In window.el tell whether functions operate on valid, live or any windows.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
52162052
MR
12012-08-16 Martin Rudalics <rudalics@gmx.at>
2
3 Consistently check windows for validity/liveness
4 (Bug#11984, Bug#12025, Bug#12026).
5 * lisp.h (CHECK_VALID_WINDOW): New macro.
6 * window.c (decode_window): Rename to decode_live_window.
7 (decode_valid_window, Fwindow_valid_p): New functions.
8 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
9 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
10 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
11 (Fwindow_prev_sibling, Fwindow_combination_limit)
12 (Fset_window_combination_limit, Fwindow_use_time)
13 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
14 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
15 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
16 (Fwindow_hscroll, Fset_window_hscroll)
17 (Fwindow_redisplay_end_trigger)
18 (Fset_window_redisplay_end_trigger, Fwindow_edges)
19 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
20 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
21 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
22 (Fwindow_end, Fset_window_point, Fset_window_start)
23 (Fpos_visible_in_window_p, Fwindow_line_height)
24 (Fwindow_dedicated_p, Fset_window_dedicated_p)
25 (Fwindow_prev_buffers, Fset_window_prev_buffers)
26 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
27 (Fset_window_parameter, Fwindow_display_table)
28 (Fset_window_display_table, Fdelete_other_windows_internal)
29 (Fset_window_buffer, Fset_window_new_total)
30 (Fset_window_new_normal, Fdelete_window_internal)
31 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
32 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
33 (Fwindow_scroll_bars): Check whether argument window is a valid or
34 live window. Update doc-strings.
35 (syms_of_window): New symbol Qwindow_valid_p.
36 * keyboard.c (Fposn_at_x_y): Check whether argument
37 frame_or_window denotes a valid window.
38
2751c80f
DA
392012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
40
41 Fix previous char table change.
42 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
43 * chartab.c (optimize_sub_char_table): Likewise.
44
032a42c8
CY
452012-08-16 Chong Yidong <cyd@gnu.org>
46
a2d19368
CY
47 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
48
032a42c8
CY
49 * xfont.c (xfont_open):
50 * xftfont.c (xftfont_open): Set the font's max_width field.
51
52 * nsfont.m (nsfont_open): Similar to the Xft backend, set
53 min_width to space_width and average_width to the average over
54 printable ASCII characters.
55 (ns_char_width): Code cleanup.
56 (ns_ascii_average_width): New utility function.
57
58 * font.h (struct font): Update comments.
59
a098c930
DA
602012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
61
032a42c8 62 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
63 * lisp.h (CSET): New macro.
64 (char_table_set_extras, char_table_set_contents)
65 (sub_char_table_set_contents): New function.
66 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
67 * syntax.c: Adjust users.
68
8be3a09c
SM
692012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
70
71 * eval.c (eval_sub): Bind lexical-binding.
72 * lread.c (Qlexical_binding): Make non-static.
73
ac4845a6
JD
742012-08-15 Jan Djärv <jan.h.d@swipnet.se>
75
ddee6515
JD
76 * nsmenu.m (popupSession): Remove.
77 (pop_down_menu): Remove endModalSession.
78 (timeout_handler:): New method.
79 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
80 Call runModalForWindow. Check timer_fired when it returns.
81 If not set, cancel timer and break out of loop.
82 Otherwise loop again, with a new timeout.
83
84 * nsterm.m: Include fcntl.h if present.
85 (fd_entry, t_readfds, inNsSelect): Remove.
86 (select_writefds, select_valid, select_timeout, selfds)
87 (select_mutex, apploopnr): Add.
88 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
89 Otherwise call kbd_buffer_store_event.
90 (ns_send_appdefined): Remove release of fd_entry.
91 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
92 Increment and decrement apploopnr.
93 (ns_select): If no file descriptors, just do a NSTimer.
94 Otherwise copy read/write masks and start select thread (fd_handler).
95 Start main loop and wait for application defined event.
96 Inform select thread to stop selecting after main loop is exited.
97 (ns_term_init): Create selfds pipe and set non-blocking.
98 Initialize select_mutex. Start the select thread (fd_handler).
99 (fd_handler:): Loop forever, wait for info from the main thread
100 to either start or stop selecting. When select returns, send
101 and appdefined event.
102 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
103 If not call kbd_buffer_store_event.
104
105 * nsterm.h (EmacsApp): fd_handler takes id argument.
106 (EmacsDialogPanel): Add timer_fired and timeout_handler.
107
ac4845a6
JD
108 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
109
eb424fe3
EZ
1102012-08-15 Eli Zaretskii <eliz@gnu.org>
111
112 * region-cache.c (move_cache_gap): Update gap_len using the actual
113 growth of the boundaries array. Do not change cache_len.
114 (Bug#12196)
115
4e6a86c6
DA
1162012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Generalize and cleanup font subsystem checks.
119 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
120 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
121 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 122
5bf192ca
DA
1232012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
124
125 * gtkutil.c (xg_get_font): Use pango_units_to_double.
126
f2045622
CY
1272012-08-15 Chong Yidong <cyd@gnu.org>
128
8be3a09c
SM
129 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
130 When using the new font chooser, use gtk_font_chooser_get_font_desc to
131 extract the font descriptor instead of just the font name.
132 In that case, return a font spec instead of a string.
f2045622
CY
133 (x_last_font_name): Move to this file from xfns.c.
134
135 * xfns.c (Fx_select_font): The return value can also be a font
136 spec. Move x_last_font_name management to gtkutil.c.
137
138 * xfaces.c: Make font weight and style symbols non-static.
139
7f6feb56
SM
1402012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
141
142 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
143 (bug#12117).
144
fecbd8ff
SM
1452012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
146
147 * alloc.c (Fgarbage_collect): Use plural form consistently.
148
9b8d5165
EZ
1492012-08-14 Eli Zaretskii <eliz@gnu.org>
150
151 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
152 iteration through the command loop. Fixes a problem whereby mouse
153 movements are ignored until the first mouse click.
154
f5d9e83a
PE
1552012-08-14 Paul Eggert <eggert@cs.ucla.edu>
156
157 Use bool, not int, for Lisp booleans.
158 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
159 makes Emacs a bit smaller and presumably a bit faster.
160 * lisp.h: Include <stdbool.h>.
161 (struct Lisp_Boolfwd, defvar_bool):
162 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
163 * regex.c [!emacs]: Include <stdbool.h>.
164 (false, true): Remove; <stdbool.h> does this for us now.
165
55802e4a
CY
1662012-08-14 Chong Yidong <cyd@gnu.org>
167
4abcdac8
CY
168 * character.c (Fcharacterp): Doc fix (Bug#12076).
169
170 * data.c (Findirect_variable): Doc fix (Bug#11040).
171
55802e4a
CY
172 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
173
174 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 175 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 176
8e99d072
BR
1772012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
178
179 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
180 (bug#12022).
181
08908aca
MR
1822012-08-14 Martin Rudalics <rudalics@gmx.at>
183
184 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
185 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
186 * minibuf.c (choose_minibuf_frame, read_minibuf):
187 * w32fns.c (x_create_tip_frame):
188 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
189 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
190
56120d6f
PE
1912012-08-14 Paul Eggert <eggert@cs.ucla.edu>
192
193 * intervals.c (offset_intervals): Remove obsolete comment.
194
67b77c0b
AS
1952012-08-14 Andreas Schwab <schwab@linux-m68k.org>
196
197 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
198
f48b82fd
GR
1992012-08-14 Gergely Risko <gergely@risko.hu>
200
201 * coding.c (decode_coding): Record buffer modification before
202 disabling undo_list (Bug#11773).
203
fd318b54
DA
2042012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
205
206 Revert and cleanup some recent overlay changes.
207 * buffer.h (enum overlay_type): Remove.
208 (buffer_get_overlays, buffer_set_overlays): Likewise.
209 (buffer_set_overlays_before, buffer_set_overlays_after):
210 New function. Adjust users.
211 (unchain_both): Add eassert.
212
41a62dd9
DA
2132012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
214
215 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
216
5884c324
PE
2172012-08-14 Paul Eggert <eggert@cs.ucla.edu>
218
219 * gtkutil.c (xg_mark_data): Don't assume C99.
220
ca06f160
JD
2212012-08-13 Jan Djärv <jan.h.d@swipnet.se>
222
223 * gtkutil.c (xg_frame_tb_info): New struct.
224 (TB_INFO_KEY): New define.
225 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
226 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
227 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
228 if not present.
229 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
230 is up to date. Otherwise store new data.
231 (free_frame_tool_bar): Free xg_frame_tb_info if present.
232
7864a3f7
DA
2332012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Use KSET for write access to Lisp_Object members of struct kboard.
236 * keyboard.h (KSET): New macro.
237 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
238 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
239 * xterm.c: Adjust users.
240
4c31be61
DA
2412012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
242
243 Use BSET for write access to Lisp_Object members of struct buffer.
244 * buffer.h (BSET): New macro.
245 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
246 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
247 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
248 * window.c, xdisp.c, xfns.c: Adjust users.
249
14ae4239
BT
2502012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
251
252 * lread.c (syms_of_lread): Initialize Vlexical_binding.
253
32bcadb4
JD
2542012-08-11 Jan Djärv <jan.h.d@swipnet.se>
255
3d29b2ce
JD
256 * nsterm.m (not_in_argv): New function.
257 (application:openFile, application:openTempFile:):
258 (application:openFileWithoutUI:, application:openFiles:): Open file
259 if not_in_argv returns non-zero (bug#12171).
260
32bcadb4 261 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
262 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
263 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
264 (xg_get_font_name): Use those functions/macros here.
265 Reported by Frans Oilinki <moilinki@gmail.com>.
266
9ff9402d 2672012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
268
269 * unexmacosx.c (copy_data_segment): Copy initialized data in
270 statically linked libraries from input file rather than memory.
271
db74a5fc
YM
272 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
273 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
274 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
275
25e65510
GM
2762012-08-10 Glenn Morris <rgm@gnu.org>
277
278 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
279 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
280
7961135c
DA
2812012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
282
283 Fix last change to allow compilation with low optimization levels.
284 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
285 Reported by Jan Djärv <jan.h.d@swipnet.se>.
286
42b3a444
DA
2872012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
288
289 Use common inline syntax in intervals.h.
290 * intervals.h (INTERVALS_INLINE): New macro.
291 Change all users from LISP_INLINE.
292
9fb0c957
DA
2932012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Define Qnone once for all platforms.
296 * frame.c (Qnone): Define here.
297 (syms_of_frame): DEFSYM it.
298 * lisp.h (Qnone): New declaration.
299 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
300 * xfns.c: Remove duplication. Adjust users.
301
65e8ee52
DA
3022012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
303
304 Remove unused macros from intervals.h.
305 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
306 * intervals.c: Adjust comment.
307
9b855fd6
EZ
3082012-08-10 Eli Zaretskii <eliz@gnu.org>
309
310 * w32fns.c <w32_unicode_gui>: New static variable.
311 (globals_of_w32fns): Initialize it according to os_subtype.
312 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
313 testing os_subtype.
314
39cb9e56 3152012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
316 Eli Zaretskii <eliz@gnu.org>
317
318 Fix bug #10299 with Unicode characters sent by customized
319 keyboards created by MSKLC.
320 * w32fns.c (INIT_WINDOW_CLASS): New macro.
321 (w32_init_class): Use it to initialize the Emacs class with either
322 ANSI or Unicode API calls.
323 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
324 later.
325 (w32_wnd_proc): If the character code sent by WM_CHAR or
326 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
327 original message. Call DefWindowProcW on NT and later.
328
9374581a
GM
3292012-08-10 Glenn Morris <rgm@gnu.org>
330
4b94e8cf
GM
331 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
332
9374581a
GM
333 * lisp.h (DIRECTORY_SEP): Let configure set it.
334
a2752828
DA
3352012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
336
337 Use TSET for write access to Lisp_Object slots of struct terminal.
338 * termhooks.h (TSET): New macro.
339 * coding.c, terminal.c, xselect.c: Adjust users.
340
cc92c454
SM
3412012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
342
343 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
344 the failing expression, include them in the error message.
345 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
346 * lisp.h (internal_condition_case_n): Update declaration.
347
4cb3e6b3
DA
3482012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
349
350 Inline functions to examine and change buffer overlays.
351 * buffer.c (unchain_both): New function.
352 * buffer.h (buffer_get_overlays, buffer_set_overlays):
353 (buffer_has_overlays): New function.
354 (enum overlay_type): New enum.
355 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
356 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
357
8707c1e5
DA
3582012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
359
360 Inline functions to examine and change buffer intervals.
361 * alloc.c (mark_interval_tree): Remove.
362 (MARK_INTERVAL_TREE): Simplify.
363 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
364 * intervals.c (buffer_balance_intervals): New function.
365 (graft_intervals_into_buffer): Adjust indentation.
366 (set_intervals_multibyte): Simplify.
367 * buffer.h (BUF_INTERVALS): Remove.
368 (buffer_get_intervals, buffer_set_intervals): New function.
369 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
370 * intervals.c, textprop.c: Adjust users.
371
ad8c997f
DA
3722012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
373
374 Inline functions to examine and change string intervals.
375 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
376 (string_get_intervals, string_set_intervals): New function.
377 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
378 * lread.c, print.c, textprop.c: Adjust users.
379
32ac3a6b
GM
3802012-08-08 Glenn Morris <rgm@gnu.org>
381
382 * lisp.mk (lisp): Remove language/persian.elc.
383
77c7bcb1
DA
3842012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
385
386 Cleanup intervals.
387 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
388 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
389 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
390 Adjust comment. Move under #if 0.
77c7bcb1
DA
391 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
392 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
393
9c08a8d4
DA
3942012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
395
396 Check total length of intervals with eassert.
397 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
398 * intervals.c: Change all users to eassert.
399
26d16b35
EZ
4002012-08-07 Eli Zaretskii <eliz@gnu.org>
401
14ae4239
BT
402 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
403 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
404 INTERNAL_FIELD in Lisp_Cons.
405
c644523b
DA
4062012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
407
408 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
409 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
410 name since all xname users are fixed long time ago. Do not
411 use INTERNAL_FIELD.
412 (set_symbol_name, set_symbol_function, set_symbol_plist):
413 (set_symbol_next, set_overlay_plist): New function.
414 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
415 (struct Lisp_Overlay): Likewise.
416 (CVAR, MVAR, SVAR): Remove.
417 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
418 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
419 * xterm.c: Adjust users.
420 * .gdbinit: Change to use name field of struct Lisp_Symbol
421 where appropriate.
422
6a3d20cc
DA
4232012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
424
425 Basic functions to set Lisp_Object and pointer slots of intervals.
426 * intervals.h (interval_set_parent, interval_set_object):
427 (interval_set_left, interval_set_right, interval_set_plist):
428 (interval_copy_parent): New function.
429 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
430 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
431 Adjust indentation.
6a3d20cc
DA
432 (INTERVAL_SIZE): Remove. Adjust users.
433 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
434
4d2b044c
DA
4352012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
436
437 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
438 * process.h (PGET): Remove.
439 (struct Lisp_Process): Do not use INTERNAL_FIELD.
440 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
441
d3d50620
DA
4422012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
443
444 Drop WGET and revert read access to Lisp_Objects slots of struct window.
445 * window.h (WGET): Remove.
446 (struct window): Do not use INTERNAL_FIELD.
447 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
448 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
449 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
450 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
451 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
452 Adjust users.
453
d10a51dc
CY
4542012-08-07 Chong Yidong <cyd@gnu.org>
455
456 * window.c (Fwindow_edges, Fwindow_pixel_edges)
457 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
458 (Fdelete_window_internal): Signal an error if the window is not on
459 a live frame (Bug#12025).
460
e69b0960
DA
4612012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
462
463 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
464 * frame.h (FGET): Remove.
465 (struct frame): Do not use INTERNAL_FIELD.
466 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
467 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
468 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
469 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
470
25a20a3a
JB
4712012-08-06 Juanma Barranquero <lekktu@gmail.com>
472
473 * w32.c: Silence compiler warnings.
474 (map_w32_filename): Remove unused variable `is_fat'.
475 (chase_symlinks): Add parentheses around expression.
476
1c6f11f4
GM
4772012-08-06 Glenn Morris <rgm@gnu.org>
478
1db4583a
GM
479 * sysdep.c: Respect BROKEN_GETWD.
480
1c6f11f4
GM
481 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
482 Let configure handle it.
483 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
484
2b90362b
DA
4852012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Use GCALIGNMENT where appropriate.
488 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
489 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
490 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
491
5f50daf2
EZ
4922012-08-06 Eli Zaretskii <eliz@gnu.org>
493
14ae4239
BT
494 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
495 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 496
cbcc7007
SM
4972012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
498
499 * buffer.h (struct buffer): Revert `indirections' to a simple int;
500 that should be sufficient for everyone.
501
4d365fa4
JD
5022012-08-06 Jan Djärv <jan.h.d@swipnet.se>
503
504 * keyboard.c (timer_check_2): Add break so timer_check returns next
505 timeout.
506
dd86bd82
DA
5072012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
508
509 Fix Windows build errors introduced after converting to WGET and WSET.
510 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
511 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
512
054e1668
JD
5132012-08-06 Jan Djärv <jan.h.d@swipnet.se>
514
515 * nsterm.m (ns_frame_rehighlight): Use FSET.
516
517 * nsmenu.m (ns_update_menubar): Use FSET.
518
21238f11
DA
5192012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
520
521 Separate read and write access to Lisp_Object slots of Lisp_Process.
522 * process.h (PGET, PSET): New macros similar to AREF and ASET.
523 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
524
077288cf
DA
5252012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
526
527 Separate read and write access to Lisp_Object slots of struct window.
528 * window.h (WGET, WSET): New macros similar to AREF and ASET.
529 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
530 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
531 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
532 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
533 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
534 Adjust users.
535
71688bd7
DA
5362012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Fix Windows build errors introduced after converting to FGET and FSET.
539 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
540 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
541 (w32_judge_scroll_bars): Change to use FSET.
542 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
543
f99bac93
DA
5442012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Fix replacement typo.
547 * window.c (replace_window): Set root_window instead of
548 selected_window. This fixes a total window subsystem
549 malfunction reported by Bastien Guerry <bzg@gnu.org>.
550
8c2a0f2d
GM
5512012-08-06 Glenn Morris <rgm@gnu.org>
552
553 * lisp.mk (lisp): Add language/persian.elc.
554
edd74c35
DA
5552012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
556
557 Separate read and write access to Lisp_Object slots of struct frame.
558 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
559 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
560 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
561 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
562 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
563
8671676c
AS
5642012-08-05 Andreas Schwab <schwab@linux-m68k.org>
565
566 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
567
663e2b3f
DA
5682012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
569
570 Generalize common compile-time constants.
571 * lisp.h (header_size, bool_header_size, word_size): Now here.
572 (struct Lisp_Vector): Add comment.
573 (struct Lisp_Bool_Vector): Move up to define handy constants.
574 (VECSIZE, PSEUDOVECSIZE): Simplify.
575 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
576 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
577 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
578 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
579 * xfont.c, xmenu.c: Use word_size where appropriate.
580
d32e47af
LM
5812012-08-05 Lawrence Mitchell <wence@gmx.li>
582
583 * search.c (Freplace_match): Treat \? in the replacement text
584 literally (Bug#8161).
585
e5d9c0d1
CY
5862012-08-05 Chong Yidong <cyd@gnu.org>
587
588 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
589 * frame.c (Vdelete_frame_functions):
590 * emacs.c (Vkill_emacs_hook): Doc fix.
591
8da0576b
EZ
5922012-08-04 Eli Zaretskii <eliz@gnu.org>
593
594 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
595 --with-x-toolkit=no builds.
596 Reported by Carsten Mattner <carstenmattner@gmail.com>.
597
02676e5d
CY
5982012-08-04 Chong Yidong <cyd@gnu.org>
599
600 * syntax.c (Fmodify_syntax_entry): Doc fix.
601
97147da9
EZ
6022012-08-04 Eli Zaretskii <eliz@gnu.org>
603
76151e2c
EZ
604 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
605 * w32.c (init_environment): Change the default values of many
606 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
607 them into environment when they were not already defined.
608 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 609 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
610 (check_windows_init_file): Now external, not static.
611 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
612 called when Vload_path is already set up.
613
614 * w32.h (check_windows_init_file): Add prototype.
615
616 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
617 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
618 compatibility with Posix platforms.
619 (main): Move the call to check_windows_init_file to here from
620 w32.c.
621 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
622 any, in the DEFALT argument into the root of the Emacs build or
623 installation tree, as appropriate.
624
625 * callproc.c (init_callproc_1): Call decode_env_path instead of
626 doing its equivalent by hand.
627 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
628 the code that sets Vexec_path run on MS-Windows.
629
630 * lread.c (init_lread): Add comments to #ifdef's.
631
97147da9
EZ
632 * msdos.c (dos_set_window_size, IT_update_begin)
633 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
634 instead of direct references.
635
185ee146
PE
6362012-08-04 Paul Eggert <eggert@cs.ucla.edu>
637
638 Export DEFAULT_REHASH_* to GDB.
639 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
640 Now constants, not macros.
641
8834c57a
PE
6422012-08-03 Paul Eggert <eggert@cs.ucla.edu>
643
98c6f1e3
PE
644 Remove unnecessary casts involving pointers.
645 These casts are no longer needed now that we assume C89 or later,
646 since they involve casting to or from void *.
647 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
648 (make_pure_float, make_pure_vector):
649 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
650 * macros.c (Fstart_kbd_macro):
651 * menu.c (find_and_return_menu_selection):
652 * minibuf.c (read_minibuf_noninteractive):
653 * sysdep.c (closedir):
654 * xdisp.c (x_produce_glyphs):
655 * xfaces.c (compare_fonts_by_sort_order):
656 * xfns.c (x_real_positions, select_visual):
657 * xselect.c (x_stop_queuing_selection_requests)
658 (x_get_window_property, x_get_window_property_as_lisp_data):
659 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
660 Remove unnecessary pointer casts.
661 * alloc.c (record_xmalloc): New function.
662 * lisp.h (record_xmalloc): New decl.
663 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
664 more like a function. This is because the pointer cast is not
665 needed. All uses changed.
666 * print.c (print_string, print_error_message): Avoid length recalc.
667
8834c57a
PE
668 Improve fix for macroexp crash with debugging (Bug#12118).
669 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
670 ARRAY_MARK_FLAG when checking subscripts, because ASET is
671 not supposed to be invoked from the garbage collector.
672 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
673 (gc_aset): New function, which is like ASET but can be
674 used in the garbage collector.
675 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
676 (set_hash_index): Use it instead of ASET.
677
6dad7178
EZ
6782012-08-03 Eli Zaretskii <eliz@gnu.org>
679
680 Support symlinks on latest versions of MS-Windows.
681 * w32.c: Include winioctl.h and aclapi.h.
682 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
683 (revert_to_self): Forward declarations of static functions.
684 <static BOOL g_b_init_get_security_info>:
685 <g_b_init_create_symbolic_link>: New static flags.
686 (globals_of_w32): Initialize them to zero.
687 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
688 (map_w32_filename): Improve commentary. Simplify switch.
689 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
690 headers (most versions of MinGW w32api don't).
691 (get_security_info, create_symbolic_link)
692 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
693 New functions.
694 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
695 in the argument file name.
696 (sys_access): Call unc_volume_file_attributes only if
697 GetFileAttributes fails with network-related error codes.
698 (sys_rename): Diagnose renaming of a symlink when the user doesn't
699 have the required privileges.
14ae4239 700 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
701 get_file_security_desc.
702 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
703 with addition of handling of symlinks and support for 'lstat'.
704 If possible, get file's attributes and security information by
6dad7178
EZ
705 handle, not by name. Produce S_IFLNK bit for symlinks, when
706 called from 'lstat'.
707 (stat, lstat): New functions, call 'stat_worker'.
708 (symlink, readlink, careadlinkat): Rewritten to create and resolve
709 symlinks when the underlying filesystem supports them.
710
f162bcc3
PE
7112012-08-02 Paul Eggert <eggert@cs.ucla.edu>
712
79ea6c20
PE
713 Fix macroexp crash on Windows with debugging (Bug#12118).
714 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
715 checking subscripts; problem introduced with the recent
716 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
717 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
718 since it's used in non-static inline functions now.
719
c0ce93fd
PE
720 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
721 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 722
f162bcc3
PE
723 Use C99-style 'extern inline' if available.
724 * buffer.h (BUFFER_INLINE):
725 * category.h (CATEGORY_INLINE):
726 * character.h (CHARACTER_INLINE):
727 * charset.h (CHARSET_INLINE):
728 * composite.h (COMPOSITE_INLINE):
729 * dispextern.h (DISPEXTERN_INLINE):
730 * lisp.h (LISP_INLINE):
731 * systime.h (SYSTIME_INLINE):
732 New macro, replacing 'static inline' in this header.
733 * buffer.h, category.h, character.h, charset.h, composite.h:
734 * dispextern.h, lisp.h, systime.h:
735 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
736 * alloc.c (LISP_INLINE):
737 * buffer.c (BUFFER_INLINE):
738 * category.c (CATEGORY_INLINE):
739 * character.c (CHARACTER_INLINE):
740 * charset.c (CHARSET_INLINE):
741 * composite.c (COMPOSITE_INLINE):
742 * dispnew.c (DISPEXTERN_INLINE):
743 * sysdep.c (SYSTIME_INLINE):
744 Define to EXTERN_INLINE, so that the corresponding functions
745 are compiled into code.
746 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
747 (INLINE_HEADER_END): New macros.
748 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
749 since it's used in non-static inline functions now.
a8333d03 750 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 751
837b365b
GM
7522012-08-02 Glenn Morris <rgm@gnu.org>
753
d66b744d
GM
754 * s/: Remove empty directory.
755
837b365b
GM
756 * s/ms-w32.h: Move to ../nt/inc.
757 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
758 Update for new ms-w32.h location.
759
13294f95
PE
7602012-08-02 Paul Eggert <eggert@cs.ucla.edu>
761
762 Port to Solaris 8.
763 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
764
90df0db3
GM
7652012-08-02 Glenn Morris <rgm@gnu.org>
766
767 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
768 hard-coding the path separator.
769
4939150c
PE
7702012-08-01 Paul Eggert <eggert@cs.ucla.edu>
771
772 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
773 This how ASET and AREF are supposed to work, and makes
774 it easier to think about future improvements. See
775 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
776 * charset.h (set_charset_attr): New function.
777 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
778 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
779 (aref_addr): New function. All uses of &AREF(...) changed.
780 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
781 (set_hash_index): New functions. All lvalue-style uses of
782 HASH_KEY etc. changed.
783 * keyboard.c (set_prop): New function. All lvalue-style uses
784 of PROP changed.
785
947b2afd
AA
7862012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
787
788 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
789 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
790 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
791 * nsfns.m (ns_set_name_as_filename): Likewise.
792 * nsmenu.m (ns_update_menubar): Likewise.
793 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
794
4f5d0325
EZ
7952012-08-01 Eli Zaretskii <eliz@gnu.org>
796
2008beae
EZ
797 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
798 Adapt to latest changes in field names of the corresponding Lisp
288479f6 799 objects.
2008beae 800
4f5d0325
EZ
801 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
802
fe3cc771
GM
8032012-08-01 Glenn Morris <rgm@gnu.org>
804
805 * s/msdos.h: Remove file.
806 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
807 * Makefile.in (S_FILE): Remove.
808 (config_h): Remove S_FILE.
809
c90acc54
JB
8102012-08-01 Juanma Barranquero <lekktu@gmail.com>
811
812 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
813 Remove; moved to nt/config.nt.
814
d8a05828
DA
8152012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Use INTERNAL_FIELD for conses and overlays.
818 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
819 Remove obsolete comment.
820 (MVAR): New macro.
821 (struct Lisp_Overlay): Use INTERNAL_FIELD.
822 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
823
8271d590
DA
8242012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
825
826 Use INTERNAL_FIELD for symbols.
827 * lisp.h (SVAR): New macro. Adjust users.
828 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
829 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
830
3193acd2
DA
8312012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
832
833 Use INTERNAL_FIELD for processes.
834 * process.h (PVAR): New macro. Adjust style.
835 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
836 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
837
3a45383a
DA
8382012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
839
840 Use INTERNAL_FIELD for windows.
841 * window.h (WVAR): New macro.
842 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
843 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
844 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
845 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
846 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
847 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
848
c1dbc63c
PE
8492012-08-01 Paul Eggert <eggert@cs.ucla.edu>
850
851 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
852
5c0c0e8a
GM
8532012-08-01 Glenn Morris <rgm@gnu.org>
854
855 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
856 Move to configure.ac.
857
552a99b4
JB
8582012-08-01 Juanma Barranquero <lekktu@gmail.com>
859
860 * makefile.w32-in (CONFIG_H): Update dependencies.
861 (CONF_POST_H): New macro.
862
863 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
864
8d8e2dfe
GM
8652012-07-31 Glenn Morris <rgm@gnu.org>
866
bc96620a
GM
867 * Makefile.in (S_FILE): No longer set by configure.
868
476b1b2d
GM
869 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
870 is available.
871 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
872
b2c7a106
GM
873 * process.h (NULL_DEVICE):
874 * emacs.c (SEPCHAR):
875 * editfns.c (USER_FULL_NAME): Let configure set them.
876
d53d062a
GM
877 * s/README, s/template.h: Remove files.
878
4515017f
GM
879 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
880
8d8e2dfe
GM
881 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
882 Move to configure.ac.
883
5b20b3cc
EZ
8842012-07-31 Eli Zaretskii <eliz@gnu.org>
885
1e0afd9a
EZ
886 * .gdbinit (xframe): Adapt to introduction of FVAR and the
887 resulting renaming of 'struct frame' members.
888
5b20b3cc
EZ
889 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
890
891 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
892 after introduction of FVAR.
893
f1310128
JD
8942012-07-31 Jan Djärv <jan.h.d@swipnet.se>
895
79e721e0
JD
896 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
897
898 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
899 instead of compositeToPoint.
900 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
901
8d7c7eed 902 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 903
e34f7f79
DA
9042012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
905
906 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
907 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 908 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
909 (BVAR): Change to use INTERNAL_FIELD.
910 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
911 (KVAR): Change to use INTERNAL_FIELD.
912 * frame.h (FVAR): New macro.
913 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
914 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
915 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
916 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
917 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
918
c09bfb2f
DA
9192012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
920
921 Miscellaneous fixes for non-default X toolkits.
922 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
923 * xterm.c (x_frame_of_widget): Remove redundant prototype.
924 Move under #ifdef USE_LUCID.
925 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
926 definition and usage to avoid warnings.
927
14c114ae
JD
9282012-07-31 Jan Djärv <jan.h.d@swipnet.se>
929
930 * nsterm.m (openFiles): Fix previous checkin.
931
3bd21e82
PE
9322012-07-31 Paul Eggert <eggert@cs.ucla.edu>
933
934 * indent.c (compute_motion): Remove unused local.
935
c1529ded
GM
9362012-07-31 Glenn Morris <rgm@gnu.org>
937
400d5621
GM
938 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
939
268e2432
GM
940 * conf_post.h [USG5_4]:
941 Move remaining contents of s/usg5-4-common.h here.
942 * s/usg5-4-common.h: Remove file.
943
7552f3ee
GM
944 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
945 * s/irix6-5.h: Remove file.
946
6a381852
GM
947 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
948 * s/darwin.h: Remove file.
949
c1529ded
GM
950 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
951 * s/hpux10-20.h: Remove file, which is now empty.
952
b429a4ee
GM
9532012-07-30 Glenn Morris <rgm@gnu.org>
954
955 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
956 * Makefile.in (config_h): Add conf_post.h.
957 * makefile.w32-in (CONFIG_H): Add conf_post.h.
958
adff3182
JD
9592012-07-30 Jan Djärv <jan.h.d@swipnet.se>
960
961 * nsterm.m (ns_do_open_file): New variable.
b9031d69 962 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
963 (openFile, openTempFile, openFileWithoutUI, openFiles):
964 Open files only if ns_do_open_file.
adff3182 965
c32af1e4
PE
9662012-07-30 Paul Eggert <eggert@cs.ucla.edu>
967
7393bcbb
PE
968 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
969 This no-op macro hasn't been needed for many years.
970 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
971
c32af1e4
PE
972 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
973 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
974 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
975 gdb_make_enums_visible.
976 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
977 (DIRECTORY_SEP): Now a constant, not a macro.
978
302fc036
EZ
9792012-07-30 Eli Zaretskii <eliz@gnu.org>
980
981 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
982 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
983
984 * w32term.c <w32_keyboard_codepage>: Renamed from
985 keyboard_codepage and now external. All users changed.
986
987 * w32term.h: Add declaration of w32_keyboard_codepage.
988
989 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
990 the codepage to translate keys to Unicode. If this argument is
991 -1, use the value returned by GetConsoleCP. All callers changed.
992
88fb40b4
PE
9932012-07-30 Paul Eggert <eggert@cs.ucla.edu>
994
0aee6912
PE
995 Update .PHONY listings in makefiles.
996 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
997 bootstrap-clean, distclean, maintainer-clean, versioclean,
998 extraclean, frc.
999
88fb40b4
PE
1000 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
1001 This is a bit clearer. Fix some commentary typos.
1002
0a763bd1
GM
10032012-07-30 Glenn Morris <rgm@gnu.org>
1004
32bac6d6
GM
1005 * s/netbsd.h: Let configure include signal.h if needed.
1006 Remove file, which is now empty.
1007
b65e7c46
GM
1008 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
1009 Let configure set them.
1010 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
1011 No more need to undefine.
0a763bd1 1012
169304bd
AS
10132012-07-30 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * keymap.c (Fkey_description): Don't remove 0x80 bit from
1016 non-single-byte char when adding meta modifier. (Bug#12090)
1017
6cd7a139
DA
10182012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1019
1020 Convert safe_call to use variable number of arguments.
1021 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
1022 (safe_call2): Fix comment.
1023 * lisp.h (safe_call): Adjust prototype.
1024 * coding.c (encode_coding_object): Change to use safe_call2.
1025 * xfaces.c (merge_face_heights): Change to use safe_call1.
1026
d34d6ffc
GM
10272012-07-30 Glenn Morris <rgm@gnu.org>
1028
7b8a48e4 1029 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 1030 does that unconditionally. Remove file, which is now empty.
7b8a48e4 1031
d34d6ffc
GM
1032 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
1033 Remove empty files.
1034
03a660a6
PE
10352012-07-30 Paul Eggert <eggert@cs.ucla.edu>
1036
1037 Export to GDB most of lisp.h's remaining object-like macros.
1038 * lisp.h (min, max): Move earlier, because they're used earlier now.
1039 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
1040 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
1041 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
1042 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
1043 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
1044 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
1045 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
1046 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
1047 Now constants, for GDB. They need not be macros.
1048 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
1049 Now constants, for GDB, as well as macros, for static initializers.
1050 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
1051 Move to after the definition of struct Lisp_Char_Table,
1052 since the former now needs that type defined.
1053 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
1054 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
1055 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
1056 New enums, for gdb_make_enums_visible.
1057 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 1058 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
1059 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
1060 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
1061 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
1062 enum maxargs, enum MAX_ALLOCA.
1063 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
1064 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
1065 no longer needed, now that they are done in lisp.h.
1066
e499d0ee
DA
10672012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 Cleanup string bytes checking.
1070 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
1071 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
1072 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
1073 (check_sblock, compact_small_strings): Simplify.
1074
d5040d2d
PE
10752012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
1078 These macros are confusing and no longer need to be defined, as
1079 the enum values now suffice. All uses replaced with definiens.
1080 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
1081
7f259ae6
JB
10822012-07-29 Juanma Barranquero <lekktu@gmail.com>
1083
1084 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
1085 ($(BLD)/w32console.$(O)): Update dependencies.
1086
7e63e0c3
DA
10872012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
1090 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
1091 time. Adjust users.
1092 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
1093
ffd817eb
JD
10942012-07-29 Jan Djärv <jan.h.d@swipnet.se>
1095
1096 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
1097 setting sitelisp (Bug#12010).
1098
417a7a0e
EZ
10992012-07-29 Eli Zaretskii <eliz@gnu.org>
1100
14ae4239 1101 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
1102
1103 * w32heap.c (cache_system_info):
1104 * w32.c (sys_rename):
1105 * w32proc.c (find_child_console, sys_kill): All users changed.
1106
387d4d92
PE
11072012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1108
1109 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
1110
55a6cca6
EZ
11112012-07-29 Eli Zaretskii <eliz@gnu.org>
1112
1113 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
1114
dbcf001c
DA
11152012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1116
1117 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1118 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1119 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1120
e2688e4a
DA
11212012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1124 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1125 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1126 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1127 (replace_range, replace_range_2, del_range_2): Change to eassert.
1128 * marker.c (byte_char_debug_check): Adjust style.
1129
b46a6a83
PE
11302012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1133 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1134 long-ago-commented-out code that talks about "WIN32".
1135 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1136 All uses changed.
1137
e32a5799
PE
11382012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1139
1140 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1141 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1142 Simplify by using alignof.
1143 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1144 * lisp.h: Include <stdalign.h>.
1145 (GCALIGNMENT): New macro and constant.
1146 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1147 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1148 (stdalign): New macro, if not already defined.
1149
df81cd29
EZ
11502012-07-28 Eli Zaretskii <eliz@gnu.org>
1151
01bd1b0d
EZ
1152 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1153 * w32inevt.c: Include w32inevt.h.
1154 (w32_read_console_input): New inline function, calls either
1155 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1156 w32_console_unicode_input.
1157 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1158 (w32_kbd_patch_key, key_event): Use the codepage returned by
1159 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1160 (key_event): use uChar.UnicodeChar only if
1161 w32_console_unicode_input is non-zero.
1162
1163 * w32console.c: Include w32heap.h.
1164 <w32_console_unicode_input>: New global variable.
1165 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1166 family of Windows, zero otherwise.
1167
1168 * w32inevt.h: Declare w32_console_unicode_input.
1169
df81cd29
EZ
1170 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1171 --without-x. (Bug#11742)
1172
c20fdd9e
PE
11732012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 Adjust GDB to reflect pvec_type changes (Bug#12036).
1176 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1177 2012-07-04 changes to pseudovector representation.
1178 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1179
32770973 11802012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1181
1182 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1183 bus address.
1184 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1185
3438fe21
EZ
11862012-07-27 Eli Zaretskii <eliz@gnu.org>
1187
bcfbc9de
EZ
1188 * alloc.c (listn): Fix the order the arguments are consed onto the
1189 list.
1190
3438fe21
EZ
1191 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1192 enumeration constants, as PURE and HEAP are too general, and clash
1193 with other headers and sources, such as gmalloc.c and the
1194 MS-Windows system headers. All users changed.
1195
eeaea515
DA
11962012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 Revert last save_excursion_save and save_excursion_restore changes.
1199 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1200 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1201
073c88c2
DA
12022012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 Fix recently-introduced typos in Windows port.
1205 Reported by Martin Rudalics <rudalics@gmx.at>.
1206 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1207 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1208
4706125e
PE
12092012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 Improve GDB symbol export (Bug#12036).
1212 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1213 arms of an 'if', not using conditional expressions; otherwise GDB
1214 complains about the types in the unevaluated arm when the argument
1215 is an integer literal.
1216 (xgetint): Simplify expression.
1217 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1218 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1219 Zaretskii in <http://bugs.gnu.org/12036#13>.
1220 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1221 needed now that we have gdb_make_enums_visible.
1222 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1223 (enum enum_USE_LSB_TAG):
1224 New enum types, packaging up enums that need to be exported to GDB.
1225
694b6c97
DA
12262012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 Utility function to make a list from specified amount of objects.
1229 * lisp.h (enum constype): New datatype.
1230 (listn): New prototype.
1231 * alloc.c (listn): New function.
1232 (Fmemory_use_count, syms_of_alloc): Use it.
1233 * buffer.c (syms_of_buffer): Likewise.
1234 * callint.c (syms_of_callint): Likewise.
1235 * charset.c (define_charset_internal): Likewise.
1236 * coding.c (syms_of_coding): Likewise.
1237 * keymap.c (syms_of_keymap): Likewise.
1238 * search.c (syms_of_search): Likewise.
1239 * syntax.c (syms_of_syntax): Likewise.
1240 * w32.c (init_environment): Likewise.
1241 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1242 * xdisp.c (syms_of_xdisp): Likewise.
1243 * xfns.c (syms_of_xfns): Likewise.
1244
6195f384
DA
12452012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1246
1247 Fast save_excursion_save and save_excursion_restore.
1248 * lisp.h (struct Lisp_Excursion): New data type.
1249 (PVEC_EXCURSION): New pseudovector type.
1250 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1251 to deal with it. Adjust comments.
1252 (init_marker, attach_marker): New prototype.
1253 (unchain_marker): Adjust prototype.
1254 * marker.c (attach_marker): Change to global.
1255 (init_marker): New function.
1256 * alloc.c (Fmake_marker, build_marker): Use it.
1257 (build_marker): More easserts.
1258 (mark_object): Handle struct Lisp_Excursion.
1259 * editfns.c (save_excursion_save, save_excursion_restore):
1260 Reimplement to use struct Lisp_Excursion. Add comments.
1261
5eceb8fb
PE
12622012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 Fix export of symbols to GDB (Bug#12036).
1265 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1266 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1267 emacs.c, as this is a more-suitable home. Had this been done earlier
1268 the fix for 12036 would have avoided some of the problems noted in
1269 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1270 would have been more obvious.
562157c8
PE
1271 * emacs.c: Do not include <verify.h>; no longer needed.
1272 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1273 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1274 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1275 Remove; now done in lisp.h.
1276 * lisp.h (PUBLISH_TO_GDB): New macro.
1277 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1278 (DATA_SEG_BITS): Use it.
1279 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1280 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1281 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1282 not be usable in #if. This simplifies things.
1283
d6749401
JB
12842012-07-26 Juanma Barranquero <lekktu@gmail.com>
1285
1286 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1287
1781b9e9
PE
12882012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1289
d89518db 1290 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1291 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1292 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1293 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1294 Adjust to changes in lisp.h and emacs.c, by using
1295 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1296 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1297 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1298 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1299 instead of gdb_valbits.
1300 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1301 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1302 instead of gdb_array_mark_flag.
1303 (xboolvector): Get size from $->size, not $->header.size.
1304 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1305 (xreload, hook-run, hookpost-run): Remove.
1306 * emacs.c: Include <verify.h>.
1307 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1308 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1309 Remove.
1310 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1311 (gdb_USE_LSB_TAG): New enum constants.
1312 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1313 Also define these as enum constants, so they're visible to GDB.
1314 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1315 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1316 as constants, so they're visible to GDB.
1317 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1318 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1319 Now enum constants, not macros, so they're visible to GDB.
1320 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1321 more convenient now. All uses changed.
1322 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1323 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1324
3628596a
DA
13252012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1326
1327 Explicitly free restriction data that are not needed anymore.
1328 * editfns.c (save_restriction_restore): Free restriction data.
1329
7abaf5cc
SM
13302012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1331
1332 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1333 add argument, tune behavior, and adjust all callers.
1334
71f88e00
PE
13352012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1336
1337 Use typedef for EMACS_INT, EMACS_UINT.
1338 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1339 than macros. This simplifies debugging in the usual case, since
1340 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1341 and it allows expressions involving EMACS_INT casts.
1342 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1343
57ec3034
JD
13442012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1345
1346 * nsterm.m (ns_read_socket): Return early if there is a modal
1347 window (Bug#12043).
1348
8137e7b3
MR
13492012-07-25 Martin Rudalics <rudalics@gmx.at>
1350
1351 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1352 that FOCUS-FRAME can be omitted.
1353
04e9897c
DA
13542012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Adjust buffer text indirection counters at the end of Fkill_buffer.
1357 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1358 buffer is definitely dead. This should really fix an issue reported
1359 by Christoph Scholtes again. (Bug#12007).
1360 (init_buffer_once): Initialize indirection counters of
1361 buffer_defaults and buffer_local_symbols (for sanity and safety).
1362
8a0484e1
EZ
13632012-07-24 Eli Zaretskii <eliz@gnu.org>
1364
1365 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1366 and continuation glyphs on tooltip frames, leave them at zero.
1367 Avoids continued lines in tooltips. (Bug#11832)
1368
fa691a83
DA
13692012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 Simplify copy_overlay.
04e9897c 1372 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1373 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1374
436bc8e0
EZ
13752012-07-23 Eli Zaretskii <eliz@gnu.org>
1376
1377 * print.c (print_object): Don't crash when a frame's name is nil
1378 or invalid. (Bug#12025)
1379
1380 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1381 it signals an error when a tooltip frame is being created.
1382
d7a7fda3
DA
13832012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Cleanup miscellaneous objects allocation and initialization.
1386 * alloc.c (allocate_misc): Change to static. Add argument to
1387 specify the subtype. Adjust comment and users.
1388 (build_overlay): New function.
1389 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1390 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1391 (allocate_misc): Remove prototype.
1392 (build_overlay): Add prototype.
1393
13942012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1395
1396 Swap buffer text indirection counters in Fbuffer_swap_text.
1397 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1398 This avoids crash reported by Christoph Scholtes at
1399 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1400
9d7fa573
JD
14012012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1402
1403 * nsmenu.m (Popdown_data): New struct.
1404 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1405 free Popdown_data.
1406 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1407 (initWithContentRect): Make imgView and contentView non-static
1408 and autorelease them. Also autorelease img and matrix (Bug#12005).
1409 (dealloc): Remove (Bug#12005).
1410
0dd6d66d
DA
14112012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 Adjust consing_since_gc when objects are explicitly freed.
1414 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1415 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1416 (free_cons, free_misc): Subtract object size from consing_since_gc.
1417
d36d71df
DA
14182012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1419
1420 Simplify and cleanup markers positioning code.
1421 * marker.c (attach_marker): More useful eassert.
1422 (live_buffer, set_marker_internal): New function.
1423 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1424 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1425
fb9ea40f
PE
14262012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1429 as it's limited by the amount of memory, not by INT_MAX.
1430
2d5c5f7d
EZ
14312012-07-21 Eli Zaretskii <eliz@gnu.org>
1432
07fb592e
EZ
1433 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1434 in special-event-map. See the discussion at
1435 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1436 for the reasons.
1437
37a9eac8 1438 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1439 info.dwItemData. Fixes crashes on 64-bit Windows.
1440 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1441
c4328746
JD
14422012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1443
1444 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1445 (conversationIdentifier): Return value is NSInteger.
784051c4 1446 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1447
6e5d1c12
CY
14482012-07-21 Chong Yidong <cyd@gnu.org>
1449
1450 * window.c (decode_any_window): Signal an error if the window is
1451 on a dead frame (Bug#11984).
1452
9928463d
DA
14532012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1454
1455 Add indirection counting to speed up Fkill_buffer.
1456 * buffer.h (struct buffer): New member.
1457 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1458 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1459 base buffer indirection counter.
1460 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1461 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1462 through buffer list if indirection counter is 0.
1463
f8643a6b
DA
14642012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1465
1466 Extend the value returned by Fgarbage_collect with heap statistics.
1467 * alloc.c (Qheap): New symbol.
1468 (syms_of_alloc): DEFSYM it.
1469 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1470 (Fmemory_free): Remove.
1471 (syms_of_alloc): Don't defsubr it.
1472 * buffer.c (Fcompact_buffer): Remove.
1473 (syms_of_buffer): Don't defsubr it.
1474
dac616ff
DA
14752012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1476
1477 Make maybe_gc inline.
1478 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1479 * lisp.h (consing_since_gc, gc_relative_threshold)
1480 (memory_full_cons_threshold): Revert declaration.
1481 (maybe_gc): Remove prototype, define as inline.
1482 * alloc.c: Remove old commented-out code.
1483 (consing_since_gc, gc_relative_threshold)
1484 (memory_full_cons_threshold): Revert to global.
1485 (maybe_gc): Remove.
1486
d7ea76b4
DA
14872012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1488
1489 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1490 * lisp.h (build_unibyte_string): New function.
1491 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1492 * sysdep.c, w32fns.c, xfns.c: Use it.
1493 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1494 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1495 Adjust users accordingly.
1496 * font.h (font_open_by_name): Adjust prototype.
1497
765e61e3
DA
14982012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1499
1500 Cleanup calls to Fgarbage_collect.
1501 * lisp.h (maybe_gc): New prototype.
1502 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1503 Remove declarations.
1504 * alloc.c (maybe_gc): New function.
1505 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1506 Make them static.
1507 * bytecode.c (MAYBE_GC): Use maybe_gc.
1508 * eval.c (eval_sub, Ffuncall): Likewise.
1509 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1510 to avoid dependency from auto-save feature.
1511
52b852c7
PE
15122012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1513
1514 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1515 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1516 'for_each_per_buffer_object_at'.
1517 All uses changed. It's better to use upper-case for macros that
1518 cannot be implemented as functions, to give the reader a clue
1519 that they're special.
1520
5db81e33
SM
15212012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1522
1523 * alloc.c (Fgarbage_collect): Tweak docstring.
1524
5b835e1d
DA
15252012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1526
1527 Tweak the value returned from Fgarbage_collect again.
1528 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1529 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1530 Adjust documentation.
1531 (total_vector_bytes): Rename to total_vector_slots, adjust
1532 accounting.
1533 (total_free_vector_bytes): Rename to total_free_vector_slots,
1534 adjust accounting.
1535 (Qstring_bytes, Qvector_slots): New symbols.
1536 (syms_of_alloc): DEFSYM them.
1537
9cd47b72
DA
15382012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1539
1540 Buffer compaction primitive which may be used from Lisp.
1541 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1542 (syms_of_buffer): Register Fcompact_buffer.
1543 * alloc.c (Fgarbage_collect): Use compact_buffer.
1544 * buffer.h (compact_buffer): New prototype.
1545 (struct buffer_text): New member.
1546
d17337e5
DA
15472012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1548
1549 New macro to iterate over all buffers, miscellaneous cleanups.
1550 * lisp.h (all_buffers): Remove declaration.
1551 * buffer.h (all_buffers): Add declaration, with comment.
1552 (for_each_buffer): New macro.
1553 * alloc.c (Fgarbage_collect, mark_object): Use it.
1554 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1555 (init_buffer): Likewise.
1556 * data.c (Fset_default): Likewise.
1557 * coding.c (code_conversion_restore): Remove redundant check
1558 for dead buffer.
1559 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1560
60cfd278
AS
15612012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1562
1563 Fix bug that created negative-length intervals.
1564 * intervals.c (merge_interval_right, merge_interval_left):
1565 Do not zero out this interval if it is absorbed by its children,
1566 as this interval's total length doesn't change in that case. See
1567 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1568
d06714cb
PE
15692012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1570
83713154
PE
1571 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1572 when invoking (make-bool-vector N t) and N is a positive
1573 multiple of 8 -- the last 8 bits were mistakenly cleared.
1574
d06714cb
PE
1575 Remove some struct layout assumptions in bool vectors.
1576 * alloc.c (bool_header_size): New constant.
1577 (header_size, word_size): Move earlier, as they're now used earlier.
1578 Use 'word_size' in a few more places, where it's appropriate.
1579 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1580 padding before the data member of a bool vector.
1581 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1582 than doing the check by hand with an abort ().
1583
464d5a5e
SM
15842012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1585
5fbc0409
SM
1586 * eval.c (Fdefvar): Don't check constants since we only set the var if
1587 it's not yet defined anyway (bug#11904).
1588
464d5a5e
SM
1589 * lisp.h (last_undo_boundary): Declare new var.
1590 * keyboard.c (command_loop_1): Set it.
1591 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1592 were auto-added by the command loop (bug#11774).
1593
8dc2e44a
AS
15942012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1595
1596 * w32font.c (Qsymbol): Remove local definition.
1597 (syms_of_w32font): Don't DEFSYM it.
1598
169925ec
DA
15992012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1600
1601 Fix sweep_vectors to handle large bool vectors correctly.
1602 * alloc.c (sweep_vectors): Account total_vector_bytes for
1603 bool vectors larger than VBLOCK_BYTES_MAX.
1604
5fbfb018
CY
16052012-07-18 Chong Yidong <cyd@gnu.org>
1606
1607 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1608 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1609
3ab6e069
DA
16102012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1611
1612 Return more descriptive data from Fgarbage_collect.
1613 Suggested by Stefan Monnier in
1614 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1615 * alloc.c (bounded_number): New function.
1616 (total_buffers, total_vectors): New variable.
1617 (total_string_size): Rename to total_string_bytes, adjust users.
1618 (total_vector_size): Rename to total_vector_bytes, adjust users.
1619 (sweep_vectors): Account total_vectors and total_vector_bytes.
1620 (Fgarbage_collect): New return value. Adjust documentation.
1621 (gc_sweep): Account total_buffers.
1622 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1623 (VECTOR_SIZE): Remove.
1624 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1625 (Qinterval, Qmisc): New symbols.
1626 (syms_of_data): Initialize them.
1627 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1628 (Qcons, Qbuffer): New declarations.
1629
6d02fe5b
PE
16302012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1633 Round up, not down. Improve doc.
1634
b7ffe040
DA
16352012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 Restore old code in allocate_string_data to avoid Faset breakage.
1638 Reported by Julien Danjou <julien@danjou.info> in
1639 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1640 * alloc.c (allocate_string_data): Restore old code with minor
1641 adjustments, fix comment to explain this subtle issue.
1642
4dc7c8d5
SM
16432012-07-17 Eli Zaretskii <eliz@gnu.org>
1644
1645 Remove FILE_SYSTEM_CASE.
1646 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1647
1648 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1649 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1650 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1651 call-process-region passes it through expand-file-name.
1652
1653 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1654
16552012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1656
1657 Fix crash when creating indirect buffer (Bug#11917)
1658 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1659 Don't handle unbound variables specially if non-zero.
1660 (Fbuffer_local_variables): Pass zero.
1661 (clone_per_buffer_values): Pass non-zero.
1662
16632012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1666 to make the loop interruptible.
1667
16682012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * gnutls.c (emacs_gnutls_handshake): Only retry if
1671 GNUTLS_E_INTERRUPTED.
1672
cce7fefc
DA
16732012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1674
1675 Cleanup and convert miscellaneous checks to eassert.
1676 * alloc.c (mark_interval): Fix comment, partially rephrase
1677 old comment from intervals.h (see below).
1678 * intervals.c (find_interval, adjust_intervals_for_insertion)
1679 (delete_interval, adjust_intervals_for_deletion)
1680 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1681 Convert to eassert.
1682 (adjust_intervals_for_insertion, make_new_interval):
1683 Remove obsolete and unused code.
1684 * intervals.h (struct interval): Remove obsolete comment.
1685 * textprotp.c (erase_properties): Remove unused code.
1686 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1687 (Fremove_list_of_text_properties): Convert to eassert.
1688
9ea10cc3
CY
16892012-07-17 Chong Yidong <cyd@gnu.org>
1690
1691 * editfns.c (Finsert_char): Doc fix.
1692
3900d5de
DA
16932012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1694
1695 Fix previous change to make Fmemory_free always accurate.
1696 * alloc.c (make_interval): Update total_free_intervals.
1697 (make_float): Likewise for total_free_floats.
1698 (free_cons, Fcons): Likewise for total_free_conses.
1699 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1700 Likewise for total_free_vector_bytes.
1701 (Fmake_symbol): Likewise for total_free_symbols.
1702 (bytes_free): Remove.
1703
7098646f
DA
17042012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 Simple free memory accounting feature.
1707 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1708 (sweep_vectors): Accumulate size of free vectors.
1709 (Fgarbage_collect): Setup bytes_free.
1710 (Fmemory_free): New function.
1711 (syms_of_alloc): Register it.
1712
22657b40
DA
17132012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1714
1715 Cleanup overlays checking.
1716 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1717 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1718 eassert and OVERLAYP.
1719 (sort_overlays): Change to use OVERLAYP.
1720
ddfc8813
RK
17212012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1722
1723 * editfns.c (Finsert_char): Make it interactive, and make the
1724 second arg optional. Copy interactive spec and docstring from
1725 ucs-insert.
1726
7c26cf3c
PE
17272012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1728
1729 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1730 Unlike the other wrapped functions, fabs has an unspecified
1731 effect on errno.
1732
5d127af9
JD
17332012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1734
1735 * nsterm.m (keyDown): Interpret flags without left/right bits
1736 as the left key (Bug#11670).
1737
6a0dd1d7
DA
17382012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1739
1740 Remove empty and useless init functions.
1741 * lisp.h (init_character_once, init_fns, init_image)
1742 (init_filelock, init_sound): Remove prototype.
1743 * character.c (init_character_once): Remove.
1744 * filelock.c (init_filelock): Likewise.
1745 * fns.c (init_fns): Likewise.
1746 * image.c (init_image): Likewise.
1747 * sound.c (init_sound): Likewise.
1748 * emacs.c (main): Adjust accordingly.
1749
7a6136fd
DA
17502012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1751
1752 * gtkutil.h: Tiny cleanups.
1753 (use_old_gtk_file_dialog): Remove useless declaration.
1754 (xg_uses_old_file_dialog): Add suggested const attribute.
1755
ce811ad9
EZ
17562012-07-15 Eli Zaretskii <eliz@gnu.org>
1757
1758 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1759 (bidi_paragraph_init): Use it to limit search forward for a strong
1760 directional character in abnormally large paragraphs full of
1761 neutral or weak characters. (Bug#11943)
1762
c9adfeaa
SF
17632012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1764
1765 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1766 the toolbar (Bug#9451).
1767 (xg_make_tool_item): Give the widget event box a transparent
1768 background.
1769
fff62aa9
DA
17702012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1771
1772 Cleanup basic allocation variables and functions.
1773 * alloc.c (ignore_warnings, init_intervals, init_float)
1774 (init_cons, init_symbol, init_marker): Remove.
1775 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1776 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1777 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1778 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1779 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1780 (staticidx, init_alloc_once, init_strings, free_ablock):
1781 Remove redundant initialization.
1782 * fns.c (init_weak_hash_tables): Remove.
1783 * lisp.h (init_weak_hash_tables): Remove prototype.
1784
9730daca
DA
17852012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 Use zero_vector where appropriate.
1788 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1789 accordingly.
1790 * lisp.h (zero_vector): New declaration.
1791 * font.c (null_vector): Remove.
1792 (syms_of_font): Remove initialization and staticpro.
1793 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1794 * keymap.c (Faccessible_keymaps): Likewise.
1795
2e2d2a13
LL
17962012-07-15 Leo Liu <sdl.web@gmail.com>
1797
1798 * fringe.c: Fix typo in comments.
1799
cd276f6e
LL
18002012-07-14 Leo Liu <sdl.web@gmail.com>
1801
1802 * fringe.c: Add a new bitmap exclamation-mark.
1803
5a1131d9
EZ
18042012-07-14 Eli Zaretskii <eliz@gnu.org>
1805
1806 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1807
1808 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1809 (HAVE_MENUS): Don't define, defined by editing config.in with
1810 msdos/sed2v2.inp.
1811 (GMALLOC_INHIBIT_VALLOC): Don't define.
1812 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1813
22e983b7
JB
18142012-07-14 Juanma Barranquero <lekktu@gmail.com>
1815
1816 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1817
5b3f250f
GM
18182012-07-14 Glenn Morris <rgm@gnu.org>
1819
1820 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1821 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1822 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1823
33d63ff4
GM
18242012-07-13 Glenn Morris <rgm@gnu.org>
1825
5b633342
GM
1826 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1827
33d63ff4
GM
1828 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1829 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1830
b55b9f85
JD
18312012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1832
0dc8cf50
JD
1833 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1834 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1835 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1836 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1837 where appropriate.
1838 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1839 as boolean expression.
1840 (x_set_window_size): Remove unused variable toolbar.
1841 (ns_get_color_default, ns_mod_to_lisp): Remove.
1842 (ns_mouse_position): Remove unused variables xchar and ychar.
1843 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1844 (ns_set_vertical_scroll_bar): Remove unused variable count.
1845 (ns_delete_terminal): Remove unused variable i.
1846 (ns_term_init): Remove unused variables r, g and b.
1847 (mouseDown): Remove unused variable window.
1848 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1849 (initFrameFromEmacs): Remove unused variable vbextra.
1850 (mouseEntered): Remove unused variables p and dpyinfo.
1851 (mouseExited): Remove unused variables p and r.
1852 (ns_define_frame_cursor, ns_clear_frame_area)
1853 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1854 (menuDown): Assign [sender tag] to variable and cast the variable.
1855
1856 * nsterm.h (menuDown): Add id as type to argument sender.
1857 (ns_display_info_for_name): Add Lisp_Object argument.
1858 (ns_term_init): Add Lisp_Object argument.
1859 (ns_map_event_to_object): Add void argument.
1860 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1861 prototype with arguments and only declare if __OBJC__.
1862 (nxatoms_of_nsselect): Add void argument.
1863 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1864 (ns_alloc_autorelease_pool): Add void argument.
1865 (ns_release_autorelease_pool): Add void* argument.
1866 (ns_get_defaults_value): Add const char* argument.
1867
1868 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1869 (initFromContents): Use SSDATA where appropriate.
1870 (ns_update_menubar): Add braces to ambigous if-else.
1871 (initWithTitle): Put () around assignment in if statement.
1872 (ns_menu_show): Remove unused variables window and keymap.
1873 (update_frame_tool_bar): Remove unused variable selected_p.
1874 (initWithContentRect): Remove unused variable this_cmd_name.
1875
1876 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1877 appropriate.
1878 (setXBMColor): Remove unused variable len.
1879 (setPixmapData): Put () around assignment in loop statement.
1880
1881 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1882 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1883 where appropriate.
1884 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1885 around assignment in loop statement.
1886 (nsfont_open): Remove unused variable i.
1887 (nsfont_open): Remove unused variable len.
1888 (nsfont_draw): Remove unused variable cs.
1889
1890 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1891 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1892 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1893 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1894 (Fns_font_name, Fns_perform_service)
1895 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1896 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1897 (ns_set_name): Remove unused variable view.
1898 (x_set_menu_bar_lines): Remove unused variable olines.
1899 (x_set_tool_bar_lines): Remove unused variable root_window.
1900 (Fns_list_colors): Put () around assignment in while statement.
1901 (Fns_perform_service): Remove unused variable len.
1902 (Fns_display_usable_bounds): Remove unused variable top.
1903 (syms_of_nsfns): Remove unused variable i.
1904
b55b9f85
JD
1905 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1906 memcpy (Bug#11907).
1907
ed9265fc 19082012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1909
1910 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1911 and free it with DestroyExceptionInfo (Bug#11558).
1912
ef099b57
JB
19132012-07-13 Juanma Barranquero <lekktu@gmail.com>
1914
1915 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1916 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1917 Set here, not in nt/config.nt.
1918
ea814a5d
EZ
19192012-07-13 Eli Zaretskii <eliz@gnu.org>
1920
1921 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1922 cursor overflow into the last glyph on display line when the right
1923 fringe is off. (Bug#11832)
1924
1a952767
PE
19252012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * xdisp.c (produce_special_glyphs): Now static.
1928 * dispextern.h (produce_special_glyphs): Remove decl.
1929
983188fd
GM
19302012-07-13 Glenn Morris <rgm@gnu.org>
1931
8d7c7eed 1932 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1933 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1934
983188fd
GM
1935 * s/usg5-4-common.h (USG, USG5):
1936 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1937 * s/sol2-6.h (SOLARIS2):
1938 * s/irix6-5.h (IRIX6_5):
1939 * s/hpux10-20.h (USG, USG5, HPUX):
1940 * s/gnu-linux.h (USG, GNU_LINUX):
1941 * s/freebsd.h (BSD_SYSTEM):
1942 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1943 * s/cygwin.h (CYGWIN):
1944 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1945 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1946
d1e68667 19472012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1948
1949 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1950
6de0e799
GM
19512012-07-13 Glenn Morris <rgm@gnu.org>
1952
739ae010
GM
1953 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1954
dbee5793
GM
1955 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1956
6de0e799
GM
1957 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1958 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1959
b82da769
GM
19602012-07-12 Glenn Morris <rgm@gnu.org>
1961
4fae5a7a 1962 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1963
1964 * process.c (init_process_emacs): Rename from init_process.
1965 The old name is also the name of a Mach system call.
1966 * lisp.h, emacs.c: Update for this name change.
1967 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1968 longer needed.
1969
5a979817
EZ
19702012-07-12 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1973 memmove call that removes glyphs covered by the left truncation
1974 glyph. Improve commentary.
1975 (display_line): Fix display of continuation glyphs on GUI frames
1976 when the right fringe is turned off and variable-size fonts are
1977 used in the window. Move the code that appends a stretch glyph to
1978 produce_special_glyphs, so that it could be used for truncation
1979 and continuation glyphs alike.
1980 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1981 glyph of a suitably computed width, to align the special glyphs at
1982 the window margin. Code moved from display_line. (Bug#11832)
1983
3e91a053
GM
19842012-07-12 Glenn Morris <rgm@gnu.org>
1985
ba9e4b84
GM
1986 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1987
1988 * s/gnu-linux.h, s/hpux10-20.h:
1989 Do not unconditionally define HAVE_XRMSETDATABASE.
1990
3e91a053
GM
1991 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1992
b300b1f4
PE
19932012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 Fix typos that broke OS X build.
1996 Reported by Randal L. Schwartz in
1997 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1998 * nsterm.m (ns_timeout): Add missing local decl.
1999 (ns_get_color): snprintf -> sprintf, to fix typo.
2000
6e777848
GM
20012012-07-12 Glenn Morris <rgm@gnu.org>
2002
3f922c37
GM
2003 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
2004 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
2005 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
2006 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
2007
0ab7b23a
GM
2008 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
2009 Move PTY_OPEN to configure.
2010
6e777848
GM
2011 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2012 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
2013 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
2014
4a7edc24
DA
20152012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
2016
2017 Use empty_unibyte_string where applicable.
2018 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
2019 * lread.c (read1): Likewise.
2020 * xsettings.c (syms_of_xsettings): Likewise.
2021
308aab79
GM
20222012-07-12 Glenn Morris <rgm@gnu.org>
2023
42bd1719
GM
2024 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
2025 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
2026 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
2027 * s/hpux10-20.h (RUN_TIME_REMAP):
2028 * s/bsd-common.h (TABDLY): Move to configure.
2029
2030 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
2031
2032 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
2033
ea0bbd17 2034 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 2035 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
2036
2037 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 2038
308aab79
GM
2039 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
2040 * s/template.h: Move NARROWPROTO to configure.
2041
ee1cf5cf
GM
20422012-07-11 Glenn Morris <rgm@gnu.org>
2043
30fe9bf4
GM
2044 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
2045 unused since 2011-01-17 change to systty.h.
2046
ee1cf5cf
GM
2047 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
2048 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2049 Move HAVE_PTYS and HAVE_SOCKETS to configure.
2050
63e47e07
PE
20512012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
2054
c43fb4c3
GM
20552012-07-11 Glenn Morris <rgm@gnu.org>
2056
2057 * s/darwin.h, s/gnu-linux.h, s/template.h:
2058 Move INTERRUPT_INPUT to configure.
2059
e8df9267
DA
20602012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2061
2062 Minor adjustments to interning code.
2063 * lisp.h (intern, intern_c_string): Redefine as static inline
2064 wrappers for intern_1 and intern_c_string_1, respectively.
2065 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
2066 * lread.c (intern_1, intern_c_string_1, oblookup):
2067 Simplify Vobarray checking.
e8df9267
DA
2068 * font.c (font_intern_prop): Likewise. Adjust comment.
2069 * w32font.c (intern_font_name): Likewise.
2070
34348bd4
AS
20712012-07-11 Andreas Schwab <schwab@linux-m68k.org>
2072
d96a1e0c
AS
2073 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
2074
34348bd4
AS
2075 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
2076 of Fcar/Fcdr if possible.
2077 * font.c (check_otf_features): Likewise.
2078 * fontset.c (Fnew_fontset): Likewise.
2079 * gnutls.c (Fgnutls_boot): Likewise.
2080 * minibuf.c (read_minibuf): Likewise.
2081 * msdos.c (IT_set_frame_parameters): Likewise.
2082 * xmenu.c (Fx_popup_dialog): Likewise.
2083 * w32menu.c (Fx_popup_dialog): Likewise.
2084
c8add24e
GM
20852012-07-11 Glenn Morris <rgm@gnu.org>
2086
4b575b3c
GM
2087 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
2088 since nothing has defined it on these platforms.
2089
09f4e3b0
GM
2090 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
2091 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
2092
172bedef
GM
2093 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2094 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
2095 Move CLASH_DETECTION to configure.
2096
249685df
GM
2097 * s/gnu.h: Remove file, which is now empty.
2098
c8add24e
GM
2099 * s/gnu.h, s/gnu-linux.h:
2100 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
2101
b41253a3
JW
21022012-07-11 John Wiegley <johnw@newartisans.com>
2103
2104 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
2105 function attribute, so we only use it if it exists in the
2106 compiler.
2107
d923b542
DA
21082012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2109
2110 Avoid call to strlen in fast_c_string_match_ignore_case.
2111 * search.c (fast_c_string_match_ignore_case): Change to use
2112 length argument. Adjust users accordingly.
2113 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
2114
5ebbef1d
PE
21152012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2116
bb352260
PE
2117 Assume mkdir, rmdir.
2118 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2119 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2120
57054ddd
PE
2121 Assume rename.
2122 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2123
b747d3f7
PE
2124 Assume perror.
2125 * s/hpux10-20.h (HAVE_PERROR): Remove.
2126 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2127 Remove dummy definition, as this problem was obsolete long ago.
2128
5ebbef1d
PE
2129 Assume strerror.
2130 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2131
984e7f30
DA
21322012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2133
2134 Avoid calls to strlen in font processing functions.
2135 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2136 (font_open_by_name): Change to use length argument.
2137 Adjust users accordingly.
d923b542
DA
2138 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2139 Adjust prototypes.
2140 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2141 Change to return ptrdiff_t.
984e7f30
DA
2142 (xfont_list_pattern, xfont_match): Use length returned by
2143 xfont_decode_coding_xlfd.
2144 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2145
20e94fdd
GM
21462012-07-11 Glenn Morris <rgm@gnu.org>
2147
9d596af3
GM
2148 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2149 Move DONT_REOPEN_PTY to configure.
2150
20e94fdd
GM
2151 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2152 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2153
e99a530f
PE
21542012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2155
22ffb973
PE
2156 Remove "#define unix" that is no longer needed (Bug#11905).
2157 * s/aix4-2.h (unix): Remove; no longer needed.
2158
e9a9ae03
PE
2159 EMACS_TIME simplification (Bug#11875).
2160 This replaces macros (which typically do not work in GDB)
2161 with functions, typedefs and enums, making the code easier to debug.
2162 The functional style also makes code easier to read and maintain.
2163 * systime.h: Include <sys/time.h> on all hosts, not just if
2164 WINDOWSNT, since 'struct timeval' is needed in general.
2165 (EMACS_TIME): Now a typedef, not a macro.
2166 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2167 not macros.
2168 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2169 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2170 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2171 (EMACS_TIME_LE): Now functions, not macros.
2172 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2173 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2174 which are not functions. All uses rewritten to use:
2175 (make_emacs_time): New function.
2176 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2177 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2178 not functions. All uses rewritten to use the following, respectively:
2179 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2180 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2181 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2182 * fileio.c (Fcopy_file):
2183 * xterm.c (XTflash): Get the current time closer to when it's used.
2184 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2185
ffacb126
PE
2186 * bytecode.c (targets): Suppress -Woverride-init warnings.
2187
e99a530f
PE
2188 Simplify by avoiding confusing use of strncpy etc.
2189 * doc.c (Fsnarf_documentation):
2190 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2191 * frame.c (Fmake_terminal_frame):
2192 * gtkutil.c (get_utf8_string):
2193 * lread.c (openp):
2194 * nsmenu.m (ns_update_menubar):
2195 * regex.c (regerror):
2196 Prefer memcpy to strncpy and strncat when either will do.
2197 * fileio.c (Fsubstitute_in_file_name):
2198 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2199 (menu_separator_name_p):
2200 * nsmenu.m (ns_update_menubar):
2201 Prefer memcmp to strncmp when either will do.
2202 * nsterm.m: Include <ftoastr.h>.
2203 (ns_get_color):
2204 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2205 Prefer snprintf to strncpy.
2206 * nsterm.m (ns_term_init):
2207 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2208 * nsterm.m (ns_term_init):
2209 Avoid the need for strncpy, by using build_string or
2210 make_unibyte_string directly. Use dtoastr, not snprintf.
2211 * process.c (Fmake_network_process): Diagnose service names that
2212 are too long, rather than silently truncating them or creating
2213 non-null-terminated names.
2214 (Fnetwork_interface_info): Likewise, for interface names.
2215 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2216 Prefer sprintf to strncat.
2217 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2218 Prefer vsnprintf to vsprintf + strncpy.
2219
c59592b3
GM
22202012-07-10 Glenn Morris <rgm@gnu.org>
2221
2222 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2223 Clarify fallback case.
2224
7d7bbefd
DA
22252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2226
2227 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2228 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2229 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2230 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2231 where argument type is known to be a Lisp_Cons.
2232
3a4c8000
TT
22332012-07-10 Tom Tromey <tromey@redhat.com>
2234
2235 * bytecode.c (BYTE_CODE_THREADED): New macro.
2236 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2237 (enum byte_code_op): New type.
2238 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2239 (exec_byte_code): Use them. Use token threading when applicable.
2240
2a0213a6
DA
22412012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2242
2243 Optimize pure C strings initialization.
2244 * lisp.h (make_pure_string): Fix prototype.
2245 (build_pure_c_string): New function, defined as static inline. This
2246 provides a better opportunity to optimize away calls to strlen when
2247 the function is called with compile-time constant argument.
2248 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2249 argument, adjust users accordingly. Use build_pure_c_string where
2250 appropriate.
2251 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2252 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2253 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2254
cb1caeaf
DA
22552012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2256
2257 Avoid calls to strlen in miscellaneous functions.
2258 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2259 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2260 * lread.c (openp): Likewise.
2261
c293e30c
DA
22622012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2263
2264 Avoid calls to strlen in path processing functions.
2265 * fileio.c (file_name_as_directory): Add comment. Change to add
2266 srclen argument and return the length of result. Adjust users
2267 accordingly.
2268 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2269 swap 1st and 2nd arguments to obey the common convention.
2270 Adjust users accordingly.
c293e30c
DA
2271 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2272
9e059e3f
GM
22732012-07-10 Glenn Morris <rgm@gnu.org>
2274
d02eb359
GM
2275 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2276 Move PENDING_OUTPUT_COUNT definition to configure.
2277
882cf227
GM
2278 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2279 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2280 * s/gnu.h (DATA_START): Move definitions to configure.
2281
af6e839f
GM
2282 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2283 We include usg5-4-common.h, which defines them both.
2284
40289a12
GM
2285 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2286 O_RDONLY already includes it).
2287
9e059e3f
GM
2288 Stop ns builds setting the EMACSLOADPATH environment variable.
2289 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2290 Now it does not set EMACSLOADPATH, just returns the load-path string.
2291 * nsterm.h: Update accordingly.
2292 * lread.c [HAVE_NS]: Include nsterm.h.
2293 (init_lread) [HAVE_NS]: Use ns_load_path.
2294 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2295
7c4e8ec0
GM
22962012-07-09 Glenn Morris <rgm@gnu.org>
2297
d4f600ff
GM
2298 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2299 since the included bsd-common.h does so.
2300
cbb31951
GM
2301 Stop ns builds setting the EMACSPATH environment variable.
2302 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2303 (ns_init_paths): Do not set EMACSPATH.
2304 * nsterm.h (ns_exec_path): Add it.
2305 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2306 Use ns_exec_path.
2307
7c4e8ec0
GM
2308 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2309
26bccfae
PE
23102012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2311
a0bee46f
PE
2312 * process.c (wait_reading_process_output): 'waitchannels' was unset
2313 when read_kbd || !NILP (wait_for_cell); fix this.
2314
5994c183
PE
2315 Add GCC-style 'const' attribute to functions that can use it.
2316 * character.h (char_resolve_modifier_mask):
2317 * keyboard.h (make_ctrl_char):
2318 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2319 (init_character_once, next_almost_prime, init_fns, init_image)
2320 (flush_pending_output, init_sound):
2321 * mem-limits.h (start_of_data):
2322 * menu.h (finish_menu_items):
2323 Add ATTRIBUTE_CONST.
2324 * emacs.c (DEFINE_DUMMY_FUNCTION):
2325 Declare the dummy function with ATTRIBUTE_CONST.
2326 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2327 Add decls with ATTRIBUTE_CONST.
2328
26bccfae
PE
2329 Minor improvements to make_formatted_string.
2330 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2331 where int is good enough, as vsprintf returns an int.
2332 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2333
a8290ec3
DA
23342012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2335
2336 Use make_formatted_string to avoid double length calculation.
2337 * lisp.h (make_formatted_string): New prototype.
2338 * alloc.c (make_formatted_string): New function.
2339 * buffer.c (Fgenerate_new_buffer_name): Use it.
2340 * dbus.c (syms_of_dbusbind): Likewise.
2341 * editfns.c (Fcurrent_time_zone): Likewise.
2342 * filelock.c (get_boot_time): Likewise.
2343 * frame.c (make_terminal_frame, set_term_frame_name)
2344 (x_report_frame_params): Likewise.
2345 * image.c (gs_load): Likewise.
2346 * minibuf.c (get_minibuffer): Likewise.
2347 * msdos.c (dos_set_window_size): Likewise.
2348 * process.c (make_process): Likewise.
2349 * xdisp.c (ensure_echo_area_buffers): Likewise.
2350 * xsettings.c (apply_xft_settings): Likewise.
2351
d01ba2f1
GM
23522012-07-09 Glenn Morris <rgm@gnu.org>
2353
2354 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2355 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2356 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2357 * nsterm.h (ns_etc_directory): Add it.
2358 * callproc.c [HAVE_NS]: Include nsterm.h.
2359 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2360
f1f924b6
DA
23612012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2362
2363 Move marker debugging code under MARKER_DEBUG.
2364 * marker.c (MARKER_DEBUG): Move marker debugging code under
2365 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2366 for bootstrap with --enable-checking (~3x slowdown reported
2367 by Juanma Barranquero <lekktu@gmail.com>).
2368 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2369
ab531b66
PE
23702012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2371
2372 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2373 See <http://bugs.gnu.org/11825#29>.
2374
c4b3bc8a
EZ
23752012-07-08 Eli Zaretskii <eliz@gnu.org>
2376
2377 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2378 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2379 (display_line): Add commentary about displaying truncation glyphs
2380 on GUI frames.
2381 (produce_special_glyphs): Move here from term.c.
2382
2383 * term.c (produce_special_glyphs): Move to xdisp.c.
2384
2385 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2386 section.
c4b3bc8a 2387
b676b881
AS
23882012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2389
f17c5273
AS
2390 * xdisp.c (display_line): Avoid warning about implicit declaration
2391 of FRAME_FONT.
2392
298819b9
AS
2393 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2394
b676b881
AS
2395 * lisp.h: Remove empty conditional.
2396
6045c4fd
PE
23972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2398
b3350bf9
PE
2399 * lread.c (load_path_check): Now static.
2400
6045c4fd
PE
2401 Fix some minor --with-ns problems found by static checking.
2402 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2403 (x_set_font) [!HAVE_X_WINDOWS]:
2404 * image.c (xpm_load_image) [HAVE_NS]:
2405 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2406 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2407 Remove unused local.
2408 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2409 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2410 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2411 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2412 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2413 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2414 Fix pointer signedness problem.
2415 * xfaces.c (FRAME_X_FONT_TABLE):
2416 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2417
929e7845
GM
24182012-07-07 Glenn Morris <rgm@gnu.org>
2419
2420 * lread.c (load_path_check): New function, split from init_lread.
2421 (init_lread): Reorganize. Motivation:
2422 If EMACSLOADPATH is set, check/warn about that rather than the
2423 defaults, which we are not going to use. Hence we can remove
2424 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2425 Don't warn if site-lisp directories are missing.
2426 If not installed, start from a blank load-path, since
2427 PATH_LOADSEARCH refers to the eventual installation directories.
2428
58dd0aa4
EZ
24292012-07-07 Eli Zaretskii <eliz@gnu.org>
2430
2431 Support truncation and continuation glyphs on GUI frames, when
2432 fringes are disabled. (Bug#11832)
2433 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2434 continuation glyphs even if on GUI frames.
2435 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2436 or both, are absent.
2437 (start_display, move_it_in_display_line_to): Handle the case of a
2438 GUI frame without a fringe to display continuation or truncation
2439 glyphs.
2440 (insert_left_trunc_glyphs): Support GUI frames: make sure
2441 truncation glyphs overwrite enough glyphs from the current line to
2442 have sufficient space in pixels.
2443 (display_line): Support truncation and continuation glyphs on GUI
2444 frames. If some spare pixels are left on the line after inserting
2445 the truncation glyphs, fill that space with a stretch glyph of a
2446 suitably computed width.
2447
2448 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2449 produce_glyphs, to support GUI sessions.
2450
31571fd7
PE
24512012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2452
5a16b9bc
PE
2453 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2454
f3047c75
PE
2455 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2456
31571fd7
PE
2457 Do not require float-time's arg to fit in time_t (Bug#11825).
2458 This works better on hosts where time_t is unsigned, and where
2459 float-time is applied to the (negative) difference between two times.
2460 * editfns.c (decode_time_components): Last arg is now double *,
2461 not int *, and means to store all the result as a double, without
2462 worrying about whether the seconds part fits in time_t.
2463 All callers changed.
2464 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2465 All callers changed.
2466 (Ffloat_time): Do not fail merely because the specified time falls
2467 outside of time_t range.
2468
4516fbef
GM
24692012-07-07 Glenn Morris <rgm@gnu.org>
2470
2471 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2472 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2473 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2474
07adc2c6
JB
24752012-07-07 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2478 Update dependencies.
2479
2480 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2481
fd573f31
PE
24822012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2483
fee5959d
PE
2484 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2485 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2486 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2487 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2488 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2489 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2490
fd573f31
PE
2491 * xfont.c (compare_font_names): Redo to omit the need for casts.
2492
ddadbc0e
AS
24932012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2494
fca8d6b6
AS
2495 * xfns.c (Fx_change_window_property): Doc fix.
2496 * w32fns.c (Fx_change_window_property): Doc fix.
2497
ddadbc0e
AS
2498 * w32fns.c (Fx_window_property): Accept the same arguments as the
2499 X Windows version. Doc fix.
2500 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2501
ed9265fc 25022012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2503 Eli Zaretskii <eliz@gnu.org>
2504
2505 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2506 Windows-specific code from nt/config.nt moved here.
2507 Obsolete settings removed.
2508
216ee680
PE
25092012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 * process.c: Avoid unnecessary calls to gettime.
2512 (wait_reading_process_output): Don't get the time of day
2513 when gobbling data immediately and not waiting, as there's no need
2514 for it in that case. This removes a FIXME.
2515
bdd091e4
JD
25162012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2519 is defined (Bug#11768).
2520
9d44f8ce
DA
25212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2522
2523 Fix marker debugging code.
2524 * marker.c (byte_char_debug_check): Do not perform the check
2525 if buffer is not multibyte.
090bd7cb
JB
2526 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2527 Call byte_char_debug_check with correct arguments.
9d44f8ce 2528
90fc4786
DA
25292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2530
2531 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2532 * marker.c (byte_char_debug_check, count_markers):
2533 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2534 (byte_debug_flag): Remove.
2535 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2536 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2537
7b7ae965
DA
25382012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2539
4e57b342
DA
2540 Avoid code repetition in marker-related functions.
2541 * marker.c (attach_marker): New function.
2542 (Fset_marker, set_marker_restricted, set_marker_both)
2543 (set_marker_restricted_both): Use it.
2544 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2545 Consistently rename charno to charpos.
2546 (marker_position): Add eassert.
2547 (marker_byte_position): Convert to eassert.
2548
25492012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2550
2551 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2552 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2553 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2554
657924ff
DA
25552012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2556
2557 Introduce fast path for the widely used marker operation.
2558 * alloc.c (build_marker): New function.
2559 * lisp.h (build_marker): New prototype.
2560 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2561 * composite.c (autocmp_chars): Likewise.
2562 * editfns.c (buildmark): Remove.
2563 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2564 (save_restriction_save): Use build_marker.
2565 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2566 * window.c (save_window_save): Likewise.
2567
041a49a6
DA
25682012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2569
2570 Do not use Fdelete_overlay in delete_all_overlays
2571 to avoid redundant calls to unchain_overlay.
2572 * buffer.c (drop_overlay): New function.
2573 (delete_all_overlays, Fdelete_overlay): Use it.
2574 * minibuf.c (get_minibuffer): Fix comment.
2575
7dca65a4
PE
25762012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2577
2578 Port to OpenBSD 5.1 amd64.
2579 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2580 This is needed for OpenBSD, and should be harmless on all BSD systems.
2581 Also, include <sys/sysctl.h>, as it should be available on all
2582 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2583 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2584 use p_pid member, not kp_proc.pid.
2585
8eb876e2
GM
25862012-07-06 Glenn Morris <rgm@gnu.org>
2587
2588 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2589
38182d90
PE
25902012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 More xmalloc and related cleanup.
2593 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2594 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2595 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2596 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2597 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2598 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2599 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2600 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2601 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2602 * xterm.c:
2603 Omit needless casts involving void * pointers and allocation.
2604 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2605 as the former is more robust if P's type is changed.
2606 Prefer xzalloc to xmalloc + memset 0.
2607 Simplify malloc-or-realloc to realloc.
2608 Don't worry about xmalloc returning a null pointer.
2609 Prefer xstrdup to xmalloc + strcpy.
2610 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2611 growing it.
2612 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2613 alloca of a constant.
2614
6dd5a677
EZ
26152012-07-05 Eli Zaretskii <eliz@gnu.org>
2616
2617 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2618 hscroll is larger than the line width. Fixes long and futile
2619 looping inside extend_face_to_end_of_line (on a TTY) producing
2620 glyphs that are not needed and thrown away.
2621
6b312f0f
DA
26222012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2623
2624 * marker.c (set_marker_restricted_both): Simplify by using
2625 clip_to_bounds.
2626
f520ef9b
PE
26272012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2628
2629 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2630
383b7c95
JD
26312012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2632
2633 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2634 not defined (Bug#11768).
2635 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2636 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2637 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2638 followed by gtk_box_set_homogeneous (Bug#11768).
2639 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2640 (update_theme_scrollbar_width, xg_create_scroll_bar):
2641 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2642 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2643 (is_box_type): New function (Bug#11768).
2644 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2645 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2646 with default display (Bug#11768).
2647
d6e7bf45
EZ
26482012-07-05 Eli Zaretskii <eliz@gnu.org>
2649
2650 * xdisp.c (window_hscroll_limited): New function.
2651 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2652 coordinates when window's hscroll is set to insanely large
2653 values. (Bug#11857)
2654
431391ec
JB
26552012-07-05 Juanma Barranquero <lekktu@gmail.com>
2656
2657 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2658 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2659
23f86fce
DA
26602012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2661
2662 Cleanup xmalloc.
2663 * lisp.h (xzalloc): New prototype. Omit needless casts.
2664 * alloc.c (xzalloc): New function. Omit needless casts.
2665 * charset.c: Omit needless casts. Convert all calls to
2666 xmalloc with following memset to xzalloc.
2667 * dispnew.c: Likewise.
2668 * fringe.c: Likewise.
2669 * image.c: Likewise.
2670 * sound.c: Likewise.
2671 * term.c: Likewise.
2672 * w32fns.c: Likewise.
2673 * w32font.c: Likewise.
2674 * w32term.c: Likewise.
2675 * xfaces.c: Likewise.
2676 * xfns.c: Likewise.
2677 * xterm.c: Likewise.
2678 * atimer.c: Omit needless casts.
2679 * buffer.c: Likewise.
2680 * callproc.c: Likewise.
2681 * ccl.c: Likewise.
2682 * coding.c: Likewise.
2683 * composite.c: Likewise.
2684 * doc.c: Likewise.
2685 * doprnt.c: Likewise.
2686 * editfns.c: Likewise.
2687 * emacs.c: Likewise.
2688 * eval.c: Likewise.
2689 * filelock.c: Likewise.
2690 * fns.c: Likewise.
2691 * gtkutil.c: Likewise.
2692 * keyboard.c: Likewise.
2693 * lisp.h: Likewise.
2694 * lread.c: Likewise.
2695 * minibuf.c: Likewise.
2696 * msdos.c: Likewise.
2697 * print.c: Likewise.
2698 * process.c: Likewise.
2699 * region-cache.c: Likewise.
2700 * search.c: Likewise.
2701 * sysdep.c: Likewise.
2702 * termcap.c: Likewise.
2703 * terminal.c: Likewise.
2704 * tparam.c: Likewise.
2705 * w16select.c: Likewise.
2706 * w32.c: Likewise.
2707 * w32reg.c: Likewise.
2708 * w32select.c: Likewise.
2709 * w32uniscribe.c: Likewise.
2710 * widget.c: Likewise.
2711 * xdisp.c: Likewise.
2712 * xmenu.c: Likewise.
2713 * xrdb.c: Likewise.
2714 * xselect.c: Likewise.
2715
0497dc44
PE
27162012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2717
2718 * fileio.c (time_error_value): Check the right error number.
2719 Problem reported by Troels Nielsen in
2720 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2721
356e7178
PE
27222012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2723
4e71fd89
PE
2724 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2725 This should be fixed in a better way; see Eli Zaretskii in
2726 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2727 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2728
f0941253
PE
2729 * fileio.c (time_error_value): Rename from special_mtime.
2730 The old name's problems were noted by Eli Zaretskii in
2731 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2732
065c9eb4
PE
2733 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2734 This variable's comment says Emacs needs at least one GDB-visible
2735 symbol of type enum pvec_type, to work around GDB problems.
2736 The symbol's value doesn't matter.
2737
356e7178
PE
2738 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2739 that causes compilation to fail on pre-C99 compilers.
2740
ed9265fc 27412012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2742
2743 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2744 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2745
3884d954
DA
27462012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2747
d209e2fb 2748 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2749 headers for buffer_defaults and buffer_local_symbols.
2750 Reported by Juanma Barranquero <lekktu@gmail.com>.
2751
ee28be33
SM
27522012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2753
2754 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2755 * lisp.h (enum pvec_type): Use fewer bits.
2756 (PSEUDOVECTOR_SIZE_BITS): New constant.
2757 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2758 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2759 change in pvec_type.
2760 (PSEUDOVECTOR_TYPEP): New macro.
2761 (TYPED_PSEUDOVECTORP): Use it.
2762 * fns.c (internal_equal): Adapt code to extract pvectype.
2763 * emacs.c (gdb_pvec_type): Update type.
2764 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2765 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2766 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2767 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2768 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2769 abusing vector->header.next.nbytes.
2770 (live_vector_p): Use PVEC_TYPE.
2771 (mark_object): Adapt code to extract pvectype. Use switch.
2772
c7f2cd7f
PE
27732012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2774
2775 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2776 Tighten new eassert a bit.
2777
8ce70ed2
DA
27782012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2779
2780 Fix compilation with --enable-gcc-warnings and -O1
2781 optimization level.
2782 * doprnt.c (doprnt): Change type of tem to int, initialize
2783 to avoid compiler warning. Add eassert.
2784 * search.c (simple_search): Initialize match_byte to avoid
2785 compiler warning. Add eassert.
2786
dea7f1e5
PE
27872012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2788
24a212eb
PE
2789 Avoid weird behavior with large horizontal scrolls.
2790 Without this change, for example, large hscroll values would
2791 mess up Emacs's display on Fedora 15 x86, presumably due to
2792 overflows in int calculations in the display code.
2793 Also, if buffers had long lines, Emacs would freeze.
2794 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2795 (set_window_hscroll): New function, containing the old guts of
2796 Fset_window_hscroll. Return the clipped value.
2797 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2798 This avoids the need to check against PTRDIFF_MAX.
2799
dea7f1e5
PE
2800 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2801
76046526
DA
28022012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2803
2804 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2805
39adff0d
PE
28062012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2807
63807d47
PE
2808 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2809 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2810 since GCC 4.4.6 issues a bogus warning for them.
2811
39adff0d
PE
2812 Fix bugs in file timestamp newness comparisons.
2813 * fileio.c (Ffile_newer_than_file_p):
2814 * lread.c (Fload): Use full timestamp resolution of files,
2815 not just the 1-second resolution, so that files that are only
2816 slightly newer still count as newer.
2817 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2818 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2819
dbeed9a6
PE
28202012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2821
2822 * fileio.c: Improve handling of file time marker. (Bug#11852)
2823 (special_mtime): New function.
2824 (Finsert_file_contents, Fverify_visited_file_modtime):
2825 Use it to set special mtime values consistently.
2826
636334d6
AS
28272012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2828
2829 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2830 marker for non-existing file. (Bug#11852)
2831
e2017fe2
GM
28322012-07-03 Glenn Morris <rgm@gnu.org>
2833
2834 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2835 and did not make it into globals.h).
2836
404dbd37
TT
28372012-07-03 Tom Tromey <tromey@redhat.com>
2838
2839 * window.c (Fset_window_margins, Fset_window_fringes)
2840 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2841 * textprop.c (Fprevious_property_change): No longer static.
2842 * syntax.c (Fsyntax_table_p): No longer static.
2843 * process.c (Fget_process, Fprocess_datagram_address): No longer
2844 static.
2845 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2846 * keyboard.c (Fcommand_execute): No longer static.
2847 Remove EXFUN.
2848 * insdel.c (Fcombine_after_change_execute): No longer static.
2849 * image.c (Finit_image_library): No longer static.
2850 * fileio.c (Fmake_symbolic_link): No longer static.
2851 * eval.c (Ffetch_bytecode): No longer static.
2852 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2853 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2854 No longer static.
404dbd37
TT
2855 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2856 static.
2857 * dired.c (Ffile_attributes): No longer static.
2858 * composite.c (Fcomposition_get_gstring): No longer static.
2859 * callproc.c (Fgetenv_internal): No longer static.
2860
2861 * ccl.h: Remove EXFUNs.
2862 * buffer.h: Remove EXFUNs.
2863 * dispextern.h: Remove EXFUNs.
2864 * intervals.h: Remove EXFUNs.
2865 * fontset.h: Remove EXFUN.
2866 * font.h: Remove EXFUNs.
2867 * dosfns.c (system_process_attributes): Remove EXFUN.
2868 * keymap.h: Remove EXFUNs.
2869 * lisp.h: Remove EXFUNs.
2870 * w32term.h: Remove EXFUNs.
2871 * window.h: Remove EXFUNs.
2872 * xsettings.h: Remove EXFUN.
2873 * xterm.h: Remove EXFUN.
2874
8e4fd1e1
GM
28752012-07-03 Glenn Morris <rgm@gnu.org>
2876
2877 * lisp.h (Frandom): Make it visible to C.
2878 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2879 buffer for invisible buffers. (Bug#1229)
2880
ca95b3eb
DA
28812012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2882
2883 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2884 values which aren't power of 2.
14ae4239
BT
2885 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2886 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2887 accordingly.
2888
7555c33f
SM
28892012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2890
2891 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2892
2893 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2894
d12e8f5a
DA
28952012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2896
2897 * alloc.c (allocate_vector_block): Remove redundant
2898 calls to mallopt if DOUG_LEA_MALLOC is defined.
2899 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2900 avoid calls to mallopt if zero_vector is returned.
2901
296094c3
DA
29022012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2903
2904 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2905 is enabled, avoid dereferencing NULL current_sblock if
2906 running undumped.
2907
36429c89
DA
29082012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2909
2910 Cleanup basic buffer management.
2911 * buffer.h (struct buffer): Change layout to use generic vector
2912 marking code. Fix some comments. Change type of 'clip_changed'
2913 to bitfield. Remove unused #ifndef old.
2914 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2915 (GET_OVERLAYS_AT): Fix indentation.
2916 (for_each_per_buffer_object_at): New macro.
2917 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2918 (Fbuffer_local_variables): Use it.
2919 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2920 * alloc.c (allocate_buffer): Adjust to match new layout of
2921 struct buffer. Fix comment.
2922 (mark_overlay): New function.
2923 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2924 Lisp area of struct buffer.
2925 (mark_object): Use it. Adjust marking of misc objects
2926 and related comments.
2927
3b3e4cac
PE
29282012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2931 wrapper that is not needed because the wrapped code is a no-op (zero
2932 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2933 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2934
cf5c0175
DA
29352012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2936
2937 * alloc.c (mark_buffer): Simplify. Remove prototype.
2938 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2939 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2940 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2941 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2942
ca26824c
GM
29432012-06-30 Glenn Morris <rgm@gnu.org>
2944
2e4c5312
GM
2945 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2946
ca26824c
GM
2947 * epaths.in (PATH_SITELOADSEARCH): New.
2948 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2949 This is rather than relying on --enable-locallisppath elements
2950 having "site-lisp" in their names. (Bug#10208#25, 11658)
2951
0d23c240
EZ
29522012-06-30 Eli Zaretskii <eliz@gnu.org>
2953
c9240d7a
EZ
2954 * w32proc.c (sys_select): Accept and ignore one more argument.
2955
2956 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2957
0d23c240 2958 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2959 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2960
2961 * sysdep.c: Don't include dos.h and dosfns.h.
2962
2963 * process.c (sys_select):
2964 * msdos.c (sys_select): Accept one more argument and ignore it.
2965
2966 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2967 adapt data types and code to that.
2968
2969 * dosfns.c:
2970 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2971 which clashes with the gnulib function of the same name.
2972
af5a5a98
AS
29732012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2974
c5e4379c
AS
2975 * font.c (font_style_to_value, font_style_symbolic)
2976 (font_prop_validate_style): Add type checks for values in
2977 font_style_table.
2978
af5a5a98
AS
2979 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2980 argument.
2981 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2982 uses.
2983
8d38f461
EZ
29842012-06-29 Eli Zaretskii <eliz@gnu.org>
2985
2e5a6631
EZ
2986 * xdisp.c (try_window_id): Undo last change.
2987
8d38f461
EZ
2988 * w32.c (getwd): Adjust commentary about startup_dir.
2989 (init_environment): Always call sys_access, even in non-MSVC
2990 builds. Don't chdir to the directory of the Emacs executable.
2991 This undoes code from 1997 which was justified by the need to
2992 "avoid conflicts when removing and renaming directories". But its
2993 downside was that every relative file name was being interpreted
2994 relative to the directory of the Emacs executable, which can never
2995 be TRT. In particular, it broke sys_access when called with
2996 relative file names.
2997 (sys_access): Map GetLastError to errno.
2998
2af3565e
DA
29992012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3000
3001 * window.h (struct window): Change type of 'fringes_outside_margins'
3002 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 3003 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
3004 Adjust comment.
3005 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
3006 to ptrdiff_t.
3007
c8d3a25c 30082012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 3009
c8d3a25c
GM
3010 * gnutls.c (emacs_gnutls_handshake):
3011 Add QUIT to make the loop interruptible.
57570cd3 3012
c8d3a25c 30132012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 3014
c8d3a25c
GM
3015 * charset.c (init_charset): Make lack of etc/charsets fatal.
3016
3e984ee8
DA
30172012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3018
3019 * editfns.c (region_limit): Fix type mismatch.
3020
ef884f23
DA
30212012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
3022
3023 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
3024 undefined. Convert from xassert to eassert.
3025 * nsmenu.m: Convert from xassert to eassert.
3026 * nsterm.m: Likewise.
3027
7d7e0027
SM
30282012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * editfns.c (region_limit): Clip to narrowing (bug#11770).
3031
aa754e6a
PE
30322012-06-28 Paul Eggert <eggert@cs.ucla.edu>
3033
3034 Avoid integer overflow on scroll-left and scroll-right.
3035 * window.c (HSCROLL_MAX): New macro.
3036 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
3037 overflow when requested scroll falls outside ptrdiff_t range.
3038
80b00b08
DA
30392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3040
3041 * window.h (struct window): Change type of 'hscroll',
3042 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
3043 'last_modified' and 'last_overlay_modified' to EMACS_INT.
3044 Adjust users accordingly.
3045 * xdisp.c (try_cursor_movement): Replace type check with eassert.
3046 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
3047 from EMACS_INT to ptrdiff_t.
3048 (make_window): Omit redundant initialization.
3049
62b2bcf6
JB
30502012-06-28 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
3053
45942c7d
DA
30542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3055
3056 * window.h (struct window): Change type of 'use_time' and
3057 'sequence_number' from Lisp_Object to int.
3058 * frame.c (make_frame): Adjust users accordingly.
3059 * print.c (print_object): Likewise.
3060 * window.c (select_window, Fwindow_use_time, make_parent_window)
3061 (make_window): Likewise.
3062
e509cfa6
DA
30632012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3064
3065 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
3066 enabled with --enable-checking=[all,glyphs] configure option.
3067 Fix GLYPH_DEBUG usage assuming that it may be undefined,
3068 adjust comments accordingly.
3069 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
3070 undefined, adjust comments accordingly.
3071 * image.c: Likewise.
3072 * scroll.c: Likewise.
3073 * w32fns.c: Likewise.
3074 * w32term.c: Likewise.
3075 * xdisp.c: Likewise.
3076 * xfaces.c: Likewise.
3077 * xfns.c: Likewise.
3078 * xterm.c: Likewise.
3079
a54e2c05
DA
30802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
3081
3082 Generalize run-time debugging checks.
3083 * dispextern.h (XASSERTS): Remove.
3084 * fontset.c (xassert): Remove.
3085 Convert from xassert to eassert.
3086 * alloc.c: Convert from xassert to eassert.
3087 * bidi.c: Likewise.
3088 * dispnew.c: Likewise.
3089 * fns.c: Likewise.
3090 * fringe.c: Likewise.
3091 * ftfont.c: Likewise.
3092 * gtkutil.c: Likewise.
3093 * image.c: Likewise.
3094 * keyboard.c: Likewise.
3095 * menu.c: Likewise.
3096 * process.c: Likewise.
3097 * scroll.c: Likewise.
3098 * sound.c: Likewise.
3099 * term.c: Likewise.
3100 * w32console.c: Likewise.
3101 * w32fns.c: Likewise.
3102 * w32term.c: Likewise.
3103 * window.c: Likewise.
3104 * xdisp.c: Likewise.
3105 * xfaces.c: Likewise.
3106 * xfns.c: Likewise.
3107 * xselect.c: Likewise.
3108 * xterm.c: Likewise.
3109
1ec4b7b2
SM
31102012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
3111
3112 * fns.c (maybe_resize_hash_table): Output message when growing the
3113 purify-hashtable.
3114
2014308a
DA
31152012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3116
3117 * alloc.c (allocate_string_data): Remove dead code.
3118 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3119 avoid GCC warning about unused macro.
3120
246155eb
DA
31212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3122
3123 * alloc.c (allocate_string): Omit intervals initialization.
3124 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3125 as in make_pure_string and make_pure_c_string.
3126
43184b7b
DA
31272012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3128
d209e2fb 3129 * alloc.c (allocate_string): Fix last change.
43184b7b 3130
3fe6dd74
DA
31312012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3132
d209e2fb 3133 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3134 to memset, add explicit initialization where appropriate.
3135
1ba6038a
GM
31362012-06-27 Glenn Morris <rgm@gnu.org>
3137
3138 * lisp.mk (lisp): Remove paths.elc.
3139
c89926a5
CY
31402012-06-27 Chong Yidong <cyd@gnu.org>
3141
3142 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3143
ed6b3510
JW
31442012-06-26 John Wiegley <johnw@newartisans.com>
3145
1ec4b7b2 3146 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3147 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3148
ed6b3510
JW
3149 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3150 when building with Clang.
3151
8edd4a2b
SM
31522012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3153
3154 * eval.c (Fapply): Allow calling it with a single argument.
3155
f6f62d1b
EZ
31562012-06-26 Eli Zaretskii <eliz@gnu.org>
3157
3158 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3159 _stricmp and _strnicmp.
3160 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3161
62efea5e
DA
31622012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3163
3164 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3165 allocated window.
3166 (allocate_process): Likewise for new process.
8edd4a2b 3167 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3168 (allocate_frame): Likewise.
3169 * frame.c (make_frame): Omit redundant initialization.
3170 * window.c (make_parent_window): Use memset.
3171 (make_window): Omit redundant initialization.
3172 * process.c (make_process): Omit redundant initialization.
3173 * terminal.c (create_terminal): Likewise.
3174
42997f4d
DA
31752012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3176
3177 * term.c (delete_tty): Remove redundant call to memset.
3178
1130ecfc
DA
31792012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3180
3181 * alloc.c: Remove build_string.
3182 * lisp.h: Define build_string as static inline. This provides
3183 a better opportunity to optimize away calls to strlen when the
3184 function is called with compile-time constant argument.
3185 * image.c (imagemagick_error): Convert to build_string.
3186 * w32proc.c (sys_spawnve): Likewise.
3187 * xterm.c (x_term_init): Likewise.
3188
cf38a720
PE
31892012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3190
99027bdd
PE
3191 Use sprintf return value instead of invoking strlen on result.
3192 In the old days this wasn't portable, since some sprintf
3193 implementations returned char *. But they died out years ago and
3194 Emacs already assumes sprintf returns int.
3195 Similarly for float_to_string.
3196 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3197 * ccl.c (ccl_driver):
3198 * character.c (string_escape_byte8):
3199 * data.c (Fnumber_to_string):
3200 * doprnt.c (doprnt):
3201 * print.c (print_object):
3202 * xdisp.c (message_dolog):
3203 * xfns.c (syms_of_xfns):
3204 Use sprintf or float_to_string result to avoid need to call strlen.
3205 * data.c (Fnumber_to_string):
3206 Use make_unibyte_string, since the string must be ASCII.
3207 * lisp.h, print.c (float_to_string): Now returns int length.
3208 * term.c (produce_glyphless_glyph):
3209 Use sprintf result rather than recomputing it.
3210
cf38a720
PE
3211 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3212 * Makefile.in (ALL_CFLAGS):
3213 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3214 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3215
3511c784
DA
32162012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3217
0a08eb21 3218 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3219 strcasecmp if available.
3220 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3221
fb7da12e
AS
32222012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3223
3224 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3225 Avoid comma operator.
3226 * menu.c (push_submenu_start, push_submenu_end)
3227 (push_left_right_boundary, push_menu_pane): Likewise.
3228 * msdos.c (dos_rawgetc): Likewise.
3229
afa2ffd8
DA
32302012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3231
3232 * xfns.c (xic_create_fontsetname): Remove redundant calls
3233 to memset.
3234
b3b4476b
PE
32352012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3236
4495ff38
PE
3237 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3238 sprintf already null-terminates its output.
3239
b3b4476b
PE
3240 * xfns.c (x_window): Remove redundant cast.
3241
b00876c9
DA
32422012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3243
3244 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3245 `const char *' to `char *' to avoid compiler warning.
3246
d188e26b
PE
32472012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3248
885d1d74
PE
3249 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3250 instead of truncating it to 63 (admittedly a generous limit).
3251
d188e26b
PE
3252 * process.c: Fix spelling and caps in comments.
3253
e2f560b1
DN
32542012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3255
e86db54b 3256 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3257 * sysdep.c (setpgrp): Remove definition, not used in this file.
3258
7583a3a1
JB
32592012-06-24 Juanma Barranquero <lekktu@gmail.com>
3260
3261 * makefile.w32-in: Update dependencies.
3262
696056c2
EZ
32632012-06-24 Eli Zaretskii <eliz@gnu.org>
3264
3265 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3266 (SYSTIME_H): Add nt/inc/sys/time.h.
3267
3268 * systime.h [WINDOWSNT]: Include sys/time.h.
3269
3270 * s/ms-w32.h (struct timespec): Definition moved from
3271 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3272
845ca893
PE
32732012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3276 * buffer.h (buffer_slot_type_mismatch):
3277 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3278 * eval.c (unwind_to_catch):
3279 * image.c (my_png_error, my_error_exit):
3280 * keyboard.c (quit_throw_to_read_char, user_error)
3281 (Fexit_recursive_edit, Fabort_recursive_edit):
3282 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3283 (wrong_type_argument, buffer_overflow, __executable_start)
3284 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3285 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3286 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3287 (fatal):
3288 (child_setup) [!DOS_NT]:
3289 * lread.c (end_of_file_error, invalid_syntax):
3290 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3291 * puresize.h (pure_write_error):
3292 * search.c (matcher_overflow):
3293 * sound.c (sound_perror, alsa_sound_perror):
3294 * sysdep.c, syssignal.h (croak):
3295 * term.c (maybe_fatal, vfatal):
3296 * textprop.c (text_read_only):
3297 * undo.c (user_error):
3298 * unexmacosx.c (unexec_error):
3299 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3300 Use _Noreturn rather than NO_RETURN.
3301 No need for separate decl merely because of _Noreturn.
3302 * sound.c (sound_warning, parse_sound):
3303 Remove unnecessary forward decls.
3304
f1dd8073
PE
33052012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3306
3307 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3308 * lisp.h (WAIT_READING_MAX): New macro.
3309 * dispnew.c (Fsleep_for, sit_for):
3310 * keyboard.c (kbd_buffer_get_event):
3311 * process.c (Faccept_process_output):
3312 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3313 This improves on the previous patch, which introduced a bug
3314 when time_t is unsigned and as wide as intmax_t.
3315 See <http://bugs.gnu.org/9000#51>.
3316
b82c1755
EZ
33172012-06-23 Eli Zaretskii <eliz@gnu.org>
3318
3319 * dispnew.c (sit_for, Fsleep_for):
3320 * keyboard.c (kbd_buffer_get_event):
3321 * process.c (Faccept_process_output): Avoid compiler warnings when
3322 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3323
ca300656
JB
33242012-06-23 Juanma Barranquero <lekktu@gmail.com>
3325
049ec95b
JB
3326 * makefile.w32-in: Update dependencies.
3327
ca300656
JB
3328 * w32.c (ltime): Add return type and declare static.
3329 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3330
db7b8d06
PE
33312012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3332
3333 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3334 Privately reported by Herbert J. Skuhra.
3335 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3336 All uses changed.
3337 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3338 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3339
0bd8297f
EZ
33402012-06-23 Eli Zaretskii <eliz@gnu.org>
3341
96512555
EZ
3342 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3343 last argument of make_unibyte_string.
3344
0bd8297f
EZ
3345 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3346 language ID in the event parameters.
3347
3348 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3349 event.code, not the obscure "character set ID".
3350
63def6b6
CY
33512012-06-23 Chong Yidong <cyd@gnu.org>
3352
3353 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3354
e8a02204
EZ
33552012-06-23 Eli Zaretskii <eliz@gnu.org>
3356
388cdec0
EZ
3357 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3358 * w32.c (fdutimens): New function.
3359
3360 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3361
3362 * s/ms-w32.h (pselect): Redirect to sys_select.
3363
3364 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3365
e8a02204
EZ
3366 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3367 in the logic of incrementing and decrementing the value of
3368 use_relocatable_buffers.
3369
d054f3fb
PE
33702012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3371
3372 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3373 Privately reported by Herbert J. Skuhra.
3374 [__FreeBSD__]: Remove "*/" typo after "#include".
3375 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3376 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3377 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3378 Don't assume EMACS_TIME and struct timeval are the same type.
3379
d35af63c
PE
33802012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3381
3382 Support higher-resolution time stamps (Bug#9000).
3383 The time stamps are only nanosecond-resolution at the C level,
3384 since that's the best that any real-world system supports now.
3385 But they are picosecond-resolution at the Lisp level, as that's
3386 easy, and leaves room for future OS improvements.
3387
3388 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3389 (LIBES): Use it.
3390
3391 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3392 Don't get current time unless it's needed.
3393
3394 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3395 now provides it if it's absent.
3396 (start_atimer): Port to higher-res time stamps.
3397 Check for time stamp overflow. Don't get current time more
3398 often than is needed.
3399
3400 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3401 Include systime.h, not time.h.
3402 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3403
3404 * dired.c: Include stat-time.h.
3405 (Ffile-attributes): File times now have higher resolution.
3406
3407 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3408 (struct image): Timestamp now has higher resolution.
3409
3410 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3411 has at least microseconds now. All uses removed.
3412 (update_frame, update_single_window, update_window, update_frame_1)
3413 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3414
3415 * editfns.c (time_overflow): Now extern.
3416 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3417 (float-time, Fformat_time_string, Fcurrent_time_string)
3418 (Fcurrent_time_zone): Accept and generate higher-resolution
3419 time stamps.
3420 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3421 (decode_time_components, lisp_seconds_argument): New functions.
3422 (make_time): Now static.
3423 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3424 Report an error if the time is invalid, rather than having the caller
3425 do that.
3426
3427 * fileio.c: Include <stat-time.h>
3428 (Fcopy_file): Copy higher-resolution time stamps.
3429 Prefer to set the time stamp via a file descriptor if that works.
3430 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3431 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3432 (Fvisited_file_modtime, Fset_visited_file_modtime):
3433 Support higher-resolution time stamps.
3434
3435 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3436
3437 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3438
3439 * image.c (prepare_image_for_display, clear_image_cache)
3440 (lookup_image): Port to higer-resolution time stamps.
3441
3442 * keyboard.c (start_polling, bind_polling_period):
3443 Check for time stamp overflow.
3444 (read_char, kbd_buffer_get_event, timer_start_idle)
3445 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3446 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3447 Port to higher-resolution time stamps. Do not assume time_t is signed.
3448 (decode_timer): New function. Timers are now vectors of length 9,
3449 not 8, to accommodate the picosecond component.
3450 (timer_check_2): Use it.
3451
3452 * nsterm.m (select_timeout, timeval_subtract): Remove.
3453 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3454 as they're a bit more accurate and handle overflow better.
3455 (ns_select): Change prototype to be compatible with pselect.
3456 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3457 * nsterm.h (ns_select): Adjust prototype.
3458
3459 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3460 us-resolution time stamps.
3461 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3462
3463 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3464
3465 * lisp.h (time_overflow): New decl.
3466 (wait_reading_process_output): First arg is now intmax_t, not int,
3467 to accommodate larger waits.
3468
3469 * process.h (struct Lisp_Process.read_output_delay):
3470 Now counts nanoseconds, not microseconds.
3471 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3472 EMACS_HAS_USECS.
3473 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3474 (wait_reading_process_output):
3475 Port to ns-resolution time stamps.
3476 (Faccept_process_output, wait_reading_process_output):
3477 Check for time stamp overflow. Do not assume time_t is signed.
3478 (select_wrapper): Remove; we now use pselect.
3479 (Fprocess_attributes): Now generates ns-resolution time stamps.
3480
3481 * sysdep.c: Include utimens.h. Don't include utime.h
3482 or worry about struct utimbuf; gnulib does that for us now.
3483 (gettimeofday): Remove; gnulib provides a substitute.
3484 (make_timeval): New function.
3485 (set_file_times): Now sets ns-resolution time stamps.
3486 New arg FD; all uses changed.
3487 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3488 (system_process_attributes):
3489 Now returns ns-resolution time stamp. All uses changed.
3490 Check for time stamp overflow.
3491
3492 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3493 provides a substitute now.
3494
3495 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3496 since it guarantees struct timespec.
3497 (EMACS_TIME): Now struct timespec, so that we can support
3498 ns-resolution time stamps.
3499 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3500 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3501 (EMACS_USECS): Remove.
3502 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3503 so multiply the arg by 1000 before storing it.
3504 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3505 New macros.
3506 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3507 Port to ns-resolution time stamps.
3508 (EMACS_TIME_NEG_P): Remove; replaced by....
3509 (EMACS_TIME_SIGN): New macro.
3510 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3511 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3512 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3513 (make_timeval, make_lisp_time, decode_time_components): New decls.
3514 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3515 that it mishandled time_t overflow. You can't compare by subtracting!
3516 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3517 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3518
3519 * term.c: Include <sys/time.h>.
3520 (timeval_to_Time): New function, for proper overflow wraparound.
3521 (term_mouse_position, term_mouse_click): Use it.
3522
3523 * undo.c (record_first_change): Support higher-resolution time stamps
3524 in the undo buffer.
3525 (Fprimitive_undo): Use them when restoring time stamps.
3526
3527 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3528 (w32_get_internal_run_time):
3529 Port to higher-resolution Emacs time stamps.
3530 (ltime): Now accepts single 64-bit integer, as that's more convenient
3531 for callers.
3532
3533 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3534
3535 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3536 for compatibility with pselect. Support ns-resolution time stamps.
3537
3538 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3539
3540 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3541 Check for time stamp overflow, and support ns-resolution time stamps.
3542
3543 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3544 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3545 (timeval_subtract): Remove; no longer needed.
3546 (XTflash, XTring_bell, x_wait_for_event):
3547 Port to ns-resolution time stamps. Don't assume time_t is signed.
3548
b6a92dfe
CY
35492012-06-22 Chong Yidong <cyd@gnu.org>
3550
3551 * xdisp.c (x_consider_frame_title): Revert last change.
3552
d251c37c
EZ
35532012-06-22 Eli Zaretskii <eliz@gnu.org>
3554
3555 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3556 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3557 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3558 staticidx goes up to 1597 out of 1600 = 0x640.)
3559
f10deafb
PE
35602012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3561
3562 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3563 Otherwise, the umask might be mistakenly 0 while handling input signals.
3564
ec6de1e2
SM
35652012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3566
3567 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3568
28be1ada
DA
35692012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3570
3571 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3572 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3573 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3574 access to `contents' member of Lisp_Vector objects with AREF and ASET
3575 where appropriate.
3576
c6bf3022
CY
35772012-06-19 Chong Yidong <cyd@gnu.org>
3578
3579 * frame.c (delete_frame): When selecting a frame on a different
3580 text terminal, do not alter the terminal's top-frame.
3581
3582 * xdisp.c (format_mode_line_unwind_data): Record the target
3583 frame's selected window and its terminal's top-frame.
3584 (unwind_format_mode_line): Restore them.
3585 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3586 Callers changed.
3587 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3588 since tty frames can be explicitly named.
3589 (prepare_menu_bars): Likewise.
3590
3591 * term.c (Ftty_top_frame): New function.
3592
defd4196
PE
35932012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3594
3595 Port byte-code-meter to modern targets.
3596 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3597 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3598 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3599 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3600 (METER_1, METER_2): Simplify.
3601
1053a871
SM
36022012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3603
3604 * data.c (Fdefalias): Return `symbol' (bug#11686).
3605
b7e8d081
MR
36062012-06-18 Martin Rudalics <rudalics@gmx.at>
3607
3608 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3609 gets killed during executing of this function (Bug#11665).
3610 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3611 (Vkill_buffer_query_functions): In doc-string say that functions
3612 run by this hook should not change the current buffer.
3613
7ea2b339
PE
36142012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Fix recently-introduced process.c problems found by static checking.
3617 * process.c (write_queue_push, write_queue_pop, send_process):
3618 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3619 (write_queue_pop): Fix pointer signedness problem.
3620 (send_process): Remove unused local.
3621
96a313a1
CY
36222012-06-17 Chong Yidong <cyd@gnu.org>
3623
3624 * xdisp.c (redisplay_internal): No need to redisplay terminal
3625 frames that are not on top.
3626
20ca2e94
TN
36272012-06-17 Troels Nielsen <bn.troels@gmail.com>
3628
3629 * process.c (make_process): Initialize write_queue.
3630 (write_queue_push, write_queue_pop): New functions.
3631 (send_process): Use them to maintain correct ordering of process
3632 writes (Bug#10815).
3633
9a900ca9
PE
36342012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3635
310fbfa8
PE
3636 * lisp.h (eassert): Assume C89 or later.
3637 This removes the need for CHECK.
3638 (CHECK): Remove. Its comments about always evaluating its
3639 argument were confusing, as 'eassert' typically does not evaluate
3640 its argument.
3641
27bb1ca4
PE
3642 * coding.c (produce_chars): Use ptrdiff_t, not int.
3643
9a900ca9
PE
3644 * xterm.c (x_draw_underwave): Check for integer overflow.
3645 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3646
41b7f8bc 36472012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3648
3649 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3650 referenced (Bug#11583).
3651
9b0e3eba
AA
36522012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3653
3654 Implement wave-style variant of underlining.
3655 * dispextern.h (face_underline_type): New enum.
3656 (face): Add field for underline type.
3657 * nsterm.m (ns_draw_underwave): New function.
3658 (ns_draw_text_decoration): Use it.
3659 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3660 New functions.
3661 (x_draw_glyph_string): Use them.
3662 * xfaces.c (Qline, Qwave): New Lisp objects.
3663 (check_lface_attrs, merge_face_ref)
1053a871
SM
3664 (Finternal_set_lisp_face_attribute, realize_x_face):
3665 Handle wave-style underline face attributes.
9b0e3eba
AA
3666 * xterm.c (x_draw_underwave): New function.
3667 (x_draw_glyph_string): Use it.
3668
0fb52f11
JB
36692012-06-16 Juanma Barranquero <lekktu@gmail.com>
3670
3671 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3672 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3673 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3674 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3675 ($(BLD)/w32select.$(O)): Update dependencies.
3676
e5560ff7
AS
36772012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3678
3679 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3680 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3681 * character.c (_fetch_multibyte_char_p): Remove.
3682 * alloc.c: Include "character.h" before "buffer.h".
3683 * bidi.c: Likewise.
3684 * buffer.c: Likewise.
3685 * bytecode.c: Likewise.
3686 * callint.c: Likewise.
3687 * callproc.c: Likewise.
3688 * casefiddle.c: Likewise.
3689 * casetab.c: Likewise.
3690 * category.c: Likewise.
3691 * cmds.c: Likewise.
3692 * coding.c: Likewise.
3693 * composite.c: Likewise.
3694 * dired.c: Likewise.
3695 * dispnew.c: Likewise.
3696 * doc.c: Likewise.
3697 * dosfns.c: Likewise.
3698 * editfns.c: Likewise.
3699 * emacs.c: Likewise.
3700 * fileio.c: Likewise.
3701 * filelock.c: Likewise.
3702 * font.c: Likewise.
3703 * fontset.c: Likewise.
3704 * fringe.c: Likewise.
3705 * indent.c: Likewise.
3706 * insdel.c: Likewise.
3707 * intervals.c: Likewise.
3708 * keyboard.c: Likewise.
3709 * keymap.c: Likewise.
3710 * lread.c: Likewise.
3711 * macros.c: Likewise.
3712 * marker.c: Likewise.
3713 * minibuf.c: Likewise.
3714 * nsfns.m: Likewise.
3715 * nsmenu.m: Likewise.
3716 * print.c: Likewise.
3717 * process.c: Likewise.
3718 * regex.c: Likewise.
3719 * region-cache.c: Likewise.
3720 * search.c: Likewise.
3721 * syntax.c: Likewise.
3722 * term.c: Likewise.
3723 * textprop.c: Likewise.
3724 * undo.c: Likewise.
3725 * unexsol.c: Likewise.
3726 * w16select.c: Likewise.
3727 * w32fns.c: Likewise.
3728 * w32menu.c: Likewise.
3729 * window.c: Likewise.
3730 * xdisp.c: Likewise.
3731 * xfns.c: Likewise.
3732 * xmenu.c: Likewise.
3733 * xml.c: Likewise.
3734 * xselect.c: Likewise.
3735
2f07e6af
EZ
37362012-06-16 Eli Zaretskii <eliz@gnu.org>
3737
1053a871
SM
3738 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3739 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3740 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3741 row.
3742 (handle_face_prop): Use chunk-relative overlay string index when
3743 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3744 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3745 the rightmost. (Bug#11720)
2f07e6af 3746
29b83cec
AS
37472012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3748
3749 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3750 (CATEGORY_MEMBER): Enforce 1/0 value.
3751 * category.c (_temp_category_set): Remove.
3752
4c5501e9
EZ
37532012-06-16 Eli Zaretskii <eliz@gnu.org>
3754
3755 * window.c (Fdelete_other_windows_internal)
3756 (Fdelete_window_internal): Don't access frame's mouse highlight
3757 info of the initial frame. (Bug#11677)
3758
2b570124
PE
37592012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3760
e93864f9
PE
3761 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3762 Assume USE_2_TAGS_FOR_INTS.
3763 (xreload): Adjust $tagmask width to match recent lisp.h change.
3764
2b570124
PE
3765 Simplify lisp.h in minor ways that should not affect code.
3766 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3767 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3768 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3769 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3770 (INTTYPEBITS): New macro, for clarity.
3771 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3772 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3773 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3774 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3775 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3776
81755f69
JB
37772012-06-13 Juanma Barranquero <lekktu@gmail.com>
3778
3779 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3780
16192a57
GM
37812012-06-13 Glenn Morris <rgm@gnu.org>
3782
3783 * s/bsd-common.h (BSD4_3):
3784 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3785
646b5f55
AS
37862012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3787
3788 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3789 instead of union.
3790 (XLI, XIL): Define.
1053a871
SM
3791 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3792 Use them.
3793 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3794 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3795 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3796 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3797 * frame.c (delete_frame): Remove outdated comment.
3798 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3799 USE_LISP_UNION_TYPE.
3800 (Fw32_unregister_hot_key): Likewise.
3801 (Fw32_toggle_lock_key): Likewise.
3802 * w32menu.c (add_menu_item): Likewise.
3803 (w32_menu_display_help): Use XIL instead of checking
3804 USE_LISP_UNION_TYPE.
3805 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3806 (init_heap): Likewise.
3807 * w32term.c (w32_read_socket): Update comment.
3808
1d3823c9
GM
38092012-06-13 Glenn Morris <rgm@gnu.org>
3810
c62ff706
GM
3811 * s/usg5-4-common.h, src/s/unixware.h:
3812 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3813
1d3823c9
GM
3814 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3815
bfe3e0a2
PE
38162012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3817
3818 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3819 * alloc.c (make_number) [!defined make_number]:
3820 Remove, as lisp.h always defines this now.
3821 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3822 (roundup_size): Verify that it is a power of 2.
3823 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3824 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3825 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3826 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3827 USE_LSB_TAG now is always defined to be either 0 or 1.
3828 All uses changed.
3829 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3830 code works fine either way, and efficiency is not a concern here,
3831 as the union type is for debugging, not for production.
3832 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3833 Use an inline function on all platforms when using the union type,
3834 since this is simpler and 'static inline' can be used portably
3835 within Emacs now.
3836 (LISP_INITIALLY_ZERO): New macro.
3837 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3838 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3839
45fa9c0f
GM
38402012-06-12 Glenn Morris <rgm@gnu.org>
3841
b4492cba
GM
3842 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3843
3844 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3845
45fa9c0f
GM
3846 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3847 Move BROKEN_SIGIO to configure.
3848
3849 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3850 Move NO_TERMIO to configure.
3851
0e25d334
CY
38522012-06-12 Chong Yidong <cyd@gnu.org>
3853
3854 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3855 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3856 MagickExportImagePixels is undefined.
3857
43682bb6
PE
38582012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * image.c (imagemagick_load_image): Remove unused label.
3861
a9be7d2b
GM
38622012-06-11 Glenn Morris <rgm@gnu.org>
3863
3864 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3865 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3866 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3867 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3868
3017f87f
SM
38692012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3870
3871 * alloc.c (make_byte_code): New function.
3872 (Fmake_byte_code): Use it. Don't purify here.
3873 * lread.c (read1): Use it as well to avoid extra allocation.
3874
1b9b4cf4
CY
38752012-06-11 Chong Yidong <cyd@gnu.org>
3876
3877 * image.c (imagemagick_load_image): Implement transparency.
3878
95988fcf
AS
38792012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3880
3881 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3882 account for preceding backslashes. (Bug#11663)
3883
cd4eb164
CY
38842012-06-09 Chong Yidong <cyd@gnu.org>
3885
3886 * term.c: Support italics in capable terminals (Bug#9652).
3887 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3888 (turn_on_face): Output using TS_enter_italic_mode if available.
3889 Don't handle unused blinking and alt-charset cases.
3890 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3891 and tty_alt_charset_p cases.
3892 (tty_capable_p, init_tty): Support italics.
3893
3894 * termchar.h (struct tty_display_info): Add field for italics.
3895 Remove unused blink field.
3896
3897 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3898 Handle slant.
3899
3900 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3901 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3902 tty_alt_charset_p. Add tty_italic_p.
3903
ff88beb8
MA
39042012-06-09 Michael Albinus <michael.albinus@gmx.de>
3905
3906 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3907 dbus_type_is_basic if available.
3908 (xd_extract_signed, xd_extract_unsigned): Rename from
3909 extract_signed and extract_unsigned, respectively. Adapt callers.
3910
44286096
CY
39112012-06-09 Chong Yidong <cyd@gnu.org>
3912
1682701f
CY
3913 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3914
44286096
CY
3915 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3916 case (Bug#9752).
3917
d86feb17
PE
39182012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3919
3920 * xdisp.c (vmessage): Treat frame message as multibyte.
3921 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3922 would generate the diagnostic "Making \302\247 buffer-local while
3923 let-bound!".
3924
d5c20fe8
EZ
39252012-06-08 Eli Zaretskii <eliz@gnu.org>
3926
3927 * dispnew.c (showing_window_margins_p): Undo last change, which
3928 was done due to an inadvertent commit.
3929 (adjust_frame_glyphs_for_frame_redisplay): Do call
3930 showing_window_margins_p.
3931
513749ee
SM
39322012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3933
3934 * eval.c (Fmake_var_non_special): New primitive.
3935 (syms_of_eval): Defsubr it.
3936 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3937
d4a8f5c1
JB
39382012-06-08 Juanma Barranquero <lekktu@gmail.com>
3939
3940 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3941 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3942
8bbbc977
EZ
39432012-06-08 Eli Zaretskii <eliz@gnu.org>
3944
3945 * alloc.c (allocate_vectorlike): Fix last change.
3946
f3372c87
DA
39472012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3948
3949 Block-based vector allocation of small vectors.
3950 * lisp.h (struct vectorlike_header): New field `nbytes',
3951 adjust comment accordingly.
3952 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3953 to denote vector blocks. Adjust users (live_vector_p,
3954 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3955 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3956 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3957 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3958 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3959 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3960 (roundup_size): New constant.
3961 (struct vector_block): New data type.
3962 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3963 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3964 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3965 (sweep_vectors): New functions.
3966 (allocate_vectorlike): Return `zero_vector' as the only vector of
3967 0 items. Allocate new vector from block if vector size is less than
3968 or equal to VBLOCK_BYTES_MAX.
3969 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3970 (init_alloc_once): Add call to init_vectors.
3971
4f18a4ed
SM
39722012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3973
3974 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3975
86f158bc
PE
39762012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3977
3978 * doprnt.c (doprnt): Truncate multibyte char correctly.
3979 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3980 would mishandle a string argument "Xc" if X was a multibyte
3981 character of length 2: it would truncate after X's first byte
3982 rather than including all of X.
3983
c5cfcbe0
CY
39842012-06-06 Chong Yidong <cyd@gnu.org>
3985
3986 * buffer.c (word_wrap): Doc fix.
3987
c05cf390
PE
39882012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3991
0c3461de
GM
39922012-06-03 Glenn Morris <rgm@gnu.org>
3993
3994 * xdisp.c (tool-bar-style): Doc fix.
3995
c71232db
UM
39962012-06-03 Ulrich Müller <ulm@gentoo.org>
3997
3998 * Makefile.in (PAXCTL): Define.
3999 (temacs$(EXEEXT)): Disable memory randomization for the temacs
4000 binary via PaX flags if the paxctl utility is available.
4001 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
4002 Restore PaX flags to their default. (Bug#11398)
4003
383f7350
CY
40042012-06-03 Chong Yidong <cyd@gnu.org>
4005
4006 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
4007 buffer (Bug#11226).
4008
5f2c76c6
CY
40092012-06-03 Chong Yidong <cyd@gnu.org>
4010
4011 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
4012 (note_mode_line_or_margin_highlight): If there is no help echo,
4013 use mode-line-default-help-echo. Handle the case where the mouse
4014 position is past the end of the mode line string.
4015
4016 * buffer.c (buffer_local_value_1): New function, split from
4017 Fbuffer_local_value; can return Qunbound.
4018 (Fbuffer_local_value): Use it.
4019 (Vmode_line_format): Docstring tweaks.
4020
773d47f6
PE
40212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4022
4023 * sysdep.c (system_process_attributes): Improve comment.
4024
f2d6a3df
SM
40252012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
4026
4027 * keyboard.c: Export real-this-command to Elisp.
4028 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
4029 and DEFVAR it. Update all users.
4030
63810350
PE
40312012-06-02 Paul Eggert <eggert@cs.ucla.edu>
4032
7bd5c1f4
PE
4033 * minibuf.c (Fassoc_string): Remove duplicate declaration.
4034
63810350
PE
4035 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
4036 Convert pctcpu and pctmem to Lisp float properly.
4037 Let the compiler fold better, as 100.0/0x8000 is exact.
4038
a2821611
AS
40392012-06-02 Andreas Schwab <schwab@linux-m68k.org>
4040
4041 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
4042 cons_block.
4043
5fceba1d
PE
40442012-06-01 Paul Eggert <eggert@cs.ucla.edu>
4045
4046 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
4047
c98ff5dd
DA
40482012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
4049
4050 For a 'struct window', replace some Lisp_Object fields to
4051 bitfields where appropriate, remove unused fields.
4052 * window.h (struct window): Remove unused 'last_mark_x' and
4053 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
4054 change it's type from Lisp_Object to bitfield.
4055 Change type of 'force_start', 'optional_new_start',
4056 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
4057 fields from Lisp_Object to bitfield. Adjust users accordingly.
4058
ca34e0be
PE
40592012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4060
4061 Pacify gcc -Wdouble-precision when using Xaw.
4062 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
4063 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
4064 Use 'float' consistently, rather than 'float' in most places
4065 and 'double' in a couple of places.
4066
efc00ab1 40672012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
4068
4069 * xdisp.c (handle_stop): Detect whether we have overlay strings
4070 loaded by testing it->current.overlay_string_index to be
4071 non-negative, instead of checking whether n_overlay_strings is
4072 positive. (Bug#11587)
4073
efc00ab1 40742012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
4075
4076 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
4077
4078 * doc.c (Fsubstitute_command_keys): Doc fix.
4079
efc00ab1 40802012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
4081
4082 * search.c (search_buffer): Remove calls to
4083 r_alloc_inhibit_buffer_relocation, as it is now called by
4084 maybe_unify_char, which was the cause of relocation of buffer text
4085 in bug#11519.
4086
efc00ab1 40872012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
4088
4089 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4090 for the duration of call to load_charset, to avoid problems with
4091 callers of maybe_unify_char that access buffer text through C
4092 pointers.
4093
4094 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
4095 decrement the inhibition flag, instead of just setting or
4096 resetting it.
4097
ba93a187
PE
40982012-05-31 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Remove obsolete '#define static' cruft.
4101 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
4102 This #undef was "temporary" in 2000; it is no longer needed
4103 now that '#define static' has gone away.
4104 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
4105 (gray_bitmap_bits): Remove; no longer needed.
4106 All uses replaced with definiens.
4107 * xterm.c: Include "bitmaps/gray.xbm".
4108
9e4bf381
PE
41092012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 Clean up __executable_start, monstartup when --enable-profiling.
4112 The following changes affect the code only when profiling.
4113 * dispnew.c (__executable_start): Rename from safe_bcopy.
4114 Define only on platforms that need it.
4115 * emacs.c: Include <sys/gmon.h> when profiling.
4116 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4117 (__executable_start): Remove decl, since lisp.h does it now.
4118 (safe_bcopy): Remove decl; no longer has that name.
4119 (main): Coalesce #if into single bit of code, for simplicity.
4120 Cast pointers to uintptr_t, since standard libraries want integers
4121 and not pointers.
4122 * lisp.h (__executable_start): New decl.
4123
32d72c2f
GM
41242012-05-31 Glenn Morris <rgm@gnu.org>
4125
4126 * image.c (Fimagemagick_types): Doc fix.
4127
baac5bc7
JM
41282012-05-30 Jim Meyering <meyering@redhat.com>
4129
4130 * callproc.c (Fcall_process_region): Include directory component
4131 in mkstemp error message (Bug#11586).
4132
72cb32cf
PE
41332012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 * alloc.c, lisp.h (make_pure_vector): Now static.
4136
61b108cc
SM
41372012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4138
4139 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4140 Move to byte-run.el.
4141 (Fautoload): Do the hash-doc more carefully.
4142 * data.c (Fdefalias): Purify definition, except for keymaps.
4143 (Qdefun): Move from eval.c.
4144 * lisp.h (Qdefun): Remove.
4145 * lread.c (read1): Tiny simplification.
4146
471fe23d
TN
41472012-05-29 Troels Nielsen <bn.troels@gmail.com>
4148
934f3f58 4149 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4150 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4151 Bug#9642, but explicitly check that the buffer the overlay would
4152 be moved to is live and rearrange lines to make sure that errors
4153 will not put the overlay in an inconsistent state.
4154 (Fdelete_overlay): Cosmetics.
4155
85d0efd1
EZ
41562012-05-28 Eli Zaretskii <eliz@gnu.org>
4157
4158 * w32term.c (my_bring_window_to_top): New function.
4159 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4160 could be different from the original one.
4161 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4162 (Bug#11513)
4163
4164 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4165 by calling BringWindowToTop.
4166
4167 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4168 (WM_EMACS_END): Increase by one.
4169
da92a98c
PE
41702012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4171
4172 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4173 This avoids undefined behavior that might cause the eassert
4174 to not catch an out-of-range value.
4175
74d1f848
JB
41762012-05-28 Juanma Barranquero <lekktu@gmail.com>
4177
4178 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4179 Update dependencies.
4180
9e1a06fc
EZ
41812012-05-27 Eli Zaretskii <eliz@gnu.org>
4182
4183 * bidi.c (bidi_mirror_char): Fix last change.
4184
f3dd7312
AS
41852012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4186
4187 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4188 when referring to sectname field in printf format.
4189
81899c91
PE
41902012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4191
57b81a9f
PE
4192 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4193 Only r_alloc_inhibit_buffer_relocation needed to be added;
4194 the others were already declared.
4195
81899c91
PE
4196 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4197 before checking whether it's out of range. Put the check inside
4198 eassert. See
4199 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4200
33017faf 42012012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4202
4203 * callproc.c (Fcall_process): Restore a line that was accidentally
4204 commented out in the 2011-02-13 change (bug#11547).
4205
33017faf 42062012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4207
4208 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4209 defined on ralloc.c.
4210
4211 * buffer.c [REL_ALLOC]: Remove prototypes of
4212 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4213 they are now on lisp.h.
4214
4215 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4216
4217 * search.c (search_buffer): Use it to inhibit relocation of buffer
4218 text while re_search_2 is doing its job, because re_search_2 is
4219 passed C pointers to buffer text. (Bug#11519)
4220
23415acf
EZ
4221 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4222 Update value to 24.
4223
44e27368
EZ
4224 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4225 state after an additional call to move_it_in_display_line_to, keep
4226 the values of it->max_ascent and it->max_descent found for the
4227 entire line.
4228 (pos_visible_p): Revert the comparison against bottom_y to what it
4229 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4230 (Bug#11464)
4231
c1892f11
PE
42322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4233
4234 Fix coding-related core dumps with gcc -ftrapv.
4235 The code was computing A - B, where A and B are pointers, and B is
4236 random garbage. This can lead to core dumps on platforms that
4237 have special pointer registers, and it also leads to core dumps on
4238 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4239 A - B only when B is initialized properly.
4240 * coding.c (coding_set_source, coding_set_destination): Return void.
4241 (coding_change_source, coding_change_destinations): New functions,
4242 with the old behaviors of coding_set_source and coding_set_destination.
4243 All callers that need an offset changed to use these new functions.
4244
eb7afdad
GM
42452012-05-26 Glenn Morris <rgm@gnu.org>
4246
4247 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4248
f12fdf02
EZ
42492012-05-26 Eli Zaretskii <eliz@gnu.org>
4250
53a63be6 4251 Extend mouse support on W32 text-mode console.
61b108cc
SM
4252 * xdisp.c (draw_row_with_mouse_face):
4253 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4254
eb3f6f01 4255 * w32console.c: Include window.h.
61b108cc
SM
4256 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4257 New functions.
eb3f6f01
EZ
4258 (initialize_w32_display): Initialize mouse-highlight data.
4259
53a63be6
EZ
4260 * w32inevt.c: Include termchar.h and window.h.
4261 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4262 moves, call note_mouse_highlight. If help_echo changed, call
4263 gen_help_event to produce help-echo message in the echo area.
4264 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4265 highlight info.
4266
4cfd81f6
PE
42672012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4268
4269 * lread.c (read1): Simplify slightly to avoid an overflow warning
4270 with GCC 4.7.0 on x86-64.
4271
4446092a
EZ
42722012-05-26 Eli Zaretskii <eliz@gnu.org>
4273
4274 * bidi.c (bidi_mirror_char): Revert last change: an int is
4275 definitely wide enough here.
4276
42b2a986 42772012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4278
42b2a986 4279 Fix integer width and related bugs (Bug#9874).
eb106a49 4280 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4281 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4282 (string_bytes, check_sblock, allocate_string_data):
4283 (compact_small_strings, Fmake_bool_vector, make_string)
4284 (make_unibyte_string, make_multibyte_string)
4285 (make_string_from_bytes, make_specified_string)
4286 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4287 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4288 (mark_vectorlike):
4289 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4290 (allocate_pseudovector):
4291 Use int, not EMACS_INT, where int is wide enough.
4292 (inhibit_garbage_collection, Fgarbage_collect):
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4295 int might not be wide enough.
4296 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4297 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4298 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4299 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4300 (bidi_level_of_next_char, bidi_move_to_visually_next):
4301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4302 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4303 (Fkill_buffer, Fset_buffer_major_mode)
4304 (advance_to_char_boundary, Fbuffer_swap_text)
4305 (Fset_buffer_multibyte, overlays_at, overlays_in)
4306 (overlay_touches_p, struct sortvec, record_overlay_string)
4307 (overlay_strings, recenter_overlay_lists)
4308 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4309 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4310 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4311 (Foverlay_recenter, last_overlay_modification_hooks_used)
4312 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4314 (validate_region): Omit unnecessary test for b <= e,
4315 since that's guaranteed by the previous test.
d311d28c
PE
4316 (adjust_overlays_for_delete): Avoid pos + length overflow.
4317 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4318 (report_overlay_modification):
4319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4320 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4321 Omit pointer cast, which isn't needed anyway, and doesn't work
4322 after the EMACS_INT -> ptrdiff_t change.
02481186 4323 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4324 * buffer.h: Adjust decls to match defn changes elsewhere.
4325 (struct buffer_text, struct buffer):
4326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4327 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4328 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4329 not int, to avoid needless 32-bit limit on 64-bit hosts.
4330 (exec_byte_code): Use tighter memory-full test, one that checks
4331 for alloca overflow. Don't compute the address of the object just
4332 before an array, as that's not portable. Use EMACS_INT, not
4333 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4334 * callint.c (Fcall_interactively):
4335 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4336 * callproc.c (call_process_kill, Fcall_process):
4337 Don't assume pid_t fits into an Emacs fixnum.
4338 (call_process_cleanup, Fcall_process, child_setup):
4339 Don't assume pid_t fits into int.
4340 (call_process_cleanup, Fcall_process, delete_temp_file)
4341 (Fcall_process_region):
4342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4343 (Fcall_process): Simplify handling of volatile integers.
4344 Use int, not EMACS_INT, where int will do.
4345 * casefiddle.c (casify_object, casify_region, operate_on_word)
4346 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4348 (casify_object): Avoid integer overflow when overallocating buffer.
4349 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4350 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4351 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4352 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4353 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4354 integers are now checked earlier. All uses replaced with XINT.
4355 (ccl_driver):
4356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4357 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4358 (ccl_driver, Fregister_code_conversion_map):
4359 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4360 (resolve_symbol_ccl_program): Check that vector header is in range.
4361 Always copy the vector, so that we can check its contents reliably
4362 now rather than having to recheck each instruction as it's being
4363 executed. Check that vector words fit in 'int'.
4364 (ccl_get_compiled_code, Fregister_ccl_program)
4365 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4366 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4367 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4368 contents are in range.
4369 (Fccl_execute_on_string): Check that status is in range.
4370 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4371 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4372 Accept and return EMACS_INT, not int, because callers can pass values
4373 out of 'int' range.
4374 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4375 (multibyte_chars_in_text, parse_str_as_multibyte)
4376 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4377 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4378 (string_escape_byte8, Fget_byte):
4379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4380 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4381 avoid mishandling large integers.
4382 * character.h: Adjust decls to match defn changes elsewhere.
4383 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4384 (Ffind_charset_region):
4385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4386 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4387 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4388 Don't assume fixnum fits in int.
d311d28c
PE
4389 (load_charset_map_from_vector, Fmap_charset_chars):
4390 Remove now-unnecessary CHECK_NATNUMs.
4391 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4392 Don't rely on undefined behavior with signed left shift overflow.
4393 Don't assume unsigned int fits into fixnum, or that fixnum fits
4394 into unsigned int. Don't require max_code to be a valid fixnum;
4395 that's not true for gb10830 4-byte on a 32-bit host. Allow
4396 invalid_code to be a cons, for the same reason. Require code_offset
4397 to be a character. Avoid int overflow if max_char is close
4398 to INT_MAX.
4399 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4400 this is intended anyway and avoids some undefined behavior.
4401 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4402 INDEX_TO_CODE_POINT, as that's what it expects.
4403 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4404 * charset.h (DECODE_CHAR): Return int, not unsigned;
4405 this is what was intended anyway, and it avoids undefined behavior.
4406 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4407 integer-overflow issues.
4408 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4409 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4410 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4411 * chartab.c (Fmake_char_table, Fset_char_table_range)
4412 (uniprop_get_decoder, uniprop_get_encoder):
4413 Don't assume fixnum fits in int.
4414 * cmds.c (move_point): New function, that does the gist of
4415 Fforward_char and Fbackward_char, but does so while checking
4416 for integer overflow more accurately.
c96e5d6a 4417 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4418 (Fforward_line, Fend_of_line, internal_self_insert)
4419 (internal_self_insert):
4420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4421 Fix a FIXME, by checking for integer overflow when calculating
4422 target_clm and actual_clm.
4423 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4424 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4425 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4426 (coding_alloc_by_making_gap, alloc_destination)
4427 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4428 (encode_coding_utf_16, detect_coding_emacs_mule)
4429 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4430 (detect_coding_iso_2022, decode_coding_iso_2022)
4431 (encode_invocation_designation, encode_designation_at_bol)
4432 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4433 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4434 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4435 (encode_coding_ccl, encode_coding_raw_text)
4436 (detect_coding_charset, decode_coding_charset)
4437 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4438 (produce_composition, produce_charset, produce_annotation)
4439 (decode_coding, handle_composition_annotation)
4440 (handle_charset_annotation, consume_chars, decode_coding_gap)
4441 (decode_coding_object, encode_coding_object, detect_coding_system)
4442 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4443 (code_convert_region, code_convert_string)
8f50130c
PE
4444 (Fdefine_coding_system_internal)
4445 (coding_set_source, coding_set_destination):
d311d28c
PE
4446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4447 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4448 (Fdefine_coding_system_internal):
4449 Don't assume fixnums fit in int.
4450 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4451 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4452 (Funencodable_char_position, Fcheck_coding_systems_region)
4453 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4454 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4455 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4456 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4457 Don't access memory outside of the args array.
d311d28c 4458 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4459 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4460 result of ENCODE_CHAR.
d311d28c
PE
4461 * coding.h: Adjust decls to match defn changes elsewhere.
4462 (struct coding_system):
4463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4464 * composite.c (get_composition_id, find_composition)
4465 (run_composition_function, update_compositions)
4466 (compose_text, composition_gstring_put_cache)
4467 (composition_gstring_p, composition_gstring_width)
4468 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4469 (composition_compute_stop_pos, composition_reseat_it)
4470 (composition_update_it, struct position_record)
4471 (find_automatic_composition, composition_adjust_point)
4472 (Fcomposition_get_gstring, Ffind_composition_internal):
4473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4474 (update_compositions):
4475 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4476 * composite.h: Adjust decls to match defn changes elsewhere.
4477 (struct composition):
4478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4479 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4480 Do not attempt to compute the address of the object just before a
4481 buffer; this is not portable.
4482 (Faref, Faset):
4483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4484 (Faset): Use int, not EMACS_INT, where int is wide enough.
4485 (Fstring_to_number): Don't assume fixnums fit in int.
4486 (Frem): Don't assume arg is nonnegative.
4487 * dbusbind.c (xd_append_arg): Check for integers out of range.
4488 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4489 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4490 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4491 (xd_get_connection_references): Return ptrdiff_t, not int.
4492 All uses changed.
4493 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4494 (xd_read_message_1):
4495 Use int, not unsigned, where the dbus API uses int.
4496 (Fdbus_message_internal): Don't overflow mtype.
4497 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4498 * dired.c (directory_files_internal, file_name_completion, scmp)
4499 (file_name_completion_stat):
4500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4501 (file_name_completion): Don't overflow matchcount.
4502 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4503 * dispextern.h: Adjust decls to match defn changes elsewhere.
4504 (struct text_pos, struct glyph, struct bidi_saved_info)
4505 (struct bidi_string_data, struct bidi_it, struct composition_it)
4506 (struct it):
4507 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4508 (struct display_pos, struct composition_it, struct it):
4509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4510 * dispnew.c (increment_matrix_positions)
4511 (increment_row_positions, mode_line_string)
4512 (marginal_area_string):
4513 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4514 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4516 (duration_to_sec_usec): New function, to check for overflow better.
4517 (Fsleep_for, sit_for): Use it.
4518 * doc.c (get_doc_string, store_function_docstring):
4519 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4520 (get_doc_string, Fsnarf_documentation):
4521 Use int, not EMACS_INT, where int is wide enough.
4522 (get_doc_string):
4523 Use SAFE_ALLOCA, not alloca.
4524 Check for overflow when converting EMACS_INT to off_t.
4525 * doprnt.c (doprnt):
4526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4527 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4528 Don't assume uid_t fits into fixnum.
4529 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4530 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4531 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4532 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4533 (general_insert_function)
4534 (Finsert_char, make_buffer_string, make_buffer_string_both)
4535 (update_buffer_properties, Fbuffer_substring)
4536 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4537 (Fsubst_char_in_region, check_translation)
4538 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4539 (transpose_markers, Ftranspose_regions):
4540 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4541 (clip_to_bounds): Move to lisp.h as an inline function).
4542 (Fconstrain_to_field): Don't assume integers are nonnegative.
4543 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4544 (Fsubst_char_in_region, Fsave_restriction):
4545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4546 (Femacs_pid): Don't assume pid_t fits into fixnum.
4547 (lo_time): Use int, not EMACS_INT, when int suffices.
4548 (lisp_time_argument): Check for usec out of range.
4549 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4550 (Fuser_login_name, Fuser_full_name): Signal an error
4551 if a uid argument is out of range, rather than relying on
4552 undefined behavior.
c8d5c857
PE
4553 (Fformat_time_string): Remove now-unnecessary check.
4554 lisp_time_argument checks for out-of-range usec now.
243e0530 4555 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4556 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4557 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4558 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4559 (init_cmdargs, Fdump_emacs):
4560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4561 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4562 the bottom (typically) 32 bits of the fixnum.
4563 * eval.c (specpdl_size, call_debugger):
4564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4565 (when_entered_debugger, Fbacktrace_debug):
4566 Don't assume fixnum can fit in int.
4567 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4568 the object just before a buffer; this is not portable.
4569 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4570 (grow_specpdl, unbind_to):
4571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4572 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4573 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4574 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4575 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4576 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4578 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4579 (a_write, e_write):
4580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4581 (Fcopy_file, non_regular_nbytes, read_non_regular)
4582 (Finsert_file_contents):
4583 Use int, not EMACS_INT, where int is wide enough.
4584 (READ_BUF_SIZE): Verify that it fits in int.
4585 (Finsert_file_contents): Check that counts are in proper range,
4586 rather than assuming fixnums fit into ptrdiff_t etc.
4587 Don't assume fixnums fit into int.
125b3835 4588 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4589 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4590 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4591 (string_char_to_byte, string_byte_to_char)
4592 (string_make_multibyte, string_to_multibyte)
4593 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4594 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4595 (substring_both, Fdelete, internal_equal, Ffillarray)
4596 (Fclear_string, mapcar1)
4597 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4598 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4599 (larger_vector, make_hash_table, maybe_resize_hash_table)
4600 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4601 (Fmaphash, secure_hash):
4602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4603 (concat): Check for string index and length overflow.
4604 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4605 (Frequire):
4606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4607 (larger_vector): New API (vec, incr_min, size_max) replaces old
4608 one (vec, new_size, init). This catches size overflow.
4609 INIT was removed because it was always Qnil.
4610 All callers changed.
4611 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4612 the upper bound on a hash table index size.
4613 (make_hash_table, maybe_resize_hash_table): Use it.
4614 (secure_hash): Computer start_byte and end_byte only after
4615 they're known to be in ptrdiff_t range.
4616 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4617 (Ffont_get_glyphs, Ffont_at):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4620 (Flist_fonts, Fopen_font):
4621 Don't assume fixnum can fit in int.
4622 (check_gstring): Don't assume index can fit in int.
4623 (font_match_p): Check that fixnum is a character, not a nonnegative
4624 fixnum, since the later code needs to stuff it into an int.
4625 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4626 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4627 conversion overflow issues.
4628 (Fopen_font): Check for integer out of range.
4629 (Ffont_get_glyphs): Don't assume index can fit in int.
4630 * font.h: Adjust decls to match defn changes elsewhere.
4631 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4632 integer overflow.
4633 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4634 printmax_t, where ptrdiff_t is wide enough.
4635 (Finternal_char_font):
4636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4637 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4638 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4639 (Fset_frame_position, x_set_frame_parameters)
4640 (x_set_line_spacing, x_set_border_width)
4641 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4642 Check that fixnums are in proper range for system types.
4643 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4645 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4646 Use SAFE_ALLOCA_LISP, not alloca.
4647 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4648 intptr_t is wide enough.
4649 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4650 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4651 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4652 Check for fixnum out of range.
4653 * ftfont.c (ftfont_list): Don't assume index fits in int.
4654 Check that fixnums are in proper range for system types.
4655 (ftfont_shape_by_flt):
4656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4657 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4659 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4660 Check that fixnums are in proper range for system types.
4661 * gnutls.h: Adjust decls to match defn changes elsewhere.
4662 * gtkutil.c (xg_dialog_run):
4663 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4664 (update_frame_tool_bar):
4665 Check that fixnums are in proper range for system types.
4666 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4667 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4668 * indent.c (last_known_column, last_known_column_point):
4669 (current_column_bol_cache):
4670 (skip_invisible, current_column, check_display_width):
4671 (check_display_width, scan_for_column, current_column_1)
4672 (Findent_to, Fcurrent_indentation, position_indentation)
4673 (indented_beyond_p, Fmove_to_column, compute_motion):
4674 (Fcompute_motion, Fvertical_motion):
4675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4676 (last_known_column_modified): Use EMACS_INT, not int.
4677 (check_display_width):
4678 (Fcompute_motion):
4679 Check that fixnums and floats are in proper range for system types.
4680 (compute_motion): Don't assume index or fixnum fits in int.
4681 (compute_motion, Fcompute_motion):
4682 Use int, not EMACS_INT, when it is wide enough.
4683 (vmotion): Omit local var start_hpos that is always 0; that way
4684 we don't need to worry about overflow in expressions involving it.
4685 * indent.h: Adjust decls to match defn changes elsewhere.
4686 (struct position):
4687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4688 Use int, not EMACS_INT, where int is wide enough.
4689 Remove unused members ovstring_chars_done and tab_offset;
4690 all uses removed.
4691 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4692 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4693 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4694 (make_gap, copy_text, insert, insert_and_inherit)
4695 (insert_before_markers, insert_before_markers_and_inherit)
4696 (insert_1, count_combining_before, count_combining_after)
4697 (insert_1_both, insert_from_string)
4698 (insert_from_string_before_markers, insert_from_string_1)
4699 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4700 (adjust_after_replace, adjust_after_insert, replace_range)
4701 (replace_range_2, del_range, del_range_1, del_range_byte)
4702 (del_range_both, del_range_2, modify_region)
4703 (prepare_to_modify_buffer, signal_before_change)
4704 (signal_after_change, Fcombine_after_change_execute):
4705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4706 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4707 (balance_an_interval, split_interval_right, split_interval_left)
4708 (find_interval, next_interval, update_interval)
4709 (adjust_intervals_for_insertion, delete_node, delete_interval)
4710 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4711 (static_offset_intervals, offset_intervals)
4712 (merge_interval_right, merge_interval_left, make_new_interval)
4713 (graft_intervals_into_buffer, temp_set_point_both)
4714 (temp_set_point, set_point, adjust_for_invis_intang)
4715 (set_point_both, move_if_not_intangible, get_property_and_range)
4716 (get_local_map, copy_intervals, copy_intervals_to_string)
4717 (compare_string_intervals, set_intervals_multibyte_1):
4718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4719 * intervals.h: Adjust decls to match defn changes elsewhere.
4720 (struct interval):
4721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4722 * keyboard.c (this_command_key_count, this_single_command_key_start)
4723 (before_command_key_count, before_command_echo_length, echo_now)
4724 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4725 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4726 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4727 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4729 (last_non_minibuf_size, last_point_position, echo_truncate)
4730 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4731 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4732 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4733 (stuff_buffered_input):
4734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4735 (last_auto_save, command_loop_1, read_char):
4736 Use EMACS_INT, not int, to avoid integer overflow.
4737 (record_char): Avoid overflow in total_keys computation.
4738 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4739 * keyboard.h: Adjust decls to match defn changes elsewhere.
4740 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4741 (Fkey_description, Fdescribe_vector, Flookup_key):
4742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4743 (click_position): New function, to check that positions are in range.
4744 (Fcurrent_active_maps):
4745 (describe_command):
4746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4747 (Faccessible_keymaps, Fkey_description):
4748 (preferred_sequence_p):
4749 Don't assume fixnum can fit into int.
4750 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4751 Check for integer overflow in size calculations.
4752 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4753 avoid mishandling large integers.
4754 * lisp.h: Adjust decls to match defn changes elsewhere.
4755 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4756 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4757 (struct Lisp_Marker):
4758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4759 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4760 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4761 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4762 All callers changed.
4763 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4764 Assume the arg has valid form, since it always does.
4765 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4766 unsigned integer system type.
4767 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4768 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4770 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4771 (duration_to_sec_usec): New decl.
4772 * lread.c (read_from_string_index, read_from_string_index_byte)
4773 (read_from_string_limit, readchar, unreadchar, openp)
4774 (read_internal_start, read1, oblookup):
4775 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4776 (Fload, readevalloop, Feval_buffer, Feval_region):
4777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4778 (openp): Check for out-of-range argument to 'access'.
4779 (read1): Use int, not EMACS_INT, where int is wide enough.
4780 Don't assume fixnum fits into int.
6efdadfd 4781 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4782 (read_filtered_event): Use duration_to_sec_usec
4783 to do proper overflow checking on durations.
d311d28c
PE
4784 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4785 in size calculation.
4786 (Fexecute_kbd_macro):
4787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4788 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4789 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4790 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4791 (set_marker_both, set_marker_restricted_both, marker_position)
4792 (marker_byte_position, Fbuffer_has_markers_at):
4793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4794 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4795 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4796 It now merely ensures that the menu is large enough, without
4797 necessarily growing it, as this avoids some integer overflow issues.
4798 All callers changed.
4799 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4801 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4802 Use SAFE_ALLOCA_LISP, not alloca.
4803 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4804 to EMACS_INT. Check that fixnums are in proper range for system types.
4805 * minibuf.c (minibuf_prompt_width, string_to_object)
4806 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4807 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4809 (get_minibuffer, read_minibuf_unwind):
4810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4811 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4812 this simplifies overflow checking. All callers changed.
4813 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4814 (Ftest_completion):
4815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4816 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4817 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4818 Check that fixnums are in proper range for system types.
4819 (Fx_create_frame, Fx_show_tip):
4820 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4821 * nsfont.m (ns_findfonts, nsfont_list_family):
4822 Don't assume fixnum fits in long.
4823 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4825 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4826 wide enough.
17fdb222 4827 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4829 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4830 (PRINTDECLARE, PRINTPREPARE):
4831 (strout, print_string):
4832 (print, print_preprocess, print_check_string_charset_prop)
4833 (print_object):
4834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4835 (PRINTDECLARE):
4836 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4838 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4839 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4840 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4841 (print_error_message): Use SAFE_ALLOCA, not alloca.
4842 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4843 (print_depth, new_backquote_output, print_number_index):
4844 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4845 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4846 (Fset_process_window_size, Fformat_network_address)
4847 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4848 (sigchld_handler):
d311d28c 4849 Check that fixnums are in proper range for system types.
d44287d4 4850 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4851 Check for process-ids out of pid_t range rather than relying on
4852 undefined behavior.
e4d81efc 4853 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4854 (Fformat_network_address, read_process_output, send_process)
4855 (Fprocess_send_region, status_notify):
4856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4857 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4858 (wait_reading_process_output, read_process_output, exec_sentinel):
4859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4860 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4861 (Faccept_process_output): Use duration_to_sec_usec to do proper
4862 overflow checking on durations.
dde14581
PE
4863 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4864 Don't assume pid_t fits in int.
02481186
PE
4865 * process.h (struct Lisp_Process): Members tick and update_tick
4866 are now of type EMACS_INT, not int.
b62b53e8
PE
4867 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4868 configured --with-wide-int.
d311d28c
PE
4869 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4870 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4871 * search.c (looking_at_1, string_match_1):
4872 (fast_string_match, fast_c_string_match_ignore_case)
4873 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4874 (scan_newline, find_before_next_newline, search_command)
4875 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4876 (set_search_regs, wordify):
4877 (Freplace_match):
4878 (Fmatch_data):
4879 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4880 (string_match_1, search_buffer, set_search_regs):
4881 (Fmatch_data):
4882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4883 (wordify): Check for overflow in size calculation.
4884 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4885 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4886 Check that fixnums are in proper range for system types.
4887 * sound.c (struct sound_device)
4888 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4890 (Fplay_sound_internal):
4891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4892 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4893 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4894 (Fparse_partial_sexp):
4895 Don't assume fixnums can fit in int.
4896 (struct lisp_parse_state, find_start_pos, find_start_value)
4897 (find_start_value_byte, find_start_begv)
4898 (update_syntax_table, char_quoted, dec_bytepos)
4899 (find_defun_start, prev_char_comend_first, back_comment):
4900 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4901 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4903 (Finternal_describe_syntax_value): Check that match_lisp is a
4904 character, not an integer, since the code stuffs it into int.
4905 (scan_words, scan_sexps_forward):
4906 Check that fixnums are in proper range for system types.
4907 (Fforward_word):
4908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4909 (scan_sexps_forward):
4910 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4911 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4912 * syntax.h: Adjust decls to match defn changes elsewhere.
4913 (struct gl_state_s):
4914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4915 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4916 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4917 * sysdep.c (wait_for_termination_1, wait_for_termination)
4918 (interruptible_wait_for_termination, mkdir):
4919 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4920 (emacs_read, emacs_write):
4921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4922 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4923 and double all fit in int.
d311d28c
PE
4924 * term.c (set_tty_color_mode):
4925 Check that fixnums are in proper range for system types.
4926 * termhooks.h (struct input_event):
4927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4928 * textprop.c (validate_interval_range, interval_of)
4929 (Fadd_text_properties, set_text_properties_1)
4930 (Fremove_text_properties, Fremove_list_of_text_properties)
4931 (Ftext_property_any, Ftext_property_not_all)
4932 (copy_text_properties, text_property_list, extend_property_ranges)
4933 (verify_interval_modification):
4934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4935 (Fnext_single_char_property_change)
4936 (Fprevious_single_char_property_change):
4937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4938 (copy_text_properties):
4939 Check for integer overflow in index calculation.
d311d28c
PE
4940 * undo.c (last_boundary_position, record_point, record_insert)
4941 (record_delete, record_marker_adjustment, record_change)
4942 (record_property_change):
4943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4944 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4945 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4946 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4947 (Fx_hide_tip, Fx_file_dialog):
4948 * w32menu.c (set_frame_menubar):
4949 Use ptrdiff_t, not int, for consistency with rest of code.
4950 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4951 (select_window, Fdelete_other_windows_internal)
4952 (window_scroll_pixel_based, window_scroll_line_based)
4953 (Frecenter, Fset_window_configuration):
4954 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4955 (Fset_window_hscroll, run_window_configuration_change_hook)
4956 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4957 (Fscroll_other_window, Frecenter):
d311d28c
PE
4958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4959 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4960 Don't assume fixnum fits in int.
4961 (Fset_window_scroll_bars):
4962 Check that fixnums are in proper range for system types.
4963 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4964 (string_pos, c_string_pos, number_of_chars, init_iterator)
4965 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4966 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4967 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4968 (face_before_or_after_it_pos, handle_invisible_prop)
4969 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4970 (display_prop_intangible_p, string_buffer_position_lim)
4971 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4972 (get_overlay_strings_1, get_overlay_strings)
4973 (iterate_out_of_display_property, forward_to_next_line_start)
4974 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4975 (get_next_display_element, set_iterator_to_next)
4976 (get_visually_first_element, compute_stop_pos_backwards)
4977 (handle_stop_backwards, next_element_from_buffer)
4978 (move_it_in_display_line_to, move_it_in_display_line)
4979 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4980 (add_to_log, message_dolog, message_log_check_duplicate)
4981 (message2, message2_nolog, message3, message3_nolog
4982 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4983 (current_message_1, truncate_echo_area, truncate_message_1)
4984 (set_message, set_message_1, store_mode_line_noprop)
4985 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4986 (text_outside_line_unchanged_p, check_point_in_composition)
4987 (reconsider_clip_changes)
4988 (redisplay_internal, set_cursor_from_row, try_scrolling)
4989 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4990 (redisplay_window, find_last_unchanged_at_beg_row)
4991 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4992 (trailing_whitespace_p, find_row_edges, display_line)
4993 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4994 (display_mode_element, store_mode_line_string)
4995 (pint2str, pint2hrstr, decode_mode_spec)
4996 (display_count_lines, display_string, draw_glyphs)
4997 (x_produce_glyphs, x_insert_glyphs)
4998 (rows_from_pos_range, mouse_face_from_buffer_pos)
4999 (fast_find_string_pos, mouse_face_from_string_pos)
5000 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5002 (safe_call, init_from_display_pos, handle_fontified_prop)
5003 (handle_single_display_spec, load_overlay_strings)
5004 (with_echo_area_buffer, setup_echo_area_for_printing)
5005 (display_echo_area, echo_area_display)
5006 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
5007 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
5008 (redisplay_window, dump_glyph_row, display_mode_line)
5009 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 5010 (handle_display_spec, display_prop_string_p):
d311d28c
PE
5011 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5012 (handle_single_display_spec, build_desired_tool_bar_string)
5013 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
5014 (get_specified_cursor_type):
5015 Check that fixnums are in proper range for system types.
5016 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
5017 (Flookup_image_map):
5018 Don't assume fixnums fit in int.
5019 (compare_overlay_entries):
5020 Avoid mishandling comparisons due to subtraction overflow.
5021 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
5022 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
5023 (handle_tool_bar_click):
5024 Use int, not unsigned, since we prefer signed and the signedness
5025 doesn't matter here.
5026 (get_next_display_element, next_element_from_display_vector):
5027 Use int, not EMACS_INT, when int is wide enough.
5028 (start_hourglass): Use duration_to_sec_usec to do proper
5029 overflow checking on durations.
5030 * xfaces.c (Fbitmap_spec_p):
5031 Check that fixnums are in proper range for system types.
5032 (compare_fonts_by_sort_order):
5033 Avoid mishandling comparisons due to subtraction overflow.
5034 (Fx_family_fonts, realize_basic_faces):
5035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5036 (Fx_family_fonts):
5037 Don't assume fixnum fits in int.
5038 Use SAFE_ALLOCA_LISP, not alloca.
5039 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
5040 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
5041 (face_at_buffer_position, face_for_overlay_string)
5042 (face_at_string_position):
5043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5044 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
5045 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
5046 (Fx_show_tip):
5047 Check that fixnums are in proper range for system types.
5048 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
5049 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
5050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5051 (Fx_change_window_property): Don't assume fixnums fit in int.
5052 * xfont.c (xfont_chars_supported):
5053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5054 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
5055 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
5056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5057 * xml.c (parse_region):
5058 * xrdb.c (magic_file_p):
5059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
5060 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
5061 (x_get_local_selection, x_reply_selection_request)
5062 (x_handle_selection_request, wait_for_property_change):
5063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5064 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
5065 short is wide enough.
5066 (x_send_client_event): Don't assume fixnum fits in int.
5067 * xterm.c (x_x_to_emacs_modifiers):
5068 Don't assume EMACS_INT overflows nicely into int.
5069 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
5070 may come from Lisp.
5071 (handle_one_xevent): NATNUMP can eval its arg twice.
5072 (x_connection_closed):
5073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5074 * xterm.h: Adjust decls to match defn changes elsewhere.
5075 (struct scroll_bar): Use struct vectorlike_header
5076 rather than rolling our own approximation.
5077 (SCROLL_BAR_VEC_SIZE): Remove; not used.
5078
c6574eb5
GM
50792012-05-25 Glenn Morris <rgm@gnu.org>
5080
5081 * lisp.mk (lisp): Update for more files being compiled now.
5082
e8d32c7e
SM
50832012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
5084
48def666
SM
5085 * lread.c: Remove `read_pure' which makes no difference.
5086 (read_pure): Remove var.
5087 (unreadpure): Remove function.
5088 (readevalloop): Don't call read_list with -1 flag.
5089 (read1, read_vector): Don't test read_pure any more.
5090 (read_list): Simplify.
5091
e8d32c7e
SM
5092 * fileio.c, character.h: Minor style tweaks.
5093
4b2addb7
DA
50942012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
5095
5096 * window.h (clip_changed): Remove useless declaration.
5097
584461b2
JB
50982012-05-22 Juanma Barranquero <lekktu@gmail.com>
5099
5100 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
5101 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
5102
34374650
PE
51032012-05-22 Paul Eggert <eggert@cs.ucla.edu>
5104
5105 Remove src/m/*.
5106 This directory predates autoconf and is no longer needed nowadays.
5107 Move its few remaining bits of functionality to where they're needed.
5108 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
5109 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
5110 * m/template.h: Remove.
5111 * Makefile.in (M_FILE): Remove. All uses removed.
5112 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
5113 * lisp.h (USE_LSB_TAG):
5114 * mem-limits.h (EXCEEDS_LISP_PTR):
5115 Use VAL_MAX, not VALBITS, in #if.
5116 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5117 (EMACS_UINT): Define unconditionally now.
5118 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5119 (BITS_PER_EMACS_INT): New constants, replacing
5120 what used to be in config.h, but not useful in #if.
5121 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5122 define them any more.
5123 (VAL_MAX): New macro.
5124 (VALMASK): Use it.
5125 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5126 BITS_PER_EMACS_INT, in #if.
5127 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5128 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5129 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5130 * s/ms-w32.h (DATA_START):
5131 Move here from removed file m/intel386.h.
5132 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5133 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5134
261cb4bb
PE
51352012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5136
5137 Assume C89 or later.
5138 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5139 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5140 (xrealloc):
5141 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5142 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5143 * textprop.c, tparam.c (NULL): Remove.
5144 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5145 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5146 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5147 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5148 * xterm.c (input_signal_count): Assume volatile works.
5149
ff23cd9f
KB
51502012-05-21 Ken Brown <kbrown@cornell.edu>
5151
5152 * xgselect.c (xg_select): Fix first argument in call to 'select'
5153 (bug#11508).
5154
1b170bc6
KB
51552012-05-20 Ken Brown <kbrown@cornell.edu>
5156
5157 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5158 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5159
b2f4d39f
KB
51602012-05-19 Ken Brown <kbrown@cornell.edu>
5161
5162 * xfns.c (x_in_use): Remove `static' qualifier.
5163 * xterm.h (x_in_use): Declare.
5164 * xgselect.c: Include xterm.h.
5165 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5166 and `display_arg' (bug#9754).
5167
003fdae2
PE
51682012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5169
9232a6d9
PE
5170 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5171
003fdae2
PE
5172 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5173 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5174
784b56e2
EZ
51752012-05-18 Eli Zaretskii <eliz@gnu.org>
5176
5177 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5178
5179 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5180 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5181
5182 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5183 reference to image_cache->refcount.
5184 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5185
a0a79cde
JL
51862012-05-17 Juri Linkov <juri@jurta.org>
5187
5188 * search.c (Fword_search_regexp, Fword_search_backward)
5189 (Fword_search_forward, Fword_search_backward_lax)
5190 (Fword_search_forward_lax): Move functions to isearch.el
5191 (bug#10145, bug#11381).
5192
b0572523
PE
51932012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5194
5195 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5196
9660f5fc
SM
51972012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5198
5199 * lread.c (init_obarray): Declare Qt and Qnil as special.
5200
4374de83
GM
52012012-05-14 Glenn Morris <rgm@gnu.org>
5202
5203 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5204 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5205
dc44c39a
PE
52062012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5207
078c97cb
PE
5208 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5209
dc44c39a
PE
5210 * unexaix.c: Port to more-recent AIX compilers.
5211 (report_error, report_error_1, make_hdr, copy_sym)
5212 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5213 Make arguments const char *, not char *, to avoid violations of C
5214 standard and to fix some AIX warnings reported by Gilles Pion.
5215
e18afed7 52162012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5217
5218 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5219 already have overlays loaded.
5220 (handle_single_display_spec): Before returning without displaying
5221 fringe bitmap, synchronize the bidi iterator with the main display
5222 iterator, by calling iterate_out_of_display_property.
5223 (iterate_out_of_display_property): Detect buffer iteration by
5224 testing that it->string is a Lisp string.
5225 (get_next_display_element): When the current object is exhausted,
5226 and there's something on it->stack, call set_iterator_to_next to
5227 proceed with what's on the stack, instead of returning zero.
5228 (set_iterator_to_next): If called at the end of a Lisp string,
5229 proceed to consider_string_end without incrementing string
5230 position. Don't increment display vector index past the end of
5231 the display vector. (Bug#11417)
c8fb9dc6
EZ
5232 (pos_visible_p): Don't report a position visible when move_it_to
5233 stopped at the last line of window, which happens to be scanned
5234 backwards by the bidi iteration. (Bug#11464)
ac268e67 5235
e18afed7 52362012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5237
5238 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5239 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5240 are on a TTY, and thus unable to display on the fringes.
5241 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5242 so we need to signal to the caller that this is a "replacing"
5243 display spec. This fixes display when the spec is invalid or we
5244 are on a TTY.
5245
e18afed7 52462012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5247
5248 * unexaix.c (make_hdr): Fix typo in prototype.
5249 This bug broke the build on AIX. Problem reported by Gilles Pion.
5250
9d0a235a
MA
52512012-05-14 Michael Albinus <michael.albinus@gmx.de>
5252
5253 * keyboard.c (kbd_buffer_get_event): Read special events also in
5254 batch mode. (Bug#11415)
5255
9e6b06ed
GM
52562012-05-12 Glenn Morris <rgm@gnu.org>
5257
5258 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5259
c1a1d7a3
EZ
52602012-05-12 Eli Zaretskii <eliz@gnu.org>
5261
5262 * lisp.mk (lisp): Add newcomment.elc.
5263
3fe7cdc8
GM
52642012-05-12 Glenn Morris <rgm@gnu.org>
5265
5266 * Makefile.in (MKDIR_P): New, set by configure.
5267 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5268
53f7d2c0
PE
52692012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5270
5271 Remove unused function hourglass_started.
5272 * dispextern.h (hourglass_started):
5273 * w32fns.c (hourglass_started):
5274 * xdisp.c (hourglass_started): Remove.
5275
75aafb17
JB
52762012-05-10 Juanma Barranquero <lekktu@gmail.com>
5277
5278 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5279 Update dependencies.
5280
12959e8e
PE
52812012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5282
97107e2e
PE
5283 * xgselect.c (xg_select): Put maxfds+1 into a var.
5284 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5285
12959e8e
PE
5286 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5287
836d29b3
DA
52882012-05-10 Dave Abrahams <dave@boostpro.com>
5289
5290 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5291 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5292
5cb67954
MA
52932012-05-09 Michael Albinus <michael.albinus@gmx.de>
5294
5295 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5296 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5297 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5298 Initialize xd_registered_buses.
5299
3478ec45
PE
53002012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5301
b263a6b0
PE
5302 Untag more efficiently if USE_LSB_TAG.
5303 This is based on a proposal by YAMAMOTO Mitsuharu in
5304 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5305 For an admittedly artificial (nth 8000 longlist) benchmark on
5306 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5307 Emacs's overall text size by 1%.
5308 * lisp.h (XUNTAG): New macro.
5309 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5310 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5311 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5312 * eval.c (Fautoload):
5313 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5314 * frame.h (XFRAME): Use XUNTAG.
5315
3478ec45
PE
5316 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5317 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5318 Remove unportable assumptions about print widths of types like
5319 dbus_uint32_t.
5320 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5321 intptr_t when converting between pointer and integer, to avoid GCC
5322 warnings about wrong width.
5323
666b903b 53242012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5325
5326 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5327 stack for each reader_thread, instead of defaulting to 8MB
5328 determined by the linker. This avoids failures in creating
5329 subprocesses on Windows 7, see the discussion in this thread:
5330 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5331
b120cc17
JC
53322012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5333
5334 Fix up display of the *Minibuf-0* buffer in the mini window.
5335 * keyboard.c (read_char): Don't clear the echo area if there's no
5336 message to clear.
5337 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5338 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5339
9a4b36f8
MA
53402012-05-07 Michael Albinus <michael.albinus@gmx.de>
5341
5342 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5343 batch mode.
5344
e5f9458f
CY
53452012-05-06 Chong Yidong <cyd@gnu.org>
5346
5347 * lisp.mk (lisp): Update.
5348
eceeb5fc 53492012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5350
5351 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5352
71873e2b
SM
53532012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5354
5355 * data.c (PUT_ERROR): New macro.
5356 (syms_of_data): Use it. Add new error type `user-error'.
5357 * undo.c (user_error): New function.
5358 (Fprimitive_undo): Use it.
5359 * print.c (print_error_message): Adjust print style for `user-error'.
5360 * keyboard.c (user_error): New function.
5361 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5362
ab0fa4e4
PE
53632012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5364
5365 Do not limit current-time-string to years 1000..9999.
5366 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5367 (Fcurrent_time_string): Support any year that is supported by the
5368 underlying localtime representation. Don't use asctime, as it
5369 has undefined behavior for years outside the range -999..9999.
5370
7ed806a7
PE
53712012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5372
5373 Fix race conditions involving setenv, gmtime, localtime, asctime.
5374 Without this fix, interrupts could mess up code that uses these
5375 nonreentrant functions, since setting TZ invalidates existing
5376 tm_zone or tzname values, and since most of these functions return
5377 pointers to static storage.
5378 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5379 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5380 Grow the critical sections to include not just invoking
5381 localtime/gmtime, but also accessing these functions' results
5382 including their tm_zone values if any, and any related TZ setting.
5383 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5384 so that the struct tm is saved in the critical section.
5385 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5386 motivated by the fact that memory allocation needs to be outside
5387 the critical section.
5388
0c16dfed
DA
53892012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5390
5391 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5392 with RESET_INTERVAL.
5393
5394 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5395 Remove duplicated buffer name initialization.
5396
3f83ace8
JM
53972012-05-02 Jim Meyering <jim@meyering.net>
5398
5399 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5400
c7b8541e
JM
5401 * xfns.c (x_window): Use xstrdup (Bug#11375).
5402
90207a15 54032012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5404
5405 * xdisp.c (pos_visible_p): If already at a newline from the
5406 display string before the 'while' loop, don't walk back the glyphs
5407 from it3.glyph_row. Solves assertion violation when the display
5408 string begins with a newline (egg.el). (Bug#11367)
5409
b593d6a9
AH
54102012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5411
5412 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5413 Move to simple.el.
5414
4737362e
GM
54152012-05-01 Glenn Morris <rgm@gnu.org>
5416
99cf43f9
GM
5417 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5418 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5419 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5420 All were removed before 23.1.
5421
9311dcff
GM
5422 * dispnew.c: Remove HAVE_LIBNCURSES test;
5423 it is always true on relevant platforms.
5424
4d5c6349
GM
5425 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5426 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5427
4737362e
GM
5428 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5429
74dd3a6b
AS
54302012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5431
5432 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5433 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5434 Remove.
5435
13c379ee
PE
54362012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5437
5438 Do not avoid creating empty evaporating overlays (Bug#9642).
5439 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5440 That is, do not delete an evaporating overlay if it becomes
5441 empty after its bounds are adjusted to fit within its buffer.
5442 This fix caused other problems, and I'm reverting it until we get
5443 to the bottom of them.
5444
a8e7d6d7 54452012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5446
5447 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5448
a8e7d6d7 54492012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5450
5451 * xdisp.c (pos_visible_p): If the window start position is beyond
5452 ZV, start the display from buffer beginning. Prevents assertion
5453 violation in init_iterator when the minibuffer window is scrolled
5454 via the scroll bar.
5455
5456 * window.c (window_scroll_pixel_based): Likewise.
5457
a8e7d6d7 54582012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5459
5460 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5461
a8e7d6d7 54622012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5463
5464 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5465 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5466
a8e7d6d7 54672012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5468
b593d6a9
AH
5469 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5470 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5471
1c6900d9
EZ
54722012-04-26 Eli Zaretskii <eliz@gnu.org>
5473
4c3fa1d9
EZ
5474 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5475 display element, check also the underlying string or buffer
5476 character. (Bug#11341)
5477
1c6900d9
EZ
5478 * w32menu.c: Include w32heap.h.
5479 (add_menu_item): If the call to AppendMenuW (via
5480 unicode_append_menu) fails, disable Unicode menus only if we are
5481 running on Windows 9X/Me.
5482
42bf8205
AS
54832012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5484
5485 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5486 (xgetint): Add missing shift for LSB tags.
5487
b1bac16e
MR
54882012-04-24 Martin Rudalics <rudalics@gmx.at>
5489
5490 * keyboard.c (read_char): Don't wipe echo area for select window
5491 events: These might get delayed via `mouse-autoselect-window'
5492 (Bug#11304).
5493
d69621cc
JB
54942012-04-24 Juanma Barranquero <lekktu@gmail.com>
5495
5496 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5497 manipulation of :loaded-from data.
5498
02fd101b
JB
54992012-04-23 Juanma Barranquero <lekktu@gmail.com>
5500
5501 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5502 now a cons (bug#11311).
5503
888bec30
PE
55042012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5505
89a438bd
PE
5506 Do not create empty overlays with the evaporate property (Bug#9642).
5507 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5508 if it becomes empty after its bounds are adjusted to fit within
5509 its buffer. Without this fix, in a nonempty buffer (let ((o
5510 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5511 yields an empty overlay that has the evaporate property, which is
5512 not supposed to happen.
5513
1068fe4d
PE
5514 Fix minor GTK3 problems found by static checking.
5515 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5516 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5517 (struct _EmacsFixedClass, emacs_fixed_get_type):
5518 Move decls here from emacsgtkfixed.h, since they needn't be public.
5519 (emacs_fixed_get_type): Now static.
5520 (emacs_fixed_class_init): Omit unused local.
5521 (emacs_fixed_child_type): Remove; unused.
5522 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5523 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5524 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5525 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5526 (EMACS_FIXED_GET_CLASS): Remove; unused.
5527 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5528
888bec30
PE
5529 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5530 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5531
de85e130
PE
55322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5533
d0baac98 5534 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5535 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5536 (__malloc_size_t, __malloc_ptrdiff_t):
5537 Remove. All uses removed, replaced by the definiens if needed,
5538 since we can assume C89 or better now.
5539 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5540 (protect_malloc_state, align, get_contiguous_space)
5541 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5542 (malloc_atfork_handler_child, malloc_enable_thread)
5543 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5544 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5545 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5546 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5547 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5548 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5549 Define using prototypes, not old style.
5550 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5551 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5552 (align): Don't assume that signed integer overflow wraps around.
5553 Omit unused local var.
5554 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5555 (_free_internal_nolock, memalign, mallochook, reallochook):
5556 Omit no-longer-needed casts.
5557 (valloc): Use getpagesize, not __getpagesize.
5558 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5559 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5560
de85e130
PE
5561 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5562
dcbf5805
MA
55632012-04-22 Michael Albinus <michael.albinus@gmx.de>
5564
5565 Move functions from C to Lisp. Make non-blocking method calls
5566 the default. Implement further D-Bus standard interfaces.
5567
5568 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5569 (QCdbus_request_name_allow_replacement)
5570 (QCdbus_request_name_replace_existing)
5571 (QCdbus_request_name_do_not_queue)
5572 (QCdbus_request_name_reply_primary_owner)
5573 (QCdbus_request_name_reply_in_queue)
5574 (QCdbus_request_name_reply_exists)
5575 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5576 (QCdbus_registered_serial, QCdbus_registered_method)
5577 (QCdbus_registered_signal): New Lisp objects.
5578 (XD_DEBUG_MESSAGE): Use sizeof.
5579 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5580 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5581 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5582 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5583 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5584 (xd_signature, xd_append_arg): Allow float for integer types.
5585 (xd_get_connection_references): New function.
b593d6a9
AH
5586 (xd_get_connection_address): Rename from xd_initialize.
5587 Return cached address.
dcbf5805
MA
5588 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5589 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5590 level.
5591 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5592 Return number of refcounts.
dcbf5805
MA
5593 (Fdbus_get_unique_name): Make stronger parameter check.
5594 (Fdbus_message_internal): New defun.
5595 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5596 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5597 (Fdbus_send_signal, Fdbus_register_service)
5598 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5599 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5600 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5601 (Vdbus_compiled_version, Vdbus_runtime_version)
5602 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5603 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5604 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5605 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5606 Adapt docstring.
dcbf5805 5607
52828e02
PE
56082012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5609
da05bc4c
PE
5610 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5611 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5612 Do not assume ptrdiff_t is the same width as 'int'.
5613
52828e02
PE
5614 * alloc.c: Handle unusual debugging option combinations.
5615 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5616 since the two debugging options are incompatible.
5617 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5618 is defined.
5619 (mem_init, mem_insert, mem_insert_fixup):
5620 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5621 (NEED_MEM_INSERT): Remove; no longer needed.
5622
f01769f9
LL
56232012-04-22 Leo Liu <sdl.web@gmail.com>
5624
5625 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5626
5790543d
PE
56272012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5628
5629 * sysdep.c [__FreeBSD__]: Minor cleanups.
5630 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5631 Use Emacs indenting style more consistently. Avoid some casts.
5632 Use 'double' consistently rather than mixing 'float' and 'double'.
5633
b91b7e4d
EW
56342012-04-21 Eduard Wiebe <usenet@pusto.de>
5635
b593d6a9
AH
5636 * sysdep.c (list_system_processes, system_process_attributes):
5637 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5638
6114eb15
AS
56392012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5640
5641 * lisp.mk (lisp): Update.
5642
2f38dff7
PE
56432012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5646 It is never used otherwise.
5647
4ae29f89
SM
56482012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5649
5650 * print.c (print_preprocess): Only check print_depth if print-circle
5651 is nil.
5652 (print_object): Check for cycles even when print-circle is nil and
5653 print-gensym is t, but only check print_depth if print-circle is nil.
5654
f30d612a
CY
56552012-04-20 Chong Yidong <cyd@gnu.org>
5656
5657 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5658 set the status to "failed" and ensure that sentinel is run.
5659
c07a4c0b 56602012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5661
5662 * process.c (Fset_process_inherit_coding_system_flag)
5663 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5664 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5665
c07a4c0b 56662012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5667
5668 * xdisp.c (string_buffer_position_lim): Limit starting position to
5669 BEGV.
5670 (set_cursor_from_row): If called for a mode-line or header-line
5671 row, return zero immediately.
5672 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5673 farther than the first row after the header line, if any.
5674 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5675 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5676
c07a4c0b 56772012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5678
4ae29f89
SM
5679 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5680 (bug#11238).
ad3a2b41 5681
c07a4c0b 56822012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 56832012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5684
5685 configure: new option --enable-gcc-warnings (Bug#11207)
5686 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5687 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5688 (ALL_CFLAGS): Use new macros rather than old.
5689 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5690 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5691 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5692 -Wunused-result, -Wunused-variable. This should go away once
5693 the Emacs and Gnulib regex code is merged.
5694 (xmalloc, xrealloc): Now static.
5695
aba027e8
PE
56962012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5697
5698 * dired.c (Fsystem_groups): Remove unused local.
5699
e5a36063
GM
57002012-04-17 Glenn Morris <rgm@gnu.org>
5701
5702 * dired.c (Fsystem_users): Doc fix.
5703
316411f0
DA
57042012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5705
5706 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5707 (syms_of_dired): Add them.
5708
9426aba4
PE
57092012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5710
b62a57be
PE
5711 Fix minor alloc.c problems found by static checking.
5712 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5713 New extern decls, to avoid calling undeclared functions.
5714 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5715 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5716 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5717 (NEED_MEM_INSERT): New macro.
5718 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5719 Remove one incorrect comment and fix another.
b62a57be 5720
3539f31f
PE
5721 Fix minor ralloc.c problems found by static checking.
5722 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5723 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5724 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5725 (r_alloc_sbrk): Now static.
5726
a041960a
PE
5727 Improve ralloc.c interface checking.
5728 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5729 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5730 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5731 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5732 [REL_ALLOC]: ... to here, to check interface.
5733 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5734 Remove decls. This fixes an "It stinks!".
5735
9426aba4
PE
5736 * alloc.c (which_symbols): Fix alignment issue / type clash.
5737
d55c12ed
AS
57382012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5739
5740 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5741 (struct Lisp_Misc_Any): Likewise.
5742 (struct Lisp_Free): Likewise.
5743 * alloc.c (union aligned_Lisp_Symbol): Define.
5744 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5745 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5746 (union aligned_Lisp_Misc): Define.
5747 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5748 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5749 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5750
b948ce8b
PE
57512012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5752
5753 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5754 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5755 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5756 * s/netbsd.h, s/sol2-6.h:
5757 Remove definition of GC_MARK_STACK, since the default now works.
5758 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5759 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5760 no longer the default.
5761 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5762
35dc09a1 57632012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5764
35dc09a1
GM
5765 * lread.c (lisp_file_lexically_bound_p):
5766 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5767
35dc09a1
GM
57682012-04-14 Eli Zaretskii <eliz@gnu.org>
5769
5770 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5771 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5772
57732012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5774
5775 * nsterm.m (constrainFrameRect): Always constrain when there is only
5776 one screen (Bug#10962).
5777
bcd86815
KB
57782012-04-13 Ken Brown <kbrown@cornell.edu>
5779
5780 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5781
c25df26e
RT
57822012-04-13 Reuben Thomas <rrt@sc3d.org>
5783
5784 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5785
0fc59f1e
DC
57862012-04-11 Daniel Colascione <dancol@dancol.org>
5787
5788 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5789 against is gone. It's better to use vfork now so that when Cygwin
5790 gains a new, working vfork, we use it automatically (bug#10398).
5791
de8c03dc
SM
57922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5793
5794 * window.c (save_window_save): Obey window-point-insertion-type.
5795
2f097256
GM
57962012-04-11 Glenn Morris <rgm@gnu.org>
5797
5798 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5799
453b951e
SM
58002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5801
5802 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5803
75f1671a 58042012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5805
5806 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5807 (force_quit_count): New var.
5808 (handle_interrupt): Use it.
5809
2a8ce227
JB
58102012-04-10 Juanma Barranquero <lekktu@gmail.com>
5811
5812 * w32.c (w32_delayed_load): Record the full path of the library
5813 being loaded (bug#10424).
5814
935396c0
GM
58152012-04-09 Glenn Morris <rgm@gnu.org>
5816
05920a43
GM
5817 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5818 not just in the obarray, before snarfing them. (Bug#11036)
5819
935396c0
GM
5820 * Makefile.in ($(leimdir)/leim-list.el):
5821 Pass EMACS rather than BUILT_EMACS.
5822
a18ecafa
TZ
58232012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5824
5825 * process.c (make_process):
5826 * process.h: Add integer `gnutls_handshakes_tried' member to
5827 process struct.
5828
6bbef4e5
JC
5829 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5830 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5831
5832 * gnutls.c (gnutls_log_function2i): Convenience log function.
5833 (emacs_gnutls_read): Use new log functions,
5834 `gnutls_handshakes_tried' process member, and
5835 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5836 attempts per process (connection).
5837
b4d3bc10
CY
58382012-04-09 Chong Yidong <cyd@gnu.org>
5839
5840 * eval.c (Fuser_variable_p, user_variable_p_eh)
5841 (lisp_indirect_variable): Functions deleted.
5842 (Fdefvar): Caller changed.
5843
5844 * callint.c (Finteractive, Fcall_interactively):
5845 * minibuf.c (Fread_variable): Callers changed.
5846
70f4d973
EZ
58472012-04-09 Eli Zaretskii <eliz@gnu.org>
5848
5849 * xdisp.c (set_cursor_from_row): If the display string appears in
5850 the buffer at position that is closer to point than the position
5851 after the display string, display the cursor on the first glyph of
5852 the display string. Fixes cursor display when a 'display' text
5853 property immediately follows invisible text. (Bug#11094)
5854
cb3c2e3e
PE
58552012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5856
5857 composite.c: use 'double' consistently
5858 * composite.c (get_composition_id): Use 'double' consistently
5859 instead of converting 'float' to 'double' and vice versa; this is
5860 easier to understand and avoids a GCC warning.
5861
fd06db5d
GM
58622012-04-09 Glenn Morris <rgm@gnu.org>
5863
50fe702a
GM
5864 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5865 preparation for dumping it with emacs. (Bug#4789)
5866 (leimdir): New variable.
5867 ($(leimdir)/leim-list.el): New rule.
5868 (emacs$(EXEEXT)): Depend on leim-list.el.
5869
fd06db5d
GM
5870 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5871 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5872 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5873
55c131ee
AS
58742012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5875
5876 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5877 proper alignment.
5878
9209588f
JB
58792012-04-07 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5882 Remove unused local variable.
5883
e3fb2efb
PE
58842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5887 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5888 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5889 objects, as mark_maybe_pointer will catch them otherwise.
5890 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5891 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5892
b5385551
PE
58932012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5894
5895 Fix typo that broke non-Windows builds.
5896 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5897
9078ead6
EZ
58982012-04-07 Eli Zaretskii <eliz@gnu.org>
5899
5900 Support building on MS-Windows with libxml2.
5901
5902 * makefile.w32-in (OBJ2): Add xml.$(O).
5903 (GLOBAL_SOURCES): Add xml.c.
5904 ($(BLD)/xml.$(O)): New dependency list.
5905
5906 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5907 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5908 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5909 [!WINDOWSNT]: New macros.
5910 (init_libxml2_functions, libxml2_loaded_p): New functions.
5911 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5912 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5913 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5914 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5915 linked in).
6bbef4e5
JC
5916 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5917 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5918 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5919
5920 * emacs.c: Don't include libxml/parser.h.
5921 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5922 xmlCleanupParser directly.
5923
5924 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5925
3811fdf3
EZ
59262012-04-07 Eli Zaretskii <eliz@gnu.org>
5927
5928 * indent.c (Fvertical_motion): If there is a display string at
5929 point, use it.vpos to compute how many lines to backtrack after
5930 move_it_to point. (Bug#11133)
5931
2f8e16b2
EZ
59322012-04-06 Eli Zaretskii <eliz@gnu.org>
5933
5934 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5935 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5936 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5937 macros related to unification of CJK characters. For the details,
5938 see the discussion following the message here:
5939 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5940
3d439cd1
CY
59412012-04-04 Chong Yidong <cyd@gnu.org>
5942
5943 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5944
8bc53d00
EZ
59452012-04-01 Eli Zaretskii <eliz@gnu.org>
5946
5947 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5948 instead of alloca. (Bug#11138)
5949
3b0512a3
AS
59502012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5951
5952 * w32menu.c (is_simple_dialog): Properly check lisp types.
5953 (Bug#11141)
5954
8427ddd2
EZ
59552012-03-31 Eli Zaretskii <eliz@gnu.org>
5956
979022ef
EZ
5957 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5958 position we get to after a call to move_it_to fails the
5959 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5960 only if we wind up in a string from display property. (Bug#11063)
5961
a6b1c7cc
EZ
5962 * window.c (Fdelete_other_windows_internal): Invalidate the row
5963 and column information about mouse highlight, so that redisplay
5964 restores it after reallocating the glyph matrices. (Bug#7464)
5965
8427ddd2
EZ
5966 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5967 string comes from a `display' text property, use the buffer
5968 position of that property as if we actually saw that position in
5969 the row's glyphs.
697ba24b
EZ
5970 (move_it_by_lines): Remove the assertion that
5971 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5972 violated when there's a before-string at the beginning of a line.
5973 (Bug#11063)
8427ddd2 5974
65a0a738
EZ
59752012-03-30 Eli Zaretskii <eliz@gnu.org>
5976
5977 * xdisp.c (append_space_for_newline): If the default face was
5978 remapped, use the remapped face for the appended newline.
5979 (extend_face_to_end_of_line): Use the remapped default face for
5980 extending the face to the end of the line.
5981 (display_line): Call extend_face_to_end_of_line when the default
5982 face was remapped. (Bug#11068)
5983
581355cc
EZ
59842012-03-29 Eli Zaretskii <eliz@gnu.org>
5985
5986 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5987
e8fc049f
SM
59882012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5989
5990 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5991
4fb9a543
GM
59922012-03-27 Glenn Morris <rgm@gnu.org>
5993
5994 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5995 Doc fixes.
5996
679910f1
KH
59972012-03-26 Kenichi Handa <handa@m17n.org>
5998
5999 * dispextern.h (struct glyph): Fix previous change. Change the
6000 bit length of glyphless.ch to 25 (Bug#11082).
6001
90d49b7f
CY
60022012-03-26 Chong Yidong <cyd@gnu.org>
6003
6004 * keyboard.c (Vselection_inhibit_update_commands): New variable.
6005 (command_loop_1): Use it; inhibit selection update for
6006 handle-select-window too (Bug#8996).
6007
f514f6f0
FP
60082012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
6009
e8fc049f 6010 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 6011
bf43fa51
KH
60122012-03-25 Kenichi Handa <handa@m17n.org>
6013
6014 * dispextern.h (struct glyph): Change the bit length of
6015 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
6016
8a0c01dd
EZ
60172012-03-24 Eli Zaretskii <eliz@gnu.org>
6018
6019 * s/ms-w32.h (tzname): Include time.h before redirecting to
6020 _tzname. Fixes the MSVC build. (Bug#9960)
6021
7d1c3a76
AS
60222012-03-24 Andreas Schwab <schwab@linux-m68k.org>
6023
8ed79523
AS
6024 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
6025 characters.
6026
7d1c3a76
AS
6027 * xterm.c (XTread_socket): Only modify handling_signal if
6028 !SYNC_INPUT. (Bug#11080)
6029
e99a9b8b
EZ
60302012-03-23 Eli Zaretskii <eliz@gnu.org>
6031
6032 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
6033 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
6034 when fetching a multibyte character consumes more bytes than
6035 CHAR_BYTES returns, due to unification of CJK characters in
6036 string_char. (Bug#11073)
6037
5063c0e1
TN
60382012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
6039
6040 * process.c (wait_reading_process_output): Handle pty disconnect
6041 by refraining from sending oneself a SIGCHLD (bug#10933).
6042
9f851fbd
CY
60432012-03-22 Chong Yidong <cyd@gnu.org>
6044
6045 * dispextern.h (struct it): New member string_from_prefix_prop_p.
6046
5063c0e1 6047 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
6048 Mark string as coming from a prefix property.
6049 (handle_face_prop): Use default face for prefix strings (Bug#4281).
6050 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
6051
fb5b8aca
CY
60522012-03-21 Chong Yidong <cyd@gnu.org>
6053
6054 * xfaces.c (Vface_remapping_alist): Doc fix.
6055
62356a1b
EZ
60562012-03-20 Eli Zaretskii <eliz@gnu.org>
6057
6058 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
6059 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
6060 Doc fixes.
62356a1b 6061
025de85b
CY
60622012-03-20 Chong Yidong <cyd@gnu.org>
6063
6064 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
6065 to reflect default non-nil value of redisplay-dont-pause.
6066
4827f94e
KH
60672012-03-19 Kenichi Handa <handa@m17n.org>
6068
6069 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
6070 it fit in a valid range (Bug#11003).
6071
e50a24a2
EZ
60722012-03-18 Eli Zaretskii <eliz@gnu.org>
6073
6074 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
6075 that is not from display property, accept the row as a "cursor
6076 row" if one of the string's character has a non-nil `cursor'
6077 property. Fixes cursor positioning when there are newlines in
6078 overlay strings, e.g. in icomplete.el. (Bug#11035)
6079
9af5ed87
PE
60802012-03-12 Paul Eggert <eggert@cs.ucla.edu>
6081
6082 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
6083
d1f55f16
CY
60842012-03-12 Chong Yidong <cyd@gnu.org>
6085
6086 * eval.c (inhibit_lisp_code): Rename from
6087 inhibit_window_configuration_change_hook; move from window.c.
6088
6089 * xfns.c (unwind_create_frame_1, Fx_create_frame):
6090 * window.c (run_window_configuration_change_hook)
6091 (syms_of_window): Callers changed.
6092
66c5eebd
CY
60932012-03-11 Chong Yidong <cyd@gnu.org>
6094
413df973
CY
6095 * keymap.c (Fkey_description): Doc fix (Bug#9700).
6096
66c5eebd
CY
6097 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
6098
1de11f56
CY
60992012-03-10 Chong Yidong <cyd@gnu.org>
6100
6101 * frame.c (other_visible_frames): Don't assume the selected frame
6102 is visible (Bug#10955).
6103
cae07000
SM
61042012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
6105
6106 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
6107
89c94350
JD
61082012-03-08 Jan Djärv <jan.h.d@swipnet.se>
6109
6110 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
6111 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
6112 zero (Bug#10954).
6113
999dd333
GM
61142012-03-03 Glenn Morris <rgm@gnu.org>
6115
01a6dcc8 6116 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6117
de0100f2
EZ
61182012-03-02 Eli Zaretskii <eliz@gnu.org>
6119
6120 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6121 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6122 (redisplay_window, next_element_from_string): Fix typos in
6123 comments.
3e441275
EZ
6124 (redisplay_window): Pass to move_it_vertically the margin in
6125 pixels, not in screen lines.
de0100f2 6126
96a72ee9
GM
61272012-03-02 Glenn Morris <rgm@gnu.org>
6128
6129 * buffer.c (buffer-list-update-hook): Doc fix.
6130
312508d7
EZ
61312012-02-29 Eli Zaretskii <eliz@gnu.org>
6132
6133 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6134 push_it before setting up the iterator for the first overlay
6135 string, even if we have an empty string loaded.
6136 (next_overlay_string): If there's an empty string on the iterator
6137 stack, pop the stack. (Bug#10903)
6138
27f3c637
PE
61392012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6140
6141 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6142 Suggested by Stefan Monnier in
6143 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6144 * alloc.c (widen_to_Lisp_Object): New static function.
6145 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6146 and widening them to Lisp_Objects. This would work even if
6147 USE_LSB_TAG is defined and wide integers are used, which might
6148 happen in a future version of Emacs.
6149
3c9dfce6
CY
61502012-02-25 Chong Yidong <cyd@gnu.org>
6151
fa74b241
CY
6152 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6153 Doc fix.
6154
3c9dfce6
CY
6155 * xselect.c (Fx_selection_exists_p): Doc fix.
6156 (x_clipboard_manager_save_all): Print an informative message
6157 before saving to clipboard manager.
6158
9486df08
CY
61592012-02-24 Chong Yidong <cyd@gnu.org>
6160
6161 * keyboard.c (process_special_events): Handle all X selection
6162 requests in kbd_buffer, not just the next one (Bug#8869).
6163
f01d3321
CY
61642012-02-23 Chong Yidong <cyd@gnu.org>
6165
6166 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6167 call when setting menu-bar-lines and tool-bar-lines parameters.
6168 (unwind_create_frame_1): New helper function.
6169
6170 * window.c (inhibit_window_configuration_change_hook): New var.
6171 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6172 (syms_of_window): Initialize it.
f01d3321 6173
86b847b6
CY
61742012-02-22 Chong Yidong <cyd@gnu.org>
6175
6176 * xterm.c (x_draw_image_relief): Add missing type check for
6177 Vtool_bar_button_margin (Bug#10743).
6178
a59225b1
CY
61792012-02-21 Chong Yidong <cyd@gnu.org>
6180
6181 * fileio.c (Vfile_name_handler_alist): Doc fix.
6182
6183 * buffer.c (Fget_file_buffer): Protect against invalid file
6184 handler return value.
6185
310f5bd4
PE
61862012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6187
cb3a28cc
PE
6188 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6189 when computing $valmask.
6190
310f5bd4
PE
6191 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6192 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6193 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6194 It's useless in that case, and it can cause problems on hosts
6195 that allocate halves of EMACS_INT values separately.
6196 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6197 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6198 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6199 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6200 it avoids undefined behavior on hosts where shifting right by more
6201 than the word width has undefined behavior.
6202
2375c96a
CY
62032012-02-19 Chong Yidong <cyd@gnu.org>
6204
6205 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6206 (Funhandled_file_name_directory, Ffile_name_as_directory)
6207 (Fdirectory_file_name, Fexpand_file_name)
6208 (Fsubstitute_in_file_name): Protect against invalid file handler
6209 return values (Bug#10845).
6210
3eb49e71
EZ
62112012-02-18 Eli Zaretskii <eliz@gnu.org>
6212
6213 * .gdbinit (pitx): Fix incorrect references to fields of the
6214 iterator stack.
6215
7b926f3f
CY
62162012-02-17 Chong Yidong <cyd@gnu.org>
6217
6218 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6219
11273115
PE
62202012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6221
6222 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6223 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6224
c3a70e2b
CY
62252012-02-15 Chong Yidong <cyd@gnu.org>
6226
6227 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6228 marked as special. Also, starting docstrings with * is obsolete.
6229
0ca43699
AS
62302012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6231
6232 * gnutls.c (emacs_gnutls_write): Fix last change.
6233
2e8f3c56
LI
62342012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6235
6236 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6237 send_process.
6238
af70074f
SM
62392012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6240
6241 * keymap.c (Fsingle_key_description): Handle char ranges.
6242
95986d52
CY
62432012-02-12 Chong Yidong <cyd@gnu.org>
6244
afd83bd1
CY
6245 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6246 as that creates a dangerous corner case.
6247
95986d52
CY
6248 * window.c (Fdelete_window_internal): Invalidate the mouse
6249 highlight (Bug#9904).
6250
bd7da63e
GM
62512012-02-12 Glenn Morris <rgm@gnu.org>
6252
6253 * xselect.c (Fx_own_selection_internal)
6254 (Fx_get_selection_internal, Fx_disown_selection_internal)
6255 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6256 * nsselect.m (Fx_own_selection_internal)
6257 (Fx_disown_selection_internal, Fx_selection_exists_p)
6258 (Fx_selection_owner_p, Fx_get_selection_internal):
6259 Sync docs and argument specs with the xselect.c versions.
6260
77abcbc2
LI
62612012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6262
6263 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6264
90b671e2
EZ
62652012-02-11 Eli Zaretskii <eliz@gnu.org>
6266
1c0ca0b7
EZ
6267 * w32select.c (Fx_selection_exists_p): Sync doc string and
6268 argument list with xselect.c. (Bug#10783)
6269
6270 * w16select.c (Fx_selection_exists_p): Sync doc string and
6271 argument list with xselect.c. (Bug#10783)
90b671e2 6272
49241268
GM
62732012-02-10 Glenn Morris <rgm@gnu.org>
6274
6275 * fns.c (Fsecure_hash): Doc fix.
6276
f998bbe7 62772012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6278
6279 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6280
0992bd9c
CY
62812012-02-07 Chong Yidong <cyd@gnu.org>
6282
6283 * buffer.c (Fbuffer_local_variables)
6284 (buffer_lisp_local_variables): Handle unbound vars correctly;
6285 don't let Qunbound leak into Lisp.
6286
af008560
GM
62872012-02-07 Glenn Morris <rgm@gnu.org>
6288
dd605cc4
GM
6289 * image.c (Fimagemagick_types): Doc fix.
6290
af008560
GM
6291 * image.c (imagemagick-render-type): Change it from a lisp object
6292 to an integer. Move the doc here from the lisp manual.
6293 Treat all values not equal to 0 the same.
6294
1449fa1d
CY
62952012-02-06 Chong Yidong <cyd@gnu.org>
6296
6297 * doc.c (store_function_docstring): Avoid applying docstring of
6298 alias to base function (Bug#2603).
6299
3723ec07
AS
63002012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6301
6302 * .gdbinit (pp1, pv1): Remove redundant defines.
6303 (pr): Use pp.
6304
79c1cc1e
CY
63052012-02-04 Chong Yidong <cyd@gnu.org>
6306
6307 * nsterm.m: Declare a global (Bug#10694).
6308
d7f29f8e
EZ
63092012-02-04 Eli Zaretskii <eliz@gnu.org>
6310
cae07000
SM
6311 * w32.c (get_emacs_configuration_options):
6312 Include --enable-checking, if specified, in the return value.
d7f29f8e 6313
3b95a6f9
MR
63142012-02-04 Martin Rudalics <rudalics@gmx.at>
6315
6316 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6317 after rounding frame sizes. (Bug#9723)
6318
d6fa96a6
EZ
63192012-02-04 Eli Zaretskii <eliz@gnu.org>
6320
6321 * keyboard.c (adjust_point_for_property): Don't position point
6322 before BEGV. (Bug#10696)
6323
df0b2940
PE
63242012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6325
6326 Handle overflow when computing char display width (Bug#9496).
6327 * character.c (char_width): Return EMACS_INT, not int.
6328 (char_width, c_string_width): Check for overflow when
6329 computing the width; this is possible now that individual
6330 characters can have unbounded width. Problem introduced
6331 by merge from Emacs 23 on 2012-01-19.
6332
6bee44d6
MA
63332012-02-02 Michael Albinus <michael.albinus@gmx.de>
6334
6335 * dbusbind.c (Fdbus_register_method): Mention the return value
6336 :ignore in the docstring.
6337
44f92739
GM
63382012-02-02 Glenn Morris <rgm@gnu.org>
6339
1b9f60cc
GM
6340 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6341
44f92739
GM
6342 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6343 Unconditionally set to t. (Bug#10673)
6344 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6345 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6346 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6347
c5d3843c
KH
63482012-02-02 Kenichi Handa <handa@m17n.org>
6349
6350 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6351 0, do not call append_composite_glyph.
6352
159462d4 63532012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6354
6355 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6356 NULL (Bug#6988).
6357 (x_produce_glyphs): If the component of a composition is a null
6358 string, set it->pixel_width to 1 to avoid zero-width glyph.
6359
78cef877
EZ
63602012-02-01 Eli Zaretskii <eliz@gnu.org>
6361
6362 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6363 first 2 arguments are identical. This makes inserting large
6364 output from a subprocess an order of magnitude faster on
6365 MS-Windows, where all sbrk'ed memory is always contiguous.
6366
97897668
GM
63672012-01-31 Glenn Morris <rgm@gnu.org>
6368
6369 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6370 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6371 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6372
31fd3586
GM
63732012-01-29 Glenn Morris <rgm@gnu.org>
6374
6375 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6376
0e24a8b2
CY
63772012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6378
6379 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6380
cc0adcb0
CY
63812012-01-28 Chong Yidong <cyd@gnu.org>
6382
6383 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6384
acc28cb9
CY
63852012-01-26 Chong Yidong <cyd@gnu.org>
6386
9c69cfb7
CY
6387 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6388
acc28cb9
CY
6389 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6390 repeat counts (Bug#10507).
6391
48da7392
GM
63922012-01-26 Glenn Morris <rgm@gnu.org>
6393
6394 * lread.c (syms_of_lread): Doc fix.
6395
14af5f7f
CY
63962012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6397
6398 * coding.c (encode_designation_at_bol): Change return value to
6399 EMACS_INT.
6400
0b21c100
CY
64012012-01-25 Chong Yidong <cyd@gnu.org>
6402
6403 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6404
3c2907f7
CY
64052012-01-21 Chong Yidong <cyd@gnu.org>
6406
6407 * floatfns.c (Fcopysign): Make the second argument non-optional,
6408 since nil is not allowed anyway.
6409
959ad23f
AS
64102012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6411
6412 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6413 (send_process): Likewise.
6414
34a02f46
MR
64152012-01-19 Martin Rudalics <rudalics@gmx.at>
6416
6417 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6418 (Vwindow_persistent_parameters): Do not use Qstate.
6419 Rewrite doc-strings.
34a02f46 6420
1259009a 64212012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6422
6423 * character.c (char_width): New function.
70d4fdf6
GM
6424 (Fchar_width, c_string_width, lisp_string_width):
6425 Use char_width (Bug#9496).
25ed9e61 6426
6a6ee00d
MR
64272012-01-16 Martin Rudalics <rudalics@gmx.at>
6428
6429 * window.c (Vwindow_persistent_parameters): New variable.
6430 (Fset_window_configuration, save_window_save): Handle persistent
6431 window parameters.
6432
c85efaf7
EZ
64332012-01-14 Eli Zaretskii <eliz@gnu.org>
6434
6435 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6436 thrashing the stack of the thread. (Bug#9087)
6437
5944709e
PE
64382012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6439
6440 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6441
e71f5d99
EZ
64422012-01-11 Eli Zaretskii <eliz@gnu.org>
6443
6444 * xdisp.c (rows_from_pos_range): Handle the case where the
6445 highlight ends on a newline. (Bug#10464)
6446 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6447 he end column for display of highlight that ends on a newline
6448 before a R2L line.
6449
ce316182
GM
64502012-01-11 Glenn Morris <rgm@gnu.org>
6451
6452 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6453 from load-path also when installation-directory is nil. (Bug#10208)
6454
5b43da69
GM
64552012-01-10 Glenn Morris <rgm@gnu.org>
6456
74cc8ff9
GM
6457 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6458
7d8d6e4e
GM
6459 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6460 Update template values to be closer to their typical values these days.
5b43da69 6461
a0db8d43
EZ
64622012-01-09 Eli Zaretskii <eliz@gnu.org>
6463
6464 * xdisp.c (rows_from_pos_range): Accept additional argument
6465 DISP_STRING, and accept any glyph in a row whose object is that
6466 string as eligible for mouse highlight. Fixes mouse highlight of
6467 display strings from overlays. (Bug#10464)
6468
9a0115ab 64692012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6470
b9110d6a 6471 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6472 * fileio.c (auto_saving_dir_umask): New static var.
6473 (Fmake_directory_internal): Use it.
6474 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6475 creating the directory. The old code temporarily assigns
6476 too-generous permissions to the directory.
6477 (do_auto_save_eh): Clear it.
b9110d6a 6478 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6479 that the var is always cleared.
6480
6c1bd3f3
EZ
64812012-01-07 Eli Zaretskii <eliz@gnu.org>
6482
6483 * search.c (scan_buffer): Pass character positions to
6484 know_region_cache, not byte positions. (Bug#6540)
6485
069d2b50
L
64862012-01-07 LynX <_LynX@bk.ru> (tiny change)
6487
6488 * w32.c (sys_rename): Report EXDEV when rename of a directory
6489 fails because the target is on another logical disk. (Bug#10284)
6490
75bf0d33
DB
64912012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6492
6493 * xterm.c (x_embed_request_focus): New function.
6494
6495 * xterm.h: Add prototype.
6496
6497 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6498
1c6e5a32
GM
64992012-01-05 Glenn Morris <rgm@gnu.org>
6500
6501 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6502
651e947e
EZ
65032012-01-01 Eli Zaretskii <eliz@gnu.org>
6504
6505 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6506 Load gnutls_transport_set_lowat only if GnuTLS version is below
6507 2.11.1.
6508 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6509 GnuTLS versions below 2.11.1.
6510
3778cdd8
AL
65112011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6512
6513 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6514 to the doc string advising against its use for altering the way
6515 windows are scrolled.
6516
0e5317f7
KH
65172011-12-28 Kenichi Handa <handa@m17n.org>
6518
6519 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6520 coding-system ASCII compatible only when it does not produce BOM
6521 on encoding (Bug#10383).
6522
93d5ca1f
JD
65232011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6524
6525 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6526 can scroll.
6527 (create_and_show_popup_menu): Always use menu_position_func for
6528 Gtk3 (Bug#10361).
6529
ca22b785
AS
65302011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6531
6532 * callint.c (Fcall_interactively): Don't truncate prompt string.
6533
d048e1e6
EZ
65342011-12-23 Eli Zaretskii <eliz@gnu.org>
6535
6536 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6537 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6538 resumed from there (after widening). (Bug#10360)
d048e1e6 6539
5ccaba1f
JD
65402011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6541
6542 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6543
204ee57f
JD
65442011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6545
b81d40f0
JB
6546 * nsterm.m (x_free_frame_resources):
6547 Release f->output_data.ns->miniimage.
204ee57f
JD
6548 (ns_index_color): Fix indentation. Do not retain
6549 color_table->colors[i].
6550
6551 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6552 before returning.
6553
6554 * nsfns.m (x_set_background_color): Assign return value from
6555 ns_index_color to face-background instead of NSColor*.
6556 (ns_implicitly_set_icon_type): Fix indentation.
6557 Change assignment in for loop to comparison.
6558
6559 * emacs.c (ns_pool): New variable.
6560 (main): Assign ns_pool.
6561 (Fkill_emacs): Call ns_release_autorelease_pool.
6562
6563 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6564 autorelease fdesc, release fdAttrs and tdict.
6565 (ns_get_covering_families): Release charset.
6566 (ns_findfonts): Release NSFontDescriptor created with new.
6567 (ns_uni_to_glyphs): Fix indentation.
6568 (setString): Release attrStr before assigning new value.
6569
c803b2b7
JD
65702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6571
678f4426
JD
6572 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6573 and NS_IMPL_COCOA.
6574 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6575 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6576
cd394be1 65772011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6578
5fecd5fc
JD
6579 * nsterm.m (ns_term_init): Subscribe for notifications
6580 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6581 to method trackingNotification in EmacsMenu.
6582
6583 * nsmenu.m (trackingMenu): New variable.
3771cb17 6584 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6585 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6586 from Aquamacs (Bug#7030).
678f4426
JD
6587
65882011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6589
c803b2b7
JD
6590 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6591 (symbol_to_nsstring): Fix indentation.
6592 (ns_symbol_to_pb): New function.
cae07000
SM
6593 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6594 (Fns_rotate_cut_buffers_internal): Remove.
6595 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6596 Fns_store_cut_buffer_internal.
6597 (ns_get_foreign_selection, Fx_own_selection_internal)
6598 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6599 (Fns_get_selection_internal, Fns_store_selection_internal):
6600 Use ns_symbol_to_pb and check if return value is nil.
6601 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6602 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6603 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6604 renamed to Sns_store_selection_internal.
6605 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6606 and remove this function.
6607 (ns_handle_selection_clear): Remove, never used.
6608 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6609 here.
6610
e1b01a3a
KB
66112011-12-17 Ken Brown <kbrown@cornell.edu>
6612
6613 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6614 GID is unknown (Bug#10257).
6615
2adb6e85
PE
66162011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6617
6618 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6619 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6620 which caused a build failure on GNU/Linux IA-64. This problem was
6621 introduced by my 2011-10-07 patch.
6622
d1d7b339
JL
66232011-12-15 Juri Linkov <juri@jurta.org>
6624
6625 * image.c (imagemagick_error): New function. (Bug#10112)
6626 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6627 Use `imagemagick_error' where ImageMagick functions return
6628 `MagickFalse'.
6629 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6630 proper order.
6631
100d5755
KH
66322011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6633
6634 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6635 fill background (Bug#8992).
6636
454592a6
MR
66372011-12-13 Martin Rudalics <rudalics@gmx.at>
6638
6639 * window.c (Vwindow_combination_resize)
6640 (Vwindow_combination_limit): Use t instead of non-nil in
6641 doc-strings.
61d4b438
MR
6642 (Vrecenter_redisplay): Add first sentence of doc-string on
6643 separate line.
53524d93 6644 (Frecenter): Fix doc-string typo.
454592a6 6645
3633e3aa
KH
66462011-12-11 Kenichi Handa <handa@m17n.org>
6647
6648 * coding.c (Funencodable_char_position): Pay attention to the
6649 buffer text relocation (Bug#9389).
6650
7b9d523a 66512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6652
7b9d523a
JD
6653 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6654 gtk_init (Bug#10100).
6655
b73189c6
EZ
66562011-12-10 Eli Zaretskii <eliz@gnu.org>
6657
6658 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6659 IT->string is nil. (Bug#10263)
6660
f7dfe5d6
JD
66612011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6662
83faebb4
JD
6663 * nsterm.h (x_free_frame_resources): Declare.
6664
f7dfe5d6
JD
6665 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6666 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6667
6668 * nsterm.h (ns_get_defaults_value): Declare.
6669
6670 * nsterm.m (ns_default): Call ns_get_defaults_value.
6671
7cd4e72c
EZ
66722011-12-09 Eli Zaretskii <eliz@gnu.org>
6673
6674 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6675 (Bug#10170)
6676
b34d7317
YM
66772011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6678
6679 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6680 that where the value of an _OBJC_* symbol points to is in the .bss
6681 section (Bug#10240).
6682
76470ad1
KH
66832011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6684
6685 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6686 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6687
745fff94
KH
66882011-12-08 Kenichi Handa <handa@m17n.org>
6689
6690 * ftfont.c (get_adstyle_property): Fix previous change
6691 (Bug#10233).
6692
6e44397c
JB
66932011-12-07 Juanma Barranquero <lekktu@gmail.com>
6694
6695 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6696 dirs from the default value of EMACSLOADPATH (bug#10208).
6697
7efa6272
GM
66982011-12-07 Glenn Morris <rgm@gnu.org>
6699
6700 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6701 installation and source directories as well. (Bug#10208)
6702
f6fc4d87
CY
67032011-12-06 Chong Yidong <cyd@gnu.org>
6704
6705 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6706
2bf26180
GM
67072011-12-06 Glenn Morris <rgm@gnu.org>
6708
6709 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6710 as an error, not just -1. (Bug#10217)
6711
3a6ad4f0
CY
67122011-12-05 Chong Yidong <cyd@gnu.org>
6713
6714 * keyboard.c (process_special_events): New function.
6715 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6716
75a3b399
PE
67172011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6718
6719 * coding.c (encode_designation_at_bol): Don't use uninitialized
6720 local variable (Bug#9318).
6721
c3c9e25e
KH
67222011-12-05 Kenichi Handa <handa@m17n.org>
6723
6724 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6725 return Qnil (Bug#8046, Bug#10193).
6726
5eb05ea3
KH
67272011-12-05 Kenichi Handa <handa@m17n.org>
6728
6729 * coding.c (encode_designation_at_bol): New args charbuf_end and
6730 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6731 (coding_set_source): Return how many bytes coding->source was
6732 relocated.
6733 (coding_set_destination): Return how many bytes
6734 coding->destination was relocated.
6735 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6736 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6737
67382011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6739
6740 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6741 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6742 macro (Bug#9318).
6743
67442011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6745
6746 The following changes are to fix Bug#9318.
6747
a79703f5 6748 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6749 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6750 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6751 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6752
7dbda6df
JB
67532011-12-05 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * lisp.h (process_quit_flag): Fix external declaration.
6756
6d5eb5b0
SM
67572011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6758
6759 Don't macro-inline non-performance-critical code.
6760 * eval.c (process_quit_flag): New function.
6761 * lisp.h (QUIT): Use it.
6762
a0c3fad0
JD
67632011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6764
6765 * nsfns.m (get_geometry_from_preferences): New function.
6766 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6767
6c07aac2
AS
67682011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6769
6770 * emacs.c (Qkill_emacs): Define.
6771 (syms_of_emacs): Initialize it.
6772 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6773 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6774 (quit_throw_to_read_char): Add parameter `from_signal'.
6775 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6776 * lisp.h (QUIT): Call Fkill_emacs if requested.
6777
c052ead4
JD
67782011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6779
6780 * widget.c (update_wm_hints): Return if wmshell is null.
6781 (widget_update_wm_size_hints): New function.
6782
6783 * widget.h (widget_update_wm_size_hints): Declare.
6784
6785 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6786 widget_update_wm_size_hints (Bug#10104).
6787
9e49252b
EZ
67882011-12-03 Eli Zaretskii <eliz@gnu.org>
6789
6790 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6791 before a newline, prepare the bidi iterator for consuming the
6792 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6793 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6794
02b16839
JL
67952011-12-02 Juri Linkov <juri@jurta.org>
6796
6797 * search.c (Fword_search_regexp): New Lisp function created from
6798 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6799 (Fword_search_backward, Fword_search_forward)
6800 (Fword_search_backward_lax, Fword_search_forward_lax):
6801 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6802 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6803
0068070e
SM
68042011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6805
6806 * fileio.c (Finsert_file_contents): Move after-change-function call
6807 to before the "handled:" label, since all "goto handled" appear in
6808 cases where the *-change-functions have already been properly called
6809 (bug#10117).
6810
3360a3fc
AS
68112011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6812
6813 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6814 waiting for input. (Bug#10169)
6815
73d6c093
EZ
68162011-11-30 Eli Zaretskii <eliz@gnu.org>
6817
6818 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6819 verifies glyph row's hash code--we have just reallocated the
6820 glyphs, so their contents can be complete garbage. (Bug#10164)
6821
febe6bea
JB
68222011-11-30 Juanma Barranquero <lekktu@gmail.com>
6823
6824 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6825
801a4313
EZ
68262011-11-30 Eli Zaretskii <eliz@gnu.org>
6827
6828 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6829 attributes are tested _before_ calling verify_row_hash, to protect
6830 against GCC re-ordering of the tests. (Bug#10164)
6831
2b56b87e
JD
68322011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6833
6834 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6835
6836 * xterm.c (handle_one_xevent): Only set async_visible and friends
6837 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6838 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6839 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6840
dbf31225
PE
68412011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6842
6843 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6844 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6845 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6846 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6847 All uses changed to use GCPRO1 etc.
6848 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6849 Revert to old implementation (i.e., before 2011-03-11).
6850
1305621b
YM
68512011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6852
6853 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6854 of scroll runs so as to avoid assigning disabled bogus rows and
6855 unnecessary graphics copy operations.
6856
8c9afb46
EZ
68572011-11-27 Eli Zaretskii <eliz@gnu.org>
6858
6859 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6860 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6861 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6862 (malloc, free, realloc, calloc): Redirect to e_* only when
6863 compiling Emacs.
6864
6865 * lisp.h (GCTYPEBITS): Move before first use.
6866 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6867 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6868 this macro definition.
6869
6870 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6871 _MSC_VER.
6872
54e9e3bf
JD
68732011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6874
6d5eb5b0
SM
6875 * gtkutil.c (xg_create_frame_widgets):
6876 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6877 present with Gtk+ 2.0.
6878
83aca1cb
PE
68792011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 * fileio.c (Finsert_file_contents): Undo previous change; see
6882 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6883
5b76caa4
PE
68842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6885
6886 Rename locals to avoid shadowing.
6887 * fileio.c (Finsert_file_contents):
6888 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6889 * process.c (wait_reading_process_output):
6890 Rename inner 'proc' to 'p' to avoid shadowing.
6891 Indent for consistency with usual Emacs style.
6892
8c535114
EZ
68932011-11-25 Eli Zaretskii <eliz@gnu.org>
6894
6895 * xdisp.c (redisplay_window): If cursor row is not fully visible
6896 after recentering, and scroll-conservatively is set to a large
6897 number, scroll window by a few more lines to make the cursor fully
6898 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6899 (start_display): Don't move to the next line if the display should
6900 start at a newline that is part of a display vector or an overlay
6901 string. (Bug#10119)
8c535114 6902
fa4fdb5c
JL
69032011-11-24 Juri Linkov <juri@jurta.org>
6904
6905 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6906 after the `MagickPingImage' call. (Bug#10112)
6907
90ec88df
CY
69082011-11-23 Chong Yidong <cyd@gnu.org>
6909
6910 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6911
56e2e794
MR
69122011-11-23 Martin Rudalics <rudalics@gmx.at>
6913
6914 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6915 making another buffer current. (Bug#10114)
6916
b6e64c41
GM
69172011-11-23 Glenn Morris <rgm@gnu.org>
6918
6919 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6920
6b21de18
CY
69212011-11-23 Chong Yidong <cyd@gnu.org>
6922
6923 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6924 using it (Bug#5984).
6925
b12cd789
EZ
69262011-11-22 Eli Zaretskii <eliz@gnu.org>
6927
6928 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6929 and header-lines, as they don't have one computed for them.
6930 (Bug#10098)
6931
6932 * .gdbinit (prow): Make displayed values more self-explaining.
6933 Add row's hash code.
6934
261b6fd4
LMI
69352011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6936
6937 * process.c (wait_reading_process_output): Fix asynchrounous
6938 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6939 (wait_reading_process_output): Add comment and URL.
261b6fd4 6940
e7cfd277
JD
69412011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6942
6943 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6944
a9b9b7f5
CY
69452011-11-21 Chong Yidong <cyd@gnu.org>
6946
6947 * window.c (Fnext_window, Fprevious_window): Doc fix.
6948
b0d15b4f
SM
69492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6950
6951 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6952
fe7a3057
JB
69532011-11-20 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6956
d2999b1a
MR
69572011-11-20 Martin Rudalics <rudalics@gmx.at>
6958
6959 * window.c (Fset_window_combination_limit): Rename argument
6960 STATUS to LIMIT.
6961 (Vwindow_combination_limit): Remove "status" from doc-string.
6962
d5ff9cd0
AS
69632011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6964
6965 * m/ibms390.h: Remove.
6966 * m/ibms390x.h: Don't include "ibms390.h".
6967
a5bb9bd3
SM
69682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6969
6970 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6971 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6972
cd1181db
JB
69732011-11-20 Juanma Barranquero <lekktu@gmail.com>
6974
6975 * casetab.c (Fset_case_table):
6976 * charset.c (Fcharset_after): Fix typos.
6977
615a3b8d 69782011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6979
17e845af
PE
6980 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6981 Otherwise, valgrind does not work on some platforms.
6982 Problem reported by Andreas Schwab in
6a0bf43d
PE
6983 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6984 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6985 is set, removing the need for VIRT_ADDRESS_VARIES.
6986 (PURE_P): Use a more-efficient implementation that needs just one
6987 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6988 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6989 to 4 (xorl, subq, cmpq, setbe).
6990 * alloc.c (pure): Always extern now, since that's the
6991 VIRT_ADDR_VARIES behavior.
6992 (PURE_POINTER_P): Use a single comparison, not two, for
6993 consistency with the new puresize.h.
6994 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6995 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6996 Remove VIRT_ADDR_VARIES no longer needed.
6997
f8fe6f96
EZ
69982011-11-19 Eli Zaretskii <eliz@gnu.org>
6999
7000 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
7001 (erase_phys_cursor, update_window_cursor, show_mouse_face)
7002 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
7003 behave as if the cursor position were at the window margin.
7004
7005 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
7006 and the cursor position is out of bounds, behave as if the cursor
7007 position were at the window margin. (Bug#10075)
7008
df05a53c
CY
70092011-11-18 Chong Yidong <cyd@gnu.org>
7010
7011 * window.c (Fwindow_combination_limit): Make first argument
7012 non-optional, since it is meaningless for live windows like the
7013 selected window.
61ccba97 7014
2071918e
DA
70152011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
7016
7017 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
7018
b50a28de
SM
70192011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
7020
7021 * intervals.c: Fix grafting over the whole buffer (bug#10071).
7022 (graft_intervals_into_buffer): Simplify.
7023
015137db
EZ
70242011-11-18 Eli Zaretskii <eliz@gnu.org>
7025
7026 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
7027 hash values of the two rows.
7028 (copy_row_except_pointers): Preserve the used[] arrays and the
7029 hash values of the two rows. (Bug#10035)
68c95424 7030 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
7031
7032 * xdisp.c (row_hash): New function, body extracted from
7033 compute_line_metrics.
7034 (compute_line_metrics): Call row_hash, instead of computing the
7035 hash code inline.
7036
7037 * dispnew.c (verify_row_hash): Call row_hash for computing the
7038 hash code of a row, instead of duplicating code from xdisp.c.
7039
7040 * dispextern.h (row_hash): Add prototype.
7041
a2addb04
TH
70422011-11-18 Tassilo Horn <tassilo@member.fsf.org>
7043
7044 * frame.c (delete_frame): Don't delete the terminal when the last
7045 X frame is closed if emacs is built with GTK toolkit.
7046
df85d315
JB
70472011-11-17 Juanma Barranquero <lekktu@gmail.com>
7048
7049 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
7050
a0c2d0ae
MR
70512011-11-17 Martin Rudalics <rudalics@gmx.at>
7052
7053 * window.c (Vwindow_splits): Rename to
7054 Vwindow_combination_resize. Suggested by Juri Linkov.
7055 (Fsplit_window_internal): Use Vwindow_combination_resize instead
7056 of Vwindow_splits.
7057
58179cce
JB
70582011-11-16 Juanma Barranquero <lekktu@gmail.com>
7059
7877f373
JB
7060 * nsfns.m (Fns_font_name):
7061 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 7062
b6f67890
MR
70632011-11-16 Martin Rudalics <rudalics@gmx.at>
7064
7065 * window.h (window): Rename slot "nest" to "combination_limit".
7066 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
7067 (Fset_window_nest): Rename to Fset_window_combination_limit.
7068 (Vwindow_nest): Rename to Vwindow_combination_limit.
7069 (recombine_windows, make_parent_window, make_window)
7070 (Fsplit_window_internal, saved_window)
7071 (Fset_window_configuration, save_window_save): Rename all
7072 occurrences of window_nest to window_combination_limit.
7073
c7015153
JB
70742011-11-15 Juanma Barranquero <lekktu@gmail.com>
7075
7076 * image.c (imagemagick_load_image): Fix typo.
7077
322ad6ec
EZ
70782011-11-14 Eli Zaretskii <eliz@gnu.org>
7079
7080 * xdisp.c (display_line): Move the call to
7081 highlight_trailing_whitespace before the call to
7082 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
7083 faces of all the glyphs to compute ROW's hash value.
7084 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 7085
f067b8ec
JB
70862011-11-14 Juanma Barranquero <lekktu@gmail.com>
7087
7088 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
7089 just return (bug#10044).
7090
1e5b2111
EZ
70912011-11-12 Eli Zaretskii <eliz@gnu.org>
7092
7ef3cbd5
EZ
7093 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
7094 with user-defined heap size. Bump the default size of the temacs
7095 heap to 27MB, to avoid memory warning when running temacs.
7096 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
7097
1e5b2111
EZ
7098 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
7099 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
7100 (verify_row_hash) [XASSERTS]: New function.
7101 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
7102 that the hash value of glyph rows is correct.
1e5b2111 7103
89d61221
MR
71042011-11-12 Martin Rudalics <rudalics@gmx.at>
7105
7106 * window.h (window): Remove splits slot.
7107 * window.c (Fwindow_splits, Fset_window_splits): Remove.
7108 (Fdelete_other_windows_internal, make_parent_window)
7109 (make_window, Fsplit_window_internal, Fdelete_window_internal)
7110 (Fset_window_configuration, save_window_save): Don't deal with
7111 split status of windows.
7112 (saved_window): Remove splits slot.
7113 (Vwindow_splits): Rewrite doc-string.
7114
97f18cc8
JD
71152011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7116
7117 * xfns.c (unwind_create_frame):
7118 * nsfns.m (unwind_create_frame):
7119 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7120 Vframe_list (Bug#9999).
7121
22a648b4
DA
71222011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7123
0b381c7e 7124 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7125
659afede
KH
71262011-11-11 Kenichi Handa <handa@m17n.org>
7127
7128 * callproc.c (Fcall_process): Set the member dst_multibyte of
7129 process_coding.
7130
9ac0394b
KH
71312011-11-11 Johan Bockgård <bojohan@gnu.org>
7132
7133 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7134 avoid a crash (bug#9496).
7135
2fbdc249
CY
71362011-11-09 Chong Yidong <cyd@gnu.org>
7137
7138 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7139 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7140
ac6b1f81
PE
71412011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7142
7143 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7144
09db192c
PE
71452011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7146
7147 Avoid some portability problems by eschewing 'extern inline' functions.
7148 The trivial performance wins aren't worth the portability hassles; see
7149 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7150 et seq.
7151 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7152 (window_box_width, window_box_left, window_box_left_offset)
7153 (window_box_right, window_box_right_offset): Undo previous change,
7154 by removing the "extern"s.
7155 * intervals.c (adjust_intervals_for_insertion)
7156 (adjust_intervals_for_deletion): Undo previous change,
7157 making these static again.
7158 (offset_intervals, temp_set_point_both, temp_set_point)
7159 (copy_intervals_to_string): No longer inline.
7160 * xdisp.c (window_text_bottom_y, window_box_width)
7161 (window_box_height, window_box_left_offset)
7162 (window_box_right_offset, window_box_left, window_box_right)
7163 (window_box): No longer inline.
7164
105216ed
CY
71652011-11-08 Chong Yidong <cyd@gnu.org>
7166
7167 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7168 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7169 Signal an error if not a live window.
105216ed
CY
7170 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7171 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7172
ae9e237f
JB
71732011-11-07 Juanma Barranquero <lekktu@gmail.com>
7174
7175 * lisp.h (syms_of_abbrev): Remove declaration.
7176 Reported by CHENG Gao <chenggao@royau.me>.
7177
c7aa8333
EZ
71782011-11-07 Eli Zaretskii <eliz@gnu.org>
7179
7180 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7181 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7182 of temacs in GUI mode.
7183
be7f5545
MR
71842011-11-07 Martin Rudalics <rudalics@gmx.at>
7185
7186 * window.h: Declare delete_all_child_windows instead of
7187 delete_all_subwindows.
7188 * window.c (Fwindow_nest, Fset_window_nest)
7189 (Fset_window_new_total, Fset_window_new_normal)
7190 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7191 (delete_all_subwindows): Rename to delete_all_child_windows.
7192 (Fdelete_other_windows_internal, Fset_window_configuration):
7193 Call delete_all_child_windows instead of delete_all_subwindows.
7194 * frame.c (delete_frame): Call delete_all_child_windows instead
7195 of delete_all_subwindows.
7196
ca78dc43
PE
71972011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7198
7199 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7200 This is also needed for porting to any host where GC_MARK_STACK is
7201 not GC_MAKE_GCPROS_NOOPS.
7202 (which_symbols): Use it.
7203
a0241d01
KH
72042011-11-07 Kenichi Handa <handa@m17n.org>
7205
7206 * coding.c (coding_set_destination): Check coding->src_pos only
7207 when coding->src_object is a buffer (bug#9910).
7208
7209 * process.c (send_process): Set the member src_multibyte of coding
7210 to 0 (bug#9911) when sending a unibyte text.
7211
7212 * callproc.c (Fcall_process): Set the member src_multibyte of
7213 process_coding to 0 (bug#9912).
7214
a64bfdfa 72152011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7216
7217 * xmenu.c (cleanup_widget_value_tree): New function.
7218 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7219 calling free_menubar_widget_value_tree directly (Bug#9830).
7220
cb41b32a
PE
72212011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7222
7223 Fix some portability problems with 'inline'.
7224 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7225 (window_box_width, window_box_left, window_box_left_offset)
7226 (window_box_right, window_box_right_offset): Declare extern.
7227 Otherwise, these inline functions do not conform to C99 and
7228 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7229 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7230 * intervals.c (adjust_intervals_for_insertion)
7231 (adjust_intervals_for_deletion): Now extern, because otherwise the
7232 extern inline functions 'offset_intervals' couldn't refer to it.
7233 (static_offset_intervals): Remove.
7234 (offset_intervals): Rewrite using the old contents of
7235 static_offset_intervals. The old version didn't conform to C99
7236 because an extern inline function contained a reference to an
7237 identifier with static linkage.
7238
b7041366
AS
72392011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7240
7241 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7242 GC.
7243
88a37c4d
EZ
72442011-11-06 Eli Zaretskii <eliz@gnu.org>
7245
7246 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7247 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7248 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7249 return Qleft_to_right.
7250
49745b39
CY
72512011-11-06 Chong Yidong <cyd@gnu.org>
7252
7253 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7254 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7255 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7256 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7257 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7258 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7259 (Fwindow_vscroll): Doc fix.
7260 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7261 argument, since it makes no sense to pass a live window and for
7262 consistency with window-child.
7263
1f05cd82
CS
72642011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7265
7266 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7267 support MSVC.
7268
22610910
JR
72692011-11-05 Jason Rumney <jasonr@gnu.org>
7270
7271 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7272 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7273 fonts (Bug#6029).
7274 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7275 bitwise arithmetic preventing use of unicode-sip and non-truetype
7276 opentype fonts.
7277
a06776b2
EZ
72782011-11-05 Eli Zaretskii <eliz@gnu.org>
7279
3ad924ba
EZ
7280 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7281 "emacs"-only part.
7282
a06776b2
EZ
7283 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7284 initialization code to keep similarity to xfns.c after changes
7285 from 2011-11-05.
7286
c9e7db78
JD
72872011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7288
a97f8f3f
JD
7289 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7290 (unwind_create_frame): New function (Bug#9943).
7291 (Fx_create_frame): Restructure code to be more similar to the one in
7292 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7293 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7294 Move terminal->reference_count++ just before making the frame official
7295 (Bug#9943).
7296
7297 * nsterm.m (x_free_frame_resources): New function.
7298 (x_destroy_window): Move code to x_free_frame_resources.
7299
c9e7db78 7300 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7301 (Fx_create_frame, x_create_tip_frame):
7302 Move terminal->reference_count++ just before making the frame
75f1671a 7303 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7304 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7305
a6fc3b5c
EZ
73062011-11-05 Eli Zaretskii <eliz@gnu.org>
7307
7308 Support MSVC build with newer versions of Visual Studio.
7309 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7310 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7311 nt/gmake.defs.
7312
7313 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7314 which are not supported by MSVC.
7315 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7316 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7317 bitfields.
7318 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7319 types in bitfields.
7320 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7321
7322 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7323
58179cce 73242011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7325
7326 Support MSVC build with newer versions of Visual Studio.
7327 * w32.c: Don't include w32api.h for MSVC.
7328 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7329
7330 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7331 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7332 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7333 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7334 e_* cousins.
7335 (alloca) [_MSC_VER]: Define to _alloca.
7336
7337 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7338
7339 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7340
a58c13ed
EZ
73412011-11-04 Eli Zaretskii <eliz@gnu.org>
7342
7343 * xdisp.c (note_mouse_highlight): If either of
7344 previous/next-single-property-change returns nil, treat that as
7345 the beginning or the end of the buffer. (Bug#9955)
7346
fe0b6370
JD
73472011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7348
a58c13ed 7349 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7350 label is not null (Bug#9951).
7351 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7352 may be NULL.
7353
89bd5ee1
EZ
73542011-11-04 Eli Zaretskii <eliz@gnu.org>
7355
7356 * window.c (Fwindow_body_size): Mention in the doc string that the
7357 return value is in frame's canonical units. (Bug#9949)
7358
84c3edb9
EZ
73592011-11-03 Eli Zaretskii <eliz@gnu.org>
7360
4e2fb5c7
EZ
7361 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7362
84c3edb9 7363 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7364 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7365 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7366
bc17a887
EZ
73672011-11-01 Eli Zaretskii <eliz@gnu.org>
7368
7369 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7370 Don't stop backward scan on the continuation glyph, even though
7371 its CHARPOS is positive.
6d5eb5b0
SM
7372 (mouse_face_from_buffer_pos, note_mouse_highlight):
7373 Rename cover_string to disp_string.
bc17a887 7374
4ee88440
MR
73752011-11-01 Martin Rudalics <rudalics@gmx.at>
7376
7377 * window.c (temp_output_buffer_show): Don't use
7378 Vtemp_buffer_show_specifiers.
7379 (Vtemp_buffer_show_specifiers): Remove unused variable.
7380
c2ff3c02
EZ
73812011-10-30 Eli Zaretskii <eliz@gnu.org>
7382
7383 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7384 past the beginning of the current glyph matrix.
7385
58179cce 73862011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7387
7388 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7389 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7390 HAVE_GTK3 (Bug#9869).
b77a6a7f 7391
3b574623
JD
7392 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7393 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7394
b77a6a7f
JD
7395 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7396
7397 * xterm.c: Declare x_handle_net_wm_state to return int.
7398 (handle_one_xevent): Check if we are iconified but don't have
7399 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7400 (get_current_wm_state): Return non-zero if not hidden,
7401 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7402 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7403 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7404 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7405
196e41e4
PE
74062011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7407
7408 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7409 so that this new function doesn't get optimized away by a
7410 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7411
021f2e1a
AS
74122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7413
7414 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7415
8b058d44
EZ
74162011-10-29 Eli Zaretskii <eliz@gnu.org>
7417
7418 Fix the `xbytecode' command.
7419 * .gdbinit (xprintbytestr): New command.
b50a28de 7420 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7421 (xbytecode): Print the byte-code string as well.
7422
4452fb80
EZ
74232011-10-29 Kim Storm <storm@cua.dk>
7424
8b058d44
EZ
7425 * alloc.c (which_symbols): New function.
7426
21b72067
AS
74272011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7428
7429 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7430 line. (Bug#9903)
7431
83ed7b5c
GM
74322011-10-29 Glenn Morris <rgm@gnu.org>
7433
7434 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7435 Not clear what it was for, and it causes various bugs. (Bug#9839)
7436
5a7a728b
EZ
74372011-10-28 Eli Zaretskii <eliz@gnu.org>
7438
7439 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7440 possible random value that matches one of those tested as
7441 condition to clear the mouse face.
7442
d3d0842f
CY
74432011-10-28 Chong Yidong <cyd@gnu.org>
7444
7445 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7446
31b39d13
DN
74472011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7448
7449 * window.c (make_window): Initialize phys_cursor_on_p.
7450
9aba6043
SM
74512011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7452
7453 * lisp.h (struct Lisp_Symbol): Update comments.
7454
c20992f4
JB
74552011-10-28 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7458
db4f02f2
EZ
74592011-10-28 Eli Zaretskii <eliz@gnu.org>
7460
7461 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7462 <oslsachem@gmail.com> for helping to debug this.
7463
7464 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7465 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7466 (g_b_init_get_glyph_outline_w): New static variables.
7467 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7468 (GetGlyphOutlineW_Proc): New typedefs.
7469 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7470 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7471 New functions.
7472 (w32font_open_internal, compute_metrics):
7473 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7474 instead of calling the "wide" APIs directly.
7475
7476 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7477
7478 * w32.h (syms_of_w32font): Add prototype.
7479
87e68db4
JB
74802011-10-27 Juanma Barranquero <lekktu@gmail.com>
7481
7482 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7483 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7484 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7485 (Fmove_to_window_line): Doc fix.
7486
435c1d67
CY
74872011-10-27 Chong Yidong <cyd@gnu.org>
7488
7489 * process.c (make_process): Set gnutls_state to NULL.
7490
7491 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7492 non-NULL, regardless of GNUTLS_INITSTAGE.
7493 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7494 an error. Set process slots as soon as we allocate them.
7495
7496 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7497
9c6c6f49
CY
74982011-10-27 Chong Yidong <cyd@gnu.org>
7499
9aba6043
SM
7500 * gnutls.c (emacs_gnutls_deinit): New function.
7501 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7502 (Fgnutls_deinit, Fgnutls_boot): Use it.
7503
7504 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7505 (deactivate_process): Call emacs_gnutls_deinit.
7506
657d08d3
JB
75072011-10-27 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * image.c (x_create_x_image_and_pixmap):
7510 * w32.c (sys_rename, w32_delayed_load):
7511 * w32font.c (fill_in_logfont):
7512 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7513
5430d399
JB
75142011-10-26 Juanma Barranquero <lekktu@gmail.com>
7515
7516 * w32fns.c (w32_default_color_map): New function,
7517 extracted from Fw32_default_color_map.
a7ef684b 7518 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7519
fe0055fa
PE
75202011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7521
7522 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7523
e6346438
SM
75242011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7525
7526 * keyboard.c (test_undefined): New function (bug#9751).
7527 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7528
e112cc37
ET
75292011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7530
7531 * sysdep.c (init_sys_modes): Fix the check for the controlling
7532 terminal (Bug#6649).
7533
7b5d6677
EZ
75342011-10-20 Eli Zaretskii <eliz@gnu.org>
7535
7536 * dispextern.h (struct bidi_it): New member next_en_type.
7537
7538 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7539 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7540 current character, check also for next_en_type being WEAK_EN.
7541 (bidi_resolve_weak): Don't enter the expensive loop if the current
7542 position is before next_en_pos. Record the bidi type of the first
7543 non-ET, non-BN character we find, in addition to its position.
7544 (bidi_level_of_next_char): Invalidate next_en_type when
7545 next_en_pos is over-stepped.
7546
7da0b018
PE
75472011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7550 * editfns.c: Rewrite current-time-zone so that it invokes
7551 the equivalent of (format-time-string "%Z") to get the time zone name.
7552 This fixes a bug when the time zone name contains characters that
7553 need converting from the system time locale to Emacs internal format.
7554 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7555 that patch fixed format-time-string to do the conversion, but
7556 I forgot to fix current-time-zone.
7557 (format_time_string): New function, containing most of
7558 what Fformat_time_string used to contain.
7559 (Fformat_time_string): Rewrite in terms of format_time_string.
7560 This doesn't change this function's behavior.
7561 (current-time-zone): Rewrite to use format_time_string.
7562 This fixes the bug reported by Michael Schierl in
7563 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7564 Jason Rumney's 2007-06-07 change worked around this bug, but
7565 didn't fix it.
7566 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7567
8547b010
EZ
75682011-10-19 Eli Zaretskii <eliz@gnu.org>
7569
7570 * xdisp.c (start_display): If the character at POS is displayed
7571 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7572 (try_window_reusing_current_matrix): If a line ends in a display
7573 vector or the next line starts in a display vector, continue
7574 redrawing the window even though the character position of
7575 start_row was reached.
8547b010
EZ
7576 (Bug#9771, part 2)
7577
4e948d15
CY
75782011-10-18 Chong Yidong <cyd@gnu.org>
7579
7580 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7581 with nobreak-char-display too.
7582
4787455f
EZ
75832011-10-18 Eli Zaretskii <eliz@gnu.org>
7584
7585 Fix part 3 of bug#9771.
7586 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7587 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7588 non-neutral characters if the current character is a paragraph
7589 separator (a.k.a. Newline). This avoids running the same
7590 expensive loop twice, once when we consume the preceding newline
7591 and the other time when the line actually needs to be displayed.
7592 Avoid the loop when we see neutrals on the base embedding level
7593 following a character whose directionality is the same as the
7594 paragraph's. This avoids running the expensive loop when a line
7595 ends in a long sequence of neutrals, like control characters.
7596 Add assertion against STRONG_AL type. Slightly rearrange code
7597 that determines the type of a neutral given the first non-neutral
7598 that follows it.
7599 (bidi_level_of_next_char): Set next_en_pos to zero when
7600 invalidating its info.
7601
2c91f553
EZ
76022011-10-17 Eli Zaretskii <eliz@gnu.org>
7603
7604 * xdisp.c (push_display_prop): Determine whether to record string
7605 or buffer position by IT->string, not by IT->method. Allow
7606 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7607 (move_it_vertically_backward): Don't look for character position
7608 immediately after the newline when in a continuation line.
7609 (Bug#9771, part 1)
2c91f553 7610
c7b08b0d
MR
76112011-10-15 Martin Rudalics <rudalics@gmx.at>
7612
7613 * window.c (coordinates_in_window): Rewrite and delabelize
7614 vertical border check. (Bug#5357) (Bug#9618)
7615
6b02f655
SM
76162011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7617
7618 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7619 errors in XSetWindowBorder (bug#9310).
7620
81d40c92
DA
76212011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7622
7623 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7624 avoid crash when xmalloc overrun checking is enabled.
7625
d4172c3b
EZ
76262011-10-13 Eli Zaretskii <eliz@gnu.org>
7627
7628 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7629 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7630 cursor motion with <left> and <right> arrow keys.
7631
7632 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7633 some callers set that themselves.
7634
b00eea75
EZ
76352011-10-12 Eli Zaretskii <eliz@gnu.org>
7636
7637 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7638 display string and the previous row comes from the same string and
7639 is empty. (Bug#9739) (Bug#9738)
7640
8fe012c4
SM
76412011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7642
7643 * doc.c (get_doc_string): Encode file name (bug#9735).
7644
0074aef2
EZ
76452011-10-12 Eli Zaretskii <eliz@gnu.org>
7646
79beb178
EZ
7647 * bidi.c (bidi_level_of_next_char):
7648 * xdisp.c (get_visually_first_element): Remove old incorrect
7649 comments regarding the Unicode Line Separator character.
7650
0074aef2
EZ
7651 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7652
6e4b3fbe
DA
76532011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7654
7655 * alloc.c (Fgc_status): Do not access beyond zombies array
7656 boundary if nzombies > MAX_ZOMBIES.
7657 * alloc.c (dump_zombies): Add missing format specifier.
7658
0324f3af
PE
76592011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7660
b5525cac
PE
7661 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7662 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7663
0324f3af
PE
7664 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7665 Some packages use them to denote characters with modifiers.
7666
e9b5f888
AS
76672011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7668
7669 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7670 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7671 matching a pp-number. Rename parameter var to var1.
7672
127827c0
SM
76732011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7674
7675 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7676
c8fd3bd0
GM
76772011-10-08 Glenn Morris <rgm@gnu.org>
7678
7679 * callint.c (Fcall_interactively): Give a more explicit error for the
7680 'c' case with a non-character input. (Bug#8479)
7681
352ec8ff
EZ
76822011-10-08 Eli Zaretskii <eliz@gnu.org>
7683
03669ccb
EZ
7684 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7685 lines.
7061c986
EZ
7686 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7687 lines that are hscrolled on the left.
03669ccb 7688
352ec8ff
EZ
7689 * dispnew.c (buffer_posn_from_coords): Account for a possible
7690 presence of header-line. (Bug#4426)
7691
a66cfb1c
SM
76922011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7693
6b02f655
SM
7694 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7695 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7696
7c5ee88e
PE
76972011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7698
7699 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7700 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7701 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7702 this makes Emacs dump core during garbage collection on rare
7703 occasions. sizeof is obviously inferior to offsetof here, so
7704 stick with offsetof.
7705 (GC_POINTER_ALIGNMENT): New macro.
7706 (mark_memory): Omit 3rd (offset) arg; caller changed.
7707 Don't assume EMACS_INT alignment is the same as pointer alignment.
7708
df1bbe5b
SM
77092011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7710
7711 * keyboard.c (read_key_sequence_remapped): New var.
7712 (read_key_sequence): Compute remapping in the right buffer.
7713 (command_loop_1): Use read_key_sequence's remapping directly.
7714
51553db6
SM
77152011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7716
32c1fffd
SM
7717 * dired.c (file_name_completion): Don't expand file name.
7718 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7719 before checking file name handler.
7720
51553db6
SM
7721 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7722 they've been requested explicitly (bug#9591).
7723
b6bd1599 77242011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7725
7726 * keymap.c (Fsingle_key_description): Use make_specified_string
7727 instead of build_string to build string from push_key_description.
7728 (Bug#5193)
7729
f701dc2a
PE
77302011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7731
4222c55d
PE
7732 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7733 This fixes a Y2038 bug on 64-bit hosts.
7734 * buffer.c (reset_buffer):
7735 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7736 (Fclear_buffer_auto_save_failure):
7737 Use 0, not -1, to represent an unset failure time, since time_t
7738 might not be signed.
7739
f701dc2a
PE
7740 Remove dependency on glibc malloc internals.
7741 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7742 Move back here from lisp.h, but with their new implementations.
7743 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7744 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7745 * charset.c (charset_table_init): New static var.
7746 (syms_of_charset): Use it instead of xmalloc. This removes a
7747 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7748 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7749 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7750 Move back to alloc.c.
7751 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7752 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7753
9ceebf39
JD
77542011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7755
7756 * nsterm.m (windowDidResize): Call x_set_window_size only when
7757 ns_in_resize is true. Otherwise set pixelwidth/height and
7758 call change_frame_size (Bug#9628).
7759
cb993c58
PE
77602011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7761
3930c88b
PE
7762 Port --enable-checking=all to Fedora 14 x86-64.
7763 * charset.c (syms_of_charset): Also account for glibc malloc's
7764 internal overhead when calculating the initial malloc maximum.
7765
cb993c58
PE
7766 Port --enable-checking=all to Fedora 14 x86.
7767 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7768 Move to lisp.h.
7769 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7770 (overrun_check_realloc, overrun_check_free):
7771 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7772 That way, xmalloc returns a properly-aligned pointer even if
7773 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7774 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7775 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7776 into account when calculating the initial malloc maximum.
7777 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7778 Move here from alloc.c, so that charset.c can use it too.
7779 Properly align; the old code wasn't right for common 32-bit hosts
7780 when configured with --enable-checking=all.
7781 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7782 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7783
31bed486
EZ
77842011-09-29 Eli Zaretskii <eliz@gnu.org>
7785
04c70788 7786 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7787 use EDOM.
7788
fbcaa2f3
EZ
77892011-09-28 Eli Zaretskii <eliz@gnu.org>
7790
7791 * xdisp.c (compute_display_string_end): If there's no display
7792 string at CHARPOS, return -1.
7793
7794 * bidi.c (bidi_fetch_char): When compute_display_string_end
7795 returns a negative value, treat the character as a normal
7796 character not covered by a display string. (Bug#9624)
7797
a239d4e9
JB
77982011-09-28 Juanma Barranquero <lekktu@gmail.com>
7799
7800 * lread.c (Fread_from_string): Fix typo in docstring.
7801
88652fd5
EZ
78022011-09-27 Eli Zaretskii <eliz@gnu.org>
7803
7804 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7805 newline, reseat the iterator instead of bidi-iterating there one
7806 character at a time. (Bug#9610)
32c1fffd
SM
7807 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7808 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7809
ed497dd4
AS
78102011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7811
7812 * lread.c (readevalloop): Use correct code for NBSP.
7813 (read1): Likewise. (Bug#9608)
7814
b2bf61aa
MA
78152011-09-25 Michael Albinus <michael.albinus@gmx.de>
7816
7817 * dbusbind.c (Fdbus_register_signal): When service is not
7818 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7819
32bbb17c
GM
78202011-09-25 Glenn Morris <rgm@gnu.org>
7821
7822 * buffer.c (truncate-lines): Doc fix.
7823
94e0933e
CY
78242011-09-24 Chong Yidong <cyd@stupidchicken.com>
7825
7826 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7827 (Fset_window_next_buffers): Doc fix.
7828
cddde921
GM
78292011-09-24 Glenn Morris <rgm@gnu.org>
7830
7831 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7832
1260aef1
PE
78332011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7834
25b4bfa0
PE
7835 Fix minor problems found by static checking.
7836 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7837 * indent.c (Fvertical_motion): Fix == vs = typo.
7838
e3cbd34b
EZ
78392011-09-24 Eli Zaretskii <eliz@gnu.org>
7840
a66cfb1c
SM
7841 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7842 Default value is now t. Doc fix.
6bf7006f 7843
e3cbd34b 7844 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7845 logic when moving up, not only when moving down. Fix the
e3cbd34b 7846 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7847 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7848
7849 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7850 CHARPOS is covered by a display string which includes newlines.
7851 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7852 is covered by a display string with embedded newlines.
7853
a3de0cbd
MA
78542011-09-24 Michael Albinus <michael.albinus@gmx.de>
7855
7856 * dbusbind.c (Fdbus_register_signal): Add match rule to
7857 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7858 (Fdbus_register_method, Vdbus_registered_objects_table):
7859 Fix docstring.
a3de0cbd 7860
b260039d
JM
78612011-09-24 Jim Meyering <meyering@redhat.com>
7862
32c1fffd 7863 do not ignore write error for any output size
b260039d
JM
7864 The previous change was incomplete.
7865 While it makes emacs --batch detect the vast majority of stdout
7866 write failures, errors were still ignored whenever the output size is
7867 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7868 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7869 && echo FAIL: ignored write error
7870 FAIL: ignored write error
7871 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7872 && echo FAIL: ignored write error
7873 FAIL: ignored write error
7874 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7875
8eca8a7c
AS
78762011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7877
7878 * emacs.c (Fkill_emacs): In noninteractive mode exit
7879 non-successfully if a write error occurred on stdout. (Bug#9574)
7880
3341db62
EZ
78812011-09-21 Eli Zaretskii <eliz@gnu.org>
7882
7883 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7884 the xassert test.
7885
7886 * dispextern.h (struct it): Update the comment documenting what
7887 can it->OBJECT be.
7888
8c203dbf
EZ
78892011-09-20 Eli Zaretskii <eliz@gnu.org>
7890
7891 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7892 a display string, extend search for cursor position to end of row.
7893 (find_row_edges): If the row ends in a newline from a display
7894 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7895 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7896 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7897 non-empty line. Fixes confusing cursor motion with arrow keys at
7898 the beginning of a line that starts with whitespace.
8c203dbf 7899
a4824228
LMI
79002011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7901
7902 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7903 (bug#9493).
7904
33ed493b
CY
79052011-09-18 Chong Yidong <cyd@stupidchicken.com>
7906
7907 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7908 boolean (Bug#9154).
7909
56cd55c8
EZ
79102011-09-18 Eli Zaretskii <eliz@gnu.org>
7911
7912 * xdisp.c (display_line): Record maximum and minimum buffer
7913 positions even if no glyphs were produced (e.g., by a zero-width
7914 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7915 buffer positions that will be removed from the glyph row because
7916 they don't fit.
c02dcedf
EZ
7917 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7918 column is beyond frame width: don't subtract 1 "pixel" when
7919 computing width of the stretch.
3e62b7e0
EZ
7920 (reseat_at_next_visible_line_start): Undo the change made on
7921 2011-09-17 that saved paragraph information and restored it after
7922 the call to `reseat'. (Bug#9545)
56cd55c8 7923
5ed99d36 79242011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7925
7926 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7927 and turn window cursor on if cleared (Bug#9415).
7928
5ed99d36 79292011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7930
7931 * search.c (boyer_moore): Take unibyte characters from pattern
7932 literally. (Bug#9458)
7933
9bade7b2
EZ
79342011-09-18 Eli Zaretskii <eliz@gnu.org>
7935
7936 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7937
e5e9d610
PE
79382011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7939
87e4427a
PE
7940 Fix minor problem found by static checking.
7941 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7942 initialized, to pacify gcc -Wuninitialized.
7943
e5e9d610
PE
7944 * fileio.c: Report proper errno when syscall falls.
7945 (Finsert_file_contents): Save and restore errno,
7946 so that report_file_error outputs the correct diagnostic.
7947 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7948
a1674f0b
EZ
79492011-09-18 Eli Zaretskii <eliz@gnu.org>
7950
7951 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7952
fbfb6dd4
EZ
79532011-09-17 Eli Zaretskii <eliz@gnu.org>
7954
7955 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7956 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7957
bb187662
EZ
79582011-09-17 Eli Zaretskii <eliz@gnu.org>
7959
1137e8b8 7960 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7961 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7962
7963 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7964 (bidi_find_paragraph_start): Search back for paragraph beginning
7965 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7966 (bidi_move_to_visually_next): Only trigger paragraph-related
7967 computations when the last character is a newline or at EOB, not
7968 just any NEUTRAL_B. (Bug#9470)
7969
bb187662
EZ
7970 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7971 truncated lines if point is covered by a display string. (Bug#9524)
7972
2e621251
PE
79732011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7974
7975 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7976 (cons_to_x_long): New function.
7977 (lisp_data_to_selection_data): Use it. Correct the test for
7978 short-versus-long data; it was negated. Break out of vector
7979 loop, for efficiency, when a long datum is discovered.
7980
91a15bc6
SM
79812011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7982
7983 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7984
b41c3a35
EZ
79852011-09-16 Eli Zaretskii <eliz@gnu.org>
7986
7987 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7988 GCC PR/17406) by declaring this function with external scope.
7989
7812ba2d
PE
79902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7991
7992 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7993 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7994
cf7edc2a
AS
79952011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7996
7997 * editfns.c (Fformat): Correctly handle text properties on "%%".
7998
bd01620e
EZ
79992011-09-15 Eli Zaretskii <eliz@gnu.org>
8000
8001 * xterm.c (x_draw_composite_glyph_string_foreground):
8002 * w32term.c (x_draw_composite_glyph_string_foreground):
8003 * term.c (encode_terminal_code):
8004 * composite.c (composition_update_it, get_composition_id):
8005 * xdisp.c (get_next_display_element)
8006 (fill_composite_glyph_string): Add comments about special meaning
8007 of TAB characters in a composition.
8008
a02719a3
PE
80092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
8010
8011 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
8012 This occurs when processing a multibyte format.
8013 Problem reported by Wolfgang Jenker.
a02719a3 8014
72589a3c
JB
80152011-09-15 Johan Bockgård <bojohan@gnu.org>
8016
8017 * xdisp.c (try_cursor_movement): Only check for exact match if
8018 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
8019
1c14176c
PE
80202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8021
8022 Remove unused external symbols.
8023 * dispextern.h (calc_pixel_width_or_height): Remove decl.
8024 * xdisp.c (calc_pixel_width_or_height): Now static.
8025 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
8026 * indent.c (check_display_width):
8027 * w32term.c: Fix comment to match code.
8028 * xterm.c, xterm.h (x_catching_errors): Remove.
8029
d2eea5b5
PE
80302011-09-14 Paul Eggert <eggert@cs.ucla.edu>
8031
8032 * xselect.c: Use signed conversions more consistently (Bug#9498).
8033 (selection_data_to_lisp_data): Assume incoming selection data are
8034 signed integers, not unsigned. This is to be consistent with
8035 outgoing selection data, which was modified to use signed integers
8036 in as part of the fix to Bug#9196 in response to Jan D.'s comment
8037 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
8038 expects long, not unsigned long.
8039
46888499
EZ
80402011-09-14 Eli Zaretskii <eliz@gnu.org>
8041
8042 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
8043 computation of loop end. Reported by Johan Bockgård
8044 <bojohan@gnu.org>.
8045
ef8ef9fb
CY
80462011-09-13 Chong Yidong <cyd@stupidchicken.com>
8047
8048 * frame.c (Fother_visible_frames_p): Function deleted.
8049
fa819fed
EZ
80502011-09-12 Eli Zaretskii <eliz@gnu.org>
8051
8052 * indent.c (compute_motion): Process display vector front to back
8053 rather than the other way around. (Bug#2496)
8054
2ba8e008
SM
80552011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
8056
8057 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
8058
20f53c69
CY
80592011-09-11 Chong Yidong <cyd@stupidchicken.com>
8060
8061 * minibuf.c (Fread_from_minibuffer): Doc fix.
8062
d562d7a4
EZ
80632011-09-11 Eli Zaretskii <eliz@gnu.org>
8064
8065 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
8066 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
8067
1c4d7f3d
LMI
80682011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8069
8070 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
8071 value for non-existent files.
8072
b885bf36
EZ
80732011-09-11 Eli Zaretskii <eliz@gnu.org>
8074
8075 * fileio.c (Finsert_file_contents): If the file cannot be opened,
8076 set its "size" to -1. This will set the modtime_size field of
8077 the corresponding buffer to -1, which is what
8078 verify-visited-file-modtime expects for files that do not exist.
8079 (Bug#9139)
8080
6612f0bf
PE
80812011-09-11 Paul Eggert <eggert@cs.ucla.edu>
8082
8083 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
8084 here ...
8085 * lisp.h: ... from here. push_key_description is no longer
8086 defined in keyboard.c, so its declaration should not be in
8087 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
8088 logically belongs with push_key_description.
8089
dfb3f755
PE
80902011-09-10 Paul Eggert <eggert@cs.ucla.edu>
8091
8092 * buffer.h: Include <sys/types.h> instead of <time.h>.
8093 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
8094 Problem reported by Herbert J. Skuhra.
8095
3134906c
LMI
80962011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
8097
8098 * xml.c (parse_region): Make the parsing work for
8099 non-comment-starting XML files again (bug#9144).
8100
8d903f4e
AS
81012011-09-10 Andreas Schwab <schwab@linux-m68k.org>
8102
8103 * image.c (gif_load): Fix calculation of bottom and right corner.
8104 (Bug#9468)
8105
80ad64f4
EZ
81062011-09-10 Eli Zaretskii <eliz@gnu.org>
8107
8108 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
8109 redisplay in small windows.
8110
208a048d
EZ
81112011-09-09 Eli Zaretskii <eliz@gnu.org>
8112
8113 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
8114
9b1c252e
MR
81152011-09-08 Martin Rudalics <rudalics@gmx.at>
8116
8117 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8118 Operate on live windows only.
8119
2949f33b
JB
81202011-09-08 Juanma Barranquero <lekktu@gmail.com>
8121
8122 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8123
e08dcafd
EZ
81242011-09-07 Eli Zaretskii <eliz@gnu.org>
8125
8126 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8127 only under bidi iteration.
8128
115b96bd
JD
81292011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8130
8131 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8132
c8199d0f
PE
81332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8134
8135 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8136 Without this fix, the command to link temacs failed due to an
8137 undefined symbol __builtin_isnan. This is because
8138 /usr/include/iso/math_c99.h #defines isnan(x) to
8139 __builtin_isnan(x), but the bundled gcc, which identifies itself
8140 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8141 a __builtin_isnan.
8142 * floatfns.c (isnan): #undef, and then #define to a clone of
8143 what's in data.c.
8144 (Fisnan): Always define, since it's always available now.
8145 (syms_of_floatfns): Always define isnan at the Lisp level.
8146
e39b275c 81472011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8148
8149 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8150
b2db44d9 81512011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8152
f4af5137 8153 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8154 The previous code assumed that file offsets (off_t values) fit in
8155 EMACS_INT variables, which is not true on typical 32-bit hosts.
8156 The code messed up by falsely reporting buffer overflow in cases
8157 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8158 when "big" contains more than 2**29 bytes, even though this
8159 inserts just one byte and does not overflow the buffer.
8160 (Finsert_file_contents): Store file offsets as off_t
8161 values, not as EMACS_INT values. Check for overflow when
8162 converting between EMACS_INT and off_t. When checking for
8163 buffer overflow or for overlap, take the offsets into account.
8164 Don't use EMACS_INT for small values where int suffices.
8165 When checking for overlap, fix a typo: ZV was used where
8166 ZV_BYTE was intended.
8167 (Fwrite_region): Don't assume off_t fits into 'long'.
8168 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8169
ecfc0a49
MA
81702011-09-05 Michael Albinus <michael.albinus@gmx.de>
8171
8172 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8173
6511acf2 81742011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8175
0999621a 8176 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8177
8178 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8179 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8180 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8181 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8182 (modify_event_symbol): Do not assume that the length of
8183 name_alist_or_stem is safe to alloca and fits in int.
8184 (Fexecute_extended_command): Likewise for function name and binding.
8185 (Frecursion_depth): Wrap around reliably on integer overflow.
8186 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8187 since some callers pass EMACS_INT values.
8188 (Fsingle_key_description): Don't crash if symbol name contains more
8189 than MAX_ALLOCA bytes.
8190 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8191 (get_minibuffer): Arg is now EMACS_INT, not int.
8192 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8193 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8194 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8195
2be7d702
PE
8196 * dbusbind.c (signature_cat): New function.
8197 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8198 Do not overrun buffer; instead, report string overflow.
8199
9d1df220
PE
8200 * dispnew.c (add_window_display_history): Don't overrun buffer.
8201 Truncate instead; this is OK since it's just a log.
8202
33ef5c64
PE
8203 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8204 even if the time zone offset is outlandishly large.
8205 Don't mishandle offset == INT_MIN.
8206
66c6fdd5
PE
8207 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8208 when creating daemon; the previous buffer-overflow check was incorrect.
8209
d749b01b
PE
8210 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8211 which has the guts of the old verror function.
8212
b5cd1905
PE
8213 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8214 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8215
6e1a67fb
PE
8216 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8217 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8218 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8219 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8220 length of string rather than counting it via multiple sprintfs;
8221 that's simpler and more reliable.
c21721cc
PE
8222 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8223 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8224 sprintf, in case result does not fit in int.
8225
c57b67fc
PE
8226 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8227 (fontset_from_font): Print it.
8228
8a401434
PE
8229 * frame.c (tty_frame_count): Now printmax_t, not int.
8230 (make_terminal_frame, set_term_frame_name): Print it.
8231 (x_report_frame_params): In X, window IDs are unsigned long,
8232 not signed long, so print them as unsigned.
8233 (validate_x_resource_name): Check for implausibly long names,
8234 and don't assume name length fits in 'int'.
8235 (x_get_resource_string): Don't blindly alloca invocation name;
8236 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8237 not fit in int.
8238
6e1a67fb
PE
8239 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8240 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8241 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8242
0df02bf3
PE
8243 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8244 Use esprintf, not sprintf, in case result does not fit in int.
8245
48e30793
PE
8246 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8247 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8248 it as a large positive number.
8249 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8250 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8251
a66ff6d8
PE
8252 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8253 in case result does not fit in int.
8254
aca216ff
PE
8255 * print.c (float_to_string): Detect width overflow more reliably.
8256 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8257 buffer overrun. Don't assume list length fits in 'int'. Treat
8258 print length of 0 as 0, not as infinity; to be consistent with other
8259 uses of print length in this function. Don't overflow print length
8260 index. Don't assume hash table size fits in 'long', or that
8261 vectorlike size fits in 'unsigned long'.
8262
31c286f7
PE
8263 * process.c (make_process): Use printmax_t, not int, to format
8264 process-name gensyms.
8265
55e5faa1
PE
8266 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8267
80f2e268
PE
8268 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8269 to avoid potential buffer overrun.
8270
670741ab
PE
8271 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8272 if X resource line is longer than 512 bytes.
8273
b7163a50
PE
8274 * xfns.c (x_window): Make sprintf buffer a bit bigger
8275 to avoid potential buffer overrun.
8276
ae58ff1f
PE
8277 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8278
c43c8a6a
PE
8279 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8280
3f8236f4
PE
82812011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8282
53e9fe90 8283 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8284 Without these, Emacs silently mishandles large integers sometimes.
8285 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8286 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8287
6511acf2
PE
8288 * xdisp.c (try_window_id): Check Emacs fixnum range before
8289 converting to 'int'.
806add1d 8290
6511acf2 8291 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8292 Check that an Emacs fixnum is in range before assigning it to 'int'.
8293 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8294 values converted from Emacs fixnums.
8295 (Frecenter): Don't wrap around a line count if it is out of 'int'
8296 range; instead, treat it as an extreme value.
8297 (Fset_window_configuration, compare_window_configurations):
8298 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8299
6511acf2
PE
8300 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8301 that can exceed INT_MAX. Check that EMACS_INT value is in range
8302 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8303 (match_limit): Don't assume that a fixnum can fit in 'int'.
8304
6511acf2 8305 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8306 exceed INT_MAX.
8307
6511acf2 8308 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8309 (Fvertical_motion): Don't wrap around LINES values that don't fit
8310 in 'int'. Instead, treat them as extreme values. This is good
8311 enough for windows, which can't have more than INT_MAX lines anyway.
8312
fcb901a7
LMI
83132011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8314
0f2f6b6d
LMI
8315 * Require libxml/parser.h to avoid compilation warning.
8316
fcb901a7
LMI
8317 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8318
8319 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8320 since this reportedly can destroy thread storage.
8321
6e20a0d4
CY
83222011-08-30 Chong Yidong <cyd@stupidchicken.com>
8323
8324 * syntax.c (find_defun_start): Update all cache variables if
8325 exiting early (Bug#9401).
8326
148ae00e
EZ
83272011-08-30 Eli Zaretskii <eliz@gnu.org>
8328
f6cfbd8f
EZ
8329 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8330
148ae00e
EZ
8331 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8332 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8333 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8334
8335 * term.c (tty_append_glyph): New function.
8336 (produce_stretch_glyph): Static function and its prototype deleted.
8337
a66cfb1c
SM
8338 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8339 Add prototypes.
148ae00e 8340
c4a07a4c
PE
83412011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8342
8343 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8344 when checking :margin (Bug#9390).
8345 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8346 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8347 so that the name doesn't mislead. All uses changed.
8348
6bc8cd65
JB
83492011-08-28 Johan Bockgård <bojohan@gnu.org>
8350
8351 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8352 set_tty_hooks.
8353
dca4927e
EZ
83542011-08-27 Eli Zaretskii <eliz@gnu.org>
8355
8356 * xdisp.c (move_it_to): Don't bail out early when reaching
8357 position beyond to_charpos, if we are scanning backwards.
8358 (move_it_vertically_backward): When DY == 0, make sure we get to
8359 the first character in the line after the newline.
8360
f2cad773
PE
83612011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8362
8363 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8364 (ccl_driver): Do not generate an out-of-range pointer.
8365 (Fccl_execute_on_string): Remove unnecessary check for
8366 integer overflow, noted by Stefan Monnier in
8367 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8368 Remove a FIXME that didn't need fixing.
8369 Simplify the newly-introduced buffer reallocation code.
8370
0cae2cdb
JB
83712011-08-27 Juanma Barranquero <lekktu@gmail.com>
8372
8373 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8374
5fc295a4 83752011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8376
70c60eb2 8377 Integer and memory overflow issues (Bug#9196).
726e0ab1 8378
d31850da
PE
8379 * doc.c (get_doc_string): Rework so that
8380 get_doc_string_buffer_size is the actual buffer size, rather than
8381 being 1 less than the actual buffer size; this makes xpalloc more
8382 convenient.
8383
a69fbedb
PE
8384 * image.c (x_allocate_bitmap_record, cache_image):
8385 * xselect.c (Fx_register_dnd_atom):
8386 Simplify previous changes by using xpalloc.
8387
fe5c5d37
PE
8388 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8389 since either will do and ptrdiff_t is convenient with xpalloc.
8390
0065d054
PE
8391 * charset.c (charset_table_size)
8392 (struct charset_sort_data.priority): Now ptrdiff_t.
8393 (charset_compare): Don't overflow if priorities differ greatly.
8394 (Fsort_charsets): Don't assume list length fits in int.
8395 Check for size-calculation overflow when allocating sort data.
8396 (syms_of_charset): Allocate an initial charset table that is
8397 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8398
8399 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8400
8401 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8402 The actual value is always <= INT_MAX, and leaving it unsigned made
8403 overflow checking harder.
8404
8405 * dispextern.h (struct glyph_matrix.rows_allocated)
8406 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8407 with xpalloc. The values are still always <= INT_MAX.
8408
8409 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8410
8411 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8412 (SAFE_NALLOCA): New macro.
8413
8414 * region-cache.c (struct boundary.pos, find_cache_boundary)
8415 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8416 (set_cache_region, invalidate_region_cache)
8417 (revalidate_region_cache, know_region_cache, region_cache_forward)
8418 (region_cache_backward, pp_cache):
8419 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8420 so that ptrdiff_t * can be passed to xpalloc.
8421 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8422 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8423 (pp_cache): Don't assume cache_len fits in int.
8424 * region-cache.h: Adjust extern decls to match.
8425
8426 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8427 EMACS_INT, since either will do, for xpalloc.
8428
8429 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8430 (xnmalloc, xnrealloc, xpalloc): New functions.
8431
726e0ab1
PE
8432 * bidi.c (bidi_shelve_header_size): New constant.
8433 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8434 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8435
51f30bc5 8436 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8437 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8438 (overlay_strings):
8439 Don't update size of array until after memory allocation succeeds,
8440 because xmalloc/xrealloc may not return.
0065d054
PE
8441 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8442 now that we have proper integer overflow checking.
8443 (record_overlay_string, overlay_strings): Catch overflows when
8444 calculating size of overlay_str_buf.
726e0ab1 8445
0065d054
PE
8446 * callproc.c (Fcall_process): Check for size overflow when
8447 calculating size of args2.
8448 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8449 Normally we prefer signed values, but sticking with ptrdiff_t would
8450 require adding more-complicated checks.
726e0ab1
PE
8451
8452 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8453 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8454 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8455 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8456
8457 * character.c (Fstring): Check for size-calculation overflow.
8458
8459 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8460 unnecessary integer overflow. Check for size overflow.
8461 (encode_coding_object): Don't update size until xmalloc succeeds.
8462
8463 * composite.c (get_composition_id): Check for overflow in glyph
8464 length calculations.
8465
8466 Integer and memory overflow fixes for display code.
8467 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8468 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8469 (scrolling_window): Check for overflow in size calculations.
8470 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8471 Don't assume glyph table len fits in int.
8472 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8473 (row_table_size): Now ptrdiff_t, not int.
8474 (scrolling_window): Avoid overflow in size calculations.
8475 Don't update size until allocation succeeds.
8476 * fns.c (concat): Check for overflow in size calculations.
8477 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8478 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8479 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8480
8481 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8482 (get_doc_string): Check for size calculation overflow.
8483 Don't update size until allocation succeeds.
8484 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8485 EMACS_INT, where ptrdiff_t will do.
8486 (Fsubstitute_command_keys): Check for string overflow.
8487
8488 * editfns.c (set_time_zone_rule): Don't assume environment length
8489 fits in int.
8490 (message_length): Now ptrdiff_t, not int.
8491 (Fmessage_box): Don't update size until allocation succeeds.
8492 Don't assume message length fits in int.
8493 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8494
0065d054
PE
8495 * emacs.c (main): Do not reallocate argv, since there is a null at
8496 the end that can be overwritten, and this way there's no need to
8497 worry about size-calculation overflow.
8498 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8499
8500 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8501 alloc succeeds.
8502 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8503
8504 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8505 (x_set_scroll_bar_width, x_figure_window_size):
8506 Check for integer overflow.
8507 (x_set_alpha): Do not assume XINT fits in int.
8508
8509 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8510 This is for the members text_lines, text_cols, total_lines, total_cols,
8511 where the system imposes an 'int' limit.
8512
8513 * fringe.c (Fdefine_fringe_bitmap):
8514 Don't update size until alloc works.
8515
8516 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8517 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8518
8519 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8520 Check for size-calculation overflow.
8521 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8522 do, as we prefer signed integers.
8523 (id_to_widget.max_size, id_to_widget.used)
8524 (xg_store_widget_in_map, xg_remove_widget_from_map)
8525 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8526 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8527 Use and return ptrdiff_t, not int.
8528 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8529 * gtkutil.h: Change prototypes to match the above.
8530
8531 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8532 are duplicate now that they've been promoted to lisp.h.
8533 (x_allocate_bitmap_record, x_alloc_image_color)
8534 (make_image_cache, cache_image, xpm_load):
8535 Don't update size until alloc is done.
8536 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8537 (x_detect_edges):
3256efce 8538 Check for size calculation overflow.
726e0ab1
PE
8539 (ct_colors_allocated_max): New constant.
8540 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8541 overflow.
3256efce 8542
726e0ab1
PE
8543 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8544 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8545 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8546 Use ptrdiff_t, not int, to count maps.
8547 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8548 calculations. Don't update size until allocation succeeds.
8549 Redo calculations to avoid overflow.
726e0ab1
PE
8550 * keyboard.h: Change prototypes to match the above.
8551
8552 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8553 to count maps.
8554 (current_minor_maps): Check for size calculation overflow.
8555 * keymap.h: Change prototypes to match the above.
8556
8557 * lread.c (read1, init_obarray): Don't update size until alloc done.
8558
8559 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8560 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8561
726e0ab1
PE
8562 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8563 Now ptrdiff_t, not int.
8564 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8565 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8566
8567 * process.c (Fnetwork_interface_list): Check for overflow
8568 in size calculation.
8569
8570 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8571
8572 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8573 overflow. Don't bother calling xmalloc when xrealloc will do.
8574
8575 * search.c (Freplace_match): Check for size calculation overflow.
8576 (Fset_match_data): Don't assume list lengths fit in 'int'.
8577
8578 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8579 for command line length. Do not attempt to address one before the
8580 beginning of an array, as that's not portable.
8581
8582 * term.c (max_frame_lines): Remove; unused.
8583 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8584 not int.
8585 (encode_terminal_code, calculate_costs): Check for size
8586 calculation overflow.
8587 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8588 table lengths and related sizes. Don't update size until alloc
8589 done. Redo calculations to avoid overflow.
8590 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8591
8592 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8593 subtracting pointers.
8594 (gobble_line): Check for overflow more carefully. Don't update size
8595 until alloc done.
8596
8597 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8598 Don't update size until alloc done.
8599 Redo size calculations to avoid overflow.
8600 Check for size calculation overflow.
0065d054 8601 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8602
8603 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8604 Use ptrdiff_t, not int, for sizes.
8605 (store_mode_line_noprop_char): Don't update size until alloc done.
8606
0065d054
PE
8607 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8608 Use ptrdiff_t, not int, for sizes.
8609 (Finternal_make_lisp_face, cache_face):
8610 Check for size calculation overflow.
8611 (cache_face): Treat size calculation overflows as if they were
8612 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8613
8614 * xfns.c (x_encode_text, x_set_name_internal)
8615 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8616 sizes, since they can exceed INT_MAX in size. Check for size
8617 calculation overflow.
8618
0065d054
PE
8619 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8620 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8621 Don't update size until alloc done.
8622
0065d054 8623 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8624 as sprintf is limited to int lengths.
1d526e2f 8625
252c5ee1
PE
8626 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8627 (X_LONG_MIN): New macros.
864d7ce7
PE
8628 Use them to make the following changes clearer.
8629 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8630 This change doesn't affect the value now, but it may help remind
8631 future maintainers not to raise the value too much later.
8632 (SELECTION_QUANTUM): Remove, replacing with ...
8633 (selection_quantum): ... new function, which avoids overflow.
8634 All uses changed.
8635 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8636 assumption that selection length fits in 'int'.
8637 (x_reply_selection_request, x_handle_selection_request)
8638 (x_get_window_property, receive_incremental_selection)
8639 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8640 (lisp_data_to_selection_data, clean_local_selection_data):
8641 Use ptrdiff_t, not int, to record length of selection.
8642 (x_reply_selection_request, x_get_window_property)
8643 (receive_incremental_selection, x_property_data_to_lisp):
8644 Redo calculations to avoid overflow.
8645 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8646 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8647 something.
8648 (x_get_window_property, receive_incremental_selection)
8649 (lisp_data_to_selection_data, x_property_data_to_lisp):
8650 Check for size-calculation overflow.
8651 (x_get_window_property, receive_incremental_selection)
8652 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8653 Don't store size until memory allocation succeeds.
8654 (x_get_window_property): Plug memory leak on memory exhaustion.
8655 Don't double-block input; malloc is safe here. Don't assume 2**34
8656 - 4 fits in unsigned long. Add an xassert to check
8657 XGetWindowProperty overflow. Be more careful about overflow
8658 calculations, and distinguish size from memory overflow better.
8659 (receive_incremental_selection): When tracing, don't assume
8660 unsigned int is less than INT_MAX.
8661 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8662 harmful) conversions of unsigned short to int.
8663 (lisp_data_to_selection_data): Don't assume that integers
8664 in the range -65535 through -1 fit in an X unsigned short.
8665 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8666 result parameters unless successful. Rely on cons_to_unsigned
8667 to report problems with elements; the old code wasn't right anyway.
8668 (x_check_property_data): Check for int overflow; we cannot use
8669 a wider type due to X limits.
8670 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8671
726e0ab1 8672 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8673
0065d054
PE
8674 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8675 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8676 (x_color_cells): Don't store size until memory allocation succeeds.
8677 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8678 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8679 (x_term_init): Don't assume length fits in int (sprintf is limited
8680 to int size).
bc18e09d 8681
ebfa62c0
PE
8682 Use ptrdiff_t for composition IDs.
8683 * character.c (lisp_string_width):
8684 * composite.c (composition_table_size, n_compositions)
8685 (get_composition_id, composition_gstring_from_id):
8686 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8687 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8688 * window.c (Frecenter):
8689 Use ptrdiff_t, not int, for composition IDs.
8690 * composite.c (get_composition_id): Check for integer overflow.
8691 * composite.h: Adjust prototypes to match the above changes.
8692
d3411f89
PE
8693 Use ptrdiff_t for hash table indexes.
8694 * category.c (hash_get_category_set):
8695 * ccl.c (ccl_driver):
8696 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8697 * coding.c (coding_system_charset_list, detect_coding_system):
8698 * coding.h (struct coding_system.id):
8699 * composite.c (get_composition_id, gstring_lookup_cache):
8700 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8701 * image.c (xpm_get_color_table_h):
8702 * lisp.h (hash_lookup, hash_put):
8703 * minibuf.c (Ftest_completion):
8704 Use ptrdiff_t for hash table indexes, not int (which is too
8705 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8706 32-bit --with-wide-int hosts).
8707
e097a6fa
PE
8708 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8709 Add a FIXME comment about memory leaks.
8710 (syms_of_charset): Don't assume xmalloc returns.
8711
5637687f
PE
8712 Don't assume that stated character widths fit in int.
8713 * character.c (Fchar_width, c_string_width, lisp_string_width):
8714 * character.h (CHAR_WIDTH):
8715 * indent.c (MULTIBYTE_BYTES_WIDTH):
8716 Use sanitize_char_width to avoid undefined and/or bad behavior
8717 with outlandish widths.
a66cfb1c 8718 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8719 now that we have two such functions. All uses changed.
8720 (sanitize_char_width): New inline function.
8721
a2271ba2
PE
8722 Don't assume that tab-width fits in int.
8723 * character.h (sanitize_width): New inline function.
8724 (SANE_TAB_WIDTH): New macro.
8725 (ASCII_CHAR_WIDTH): Use it.
8726 * indent.c (sane_tab_width): Remove. All uses replaced by
8727 SANE_TAB_WIDTH (current_buffer).
8728 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8729
18c52557
PE
8730 * fileio.c: Integer overflow issues with file modes.
8731 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8732
caeeedc1
PE
8733 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8734 Remove unreachable code.
8735 (read_hex, load_charset_map_from_file): Check for integer overflow.
8736
6df6ae42 8737 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8738 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8739 (x_send_scroll_bar_event): Likewise. Check that the size does not
8740 exceed limits imposed by XClientMessageEvent, as well as the usual
8741 ptrdiff_t and size_t limits.
8742
b13995db
PE
8743 * keyboard.c: Overflow, signedness and related fixes.
8744 (make_lispy_movement): Use same integer type in forward decl
8745 that is used in the definition.
8746 (read_key_sequence, keyremap_step):
8747 Change bufsize argument back to int, undoing my 2011-03-30 change.
8748 We prefer signed types, and int is wide enough here.
8749 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8750 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8751 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8752 length, not size_t. Use ptrdiff_t for index, not int.
8753 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8754 possibility of integer overflow.
8755
13464394
PE
8756 Overflow, signedness and related fixes for images.
8757
8758 * dispextern.h (struct it.stack[0].u.image.image_id)
8759 (struct_it.image_id, struct image.id, struct image_cache.size)
8760 (struct image_cache.used, struct image_cache.ref_count):
8761 * gtkutil.c (update_frame_tool_bar):
8762 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8763 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8764 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8765 * nsmenu.m (update_frame_tool_bar):
8766 * xdisp.c (calc_pixel_width_or_height):
8767 * xfns.c (image_cache_refcount):
8768 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8769 on typical 64-bit hosts.
8770
8771 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8772 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8773 Omit unnecessary casts to int.
8774 (parse_image_spec): Check that integers fall into 'int' range
8775 when the callers expect that.
8776 (image_ascent): Redo ascent calculation to avoid int overflow.
8777 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8778 (lookup_image): Remove unnecessary tests.
8779 (xbm_image_p): Locals are now of int, not EMACS_INT,
8780 since parse_image_check makes sure they fit into int.
8781 (png_load, gif_load, svg_load_image):
8782 Prefer int to unsigned where either will do.
8783 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8784 old tiff_error_handler and tiff_warning_handler.
8785 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8786 stack buffer overflows. It uses only the features of vsnprintf
8787 that are common to both POSIX and native Microsoft.
8788 (tiff_error_handler, tiff_warning_handler): Use it.
8789 (tiff_load, gif_load, imagemagick_load_image):
8790 Don't assume :index value fits in 'int'.
8791 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8792 (imagemagick_load_image): Check that crop parameters fit into
8793 the integer types that MagickCropImage accepts. Don't assume
8794 Vimagemagick_render_type has a nonnegative value. Don't assume
8795 size_t fits in 'long'.
8796 (gs_load): Use printmax_t to print the widest integers possible.
8797 Check for integer overflow when computing image height and width.
8798
c11821d4
EZ
87992011-08-26 Eli Zaretskii <eliz@gnu.org>
8800
8801 * xdisp.c (redisplay_window): Don't force window start if point
8802 will be invisible in the resulting window. (Bug#9324)
8803
0c95fcf7
EZ
88042011-08-25 Eli Zaretskii <eliz@gnu.org>
8805
8806 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8807 the display spec is of the form `(space ...)'.
8808 (handle_display_spec): Return the value returned by
8809 handle_single_display_spec, not just 1 or zero.
8810 (handle_single_display_spec): If the display spec is of the form
8811 `(space ...)', and specifies display in the text area, return 2
8812 rather than 1.
fee65a97 8813 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8814 accurately, and prefer exact match for point under bidi.
8815 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8816
8817 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8818 into disp_prop; all users changed.
8819
8820 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8821 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8822 for the text covered by the display property.
8823
e4ed06f1
CY
88242011-08-25 Chong Yidong <cyd@stupidchicken.com>
8825
8826 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8827 Change return value to nil.
8828 (Frecord_buffer): Delete unused function.
8829
f67cdd7f
EZ
88302011-08-24 Eli Zaretskii <eliz@gnu.org>
8831
5980d4c6
EZ
8832 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8833 buffers, return left-to-right.
8610fe8b
EZ
8834 (set_cursor_from_row): Consider candidate row a win if its glyph
8835 represents a newline and point is on that newline. Fixes cursor
8836 positioning on the newline at EOL of R2L text within L2R
8837 paragraph, and vice versa.
8838 (try_cursor_movement): Check continued rows, in addition to
8839 continuation rows. Fixes unwarranted scroll when point enters a
8840 continued line of R2L text within an L2R paragraph, or vice versa.
8841 (cursor_row_p): Consider the case of point being equal to
8842 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8843 from the end of a short line to the beginning of a continued line
8844 of R2L text within L2R paragraph.
8845 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8846 composed characters.
5980d4c6 8847
f67cdd7f
EZ
8848 * bidi.c (bidi_check_type): Use xassert.
8849 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8850 members.
8851
bca633fb
EZ
88522011-08-23 Eli Zaretskii <eliz@gnu.org>
8853
8854 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8855 a character.
8856
4a5885a7
CY
88572011-08-23 Chong Yidong <cyd@stupidchicken.com>
8858
8859 * nsfont.m (ns_otf_to_script): Fix typo.
8860
0902a04e
KH
88612011-08-22 Kenichi Handa <handa@m17n.org>
8862
8863 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8864 extra slot even if the purpose is char-code-property-table.
8865
1a2e6670
EZ
88662011-08-23 Eli Zaretskii <eliz@gnu.org>
8867
8ddde651
EZ
8868 * xdisp.c (redisplay_window): When computing centering_position,
8869 account for the height of the header line. (Bug#8874)
8870
425cc014
EZ
8871 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8872 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8873 candidate is selected by the mouse, and that candidate has a
8874 composed character under the mouse.
8875
1a2e6670
EZ
8876 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8877 coordinates reported by pos-visible-in-window-p for a composed
8878 character in column zero.
8879
8b76d6f8
SM
88802011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8881
8882 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8883
dac347dd
EZ
88842011-08-22 Eli Zaretskii <eliz@gnu.org>
8885
8886 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8887 consider it a hit if to_charpos is anywhere in the range of the
8888 composed buffer positions.
8889
e013fb34
CY
88902011-08-22 Chong Yidong <cyd@stupidchicken.com>
8891
8892 * image.c (gif_load): Don't assume that each subimage has the same
8893 dimensions as the base image. Handle disposal method that is
8894 "undefined" by the gif spec (Bug#9335).
8895
bd1ba3e8
CY
88962011-08-20 Chong Yidong <cyd@stupidchicken.com>
8897
8898 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8899 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8900
54a1215b
EZ
89012011-08-19 Eli Zaretskii <eliz@gnu.org>
8902
823564e5
EZ
8903 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8904 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8905 from an Org mode buffer to a Speedbar frame.
8906
54a1215b
EZ
8907 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8908 a composition, take its buffer position from IT->cmp_it.charpos.
8909 Fixes cursor positioning at the beginning of a line that begins
8910 with a composed character.
8911
9778ebcc
EZ
89122011-08-18 Eli Zaretskii <eliz@gnu.org>
8913
0be6ee06
EZ
8914 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8915 character bidirectional type, use STRONG_L instead. Fixes crashes
8916 in a buffer produced by `describe-categories'.
8917
9778ebcc
EZ
8918 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8919 members before the level stack, so they would be saved and
8920 restored when copying iterator state. Fixes incorrect reordering
8921 around TABs covered by display properties.
8922
156bffbe
AS
89232011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8924
6b02f655 8925 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8926
72ad093b
CY
89272011-08-17 Chong Yidong <cyd@stupidchicken.com>
8928
8929 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8930 (internal_condition_case_2, internal_condition_case_n):
8931 Remove unnecessary aborts (Bug#9081).
72ad093b 8932
35774242
EZ
89332011-08-17 Eli Zaretskii <eliz@gnu.org>
8934
8935 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8936 has no `load' handler, try opening the file locally. (Bug#9311)
8937
db76dd85
KB
89382011-08-16 Ken Brown <kbrown@cornell.edu>
8939
8940 * gmalloc.c: Expand comment.
8941
b215eee5
EZ
89422011-08-16 Eli Zaretskii <eliz@gnu.org>
8943
8944 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8945 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8946
a4579d33
KB
89472011-08-16 Ken Brown <kbrown@cornell.edu>
8948
8949 Fix memory allocation problems in Cygwin build (Bug#9273).
8950
8951 * unexcw.c ( __malloc_initialized): Declare external variable.
8952 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8953
8b76d6f8
SM
8954 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8955 New variables.
a4579d33
KB
8956 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8957 dumped emacs.
8958 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8959 in the static heap.
8960 [CYGWIN] (special_realloc): New function.
8961 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8962 requests to realloc storage in the static heap.
8963
3ebec551
PE
89642011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8965
8966 * bidi.c (bidi_initialize): Remove unused local.
8967
9fd8be00
EZ
89682011-08-15 Eli Zaretskii <eliz@gnu.org>
8969
6b02f655
SM
8970 * bidimirror.h:
8971 * biditype.h: Remove file.
8972 * makefile.w32-in ($(BLD)/bidi.$(O)):
8973 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8974
8975 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8976
8977 * chartab.c: Improve commentary for the uniprop_table API.
8978
32413314
EZ
8979 * bidi.c (bidi_paragraph_init): Support zero value of
8980 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8981 (bidi_initialize): Use uniprop_table instead of including
8982 biditype.h and bidimirror.h.
32413314 8983
9fd8be00
EZ
8984 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8985 coordinates of the iterator when restoring from ppos_it.
8986 (Bug#9296)
8987
5cf2b69b
KH
89882011-08-14 Kenichi Handa <handa@m17n.org>
8989
8990 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8991 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8992
daf17d00
EZ
89932011-08-14 Eli Zaretskii <eliz@gnu.org>
8994
8995 * xdisp.c (move_it_in_display_line_to): Don't invoke
8996 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8997 ppos_it. Fixes vertical cursor motion when line beginning is
8998 covered by an image. (Bug#9296)
8999
08e3161a
JD
90002011-08-14 Jan Djärv <jan.h.d@swipnet.se>
9001
9002 * nsterm.h (ns_run_ascript): Declare.
9003 (NSAPP_DATA2_RUNASSCRIPT): Define.
9004
9005 * nsfns.m (as_script, as_result, as_status): New static variables.
9006 (ns_run_ascript): New function.
5e617bc2 9007 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
9008 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
9009 the event loop. Get status from as_status (Bug#7276).
9010
9011 * nsterm.m (sendEvent): If event is NSApplicationDefined and
9012 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
9013 the event loop (Bug#7276).
9014
a3720aa2
AS
90152011-08-14 Andreas Schwab <schwab@linux-m68k.org>
9016
9017 * gnutls.c (QCgnutls_bootprop_priority)
9018 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
9019 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
9020 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
9021 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
9022 (QCgnutls_bootprop_verify_hostname_error)
9023 (QCgnutls_bootprop_callbacks_verify): Rename from
9024 Qgnutls_bootprop_..., all uses changed.
9025
9026 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
9027 uses changed.
9028
0a0d27fb
PE
90292011-08-14 Paul Eggert <eggert@cs.ucla.edu>
9030
19d5c50c
PE
9031 * xfaces.c (Qframe_set_background_mode): Now static.
9032 * dispextern.h (Qframe_set_background_mode): Remove decl.
9033
0a0d27fb
PE
9034 * process.c (Fnetwork_interface_info): Declare local only if needed.
9035
377538cb
JD
90362011-08-13 Jan Djärv <jan.h.d@swipnet.se>
9037
9038 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
9039 (Fnetwork_interface_list): Allocate in increments of bytes instead
9040 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
9041 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
9042 sockaddr.
9043 (struct ifflag_def): notrailers is smart on OSX.
9044 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
9045 Get hardware address with getifaddrs if available.
9046
08fff70c
EZ
90472011-08-12 Eli Zaretskii <eliz@gnu.org>
9048
9049 * xdisp.c (iterate_out_of_display_property): xassert that
9050 IT->position is set to within IT->object's boundaries. Break from
9051 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
9052 when IT->position is set up wrongly due to some bug.
9053 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
9054 (push_display_prop): Allow GET_FROM_STRING as IT->method on
9055 entry. Force push_it to save on the stack the current
9056 buffer/string position, to be restored by pop_it. Fix flags in
9057 the iterator structure wrt the object coming from a display
9058 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
9059 properties. (Bug#9284)
9060
7be1c708 90612011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 9062
7be1c708
CY
9063 * fontset.c (fontset_get_font_group): Add proper type checks.
9064 (Bug#9172)
aac0c6e3 9065
7be1c708 90662011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 9067
7be1c708
CY
9068 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
9069 and LC_VERSION_MIN_MACOSX.
9070 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
9071 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 9072
97bb72a6
EZ
90732011-08-08 Eli Zaretskii <eliz@gnu.org>
9074
9075 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
9076 no-display-properties-and-no-overlays under bidi display.
9077 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 9078 properties and overlays.
97bb72a6 9079
d5617611
CY
90802011-08-08 Chong Yidong <cyd@stupidchicken.com>
9081
37e11a63
CY
9082 * editfns.c (Fset_time_zone_rule): Document relationship with the
9083 setenv function.
9084
d5617611
CY
9085 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
9086 the font entity extracted from the cache (Bug#8109).
9087
58872834
CY
90882011-08-07 Chong Yidong <cyd@stupidchicken.com>
9089
9090 * composite.c (autocmp_chars): Don't reset point. That is done by
9091 restore_point_unwind (Bug#5984).
9092
75bfc667
JL
90932011-08-07 Juri Linkov <juri@jurta.org>
9094
9095 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
9096 to show the arg `TIME' instead of `TIMEVAL'.
9097
d1410150
EZ
90982011-08-06 Eli Zaretskii <eliz@gnu.org>
9099
9100 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
9101 display property strides EOL and includes a newline, as in
9102 longlines-mode. (Bug#9254)
75b771e4
EZ
9103 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
9104 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
9105
9106 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
9107 is non-zero, even if the data buffer is NULL. Fixes a crash in
9108 vertical-motion with longlines-mode. (Bug#9254)
9109
35928349
EZ
91102011-08-05 Eli Zaretskii <eliz@gnu.org>
9111
ec7cc85b
EZ
9112 * bidi.c <bidi_cache_total_alloc>: Now static.
9113 (bidi_initialize): Initialize bidi_cache_total_alloc.
9114
8b76d6f8 9115 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9116 cache. (Bug#9221)
9117
9118 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9119 amount allocated this far in `bidi_cache_total_alloc'.
9120 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9121 non-zero, only free the data buffer without restoring the cache
9122 contents. All callers changed.
9123
9124 * dispextern.h (bidi_unshelve_cache): Update prototype.
9125
9126 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9127 (move_it_in_display_line, move_it_to)
9128 (move_it_vertically_backward, move_it_by_lines): Replace the call
9129 to xfree to an equivalent call to bidi_unshelve_cache.
9130 (move_it_in_display_line_to): Fix logic of returning
412b6358 9131 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9132
e2e2423b
EZ
91332011-08-05 Eli Zaretskii <eliz@gnu.org>
9134
9135 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9136 came from a string character with a `cursor' property. (Bug#9229)
9137
ae9e757a
JD
91382011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9139
9140 * Makefile.in (LIB_PTHREAD): New variable.
9141 (LIBES): Add LIB_PTHREAD (Bug#9216).
9142
9143 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9144 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9145
213bd7f2
AS
91462011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9147
6b02f655 9148 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9149
99aaf75f
JD
91502011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9151
9152 * xterm.c (x_find_topmost_parent): New function.
9153 (x_set_frame_alpha): Find topmost parent window with
9154 x_find_topmost_parent and set the property there also (bug#9181).
9155 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9156
c74e9d86
PE
91572011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9158
9159 * callproc.c (Fcall_process): Avoid vfork clobbering
9160 the local vars buffer, coding_systems, current_dir.
9161
640c8776
SM
91622011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9163
9164 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9165
f26d0e4c
PE
91662011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9167
8a10d76c
PE
9168 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9169 so that it is not optimized away.
9170
f26d0e4c
PE
9171 * xdisp.c (compute_display_string_pos): Remove unused local.
9172
55439c61
EZ
91732011-08-02 Eli Zaretskii <eliz@gnu.org>
9174
9175 Fix slow cursor motion and scrolling in large buffers with
9176 selective display, like Org Mode buffers. (Bug#9218)
9177
9178 * dispextern.h (struct bidi_it): New member disp_prop_p.
9179
9180 * xdisp.c: Remove one-slot cache of display string positions.
9181 (compute_display_string_pos): Accept an additional argument
5e617bc2 9182 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9183 for a display string or property. If found, set DISP_PROP_P
9184 non-zero.
9185
9186 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9187 DISP_PROP_P, and pass it to compute_display_string_pos.
9188 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9189 non-zero. All callers of bidi_fetch_char changed.
9190
fb33fa43
SM
91912011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9192
9193 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9194
b099e063
DM
91952010-12-03 Don March <don@ohspite.net>
9196
9197 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9198 last character M-[char] is translated to ESC [char] (bug#7541).
9199
5cc7f7af
KH
92002011-08-02 Kenichi Handa <handa@m17n.org>
9201
d0fffa3f 9202 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9203
9204 * chartab.c (uniprop_table): Make it non-static.
9205
525d5e6e
EZ
92062011-08-01 Eli Zaretskii <eliz@gnu.org>
9207
9208 * xdisp.c (forward_to_next_line_start): Accept additional argument
9209 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9210 on the newline.
9211 (reseat_at_next_visible_line_start): Use the bidi iterator state
9212 returned by forward_to_next_line_start to restore the state of
9213 it->bidi_it after backing up to previous newline. (Bug#9212)
9214
31011111
AS
92152011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9216
9217 * regex.c (re_comp): Protoize.
9218 (re_exec): Fix return type.
9219 (regexec): Fix type of `ret'. (Bug#9203)
9220
476371c4
PE
92212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9222
e5d76069
PE
9223 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9224 This is needed if max-image-size is a floating-point number.
9225
9a79b20c
AS
92262011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9227
9228 * print.c (print_object): Print empty symbol as ##.
9229
9230 * lread.c (read1): Read ## as empty symbol.
9231
d8c2fa78
AA
92322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9233
9234 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9235 setting frame foreground color (Bug#9175).
9236 (x_set_background_color): Likewise.
9237
ffe57a7a
AA
9238 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9239 contents (Bug#9176).
9240 (EmacsTooltip -init): Remove bezels and add shadows to
9241 tooltip windows.
9242
bf3492a5
AA
9243 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9244 or scroll bar (Bug#8470).
9245
d55e9c53
AA
9246 * nsfont.m (nsfont_open): Remove assignment to voffset and
9247 unnecessary vars hshink, expand, hd, full_height, min_height.
9248 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9249
9250 * nsterm.h (nsfont_info): Remove voffset field.
9251
d8c2fa78 92522011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9253
9254 Implement strike-through and overline on NextStep (Bug#8863).
9255
9256 * nsfont.m (nsfont_open): Use underline position provided by font,
9257 instead of hard-coded value of 2.
9258 (nsfont_draw): Call ns_draw_text_decoration instead.
9259
9260 * nsterm.h: Add declaration for ns_draw_text_decoration.
9261
9262 * nsterm.m (ns_draw_text_decoration): New function for drawing
9263 underline, overline, and strike-through.
9264 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9265 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9266 accommodate underlining, etc.
4843aac3 9267
4cc60b9b
EZ
92682011-07-28 Eli Zaretskii <eliz@gnu.org>
9269
bc7ece87
EZ
9270 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9271 default.
4cc60b9b 9272
476371c4
PE
92732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9274
66606eea
PE
9275 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9276 Without this fix, if a signal arrives just after memory fills up,
9277 'malloc' might be invoked reentrantly.
9278
476371c4
PE
9279 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9280 In other words, assume that every image size is allowed, on non-X
9281 hosts. This assumption is probably wrong, but it lets Emacs compile.
9282
f3fcc40d
AS
92832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9284
9285 * regex.c (re_iswctype): Convert return values to boolean.
9286
350c992f
EZ
92872011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9288
9289 * xdisp.c (compute_display_string_pos): Don't use cached display
9290 string position if the buffer had its restriction changed.
9291 (Bug#9184)
9292
5266b4bb
PE
92932011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9294
9295 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9296
2573a837 92972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9298
41f55ccd 9299 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9300
39e378da
PE
9301 * bidi.c: Integer size and overflow fixes.
9302 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9303 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9304 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9305 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9306 (bidi_find_other_level_edge):
9307 Use ptrdiff_t instead of EMACS_INT where either will do.
9308 This works better on 32-bit hosts configured --with-wide-int.
9309 (bidi_cache_ensure_space): Check for size-calculation overflow.
9310 Use % rather than repeated addition, for better worst-case speed.
9311 Don't set bidi_cache_size until after xrealloc returns, because it
9312 might not return.
9313 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9314 (bidi_cache_ensure_space): Also check that the bidi cache size
9315 does not exceed that of the largest Lisp string or buffer. See Eli
9316 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9317
5e927815
PE
9318 * alloc.c (__malloc_size_t): Remove.
9319 All uses replaced by size_t. See Andreas Schwab's note
9320 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9321
ca4aa935
PE
9322 * image.c: Improve checking for integer overflow.
9323 (check_image_size): Assume that f is nonnull, since
9324 it is always nonnull in practice. This is one less thing to
9325 worry about when checking for integer overflow later.
9326 (x_check_image_size): New function, which checks for integer
9327 overflow issues inside X.
9328 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9329 This removes the need for a memory_full check.
9330 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9331 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9332 (xbm_read_bitmap_data): Change locals back to 'int', since
9333 their values must fit in 'int'.
9334 (xpm_load_image, png_load, tiff_load):
9335 Invoke x_create_x_image_and_pixmap earlier,
9336 to avoid much needless work if the image is too large.
9337 (tiff_load): Treat overly large images as if
9338 x_create_x_image_and_pixmap failed, not as malloc failures.
9339 (gs_load): Use x_check_image_size.
9340
5f8f9cc2
PE
9341 * gtkutil.c: Omit integer casts.
9342 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9343 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9344
5adf60bc
PE
9345 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9346
c8907a93
PE
9347 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9348 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9349 would wrongly return t on a 64-bit host.
9350
e3c25c68
PE
9351 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9352 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9353 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9354 and therefore cause GCC to emit a bogus diagnostic in some cases.
9355
3f791afe
PE
9356 * image.c: Integer signedness and overflow and related fixes.
9357 This is not an exhaustive set of fixes, but it's time to
9358 record what I've got.
9359 (lookup_pixel_color, check_image_size): Remove redundant decls.
9360 (check_image_size): Don't assume that arbitrary EMACS_INT values
9361 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9362 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9363 (tiff_load, imagemagick_load_image):
9364 Check for overflow in size calculations.
9365 (x_create_x_image_and_pixmap): Remove unnecessary test for
9366 xmalloc returning NULL; that can't happen.
9367 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9368 (xpm_color_bucket): Use better integer hashing function.
9369 (xpm_cache_color): Don't possibly over-allocate memory.
9370 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9371 (gif_memory_source):
9372 Use ptrdiff_t, not int or size_t, to record sizes.
9373 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9374 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9375 either works, as we prefer signed integers.
9376 (tiff_read_from_memory, tiff_write_from_memory):
9377 Return tsize_t, not size_t, since that's what the TIFF API wants.
9378 (tiff_read_from_memory): Don't fail simply because the read would
9379 go past EOF; instead, return a short read.
9380 (tiff_load): Omit no-longer-needed casts.
9381 (Fimagemagick_types): Don't assume size fits into 'int'.
9382
3cc5a532
PE
9383 Improve hashing quality when configured --with-wide-int.
9384 * fns.c (hash_string): New function, taken from sxhash_string.
9385 Do not discard information about ASCII character case; this
9386 discarding is no longer needed.
9387 (sxhash-string): Use it. Change sig to match it. Caller changed.
9388 * lisp.h: Declare it.
9389 * lread.c (hash_string): Remove, since we now use fns.c's version.
9390 The fns.c version returns a wider integer if --with-wide-int is
9391 specified, so this should help the quality of the hashing a bit.
9392
b312a492
PE
9393 * emacs.c: Integer overflow minor fix.
9394 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9395 Define only if GNU_LINUX.
9396 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9397
dfd153ae
PE
9398 * dispnew.c: Integer signedness and overflow fixes.
9399 Remove unnecessary forward decls, that were a maintenance hassle.
9400 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9401 All uses changed.
9402 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9403 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9404 (prepare_desired_row, line_draw_cost):
9405 Use int, not unsigned, where either works.
9406 (save_current_matrix, restore_current_matrix):
9407 Use ptrdiff_t, not size_t, where either works.
9408 (init_display): Check for overflow more accurately, and without
9409 relying on undefined behavior.
9410
a81d11a3
PE
9411 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9412 Remove, replacing with the new symbols in lisp.h. All uses changed.
9413 * fileio.c (make_temp_name):
9414 * filelock.c (lock_file_1, lock_file):
9415 * xdisp.c (message_dolog):
9416 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9417 Use pMd etc. instead.
9418 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9419 replacing the pWIDE etc. symbols removed from editfns.c.
9420
3300e6fd
PE
9421 * keyboard.h (num_input_events): Now uintmax_t.
9422 This is (very slightly) less likely to mess up due to wraparound.
9423 All uses changed.
9424
fd05c7e9
PE
9425 * buffer.c: Integer signedness fixes.
9426 (alloc_buffer_text, enlarge_buffer_text):
9427 Use ptrdiff_t rather than size_t when either will do, as we prefer
9428 signed integers.
9429
903fe15d
PE
9430 * alloc.c: Integer signedness and overflow fixes.
9431 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9432 (__malloc_size_t): Default to size_t, not to int.
9433 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9434 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9435 Prefer ptrdiff_t to size_t when either would do, as we prefer
9436 signed integers.
9437 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9438 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9439 Now const. Initialize with values that are in range even if char
9440 is signed.
9441 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9442 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9443 These functions do the right thing with sizes > 2**32.
9444 (check_depth): Now ptrdiff_t, not int.
9445 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9446 Adjust to new way of storing sizes. Check for size overflow bugs
9447 in rest of code.
9448 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9449 slightly wrong anyway, as it missed one instance of
9450 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9451 (refill_memory_reserve): Omit needless cast to size_t.
9452 (mark_object_loop_halt): Mark as externally visible.
9453
ac82cc6a
PE
9454 * xselect.c: Integer signedness and overflow fixes.
9455 (Fx_register_dnd_atom, x_handle_dnd_message):
9456 Use ptrdiff_t, not size_t, since we prefer signed.
9457 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9458 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9459 x_dnd_atoms_size and x_dnd_atoms_length.
9460
c2d1e36d
PE
9461 * doprnt.c: Prefer signed to unsigned when either works.
9462 * eval.c (verror):
9463 * doprnt.c (doprnt):
9464 * lisp.h (doprnt):
9465 * xdisp.c (vmessage):
9466 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9467 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9468 prefer signed arithmetic to avoid comparison confusion.
9469 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9470 but is a bit tricky.
9471
0e926e56
PE
9472 Assume freestanding C89 headers, string.h, stdlib.h.
9473 * data.c, doprnt.c, floatfns.c, print.c:
9474 Include float.h unconditionally.
9475 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9476 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9477 * regex.c: Likewise for stddef.h, string.h.
9478 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9479 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9480 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9481 (STDC_HEADERS): Remove obsolete defines.
9482 * sysdep.c: Include limits.h unconditionally.
9483
9cfdb3ec
PE
9484 Assume support for memcmp, memcpy, memmove, memset.
9485 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9486 * regex.c (memcmp, memcpy):
9487 Remove; we assume C89 now.
9488
9489 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9490 (__malloc_safe_bcopy): Remove; no longer needed.
9491
cf950e6b 9492 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9493 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9494 well either way, and we prefer signed to unsigned.
9495
dbf38e02
LMI
94962011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9497
9498 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9499 closes the connection while we're reading (bug#9182).
9500
d6f0886c 95012011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9502
d6f0886c
JD
9503 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9504 are specified (Bug#9168).
24e0f6b1 9505
2eb1f9e6
PE
95062011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9507
9508 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9509 Found by GCC static checking and --with-wide-int on a 32-bit host.
9510
22381272 95112011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9512
9513 * xdisp.c (compute_display_string_pos): Fix logic of caching
9514 previous display string position. Initialize cached_prev_pos to
9515 -1. Fixes slow-down at the beginning of a buffer.
9516
f25e39b4
EZ
95172011-07-24 Eli Zaretskii <eliz@gnu.org>
9518
9519 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9520 for attrs[LFACE_FONTSET_INDEX].
9521
04c4b52e
PE
95222011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9523
9524 * xml.c (parse_region): Remove unused local
9525 that was recently introduced.
9526
c1734fbd
EZ
95272011-07-23 Eli Zaretskii <eliz@gnu.org>
9528
be18c5a5
EZ
9529 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9530 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9531
c1734fbd
EZ
9532 * xdisp.c (move_it_in_display_line_to): Record the best matching
9533 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9534 exit if none of the characters scanned was an exact match.
9535 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9536 when exact match is impossible due to invisible text, and the
9537 lines are truncated.
9538
a258d627
JD
95392011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9540
9541 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9542 for OSX >= 10.7.
9543
b6d5a689
EZ
95442011-07-22 Eli Zaretskii <eliz@gnu.org>
9545
0f74f785
EZ
9546 Fix a significant slow-down of cursor motion with C-n, C-p,
9547 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9548 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9549 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9550 (next_element_from_buffer): Call compute_stop_pos_backwards to
9551 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9552 base_level_stop.
9553 (reseat): Don't look for prev_stop, as that could mean a very long
9554 run.
9555 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9556 <cached_disp_overlay_modiff>: Cache for last found display string
9557 position.
551918c1 9558 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9559 about the same buffer in the same area of character positions, and
9560 the buffer wasn't changed since the time the display string
9561 position was cached.
551918c1 9562
b2d0c91a
EZ
95632011-07-22 Eli Zaretskii <eliz@gnu.org>
9564
9565 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9566 is an integer, which is important for empty lines. (Bug#9149)
9567
043604ee
CY
95682011-07-22 Chong Yidong <cyd@stupidchicken.com>
9569
9570 * frame.c (Fmodify_frame_parameters): In tty case, update the
9571 default face if necessary (Bug#4238).
9572
da4adb04
CY
95732011-07-21 Chong Yidong <cyd@stupidchicken.com>
9574
9575 * editfns.c (Fstring_to_char): No need to explain what a character
9576 is in the docstring (Bug#6576).
9577
9abd0532
LMI
95782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9579
9580 * xml.c (parse_region): Make sure we always return a tree.
9581
36881d16
HK
95822011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9583
9584 * xml.c (parse_region): If a document contains only comments,
9585 return that, too.
9586
1e98674d
LMI
95872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9588
9589 * xml.c (make_dom): Return comments, too.
9590
590bd467
PE
95912011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9592
9593 Port to OpenBSD.
9594 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9595 and the surrounding thread.
9596 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9597 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9598 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9599 timer goes off.
9600 * s/openbsd.h (BROKEN_SIGIO): Define.
9601 * unexelf.c (unexec) [__OpenBSD__]:
9602 Don't update the .mdebug section of the Alpha COFF symbol table.
9603
f41628b2
LMI
96042011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9605
9606 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9607 (bug#8460).
9608
b59b67c5
PE
96092011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9610
15e3a074
PE
9611 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9612 This fixes some race conditions on the permissions of any newly
9613 created file.
9614
41bed37d
PE
9615 * alloc.c (valid_pointer_p): Use pipe, not open.
9616 This fixes some permissions issues when debugging.
9617
b59b67c5
PE
9618 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9619 If fchown fails to set both uid and gid, try to set just gid,
9620 as that is sometimes allowed. Adjust the file's mode to eliminate
9621 setuid or setgid bits that are inappropriate if fchown fails.
9622
925a6be7
SM
96232011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9624
9625 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9626 to compare Lisp_Objects.
9627 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9628 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9629 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9630
52968808
AS
96312011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9632
0a6a104b
AS
9633 * lread.c (read_integer): Unread even EOF character.
9634 (read1): Likewise. Properly record start position of symbol.
9635
52968808
AS
9636 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9637 symbol character follows.
9638
9e381cdd
PE
96392011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9640
9641 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9642 This works around a problem with the previous change to Fcopy_file.
9643 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9644 and without this change, GCC might complain about discarding
9645 fchown's return value.
9646
b5641435
JB
96472011-07-16 Juanma Barranquero <lekktu@gmail.com>
9648
9649 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9650
a8031457
PE
96512011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9652
9653 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9654
dd889327
LMI
96552011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9656
750c33f7
LMI
9657 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9658 it's used from the C level.
9659
dd889327
LMI
9660 * process.c: Use the same condition for POLL_FOR_INPUT in both
9661 keyboard.c and process.c (bug#1858).
9662
87e86684
LM
96632011-07-09 Lawrence Mitchell <wence@gmx.li>
9664
9665 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9666 (Fgnutls_boot): Use it.
9667
64348f40
AS
96682011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9669
9670 * doc.c (Fsubstitute_command_keys): Revert last change.
9671
1d698799
LMI
96722011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9673
f863868c
LMI
9674 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9675 quotes the next character, and doesn't affect other longer
9676 sequences (bug#8935).
9677
1d698799
LMI
9678 * lread.c (syms_of_lread): Clarify that is isn't only
9679 `eval-buffer' and `eval-defun' that's affected by
9680 `lexical-binding' (bug#8460).
9681
aa4b6df6
EZ
96822011-07-15 Eli Zaretskii <eliz@gnu.org>
9683
9684 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9685 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9686
5d856da6
PE
96872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9688
ad6042bb
PE
9689 Fix minor problems found by static checking.
9690 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9691 (elsz): Now a signed constant, not a size_t var. We prefer signed
9692 types to unsigned, to avoid integer comparison confusion. Without
9693 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9694 "cannot optimize loop, the loop counter may overflow", a symptom
9695 of the confusion.
f00bbb22 9696 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9697 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9698
6468f31c
LMI
96992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9700
49080b10
LMI
9701 * search.c (Fre_search_backward): Mention `case-fold-search' in
9702 all the re_search_* functions (bug#8138).
9703
6468f31c
LMI
9704 * keyboard.c (Fopen_dribble_file): Document when the file is
9705 closed (bug#8056).
9706
c965adc5
EZ
97072011-07-14 Eli Zaretskii <eliz@gnu.org>
9708
df9733bf
EZ
9709 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9710 bidi_cache_idx.
9711
0bb23927
EZ
9712 Support bidi reordering of display and overlay strings.
9713 * xdisp.c (compute_display_string_pos)
9714 (compute_display_string_end): Accept additional argument STRING.
9715 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9716 (reseat_to_string): Initialize bidi_it->string.s and
9717 bidi_it->string.schars.
9718 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9719 NULL (avoids a crash in bidi_paragraph_init).
9720 Initialize itb.string.lstring.
0bb23927
EZ
9721 (init_iterator): Call bidi_init_it only of a valid
9722 buffer position was specified. Initialize paragraph_embedding to
9723 L2R.
9724 (reseat_to_string): Initialize the bidi iterator.
9725 (display_string): If we need to ignore text properties of
9726 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9727 original value of -1 will not work with bidi.)
9728 (compute_display_string_pos): First arg is now struct
9729 `text_pos *'; all callers changed. Support display properties on
9730 Lisp strings.
9731 (compute_display_string_end): Support display properties on Lisp
9732 strings.
9733 (init_iterator, reseat_1, reseat_to_string): Initialize the
9734 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9735 when iterating on a string not from display properties).
640c8776
SM
9736 (compute_display_string_pos, compute_display_string_end):
9737 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9738 arrow keys.
9739 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9740 base_level_stop; instead, set base_level_stop to BEGV.
9741 Fixes crashes in vertical-motion.
0bb23927
EZ
9742 (next_element_from_buffer): Improve commentary for when
9743 the iterator is before prev_stop.
9744 (init_iterator): Initialize bidi_p from the default value of
9745 bidi-display-reordering, not from buffer-local value. Use the
9746 buffer-local value only if initializing for buffer iteration.
9747 (handle_invisible_prop): Support invisible properties on strings
9748 that are being bidi-reordered.
9749 (set_iterator_to_next): Support bidi reordering of C strings and
9750 Lisp strings.
9751 (next_element_from_string): Support bidi reordering of Lisp
9752 strings.
9753 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9754 (display_string): Support display of R2L glyph rows.
9755 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9756 (init_iterator): Don't initialize it->bidi_p for strings
9757 here.
9758 (reseat_to_string): Initialize it->bidi_p for strings here.
9759 (next_element_from_string, next_element_from_c_string)
9760 (next_element_from_buffer): Add xassert's for correspondence
9761 between IT's object being iterated and it->bidi_it.string
9762 structure.
9763 (face_before_or_after_it_pos): Support bidi iteration.
9764 (next_element_from_c_string): Handle the case of the first string
9765 character that is not the first one in the visual order.
9766 (get_visually_first_element): New function, refactored from common
9767 parts of next_element_from_buffer, next_element_from_string, and
9768 next_element_from_c_string.
9769 (tool_bar_lines_needed, redisplay_tool_bar)
9770 (display_menu_bar): Force left-to-right direction. Add a FIXME
9771 comment for making that be controlled by a user option.
9772 (push_it, pop_it): Save and restore the state of the
9773 bidi iterator. Save and restore the bidi_p flag.
9774 (pop_it): Iterate out of display property for string iteration as
9775 well.
9776 (iterate_out_of_display_property): Support iteration over strings.
9777 (handle_single_display_spec): Set up it->bidi_it for iteration
9778 over a display string, and call bidi_init_it.
9779 (handle_single_display_spec, next_overlay_string)
9780 (get_overlay_strings_1, push_display_prop): Set up the bidi
9781 iterator for displaying display or overlay strings.
9782 (forward_to_next_line_start): Don't use the shortcut if
9783 bidi-iterating.
9784 (back_to_previous_visible_line_start): If handle_display_prop
9785 pushed the iterator stack, restore the internal state of the bidi
9786 iterator by calling bidi_pop_it same number of times.
9787 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9788 and we are bidi-iterating, don't decrement the iterator position;
9789 instead, set the first_elt flag in the bidi iterator, to produce
9790 the same effect.
9791 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9792 (push_display_prop): xassert that we are iterating a buffer.
9793 (push_it, pop_it): Save and restore paragraph_embedding member.
9794 (handle_single_display_spec, next_overlay_string)
9795 (get_overlay_strings_1, reseat_1, reseat_to_string)
9796 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9797 correctly. Don't assume unibyte strings are not bidi-reordered.
9798 (compute_display_string_pos)
9799 (compute_display_string_end): Fix handling the case of C string.
9800 (push_it, pop_it): Save and restore from_disp_prop_p.
9801 (handle_single_display_spec, push_display_prop): Set the
9802 from_disp_prop_p flag.
9803 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9804 (pop_it): Call iterate_out_of_display_property only if we are
9805 popping after iteration over a string that came from a display
9806 property. Fix a typo in popping stretch info. Add an assertion
9807 for verifying that the iterator position is in sync with the bidi
9808 iterator.
9809 (handle_single_display_spec, get_overlay_strings_1)
9810 (push_display_prop): Fix initialization of paragraph direction for
9811 string when that of the parent object is not yet determined.
9812 (reseat_1): Call bidi_init_it to resync the bidi
9813 iterator with IT's position. (Bug#7616)
9814 (find_row_edges): If ROW->start.pos gives position
9815 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9816 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9817 Reset the from_disp_prop_p flag.
9818 (SAVE_IT, RESTORE_IT): New macros.
9819 (pos_visible_p, face_before_or_after_it_pos)
9820 (back_to_previous_visible_line_start)
9821 (move_it_in_display_line_to, move_it_in_display_line)
9822 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9823 (try_scrolling, redisplay_window, display_line): Use them when
9824 saving a temporary copy of the iterator and restoring it back.
9825 (back_to_previous_visible_line_start, reseat_1)
9826 (init_iterator): Empty the bidi cache "stack".
9827 (move_it_in_display_line_to): If iterator ended up at
9828 EOL, but we never saw any buffer positions smaller than
9829 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9830 motion in bidi-reordered lines.
9831 (move_it_in_display_line_to): Record prev_method and prev_pos
9832 immediately before the call to set_iterator_to_next. Fixes cursor
9833 motion in bidi-reordered lines with stretch glyphs and strings
9834 displayed in margins. (Bug#8133) (Bug#8867)
9835 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9836 TO_CHARPOS.
640c8776
SM
9837 (pos_visible_p): Support positions in bidi-reordered lines.
9838 Save and restore bidi cache.
0bb23927
EZ
9839
9840 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9841 (bidi_paragraph_info): Delete unused struct.
9842 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9843 (bidi_cache_start): New variable.
9844 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9845 to zero.
9846 (bidi_cache_fetch_state, bidi_cache_search)
9847 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9848 (bidi_cache_find, bidi_peek_at_next_level)
9849 (bidi_level_of_next_char, bidi_find_other_level_edge)
9850 (bidi_move_to_visually_next): Compare cache index with
9851 bidi_cache_start rather than with zero.
9852 (bidi_fetch_char): Accept new argument STRING; all callers
9853 changed. Support iteration over a string. Support strings with
9854 display properties. Support unibyte strings. Fix the type of
9855 `len' according to what STRING_CHAR_AND_LENGTH expects.
9856 (bidi_paragraph_init, bidi_resolve_explicit_1)
9857 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9858 (bidi_level_of_next_char, bidi_move_to_visually_next):
9859 Support iteration over a string.
0bb23927
EZ
9860 (bidi_set_sor_type, bidi_resolve_explicit_1)
9861 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9862 can now be zero (for strings); special values 0 and -1 were
9863 changed to -1 and -2, respectively.
9864 (bidi_char_at_pos): New function.
9865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9866 Call it instead of FETCH_MULTIBYTE_CHAR.
9867 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9868 initialized to valid values.
9869 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9870 values.
9871 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9872 the test for valid cached positions. Fix the logic for looking up
9873 the sentinel state in the cache. GCPRO the Lisp string we are
9874 iterating.
9875 (bidi_push_it, bidi_pop_it): New functions.
9876 (bidi_initialize): Initialize the bidi cache start stack pointer.
9877 (bidi_cache_ensure_space): New function, refactored from part of
9878 bidi_cache_iterator_state. Don't assume the required size is just
9879 one BIDI_CACHE_CHUNK away.
9880 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9881 (bidi_count_bytes, bidi_char_at_pos): New functions.
9882 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9883 always valid if bidi_cache_idx is valid.
9884 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9885 is valid if it's going to be used.
9886 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9887 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9888 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9889 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9890 (bidi_find_other_level_edge, bidi_cache_start_stack):
9891 All variables related to cache indices are now EMACS_INT.
c965adc5 9892
0bb23927
EZ
9893 * dispextern.h (struct bidi_string_data): New structure.
9894 (struct bidi_it): New member `string'. Make flag members be 1-bit
9895 fields, and put them last in the struct.
640c8776
SM
9896 (compute_display_string_pos, compute_display_string_end):
9897 Update prototypes.
0bb23927
EZ
9898 (bidi_push_it, bidi_pop_it): Add prototypes.
9899 (struct iterator_stack_entry): New members bidi_p,
9900 paragraph_embedding, and from_disp_prop_p.
9901 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9902 (bidi_shelve_cache, bidi_unshelve_cache):
9903 Declare prototypes.
0bb23927
EZ
9904
9905 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9906 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9907 and vector-like objects.
9908
9909 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9910 cache around display iteration.
9911
9912 * window.c (Fwindow_end, window_scroll_pixel_based)
9913 (displayed_window_lines, Frecenter): Save and restore the bidi
9914 cache around display iteration.
9915
3bbd2265
LMI
99162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9917
9918 * editfns.c (Fdelete_region): Clarify the use of the named
9919 parameters (bug#6788).
9920
adc47434
MR
99212011-07-14 Martin Rudalics <rudalics@gmx.at>
9922
9923 * indent.c (Fvertical_motion): Set and restore w->pointm when
9924 saving and restoring the window's buffer (Bug#9006).
9925
837c31f8
LMI
99262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9927
9928 * editfns.c (Fstring_to_char): Clarify just what is returned
9929 (bug#6576). Text by Eli Zaretskii.
9930
ac389d0c
JB
99312011-07-13 Juanma Barranquero <lekktu@gmail.com>
9932
9933 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9934
0be0ce47
EZ
99352011-07-13 Eli Zaretskii <eliz@gnu.org>
9936
9937 * buffer.c (mmap_find): Fix a typo.
9938
cd18e7e3
JB
99392011-07-13 Johan Bockgård <bojohan@gnu.org>
9940
9941 Fix execution of x selection hooks.
9942 * xselect.c (Qx_lost_selection_functions)
9943 (Qx_sent_selection_functions): New vars.
9944 (syms_of_xselect): DEFSYM them.
9945 (x_handle_selection_request): Pass Qx_sent_selection_functions
9946 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9947 (x_handle_selection_clear,x_clear_frame_selections):
9948 Pass Qx_lost_selection_functions rather than
9949 Vx_lost_selection_functions to Frun_hook_with_args.
9950
47ea7f44
PE
99512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9952
ac389d0c 9953 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9954 The old code sometimes used this field without initializing it.
9955
47ea7f44
PE
9956 * alloc.c (gc_sweep): Don't read past end of array.
9957 In theory, the old code could also have corrupted Emacs internals,
9958 though it'd be very unlikely.
9959
bc985c87
AS
99602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9961
9962 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9963 argument. (Bug#4026)
bc985c87 9964
0cf34688
LMI
99652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9966
b3dadd76
LMI
9967 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9968 key" (bug#4257).
9969
0cf34688
LMI
9970 * window.c (Fset_window_start): Doc fix (bug#4199).
9971 (Fset_window_hscroll): Ditto.
9972
270768cd
PE
99732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9974
077e3dda 9975 Fix minor new problems caught by GCC 4.6.1.
270768cd 9976 * term.c (init_tty): Remove unused local.
490011a6 9977 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9978 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9979 not used otherwise.
270768cd 9980
b1f58454
CY
99812011-07-12 Chong Yidong <cyd@stupidchicken.com>
9982
9983 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9984
22b9578d
LMI
99852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9986
6e70ab07
LMI
9987 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9988 are the mini-buffer and the echo area (bug#3320).
9989
22b9578d
LMI
9990 * term.c (init_tty): Remove support for supdup, c10 and perq
9991 terminals, which are no longer supported (bug#1482).
9992
8974cc9f
JB
99932011-07-10 Johan Bockgård <bojohan@gnu.org>
9994
9995 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9996
a560d974
JD
99972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9998
9999 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
10000 for non-popups (Bug#3642).
10001
1dae0f0a
AS
100022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
10003
268c2c36 10004 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 10005 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
10006 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
10007 * cm.c (losecursor): Likewise.
1dae0f0a
AS
10008 * data.c (fmod): Likewise.
10009 * dispnew.c (swap_glyphs_in_rows): Likewise.
10010 * emacs.c (memory_warning_signal): Likewise.
10011 * floatfns.c (float_error): Likewise.
10012 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
10013 (otf_open, font_otf_capability, generate_otf_features)
10014 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
10015 Likewise.
10016 * image.c (pbm_read_file): Likewise.
10017 * indent.c (string_display_width): Likewise.
10018 * intervals.c (check_for_interval, search_for_interval)
10019 (inc_interval_count, count_intervals, root_interval)
10020 (adjust_intervals_for_insertion, make_new_interval): Likewise.
10021 * lread.c (defalias): Likewise.
268c2c36 10022 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
10023 * regex.c (set_image_of_range_1, set_image_of_range)
10024 (regex_grow_registers): Likewise.
10025 * sysdep.c (strerror): Likewise.
10026 * termcap.c (valid_filename_p, tprint, main): Likewise.
10027 * tparam.c (main): Likewise.
10028 * unexhp9k800.c (run_time_remap, save_data_space)
10029 (update_file_ptrs, read_header, write_header, calculate_checksum)
10030 (copy_file, copy_rest, display_header): Likewise.
10031 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
10032 Likewise.
10033 * xdisp.c (check_it): Likewise.
10034 * xfaces.c (register_color, unregister_color, unregister_colors):
10035 Likewise.
10036 * xfns.c (print_fontset_result): Likewise.
10037 * xrdb.c (member, fatal, main): Likewise.
10038
99033785
PE
100392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
10040
10041 Fix minor problems found by static checking (Bug#9031).
10042 * chartab.c (char_table_set_range, map_sub_char_table):
10043 Remove unused locals.
10044 (uniprop_table): Now static.
10045 * composite.c (_work_char): Remove unused static var.
10046
9cb2ac56
JB
100472011-07-09 Juanma Barranquero <lekktu@gmail.com>
10048
10049 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
10050
f25661f0
JD
100512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
10052
10053 * gtkutil.c (qttip_cb): Remove code without function.
10054
8278c4fe
EZ
100552011-07-09 Eli Zaretskii <eliz@gnu.org>
10056
10057 * w32.c (pthread_sigmask): New stub.
10058
1692ae2d 100592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 10060
8a6ebd58 10061 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
10062 sigprocmask is portable only for single-threaded applications, and
10063 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
10064 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
10065 (LIBES): Use it.
10066 * callproc.c (Fcall_process):
10067 * process.c (create_process):
10068 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
10069 Use pthread_sigmask, not sigprocmask.
123403e4 10070
1b854618
JD
100712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10072
10073 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
10074 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
10075 wrong (Bug#8591).
10076
3fe4b549
JD
100772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10078
0ce7e563
JD
10079 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
10080 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
10081 (xg_hide_tooltip): Fix comment.
10082
3fe4b549
JD
10083 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
10084 in registerServicesMenuSendTypes.
10085 (validRequestorForSendType): Don't check ns_return_types.
10086
10087 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
10088 ns_return_type.
10089
5df75e47
JR
100902011-07-08 Jason Rumney <jasonr@gnu.org>
10091
22610910
JR
10092 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
10093 SH_SHOW for hidden windows (Bug#5482).
10094
5df75e47
JR
10095 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
10096 frame struct members of non-existent frames (Bug#6284).
10097
699c10bd
JD
100982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
10099
4393663b
JD
10100 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
10101 variable firstTime not needed on OSX >= 10.6.
10102 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
10103 >= 10.5. Use setKnobProportion, setDoubleValue.
10104
10105 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
10106 (MAC_OS_X_VERSION_10_5): Define if not defined.
10107 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
10108 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
10109 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
10110
10111 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 10112 cString and lossyCString on OSX >= 10.4.
4393663b 10113
58179cce 10114 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10115 sizeToFit on OSX >= 10.2.
10116
10117 * nsimage.m (allocInitFromFile): Don't use deprecated method
10118 bestRepresentationForDevice on OSX >= 10.6.
10119
10120 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10121 to avoid warning.
10122
10123 * emacs.c: Declare unexec_init_emacs_zone.
10124
a63e0781
JD
10125 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10126
699c10bd
JD
10127 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10128
10129 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10130 on svcsMenu (Bug#8842).
10131
10132 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10133 ns_return_types.
10134 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10135
10136 * nsterm.m (QUTF8_STRING): Declare.
10137 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10138 (validRequestorForSendType): Return type is (id).
10139 Change indexOfObjectIdenticalTo to indexOfObject.
10140 Check if we have local selection before returning self (Bug#8842).
10141 (writeSelectionToPasteboard): Put local selection into paste board
10142 if we have a local selection (Bug#8842).
10143 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10144
10145 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10146 (ns_get_local_selection): Declare.
10147
54e10184
LMI
101482011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10149
9888ff71
LMI
10150 * keymap.c (describe_map_tree): Don't insert a double newline at
10151 the end of the buffer (bug#1169) and return whether we inserted
10152 something.
10153
54e10184
LMI
10154 * callint.c (Fcall_interactively): Change "reading args" to
10155 "providing args" to try to clarify what it does (bug#1010).
10156
15fa4783
KH
101572011-07-07 Kenichi Handa <handa@m17n.org>
10158
10159 * composite.c (composition_compute_stop_pos): Ignore a static
10160 composition starting before CHARPOS (Bug#8915).
10161
10162 * xdisp.c (handle_composition_prop): Likewise.
10163
a8815b00
EZ
101642011-07-07 Eli Zaretskii <eliz@gnu.org>
10165
10166 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10167 (Bug#9015)
10168
ef7b981d 101692011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10170
10171 * character.h (unicode_category_t): New enum type.
10172
10173 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10174 (Qchar_code_property_table): New variable.
10175 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10176 (UNIPROP_COMPRESSED_FORM_P): New macros.
10177 (char_table_ascii): Uncompress the compressed values.
10178 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10179 Uncompress the compressed values.
ac389d0c 10180 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10181 (char_table_ref_and_range): Uncompress the compressed values.
10182 (sub_char_table_set): New arg is_uniprop. Callers changed.
10183 Uncompress the compressed values.
10184 (sub_char_table_set_range): Args changed. Callers changed.
10185 (char_table_set_range): Adjuted for the above change.
10186 (map_sub_char_table): Delete args default_val and parent. Add arg
10187 top. Give decoded values to a Lisp function.
640c8776 10188 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10189 values to a Lisp function. Gcpro more variables.
10190 (uniprop_table_uncompress)
10191 (uniprop_decode_value_run_length): New functions.
10192 (uniprop_decoder, uniprop_decoder_count): New variables.
10193 (uniprop_get_decoder, uniprop_encode_value_character)
10194 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10195 New functions.
10196 (uniprop_encoder, uniprop_encoder_count): New variables.
10197 (uniprop_get_encoder, uniprop_table)
10198 (Funicode_property_table_internal, Fget_unicode_property_internal)
10199 (Fput_unicode_property_internal): New functions.
10200 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10201 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10202 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10203 char-code-property-alist.
10204
640c8776 10205 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10206 Vunicode_category_table.
10207
640c8776 10208 * font.c (font_range): Adjust for the change of
c805dec0
KH
10209 Vunicode_category_table.
10210
76b397fb
DN
102112011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10212
10213 * m/iris4d.h: Remove file, move contents ...
10214 * s/irix6-5.h: ... here.
10215
22b4128e
PE
102162011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10217
10218 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10219 * alloc.c (mark_buffer):
10220 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10221 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10222 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10223 This isn't true in general, and it's particularly not true
10224 if Emacs is configured with --with-wide-int.
10225 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10226 New macros, used in the buffer.c change.
10227
869795d6
JD
102282011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10229
10230 * xsettings.c: Use both GConf and GSettings if both are available.
10231 (store_config_changed_event): Add comment.
10232 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10233 (store_tool_bar_style_changed): New functions.
5e617bc2 10234 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10235 (struct xsettings): Move font inside HAVE_XFT.
10236 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10237 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10238 Move inside HAVE_XFT.
640c8776 10239 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10240 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10241 also.
10242 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10243 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10244 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10245 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10246 (parse_settings): Move check for font inside HAVE_XFT.
10247 (read_settings, apply_xft_settings): Add comment.
10248 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10249 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10250 call store_font_name_changed.
10251 (xft_settings_event): Add comment.
10252 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10253 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10254 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10255 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10256 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10257 (xsettings_get_system_font, xsettings_get_system_normal_font):
10258 Add comment.
869795d6 10259
d8ed26bd
PE
102602011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10261
10262 Random fixes. E.g., (random) never returned negative values.
10263 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10264 subseconds part to the entropy, as that's a bit more random.
10265 Prefer signed to unsigned, since the signedness doesn't matter and
10266 in general we prefer signed. When given a limit, use a
10267 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10268 latter isn't right if USE_2_TAGS_FOR_INTS.
10269 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10270 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10271
cabf1cac
SM
102722011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10273
10274 * textprop.c (text_property_stickiness):
10275 Obey Vtext_property_default_nonsticky.
10276 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10277 * w32fns.c (syms_of_w32fns):
10278 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10279
6e9b2be9
PE
102802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10281
10282 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10283 This is more efficient than Ffile_directory_p and avoids a minor race.
10284
90186c68
LMI
102852011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10286
7c301272
LMI
10287 * buffer.c (Foverlay_put): Say what the return value is
10288 (bug#7835).
10289
c4f2d8d4
LMI
10290 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10291 is a directory before asking whether to use the file name
10292 (bug#7564).
ad637907
LMI
10293 (barf_or_query_if_file_exists): Make the "File is a directory"
10294 error be more correct.
c4f2d8d4 10295
90186c68
LMI
10296 * fns.c (Frequire): Remove the mention of the .gz files, since
10297 that's installation-specific, but keep the mention of
10298 `get-load-suffixes'.
10299
da64016e
PE
103002011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10301
10302 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10303 Report string overflow if the output is too long.
10304
7d47b580
JB
103052011-07-04 Juanma Barranquero <lekktu@gmail.com>
10306
a555cb87
JB
10307 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10308 (syms_of_gnutls): Remove duplicate DEFSYM for
10309 Qgnutls_bootprop_verify_hostname_error, an error for
10310 Qgnutls_bootprop_verify_error (which is no longer used).
10311
7d47b580
JB
10312 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10313 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10314 Also (re)move comments that are misplaced or no longer relevant.
10315
1e49bfab
LMI
103162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10317
10318 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10319
1485f4c0
CY
103202011-07-03 Chong Yidong <cyd@stupidchicken.com>
10321
10322 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10323 and background color parameters if they have been changed.
10324
a9ab721e
LMI
103252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10326
10327 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10328
cf7cff57
PE
103292011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10330
2e13213d
PE
10331 * xsettings.c (SYSTEM_FONT): Define only when used.
10332 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10333
cf7cff57
PE
10334 * keymap.c (access_keymap_1): Now static.
10335
7a8e04f7
CY
103362011-07-02 Chong Yidong <cyd@stupidchicken.com>
10337
10338 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10339 leave any prefix arg for the up event (Bug#1586).
10340
61352f62
LMI
103412011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10342
69bb1ef7
LMI
10343 * lread.c (syms_of_lread): Mention single symbols defined by
10344 `defvar' or `defconst' (bug#7154).
10345
61352f62 10346 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10347 (Frequire): Mention get-load-suffixes.
61352f62 10348
28545e04
MR
103492011-07-02 Martin Rudalics <rudalics@gmx.at>
10350
10351 * window.h (window): Remove clone_number slot.
10352 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10353 Remove.
10354 (make_parent_window, make_window, saved_window)
10355 (Fset_window_configuration, save_window_save): Don't deal with
10356 clone numbers.
10357 * buffer.c (Qclone_number): Remove declaration.
10358 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10359
3349e122
SM
103602011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10361
10362 Add multiple inheritance to keymaps.
10363 * keymap.c (Fmake_composed_keymap): New function.
10364 (Fset_keymap_parent): Simplify.
10365 (fix_submap_inheritance): Remove.
10366 (access_keymap_1): New function extracted from access_keymap to handle
10367 embedded parents and handle lists of maps.
10368 (access_keymap): Use it.
10369 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10370 (Fcopy_keymap): Handle embedded parents.
10371 (Fcommand_remapping, define_as_prefix): Simplify.
10372 (Fkey_binding): Simplify.
10373 (syms_of_keymap): Move minibuffer-local-completion-map,
10374 minibuffer-local-filename-completion-map,
10375 minibuffer-local-must-match-map, and
10376 minibuffer-local-filename-must-match-map to Elisp.
10377 (syms_of_keymap): Defsubr make-composed-keymap.
10378 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10379 (parse_menu_item): Trivial simplification.
10380
3279eb87
GM
103812011-07-01 Glenn Morris <rgm@gnu.org>
10382
10383 * Makefile.in (SETTINGS_LIBS): Fix typo.
10384
39cb9e56 103852011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10386
10387 * coding.c (Fencode_coding_string): Record the last coding system
10388 used, as the function doc string says (bug#8738).
10389
0949d2b6
JD
103902011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10391
10392 * xsettings.c (store_monospaced_changed): Take new font as arg and
10393 check for change against current_mono_font.
10394 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10395 (emacs_settings_constructor, emacs_settings_get_property)
10396 (emacs_settings_set_property, emacs_settings_class_init)
10397 (emacs_settings_init, gsettings_obj): Remove.
10398 (something_changedCB): New function for HAVE_GSETTINGS.
10399 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10400 with value as argument.
10401 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10402 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10403 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10404 "changed".
10405
10406 * xgselect.c: Add defined (HAVE_GSETTINGS).
10407 (xgselect_initialize): Ditto.
10408
10409 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10410 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10411 xg_select.
10412
bbc6b304
PE
104132011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10414
10415 * eval.c (struct backtrace): Simplify and port the data structure.
10416 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10417 signed bit field, as this assumption is not portable and it makes
10418 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10419 "char debug_on_exit : 1" as this is not portable either; instead,
10420 use the portable "unsigned int debug_on_exit : 1". Remove unused
10421 member evalargs. Remove obsolete comments about cc bombing out.
10422
9851bfc5
JD
104232011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10424
51bb811f 10425 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10426 Let HAVE_GSETTINGS override HAVE_GCONF.
10427 (store_monospaced_changed): New function.
10428 (EMACS_SETTINGS): A new type derived from GObject to handle
10429 GSettings notifications.
10430 (emacs_settings_constructor, emacs_settings_get_property)
10431 (emacs_settings_set_property, emacs_settings_class_init):
10432 New functions.
10433 (gsettings_client, gsettings_obj): New variables.
10434 (GSETTINGS_SCHEMA): New define.
10435 (something_changedCB): Call store_monospaced_changed.
10436 (init_gsettings): New function.
10437 (xsettings_initialize): Call init_gsettings.
10438 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10439 to NULL.
10440
640c8776 10441 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10442 GCONF_CFLAGS/LIBS.
10443
5386012d
MR
104442011-06-29 Martin Rudalics <rudalics@gmx.at>
10445
10446 * window.c (resize_root_window, grow_mini_window)
10447 (shrink_mini_window): Rename Qresize_root_window to
10448 Qwindow_resize_root_window and Qresize_root_window_vertically to
10449 Qwindow_resize_root_window_vertically.
10450
f13e0b08
PE
104512011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10452
10453 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10454
94515237
JB
104552011-06-27 Juanma Barranquero <lekktu@gmail.com>
10456
10457 * makefile.w32-in: Redesign dependencies so they reflect more
10458 clearly which files are directly included by each source file,
10459 and not through other includes.
10460
e43b6e43
MR
104612011-06-27 Martin Rudalics <rudalics@gmx.at>
10462
10463 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10464 (sort_overlays, overlay_strings): When an overlay's clone number
10465 matches the window's clone number process the overlay even if
10466 the overlay's window property doesn't match the current window.
10467
d68443dc
MR
10468 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10469 (Fwindow_hchild): Rename to Fwindow_left_child.
10470 (Fwindow_next): Rename to Fwindow_next_sibling.
10471 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10472 (resize_window_check): Rename to window_resize_check.
10473 (resize_window_apply): Rename to window_resize_apply.
10474 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10475 (Fdelete_other_windows_internal, resize_frame_windows)
10476 (Fsplit_window_internal, Fdelete_window_internal)
10477 (grow_mini_window, shrink_mini_window)
10478 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10479
c7e73be5
JD
104802011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10481
10482 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10483 (emacs_fixed_set_min_size): Remove.
10484 (emacs_fixed_new): Take frame as argument.
10485
10486 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10487 (_EmacsFixedPrivate): Remove minwidth/height.
10488 Add struct frame *f.
10489 (emacs_fixed_init): Initialize priv->f.
10490 (get_parent_class, emacs_fixed_set_min_size): Remove.
10491 (emacs_fixed_new): Set priv->f to argument.
10492 (emacs_fixed_get_preferred_width)
10493 (emacs_fixed_get_preferred_height): Use min_width/height from
10494 frames size_hint to set minimum and natural (Bug#8919).
10495 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10496 and use min_width/height from frames size_hint to set
10497 min_width/height (Bug#8919).
10498
10499 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10500 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10501 Fix indentation.
c7e73be5 10502
cf99dcf8
EZ
105032011-06-26 Eli Zaretskii <eliz@gnu.org>
10504
10505 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10506 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10507 called at ZV.
10508
029529ac
CY
105092011-06-26 Chong Yidong <cyd@stupidchicken.com>
10510
10511 * process.c (wait_reading_process_output): Bypass select if
10512 waiting for a cell while ignoring keyboard input, and input is
10513 pending. Suggested by Jan Djärv (Bug#8869).
10514
7a7ef429
PE
105152011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10516
10517 Use gnulib's dup2 module instead of rolling our own.
10518 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10519
11fdef7d 105202011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10521
10522 * dispnew.c (scrolling_window): Before scrolling, turn off a
10523 mouse-highlight in the window being scrolled.
10524
cd3520a4
JB
105252011-06-24 Juanma Barranquero <lekktu@gmail.com>
10526
10527 Move DEFSYM to lisp.h and use everywhere.
10528
10529 * character.h (DEFSYM): Move declaration...
10530 * lisp.h (DEFSYM): ...here.
10531
10532 * gnutls.c:
10533 * minibuf.c:
10534 * w32menu.c:
10535 * w32proc.c:
10536 * w32select.c: Don't include character.h.
10537
10538 * alloc.c (syms_of_alloc):
10539 * buffer.c (syms_of_buffer):
10540 * bytecode.c (syms_of_bytecode):
10541 * callint.c (syms_of_callint):
10542 * casefiddle.c (syms_of_casefiddle):
10543 * casetab.c (init_casetab_once):
10544 * category.c (init_category_once, syms_of_category):
10545 * ccl.c (syms_of_ccl):
10546 * cmds.c (syms_of_cmds):
10547 * composite.c (syms_of_composite):
10548 * dbusbind.c (syms_of_dbusbind):
10549 * dired.c (syms_of_dired):
10550 * dispnew.c (syms_of_display):
10551 * doc.c (syms_of_doc):
10552 * editfns.c (syms_of_editfns):
10553 * emacs.c (syms_of_emacs):
10554 * eval.c (syms_of_eval):
10555 * fileio.c (syms_of_fileio):
10556 * fns.c (syms_of_fns):
10557 * frame.c (syms_of_frame):
10558 * fringe.c (syms_of_fringe):
10559 * insdel.c (syms_of_insdel):
10560 * keymap.c (syms_of_keymap):
10561 * lread.c (init_obarray, syms_of_lread):
10562 * macros.c (syms_of_macros):
10563 * msdos.c (syms_of_msdos):
10564 * print.c (syms_of_print):
10565 * process.c (syms_of_process):
10566 * search.c (syms_of_search):
10567 * sound.c (syms_of_sound):
10568 * syntax.c (init_syntax_once, syms_of_syntax):
10569 * terminal.c (syms_of_terminal):
10570 * textprop.c (syms_of_textprop):
10571 * undo.c (syms_of_undo):
10572 * w32.c (globals_of_w32):
10573 * window.c (syms_of_window):
10574 * xdisp.c (syms_of_xdisp):
10575 * xfaces.c (syms_of_xfaces):
10576 * xfns.c (syms_of_xfns):
10577 * xmenu.c (syms_of_xmenu):
10578 * xsettings.c (syms_of_xsettings):
10579 * xterm.c (syms_of_xterm): Use DEFSYM.
10580
4228cf16
TZ
105812011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10582
cd3520a4 10583 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10584
7fcccf1e
PE
105852011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10586
7efb4e0e
PE
10587 Integer and buffer overflow fixes (Bug#8873).
10588
ff5844ad
PE
10589 * print.c (printchar, strout): Check for string overflow.
10590 (PRINTPREPARE, printchar, strout):
10591 Don't set size unless allocation succeeds.
10592
90532f02
PE
10593 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10594 for sizes. Check for string overflow more accurately.
10595 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10596
6d84508d
PE
10597 * macros.c: Integer and buffer overflow fixes.
10598 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10599 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10600 Use ptrdiff_t, not int, for sizes.
10601 Don't increment bufsize until after realloc succeeds.
10602 Check for size-calculation overflow.
10603 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10604
437b2cb4
PE
10605 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10606
8b9ac8b4
PE
10607 * lread.c: Integer overflow fixes.
10608 (read_integer): Radix is now EMACS_INT, not int,
10609 to improve quality of diagnostics for out-of-range radices.
10610 Calculate buffer size correctly for out-of-range radices.
10611 (read1): Check for integer overflow in radices, and in
10612 read-circle numbers.
82cb60d3
PE
10613 (read_escape): Avoid int overflow.
10614 (Fload, openp, read_buffer_size, read1)
10615 (substitute_object_recurse, read_vector, read_list, map_obarray):
10616 Use ptrdiff_t, not int, for sizes.
10617 (read1): Use EMACS_INT, not int, for sizes.
20270765 10618 Check for size overflow.
8b9ac8b4 10619
7fcccf1e
PE
10620 * image.c (cache_image): Check for size arithmetic overflow.
10621
bfbbd7e7
PE
10622 * lread.c: Integer overflow issues.
10623 (saved_doc_string_size, saved_doc_string_length)
10624 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10625 Now ptrdiff_t, not int.
10626 (read1): Don't assume doc string length fits in int. Check for
10627 out-of-range doc string lengths.
10628 (read_list): Don't assume file position fits in int.
39019e54 10629 (read_escape): Check for hex character overflow.
bfbbd7e7 10630
4e323265
LL
106312011-06-22 Leo Liu <sdl.web@gmail.com>
10632
10633 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10634 Move to minibuffer.el.
10635
85fece3e
PE
106362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10637
20b84ce9 10638 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10639 The following patches are for when GLYPH_DEBUG && !XASSERT.
10640 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10641 * dispnew.c (flush_stdout):
10642 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10643 Mark as externally visible.
10644 * dispnew.c (check_window_matrix_pointers): Now static.
10645 * dispnew.c (window_to_frame_vpos):
10646 * xfns.c (unwind_create_frame):
10647 * xterm.c (x_check_font): Remove unused local.
10648 * scroll.c (CHECK_BOUNDS):
10649 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10650 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10651 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10652 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10653 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10654 Now static.
10655 (debug_method_add): Use va_list and vsprintf rather than relying
10656 on undefined behavior with wrong number of arguments.
10657 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10658 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10659 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10660 since we're not interested in debugging glyphs with old libraries.
10661 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10662 GCC 4.6.0's static checking.
10663
0766b489
PE
106642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10665
31fd4b32
PE
10666 Integer overflow and signedness fixes (Bug#8873).
10667 A few related buffer overrun fixes, too.
10668
b79e8648
PE
10669 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10670
0766b489
PE
10671 * dispextern.h (struct face.stipple):
10672 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10673 (x_bitmap_mask, x_allocate_bitmap_record)
10674 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10675 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10676 (x_create_bitmap_from_xpm_data):
10677 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10678 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10679 (.bitmaps_last):
10680 * xfaces.c (load_pixmap):
10681 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10682 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10683 (.bitmaps_last, struct x_output.icon_bitmap):
10684 Use ptrdiff_t, not int, for bitmap indexes.
10685 (x_allocate_bitmap_record): Check for size overflow.
10686 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10687
b081724f
PE
10688 Use ptrdiff_t, not int, for overlay counts.
10689 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10690 * editfns.c (overlays_around, get_pos_property):
10691 * textprop.c (get_char_property_and_overlay):
10692 * xdisp.c (next_overlay_change, note_mouse_highlight):
10693 * xfaces.c (face_at_buffer_position):
21514da7
PE
10694 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10695 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10696 (Fnext_overlay_change, Fprevious_overlay_change)
10697 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10698 Use ptrdiff_t, not int, for sizes.
21514da7 10699 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10700
3de73e5e
PE
10701 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10702
2606c57b
PE
10703 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10704 (x_session_initialize): Do not assume string length fits in int.
10705
aaafe47a
PE
10706 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10707 This is unlikely, but can occur if DPI is outlandish.
10708
2674ddc8 10709 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10710 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10711
28154962
PE
10712 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10713 * xrdb.c (magic_file_p, search_magic_path):
10714 Omit last arg SUFFIX; it was always 0. All callers changed.
10715 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10716
7de51af5
PE
10717 * xfont.c (xfont_match): Avoid need for strlen.
10718
25ed6cc3
PE
10719 * xfns.c: Don't assume strlen fits in int.
10720 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10721
4eab31dd
PE
10722 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10723 not unsigned long, as we prefer signed integers. All callers changed.
10724 Detect integer overflow in repeat count.
10725 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10726 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10727
171e2a58
PE
10728 * termcap.c: Don't assume sizes fit in int and never overflow.
10729 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10730 (gobble_line): Check for size-calculation overflow.
10731
ad39faca 10732 * minibuf.c (Fread_buffer):
6e5bb2dc 10733 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10734 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10735 Don't assume string length fits in int.
10736
52c61c22 10737 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10738 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10739
b5b8c9e5
PE
10740 * font.c: Don't assume string length fits in int.
10741 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10742 Use ptrdiff_t, not int.
ccd6111c
PE
10743 (font_intern_prop): Don't assume string length fits in int.
10744 Don't assume integer property fits in fixnum.
10745 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10746
882f0d81 10747 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10748 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10749 Reformulate so as not to need the command string.
10750 Invoke gzip -cd rather than gunzip, as it's more portable.
10751 (lock_info_type, lock_file_1, lock_file):
10752 Don't assume pid_t and time_t fit in unsigned long.
10753 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10754 (current_lock_owner): Prefer signed type for sizes.
10755 Use memcpy, not strncpy, where memcpy is what is really wanted.
10756 Don't assume (via atoi) that time_t and pid_t fit in int.
10757 Check for time_t and/or pid_t out of range, e.g., via a network share.
10758 Don't alloca where an auto var works fine.
10759
93f4cf88
PE
10760 * fileio.c: Fix some integer overflow issues.
10761 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10762 Don't assume string length fits in int.
10763 (directory_file_name): Don't assume string length fits in long.
10764 (make_temp_name): Don't assume pid fits in int, or that its print
10765 length is less than 20.
10766
f3e92b69
PE
10767 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10768
1bfdaf10
PE
10769 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10770
35016e9a
PE
10771 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10772
3d1e65a1
PE
10773 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10774 We prefer signed integers, even for size calculations.
10775
0b963a93
PE
10776 * emacs.c: Don't assume string length fits in 'int'.
10777 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10778 (main): Don't invoke strlen when not needed.
10779
573f4b54
PE
10780 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10781 (XD_DEBUG_MESSAGE): Don't waste a byte.
10782
989f33ba
PE
10783 * callproc.c (getenv_internal_1, getenv_internal)
10784 (Fgetenv_internal):
965d34eb
PE
10785 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10786
e4d29b33
PE
10787 * lread.c (invalid_syntax): Omit length argument.
10788 All uses changed. This doesn't fix a bug, but it simplifies the
10789 code away from its former Hollerith-constant appearance, and it's
10790 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10791 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10792
eb49b136
PE
10793 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10794 This didn't break anything, but it didn't help either.
10795 It's confusing to put a bogus integer in a place where the actual
10796 value does not matter.
9f62aeb1 10797 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10798 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10799
15375a22
PE
10800 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10801 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10802 implementation.
b61cc01c
PE
10803 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10804 We prefer signed types, and the value cannot exceed the EMACS_INT
10805 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10806 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10807 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10808 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10809
53b2623d
PE
10810 * indent.c (sane_tab_width): New function.
10811 (current_column, scan_for_column, Findent_to, position_indentation)
10812 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10813 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10814
51cab52b 10815 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10816
f2ed8a70
PE
10817 * lisp.h (lint_assume): New macro.
10818 * composite.c (composition_gstring_put_cache):
10819 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10820
abe80cc6
PE
10821 * editfns.c, insdel.c:
10822 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10823
b02c740e
PE
10824 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10825
ebc96716
PE
10826 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10827
b4e50fa0 10828 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10829 Use much-faster test for byte-length change.
311d5d7c 10830 Don't assume string byte-length fits in 'int'.
a4cf38e4 10831 Check that character arg fits in 'int'.
85461888 10832 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10833
c0c1ee9f
PE
10834 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10835
a498d7f4
PE
10836 * fns.c (concat): Catch string overflow earlier.
10837 Do not rely on integer wraparound.
10838
51cab52b
PE
10839 * dispextern.h (struct it.overlay_strings_charpos)
10840 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10841 * xdisp.c (forward_to_next_line_start)
10842 (back_to_previous_visible_line_start)
10843 (reseat_at_next_visible_line_start, next_element_from_buffer):
10844 Don't arbitrarily truncate the value of 'selective' to int.
10845
76031fad
PE
10846 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10847
5eb55db9
PE
10848 * composite.c: Don't truncate sizes to 'int'.
10849 (composition_gstring_p, composition_reseat_it)
10850 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10851 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10852 not EMACS_UINT, for indexes.
5eb55db9 10853
0703a717
PE
10854 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10855
d6202519
PE
10856 * buffer.c: Include <verify.h>.
10857 (struct sortvec.priority, struct sortstr.priority):
8961a454 10858 Now EMACS_INT, not int.
c20998a7 10859 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10860 (struct sortstr.size, record_overlay_string)
10861 (struct sortstrlist.size, struct sortlist.used):
10862 Don't truncate size to int.
10863 (record_overlay_string): Check for size-calculation overflow.
d6202519 10864 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10865
d5a19415
JM
108662011-06-22 Jim Meyering <meyering@redhat.com>
10867
029529ac 10868 Don't leak an XBM-image-sized buffer
d5a19415
JM
10869 * image.c (xbm_load): Free the image buffer after using it.
10870
a9041e6c
PE
108712011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10872
10873 Port to Sun C.
10874 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10875 that Sun C diagnosed.
10876 * fns.c (secure_hash): Fix pointer signedness issue.
10877 * intervals.c (static_offset_intervals): New function.
10878 (offset_intervals): Use it.
10879
7f3f739f
LL
108802011-06-21 Leo Liu <sdl.web@gmail.com>
10881
10882 * deps.mk (fns.o):
10883 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10884 sha512.h.
10885
10886 * fns.c (secure_hash): Rename from crypto_hash_function and change
10887 the first arg to accept symbols.
5b66d427 10888 (Fsecure_hash): New primitive.
7f3f739f
LL
10889 (syms_of_fns): New symbols.
10890
76147d94
DD
108912011-06-20 Deniz Dogan <deniz@dogan.se>
10892
10893 * process.c (Fset_process_buffer): Clarify return value in
10894 docstring.
10895
7d7d0045
CY
108962011-06-18 Chong Yidong <cyd@stupidchicken.com>
10897
10898 * dispnew.c (add_window_display_history): Use BVAR.
10899
10900 * xdisp.c (debug_method_add): Use BVAR.
10901 (check_window_end, dump_glyph_matrix, dump_glyph)
10902 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10903
10904 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10905 Likewise.
10906
10907 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10908 check till after the cache is created in init_frame_faces.
10909
ff2bc410
SM
109102011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10911
10912 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10913
28177add
PE
109142011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10915
dd3482fe
PE
10916 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10917 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10918 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10919
393d71f3 10920 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10921 * fileio.c (Finsert_file_contents):
10922 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10923 Remove the old (too-loose) buffer overflow checks.
10924 They weren't needed, since make_gap checks for buffer overflow.
10925 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10926 The old code merely checked for Emacs fixnum overflow, and relied
10927 on undefined (wraparound) behavior. The new code avoids undefined
10928 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10929
2e6813b0 10930 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10931 Tune. Don't use wider integers than needed. Don't use alloca.
10932 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10933
599a9e4f
PE
10934 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10935
99561444
PE
10936 * insdel.c, lisp.h (buffer_overflow): New function.
10937 (insert_from_buffer_1, replace_range, replace_range_2):
10938 * insdel.c (make_gap_larger):
10939 * editfns.c (Finsert_char):
10940 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10941
28177add
PE
10942 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10943
e69dafad
PE
109442011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10945
4baa020d 10946 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10947
b1c46f02
PE
10948 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10949 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10950
e69dafad
PE
10951 * fileio.c: Don't assume EMACS_INT fits in off_t.
10952 (emacs_lseek): New static function.
10953 (Finsert_file_contents, Fwrite_region): Use it.
10954 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10955
566684ea
PE
10956 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10957
e6966cd6
PE
10958 * fns.c: Don't overflow int when computing a list length.
10959 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10960 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10961 truncation on 64-bit hosts. Check for QUIT every
10962 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10963 faster and is responsive enough.
10964 (Flength): Report an error instead of overflowing an integer.
10965 (Fsafe_length): Return a float if the value is not representable
10966 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10967 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10968 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10969
dd0b0efb
PE
10970 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10971 (header_size, word_size): New constants.
10972 (allocate_vectorlike): Don't check size overflow here.
10973 (allocate_vector): Check it here instead, since this is the only
10974 caller of allocate_vectorlike that could cause overflow.
10975 Check that the new vector's length is representable as a fixnum.
10976
86fe5cfe
PE
10977 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10978 The previous code was bogus. For example, next_almost_prime (32)
10979 returned 39, which is undesirable as it is a multiple of 3; and
10980 next_almost_prime (24) returned 25, which is a multiple of 5 so
10981 why was the code bothering to check for multiples of 7?
10982
80e88859
PE
10983 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10984
4a2f0ad6
PE
10985 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10986
f66c7cf8
PE
10987 Variadic C functions now count arguments with ptrdiff_t.
10988 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10989 Back then I didn't know that the Emacs coding style prefers signed int.
10990 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10991 were being counted with int, which may truncate counts on 64-bit
10992 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10993 * lisp.h (struct Lisp_Subr.function.aMANY)
10994 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10995 Arg counts are now ptrdiff_t, not size_t.
10996 All variadic functions and their callers changed accordingly.
10997 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10998 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10999 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
11000 * callint.c (Fcall_interactively): Check arg count for overflow,
11001 to avoid potential buffer overrun. Use signed char, not 'int',
11002 for 'varies' array, so that we needn't bother to check its size
11003 calculation for overflow.
11004 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
11005 * eval.c (apply_lambda):
11006 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
11007 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
11008 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
11009
a1759b76
PE
11010 * callint.c (Fcall_interactively): Don't use index var as event count.
11011
d96be9fc
PE
11012 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
11013 * mem-limits.h (SIZE): Remove; no longer used.
11014
a690a978 11015 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 11016
578c21e6
PE
11017 Remove unnecessary casts.
11018 * xterm.c (x_term_init):
11019 * xfns.c (x_set_border_pixel):
11020 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
11021 These aren't needed now that we assume ANSI C.
11022
96f53c6c
PE
11023 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
11024 It's more likely to cause problems (due to unsigned overflow)
11025 than to cure them.
11026
83c77d31
PE
11027 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
11028
ee2079f1
PE
11029 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
11030
6da65536
PE
11031 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
11032
7147c4a4
PE
11033 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
11034
193e32d9
PE
11035 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
11036
e5533da6
PE
11037 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
11038
9910e595
PE
11039 GLYPH_CODE_FACE returns EMACS_INT, not int.
11040 * dispextern.h (merge_faces):
11041 * xfaces.c (merge_faces):
01103c44
PE
11042 * xdisp.c (get_next_display_element, next_element_from_display_vector):
11043 Don't assume EMACS_INT fits in int.
9910e595 11044
2638320e
PE
11045 * character.h (CHAR_VALID_P): Remove unused parameter.
11046 * fontset.c, lisp.h, xdisp.c: All uses changed.
11047
045eb8d9
PE
11048 * editfns.c (Ftranslate_region_internal): Omit redundant test.
11049
c1f134b5
PE
11050 * fns.c (concat): Minor tuning based on overflow analysis.
11051 This doesn't fix any bugs. Use int to hold character, instead
11052 of constantly refetching from Emacs object. Use XFASTINT, not
11053 XINT, for value known to be a character. Don't bother comparing
11054 a single byte to 0400, as it's always less.
11055
395fcb93 11056 * floatfns.c (Fexpt):
327eeec8
PE
11057 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
11058
abbd3d23
PE
11059 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
11060 for characters.
11061
684a03ef
PE
11062 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
11063
0fed43f3
PE
11064 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
11065 Without this fix, on a 64-bit host (aset S 0 4294967386) would
11066 incorrectly succeed when S was a string, because 4294967386 was
11067 truncated before it was used.
11068
8fd02eb7
PE
11069 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
11070 Otherwise, an out-of-range integer could cause undefined behavior
11071 on a 64-bit host.
11072
f8c86b69
PE
11073 * composite.c: Use int, not EMACS_INT, for characters.
11074 (fill_gstring_body, composition_compute_stop_pos): Use int, not
11075 EMACS_INT, for values that are known to be in character range.
11076 This doesn't fix any bugs but is the usual style inside Emacs and
11077 may generate better code on 32-bit machines.
11078
34206dd2
PE
11079 Make sure a 64-bit char is never passed to ENCODE_CHAR.
11080 This is for reasons similar to the recent CHAR_STRING fix.
11081 * charset.c (Fencode_char): Check that character arg is actually
11082 a character. Pass an int to ENCODE_CHAR.
11083 * charset.h (ENCODE_CHAR): Verify that the character argument is no
11084 wider than 'int', as a compile-time check to prevent future regressions
11085 in this area.
11086
c5958d4c 11087 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
11088
11089 Make sure a 64-bit char is never passed to CHAR_STRING.
11090 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
11091 by silently ignoring the top 32 bits, allowing some values
11092 that were far too large to be valid characters.
11093 * character.h: Include <verify.h>.
11094 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
11095 arguments are no wider than unsigned, as a compile-time check
11096 to prevent future regressions in this area.
11097 * data.c (Faset):
01103c44 11098 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
11099 (Fsubst_char_in_region):
11100 * fns.c (concat):
11101 * xdisp.c (decode_mode_spec_coding):
11102 Adjust to CHAR_STRING's new requirement.
11103 * editfns.c (Finsert_char, Fsubst_char_in_region):
11104 * fns.c (concat): Check that character args are actually
11105 characters. Without this test, these functions did the wrong
11106 thing with wildly out-of-range values on 64-bit hosts.
11107
d37ca623
PE
11108 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
11109 These casts should not be needed on 32-bit hosts, either.
11110 * keyboard.c (read_char):
11111 * lread.c (Fload): Remove casts to unsigned.
11112
ea204efb
PE
11113 * lisp.h (UNSIGNED_CMP): New macro.
11114 This fixes comparison bugs on 64-bit hosts.
11115 (ASCII_CHAR_P): Use it.
11116 * casefiddle.c (casify_object):
01103c44 11117 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11118 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11119 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11120 * dispextern.h (FACE_FROM_ID):
11121 * keyboard.c (read_char): Use UNSIGNED_CMP.
11122
41cb286c
PE
11123 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11124 not to EMACS_INT, to avoid GCC warning.
11125
4a1b9832
PE
11126 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11127
55daad71
PE
11128 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11129 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11130 isn't needed on 32-bit machines.
8f95c75c 11131
01103c44
PE
11132 * buffer.c (Fgenerate_new_buffer_name):
11133 Use EMACS_INT for count, not int.
0ceccced 11134 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11135
11136 * data.c (Qcompiled_function): Now static.
11137
c6f072e7
PE
11138 * window.c (window_body_lines): Now static.
11139
20ce5912
PE
11140 * image.c (gif_load): Rename local to avoid shadowing.
11141
9c4c5f81
PE
11142 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11143 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11144 * alloc.c (make_save_value): Integer argument is now of type
11145 ptrdiff_t, not int.
11146 (mark_object): Use ptrdiff_t, not int.
11147 * lisp.h (pD): New macro.
11148 * print.c (print_object): Use it.
11149
c0c5c8ae
PE
11150 * alloc.c: Use EMACS_INT, not int, to count objects.
11151 (total_conses, total_markers, total_symbols, total_vector_size)
11152 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11153 (total_free_floats, total_floats, total_free_intervals)
11154 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11155 Now EMACS_INT, not int. All uses changed.
11156 (Fgarbage_collect): Compute overall total using a double, so that
11157 integer overflow is less likely to be a problem. Check for overflow
11158 when converting back to an integer.
5a25e253
PE
11159 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11160 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11161 These were 'int' variables that could overflow on 64-bit hosts;
11162 they were never used, so remove them instead of repairing them.
211a0b2a 11163 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11164 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11165 Previously, this ceilinged at INT_MAX, but that doesn't work on
11166 64-bit machines.
e46bb31a 11167 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11168
c78baabf 11169 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11170 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11171 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11172 when a (possibly-narrower) signed value would do just as well.
11173 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11174
c9d624c6
PE
11175 * alloc.c: Catch some string size overflows that we were missing.
11176 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11177 for convenience in STRING_BYTES_MAX.
11178 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11179 The definition here is exact; the one in lisp.h was approximate.
11180 (allocate_string_data): Check for string overflow. This catches
11181 some instances we weren't catching before. Also, it catches
11182 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11183 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11184 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11185
c9d624c6
PE
11186 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11187 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11188 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11189
353032ce
PE
11190 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11191
2bccce07
PE
11192 * alloc.c (Fmake_string): Check for out-of-range init.
11193
0ac30604
SM
111942011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11195
11196 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11197
c195f2de
JD
111982011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11199
11200 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11201 xg_get_default_scrollbar_width.
11202
11203 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11204 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11205 (style_changed_cb): Call update_theme_scrollbar_width and call
11206 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11207 all frames (Bug#8505).
11208 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11209 Call gtk_window_set_resizable if HAVE_GTK3.
11210 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11211 and height if HAVE_GTK3 (Bug#8505).
11212 (scroll_bar_width_for_theme): New variable.
11213 (update_theme_scrollbar_width): New function.
11214 (xg_get_default_scrollbar_width): Move code to
11215 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11216 (xg_initialize): Call update_theme_scrollbar_width.
11217
11218 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11219
11220 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11221
e10ac9f1
MR
112222011-06-12 Martin Rudalics <rudalics@gmx.at>
11223
11224 * frame.c (make_frame): Call other_buffer_safely instead of
11225 other_buffer.
11226
11227 * window.c (temp_output_buffer_show): Call display_buffer with
11228 second argument Vtemp_buffer_show_specifiers and reset latter
11229 immediately after the call.
11230 (Vtemp_buffer_show_specifiers): New variable.
11231 (auto_window_vscroll_p, next_screen_context_lines)
11232 (Vscroll_preserve_screen_position): Remove leading asterisks from
11233 doc-strings.
11234
2d3c217e 112352011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11236
7b7f97e8 11237 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11238 * buffer.c (Qclone_number): Remove for now, as it's unused.
11239 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11240 (record_buffer): Remove unused local.
11241 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11242 (set_frame_buffer_list): Remove; unused.
11243 * frame.h (other_visible_frames): Remove decl.
11244 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11245 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11246 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11247 if HAVE_GPM.
11248 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11249 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11250 Define only if HAVE_GPM.
11251 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11252 (update_hints_inhibit): Remove; never set. All uses removed.
11253 * widgetprv.h (emacsFrameClassRec): Remove decl.
11254 * window.c (delete_deletable_window): Now returns void, since it
11255 wasn't returning anything.
11256 (compare_window_configurations): Remove unused locals.
11257 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11258 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11259 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11260 the same widths as pointers. This follows up on the 2011-05-06 patch.
11261 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11262 * xterm.h: Likewise.
11263 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11264
1384b89e
JB
112652011-06-12 Juanma Barranquero <lekktu@gmail.com>
11266
11267 * makefile.w32-in: Update dependencies.
11268 (LISP_H): Add lib/intprops.h.
11269
1100a63c
CY
112702011-06-11 Chong Yidong <cyd@stupidchicken.com>
11271
11272 * image.c (gif_load): Add animation frame delay to the metadata.
11273 (syms_of_image): Use DEFSYM. New symbol `delay'.
11274
6198ccd0
MR
112752011-06-11 Martin Rudalics <rudalics@gmx.at>
11276
11277 * window.c (delete_deletable_window): Re-add.
11278 (Fset_window_configuration): Rewrite to handle dead buffers and
11279 consequently deletable windows.
11280 (window_tree, Fwindow_tree): Remove. Supply functionality in
11281 window.el.
11282 (compare_window_configurations): Simplify code.
11283
b6e3633c
AS
112842011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11285
1ab0dee5
AS
11286 * image.c (imagemagick_load_image): Fix type mismatch.
11287 (Fimagemagick_types): Likewise.
11288
b6e3633c
AS
11289 * window.h (replace_buffer_in_windows): Declare.
11290
9397e56f
MR
112912011-06-11 Martin Rudalics <rudalics@gmx.at>
11292
11293 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11294 Qclone_number. Remove external declaration of Qdelete_window.
11295 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11296 code.
640c8776
SM
11297 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11298 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11299 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11300 buffer list implementation.
11301 (other_buffer_safely): New function.
11302 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11303 calls to replace_buffer_in_windows and
11304 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11305 if allowed.
11306 (record_buffer): Inhibit quitting and rewrite using quittable
11307 functions. Run Qbuffer_list_update_hook if allowed.
11308 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11309 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11310 Move switch-to-buffer to window.el.
9397e56f
MR
11311 (bury-buffer): Move to window.el.
11312 (Vbuffer_list_update_hook): New variable.
11313
11314 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11315 section.
11316
11317 * window.h (resize_frame_windows): Move up in code.
11318 (Fwindow_frame): Remove EXFUN.
11319 (replace_buffer_in_all_windows): Remove prototype.
11320 (replace_buffer_in_windows_safely): Add prototype.
11321
11322 * window.c: Declare Qdelete_window static again. Move down
11323 declaration of select_count.
11324 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11325 (Fother_window): Move to window.el.
11326 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11327 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11328 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11329 window.el.
11330 (replace_buffer_in_windows): Implement by calling
11331 Qreplace_buffer_in_windows.
11332 (replace_buffer_in_all_windows): Remove with some functionality
11333 moved into replace_buffer_in_windows_safely.
11334 (replace_buffer_in_windows_safely): New function.
11335 (select_window_norecord, select_frame_norecord): Move in front
11336 of run_window_configuration_change_hook. Remove now obsolete
11337 declarations.
640c8776
SM
11338 (Fset_window_buffer): Rewrite doc-string.
11339 Call Qrecord_window_buffer.
9397e56f
MR
11340 (keys_of_window): Move binding for other-window to window.el.
11341
b50691aa
CY
113422011-06-11 Chong Yidong <cyd@stupidchicken.com>
11343
11344 * dispextern.h (struct image): Replace data member, whose int_val
11345 and ptr_val fields were not used by anything, with a single
11346 lisp_val object.
11347
11348 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11349 (gif_clear_image, gif_load, imagemagick_load_image)
11350 (gs_clear_image, gs_load): Callers changed.
11351
3f754b86
PE
113522011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11353
cca69397
PE
11354 * buffer.h: Include <time.h>, for time_t.
11355 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11356
109e28d0
PE
11357 Fix minor problems found by static checking.
11358
60737f02
PE
11359 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11360
4b66faf3
PE
11361 Make identifiers static if they are not used in other modules.
11362 * data.c (Qcompiled_function, Qframe, Qvector):
11363 * image.c (QimageMagick, Qsvg):
11364 * minibuf.c (Qmetadata):
11365 * window.c (resize_window_check, resize_root_window): Now static.
11366 * window.h (resize_window_check, resize_root_window): Remove decls.
11367
109e28d0
PE
11368 * window.c (window_deletion_count, delete_deletable_window):
11369 Remove; unused.
46a4ce9e
PE
11370 (window_body_lines): Now static.
11371 (Fdelete_other_windows_internal): Mark vars as initialized.
11372 Make sure 'resize_failed' is initialized.
11373 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11374 (resize_window_apply): Remove unused local.
11375 * window.h (delete_deletable_window): Remove decl.
11376
109e28d0 11377 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11378 (imagemagick_load_image): Fix pointer signedness problem by changing
11379 last arg from unsigned char * to char *. All uses changed.
11380 Also, fix a local for similar reasons.
11381 Remove unused locals. Remove locals to avoid shadowing.
11382 (fn_rsvg_handle_free): Remove; unused.
11383 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11384 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11385
3f754b86
PE
11386 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11387
2547adb1
CY
113882011-06-10 Chong Yidong <cyd@stupidchicken.com>
11389
11390 * image.c (gif_load): Fix omitted cast error introduced by
11391 2011-06-06 change.
11392
2c8e37d4
MR
113932011-06-10 Martin Rudalics <rudalics@gmx.at>
11394
11395 * window.h (resize_proportionally, orig_total_lines)
11396 (orig_top_line): Remove from window structure.
11397 (set_window_height, set_window_width, change_window_heights)
11398 (Fdelete_window): Remove prototypes.
11399 (resize_frame_windows): Remove duplicate declaration.
11400
440a42e3
EZ
114012011-06-10 Eli Zaretskii <eliz@gnu.org>
11402
11403 * window.h (resize_frame_windows, resize_window_check)
11404 (delete_deletable_window, resize_root_window)
11405 (resize_frame_windows): Declare prototypes.
11406
11407 * window.c (resize_window_apply): Make definition be "static" to
11408 match the prototype.
11409
562dd5e9
MR
114102011-06-10 Martin Rudalics <rudalics@gmx.at>
11411
11412 * window.c: Remove declarations of Qwindow_size_fixed,
11413 window_min_size_1, window_min_size_2, window_min_size,
11414 size_window, window_fixed_size_p, enlarge_window, delete_window.
11415 Remove static from declaration of Qdelete_window, it's
11416 temporarily needed by Fbury_buffer.
11417 (replace_window): Don't assign orig_top_line and
11418 orig_total_lines.
11419 (Fdelete_window, delete_window): Remove. Window deletion is
11420 handled by window.el.
640c8776
SM
11421 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11422 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11423 (Fdelete_other_windows): Remove. Deleting other windows is
11424 handled by window.el.
11425 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11426 handled in window.el.
11427 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11428 Window minimum sizes are handled in window.el.
11429 (shrink_windows, size_window, set_window_height)
11430 (set_window_width, change_window_heights, window_height)
11431 (window_width, CURBEG, CURSIZE, enlarge_window)
11432 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11433 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11434 handled in window.el.
11435 (make_dummy_parent): Rename to make_parent_window and give it a
11436 second argument horflag.
11437 (make_window): Don't set resize_proportionally any more.
11438 (Fsplit_window): Remove. Windows are split in window.el.
11439 (save_restore_action, save_restore_orig_size)
11440 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11441 Resize mini windows in window.el.
11442 (grow_mini_window, shrink_mini_window): Implement by calling
11443 Qresize_root_window_vertically, resize_window_check and
11444 resize_window_apply.
640c8776
SM
11445 (saved_window, Fset_window_configuration, save_window_save):
11446 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11447 resize_proportionally.
11448 (window_min_height, window_min_width): Move to window.el.
11449 (keys_of_window): Move bindings for delete-other-windows,
11450 split-window, delete-window and enlarge-window to window.el.
11451
11452 * buffer.c: Temporarily extern Qdelete_window.
11453 (Fbury_buffer): Temporarily call Qdelete_window instead of
11454 Fdelete_window (Fbury_buffer will move to window.el soon).
11455
11456 * frame.c (set_menu_bar_lines_1): Remove code handling
11457 orig_top_line and orig_total_lines.
11458
11459 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11460 set_window_height but set heights directly.
11461 (change_frame_size_1): Use resize_frame_windows.
11462
11463 * xdisp.c (init_xdisp): Don't use set_window_height but set
11464 heights directly.
11465
640c8776
SM
11466 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11467 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11468 run_window_configuration_change_hook.
11469
11470 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11471 instead of change_window_heights and run
11472 run_window_configuration_change_hook.
11473
1a13852e
MR
114742011-06-09 Martin Rudalics <rudalics@gmx.at>
11475
11476 * window.c (replace_window): Rename second argument REPLACEMENT to
11477 NEW. New third argument SETFLAG. Rewrite.
11478 (delete_window, make_dummy_parent): Call replace_window with
11479 third argument 1.
11480 (window_list_1): Move down in code.
11481 (run_window_configuration_change_hook): Move set_buffer part
11482 before select_frame_norecord part in order to unwind correctly.
11483 Rename count1 to count.
11484 (recombine_windows, delete_deletable_window, resize_root_window)
11485 (Fdelete_other_windows_internal)
11486 (Frun_window_configuration_change_hook, make_parent_window)
11487 (resize_window_check, resize_window_apply, Fresize_window_apply)
11488 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11489 (Fdelete_window_internal, Fresize_mini_window_internal):
11490 New functions.
1a13852e
MR
11491 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11492
f3d1777e
MR
114932011-06-08 Martin Rudalics <rudalics@gmx.at>
11494
496e208e
MR
11495 * window.h (window): Add some new members to window structure -
11496 normal_lines, normal_cols, new_total, new_normal, clone_number,
11497 splits, nest, prev_buffers, next_buffers.
11498 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11499 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11500
f3d1777e
MR
11501 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11502 Remove.
496e208e
MR
11503 (make_dummy_parent): Set new members of windows structure.
11504 (make_window): Move down in code. Handle new members of window
11505 structure.
11506 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11507 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11508 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11509 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11510 (Fset_window_next_buffers, Fset_window_clone_number):
11511 New functions.
496e208e
MR
11512 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11513 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11514 Doc-string fixes.
11515 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11516 Argument WINDOW can be now internal window too.
11517 (Fwindow_use_time): Move up in code.
11518 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11519 Rewrite doc-string.
11520 (Fset_window_configuration, saved_window)
11521 (Fcurrent_window_configuration, save_window_save): Handle new
11522 members of window structure.
b9e809c2
MR
11523 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11524 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11525 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11526 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11527 Qget_mru_window, Qresize_root_window,
11528 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11529 Qauto_buffer_name; staticpro them.
f3d1777e 11530
abde8f8c
MR
115312011-06-07 Martin Rudalics <rudalics@gmx.at>
11532
11533 * window.c (Fwindow_total_size, Fwindow_left_column)
11534 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11535 (Fwindow_list_1): New functions.
11536 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11537 (Fwindow_width, Fscroll_left, Fscroll_right):
11538 Use window_body_cols instead of window_box_text_cols.
11539 (delete_window, Fset_window_configuration):
11540 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11541 (delete_all_subwindows): Take a window as argument and not a
11542 structure. Rewrite.
190b47e6
MR
11543 (window_loop): Remove handling of GET_LRU_WINDOW and
11544 GET_LARGEST_WINDOW.
11545 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11546
11547 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11548 window_box_text_cols. delete_all_subwindows now takes a
11549 Lisp_Object as argument.
abde8f8c 11550
640c8776
SM
11551 * indent.c (compute_motion, Fcompute_motion):
11552 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11553
fa8a67e6
MR
11554 * frame.c (delete_frame): Call delete_all_subwindows with root
11555 window as argument.
11556
a54e3482
DC
115572011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11558
11559 * fns.c (Fputhash): Document return value.
11560
60002bf5
CY
115612011-06-06 Chong Yidong <cyd@stupidchicken.com>
11562
11563 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11564
0c671da6 115652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11566
b862a52a 11567 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11568
be44ca6c
PE
11569 Check for overflow when converting integer to cons and back.
11570 * charset.c (Fdefine_charset_internal, Fdecode_char):
11571 Use cons_to_unsigned to catch overflow.
11572 (Fencode_char): Use INTEGER_TO_CONS.
11573 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11574 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11575 * data.c (long_to_cons, cons_to_long): Remove.
11576 (cons_to_unsigned, cons_to_signed): New functions.
11577 These signal an error for invalid or out-of-range values.
11578 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11579 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11580 * font.c (Ffont_variation_glyphs):
11581 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11582 * lisp.h: Include <intprops.h>.
11583 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11584 (cons_to_signed, cons_to_unsigned): New decls.
11585 (long_to_cons, cons_to_long): Remove decls.
11586 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11587 (Fprimitive_undo): Use CONS_TO_INTEGER.
11588 * xfns.c (Fx_window_property): Likewise.
11589 * xselect.c: Include <limits.h>.
11590 (x_own_selection, selection_data_to_lisp_data):
11591 Use INTEGER_TO_CONS.
11592 (x_handle_selection_request, x_handle_selection_clear)
11593 (x_get_foreign_selection, Fx_disown_selection_internal)
11594 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11595 (lisp_data_to_selection_data): Use cons_to_unsigned.
11596 (x_fill_property_data): Use cons_to_signed.
11597 Report values out of range.
11598
d1f3d2af
PE
11599 Check for buffer and string overflow more precisely.
11600 * buffer.h (BUF_BYTES_MAX): New macro.
11601 * lisp.h (STRING_BYTES_MAX): New macro.
11602 * alloc.c (Fmake_string):
11603 * character.c (string_escape_byte8):
11604 * coding.c (coding_alloc_by_realloc):
11605 * doprnt.c (doprnt):
11606 * editfns.c (Fformat):
11607 * eval.c (verror):
11608 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11609 since they may not be the same number.
11610 * editfns.c (Finsert_char):
11611 * fileio.c (Finsert_file_contents):
11612 Likewise for BUF_BYTES_MAX.
11613
dd52fcea
PE
11614 * image.c: Use ptrdiff_t, not int, for sizes.
11615 (slurp_file): Switch from int to ptrdiff_t.
11616 All uses changed.
11617 (slurp_file): Check that file size fits in both size_t (for
11618 malloc) and ptrdiff_t (for sanity and safety).
11619
7f9bbdbb
PE
11620 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11621 if b->modtime has its maximal value.
11622
dfe18f82
PE
11623 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11624
84acfcf0
PE
11625 Don't assume time_t can fit into int.
11626 * buffer.h (struct buffer.modtime): Now time_t, not int.
11627 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11628 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11629
ccd9a01a
PE
11630 Minor fixes for signed vs unsigned integers.
11631 * character.h (MAYBE_UNIFY_CHAR):
11632 * charset.c (maybe_unify_char):
11633 * keyboard.c (read_char, reorder_modifiers):
11634 XINT -> XFASTINT, since the integer must be nonnegative.
11635 * ftfont.c (ftfont_spec_pattern):
11636 * keymap.c (access_keymap, silly_event_symbol_error):
11637 XUINT -> XFASTINT, since the integer must be nonnegative.
11638 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11639 since it makes no difference and we prefer signed.
11640 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11641 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11642 nonnegative.
11643
d6d100dd
SM
116442011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11645
11646 * window.h (Fwindow_frame): Declare.
11647
2b6148e4
PE
116482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11649
11650 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11651 (SPARE_MEMORY): Always define.
11652 (LARGE_REQUEST): Remove.
11653 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11654
f230ecc9
MR
116552011-06-06 Martin Rudalics <rudalics@gmx.at>
11656
727e958e
MR
11657 * lisp.h: Move EXFUNS for Fframe_root_window,
11658 Fframe_first_window and Fset_frame_selected_window to window.h.
11659
11660 * window.h: Move EXFUNS for Fframe_root_window,
11661 Fframe_first_window and Fset_frame_selected_window here from
11662 lisp.h.
11663
11664 * frame.c (Fwindow_frame, Fframe_first_window)
11665 (Fframe_root_window, Fframe_selected_window)
11666 (Fset_frame_selected_window): Move to window.c.
11667 (Factive_minibuffer_window): Move to minibuf.c.
11668 (Fother_visible_frames_p): New function.
11669
11670 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11671
f230ecc9
MR
11672 * window.c (decode_window, decode_any_window): Move up in code.
11673 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11674 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11675 (Fwindow_buffer): Move up and rewrite doc-string.
11676 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11677 (Fwindow_prev): New functions.
727e958e
MR
11678 (Fwindow_frame): Move here from frame.c. Accept any window as
11679 argument.
11680 (Fframe_root_window, Fframe_first_window)
11681 (Fframe_selected_window): Move here from frame.c. Accept frame
11682 or arbitrary window as argument. Update doc-strings.
11683 (Fminibuffer_window): Move up in code.
11684 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11685 (Fset_frame_selected_window): Move here from frame.c.
11686 Marginal rewrite.
727e958e
MR
11687 (Fselected_window, select_window, Fselect_window): Move up in
11688 code. Minor doc-string fixes.
f230ecc9 11689
4d09bcf6
PE
116902011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11691
11692 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11693 Do not assume that spare memory exists; that assumption is valid
11694 only if SYSTEM_MALLOC.
11695 (LARGE_REQUEST): New macro, so that the issue of large requests
11696 is separated from the issue of spare memory.
11697
810928a2
AS
116982011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11699
172418ad
AS
11700 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11701 format. (Bug#8806)
11702
43f862f7
AS
11703 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11704
810928a2
AS
11705 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11706 before statements.
11707
a059fe24
JD
117082011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11709
11710 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11711
11712 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11713
11714 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11715 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11716
989bf368
JB
117172011-06-05 Juanma Barranquero <lekktu@gmail.com>
11718
11719 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11720
4b80f674
CY
117212011-06-04 Chong Yidong <cyd@stupidchicken.com>
11722
11723 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11724 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11725 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11726 New error handlers.
4b80f674
CY
11727 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11728 Obey Vx_select_enable_clipboard_manager. Catch errors in
11729 x_clipboard_manager_save (Bug#8779).
11730 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11731 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11732
99a33b77 117332011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11734
11735 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11736
99a33b77 117372011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11738
11739 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11740 in the current matrix if keep_current_p is non-zero.
11741
8264569d
EZ
117422011-06-04 Eli Zaretskii <eliz@gnu.org>
11743
11744 * bidi.c (bidi_level_of_next_char): Fix last change.
11745
57f97249
EZ
117462011-06-03 Eli Zaretskii <eliz@gnu.org>
11747
fec2107c 11748 Support bidi reordering of text covered by display properties.
57f97249 11749
fec2107c
EZ
11750 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11751 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11752 (bidi_cache_search, bidi_cache_iterator_state)
11753 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11754 (bidi_level_of_next_char, bidi_move_to_visually_next):
11755 Support character positions inside a run of characters covered by a
fec2107c
EZ
11756 display string.
11757 (bidi_paragraph_init, bidi_resolve_explicit_1)
11758 (bidi_level_of_next_char): Call bidi_fetch_char and
11759 bidi_fetch_char_advance instead of FETCH_CHAR and
11760 FETCH_CHAR_ADVANCE.
11761 (bidi_init_it): Initialize new members.
11762 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11763 definitions.
11764 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11765 instead of using explicit *_CHAR codes.
d6d100dd
SM
11766 (bidi_resolve_explicit, bidi_resolve_weak):
11767 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11768 bidirectional text is supported only in multibyte buffers.
11769 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11770 it to initialize the frame_window_p member of struct bidi_it.
11771 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11772 (bidi_resolve_explicit, bidi_resolve_weak)
11773 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11774 bidi_it->nchars is non-positive.
11775 (bidi_level_of_next_char): Don't try to lookup the cache for the
11776 next/previous character if nothing is cached there yet, or if we
11777 were just reseat()'ed to a new position.
c40e2fb2 11778
0e14fe90
EZ
11779 * xdisp.c (set_cursor_from_row): Set start and stop points
11780 according to the row's direction when priming the loop that looks
11781 for the glyph on which to display cursor.
11782 (single_display_spec_intangible_p): Function deleted.
11783 (display_prop_intangible_p): Reimplement to call
11784 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11785 Accept 3 additional arguments needed by handle_display_spec.
11786 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11787 values: lists, `(when COND...)' forms, etc.
11788 (single_display_spec_string_p): Support property values that are
11789 lists with the argument STRING its top-level element.
11790 (display_prop_string_p): Fix the condition for processing a
11791 property that is a list to be consistent with handle_display_spec.
fec2107c 11792 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11793 last portion of handle_display_prop.
11794 (compute_display_string_pos): Accept additional argument
11795 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11796 value of a `display' property is a "replacing spec".
11797 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11798 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11799 the display property, but just return a value indicating whether
11800 the display property will replace the characters it covers.
11801 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11802 frame_window_p members of struct bidi_it.
d6d100dd
SM
11803 (compute_display_string_pos, compute_display_string_end):
11804 New functions.
fec2107c
EZ
11805 (push_it): Accept second argument POSITION, where pop_it should
11806 jump to continue iteration.
11807 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11808
fec2107c
EZ
11809 * keyboard.c (adjust_point_for_property): Adjust the call to
11810 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11811
11812 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11813 (bidi_init_it): Update prototypes.
11814 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11815 (compute_display_string_pos, compute_display_string_end):
11816 Declare prototypes.
fec2107c
EZ
11817 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11818 EMACS_INT.
fc6f18ce 11819
40087514 118202011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11821
57f53182
PE
11822 Malloc failure behavior now depends on size of allocation.
11823 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11824 * lisp.h: Change signatures accordingly.
11825 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11826 All callers changed. (Bug#8762)
11827
11828 * gnutls.c: Use Emacs's memory allocators.
11829 Without this change, the gnutls library would invoke malloc etc.
11830 directly, which causes problems on non-SYNC_INPUT hosts, and which
11831 runs afoul of improving memory_full behavior. (Bug#8761)
11832 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11833 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11834 xfree instead of the default malloc, realloc, free.
11835 (Fgnutls_boot): No need to check for memory allocation failure,
11836 since xmalloc does that for us.
11837
ac32cd99 11838 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11839 * category.c (hash_get_category_set):
11840 * ccl.c (ccl_driver):
11841 * charset.c (Fdefine_charset_internal):
11842 * charset.h (struct charset.hash_index):
11843 * composite.c (get_composition_id, gstring_lookup_cache)
11844 (composition_gstring_put_cache):
11845 * composite.h (struct composition.hash_index):
11846 * dispextern.h (struct image.hash):
11847 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11848 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11849 (hashfn_equal, hashfn_user_defined, make_hash_table)
11850 (maybe_resize_hash_table, hash_lookup, hash_put)
11851 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11852 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11853 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11854 * image.c (make_image, search_image_cache, lookup_image)
11855 (xpm_put_color_table_h):
11856 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11857 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11858 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11859 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11860 * alloc.c (allocate_vectorlike):
11861 Check for overflow in vector size calculations.
11862 * ccl.c (ccl_driver):
11863 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11864 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11865 need to be updated by these changes.
40087514
PE
11866 * fns.c (make_hash_table, maybe_resize_hash_table):
11867 Check for integer overflow with large hash tables.
0de4bb68
PE
11868 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11869 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11870 (SXHASH_REDUCE): New macro.
11871 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11872 Use it instead of discarding useful hash info with large hash values.
11873 (sxhash_float): New function.
11874 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11875 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11876 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11877 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11878 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11879 Adjust signatures to match updated version of code.
11880 (consing_since_gc): Now EMACS_INT, since a single hash table can
11881 use more than INT_MAX bytes.
11882
698d32e2
DN
118832011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11884
11885 Make it possible to build with GCC-4.6+ -O2 -flto.
11886
11887 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11888
fd6fa53f
SM
118892011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11890
11891 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11892 Call minibuffer-inactive-mode.
11893
864db017
JB
118942011-05-31 Juanma Barranquero <lekktu@gmail.com>
11895
11896 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11897 Update dependencies.
11898
2ad0baf4
DN
118992011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11900
11901 * data.c (init_data): Remove code for UTS, this system is not
11902 supported anymore.
11903
4fcc2638
DN
119042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11905
11906 Don't force ./temacs to start in terminal mode.
11907
11908 * frame.c (make_initial_frame): Initialize faces in all cases, not
11909 only when CANNOT_DUMP is defined.
11910 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11911
c56e0fd5
DN
119122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11913
11914 * dispnew.c (add_window_display_history): Use const for the string
11915 pointer. Remove declaration, not needed.
11916
333d54da 119172011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11918
55d4c1b2 11919 Use 'inline', not 'INLINE'.
333d54da 11920 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11921 * alloc.c, fontset.c (INLINE): Remove.
11922 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11923 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11924 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11925 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11926 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11927
738db178
DN
119282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11929
11930 Make it possible to run ./temacs.
11931
11932 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11933 syms_of_callproc does the same thing. Remove test for
11934 "initialized", do it in the caller.
11935 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11936
620c53a6
SM
119372011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11938
11939 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11940 (read_minibuf): Use get_minibuffer.
11941 (syms_of_minibuf): Use DEFSYM.
11942 (Qmetadata): New var.
11943 * data.c (Qbuffer): Don't make it static.
11944 (syms_of_data): Use DEFSYM.
11945
e003a292
PE
119462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11947
11948 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11949 (CCL_CODE_MIN): New macro.
11950
ed008a6d
PE
119512011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11952
3687c2ef
PE
11953 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11954
ed008a6d
PE
11955 * eval.c (Qdebug): Now static.
11956 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11957 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11958 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11959
d66c4c7c
CY
119602011-05-29 Chong Yidong <cyd@stupidchicken.com>
11961
11962 * image.c: Various fixes to ImageMagick code comments.
11963 (Fimagemagick_types): Doc fix.
11964
5fbc2025
PE
119652011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11966
0196f88a
PE
11967 Minor fixes prompted by GCC 4.6.0 warnings.
11968
11969 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11970
5fbc2025
PE
11971 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11972 (x_clipboard_manager_save_all): Move extern decl to ...
11973 * xterm.h: ... here, so that it can be checked for consistency.
11974
1dd3c2d9
CY
119752011-05-29 Chong Yidong <cyd@stupidchicken.com>
11976
11977 * xselect.c (x_clipboard_manager_save_frame)
11978 (x_clipboard_manager_save_all): New functions.
11979 (Fx_clipboard_manager_save): Lisp function deleted.
11980
11981 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11982 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11983
11984 * xterm.h: Update prototype.
11985
5ba6571d
WX
119862011-05-28 William Xu <william.xwl@gmail.com>
11987
11988 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11989 exiting (Bug#8239).
11990
3eaff834
JM
119912011-05-28 Jim Meyering <meyering@redhat.com>
11992
e1900994 11993 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11994 * fns.c (to_uchar): Define.
11995 (crypto_hash_function): Use it to convert some newly-signed
11996 variables to unsigned, to avoid sign-extension bugs. For example,
11997 without this change, (md5 "truc") would evaluate to
11998 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11999 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 12000 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 12001
0f6990a7
PE
120022011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12003
12004 Integer overflow fixes.
c8a9ca5a 12005
08686060
PE
12006 * dbusbind.c: Serial number integer overflow fixes.
12007 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
12008 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
12009 to hold a serial number that is too large for a fixnum.
12010 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12011 Check for serial numbers out of range. Decode any serial number
59568bf0 12012 that was so large that it became a float. (Bug#8722)
08686060 12013
2d1fc3c7
PE
12014 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
12015 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12016 Use XFASTINT rather than XUINT when numbers are nonnegative.
12017 (xd_append_arg, Fdbus_method_return_internal):
12018 (Fdbus_method_error_internal): Likewise. Also, for unsigned
12019 arguments, check that Lisp number is nonnegative, rather than
59568bf0 12020 silently wrapping negative numbers around. (Bug#8722)
30217ff0 12021 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 12022 (Bug#8722)
2d1fc3c7 12023
c8a9ca5a
PE
12024 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
12025
519e1d69
PE
12026 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
12027
6df6ae42 12028 ccl: Add integer overflow checks.
30569699
PE
12029 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
12030 (IN_INT_RANGE): New macros.
12031 (ccl_driver): Use them to check for integer overflow when
12032 decoding a CCL program. Many of the new checks are whether XINT (x)
12033 fits in int; it doesn't always, on 64-bit hosts. The new version
12034 doesn't catch all possible integer overflows, but it's an
847044ea 12035 improvement. (Bug#8719)
30569699 12036
c11285dc
PE
12037 * alloc.c (make_event_array): Use XINT, not XUINT.
12038 There's no need for unsigned here.
12039
fdccd48e
PE
12040 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
12041 This follows up to the 2011-05-06 change that substituted uintptr_t
12042 for EMACS_INT. This case wasn't caught back then.
12043
37910ab2
PE
12044 Rework Fformat to avoid integer overflow issues.
12045 * editfns.c: Include <float.h> unconditionally, as it's everywhere
12046 now (part of C89). Include <verify.h>.
12047 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
12048 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
12049 (Fformat): Avoid the prepass trying to compute sizes; it was only
12050 approximate and thus did not catch overflow reliably. Instead, walk
12051 through the format just once, formatting and computing sizes as we go,
12052 checking for integer overflow at every step, and allocating a larger
12053 buffer as needed. Keep track separately whether the format is
12054 multibyte. Keep only the most-recently calculated precision, rather
12055 than them all. Record whether each argument has been converted to
12056 string. Use EMACS_INT, not int, for byte and char and arg counts.
12057 Support field widths and precisions larger than INT_MAX. Avoid
12058 sprintf's undefined behavior with conversion specifications such as %#d
12059 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
12060 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
12061 formatting out-of-range floating point numbers with int
9173deec 12062 formats. (Bug#8668)
37910ab2 12063
2e6578fb
PE
12064 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
12065
0ae6bdee
PE
12066 * data.c: Avoid integer truncation in expressions involving floats.
12067 * data.c: Include <intprops.h>.
12068 (arith_driver): When there's an integer overflow in an expression
12069 involving floating point, convert the integers to floating point
12070 so that the resulting value does not suffer from catastrophic
12071 integer truncation. For example, on a 64-bit host (* 4
12072 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
12073 Do not rely on undefined behavior after integer overflow.
12074
de883a70
PE
12075 merge count_size_as_multibyte, parse_str_to_multibyte
12076 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 12077 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
12078 Check for integer overflow.
12079 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
12080 since it's now a duplicate of the other. This is more of
12081 a character than a buffer op, so better that it's in character.c.
12082 * fns.c, print.c: Adjust to above changes.
12083
2ff916cb
PE
120842011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
12085
12086 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
12087
f1b54466
PE
120882011-05-27 Paul Eggert <eggert@cs.ucla.edu>
12089
fb1ac845
PE
12090 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12091 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
12092 (x_clipboard_manager_save): Now static.
12093 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
12094
f1b54466
PE
12095 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
12096 (crypto_hash_function): Now static.
12097 Fix pointer signedness problems. Avoid unnecessary initializations.
12098
a9f737ee
CY
120992011-05-27 Chong Yidong <cyd@stupidchicken.com>
12100
12101 * termhooks.h (Vselection_alist): Make it terminal-local.
12102
12103 * terminal.c (create_terminal): Initialize it.
12104
12105 * xselect.c: Support for clipboard managers.
12106 (Vselection_alist): Move to termhooks.h as terminal-local var.
12107 (LOCAL_SELECTION): New macro.
12108 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
12109 (symbol_to_x_atom): Remove gratuitous arg.
12110 (x_handle_selection_request, lisp_data_to_selection_data)
12111 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
12112 (x_own_selection, x_get_local_selection, x_convert_selection):
12113 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
12114 (some_frame_on_display): Delete unused function.
12115 (Fx_own_selection_internal, Fx_get_selection_internal)
12116 (Fx_disown_selection_internal, Fx_selection_owner_p)
12117 (Fx_selection_exists_p): New optional frame arg.
12118 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12119 (x_handle_selection_clear): Don't treat other terminals with the
12120 same keyboard specially. Use the terminal-local Vselection_alist.
12121 (x_clear_frame_selections): Use Frun_hook_with_args.
12122
12123 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12124
12125 * xterm.h: Add support for those atoms.
12126
e067f0c1
CY
121272011-05-26 Chong Yidong <cyd@stupidchicken.com>
12128
12129 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12130 (converted_selections, conversion_fail_tag): New global variables.
12131 (x_selection_request_lisp_error): Free the above.
12132 (x_get_local_selection): Remove unnecessary code.
12133 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12134 of converted selections stored in converted_selections.
12135 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12136 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12137 (x_convert_selection): New function.
12138 (x_handle_selection_event): Simplify.
12139 (x_get_foreign_selection): Don't ignore incoming requests while
12140 waiting for an answer; this will fail when we implement
12141 SAVE_TARGETS, and seems unnecessary anyway.
12142 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12143 (Vx_sent_selection_functions): Doc fix.
12144
0f4aebc0
LL
121452011-05-26 Leo Liu <sdl.web@gmail.com>
12146
12147 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12148
e61124cd
YM
121492011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12150
12151 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12152
12153 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12154 for fringe update if it has periodic bitmap.
ac389d0c 12155 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12156 and fringe_bitmap_periodic_p.
12157
12158 * fringe.c (get_fringe_bitmap_data): New function.
12159 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12160 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12161 row. Mark glyph row for fringe update if periodicity changed.
12162
12163 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12164 for fringe update unless it has periodic bitmap.
12165
f16d9837
KH
121662011-05-25 Kenichi Handa <handa@m17n.org>
12167
12168 * xdisp.c (get_next_display_element): Set correct it->face_id for
12169 a static composition.
12170
e1b90ef6
LL
121712011-05-24 Leo Liu <sdl.web@gmail.com>
12172
12173 * deps.mk (fns.o):
12174 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12175
12176 * fns.c (crypto_hash_function, Fsha1): New function.
12177 (Fmd5): Use crypto_hash_function.
12178 (syms_of_fns): Add Ssha1.
12179
7400048f
PE
121802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12181
12182 * gnutls.c: Remove unused macros.
12183 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12184 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12185 Remove macros that are defined and never used.
12186 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12187
abb71cf4
CY
121882011-05-22 Chong Yidong <cyd@stupidchicken.com>
12189
12190 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12191 (Fx_get_selection_internal): Minor cleanup.
12192 (Fx_own_selection_internal): Rename arguments for consistency with
12193 select.el.
12194
6307db39
PE
121952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12196
12197 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12198
f3d4e0a4
CY
121992011-05-22 Chong Yidong <cyd@stupidchicken.com>
12200
12201 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12202
4d8ade89
YM
122032011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12204
12205 * dispnew.c (scrolling_window): Don't exclude the case that the
12206 last enabled row in the desired matrix touches the bottom boundary.
12207
32078c8d
GM
122082011-05-21 Glenn Morris <rgm@gnu.org>
12209
12210 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12211 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12212 and add some more files.
32078c8d 12213
7285dc67
EZ
122142011-05-20 Eli Zaretskii <eliz@gnu.org>
12215
12216 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12217 report_file_error introduced by the change from 2011-05-07.
12218
89d1bd22
PE
122192011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12220
12221 * systime.h (Time): Define only if emacs is defined.
12222 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12223 where the include path doesn't have X11/X.h by default. See
12224 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12225
cd394be1 122262011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12227
12228 * composite.c (find_automatic_composition): Fix previous change.
12229
b9704ad9
GM
122302011-05-20 Glenn Morris <rgm@gnu.org>
12231
12232 * lisp.mk: New file, split from Makefile.in.
12233 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12234 (shortlisp): Remove.
12235 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12236
4a720484
GM
122372011-05-19 Glenn Morris <rgm@gnu.org>
12238
12239 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12240 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12241 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12242 (lisp): Set the order to that of loadup.el.
12243 (shortlisp): Make it a copy of $lisp.
12244 (SOME_MACHINE_LISP): Remove.
12245 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12246 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12247
a28d4396
KH
122482011-05-18 Kenichi Handa <handa@m17n.org>
12249
12250 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12251 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12252 (find_automatic_composition): Mostly rewrite for efficiency.
12253
a2b1fa8e
JB
122542011-05-18 Juanma Barranquero <lekktu@gmail.com>
12255
12256 * makefile.w32-in: Update dependencies.
12257
8e1f5610
CS
122582011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12259
12260 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12261 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12262
7025ee00 122632011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12264
cdfa6eab
PE
12265 Fix some integer overflow issues, such as string length overflow.
12266
06d6db33
PE
12267 * insdel.c (count_size_as_multibyte): Check for string overflow.
12268
2b4560a8
PE
12269 * character.c (lisp_string_width): Check for string overflow.
12270 Use EMACS_INT, not int, for string indexes and lengths; in
12271 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12272 the resulting string length overflows an EMACS_INT; instead,
12273 report a string overflow if no precision given. When checking for
12274 precision exhaustion, use a check that cannot possibly have
12275 integer overflow. (Bug#8675)
12276 * character.h (lisp_string_width): Adjust to new signature.
12277
cb93f9be
PE
12278 * alloc.c (string_overflow): New function.
12279 (Fmake_string): Use it. This doesn't change behavior, but saves
12280 a few bytes and will simplify future changes.
12281 * character.c (string_escape_byte8): Likewise.
12282 * lisp.h (string_overflow): New decl.
12283
1a1f3366
PE
12284 Fixups, following up to the user-interface timestamp change.
12285 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12286 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12287 * msdos.c (mouse_get_pos): Likewise.
12288 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12289 * w32gui.h (Time): Define by including "systime.h" rather than by
12290 declaring it ourselves. (Bug#8664)
12291
d4e3e4d3
PE
12292 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12293 * image.c (clear_image_cache): Likewise.
12294
f6a24d19
PE
12295 * term.c (term_mouse_position): Don't assume time_t wraparound.
12296
08dc5ae6
PE
12297 Be more systematic about user-interface timestamps.
12298 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12299 and sometimes 'EMACS_UINT', to represent these timestamps.
12300 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12301 This makes the code easier to follow, and makes it easier to catch
12302 integer overflow bugs such as Bug#8664.
12303 * frame.c (Fmouse_position, Fmouse_pixel_position):
12304 Use Time, not unsigned long, for user-interface timestamps.
12305 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12306 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12307 * keyboard.h (last_event_timestamp): Likewise.
12308 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12309 * menu.h (xmenu_show): Likewise.
12310 * term.c (term_mouse_position): Likewise.
12311 * termhooks.h (struct input_event.timestamp): Likewise.
12312 (struct terminal.mouse_position_hook): Likewise.
12313 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12314 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12315 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12316 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12317 what it was before.
12318 * menu.h, termhooks.h: Include "systime.h", for Time.
12319
8e55734a
PE
12320 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12321 Don't assume that the difference between two unsigned long values
12322 can fit into an integer. At this point, we know button_down_time
12323 <= event->timestamp, so the difference must be nonnegative, so
12324 there's no need to cast the result if double-click-time is
12325 nonnegative, as it should be; check that it's nonnegative, just in
12326 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12327 apart (about 25 days). (Bug#8664)
8e55734a 12328
841f1b75 12329 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12330 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12331
3e26f69c
PE
12332 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12333 that always fit in int. Use a sentinel instead of a counter, to
12334 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12335 * frame.h (struct frame): Use int for menu_bar_items_used
12336 instead of EMACS_INT, since it always fits in int.
3e26f69c 12337
5cc152c0
PE
12338 * menu.c (grow_menu_items): Check for int overflow.
12339
d89eb65e
PE
12340 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12341
5235bd3e
PE
12342 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12343 Before, the code was not consistent. These values cannot exceed
12344 2**31 - 1 so there's no need to make them unsigned.
12345 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12346 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12347 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12348 as modifiers.
12349 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12350
bc827e23
PE
12351 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12352 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12353 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12354 presumably because the widths might not match.
12355
78eb494e
PE
12356 * window.c (size_window): Avoid needless test at loop start.
12357
04f2d78b
CB
123582011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12359
12360 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12361
d2fc7e3d 123622011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12363
12364 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12365
d2fc7e3d 123662011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12367
12368 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12369 `width' to `bar_area_x' and `bar_area_width', respectively.
12370 (x_scroll_run): Take account of fringe background extension.
12371
04f2d78b
CB
12372 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12373 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12374 `bar_area_width', respectively.
12375 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12376 background extension.
12377
79b70037
GM
123782011-05-10 Jim Meyering <meyering@redhat.com>
12379
12380 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12381
2f142cc5
JB
123822011-05-10 Juanma Barranquero <lekktu@gmail.com>
12383
12384 * image.c (Finit_image_library): Return t for built-in image types,
12385 like pbm and xbm. (Bug#8640)
12386
57679c86
AS
123872011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12388
12389 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12390
888c9e86
EZ
123912011-05-07 Eli Zaretskii <eliz@gnu.org>
12392
b0512a1d
EZ
12393 * w32console.c (Fset_screen_color): Doc fix.
12394 (Fget_screen_color): New function.
12395 (syms_of_ntterm): Defsubr it.
12396
7285dc67
EZ
12397 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12398 unlink the temporary file if Fcall_process didn't create it in the
12399 first place.
12400 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12401 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12402 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12403 cue to call_process_cleanup not to close that handle.
12404
4d3fcc8e
BK
124052011-05-07 Ben Key <bkey76@gmail.com>
12406
12407 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12408 one of two shell specific rules, either bootstrap-temacs-CMD or
12409 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12410 to the previous implementation of the bootstrap-temacs rule.
12411 The bootstrap-temacs-CMD rule is similar to the previous
12412 implementation of the bootstrap-temacs rule except that it
12413 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12414 variable.
12415
12416 These changes, along with some changes to nt/configure.bat,
12417 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12418 earlier fix to add support for --cflags and --ldflags options
12419 that include quotes so that it works whether make uses cmd or
12420 sh as the shell.
12421
b4289b64
MA
124222011-05-06 Michael Albinus <michael.albinus@gmx.de>
12423
12424 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12425 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12426 is a constant.
12427 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12428 a string. Handle both cases.
12429 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12430 (Fdbus_register_method): Use Qinvalid_function.
12431
af4c0e28
JB
124322011-05-06 Juanma Barranquero <lekktu@gmail.com>
12433
12434 * makefile.w32-in: Update dependencies.
12435 (LISP_H): Add inttypes.h and stdin.h.
12436 (PROCESS_H): Add unistd.h.
12437
c51453d9
EZ
124382011-05-06 Eli Zaretskii <eliz@gnu.org>
12439
12440 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12441 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12442
8ff0ac3c 124432011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12444
4c4b566b
PE
12445 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12446
aab2b9b5
PE
12447 * term.c (vfatal): Remove stray call to va_end.
12448 It's not needed and the C Standard doesn't allow it here anyway.
12449
c378da0b
PE
12450 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12451 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12452
288b08c7
PE
12453 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12454 bytes.
12455
e3601888
PE
12456 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12457
db6c0e74
PE
12458 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12459
dd5963ea
PE
12460 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12461
88c9450f
PE
12462 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12463
2f9442b8
PE
12464 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12465
c032b5f8
PE
12466 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12467 * charset.c (Fdefine_charset_internal): Don't initialize
12468 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12469 32-bit int (Bug#8600).
a108c10b
PE
12470
12471 * lread.c (read_integer): Be more consistent with string-to-number.
12472 Use string_to_number to do the actual conversion; this avoids
12473 rounding errors and fixes some other screwups. Without this fix,
12474 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12475 (digit_to_number): Move earlier, for benefit of read_integer.
12476 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12477 not a digit in any supported base. (Bug#8602)
a108c10b 12478
ad5f9eea
PE
12479 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12480
aec1708a
PE
12481 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12482 to match comment at start of function. This also removes a
12483 GCC warning about overflow in a 32+64-bit port.
12484
47be4ab5
PE
12485 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12486
371cac43
PE
12487 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12488 Reported by Stefan Monnier in
12489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12490 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12491 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12492
d01a7826
PE
12493 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12494 (EMACS_UINTPTR): Likewise, with uintptr_t.
12495
7fd47d5c
PE
12496 * lisp.h: Prefer 64-bit EMACS_INT if available.
12497 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12498 on 32-bit hosts that have 64-bit int, so that they can access
12499 large files.
122b0c86
PE
12500 However, temporarily disable this change unless the temporary
12501 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12502
8727937b
PE
12503 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12504
8ac068ac
PE
12505 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12506 This removes an assumption that EMACS_INT and long are the same
12507 width as pointers. The assumption is true for Emacs porting targets
12508 now, but we want to make other targets possible.
12509 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12510 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12511 In the rest of the code, change types of integers that hold casted
12512 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12513 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12514 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12515 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12516 No need to cast type when ORing.
12517 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12518 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12519 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12520 assume EMACS_INT is the same width as char *.
12521 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12522 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12523 Remove no-longer-needed casts.
12524 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12525 (xg_tool_bar_help_callback, xg_make_tool_item):
12526 Use EMACS_INTPTR to hold an integer
12527 that will be cast to void *; this can avoid a GCC warning
12528 if EMACS_INT is not the same width as void *.
12529 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12530 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12531 (current_message_1, set_message_1):
12532 Use a local to convert to proper width without a cast.
12533 * xmenu.c (dialog_selection_callback): Likewise.
12534
ede49d71
PE
12535 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12536 Also, don't assume VALBITS / RAND_BITS is less than 5,
12537 and don't rely on undefined behavior when shifting a 1 left into
12538 the sign bit.
12539 * lisp.h (get_random): Change signature to match.
12540
2f30ecd0
PE
12541 * lread.c (hash_string): Use size_t, not int, for hash computation.
12542 Normally we prefer signed values; but hashing is special, because
12543 it's better to use unsigned division on hash table sizes so that
12544 the remainder is nonnegative. Also, size_t is the natural width
12545 for hashing into memory. The previous code used 'int', which doesn't
12546 retain enough info to hash well into very large tables.
12547 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12548
2a866e7b
PE
12549 * dbusbind.c: Don't possibly lose pointer info when converting.
12550 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12551 Use XPNTR rather than XHASH, so that the high-order bits of
12552 the pointer aren't lost when converting through void *.
12553
51639eac
PE
12554 * eval.c (Fautoload): Don't double-shift a pointer.
12555
92394119
PE
12556 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12557
dbdb9a7c
JB
125582011-05-06 Juanma Barranquero <lekktu@gmail.com>
12559
12560 * gnutls.c (DEF_GNUTLS_FN):
12561 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12562
db7a0b4f
AS
125632011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12564
12565 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12566 marker. (Bug#8610)
12567
cd394be1 125682011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12569
12570 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12571 New version that can reserve upto 2GB of heap space.
12572
f7ff1b0f 125732011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12574
12575 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12576
639c109b
TZ
125772011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12578
12579 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12580 `gnutls_certificate_set_x509_key_file'.
12581
d2127135
JB
125822011-05-05 Juanma Barranquero <lekktu@gmail.com>
12583
12584 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12585 Update dependencies.
12586
e968f4f3
JB
125872011-05-04 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12590 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12591 Remove unused parameter `fildes'.
12592 * process.c (read_process_output, send_process): Don't pass it.
12593
84d358f0
JB
125942011-05-04 Juanma Barranquero <lekktu@gmail.com>
12595
12596 Fix previous change: the library cache is defined in w32.c.
12597 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12598 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12599
0898ca10
JB
126002011-05-04 Juanma Barranquero <lekktu@gmail.com>
12601
12602 Implement dynamic loading of GnuTLS on Windows.
12603
12604 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12605 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12606 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12607 Declare.
12608
12609 * gnutls.c (Qgnutls_dll): Define.
12610 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12611 (gnutls_*): Declare function pointers.
12612 (init_gnutls_functions): New function to initialize function pointers.
12613 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12614 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12615 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12616 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12617 (emacs_gnutls_write, emacs_gnutls_read)
12618 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12619 (Fgnutls_available_p): New function.
12620 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12621 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12622 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12623
12624 * image.c: Include w32.h.
12625 (Vimage_type_cache): Delete.
12626 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12627 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12628 (w32_delayed_load): Move to w32.c.
12629
12630 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12631
12632 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12633 (w32_delayed_load): Move from image.c. When loading a library, record
12634 its filename in the :loaded-from property of the library id.
12635 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12636 Initialize and staticpro them.
12637 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12638
12639 * process.c: Include lisp.h before w32.h, not after.
12640 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12641 instead of gnutls_record_check_pending.
12642
12643 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12644
ff4de4aa
TZ
126452011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12646
12647 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12648 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12649 as passed in.
12650
abe95abb
JD
126512011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12652
12653 * xterm.c (x_set_frame_alpha): Do not set property on anything
12654 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12655
e16e55d4
JB
126562011-05-02 Juanma Barranquero <lekktu@gmail.com>
12657
12658 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12659
bafcf6a5
JB
126602011-05-02 Juanma Barranquero <lekktu@gmail.com>
12661
12662 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12663 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12664 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12665 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12666 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12667 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12668 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12669 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12670 (Qgnutls_bootprop_callbacks_verify): Make static.
12671
e7a6747f
AS
126722011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12673
19ed11ba
AS
12674 * callproc.c: Indentation fixup.
12675
e7a6747f 12676 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12677 (wait_for_termination, interruptible_wait_for_termination):
12678 Move after wait_for_termination_1.
e7a6747f 12679
1ef14cb4
LMI
126802011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12681
12682 * sysdep.c (interruptible_wait_for_termination): New function
12683 which is like wait_for_termination, but allows keyboard
12684 interruptions.
12685
12686 * callproc.c (Fcall_process): Add (:file "file") as an option for
12687 the STDOUT buffer.
12688 (Fcall_process_region): Ditto.
12689
330d880c
EZ
126902011-04-30 Eli Zaretskii <eliz@gnu.org>
12691
8db90b73
EZ
12692 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12693 rather than `XVECTOR (FOO)->size'.
12694
330d880c
EZ
12695 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12696 inttypes.h, as a gnulib replacement is used if it not available in
12697 system headers.
12698
15cbd324
EZ
126992011-04-21 Eli Zaretskii <eliz@gnu.org>
12700
12701 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12702 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12703 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12704
12705 * coding.c (coding_alloc_by_realloc): Error out if destination
12706 will grow beyond MOST_POSITIVE_FIXNUM.
12707 (decode_coding_emacs_mule): Abort if there isn't enough place in
12708 charbuf for the composition carryover bytes. Reserve an extra
12709 space for up to 2 characters produced in a loop.
12710 (decode_coding_iso_2022): Abort if there isn't enough place in
12711 charbuf for the composition carryover bytes.
12712
127132011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12714
ae940cca
EZ
12715 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12716 aborting when %lld or %lll format is passed.
12717 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12718 %llo or %llx format is passed. (Bug#8545)
12719
03ab8921
EZ
12720 * window.c (window_scroll_line_based): Use a marker instead of
12721 simple variables to record original value of point. (Bug#7952)
12722
afda1437
EZ
12723 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12724 produced by %s or %c overflows available buffer space. (Bug#8545)
12725
f76dee0c
PE
127262011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12727
12728 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12729 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12730
fdc5744d
JB
127312011-04-28 Juanma Barranquero <lekktu@gmail.com>
12732
12733 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12734
638f053a
JB
127352011-04-28 Juanma Barranquero <lekktu@gmail.com>
12736
12737 * keyboard.c (Qdelayed_warnings_hook): Define.
12738 (command_loop_1): Run `delayed-warnings-hook'
12739 if Vdelayed_warnings_list is non-nil.
12740 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12741 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12742
d178f871
EZ
127432011-04-28 Eli Zaretskii <eliz@gnu.org>
12744
12745 * doprnt.c (doprnt): Don't return value smaller than the buffer
12746 size if the message was truncated. (Bug#8545).
12747
b124fd93
JB
127482011-04-28 Juanma Barranquero <lekktu@gmail.com>
12749
12750 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12751 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12752
e810457d
PE
127532011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12754
12755 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12756
ea51cceb
JB
127572011-04-27 Juanma Barranquero <lekktu@gmail.com>
12758
12759 * makefile.w32-in: Update dependencies.
12760
94dcfacf
EZ
127612011-04-27 Eli Zaretskii <eliz@gnu.org>
12762
12763 Improve `doprnt' and its usage. (Bug#8545)
12764 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12765 `format_end'. Remove support for %l as a conversion specifier.
12766 Don't use xrealloc. Improve diagnostics when the %l size modifier
12767 is used. Update the commentary.
12768
12769 * eval.c (verror): Simplify calculation of size_t.
12770
12771 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12772 messages.
12773
f61f41d7
PE
127742011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12775
12776 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12777 change.
12778
96fb4434
PE
127792011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12780
12781 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12782 This makes this file independent of the recent pseudovector change.
12783
671875da 127842011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12785
69e9b5a3
PE
12786 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12787
b5f869a7 12788 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12789 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12790 Remove unused local.
c8926152 12791 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12792
841a1577 12793 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12794 GCC 4.6.0 optimizes based on type-based alias analysis.
12795 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12796 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12797 != &v->size, and therefore "v->size = 1; b->size = 2; return
12798 v->size;" must therefore return 1. This assumption is incorrect
12799 for Emacs, since it type-puns struct Lisp_Vector * with many other
12800 types. To fix this problem, this patch adds a new type struct
f904488f 12801 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12802 and pseudovectors, and helps optimizing compilers not get fooled
12803 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12804 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12805 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12806 the size member.
eab3844f
PE
12807 (XSETPVECTYPE): Rewrite in terms of new macro.
12808 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12809 This is a bit clearer, and further avoids the possibility of
12810 undesirable aliasing.
12811 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12812 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12813 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12814 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12815 (ASIZE): Now uses header.size rather than size.
12816 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12817 to avoid the hassle of writing XVECTOR (foo)->header.size.
12818 (struct vectorlike_header): New type.
eab3844f
PE
12819 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12820 object, to help avoid aliasing.
12821 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12822 (SUBRP): Likewise, since Lisp_Subr is a special case.
12823 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12824 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12825 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12826 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12827 changed to be "header.size" and "header.next".
12828 * buffer.h (struct buffer): Likewise.
12829 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12830 * frame.h (struct frame): Likewise.
12831 * process.h (struct Lisp_Process): Likewise.
12832 * termhooks.h (struct terminal): Likewise.
12833 * window.c (struct save_window_data, struct saved_window): Likewise.
12834 * window.h (struct window): Likewise.
12835 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12836 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12837 * buffer.c (init_buffer_once): Likewise.
12838 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12839 special case.
12840 * process.c (Fformat_network_address): Use local var for size,
12841 for brevity.
12842
0df1eac5
PE
12843 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12844
847ab9d1 12845 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12846 * data.c (atof): Remove decl; no longer used or needed.
12847 (digit_to_number): Move to lread.c.
12848 (Fstring_to_number): Use new string_to_number function, to be
12849 consistent with how the Lisp reader treats infinities and NaNs.
12850 Do not assume that floating-point numbers represent EMACS_INT
12851 without losing information; this is not true on most 64-bit hosts.
12852 Avoid double-rounding errors, by insisting on integers when
12853 parsing non-base-10 numbers, as the documentation specifies.
12854 * lisp.h (string_to_number): New decl, replacing ...
12855 (isfloat_string): Remove.
bc0a5c13 12856 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12857 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12858 appears to have been a coding error. Similarly, do not accept
12859 strings like +-1e0 as floating point numbers. Do not report
12860 overflow for integer overflows unless the base is not 10 which
12861 means we have no simple and reliable way to continue.
12862 Break out the floating-point parsing into a new
12863 function string_to_number, so that Fstring_to_number parses
12864 floating point numbers consistently with the Lisp reader.
04f2d78b 12865 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12866 (E_CHAR, EXP_INT): Remove, replacing with ...
12867 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12868 (string_to_number): New function, replacing isfloat_string.
12869 This function checks for valid syntax and produces the resulting
12870 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12871 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12872 so that overflow for non-base-10 numbers is reported only when
12873 there's no portable and simple way to convert to floating point.
452f4150 12874
67769ffc
PE
12875 * textprop.c (set_text_properties_1): Rewrite for clarity,
12876 and to avoid GCC warning about integer overflow.
12877
c20db43f
PE
12878 * intervals.h (struct interval): Use EMACS_INT for members
12879 where EMACS_UINT might cause problems. See
12880 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12881 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12882 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12883 All uses changed.
37aa2f85
PE
12884 (offset_intervals): Tell GCC not to worry about length overflow
12885 when negating a negative length.
c20db43f 12886
2538aa2f
PE
12887 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12888 (overrun_check_free): Likewise.
12889
f2d3008d
PE
12890 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12891 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12892 word size.
12893
ec8df744
PE
12894 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12895 (gnutls_make_error): Rename local to avoid shadowing.
12896 (gnutls_emacs_global_deinit): ifdef out; not used.
12897 (Fgnutls_boot): Use const for pointer to readonly storage.
12898 Comment out unused local. Fix pointer signedness problems.
12899
640ee02d
PE
12900 * lread.c (openp): Don't stuff size_t into an 'int'.
12901 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12902 about possible signed overflow.
12903
6048fb2a
PE
12904 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12905 (GDK_KEY_g): Don't define if already defined.
12906 (xg_prepare_tooltip): Avoid pointer signedness problem.
12907 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12908
fa3c87e1
PE
12909 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12910 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12911
2172544b
PE
12912 * xfns.c (Fx_window_property): Simplify a bit,
12913 to make a bit faster and to avoid GCC 4.6.0 warning.
12914 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12915
9b821a21
PE
12916 * fns.c (internal_equal): Don't assume size_t fits in int.
12917
3c616cfa
PE
12918 * alloc.c (compact_small_strings): Tighten assertion a little.
12919
c2982e87
PE
12920 Replace pEd with more-general pI, and fix some printf arg casts.
12921 * lisp.h (pI): New macro, generalizing old pEd macro to other
12922 conversion specifiers. For example, use "...%"pI"d..." rather
12923 than "...%"pEd"...".
12924 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12925 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12926 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12927 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12928 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12929 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12930 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12931 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12932 64-bit hosts.
12933 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12934 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12935 * print.c (safe_debug_print, print_object): Likewise.
12936 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12937 to int.
6f04d126
PE
12938 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12939 avoiding the 0 flag, which is not portable.
c2982e87
PE
12940 * process.c (Fmake_network_process): Use pI to avoid cast.
12941 * region-cache.c (pp_cache): Likewise.
12942 * xdisp.c (decode_mode_spec): Likewise.
12943 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12944 behavior on 64-bit hosts with printf arg.
6f04d126 12945 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12946 (x_stop_queuing_selection_requests): Likewise.
12947 (x_get_window_property): Don't truncate byte count to an 'int'
12948 when tracing.
0b432f21 12949
5e073ec7
PE
12950 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12951 here, since it parses constructs like leading '-' and spaces,
12952 which are not wanted; and it overflows with large numbers.
12953 Instead, simply match F[0-9]+, which is what is wanted anyway.
12954
36372bf9
PE
12955 * alloc.c: Remove unportable assumptions about struct layout.
12956 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12957 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12958 (allocate_vectorlike, make_pure_vector): Use the new macros,
12959 plus offsetof, to remove unportable assumptions about struct layout.
12960 These assumptions hold on all porting targets that I know of, but
12961 they are not guaranteed, they're easy to remove, and removing them
12962 makes further changes easier.
12963
0b432f21
PE
12964 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12965 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12966 (string_overrun_cookie): Now const. Use initializers that
12967 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12968 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12969 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12970 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12971 multiple of sizeof (EMACS_INT); it need not be, if
12972 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12973 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12974
895009e1
JB
129752011-04-26 Juanma Barranquero <lekktu@gmail.com>
12976
12977 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12978
6a7a1b0b
TZ
129792011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12980
12981 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12982 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12983 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12984
841a1577 129852011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12986
12987 * lisp.h (Qdebug): List symbol.
895009e1 12988 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12989 * keyboard.c (debug-on-event): New variable.
12990 (handle_user_signal): Break into debugger when debug-on-event
12991 matches the current signal symbol.
12992
f2d3ba6f
DN
129932011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12994
12995 * alloc.c (check_sblock, check_string_bytes)
12996 (check_string_free_list): Convert to standard C.
12997
42ce4c63
TZ
129982011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12999
13000 * w32.c (emacs_gnutls_push): Fix typo.
13001
825cd63c
EZ
130022011-04-25 Eli Zaretskii <eliz@gnu.org>
13003
fb11d64d
EZ
13004 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
13005 "cast to pointer from integer of different size".
13006
825cd63c
EZ
13007 Improve doprnt and its use in verror. (Bug#8545)
13008 * doprnt.c (doprnt): Document the set of format control sequences
13009 supported by the function. Use SAFE_ALLOCA instead of always
13010 using `alloca'.
13011
13012 * eval.c (verror): Don't limit the buffer size at size_max-1, that
13013 is one byte too soon. Don't use xrealloc; instead xfree and
13014 xmalloc anew.
13015
e061a11b
TZ
130162011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
13017
13018 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
13019 callbacks stage.
13020
13021 * gnutls.c: Renamed global_initialized to
13022 gnutls_global_initialized. Added internals for the
13023 :verify-hostname-error, :verify-error, and :verify-flags
13024 parameters of `gnutls-boot' and documented those parameters in the
13025 docstring. Start callback support.
9173deec
JB
13026 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
13027 unless a fatal error occurred. Call gnutls_alert_send_appropriate
13028 on error. Return error code.
e061a11b
TZ
13029 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
13030 (emacs_gnutls_read): Likewise.
13031 (Fgnutls_boot): Return handshake error code.
13032 (emacs_gnutls_handle_error): New function.
13033 (wsaerror_to_errno): Likewise.
13034
13035 * w32.h (emacs_gnutls_pull): Add prototype.
13036 (emacs_gnutls_push): Likewise.
13037
13038 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
13039 (emacs_gnutls_push): Likewise.
13040
130412011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
13042
13043 * process.c (wait_reading_process_output): Check if GnuTLS
13044 buffered some data internally if no FDs are set for TLS
13045 connections.
13046
13047 * makefile.w32-in (OBJ2): Add gnutls.$(O).
13048 (LIBS): Link to USER_LIBS.
13049 ($(BLD)/gnutls.$(0)): New target.
13050
fa6996bc
EZ
130512011-04-24 Eli Zaretskii <eliz@gnu.org>
13052
eb35682e
EZ
13053 * xdisp.c (handle_single_display_spec): Rename the
13054 display_replaced_before_p argument into display_replaced_p, to
13055 make it consistent with the commentary. Fix typos in the
13056 commentary.
13057
e2ad650c
EZ
13058 * textprop.c (syms_of_textprop): Remove dead code.
13059 (copy_text_properties): Delete obsolete commentary about an
13060 interface that was deleted long ago. Fix typos in the description
13061 of arguments.
13062
1b2de274
EZ
13063 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
13064 to changes in oldXMenu/XMenu.h from 2011-04-16.
13065 <menu_help_message, prev_menu_help_message>: Constify.
13066 (IT_menu_make_room): menu->help_text is now `const char **';
13067 adjust.
13068
13069 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
13070 to changes in oldXMenu/XMenu.h from 2011-04-16.
13071 (struct XMenu): Declare `help_text' `const char **'.
13072
13073 * xfaces.c <Qunspecified>: Make extern again.
13074
13075 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 13076 required by POSIX.
1b2de274 13077
762b15be
EZ
13078 * doc.c (get_doc_string): Improve the format passed to `error'.
13079
13080 * doprnt.c (doprnt): Improve commentary.
13081
13082 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
13083
13084 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
13085 them with etags.
13086
f1052e5d
EZ
13087 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
13088 changes in globals.h immediately force recompilation.
762b15be
EZ
13089 (TAGS): Depend on $(CURDIR)/m/intel386.h and
13090 $(CURDIR)/s/ms-w32.h.
13091 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 13092
fa6996bc
EZ
13093 * character.c (Fchar_direction): Function deleted.
13094 (syms_of_character): Don't defsubr it.
13095 <char-direction-table>: Deleted.
13096
e6c3da20
EZ
130972011-04-23 Eli Zaretskii <eliz@gnu.org>
13098
13099 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
13100 * doprnt.c: Include limits.h.
13101 (SIZE_MAX): New macro.
04f2d78b
CB
13102 (doprnt): Return a size_t value. 2nd arg is now size_t.
13103 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
13104 Improve overflow protection. Support `l' modifier for integer
13105 conversions. Support %l conversion. Don't assume an EMACS_INT
13106 argument for integer conversions and for %c.
13107
13108 * lisp.h (doprnt): Restore prototype.
13109
13110 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
13111 $(SRC)/character.h.
13112
13113 * Makefile.in (base_obj): Add back doprnt.o.
13114
13115 * deps.mk (doprnt.o): Add back prerequisites.
13116 (callint.o): Depend on character.h.
13117
13118 * eval.c (internal_lisp_condition_case): Include the handler
13119 representation in the error message.
13120 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13121 when breaking from the loop.
13122
13123 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13124
13125 * callint.c (Fcall_interactively): When displaying error message
13126 about invalid control letter, pass the character's codepoint, not
13127 a pointer to its multibyte form. Improve display of the character
13128 in octal and display also its hex code.
13129
13130 * character.c (char_string): Use %x to display the (unsigned)
13131 codepoint of an invalid character, to avoid displaying a bogus
13132 negative value.
13133
13134 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13135 `error', not SYMBOL_NAME itself.
13136
13137 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13138 character arguments to `error'.
13139
13140 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13141 to `error' in error message about FINAL_CHAR argument. Make sure
13142 FINAL_CHAR is a character, and use %c when it is passed as
13143 argument to `error'.
13144
4ffd0d6b 131452011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13146
13147 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13148
13149 * w32.c: Include <time.h>.
13150 (sys_localtime): New function.
13151
4ffd0d6b 131522011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13153
13154 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13155
4ffd0d6b 13156 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13157
4ffd0d6b 131582011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13159
4ffd0d6b
GM
13160 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13161 zombies (Bug#8467).
aac0c6e3 13162
04c56954
EZ
131632011-04-19 Eli Zaretskii <eliz@gnu.org>
13164
13165 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13166 gl_state.e_property when gl_state.object is Qt.
13167
13168 * insdel.c (make_gap_larger): Remove limitation of buffer size
13169 to <= INT_MAX.
13170
16a43933
CY
131712011-04-18 Chong Yidong <cyd@stupidchicken.com>
13172
13173 * xdisp.c (lookup_glyphless_char_display)
13174 (produce_glyphless_glyph): Handle cons cell entry in
13175 glyphless-char-display.
13176 (Vglyphless_char_display): Document it.
13177
13178 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13179 glyphless-char-display.
13180
4581706e
CY
131812011-04-17 Chong Yidong <cyd@stupidchicken.com>
13182
13183 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13184
13185 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13186
13187 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13188 definition for no-X builds.
13189
4887c6e2 131902011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13191
fd35b6f9
PE
13192 Static checks with GCC 4.6.0 and non-default toolkits.
13193
5c1ccb01
PE
13194 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13195
006c5daa
PE
13196 * process.c (keyboard_bit_set): Define only if SIGIO.
13197 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13198 (send_process): Repair possible setjmp clobbering.
13199
efc736d3
PE
13200 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13201
4e2fe2e6
PE
13202 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13203
f97334a2
PE
13204 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13205
4e75f29d
PE
13206 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13207 Define only if needed.
13208
90efadd1
PE
13209 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13210 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13211 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13212
3c647824
PE
13213 * dispextern.h (struct redisplay_interface): Rename param
13214 to avoid shadowing.
e264f262 13215 * termhooks.h (struct terminal): Likewise.
761383f4 13216 * xterm.c (xembed_send_message): Likewise.
3c647824 13217
b58c5c4a
PE
13218 * insdel.c (make_gap_smaller): Define only if
13219 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13220
cad59032
PE
13221 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13222 it.
13223
c339dc2e
PE
13224 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13225 so that we aren't warned about unused symbols.
13226
91a3e27b
PE
13227 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13228
399c71d3 13229 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13230
8ffc96f5
PE
13231 * xfns.c (x_real_positions): Mark locals as initialized.
13232
eef9bc79
PE
13233 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13234
098db9dd
PE
13235 * xterm.c: Fix problems found by static analysis with other toolkits.
13236 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13237 (x_dispatch_event): Declare static if USE_GTK, and
13238 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13239 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13240 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13241 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13242 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13243
eb18f6cc
PE
13244 * xmenu.c (menu_help_callback): Pointer type fixes.
13245 Use const pointers when pointing at readonly data. Avoid pointer
13246 signedness clashes.
13247 (FALSE): Remove unused macro.
13248 (update_frame_menubar): Remove unused decl.
13249
1fe72bf8
PE
13250 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13251
60d9e1db
PE
13252 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13253 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13254 (single_menu_item): Rename local to avoid shadowing.
13255
39261c26
PE
13256 * keyboard.c (make_lispy_event): Remove unused local var.
13257
018c5e19
PE
13258 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13259 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13260
63d2b86e
PE
13261 * bitmaps: Change bitmaps from unsigned char back to the X11
13262 compatible char. Avoid the old compiler warnings about
13263 out-of-range initializers by using, for example, '\xab' rather
13264 than 0xab.
13265
aefd87e1
PE
13266 * xgselect.c (xgselect_initialize): Check vs interface
13267 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13268
bf501fb9
PE
13269 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13270
e9829fdf
PE
13271 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13272 to read-only memory.
13273
1086c095
PE
13274 * fns.c (vector): Remove; this old hack is no longer needed.
13275
2baccd04 13276 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13277 Remove unused var.
dde42981 13278 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13279
72391843 13280 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13281
436c16df 13282 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13283 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13284 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13285
92bb796d 13286 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13287 (x_term_init): Remove local to avoid shadowing.
92bb796d 13288
764430a3 13289 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13290
13291 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13292 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13293
d1dfb56c
EZ
132942011-04-16 Eli Zaretskii <eliz@gnu.org>
13295
c4354cb4
EZ
13296 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13297
d1dfb56c
EZ
13298 Fix regex.c, syntax.c and friends for buffers > 2GB.
13299 * syntax.h (struct gl_state_s): Declare character position members
13300 EMACS_INT.
13301
13302 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13303
04f2d78b
CB
13304 * textprop.c (verify_interval_modification, interval_of):
13305 Declare arguments EMACS_INT.
d1dfb56c
EZ
13306
13307 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13308 EMACS_INT.
13309
13310 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13311
13312 * indent.c (Fvertical_motion): Local variable it_start is now
13313 EMACS_INT.
13314
13315 * regex.c (re_match, re_match_2, re_match_2_internal)
13316 (bcmp_translate, regcomp, regexec, print_double_string)
13317 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13318 (re_compile_pattern, re_exec): Declare arguments and local
13319 variables `size_t' and `ssize_t' and return values `regoff_t', as
13320 appropriate.
13321 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13322 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13323 <compile_stack_type>: `size' and `avail' are now `size_t'.
13324
13325 * regex.h <regoff_t>: Use ssize_t, not int.
13326 (re_search, re_search_2, re_match, re_match_2): Arguments that
13327 specify buffer/string position and length are now ssize_t and
13328 size_t. Return type is regoff_t.
13329
613052cd
BK
133302011-04-16 Ben Key <bkey76@gmail.com>
13331
13332 * nsfont.m: Fixed bugs in ns_get_family and
13333 ns_descriptor_to_entity that were caused by using free to
13334 deallocate memory blocks that were allocated by xmalloc (via
13335 xstrdup). This caused Emacs to crash when compiled with
13336 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13337 --enable-checking=xmallocoverrun). xfree is now used to
13338 deallocate these memory blocks.
13339
4170f62f 133402011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13341
71b41406
PE
13342 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13343
9587a89d
PE
13344 emacs_write: Accept and return EMACS_INT for sizes.
13345 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13346 et seq.
13347 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13348 Accept and return EMACS_INT.
13349 (emacs_gnutls_write): Return the number of bytes written on
13350 partial writes.
13351 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13352 (emacs_read, emacs_write): Remove check for negative size, as the
13353 Emacs source code has been audited now.
9587a89d
PE
13354 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13355 (emacs_read, emacs_write): Use it.
273a5f82
PE
13356 * process.c (send_process): Adjust to the new signatures of
13357 emacs_write and emacs_gnutls_write. Do not attempt to store
13358 a byte offset into an 'int'; it might overflow.
9587a89d 13359 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13360
3e047f51
PE
13361 * sound.c: Don't assume sizes fit in 'int'.
13362 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13363 Return EMACS_INT, not int.
3e047f51 13364 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13365 Accept EMACS_INT, not int.
13366 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13367 record read return values.
13368
cc39a9db
BK
133692011-04-15 Ben Key <bkey76@gmail.com>
13370
c9d0ec6d
JB
13371 * keyboard.c (Qundefined): Don't declare static since it is used
13372 in nsfns.m.
13373 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13374 static since they are used in nsfont.m.
cc39a9db 13375
6c60eb9f
SM
133762011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13377
13378 * process.c (Qprocessp): Don't declare static.
13379 * lisp.h (Qprocessp): Declare again.
13380
7990b61a
JB
133812011-04-15 Juanma Barranquero <lekktu@gmail.com>
13382
13383 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13384
5d4cb038
PE
133852011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13386
8bd7b830 13387 Improve C-level modularity by making more things 'static'.
cd64ea1d 13388
e3b27b31
PE
13389 Don't publish debugger-only interfaces to other modules.
13390 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13391 (verify_bytepos, count_markers): Move decls to the only modules
13392 that need them.
13393 * region-cache.h (pp_cache): Likewise.
13394 * window.h (check_all_windows): Likewise.
13395 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13396
5d4cb038
PE
13397 * sysdep.c (croak): Now static, if
13398 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13399 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13400
13401 * alloc.c (refill_memory_reserve): Now static if
13402 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13403 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13404
e87b6180
PE
13405 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13406 Define only if USE_LUCID.
13407
ac64929e
PE
13408 * xrdb.c (x_customization_string, x_rm_string): Now static.
13409
6f37259d
PE
13410 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13411 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13412
1683e3ab
PE
13413 * xdisp.c (draw_row_with_mouse_face): Now static.
13414 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13415
de9c2632
PE
13416 * window.h (check_all_windows): Mark externally visible.
13417
2b96acb7
PE
13418 * window.c (window_deletion_count): Now static.
13419
13420 * undo.c: Make symbols static if they're not exported.
13421 (last_undo_buffer, last_boundary_position, pending_boundary):
13422 Now static.
13423
50436f33
PE
13424 * textprop.c (interval_insert_behind_hooks): Now static.
13425 (interval_insert_in_front_hooks): Likewise.
13426
64520e5c
PE
13427 * term.c: Make symbols static if they're not exported.
13428 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13429 (max_frame_lines, tty_set_terminal_modes):
13430 (tty_reset_terminal_modes, tty_turn_off_highlight):
13431 (get_tty_terminal): Now static.
13432 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13433 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13434 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13435 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13436 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13437
1fa53021
PE
13438 * sysdep.c: Make symbols static if they're not exported.
13439 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13440 Now static.
13441 (sigprocmask_set, full_mask): Remove; unused.
13442 (wait_debugging): Mark as visible.
13443 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13444 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13445
d4b43b22
PE
13446 * syntax.c (syntax_temp): Define only if !__GNUC__.
13447
b7c513d0
PE
13448 * sound.c (current_sound_device, current_sound): Now static.
13449
989b29ad
PE
13450 * search.c (searchbufs, searchbuf_head): Now static.
13451
13a55a78
PE
13452 * scroll.c (scroll_cost): Remove; unused.
13453 * dispextern.h (scroll_cost): Remove decl.
13454
de68a1fc
PE
13455 * region-cache.h (pp_cache): Mark as externally visible.
13456
40ccffa6
PE
13457 * process.c: Make symbols static if they're not exported.
13458 (process_tick, update_tick, create_process, chan_process):
13459 (Vprocess_alist, proc_buffered_char, datagram_access):
13460 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13461 (deactivate_process): Mark defn as static, as well as decl.
13462 * lisp.h (create_process): Remove decl.
13463 * process.h (chan_process, Vprocess_alist): Remove decls.
13464
ad64fc97
PE
13465 * print.c: Make symbols static if they're not exported.
13466 (print_depth, new_backquote_output, being_printed, print_buffer):
13467 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13468 (print_interval, print_number_index, initial_stderr_stream):
13469 Now static.
13470 * lisp.h (Fprinc): Remove decl.
13471 (debug_output_compilation_hack): Mark as externally visible.
13472
adddb265
PE
13473 * sysdep.c (croak): Move decl from here to syssignal.h.
13474 * syssignal.h (croak): Put it here, so the API can be checked when
13475 'croak' is called from dissociate_if_controlling_tty.
13476
1717ede2
PE
13477 * minibuf.c: Make symbols static if they're not exported.
13478 (minibuf_save_list, choose_minibuf_frame): Now static.
13479 * lisp.h (choose_minibuf_frame): Remove decl.
13480
fa5fb2bc
PE
13481 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13482
1e3890d1
PE
13483 * lread.c: Make symbols static if they're not exported.
13484 (read_objects, initial_obarray, oblookup_last_bucket_number):
13485 Now static.
13486 (make_symbol): Remove; unused.
13487 * lisp.h (initial_obarray, make_symbol): Remove decls.
13488
8a1414fa
PE
13489 * keyboard.c: Make symbols static if they're not exported.
13490 (single_kboard, recent_keys_index, total_keys, recent_keys):
13491 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13492 (this_single_command_key_start, echoing, last_auto_save):
13493 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13494 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13495 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13496 (Vlispy_mouse_stem, double_click_count):
13497 Now static.
13498 (force_auto_save_soon): Define only if SIGDANGER.
13499 (ignore_mouse_drag_p): Now static if
13500 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13501 (print_help): Remove; unused.
13502 (stop_character, last_timer_event): Mark as externally visible.
13503 * keyboard.h (ignore_mouse_drag_p): Declare only if
13504 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13505 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13506 * lisp.h (echoing): Remove decl.
13507 (force_auto_save_soon): Declare only if SIGDANGER.
13508 * xdisp.c (redisplay_window): Simplify code, to make it more
13509 obvious that ignore_mouse_drag_p is not accessed if !defined
13510 USE_GTK && !defined HAVE_NS.
13511
93ea6e8f
PE
13512 * intervals.c: Make symbols static if they're not exported.
13513 (merge_properties_sticky, merge_interval_right, delete_interval):
13514 Now static.
13515 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13516
77382fcc
PE
13517 * insdel.c: Make symbols static if they're not exported.
13518 However, leave prepare_to_modify_buffer alone. It's never
13519 called from outside this function, but that appears to be a bug.
13520 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13521 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13522 (adjust_after_replace_noundo): Remove; unused.
13523 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13524 (signal_before_change): Remove decls.
77382fcc 13525
9306c32e
PE
13526 * indent.c (val_compute_motion, val_vmotion): Now static.
13527
cd44d2eb
PE
13528 * image.c: Make symbols static if they're not exported.
13529 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13530 if USE_GTK.
13531 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13532 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13533
ad9a7a06
PE
13534 * fringe.c (standard_bitmaps): Now static.
13535 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13536
81626931
PE
13537 * frame.c: Make symbols static if they're not exported.
13538 (x_report_frame_params, make_terminal_frame): Now static.
13539 (get_frame_param): Now static, unless HAVE_NS.
13540 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13541 (x_get_resource_string): Remove; not used.
13542 * frame.h (make_terminal_frame, x_report_frame_params):
13543 (x_get_resource_string); Remove decls.
13544 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13545 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13546
239f9db9
PE
13547 * font.c, fontset.c: Make symbols static if they're not exported.
13548 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13549 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13550 * font.c (font_close_object): Now static.
13551 * font.h (font_close_object): Remove.
13552 * fontset.c (FONTSET_OBJLIST): Remove.
13553 (free_realized_fontset) #if-0 the body, which does nothing.
13554 (face_suitable_for_char_p): #if-0, as it's never called.
13555 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13556 * xfaces.c (face_at_string_position):
13557 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13558 since 0 is always ASCII.
13559
dfcf3579
PE
13560 * fns.c (weak_hash_tables): Now static.
13561
5045092b
PE
13562 * fileio.c: Make symbols static if they're not exported.
13563 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13564 (Vwrite_region_annotation_buffers): Now static.
13565
57a96f5c
PE
13566 * eval.c: Make symbols static if they're not exported.
13567 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13568 * lisp.h (backtrace_list): Remove decl.
13569
35f08c38
PE
13570 * emacs.c: Make symbols static if they're not exported.
13571 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13572 (fatal_error_code, fatal_error_signal_hook, standard_args):
13573 Now static.
13574 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13575 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13576 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13577 * lisp.h (fatal_error_signal_hook): Remove decl.
13578 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13579
f44bd759
PE
13580 * editfns.c: Move a (normally-unused) function to its only use.
13581 * editfns.c, lisp.h (get_operating_system_release): Remove.
13582 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13583 worth the hassle of breaking this out.
13584
b532497d
PE
13585 * xterm.c: Make symbols static if they're not exported.
13586 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13587 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13588 (x_destroy_window, x_delete_display):
13589 Now static.
13590 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13591 (x_mouse_leave): Remove; unused.
13592 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13593 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13594 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13595 Remove decls.
13596 (x_mouse_leave): Declare only if WINDOWSNT.
13597 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13598 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13599 USE_X_TOOLKIT.
13600
1675728f
PE
13601 * ftxfont.c: Make symbols static if they're not exported.
13602 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13603 HAVE_FREETYPE.
13604 * font.h (ftxfont_driver): Likewise.
13605
e4cebfca
PE
13606 * xfns.c: Make symbols static if they're not exported.
13607 (x_last_font_name, x_display_info_for_name):
13608 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13609 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13610 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13611 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13612 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13613 (last_show_tip_args): Now static.
13614 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13615 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13616 (x_screen_planes): Remove; unused.
13617 * dispextern.h (x_screen_planes): Remove decl.
13618
5bf46f05
PE
13619 * dispnew.c: Make symbols static if they're not exported.
13620 * dispextern.h (redraw_garbaged_frames, scrolling):
13621 (increment_row_positions): Remove.
13622 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13623 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13624 Now static.
13625 (redraw_garbaged_frames): Remove; unused.
13626
435f4c28
PE
13627 * xfaces.c: Make symbols static if they're not exported.
13628 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13629 Remove decls.
13630 * xterm.h (defined_color): Remove decls.
13631 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13632 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13633 (menu_face_changed_default, defined_color, free_realized_face):
13634 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13635 (ascii_face_of_lisp_face): Remove; unused.
13636
8524aef3
PE
13637 * xdisp.c: Make symbols static if they're not exported.
13638 * dispextern.h (scratch_glyph_row, window_box_edges):
13639 (glyph_to_pixel_coords, set_cursor_from_row):
13640 (get_next_display_element, set_iterator_to_next):
13641 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13642 (show_mouse_face): Remove decls
13643 * frame.h (message_buf_print): Likewise.
13644 * lisp.h (pop_message, set_message, check_point_in_composition):
13645 Likewise.
13646 * xterm.h (set_vertical_scroll_bar): Likewise.
13647 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13648 (message_buf_print, scratch_glyph_row, displayed_buffer):
13649 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13650 (get_next_display_element, show_mouse_face, window_box_edges):
13651 (frame_to_window_pixel_xy, check_point_in_composition):
13652 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13653 (glyph_to_pixel_coords): Remove; unused.
13654
16390cd2
PE
13655 * dired.c (file_name_completion): Now static.
13656
13657 * dbusbind.c (xd_in_read_queued_messages): Now static.
13658
a25f4dfa
PE
13659 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13660 * data.c (circular_list_error): Remove.
13661
14a9c8df
PE
13662 * commands.h (last_point_position, last_point_position_buffer):
13663 (last_point_position_window): Remove decls.
13664 * keyboard.c: Make these variables static.
13665
04f2d78b
CB
13666 * coding.h (coding, code_convert_region, encode_coding_gap):
13667 Remove decls.
74ab6df5
PE
13668 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13669 (iso_code_class, detect_coding, code_convert_region): Now static.
13670 (encode_coding_gap): Remove; unused.
13671
38dfbee1
PE
13672 * chartab.c (chartab_chars, chartab_bits): Now static.
13673
a2cb4e63
PE
13674 * charset.h (charset_iso_8859_1): Remove decl.
13675 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13676 Now static.
13677
127198fd
PE
13678 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13679 * ccl.c (Vccl_program_table): Now static.
13680 (check_ccl_update): Remove; unused.
13681
d85b608f
PE
13682 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13683 * category.h: ... from here.
13684 * category.c (check_category_table, set_category_set): Now static.
13685
31cd66f3
PE
13686 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13687 * lisp.h: Remove these decls.
13688
c358e587
PE
13689 * buffer.c (buffer_count): Remove unused var.
13690
e78aecca
PE
13691 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13692 so that it's not optimized away.
13693 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13694 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13695 exported only to the debugger.
13696
e192d7d3 13697 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13698 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13699
92470028
PE
13700 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13701 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13702 was inaccessible from Lisp.
13703 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13704 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13705
244ed907
PE
13706 alloc.c: Import and export fewer symbols, and remove unused items.
13707 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13708 is defined.
13709 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13710 it's not optimized away by whole-program optimization.
13711 (message_enable_multibyte, free_misc): Remove.
13712 (catchlist, handlerlist, mark_backtrace):
13713 Declare only if BYTE_MARK_STACK.
13714 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13715 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13716 (message_enable_multibyte): Remove decl.
13717 (free_misc, interval_free_list, float_block, float_block_index):
13718 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13719 (cons_free_list, last_marked_index):
13720 Now static.
13721 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13722 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13723 (mark_backtrace): Define only if BYTE_MARK_STACK.
13724 * xdisp.c (message_enable_multibyte): Now static.
13725
61c2b50e 13726 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13727 This makes it easier for human readers (and static analyzers)
13728 to see whether these variables are used from other modules.
13729 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13730 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13731 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13732 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13733 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13734 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13735 * xmenu.c, xselect.c:
13736 Declare Q* vars static if they are not used in other modules.
13737 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13738 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13739 Remove decls of unexported vars.
13740 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13741
95c82688
PE
13742 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13743
16a97296
PE
13744 Make Emacs functions such as Fatom 'static' by default.
13745 This makes it easier for human readers (and static analyzers)
13746 to see whether these functions can be called from other modules.
13747 DEFUN now defines a static function. To make the function external
13748 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13749 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13750 (Finit_image_library):
16a97296
PE
13751 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13752 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13753 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13754 Remove decls, since these functions are now static.
13755 (Funintern, Fget_internal_run_time): New decls, since these functions
13756 were already external.
95c82688 13757
16a97296
PE
13758 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13759 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13760 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13761 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13762 * keyboard.c, keymap.c, lread.c:
13763 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13764 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13765 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13766 Mark functions with DEFUE instead of DEFUN,
13767 if they are used in other modules.
13768 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13769 decls for now-static functions.
13770 * buffer.h (Fdelete_overlay): Remove decl.
13771 * callproc.c (Fgetenv_internal): Mark as internal.
13772 * composite.c (Fremove_list_of_text_properties): Remove decl.
13773 (Fcomposition_get_gstring): New forward static decl.
13774 * composite.h (Fcomposite_get_gstring): Remove decl.
13775 * dired.c (Ffile_attributes): New forward static decl.
13776 * doc.c (Fdocumntation_property): New forward static decl.
13777 * eval.c (Ffetch_bytecode): New forward static decl.
13778 (Funintern): Remove extern decl; now in .h file where it belongs.
13779 * fileio.c (Fmake_symbolic_link): New forward static decl.
13780 * image.c (Finit_image_library): New forward static decl.
13781 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13782 * intervals.h (Fprevious_property_change):
13783 (Fremove_list_of_text_properties): Remove decls.
13784 * keyboard.c (Fthis_command_keys): Remove decl.
13785 (Fcommand_execute): New forward static decl.
13786 * keymap.c (Flookup_key): New forward static decl.
13787 (Fcopy_keymap): Now static.
13788 * keymap.h (Flookup_key): Remove decl.
13789 * process.c (Fget_process): New forward static decl.
13790 (Fprocess_datagram_address): Mark as internal.
13791 * syntax.c (Fsyntax_table_p): New forward static decl.
13792 (skip_chars): Remove duplicate decl.
13793 * textprop.c (Fprevious_property_change): New forward static decl.
13794 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13795 Now internal.
13796 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13797 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13798
785bbd42
PE
13799 * editfns.c (Fformat): Remove unreachable code.
13800
8b913b57
AS
138012011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13802
13803 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13804 change. (Bug#8496)
13805
a6744a35
EZ
138062011-04-13 Eli Zaretskii <eliz@gnu.org>
13807
13808 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13809 when at ZV. (Bug#8487)
13810
e7974947
AS
138112011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13812
baad03f0
AS
13813 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13814 (Bug#8437)
13815 * keyboard.c (parse_tool_bar_item): Likewise.
13816 * sound.c (sound_cleanup, alsa_close): Likewise.
13817 * termcap.c (tgetent): Likewise.
13818 * xfns.c (x_default_font_parameter): Likewise.
13819 * xsettings.c (read_and_apply_settings): Likewise.
13820
e7974947
AS
13821 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13822 (overrun_check_free): Protoize.
13823
28272684
PE
138242011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13825
13826 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13827 since callers should never pass a negative size.
13828 Change the signature to match that of plain 'read' and 'write'; see
13829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13830 * lisp.h: Update prototypes of emacs_write and emacs_read.
13831
11997c76
EZ
138322011-04-11 Eli Zaretskii <eliz@gnu.org>
13833
13834 * xdisp.c (redisplay_window): Don't try to determine the character
13835 position of the scroll margin if the window start point w->startp
e896f03c 13836 is outside the buffer's accessible region. (Bug#8468)
11997c76 13837
8a2cbd72
EZ
138382011-04-10 Eli Zaretskii <eliz@gnu.org>
13839
13840 Fix write-region and its subroutines for buffers > 2GB.
13841 * fileio.c (a_write, e_write): Modify declaration of arguments and
13842 local variables to support buffers larger than 2GB.
13843 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13844
13845 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13846 argument, local variables, and return value.
13847
13848 * lisp.h: Update prototypes of emacs_write and emacs_read.
13849
13850 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13851
4073e537 138522011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13853
1ebfdcb6
PE
13854 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13855
b2ded58d
PE
13856 Fix more problems found by GCC 4.6.0's static checks.
13857
7d66342c
PE
13858 * xdisp.c (vmessage): Use a better test for character truncation.
13859
bbf47d44
PE
13860 * charset.c (load_charset_map): <, not <=, for optimization,
13861 and to avoid potential problems with integer overflow.
9248994d 13862 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13863 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13864 * editfns.c (Fformat): Likewise.
1e69125e 13865 * syntax.c (skip_chars): Likewise.
3befa583 13866
e3019616
PE
13867 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13868 This also lets GCC 4.6.0 generate slightly better loop code.
13869
becfa255
PE
13870 * callint.c (Fcall_interactively): <, not <=, for optimization.
13871 (Fcall_interactively): Count the number of arguments produced,
13872 not the number of arguments given. This is simpler and lets GCC
13873 4.6.0 generate slightly better code.
13874
dae0cd48
PE
13875 * ftfont.c: Distingish more carefully between FcChar8 and char.
13876 The previous code passed unsigned char * to a functions like
13877 strlen and xstrcasecmp that expect char *, which does not
13878 conform to the C standard.
13879 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13880 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13881 char * when the C standard requires it.
13882
76032d70
PE
13883 * keyboard.c (read_char): Remove unused var.
13884
eb3f1cc8
PE
13885 * eval.c: Port to Windows vsnprintf (Bug#8435).
13886 Include <limits.h>.
13887 (SIZE_MAX): Define if the headers do not.
13888 (verror): Do not give up if vsnprintf returns a negative count.
13889 Instead, grow the buffer. This ports to Windows vsnprintf, which
13890 does not conform to C99. Problem reported by Eli Zaretskii.
13891 Also, simplify the allocation scheme, by avoiding the need for
13892 calling realloc, and removing the ALLOCATED variable.
13893
70476b54
PE
13894 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13895
12020a9e
PE
13896 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13897 But keep the doprint source code for now, as we might revamp it
13898 and use it again (Bug#8435).
ea6c7ae6
PE
13899 * lisp.h (doprnt): Remove.
13900 * Makefile.in (base_obj): Remove doprnt.o.
13901 * deps.mk (doprnt.o): Remove.
13902
5fdb398c
PE
13903 error: Print 32- and 64-bit integers portably (Bug#8435).
13904 Without this change, on typical 64-bit hosts error ("...%d...", N)
13905 was used to print both 32- and 64-bit integers N, which relied on
13906 undefined behavior.
61bdb816 13907 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13908 * lisp.h (error, verror): Mark as printf-like functions.
13909 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13910 Report overflow in size calculations when allocating printf buffer.
13911 Do not truncate output string at its first null byte.
13912 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13913 Truncate the output at a character boundary, since vsnprintf does not
13914 do that.
13915 * charset.c (check_iso_charset_parameter): Convert internal
13916 character to string before calling 'error', since %c now has the
13917 printf meaning.
13918 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13919 overflow when computing char to be passed to 'error'. Do not
13920 pass Lisp_Object to 'error'; pass the integer instead.
13921 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13922 formatted with plain %d.
13923
b189fa66
PE
13924 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13925
bff87ef0
PE
13926 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13927
7e2cac20
PE
13928 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13929
ce4d90b5
PE
13930 * xterm.c (x_catch_errors): Remove duplicate declaration.
13931
266c9547
PE
13932 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13933
79c49ad2
PE
13934 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13935
368f4090
JM
139362011-04-10 Jim Meyering <meyering@redhat.com>
13937
13938 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13939 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13940 return ssize_t not "int", and use size_t as the buffer length.
13941 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13942 * gnutls.h: Update declarations.
13943 * process.c (read_process_output): Use ssize_t, to match.
13944 (send_process): Likewise.
13945
a32d4040
CY
139462011-04-09 Chong Yidong <cyd@stupidchicken.com>
13947
13948 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13949
8546720e 139502011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13951
04f2d78b
CB
13952 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13953 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13954
8546720e
GM
13955 * xterm.c (handle_one_xevent):
13956 * xmenu.c (create_and_show_popup_menu):
13957 * xselect.c (x_decline_selection_request)
13958 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13959
0a2f5c1a 139602011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13961
13962 Fix some uses of `int' instead of EMACS_INT.
13963 * search.c (string_match_1, fast_string_match)
13964 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13965 (scan_buffer, find_next_newline_no_quit)
13966 (find_before_next_newline, search_command, Freplace_match)
13967 (Fmatch_data): Make some `int' variables be EMACS_INT.
13968
13969 * xdisp.c (display_count_lines): 3rd argument and return value now
13970 EMACS_INT. All callers changed.
13971 (pint2hrstr): Last argument is now EMACS_INT.
13972
13973 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13974 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13975 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13976 (decode_coding_utf_16, decode_coding_emacs_mule)
13977 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13978 (decode_coding_ccl, decode_coding_charset)
13979 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13980 (decode_coding_iso_2022, decode_coding_emacs_mule)
13981 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13982 <char_offset, last_offset>: Declare EMACS_INT.
13983 (encode_coding_utf_8, encode_coding_utf_16)
13984 (encode_coding_emacs_mule, encode_invocation_designation)
13985 (encode_designation_at_bol, encode_coding_iso_2022)
13986 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13987 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13988 Declare EMACS_INT.
13989 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13990 (encode_invocation_designation): Last argument P_NCHARS is now
13991 EMACS_INT.
13992 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13993 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13994
13995 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13996 All users changed.
13997
13998 * ccl.c (Fccl_execute_on_string): Declare some variables
13999 EMACS_INT.
14000
8546720e 140012011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
14002
14003 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
14004
4e19a977
CS
140052011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
14006
14007 * process.c (Fformat_network_address): Doc fix.
14008
87302331
R
140092011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
14010
ee7683eb 14011 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 14012
cbb59342
CY
140132011-04-08 Chong Yidong <cyd@stupidchicken.com>
14014
14015 * keyboard.c (read_char): Call Lisp function help-form-show,
14016 instead of using internal_with_output_to_temp_buffer.
14017 (Qhelp_form_show): New var.
e0d38eeb 14018 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
14019
14020 * print.c (internal_with_output_to_temp_buffer): Function deleted.
14021
14022 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
14023
e67a13ab
CY
140242011-04-06 Chong Yidong <cyd@stupidchicken.com>
14025
04f2d78b
CB
14026 * process.c (Flist_processes): Remove to Lisp.
14027 (list_processes_1): Delete.
e67a13ab 14028
973f782d
EZ
140292011-04-06 Eli Zaretskii <eliz@gnu.org>
14030
7c106b1e
EZ
14031 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
14032
973f782d
EZ
14033 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
14034
41cf7d1a 140352011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 14036
ca23cc88
PE
14037 Fix more problems found by GCC 4.6.0's static checks.
14038
f390e2d5
PE
14039 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
14040
42eea0d0
PE
14041 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
14042
b69769da 14043 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 14044
f9541e84
PE
14045 * xdisp.c (vmessage): Mark as a printf-like function.
14046
13841b55
PE
14047 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
14048
c136c10f
PE
14049 * sound.c (sound_warning): Don't crash if arg contains a printf format.
14050
5e2d4a30
PE
14051 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
14052 printf-like functions.
14053 (tiff_load): Add casts to remove these marks before passing them
14054 to system-supplied API.
14055
583f48b9
PE
14056 * eval.c (Fsignal): Remove excess argument to 'fatal'.
14057
b25d760e
PE
14058 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
14059 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
14060 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
14061 directly, rather than having caller test rule sign. This avoids
14062 some unnecessary tests.
14063 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
14064 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
14065 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 14066
bc7b6697 14067 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 14068 (xfont_open): Avoid unnecessary tests.
bc7b6697 14069
27ccc379
PE
14070 * composite.c (composition_gstring_put_cache): Use unsigned integer.
14071
dcd5c89a
PE
14072 * composite.h, composite.c (composition_gstring_put_cache):
14073 Use EMACS_INT, not int, for length.
14074
b13a45c6
PE
14075 * composite.h (COMPOSITION_DECODE_REFS): New macro,
14076 breaking out part of COMPOSITION_DECODE_RULE.
14077 (COMPOSITION_DECODE_RULE): Use it.
14078 * composite.c (get_composition_id): Remove unused local vars,
14079 by using the new macro.
14080
1e792e4d
PE
14081 * textprop.c (set_text_properties_1): Change while to do-while,
14082 since the condition is always true at first.
14083
dc6c6455 14084 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
14085 (interval_deletion_adjustment): Return unsigned value.
14086 All uses changed.
dc6c6455 14087
aba7731a
PE
14088 * process.c (list_processes_1, create_pty, read_process_output):
14089 (exec_sentinel): Remove vars that were set but not used.
afd4052b 14090 (create_pty): Remove unnecessary "volatile"s.
bc57d757 14091 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 14092 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 14093 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 14094
fdfc4bf3
PE
14095 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
14096
fca8fe46 14097 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 14098 (update_syntax_table): Use unsigned instead of int.
fca8fe46 14099
06a0259a 14100 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 14101 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 14102 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 14103
e7b9e80f
PE
14104 * print.c (print_error_message): Avoid int overflow.
14105
56201685
PE
14106 * font.c (font_list_entities): Redo for clarity,
14107 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
14108
78834453 14109 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 14110 (font_score): Avoid potential overflow in diff calculation.
78834453 14111
0bc0b309 14112 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 14113 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 14114
e610eaca
PE
14115 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14116
b895abce
PE
14117 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14118 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14119 can always succeed if overflow has undefined behavior.
14120
1f1d9321 14121 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14122 (wordify): Omit three unnecessary tests.
1f1d9321 14123
c59478bc
PE
14124 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14125 All callers changed. This avoids the need for an unused var.
14126
79b73827
PE
14127 * casefiddle.c (casify_region): Remove var that is set but not used.
14128
a4db5dfe
PE
14129 * dired.c (file_name_completion): Remove var that is set but not used.
14130
43aae36e
PE
14131 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14132
2a47c44d 14133 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14134 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14135
a37c69bf
PE
14136 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14137 Check for integer overflow on size calculations.
14138
328ab8e7
PE
14139 * buffer.c (Fprevious_overlay_change): Remove var that is set
14140 but not used.
14141
e5a2a5cb
PE
14142 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14143 Remove vars that are set but not used.
8d84a6eb 14144 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14145 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14146
a60e5f68
PE
14147 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14148
f661cb61 14149 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14150 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14151
f0397f5a
PE
14152 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14153 that are set but not used.
14154
8664db06 14155 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14156 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14157
6abdaa4a
PE
14158 * xselect.c (x_get_local_selection, x_handle_property_notify):
14159 Remove vars that are set but not used.
14160
0ce7538d 14161 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14162 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14163
9ae848fc
PE
14164 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14165 Remove var that is set but not used.
0b918413
PE
14166 (scroll_bar_windows_size): Now size_t, not int.
14167 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14168 Check for overflow.
9ae848fc 14169
a5a62657
PE
14170 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14171 (map_tty_color) [!defined MSDOS]: Likewise.
14172
5c5cdd39
PE
14173 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14174
66ebf983
PE
14175 * coding.c: Remove vars that are set but not used.
14176 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14177 All callers changed.
14178 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14179 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14180 (decode_coding_charset): Remove vars that are set but not used.
14181
1be4d761
PE
14182 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14183 that is set but not used.
14184
47553fa8
PE
14185 * print.c (print_object): Remove var that is set but not used.
14186
1f7196bf 14187 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14188 The gnulib version avoids calling malloc in the usual case,
14189 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14190 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14191 * filelock.c (current_lock_owner): Likewise.
14192 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14193 * sysdep.c: Include allocator.h, careadlinkat.h.
14194 (emacs_no_realloc_allocator): New static constant.
14195 (emacs_readlink): New function.
fdb61804
PE
14196 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14197 ../lib/careadlinkat.h.
d1fdcab7 14198
f84c17c7
SM
141992011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14200
14201 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14202 first non-nil return value).
14203
ef3862ad
JD
142042011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14205
14206 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14207 if not defined (Bug#8403).
14208
376a7006
JB
142092011-04-02 Juanma Barranquero <lekktu@gmail.com>
14210
14211 * xdisp.c (display_count_lines): Remove parameter `start',
14212 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14213 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14214 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14215 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14216 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14217 and thereabouts. All callers changed.
14218 (get_per_char_metric): Remove parameter `f', unused since
14219 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14220
6ca3801d
JM
142212011-04-02 Jim Meyering <meyering@redhat.com>
14222
14223 do not dereference NULL upon failed strdup
14224 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14225 (ns_get_family): Likewise.
14226
d8e2b5ba
JB
142272011-04-02 Juanma Barranquero <lekktu@gmail.com>
14228
14229 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14230
8c74fcbd
JD
142312011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14232
14233 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14234 later (Bug#8403).
14235
7200d79c
SM
142362011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14237
03408648 14238 Add lexical binding.
7200d79c 14239
03408648
SM
14240 * window.c (Ftemp_output_buffer_show): New fun.
14241 (Fsave_window_excursion):
14242 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14243
14244 * lread.c (lisp_file_lexically_bound_p): New function.
14245 (Fload): Bind Qlexical_binding.
14246 (readevalloop): Remove `evalfun' arg.
14247 Bind Qinternal_interpreter_environment.
14248 (Feval_buffer): Bind Qlexical_binding.
14249 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14250 Mark as dynamic.
14251 (syms_of_lread): Declare `lexical-binding'.
14252
14253 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14254
14255 * keyboard.c (eval_dyn): New fun.
14256 (menu_item_eval_property): Use it.
ca105506
SM
14257
14258 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14259
03408648
SM
14260 * fns.c (concat, mapcar1): Accept byte-code-functions.
14261
14262 * eval.c (Fsetq): Handle lexical vars.
14263 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14264 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14265 (FletX, Flet): Obey lexical binding.
14266 (Fcommandp): Handle closures.
14267 (Feval): New `lexical' arg.
14268 (eval_sub): New function extracted from Feval. Use it almost
14269 everywhere where Feval was used. Look up vars in lexical env.
14270 Handle closures.
14271 (Ffunctionp): Move from subr.el.
14272 (Ffuncall): Handle closures.
14273 (apply_lambda): Remove `eval_flags'.
14274 (funcall_lambda): Handle closures and new byte-code-functions.
14275 (Fspecial_variable_p): New function.
14276 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14277 but without exporting it to Lisp.
23aba0ea 14278
23aba0ea 14279 * doc.c (Fdocumentation, store_function_docstring):
03408648 14280 * data.c (Finteractive_form): Handle closures.
23aba0ea 14281
03408648
SM
14282 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14283 interactive spec.
ba83908c 14284
04f2d78b
CB
14285 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14286 New byte-codes.
03408648
SM
14287 (exec_byte_code): New function extracted from Fbyte_code to handle new
14288 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14289
03408648 14290 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14291
03408648 14292 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14293
e2abce01
JB
142942011-03-31 Juanma Barranquero <lekktu@gmail.com>
14295
14296 * xdisp.c (redisplay_internal): Fix prototype.
14297
63696a73 142982011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14299
63696a73 14300 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14301 (try_scrolling): Use it when setting scroll_limit.
14302 Limit scrolling to 100 screen lines.
63696a73
EZ
14303 (redisplay_window): Even when falling back on "recentering",
14304 position point in the window according to scroll-conservatively,
14305 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14306
14307 (try_scrolling): When point is above the window, allow searching
14308 as far as scroll_max, or one screenful, to compute vertical
14309 distance from PT to the scroll margin position. This prevents
14310 try_scrolling from unnecessarily failing when
14311 scroll-conservatively is set to a value slightly larger than the
14312 window height. Clean up the case of PT below the margin at bottom
14313 of window: scroll_max can no longer be INT_MAX. When aggressive
14314 scrolling is in use, don't let point enter the opposite scroll
14315 margin as result of the scroll.
14316 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14317 threshold of 100 lines for never-recentering scrolling.
14318
e4cc2dfc
JB
143192011-03-31 Juanma Barranquero <lekktu@gmail.com>
14320
14321 * dispextern.h (move_it_by_lines):
14322 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14323 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14324 (message_log_check_duplicate): Remove parameters `prev_bol' and
14325 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14326 (redisplay_internal): Remove parameter `preserve_echo_area',
14327 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14328
14329 * indent.c (Fvertical_motion):
14330 * window.c (window_scroll_pixel_based, Frecenter):
14331 Don't pass `need_y_p' to `move_it_by_lines'.
14332
1c470562
SM
143332011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14334
44f230aa
SM
14335 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14336 steal a few bits to be more compact.
14337 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14338 Remove unneeded casts.
14339
1c470562
SM
14340 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14341
888adce9
ZK
143422011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14343
14344 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14345 binding" message (bug#7967).
14346
f838ed7b
PE
143472011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14348
77861b95
PE
14349 Fix more problems found by GCC 4.6.0's static checks.
14350
de6dbc14
PE
14351 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14352 Remove unused local var.
14353
f838ed7b
PE
14354 * editfns.c (Fmessage_box): Remove unused local var.
14355
792c7b2b
PE
14356 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14357 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14358 Omit unused local vars.
c499e557 14359 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14360 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14361 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14362 Omit unused local var.
14363
ba0165e1
PE
14364 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14365 Don't assume string length fits in int.
32ad8845 14366 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14367 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14368
3c59b4c9
PE
14369 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14370 instead of alloca (Bug#8344).
14371
a3eed478 14372 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14373 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14374
eb4d412d
PE
14375 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14376
1658b401
PE
14377 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14378 concerns.
14379
14380 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14381
14382 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14383
9a2c6e05
PE
14384 * keyboard.c (syms_of_keyboard): Use the same style as later
14385 in this function when indexing through an array. This also
14386 works around GCC bug 48267.
14387
03d0a109
PE
14388 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14389
44f730c8
PE
14390 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14391
fe75f926
PE
14392 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14393 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14394
ffa8c828
PE
14395 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14396 This avoids undefined behavior on integer overflow, and is a bit
14397 more convenient anyway since it is compared to a size_t variable.
14398
c5101a77
PE
14399 Variadic C functions now count arguments with size_t, not int.
14400 This avoids an unnecessary limitation on 64-bit machines, which
14401 caused (substring ...) to crash on large vectors (Bug#8344).
14402 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14404 All variadic functions and their callers changed accordingly.
c5101a77
PE
14405 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14406 * data.c (arith_driver, float_arith_driver): Likewise.
14407 * editfns.c (general_insert_function): Likewise.
14408 * eval.c (struct backtrace.nargs, interactive_p)
14409 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14410 (funcall_lambda, mark_backtrace): Likewise.
14411 * fns.c (concat): Likewise.
14412 * frame.c (x_set_frame_parameters): Likewise.
14413 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14414 0 if not found, not -1. All callers changed.
14415
dd3f25f7
PE
14416 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14417 (stack_copy_size): Now size_t, not int.
14418 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14419
461c2ab9
JB
144202011-03-28 Juanma Barranquero <lekktu@gmail.com>
14421
14422 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14423 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14424 All callers changed.
14425
14426 * lisp.h (multibyte_char_to_unibyte):
14427 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14428 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14429 * character.h (CHAR_TO_BYTE8):
14430 * cmds.c (internal_self_insert):
14431 * editfns.c (general_insert_function):
14432 * keymap.c (push_key_description):
14433 * search.c (Freplace_match):
14434 * xdisp.c (message_dolog, set_message_1): All callers changed.
14435
f6d62986
SM
144362011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14437
14438 * keyboard.c (safe_run_hook_funcall): New function.
14439 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14440 don't set the hook to nil, but remove the offending function instead.
14441 (Qcommand_hook_internal): Remove, unused.
14442 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14443 Vcommand_hook_internal.
14444
14445 * eval.c (enum run_hooks_condition): Remove.
14446 (funcall_nil, funcall_not): New functions.
14447 (run_hook_with_args): Call each function through a `funcall' argument.
14448 Remove `cond' argument, now redundant.
14449 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14450 (Frun_hook_with_args_until_failure): Adjust accordingly.
14451 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14452
1db5b1ad
JB
144532011-03-28 Juanma Barranquero <lekktu@gmail.com>
14454
14455 * dispextern.h (string_buffer_position): Remove declaration.
14456
14457 * print.c (strout): Remove parameter `multibyte', unused since
14458 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14459
14460 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14461 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14462 All callers changed.
14463
14464 * w32.c (_wsa_errlist): Use braces for struct initializers.
14465
14466 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14467 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14468 All callers changed.
14469 (string_buffer_position): Likewise. Also, make static (it's never
14470 used outside xdisp.c).
14471 (cursor_row_p): Remove parameter `w', unused since
14472 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14473 (decode_mode_spec): Remove parameter `precision', introduced during
14474 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14475 All callers changed.
14476
5ffb62aa
JD
144772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14478
14479 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14480
461c2ab9 144812011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14482
14483 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14484 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14485 (ns_update_auto_hide_menu_bar): New functions.
14486 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14487 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14488 ns_constrain_all_frames.
14489 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14490 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14491
5c380ffb
JD
144922011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14493
14494 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14495
9af30bdf
GM
144962011-03-27 Glenn Morris <rgm@gnu.org>
14497
14498 * syssignal.h: Replace RETSIGTYPE with void.
14499 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14500 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14501 Replace SIGTYPE with void everywhere.
14502 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14503 * s/template.h (SIGTYPE): Remove commented out definition.
14504
e2abce01
JB
145052011-03-26 Eli Zaretskii <eliz@gnu.org>
14506
14507 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14508 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14509
f868cd8a
JB
145102011-03-26 Juanma Barranquero <lekktu@gmail.com>
14511
59eb0929
JB
14512 * w32.c (read_unc_volume): Use parameter `henum', instead of
14513 global variable `wget_enum_handle'.
14514
14515 * keymap.c (describe_vector): Remove parameters `indices' and
14516 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14517 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14518
f868cd8a
JB
14519 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14520
14521 * keyboard.c (timer_check): Remove parameter `do_it_now',
14522 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14523 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14524 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14525
14526 * keyboard.c (read_char):
14527 * w32menu.c (w32_menu_display_help):
14528 * xmenu.c (show_help_event, menu_help_callback):
14529 Adjust calls to `show_help_echo'.
14530
14531 * gtkutil.c (xg_maybe_add_timer):
14532 * keyboard.c (readable_events):
14533 * process.c (wait_reading_process_output):
14534 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14535
14536 * insdel.c (adjust_markers_gap_motion):
14537 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14538 (gap_left, gap_right): Don't call it.
14539
2ecf6fdb
CY
145402011-03-25 Chong Yidong <cyd@stupidchicken.com>
14541
14542 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14543 incurred during fontification.
14544
6b1f9ba4
JB
145452011-03-25 Juanma Barranquero <lekktu@gmail.com>
14546
14547 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14548 (DEFVAR_PER_BUFFER): Don't pass it.
14549
14550 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14551 (scrolling_window): Don't pass it.
14552
0f4a96b5
JB
145532011-03-25 Juanma Barranquero <lekktu@gmail.com>
14554
14555 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14556
14557 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14558 and `suffix'.
14559 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14560 of variables specific to SELinux and computation of `encoded_absname'.
14561
14562 * image.c (XPutPixel): Remove unused variable `height'.
14563
14564 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14565
14566 * unexw32.c (get_section_info): Remove unused variable `section'.
14567
14568 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14569 (system_process_attributes): Remove unused variable `sess'.
14570 (sys_read): Remove unused variable `err'.
14571
14572 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14573 (w32_wnd_proc): Remove unused variable `isdead'.
14574 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14575 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14576 (x_create_tip_frame): Remove unused variable `tem'.
14577
14578 * w32inevt.c (w32_console_read_socket):
14579 Remove unused variable `no_events'.
14580
14581 * w32term.c (x_draw_composite_glyph_string_foreground):
14582 Remove unused variable `width'.
14583
1149507c
JB
145842011-03-24 Juanma Barranquero <lekktu@gmail.com>
14585
14586 * w32term.c (x_set_glyph_string_clipping):
14587 Don't pass uninitialized region to CombineRgn.
14588
9c88f339
JB
145892011-03-23 Juanma Barranquero <lekktu@gmail.com>
14590
14591 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14592 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14593 (Fx_close_connection): Remove unused variable `i'.
14594
14595 * w32font.c (w32font_draw): Return number of glyphs.
14596 (w32font_open_internal): Remove unused variable `i'.
14597 (w32font_driver): Add missing initializer.
14598
14599 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14600 (fill_in_menu): Remove unused variable `items_added'.
14601
14602 * w32term.c (last_mouse_press_frame): Remove static global variable.
14603 (w32_clip_to_row): Remove unused variable `f'.
14604 (x_delete_terminal): Remove unused variable `i'.
14605
14606 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14607 (NOTHING): Remove unused static global variable.
14608 (uniscribe_check_otf): Remove unused variable `table'.
14609 (uniscribe_font_driver): Add missing initializers.
14610
dee091a3
JD
146112011-03-23 Julien Danjou <julien@danjou.info>
14612
14613 * term.c (Fsuspend_tty, Fresume_tty):
14614 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14615 * window.c (temp_output_buffer_show):
14616 * insdel.c (signal_before_change):
14617 * frame.c (Fhandle_switch_frame):
14618 * fileio.c (Fdo_auto_save):
14619 * emacs.c (Fkill_emacs):
14620 * editfns.c (save_excursion_restore):
14621 * cmds.c (internal_self_insert):
14622 * callint.c (Fcall_interactively):
14623 * buffer.c (Fkill_all_local_variables):
14624 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14625 Use Frun_hooks.
0f4a96b5 14626 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14627 unconditionally since it does the check itself.
dee091a3 14628
2c520ab5 146292011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14630
c9c49752
PE
14631 Fix more problems found by GCC 4.5.2's static checks.
14632
8abc3f12
PE
14633 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14634 the first time through the loop, since we know p0 < p1 then.
14635 This also avoids a gcc -Wstrict-overflow warning.
14636
a2d26660
PE
14637 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14638 leading to a memory leak, possible in functions like
14639 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14640 of objects (Bug#8318).
a2d26660 14641
916c72e9
PE
14642 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14643 that could (at least in theory) be that large.
14644
19ab8a18
PE
14645 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14646 This is less likely to overflow, and avoids undefined behavior if
14647 overflow does occur. All callers changed. Use strtoul to scan
14648 for the unsigned long integer.
b7cbbd6f
PE
14649 (pint2hrstr): Simplify and tune code slightly.
14650 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14651
f0641eff
PE
14652 * scroll.c (do_scrolling): Work around GCC bug 48228.
14653 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14654
7f650bb9
PE
14655 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14656 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14657 (validate_x_resource_name): Simplify count usage.
14658 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14659
37dd57d1
PE
14660 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14661 fail (Bug#8306).
81e56e61 14662
699979fc 14663 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14664
401bf9b4
PE
14665 * process.c (Fmake_network_process): Use socklen_t, not int,
14666 where POSIX says socklen_t is required in portable programs.
14667 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14668 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14669 (Fmake_network_process, server_accept_connection):
14670 (wait_reading_process_output, read_process_output):
14671 Likewise.
14672
b93aacde
PE
14673 * process.c: Rename or move locals to avoid shadowing.
14674 (list_processes_1, Fmake_network_process):
14675 (read_process_output_error_handler, exec_sentinel_error_handler):
14676 Rename or move locals.
4dc343ee 14677 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14678 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14679 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14680 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14681 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14682
af8a867c 14683 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14684 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14685 Include tparam.h instead, since it declares them.
af8a867c
PE
14686 * cm.h (PC): Remove extern decl; tparam.h now does this.
14687 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14688 * terminfo.c: Include tparam.h, to check interfaces.
14689 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14690 (tparam): Adjust signature to match interface in tparam.h;
14691 this removes some undefined behavior. Check that outstring and len
14692 are zero, which they always are with Emacs.
14693 * tparam.h (PC, BC, UP): New extern decls.
14694
0248044d 14695 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14696 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14697
8ff096c1 14698 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14699 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14700 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14701 (ftfont_list): Remove unused local.
49eaafba
PE
14702 (get_adstyle_property, ftfont_pattern_entity):
14703 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14704 Rename locals to avoid shadowing.
8ff096c1 14705
e2be39f6
PE
14706 * xfont.c (xfont_list_family): Mark var as initialized.
14707
c9735e30
PE
14708 * xml.c (make_dom): Now static.
14709
8f5201ae
PE
14710 * composite.c (composition_compute_stop_pos): Rename local to
14711 avoid shadowing.
b246f932
PE
14712 (composition_reseat_it): Remove unused locals.
14713 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14714 (composition_update_it): Mark var as initialized.
11b61122
PE
14715 (find_automatic_composition): Mark vars as initialized,
14716 with a FIXME (Bug#8290).
8f5201ae 14717
760fbc2c
PE
14718 character.h: Rename locals to avoid shadowing.
14719 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14720 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14721 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14722 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14723 to avoid shadowing.
14724
ff08eb85
PE
14725 * textprop.c (property_change_between_p): Remove; unused.
14726
fc7bf025
PE
14727 * intervals.c (interval_start_pos): Now static.
14728
235d7abc
PE
14729 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14730
44f230aa
SM
14731 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14732 Rename locals to avoid shadowing.
3e7d6594 14733
50060332
PE
14734 * sound.c (wav_play, au_play, Fplay_sound_internal):
14735 Fix pointer signedness.
d01f234b 14736 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14737 (wav_play): Initialize a variable to 0, to prevent undefined
14738 behavior (Bug#8278).
50060332 14739
c4fc4e30
PE
14740 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14741
918436ed
PE
14742 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14743
c939f91b
PE
14744 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14745 clobbering (Bug#8298).
b9c7f648
PE
14746 * sysdep.c (sys_subshell): Likewise.
14747 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14748
6bd8c144
PE
14749 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14750 This should get cleaned up, so that child_setup has the
14751 same signature on all platforms.
14752
7710357c 14753 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14754 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14755
c59da222
CY
147562011-03-22 Chong Yidong <cyd@stupidchicken.com>
14757
14758 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14759 not to be necessary, and produces flickering.
14760
66b87493
GM
147612011-03-20 Glenn Morris <rgm@gnu.org>
14762
14763 * config.in: Remove file.
14764
45b6f6d5
JB
147652011-03-20 Juanma Barranquero <lekktu@gmail.com>
14766
14767 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14768 are now in src/globals.h.
14769 (syms_of_minibuf): Remove spurious & from previous change.
14770
cd394be1 147712011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14772
14773 * minibuf.c (completing-read-function): New variable.
14774 (completing-read-default): Rename from completing-read.
14775 (completing-read): Call completing-read-function.
14776
b14e3e21
CY
147772011-03-19 Juanma Barranquero <lekktu@gmail.com>
14778
14779 * xfaces.c (Fx_load_color_file):
14780 Read color file from absolute filename (bug#8250).
14781
f2b726e6
JB
147822011-03-19 Juanma Barranquero <lekktu@gmail.com>
14783
14784 * makefile.w32-in: Update dependencies.
14785
09f6ff02
EZ
147862011-03-17 Eli Zaretskii <eliz@gnu.org>
14787
14788 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14789
29a6015a
PE
147902011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14791
a3a6c54e
PE
14792 Fix more problems found by GCC 4.5.2's static checks.
14793
b766f867
PE
14794 * process.c (make_serial_process_unwind, send_process_trap):
14795 (sigchld_handler): Now static.
14796
be02381c
PE
14797 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14798 That way, the code declares only the vars that it needs.
14799 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14800 * s/cygwin.h (PTY_ITERATION): Likewise.
14801 * s/darwin.h (PTY_ITERATION): Likewise.
14802 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14803
57048744
PE
14804 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14805 * process.c (allocate_pty): Don't declare stb unless it's needed.
14806
7914961c 14807 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14808 (CONSTANTLIM): Remove; unused.
14809 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14810 Define only if needed.
7914961c 14811
b3967b18
PE
14812 * unexelf.c (unexec): Name an expression,
14813 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14814 Use a different way to cause a compilation error if anyone uses
14815 n rather than nn, a way that does not involve shadowing.
73366a00 14816 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14817
29a6015a
PE
14818 * deps.mk (unexalpha.o): Remove; unused.
14819
43cfc33e 14820 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14821 * unexec.h: New file.
ce701a33
PE
14822 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14823 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14824 Depend on unexec.h.
14825 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14826 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14827 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14828 Change as necessary to match prototype in unexec.h.
ce701a33 14829
01f44d5a
PE
14830 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14831 shadowing.
4f63c6bb 14832 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14833
a6670b0b
PE
14834 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14835 Rename locals to avoid shadowing.
14836
cef2010d 14837 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14838 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14839
d4d7173a
PE
14840 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14841
f08b802a
PE
14842 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14843 warning when compiling print.c.
14844
3ddb0639
PE
14845 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14846 instead of using an uninitialized var.
5ad03b97 14847 (font_sort_entities): Mark var as initialized.
3ddb0639 14848
170a2692
PE
14849 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14850
e663c700
PE
14851 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14852 pointers to constants.
89bc529a 14853 (font_parse_fcname): Remove unused vars.
7b81e2d0 14854 (font_delete_unmatched): Now static.
ea838e10 14855 (font_get_spec): Remove; unused.
13a547c6
PE
14856 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14857 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14858 Rename or move locals to avoid shadowing.
e663c700 14859
2a80c887 14860 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14861 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14862
1384fa33 14863 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14864 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14865
8b2c52e9
PE
14866 * alloc.c (mark_backtrace): Move decl from here ...
14867 * lisp.h: ... to here, so that it can be checked.
14868
475545b5 14869 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14870 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14871 (lisp_indirect_variable): Name an expression,
14872 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14873 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14874
b1349114 14875 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14876 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14877 Use const pointer when appropriate.
b1349114 14878
a2928364
PE
14879 * lisp.h (get_system_name, get_operating_system_release):
14880 Move decls here, to check interfaces.
14881 * process.c (get_operating_system_release): Move decl to lisp.h.
14882 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14883 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14884 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14885 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14886 (Fformat_time_string, Fencode_time, Finsert_char):
14887 (Ftranslate_region_internal, Fformat):
14888 Rename or remove local vars to avoid shadowing.
9710023e 14889 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14890
a415e694
PE
14891 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14892 avoid shadowing.
14893
8ef4622d
PE
14894 * lisp.h (eassert): Check that the argument compiles, even if
14895 ENABLE_CHECKING is not defined.
14896
946f9a5b
PE
14897 * data.c (Findirect_variable): Name an expression, to avoid
14898 gcc -Wbad-function-cast warning.
112396d6 14899 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14900 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14901 (Fmake_variable_buffer_local, Fmake_local_variable):
14902 Mark variables as initialized.
52746918 14903 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14904
e5aab7e7 14905 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14906 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14907 Rename locals to avoid shadowing.
dff45157
PE
14908 (mark_stack): Move local variables into the #ifdef region where
14909 they're used.
7bc26fdb
PE
14910 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14911 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14912 needed otherwise.
14913 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14914 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14915 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14916
e5aab7e7
PE
14917 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14918 avoids undefined behavior in theory.
14919
4da60324
PE
14920 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14921
88043301
PE
14922 Use functions, not macros, for up- and down-casing (Bug#8254).
14923 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14924 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14925 to use the following functions instead of these macros.
14926 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14927 EMACS_INT, since callers assume the returned value fits in int.
14928 (upcase1): Likewise, for UPCASE_TABLE.
14929 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14930 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14931 the race-condition problem in the old DOWNCASE.
88043301 14932
19ed5445
PE
14933 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14934 Rename locals to avoid shadowing.
14935 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14936 (regex_compile, re_search_2, re_match_2_internal):
14937 Remove unused local vars.
952db0d7
PE
14938 (FREE_VAR): Rewrite so as not to use empty "else",
14939 which gcc can warn about.
da053e48 14940 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14941 (RETALLOC_IF): Define only if needed.
14942 (WORDCHAR_P): Likewise. This one is never needed, but is used
14943 only in a comment talking about a compiler bug, so put inside
14944 the #if 0 of that comment.
14945 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14946 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14947 Remove; unused.
19ed5445 14948
1f3561e4 14949 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14950 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14951 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14952
ded6f8f7
PE
14953 * search.c (simple_search): Remove unused var.
14954
dbd37a95
PE
14955 * dired.c (compile_pattern): Move decl from here ...
14956 * lisp.h: ... to here, so that it can be checked.
14957 (struct re_registers): New forward decl.
14958
7e47afad
PE
14959 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14960
85f24f61
PE
14961 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14962 All uses changed.
14963 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14964 Rename locals to avoid shadowing.
5671df8f 14965 (Fvertical_motion): Mark locals as initialized.
85f24f61 14966
181aa2be 14967 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14968 (casify_region): Mark local as initialized.
181aa2be 14969
930d429c
PE
14970 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14971
7082eac6
PE
14972 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14973 New macros, so that the caller can use some names other than
14974 gcpro1, gcpro2, etc.
14975 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14976 of the new macros.
14977 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14978 argument, for consistency with GCPRO2_VAR, etc: it is now the
14979 prefix of the variable, not the variable itself. All uses
14980 changed.
38b2c076
PE
14981 * dired.c (directory_files_internal, file_name_completion):
14982 Rename locals to avoid shadowing.
14983
15206ed9
PE
14984 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14985 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14986 dired.c's scmp function, had undefined behavior.
14987 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14988 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14989 * buffer.h: ... to here, because these macros use current_buffer,
14990 and the new implementation with inline functions needs to have
14991 current_buffer in scope now, rather than later when the macros
14992 are used.
14993 (downcase, upcase1): New static inline functions.
14994 (DOWNCASE, UPCASE1): Reimplement using these functions.
14995 This avoids undefined behavior in expressions like
14996 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14997 from race conditions in accessing the global variables
14998 case_temp1 and case_temp2.
14999 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
15000 * lisp.h (case_temp1, case_temp2): Remove their decls.
15001 * character.h (ASCII_CHAR_P): Move from here ...
15002 * lisp.h: ... to here, so that the inline functions mentioned
15003 above can use them.
15004
4a6bea26
PE
15005 * dired.c (directory_files_internal_unwind): Now static.
15006
f14b7e14
PE
15007 * fileio.c (file_name_as_directory, directory_file_name):
15008 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
15009 Now static.
2893f146
PE
15010 (file_name_as_directory): Use const pointers when appropriate.
15011 (Fexpand_file_name): Likewise. In particular, newdir might
15012 point at constant storage, so make it a const pointer.
fd4ead52 15013 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
15014 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
15015 signedness issues.
f839df0c
PE
15016 (Fset_file_times, Finsert_file_contents, auto_save_error):
15017 Rename locals to avoid shadowing.
f14b7e14 15018
5716756e 15019 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
15020 (Ftry_completion, Fall_completions): Rename or remove locals
15021 to avoid shadowing.
5716756e 15022
b4c3046a
PE
15023 * marker.c (bytepos_to_charpos): Remove; unused.
15024
b45db522
PE
15025 * lisp.h (verify_bytepos, count_markers): New decls,
15026 so that gcc does not warn that these functions aren't declared.
15027
85876d07
PE
15028 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
15029 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 15030 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 15031 (copy_text): Remove unused local var.
85876d07 15032
03d78a21 15033 * filelock.c (within_one_second): Now static.
b3dd38ab 15034 (lock_file_1): Rename local to avoid shadowing.
03d78a21 15035
5df8f01b
PE
15036 * buffer.c (fix_overlays_before): Mark locals as initialized.
15037 (fix_start_end_in_overlays): Likewise. This function should be
15038 simplified by using pointers-to-pointers, but that's a different
15039 matter.
b1d876f1 15040 (switch_to_buffer_1): Now static.
8f54f30a
PE
15041 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
15042 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 15043
a70072c9 15044 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 15045 Fix pointer signedness issue.
edced198
PE
15046 (sys_subshell): Mark local as volatile if checking for lint,
15047 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 15048 (MAXPATHLEN): Define only if needed.
a70072c9 15049
a0977c44
PE
15050 * process.c (serial_open, serial_configure): Move decls from here ...
15051 * systty.h: ... to here, so that they can be checked.
15052
a884fdcc
PE
15053 * fns.c (get_random, seed_random): Move extern decls from here ...
15054 * lisp.h: ... to here, so that they can be checked.
15055
604efe86 15056 * sysdep.c (reset_io): Now static.
b8950c94 15057 (wait_for_termination_signal): Remove; unused.
604efe86 15058
38fc62d9
PE
15059 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
15060 (copy_keymap_item, append_key, push_text_char_description):
15061 Now static.
1004a21a 15062 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 15063 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
15064 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
15065 (describe_map_tree):
15066 Rename locals to avoid shadowing.
38fc62d9 15067
2f2650da
PE
15068 * keyboard.c: Declare functions static if they are not used elsewhere.
15069 (echo_char, echo_dash, cmd_error, top_level_2):
15070 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
15071 (read_char, kbd_buffer_get_event, make_lispy_position):
15072 (make_lispy_event, make_lispy_movement, apply_modifiers):
15073 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
15074 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
15075 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 15076 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 15077 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 15078
a053e86c 15079 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
15080 (mark_kboards): Move decl here ...
15081 * alloc.c (mark_kboards): ... from here.
a053e86c 15082
4752793e
PE
15083 * lisp.h (force_auto_save_soon): New decl.
15084
74f10ca7 15085 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
15086 (DEFINE_DUMMY_FUNCTION): New macro.
15087 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
15088 Use it.
c03cd23f
PE
15089 (main): Add casts to avoid warnings
15090 if GCC considers string literals to be constants.
74f10ca7 15091
022e70d4
PE
15092 * lisp.h (fatal_error_signal): Add decl, since it's exported.
15093
59d6fe83
PE
15094 * dbusbind.c: Pointer signedness fixes.
15095 (xd_signature, xd_append_arg, xd_initialize):
15096 (Fdbus_call_method, Fdbus_call_method_asynchronously):
15097 (Fdbus_method_return_internal, Fdbus_method_error_internal):
15098 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
15099 (Fdbus_register_signal): Use SSDATA when the context wants char *.
15100
78320123
PE
15101 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
15102 if GCC considers string literals to be constants.
49cebcca 15103 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 15104
35ac2a97
SM
151052011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
15106
fb103ca9
SM
15107 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
15108 (print_preprocess, print_object): New macro to fix last change.
15109
35ac2a97
SM
15110 * print.c (print_preprocess): Don't forget font objects.
15111
62973b41
JB
151122011-03-16 Juanma Barranquero <lekktu@gmail.com>
15113
15114 * emacs.c (USAGE3): Doc fixes.
15115
0e48bb22
AS
151162011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15117
15118 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15119 structure.
15120
7684e57b
JB
151212011-03-14 Juanma Barranquero <lekktu@gmail.com>
15122
15123 * lisp.h (VWindow_system, Qfile_name_history):
15124 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15125 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15126 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15127
15128 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15129 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15130
15131 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15132 * w32console.c (detect_input_pending, read_input_pending)
15133 (encode_terminal_code):
15134 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15135 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15136 (w32_system_caret_y, Qfile_name_history):
15137 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15138 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15139 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15140 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15141 * w32proc.c (Qlocal, report_file_error):
15142 * w32term.c (Vwindow_system, updating_frame):
15143 * w32uniscribe.c (initialized, uniscribe_font_driver):
15144 Remove unneeded extern declarations.
15145
2aa46d6c
CY
151462011-03-14 Chong Yidong <cyd@stupidchicken.com>
15147
c96bbc66 15148 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15149
cffc6f3b
CY
151502011-03-13 Chong Yidong <cyd@stupidchicken.com>
15151
15152 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15153 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15154 These macros can no longer be used for assignment.
15155
44f230aa
SM
15156 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15157 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15158 (record_buffer_markers, fetch_buffer_markers): New functions for
15159 recording and fetching special buffer markers.
15160 (set_buffer_internal_1, set_buffer_temp): Use them.
15161
15162 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15163
15164 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15165
15166 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15167 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15168
15169 * xdisp.c (hscroll_window_tree):
15170 (reconsider_clip_changes): Use PT instead of BUF_PT.
15171
d251f04b
EZ
151722011-03-13 Eli Zaretskii <eliz@gnu.org>
15173
15174 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15175 $(EMACS_ROOT)/lib/intprops.h.
15176
f0c77cd1
PE
151772011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15178
3eca4629
PE
15179 Fix more problems found by GCC 4.5.2's static checks.
15180
7c86ee98
PE
15181 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15182 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15183 (xg_free_frame_widgets): Make it clear that a local variable is
15184 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15185 (gdk_window_get_screen): Make it clear that this macro is needed
15186 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15187 (int_gtk_range_get_value): New function, which avoids a diagnostic
15188 from gcc -Wbad-function-cast.
15189 (xg_set_toolkit_scroll_bar_thumb): Use it.
15190 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15191 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15192 (get_utf8_string, xg_get_file_with_chooser):
15193 Rename locals to avoid shadowing.
15194 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15195
41729b81
PE
15196 * xgselect.c (xg_select): Remove unused var.
15197
f0c77cd1
PE
15198 * image.c (four_corners_best): Mark locals as initialized.
15199 (gif_load): Initialize transparent_p to zero (Bug#8238).
15200 Mark another local as initialized.
ec6cf4c6 15201 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15202
ce0ad53d 15203 * image.c (clear_image_cache): Now static.
d5d5a617 15204 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15205 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15206 (x_edge_detection): Remove unnecessary cast that
15207 gcc -Wbad-function-cast diagnoses.
2037898d 15208 (gif_load): Fix pointer signedness.
6ae141d6
PE
15209 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15210 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15211
33383987 152122011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15213
d32df629
PE
15214 Improve quality of tests for time stamp overflow.
15215 For example, without this patch (encode-time 0 0 0 1 1
15216 1152921504606846976) returns the obviously-bogus value (-948597
15217 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15218 reports time overflow. See
15219 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15220 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15221 * editfns.c: Include limits.h and intprops.h.
15222 (TIME_T_MIN, TIME_T_MAX): New macros.
15223 (time_overflow): Move earlier, to before first use.
15224 (hi_time, lo_time): New functions, for an accurate test for
15225 out-of-range times.
15226 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15227 (Fget_internal_run_time): Don't assume time_t fits in int.
15228 (make_time): Use list2 instead of Fcons twice.
15229 (Fdecode_time): More accurate test for out-of-range times.
15230 (check_tm_member): New function.
15231 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15232 (lisp_time_argument): Don't rely on undefined left-shift and
15233 right-shift behavior when checking for time stamp overflow.
8be6f318 15234
fe31d94c
PE
15235 * editfns.c (time_overflow): New function, refactoring common code.
15236 (Fformat_time_string, Fdecode_time, Fencode_time):
15237 (Fcurrent_time_string): Use it.
15238
8be6f318
PE
15239 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15240 * dired.c (make_time): Move to ...
15241 * editfns.c (make_time): ... here.
15242 * systime.h: Note the move.
15243
09d9db2c 152442011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15245
126bc0dc
YM
15246 * fringe.c (update_window_fringes): Remove unused variables.
15247
c47cbdfd
YM
15248 * unexmacosx.c (copy_data_segment): Also copy __got section.
15249 (Bug#8223)
15250
7ac80be9
EZ
152512011-03-12 Eli Zaretskii <eliz@gnu.org>
15252
c96bbc66 15253 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15254 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15255 Constify `char *' arguments and their references according to
15256 prototypes in tparam.h.
15257
ecb0f94d 15258 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15259
7ac80be9
EZ
15260 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15261 Adapt all references accordingly.
15262
15263 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15264
ef1fd07e
TT
152652011-03-11 Tom Tromey <tromey@redhat.com>
15266
15267 * buffer.c (syms_of_buffer): Remove obsolete comment.
15268
7ef4b50c
EZ
152692011-03-11 Eli Zaretskii <eliz@gnu.org>
15270
15271 * termhooks.h (encode_terminal_code): Declare prototype.
15272
15273 * msdos.c (encode_terminal_code): Don't declare prototype.
15274
15275 * term.c (encode_terminal_code): Now external again, used by
15276 w32console.c and msdos.c.
15277
44f230aa
SM
15278 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15279 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15280
4b1ec863 152812011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15282
1714f52b 15283 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15284
4b1ec863
PE
15285 * fringe.c (update_window_fringes): Mark locals as initialized
15286 (Bug#8227).
15287 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15288
524c7aa6
PE
15289 * alloc.c (mark_fringe_data): Move decl from here ...
15290 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15291 to check its interface.
15292 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15293
a5c0af81 15294 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15295 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15296 (fontset_font): Mark local as initialized.
a9a06e0b 15297 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15298
b4716021
PE
15299 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15300
811e9bac 15301 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15302 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15303 (x_own_selection, Fx_disown_selection_internal): Rename locals
15304 to avoid shadowing.
15305 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15306
7e3ab302
PE
15307 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15308 so that the caller can use some name other than gcpro1.
15309 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15310 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15311 (Fx_backspace_delete_keys_p):
15312 Use them to avoid shadowing, and rename vars to avoid shadowing.
15313 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15314 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15315 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15316 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15317 Remove unused locals.
7e3ab302
PE
15318 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15319 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15320 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15321 macros.
f78faa98 15322
e2b13473
PE
15323 * xterm.h (x_mouse_leave): New decl.
15324
77f23912
PE
15325 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15326 Remove unused functions.
cdf4ba58
PE
15327 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15328 (x_calc_absolute_position): Now static.
7411c686 15329 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15330 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15331 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15332 unless they are used.
38d0b34a
PE
15333 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15334 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15335 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15336 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15337 (x_error_catcher, x_connection_closed, x_error_handler):
15338 (x_error_quitter, xembed_send_message, x_iconify_frame):
15339 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15340 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15341 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15342
44f230aa
SM
15343 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15344 Rename or move locals to avoid shadowing.
6b463e58 15345 (tty_defined_color, merge_face_heights): Now static.
5967d051 15346 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15347 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15348 does not deduce is never used uninitialized.
73719eba
PE
15349 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15350 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15351
426994c3 15352 * terminal.c (store_terminal_param): Now static.
5489860b 15353
032f1620 15354 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15355 (set_frame_menubar): Remove unused local.
d4323972 15356 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15357 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15358 since they might point to immutable storage.
281585b0
PE
15359 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15360 since it's unused otherwise.
032f1620 15361
367c19e5 15362 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15363 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15364 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15365 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15366 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15367 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15368 does not deduce are never used uninitialized.
70739cbe 15369
07b48fa9
PE
15370 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15371
8868a238 15372 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15373 * window.c (window_loop, size_window):
15374 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15375
7e5cf297 15376 * window.c (display_buffer): Now static.
d6550a9f
PE
15377 (size_window): Mark variables that gcc -Wuninitialized
15378 does not deduce are never used uninitialized.
a586633d
PE
15379 * window.h (check_all_windows): New decl, to forestall
15380 gcc -Wmissing-prototypes diagnostic.
5b555da1 15381 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15382
f6095868
PE
15383 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15384 shadowing.
15385 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15386 Include <limits.h>.
15387 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15388 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15389 (load_charset_map): Mark variables that gcc -Wuninitialized
15390 does not deduce are never used uninitialized.
53df7c11 15391 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15392
f38b440c
PE
15393 * coding.c (coding_set_source, coding_set_destination):
15394 Use "else { /* comment */ }" rather than "else /* comment */;"
15395 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15396 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15397 a block, when the outer 'i' will do.
15398 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15399 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15400 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15401 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15402 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15403 Rename locals to avoid shadowing.
15404 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15405 * coding.c (emacs_mule_char, encode_invocation_designation):
15406 Now static, since they're not used elsewhere.
413bb2db 15407 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15408 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15409 (decode_coding_emacs_mule): Mark variables that gcc
15410 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15411 (detect_coding_iso_2022): Initialize a local variable that might
15412 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15413 this initialization is needed. (Bug#8211)
5f58e762
PE
15414 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15415 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15416 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15417 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15418 Remove unused macros.
f38b440c 15419
232b38b9 15420 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15421 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15422 * character.c (string_count_byte8): Likewise.
232b38b9 15423
fb90da1b
PE
15424 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15425 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15426
fb93dbc2
PE
15427 * chartab.c (copy_sub_char_table): Now static, since it's not used
15428 elsewhere.
5c156ace
PE
15429 (sub_char_table_ref_and_range, char_table_ref_and_range):
15430 Rename locals to avoid shadowing.
bbcd0949 15431 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15432
7d3b3862 15433 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15434 (BIDI_BOB): Remove unused macro.
7d3b3862 15435
6be7d3da
PE
15436 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15437 deduce are never used uninitialized.
c2ed9c8b 15438 * term.c (encode_terminal_code): Likewise.
6be7d3da 15439
75f8807f 15440 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15441
50938595
PE
15442 * tparam.h: New file.
15443 * term.c, tparam.h: Include it.
15444 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15445 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15446 Move these decls to tparam.h, and make them agree with what
15447 is actually in tparam.c. The previous trick of using incompatible
15448 decls in different modules does not conform to the C standard.
15449 All callers of tparam changed to use tparam's actual API.
15450 * tparam.c (tparam1, tparam, tgoto):
15451 Use const pointers where appropriate.
15452
fbceeba2
PE
15453 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15454 * cm.h (struct cm): Likewise.
15455 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15456 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15457 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15458 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15459 (turn_on_face, init_tty): Likewise.
15460 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15461
7f3f1250
PE
15462 * term.c (term_mouse_position): Rename local to avoid shadowing.
15463
e6ca6543
PE
15464 * alloc.c (mark_ttys): Move decl from here ...
15465 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15466
c40f8d15
AS
154672011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15468
15469 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15470
cfe0661d
JB
154712011-03-09 Juanma Barranquero <lekktu@gmail.com>
15472
15473 * search.c (compile_pattern_1): Remove argument regp, unused since
15474 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15475 (compile_pattern): Don't pass it.
15476
0afb4571
J
154772011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15478
15479 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15480 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15481 for ! HAVE_GTK3.
15482 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15483
15484 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15485
15486 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15487 gdk_window_get_screen, gdk_window_get_geometry,
15488 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15489 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15490 (xg_get_pixbuf_from_pixmap): New function.
15491 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15492 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15493 Call xg_get_pixbuf_from_pixmap instead of
15494 gdk_pixbuf_get_from_drawable.
15495 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15496 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15497 (xg_check_special_colors): Use GtkStyleContext and its functions
15498 for HAVE_GTK3.
15499 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15500 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15501 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15502 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15503 Call gtk_widget_get_preferred_size.
0afb4571
J
15504 (xg_frame_resized): gdk_window_get_geometry only takes 5
15505 parameters.
44f230aa
SM
15506 (xg_win_to_widget, xg_event_is_for_menubar):
15507 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15508 (xg_set_widget_bg): New function.
15509 (delete_cb): New function.
895009e1 15510 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15511 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15512 (xg_set_background_color): Call xg_set_widget_bg.
15513 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15514 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15515 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15516 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15517 if ! HAVE_GTK3.
15518 (update_frame_tool_bar): Call gtk_widget_hide.
15519 (xg_initialize): Use GDK_KEY_g.
15520
15521 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15522 if ! HAVE_GTK3
15523 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15524
15525 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15526 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15527 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15528
1c2cc4ef
JB
155292011-03-08 Juanma Barranquero <lekktu@gmail.com>
15530
15531 * w32xfns.c (select_palette): Check success of RealizePalette against
15532 GDI_ERROR, not zero.
15533
33383987 15534See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15535
15536;; Local Variables:
15537;; coding: utf-8
aac0c6e3
MR
15538;; End:
15539
2f097256 15540 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15541
15542 This file is part of GNU Emacs.
15543
15544 GNU Emacs is free software: you can redistribute it and/or modify
15545 it under the terms of the GNU General Public License as published by
15546 the Free Software Foundation, either version 3 of the License, or
15547 (at your option) any later version.
15548
15549 GNU Emacs is distributed in the hope that it will be useful,
15550 but WITHOUT ANY WARRANTY; without even the implied warranty of
15551 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15552 GNU General Public License for more details.
15553
15554 You should have received a copy of the GNU General Public License
15555 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.