Minor Dired doc fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
22b9578d
LMI
12011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
6e70ab07
LMI
3 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4 are the mini-buffer and the echo area (bug#3320).
5
22b9578d
LMI
6 * term.c (init_tty): Remove support for supdup, c10 and perq
7 terminals, which are no longer supported (bug#1482).
8
8974cc9f
JB
92011-07-10 Johan Bockgård <bojohan@gnu.org>
10
11 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12
a560d974
JD
132011-07-10 Jan Djärv <jan.h.d@swipnet.se>
14
15 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
16 for non-popups (Bug#3642).
17
1dae0f0a
AS
182011-07-10 Andreas Schwab <schwab@linux-m68k.org>
19
268c2c36 20 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 21 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
22 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
23 * cm.c (losecursor): Likewise.
1dae0f0a
AS
24 * data.c (fmod): Likewise.
25 * dispnew.c (swap_glyphs_in_rows): Likewise.
26 * emacs.c (memory_warning_signal): Likewise.
27 * floatfns.c (float_error): Likewise.
28 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
29 (otf_open, font_otf_capability, generate_otf_features)
30 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
31 Likewise.
32 * image.c (pbm_read_file): Likewise.
33 * indent.c (string_display_width): Likewise.
34 * intervals.c (check_for_interval, search_for_interval)
35 (inc_interval_count, count_intervals, root_interval)
36 (adjust_intervals_for_insertion, make_new_interval): Likewise.
37 * lread.c (defalias): Likewise.
268c2c36 38 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
39 * regex.c (set_image_of_range_1, set_image_of_range)
40 (regex_grow_registers): Likewise.
41 * sysdep.c (strerror): Likewise.
42 * termcap.c (valid_filename_p, tprint, main): Likewise.
43 * tparam.c (main): Likewise.
44 * unexhp9k800.c (run_time_remap, save_data_space)
45 (update_file_ptrs, read_header, write_header, calculate_checksum)
46 (copy_file, copy_rest, display_header): Likewise.
47 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
48 Likewise.
49 * xdisp.c (check_it): Likewise.
50 * xfaces.c (register_color, unregister_color, unregister_colors):
51 Likewise.
52 * xfns.c (print_fontset_result): Likewise.
53 * xrdb.c (member, fatal, main): Likewise.
54
99033785
PE
552011-07-10 Paul Eggert <eggert@cs.ucla.edu>
56
57 Fix minor problems found by static checking (Bug#9031).
58 * chartab.c (char_table_set_range, map_sub_char_table):
59 Remove unused locals.
60 (uniprop_table): Now static.
61 * composite.c (_work_char): Remove unused static var.
62
9cb2ac56
JB
632011-07-09 Juanma Barranquero <lekktu@gmail.com>
64
65 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
66
f25661f0
JD
672011-07-09 Jan Djärv <jan.h.d@swipnet.se>
68
69 * gtkutil.c (qttip_cb): Remove code without function.
70
8278c4fe
EZ
712011-07-09 Eli Zaretskii <eliz@gnu.org>
72
73 * w32.c (pthread_sigmask): New stub.
74
1692ae2d 752011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 76
8a6ebd58 77 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
78 sigprocmask is portable only for single-threaded applications, and
79 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
80 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
81 (LIBES): Use it.
82 * callproc.c (Fcall_process):
83 * process.c (create_process):
84 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
85 Use pthread_sigmask, not sigprocmask.
123403e4 86
1b854618
JD
872011-07-08 Jan Djärv <jan.h.d@swipnet.se>
88
89 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
90 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
91 wrong (Bug#8591).
92
3fe4b549
JD
932011-07-08 Jan Djärv <jan.h.d@swipnet.se>
94
0ce7e563
JD
95 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
96 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
97 (xg_hide_tooltip): Fix comment.
98
3fe4b549
JD
99 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
100 in registerServicesMenuSendTypes.
101 (validRequestorForSendType): Don't check ns_return_types.
102
103 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
104 ns_return_type.
105
5df75e47
JR
1062011-07-08 Jason Rumney <jasonr@gnu.org>
107
108 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
109 frame struct members of non-existent frames (Bug#6284).
110
699c10bd
JD
1112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
112
4393663b
JD
113 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
114 variable firstTime not needed on OSX >= 10.6.
115 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
116 >= 10.5. Use setKnobProportion, setDoubleValue.
117
118 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
119 (MAC_OS_X_VERSION_10_5): Define if not defined.
120 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
121 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
122 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
123
124 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
125 cString and lossyCString on OSX >= 10.4
126
127 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
128 sizeToFit on OSX >= 10.2.
129
130 * nsimage.m (allocInitFromFile): Don't use deprecated method
131 bestRepresentationForDevice on OSX >= 10.6.
132
133 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
134 to avoid warning.
135
136 * emacs.c: Declare unexec_init_emacs_zone.
137
a63e0781
JD
138 * nsgui.h: Fix compiler warning about gnulib redefining verify.
139
699c10bd
JD
140 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
141
142 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
143 on svcsMenu (Bug#8842).
144
145 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
146 ns_return_types.
147 (Fns_list_services): Just return Qnil on 10.6, code not working there.
148
149 * nsterm.m (QUTF8_STRING): Declare.
150 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
151 (validRequestorForSendType): Return type is (id).
152 Change indexOfObjectIdenticalTo to indexOfObject.
153 Check if we have local selection before returning self (Bug#8842).
154 (writeSelectionToPasteboard): Put local selection into paste board
155 if we have a local selection (Bug#8842).
156 (syms_of_nsterm): DEFSYM QUTF8_STRING.
157
158 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
159 (ns_get_local_selection): Declare.
160
54e10184
LMI
1612011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
162
9888ff71
LMI
163 * keymap.c (describe_map_tree): Don't insert a double newline at
164 the end of the buffer (bug#1169) and return whether we inserted
165 something.
166
54e10184
LMI
167 * callint.c (Fcall_interactively): Change "reading args" to
168 "providing args" to try to clarify what it does (bug#1010).
169
15fa4783
KH
1702011-07-07 Kenichi Handa <handa@m17n.org>
171
172 * composite.c (composition_compute_stop_pos): Ignore a static
173 composition starting before CHARPOS (Bug#8915).
174
175 * xdisp.c (handle_composition_prop): Likewise.
176
a8815b00
EZ
1772011-07-07 Eli Zaretskii <eliz@gnu.org>
178
179 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
180 (Bug#9015)
181
ef7b981d 1822011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
183
184 * character.h (unicode_category_t): New enum type.
185
186 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
187 (Qchar_code_property_table): New variable.
188 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
189 (UNIPROP_COMPRESSED_FORM_P): New macros.
190 (char_table_ascii): Uncompress the compressed values.
191 (sub_char_table_ref): New arg is_uniprop. Callers changed.
192 Uncompress the compressed values.
193 (sub_char_table_ref_and_range): Likewise.
194 (char_table_ref_and_range): Uncompress the compressed values.
195 (sub_char_table_set): New arg is_uniprop. Callers changed.
196 Uncompress the compressed values.
197 (sub_char_table_set_range): Args changed. Callers changed.
198 (char_table_set_range): Adjuted for the above change.
199 (map_sub_char_table): Delete args default_val and parent. Add arg
200 top. Give decoded values to a Lisp function.
201 (map_char_table): Adjusted for the above change. Give decoded
202 values to a Lisp function. Gcpro more variables.
203 (uniprop_table_uncompress)
204 (uniprop_decode_value_run_length): New functions.
205 (uniprop_decoder, uniprop_decoder_count): New variables.
206 (uniprop_get_decoder, uniprop_encode_value_character)
207 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
208 New functions.
209 (uniprop_encoder, uniprop_encoder_count): New variables.
210 (uniprop_get_encoder, uniprop_table)
211 (Funicode_property_table_internal, Fget_unicode_property_internal)
212 (Fput_unicode_property_internal): New functions.
213 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
214 Sunicode_property_table_internal, Sget_unicode_property_internal,
215 and Sput_unicode_property_internal. Defvar_lisp
216 char-code-property-alist.
217
218 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
219 Vunicode_category_table.
220
221 * font.c (font_range): Adjusted for the change of
222 Vunicode_category_table.
223
76b397fb
DN
2242011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
225
226 * m/iris4d.h: Remove file, move contents ...
227 * s/irix6-5.h: ... here.
228
22b4128e
PE
2292011-07-06 Paul Eggert <eggert@cs.ucla.edu>
230
231 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
232 * alloc.c (mark_buffer):
233 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
234 (clone_per_buffer_values): Don't assume that
22b4128e
PE
235 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
236 This isn't true in general, and it's particularly not true
237 if Emacs is configured with --with-wide-int.
238 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
239 New macros, used in the buffer.c change.
240
869795d6
JD
2412011-07-05 Jan Djärv <jan.h.d@swipnet.se>
242
243 * xsettings.c: Use both GConf and GSettings if both are available.
244 (store_config_changed_event): Add comment.
245 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
246 (store_tool_bar_style_changed): New functions.
247 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
248 (struct xsettings): Move font inside HAVE_XFT.
249 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
250 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
251 Move inside HAVE_XFT.
252 (something_changed_gsettingsCB): Renamed from something_changedCB.
253 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
254 also.
255 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
256 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
257 (something_changed_gconfCB): Renamed from something_changedCB.
258 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
259 (parse_settings): Move check for font inside HAVE_XFT.
260 (read_settings, apply_xft_settings): Add comment.
261 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
262 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
263 call store_font_name_changed.
264 (xft_settings_event): Add comment.
265 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
266 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
267 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
268 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
269 (xsettings_initialize): Call init_gsettings last.
270 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
271 comment.
272
d8ed26bd
PE
2732011-07-05 Paul Eggert <eggert@cs.ucla.edu>
274
275 Random fixes. E.g., (random) never returned negative values.
276 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
277 subseconds part to the entropy, as that's a bit more random.
278 Prefer signed to unsigned, since the signedness doesn't matter and
279 in general we prefer signed. When given a limit, use a
280 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
281 latter isn't right if USE_2_TAGS_FOR_INTS.
282 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
283 not 0..VALMASK. Don't discard "excess" bits that random () returns.
284
cabf1cac
SM
2852011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
286
287 * textprop.c (text_property_stickiness):
288 Obey Vtext_property_default_nonsticky.
289 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
290 * w32fns.c (syms_of_w32fns):
291 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
292
6e9b2be9
PE
2932011-07-04 Paul Eggert <eggert@cs.ucla.edu>
294
295 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
296 This is more efficient than Ffile_directory_p and avoids a minor race.
297
90186c68
LMI
2982011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
299
7c301272
LMI
300 * buffer.c (Foverlay_put): Say what the return value is
301 (bug#7835).
302
c4f2d8d4
LMI
303 * fileio.c (barf_or_query_if_file_exists): Check first if the file
304 is a directory before asking whether to use the file name
305 (bug#7564).
ad637907
LMI
306 (barf_or_query_if_file_exists): Make the "File is a directory"
307 error be more correct.
c4f2d8d4 308
90186c68
LMI
309 * fns.c (Frequire): Remove the mention of the .gz files, since
310 that's installation-specific, but keep the mention of
311 `get-load-suffixes'.
312
da64016e
PE
3132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
314
315 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
316 Report string overflow if the output is too long.
317
7d47b580
JB
3182011-07-04 Juanma Barranquero <lekktu@gmail.com>
319
a555cb87
JB
320 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
321 (syms_of_gnutls): Remove duplicate DEFSYM for
322 Qgnutls_bootprop_verify_hostname_error, an error for
323 Qgnutls_bootprop_verify_error (which is no longer used).
324
7d47b580
JB
325 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
326 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
327 Also (re)move comments that are misplaced or no longer relevant.
328
1e49bfab
LMI
3292011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
330
331 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
332
1485f4c0
CY
3332011-07-03 Chong Yidong <cyd@stupidchicken.com>
334
335 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
336 and background color parameters if they have been changed.
337
a9ab721e
LMI
3382011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
339
340 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
341
cf7cff57
PE
3422011-07-03 Paul Eggert <eggert@cs.ucla.edu>
343
2e13213d
PE
344 * xsettings.c (SYSTEM_FONT): Define only when used.
345 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
346
cf7cff57
PE
347 * keymap.c (access_keymap_1): Now static.
348
7a8e04f7
CY
3492011-07-02 Chong Yidong <cyd@stupidchicken.com>
350
351 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
352 leave any prefix arg for the up event (Bug#1586).
353
61352f62
LMI
3542011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
355
69bb1ef7
LMI
356 * lread.c (syms_of_lread): Mention single symbols defined by
357 `defvar' or `defconst' (bug#7154).
358
61352f62 359 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 360 (Frequire): Mention get-load-suffixes.
61352f62 361
28545e04
MR
3622011-07-02 Martin Rudalics <rudalics@gmx.at>
363
364 * window.h (window): Remove clone_number slot.
365 * window.c (Fwindow_clone_number, Fset_window_clone_number):
366 Remove.
367 (make_parent_window, make_window, saved_window)
368 (Fset_window_configuration, save_window_save): Don't deal with
369 clone numbers.
370 * buffer.c (Qclone_number): Remove declaration.
371 (sort_overlays, overlay_strings): Don't deal with clone numbers.
372
3349e122
SM
3732011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
374
375 Add multiple inheritance to keymaps.
376 * keymap.c (Fmake_composed_keymap): New function.
377 (Fset_keymap_parent): Simplify.
378 (fix_submap_inheritance): Remove.
379 (access_keymap_1): New function extracted from access_keymap to handle
380 embedded parents and handle lists of maps.
381 (access_keymap): Use it.
382 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
383 (Fcopy_keymap): Handle embedded parents.
384 (Fcommand_remapping, define_as_prefix): Simplify.
385 (Fkey_binding): Simplify.
386 (syms_of_keymap): Move minibuffer-local-completion-map,
387 minibuffer-local-filename-completion-map,
388 minibuffer-local-must-match-map, and
389 minibuffer-local-filename-must-match-map to Elisp.
390 (syms_of_keymap): Defsubr make-composed-keymap.
391 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
392 (parse_menu_item): Trivial simplification.
393
3279eb87
GM
3942011-07-01 Glenn Morris <rgm@gnu.org>
395
396 * Makefile.in (SETTINGS_LIBS): Fix typo.
397
4550efdf
KI
3982011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
399
400 * coding.c (Fencode_coding_string): Record the last coding system
401 used, as the function doc string says (bug#8738).
402
0949d2b6
JD
4032011-07-01 Jan Djärv <jan.h.d@swipnet.se>
404
405 * xsettings.c (store_monospaced_changed): Take new font as arg and
406 check for change against current_mono_font.
407 (EMACS_TYPE_SETTINGS): Remove this and related defines.
408 (emacs_settings_constructor, emacs_settings_get_property)
409 (emacs_settings_set_property, emacs_settings_class_init)
410 (emacs_settings_init, gsettings_obj): Remove.
411 (something_changedCB): New function for HAVE_GSETTINGS.
412 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
413 with value as argument.
414 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
415 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 416 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
417 "changed".
418
419 * xgselect.c: Add defined (HAVE_GSETTINGS).
420 (xgselect_initialize): Ditto.
421
422 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
423 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
424 xg_select.
425
bbc6b304
PE
4262011-07-01 Paul Eggert <eggert@cs.ucla.edu>
427
428 * eval.c (struct backtrace): Simplify and port the data structure.
429 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
430 signed bit field, as this assumption is not portable and it makes
431 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
432 "char debug_on_exit : 1" as this is not portable either; instead,
433 use the portable "unsigned int debug_on_exit : 1". Remove unused
434 member evalargs. Remove obsolete comments about cc bombing out.
435
9851bfc5
JD
4362011-06-30 Jan Djärv <jan.h.d@swipnet.se>
437
51bb811f 438 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
439 Let HAVE_GSETTINGS override HAVE_GCONF.
440 (store_monospaced_changed): New function.
441 (EMACS_SETTINGS): A new type derived from GObject to handle
442 GSettings notifications.
443 (emacs_settings_constructor, emacs_settings_get_property)
444 (emacs_settings_set_property, emacs_settings_class_init):
445 New functions.
446 (gsettings_client, gsettings_obj): New variables.
447 (GSETTINGS_SCHEMA): New define.
448 (something_changedCB): Call store_monospaced_changed.
449 (init_gsettings): New function.
450 (xsettings_initialize): Call init_gsettings.
451 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
452 to NULL.
453
454 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
455 GCONF_CFLAGS/LIBS.
456
5386012d
MR
4572011-06-29 Martin Rudalics <rudalics@gmx.at>
458
459 * window.c (resize_root_window, grow_mini_window)
460 (shrink_mini_window): Rename Qresize_root_window to
461 Qwindow_resize_root_window and Qresize_root_window_vertically to
462 Qwindow_resize_root_window_vertically.
463
f13e0b08
PE
4642011-06-28 Paul Eggert <eggert@cs.ucla.edu>
465
466 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
467
94515237
JB
4682011-06-27 Juanma Barranquero <lekktu@gmail.com>
469
470 * makefile.w32-in: Redesign dependencies so they reflect more
471 clearly which files are directly included by each source file,
472 and not through other includes.
473
e43b6e43
MR
4742011-06-27 Martin Rudalics <rudalics@gmx.at>
475
476 * buffer.c (Qclone_number): Declare static and DEFSYM it.
477 (sort_overlays, overlay_strings): When an overlay's clone number
478 matches the window's clone number process the overlay even if
479 the overlay's window property doesn't match the current window.
480
d68443dc
MR
481 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
482 (Fwindow_hchild): Rename to Fwindow_left_child.
483 (Fwindow_next): Rename to Fwindow_next_sibling.
484 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
485 (resize_window_check): Rename to window_resize_check.
486 (resize_window_apply): Rename to window_resize_apply.
487 (Fresize_window_apply): Rename to Fwindow_resize_apply.
488 (Fdelete_other_windows_internal, resize_frame_windows)
489 (Fsplit_window_internal, Fdelete_window_internal)
490 (grow_mini_window, shrink_mini_window)
491 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 492
c7e73be5
JD
4932011-06-26 Jan Djärv <jan.h.d@swipnet.se>
494
495 * emacsgtkfixed.h: State that this is only used with Gtk+3.
496 (emacs_fixed_set_min_size): Remove.
497 (emacs_fixed_new): Take frame as argument.
498
499 * emacsgtkfixed.c: State that this is only used with Gtk+3.
500 (_EmacsFixedPrivate): Remove minwidth/height.
501 Add struct frame *f.
502 (emacs_fixed_init): Initialize priv->f.
503 (get_parent_class, emacs_fixed_set_min_size): Remove.
504 (emacs_fixed_new): Set priv->f to argument.
505 (emacs_fixed_get_preferred_width)
506 (emacs_fixed_get_preferred_height): Use min_width/height from
507 frames size_hint to set minimum and natural (Bug#8919).
508 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
509 and use min_width/height from frames size_hint to set
510 min_width/height (Bug#8919).
511
512 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
513 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
514 Fix indentation.
c7e73be5 515
cf99dcf8
EZ
5162011-06-26 Eli Zaretskii <eliz@gnu.org>
517
518 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
519 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
520 called at ZV.
521
029529ac
CY
5222011-06-26 Chong Yidong <cyd@stupidchicken.com>
523
524 * process.c (wait_reading_process_output): Bypass select if
525 waiting for a cell while ignoring keyboard input, and input is
526 pending. Suggested by Jan Djärv (Bug#8869).
527
7a7ef429
PE
5282011-06-25 Paul Eggert <eggert@cs.ucla.edu>
529
530 Use gnulib's dup2 module instead of rolling our own.
531 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
532
11fdef7d 5332011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
534
535 * dispnew.c (scrolling_window): Before scrolling, turn off a
536 mouse-highlight in the window being scrolled.
537
cd3520a4
JB
5382011-06-24 Juanma Barranquero <lekktu@gmail.com>
539
540 Move DEFSYM to lisp.h and use everywhere.
541
542 * character.h (DEFSYM): Move declaration...
543 * lisp.h (DEFSYM): ...here.
544
545 * gnutls.c:
546 * minibuf.c:
547 * w32menu.c:
548 * w32proc.c:
549 * w32select.c: Don't include character.h.
550
551 * alloc.c (syms_of_alloc):
552 * buffer.c (syms_of_buffer):
553 * bytecode.c (syms_of_bytecode):
554 * callint.c (syms_of_callint):
555 * casefiddle.c (syms_of_casefiddle):
556 * casetab.c (init_casetab_once):
557 * category.c (init_category_once, syms_of_category):
558 * ccl.c (syms_of_ccl):
559 * cmds.c (syms_of_cmds):
560 * composite.c (syms_of_composite):
561 * dbusbind.c (syms_of_dbusbind):
562 * dired.c (syms_of_dired):
563 * dispnew.c (syms_of_display):
564 * doc.c (syms_of_doc):
565 * editfns.c (syms_of_editfns):
566 * emacs.c (syms_of_emacs):
567 * eval.c (syms_of_eval):
568 * fileio.c (syms_of_fileio):
569 * fns.c (syms_of_fns):
570 * frame.c (syms_of_frame):
571 * fringe.c (syms_of_fringe):
572 * insdel.c (syms_of_insdel):
573 * keymap.c (syms_of_keymap):
574 * lread.c (init_obarray, syms_of_lread):
575 * macros.c (syms_of_macros):
576 * msdos.c (syms_of_msdos):
577 * print.c (syms_of_print):
578 * process.c (syms_of_process):
579 * search.c (syms_of_search):
580 * sound.c (syms_of_sound):
581 * syntax.c (init_syntax_once, syms_of_syntax):
582 * terminal.c (syms_of_terminal):
583 * textprop.c (syms_of_textprop):
584 * undo.c (syms_of_undo):
585 * w32.c (globals_of_w32):
586 * window.c (syms_of_window):
587 * xdisp.c (syms_of_xdisp):
588 * xfaces.c (syms_of_xfaces):
589 * xfns.c (syms_of_xfns):
590 * xmenu.c (syms_of_xmenu):
591 * xsettings.c (syms_of_xsettings):
592 * xterm.c (syms_of_xterm): Use DEFSYM.
593
4228cf16
TZ
5942011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
595
cd3520a4 596 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 597
7fcccf1e
PE
5982011-06-23 Paul Eggert <eggert@cs.ucla.edu>
599
7efb4e0e
PE
600 Integer and buffer overflow fixes (Bug#8873).
601
ff5844ad
PE
602 * print.c (printchar, strout): Check for string overflow.
603 (PRINTPREPARE, printchar, strout):
604 Don't set size unless allocation succeeds.
605
90532f02
PE
606 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
607 for sizes. Check for string overflow more accurately.
608 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
609
6d84508d
PE
610 * macros.c: Integer and buffer overflow fixes.
611 * keyboard.h (struct keyboard.kbd_macro_bufsize):
612 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
613 Use ptrdiff_t, not int, for sizes.
614 Don't increment bufsize until after realloc succeeds.
615 Check for size-calculation overflow.
616 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
617
437b2cb4
PE
618 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
619
8b9ac8b4
PE
620 * lread.c: Integer overflow fixes.
621 (read_integer): Radix is now EMACS_INT, not int,
622 to improve quality of diagnostics for out-of-range radices.
623 Calculate buffer size correctly for out-of-range radices.
624 (read1): Check for integer overflow in radices, and in
625 read-circle numbers.
82cb60d3
PE
626 (read_escape): Avoid int overflow.
627 (Fload, openp, read_buffer_size, read1)
628 (substitute_object_recurse, read_vector, read_list, map_obarray):
629 Use ptrdiff_t, not int, for sizes.
630 (read1): Use EMACS_INT, not int, for sizes.
20270765 631 Check for size overflow.
8b9ac8b4 632
7fcccf1e
PE
633 * image.c (cache_image): Check for size arithmetic overflow.
634
bfbbd7e7
PE
635 * lread.c: Integer overflow issues.
636 (saved_doc_string_size, saved_doc_string_length)
637 (prev_saved_doc_string_size, prev_saved_doc_string_length):
638 Now ptrdiff_t, not int.
639 (read1): Don't assume doc string length fits in int. Check for
640 out-of-range doc string lengths.
641 (read_list): Don't assume file position fits in int.
39019e54 642 (read_escape): Check for hex character overflow.
bfbbd7e7 643
4e323265
LL
6442011-06-22 Leo Liu <sdl.web@gmail.com>
645
646 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
647 Move to minibuffer.el.
648
85fece3e
PE
6492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
650
20b84ce9 651 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
652 The following patches are for when GLYPH_DEBUG && !XASSERT.
653 * dispextern.h (trace_redisplay_p, dump_glyph_string):
654 * dispnew.c (flush_stdout):
655 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
656 Mark as externally visible.
657 * dispnew.c (check_window_matrix_pointers): Now static.
658 * dispnew.c (window_to_frame_vpos):
659 * xfns.c (unwind_create_frame):
660 * xterm.c (x_check_font): Remove unused local.
661 * scroll.c (CHECK_BOUNDS):
662 * xfaces.c (cache_fache): Rename local to avoid shadowing.
663 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
664 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
665 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
666 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
667 Now static.
668 (debug_method_add): Use va_list and vsprintf rather than relying
669 on undefined behavior with wrong number of arguments.
670 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
671 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
672 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
673 since we're not interested in debugging glyphs with old libraries.
674 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
675 GCC 4.6.0's static checking.
676
0766b489
PE
6772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
678
31fd4b32
PE
679 Integer overflow and signedness fixes (Bug#8873).
680 A few related buffer overrun fixes, too.
681
b79e8648
PE
682 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
683
0766b489
PE
684 * dispextern.h (struct face.stipple):
685 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
686 (x_bitmap_mask, x_allocate_bitmap_record)
687 (x_create_bitmap_from_data, x_create_bitmap_from_file)
688 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
689 (x_create_bitmap_from_xpm_data):
690 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
691 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
692 (.bitmaps_last):
693 * xfaces.c (load_pixmap):
694 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
695 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
696 (.bitmaps_last, struct x_output.icon_bitmap):
697 Use ptrdiff_t, not int, for bitmap indexes.
698 (x_allocate_bitmap_record): Check for size overflow.
699 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
700
b081724f
PE
701 Use ptrdiff_t, not int, for overlay counts.
702 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
703 * editfns.c (overlays_around, get_pos_property):
704 * textprop.c (get_char_property_and_overlay):
705 * xdisp.c (next_overlay_change, note_mouse_highlight):
706 * xfaces.c (face_at_buffer_position):
21514da7
PE
707 * buffer.c (OVERLAY_COUNT_MAX): New macro.
708 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
709 (Fnext_overlay_change, Fprevious_overlay_change)
710 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 711 Use ptrdiff_t, not int, for sizes.
21514da7 712 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 713
3de73e5e
PE
714 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
715
2606c57b
PE
716 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
717 (x_session_initialize): Do not assume string length fits in int.
718
aaafe47a
PE
719 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
720 This is unlikely, but can occur if DPI is outlandish.
721
2674ddc8 722 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
723 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
724
28154962
PE
725 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
726 * xrdb.c (magic_file_p, search_magic_path):
727 Omit last arg SUFFIX; it was always 0. All callers changed.
728 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
729
7de51af5
PE
730 * xfont.c (xfont_match): Avoid need for strlen.
731
25ed6cc3
PE
732 * xfns.c: Don't assume strlen fits in int.
733 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
734
4eab31dd
PE
735 * xdisp.c (message_log_check_duplicate): Return intmax_t,
736 not unsigned long, as we prefer signed integers. All callers changed.
737 Detect integer overflow in repeat count.
738 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 739 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 740
171e2a58
PE
741 * termcap.c: Don't assume sizes fit in int and never overflow.
742 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
743 (gobble_line): Check for size-calculation overflow.
744
ad39faca 745 * minibuf.c (Fread_buffer):
6e5bb2dc 746 * lread.c (intern, intern_c_string):
74ca2eb3
PE
747 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
748 Don't assume string length fits in int.
749
52c61c22 750 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
751 * gtkutil.c (style_changed_cb): Avoid need for strlen.
752
b5b8c9e5
PE
753 * font.c: Don't assume string length fits in int.
754 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
755 Use ptrdiff_t, not int.
ccd6111c
PE
756 (font_intern_prop): Don't assume string length fits in int.
757 Don't assume integer property fits in fixnum.
758 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 759
882f0d81 760 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 761 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
762 Reformulate so as not to need the command string.
763 Invoke gzip -cd rather than gunzip, as it's more portable.
764 (lock_info_type, lock_file_1, lock_file):
765 Don't assume pid_t and time_t fit in unsigned long.
766 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
767 (current_lock_owner): Prefer signed type for sizes.
768 Use memcpy, not strncpy, where memcpy is what is really wanted.
769 Don't assume (via atoi) that time_t and pid_t fit in int.
770 Check for time_t and/or pid_t out of range, e.g., via a network share.
771 Don't alloca where an auto var works fine.
772
93f4cf88
PE
773 * fileio.c: Fix some integer overflow issues.
774 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
775 Don't assume string length fits in int.
776 (directory_file_name): Don't assume string length fits in long.
777 (make_temp_name): Don't assume pid fits in int, or that its print
778 length is less than 20.
779
f3e92b69
PE
780 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
781
1bfdaf10
PE
782 * coding.c (make_subsidiaries): Don't assume string length fits in int.
783
35016e9a
PE
784 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
785
3d1e65a1
PE
786 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
787 We prefer signed integers, even for size calculations.
788
0b963a93
PE
789 * emacs.c: Don't assume string length fits in 'int'.
790 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
791 (main): Don't invoke strlen when not needed.
792
573f4b54
PE
793 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
794 (XD_DEBUG_MESSAGE): Don't waste a byte.
795
989f33ba
PE
796 * callproc.c (getenv_internal_1, getenv_internal)
797 (Fgetenv_internal):
965d34eb
PE
798 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
799
e4d29b33
PE
800 * lread.c (invalid_syntax): Omit length argument.
801 All uses changed. This doesn't fix a bug, but it simplifies the
802 code away from its former Hollerith-constant appearance, and it's
803 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 804 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 805
eb49b136
PE
806 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
807 This didn't break anything, but it didn't help either.
808 It's confusing to put a bogus integer in a place where the actual
809 value does not matter.
9f62aeb1 810 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 811 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 812
15375a22
PE
813 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
814 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
815 implementation.
b61cc01c
PE
816 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
817 We prefer signed types, and the value cannot exceed the EMACS_INT
818 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
819 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
820 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
821 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 822
53b2623d
PE
823 * indent.c (sane_tab_width): New function.
824 (current_column, scan_for_column, Findent_to, position_indentation)
825 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 826 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 827
51cab52b 828 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 829
f2ed8a70
PE
830 * lisp.h (lint_assume): New macro.
831 * composite.c (composition_gstring_put_cache):
832 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
833
abe80cc6
PE
834 * editfns.c, insdel.c:
835 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 836
b02c740e
PE
837 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
838
ebc96716
PE
839 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
840
b4e50fa0 841 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 842 Use much-faster test for byte-length change.
311d5d7c 843 Don't assume string byte-length fits in 'int'.
a4cf38e4 844 Check that character arg fits in 'int'.
85461888 845 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 846
c0c1ee9f
PE
847 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
848
a498d7f4
PE
849 * fns.c (concat): Catch string overflow earlier.
850 Do not rely on integer wraparound.
851
51cab52b
PE
852 * dispextern.h (struct it.overlay_strings_charpos)
853 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
854 * xdisp.c (forward_to_next_line_start)
855 (back_to_previous_visible_line_start)
856 (reseat_at_next_visible_line_start, next_element_from_buffer):
857 Don't arbitrarily truncate the value of 'selective' to int.
858
76031fad
PE
859 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
860
5eb55db9
PE
861 * composite.c: Don't truncate sizes to 'int'.
862 (composition_gstring_p, composition_reseat_it)
863 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
864 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
865 not EMACS_UINT, for indexes.
5eb55db9 866
0703a717
PE
867 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
868
d6202519
PE
869 * buffer.c: Include <verify.h>.
870 (struct sortvec.priority, struct sortstr.priority):
8961a454 871 Now EMACS_INT, not int.
c20998a7 872 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
873 (struct sortstr.size, record_overlay_string)
874 (struct sortstrlist.size, struct sortlist.used):
875 Don't truncate size to int.
876 (record_overlay_string): Check for size-calculation overflow.
d6202519 877 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 878
d5a19415
JM
8792011-06-22 Jim Meyering <meyering@redhat.com>
880
029529ac 881 Don't leak an XBM-image-sized buffer
d5a19415
JM
882 * image.c (xbm_load): Free the image buffer after using it.
883
a9041e6c
PE
8842011-06-21 Paul Eggert <eggert@cs.ucla.edu>
885
886 Port to Sun C.
887 * composite.c (find_automatic_composition): Omit needless 'return 0;'
888 that Sun C diagnosed.
889 * fns.c (secure_hash): Fix pointer signedness issue.
890 * intervals.c (static_offset_intervals): New function.
891 (offset_intervals): Use it.
892
7f3f739f
LL
8932011-06-21 Leo Liu <sdl.web@gmail.com>
894
895 * deps.mk (fns.o):
896 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
897 sha512.h.
898
899 * fns.c (secure_hash): Rename from crypto_hash_function and change
900 the first arg to accept symbols.
5b66d427 901 (Fsecure_hash): New primitive.
7f3f739f
LL
902 (syms_of_fns): New symbols.
903
76147d94
DD
9042011-06-20 Deniz Dogan <deniz@dogan.se>
905
906 * process.c (Fset_process_buffer): Clarify return value in
907 docstring.
908
7d7d0045
CY
9092011-06-18 Chong Yidong <cyd@stupidchicken.com>
910
911 * dispnew.c (add_window_display_history): Use BVAR.
912
913 * xdisp.c (debug_method_add): Use BVAR.
914 (check_window_end, dump_glyph_matrix, dump_glyph)
915 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
916
917 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
918 Likewise.
919
920 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
921 check till after the cache is created in init_frame_faces.
922
ff2bc410
SM
9232011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
924
925 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
926
28177add
PE
9272011-06-16 Paul Eggert <eggert@cs.ucla.edu>
928
dd3482fe
PE
929 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
930 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
931 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
932
393d71f3 933 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
934 * fileio.c (Finsert_file_contents):
935 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
936 Remove the old (too-loose) buffer overflow checks.
937 They weren't needed, since make_gap checks for buffer overflow.
938 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
939 The old code merely checked for Emacs fixnum overflow, and relied
940 on undefined (wraparound) behavior. The new code avoids undefined
941 behavior, and also checks for ptrdiff_t and/or size_t overflow.
942
2e6813b0 943 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
944 Tune. Don't use wider integers than needed. Don't use alloca.
945 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 946
599a9e4f
PE
947 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
948
99561444
PE
949 * insdel.c, lisp.h (buffer_overflow): New function.
950 (insert_from_buffer_1, replace_range, replace_range_2):
951 * insdel.c (make_gap_larger):
952 * editfns.c (Finsert_char):
953 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
954
28177add
PE
955 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
956
e69dafad
PE
9572011-06-15 Paul Eggert <eggert@cs.ucla.edu>
958
a7af7fde 959 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 960
b1c46f02
PE
961 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
962 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
963
e69dafad
PE
964 * fileio.c: Don't assume EMACS_INT fits in off_t.
965 (emacs_lseek): New static function.
966 (Finsert_file_contents, Fwrite_region): Use it.
967 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
968
566684ea
PE
969 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
970
e6966cd6
PE
971 * fns.c: Don't overflow int when computing a list length.
972 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
973 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
974 truncation on 64-bit hosts. Check for QUIT every
975 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
976 faster and is responsive enough.
977 (Flength): Report an error instead of overflowing an integer.
978 (Fsafe_length): Return a float if the value is not representable
979 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 980 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 981 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 982
dd0b0efb
PE
983 * alloc.c: Check that resized vectors' lengths fit in fixnums.
984 (header_size, word_size): New constants.
985 (allocate_vectorlike): Don't check size overflow here.
986 (allocate_vector): Check it here instead, since this is the only
987 caller of allocate_vectorlike that could cause overflow.
988 Check that the new vector's length is representable as a fixnum.
989
86fe5cfe
PE
990 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
991 The previous code was bogus. For example, next_almost_prime (32)
992 returned 39, which is undesirable as it is a multiple of 3; and
993 next_almost_prime (24) returned 25, which is a multiple of 5 so
994 why was the code bothering to check for multiples of 7?
995
80e88859
PE
996 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
997
4a2f0ad6
PE
998 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
999
f66c7cf8
PE
1000 Variadic C functions now count arguments with ptrdiff_t.
1001 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1002 Back then I didn't know that the Emacs coding style prefers signed int.
1003 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1004 were being counted with int, which may truncate counts on 64-bit
1005 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1006 * lisp.h (struct Lisp_Subr.function.aMANY)
1007 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1008 Arg counts are now ptrdiff_t, not size_t.
1009 All variadic functions and their callers changed accordingly.
1010 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1011 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1012 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1013 * callint.c (Fcall_interactively): Check arg count for overflow,
1014 to avoid potential buffer overrun. Use signed char, not 'int',
1015 for 'varies' array, so that we needn't bother to check its size
1016 calculation for overflow.
1017 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1018 * eval.c (apply_lambda):
1019 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1020 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1021 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1022
a1759b76
PE
1023 * callint.c (Fcall_interactively): Don't use index var as event count.
1024
d96be9fc
PE
1025 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1026 * mem-limits.h (SIZE): Remove; no longer used.
1027
a690a978 1028 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1029
578c21e6
PE
1030 Remove unnecessary casts.
1031 * xterm.c (x_term_init):
1032 * xfns.c (x_set_border_pixel):
1033 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1034 These aren't needed now that we assume ANSI C.
1035
96f53c6c
PE
1036 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1037 It's more likely to cause problems (due to unsigned overflow)
1038 than to cure them.
1039
83c77d31
PE
1040 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1041
ee2079f1
PE
1042 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1043
6da65536
PE
1044 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1045
7147c4a4
PE
1046 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1047
193e32d9
PE
1048 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1049
e5533da6
PE
1050 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1051
9910e595
PE
1052 GLYPH_CODE_FACE returns EMACS_INT, not int.
1053 * dispextern.h (merge_faces):
1054 * xfaces.c (merge_faces):
01103c44
PE
1055 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1056 Don't assume EMACS_INT fits in int.
9910e595 1057
2638320e
PE
1058 * character.h (CHAR_VALID_P): Remove unused parameter.
1059 * fontset.c, lisp.h, xdisp.c: All uses changed.
1060
045eb8d9
PE
1061 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1062
c1f134b5
PE
1063 * fns.c (concat): Minor tuning based on overflow analysis.
1064 This doesn't fix any bugs. Use int to hold character, instead
1065 of constantly refetching from Emacs object. Use XFASTINT, not
1066 XINT, for value known to be a character. Don't bother comparing
1067 a single byte to 0400, as it's always less.
1068
395fcb93 1069 * floatfns.c (Fexpt):
327eeec8
PE
1070 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1071
abbd3d23
PE
1072 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1073 for characters.
1074
684a03ef
PE
1075 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1076
0fed43f3
PE
1077 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1078 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1079 incorrectly succeed when S was a string, because 4294967386 was
1080 truncated before it was used.
1081
8fd02eb7
PE
1082 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1083 Otherwise, an out-of-range integer could cause undefined behavior
1084 on a 64-bit host.
1085
f8c86b69
PE
1086 * composite.c: Use int, not EMACS_INT, for characters.
1087 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1088 EMACS_INT, for values that are known to be in character range.
1089 This doesn't fix any bugs but is the usual style inside Emacs and
1090 may generate better code on 32-bit machines.
1091
34206dd2
PE
1092 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1093 This is for reasons similar to the recent CHAR_STRING fix.
1094 * charset.c (Fencode_char): Check that character arg is actually
1095 a character. Pass an int to ENCODE_CHAR.
1096 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1097 wider than 'int', as a compile-time check to prevent future regressions
1098 in this area.
1099
c5958d4c 1100 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1101
1102 Make sure a 64-bit char is never passed to CHAR_STRING.
1103 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1104 by silently ignoring the top 32 bits, allowing some values
1105 that were far too large to be valid characters.
1106 * character.h: Include <verify.h>.
1107 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1108 arguments are no wider than unsigned, as a compile-time check
1109 to prevent future regressions in this area.
1110 * data.c (Faset):
01103c44 1111 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1112 (Fsubst_char_in_region):
1113 * fns.c (concat):
1114 * xdisp.c (decode_mode_spec_coding):
1115 Adjust to CHAR_STRING's new requirement.
1116 * editfns.c (Finsert_char, Fsubst_char_in_region):
1117 * fns.c (concat): Check that character args are actually
1118 characters. Without this test, these functions did the wrong
1119 thing with wildly out-of-range values on 64-bit hosts.
1120
d37ca623
PE
1121 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1122 These casts should not be needed on 32-bit hosts, either.
1123 * keyboard.c (read_char):
1124 * lread.c (Fload): Remove casts to unsigned.
1125
ea204efb
PE
1126 * lisp.h (UNSIGNED_CMP): New macro.
1127 This fixes comparison bugs on 64-bit hosts.
1128 (ASCII_CHAR_P): Use it.
1129 * casefiddle.c (casify_object):
01103c44 1130 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1131 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1132 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1133 * dispextern.h (FACE_FROM_ID):
1134 * keyboard.c (read_char): Use UNSIGNED_CMP.
1135
41cb286c
PE
1136 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1137 not to EMACS_INT, to avoid GCC warning.
1138
4a1b9832
PE
1139 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1140
55daad71
PE
1141 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1142 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1143 isn't needed on 32-bit machines.
8f95c75c 1144
01103c44
PE
1145 * buffer.c (Fgenerate_new_buffer_name):
1146 Use EMACS_INT for count, not int.
0ceccced 1147 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1148
1149 * data.c (Qcompiled_function): Now static.
1150
c6f072e7
PE
1151 * window.c (window_body_lines): Now static.
1152
20ce5912
PE
1153 * image.c (gif_load): Rename local to avoid shadowing.
1154
9c4c5f81
PE
1155 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1156 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1157 * alloc.c (make_save_value): Integer argument is now of type
1158 ptrdiff_t, not int.
1159 (mark_object): Use ptrdiff_t, not int.
1160 * lisp.h (pD): New macro.
1161 * print.c (print_object): Use it.
1162
c0c5c8ae
PE
1163 * alloc.c: Use EMACS_INT, not int, to count objects.
1164 (total_conses, total_markers, total_symbols, total_vector_size)
1165 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1166 (total_free_floats, total_floats, total_free_intervals)
1167 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1168 Now EMACS_INT, not int. All uses changed.
1169 (Fgarbage_collect): Compute overall total using a double, so that
1170 integer overflow is less likely to be a problem. Check for overflow
1171 when converting back to an integer.
5a25e253
PE
1172 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1173 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1174 These were 'int' variables that could overflow on 64-bit hosts;
1175 they were never used, so remove them instead of repairing them.
211a0b2a 1176 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1177 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1178 Previously, this ceilinged at INT_MAX, but that doesn't work on
1179 64-bit machines.
e46bb31a 1180 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1181
c78baabf 1182 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1183 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1184 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1185 when a (possibly-narrower) signed value would do just as well.
1186 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1187
c9d624c6
PE
1188 * alloc.c: Catch some string size overflows that we were missing.
1189 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1190 for convenience in STRING_BYTES_MAX.
1191 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1192 The definition here is exact; the one in lisp.h was approximate.
1193 (allocate_string_data): Check for string overflow. This catches
1194 some instances we weren't catching before. Also, it catches
1195 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1196 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1197 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1198
c9d624c6
PE
1199 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1200 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1201 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1202
353032ce
PE
1203 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1204
2bccce07
PE
1205 * alloc.c (Fmake_string): Check for out-of-range init.
1206
0ac30604
SM
12072011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1208
1209 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1210
c195f2de
JD
12112011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1212
1213 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1214 xg_get_default_scrollbar_width.
1215
1216 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1217 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1218 (style_changed_cb): Call update_theme_scrollbar_width and call
1219 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1220 all frames (Bug#8505).
1221 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1222 Call gtk_window_set_resizable if HAVE_GTK3.
1223 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1224 and height if HAVE_GTK3 (Bug#8505).
1225 (scroll_bar_width_for_theme): New variable.
1226 (update_theme_scrollbar_width): New function.
1227 (xg_get_default_scrollbar_width): Move code to
1228 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1229 (xg_initialize): Call update_theme_scrollbar_width.
1230
1231 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1232
1233 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1234
e10ac9f1
MR
12352011-06-12 Martin Rudalics <rudalics@gmx.at>
1236
1237 * frame.c (make_frame): Call other_buffer_safely instead of
1238 other_buffer.
1239
1240 * window.c (temp_output_buffer_show): Call display_buffer with
1241 second argument Vtemp_buffer_show_specifiers and reset latter
1242 immediately after the call.
1243 (Vtemp_buffer_show_specifiers): New variable.
1244 (auto_window_vscroll_p, next_screen_context_lines)
1245 (Vscroll_preserve_screen_position): Remove leading asterisks from
1246 doc-strings.
1247
2d3c217e 12482011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1249
7b7f97e8 1250 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1251 * buffer.c (Qclone_number): Remove for now, as it's unused.
1252 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1253 (record_buffer): Remove unused local.
1254 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1255 (set_frame_buffer_list): Remove; unused.
1256 * frame.h (other_visible_frames): Remove decl.
1257 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1258 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1259 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1260 if HAVE_GPM.
1261 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1262 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1263 Define only if HAVE_GPM.
1264 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1265 (update_hints_inhibit): Remove; never set. All uses removed.
1266 * widgetprv.h (emacsFrameClassRec): Remove decl.
1267 * window.c (delete_deletable_window): Now returns void, since it
1268 wasn't returning anything.
1269 (compare_window_configurations): Remove unused locals.
1270 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1271 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1272 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1273 the same widths as pointers. This follows up on the 2011-05-06 patch.
1274 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1275 * xterm.h: Likewise.
1276 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1277
1384b89e
JB
12782011-06-12 Juanma Barranquero <lekktu@gmail.com>
1279
1280 * makefile.w32-in: Update dependencies.
1281 (LISP_H): Add lib/intprops.h.
1282
1100a63c
CY
12832011-06-11 Chong Yidong <cyd@stupidchicken.com>
1284
1285 * image.c (gif_load): Add animation frame delay to the metadata.
1286 (syms_of_image): Use DEFSYM. New symbol `delay'.
1287
6198ccd0
MR
12882011-06-11 Martin Rudalics <rudalics@gmx.at>
1289
1290 * window.c (delete_deletable_window): Re-add.
1291 (Fset_window_configuration): Rewrite to handle dead buffers and
1292 consequently deletable windows.
1293 (window_tree, Fwindow_tree): Remove. Supply functionality in
1294 window.el.
1295 (compare_window_configurations): Simplify code.
1296
b6e3633c
AS
12972011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1298
1ab0dee5
AS
1299 * image.c (imagemagick_load_image): Fix type mismatch.
1300 (Fimagemagick_types): Likewise.
1301
b6e3633c
AS
1302 * window.h (replace_buffer_in_windows): Declare.
1303
9397e56f
MR
13042011-06-11 Martin Rudalics <rudalics@gmx.at>
1305
1306 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1307 Qclone_number. Remove external declaration of Qdelete_window.
1308 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1309 code.
1310 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1311 Qbuffer_list_update_hook if allowed.
1312 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1313 buffer list implementation.
1314 (other_buffer_safely): New function.
1315 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1316 calls to replace_buffer_in_windows and
1317 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1318 if allowed.
1319 (record_buffer): Inhibit quitting and rewrite using quittable
1320 functions. Run Qbuffer_list_update_hook if allowed.
1321 (Frecord_buffer, Funrecord_buffer): New functions.
1322 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1323 switch-to-buffer to window.el.
1324 (bury-buffer): Move to window.el.
1325 (Vbuffer_list_update_hook): New variable.
1326
1327 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1328 section.
1329
1330 * window.h (resize_frame_windows): Move up in code.
1331 (Fwindow_frame): Remove EXFUN.
1332 (replace_buffer_in_all_windows): Remove prototype.
1333 (replace_buffer_in_windows_safely): Add prototype.
1334
1335 * window.c: Declare Qdelete_window static again. Move down
1336 declaration of select_count.
1337 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1338 (Fother_window): Move to window.el.
1339 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1340 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1341 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1342 window.el.
1343 (replace_buffer_in_windows): Implement by calling
1344 Qreplace_buffer_in_windows.
1345 (replace_buffer_in_all_windows): Remove with some functionality
1346 moved into replace_buffer_in_windows_safely.
1347 (replace_buffer_in_windows_safely): New function.
1348 (select_window_norecord, select_frame_norecord): Move in front
1349 of run_window_configuration_change_hook. Remove now obsolete
1350 declarations.
1351 (Fset_window_buffer): Rewrite doc-string. Call
1352 Qrecord_window_buffer.
1353 (keys_of_window): Move binding for other-window to window.el.
1354
b50691aa
CY
13552011-06-11 Chong Yidong <cyd@stupidchicken.com>
1356
1357 * dispextern.h (struct image): Replace data member, whose int_val
1358 and ptr_val fields were not used by anything, with a single
1359 lisp_val object.
1360
1361 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1362 (gif_clear_image, gif_load, imagemagick_load_image)
1363 (gs_clear_image, gs_load): Callers changed.
1364
3f754b86
PE
13652011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1366
cca69397
PE
1367 * buffer.h: Include <time.h>, for time_t.
1368 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1369
109e28d0
PE
1370 Fix minor problems found by static checking.
1371
60737f02
PE
1372 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1373
4b66faf3
PE
1374 Make identifiers static if they are not used in other modules.
1375 * data.c (Qcompiled_function, Qframe, Qvector):
1376 * image.c (QimageMagick, Qsvg):
1377 * minibuf.c (Qmetadata):
1378 * window.c (resize_window_check, resize_root_window): Now static.
1379 * window.h (resize_window_check, resize_root_window): Remove decls.
1380
109e28d0
PE
1381 * window.c (window_deletion_count, delete_deletable_window):
1382 Remove; unused.
46a4ce9e
PE
1383 (window_body_lines): Now static.
1384 (Fdelete_other_windows_internal): Mark vars as initialized.
1385 Make sure 'resize_failed' is initialized.
1386 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1387 (resize_window_apply): Remove unused local.
1388 * window.h (delete_deletable_window): Remove decl.
1389
109e28d0 1390 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1391 (imagemagick_load_image): Fix pointer signedness problem by changing
1392 last arg from unsigned char * to char *. All uses changed.
1393 Also, fix a local for similar reasons.
1394 Remove unused locals. Remove locals to avoid shadowing.
1395 (fn_rsvg_handle_free): Remove; unused.
1396 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1397 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1398
3f754b86
PE
1399 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1400
2547adb1
CY
14012011-06-10 Chong Yidong <cyd@stupidchicken.com>
1402
1403 * image.c (gif_load): Fix omitted cast error introduced by
1404 2011-06-06 change.
1405
2c8e37d4
MR
14062011-06-10 Martin Rudalics <rudalics@gmx.at>
1407
1408 * window.h (resize_proportionally, orig_total_lines)
1409 (orig_top_line): Remove from window structure.
1410 (set_window_height, set_window_width, change_window_heights)
1411 (Fdelete_window): Remove prototypes.
1412 (resize_frame_windows): Remove duplicate declaration.
1413
440a42e3
EZ
14142011-06-10 Eli Zaretskii <eliz@gnu.org>
1415
1416 * window.h (resize_frame_windows, resize_window_check)
1417 (delete_deletable_window, resize_root_window)
1418 (resize_frame_windows): Declare prototypes.
1419
1420 * window.c (resize_window_apply): Make definition be "static" to
1421 match the prototype.
1422
562dd5e9
MR
14232011-06-10 Martin Rudalics <rudalics@gmx.at>
1424
1425 * window.c: Remove declarations of Qwindow_size_fixed,
1426 window_min_size_1, window_min_size_2, window_min_size,
1427 size_window, window_fixed_size_p, enlarge_window, delete_window.
1428 Remove static from declaration of Qdelete_window, it's
1429 temporarily needed by Fbury_buffer.
1430 (replace_window): Don't assign orig_top_line and
1431 orig_total_lines.
1432 (Fdelete_window, delete_window): Remove. Window deletion is
1433 handled by window.el.
1434 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1435 Fdelete_window calls with calls to Qdelete_window.
1436 (Fdelete_other_windows): Remove. Deleting other windows is
1437 handled by window.el.
1438 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1439 handled in window.el.
1440 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1441 Window minimum sizes are handled in window.el.
1442 (shrink_windows, size_window, set_window_height)
1443 (set_window_width, change_window_heights, window_height)
1444 (window_width, CURBEG, CURSIZE, enlarge_window)
1445 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1446 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1447 handled in window.el.
1448 (make_dummy_parent): Rename to make_parent_window and give it a
1449 second argument horflag.
1450 (make_window): Don't set resize_proportionally any more.
1451 (Fsplit_window): Remove. Windows are split in window.el.
1452 (save_restore_action, save_restore_orig_size)
1453 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1454 Resize mini windows in window.el.
1455 (grow_mini_window, shrink_mini_window): Implement by calling
1456 Qresize_root_window_vertically, resize_window_check and
1457 resize_window_apply.
1458 (saved_window, Fset_window_configuration, save_window_save): Do
1459 not handle orig_top_line, orig_total_lines, and
1460 resize_proportionally.
1461 (window_min_height, window_min_width): Move to window.el.
1462 (keys_of_window): Move bindings for delete-other-windows,
1463 split-window, delete-window and enlarge-window to window.el.
1464
1465 * buffer.c: Temporarily extern Qdelete_window.
1466 (Fbury_buffer): Temporarily call Qdelete_window instead of
1467 Fdelete_window (Fbury_buffer will move to window.el soon).
1468
1469 * frame.c (set_menu_bar_lines_1): Remove code handling
1470 orig_top_line and orig_total_lines.
1471
1472 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1473 set_window_height but set heights directly.
1474 (change_frame_size_1): Use resize_frame_windows.
1475
1476 * xdisp.c (init_xdisp): Don't use set_window_height but set
1477 heights directly.
1478
1479 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1480 resize_frame_windows instead of change_window_heights and run
1481 run_window_configuration_change_hook.
1482
1483 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1484 instead of change_window_heights and run
1485 run_window_configuration_change_hook.
1486
1a13852e
MR
14872011-06-09 Martin Rudalics <rudalics@gmx.at>
1488
1489 * window.c (replace_window): Rename second argument REPLACEMENT to
1490 NEW. New third argument SETFLAG. Rewrite.
1491 (delete_window, make_dummy_parent): Call replace_window with
1492 third argument 1.
1493 (window_list_1): Move down in code.
1494 (run_window_configuration_change_hook): Move set_buffer part
1495 before select_frame_norecord part in order to unwind correctly.
1496 Rename count1 to count.
1497 (recombine_windows, delete_deletable_window, resize_root_window)
1498 (Fdelete_other_windows_internal)
1499 (Frun_window_configuration_change_hook, make_parent_window)
1500 (resize_window_check, resize_window_apply, Fresize_window_apply)
1501 (resize_frame_windows, Fsplit_window_internal)
1502 (Fdelete_window_internal, Fresize_mini_window_internal): New
1503 functions.
1504 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1505
f3d1777e
MR
15062011-06-08 Martin Rudalics <rudalics@gmx.at>
1507
496e208e
MR
1508 * window.h (window): Add some new members to window structure -
1509 normal_lines, normal_cols, new_total, new_normal, clone_number,
1510 splits, nest, prev_buffers, next_buffers.
1511 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1512 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1513
f3d1777e
MR
1514 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1515 Remove.
496e208e
MR
1516 (make_dummy_parent): Set new members of windows structure.
1517 (make_window): Move down in code. Handle new members of window
1518 structure.
1519 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1520 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1521 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1522 (Fset_window_prev_buffers, Fwindow_next_buffers)
1523 (Fset_window_next_buffers, Fset_window_clone_number): New
1524 functions.
1525 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1526 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1527 Doc-string fixes.
1528 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1529 Argument WINDOW can be now internal window too.
1530 (Fwindow_use_time): Move up in code.
1531 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1532 Rewrite doc-string.
1533 (Fset_window_configuration, saved_window)
1534 (Fcurrent_window_configuration, save_window_save): Handle new
1535 members of window structure.
b9e809c2
MR
1536 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1537 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1538 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1539 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1540 Qget_mru_window, Qresize_root_window,
1541 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1542 Qauto_buffer_name; staticpro them.
f3d1777e 1543
abde8f8c
MR
15442011-06-07 Martin Rudalics <rudalics@gmx.at>
1545
1546 * window.c (Fwindow_total_size, Fwindow_left_column)
1547 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1548 (Fwindow_list_1): New functions.
1549 (window_box_text_cols): Replace with window_body_cols.
1550 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1551 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1552 (delete_window, Fset_window_configuration): Call
1553 delete_all_subwindows with window as argument.
1554 (delete_all_subwindows): Take a window as argument and not a
1555 structure. Rewrite.
190b47e6
MR
1556 (window_loop): Remove handling of GET_LRU_WINDOW and
1557 GET_LARGEST_WINDOW.
1558 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1559
1560 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1561 window_box_text_cols. delete_all_subwindows now takes a
1562 Lisp_Object as argument.
abde8f8c
MR
1563
1564 * indent.c (compute_motion, Fcompute_motion): Use
1565 window_body_cols instead of window_box_text_cols.
1566
fa8a67e6
MR
1567 * frame.c (delete_frame): Call delete_all_subwindows with root
1568 window as argument.
1569
a54e3482
DC
15702011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1571
1572 * fns.c (Fputhash): Document return value.
1573
60002bf5
CY
15742011-06-06 Chong Yidong <cyd@stupidchicken.com>
1575
1576 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1577
0c671da6 15782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1579
b862a52a 1580 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1581
be44ca6c
PE
1582 Check for overflow when converting integer to cons and back.
1583 * charset.c (Fdefine_charset_internal, Fdecode_char):
1584 Use cons_to_unsigned to catch overflow.
1585 (Fencode_char): Use INTEGER_TO_CONS.
1586 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1587 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1588 * data.c (long_to_cons, cons_to_long): Remove.
1589 (cons_to_unsigned, cons_to_signed): New functions.
1590 These signal an error for invalid or out-of-range values.
1591 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1592 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1593 * font.c (Ffont_variation_glyphs):
1594 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1595 * lisp.h: Include <intprops.h>.
1596 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1597 (cons_to_signed, cons_to_unsigned): New decls.
1598 (long_to_cons, cons_to_long): Remove decls.
1599 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1600 (Fprimitive_undo): Use CONS_TO_INTEGER.
1601 * xfns.c (Fx_window_property): Likewise.
1602 * xselect.c: Include <limits.h>.
1603 (x_own_selection, selection_data_to_lisp_data):
1604 Use INTEGER_TO_CONS.
1605 (x_handle_selection_request, x_handle_selection_clear)
1606 (x_get_foreign_selection, Fx_disown_selection_internal)
1607 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1608 (lisp_data_to_selection_data): Use cons_to_unsigned.
1609 (x_fill_property_data): Use cons_to_signed.
1610 Report values out of range.
1611
d1f3d2af
PE
1612 Check for buffer and string overflow more precisely.
1613 * buffer.h (BUF_BYTES_MAX): New macro.
1614 * lisp.h (STRING_BYTES_MAX): New macro.
1615 * alloc.c (Fmake_string):
1616 * character.c (string_escape_byte8):
1617 * coding.c (coding_alloc_by_realloc):
1618 * doprnt.c (doprnt):
1619 * editfns.c (Fformat):
1620 * eval.c (verror):
1621 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1622 since they may not be the same number.
1623 * editfns.c (Finsert_char):
1624 * fileio.c (Finsert_file_contents):
1625 Likewise for BUF_BYTES_MAX.
1626
dd52fcea
PE
1627 * image.c: Use ptrdiff_t, not int, for sizes.
1628 (slurp_file): Switch from int to ptrdiff_t.
1629 All uses changed.
1630 (slurp_file): Check that file size fits in both size_t (for
1631 malloc) and ptrdiff_t (for sanity and safety).
1632
7f9bbdbb
PE
1633 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1634 if b->modtime has its maximal value.
1635
dfe18f82
PE
1636 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1637
84acfcf0
PE
1638 Don't assume time_t can fit into int.
1639 * buffer.h (struct buffer.modtime): Now time_t, not int.
1640 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1641 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1642
ccd9a01a
PE
1643 Minor fixes for signed vs unsigned integers.
1644 * character.h (MAYBE_UNIFY_CHAR):
1645 * charset.c (maybe_unify_char):
1646 * keyboard.c (read_char, reorder_modifiers):
1647 XINT -> XFASTINT, since the integer must be nonnegative.
1648 * ftfont.c (ftfont_spec_pattern):
1649 * keymap.c (access_keymap, silly_event_symbol_error):
1650 XUINT -> XFASTINT, since the integer must be nonnegative.
1651 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1652 since it makes no difference and we prefer signed.
1653 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1654 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1655 nonnegative.
1656
d6d100dd
SM
16572011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1658
1659 * window.h (Fwindow_frame): Declare.
1660
2b6148e4
PE
16612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1662
1663 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1664 (SPARE_MEMORY): Always define.
1665 (LARGE_REQUEST): Remove.
1666 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1667
f230ecc9
MR
16682011-06-06 Martin Rudalics <rudalics@gmx.at>
1669
727e958e
MR
1670 * lisp.h: Move EXFUNS for Fframe_root_window,
1671 Fframe_first_window and Fset_frame_selected_window to window.h.
1672
1673 * window.h: Move EXFUNS for Fframe_root_window,
1674 Fframe_first_window and Fset_frame_selected_window here from
1675 lisp.h.
1676
1677 * frame.c (Fwindow_frame, Fframe_first_window)
1678 (Fframe_root_window, Fframe_selected_window)
1679 (Fset_frame_selected_window): Move to window.c.
1680 (Factive_minibuffer_window): Move to minibuf.c.
1681 (Fother_visible_frames_p): New function.
1682
1683 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1684
f230ecc9
MR
1685 * window.c (decode_window, decode_any_window): Move up in code.
1686 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1687 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1688 (Fwindow_buffer): Move up and rewrite doc-string.
1689 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1690 (Fwindow_prev): New functions.
727e958e
MR
1691 (Fwindow_frame): Move here from frame.c. Accept any window as
1692 argument.
1693 (Fframe_root_window, Fframe_first_window)
1694 (Fframe_selected_window): Move here from frame.c. Accept frame
1695 or arbitrary window as argument. Update doc-strings.
1696 (Fminibuffer_window): Move up in code.
1697 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1698 (Fset_frame_selected_window): Move here from frame.c.
1699 Marginal rewrite.
727e958e
MR
1700 (Fselected_window, select_window, Fselect_window): Move up in
1701 code. Minor doc-string fixes.
f230ecc9 1702
4d09bcf6
PE
17032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1706 Do not assume that spare memory exists; that assumption is valid
1707 only if SYSTEM_MALLOC.
1708 (LARGE_REQUEST): New macro, so that the issue of large requests
1709 is separated from the issue of spare memory.
1710
810928a2
AS
17112011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1712
172418ad
AS
1713 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1714 format. (Bug#8806)
1715
43f862f7
AS
1716 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1717
810928a2
AS
1718 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1719 before statements.
1720
a059fe24
JD
17212011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1722
1723 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1724
1725 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1726
1727 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1728 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1729
989bf368
JB
17302011-06-05 Juanma Barranquero <lekktu@gmail.com>
1731
1732 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1733
4b80f674
CY
17342011-06-04 Chong Yidong <cyd@stupidchicken.com>
1735
1736 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1737 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1738 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1739 New error handlers.
4b80f674
CY
1740 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1741 Obey Vx_select_enable_clipboard_manager. Catch errors in
1742 x_clipboard_manager_save (Bug#8779).
1743 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1744 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1745
99a33b77 17462011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1747
1748 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1749
99a33b77 17502011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1751
1752 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1753 in the current matrix if keep_current_p is non-zero.
1754
8264569d
EZ
17552011-06-04 Eli Zaretskii <eliz@gnu.org>
1756
1757 * bidi.c (bidi_level_of_next_char): Fix last change.
1758
57f97249
EZ
17592011-06-03 Eli Zaretskii <eliz@gnu.org>
1760
fec2107c 1761 Support bidi reordering of text covered by display properties.
57f97249 1762
fec2107c
EZ
1763 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1764 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1765 (bidi_cache_search, bidi_cache_iterator_state)
1766 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1767 (bidi_level_of_next_char, bidi_move_to_visually_next):
1768 Support character positions inside a run of characters covered by a
fec2107c
EZ
1769 display string.
1770 (bidi_paragraph_init, bidi_resolve_explicit_1)
1771 (bidi_level_of_next_char): Call bidi_fetch_char and
1772 bidi_fetch_char_advance instead of FETCH_CHAR and
1773 FETCH_CHAR_ADVANCE.
1774 (bidi_init_it): Initialize new members.
1775 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1776 definitions.
1777 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1778 instead of using explicit *_CHAR codes.
d6d100dd
SM
1779 (bidi_resolve_explicit, bidi_resolve_weak):
1780 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1781 bidirectional text is supported only in multibyte buffers.
1782 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1783 it to initialize the frame_window_p member of struct bidi_it.
1784 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1785 (bidi_resolve_explicit, bidi_resolve_weak)
1786 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1787 bidi_it->nchars is non-positive.
1788 (bidi_level_of_next_char): Don't try to lookup the cache for the
1789 next/previous character if nothing is cached there yet, or if we
1790 were just reseat()'ed to a new position.
c40e2fb2 1791
0e14fe90
EZ
1792 * xdisp.c (set_cursor_from_row): Set start and stop points
1793 according to the row's direction when priming the loop that looks
1794 for the glyph on which to display cursor.
1795 (single_display_spec_intangible_p): Function deleted.
1796 (display_prop_intangible_p): Reimplement to call
1797 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1798 Accept 3 additional arguments needed by handle_display_spec.
1799 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1800 values: lists, `(when COND...)' forms, etc.
1801 (single_display_spec_string_p): Support property values that are
1802 lists with the argument STRING its top-level element.
1803 (display_prop_string_p): Fix the condition for processing a
1804 property that is a list to be consistent with handle_display_spec.
fec2107c 1805 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1806 last portion of handle_display_prop.
1807 (compute_display_string_pos): Accept additional argument
1808 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1809 value of a `display' property is a "replacing spec".
1810 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1811 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1812 the display property, but just return a value indicating whether
1813 the display property will replace the characters it covers.
1814 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1815 frame_window_p members of struct bidi_it.
d6d100dd
SM
1816 (compute_display_string_pos, compute_display_string_end):
1817 New functions.
fec2107c
EZ
1818 (push_it): Accept second argument POSITION, where pop_it should
1819 jump to continue iteration.
1820 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1821
fec2107c
EZ
1822 * keyboard.c (adjust_point_for_property): Adjust the call to
1823 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1824
1825 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1826 (bidi_init_it): Update prototypes.
1827 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1828 (compute_display_string_pos, compute_display_string_end):
1829 Declare prototypes.
fec2107c
EZ
1830 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1831 EMACS_INT.
fc6f18ce 1832
40087514 18332011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1834
57f53182
PE
1835 Malloc failure behavior now depends on size of allocation.
1836 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1837 * lisp.h: Change signatures accordingly.
1838 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1839 All callers changed. (Bug#8762)
1840
1841 * gnutls.c: Use Emacs's memory allocators.
1842 Without this change, the gnutls library would invoke malloc etc.
1843 directly, which causes problems on non-SYNC_INPUT hosts, and which
1844 runs afoul of improving memory_full behavior. (Bug#8761)
1845 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1846 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1847 xfree instead of the default malloc, realloc, free.
1848 (Fgnutls_boot): No need to check for memory allocation failure,
1849 since xmalloc does that for us.
1850
ac32cd99 1851 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1852 * category.c (hash_get_category_set):
1853 * ccl.c (ccl_driver):
1854 * charset.c (Fdefine_charset_internal):
1855 * charset.h (struct charset.hash_index):
1856 * composite.c (get_composition_id, gstring_lookup_cache)
1857 (composition_gstring_put_cache):
1858 * composite.h (struct composition.hash_index):
1859 * dispextern.h (struct image.hash):
1860 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1861 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1862 (hashfn_equal, hashfn_user_defined, make_hash_table)
1863 (maybe_resize_hash_table, hash_lookup, hash_put)
1864 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1865 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1866 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1867 * image.c (make_image, search_image_cache, lookup_image)
1868 (xpm_put_color_table_h):
1869 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1870 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1871 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1872 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1873 * alloc.c (allocate_vectorlike):
1874 Check for overflow in vector size calculations.
1875 * ccl.c (ccl_driver):
1876 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1877 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1878 need to be updated by these changes.
40087514
PE
1879 * fns.c (make_hash_table, maybe_resize_hash_table):
1880 Check for integer overflow with large hash tables.
0de4bb68
PE
1881 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1882 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1883 (SXHASH_REDUCE): New macro.
1884 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1885 Use it instead of discarding useful hash info with large hash values.
1886 (sxhash_float): New function.
1887 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1888 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1889 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1890 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1891 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1892 Adjust signatures to match updated version of code.
1893 (consing_since_gc): Now EMACS_INT, since a single hash table can
1894 use more than INT_MAX bytes.
1895
698d32e2
DN
18962011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1897
1898 Make it possible to build with GCC-4.6+ -O2 -flto.
1899
1900 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1901
fd6fa53f
SM
19022011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1903
1904 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1905 Call minibuffer-inactive-mode.
1906
864db017
JB
19072011-05-31 Juanma Barranquero <lekktu@gmail.com>
1908
1909 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1910 Update dependencies.
1911
2ad0baf4
DN
19122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1913
1914 * data.c (init_data): Remove code for UTS, this system is not
1915 supported anymore.
1916
4fcc2638
DN
19172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1918
1919 Don't force ./temacs to start in terminal mode.
1920
1921 * frame.c (make_initial_frame): Initialize faces in all cases, not
1922 only when CANNOT_DUMP is defined.
1923 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1924
c56e0fd5
DN
19252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1926
1927 * dispnew.c (add_window_display_history): Use const for the string
1928 pointer. Remove declaration, not needed.
1929
333d54da 19302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1931
55d4c1b2 1932 Use 'inline', not 'INLINE'.
333d54da 1933 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1934 * alloc.c, fontset.c (INLINE): Remove.
1935 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1936 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1937 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1938 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1939 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1940
738db178
DN
19412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1942
1943 Make it possible to run ./temacs.
1944
1945 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1946 syms_of_callproc does the same thing. Remove test for
1947 "initialized", do it in the caller.
1948 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1949
620c53a6
SM
19502011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1951
1952 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1953 (read_minibuf): Use get_minibuffer.
1954 (syms_of_minibuf): Use DEFSYM.
1955 (Qmetadata): New var.
1956 * data.c (Qbuffer): Don't make it static.
1957 (syms_of_data): Use DEFSYM.
1958
e003a292
PE
19592011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1962 (CCL_CODE_MIN): New macro.
1963
ed008a6d
PE
19642011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1965
3687c2ef
PE
1966 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1967
ed008a6d
PE
1968 * eval.c (Qdebug): Now static.
1969 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1970 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1971 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1972
d66c4c7c
CY
19732011-05-29 Chong Yidong <cyd@stupidchicken.com>
1974
1975 * image.c: Various fixes to ImageMagick code comments.
1976 (Fimagemagick_types): Doc fix.
1977
5fbc2025
PE
19782011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1979
0196f88a
PE
1980 Minor fixes prompted by GCC 4.6.0 warnings.
1981
1982 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1983
5fbc2025
PE
1984 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1985 (x_clipboard_manager_save_all): Move extern decl to ...
1986 * xterm.h: ... here, so that it can be checked for consistency.
1987
1dd3c2d9
CY
19882011-05-29 Chong Yidong <cyd@stupidchicken.com>
1989
1990 * xselect.c (x_clipboard_manager_save_frame)
1991 (x_clipboard_manager_save_all): New functions.
1992 (Fx_clipboard_manager_save): Lisp function deleted.
1993
1994 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1995 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1996
1997 * xterm.h: Update prototype.
1998
5ba6571d
WX
19992011-05-28 William Xu <william.xwl@gmail.com>
2000
2001 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2002 exiting (Bug#8239).
2003
3eaff834
JM
20042011-05-28 Jim Meyering <meyering@redhat.com>
2005
e1900994 2006 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2007 * fns.c (to_uchar): Define.
2008 (crypto_hash_function): Use it to convert some newly-signed
2009 variables to unsigned, to avoid sign-extension bugs. For example,
2010 without this change, (md5 "truc") would evaluate to
2011 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2012 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2013 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2014
0f6990a7
PE
20152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2016
2017 Integer overflow fixes.
c8a9ca5a 2018
08686060
PE
2019 * dbusbind.c: Serial number integer overflow fixes.
2020 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2021 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2022 to hold a serial number that is too large for a fixnum.
2023 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2024 Check for serial numbers out of range. Decode any serial number
59568bf0 2025 that was so large that it became a float. (Bug#8722)
08686060 2026
2d1fc3c7
PE
2027 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2028 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2029 Use XFASTINT rather than XUINT when numbers are nonnegative.
2030 (xd_append_arg, Fdbus_method_return_internal):
2031 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2032 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2033 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2034 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2035 (Bug#8722)
2d1fc3c7 2036
c8a9ca5a
PE
2037 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2038
519e1d69
PE
2039 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2040
30569699
PE
2041 ccl: add integer overflow checks
2042 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2043 (IN_INT_RANGE): New macros.
2044 (ccl_driver): Use them to check for integer overflow when
2045 decoding a CCL program. Many of the new checks are whether XINT (x)
2046 fits in int; it doesn't always, on 64-bit hosts. The new version
2047 doesn't catch all possible integer overflows, but it's an
847044ea 2048 improvement. (Bug#8719)
30569699 2049
c11285dc
PE
2050 * alloc.c (make_event_array): Use XINT, not XUINT.
2051 There's no need for unsigned here.
2052
fdccd48e
PE
2053 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2054 This follows up to the 2011-05-06 change that substituted uintptr_t
2055 for EMACS_INT. This case wasn't caught back then.
2056
37910ab2
PE
2057 Rework Fformat to avoid integer overflow issues.
2058 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2059 now (part of C89). Include <verify.h>.
2060 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2061 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2062 (Fformat): Avoid the prepass trying to compute sizes; it was only
2063 approximate and thus did not catch overflow reliably. Instead, walk
2064 through the format just once, formatting and computing sizes as we go,
2065 checking for integer overflow at every step, and allocating a larger
2066 buffer as needed. Keep track separately whether the format is
2067 multibyte. Keep only the most-recently calculated precision, rather
2068 than them all. Record whether each argument has been converted to
2069 string. Use EMACS_INT, not int, for byte and char and arg counts.
2070 Support field widths and precisions larger than INT_MAX. Avoid
2071 sprintf's undefined behavior with conversion specifications such as %#d
2072 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2073 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2074 formatting out-of-range floating point numbers with int
9173deec 2075 formats. (Bug#8668)
37910ab2 2076
2e6578fb
PE
2077 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2078
0ae6bdee
PE
2079 * data.c: Avoid integer truncation in expressions involving floats.
2080 * data.c: Include <intprops.h>.
2081 (arith_driver): When there's an integer overflow in an expression
2082 involving floating point, convert the integers to floating point
2083 so that the resulting value does not suffer from catastrophic
2084 integer truncation. For example, on a 64-bit host (* 4
2085 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2086 Do not rely on undefined behavior after integer overflow.
2087
de883a70
PE
2088 merge count_size_as_multibyte, parse_str_to_multibyte
2089 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2090 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2091 Check for integer overflow.
2092 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2093 since it's now a duplicate of the other. This is more of
2094 a character than a buffer op, so better that it's in character.c.
2095 * fns.c, print.c: Adjust to above changes.
2096
2ff916cb
PE
20972011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2098
2099 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2100
f1b54466
PE
21012011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2102
fb1ac845
PE
2103 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2104 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2105 (x_clipboard_manager_save): Now static.
2106 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2107
f1b54466
PE
2108 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2109 (crypto_hash_function): Now static.
2110 Fix pointer signedness problems. Avoid unnecessary initializations.
2111
a9f737ee
CY
21122011-05-27 Chong Yidong <cyd@stupidchicken.com>
2113
2114 * termhooks.h (Vselection_alist): Make it terminal-local.
2115
2116 * terminal.c (create_terminal): Initialize it.
2117
2118 * xselect.c: Support for clipboard managers.
2119 (Vselection_alist): Move to termhooks.h as terminal-local var.
2120 (LOCAL_SELECTION): New macro.
2121 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2122 (symbol_to_x_atom): Remove gratuitous arg.
2123 (x_handle_selection_request, lisp_data_to_selection_data)
2124 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2125 (x_own_selection, x_get_local_selection, x_convert_selection):
2126 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2127 (some_frame_on_display): Delete unused function.
2128 (Fx_own_selection_internal, Fx_get_selection_internal)
2129 (Fx_disown_selection_internal, Fx_selection_owner_p)
2130 (Fx_selection_exists_p): New optional frame arg.
2131 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2132 (x_handle_selection_clear): Don't treat other terminals with the
2133 same keyboard specially. Use the terminal-local Vselection_alist.
2134 (x_clear_frame_selections): Use Frun_hook_with_args.
2135
2136 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2137
2138 * xterm.h: Add support for those atoms.
2139
e067f0c1
CY
21402011-05-26 Chong Yidong <cyd@stupidchicken.com>
2141
2142 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2143 (converted_selections, conversion_fail_tag): New global variables.
2144 (x_selection_request_lisp_error): Free the above.
2145 (x_get_local_selection): Remove unnecessary code.
2146 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2147 of converted selections stored in converted_selections.
2148 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2149 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2150 (x_convert_selection): New function.
2151 (x_handle_selection_event): Simplify.
2152 (x_get_foreign_selection): Don't ignore incoming requests while
2153 waiting for an answer; this will fail when we implement
2154 SAVE_TARGETS, and seems unnecessary anyway.
2155 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2156 (Vx_sent_selection_functions): Doc fix.
2157
0f4aebc0
LL
21582011-05-26 Leo Liu <sdl.web@gmail.com>
2159
2160 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2161
e61124cd
YM
21622011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2163
2164 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2165
2166 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2167 for fringe update if it has periodic bitmap.
2168 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2169 and fringe_bitmap_periodic_p.
2170
2171 * fringe.c (get_fringe_bitmap_data): New function.
2172 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2173 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2174 row. Mark glyph row for fringe update if periodicity changed.
2175
2176 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2177 for fringe update unless it has periodic bitmap.
2178
f16d9837
KH
21792011-05-25 Kenichi Handa <handa@m17n.org>
2180
2181 * xdisp.c (get_next_display_element): Set correct it->face_id for
2182 a static composition.
2183
e1b90ef6
LL
21842011-05-24 Leo Liu <sdl.web@gmail.com>
2185
2186 * deps.mk (fns.o):
2187 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2188
2189 * fns.c (crypto_hash_function, Fsha1): New function.
2190 (Fmd5): Use crypto_hash_function.
2191 (syms_of_fns): Add Ssha1.
2192
7400048f
PE
21932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * gnutls.c: Remove unused macros.
2196 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2197 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2198 Remove macros that are defined and never used.
2199 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2200
abb71cf4
CY
22012011-05-22 Chong Yidong <cyd@stupidchicken.com>
2202
2203 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2204 (Fx_get_selection_internal): Minor cleanup.
2205 (Fx_own_selection_internal): Rename arguments for consistency with
2206 select.el.
2207
6307db39
PE
22082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2211
f3d4e0a4
CY
22122011-05-22 Chong Yidong <cyd@stupidchicken.com>
2213
2214 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2215
4d8ade89
YM
22162011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2217
2218 * dispnew.c (scrolling_window): Don't exclude the case that the
2219 last enabled row in the desired matrix touches the bottom boundary.
2220
32078c8d
GM
22212011-05-21 Glenn Morris <rgm@gnu.org>
2222
2223 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2224 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2225 and add some more files.
32078c8d 2226
7285dc67
EZ
22272011-05-20 Eli Zaretskii <eliz@gnu.org>
2228
2229 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2230 report_file_error introduced by the change from 2011-05-07.
2231
89d1bd22
PE
22322011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2233
2234 * systime.h (Time): Define only if emacs is defined.
2235 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2236 where the include path doesn't have X11/X.h by default. See
2237 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2238
e23640bb 22392011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2240
2241 * composite.c (find_automatic_composition): Fix previous change.
2242
b9704ad9
GM
22432011-05-20 Glenn Morris <rgm@gnu.org>
2244
2245 * lisp.mk: New file, split from Makefile.in.
2246 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2247 (shortlisp): Remove.
2248 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2249
4a720484
GM
22502011-05-19 Glenn Morris <rgm@gnu.org>
2251
2252 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2253 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2254 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2255 (lisp): Set the order to that of loadup.el.
2256 (shortlisp): Make it a copy of $lisp.
2257 (SOME_MACHINE_LISP): Remove.
2258 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2259 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2260
a28d4396
KH
22612011-05-18 Kenichi Handa <handa@m17n.org>
2262
2263 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2264 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2265 (find_automatic_composition): Mostly rewrite for efficiency.
2266
a2b1fa8e
JB
22672011-05-18 Juanma Barranquero <lekktu@gmail.com>
2268
2269 * makefile.w32-in: Update dependencies.
2270
8e1f5610
CS
22712011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2272
2273 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2274 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2275
7025ee00 22762011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2277
cdfa6eab
PE
2278 Fix some integer overflow issues, such as string length overflow.
2279
06d6db33
PE
2280 * insdel.c (count_size_as_multibyte): Check for string overflow.
2281
2b4560a8
PE
2282 * character.c (lisp_string_width): Check for string overflow.
2283 Use EMACS_INT, not int, for string indexes and lengths; in
2284 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2285 the resulting string length overflows an EMACS_INT; instead,
2286 report a string overflow if no precision given. When checking for
2287 precision exhaustion, use a check that cannot possibly have
2288 integer overflow. (Bug#8675)
2289 * character.h (lisp_string_width): Adjust to new signature.
2290
cb93f9be
PE
2291 * alloc.c (string_overflow): New function.
2292 (Fmake_string): Use it. This doesn't change behavior, but saves
2293 a few bytes and will simplify future changes.
2294 * character.c (string_escape_byte8): Likewise.
2295 * lisp.h (string_overflow): New decl.
2296
1a1f3366
PE
2297 Fixups, following up to the user-interface timestamp change.
2298 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2299 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2300 * msdos.c (mouse_get_pos): Likewise.
2301 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2302 * w32gui.h (Time): Define by including "systime.h" rather than by
2303 declaring it ourselves. (Bug#8664)
2304
d4e3e4d3
PE
2305 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2306 * image.c (clear_image_cache): Likewise.
2307
f6a24d19
PE
2308 * term.c (term_mouse_position): Don't assume time_t wraparound.
2309
08dc5ae6
PE
2310 Be more systematic about user-interface timestamps.
2311 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2312 and sometimes 'EMACS_UINT', to represent these timestamps.
2313 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2314 This makes the code easier to follow, and makes it easier to catch
2315 integer overflow bugs such as Bug#8664.
2316 * frame.c (Fmouse_position, Fmouse_pixel_position):
2317 Use Time, not unsigned long, for user-interface timestamps.
2318 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2319 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2320 * keyboard.h (last_event_timestamp): Likewise.
2321 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2322 * menu.h (xmenu_show): Likewise.
2323 * term.c (term_mouse_position): Likewise.
2324 * termhooks.h (struct input_event.timestamp): Likewise.
2325 (struct terminal.mouse_position_hook): Likewise.
2326 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2327 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2328 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2329 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2330 what it was before.
2331 * menu.h, termhooks.h: Include "systime.h", for Time.
2332
8e55734a
PE
2333 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2334 Don't assume that the difference between two unsigned long values
2335 can fit into an integer. At this point, we know button_down_time
2336 <= event->timestamp, so the difference must be nonnegative, so
2337 there's no need to cast the result if double-click-time is
2338 nonnegative, as it should be; check that it's nonnegative, just in
2339 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2340 apart (about 25 days). (Bug#8664)
8e55734a 2341
841f1b75 2342 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2343 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2344
3e26f69c
PE
2345 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2346 that always fit in int. Use a sentinel instead of a counter, to
2347 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2348 * frame.h (struct frame): Use int for menu_bar_items_used
2349 instead of EMACS_INT, since it always fits in int.
3e26f69c 2350
5cc152c0
PE
2351 * menu.c (grow_menu_items): Check for int overflow.
2352
d89eb65e
PE
2353 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2354
5235bd3e
PE
2355 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2356 Before, the code was not consistent. These values cannot exceed
2357 2**31 - 1 so there's no need to make them unsigned.
2358 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2359 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2360 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2361 as modifiers.
2362 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2363
bc827e23
PE
2364 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2365 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2366 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2367 presumably because the widths might not match.
2368
78eb494e
PE
2369 * window.c (size_window): Avoid needless test at loop start.
2370
04f2d78b
CB
23712011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2372
2373 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2374
d2fc7e3d 23752011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2376
2377 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2378
d2fc7e3d 23792011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2380
2381 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2382 `width' to `bar_area_x' and `bar_area_width', respectively.
2383 (x_scroll_run): Take account of fringe background extension.
2384
04f2d78b
CB
2385 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2386 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2387 `bar_area_width', respectively.
2388 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2389 background extension.
2390
79b70037
GM
23912011-05-10 Jim Meyering <meyering@redhat.com>
2392
2393 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2394
2f142cc5
JB
23952011-05-10 Juanma Barranquero <lekktu@gmail.com>
2396
2397 * image.c (Finit_image_library): Return t for built-in image types,
2398 like pbm and xbm. (Bug#8640)
2399
57679c86
AS
24002011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2401
2402 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2403
888c9e86
EZ
24042011-05-07 Eli Zaretskii <eliz@gnu.org>
2405
b0512a1d
EZ
2406 * w32console.c (Fset_screen_color): Doc fix.
2407 (Fget_screen_color): New function.
2408 (syms_of_ntterm): Defsubr it.
2409
7285dc67
EZ
2410 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2411 unlink the temporary file if Fcall_process didn't create it in the
2412 first place.
2413 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2414 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2415 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2416 cue to call_process_cleanup not to close that handle.
2417
4d3fcc8e
BK
24182011-05-07 Ben Key <bkey76@gmail.com>
2419
2420 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2421 one of two shell specific rules, either bootstrap-temacs-CMD or
2422 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2423 to the previous implementation of the bootstrap-temacs rule.
2424 The bootstrap-temacs-CMD rule is similar to the previous
2425 implementation of the bootstrap-temacs rule except that it
2426 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2427 variable.
2428
2429 These changes, along with some changes to nt/configure.bat,
2430 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2431 earlier fix to add support for --cflags and --ldflags options
2432 that include quotes so that it works whether make uses cmd or
2433 sh as the shell.
2434
b4289b64
MA
24352011-05-06 Michael Albinus <michael.albinus@gmx.de>
2436
2437 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2438 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2439 is a constant.
2440 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2441 a string. Handle both cases.
2442 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2443 (Fdbus_register_method): Use Qinvalid_function.
2444
af4c0e28
JB
24452011-05-06 Juanma Barranquero <lekktu@gmail.com>
2446
2447 * makefile.w32-in: Update dependencies.
2448 (LISP_H): Add inttypes.h and stdin.h.
2449 (PROCESS_H): Add unistd.h.
2450
c51453d9
EZ
24512011-05-06 Eli Zaretskii <eliz@gnu.org>
2452
2453 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2454 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2455
8ff0ac3c 24562011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2457
4c4b566b
PE
2458 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2459
aab2b9b5
PE
2460 * term.c (vfatal): Remove stray call to va_end.
2461 It's not needed and the C Standard doesn't allow it here anyway.
2462
c378da0b
PE
2463 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2464 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2465
288b08c7
PE
2466 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2467 bytes.
2468
e3601888
PE
2469 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2470
db6c0e74
PE
2471 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2472
dd5963ea
PE
2473 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2474
88c9450f
PE
2475 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2476
2f9442b8
PE
2477 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2478
c032b5f8
PE
2479 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2480 * charset.c (Fdefine_charset_internal): Don't initialize
2481 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2482 32-bit int (Bug#8600).
a108c10b
PE
2483
2484 * lread.c (read_integer): Be more consistent with string-to-number.
2485 Use string_to_number to do the actual conversion; this avoids
2486 rounding errors and fixes some other screwups. Without this fix,
2487 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2488 (digit_to_number): Move earlier, for benefit of read_integer.
2489 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2490 not a digit in any supported base. (Bug#8602)
a108c10b 2491
ad5f9eea
PE
2492 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2493
aec1708a
PE
2494 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2495 to match comment at start of function. This also removes a
2496 GCC warning about overflow in a 32+64-bit port.
2497
47be4ab5
PE
2498 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2499
371cac43
PE
2500 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2501 Reported by Stefan Monnier in
2502 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2503 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2504 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2505
d01a7826
PE
2506 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2507 (EMACS_UINTPTR): Likewise, with uintptr_t.
2508
7fd47d5c
PE
2509 * lisp.h: Prefer 64-bit EMACS_INT if available.
2510 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2511 on 32-bit hosts that have 64-bit int, so that they can access
2512 large files.
122b0c86
PE
2513 However, temporarily disable this change unless the temporary
2514 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2515
8727937b
PE
2516 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2517
8ac068ac
PE
2518 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2519 This removes an assumption that EMACS_INT and long are the same
2520 width as pointers. The assumption is true for Emacs porting targets
2521 now, but we want to make other targets possible.
2522 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2523 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2524 In the rest of the code, change types of integers that hold casted
2525 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2526 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2527 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2528 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2529 No need to cast type when ORing.
2530 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2531 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2532 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2533 assume EMACS_INT is the same width as char *.
2534 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2535 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2536 Remove no-longer-needed casts.
2537 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2538 (xg_tool_bar_help_callback, xg_make_tool_item):
2539 Use EMACS_INTPTR to hold an integer
2540 that will be cast to void *; this can avoid a GCC warning
2541 if EMACS_INT is not the same width as void *.
2542 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2543 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2544 (current_message_1, set_message_1):
2545 Use a local to convert to proper width without a cast.
2546 * xmenu.c (dialog_selection_callback): Likewise.
2547
ede49d71
PE
2548 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2549 Also, don't assume VALBITS / RAND_BITS is less than 5,
2550 and don't rely on undefined behavior when shifting a 1 left into
2551 the sign bit.
2552 * lisp.h (get_random): Change signature to match.
2553
2f30ecd0
PE
2554 * lread.c (hash_string): Use size_t, not int, for hash computation.
2555 Normally we prefer signed values; but hashing is special, because
2556 it's better to use unsigned division on hash table sizes so that
2557 the remainder is nonnegative. Also, size_t is the natural width
2558 for hashing into memory. The previous code used 'int', which doesn't
2559 retain enough info to hash well into very large tables.
2560 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2561
2a866e7b
PE
2562 * dbusbind.c: Don't possibly lose pointer info when converting.
2563 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2564 Use XPNTR rather than XHASH, so that the high-order bits of
2565 the pointer aren't lost when converting through void *.
2566
51639eac
PE
2567 * eval.c (Fautoload): Don't double-shift a pointer.
2568
92394119
PE
2569 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2570
dbdb9a7c
JB
25712011-05-06 Juanma Barranquero <lekktu@gmail.com>
2572
2573 * gnutls.c (DEF_GNUTLS_FN):
2574 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2575
db7a0b4f
AS
25762011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2579 marker. (Bug#8610)
2580
f7ff1b0f 25812011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2582
2583 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2584 New version that can reserve upto 2GB of heap space.
2585
f7ff1b0f 25862011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2587
2588 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2589
639c109b
TZ
25902011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2591
2592 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2593 `gnutls_certificate_set_x509_key_file'.
2594
d2127135
JB
25952011-05-05 Juanma Barranquero <lekktu@gmail.com>
2596
2597 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2598 Update dependencies.
2599
e968f4f3
JB
26002011-05-04 Juanma Barranquero <lekktu@gmail.com>
2601
2602 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2603 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2604 Remove unused parameter `fildes'.
2605 * process.c (read_process_output, send_process): Don't pass it.
2606
84d358f0
JB
26072011-05-04 Juanma Barranquero <lekktu@gmail.com>
2608
2609 Fix previous change: the library cache is defined in w32.c.
2610 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2611 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2612
0898ca10
JB
26132011-05-04 Juanma Barranquero <lekktu@gmail.com>
2614
2615 Implement dynamic loading of GnuTLS on Windows.
2616
2617 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2618 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2619 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2620 Declare.
2621
2622 * gnutls.c (Qgnutls_dll): Define.
2623 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2624 (gnutls_*): Declare function pointers.
2625 (init_gnutls_functions): New function to initialize function pointers.
2626 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2627 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2628 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2629 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2630 (emacs_gnutls_write, emacs_gnutls_read)
2631 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2632 (Fgnutls_available_p): New function.
2633 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2634 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2635 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2636
2637 * image.c: Include w32.h.
2638 (Vimage_type_cache): Delete.
2639 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2640 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2641 (w32_delayed_load): Move to w32.c.
2642
2643 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2644
2645 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2646 (w32_delayed_load): Move from image.c. When loading a library, record
2647 its filename in the :loaded-from property of the library id.
2648 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2649 Initialize and staticpro them.
2650 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2651
2652 * process.c: Include lisp.h before w32.h, not after.
2653 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2654 instead of gnutls_record_check_pending.
2655
2656 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2657
ff4de4aa
TZ
26582011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2659
2660 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2661 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2662 as passed in.
2663
abe95abb
JD
26642011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2665
2666 * xterm.c (x_set_frame_alpha): Do not set property on anything
2667 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2668
e16e55d4
JB
26692011-05-02 Juanma Barranquero <lekktu@gmail.com>
2670
2671 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2672
bafcf6a5
JB
26732011-05-02 Juanma Barranquero <lekktu@gmail.com>
2674
2675 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2676 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2677 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2678 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2679 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2680 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2681 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2682 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2683 (Qgnutls_bootprop_callbacks_verify): Make static.
2684
e7a6747f
AS
26852011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2686
19ed11ba
AS
2687 * callproc.c: Indentation fixup.
2688
e7a6747f 2689 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2690 (wait_for_termination, interruptible_wait_for_termination):
2691 Move after wait_for_termination_1.
e7a6747f 2692
1ef14cb4
LMI
26932011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2694
2695 * sysdep.c (interruptible_wait_for_termination): New function
2696 which is like wait_for_termination, but allows keyboard
2697 interruptions.
2698
2699 * callproc.c (Fcall_process): Add (:file "file") as an option for
2700 the STDOUT buffer.
2701 (Fcall_process_region): Ditto.
2702
330d880c
EZ
27032011-04-30 Eli Zaretskii <eliz@gnu.org>
2704
8db90b73
EZ
2705 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2706 rather than `XVECTOR (FOO)->size'.
2707
330d880c
EZ
2708 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2709 inttypes.h, as a gnulib replacement is used if it not available in
2710 system headers.
2711
15cbd324
EZ
27122011-04-21 Eli Zaretskii <eliz@gnu.org>
2713
2714 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2715 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2716 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2717
2718 * coding.c (coding_alloc_by_realloc): Error out if destination
2719 will grow beyond MOST_POSITIVE_FIXNUM.
2720 (decode_coding_emacs_mule): Abort if there isn't enough place in
2721 charbuf for the composition carryover bytes. Reserve an extra
2722 space for up to 2 characters produced in a loop.
2723 (decode_coding_iso_2022): Abort if there isn't enough place in
2724 charbuf for the composition carryover bytes.
2725
27262011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2727
ae940cca
EZ
2728 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2729 aborting when %lld or %lll format is passed.
2730 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2731 %llo or %llx format is passed. (Bug#8545)
2732
03ab8921
EZ
2733 * window.c (window_scroll_line_based): Use a marker instead of
2734 simple variables to record original value of point. (Bug#7952)
2735
afda1437
EZ
2736 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2737 produced by %s or %c overflows available buffer space. (Bug#8545)
2738
f76dee0c
PE
27392011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2742 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2743
fdc5744d
JB
27442011-04-28 Juanma Barranquero <lekktu@gmail.com>
2745
2746 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2747
638f053a
JB
27482011-04-28 Juanma Barranquero <lekktu@gmail.com>
2749
2750 * keyboard.c (Qdelayed_warnings_hook): Define.
2751 (command_loop_1): Run `delayed-warnings-hook'
2752 if Vdelayed_warnings_list is non-nil.
2753 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2754 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2755
d178f871
EZ
27562011-04-28 Eli Zaretskii <eliz@gnu.org>
2757
2758 * doprnt.c (doprnt): Don't return value smaller than the buffer
2759 size if the message was truncated. (Bug#8545).
2760
b124fd93
JB
27612011-04-28 Juanma Barranquero <lekktu@gmail.com>
2762
2763 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2764 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2765
e810457d
PE
27662011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2769
ea51cceb
JB
27702011-04-27 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * makefile.w32-in: Update dependencies.
2773
94dcfacf
EZ
27742011-04-27 Eli Zaretskii <eliz@gnu.org>
2775
2776 Improve `doprnt' and its usage. (Bug#8545)
2777 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2778 `format_end'. Remove support for %l as a conversion specifier.
2779 Don't use xrealloc. Improve diagnostics when the %l size modifier
2780 is used. Update the commentary.
2781
2782 * eval.c (verror): Simplify calculation of size_t.
2783
2784 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2785 messages.
2786
f61f41d7
PE
27872011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2788
2789 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2790 change.
2791
96fb4434
PE
27922011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2793
2794 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2795 This makes this file independent of the recent pseudovector change.
2796
671875da 27972011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2798
69e9b5a3
PE
2799 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2800
b5f869a7 2801 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2802 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2803 Remove unused local.
c8926152 2804 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2805
841a1577 2806 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2807 GCC 4.6.0 optimizes based on type-based alias analysis.
2808 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2809 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2810 != &v->size, and therefore "v->size = 1; b->size = 2; return
2811 v->size;" must therefore return 1. This assumption is incorrect
2812 for Emacs, since it type-puns struct Lisp_Vector * with many other
2813 types. To fix this problem, this patch adds a new type struct
f904488f 2814 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2815 and pseudovectors, and helps optimizing compilers not get fooled
2816 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2817 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2818 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2819 the size member.
eab3844f
PE
2820 (XSETPVECTYPE): Rewrite in terms of new macro.
2821 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2822 This is a bit clearer, and further avoids the possibility of
2823 undesirable aliasing.
2824 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2825 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2826 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2827 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2828 (ASIZE): Now uses header.size rather than size.
2829 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2830 to avoid the hassle of writing XVECTOR (foo)->header.size.
2831 (struct vectorlike_header): New type.
eab3844f
PE
2832 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2833 object, to help avoid aliasing.
2834 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2835 (SUBRP): Likewise, since Lisp_Subr is a special case.
2836 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2837 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2838 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2839 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2840 changed to be "header.size" and "header.next".
2841 * buffer.h (struct buffer): Likewise.
2842 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2843 * frame.h (struct frame): Likewise.
2844 * process.h (struct Lisp_Process): Likewise.
2845 * termhooks.h (struct terminal): Likewise.
2846 * window.c (struct save_window_data, struct saved_window): Likewise.
2847 * window.h (struct window): Likewise.
2848 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2849 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2850 * buffer.c (init_buffer_once): Likewise.
2851 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2852 special case.
2853 * process.c (Fformat_network_address): Use local var for size,
2854 for brevity.
2855
0df1eac5
PE
2856 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2857
847ab9d1 2858 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2859 * data.c (atof): Remove decl; no longer used or needed.
2860 (digit_to_number): Move to lread.c.
2861 (Fstring_to_number): Use new string_to_number function, to be
2862 consistent with how the Lisp reader treats infinities and NaNs.
2863 Do not assume that floating-point numbers represent EMACS_INT
2864 without losing information; this is not true on most 64-bit hosts.
2865 Avoid double-rounding errors, by insisting on integers when
2866 parsing non-base-10 numbers, as the documentation specifies.
2867 * lisp.h (string_to_number): New decl, replacing ...
2868 (isfloat_string): Remove.
bc0a5c13 2869 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2870 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2871 appears to have been a coding error. Similarly, do not accept
2872 strings like +-1e0 as floating point numbers. Do not report
2873 overflow for integer overflows unless the base is not 10 which
2874 means we have no simple and reliable way to continue.
2875 Break out the floating-point parsing into a new
2876 function string_to_number, so that Fstring_to_number parses
2877 floating point numbers consistently with the Lisp reader.
04f2d78b 2878 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2879 (E_CHAR, EXP_INT): Remove, replacing with ...
2880 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2881 (string_to_number): New function, replacing isfloat_string.
2882 This function checks for valid syntax and produces the resulting
2883 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2884 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2885 so that overflow for non-base-10 numbers is reported only when
2886 there's no portable and simple way to convert to floating point.
452f4150 2887
67769ffc
PE
2888 * textprop.c (set_text_properties_1): Rewrite for clarity,
2889 and to avoid GCC warning about integer overflow.
2890
c20db43f
PE
2891 * intervals.h (struct interval): Use EMACS_INT for members
2892 where EMACS_UINT might cause problems. See
2893 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2894 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2895 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2896 All uses changed.
37aa2f85
PE
2897 (offset_intervals): Tell GCC not to worry about length overflow
2898 when negating a negative length.
c20db43f 2899
2538aa2f
PE
2900 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2901 (overrun_check_free): Likewise.
2902
f2d3008d
PE
2903 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2904 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2905 word size.
2906
ec8df744
PE
2907 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2908 (gnutls_make_error): Rename local to avoid shadowing.
2909 (gnutls_emacs_global_deinit): ifdef out; not used.
2910 (Fgnutls_boot): Use const for pointer to readonly storage.
2911 Comment out unused local. Fix pointer signedness problems.
2912
640ee02d
PE
2913 * lread.c (openp): Don't stuff size_t into an 'int'.
2914 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2915 about possible signed overflow.
2916
6048fb2a
PE
2917 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2918 (GDK_KEY_g): Don't define if already defined.
2919 (xg_prepare_tooltip): Avoid pointer signedness problem.
2920 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2921
fa3c87e1
PE
2922 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2923 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2924
2172544b
PE
2925 * xfns.c (Fx_window_property): Simplify a bit,
2926 to make a bit faster and to avoid GCC 4.6.0 warning.
2927 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2928
9b821a21
PE
2929 * fns.c (internal_equal): Don't assume size_t fits in int.
2930
3c616cfa
PE
2931 * alloc.c (compact_small_strings): Tighten assertion a little.
2932
c2982e87
PE
2933 Replace pEd with more-general pI, and fix some printf arg casts.
2934 * lisp.h (pI): New macro, generalizing old pEd macro to other
2935 conversion specifiers. For example, use "...%"pI"d..." rather
2936 than "...%"pEd"...".
2937 (pEd): Remove. All uses replaced with similar uses of pI.
2938 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2939 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2940 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2941 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2942 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2943 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2944 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2945 64-bit hosts.
2946 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2947 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2948 * print.c (safe_debug_print, print_object): Likewise.
2949 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2950 to int.
6f04d126
PE
2951 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2952 avoiding the 0 flag, which is not portable.
c2982e87
PE
2953 * process.c (Fmake_network_process): Use pI to avoid cast.
2954 * region-cache.c (pp_cache): Likewise.
2955 * xdisp.c (decode_mode_spec): Likewise.
2956 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2957 behavior on 64-bit hosts with printf arg.
6f04d126 2958 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2959 (x_stop_queuing_selection_requests): Likewise.
2960 (x_get_window_property): Don't truncate byte count to an 'int'
2961 when tracing.
0b432f21 2962
5e073ec7
PE
2963 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2964 here, since it parses constructs like leading '-' and spaces,
2965 which are not wanted; and it overflows with large numbers.
2966 Instead, simply match F[0-9]+, which is what is wanted anyway.
2967
36372bf9
PE
2968 * alloc.c: Remove unportable assumptions about struct layout.
2969 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2970 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2971 (allocate_vectorlike, make_pure_vector): Use the new macros,
2972 plus offsetof, to remove unportable assumptions about struct layout.
2973 These assumptions hold on all porting targets that I know of, but
2974 they are not guaranteed, they're easy to remove, and removing them
2975 makes further changes easier.
2976
0b432f21
PE
2977 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2978 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2979 (string_overrun_cookie): Now const. Use initializers that
2980 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2981 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2982 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2983 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2984 multiple of sizeof (EMACS_INT); it need not be, if
2985 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2986 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2987
895009e1
JB
29882011-04-26 Juanma Barranquero <lekktu@gmail.com>
2989
2990 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2991
6a7a1b0b
TZ
29922011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2993
2994 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2995 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2996 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2997
841a1577 29982011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2999
3000 * lisp.h (Qdebug): List symbol.
895009e1 3001 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3002 * keyboard.c (debug-on-event): New variable.
3003 (handle_user_signal): Break into debugger when debug-on-event
3004 matches the current signal symbol.
3005
f2d3ba6f
DN
30062011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3007
3008 * alloc.c (check_sblock, check_string_bytes)
3009 (check_string_free_list): Convert to standard C.
3010
42ce4c63
TZ
30112011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3012
3013 * w32.c (emacs_gnutls_push): Fix typo.
3014
825cd63c
EZ
30152011-04-25 Eli Zaretskii <eliz@gnu.org>
3016
fb11d64d
EZ
3017 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3018 "cast to pointer from integer of different size".
3019
825cd63c
EZ
3020 Improve doprnt and its use in verror. (Bug#8545)
3021 * doprnt.c (doprnt): Document the set of format control sequences
3022 supported by the function. Use SAFE_ALLOCA instead of always
3023 using `alloca'.
3024
3025 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3026 is one byte too soon. Don't use xrealloc; instead xfree and
3027 xmalloc anew.
3028
e061a11b
TZ
30292011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3030
3031 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3032 callbacks stage.
3033
3034 * gnutls.c: Renamed global_initialized to
3035 gnutls_global_initialized. Added internals for the
3036 :verify-hostname-error, :verify-error, and :verify-flags
3037 parameters of `gnutls-boot' and documented those parameters in the
3038 docstring. Start callback support.
9173deec
JB
3039 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3040 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3041 on error. Return error code.
e061a11b
TZ
3042 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3043 (emacs_gnutls_read): Likewise.
3044 (Fgnutls_boot): Return handshake error code.
3045 (emacs_gnutls_handle_error): New function.
3046 (wsaerror_to_errno): Likewise.
3047
3048 * w32.h (emacs_gnutls_pull): Add prototype.
3049 (emacs_gnutls_push): Likewise.
3050
3051 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3052 (emacs_gnutls_push): Likewise.
3053
30542011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3055
3056 * process.c (wait_reading_process_output): Check if GnuTLS
3057 buffered some data internally if no FDs are set for TLS
3058 connections.
3059
3060 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3061 (LIBS): Link to USER_LIBS.
3062 ($(BLD)/gnutls.$(0)): New target.
3063
fa6996bc
EZ
30642011-04-24 Eli Zaretskii <eliz@gnu.org>
3065
eb35682e
EZ
3066 * xdisp.c (handle_single_display_spec): Rename the
3067 display_replaced_before_p argument into display_replaced_p, to
3068 make it consistent with the commentary. Fix typos in the
3069 commentary.
3070
e2ad650c
EZ
3071 * textprop.c (syms_of_textprop): Remove dead code.
3072 (copy_text_properties): Delete obsolete commentary about an
3073 interface that was deleted long ago. Fix typos in the description
3074 of arguments.
3075
1b2de274
EZ
3076 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3077 to changes in oldXMenu/XMenu.h from 2011-04-16.
3078 <menu_help_message, prev_menu_help_message>: Constify.
3079 (IT_menu_make_room): menu->help_text is now `const char **';
3080 adjust.
3081
3082 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3083 to changes in oldXMenu/XMenu.h from 2011-04-16.
3084 (struct XMenu): Declare `help_text' `const char **'.
3085
3086 * xfaces.c <Qunspecified>: Make extern again.
3087
3088 * syntax.c: Include sys/types.h before including regex.h, as
3089 required by Posix.
3090
762b15be
EZ
3091 * doc.c (get_doc_string): Improve the format passed to `error'.
3092
3093 * doprnt.c (doprnt): Improve commentary.
3094
3095 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3096
3097 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3098 them with etags.
3099
f1052e5d
EZ
3100 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3101 changes in globals.h immediately force recompilation.
762b15be
EZ
3102 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3103 $(CURDIR)/s/ms-w32.h.
3104 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3105
fa6996bc
EZ
3106 * character.c (Fchar_direction): Function deleted.
3107 (syms_of_character): Don't defsubr it.
3108 <char-direction-table>: Deleted.
3109
e6c3da20
EZ
31102011-04-23 Eli Zaretskii <eliz@gnu.org>
3111
3112 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3113 * doprnt.c: Include limits.h.
3114 (SIZE_MAX): New macro.
04f2d78b
CB
3115 (doprnt): Return a size_t value. 2nd arg is now size_t.
3116 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3117 Improve overflow protection. Support `l' modifier for integer
3118 conversions. Support %l conversion. Don't assume an EMACS_INT
3119 argument for integer conversions and for %c.
3120
3121 * lisp.h (doprnt): Restore prototype.
3122
3123 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3124 $(SRC)/character.h.
3125
3126 * Makefile.in (base_obj): Add back doprnt.o.
3127
3128 * deps.mk (doprnt.o): Add back prerequisites.
3129 (callint.o): Depend on character.h.
3130
3131 * eval.c (internal_lisp_condition_case): Include the handler
3132 representation in the error message.
3133 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3134 when breaking from the loop.
3135
3136 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3137
3138 * callint.c (Fcall_interactively): When displaying error message
3139 about invalid control letter, pass the character's codepoint, not
3140 a pointer to its multibyte form. Improve display of the character
3141 in octal and display also its hex code.
3142
3143 * character.c (char_string): Use %x to display the (unsigned)
3144 codepoint of an invalid character, to avoid displaying a bogus
3145 negative value.
3146
3147 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3148 `error', not SYMBOL_NAME itself.
3149
3150 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3151 character arguments to `error'.
3152
3153 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3154 to `error' in error message about FINAL_CHAR argument. Make sure
3155 FINAL_CHAR is a character, and use %c when it is passed as
3156 argument to `error'.
3157
4ffd0d6b 31582011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3159
3160 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3161
3162 * w32.c: Include <time.h>.
3163 (sys_localtime): New function.
3164
4ffd0d6b 31652011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3166
3167 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3168
4ffd0d6b 3169 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3170
4ffd0d6b 31712011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3172
4ffd0d6b
GM
3173 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3174 zombies (Bug#8467).
aac0c6e3 3175
04c56954
EZ
31762011-04-19 Eli Zaretskii <eliz@gnu.org>
3177
3178 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3179 gl_state.e_property when gl_state.object is Qt.
3180
3181 * insdel.c (make_gap_larger): Remove limitation of buffer size
3182 to <= INT_MAX.
3183
16a43933
CY
31842011-04-18 Chong Yidong <cyd@stupidchicken.com>
3185
3186 * xdisp.c (lookup_glyphless_char_display)
3187 (produce_glyphless_glyph): Handle cons cell entry in
3188 glyphless-char-display.
3189 (Vglyphless_char_display): Document it.
3190
3191 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3192 glyphless-char-display.
3193
4581706e
CY
31942011-04-17 Chong Yidong <cyd@stupidchicken.com>
3195
3196 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3197
3198 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3199
3200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3201 definition for no-X builds.
3202
4887c6e2 32032011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3204
fd35b6f9
PE
3205 Static checks with GCC 4.6.0 and non-default toolkits.
3206
5c1ccb01
PE
3207 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3208
006c5daa
PE
3209 * process.c (keyboard_bit_set): Define only if SIGIO.
3210 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3211 (send_process): Repair possible setjmp clobbering.
3212
efc736d3
PE
3213 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3214
4e2fe2e6
PE
3215 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3216
f97334a2
PE
3217 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3218
4e75f29d
PE
3219 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3220 Define only if needed.
3221
90efadd1
PE
3222 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3223 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3224 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3225
3c647824
PE
3226 * dispextern.h (struct redisplay_interface): Rename param
3227 to avoid shadowing.
e264f262 3228 * termhooks.h (struct terminal): Likewise.
761383f4 3229 * xterm.c (xembed_send_message): Likewise.
3c647824 3230
b58c5c4a
PE
3231 * insdel.c (make_gap_smaller): Define only if
3232 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3233
cad59032
PE
3234 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3235 it.
3236
c339dc2e
PE
3237 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3238 so that we aren't warned about unused symbols.
3239
91a3e27b
PE
3240 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3241
399c71d3 3242 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3243
8ffc96f5
PE
3244 * xfns.c (x_real_positions): Mark locals as initialized.
3245
eef9bc79
PE
3246 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3247
098db9dd
PE
3248 * xterm.c: Fix problems found by static analysis with other toolkits.
3249 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3250 (x_dispatch_event): Declare static if USE_GTK, and
3251 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3252 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3253 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3254 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3255 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3256
eb18f6cc
PE
3257 * xmenu.c (menu_help_callback): Pointer type fixes.
3258 Use const pointers when pointing at readonly data. Avoid pointer
3259 signedness clashes.
3260 (FALSE): Remove unused macro.
3261 (update_frame_menubar): Remove unused decl.
3262
1fe72bf8
PE
3263 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3264
60d9e1db
PE
3265 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3266 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3267 (single_menu_item): Rename local to avoid shadowing.
3268
39261c26
PE
3269 * keyboard.c (make_lispy_event): Remove unused local var.
3270
018c5e19
PE
3271 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3272 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3273
63d2b86e
PE
3274 * bitmaps: Change bitmaps from unsigned char back to the X11
3275 compatible char. Avoid the old compiler warnings about
3276 out-of-range initializers by using, for example, '\xab' rather
3277 than 0xab.
3278
aefd87e1
PE
3279 * xgselect.c (xgselect_initialize): Check vs interface
3280 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3281
bf501fb9
PE
3282 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3283
e9829fdf
PE
3284 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3285 to read-only memory.
3286
1086c095
PE
3287 * fns.c (vector): Remove; this old hack is no longer needed.
3288
2baccd04 3289 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3290 Remove unused var.
dde42981 3291 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3292
72391843 3293 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3294
436c16df 3295 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3296 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3297 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3298
92bb796d 3299 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3300 (x_term_init): Remove local to avoid shadowing.
92bb796d 3301
764430a3 3302 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3303
3304 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3305 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3306
d1dfb56c
EZ
33072011-04-16 Eli Zaretskii <eliz@gnu.org>
3308
c4354cb4
EZ
3309 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3310
d1dfb56c
EZ
3311 Fix regex.c, syntax.c and friends for buffers > 2GB.
3312 * syntax.h (struct gl_state_s): Declare character position members
3313 EMACS_INT.
3314
3315 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3316
04f2d78b
CB
3317 * textprop.c (verify_interval_modification, interval_of):
3318 Declare arguments EMACS_INT.
d1dfb56c
EZ
3319
3320 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3321 EMACS_INT.
3322
3323 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3324
3325 * indent.c (Fvertical_motion): Local variable it_start is now
3326 EMACS_INT.
3327
3328 * regex.c (re_match, re_match_2, re_match_2_internal)
3329 (bcmp_translate, regcomp, regexec, print_double_string)
3330 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3331 (re_compile_pattern, re_exec): Declare arguments and local
3332 variables `size_t' and `ssize_t' and return values `regoff_t', as
3333 appropriate.
3334 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3335 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3336 <compile_stack_type>: `size' and `avail' are now `size_t'.
3337
3338 * regex.h <regoff_t>: Use ssize_t, not int.
3339 (re_search, re_search_2, re_match, re_match_2): Arguments that
3340 specify buffer/string position and length are now ssize_t and
3341 size_t. Return type is regoff_t.
3342
613052cd
BK
33432011-04-16 Ben Key <bkey76@gmail.com>
3344
3345 * nsfont.m: Fixed bugs in ns_get_family and
3346 ns_descriptor_to_entity that were caused by using free to
3347 deallocate memory blocks that were allocated by xmalloc (via
3348 xstrdup). This caused Emacs to crash when compiled with
3349 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3350 --enable-checking=xmallocoverrun). xfree is now used to
3351 deallocate these memory blocks.
3352
4170f62f 33532011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3354
71b41406
PE
3355 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3356
9587a89d
PE
3357 emacs_write: Accept and return EMACS_INT for sizes.
3358 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3359 et seq.
3360 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3361 Accept and return EMACS_INT.
3362 (emacs_gnutls_write): Return the number of bytes written on
3363 partial writes.
3364 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3365 (emacs_read, emacs_write): Remove check for negative size, as the
3366 Emacs source code has been audited now.
9587a89d
PE
3367 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3368 (emacs_read, emacs_write): Use it.
273a5f82
PE
3369 * process.c (send_process): Adjust to the new signatures of
3370 emacs_write and emacs_gnutls_write. Do not attempt to store
3371 a byte offset into an 'int'; it might overflow.
9587a89d 3372 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3373
3e047f51
PE
3374 * sound.c: Don't assume sizes fit in 'int'.
3375 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3376 Return EMACS_INT, not int.
3e047f51 3377 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3378 Accept EMACS_INT, not int.
3379 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3380 record read return values.
3381
cc39a9db
BK
33822011-04-15 Ben Key <bkey76@gmail.com>
3383
c9d0ec6d
JB
3384 * keyboard.c (Qundefined): Don't declare static since it is used
3385 in nsfns.m.
3386 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3387 static since they are used in nsfont.m.
cc39a9db 3388
6c60eb9f
SM
33892011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * process.c (Qprocessp): Don't declare static.
3392 * lisp.h (Qprocessp): Declare again.
3393
7990b61a
JB
33942011-04-15 Juanma Barranquero <lekktu@gmail.com>
3395
3396 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3397
5d4cb038
PE
33982011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3399
8bd7b830 3400 Improve C-level modularity by making more things 'static'.
cd64ea1d 3401
e3b27b31
PE
3402 Don't publish debugger-only interfaces to other modules.
3403 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3404 (verify_bytepos, count_markers): Move decls to the only modules
3405 that need them.
3406 * region-cache.h (pp_cache): Likewise.
3407 * window.h (check_all_windows): Likewise.
3408 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3409
5d4cb038
PE
3410 * sysdep.c (croak): Now static, if
3411 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3412 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3413
3414 * alloc.c (refill_memory_reserve): Now static if
3415 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3416 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3417
e87b6180
PE
3418 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3419 Define only if USE_LUCID.
3420
ac64929e
PE
3421 * xrdb.c (x_customization_string, x_rm_string): Now static.
3422
6f37259d
PE
3423 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3424 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3425
1683e3ab
PE
3426 * xdisp.c (draw_row_with_mouse_face): Now static.
3427 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3428
de9c2632
PE
3429 * window.h (check_all_windows): Mark externally visible.
3430
2b96acb7
PE
3431 * window.c (window_deletion_count): Now static.
3432
3433 * undo.c: Make symbols static if they're not exported.
3434 (last_undo_buffer, last_boundary_position, pending_boundary):
3435 Now static.
3436
50436f33
PE
3437 * textprop.c (interval_insert_behind_hooks): Now static.
3438 (interval_insert_in_front_hooks): Likewise.
3439
64520e5c
PE
3440 * term.c: Make symbols static if they're not exported.
3441 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3442 (max_frame_lines, tty_set_terminal_modes):
3443 (tty_reset_terminal_modes, tty_turn_off_highlight):
3444 (get_tty_terminal): Now static.
3445 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3446 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3447 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3448 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3449 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3450
1fa53021
PE
3451 * sysdep.c: Make symbols static if they're not exported.
3452 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3453 Now static.
3454 (sigprocmask_set, full_mask): Remove; unused.
3455 (wait_debugging): Mark as visible.
3456 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3457 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3458
d4b43b22
PE
3459 * syntax.c (syntax_temp): Define only if !__GNUC__.
3460
b7c513d0
PE
3461 * sound.c (current_sound_device, current_sound): Now static.
3462
989b29ad
PE
3463 * search.c (searchbufs, searchbuf_head): Now static.
3464
13a55a78
PE
3465 * scroll.c (scroll_cost): Remove; unused.
3466 * dispextern.h (scroll_cost): Remove decl.
3467
de68a1fc
PE
3468 * region-cache.h (pp_cache): Mark as externally visible.
3469
40ccffa6
PE
3470 * process.c: Make symbols static if they're not exported.
3471 (process_tick, update_tick, create_process, chan_process):
3472 (Vprocess_alist, proc_buffered_char, datagram_access):
3473 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3474 (deactivate_process): Mark defn as static, as well as decl.
3475 * lisp.h (create_process): Remove decl.
3476 * process.h (chan_process, Vprocess_alist): Remove decls.
3477
ad64fc97
PE
3478 * print.c: Make symbols static if they're not exported.
3479 (print_depth, new_backquote_output, being_printed, print_buffer):
3480 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3481 (print_interval, print_number_index, initial_stderr_stream):
3482 Now static.
3483 * lisp.h (Fprinc): Remove decl.
3484 (debug_output_compilation_hack): Mark as externally visible.
3485
adddb265
PE
3486 * sysdep.c (croak): Move decl from here to syssignal.h.
3487 * syssignal.h (croak): Put it here, so the API can be checked when
3488 'croak' is called from dissociate_if_controlling_tty.
3489
1717ede2
PE
3490 * minibuf.c: Make symbols static if they're not exported.
3491 (minibuf_save_list, choose_minibuf_frame): Now static.
3492 * lisp.h (choose_minibuf_frame): Remove decl.
3493
fa5fb2bc
PE
3494 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3495
1e3890d1
PE
3496 * lread.c: Make symbols static if they're not exported.
3497 (read_objects, initial_obarray, oblookup_last_bucket_number):
3498 Now static.
3499 (make_symbol): Remove; unused.
3500 * lisp.h (initial_obarray, make_symbol): Remove decls.
3501
8a1414fa
PE
3502 * keyboard.c: Make symbols static if they're not exported.
3503 (single_kboard, recent_keys_index, total_keys, recent_keys):
3504 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3505 (this_single_command_key_start, echoing, last_auto_save):
3506 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3507 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3508 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3509 (Vlispy_mouse_stem, double_click_count):
3510 Now static.
3511 (force_auto_save_soon): Define only if SIGDANGER.
3512 (ignore_mouse_drag_p): Now static if
3513 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3514 (print_help): Remove; unused.
3515 (stop_character, last_timer_event): Mark as externally visible.
3516 * keyboard.h (ignore_mouse_drag_p): Declare only if
3517 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3518 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3519 * lisp.h (echoing): Remove decl.
3520 (force_auto_save_soon): Declare only if SIGDANGER.
3521 * xdisp.c (redisplay_window): Simplify code, to make it more
3522 obvious that ignore_mouse_drag_p is not accessed if !defined
3523 USE_GTK && !defined HAVE_NS.
3524
93ea6e8f
PE
3525 * intervals.c: Make symbols static if they're not exported.
3526 (merge_properties_sticky, merge_interval_right, delete_interval):
3527 Now static.
3528 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3529
77382fcc
PE
3530 * insdel.c: Make symbols static if they're not exported.
3531 However, leave prepare_to_modify_buffer alone. It's never
3532 called from outside this function, but that appears to be a bug.
3533 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3534 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3535 (adjust_after_replace_noundo): Remove; unused.
3536 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3537 (signal_before_change): Remove decls.
77382fcc 3538
9306c32e
PE
3539 * indent.c (val_compute_motion, val_vmotion): Now static.
3540
cd44d2eb
PE
3541 * image.c: Make symbols static if they're not exported.
3542 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3543 if USE_GTK.
3544 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3545 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3546
ad9a7a06
PE
3547 * fringe.c (standard_bitmaps): Now static.
3548 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3549
81626931
PE
3550 * frame.c: Make symbols static if they're not exported.
3551 (x_report_frame_params, make_terminal_frame): Now static.
3552 (get_frame_param): Now static, unless HAVE_NS.
3553 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3554 (x_get_resource_string): Remove; not used.
3555 * frame.h (make_terminal_frame, x_report_frame_params):
3556 (x_get_resource_string); Remove decls.
3557 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3558 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3559
239f9db9
PE
3560 * font.c, fontset.c: Make symbols static if they're not exported.
3561 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3562 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3563 * font.c (font_close_object): Now static.
3564 * font.h (font_close_object): Remove.
3565 * fontset.c (FONTSET_OBJLIST): Remove.
3566 (free_realized_fontset) #if-0 the body, which does nothing.
3567 (face_suitable_for_char_p): #if-0, as it's never called.
3568 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3569 * xfaces.c (face_at_string_position):
3570 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3571 since 0 is always ASCII.
3572
dfcf3579
PE
3573 * fns.c (weak_hash_tables): Now static.
3574
5045092b
PE
3575 * fileio.c: Make symbols static if they're not exported.
3576 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3577 (Vwrite_region_annotation_buffers): Now static.
3578
57a96f5c
PE
3579 * eval.c: Make symbols static if they're not exported.
3580 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3581 * lisp.h (backtrace_list): Remove decl.
3582
35f08c38
PE
3583 * emacs.c: Make symbols static if they're not exported.
3584 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3585 (fatal_error_code, fatal_error_signal_hook, standard_args):
3586 Now static.
3587 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3588 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3589 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3590 * lisp.h (fatal_error_signal_hook): Remove decl.
3591 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3592
f44bd759
PE
3593 * editfns.c: Move a (normally-unused) function to its only use.
3594 * editfns.c, lisp.h (get_operating_system_release): Remove.
3595 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3596 worth the hassle of breaking this out.
3597
b532497d
PE
3598 * xterm.c: Make symbols static if they're not exported.
3599 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3600 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3601 (x_destroy_window, x_delete_display):
3602 Now static.
3603 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3604 (x_mouse_leave): Remove; unused.
3605 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3606 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3607 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3608 Remove decls.
3609 (x_mouse_leave): Declare only if WINDOWSNT.
3610 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3611 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3612 USE_X_TOOLKIT.
3613
1675728f
PE
3614 * ftxfont.c: Make symbols static if they're not exported.
3615 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3616 HAVE_FREETYPE.
3617 * font.h (ftxfont_driver): Likewise.
3618
e4cebfca
PE
3619 * xfns.c: Make symbols static if they're not exported.
3620 (x_last_font_name, x_display_info_for_name):
3621 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3622 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3623 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3624 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3625 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3626 (last_show_tip_args): Now static.
3627 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3628 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3629 (x_screen_planes): Remove; unused.
3630 * dispextern.h (x_screen_planes): Remove decl.
3631
5bf46f05
PE
3632 * dispnew.c: Make symbols static if they're not exported.
3633 * dispextern.h (redraw_garbaged_frames, scrolling):
3634 (increment_row_positions): Remove.
3635 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3636 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3637 Now static.
3638 (redraw_garbaged_frames): Remove; unused.
3639
435f4c28
PE
3640 * xfaces.c: Make symbols static if they're not exported.
3641 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3642 Remove decls.
3643 * xterm.h (defined_color): Remove decls.
3644 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3645 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3646 (menu_face_changed_default, defined_color, free_realized_face):
3647 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3648 (ascii_face_of_lisp_face): Remove; unused.
3649
8524aef3
PE
3650 * xdisp.c: Make symbols static if they're not exported.
3651 * dispextern.h (scratch_glyph_row, window_box_edges):
3652 (glyph_to_pixel_coords, set_cursor_from_row):
3653 (get_next_display_element, set_iterator_to_next):
3654 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3655 (show_mouse_face): Remove decls
3656 * frame.h (message_buf_print): Likewise.
3657 * lisp.h (pop_message, set_message, check_point_in_composition):
3658 Likewise.
3659 * xterm.h (set_vertical_scroll_bar): Likewise.
3660 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3661 (message_buf_print, scratch_glyph_row, displayed_buffer):
3662 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3663 (get_next_display_element, show_mouse_face, window_box_edges):
3664 (frame_to_window_pixel_xy, check_point_in_composition):
3665 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3666 (glyph_to_pixel_coords): Remove; unused.
3667
16390cd2
PE
3668 * dired.c (file_name_completion): Now static.
3669
3670 * dbusbind.c (xd_in_read_queued_messages): Now static.
3671
a25f4dfa
PE
3672 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3673 * data.c (circular_list_error): Remove.
3674
14a9c8df
PE
3675 * commands.h (last_point_position, last_point_position_buffer):
3676 (last_point_position_window): Remove decls.
3677 * keyboard.c: Make these variables static.
3678
04f2d78b
CB
3679 * coding.h (coding, code_convert_region, encode_coding_gap):
3680 Remove decls.
74ab6df5
PE
3681 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3682 (iso_code_class, detect_coding, code_convert_region): Now static.
3683 (encode_coding_gap): Remove; unused.
3684
38dfbee1
PE
3685 * chartab.c (chartab_chars, chartab_bits): Now static.
3686
a2cb4e63
PE
3687 * charset.h (charset_iso_8859_1): Remove decl.
3688 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3689 Now static.
3690
127198fd
PE
3691 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3692 * ccl.c (Vccl_program_table): Now static.
3693 (check_ccl_update): Remove; unused.
3694
d85b608f
PE
3695 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3696 * category.h: ... from here.
3697 * category.c (check_category_table, set_category_set): Now static.
3698
31cd66f3
PE
3699 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3700 * lisp.h: Remove these decls.
3701
c358e587
PE
3702 * buffer.c (buffer_count): Remove unused var.
3703
e78aecca
PE
3704 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3705 so that it's not optimized away.
3706 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3707 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3708 exported only to the debugger.
3709
e192d7d3 3710 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3711 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3712
92470028
PE
3713 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3714 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3715 was inaccessible from Lisp.
3716 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3717 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3718
244ed907
PE
3719 alloc.c: Import and export fewer symbols, and remove unused items.
3720 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3721 is defined.
3722 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3723 it's not optimized away by whole-program optimization.
3724 (message_enable_multibyte, free_misc): Remove.
3725 (catchlist, handlerlist, mark_backtrace):
3726 Declare only if BYTE_MARK_STACK.
3727 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3728 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3729 (message_enable_multibyte): Remove decl.
3730 (free_misc, interval_free_list, float_block, float_block_index):
3731 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3732 (cons_free_list, last_marked_index):
3733 Now static.
3734 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3735 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3736 (mark_backtrace): Define only if BYTE_MARK_STACK.
3737 * xdisp.c (message_enable_multibyte): Now static.
3738
61c2b50e 3739 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3740 This makes it easier for human readers (and static analyzers)
3741 to see whether these variables are used from other modules.
3742 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3743 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3744 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3745 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3746 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3747 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3748 * xmenu.c, xselect.c:
3749 Declare Q* vars static if they are not used in other modules.
3750 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3751 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3752 Remove decls of unexported vars.
3753 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3754
95c82688
PE
3755 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3756
16a97296
PE
3757 Make Emacs functions such as Fatom 'static' by default.
3758 This makes it easier for human readers (and static analyzers)
3759 to see whether these functions can be called from other modules.
3760 DEFUN now defines a static function. To make the function external
3761 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3762 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3763 (Finit_image_library):
16a97296
PE
3764 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3765 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3766 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3767 Remove decls, since these functions are now static.
3768 (Funintern, Fget_internal_run_time): New decls, since these functions
3769 were already external.
95c82688 3770
16a97296
PE
3771 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3772 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3773 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3774 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3775 * keyboard.c, keymap.c, lread.c:
3776 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3777 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3778 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3779 Mark functions with DEFUE instead of DEFUN,
3780 if they are used in other modules.
3781 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3782 decls for now-static functions.
3783 * buffer.h (Fdelete_overlay): Remove decl.
3784 * callproc.c (Fgetenv_internal): Mark as internal.
3785 * composite.c (Fremove_list_of_text_properties): Remove decl.
3786 (Fcomposition_get_gstring): New forward static decl.
3787 * composite.h (Fcomposite_get_gstring): Remove decl.
3788 * dired.c (Ffile_attributes): New forward static decl.
3789 * doc.c (Fdocumntation_property): New forward static decl.
3790 * eval.c (Ffetch_bytecode): New forward static decl.
3791 (Funintern): Remove extern decl; now in .h file where it belongs.
3792 * fileio.c (Fmake_symbolic_link): New forward static decl.
3793 * image.c (Finit_image_library): New forward static decl.
3794 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3795 * intervals.h (Fprevious_property_change):
3796 (Fremove_list_of_text_properties): Remove decls.
3797 * keyboard.c (Fthis_command_keys): Remove decl.
3798 (Fcommand_execute): New forward static decl.
3799 * keymap.c (Flookup_key): New forward static decl.
3800 (Fcopy_keymap): Now static.
3801 * keymap.h (Flookup_key): Remove decl.
3802 * process.c (Fget_process): New forward static decl.
3803 (Fprocess_datagram_address): Mark as internal.
3804 * syntax.c (Fsyntax_table_p): New forward static decl.
3805 (skip_chars): Remove duplicate decl.
3806 * textprop.c (Fprevious_property_change): New forward static decl.
3807 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3808 Now internal.
3809 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3810 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3811
785bbd42
PE
3812 * editfns.c (Fformat): Remove unreachable code.
3813
8b913b57
AS
38142011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3815
3816 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3817 change. (Bug#8496)
3818
a6744a35
EZ
38192011-04-13 Eli Zaretskii <eliz@gnu.org>
3820
3821 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3822 when at ZV. (Bug#8487)
3823
e7974947
AS
38242011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3825
baad03f0
AS
3826 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3827 (Bug#8437)
3828 * keyboard.c (parse_tool_bar_item): Likewise.
3829 * sound.c (sound_cleanup, alsa_close): Likewise.
3830 * termcap.c (tgetent): Likewise.
3831 * xfns.c (x_default_font_parameter): Likewise.
3832 * xsettings.c (read_and_apply_settings): Likewise.
3833
e7974947
AS
3834 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3835 (overrun_check_free): Protoize.
3836
28272684
PE
38372011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3838
3839 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3840 since callers should never pass a negative size.
3841 Change the signature to match that of plain 'read' and 'write'; see
3842 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3843 * lisp.h: Update prototypes of emacs_write and emacs_read.
3844
11997c76
EZ
38452011-04-11 Eli Zaretskii <eliz@gnu.org>
3846
3847 * xdisp.c (redisplay_window): Don't try to determine the character
3848 position of the scroll margin if the window start point w->startp
e896f03c 3849 is outside the buffer's accessible region. (Bug#8468)
11997c76 3850
8a2cbd72
EZ
38512011-04-10 Eli Zaretskii <eliz@gnu.org>
3852
3853 Fix write-region and its subroutines for buffers > 2GB.
3854 * fileio.c (a_write, e_write): Modify declaration of arguments and
3855 local variables to support buffers larger than 2GB.
3856 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3857
3858 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3859 argument, local variables, and return value.
3860
3861 * lisp.h: Update prototypes of emacs_write and emacs_read.
3862
3863 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3864
4073e537 38652011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3866
1ebfdcb6
PE
3867 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3868
b2ded58d
PE
3869 Fix more problems found by GCC 4.6.0's static checks.
3870
7d66342c
PE
3871 * xdisp.c (vmessage): Use a better test for character truncation.
3872
bbf47d44
PE
3873 * charset.c (load_charset_map): <, not <=, for optimization,
3874 and to avoid potential problems with integer overflow.
9248994d 3875 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3876 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3877 * editfns.c (Fformat): Likewise.
1e69125e 3878 * syntax.c (skip_chars): Likewise.
3befa583 3879
e3019616
PE
3880 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3881 This also lets GCC 4.6.0 generate slightly better loop code.
3882
becfa255
PE
3883 * callint.c (Fcall_interactively): <, not <=, for optimization.
3884 (Fcall_interactively): Count the number of arguments produced,
3885 not the number of arguments given. This is simpler and lets GCC
3886 4.6.0 generate slightly better code.
3887
dae0cd48
PE
3888 * ftfont.c: Distingish more carefully between FcChar8 and char.
3889 The previous code passed unsigned char * to a functions like
3890 strlen and xstrcasecmp that expect char *, which does not
3891 conform to the C standard.
3892 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3893 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3894 char * when the C standard requires it.
3895
76032d70
PE
3896 * keyboard.c (read_char): Remove unused var.
3897
eb3f1cc8
PE
3898 * eval.c: Port to Windows vsnprintf (Bug#8435).
3899 Include <limits.h>.
3900 (SIZE_MAX): Define if the headers do not.
3901 (verror): Do not give up if vsnprintf returns a negative count.
3902 Instead, grow the buffer. This ports to Windows vsnprintf, which
3903 does not conform to C99. Problem reported by Eli Zaretskii.
3904 Also, simplify the allocation scheme, by avoiding the need for
3905 calling realloc, and removing the ALLOCATED variable.
3906
70476b54
PE
3907 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3908
12020a9e
PE
3909 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3910 But keep the doprint source code for now, as we might revamp it
3911 and use it again (Bug#8435).
ea6c7ae6
PE
3912 * lisp.h (doprnt): Remove.
3913 * Makefile.in (base_obj): Remove doprnt.o.
3914 * deps.mk (doprnt.o): Remove.
3915
5fdb398c
PE
3916 error: Print 32- and 64-bit integers portably (Bug#8435).
3917 Without this change, on typical 64-bit hosts error ("...%d...", N)
3918 was used to print both 32- and 64-bit integers N, which relied on
3919 undefined behavior.
3920 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3921 New macro.
3922 * lisp.h (error, verror): Mark as printf-like functions.
3923 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3924 Report overflow in size calculations when allocating printf buffer.
3925 Do not truncate output string at its first null byte.
3926 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3927 Truncate the output at a character boundary, since vsnprintf does not
3928 do that.
3929 * charset.c (check_iso_charset_parameter): Convert internal
3930 character to string before calling 'error', since %c now has the
3931 printf meaning.
3932 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3933 overflow when computing char to be passed to 'error'. Do not
3934 pass Lisp_Object to 'error'; pass the integer instead.
3935 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3936 formatted with plain %d.
3937
b189fa66
PE
3938 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3939
bff87ef0
PE
3940 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3941
7e2cac20
PE
3942 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3943
ce4d90b5
PE
3944 * xterm.c (x_catch_errors): Remove duplicate declaration.
3945
266c9547
PE
3946 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3947
79c49ad2
PE
3948 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3949
368f4090
JM
39502011-04-10 Jim Meyering <meyering@redhat.com>
3951
3952 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3953 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3954 return ssize_t not "int", and use size_t as the buffer length.
3955 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3956 * gnutls.h: Update declarations.
3957 * process.c (read_process_output): Use ssize_t, to match.
3958 (send_process): Likewise.
3959
a32d4040
CY
39602011-04-09 Chong Yidong <cyd@stupidchicken.com>
3961
3962 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3963
8546720e 39642011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3965
04f2d78b
CB
3966 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3967 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3968
8546720e
GM
3969 * xterm.c (handle_one_xevent):
3970 * xmenu.c (create_and_show_popup_menu):
3971 * xselect.c (x_decline_selection_request)
3972 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3973
0a2f5c1a 39742011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3975
3976 Fix some uses of `int' instead of EMACS_INT.
3977 * search.c (string_match_1, fast_string_match)
3978 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3979 (scan_buffer, find_next_newline_no_quit)
3980 (find_before_next_newline, search_command, Freplace_match)
3981 (Fmatch_data): Make some `int' variables be EMACS_INT.
3982
3983 * xdisp.c (display_count_lines): 3rd argument and return value now
3984 EMACS_INT. All callers changed.
3985 (pint2hrstr): Last argument is now EMACS_INT.
3986
3987 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3988 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3989 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3990 (decode_coding_utf_16, decode_coding_emacs_mule)
3991 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3992 (decode_coding_ccl, decode_coding_charset)
3993 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3994 (decode_coding_iso_2022, decode_coding_emacs_mule)
3995 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3996 <char_offset, last_offset>: Declare EMACS_INT.
3997 (encode_coding_utf_8, encode_coding_utf_16)
3998 (encode_coding_emacs_mule, encode_invocation_designation)
3999 (encode_designation_at_bol, encode_coding_iso_2022)
4000 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4001 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4002 Declare EMACS_INT.
4003 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4004 (encode_invocation_designation): Last argument P_NCHARS is now
4005 EMACS_INT.
4006 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4007 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4008
4009 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4010 All users changed.
4011
4012 * ccl.c (Fccl_execute_on_string): Declare some variables
4013 EMACS_INT.
4014
8546720e 40152011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4016
4017 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4018
4e19a977
CS
40192011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4020
4021 * process.c (Fformat_network_address): Doc fix.
4022
87302331
R
40232011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4024
4025 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4026
cbb59342
CY
40272011-04-08 Chong Yidong <cyd@stupidchicken.com>
4028
4029 * keyboard.c (read_char): Call Lisp function help-form-show,
4030 instead of using internal_with_output_to_temp_buffer.
4031 (Qhelp_form_show): New var.
e0d38eeb 4032 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4033
4034 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4035
4036 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4037
e67a13ab
CY
40382011-04-06 Chong Yidong <cyd@stupidchicken.com>
4039
04f2d78b
CB
4040 * process.c (Flist_processes): Remove to Lisp.
4041 (list_processes_1): Delete.
e67a13ab 4042
973f782d
EZ
40432011-04-06 Eli Zaretskii <eliz@gnu.org>
4044
7c106b1e
EZ
4045 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4046
973f782d
EZ
4047 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4048
41cf7d1a 40492011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4050
ca23cc88
PE
4051 Fix more problems found by GCC 4.6.0's static checks.
4052
f390e2d5
PE
4053 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4054
42eea0d0
PE
4055 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4056
b69769da 4057 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4058
f9541e84
PE
4059 * xdisp.c (vmessage): Mark as a printf-like function.
4060
13841b55
PE
4061 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4062
c136c10f
PE
4063 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4064
5e2d4a30
PE
4065 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4066 printf-like functions.
4067 (tiff_load): Add casts to remove these marks before passing them
4068 to system-supplied API.
4069
583f48b9
PE
4070 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4071
b25d760e
PE
4072 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4073 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4074 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4075 directly, rather than having caller test rule sign. This avoids
4076 some unnecessary tests.
4077 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4078 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4079 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4080
bc7b6697 4081 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4082 (xfont_open): Avoid unnecessary tests.
bc7b6697 4083
27ccc379
PE
4084 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4085
dcd5c89a
PE
4086 * composite.h, composite.c (composition_gstring_put_cache):
4087 Use EMACS_INT, not int, for length.
4088
b13a45c6
PE
4089 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4090 breaking out part of COMPOSITION_DECODE_RULE.
4091 (COMPOSITION_DECODE_RULE): Use it.
4092 * composite.c (get_composition_id): Remove unused local vars,
4093 by using the new macro.
4094
1e792e4d
PE
4095 * textprop.c (set_text_properties_1): Change while to do-while,
4096 since the condition is always true at first.
4097
dc6c6455 4098 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4099 (interval_deletion_adjustment): Return unsigned value.
4100 All uses changed.
dc6c6455 4101
aba7731a
PE
4102 * process.c (list_processes_1, create_pty, read_process_output):
4103 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4104 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4105 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4106 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4107 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4108
fdfc4bf3
PE
4109 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4110
fca8fe46 4111 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4112 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4113
06a0259a 4114 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4115 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4116 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4117
e7b9e80f
PE
4118 * print.c (print_error_message): Avoid int overflow.
4119
56201685
PE
4120 * font.c (font_list_entities): Redo for clarity,
4121 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4122
78834453 4123 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4124 (font_score): Avoid potential overflow in diff calculation.
78834453 4125
0bc0b309 4126 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4127 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4128
e610eaca
PE
4129 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4130
b895abce
PE
4131 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4132 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4133 can always succeed if overflow has undefined behavior.
4134
1f1d9321 4135 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4136 (wordify): Omit three unnecessary tests.
1f1d9321 4137
c59478bc
PE
4138 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4139 All callers changed. This avoids the need for an unused var.
4140
79b73827
PE
4141 * casefiddle.c (casify_region): Remove var that is set but not used.
4142
a4db5dfe
PE
4143 * dired.c (file_name_completion): Remove var that is set but not used.
4144
43aae36e
PE
4145 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4146
2a47c44d 4147 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4148 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4149
a37c69bf
PE
4150 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4151 Check for integer overflow on size calculations.
4152
328ab8e7
PE
4153 * buffer.c (Fprevious_overlay_change): Remove var that is set
4154 but not used.
4155
e5a2a5cb
PE
4156 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4157 Remove vars that are set but not used.
8d84a6eb 4158 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4159 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4160
a60e5f68
PE
4161 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4162
f661cb61 4163 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4164 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4165
f0397f5a
PE
4166 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4167 that are set but not used.
4168
8664db06 4169 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4170 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4171
6abdaa4a
PE
4172 * xselect.c (x_get_local_selection, x_handle_property_notify):
4173 Remove vars that are set but not used.
4174
0ce7538d 4175 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4176 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4177
9ae848fc
PE
4178 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4179 Remove var that is set but not used.
0b918413
PE
4180 (scroll_bar_windows_size): Now size_t, not int.
4181 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4182 Check for overflow.
9ae848fc 4183
a5a62657
PE
4184 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4185 (map_tty_color) [!defined MSDOS]: Likewise.
4186
5c5cdd39
PE
4187 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4188
66ebf983
PE
4189 * coding.c: Remove vars that are set but not used.
4190 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4191 All callers changed.
4192 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4193 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4194 (decode_coding_charset): Remove vars that are set but not used.
4195
1be4d761
PE
4196 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4197 that is set but not used.
4198
47553fa8
PE
4199 * print.c (print_object): Remove var that is set but not used.
4200
1f7196bf 4201 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4202 The gnulib version avoids calling malloc in the usual case,
4203 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4204 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4205 * filelock.c (current_lock_owner): Likewise.
4206 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4207 * sysdep.c: Include allocator.h, careadlinkat.h.
4208 (emacs_no_realloc_allocator): New static constant.
4209 (emacs_readlink): New function.
fdb61804
PE
4210 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4211 ../lib/careadlinkat.h.
d1fdcab7 4212
f84c17c7
SM
42132011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4214
4215 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4216 first non-nil return value).
4217
ef3862ad
JD
42182011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4219
4220 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4221 if not defined (Bug#8403).
4222
376a7006
JB
42232011-04-02 Juanma Barranquero <lekktu@gmail.com>
4224
4225 * xdisp.c (display_count_lines): Remove parameter `start',
4226 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4227 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4228 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4229 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4230 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4231 and thereabouts. All callers changed.
4232 (get_per_char_metric): Remove parameter `f', unused since
4233 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4234
6ca3801d
JM
42352011-04-02 Jim Meyering <meyering@redhat.com>
4236
4237 do not dereference NULL upon failed strdup
4238 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4239 (ns_get_family): Likewise.
4240
d8e2b5ba
JB
42412011-04-02 Juanma Barranquero <lekktu@gmail.com>
4242
4243 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4244
8c74fcbd
JD
42452011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4246
4247 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4248 later (Bug#8403).
4249
7200d79c
SM
42502011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4251
03408648 4252 Add lexical binding.
7200d79c 4253
03408648
SM
4254 * window.c (Ftemp_output_buffer_show): New fun.
4255 (Fsave_window_excursion):
4256 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4257
4258 * lread.c (lisp_file_lexically_bound_p): New function.
4259 (Fload): Bind Qlexical_binding.
4260 (readevalloop): Remove `evalfun' arg.
4261 Bind Qinternal_interpreter_environment.
4262 (Feval_buffer): Bind Qlexical_binding.
4263 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4264 Mark as dynamic.
4265 (syms_of_lread): Declare `lexical-binding'.
4266
4267 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4268
4269 * keyboard.c (eval_dyn): New fun.
4270 (menu_item_eval_property): Use it.
ca105506
SM
4271
4272 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4273
03408648
SM
4274 * fns.c (concat, mapcar1): Accept byte-code-functions.
4275
4276 * eval.c (Fsetq): Handle lexical vars.
4277 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4278 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4279 (FletX, Flet): Obey lexical binding.
4280 (Fcommandp): Handle closures.
4281 (Feval): New `lexical' arg.
4282 (eval_sub): New function extracted from Feval. Use it almost
4283 everywhere where Feval was used. Look up vars in lexical env.
4284 Handle closures.
4285 (Ffunctionp): Move from subr.el.
4286 (Ffuncall): Handle closures.
4287 (apply_lambda): Remove `eval_flags'.
4288 (funcall_lambda): Handle closures and new byte-code-functions.
4289 (Fspecial_variable_p): New function.
4290 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4291 but without exporting it to Lisp.
23aba0ea 4292
23aba0ea 4293 * doc.c (Fdocumentation, store_function_docstring):
03408648 4294 * data.c (Finteractive_form): Handle closures.
23aba0ea 4295
03408648
SM
4296 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4297 interactive spec.
ba83908c 4298
04f2d78b
CB
4299 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4300 New byte-codes.
03408648
SM
4301 (exec_byte_code): New function extracted from Fbyte_code to handle new
4302 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4303
03408648 4304 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4305
03408648 4306 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4307
e2abce01
JB
43082011-03-31 Juanma Barranquero <lekktu@gmail.com>
4309
4310 * xdisp.c (redisplay_internal): Fix prototype.
4311
63696a73 43122011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4313
63696a73 4314 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4315 (try_scrolling): Use it when setting scroll_limit.
4316 Limit scrolling to 100 screen lines.
63696a73
EZ
4317 (redisplay_window): Even when falling back on "recentering",
4318 position point in the window according to scroll-conservatively,
4319 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4320
4321 (try_scrolling): When point is above the window, allow searching
4322 as far as scroll_max, or one screenful, to compute vertical
4323 distance from PT to the scroll margin position. This prevents
4324 try_scrolling from unnecessarily failing when
4325 scroll-conservatively is set to a value slightly larger than the
4326 window height. Clean up the case of PT below the margin at bottom
4327 of window: scroll_max can no longer be INT_MAX. When aggressive
4328 scrolling is in use, don't let point enter the opposite scroll
4329 margin as result of the scroll.
4330 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4331 threshold of 100 lines for never-recentering scrolling.
4332
e4cc2dfc
JB
43332011-03-31 Juanma Barranquero <lekktu@gmail.com>
4334
4335 * dispextern.h (move_it_by_lines):
4336 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4337 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4338 (message_log_check_duplicate): Remove parameters `prev_bol' and
4339 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4340 (redisplay_internal): Remove parameter `preserve_echo_area',
4341 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4342
4343 * indent.c (Fvertical_motion):
4344 * window.c (window_scroll_pixel_based, Frecenter):
4345 Don't pass `need_y_p' to `move_it_by_lines'.
4346
1c470562
SM
43472011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4348
44f230aa
SM
4349 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4350 steal a few bits to be more compact.
4351 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4352 Remove unneeded casts.
4353
1c470562
SM
4354 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4355
888adce9
ZK
43562011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4357
4358 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4359 binding" message (bug#7967).
4360
f838ed7b
PE
43612011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4362
77861b95
PE
4363 Fix more problems found by GCC 4.6.0's static checks.
4364
de6dbc14
PE
4365 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4366 Remove unused local var.
4367
f838ed7b
PE
4368 * editfns.c (Fmessage_box): Remove unused local var.
4369
792c7b2b
PE
4370 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4371 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4372 Omit unused local vars.
c499e557 4373 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4374 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4375 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4376 Omit unused local var.
4377
ba0165e1
PE
4378 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4379 Don't assume string length fits in int.
32ad8845 4380 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4381 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4382
3c59b4c9
PE
4383 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4384 instead of alloca (Bug#8344).
4385
a3eed478 4386 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4387 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4388
eb4d412d
PE
4389 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4390
1658b401
PE
4391 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4392 concerns.
4393
4394 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4395
4396 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4397
9a2c6e05
PE
4398 * keyboard.c (syms_of_keyboard): Use the same style as later
4399 in this function when indexing through an array. This also
4400 works around GCC bug 48267.
4401
03d0a109
PE
4402 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4403
44f730c8
PE
4404 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4405
fe75f926
PE
4406 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4407 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4408
ffa8c828
PE
4409 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4410 This avoids undefined behavior on integer overflow, and is a bit
4411 more convenient anyway since it is compared to a size_t variable.
4412
c5101a77
PE
4413 Variadic C functions now count arguments with size_t, not int.
4414 This avoids an unnecessary limitation on 64-bit machines, which
4415 caused (substring ...) to crash on large vectors (Bug#8344).
4416 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4417 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4418 All variadic functions and their callers changed accordingly.
c5101a77
PE
4419 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4420 * data.c (arith_driver, float_arith_driver): Likewise.
4421 * editfns.c (general_insert_function): Likewise.
4422 * eval.c (struct backtrace.nargs, interactive_p)
4423 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4424 (funcall_lambda, mark_backtrace): Likewise.
4425 * fns.c (concat): Likewise.
4426 * frame.c (x_set_frame_parameters): Likewise.
4427 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4428 0 if not found, not -1. All callers changed.
4429
dd3f25f7
PE
4430 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4431 (stack_copy_size): Now size_t, not int.
4432 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4433
461c2ab9
JB
44342011-03-28 Juanma Barranquero <lekktu@gmail.com>
4435
4436 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4437 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4438 All callers changed.
4439
4440 * lisp.h (multibyte_char_to_unibyte):
4441 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4442 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4443 * character.h (CHAR_TO_BYTE8):
4444 * cmds.c (internal_self_insert):
4445 * editfns.c (general_insert_function):
4446 * keymap.c (push_key_description):
4447 * search.c (Freplace_match):
4448 * xdisp.c (message_dolog, set_message_1): All callers changed.
4449
f6d62986
SM
44502011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4451
4452 * keyboard.c (safe_run_hook_funcall): New function.
4453 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4454 don't set the hook to nil, but remove the offending function instead.
4455 (Qcommand_hook_internal): Remove, unused.
4456 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4457 Vcommand_hook_internal.
4458
4459 * eval.c (enum run_hooks_condition): Remove.
4460 (funcall_nil, funcall_not): New functions.
4461 (run_hook_with_args): Call each function through a `funcall' argument.
4462 Remove `cond' argument, now redundant.
4463 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4464 (Frun_hook_with_args_until_failure): Adjust accordingly.
4465 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4466
1db5b1ad
JB
44672011-03-28 Juanma Barranquero <lekktu@gmail.com>
4468
4469 * dispextern.h (string_buffer_position): Remove declaration.
4470
4471 * print.c (strout): Remove parameter `multibyte', unused since
4472 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4473
4474 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4475 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4476 All callers changed.
4477
4478 * w32.c (_wsa_errlist): Use braces for struct initializers.
4479
4480 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4481 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4482 All callers changed.
4483 (string_buffer_position): Likewise. Also, make static (it's never
4484 used outside xdisp.c).
4485 (cursor_row_p): Remove parameter `w', unused since
4486 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4487 (decode_mode_spec): Remove parameter `precision', introduced during
4488 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4489 All callers changed.
4490
5ffb62aa
JD
44912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4492
4493 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4494
461c2ab9 44952011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4496
4497 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4498 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4499 (ns_update_auto_hide_menu_bar): New functions.
4500 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4501 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4502 ns_constrain_all_frames.
4503 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4504 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4505
5c380ffb
JD
45062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4507
4508 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4509
9af30bdf
GM
45102011-03-27 Glenn Morris <rgm@gnu.org>
4511
4512 * syssignal.h: Replace RETSIGTYPE with void.
4513 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4514 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4515 Replace SIGTYPE with void everywhere.
4516 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4517 * s/template.h (SIGTYPE): Remove commented out definition.
4518
e2abce01
JB
45192011-03-26 Eli Zaretskii <eliz@gnu.org>
4520
4521 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4522 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4523
f868cd8a
JB
45242011-03-26 Juanma Barranquero <lekktu@gmail.com>
4525
59eb0929
JB
4526 * w32.c (read_unc_volume): Use parameter `henum', instead of
4527 global variable `wget_enum_handle'.
4528
4529 * keymap.c (describe_vector): Remove parameters `indices' and
4530 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4531 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4532
f868cd8a
JB
4533 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4534
4535 * keyboard.c (timer_check): Remove parameter `do_it_now',
4536 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4537 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4538 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4539
4540 * keyboard.c (read_char):
4541 * w32menu.c (w32_menu_display_help):
4542 * xmenu.c (show_help_event, menu_help_callback):
4543 Adjust calls to `show_help_echo'.
4544
4545 * gtkutil.c (xg_maybe_add_timer):
4546 * keyboard.c (readable_events):
4547 * process.c (wait_reading_process_output):
4548 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4549
4550 * insdel.c (adjust_markers_gap_motion):
4551 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4552 (gap_left, gap_right): Don't call it.
4553
2ecf6fdb
CY
45542011-03-25 Chong Yidong <cyd@stupidchicken.com>
4555
4556 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4557 incurred during fontification.
4558
6b1f9ba4
JB
45592011-03-25 Juanma Barranquero <lekktu@gmail.com>
4560
4561 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4562 (DEFVAR_PER_BUFFER): Don't pass it.
4563
4564 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4565 (scrolling_window): Don't pass it.
4566
0f4a96b5
JB
45672011-03-25 Juanma Barranquero <lekktu@gmail.com>
4568
4569 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4570
4571 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4572 and `suffix'.
4573 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4574 of variables specific to SELinux and computation of `encoded_absname'.
4575
4576 * image.c (XPutPixel): Remove unused variable `height'.
4577
4578 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4579
4580 * unexw32.c (get_section_info): Remove unused variable `section'.
4581
4582 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4583 (system_process_attributes): Remove unused variable `sess'.
4584 (sys_read): Remove unused variable `err'.
4585
4586 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4587 (w32_wnd_proc): Remove unused variable `isdead'.
4588 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4589 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4590 (x_create_tip_frame): Remove unused variable `tem'.
4591
4592 * w32inevt.c (w32_console_read_socket):
4593 Remove unused variable `no_events'.
4594
4595 * w32term.c (x_draw_composite_glyph_string_foreground):
4596 Remove unused variable `width'.
4597
1149507c
JB
45982011-03-24 Juanma Barranquero <lekktu@gmail.com>
4599
4600 * w32term.c (x_set_glyph_string_clipping):
4601 Don't pass uninitialized region to CombineRgn.
4602
9c88f339
JB
46032011-03-23 Juanma Barranquero <lekktu@gmail.com>
4604
4605 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4606 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4607 (Fx_close_connection): Remove unused variable `i'.
4608
4609 * w32font.c (w32font_draw): Return number of glyphs.
4610 (w32font_open_internal): Remove unused variable `i'.
4611 (w32font_driver): Add missing initializer.
4612
4613 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4614 (fill_in_menu): Remove unused variable `items_added'.
4615
4616 * w32term.c (last_mouse_press_frame): Remove static global variable.
4617 (w32_clip_to_row): Remove unused variable `f'.
4618 (x_delete_terminal): Remove unused variable `i'.
4619
4620 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4621 (NOTHING): Remove unused static global variable.
4622 (uniscribe_check_otf): Remove unused variable `table'.
4623 (uniscribe_font_driver): Add missing initializers.
4624
dee091a3
JD
46252011-03-23 Julien Danjou <julien@danjou.info>
4626
4627 * term.c (Fsuspend_tty, Fresume_tty):
4628 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4629 * window.c (temp_output_buffer_show):
4630 * insdel.c (signal_before_change):
4631 * frame.c (Fhandle_switch_frame):
4632 * fileio.c (Fdo_auto_save):
4633 * emacs.c (Fkill_emacs):
4634 * editfns.c (save_excursion_restore):
4635 * cmds.c (internal_self_insert):
4636 * callint.c (Fcall_interactively):
4637 * buffer.c (Fkill_all_local_variables):
4638 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4639 Use Frun_hooks.
0f4a96b5 4640 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4641 unconditionnaly since it does the check itself.
4642
2c520ab5 46432011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4644
c9c49752
PE
4645 Fix more problems found by GCC 4.5.2's static checks.
4646
8abc3f12
PE
4647 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4648 the first time through the loop, since we know p0 < p1 then.
4649 This also avoids a gcc -Wstrict-overflow warning.
4650
a2d26660
PE
4651 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4652 leading to a memory leak, possible in functions like
4653 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4654 of objects (Bug#8318).
a2d26660 4655
916c72e9
PE
4656 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4657 that could (at least in theory) be that large.
4658
19ab8a18
PE
4659 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4660 This is less likely to overflow, and avoids undefined behavior if
4661 overflow does occur. All callers changed. Use strtoul to scan
4662 for the unsigned long integer.
b7cbbd6f
PE
4663 (pint2hrstr): Simplify and tune code slightly.
4664 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4665
f0641eff
PE
4666 * scroll.c (do_scrolling): Work around GCC bug 48228.
4667 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4668
7f650bb9
PE
4669 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4670 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4671 (validate_x_resource_name): Simplify count usage.
4672 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4673
37dd57d1
PE
4674 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4675 fail (Bug#8306).
81e56e61 4676
699979fc 4677 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4678
401bf9b4
PE
4679 * process.c (Fmake_network_process): Use socklen_t, not int,
4680 where POSIX says socklen_t is required in portable programs.
4681 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4682 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4683 (Fmake_network_process, server_accept_connection):
4684 (wait_reading_process_output, read_process_output):
4685 Likewise.
4686
b93aacde
PE
4687 * process.c: Rename or move locals to avoid shadowing.
4688 (list_processes_1, Fmake_network_process):
4689 (read_process_output_error_handler, exec_sentinel_error_handler):
4690 Rename or move locals.
4dc343ee 4691 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4692 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4693 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4694 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4695 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4696
af8a867c 4697 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4698 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4699 Include tparam.h instead, since it declares them.
af8a867c
PE
4700 * cm.h (PC): Remove extern decl; tparam.h now does this.
4701 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4702 * terminfo.c: Include tparam.h, to check interfaces.
4703 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4704 (tparam): Adjust signature to match interface in tparam.h;
4705 this removes some undefined behavior. Check that outstring and len
4706 are zero, which they always are with Emacs.
4707 * tparam.h (PC, BC, UP): New extern decls.
4708
0248044d 4709 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4710 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4711
8ff096c1 4712 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4713 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4714 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4715 (ftfont_list): Remove unused local.
49eaafba
PE
4716 (get_adstyle_property, ftfont_pattern_entity):
4717 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4718 Rename locals to avoid shadowing.
8ff096c1 4719
e2be39f6
PE
4720 * xfont.c (xfont_list_family): Mark var as initialized.
4721
c9735e30
PE
4722 * xml.c (make_dom): Now static.
4723
8f5201ae
PE
4724 * composite.c (composition_compute_stop_pos): Rename local to
4725 avoid shadowing.
b246f932
PE
4726 (composition_reseat_it): Remove unused locals.
4727 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4728 (composition_update_it): Mark var as initialized.
11b61122
PE
4729 (find_automatic_composition): Mark vars as initialized,
4730 with a FIXME (Bug#8290).
8f5201ae 4731
760fbc2c
PE
4732 character.h: Rename locals to avoid shadowing.
4733 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4734 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4735 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4736 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4737 to avoid shadowing.
4738
ff08eb85
PE
4739 * textprop.c (property_change_between_p): Remove; unused.
4740
fc7bf025
PE
4741 * intervals.c (interval_start_pos): Now static.
4742
235d7abc
PE
4743 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4744
44f230aa
SM
4745 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4746 Rename locals to avoid shadowing.
3e7d6594 4747
50060332
PE
4748 * sound.c (wav_play, au_play, Fplay_sound_internal):
4749 Fix pointer signedness.
d01f234b 4750 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4751 (wav_play): Initialize a variable to 0, to prevent undefined
4752 behavior (Bug#8278).
50060332 4753
c4fc4e30
PE
4754 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4755
918436ed
PE
4756 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4757
c939f91b
PE
4758 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4759 clobbering (Bug#8298).
b9c7f648
PE
4760 * sysdep.c (sys_subshell): Likewise.
4761 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4762
6bd8c144
PE
4763 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4764 This should get cleaned up, so that child_setup has the
4765 same signature on all platforms.
4766
7710357c 4767 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4768 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4769
c59da222
CY
47702011-03-22 Chong Yidong <cyd@stupidchicken.com>
4771
4772 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4773 not to be necessary, and produces flickering.
4774
66b87493
GM
47752011-03-20 Glenn Morris <rgm@gnu.org>
4776
4777 * config.in: Remove file.
4778
45b6f6d5
JB
47792011-03-20 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4782 are now in src/globals.h.
4783 (syms_of_minibuf): Remove spurious & from previous change.
4784
3ec03f7e
LL
47852011-03-20 Leo <sdl.web@gmail.com>
4786
4787 * minibuf.c (completing-read-function): New variable.
4788 (completing-read-default): Rename from completing-read.
4789 (completing-read): Call completing-read-function.
4790
b14e3e21
CY
47912011-03-19 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * xfaces.c (Fx_load_color_file):
4794 Read color file from absolute filename (bug#8250).
4795
f2b726e6
JB
47962011-03-19 Juanma Barranquero <lekktu@gmail.com>
4797
4798 * makefile.w32-in: Update dependencies.
4799
09f6ff02
EZ
48002011-03-17 Eli Zaretskii <eliz@gnu.org>
4801
4802 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4803
29a6015a
PE
48042011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4805
a3a6c54e
PE
4806 Fix more problems found by GCC 4.5.2's static checks.
4807
b766f867
PE
4808 * process.c (make_serial_process_unwind, send_process_trap):
4809 (sigchld_handler): Now static.
4810
be02381c
PE
4811 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4812 That way, the code declares only the vars that it needs.
4813 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4814 * s/cygwin.h (PTY_ITERATION): Likewise.
4815 * s/darwin.h (PTY_ITERATION): Likewise.
4816 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4817
57048744
PE
4818 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4819 * process.c (allocate_pty): Don't declare stb unless it's needed.
4820
7914961c 4821 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4822 (CONSTANTLIM): Remove; unused.
4823 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4824 Define only if needed.
7914961c 4825
b3967b18
PE
4826 * unexelf.c (unexec): Name an expression,
4827 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4828 Use a different way to cause a compilation error if anyone uses
4829 n rather than nn, a way that does not involve shadowing.
73366a00 4830 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4831
29a6015a
PE
4832 * deps.mk (unexalpha.o): Remove; unused.
4833
43cfc33e 4834 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4835 * unexec.h: New file.
ce701a33
PE
4836 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4837 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4838 Depend on unexec.h.
4839 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4840 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4841 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4842 Change as necessary to match prototype in unexec.h.
ce701a33 4843
01f44d5a
PE
4844 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4845 shadowing.
4f63c6bb 4846 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4847
a6670b0b
PE
4848 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4849 Rename locals to avoid shadowing.
4850
cef2010d 4851 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4852 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4853
d4d7173a
PE
4854 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4855
f08b802a
PE
4856 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4857 warning when compiling print.c.
4858
3ddb0639
PE
4859 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4860 instead of using an uninitialized var.
5ad03b97 4861 (font_sort_entities): Mark var as initialized.
3ddb0639 4862
170a2692
PE
4863 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4864
e663c700
PE
4865 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4866 pointers to constants.
89bc529a 4867 (font_parse_fcname): Remove unused vars.
7b81e2d0 4868 (font_delete_unmatched): Now static.
ea838e10 4869 (font_get_spec): Remove; unused.
13a547c6
PE
4870 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4871 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4872 Rename or move locals to avoid shadowing.
e663c700 4873
2a80c887 4874 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4875 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4876
1384fa33 4877 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4878 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4879
8b2c52e9
PE
4880 * alloc.c (mark_backtrace): Move decl from here ...
4881 * lisp.h: ... to here, so that it can be checked.
4882
475545b5 4883 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4884 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4885 (lisp_indirect_variable): Name an expression,
4886 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4887 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4888
b1349114 4889 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4890 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4891 Use const pointer when appropriate.
b1349114 4892
a2928364
PE
4893 * lisp.h (get_system_name, get_operating_system_release):
4894 Move decls here, to check interfaces.
4895 * process.c (get_operating_system_release): Move decl to lisp.h.
4896 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4897 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4898 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4899 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4900 (Fformat_time_string, Fencode_time, Finsert_char):
4901 (Ftranslate_region_internal, Fformat):
4902 Rename or remove local vars to avoid shadowing.
9710023e 4903 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4904
a415e694
PE
4905 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4906 avoid shadowing.
4907
8ef4622d
PE
4908 * lisp.h (eassert): Check that the argument compiles, even if
4909 ENABLE_CHECKING is not defined.
4910
946f9a5b
PE
4911 * data.c (Findirect_variable): Name an expression, to avoid
4912 gcc -Wbad-function-cast warning.
112396d6 4913 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4914 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4915 (Fmake_variable_buffer_local, Fmake_local_variable):
4916 Mark variables as initialized.
52746918 4917 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4918
e5aab7e7 4919 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4920 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4921 Rename locals to avoid shadowing.
dff45157
PE
4922 (mark_stack): Move local variables into the #ifdef region where
4923 they're used.
7bc26fdb
PE
4924 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4925 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4926 needed otherwise.
4927 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4928 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4929 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4930
e5aab7e7
PE
4931 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4932 avoids undefined behavior in theory.
4933
4da60324
PE
4934 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4935
88043301
PE
4936 Use functions, not macros, for up- and down-casing (Bug#8254).
4937 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4938 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4939 to use the following functions instead of these macros.
4940 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4941 EMACS_INT, since callers assume the returned value fits in int.
4942 (upcase1): Likewise, for UPCASE_TABLE.
4943 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4944 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4945 the race-condition problem in the old DOWNCASE.
88043301 4946
19ed5445
PE
4947 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4948 Rename locals to avoid shadowing.
4949 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4950 (regex_compile, re_search_2, re_match_2_internal):
4951 Remove unused local vars.
952db0d7
PE
4952 (FREE_VAR): Rewrite so as not to use empty "else",
4953 which gcc can warn about.
da053e48 4954 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4955 (RETALLOC_IF): Define only if needed.
4956 (WORDCHAR_P): Likewise. This one is never needed, but is used
4957 only in a comment talking about a compiler bug, so put inside
4958 the #if 0 of that comment.
4959 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4960 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4961 Remove; unused.
19ed5445 4962
1f3561e4 4963 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4964 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4965 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4966
ded6f8f7
PE
4967 * search.c (simple_search): Remove unused var.
4968
dbd37a95
PE
4969 * dired.c (compile_pattern): Move decl from here ...
4970 * lisp.h: ... to here, so that it can be checked.
4971 (struct re_registers): New forward decl.
4972
7e47afad
PE
4973 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4974
85f24f61
PE
4975 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4976 All uses changed.
4977 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4978 Rename locals to avoid shadowing.
5671df8f 4979 (Fvertical_motion): Mark locals as initialized.
85f24f61 4980
181aa2be 4981 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4982 (casify_region): Mark local as initialized.
181aa2be 4983
930d429c
PE
4984 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4985
7082eac6
PE
4986 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4987 New macros, so that the caller can use some names other than
4988 gcpro1, gcpro2, etc.
4989 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4990 of the new macros.
4991 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4992 argument, for consistency with GCPRO2_VAR, etc: it is now the
4993 prefix of the variable, not the variable itself. All uses
4994 changed.
38b2c076
PE
4995 * dired.c (directory_files_internal, file_name_completion):
4996 Rename locals to avoid shadowing.
4997
15206ed9
PE
4998 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4999 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5000 dired.c's scmp function, had undefined behavior.
5001 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5002 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5003 * buffer.h: ... to here, because these macros use current_buffer,
5004 and the new implementation with inline functions needs to have
5005 current_buffer in scope now, rather than later when the macros
5006 are used.
5007 (downcase, upcase1): New static inline functions.
5008 (DOWNCASE, UPCASE1): Reimplement using these functions.
5009 This avoids undefined behavior in expressions like
5010 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5011 from race conditions in accessing the global variables
5012 case_temp1 and case_temp2.
5013 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5014 * lisp.h (case_temp1, case_temp2): Remove their decls.
5015 * character.h (ASCII_CHAR_P): Move from here ...
5016 * lisp.h: ... to here, so that the inline functions mentioned
5017 above can use them.
5018
4a6bea26
PE
5019 * dired.c (directory_files_internal_unwind): Now static.
5020
f14b7e14
PE
5021 * fileio.c (file_name_as_directory, directory_file_name):
5022 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5023 Now static.
2893f146
PE
5024 (file_name_as_directory): Use const pointers when appropriate.
5025 (Fexpand_file_name): Likewise. In particular, newdir might
5026 point at constant storage, so make it a const pointer.
fd4ead52 5027 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5028 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5029 signedness issues.
f839df0c
PE
5030 (Fset_file_times, Finsert_file_contents, auto_save_error):
5031 Rename locals to avoid shadowing.
f14b7e14 5032
5716756e 5033 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5034 (Ftry_completion, Fall_completions): Rename or remove locals
5035 to avoid shadowing.
5716756e 5036
b4c3046a
PE
5037 * marker.c (bytepos_to_charpos): Remove; unused.
5038
b45db522
PE
5039 * lisp.h (verify_bytepos, count_markers): New decls,
5040 so that gcc does not warn that these functions aren't declared.
5041
85876d07
PE
5042 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5043 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5044 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5045 (copy_text): Remove unused local var.
85876d07 5046
03d78a21 5047 * filelock.c (within_one_second): Now static.
b3dd38ab 5048 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5049
5df8f01b
PE
5050 * buffer.c (fix_overlays_before): Mark locals as initialized.
5051 (fix_start_end_in_overlays): Likewise. This function should be
5052 simplified by using pointers-to-pointers, but that's a different
5053 matter.
b1d876f1 5054 (switch_to_buffer_1): Now static.
8f54f30a
PE
5055 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5056 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5057
a70072c9 5058 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5059 Fix pointer signedness issue.
edced198
PE
5060 (sys_subshell): Mark local as volatile if checking for lint,
5061 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5062 (MAXPATHLEN): Define only if needed.
a70072c9 5063
a0977c44
PE
5064 * process.c (serial_open, serial_configure): Move decls from here ...
5065 * systty.h: ... to here, so that they can be checked.
5066
a884fdcc
PE
5067 * fns.c (get_random, seed_random): Move extern decls from here ...
5068 * lisp.h: ... to here, so that they can be checked.
5069
604efe86 5070 * sysdep.c (reset_io): Now static.
b8950c94 5071 (wait_for_termination_signal): Remove; unused.
604efe86 5072
38fc62d9
PE
5073 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5074 (copy_keymap_item, append_key, push_text_char_description):
5075 Now static.
1004a21a 5076 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5077 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5078 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5079 (describe_map_tree):
5080 Rename locals to avoid shadowing.
38fc62d9 5081
2f2650da
PE
5082 * keyboard.c: Declare functions static if they are not used elsewhere.
5083 (echo_char, echo_dash, cmd_error, top_level_2):
5084 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5085 (read_char, kbd_buffer_get_event, make_lispy_position):
5086 (make_lispy_event, make_lispy_movement, apply_modifiers):
5087 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5088 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5089 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5090 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5091 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5092
a053e86c 5093 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5094 (mark_kboards): Move decl here ...
5095 * alloc.c (mark_kboards): ... from here.
a053e86c 5096
4752793e
PE
5097 * lisp.h (force_auto_save_soon): New decl.
5098
74f10ca7 5099 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5100 (DEFINE_DUMMY_FUNCTION): New macro.
5101 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5102 Use it.
c03cd23f
PE
5103 (main): Add casts to avoid warnings
5104 if GCC considers string literals to be constants.
74f10ca7 5105
022e70d4
PE
5106 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5107
59d6fe83
PE
5108 * dbusbind.c: Pointer signedness fixes.
5109 (xd_signature, xd_append_arg, xd_initialize):
5110 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5111 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5112 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5113 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5114
78320123
PE
5115 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5116 if GCC considers string literals to be constants.
49cebcca 5117 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5118
35ac2a97
SM
51192011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5120
fb103ca9
SM
5121 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5122 (print_preprocess, print_object): New macro to fix last change.
5123
35ac2a97
SM
5124 * print.c (print_preprocess): Don't forget font objects.
5125
62973b41
JB
51262011-03-16 Juanma Barranquero <lekktu@gmail.com>
5127
5128 * emacs.c (USAGE3): Doc fixes.
5129
0e48bb22
AS
51302011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5131
5132 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5133 structure.
5134
7684e57b
JB
51352011-03-14 Juanma Barranquero <lekktu@gmail.com>
5136
5137 * lisp.h (VWindow_system, Qfile_name_history):
5138 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5139 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5140 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5141
5142 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5143 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5144
5145 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5146 * w32console.c (detect_input_pending, read_input_pending)
5147 (encode_terminal_code):
5148 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5149 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5150 (w32_system_caret_y, Qfile_name_history):
5151 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5152 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5153 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5154 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5155 * w32proc.c (Qlocal, report_file_error):
5156 * w32term.c (Vwindow_system, updating_frame):
5157 * w32uniscribe.c (initialized, uniscribe_font_driver):
5158 Remove unneeded extern declarations.
5159
2aa46d6c
CY
51602011-03-14 Chong Yidong <cyd@stupidchicken.com>
5161
c96bbc66 5162 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5163
cffc6f3b
CY
51642011-03-13 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5167 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5168 These macros can no longer be used for assignment.
5169
44f230aa
SM
5170 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5171 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5172 (record_buffer_markers, fetch_buffer_markers): New functions for
5173 recording and fetching special buffer markers.
5174 (set_buffer_internal_1, set_buffer_temp): Use them.
5175
5176 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5177
5178 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5179
5180 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5181 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5182
5183 * xdisp.c (hscroll_window_tree):
5184 (reconsider_clip_changes): Use PT instead of BUF_PT.
5185
d251f04b
EZ
51862011-03-13 Eli Zaretskii <eliz@gnu.org>
5187
5188 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5189 $(EMACS_ROOT)/lib/intprops.h.
5190
f0c77cd1
PE
51912011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5192
3eca4629
PE
5193 Fix more problems found by GCC 4.5.2's static checks.
5194
7c86ee98
PE
5195 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5196 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5197 (xg_free_frame_widgets): Make it clear that a local variable is
5198 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5199 (gdk_window_get_screen): Make it clear that this macro is needed
5200 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5201 (int_gtk_range_get_value): New function, which avoids a diagnostic
5202 from gcc -Wbad-function-cast.
5203 (xg_set_toolkit_scroll_bar_thumb): Use it.
5204 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5205 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5206 (get_utf8_string, xg_get_file_with_chooser):
5207 Rename locals to avoid shadowing.
5208 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5209
41729b81
PE
5210 * xgselect.c (xg_select): Remove unused var.
5211
f0c77cd1
PE
5212 * image.c (four_corners_best): Mark locals as initialized.
5213 (gif_load): Initialize transparent_p to zero (Bug#8238).
5214 Mark another local as initialized.
ec6cf4c6 5215 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5216
ce0ad53d 5217 * image.c (clear_image_cache): Now static.
d5d5a617 5218 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5219 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5220 (x_edge_detection): Remove unnecessary cast that
5221 gcc -Wbad-function-cast diagnoses.
2037898d 5222 (gif_load): Fix pointer signedness.
6ae141d6
PE
5223 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5224 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5225
33383987 52262011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5227
d32df629
PE
5228 Improve quality of tests for time stamp overflow.
5229 For example, without this patch (encode-time 0 0 0 1 1
5230 1152921504606846976) returns the obviously-bogus value (-948597
5231 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5232 reports time overflow. See
5233 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5234 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5235 * editfns.c: Include limits.h and intprops.h.
5236 (TIME_T_MIN, TIME_T_MAX): New macros.
5237 (time_overflow): Move earlier, to before first use.
5238 (hi_time, lo_time): New functions, for an accurate test for
5239 out-of-range times.
5240 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5241 (Fget_internal_run_time): Don't assume time_t fits in int.
5242 (make_time): Use list2 instead of Fcons twice.
5243 (Fdecode_time): More accurate test for out-of-range times.
5244 (check_tm_member): New function.
5245 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5246 (lisp_time_argument): Don't rely on undefined left-shift and
5247 right-shift behavior when checking for time stamp overflow.
8be6f318 5248
fe31d94c
PE
5249 * editfns.c (time_overflow): New function, refactoring common code.
5250 (Fformat_time_string, Fdecode_time, Fencode_time):
5251 (Fcurrent_time_string): Use it.
5252
8be6f318
PE
5253 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5254 * dired.c (make_time): Move to ...
5255 * editfns.c (make_time): ... here.
5256 * systime.h: Note the move.
5257
09d9db2c 52582011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5259
126bc0dc
YM
5260 * fringe.c (update_window_fringes): Remove unused variables.
5261
c47cbdfd
YM
5262 * unexmacosx.c (copy_data_segment): Also copy __got section.
5263 (Bug#8223)
5264
7ac80be9
EZ
52652011-03-12 Eli Zaretskii <eliz@gnu.org>
5266
c96bbc66 5267 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5268 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5269 Constify `char *' arguments and their references according to
5270 prototypes in tparam.h.
5271
ecb0f94d 5272 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5273
7ac80be9
EZ
5274 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5275 Adapt all references accordingly.
5276
5277 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5278
ef1fd07e
TT
52792011-03-11 Tom Tromey <tromey@redhat.com>
5280
5281 * buffer.c (syms_of_buffer): Remove obsolete comment.
5282
7ef4b50c
EZ
52832011-03-11 Eli Zaretskii <eliz@gnu.org>
5284
5285 * termhooks.h (encode_terminal_code): Declare prototype.
5286
5287 * msdos.c (encode_terminal_code): Don't declare prototype.
5288
5289 * term.c (encode_terminal_code): Now external again, used by
5290 w32console.c and msdos.c.
5291
44f230aa
SM
5292 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5293 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5294
4b1ec863 52952011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5296
1714f52b 5297 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5298
4b1ec863
PE
5299 * fringe.c (update_window_fringes): Mark locals as initialized
5300 (Bug#8227).
5301 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5302
524c7aa6
PE
5303 * alloc.c (mark_fringe_data): Move decl from here ...
5304 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5305 to check its interface.
5306 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5307
a5c0af81 5308 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5309 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5310 (fontset_font): Mark local as initialized.
a9a06e0b 5311 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5312
b4716021
PE
5313 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5314
811e9bac 5315 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5316 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5317 (x_own_selection, Fx_disown_selection_internal): Rename locals
5318 to avoid shadowing.
5319 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5320
7e3ab302
PE
5321 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5322 so that the caller can use some name other than gcpro1.
5323 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5324 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5325 (Fx_backspace_delete_keys_p):
5326 Use them to avoid shadowing, and rename vars to avoid shadowing.
5327 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5328 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5329 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5330 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5331 Remove unused locals.
7e3ab302
PE
5332 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5333 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5334 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5335 macros.
f78faa98 5336
e2b13473
PE
5337 * xterm.h (x_mouse_leave): New decl.
5338
77f23912
PE
5339 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5340 Remove unused functions.
cdf4ba58
PE
5341 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5342 (x_calc_absolute_position): Now static.
7411c686 5343 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5344 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5345 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5346 unless they are used.
38d0b34a
PE
5347 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5348 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5349 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5350 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5351 (x_error_catcher, x_connection_closed, x_error_handler):
5352 (x_error_quitter, xembed_send_message, x_iconify_frame):
5353 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5354 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5355 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5356
44f230aa
SM
5357 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5358 Rename or move locals to avoid shadowing.
6b463e58 5359 (tty_defined_color, merge_face_heights): Now static.
5967d051 5360 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5361 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5362 does not deduce is never used uninitialized.
73719eba
PE
5363 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5364 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5365
426994c3 5366 * terminal.c (store_terminal_param): Now static.
5489860b 5367
032f1620 5368 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5369 (set_frame_menubar): Remove unused local.
d4323972 5370 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5371 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5372 since they might point to immutable storage.
281585b0
PE
5373 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5374 since it's unused otherwise.
032f1620 5375
367c19e5 5376 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5377 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5378 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5379 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5380 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5381 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5382 does not deduce are never used uninitialized.
70739cbe 5383
07b48fa9
PE
5384 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5385
8868a238 5386 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5387 * window.c (window_loop, size_window):
5388 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5389
7e5cf297 5390 * window.c (display_buffer): Now static.
d6550a9f
PE
5391 (size_window): Mark variables that gcc -Wuninitialized
5392 does not deduce are never used uninitialized.
a586633d
PE
5393 * window.h (check_all_windows): New decl, to forestall
5394 gcc -Wmissing-prototypes diagnostic.
5b555da1 5395 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5396
f6095868
PE
5397 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5398 shadowing.
5399 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5400 Include <limits.h>.
5401 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5402 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5403 (load_charset_map): Mark variables that gcc -Wuninitialized
5404 does not deduce are never used uninitialized.
53df7c11 5405 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5406
f38b440c
PE
5407 * coding.c (coding_set_source, coding_set_destination):
5408 Use "else { /* comment */ }" rather than "else /* comment */;"
5409 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5410 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5411 a block, when the outer 'i' will do.
5412 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5413 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5414 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5415 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5416 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5417 Rename locals to avoid shadowing.
5418 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5419 * coding.c (emacs_mule_char, encode_invocation_designation):
5420 Now static, since they're not used elsewhere.
413bb2db 5421 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5422 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5423 (decode_coding_emacs_mule): Mark variables that gcc
5424 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5425 (detect_coding_iso_2022): Initialize a local variable that might
5426 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5427 this initialization is needed. (Bug#8211)
5f58e762
PE
5428 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5429 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5430 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5431 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5432 Remove unused macros.
f38b440c 5433
232b38b9 5434 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5435 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5436 * character.c (string_count_byte8): Likewise.
232b38b9 5437
fb90da1b
PE
5438 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5439 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5440
fb93dbc2
PE
5441 * chartab.c (copy_sub_char_table): Now static, since it's not used
5442 elsewhere.
5c156ace
PE
5443 (sub_char_table_ref_and_range, char_table_ref_and_range):
5444 Rename locals to avoid shadowing.
bbcd0949 5445 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5446
7d3b3862 5447 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5448 (BIDI_BOB): Remove unused macro.
7d3b3862 5449
6be7d3da
PE
5450 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5451 deduce are never used uninitialized.
c2ed9c8b 5452 * term.c (encode_terminal_code): Likewise.
6be7d3da 5453
75f8807f 5454 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5455
50938595
PE
5456 * tparam.h: New file.
5457 * term.c, tparam.h: Include it.
5458 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5459 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5460 Move these decls to tparam.h, and make them agree with what
5461 is actually in tparam.c. The previous trick of using incompatible
5462 decls in different modules does not conform to the C standard.
5463 All callers of tparam changed to use tparam's actual API.
5464 * tparam.c (tparam1, tparam, tgoto):
5465 Use const pointers where appropriate.
5466
fbceeba2
PE
5467 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5468 * cm.h (struct cm): Likewise.
5469 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5470 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5471 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5472 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5473 (turn_on_face, init_tty): Likewise.
5474 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5475
7f3f1250
PE
5476 * term.c (term_mouse_position): Rename local to avoid shadowing.
5477
e6ca6543
PE
5478 * alloc.c (mark_ttys): Move decl from here ...
5479 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5480
c40f8d15
AS
54812011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5482
5483 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5484
cfe0661d
JB
54852011-03-09 Juanma Barranquero <lekktu@gmail.com>
5486
5487 * search.c (compile_pattern_1): Remove argument regp, unused since
5488 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5489 (compile_pattern): Don't pass it.
5490
0afb4571
J
54912011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5492
5493 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5494 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5495 for ! HAVE_GTK3.
5496 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5497
5498 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5499
5500 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5501 gdk_window_get_screen, gdk_window_get_geometry,
5502 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5503 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5504 (xg_get_pixbuf_from_pixmap): New function.
5505 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5506 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5507 Call xg_get_pixbuf_from_pixmap instead of
5508 gdk_pixbuf_get_from_drawable.
5509 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5510 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5511 (xg_check_special_colors): Use GtkStyleContext and its functions
5512 for HAVE_GTK3.
5513 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5514 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5515 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5516 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5517 Call gtk_widget_get_preferred_size.
0afb4571
J
5518 (xg_frame_resized): gdk_window_get_geometry only takes 5
5519 parameters.
44f230aa
SM
5520 (xg_win_to_widget, xg_event_is_for_menubar):
5521 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5522 (xg_set_widget_bg): New function.
5523 (delete_cb): New function.
895009e1 5524 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5525 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5526 (xg_set_background_color): Call xg_set_widget_bg.
5527 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5528 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5529 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5530 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5531 if ! HAVE_GTK3.
5532 (update_frame_tool_bar): Call gtk_widget_hide.
5533 (xg_initialize): Use GDK_KEY_g.
5534
5535 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5536 if ! HAVE_GTK3
5537 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5538
5539 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5540 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5541 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5542
1c2cc4ef
JB
55432011-03-08 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * w32xfns.c (select_palette): Check success of RealizePalette against
5546 GDI_ERROR, not zero.
5547
33383987 5548See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5549
5550;; Local Variables:
5551;; coding: utf-8
aac0c6e3
MR
5552;; End:
5553
33383987 5554 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5555
5556 This file is part of GNU Emacs.
5557
5558 GNU Emacs is free software: you can redistribute it and/or modify
5559 it under the terms of the GNU General Public License as published by
5560 the Free Software Foundation, either version 3 of the License, or
5561 (at your option) any later version.
5562
5563 GNU Emacs is distributed in the hope that it will be useful,
5564 but WITHOUT ANY WARRANTY; without even the implied warranty of
5565 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5566 GNU General Public License for more details.
5567
5568 You should have received a copy of the GNU General Public License
5569 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.