Generalize and cleanup font subsystem checks.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4e6a86c6
DA
12012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Generalize and cleanup font subsystem checks.
4 * font.h (FONT_DEBUG, font_assert): Remove.
5 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c: Change
6 font_assert to eassert. Use eassert where appropriate.
7
5bf192ca
DA
82012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
9
10 * gtkutil.c (xg_get_font): Use pango_units_to_double.
11
f2045622
CY
122012-08-15 Chong Yidong <cyd@gnu.org>
13
14 * gtkutil.c (xg_get_font): Rename from xg_get_font_name. When
15 using the new font chooser, use gtk_font_chooser_get_font_desc to
16 extract the font descriptor instead of just the font name. In
17 that case, return a font spec instead of a string.
18 (x_last_font_name): Move to this file from xfns.c.
19
20 * xfns.c (Fx_select_font): The return value can also be a font
21 spec. Move x_last_font_name management to gtkutil.c.
22
23 * xfaces.c: Make font weight and style symbols non-static.
24
7f6feb56
SM
252012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
26
27 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
28 (bug#12117).
29
fecbd8ff
SM
302012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
31
32 * alloc.c (Fgarbage_collect): Use plural form consistently.
33
9b8d5165
EZ
342012-08-14 Eli Zaretskii <eliz@gnu.org>
35
36 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
37 iteration through the command loop. Fixes a problem whereby mouse
38 movements are ignored until the first mouse click.
39
f5d9e83a
PE
402012-08-14 Paul Eggert <eggert@cs.ucla.edu>
41
42 Use bool, not int, for Lisp booleans.
43 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
44 makes Emacs a bit smaller and presumably a bit faster.
45 * lisp.h: Include <stdbool.h>.
46 (struct Lisp_Boolfwd, defvar_bool):
47 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
48 * regex.c [!emacs]: Include <stdbool.h>.
49 (false, true): Remove; <stdbool.h> does this for us now.
50
55802e4a
CY
512012-08-14 Chong Yidong <cyd@gnu.org>
52
4abcdac8
CY
53 * character.c (Fcharacterp): Doc fix (Bug#12076).
54
55 * data.c (Findirect_variable): Doc fix (Bug#11040).
56
55802e4a
CY
57 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
58
59 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 60 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 61
8e99d072
BR
622012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
63
64 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
65 (bug#12022).
66
08908aca
MR
672012-08-14 Martin Rudalics <rudalics@gmx.at>
68
69 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
70 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
71 * minibuf.c (choose_minibuf_frame, read_minibuf):
72 * w32fns.c (x_create_tip_frame):
73 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
74 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
75
56120d6f
PE
762012-08-14 Paul Eggert <eggert@cs.ucla.edu>
77
78 * intervals.c (offset_intervals): Remove obsolete comment.
79
67b77c0b
AS
802012-08-14 Andreas Schwab <schwab@linux-m68k.org>
81
82 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
83
f48b82fd
GR
842012-08-14 Gergely Risko <gergely@risko.hu>
85
86 * coding.c (decode_coding): Record buffer modification before
87 disabling undo_list (Bug#11773).
88
fd318b54
DA
892012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
90
91 Revert and cleanup some recent overlay changes.
92 * buffer.h (enum overlay_type): Remove.
93 (buffer_get_overlays, buffer_set_overlays): Likewise.
94 (buffer_set_overlays_before, buffer_set_overlays_after):
95 New function. Adjust users.
96 (unchain_both): Add eassert.
97
41a62dd9
DA
982012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
99
100 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
101
5884c324
PE
1022012-08-14 Paul Eggert <eggert@cs.ucla.edu>
103
104 * gtkutil.c (xg_mark_data): Don't assume C99.
105
ca06f160
JD
1062012-08-13 Jan Djärv <jan.h.d@swipnet.se>
107
108 * gtkutil.c (xg_frame_tb_info): New struct.
109 (TB_INFO_KEY): New define.
110 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
111 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
112 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
113 if not present.
114 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
115 is up to date. Otherwise store new data.
116 (free_frame_tool_bar): Free xg_frame_tb_info if present.
117
7864a3f7
DA
1182012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
119
120 Use KSET for write access to Lisp_Object members of struct kboard.
121 * keyboard.h (KSET): New macro.
122 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
123 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
124 * xterm.c: Adjust users.
125
4c31be61
DA
1262012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
127
128 Use BSET for write access to Lisp_Object members of struct buffer.
129 * buffer.h (BSET): New macro.
130 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
131 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
132 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
133 * window.c, xdisp.c, xfns.c: Adjust users.
134
14ae4239
BT
1352012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
136
137 * lread.c (syms_of_lread): Initialize Vlexical_binding.
138
32bcadb4
JD
1392012-08-11 Jan Djärv <jan.h.d@swipnet.se>
140
3d29b2ce
JD
141 * nsterm.m (not_in_argv): New function.
142 (application:openFile, application:openTempFile:):
143 (application:openFileWithoutUI:, application:openFiles:): Open file
144 if not_in_argv returns non-zero (bug#12171).
145
32bcadb4 146 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
147 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
148 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
149 (xg_get_font_name): Use those functions/macros here.
150 Reported by Frans Oilinki <moilinki@gmail.com>.
151
9ff9402d 1522012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
153
154 * unexmacosx.c (copy_data_segment): Copy initialized data in
155 statically linked libraries from input file rather than memory.
156
db74a5fc
YM
157 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
158 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
159 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
160
25e65510
GM
1612012-08-10 Glenn Morris <rgm@gnu.org>
162
163 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
164 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
165
7961135c
DA
1662012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
167
168 Fix last change to allow compilation with low optimization levels.
169 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
170 Reported by Jan Djärv <jan.h.d@swipnet.se>.
171
42b3a444
DA
1722012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
173
174 Use common inline syntax in intervals.h.
175 * intervals.h (INTERVALS_INLINE): New macro.
176 Change all users from LISP_INLINE.
177
9fb0c957
DA
1782012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Define Qnone once for all platforms.
181 * frame.c (Qnone): Define here.
182 (syms_of_frame): DEFSYM it.
183 * lisp.h (Qnone): New declaration.
184 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
185 * xfns.c: Remove duplication. Adjust users.
186
65e8ee52
DA
1872012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Remove unused macros from intervals.h.
190 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
191 * intervals.c: Adjust comment.
192
9b855fd6
EZ
1932012-08-10 Eli Zaretskii <eliz@gnu.org>
194
195 * w32fns.c <w32_unicode_gui>: New static variable.
196 (globals_of_w32fns): Initialize it according to os_subtype.
197 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
198 testing os_subtype.
199
39cb9e56 2002012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
201 Eli Zaretskii <eliz@gnu.org>
202
203 Fix bug #10299 with Unicode characters sent by customized
204 keyboards created by MSKLC.
205 * w32fns.c (INIT_WINDOW_CLASS): New macro.
206 (w32_init_class): Use it to initialize the Emacs class with either
207 ANSI or Unicode API calls.
208 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
209 later.
210 (w32_wnd_proc): If the character code sent by WM_CHAR or
211 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
212 original message. Call DefWindowProcW on NT and later.
213
9374581a
GM
2142012-08-10 Glenn Morris <rgm@gnu.org>
215
4b94e8cf
GM
216 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
217
9374581a
GM
218 * lisp.h (DIRECTORY_SEP): Let configure set it.
219
a2752828
DA
2202012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Use TSET for write access to Lisp_Object slots of struct terminal.
223 * termhooks.h (TSET): New macro.
224 * coding.c, terminal.c, xselect.c: Adjust users.
225
cc92c454
SM
2262012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
227
228 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
229 the failing expression, include them in the error message.
230 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
231 * lisp.h (internal_condition_case_n): Update declaration.
232
4cb3e6b3
DA
2332012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
234
235 Inline functions to examine and change buffer overlays.
236 * buffer.c (unchain_both): New function.
237 * buffer.h (buffer_get_overlays, buffer_set_overlays):
238 (buffer_has_overlays): New function.
239 (enum overlay_type): New enum.
240 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
241 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
242
8707c1e5
DA
2432012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Inline functions to examine and change buffer intervals.
246 * alloc.c (mark_interval_tree): Remove.
247 (MARK_INTERVAL_TREE): Simplify.
248 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
249 * intervals.c (buffer_balance_intervals): New function.
250 (graft_intervals_into_buffer): Adjust indentation.
251 (set_intervals_multibyte): Simplify.
252 * buffer.h (BUF_INTERVALS): Remove.
253 (buffer_get_intervals, buffer_set_intervals): New function.
254 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
255 * intervals.c, textprop.c: Adjust users.
256
ad8c997f
DA
2572012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
258
259 Inline functions to examine and change string intervals.
260 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
261 (string_get_intervals, string_set_intervals): New function.
262 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
263 * lread.c, print.c, textprop.c: Adjust users.
264
32ac3a6b
GM
2652012-08-08 Glenn Morris <rgm@gnu.org>
266
267 * lisp.mk (lisp): Remove language/persian.elc.
268
77c7bcb1
DA
2692012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Cleanup intervals.
272 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
273 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
274 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
275 Adjust comment. Move under #if 0.
77c7bcb1
DA
276 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
277 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
278
9c08a8d4
DA
2792012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Check total length of intervals with eassert.
282 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
283 * intervals.c: Change all users to eassert.
284
26d16b35
EZ
2852012-08-07 Eli Zaretskii <eliz@gnu.org>
286
14ae4239
BT
287 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
288 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
289 INTERNAL_FIELD in Lisp_Cons.
290
c644523b
DA
2912012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
294 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
295 name since all xname users are fixed long time ago. Do not
296 use INTERNAL_FIELD.
297 (set_symbol_name, set_symbol_function, set_symbol_plist):
298 (set_symbol_next, set_overlay_plist): New function.
299 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
300 (struct Lisp_Overlay): Likewise.
301 (CVAR, MVAR, SVAR): Remove.
302 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
303 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
304 * xterm.c: Adjust users.
305 * .gdbinit: Change to use name field of struct Lisp_Symbol
306 where appropriate.
307
6a3d20cc
DA
3082012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Basic functions to set Lisp_Object and pointer slots of intervals.
311 * intervals.h (interval_set_parent, interval_set_object):
312 (interval_set_left, interval_set_right, interval_set_plist):
313 (interval_copy_parent): New function.
314 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
315 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
316 Adjust indentation.
6a3d20cc
DA
317 (INTERVAL_SIZE): Remove. Adjust users.
318 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
319
4d2b044c
DA
3202012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
323 * process.h (PGET): Remove.
324 (struct Lisp_Process): Do not use INTERNAL_FIELD.
325 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
326
d3d50620
DA
3272012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Drop WGET and revert read access to Lisp_Objects slots of struct window.
330 * window.h (WGET): Remove.
331 (struct window): Do not use INTERNAL_FIELD.
332 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
333 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
334 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
335 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
336 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
337 Adjust users.
338
d10a51dc
CY
3392012-08-07 Chong Yidong <cyd@gnu.org>
340
341 * window.c (Fwindow_edges, Fwindow_pixel_edges)
342 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
343 (Fdelete_window_internal): Signal an error if the window is not on
344 a live frame (Bug#12025).
345
e69b0960
DA
3462012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
347
348 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
349 * frame.h (FGET): Remove.
350 (struct frame): Do not use INTERNAL_FIELD.
351 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
352 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
353 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
354 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
355
25a20a3a
JB
3562012-08-06 Juanma Barranquero <lekktu@gmail.com>
357
358 * w32.c: Silence compiler warnings.
359 (map_w32_filename): Remove unused variable `is_fat'.
360 (chase_symlinks): Add parentheses around expression.
361
1c6f11f4
GM
3622012-08-06 Glenn Morris <rgm@gnu.org>
363
1db4583a
GM
364 * sysdep.c: Respect BROKEN_GETWD.
365
1c6f11f4
GM
366 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
367 Let configure handle it.
368 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
369
2b90362b
DA
3702012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
371
372 Use GCALIGNMENT where appropriate.
373 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
374 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
375 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
376
5f50daf2
EZ
3772012-08-06 Eli Zaretskii <eliz@gnu.org>
378
14ae4239
BT
379 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
380 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 381
cbcc7007
SM
3822012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
383
384 * buffer.h (struct buffer): Revert `indirections' to a simple int;
385 that should be sufficient for everyone.
386
4d365fa4
JD
3872012-08-06 Jan Djärv <jan.h.d@swipnet.se>
388
389 * keyboard.c (timer_check_2): Add break so timer_check returns next
390 timeout.
391
dd86bd82
DA
3922012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
393
394 Fix Windows build errors introduced after converting to WGET and WSET.
395 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
396 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
397
054e1668
JD
3982012-08-06 Jan Djärv <jan.h.d@swipnet.se>
399
400 * nsterm.m (ns_frame_rehighlight): Use FSET.
401
402 * nsmenu.m (ns_update_menubar): Use FSET.
403
21238f11
DA
4042012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Separate read and write access to Lisp_Object slots of Lisp_Process.
407 * process.h (PGET, PSET): New macros similar to AREF and ASET.
408 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
409
077288cf
DA
4102012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
411
412 Separate read and write access to Lisp_Object slots of struct window.
413 * window.h (WGET, WSET): New macros similar to AREF and ASET.
414 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
415 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
416 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
417 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
418 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
419 Adjust users.
420
71688bd7
DA
4212012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Fix Windows build errors introduced after converting to FGET and FSET.
424 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
425 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
426 (w32_judge_scroll_bars): Change to use FSET.
427 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
428
f99bac93
DA
4292012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
430
431 Fix replacement typo.
432 * window.c (replace_window): Set root_window instead of
433 selected_window. This fixes a total window subsystem
434 malfunction reported by Bastien Guerry <bzg@gnu.org>.
435
8c2a0f2d
GM
4362012-08-06 Glenn Morris <rgm@gnu.org>
437
438 * lisp.mk (lisp): Add language/persian.elc.
439
edd74c35
DA
4402012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Separate read and write access to Lisp_Object slots of struct frame.
443 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
444 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
445 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
446 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
447 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
448
8671676c
AS
4492012-08-05 Andreas Schwab <schwab@linux-m68k.org>
450
451 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
452
663e2b3f
DA
4532012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
454
455 Generalize common compile-time constants.
456 * lisp.h (header_size, bool_header_size, word_size): Now here.
457 (struct Lisp_Vector): Add comment.
458 (struct Lisp_Bool_Vector): Move up to define handy constants.
459 (VECSIZE, PSEUDOVECSIZE): Simplify.
460 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
461 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
462 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
463 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
464 * xfont.c, xmenu.c: Use word_size where appropriate.
465
d32e47af
LM
4662012-08-05 Lawrence Mitchell <wence@gmx.li>
467
468 * search.c (Freplace_match): Treat \? in the replacement text
469 literally (Bug#8161).
470
e5d9c0d1
CY
4712012-08-05 Chong Yidong <cyd@gnu.org>
472
473 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
474 * frame.c (Vdelete_frame_functions):
475 * emacs.c (Vkill_emacs_hook): Doc fix.
476
8da0576b
EZ
4772012-08-04 Eli Zaretskii <eliz@gnu.org>
478
479 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
480 --with-x-toolkit=no builds.
481 Reported by Carsten Mattner <carstenmattner@gmail.com>.
482
02676e5d
CY
4832012-08-04 Chong Yidong <cyd@gnu.org>
484
485 * syntax.c (Fmodify_syntax_entry): Doc fix.
486
97147da9
EZ
4872012-08-04 Eli Zaretskii <eliz@gnu.org>
488
76151e2c
EZ
489 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
490 * w32.c (init_environment): Change the default values of many
491 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
492 them into environment when they were not already defined.
493 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 494 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
495 (check_windows_init_file): Now external, not static.
496 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
497 called when Vload_path is already set up.
498
499 * w32.h (check_windows_init_file): Add prototype.
500
501 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
502 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
503 compatibility with Posix platforms.
504 (main): Move the call to check_windows_init_file to here from
505 w32.c.
506 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
507 any, in the DEFALT argument into the root of the Emacs build or
508 installation tree, as appropriate.
509
510 * callproc.c (init_callproc_1): Call decode_env_path instead of
511 doing its equivalent by hand.
512 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
513 the code that sets Vexec_path run on MS-Windows.
514
515 * lread.c (init_lread): Add comments to #ifdef's.
516
97147da9
EZ
517 * msdos.c (dos_set_window_size, IT_update_begin)
518 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
519 instead of direct references.
520
185ee146
PE
5212012-08-04 Paul Eggert <eggert@cs.ucla.edu>
522
523 Export DEFAULT_REHASH_* to GDB.
524 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
525 Now constants, not macros.
526
8834c57a
PE
5272012-08-03 Paul Eggert <eggert@cs.ucla.edu>
528
98c6f1e3
PE
529 Remove unnecessary casts involving pointers.
530 These casts are no longer needed now that we assume C89 or later,
531 since they involve casting to or from void *.
532 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
533 (make_pure_float, make_pure_vector):
534 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
535 * macros.c (Fstart_kbd_macro):
536 * menu.c (find_and_return_menu_selection):
537 * minibuf.c (read_minibuf_noninteractive):
538 * sysdep.c (closedir):
539 * xdisp.c (x_produce_glyphs):
540 * xfaces.c (compare_fonts_by_sort_order):
541 * xfns.c (x_real_positions, select_visual):
542 * xselect.c (x_stop_queuing_selection_requests)
543 (x_get_window_property, x_get_window_property_as_lisp_data):
544 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
545 Remove unnecessary pointer casts.
546 * alloc.c (record_xmalloc): New function.
547 * lisp.h (record_xmalloc): New decl.
548 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
549 more like a function. This is because the pointer cast is not
550 needed. All uses changed.
551 * print.c (print_string, print_error_message): Avoid length recalc.
552
8834c57a
PE
553 Improve fix for macroexp crash with debugging (Bug#12118).
554 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
555 ARRAY_MARK_FLAG when checking subscripts, because ASET is
556 not supposed to be invoked from the garbage collector.
557 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
558 (gc_aset): New function, which is like ASET but can be
559 used in the garbage collector.
560 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
561 (set_hash_index): Use it instead of ASET.
562
6dad7178
EZ
5632012-08-03 Eli Zaretskii <eliz@gnu.org>
564
565 Support symlinks on latest versions of MS-Windows.
566 * w32.c: Include winioctl.h and aclapi.h.
567 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
568 (revert_to_self): Forward declarations of static functions.
569 <static BOOL g_b_init_get_security_info>:
570 <g_b_init_create_symbolic_link>: New static flags.
571 (globals_of_w32): Initialize them to zero.
572 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
573 (map_w32_filename): Improve commentary. Simplify switch.
574 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
575 headers (most versions of MinGW w32api don't).
576 (get_security_info, create_symbolic_link)
577 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
578 New functions.
579 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
580 in the argument file name.
581 (sys_access): Call unc_volume_file_attributes only if
582 GetFileAttributes fails with network-related error codes.
583 (sys_rename): Diagnose renaming of a symlink when the user doesn't
584 have the required privileges.
14ae4239 585 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
586 get_file_security_desc.
587 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
588 with addition of handling of symlinks and support for 'lstat'.
589 If possible, get file's attributes and security information by
6dad7178
EZ
590 handle, not by name. Produce S_IFLNK bit for symlinks, when
591 called from 'lstat'.
592 (stat, lstat): New functions, call 'stat_worker'.
593 (symlink, readlink, careadlinkat): Rewritten to create and resolve
594 symlinks when the underlying filesystem supports them.
595
f162bcc3
PE
5962012-08-02 Paul Eggert <eggert@cs.ucla.edu>
597
79ea6c20
PE
598 Fix macroexp crash on Windows with debugging (Bug#12118).
599 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
600 checking subscripts; problem introduced with the recent
601 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
602 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
603 since it's used in non-static inline functions now.
604
c0ce93fd
PE
605 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
606 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 607
f162bcc3
PE
608 Use C99-style 'extern inline' if available.
609 * buffer.h (BUFFER_INLINE):
610 * category.h (CATEGORY_INLINE):
611 * character.h (CHARACTER_INLINE):
612 * charset.h (CHARSET_INLINE):
613 * composite.h (COMPOSITE_INLINE):
614 * dispextern.h (DISPEXTERN_INLINE):
615 * lisp.h (LISP_INLINE):
616 * systime.h (SYSTIME_INLINE):
617 New macro, replacing 'static inline' in this header.
618 * buffer.h, category.h, character.h, charset.h, composite.h:
619 * dispextern.h, lisp.h, systime.h:
620 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
621 * alloc.c (LISP_INLINE):
622 * buffer.c (BUFFER_INLINE):
623 * category.c (CATEGORY_INLINE):
624 * character.c (CHARACTER_INLINE):
625 * charset.c (CHARSET_INLINE):
626 * composite.c (COMPOSITE_INLINE):
627 * dispnew.c (DISPEXTERN_INLINE):
628 * sysdep.c (SYSTIME_INLINE):
629 Define to EXTERN_INLINE, so that the corresponding functions
630 are compiled into code.
631 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
632 (INLINE_HEADER_END): New macros.
633 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
634 since it's used in non-static inline functions now.
a8333d03 635 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 636
837b365b
GM
6372012-08-02 Glenn Morris <rgm@gnu.org>
638
d66b744d
GM
639 * s/: Remove empty directory.
640
837b365b
GM
641 * s/ms-w32.h: Move to ../nt/inc.
642 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
643 Update for new ms-w32.h location.
644
13294f95
PE
6452012-08-02 Paul Eggert <eggert@cs.ucla.edu>
646
647 Port to Solaris 8.
648 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
649
90df0db3
GM
6502012-08-02 Glenn Morris <rgm@gnu.org>
651
652 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
653 hard-coding the path separator.
654
4939150c
PE
6552012-08-01 Paul Eggert <eggert@cs.ucla.edu>
656
657 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
658 This how ASET and AREF are supposed to work, and makes
659 it easier to think about future improvements. See
660 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
661 * charset.h (set_charset_attr): New function.
662 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
663 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
664 (aref_addr): New function. All uses of &AREF(...) changed.
665 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
666 (set_hash_index): New functions. All lvalue-style uses of
667 HASH_KEY etc. changed.
668 * keyboard.c (set_prop): New function. All lvalue-style uses
669 of PROP changed.
670
947b2afd
AA
6712012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
672
673 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
674 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
675 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
676 * nsfns.m (ns_set_name_as_filename): Likewise.
677 * nsmenu.m (ns_update_menubar): Likewise.
678 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
679
4f5d0325
EZ
6802012-08-01 Eli Zaretskii <eliz@gnu.org>
681
2008beae
EZ
682 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
683 Adapt to latest changes in field names of the corresponding Lisp
288479f6 684 objects.
2008beae 685
4f5d0325
EZ
686 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
687
fe3cc771
GM
6882012-08-01 Glenn Morris <rgm@gnu.org>
689
690 * s/msdos.h: Remove file.
691 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
692 * Makefile.in (S_FILE): Remove.
693 (config_h): Remove S_FILE.
694
c90acc54
JB
6952012-08-01 Juanma Barranquero <lekktu@gmail.com>
696
697 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
698 Remove; moved to nt/config.nt.
699
d8a05828
DA
7002012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
701
702 Use INTERNAL_FIELD for conses and overlays.
703 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
704 Remove obsolete comment.
705 (MVAR): New macro.
706 (struct Lisp_Overlay): Use INTERNAL_FIELD.
707 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
708
8271d590
DA
7092012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
710
711 Use INTERNAL_FIELD for symbols.
712 * lisp.h (SVAR): New macro. Adjust users.
713 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
714 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
715
3193acd2
DA
7162012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
717
718 Use INTERNAL_FIELD for processes.
719 * process.h (PVAR): New macro. Adjust style.
720 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
721 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
722
3a45383a
DA
7232012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
724
725 Use INTERNAL_FIELD for windows.
726 * window.h (WVAR): New macro.
727 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
728 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
729 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
730 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
731 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
732 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
733
c1dbc63c
PE
7342012-08-01 Paul Eggert <eggert@cs.ucla.edu>
735
736 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
737
5c0c0e8a
GM
7382012-08-01 Glenn Morris <rgm@gnu.org>
739
740 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
741 Move to configure.ac.
742
552a99b4
JB
7432012-08-01 Juanma Barranquero <lekktu@gmail.com>
744
745 * makefile.w32-in (CONFIG_H): Update dependencies.
746 (CONF_POST_H): New macro.
747
748 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
749
8d8e2dfe
GM
7502012-07-31 Glenn Morris <rgm@gnu.org>
751
bc96620a
GM
752 * Makefile.in (S_FILE): No longer set by configure.
753
476b1b2d
GM
754 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
755 is available.
756 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
757
b2c7a106
GM
758 * process.h (NULL_DEVICE):
759 * emacs.c (SEPCHAR):
760 * editfns.c (USER_FULL_NAME): Let configure set them.
761
d53d062a
GM
762 * s/README, s/template.h: Remove files.
763
4515017f
GM
764 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
765
8d8e2dfe
GM
766 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
767 Move to configure.ac.
768
5b20b3cc
EZ
7692012-07-31 Eli Zaretskii <eliz@gnu.org>
770
1e0afd9a
EZ
771 * .gdbinit (xframe): Adapt to introduction of FVAR and the
772 resulting renaming of 'struct frame' members.
773
5b20b3cc
EZ
774 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
775
776 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
777 after introduction of FVAR.
778
f1310128
JD
7792012-07-31 Jan Djärv <jan.h.d@swipnet.se>
780
79e721e0
JD
781 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
782
783 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
784 instead of compositeToPoint.
785 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
786
8d7c7eed 787 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 788
e34f7f79
DA
7892012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
790
791 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
792 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 793 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
794 (BVAR): Change to use INTERNAL_FIELD.
795 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
796 (KVAR): Change to use INTERNAL_FIELD.
797 * frame.h (FVAR): New macro.
798 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
799 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
800 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
801 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
802 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
803
c09bfb2f
DA
8042012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
805
806 Miscellaneous fixes for non-default X toolkits.
807 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
808 * xterm.c (x_frame_of_widget): Remove redundant prototype.
809 Move under #ifdef USE_LUCID.
810 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
811 definition and usage to avoid warnings.
812
14c114ae
JD
8132012-07-31 Jan Djärv <jan.h.d@swipnet.se>
814
815 * nsterm.m (openFiles): Fix previous checkin.
816
3bd21e82
PE
8172012-07-31 Paul Eggert <eggert@cs.ucla.edu>
818
819 * indent.c (compute_motion): Remove unused local.
820
c1529ded
GM
8212012-07-31 Glenn Morris <rgm@gnu.org>
822
400d5621
GM
823 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
824
268e2432
GM
825 * conf_post.h [USG5_4]:
826 Move remaining contents of s/usg5-4-common.h here.
827 * s/usg5-4-common.h: Remove file.
828
7552f3ee
GM
829 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
830 * s/irix6-5.h: Remove file.
831
6a381852
GM
832 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
833 * s/darwin.h: Remove file.
834
c1529ded
GM
835 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
836 * s/hpux10-20.h: Remove file, which is now empty.
837
b429a4ee
GM
8382012-07-30 Glenn Morris <rgm@gnu.org>
839
840 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
841 * Makefile.in (config_h): Add conf_post.h.
842 * makefile.w32-in (CONFIG_H): Add conf_post.h.
843
adff3182
JD
8442012-07-30 Jan Djärv <jan.h.d@swipnet.se>
845
846 * nsterm.m (ns_do_open_file): New variable.
b9031d69 847 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
848 (openFile, openTempFile, openFileWithoutUI, openFiles):
849 Open files only if ns_do_open_file.
adff3182 850
c32af1e4
PE
8512012-07-30 Paul Eggert <eggert@cs.ucla.edu>
852
7393bcbb
PE
853 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
854 This no-op macro hasn't been needed for many years.
855 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
856
c32af1e4
PE
857 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
858 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
859 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
860 gdb_make_enums_visible.
861 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
862 (DIRECTORY_SEP): Now a constant, not a macro.
863
302fc036
EZ
8642012-07-30 Eli Zaretskii <eliz@gnu.org>
865
866 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
867 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
868
869 * w32term.c <w32_keyboard_codepage>: Renamed from
870 keyboard_codepage and now external. All users changed.
871
872 * w32term.h: Add declaration of w32_keyboard_codepage.
873
874 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
875 the codepage to translate keys to Unicode. If this argument is
876 -1, use the value returned by GetConsoleCP. All callers changed.
877
88fb40b4
PE
8782012-07-30 Paul Eggert <eggert@cs.ucla.edu>
879
0aee6912
PE
880 Update .PHONY listings in makefiles.
881 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
882 bootstrap-clean, distclean, maintainer-clean, versioclean,
883 extraclean, frc.
884
88fb40b4
PE
885 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
886 This is a bit clearer. Fix some commentary typos.
887
0a763bd1
GM
8882012-07-30 Glenn Morris <rgm@gnu.org>
889
32bac6d6
GM
890 * s/netbsd.h: Let configure include signal.h if needed.
891 Remove file, which is now empty.
892
b65e7c46
GM
893 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
894 Let configure set them.
895 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
896 No more need to undefine.
0a763bd1 897
169304bd
AS
8982012-07-30 Andreas Schwab <schwab@linux-m68k.org>
899
900 * keymap.c (Fkey_description): Don't remove 0x80 bit from
901 non-single-byte char when adding meta modifier. (Bug#12090)
902
6cd7a139
DA
9032012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
904
905 Convert safe_call to use variable number of arguments.
906 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
907 (safe_call2): Fix comment.
908 * lisp.h (safe_call): Adjust prototype.
909 * coding.c (encode_coding_object): Change to use safe_call2.
910 * xfaces.c (merge_face_heights): Change to use safe_call1.
911
d34d6ffc
GM
9122012-07-30 Glenn Morris <rgm@gnu.org>
913
7b8a48e4 914 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 915 does that unconditionally. Remove file, which is now empty.
7b8a48e4 916
d34d6ffc
GM
917 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
918 Remove empty files.
919
03a660a6
PE
9202012-07-30 Paul Eggert <eggert@cs.ucla.edu>
921
922 Export to GDB most of lisp.h's remaining object-like macros.
923 * lisp.h (min, max): Move earlier, because they're used earlier now.
924 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
925 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
926 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
927 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
928 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
929 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
930 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
931 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
932 Now constants, for GDB. They need not be macros.
933 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
934 Now constants, for GDB, as well as macros, for static initializers.
935 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
936 Move to after the definition of struct Lisp_Char_Table,
937 since the former now needs that type defined.
938 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
939 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
940 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
941 New enums, for gdb_make_enums_visible.
942 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 943 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
944 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
945 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
946 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
947 enum maxargs, enum MAX_ALLOCA.
948 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
949 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
950 no longer needed, now that they are done in lisp.h.
951
e499d0ee
DA
9522012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
953
954 Cleanup string bytes checking.
955 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
956 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
957 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
958 (check_sblock, compact_small_strings): Simplify.
959
d5040d2d
PE
9602012-07-29 Paul Eggert <eggert@cs.ucla.edu>
961
962 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
963 These macros are confusing and no longer need to be defined, as
964 the enum values now suffice. All uses replaced with definiens.
965 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
966
7f259ae6
JB
9672012-07-29 Juanma Barranquero <lekktu@gmail.com>
968
969 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
970 ($(BLD)/w32console.$(O)): Update dependencies.
971
7e63e0c3
DA
9722012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
973
974 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
975 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
976 time. Adjust users.
977 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
978
ffd817eb
JD
9792012-07-29 Jan Djärv <jan.h.d@swipnet.se>
980
981 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
982 setting sitelisp (Bug#12010).
983
417a7a0e
EZ
9842012-07-29 Eli Zaretskii <eliz@gnu.org>
985
14ae4239 986 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
987
988 * w32heap.c (cache_system_info):
989 * w32.c (sys_rename):
990 * w32proc.c (find_child_console, sys_kill): All users changed.
991
387d4d92
PE
9922012-07-29 Paul Eggert <eggert@cs.ucla.edu>
993
994 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
995
55a6cca6
EZ
9962012-07-29 Eli Zaretskii <eliz@gnu.org>
997
998 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
999
dbcf001c
DA
10002012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
1003 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
1004 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 1005
e2688e4a
DA
10062012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1007
1008 Generalize marker debugging code under MARKER_DEBUG and use eassert.
1009 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
1010 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
1011 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
1012 (replace_range, replace_range_2, del_range_2): Change to eassert.
1013 * marker.c (byte_char_debug_check): Adjust style.
1014
b46a6a83
PE
10152012-07-29 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
1018 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
1019 long-ago-commented-out code that talks about "WIN32".
1020 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
1021 All uses changed.
1022
e32a5799
PE
10232012-07-28 Paul Eggert <eggert@cs.ucla.edu>
1024
1025 Use Gnulib stdalign module (Bug#9772, Bug#9960).
1026 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
1027 Simplify by using alignof.
1028 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
1029 * lisp.h: Include <stdalign.h>.
1030 (GCALIGNMENT): New macro and constant.
1031 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
1032 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
1033 (stdalign): New macro, if not already defined.
1034
df81cd29
EZ
10352012-07-28 Eli Zaretskii <eliz@gnu.org>
1036
01bd1b0d
EZ
1037 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
1038 * w32inevt.c: Include w32inevt.h.
1039 (w32_read_console_input): New inline function, calls either
1040 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
1041 w32_console_unicode_input.
1042 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
1043 (w32_kbd_patch_key, key_event): Use the codepage returned by
1044 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
1045 (key_event): use uChar.UnicodeChar only if
1046 w32_console_unicode_input is non-zero.
1047
1048 * w32console.c: Include w32heap.h.
1049 <w32_console_unicode_input>: New global variable.
1050 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
1051 family of Windows, zero otherwise.
1052
1053 * w32inevt.h: Declare w32_console_unicode_input.
1054
df81cd29
EZ
1055 * xdisp.c (init_iterator): Don't reference tip_frame in a build
1056 --without-x. (Bug#11742)
1057
c20fdd9e
PE
10582012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1059
1060 Adjust GDB to reflect pvec_type changes (Bug#12036).
1061 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
1062 2012-07-04 changes to pseudovector representation.
1063 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 1064
32770973 10652012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
1066
1067 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
1068 bus address.
1069 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
1070
3438fe21
EZ
10712012-07-27 Eli Zaretskii <eliz@gnu.org>
1072
bcfbc9de
EZ
1073 * alloc.c (listn): Fix the order the arguments are consed onto the
1074 list.
1075
3438fe21
EZ
1076 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
1077 enumeration constants, as PURE and HEAP are too general, and clash
1078 with other headers and sources, such as gmalloc.c and the
1079 MS-Windows system headers. All users changed.
1080
eeaea515
DA
10812012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 Revert last save_excursion_save and save_excursion_restore changes.
1084 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
1085 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
1086
073c88c2
DA
10872012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1088
1089 Fix recently-introduced typos in Windows port.
1090 Reported by Martin Rudalics <rudalics@gmx.at>.
1091 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 1092 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 1093
4706125e
PE
10942012-07-27 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 Improve GDB symbol export (Bug#12036).
1097 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
1098 arms of an 'if', not using conditional expressions; otherwise GDB
1099 complains about the types in the unevaluated arm when the argument
1100 is an integer literal.
1101 (xgetint): Simplify expression.
1102 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1103 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1104 Zaretskii in <http://bugs.gnu.org/12036#13>.
1105 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1106 needed now that we have gdb_make_enums_visible.
1107 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1108 (enum enum_USE_LSB_TAG):
1109 New enum types, packaging up enums that need to be exported to GDB.
1110
694b6c97
DA
11112012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1112
1113 Utility function to make a list from specified amount of objects.
1114 * lisp.h (enum constype): New datatype.
1115 (listn): New prototype.
1116 * alloc.c (listn): New function.
1117 (Fmemory_use_count, syms_of_alloc): Use it.
1118 * buffer.c (syms_of_buffer): Likewise.
1119 * callint.c (syms_of_callint): Likewise.
1120 * charset.c (define_charset_internal): Likewise.
1121 * coding.c (syms_of_coding): Likewise.
1122 * keymap.c (syms_of_keymap): Likewise.
1123 * search.c (syms_of_search): Likewise.
1124 * syntax.c (syms_of_syntax): Likewise.
1125 * w32.c (init_environment): Likewise.
1126 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1127 * xdisp.c (syms_of_xdisp): Likewise.
1128 * xfns.c (syms_of_xfns): Likewise.
1129
6195f384
DA
11302012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Fast save_excursion_save and save_excursion_restore.
1133 * lisp.h (struct Lisp_Excursion): New data type.
1134 (PVEC_EXCURSION): New pseudovector type.
1135 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1136 to deal with it. Adjust comments.
1137 (init_marker, attach_marker): New prototype.
1138 (unchain_marker): Adjust prototype.
1139 * marker.c (attach_marker): Change to global.
1140 (init_marker): New function.
1141 * alloc.c (Fmake_marker, build_marker): Use it.
1142 (build_marker): More easserts.
1143 (mark_object): Handle struct Lisp_Excursion.
1144 * editfns.c (save_excursion_save, save_excursion_restore):
1145 Reimplement to use struct Lisp_Excursion. Add comments.
1146
5eceb8fb
PE
11472012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 Fix export of symbols to GDB (Bug#12036).
1150 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1151 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1152 emacs.c, as this is a more-suitable home. Had this been done earlier
1153 the fix for 12036 would have avoided some of the problems noted in
1154 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1155 would have been more obvious.
562157c8
PE
1156 * emacs.c: Do not include <verify.h>; no longer needed.
1157 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1158 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1159 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1160 Remove; now done in lisp.h.
1161 * lisp.h (PUBLISH_TO_GDB): New macro.
1162 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1163 (DATA_SEG_BITS): Use it.
1164 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1165 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1166 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1167 not be usable in #if. This simplifies things.
1168
d6749401
JB
11692012-07-26 Juanma Barranquero <lekktu@gmail.com>
1170
1171 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1172
1781b9e9
PE
11732012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1174
d89518db 1175 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1176 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1177 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1178 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1179 Adjust to changes in lisp.h and emacs.c, by using
1180 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1181 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1182 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1183 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1184 instead of gdb_valbits.
1185 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1186 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1187 instead of gdb_array_mark_flag.
1188 (xboolvector): Get size from $->size, not $->header.size.
1189 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1190 (xreload, hook-run, hookpost-run): Remove.
1191 * emacs.c: Include <verify.h>.
1192 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1193 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1194 Remove.
1195 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1196 (gdb_USE_LSB_TAG): New enum constants.
1197 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1198 Also define these as enum constants, so they're visible to GDB.
1199 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1200 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1201 as constants, so they're visible to GDB.
1202 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1203 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1204 Now enum constants, not macros, so they're visible to GDB.
1205 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1206 more convenient now. All uses changed.
1207 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1208 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1209
3628596a
DA
12102012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1211
1212 Explicitly free restriction data that are not needed anymore.
1213 * editfns.c (save_restriction_restore): Free restriction data.
1214
7abaf5cc
SM
12152012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1216
1217 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1218 add argument, tune behavior, and adjust all callers.
1219
71f88e00
PE
12202012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 Use typedef for EMACS_INT, EMACS_UINT.
1223 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1224 than macros. This simplifies debugging in the usual case, since
1225 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1226 and it allows expressions involving EMACS_INT casts.
1227 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1228
57ec3034
JD
12292012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1230
1231 * nsterm.m (ns_read_socket): Return early if there is a modal
1232 window (Bug#12043).
1233
8137e7b3
MR
12342012-07-25 Martin Rudalics <rudalics@gmx.at>
1235
1236 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1237 that FOCUS-FRAME can be omitted.
1238
04e9897c
DA
12392012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1240
1241 Adjust buffer text indirection counters at the end of Fkill_buffer.
1242 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1243 buffer is definitely dead. This should really fix an issue reported
1244 by Christoph Scholtes again. (Bug#12007).
1245 (init_buffer_once): Initialize indirection counters of
1246 buffer_defaults and buffer_local_symbols (for sanity and safety).
1247
8a0484e1
EZ
12482012-07-24 Eli Zaretskii <eliz@gnu.org>
1249
1250 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1251 and continuation glyphs on tooltip frames, leave them at zero.
1252 Avoids continued lines in tooltips. (Bug#11832)
1253
fa691a83
DA
12542012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1255
1256 Simplify copy_overlay.
04e9897c 1257 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1258 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1259
436bc8e0
EZ
12602012-07-23 Eli Zaretskii <eliz@gnu.org>
1261
1262 * print.c (print_object): Don't crash when a frame's name is nil
1263 or invalid. (Bug#12025)
1264
1265 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1266 it signals an error when a tooltip frame is being created.
1267
d7a7fda3
DA
12682012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 Cleanup miscellaneous objects allocation and initialization.
1271 * alloc.c (allocate_misc): Change to static. Add argument to
1272 specify the subtype. Adjust comment and users.
1273 (build_overlay): New function.
1274 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1275 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1276 (allocate_misc): Remove prototype.
1277 (build_overlay): Add prototype.
1278
12792012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1280
1281 Swap buffer text indirection counters in Fbuffer_swap_text.
1282 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1283 This avoids crash reported by Christoph Scholtes at
1284 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1285
9d7fa573
JD
12862012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1287
1288 * nsmenu.m (Popdown_data): New struct.
1289 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1290 free Popdown_data.
1291 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1292 (initWithContentRect): Make imgView and contentView non-static
1293 and autorelease them. Also autorelease img and matrix (Bug#12005).
1294 (dealloc): Remove (Bug#12005).
1295
0dd6d66d
DA
12962012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1297
1298 Adjust consing_since_gc when objects are explicitly freed.
1299 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1300 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1301 (free_cons, free_misc): Subtract object size from consing_since_gc.
1302
d36d71df
DA
13032012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1304
1305 Simplify and cleanup markers positioning code.
1306 * marker.c (attach_marker): More useful eassert.
1307 (live_buffer, set_marker_internal): New function.
1308 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1309 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1310
fb9ea40f
PE
13112012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1314 as it's limited by the amount of memory, not by INT_MAX.
1315
2d5c5f7d
EZ
13162012-07-21 Eli Zaretskii <eliz@gnu.org>
1317
07fb592e
EZ
1318 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1319 in special-event-map. See the discussion at
1320 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1321 for the reasons.
1322
37a9eac8 1323 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1324 info.dwItemData. Fixes crashes on 64-bit Windows.
1325 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1326
c4328746
JD
13272012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1328
1329 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1330 (conversationIdentifier): Return value is NSInteger.
784051c4 1331 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1332
6e5d1c12
CY
13332012-07-21 Chong Yidong <cyd@gnu.org>
1334
1335 * window.c (decode_any_window): Signal an error if the window is
1336 on a dead frame (Bug#11984).
1337
9928463d
DA
13382012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1339
1340 Add indirection counting to speed up Fkill_buffer.
1341 * buffer.h (struct buffer): New member.
1342 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1343 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1344 base buffer indirection counter.
1345 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1346 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1347 through buffer list if indirection counter is 0.
1348
f8643a6b
DA
13492012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1350
1351 Extend the value returned by Fgarbage_collect with heap statistics.
1352 * alloc.c (Qheap): New symbol.
1353 (syms_of_alloc): DEFSYM it.
1354 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1355 (Fmemory_free): Remove.
1356 (syms_of_alloc): Don't defsubr it.
1357 * buffer.c (Fcompact_buffer): Remove.
1358 (syms_of_buffer): Don't defsubr it.
1359
dac616ff
DA
13602012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 Make maybe_gc inline.
1363 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1364 * lisp.h (consing_since_gc, gc_relative_threshold)
1365 (memory_full_cons_threshold): Revert declaration.
1366 (maybe_gc): Remove prototype, define as inline.
1367 * alloc.c: Remove old commented-out code.
1368 (consing_since_gc, gc_relative_threshold)
1369 (memory_full_cons_threshold): Revert to global.
1370 (maybe_gc): Remove.
1371
d7ea76b4
DA
13722012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1373
1374 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1375 * lisp.h (build_unibyte_string): New function.
1376 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1377 * sysdep.c, w32fns.c, xfns.c: Use it.
1378 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1379 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1380 Adjust users accordingly.
1381 * font.h (font_open_by_name): Adjust prototype.
1382
765e61e3
DA
13832012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Cleanup calls to Fgarbage_collect.
1386 * lisp.h (maybe_gc): New prototype.
1387 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1388 Remove declarations.
1389 * alloc.c (maybe_gc): New function.
1390 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1391 Make them static.
1392 * bytecode.c (MAYBE_GC): Use maybe_gc.
1393 * eval.c (eval_sub, Ffuncall): Likewise.
1394 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1395 to avoid dependency from auto-save feature.
1396
52b852c7
PE
13972012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1398
1399 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1400 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1401 'for_each_per_buffer_object_at'.
1402 All uses changed. It's better to use upper-case for macros that
1403 cannot be implemented as functions, to give the reader a clue
1404 that they're special.
1405
5db81e33
SM
14062012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * alloc.c (Fgarbage_collect): Tweak docstring.
1409
5b835e1d
DA
14102012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1411
1412 Tweak the value returned from Fgarbage_collect again.
1413 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1414 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1415 Adjust documentation.
1416 (total_vector_bytes): Rename to total_vector_slots, adjust
1417 accounting.
1418 (total_free_vector_bytes): Rename to total_free_vector_slots,
1419 adjust accounting.
1420 (Qstring_bytes, Qvector_slots): New symbols.
1421 (syms_of_alloc): DEFSYM them.
1422
9cd47b72
DA
14232012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1424
1425 Buffer compaction primitive which may be used from Lisp.
1426 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1427 (syms_of_buffer): Register Fcompact_buffer.
1428 * alloc.c (Fgarbage_collect): Use compact_buffer.
1429 * buffer.h (compact_buffer): New prototype.
1430 (struct buffer_text): New member.
1431
d17337e5
DA
14322012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1433
1434 New macro to iterate over all buffers, miscellaneous cleanups.
1435 * lisp.h (all_buffers): Remove declaration.
1436 * buffer.h (all_buffers): Add declaration, with comment.
1437 (for_each_buffer): New macro.
1438 * alloc.c (Fgarbage_collect, mark_object): Use it.
1439 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1440 (init_buffer): Likewise.
1441 * data.c (Fset_default): Likewise.
1442 * coding.c (code_conversion_restore): Remove redundant check
1443 for dead buffer.
1444 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1445
60cfd278
AS
14462012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1447
1448 Fix bug that created negative-length intervals.
1449 * intervals.c (merge_interval_right, merge_interval_left):
1450 Do not zero out this interval if it is absorbed by its children,
1451 as this interval's total length doesn't change in that case. See
1452 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1453
d06714cb
PE
14542012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1455
83713154
PE
1456 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1457 when invoking (make-bool-vector N t) and N is a positive
1458 multiple of 8 -- the last 8 bits were mistakenly cleared.
1459
d06714cb
PE
1460 Remove some struct layout assumptions in bool vectors.
1461 * alloc.c (bool_header_size): New constant.
1462 (header_size, word_size): Move earlier, as they're now used earlier.
1463 Use 'word_size' in a few more places, where it's appropriate.
1464 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1465 padding before the data member of a bool vector.
1466 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1467 than doing the check by hand with an abort ().
1468
464d5a5e
SM
14692012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1470
5fbc0409
SM
1471 * eval.c (Fdefvar): Don't check constants since we only set the var if
1472 it's not yet defined anyway (bug#11904).
1473
464d5a5e
SM
1474 * lisp.h (last_undo_boundary): Declare new var.
1475 * keyboard.c (command_loop_1): Set it.
1476 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1477 were auto-added by the command loop (bug#11774).
1478
8dc2e44a
AS
14792012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * w32font.c (Qsymbol): Remove local definition.
1482 (syms_of_w32font): Don't DEFSYM it.
1483
169925ec
DA
14842012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1485
1486 Fix sweep_vectors to handle large bool vectors correctly.
1487 * alloc.c (sweep_vectors): Account total_vector_bytes for
1488 bool vectors larger than VBLOCK_BYTES_MAX.
1489
5fbfb018
CY
14902012-07-18 Chong Yidong <cyd@gnu.org>
1491
1492 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1493 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1494
3ab6e069
DA
14952012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1496
1497 Return more descriptive data from Fgarbage_collect.
1498 Suggested by Stefan Monnier in
1499 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1500 * alloc.c (bounded_number): New function.
1501 (total_buffers, total_vectors): New variable.
1502 (total_string_size): Rename to total_string_bytes, adjust users.
1503 (total_vector_size): Rename to total_vector_bytes, adjust users.
1504 (sweep_vectors): Account total_vectors and total_vector_bytes.
1505 (Fgarbage_collect): New return value. Adjust documentation.
1506 (gc_sweep): Account total_buffers.
1507 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1508 (VECTOR_SIZE): Remove.
1509 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1510 (Qinterval, Qmisc): New symbols.
1511 (syms_of_data): Initialize them.
1512 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1513 (Qcons, Qbuffer): New declarations.
1514
6d02fe5b
PE
15152012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1516
1517 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1518 Round up, not down. Improve doc.
1519
b7ffe040
DA
15202012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1521
1522 Restore old code in allocate_string_data to avoid Faset breakage.
1523 Reported by Julien Danjou <julien@danjou.info> in
1524 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1525 * alloc.c (allocate_string_data): Restore old code with minor
1526 adjustments, fix comment to explain this subtle issue.
1527
4dc7c8d5
SM
15282012-07-17 Eli Zaretskii <eliz@gnu.org>
1529
1530 Remove FILE_SYSTEM_CASE.
1531 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1532
1533 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1534 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1535 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1536 call-process-region passes it through expand-file-name.
1537
1538 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1539
15402012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1541
1542 Fix crash when creating indirect buffer (Bug#11917)
1543 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1544 Don't handle unbound variables specially if non-zero.
1545 (Fbuffer_local_variables): Pass zero.
1546 (clone_per_buffer_values): Pass non-zero.
1547
15482012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1549
1550 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1551 to make the loop interruptible.
1552
15532012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1554
1555 * gnutls.c (emacs_gnutls_handshake): Only retry if
1556 GNUTLS_E_INTERRUPTED.
1557
cce7fefc
DA
15582012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1559
1560 Cleanup and convert miscellaneous checks to eassert.
1561 * alloc.c (mark_interval): Fix comment, partially rephrase
1562 old comment from intervals.h (see below).
1563 * intervals.c (find_interval, adjust_intervals_for_insertion)
1564 (delete_interval, adjust_intervals_for_deletion)
1565 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1566 Convert to eassert.
1567 (adjust_intervals_for_insertion, make_new_interval):
1568 Remove obsolete and unused code.
1569 * intervals.h (struct interval): Remove obsolete comment.
1570 * textprotp.c (erase_properties): Remove unused code.
1571 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1572 (Fremove_list_of_text_properties): Convert to eassert.
1573
9ea10cc3
CY
15742012-07-17 Chong Yidong <cyd@gnu.org>
1575
1576 * editfns.c (Finsert_char): Doc fix.
1577
3900d5de
DA
15782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 Fix previous change to make Fmemory_free always accurate.
1581 * alloc.c (make_interval): Update total_free_intervals.
1582 (make_float): Likewise for total_free_floats.
1583 (free_cons, Fcons): Likewise for total_free_conses.
1584 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1585 Likewise for total_free_vector_bytes.
1586 (Fmake_symbol): Likewise for total_free_symbols.
1587 (bytes_free): Remove.
1588
7098646f
DA
15892012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 Simple free memory accounting feature.
1592 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1593 (sweep_vectors): Accumulate size of free vectors.
1594 (Fgarbage_collect): Setup bytes_free.
1595 (Fmemory_free): New function.
1596 (syms_of_alloc): Register it.
1597
22657b40
DA
15982012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1599
1600 Cleanup overlays checking.
1601 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1602 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1603 eassert and OVERLAYP.
1604 (sort_overlays): Change to use OVERLAYP.
1605
ddfc8813
RK
16062012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1607
1608 * editfns.c (Finsert_char): Make it interactive, and make the
1609 second arg optional. Copy interactive spec and docstring from
1610 ucs-insert.
1611
7c26cf3c
PE
16122012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1613
1614 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1615 Unlike the other wrapped functions, fabs has an unspecified
1616 effect on errno.
1617
5d127af9
JD
16182012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1619
1620 * nsterm.m (keyDown): Interpret flags without left/right bits
1621 as the left key (Bug#11670).
1622
6a0dd1d7
DA
16232012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1624
1625 Remove empty and useless init functions.
1626 * lisp.h (init_character_once, init_fns, init_image)
1627 (init_filelock, init_sound): Remove prototype.
1628 * character.c (init_character_once): Remove.
1629 * filelock.c (init_filelock): Likewise.
1630 * fns.c (init_fns): Likewise.
1631 * image.c (init_image): Likewise.
1632 * sound.c (init_sound): Likewise.
1633 * emacs.c (main): Adjust accordingly.
1634
7a6136fd
DA
16352012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1636
1637 * gtkutil.h: Tiny cleanups.
1638 (use_old_gtk_file_dialog): Remove useless declaration.
1639 (xg_uses_old_file_dialog): Add suggested const attribute.
1640
ce811ad9
EZ
16412012-07-15 Eli Zaretskii <eliz@gnu.org>
1642
1643 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1644 (bidi_paragraph_init): Use it to limit search forward for a strong
1645 directional character in abnormally large paragraphs full of
1646 neutral or weak characters. (Bug#11943)
1647
c9adfeaa
SF
16482012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1649
1650 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1651 the toolbar (Bug#9451).
1652 (xg_make_tool_item): Give the widget event box a transparent
1653 background.
1654
fff62aa9
DA
16552012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1656
1657 Cleanup basic allocation variables and functions.
1658 * alloc.c (ignore_warnings, init_intervals, init_float)
1659 (init_cons, init_symbol, init_marker): Remove.
1660 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1661 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1662 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1663 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1664 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1665 (staticidx, init_alloc_once, init_strings, free_ablock):
1666 Remove redundant initialization.
1667 * fns.c (init_weak_hash_tables): Remove.
1668 * lisp.h (init_weak_hash_tables): Remove prototype.
1669
9730daca
DA
16702012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1671
1672 Use zero_vector where appropriate.
1673 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1674 accordingly.
1675 * lisp.h (zero_vector): New declaration.
1676 * font.c (null_vector): Remove.
1677 (syms_of_font): Remove initialization and staticpro.
1678 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1679 * keymap.c (Faccessible_keymaps): Likewise.
1680
2e2d2a13
LL
16812012-07-15 Leo Liu <sdl.web@gmail.com>
1682
1683 * fringe.c: Fix typo in comments.
1684
cd276f6e
LL
16852012-07-14 Leo Liu <sdl.web@gmail.com>
1686
1687 * fringe.c: Add a new bitmap exclamation-mark.
1688
5a1131d9
EZ
16892012-07-14 Eli Zaretskii <eliz@gnu.org>
1690
1691 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1692
1693 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1694 (HAVE_MENUS): Don't define, defined by editing config.in with
1695 msdos/sed2v2.inp.
1696 (GMALLOC_INHIBIT_VALLOC): Don't define.
1697 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1698
22e983b7
JB
16992012-07-14 Juanma Barranquero <lekktu@gmail.com>
1700
1701 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1702
5b3f250f
GM
17032012-07-14 Glenn Morris <rgm@gnu.org>
1704
1705 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1706 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1707 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1708
33d63ff4
GM
17092012-07-13 Glenn Morris <rgm@gnu.org>
1710
5b633342
GM
1711 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1712
33d63ff4
GM
1713 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1714 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1715
b55b9f85
JD
17162012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1717
0dc8cf50
JD
1718 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1719 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1720 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1721 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1722 where appropriate.
1723 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1724 as boolean expression.
1725 (x_set_window_size): Remove unused variable toolbar.
1726 (ns_get_color_default, ns_mod_to_lisp): Remove.
1727 (ns_mouse_position): Remove unused variables xchar and ychar.
1728 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1729 (ns_set_vertical_scroll_bar): Remove unused variable count.
1730 (ns_delete_terminal): Remove unused variable i.
1731 (ns_term_init): Remove unused variables r, g and b.
1732 (mouseDown): Remove unused variable window.
1733 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1734 (initFrameFromEmacs): Remove unused variable vbextra.
1735 (mouseEntered): Remove unused variables p and dpyinfo.
1736 (mouseExited): Remove unused variables p and r.
1737 (ns_define_frame_cursor, ns_clear_frame_area)
1738 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1739 (menuDown): Assign [sender tag] to variable and cast the variable.
1740
1741 * nsterm.h (menuDown): Add id as type to argument sender.
1742 (ns_display_info_for_name): Add Lisp_Object argument.
1743 (ns_term_init): Add Lisp_Object argument.
1744 (ns_map_event_to_object): Add void argument.
1745 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1746 prototype with arguments and only declare if __OBJC__.
1747 (nxatoms_of_nsselect): Add void argument.
1748 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1749 (ns_alloc_autorelease_pool): Add void argument.
1750 (ns_release_autorelease_pool): Add void* argument.
1751 (ns_get_defaults_value): Add const char* argument.
1752
1753 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1754 (initFromContents): Use SSDATA where appropriate.
1755 (ns_update_menubar): Add braces to ambigous if-else.
1756 (initWithTitle): Put () around assignment in if statement.
1757 (ns_menu_show): Remove unused variables window and keymap.
1758 (update_frame_tool_bar): Remove unused variable selected_p.
1759 (initWithContentRect): Remove unused variable this_cmd_name.
1760
1761 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1762 appropriate.
1763 (setXBMColor): Remove unused variable len.
1764 (setPixmapData): Put () around assignment in loop statement.
1765
1766 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1767 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1768 where appropriate.
1769 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1770 around assignment in loop statement.
1771 (nsfont_open): Remove unused variable i.
1772 (nsfont_open): Remove unused variable len.
1773 (nsfont_draw): Remove unused variable cs.
1774
1775 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1776 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1777 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1778 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1779 (Fns_font_name, Fns_perform_service)
1780 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1781 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1782 (ns_set_name): Remove unused variable view.
1783 (x_set_menu_bar_lines): Remove unused variable olines.
1784 (x_set_tool_bar_lines): Remove unused variable root_window.
1785 (Fns_list_colors): Put () around assignment in while statement.
1786 (Fns_perform_service): Remove unused variable len.
1787 (Fns_display_usable_bounds): Remove unused variable top.
1788 (syms_of_nsfns): Remove unused variable i.
1789
b55b9f85
JD
1790 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1791 memcpy (Bug#11907).
1792
ed9265fc 17932012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1794
1795 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1796 and free it with DestroyExceptionInfo (Bug#11558).
1797
ef099b57
JB
17982012-07-13 Juanma Barranquero <lekktu@gmail.com>
1799
1800 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1801 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1802 Set here, not in nt/config.nt.
1803
ea814a5d
EZ
18042012-07-13 Eli Zaretskii <eliz@gnu.org>
1805
1806 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1807 cursor overflow into the last glyph on display line when the right
1808 fringe is off. (Bug#11832)
1809
1a952767
PE
18102012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * xdisp.c (produce_special_glyphs): Now static.
1813 * dispextern.h (produce_special_glyphs): Remove decl.
1814
983188fd
GM
18152012-07-13 Glenn Morris <rgm@gnu.org>
1816
8d7c7eed 1817 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1818 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1819
983188fd
GM
1820 * s/usg5-4-common.h (USG, USG5):
1821 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1822 * s/sol2-6.h (SOLARIS2):
1823 * s/irix6-5.h (IRIX6_5):
1824 * s/hpux10-20.h (USG, USG5, HPUX):
1825 * s/gnu-linux.h (USG, GNU_LINUX):
1826 * s/freebsd.h (BSD_SYSTEM):
1827 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1828 * s/cygwin.h (CYGWIN):
1829 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1830 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1831
d1e68667 18322012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1833
1834 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1835
6de0e799
GM
18362012-07-13 Glenn Morris <rgm@gnu.org>
1837
739ae010
GM
1838 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1839
dbee5793
GM
1840 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1841
6de0e799
GM
1842 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1843 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1844
b82da769
GM
18452012-07-12 Glenn Morris <rgm@gnu.org>
1846
4fae5a7a 1847 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1848
1849 * process.c (init_process_emacs): Rename from init_process.
1850 The old name is also the name of a Mach system call.
1851 * lisp.h, emacs.c: Update for this name change.
1852 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1853 longer needed.
1854
5a979817
EZ
18552012-07-12 Eli Zaretskii <eliz@gnu.org>
1856
1857 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1858 memmove call that removes glyphs covered by the left truncation
1859 glyph. Improve commentary.
1860 (display_line): Fix display of continuation glyphs on GUI frames
1861 when the right fringe is turned off and variable-size fonts are
1862 used in the window. Move the code that appends a stretch glyph to
1863 produce_special_glyphs, so that it could be used for truncation
1864 and continuation glyphs alike.
1865 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1866 glyph of a suitably computed width, to align the special glyphs at
1867 the window margin. Code moved from display_line. (Bug#11832)
1868
3e91a053
GM
18692012-07-12 Glenn Morris <rgm@gnu.org>
1870
ba9e4b84
GM
1871 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1872
1873 * s/gnu-linux.h, s/hpux10-20.h:
1874 Do not unconditionally define HAVE_XRMSETDATABASE.
1875
3e91a053
GM
1876 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1877
b300b1f4
PE
18782012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 Fix typos that broke OS X build.
1881 Reported by Randal L. Schwartz in
1882 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1883 * nsterm.m (ns_timeout): Add missing local decl.
1884 (ns_get_color): snprintf -> sprintf, to fix typo.
1885
6e777848
GM
18862012-07-12 Glenn Morris <rgm@gnu.org>
1887
3f922c37
GM
1888 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1889 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1890 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1891 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1892
0ab7b23a
GM
1893 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1894 Move PTY_OPEN to configure.
1895
6e777848
GM
1896 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1897 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1898 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1899
4a7edc24
DA
19002012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 Use empty_unibyte_string where applicable.
1903 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1904 * lread.c (read1): Likewise.
1905 * xsettings.c (syms_of_xsettings): Likewise.
1906
308aab79
GM
19072012-07-12 Glenn Morris <rgm@gnu.org>
1908
42bd1719
GM
1909 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1910 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1911 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1912 * s/hpux10-20.h (RUN_TIME_REMAP):
1913 * s/bsd-common.h (TABDLY): Move to configure.
1914
1915 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1916
1917 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1918
ea0bbd17 1919 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1920 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1921
1922 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1923
308aab79
GM
1924 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1925 * s/template.h: Move NARROWPROTO to configure.
1926
ee1cf5cf
GM
19272012-07-11 Glenn Morris <rgm@gnu.org>
1928
30fe9bf4
GM
1929 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1930 unused since 2011-01-17 change to systty.h.
1931
ee1cf5cf
GM
1932 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1933 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1934 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1935
63e47e07
PE
19362012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1937
1938 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1939
c43fb4c3
GM
19402012-07-11 Glenn Morris <rgm@gnu.org>
1941
1942 * s/darwin.h, s/gnu-linux.h, s/template.h:
1943 Move INTERRUPT_INPUT to configure.
1944
e8df9267
DA
19452012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1946
1947 Minor adjustments to interning code.
1948 * lisp.h (intern, intern_c_string): Redefine as static inline
1949 wrappers for intern_1 and intern_c_string_1, respectively.
1950 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1951 * lread.c (intern_1, intern_c_string_1, oblookup):
1952 Simplify Vobarray checking.
e8df9267
DA
1953 * font.c (font_intern_prop): Likewise. Adjust comment.
1954 * w32font.c (intern_font_name): Likewise.
1955
34348bd4
AS
19562012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1957
d96a1e0c
AS
1958 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1959
34348bd4
AS
1960 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1961 of Fcar/Fcdr if possible.
1962 * font.c (check_otf_features): Likewise.
1963 * fontset.c (Fnew_fontset): Likewise.
1964 * gnutls.c (Fgnutls_boot): Likewise.
1965 * minibuf.c (read_minibuf): Likewise.
1966 * msdos.c (IT_set_frame_parameters): Likewise.
1967 * xmenu.c (Fx_popup_dialog): Likewise.
1968 * w32menu.c (Fx_popup_dialog): Likewise.
1969
c8add24e
GM
19702012-07-11 Glenn Morris <rgm@gnu.org>
1971
4b575b3c
GM
1972 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1973 since nothing has defined it on these platforms.
1974
09f4e3b0
GM
1975 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1976 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1977
172bedef
GM
1978 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1979 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1980 Move CLASH_DETECTION to configure.
1981
249685df
GM
1982 * s/gnu.h: Remove file, which is now empty.
1983
c8add24e
GM
1984 * s/gnu.h, s/gnu-linux.h:
1985 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1986
b41253a3
JW
19872012-07-11 John Wiegley <johnw@newartisans.com>
1988
1989 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1990 function attribute, so we only use it if it exists in the
1991 compiler.
1992
d923b542
DA
19932012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1994
1995 Avoid call to strlen in fast_c_string_match_ignore_case.
1996 * search.c (fast_c_string_match_ignore_case): Change to use
1997 length argument. Adjust users accordingly.
1998 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1999
5ebbef1d
PE
20002012-07-11 Paul Eggert <eggert@cs.ucla.edu>
2001
bb352260
PE
2002 Assume mkdir, rmdir.
2003 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
2004 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
2005
57054ddd
PE
2006 Assume rename.
2007 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
2008
b747d3f7
PE
2009 Assume perror.
2010 * s/hpux10-20.h (HAVE_PERROR): Remove.
2011 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
2012 Remove dummy definition, as this problem was obsolete long ago.
2013
5ebbef1d
PE
2014 Assume strerror.
2015 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
2016
984e7f30
DA
20172012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
2018
2019 Avoid calls to strlen in font processing functions.
2020 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
2021 (font_open_by_name): Change to use length argument.
2022 Adjust users accordingly.
d923b542
DA
2023 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
2024 Adjust prototypes.
2025 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
2026 Change to return ptrdiff_t.
984e7f30
DA
2027 (xfont_list_pattern, xfont_match): Use length returned by
2028 xfont_decode_coding_xlfd.
2029 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
2030
20e94fdd
GM
20312012-07-11 Glenn Morris <rgm@gnu.org>
2032
9d596af3
GM
2033 * s/darwin.h, s/freebsd.h, s/netbsd.h:
2034 Move DONT_REOPEN_PTY to configure.
2035
20e94fdd
GM
2036 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
2037 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
2038
e99a530f
PE
20392012-07-10 Paul Eggert <eggert@cs.ucla.edu>
2040
22ffb973
PE
2041 Remove "#define unix" that is no longer needed (Bug#11905).
2042 * s/aix4-2.h (unix): Remove; no longer needed.
2043
e9a9ae03
PE
2044 EMACS_TIME simplification (Bug#11875).
2045 This replaces macros (which typically do not work in GDB)
2046 with functions, typedefs and enums, making the code easier to debug.
2047 The functional style also makes code easier to read and maintain.
2048 * systime.h: Include <sys/time.h> on all hosts, not just if
2049 WINDOWSNT, since 'struct timeval' is needed in general.
2050 (EMACS_TIME): Now a typedef, not a macro.
2051 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
2052 not macros.
2053 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
2054 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
2055 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
2056 (EMACS_TIME_LE): Now functions, not macros.
2057 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
2058 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
2059 which are not functions. All uses rewritten to use:
2060 (make_emacs_time): New function.
2061 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
2062 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
2063 not functions. All uses rewritten to use the following, respectively:
2064 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
2065 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 2066 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
2067 * fileio.c (Fcopy_file):
2068 * xterm.c (XTflash): Get the current time closer to when it's used.
2069 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
2070
ffacb126
PE
2071 * bytecode.c (targets): Suppress -Woverride-init warnings.
2072
e99a530f
PE
2073 Simplify by avoiding confusing use of strncpy etc.
2074 * doc.c (Fsnarf_documentation):
2075 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
2076 * frame.c (Fmake_terminal_frame):
2077 * gtkutil.c (get_utf8_string):
2078 * lread.c (openp):
2079 * nsmenu.m (ns_update_menubar):
2080 * regex.c (regerror):
2081 Prefer memcpy to strncpy and strncat when either will do.
2082 * fileio.c (Fsubstitute_in_file_name):
2083 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
2084 (menu_separator_name_p):
2085 * nsmenu.m (ns_update_menubar):
2086 Prefer memcmp to strncmp when either will do.
2087 * nsterm.m: Include <ftoastr.h>.
2088 (ns_get_color):
2089 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
2090 Prefer snprintf to strncpy.
2091 * nsterm.m (ns_term_init):
2092 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
2093 * nsterm.m (ns_term_init):
2094 Avoid the need for strncpy, by using build_string or
2095 make_unibyte_string directly. Use dtoastr, not snprintf.
2096 * process.c (Fmake_network_process): Diagnose service names that
2097 are too long, rather than silently truncating them or creating
2098 non-null-terminated names.
2099 (Fnetwork_interface_info): Likewise, for interface names.
2100 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2101 Prefer sprintf to strncat.
2102 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2103 Prefer vsnprintf to vsprintf + strncpy.
2104
c59592b3
GM
21052012-07-10 Glenn Morris <rgm@gnu.org>
2106
2107 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2108 Clarify fallback case.
2109
7d7bbefd
DA
21102012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2113 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2114 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2115 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2116 where argument type is known to be a Lisp_Cons.
2117
3a4c8000
TT
21182012-07-10 Tom Tromey <tromey@redhat.com>
2119
2120 * bytecode.c (BYTE_CODE_THREADED): New macro.
2121 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2122 (enum byte_code_op): New type.
2123 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2124 (exec_byte_code): Use them. Use token threading when applicable.
2125
2a0213a6
DA
21262012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2127
2128 Optimize pure C strings initialization.
2129 * lisp.h (make_pure_string): Fix prototype.
2130 (build_pure_c_string): New function, defined as static inline. This
2131 provides a better opportunity to optimize away calls to strlen when
2132 the function is called with compile-time constant argument.
2133 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2134 argument, adjust users accordingly. Use build_pure_c_string where
2135 appropriate.
2136 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2137 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2138 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2139
cb1caeaf
DA
21402012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2141
2142 Avoid calls to strlen in miscellaneous functions.
2143 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2144 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2145 * lread.c (openp): Likewise.
2146
c293e30c
DA
21472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2148
2149 Avoid calls to strlen in path processing functions.
2150 * fileio.c (file_name_as_directory): Add comment. Change to add
2151 srclen argument and return the length of result. Adjust users
2152 accordingly.
2153 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2154 swap 1st and 2nd arguments to obey the common convention.
2155 Adjust users accordingly.
c293e30c
DA
2156 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2157
9e059e3f
GM
21582012-07-10 Glenn Morris <rgm@gnu.org>
2159
d02eb359
GM
2160 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2161 Move PENDING_OUTPUT_COUNT definition to configure.
2162
882cf227
GM
2163 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2164 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2165 * s/gnu.h (DATA_START): Move definitions to configure.
2166
af6e839f
GM
2167 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2168 We include usg5-4-common.h, which defines them both.
2169
40289a12
GM
2170 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2171 O_RDONLY already includes it).
2172
9e059e3f
GM
2173 Stop ns builds setting the EMACSLOADPATH environment variable.
2174 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2175 Now it does not set EMACSLOADPATH, just returns the load-path string.
2176 * nsterm.h: Update accordingly.
2177 * lread.c [HAVE_NS]: Include nsterm.h.
2178 (init_lread) [HAVE_NS]: Use ns_load_path.
2179 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2180
7c4e8ec0
GM
21812012-07-09 Glenn Morris <rgm@gnu.org>
2182
d4f600ff
GM
2183 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2184 since the included bsd-common.h does so.
2185
cbb31951
GM
2186 Stop ns builds setting the EMACSPATH environment variable.
2187 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2188 (ns_init_paths): Do not set EMACSPATH.
2189 * nsterm.h (ns_exec_path): Add it.
2190 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2191 Use ns_exec_path.
2192
7c4e8ec0
GM
2193 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2194
26bccfae
PE
21952012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2196
a0bee46f
PE
2197 * process.c (wait_reading_process_output): 'waitchannels' was unset
2198 when read_kbd || !NILP (wait_for_cell); fix this.
2199
5994c183
PE
2200 Add GCC-style 'const' attribute to functions that can use it.
2201 * character.h (char_resolve_modifier_mask):
2202 * keyboard.h (make_ctrl_char):
2203 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2204 (init_character_once, next_almost_prime, init_fns, init_image)
2205 (flush_pending_output, init_sound):
2206 * mem-limits.h (start_of_data):
2207 * menu.h (finish_menu_items):
2208 Add ATTRIBUTE_CONST.
2209 * emacs.c (DEFINE_DUMMY_FUNCTION):
2210 Declare the dummy function with ATTRIBUTE_CONST.
2211 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2212 Add decls with ATTRIBUTE_CONST.
2213
26bccfae
PE
2214 Minor improvements to make_formatted_string.
2215 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2216 where int is good enough, as vsprintf returns an int.
2217 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2218
a8290ec3
DA
22192012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2220
2221 Use make_formatted_string to avoid double length calculation.
2222 * lisp.h (make_formatted_string): New prototype.
2223 * alloc.c (make_formatted_string): New function.
2224 * buffer.c (Fgenerate_new_buffer_name): Use it.
2225 * dbus.c (syms_of_dbusbind): Likewise.
2226 * editfns.c (Fcurrent_time_zone): Likewise.
2227 * filelock.c (get_boot_time): Likewise.
2228 * frame.c (make_terminal_frame, set_term_frame_name)
2229 (x_report_frame_params): Likewise.
2230 * image.c (gs_load): Likewise.
2231 * minibuf.c (get_minibuffer): Likewise.
2232 * msdos.c (dos_set_window_size): Likewise.
2233 * process.c (make_process): Likewise.
2234 * xdisp.c (ensure_echo_area_buffers): Likewise.
2235 * xsettings.c (apply_xft_settings): Likewise.
2236
d01ba2f1
GM
22372012-07-09 Glenn Morris <rgm@gnu.org>
2238
2239 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2240 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2241 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2242 * nsterm.h (ns_etc_directory): Add it.
2243 * callproc.c [HAVE_NS]: Include nsterm.h.
2244 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2245
f1f924b6
DA
22462012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2247
2248 Move marker debugging code under MARKER_DEBUG.
2249 * marker.c (MARKER_DEBUG): Move marker debugging code under
2250 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2251 for bootstrap with --enable-checking (~3x slowdown reported
2252 by Juanma Barranquero <lekktu@gmail.com>).
2253 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2254
ab531b66
PE
22552012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2256
2257 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2258 See <http://bugs.gnu.org/11825#29>.
2259
c4b3bc8a
EZ
22602012-07-08 Eli Zaretskii <eliz@gnu.org>
2261
2262 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2263 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2264 (display_line): Add commentary about displaying truncation glyphs
2265 on GUI frames.
2266 (produce_special_glyphs): Move here from term.c.
2267
2268 * term.c (produce_special_glyphs): Move to xdisp.c.
2269
2270 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2271 section.
c4b3bc8a 2272
b676b881
AS
22732012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2274
f17c5273
AS
2275 * xdisp.c (display_line): Avoid warning about implicit declaration
2276 of FRAME_FONT.
2277
298819b9
AS
2278 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2279
b676b881
AS
2280 * lisp.h: Remove empty conditional.
2281
6045c4fd
PE
22822012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2283
b3350bf9
PE
2284 * lread.c (load_path_check): Now static.
2285
6045c4fd
PE
2286 Fix some minor --with-ns problems found by static checking.
2287 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2288 (x_set_font) [!HAVE_X_WINDOWS]:
2289 * image.c (xpm_load_image) [HAVE_NS]:
2290 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2291 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2292 Remove unused local.
2293 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2294 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2295 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2296 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2297 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2298 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2299 Fix pointer signedness problem.
2300 * xfaces.c (FRAME_X_FONT_TABLE):
2301 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2302
929e7845
GM
23032012-07-07 Glenn Morris <rgm@gnu.org>
2304
2305 * lread.c (load_path_check): New function, split from init_lread.
2306 (init_lread): Reorganize. Motivation:
2307 If EMACSLOADPATH is set, check/warn about that rather than the
2308 defaults, which we are not going to use. Hence we can remove
2309 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2310 Don't warn if site-lisp directories are missing.
2311 If not installed, start from a blank load-path, since
2312 PATH_LOADSEARCH refers to the eventual installation directories.
2313
58dd0aa4
EZ
23142012-07-07 Eli Zaretskii <eliz@gnu.org>
2315
2316 Support truncation and continuation glyphs on GUI frames, when
2317 fringes are disabled. (Bug#11832)
2318 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2319 continuation glyphs even if on GUI frames.
2320 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2321 or both, are absent.
2322 (start_display, move_it_in_display_line_to): Handle the case of a
2323 GUI frame without a fringe to display continuation or truncation
2324 glyphs.
2325 (insert_left_trunc_glyphs): Support GUI frames: make sure
2326 truncation glyphs overwrite enough glyphs from the current line to
2327 have sufficient space in pixels.
2328 (display_line): Support truncation and continuation glyphs on GUI
2329 frames. If some spare pixels are left on the line after inserting
2330 the truncation glyphs, fill that space with a stretch glyph of a
2331 suitably computed width.
2332
2333 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2334 produce_glyphs, to support GUI sessions.
2335
31571fd7
PE
23362012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2337
5a16b9bc
PE
2338 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2339
f3047c75
PE
2340 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2341
31571fd7
PE
2342 Do not require float-time's arg to fit in time_t (Bug#11825).
2343 This works better on hosts where time_t is unsigned, and where
2344 float-time is applied to the (negative) difference between two times.
2345 * editfns.c (decode_time_components): Last arg is now double *,
2346 not int *, and means to store all the result as a double, without
2347 worrying about whether the seconds part fits in time_t.
2348 All callers changed.
2349 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2350 All callers changed.
2351 (Ffloat_time): Do not fail merely because the specified time falls
2352 outside of time_t range.
2353
4516fbef
GM
23542012-07-07 Glenn Morris <rgm@gnu.org>
2355
2356 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2357 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2358 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2359
07adc2c6
JB
23602012-07-07 Juanma Barranquero <lekktu@gmail.com>
2361
2362 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2363 Update dependencies.
2364
2365 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2366
fd573f31
PE
23672012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2368
fee5959d
PE
2369 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2370 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2371 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2372 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2373 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2374 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2375
fd573f31
PE
2376 * xfont.c (compare_font_names): Redo to omit the need for casts.
2377
ddadbc0e
AS
23782012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2379
fca8d6b6
AS
2380 * xfns.c (Fx_change_window_property): Doc fix.
2381 * w32fns.c (Fx_change_window_property): Doc fix.
2382
ddadbc0e
AS
2383 * w32fns.c (Fx_window_property): Accept the same arguments as the
2384 X Windows version. Doc fix.
2385 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2386
ed9265fc 23872012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2388 Eli Zaretskii <eliz@gnu.org>
2389
2390 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2391 Windows-specific code from nt/config.nt moved here.
2392 Obsolete settings removed.
2393
216ee680
PE
23942012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2395
2396 * process.c: Avoid unnecessary calls to gettime.
2397 (wait_reading_process_output): Don't get the time of day
2398 when gobbling data immediately and not waiting, as there's no need
2399 for it in that case. This removes a FIXME.
2400
bdd091e4
JD
24012012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2402
2403 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2404 is defined (Bug#11768).
2405
9d44f8ce
DA
24062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2407
2408 Fix marker debugging code.
2409 * marker.c (byte_char_debug_check): Do not perform the check
2410 if buffer is not multibyte.
090bd7cb
JB
2411 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2412 Call byte_char_debug_check with correct arguments.
9d44f8ce 2413
90fc4786
DA
24142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2415
2416 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2417 * marker.c (byte_char_debug_check, count_markers):
2418 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2419 (byte_debug_flag): Remove.
2420 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2421 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2422
7b7ae965
DA
24232012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2424
4e57b342
DA
2425 Avoid code repetition in marker-related functions.
2426 * marker.c (attach_marker): New function.
2427 (Fset_marker, set_marker_restricted, set_marker_both)
2428 (set_marker_restricted_both): Use it.
2429 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2430 Consistently rename charno to charpos.
2431 (marker_position): Add eassert.
2432 (marker_byte_position): Convert to eassert.
2433
24342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2435
2436 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2437 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2438 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2439
657924ff
DA
24402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2441
2442 Introduce fast path for the widely used marker operation.
2443 * alloc.c (build_marker): New function.
2444 * lisp.h (build_marker): New prototype.
2445 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2446 * composite.c (autocmp_chars): Likewise.
2447 * editfns.c (buildmark): Remove.
2448 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2449 (save_restriction_save): Use build_marker.
2450 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2451 * window.c (save_window_save): Likewise.
2452
041a49a6
DA
24532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2454
2455 Do not use Fdelete_overlay in delete_all_overlays
2456 to avoid redundant calls to unchain_overlay.
2457 * buffer.c (drop_overlay): New function.
2458 (delete_all_overlays, Fdelete_overlay): Use it.
2459 * minibuf.c (get_minibuffer): Fix comment.
2460
7dca65a4
PE
24612012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2462
2463 Port to OpenBSD 5.1 amd64.
2464 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2465 This is needed for OpenBSD, and should be harmless on all BSD systems.
2466 Also, include <sys/sysctl.h>, as it should be available on all
2467 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2468 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2469 use p_pid member, not kp_proc.pid.
2470
8eb876e2
GM
24712012-07-06 Glenn Morris <rgm@gnu.org>
2472
2473 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2474
38182d90
PE
24752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2476
2477 More xmalloc and related cleanup.
2478 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2479 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2480 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2481 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2482 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2483 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2484 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2485 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2486 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2487 * xterm.c:
2488 Omit needless casts involving void * pointers and allocation.
2489 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2490 as the former is more robust if P's type is changed.
2491 Prefer xzalloc to xmalloc + memset 0.
2492 Simplify malloc-or-realloc to realloc.
2493 Don't worry about xmalloc returning a null pointer.
2494 Prefer xstrdup to xmalloc + strcpy.
2495 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2496 growing it.
2497 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2498 alloca of a constant.
2499
6dd5a677
EZ
25002012-07-05 Eli Zaretskii <eliz@gnu.org>
2501
2502 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2503 hscroll is larger than the line width. Fixes long and futile
2504 looping inside extend_face_to_end_of_line (on a TTY) producing
2505 glyphs that are not needed and thrown away.
2506
6b312f0f
DA
25072012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2508
2509 * marker.c (set_marker_restricted_both): Simplify by using
2510 clip_to_bounds.
2511
f520ef9b
PE
25122012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2515
383b7c95
JD
25162012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2519 not defined (Bug#11768).
2520 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2521 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2522 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2523 followed by gtk_box_set_homogeneous (Bug#11768).
2524 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2525 (update_theme_scrollbar_width, xg_create_scroll_bar):
2526 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2527 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2528 (is_box_type): New function (Bug#11768).
2529 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2530 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2531 with default display (Bug#11768).
2532
d6e7bf45
EZ
25332012-07-05 Eli Zaretskii <eliz@gnu.org>
2534
2535 * xdisp.c (window_hscroll_limited): New function.
2536 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2537 coordinates when window's hscroll is set to insanely large
2538 values. (Bug#11857)
2539
431391ec
JB
25402012-07-05 Juanma Barranquero <lekktu@gmail.com>
2541
2542 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2543 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2544
23f86fce
DA
25452012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2546
2547 Cleanup xmalloc.
2548 * lisp.h (xzalloc): New prototype. Omit needless casts.
2549 * alloc.c (xzalloc): New function. Omit needless casts.
2550 * charset.c: Omit needless casts. Convert all calls to
2551 xmalloc with following memset to xzalloc.
2552 * dispnew.c: Likewise.
2553 * fringe.c: Likewise.
2554 * image.c: Likewise.
2555 * sound.c: Likewise.
2556 * term.c: Likewise.
2557 * w32fns.c: Likewise.
2558 * w32font.c: Likewise.
2559 * w32term.c: Likewise.
2560 * xfaces.c: Likewise.
2561 * xfns.c: Likewise.
2562 * xterm.c: Likewise.
2563 * atimer.c: Omit needless casts.
2564 * buffer.c: Likewise.
2565 * callproc.c: Likewise.
2566 * ccl.c: Likewise.
2567 * coding.c: Likewise.
2568 * composite.c: Likewise.
2569 * doc.c: Likewise.
2570 * doprnt.c: Likewise.
2571 * editfns.c: Likewise.
2572 * emacs.c: Likewise.
2573 * eval.c: Likewise.
2574 * filelock.c: Likewise.
2575 * fns.c: Likewise.
2576 * gtkutil.c: Likewise.
2577 * keyboard.c: Likewise.
2578 * lisp.h: Likewise.
2579 * lread.c: Likewise.
2580 * minibuf.c: Likewise.
2581 * msdos.c: Likewise.
2582 * print.c: Likewise.
2583 * process.c: Likewise.
2584 * region-cache.c: Likewise.
2585 * search.c: Likewise.
2586 * sysdep.c: Likewise.
2587 * termcap.c: Likewise.
2588 * terminal.c: Likewise.
2589 * tparam.c: Likewise.
2590 * w16select.c: Likewise.
2591 * w32.c: Likewise.
2592 * w32reg.c: Likewise.
2593 * w32select.c: Likewise.
2594 * w32uniscribe.c: Likewise.
2595 * widget.c: Likewise.
2596 * xdisp.c: Likewise.
2597 * xmenu.c: Likewise.
2598 * xrdb.c: Likewise.
2599 * xselect.c: Likewise.
2600
0497dc44
PE
26012012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * fileio.c (time_error_value): Check the right error number.
2604 Problem reported by Troels Nielsen in
2605 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2606
356e7178
PE
26072012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2608
4e71fd89
PE
2609 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2610 This should be fixed in a better way; see Eli Zaretskii in
2611 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2612 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2613
f0941253
PE
2614 * fileio.c (time_error_value): Rename from special_mtime.
2615 The old name's problems were noted by Eli Zaretskii in
2616 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2617
065c9eb4
PE
2618 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2619 This variable's comment says Emacs needs at least one GDB-visible
2620 symbol of type enum pvec_type, to work around GDB problems.
2621 The symbol's value doesn't matter.
2622
356e7178
PE
2623 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2624 that causes compilation to fail on pre-C99 compilers.
2625
ed9265fc 26262012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2627
2628 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2629 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2630
3884d954
DA
26312012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2632
d209e2fb 2633 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2634 headers for buffer_defaults and buffer_local_symbols.
2635 Reported by Juanma Barranquero <lekktu@gmail.com>.
2636
ee28be33
SM
26372012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2638
2639 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2640 * lisp.h (enum pvec_type): Use fewer bits.
2641 (PSEUDOVECTOR_SIZE_BITS): New constant.
2642 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2643 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2644 change in pvec_type.
2645 (PSEUDOVECTOR_TYPEP): New macro.
2646 (TYPED_PSEUDOVECTORP): Use it.
2647 * fns.c (internal_equal): Adapt code to extract pvectype.
2648 * emacs.c (gdb_pvec_type): Update type.
2649 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2650 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2651 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2652 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2653 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2654 abusing vector->header.next.nbytes.
2655 (live_vector_p): Use PVEC_TYPE.
2656 (mark_object): Adapt code to extract pvectype. Use switch.
2657
c7f2cd7f
PE
26582012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2659
2660 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2661 Tighten new eassert a bit.
2662
8ce70ed2
DA
26632012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2664
2665 Fix compilation with --enable-gcc-warnings and -O1
2666 optimization level.
2667 * doprnt.c (doprnt): Change type of tem to int, initialize
2668 to avoid compiler warning. Add eassert.
2669 * search.c (simple_search): Initialize match_byte to avoid
2670 compiler warning. Add eassert.
2671
dea7f1e5
PE
26722012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2673
24a212eb
PE
2674 Avoid weird behavior with large horizontal scrolls.
2675 Without this change, for example, large hscroll values would
2676 mess up Emacs's display on Fedora 15 x86, presumably due to
2677 overflows in int calculations in the display code.
2678 Also, if buffers had long lines, Emacs would freeze.
2679 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2680 (set_window_hscroll): New function, containing the old guts of
2681 Fset_window_hscroll. Return the clipped value.
2682 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2683 This avoids the need to check against PTRDIFF_MAX.
2684
dea7f1e5
PE
2685 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2686
76046526
DA
26872012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2688
2689 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2690
39adff0d
PE
26912012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2692
63807d47
PE
2693 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2694 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2695 since GCC 4.4.6 issues a bogus warning for them.
2696
39adff0d
PE
2697 Fix bugs in file timestamp newness comparisons.
2698 * fileio.c (Ffile_newer_than_file_p):
2699 * lread.c (Fload): Use full timestamp resolution of files,
2700 not just the 1-second resolution, so that files that are only
2701 slightly newer still count as newer.
2702 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2703 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2704
dbeed9a6
PE
27052012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2706
2707 * fileio.c: Improve handling of file time marker. (Bug#11852)
2708 (special_mtime): New function.
2709 (Finsert_file_contents, Fverify_visited_file_modtime):
2710 Use it to set special mtime values consistently.
2711
636334d6
AS
27122012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2713
2714 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2715 marker for non-existing file. (Bug#11852)
2716
e2017fe2
GM
27172012-07-03 Glenn Morris <rgm@gnu.org>
2718
2719 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2720 and did not make it into globals.h).
2721
404dbd37
TT
27222012-07-03 Tom Tromey <tromey@redhat.com>
2723
2724 * window.c (Fset_window_margins, Fset_window_fringes)
2725 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2726 * textprop.c (Fprevious_property_change): No longer static.
2727 * syntax.c (Fsyntax_table_p): No longer static.
2728 * process.c (Fget_process, Fprocess_datagram_address): No longer
2729 static.
2730 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2731 * keyboard.c (Fcommand_execute): No longer static.
2732 Remove EXFUN.
2733 * insdel.c (Fcombine_after_change_execute): No longer static.
2734 * image.c (Finit_image_library): No longer static.
2735 * fileio.c (Fmake_symbolic_link): No longer static.
2736 * eval.c (Ffetch_bytecode): No longer static.
2737 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2738 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2739 No longer static.
404dbd37
TT
2740 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2741 static.
2742 * dired.c (Ffile_attributes): No longer static.
2743 * composite.c (Fcomposition_get_gstring): No longer static.
2744 * callproc.c (Fgetenv_internal): No longer static.
2745
2746 * ccl.h: Remove EXFUNs.
2747 * buffer.h: Remove EXFUNs.
2748 * dispextern.h: Remove EXFUNs.
2749 * intervals.h: Remove EXFUNs.
2750 * fontset.h: Remove EXFUN.
2751 * font.h: Remove EXFUNs.
2752 * dosfns.c (system_process_attributes): Remove EXFUN.
2753 * keymap.h: Remove EXFUNs.
2754 * lisp.h: Remove EXFUNs.
2755 * w32term.h: Remove EXFUNs.
2756 * window.h: Remove EXFUNs.
2757 * xsettings.h: Remove EXFUN.
2758 * xterm.h: Remove EXFUN.
2759
8e4fd1e1
GM
27602012-07-03 Glenn Morris <rgm@gnu.org>
2761
2762 * lisp.h (Frandom): Make it visible to C.
2763 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2764 buffer for invisible buffers. (Bug#1229)
2765
ca95b3eb
DA
27662012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2767
2768 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2769 values which aren't power of 2.
14ae4239
BT
2770 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2771 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2772 accordingly.
2773
7555c33f
SM
27742012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2775
2776 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2777
2778 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2779
d12e8f5a
DA
27802012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2781
2782 * alloc.c (allocate_vector_block): Remove redundant
2783 calls to mallopt if DOUG_LEA_MALLOC is defined.
2784 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2785 avoid calls to mallopt if zero_vector is returned.
2786
296094c3
DA
27872012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2788
2789 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2790 is enabled, avoid dereferencing NULL current_sblock if
2791 running undumped.
2792
36429c89
DA
27932012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2794
2795 Cleanup basic buffer management.
2796 * buffer.h (struct buffer): Change layout to use generic vector
2797 marking code. Fix some comments. Change type of 'clip_changed'
2798 to bitfield. Remove unused #ifndef old.
2799 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2800 (GET_OVERLAYS_AT): Fix indentation.
2801 (for_each_per_buffer_object_at): New macro.
2802 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2803 (Fbuffer_local_variables): Use it.
2804 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2805 * alloc.c (allocate_buffer): Adjust to match new layout of
2806 struct buffer. Fix comment.
2807 (mark_overlay): New function.
2808 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2809 Lisp area of struct buffer.
2810 (mark_object): Use it. Adjust marking of misc objects
2811 and related comments.
2812
3b3e4cac
PE
28132012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2814
2815 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2816 wrapper that is not needed because the wrapped code is a no-op (zero
2817 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2818 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2819
cf5c0175
DA
28202012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2821
2822 * alloc.c (mark_buffer): Simplify. Remove prototype.
2823 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2824 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2825 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2826 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2827
ca26824c
GM
28282012-06-30 Glenn Morris <rgm@gnu.org>
2829
2e4c5312
GM
2830 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2831
ca26824c
GM
2832 * epaths.in (PATH_SITELOADSEARCH): New.
2833 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2834 This is rather than relying on --enable-locallisppath elements
2835 having "site-lisp" in their names. (Bug#10208#25, 11658)
2836
0d23c240
EZ
28372012-06-30 Eli Zaretskii <eliz@gnu.org>
2838
c9240d7a
EZ
2839 * w32proc.c (sys_select): Accept and ignore one more argument.
2840
2841 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2842
0d23c240 2843 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2844 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2845
2846 * sysdep.c: Don't include dos.h and dosfns.h.
2847
2848 * process.c (sys_select):
2849 * msdos.c (sys_select): Accept one more argument and ignore it.
2850
2851 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2852 adapt data types and code to that.
2853
2854 * dosfns.c:
2855 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2856 which clashes with the gnulib function of the same name.
2857
af5a5a98
AS
28582012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2859
c5e4379c
AS
2860 * font.c (font_style_to_value, font_style_symbolic)
2861 (font_prop_validate_style): Add type checks for values in
2862 font_style_table.
2863
af5a5a98
AS
2864 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2865 argument.
2866 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2867 uses.
2868
8d38f461
EZ
28692012-06-29 Eli Zaretskii <eliz@gnu.org>
2870
2e5a6631
EZ
2871 * xdisp.c (try_window_id): Undo last change.
2872
8d38f461
EZ
2873 * w32.c (getwd): Adjust commentary about startup_dir.
2874 (init_environment): Always call sys_access, even in non-MSVC
2875 builds. Don't chdir to the directory of the Emacs executable.
2876 This undoes code from 1997 which was justified by the need to
2877 "avoid conflicts when removing and renaming directories". But its
2878 downside was that every relative file name was being interpreted
2879 relative to the directory of the Emacs executable, which can never
2880 be TRT. In particular, it broke sys_access when called with
2881 relative file names.
2882 (sys_access): Map GetLastError to errno.
2883
2af3565e
DA
28842012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2885
2886 * window.h (struct window): Change type of 'fringes_outside_margins'
2887 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2888 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2889 Adjust comment.
2890 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2891 to ptrdiff_t.
2892
c8d3a25c 28932012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2894
c8d3a25c
GM
2895 * gnutls.c (emacs_gnutls_handshake):
2896 Add QUIT to make the loop interruptible.
57570cd3 2897
c8d3a25c 28982012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2899
c8d3a25c
GM
2900 * charset.c (init_charset): Make lack of etc/charsets fatal.
2901
3e984ee8
DA
29022012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2903
2904 * editfns.c (region_limit): Fix type mismatch.
2905
ef884f23
DA
29062012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2907
2908 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2909 undefined. Convert from xassert to eassert.
2910 * nsmenu.m: Convert from xassert to eassert.
2911 * nsterm.m: Likewise.
2912
7d7e0027
SM
29132012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2914
2915 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2916
aa754e6a
PE
29172012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2918
2919 Avoid integer overflow on scroll-left and scroll-right.
2920 * window.c (HSCROLL_MAX): New macro.
2921 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2922 overflow when requested scroll falls outside ptrdiff_t range.
2923
80b00b08
DA
29242012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2925
2926 * window.h (struct window): Change type of 'hscroll',
2927 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2928 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2929 Adjust users accordingly.
2930 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2931 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2932 from EMACS_INT to ptrdiff_t.
2933 (make_window): Omit redundant initialization.
2934
62b2bcf6
JB
29352012-06-28 Juanma Barranquero <lekktu@gmail.com>
2936
2937 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2938
45942c7d
DA
29392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2940
2941 * window.h (struct window): Change type of 'use_time' and
2942 'sequence_number' from Lisp_Object to int.
2943 * frame.c (make_frame): Adjust users accordingly.
2944 * print.c (print_object): Likewise.
2945 * window.c (select_window, Fwindow_use_time, make_parent_window)
2946 (make_window): Likewise.
2947
e509cfa6
DA
29482012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2949
2950 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2951 enabled with --enable-checking=[all,glyphs] configure option.
2952 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2953 adjust comments accordingly.
2954 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2955 undefined, adjust comments accordingly.
2956 * image.c: Likewise.
2957 * scroll.c: Likewise.
2958 * w32fns.c: Likewise.
2959 * w32term.c: Likewise.
2960 * xdisp.c: Likewise.
2961 * xfaces.c: Likewise.
2962 * xfns.c: Likewise.
2963 * xterm.c: Likewise.
2964
a54e2c05
DA
29652012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2966
2967 Generalize run-time debugging checks.
2968 * dispextern.h (XASSERTS): Remove.
2969 * fontset.c (xassert): Remove.
2970 Convert from xassert to eassert.
2971 * alloc.c: Convert from xassert to eassert.
2972 * bidi.c: Likewise.
2973 * dispnew.c: Likewise.
2974 * fns.c: Likewise.
2975 * fringe.c: Likewise.
2976 * ftfont.c: Likewise.
2977 * gtkutil.c: Likewise.
2978 * image.c: Likewise.
2979 * keyboard.c: Likewise.
2980 * menu.c: Likewise.
2981 * process.c: Likewise.
2982 * scroll.c: Likewise.
2983 * sound.c: Likewise.
2984 * term.c: Likewise.
2985 * w32console.c: Likewise.
2986 * w32fns.c: Likewise.
2987 * w32term.c: Likewise.
2988 * window.c: Likewise.
2989 * xdisp.c: Likewise.
2990 * xfaces.c: Likewise.
2991 * xfns.c: Likewise.
2992 * xselect.c: Likewise.
2993 * xterm.c: Likewise.
2994
1ec4b7b2
SM
29952012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2996
2997 * fns.c (maybe_resize_hash_table): Output message when growing the
2998 purify-hashtable.
2999
2014308a
DA
30002012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3001
3002 * alloc.c (allocate_string_data): Remove dead code.
3003 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
3004 avoid GCC warning about unused macro.
3005
246155eb
DA
30062012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3007
3008 * alloc.c (allocate_string): Omit intervals initialization.
3009 * alloc.c (make_uninit_multibyte_string): Initialize intervals
3010 as in make_pure_string and make_pure_c_string.
3011
43184b7b
DA
30122012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3013
d209e2fb 3014 * alloc.c (allocate_string): Fix last change.
43184b7b 3015
3fe6dd74
DA
30162012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
3017
d209e2fb 3018 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
3019 to memset, add explicit initialization where appropriate.
3020
1ba6038a
GM
30212012-06-27 Glenn Morris <rgm@gnu.org>
3022
3023 * lisp.mk (lisp): Remove paths.elc.
3024
c89926a5
CY
30252012-06-27 Chong Yidong <cyd@gnu.org>
3026
3027 * doc.c (Fsubstitute_command_keys): Fix punctuation.
3028
ed6b3510
JW
30292012-06-26 John Wiegley <johnw@newartisans.com>
3030
1ec4b7b2 3031 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
3032 on Mac OS X Lion: __mod_init_func and __mod_term_func.
3033
ed6b3510
JW
3034 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
3035 when building with Clang.
3036
8edd4a2b
SM
30372012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
3038
3039 * eval.c (Fapply): Allow calling it with a single argument.
3040
f6f62d1b
EZ
30412012-06-26 Eli Zaretskii <eliz@gnu.org>
3042
3043 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
3044 _stricmp and _strnicmp.
3045 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
3046
62efea5e
DA
30472012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3048
3049 * alloc.c (allocate_window): Zero out non-Lisp part of newly
3050 allocated window.
3051 (allocate_process): Likewise for new process.
8edd4a2b 3052 (allocate_terminal): Change to use offsetof.
62efea5e
DA
3053 (allocate_frame): Likewise.
3054 * frame.c (make_frame): Omit redundant initialization.
3055 * window.c (make_parent_window): Use memset.
3056 (make_window): Omit redundant initialization.
3057 * process.c (make_process): Omit redundant initialization.
3058 * terminal.c (create_terminal): Likewise.
3059
42997f4d
DA
30602012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3061
3062 * term.c (delete_tty): Remove redundant call to memset.
3063
1130ecfc
DA
30642012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
3065
3066 * alloc.c: Remove build_string.
3067 * lisp.h: Define build_string as static inline. This provides
3068 a better opportunity to optimize away calls to strlen when the
3069 function is called with compile-time constant argument.
3070 * image.c (imagemagick_error): Convert to build_string.
3071 * w32proc.c (sys_spawnve): Likewise.
3072 * xterm.c (x_term_init): Likewise.
3073
cf38a720
PE
30742012-06-26 Paul Eggert <eggert@cs.ucla.edu>
3075
99027bdd
PE
3076 Use sprintf return value instead of invoking strlen on result.
3077 In the old days this wasn't portable, since some sprintf
3078 implementations returned char *. But they died out years ago and
3079 Emacs already assumes sprintf returns int.
3080 Similarly for float_to_string.
3081 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
3082 * ccl.c (ccl_driver):
3083 * character.c (string_escape_byte8):
3084 * data.c (Fnumber_to_string):
3085 * doprnt.c (doprnt):
3086 * print.c (print_object):
3087 * xdisp.c (message_dolog):
3088 * xfns.c (syms_of_xfns):
3089 Use sprintf or float_to_string result to avoid need to call strlen.
3090 * data.c (Fnumber_to_string):
3091 Use make_unibyte_string, since the string must be ASCII.
3092 * lisp.h, print.c (float_to_string): Now returns int length.
3093 * term.c (produce_glyphless_glyph):
3094 Use sprintf result rather than recomputing it.
3095
cf38a720
PE
3096 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
3097 * Makefile.in (ALL_CFLAGS):
3098 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
3099 * gmalloc.c, regex.c: Include <config.h> unconditionally.
3100
3511c784
DA
31012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3102
0a08eb21 3103 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3104 strcasecmp if available.
3105 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3106
fb7da12e
AS
31072012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3108
3109 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3110 Avoid comma operator.
3111 * menu.c (push_submenu_start, push_submenu_end)
3112 (push_left_right_boundary, push_menu_pane): Likewise.
3113 * msdos.c (dos_rawgetc): Likewise.
3114
afa2ffd8
DA
31152012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3116
3117 * xfns.c (xic_create_fontsetname): Remove redundant calls
3118 to memset.
3119
b3b4476b
PE
31202012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3121
4495ff38
PE
3122 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3123 sprintf already null-terminates its output.
3124
b3b4476b
PE
3125 * xfns.c (x_window): Remove redundant cast.
3126
b00876c9
DA
31272012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3128
3129 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3130 `const char *' to `char *' to avoid compiler warning.
3131
d188e26b
PE
31322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3133
885d1d74
PE
3134 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3135 instead of truncating it to 63 (admittedly a generous limit).
3136
d188e26b
PE
3137 * process.c: Fix spelling and caps in comments.
3138
e2f560b1
DN
31392012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3140
e86db54b 3141 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3142 * sysdep.c (setpgrp): Remove definition, not used in this file.
3143
7583a3a1
JB
31442012-06-24 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * makefile.w32-in: Update dependencies.
3147
696056c2
EZ
31482012-06-24 Eli Zaretskii <eliz@gnu.org>
3149
3150 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3151 (SYSTIME_H): Add nt/inc/sys/time.h.
3152
3153 * systime.h [WINDOWSNT]: Include sys/time.h.
3154
3155 * s/ms-w32.h (struct timespec): Definition moved from
3156 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3157
845ca893
PE
31582012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3161 * buffer.h (buffer_slot_type_mismatch):
3162 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3163 * eval.c (unwind_to_catch):
3164 * image.c (my_png_error, my_error_exit):
3165 * keyboard.c (quit_throw_to_read_char, user_error)
3166 (Fexit_recursive_edit, Fabort_recursive_edit):
3167 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3168 (wrong_type_argument, buffer_overflow, __executable_start)
3169 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3170 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3171 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3172 (fatal):
3173 (child_setup) [!DOS_NT]:
3174 * lread.c (end_of_file_error, invalid_syntax):
3175 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3176 * puresize.h (pure_write_error):
3177 * search.c (matcher_overflow):
3178 * sound.c (sound_perror, alsa_sound_perror):
3179 * sysdep.c, syssignal.h (croak):
3180 * term.c (maybe_fatal, vfatal):
3181 * textprop.c (text_read_only):
3182 * undo.c (user_error):
3183 * unexmacosx.c (unexec_error):
3184 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3185 Use _Noreturn rather than NO_RETURN.
3186 No need for separate decl merely because of _Noreturn.
3187 * sound.c (sound_warning, parse_sound):
3188 Remove unnecessary forward decls.
3189
f1dd8073
PE
31902012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3191
3192 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3193 * lisp.h (WAIT_READING_MAX): New macro.
3194 * dispnew.c (Fsleep_for, sit_for):
3195 * keyboard.c (kbd_buffer_get_event):
3196 * process.c (Faccept_process_output):
3197 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3198 This improves on the previous patch, which introduced a bug
3199 when time_t is unsigned and as wide as intmax_t.
3200 See <http://bugs.gnu.org/9000#51>.
3201
b82c1755
EZ
32022012-06-23 Eli Zaretskii <eliz@gnu.org>
3203
3204 * dispnew.c (sit_for, Fsleep_for):
3205 * keyboard.c (kbd_buffer_get_event):
3206 * process.c (Faccept_process_output): Avoid compiler warnings when
3207 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3208
ca300656
JB
32092012-06-23 Juanma Barranquero <lekktu@gmail.com>
3210
049ec95b
JB
3211 * makefile.w32-in: Update dependencies.
3212
ca300656
JB
3213 * w32.c (ltime): Add return type and declare static.
3214 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3215
db7b8d06
PE
32162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3219 Privately reported by Herbert J. Skuhra.
3220 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3221 All uses changed.
3222 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3223 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3224
0bd8297f
EZ
32252012-06-23 Eli Zaretskii <eliz@gnu.org>
3226
96512555
EZ
3227 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3228 last argument of make_unibyte_string.
3229
0bd8297f
EZ
3230 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3231 language ID in the event parameters.
3232
3233 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3234 event.code, not the obscure "character set ID".
3235
63def6b6
CY
32362012-06-23 Chong Yidong <cyd@gnu.org>
3237
3238 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3239
e8a02204
EZ
32402012-06-23 Eli Zaretskii <eliz@gnu.org>
3241
388cdec0
EZ
3242 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3243 * w32.c (fdutimens): New function.
3244
3245 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3246
3247 * s/ms-w32.h (pselect): Redirect to sys_select.
3248
3249 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3250
e8a02204
EZ
3251 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3252 in the logic of incrementing and decrementing the value of
3253 use_relocatable_buffers.
3254
d054f3fb
PE
32552012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3258 Privately reported by Herbert J. Skuhra.
3259 [__FreeBSD__]: Remove "*/" typo after "#include".
3260 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3261 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3262 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3263 Don't assume EMACS_TIME and struct timeval are the same type.
3264
d35af63c
PE
32652012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 Support higher-resolution time stamps (Bug#9000).
3268 The time stamps are only nanosecond-resolution at the C level,
3269 since that's the best that any real-world system supports now.
3270 But they are picosecond-resolution at the Lisp level, as that's
3271 easy, and leaves room for future OS improvements.
3272
3273 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3274 (LIBES): Use it.
3275
3276 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3277 Don't get current time unless it's needed.
3278
3279 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3280 now provides it if it's absent.
3281 (start_atimer): Port to higher-res time stamps.
3282 Check for time stamp overflow. Don't get current time more
3283 often than is needed.
3284
3285 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3286 Include systime.h, not time.h.
3287 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3288
3289 * dired.c: Include stat-time.h.
3290 (Ffile-attributes): File times now have higher resolution.
3291
3292 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3293 (struct image): Timestamp now has higher resolution.
3294
3295 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3296 has at least microseconds now. All uses removed.
3297 (update_frame, update_single_window, update_window, update_frame_1)
3298 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3299
3300 * editfns.c (time_overflow): Now extern.
3301 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3302 (float-time, Fformat_time_string, Fcurrent_time_string)
3303 (Fcurrent_time_zone): Accept and generate higher-resolution
3304 time stamps.
3305 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3306 (decode_time_components, lisp_seconds_argument): New functions.
3307 (make_time): Now static.
3308 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3309 Report an error if the time is invalid, rather than having the caller
3310 do that.
3311
3312 * fileio.c: Include <stat-time.h>
3313 (Fcopy_file): Copy higher-resolution time stamps.
3314 Prefer to set the time stamp via a file descriptor if that works.
3315 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3316 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3317 (Fvisited_file_modtime, Fset_visited_file_modtime):
3318 Support higher-resolution time stamps.
3319
3320 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3321
3322 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3323
3324 * image.c (prepare_image_for_display, clear_image_cache)
3325 (lookup_image): Port to higer-resolution time stamps.
3326
3327 * keyboard.c (start_polling, bind_polling_period):
3328 Check for time stamp overflow.
3329 (read_char, kbd_buffer_get_event, timer_start_idle)
3330 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3331 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3332 Port to higher-resolution time stamps. Do not assume time_t is signed.
3333 (decode_timer): New function. Timers are now vectors of length 9,
3334 not 8, to accommodate the picosecond component.
3335 (timer_check_2): Use it.
3336
3337 * nsterm.m (select_timeout, timeval_subtract): Remove.
3338 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3339 as they're a bit more accurate and handle overflow better.
3340 (ns_select): Change prototype to be compatible with pselect.
3341 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3342 * nsterm.h (ns_select): Adjust prototype.
3343
3344 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3345 us-resolution time stamps.
3346 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3347
3348 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3349
3350 * lisp.h (time_overflow): New decl.
3351 (wait_reading_process_output): First arg is now intmax_t, not int,
3352 to accommodate larger waits.
3353
3354 * process.h (struct Lisp_Process.read_output_delay):
3355 Now counts nanoseconds, not microseconds.
3356 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3357 EMACS_HAS_USECS.
3358 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3359 (wait_reading_process_output):
3360 Port to ns-resolution time stamps.
3361 (Faccept_process_output, wait_reading_process_output):
3362 Check for time stamp overflow. Do not assume time_t is signed.
3363 (select_wrapper): Remove; we now use pselect.
3364 (Fprocess_attributes): Now generates ns-resolution time stamps.
3365
3366 * sysdep.c: Include utimens.h. Don't include utime.h
3367 or worry about struct utimbuf; gnulib does that for us now.
3368 (gettimeofday): Remove; gnulib provides a substitute.
3369 (make_timeval): New function.
3370 (set_file_times): Now sets ns-resolution time stamps.
3371 New arg FD; all uses changed.
3372 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3373 (system_process_attributes):
3374 Now returns ns-resolution time stamp. All uses changed.
3375 Check for time stamp overflow.
3376
3377 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3378 provides a substitute now.
3379
3380 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3381 since it guarantees struct timespec.
3382 (EMACS_TIME): Now struct timespec, so that we can support
3383 ns-resolution time stamps.
3384 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3385 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3386 (EMACS_USECS): Remove.
3387 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3388 so multiply the arg by 1000 before storing it.
3389 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3390 New macros.
3391 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3392 Port to ns-resolution time stamps.
3393 (EMACS_TIME_NEG_P): Remove; replaced by....
3394 (EMACS_TIME_SIGN): New macro.
3395 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3396 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3397 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3398 (make_timeval, make_lisp_time, decode_time_components): New decls.
3399 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3400 that it mishandled time_t overflow. You can't compare by subtracting!
3401 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3402 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3403
3404 * term.c: Include <sys/time.h>.
3405 (timeval_to_Time): New function, for proper overflow wraparound.
3406 (term_mouse_position, term_mouse_click): Use it.
3407
3408 * undo.c (record_first_change): Support higher-resolution time stamps
3409 in the undo buffer.
3410 (Fprimitive_undo): Use them when restoring time stamps.
3411
3412 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3413 (w32_get_internal_run_time):
3414 Port to higher-resolution Emacs time stamps.
3415 (ltime): Now accepts single 64-bit integer, as that's more convenient
3416 for callers.
3417
3418 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3419
3420 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3421 for compatibility with pselect. Support ns-resolution time stamps.
3422
3423 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3424
3425 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3426 Check for time stamp overflow, and support ns-resolution time stamps.
3427
3428 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3429 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3430 (timeval_subtract): Remove; no longer needed.
3431 (XTflash, XTring_bell, x_wait_for_event):
3432 Port to ns-resolution time stamps. Don't assume time_t is signed.
3433
b6a92dfe
CY
34342012-06-22 Chong Yidong <cyd@gnu.org>
3435
3436 * xdisp.c (x_consider_frame_title): Revert last change.
3437
d251c37c
EZ
34382012-06-22 Eli Zaretskii <eliz@gnu.org>
3439
3440 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3441 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3442 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3443 staticidx goes up to 1597 out of 1600 = 0x640.)
3444
f10deafb
PE
34452012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3448 Otherwise, the umask might be mistakenly 0 while handling input signals.
3449
ec6de1e2
SM
34502012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3451
3452 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3453
28be1ada
DA
34542012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3455
3456 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3457 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3458 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3459 access to `contents' member of Lisp_Vector objects with AREF and ASET
3460 where appropriate.
3461
c6bf3022
CY
34622012-06-19 Chong Yidong <cyd@gnu.org>
3463
3464 * frame.c (delete_frame): When selecting a frame on a different
3465 text terminal, do not alter the terminal's top-frame.
3466
3467 * xdisp.c (format_mode_line_unwind_data): Record the target
3468 frame's selected window and its terminal's top-frame.
3469 (unwind_format_mode_line): Restore them.
3470 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3471 Callers changed.
3472 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3473 since tty frames can be explicitly named.
3474 (prepare_menu_bars): Likewise.
3475
3476 * term.c (Ftty_top_frame): New function.
3477
defd4196
PE
34782012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 Port byte-code-meter to modern targets.
3481 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3482 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3483 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3484 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3485 (METER_1, METER_2): Simplify.
3486
1053a871
SM
34872012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3488
3489 * data.c (Fdefalias): Return `symbol' (bug#11686).
3490
b7e8d081
MR
34912012-06-18 Martin Rudalics <rudalics@gmx.at>
3492
3493 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3494 gets killed during executing of this function (Bug#11665).
3495 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3496 (Vkill_buffer_query_functions): In doc-string say that functions
3497 run by this hook should not change the current buffer.
3498
7ea2b339
PE
34992012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3500
3501 Fix recently-introduced process.c problems found by static checking.
3502 * process.c (write_queue_push, write_queue_pop, send_process):
3503 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3504 (write_queue_pop): Fix pointer signedness problem.
3505 (send_process): Remove unused local.
3506
96a313a1
CY
35072012-06-17 Chong Yidong <cyd@gnu.org>
3508
3509 * xdisp.c (redisplay_internal): No need to redisplay terminal
3510 frames that are not on top.
3511
20ca2e94
TN
35122012-06-17 Troels Nielsen <bn.troels@gmail.com>
3513
3514 * process.c (make_process): Initialize write_queue.
3515 (write_queue_push, write_queue_pop): New functions.
3516 (send_process): Use them to maintain correct ordering of process
3517 writes (Bug#10815).
3518
9a900ca9
PE
35192012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3520
310fbfa8
PE
3521 * lisp.h (eassert): Assume C89 or later.
3522 This removes the need for CHECK.
3523 (CHECK): Remove. Its comments about always evaluating its
3524 argument were confusing, as 'eassert' typically does not evaluate
3525 its argument.
3526
27bb1ca4
PE
3527 * coding.c (produce_chars): Use ptrdiff_t, not int.
3528
9a900ca9
PE
3529 * xterm.c (x_draw_underwave): Check for integer overflow.
3530 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3531
41b7f8bc 35322012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3533
3534 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3535 referenced (Bug#11583).
3536
9b0e3eba
AA
35372012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3538
3539 Implement wave-style variant of underlining.
3540 * dispextern.h (face_underline_type): New enum.
3541 (face): Add field for underline type.
3542 * nsterm.m (ns_draw_underwave): New function.
3543 (ns_draw_text_decoration): Use it.
3544 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3545 New functions.
3546 (x_draw_glyph_string): Use them.
3547 * xfaces.c (Qline, Qwave): New Lisp objects.
3548 (check_lface_attrs, merge_face_ref)
1053a871
SM
3549 (Finternal_set_lisp_face_attribute, realize_x_face):
3550 Handle wave-style underline face attributes.
9b0e3eba
AA
3551 * xterm.c (x_draw_underwave): New function.
3552 (x_draw_glyph_string): Use it.
3553
0fb52f11
JB
35542012-06-16 Juanma Barranquero <lekktu@gmail.com>
3555
3556 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3557 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3558 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3559 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3560 ($(BLD)/w32select.$(O)): Update dependencies.
3561
e5560ff7
AS
35622012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3563
3564 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3565 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3566 * character.c (_fetch_multibyte_char_p): Remove.
3567 * alloc.c: Include "character.h" before "buffer.h".
3568 * bidi.c: Likewise.
3569 * buffer.c: Likewise.
3570 * bytecode.c: Likewise.
3571 * callint.c: Likewise.
3572 * callproc.c: Likewise.
3573 * casefiddle.c: Likewise.
3574 * casetab.c: Likewise.
3575 * category.c: Likewise.
3576 * cmds.c: Likewise.
3577 * coding.c: Likewise.
3578 * composite.c: Likewise.
3579 * dired.c: Likewise.
3580 * dispnew.c: Likewise.
3581 * doc.c: Likewise.
3582 * dosfns.c: Likewise.
3583 * editfns.c: Likewise.
3584 * emacs.c: Likewise.
3585 * fileio.c: Likewise.
3586 * filelock.c: Likewise.
3587 * font.c: Likewise.
3588 * fontset.c: Likewise.
3589 * fringe.c: Likewise.
3590 * indent.c: Likewise.
3591 * insdel.c: Likewise.
3592 * intervals.c: Likewise.
3593 * keyboard.c: Likewise.
3594 * keymap.c: Likewise.
3595 * lread.c: Likewise.
3596 * macros.c: Likewise.
3597 * marker.c: Likewise.
3598 * minibuf.c: Likewise.
3599 * nsfns.m: Likewise.
3600 * nsmenu.m: Likewise.
3601 * print.c: Likewise.
3602 * process.c: Likewise.
3603 * regex.c: Likewise.
3604 * region-cache.c: Likewise.
3605 * search.c: Likewise.
3606 * syntax.c: Likewise.
3607 * term.c: Likewise.
3608 * textprop.c: Likewise.
3609 * undo.c: Likewise.
3610 * unexsol.c: Likewise.
3611 * w16select.c: Likewise.
3612 * w32fns.c: Likewise.
3613 * w32menu.c: Likewise.
3614 * window.c: Likewise.
3615 * xdisp.c: Likewise.
3616 * xfns.c: Likewise.
3617 * xmenu.c: Likewise.
3618 * xml.c: Likewise.
3619 * xselect.c: Likewise.
3620
2f07e6af
EZ
36212012-06-16 Eli Zaretskii <eliz@gnu.org>
3622
1053a871
SM
3623 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3624 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3625 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3626 row.
3627 (handle_face_prop): Use chunk-relative overlay string index when
3628 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3629 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3630 the rightmost. (Bug#11720)
2f07e6af 3631
29b83cec
AS
36322012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3633
3634 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3635 (CATEGORY_MEMBER): Enforce 1/0 value.
3636 * category.c (_temp_category_set): Remove.
3637
4c5501e9
EZ
36382012-06-16 Eli Zaretskii <eliz@gnu.org>
3639
3640 * window.c (Fdelete_other_windows_internal)
3641 (Fdelete_window_internal): Don't access frame's mouse highlight
3642 info of the initial frame. (Bug#11677)
3643
2b570124
PE
36442012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3645
e93864f9
PE
3646 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3647 Assume USE_2_TAGS_FOR_INTS.
3648 (xreload): Adjust $tagmask width to match recent lisp.h change.
3649
2b570124
PE
3650 Simplify lisp.h in minor ways that should not affect code.
3651 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3652 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3653 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3654 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3655 (INTTYPEBITS): New macro, for clarity.
3656 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3657 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3658 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3659 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3660 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3661
81755f69
JB
36622012-06-13 Juanma Barranquero <lekktu@gmail.com>
3663
3664 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3665
16192a57
GM
36662012-06-13 Glenn Morris <rgm@gnu.org>
3667
3668 * s/bsd-common.h (BSD4_3):
3669 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3670
646b5f55
AS
36712012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3672
3673 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3674 instead of union.
3675 (XLI, XIL): Define.
1053a871
SM
3676 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3677 Use them.
3678 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3679 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3680 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3681 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3682 * frame.c (delete_frame): Remove outdated comment.
3683 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3684 USE_LISP_UNION_TYPE.
3685 (Fw32_unregister_hot_key): Likewise.
3686 (Fw32_toggle_lock_key): Likewise.
3687 * w32menu.c (add_menu_item): Likewise.
3688 (w32_menu_display_help): Use XIL instead of checking
3689 USE_LISP_UNION_TYPE.
3690 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3691 (init_heap): Likewise.
3692 * w32term.c (w32_read_socket): Update comment.
3693
1d3823c9
GM
36942012-06-13 Glenn Morris <rgm@gnu.org>
3695
c62ff706
GM
3696 * s/usg5-4-common.h, src/s/unixware.h:
3697 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3698
1d3823c9
GM
3699 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3700
bfe3e0a2
PE
37012012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3702
3703 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3704 * alloc.c (make_number) [!defined make_number]:
3705 Remove, as lisp.h always defines this now.
3706 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3707 (roundup_size): Verify that it is a power of 2.
3708 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3709 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3710 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3711 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3712 USE_LSB_TAG now is always defined to be either 0 or 1.
3713 All uses changed.
3714 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3715 code works fine either way, and efficiency is not a concern here,
3716 as the union type is for debugging, not for production.
3717 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3718 Use an inline function on all platforms when using the union type,
3719 since this is simpler and 'static inline' can be used portably
3720 within Emacs now.
3721 (LISP_INITIALLY_ZERO): New macro.
3722 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3723 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3724
45fa9c0f
GM
37252012-06-12 Glenn Morris <rgm@gnu.org>
3726
b4492cba
GM
3727 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3728
3729 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3730
45fa9c0f
GM
3731 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3732 Move BROKEN_SIGIO to configure.
3733
3734 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3735 Move NO_TERMIO to configure.
3736
0e25d334
CY
37372012-06-12 Chong Yidong <cyd@gnu.org>
3738
3739 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3740 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3741 MagickExportImagePixels is undefined.
3742
43682bb6
PE
37432012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3744
3745 * image.c (imagemagick_load_image): Remove unused label.
3746
a9be7d2b
GM
37472012-06-11 Glenn Morris <rgm@gnu.org>
3748
3749 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3750 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3751 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3752 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3753
3017f87f
SM
37542012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3755
3756 * alloc.c (make_byte_code): New function.
3757 (Fmake_byte_code): Use it. Don't purify here.
3758 * lread.c (read1): Use it as well to avoid extra allocation.
3759
1b9b4cf4
CY
37602012-06-11 Chong Yidong <cyd@gnu.org>
3761
3762 * image.c (imagemagick_load_image): Implement transparency.
3763
95988fcf
AS
37642012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3765
3766 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3767 account for preceding backslashes. (Bug#11663)
3768
cd4eb164
CY
37692012-06-09 Chong Yidong <cyd@gnu.org>
3770
3771 * term.c: Support italics in capable terminals (Bug#9652).
3772 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3773 (turn_on_face): Output using TS_enter_italic_mode if available.
3774 Don't handle unused blinking and alt-charset cases.
3775 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3776 and tty_alt_charset_p cases.
3777 (tty_capable_p, init_tty): Support italics.
3778
3779 * termchar.h (struct tty_display_info): Add field for italics.
3780 Remove unused blink field.
3781
3782 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3783 Handle slant.
3784
3785 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3786 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3787 tty_alt_charset_p. Add tty_italic_p.
3788
ff88beb8
MA
37892012-06-09 Michael Albinus <michael.albinus@gmx.de>
3790
3791 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3792 dbus_type_is_basic if available.
3793 (xd_extract_signed, xd_extract_unsigned): Rename from
3794 extract_signed and extract_unsigned, respectively. Adapt callers.
3795
44286096
CY
37962012-06-09 Chong Yidong <cyd@gnu.org>
3797
1682701f
CY
3798 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3799
44286096
CY
3800 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3801 case (Bug#9752).
3802
d86feb17
PE
38032012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3804
3805 * xdisp.c (vmessage): Treat frame message as multibyte.
3806 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3807 would generate the diagnostic "Making \302\247 buffer-local while
3808 let-bound!".
3809
d5c20fe8
EZ
38102012-06-08 Eli Zaretskii <eliz@gnu.org>
3811
3812 * dispnew.c (showing_window_margins_p): Undo last change, which
3813 was done due to an inadvertent commit.
3814 (adjust_frame_glyphs_for_frame_redisplay): Do call
3815 showing_window_margins_p.
3816
513749ee
SM
38172012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3818
3819 * eval.c (Fmake_var_non_special): New primitive.
3820 (syms_of_eval): Defsubr it.
3821 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3822
d4a8f5c1
JB
38232012-06-08 Juanma Barranquero <lekktu@gmail.com>
3824
3825 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3826 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3827
8bbbc977
EZ
38282012-06-08 Eli Zaretskii <eliz@gnu.org>
3829
3830 * alloc.c (allocate_vectorlike): Fix last change.
3831
f3372c87
DA
38322012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3833
3834 Block-based vector allocation of small vectors.
3835 * lisp.h (struct vectorlike_header): New field `nbytes',
3836 adjust comment accordingly.
3837 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3838 to denote vector blocks. Adjust users (live_vector_p,
3839 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3840 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3841 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3842 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3843 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3844 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3845 (roundup_size): New constant.
3846 (struct vector_block): New data type.
3847 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3848 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3849 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3850 (sweep_vectors): New functions.
3851 (allocate_vectorlike): Return `zero_vector' as the only vector of
3852 0 items. Allocate new vector from block if vector size is less than
3853 or equal to VBLOCK_BYTES_MAX.
3854 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3855 (init_alloc_once): Add call to init_vectors.
3856
4f18a4ed
SM
38572012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3858
3859 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3860
86f158bc
PE
38612012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3862
3863 * doprnt.c (doprnt): Truncate multibyte char correctly.
3864 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3865 would mishandle a string argument "Xc" if X was a multibyte
3866 character of length 2: it would truncate after X's first byte
3867 rather than including all of X.
3868
c5cfcbe0
CY
38692012-06-06 Chong Yidong <cyd@gnu.org>
3870
3871 * buffer.c (word_wrap): Doc fix.
3872
c05cf390
PE
38732012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3874
3875 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3876
0c3461de
GM
38772012-06-03 Glenn Morris <rgm@gnu.org>
3878
3879 * xdisp.c (tool-bar-style): Doc fix.
3880
c71232db
UM
38812012-06-03 Ulrich Müller <ulm@gentoo.org>
3882
3883 * Makefile.in (PAXCTL): Define.
3884 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3885 binary via PaX flags if the paxctl utility is available.
3886 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3887 Restore PaX flags to their default. (Bug#11398)
3888
383f7350
CY
38892012-06-03 Chong Yidong <cyd@gnu.org>
3890
3891 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3892 buffer (Bug#11226).
3893
5f2c76c6
CY
38942012-06-03 Chong Yidong <cyd@gnu.org>
3895
3896 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3897 (note_mode_line_or_margin_highlight): If there is no help echo,
3898 use mode-line-default-help-echo. Handle the case where the mouse
3899 position is past the end of the mode line string.
3900
3901 * buffer.c (buffer_local_value_1): New function, split from
3902 Fbuffer_local_value; can return Qunbound.
3903 (Fbuffer_local_value): Use it.
3904 (Vmode_line_format): Docstring tweaks.
3905
773d47f6
PE
39062012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3907
3908 * sysdep.c (system_process_attributes): Improve comment.
3909
f2d6a3df
SM
39102012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3911
3912 * keyboard.c: Export real-this-command to Elisp.
3913 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3914 and DEFVAR it. Update all users.
3915
63810350
PE
39162012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3917
7bd5c1f4
PE
3918 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3919
63810350
PE
3920 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3921 Convert pctcpu and pctmem to Lisp float properly.
3922 Let the compiler fold better, as 100.0/0x8000 is exact.
3923
a2821611
AS
39242012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3925
3926 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3927 cons_block.
3928
5fceba1d
PE
39292012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3930
3931 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3932
c98ff5dd
DA
39332012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3934
3935 For a 'struct window', replace some Lisp_Object fields to
3936 bitfields where appropriate, remove unused fields.
3937 * window.h (struct window): Remove unused 'last_mark_x' and
3938 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3939 change it's type from Lisp_Object to bitfield.
3940 Change type of 'force_start', 'optional_new_start',
3941 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3942 fields from Lisp_Object to bitfield. Adjust users accordingly.
3943
ca34e0be
PE
39442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3945
3946 Pacify gcc -Wdouble-precision when using Xaw.
3947 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3948 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3949 Use 'float' consistently, rather than 'float' in most places
3950 and 'double' in a couple of places.
3951
efc00ab1 39522012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3953
3954 * xdisp.c (handle_stop): Detect whether we have overlay strings
3955 loaded by testing it->current.overlay_string_index to be
3956 non-negative, instead of checking whether n_overlay_strings is
3957 positive. (Bug#11587)
3958
efc00ab1 39592012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3960
3961 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3962
3963 * doc.c (Fsubstitute_command_keys): Doc fix.
3964
efc00ab1 39652012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3966
3967 * search.c (search_buffer): Remove calls to
3968 r_alloc_inhibit_buffer_relocation, as it is now called by
3969 maybe_unify_char, which was the cause of relocation of buffer text
3970 in bug#11519.
3971
efc00ab1 39722012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3973
3974 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3975 for the duration of call to load_charset, to avoid problems with
3976 callers of maybe_unify_char that access buffer text through C
3977 pointers.
3978
3979 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3980 decrement the inhibition flag, instead of just setting or
3981 resetting it.
3982
ba93a187
PE
39832012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Remove obsolete '#define static' cruft.
3986 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3987 This #undef was "temporary" in 2000; it is no longer needed
3988 now that '#define static' has gone away.
3989 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3990 (gray_bitmap_bits): Remove; no longer needed.
3991 All uses replaced with definiens.
3992 * xterm.c: Include "bitmaps/gray.xbm".
3993
9e4bf381
PE
39942012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3995
3996 Clean up __executable_start, monstartup when --enable-profiling.
3997 The following changes affect the code only when profiling.
3998 * dispnew.c (__executable_start): Rename from safe_bcopy.
3999 Define only on platforms that need it.
4000 * emacs.c: Include <sys/gmon.h> when profiling.
4001 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
4002 (__executable_start): Remove decl, since lisp.h does it now.
4003 (safe_bcopy): Remove decl; no longer has that name.
4004 (main): Coalesce #if into single bit of code, for simplicity.
4005 Cast pointers to uintptr_t, since standard libraries want integers
4006 and not pointers.
4007 * lisp.h (__executable_start): New decl.
4008
32d72c2f
GM
40092012-05-31 Glenn Morris <rgm@gnu.org>
4010
4011 * image.c (Fimagemagick_types): Doc fix.
4012
baac5bc7
JM
40132012-05-30 Jim Meyering <meyering@redhat.com>
4014
4015 * callproc.c (Fcall_process_region): Include directory component
4016 in mkstemp error message (Bug#11586).
4017
72cb32cf
PE
40182012-05-30 Paul Eggert <eggert@cs.ucla.edu>
4019
4020 * alloc.c, lisp.h (make_pure_vector): Now static.
4021
61b108cc
SM
40222012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
4025 Move to byte-run.el.
4026 (Fautoload): Do the hash-doc more carefully.
4027 * data.c (Fdefalias): Purify definition, except for keymaps.
4028 (Qdefun): Move from eval.c.
4029 * lisp.h (Qdefun): Remove.
4030 * lread.c (read1): Tiny simplification.
4031
471fe23d
TN
40322012-05-29 Troels Nielsen <bn.troels@gmail.com>
4033
934f3f58 4034 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
4035 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
4036 Bug#9642, but explicitly check that the buffer the overlay would
4037 be moved to is live and rearrange lines to make sure that errors
4038 will not put the overlay in an inconsistent state.
4039 (Fdelete_overlay): Cosmetics.
4040
85d0efd1
EZ
40412012-05-28 Eli Zaretskii <eliz@gnu.org>
4042
4043 * w32term.c (my_bring_window_to_top): New function.
4044 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
4045 could be different from the original one.
4046 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
4047 (Bug#11513)
4048
4049 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
4050 by calling BringWindowToTop.
4051
4052 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
4053 (WM_EMACS_END): Increase by one.
4054
da92a98c
PE
40552012-05-28 Paul Eggert <eggert@cs.ucla.edu>
4056
4057 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
4058 This avoids undefined behavior that might cause the eassert
4059 to not catch an out-of-range value.
4060
74d1f848
JB
40612012-05-28 Juanma Barranquero <lekktu@gmail.com>
4062
4063 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
4064 Update dependencies.
4065
9e1a06fc
EZ
40662012-05-27 Eli Zaretskii <eliz@gnu.org>
4067
4068 * bidi.c (bidi_mirror_char): Fix last change.
4069
f3dd7312
AS
40702012-05-27 Andreas Schwab <schwab@linux-m68k.org>
4071
4072 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
4073 when referring to sectname field in printf format.
4074
81899c91
PE
40752012-05-27 Paul Eggert <eggert@cs.ucla.edu>
4076
57b81a9f
PE
4077 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
4078 Only r_alloc_inhibit_buffer_relocation needed to be added;
4079 the others were already declared.
4080
81899c91
PE
4081 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4082 before checking whether it's out of range. Put the check inside
4083 eassert. See
4084 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
4085
33017faf 40862012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
4087
4088 * callproc.c (Fcall_process): Restore a line that was accidentally
4089 commented out in the 2011-02-13 change (bug#11547).
4090
33017faf 40912012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
4092
4093 * lisp.h [REL_ALLOC]: Add prototypes for external functions
4094 defined on ralloc.c.
4095
4096 * buffer.c [REL_ALLOC]: Remove prototypes of
4097 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
4098 they are now on lisp.h.
4099
4100 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4101
4102 * search.c (search_buffer): Use it to inhibit relocation of buffer
4103 text while re_search_2 is doing its job, because re_search_2 is
4104 passed C pointers to buffer text. (Bug#11519)
4105
23415acf
EZ
4106 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4107 Update value to 24.
4108
44e27368
EZ
4109 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4110 state after an additional call to move_it_in_display_line_to, keep
4111 the values of it->max_ascent and it->max_descent found for the
4112 entire line.
4113 (pos_visible_p): Revert the comparison against bottom_y to what it
4114 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4115 (Bug#11464)
4116
c1892f11
PE
41172012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4118
4119 Fix coding-related core dumps with gcc -ftrapv.
4120 The code was computing A - B, where A and B are pointers, and B is
4121 random garbage. This can lead to core dumps on platforms that
4122 have special pointer registers, and it also leads to core dumps on
4123 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4124 A - B only when B is initialized properly.
4125 * coding.c (coding_set_source, coding_set_destination): Return void.
4126 (coding_change_source, coding_change_destinations): New functions,
4127 with the old behaviors of coding_set_source and coding_set_destination.
4128 All callers that need an offset changed to use these new functions.
4129
eb7afdad
GM
41302012-05-26 Glenn Morris <rgm@gnu.org>
4131
4132 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4133
f12fdf02
EZ
41342012-05-26 Eli Zaretskii <eliz@gnu.org>
4135
53a63be6 4136 Extend mouse support on W32 text-mode console.
61b108cc
SM
4137 * xdisp.c (draw_row_with_mouse_face):
4138 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4139
eb3f6f01 4140 * w32console.c: Include window.h.
61b108cc
SM
4141 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4142 New functions.
eb3f6f01
EZ
4143 (initialize_w32_display): Initialize mouse-highlight data.
4144
53a63be6
EZ
4145 * w32inevt.c: Include termchar.h and window.h.
4146 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4147 moves, call note_mouse_highlight. If help_echo changed, call
4148 gen_help_event to produce help-echo message in the echo area.
4149 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4150 highlight info.
4151
4cfd81f6
PE
41522012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4153
4154 * lread.c (read1): Simplify slightly to avoid an overflow warning
4155 with GCC 4.7.0 on x86-64.
4156
4446092a
EZ
41572012-05-26 Eli Zaretskii <eliz@gnu.org>
4158
4159 * bidi.c (bidi_mirror_char): Revert last change: an int is
4160 definitely wide enough here.
4161
42b2a986 41622012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4163
42b2a986 4164 Fix integer width and related bugs (Bug#9874).
eb106a49 4165 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4166 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4167 (string_bytes, check_sblock, allocate_string_data):
4168 (compact_small_strings, Fmake_bool_vector, make_string)
4169 (make_unibyte_string, make_multibyte_string)
4170 (make_string_from_bytes, make_specified_string)
4171 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4172 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4173 (mark_vectorlike):
4174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4175 (allocate_pseudovector):
4176 Use int, not EMACS_INT, where int is wide enough.
4177 (inhibit_garbage_collection, Fgarbage_collect):
4178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4179 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4180 int might not be wide enough.
4181 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4182 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4183 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4184 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4185 (bidi_level_of_next_char, bidi_move_to_visually_next):
4186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4187 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4188 (Fkill_buffer, Fset_buffer_major_mode)
4189 (advance_to_char_boundary, Fbuffer_swap_text)
4190 (Fset_buffer_multibyte, overlays_at, overlays_in)
4191 (overlay_touches_p, struct sortvec, record_overlay_string)
4192 (overlay_strings, recenter_overlay_lists)
4193 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4194 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4195 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4196 (Foverlay_recenter, last_overlay_modification_hooks_used)
4197 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4199 (validate_region): Omit unnecessary test for b <= e,
4200 since that's guaranteed by the previous test.
d311d28c
PE
4201 (adjust_overlays_for_delete): Avoid pos + length overflow.
4202 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4203 (report_overlay_modification):
4204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4205 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4206 Omit pointer cast, which isn't needed anyway, and doesn't work
4207 after the EMACS_INT -> ptrdiff_t change.
02481186 4208 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4209 * buffer.h: Adjust decls to match defn changes elsewhere.
4210 (struct buffer_text, struct buffer):
4211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4212 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4213 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4214 not int, to avoid needless 32-bit limit on 64-bit hosts.
4215 (exec_byte_code): Use tighter memory-full test, one that checks
4216 for alloca overflow. Don't compute the address of the object just
4217 before an array, as that's not portable. Use EMACS_INT, not
4218 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4219 * callint.c (Fcall_interactively):
4220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4221 * callproc.c (call_process_kill, Fcall_process):
4222 Don't assume pid_t fits into an Emacs fixnum.
4223 (call_process_cleanup, Fcall_process, child_setup):
4224 Don't assume pid_t fits into int.
4225 (call_process_cleanup, Fcall_process, delete_temp_file)
4226 (Fcall_process_region):
4227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4228 (Fcall_process): Simplify handling of volatile integers.
4229 Use int, not EMACS_INT, where int will do.
4230 * casefiddle.c (casify_object, casify_region, operate_on_word)
4231 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4233 (casify_object): Avoid integer overflow when overallocating buffer.
4234 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4235 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4236 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4237 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4238 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4239 integers are now checked earlier. All uses replaced with XINT.
4240 (ccl_driver):
4241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4242 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4243 (ccl_driver, Fregister_code_conversion_map):
4244 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4245 (resolve_symbol_ccl_program): Check that vector header is in range.
4246 Always copy the vector, so that we can check its contents reliably
4247 now rather than having to recheck each instruction as it's being
4248 executed. Check that vector words fit in 'int'.
4249 (ccl_get_compiled_code, Fregister_ccl_program)
4250 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4251 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4252 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4253 contents are in range.
4254 (Fccl_execute_on_string): Check that status is in range.
4255 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4256 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4257 Accept and return EMACS_INT, not int, because callers can pass values
4258 out of 'int' range.
4259 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4260 (multibyte_chars_in_text, parse_str_as_multibyte)
4261 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4262 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4263 (string_escape_byte8, Fget_byte):
4264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4265 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4266 avoid mishandling large integers.
4267 * character.h: Adjust decls to match defn changes elsewhere.
4268 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4269 (Ffind_charset_region):
4270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4271 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4272 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4273 Don't assume fixnum fits in int.
d311d28c
PE
4274 (load_charset_map_from_vector, Fmap_charset_chars):
4275 Remove now-unnecessary CHECK_NATNUMs.
4276 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4277 Don't rely on undefined behavior with signed left shift overflow.
4278 Don't assume unsigned int fits into fixnum, or that fixnum fits
4279 into unsigned int. Don't require max_code to be a valid fixnum;
4280 that's not true for gb10830 4-byte on a 32-bit host. Allow
4281 invalid_code to be a cons, for the same reason. Require code_offset
4282 to be a character. Avoid int overflow if max_char is close
4283 to INT_MAX.
4284 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4285 this is intended anyway and avoids some undefined behavior.
4286 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4287 INDEX_TO_CODE_POINT, as that's what it expects.
4288 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4289 * charset.h (DECODE_CHAR): Return int, not unsigned;
4290 this is what was intended anyway, and it avoids undefined behavior.
4291 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4292 integer-overflow issues.
4293 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4294 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4295 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4296 * chartab.c (Fmake_char_table, Fset_char_table_range)
4297 (uniprop_get_decoder, uniprop_get_encoder):
4298 Don't assume fixnum fits in int.
4299 * cmds.c (move_point): New function, that does the gist of
4300 Fforward_char and Fbackward_char, but does so while checking
4301 for integer overflow more accurately.
c96e5d6a 4302 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4303 (Fforward_line, Fend_of_line, internal_self_insert)
4304 (internal_self_insert):
4305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4306 Fix a FIXME, by checking for integer overflow when calculating
4307 target_clm and actual_clm.
4308 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4309 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4310 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4311 (coding_alloc_by_making_gap, alloc_destination)
4312 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4313 (encode_coding_utf_16, detect_coding_emacs_mule)
4314 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4315 (detect_coding_iso_2022, decode_coding_iso_2022)
4316 (encode_invocation_designation, encode_designation_at_bol)
4317 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4318 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4319 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4320 (encode_coding_ccl, encode_coding_raw_text)
4321 (detect_coding_charset, decode_coding_charset)
4322 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4323 (produce_composition, produce_charset, produce_annotation)
4324 (decode_coding, handle_composition_annotation)
4325 (handle_charset_annotation, consume_chars, decode_coding_gap)
4326 (decode_coding_object, encode_coding_object, detect_coding_system)
4327 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4328 (code_convert_region, code_convert_string)
8f50130c
PE
4329 (Fdefine_coding_system_internal)
4330 (coding_set_source, coding_set_destination):
d311d28c
PE
4331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4332 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4333 (Fdefine_coding_system_internal):
4334 Don't assume fixnums fit in int.
4335 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4336 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4337 (Funencodable_char_position, Fcheck_coding_systems_region)
4338 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4340 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4341 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4342 Don't access memory outside of the args array.
d311d28c 4343 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4344 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4345 result of ENCODE_CHAR.
d311d28c
PE
4346 * coding.h: Adjust decls to match defn changes elsewhere.
4347 (struct coding_system):
4348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4349 * composite.c (get_composition_id, find_composition)
4350 (run_composition_function, update_compositions)
4351 (compose_text, composition_gstring_put_cache)
4352 (composition_gstring_p, composition_gstring_width)
4353 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4354 (composition_compute_stop_pos, composition_reseat_it)
4355 (composition_update_it, struct position_record)
4356 (find_automatic_composition, composition_adjust_point)
4357 (Fcomposition_get_gstring, Ffind_composition_internal):
4358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4359 (update_compositions):
4360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4361 * composite.h: Adjust decls to match defn changes elsewhere.
4362 (struct composition):
4363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4364 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4365 Do not attempt to compute the address of the object just before a
4366 buffer; this is not portable.
4367 (Faref, Faset):
4368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4369 (Faset): Use int, not EMACS_INT, where int is wide enough.
4370 (Fstring_to_number): Don't assume fixnums fit in int.
4371 (Frem): Don't assume arg is nonnegative.
4372 * dbusbind.c (xd_append_arg): Check for integers out of range.
4373 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4374 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4375 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4376 (xd_get_connection_references): Return ptrdiff_t, not int.
4377 All uses changed.
4378 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4379 (xd_read_message_1):
4380 Use int, not unsigned, where the dbus API uses int.
4381 (Fdbus_message_internal): Don't overflow mtype.
4382 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4383 * dired.c (directory_files_internal, file_name_completion, scmp)
4384 (file_name_completion_stat):
4385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4386 (file_name_completion): Don't overflow matchcount.
4387 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4388 * dispextern.h: Adjust decls to match defn changes elsewhere.
4389 (struct text_pos, struct glyph, struct bidi_saved_info)
4390 (struct bidi_string_data, struct bidi_it, struct composition_it)
4391 (struct it):
4392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4393 (struct display_pos, struct composition_it, struct it):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4395 * dispnew.c (increment_matrix_positions)
4396 (increment_row_positions, mode_line_string)
4397 (marginal_area_string):
4398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4399 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4401 (duration_to_sec_usec): New function, to check for overflow better.
4402 (Fsleep_for, sit_for): Use it.
4403 * doc.c (get_doc_string, store_function_docstring):
4404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4405 (get_doc_string, Fsnarf_documentation):
4406 Use int, not EMACS_INT, where int is wide enough.
4407 (get_doc_string):
4408 Use SAFE_ALLOCA, not alloca.
4409 Check for overflow when converting EMACS_INT to off_t.
4410 * doprnt.c (doprnt):
4411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4412 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4413 Don't assume uid_t fits into fixnum.
4414 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4415 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4416 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4417 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4418 (general_insert_function)
4419 (Finsert_char, make_buffer_string, make_buffer_string_both)
4420 (update_buffer_properties, Fbuffer_substring)
4421 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4422 (Fsubst_char_in_region, check_translation)
4423 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4424 (transpose_markers, Ftranspose_regions):
4425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4426 (clip_to_bounds): Move to lisp.h as an inline function).
4427 (Fconstrain_to_field): Don't assume integers are nonnegative.
4428 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4429 (Fsubst_char_in_region, Fsave_restriction):
4430 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4431 (Femacs_pid): Don't assume pid_t fits into fixnum.
4432 (lo_time): Use int, not EMACS_INT, when int suffices.
4433 (lisp_time_argument): Check for usec out of range.
4434 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4435 (Fuser_login_name, Fuser_full_name): Signal an error
4436 if a uid argument is out of range, rather than relying on
4437 undefined behavior.
c8d5c857
PE
4438 (Fformat_time_string): Remove now-unnecessary check.
4439 lisp_time_argument checks for out-of-range usec now.
243e0530 4440 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4441 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4442 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4443 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4444 (init_cmdargs, Fdump_emacs):
4445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4446 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4447 the bottom (typically) 32 bits of the fixnum.
4448 * eval.c (specpdl_size, call_debugger):
4449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4450 (when_entered_debugger, Fbacktrace_debug):
4451 Don't assume fixnum can fit in int.
4452 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4453 the object just before a buffer; this is not portable.
4454 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4455 (grow_specpdl, unbind_to):
4456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4457 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4458 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4459 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4460 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4461 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4463 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4464 (a_write, e_write):
4465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4466 (Fcopy_file, non_regular_nbytes, read_non_regular)
4467 (Finsert_file_contents):
4468 Use int, not EMACS_INT, where int is wide enough.
4469 (READ_BUF_SIZE): Verify that it fits in int.
4470 (Finsert_file_contents): Check that counts are in proper range,
4471 rather than assuming fixnums fit into ptrdiff_t etc.
4472 Don't assume fixnums fit into int.
125b3835 4473 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4474 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4475 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4476 (string_char_to_byte, string_byte_to_char)
4477 (string_make_multibyte, string_to_multibyte)
4478 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4479 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4480 (substring_both, Fdelete, internal_equal, Ffillarray)
4481 (Fclear_string, mapcar1)
4482 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4483 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4484 (larger_vector, make_hash_table, maybe_resize_hash_table)
4485 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4486 (Fmaphash, secure_hash):
4487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4488 (concat): Check for string index and length overflow.
4489 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4490 (Frequire):
4491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4492 (larger_vector): New API (vec, incr_min, size_max) replaces old
4493 one (vec, new_size, init). This catches size overflow.
4494 INIT was removed because it was always Qnil.
4495 All callers changed.
4496 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4497 the upper bound on a hash table index size.
4498 (make_hash_table, maybe_resize_hash_table): Use it.
4499 (secure_hash): Computer start_byte and end_byte only after
4500 they're known to be in ptrdiff_t range.
4501 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4502 (Ffont_get_glyphs, Ffont_at):
4503 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4504 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4505 (Flist_fonts, Fopen_font):
4506 Don't assume fixnum can fit in int.
4507 (check_gstring): Don't assume index can fit in int.
4508 (font_match_p): Check that fixnum is a character, not a nonnegative
4509 fixnum, since the later code needs to stuff it into an int.
4510 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4511 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4512 conversion overflow issues.
4513 (Fopen_font): Check for integer out of range.
4514 (Ffont_get_glyphs): Don't assume index can fit in int.
4515 * font.h: Adjust decls to match defn changes elsewhere.
4516 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4517 integer overflow.
4518 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4519 printmax_t, where ptrdiff_t is wide enough.
4520 (Finternal_char_font):
4521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4522 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4523 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4524 (Fset_frame_position, x_set_frame_parameters)
4525 (x_set_line_spacing, x_set_border_width)
4526 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4527 Check that fixnums are in proper range for system types.
4528 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4530 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4531 Use SAFE_ALLOCA_LISP, not alloca.
4532 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4533 intptr_t is wide enough.
4534 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4535 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4536 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4537 Check for fixnum out of range.
4538 * ftfont.c (ftfont_list): Don't assume index fits in int.
4539 Check that fixnums are in proper range for system types.
4540 (ftfont_shape_by_flt):
4541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4542 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4543 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4544 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4545 Check that fixnums are in proper range for system types.
4546 * gnutls.h: Adjust decls to match defn changes elsewhere.
4547 * gtkutil.c (xg_dialog_run):
4548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4549 (update_frame_tool_bar):
4550 Check that fixnums are in proper range for system types.
4551 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4552 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4553 * indent.c (last_known_column, last_known_column_point):
4554 (current_column_bol_cache):
4555 (skip_invisible, current_column, check_display_width):
4556 (check_display_width, scan_for_column, current_column_1)
4557 (Findent_to, Fcurrent_indentation, position_indentation)
4558 (indented_beyond_p, Fmove_to_column, compute_motion):
4559 (Fcompute_motion, Fvertical_motion):
4560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4561 (last_known_column_modified): Use EMACS_INT, not int.
4562 (check_display_width):
4563 (Fcompute_motion):
4564 Check that fixnums and floats are in proper range for system types.
4565 (compute_motion): Don't assume index or fixnum fits in int.
4566 (compute_motion, Fcompute_motion):
4567 Use int, not EMACS_INT, when it is wide enough.
4568 (vmotion): Omit local var start_hpos that is always 0; that way
4569 we don't need to worry about overflow in expressions involving it.
4570 * indent.h: Adjust decls to match defn changes elsewhere.
4571 (struct position):
4572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4573 Use int, not EMACS_INT, where int is wide enough.
4574 Remove unused members ovstring_chars_done and tab_offset;
4575 all uses removed.
4576 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4577 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4578 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4579 (make_gap, copy_text, insert, insert_and_inherit)
4580 (insert_before_markers, insert_before_markers_and_inherit)
4581 (insert_1, count_combining_before, count_combining_after)
4582 (insert_1_both, insert_from_string)
4583 (insert_from_string_before_markers, insert_from_string_1)
4584 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4585 (adjust_after_replace, adjust_after_insert, replace_range)
4586 (replace_range_2, del_range, del_range_1, del_range_byte)
4587 (del_range_both, del_range_2, modify_region)
4588 (prepare_to_modify_buffer, signal_before_change)
4589 (signal_after_change, Fcombine_after_change_execute):
4590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4591 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4592 (balance_an_interval, split_interval_right, split_interval_left)
4593 (find_interval, next_interval, update_interval)
4594 (adjust_intervals_for_insertion, delete_node, delete_interval)
4595 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4596 (static_offset_intervals, offset_intervals)
4597 (merge_interval_right, merge_interval_left, make_new_interval)
4598 (graft_intervals_into_buffer, temp_set_point_both)
4599 (temp_set_point, set_point, adjust_for_invis_intang)
4600 (set_point_both, move_if_not_intangible, get_property_and_range)
4601 (get_local_map, copy_intervals, copy_intervals_to_string)
4602 (compare_string_intervals, set_intervals_multibyte_1):
4603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4604 * intervals.h: Adjust decls to match defn changes elsewhere.
4605 (struct interval):
4606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4607 * keyboard.c (this_command_key_count, this_single_command_key_start)
4608 (before_command_key_count, before_command_echo_length, echo_now)
4609 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4610 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4611 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4612 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4614 (last_non_minibuf_size, last_point_position, echo_truncate)
4615 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4616 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4617 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4618 (stuff_buffered_input):
4619 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4620 (last_auto_save, command_loop_1, read_char):
4621 Use EMACS_INT, not int, to avoid integer overflow.
4622 (record_char): Avoid overflow in total_keys computation.
4623 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4624 * keyboard.h: Adjust decls to match defn changes elsewhere.
4625 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4626 (Fkey_description, Fdescribe_vector, Flookup_key):
4627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4628 (click_position): New function, to check that positions are in range.
4629 (Fcurrent_active_maps):
4630 (describe_command):
4631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4632 (Faccessible_keymaps, Fkey_description):
4633 (preferred_sequence_p):
4634 Don't assume fixnum can fit into int.
4635 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4636 Check for integer overflow in size calculations.
4637 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4638 avoid mishandling large integers.
4639 * lisp.h: Adjust decls to match defn changes elsewhere.
4640 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4641 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4642 (struct Lisp_Marker):
4643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4644 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4645 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4646 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4647 All callers changed.
4648 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4649 Assume the arg has valid form, since it always does.
4650 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4651 unsigned integer system type.
4652 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4653 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4655 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4656 (duration_to_sec_usec): New decl.
4657 * lread.c (read_from_string_index, read_from_string_index_byte)
4658 (read_from_string_limit, readchar, unreadchar, openp)
4659 (read_internal_start, read1, oblookup):
4660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4661 (Fload, readevalloop, Feval_buffer, Feval_region):
4662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4663 (openp): Check for out-of-range argument to 'access'.
4664 (read1): Use int, not EMACS_INT, where int is wide enough.
4665 Don't assume fixnum fits into int.
6efdadfd 4666 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4667 (read_filtered_event): Use duration_to_sec_usec
4668 to do proper overflow checking on durations.
d311d28c
PE
4669 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4670 in size calculation.
4671 (Fexecute_kbd_macro):
4672 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4673 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4674 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4675 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4676 (set_marker_both, set_marker_restricted_both, marker_position)
4677 (marker_byte_position, Fbuffer_has_markers_at):
4678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4679 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4680 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4681 It now merely ensures that the menu is large enough, without
4682 necessarily growing it, as this avoids some integer overflow issues.
4683 All callers changed.
4684 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4686 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4687 Use SAFE_ALLOCA_LISP, not alloca.
4688 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4689 to EMACS_INT. Check that fixnums are in proper range for system types.
4690 * minibuf.c (minibuf_prompt_width, string_to_object)
4691 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4692 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4694 (get_minibuffer, read_minibuf_unwind):
4695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4696 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4697 this simplifies overflow checking. All callers changed.
4698 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4699 (Ftest_completion):
4700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4701 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4702 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4703 Check that fixnums are in proper range for system types.
4704 (Fx_create_frame, Fx_show_tip):
4705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4706 * nsfont.m (ns_findfonts, nsfont_list_family):
4707 Don't assume fixnum fits in long.
4708 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4709 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4710 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4711 wide enough.
17fdb222 4712 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4714 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4715 (PRINTDECLARE, PRINTPREPARE):
4716 (strout, print_string):
4717 (print, print_preprocess, print_check_string_charset_prop)
4718 (print_object):
4719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4720 (PRINTDECLARE):
4721 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4723 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4724 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4725 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4726 (print_error_message): Use SAFE_ALLOCA, not alloca.
4727 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4728 (print_depth, new_backquote_output, print_number_index):
4729 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4730 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4731 (Fset_process_window_size, Fformat_network_address)
4732 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4733 (sigchld_handler):
d311d28c 4734 Check that fixnums are in proper range for system types.
d44287d4 4735 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4736 Check for process-ids out of pid_t range rather than relying on
4737 undefined behavior.
e4d81efc 4738 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4739 (Fformat_network_address, read_process_output, send_process)
4740 (Fprocess_send_region, status_notify):
4741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4742 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4743 (wait_reading_process_output, read_process_output, exec_sentinel):
4744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4745 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4746 (Faccept_process_output): Use duration_to_sec_usec to do proper
4747 overflow checking on durations.
dde14581
PE
4748 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4749 Don't assume pid_t fits in int.
02481186
PE
4750 * process.h (struct Lisp_Process): Members tick and update_tick
4751 are now of type EMACS_INT, not int.
b62b53e8
PE
4752 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4753 configured --with-wide-int.
d311d28c
PE
4754 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4755 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4756 * search.c (looking_at_1, string_match_1):
4757 (fast_string_match, fast_c_string_match_ignore_case)
4758 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4759 (scan_newline, find_before_next_newline, search_command)
4760 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4761 (set_search_regs, wordify):
4762 (Freplace_match):
4763 (Fmatch_data):
4764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4765 (string_match_1, search_buffer, set_search_regs):
4766 (Fmatch_data):
4767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4768 (wordify): Check for overflow in size calculation.
4769 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4770 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4771 Check that fixnums are in proper range for system types.
4772 * sound.c (struct sound_device)
4773 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4775 (Fplay_sound_internal):
4776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4777 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4778 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4779 (Fparse_partial_sexp):
4780 Don't assume fixnums can fit in int.
4781 (struct lisp_parse_state, find_start_pos, find_start_value)
4782 (find_start_value_byte, find_start_begv)
4783 (update_syntax_table, char_quoted, dec_bytepos)
4784 (find_defun_start, prev_char_comend_first, back_comment):
4785 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4786 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4788 (Finternal_describe_syntax_value): Check that match_lisp is a
4789 character, not an integer, since the code stuffs it into int.
4790 (scan_words, scan_sexps_forward):
4791 Check that fixnums are in proper range for system types.
4792 (Fforward_word):
4793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4794 (scan_sexps_forward):
4795 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4796 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4797 * syntax.h: Adjust decls to match defn changes elsewhere.
4798 (struct gl_state_s):
4799 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4800 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4801 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4802 * sysdep.c (wait_for_termination_1, wait_for_termination)
4803 (interruptible_wait_for_termination, mkdir):
4804 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4805 (emacs_read, emacs_write):
4806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4807 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4808 and double all fit in int.
d311d28c
PE
4809 * term.c (set_tty_color_mode):
4810 Check that fixnums are in proper range for system types.
4811 * termhooks.h (struct input_event):
4812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4813 * textprop.c (validate_interval_range, interval_of)
4814 (Fadd_text_properties, set_text_properties_1)
4815 (Fremove_text_properties, Fremove_list_of_text_properties)
4816 (Ftext_property_any, Ftext_property_not_all)
4817 (copy_text_properties, text_property_list, extend_property_ranges)
4818 (verify_interval_modification):
4819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4820 (Fnext_single_char_property_change)
4821 (Fprevious_single_char_property_change):
4822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4823 (copy_text_properties):
4824 Check for integer overflow in index calculation.
d311d28c
PE
4825 * undo.c (last_boundary_position, record_point, record_insert)
4826 (record_delete, record_marker_adjustment, record_change)
4827 (record_property_change):
4828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4829 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4830 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4831 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4832 (Fx_hide_tip, Fx_file_dialog):
4833 * w32menu.c (set_frame_menubar):
4834 Use ptrdiff_t, not int, for consistency with rest of code.
4835 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4836 (select_window, Fdelete_other_windows_internal)
4837 (window_scroll_pixel_based, window_scroll_line_based)
4838 (Frecenter, Fset_window_configuration):
4839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4840 (Fset_window_hscroll, run_window_configuration_change_hook)
4841 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4842 (Fscroll_other_window, Frecenter):
d311d28c
PE
4843 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4844 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4845 Don't assume fixnum fits in int.
4846 (Fset_window_scroll_bars):
4847 Check that fixnums are in proper range for system types.
4848 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4849 (string_pos, c_string_pos, number_of_chars, init_iterator)
4850 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4851 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4852 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4853 (face_before_or_after_it_pos, handle_invisible_prop)
4854 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4855 (display_prop_intangible_p, string_buffer_position_lim)
4856 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4857 (get_overlay_strings_1, get_overlay_strings)
4858 (iterate_out_of_display_property, forward_to_next_line_start)
4859 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4860 (get_next_display_element, set_iterator_to_next)
4861 (get_visually_first_element, compute_stop_pos_backwards)
4862 (handle_stop_backwards, next_element_from_buffer)
4863 (move_it_in_display_line_to, move_it_in_display_line)
4864 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4865 (add_to_log, message_dolog, message_log_check_duplicate)
4866 (message2, message2_nolog, message3, message3_nolog
4867 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4868 (current_message_1, truncate_echo_area, truncate_message_1)
4869 (set_message, set_message_1, store_mode_line_noprop)
4870 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4871 (text_outside_line_unchanged_p, check_point_in_composition)
4872 (reconsider_clip_changes)
4873 (redisplay_internal, set_cursor_from_row, try_scrolling)
4874 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4875 (redisplay_window, find_last_unchanged_at_beg_row)
4876 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4877 (trailing_whitespace_p, find_row_edges, display_line)
4878 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4879 (display_mode_element, store_mode_line_string)
4880 (pint2str, pint2hrstr, decode_mode_spec)
4881 (display_count_lines, display_string, draw_glyphs)
4882 (x_produce_glyphs, x_insert_glyphs)
4883 (rows_from_pos_range, mouse_face_from_buffer_pos)
4884 (fast_find_string_pos, mouse_face_from_string_pos)
4885 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4887 (safe_call, init_from_display_pos, handle_fontified_prop)
4888 (handle_single_display_spec, load_overlay_strings)
4889 (with_echo_area_buffer, setup_echo_area_for_printing)
4890 (display_echo_area, echo_area_display)
4891 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4892 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4893 (redisplay_window, dump_glyph_row, display_mode_line)
4894 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4895 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4897 (handle_single_display_spec, build_desired_tool_bar_string)
4898 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4899 (get_specified_cursor_type):
4900 Check that fixnums are in proper range for system types.
4901 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4902 (Flookup_image_map):
4903 Don't assume fixnums fit in int.
4904 (compare_overlay_entries):
4905 Avoid mishandling comparisons due to subtraction overflow.
4906 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4907 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4908 (handle_tool_bar_click):
4909 Use int, not unsigned, since we prefer signed and the signedness
4910 doesn't matter here.
4911 (get_next_display_element, next_element_from_display_vector):
4912 Use int, not EMACS_INT, when int is wide enough.
4913 (start_hourglass): Use duration_to_sec_usec to do proper
4914 overflow checking on durations.
4915 * xfaces.c (Fbitmap_spec_p):
4916 Check that fixnums are in proper range for system types.
4917 (compare_fonts_by_sort_order):
4918 Avoid mishandling comparisons due to subtraction overflow.
4919 (Fx_family_fonts, realize_basic_faces):
4920 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4921 (Fx_family_fonts):
4922 Don't assume fixnum fits in int.
4923 Use SAFE_ALLOCA_LISP, not alloca.
4924 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4925 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4926 (face_at_buffer_position, face_for_overlay_string)
4927 (face_at_string_position):
4928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4929 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4930 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4931 (Fx_show_tip):
4932 Check that fixnums are in proper range for system types.
4933 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4934 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4936 (Fx_change_window_property): Don't assume fixnums fit in int.
4937 * xfont.c (xfont_chars_supported):
4938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4939 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4940 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4942 * xml.c (parse_region):
4943 * xrdb.c (magic_file_p):
4944 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4945 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4946 (x_get_local_selection, x_reply_selection_request)
4947 (x_handle_selection_request, wait_for_property_change):
4948 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4949 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4950 short is wide enough.
4951 (x_send_client_event): Don't assume fixnum fits in int.
4952 * xterm.c (x_x_to_emacs_modifiers):
4953 Don't assume EMACS_INT overflows nicely into int.
4954 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4955 may come from Lisp.
4956 (handle_one_xevent): NATNUMP can eval its arg twice.
4957 (x_connection_closed):
4958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4959 * xterm.h: Adjust decls to match defn changes elsewhere.
4960 (struct scroll_bar): Use struct vectorlike_header
4961 rather than rolling our own approximation.
4962 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4963
c6574eb5
GM
49642012-05-25 Glenn Morris <rgm@gnu.org>
4965
4966 * lisp.mk (lisp): Update for more files being compiled now.
4967
e8d32c7e
SM
49682012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4969
48def666
SM
4970 * lread.c: Remove `read_pure' which makes no difference.
4971 (read_pure): Remove var.
4972 (unreadpure): Remove function.
4973 (readevalloop): Don't call read_list with -1 flag.
4974 (read1, read_vector): Don't test read_pure any more.
4975 (read_list): Simplify.
4976
e8d32c7e
SM
4977 * fileio.c, character.h: Minor style tweaks.
4978
4b2addb7
DA
49792012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4980
4981 * window.h (clip_changed): Remove useless declaration.
4982
584461b2
JB
49832012-05-22 Juanma Barranquero <lekktu@gmail.com>
4984
4985 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4986 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4987
34374650
PE
49882012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4989
4990 Remove src/m/*.
4991 This directory predates autoconf and is no longer needed nowadays.
4992 Move its few remaining bits of functionality to where they're needed.
4993 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4994 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4995 * m/template.h: Remove.
4996 * Makefile.in (M_FILE): Remove. All uses removed.
4997 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4998 * lisp.h (USE_LSB_TAG):
4999 * mem-limits.h (EXCEEDS_LISP_PTR):
5000 Use VAL_MAX, not VALBITS, in #if.
5001 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
5002 (EMACS_UINT): Define unconditionally now.
5003 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
5004 (BITS_PER_EMACS_INT): New constants, replacing
5005 what used to be in config.h, but not useful in #if.
5006 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
5007 define them any more.
5008 (VAL_MAX): New macro.
5009 (VALMASK): Use it.
5010 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
5011 BITS_PER_EMACS_INT, in #if.
5012 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
5013 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
5014 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
5015 * s/ms-w32.h (DATA_START):
5016 Move here from removed file m/intel386.h.
5017 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
5018 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
5019
261cb4bb
PE
50202012-05-21 Paul Eggert <eggert@cs.ucla.edu>
5021
5022 Assume C89 or later.
5023 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
5024 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
5025 (xrealloc):
5026 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
5027 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
5028 * textprop.c, tparam.c (NULL): Remove.
5029 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
5030 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
5031 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
5032 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
5033 * xterm.c (input_signal_count): Assume volatile works.
5034
ff23cd9f
KB
50352012-05-21 Ken Brown <kbrown@cornell.edu>
5036
5037 * xgselect.c (xg_select): Fix first argument in call to 'select'
5038 (bug#11508).
5039
1b170bc6
KB
50402012-05-20 Ken Brown <kbrown@cornell.edu>
5041
5042 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 5043 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 5044
b2f4d39f
KB
50452012-05-19 Ken Brown <kbrown@cornell.edu>
5046
5047 * xfns.c (x_in_use): Remove `static' qualifier.
5048 * xterm.h (x_in_use): Declare.
5049 * xgselect.c: Include xterm.h.
5050 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
5051 and `display_arg' (bug#9754).
5052
003fdae2
PE
50532012-05-19 Paul Eggert <eggert@cs.ucla.edu>
5054
9232a6d9
PE
5055 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
5056
003fdae2
PE
5057 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
5058 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
5059
784b56e2
EZ
50602012-05-18 Eli Zaretskii <eliz@gnu.org>
5061
5062 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
5063
5064 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 5065 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
5066
5067 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
5068 reference to image_cache->refcount.
5069 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
5070
a0a79cde
JL
50712012-05-17 Juri Linkov <juri@jurta.org>
5072
5073 * search.c (Fword_search_regexp, Fword_search_backward)
5074 (Fword_search_forward, Fword_search_backward_lax)
5075 (Fword_search_forward_lax): Move functions to isearch.el
5076 (bug#10145, bug#11381).
5077
b0572523
PE
50782012-05-16 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
5081
9660f5fc
SM
50822012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
5083
5084 * lread.c (init_obarray): Declare Qt and Qnil as special.
5085
4374de83
GM
50862012-05-14 Glenn Morris <rgm@gnu.org>
5087
5088 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 5089 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 5090
dc44c39a
PE
50912012-05-14 Paul Eggert <eggert@cs.ucla.edu>
5092
078c97cb
PE
5093 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
5094
dc44c39a
PE
5095 * unexaix.c: Port to more-recent AIX compilers.
5096 (report_error, report_error_1, make_hdr, copy_sym)
5097 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
5098 Make arguments const char *, not char *, to avoid violations of C
5099 standard and to fix some AIX warnings reported by Gilles Pion.
5100
e18afed7 51012012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5102
5103 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5104 already have overlays loaded.
5105 (handle_single_display_spec): Before returning without displaying
5106 fringe bitmap, synchronize the bidi iterator with the main display
5107 iterator, by calling iterate_out_of_display_property.
5108 (iterate_out_of_display_property): Detect buffer iteration by
5109 testing that it->string is a Lisp string.
5110 (get_next_display_element): When the current object is exhausted,
5111 and there's something on it->stack, call set_iterator_to_next to
5112 proceed with what's on the stack, instead of returning zero.
5113 (set_iterator_to_next): If called at the end of a Lisp string,
5114 proceed to consider_string_end without incrementing string
5115 position. Don't increment display vector index past the end of
5116 the display vector. (Bug#11417)
c8fb9dc6
EZ
5117 (pos_visible_p): Don't report a position visible when move_it_to
5118 stopped at the last line of window, which happens to be scanned
5119 backwards by the bidi iteration. (Bug#11464)
ac268e67 5120
e18afed7 51212012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5122
5123 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5124 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5125 are on a TTY, and thus unable to display on the fringes.
5126 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5127 so we need to signal to the caller that this is a "replacing"
5128 display spec. This fixes display when the spec is invalid or we
5129 are on a TTY.
5130
e18afed7 51312012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5132
5133 * unexaix.c (make_hdr): Fix typo in prototype.
5134 This bug broke the build on AIX. Problem reported by Gilles Pion.
5135
9d0a235a
MA
51362012-05-14 Michael Albinus <michael.albinus@gmx.de>
5137
5138 * keyboard.c (kbd_buffer_get_event): Read special events also in
5139 batch mode. (Bug#11415)
5140
9e6b06ed
GM
51412012-05-12 Glenn Morris <rgm@gnu.org>
5142
5143 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5144
c1a1d7a3
EZ
51452012-05-12 Eli Zaretskii <eliz@gnu.org>
5146
5147 * lisp.mk (lisp): Add newcomment.elc.
5148
3fe7cdc8
GM
51492012-05-12 Glenn Morris <rgm@gnu.org>
5150
5151 * Makefile.in (MKDIR_P): New, set by configure.
5152 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5153
53f7d2c0
PE
51542012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5155
5156 Remove unused function hourglass_started.
5157 * dispextern.h (hourglass_started):
5158 * w32fns.c (hourglass_started):
5159 * xdisp.c (hourglass_started): Remove.
5160
75aafb17
JB
51612012-05-10 Juanma Barranquero <lekktu@gmail.com>
5162
5163 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5164 Update dependencies.
5165
12959e8e
PE
51662012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5167
97107e2e
PE
5168 * xgselect.c (xg_select): Put maxfds+1 into a var.
5169 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5170
12959e8e
PE
5171 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5172
836d29b3
DA
51732012-05-10 Dave Abrahams <dave@boostpro.com>
5174
5175 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5176 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5177
5cb67954
MA
51782012-05-09 Michael Albinus <michael.albinus@gmx.de>
5179
5180 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5181 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5182 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5183 Initialize xd_registered_buses.
5184
3478ec45
PE
51852012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5186
b263a6b0
PE
5187 Untag more efficiently if USE_LSB_TAG.
5188 This is based on a proposal by YAMAMOTO Mitsuharu in
5189 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5190 For an admittedly artificial (nth 8000 longlist) benchmark on
5191 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5192 Emacs's overall text size by 1%.
5193 * lisp.h (XUNTAG): New macro.
5194 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5195 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5196 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5197 * eval.c (Fautoload):
5198 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5199 * frame.h (XFRAME): Use XUNTAG.
5200
3478ec45
PE
5201 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5202 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5203 Remove unportable assumptions about print widths of types like
5204 dbus_uint32_t.
5205 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5206 intptr_t when converting between pointer and integer, to avoid GCC
5207 warnings about wrong width.
5208
666b903b 52092012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5210
5211 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5212 stack for each reader_thread, instead of defaulting to 8MB
5213 determined by the linker. This avoids failures in creating
5214 subprocesses on Windows 7, see the discussion in this thread:
5215 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5216
b120cc17
JC
52172012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5218
5219 Fix up display of the *Minibuf-0* buffer in the mini window.
5220 * keyboard.c (read_char): Don't clear the echo area if there's no
5221 message to clear.
5222 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5223 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5224
9a4b36f8
MA
52252012-05-07 Michael Albinus <michael.albinus@gmx.de>
5226
5227 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5228 batch mode.
5229
e5f9458f
CY
52302012-05-06 Chong Yidong <cyd@gnu.org>
5231
5232 * lisp.mk (lisp): Update.
5233
eceeb5fc 52342012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5235
5236 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5237
71873e2b
SM
52382012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5239
5240 * data.c (PUT_ERROR): New macro.
5241 (syms_of_data): Use it. Add new error type `user-error'.
5242 * undo.c (user_error): New function.
5243 (Fprimitive_undo): Use it.
5244 * print.c (print_error_message): Adjust print style for `user-error'.
5245 * keyboard.c (user_error): New function.
5246 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5247
ab0fa4e4
PE
52482012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5249
5250 Do not limit current-time-string to years 1000..9999.
5251 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5252 (Fcurrent_time_string): Support any year that is supported by the
5253 underlying localtime representation. Don't use asctime, as it
5254 has undefined behavior for years outside the range -999..9999.
5255
7ed806a7
PE
52562012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5257
5258 Fix race conditions involving setenv, gmtime, localtime, asctime.
5259 Without this fix, interrupts could mess up code that uses these
5260 nonreentrant functions, since setting TZ invalidates existing
5261 tm_zone or tzname values, and since most of these functions return
5262 pointers to static storage.
5263 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5264 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5265 Grow the critical sections to include not just invoking
5266 localtime/gmtime, but also accessing these functions' results
5267 including their tm_zone values if any, and any related TZ setting.
5268 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5269 so that the struct tm is saved in the critical section.
5270 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5271 motivated by the fact that memory allocation needs to be outside
5272 the critical section.
5273
0c16dfed
DA
52742012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5275
5276 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5277 with RESET_INTERVAL.
5278
5279 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5280 Remove duplicated buffer name initialization.
5281
3f83ace8
JM
52822012-05-02 Jim Meyering <jim@meyering.net>
5283
5284 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5285
c7b8541e
JM
5286 * xfns.c (x_window): Use xstrdup (Bug#11375).
5287
90207a15 52882012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5289
5290 * xdisp.c (pos_visible_p): If already at a newline from the
5291 display string before the 'while' loop, don't walk back the glyphs
5292 from it3.glyph_row. Solves assertion violation when the display
5293 string begins with a newline (egg.el). (Bug#11367)
5294
b593d6a9
AH
52952012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5296
5297 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5298 Move to simple.el.
5299
4737362e
GM
53002012-05-01 Glenn Morris <rgm@gnu.org>
5301
99cf43f9
GM
5302 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5303 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5304 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5305 All were removed before 23.1.
5306
9311dcff
GM
5307 * dispnew.c: Remove HAVE_LIBNCURSES test;
5308 it is always true on relevant platforms.
5309
4d5c6349
GM
5310 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5311 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5312
4737362e
GM
5313 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5314
74dd3a6b
AS
53152012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5316
5317 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5318 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5319 Remove.
5320
13c379ee
PE
53212012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5322
5323 Do not avoid creating empty evaporating overlays (Bug#9642).
5324 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5325 That is, do not delete an evaporating overlay if it becomes
5326 empty after its bounds are adjusted to fit within its buffer.
5327 This fix caused other problems, and I'm reverting it until we get
5328 to the bottom of them.
5329
a8e7d6d7 53302012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5331
5332 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5333
a8e7d6d7 53342012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5335
5336 * xdisp.c (pos_visible_p): If the window start position is beyond
5337 ZV, start the display from buffer beginning. Prevents assertion
5338 violation in init_iterator when the minibuffer window is scrolled
5339 via the scroll bar.
5340
5341 * window.c (window_scroll_pixel_based): Likewise.
5342
a8e7d6d7 53432012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5344
5345 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5346
a8e7d6d7 53472012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5348
5349 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5350 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5351
a8e7d6d7 53522012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5353
b593d6a9
AH
5354 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5355 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5356
1c6900d9
EZ
53572012-04-26 Eli Zaretskii <eliz@gnu.org>
5358
4c3fa1d9
EZ
5359 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5360 display element, check also the underlying string or buffer
5361 character. (Bug#11341)
5362
1c6900d9
EZ
5363 * w32menu.c: Include w32heap.h.
5364 (add_menu_item): If the call to AppendMenuW (via
5365 unicode_append_menu) fails, disable Unicode menus only if we are
5366 running on Windows 9X/Me.
5367
42bf8205
AS
53682012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5369
5370 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5371 (xgetint): Add missing shift for LSB tags.
5372
b1bac16e
MR
53732012-04-24 Martin Rudalics <rudalics@gmx.at>
5374
5375 * keyboard.c (read_char): Don't wipe echo area for select window
5376 events: These might get delayed via `mouse-autoselect-window'
5377 (Bug#11304).
5378
d69621cc
JB
53792012-04-24 Juanma Barranquero <lekktu@gmail.com>
5380
5381 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5382 manipulation of :loaded-from data.
5383
02fd101b
JB
53842012-04-23 Juanma Barranquero <lekktu@gmail.com>
5385
5386 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5387 now a cons (bug#11311).
5388
888bec30
PE
53892012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5390
89a438bd
PE
5391 Do not create empty overlays with the evaporate property (Bug#9642).
5392 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5393 if it becomes empty after its bounds are adjusted to fit within
5394 its buffer. Without this fix, in a nonempty buffer (let ((o
5395 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5396 yields an empty overlay that has the evaporate property, which is
5397 not supposed to happen.
5398
1068fe4d
PE
5399 Fix minor GTK3 problems found by static checking.
5400 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5401 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5402 (struct _EmacsFixedClass, emacs_fixed_get_type):
5403 Move decls here from emacsgtkfixed.h, since they needn't be public.
5404 (emacs_fixed_get_type): Now static.
5405 (emacs_fixed_class_init): Omit unused local.
5406 (emacs_fixed_child_type): Remove; unused.
5407 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5408 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5409 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5410 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5411 (EMACS_FIXED_GET_CLASS): Remove; unused.
5412 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5413
888bec30
PE
5414 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5415 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5416
de85e130
PE
54172012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5418
d0baac98 5419 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5420 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5421 (__malloc_size_t, __malloc_ptrdiff_t):
5422 Remove. All uses removed, replaced by the definiens if needed,
5423 since we can assume C89 or better now.
5424 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5425 (protect_malloc_state, align, get_contiguous_space)
5426 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5427 (malloc_atfork_handler_child, malloc_enable_thread)
5428 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5429 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5430 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5431 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5432 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5433 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5434 Define using prototypes, not old style.
5435 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5436 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5437 (align): Don't assume that signed integer overflow wraps around.
5438 Omit unused local var.
5439 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5440 (_free_internal_nolock, memalign, mallochook, reallochook):
5441 Omit no-longer-needed casts.
5442 (valloc): Use getpagesize, not __getpagesize.
5443 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5444 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5445
de85e130
PE
5446 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5447
dcbf5805
MA
54482012-04-22 Michael Albinus <michael.albinus@gmx.de>
5449
5450 Move functions from C to Lisp. Make non-blocking method calls
5451 the default. Implement further D-Bus standard interfaces.
5452
5453 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5454 (QCdbus_request_name_allow_replacement)
5455 (QCdbus_request_name_replace_existing)
5456 (QCdbus_request_name_do_not_queue)
5457 (QCdbus_request_name_reply_primary_owner)
5458 (QCdbus_request_name_reply_in_queue)
5459 (QCdbus_request_name_reply_exists)
5460 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5461 (QCdbus_registered_serial, QCdbus_registered_method)
5462 (QCdbus_registered_signal): New Lisp objects.
5463 (XD_DEBUG_MESSAGE): Use sizeof.
5464 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5465 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5466 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5467 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5468 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5469 (xd_signature, xd_append_arg): Allow float for integer types.
5470 (xd_get_connection_references): New function.
b593d6a9
AH
5471 (xd_get_connection_address): Rename from xd_initialize.
5472 Return cached address.
dcbf5805
MA
5473 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5474 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5475 level.
5476 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5477 Return number of refcounts.
dcbf5805
MA
5478 (Fdbus_get_unique_name): Make stronger parameter check.
5479 (Fdbus_message_internal): New defun.
5480 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5481 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5482 (Fdbus_send_signal, Fdbus_register_service)
5483 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5484 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5485 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5486 (Vdbus_compiled_version, Vdbus_runtime_version)
5487 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5488 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5489 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5490 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5491 Adapt docstring.
dcbf5805 5492
52828e02
PE
54932012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5494
da05bc4c
PE
5495 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5496 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5497 Do not assume ptrdiff_t is the same width as 'int'.
5498
52828e02
PE
5499 * alloc.c: Handle unusual debugging option combinations.
5500 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5501 since the two debugging options are incompatible.
5502 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5503 is defined.
5504 (mem_init, mem_insert, mem_insert_fixup):
5505 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5506 (NEED_MEM_INSERT): Remove; no longer needed.
5507
f01769f9
LL
55082012-04-22 Leo Liu <sdl.web@gmail.com>
5509
5510 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5511
5790543d
PE
55122012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5513
5514 * sysdep.c [__FreeBSD__]: Minor cleanups.
5515 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5516 Use Emacs indenting style more consistently. Avoid some casts.
5517 Use 'double' consistently rather than mixing 'float' and 'double'.
5518
b91b7e4d
EW
55192012-04-21 Eduard Wiebe <usenet@pusto.de>
5520
b593d6a9
AH
5521 * sysdep.c (list_system_processes, system_process_attributes):
5522 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5523
6114eb15
AS
55242012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5525
5526 * lisp.mk (lisp): Update.
5527
2f38dff7
PE
55282012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5529
5530 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5531 It is never used otherwise.
5532
4ae29f89
SM
55332012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5534
5535 * print.c (print_preprocess): Only check print_depth if print-circle
5536 is nil.
5537 (print_object): Check for cycles even when print-circle is nil and
5538 print-gensym is t, but only check print_depth if print-circle is nil.
5539
f30d612a
CY
55402012-04-20 Chong Yidong <cyd@gnu.org>
5541
5542 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5543 set the status to "failed" and ensure that sentinel is run.
5544
c07a4c0b 55452012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5546
5547 * process.c (Fset_process_inherit_coding_system_flag)
5548 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5549 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5550
c07a4c0b 55512012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5552
5553 * xdisp.c (string_buffer_position_lim): Limit starting position to
5554 BEGV.
5555 (set_cursor_from_row): If called for a mode-line or header-line
5556 row, return zero immediately.
5557 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5558 farther than the first row after the header line, if any.
5559 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5560 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5561
c07a4c0b 55622012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5563
4ae29f89
SM
5564 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5565 (bug#11238).
ad3a2b41 5566
c07a4c0b 55672012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 55682012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5569
5570 configure: new option --enable-gcc-warnings (Bug#11207)
5571 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5572 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5573 (ALL_CFLAGS): Use new macros rather than old.
5574 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5575 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5576 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5577 -Wunused-result, -Wunused-variable. This should go away once
5578 the Emacs and Gnulib regex code is merged.
5579 (xmalloc, xrealloc): Now static.
5580
aba027e8
PE
55812012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * dired.c (Fsystem_groups): Remove unused local.
5584
e5a36063
GM
55852012-04-17 Glenn Morris <rgm@gnu.org>
5586
5587 * dired.c (Fsystem_users): Doc fix.
5588
316411f0
DA
55892012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5590
5591 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5592 (syms_of_dired): Add them.
5593
9426aba4
PE
55942012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5595
b62a57be
PE
5596 Fix minor alloc.c problems found by static checking.
5597 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5598 New extern decls, to avoid calling undeclared functions.
5599 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5600 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5601 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5602 (NEED_MEM_INSERT): New macro.
5603 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5604 Remove one incorrect comment and fix another.
b62a57be 5605
3539f31f
PE
5606 Fix minor ralloc.c problems found by static checking.
5607 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5608 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5609 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5610 (r_alloc_sbrk): Now static.
5611
a041960a
PE
5612 Improve ralloc.c interface checking.
5613 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5614 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5615 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5616 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5617 [REL_ALLOC]: ... to here, to check interface.
5618 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5619 Remove decls. This fixes an "It stinks!".
5620
9426aba4
PE
5621 * alloc.c (which_symbols): Fix alignment issue / type clash.
5622
d55c12ed
AS
56232012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5624
5625 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5626 (struct Lisp_Misc_Any): Likewise.
5627 (struct Lisp_Free): Likewise.
5628 * alloc.c (union aligned_Lisp_Symbol): Define.
5629 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5630 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5631 (union aligned_Lisp_Misc): Define.
5632 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5633 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5634 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5635
b948ce8b
PE
56362012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5637
5638 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5639 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5640 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5641 * s/netbsd.h, s/sol2-6.h:
5642 Remove definition of GC_MARK_STACK, since the default now works.
5643 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5644 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5645 no longer the default.
5646 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5647
35dc09a1 56482012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5649
35dc09a1
GM
5650 * lread.c (lisp_file_lexically_bound_p):
5651 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5652
35dc09a1
GM
56532012-04-14 Eli Zaretskii <eliz@gnu.org>
5654
5655 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5656 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5657
56582012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5659
5660 * nsterm.m (constrainFrameRect): Always constrain when there is only
5661 one screen (Bug#10962).
5662
bcd86815
KB
56632012-04-13 Ken Brown <kbrown@cornell.edu>
5664
5665 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5666
c25df26e
RT
56672012-04-13 Reuben Thomas <rrt@sc3d.org>
5668
5669 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5670
0fc59f1e
DC
56712012-04-11 Daniel Colascione <dancol@dancol.org>
5672
5673 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5674 against is gone. It's better to use vfork now so that when Cygwin
5675 gains a new, working vfork, we use it automatically (bug#10398).
5676
de8c03dc
SM
56772012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5678
5679 * window.c (save_window_save): Obey window-point-insertion-type.
5680
2f097256
GM
56812012-04-11 Glenn Morris <rgm@gnu.org>
5682
5683 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5684
453b951e
SM
56852012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5686
5687 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5688
75f1671a 56892012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5690
5691 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5692 (force_quit_count): New var.
5693 (handle_interrupt): Use it.
5694
2a8ce227
JB
56952012-04-10 Juanma Barranquero <lekktu@gmail.com>
5696
5697 * w32.c (w32_delayed_load): Record the full path of the library
5698 being loaded (bug#10424).
5699
935396c0
GM
57002012-04-09 Glenn Morris <rgm@gnu.org>
5701
05920a43
GM
5702 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5703 not just in the obarray, before snarfing them. (Bug#11036)
5704
935396c0
GM
5705 * Makefile.in ($(leimdir)/leim-list.el):
5706 Pass EMACS rather than BUILT_EMACS.
5707
a18ecafa
TZ
57082012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5709
5710 * process.c (make_process):
5711 * process.h: Add integer `gnutls_handshakes_tried' member to
5712 process struct.
5713
6bbef4e5
JC
5714 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5715 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5716
5717 * gnutls.c (gnutls_log_function2i): Convenience log function.
5718 (emacs_gnutls_read): Use new log functions,
5719 `gnutls_handshakes_tried' process member, and
5720 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5721 attempts per process (connection).
5722
b4d3bc10
CY
57232012-04-09 Chong Yidong <cyd@gnu.org>
5724
5725 * eval.c (Fuser_variable_p, user_variable_p_eh)
5726 (lisp_indirect_variable): Functions deleted.
5727 (Fdefvar): Caller changed.
5728
5729 * callint.c (Finteractive, Fcall_interactively):
5730 * minibuf.c (Fread_variable): Callers changed.
5731
70f4d973
EZ
57322012-04-09 Eli Zaretskii <eliz@gnu.org>
5733
5734 * xdisp.c (set_cursor_from_row): If the display string appears in
5735 the buffer at position that is closer to point than the position
5736 after the display string, display the cursor on the first glyph of
5737 the display string. Fixes cursor display when a 'display' text
5738 property immediately follows invisible text. (Bug#11094)
5739
cb3c2e3e
PE
57402012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5741
5742 composite.c: use 'double' consistently
5743 * composite.c (get_composition_id): Use 'double' consistently
5744 instead of converting 'float' to 'double' and vice versa; this is
5745 easier to understand and avoids a GCC warning.
5746
fd06db5d
GM
57472012-04-09 Glenn Morris <rgm@gnu.org>
5748
50fe702a
GM
5749 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5750 preparation for dumping it with emacs. (Bug#4789)
5751 (leimdir): New variable.
5752 ($(leimdir)/leim-list.el): New rule.
5753 (emacs$(EXEEXT)): Depend on leim-list.el.
5754
fd06db5d
GM
5755 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5756 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5757 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5758
55c131ee
AS
57592012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5760
5761 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5762 proper alignment.
5763
9209588f
JB
57642012-04-07 Juanma Barranquero <lekktu@gmail.com>
5765
5766 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5767 Remove unused local variable.
5768
e3fb2efb
PE
57692012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5772 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5773 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5774 objects, as mark_maybe_pointer will catch them otherwise.
5775 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5776 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5777
b5385551
PE
57782012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5779
5780 Fix typo that broke non-Windows builds.
5781 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5782
9078ead6
EZ
57832012-04-07 Eli Zaretskii <eliz@gnu.org>
5784
5785 Support building on MS-Windows with libxml2.
5786
5787 * makefile.w32-in (OBJ2): Add xml.$(O).
5788 (GLOBAL_SOURCES): Add xml.c.
5789 ($(BLD)/xml.$(O)): New dependency list.
5790
5791 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5792 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5793 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5794 [!WINDOWSNT]: New macros.
5795 (init_libxml2_functions, libxml2_loaded_p): New functions.
5796 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5797 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5798 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5799 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5800 linked in).
6bbef4e5
JC
5801 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5802 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5803 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5804
5805 * emacs.c: Don't include libxml/parser.h.
5806 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5807 xmlCleanupParser directly.
5808
5809 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5810
3811fdf3
EZ
58112012-04-07 Eli Zaretskii <eliz@gnu.org>
5812
5813 * indent.c (Fvertical_motion): If there is a display string at
5814 point, use it.vpos to compute how many lines to backtrack after
5815 move_it_to point. (Bug#11133)
5816
2f8e16b2
EZ
58172012-04-06 Eli Zaretskii <eliz@gnu.org>
5818
5819 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5820 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5821 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5822 macros related to unification of CJK characters. For the details,
5823 see the discussion following the message here:
5824 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5825
3d439cd1
CY
58262012-04-04 Chong Yidong <cyd@gnu.org>
5827
5828 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5829
8bc53d00
EZ
58302012-04-01 Eli Zaretskii <eliz@gnu.org>
5831
5832 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5833 instead of alloca. (Bug#11138)
5834
3b0512a3
AS
58352012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5836
5837 * w32menu.c (is_simple_dialog): Properly check lisp types.
5838 (Bug#11141)
5839
8427ddd2
EZ
58402012-03-31 Eli Zaretskii <eliz@gnu.org>
5841
979022ef
EZ
5842 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5843 position we get to after a call to move_it_to fails the
5844 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5845 only if we wind up in a string from display property. (Bug#11063)
5846
a6b1c7cc
EZ
5847 * window.c (Fdelete_other_windows_internal): Invalidate the row
5848 and column information about mouse highlight, so that redisplay
5849 restores it after reallocating the glyph matrices. (Bug#7464)
5850
8427ddd2
EZ
5851 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5852 string comes from a `display' text property, use the buffer
5853 position of that property as if we actually saw that position in
5854 the row's glyphs.
697ba24b
EZ
5855 (move_it_by_lines): Remove the assertion that
5856 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5857 violated when there's a before-string at the beginning of a line.
5858 (Bug#11063)
8427ddd2 5859
65a0a738
EZ
58602012-03-30 Eli Zaretskii <eliz@gnu.org>
5861
5862 * xdisp.c (append_space_for_newline): If the default face was
5863 remapped, use the remapped face for the appended newline.
5864 (extend_face_to_end_of_line): Use the remapped default face for
5865 extending the face to the end of the line.
5866 (display_line): Call extend_face_to_end_of_line when the default
5867 face was remapped. (Bug#11068)
5868
581355cc
EZ
58692012-03-29 Eli Zaretskii <eliz@gnu.org>
5870
5871 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5872
e8fc049f
SM
58732012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5874
5875 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5876
4fb9a543
GM
58772012-03-27 Glenn Morris <rgm@gnu.org>
5878
5879 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5880 Doc fixes.
5881
679910f1
KH
58822012-03-26 Kenichi Handa <handa@m17n.org>
5883
5884 * dispextern.h (struct glyph): Fix previous change. Change the
5885 bit length of glyphless.ch to 25 (Bug#11082).
5886
90d49b7f
CY
58872012-03-26 Chong Yidong <cyd@gnu.org>
5888
5889 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5890 (command_loop_1): Use it; inhibit selection update for
5891 handle-select-window too (Bug#8996).
5892
f514f6f0
FP
58932012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5894
e8fc049f 5895 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5896
bf43fa51
KH
58972012-03-25 Kenichi Handa <handa@m17n.org>
5898
5899 * dispextern.h (struct glyph): Change the bit length of
5900 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5901
8a0c01dd
EZ
59022012-03-24 Eli Zaretskii <eliz@gnu.org>
5903
5904 * s/ms-w32.h (tzname): Include time.h before redirecting to
5905 _tzname. Fixes the MSVC build. (Bug#9960)
5906
7d1c3a76
AS
59072012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5908
8ed79523
AS
5909 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5910 characters.
5911
7d1c3a76
AS
5912 * xterm.c (XTread_socket): Only modify handling_signal if
5913 !SYNC_INPUT. (Bug#11080)
5914
e99a9b8b
EZ
59152012-03-23 Eli Zaretskii <eliz@gnu.org>
5916
5917 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5918 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5919 when fetching a multibyte character consumes more bytes than
5920 CHAR_BYTES returns, due to unification of CJK characters in
5921 string_char. (Bug#11073)
5922
5063c0e1
TN
59232012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5924
5925 * process.c (wait_reading_process_output): Handle pty disconnect
5926 by refraining from sending oneself a SIGCHLD (bug#10933).
5927
9f851fbd
CY
59282012-03-22 Chong Yidong <cyd@gnu.org>
5929
5930 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5931
5063c0e1 5932 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5933 Mark string as coming from a prefix property.
5934 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5935 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5936
fb5b8aca
CY
59372012-03-21 Chong Yidong <cyd@gnu.org>
5938
5939 * xfaces.c (Vface_remapping_alist): Doc fix.
5940
62356a1b
EZ
59412012-03-20 Eli Zaretskii <eliz@gnu.org>
5942
5943 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5944 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5945 Doc fixes.
62356a1b 5946
025de85b
CY
59472012-03-20 Chong Yidong <cyd@gnu.org>
5948
5949 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5950 to reflect default non-nil value of redisplay-dont-pause.
5951
4827f94e
KH
59522012-03-19 Kenichi Handa <handa@m17n.org>
5953
5954 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5955 it fit in a valid range (Bug#11003).
5956
e50a24a2
EZ
59572012-03-18 Eli Zaretskii <eliz@gnu.org>
5958
5959 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5960 that is not from display property, accept the row as a "cursor
5961 row" if one of the string's character has a non-nil `cursor'
5962 property. Fixes cursor positioning when there are newlines in
5963 overlay strings, e.g. in icomplete.el. (Bug#11035)
5964
9af5ed87
PE
59652012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5966
5967 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5968
d1f55f16
CY
59692012-03-12 Chong Yidong <cyd@gnu.org>
5970
5971 * eval.c (inhibit_lisp_code): Rename from
5972 inhibit_window_configuration_change_hook; move from window.c.
5973
5974 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5975 * window.c (run_window_configuration_change_hook)
5976 (syms_of_window): Callers changed.
5977
66c5eebd
CY
59782012-03-11 Chong Yidong <cyd@gnu.org>
5979
413df973
CY
5980 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5981
66c5eebd
CY
5982 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5983
1de11f56
CY
59842012-03-10 Chong Yidong <cyd@gnu.org>
5985
5986 * frame.c (other_visible_frames): Don't assume the selected frame
5987 is visible (Bug#10955).
5988
cae07000
SM
59892012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5990
5991 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5992
89c94350
JD
59932012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5994
5995 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5996 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5997 zero (Bug#10954).
5998
999dd333
GM
59992012-03-03 Glenn Morris <rgm@gnu.org>
6000
01a6dcc8 6001 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 6002
de0100f2
EZ
60032012-03-02 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
6006 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
6007 (redisplay_window, next_element_from_string): Fix typos in
6008 comments.
3e441275
EZ
6009 (redisplay_window): Pass to move_it_vertically the margin in
6010 pixels, not in screen lines.
de0100f2 6011
96a72ee9
GM
60122012-03-02 Glenn Morris <rgm@gnu.org>
6013
6014 * buffer.c (buffer-list-update-hook): Doc fix.
6015
312508d7
EZ
60162012-02-29 Eli Zaretskii <eliz@gnu.org>
6017
6018 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
6019 push_it before setting up the iterator for the first overlay
6020 string, even if we have an empty string loaded.
6021 (next_overlay_string): If there's an empty string on the iterator
6022 stack, pop the stack. (Bug#10903)
6023
27f3c637
PE
60242012-02-25 Paul Eggert <eggert@cs.ucla.edu>
6025
6026 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
6027 Suggested by Stefan Monnier in
6028 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
6029 * alloc.c (widen_to_Lisp_Object): New static function.
6030 (mark_memory): Also mark Lisp_Objects by fetching pointer words
6031 and widening them to Lisp_Objects. This would work even if
6032 USE_LSB_TAG is defined and wide integers are used, which might
6033 happen in a future version of Emacs.
6034
3c9dfce6
CY
60352012-02-25 Chong Yidong <cyd@gnu.org>
6036
fa74b241
CY
6037 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
6038 Doc fix.
6039
3c9dfce6
CY
6040 * xselect.c (Fx_selection_exists_p): Doc fix.
6041 (x_clipboard_manager_save_all): Print an informative message
6042 before saving to clipboard manager.
6043
9486df08
CY
60442012-02-24 Chong Yidong <cyd@gnu.org>
6045
6046 * keyboard.c (process_special_events): Handle all X selection
6047 requests in kbd_buffer, not just the next one (Bug#8869).
6048
f01d3321
CY
60492012-02-23 Chong Yidong <cyd@gnu.org>
6050
6051 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
6052 call when setting menu-bar-lines and tool-bar-lines parameters.
6053 (unwind_create_frame_1): New helper function.
6054
6055 * window.c (inhibit_window_configuration_change_hook): New var.
6056 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 6057 (syms_of_window): Initialize it.
f01d3321 6058
86b847b6
CY
60592012-02-22 Chong Yidong <cyd@gnu.org>
6060
6061 * xterm.c (x_draw_image_relief): Add missing type check for
6062 Vtool_bar_button_margin (Bug#10743).
6063
a59225b1
CY
60642012-02-21 Chong Yidong <cyd@gnu.org>
6065
6066 * fileio.c (Vfile_name_handler_alist): Doc fix.
6067
6068 * buffer.c (Fget_file_buffer): Protect against invalid file
6069 handler return value.
6070
310f5bd4
PE
60712012-02-20 Paul Eggert <eggert@cs.ucla.edu>
6072
cb3a28cc
PE
6073 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
6074 when computing $valmask.
6075
310f5bd4
PE
6076 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
6077 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
6078 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
6079 It's useless in that case, and it can cause problems on hosts
6080 that allocate halves of EMACS_INT values separately.
6081 Reported by Dan Horák. Diagnosed by Andreas Schwab in
6082 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
6083 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
6084 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
6085 it avoids undefined behavior on hosts where shifting right by more
6086 than the word width has undefined behavior.
6087
2375c96a
CY
60882012-02-19 Chong Yidong <cyd@gnu.org>
6089
6090 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
6091 (Funhandled_file_name_directory, Ffile_name_as_directory)
6092 (Fdirectory_file_name, Fexpand_file_name)
6093 (Fsubstitute_in_file_name): Protect against invalid file handler
6094 return values (Bug#10845).
6095
3eb49e71
EZ
60962012-02-18 Eli Zaretskii <eliz@gnu.org>
6097
6098 * .gdbinit (pitx): Fix incorrect references to fields of the
6099 iterator stack.
6100
7b926f3f
CY
61012012-02-17 Chong Yidong <cyd@gnu.org>
6102
6103 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6104
11273115
PE
61052012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6106
6107 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6108 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6109
c3a70e2b
CY
61102012-02-15 Chong Yidong <cyd@gnu.org>
6111
6112 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6113 marked as special. Also, starting docstrings with * is obsolete.
6114
0ca43699
AS
61152012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6116
6117 * gnutls.c (emacs_gnutls_write): Fix last change.
6118
2e8f3c56
LI
61192012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6120
6121 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6122 send_process.
6123
af70074f
SM
61242012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6125
6126 * keymap.c (Fsingle_key_description): Handle char ranges.
6127
95986d52
CY
61282012-02-12 Chong Yidong <cyd@gnu.org>
6129
afd83bd1
CY
6130 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6131 as that creates a dangerous corner case.
6132
95986d52
CY
6133 * window.c (Fdelete_window_internal): Invalidate the mouse
6134 highlight (Bug#9904).
6135
bd7da63e
GM
61362012-02-12 Glenn Morris <rgm@gnu.org>
6137
6138 * xselect.c (Fx_own_selection_internal)
6139 (Fx_get_selection_internal, Fx_disown_selection_internal)
6140 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6141 * nsselect.m (Fx_own_selection_internal)
6142 (Fx_disown_selection_internal, Fx_selection_exists_p)
6143 (Fx_selection_owner_p, Fx_get_selection_internal):
6144 Sync docs and argument specs with the xselect.c versions.
6145
77abcbc2
LI
61462012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6147
6148 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6149
90b671e2
EZ
61502012-02-11 Eli Zaretskii <eliz@gnu.org>
6151
1c0ca0b7
EZ
6152 * w32select.c (Fx_selection_exists_p): Sync doc string and
6153 argument list with xselect.c. (Bug#10783)
6154
6155 * w16select.c (Fx_selection_exists_p): Sync doc string and
6156 argument list with xselect.c. (Bug#10783)
90b671e2 6157
49241268
GM
61582012-02-10 Glenn Morris <rgm@gnu.org>
6159
6160 * fns.c (Fsecure_hash): Doc fix.
6161
f998bbe7 61622012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6163
6164 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6165
0992bd9c
CY
61662012-02-07 Chong Yidong <cyd@gnu.org>
6167
6168 * buffer.c (Fbuffer_local_variables)
6169 (buffer_lisp_local_variables): Handle unbound vars correctly;
6170 don't let Qunbound leak into Lisp.
6171
af008560
GM
61722012-02-07 Glenn Morris <rgm@gnu.org>
6173
dd605cc4
GM
6174 * image.c (Fimagemagick_types): Doc fix.
6175
af008560
GM
6176 * image.c (imagemagick-render-type): Change it from a lisp object
6177 to an integer. Move the doc here from the lisp manual.
6178 Treat all values not equal to 0 the same.
6179
1449fa1d
CY
61802012-02-06 Chong Yidong <cyd@gnu.org>
6181
6182 * doc.c (store_function_docstring): Avoid applying docstring of
6183 alias to base function (Bug#2603).
6184
3723ec07
AS
61852012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6186
6187 * .gdbinit (pp1, pv1): Remove redundant defines.
6188 (pr): Use pp.
6189
79c1cc1e
CY
61902012-02-04 Chong Yidong <cyd@gnu.org>
6191
6192 * nsterm.m: Declare a global (Bug#10694).
6193
d7f29f8e
EZ
61942012-02-04 Eli Zaretskii <eliz@gnu.org>
6195
cae07000
SM
6196 * w32.c (get_emacs_configuration_options):
6197 Include --enable-checking, if specified, in the return value.
d7f29f8e 6198
3b95a6f9
MR
61992012-02-04 Martin Rudalics <rudalics@gmx.at>
6200
6201 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6202 after rounding frame sizes. (Bug#9723)
6203
d6fa96a6
EZ
62042012-02-04 Eli Zaretskii <eliz@gnu.org>
6205
6206 * keyboard.c (adjust_point_for_property): Don't position point
6207 before BEGV. (Bug#10696)
6208
df0b2940
PE
62092012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6210
6211 Handle overflow when computing char display width (Bug#9496).
6212 * character.c (char_width): Return EMACS_INT, not int.
6213 (char_width, c_string_width): Check for overflow when
6214 computing the width; this is possible now that individual
6215 characters can have unbounded width. Problem introduced
6216 by merge from Emacs 23 on 2012-01-19.
6217
6bee44d6
MA
62182012-02-02 Michael Albinus <michael.albinus@gmx.de>
6219
6220 * dbusbind.c (Fdbus_register_method): Mention the return value
6221 :ignore in the docstring.
6222
44f92739
GM
62232012-02-02 Glenn Morris <rgm@gnu.org>
6224
1b9f60cc
GM
6225 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6226
44f92739
GM
6227 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6228 Unconditionally set to t. (Bug#10673)
6229 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6230 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6231 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6232
c5d3843c
KH
62332012-02-02 Kenichi Handa <handa@m17n.org>
6234
6235 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6236 0, do not call append_composite_glyph.
6237
159462d4 62382012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6239
6240 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6241 NULL (Bug#6988).
6242 (x_produce_glyphs): If the component of a composition is a null
6243 string, set it->pixel_width to 1 to avoid zero-width glyph.
6244
78cef877
EZ
62452012-02-01 Eli Zaretskii <eliz@gnu.org>
6246
6247 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6248 first 2 arguments are identical. This makes inserting large
6249 output from a subprocess an order of magnitude faster on
6250 MS-Windows, where all sbrk'ed memory is always contiguous.
6251
97897668
GM
62522012-01-31 Glenn Morris <rgm@gnu.org>
6253
6254 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6255 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6256 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6257
31fd3586
GM
62582012-01-29 Glenn Morris <rgm@gnu.org>
6259
6260 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6261
0e24a8b2
CY
62622012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6263
6264 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6265
cc0adcb0
CY
62662012-01-28 Chong Yidong <cyd@gnu.org>
6267
6268 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6269
acc28cb9
CY
62702012-01-26 Chong Yidong <cyd@gnu.org>
6271
9c69cfb7
CY
6272 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6273
acc28cb9
CY
6274 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6275 repeat counts (Bug#10507).
6276
48da7392
GM
62772012-01-26 Glenn Morris <rgm@gnu.org>
6278
6279 * lread.c (syms_of_lread): Doc fix.
6280
14af5f7f
CY
62812012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6282
6283 * coding.c (encode_designation_at_bol): Change return value to
6284 EMACS_INT.
6285
0b21c100
CY
62862012-01-25 Chong Yidong <cyd@gnu.org>
6287
6288 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6289
3c2907f7
CY
62902012-01-21 Chong Yidong <cyd@gnu.org>
6291
6292 * floatfns.c (Fcopysign): Make the second argument non-optional,
6293 since nil is not allowed anyway.
6294
959ad23f
AS
62952012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6296
6297 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6298 (send_process): Likewise.
6299
34a02f46
MR
63002012-01-19 Martin Rudalics <rudalics@gmx.at>
6301
6302 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6303 (Vwindow_persistent_parameters): Do not use Qstate.
6304 Rewrite doc-strings.
34a02f46 6305
1259009a 63062012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6307
6308 * character.c (char_width): New function.
70d4fdf6
GM
6309 (Fchar_width, c_string_width, lisp_string_width):
6310 Use char_width (Bug#9496).
25ed9e61 6311
6a6ee00d
MR
63122012-01-16 Martin Rudalics <rudalics@gmx.at>
6313
6314 * window.c (Vwindow_persistent_parameters): New variable.
6315 (Fset_window_configuration, save_window_save): Handle persistent
6316 window parameters.
6317
c85efaf7
EZ
63182012-01-14 Eli Zaretskii <eliz@gnu.org>
6319
6320 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6321 thrashing the stack of the thread. (Bug#9087)
6322
5944709e
PE
63232012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6324
6325 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6326
e71f5d99
EZ
63272012-01-11 Eli Zaretskii <eliz@gnu.org>
6328
6329 * xdisp.c (rows_from_pos_range): Handle the case where the
6330 highlight ends on a newline. (Bug#10464)
6331 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6332 he end column for display of highlight that ends on a newline
6333 before a R2L line.
6334
ce316182
GM
63352012-01-11 Glenn Morris <rgm@gnu.org>
6336
6337 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6338 from load-path also when installation-directory is nil. (Bug#10208)
6339
5b43da69
GM
63402012-01-10 Glenn Morris <rgm@gnu.org>
6341
74cc8ff9
GM
6342 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6343
7d8d6e4e
GM
6344 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6345 Update template values to be closer to their typical values these days.
5b43da69 6346
a0db8d43
EZ
63472012-01-09 Eli Zaretskii <eliz@gnu.org>
6348
6349 * xdisp.c (rows_from_pos_range): Accept additional argument
6350 DISP_STRING, and accept any glyph in a row whose object is that
6351 string as eligible for mouse highlight. Fixes mouse highlight of
6352 display strings from overlays. (Bug#10464)
6353
9a0115ab 63542012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6355
b9110d6a 6356 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6357 * fileio.c (auto_saving_dir_umask): New static var.
6358 (Fmake_directory_internal): Use it.
6359 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6360 creating the directory. The old code temporarily assigns
6361 too-generous permissions to the directory.
6362 (do_auto_save_eh): Clear it.
b9110d6a 6363 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6364 that the var is always cleared.
6365
6c1bd3f3
EZ
63662012-01-07 Eli Zaretskii <eliz@gnu.org>
6367
6368 * search.c (scan_buffer): Pass character positions to
6369 know_region_cache, not byte positions. (Bug#6540)
6370
069d2b50
L
63712012-01-07 LynX <_LynX@bk.ru> (tiny change)
6372
6373 * w32.c (sys_rename): Report EXDEV when rename of a directory
6374 fails because the target is on another logical disk. (Bug#10284)
6375
75bf0d33
DB
63762012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6377
6378 * xterm.c (x_embed_request_focus): New function.
6379
6380 * xterm.h: Add prototype.
6381
6382 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6383
1c6e5a32
GM
63842012-01-05 Glenn Morris <rgm@gnu.org>
6385
6386 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6387
651e947e
EZ
63882012-01-01 Eli Zaretskii <eliz@gnu.org>
6389
6390 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6391 Load gnutls_transport_set_lowat only if GnuTLS version is below
6392 2.11.1.
6393 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6394 GnuTLS versions below 2.11.1.
6395
3778cdd8
AL
63962011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6397
6398 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6399 to the doc string advising against its use for altering the way
6400 windows are scrolled.
6401
0e5317f7
KH
64022011-12-28 Kenichi Handa <handa@m17n.org>
6403
6404 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6405 coding-system ASCII compatible only when it does not produce BOM
6406 on encoding (Bug#10383).
6407
93d5ca1f
JD
64082011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6409
6410 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6411 can scroll.
6412 (create_and_show_popup_menu): Always use menu_position_func for
6413 Gtk3 (Bug#10361).
6414
ca22b785
AS
64152011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6416
6417 * callint.c (Fcall_interactively): Don't truncate prompt string.
6418
d048e1e6
EZ
64192011-12-23 Eli Zaretskii <eliz@gnu.org>
6420
6421 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6422 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6423 resumed from there (after widening). (Bug#10360)
d048e1e6 6424
5ccaba1f
JD
64252011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6426
6427 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6428
204ee57f
JD
64292011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6430
b81d40f0
JB
6431 * nsterm.m (x_free_frame_resources):
6432 Release f->output_data.ns->miniimage.
204ee57f
JD
6433 (ns_index_color): Fix indentation. Do not retain
6434 color_table->colors[i].
6435
6436 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6437 before returning.
6438
6439 * nsfns.m (x_set_background_color): Assign return value from
6440 ns_index_color to face-background instead of NSColor*.
6441 (ns_implicitly_set_icon_type): Fix indentation.
6442 Change assignment in for loop to comparison.
6443
6444 * emacs.c (ns_pool): New variable.
6445 (main): Assign ns_pool.
6446 (Fkill_emacs): Call ns_release_autorelease_pool.
6447
6448 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6449 autorelease fdesc, release fdAttrs and tdict.
6450 (ns_get_covering_families): Release charset.
6451 (ns_findfonts): Release NSFontDescriptor created with new.
6452 (ns_uni_to_glyphs): Fix indentation.
6453 (setString): Release attrStr before assigning new value.
6454
c803b2b7
JD
64552011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6456
678f4426
JD
6457 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6458 and NS_IMPL_COCOA.
6459 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6460 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6461
cd394be1 64622011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6463
5fecd5fc
JD
6464 * nsterm.m (ns_term_init): Subscribe for notifications
6465 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6466 to method trackingNotification in EmacsMenu.
6467
6468 * nsmenu.m (trackingMenu): New variable.
3771cb17 6469 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6470 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6471 from Aquamacs (Bug#7030).
678f4426
JD
6472
64732011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6474
c803b2b7
JD
6475 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6476 (symbol_to_nsstring): Fix indentation.
6477 (ns_symbol_to_pb): New function.
cae07000
SM
6478 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6479 (Fns_rotate_cut_buffers_internal): Remove.
6480 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6481 Fns_store_cut_buffer_internal.
6482 (ns_get_foreign_selection, Fx_own_selection_internal)
6483 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6484 (Fns_get_selection_internal, Fns_store_selection_internal):
6485 Use ns_symbol_to_pb and check if return value is nil.
6486 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6487 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6488 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6489 renamed to Sns_store_selection_internal.
6490 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6491 and remove this function.
6492 (ns_handle_selection_clear): Remove, never used.
6493 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6494 here.
6495
e1b01a3a
KB
64962011-12-17 Ken Brown <kbrown@cornell.edu>
6497
6498 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6499 GID is unknown (Bug#10257).
6500
2adb6e85
PE
65012011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6504 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6505 which caused a build failure on GNU/Linux IA-64. This problem was
6506 introduced by my 2011-10-07 patch.
6507
d1d7b339
JL
65082011-12-15 Juri Linkov <juri@jurta.org>
6509
6510 * image.c (imagemagick_error): New function. (Bug#10112)
6511 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6512 Use `imagemagick_error' where ImageMagick functions return
6513 `MagickFalse'.
6514 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6515 proper order.
6516
100d5755
KH
65172011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6518
6519 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6520 fill background (Bug#8992).
6521
454592a6
MR
65222011-12-13 Martin Rudalics <rudalics@gmx.at>
6523
6524 * window.c (Vwindow_combination_resize)
6525 (Vwindow_combination_limit): Use t instead of non-nil in
6526 doc-strings.
61d4b438
MR
6527 (Vrecenter_redisplay): Add first sentence of doc-string on
6528 separate line.
53524d93 6529 (Frecenter): Fix doc-string typo.
454592a6 6530
3633e3aa
KH
65312011-12-11 Kenichi Handa <handa@m17n.org>
6532
6533 * coding.c (Funencodable_char_position): Pay attention to the
6534 buffer text relocation (Bug#9389).
6535
7b9d523a 65362011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6537
7b9d523a
JD
6538 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6539 gtk_init (Bug#10100).
6540
b73189c6
EZ
65412011-12-10 Eli Zaretskii <eliz@gnu.org>
6542
6543 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6544 IT->string is nil. (Bug#10263)
6545
f7dfe5d6
JD
65462011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6547
83faebb4
JD
6548 * nsterm.h (x_free_frame_resources): Declare.
6549
f7dfe5d6
JD
6550 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6551 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6552
6553 * nsterm.h (ns_get_defaults_value): Declare.
6554
6555 * nsterm.m (ns_default): Call ns_get_defaults_value.
6556
7cd4e72c
EZ
65572011-12-09 Eli Zaretskii <eliz@gnu.org>
6558
6559 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6560 (Bug#10170)
6561
b34d7317
YM
65622011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6563
6564 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6565 that where the value of an _OBJC_* symbol points to is in the .bss
6566 section (Bug#10240).
6567
76470ad1
KH
65682011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6569
6570 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6571 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6572
745fff94
KH
65732011-12-08 Kenichi Handa <handa@m17n.org>
6574
6575 * ftfont.c (get_adstyle_property): Fix previous change
6576 (Bug#10233).
6577
6e44397c
JB
65782011-12-07 Juanma Barranquero <lekktu@gmail.com>
6579
6580 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6581 dirs from the default value of EMACSLOADPATH (bug#10208).
6582
7efa6272
GM
65832011-12-07 Glenn Morris <rgm@gnu.org>
6584
6585 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6586 installation and source directories as well. (Bug#10208)
6587
f6fc4d87
CY
65882011-12-06 Chong Yidong <cyd@gnu.org>
6589
6590 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6591
2bf26180
GM
65922011-12-06 Glenn Morris <rgm@gnu.org>
6593
6594 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6595 as an error, not just -1. (Bug#10217)
6596
3a6ad4f0
CY
65972011-12-05 Chong Yidong <cyd@gnu.org>
6598
6599 * keyboard.c (process_special_events): New function.
6600 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6601
75a3b399
PE
66022011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6603
6604 * coding.c (encode_designation_at_bol): Don't use uninitialized
6605 local variable (Bug#9318).
6606
c3c9e25e
KH
66072011-12-05 Kenichi Handa <handa@m17n.org>
6608
6609 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6610 return Qnil (Bug#8046, Bug#10193).
6611
5eb05ea3
KH
66122011-12-05 Kenichi Handa <handa@m17n.org>
6613
6614 * coding.c (encode_designation_at_bol): New args charbuf_end and
6615 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6616 (coding_set_source): Return how many bytes coding->source was
6617 relocated.
6618 (coding_set_destination): Return how many bytes
6619 coding->destination was relocated.
6620 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6621 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6622
66232011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6624
6625 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6626 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6627 macro (Bug#9318).
6628
66292011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6630
6631 The following changes are to fix Bug#9318.
6632
a79703f5 6633 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6634 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6635 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6636 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6637
7dbda6df
JB
66382011-12-05 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * lisp.h (process_quit_flag): Fix external declaration.
6641
6d5eb5b0
SM
66422011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6643
6644 Don't macro-inline non-performance-critical code.
6645 * eval.c (process_quit_flag): New function.
6646 * lisp.h (QUIT): Use it.
6647
a0c3fad0
JD
66482011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6649
6650 * nsfns.m (get_geometry_from_preferences): New function.
6651 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6652
6c07aac2
AS
66532011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6654
6655 * emacs.c (Qkill_emacs): Define.
6656 (syms_of_emacs): Initialize it.
6657 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6658 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6659 (quit_throw_to_read_char): Add parameter `from_signal'.
6660 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6661 * lisp.h (QUIT): Call Fkill_emacs if requested.
6662
c052ead4
JD
66632011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6664
6665 * widget.c (update_wm_hints): Return if wmshell is null.
6666 (widget_update_wm_size_hints): New function.
6667
6668 * widget.h (widget_update_wm_size_hints): Declare.
6669
6670 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6671 widget_update_wm_size_hints (Bug#10104).
6672
9e49252b
EZ
66732011-12-03 Eli Zaretskii <eliz@gnu.org>
6674
6675 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6676 before a newline, prepare the bidi iterator for consuming the
6677 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6678 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6679
02b16839
JL
66802011-12-02 Juri Linkov <juri@jurta.org>
6681
6682 * search.c (Fword_search_regexp): New Lisp function created from
6683 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6684 (Fword_search_backward, Fword_search_forward)
6685 (Fword_search_backward_lax, Fword_search_forward_lax):
6686 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6687 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6688
0068070e
SM
66892011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6690
6691 * fileio.c (Finsert_file_contents): Move after-change-function call
6692 to before the "handled:" label, since all "goto handled" appear in
6693 cases where the *-change-functions have already been properly called
6694 (bug#10117).
6695
3360a3fc
AS
66962011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6697
6698 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6699 waiting for input. (Bug#10169)
6700
73d6c093
EZ
67012011-11-30 Eli Zaretskii <eliz@gnu.org>
6702
6703 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6704 verifies glyph row's hash code--we have just reallocated the
6705 glyphs, so their contents can be complete garbage. (Bug#10164)
6706
febe6bea
JB
67072011-11-30 Juanma Barranquero <lekktu@gmail.com>
6708
6709 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6710
801a4313
EZ
67112011-11-30 Eli Zaretskii <eliz@gnu.org>
6712
6713 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6714 attributes are tested _before_ calling verify_row_hash, to protect
6715 against GCC re-ordering of the tests. (Bug#10164)
6716
2b56b87e
JD
67172011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6718
6719 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6720
6721 * xterm.c (handle_one_xevent): Only set async_visible and friends
6722 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6723 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6724 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6725
dbf31225
PE
67262011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6727
6728 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6729 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6730 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6731 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6732 All uses changed to use GCPRO1 etc.
6733 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6734 Revert to old implementation (i.e., before 2011-03-11).
6735
1305621b
YM
67362011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6737
6738 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6739 of scroll runs so as to avoid assigning disabled bogus rows and
6740 unnecessary graphics copy operations.
6741
8c9afb46
EZ
67422011-11-27 Eli Zaretskii <eliz@gnu.org>
6743
6744 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6745 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6746 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6747 (malloc, free, realloc, calloc): Redirect to e_* only when
6748 compiling Emacs.
6749
6750 * lisp.h (GCTYPEBITS): Move before first use.
6751 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6752 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6753 this macro definition.
6754
6755 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6756 _MSC_VER.
6757
54e9e3bf
JD
67582011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6759
6d5eb5b0
SM
6760 * gtkutil.c (xg_create_frame_widgets):
6761 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6762 present with Gtk+ 2.0.
6763
83aca1cb
PE
67642011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6765
6766 * fileio.c (Finsert_file_contents): Undo previous change; see
6767 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6768
5b76caa4
PE
67692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6770
6771 Rename locals to avoid shadowing.
6772 * fileio.c (Finsert_file_contents):
6773 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6774 * process.c (wait_reading_process_output):
6775 Rename inner 'proc' to 'p' to avoid shadowing.
6776 Indent for consistency with usual Emacs style.
6777
8c535114
EZ
67782011-11-25 Eli Zaretskii <eliz@gnu.org>
6779
6780 * xdisp.c (redisplay_window): If cursor row is not fully visible
6781 after recentering, and scroll-conservatively is set to a large
6782 number, scroll window by a few more lines to make the cursor fully
6783 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6784 (start_display): Don't move to the next line if the display should
6785 start at a newline that is part of a display vector or an overlay
6786 string. (Bug#10119)
8c535114 6787
fa4fdb5c
JL
67882011-11-24 Juri Linkov <juri@jurta.org>
6789
6790 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6791 after the `MagickPingImage' call. (Bug#10112)
6792
90ec88df
CY
67932011-11-23 Chong Yidong <cyd@gnu.org>
6794
6795 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6796
56e2e794
MR
67972011-11-23 Martin Rudalics <rudalics@gmx.at>
6798
6799 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6800 making another buffer current. (Bug#10114)
6801
b6e64c41
GM
68022011-11-23 Glenn Morris <rgm@gnu.org>
6803
6804 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6805
6b21de18
CY
68062011-11-23 Chong Yidong <cyd@gnu.org>
6807
6808 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6809 using it (Bug#5984).
6810
b12cd789
EZ
68112011-11-22 Eli Zaretskii <eliz@gnu.org>
6812
6813 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6814 and header-lines, as they don't have one computed for them.
6815 (Bug#10098)
6816
6817 * .gdbinit (prow): Make displayed values more self-explaining.
6818 Add row's hash code.
6819
261b6fd4
LMI
68202011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6821
6822 * process.c (wait_reading_process_output): Fix asynchrounous
6823 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6824 (wait_reading_process_output): Add comment and URL.
261b6fd4 6825
e7cfd277
JD
68262011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6827
6828 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6829
a9b9b7f5
CY
68302011-11-21 Chong Yidong <cyd@gnu.org>
6831
6832 * window.c (Fnext_window, Fprevious_window): Doc fix.
6833
b0d15b4f
SM
68342011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6835
6836 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6837
fe7a3057
JB
68382011-11-20 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6841
d2999b1a
MR
68422011-11-20 Martin Rudalics <rudalics@gmx.at>
6843
6844 * window.c (Fset_window_combination_limit): Rename argument
6845 STATUS to LIMIT.
6846 (Vwindow_combination_limit): Remove "status" from doc-string.
6847
d5ff9cd0
AS
68482011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6849
6850 * m/ibms390.h: Remove.
6851 * m/ibms390x.h: Don't include "ibms390.h".
6852
a5bb9bd3
SM
68532011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6854
6855 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6856 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6857
cd1181db
JB
68582011-11-20 Juanma Barranquero <lekktu@gmail.com>
6859
6860 * casetab.c (Fset_case_table):
6861 * charset.c (Fcharset_after): Fix typos.
6862
615a3b8d 68632011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6864
17e845af
PE
6865 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6866 Otherwise, valgrind does not work on some platforms.
6867 Problem reported by Andreas Schwab in
6a0bf43d
PE
6868 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6869 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6870 is set, removing the need for VIRT_ADDRESS_VARIES.
6871 (PURE_P): Use a more-efficient implementation that needs just one
6872 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6873 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6874 to 4 (xorl, subq, cmpq, setbe).
6875 * alloc.c (pure): Always extern now, since that's the
6876 VIRT_ADDR_VARIES behavior.
6877 (PURE_POINTER_P): Use a single comparison, not two, for
6878 consistency with the new puresize.h.
6879 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6880 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6881 Remove VIRT_ADDR_VARIES no longer needed.
6882
f8fe6f96
EZ
68832011-11-19 Eli Zaretskii <eliz@gnu.org>
6884
6885 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6886 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6887 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6888 behave as if the cursor position were at the window margin.
6889
6890 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6891 and the cursor position is out of bounds, behave as if the cursor
6892 position were at the window margin. (Bug#10075)
6893
df05a53c
CY
68942011-11-18 Chong Yidong <cyd@gnu.org>
6895
6896 * window.c (Fwindow_combination_limit): Make first argument
6897 non-optional, since it is meaningless for live windows like the
6898 selected window.
61ccba97 6899
2071918e
DA
69002011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6901
6902 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6903
b50a28de
SM
69042011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6905
6906 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6907 (graft_intervals_into_buffer): Simplify.
6908
015137db
EZ
69092011-11-18 Eli Zaretskii <eliz@gnu.org>
6910
6911 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6912 hash values of the two rows.
6913 (copy_row_except_pointers): Preserve the used[] arrays and the
6914 hash values of the two rows. (Bug#10035)
68c95424 6915 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6916
6917 * xdisp.c (row_hash): New function, body extracted from
6918 compute_line_metrics.
6919 (compute_line_metrics): Call row_hash, instead of computing the
6920 hash code inline.
6921
6922 * dispnew.c (verify_row_hash): Call row_hash for computing the
6923 hash code of a row, instead of duplicating code from xdisp.c.
6924
6925 * dispextern.h (row_hash): Add prototype.
6926
a2addb04
TH
69272011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6928
6929 * frame.c (delete_frame): Don't delete the terminal when the last
6930 X frame is closed if emacs is built with GTK toolkit.
6931
df85d315
JB
69322011-11-17 Juanma Barranquero <lekktu@gmail.com>
6933
6934 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6935
a0c2d0ae
MR
69362011-11-17 Martin Rudalics <rudalics@gmx.at>
6937
6938 * window.c (Vwindow_splits): Rename to
6939 Vwindow_combination_resize. Suggested by Juri Linkov.
6940 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6941 of Vwindow_splits.
6942
58179cce
JB
69432011-11-16 Juanma Barranquero <lekktu@gmail.com>
6944
7877f373
JB
6945 * nsfns.m (Fns_font_name):
6946 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6947
b6f67890
MR
69482011-11-16 Martin Rudalics <rudalics@gmx.at>
6949
6950 * window.h (window): Rename slot "nest" to "combination_limit".
6951 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6952 (Fset_window_nest): Rename to Fset_window_combination_limit.
6953 (Vwindow_nest): Rename to Vwindow_combination_limit.
6954 (recombine_windows, make_parent_window, make_window)
6955 (Fsplit_window_internal, saved_window)
6956 (Fset_window_configuration, save_window_save): Rename all
6957 occurrences of window_nest to window_combination_limit.
6958
c7015153
JB
69592011-11-15 Juanma Barranquero <lekktu@gmail.com>
6960
6961 * image.c (imagemagick_load_image): Fix typo.
6962
322ad6ec
EZ
69632011-11-14 Eli Zaretskii <eliz@gnu.org>
6964
6965 * xdisp.c (display_line): Move the call to
6966 highlight_trailing_whitespace before the call to
6967 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6968 faces of all the glyphs to compute ROW's hash value.
6969 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6970
f067b8ec
JB
69712011-11-14 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6974 just return (bug#10044).
6975
1e5b2111
EZ
69762011-11-12 Eli Zaretskii <eliz@gnu.org>
6977
7ef3cbd5
EZ
6978 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6979 with user-defined heap size. Bump the default size of the temacs
6980 heap to 27MB, to avoid memory warning when running temacs.
6981 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6982
1e5b2111
EZ
6983 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6984 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6985 (verify_row_hash) [XASSERTS]: New function.
6986 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6987 that the hash value of glyph rows is correct.
1e5b2111 6988
89d61221
MR
69892011-11-12 Martin Rudalics <rudalics@gmx.at>
6990
6991 * window.h (window): Remove splits slot.
6992 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6993 (Fdelete_other_windows_internal, make_parent_window)
6994 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6995 (Fset_window_configuration, save_window_save): Don't deal with
6996 split status of windows.
6997 (saved_window): Remove splits slot.
6998 (Vwindow_splits): Rewrite doc-string.
6999
97f18cc8
JD
70002011-11-11 Jan Djärv <jan.h.d@swipnet.se>
7001
7002 * xfns.c (unwind_create_frame):
7003 * nsfns.m (unwind_create_frame):
7004 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
7005 Vframe_list (Bug#9999).
7006
22a648b4
DA
70072011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
7008
0b381c7e 7009 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 7010
659afede
KH
70112011-11-11 Kenichi Handa <handa@m17n.org>
7012
7013 * callproc.c (Fcall_process): Set the member dst_multibyte of
7014 process_coding.
7015
9ac0394b
KH
70162011-11-11 Johan Bockgård <bojohan@gnu.org>
7017
7018 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
7019 avoid a crash (bug#9496).
7020
2fbdc249
CY
70212011-11-09 Chong Yidong <cyd@gnu.org>
7022
7023 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
7024 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
7025
ac6b1f81
PE
70262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7027
7028 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
7029
09db192c
PE
70302011-11-08 Paul Eggert <eggert@cs.ucla.edu>
7031
7032 Avoid some portability problems by eschewing 'extern inline' functions.
7033 The trivial performance wins aren't worth the portability hassles; see
7034 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
7035 et seq.
7036 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7037 (window_box_width, window_box_left, window_box_left_offset)
7038 (window_box_right, window_box_right_offset): Undo previous change,
7039 by removing the "extern"s.
7040 * intervals.c (adjust_intervals_for_insertion)
7041 (adjust_intervals_for_deletion): Undo previous change,
7042 making these static again.
7043 (offset_intervals, temp_set_point_both, temp_set_point)
7044 (copy_intervals_to_string): No longer inline.
7045 * xdisp.c (window_text_bottom_y, window_box_width)
7046 (window_box_height, window_box_left_offset)
7047 (window_box_right_offset, window_box_left, window_box_right)
7048 (window_box): No longer inline.
7049
105216ed
CY
70502011-11-08 Chong Yidong <cyd@gnu.org>
7051
7052 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
7053 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
7054 Signal an error if not a live window.
105216ed
CY
7055 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
7056 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
7057
ae9e237f
JB
70582011-11-07 Juanma Barranquero <lekktu@gmail.com>
7059
7060 * lisp.h (syms_of_abbrev): Remove declaration.
7061 Reported by CHENG Gao <chenggao@royau.me>.
7062
c7aa8333
EZ
70632011-11-07 Eli Zaretskii <eliz@gnu.org>
7064
7065 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
7066 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
7067 of temacs in GUI mode.
7068
be7f5545
MR
70692011-11-07 Martin Rudalics <rudalics@gmx.at>
7070
7071 * window.h: Declare delete_all_child_windows instead of
7072 delete_all_subwindows.
7073 * window.c (Fwindow_nest, Fset_window_nest)
7074 (Fset_window_new_total, Fset_window_new_normal)
7075 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
7076 (delete_all_subwindows): Rename to delete_all_child_windows.
7077 (Fdelete_other_windows_internal, Fset_window_configuration):
7078 Call delete_all_child_windows instead of delete_all_subwindows.
7079 * frame.c (delete_frame): Call delete_all_child_windows instead
7080 of delete_all_subwindows.
7081
ca78dc43
PE
70822011-11-07 Paul Eggert <eggert@cs.ucla.edu>
7083
7084 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
7085 This is also needed for porting to any host where GC_MARK_STACK is
7086 not GC_MAKE_GCPROS_NOOPS.
7087 (which_symbols): Use it.
7088
a0241d01
KH
70892011-11-07 Kenichi Handa <handa@m17n.org>
7090
7091 * coding.c (coding_set_destination): Check coding->src_pos only
7092 when coding->src_object is a buffer (bug#9910).
7093
7094 * process.c (send_process): Set the member src_multibyte of coding
7095 to 0 (bug#9911) when sending a unibyte text.
7096
7097 * callproc.c (Fcall_process): Set the member src_multibyte of
7098 process_coding to 0 (bug#9912).
7099
a64bfdfa 71002011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7101
7102 * xmenu.c (cleanup_widget_value_tree): New function.
7103 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7104 calling free_menubar_widget_value_tree directly (Bug#9830).
7105
cb41b32a
PE
71062011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7107
7108 Fix some portability problems with 'inline'.
7109 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7110 (window_box_width, window_box_left, window_box_left_offset)
7111 (window_box_right, window_box_right_offset): Declare extern.
7112 Otherwise, these inline functions do not conform to C99 and
7113 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7114 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7115 * intervals.c (adjust_intervals_for_insertion)
7116 (adjust_intervals_for_deletion): Now extern, because otherwise the
7117 extern inline functions 'offset_intervals' couldn't refer to it.
7118 (static_offset_intervals): Remove.
7119 (offset_intervals): Rewrite using the old contents of
7120 static_offset_intervals. The old version didn't conform to C99
7121 because an extern inline function contained a reference to an
7122 identifier with static linkage.
7123
b7041366
AS
71242011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7125
7126 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7127 GC.
7128
88a37c4d
EZ
71292011-11-06 Eli Zaretskii <eliz@gnu.org>
7130
7131 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7132 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7133 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7134 return Qleft_to_right.
7135
49745b39
CY
71362011-11-06 Chong Yidong <cyd@gnu.org>
7137
7138 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7139 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7140 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7141 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7142 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7143 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7144 (Fwindow_vscroll): Doc fix.
7145 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7146 argument, since it makes no sense to pass a live window and for
7147 consistency with window-child.
7148
1f05cd82
CS
71492011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7150
7151 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7152 support MSVC.
7153
22610910
JR
71542011-11-05 Jason Rumney <jasonr@gnu.org>
7155
7156 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7157 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7158 fonts (Bug#6029).
7159 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7160 bitwise arithmetic preventing use of unicode-sip and non-truetype
7161 opentype fonts.
7162
a06776b2
EZ
71632011-11-05 Eli Zaretskii <eliz@gnu.org>
7164
3ad924ba
EZ
7165 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7166 "emacs"-only part.
7167
a06776b2
EZ
7168 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7169 initialization code to keep similarity to xfns.c after changes
7170 from 2011-11-05.
7171
c9e7db78
JD
71722011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7173
a97f8f3f
JD
7174 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7175 (unwind_create_frame): New function (Bug#9943).
7176 (Fx_create_frame): Restructure code to be more similar to the one in
7177 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7178 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7179 Move terminal->reference_count++ just before making the frame official
7180 (Bug#9943).
7181
7182 * nsterm.m (x_free_frame_resources): New function.
7183 (x_destroy_window): Move code to x_free_frame_resources.
7184
c9e7db78 7185 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7186 (Fx_create_frame, x_create_tip_frame):
7187 Move terminal->reference_count++ just before making the frame
75f1671a 7188 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7189 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7190
a6fc3b5c
EZ
71912011-11-05 Eli Zaretskii <eliz@gnu.org>
7192
7193 Support MSVC build with newer versions of Visual Studio.
7194 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7195 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7196 nt/gmake.defs.
7197
7198 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7199 which are not supported by MSVC.
7200 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7201 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7202 bitfields.
7203 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7204 types in bitfields.
7205 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7206
7207 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7208
58179cce 72092011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7210
7211 Support MSVC build with newer versions of Visual Studio.
7212 * w32.c: Don't include w32api.h for MSVC.
7213 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7214
7215 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7216 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7217 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7218 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7219 e_* cousins.
7220 (alloca) [_MSC_VER]: Define to _alloca.
7221
7222 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7223
7224 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7225
a58c13ed
EZ
72262011-11-04 Eli Zaretskii <eliz@gnu.org>
7227
7228 * xdisp.c (note_mouse_highlight): If either of
7229 previous/next-single-property-change returns nil, treat that as
7230 the beginning or the end of the buffer. (Bug#9955)
7231
fe0b6370
JD
72322011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7233
a58c13ed 7234 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7235 label is not null (Bug#9951).
7236 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7237 may be NULL.
7238
89bd5ee1
EZ
72392011-11-04 Eli Zaretskii <eliz@gnu.org>
7240
7241 * window.c (Fwindow_body_size): Mention in the doc string that the
7242 return value is in frame's canonical units. (Bug#9949)
7243
84c3edb9
EZ
72442011-11-03 Eli Zaretskii <eliz@gnu.org>
7245
4e2fb5c7
EZ
7246 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7247
84c3edb9 7248 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7249 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7250 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7251
bc17a887
EZ
72522011-11-01 Eli Zaretskii <eliz@gnu.org>
7253
7254 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7255 Don't stop backward scan on the continuation glyph, even though
7256 its CHARPOS is positive.
6d5eb5b0
SM
7257 (mouse_face_from_buffer_pos, note_mouse_highlight):
7258 Rename cover_string to disp_string.
bc17a887 7259
4ee88440
MR
72602011-11-01 Martin Rudalics <rudalics@gmx.at>
7261
7262 * window.c (temp_output_buffer_show): Don't use
7263 Vtemp_buffer_show_specifiers.
7264 (Vtemp_buffer_show_specifiers): Remove unused variable.
7265
c2ff3c02
EZ
72662011-10-30 Eli Zaretskii <eliz@gnu.org>
7267
7268 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7269 past the beginning of the current glyph matrix.
7270
58179cce 72712011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7272
7273 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7274 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7275 HAVE_GTK3 (Bug#9869).
b77a6a7f 7276
3b574623
JD
7277 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7278 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7279
b77a6a7f
JD
7280 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7281
7282 * xterm.c: Declare x_handle_net_wm_state to return int.
7283 (handle_one_xevent): Check if we are iconified but don't have
7284 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7285 (get_current_wm_state): Return non-zero if not hidden,
7286 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7287 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7288 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7289 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7290
196e41e4
PE
72912011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7292
7293 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7294 so that this new function doesn't get optimized away by a
7295 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7296
021f2e1a
AS
72972011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7298
7299 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7300
8b058d44
EZ
73012011-10-29 Eli Zaretskii <eliz@gnu.org>
7302
7303 Fix the `xbytecode' command.
7304 * .gdbinit (xprintbytestr): New command.
b50a28de 7305 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7306 (xbytecode): Print the byte-code string as well.
7307
4452fb80
EZ
73082011-10-29 Kim Storm <storm@cua.dk>
7309
8b058d44
EZ
7310 * alloc.c (which_symbols): New function.
7311
21b72067
AS
73122011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7313
7314 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7315 line. (Bug#9903)
7316
83ed7b5c
GM
73172011-10-29 Glenn Morris <rgm@gnu.org>
7318
7319 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7320 Not clear what it was for, and it causes various bugs. (Bug#9839)
7321
5a7a728b
EZ
73222011-10-28 Eli Zaretskii <eliz@gnu.org>
7323
7324 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7325 possible random value that matches one of those tested as
7326 condition to clear the mouse face.
7327
d3d0842f
CY
73282011-10-28 Chong Yidong <cyd@gnu.org>
7329
7330 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7331
31b39d13
DN
73322011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7333
7334 * window.c (make_window): Initialize phys_cursor_on_p.
7335
9aba6043
SM
73362011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7337
7338 * lisp.h (struct Lisp_Symbol): Update comments.
7339
c20992f4
JB
73402011-10-28 Juanma Barranquero <lekktu@gmail.com>
7341
7342 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7343
db4f02f2
EZ
73442011-10-28 Eli Zaretskii <eliz@gnu.org>
7345
7346 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7347 <oslsachem@gmail.com> for helping to debug this.
7348
7349 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7350 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7351 (g_b_init_get_glyph_outline_w): New static variables.
7352 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7353 (GetGlyphOutlineW_Proc): New typedefs.
7354 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7355 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7356 New functions.
7357 (w32font_open_internal, compute_metrics):
7358 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7359 instead of calling the "wide" APIs directly.
7360
7361 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7362
7363 * w32.h (syms_of_w32font): Add prototype.
7364
87e68db4
JB
73652011-10-27 Juanma Barranquero <lekktu@gmail.com>
7366
7367 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7368 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7369 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7370 (Fmove_to_window_line): Doc fix.
7371
435c1d67
CY
73722011-10-27 Chong Yidong <cyd@gnu.org>
7373
7374 * process.c (make_process): Set gnutls_state to NULL.
7375
7376 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7377 non-NULL, regardless of GNUTLS_INITSTAGE.
7378 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7379 an error. Set process slots as soon as we allocate them.
7380
7381 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7382
9c6c6f49
CY
73832011-10-27 Chong Yidong <cyd@gnu.org>
7384
9aba6043
SM
7385 * gnutls.c (emacs_gnutls_deinit): New function.
7386 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7387 (Fgnutls_deinit, Fgnutls_boot): Use it.
7388
7389 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7390 (deactivate_process): Call emacs_gnutls_deinit.
7391
657d08d3
JB
73922011-10-27 Juanma Barranquero <lekktu@gmail.com>
7393
7394 * image.c (x_create_x_image_and_pixmap):
7395 * w32.c (sys_rename, w32_delayed_load):
7396 * w32font.c (fill_in_logfont):
7397 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7398
5430d399
JB
73992011-10-26 Juanma Barranquero <lekktu@gmail.com>
7400
7401 * w32fns.c (w32_default_color_map): New function,
7402 extracted from Fw32_default_color_map.
a7ef684b 7403 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7404
fe0055fa
PE
74052011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7406
7407 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7408
e6346438
SM
74092011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7410
7411 * keyboard.c (test_undefined): New function (bug#9751).
7412 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7413
e112cc37
ET
74142011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7415
7416 * sysdep.c (init_sys_modes): Fix the check for the controlling
7417 terminal (Bug#6649).
7418
7b5d6677
EZ
74192011-10-20 Eli Zaretskii <eliz@gnu.org>
7420
7421 * dispextern.h (struct bidi_it): New member next_en_type.
7422
7423 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7424 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7425 current character, check also for next_en_type being WEAK_EN.
7426 (bidi_resolve_weak): Don't enter the expensive loop if the current
7427 position is before next_en_pos. Record the bidi type of the first
7428 non-ET, non-BN character we find, in addition to its position.
7429 (bidi_level_of_next_char): Invalidate next_en_type when
7430 next_en_pos is over-stepped.
7431
7da0b018
PE
74322011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7433
7434 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7435 * editfns.c: Rewrite current-time-zone so that it invokes
7436 the equivalent of (format-time-string "%Z") to get the time zone name.
7437 This fixes a bug when the time zone name contains characters that
7438 need converting from the system time locale to Emacs internal format.
7439 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7440 that patch fixed format-time-string to do the conversion, but
7441 I forgot to fix current-time-zone.
7442 (format_time_string): New function, containing most of
7443 what Fformat_time_string used to contain.
7444 (Fformat_time_string): Rewrite in terms of format_time_string.
7445 This doesn't change this function's behavior.
7446 (current-time-zone): Rewrite to use format_time_string.
7447 This fixes the bug reported by Michael Schierl in
7448 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7449 Jason Rumney's 2007-06-07 change worked around this bug, but
7450 didn't fix it.
7451 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7452
8547b010
EZ
74532011-10-19 Eli Zaretskii <eliz@gnu.org>
7454
7455 * xdisp.c (start_display): If the character at POS is displayed
7456 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7457 (try_window_reusing_current_matrix): If a line ends in a display
7458 vector or the next line starts in a display vector, continue
7459 redrawing the window even though the character position of
7460 start_row was reached.
8547b010
EZ
7461 (Bug#9771, part 2)
7462
4e948d15
CY
74632011-10-18 Chong Yidong <cyd@gnu.org>
7464
7465 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7466 with nobreak-char-display too.
7467
4787455f
EZ
74682011-10-18 Eli Zaretskii <eliz@gnu.org>
7469
7470 Fix part 3 of bug#9771.
7471 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7472 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7473 non-neutral characters if the current character is a paragraph
7474 separator (a.k.a. Newline). This avoids running the same
7475 expensive loop twice, once when we consume the preceding newline
7476 and the other time when the line actually needs to be displayed.
7477 Avoid the loop when we see neutrals on the base embedding level
7478 following a character whose directionality is the same as the
7479 paragraph's. This avoids running the expensive loop when a line
7480 ends in a long sequence of neutrals, like control characters.
7481 Add assertion against STRONG_AL type. Slightly rearrange code
7482 that determines the type of a neutral given the first non-neutral
7483 that follows it.
7484 (bidi_level_of_next_char): Set next_en_pos to zero when
7485 invalidating its info.
7486
2c91f553
EZ
74872011-10-17 Eli Zaretskii <eliz@gnu.org>
7488
7489 * xdisp.c (push_display_prop): Determine whether to record string
7490 or buffer position by IT->string, not by IT->method. Allow
7491 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7492 (move_it_vertically_backward): Don't look for character position
7493 immediately after the newline when in a continuation line.
7494 (Bug#9771, part 1)
2c91f553 7495
c7b08b0d
MR
74962011-10-15 Martin Rudalics <rudalics@gmx.at>
7497
7498 * window.c (coordinates_in_window): Rewrite and delabelize
7499 vertical border check. (Bug#5357) (Bug#9618)
7500
6b02f655
SM
75012011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7502
7503 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7504 errors in XSetWindowBorder (bug#9310).
7505
81d40c92
DA
75062011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7507
7508 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7509 avoid crash when xmalloc overrun checking is enabled.
7510
d4172c3b
EZ
75112011-10-13 Eli Zaretskii <eliz@gnu.org>
7512
7513 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7514 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7515 cursor motion with <left> and <right> arrow keys.
7516
7517 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7518 some callers set that themselves.
7519
b00eea75
EZ
75202011-10-12 Eli Zaretskii <eliz@gnu.org>
7521
7522 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7523 display string and the previous row comes from the same string and
7524 is empty. (Bug#9739) (Bug#9738)
7525
8fe012c4
SM
75262011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 * doc.c (get_doc_string): Encode file name (bug#9735).
7529
0074aef2
EZ
75302011-10-12 Eli Zaretskii <eliz@gnu.org>
7531
79beb178
EZ
7532 * bidi.c (bidi_level_of_next_char):
7533 * xdisp.c (get_visually_first_element): Remove old incorrect
7534 comments regarding the Unicode Line Separator character.
7535
0074aef2
EZ
7536 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7537
6e4b3fbe
DA
75382011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7539
7540 * alloc.c (Fgc_status): Do not access beyond zombies array
7541 boundary if nzombies > MAX_ZOMBIES.
7542 * alloc.c (dump_zombies): Add missing format specifier.
7543
0324f3af
PE
75442011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7545
b5525cac
PE
7546 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7547 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7548
0324f3af
PE
7549 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7550 Some packages use them to denote characters with modifiers.
7551
e9b5f888
AS
75522011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7553
7554 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7555 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7556 matching a pp-number. Rename parameter var to var1.
7557
127827c0
SM
75582011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7559
7560 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7561
c8fd3bd0
GM
75622011-10-08 Glenn Morris <rgm@gnu.org>
7563
7564 * callint.c (Fcall_interactively): Give a more explicit error for the
7565 'c' case with a non-character input. (Bug#8479)
7566
352ec8ff
EZ
75672011-10-08 Eli Zaretskii <eliz@gnu.org>
7568
03669ccb
EZ
7569 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7570 lines.
7061c986
EZ
7571 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7572 lines that are hscrolled on the left.
03669ccb 7573
352ec8ff
EZ
7574 * dispnew.c (buffer_posn_from_coords): Account for a possible
7575 presence of header-line. (Bug#4426)
7576
a66cfb1c
SM
75772011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7578
6b02f655
SM
7579 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7580 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7581
7c5ee88e
PE
75822011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7583
7584 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7585 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7586 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7587 this makes Emacs dump core during garbage collection on rare
7588 occasions. sizeof is obviously inferior to offsetof here, so
7589 stick with offsetof.
7590 (GC_POINTER_ALIGNMENT): New macro.
7591 (mark_memory): Omit 3rd (offset) arg; caller changed.
7592 Don't assume EMACS_INT alignment is the same as pointer alignment.
7593
df1bbe5b
SM
75942011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7595
7596 * keyboard.c (read_key_sequence_remapped): New var.
7597 (read_key_sequence): Compute remapping in the right buffer.
7598 (command_loop_1): Use read_key_sequence's remapping directly.
7599
51553db6
SM
76002011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7601
32c1fffd
SM
7602 * dired.c (file_name_completion): Don't expand file name.
7603 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7604 before checking file name handler.
7605
51553db6
SM
7606 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7607 they've been requested explicitly (bug#9591).
7608
b6bd1599 76092011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7610
7611 * keymap.c (Fsingle_key_description): Use make_specified_string
7612 instead of build_string to build string from push_key_description.
7613 (Bug#5193)
7614
f701dc2a
PE
76152011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7616
4222c55d
PE
7617 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7618 This fixes a Y2038 bug on 64-bit hosts.
7619 * buffer.c (reset_buffer):
7620 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7621 (Fclear_buffer_auto_save_failure):
7622 Use 0, not -1, to represent an unset failure time, since time_t
7623 might not be signed.
7624
f701dc2a
PE
7625 Remove dependency on glibc malloc internals.
7626 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7627 Move back here from lisp.h, but with their new implementations.
7628 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7629 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7630 * charset.c (charset_table_init): New static var.
7631 (syms_of_charset): Use it instead of xmalloc. This removes a
7632 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7633 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7634 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7635 Move back to alloc.c.
7636 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7637 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7638
9ceebf39
JD
76392011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7640
7641 * nsterm.m (windowDidResize): Call x_set_window_size only when
7642 ns_in_resize is true. Otherwise set pixelwidth/height and
7643 call change_frame_size (Bug#9628).
7644
cb993c58
PE
76452011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7646
3930c88b
PE
7647 Port --enable-checking=all to Fedora 14 x86-64.
7648 * charset.c (syms_of_charset): Also account for glibc malloc's
7649 internal overhead when calculating the initial malloc maximum.
7650
cb993c58
PE
7651 Port --enable-checking=all to Fedora 14 x86.
7652 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7653 Move to lisp.h.
7654 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7655 (overrun_check_realloc, overrun_check_free):
7656 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7657 That way, xmalloc returns a properly-aligned pointer even if
7658 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7659 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7660 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7661 into account when calculating the initial malloc maximum.
7662 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7663 Move here from alloc.c, so that charset.c can use it too.
7664 Properly align; the old code wasn't right for common 32-bit hosts
7665 when configured with --enable-checking=all.
7666 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7667 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7668
31bed486
EZ
76692011-09-29 Eli Zaretskii <eliz@gnu.org>
7670
04c70788 7671 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7672 use EDOM.
7673
fbcaa2f3
EZ
76742011-09-28 Eli Zaretskii <eliz@gnu.org>
7675
7676 * xdisp.c (compute_display_string_end): If there's no display
7677 string at CHARPOS, return -1.
7678
7679 * bidi.c (bidi_fetch_char): When compute_display_string_end
7680 returns a negative value, treat the character as a normal
7681 character not covered by a display string. (Bug#9624)
7682
a239d4e9
JB
76832011-09-28 Juanma Barranquero <lekktu@gmail.com>
7684
7685 * lread.c (Fread_from_string): Fix typo in docstring.
7686
88652fd5
EZ
76872011-09-27 Eli Zaretskii <eliz@gnu.org>
7688
7689 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7690 newline, reseat the iterator instead of bidi-iterating there one
7691 character at a time. (Bug#9610)
32c1fffd
SM
7692 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7693 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7694
ed497dd4
AS
76952011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7696
7697 * lread.c (readevalloop): Use correct code for NBSP.
7698 (read1): Likewise. (Bug#9608)
7699
b2bf61aa
MA
77002011-09-25 Michael Albinus <michael.albinus@gmx.de>
7701
7702 * dbusbind.c (Fdbus_register_signal): When service is not
7703 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7704
32bbb17c
GM
77052011-09-25 Glenn Morris <rgm@gnu.org>
7706
7707 * buffer.c (truncate-lines): Doc fix.
7708
94e0933e
CY
77092011-09-24 Chong Yidong <cyd@stupidchicken.com>
7710
7711 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7712 (Fset_window_next_buffers): Doc fix.
7713
cddde921
GM
77142011-09-24 Glenn Morris <rgm@gnu.org>
7715
7716 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7717
1260aef1
PE
77182011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7719
25b4bfa0
PE
7720 Fix minor problems found by static checking.
7721 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7722 * indent.c (Fvertical_motion): Fix == vs = typo.
7723
e3cbd34b
EZ
77242011-09-24 Eli Zaretskii <eliz@gnu.org>
7725
a66cfb1c
SM
7726 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7727 Default value is now t. Doc fix.
6bf7006f 7728
e3cbd34b 7729 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7730 logic when moving up, not only when moving down. Fix the
e3cbd34b 7731 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7732 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7733
7734 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7735 CHARPOS is covered by a display string which includes newlines.
7736 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7737 is covered by a display string with embedded newlines.
7738
a3de0cbd
MA
77392011-09-24 Michael Albinus <michael.albinus@gmx.de>
7740
7741 * dbusbind.c (Fdbus_register_signal): Add match rule to
7742 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7743 (Fdbus_register_method, Vdbus_registered_objects_table):
7744 Fix docstring.
a3de0cbd 7745
b260039d
JM
77462011-09-24 Jim Meyering <meyering@redhat.com>
7747
32c1fffd 7748 do not ignore write error for any output size
b260039d
JM
7749 The previous change was incomplete.
7750 While it makes emacs --batch detect the vast majority of stdout
7751 write failures, errors were still ignored whenever the output size is
7752 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7753 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7754 && echo FAIL: ignored write error
7755 FAIL: ignored write error
7756 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7757 && echo FAIL: ignored write error
7758 FAIL: ignored write error
7759 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7760
8eca8a7c
AS
77612011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7762
7763 * emacs.c (Fkill_emacs): In noninteractive mode exit
7764 non-successfully if a write error occurred on stdout. (Bug#9574)
7765
3341db62
EZ
77662011-09-21 Eli Zaretskii <eliz@gnu.org>
7767
7768 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7769 the xassert test.
7770
7771 * dispextern.h (struct it): Update the comment documenting what
7772 can it->OBJECT be.
7773
8c203dbf
EZ
77742011-09-20 Eli Zaretskii <eliz@gnu.org>
7775
7776 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7777 a display string, extend search for cursor position to end of row.
7778 (find_row_edges): If the row ends in a newline from a display
7779 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7780 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7781 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7782 non-empty line. Fixes confusing cursor motion with arrow keys at
7783 the beginning of a line that starts with whitespace.
8c203dbf 7784
a4824228
LMI
77852011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7786
7787 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7788 (bug#9493).
7789
33ed493b
CY
77902011-09-18 Chong Yidong <cyd@stupidchicken.com>
7791
7792 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7793 boolean (Bug#9154).
7794
56cd55c8
EZ
77952011-09-18 Eli Zaretskii <eliz@gnu.org>
7796
7797 * xdisp.c (display_line): Record maximum and minimum buffer
7798 positions even if no glyphs were produced (e.g., by a zero-width
7799 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7800 buffer positions that will be removed from the glyph row because
7801 they don't fit.
c02dcedf
EZ
7802 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7803 column is beyond frame width: don't subtract 1 "pixel" when
7804 computing width of the stretch.
3e62b7e0
EZ
7805 (reseat_at_next_visible_line_start): Undo the change made on
7806 2011-09-17 that saved paragraph information and restored it after
7807 the call to `reseat'. (Bug#9545)
56cd55c8 7808
5ed99d36 78092011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7810
7811 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7812 and turn window cursor on if cleared (Bug#9415).
7813
5ed99d36 78142011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7815
7816 * search.c (boyer_moore): Take unibyte characters from pattern
7817 literally. (Bug#9458)
7818
9bade7b2
EZ
78192011-09-18 Eli Zaretskii <eliz@gnu.org>
7820
7821 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7822
e5e9d610
PE
78232011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7824
87e4427a
PE
7825 Fix minor problem found by static checking.
7826 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7827 initialized, to pacify gcc -Wuninitialized.
7828
e5e9d610
PE
7829 * fileio.c: Report proper errno when syscall falls.
7830 (Finsert_file_contents): Save and restore errno,
7831 so that report_file_error outputs the correct diagnostic.
7832 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7833
a1674f0b
EZ
78342011-09-18 Eli Zaretskii <eliz@gnu.org>
7835
7836 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7837
fbfb6dd4
EZ
78382011-09-17 Eli Zaretskii <eliz@gnu.org>
7839
7840 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7841 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7842
bb187662
EZ
78432011-09-17 Eli Zaretskii <eliz@gnu.org>
7844
1137e8b8 7845 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7846 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7847
7848 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7849 (bidi_find_paragraph_start): Search back for paragraph beginning
7850 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7851 (bidi_move_to_visually_next): Only trigger paragraph-related
7852 computations when the last character is a newline or at EOB, not
7853 just any NEUTRAL_B. (Bug#9470)
7854
bb187662
EZ
7855 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7856 truncated lines if point is covered by a display string. (Bug#9524)
7857
2e621251
PE
78582011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7859
7860 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7861 (cons_to_x_long): New function.
7862 (lisp_data_to_selection_data): Use it. Correct the test for
7863 short-versus-long data; it was negated. Break out of vector
7864 loop, for efficiency, when a long datum is discovered.
7865
91a15bc6
SM
78662011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7867
7868 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7869
b41c3a35
EZ
78702011-09-16 Eli Zaretskii <eliz@gnu.org>
7871
7872 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7873 GCC PR/17406) by declaring this function with external scope.
7874
7812ba2d
PE
78752011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7876
7877 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7878 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7879
cf7edc2a
AS
78802011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7881
7882 * editfns.c (Fformat): Correctly handle text properties on "%%".
7883
bd01620e
EZ
78842011-09-15 Eli Zaretskii <eliz@gnu.org>
7885
7886 * xterm.c (x_draw_composite_glyph_string_foreground):
7887 * w32term.c (x_draw_composite_glyph_string_foreground):
7888 * term.c (encode_terminal_code):
7889 * composite.c (composition_update_it, get_composition_id):
7890 * xdisp.c (get_next_display_element)
7891 (fill_composite_glyph_string): Add comments about special meaning
7892 of TAB characters in a composition.
7893
a02719a3
PE
78942011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7895
7896 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7897 This occurs when processing a multibyte format.
7898 Problem reported by Wolfgang Jenker.
a02719a3 7899
72589a3c
JB
79002011-09-15 Johan Bockgård <bojohan@gnu.org>
7901
7902 * xdisp.c (try_cursor_movement): Only check for exact match if
7903 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7904
1c14176c
PE
79052011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7906
7907 Remove unused external symbols.
7908 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7909 * xdisp.c (calc_pixel_width_or_height): Now static.
7910 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7911 * indent.c (check_display_width):
7912 * w32term.c: Fix comment to match code.
7913 * xterm.c, xterm.h (x_catching_errors): Remove.
7914
d2eea5b5
PE
79152011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7916
7917 * xselect.c: Use signed conversions more consistently (Bug#9498).
7918 (selection_data_to_lisp_data): Assume incoming selection data are
7919 signed integers, not unsigned. This is to be consistent with
7920 outgoing selection data, which was modified to use signed integers
7921 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7922 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7923 expects long, not unsigned long.
7924
46888499
EZ
79252011-09-14 Eli Zaretskii <eliz@gnu.org>
7926
7927 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7928 computation of loop end. Reported by Johan Bockgård
7929 <bojohan@gnu.org>.
7930
ef8ef9fb
CY
79312011-09-13 Chong Yidong <cyd@stupidchicken.com>
7932
7933 * frame.c (Fother_visible_frames_p): Function deleted.
7934
fa819fed
EZ
79352011-09-12 Eli Zaretskii <eliz@gnu.org>
7936
7937 * indent.c (compute_motion): Process display vector front to back
7938 rather than the other way around. (Bug#2496)
7939
2ba8e008
SM
79402011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7941
7942 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7943
20f53c69
CY
79442011-09-11 Chong Yidong <cyd@stupidchicken.com>
7945
7946 * minibuf.c (Fread_from_minibuffer): Doc fix.
7947
d562d7a4
EZ
79482011-09-11 Eli Zaretskii <eliz@gnu.org>
7949
7950 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7951 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7952
1c4d7f3d
LMI
79532011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7954
7955 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7956 value for non-existent files.
7957
b885bf36
EZ
79582011-09-11 Eli Zaretskii <eliz@gnu.org>
7959
7960 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7961 set its "size" to -1. This will set the modtime_size field of
7962 the corresponding buffer to -1, which is what
7963 verify-visited-file-modtime expects for files that do not exist.
7964 (Bug#9139)
7965
6612f0bf
PE
79662011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7967
7968 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7969 here ...
7970 * lisp.h: ... from here. push_key_description is no longer
7971 defined in keyboard.c, so its declaration should not be in
7972 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7973 logically belongs with push_key_description.
7974
dfb3f755
PE
79752011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7976
7977 * buffer.h: Include <sys/types.h> instead of <time.h>.
7978 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7979 Problem reported by Herbert J. Skuhra.
7980
3134906c
LMI
79812011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7982
7983 * xml.c (parse_region): Make the parsing work for
7984 non-comment-starting XML files again (bug#9144).
7985
8d903f4e
AS
79862011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7987
7988 * image.c (gif_load): Fix calculation of bottom and right corner.
7989 (Bug#9468)
7990
80ad64f4
EZ
79912011-09-10 Eli Zaretskii <eliz@gnu.org>
7992
7993 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7994 redisplay in small windows.
7995
208a048d
EZ
79962011-09-09 Eli Zaretskii <eliz@gnu.org>
7997
7998 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7999
9b1c252e
MR
80002011-09-08 Martin Rudalics <rudalics@gmx.at>
8001
8002 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
8003 Operate on live windows only.
8004
2949f33b
JB
80052011-09-08 Juanma Barranquero <lekktu@gmail.com>
8006
8007 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
8008
e08dcafd
EZ
80092011-09-07 Eli Zaretskii <eliz@gnu.org>
8010
8011 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
8012 only under bidi iteration.
8013
115b96bd
JD
80142011-09-07 Jan Djärv <jan.h.d@swipnet.se>
8015
8016 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
8017
c8199d0f
PE
80182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
8019
8020 isnan: Fix porting problem to Solaris 10 with bundled gcc.
8021 Without this fix, the command to link temacs failed due to an
8022 undefined symbol __builtin_isnan. This is because
8023 /usr/include/iso/math_c99.h #defines isnan(x) to
8024 __builtin_isnan(x), but the bundled gcc, which identifies itself
8025 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
8026 a __builtin_isnan.
8027 * floatfns.c (isnan): #undef, and then #define to a clone of
8028 what's in data.c.
8029 (Fisnan): Always define, since it's always available now.
8030 (syms_of_floatfns): Always define isnan at the Lisp level.
8031
e39b275c 80322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
8033
8034 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
8035
b2db44d9 80362011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 8037
f4af5137 8038 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
8039 The previous code assumed that file offsets (off_t values) fit in
8040 EMACS_INT variables, which is not true on typical 32-bit hosts.
8041 The code messed up by falsely reporting buffer overflow in cases
8042 such as (insert-file-contents "big" nil 1 2) into an empty buffer
8043 when "big" contains more than 2**29 bytes, even though this
8044 inserts just one byte and does not overflow the buffer.
8045 (Finsert_file_contents): Store file offsets as off_t
8046 values, not as EMACS_INT values. Check for overflow when
8047 converting between EMACS_INT and off_t. When checking for
8048 buffer overflow or for overlap, take the offsets into account.
8049 Don't use EMACS_INT for small values where int suffices.
8050 When checking for overlap, fix a typo: ZV was used where
8051 ZV_BYTE was intended.
8052 (Fwrite_region): Don't assume off_t fits into 'long'.
8053 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
8054
ecfc0a49
MA
80552011-09-05 Michael Albinus <michael.albinus@gmx.de>
8056
8057 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
8058
6511acf2 80592011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 8060
0999621a 8061 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
8062
8063 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 8064 (esprintf, exprintf, evxprintf): New functions.
62f19c19 8065 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 8066 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
8067 (modify_event_symbol): Do not assume that the length of
8068 name_alist_or_stem is safe to alloca and fits in int.
8069 (Fexecute_extended_command): Likewise for function name and binding.
8070 (Frecursion_depth): Wrap around reliably on integer overflow.
8071 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
8072 since some callers pass EMACS_INT values.
8073 (Fsingle_key_description): Don't crash if symbol name contains more
8074 than MAX_ALLOCA bytes.
8075 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
8076 (get_minibuffer): Arg is now EMACS_INT, not int.
8077 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 8078 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
8079 * window.h (command_loop_level, minibuf_level): Reflect API changes.
8080
2be7d702
PE
8081 * dbusbind.c (signature_cat): New function.
8082 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
8083 Do not overrun buffer; instead, report string overflow.
8084
9d1df220
PE
8085 * dispnew.c (add_window_display_history): Don't overrun buffer.
8086 Truncate instead; this is OK since it's just a log.
8087
33ef5c64
PE
8088 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
8089 even if the time zone offset is outlandishly large.
8090 Don't mishandle offset == INT_MIN.
8091
66c6fdd5
PE
8092 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
8093 when creating daemon; the previous buffer-overflow check was incorrect.
8094
d749b01b
PE
8095 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
8096 which has the guts of the old verror function.
8097
b5cd1905
PE
8098 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
8099 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
8100
6e1a67fb
PE
8101 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8102 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8103 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8104 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8105 length of string rather than counting it via multiple sprintfs;
8106 that's simpler and more reliable.
c21721cc
PE
8107 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8108 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8109 sprintf, in case result does not fit in int.
8110
c57b67fc
PE
8111 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8112 (fontset_from_font): Print it.
8113
8a401434
PE
8114 * frame.c (tty_frame_count): Now printmax_t, not int.
8115 (make_terminal_frame, set_term_frame_name): Print it.
8116 (x_report_frame_params): In X, window IDs are unsigned long,
8117 not signed long, so print them as unsigned.
8118 (validate_x_resource_name): Check for implausibly long names,
8119 and don't assume name length fits in 'int'.
8120 (x_get_resource_string): Don't blindly alloca invocation name;
8121 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8122 not fit in int.
8123
6e1a67fb
PE
8124 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8125 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8126 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8127
0df02bf3
PE
8128 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8129 Use esprintf, not sprintf, in case result does not fit in int.
8130
48e30793
PE
8131 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8132 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8133 it as a large positive number.
8134 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8135 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8136
a66ff6d8
PE
8137 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8138 in case result does not fit in int.
8139
aca216ff
PE
8140 * print.c (float_to_string): Detect width overflow more reliably.
8141 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8142 buffer overrun. Don't assume list length fits in 'int'. Treat
8143 print length of 0 as 0, not as infinity; to be consistent with other
8144 uses of print length in this function. Don't overflow print length
8145 index. Don't assume hash table size fits in 'long', or that
8146 vectorlike size fits in 'unsigned long'.
8147
31c286f7
PE
8148 * process.c (make_process): Use printmax_t, not int, to format
8149 process-name gensyms.
8150
55e5faa1
PE
8151 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8152
80f2e268
PE
8153 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8154 to avoid potential buffer overrun.
8155
670741ab
PE
8156 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8157 if X resource line is longer than 512 bytes.
8158
b7163a50
PE
8159 * xfns.c (x_window): Make sprintf buffer a bit bigger
8160 to avoid potential buffer overrun.
8161
ae58ff1f
PE
8162 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8163
c43c8a6a
PE
8164 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8165
3f8236f4
PE
81662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8167
53e9fe90 8168 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8169 Without these, Emacs silently mishandles large integers sometimes.
8170 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8171 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8172
6511acf2
PE
8173 * xdisp.c (try_window_id): Check Emacs fixnum range before
8174 converting to 'int'.
806add1d 8175
6511acf2 8176 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8177 Check that an Emacs fixnum is in range before assigning it to 'int'.
8178 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8179 values converted from Emacs fixnums.
8180 (Frecenter): Don't wrap around a line count if it is out of 'int'
8181 range; instead, treat it as an extreme value.
8182 (Fset_window_configuration, compare_window_configurations):
8183 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8184
6511acf2
PE
8185 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8186 that can exceed INT_MAX. Check that EMACS_INT value is in range
8187 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8188 (match_limit): Don't assume that a fixnum can fit in 'int'.
8189
6511acf2 8190 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8191 exceed INT_MAX.
8192
6511acf2 8193 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8194 (Fvertical_motion): Don't wrap around LINES values that don't fit
8195 in 'int'. Instead, treat them as extreme values. This is good
8196 enough for windows, which can't have more than INT_MAX lines anyway.
8197
fcb901a7
LMI
81982011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8199
0f2f6b6d
LMI
8200 * Require libxml/parser.h to avoid compilation warning.
8201
fcb901a7
LMI
8202 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8203
8204 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8205 since this reportedly can destroy thread storage.
8206
6e20a0d4
CY
82072011-08-30 Chong Yidong <cyd@stupidchicken.com>
8208
8209 * syntax.c (find_defun_start): Update all cache variables if
8210 exiting early (Bug#9401).
8211
148ae00e
EZ
82122011-08-30 Eli Zaretskii <eliz@gnu.org>
8213
f6cfbd8f
EZ
8214 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8215
148ae00e
EZ
8216 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8217 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8218 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8219
8220 * term.c (tty_append_glyph): New function.
8221 (produce_stretch_glyph): Static function and its prototype deleted.
8222
a66cfb1c
SM
8223 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8224 Add prototypes.
148ae00e 8225
c4a07a4c
PE
82262011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8229 when checking :margin (Bug#9390).
8230 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8231 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8232 so that the name doesn't mislead. All uses changed.
8233
6bc8cd65
JB
82342011-08-28 Johan Bockgård <bojohan@gnu.org>
8235
8236 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8237 set_tty_hooks.
8238
dca4927e
EZ
82392011-08-27 Eli Zaretskii <eliz@gnu.org>
8240
8241 * xdisp.c (move_it_to): Don't bail out early when reaching
8242 position beyond to_charpos, if we are scanning backwards.
8243 (move_it_vertically_backward): When DY == 0, make sure we get to
8244 the first character in the line after the newline.
8245
f2cad773
PE
82462011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8247
8248 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8249 (ccl_driver): Do not generate an out-of-range pointer.
8250 (Fccl_execute_on_string): Remove unnecessary check for
8251 integer overflow, noted by Stefan Monnier in
8252 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8253 Remove a FIXME that didn't need fixing.
8254 Simplify the newly-introduced buffer reallocation code.
8255
0cae2cdb
JB
82562011-08-27 Juanma Barranquero <lekktu@gmail.com>
8257
8258 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8259
5fc295a4 82602011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8261
70c60eb2 8262 Integer and memory overflow issues (Bug#9196).
726e0ab1 8263
d31850da
PE
8264 * doc.c (get_doc_string): Rework so that
8265 get_doc_string_buffer_size is the actual buffer size, rather than
8266 being 1 less than the actual buffer size; this makes xpalloc more
8267 convenient.
8268
a69fbedb
PE
8269 * image.c (x_allocate_bitmap_record, cache_image):
8270 * xselect.c (Fx_register_dnd_atom):
8271 Simplify previous changes by using xpalloc.
8272
fe5c5d37
PE
8273 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8274 since either will do and ptrdiff_t is convenient with xpalloc.
8275
0065d054
PE
8276 * charset.c (charset_table_size)
8277 (struct charset_sort_data.priority): Now ptrdiff_t.
8278 (charset_compare): Don't overflow if priorities differ greatly.
8279 (Fsort_charsets): Don't assume list length fits in int.
8280 Check for size-calculation overflow when allocating sort data.
8281 (syms_of_charset): Allocate an initial charset table that is
8282 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8283
8284 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8285
8286 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8287 The actual value is always <= INT_MAX, and leaving it unsigned made
8288 overflow checking harder.
8289
8290 * dispextern.h (struct glyph_matrix.rows_allocated)
8291 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8292 with xpalloc. The values are still always <= INT_MAX.
8293
8294 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8295
8296 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8297 (SAFE_NALLOCA): New macro.
8298
8299 * region-cache.c (struct boundary.pos, find_cache_boundary)
8300 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8301 (set_cache_region, invalidate_region_cache)
8302 (revalidate_region_cache, know_region_cache, region_cache_forward)
8303 (region_cache_backward, pp_cache):
8304 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8305 so that ptrdiff_t * can be passed to xpalloc.
8306 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8307 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8308 (pp_cache): Don't assume cache_len fits in int.
8309 * region-cache.h: Adjust extern decls to match.
8310
8311 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8312 EMACS_INT, since either will do, for xpalloc.
8313
8314 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8315 (xnmalloc, xnrealloc, xpalloc): New functions.
8316
726e0ab1
PE
8317 * bidi.c (bidi_shelve_header_size): New constant.
8318 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8319 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8320
51f30bc5 8321 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8322 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8323 (overlay_strings):
8324 Don't update size of array until after memory allocation succeeds,
8325 because xmalloc/xrealloc may not return.
0065d054
PE
8326 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8327 now that we have proper integer overflow checking.
8328 (record_overlay_string, overlay_strings): Catch overflows when
8329 calculating size of overlay_str_buf.
726e0ab1 8330
0065d054
PE
8331 * callproc.c (Fcall_process): Check for size overflow when
8332 calculating size of args2.
8333 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8334 Normally we prefer signed values, but sticking with ptrdiff_t would
8335 require adding more-complicated checks.
726e0ab1
PE
8336
8337 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8338 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8339 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8340 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8341
8342 * character.c (Fstring): Check for size-calculation overflow.
8343
8344 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8345 unnecessary integer overflow. Check for size overflow.
8346 (encode_coding_object): Don't update size until xmalloc succeeds.
8347
8348 * composite.c (get_composition_id): Check for overflow in glyph
8349 length calculations.
8350
8351 Integer and memory overflow fixes for display code.
8352 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8353 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8354 (scrolling_window): Check for overflow in size calculations.
8355 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8356 Don't assume glyph table len fits in int.
8357 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8358 (row_table_size): Now ptrdiff_t, not int.
8359 (scrolling_window): Avoid overflow in size calculations.
8360 Don't update size until allocation succeeds.
8361 * fns.c (concat): Check for overflow in size calculations.
8362 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8363 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8364 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8365
8366 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8367 (get_doc_string): Check for size calculation overflow.
8368 Don't update size until allocation succeeds.
8369 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8370 EMACS_INT, where ptrdiff_t will do.
8371 (Fsubstitute_command_keys): Check for string overflow.
8372
8373 * editfns.c (set_time_zone_rule): Don't assume environment length
8374 fits in int.
8375 (message_length): Now ptrdiff_t, not int.
8376 (Fmessage_box): Don't update size until allocation succeeds.
8377 Don't assume message length fits in int.
8378 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8379
0065d054
PE
8380 * emacs.c (main): Do not reallocate argv, since there is a null at
8381 the end that can be overwritten, and this way there's no need to
8382 worry about size-calculation overflow.
8383 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8384
8385 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8386 alloc succeeds.
8387 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8388
8389 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8390 (x_set_scroll_bar_width, x_figure_window_size):
8391 Check for integer overflow.
8392 (x_set_alpha): Do not assume XINT fits in int.
8393
8394 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8395 This is for the members text_lines, text_cols, total_lines, total_cols,
8396 where the system imposes an 'int' limit.
8397
8398 * fringe.c (Fdefine_fringe_bitmap):
8399 Don't update size until alloc works.
8400
8401 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8402 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8403
8404 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8405 Check for size-calculation overflow.
8406 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8407 do, as we prefer signed integers.
8408 (id_to_widget.max_size, id_to_widget.used)
8409 (xg_store_widget_in_map, xg_remove_widget_from_map)
8410 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8411 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8412 Use and return ptrdiff_t, not int.
8413 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8414 * gtkutil.h: Change prototypes to match the above.
8415
8416 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8417 are duplicate now that they've been promoted to lisp.h.
8418 (x_allocate_bitmap_record, x_alloc_image_color)
8419 (make_image_cache, cache_image, xpm_load):
8420 Don't update size until alloc is done.
8421 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8422 (x_detect_edges):
3256efce 8423 Check for size calculation overflow.
726e0ab1
PE
8424 (ct_colors_allocated_max): New constant.
8425 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8426 overflow.
3256efce 8427
726e0ab1
PE
8428 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8429 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8430 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8431 Use ptrdiff_t, not int, to count maps.
8432 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8433 calculations. Don't update size until allocation succeeds.
8434 Redo calculations to avoid overflow.
726e0ab1
PE
8435 * keyboard.h: Change prototypes to match the above.
8436
8437 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8438 to count maps.
8439 (current_minor_maps): Check for size calculation overflow.
8440 * keymap.h: Change prototypes to match the above.
8441
8442 * lread.c (read1, init_obarray): Don't update size until alloc done.
8443
8444 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8445 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8446
726e0ab1
PE
8447 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8448 Now ptrdiff_t, not int.
8449 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8450 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8451
8452 * process.c (Fnetwork_interface_list): Check for overflow
8453 in size calculation.
8454
8455 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8456
8457 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8458 overflow. Don't bother calling xmalloc when xrealloc will do.
8459
8460 * search.c (Freplace_match): Check for size calculation overflow.
8461 (Fset_match_data): Don't assume list lengths fit in 'int'.
8462
8463 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8464 for command line length. Do not attempt to address one before the
8465 beginning of an array, as that's not portable.
8466
8467 * term.c (max_frame_lines): Remove; unused.
8468 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8469 not int.
8470 (encode_terminal_code, calculate_costs): Check for size
8471 calculation overflow.
8472 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8473 table lengths and related sizes. Don't update size until alloc
8474 done. Redo calculations to avoid overflow.
8475 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8476
8477 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8478 subtracting pointers.
8479 (gobble_line): Check for overflow more carefully. Don't update size
8480 until alloc done.
8481
8482 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8483 Don't update size until alloc done.
8484 Redo size calculations to avoid overflow.
8485 Check for size calculation overflow.
0065d054 8486 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8487
8488 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8489 Use ptrdiff_t, not int, for sizes.
8490 (store_mode_line_noprop_char): Don't update size until alloc done.
8491
0065d054
PE
8492 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8493 Use ptrdiff_t, not int, for sizes.
8494 (Finternal_make_lisp_face, cache_face):
8495 Check for size calculation overflow.
8496 (cache_face): Treat size calculation overflows as if they were
8497 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8498
8499 * xfns.c (x_encode_text, x_set_name_internal)
8500 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8501 sizes, since they can exceed INT_MAX in size. Check for size
8502 calculation overflow.
8503
0065d054
PE
8504 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8505 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8506 Don't update size until alloc done.
8507
0065d054 8508 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8509 as sprintf is limited to int lengths.
1d526e2f 8510
252c5ee1
PE
8511 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8512 (X_LONG_MIN): New macros.
864d7ce7
PE
8513 Use them to make the following changes clearer.
8514 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8515 This change doesn't affect the value now, but it may help remind
8516 future maintainers not to raise the value too much later.
8517 (SELECTION_QUANTUM): Remove, replacing with ...
8518 (selection_quantum): ... new function, which avoids overflow.
8519 All uses changed.
8520 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8521 assumption that selection length fits in 'int'.
8522 (x_reply_selection_request, x_handle_selection_request)
8523 (x_get_window_property, receive_incremental_selection)
8524 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8525 (lisp_data_to_selection_data, clean_local_selection_data):
8526 Use ptrdiff_t, not int, to record length of selection.
8527 (x_reply_selection_request, x_get_window_property)
8528 (receive_incremental_selection, x_property_data_to_lisp):
8529 Redo calculations to avoid overflow.
8530 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8531 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8532 something.
8533 (x_get_window_property, receive_incremental_selection)
8534 (lisp_data_to_selection_data, x_property_data_to_lisp):
8535 Check for size-calculation overflow.
8536 (x_get_window_property, receive_incremental_selection)
8537 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8538 Don't store size until memory allocation succeeds.
8539 (x_get_window_property): Plug memory leak on memory exhaustion.
8540 Don't double-block input; malloc is safe here. Don't assume 2**34
8541 - 4 fits in unsigned long. Add an xassert to check
8542 XGetWindowProperty overflow. Be more careful about overflow
8543 calculations, and distinguish size from memory overflow better.
8544 (receive_incremental_selection): When tracing, don't assume
8545 unsigned int is less than INT_MAX.
8546 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8547 harmful) conversions of unsigned short to int.
8548 (lisp_data_to_selection_data): Don't assume that integers
8549 in the range -65535 through -1 fit in an X unsigned short.
8550 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8551 result parameters unless successful. Rely on cons_to_unsigned
8552 to report problems with elements; the old code wasn't right anyway.
8553 (x_check_property_data): Check for int overflow; we cannot use
8554 a wider type due to X limits.
8555 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8556
726e0ab1 8557 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8558
0065d054
PE
8559 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8560 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8561 (x_color_cells): Don't store size until memory allocation succeeds.
8562 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8563 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8564 (x_term_init): Don't assume length fits in int (sprintf is limited
8565 to int size).
bc18e09d 8566
ebfa62c0
PE
8567 Use ptrdiff_t for composition IDs.
8568 * character.c (lisp_string_width):
8569 * composite.c (composition_table_size, n_compositions)
8570 (get_composition_id, composition_gstring_from_id):
8571 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8572 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8573 * window.c (Frecenter):
8574 Use ptrdiff_t, not int, for composition IDs.
8575 * composite.c (get_composition_id): Check for integer overflow.
8576 * composite.h: Adjust prototypes to match the above changes.
8577
d3411f89
PE
8578 Use ptrdiff_t for hash table indexes.
8579 * category.c (hash_get_category_set):
8580 * ccl.c (ccl_driver):
8581 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8582 * coding.c (coding_system_charset_list, detect_coding_system):
8583 * coding.h (struct coding_system.id):
8584 * composite.c (get_composition_id, gstring_lookup_cache):
8585 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8586 * image.c (xpm_get_color_table_h):
8587 * lisp.h (hash_lookup, hash_put):
8588 * minibuf.c (Ftest_completion):
8589 Use ptrdiff_t for hash table indexes, not int (which is too
8590 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8591 32-bit --with-wide-int hosts).
8592
e097a6fa
PE
8593 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8594 Add a FIXME comment about memory leaks.
8595 (syms_of_charset): Don't assume xmalloc returns.
8596
5637687f
PE
8597 Don't assume that stated character widths fit in int.
8598 * character.c (Fchar_width, c_string_width, lisp_string_width):
8599 * character.h (CHAR_WIDTH):
8600 * indent.c (MULTIBYTE_BYTES_WIDTH):
8601 Use sanitize_char_width to avoid undefined and/or bad behavior
8602 with outlandish widths.
a66cfb1c 8603 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8604 now that we have two such functions. All uses changed.
8605 (sanitize_char_width): New inline function.
8606
a2271ba2
PE
8607 Don't assume that tab-width fits in int.
8608 * character.h (sanitize_width): New inline function.
8609 (SANE_TAB_WIDTH): New macro.
8610 (ASCII_CHAR_WIDTH): Use it.
8611 * indent.c (sane_tab_width): Remove. All uses replaced by
8612 SANE_TAB_WIDTH (current_buffer).
8613 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8614
18c52557
PE
8615 * fileio.c: Integer overflow issues with file modes.
8616 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8617
caeeedc1
PE
8618 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8619 Remove unreachable code.
8620 (read_hex, load_charset_map_from_file): Check for integer overflow.
8621
6df6ae42 8622 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8623 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8624 (x_send_scroll_bar_event): Likewise. Check that the size does not
8625 exceed limits imposed by XClientMessageEvent, as well as the usual
8626 ptrdiff_t and size_t limits.
8627
b13995db
PE
8628 * keyboard.c: Overflow, signedness and related fixes.
8629 (make_lispy_movement): Use same integer type in forward decl
8630 that is used in the definition.
8631 (read_key_sequence, keyremap_step):
8632 Change bufsize argument back to int, undoing my 2011-03-30 change.
8633 We prefer signed types, and int is wide enough here.
8634 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8635 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8636 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8637 length, not size_t. Use ptrdiff_t for index, not int.
8638 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8639 possibility of integer overflow.
8640
13464394
PE
8641 Overflow, signedness and related fixes for images.
8642
8643 * dispextern.h (struct it.stack[0].u.image.image_id)
8644 (struct_it.image_id, struct image.id, struct image_cache.size)
8645 (struct image_cache.used, struct image_cache.ref_count):
8646 * gtkutil.c (update_frame_tool_bar):
8647 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8648 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8649 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8650 * nsmenu.m (update_frame_tool_bar):
8651 * xdisp.c (calc_pixel_width_or_height):
8652 * xfns.c (image_cache_refcount):
8653 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8654 on typical 64-bit hosts.
8655
8656 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8657 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8658 Omit unnecessary casts to int.
8659 (parse_image_spec): Check that integers fall into 'int' range
8660 when the callers expect that.
8661 (image_ascent): Redo ascent calculation to avoid int overflow.
8662 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8663 (lookup_image): Remove unnecessary tests.
8664 (xbm_image_p): Locals are now of int, not EMACS_INT,
8665 since parse_image_check makes sure they fit into int.
8666 (png_load, gif_load, svg_load_image):
8667 Prefer int to unsigned where either will do.
8668 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8669 old tiff_error_handler and tiff_warning_handler.
8670 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8671 stack buffer overflows. It uses only the features of vsnprintf
8672 that are common to both POSIX and native Microsoft.
8673 (tiff_error_handler, tiff_warning_handler): Use it.
8674 (tiff_load, gif_load, imagemagick_load_image):
8675 Don't assume :index value fits in 'int'.
8676 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8677 (imagemagick_load_image): Check that crop parameters fit into
8678 the integer types that MagickCropImage accepts. Don't assume
8679 Vimagemagick_render_type has a nonnegative value. Don't assume
8680 size_t fits in 'long'.
8681 (gs_load): Use printmax_t to print the widest integers possible.
8682 Check for integer overflow when computing image height and width.
8683
c11821d4
EZ
86842011-08-26 Eli Zaretskii <eliz@gnu.org>
8685
8686 * xdisp.c (redisplay_window): Don't force window start if point
8687 will be invisible in the resulting window. (Bug#9324)
8688
0c95fcf7
EZ
86892011-08-25 Eli Zaretskii <eliz@gnu.org>
8690
8691 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8692 the display spec is of the form `(space ...)'.
8693 (handle_display_spec): Return the value returned by
8694 handle_single_display_spec, not just 1 or zero.
8695 (handle_single_display_spec): If the display spec is of the form
8696 `(space ...)', and specifies display in the text area, return 2
8697 rather than 1.
fee65a97 8698 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8699 accurately, and prefer exact match for point under bidi.
8700 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8701
8702 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8703 into disp_prop; all users changed.
8704
8705 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8706 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8707 for the text covered by the display property.
8708
e4ed06f1
CY
87092011-08-25 Chong Yidong <cyd@stupidchicken.com>
8710
8711 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8712 Change return value to nil.
8713 (Frecord_buffer): Delete unused function.
8714
f67cdd7f
EZ
87152011-08-24 Eli Zaretskii <eliz@gnu.org>
8716
5980d4c6
EZ
8717 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8718 buffers, return left-to-right.
8610fe8b
EZ
8719 (set_cursor_from_row): Consider candidate row a win if its glyph
8720 represents a newline and point is on that newline. Fixes cursor
8721 positioning on the newline at EOL of R2L text within L2R
8722 paragraph, and vice versa.
8723 (try_cursor_movement): Check continued rows, in addition to
8724 continuation rows. Fixes unwarranted scroll when point enters a
8725 continued line of R2L text within an L2R paragraph, or vice versa.
8726 (cursor_row_p): Consider the case of point being equal to
8727 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8728 from the end of a short line to the beginning of a continued line
8729 of R2L text within L2R paragraph.
8730 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8731 composed characters.
5980d4c6 8732
f67cdd7f
EZ
8733 * bidi.c (bidi_check_type): Use xassert.
8734 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8735 members.
8736
bca633fb
EZ
87372011-08-23 Eli Zaretskii <eliz@gnu.org>
8738
8739 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8740 a character.
8741
4a5885a7
CY
87422011-08-23 Chong Yidong <cyd@stupidchicken.com>
8743
8744 * nsfont.m (ns_otf_to_script): Fix typo.
8745
0902a04e
KH
87462011-08-22 Kenichi Handa <handa@m17n.org>
8747
8748 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8749 extra slot even if the purpose is char-code-property-table.
8750
1a2e6670
EZ
87512011-08-23 Eli Zaretskii <eliz@gnu.org>
8752
8ddde651
EZ
8753 * xdisp.c (redisplay_window): When computing centering_position,
8754 account for the height of the header line. (Bug#8874)
8755
425cc014
EZ
8756 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8757 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8758 candidate is selected by the mouse, and that candidate has a
8759 composed character under the mouse.
8760
1a2e6670
EZ
8761 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8762 coordinates reported by pos-visible-in-window-p for a composed
8763 character in column zero.
8764
8b76d6f8
SM
87652011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8766
8767 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8768
dac347dd
EZ
87692011-08-22 Eli Zaretskii <eliz@gnu.org>
8770
8771 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8772 consider it a hit if to_charpos is anywhere in the range of the
8773 composed buffer positions.
8774
e013fb34
CY
87752011-08-22 Chong Yidong <cyd@stupidchicken.com>
8776
8777 * image.c (gif_load): Don't assume that each subimage has the same
8778 dimensions as the base image. Handle disposal method that is
8779 "undefined" by the gif spec (Bug#9335).
8780
bd1ba3e8
CY
87812011-08-20 Chong Yidong <cyd@stupidchicken.com>
8782
8783 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8784 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8785
54a1215b
EZ
87862011-08-19 Eli Zaretskii <eliz@gnu.org>
8787
823564e5
EZ
8788 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8789 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8790 from an Org mode buffer to a Speedbar frame.
8791
54a1215b
EZ
8792 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8793 a composition, take its buffer position from IT->cmp_it.charpos.
8794 Fixes cursor positioning at the beginning of a line that begins
8795 with a composed character.
8796
9778ebcc
EZ
87972011-08-18 Eli Zaretskii <eliz@gnu.org>
8798
0be6ee06
EZ
8799 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8800 character bidirectional type, use STRONG_L instead. Fixes crashes
8801 in a buffer produced by `describe-categories'.
8802
9778ebcc
EZ
8803 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8804 members before the level stack, so they would be saved and
8805 restored when copying iterator state. Fixes incorrect reordering
8806 around TABs covered by display properties.
8807
156bffbe
AS
88082011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8809
6b02f655 8810 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8811
72ad093b
CY
88122011-08-17 Chong Yidong <cyd@stupidchicken.com>
8813
8814 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8815 (internal_condition_case_2, internal_condition_case_n):
8816 Remove unnecessary aborts (Bug#9081).
72ad093b 8817
35774242
EZ
88182011-08-17 Eli Zaretskii <eliz@gnu.org>
8819
8820 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8821 has no `load' handler, try opening the file locally. (Bug#9311)
8822
db76dd85
KB
88232011-08-16 Ken Brown <kbrown@cornell.edu>
8824
8825 * gmalloc.c: Expand comment.
8826
b215eee5
EZ
88272011-08-16 Eli Zaretskii <eliz@gnu.org>
8828
8829 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8830 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8831
a4579d33
KB
88322011-08-16 Ken Brown <kbrown@cornell.edu>
8833
8834 Fix memory allocation problems in Cygwin build (Bug#9273).
8835
8836 * unexcw.c ( __malloc_initialized): Declare external variable.
8837 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8838
8b76d6f8
SM
8839 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8840 New variables.
a4579d33
KB
8841 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8842 dumped emacs.
8843 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8844 in the static heap.
8845 [CYGWIN] (special_realloc): New function.
8846 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8847 requests to realloc storage in the static heap.
8848
3ebec551
PE
88492011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8850
8851 * bidi.c (bidi_initialize): Remove unused local.
8852
9fd8be00
EZ
88532011-08-15 Eli Zaretskii <eliz@gnu.org>
8854
6b02f655
SM
8855 * bidimirror.h:
8856 * biditype.h: Remove file.
8857 * makefile.w32-in ($(BLD)/bidi.$(O)):
8858 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8859
8860 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8861
8862 * chartab.c: Improve commentary for the uniprop_table API.
8863
32413314
EZ
8864 * bidi.c (bidi_paragraph_init): Support zero value of
8865 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8866 (bidi_initialize): Use uniprop_table instead of including
8867 biditype.h and bidimirror.h.
32413314 8868
9fd8be00
EZ
8869 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8870 coordinates of the iterator when restoring from ppos_it.
8871 (Bug#9296)
8872
5cf2b69b
KH
88732011-08-14 Kenichi Handa <handa@m17n.org>
8874
8875 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8876 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8877
daf17d00
EZ
88782011-08-14 Eli Zaretskii <eliz@gnu.org>
8879
8880 * xdisp.c (move_it_in_display_line_to): Don't invoke
8881 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8882 ppos_it. Fixes vertical cursor motion when line beginning is
8883 covered by an image. (Bug#9296)
8884
08e3161a
JD
88852011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8886
8887 * nsterm.h (ns_run_ascript): Declare.
8888 (NSAPP_DATA2_RUNASSCRIPT): Define.
8889
8890 * nsfns.m (as_script, as_result, as_status): New static variables.
8891 (ns_run_ascript): New function.
5e617bc2 8892 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8893 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8894 the event loop. Get status from as_status (Bug#7276).
8895
8896 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8897 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8898 the event loop (Bug#7276).
8899
a3720aa2
AS
89002011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8901
8902 * gnutls.c (QCgnutls_bootprop_priority)
8903 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8904 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8905 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8906 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8907 (QCgnutls_bootprop_verify_hostname_error)
8908 (QCgnutls_bootprop_callbacks_verify): Rename from
8909 Qgnutls_bootprop_..., all uses changed.
8910
8911 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8912 uses changed.
8913
0a0d27fb
PE
89142011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8915
19d5c50c
PE
8916 * xfaces.c (Qframe_set_background_mode): Now static.
8917 * dispextern.h (Qframe_set_background_mode): Remove decl.
8918
0a0d27fb
PE
8919 * process.c (Fnetwork_interface_info): Declare local only if needed.
8920
377538cb
JD
89212011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8922
8923 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8924 (Fnetwork_interface_list): Allocate in increments of bytes instead
8925 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8926 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8927 sockaddr.
8928 (struct ifflag_def): notrailers is smart on OSX.
8929 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8930 Get hardware address with getifaddrs if available.
8931
08fff70c
EZ
89322011-08-12 Eli Zaretskii <eliz@gnu.org>
8933
8934 * xdisp.c (iterate_out_of_display_property): xassert that
8935 IT->position is set to within IT->object's boundaries. Break from
8936 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8937 when IT->position is set up wrongly due to some bug.
8938 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8939 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8940 entry. Force push_it to save on the stack the current
8941 buffer/string position, to be restored by pop_it. Fix flags in
8942 the iterator structure wrt the object coming from a display
8943 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8944 properties. (Bug#9284)
8945
7be1c708 89462011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8947
7be1c708
CY
8948 * fontset.c (fontset_get_font_group): Add proper type checks.
8949 (Bug#9172)
aac0c6e3 8950
7be1c708 89512011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8952
7be1c708
CY
8953 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8954 and LC_VERSION_MIN_MACOSX.
8955 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8956 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8957
97bb72a6
EZ
89582011-08-08 Eli Zaretskii <eliz@gnu.org>
8959
8960 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8961 no-display-properties-and-no-overlays under bidi display.
8962 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8963 properties and overlays.
97bb72a6 8964
d5617611
CY
89652011-08-08 Chong Yidong <cyd@stupidchicken.com>
8966
37e11a63
CY
8967 * editfns.c (Fset_time_zone_rule): Document relationship with the
8968 setenv function.
8969
d5617611
CY
8970 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8971 the font entity extracted from the cache (Bug#8109).
8972
58872834
CY
89732011-08-07 Chong Yidong <cyd@stupidchicken.com>
8974
8975 * composite.c (autocmp_chars): Don't reset point. That is done by
8976 restore_point_unwind (Bug#5984).
8977
75bfc667
JL
89782011-08-07 Juri Linkov <juri@jurta.org>
8979
8980 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8981 to show the arg `TIME' instead of `TIMEVAL'.
8982
d1410150
EZ
89832011-08-06 Eli Zaretskii <eliz@gnu.org>
8984
8985 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8986 display property strides EOL and includes a newline, as in
8987 longlines-mode. (Bug#9254)
75b771e4
EZ
8988 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8989 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8990
8991 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8992 is non-zero, even if the data buffer is NULL. Fixes a crash in
8993 vertical-motion with longlines-mode. (Bug#9254)
8994
35928349
EZ
89952011-08-05 Eli Zaretskii <eliz@gnu.org>
8996
ec7cc85b
EZ
8997 * bidi.c <bidi_cache_total_alloc>: Now static.
8998 (bidi_initialize): Initialize bidi_cache_total_alloc.
8999
8b76d6f8 9000 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
9001 cache. (Bug#9221)
9002
9003 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
9004 amount allocated this far in `bidi_cache_total_alloc'.
9005 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
9006 non-zero, only free the data buffer without restoring the cache
9007 contents. All callers changed.
9008
9009 * dispextern.h (bidi_unshelve_cache): Update prototype.
9010
9011 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
9012 (move_it_in_display_line, move_it_to)
9013 (move_it_vertically_backward, move_it_by_lines): Replace the call
9014 to xfree to an equivalent call to bidi_unshelve_cache.
9015 (move_it_in_display_line_to): Fix logic of returning
412b6358 9016 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 9017
e2e2423b
EZ
90182011-08-05 Eli Zaretskii <eliz@gnu.org>
9019
9020 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
9021 came from a string character with a `cursor' property. (Bug#9229)
9022
ae9e757a
JD
90232011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9024
9025 * Makefile.in (LIB_PTHREAD): New variable.
9026 (LIBES): Add LIB_PTHREAD (Bug#9216).
9027
9028 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
9029 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
9030
213bd7f2
AS
90312011-08-04 Andreas Schwab <schwab@linux-m68k.org>
9032
6b02f655 9033 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 9034
99aaf75f
JD
90352011-08-04 Jan Djärv <jan.h.d@swipnet.se>
9036
9037 * xterm.c (x_find_topmost_parent): New function.
9038 (x_set_frame_alpha): Find topmost parent window with
9039 x_find_topmost_parent and set the property there also (bug#9181).
9040 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
9041
c74e9d86
PE
90422011-08-04 Paul Eggert <eggert@cs.ucla.edu>
9043
9044 * callproc.c (Fcall_process): Avoid vfork clobbering
9045 the local vars buffer, coding_systems, current_dir.
9046
640c8776
SM
90472011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
9048
9049 * keymap.c (Fmake_composed_keymap): Move to subr.el.
9050
f26d0e4c
PE
90512011-08-03 Paul Eggert <eggert@cs.ucla.edu>
9052
8a10d76c
PE
9053 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
9054 so that it is not optimized away.
9055
f26d0e4c
PE
9056 * xdisp.c (compute_display_string_pos): Remove unused local.
9057
55439c61
EZ
90582011-08-02 Eli Zaretskii <eliz@gnu.org>
9059
9060 Fix slow cursor motion and scrolling in large buffers with
9061 selective display, like Org Mode buffers. (Bug#9218)
9062
9063 * dispextern.h (struct bidi_it): New member disp_prop_p.
9064
9065 * xdisp.c: Remove one-slot cache of display string positions.
9066 (compute_display_string_pos): Accept an additional argument
5e617bc2 9067 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
9068 for a display string or property. If found, set DISP_PROP_P
9069 non-zero.
9070
9071 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
9072 DISP_PROP_P, and pass it to compute_display_string_pos.
9073 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
9074 non-zero. All callers of bidi_fetch_char changed.
9075
fb33fa43
SM
90762011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
9077
9078 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
9079
b099e063
DM
90802010-12-03 Don March <don@ohspite.net>
9081
9082 * keymap.c (Fdefine_key): Fix non-prefix key error message when
9083 last character M-[char] is translated to ESC [char] (bug#7541).
9084
5cc7f7af
KH
90852011-08-02 Kenichi Handa <handa@m17n.org>
9086
d0fffa3f 9087 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
9088
9089 * chartab.c (uniprop_table): Make it non-static.
9090
525d5e6e
EZ
90912011-08-01 Eli Zaretskii <eliz@gnu.org>
9092
9093 * xdisp.c (forward_to_next_line_start): Accept additional argument
9094 BIDI_IT_PREV, and store into it the state of the bidi iterator had
9095 on the newline.
9096 (reseat_at_next_visible_line_start): Use the bidi iterator state
9097 returned by forward_to_next_line_start to restore the state of
9098 it->bidi_it after backing up to previous newline. (Bug#9212)
9099
31011111
AS
91002011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9101
9102 * regex.c (re_comp): Protoize.
9103 (re_exec): Fix return type.
9104 (regexec): Fix type of `ret'. (Bug#9203)
9105
476371c4
PE
91062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9107
e5d76069
PE
9108 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9109 This is needed if max-image-size is a floating-point number.
9110
9a79b20c
AS
91112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9112
9113 * print.c (print_object): Print empty symbol as ##.
9114
9115 * lread.c (read1): Read ## as empty symbol.
9116
d8c2fa78
AA
91172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9118
9119 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9120 setting frame foreground color (Bug#9175).
9121 (x_set_background_color): Likewise.
9122
ffe57a7a
AA
9123 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9124 contents (Bug#9176).
9125 (EmacsTooltip -init): Remove bezels and add shadows to
9126 tooltip windows.
9127
bf3492a5
AA
9128 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9129 or scroll bar (Bug#8470).
9130
d55e9c53
AA
9131 * nsfont.m (nsfont_open): Remove assignment to voffset and
9132 unnecessary vars hshink, expand, hd, full_height, min_height.
9133 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9134
9135 * nsterm.h (nsfont_info): Remove voffset field.
9136
d8c2fa78 91372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9138
9139 Implement strike-through and overline on NextStep (Bug#8863).
9140
9141 * nsfont.m (nsfont_open): Use underline position provided by font,
9142 instead of hard-coded value of 2.
9143 (nsfont_draw): Call ns_draw_text_decoration instead.
9144
9145 * nsterm.h: Add declaration for ns_draw_text_decoration.
9146
9147 * nsterm.m (ns_draw_text_decoration): New function for drawing
9148 underline, overline, and strike-through.
9149 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9150 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9151 accommodate underlining, etc.
4843aac3 9152
4cc60b9b
EZ
91532011-07-28 Eli Zaretskii <eliz@gnu.org>
9154
bc7ece87
EZ
9155 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9156 default.
4cc60b9b 9157
476371c4
PE
91582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9159
66606eea
PE
9160 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9161 Without this fix, if a signal arrives just after memory fills up,
9162 'malloc' might be invoked reentrantly.
9163
476371c4
PE
9164 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9165 In other words, assume that every image size is allowed, on non-X
9166 hosts. This assumption is probably wrong, but it lets Emacs compile.
9167
f3fcc40d
AS
91682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9169
9170 * regex.c (re_iswctype): Convert return values to boolean.
9171
350c992f
EZ
91722011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9173
9174 * xdisp.c (compute_display_string_pos): Don't use cached display
9175 string position if the buffer had its restriction changed.
9176 (Bug#9184)
9177
5266b4bb
PE
91782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9179
9180 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9181
2573a837 91822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9183
41f55ccd 9184 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9185
39e378da
PE
9186 * bidi.c: Integer size and overflow fixes.
9187 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9188 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9189 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9190 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9191 (bidi_find_other_level_edge):
9192 Use ptrdiff_t instead of EMACS_INT where either will do.
9193 This works better on 32-bit hosts configured --with-wide-int.
9194 (bidi_cache_ensure_space): Check for size-calculation overflow.
9195 Use % rather than repeated addition, for better worst-case speed.
9196 Don't set bidi_cache_size until after xrealloc returns, because it
9197 might not return.
9198 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9199 (bidi_cache_ensure_space): Also check that the bidi cache size
9200 does not exceed that of the largest Lisp string or buffer. See Eli
9201 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9202
5e927815
PE
9203 * alloc.c (__malloc_size_t): Remove.
9204 All uses replaced by size_t. See Andreas Schwab's note
9205 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9206
ca4aa935
PE
9207 * image.c: Improve checking for integer overflow.
9208 (check_image_size): Assume that f is nonnull, since
9209 it is always nonnull in practice. This is one less thing to
9210 worry about when checking for integer overflow later.
9211 (x_check_image_size): New function, which checks for integer
9212 overflow issues inside X.
9213 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9214 This removes the need for a memory_full check.
9215 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9216 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9217 (xbm_read_bitmap_data): Change locals back to 'int', since
9218 their values must fit in 'int'.
9219 (xpm_load_image, png_load, tiff_load):
9220 Invoke x_create_x_image_and_pixmap earlier,
9221 to avoid much needless work if the image is too large.
9222 (tiff_load): Treat overly large images as if
9223 x_create_x_image_and_pixmap failed, not as malloc failures.
9224 (gs_load): Use x_check_image_size.
9225
5f8f9cc2
PE
9226 * gtkutil.c: Omit integer casts.
9227 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9228 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9229
5adf60bc
PE
9230 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9231
c8907a93
PE
9232 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9233 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9234 would wrongly return t on a 64-bit host.
9235
e3c25c68
PE
9236 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9237 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9238 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9239 and therefore cause GCC to emit a bogus diagnostic in some cases.
9240
3f791afe
PE
9241 * image.c: Integer signedness and overflow and related fixes.
9242 This is not an exhaustive set of fixes, but it's time to
9243 record what I've got.
9244 (lookup_pixel_color, check_image_size): Remove redundant decls.
9245 (check_image_size): Don't assume that arbitrary EMACS_INT values
9246 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9247 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9248 (tiff_load, imagemagick_load_image):
9249 Check for overflow in size calculations.
9250 (x_create_x_image_and_pixmap): Remove unnecessary test for
9251 xmalloc returning NULL; that can't happen.
9252 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9253 (xpm_color_bucket): Use better integer hashing function.
9254 (xpm_cache_color): Don't possibly over-allocate memory.
9255 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9256 (gif_memory_source):
9257 Use ptrdiff_t, not int or size_t, to record sizes.
9258 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9259 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9260 either works, as we prefer signed integers.
9261 (tiff_read_from_memory, tiff_write_from_memory):
9262 Return tsize_t, not size_t, since that's what the TIFF API wants.
9263 (tiff_read_from_memory): Don't fail simply because the read would
9264 go past EOF; instead, return a short read.
9265 (tiff_load): Omit no-longer-needed casts.
9266 (Fimagemagick_types): Don't assume size fits into 'int'.
9267
3cc5a532
PE
9268 Improve hashing quality when configured --with-wide-int.
9269 * fns.c (hash_string): New function, taken from sxhash_string.
9270 Do not discard information about ASCII character case; this
9271 discarding is no longer needed.
9272 (sxhash-string): Use it. Change sig to match it. Caller changed.
9273 * lisp.h: Declare it.
9274 * lread.c (hash_string): Remove, since we now use fns.c's version.
9275 The fns.c version returns a wider integer if --with-wide-int is
9276 specified, so this should help the quality of the hashing a bit.
9277
b312a492
PE
9278 * emacs.c: Integer overflow minor fix.
9279 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9280 Define only if GNU_LINUX.
9281 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9282
dfd153ae
PE
9283 * dispnew.c: Integer signedness and overflow fixes.
9284 Remove unnecessary forward decls, that were a maintenance hassle.
9285 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9286 All uses changed.
9287 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9288 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9289 (prepare_desired_row, line_draw_cost):
9290 Use int, not unsigned, where either works.
9291 (save_current_matrix, restore_current_matrix):
9292 Use ptrdiff_t, not size_t, where either works.
9293 (init_display): Check for overflow more accurately, and without
9294 relying on undefined behavior.
9295
a81d11a3
PE
9296 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9297 Remove, replacing with the new symbols in lisp.h. All uses changed.
9298 * fileio.c (make_temp_name):
9299 * filelock.c (lock_file_1, lock_file):
9300 * xdisp.c (message_dolog):
9301 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9302 Use pMd etc. instead.
9303 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9304 replacing the pWIDE etc. symbols removed from editfns.c.
9305
3300e6fd
PE
9306 * keyboard.h (num_input_events): Now uintmax_t.
9307 This is (very slightly) less likely to mess up due to wraparound.
9308 All uses changed.
9309
fd05c7e9
PE
9310 * buffer.c: Integer signedness fixes.
9311 (alloc_buffer_text, enlarge_buffer_text):
9312 Use ptrdiff_t rather than size_t when either will do, as we prefer
9313 signed integers.
9314
903fe15d
PE
9315 * alloc.c: Integer signedness and overflow fixes.
9316 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9317 (__malloc_size_t): Default to size_t, not to int.
9318 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9319 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9320 Prefer ptrdiff_t to size_t when either would do, as we prefer
9321 signed integers.
9322 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9323 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9324 Now const. Initialize with values that are in range even if char
9325 is signed.
9326 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9327 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9328 These functions do the right thing with sizes > 2**32.
9329 (check_depth): Now ptrdiff_t, not int.
9330 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9331 Adjust to new way of storing sizes. Check for size overflow bugs
9332 in rest of code.
9333 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9334 slightly wrong anyway, as it missed one instance of
9335 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9336 (refill_memory_reserve): Omit needless cast to size_t.
9337 (mark_object_loop_halt): Mark as externally visible.
9338
ac82cc6a
PE
9339 * xselect.c: Integer signedness and overflow fixes.
9340 (Fx_register_dnd_atom, x_handle_dnd_message):
9341 Use ptrdiff_t, not size_t, since we prefer signed.
9342 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9343 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9344 x_dnd_atoms_size and x_dnd_atoms_length.
9345
c2d1e36d
PE
9346 * doprnt.c: Prefer signed to unsigned when either works.
9347 * eval.c (verror):
9348 * doprnt.c (doprnt):
9349 * lisp.h (doprnt):
9350 * xdisp.c (vmessage):
9351 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9352 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9353 prefer signed arithmetic to avoid comparison confusion.
9354 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9355 but is a bit tricky.
9356
0e926e56
PE
9357 Assume freestanding C89 headers, string.h, stdlib.h.
9358 * data.c, doprnt.c, floatfns.c, print.c:
9359 Include float.h unconditionally.
9360 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9361 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9362 * regex.c: Likewise for stddef.h, string.h.
9363 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9364 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9365 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9366 (STDC_HEADERS): Remove obsolete defines.
9367 * sysdep.c: Include limits.h unconditionally.
9368
9cfdb3ec
PE
9369 Assume support for memcmp, memcpy, memmove, memset.
9370 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9371 * regex.c (memcmp, memcpy):
9372 Remove; we assume C89 now.
9373
9374 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9375 (__malloc_safe_bcopy): Remove; no longer needed.
9376
cf950e6b 9377 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9378 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9379 well either way, and we prefer signed to unsigned.
9380
dbf38e02
LMI
93812011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9382
9383 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9384 closes the connection while we're reading (bug#9182).
9385
d6f0886c 93862011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9387
d6f0886c
JD
9388 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9389 are specified (Bug#9168).
24e0f6b1 9390
2eb1f9e6
PE
93912011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9392
9393 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9394 Found by GCC static checking and --with-wide-int on a 32-bit host.
9395
22381272 93962011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9397
9398 * xdisp.c (compute_display_string_pos): Fix logic of caching
9399 previous display string position. Initialize cached_prev_pos to
9400 -1. Fixes slow-down at the beginning of a buffer.
9401
f25e39b4
EZ
94022011-07-24 Eli Zaretskii <eliz@gnu.org>
9403
9404 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9405 for attrs[LFACE_FONTSET_INDEX].
9406
04c4b52e
PE
94072011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9408
9409 * xml.c (parse_region): Remove unused local
9410 that was recently introduced.
9411
c1734fbd
EZ
94122011-07-23 Eli Zaretskii <eliz@gnu.org>
9413
be18c5a5
EZ
9414 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9415 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9416
c1734fbd
EZ
9417 * xdisp.c (move_it_in_display_line_to): Record the best matching
9418 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9419 exit if none of the characters scanned was an exact match.
9420 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9421 when exact match is impossible due to invisible text, and the
9422 lines are truncated.
9423
a258d627
JD
94242011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9425
9426 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9427 for OSX >= 10.7.
9428
b6d5a689
EZ
94292011-07-22 Eli Zaretskii <eliz@gnu.org>
9430
0f74f785
EZ
9431 Fix a significant slow-down of cursor motion with C-n, C-p,
9432 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9433 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9434 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9435 (next_element_from_buffer): Call compute_stop_pos_backwards to
9436 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9437 base_level_stop.
9438 (reseat): Don't look for prev_stop, as that could mean a very long
9439 run.
9440 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9441 <cached_disp_overlay_modiff>: Cache for last found display string
9442 position.
551918c1 9443 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9444 about the same buffer in the same area of character positions, and
9445 the buffer wasn't changed since the time the display string
9446 position was cached.
551918c1 9447
b2d0c91a
EZ
94482011-07-22 Eli Zaretskii <eliz@gnu.org>
9449
9450 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9451 is an integer, which is important for empty lines. (Bug#9149)
9452
043604ee
CY
94532011-07-22 Chong Yidong <cyd@stupidchicken.com>
9454
9455 * frame.c (Fmodify_frame_parameters): In tty case, update the
9456 default face if necessary (Bug#4238).
9457
da4adb04
CY
94582011-07-21 Chong Yidong <cyd@stupidchicken.com>
9459
9460 * editfns.c (Fstring_to_char): No need to explain what a character
9461 is in the docstring (Bug#6576).
9462
9abd0532
LMI
94632011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9464
9465 * xml.c (parse_region): Make sure we always return a tree.
9466
36881d16
HK
94672011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9468
9469 * xml.c (parse_region): If a document contains only comments,
9470 return that, too.
9471
1e98674d
LMI
94722011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9473
9474 * xml.c (make_dom): Return comments, too.
9475
590bd467
PE
94762011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9477
9478 Port to OpenBSD.
9479 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9480 and the surrounding thread.
9481 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9482 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9483 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9484 timer goes off.
9485 * s/openbsd.h (BROKEN_SIGIO): Define.
9486 * unexelf.c (unexec) [__OpenBSD__]:
9487 Don't update the .mdebug section of the Alpha COFF symbol table.
9488
f41628b2
LMI
94892011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9490
9491 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9492 (bug#8460).
9493
b59b67c5
PE
94942011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9495
15e3a074
PE
9496 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9497 This fixes some race conditions on the permissions of any newly
9498 created file.
9499
41bed37d
PE
9500 * alloc.c (valid_pointer_p): Use pipe, not open.
9501 This fixes some permissions issues when debugging.
9502
b59b67c5
PE
9503 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9504 If fchown fails to set both uid and gid, try to set just gid,
9505 as that is sometimes allowed. Adjust the file's mode to eliminate
9506 setuid or setgid bits that are inappropriate if fchown fails.
9507
925a6be7
SM
95082011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9509
9510 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9511 to compare Lisp_Objects.
9512 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9513 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9514 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9515
52968808
AS
95162011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9517
0a6a104b
AS
9518 * lread.c (read_integer): Unread even EOF character.
9519 (read1): Likewise. Properly record start position of symbol.
9520
52968808
AS
9521 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9522 symbol character follows.
9523
9e381cdd
PE
95242011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9525
9526 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9527 This works around a problem with the previous change to Fcopy_file.
9528 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9529 and without this change, GCC might complain about discarding
9530 fchown's return value.
9531
b5641435
JB
95322011-07-16 Juanma Barranquero <lekktu@gmail.com>
9533
9534 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9535
a8031457
PE
95362011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9537
9538 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9539
dd889327
LMI
95402011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9541
750c33f7
LMI
9542 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9543 it's used from the C level.
9544
dd889327
LMI
9545 * process.c: Use the same condition for POLL_FOR_INPUT in both
9546 keyboard.c and process.c (bug#1858).
9547
87e86684
LM
95482011-07-09 Lawrence Mitchell <wence@gmx.li>
9549
9550 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9551 (Fgnutls_boot): Use it.
9552
64348f40
AS
95532011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9554
9555 * doc.c (Fsubstitute_command_keys): Revert last change.
9556
1d698799
LMI
95572011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9558
f863868c
LMI
9559 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9560 quotes the next character, and doesn't affect other longer
9561 sequences (bug#8935).
9562
1d698799
LMI
9563 * lread.c (syms_of_lread): Clarify that is isn't only
9564 `eval-buffer' and `eval-defun' that's affected by
9565 `lexical-binding' (bug#8460).
9566
aa4b6df6
EZ
95672011-07-15 Eli Zaretskii <eliz@gnu.org>
9568
9569 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9570 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9571
5d856da6
PE
95722011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9573
ad6042bb
PE
9574 Fix minor problems found by static checking.
9575 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9576 (elsz): Now a signed constant, not a size_t var. We prefer signed
9577 types to unsigned, to avoid integer comparison confusion. Without
9578 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9579 "cannot optimize loop, the loop counter may overflow", a symptom
9580 of the confusion.
f00bbb22 9581 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9582 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9583
6468f31c
LMI
95842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9585
49080b10
LMI
9586 * search.c (Fre_search_backward): Mention `case-fold-search' in
9587 all the re_search_* functions (bug#8138).
9588
6468f31c
LMI
9589 * keyboard.c (Fopen_dribble_file): Document when the file is
9590 closed (bug#8056).
9591
c965adc5
EZ
95922011-07-14 Eli Zaretskii <eliz@gnu.org>
9593
df9733bf
EZ
9594 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9595 bidi_cache_idx.
9596
0bb23927
EZ
9597 Support bidi reordering of display and overlay strings.
9598 * xdisp.c (compute_display_string_pos)
9599 (compute_display_string_end): Accept additional argument STRING.
9600 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9601 (reseat_to_string): Initialize bidi_it->string.s and
9602 bidi_it->string.schars.
9603 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9604 NULL (avoids a crash in bidi_paragraph_init).
9605 Initialize itb.string.lstring.
0bb23927
EZ
9606 (init_iterator): Call bidi_init_it only of a valid
9607 buffer position was specified. Initialize paragraph_embedding to
9608 L2R.
9609 (reseat_to_string): Initialize the bidi iterator.
9610 (display_string): If we need to ignore text properties of
9611 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9612 original value of -1 will not work with bidi.)
9613 (compute_display_string_pos): First arg is now struct
9614 `text_pos *'; all callers changed. Support display properties on
9615 Lisp strings.
9616 (compute_display_string_end): Support display properties on Lisp
9617 strings.
9618 (init_iterator, reseat_1, reseat_to_string): Initialize the
9619 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9620 when iterating on a string not from display properties).
640c8776
SM
9621 (compute_display_string_pos, compute_display_string_end):
9622 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9623 arrow keys.
9624 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9625 base_level_stop; instead, set base_level_stop to BEGV.
9626 Fixes crashes in vertical-motion.
0bb23927
EZ
9627 (next_element_from_buffer): Improve commentary for when
9628 the iterator is before prev_stop.
9629 (init_iterator): Initialize bidi_p from the default value of
9630 bidi-display-reordering, not from buffer-local value. Use the
9631 buffer-local value only if initializing for buffer iteration.
9632 (handle_invisible_prop): Support invisible properties on strings
9633 that are being bidi-reordered.
9634 (set_iterator_to_next): Support bidi reordering of C strings and
9635 Lisp strings.
9636 (next_element_from_string): Support bidi reordering of Lisp
9637 strings.
9638 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9639 (display_string): Support display of R2L glyph rows.
9640 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9641 (init_iterator): Don't initialize it->bidi_p for strings
9642 here.
9643 (reseat_to_string): Initialize it->bidi_p for strings here.
9644 (next_element_from_string, next_element_from_c_string)
9645 (next_element_from_buffer): Add xassert's for correspondence
9646 between IT's object being iterated and it->bidi_it.string
9647 structure.
9648 (face_before_or_after_it_pos): Support bidi iteration.
9649 (next_element_from_c_string): Handle the case of the first string
9650 character that is not the first one in the visual order.
9651 (get_visually_first_element): New function, refactored from common
9652 parts of next_element_from_buffer, next_element_from_string, and
9653 next_element_from_c_string.
9654 (tool_bar_lines_needed, redisplay_tool_bar)
9655 (display_menu_bar): Force left-to-right direction. Add a FIXME
9656 comment for making that be controlled by a user option.
9657 (push_it, pop_it): Save and restore the state of the
9658 bidi iterator. Save and restore the bidi_p flag.
9659 (pop_it): Iterate out of display property for string iteration as
9660 well.
9661 (iterate_out_of_display_property): Support iteration over strings.
9662 (handle_single_display_spec): Set up it->bidi_it for iteration
9663 over a display string, and call bidi_init_it.
9664 (handle_single_display_spec, next_overlay_string)
9665 (get_overlay_strings_1, push_display_prop): Set up the bidi
9666 iterator for displaying display or overlay strings.
9667 (forward_to_next_line_start): Don't use the shortcut if
9668 bidi-iterating.
9669 (back_to_previous_visible_line_start): If handle_display_prop
9670 pushed the iterator stack, restore the internal state of the bidi
9671 iterator by calling bidi_pop_it same number of times.
9672 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9673 and we are bidi-iterating, don't decrement the iterator position;
9674 instead, set the first_elt flag in the bidi iterator, to produce
9675 the same effect.
9676 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9677 (push_display_prop): xassert that we are iterating a buffer.
9678 (push_it, pop_it): Save and restore paragraph_embedding member.
9679 (handle_single_display_spec, next_overlay_string)
9680 (get_overlay_strings_1, reseat_1, reseat_to_string)
9681 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9682 correctly. Don't assume unibyte strings are not bidi-reordered.
9683 (compute_display_string_pos)
9684 (compute_display_string_end): Fix handling the case of C string.
9685 (push_it, pop_it): Save and restore from_disp_prop_p.
9686 (handle_single_display_spec, push_display_prop): Set the
9687 from_disp_prop_p flag.
9688 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9689 (pop_it): Call iterate_out_of_display_property only if we are
9690 popping after iteration over a string that came from a display
9691 property. Fix a typo in popping stretch info. Add an assertion
9692 for verifying that the iterator position is in sync with the bidi
9693 iterator.
9694 (handle_single_display_spec, get_overlay_strings_1)
9695 (push_display_prop): Fix initialization of paragraph direction for
9696 string when that of the parent object is not yet determined.
9697 (reseat_1): Call bidi_init_it to resync the bidi
9698 iterator with IT's position. (Bug#7616)
9699 (find_row_edges): If ROW->start.pos gives position
9700 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9701 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9702 Reset the from_disp_prop_p flag.
9703 (SAVE_IT, RESTORE_IT): New macros.
9704 (pos_visible_p, face_before_or_after_it_pos)
9705 (back_to_previous_visible_line_start)
9706 (move_it_in_display_line_to, move_it_in_display_line)
9707 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9708 (try_scrolling, redisplay_window, display_line): Use them when
9709 saving a temporary copy of the iterator and restoring it back.
9710 (back_to_previous_visible_line_start, reseat_1)
9711 (init_iterator): Empty the bidi cache "stack".
9712 (move_it_in_display_line_to): If iterator ended up at
9713 EOL, but we never saw any buffer positions smaller than
9714 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9715 motion in bidi-reordered lines.
9716 (move_it_in_display_line_to): Record prev_method and prev_pos
9717 immediately before the call to set_iterator_to_next. Fixes cursor
9718 motion in bidi-reordered lines with stretch glyphs and strings
9719 displayed in margins. (Bug#8133) (Bug#8867)
9720 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9721 TO_CHARPOS.
640c8776
SM
9722 (pos_visible_p): Support positions in bidi-reordered lines.
9723 Save and restore bidi cache.
0bb23927
EZ
9724
9725 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9726 (bidi_paragraph_info): Delete unused struct.
9727 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9728 (bidi_cache_start): New variable.
9729 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9730 to zero.
9731 (bidi_cache_fetch_state, bidi_cache_search)
9732 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9733 (bidi_cache_find, bidi_peek_at_next_level)
9734 (bidi_level_of_next_char, bidi_find_other_level_edge)
9735 (bidi_move_to_visually_next): Compare cache index with
9736 bidi_cache_start rather than with zero.
9737 (bidi_fetch_char): Accept new argument STRING; all callers
9738 changed. Support iteration over a string. Support strings with
9739 display properties. Support unibyte strings. Fix the type of
9740 `len' according to what STRING_CHAR_AND_LENGTH expects.
9741 (bidi_paragraph_init, bidi_resolve_explicit_1)
9742 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9743 (bidi_level_of_next_char, bidi_move_to_visually_next):
9744 Support iteration over a string.
0bb23927
EZ
9745 (bidi_set_sor_type, bidi_resolve_explicit_1)
9746 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9747 can now be zero (for strings); special values 0 and -1 were
9748 changed to -1 and -2, respectively.
9749 (bidi_char_at_pos): New function.
9750 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9751 Call it instead of FETCH_MULTIBYTE_CHAR.
9752 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9753 initialized to valid values.
9754 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9755 values.
9756 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9757 the test for valid cached positions. Fix the logic for looking up
9758 the sentinel state in the cache. GCPRO the Lisp string we are
9759 iterating.
9760 (bidi_push_it, bidi_pop_it): New functions.
9761 (bidi_initialize): Initialize the bidi cache start stack pointer.
9762 (bidi_cache_ensure_space): New function, refactored from part of
9763 bidi_cache_iterator_state. Don't assume the required size is just
9764 one BIDI_CACHE_CHUNK away.
9765 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9766 (bidi_count_bytes, bidi_char_at_pos): New functions.
9767 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9768 always valid if bidi_cache_idx is valid.
9769 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9770 is valid if it's going to be used.
9771 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9772 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9773 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9774 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9775 (bidi_find_other_level_edge, bidi_cache_start_stack):
9776 All variables related to cache indices are now EMACS_INT.
c965adc5 9777
0bb23927
EZ
9778 * dispextern.h (struct bidi_string_data): New structure.
9779 (struct bidi_it): New member `string'. Make flag members be 1-bit
9780 fields, and put them last in the struct.
640c8776
SM
9781 (compute_display_string_pos, compute_display_string_end):
9782 Update prototypes.
0bb23927
EZ
9783 (bidi_push_it, bidi_pop_it): Add prototypes.
9784 (struct iterator_stack_entry): New members bidi_p,
9785 paragraph_embedding, and from_disp_prop_p.
9786 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9787 (bidi_shelve_cache, bidi_unshelve_cache):
9788 Declare prototypes.
0bb23927
EZ
9789
9790 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9791 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9792 and vector-like objects.
9793
9794 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9795 cache around display iteration.
9796
9797 * window.c (Fwindow_end, window_scroll_pixel_based)
9798 (displayed_window_lines, Frecenter): Save and restore the bidi
9799 cache around display iteration.
9800
3bbd2265
LMI
98012011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9802
9803 * editfns.c (Fdelete_region): Clarify the use of the named
9804 parameters (bug#6788).
9805
adc47434
MR
98062011-07-14 Martin Rudalics <rudalics@gmx.at>
9807
9808 * indent.c (Fvertical_motion): Set and restore w->pointm when
9809 saving and restoring the window's buffer (Bug#9006).
9810
837c31f8
LMI
98112011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9812
9813 * editfns.c (Fstring_to_char): Clarify just what is returned
9814 (bug#6576). Text by Eli Zaretskii.
9815
ac389d0c
JB
98162011-07-13 Juanma Barranquero <lekktu@gmail.com>
9817
9818 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9819
0be0ce47
EZ
98202011-07-13 Eli Zaretskii <eliz@gnu.org>
9821
9822 * buffer.c (mmap_find): Fix a typo.
9823
cd18e7e3
JB
98242011-07-13 Johan Bockgård <bojohan@gnu.org>
9825
9826 Fix execution of x selection hooks.
9827 * xselect.c (Qx_lost_selection_functions)
9828 (Qx_sent_selection_functions): New vars.
9829 (syms_of_xselect): DEFSYM them.
9830 (x_handle_selection_request): Pass Qx_sent_selection_functions
9831 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9832 (x_handle_selection_clear,x_clear_frame_selections):
9833 Pass Qx_lost_selection_functions rather than
9834 Vx_lost_selection_functions to Frun_hook_with_args.
9835
47ea7f44
PE
98362011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9837
ac389d0c 9838 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9839 The old code sometimes used this field without initializing it.
9840
47ea7f44
PE
9841 * alloc.c (gc_sweep): Don't read past end of array.
9842 In theory, the old code could also have corrupted Emacs internals,
9843 though it'd be very unlikely.
9844
bc985c87
AS
98452011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9846
9847 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9848 argument. (Bug#4026)
bc985c87 9849
0cf34688
LMI
98502011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9851
b3dadd76
LMI
9852 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9853 key" (bug#4257).
9854
0cf34688
LMI
9855 * window.c (Fset_window_start): Doc fix (bug#4199).
9856 (Fset_window_hscroll): Ditto.
9857
270768cd
PE
98582011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9859
077e3dda 9860 Fix minor new problems caught by GCC 4.6.1.
270768cd 9861 * term.c (init_tty): Remove unused local.
490011a6 9862 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9863 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9864 not used otherwise.
270768cd 9865
b1f58454
CY
98662011-07-12 Chong Yidong <cyd@stupidchicken.com>
9867
9868 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9869
22b9578d
LMI
98702011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9871
6e70ab07
LMI
9872 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9873 are the mini-buffer and the echo area (bug#3320).
9874
22b9578d
LMI
9875 * term.c (init_tty): Remove support for supdup, c10 and perq
9876 terminals, which are no longer supported (bug#1482).
9877
8974cc9f
JB
98782011-07-10 Johan Bockgård <bojohan@gnu.org>
9879
9880 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9881
a560d974
JD
98822011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9883
9884 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9885 for non-popups (Bug#3642).
9886
1dae0f0a
AS
98872011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9888
268c2c36 9889 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9890 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9891 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9892 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9893 * data.c (fmod): Likewise.
9894 * dispnew.c (swap_glyphs_in_rows): Likewise.
9895 * emacs.c (memory_warning_signal): Likewise.
9896 * floatfns.c (float_error): Likewise.
9897 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9898 (otf_open, font_otf_capability, generate_otf_features)
9899 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9900 Likewise.
9901 * image.c (pbm_read_file): Likewise.
9902 * indent.c (string_display_width): Likewise.
9903 * intervals.c (check_for_interval, search_for_interval)
9904 (inc_interval_count, count_intervals, root_interval)
9905 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9906 * lread.c (defalias): Likewise.
268c2c36 9907 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9908 * regex.c (set_image_of_range_1, set_image_of_range)
9909 (regex_grow_registers): Likewise.
9910 * sysdep.c (strerror): Likewise.
9911 * termcap.c (valid_filename_p, tprint, main): Likewise.
9912 * tparam.c (main): Likewise.
9913 * unexhp9k800.c (run_time_remap, save_data_space)
9914 (update_file_ptrs, read_header, write_header, calculate_checksum)
9915 (copy_file, copy_rest, display_header): Likewise.
9916 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9917 Likewise.
9918 * xdisp.c (check_it): Likewise.
9919 * xfaces.c (register_color, unregister_color, unregister_colors):
9920 Likewise.
9921 * xfns.c (print_fontset_result): Likewise.
9922 * xrdb.c (member, fatal, main): Likewise.
9923
99033785
PE
99242011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9925
9926 Fix minor problems found by static checking (Bug#9031).
9927 * chartab.c (char_table_set_range, map_sub_char_table):
9928 Remove unused locals.
9929 (uniprop_table): Now static.
9930 * composite.c (_work_char): Remove unused static var.
9931
9cb2ac56
JB
99322011-07-09 Juanma Barranquero <lekktu@gmail.com>
9933
9934 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9935
f25661f0
JD
99362011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9937
9938 * gtkutil.c (qttip_cb): Remove code without function.
9939
8278c4fe
EZ
99402011-07-09 Eli Zaretskii <eliz@gnu.org>
9941
9942 * w32.c (pthread_sigmask): New stub.
9943
1692ae2d 99442011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9945
8a6ebd58 9946 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9947 sigprocmask is portable only for single-threaded applications, and
9948 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9949 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9950 (LIBES): Use it.
9951 * callproc.c (Fcall_process):
9952 * process.c (create_process):
9953 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9954 Use pthread_sigmask, not sigprocmask.
123403e4 9955
1b854618
JD
99562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9957
9958 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9959 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9960 wrong (Bug#8591).
9961
3fe4b549
JD
99622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9963
0ce7e563
JD
9964 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9965 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9966 (xg_hide_tooltip): Fix comment.
9967
3fe4b549
JD
9968 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9969 in registerServicesMenuSendTypes.
9970 (validRequestorForSendType): Don't check ns_return_types.
9971
9972 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9973 ns_return_type.
9974
5df75e47
JR
99752011-07-08 Jason Rumney <jasonr@gnu.org>
9976
22610910
JR
9977 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9978 SH_SHOW for hidden windows (Bug#5482).
9979
5df75e47
JR
9980 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9981 frame struct members of non-existent frames (Bug#6284).
9982
699c10bd
JD
99832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9984
4393663b
JD
9985 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9986 variable firstTime not needed on OSX >= 10.6.
9987 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9988 >= 10.5. Use setKnobProportion, setDoubleValue.
9989
9990 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9991 (MAC_OS_X_VERSION_10_5): Define if not defined.
9992 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9993 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9994 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9995
9996 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9997 cString and lossyCString on OSX >= 10.4.
4393663b 9998
58179cce 9999 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
10000 sizeToFit on OSX >= 10.2.
10001
10002 * nsimage.m (allocInitFromFile): Don't use deprecated method
10003 bestRepresentationForDevice on OSX >= 10.6.
10004
10005 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
10006 to avoid warning.
10007
10008 * emacs.c: Declare unexec_init_emacs_zone.
10009
a63e0781
JD
10010 * nsgui.h: Fix compiler warning about gnulib redefining verify.
10011
699c10bd
JD
10012 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
10013
10014 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
10015 on svcsMenu (Bug#8842).
10016
10017 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
10018 ns_return_types.
10019 (Fns_list_services): Just return Qnil on 10.6, code not working there.
10020
10021 * nsterm.m (QUTF8_STRING): Declare.
10022 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
10023 (validRequestorForSendType): Return type is (id).
10024 Change indexOfObjectIdenticalTo to indexOfObject.
10025 Check if we have local selection before returning self (Bug#8842).
10026 (writeSelectionToPasteboard): Put local selection into paste board
10027 if we have a local selection (Bug#8842).
10028 (syms_of_nsterm): DEFSYM QUTF8_STRING.
10029
10030 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
10031 (ns_get_local_selection): Declare.
10032
54e10184
LMI
100332011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
10034
9888ff71
LMI
10035 * keymap.c (describe_map_tree): Don't insert a double newline at
10036 the end of the buffer (bug#1169) and return whether we inserted
10037 something.
10038
54e10184
LMI
10039 * callint.c (Fcall_interactively): Change "reading args" to
10040 "providing args" to try to clarify what it does (bug#1010).
10041
15fa4783
KH
100422011-07-07 Kenichi Handa <handa@m17n.org>
10043
10044 * composite.c (composition_compute_stop_pos): Ignore a static
10045 composition starting before CHARPOS (Bug#8915).
10046
10047 * xdisp.c (handle_composition_prop): Likewise.
10048
a8815b00
EZ
100492011-07-07 Eli Zaretskii <eliz@gnu.org>
10050
10051 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
10052 (Bug#9015)
10053
ef7b981d 100542011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
10055
10056 * character.h (unicode_category_t): New enum type.
10057
10058 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
10059 (Qchar_code_property_table): New variable.
10060 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
10061 (UNIPROP_COMPRESSED_FORM_P): New macros.
10062 (char_table_ascii): Uncompress the compressed values.
10063 (sub_char_table_ref): New arg is_uniprop. Callers changed.
10064 Uncompress the compressed values.
ac389d0c 10065 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
10066 (char_table_ref_and_range): Uncompress the compressed values.
10067 (sub_char_table_set): New arg is_uniprop. Callers changed.
10068 Uncompress the compressed values.
10069 (sub_char_table_set_range): Args changed. Callers changed.
10070 (char_table_set_range): Adjuted for the above change.
10071 (map_sub_char_table): Delete args default_val and parent. Add arg
10072 top. Give decoded values to a Lisp function.
640c8776 10073 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
10074 values to a Lisp function. Gcpro more variables.
10075 (uniprop_table_uncompress)
10076 (uniprop_decode_value_run_length): New functions.
10077 (uniprop_decoder, uniprop_decoder_count): New variables.
10078 (uniprop_get_decoder, uniprop_encode_value_character)
10079 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
10080 New functions.
10081 (uniprop_encoder, uniprop_encoder_count): New variables.
10082 (uniprop_get_encoder, uniprop_table)
10083 (Funicode_property_table_internal, Fget_unicode_property_internal)
10084 (Fput_unicode_property_internal): New functions.
10085 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
10086 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 10087 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
10088 char-code-property-alist.
10089
640c8776 10090 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
10091 Vunicode_category_table.
10092
640c8776 10093 * font.c (font_range): Adjust for the change of
c805dec0
KH
10094 Vunicode_category_table.
10095
76b397fb
DN
100962011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
10097
10098 * m/iris4d.h: Remove file, move contents ...
10099 * s/irix6-5.h: ... here.
10100
22b4128e
PE
101012011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10102
10103 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10104 * alloc.c (mark_buffer):
10105 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10106 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10107 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10108 This isn't true in general, and it's particularly not true
10109 if Emacs is configured with --with-wide-int.
10110 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10111 New macros, used in the buffer.c change.
10112
869795d6
JD
101132011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10114
10115 * xsettings.c: Use both GConf and GSettings if both are available.
10116 (store_config_changed_event): Add comment.
10117 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10118 (store_tool_bar_style_changed): New functions.
5e617bc2 10119 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10120 (struct xsettings): Move font inside HAVE_XFT.
10121 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10122 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10123 Move inside HAVE_XFT.
640c8776 10124 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10125 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10126 also.
10127 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10128 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10129 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10130 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10131 (parse_settings): Move check for font inside HAVE_XFT.
10132 (read_settings, apply_xft_settings): Add comment.
10133 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10134 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10135 call store_font_name_changed.
10136 (xft_settings_event): Add comment.
10137 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10138 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10139 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10140 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10141 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10142 (xsettings_get_system_font, xsettings_get_system_normal_font):
10143 Add comment.
869795d6 10144
d8ed26bd
PE
101452011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10146
10147 Random fixes. E.g., (random) never returned negative values.
10148 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10149 subseconds part to the entropy, as that's a bit more random.
10150 Prefer signed to unsigned, since the signedness doesn't matter and
10151 in general we prefer signed. When given a limit, use a
10152 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10153 latter isn't right if USE_2_TAGS_FOR_INTS.
10154 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10155 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10156
cabf1cac
SM
101572011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10158
10159 * textprop.c (text_property_stickiness):
10160 Obey Vtext_property_default_nonsticky.
10161 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10162 * w32fns.c (syms_of_w32fns):
10163 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10164
6e9b2be9
PE
101652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10166
10167 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10168 This is more efficient than Ffile_directory_p and avoids a minor race.
10169
90186c68
LMI
101702011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10171
7c301272
LMI
10172 * buffer.c (Foverlay_put): Say what the return value is
10173 (bug#7835).
10174
c4f2d8d4
LMI
10175 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10176 is a directory before asking whether to use the file name
10177 (bug#7564).
ad637907
LMI
10178 (barf_or_query_if_file_exists): Make the "File is a directory"
10179 error be more correct.
c4f2d8d4 10180
90186c68
LMI
10181 * fns.c (Frequire): Remove the mention of the .gz files, since
10182 that's installation-specific, but keep the mention of
10183 `get-load-suffixes'.
10184
da64016e
PE
101852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10186
10187 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10188 Report string overflow if the output is too long.
10189
7d47b580
JB
101902011-07-04 Juanma Barranquero <lekktu@gmail.com>
10191
a555cb87
JB
10192 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10193 (syms_of_gnutls): Remove duplicate DEFSYM for
10194 Qgnutls_bootprop_verify_hostname_error, an error for
10195 Qgnutls_bootprop_verify_error (which is no longer used).
10196
7d47b580
JB
10197 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10198 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10199 Also (re)move comments that are misplaced or no longer relevant.
10200
1e49bfab
LMI
102012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10202
10203 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10204
1485f4c0
CY
102052011-07-03 Chong Yidong <cyd@stupidchicken.com>
10206
10207 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10208 and background color parameters if they have been changed.
10209
a9ab721e
LMI
102102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10211
10212 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10213
cf7cff57
PE
102142011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10215
2e13213d
PE
10216 * xsettings.c (SYSTEM_FONT): Define only when used.
10217 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10218
cf7cff57
PE
10219 * keymap.c (access_keymap_1): Now static.
10220
7a8e04f7
CY
102212011-07-02 Chong Yidong <cyd@stupidchicken.com>
10222
10223 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10224 leave any prefix arg for the up event (Bug#1586).
10225
61352f62
LMI
102262011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10227
69bb1ef7
LMI
10228 * lread.c (syms_of_lread): Mention single symbols defined by
10229 `defvar' or `defconst' (bug#7154).
10230
61352f62 10231 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10232 (Frequire): Mention get-load-suffixes.
61352f62 10233
28545e04
MR
102342011-07-02 Martin Rudalics <rudalics@gmx.at>
10235
10236 * window.h (window): Remove clone_number slot.
10237 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10238 Remove.
10239 (make_parent_window, make_window, saved_window)
10240 (Fset_window_configuration, save_window_save): Don't deal with
10241 clone numbers.
10242 * buffer.c (Qclone_number): Remove declaration.
10243 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10244
3349e122
SM
102452011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10246
10247 Add multiple inheritance to keymaps.
10248 * keymap.c (Fmake_composed_keymap): New function.
10249 (Fset_keymap_parent): Simplify.
10250 (fix_submap_inheritance): Remove.
10251 (access_keymap_1): New function extracted from access_keymap to handle
10252 embedded parents and handle lists of maps.
10253 (access_keymap): Use it.
10254 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10255 (Fcopy_keymap): Handle embedded parents.
10256 (Fcommand_remapping, define_as_prefix): Simplify.
10257 (Fkey_binding): Simplify.
10258 (syms_of_keymap): Move minibuffer-local-completion-map,
10259 minibuffer-local-filename-completion-map,
10260 minibuffer-local-must-match-map, and
10261 minibuffer-local-filename-must-match-map to Elisp.
10262 (syms_of_keymap): Defsubr make-composed-keymap.
10263 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10264 (parse_menu_item): Trivial simplification.
10265
3279eb87
GM
102662011-07-01 Glenn Morris <rgm@gnu.org>
10267
10268 * Makefile.in (SETTINGS_LIBS): Fix typo.
10269
39cb9e56 102702011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10271
10272 * coding.c (Fencode_coding_string): Record the last coding system
10273 used, as the function doc string says (bug#8738).
10274
0949d2b6
JD
102752011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10276
10277 * xsettings.c (store_monospaced_changed): Take new font as arg and
10278 check for change against current_mono_font.
10279 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10280 (emacs_settings_constructor, emacs_settings_get_property)
10281 (emacs_settings_set_property, emacs_settings_class_init)
10282 (emacs_settings_init, gsettings_obj): Remove.
10283 (something_changedCB): New function for HAVE_GSETTINGS.
10284 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10285 with value as argument.
10286 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10287 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10288 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10289 "changed".
10290
10291 * xgselect.c: Add defined (HAVE_GSETTINGS).
10292 (xgselect_initialize): Ditto.
10293
10294 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10295 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10296 xg_select.
10297
bbc6b304
PE
102982011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10299
10300 * eval.c (struct backtrace): Simplify and port the data structure.
10301 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10302 signed bit field, as this assumption is not portable and it makes
10303 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10304 "char debug_on_exit : 1" as this is not portable either; instead,
10305 use the portable "unsigned int debug_on_exit : 1". Remove unused
10306 member evalargs. Remove obsolete comments about cc bombing out.
10307
9851bfc5
JD
103082011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10309
51bb811f 10310 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10311 Let HAVE_GSETTINGS override HAVE_GCONF.
10312 (store_monospaced_changed): New function.
10313 (EMACS_SETTINGS): A new type derived from GObject to handle
10314 GSettings notifications.
10315 (emacs_settings_constructor, emacs_settings_get_property)
10316 (emacs_settings_set_property, emacs_settings_class_init):
10317 New functions.
10318 (gsettings_client, gsettings_obj): New variables.
10319 (GSETTINGS_SCHEMA): New define.
10320 (something_changedCB): Call store_monospaced_changed.
10321 (init_gsettings): New function.
10322 (xsettings_initialize): Call init_gsettings.
10323 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10324 to NULL.
10325
640c8776 10326 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10327 GCONF_CFLAGS/LIBS.
10328
5386012d
MR
103292011-06-29 Martin Rudalics <rudalics@gmx.at>
10330
10331 * window.c (resize_root_window, grow_mini_window)
10332 (shrink_mini_window): Rename Qresize_root_window to
10333 Qwindow_resize_root_window and Qresize_root_window_vertically to
10334 Qwindow_resize_root_window_vertically.
10335
f13e0b08
PE
103362011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10337
10338 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10339
94515237
JB
103402011-06-27 Juanma Barranquero <lekktu@gmail.com>
10341
10342 * makefile.w32-in: Redesign dependencies so they reflect more
10343 clearly which files are directly included by each source file,
10344 and not through other includes.
10345
e43b6e43
MR
103462011-06-27 Martin Rudalics <rudalics@gmx.at>
10347
10348 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10349 (sort_overlays, overlay_strings): When an overlay's clone number
10350 matches the window's clone number process the overlay even if
10351 the overlay's window property doesn't match the current window.
10352
d68443dc
MR
10353 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10354 (Fwindow_hchild): Rename to Fwindow_left_child.
10355 (Fwindow_next): Rename to Fwindow_next_sibling.
10356 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10357 (resize_window_check): Rename to window_resize_check.
10358 (resize_window_apply): Rename to window_resize_apply.
10359 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10360 (Fdelete_other_windows_internal, resize_frame_windows)
10361 (Fsplit_window_internal, Fdelete_window_internal)
10362 (grow_mini_window, shrink_mini_window)
10363 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10364
c7e73be5
JD
103652011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10366
10367 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10368 (emacs_fixed_set_min_size): Remove.
10369 (emacs_fixed_new): Take frame as argument.
10370
10371 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10372 (_EmacsFixedPrivate): Remove minwidth/height.
10373 Add struct frame *f.
10374 (emacs_fixed_init): Initialize priv->f.
10375 (get_parent_class, emacs_fixed_set_min_size): Remove.
10376 (emacs_fixed_new): Set priv->f to argument.
10377 (emacs_fixed_get_preferred_width)
10378 (emacs_fixed_get_preferred_height): Use min_width/height from
10379 frames size_hint to set minimum and natural (Bug#8919).
10380 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10381 and use min_width/height from frames size_hint to set
10382 min_width/height (Bug#8919).
10383
10384 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10385 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10386 Fix indentation.
c7e73be5 10387
cf99dcf8
EZ
103882011-06-26 Eli Zaretskii <eliz@gnu.org>
10389
10390 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10391 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10392 called at ZV.
10393
029529ac
CY
103942011-06-26 Chong Yidong <cyd@stupidchicken.com>
10395
10396 * process.c (wait_reading_process_output): Bypass select if
10397 waiting for a cell while ignoring keyboard input, and input is
10398 pending. Suggested by Jan Djärv (Bug#8869).
10399
7a7ef429
PE
104002011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10401
10402 Use gnulib's dup2 module instead of rolling our own.
10403 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10404
11fdef7d 104052011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10406
10407 * dispnew.c (scrolling_window): Before scrolling, turn off a
10408 mouse-highlight in the window being scrolled.
10409
cd3520a4
JB
104102011-06-24 Juanma Barranquero <lekktu@gmail.com>
10411
10412 Move DEFSYM to lisp.h and use everywhere.
10413
10414 * character.h (DEFSYM): Move declaration...
10415 * lisp.h (DEFSYM): ...here.
10416
10417 * gnutls.c:
10418 * minibuf.c:
10419 * w32menu.c:
10420 * w32proc.c:
10421 * w32select.c: Don't include character.h.
10422
10423 * alloc.c (syms_of_alloc):
10424 * buffer.c (syms_of_buffer):
10425 * bytecode.c (syms_of_bytecode):
10426 * callint.c (syms_of_callint):
10427 * casefiddle.c (syms_of_casefiddle):
10428 * casetab.c (init_casetab_once):
10429 * category.c (init_category_once, syms_of_category):
10430 * ccl.c (syms_of_ccl):
10431 * cmds.c (syms_of_cmds):
10432 * composite.c (syms_of_composite):
10433 * dbusbind.c (syms_of_dbusbind):
10434 * dired.c (syms_of_dired):
10435 * dispnew.c (syms_of_display):
10436 * doc.c (syms_of_doc):
10437 * editfns.c (syms_of_editfns):
10438 * emacs.c (syms_of_emacs):
10439 * eval.c (syms_of_eval):
10440 * fileio.c (syms_of_fileio):
10441 * fns.c (syms_of_fns):
10442 * frame.c (syms_of_frame):
10443 * fringe.c (syms_of_fringe):
10444 * insdel.c (syms_of_insdel):
10445 * keymap.c (syms_of_keymap):
10446 * lread.c (init_obarray, syms_of_lread):
10447 * macros.c (syms_of_macros):
10448 * msdos.c (syms_of_msdos):
10449 * print.c (syms_of_print):
10450 * process.c (syms_of_process):
10451 * search.c (syms_of_search):
10452 * sound.c (syms_of_sound):
10453 * syntax.c (init_syntax_once, syms_of_syntax):
10454 * terminal.c (syms_of_terminal):
10455 * textprop.c (syms_of_textprop):
10456 * undo.c (syms_of_undo):
10457 * w32.c (globals_of_w32):
10458 * window.c (syms_of_window):
10459 * xdisp.c (syms_of_xdisp):
10460 * xfaces.c (syms_of_xfaces):
10461 * xfns.c (syms_of_xfns):
10462 * xmenu.c (syms_of_xmenu):
10463 * xsettings.c (syms_of_xsettings):
10464 * xterm.c (syms_of_xterm): Use DEFSYM.
10465
4228cf16
TZ
104662011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10467
cd3520a4 10468 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10469
7fcccf1e
PE
104702011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10471
7efb4e0e
PE
10472 Integer and buffer overflow fixes (Bug#8873).
10473
ff5844ad
PE
10474 * print.c (printchar, strout): Check for string overflow.
10475 (PRINTPREPARE, printchar, strout):
10476 Don't set size unless allocation succeeds.
10477
90532f02
PE
10478 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10479 for sizes. Check for string overflow more accurately.
10480 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10481
6d84508d
PE
10482 * macros.c: Integer and buffer overflow fixes.
10483 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10484 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10485 Use ptrdiff_t, not int, for sizes.
10486 Don't increment bufsize until after realloc succeeds.
10487 Check for size-calculation overflow.
10488 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10489
437b2cb4
PE
10490 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10491
8b9ac8b4
PE
10492 * lread.c: Integer overflow fixes.
10493 (read_integer): Radix is now EMACS_INT, not int,
10494 to improve quality of diagnostics for out-of-range radices.
10495 Calculate buffer size correctly for out-of-range radices.
10496 (read1): Check for integer overflow in radices, and in
10497 read-circle numbers.
82cb60d3
PE
10498 (read_escape): Avoid int overflow.
10499 (Fload, openp, read_buffer_size, read1)
10500 (substitute_object_recurse, read_vector, read_list, map_obarray):
10501 Use ptrdiff_t, not int, for sizes.
10502 (read1): Use EMACS_INT, not int, for sizes.
20270765 10503 Check for size overflow.
8b9ac8b4 10504
7fcccf1e
PE
10505 * image.c (cache_image): Check for size arithmetic overflow.
10506
bfbbd7e7
PE
10507 * lread.c: Integer overflow issues.
10508 (saved_doc_string_size, saved_doc_string_length)
10509 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10510 Now ptrdiff_t, not int.
10511 (read1): Don't assume doc string length fits in int. Check for
10512 out-of-range doc string lengths.
10513 (read_list): Don't assume file position fits in int.
39019e54 10514 (read_escape): Check for hex character overflow.
bfbbd7e7 10515
4e323265
LL
105162011-06-22 Leo Liu <sdl.web@gmail.com>
10517
10518 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10519 Move to minibuffer.el.
10520
85fece3e
PE
105212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10522
20b84ce9 10523 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10524 The following patches are for when GLYPH_DEBUG && !XASSERT.
10525 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10526 * dispnew.c (flush_stdout):
10527 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10528 Mark as externally visible.
10529 * dispnew.c (check_window_matrix_pointers): Now static.
10530 * dispnew.c (window_to_frame_vpos):
10531 * xfns.c (unwind_create_frame):
10532 * xterm.c (x_check_font): Remove unused local.
10533 * scroll.c (CHECK_BOUNDS):
10534 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10535 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10536 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10537 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10538 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10539 Now static.
10540 (debug_method_add): Use va_list and vsprintf rather than relying
10541 on undefined behavior with wrong number of arguments.
10542 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10543 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10544 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10545 since we're not interested in debugging glyphs with old libraries.
10546 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10547 GCC 4.6.0's static checking.
10548
0766b489
PE
105492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10550
31fd4b32
PE
10551 Integer overflow and signedness fixes (Bug#8873).
10552 A few related buffer overrun fixes, too.
10553
b79e8648
PE
10554 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10555
0766b489
PE
10556 * dispextern.h (struct face.stipple):
10557 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10558 (x_bitmap_mask, x_allocate_bitmap_record)
10559 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10560 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10561 (x_create_bitmap_from_xpm_data):
10562 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10563 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10564 (.bitmaps_last):
10565 * xfaces.c (load_pixmap):
10566 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10567 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10568 (.bitmaps_last, struct x_output.icon_bitmap):
10569 Use ptrdiff_t, not int, for bitmap indexes.
10570 (x_allocate_bitmap_record): Check for size overflow.
10571 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10572
b081724f
PE
10573 Use ptrdiff_t, not int, for overlay counts.
10574 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10575 * editfns.c (overlays_around, get_pos_property):
10576 * textprop.c (get_char_property_and_overlay):
10577 * xdisp.c (next_overlay_change, note_mouse_highlight):
10578 * xfaces.c (face_at_buffer_position):
21514da7
PE
10579 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10580 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10581 (Fnext_overlay_change, Fprevious_overlay_change)
10582 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10583 Use ptrdiff_t, not int, for sizes.
21514da7 10584 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10585
3de73e5e
PE
10586 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10587
2606c57b
PE
10588 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10589 (x_session_initialize): Do not assume string length fits in int.
10590
aaafe47a
PE
10591 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10592 This is unlikely, but can occur if DPI is outlandish.
10593
2674ddc8 10594 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10595 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10596
28154962
PE
10597 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10598 * xrdb.c (magic_file_p, search_magic_path):
10599 Omit last arg SUFFIX; it was always 0. All callers changed.
10600 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10601
7de51af5
PE
10602 * xfont.c (xfont_match): Avoid need for strlen.
10603
25ed6cc3
PE
10604 * xfns.c: Don't assume strlen fits in int.
10605 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10606
4eab31dd
PE
10607 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10608 not unsigned long, as we prefer signed integers. All callers changed.
10609 Detect integer overflow in repeat count.
10610 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10611 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10612
171e2a58
PE
10613 * termcap.c: Don't assume sizes fit in int and never overflow.
10614 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10615 (gobble_line): Check for size-calculation overflow.
10616
ad39faca 10617 * minibuf.c (Fread_buffer):
6e5bb2dc 10618 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10619 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10620 Don't assume string length fits in int.
10621
52c61c22 10622 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10623 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10624
b5b8c9e5
PE
10625 * font.c: Don't assume string length fits in int.
10626 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10627 Use ptrdiff_t, not int.
ccd6111c
PE
10628 (font_intern_prop): Don't assume string length fits in int.
10629 Don't assume integer property fits in fixnum.
10630 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10631
882f0d81 10632 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10633 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10634 Reformulate so as not to need the command string.
10635 Invoke gzip -cd rather than gunzip, as it's more portable.
10636 (lock_info_type, lock_file_1, lock_file):
10637 Don't assume pid_t and time_t fit in unsigned long.
10638 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10639 (current_lock_owner): Prefer signed type for sizes.
10640 Use memcpy, not strncpy, where memcpy is what is really wanted.
10641 Don't assume (via atoi) that time_t and pid_t fit in int.
10642 Check for time_t and/or pid_t out of range, e.g., via a network share.
10643 Don't alloca where an auto var works fine.
10644
93f4cf88
PE
10645 * fileio.c: Fix some integer overflow issues.
10646 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10647 Don't assume string length fits in int.
10648 (directory_file_name): Don't assume string length fits in long.
10649 (make_temp_name): Don't assume pid fits in int, or that its print
10650 length is less than 20.
10651
f3e92b69
PE
10652 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10653
1bfdaf10
PE
10654 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10655
35016e9a
PE
10656 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10657
3d1e65a1
PE
10658 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10659 We prefer signed integers, even for size calculations.
10660
0b963a93
PE
10661 * emacs.c: Don't assume string length fits in 'int'.
10662 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10663 (main): Don't invoke strlen when not needed.
10664
573f4b54
PE
10665 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10666 (XD_DEBUG_MESSAGE): Don't waste a byte.
10667
989f33ba
PE
10668 * callproc.c (getenv_internal_1, getenv_internal)
10669 (Fgetenv_internal):
965d34eb
PE
10670 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10671
e4d29b33
PE
10672 * lread.c (invalid_syntax): Omit length argument.
10673 All uses changed. This doesn't fix a bug, but it simplifies the
10674 code away from its former Hollerith-constant appearance, and it's
10675 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10676 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10677
eb49b136
PE
10678 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10679 This didn't break anything, but it didn't help either.
10680 It's confusing to put a bogus integer in a place where the actual
10681 value does not matter.
9f62aeb1 10682 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10683 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10684
15375a22
PE
10685 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10686 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10687 implementation.
b61cc01c
PE
10688 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10689 We prefer signed types, and the value cannot exceed the EMACS_INT
10690 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10691 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10692 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10693 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10694
53b2623d
PE
10695 * indent.c (sane_tab_width): New function.
10696 (current_column, scan_for_column, Findent_to, position_indentation)
10697 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10698 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10699
51cab52b 10700 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10701
f2ed8a70
PE
10702 * lisp.h (lint_assume): New macro.
10703 * composite.c (composition_gstring_put_cache):
10704 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10705
abe80cc6
PE
10706 * editfns.c, insdel.c:
10707 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10708
b02c740e
PE
10709 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10710
ebc96716
PE
10711 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10712
b4e50fa0 10713 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10714 Use much-faster test for byte-length change.
311d5d7c 10715 Don't assume string byte-length fits in 'int'.
a4cf38e4 10716 Check that character arg fits in 'int'.
85461888 10717 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10718
c0c1ee9f
PE
10719 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10720
a498d7f4
PE
10721 * fns.c (concat): Catch string overflow earlier.
10722 Do not rely on integer wraparound.
10723
51cab52b
PE
10724 * dispextern.h (struct it.overlay_strings_charpos)
10725 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10726 * xdisp.c (forward_to_next_line_start)
10727 (back_to_previous_visible_line_start)
10728 (reseat_at_next_visible_line_start, next_element_from_buffer):
10729 Don't arbitrarily truncate the value of 'selective' to int.
10730
76031fad
PE
10731 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10732
5eb55db9
PE
10733 * composite.c: Don't truncate sizes to 'int'.
10734 (composition_gstring_p, composition_reseat_it)
10735 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10736 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10737 not EMACS_UINT, for indexes.
5eb55db9 10738
0703a717
PE
10739 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10740
d6202519
PE
10741 * buffer.c: Include <verify.h>.
10742 (struct sortvec.priority, struct sortstr.priority):
8961a454 10743 Now EMACS_INT, not int.
c20998a7 10744 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10745 (struct sortstr.size, record_overlay_string)
10746 (struct sortstrlist.size, struct sortlist.used):
10747 Don't truncate size to int.
10748 (record_overlay_string): Check for size-calculation overflow.
d6202519 10749 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10750
d5a19415
JM
107512011-06-22 Jim Meyering <meyering@redhat.com>
10752
029529ac 10753 Don't leak an XBM-image-sized buffer
d5a19415
JM
10754 * image.c (xbm_load): Free the image buffer after using it.
10755
a9041e6c
PE
107562011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10757
10758 Port to Sun C.
10759 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10760 that Sun C diagnosed.
10761 * fns.c (secure_hash): Fix pointer signedness issue.
10762 * intervals.c (static_offset_intervals): New function.
10763 (offset_intervals): Use it.
10764
7f3f739f
LL
107652011-06-21 Leo Liu <sdl.web@gmail.com>
10766
10767 * deps.mk (fns.o):
10768 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10769 sha512.h.
10770
10771 * fns.c (secure_hash): Rename from crypto_hash_function and change
10772 the first arg to accept symbols.
5b66d427 10773 (Fsecure_hash): New primitive.
7f3f739f
LL
10774 (syms_of_fns): New symbols.
10775
76147d94
DD
107762011-06-20 Deniz Dogan <deniz@dogan.se>
10777
10778 * process.c (Fset_process_buffer): Clarify return value in
10779 docstring.
10780
7d7d0045
CY
107812011-06-18 Chong Yidong <cyd@stupidchicken.com>
10782
10783 * dispnew.c (add_window_display_history): Use BVAR.
10784
10785 * xdisp.c (debug_method_add): Use BVAR.
10786 (check_window_end, dump_glyph_matrix, dump_glyph)
10787 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10788
10789 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10790 Likewise.
10791
10792 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10793 check till after the cache is created in init_frame_faces.
10794
ff2bc410
SM
107952011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10796
10797 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10798
28177add
PE
107992011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10800
dd3482fe
PE
10801 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10802 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10803 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10804
393d71f3 10805 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10806 * fileio.c (Finsert_file_contents):
10807 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10808 Remove the old (too-loose) buffer overflow checks.
10809 They weren't needed, since make_gap checks for buffer overflow.
10810 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10811 The old code merely checked for Emacs fixnum overflow, and relied
10812 on undefined (wraparound) behavior. The new code avoids undefined
10813 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10814
2e6813b0 10815 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10816 Tune. Don't use wider integers than needed. Don't use alloca.
10817 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10818
599a9e4f
PE
10819 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10820
99561444
PE
10821 * insdel.c, lisp.h (buffer_overflow): New function.
10822 (insert_from_buffer_1, replace_range, replace_range_2):
10823 * insdel.c (make_gap_larger):
10824 * editfns.c (Finsert_char):
10825 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10826
28177add
PE
10827 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10828
e69dafad
PE
108292011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10830
4baa020d 10831 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10832
b1c46f02
PE
10833 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10834 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10835
e69dafad
PE
10836 * fileio.c: Don't assume EMACS_INT fits in off_t.
10837 (emacs_lseek): New static function.
10838 (Finsert_file_contents, Fwrite_region): Use it.
10839 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10840
566684ea
PE
10841 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10842
e6966cd6
PE
10843 * fns.c: Don't overflow int when computing a list length.
10844 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10845 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10846 truncation on 64-bit hosts. Check for QUIT every
10847 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10848 faster and is responsive enough.
10849 (Flength): Report an error instead of overflowing an integer.
10850 (Fsafe_length): Return a float if the value is not representable
10851 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10852 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10853 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10854
dd0b0efb
PE
10855 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10856 (header_size, word_size): New constants.
10857 (allocate_vectorlike): Don't check size overflow here.
10858 (allocate_vector): Check it here instead, since this is the only
10859 caller of allocate_vectorlike that could cause overflow.
10860 Check that the new vector's length is representable as a fixnum.
10861
86fe5cfe
PE
10862 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10863 The previous code was bogus. For example, next_almost_prime (32)
10864 returned 39, which is undesirable as it is a multiple of 3; and
10865 next_almost_prime (24) returned 25, which is a multiple of 5 so
10866 why was the code bothering to check for multiples of 7?
10867
80e88859
PE
10868 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10869
4a2f0ad6
PE
10870 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10871
f66c7cf8
PE
10872 Variadic C functions now count arguments with ptrdiff_t.
10873 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10874 Back then I didn't know that the Emacs coding style prefers signed int.
10875 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10876 were being counted with int, which may truncate counts on 64-bit
10877 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10878 * lisp.h (struct Lisp_Subr.function.aMANY)
10879 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10880 Arg counts are now ptrdiff_t, not size_t.
10881 All variadic functions and their callers changed accordingly.
10882 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10883 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10884 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10885 * callint.c (Fcall_interactively): Check arg count for overflow,
10886 to avoid potential buffer overrun. Use signed char, not 'int',
10887 for 'varies' array, so that we needn't bother to check its size
10888 calculation for overflow.
10889 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10890 * eval.c (apply_lambda):
10891 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10892 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10893 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10894
a1759b76
PE
10895 * callint.c (Fcall_interactively): Don't use index var as event count.
10896
d96be9fc
PE
10897 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10898 * mem-limits.h (SIZE): Remove; no longer used.
10899
a690a978 10900 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10901
578c21e6
PE
10902 Remove unnecessary casts.
10903 * xterm.c (x_term_init):
10904 * xfns.c (x_set_border_pixel):
10905 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10906 These aren't needed now that we assume ANSI C.
10907
96f53c6c
PE
10908 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10909 It's more likely to cause problems (due to unsigned overflow)
10910 than to cure them.
10911
83c77d31
PE
10912 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10913
ee2079f1
PE
10914 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10915
6da65536
PE
10916 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10917
7147c4a4
PE
10918 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10919
193e32d9
PE
10920 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10921
e5533da6
PE
10922 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10923
9910e595
PE
10924 GLYPH_CODE_FACE returns EMACS_INT, not int.
10925 * dispextern.h (merge_faces):
10926 * xfaces.c (merge_faces):
01103c44
PE
10927 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10928 Don't assume EMACS_INT fits in int.
9910e595 10929
2638320e
PE
10930 * character.h (CHAR_VALID_P): Remove unused parameter.
10931 * fontset.c, lisp.h, xdisp.c: All uses changed.
10932
045eb8d9
PE
10933 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10934
c1f134b5
PE
10935 * fns.c (concat): Minor tuning based on overflow analysis.
10936 This doesn't fix any bugs. Use int to hold character, instead
10937 of constantly refetching from Emacs object. Use XFASTINT, not
10938 XINT, for value known to be a character. Don't bother comparing
10939 a single byte to 0400, as it's always less.
10940
395fcb93 10941 * floatfns.c (Fexpt):
327eeec8
PE
10942 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10943
abbd3d23
PE
10944 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10945 for characters.
10946
684a03ef
PE
10947 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10948
0fed43f3
PE
10949 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10950 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10951 incorrectly succeed when S was a string, because 4294967386 was
10952 truncated before it was used.
10953
8fd02eb7
PE
10954 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10955 Otherwise, an out-of-range integer could cause undefined behavior
10956 on a 64-bit host.
10957
f8c86b69
PE
10958 * composite.c: Use int, not EMACS_INT, for characters.
10959 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10960 EMACS_INT, for values that are known to be in character range.
10961 This doesn't fix any bugs but is the usual style inside Emacs and
10962 may generate better code on 32-bit machines.
10963
34206dd2
PE
10964 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10965 This is for reasons similar to the recent CHAR_STRING fix.
10966 * charset.c (Fencode_char): Check that character arg is actually
10967 a character. Pass an int to ENCODE_CHAR.
10968 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10969 wider than 'int', as a compile-time check to prevent future regressions
10970 in this area.
10971
c5958d4c 10972 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10973
10974 Make sure a 64-bit char is never passed to CHAR_STRING.
10975 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10976 by silently ignoring the top 32 bits, allowing some values
10977 that were far too large to be valid characters.
10978 * character.h: Include <verify.h>.
10979 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10980 arguments are no wider than unsigned, as a compile-time check
10981 to prevent future regressions in this area.
10982 * data.c (Faset):
01103c44 10983 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10984 (Fsubst_char_in_region):
10985 * fns.c (concat):
10986 * xdisp.c (decode_mode_spec_coding):
10987 Adjust to CHAR_STRING's new requirement.
10988 * editfns.c (Finsert_char, Fsubst_char_in_region):
10989 * fns.c (concat): Check that character args are actually
10990 characters. Without this test, these functions did the wrong
10991 thing with wildly out-of-range values on 64-bit hosts.
10992
d37ca623
PE
10993 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10994 These casts should not be needed on 32-bit hosts, either.
10995 * keyboard.c (read_char):
10996 * lread.c (Fload): Remove casts to unsigned.
10997
ea204efb
PE
10998 * lisp.h (UNSIGNED_CMP): New macro.
10999 This fixes comparison bugs on 64-bit hosts.
11000 (ASCII_CHAR_P): Use it.
11001 * casefiddle.c (casify_object):
01103c44 11002 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
11003 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
11004 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
11005 * dispextern.h (FACE_FROM_ID):
11006 * keyboard.c (read_char): Use UNSIGNED_CMP.
11007
41cb286c
PE
11008 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
11009 not to EMACS_INT, to avoid GCC warning.
11010
4a1b9832
PE
11011 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
11012
55daad71
PE
11013 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
11014 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
11015 isn't needed on 32-bit machines.
8f95c75c 11016
01103c44
PE
11017 * buffer.c (Fgenerate_new_buffer_name):
11018 Use EMACS_INT for count, not int.
0ceccced 11019 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
11020
11021 * data.c (Qcompiled_function): Now static.
11022
c6f072e7
PE
11023 * window.c (window_body_lines): Now static.
11024
20ce5912
PE
11025 * image.c (gif_load): Rename local to avoid shadowing.
11026
9c4c5f81
PE
11027 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
11028 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
11029 * alloc.c (make_save_value): Integer argument is now of type
11030 ptrdiff_t, not int.
11031 (mark_object): Use ptrdiff_t, not int.
11032 * lisp.h (pD): New macro.
11033 * print.c (print_object): Use it.
11034
c0c5c8ae
PE
11035 * alloc.c: Use EMACS_INT, not int, to count objects.
11036 (total_conses, total_markers, total_symbols, total_vector_size)
11037 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
11038 (total_free_floats, total_floats, total_free_intervals)
11039 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
11040 Now EMACS_INT, not int. All uses changed.
11041 (Fgarbage_collect): Compute overall total using a double, so that
11042 integer overflow is less likely to be a problem. Check for overflow
11043 when converting back to an integer.
5a25e253
PE
11044 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
11045 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
11046 These were 'int' variables that could overflow on 64-bit hosts;
11047 they were never used, so remove them instead of repairing them.
211a0b2a 11048 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
11049 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
11050 Previously, this ceilinged at INT_MAX, but that doesn't work on
11051 64-bit machines.
e46bb31a 11052 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 11053
c78baabf 11054 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 11055 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
11056 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
11057 when a (possibly-narrower) signed value would do just as well.
11058 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 11059
c9d624c6
PE
11060 * alloc.c: Catch some string size overflows that we were missing.
11061 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
11062 for convenience in STRING_BYTES_MAX.
11063 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
11064 The definition here is exact; the one in lisp.h was approximate.
11065 (allocate_string_data): Check for string overflow. This catches
11066 some instances we weren't catching before. Also, it catches
11067 size_t overflow on (unusual) hosts where SIZE_MAX <= min
11068 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
11069 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 11070
c9d624c6
PE
11071 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
11072 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 11073 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 11074
353032ce
PE
11075 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
11076
2bccce07
PE
11077 * alloc.c (Fmake_string): Check for out-of-range init.
11078
0ac30604
SM
110792011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
11080
11081 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
11082
c195f2de
JD
110832011-06-14 Jan Djärv <jan.h.d@swipnet.se>
11084
11085 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
11086 xg_get_default_scrollbar_width.
11087
11088 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
11089 (int_gtk_range_get_value): Move to the scroll bar part of the file.
11090 (style_changed_cb): Call update_theme_scrollbar_width and call
11091 x_set_scroll_bar_default_width and xg_frame_set_char_size for
11092 all frames (Bug#8505).
11093 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
11094 Call gtk_window_set_resizable if HAVE_GTK3.
11095 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
11096 and height if HAVE_GTK3 (Bug#8505).
11097 (scroll_bar_width_for_theme): New variable.
11098 (update_theme_scrollbar_width): New function.
11099 (xg_get_default_scrollbar_width): Move code to
11100 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11101 (xg_initialize): Call update_theme_scrollbar_width.
11102
11103 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11104
11105 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11106
e10ac9f1
MR
111072011-06-12 Martin Rudalics <rudalics@gmx.at>
11108
11109 * frame.c (make_frame): Call other_buffer_safely instead of
11110 other_buffer.
11111
11112 * window.c (temp_output_buffer_show): Call display_buffer with
11113 second argument Vtemp_buffer_show_specifiers and reset latter
11114 immediately after the call.
11115 (Vtemp_buffer_show_specifiers): New variable.
11116 (auto_window_vscroll_p, next_screen_context_lines)
11117 (Vscroll_preserve_screen_position): Remove leading asterisks from
11118 doc-strings.
11119
2d3c217e 111202011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11121
7b7f97e8 11122 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11123 * buffer.c (Qclone_number): Remove for now, as it's unused.
11124 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11125 (record_buffer): Remove unused local.
11126 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11127 (set_frame_buffer_list): Remove; unused.
11128 * frame.h (other_visible_frames): Remove decl.
11129 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11130 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11131 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11132 if HAVE_GPM.
11133 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11134 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11135 Define only if HAVE_GPM.
11136 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11137 (update_hints_inhibit): Remove; never set. All uses removed.
11138 * widgetprv.h (emacsFrameClassRec): Remove decl.
11139 * window.c (delete_deletable_window): Now returns void, since it
11140 wasn't returning anything.
11141 (compare_window_configurations): Remove unused locals.
11142 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11143 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11144 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11145 the same widths as pointers. This follows up on the 2011-05-06 patch.
11146 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11147 * xterm.h: Likewise.
11148 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11149
1384b89e
JB
111502011-06-12 Juanma Barranquero <lekktu@gmail.com>
11151
11152 * makefile.w32-in: Update dependencies.
11153 (LISP_H): Add lib/intprops.h.
11154
1100a63c
CY
111552011-06-11 Chong Yidong <cyd@stupidchicken.com>
11156
11157 * image.c (gif_load): Add animation frame delay to the metadata.
11158 (syms_of_image): Use DEFSYM. New symbol `delay'.
11159
6198ccd0
MR
111602011-06-11 Martin Rudalics <rudalics@gmx.at>
11161
11162 * window.c (delete_deletable_window): Re-add.
11163 (Fset_window_configuration): Rewrite to handle dead buffers and
11164 consequently deletable windows.
11165 (window_tree, Fwindow_tree): Remove. Supply functionality in
11166 window.el.
11167 (compare_window_configurations): Simplify code.
11168
b6e3633c
AS
111692011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11170
1ab0dee5
AS
11171 * image.c (imagemagick_load_image): Fix type mismatch.
11172 (Fimagemagick_types): Likewise.
11173
b6e3633c
AS
11174 * window.h (replace_buffer_in_windows): Declare.
11175
9397e56f
MR
111762011-06-11 Martin Rudalics <rudalics@gmx.at>
11177
11178 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11179 Qclone_number. Remove external declaration of Qdelete_window.
11180 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11181 code.
640c8776
SM
11182 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11183 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11184 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11185 buffer list implementation.
11186 (other_buffer_safely): New function.
11187 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11188 calls to replace_buffer_in_windows and
11189 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11190 if allowed.
11191 (record_buffer): Inhibit quitting and rewrite using quittable
11192 functions. Run Qbuffer_list_update_hook if allowed.
11193 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11194 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11195 Move switch-to-buffer to window.el.
9397e56f
MR
11196 (bury-buffer): Move to window.el.
11197 (Vbuffer_list_update_hook): New variable.
11198
11199 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11200 section.
11201
11202 * window.h (resize_frame_windows): Move up in code.
11203 (Fwindow_frame): Remove EXFUN.
11204 (replace_buffer_in_all_windows): Remove prototype.
11205 (replace_buffer_in_windows_safely): Add prototype.
11206
11207 * window.c: Declare Qdelete_window static again. Move down
11208 declaration of select_count.
11209 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11210 (Fother_window): Move to window.el.
11211 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11212 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11213 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11214 window.el.
11215 (replace_buffer_in_windows): Implement by calling
11216 Qreplace_buffer_in_windows.
11217 (replace_buffer_in_all_windows): Remove with some functionality
11218 moved into replace_buffer_in_windows_safely.
11219 (replace_buffer_in_windows_safely): New function.
11220 (select_window_norecord, select_frame_norecord): Move in front
11221 of run_window_configuration_change_hook. Remove now obsolete
11222 declarations.
640c8776
SM
11223 (Fset_window_buffer): Rewrite doc-string.
11224 Call Qrecord_window_buffer.
9397e56f
MR
11225 (keys_of_window): Move binding for other-window to window.el.
11226
b50691aa
CY
112272011-06-11 Chong Yidong <cyd@stupidchicken.com>
11228
11229 * dispextern.h (struct image): Replace data member, whose int_val
11230 and ptr_val fields were not used by anything, with a single
11231 lisp_val object.
11232
11233 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11234 (gif_clear_image, gif_load, imagemagick_load_image)
11235 (gs_clear_image, gs_load): Callers changed.
11236
3f754b86
PE
112372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11238
cca69397
PE
11239 * buffer.h: Include <time.h>, for time_t.
11240 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11241
109e28d0
PE
11242 Fix minor problems found by static checking.
11243
60737f02
PE
11244 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11245
4b66faf3
PE
11246 Make identifiers static if they are not used in other modules.
11247 * data.c (Qcompiled_function, Qframe, Qvector):
11248 * image.c (QimageMagick, Qsvg):
11249 * minibuf.c (Qmetadata):
11250 * window.c (resize_window_check, resize_root_window): Now static.
11251 * window.h (resize_window_check, resize_root_window): Remove decls.
11252
109e28d0
PE
11253 * window.c (window_deletion_count, delete_deletable_window):
11254 Remove; unused.
46a4ce9e
PE
11255 (window_body_lines): Now static.
11256 (Fdelete_other_windows_internal): Mark vars as initialized.
11257 Make sure 'resize_failed' is initialized.
11258 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11259 (resize_window_apply): Remove unused local.
11260 * window.h (delete_deletable_window): Remove decl.
11261
109e28d0 11262 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11263 (imagemagick_load_image): Fix pointer signedness problem by changing
11264 last arg from unsigned char * to char *. All uses changed.
11265 Also, fix a local for similar reasons.
11266 Remove unused locals. Remove locals to avoid shadowing.
11267 (fn_rsvg_handle_free): Remove; unused.
11268 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11269 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11270
3f754b86
PE
11271 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11272
2547adb1
CY
112732011-06-10 Chong Yidong <cyd@stupidchicken.com>
11274
11275 * image.c (gif_load): Fix omitted cast error introduced by
11276 2011-06-06 change.
11277
2c8e37d4
MR
112782011-06-10 Martin Rudalics <rudalics@gmx.at>
11279
11280 * window.h (resize_proportionally, orig_total_lines)
11281 (orig_top_line): Remove from window structure.
11282 (set_window_height, set_window_width, change_window_heights)
11283 (Fdelete_window): Remove prototypes.
11284 (resize_frame_windows): Remove duplicate declaration.
11285
440a42e3
EZ
112862011-06-10 Eli Zaretskii <eliz@gnu.org>
11287
11288 * window.h (resize_frame_windows, resize_window_check)
11289 (delete_deletable_window, resize_root_window)
11290 (resize_frame_windows): Declare prototypes.
11291
11292 * window.c (resize_window_apply): Make definition be "static" to
11293 match the prototype.
11294
562dd5e9
MR
112952011-06-10 Martin Rudalics <rudalics@gmx.at>
11296
11297 * window.c: Remove declarations of Qwindow_size_fixed,
11298 window_min_size_1, window_min_size_2, window_min_size,
11299 size_window, window_fixed_size_p, enlarge_window, delete_window.
11300 Remove static from declaration of Qdelete_window, it's
11301 temporarily needed by Fbury_buffer.
11302 (replace_window): Don't assign orig_top_line and
11303 orig_total_lines.
11304 (Fdelete_window, delete_window): Remove. Window deletion is
11305 handled by window.el.
640c8776
SM
11306 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11307 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11308 (Fdelete_other_windows): Remove. Deleting other windows is
11309 handled by window.el.
11310 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11311 handled in window.el.
11312 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11313 Window minimum sizes are handled in window.el.
11314 (shrink_windows, size_window, set_window_height)
11315 (set_window_width, change_window_heights, window_height)
11316 (window_width, CURBEG, CURSIZE, enlarge_window)
11317 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11318 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11319 handled in window.el.
11320 (make_dummy_parent): Rename to make_parent_window and give it a
11321 second argument horflag.
11322 (make_window): Don't set resize_proportionally any more.
11323 (Fsplit_window): Remove. Windows are split in window.el.
11324 (save_restore_action, save_restore_orig_size)
11325 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11326 Resize mini windows in window.el.
11327 (grow_mini_window, shrink_mini_window): Implement by calling
11328 Qresize_root_window_vertically, resize_window_check and
11329 resize_window_apply.
640c8776
SM
11330 (saved_window, Fset_window_configuration, save_window_save):
11331 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11332 resize_proportionally.
11333 (window_min_height, window_min_width): Move to window.el.
11334 (keys_of_window): Move bindings for delete-other-windows,
11335 split-window, delete-window and enlarge-window to window.el.
11336
11337 * buffer.c: Temporarily extern Qdelete_window.
11338 (Fbury_buffer): Temporarily call Qdelete_window instead of
11339 Fdelete_window (Fbury_buffer will move to window.el soon).
11340
11341 * frame.c (set_menu_bar_lines_1): Remove code handling
11342 orig_top_line and orig_total_lines.
11343
11344 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11345 set_window_height but set heights directly.
11346 (change_frame_size_1): Use resize_frame_windows.
11347
11348 * xdisp.c (init_xdisp): Don't use set_window_height but set
11349 heights directly.
11350
640c8776
SM
11351 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11352 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11353 run_window_configuration_change_hook.
11354
11355 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11356 instead of change_window_heights and run
11357 run_window_configuration_change_hook.
11358
1a13852e
MR
113592011-06-09 Martin Rudalics <rudalics@gmx.at>
11360
11361 * window.c (replace_window): Rename second argument REPLACEMENT to
11362 NEW. New third argument SETFLAG. Rewrite.
11363 (delete_window, make_dummy_parent): Call replace_window with
11364 third argument 1.
11365 (window_list_1): Move down in code.
11366 (run_window_configuration_change_hook): Move set_buffer part
11367 before select_frame_norecord part in order to unwind correctly.
11368 Rename count1 to count.
11369 (recombine_windows, delete_deletable_window, resize_root_window)
11370 (Fdelete_other_windows_internal)
11371 (Frun_window_configuration_change_hook, make_parent_window)
11372 (resize_window_check, resize_window_apply, Fresize_window_apply)
11373 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11374 (Fdelete_window_internal, Fresize_mini_window_internal):
11375 New functions.
1a13852e
MR
11376 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11377
f3d1777e
MR
113782011-06-08 Martin Rudalics <rudalics@gmx.at>
11379
496e208e
MR
11380 * window.h (window): Add some new members to window structure -
11381 normal_lines, normal_cols, new_total, new_normal, clone_number,
11382 splits, nest, prev_buffers, next_buffers.
11383 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11384 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11385
f3d1777e
MR
11386 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11387 Remove.
496e208e
MR
11388 (make_dummy_parent): Set new members of windows structure.
11389 (make_window): Move down in code. Handle new members of window
11390 structure.
11391 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11392 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11393 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11394 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11395 (Fset_window_next_buffers, Fset_window_clone_number):
11396 New functions.
496e208e
MR
11397 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11398 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11399 Doc-string fixes.
11400 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11401 Argument WINDOW can be now internal window too.
11402 (Fwindow_use_time): Move up in code.
11403 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11404 Rewrite doc-string.
11405 (Fset_window_configuration, saved_window)
11406 (Fcurrent_window_configuration, save_window_save): Handle new
11407 members of window structure.
b9e809c2
MR
11408 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11409 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11410 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11411 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11412 Qget_mru_window, Qresize_root_window,
11413 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11414 Qauto_buffer_name; staticpro them.
f3d1777e 11415
abde8f8c
MR
114162011-06-07 Martin Rudalics <rudalics@gmx.at>
11417
11418 * window.c (Fwindow_total_size, Fwindow_left_column)
11419 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11420 (Fwindow_list_1): New functions.
11421 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11422 (Fwindow_width, Fscroll_left, Fscroll_right):
11423 Use window_body_cols instead of window_box_text_cols.
11424 (delete_window, Fset_window_configuration):
11425 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11426 (delete_all_subwindows): Take a window as argument and not a
11427 structure. Rewrite.
190b47e6
MR
11428 (window_loop): Remove handling of GET_LRU_WINDOW and
11429 GET_LARGEST_WINDOW.
11430 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11431
11432 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11433 window_box_text_cols. delete_all_subwindows now takes a
11434 Lisp_Object as argument.
abde8f8c 11435
640c8776
SM
11436 * indent.c (compute_motion, Fcompute_motion):
11437 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11438
fa8a67e6
MR
11439 * frame.c (delete_frame): Call delete_all_subwindows with root
11440 window as argument.
11441
a54e3482
DC
114422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11443
11444 * fns.c (Fputhash): Document return value.
11445
60002bf5
CY
114462011-06-06 Chong Yidong <cyd@stupidchicken.com>
11447
11448 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11449
0c671da6 114502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11451
b862a52a 11452 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11453
be44ca6c
PE
11454 Check for overflow when converting integer to cons and back.
11455 * charset.c (Fdefine_charset_internal, Fdecode_char):
11456 Use cons_to_unsigned to catch overflow.
11457 (Fencode_char): Use INTEGER_TO_CONS.
11458 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11459 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11460 * data.c (long_to_cons, cons_to_long): Remove.
11461 (cons_to_unsigned, cons_to_signed): New functions.
11462 These signal an error for invalid or out-of-range values.
11463 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11464 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11465 * font.c (Ffont_variation_glyphs):
11466 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11467 * lisp.h: Include <intprops.h>.
11468 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11469 (cons_to_signed, cons_to_unsigned): New decls.
11470 (long_to_cons, cons_to_long): Remove decls.
11471 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11472 (Fprimitive_undo): Use CONS_TO_INTEGER.
11473 * xfns.c (Fx_window_property): Likewise.
11474 * xselect.c: Include <limits.h>.
11475 (x_own_selection, selection_data_to_lisp_data):
11476 Use INTEGER_TO_CONS.
11477 (x_handle_selection_request, x_handle_selection_clear)
11478 (x_get_foreign_selection, Fx_disown_selection_internal)
11479 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11480 (lisp_data_to_selection_data): Use cons_to_unsigned.
11481 (x_fill_property_data): Use cons_to_signed.
11482 Report values out of range.
11483
d1f3d2af
PE
11484 Check for buffer and string overflow more precisely.
11485 * buffer.h (BUF_BYTES_MAX): New macro.
11486 * lisp.h (STRING_BYTES_MAX): New macro.
11487 * alloc.c (Fmake_string):
11488 * character.c (string_escape_byte8):
11489 * coding.c (coding_alloc_by_realloc):
11490 * doprnt.c (doprnt):
11491 * editfns.c (Fformat):
11492 * eval.c (verror):
11493 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11494 since they may not be the same number.
11495 * editfns.c (Finsert_char):
11496 * fileio.c (Finsert_file_contents):
11497 Likewise for BUF_BYTES_MAX.
11498
dd52fcea
PE
11499 * image.c: Use ptrdiff_t, not int, for sizes.
11500 (slurp_file): Switch from int to ptrdiff_t.
11501 All uses changed.
11502 (slurp_file): Check that file size fits in both size_t (for
11503 malloc) and ptrdiff_t (for sanity and safety).
11504
7f9bbdbb
PE
11505 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11506 if b->modtime has its maximal value.
11507
dfe18f82
PE
11508 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11509
84acfcf0
PE
11510 Don't assume time_t can fit into int.
11511 * buffer.h (struct buffer.modtime): Now time_t, not int.
11512 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11513 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11514
ccd9a01a
PE
11515 Minor fixes for signed vs unsigned integers.
11516 * character.h (MAYBE_UNIFY_CHAR):
11517 * charset.c (maybe_unify_char):
11518 * keyboard.c (read_char, reorder_modifiers):
11519 XINT -> XFASTINT, since the integer must be nonnegative.
11520 * ftfont.c (ftfont_spec_pattern):
11521 * keymap.c (access_keymap, silly_event_symbol_error):
11522 XUINT -> XFASTINT, since the integer must be nonnegative.
11523 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11524 since it makes no difference and we prefer signed.
11525 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11526 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11527 nonnegative.
11528
d6d100dd
SM
115292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11530
11531 * window.h (Fwindow_frame): Declare.
11532
2b6148e4
PE
115332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11534
11535 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11536 (SPARE_MEMORY): Always define.
11537 (LARGE_REQUEST): Remove.
11538 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11539
f230ecc9
MR
115402011-06-06 Martin Rudalics <rudalics@gmx.at>
11541
727e958e
MR
11542 * lisp.h: Move EXFUNS for Fframe_root_window,
11543 Fframe_first_window and Fset_frame_selected_window to window.h.
11544
11545 * window.h: Move EXFUNS for Fframe_root_window,
11546 Fframe_first_window and Fset_frame_selected_window here from
11547 lisp.h.
11548
11549 * frame.c (Fwindow_frame, Fframe_first_window)
11550 (Fframe_root_window, Fframe_selected_window)
11551 (Fset_frame_selected_window): Move to window.c.
11552 (Factive_minibuffer_window): Move to minibuf.c.
11553 (Fother_visible_frames_p): New function.
11554
11555 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11556
f230ecc9
MR
11557 * window.c (decode_window, decode_any_window): Move up in code.
11558 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11559 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11560 (Fwindow_buffer): Move up and rewrite doc-string.
11561 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11562 (Fwindow_prev): New functions.
727e958e
MR
11563 (Fwindow_frame): Move here from frame.c. Accept any window as
11564 argument.
11565 (Fframe_root_window, Fframe_first_window)
11566 (Fframe_selected_window): Move here from frame.c. Accept frame
11567 or arbitrary window as argument. Update doc-strings.
11568 (Fminibuffer_window): Move up in code.
11569 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11570 (Fset_frame_selected_window): Move here from frame.c.
11571 Marginal rewrite.
727e958e
MR
11572 (Fselected_window, select_window, Fselect_window): Move up in
11573 code. Minor doc-string fixes.
f230ecc9 11574
4d09bcf6
PE
115752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11576
11577 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11578 Do not assume that spare memory exists; that assumption is valid
11579 only if SYSTEM_MALLOC.
11580 (LARGE_REQUEST): New macro, so that the issue of large requests
11581 is separated from the issue of spare memory.
11582
810928a2
AS
115832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11584
172418ad
AS
11585 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11586 format. (Bug#8806)
11587
43f862f7
AS
11588 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11589
810928a2
AS
11590 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11591 before statements.
11592
a059fe24
JD
115932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11594
11595 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11596
11597 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11598
11599 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11600 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11601
989bf368
JB
116022011-06-05 Juanma Barranquero <lekktu@gmail.com>
11603
11604 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11605
4b80f674
CY
116062011-06-04 Chong Yidong <cyd@stupidchicken.com>
11607
11608 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11609 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11610 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11611 New error handlers.
4b80f674
CY
11612 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11613 Obey Vx_select_enable_clipboard_manager. Catch errors in
11614 x_clipboard_manager_save (Bug#8779).
11615 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11616 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11617
99a33b77 116182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11619
11620 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11621
99a33b77 116222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11623
11624 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11625 in the current matrix if keep_current_p is non-zero.
11626
8264569d
EZ
116272011-06-04 Eli Zaretskii <eliz@gnu.org>
11628
11629 * bidi.c (bidi_level_of_next_char): Fix last change.
11630
57f97249
EZ
116312011-06-03 Eli Zaretskii <eliz@gnu.org>
11632
fec2107c 11633 Support bidi reordering of text covered by display properties.
57f97249 11634
fec2107c
EZ
11635 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11636 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11637 (bidi_cache_search, bidi_cache_iterator_state)
11638 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11639 (bidi_level_of_next_char, bidi_move_to_visually_next):
11640 Support character positions inside a run of characters covered by a
fec2107c
EZ
11641 display string.
11642 (bidi_paragraph_init, bidi_resolve_explicit_1)
11643 (bidi_level_of_next_char): Call bidi_fetch_char and
11644 bidi_fetch_char_advance instead of FETCH_CHAR and
11645 FETCH_CHAR_ADVANCE.
11646 (bidi_init_it): Initialize new members.
11647 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11648 definitions.
11649 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11650 instead of using explicit *_CHAR codes.
d6d100dd
SM
11651 (bidi_resolve_explicit, bidi_resolve_weak):
11652 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11653 bidirectional text is supported only in multibyte buffers.
11654 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11655 it to initialize the frame_window_p member of struct bidi_it.
11656 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11657 (bidi_resolve_explicit, bidi_resolve_weak)
11658 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11659 bidi_it->nchars is non-positive.
11660 (bidi_level_of_next_char): Don't try to lookup the cache for the
11661 next/previous character if nothing is cached there yet, or if we
11662 were just reseat()'ed to a new position.
c40e2fb2 11663
0e14fe90
EZ
11664 * xdisp.c (set_cursor_from_row): Set start and stop points
11665 according to the row's direction when priming the loop that looks
11666 for the glyph on which to display cursor.
11667 (single_display_spec_intangible_p): Function deleted.
11668 (display_prop_intangible_p): Reimplement to call
11669 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11670 Accept 3 additional arguments needed by handle_display_spec.
11671 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11672 values: lists, `(when COND...)' forms, etc.
11673 (single_display_spec_string_p): Support property values that are
11674 lists with the argument STRING its top-level element.
11675 (display_prop_string_p): Fix the condition for processing a
11676 property that is a list to be consistent with handle_display_spec.
fec2107c 11677 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11678 last portion of handle_display_prop.
11679 (compute_display_string_pos): Accept additional argument
11680 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11681 value of a `display' property is a "replacing spec".
11682 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11683 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11684 the display property, but just return a value indicating whether
11685 the display property will replace the characters it covers.
11686 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11687 frame_window_p members of struct bidi_it.
d6d100dd
SM
11688 (compute_display_string_pos, compute_display_string_end):
11689 New functions.
fec2107c
EZ
11690 (push_it): Accept second argument POSITION, where pop_it should
11691 jump to continue iteration.
11692 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11693
fec2107c
EZ
11694 * keyboard.c (adjust_point_for_property): Adjust the call to
11695 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11696
11697 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11698 (bidi_init_it): Update prototypes.
11699 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11700 (compute_display_string_pos, compute_display_string_end):
11701 Declare prototypes.
fec2107c
EZ
11702 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11703 EMACS_INT.
fc6f18ce 11704
40087514 117052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11706
57f53182
PE
11707 Malloc failure behavior now depends on size of allocation.
11708 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11709 * lisp.h: Change signatures accordingly.
11710 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11711 All callers changed. (Bug#8762)
11712
11713 * gnutls.c: Use Emacs's memory allocators.
11714 Without this change, the gnutls library would invoke malloc etc.
11715 directly, which causes problems on non-SYNC_INPUT hosts, and which
11716 runs afoul of improving memory_full behavior. (Bug#8761)
11717 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11718 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11719 xfree instead of the default malloc, realloc, free.
11720 (Fgnutls_boot): No need to check for memory allocation failure,
11721 since xmalloc does that for us.
11722
ac32cd99 11723 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11724 * category.c (hash_get_category_set):
11725 * ccl.c (ccl_driver):
11726 * charset.c (Fdefine_charset_internal):
11727 * charset.h (struct charset.hash_index):
11728 * composite.c (get_composition_id, gstring_lookup_cache)
11729 (composition_gstring_put_cache):
11730 * composite.h (struct composition.hash_index):
11731 * dispextern.h (struct image.hash):
11732 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11733 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11734 (hashfn_equal, hashfn_user_defined, make_hash_table)
11735 (maybe_resize_hash_table, hash_lookup, hash_put)
11736 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11737 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11738 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11739 * image.c (make_image, search_image_cache, lookup_image)
11740 (xpm_put_color_table_h):
11741 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11742 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11743 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11744 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11745 * alloc.c (allocate_vectorlike):
11746 Check for overflow in vector size calculations.
11747 * ccl.c (ccl_driver):
11748 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11749 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11750 need to be updated by these changes.
40087514
PE
11751 * fns.c (make_hash_table, maybe_resize_hash_table):
11752 Check for integer overflow with large hash tables.
0de4bb68
PE
11753 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11754 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11755 (SXHASH_REDUCE): New macro.
11756 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11757 Use it instead of discarding useful hash info with large hash values.
11758 (sxhash_float): New function.
11759 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11760 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11761 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11762 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11763 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11764 Adjust signatures to match updated version of code.
11765 (consing_since_gc): Now EMACS_INT, since a single hash table can
11766 use more than INT_MAX bytes.
11767
698d32e2
DN
117682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11769
11770 Make it possible to build with GCC-4.6+ -O2 -flto.
11771
11772 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11773
fd6fa53f
SM
117742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11775
11776 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11777 Call minibuffer-inactive-mode.
11778
864db017
JB
117792011-05-31 Juanma Barranquero <lekktu@gmail.com>
11780
11781 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11782 Update dependencies.
11783
2ad0baf4
DN
117842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11785
11786 * data.c (init_data): Remove code for UTS, this system is not
11787 supported anymore.
11788
4fcc2638
DN
117892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11790
11791 Don't force ./temacs to start in terminal mode.
11792
11793 * frame.c (make_initial_frame): Initialize faces in all cases, not
11794 only when CANNOT_DUMP is defined.
11795 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11796
c56e0fd5
DN
117972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11798
11799 * dispnew.c (add_window_display_history): Use const for the string
11800 pointer. Remove declaration, not needed.
11801
333d54da 118022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11803
55d4c1b2 11804 Use 'inline', not 'INLINE'.
333d54da 11805 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11806 * alloc.c, fontset.c (INLINE): Remove.
11807 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11808 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11809 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11810 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11811 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11812
738db178
DN
118132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11814
11815 Make it possible to run ./temacs.
11816
11817 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11818 syms_of_callproc does the same thing. Remove test for
11819 "initialized", do it in the caller.
11820 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11821
620c53a6
SM
118222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11823
11824 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11825 (read_minibuf): Use get_minibuffer.
11826 (syms_of_minibuf): Use DEFSYM.
11827 (Qmetadata): New var.
11828 * data.c (Qbuffer): Don't make it static.
11829 (syms_of_data): Use DEFSYM.
11830
e003a292
PE
118312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11832
11833 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11834 (CCL_CODE_MIN): New macro.
11835
ed008a6d
PE
118362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11837
3687c2ef
PE
11838 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11839
ed008a6d
PE
11840 * eval.c (Qdebug): Now static.
11841 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11842 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11843 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11844
d66c4c7c
CY
118452011-05-29 Chong Yidong <cyd@stupidchicken.com>
11846
11847 * image.c: Various fixes to ImageMagick code comments.
11848 (Fimagemagick_types): Doc fix.
11849
5fbc2025
PE
118502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11851
0196f88a
PE
11852 Minor fixes prompted by GCC 4.6.0 warnings.
11853
11854 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11855
5fbc2025
PE
11856 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11857 (x_clipboard_manager_save_all): Move extern decl to ...
11858 * xterm.h: ... here, so that it can be checked for consistency.
11859
1dd3c2d9
CY
118602011-05-29 Chong Yidong <cyd@stupidchicken.com>
11861
11862 * xselect.c (x_clipboard_manager_save_frame)
11863 (x_clipboard_manager_save_all): New functions.
11864 (Fx_clipboard_manager_save): Lisp function deleted.
11865
11866 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11867 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11868
11869 * xterm.h: Update prototype.
11870
5ba6571d
WX
118712011-05-28 William Xu <william.xwl@gmail.com>
11872
11873 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11874 exiting (Bug#8239).
11875
3eaff834
JM
118762011-05-28 Jim Meyering <meyering@redhat.com>
11877
e1900994 11878 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11879 * fns.c (to_uchar): Define.
11880 (crypto_hash_function): Use it to convert some newly-signed
11881 variables to unsigned, to avoid sign-extension bugs. For example,
11882 without this change, (md5 "truc") would evaluate to
11883 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11884 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11885 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11886
0f6990a7
PE
118872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11888
11889 Integer overflow fixes.
c8a9ca5a 11890
08686060
PE
11891 * dbusbind.c: Serial number integer overflow fixes.
11892 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11893 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11894 to hold a serial number that is too large for a fixnum.
11895 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11896 Check for serial numbers out of range. Decode any serial number
59568bf0 11897 that was so large that it became a float. (Bug#8722)
08686060 11898
2d1fc3c7
PE
11899 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11900 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11901 Use XFASTINT rather than XUINT when numbers are nonnegative.
11902 (xd_append_arg, Fdbus_method_return_internal):
11903 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11904 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11905 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11906 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11907 (Bug#8722)
2d1fc3c7 11908
c8a9ca5a
PE
11909 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11910
519e1d69
PE
11911 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11912
6df6ae42 11913 ccl: Add integer overflow checks.
30569699
PE
11914 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11915 (IN_INT_RANGE): New macros.
11916 (ccl_driver): Use them to check for integer overflow when
11917 decoding a CCL program. Many of the new checks are whether XINT (x)
11918 fits in int; it doesn't always, on 64-bit hosts. The new version
11919 doesn't catch all possible integer overflows, but it's an
847044ea 11920 improvement. (Bug#8719)
30569699 11921
c11285dc
PE
11922 * alloc.c (make_event_array): Use XINT, not XUINT.
11923 There's no need for unsigned here.
11924
fdccd48e
PE
11925 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11926 This follows up to the 2011-05-06 change that substituted uintptr_t
11927 for EMACS_INT. This case wasn't caught back then.
11928
37910ab2
PE
11929 Rework Fformat to avoid integer overflow issues.
11930 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11931 now (part of C89). Include <verify.h>.
11932 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11933 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11934 (Fformat): Avoid the prepass trying to compute sizes; it was only
11935 approximate and thus did not catch overflow reliably. Instead, walk
11936 through the format just once, formatting and computing sizes as we go,
11937 checking for integer overflow at every step, and allocating a larger
11938 buffer as needed. Keep track separately whether the format is
11939 multibyte. Keep only the most-recently calculated precision, rather
11940 than them all. Record whether each argument has been converted to
11941 string. Use EMACS_INT, not int, for byte and char and arg counts.
11942 Support field widths and precisions larger than INT_MAX. Avoid
11943 sprintf's undefined behavior with conversion specifications such as %#d
11944 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11945 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11946 formatting out-of-range floating point numbers with int
9173deec 11947 formats. (Bug#8668)
37910ab2 11948
2e6578fb
PE
11949 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11950
0ae6bdee
PE
11951 * data.c: Avoid integer truncation in expressions involving floats.
11952 * data.c: Include <intprops.h>.
11953 (arith_driver): When there's an integer overflow in an expression
11954 involving floating point, convert the integers to floating point
11955 so that the resulting value does not suffer from catastrophic
11956 integer truncation. For example, on a 64-bit host (* 4
11957 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11958 Do not rely on undefined behavior after integer overflow.
11959
de883a70
PE
11960 merge count_size_as_multibyte, parse_str_to_multibyte
11961 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11962 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11963 Check for integer overflow.
11964 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11965 since it's now a duplicate of the other. This is more of
11966 a character than a buffer op, so better that it's in character.c.
11967 * fns.c, print.c: Adjust to above changes.
11968
2ff916cb
PE
119692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11970
11971 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11972
f1b54466
PE
119732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11974
fb1ac845
PE
11975 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11976 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11977 (x_clipboard_manager_save): Now static.
11978 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11979
f1b54466
PE
11980 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11981 (crypto_hash_function): Now static.
11982 Fix pointer signedness problems. Avoid unnecessary initializations.
11983
a9f737ee
CY
119842011-05-27 Chong Yidong <cyd@stupidchicken.com>
11985
11986 * termhooks.h (Vselection_alist): Make it terminal-local.
11987
11988 * terminal.c (create_terminal): Initialize it.
11989
11990 * xselect.c: Support for clipboard managers.
11991 (Vselection_alist): Move to termhooks.h as terminal-local var.
11992 (LOCAL_SELECTION): New macro.
11993 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11994 (symbol_to_x_atom): Remove gratuitous arg.
11995 (x_handle_selection_request, lisp_data_to_selection_data)
11996 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11997 (x_own_selection, x_get_local_selection, x_convert_selection):
11998 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11999 (some_frame_on_display): Delete unused function.
12000 (Fx_own_selection_internal, Fx_get_selection_internal)
12001 (Fx_disown_selection_internal, Fx_selection_owner_p)
12002 (Fx_selection_exists_p): New optional frame arg.
12003 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
12004 (x_handle_selection_clear): Don't treat other terminals with the
12005 same keyboard specially. Use the terminal-local Vselection_alist.
12006 (x_clear_frame_selections): Use Frun_hook_with_args.
12007
12008 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
12009
12010 * xterm.h: Add support for those atoms.
12011
e067f0c1
CY
120122011-05-26 Chong Yidong <cyd@stupidchicken.com>
12013
12014 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
12015 (converted_selections, conversion_fail_tag): New global variables.
12016 (x_selection_request_lisp_error): Free the above.
12017 (x_get_local_selection): Remove unnecessary code.
12018 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
12019 of converted selections stored in converted_selections.
12020 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
12021 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
12022 (x_convert_selection): New function.
12023 (x_handle_selection_event): Simplify.
12024 (x_get_foreign_selection): Don't ignore incoming requests while
12025 waiting for an answer; this will fail when we implement
12026 SAVE_TARGETS, and seems unnecessary anyway.
12027 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
12028 (Vx_sent_selection_functions): Doc fix.
12029
0f4aebc0
LL
120302011-05-26 Leo Liu <sdl.web@gmail.com>
12031
12032 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
12033
e61124cd
YM
120342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12035
12036 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
12037
12038 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
12039 for fringe update if it has periodic bitmap.
ac389d0c 12040 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
12041 and fringe_bitmap_periodic_p.
12042
12043 * fringe.c (get_fringe_bitmap_data): New function.
12044 (draw_fringe_bitmap_1, update_window_fringes): Use it.
12045 (update_window_fringes): Record periodicity of fringe bitmap in glyph
12046 row. Mark glyph row for fringe update if periodicity changed.
12047
12048 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
12049 for fringe update unless it has periodic bitmap.
12050
f16d9837
KH
120512011-05-25 Kenichi Handa <handa@m17n.org>
12052
12053 * xdisp.c (get_next_display_element): Set correct it->face_id for
12054 a static composition.
12055
e1b90ef6
LL
120562011-05-24 Leo Liu <sdl.web@gmail.com>
12057
12058 * deps.mk (fns.o):
12059 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
12060
12061 * fns.c (crypto_hash_function, Fsha1): New function.
12062 (Fmd5): Use crypto_hash_function.
12063 (syms_of_fns): Add Ssha1.
12064
7400048f
PE
120652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12066
12067 * gnutls.c: Remove unused macros.
12068 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
12069 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
12070 Remove macros that are defined and never used.
12071 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
12072
abb71cf4
CY
120732011-05-22 Chong Yidong <cyd@stupidchicken.com>
12074
12075 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
12076 (Fx_get_selection_internal): Minor cleanup.
12077 (Fx_own_selection_internal): Rename arguments for consistency with
12078 select.el.
12079
6307db39
PE
120802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
12081
12082 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
12083
f3d4e0a4
CY
120842011-05-22 Chong Yidong <cyd@stupidchicken.com>
12085
12086 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
12087
4d8ade89
YM
120882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12089
12090 * dispnew.c (scrolling_window): Don't exclude the case that the
12091 last enabled row in the desired matrix touches the bottom boundary.
12092
32078c8d
GM
120932011-05-21 Glenn Morris <rgm@gnu.org>
12094
12095 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
12096 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
12097 and add some more files.
32078c8d 12098
7285dc67
EZ
120992011-05-20 Eli Zaretskii <eliz@gnu.org>
12100
12101 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12102 report_file_error introduced by the change from 2011-05-07.
12103
89d1bd22
PE
121042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12105
12106 * systime.h (Time): Define only if emacs is defined.
12107 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12108 where the include path doesn't have X11/X.h by default. See
12109 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12110
cd394be1 121112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12112
12113 * composite.c (find_automatic_composition): Fix previous change.
12114
b9704ad9
GM
121152011-05-20 Glenn Morris <rgm@gnu.org>
12116
12117 * lisp.mk: New file, split from Makefile.in.
12118 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12119 (shortlisp): Remove.
12120 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12121
4a720484
GM
121222011-05-19 Glenn Morris <rgm@gnu.org>
12123
12124 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12125 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12126 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12127 (lisp): Set the order to that of loadup.el.
12128 (shortlisp): Make it a copy of $lisp.
12129 (SOME_MACHINE_LISP): Remove.
12130 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12131 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12132
a28d4396
KH
121332011-05-18 Kenichi Handa <handa@m17n.org>
12134
12135 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12136 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12137 (find_automatic_composition): Mostly rewrite for efficiency.
12138
a2b1fa8e
JB
121392011-05-18 Juanma Barranquero <lekktu@gmail.com>
12140
12141 * makefile.w32-in: Update dependencies.
12142
8e1f5610
CS
121432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12144
12145 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12146 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12147
7025ee00 121482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12149
cdfa6eab
PE
12150 Fix some integer overflow issues, such as string length overflow.
12151
06d6db33
PE
12152 * insdel.c (count_size_as_multibyte): Check for string overflow.
12153
2b4560a8
PE
12154 * character.c (lisp_string_width): Check for string overflow.
12155 Use EMACS_INT, not int, for string indexes and lengths; in
12156 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12157 the resulting string length overflows an EMACS_INT; instead,
12158 report a string overflow if no precision given. When checking for
12159 precision exhaustion, use a check that cannot possibly have
12160 integer overflow. (Bug#8675)
12161 * character.h (lisp_string_width): Adjust to new signature.
12162
cb93f9be
PE
12163 * alloc.c (string_overflow): New function.
12164 (Fmake_string): Use it. This doesn't change behavior, but saves
12165 a few bytes and will simplify future changes.
12166 * character.c (string_escape_byte8): Likewise.
12167 * lisp.h (string_overflow): New decl.
12168
1a1f3366
PE
12169 Fixups, following up to the user-interface timestamp change.
12170 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12171 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12172 * msdos.c (mouse_get_pos): Likewise.
12173 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12174 * w32gui.h (Time): Define by including "systime.h" rather than by
12175 declaring it ourselves. (Bug#8664)
12176
d4e3e4d3
PE
12177 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12178 * image.c (clear_image_cache): Likewise.
12179
f6a24d19
PE
12180 * term.c (term_mouse_position): Don't assume time_t wraparound.
12181
08dc5ae6
PE
12182 Be more systematic about user-interface timestamps.
12183 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12184 and sometimes 'EMACS_UINT', to represent these timestamps.
12185 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12186 This makes the code easier to follow, and makes it easier to catch
12187 integer overflow bugs such as Bug#8664.
12188 * frame.c (Fmouse_position, Fmouse_pixel_position):
12189 Use Time, not unsigned long, for user-interface timestamps.
12190 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12191 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12192 * keyboard.h (last_event_timestamp): Likewise.
12193 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12194 * menu.h (xmenu_show): Likewise.
12195 * term.c (term_mouse_position): Likewise.
12196 * termhooks.h (struct input_event.timestamp): Likewise.
12197 (struct terminal.mouse_position_hook): Likewise.
12198 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12199 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12200 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12201 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12202 what it was before.
12203 * menu.h, termhooks.h: Include "systime.h", for Time.
12204
8e55734a
PE
12205 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12206 Don't assume that the difference between two unsigned long values
12207 can fit into an integer. At this point, we know button_down_time
12208 <= event->timestamp, so the difference must be nonnegative, so
12209 there's no need to cast the result if double-click-time is
12210 nonnegative, as it should be; check that it's nonnegative, just in
12211 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12212 apart (about 25 days). (Bug#8664)
8e55734a 12213
841f1b75 12214 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12215 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12216
3e26f69c
PE
12217 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12218 that always fit in int. Use a sentinel instead of a counter, to
12219 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12220 * frame.h (struct frame): Use int for menu_bar_items_used
12221 instead of EMACS_INT, since it always fits in int.
3e26f69c 12222
5cc152c0
PE
12223 * menu.c (grow_menu_items): Check for int overflow.
12224
d89eb65e
PE
12225 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12226
5235bd3e
PE
12227 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12228 Before, the code was not consistent. These values cannot exceed
12229 2**31 - 1 so there's no need to make them unsigned.
12230 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12231 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12232 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12233 as modifiers.
12234 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12235
bc827e23
PE
12236 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12237 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12238 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12239 presumably because the widths might not match.
12240
78eb494e
PE
12241 * window.c (size_window): Avoid needless test at loop start.
12242
04f2d78b
CB
122432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12244
12245 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12246
d2fc7e3d 122472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12248
12249 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12250
d2fc7e3d 122512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12252
12253 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12254 `width' to `bar_area_x' and `bar_area_width', respectively.
12255 (x_scroll_run): Take account of fringe background extension.
12256
04f2d78b
CB
12257 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12258 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12259 `bar_area_width', respectively.
12260 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12261 background extension.
12262
79b70037
GM
122632011-05-10 Jim Meyering <meyering@redhat.com>
12264
12265 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12266
2f142cc5
JB
122672011-05-10 Juanma Barranquero <lekktu@gmail.com>
12268
12269 * image.c (Finit_image_library): Return t for built-in image types,
12270 like pbm and xbm. (Bug#8640)
12271
57679c86
AS
122722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12273
12274 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12275
888c9e86
EZ
122762011-05-07 Eli Zaretskii <eliz@gnu.org>
12277
b0512a1d
EZ
12278 * w32console.c (Fset_screen_color): Doc fix.
12279 (Fget_screen_color): New function.
12280 (syms_of_ntterm): Defsubr it.
12281
7285dc67
EZ
12282 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12283 unlink the temporary file if Fcall_process didn't create it in the
12284 first place.
12285 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12286 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12287 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12288 cue to call_process_cleanup not to close that handle.
12289
4d3fcc8e
BK
122902011-05-07 Ben Key <bkey76@gmail.com>
12291
12292 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12293 one of two shell specific rules, either bootstrap-temacs-CMD or
12294 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12295 to the previous implementation of the bootstrap-temacs rule.
12296 The bootstrap-temacs-CMD rule is similar to the previous
12297 implementation of the bootstrap-temacs rule except that it
12298 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12299 variable.
12300
12301 These changes, along with some changes to nt/configure.bat,
12302 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12303 earlier fix to add support for --cflags and --ldflags options
12304 that include quotes so that it works whether make uses cmd or
12305 sh as the shell.
12306
b4289b64
MA
123072011-05-06 Michael Albinus <michael.albinus@gmx.de>
12308
12309 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12310 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12311 is a constant.
12312 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12313 a string. Handle both cases.
12314 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12315 (Fdbus_register_method): Use Qinvalid_function.
12316
af4c0e28
JB
123172011-05-06 Juanma Barranquero <lekktu@gmail.com>
12318
12319 * makefile.w32-in: Update dependencies.
12320 (LISP_H): Add inttypes.h and stdin.h.
12321 (PROCESS_H): Add unistd.h.
12322
c51453d9
EZ
123232011-05-06 Eli Zaretskii <eliz@gnu.org>
12324
12325 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12326 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12327
8ff0ac3c 123282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12329
4c4b566b
PE
12330 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12331
aab2b9b5
PE
12332 * term.c (vfatal): Remove stray call to va_end.
12333 It's not needed and the C Standard doesn't allow it here anyway.
12334
c378da0b
PE
12335 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12336 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12337
288b08c7
PE
12338 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12339 bytes.
12340
e3601888
PE
12341 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12342
db6c0e74
PE
12343 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12344
dd5963ea
PE
12345 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12346
88c9450f
PE
12347 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12348
2f9442b8
PE
12349 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12350
c032b5f8
PE
12351 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12352 * charset.c (Fdefine_charset_internal): Don't initialize
12353 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12354 32-bit int (Bug#8600).
a108c10b
PE
12355
12356 * lread.c (read_integer): Be more consistent with string-to-number.
12357 Use string_to_number to do the actual conversion; this avoids
12358 rounding errors and fixes some other screwups. Without this fix,
12359 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12360 (digit_to_number): Move earlier, for benefit of read_integer.
12361 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12362 not a digit in any supported base. (Bug#8602)
a108c10b 12363
ad5f9eea
PE
12364 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12365
aec1708a
PE
12366 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12367 to match comment at start of function. This also removes a
12368 GCC warning about overflow in a 32+64-bit port.
12369
47be4ab5
PE
12370 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12371
371cac43
PE
12372 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12373 Reported by Stefan Monnier in
12374 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12375 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12376 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12377
d01a7826
PE
12378 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12379 (EMACS_UINTPTR): Likewise, with uintptr_t.
12380
7fd47d5c
PE
12381 * lisp.h: Prefer 64-bit EMACS_INT if available.
12382 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12383 on 32-bit hosts that have 64-bit int, so that they can access
12384 large files.
122b0c86
PE
12385 However, temporarily disable this change unless the temporary
12386 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12387
8727937b
PE
12388 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12389
8ac068ac
PE
12390 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12391 This removes an assumption that EMACS_INT and long are the same
12392 width as pointers. The assumption is true for Emacs porting targets
12393 now, but we want to make other targets possible.
12394 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12395 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12396 In the rest of the code, change types of integers that hold casted
12397 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12398 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12399 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12400 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12401 No need to cast type when ORing.
12402 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12403 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12404 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12405 assume EMACS_INT is the same width as char *.
12406 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12407 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12408 Remove no-longer-needed casts.
12409 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12410 (xg_tool_bar_help_callback, xg_make_tool_item):
12411 Use EMACS_INTPTR to hold an integer
12412 that will be cast to void *; this can avoid a GCC warning
12413 if EMACS_INT is not the same width as void *.
12414 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12415 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12416 (current_message_1, set_message_1):
12417 Use a local to convert to proper width without a cast.
12418 * xmenu.c (dialog_selection_callback): Likewise.
12419
ede49d71
PE
12420 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12421 Also, don't assume VALBITS / RAND_BITS is less than 5,
12422 and don't rely on undefined behavior when shifting a 1 left into
12423 the sign bit.
12424 * lisp.h (get_random): Change signature to match.
12425
2f30ecd0
PE
12426 * lread.c (hash_string): Use size_t, not int, for hash computation.
12427 Normally we prefer signed values; but hashing is special, because
12428 it's better to use unsigned division on hash table sizes so that
12429 the remainder is nonnegative. Also, size_t is the natural width
12430 for hashing into memory. The previous code used 'int', which doesn't
12431 retain enough info to hash well into very large tables.
12432 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12433
2a866e7b
PE
12434 * dbusbind.c: Don't possibly lose pointer info when converting.
12435 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12436 Use XPNTR rather than XHASH, so that the high-order bits of
12437 the pointer aren't lost when converting through void *.
12438
51639eac
PE
12439 * eval.c (Fautoload): Don't double-shift a pointer.
12440
92394119
PE
12441 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12442
dbdb9a7c
JB
124432011-05-06 Juanma Barranquero <lekktu@gmail.com>
12444
12445 * gnutls.c (DEF_GNUTLS_FN):
12446 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12447
db7a0b4f
AS
124482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12449
12450 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12451 marker. (Bug#8610)
12452
cd394be1 124532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12454
12455 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12456 New version that can reserve upto 2GB of heap space.
12457
f7ff1b0f 124582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12459
12460 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12461
639c109b
TZ
124622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12463
12464 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12465 `gnutls_certificate_set_x509_key_file'.
12466
d2127135
JB
124672011-05-05 Juanma Barranquero <lekktu@gmail.com>
12468
12469 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12470 Update dependencies.
12471
e968f4f3
JB
124722011-05-04 Juanma Barranquero <lekktu@gmail.com>
12473
12474 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12475 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12476 Remove unused parameter `fildes'.
12477 * process.c (read_process_output, send_process): Don't pass it.
12478
84d358f0
JB
124792011-05-04 Juanma Barranquero <lekktu@gmail.com>
12480
12481 Fix previous change: the library cache is defined in w32.c.
12482 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12483 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12484
0898ca10
JB
124852011-05-04 Juanma Barranquero <lekktu@gmail.com>
12486
12487 Implement dynamic loading of GnuTLS on Windows.
12488
12489 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12490 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12491 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12492 Declare.
12493
12494 * gnutls.c (Qgnutls_dll): Define.
12495 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12496 (gnutls_*): Declare function pointers.
12497 (init_gnutls_functions): New function to initialize function pointers.
12498 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12499 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12500 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12501 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12502 (emacs_gnutls_write, emacs_gnutls_read)
12503 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12504 (Fgnutls_available_p): New function.
12505 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12506 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12507 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12508
12509 * image.c: Include w32.h.
12510 (Vimage_type_cache): Delete.
12511 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12512 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12513 (w32_delayed_load): Move to w32.c.
12514
12515 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12516
12517 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12518 (w32_delayed_load): Move from image.c. When loading a library, record
12519 its filename in the :loaded-from property of the library id.
12520 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12521 Initialize and staticpro them.
12522 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12523
12524 * process.c: Include lisp.h before w32.h, not after.
12525 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12526 instead of gnutls_record_check_pending.
12527
12528 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12529
ff4de4aa
TZ
125302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12531
12532 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12533 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12534 as passed in.
12535
abe95abb
JD
125362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12537
12538 * xterm.c (x_set_frame_alpha): Do not set property on anything
12539 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12540
e16e55d4
JB
125412011-05-02 Juanma Barranquero <lekktu@gmail.com>
12542
12543 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12544
bafcf6a5
JB
125452011-05-02 Juanma Barranquero <lekktu@gmail.com>
12546
12547 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12548 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12549 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12550 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12551 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12552 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12553 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12554 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12555 (Qgnutls_bootprop_callbacks_verify): Make static.
12556
e7a6747f
AS
125572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12558
19ed11ba
AS
12559 * callproc.c: Indentation fixup.
12560
e7a6747f 12561 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12562 (wait_for_termination, interruptible_wait_for_termination):
12563 Move after wait_for_termination_1.
e7a6747f 12564
1ef14cb4
LMI
125652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12566
12567 * sysdep.c (interruptible_wait_for_termination): New function
12568 which is like wait_for_termination, but allows keyboard
12569 interruptions.
12570
12571 * callproc.c (Fcall_process): Add (:file "file") as an option for
12572 the STDOUT buffer.
12573 (Fcall_process_region): Ditto.
12574
330d880c
EZ
125752011-04-30 Eli Zaretskii <eliz@gnu.org>
12576
8db90b73
EZ
12577 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12578 rather than `XVECTOR (FOO)->size'.
12579
330d880c
EZ
12580 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12581 inttypes.h, as a gnulib replacement is used if it not available in
12582 system headers.
12583
15cbd324
EZ
125842011-04-21 Eli Zaretskii <eliz@gnu.org>
12585
12586 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12587 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12588 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12589
12590 * coding.c (coding_alloc_by_realloc): Error out if destination
12591 will grow beyond MOST_POSITIVE_FIXNUM.
12592 (decode_coding_emacs_mule): Abort if there isn't enough place in
12593 charbuf for the composition carryover bytes. Reserve an extra
12594 space for up to 2 characters produced in a loop.
12595 (decode_coding_iso_2022): Abort if there isn't enough place in
12596 charbuf for the composition carryover bytes.
12597
125982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12599
ae940cca
EZ
12600 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12601 aborting when %lld or %lll format is passed.
12602 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12603 %llo or %llx format is passed. (Bug#8545)
12604
03ab8921
EZ
12605 * window.c (window_scroll_line_based): Use a marker instead of
12606 simple variables to record original value of point. (Bug#7952)
12607
afda1437
EZ
12608 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12609 produced by %s or %c overflows available buffer space. (Bug#8545)
12610
f76dee0c
PE
126112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12612
12613 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12614 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12615
fdc5744d
JB
126162011-04-28 Juanma Barranquero <lekktu@gmail.com>
12617
12618 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12619
638f053a
JB
126202011-04-28 Juanma Barranquero <lekktu@gmail.com>
12621
12622 * keyboard.c (Qdelayed_warnings_hook): Define.
12623 (command_loop_1): Run `delayed-warnings-hook'
12624 if Vdelayed_warnings_list is non-nil.
12625 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12626 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12627
d178f871
EZ
126282011-04-28 Eli Zaretskii <eliz@gnu.org>
12629
12630 * doprnt.c (doprnt): Don't return value smaller than the buffer
12631 size if the message was truncated. (Bug#8545).
12632
b124fd93
JB
126332011-04-28 Juanma Barranquero <lekktu@gmail.com>
12634
12635 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12636 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12637
e810457d
PE
126382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12639
12640 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12641
ea51cceb
JB
126422011-04-27 Juanma Barranquero <lekktu@gmail.com>
12643
12644 * makefile.w32-in: Update dependencies.
12645
94dcfacf
EZ
126462011-04-27 Eli Zaretskii <eliz@gnu.org>
12647
12648 Improve `doprnt' and its usage. (Bug#8545)
12649 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12650 `format_end'. Remove support for %l as a conversion specifier.
12651 Don't use xrealloc. Improve diagnostics when the %l size modifier
12652 is used. Update the commentary.
12653
12654 * eval.c (verror): Simplify calculation of size_t.
12655
12656 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12657 messages.
12658
f61f41d7
PE
126592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12660
12661 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12662 change.
12663
96fb4434
PE
126642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12665
12666 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12667 This makes this file independent of the recent pseudovector change.
12668
671875da 126692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12670
69e9b5a3
PE
12671 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12672
b5f869a7 12673 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12674 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12675 Remove unused local.
c8926152 12676 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12677
841a1577 12678 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12679 GCC 4.6.0 optimizes based on type-based alias analysis.
12680 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12681 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12682 != &v->size, and therefore "v->size = 1; b->size = 2; return
12683 v->size;" must therefore return 1. This assumption is incorrect
12684 for Emacs, since it type-puns struct Lisp_Vector * with many other
12685 types. To fix this problem, this patch adds a new type struct
f904488f 12686 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12687 and pseudovectors, and helps optimizing compilers not get fooled
12688 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12689 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12690 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12691 the size member.
eab3844f
PE
12692 (XSETPVECTYPE): Rewrite in terms of new macro.
12693 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12694 This is a bit clearer, and further avoids the possibility of
12695 undesirable aliasing.
12696 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12697 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12698 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12699 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12700 (ASIZE): Now uses header.size rather than size.
12701 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12702 to avoid the hassle of writing XVECTOR (foo)->header.size.
12703 (struct vectorlike_header): New type.
eab3844f
PE
12704 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12705 object, to help avoid aliasing.
12706 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12707 (SUBRP): Likewise, since Lisp_Subr is a special case.
12708 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12709 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12710 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12711 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12712 changed to be "header.size" and "header.next".
12713 * buffer.h (struct buffer): Likewise.
12714 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12715 * frame.h (struct frame): Likewise.
12716 * process.h (struct Lisp_Process): Likewise.
12717 * termhooks.h (struct terminal): Likewise.
12718 * window.c (struct save_window_data, struct saved_window): Likewise.
12719 * window.h (struct window): Likewise.
12720 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12721 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12722 * buffer.c (init_buffer_once): Likewise.
12723 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12724 special case.
12725 * process.c (Fformat_network_address): Use local var for size,
12726 for brevity.
12727
0df1eac5
PE
12728 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12729
847ab9d1 12730 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12731 * data.c (atof): Remove decl; no longer used or needed.
12732 (digit_to_number): Move to lread.c.
12733 (Fstring_to_number): Use new string_to_number function, to be
12734 consistent with how the Lisp reader treats infinities and NaNs.
12735 Do not assume that floating-point numbers represent EMACS_INT
12736 without losing information; this is not true on most 64-bit hosts.
12737 Avoid double-rounding errors, by insisting on integers when
12738 parsing non-base-10 numbers, as the documentation specifies.
12739 * lisp.h (string_to_number): New decl, replacing ...
12740 (isfloat_string): Remove.
bc0a5c13 12741 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12742 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12743 appears to have been a coding error. Similarly, do not accept
12744 strings like +-1e0 as floating point numbers. Do not report
12745 overflow for integer overflows unless the base is not 10 which
12746 means we have no simple and reliable way to continue.
12747 Break out the floating-point parsing into a new
12748 function string_to_number, so that Fstring_to_number parses
12749 floating point numbers consistently with the Lisp reader.
04f2d78b 12750 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12751 (E_CHAR, EXP_INT): Remove, replacing with ...
12752 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12753 (string_to_number): New function, replacing isfloat_string.
12754 This function checks for valid syntax and produces the resulting
12755 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12756 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12757 so that overflow for non-base-10 numbers is reported only when
12758 there's no portable and simple way to convert to floating point.
452f4150 12759
67769ffc
PE
12760 * textprop.c (set_text_properties_1): Rewrite for clarity,
12761 and to avoid GCC warning about integer overflow.
12762
c20db43f
PE
12763 * intervals.h (struct interval): Use EMACS_INT for members
12764 where EMACS_UINT might cause problems. See
12765 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12766 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12767 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12768 All uses changed.
37aa2f85
PE
12769 (offset_intervals): Tell GCC not to worry about length overflow
12770 when negating a negative length.
c20db43f 12771
2538aa2f
PE
12772 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12773 (overrun_check_free): Likewise.
12774
f2d3008d
PE
12775 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12776 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12777 word size.
12778
ec8df744
PE
12779 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12780 (gnutls_make_error): Rename local to avoid shadowing.
12781 (gnutls_emacs_global_deinit): ifdef out; not used.
12782 (Fgnutls_boot): Use const for pointer to readonly storage.
12783 Comment out unused local. Fix pointer signedness problems.
12784
640ee02d
PE
12785 * lread.c (openp): Don't stuff size_t into an 'int'.
12786 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12787 about possible signed overflow.
12788
6048fb2a
PE
12789 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12790 (GDK_KEY_g): Don't define if already defined.
12791 (xg_prepare_tooltip): Avoid pointer signedness problem.
12792 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12793
fa3c87e1
PE
12794 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12795 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12796
2172544b
PE
12797 * xfns.c (Fx_window_property): Simplify a bit,
12798 to make a bit faster and to avoid GCC 4.6.0 warning.
12799 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12800
9b821a21
PE
12801 * fns.c (internal_equal): Don't assume size_t fits in int.
12802
3c616cfa
PE
12803 * alloc.c (compact_small_strings): Tighten assertion a little.
12804
c2982e87
PE
12805 Replace pEd with more-general pI, and fix some printf arg casts.
12806 * lisp.h (pI): New macro, generalizing old pEd macro to other
12807 conversion specifiers. For example, use "...%"pI"d..." rather
12808 than "...%"pEd"...".
12809 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12810 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12811 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12812 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12813 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12814 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12815 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12816 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12817 64-bit hosts.
12818 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12819 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12820 * print.c (safe_debug_print, print_object): Likewise.
12821 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12822 to int.
6f04d126
PE
12823 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12824 avoiding the 0 flag, which is not portable.
c2982e87
PE
12825 * process.c (Fmake_network_process): Use pI to avoid cast.
12826 * region-cache.c (pp_cache): Likewise.
12827 * xdisp.c (decode_mode_spec): Likewise.
12828 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12829 behavior on 64-bit hosts with printf arg.
6f04d126 12830 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12831 (x_stop_queuing_selection_requests): Likewise.
12832 (x_get_window_property): Don't truncate byte count to an 'int'
12833 when tracing.
0b432f21 12834
5e073ec7
PE
12835 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12836 here, since it parses constructs like leading '-' and spaces,
12837 which are not wanted; and it overflows with large numbers.
12838 Instead, simply match F[0-9]+, which is what is wanted anyway.
12839
36372bf9
PE
12840 * alloc.c: Remove unportable assumptions about struct layout.
12841 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12842 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12843 (allocate_vectorlike, make_pure_vector): Use the new macros,
12844 plus offsetof, to remove unportable assumptions about struct layout.
12845 These assumptions hold on all porting targets that I know of, but
12846 they are not guaranteed, they're easy to remove, and removing them
12847 makes further changes easier.
12848
0b432f21
PE
12849 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12850 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12851 (string_overrun_cookie): Now const. Use initializers that
12852 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12853 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12854 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12855 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12856 multiple of sizeof (EMACS_INT); it need not be, if
12857 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12858 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12859
895009e1
JB
128602011-04-26 Juanma Barranquero <lekktu@gmail.com>
12861
12862 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12863
6a7a1b0b
TZ
128642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12865
12866 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12867 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12868 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12869
841a1577 128702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12871
12872 * lisp.h (Qdebug): List symbol.
895009e1 12873 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12874 * keyboard.c (debug-on-event): New variable.
12875 (handle_user_signal): Break into debugger when debug-on-event
12876 matches the current signal symbol.
12877
f2d3ba6f
DN
128782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12879
12880 * alloc.c (check_sblock, check_string_bytes)
12881 (check_string_free_list): Convert to standard C.
12882
42ce4c63
TZ
128832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12884
12885 * w32.c (emacs_gnutls_push): Fix typo.
12886
825cd63c
EZ
128872011-04-25 Eli Zaretskii <eliz@gnu.org>
12888
fb11d64d
EZ
12889 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12890 "cast to pointer from integer of different size".
12891
825cd63c
EZ
12892 Improve doprnt and its use in verror. (Bug#8545)
12893 * doprnt.c (doprnt): Document the set of format control sequences
12894 supported by the function. Use SAFE_ALLOCA instead of always
12895 using `alloca'.
12896
12897 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12898 is one byte too soon. Don't use xrealloc; instead xfree and
12899 xmalloc anew.
12900
e061a11b
TZ
129012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12902
12903 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12904 callbacks stage.
12905
12906 * gnutls.c: Renamed global_initialized to
12907 gnutls_global_initialized. Added internals for the
12908 :verify-hostname-error, :verify-error, and :verify-flags
12909 parameters of `gnutls-boot' and documented those parameters in the
12910 docstring. Start callback support.
9173deec
JB
12911 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12912 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12913 on error. Return error code.
e061a11b
TZ
12914 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12915 (emacs_gnutls_read): Likewise.
12916 (Fgnutls_boot): Return handshake error code.
12917 (emacs_gnutls_handle_error): New function.
12918 (wsaerror_to_errno): Likewise.
12919
12920 * w32.h (emacs_gnutls_pull): Add prototype.
12921 (emacs_gnutls_push): Likewise.
12922
12923 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12924 (emacs_gnutls_push): Likewise.
12925
129262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12927
12928 * process.c (wait_reading_process_output): Check if GnuTLS
12929 buffered some data internally if no FDs are set for TLS
12930 connections.
12931
12932 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12933 (LIBS): Link to USER_LIBS.
12934 ($(BLD)/gnutls.$(0)): New target.
12935
fa6996bc
EZ
129362011-04-24 Eli Zaretskii <eliz@gnu.org>
12937
eb35682e
EZ
12938 * xdisp.c (handle_single_display_spec): Rename the
12939 display_replaced_before_p argument into display_replaced_p, to
12940 make it consistent with the commentary. Fix typos in the
12941 commentary.
12942
e2ad650c
EZ
12943 * textprop.c (syms_of_textprop): Remove dead code.
12944 (copy_text_properties): Delete obsolete commentary about an
12945 interface that was deleted long ago. Fix typos in the description
12946 of arguments.
12947
1b2de274
EZ
12948 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12949 to changes in oldXMenu/XMenu.h from 2011-04-16.
12950 <menu_help_message, prev_menu_help_message>: Constify.
12951 (IT_menu_make_room): menu->help_text is now `const char **';
12952 adjust.
12953
12954 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12955 to changes in oldXMenu/XMenu.h from 2011-04-16.
12956 (struct XMenu): Declare `help_text' `const char **'.
12957
12958 * xfaces.c <Qunspecified>: Make extern again.
12959
12960 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12961 required by POSIX.
1b2de274 12962
762b15be
EZ
12963 * doc.c (get_doc_string): Improve the format passed to `error'.
12964
12965 * doprnt.c (doprnt): Improve commentary.
12966
12967 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12968
12969 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12970 them with etags.
12971
f1052e5d
EZ
12972 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12973 changes in globals.h immediately force recompilation.
762b15be
EZ
12974 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12975 $(CURDIR)/s/ms-w32.h.
12976 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12977
fa6996bc
EZ
12978 * character.c (Fchar_direction): Function deleted.
12979 (syms_of_character): Don't defsubr it.
12980 <char-direction-table>: Deleted.
12981
e6c3da20
EZ
129822011-04-23 Eli Zaretskii <eliz@gnu.org>
12983
12984 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12985 * doprnt.c: Include limits.h.
12986 (SIZE_MAX): New macro.
04f2d78b
CB
12987 (doprnt): Return a size_t value. 2nd arg is now size_t.
12988 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12989 Improve overflow protection. Support `l' modifier for integer
12990 conversions. Support %l conversion. Don't assume an EMACS_INT
12991 argument for integer conversions and for %c.
12992
12993 * lisp.h (doprnt): Restore prototype.
12994
12995 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12996 $(SRC)/character.h.
12997
12998 * Makefile.in (base_obj): Add back doprnt.o.
12999
13000 * deps.mk (doprnt.o): Add back prerequisites.
13001 (callint.o): Depend on character.h.
13002
13003 * eval.c (internal_lisp_condition_case): Include the handler
13004 representation in the error message.
13005 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
13006 when breaking from the loop.
13007
13008 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
13009
13010 * callint.c (Fcall_interactively): When displaying error message
13011 about invalid control letter, pass the character's codepoint, not
13012 a pointer to its multibyte form. Improve display of the character
13013 in octal and display also its hex code.
13014
13015 * character.c (char_string): Use %x to display the (unsigned)
13016 codepoint of an invalid character, to avoid displaying a bogus
13017 negative value.
13018
13019 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
13020 `error', not SYMBOL_NAME itself.
13021
13022 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
13023 character arguments to `error'.
13024
13025 * charset.c (check_iso_charset_parameter): Fix incorrect argument
13026 to `error' in error message about FINAL_CHAR argument. Make sure
13027 FINAL_CHAR is a character, and use %c when it is passed as
13028 argument to `error'.
13029
4ffd0d6b 130302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
13031
13032 * s/ms-w32.h (localtime): Redirect to sys_localtime.
13033
13034 * w32.c: Include <time.h>.
13035 (sys_localtime): New function.
13036
4ffd0d6b 130372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
13038
13039 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
13040
4ffd0d6b 13041 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 13042
4ffd0d6b 130432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 13044
4ffd0d6b
GM
13045 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
13046 zombies (Bug#8467).
aac0c6e3 13047
04c56954
EZ
130482011-04-19 Eli Zaretskii <eliz@gnu.org>
13049
13050 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
13051 gl_state.e_property when gl_state.object is Qt.
13052
13053 * insdel.c (make_gap_larger): Remove limitation of buffer size
13054 to <= INT_MAX.
13055
16a43933
CY
130562011-04-18 Chong Yidong <cyd@stupidchicken.com>
13057
13058 * xdisp.c (lookup_glyphless_char_display)
13059 (produce_glyphless_glyph): Handle cons cell entry in
13060 glyphless-char-display.
13061 (Vglyphless_char_display): Document it.
13062
13063 * term.c (produce_glyphless_glyph): Handle cons cell entry in
13064 glyphless-char-display.
13065
4581706e
CY
130662011-04-17 Chong Yidong <cyd@stupidchicken.com>
13067
13068 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
13069
13070 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
13071
13072 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
13073 definition for no-X builds.
13074
4887c6e2 130752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 13076
fd35b6f9
PE
13077 Static checks with GCC 4.6.0 and non-default toolkits.
13078
5c1ccb01
PE
13079 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
13080
006c5daa
PE
13081 * process.c (keyboard_bit_set): Define only if SIGIO.
13082 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
13083 (send_process): Repair possible setjmp clobbering.
13084
efc736d3
PE
13085 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
13086
4e2fe2e6
PE
13087 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
13088
f97334a2
PE
13089 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
13090
4e75f29d
PE
13091 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
13092 Define only if needed.
13093
90efadd1
PE
13094 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
13095 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 13096 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 13097
3c647824
PE
13098 * dispextern.h (struct redisplay_interface): Rename param
13099 to avoid shadowing.
e264f262 13100 * termhooks.h (struct terminal): Likewise.
761383f4 13101 * xterm.c (xembed_send_message): Likewise.
3c647824 13102
b58c5c4a
PE
13103 * insdel.c (make_gap_smaller): Define only if
13104 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13105
cad59032
PE
13106 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13107 it.
13108
c339dc2e
PE
13109 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13110 so that we aren't warned about unused symbols.
13111
91a3e27b
PE
13112 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13113
399c71d3 13114 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13115
8ffc96f5
PE
13116 * xfns.c (x_real_positions): Mark locals as initialized.
13117
eef9bc79
PE
13118 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13119
098db9dd
PE
13120 * xterm.c: Fix problems found by static analysis with other toolkits.
13121 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13122 (x_dispatch_event): Declare static if USE_GTK, and
13123 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13124 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13125 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13126 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13127 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13128
eb18f6cc
PE
13129 * xmenu.c (menu_help_callback): Pointer type fixes.
13130 Use const pointers when pointing at readonly data. Avoid pointer
13131 signedness clashes.
13132 (FALSE): Remove unused macro.
13133 (update_frame_menubar): Remove unused decl.
13134
1fe72bf8
PE
13135 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13136
60d9e1db
PE
13137 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13138 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13139 (single_menu_item): Rename local to avoid shadowing.
13140
39261c26
PE
13141 * keyboard.c (make_lispy_event): Remove unused local var.
13142
018c5e19
PE
13143 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13144 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13145
63d2b86e
PE
13146 * bitmaps: Change bitmaps from unsigned char back to the X11
13147 compatible char. Avoid the old compiler warnings about
13148 out-of-range initializers by using, for example, '\xab' rather
13149 than 0xab.
13150
aefd87e1
PE
13151 * xgselect.c (xgselect_initialize): Check vs interface
13152 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13153
bf501fb9
PE
13154 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13155
e9829fdf
PE
13156 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13157 to read-only memory.
13158
1086c095
PE
13159 * fns.c (vector): Remove; this old hack is no longer needed.
13160
2baccd04 13161 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13162 Remove unused var.
dde42981 13163 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13164
72391843 13165 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13166
436c16df 13167 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13168 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13169 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13170
92bb796d 13171 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13172 (x_term_init): Remove local to avoid shadowing.
92bb796d 13173
764430a3 13174 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13175
13176 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13177 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13178
d1dfb56c
EZ
131792011-04-16 Eli Zaretskii <eliz@gnu.org>
13180
c4354cb4
EZ
13181 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13182
d1dfb56c
EZ
13183 Fix regex.c, syntax.c and friends for buffers > 2GB.
13184 * syntax.h (struct gl_state_s): Declare character position members
13185 EMACS_INT.
13186
13187 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13188
04f2d78b
CB
13189 * textprop.c (verify_interval_modification, interval_of):
13190 Declare arguments EMACS_INT.
d1dfb56c
EZ
13191
13192 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13193 EMACS_INT.
13194
13195 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13196
13197 * indent.c (Fvertical_motion): Local variable it_start is now
13198 EMACS_INT.
13199
13200 * regex.c (re_match, re_match_2, re_match_2_internal)
13201 (bcmp_translate, regcomp, regexec, print_double_string)
13202 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13203 (re_compile_pattern, re_exec): Declare arguments and local
13204 variables `size_t' and `ssize_t' and return values `regoff_t', as
13205 appropriate.
13206 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13207 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13208 <compile_stack_type>: `size' and `avail' are now `size_t'.
13209
13210 * regex.h <regoff_t>: Use ssize_t, not int.
13211 (re_search, re_search_2, re_match, re_match_2): Arguments that
13212 specify buffer/string position and length are now ssize_t and
13213 size_t. Return type is regoff_t.
13214
613052cd
BK
132152011-04-16 Ben Key <bkey76@gmail.com>
13216
13217 * nsfont.m: Fixed bugs in ns_get_family and
13218 ns_descriptor_to_entity that were caused by using free to
13219 deallocate memory blocks that were allocated by xmalloc (via
13220 xstrdup). This caused Emacs to crash when compiled with
13221 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13222 --enable-checking=xmallocoverrun). xfree is now used to
13223 deallocate these memory blocks.
13224
4170f62f 132252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13226
71b41406
PE
13227 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13228
9587a89d
PE
13229 emacs_write: Accept and return EMACS_INT for sizes.
13230 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13231 et seq.
13232 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13233 Accept and return EMACS_INT.
13234 (emacs_gnutls_write): Return the number of bytes written on
13235 partial writes.
13236 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13237 (emacs_read, emacs_write): Remove check for negative size, as the
13238 Emacs source code has been audited now.
9587a89d
PE
13239 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13240 (emacs_read, emacs_write): Use it.
273a5f82
PE
13241 * process.c (send_process): Adjust to the new signatures of
13242 emacs_write and emacs_gnutls_write. Do not attempt to store
13243 a byte offset into an 'int'; it might overflow.
9587a89d 13244 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13245
3e047f51
PE
13246 * sound.c: Don't assume sizes fit in 'int'.
13247 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13248 Return EMACS_INT, not int.
3e047f51 13249 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13250 Accept EMACS_INT, not int.
13251 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13252 record read return values.
13253
cc39a9db
BK
132542011-04-15 Ben Key <bkey76@gmail.com>
13255
c9d0ec6d
JB
13256 * keyboard.c (Qundefined): Don't declare static since it is used
13257 in nsfns.m.
13258 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13259 static since they are used in nsfont.m.
cc39a9db 13260
6c60eb9f
SM
132612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13262
13263 * process.c (Qprocessp): Don't declare static.
13264 * lisp.h (Qprocessp): Declare again.
13265
7990b61a
JB
132662011-04-15 Juanma Barranquero <lekktu@gmail.com>
13267
13268 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13269
5d4cb038
PE
132702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13271
8bd7b830 13272 Improve C-level modularity by making more things 'static'.
cd64ea1d 13273
e3b27b31
PE
13274 Don't publish debugger-only interfaces to other modules.
13275 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13276 (verify_bytepos, count_markers): Move decls to the only modules
13277 that need them.
13278 * region-cache.h (pp_cache): Likewise.
13279 * window.h (check_all_windows): Likewise.
13280 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13281
5d4cb038
PE
13282 * sysdep.c (croak): Now static, if
13283 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13284 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13285
13286 * alloc.c (refill_memory_reserve): Now static if
13287 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13288 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13289
e87b6180
PE
13290 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13291 Define only if USE_LUCID.
13292
ac64929e
PE
13293 * xrdb.c (x_customization_string, x_rm_string): Now static.
13294
6f37259d
PE
13295 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13296 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13297
1683e3ab
PE
13298 * xdisp.c (draw_row_with_mouse_face): Now static.
13299 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13300
de9c2632
PE
13301 * window.h (check_all_windows): Mark externally visible.
13302
2b96acb7
PE
13303 * window.c (window_deletion_count): Now static.
13304
13305 * undo.c: Make symbols static if they're not exported.
13306 (last_undo_buffer, last_boundary_position, pending_boundary):
13307 Now static.
13308
50436f33
PE
13309 * textprop.c (interval_insert_behind_hooks): Now static.
13310 (interval_insert_in_front_hooks): Likewise.
13311
64520e5c
PE
13312 * term.c: Make symbols static if they're not exported.
13313 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13314 (max_frame_lines, tty_set_terminal_modes):
13315 (tty_reset_terminal_modes, tty_turn_off_highlight):
13316 (get_tty_terminal): Now static.
13317 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13318 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13319 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13320 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13321 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13322
1fa53021
PE
13323 * sysdep.c: Make symbols static if they're not exported.
13324 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13325 Now static.
13326 (sigprocmask_set, full_mask): Remove; unused.
13327 (wait_debugging): Mark as visible.
13328 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13329 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13330
d4b43b22
PE
13331 * syntax.c (syntax_temp): Define only if !__GNUC__.
13332
b7c513d0
PE
13333 * sound.c (current_sound_device, current_sound): Now static.
13334
989b29ad
PE
13335 * search.c (searchbufs, searchbuf_head): Now static.
13336
13a55a78
PE
13337 * scroll.c (scroll_cost): Remove; unused.
13338 * dispextern.h (scroll_cost): Remove decl.
13339
de68a1fc
PE
13340 * region-cache.h (pp_cache): Mark as externally visible.
13341
40ccffa6
PE
13342 * process.c: Make symbols static if they're not exported.
13343 (process_tick, update_tick, create_process, chan_process):
13344 (Vprocess_alist, proc_buffered_char, datagram_access):
13345 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13346 (deactivate_process): Mark defn as static, as well as decl.
13347 * lisp.h (create_process): Remove decl.
13348 * process.h (chan_process, Vprocess_alist): Remove decls.
13349
ad64fc97
PE
13350 * print.c: Make symbols static if they're not exported.
13351 (print_depth, new_backquote_output, being_printed, print_buffer):
13352 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13353 (print_interval, print_number_index, initial_stderr_stream):
13354 Now static.
13355 * lisp.h (Fprinc): Remove decl.
13356 (debug_output_compilation_hack): Mark as externally visible.
13357
adddb265
PE
13358 * sysdep.c (croak): Move decl from here to syssignal.h.
13359 * syssignal.h (croak): Put it here, so the API can be checked when
13360 'croak' is called from dissociate_if_controlling_tty.
13361
1717ede2
PE
13362 * minibuf.c: Make symbols static if they're not exported.
13363 (minibuf_save_list, choose_minibuf_frame): Now static.
13364 * lisp.h (choose_minibuf_frame): Remove decl.
13365
fa5fb2bc
PE
13366 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13367
1e3890d1
PE
13368 * lread.c: Make symbols static if they're not exported.
13369 (read_objects, initial_obarray, oblookup_last_bucket_number):
13370 Now static.
13371 (make_symbol): Remove; unused.
13372 * lisp.h (initial_obarray, make_symbol): Remove decls.
13373
8a1414fa
PE
13374 * keyboard.c: Make symbols static if they're not exported.
13375 (single_kboard, recent_keys_index, total_keys, recent_keys):
13376 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13377 (this_single_command_key_start, echoing, last_auto_save):
13378 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13379 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13380 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13381 (Vlispy_mouse_stem, double_click_count):
13382 Now static.
13383 (force_auto_save_soon): Define only if SIGDANGER.
13384 (ignore_mouse_drag_p): Now static if
13385 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13386 (print_help): Remove; unused.
13387 (stop_character, last_timer_event): Mark as externally visible.
13388 * keyboard.h (ignore_mouse_drag_p): Declare only if
13389 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13390 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13391 * lisp.h (echoing): Remove decl.
13392 (force_auto_save_soon): Declare only if SIGDANGER.
13393 * xdisp.c (redisplay_window): Simplify code, to make it more
13394 obvious that ignore_mouse_drag_p is not accessed if !defined
13395 USE_GTK && !defined HAVE_NS.
13396
93ea6e8f
PE
13397 * intervals.c: Make symbols static if they're not exported.
13398 (merge_properties_sticky, merge_interval_right, delete_interval):
13399 Now static.
13400 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13401
77382fcc
PE
13402 * insdel.c: Make symbols static if they're not exported.
13403 However, leave prepare_to_modify_buffer alone. It's never
13404 called from outside this function, but that appears to be a bug.
13405 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13406 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13407 (adjust_after_replace_noundo): Remove; unused.
13408 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13409 (signal_before_change): Remove decls.
77382fcc 13410
9306c32e
PE
13411 * indent.c (val_compute_motion, val_vmotion): Now static.
13412
cd44d2eb
PE
13413 * image.c: Make symbols static if they're not exported.
13414 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13415 if USE_GTK.
13416 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13417 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13418
ad9a7a06
PE
13419 * fringe.c (standard_bitmaps): Now static.
13420 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13421
81626931
PE
13422 * frame.c: Make symbols static if they're not exported.
13423 (x_report_frame_params, make_terminal_frame): Now static.
13424 (get_frame_param): Now static, unless HAVE_NS.
13425 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13426 (x_get_resource_string): Remove; not used.
13427 * frame.h (make_terminal_frame, x_report_frame_params):
13428 (x_get_resource_string); Remove decls.
13429 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13430 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13431
239f9db9
PE
13432 * font.c, fontset.c: Make symbols static if they're not exported.
13433 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13434 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13435 * font.c (font_close_object): Now static.
13436 * font.h (font_close_object): Remove.
13437 * fontset.c (FONTSET_OBJLIST): Remove.
13438 (free_realized_fontset) #if-0 the body, which does nothing.
13439 (face_suitable_for_char_p): #if-0, as it's never called.
13440 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13441 * xfaces.c (face_at_string_position):
13442 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13443 since 0 is always ASCII.
13444
dfcf3579
PE
13445 * fns.c (weak_hash_tables): Now static.
13446
5045092b
PE
13447 * fileio.c: Make symbols static if they're not exported.
13448 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13449 (Vwrite_region_annotation_buffers): Now static.
13450
57a96f5c
PE
13451 * eval.c: Make symbols static if they're not exported.
13452 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13453 * lisp.h (backtrace_list): Remove decl.
13454
35f08c38
PE
13455 * emacs.c: Make symbols static if they're not exported.
13456 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13457 (fatal_error_code, fatal_error_signal_hook, standard_args):
13458 Now static.
13459 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13460 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13461 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13462 * lisp.h (fatal_error_signal_hook): Remove decl.
13463 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13464
f44bd759
PE
13465 * editfns.c: Move a (normally-unused) function to its only use.
13466 * editfns.c, lisp.h (get_operating_system_release): Remove.
13467 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13468 worth the hassle of breaking this out.
13469
b532497d
PE
13470 * xterm.c: Make symbols static if they're not exported.
13471 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13472 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13473 (x_destroy_window, x_delete_display):
13474 Now static.
13475 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13476 (x_mouse_leave): Remove; unused.
13477 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13478 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13479 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13480 Remove decls.
13481 (x_mouse_leave): Declare only if WINDOWSNT.
13482 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13483 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13484 USE_X_TOOLKIT.
13485
1675728f
PE
13486 * ftxfont.c: Make symbols static if they're not exported.
13487 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13488 HAVE_FREETYPE.
13489 * font.h (ftxfont_driver): Likewise.
13490
e4cebfca
PE
13491 * xfns.c: Make symbols static if they're not exported.
13492 (x_last_font_name, x_display_info_for_name):
13493 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13494 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13495 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13496 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13497 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13498 (last_show_tip_args): Now static.
13499 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13500 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13501 (x_screen_planes): Remove; unused.
13502 * dispextern.h (x_screen_planes): Remove decl.
13503
5bf46f05
PE
13504 * dispnew.c: Make symbols static if they're not exported.
13505 * dispextern.h (redraw_garbaged_frames, scrolling):
13506 (increment_row_positions): Remove.
13507 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13508 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13509 Now static.
13510 (redraw_garbaged_frames): Remove; unused.
13511
435f4c28
PE
13512 * xfaces.c: Make symbols static if they're not exported.
13513 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13514 Remove decls.
13515 * xterm.h (defined_color): Remove decls.
13516 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13517 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13518 (menu_face_changed_default, defined_color, free_realized_face):
13519 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13520 (ascii_face_of_lisp_face): Remove; unused.
13521
8524aef3
PE
13522 * xdisp.c: Make symbols static if they're not exported.
13523 * dispextern.h (scratch_glyph_row, window_box_edges):
13524 (glyph_to_pixel_coords, set_cursor_from_row):
13525 (get_next_display_element, set_iterator_to_next):
13526 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13527 (show_mouse_face): Remove decls
13528 * frame.h (message_buf_print): Likewise.
13529 * lisp.h (pop_message, set_message, check_point_in_composition):
13530 Likewise.
13531 * xterm.h (set_vertical_scroll_bar): Likewise.
13532 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13533 (message_buf_print, scratch_glyph_row, displayed_buffer):
13534 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13535 (get_next_display_element, show_mouse_face, window_box_edges):
13536 (frame_to_window_pixel_xy, check_point_in_composition):
13537 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13538 (glyph_to_pixel_coords): Remove; unused.
13539
16390cd2
PE
13540 * dired.c (file_name_completion): Now static.
13541
13542 * dbusbind.c (xd_in_read_queued_messages): Now static.
13543
a25f4dfa
PE
13544 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13545 * data.c (circular_list_error): Remove.
13546
14a9c8df
PE
13547 * commands.h (last_point_position, last_point_position_buffer):
13548 (last_point_position_window): Remove decls.
13549 * keyboard.c: Make these variables static.
13550
04f2d78b
CB
13551 * coding.h (coding, code_convert_region, encode_coding_gap):
13552 Remove decls.
74ab6df5
PE
13553 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13554 (iso_code_class, detect_coding, code_convert_region): Now static.
13555 (encode_coding_gap): Remove; unused.
13556
38dfbee1
PE
13557 * chartab.c (chartab_chars, chartab_bits): Now static.
13558
a2cb4e63
PE
13559 * charset.h (charset_iso_8859_1): Remove decl.
13560 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13561 Now static.
13562
127198fd
PE
13563 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13564 * ccl.c (Vccl_program_table): Now static.
13565 (check_ccl_update): Remove; unused.
13566
d85b608f
PE
13567 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13568 * category.h: ... from here.
13569 * category.c (check_category_table, set_category_set): Now static.
13570
31cd66f3
PE
13571 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13572 * lisp.h: Remove these decls.
13573
c358e587
PE
13574 * buffer.c (buffer_count): Remove unused var.
13575
e78aecca
PE
13576 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13577 so that it's not optimized away.
13578 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13579 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13580 exported only to the debugger.
13581
e192d7d3 13582 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13583 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13584
92470028
PE
13585 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13586 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13587 was inaccessible from Lisp.
13588 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13589 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13590
244ed907
PE
13591 alloc.c: Import and export fewer symbols, and remove unused items.
13592 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13593 is defined.
13594 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13595 it's not optimized away by whole-program optimization.
13596 (message_enable_multibyte, free_misc): Remove.
13597 (catchlist, handlerlist, mark_backtrace):
13598 Declare only if BYTE_MARK_STACK.
13599 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13600 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13601 (message_enable_multibyte): Remove decl.
13602 (free_misc, interval_free_list, float_block, float_block_index):
13603 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13604 (cons_free_list, last_marked_index):
13605 Now static.
13606 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13607 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13608 (mark_backtrace): Define only if BYTE_MARK_STACK.
13609 * xdisp.c (message_enable_multibyte): Now static.
13610
61c2b50e 13611 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13612 This makes it easier for human readers (and static analyzers)
13613 to see whether these variables are used from other modules.
13614 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13615 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13616 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13617 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13618 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13619 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13620 * xmenu.c, xselect.c:
13621 Declare Q* vars static if they are not used in other modules.
13622 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13623 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13624 Remove decls of unexported vars.
13625 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13626
95c82688
PE
13627 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13628
16a97296
PE
13629 Make Emacs functions such as Fatom 'static' by default.
13630 This makes it easier for human readers (and static analyzers)
13631 to see whether these functions can be called from other modules.
13632 DEFUN now defines a static function. To make the function external
13633 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13634 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13635 (Finit_image_library):
16a97296
PE
13636 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13637 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13638 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13639 Remove decls, since these functions are now static.
13640 (Funintern, Fget_internal_run_time): New decls, since these functions
13641 were already external.
95c82688 13642
16a97296
PE
13643 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13644 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13645 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13646 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13647 * keyboard.c, keymap.c, lread.c:
13648 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13649 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13650 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13651 Mark functions with DEFUE instead of DEFUN,
13652 if they are used in other modules.
13653 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13654 decls for now-static functions.
13655 * buffer.h (Fdelete_overlay): Remove decl.
13656 * callproc.c (Fgetenv_internal): Mark as internal.
13657 * composite.c (Fremove_list_of_text_properties): Remove decl.
13658 (Fcomposition_get_gstring): New forward static decl.
13659 * composite.h (Fcomposite_get_gstring): Remove decl.
13660 * dired.c (Ffile_attributes): New forward static decl.
13661 * doc.c (Fdocumntation_property): New forward static decl.
13662 * eval.c (Ffetch_bytecode): New forward static decl.
13663 (Funintern): Remove extern decl; now in .h file where it belongs.
13664 * fileio.c (Fmake_symbolic_link): New forward static decl.
13665 * image.c (Finit_image_library): New forward static decl.
13666 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13667 * intervals.h (Fprevious_property_change):
13668 (Fremove_list_of_text_properties): Remove decls.
13669 * keyboard.c (Fthis_command_keys): Remove decl.
13670 (Fcommand_execute): New forward static decl.
13671 * keymap.c (Flookup_key): New forward static decl.
13672 (Fcopy_keymap): Now static.
13673 * keymap.h (Flookup_key): Remove decl.
13674 * process.c (Fget_process): New forward static decl.
13675 (Fprocess_datagram_address): Mark as internal.
13676 * syntax.c (Fsyntax_table_p): New forward static decl.
13677 (skip_chars): Remove duplicate decl.
13678 * textprop.c (Fprevious_property_change): New forward static decl.
13679 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13680 Now internal.
13681 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13682 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13683
785bbd42
PE
13684 * editfns.c (Fformat): Remove unreachable code.
13685
8b913b57
AS
136862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13687
13688 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13689 change. (Bug#8496)
13690
a6744a35
EZ
136912011-04-13 Eli Zaretskii <eliz@gnu.org>
13692
13693 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13694 when at ZV. (Bug#8487)
13695
e7974947
AS
136962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13697
baad03f0
AS
13698 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13699 (Bug#8437)
13700 * keyboard.c (parse_tool_bar_item): Likewise.
13701 * sound.c (sound_cleanup, alsa_close): Likewise.
13702 * termcap.c (tgetent): Likewise.
13703 * xfns.c (x_default_font_parameter): Likewise.
13704 * xsettings.c (read_and_apply_settings): Likewise.
13705
e7974947
AS
13706 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13707 (overrun_check_free): Protoize.
13708
28272684
PE
137092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13710
13711 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13712 since callers should never pass a negative size.
13713 Change the signature to match that of plain 'read' and 'write'; see
13714 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13715 * lisp.h: Update prototypes of emacs_write and emacs_read.
13716
11997c76
EZ
137172011-04-11 Eli Zaretskii <eliz@gnu.org>
13718
13719 * xdisp.c (redisplay_window): Don't try to determine the character
13720 position of the scroll margin if the window start point w->startp
e896f03c 13721 is outside the buffer's accessible region. (Bug#8468)
11997c76 13722
8a2cbd72
EZ
137232011-04-10 Eli Zaretskii <eliz@gnu.org>
13724
13725 Fix write-region and its subroutines for buffers > 2GB.
13726 * fileio.c (a_write, e_write): Modify declaration of arguments and
13727 local variables to support buffers larger than 2GB.
13728 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13729
13730 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13731 argument, local variables, and return value.
13732
13733 * lisp.h: Update prototypes of emacs_write and emacs_read.
13734
13735 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13736
4073e537 137372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13738
1ebfdcb6
PE
13739 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13740
b2ded58d
PE
13741 Fix more problems found by GCC 4.6.0's static checks.
13742
7d66342c
PE
13743 * xdisp.c (vmessage): Use a better test for character truncation.
13744
bbf47d44
PE
13745 * charset.c (load_charset_map): <, not <=, for optimization,
13746 and to avoid potential problems with integer overflow.
9248994d 13747 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13748 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13749 * editfns.c (Fformat): Likewise.
1e69125e 13750 * syntax.c (skip_chars): Likewise.
3befa583 13751
e3019616
PE
13752 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13753 This also lets GCC 4.6.0 generate slightly better loop code.
13754
becfa255
PE
13755 * callint.c (Fcall_interactively): <, not <=, for optimization.
13756 (Fcall_interactively): Count the number of arguments produced,
13757 not the number of arguments given. This is simpler and lets GCC
13758 4.6.0 generate slightly better code.
13759
dae0cd48
PE
13760 * ftfont.c: Distingish more carefully between FcChar8 and char.
13761 The previous code passed unsigned char * to a functions like
13762 strlen and xstrcasecmp that expect char *, which does not
13763 conform to the C standard.
13764 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13765 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13766 char * when the C standard requires it.
13767
76032d70
PE
13768 * keyboard.c (read_char): Remove unused var.
13769
eb3f1cc8
PE
13770 * eval.c: Port to Windows vsnprintf (Bug#8435).
13771 Include <limits.h>.
13772 (SIZE_MAX): Define if the headers do not.
13773 (verror): Do not give up if vsnprintf returns a negative count.
13774 Instead, grow the buffer. This ports to Windows vsnprintf, which
13775 does not conform to C99. Problem reported by Eli Zaretskii.
13776 Also, simplify the allocation scheme, by avoiding the need for
13777 calling realloc, and removing the ALLOCATED variable.
13778
70476b54
PE
13779 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13780
12020a9e
PE
13781 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13782 But keep the doprint source code for now, as we might revamp it
13783 and use it again (Bug#8435).
ea6c7ae6
PE
13784 * lisp.h (doprnt): Remove.
13785 * Makefile.in (base_obj): Remove doprnt.o.
13786 * deps.mk (doprnt.o): Remove.
13787
5fdb398c
PE
13788 error: Print 32- and 64-bit integers portably (Bug#8435).
13789 Without this change, on typical 64-bit hosts error ("...%d...", N)
13790 was used to print both 32- and 64-bit integers N, which relied on
13791 undefined behavior.
61bdb816 13792 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13793 * lisp.h (error, verror): Mark as printf-like functions.
13794 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13795 Report overflow in size calculations when allocating printf buffer.
13796 Do not truncate output string at its first null byte.
13797 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13798 Truncate the output at a character boundary, since vsnprintf does not
13799 do that.
13800 * charset.c (check_iso_charset_parameter): Convert internal
13801 character to string before calling 'error', since %c now has the
13802 printf meaning.
13803 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13804 overflow when computing char to be passed to 'error'. Do not
13805 pass Lisp_Object to 'error'; pass the integer instead.
13806 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13807 formatted with plain %d.
13808
b189fa66
PE
13809 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13810
bff87ef0
PE
13811 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13812
7e2cac20
PE
13813 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13814
ce4d90b5
PE
13815 * xterm.c (x_catch_errors): Remove duplicate declaration.
13816
266c9547
PE
13817 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13818
79c49ad2
PE
13819 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13820
368f4090
JM
138212011-04-10 Jim Meyering <meyering@redhat.com>
13822
13823 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13824 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13825 return ssize_t not "int", and use size_t as the buffer length.
13826 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13827 * gnutls.h: Update declarations.
13828 * process.c (read_process_output): Use ssize_t, to match.
13829 (send_process): Likewise.
13830
a32d4040
CY
138312011-04-09 Chong Yidong <cyd@stupidchicken.com>
13832
13833 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13834
8546720e 138352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13836
04f2d78b
CB
13837 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13838 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13839
8546720e
GM
13840 * xterm.c (handle_one_xevent):
13841 * xmenu.c (create_and_show_popup_menu):
13842 * xselect.c (x_decline_selection_request)
13843 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13844
0a2f5c1a 138452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13846
13847 Fix some uses of `int' instead of EMACS_INT.
13848 * search.c (string_match_1, fast_string_match)
13849 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13850 (scan_buffer, find_next_newline_no_quit)
13851 (find_before_next_newline, search_command, Freplace_match)
13852 (Fmatch_data): Make some `int' variables be EMACS_INT.
13853
13854 * xdisp.c (display_count_lines): 3rd argument and return value now
13855 EMACS_INT. All callers changed.
13856 (pint2hrstr): Last argument is now EMACS_INT.
13857
13858 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13859 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13860 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13861 (decode_coding_utf_16, decode_coding_emacs_mule)
13862 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13863 (decode_coding_ccl, decode_coding_charset)
13864 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13865 (decode_coding_iso_2022, decode_coding_emacs_mule)
13866 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13867 <char_offset, last_offset>: Declare EMACS_INT.
13868 (encode_coding_utf_8, encode_coding_utf_16)
13869 (encode_coding_emacs_mule, encode_invocation_designation)
13870 (encode_designation_at_bol, encode_coding_iso_2022)
13871 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13872 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13873 Declare EMACS_INT.
13874 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13875 (encode_invocation_designation): Last argument P_NCHARS is now
13876 EMACS_INT.
13877 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13878 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13879
13880 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13881 All users changed.
13882
13883 * ccl.c (Fccl_execute_on_string): Declare some variables
13884 EMACS_INT.
13885
8546720e 138862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13887
13888 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13889
4e19a977
CS
138902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13891
13892 * process.c (Fformat_network_address): Doc fix.
13893
87302331
R
138942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13895
ee7683eb 13896 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13897
cbb59342
CY
138982011-04-08 Chong Yidong <cyd@stupidchicken.com>
13899
13900 * keyboard.c (read_char): Call Lisp function help-form-show,
13901 instead of using internal_with_output_to_temp_buffer.
13902 (Qhelp_form_show): New var.
e0d38eeb 13903 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13904
13905 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13906
13907 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13908
e67a13ab
CY
139092011-04-06 Chong Yidong <cyd@stupidchicken.com>
13910
04f2d78b
CB
13911 * process.c (Flist_processes): Remove to Lisp.
13912 (list_processes_1): Delete.
e67a13ab 13913
973f782d
EZ
139142011-04-06 Eli Zaretskii <eliz@gnu.org>
13915
7c106b1e
EZ
13916 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13917
973f782d
EZ
13918 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13919
41cf7d1a 139202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13921
ca23cc88
PE
13922 Fix more problems found by GCC 4.6.0's static checks.
13923
f390e2d5
PE
13924 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13925
42eea0d0
PE
13926 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13927
b69769da 13928 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13929
f9541e84
PE
13930 * xdisp.c (vmessage): Mark as a printf-like function.
13931
13841b55
PE
13932 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13933
c136c10f
PE
13934 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13935
5e2d4a30
PE
13936 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13937 printf-like functions.
13938 (tiff_load): Add casts to remove these marks before passing them
13939 to system-supplied API.
13940
583f48b9
PE
13941 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13942
b25d760e
PE
13943 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13944 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13945 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13946 directly, rather than having caller test rule sign. This avoids
13947 some unnecessary tests.
13948 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13949 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13950 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13951
bc7b6697 13952 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13953 (xfont_open): Avoid unnecessary tests.
bc7b6697 13954
27ccc379
PE
13955 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13956
dcd5c89a
PE
13957 * composite.h, composite.c (composition_gstring_put_cache):
13958 Use EMACS_INT, not int, for length.
13959
b13a45c6
PE
13960 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13961 breaking out part of COMPOSITION_DECODE_RULE.
13962 (COMPOSITION_DECODE_RULE): Use it.
13963 * composite.c (get_composition_id): Remove unused local vars,
13964 by using the new macro.
13965
1e792e4d
PE
13966 * textprop.c (set_text_properties_1): Change while to do-while,
13967 since the condition is always true at first.
13968
dc6c6455 13969 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13970 (interval_deletion_adjustment): Return unsigned value.
13971 All uses changed.
dc6c6455 13972
aba7731a
PE
13973 * process.c (list_processes_1, create_pty, read_process_output):
13974 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13975 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13976 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13977 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13978 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13979
fdfc4bf3
PE
13980 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13981
fca8fe46 13982 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13983 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13984
06a0259a 13985 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13986 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13987 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13988
e7b9e80f
PE
13989 * print.c (print_error_message): Avoid int overflow.
13990
56201685
PE
13991 * font.c (font_list_entities): Redo for clarity,
13992 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13993
78834453 13994 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13995 (font_score): Avoid potential overflow in diff calculation.
78834453 13996
0bc0b309 13997 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13998 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13999
e610eaca
PE
14000 * eval.c (funcall_lambda): Rename local to avoid shadowing.
14001
b895abce
PE
14002 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
14003 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
14004 can always succeed if overflow has undefined behavior.
14005
1f1d9321 14006 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 14007 (wordify): Omit three unnecessary tests.
1f1d9321 14008
c59478bc
PE
14009 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
14010 All callers changed. This avoids the need for an unused var.
14011
79b73827
PE
14012 * casefiddle.c (casify_region): Remove var that is set but not used.
14013
a4db5dfe
PE
14014 * dired.c (file_name_completion): Remove var that is set but not used.
14015
43aae36e
PE
14016 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
14017
2a47c44d 14018 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 14019 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 14020
a37c69bf
PE
14021 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
14022 Check for integer overflow on size calculations.
14023
328ab8e7
PE
14024 * buffer.c (Fprevious_overlay_change): Remove var that is set
14025 but not used.
14026
e5a2a5cb
PE
14027 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
14028 Remove vars that are set but not used.
8d84a6eb 14029 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 14030 (timer_check_2): Mark vars as initialized.
e5a2a5cb 14031
a60e5f68
PE
14032 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
14033
f661cb61 14034 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 14035 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 14036
f0397f5a
PE
14037 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
14038 that are set but not used.
14039
8664db06 14040 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 14041 if XCreateBitmapFromData fails (Bug#8410).
8664db06 14042
6abdaa4a
PE
14043 * xselect.c (x_get_local_selection, x_handle_property_notify):
14044 Remove vars that are set but not used.
14045
0ce7538d 14046 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 14047 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 14048
9ae848fc
PE
14049 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
14050 Remove var that is set but not used.
0b918413
PE
14051 (scroll_bar_windows_size): Now size_t, not int.
14052 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
14053 Check for overflow.
9ae848fc 14054
a5a62657
PE
14055 * xfaces.c (realize_named_face): Remove vars that are set but not used.
14056 (map_tty_color) [!defined MSDOS]: Likewise.
14057
5c5cdd39
PE
14058 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
14059
66ebf983
PE
14060 * coding.c: Remove vars that are set but not used.
14061 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
14062 All callers changed.
14063 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
14064 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
14065 (decode_coding_charset): Remove vars that are set but not used.
14066
1be4d761
PE
14067 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
14068 that is set but not used.
14069
47553fa8
PE
14070 * print.c (print_object): Remove var that is set but not used.
14071
1f7196bf 14072 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
14073 The gnulib version avoids calling malloc in the usual case,
14074 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
14075 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
14076 * filelock.c (current_lock_owner): Likewise.
14077 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
14078 * sysdep.c: Include allocator.h, careadlinkat.h.
14079 (emacs_no_realloc_allocator): New static constant.
14080 (emacs_readlink): New function.
fdb61804
PE
14081 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
14082 ../lib/careadlinkat.h.
d1fdcab7 14083
f84c17c7
SM
140842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
14085
14086 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
14087 first non-nil return value).
14088
ef3862ad
JD
140892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
14090
14091 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
14092 if not defined (Bug#8403).
14093
376a7006
JB
140942011-04-02 Juanma Barranquero <lekktu@gmail.com>
14095
14096 * xdisp.c (display_count_lines): Remove parameter `start',
14097 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14098 (get_char_face_and_encoding): Remove parameter `multibyte_p',
14099 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14100 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14101 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14102 and thereabouts. All callers changed.
14103 (get_per_char_metric): Remove parameter `f', unused since
14104 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14105
6ca3801d
JM
141062011-04-02 Jim Meyering <meyering@redhat.com>
14107
14108 do not dereference NULL upon failed strdup
14109 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14110 (ns_get_family): Likewise.
14111
d8e2b5ba
JB
141122011-04-02 Juanma Barranquero <lekktu@gmail.com>
14113
14114 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14115
8c74fcbd
JD
141162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14117
14118 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14119 later (Bug#8403).
14120
7200d79c
SM
141212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14122
03408648 14123 Add lexical binding.
7200d79c 14124
03408648
SM
14125 * window.c (Ftemp_output_buffer_show): New fun.
14126 (Fsave_window_excursion):
14127 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14128
14129 * lread.c (lisp_file_lexically_bound_p): New function.
14130 (Fload): Bind Qlexical_binding.
14131 (readevalloop): Remove `evalfun' arg.
14132 Bind Qinternal_interpreter_environment.
14133 (Feval_buffer): Bind Qlexical_binding.
14134 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14135 Mark as dynamic.
14136 (syms_of_lread): Declare `lexical-binding'.
14137
14138 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14139
14140 * keyboard.c (eval_dyn): New fun.
14141 (menu_item_eval_property): Use it.
ca105506
SM
14142
14143 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14144
03408648
SM
14145 * fns.c (concat, mapcar1): Accept byte-code-functions.
14146
14147 * eval.c (Fsetq): Handle lexical vars.
14148 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14149 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14150 (FletX, Flet): Obey lexical binding.
14151 (Fcommandp): Handle closures.
14152 (Feval): New `lexical' arg.
14153 (eval_sub): New function extracted from Feval. Use it almost
14154 everywhere where Feval was used. Look up vars in lexical env.
14155 Handle closures.
14156 (Ffunctionp): Move from subr.el.
14157 (Ffuncall): Handle closures.
14158 (apply_lambda): Remove `eval_flags'.
14159 (funcall_lambda): Handle closures and new byte-code-functions.
14160 (Fspecial_variable_p): New function.
14161 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14162 but without exporting it to Lisp.
23aba0ea 14163
23aba0ea 14164 * doc.c (Fdocumentation, store_function_docstring):
03408648 14165 * data.c (Finteractive_form): Handle closures.
23aba0ea 14166
03408648
SM
14167 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14168 interactive spec.
ba83908c 14169
04f2d78b
CB
14170 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14171 New byte-codes.
03408648
SM
14172 (exec_byte_code): New function extracted from Fbyte_code to handle new
14173 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14174
03408648 14175 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14176
03408648 14177 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14178
e2abce01
JB
141792011-03-31 Juanma Barranquero <lekktu@gmail.com>
14180
14181 * xdisp.c (redisplay_internal): Fix prototype.
14182
63696a73 141832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14184
63696a73 14185 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14186 (try_scrolling): Use it when setting scroll_limit.
14187 Limit scrolling to 100 screen lines.
63696a73
EZ
14188 (redisplay_window): Even when falling back on "recentering",
14189 position point in the window according to scroll-conservatively,
14190 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14191
14192 (try_scrolling): When point is above the window, allow searching
14193 as far as scroll_max, or one screenful, to compute vertical
14194 distance from PT to the scroll margin position. This prevents
14195 try_scrolling from unnecessarily failing when
14196 scroll-conservatively is set to a value slightly larger than the
14197 window height. Clean up the case of PT below the margin at bottom
14198 of window: scroll_max can no longer be INT_MAX. When aggressive
14199 scrolling is in use, don't let point enter the opposite scroll
14200 margin as result of the scroll.
14201 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14202 threshold of 100 lines for never-recentering scrolling.
14203
e4cc2dfc
JB
142042011-03-31 Juanma Barranquero <lekktu@gmail.com>
14205
14206 * dispextern.h (move_it_by_lines):
14207 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14208 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14209 (message_log_check_duplicate): Remove parameters `prev_bol' and
14210 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14211 (redisplay_internal): Remove parameter `preserve_echo_area',
14212 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14213
14214 * indent.c (Fvertical_motion):
14215 * window.c (window_scroll_pixel_based, Frecenter):
14216 Don't pass `need_y_p' to `move_it_by_lines'.
14217
1c470562
SM
142182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14219
44f230aa
SM
14220 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14221 steal a few bits to be more compact.
14222 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14223 Remove unneeded casts.
14224
1c470562
SM
14225 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14226
888adce9
ZK
142272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14228
14229 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14230 binding" message (bug#7967).
14231
f838ed7b
PE
142322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14233
77861b95
PE
14234 Fix more problems found by GCC 4.6.0's static checks.
14235
de6dbc14
PE
14236 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14237 Remove unused local var.
14238
f838ed7b
PE
14239 * editfns.c (Fmessage_box): Remove unused local var.
14240
792c7b2b
PE
14241 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14242 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14243 Omit unused local vars.
c499e557 14244 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14245 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14246 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14247 Omit unused local var.
14248
ba0165e1
PE
14249 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14250 Don't assume string length fits in int.
32ad8845 14251 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14252 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14253
3c59b4c9
PE
14254 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14255 instead of alloca (Bug#8344).
14256
a3eed478 14257 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14258 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14259
eb4d412d
PE
14260 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14261
1658b401
PE
14262 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14263 concerns.
14264
14265 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14266
14267 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14268
9a2c6e05
PE
14269 * keyboard.c (syms_of_keyboard): Use the same style as later
14270 in this function when indexing through an array. This also
14271 works around GCC bug 48267.
14272
03d0a109
PE
14273 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14274
44f730c8
PE
14275 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14276
fe75f926
PE
14277 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14278 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14279
ffa8c828
PE
14280 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14281 This avoids undefined behavior on integer overflow, and is a bit
14282 more convenient anyway since it is compared to a size_t variable.
14283
c5101a77
PE
14284 Variadic C functions now count arguments with size_t, not int.
14285 This avoids an unnecessary limitation on 64-bit machines, which
14286 caused (substring ...) to crash on large vectors (Bug#8344).
14287 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14288 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14289 All variadic functions and their callers changed accordingly.
c5101a77
PE
14290 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14291 * data.c (arith_driver, float_arith_driver): Likewise.
14292 * editfns.c (general_insert_function): Likewise.
14293 * eval.c (struct backtrace.nargs, interactive_p)
14294 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14295 (funcall_lambda, mark_backtrace): Likewise.
14296 * fns.c (concat): Likewise.
14297 * frame.c (x_set_frame_parameters): Likewise.
14298 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14299 0 if not found, not -1. All callers changed.
14300
dd3f25f7
PE
14301 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14302 (stack_copy_size): Now size_t, not int.
14303 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14304
461c2ab9
JB
143052011-03-28 Juanma Barranquero <lekktu@gmail.com>
14306
14307 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14308 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14309 All callers changed.
14310
14311 * lisp.h (multibyte_char_to_unibyte):
14312 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14313 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14314 * character.h (CHAR_TO_BYTE8):
14315 * cmds.c (internal_self_insert):
14316 * editfns.c (general_insert_function):
14317 * keymap.c (push_key_description):
14318 * search.c (Freplace_match):
14319 * xdisp.c (message_dolog, set_message_1): All callers changed.
14320
f6d62986
SM
143212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14322
14323 * keyboard.c (safe_run_hook_funcall): New function.
14324 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14325 don't set the hook to nil, but remove the offending function instead.
14326 (Qcommand_hook_internal): Remove, unused.
14327 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14328 Vcommand_hook_internal.
14329
14330 * eval.c (enum run_hooks_condition): Remove.
14331 (funcall_nil, funcall_not): New functions.
14332 (run_hook_with_args): Call each function through a `funcall' argument.
14333 Remove `cond' argument, now redundant.
14334 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14335 (Frun_hook_with_args_until_failure): Adjust accordingly.
14336 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14337
1db5b1ad
JB
143382011-03-28 Juanma Barranquero <lekktu@gmail.com>
14339
14340 * dispextern.h (string_buffer_position): Remove declaration.
14341
14342 * print.c (strout): Remove parameter `multibyte', unused since
14343 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14344
14345 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14346 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14347 All callers changed.
14348
14349 * w32.c (_wsa_errlist): Use braces for struct initializers.
14350
14351 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14352 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14353 All callers changed.
14354 (string_buffer_position): Likewise. Also, make static (it's never
14355 used outside xdisp.c).
14356 (cursor_row_p): Remove parameter `w', unused since
14357 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14358 (decode_mode_spec): Remove parameter `precision', introduced during
14359 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14360 All callers changed.
14361
5ffb62aa
JD
143622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14363
14364 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14365
461c2ab9 143662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14367
14368 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14369 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14370 (ns_update_auto_hide_menu_bar): New functions.
14371 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14372 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14373 ns_constrain_all_frames.
14374 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14375 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14376
5c380ffb
JD
143772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14378
14379 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14380
9af30bdf
GM
143812011-03-27 Glenn Morris <rgm@gnu.org>
14382
14383 * syssignal.h: Replace RETSIGTYPE with void.
14384 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14385 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14386 Replace SIGTYPE with void everywhere.
14387 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14388 * s/template.h (SIGTYPE): Remove commented out definition.
14389
e2abce01
JB
143902011-03-26 Eli Zaretskii <eliz@gnu.org>
14391
14392 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14393 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14394
f868cd8a
JB
143952011-03-26 Juanma Barranquero <lekktu@gmail.com>
14396
59eb0929
JB
14397 * w32.c (read_unc_volume): Use parameter `henum', instead of
14398 global variable `wget_enum_handle'.
14399
14400 * keymap.c (describe_vector): Remove parameters `indices' and
14401 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14402 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14403
f868cd8a
JB
14404 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14405
14406 * keyboard.c (timer_check): Remove parameter `do_it_now',
14407 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14408 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14409 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14410
14411 * keyboard.c (read_char):
14412 * w32menu.c (w32_menu_display_help):
14413 * xmenu.c (show_help_event, menu_help_callback):
14414 Adjust calls to `show_help_echo'.
14415
14416 * gtkutil.c (xg_maybe_add_timer):
14417 * keyboard.c (readable_events):
14418 * process.c (wait_reading_process_output):
14419 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14420
14421 * insdel.c (adjust_markers_gap_motion):
14422 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14423 (gap_left, gap_right): Don't call it.
14424
2ecf6fdb
CY
144252011-03-25 Chong Yidong <cyd@stupidchicken.com>
14426
14427 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14428 incurred during fontification.
14429
6b1f9ba4
JB
144302011-03-25 Juanma Barranquero <lekktu@gmail.com>
14431
14432 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14433 (DEFVAR_PER_BUFFER): Don't pass it.
14434
14435 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14436 (scrolling_window): Don't pass it.
14437
0f4a96b5
JB
144382011-03-25 Juanma Barranquero <lekktu@gmail.com>
14439
14440 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14441
14442 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14443 and `suffix'.
14444 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14445 of variables specific to SELinux and computation of `encoded_absname'.
14446
14447 * image.c (XPutPixel): Remove unused variable `height'.
14448
14449 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14450
14451 * unexw32.c (get_section_info): Remove unused variable `section'.
14452
14453 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14454 (system_process_attributes): Remove unused variable `sess'.
14455 (sys_read): Remove unused variable `err'.
14456
14457 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14458 (w32_wnd_proc): Remove unused variable `isdead'.
14459 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14460 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14461 (x_create_tip_frame): Remove unused variable `tem'.
14462
14463 * w32inevt.c (w32_console_read_socket):
14464 Remove unused variable `no_events'.
14465
14466 * w32term.c (x_draw_composite_glyph_string_foreground):
14467 Remove unused variable `width'.
14468
1149507c
JB
144692011-03-24 Juanma Barranquero <lekktu@gmail.com>
14470
14471 * w32term.c (x_set_glyph_string_clipping):
14472 Don't pass uninitialized region to CombineRgn.
14473
9c88f339
JB
144742011-03-23 Juanma Barranquero <lekktu@gmail.com>
14475
14476 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14477 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14478 (Fx_close_connection): Remove unused variable `i'.
14479
14480 * w32font.c (w32font_draw): Return number of glyphs.
14481 (w32font_open_internal): Remove unused variable `i'.
14482 (w32font_driver): Add missing initializer.
14483
14484 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14485 (fill_in_menu): Remove unused variable `items_added'.
14486
14487 * w32term.c (last_mouse_press_frame): Remove static global variable.
14488 (w32_clip_to_row): Remove unused variable `f'.
14489 (x_delete_terminal): Remove unused variable `i'.
14490
14491 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14492 (NOTHING): Remove unused static global variable.
14493 (uniscribe_check_otf): Remove unused variable `table'.
14494 (uniscribe_font_driver): Add missing initializers.
14495
dee091a3
JD
144962011-03-23 Julien Danjou <julien@danjou.info>
14497
14498 * term.c (Fsuspend_tty, Fresume_tty):
14499 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14500 * window.c (temp_output_buffer_show):
14501 * insdel.c (signal_before_change):
14502 * frame.c (Fhandle_switch_frame):
14503 * fileio.c (Fdo_auto_save):
14504 * emacs.c (Fkill_emacs):
14505 * editfns.c (save_excursion_restore):
14506 * cmds.c (internal_self_insert):
14507 * callint.c (Fcall_interactively):
14508 * buffer.c (Fkill_all_local_variables):
14509 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14510 Use Frun_hooks.
0f4a96b5 14511 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14512 unconditionally since it does the check itself.
dee091a3 14513
2c520ab5 145142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14515
c9c49752
PE
14516 Fix more problems found by GCC 4.5.2's static checks.
14517
8abc3f12
PE
14518 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14519 the first time through the loop, since we know p0 < p1 then.
14520 This also avoids a gcc -Wstrict-overflow warning.
14521
a2d26660
PE
14522 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14523 leading to a memory leak, possible in functions like
14524 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14525 of objects (Bug#8318).
a2d26660 14526
916c72e9
PE
14527 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14528 that could (at least in theory) be that large.
14529
19ab8a18
PE
14530 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14531 This is less likely to overflow, and avoids undefined behavior if
14532 overflow does occur. All callers changed. Use strtoul to scan
14533 for the unsigned long integer.
b7cbbd6f
PE
14534 (pint2hrstr): Simplify and tune code slightly.
14535 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14536
f0641eff
PE
14537 * scroll.c (do_scrolling): Work around GCC bug 48228.
14538 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14539
7f650bb9
PE
14540 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14541 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14542 (validate_x_resource_name): Simplify count usage.
14543 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14544
37dd57d1
PE
14545 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14546 fail (Bug#8306).
81e56e61 14547
699979fc 14548 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14549
401bf9b4
PE
14550 * process.c (Fmake_network_process): Use socklen_t, not int,
14551 where POSIX says socklen_t is required in portable programs.
14552 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14553 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14554 (Fmake_network_process, server_accept_connection):
14555 (wait_reading_process_output, read_process_output):
14556 Likewise.
14557
b93aacde
PE
14558 * process.c: Rename or move locals to avoid shadowing.
14559 (list_processes_1, Fmake_network_process):
14560 (read_process_output_error_handler, exec_sentinel_error_handler):
14561 Rename or move locals.
4dc343ee 14562 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14563 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14564 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14565 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14566 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14567
af8a867c 14568 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14569 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14570 Include tparam.h instead, since it declares them.
af8a867c
PE
14571 * cm.h (PC): Remove extern decl; tparam.h now does this.
14572 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14573 * terminfo.c: Include tparam.h, to check interfaces.
14574 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14575 (tparam): Adjust signature to match interface in tparam.h;
14576 this removes some undefined behavior. Check that outstring and len
14577 are zero, which they always are with Emacs.
14578 * tparam.h (PC, BC, UP): New extern decls.
14579
0248044d 14580 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14581 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14582
8ff096c1 14583 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14584 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14585 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14586 (ftfont_list): Remove unused local.
49eaafba
PE
14587 (get_adstyle_property, ftfont_pattern_entity):
14588 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14589 Rename locals to avoid shadowing.
8ff096c1 14590
e2be39f6
PE
14591 * xfont.c (xfont_list_family): Mark var as initialized.
14592
c9735e30
PE
14593 * xml.c (make_dom): Now static.
14594
8f5201ae
PE
14595 * composite.c (composition_compute_stop_pos): Rename local to
14596 avoid shadowing.
b246f932
PE
14597 (composition_reseat_it): Remove unused locals.
14598 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14599 (composition_update_it): Mark var as initialized.
11b61122
PE
14600 (find_automatic_composition): Mark vars as initialized,
14601 with a FIXME (Bug#8290).
8f5201ae 14602
760fbc2c
PE
14603 character.h: Rename locals to avoid shadowing.
14604 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14605 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14606 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14607 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14608 to avoid shadowing.
14609
ff08eb85
PE
14610 * textprop.c (property_change_between_p): Remove; unused.
14611
fc7bf025
PE
14612 * intervals.c (interval_start_pos): Now static.
14613
235d7abc
PE
14614 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14615
44f230aa
SM
14616 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14617 Rename locals to avoid shadowing.
3e7d6594 14618
50060332
PE
14619 * sound.c (wav_play, au_play, Fplay_sound_internal):
14620 Fix pointer signedness.
d01f234b 14621 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14622 (wav_play): Initialize a variable to 0, to prevent undefined
14623 behavior (Bug#8278).
50060332 14624
c4fc4e30
PE
14625 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14626
918436ed
PE
14627 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14628
c939f91b
PE
14629 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14630 clobbering (Bug#8298).
b9c7f648
PE
14631 * sysdep.c (sys_subshell): Likewise.
14632 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14633
6bd8c144
PE
14634 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14635 This should get cleaned up, so that child_setup has the
14636 same signature on all platforms.
14637
7710357c 14638 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14639 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14640
c59da222
CY
146412011-03-22 Chong Yidong <cyd@stupidchicken.com>
14642
14643 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14644 not to be necessary, and produces flickering.
14645
66b87493
GM
146462011-03-20 Glenn Morris <rgm@gnu.org>
14647
14648 * config.in: Remove file.
14649
45b6f6d5
JB
146502011-03-20 Juanma Barranquero <lekktu@gmail.com>
14651
14652 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14653 are now in src/globals.h.
14654 (syms_of_minibuf): Remove spurious & from previous change.
14655
cd394be1 146562011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14657
14658 * minibuf.c (completing-read-function): New variable.
14659 (completing-read-default): Rename from completing-read.
14660 (completing-read): Call completing-read-function.
14661
b14e3e21
CY
146622011-03-19 Juanma Barranquero <lekktu@gmail.com>
14663
14664 * xfaces.c (Fx_load_color_file):
14665 Read color file from absolute filename (bug#8250).
14666
f2b726e6
JB
146672011-03-19 Juanma Barranquero <lekktu@gmail.com>
14668
14669 * makefile.w32-in: Update dependencies.
14670
09f6ff02
EZ
146712011-03-17 Eli Zaretskii <eliz@gnu.org>
14672
14673 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14674
29a6015a
PE
146752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14676
a3a6c54e
PE
14677 Fix more problems found by GCC 4.5.2's static checks.
14678
b766f867
PE
14679 * process.c (make_serial_process_unwind, send_process_trap):
14680 (sigchld_handler): Now static.
14681
be02381c
PE
14682 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14683 That way, the code declares only the vars that it needs.
14684 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14685 * s/cygwin.h (PTY_ITERATION): Likewise.
14686 * s/darwin.h (PTY_ITERATION): Likewise.
14687 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14688
57048744
PE
14689 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14690 * process.c (allocate_pty): Don't declare stb unless it's needed.
14691
7914961c 14692 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14693 (CONSTANTLIM): Remove; unused.
14694 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14695 Define only if needed.
7914961c 14696
b3967b18
PE
14697 * unexelf.c (unexec): Name an expression,
14698 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14699 Use a different way to cause a compilation error if anyone uses
14700 n rather than nn, a way that does not involve shadowing.
73366a00 14701 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14702
29a6015a
PE
14703 * deps.mk (unexalpha.o): Remove; unused.
14704
43cfc33e 14705 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14706 * unexec.h: New file.
ce701a33
PE
14707 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14708 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14709 Depend on unexec.h.
14710 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14711 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14712 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14713 Change as necessary to match prototype in unexec.h.
ce701a33 14714
01f44d5a
PE
14715 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14716 shadowing.
4f63c6bb 14717 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14718
a6670b0b
PE
14719 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14720 Rename locals to avoid shadowing.
14721
cef2010d 14722 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14723 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14724
d4d7173a
PE
14725 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14726
f08b802a
PE
14727 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14728 warning when compiling print.c.
14729
3ddb0639
PE
14730 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14731 instead of using an uninitialized var.
5ad03b97 14732 (font_sort_entities): Mark var as initialized.
3ddb0639 14733
170a2692
PE
14734 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14735
e663c700
PE
14736 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14737 pointers to constants.
89bc529a 14738 (font_parse_fcname): Remove unused vars.
7b81e2d0 14739 (font_delete_unmatched): Now static.
ea838e10 14740 (font_get_spec): Remove; unused.
13a547c6
PE
14741 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14742 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14743 Rename or move locals to avoid shadowing.
e663c700 14744
2a80c887 14745 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14746 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14747
1384fa33 14748 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14749 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14750
8b2c52e9
PE
14751 * alloc.c (mark_backtrace): Move decl from here ...
14752 * lisp.h: ... to here, so that it can be checked.
14753
475545b5 14754 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14755 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14756 (lisp_indirect_variable): Name an expression,
14757 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14758 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14759
b1349114 14760 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14761 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14762 Use const pointer when appropriate.
b1349114 14763
a2928364
PE
14764 * lisp.h (get_system_name, get_operating_system_release):
14765 Move decls here, to check interfaces.
14766 * process.c (get_operating_system_release): Move decl to lisp.h.
14767 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14768 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14769 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14770 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14771 (Fformat_time_string, Fencode_time, Finsert_char):
14772 (Ftranslate_region_internal, Fformat):
14773 Rename or remove local vars to avoid shadowing.
9710023e 14774 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14775
a415e694
PE
14776 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14777 avoid shadowing.
14778
8ef4622d
PE
14779 * lisp.h (eassert): Check that the argument compiles, even if
14780 ENABLE_CHECKING is not defined.
14781
946f9a5b
PE
14782 * data.c (Findirect_variable): Name an expression, to avoid
14783 gcc -Wbad-function-cast warning.
112396d6 14784 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14785 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14786 (Fmake_variable_buffer_local, Fmake_local_variable):
14787 Mark variables as initialized.
52746918 14788 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14789
e5aab7e7 14790 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14791 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14792 Rename locals to avoid shadowing.
dff45157
PE
14793 (mark_stack): Move local variables into the #ifdef region where
14794 they're used.
7bc26fdb
PE
14795 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14796 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14797 needed otherwise.
14798 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14799 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14800 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14801
e5aab7e7
PE
14802 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14803 avoids undefined behavior in theory.
14804
4da60324
PE
14805 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14806
88043301
PE
14807 Use functions, not macros, for up- and down-casing (Bug#8254).
14808 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14809 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14810 to use the following functions instead of these macros.
14811 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14812 EMACS_INT, since callers assume the returned value fits in int.
14813 (upcase1): Likewise, for UPCASE_TABLE.
14814 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14815 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14816 the race-condition problem in the old DOWNCASE.
88043301 14817
19ed5445
PE
14818 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14819 Rename locals to avoid shadowing.
14820 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14821 (regex_compile, re_search_2, re_match_2_internal):
14822 Remove unused local vars.
952db0d7
PE
14823 (FREE_VAR): Rewrite so as not to use empty "else",
14824 which gcc can warn about.
da053e48 14825 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14826 (RETALLOC_IF): Define only if needed.
14827 (WORDCHAR_P): Likewise. This one is never needed, but is used
14828 only in a comment talking about a compiler bug, so put inside
14829 the #if 0 of that comment.
14830 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14831 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14832 Remove; unused.
19ed5445 14833
1f3561e4 14834 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14835 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14836 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14837
ded6f8f7
PE
14838 * search.c (simple_search): Remove unused var.
14839
dbd37a95
PE
14840 * dired.c (compile_pattern): Move decl from here ...
14841 * lisp.h: ... to here, so that it can be checked.
14842 (struct re_registers): New forward decl.
14843
7e47afad
PE
14844 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14845
85f24f61
PE
14846 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14847 All uses changed.
14848 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14849 Rename locals to avoid shadowing.
5671df8f 14850 (Fvertical_motion): Mark locals as initialized.
85f24f61 14851
181aa2be 14852 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14853 (casify_region): Mark local as initialized.
181aa2be 14854
930d429c
PE
14855 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14856
7082eac6
PE
14857 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14858 New macros, so that the caller can use some names other than
14859 gcpro1, gcpro2, etc.
14860 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14861 of the new macros.
14862 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14863 argument, for consistency with GCPRO2_VAR, etc: it is now the
14864 prefix of the variable, not the variable itself. All uses
14865 changed.
38b2c076
PE
14866 * dired.c (directory_files_internal, file_name_completion):
14867 Rename locals to avoid shadowing.
14868
15206ed9
PE
14869 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14870 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14871 dired.c's scmp function, had undefined behavior.
14872 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14873 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14874 * buffer.h: ... to here, because these macros use current_buffer,
14875 and the new implementation with inline functions needs to have
14876 current_buffer in scope now, rather than later when the macros
14877 are used.
14878 (downcase, upcase1): New static inline functions.
14879 (DOWNCASE, UPCASE1): Reimplement using these functions.
14880 This avoids undefined behavior in expressions like
14881 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14882 from race conditions in accessing the global variables
14883 case_temp1 and case_temp2.
14884 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14885 * lisp.h (case_temp1, case_temp2): Remove their decls.
14886 * character.h (ASCII_CHAR_P): Move from here ...
14887 * lisp.h: ... to here, so that the inline functions mentioned
14888 above can use them.
14889
4a6bea26
PE
14890 * dired.c (directory_files_internal_unwind): Now static.
14891
f14b7e14
PE
14892 * fileio.c (file_name_as_directory, directory_file_name):
14893 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14894 Now static.
2893f146
PE
14895 (file_name_as_directory): Use const pointers when appropriate.
14896 (Fexpand_file_name): Likewise. In particular, newdir might
14897 point at constant storage, so make it a const pointer.
fd4ead52 14898 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14899 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14900 signedness issues.
f839df0c
PE
14901 (Fset_file_times, Finsert_file_contents, auto_save_error):
14902 Rename locals to avoid shadowing.
f14b7e14 14903
5716756e 14904 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14905 (Ftry_completion, Fall_completions): Rename or remove locals
14906 to avoid shadowing.
5716756e 14907
b4c3046a
PE
14908 * marker.c (bytepos_to_charpos): Remove; unused.
14909
b45db522
PE
14910 * lisp.h (verify_bytepos, count_markers): New decls,
14911 so that gcc does not warn that these functions aren't declared.
14912
85876d07
PE
14913 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14914 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14915 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14916 (copy_text): Remove unused local var.
85876d07 14917
03d78a21 14918 * filelock.c (within_one_second): Now static.
b3dd38ab 14919 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14920
5df8f01b
PE
14921 * buffer.c (fix_overlays_before): Mark locals as initialized.
14922 (fix_start_end_in_overlays): Likewise. This function should be
14923 simplified by using pointers-to-pointers, but that's a different
14924 matter.
b1d876f1 14925 (switch_to_buffer_1): Now static.
8f54f30a
PE
14926 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14927 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14928
a70072c9 14929 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14930 Fix pointer signedness issue.
edced198
PE
14931 (sys_subshell): Mark local as volatile if checking for lint,
14932 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14933 (MAXPATHLEN): Define only if needed.
a70072c9 14934
a0977c44
PE
14935 * process.c (serial_open, serial_configure): Move decls from here ...
14936 * systty.h: ... to here, so that they can be checked.
14937
a884fdcc
PE
14938 * fns.c (get_random, seed_random): Move extern decls from here ...
14939 * lisp.h: ... to here, so that they can be checked.
14940
604efe86 14941 * sysdep.c (reset_io): Now static.
b8950c94 14942 (wait_for_termination_signal): Remove; unused.
604efe86 14943
38fc62d9
PE
14944 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14945 (copy_keymap_item, append_key, push_text_char_description):
14946 Now static.
1004a21a 14947 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14948 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14949 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14950 (describe_map_tree):
14951 Rename locals to avoid shadowing.
38fc62d9 14952
2f2650da
PE
14953 * keyboard.c: Declare functions static if they are not used elsewhere.
14954 (echo_char, echo_dash, cmd_error, top_level_2):
14955 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14956 (read_char, kbd_buffer_get_event, make_lispy_position):
14957 (make_lispy_event, make_lispy_movement, apply_modifiers):
14958 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14959 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14960 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14961 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14962 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14963
a053e86c 14964 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14965 (mark_kboards): Move decl here ...
14966 * alloc.c (mark_kboards): ... from here.
a053e86c 14967
4752793e
PE
14968 * lisp.h (force_auto_save_soon): New decl.
14969
74f10ca7 14970 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14971 (DEFINE_DUMMY_FUNCTION): New macro.
14972 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14973 Use it.
c03cd23f
PE
14974 (main): Add casts to avoid warnings
14975 if GCC considers string literals to be constants.
74f10ca7 14976
022e70d4
PE
14977 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14978
59d6fe83
PE
14979 * dbusbind.c: Pointer signedness fixes.
14980 (xd_signature, xd_append_arg, xd_initialize):
14981 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14982 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14983 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14984 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14985
78320123
PE
14986 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14987 if GCC considers string literals to be constants.
49cebcca 14988 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14989
35ac2a97
SM
149902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14991
fb103ca9
SM
14992 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14993 (print_preprocess, print_object): New macro to fix last change.
14994
35ac2a97
SM
14995 * print.c (print_preprocess): Don't forget font objects.
14996
62973b41
JB
149972011-03-16 Juanma Barranquero <lekktu@gmail.com>
14998
14999 * emacs.c (USAGE3): Doc fixes.
15000
0e48bb22
AS
150012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
15002
15003 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
15004 structure.
15005
7684e57b
JB
150062011-03-14 Juanma Barranquero <lekktu@gmail.com>
15007
15008 * lisp.h (VWindow_system, Qfile_name_history):
15009 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
15010 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
15011 (w32_system_caret_x, w32_system_caret_y): Declare extern.
15012
15013 * w32select.c: Don't #include "keyboard.h".
c96bbc66 15014 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
15015
15016 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
15017 * w32console.c (detect_input_pending, read_input_pending)
15018 (encode_terminal_code):
15019 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
15020 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
15021 (w32_system_caret_y, Qfile_name_history):
15022 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
15023 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
15024 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
15025 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
15026 * w32proc.c (Qlocal, report_file_error):
15027 * w32term.c (Vwindow_system, updating_frame):
15028 * w32uniscribe.c (initialized, uniscribe_font_driver):
15029 Remove unneeded extern declarations.
15030
2aa46d6c
CY
150312011-03-14 Chong Yidong <cyd@stupidchicken.com>
15032
c96bbc66 15033 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 15034
cffc6f3b
CY
150352011-03-13 Chong Yidong <cyd@stupidchicken.com>
15036
15037 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
15038 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
15039 These macros can no longer be used for assignment.
15040
44f230aa
SM
15041 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
15042 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
15043 (record_buffer_markers, fetch_buffer_markers): New functions for
15044 recording and fetching special buffer markers.
15045 (set_buffer_internal_1, set_buffer_temp): Use them.
15046
15047 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
15048
15049 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
15050
15051 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
15052 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
15053
15054 * xdisp.c (hscroll_window_tree):
15055 (reconsider_clip_changes): Use PT instead of BUF_PT.
15056
d251f04b
EZ
150572011-03-13 Eli Zaretskii <eliz@gnu.org>
15058
15059 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
15060 $(EMACS_ROOT)/lib/intprops.h.
15061
f0c77cd1
PE
150622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
15063
3eca4629
PE
15064 Fix more problems found by GCC 4.5.2's static checks.
15065
7c86ee98
PE
15066 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
15067 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
15068 (xg_free_frame_widgets): Make it clear that a local variable is
15069 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
15070 (gdk_window_get_screen): Make it clear that this macro is needed
15071 only if USE_GTK_TOOLTIP.
1e5524e7
PE
15072 (int_gtk_range_get_value): New function, which avoids a diagnostic
15073 from gcc -Wbad-function-cast.
15074 (xg_set_toolkit_scroll_bar_thumb): Use it.
15075 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
15076 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
15077 (get_utf8_string, xg_get_file_with_chooser):
15078 Rename locals to avoid shadowing.
15079 (create_dialog): Move locals to avoid shadowing.
7c86ee98 15080
41729b81
PE
15081 * xgselect.c (xg_select): Remove unused var.
15082
f0c77cd1
PE
15083 * image.c (four_corners_best): Mark locals as initialized.
15084 (gif_load): Initialize transparent_p to zero (Bug#8238).
15085 Mark another local as initialized.
ec6cf4c6 15086 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 15087
ce0ad53d 15088 * image.c (clear_image_cache): Now static.
d5d5a617 15089 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 15090 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
15091 (x_edge_detection): Remove unnecessary cast that
15092 gcc -Wbad-function-cast diagnoses.
2037898d 15093 (gif_load): Fix pointer signedness.
6ae141d6
PE
15094 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
15095 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 15096
33383987 150972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 15098
d32df629
PE
15099 Improve quality of tests for time stamp overflow.
15100 For example, without this patch (encode-time 0 0 0 1 1
15101 1152921504606846976) returns the obviously-bogus value (-948597
15102 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15103 reports time overflow. See
15104 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15105 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15106 * editfns.c: Include limits.h and intprops.h.
15107 (TIME_T_MIN, TIME_T_MAX): New macros.
15108 (time_overflow): Move earlier, to before first use.
15109 (hi_time, lo_time): New functions, for an accurate test for
15110 out-of-range times.
15111 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15112 (Fget_internal_run_time): Don't assume time_t fits in int.
15113 (make_time): Use list2 instead of Fcons twice.
15114 (Fdecode_time): More accurate test for out-of-range times.
15115 (check_tm_member): New function.
15116 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15117 (lisp_time_argument): Don't rely on undefined left-shift and
15118 right-shift behavior when checking for time stamp overflow.
8be6f318 15119
fe31d94c
PE
15120 * editfns.c (time_overflow): New function, refactoring common code.
15121 (Fformat_time_string, Fdecode_time, Fencode_time):
15122 (Fcurrent_time_string): Use it.
15123
8be6f318
PE
15124 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15125 * dired.c (make_time): Move to ...
15126 * editfns.c (make_time): ... here.
15127 * systime.h: Note the move.
15128
09d9db2c 151292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15130
126bc0dc
YM
15131 * fringe.c (update_window_fringes): Remove unused variables.
15132
c47cbdfd
YM
15133 * unexmacosx.c (copy_data_segment): Also copy __got section.
15134 (Bug#8223)
15135
7ac80be9
EZ
151362011-03-12 Eli Zaretskii <eliz@gnu.org>
15137
c96bbc66 15138 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15139 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15140 Constify `char *' arguments and their references according to
15141 prototypes in tparam.h.
15142
ecb0f94d 15143 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15144
7ac80be9
EZ
15145 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15146 Adapt all references accordingly.
15147
15148 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15149
ef1fd07e
TT
151502011-03-11 Tom Tromey <tromey@redhat.com>
15151
15152 * buffer.c (syms_of_buffer): Remove obsolete comment.
15153
7ef4b50c
EZ
151542011-03-11 Eli Zaretskii <eliz@gnu.org>
15155
15156 * termhooks.h (encode_terminal_code): Declare prototype.
15157
15158 * msdos.c (encode_terminal_code): Don't declare prototype.
15159
15160 * term.c (encode_terminal_code): Now external again, used by
15161 w32console.c and msdos.c.
15162
44f230aa
SM
15163 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15164 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15165
4b1ec863 151662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15167
1714f52b 15168 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15169
4b1ec863
PE
15170 * fringe.c (update_window_fringes): Mark locals as initialized
15171 (Bug#8227).
15172 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15173
524c7aa6
PE
15174 * alloc.c (mark_fringe_data): Move decl from here ...
15175 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15176 to check its interface.
15177 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15178
a5c0af81 15179 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15180 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15181 (fontset_font): Mark local as initialized.
a9a06e0b 15182 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15183
b4716021
PE
15184 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15185
811e9bac 15186 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15187 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15188 (x_own_selection, Fx_disown_selection_internal): Rename locals
15189 to avoid shadowing.
15190 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15191
7e3ab302
PE
15192 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15193 so that the caller can use some name other than gcpro1.
15194 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15195 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15196 (Fx_backspace_delete_keys_p):
15197 Use them to avoid shadowing, and rename vars to avoid shadowing.
15198 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15199 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15200 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15201 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15202 Remove unused locals.
7e3ab302
PE
15203 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15204 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15205 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15206 macros.
f78faa98 15207
e2b13473
PE
15208 * xterm.h (x_mouse_leave): New decl.
15209
77f23912
PE
15210 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15211 Remove unused functions.
cdf4ba58
PE
15212 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15213 (x_calc_absolute_position): Now static.
7411c686 15214 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15215 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15216 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15217 unless they are used.
38d0b34a
PE
15218 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15219 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15220 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15221 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15222 (x_error_catcher, x_connection_closed, x_error_handler):
15223 (x_error_quitter, xembed_send_message, x_iconify_frame):
15224 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15225 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15226 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15227
44f230aa
SM
15228 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15229 Rename or move locals to avoid shadowing.
6b463e58 15230 (tty_defined_color, merge_face_heights): Now static.
5967d051 15231 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15232 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15233 does not deduce is never used uninitialized.
73719eba
PE
15234 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15235 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15236
426994c3 15237 * terminal.c (store_terminal_param): Now static.
5489860b 15238
032f1620 15239 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15240 (set_frame_menubar): Remove unused local.
d4323972 15241 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15242 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15243 since they might point to immutable storage.
281585b0
PE
15244 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15245 since it's unused otherwise.
032f1620 15246
367c19e5 15247 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15248 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15249 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15250 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15251 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15252 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15253 does not deduce are never used uninitialized.
70739cbe 15254
07b48fa9
PE
15255 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15256
8868a238 15257 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15258 * window.c (window_loop, size_window):
15259 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15260
7e5cf297 15261 * window.c (display_buffer): Now static.
d6550a9f
PE
15262 (size_window): Mark variables that gcc -Wuninitialized
15263 does not deduce are never used uninitialized.
a586633d
PE
15264 * window.h (check_all_windows): New decl, to forestall
15265 gcc -Wmissing-prototypes diagnostic.
5b555da1 15266 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15267
f6095868
PE
15268 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15269 shadowing.
15270 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15271 Include <limits.h>.
15272 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15273 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15274 (load_charset_map): Mark variables that gcc -Wuninitialized
15275 does not deduce are never used uninitialized.
53df7c11 15276 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15277
f38b440c
PE
15278 * coding.c (coding_set_source, coding_set_destination):
15279 Use "else { /* comment */ }" rather than "else /* comment */;"
15280 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15281 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15282 a block, when the outer 'i' will do.
15283 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15284 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15285 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15286 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15287 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15288 Rename locals to avoid shadowing.
15289 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15290 * coding.c (emacs_mule_char, encode_invocation_designation):
15291 Now static, since they're not used elsewhere.
413bb2db 15292 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15293 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15294 (decode_coding_emacs_mule): Mark variables that gcc
15295 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15296 (detect_coding_iso_2022): Initialize a local variable that might
15297 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15298 this initialization is needed. (Bug#8211)
5f58e762
PE
15299 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15300 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15301 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15302 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15303 Remove unused macros.
f38b440c 15304
232b38b9 15305 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15306 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15307 * character.c (string_count_byte8): Likewise.
232b38b9 15308
fb90da1b
PE
15309 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15310 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15311
fb93dbc2
PE
15312 * chartab.c (copy_sub_char_table): Now static, since it's not used
15313 elsewhere.
5c156ace
PE
15314 (sub_char_table_ref_and_range, char_table_ref_and_range):
15315 Rename locals to avoid shadowing.
bbcd0949 15316 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15317
7d3b3862 15318 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15319 (BIDI_BOB): Remove unused macro.
7d3b3862 15320
6be7d3da
PE
15321 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15322 deduce are never used uninitialized.
c2ed9c8b 15323 * term.c (encode_terminal_code): Likewise.
6be7d3da 15324
75f8807f 15325 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15326
50938595
PE
15327 * tparam.h: New file.
15328 * term.c, tparam.h: Include it.
15329 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15330 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15331 Move these decls to tparam.h, and make them agree with what
15332 is actually in tparam.c. The previous trick of using incompatible
15333 decls in different modules does not conform to the C standard.
15334 All callers of tparam changed to use tparam's actual API.
15335 * tparam.c (tparam1, tparam, tgoto):
15336 Use const pointers where appropriate.
15337
fbceeba2
PE
15338 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15339 * cm.h (struct cm): Likewise.
15340 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15341 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15342 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15343 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15344 (turn_on_face, init_tty): Likewise.
15345 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15346
7f3f1250
PE
15347 * term.c (term_mouse_position): Rename local to avoid shadowing.
15348
e6ca6543
PE
15349 * alloc.c (mark_ttys): Move decl from here ...
15350 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15351
c40f8d15
AS
153522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15353
15354 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15355
cfe0661d
JB
153562011-03-09 Juanma Barranquero <lekktu@gmail.com>
15357
15358 * search.c (compile_pattern_1): Remove argument regp, unused since
15359 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15360 (compile_pattern): Don't pass it.
15361
0afb4571
J
153622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15363
15364 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15365 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15366 for ! HAVE_GTK3.
15367 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15368
15369 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15370
15371 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15372 gdk_window_get_screen, gdk_window_get_geometry,
15373 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15374 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15375 (xg_get_pixbuf_from_pixmap): New function.
15376 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15377 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15378 Call xg_get_pixbuf_from_pixmap instead of
15379 gdk_pixbuf_get_from_drawable.
15380 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15381 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15382 (xg_check_special_colors): Use GtkStyleContext and its functions
15383 for HAVE_GTK3.
15384 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15385 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15386 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15387 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15388 Call gtk_widget_get_preferred_size.
0afb4571
J
15389 (xg_frame_resized): gdk_window_get_geometry only takes 5
15390 parameters.
44f230aa
SM
15391 (xg_win_to_widget, xg_event_is_for_menubar):
15392 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15393 (xg_set_widget_bg): New function.
15394 (delete_cb): New function.
895009e1 15395 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15396 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15397 (xg_set_background_color): Call xg_set_widget_bg.
15398 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15399 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15400 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15401 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15402 if ! HAVE_GTK3.
15403 (update_frame_tool_bar): Call gtk_widget_hide.
15404 (xg_initialize): Use GDK_KEY_g.
15405
15406 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15407 if ! HAVE_GTK3
15408 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15409
15410 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15411 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15412 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15413
1c2cc4ef
JB
154142011-03-08 Juanma Barranquero <lekktu@gmail.com>
15415
15416 * w32xfns.c (select_palette): Check success of RealizePalette against
15417 GDI_ERROR, not zero.
15418
33383987 15419See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15420
15421;; Local Variables:
15422;; coding: utf-8
aac0c6e3
MR
15423;; End:
15424
2f097256 15425 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15426
15427 This file is part of GNU Emacs.
15428
15429 GNU Emacs is free software: you can redistribute it and/or modify
15430 it under the terms of the GNU General Public License as published by
15431 the Free Software Foundation, either version 3 of the License, or
15432 (at your option) any later version.
15433
15434 GNU Emacs is distributed in the hope that it will be useful,
15435 but WITHOUT ANY WARRANTY; without even the implied warranty of
15436 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15437 GNU General Public License for more details.
15438
15439 You should have received a copy of the GNU General Public License
15440 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.