Merge from intsign.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5637687f
PE
12011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2
d3411f89
PE
3 Use ptrdiff_t for hash table indexes.
4 * category.c (hash_get_category_set):
5 * ccl.c (ccl_driver):
6 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7 * coding.c (coding_system_charset_list, detect_coding_system):
8 * coding.h (struct coding_system.id):
9 * composite.c (get_composition_id, gstring_lookup_cache):
10 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11 * image.c (xpm_get_color_table_h):
12 * lisp.h (hash_lookup, hash_put):
13 * minibuf.c (Ftest_completion):
14 Use ptrdiff_t for hash table indexes, not int (which is too
15 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
16 32-bit --with-wide-int hosts).
17
e097a6fa
PE
18 * charset.c (Fdefine_charset_internal): Check for integer overflow.
19 Add a FIXME comment about memory leaks.
20 (syms_of_charset): Don't assume xmalloc returns.
21
5637687f
PE
22 Don't assume that stated character widths fit in int.
23 * character.c (Fchar_width, c_string_width, lisp_string_width):
24 * character.h (CHAR_WIDTH):
25 * indent.c (MULTIBYTE_BYTES_WIDTH):
26 Use sanitize_char_width to avoid undefined and/or bad behavior
27 with outlandish widths.
28 * character.h (sanitize_tab_width): Renamed from sanitize_width,
29 now that we have two such functions. All uses changed.
30 (sanitize_char_width): New inline function.
31
a2271ba2
PE
32 Don't assume that tab-width fits in int.
33 * character.h (sanitize_width): New inline function.
34 (SANE_TAB_WIDTH): New macro.
35 (ASCII_CHAR_WIDTH): Use it.
36 * indent.c (sane_tab_width): Remove. All uses replaced by
37 SANE_TAB_WIDTH (current_buffer).
38 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
39
18c52557
PE
40 * fileio.c: Integer overflow issues with file modes.
41 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
42
caeeedc1
PE
43 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
44 Remove unreachable code.
45 (read_hex, load_charset_map_from_file): Check for integer overflow.
46
50849c52
PE
47 * xterm.c: don't go over XClientMessageEvent limit
48 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
49 (x_send_scroll_bar_event): Likewise. Check that the size does not
50 exceed limits imposed by XClientMessageEvent, as well as the usual
51 ptrdiff_t and size_t limits.
52
b13995db
PE
53 * keyboard.c: Overflow, signedness and related fixes.
54 (make_lispy_movement): Use same integer type in forward decl
55 that is used in the definition.
56 (read_key_sequence, keyremap_step):
57 Change bufsize argument back to int, undoing my 2011-03-30 change.
58 We prefer signed types, and int is wide enough here.
59 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
60 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
61 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
62 length, not size_t. Use ptrdiff_t for index, not int.
63 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
64 possibility of integer overflow.
65
13464394
PE
66 Overflow, signedness and related fixes for images.
67
68 * dispextern.h (struct it.stack[0].u.image.image_id)
69 (struct_it.image_id, struct image.id, struct image_cache.size)
70 (struct image_cache.used, struct image_cache.ref_count):
71 * gtkutil.c (update_frame_tool_bar):
72 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
73 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
74 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
75 * nsmenu.m (update_frame_tool_bar):
76 * xdisp.c (calc_pixel_width_or_height):
77 * xfns.c (image_cache_refcount):
78 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
79 on typical 64-bit hosts.
80
81 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
82 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
83 Omit unnecessary casts to int.
84 (parse_image_spec): Check that integers fall into 'int' range
85 when the callers expect that.
86 (image_ascent): Redo ascent calculation to avoid int overflow.
87 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
88 (lookup_image): Remove unnecessary tests.
89 (xbm_image_p): Locals are now of int, not EMACS_INT,
90 since parse_image_check makes sure they fit into int.
91 (png_load, gif_load, svg_load_image):
92 Prefer int to unsigned where either will do.
93 (tiff_handler): New function, combining the cores of the
94 old tiff_error_handler and tiff_warning_handler. This
95 function is rewritten to use vsnprintf and thereby avoid
96 stack buffer overflows. It uses only the features of vsnprintf
97 that are common to both POSIX and native Microsoft.
98 (tiff_error_handler, tiff_warning_handler): Use it.
99 (tiff_load, gif_load, imagemagick_load_image):
100 Don't assume :index value fits in 'int'.
101 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
102 (imagemagick_load_image): Check that crop parameters fit into
103 the integer types that MagickCropImage accepts. Don't assume
104 Vimagemagick_render_type has a nonnegative value. Don't assume
105 size_t fits in 'long'.
106 (gs_load): Use printmax_t to print the widest integers possible.
107 Check for integer overflow when computing image height and width.
108
0d8de0fd 1092011-07-19 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 110
41f55ccd 111 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 112
39e378da
PE
113 * bidi.c: Integer size and overflow fixes.
114 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
115 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
116 (bidi_cache_find_level_change, bidi_cache_ensure_space)
117 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
118 (bidi_find_other_level_edge):
119 Use ptrdiff_t instead of EMACS_INT where either will do.
120 This works better on 32-bit hosts configured --with-wide-int.
121 (bidi_cache_ensure_space): Check for size-calculation overflow.
122 Use % rather than repeated addition, for better worst-case speed.
123 Don't set bidi_cache_size until after xrealloc returns, because it
124 might not return.
125 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
126 (bidi_cache_ensure_space): Also check that the bidi cache size
127 does not exceed that of the largest Lisp string or buffer. See Eli
128 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 129
5e927815
PE
130 * alloc.c (__malloc_size_t): Remove.
131 All uses replaced by size_t. See Andreas Schwab's note
132 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
133
ca4aa935
PE
134 * image.c: Improve checking for integer overflow.
135 (check_image_size): Assume that f is nonnull, since
136 it is always nonnull in practice. This is one less thing to
137 worry about when checking for integer overflow later.
138 (x_check_image_size): New function, which checks for integer
139 overflow issues inside X.
140 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
141 This removes the need for a memory_full check.
142 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
143 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
144 (xbm_read_bitmap_data): Change locals back to 'int', since
145 their values must fit in 'int'.
146 (xpm_load_image, png_load, tiff_load):
147 Invoke x_create_x_image_and_pixmap earlier,
148 to avoid much needless work if the image is too large.
149 (tiff_load): Treat overly large images as if
150 x_create_x_image_and_pixmap failed, not as malloc failures.
151 (gs_load): Use x_check_image_size.
152
5f8f9cc2
PE
153 * gtkutil.c: Omit integer casts.
154 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
155 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
156
5adf60bc
PE
157 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
158
c8907a93
PE
159 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
160 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
161 would wrongly return t on a 64-bit host.
162
e3c25c68
PE
163 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
164 The plain *_OVERFLOW macros run afoul of GCC bug 49705
165 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
166 and therefore cause GCC to emit a bogus diagnostic in some cases.
167
3f791afe
PE
168 * image.c: Integer signedness and overflow and related fixes.
169 This is not an exhaustive set of fixes, but it's time to
170 record what I've got.
171 (lookup_pixel_color, check_image_size): Remove redundant decls.
172 (check_image_size): Don't assume that arbitrary EMACS_INT values
173 fit in 'int', or that arbitrary 'double' values fit in 'int'.
174 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
175 (tiff_load, imagemagick_load_image):
176 Check for overflow in size calculations.
177 (x_create_x_image_and_pixmap): Remove unnecessary test for
178 xmalloc returning NULL; that can't happen.
179 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
180 (xpm_color_bucket): Use better integer hashing function.
181 (xpm_cache_color): Don't possibly over-allocate memory.
182 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
183 (gif_memory_source):
184 Use ptrdiff_t, not int or size_t, to record sizes.
185 (png_load): Don't assume values greater than 2**31 fit in 'int'.
186 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
187 either works, as we prefer signed integers.
188 (tiff_read_from_memory, tiff_write_from_memory):
189 Return tsize_t, not size_t, since that's what the TIFF API wants.
190 (tiff_read_from_memory): Don't fail simply because the read would
191 go past EOF; instead, return a short read.
192 (tiff_load): Omit no-longer-needed casts.
193 (Fimagemagick_types): Don't assume size fits into 'int'.
194
3cc5a532
PE
195 Improve hashing quality when configured --with-wide-int.
196 * fns.c (hash_string): New function, taken from sxhash_string.
197 Do not discard information about ASCII character case; this
198 discarding is no longer needed.
199 (sxhash-string): Use it. Change sig to match it. Caller changed.
200 * lisp.h: Declare it.
201 * lread.c (hash_string): Remove, since we now use fns.c's version.
202 The fns.c version returns a wider integer if --with-wide-int is
203 specified, so this should help the quality of the hashing a bit.
204
b312a492
PE
205 * emacs.c: Integer overflow minor fix.
206 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
207 Define only if GNU_LINUX.
208 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
209
dfd153ae
PE
210 * dispnew.c: Integer signedness and overflow fixes.
211 Remove unnecessary forward decls, that were a maintenance hassle.
212 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
213 All uses changed.
214 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
215 (scrolling_window): Use ptrdiff_t, not int, for byte count.
216 (prepare_desired_row, line_draw_cost):
217 Use int, not unsigned, where either works.
218 (save_current_matrix, restore_current_matrix):
219 Use ptrdiff_t, not size_t, where either works.
220 (init_display): Check for overflow more accurately, and without
221 relying on undefined behavior.
222
a81d11a3
PE
223 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
224 Remove, replacing with the new symbols in lisp.h. All uses changed.
225 * fileio.c (make_temp_name):
226 * filelock.c (lock_file_1, lock_file):
227 * xdisp.c (message_dolog):
228 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
229 Use pMd etc. instead.
230 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
231 replacing the pWIDE etc. symbols removed from editfns.c.
232
3300e6fd
PE
233 * keyboard.h (num_input_events): Now uintmax_t.
234 This is (very slightly) less likely to mess up due to wraparound.
235 All uses changed.
236
fd05c7e9
PE
237 * buffer.c: Integer signedness fixes.
238 (alloc_buffer_text, enlarge_buffer_text):
239 Use ptrdiff_t rather than size_t when either will do, as we prefer
240 signed integers.
241
903fe15d
PE
242 * alloc.c: Integer signedness and overflow fixes.
243 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
244 (__malloc_size_t): Default to size_t, not to int.
245 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
246 (Fgarbage_collect, mark_object_loop_halt, mark_object):
247 Prefer ptrdiff_t to size_t when either would do, as we prefer
248 signed integers.
249 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
250 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
251 Now const. Initialize with values that are in range even if char
252 is signed.
253 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
254 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
255 These functions do the right thing with sizes > 2**32.
256 (check_depth): Now ptrdiff_t, not int.
257 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
258 Adjust to new way of storing sizes. Check for size overflow bugs
259 in rest of code.
260 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
261 slightly wrong anyway, as it missed one instance of
262 XMALLOC_OVERRUN_CHECK_OVERHEAD.
263 (refill_memory_reserve): Omit needless cast to size_t.
264 (mark_object_loop_halt): Mark as externally visible.
265
ac82cc6a
PE
266 * xselect.c: Integer signedness and overflow fixes.
267 (Fx_register_dnd_atom, x_handle_dnd_message):
268 Use ptrdiff_t, not size_t, since we prefer signed.
269 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
270 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
271 x_dnd_atoms_size and x_dnd_atoms_length.
272
c2d1e36d
PE
273 * doprnt.c: Prefer signed to unsigned when either works.
274 * eval.c (verror):
275 * doprnt.c (doprnt):
276 * lisp.h (doprnt):
277 * xdisp.c (vmessage):
278 Use ptrdiff_t, not size_t, when using or implementing doprnt,
279 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
280 prefer signed arithmetic to avoid comparison confusion.
281 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
282 but is a bit tricky.
283
0e926e56
PE
284 Assume freestanding C89 headers, string.h, stdlib.h.
285 * data.c, doprnt.c, floatfns.c, print.c:
286 Include float.h unconditionally.
287 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
288 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
289 * regex.c: Likewise for stddef.h, string.h.
290 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
291 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
292 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
293 (STDC_HEADERS): Remove obsolete defines.
294 * sysdep.c: Include limits.h unconditionally.
295
9cfdb3ec
PE
296 Assume support for memcmp, memcpy, memmove, memset.
297 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
298 * regex.c (memcmp, memcpy):
299 Remove; we assume C89 now.
300
301 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
302 (__malloc_safe_bcopy): Remove; no longer needed.
303
cf950e6b 304 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
305 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
306 well either way, and we prefer signed to unsigned.
307
590bd467
PE
3082011-07-19 Paul Eggert <eggert@cs.ucla.edu>
309
310 Port to OpenBSD.
311 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
312 and the surrounding thread.
313 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
314 rather than fgets, and retry after EINTR. Otherwise, 'emacs
315 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
316 timer goes off.
317 * s/openbsd.h (BROKEN_SIGIO): Define.
318 * unexelf.c (unexec) [__OpenBSD__]:
319 Don't update the .mdebug section of the Alpha COFF symbol table.
320
f41628b2
LMI
3212011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
322
323 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
324 (bug#8460).
325
b59b67c5
PE
3262011-07-18 Paul Eggert <eggert@cs.ucla.edu>
327
15e3a074
PE
328 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
329 This fixes some race conditions on the permissions of any newly
330 created file.
331
41bed37d
PE
332 * alloc.c (valid_pointer_p): Use pipe, not open.
333 This fixes some permissions issues when debugging.
334
b59b67c5
PE
335 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
336 If fchown fails to set both uid and gid, try to set just gid,
337 as that is sometimes allowed. Adjust the file's mode to eliminate
338 setuid or setgid bits that are inappropriate if fchown fails.
339
925a6be7
SM
3402011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
343 to compare Lisp_Objects.
344 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
345 global_gnutls_log_level, don't mistake it for a Lisp_Object.
346 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
347
52968808
AS
3482011-07-17 Andreas Schwab <schwab@linux-m68k.org>
349
0a6a104b
AS
350 * lread.c (read_integer): Unread even EOF character.
351 (read1): Likewise. Properly record start position of symbol.
352
52968808
AS
353 * lread.c (read1): Read `#:' as empty uninterned symbol if no
354 symbol character follows.
355
9e381cdd
PE
3562011-07-17 Paul Eggert <eggert@cs.ucla.edu>
357
358 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
359 This works around a problem with the previous change to Fcopy_file.
360 Recent glibc declares fchown with __attribute__((warn_unused_result)),
361 and without this change, GCC might complain about discarding
362 fchown's return value.
363
b5641435
JB
3642011-07-16 Juanma Barranquero <lekktu@gmail.com>
365
366 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
367
a8031457
PE
3682011-07-16 Paul Eggert <eggert@cs.ucla.edu>
369
370 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
371
dd889327
LMI
3722011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
373
750c33f7
LMI
374 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
375 it's used from the C level.
376
dd889327
LMI
377 * process.c: Use the same condition for POLL_FOR_INPUT in both
378 keyboard.c and process.c (bug#1858).
379
87e86684
LM
3802011-07-09 Lawrence Mitchell <wence@gmx.li>
381
382 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
383 (Fgnutls_boot): Use it.
384
64348f40
AS
3852011-07-15 Andreas Schwab <schwab@linux-m68k.org>
386
387 * doc.c (Fsubstitute_command_keys): Revert last change.
388
1d698799
LMI
3892011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
390
f863868c
LMI
391 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
392 quotes the next character, and doesn't affect other longer
393 sequences (bug#8935).
394
1d698799
LMI
395 * lread.c (syms_of_lread): Clarify that is isn't only
396 `eval-buffer' and `eval-defun' that's affected by
397 `lexical-binding' (bug#8460).
398
aa4b6df6
EZ
3992011-07-15 Eli Zaretskii <eliz@gnu.org>
400
401 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
402 bidi redisplay when a line includes both an image and is
403 truncated.
404
5d856da6
PE
4052011-07-14 Paul Eggert <eggert@cs.ucla.edu>
406
ad6042bb
PE
407 Fix minor problems found by static checking.
408 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
409 (elsz): Now a signed constant, not a size_t var. We prefer signed
410 types to unsigned, to avoid integer comparison confusion. Without
411 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
412 "cannot optimize loop, the loop counter may overflow", a symptom
413 of the confusion.
f00bbb22 414 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
415 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
416
6468f31c
LMI
4172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
49080b10
LMI
419 * search.c (Fre_search_backward): Mention `case-fold-search' in
420 all the re_search_* functions (bug#8138).
421
6468f31c
LMI
422 * keyboard.c (Fopen_dribble_file): Document when the file is
423 closed (bug#8056).
424
c965adc5
EZ
4252011-07-14 Eli Zaretskii <eliz@gnu.org>
426
df9733bf
EZ
427 * bidi.c (bidi_dump_cached_states): Fix format of displaying
428 bidi_cache_idx.
429
0bb23927
EZ
430 Support bidi reordering of display and overlay strings.
431 * xdisp.c (compute_display_string_pos)
432 (compute_display_string_end): Accept additional argument STRING.
433 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
434 (reseat_to_string): Initialize bidi_it->string.s and
435 bidi_it->string.schars.
436 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
437 NULL (avoids a crash in bidi_paragraph_init). Initialize
438 itb.string.lstring.
439 (init_iterator): Call bidi_init_it only of a valid
440 buffer position was specified. Initialize paragraph_embedding to
441 L2R.
442 (reseat_to_string): Initialize the bidi iterator.
443 (display_string): If we need to ignore text properties of
444 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
445 original value of -1 will not work with bidi.)
446 (compute_display_string_pos): First arg is now struct
447 `text_pos *'; all callers changed. Support display properties on
448 Lisp strings.
449 (compute_display_string_end): Support display properties on Lisp
450 strings.
451 (init_iterator, reseat_1, reseat_to_string): Initialize the
452 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
453 when iterating on a string not from display properties).
454 (compute_display_string_pos, compute_display_string_end): Fix
455 calculation of the object to scan. Fixes an error when using
456 arrow keys.
457 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
458 base_level_stop; instead, set base_level_stop to BEGV. Fixes
459 crashes in vertical-motion.
460 (next_element_from_buffer): Improve commentary for when
461 the iterator is before prev_stop.
462 (init_iterator): Initialize bidi_p from the default value of
463 bidi-display-reordering, not from buffer-local value. Use the
464 buffer-local value only if initializing for buffer iteration.
465 (handle_invisible_prop): Support invisible properties on strings
466 that are being bidi-reordered.
467 (set_iterator_to_next): Support bidi reordering of C strings and
468 Lisp strings.
469 (next_element_from_string): Support bidi reordering of Lisp
470 strings.
471 (handle_stop_backwards): Support Lisp strings as well.
472 (display_string): Support display of R2L glyph rows. Use
473 IT_STRING_CHARPOS when displaying from a Lisp string.
474 (init_iterator): Don't initialize it->bidi_p for strings
475 here.
476 (reseat_to_string): Initialize it->bidi_p for strings here.
477 (next_element_from_string, next_element_from_c_string)
478 (next_element_from_buffer): Add xassert's for correspondence
479 between IT's object being iterated and it->bidi_it.string
480 structure.
481 (face_before_or_after_it_pos): Support bidi iteration.
482 (next_element_from_c_string): Handle the case of the first string
483 character that is not the first one in the visual order.
484 (get_visually_first_element): New function, refactored from common
485 parts of next_element_from_buffer, next_element_from_string, and
486 next_element_from_c_string.
487 (tool_bar_lines_needed, redisplay_tool_bar)
488 (display_menu_bar): Force left-to-right direction. Add a FIXME
489 comment for making that be controlled by a user option.
490 (push_it, pop_it): Save and restore the state of the
491 bidi iterator. Save and restore the bidi_p flag.
492 (pop_it): Iterate out of display property for string iteration as
493 well.
494 (iterate_out_of_display_property): Support iteration over strings.
495 (handle_single_display_spec): Set up it->bidi_it for iteration
496 over a display string, and call bidi_init_it.
497 (handle_single_display_spec, next_overlay_string)
498 (get_overlay_strings_1, push_display_prop): Set up the bidi
499 iterator for displaying display or overlay strings.
500 (forward_to_next_line_start): Don't use the shortcut if
501 bidi-iterating.
502 (back_to_previous_visible_line_start): If handle_display_prop
503 pushed the iterator stack, restore the internal state of the bidi
504 iterator by calling bidi_pop_it same number of times.
505 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
506 and we are bidi-iterating, don't decrement the iterator position;
507 instead, set the first_elt flag in the bidi iterator, to produce
508 the same effect.
509 (reseat_1): Remove redundant setting of string_from_display_prop_p.
510 (push_display_prop): xassert that we are iterating a buffer.
511 (push_it, pop_it): Save and restore paragraph_embedding member.
512 (handle_single_display_spec, next_overlay_string)
513 (get_overlay_strings_1, reseat_1, reseat_to_string)
514 (push_display_prop): Set up the `unibyte' member of bidi_it.string
515 correctly. Don't assume unibyte strings are not bidi-reordered.
516 (compute_display_string_pos)
517 (compute_display_string_end): Fix handling the case of C string.
518 (push_it, pop_it): Save and restore from_disp_prop_p.
519 (handle_single_display_spec, push_display_prop): Set the
520 from_disp_prop_p flag.
521 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
522 (pop_it): Call iterate_out_of_display_property only if we are
523 popping after iteration over a string that came from a display
524 property. Fix a typo in popping stretch info. Add an assertion
525 for verifying that the iterator position is in sync with the bidi
526 iterator.
527 (handle_single_display_spec, get_overlay_strings_1)
528 (push_display_prop): Fix initialization of paragraph direction for
529 string when that of the parent object is not yet determined.
530 (reseat_1): Call bidi_init_it to resync the bidi
531 iterator with IT's position. (Bug#7616)
532 (find_row_edges): If ROW->start.pos gives position
533 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
534 (handle_stop, back_to_previous_visible_line_start, reseat_1):
535 Reset the from_disp_prop_p flag.
536 (SAVE_IT, RESTORE_IT): New macros.
537 (pos_visible_p, face_before_or_after_it_pos)
538 (back_to_previous_visible_line_start)
539 (move_it_in_display_line_to, move_it_in_display_line)
540 (move_it_to, move_it_vertically_backward, move_it_by_lines)
541 (try_scrolling, redisplay_window, display_line): Use them when
542 saving a temporary copy of the iterator and restoring it back.
543 (back_to_previous_visible_line_start, reseat_1)
544 (init_iterator): Empty the bidi cache "stack".
545 (move_it_in_display_line_to): If iterator ended up at
546 EOL, but we never saw any buffer positions smaller than
547 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
548 motion in bidi-reordered lines.
549 (move_it_in_display_line_to): Record prev_method and prev_pos
550 immediately before the call to set_iterator_to_next. Fixes cursor
551 motion in bidi-reordered lines with stretch glyphs and strings
552 displayed in margins. (Bug#8133) (Bug#8867)
553 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
554 TO_CHARPOS.
555 (pos_visible_p): Support positions in bidi-reordered lines. Save
556 and restore bidi cache.
557
558 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
559 (bidi_paragraph_info): Delete unused struct.
560 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
561 (bidi_cache_start): New variable.
562 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
563 to zero.
564 (bidi_cache_fetch_state, bidi_cache_search)
565 (bidi_cache_find_level_change, bidi_cache_iterator_state)
566 (bidi_cache_find, bidi_peek_at_next_level)
567 (bidi_level_of_next_char, bidi_find_other_level_edge)
568 (bidi_move_to_visually_next): Compare cache index with
569 bidi_cache_start rather than with zero.
570 (bidi_fetch_char): Accept new argument STRING; all callers
571 changed. Support iteration over a string. Support strings with
572 display properties. Support unibyte strings. Fix the type of
573 `len' according to what STRING_CHAR_AND_LENGTH expects.
574 (bidi_paragraph_init, bidi_resolve_explicit_1)
575 (bidi_resolve_explicit, bidi_resolve_weak)
576 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
577 iteration over a string.
578 (bidi_set_sor_type, bidi_resolve_explicit_1)
579 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
580 can now be zero (for strings); special values 0 and -1 were
581 changed to -1 and -2, respectively.
582 (bidi_char_at_pos): New function.
583 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
584 Call it instead of FETCH_MULTIBYTE_CHAR.
585 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
586 initialized to valid values.
587 (bidi_init_it): Don't initialize charpos and bytepos with invalid
588 values.
589 (bidi_level_of_next_char): Allow the sentinel "position" to pass
590 the test for valid cached positions. Fix the logic for looking up
591 the sentinel state in the cache. GCPRO the Lisp string we are
592 iterating.
593 (bidi_push_it, bidi_pop_it): New functions.
594 (bidi_initialize): Initialize the bidi cache start stack pointer.
595 (bidi_cache_ensure_space): New function, refactored from part of
596 bidi_cache_iterator_state. Don't assume the required size is just
597 one BIDI_CACHE_CHUNK away.
598 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
599 (bidi_count_bytes, bidi_char_at_pos): New functions.
600 (bidi_cache_search): Don't assume bidi_cache_last_idx is
601 always valid if bidi_cache_idx is valid.
602 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
603 is valid if it's going to be used.
604 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
605 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
606 (bidi_cache_find_level_change, bidi_cache_ensure_space)
607 (bidi_cache_iterator_state, bidi_cache_find)
608 (bidi_find_other_level_edge, bidi_cache_start_stack): All
609 variables related to cache indices are now EMACS_INT.
610
0bb23927
EZ
611 * dispextern.h (struct bidi_string_data): New structure.
612 (struct bidi_it): New member `string'. Make flag members be 1-bit
613 fields, and put them last in the struct.
614 (compute_display_string_pos, compute_display_string_end): Update
615 prototypes.
616 (bidi_push_it, bidi_pop_it): Add prototypes.
617 (struct iterator_stack_entry): New members bidi_p,
618 paragraph_embedding, and from_disp_prop_p.
619 (struct it): Member bidi_p is now a bit field 1 bit wide.
620 (bidi_shelve_cache, bidi_unshelve_cache): Declare
621 prototypes.
622
623 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
624 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
625 and vector-like objects.
626
627 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
628 cache around display iteration.
629
630 * window.c (Fwindow_end, window_scroll_pixel_based)
631 (displayed_window_lines, Frecenter): Save and restore the bidi
632 cache around display iteration.
633
3bbd2265
LMI
6342011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
635
636 * editfns.c (Fdelete_region): Clarify the use of the named
637 parameters (bug#6788).
638
adc47434
MR
6392011-07-14 Martin Rudalics <rudalics@gmx.at>
640
641 * indent.c (Fvertical_motion): Set and restore w->pointm when
642 saving and restoring the window's buffer (Bug#9006).
643
837c31f8
LMI
6442011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
645
646 * editfns.c (Fstring_to_char): Clarify just what is returned
647 (bug#6576). Text by Eli Zaretskii.
648
ac389d0c
JB
6492011-07-13 Juanma Barranquero <lekktu@gmail.com>
650
651 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
652
0be0ce47
EZ
6532011-07-13 Eli Zaretskii <eliz@gnu.org>
654
655 * buffer.c (mmap_find): Fix a typo.
656
cd18e7e3
JB
6572011-07-13 Johan Bockgård <bojohan@gnu.org>
658
659 Fix execution of x selection hooks.
660 * xselect.c (Qx_lost_selection_functions)
661 (Qx_sent_selection_functions): New vars.
662 (syms_of_xselect): DEFSYM them.
663 (x_handle_selection_request): Pass Qx_sent_selection_functions
664 rather than Vx_sent_selection_functions to Frun_hook_with_args.
665 (x_handle_selection_clear,x_clear_frame_selections):
666 Pass Qx_lost_selection_functions rather than
667 Vx_lost_selection_functions to Frun_hook_with_args.
668
47ea7f44
PE
6692011-07-13 Paul Eggert <eggert@cs.ucla.edu>
670
ac389d0c 671 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
672 The old code sometimes used this field without initializing it.
673
47ea7f44
PE
674 * alloc.c (gc_sweep): Don't read past end of array.
675 In theory, the old code could also have corrupted Emacs internals,
676 though it'd be very unlikely.
677
bc985c87
AS
6782011-07-12 Andreas Schwab <schwab@linux-m68k.org>
679
680 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 681 argument. (Bug#4026)
bc985c87 682
0cf34688
LMI
6832011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
684
b3dadd76
LMI
685 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
686 key" (bug#4257).
687
0cf34688
LMI
688 * window.c (Fset_window_start): Doc fix (bug#4199).
689 (Fset_window_hscroll): Ditto.
690
270768cd
PE
6912011-07-12 Paul Eggert <eggert@cs.ucla.edu>
692
077e3dda 693 Fix minor new problems caught by GCC 4.6.1.
270768cd 694 * term.c (init_tty): Remove unused local.
490011a6 695 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 696 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 697 not used otherwise.
270768cd 698
b1f58454
CY
6992011-07-12 Chong Yidong <cyd@stupidchicken.com>
700
701 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
702
22b9578d
LMI
7032011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
704
6e70ab07
LMI
705 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
706 are the mini-buffer and the echo area (bug#3320).
707
22b9578d
LMI
708 * term.c (init_tty): Remove support for supdup, c10 and perq
709 terminals, which are no longer supported (bug#1482).
710
8974cc9f
JB
7112011-07-10 Johan Bockgård <bojohan@gnu.org>
712
713 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
714
a560d974
JD
7152011-07-10 Jan Djärv <jan.h.d@swipnet.se>
716
717 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
718 for non-popups (Bug#3642).
719
1dae0f0a
AS
7202011-07-10 Andreas Schwab <schwab@linux-m68k.org>
721
268c2c36 722 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 723 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
724 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
725 * cm.c (losecursor): Likewise.
1dae0f0a
AS
726 * data.c (fmod): Likewise.
727 * dispnew.c (swap_glyphs_in_rows): Likewise.
728 * emacs.c (memory_warning_signal): Likewise.
729 * floatfns.c (float_error): Likewise.
730 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
731 (otf_open, font_otf_capability, generate_otf_features)
732 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
733 Likewise.
734 * image.c (pbm_read_file): Likewise.
735 * indent.c (string_display_width): Likewise.
736 * intervals.c (check_for_interval, search_for_interval)
737 (inc_interval_count, count_intervals, root_interval)
738 (adjust_intervals_for_insertion, make_new_interval): Likewise.
739 * lread.c (defalias): Likewise.
268c2c36 740 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
741 * regex.c (set_image_of_range_1, set_image_of_range)
742 (regex_grow_registers): Likewise.
743 * sysdep.c (strerror): Likewise.
744 * termcap.c (valid_filename_p, tprint, main): Likewise.
745 * tparam.c (main): Likewise.
746 * unexhp9k800.c (run_time_remap, save_data_space)
747 (update_file_ptrs, read_header, write_header, calculate_checksum)
748 (copy_file, copy_rest, display_header): Likewise.
749 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
750 Likewise.
751 * xdisp.c (check_it): Likewise.
752 * xfaces.c (register_color, unregister_color, unregister_colors):
753 Likewise.
754 * xfns.c (print_fontset_result): Likewise.
755 * xrdb.c (member, fatal, main): Likewise.
756
99033785
PE
7572011-07-10 Paul Eggert <eggert@cs.ucla.edu>
758
759 Fix minor problems found by static checking (Bug#9031).
760 * chartab.c (char_table_set_range, map_sub_char_table):
761 Remove unused locals.
762 (uniprop_table): Now static.
763 * composite.c (_work_char): Remove unused static var.
764
9cb2ac56
JB
7652011-07-09 Juanma Barranquero <lekktu@gmail.com>
766
767 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
768
f25661f0
JD
7692011-07-09 Jan Djärv <jan.h.d@swipnet.se>
770
771 * gtkutil.c (qttip_cb): Remove code without function.
772
8278c4fe
EZ
7732011-07-09 Eli Zaretskii <eliz@gnu.org>
774
775 * w32.c (pthread_sigmask): New stub.
776
1692ae2d 7772011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 778
8a6ebd58 779 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
780 sigprocmask is portable only for single-threaded applications, and
781 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
782 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
783 (LIBES): Use it.
784 * callproc.c (Fcall_process):
785 * process.c (create_process):
786 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
787 Use pthread_sigmask, not sigprocmask.
123403e4 788
1b854618
JD
7892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
790
791 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
792 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
793 wrong (Bug#8591).
794
3fe4b549
JD
7952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
796
0ce7e563
JD
797 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
798 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
799 (xg_hide_tooltip): Fix comment.
800
3fe4b549
JD
801 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
802 in registerServicesMenuSendTypes.
803 (validRequestorForSendType): Don't check ns_return_types.
804
805 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
806 ns_return_type.
807
5df75e47
JR
8082011-07-08 Jason Rumney <jasonr@gnu.org>
809
810 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
811 frame struct members of non-existent frames (Bug#6284).
812
699c10bd
JD
8132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
814
4393663b
JD
815 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
816 variable firstTime not needed on OSX >= 10.6.
817 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
818 >= 10.5. Use setKnobProportion, setDoubleValue.
819
820 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
821 (MAC_OS_X_VERSION_10_5): Define if not defined.
822 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
823 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
824 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
825
826 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
827 cString and lossyCString on OSX >= 10.4
828
829 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
830 sizeToFit on OSX >= 10.2.
831
832 * nsimage.m (allocInitFromFile): Don't use deprecated method
833 bestRepresentationForDevice on OSX >= 10.6.
834
835 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
836 to avoid warning.
837
838 * emacs.c: Declare unexec_init_emacs_zone.
839
a63e0781
JD
840 * nsgui.h: Fix compiler warning about gnulib redefining verify.
841
699c10bd
JD
842 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
843
844 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
845 on svcsMenu (Bug#8842).
846
847 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
848 ns_return_types.
849 (Fns_list_services): Just return Qnil on 10.6, code not working there.
850
851 * nsterm.m (QUTF8_STRING): Declare.
852 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
853 (validRequestorForSendType): Return type is (id).
854 Change indexOfObjectIdenticalTo to indexOfObject.
855 Check if we have local selection before returning self (Bug#8842).
856 (writeSelectionToPasteboard): Put local selection into paste board
857 if we have a local selection (Bug#8842).
858 (syms_of_nsterm): DEFSYM QUTF8_STRING.
859
860 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
861 (ns_get_local_selection): Declare.
862
54e10184
LMI
8632011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
864
9888ff71
LMI
865 * keymap.c (describe_map_tree): Don't insert a double newline at
866 the end of the buffer (bug#1169) and return whether we inserted
867 something.
868
54e10184
LMI
869 * callint.c (Fcall_interactively): Change "reading args" to
870 "providing args" to try to clarify what it does (bug#1010).
871
15fa4783
KH
8722011-07-07 Kenichi Handa <handa@m17n.org>
873
874 * composite.c (composition_compute_stop_pos): Ignore a static
875 composition starting before CHARPOS (Bug#8915).
876
877 * xdisp.c (handle_composition_prop): Likewise.
878
a8815b00
EZ
8792011-07-07 Eli Zaretskii <eliz@gnu.org>
880
881 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
882 (Bug#9015)
883
ef7b981d 8842011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
885
886 * character.h (unicode_category_t): New enum type.
887
888 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
889 (Qchar_code_property_table): New variable.
890 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
891 (UNIPROP_COMPRESSED_FORM_P): New macros.
892 (char_table_ascii): Uncompress the compressed values.
893 (sub_char_table_ref): New arg is_uniprop. Callers changed.
894 Uncompress the compressed values.
ac389d0c 895 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
896 (char_table_ref_and_range): Uncompress the compressed values.
897 (sub_char_table_set): New arg is_uniprop. Callers changed.
898 Uncompress the compressed values.
899 (sub_char_table_set_range): Args changed. Callers changed.
900 (char_table_set_range): Adjuted for the above change.
901 (map_sub_char_table): Delete args default_val and parent. Add arg
902 top. Give decoded values to a Lisp function.
903 (map_char_table): Adjusted for the above change. Give decoded
904 values to a Lisp function. Gcpro more variables.
905 (uniprop_table_uncompress)
906 (uniprop_decode_value_run_length): New functions.
907 (uniprop_decoder, uniprop_decoder_count): New variables.
908 (uniprop_get_decoder, uniprop_encode_value_character)
909 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
910 New functions.
911 (uniprop_encoder, uniprop_encoder_count): New variables.
912 (uniprop_get_encoder, uniprop_table)
913 (Funicode_property_table_internal, Fget_unicode_property_internal)
914 (Fput_unicode_property_internal): New functions.
915 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
916 Sunicode_property_table_internal, Sget_unicode_property_internal,
917 and Sput_unicode_property_internal. Defvar_lisp
918 char-code-property-alist.
919
920 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
921 Vunicode_category_table.
922
923 * font.c (font_range): Adjusted for the change of
924 Vunicode_category_table.
925
76b397fb
DN
9262011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
927
928 * m/iris4d.h: Remove file, move contents ...
929 * s/irix6-5.h: ... here.
930
22b4128e
PE
9312011-07-06 Paul Eggert <eggert@cs.ucla.edu>
932
933 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
934 * alloc.c (mark_buffer):
935 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
936 (clone_per_buffer_values): Don't assume that
22b4128e
PE
937 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
938 This isn't true in general, and it's particularly not true
939 if Emacs is configured with --with-wide-int.
940 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
941 New macros, used in the buffer.c change.
942
869795d6
JD
9432011-07-05 Jan Djärv <jan.h.d@swipnet.se>
944
945 * xsettings.c: Use both GConf and GSettings if both are available.
946 (store_config_changed_event): Add comment.
947 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
948 (store_tool_bar_style_changed): New functions.
949 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
950 (struct xsettings): Move font inside HAVE_XFT.
951 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
952 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
953 Move inside HAVE_XFT.
954 (something_changed_gsettingsCB): Renamed from something_changedCB.
955 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
956 also.
957 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
958 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
959 (something_changed_gconfCB): Renamed from something_changedCB.
960 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
961 (parse_settings): Move check for font inside HAVE_XFT.
962 (read_settings, apply_xft_settings): Add comment.
963 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
964 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
965 call store_font_name_changed.
966 (xft_settings_event): Add comment.
967 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
968 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
969 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
970 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
971 (xsettings_initialize): Call init_gsettings last.
972 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
973 comment.
974
d8ed26bd
PE
9752011-07-05 Paul Eggert <eggert@cs.ucla.edu>
976
977 Random fixes. E.g., (random) never returned negative values.
978 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
979 subseconds part to the entropy, as that's a bit more random.
980 Prefer signed to unsigned, since the signedness doesn't matter and
981 in general we prefer signed. When given a limit, use a
982 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
983 latter isn't right if USE_2_TAGS_FOR_INTS.
984 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
985 not 0..VALMASK. Don't discard "excess" bits that random () returns.
986
cabf1cac
SM
9872011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
988
989 * textprop.c (text_property_stickiness):
990 Obey Vtext_property_default_nonsticky.
991 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
992 * w32fns.c (syms_of_w32fns):
993 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
994
6e9b2be9
PE
9952011-07-04 Paul Eggert <eggert@cs.ucla.edu>
996
997 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
998 This is more efficient than Ffile_directory_p and avoids a minor race.
999
90186c68
LMI
10002011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1001
7c301272
LMI
1002 * buffer.c (Foverlay_put): Say what the return value is
1003 (bug#7835).
1004
c4f2d8d4
LMI
1005 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1006 is a directory before asking whether to use the file name
1007 (bug#7564).
ad637907
LMI
1008 (barf_or_query_if_file_exists): Make the "File is a directory"
1009 error be more correct.
c4f2d8d4 1010
90186c68
LMI
1011 * fns.c (Frequire): Remove the mention of the .gz files, since
1012 that's installation-specific, but keep the mention of
1013 `get-load-suffixes'.
1014
da64016e
PE
10152011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1018 Report string overflow if the output is too long.
1019
7d47b580
JB
10202011-07-04 Juanma Barranquero <lekktu@gmail.com>
1021
a555cb87
JB
1022 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1023 (syms_of_gnutls): Remove duplicate DEFSYM for
1024 Qgnutls_bootprop_verify_hostname_error, an error for
1025 Qgnutls_bootprop_verify_error (which is no longer used).
1026
7d47b580
JB
1027 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1028 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1029 Also (re)move comments that are misplaced or no longer relevant.
1030
1e49bfab
LMI
10312011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1032
1033 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1034
1485f4c0
CY
10352011-07-03 Chong Yidong <cyd@stupidchicken.com>
1036
1037 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1038 and background color parameters if they have been changed.
1039
a9ab721e
LMI
10402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1041
1042 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1043
cf7cff57
PE
10442011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1045
2e13213d
PE
1046 * xsettings.c (SYSTEM_FONT): Define only when used.
1047 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1048
cf7cff57
PE
1049 * keymap.c (access_keymap_1): Now static.
1050
7a8e04f7
CY
10512011-07-02 Chong Yidong <cyd@stupidchicken.com>
1052
1053 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1054 leave any prefix arg for the up event (Bug#1586).
1055
61352f62
LMI
10562011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1057
69bb1ef7
LMI
1058 * lread.c (syms_of_lread): Mention single symbols defined by
1059 `defvar' or `defconst' (bug#7154).
1060
61352f62 1061 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1062 (Frequire): Mention get-load-suffixes.
61352f62 1063
28545e04
MR
10642011-07-02 Martin Rudalics <rudalics@gmx.at>
1065
1066 * window.h (window): Remove clone_number slot.
1067 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1068 Remove.
1069 (make_parent_window, make_window, saved_window)
1070 (Fset_window_configuration, save_window_save): Don't deal with
1071 clone numbers.
1072 * buffer.c (Qclone_number): Remove declaration.
1073 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1074
3349e122
SM
10752011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1076
1077 Add multiple inheritance to keymaps.
1078 * keymap.c (Fmake_composed_keymap): New function.
1079 (Fset_keymap_parent): Simplify.
1080 (fix_submap_inheritance): Remove.
1081 (access_keymap_1): New function extracted from access_keymap to handle
1082 embedded parents and handle lists of maps.
1083 (access_keymap): Use it.
1084 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1085 (Fcopy_keymap): Handle embedded parents.
1086 (Fcommand_remapping, define_as_prefix): Simplify.
1087 (Fkey_binding): Simplify.
1088 (syms_of_keymap): Move minibuffer-local-completion-map,
1089 minibuffer-local-filename-completion-map,
1090 minibuffer-local-must-match-map, and
1091 minibuffer-local-filename-must-match-map to Elisp.
1092 (syms_of_keymap): Defsubr make-composed-keymap.
1093 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1094 (parse_menu_item): Trivial simplification.
1095
3279eb87
GM
10962011-07-01 Glenn Morris <rgm@gnu.org>
1097
1098 * Makefile.in (SETTINGS_LIBS): Fix typo.
1099
4550efdf
KI
11002011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1101
1102 * coding.c (Fencode_coding_string): Record the last coding system
1103 used, as the function doc string says (bug#8738).
1104
0949d2b6
JD
11052011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1106
1107 * xsettings.c (store_monospaced_changed): Take new font as arg and
1108 check for change against current_mono_font.
1109 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1110 (emacs_settings_constructor, emacs_settings_get_property)
1111 (emacs_settings_set_property, emacs_settings_class_init)
1112 (emacs_settings_init, gsettings_obj): Remove.
1113 (something_changedCB): New function for HAVE_GSETTINGS.
1114 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1115 with value as argument.
1116 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1117 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1118 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1119 "changed".
1120
1121 * xgselect.c: Add defined (HAVE_GSETTINGS).
1122 (xgselect_initialize): Ditto.
1123
1124 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1125 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1126 xg_select.
1127
bbc6b304
PE
11282011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1129
1130 * eval.c (struct backtrace): Simplify and port the data structure.
1131 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1132 signed bit field, as this assumption is not portable and it makes
1133 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1134 "char debug_on_exit : 1" as this is not portable either; instead,
1135 use the portable "unsigned int debug_on_exit : 1". Remove unused
1136 member evalargs. Remove obsolete comments about cc bombing out.
1137
9851bfc5
JD
11382011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1139
51bb811f 1140 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1141 Let HAVE_GSETTINGS override HAVE_GCONF.
1142 (store_monospaced_changed): New function.
1143 (EMACS_SETTINGS): A new type derived from GObject to handle
1144 GSettings notifications.
1145 (emacs_settings_constructor, emacs_settings_get_property)
1146 (emacs_settings_set_property, emacs_settings_class_init):
1147 New functions.
1148 (gsettings_client, gsettings_obj): New variables.
1149 (GSETTINGS_SCHEMA): New define.
1150 (something_changedCB): Call store_monospaced_changed.
1151 (init_gsettings): New function.
1152 (xsettings_initialize): Call init_gsettings.
1153 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1154 to NULL.
1155
1156 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1157 GCONF_CFLAGS/LIBS.
1158
5386012d
MR
11592011-06-29 Martin Rudalics <rudalics@gmx.at>
1160
1161 * window.c (resize_root_window, grow_mini_window)
1162 (shrink_mini_window): Rename Qresize_root_window to
1163 Qwindow_resize_root_window and Qresize_root_window_vertically to
1164 Qwindow_resize_root_window_vertically.
1165
f13e0b08
PE
11662011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1167
1168 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1169
94515237
JB
11702011-06-27 Juanma Barranquero <lekktu@gmail.com>
1171
1172 * makefile.w32-in: Redesign dependencies so they reflect more
1173 clearly which files are directly included by each source file,
1174 and not through other includes.
1175
e43b6e43
MR
11762011-06-27 Martin Rudalics <rudalics@gmx.at>
1177
1178 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1179 (sort_overlays, overlay_strings): When an overlay's clone number
1180 matches the window's clone number process the overlay even if
1181 the overlay's window property doesn't match the current window.
1182
d68443dc
MR
1183 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1184 (Fwindow_hchild): Rename to Fwindow_left_child.
1185 (Fwindow_next): Rename to Fwindow_next_sibling.
1186 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1187 (resize_window_check): Rename to window_resize_check.
1188 (resize_window_apply): Rename to window_resize_apply.
1189 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1190 (Fdelete_other_windows_internal, resize_frame_windows)
1191 (Fsplit_window_internal, Fdelete_window_internal)
1192 (grow_mini_window, shrink_mini_window)
1193 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1194
c7e73be5
JD
11952011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1196
1197 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1198 (emacs_fixed_set_min_size): Remove.
1199 (emacs_fixed_new): Take frame as argument.
1200
1201 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1202 (_EmacsFixedPrivate): Remove minwidth/height.
1203 Add struct frame *f.
1204 (emacs_fixed_init): Initialize priv->f.
1205 (get_parent_class, emacs_fixed_set_min_size): Remove.
1206 (emacs_fixed_new): Set priv->f to argument.
1207 (emacs_fixed_get_preferred_width)
1208 (emacs_fixed_get_preferred_height): Use min_width/height from
1209 frames size_hint to set minimum and natural (Bug#8919).
1210 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1211 and use min_width/height from frames size_hint to set
1212 min_width/height (Bug#8919).
1213
1214 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1215 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1216 Fix indentation.
c7e73be5 1217
cf99dcf8
EZ
12182011-06-26 Eli Zaretskii <eliz@gnu.org>
1219
1220 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1221 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1222 called at ZV.
1223
029529ac
CY
12242011-06-26 Chong Yidong <cyd@stupidchicken.com>
1225
1226 * process.c (wait_reading_process_output): Bypass select if
1227 waiting for a cell while ignoring keyboard input, and input is
1228 pending. Suggested by Jan Djärv (Bug#8869).
1229
7a7ef429
PE
12302011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1231
1232 Use gnulib's dup2 module instead of rolling our own.
1233 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1234
11fdef7d 12352011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1236
1237 * dispnew.c (scrolling_window): Before scrolling, turn off a
1238 mouse-highlight in the window being scrolled.
1239
cd3520a4
JB
12402011-06-24 Juanma Barranquero <lekktu@gmail.com>
1241
1242 Move DEFSYM to lisp.h and use everywhere.
1243
1244 * character.h (DEFSYM): Move declaration...
1245 * lisp.h (DEFSYM): ...here.
1246
1247 * gnutls.c:
1248 * minibuf.c:
1249 * w32menu.c:
1250 * w32proc.c:
1251 * w32select.c: Don't include character.h.
1252
1253 * alloc.c (syms_of_alloc):
1254 * buffer.c (syms_of_buffer):
1255 * bytecode.c (syms_of_bytecode):
1256 * callint.c (syms_of_callint):
1257 * casefiddle.c (syms_of_casefiddle):
1258 * casetab.c (init_casetab_once):
1259 * category.c (init_category_once, syms_of_category):
1260 * ccl.c (syms_of_ccl):
1261 * cmds.c (syms_of_cmds):
1262 * composite.c (syms_of_composite):
1263 * dbusbind.c (syms_of_dbusbind):
1264 * dired.c (syms_of_dired):
1265 * dispnew.c (syms_of_display):
1266 * doc.c (syms_of_doc):
1267 * editfns.c (syms_of_editfns):
1268 * emacs.c (syms_of_emacs):
1269 * eval.c (syms_of_eval):
1270 * fileio.c (syms_of_fileio):
1271 * fns.c (syms_of_fns):
1272 * frame.c (syms_of_frame):
1273 * fringe.c (syms_of_fringe):
1274 * insdel.c (syms_of_insdel):
1275 * keymap.c (syms_of_keymap):
1276 * lread.c (init_obarray, syms_of_lread):
1277 * macros.c (syms_of_macros):
1278 * msdos.c (syms_of_msdos):
1279 * print.c (syms_of_print):
1280 * process.c (syms_of_process):
1281 * search.c (syms_of_search):
1282 * sound.c (syms_of_sound):
1283 * syntax.c (init_syntax_once, syms_of_syntax):
1284 * terminal.c (syms_of_terminal):
1285 * textprop.c (syms_of_textprop):
1286 * undo.c (syms_of_undo):
1287 * w32.c (globals_of_w32):
1288 * window.c (syms_of_window):
1289 * xdisp.c (syms_of_xdisp):
1290 * xfaces.c (syms_of_xfaces):
1291 * xfns.c (syms_of_xfns):
1292 * xmenu.c (syms_of_xmenu):
1293 * xsettings.c (syms_of_xsettings):
1294 * xterm.c (syms_of_xterm): Use DEFSYM.
1295
4228cf16
TZ
12962011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1297
cd3520a4 1298 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1299
7fcccf1e
PE
13002011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1301
7efb4e0e
PE
1302 Integer and buffer overflow fixes (Bug#8873).
1303
ff5844ad
PE
1304 * print.c (printchar, strout): Check for string overflow.
1305 (PRINTPREPARE, printchar, strout):
1306 Don't set size unless allocation succeeds.
1307
90532f02
PE
1308 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1309 for sizes. Check for string overflow more accurately.
1310 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1311
6d84508d
PE
1312 * macros.c: Integer and buffer overflow fixes.
1313 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1314 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1315 Use ptrdiff_t, not int, for sizes.
1316 Don't increment bufsize until after realloc succeeds.
1317 Check for size-calculation overflow.
1318 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1319
437b2cb4
PE
1320 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1321
8b9ac8b4
PE
1322 * lread.c: Integer overflow fixes.
1323 (read_integer): Radix is now EMACS_INT, not int,
1324 to improve quality of diagnostics for out-of-range radices.
1325 Calculate buffer size correctly for out-of-range radices.
1326 (read1): Check for integer overflow in radices, and in
1327 read-circle numbers.
82cb60d3
PE
1328 (read_escape): Avoid int overflow.
1329 (Fload, openp, read_buffer_size, read1)
1330 (substitute_object_recurse, read_vector, read_list, map_obarray):
1331 Use ptrdiff_t, not int, for sizes.
1332 (read1): Use EMACS_INT, not int, for sizes.
20270765 1333 Check for size overflow.
8b9ac8b4 1334
7fcccf1e
PE
1335 * image.c (cache_image): Check for size arithmetic overflow.
1336
bfbbd7e7
PE
1337 * lread.c: Integer overflow issues.
1338 (saved_doc_string_size, saved_doc_string_length)
1339 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1340 Now ptrdiff_t, not int.
1341 (read1): Don't assume doc string length fits in int. Check for
1342 out-of-range doc string lengths.
1343 (read_list): Don't assume file position fits in int.
39019e54 1344 (read_escape): Check for hex character overflow.
bfbbd7e7 1345
4e323265
LL
13462011-06-22 Leo Liu <sdl.web@gmail.com>
1347
1348 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1349 Move to minibuffer.el.
1350
85fece3e
PE
13512011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1352
20b84ce9 1353 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1354 The following patches are for when GLYPH_DEBUG && !XASSERT.
1355 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1356 * dispnew.c (flush_stdout):
1357 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1358 Mark as externally visible.
1359 * dispnew.c (check_window_matrix_pointers): Now static.
1360 * dispnew.c (window_to_frame_vpos):
1361 * xfns.c (unwind_create_frame):
1362 * xterm.c (x_check_font): Remove unused local.
1363 * scroll.c (CHECK_BOUNDS):
1364 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1365 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1366 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1367 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1368 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1369 Now static.
1370 (debug_method_add): Use va_list and vsprintf rather than relying
1371 on undefined behavior with wrong number of arguments.
1372 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1373 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1374 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1375 since we're not interested in debugging glyphs with old libraries.
1376 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1377 GCC 4.6.0's static checking.
1378
0766b489
PE
13792011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1380
31fd4b32
PE
1381 Integer overflow and signedness fixes (Bug#8873).
1382 A few related buffer overrun fixes, too.
1383
b79e8648
PE
1384 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1385
0766b489
PE
1386 * dispextern.h (struct face.stipple):
1387 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1388 (x_bitmap_mask, x_allocate_bitmap_record)
1389 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1390 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1391 (x_create_bitmap_from_xpm_data):
1392 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1393 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1394 (.bitmaps_last):
1395 * xfaces.c (load_pixmap):
1396 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1397 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1398 (.bitmaps_last, struct x_output.icon_bitmap):
1399 Use ptrdiff_t, not int, for bitmap indexes.
1400 (x_allocate_bitmap_record): Check for size overflow.
1401 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1402
b081724f
PE
1403 Use ptrdiff_t, not int, for overlay counts.
1404 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1405 * editfns.c (overlays_around, get_pos_property):
1406 * textprop.c (get_char_property_and_overlay):
1407 * xdisp.c (next_overlay_change, note_mouse_highlight):
1408 * xfaces.c (face_at_buffer_position):
21514da7
PE
1409 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1410 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1411 (Fnext_overlay_change, Fprevious_overlay_change)
1412 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1413 Use ptrdiff_t, not int, for sizes.
21514da7 1414 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1415
3de73e5e
PE
1416 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1417
2606c57b
PE
1418 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1419 (x_session_initialize): Do not assume string length fits in int.
1420
aaafe47a
PE
1421 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1422 This is unlikely, but can occur if DPI is outlandish.
1423
2674ddc8 1424 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1425 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1426
28154962
PE
1427 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1428 * xrdb.c (magic_file_p, search_magic_path):
1429 Omit last arg SUFFIX; it was always 0. All callers changed.
1430 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1431
7de51af5
PE
1432 * xfont.c (xfont_match): Avoid need for strlen.
1433
25ed6cc3
PE
1434 * xfns.c: Don't assume strlen fits in int.
1435 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1436
4eab31dd
PE
1437 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1438 not unsigned long, as we prefer signed integers. All callers changed.
1439 Detect integer overflow in repeat count.
1440 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1441 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1442
171e2a58
PE
1443 * termcap.c: Don't assume sizes fit in int and never overflow.
1444 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1445 (gobble_line): Check for size-calculation overflow.
1446
ad39faca 1447 * minibuf.c (Fread_buffer):
6e5bb2dc 1448 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1449 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1450 Don't assume string length fits in int.
1451
52c61c22 1452 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1453 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1454
b5b8c9e5
PE
1455 * font.c: Don't assume string length fits in int.
1456 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1457 Use ptrdiff_t, not int.
ccd6111c
PE
1458 (font_intern_prop): Don't assume string length fits in int.
1459 Don't assume integer property fits in fixnum.
1460 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1461
882f0d81 1462 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1463 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1464 Reformulate so as not to need the command string.
1465 Invoke gzip -cd rather than gunzip, as it's more portable.
1466 (lock_info_type, lock_file_1, lock_file):
1467 Don't assume pid_t and time_t fit in unsigned long.
1468 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1469 (current_lock_owner): Prefer signed type for sizes.
1470 Use memcpy, not strncpy, where memcpy is what is really wanted.
1471 Don't assume (via atoi) that time_t and pid_t fit in int.
1472 Check for time_t and/or pid_t out of range, e.g., via a network share.
1473 Don't alloca where an auto var works fine.
1474
93f4cf88
PE
1475 * fileio.c: Fix some integer overflow issues.
1476 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1477 Don't assume string length fits in int.
1478 (directory_file_name): Don't assume string length fits in long.
1479 (make_temp_name): Don't assume pid fits in int, or that its print
1480 length is less than 20.
1481
f3e92b69
PE
1482 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1483
1bfdaf10
PE
1484 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1485
35016e9a
PE
1486 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1487
3d1e65a1
PE
1488 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1489 We prefer signed integers, even for size calculations.
1490
0b963a93
PE
1491 * emacs.c: Don't assume string length fits in 'int'.
1492 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1493 (main): Don't invoke strlen when not needed.
1494
573f4b54
PE
1495 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1496 (XD_DEBUG_MESSAGE): Don't waste a byte.
1497
989f33ba
PE
1498 * callproc.c (getenv_internal_1, getenv_internal)
1499 (Fgetenv_internal):
965d34eb
PE
1500 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1501
e4d29b33
PE
1502 * lread.c (invalid_syntax): Omit length argument.
1503 All uses changed. This doesn't fix a bug, but it simplifies the
1504 code away from its former Hollerith-constant appearance, and it's
1505 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1506 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1507
eb49b136
PE
1508 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1509 This didn't break anything, but it didn't help either.
1510 It's confusing to put a bogus integer in a place where the actual
1511 value does not matter.
9f62aeb1 1512 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1513 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1514
15375a22
PE
1515 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1516 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1517 implementation.
b61cc01c
PE
1518 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1519 We prefer signed types, and the value cannot exceed the EMACS_INT
1520 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1521 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1522 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1523 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1524
53b2623d
PE
1525 * indent.c (sane_tab_width): New function.
1526 (current_column, scan_for_column, Findent_to, position_indentation)
1527 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1528 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1529
51cab52b 1530 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1531
f2ed8a70
PE
1532 * lisp.h (lint_assume): New macro.
1533 * composite.c (composition_gstring_put_cache):
1534 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1535
abe80cc6
PE
1536 * editfns.c, insdel.c:
1537 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1538
b02c740e
PE
1539 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1540
ebc96716
PE
1541 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1542
b4e50fa0 1543 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1544 Use much-faster test for byte-length change.
311d5d7c 1545 Don't assume string byte-length fits in 'int'.
a4cf38e4 1546 Check that character arg fits in 'int'.
85461888 1547 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1548
c0c1ee9f
PE
1549 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1550
a498d7f4
PE
1551 * fns.c (concat): Catch string overflow earlier.
1552 Do not rely on integer wraparound.
1553
51cab52b
PE
1554 * dispextern.h (struct it.overlay_strings_charpos)
1555 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1556 * xdisp.c (forward_to_next_line_start)
1557 (back_to_previous_visible_line_start)
1558 (reseat_at_next_visible_line_start, next_element_from_buffer):
1559 Don't arbitrarily truncate the value of 'selective' to int.
1560
76031fad
PE
1561 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1562
5eb55db9
PE
1563 * composite.c: Don't truncate sizes to 'int'.
1564 (composition_gstring_p, composition_reseat_it)
1565 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1566 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1567 not EMACS_UINT, for indexes.
5eb55db9 1568
0703a717
PE
1569 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1570
d6202519
PE
1571 * buffer.c: Include <verify.h>.
1572 (struct sortvec.priority, struct sortstr.priority):
8961a454 1573 Now EMACS_INT, not int.
c20998a7 1574 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1575 (struct sortstr.size, record_overlay_string)
1576 (struct sortstrlist.size, struct sortlist.used):
1577 Don't truncate size to int.
1578 (record_overlay_string): Check for size-calculation overflow.
d6202519 1579 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1580
d5a19415
JM
15812011-06-22 Jim Meyering <meyering@redhat.com>
1582
029529ac 1583 Don't leak an XBM-image-sized buffer
d5a19415
JM
1584 * image.c (xbm_load): Free the image buffer after using it.
1585
a9041e6c
PE
15862011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 Port to Sun C.
1589 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1590 that Sun C diagnosed.
1591 * fns.c (secure_hash): Fix pointer signedness issue.
1592 * intervals.c (static_offset_intervals): New function.
1593 (offset_intervals): Use it.
1594
7f3f739f
LL
15952011-06-21 Leo Liu <sdl.web@gmail.com>
1596
1597 * deps.mk (fns.o):
1598 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1599 sha512.h.
1600
1601 * fns.c (secure_hash): Rename from crypto_hash_function and change
1602 the first arg to accept symbols.
5b66d427 1603 (Fsecure_hash): New primitive.
7f3f739f
LL
1604 (syms_of_fns): New symbols.
1605
76147d94
DD
16062011-06-20 Deniz Dogan <deniz@dogan.se>
1607
1608 * process.c (Fset_process_buffer): Clarify return value in
1609 docstring.
1610
7d7d0045
CY
16112011-06-18 Chong Yidong <cyd@stupidchicken.com>
1612
1613 * dispnew.c (add_window_display_history): Use BVAR.
1614
1615 * xdisp.c (debug_method_add): Use BVAR.
1616 (check_window_end, dump_glyph_matrix, dump_glyph)
1617 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1618
1619 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1620 Likewise.
1621
1622 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1623 check till after the cache is created in init_frame_faces.
1624
ff2bc410
SM
16252011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1626
1627 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1628
28177add
PE
16292011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1630
dd3482fe
PE
1631 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1632 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1633 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1634
393d71f3 1635 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1636 * fileio.c (Finsert_file_contents):
1637 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1638 Remove the old (too-loose) buffer overflow checks.
1639 They weren't needed, since make_gap checks for buffer overflow.
1640 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1641 The old code merely checked for Emacs fixnum overflow, and relied
1642 on undefined (wraparound) behavior. The new code avoids undefined
1643 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1644
2e6813b0 1645 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1646 Tune. Don't use wider integers than needed. Don't use alloca.
1647 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1648
599a9e4f
PE
1649 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1650
99561444
PE
1651 * insdel.c, lisp.h (buffer_overflow): New function.
1652 (insert_from_buffer_1, replace_range, replace_range_2):
1653 * insdel.c (make_gap_larger):
1654 * editfns.c (Finsert_char):
1655 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1656
28177add
PE
1657 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1658
e69dafad
PE
16592011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1660
a7af7fde 1661 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1662
b1c46f02
PE
1663 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1664 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1665
e69dafad
PE
1666 * fileio.c: Don't assume EMACS_INT fits in off_t.
1667 (emacs_lseek): New static function.
1668 (Finsert_file_contents, Fwrite_region): Use it.
1669 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1670
566684ea
PE
1671 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1672
e6966cd6
PE
1673 * fns.c: Don't overflow int when computing a list length.
1674 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1675 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1676 truncation on 64-bit hosts. Check for QUIT every
1677 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1678 faster and is responsive enough.
1679 (Flength): Report an error instead of overflowing an integer.
1680 (Fsafe_length): Return a float if the value is not representable
1681 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1682 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1683 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1684
dd0b0efb
PE
1685 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1686 (header_size, word_size): New constants.
1687 (allocate_vectorlike): Don't check size overflow here.
1688 (allocate_vector): Check it here instead, since this is the only
1689 caller of allocate_vectorlike that could cause overflow.
1690 Check that the new vector's length is representable as a fixnum.
1691
86fe5cfe
PE
1692 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1693 The previous code was bogus. For example, next_almost_prime (32)
1694 returned 39, which is undesirable as it is a multiple of 3; and
1695 next_almost_prime (24) returned 25, which is a multiple of 5 so
1696 why was the code bothering to check for multiples of 7?
1697
80e88859
PE
1698 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1699
4a2f0ad6
PE
1700 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1701
f66c7cf8
PE
1702 Variadic C functions now count arguments with ptrdiff_t.
1703 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1704 Back then I didn't know that the Emacs coding style prefers signed int.
1705 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1706 were being counted with int, which may truncate counts on 64-bit
1707 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1708 * lisp.h (struct Lisp_Subr.function.aMANY)
1709 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1710 Arg counts are now ptrdiff_t, not size_t.
1711 All variadic functions and their callers changed accordingly.
1712 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1713 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1714 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1715 * callint.c (Fcall_interactively): Check arg count for overflow,
1716 to avoid potential buffer overrun. Use signed char, not 'int',
1717 for 'varies' array, so that we needn't bother to check its size
1718 calculation for overflow.
1719 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1720 * eval.c (apply_lambda):
1721 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1722 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1723 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1724
a1759b76
PE
1725 * callint.c (Fcall_interactively): Don't use index var as event count.
1726
d96be9fc
PE
1727 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1728 * mem-limits.h (SIZE): Remove; no longer used.
1729
a690a978 1730 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1731
578c21e6
PE
1732 Remove unnecessary casts.
1733 * xterm.c (x_term_init):
1734 * xfns.c (x_set_border_pixel):
1735 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1736 These aren't needed now that we assume ANSI C.
1737
96f53c6c
PE
1738 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1739 It's more likely to cause problems (due to unsigned overflow)
1740 than to cure them.
1741
83c77d31
PE
1742 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1743
ee2079f1
PE
1744 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1745
6da65536
PE
1746 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1747
7147c4a4
PE
1748 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1749
193e32d9
PE
1750 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1751
e5533da6
PE
1752 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1753
9910e595
PE
1754 GLYPH_CODE_FACE returns EMACS_INT, not int.
1755 * dispextern.h (merge_faces):
1756 * xfaces.c (merge_faces):
01103c44
PE
1757 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1758 Don't assume EMACS_INT fits in int.
9910e595 1759
2638320e
PE
1760 * character.h (CHAR_VALID_P): Remove unused parameter.
1761 * fontset.c, lisp.h, xdisp.c: All uses changed.
1762
045eb8d9
PE
1763 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1764
c1f134b5
PE
1765 * fns.c (concat): Minor tuning based on overflow analysis.
1766 This doesn't fix any bugs. Use int to hold character, instead
1767 of constantly refetching from Emacs object. Use XFASTINT, not
1768 XINT, for value known to be a character. Don't bother comparing
1769 a single byte to 0400, as it's always less.
1770
395fcb93 1771 * floatfns.c (Fexpt):
327eeec8
PE
1772 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1773
abbd3d23
PE
1774 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1775 for characters.
1776
684a03ef
PE
1777 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1778
0fed43f3
PE
1779 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1780 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1781 incorrectly succeed when S was a string, because 4294967386 was
1782 truncated before it was used.
1783
8fd02eb7
PE
1784 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1785 Otherwise, an out-of-range integer could cause undefined behavior
1786 on a 64-bit host.
1787
f8c86b69
PE
1788 * composite.c: Use int, not EMACS_INT, for characters.
1789 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1790 EMACS_INT, for values that are known to be in character range.
1791 This doesn't fix any bugs but is the usual style inside Emacs and
1792 may generate better code on 32-bit machines.
1793
34206dd2
PE
1794 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1795 This is for reasons similar to the recent CHAR_STRING fix.
1796 * charset.c (Fencode_char): Check that character arg is actually
1797 a character. Pass an int to ENCODE_CHAR.
1798 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1799 wider than 'int', as a compile-time check to prevent future regressions
1800 in this area.
1801
c5958d4c 1802 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1803
1804 Make sure a 64-bit char is never passed to CHAR_STRING.
1805 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1806 by silently ignoring the top 32 bits, allowing some values
1807 that were far too large to be valid characters.
1808 * character.h: Include <verify.h>.
1809 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1810 arguments are no wider than unsigned, as a compile-time check
1811 to prevent future regressions in this area.
1812 * data.c (Faset):
01103c44 1813 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1814 (Fsubst_char_in_region):
1815 * fns.c (concat):
1816 * xdisp.c (decode_mode_spec_coding):
1817 Adjust to CHAR_STRING's new requirement.
1818 * editfns.c (Finsert_char, Fsubst_char_in_region):
1819 * fns.c (concat): Check that character args are actually
1820 characters. Without this test, these functions did the wrong
1821 thing with wildly out-of-range values on 64-bit hosts.
1822
d37ca623
PE
1823 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1824 These casts should not be needed on 32-bit hosts, either.
1825 * keyboard.c (read_char):
1826 * lread.c (Fload): Remove casts to unsigned.
1827
ea204efb
PE
1828 * lisp.h (UNSIGNED_CMP): New macro.
1829 This fixes comparison bugs on 64-bit hosts.
1830 (ASCII_CHAR_P): Use it.
1831 * casefiddle.c (casify_object):
01103c44 1832 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1833 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1834 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1835 * dispextern.h (FACE_FROM_ID):
1836 * keyboard.c (read_char): Use UNSIGNED_CMP.
1837
41cb286c
PE
1838 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1839 not to EMACS_INT, to avoid GCC warning.
1840
4a1b9832
PE
1841 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1842
55daad71
PE
1843 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1844 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1845 isn't needed on 32-bit machines.
8f95c75c 1846
01103c44
PE
1847 * buffer.c (Fgenerate_new_buffer_name):
1848 Use EMACS_INT for count, not int.
0ceccced 1849 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1850
1851 * data.c (Qcompiled_function): Now static.
1852
c6f072e7
PE
1853 * window.c (window_body_lines): Now static.
1854
20ce5912
PE
1855 * image.c (gif_load): Rename local to avoid shadowing.
1856
9c4c5f81
PE
1857 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1858 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1859 * alloc.c (make_save_value): Integer argument is now of type
1860 ptrdiff_t, not int.
1861 (mark_object): Use ptrdiff_t, not int.
1862 * lisp.h (pD): New macro.
1863 * print.c (print_object): Use it.
1864
c0c5c8ae
PE
1865 * alloc.c: Use EMACS_INT, not int, to count objects.
1866 (total_conses, total_markers, total_symbols, total_vector_size)
1867 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1868 (total_free_floats, total_floats, total_free_intervals)
1869 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1870 Now EMACS_INT, not int. All uses changed.
1871 (Fgarbage_collect): Compute overall total using a double, so that
1872 integer overflow is less likely to be a problem. Check for overflow
1873 when converting back to an integer.
5a25e253
PE
1874 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1875 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1876 These were 'int' variables that could overflow on 64-bit hosts;
1877 they were never used, so remove them instead of repairing them.
211a0b2a 1878 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1879 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1880 Previously, this ceilinged at INT_MAX, but that doesn't work on
1881 64-bit machines.
e46bb31a 1882 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1883
c78baabf 1884 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1885 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1886 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1887 when a (possibly-narrower) signed value would do just as well.
1888 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1889
c9d624c6
PE
1890 * alloc.c: Catch some string size overflows that we were missing.
1891 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1892 for convenience in STRING_BYTES_MAX.
1893 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1894 The definition here is exact; the one in lisp.h was approximate.
1895 (allocate_string_data): Check for string overflow. This catches
1896 some instances we weren't catching before. Also, it catches
1897 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1898 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1899 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1900
c9d624c6
PE
1901 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1902 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1903 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1904
353032ce
PE
1905 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1906
2bccce07
PE
1907 * alloc.c (Fmake_string): Check for out-of-range init.
1908
0ac30604
SM
19092011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1910
1911 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1912
c195f2de
JD
19132011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1914
1915 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1916 xg_get_default_scrollbar_width.
1917
1918 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1919 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1920 (style_changed_cb): Call update_theme_scrollbar_width and call
1921 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1922 all frames (Bug#8505).
1923 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1924 Call gtk_window_set_resizable if HAVE_GTK3.
1925 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1926 and height if HAVE_GTK3 (Bug#8505).
1927 (scroll_bar_width_for_theme): New variable.
1928 (update_theme_scrollbar_width): New function.
1929 (xg_get_default_scrollbar_width): Move code to
1930 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1931 (xg_initialize): Call update_theme_scrollbar_width.
1932
1933 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1934
1935 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1936
e10ac9f1
MR
19372011-06-12 Martin Rudalics <rudalics@gmx.at>
1938
1939 * frame.c (make_frame): Call other_buffer_safely instead of
1940 other_buffer.
1941
1942 * window.c (temp_output_buffer_show): Call display_buffer with
1943 second argument Vtemp_buffer_show_specifiers and reset latter
1944 immediately after the call.
1945 (Vtemp_buffer_show_specifiers): New variable.
1946 (auto_window_vscroll_p, next_screen_context_lines)
1947 (Vscroll_preserve_screen_position): Remove leading asterisks from
1948 doc-strings.
1949
2d3c217e 19502011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1951
7b7f97e8 1952 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1953 * buffer.c (Qclone_number): Remove for now, as it's unused.
1954 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1955 (record_buffer): Remove unused local.
1956 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1957 (set_frame_buffer_list): Remove; unused.
1958 * frame.h (other_visible_frames): Remove decl.
1959 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1960 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1961 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1962 if HAVE_GPM.
1963 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1964 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1965 Define only if HAVE_GPM.
1966 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1967 (update_hints_inhibit): Remove; never set. All uses removed.
1968 * widgetprv.h (emacsFrameClassRec): Remove decl.
1969 * window.c (delete_deletable_window): Now returns void, since it
1970 wasn't returning anything.
1971 (compare_window_configurations): Remove unused locals.
1972 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1973 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1974 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1975 the same widths as pointers. This follows up on the 2011-05-06 patch.
1976 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1977 * xterm.h: Likewise.
1978 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1979
1384b89e
JB
19802011-06-12 Juanma Barranquero <lekktu@gmail.com>
1981
1982 * makefile.w32-in: Update dependencies.
1983 (LISP_H): Add lib/intprops.h.
1984
1100a63c
CY
19852011-06-11 Chong Yidong <cyd@stupidchicken.com>
1986
1987 * image.c (gif_load): Add animation frame delay to the metadata.
1988 (syms_of_image): Use DEFSYM. New symbol `delay'.
1989
6198ccd0
MR
19902011-06-11 Martin Rudalics <rudalics@gmx.at>
1991
1992 * window.c (delete_deletable_window): Re-add.
1993 (Fset_window_configuration): Rewrite to handle dead buffers and
1994 consequently deletable windows.
1995 (window_tree, Fwindow_tree): Remove. Supply functionality in
1996 window.el.
1997 (compare_window_configurations): Simplify code.
1998
b6e3633c
AS
19992011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2000
1ab0dee5
AS
2001 * image.c (imagemagick_load_image): Fix type mismatch.
2002 (Fimagemagick_types): Likewise.
2003
b6e3633c
AS
2004 * window.h (replace_buffer_in_windows): Declare.
2005
9397e56f
MR
20062011-06-11 Martin Rudalics <rudalics@gmx.at>
2007
2008 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2009 Qclone_number. Remove external declaration of Qdelete_window.
2010 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2011 code.
2012 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
2013 Qbuffer_list_update_hook if allowed.
2014 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2015 buffer list implementation.
2016 (other_buffer_safely): New function.
2017 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2018 calls to replace_buffer_in_windows and
2019 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2020 if allowed.
2021 (record_buffer): Inhibit quitting and rewrite using quittable
2022 functions. Run Qbuffer_list_update_hook if allowed.
2023 (Frecord_buffer, Funrecord_buffer): New functions.
2024 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
2025 switch-to-buffer to window.el.
2026 (bury-buffer): Move to window.el.
2027 (Vbuffer_list_update_hook): New variable.
2028
2029 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2030 section.
2031
2032 * window.h (resize_frame_windows): Move up in code.
2033 (Fwindow_frame): Remove EXFUN.
2034 (replace_buffer_in_all_windows): Remove prototype.
2035 (replace_buffer_in_windows_safely): Add prototype.
2036
2037 * window.c: Declare Qdelete_window static again. Move down
2038 declaration of select_count.
2039 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2040 (Fother_window): Move to window.el.
2041 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2042 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2043 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2044 window.el.
2045 (replace_buffer_in_windows): Implement by calling
2046 Qreplace_buffer_in_windows.
2047 (replace_buffer_in_all_windows): Remove with some functionality
2048 moved into replace_buffer_in_windows_safely.
2049 (replace_buffer_in_windows_safely): New function.
2050 (select_window_norecord, select_frame_norecord): Move in front
2051 of run_window_configuration_change_hook. Remove now obsolete
2052 declarations.
2053 (Fset_window_buffer): Rewrite doc-string. Call
2054 Qrecord_window_buffer.
2055 (keys_of_window): Move binding for other-window to window.el.
2056
b50691aa
CY
20572011-06-11 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * dispextern.h (struct image): Replace data member, whose int_val
2060 and ptr_val fields were not used by anything, with a single
2061 lisp_val object.
2062
2063 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2064 (gif_clear_image, gif_load, imagemagick_load_image)
2065 (gs_clear_image, gs_load): Callers changed.
2066
3f754b86
PE
20672011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2068
cca69397
PE
2069 * buffer.h: Include <time.h>, for time_t.
2070 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2071
109e28d0
PE
2072 Fix minor problems found by static checking.
2073
60737f02
PE
2074 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2075
4b66faf3
PE
2076 Make identifiers static if they are not used in other modules.
2077 * data.c (Qcompiled_function, Qframe, Qvector):
2078 * image.c (QimageMagick, Qsvg):
2079 * minibuf.c (Qmetadata):
2080 * window.c (resize_window_check, resize_root_window): Now static.
2081 * window.h (resize_window_check, resize_root_window): Remove decls.
2082
109e28d0
PE
2083 * window.c (window_deletion_count, delete_deletable_window):
2084 Remove; unused.
46a4ce9e
PE
2085 (window_body_lines): Now static.
2086 (Fdelete_other_windows_internal): Mark vars as initialized.
2087 Make sure 'resize_failed' is initialized.
2088 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2089 (resize_window_apply): Remove unused local.
2090 * window.h (delete_deletable_window): Remove decl.
2091
109e28d0 2092 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2093 (imagemagick_load_image): Fix pointer signedness problem by changing
2094 last arg from unsigned char * to char *. All uses changed.
2095 Also, fix a local for similar reasons.
2096 Remove unused locals. Remove locals to avoid shadowing.
2097 (fn_rsvg_handle_free): Remove; unused.
2098 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2099 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2100
3f754b86
PE
2101 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2102
2547adb1
CY
21032011-06-10 Chong Yidong <cyd@stupidchicken.com>
2104
2105 * image.c (gif_load): Fix omitted cast error introduced by
2106 2011-06-06 change.
2107
2c8e37d4
MR
21082011-06-10 Martin Rudalics <rudalics@gmx.at>
2109
2110 * window.h (resize_proportionally, orig_total_lines)
2111 (orig_top_line): Remove from window structure.
2112 (set_window_height, set_window_width, change_window_heights)
2113 (Fdelete_window): Remove prototypes.
2114 (resize_frame_windows): Remove duplicate declaration.
2115
440a42e3
EZ
21162011-06-10 Eli Zaretskii <eliz@gnu.org>
2117
2118 * window.h (resize_frame_windows, resize_window_check)
2119 (delete_deletable_window, resize_root_window)
2120 (resize_frame_windows): Declare prototypes.
2121
2122 * window.c (resize_window_apply): Make definition be "static" to
2123 match the prototype.
2124
562dd5e9
MR
21252011-06-10 Martin Rudalics <rudalics@gmx.at>
2126
2127 * window.c: Remove declarations of Qwindow_size_fixed,
2128 window_min_size_1, window_min_size_2, window_min_size,
2129 size_window, window_fixed_size_p, enlarge_window, delete_window.
2130 Remove static from declaration of Qdelete_window, it's
2131 temporarily needed by Fbury_buffer.
2132 (replace_window): Don't assign orig_top_line and
2133 orig_total_lines.
2134 (Fdelete_window, delete_window): Remove. Window deletion is
2135 handled by window.el.
2136 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2137 Fdelete_window calls with calls to Qdelete_window.
2138 (Fdelete_other_windows): Remove. Deleting other windows is
2139 handled by window.el.
2140 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2141 handled in window.el.
2142 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2143 Window minimum sizes are handled in window.el.
2144 (shrink_windows, size_window, set_window_height)
2145 (set_window_width, change_window_heights, window_height)
2146 (window_width, CURBEG, CURSIZE, enlarge_window)
2147 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2148 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2149 handled in window.el.
2150 (make_dummy_parent): Rename to make_parent_window and give it a
2151 second argument horflag.
2152 (make_window): Don't set resize_proportionally any more.
2153 (Fsplit_window): Remove. Windows are split in window.el.
2154 (save_restore_action, save_restore_orig_size)
2155 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2156 Resize mini windows in window.el.
2157 (grow_mini_window, shrink_mini_window): Implement by calling
2158 Qresize_root_window_vertically, resize_window_check and
2159 resize_window_apply.
2160 (saved_window, Fset_window_configuration, save_window_save): Do
2161 not handle orig_top_line, orig_total_lines, and
2162 resize_proportionally.
2163 (window_min_height, window_min_width): Move to window.el.
2164 (keys_of_window): Move bindings for delete-other-windows,
2165 split-window, delete-window and enlarge-window to window.el.
2166
2167 * buffer.c: Temporarily extern Qdelete_window.
2168 (Fbury_buffer): Temporarily call Qdelete_window instead of
2169 Fdelete_window (Fbury_buffer will move to window.el soon).
2170
2171 * frame.c (set_menu_bar_lines_1): Remove code handling
2172 orig_top_line and orig_total_lines.
2173
2174 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2175 set_window_height but set heights directly.
2176 (change_frame_size_1): Use resize_frame_windows.
2177
2178 * xdisp.c (init_xdisp): Don't use set_window_height but set
2179 heights directly.
2180
2181 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2182 resize_frame_windows instead of change_window_heights and run
2183 run_window_configuration_change_hook.
2184
2185 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2186 instead of change_window_heights and run
2187 run_window_configuration_change_hook.
2188
1a13852e
MR
21892011-06-09 Martin Rudalics <rudalics@gmx.at>
2190
2191 * window.c (replace_window): Rename second argument REPLACEMENT to
2192 NEW. New third argument SETFLAG. Rewrite.
2193 (delete_window, make_dummy_parent): Call replace_window with
2194 third argument 1.
2195 (window_list_1): Move down in code.
2196 (run_window_configuration_change_hook): Move set_buffer part
2197 before select_frame_norecord part in order to unwind correctly.
2198 Rename count1 to count.
2199 (recombine_windows, delete_deletable_window, resize_root_window)
2200 (Fdelete_other_windows_internal)
2201 (Frun_window_configuration_change_hook, make_parent_window)
2202 (resize_window_check, resize_window_apply, Fresize_window_apply)
2203 (resize_frame_windows, Fsplit_window_internal)
2204 (Fdelete_window_internal, Fresize_mini_window_internal): New
2205 functions.
2206 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2207
f3d1777e
MR
22082011-06-08 Martin Rudalics <rudalics@gmx.at>
2209
496e208e
MR
2210 * window.h (window): Add some new members to window structure -
2211 normal_lines, normal_cols, new_total, new_normal, clone_number,
2212 splits, nest, prev_buffers, next_buffers.
2213 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2214 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2215
f3d1777e
MR
2216 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2217 Remove.
496e208e
MR
2218 (make_dummy_parent): Set new members of windows structure.
2219 (make_window): Move down in code. Handle new members of window
2220 structure.
2221 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2222 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2223 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2224 (Fset_window_prev_buffers, Fwindow_next_buffers)
2225 (Fset_window_next_buffers, Fset_window_clone_number): New
2226 functions.
2227 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2228 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2229 Doc-string fixes.
2230 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2231 Argument WINDOW can be now internal window too.
2232 (Fwindow_use_time): Move up in code.
2233 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2234 Rewrite doc-string.
2235 (Fset_window_configuration, saved_window)
2236 (Fcurrent_window_configuration, save_window_save): Handle new
2237 members of window structure.
b9e809c2
MR
2238 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2239 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2240 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2241 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2242 Qget_mru_window, Qresize_root_window,
2243 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2244 Qauto_buffer_name; staticpro them.
f3d1777e 2245
abde8f8c
MR
22462011-06-07 Martin Rudalics <rudalics@gmx.at>
2247
2248 * window.c (Fwindow_total_size, Fwindow_left_column)
2249 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2250 (Fwindow_list_1): New functions.
2251 (window_box_text_cols): Replace with window_body_cols.
2252 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2253 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2254 (delete_window, Fset_window_configuration): Call
2255 delete_all_subwindows with window as argument.
2256 (delete_all_subwindows): Take a window as argument and not a
2257 structure. Rewrite.
190b47e6
MR
2258 (window_loop): Remove handling of GET_LRU_WINDOW and
2259 GET_LARGEST_WINDOW.
2260 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2261
2262 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2263 window_box_text_cols. delete_all_subwindows now takes a
2264 Lisp_Object as argument.
abde8f8c
MR
2265
2266 * indent.c (compute_motion, Fcompute_motion): Use
2267 window_body_cols instead of window_box_text_cols.
2268
fa8a67e6
MR
2269 * frame.c (delete_frame): Call delete_all_subwindows with root
2270 window as argument.
2271
a54e3482
DC
22722011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2273
2274 * fns.c (Fputhash): Document return value.
2275
60002bf5
CY
22762011-06-06 Chong Yidong <cyd@stupidchicken.com>
2277
2278 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2279
0c671da6 22802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2281
b862a52a 2282 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2283
be44ca6c
PE
2284 Check for overflow when converting integer to cons and back.
2285 * charset.c (Fdefine_charset_internal, Fdecode_char):
2286 Use cons_to_unsigned to catch overflow.
2287 (Fencode_char): Use INTEGER_TO_CONS.
2288 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2289 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2290 * data.c (long_to_cons, cons_to_long): Remove.
2291 (cons_to_unsigned, cons_to_signed): New functions.
2292 These signal an error for invalid or out-of-range values.
2293 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2294 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2295 * font.c (Ffont_variation_glyphs):
2296 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2297 * lisp.h: Include <intprops.h>.
2298 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2299 (cons_to_signed, cons_to_unsigned): New decls.
2300 (long_to_cons, cons_to_long): Remove decls.
2301 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2302 (Fprimitive_undo): Use CONS_TO_INTEGER.
2303 * xfns.c (Fx_window_property): Likewise.
2304 * xselect.c: Include <limits.h>.
2305 (x_own_selection, selection_data_to_lisp_data):
2306 Use INTEGER_TO_CONS.
2307 (x_handle_selection_request, x_handle_selection_clear)
2308 (x_get_foreign_selection, Fx_disown_selection_internal)
2309 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2310 (lisp_data_to_selection_data): Use cons_to_unsigned.
2311 (x_fill_property_data): Use cons_to_signed.
2312 Report values out of range.
2313
d1f3d2af
PE
2314 Check for buffer and string overflow more precisely.
2315 * buffer.h (BUF_BYTES_MAX): New macro.
2316 * lisp.h (STRING_BYTES_MAX): New macro.
2317 * alloc.c (Fmake_string):
2318 * character.c (string_escape_byte8):
2319 * coding.c (coding_alloc_by_realloc):
2320 * doprnt.c (doprnt):
2321 * editfns.c (Fformat):
2322 * eval.c (verror):
2323 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2324 since they may not be the same number.
2325 * editfns.c (Finsert_char):
2326 * fileio.c (Finsert_file_contents):
2327 Likewise for BUF_BYTES_MAX.
2328
dd52fcea
PE
2329 * image.c: Use ptrdiff_t, not int, for sizes.
2330 (slurp_file): Switch from int to ptrdiff_t.
2331 All uses changed.
2332 (slurp_file): Check that file size fits in both size_t (for
2333 malloc) and ptrdiff_t (for sanity and safety).
2334
7f9bbdbb
PE
2335 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2336 if b->modtime has its maximal value.
2337
dfe18f82
PE
2338 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2339
84acfcf0
PE
2340 Don't assume time_t can fit into int.
2341 * buffer.h (struct buffer.modtime): Now time_t, not int.
2342 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2343 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2344
ccd9a01a
PE
2345 Minor fixes for signed vs unsigned integers.
2346 * character.h (MAYBE_UNIFY_CHAR):
2347 * charset.c (maybe_unify_char):
2348 * keyboard.c (read_char, reorder_modifiers):
2349 XINT -> XFASTINT, since the integer must be nonnegative.
2350 * ftfont.c (ftfont_spec_pattern):
2351 * keymap.c (access_keymap, silly_event_symbol_error):
2352 XUINT -> XFASTINT, since the integer must be nonnegative.
2353 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2354 since it makes no difference and we prefer signed.
2355 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2356 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2357 nonnegative.
2358
d6d100dd
SM
23592011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2360
2361 * window.h (Fwindow_frame): Declare.
2362
2b6148e4
PE
23632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2364
2365 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2366 (SPARE_MEMORY): Always define.
2367 (LARGE_REQUEST): Remove.
2368 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2369
f230ecc9
MR
23702011-06-06 Martin Rudalics <rudalics@gmx.at>
2371
727e958e
MR
2372 * lisp.h: Move EXFUNS for Fframe_root_window,
2373 Fframe_first_window and Fset_frame_selected_window to window.h.
2374
2375 * window.h: Move EXFUNS for Fframe_root_window,
2376 Fframe_first_window and Fset_frame_selected_window here from
2377 lisp.h.
2378
2379 * frame.c (Fwindow_frame, Fframe_first_window)
2380 (Fframe_root_window, Fframe_selected_window)
2381 (Fset_frame_selected_window): Move to window.c.
2382 (Factive_minibuffer_window): Move to minibuf.c.
2383 (Fother_visible_frames_p): New function.
2384
2385 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2386
f230ecc9
MR
2387 * window.c (decode_window, decode_any_window): Move up in code.
2388 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2389 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2390 (Fwindow_buffer): Move up and rewrite doc-string.
2391 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2392 (Fwindow_prev): New functions.
727e958e
MR
2393 (Fwindow_frame): Move here from frame.c. Accept any window as
2394 argument.
2395 (Fframe_root_window, Fframe_first_window)
2396 (Fframe_selected_window): Move here from frame.c. Accept frame
2397 or arbitrary window as argument. Update doc-strings.
2398 (Fminibuffer_window): Move up in code.
2399 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2400 (Fset_frame_selected_window): Move here from frame.c.
2401 Marginal rewrite.
727e958e
MR
2402 (Fselected_window, select_window, Fselect_window): Move up in
2403 code. Minor doc-string fixes.
f230ecc9 2404
4d09bcf6
PE
24052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2406
2407 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2408 Do not assume that spare memory exists; that assumption is valid
2409 only if SYSTEM_MALLOC.
2410 (LARGE_REQUEST): New macro, so that the issue of large requests
2411 is separated from the issue of spare memory.
2412
810928a2
AS
24132011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2414
172418ad
AS
2415 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2416 format. (Bug#8806)
2417
43f862f7
AS
2418 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2419
810928a2
AS
2420 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2421 before statements.
2422
a059fe24
JD
24232011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2424
2425 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2426
2427 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2428
2429 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2430 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2431
989bf368
JB
24322011-06-05 Juanma Barranquero <lekktu@gmail.com>
2433
2434 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2435
4b80f674
CY
24362011-06-04 Chong Yidong <cyd@stupidchicken.com>
2437
2438 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2439 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2440 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2441 New error handlers.
4b80f674
CY
2442 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2443 Obey Vx_select_enable_clipboard_manager. Catch errors in
2444 x_clipboard_manager_save (Bug#8779).
2445 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2446 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2447
99a33b77 24482011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2449
2450 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2451
99a33b77 24522011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2453
2454 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2455 in the current matrix if keep_current_p is non-zero.
2456
8264569d
EZ
24572011-06-04 Eli Zaretskii <eliz@gnu.org>
2458
2459 * bidi.c (bidi_level_of_next_char): Fix last change.
2460
57f97249
EZ
24612011-06-03 Eli Zaretskii <eliz@gnu.org>
2462
fec2107c 2463 Support bidi reordering of text covered by display properties.
57f97249 2464
fec2107c
EZ
2465 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2466 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2467 (bidi_cache_search, bidi_cache_iterator_state)
2468 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2469 (bidi_level_of_next_char, bidi_move_to_visually_next):
2470 Support character positions inside a run of characters covered by a
fec2107c
EZ
2471 display string.
2472 (bidi_paragraph_init, bidi_resolve_explicit_1)
2473 (bidi_level_of_next_char): Call bidi_fetch_char and
2474 bidi_fetch_char_advance instead of FETCH_CHAR and
2475 FETCH_CHAR_ADVANCE.
2476 (bidi_init_it): Initialize new members.
2477 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2478 definitions.
2479 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2480 instead of using explicit *_CHAR codes.
d6d100dd
SM
2481 (bidi_resolve_explicit, bidi_resolve_weak):
2482 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2483 bidirectional text is supported only in multibyte buffers.
2484 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2485 it to initialize the frame_window_p member of struct bidi_it.
2486 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2487 (bidi_resolve_explicit, bidi_resolve_weak)
2488 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2489 bidi_it->nchars is non-positive.
2490 (bidi_level_of_next_char): Don't try to lookup the cache for the
2491 next/previous character if nothing is cached there yet, or if we
2492 were just reseat()'ed to a new position.
c40e2fb2 2493
0e14fe90
EZ
2494 * xdisp.c (set_cursor_from_row): Set start and stop points
2495 according to the row's direction when priming the loop that looks
2496 for the glyph on which to display cursor.
2497 (single_display_spec_intangible_p): Function deleted.
2498 (display_prop_intangible_p): Reimplement to call
2499 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2500 Accept 3 additional arguments needed by handle_display_spec.
2501 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2502 values: lists, `(when COND...)' forms, etc.
2503 (single_display_spec_string_p): Support property values that are
2504 lists with the argument STRING its top-level element.
2505 (display_prop_string_p): Fix the condition for processing a
2506 property that is a list to be consistent with handle_display_spec.
fec2107c 2507 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2508 last portion of handle_display_prop.
2509 (compute_display_string_pos): Accept additional argument
2510 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2511 value of a `display' property is a "replacing spec".
2512 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2513 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2514 the display property, but just return a value indicating whether
2515 the display property will replace the characters it covers.
2516 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2517 frame_window_p members of struct bidi_it.
d6d100dd
SM
2518 (compute_display_string_pos, compute_display_string_end):
2519 New functions.
fec2107c
EZ
2520 (push_it): Accept second argument POSITION, where pop_it should
2521 jump to continue iteration.
2522 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2523
fec2107c
EZ
2524 * keyboard.c (adjust_point_for_property): Adjust the call to
2525 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2526
2527 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2528 (bidi_init_it): Update prototypes.
2529 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2530 (compute_display_string_pos, compute_display_string_end):
2531 Declare prototypes.
fec2107c
EZ
2532 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2533 EMACS_INT.
fc6f18ce 2534
40087514 25352011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2536
57f53182
PE
2537 Malloc failure behavior now depends on size of allocation.
2538 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2539 * lisp.h: Change signatures accordingly.
2540 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2541 All callers changed. (Bug#8762)
2542
2543 * gnutls.c: Use Emacs's memory allocators.
2544 Without this change, the gnutls library would invoke malloc etc.
2545 directly, which causes problems on non-SYNC_INPUT hosts, and which
2546 runs afoul of improving memory_full behavior. (Bug#8761)
2547 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2548 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2549 xfree instead of the default malloc, realloc, free.
2550 (Fgnutls_boot): No need to check for memory allocation failure,
2551 since xmalloc does that for us.
2552
ac32cd99 2553 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2554 * category.c (hash_get_category_set):
2555 * ccl.c (ccl_driver):
2556 * charset.c (Fdefine_charset_internal):
2557 * charset.h (struct charset.hash_index):
2558 * composite.c (get_composition_id, gstring_lookup_cache)
2559 (composition_gstring_put_cache):
2560 * composite.h (struct composition.hash_index):
2561 * dispextern.h (struct image.hash):
2562 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2563 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2564 (hashfn_equal, hashfn_user_defined, make_hash_table)
2565 (maybe_resize_hash_table, hash_lookup, hash_put)
2566 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2567 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2568 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2569 * image.c (make_image, search_image_cache, lookup_image)
2570 (xpm_put_color_table_h):
2571 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2572 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2573 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2574 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2575 * alloc.c (allocate_vectorlike):
2576 Check for overflow in vector size calculations.
2577 * ccl.c (ccl_driver):
2578 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2579 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2580 need to be updated by these changes.
40087514
PE
2581 * fns.c (make_hash_table, maybe_resize_hash_table):
2582 Check for integer overflow with large hash tables.
0de4bb68
PE
2583 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2584 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2585 (SXHASH_REDUCE): New macro.
2586 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2587 Use it instead of discarding useful hash info with large hash values.
2588 (sxhash_float): New function.
2589 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2590 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2591 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2592 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2593 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2594 Adjust signatures to match updated version of code.
2595 (consing_since_gc): Now EMACS_INT, since a single hash table can
2596 use more than INT_MAX bytes.
2597
698d32e2
DN
25982011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2599
2600 Make it possible to build with GCC-4.6+ -O2 -flto.
2601
2602 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2603
fd6fa53f
SM
26042011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2605
2606 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2607 Call minibuffer-inactive-mode.
2608
864db017
JB
26092011-05-31 Juanma Barranquero <lekktu@gmail.com>
2610
2611 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2612 Update dependencies.
2613
2ad0baf4
DN
26142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2615
2616 * data.c (init_data): Remove code for UTS, this system is not
2617 supported anymore.
2618
4fcc2638
DN
26192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2620
2621 Don't force ./temacs to start in terminal mode.
2622
2623 * frame.c (make_initial_frame): Initialize faces in all cases, not
2624 only when CANNOT_DUMP is defined.
2625 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2626
c56e0fd5
DN
26272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2628
2629 * dispnew.c (add_window_display_history): Use const for the string
2630 pointer. Remove declaration, not needed.
2631
333d54da 26322011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2633
55d4c1b2 2634 Use 'inline', not 'INLINE'.
333d54da 2635 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2636 * alloc.c, fontset.c (INLINE): Remove.
2637 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2638 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2639 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2640 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2641 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2642
738db178
DN
26432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2644
2645 Make it possible to run ./temacs.
2646
2647 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2648 syms_of_callproc does the same thing. Remove test for
2649 "initialized", do it in the caller.
2650 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2651
620c53a6
SM
26522011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2653
2654 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2655 (read_minibuf): Use get_minibuffer.
2656 (syms_of_minibuf): Use DEFSYM.
2657 (Qmetadata): New var.
2658 * data.c (Qbuffer): Don't make it static.
2659 (syms_of_data): Use DEFSYM.
2660
e003a292
PE
26612011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2664 (CCL_CODE_MIN): New macro.
2665
ed008a6d
PE
26662011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2667
3687c2ef
PE
2668 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2669
ed008a6d
PE
2670 * eval.c (Qdebug): Now static.
2671 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2672 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2673 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2674
d66c4c7c
CY
26752011-05-29 Chong Yidong <cyd@stupidchicken.com>
2676
2677 * image.c: Various fixes to ImageMagick code comments.
2678 (Fimagemagick_types): Doc fix.
2679
5fbc2025
PE
26802011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2681
0196f88a
PE
2682 Minor fixes prompted by GCC 4.6.0 warnings.
2683
2684 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2685
5fbc2025
PE
2686 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2687 (x_clipboard_manager_save_all): Move extern decl to ...
2688 * xterm.h: ... here, so that it can be checked for consistency.
2689
1dd3c2d9
CY
26902011-05-29 Chong Yidong <cyd@stupidchicken.com>
2691
2692 * xselect.c (x_clipboard_manager_save_frame)
2693 (x_clipboard_manager_save_all): New functions.
2694 (Fx_clipboard_manager_save): Lisp function deleted.
2695
2696 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2697 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2698
2699 * xterm.h: Update prototype.
2700
5ba6571d
WX
27012011-05-28 William Xu <william.xwl@gmail.com>
2702
2703 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2704 exiting (Bug#8239).
2705
3eaff834
JM
27062011-05-28 Jim Meyering <meyering@redhat.com>
2707
e1900994 2708 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2709 * fns.c (to_uchar): Define.
2710 (crypto_hash_function): Use it to convert some newly-signed
2711 variables to unsigned, to avoid sign-extension bugs. For example,
2712 without this change, (md5 "truc") would evaluate to
2713 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2714 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2715 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2716
0f6990a7
PE
27172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2718
2719 Integer overflow fixes.
c8a9ca5a 2720
08686060
PE
2721 * dbusbind.c: Serial number integer overflow fixes.
2722 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2723 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2724 to hold a serial number that is too large for a fixnum.
2725 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2726 Check for serial numbers out of range. Decode any serial number
59568bf0 2727 that was so large that it became a float. (Bug#8722)
08686060 2728
2d1fc3c7
PE
2729 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2730 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2731 Use XFASTINT rather than XUINT when numbers are nonnegative.
2732 (xd_append_arg, Fdbus_method_return_internal):
2733 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2734 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2735 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2736 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2737 (Bug#8722)
2d1fc3c7 2738
c8a9ca5a
PE
2739 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2740
519e1d69
PE
2741 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2742
30569699
PE
2743 ccl: add integer overflow checks
2744 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2745 (IN_INT_RANGE): New macros.
2746 (ccl_driver): Use them to check for integer overflow when
2747 decoding a CCL program. Many of the new checks are whether XINT (x)
2748 fits in int; it doesn't always, on 64-bit hosts. The new version
2749 doesn't catch all possible integer overflows, but it's an
847044ea 2750 improvement. (Bug#8719)
30569699 2751
c11285dc
PE
2752 * alloc.c (make_event_array): Use XINT, not XUINT.
2753 There's no need for unsigned here.
2754
fdccd48e
PE
2755 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2756 This follows up to the 2011-05-06 change that substituted uintptr_t
2757 for EMACS_INT. This case wasn't caught back then.
2758
37910ab2
PE
2759 Rework Fformat to avoid integer overflow issues.
2760 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2761 now (part of C89). Include <verify.h>.
2762 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2763 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2764 (Fformat): Avoid the prepass trying to compute sizes; it was only
2765 approximate and thus did not catch overflow reliably. Instead, walk
2766 through the format just once, formatting and computing sizes as we go,
2767 checking for integer overflow at every step, and allocating a larger
2768 buffer as needed. Keep track separately whether the format is
2769 multibyte. Keep only the most-recently calculated precision, rather
2770 than them all. Record whether each argument has been converted to
2771 string. Use EMACS_INT, not int, for byte and char and arg counts.
2772 Support field widths and precisions larger than INT_MAX. Avoid
2773 sprintf's undefined behavior with conversion specifications such as %#d
2774 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2775 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2776 formatting out-of-range floating point numbers with int
9173deec 2777 formats. (Bug#8668)
37910ab2 2778
2e6578fb
PE
2779 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2780
0ae6bdee
PE
2781 * data.c: Avoid integer truncation in expressions involving floats.
2782 * data.c: Include <intprops.h>.
2783 (arith_driver): When there's an integer overflow in an expression
2784 involving floating point, convert the integers to floating point
2785 so that the resulting value does not suffer from catastrophic
2786 integer truncation. For example, on a 64-bit host (* 4
2787 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2788 Do not rely on undefined behavior after integer overflow.
2789
de883a70
PE
2790 merge count_size_as_multibyte, parse_str_to_multibyte
2791 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2792 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2793 Check for integer overflow.
2794 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2795 since it's now a duplicate of the other. This is more of
2796 a character than a buffer op, so better that it's in character.c.
2797 * fns.c, print.c: Adjust to above changes.
2798
2ff916cb
PE
27992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2800
2801 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2802
f1b54466
PE
28032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2804
fb1ac845
PE
2805 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2806 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2807 (x_clipboard_manager_save): Now static.
2808 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2809
f1b54466
PE
2810 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2811 (crypto_hash_function): Now static.
2812 Fix pointer signedness problems. Avoid unnecessary initializations.
2813
a9f737ee
CY
28142011-05-27 Chong Yidong <cyd@stupidchicken.com>
2815
2816 * termhooks.h (Vselection_alist): Make it terminal-local.
2817
2818 * terminal.c (create_terminal): Initialize it.
2819
2820 * xselect.c: Support for clipboard managers.
2821 (Vselection_alist): Move to termhooks.h as terminal-local var.
2822 (LOCAL_SELECTION): New macro.
2823 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2824 (symbol_to_x_atom): Remove gratuitous arg.
2825 (x_handle_selection_request, lisp_data_to_selection_data)
2826 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2827 (x_own_selection, x_get_local_selection, x_convert_selection):
2828 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2829 (some_frame_on_display): Delete unused function.
2830 (Fx_own_selection_internal, Fx_get_selection_internal)
2831 (Fx_disown_selection_internal, Fx_selection_owner_p)
2832 (Fx_selection_exists_p): New optional frame arg.
2833 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2834 (x_handle_selection_clear): Don't treat other terminals with the
2835 same keyboard specially. Use the terminal-local Vselection_alist.
2836 (x_clear_frame_selections): Use Frun_hook_with_args.
2837
2838 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2839
2840 * xterm.h: Add support for those atoms.
2841
e067f0c1
CY
28422011-05-26 Chong Yidong <cyd@stupidchicken.com>
2843
2844 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2845 (converted_selections, conversion_fail_tag): New global variables.
2846 (x_selection_request_lisp_error): Free the above.
2847 (x_get_local_selection): Remove unnecessary code.
2848 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2849 of converted selections stored in converted_selections.
2850 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2851 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2852 (x_convert_selection): New function.
2853 (x_handle_selection_event): Simplify.
2854 (x_get_foreign_selection): Don't ignore incoming requests while
2855 waiting for an answer; this will fail when we implement
2856 SAVE_TARGETS, and seems unnecessary anyway.
2857 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2858 (Vx_sent_selection_functions): Doc fix.
2859
0f4aebc0
LL
28602011-05-26 Leo Liu <sdl.web@gmail.com>
2861
2862 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2863
e61124cd
YM
28642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2865
2866 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2867
2868 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2869 for fringe update if it has periodic bitmap.
ac389d0c 2870 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2871 and fringe_bitmap_periodic_p.
2872
2873 * fringe.c (get_fringe_bitmap_data): New function.
2874 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2875 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2876 row. Mark glyph row for fringe update if periodicity changed.
2877
2878 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2879 for fringe update unless it has periodic bitmap.
2880
f16d9837
KH
28812011-05-25 Kenichi Handa <handa@m17n.org>
2882
2883 * xdisp.c (get_next_display_element): Set correct it->face_id for
2884 a static composition.
2885
e1b90ef6
LL
28862011-05-24 Leo Liu <sdl.web@gmail.com>
2887
2888 * deps.mk (fns.o):
2889 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2890
2891 * fns.c (crypto_hash_function, Fsha1): New function.
2892 (Fmd5): Use crypto_hash_function.
2893 (syms_of_fns): Add Ssha1.
2894
7400048f
PE
28952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2896
2897 * gnutls.c: Remove unused macros.
2898 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2899 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2900 Remove macros that are defined and never used.
2901 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2902
abb71cf4
CY
29032011-05-22 Chong Yidong <cyd@stupidchicken.com>
2904
2905 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2906 (Fx_get_selection_internal): Minor cleanup.
2907 (Fx_own_selection_internal): Rename arguments for consistency with
2908 select.el.
2909
6307db39
PE
29102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2913
f3d4e0a4
CY
29142011-05-22 Chong Yidong <cyd@stupidchicken.com>
2915
2916 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2917
4d8ade89
YM
29182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2919
2920 * dispnew.c (scrolling_window): Don't exclude the case that the
2921 last enabled row in the desired matrix touches the bottom boundary.
2922
32078c8d
GM
29232011-05-21 Glenn Morris <rgm@gnu.org>
2924
2925 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2926 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2927 and add some more files.
32078c8d 2928
7285dc67
EZ
29292011-05-20 Eli Zaretskii <eliz@gnu.org>
2930
2931 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2932 report_file_error introduced by the change from 2011-05-07.
2933
89d1bd22
PE
29342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 * systime.h (Time): Define only if emacs is defined.
2937 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2938 where the include path doesn't have X11/X.h by default. See
2939 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2940
e23640bb 29412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2942
2943 * composite.c (find_automatic_composition): Fix previous change.
2944
b9704ad9
GM
29452011-05-20 Glenn Morris <rgm@gnu.org>
2946
2947 * lisp.mk: New file, split from Makefile.in.
2948 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2949 (shortlisp): Remove.
2950 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2951
4a720484
GM
29522011-05-19 Glenn Morris <rgm@gnu.org>
2953
2954 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2955 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2956 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2957 (lisp): Set the order to that of loadup.el.
2958 (shortlisp): Make it a copy of $lisp.
2959 (SOME_MACHINE_LISP): Remove.
2960 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2961 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2962
a28d4396
KH
29632011-05-18 Kenichi Handa <handa@m17n.org>
2964
2965 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2966 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2967 (find_automatic_composition): Mostly rewrite for efficiency.
2968
a2b1fa8e
JB
29692011-05-18 Juanma Barranquero <lekktu@gmail.com>
2970
2971 * makefile.w32-in: Update dependencies.
2972
8e1f5610
CS
29732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2974
2975 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2976 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2977
7025ee00 29782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2979
cdfa6eab
PE
2980 Fix some integer overflow issues, such as string length overflow.
2981
06d6db33
PE
2982 * insdel.c (count_size_as_multibyte): Check for string overflow.
2983
2b4560a8
PE
2984 * character.c (lisp_string_width): Check for string overflow.
2985 Use EMACS_INT, not int, for string indexes and lengths; in
2986 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2987 the resulting string length overflows an EMACS_INT; instead,
2988 report a string overflow if no precision given. When checking for
2989 precision exhaustion, use a check that cannot possibly have
2990 integer overflow. (Bug#8675)
2991 * character.h (lisp_string_width): Adjust to new signature.
2992
cb93f9be
PE
2993 * alloc.c (string_overflow): New function.
2994 (Fmake_string): Use it. This doesn't change behavior, but saves
2995 a few bytes and will simplify future changes.
2996 * character.c (string_escape_byte8): Likewise.
2997 * lisp.h (string_overflow): New decl.
2998
1a1f3366
PE
2999 Fixups, following up to the user-interface timestamp change.
3000 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3001 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3002 * msdos.c (mouse_get_pos): Likewise.
3003 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3004 * w32gui.h (Time): Define by including "systime.h" rather than by
3005 declaring it ourselves. (Bug#8664)
3006
d4e3e4d3
PE
3007 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3008 * image.c (clear_image_cache): Likewise.
3009
f6a24d19
PE
3010 * term.c (term_mouse_position): Don't assume time_t wraparound.
3011
08dc5ae6
PE
3012 Be more systematic about user-interface timestamps.
3013 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3014 and sometimes 'EMACS_UINT', to represent these timestamps.
3015 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3016 This makes the code easier to follow, and makes it easier to catch
3017 integer overflow bugs such as Bug#8664.
3018 * frame.c (Fmouse_position, Fmouse_pixel_position):
3019 Use Time, not unsigned long, for user-interface timestamps.
3020 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3021 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3022 * keyboard.h (last_event_timestamp): Likewise.
3023 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3024 * menu.h (xmenu_show): Likewise.
3025 * term.c (term_mouse_position): Likewise.
3026 * termhooks.h (struct input_event.timestamp): Likewise.
3027 (struct terminal.mouse_position_hook): Likewise.
3028 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3029 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3030 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3031 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3032 what it was before.
3033 * menu.h, termhooks.h: Include "systime.h", for Time.
3034
8e55734a
PE
3035 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3036 Don't assume that the difference between two unsigned long values
3037 can fit into an integer. At this point, we know button_down_time
3038 <= event->timestamp, so the difference must be nonnegative, so
3039 there's no need to cast the result if double-click-time is
3040 nonnegative, as it should be; check that it's nonnegative, just in
3041 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3042 apart (about 25 days). (Bug#8664)
8e55734a 3043
841f1b75 3044 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3045 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3046
3e26f69c
PE
3047 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3048 that always fit in int. Use a sentinel instead of a counter, to
3049 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3050 * frame.h (struct frame): Use int for menu_bar_items_used
3051 instead of EMACS_INT, since it always fits in int.
3e26f69c 3052
5cc152c0
PE
3053 * menu.c (grow_menu_items): Check for int overflow.
3054
d89eb65e
PE
3055 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3056
5235bd3e
PE
3057 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3058 Before, the code was not consistent. These values cannot exceed
3059 2**31 - 1 so there's no need to make them unsigned.
3060 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3061 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3062 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3063 as modifiers.
3064 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3065
bc827e23
PE
3066 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3067 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3068 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3069 presumably because the widths might not match.
3070
78eb494e
PE
3071 * window.c (size_window): Avoid needless test at loop start.
3072
04f2d78b
CB
30732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3074
3075 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3076
d2fc7e3d 30772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3078
3079 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3080
d2fc7e3d 30812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3082
3083 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3084 `width' to `bar_area_x' and `bar_area_width', respectively.
3085 (x_scroll_run): Take account of fringe background extension.
3086
04f2d78b
CB
3087 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3088 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3089 `bar_area_width', respectively.
3090 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3091 background extension.
3092
79b70037
GM
30932011-05-10 Jim Meyering <meyering@redhat.com>
3094
3095 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3096
2f142cc5
JB
30972011-05-10 Juanma Barranquero <lekktu@gmail.com>
3098
3099 * image.c (Finit_image_library): Return t for built-in image types,
3100 like pbm and xbm. (Bug#8640)
3101
57679c86
AS
31022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3103
3104 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3105
888c9e86
EZ
31062011-05-07 Eli Zaretskii <eliz@gnu.org>
3107
b0512a1d
EZ
3108 * w32console.c (Fset_screen_color): Doc fix.
3109 (Fget_screen_color): New function.
3110 (syms_of_ntterm): Defsubr it.
3111
7285dc67
EZ
3112 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3113 unlink the temporary file if Fcall_process didn't create it in the
3114 first place.
3115 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3116 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3117 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3118 cue to call_process_cleanup not to close that handle.
3119
4d3fcc8e
BK
31202011-05-07 Ben Key <bkey76@gmail.com>
3121
3122 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3123 one of two shell specific rules, either bootstrap-temacs-CMD or
3124 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3125 to the previous implementation of the bootstrap-temacs rule.
3126 The bootstrap-temacs-CMD rule is similar to the previous
3127 implementation of the bootstrap-temacs rule except that it
3128 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3129 variable.
3130
3131 These changes, along with some changes to nt/configure.bat,
3132 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3133 earlier fix to add support for --cflags and --ldflags options
3134 that include quotes so that it works whether make uses cmd or
3135 sh as the shell.
3136
b4289b64
MA
31372011-05-06 Michael Albinus <michael.albinus@gmx.de>
3138
3139 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3140 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3141 is a constant.
3142 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3143 a string. Handle both cases.
3144 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3145 (Fdbus_register_method): Use Qinvalid_function.
3146
af4c0e28
JB
31472011-05-06 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * makefile.w32-in: Update dependencies.
3150 (LISP_H): Add inttypes.h and stdin.h.
3151 (PROCESS_H): Add unistd.h.
3152
c51453d9
EZ
31532011-05-06 Eli Zaretskii <eliz@gnu.org>
3154
3155 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3156 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3157
8ff0ac3c 31582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3159
4c4b566b
PE
3160 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3161
aab2b9b5
PE
3162 * term.c (vfatal): Remove stray call to va_end.
3163 It's not needed and the C Standard doesn't allow it here anyway.
3164
c378da0b
PE
3165 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3166 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3167
288b08c7
PE
3168 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3169 bytes.
3170
e3601888
PE
3171 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3172
db6c0e74
PE
3173 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3174
dd5963ea
PE
3175 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3176
88c9450f
PE
3177 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3178
2f9442b8
PE
3179 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3180
c032b5f8
PE
3181 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3182 * charset.c (Fdefine_charset_internal): Don't initialize
3183 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3184 32-bit int (Bug#8600).
a108c10b
PE
3185
3186 * lread.c (read_integer): Be more consistent with string-to-number.
3187 Use string_to_number to do the actual conversion; this avoids
3188 rounding errors and fixes some other screwups. Without this fix,
3189 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3190 (digit_to_number): Move earlier, for benefit of read_integer.
3191 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3192 not a digit in any supported base. (Bug#8602)
a108c10b 3193
ad5f9eea
PE
3194 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3195
aec1708a
PE
3196 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3197 to match comment at start of function. This also removes a
3198 GCC warning about overflow in a 32+64-bit port.
3199
47be4ab5
PE
3200 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3201
371cac43
PE
3202 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3203 Reported by Stefan Monnier in
3204 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3205 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3206 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3207
d01a7826
PE
3208 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3209 (EMACS_UINTPTR): Likewise, with uintptr_t.
3210
7fd47d5c
PE
3211 * lisp.h: Prefer 64-bit EMACS_INT if available.
3212 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3213 on 32-bit hosts that have 64-bit int, so that they can access
3214 large files.
122b0c86
PE
3215 However, temporarily disable this change unless the temporary
3216 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3217
8727937b
PE
3218 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3219
8ac068ac
PE
3220 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3221 This removes an assumption that EMACS_INT and long are the same
3222 width as pointers. The assumption is true for Emacs porting targets
3223 now, but we want to make other targets possible.
3224 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3225 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3226 In the rest of the code, change types of integers that hold casted
3227 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3228 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3229 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3230 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3231 No need to cast type when ORing.
3232 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3233 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3234 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3235 assume EMACS_INT is the same width as char *.
3236 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3237 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3238 Remove no-longer-needed casts.
3239 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3240 (xg_tool_bar_help_callback, xg_make_tool_item):
3241 Use EMACS_INTPTR to hold an integer
3242 that will be cast to void *; this can avoid a GCC warning
3243 if EMACS_INT is not the same width as void *.
3244 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3245 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3246 (current_message_1, set_message_1):
3247 Use a local to convert to proper width without a cast.
3248 * xmenu.c (dialog_selection_callback): Likewise.
3249
ede49d71
PE
3250 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3251 Also, don't assume VALBITS / RAND_BITS is less than 5,
3252 and don't rely on undefined behavior when shifting a 1 left into
3253 the sign bit.
3254 * lisp.h (get_random): Change signature to match.
3255
2f30ecd0
PE
3256 * lread.c (hash_string): Use size_t, not int, for hash computation.
3257 Normally we prefer signed values; but hashing is special, because
3258 it's better to use unsigned division on hash table sizes so that
3259 the remainder is nonnegative. Also, size_t is the natural width
3260 for hashing into memory. The previous code used 'int', which doesn't
3261 retain enough info to hash well into very large tables.
3262 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3263
2a866e7b
PE
3264 * dbusbind.c: Don't possibly lose pointer info when converting.
3265 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3266 Use XPNTR rather than XHASH, so that the high-order bits of
3267 the pointer aren't lost when converting through void *.
3268
51639eac
PE
3269 * eval.c (Fautoload): Don't double-shift a pointer.
3270
92394119
PE
3271 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3272
dbdb9a7c
JB
32732011-05-06 Juanma Barranquero <lekktu@gmail.com>
3274
3275 * gnutls.c (DEF_GNUTLS_FN):
3276 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3277
db7a0b4f
AS
32782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3279
3280 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3281 marker. (Bug#8610)
3282
f7ff1b0f 32832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3284
3285 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3286 New version that can reserve upto 2GB of heap space.
3287
f7ff1b0f 32882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3289
3290 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3291
639c109b
TZ
32922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3293
3294 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3295 `gnutls_certificate_set_x509_key_file'.
3296
d2127135
JB
32972011-05-05 Juanma Barranquero <lekktu@gmail.com>
3298
3299 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3300 Update dependencies.
3301
e968f4f3
JB
33022011-05-04 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3305 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3306 Remove unused parameter `fildes'.
3307 * process.c (read_process_output, send_process): Don't pass it.
3308
84d358f0
JB
33092011-05-04 Juanma Barranquero <lekktu@gmail.com>
3310
3311 Fix previous change: the library cache is defined in w32.c.
3312 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3313 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3314
0898ca10
JB
33152011-05-04 Juanma Barranquero <lekktu@gmail.com>
3316
3317 Implement dynamic loading of GnuTLS on Windows.
3318
3319 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3320 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3321 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3322 Declare.
3323
3324 * gnutls.c (Qgnutls_dll): Define.
3325 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3326 (gnutls_*): Declare function pointers.
3327 (init_gnutls_functions): New function to initialize function pointers.
3328 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3329 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3330 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3331 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3332 (emacs_gnutls_write, emacs_gnutls_read)
3333 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3334 (Fgnutls_available_p): New function.
3335 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3336 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3337 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3338
3339 * image.c: Include w32.h.
3340 (Vimage_type_cache): Delete.
3341 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3342 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3343 (w32_delayed_load): Move to w32.c.
3344
3345 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3346
3347 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3348 (w32_delayed_load): Move from image.c. When loading a library, record
3349 its filename in the :loaded-from property of the library id.
3350 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3351 Initialize and staticpro them.
3352 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3353
3354 * process.c: Include lisp.h before w32.h, not after.
3355 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3356 instead of gnutls_record_check_pending.
3357
3358 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3359
ff4de4aa
TZ
33602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3361
3362 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3363 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3364 as passed in.
3365
abe95abb
JD
33662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3367
3368 * xterm.c (x_set_frame_alpha): Do not set property on anything
3369 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3370
e16e55d4
JB
33712011-05-02 Juanma Barranquero <lekktu@gmail.com>
3372
3373 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3374
bafcf6a5
JB
33752011-05-02 Juanma Barranquero <lekktu@gmail.com>
3376
3377 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3378 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3379 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3380 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3381 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3382 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3383 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3384 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3385 (Qgnutls_bootprop_callbacks_verify): Make static.
3386
e7a6747f
AS
33872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3388
19ed11ba
AS
3389 * callproc.c: Indentation fixup.
3390
e7a6747f 3391 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3392 (wait_for_termination, interruptible_wait_for_termination):
3393 Move after wait_for_termination_1.
e7a6747f 3394
1ef14cb4
LMI
33952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3396
3397 * sysdep.c (interruptible_wait_for_termination): New function
3398 which is like wait_for_termination, but allows keyboard
3399 interruptions.
3400
3401 * callproc.c (Fcall_process): Add (:file "file") as an option for
3402 the STDOUT buffer.
3403 (Fcall_process_region): Ditto.
3404
330d880c
EZ
34052011-04-30 Eli Zaretskii <eliz@gnu.org>
3406
8db90b73
EZ
3407 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3408 rather than `XVECTOR (FOO)->size'.
3409
330d880c
EZ
3410 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3411 inttypes.h, as a gnulib replacement is used if it not available in
3412 system headers.
3413
15cbd324
EZ
34142011-04-21 Eli Zaretskii <eliz@gnu.org>
3415
3416 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3417 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3418 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3419
3420 * coding.c (coding_alloc_by_realloc): Error out if destination
3421 will grow beyond MOST_POSITIVE_FIXNUM.
3422 (decode_coding_emacs_mule): Abort if there isn't enough place in
3423 charbuf for the composition carryover bytes. Reserve an extra
3424 space for up to 2 characters produced in a loop.
3425 (decode_coding_iso_2022): Abort if there isn't enough place in
3426 charbuf for the composition carryover bytes.
3427
34282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3429
ae940cca
EZ
3430 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3431 aborting when %lld or %lll format is passed.
3432 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3433 %llo or %llx format is passed. (Bug#8545)
3434
03ab8921
EZ
3435 * window.c (window_scroll_line_based): Use a marker instead of
3436 simple variables to record original value of point. (Bug#7952)
3437
afda1437
EZ
3438 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3439 produced by %s or %c overflows available buffer space. (Bug#8545)
3440
f76dee0c
PE
34412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3442
3443 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3444 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3445
fdc5744d
JB
34462011-04-28 Juanma Barranquero <lekktu@gmail.com>
3447
3448 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3449
638f053a
JB
34502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3451
3452 * keyboard.c (Qdelayed_warnings_hook): Define.
3453 (command_loop_1): Run `delayed-warnings-hook'
3454 if Vdelayed_warnings_list is non-nil.
3455 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3456 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3457
d178f871
EZ
34582011-04-28 Eli Zaretskii <eliz@gnu.org>
3459
3460 * doprnt.c (doprnt): Don't return value smaller than the buffer
3461 size if the message was truncated. (Bug#8545).
3462
b124fd93
JB
34632011-04-28 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3466 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3467
e810457d
PE
34682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3469
3470 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3471
ea51cceb
JB
34722011-04-27 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * makefile.w32-in: Update dependencies.
3475
94dcfacf
EZ
34762011-04-27 Eli Zaretskii <eliz@gnu.org>
3477
3478 Improve `doprnt' and its usage. (Bug#8545)
3479 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3480 `format_end'. Remove support for %l as a conversion specifier.
3481 Don't use xrealloc. Improve diagnostics when the %l size modifier
3482 is used. Update the commentary.
3483
3484 * eval.c (verror): Simplify calculation of size_t.
3485
3486 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3487 messages.
3488
f61f41d7
PE
34892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3490
3491 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3492 change.
3493
96fb4434
PE
34942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3495
3496 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3497 This makes this file independent of the recent pseudovector change.
3498
671875da 34992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3500
69e9b5a3
PE
3501 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3502
b5f869a7 3503 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3504 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3505 Remove unused local.
c8926152 3506 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3507
841a1577 3508 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3509 GCC 4.6.0 optimizes based on type-based alias analysis.
3510 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3511 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3512 != &v->size, and therefore "v->size = 1; b->size = 2; return
3513 v->size;" must therefore return 1. This assumption is incorrect
3514 for Emacs, since it type-puns struct Lisp_Vector * with many other
3515 types. To fix this problem, this patch adds a new type struct
f904488f 3516 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3517 and pseudovectors, and helps optimizing compilers not get fooled
3518 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3519 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3520 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3521 the size member.
eab3844f
PE
3522 (XSETPVECTYPE): Rewrite in terms of new macro.
3523 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3524 This is a bit clearer, and further avoids the possibility of
3525 undesirable aliasing.
3526 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3527 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3528 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3529 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3530 (ASIZE): Now uses header.size rather than size.
3531 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3532 to avoid the hassle of writing XVECTOR (foo)->header.size.
3533 (struct vectorlike_header): New type.
eab3844f
PE
3534 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3535 object, to help avoid aliasing.
3536 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3537 (SUBRP): Likewise, since Lisp_Subr is a special case.
3538 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3539 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3540 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3541 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3542 changed to be "header.size" and "header.next".
3543 * buffer.h (struct buffer): Likewise.
3544 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3545 * frame.h (struct frame): Likewise.
3546 * process.h (struct Lisp_Process): Likewise.
3547 * termhooks.h (struct terminal): Likewise.
3548 * window.c (struct save_window_data, struct saved_window): Likewise.
3549 * window.h (struct window): Likewise.
3550 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3551 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3552 * buffer.c (init_buffer_once): Likewise.
3553 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3554 special case.
3555 * process.c (Fformat_network_address): Use local var for size,
3556 for brevity.
3557
0df1eac5
PE
3558 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3559
847ab9d1 3560 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3561 * data.c (atof): Remove decl; no longer used or needed.
3562 (digit_to_number): Move to lread.c.
3563 (Fstring_to_number): Use new string_to_number function, to be
3564 consistent with how the Lisp reader treats infinities and NaNs.
3565 Do not assume that floating-point numbers represent EMACS_INT
3566 without losing information; this is not true on most 64-bit hosts.
3567 Avoid double-rounding errors, by insisting on integers when
3568 parsing non-base-10 numbers, as the documentation specifies.
3569 * lisp.h (string_to_number): New decl, replacing ...
3570 (isfloat_string): Remove.
bc0a5c13 3571 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3572 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3573 appears to have been a coding error. Similarly, do not accept
3574 strings like +-1e0 as floating point numbers. Do not report
3575 overflow for integer overflows unless the base is not 10 which
3576 means we have no simple and reliable way to continue.
3577 Break out the floating-point parsing into a new
3578 function string_to_number, so that Fstring_to_number parses
3579 floating point numbers consistently with the Lisp reader.
04f2d78b 3580 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3581 (E_CHAR, EXP_INT): Remove, replacing with ...
3582 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3583 (string_to_number): New function, replacing isfloat_string.
3584 This function checks for valid syntax and produces the resulting
3585 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3586 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3587 so that overflow for non-base-10 numbers is reported only when
3588 there's no portable and simple way to convert to floating point.
452f4150 3589
67769ffc
PE
3590 * textprop.c (set_text_properties_1): Rewrite for clarity,
3591 and to avoid GCC warning about integer overflow.
3592
c20db43f
PE
3593 * intervals.h (struct interval): Use EMACS_INT for members
3594 where EMACS_UINT might cause problems. See
3595 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3596 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3597 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3598 All uses changed.
37aa2f85
PE
3599 (offset_intervals): Tell GCC not to worry about length overflow
3600 when negating a negative length.
c20db43f 3601
2538aa2f
PE
3602 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3603 (overrun_check_free): Likewise.
3604
f2d3008d
PE
3605 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3606 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3607 word size.
3608
ec8df744
PE
3609 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3610 (gnutls_make_error): Rename local to avoid shadowing.
3611 (gnutls_emacs_global_deinit): ifdef out; not used.
3612 (Fgnutls_boot): Use const for pointer to readonly storage.
3613 Comment out unused local. Fix pointer signedness problems.
3614
640ee02d
PE
3615 * lread.c (openp): Don't stuff size_t into an 'int'.
3616 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3617 about possible signed overflow.
3618
6048fb2a
PE
3619 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3620 (GDK_KEY_g): Don't define if already defined.
3621 (xg_prepare_tooltip): Avoid pointer signedness problem.
3622 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3623
fa3c87e1
PE
3624 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3625 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3626
2172544b
PE
3627 * xfns.c (Fx_window_property): Simplify a bit,
3628 to make a bit faster and to avoid GCC 4.6.0 warning.
3629 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3630
9b821a21
PE
3631 * fns.c (internal_equal): Don't assume size_t fits in int.
3632
3c616cfa
PE
3633 * alloc.c (compact_small_strings): Tighten assertion a little.
3634
c2982e87
PE
3635 Replace pEd with more-general pI, and fix some printf arg casts.
3636 * lisp.h (pI): New macro, generalizing old pEd macro to other
3637 conversion specifiers. For example, use "...%"pI"d..." rather
3638 than "...%"pEd"...".
3639 (pEd): Remove. All uses replaced with similar uses of pI.
3640 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3641 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3642 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3643 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3644 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3645 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3646 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3647 64-bit hosts.
3648 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3649 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3650 * print.c (safe_debug_print, print_object): Likewise.
3651 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3652 to int.
6f04d126
PE
3653 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3654 avoiding the 0 flag, which is not portable.
c2982e87
PE
3655 * process.c (Fmake_network_process): Use pI to avoid cast.
3656 * region-cache.c (pp_cache): Likewise.
3657 * xdisp.c (decode_mode_spec): Likewise.
3658 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3659 behavior on 64-bit hosts with printf arg.
6f04d126 3660 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3661 (x_stop_queuing_selection_requests): Likewise.
3662 (x_get_window_property): Don't truncate byte count to an 'int'
3663 when tracing.
0b432f21 3664
5e073ec7
PE
3665 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3666 here, since it parses constructs like leading '-' and spaces,
3667 which are not wanted; and it overflows with large numbers.
3668 Instead, simply match F[0-9]+, which is what is wanted anyway.
3669
36372bf9
PE
3670 * alloc.c: Remove unportable assumptions about struct layout.
3671 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3672 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3673 (allocate_vectorlike, make_pure_vector): Use the new macros,
3674 plus offsetof, to remove unportable assumptions about struct layout.
3675 These assumptions hold on all porting targets that I know of, but
3676 they are not guaranteed, they're easy to remove, and removing them
3677 makes further changes easier.
3678
0b432f21
PE
3679 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3680 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3681 (string_overrun_cookie): Now const. Use initializers that
3682 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3683 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3684 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3685 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3686 multiple of sizeof (EMACS_INT); it need not be, if
3687 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3688 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3689
895009e1
JB
36902011-04-26 Juanma Barranquero <lekktu@gmail.com>
3691
3692 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3693
6a7a1b0b
TZ
36942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3695
3696 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3697 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3698 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3699
841a1577 37002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3701
3702 * lisp.h (Qdebug): List symbol.
895009e1 3703 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3704 * keyboard.c (debug-on-event): New variable.
3705 (handle_user_signal): Break into debugger when debug-on-event
3706 matches the current signal symbol.
3707
f2d3ba6f
DN
37082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3709
3710 * alloc.c (check_sblock, check_string_bytes)
3711 (check_string_free_list): Convert to standard C.
3712
42ce4c63
TZ
37132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3714
3715 * w32.c (emacs_gnutls_push): Fix typo.
3716
825cd63c
EZ
37172011-04-25 Eli Zaretskii <eliz@gnu.org>
3718
fb11d64d
EZ
3719 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3720 "cast to pointer from integer of different size".
3721
825cd63c
EZ
3722 Improve doprnt and its use in verror. (Bug#8545)
3723 * doprnt.c (doprnt): Document the set of format control sequences
3724 supported by the function. Use SAFE_ALLOCA instead of always
3725 using `alloca'.
3726
3727 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3728 is one byte too soon. Don't use xrealloc; instead xfree and
3729 xmalloc anew.
3730
e061a11b
TZ
37312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3732
3733 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3734 callbacks stage.
3735
3736 * gnutls.c: Renamed global_initialized to
3737 gnutls_global_initialized. Added internals for the
3738 :verify-hostname-error, :verify-error, and :verify-flags
3739 parameters of `gnutls-boot' and documented those parameters in the
3740 docstring. Start callback support.
9173deec
JB
3741 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3742 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3743 on error. Return error code.
e061a11b
TZ
3744 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3745 (emacs_gnutls_read): Likewise.
3746 (Fgnutls_boot): Return handshake error code.
3747 (emacs_gnutls_handle_error): New function.
3748 (wsaerror_to_errno): Likewise.
3749
3750 * w32.h (emacs_gnutls_pull): Add prototype.
3751 (emacs_gnutls_push): Likewise.
3752
3753 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3754 (emacs_gnutls_push): Likewise.
3755
37562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3757
3758 * process.c (wait_reading_process_output): Check if GnuTLS
3759 buffered some data internally if no FDs are set for TLS
3760 connections.
3761
3762 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3763 (LIBS): Link to USER_LIBS.
3764 ($(BLD)/gnutls.$(0)): New target.
3765
fa6996bc
EZ
37662011-04-24 Eli Zaretskii <eliz@gnu.org>
3767
eb35682e
EZ
3768 * xdisp.c (handle_single_display_spec): Rename the
3769 display_replaced_before_p argument into display_replaced_p, to
3770 make it consistent with the commentary. Fix typos in the
3771 commentary.
3772
e2ad650c
EZ
3773 * textprop.c (syms_of_textprop): Remove dead code.
3774 (copy_text_properties): Delete obsolete commentary about an
3775 interface that was deleted long ago. Fix typos in the description
3776 of arguments.
3777
1b2de274
EZ
3778 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3779 to changes in oldXMenu/XMenu.h from 2011-04-16.
3780 <menu_help_message, prev_menu_help_message>: Constify.
3781 (IT_menu_make_room): menu->help_text is now `const char **';
3782 adjust.
3783
3784 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3785 to changes in oldXMenu/XMenu.h from 2011-04-16.
3786 (struct XMenu): Declare `help_text' `const char **'.
3787
3788 * xfaces.c <Qunspecified>: Make extern again.
3789
3790 * syntax.c: Include sys/types.h before including regex.h, as
3791 required by Posix.
3792
762b15be
EZ
3793 * doc.c (get_doc_string): Improve the format passed to `error'.
3794
3795 * doprnt.c (doprnt): Improve commentary.
3796
3797 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3798
3799 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3800 them with etags.
3801
f1052e5d
EZ
3802 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3803 changes in globals.h immediately force recompilation.
762b15be
EZ
3804 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3805 $(CURDIR)/s/ms-w32.h.
3806 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3807
fa6996bc
EZ
3808 * character.c (Fchar_direction): Function deleted.
3809 (syms_of_character): Don't defsubr it.
3810 <char-direction-table>: Deleted.
3811
e6c3da20
EZ
38122011-04-23 Eli Zaretskii <eliz@gnu.org>
3813
3814 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3815 * doprnt.c: Include limits.h.
3816 (SIZE_MAX): New macro.
04f2d78b
CB
3817 (doprnt): Return a size_t value. 2nd arg is now size_t.
3818 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3819 Improve overflow protection. Support `l' modifier for integer
3820 conversions. Support %l conversion. Don't assume an EMACS_INT
3821 argument for integer conversions and for %c.
3822
3823 * lisp.h (doprnt): Restore prototype.
3824
3825 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3826 $(SRC)/character.h.
3827
3828 * Makefile.in (base_obj): Add back doprnt.o.
3829
3830 * deps.mk (doprnt.o): Add back prerequisites.
3831 (callint.o): Depend on character.h.
3832
3833 * eval.c (internal_lisp_condition_case): Include the handler
3834 representation in the error message.
3835 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3836 when breaking from the loop.
3837
3838 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3839
3840 * callint.c (Fcall_interactively): When displaying error message
3841 about invalid control letter, pass the character's codepoint, not
3842 a pointer to its multibyte form. Improve display of the character
3843 in octal and display also its hex code.
3844
3845 * character.c (char_string): Use %x to display the (unsigned)
3846 codepoint of an invalid character, to avoid displaying a bogus
3847 negative value.
3848
3849 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3850 `error', not SYMBOL_NAME itself.
3851
3852 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3853 character arguments to `error'.
3854
3855 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3856 to `error' in error message about FINAL_CHAR argument. Make sure
3857 FINAL_CHAR is a character, and use %c when it is passed as
3858 argument to `error'.
3859
4ffd0d6b 38602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3861
3862 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3863
3864 * w32.c: Include <time.h>.
3865 (sys_localtime): New function.
3866
4ffd0d6b 38672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3868
3869 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3870
4ffd0d6b 3871 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3872
4ffd0d6b 38732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3874
4ffd0d6b
GM
3875 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3876 zombies (Bug#8467).
aac0c6e3 3877
04c56954
EZ
38782011-04-19 Eli Zaretskii <eliz@gnu.org>
3879
3880 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3881 gl_state.e_property when gl_state.object is Qt.
3882
3883 * insdel.c (make_gap_larger): Remove limitation of buffer size
3884 to <= INT_MAX.
3885
16a43933
CY
38862011-04-18 Chong Yidong <cyd@stupidchicken.com>
3887
3888 * xdisp.c (lookup_glyphless_char_display)
3889 (produce_glyphless_glyph): Handle cons cell entry in
3890 glyphless-char-display.
3891 (Vglyphless_char_display): Document it.
3892
3893 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3894 glyphless-char-display.
3895
4581706e
CY
38962011-04-17 Chong Yidong <cyd@stupidchicken.com>
3897
3898 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3899
3900 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3901
3902 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3903 definition for no-X builds.
3904
4887c6e2 39052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3906
fd35b6f9
PE
3907 Static checks with GCC 4.6.0 and non-default toolkits.
3908
5c1ccb01
PE
3909 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3910
006c5daa
PE
3911 * process.c (keyboard_bit_set): Define only if SIGIO.
3912 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3913 (send_process): Repair possible setjmp clobbering.
3914
efc736d3
PE
3915 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3916
4e2fe2e6
PE
3917 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3918
f97334a2
PE
3919 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3920
4e75f29d
PE
3921 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3922 Define only if needed.
3923
90efadd1
PE
3924 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3925 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3926 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3927
3c647824
PE
3928 * dispextern.h (struct redisplay_interface): Rename param
3929 to avoid shadowing.
e264f262 3930 * termhooks.h (struct terminal): Likewise.
761383f4 3931 * xterm.c (xembed_send_message): Likewise.
3c647824 3932
b58c5c4a
PE
3933 * insdel.c (make_gap_smaller): Define only if
3934 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3935
cad59032
PE
3936 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3937 it.
3938
c339dc2e
PE
3939 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3940 so that we aren't warned about unused symbols.
3941
91a3e27b
PE
3942 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3943
399c71d3 3944 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3945
8ffc96f5
PE
3946 * xfns.c (x_real_positions): Mark locals as initialized.
3947
eef9bc79
PE
3948 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3949
098db9dd
PE
3950 * xterm.c: Fix problems found by static analysis with other toolkits.
3951 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3952 (x_dispatch_event): Declare static if USE_GTK, and
3953 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3954 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3955 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3956 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3957 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3958
eb18f6cc
PE
3959 * xmenu.c (menu_help_callback): Pointer type fixes.
3960 Use const pointers when pointing at readonly data. Avoid pointer
3961 signedness clashes.
3962 (FALSE): Remove unused macro.
3963 (update_frame_menubar): Remove unused decl.
3964
1fe72bf8
PE
3965 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3966
60d9e1db
PE
3967 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3968 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3969 (single_menu_item): Rename local to avoid shadowing.
3970
39261c26
PE
3971 * keyboard.c (make_lispy_event): Remove unused local var.
3972
018c5e19
PE
3973 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3974 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3975
63d2b86e
PE
3976 * bitmaps: Change bitmaps from unsigned char back to the X11
3977 compatible char. Avoid the old compiler warnings about
3978 out-of-range initializers by using, for example, '\xab' rather
3979 than 0xab.
3980
aefd87e1
PE
3981 * xgselect.c (xgselect_initialize): Check vs interface
3982 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3983
bf501fb9
PE
3984 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3985
e9829fdf
PE
3986 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3987 to read-only memory.
3988
1086c095
PE
3989 * fns.c (vector): Remove; this old hack is no longer needed.
3990
2baccd04 3991 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3992 Remove unused var.
dde42981 3993 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3994
72391843 3995 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3996
436c16df 3997 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3998 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3999 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4000
92bb796d 4001 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4002 (x_term_init): Remove local to avoid shadowing.
92bb796d 4003
764430a3 4004 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4005
4006 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4007 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4008
d1dfb56c
EZ
40092011-04-16 Eli Zaretskii <eliz@gnu.org>
4010
c4354cb4
EZ
4011 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4012
d1dfb56c
EZ
4013 Fix regex.c, syntax.c and friends for buffers > 2GB.
4014 * syntax.h (struct gl_state_s): Declare character position members
4015 EMACS_INT.
4016
4017 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4018
04f2d78b
CB
4019 * textprop.c (verify_interval_modification, interval_of):
4020 Declare arguments EMACS_INT.
d1dfb56c
EZ
4021
4022 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4023 EMACS_INT.
4024
4025 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4026
4027 * indent.c (Fvertical_motion): Local variable it_start is now
4028 EMACS_INT.
4029
4030 * regex.c (re_match, re_match_2, re_match_2_internal)
4031 (bcmp_translate, regcomp, regexec, print_double_string)
4032 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4033 (re_compile_pattern, re_exec): Declare arguments and local
4034 variables `size_t' and `ssize_t' and return values `regoff_t', as
4035 appropriate.
4036 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4037 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4038 <compile_stack_type>: `size' and `avail' are now `size_t'.
4039
4040 * regex.h <regoff_t>: Use ssize_t, not int.
4041 (re_search, re_search_2, re_match, re_match_2): Arguments that
4042 specify buffer/string position and length are now ssize_t and
4043 size_t. Return type is regoff_t.
4044
613052cd
BK
40452011-04-16 Ben Key <bkey76@gmail.com>
4046
4047 * nsfont.m: Fixed bugs in ns_get_family and
4048 ns_descriptor_to_entity that were caused by using free to
4049 deallocate memory blocks that were allocated by xmalloc (via
4050 xstrdup). This caused Emacs to crash when compiled with
4051 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4052 --enable-checking=xmallocoverrun). xfree is now used to
4053 deallocate these memory blocks.
4054
4170f62f 40552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4056
71b41406
PE
4057 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4058
9587a89d
PE
4059 emacs_write: Accept and return EMACS_INT for sizes.
4060 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4061 et seq.
4062 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4063 Accept and return EMACS_INT.
4064 (emacs_gnutls_write): Return the number of bytes written on
4065 partial writes.
4066 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4067 (emacs_read, emacs_write): Remove check for negative size, as the
4068 Emacs source code has been audited now.
9587a89d
PE
4069 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4070 (emacs_read, emacs_write): Use it.
273a5f82
PE
4071 * process.c (send_process): Adjust to the new signatures of
4072 emacs_write and emacs_gnutls_write. Do not attempt to store
4073 a byte offset into an 'int'; it might overflow.
9587a89d 4074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4075
3e047f51
PE
4076 * sound.c: Don't assume sizes fit in 'int'.
4077 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4078 Return EMACS_INT, not int.
3e047f51 4079 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4080 Accept EMACS_INT, not int.
4081 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4082 record read return values.
4083
cc39a9db
BK
40842011-04-15 Ben Key <bkey76@gmail.com>
4085
c9d0ec6d
JB
4086 * keyboard.c (Qundefined): Don't declare static since it is used
4087 in nsfns.m.
4088 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4089 static since they are used in nsfont.m.
cc39a9db 4090
6c60eb9f
SM
40912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4092
4093 * process.c (Qprocessp): Don't declare static.
4094 * lisp.h (Qprocessp): Declare again.
4095
7990b61a
JB
40962011-04-15 Juanma Barranquero <lekktu@gmail.com>
4097
4098 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4099
5d4cb038
PE
41002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4101
8bd7b830 4102 Improve C-level modularity by making more things 'static'.
cd64ea1d 4103
e3b27b31
PE
4104 Don't publish debugger-only interfaces to other modules.
4105 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4106 (verify_bytepos, count_markers): Move decls to the only modules
4107 that need them.
4108 * region-cache.h (pp_cache): Likewise.
4109 * window.h (check_all_windows): Likewise.
4110 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4111
5d4cb038
PE
4112 * sysdep.c (croak): Now static, if
4113 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4114 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4115
4116 * alloc.c (refill_memory_reserve): Now static if
4117 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4118 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4119
e87b6180
PE
4120 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4121 Define only if USE_LUCID.
4122
ac64929e
PE
4123 * xrdb.c (x_customization_string, x_rm_string): Now static.
4124
6f37259d
PE
4125 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4126 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4127
1683e3ab
PE
4128 * xdisp.c (draw_row_with_mouse_face): Now static.
4129 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4130
de9c2632
PE
4131 * window.h (check_all_windows): Mark externally visible.
4132
2b96acb7
PE
4133 * window.c (window_deletion_count): Now static.
4134
4135 * undo.c: Make symbols static if they're not exported.
4136 (last_undo_buffer, last_boundary_position, pending_boundary):
4137 Now static.
4138
50436f33
PE
4139 * textprop.c (interval_insert_behind_hooks): Now static.
4140 (interval_insert_in_front_hooks): Likewise.
4141
64520e5c
PE
4142 * term.c: Make symbols static if they're not exported.
4143 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4144 (max_frame_lines, tty_set_terminal_modes):
4145 (tty_reset_terminal_modes, tty_turn_off_highlight):
4146 (get_tty_terminal): Now static.
4147 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4148 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4149 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4150 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4151 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4152
1fa53021
PE
4153 * sysdep.c: Make symbols static if they're not exported.
4154 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4155 Now static.
4156 (sigprocmask_set, full_mask): Remove; unused.
4157 (wait_debugging): Mark as visible.
4158 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4159 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4160
d4b43b22
PE
4161 * syntax.c (syntax_temp): Define only if !__GNUC__.
4162
b7c513d0
PE
4163 * sound.c (current_sound_device, current_sound): Now static.
4164
989b29ad
PE
4165 * search.c (searchbufs, searchbuf_head): Now static.
4166
13a55a78
PE
4167 * scroll.c (scroll_cost): Remove; unused.
4168 * dispextern.h (scroll_cost): Remove decl.
4169
de68a1fc
PE
4170 * region-cache.h (pp_cache): Mark as externally visible.
4171
40ccffa6
PE
4172 * process.c: Make symbols static if they're not exported.
4173 (process_tick, update_tick, create_process, chan_process):
4174 (Vprocess_alist, proc_buffered_char, datagram_access):
4175 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4176 (deactivate_process): Mark defn as static, as well as decl.
4177 * lisp.h (create_process): Remove decl.
4178 * process.h (chan_process, Vprocess_alist): Remove decls.
4179
ad64fc97
PE
4180 * print.c: Make symbols static if they're not exported.
4181 (print_depth, new_backquote_output, being_printed, print_buffer):
4182 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4183 (print_interval, print_number_index, initial_stderr_stream):
4184 Now static.
4185 * lisp.h (Fprinc): Remove decl.
4186 (debug_output_compilation_hack): Mark as externally visible.
4187
adddb265
PE
4188 * sysdep.c (croak): Move decl from here to syssignal.h.
4189 * syssignal.h (croak): Put it here, so the API can be checked when
4190 'croak' is called from dissociate_if_controlling_tty.
4191
1717ede2
PE
4192 * minibuf.c: Make symbols static if they're not exported.
4193 (minibuf_save_list, choose_minibuf_frame): Now static.
4194 * lisp.h (choose_minibuf_frame): Remove decl.
4195
fa5fb2bc
PE
4196 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4197
1e3890d1
PE
4198 * lread.c: Make symbols static if they're not exported.
4199 (read_objects, initial_obarray, oblookup_last_bucket_number):
4200 Now static.
4201 (make_symbol): Remove; unused.
4202 * lisp.h (initial_obarray, make_symbol): Remove decls.
4203
8a1414fa
PE
4204 * keyboard.c: Make symbols static if they're not exported.
4205 (single_kboard, recent_keys_index, total_keys, recent_keys):
4206 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4207 (this_single_command_key_start, echoing, last_auto_save):
4208 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4209 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4210 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4211 (Vlispy_mouse_stem, double_click_count):
4212 Now static.
4213 (force_auto_save_soon): Define only if SIGDANGER.
4214 (ignore_mouse_drag_p): Now static if
4215 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4216 (print_help): Remove; unused.
4217 (stop_character, last_timer_event): Mark as externally visible.
4218 * keyboard.h (ignore_mouse_drag_p): Declare only if
4219 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4220 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4221 * lisp.h (echoing): Remove decl.
4222 (force_auto_save_soon): Declare only if SIGDANGER.
4223 * xdisp.c (redisplay_window): Simplify code, to make it more
4224 obvious that ignore_mouse_drag_p is not accessed if !defined
4225 USE_GTK && !defined HAVE_NS.
4226
93ea6e8f
PE
4227 * intervals.c: Make symbols static if they're not exported.
4228 (merge_properties_sticky, merge_interval_right, delete_interval):
4229 Now static.
4230 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4231
77382fcc
PE
4232 * insdel.c: Make symbols static if they're not exported.
4233 However, leave prepare_to_modify_buffer alone. It's never
4234 called from outside this function, but that appears to be a bug.
4235 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4236 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4237 (adjust_after_replace_noundo): Remove; unused.
4238 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4239 (signal_before_change): Remove decls.
77382fcc 4240
9306c32e
PE
4241 * indent.c (val_compute_motion, val_vmotion): Now static.
4242
cd44d2eb
PE
4243 * image.c: Make symbols static if they're not exported.
4244 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4245 if USE_GTK.
4246 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4247 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4248
ad9a7a06
PE
4249 * fringe.c (standard_bitmaps): Now static.
4250 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4251
81626931
PE
4252 * frame.c: Make symbols static if they're not exported.
4253 (x_report_frame_params, make_terminal_frame): Now static.
4254 (get_frame_param): Now static, unless HAVE_NS.
4255 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4256 (x_get_resource_string): Remove; not used.
4257 * frame.h (make_terminal_frame, x_report_frame_params):
4258 (x_get_resource_string); Remove decls.
4259 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4260 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4261
239f9db9
PE
4262 * font.c, fontset.c: Make symbols static if they're not exported.
4263 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4264 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4265 * font.c (font_close_object): Now static.
4266 * font.h (font_close_object): Remove.
4267 * fontset.c (FONTSET_OBJLIST): Remove.
4268 (free_realized_fontset) #if-0 the body, which does nothing.
4269 (face_suitable_for_char_p): #if-0, as it's never called.
4270 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4271 * xfaces.c (face_at_string_position):
4272 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4273 since 0 is always ASCII.
4274
dfcf3579
PE
4275 * fns.c (weak_hash_tables): Now static.
4276
5045092b
PE
4277 * fileio.c: Make symbols static if they're not exported.
4278 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4279 (Vwrite_region_annotation_buffers): Now static.
4280
57a96f5c
PE
4281 * eval.c: Make symbols static if they're not exported.
4282 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4283 * lisp.h (backtrace_list): Remove decl.
4284
35f08c38
PE
4285 * emacs.c: Make symbols static if they're not exported.
4286 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4287 (fatal_error_code, fatal_error_signal_hook, standard_args):
4288 Now static.
4289 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4290 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4291 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4292 * lisp.h (fatal_error_signal_hook): Remove decl.
4293 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4294
f44bd759
PE
4295 * editfns.c: Move a (normally-unused) function to its only use.
4296 * editfns.c, lisp.h (get_operating_system_release): Remove.
4297 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4298 worth the hassle of breaking this out.
4299
b532497d
PE
4300 * xterm.c: Make symbols static if they're not exported.
4301 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4302 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4303 (x_destroy_window, x_delete_display):
4304 Now static.
4305 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4306 (x_mouse_leave): Remove; unused.
4307 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4308 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4309 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4310 Remove decls.
4311 (x_mouse_leave): Declare only if WINDOWSNT.
4312 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4313 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4314 USE_X_TOOLKIT.
4315
1675728f
PE
4316 * ftxfont.c: Make symbols static if they're not exported.
4317 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4318 HAVE_FREETYPE.
4319 * font.h (ftxfont_driver): Likewise.
4320
e4cebfca
PE
4321 * xfns.c: Make symbols static if they're not exported.
4322 (x_last_font_name, x_display_info_for_name):
4323 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4324 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4325 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4326 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4327 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4328 (last_show_tip_args): Now static.
4329 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4330 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4331 (x_screen_planes): Remove; unused.
4332 * dispextern.h (x_screen_planes): Remove decl.
4333
5bf46f05
PE
4334 * dispnew.c: Make symbols static if they're not exported.
4335 * dispextern.h (redraw_garbaged_frames, scrolling):
4336 (increment_row_positions): Remove.
4337 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4338 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4339 Now static.
4340 (redraw_garbaged_frames): Remove; unused.
4341
435f4c28
PE
4342 * xfaces.c: Make symbols static if they're not exported.
4343 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4344 Remove decls.
4345 * xterm.h (defined_color): Remove decls.
4346 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4347 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4348 (menu_face_changed_default, defined_color, free_realized_face):
4349 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4350 (ascii_face_of_lisp_face): Remove; unused.
4351
8524aef3
PE
4352 * xdisp.c: Make symbols static if they're not exported.
4353 * dispextern.h (scratch_glyph_row, window_box_edges):
4354 (glyph_to_pixel_coords, set_cursor_from_row):
4355 (get_next_display_element, set_iterator_to_next):
4356 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4357 (show_mouse_face): Remove decls
4358 * frame.h (message_buf_print): Likewise.
4359 * lisp.h (pop_message, set_message, check_point_in_composition):
4360 Likewise.
4361 * xterm.h (set_vertical_scroll_bar): Likewise.
4362 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4363 (message_buf_print, scratch_glyph_row, displayed_buffer):
4364 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4365 (get_next_display_element, show_mouse_face, window_box_edges):
4366 (frame_to_window_pixel_xy, check_point_in_composition):
4367 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4368 (glyph_to_pixel_coords): Remove; unused.
4369
16390cd2
PE
4370 * dired.c (file_name_completion): Now static.
4371
4372 * dbusbind.c (xd_in_read_queued_messages): Now static.
4373
a25f4dfa
PE
4374 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4375 * data.c (circular_list_error): Remove.
4376
14a9c8df
PE
4377 * commands.h (last_point_position, last_point_position_buffer):
4378 (last_point_position_window): Remove decls.
4379 * keyboard.c: Make these variables static.
4380
04f2d78b
CB
4381 * coding.h (coding, code_convert_region, encode_coding_gap):
4382 Remove decls.
74ab6df5
PE
4383 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4384 (iso_code_class, detect_coding, code_convert_region): Now static.
4385 (encode_coding_gap): Remove; unused.
4386
38dfbee1
PE
4387 * chartab.c (chartab_chars, chartab_bits): Now static.
4388
a2cb4e63
PE
4389 * charset.h (charset_iso_8859_1): Remove decl.
4390 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4391 Now static.
4392
127198fd
PE
4393 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4394 * ccl.c (Vccl_program_table): Now static.
4395 (check_ccl_update): Remove; unused.
4396
d85b608f
PE
4397 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4398 * category.h: ... from here.
4399 * category.c (check_category_table, set_category_set): Now static.
4400
31cd66f3
PE
4401 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4402 * lisp.h: Remove these decls.
4403
c358e587
PE
4404 * buffer.c (buffer_count): Remove unused var.
4405
e78aecca
PE
4406 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4407 so that it's not optimized away.
4408 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4409 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4410 exported only to the debugger.
4411
e192d7d3 4412 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4413 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4414
92470028
PE
4415 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4416 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4417 was inaccessible from Lisp.
4418 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4419 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4420
244ed907
PE
4421 alloc.c: Import and export fewer symbols, and remove unused items.
4422 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4423 is defined.
4424 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4425 it's not optimized away by whole-program optimization.
4426 (message_enable_multibyte, free_misc): Remove.
4427 (catchlist, handlerlist, mark_backtrace):
4428 Declare only if BYTE_MARK_STACK.
4429 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4430 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4431 (message_enable_multibyte): Remove decl.
4432 (free_misc, interval_free_list, float_block, float_block_index):
4433 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4434 (cons_free_list, last_marked_index):
4435 Now static.
4436 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4437 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4438 (mark_backtrace): Define only if BYTE_MARK_STACK.
4439 * xdisp.c (message_enable_multibyte): Now static.
4440
61c2b50e 4441 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4442 This makes it easier for human readers (and static analyzers)
4443 to see whether these variables are used from other modules.
4444 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4445 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4446 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4447 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4448 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4449 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4450 * xmenu.c, xselect.c:
4451 Declare Q* vars static if they are not used in other modules.
4452 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4453 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4454 Remove decls of unexported vars.
4455 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4456
95c82688
PE
4457 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4458
16a97296
PE
4459 Make Emacs functions such as Fatom 'static' by default.
4460 This makes it easier for human readers (and static analyzers)
4461 to see whether these functions can be called from other modules.
4462 DEFUN now defines a static function. To make the function external
4463 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4464 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4465 (Finit_image_library):
16a97296
PE
4466 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4467 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4468 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4469 Remove decls, since these functions are now static.
4470 (Funintern, Fget_internal_run_time): New decls, since these functions
4471 were already external.
95c82688 4472
16a97296
PE
4473 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4474 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4475 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4476 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4477 * keyboard.c, keymap.c, lread.c:
4478 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4479 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4480 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4481 Mark functions with DEFUE instead of DEFUN,
4482 if they are used in other modules.
4483 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4484 decls for now-static functions.
4485 * buffer.h (Fdelete_overlay): Remove decl.
4486 * callproc.c (Fgetenv_internal): Mark as internal.
4487 * composite.c (Fremove_list_of_text_properties): Remove decl.
4488 (Fcomposition_get_gstring): New forward static decl.
4489 * composite.h (Fcomposite_get_gstring): Remove decl.
4490 * dired.c (Ffile_attributes): New forward static decl.
4491 * doc.c (Fdocumntation_property): New forward static decl.
4492 * eval.c (Ffetch_bytecode): New forward static decl.
4493 (Funintern): Remove extern decl; now in .h file where it belongs.
4494 * fileio.c (Fmake_symbolic_link): New forward static decl.
4495 * image.c (Finit_image_library): New forward static decl.
4496 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4497 * intervals.h (Fprevious_property_change):
4498 (Fremove_list_of_text_properties): Remove decls.
4499 * keyboard.c (Fthis_command_keys): Remove decl.
4500 (Fcommand_execute): New forward static decl.
4501 * keymap.c (Flookup_key): New forward static decl.
4502 (Fcopy_keymap): Now static.
4503 * keymap.h (Flookup_key): Remove decl.
4504 * process.c (Fget_process): New forward static decl.
4505 (Fprocess_datagram_address): Mark as internal.
4506 * syntax.c (Fsyntax_table_p): New forward static decl.
4507 (skip_chars): Remove duplicate decl.
4508 * textprop.c (Fprevious_property_change): New forward static decl.
4509 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4510 Now internal.
4511 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4512 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4513
785bbd42
PE
4514 * editfns.c (Fformat): Remove unreachable code.
4515
8b913b57
AS
45162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4517
4518 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4519 change. (Bug#8496)
4520
a6744a35
EZ
45212011-04-13 Eli Zaretskii <eliz@gnu.org>
4522
4523 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4524 when at ZV. (Bug#8487)
4525
e7974947
AS
45262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4527
baad03f0
AS
4528 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4529 (Bug#8437)
4530 * keyboard.c (parse_tool_bar_item): Likewise.
4531 * sound.c (sound_cleanup, alsa_close): Likewise.
4532 * termcap.c (tgetent): Likewise.
4533 * xfns.c (x_default_font_parameter): Likewise.
4534 * xsettings.c (read_and_apply_settings): Likewise.
4535
e7974947
AS
4536 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4537 (overrun_check_free): Protoize.
4538
28272684
PE
45392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4540
4541 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4542 since callers should never pass a negative size.
4543 Change the signature to match that of plain 'read' and 'write'; see
4544 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4545 * lisp.h: Update prototypes of emacs_write and emacs_read.
4546
11997c76
EZ
45472011-04-11 Eli Zaretskii <eliz@gnu.org>
4548
4549 * xdisp.c (redisplay_window): Don't try to determine the character
4550 position of the scroll margin if the window start point w->startp
e896f03c 4551 is outside the buffer's accessible region. (Bug#8468)
11997c76 4552
8a2cbd72
EZ
45532011-04-10 Eli Zaretskii <eliz@gnu.org>
4554
4555 Fix write-region and its subroutines for buffers > 2GB.
4556 * fileio.c (a_write, e_write): Modify declaration of arguments and
4557 local variables to support buffers larger than 2GB.
4558 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4559
4560 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4561 argument, local variables, and return value.
4562
4563 * lisp.h: Update prototypes of emacs_write and emacs_read.
4564
4565 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4566
4073e537 45672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4568
1ebfdcb6
PE
4569 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4570
b2ded58d
PE
4571 Fix more problems found by GCC 4.6.0's static checks.
4572
7d66342c
PE
4573 * xdisp.c (vmessage): Use a better test for character truncation.
4574
bbf47d44
PE
4575 * charset.c (load_charset_map): <, not <=, for optimization,
4576 and to avoid potential problems with integer overflow.
9248994d 4577 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4578 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4579 * editfns.c (Fformat): Likewise.
1e69125e 4580 * syntax.c (skip_chars): Likewise.
3befa583 4581
e3019616
PE
4582 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4583 This also lets GCC 4.6.0 generate slightly better loop code.
4584
becfa255
PE
4585 * callint.c (Fcall_interactively): <, not <=, for optimization.
4586 (Fcall_interactively): Count the number of arguments produced,
4587 not the number of arguments given. This is simpler and lets GCC
4588 4.6.0 generate slightly better code.
4589
dae0cd48
PE
4590 * ftfont.c: Distingish more carefully between FcChar8 and char.
4591 The previous code passed unsigned char * to a functions like
4592 strlen and xstrcasecmp that expect char *, which does not
4593 conform to the C standard.
4594 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4595 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4596 char * when the C standard requires it.
4597
76032d70
PE
4598 * keyboard.c (read_char): Remove unused var.
4599
eb3f1cc8
PE
4600 * eval.c: Port to Windows vsnprintf (Bug#8435).
4601 Include <limits.h>.
4602 (SIZE_MAX): Define if the headers do not.
4603 (verror): Do not give up if vsnprintf returns a negative count.
4604 Instead, grow the buffer. This ports to Windows vsnprintf, which
4605 does not conform to C99. Problem reported by Eli Zaretskii.
4606 Also, simplify the allocation scheme, by avoiding the need for
4607 calling realloc, and removing the ALLOCATED variable.
4608
70476b54
PE
4609 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4610
12020a9e
PE
4611 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4612 But keep the doprint source code for now, as we might revamp it
4613 and use it again (Bug#8435).
ea6c7ae6
PE
4614 * lisp.h (doprnt): Remove.
4615 * Makefile.in (base_obj): Remove doprnt.o.
4616 * deps.mk (doprnt.o): Remove.
4617
5fdb398c
PE
4618 error: Print 32- and 64-bit integers portably (Bug#8435).
4619 Without this change, on typical 64-bit hosts error ("...%d...", N)
4620 was used to print both 32- and 64-bit integers N, which relied on
4621 undefined behavior.
4622 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4623 New macro.
4624 * lisp.h (error, verror): Mark as printf-like functions.
4625 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4626 Report overflow in size calculations when allocating printf buffer.
4627 Do not truncate output string at its first null byte.
4628 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4629 Truncate the output at a character boundary, since vsnprintf does not
4630 do that.
4631 * charset.c (check_iso_charset_parameter): Convert internal
4632 character to string before calling 'error', since %c now has the
4633 printf meaning.
4634 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4635 overflow when computing char to be passed to 'error'. Do not
4636 pass Lisp_Object to 'error'; pass the integer instead.
4637 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4638 formatted with plain %d.
4639
b189fa66
PE
4640 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4641
bff87ef0
PE
4642 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4643
7e2cac20
PE
4644 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4645
ce4d90b5
PE
4646 * xterm.c (x_catch_errors): Remove duplicate declaration.
4647
266c9547
PE
4648 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4649
79c49ad2
PE
4650 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4651
368f4090
JM
46522011-04-10 Jim Meyering <meyering@redhat.com>
4653
4654 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4655 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4656 return ssize_t not "int", and use size_t as the buffer length.
4657 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4658 * gnutls.h: Update declarations.
4659 * process.c (read_process_output): Use ssize_t, to match.
4660 (send_process): Likewise.
4661
a32d4040
CY
46622011-04-09 Chong Yidong <cyd@stupidchicken.com>
4663
4664 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4665
8546720e 46662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4667
04f2d78b
CB
4668 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4669 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4670
8546720e
GM
4671 * xterm.c (handle_one_xevent):
4672 * xmenu.c (create_and_show_popup_menu):
4673 * xselect.c (x_decline_selection_request)
4674 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4675
0a2f5c1a 46762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4677
4678 Fix some uses of `int' instead of EMACS_INT.
4679 * search.c (string_match_1, fast_string_match)
4680 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4681 (scan_buffer, find_next_newline_no_quit)
4682 (find_before_next_newline, search_command, Freplace_match)
4683 (Fmatch_data): Make some `int' variables be EMACS_INT.
4684
4685 * xdisp.c (display_count_lines): 3rd argument and return value now
4686 EMACS_INT. All callers changed.
4687 (pint2hrstr): Last argument is now EMACS_INT.
4688
4689 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4690 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4691 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4692 (decode_coding_utf_16, decode_coding_emacs_mule)
4693 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4694 (decode_coding_ccl, decode_coding_charset)
4695 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4696 (decode_coding_iso_2022, decode_coding_emacs_mule)
4697 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4698 <char_offset, last_offset>: Declare EMACS_INT.
4699 (encode_coding_utf_8, encode_coding_utf_16)
4700 (encode_coding_emacs_mule, encode_invocation_designation)
4701 (encode_designation_at_bol, encode_coding_iso_2022)
4702 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4703 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4704 Declare EMACS_INT.
4705 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4706 (encode_invocation_designation): Last argument P_NCHARS is now
4707 EMACS_INT.
4708 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4709 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4710
4711 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4712 All users changed.
4713
4714 * ccl.c (Fccl_execute_on_string): Declare some variables
4715 EMACS_INT.
4716
8546720e 47172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4718
4719 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4720
4e19a977
CS
47212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4722
4723 * process.c (Fformat_network_address): Doc fix.
4724
87302331
R
47252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4726
4727 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4728
cbb59342
CY
47292011-04-08 Chong Yidong <cyd@stupidchicken.com>
4730
4731 * keyboard.c (read_char): Call Lisp function help-form-show,
4732 instead of using internal_with_output_to_temp_buffer.
4733 (Qhelp_form_show): New var.
e0d38eeb 4734 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4735
4736 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4737
4738 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4739
e67a13ab
CY
47402011-04-06 Chong Yidong <cyd@stupidchicken.com>
4741
04f2d78b
CB
4742 * process.c (Flist_processes): Remove to Lisp.
4743 (list_processes_1): Delete.
e67a13ab 4744
973f782d
EZ
47452011-04-06 Eli Zaretskii <eliz@gnu.org>
4746
7c106b1e
EZ
4747 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4748
973f782d
EZ
4749 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4750
41cf7d1a 47512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4752
ca23cc88
PE
4753 Fix more problems found by GCC 4.6.0's static checks.
4754
f390e2d5
PE
4755 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4756
42eea0d0
PE
4757 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4758
b69769da 4759 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4760
f9541e84
PE
4761 * xdisp.c (vmessage): Mark as a printf-like function.
4762
13841b55
PE
4763 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4764
c136c10f
PE
4765 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4766
5e2d4a30
PE
4767 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4768 printf-like functions.
4769 (tiff_load): Add casts to remove these marks before passing them
4770 to system-supplied API.
4771
583f48b9
PE
4772 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4773
b25d760e
PE
4774 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4775 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4776 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4777 directly, rather than having caller test rule sign. This avoids
4778 some unnecessary tests.
4779 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4780 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4781 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4782
bc7b6697 4783 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4784 (xfont_open): Avoid unnecessary tests.
bc7b6697 4785
27ccc379
PE
4786 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4787
dcd5c89a
PE
4788 * composite.h, composite.c (composition_gstring_put_cache):
4789 Use EMACS_INT, not int, for length.
4790
b13a45c6
PE
4791 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4792 breaking out part of COMPOSITION_DECODE_RULE.
4793 (COMPOSITION_DECODE_RULE): Use it.
4794 * composite.c (get_composition_id): Remove unused local vars,
4795 by using the new macro.
4796
1e792e4d
PE
4797 * textprop.c (set_text_properties_1): Change while to do-while,
4798 since the condition is always true at first.
4799
dc6c6455 4800 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4801 (interval_deletion_adjustment): Return unsigned value.
4802 All uses changed.
dc6c6455 4803
aba7731a
PE
4804 * process.c (list_processes_1, create_pty, read_process_output):
4805 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4806 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4807 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4808 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4809 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4810
fdfc4bf3
PE
4811 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4812
fca8fe46 4813 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4814 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4815
06a0259a 4816 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4817 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4818 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4819
e7b9e80f
PE
4820 * print.c (print_error_message): Avoid int overflow.
4821
56201685
PE
4822 * font.c (font_list_entities): Redo for clarity,
4823 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4824
78834453 4825 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4826 (font_score): Avoid potential overflow in diff calculation.
78834453 4827
0bc0b309 4828 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4829 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4830
e610eaca
PE
4831 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4832
b895abce
PE
4833 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4834 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4835 can always succeed if overflow has undefined behavior.
4836
1f1d9321 4837 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4838 (wordify): Omit three unnecessary tests.
1f1d9321 4839
c59478bc
PE
4840 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4841 All callers changed. This avoids the need for an unused var.
4842
79b73827
PE
4843 * casefiddle.c (casify_region): Remove var that is set but not used.
4844
a4db5dfe
PE
4845 * dired.c (file_name_completion): Remove var that is set but not used.
4846
43aae36e
PE
4847 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4848
2a47c44d 4849 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4850 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4851
a37c69bf
PE
4852 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4853 Check for integer overflow on size calculations.
4854
328ab8e7
PE
4855 * buffer.c (Fprevious_overlay_change): Remove var that is set
4856 but not used.
4857
e5a2a5cb
PE
4858 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4859 Remove vars that are set but not used.
8d84a6eb 4860 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4861 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4862
a60e5f68
PE
4863 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4864
f661cb61 4865 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4866 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4867
f0397f5a
PE
4868 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4869 that are set but not used.
4870
8664db06 4871 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4872 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4873
6abdaa4a
PE
4874 * xselect.c (x_get_local_selection, x_handle_property_notify):
4875 Remove vars that are set but not used.
4876
0ce7538d 4877 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4878 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4879
9ae848fc
PE
4880 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4881 Remove var that is set but not used.
0b918413
PE
4882 (scroll_bar_windows_size): Now size_t, not int.
4883 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4884 Check for overflow.
9ae848fc 4885
a5a62657
PE
4886 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4887 (map_tty_color) [!defined MSDOS]: Likewise.
4888
5c5cdd39
PE
4889 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4890
66ebf983
PE
4891 * coding.c: Remove vars that are set but not used.
4892 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4893 All callers changed.
4894 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4895 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4896 (decode_coding_charset): Remove vars that are set but not used.
4897
1be4d761
PE
4898 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4899 that is set but not used.
4900
47553fa8
PE
4901 * print.c (print_object): Remove var that is set but not used.
4902
1f7196bf 4903 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4904 The gnulib version avoids calling malloc in the usual case,
4905 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4906 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4907 * filelock.c (current_lock_owner): Likewise.
4908 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4909 * sysdep.c: Include allocator.h, careadlinkat.h.
4910 (emacs_no_realloc_allocator): New static constant.
4911 (emacs_readlink): New function.
fdb61804
PE
4912 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4913 ../lib/careadlinkat.h.
d1fdcab7 4914
f84c17c7
SM
49152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4916
4917 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4918 first non-nil return value).
4919
ef3862ad
JD
49202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4921
4922 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4923 if not defined (Bug#8403).
4924
376a7006
JB
49252011-04-02 Juanma Barranquero <lekktu@gmail.com>
4926
4927 * xdisp.c (display_count_lines): Remove parameter `start',
4928 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4929 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4930 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4931 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4932 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4933 and thereabouts. All callers changed.
4934 (get_per_char_metric): Remove parameter `f', unused since
4935 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4936
6ca3801d
JM
49372011-04-02 Jim Meyering <meyering@redhat.com>
4938
4939 do not dereference NULL upon failed strdup
4940 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4941 (ns_get_family): Likewise.
4942
d8e2b5ba
JB
49432011-04-02 Juanma Barranquero <lekktu@gmail.com>
4944
4945 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4946
8c74fcbd
JD
49472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4948
4949 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4950 later (Bug#8403).
4951
7200d79c
SM
49522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4953
03408648 4954 Add lexical binding.
7200d79c 4955
03408648
SM
4956 * window.c (Ftemp_output_buffer_show): New fun.
4957 (Fsave_window_excursion):
4958 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4959
4960 * lread.c (lisp_file_lexically_bound_p): New function.
4961 (Fload): Bind Qlexical_binding.
4962 (readevalloop): Remove `evalfun' arg.
4963 Bind Qinternal_interpreter_environment.
4964 (Feval_buffer): Bind Qlexical_binding.
4965 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4966 Mark as dynamic.
4967 (syms_of_lread): Declare `lexical-binding'.
4968
4969 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4970
4971 * keyboard.c (eval_dyn): New fun.
4972 (menu_item_eval_property): Use it.
ca105506
SM
4973
4974 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4975
03408648
SM
4976 * fns.c (concat, mapcar1): Accept byte-code-functions.
4977
4978 * eval.c (Fsetq): Handle lexical vars.
4979 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4980 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4981 (FletX, Flet): Obey lexical binding.
4982 (Fcommandp): Handle closures.
4983 (Feval): New `lexical' arg.
4984 (eval_sub): New function extracted from Feval. Use it almost
4985 everywhere where Feval was used. Look up vars in lexical env.
4986 Handle closures.
4987 (Ffunctionp): Move from subr.el.
4988 (Ffuncall): Handle closures.
4989 (apply_lambda): Remove `eval_flags'.
4990 (funcall_lambda): Handle closures and new byte-code-functions.
4991 (Fspecial_variable_p): New function.
4992 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4993 but without exporting it to Lisp.
23aba0ea 4994
23aba0ea 4995 * doc.c (Fdocumentation, store_function_docstring):
03408648 4996 * data.c (Finteractive_form): Handle closures.
23aba0ea 4997
03408648
SM
4998 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4999 interactive spec.
ba83908c 5000
04f2d78b
CB
5001 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5002 New byte-codes.
03408648
SM
5003 (exec_byte_code): New function extracted from Fbyte_code to handle new
5004 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5005
03408648 5006 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5007
03408648 5008 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5009
e2abce01
JB
50102011-03-31 Juanma Barranquero <lekktu@gmail.com>
5011
5012 * xdisp.c (redisplay_internal): Fix prototype.
5013
63696a73 50142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5015
63696a73 5016 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5017 (try_scrolling): Use it when setting scroll_limit.
5018 Limit scrolling to 100 screen lines.
63696a73
EZ
5019 (redisplay_window): Even when falling back on "recentering",
5020 position point in the window according to scroll-conservatively,
5021 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5022
5023 (try_scrolling): When point is above the window, allow searching
5024 as far as scroll_max, or one screenful, to compute vertical
5025 distance from PT to the scroll margin position. This prevents
5026 try_scrolling from unnecessarily failing when
5027 scroll-conservatively is set to a value slightly larger than the
5028 window height. Clean up the case of PT below the margin at bottom
5029 of window: scroll_max can no longer be INT_MAX. When aggressive
5030 scrolling is in use, don't let point enter the opposite scroll
5031 margin as result of the scroll.
5032 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5033 threshold of 100 lines for never-recentering scrolling.
5034
e4cc2dfc
JB
50352011-03-31 Juanma Barranquero <lekktu@gmail.com>
5036
5037 * dispextern.h (move_it_by_lines):
5038 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5039 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5040 (message_log_check_duplicate): Remove parameters `prev_bol' and
5041 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5042 (redisplay_internal): Remove parameter `preserve_echo_area',
5043 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5044
5045 * indent.c (Fvertical_motion):
5046 * window.c (window_scroll_pixel_based, Frecenter):
5047 Don't pass `need_y_p' to `move_it_by_lines'.
5048
1c470562
SM
50492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5050
44f230aa
SM
5051 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5052 steal a few bits to be more compact.
5053 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5054 Remove unneeded casts.
5055
1c470562
SM
5056 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5057
888adce9
ZK
50582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5059
5060 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5061 binding" message (bug#7967).
5062
f838ed7b
PE
50632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5064
77861b95
PE
5065 Fix more problems found by GCC 4.6.0's static checks.
5066
de6dbc14
PE
5067 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5068 Remove unused local var.
5069
f838ed7b
PE
5070 * editfns.c (Fmessage_box): Remove unused local var.
5071
792c7b2b
PE
5072 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5073 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5074 Omit unused local vars.
c499e557 5075 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5076 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5077 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5078 Omit unused local var.
5079
ba0165e1
PE
5080 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5081 Don't assume string length fits in int.
32ad8845 5082 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5083 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5084
3c59b4c9
PE
5085 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5086 instead of alloca (Bug#8344).
5087
a3eed478 5088 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5089 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5090
eb4d412d
PE
5091 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5092
1658b401
PE
5093 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5094 concerns.
5095
5096 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5097
5098 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5099
9a2c6e05
PE
5100 * keyboard.c (syms_of_keyboard): Use the same style as later
5101 in this function when indexing through an array. This also
5102 works around GCC bug 48267.
5103
03d0a109
PE
5104 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5105
44f730c8
PE
5106 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5107
fe75f926
PE
5108 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5109 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5110
ffa8c828
PE
5111 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5112 This avoids undefined behavior on integer overflow, and is a bit
5113 more convenient anyway since it is compared to a size_t variable.
5114
c5101a77
PE
5115 Variadic C functions now count arguments with size_t, not int.
5116 This avoids an unnecessary limitation on 64-bit machines, which
5117 caused (substring ...) to crash on large vectors (Bug#8344).
5118 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5119 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5120 All variadic functions and their callers changed accordingly.
c5101a77
PE
5121 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5122 * data.c (arith_driver, float_arith_driver): Likewise.
5123 * editfns.c (general_insert_function): Likewise.
5124 * eval.c (struct backtrace.nargs, interactive_p)
5125 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5126 (funcall_lambda, mark_backtrace): Likewise.
5127 * fns.c (concat): Likewise.
5128 * frame.c (x_set_frame_parameters): Likewise.
5129 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5130 0 if not found, not -1. All callers changed.
5131
dd3f25f7
PE
5132 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5133 (stack_copy_size): Now size_t, not int.
5134 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5135
461c2ab9
JB
51362011-03-28 Juanma Barranquero <lekktu@gmail.com>
5137
5138 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5139 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5140 All callers changed.
5141
5142 * lisp.h (multibyte_char_to_unibyte):
5143 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5144 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5145 * character.h (CHAR_TO_BYTE8):
5146 * cmds.c (internal_self_insert):
5147 * editfns.c (general_insert_function):
5148 * keymap.c (push_key_description):
5149 * search.c (Freplace_match):
5150 * xdisp.c (message_dolog, set_message_1): All callers changed.
5151
f6d62986
SM
51522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5153
5154 * keyboard.c (safe_run_hook_funcall): New function.
5155 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5156 don't set the hook to nil, but remove the offending function instead.
5157 (Qcommand_hook_internal): Remove, unused.
5158 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5159 Vcommand_hook_internal.
5160
5161 * eval.c (enum run_hooks_condition): Remove.
5162 (funcall_nil, funcall_not): New functions.
5163 (run_hook_with_args): Call each function through a `funcall' argument.
5164 Remove `cond' argument, now redundant.
5165 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5166 (Frun_hook_with_args_until_failure): Adjust accordingly.
5167 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5168
1db5b1ad
JB
51692011-03-28 Juanma Barranquero <lekktu@gmail.com>
5170
5171 * dispextern.h (string_buffer_position): Remove declaration.
5172
5173 * print.c (strout): Remove parameter `multibyte', unused since
5174 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5175
5176 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5177 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5178 All callers changed.
5179
5180 * w32.c (_wsa_errlist): Use braces for struct initializers.
5181
5182 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5183 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5184 All callers changed.
5185 (string_buffer_position): Likewise. Also, make static (it's never
5186 used outside xdisp.c).
5187 (cursor_row_p): Remove parameter `w', unused since
5188 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5189 (decode_mode_spec): Remove parameter `precision', introduced during
5190 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5191 All callers changed.
5192
5ffb62aa
JD
51932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5194
5195 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5196
461c2ab9 51972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5198
5199 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5200 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5201 (ns_update_auto_hide_menu_bar): New functions.
5202 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5203 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5204 ns_constrain_all_frames.
5205 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5206 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5207
5c380ffb
JD
52082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5209
5210 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5211
9af30bdf
GM
52122011-03-27 Glenn Morris <rgm@gnu.org>
5213
5214 * syssignal.h: Replace RETSIGTYPE with void.
5215 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5216 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5217 Replace SIGTYPE with void everywhere.
5218 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5219 * s/template.h (SIGTYPE): Remove commented out definition.
5220
e2abce01
JB
52212011-03-26 Eli Zaretskii <eliz@gnu.org>
5222
5223 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5224 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5225
f868cd8a
JB
52262011-03-26 Juanma Barranquero <lekktu@gmail.com>
5227
59eb0929
JB
5228 * w32.c (read_unc_volume): Use parameter `henum', instead of
5229 global variable `wget_enum_handle'.
5230
5231 * keymap.c (describe_vector): Remove parameters `indices' and
5232 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5233 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5234
f868cd8a
JB
5235 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5236
5237 * keyboard.c (timer_check): Remove parameter `do_it_now',
5238 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5239 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5240 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5241
5242 * keyboard.c (read_char):
5243 * w32menu.c (w32_menu_display_help):
5244 * xmenu.c (show_help_event, menu_help_callback):
5245 Adjust calls to `show_help_echo'.
5246
5247 * gtkutil.c (xg_maybe_add_timer):
5248 * keyboard.c (readable_events):
5249 * process.c (wait_reading_process_output):
5250 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5251
5252 * insdel.c (adjust_markers_gap_motion):
5253 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5254 (gap_left, gap_right): Don't call it.
5255
2ecf6fdb
CY
52562011-03-25 Chong Yidong <cyd@stupidchicken.com>
5257
5258 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5259 incurred during fontification.
5260
6b1f9ba4
JB
52612011-03-25 Juanma Barranquero <lekktu@gmail.com>
5262
5263 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5264 (DEFVAR_PER_BUFFER): Don't pass it.
5265
5266 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5267 (scrolling_window): Don't pass it.
5268
0f4a96b5
JB
52692011-03-25 Juanma Barranquero <lekktu@gmail.com>
5270
5271 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5272
5273 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5274 and `suffix'.
5275 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5276 of variables specific to SELinux and computation of `encoded_absname'.
5277
5278 * image.c (XPutPixel): Remove unused variable `height'.
5279
5280 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5281
5282 * unexw32.c (get_section_info): Remove unused variable `section'.
5283
5284 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5285 (system_process_attributes): Remove unused variable `sess'.
5286 (sys_read): Remove unused variable `err'.
5287
5288 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5289 (w32_wnd_proc): Remove unused variable `isdead'.
5290 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5291 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5292 (x_create_tip_frame): Remove unused variable `tem'.
5293
5294 * w32inevt.c (w32_console_read_socket):
5295 Remove unused variable `no_events'.
5296
5297 * w32term.c (x_draw_composite_glyph_string_foreground):
5298 Remove unused variable `width'.
5299
1149507c
JB
53002011-03-24 Juanma Barranquero <lekktu@gmail.com>
5301
5302 * w32term.c (x_set_glyph_string_clipping):
5303 Don't pass uninitialized region to CombineRgn.
5304
9c88f339
JB
53052011-03-23 Juanma Barranquero <lekktu@gmail.com>
5306
5307 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5308 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5309 (Fx_close_connection): Remove unused variable `i'.
5310
5311 * w32font.c (w32font_draw): Return number of glyphs.
5312 (w32font_open_internal): Remove unused variable `i'.
5313 (w32font_driver): Add missing initializer.
5314
5315 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5316 (fill_in_menu): Remove unused variable `items_added'.
5317
5318 * w32term.c (last_mouse_press_frame): Remove static global variable.
5319 (w32_clip_to_row): Remove unused variable `f'.
5320 (x_delete_terminal): Remove unused variable `i'.
5321
5322 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5323 (NOTHING): Remove unused static global variable.
5324 (uniscribe_check_otf): Remove unused variable `table'.
5325 (uniscribe_font_driver): Add missing initializers.
5326
dee091a3
JD
53272011-03-23 Julien Danjou <julien@danjou.info>
5328
5329 * term.c (Fsuspend_tty, Fresume_tty):
5330 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5331 * window.c (temp_output_buffer_show):
5332 * insdel.c (signal_before_change):
5333 * frame.c (Fhandle_switch_frame):
5334 * fileio.c (Fdo_auto_save):
5335 * emacs.c (Fkill_emacs):
5336 * editfns.c (save_excursion_restore):
5337 * cmds.c (internal_self_insert):
5338 * callint.c (Fcall_interactively):
5339 * buffer.c (Fkill_all_local_variables):
5340 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5341 Use Frun_hooks.
0f4a96b5 5342 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5343 unconditionnaly since it does the check itself.
5344
2c520ab5 53452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5346
c9c49752
PE
5347 Fix more problems found by GCC 4.5.2's static checks.
5348
8abc3f12
PE
5349 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5350 the first time through the loop, since we know p0 < p1 then.
5351 This also avoids a gcc -Wstrict-overflow warning.
5352
a2d26660
PE
5353 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5354 leading to a memory leak, possible in functions like
5355 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5356 of objects (Bug#8318).
a2d26660 5357
916c72e9
PE
5358 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5359 that could (at least in theory) be that large.
5360
19ab8a18
PE
5361 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5362 This is less likely to overflow, and avoids undefined behavior if
5363 overflow does occur. All callers changed. Use strtoul to scan
5364 for the unsigned long integer.
b7cbbd6f
PE
5365 (pint2hrstr): Simplify and tune code slightly.
5366 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5367
f0641eff
PE
5368 * scroll.c (do_scrolling): Work around GCC bug 48228.
5369 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5370
7f650bb9
PE
5371 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5372 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5373 (validate_x_resource_name): Simplify count usage.
5374 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5375
37dd57d1
PE
5376 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5377 fail (Bug#8306).
81e56e61 5378
699979fc 5379 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5380
401bf9b4
PE
5381 * process.c (Fmake_network_process): Use socklen_t, not int,
5382 where POSIX says socklen_t is required in portable programs.
5383 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5384 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5385 (Fmake_network_process, server_accept_connection):
5386 (wait_reading_process_output, read_process_output):
5387 Likewise.
5388
b93aacde
PE
5389 * process.c: Rename or move locals to avoid shadowing.
5390 (list_processes_1, Fmake_network_process):
5391 (read_process_output_error_handler, exec_sentinel_error_handler):
5392 Rename or move locals.
4dc343ee 5393 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5394 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5395 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5396 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5397 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5398
af8a867c 5399 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5400 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5401 Include tparam.h instead, since it declares them.
af8a867c
PE
5402 * cm.h (PC): Remove extern decl; tparam.h now does this.
5403 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5404 * terminfo.c: Include tparam.h, to check interfaces.
5405 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5406 (tparam): Adjust signature to match interface in tparam.h;
5407 this removes some undefined behavior. Check that outstring and len
5408 are zero, which they always are with Emacs.
5409 * tparam.h (PC, BC, UP): New extern decls.
5410
0248044d 5411 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5412 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5413
8ff096c1 5414 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5415 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5416 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5417 (ftfont_list): Remove unused local.
49eaafba
PE
5418 (get_adstyle_property, ftfont_pattern_entity):
5419 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5420 Rename locals to avoid shadowing.
8ff096c1 5421
e2be39f6
PE
5422 * xfont.c (xfont_list_family): Mark var as initialized.
5423
c9735e30
PE
5424 * xml.c (make_dom): Now static.
5425
8f5201ae
PE
5426 * composite.c (composition_compute_stop_pos): Rename local to
5427 avoid shadowing.
b246f932
PE
5428 (composition_reseat_it): Remove unused locals.
5429 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5430 (composition_update_it): Mark var as initialized.
11b61122
PE
5431 (find_automatic_composition): Mark vars as initialized,
5432 with a FIXME (Bug#8290).
8f5201ae 5433
760fbc2c
PE
5434 character.h: Rename locals to avoid shadowing.
5435 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5436 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5437 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5438 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5439 to avoid shadowing.
5440
ff08eb85
PE
5441 * textprop.c (property_change_between_p): Remove; unused.
5442
fc7bf025
PE
5443 * intervals.c (interval_start_pos): Now static.
5444
235d7abc
PE
5445 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5446
44f230aa
SM
5447 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5448 Rename locals to avoid shadowing.
3e7d6594 5449
50060332
PE
5450 * sound.c (wav_play, au_play, Fplay_sound_internal):
5451 Fix pointer signedness.
d01f234b 5452 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5453 (wav_play): Initialize a variable to 0, to prevent undefined
5454 behavior (Bug#8278).
50060332 5455
c4fc4e30
PE
5456 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5457
918436ed
PE
5458 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5459
c939f91b
PE
5460 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5461 clobbering (Bug#8298).
b9c7f648
PE
5462 * sysdep.c (sys_subshell): Likewise.
5463 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5464
6bd8c144
PE
5465 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5466 This should get cleaned up, so that child_setup has the
5467 same signature on all platforms.
5468
7710357c 5469 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5470 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5471
c59da222
CY
54722011-03-22 Chong Yidong <cyd@stupidchicken.com>
5473
5474 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5475 not to be necessary, and produces flickering.
5476
66b87493
GM
54772011-03-20 Glenn Morris <rgm@gnu.org>
5478
5479 * config.in: Remove file.
5480
45b6f6d5
JB
54812011-03-20 Juanma Barranquero <lekktu@gmail.com>
5482
5483 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5484 are now in src/globals.h.
5485 (syms_of_minibuf): Remove spurious & from previous change.
5486
3ec03f7e
LL
54872011-03-20 Leo <sdl.web@gmail.com>
5488
5489 * minibuf.c (completing-read-function): New variable.
5490 (completing-read-default): Rename from completing-read.
5491 (completing-read): Call completing-read-function.
5492
b14e3e21
CY
54932011-03-19 Juanma Barranquero <lekktu@gmail.com>
5494
5495 * xfaces.c (Fx_load_color_file):
5496 Read color file from absolute filename (bug#8250).
5497
f2b726e6
JB
54982011-03-19 Juanma Barranquero <lekktu@gmail.com>
5499
5500 * makefile.w32-in: Update dependencies.
5501
09f6ff02
EZ
55022011-03-17 Eli Zaretskii <eliz@gnu.org>
5503
5504 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5505
29a6015a
PE
55062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5507
a3a6c54e
PE
5508 Fix more problems found by GCC 4.5.2's static checks.
5509
b766f867
PE
5510 * process.c (make_serial_process_unwind, send_process_trap):
5511 (sigchld_handler): Now static.
5512
be02381c
PE
5513 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5514 That way, the code declares only the vars that it needs.
5515 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5516 * s/cygwin.h (PTY_ITERATION): Likewise.
5517 * s/darwin.h (PTY_ITERATION): Likewise.
5518 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5519
57048744
PE
5520 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5521 * process.c (allocate_pty): Don't declare stb unless it's needed.
5522
7914961c 5523 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5524 (CONSTANTLIM): Remove; unused.
5525 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5526 Define only if needed.
7914961c 5527
b3967b18
PE
5528 * unexelf.c (unexec): Name an expression,
5529 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5530 Use a different way to cause a compilation error if anyone uses
5531 n rather than nn, a way that does not involve shadowing.
73366a00 5532 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5533
29a6015a
PE
5534 * deps.mk (unexalpha.o): Remove; unused.
5535
43cfc33e 5536 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5537 * unexec.h: New file.
ce701a33
PE
5538 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5539 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5540 Depend on unexec.h.
5541 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5542 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5543 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5544 Change as necessary to match prototype in unexec.h.
ce701a33 5545
01f44d5a
PE
5546 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5547 shadowing.
4f63c6bb 5548 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5549
a6670b0b
PE
5550 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5551 Rename locals to avoid shadowing.
5552
cef2010d 5553 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5554 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5555
d4d7173a
PE
5556 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5557
f08b802a
PE
5558 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5559 warning when compiling print.c.
5560
3ddb0639
PE
5561 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5562 instead of using an uninitialized var.
5ad03b97 5563 (font_sort_entities): Mark var as initialized.
3ddb0639 5564
170a2692
PE
5565 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5566
e663c700
PE
5567 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5568 pointers to constants.
89bc529a 5569 (font_parse_fcname): Remove unused vars.
7b81e2d0 5570 (font_delete_unmatched): Now static.
ea838e10 5571 (font_get_spec): Remove; unused.
13a547c6
PE
5572 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5573 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5574 Rename or move locals to avoid shadowing.
e663c700 5575
2a80c887 5576 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5577 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5578
1384fa33 5579 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5580 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5581
8b2c52e9
PE
5582 * alloc.c (mark_backtrace): Move decl from here ...
5583 * lisp.h: ... to here, so that it can be checked.
5584
475545b5 5585 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5586 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5587 (lisp_indirect_variable): Name an expression,
5588 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5589 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5590
b1349114 5591 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5592 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5593 Use const pointer when appropriate.
b1349114 5594
a2928364
PE
5595 * lisp.h (get_system_name, get_operating_system_release):
5596 Move decls here, to check interfaces.
5597 * process.c (get_operating_system_release): Move decl to lisp.h.
5598 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5599 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5600 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5601 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5602 (Fformat_time_string, Fencode_time, Finsert_char):
5603 (Ftranslate_region_internal, Fformat):
5604 Rename or remove local vars to avoid shadowing.
9710023e 5605 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5606
a415e694
PE
5607 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5608 avoid shadowing.
5609
8ef4622d
PE
5610 * lisp.h (eassert): Check that the argument compiles, even if
5611 ENABLE_CHECKING is not defined.
5612
946f9a5b
PE
5613 * data.c (Findirect_variable): Name an expression, to avoid
5614 gcc -Wbad-function-cast warning.
112396d6 5615 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5616 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5617 (Fmake_variable_buffer_local, Fmake_local_variable):
5618 Mark variables as initialized.
52746918 5619 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5620
e5aab7e7 5621 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5622 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5623 Rename locals to avoid shadowing.
dff45157
PE
5624 (mark_stack): Move local variables into the #ifdef region where
5625 they're used.
7bc26fdb
PE
5626 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5627 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5628 needed otherwise.
5629 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5630 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5631 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5632
e5aab7e7
PE
5633 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5634 avoids undefined behavior in theory.
5635
4da60324
PE
5636 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5637
88043301
PE
5638 Use functions, not macros, for up- and down-casing (Bug#8254).
5639 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5640 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5641 to use the following functions instead of these macros.
5642 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5643 EMACS_INT, since callers assume the returned value fits in int.
5644 (upcase1): Likewise, for UPCASE_TABLE.
5645 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5646 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5647 the race-condition problem in the old DOWNCASE.
88043301 5648
19ed5445
PE
5649 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5650 Rename locals to avoid shadowing.
5651 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5652 (regex_compile, re_search_2, re_match_2_internal):
5653 Remove unused local vars.
952db0d7
PE
5654 (FREE_VAR): Rewrite so as not to use empty "else",
5655 which gcc can warn about.
da053e48 5656 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5657 (RETALLOC_IF): Define only if needed.
5658 (WORDCHAR_P): Likewise. This one is never needed, but is used
5659 only in a comment talking about a compiler bug, so put inside
5660 the #if 0 of that comment.
5661 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5662 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5663 Remove; unused.
19ed5445 5664
1f3561e4 5665 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5666 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5667 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5668
ded6f8f7
PE
5669 * search.c (simple_search): Remove unused var.
5670
dbd37a95
PE
5671 * dired.c (compile_pattern): Move decl from here ...
5672 * lisp.h: ... to here, so that it can be checked.
5673 (struct re_registers): New forward decl.
5674
7e47afad
PE
5675 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5676
85f24f61
PE
5677 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5678 All uses changed.
5679 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5680 Rename locals to avoid shadowing.
5671df8f 5681 (Fvertical_motion): Mark locals as initialized.
85f24f61 5682
181aa2be 5683 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5684 (casify_region): Mark local as initialized.
181aa2be 5685
930d429c
PE
5686 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5687
7082eac6
PE
5688 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5689 New macros, so that the caller can use some names other than
5690 gcpro1, gcpro2, etc.
5691 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5692 of the new macros.
5693 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5694 argument, for consistency with GCPRO2_VAR, etc: it is now the
5695 prefix of the variable, not the variable itself. All uses
5696 changed.
38b2c076
PE
5697 * dired.c (directory_files_internal, file_name_completion):
5698 Rename locals to avoid shadowing.
5699
15206ed9
PE
5700 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5701 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5702 dired.c's scmp function, had undefined behavior.
5703 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5704 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5705 * buffer.h: ... to here, because these macros use current_buffer,
5706 and the new implementation with inline functions needs to have
5707 current_buffer in scope now, rather than later when the macros
5708 are used.
5709 (downcase, upcase1): New static inline functions.
5710 (DOWNCASE, UPCASE1): Reimplement using these functions.
5711 This avoids undefined behavior in expressions like
5712 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5713 from race conditions in accessing the global variables
5714 case_temp1 and case_temp2.
5715 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5716 * lisp.h (case_temp1, case_temp2): Remove their decls.
5717 * character.h (ASCII_CHAR_P): Move from here ...
5718 * lisp.h: ... to here, so that the inline functions mentioned
5719 above can use them.
5720
4a6bea26
PE
5721 * dired.c (directory_files_internal_unwind): Now static.
5722
f14b7e14
PE
5723 * fileio.c (file_name_as_directory, directory_file_name):
5724 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5725 Now static.
2893f146
PE
5726 (file_name_as_directory): Use const pointers when appropriate.
5727 (Fexpand_file_name): Likewise. In particular, newdir might
5728 point at constant storage, so make it a const pointer.
fd4ead52 5729 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5730 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5731 signedness issues.
f839df0c
PE
5732 (Fset_file_times, Finsert_file_contents, auto_save_error):
5733 Rename locals to avoid shadowing.
f14b7e14 5734
5716756e 5735 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5736 (Ftry_completion, Fall_completions): Rename or remove locals
5737 to avoid shadowing.
5716756e 5738
b4c3046a
PE
5739 * marker.c (bytepos_to_charpos): Remove; unused.
5740
b45db522
PE
5741 * lisp.h (verify_bytepos, count_markers): New decls,
5742 so that gcc does not warn that these functions aren't declared.
5743
85876d07
PE
5744 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5745 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5746 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5747 (copy_text): Remove unused local var.
85876d07 5748
03d78a21 5749 * filelock.c (within_one_second): Now static.
b3dd38ab 5750 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5751
5df8f01b
PE
5752 * buffer.c (fix_overlays_before): Mark locals as initialized.
5753 (fix_start_end_in_overlays): Likewise. This function should be
5754 simplified by using pointers-to-pointers, but that's a different
5755 matter.
b1d876f1 5756 (switch_to_buffer_1): Now static.
8f54f30a
PE
5757 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5758 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5759
a70072c9 5760 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5761 Fix pointer signedness issue.
edced198
PE
5762 (sys_subshell): Mark local as volatile if checking for lint,
5763 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5764 (MAXPATHLEN): Define only if needed.
a70072c9 5765
a0977c44
PE
5766 * process.c (serial_open, serial_configure): Move decls from here ...
5767 * systty.h: ... to here, so that they can be checked.
5768
a884fdcc
PE
5769 * fns.c (get_random, seed_random): Move extern decls from here ...
5770 * lisp.h: ... to here, so that they can be checked.
5771
604efe86 5772 * sysdep.c (reset_io): Now static.
b8950c94 5773 (wait_for_termination_signal): Remove; unused.
604efe86 5774
38fc62d9
PE
5775 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5776 (copy_keymap_item, append_key, push_text_char_description):
5777 Now static.
1004a21a 5778 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5779 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5780 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5781 (describe_map_tree):
5782 Rename locals to avoid shadowing.
38fc62d9 5783
2f2650da
PE
5784 * keyboard.c: Declare functions static if they are not used elsewhere.
5785 (echo_char, echo_dash, cmd_error, top_level_2):
5786 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5787 (read_char, kbd_buffer_get_event, make_lispy_position):
5788 (make_lispy_event, make_lispy_movement, apply_modifiers):
5789 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5790 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5791 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5792 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5793 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5794
a053e86c 5795 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5796 (mark_kboards): Move decl here ...
5797 * alloc.c (mark_kboards): ... from here.
a053e86c 5798
4752793e
PE
5799 * lisp.h (force_auto_save_soon): New decl.
5800
74f10ca7 5801 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5802 (DEFINE_DUMMY_FUNCTION): New macro.
5803 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5804 Use it.
c03cd23f
PE
5805 (main): Add casts to avoid warnings
5806 if GCC considers string literals to be constants.
74f10ca7 5807
022e70d4
PE
5808 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5809
59d6fe83
PE
5810 * dbusbind.c: Pointer signedness fixes.
5811 (xd_signature, xd_append_arg, xd_initialize):
5812 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5813 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5814 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5815 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5816
78320123
PE
5817 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5818 if GCC considers string literals to be constants.
49cebcca 5819 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5820
35ac2a97
SM
58212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5822
fb103ca9
SM
5823 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5824 (print_preprocess, print_object): New macro to fix last change.
5825
35ac2a97
SM
5826 * print.c (print_preprocess): Don't forget font objects.
5827
62973b41
JB
58282011-03-16 Juanma Barranquero <lekktu@gmail.com>
5829
5830 * emacs.c (USAGE3): Doc fixes.
5831
0e48bb22
AS
58322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5833
5834 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5835 structure.
5836
7684e57b
JB
58372011-03-14 Juanma Barranquero <lekktu@gmail.com>
5838
5839 * lisp.h (VWindow_system, Qfile_name_history):
5840 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5841 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5842 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5843
5844 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5845 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5846
5847 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5848 * w32console.c (detect_input_pending, read_input_pending)
5849 (encode_terminal_code):
5850 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5851 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5852 (w32_system_caret_y, Qfile_name_history):
5853 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5854 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5855 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5856 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5857 * w32proc.c (Qlocal, report_file_error):
5858 * w32term.c (Vwindow_system, updating_frame):
5859 * w32uniscribe.c (initialized, uniscribe_font_driver):
5860 Remove unneeded extern declarations.
5861
2aa46d6c
CY
58622011-03-14 Chong Yidong <cyd@stupidchicken.com>
5863
c96bbc66 5864 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5865
cffc6f3b
CY
58662011-03-13 Chong Yidong <cyd@stupidchicken.com>
5867
5868 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5869 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5870 These macros can no longer be used for assignment.
5871
44f230aa
SM
5872 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5873 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5874 (record_buffer_markers, fetch_buffer_markers): New functions for
5875 recording and fetching special buffer markers.
5876 (set_buffer_internal_1, set_buffer_temp): Use them.
5877
5878 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5879
5880 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5881
5882 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5883 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5884
5885 * xdisp.c (hscroll_window_tree):
5886 (reconsider_clip_changes): Use PT instead of BUF_PT.
5887
d251f04b
EZ
58882011-03-13 Eli Zaretskii <eliz@gnu.org>
5889
5890 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5891 $(EMACS_ROOT)/lib/intprops.h.
5892
f0c77cd1
PE
58932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5894
3eca4629
PE
5895 Fix more problems found by GCC 4.5.2's static checks.
5896
7c86ee98
PE
5897 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5898 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5899 (xg_free_frame_widgets): Make it clear that a local variable is
5900 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5901 (gdk_window_get_screen): Make it clear that this macro is needed
5902 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5903 (int_gtk_range_get_value): New function, which avoids a diagnostic
5904 from gcc -Wbad-function-cast.
5905 (xg_set_toolkit_scroll_bar_thumb): Use it.
5906 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5907 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5908 (get_utf8_string, xg_get_file_with_chooser):
5909 Rename locals to avoid shadowing.
5910 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5911
41729b81
PE
5912 * xgselect.c (xg_select): Remove unused var.
5913
f0c77cd1
PE
5914 * image.c (four_corners_best): Mark locals as initialized.
5915 (gif_load): Initialize transparent_p to zero (Bug#8238).
5916 Mark another local as initialized.
ec6cf4c6 5917 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5918
ce0ad53d 5919 * image.c (clear_image_cache): Now static.
d5d5a617 5920 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5921 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5922 (x_edge_detection): Remove unnecessary cast that
5923 gcc -Wbad-function-cast diagnoses.
2037898d 5924 (gif_load): Fix pointer signedness.
6ae141d6
PE
5925 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5926 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5927
33383987 59282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5929
d32df629
PE
5930 Improve quality of tests for time stamp overflow.
5931 For example, without this patch (encode-time 0 0 0 1 1
5932 1152921504606846976) returns the obviously-bogus value (-948597
5933 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5934 reports time overflow. See
5935 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5936 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5937 * editfns.c: Include limits.h and intprops.h.
5938 (TIME_T_MIN, TIME_T_MAX): New macros.
5939 (time_overflow): Move earlier, to before first use.
5940 (hi_time, lo_time): New functions, for an accurate test for
5941 out-of-range times.
5942 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5943 (Fget_internal_run_time): Don't assume time_t fits in int.
5944 (make_time): Use list2 instead of Fcons twice.
5945 (Fdecode_time): More accurate test for out-of-range times.
5946 (check_tm_member): New function.
5947 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5948 (lisp_time_argument): Don't rely on undefined left-shift and
5949 right-shift behavior when checking for time stamp overflow.
8be6f318 5950
fe31d94c
PE
5951 * editfns.c (time_overflow): New function, refactoring common code.
5952 (Fformat_time_string, Fdecode_time, Fencode_time):
5953 (Fcurrent_time_string): Use it.
5954
8be6f318
PE
5955 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5956 * dired.c (make_time): Move to ...
5957 * editfns.c (make_time): ... here.
5958 * systime.h: Note the move.
5959
09d9db2c 59602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5961
126bc0dc
YM
5962 * fringe.c (update_window_fringes): Remove unused variables.
5963
c47cbdfd
YM
5964 * unexmacosx.c (copy_data_segment): Also copy __got section.
5965 (Bug#8223)
5966
7ac80be9
EZ
59672011-03-12 Eli Zaretskii <eliz@gnu.org>
5968
c96bbc66 5969 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5970 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5971 Constify `char *' arguments and their references according to
5972 prototypes in tparam.h.
5973
ecb0f94d 5974 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5975
7ac80be9
EZ
5976 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5977 Adapt all references accordingly.
5978
5979 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5980
ef1fd07e
TT
59812011-03-11 Tom Tromey <tromey@redhat.com>
5982
5983 * buffer.c (syms_of_buffer): Remove obsolete comment.
5984
7ef4b50c
EZ
59852011-03-11 Eli Zaretskii <eliz@gnu.org>
5986
5987 * termhooks.h (encode_terminal_code): Declare prototype.
5988
5989 * msdos.c (encode_terminal_code): Don't declare prototype.
5990
5991 * term.c (encode_terminal_code): Now external again, used by
5992 w32console.c and msdos.c.
5993
44f230aa
SM
5994 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5995 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5996
4b1ec863 59972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5998
1714f52b 5999 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6000
4b1ec863
PE
6001 * fringe.c (update_window_fringes): Mark locals as initialized
6002 (Bug#8227).
6003 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6004
524c7aa6
PE
6005 * alloc.c (mark_fringe_data): Move decl from here ...
6006 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6007 to check its interface.
6008 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6009
a5c0af81 6010 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6011 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6012 (fontset_font): Mark local as initialized.
a9a06e0b 6013 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6014
b4716021
PE
6015 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6016
811e9bac 6017 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6018 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6019 (x_own_selection, Fx_disown_selection_internal): Rename locals
6020 to avoid shadowing.
6021 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6022
7e3ab302
PE
6023 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6024 so that the caller can use some name other than gcpro1.
6025 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6026 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6027 (Fx_backspace_delete_keys_p):
6028 Use them to avoid shadowing, and rename vars to avoid shadowing.
6029 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6030 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6031 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6032 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6033 Remove unused locals.
7e3ab302
PE
6034 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6035 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6036 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6037 macros.
f78faa98 6038
e2b13473
PE
6039 * xterm.h (x_mouse_leave): New decl.
6040
77f23912
PE
6041 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6042 Remove unused functions.
cdf4ba58
PE
6043 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6044 (x_calc_absolute_position): Now static.
7411c686 6045 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6046 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6047 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6048 unless they are used.
38d0b34a
PE
6049 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6050 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6051 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6052 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6053 (x_error_catcher, x_connection_closed, x_error_handler):
6054 (x_error_quitter, xembed_send_message, x_iconify_frame):
6055 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6056 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6057 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6058
44f230aa
SM
6059 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6060 Rename or move locals to avoid shadowing.
6b463e58 6061 (tty_defined_color, merge_face_heights): Now static.
5967d051 6062 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6063 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6064 does not deduce is never used uninitialized.
73719eba
PE
6065 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6066 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6067
426994c3 6068 * terminal.c (store_terminal_param): Now static.
5489860b 6069
032f1620 6070 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6071 (set_frame_menubar): Remove unused local.
d4323972 6072 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6073 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6074 since they might point to immutable storage.
281585b0
PE
6075 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6076 since it's unused otherwise.
032f1620 6077
367c19e5 6078 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6079 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6080 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6081 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6082 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6083 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6084 does not deduce are never used uninitialized.
70739cbe 6085
07b48fa9
PE
6086 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6087
8868a238 6088 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6089 * window.c (window_loop, size_window):
6090 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6091
7e5cf297 6092 * window.c (display_buffer): Now static.
d6550a9f
PE
6093 (size_window): Mark variables that gcc -Wuninitialized
6094 does not deduce are never used uninitialized.
a586633d
PE
6095 * window.h (check_all_windows): New decl, to forestall
6096 gcc -Wmissing-prototypes diagnostic.
5b555da1 6097 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6098
f6095868
PE
6099 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6100 shadowing.
6101 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6102 Include <limits.h>.
6103 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6104 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6105 (load_charset_map): Mark variables that gcc -Wuninitialized
6106 does not deduce are never used uninitialized.
53df7c11 6107 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6108
f38b440c
PE
6109 * coding.c (coding_set_source, coding_set_destination):
6110 Use "else { /* comment */ }" rather than "else /* comment */;"
6111 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6112 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6113 a block, when the outer 'i' will do.
6114 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6115 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6116 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6117 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6118 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6119 Rename locals to avoid shadowing.
6120 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6121 * coding.c (emacs_mule_char, encode_invocation_designation):
6122 Now static, since they're not used elsewhere.
413bb2db 6123 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6124 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6125 (decode_coding_emacs_mule): Mark variables that gcc
6126 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6127 (detect_coding_iso_2022): Initialize a local variable that might
6128 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6129 this initialization is needed. (Bug#8211)
5f58e762
PE
6130 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6131 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6132 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6133 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6134 Remove unused macros.
f38b440c 6135
232b38b9 6136 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6137 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6138 * character.c (string_count_byte8): Likewise.
232b38b9 6139
fb90da1b
PE
6140 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6141 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6142
fb93dbc2
PE
6143 * chartab.c (copy_sub_char_table): Now static, since it's not used
6144 elsewhere.
5c156ace
PE
6145 (sub_char_table_ref_and_range, char_table_ref_and_range):
6146 Rename locals to avoid shadowing.
bbcd0949 6147 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6148
7d3b3862 6149 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6150 (BIDI_BOB): Remove unused macro.
7d3b3862 6151
6be7d3da
PE
6152 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6153 deduce are never used uninitialized.
c2ed9c8b 6154 * term.c (encode_terminal_code): Likewise.
6be7d3da 6155
75f8807f 6156 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6157
50938595
PE
6158 * tparam.h: New file.
6159 * term.c, tparam.h: Include it.
6160 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6161 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6162 Move these decls to tparam.h, and make them agree with what
6163 is actually in tparam.c. The previous trick of using incompatible
6164 decls in different modules does not conform to the C standard.
6165 All callers of tparam changed to use tparam's actual API.
6166 * tparam.c (tparam1, tparam, tgoto):
6167 Use const pointers where appropriate.
6168
fbceeba2
PE
6169 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6170 * cm.h (struct cm): Likewise.
6171 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6172 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6173 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6174 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6175 (turn_on_face, init_tty): Likewise.
6176 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6177
7f3f1250
PE
6178 * term.c (term_mouse_position): Rename local to avoid shadowing.
6179
e6ca6543
PE
6180 * alloc.c (mark_ttys): Move decl from here ...
6181 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6182
c40f8d15
AS
61832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6184
6185 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6186
cfe0661d
JB
61872011-03-09 Juanma Barranquero <lekktu@gmail.com>
6188
6189 * search.c (compile_pattern_1): Remove argument regp, unused since
6190 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6191 (compile_pattern): Don't pass it.
6192
0afb4571
J
61932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6194
6195 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6196 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6197 for ! HAVE_GTK3.
6198 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6199
6200 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6201
6202 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6203 gdk_window_get_screen, gdk_window_get_geometry,
6204 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6205 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6206 (xg_get_pixbuf_from_pixmap): New function.
6207 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6208 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6209 Call xg_get_pixbuf_from_pixmap instead of
6210 gdk_pixbuf_get_from_drawable.
6211 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6212 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6213 (xg_check_special_colors): Use GtkStyleContext and its functions
6214 for HAVE_GTK3.
6215 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6216 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6217 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6218 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6219 Call gtk_widget_get_preferred_size.
0afb4571
J
6220 (xg_frame_resized): gdk_window_get_geometry only takes 5
6221 parameters.
44f230aa
SM
6222 (xg_win_to_widget, xg_event_is_for_menubar):
6223 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6224 (xg_set_widget_bg): New function.
6225 (delete_cb): New function.
895009e1 6226 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6227 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6228 (xg_set_background_color): Call xg_set_widget_bg.
6229 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6230 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6231 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6232 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6233 if ! HAVE_GTK3.
6234 (update_frame_tool_bar): Call gtk_widget_hide.
6235 (xg_initialize): Use GDK_KEY_g.
6236
6237 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6238 if ! HAVE_GTK3
6239 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6240
6241 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6242 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6243 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6244
1c2cc4ef
JB
62452011-03-08 Juanma Barranquero <lekktu@gmail.com>
6246
6247 * w32xfns.c (select_palette): Check success of RealizePalette against
6248 GDI_ERROR, not zero.
6249
33383987 6250See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6251
6252;; Local Variables:
6253;; coding: utf-8
aac0c6e3
MR
6254;; End:
6255
33383987 6256 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6257
6258 This file is part of GNU Emacs.
6259
6260 GNU Emacs is free software: you can redistribute it and/or modify
6261 it under the terms of the GNU General Public License as published by
6262 the Free Software Foundation, either version 3 of the License, or
6263 (at your option) any later version.
6264
6265 GNU Emacs is distributed in the hope that it will be useful,
6266 but WITHOUT ANY WARRANTY; without even the implied warranty of
6267 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6268 GNU General Public License for more details.
6269
6270 You should have received a copy of the GNU General Public License
6271 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.