Allow sending mail in "emacs -Q" by not calling customize-save-variable
[bpt/emacs.git] / src / ChangeLog
CommitLineData
54e10184
LMI
12011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
9888ff71
LMI
3 * keymap.c (describe_map_tree): Don't insert a double newline at
4 the end of the buffer (bug#1169) and return whether we inserted
5 something.
6
54e10184
LMI
7 * callint.c (Fcall_interactively): Change "reading args" to
8 "providing args" to try to clarify what it does (bug#1010).
9
15fa4783
KH
102011-07-07 Kenichi Handa <handa@m17n.org>
11
12 * composite.c (composition_compute_stop_pos): Ignore a static
13 composition starting before CHARPOS (Bug#8915).
14
15 * xdisp.c (handle_composition_prop): Likewise.
16
a8815b00
EZ
172011-07-07 Eli Zaretskii <eliz@gnu.org>
18
19 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
20 (Bug#9015)
21
ef7b981d 222011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
23
24 * character.h (unicode_category_t): New enum type.
25
26 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
27 (Qchar_code_property_table): New variable.
28 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
29 (UNIPROP_COMPRESSED_FORM_P): New macros.
30 (char_table_ascii): Uncompress the compressed values.
31 (sub_char_table_ref): New arg is_uniprop. Callers changed.
32 Uncompress the compressed values.
33 (sub_char_table_ref_and_range): Likewise.
34 (char_table_ref_and_range): Uncompress the compressed values.
35 (sub_char_table_set): New arg is_uniprop. Callers changed.
36 Uncompress the compressed values.
37 (sub_char_table_set_range): Args changed. Callers changed.
38 (char_table_set_range): Adjuted for the above change.
39 (map_sub_char_table): Delete args default_val and parent. Add arg
40 top. Give decoded values to a Lisp function.
41 (map_char_table): Adjusted for the above change. Give decoded
42 values to a Lisp function. Gcpro more variables.
43 (uniprop_table_uncompress)
44 (uniprop_decode_value_run_length): New functions.
45 (uniprop_decoder, uniprop_decoder_count): New variables.
46 (uniprop_get_decoder, uniprop_encode_value_character)
47 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
48 New functions.
49 (uniprop_encoder, uniprop_encoder_count): New variables.
50 (uniprop_get_encoder, uniprop_table)
51 (Funicode_property_table_internal, Fget_unicode_property_internal)
52 (Fput_unicode_property_internal): New functions.
53 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
54 Sunicode_property_table_internal, Sget_unicode_property_internal,
55 and Sput_unicode_property_internal. Defvar_lisp
56 char-code-property-alist.
57
58 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
59 Vunicode_category_table.
60
61 * font.c (font_range): Adjusted for the change of
62 Vunicode_category_table.
63
76b397fb
DN
642011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
65
66 * m/iris4d.h: Remove file, move contents ...
67 * s/irix6-5.h: ... here.
68
22b4128e
PE
692011-07-06 Paul Eggert <eggert@cs.ucla.edu>
70
71 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
72 * alloc.c (mark_buffer):
73 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
74 (clone_per_buffer_values): Don't assume that
22b4128e
PE
75 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
76 This isn't true in general, and it's particularly not true
77 if Emacs is configured with --with-wide-int.
78 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
79 New macros, used in the buffer.c change.
80
869795d6
JD
812011-07-05 Jan Djärv <jan.h.d@swipnet.se>
82
83 * xsettings.c: Use both GConf and GSettings if both are available.
84 (store_config_changed_event): Add comment.
85 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
86 (store_tool_bar_style_changed): New functions.
87 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
88 (struct xsettings): Move font inside HAVE_XFT.
89 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
90 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
91 Move inside HAVE_XFT.
92 (something_changed_gsettingsCB): Renamed from something_changedCB.
93 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
94 also.
95 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
96 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
97 (something_changed_gconfCB): Renamed from something_changedCB.
98 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
99 (parse_settings): Move check for font inside HAVE_XFT.
100 (read_settings, apply_xft_settings): Add comment.
101 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
102 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
103 call store_font_name_changed.
104 (xft_settings_event): Add comment.
105 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
106 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
107 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
108 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
109 (xsettings_initialize): Call init_gsettings last.
110 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
111 comment.
112
d8ed26bd
PE
1132011-07-05 Paul Eggert <eggert@cs.ucla.edu>
114
115 Random fixes. E.g., (random) never returned negative values.
116 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
117 subseconds part to the entropy, as that's a bit more random.
118 Prefer signed to unsigned, since the signedness doesn't matter and
119 in general we prefer signed. When given a limit, use a
120 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
121 latter isn't right if USE_2_TAGS_FOR_INTS.
122 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
123 not 0..VALMASK. Don't discard "excess" bits that random () returns.
124
cabf1cac
SM
1252011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
126
127 * textprop.c (text_property_stickiness):
128 Obey Vtext_property_default_nonsticky.
129 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
130 * w32fns.c (syms_of_w32fns):
131 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
132
6e9b2be9
PE
1332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
134
135 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
136 This is more efficient than Ffile_directory_p and avoids a minor race.
137
90186c68
LMI
1382011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
139
7c301272
LMI
140 * buffer.c (Foverlay_put): Say what the return value is
141 (bug#7835).
142
c4f2d8d4
LMI
143 * fileio.c (barf_or_query_if_file_exists): Check first if the file
144 is a directory before asking whether to use the file name
145 (bug#7564).
ad637907
LMI
146 (barf_or_query_if_file_exists): Make the "File is a directory"
147 error be more correct.
c4f2d8d4 148
90186c68
LMI
149 * fns.c (Frequire): Remove the mention of the .gz files, since
150 that's installation-specific, but keep the mention of
151 `get-load-suffixes'.
152
da64016e
PE
1532011-07-04 Paul Eggert <eggert@cs.ucla.edu>
154
155 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
156 Report string overflow if the output is too long.
157
7d47b580
JB
1582011-07-04 Juanma Barranquero <lekktu@gmail.com>
159
a555cb87
JB
160 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
161 (syms_of_gnutls): Remove duplicate DEFSYM for
162 Qgnutls_bootprop_verify_hostname_error, an error for
163 Qgnutls_bootprop_verify_error (which is no longer used).
164
7d47b580
JB
165 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
166 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
167 Also (re)move comments that are misplaced or no longer relevant.
168
1e49bfab
LMI
1692011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
170
171 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
172
1485f4c0
CY
1732011-07-03 Chong Yidong <cyd@stupidchicken.com>
174
175 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
176 and background color parameters if they have been changed.
177
a9ab721e
LMI
1782011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
179
180 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
181
cf7cff57
PE
1822011-07-03 Paul Eggert <eggert@cs.ucla.edu>
183
2e13213d
PE
184 * xsettings.c (SYSTEM_FONT): Define only when used.
185 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
186
cf7cff57
PE
187 * keymap.c (access_keymap_1): Now static.
188
7a8e04f7
CY
1892011-07-02 Chong Yidong <cyd@stupidchicken.com>
190
191 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
192 leave any prefix arg for the up event (Bug#1586).
193
61352f62
LMI
1942011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
195
69bb1ef7
LMI
196 * lread.c (syms_of_lread): Mention single symbols defined by
197 `defvar' or `defconst' (bug#7154).
198
61352f62 199 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 200 (Frequire): Mention get-load-suffixes.
61352f62 201
28545e04
MR
2022011-07-02 Martin Rudalics <rudalics@gmx.at>
203
204 * window.h (window): Remove clone_number slot.
205 * window.c (Fwindow_clone_number, Fset_window_clone_number):
206 Remove.
207 (make_parent_window, make_window, saved_window)
208 (Fset_window_configuration, save_window_save): Don't deal with
209 clone numbers.
210 * buffer.c (Qclone_number): Remove declaration.
211 (sort_overlays, overlay_strings): Don't deal with clone numbers.
212
3349e122
SM
2132011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
214
215 Add multiple inheritance to keymaps.
216 * keymap.c (Fmake_composed_keymap): New function.
217 (Fset_keymap_parent): Simplify.
218 (fix_submap_inheritance): Remove.
219 (access_keymap_1): New function extracted from access_keymap to handle
220 embedded parents and handle lists of maps.
221 (access_keymap): Use it.
222 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
223 (Fcopy_keymap): Handle embedded parents.
224 (Fcommand_remapping, define_as_prefix): Simplify.
225 (Fkey_binding): Simplify.
226 (syms_of_keymap): Move minibuffer-local-completion-map,
227 minibuffer-local-filename-completion-map,
228 minibuffer-local-must-match-map, and
229 minibuffer-local-filename-must-match-map to Elisp.
230 (syms_of_keymap): Defsubr make-composed-keymap.
231 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
232 (parse_menu_item): Trivial simplification.
233
3279eb87
GM
2342011-07-01 Glenn Morris <rgm@gnu.org>
235
236 * Makefile.in (SETTINGS_LIBS): Fix typo.
237
4550efdf
KI
2382011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
239
240 * coding.c (Fencode_coding_string): Record the last coding system
241 used, as the function doc string says (bug#8738).
242
0949d2b6
JD
2432011-07-01 Jan Djärv <jan.h.d@swipnet.se>
244
245 * xsettings.c (store_monospaced_changed): Take new font as arg and
246 check for change against current_mono_font.
247 (EMACS_TYPE_SETTINGS): Remove this and related defines.
248 (emacs_settings_constructor, emacs_settings_get_property)
249 (emacs_settings_set_property, emacs_settings_class_init)
250 (emacs_settings_init, gsettings_obj): Remove.
251 (something_changedCB): New function for HAVE_GSETTINGS.
252 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
253 with value as argument.
254 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
255 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 256 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
257 "changed".
258
259 * xgselect.c: Add defined (HAVE_GSETTINGS).
260 (xgselect_initialize): Ditto.
261
262 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
263 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
264 xg_select.
265
bbc6b304
PE
2662011-07-01 Paul Eggert <eggert@cs.ucla.edu>
267
268 * eval.c (struct backtrace): Simplify and port the data structure.
269 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
270 signed bit field, as this assumption is not portable and it makes
271 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
272 "char debug_on_exit : 1" as this is not portable either; instead,
273 use the portable "unsigned int debug_on_exit : 1". Remove unused
274 member evalargs. Remove obsolete comments about cc bombing out.
275
9851bfc5
JD
2762011-06-30 Jan Djärv <jan.h.d@swipnet.se>
277
51bb811f 278 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
279 Let HAVE_GSETTINGS override HAVE_GCONF.
280 (store_monospaced_changed): New function.
281 (EMACS_SETTINGS): A new type derived from GObject to handle
282 GSettings notifications.
283 (emacs_settings_constructor, emacs_settings_get_property)
284 (emacs_settings_set_property, emacs_settings_class_init):
285 New functions.
286 (gsettings_client, gsettings_obj): New variables.
287 (GSETTINGS_SCHEMA): New define.
288 (something_changedCB): Call store_monospaced_changed.
289 (init_gsettings): New function.
290 (xsettings_initialize): Call init_gsettings.
291 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
292 to NULL.
293
294 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
295 GCONF_CFLAGS/LIBS.
296
5386012d
MR
2972011-06-29 Martin Rudalics <rudalics@gmx.at>
298
299 * window.c (resize_root_window, grow_mini_window)
300 (shrink_mini_window): Rename Qresize_root_window to
301 Qwindow_resize_root_window and Qresize_root_window_vertically to
302 Qwindow_resize_root_window_vertically.
303
f13e0b08
PE
3042011-06-28 Paul Eggert <eggert@cs.ucla.edu>
305
306 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
307
94515237
JB
3082011-06-27 Juanma Barranquero <lekktu@gmail.com>
309
310 * makefile.w32-in: Redesign dependencies so they reflect more
311 clearly which files are directly included by each source file,
312 and not through other includes.
313
e43b6e43
MR
3142011-06-27 Martin Rudalics <rudalics@gmx.at>
315
316 * buffer.c (Qclone_number): Declare static and DEFSYM it.
317 (sort_overlays, overlay_strings): When an overlay's clone number
318 matches the window's clone number process the overlay even if
319 the overlay's window property doesn't match the current window.
320
d68443dc
MR
321 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
322 (Fwindow_hchild): Rename to Fwindow_left_child.
323 (Fwindow_next): Rename to Fwindow_next_sibling.
324 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
325 (resize_window_check): Rename to window_resize_check.
326 (resize_window_apply): Rename to window_resize_apply.
327 (Fresize_window_apply): Rename to Fwindow_resize_apply.
328 (Fdelete_other_windows_internal, resize_frame_windows)
329 (Fsplit_window_internal, Fdelete_window_internal)
330 (grow_mini_window, shrink_mini_window)
331 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 332
c7e73be5
JD
3332011-06-26 Jan Djärv <jan.h.d@swipnet.se>
334
335 * emacsgtkfixed.h: State that this is only used with Gtk+3.
336 (emacs_fixed_set_min_size): Remove.
337 (emacs_fixed_new): Take frame as argument.
338
339 * emacsgtkfixed.c: State that this is only used with Gtk+3.
340 (_EmacsFixedPrivate): Remove minwidth/height.
341 Add struct frame *f.
342 (emacs_fixed_init): Initialize priv->f.
343 (get_parent_class, emacs_fixed_set_min_size): Remove.
344 (emacs_fixed_new): Set priv->f to argument.
345 (emacs_fixed_get_preferred_width)
346 (emacs_fixed_get_preferred_height): Use min_width/height from
347 frames size_hint to set minimum and natural (Bug#8919).
348 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
349 and use min_width/height from frames size_hint to set
350 min_width/height (Bug#8919).
351
352 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
353 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
354 Fix indentation.
c7e73be5 355
cf99dcf8
EZ
3562011-06-26 Eli Zaretskii <eliz@gnu.org>
357
358 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
359 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
360 called at ZV.
361
029529ac
CY
3622011-06-26 Chong Yidong <cyd@stupidchicken.com>
363
364 * process.c (wait_reading_process_output): Bypass select if
365 waiting for a cell while ignoring keyboard input, and input is
366 pending. Suggested by Jan Djärv (Bug#8869).
367
7a7ef429
PE
3682011-06-25 Paul Eggert <eggert@cs.ucla.edu>
369
370 Use gnulib's dup2 module instead of rolling our own.
371 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
372
11fdef7d 3732011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
374
375 * dispnew.c (scrolling_window): Before scrolling, turn off a
376 mouse-highlight in the window being scrolled.
377
cd3520a4
JB
3782011-06-24 Juanma Barranquero <lekktu@gmail.com>
379
380 Move DEFSYM to lisp.h and use everywhere.
381
382 * character.h (DEFSYM): Move declaration...
383 * lisp.h (DEFSYM): ...here.
384
385 * gnutls.c:
386 * minibuf.c:
387 * w32menu.c:
388 * w32proc.c:
389 * w32select.c: Don't include character.h.
390
391 * alloc.c (syms_of_alloc):
392 * buffer.c (syms_of_buffer):
393 * bytecode.c (syms_of_bytecode):
394 * callint.c (syms_of_callint):
395 * casefiddle.c (syms_of_casefiddle):
396 * casetab.c (init_casetab_once):
397 * category.c (init_category_once, syms_of_category):
398 * ccl.c (syms_of_ccl):
399 * cmds.c (syms_of_cmds):
400 * composite.c (syms_of_composite):
401 * dbusbind.c (syms_of_dbusbind):
402 * dired.c (syms_of_dired):
403 * dispnew.c (syms_of_display):
404 * doc.c (syms_of_doc):
405 * editfns.c (syms_of_editfns):
406 * emacs.c (syms_of_emacs):
407 * eval.c (syms_of_eval):
408 * fileio.c (syms_of_fileio):
409 * fns.c (syms_of_fns):
410 * frame.c (syms_of_frame):
411 * fringe.c (syms_of_fringe):
412 * insdel.c (syms_of_insdel):
413 * keymap.c (syms_of_keymap):
414 * lread.c (init_obarray, syms_of_lread):
415 * macros.c (syms_of_macros):
416 * msdos.c (syms_of_msdos):
417 * print.c (syms_of_print):
418 * process.c (syms_of_process):
419 * search.c (syms_of_search):
420 * sound.c (syms_of_sound):
421 * syntax.c (init_syntax_once, syms_of_syntax):
422 * terminal.c (syms_of_terminal):
423 * textprop.c (syms_of_textprop):
424 * undo.c (syms_of_undo):
425 * w32.c (globals_of_w32):
426 * window.c (syms_of_window):
427 * xdisp.c (syms_of_xdisp):
428 * xfaces.c (syms_of_xfaces):
429 * xfns.c (syms_of_xfns):
430 * xmenu.c (syms_of_xmenu):
431 * xsettings.c (syms_of_xsettings):
432 * xterm.c (syms_of_xterm): Use DEFSYM.
433
4228cf16
TZ
4342011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
435
cd3520a4 436 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 437
7fcccf1e
PE
4382011-06-23 Paul Eggert <eggert@cs.ucla.edu>
439
7efb4e0e
PE
440 Integer and buffer overflow fixes (Bug#8873).
441
ff5844ad
PE
442 * print.c (printchar, strout): Check for string overflow.
443 (PRINTPREPARE, printchar, strout):
444 Don't set size unless allocation succeeds.
445
90532f02
PE
446 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
447 for sizes. Check for string overflow more accurately.
448 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
449
6d84508d
PE
450 * macros.c: Integer and buffer overflow fixes.
451 * keyboard.h (struct keyboard.kbd_macro_bufsize):
452 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
453 Use ptrdiff_t, not int, for sizes.
454 Don't increment bufsize until after realloc succeeds.
455 Check for size-calculation overflow.
456 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
457
437b2cb4
PE
458 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
459
8b9ac8b4
PE
460 * lread.c: Integer overflow fixes.
461 (read_integer): Radix is now EMACS_INT, not int,
462 to improve quality of diagnostics for out-of-range radices.
463 Calculate buffer size correctly for out-of-range radices.
464 (read1): Check for integer overflow in radices, and in
465 read-circle numbers.
82cb60d3
PE
466 (read_escape): Avoid int overflow.
467 (Fload, openp, read_buffer_size, read1)
468 (substitute_object_recurse, read_vector, read_list, map_obarray):
469 Use ptrdiff_t, not int, for sizes.
470 (read1): Use EMACS_INT, not int, for sizes.
20270765 471 Check for size overflow.
8b9ac8b4 472
7fcccf1e
PE
473 * image.c (cache_image): Check for size arithmetic overflow.
474
bfbbd7e7
PE
475 * lread.c: Integer overflow issues.
476 (saved_doc_string_size, saved_doc_string_length)
477 (prev_saved_doc_string_size, prev_saved_doc_string_length):
478 Now ptrdiff_t, not int.
479 (read1): Don't assume doc string length fits in int. Check for
480 out-of-range doc string lengths.
481 (read_list): Don't assume file position fits in int.
39019e54 482 (read_escape): Check for hex character overflow.
bfbbd7e7 483
4e323265
LL
4842011-06-22 Leo Liu <sdl.web@gmail.com>
485
486 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
487 Move to minibuffer.el.
488
85fece3e
PE
4892011-06-22 Paul Eggert <eggert@cs.ucla.edu>
490
20b84ce9 491 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
492 The following patches are for when GLYPH_DEBUG && !XASSERT.
493 * dispextern.h (trace_redisplay_p, dump_glyph_string):
494 * dispnew.c (flush_stdout):
495 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
496 Mark as externally visible.
497 * dispnew.c (check_window_matrix_pointers): Now static.
498 * dispnew.c (window_to_frame_vpos):
499 * xfns.c (unwind_create_frame):
500 * xterm.c (x_check_font): Remove unused local.
501 * scroll.c (CHECK_BOUNDS):
502 * xfaces.c (cache_fache): Rename local to avoid shadowing.
503 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
504 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
505 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
506 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
507 Now static.
508 (debug_method_add): Use va_list and vsprintf rather than relying
509 on undefined behavior with wrong number of arguments.
510 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
511 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
512 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
513 since we're not interested in debugging glyphs with old libraries.
514 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
515 GCC 4.6.0's static checking.
516
0766b489
PE
5172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
518
31fd4b32
PE
519 Integer overflow and signedness fixes (Bug#8873).
520 A few related buffer overrun fixes, too.
521
b79e8648
PE
522 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
523
0766b489
PE
524 * dispextern.h (struct face.stipple):
525 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
526 (x_bitmap_mask, x_allocate_bitmap_record)
527 (x_create_bitmap_from_data, x_create_bitmap_from_file)
528 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
529 (x_create_bitmap_from_xpm_data):
530 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
531 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
532 (.bitmaps_last):
533 * xfaces.c (load_pixmap):
534 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
535 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
536 (.bitmaps_last, struct x_output.icon_bitmap):
537 Use ptrdiff_t, not int, for bitmap indexes.
538 (x_allocate_bitmap_record): Check for size overflow.
539 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
540
b081724f
PE
541 Use ptrdiff_t, not int, for overlay counts.
542 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
543 * editfns.c (overlays_around, get_pos_property):
544 * textprop.c (get_char_property_and_overlay):
545 * xdisp.c (next_overlay_change, note_mouse_highlight):
546 * xfaces.c (face_at_buffer_position):
21514da7
PE
547 * buffer.c (OVERLAY_COUNT_MAX): New macro.
548 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
549 (Fnext_overlay_change, Fprevious_overlay_change)
550 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 551 Use ptrdiff_t, not int, for sizes.
21514da7 552 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 553
3de73e5e
PE
554 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
555
2606c57b
PE
556 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
557 (x_session_initialize): Do not assume string length fits in int.
558
aaafe47a
PE
559 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
560 This is unlikely, but can occur if DPI is outlandish.
561
2674ddc8 562 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
563 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
564
28154962
PE
565 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
566 * xrdb.c (magic_file_p, search_magic_path):
567 Omit last arg SUFFIX; it was always 0. All callers changed.
568 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
569
7de51af5
PE
570 * xfont.c (xfont_match): Avoid need for strlen.
571
25ed6cc3
PE
572 * xfns.c: Don't assume strlen fits in int.
573 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
574
4eab31dd
PE
575 * xdisp.c (message_log_check_duplicate): Return intmax_t,
576 not unsigned long, as we prefer signed integers. All callers changed.
577 Detect integer overflow in repeat count.
578 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 579 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 580
171e2a58
PE
581 * termcap.c: Don't assume sizes fit in int and never overflow.
582 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
583 (gobble_line): Check for size-calculation overflow.
584
ad39faca 585 * minibuf.c (Fread_buffer):
6e5bb2dc 586 * lread.c (intern, intern_c_string):
74ca2eb3
PE
587 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
588 Don't assume string length fits in int.
589
52c61c22 590 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
591 * gtkutil.c (style_changed_cb): Avoid need for strlen.
592
b5b8c9e5
PE
593 * font.c: Don't assume string length fits in int.
594 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
595 Use ptrdiff_t, not int.
ccd6111c
PE
596 (font_intern_prop): Don't assume string length fits in int.
597 Don't assume integer property fits in fixnum.
598 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 599
882f0d81 600 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 601 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
602 Reformulate so as not to need the command string.
603 Invoke gzip -cd rather than gunzip, as it's more portable.
604 (lock_info_type, lock_file_1, lock_file):
605 Don't assume pid_t and time_t fit in unsigned long.
606 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
607 (current_lock_owner): Prefer signed type for sizes.
608 Use memcpy, not strncpy, where memcpy is what is really wanted.
609 Don't assume (via atoi) that time_t and pid_t fit in int.
610 Check for time_t and/or pid_t out of range, e.g., via a network share.
611 Don't alloca where an auto var works fine.
612
93f4cf88
PE
613 * fileio.c: Fix some integer overflow issues.
614 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
615 Don't assume string length fits in int.
616 (directory_file_name): Don't assume string length fits in long.
617 (make_temp_name): Don't assume pid fits in int, or that its print
618 length is less than 20.
619
f3e92b69
PE
620 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
621
1bfdaf10
PE
622 * coding.c (make_subsidiaries): Don't assume string length fits in int.
623
35016e9a
PE
624 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
625
3d1e65a1
PE
626 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
627 We prefer signed integers, even for size calculations.
628
0b963a93
PE
629 * emacs.c: Don't assume string length fits in 'int'.
630 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
631 (main): Don't invoke strlen when not needed.
632
573f4b54
PE
633 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
634 (XD_DEBUG_MESSAGE): Don't waste a byte.
635
989f33ba
PE
636 * callproc.c (getenv_internal_1, getenv_internal)
637 (Fgetenv_internal):
965d34eb
PE
638 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
639
e4d29b33
PE
640 * lread.c (invalid_syntax): Omit length argument.
641 All uses changed. This doesn't fix a bug, but it simplifies the
642 code away from its former Hollerith-constant appearance, and it's
643 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 644 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 645
eb49b136
PE
646 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
647 This didn't break anything, but it didn't help either.
648 It's confusing to put a bogus integer in a place where the actual
649 value does not matter.
9f62aeb1 650 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 651 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 652
15375a22
PE
653 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
654 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
655 implementation.
b61cc01c
PE
656 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
657 We prefer signed types, and the value cannot exceed the EMACS_INT
658 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
659 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
660 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
661 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 662
53b2623d
PE
663 * indent.c (sane_tab_width): New function.
664 (current_column, scan_for_column, Findent_to, position_indentation)
665 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 666 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 667
51cab52b 668 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 669
f2ed8a70
PE
670 * lisp.h (lint_assume): New macro.
671 * composite.c (composition_gstring_put_cache):
672 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
673
abe80cc6
PE
674 * editfns.c, insdel.c:
675 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 676
b02c740e
PE
677 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
678
ebc96716
PE
679 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
680
b4e50fa0 681 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 682 Use much-faster test for byte-length change.
311d5d7c 683 Don't assume string byte-length fits in 'int'.
a4cf38e4 684 Check that character arg fits in 'int'.
85461888 685 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 686
c0c1ee9f
PE
687 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
688
a498d7f4
PE
689 * fns.c (concat): Catch string overflow earlier.
690 Do not rely on integer wraparound.
691
51cab52b
PE
692 * dispextern.h (struct it.overlay_strings_charpos)
693 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
694 * xdisp.c (forward_to_next_line_start)
695 (back_to_previous_visible_line_start)
696 (reseat_at_next_visible_line_start, next_element_from_buffer):
697 Don't arbitrarily truncate the value of 'selective' to int.
698
76031fad
PE
699 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
700
5eb55db9
PE
701 * composite.c: Don't truncate sizes to 'int'.
702 (composition_gstring_p, composition_reseat_it)
703 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
704 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
705 not EMACS_UINT, for indexes.
5eb55db9 706
0703a717
PE
707 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
708
d6202519
PE
709 * buffer.c: Include <verify.h>.
710 (struct sortvec.priority, struct sortstr.priority):
8961a454 711 Now EMACS_INT, not int.
c20998a7 712 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
713 (struct sortstr.size, record_overlay_string)
714 (struct sortstrlist.size, struct sortlist.used):
715 Don't truncate size to int.
716 (record_overlay_string): Check for size-calculation overflow.
d6202519 717 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 718
d5a19415
JM
7192011-06-22 Jim Meyering <meyering@redhat.com>
720
029529ac 721 Don't leak an XBM-image-sized buffer
d5a19415
JM
722 * image.c (xbm_load): Free the image buffer after using it.
723
a9041e6c
PE
7242011-06-21 Paul Eggert <eggert@cs.ucla.edu>
725
726 Port to Sun C.
727 * composite.c (find_automatic_composition): Omit needless 'return 0;'
728 that Sun C diagnosed.
729 * fns.c (secure_hash): Fix pointer signedness issue.
730 * intervals.c (static_offset_intervals): New function.
731 (offset_intervals): Use it.
732
7f3f739f
LL
7332011-06-21 Leo Liu <sdl.web@gmail.com>
734
735 * deps.mk (fns.o):
736 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
737 sha512.h.
738
739 * fns.c (secure_hash): Rename from crypto_hash_function and change
740 the first arg to accept symbols.
5b66d427 741 (Fsecure_hash): New primitive.
7f3f739f
LL
742 (syms_of_fns): New symbols.
743
76147d94
DD
7442011-06-20 Deniz Dogan <deniz@dogan.se>
745
746 * process.c (Fset_process_buffer): Clarify return value in
747 docstring.
748
7d7d0045
CY
7492011-06-18 Chong Yidong <cyd@stupidchicken.com>
750
751 * dispnew.c (add_window_display_history): Use BVAR.
752
753 * xdisp.c (debug_method_add): Use BVAR.
754 (check_window_end, dump_glyph_matrix, dump_glyph)
755 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
756
757 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
758 Likewise.
759
760 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
761 check till after the cache is created in init_frame_faces.
762
ff2bc410
SM
7632011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
764
765 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
766
28177add
PE
7672011-06-16 Paul Eggert <eggert@cs.ucla.edu>
768
dd3482fe
PE
769 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
770 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
771 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
772
393d71f3 773 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
774 * fileio.c (Finsert_file_contents):
775 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
776 Remove the old (too-loose) buffer overflow checks.
777 They weren't needed, since make_gap checks for buffer overflow.
778 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
779 The old code merely checked for Emacs fixnum overflow, and relied
780 on undefined (wraparound) behavior. The new code avoids undefined
781 behavior, and also checks for ptrdiff_t and/or size_t overflow.
782
2e6813b0 783 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
784 Tune. Don't use wider integers than needed. Don't use alloca.
785 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 786
599a9e4f
PE
787 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
788
99561444
PE
789 * insdel.c, lisp.h (buffer_overflow): New function.
790 (insert_from_buffer_1, replace_range, replace_range_2):
791 * insdel.c (make_gap_larger):
792 * editfns.c (Finsert_char):
793 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
794
28177add
PE
795 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
796
e69dafad
PE
7972011-06-15 Paul Eggert <eggert@cs.ucla.edu>
798
a7af7fde 799 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 800
b1c46f02
PE
801 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
802 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
803
e69dafad
PE
804 * fileio.c: Don't assume EMACS_INT fits in off_t.
805 (emacs_lseek): New static function.
806 (Finsert_file_contents, Fwrite_region): Use it.
807 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
808
566684ea
PE
809 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
810
e6966cd6
PE
811 * fns.c: Don't overflow int when computing a list length.
812 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
813 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
814 truncation on 64-bit hosts. Check for QUIT every
815 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
816 faster and is responsive enough.
817 (Flength): Report an error instead of overflowing an integer.
818 (Fsafe_length): Return a float if the value is not representable
819 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 820 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 821 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 822
dd0b0efb
PE
823 * alloc.c: Check that resized vectors' lengths fit in fixnums.
824 (header_size, word_size): New constants.
825 (allocate_vectorlike): Don't check size overflow here.
826 (allocate_vector): Check it here instead, since this is the only
827 caller of allocate_vectorlike that could cause overflow.
828 Check that the new vector's length is representable as a fixnum.
829
86fe5cfe
PE
830 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
831 The previous code was bogus. For example, next_almost_prime (32)
832 returned 39, which is undesirable as it is a multiple of 3; and
833 next_almost_prime (24) returned 25, which is a multiple of 5 so
834 why was the code bothering to check for multiples of 7?
835
80e88859
PE
836 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
837
4a2f0ad6
PE
838 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
839
f66c7cf8
PE
840 Variadic C functions now count arguments with ptrdiff_t.
841 This partly undoes my 2011-03-30 change, which replaced int with size_t.
842 Back then I didn't know that the Emacs coding style prefers signed int.
843 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
844 were being counted with int, which may truncate counts on 64-bit
845 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
846 * lisp.h (struct Lisp_Subr.function.aMANY)
847 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
848 Arg counts are now ptrdiff_t, not size_t.
849 All variadic functions and their callers changed accordingly.
850 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
851 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
852 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
853 * callint.c (Fcall_interactively): Check arg count for overflow,
854 to avoid potential buffer overrun. Use signed char, not 'int',
855 for 'varies' array, so that we needn't bother to check its size
856 calculation for overflow.
857 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
858 * eval.c (apply_lambda):
859 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
860 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
861 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
862
a1759b76
PE
863 * callint.c (Fcall_interactively): Don't use index var as event count.
864
d96be9fc
PE
865 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
866 * mem-limits.h (SIZE): Remove; no longer used.
867
a690a978 868 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 869
578c21e6
PE
870 Remove unnecessary casts.
871 * xterm.c (x_term_init):
872 * xfns.c (x_set_border_pixel):
873 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
874 These aren't needed now that we assume ANSI C.
875
96f53c6c
PE
876 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
877 It's more likely to cause problems (due to unsigned overflow)
878 than to cure them.
879
83c77d31
PE
880 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
881
ee2079f1
PE
882 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
883
6da65536
PE
884 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
885
7147c4a4
PE
886 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
887
193e32d9
PE
888 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
889
e5533da6
PE
890 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
891
9910e595
PE
892 GLYPH_CODE_FACE returns EMACS_INT, not int.
893 * dispextern.h (merge_faces):
894 * xfaces.c (merge_faces):
01103c44
PE
895 * xdisp.c (get_next_display_element, next_element_from_display_vector):
896 Don't assume EMACS_INT fits in int.
9910e595 897
2638320e
PE
898 * character.h (CHAR_VALID_P): Remove unused parameter.
899 * fontset.c, lisp.h, xdisp.c: All uses changed.
900
045eb8d9
PE
901 * editfns.c (Ftranslate_region_internal): Omit redundant test.
902
c1f134b5
PE
903 * fns.c (concat): Minor tuning based on overflow analysis.
904 This doesn't fix any bugs. Use int to hold character, instead
905 of constantly refetching from Emacs object. Use XFASTINT, not
906 XINT, for value known to be a character. Don't bother comparing
907 a single byte to 0400, as it's always less.
908
395fcb93 909 * floatfns.c (Fexpt):
327eeec8
PE
910 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
911
abbd3d23
PE
912 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
913 for characters.
914
684a03ef
PE
915 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
916
0fed43f3
PE
917 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
918 Without this fix, on a 64-bit host (aset S 0 4294967386) would
919 incorrectly succeed when S was a string, because 4294967386 was
920 truncated before it was used.
921
8fd02eb7
PE
922 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
923 Otherwise, an out-of-range integer could cause undefined behavior
924 on a 64-bit host.
925
f8c86b69
PE
926 * composite.c: Use int, not EMACS_INT, for characters.
927 (fill_gstring_body, composition_compute_stop_pos): Use int, not
928 EMACS_INT, for values that are known to be in character range.
929 This doesn't fix any bugs but is the usual style inside Emacs and
930 may generate better code on 32-bit machines.
931
34206dd2
PE
932 Make sure a 64-bit char is never passed to ENCODE_CHAR.
933 This is for reasons similar to the recent CHAR_STRING fix.
934 * charset.c (Fencode_char): Check that character arg is actually
935 a character. Pass an int to ENCODE_CHAR.
936 * charset.h (ENCODE_CHAR): Verify that the character argument is no
937 wider than 'int', as a compile-time check to prevent future regressions
938 in this area.
939
c5958d4c 940 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
941
942 Make sure a 64-bit char is never passed to CHAR_STRING.
943 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
944 by silently ignoring the top 32 bits, allowing some values
945 that were far too large to be valid characters.
946 * character.h: Include <verify.h>.
947 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
948 arguments are no wider than unsigned, as a compile-time check
949 to prevent future regressions in this area.
950 * data.c (Faset):
01103c44 951 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
952 (Fsubst_char_in_region):
953 * fns.c (concat):
954 * xdisp.c (decode_mode_spec_coding):
955 Adjust to CHAR_STRING's new requirement.
956 * editfns.c (Finsert_char, Fsubst_char_in_region):
957 * fns.c (concat): Check that character args are actually
958 characters. Without this test, these functions did the wrong
959 thing with wildly out-of-range values on 64-bit hosts.
960
d37ca623
PE
961 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
962 These casts should not be needed on 32-bit hosts, either.
963 * keyboard.c (read_char):
964 * lread.c (Fload): Remove casts to unsigned.
965
ea204efb
PE
966 * lisp.h (UNSIGNED_CMP): New macro.
967 This fixes comparison bugs on 64-bit hosts.
968 (ASCII_CHAR_P): Use it.
969 * casefiddle.c (casify_object):
01103c44 970 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
971 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
972 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
973 * dispextern.h (FACE_FROM_ID):
974 * keyboard.c (read_char): Use UNSIGNED_CMP.
975
41cb286c
PE
976 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
977 not to EMACS_INT, to avoid GCC warning.
978
4a1b9832
PE
979 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
980
55daad71
PE
981 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
982 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
983 isn't needed on 32-bit machines.
8f95c75c 984
01103c44
PE
985 * buffer.c (Fgenerate_new_buffer_name):
986 Use EMACS_INT for count, not int.
0ceccced 987 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
988
989 * data.c (Qcompiled_function): Now static.
990
c6f072e7
PE
991 * window.c (window_body_lines): Now static.
992
20ce5912
PE
993 * image.c (gif_load): Rename local to avoid shadowing.
994
9c4c5f81
PE
995 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
996 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
997 * alloc.c (make_save_value): Integer argument is now of type
998 ptrdiff_t, not int.
999 (mark_object): Use ptrdiff_t, not int.
1000 * lisp.h (pD): New macro.
1001 * print.c (print_object): Use it.
1002
c0c5c8ae
PE
1003 * alloc.c: Use EMACS_INT, not int, to count objects.
1004 (total_conses, total_markers, total_symbols, total_vector_size)
1005 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1006 (total_free_floats, total_floats, total_free_intervals)
1007 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1008 Now EMACS_INT, not int. All uses changed.
1009 (Fgarbage_collect): Compute overall total using a double, so that
1010 integer overflow is less likely to be a problem. Check for overflow
1011 when converting back to an integer.
5a25e253
PE
1012 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1013 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1014 These were 'int' variables that could overflow on 64-bit hosts;
1015 they were never used, so remove them instead of repairing them.
211a0b2a 1016 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1017 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1018 Previously, this ceilinged at INT_MAX, but that doesn't work on
1019 64-bit machines.
e46bb31a 1020 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1021
c78baabf 1022 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1023 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1024 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1025 when a (possibly-narrower) signed value would do just as well.
1026 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1027
c9d624c6
PE
1028 * alloc.c: Catch some string size overflows that we were missing.
1029 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1030 for convenience in STRING_BYTES_MAX.
1031 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1032 The definition here is exact; the one in lisp.h was approximate.
1033 (allocate_string_data): Check for string overflow. This catches
1034 some instances we weren't catching before. Also, it catches
1035 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1036 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1037 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1038
c9d624c6
PE
1039 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1040 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1041 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1042
353032ce
PE
1043 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1044
2bccce07
PE
1045 * alloc.c (Fmake_string): Check for out-of-range init.
1046
0ac30604
SM
10472011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1050
c195f2de
JD
10512011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1052
1053 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1054 xg_get_default_scrollbar_width.
1055
1056 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1057 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1058 (style_changed_cb): Call update_theme_scrollbar_width and call
1059 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1060 all frames (Bug#8505).
1061 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1062 Call gtk_window_set_resizable if HAVE_GTK3.
1063 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1064 and height if HAVE_GTK3 (Bug#8505).
1065 (scroll_bar_width_for_theme): New variable.
1066 (update_theme_scrollbar_width): New function.
1067 (xg_get_default_scrollbar_width): Move code to
1068 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1069 (xg_initialize): Call update_theme_scrollbar_width.
1070
1071 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1072
1073 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1074
e10ac9f1
MR
10752011-06-12 Martin Rudalics <rudalics@gmx.at>
1076
1077 * frame.c (make_frame): Call other_buffer_safely instead of
1078 other_buffer.
1079
1080 * window.c (temp_output_buffer_show): Call display_buffer with
1081 second argument Vtemp_buffer_show_specifiers and reset latter
1082 immediately after the call.
1083 (Vtemp_buffer_show_specifiers): New variable.
1084 (auto_window_vscroll_p, next_screen_context_lines)
1085 (Vscroll_preserve_screen_position): Remove leading asterisks from
1086 doc-strings.
1087
2d3c217e 10882011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1089
7b7f97e8 1090 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1091 * buffer.c (Qclone_number): Remove for now, as it's unused.
1092 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1093 (record_buffer): Remove unused local.
1094 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1095 (set_frame_buffer_list): Remove; unused.
1096 * frame.h (other_visible_frames): Remove decl.
1097 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1098 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1099 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1100 if HAVE_GPM.
1101 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1102 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1103 Define only if HAVE_GPM.
1104 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1105 (update_hints_inhibit): Remove; never set. All uses removed.
1106 * widgetprv.h (emacsFrameClassRec): Remove decl.
1107 * window.c (delete_deletable_window): Now returns void, since it
1108 wasn't returning anything.
1109 (compare_window_configurations): Remove unused locals.
1110 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1111 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1112 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1113 the same widths as pointers. This follows up on the 2011-05-06 patch.
1114 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1115 * xterm.h: Likewise.
1116 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1117
1384b89e
JB
11182011-06-12 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * makefile.w32-in: Update dependencies.
1121 (LISP_H): Add lib/intprops.h.
1122
1100a63c
CY
11232011-06-11 Chong Yidong <cyd@stupidchicken.com>
1124
1125 * image.c (gif_load): Add animation frame delay to the metadata.
1126 (syms_of_image): Use DEFSYM. New symbol `delay'.
1127
6198ccd0
MR
11282011-06-11 Martin Rudalics <rudalics@gmx.at>
1129
1130 * window.c (delete_deletable_window): Re-add.
1131 (Fset_window_configuration): Rewrite to handle dead buffers and
1132 consequently deletable windows.
1133 (window_tree, Fwindow_tree): Remove. Supply functionality in
1134 window.el.
1135 (compare_window_configurations): Simplify code.
1136
b6e3633c
AS
11372011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1138
1ab0dee5
AS
1139 * image.c (imagemagick_load_image): Fix type mismatch.
1140 (Fimagemagick_types): Likewise.
1141
b6e3633c
AS
1142 * window.h (replace_buffer_in_windows): Declare.
1143
9397e56f
MR
11442011-06-11 Martin Rudalics <rudalics@gmx.at>
1145
1146 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1147 Qclone_number. Remove external declaration of Qdelete_window.
1148 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1149 code.
1150 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1151 Qbuffer_list_update_hook if allowed.
1152 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1153 buffer list implementation.
1154 (other_buffer_safely): New function.
1155 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1156 calls to replace_buffer_in_windows and
1157 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1158 if allowed.
1159 (record_buffer): Inhibit quitting and rewrite using quittable
1160 functions. Run Qbuffer_list_update_hook if allowed.
1161 (Frecord_buffer, Funrecord_buffer): New functions.
1162 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1163 switch-to-buffer to window.el.
1164 (bury-buffer): Move to window.el.
1165 (Vbuffer_list_update_hook): New variable.
1166
1167 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1168 section.
1169
1170 * window.h (resize_frame_windows): Move up in code.
1171 (Fwindow_frame): Remove EXFUN.
1172 (replace_buffer_in_all_windows): Remove prototype.
1173 (replace_buffer_in_windows_safely): Add prototype.
1174
1175 * window.c: Declare Qdelete_window static again. Move down
1176 declaration of select_count.
1177 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1178 (Fother_window): Move to window.el.
1179 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1180 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1181 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1182 window.el.
1183 (replace_buffer_in_windows): Implement by calling
1184 Qreplace_buffer_in_windows.
1185 (replace_buffer_in_all_windows): Remove with some functionality
1186 moved into replace_buffer_in_windows_safely.
1187 (replace_buffer_in_windows_safely): New function.
1188 (select_window_norecord, select_frame_norecord): Move in front
1189 of run_window_configuration_change_hook. Remove now obsolete
1190 declarations.
1191 (Fset_window_buffer): Rewrite doc-string. Call
1192 Qrecord_window_buffer.
1193 (keys_of_window): Move binding for other-window to window.el.
1194
b50691aa
CY
11952011-06-11 Chong Yidong <cyd@stupidchicken.com>
1196
1197 * dispextern.h (struct image): Replace data member, whose int_val
1198 and ptr_val fields were not used by anything, with a single
1199 lisp_val object.
1200
1201 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1202 (gif_clear_image, gif_load, imagemagick_load_image)
1203 (gs_clear_image, gs_load): Callers changed.
1204
3f754b86
PE
12052011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1206
cca69397
PE
1207 * buffer.h: Include <time.h>, for time_t.
1208 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1209
109e28d0
PE
1210 Fix minor problems found by static checking.
1211
60737f02
PE
1212 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1213
4b66faf3
PE
1214 Make identifiers static if they are not used in other modules.
1215 * data.c (Qcompiled_function, Qframe, Qvector):
1216 * image.c (QimageMagick, Qsvg):
1217 * minibuf.c (Qmetadata):
1218 * window.c (resize_window_check, resize_root_window): Now static.
1219 * window.h (resize_window_check, resize_root_window): Remove decls.
1220
109e28d0
PE
1221 * window.c (window_deletion_count, delete_deletable_window):
1222 Remove; unused.
46a4ce9e
PE
1223 (window_body_lines): Now static.
1224 (Fdelete_other_windows_internal): Mark vars as initialized.
1225 Make sure 'resize_failed' is initialized.
1226 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1227 (resize_window_apply): Remove unused local.
1228 * window.h (delete_deletable_window): Remove decl.
1229
109e28d0 1230 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1231 (imagemagick_load_image): Fix pointer signedness problem by changing
1232 last arg from unsigned char * to char *. All uses changed.
1233 Also, fix a local for similar reasons.
1234 Remove unused locals. Remove locals to avoid shadowing.
1235 (fn_rsvg_handle_free): Remove; unused.
1236 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1237 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1238
3f754b86
PE
1239 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1240
2547adb1
CY
12412011-06-10 Chong Yidong <cyd@stupidchicken.com>
1242
1243 * image.c (gif_load): Fix omitted cast error introduced by
1244 2011-06-06 change.
1245
2c8e37d4
MR
12462011-06-10 Martin Rudalics <rudalics@gmx.at>
1247
1248 * window.h (resize_proportionally, orig_total_lines)
1249 (orig_top_line): Remove from window structure.
1250 (set_window_height, set_window_width, change_window_heights)
1251 (Fdelete_window): Remove prototypes.
1252 (resize_frame_windows): Remove duplicate declaration.
1253
440a42e3
EZ
12542011-06-10 Eli Zaretskii <eliz@gnu.org>
1255
1256 * window.h (resize_frame_windows, resize_window_check)
1257 (delete_deletable_window, resize_root_window)
1258 (resize_frame_windows): Declare prototypes.
1259
1260 * window.c (resize_window_apply): Make definition be "static" to
1261 match the prototype.
1262
562dd5e9
MR
12632011-06-10 Martin Rudalics <rudalics@gmx.at>
1264
1265 * window.c: Remove declarations of Qwindow_size_fixed,
1266 window_min_size_1, window_min_size_2, window_min_size,
1267 size_window, window_fixed_size_p, enlarge_window, delete_window.
1268 Remove static from declaration of Qdelete_window, it's
1269 temporarily needed by Fbury_buffer.
1270 (replace_window): Don't assign orig_top_line and
1271 orig_total_lines.
1272 (Fdelete_window, delete_window): Remove. Window deletion is
1273 handled by window.el.
1274 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1275 Fdelete_window calls with calls to Qdelete_window.
1276 (Fdelete_other_windows): Remove. Deleting other windows is
1277 handled by window.el.
1278 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1279 handled in window.el.
1280 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1281 Window minimum sizes are handled in window.el.
1282 (shrink_windows, size_window, set_window_height)
1283 (set_window_width, change_window_heights, window_height)
1284 (window_width, CURBEG, CURSIZE, enlarge_window)
1285 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1286 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1287 handled in window.el.
1288 (make_dummy_parent): Rename to make_parent_window and give it a
1289 second argument horflag.
1290 (make_window): Don't set resize_proportionally any more.
1291 (Fsplit_window): Remove. Windows are split in window.el.
1292 (save_restore_action, save_restore_orig_size)
1293 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1294 Resize mini windows in window.el.
1295 (grow_mini_window, shrink_mini_window): Implement by calling
1296 Qresize_root_window_vertically, resize_window_check and
1297 resize_window_apply.
1298 (saved_window, Fset_window_configuration, save_window_save): Do
1299 not handle orig_top_line, orig_total_lines, and
1300 resize_proportionally.
1301 (window_min_height, window_min_width): Move to window.el.
1302 (keys_of_window): Move bindings for delete-other-windows,
1303 split-window, delete-window and enlarge-window to window.el.
1304
1305 * buffer.c: Temporarily extern Qdelete_window.
1306 (Fbury_buffer): Temporarily call Qdelete_window instead of
1307 Fdelete_window (Fbury_buffer will move to window.el soon).
1308
1309 * frame.c (set_menu_bar_lines_1): Remove code handling
1310 orig_top_line and orig_total_lines.
1311
1312 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1313 set_window_height but set heights directly.
1314 (change_frame_size_1): Use resize_frame_windows.
1315
1316 * xdisp.c (init_xdisp): Don't use set_window_height but set
1317 heights directly.
1318
1319 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1320 resize_frame_windows instead of change_window_heights and run
1321 run_window_configuration_change_hook.
1322
1323 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1324 instead of change_window_heights and run
1325 run_window_configuration_change_hook.
1326
1a13852e
MR
13272011-06-09 Martin Rudalics <rudalics@gmx.at>
1328
1329 * window.c (replace_window): Rename second argument REPLACEMENT to
1330 NEW. New third argument SETFLAG. Rewrite.
1331 (delete_window, make_dummy_parent): Call replace_window with
1332 third argument 1.
1333 (window_list_1): Move down in code.
1334 (run_window_configuration_change_hook): Move set_buffer part
1335 before select_frame_norecord part in order to unwind correctly.
1336 Rename count1 to count.
1337 (recombine_windows, delete_deletable_window, resize_root_window)
1338 (Fdelete_other_windows_internal)
1339 (Frun_window_configuration_change_hook, make_parent_window)
1340 (resize_window_check, resize_window_apply, Fresize_window_apply)
1341 (resize_frame_windows, Fsplit_window_internal)
1342 (Fdelete_window_internal, Fresize_mini_window_internal): New
1343 functions.
1344 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1345
f3d1777e
MR
13462011-06-08 Martin Rudalics <rudalics@gmx.at>
1347
496e208e
MR
1348 * window.h (window): Add some new members to window structure -
1349 normal_lines, normal_cols, new_total, new_normal, clone_number,
1350 splits, nest, prev_buffers, next_buffers.
1351 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1352 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1353
f3d1777e
MR
1354 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1355 Remove.
496e208e
MR
1356 (make_dummy_parent): Set new members of windows structure.
1357 (make_window): Move down in code. Handle new members of window
1358 structure.
1359 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1360 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1361 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1362 (Fset_window_prev_buffers, Fwindow_next_buffers)
1363 (Fset_window_next_buffers, Fset_window_clone_number): New
1364 functions.
1365 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1366 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1367 Doc-string fixes.
1368 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1369 Argument WINDOW can be now internal window too.
1370 (Fwindow_use_time): Move up in code.
1371 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1372 Rewrite doc-string.
1373 (Fset_window_configuration, saved_window)
1374 (Fcurrent_window_configuration, save_window_save): Handle new
1375 members of window structure.
b9e809c2
MR
1376 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1377 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1378 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1379 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1380 Qget_mru_window, Qresize_root_window,
1381 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1382 Qauto_buffer_name; staticpro them.
f3d1777e 1383
abde8f8c
MR
13842011-06-07 Martin Rudalics <rudalics@gmx.at>
1385
1386 * window.c (Fwindow_total_size, Fwindow_left_column)
1387 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1388 (Fwindow_list_1): New functions.
1389 (window_box_text_cols): Replace with window_body_cols.
1390 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1391 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1392 (delete_window, Fset_window_configuration): Call
1393 delete_all_subwindows with window as argument.
1394 (delete_all_subwindows): Take a window as argument and not a
1395 structure. Rewrite.
190b47e6
MR
1396 (window_loop): Remove handling of GET_LRU_WINDOW and
1397 GET_LARGEST_WINDOW.
1398 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1399
1400 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1401 window_box_text_cols. delete_all_subwindows now takes a
1402 Lisp_Object as argument.
abde8f8c
MR
1403
1404 * indent.c (compute_motion, Fcompute_motion): Use
1405 window_body_cols instead of window_box_text_cols.
1406
fa8a67e6
MR
1407 * frame.c (delete_frame): Call delete_all_subwindows with root
1408 window as argument.
1409
a54e3482
DC
14102011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1411
1412 * fns.c (Fputhash): Document return value.
1413
60002bf5
CY
14142011-06-06 Chong Yidong <cyd@stupidchicken.com>
1415
1416 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1417
0c671da6 14182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1419
b862a52a 1420 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1421
be44ca6c
PE
1422 Check for overflow when converting integer to cons and back.
1423 * charset.c (Fdefine_charset_internal, Fdecode_char):
1424 Use cons_to_unsigned to catch overflow.
1425 (Fencode_char): Use INTEGER_TO_CONS.
1426 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1427 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1428 * data.c (long_to_cons, cons_to_long): Remove.
1429 (cons_to_unsigned, cons_to_signed): New functions.
1430 These signal an error for invalid or out-of-range values.
1431 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1432 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1433 * font.c (Ffont_variation_glyphs):
1434 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1435 * lisp.h: Include <intprops.h>.
1436 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1437 (cons_to_signed, cons_to_unsigned): New decls.
1438 (long_to_cons, cons_to_long): Remove decls.
1439 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1440 (Fprimitive_undo): Use CONS_TO_INTEGER.
1441 * xfns.c (Fx_window_property): Likewise.
1442 * xselect.c: Include <limits.h>.
1443 (x_own_selection, selection_data_to_lisp_data):
1444 Use INTEGER_TO_CONS.
1445 (x_handle_selection_request, x_handle_selection_clear)
1446 (x_get_foreign_selection, Fx_disown_selection_internal)
1447 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1448 (lisp_data_to_selection_data): Use cons_to_unsigned.
1449 (x_fill_property_data): Use cons_to_signed.
1450 Report values out of range.
1451
d1f3d2af
PE
1452 Check for buffer and string overflow more precisely.
1453 * buffer.h (BUF_BYTES_MAX): New macro.
1454 * lisp.h (STRING_BYTES_MAX): New macro.
1455 * alloc.c (Fmake_string):
1456 * character.c (string_escape_byte8):
1457 * coding.c (coding_alloc_by_realloc):
1458 * doprnt.c (doprnt):
1459 * editfns.c (Fformat):
1460 * eval.c (verror):
1461 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1462 since they may not be the same number.
1463 * editfns.c (Finsert_char):
1464 * fileio.c (Finsert_file_contents):
1465 Likewise for BUF_BYTES_MAX.
1466
dd52fcea
PE
1467 * image.c: Use ptrdiff_t, not int, for sizes.
1468 (slurp_file): Switch from int to ptrdiff_t.
1469 All uses changed.
1470 (slurp_file): Check that file size fits in both size_t (for
1471 malloc) and ptrdiff_t (for sanity and safety).
1472
7f9bbdbb
PE
1473 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1474 if b->modtime has its maximal value.
1475
dfe18f82
PE
1476 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1477
84acfcf0
PE
1478 Don't assume time_t can fit into int.
1479 * buffer.h (struct buffer.modtime): Now time_t, not int.
1480 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1481 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1482
ccd9a01a
PE
1483 Minor fixes for signed vs unsigned integers.
1484 * character.h (MAYBE_UNIFY_CHAR):
1485 * charset.c (maybe_unify_char):
1486 * keyboard.c (read_char, reorder_modifiers):
1487 XINT -> XFASTINT, since the integer must be nonnegative.
1488 * ftfont.c (ftfont_spec_pattern):
1489 * keymap.c (access_keymap, silly_event_symbol_error):
1490 XUINT -> XFASTINT, since the integer must be nonnegative.
1491 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1492 since it makes no difference and we prefer signed.
1493 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1494 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1495 nonnegative.
1496
d6d100dd
SM
14972011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1498
1499 * window.h (Fwindow_frame): Declare.
1500
2b6148e4
PE
15012011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1504 (SPARE_MEMORY): Always define.
1505 (LARGE_REQUEST): Remove.
1506 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1507
f230ecc9
MR
15082011-06-06 Martin Rudalics <rudalics@gmx.at>
1509
727e958e
MR
1510 * lisp.h: Move EXFUNS for Fframe_root_window,
1511 Fframe_first_window and Fset_frame_selected_window to window.h.
1512
1513 * window.h: Move EXFUNS for Fframe_root_window,
1514 Fframe_first_window and Fset_frame_selected_window here from
1515 lisp.h.
1516
1517 * frame.c (Fwindow_frame, Fframe_first_window)
1518 (Fframe_root_window, Fframe_selected_window)
1519 (Fset_frame_selected_window): Move to window.c.
1520 (Factive_minibuffer_window): Move to minibuf.c.
1521 (Fother_visible_frames_p): New function.
1522
1523 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1524
f230ecc9
MR
1525 * window.c (decode_window, decode_any_window): Move up in code.
1526 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1527 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1528 (Fwindow_buffer): Move up and rewrite doc-string.
1529 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1530 (Fwindow_prev): New functions.
727e958e
MR
1531 (Fwindow_frame): Move here from frame.c. Accept any window as
1532 argument.
1533 (Fframe_root_window, Fframe_first_window)
1534 (Fframe_selected_window): Move here from frame.c. Accept frame
1535 or arbitrary window as argument. Update doc-strings.
1536 (Fminibuffer_window): Move up in code.
1537 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1538 (Fset_frame_selected_window): Move here from frame.c.
1539 Marginal rewrite.
727e958e
MR
1540 (Fselected_window, select_window, Fselect_window): Move up in
1541 code. Minor doc-string fixes.
f230ecc9 1542
4d09bcf6
PE
15432011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1546 Do not assume that spare memory exists; that assumption is valid
1547 only if SYSTEM_MALLOC.
1548 (LARGE_REQUEST): New macro, so that the issue of large requests
1549 is separated from the issue of spare memory.
1550
810928a2
AS
15512011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1552
172418ad
AS
1553 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1554 format. (Bug#8806)
1555
43f862f7
AS
1556 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1557
810928a2
AS
1558 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1559 before statements.
1560
a059fe24
JD
15612011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1562
1563 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1564
1565 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1566
1567 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1568 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1569
989bf368
JB
15702011-06-05 Juanma Barranquero <lekktu@gmail.com>
1571
1572 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1573
4b80f674
CY
15742011-06-04 Chong Yidong <cyd@stupidchicken.com>
1575
1576 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1577 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1578 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1579 New error handlers.
4b80f674
CY
1580 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1581 Obey Vx_select_enable_clipboard_manager. Catch errors in
1582 x_clipboard_manager_save (Bug#8779).
1583 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1584 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1585
99a33b77 15862011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1587
1588 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1589
99a33b77 15902011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1591
1592 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1593 in the current matrix if keep_current_p is non-zero.
1594
8264569d
EZ
15952011-06-04 Eli Zaretskii <eliz@gnu.org>
1596
1597 * bidi.c (bidi_level_of_next_char): Fix last change.
1598
57f97249
EZ
15992011-06-03 Eli Zaretskii <eliz@gnu.org>
1600
fec2107c 1601 Support bidi reordering of text covered by display properties.
57f97249 1602
fec2107c
EZ
1603 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1604 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1605 (bidi_cache_search, bidi_cache_iterator_state)
1606 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1607 (bidi_level_of_next_char, bidi_move_to_visually_next):
1608 Support character positions inside a run of characters covered by a
fec2107c
EZ
1609 display string.
1610 (bidi_paragraph_init, bidi_resolve_explicit_1)
1611 (bidi_level_of_next_char): Call bidi_fetch_char and
1612 bidi_fetch_char_advance instead of FETCH_CHAR and
1613 FETCH_CHAR_ADVANCE.
1614 (bidi_init_it): Initialize new members.
1615 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1616 definitions.
1617 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1618 instead of using explicit *_CHAR codes.
d6d100dd
SM
1619 (bidi_resolve_explicit, bidi_resolve_weak):
1620 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1621 bidirectional text is supported only in multibyte buffers.
1622 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1623 it to initialize the frame_window_p member of struct bidi_it.
1624 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1625 (bidi_resolve_explicit, bidi_resolve_weak)
1626 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1627 bidi_it->nchars is non-positive.
1628 (bidi_level_of_next_char): Don't try to lookup the cache for the
1629 next/previous character if nothing is cached there yet, or if we
1630 were just reseat()'ed to a new position.
c40e2fb2 1631
0e14fe90
EZ
1632 * xdisp.c (set_cursor_from_row): Set start and stop points
1633 according to the row's direction when priming the loop that looks
1634 for the glyph on which to display cursor.
1635 (single_display_spec_intangible_p): Function deleted.
1636 (display_prop_intangible_p): Reimplement to call
1637 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1638 Accept 3 additional arguments needed by handle_display_spec.
1639 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1640 values: lists, `(when COND...)' forms, etc.
1641 (single_display_spec_string_p): Support property values that are
1642 lists with the argument STRING its top-level element.
1643 (display_prop_string_p): Fix the condition for processing a
1644 property that is a list to be consistent with handle_display_spec.
fec2107c 1645 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1646 last portion of handle_display_prop.
1647 (compute_display_string_pos): Accept additional argument
1648 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1649 value of a `display' property is a "replacing spec".
1650 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1651 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1652 the display property, but just return a value indicating whether
1653 the display property will replace the characters it covers.
1654 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1655 frame_window_p members of struct bidi_it.
d6d100dd
SM
1656 (compute_display_string_pos, compute_display_string_end):
1657 New functions.
fec2107c
EZ
1658 (push_it): Accept second argument POSITION, where pop_it should
1659 jump to continue iteration.
1660 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1661
fec2107c
EZ
1662 * keyboard.c (adjust_point_for_property): Adjust the call to
1663 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1664
1665 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1666 (bidi_init_it): Update prototypes.
1667 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1668 (compute_display_string_pos, compute_display_string_end):
1669 Declare prototypes.
fec2107c
EZ
1670 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1671 EMACS_INT.
fc6f18ce 1672
40087514 16732011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1674
57f53182
PE
1675 Malloc failure behavior now depends on size of allocation.
1676 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1677 * lisp.h: Change signatures accordingly.
1678 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1679 All callers changed. (Bug#8762)
1680
1681 * gnutls.c: Use Emacs's memory allocators.
1682 Without this change, the gnutls library would invoke malloc etc.
1683 directly, which causes problems on non-SYNC_INPUT hosts, and which
1684 runs afoul of improving memory_full behavior. (Bug#8761)
1685 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1686 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1687 xfree instead of the default malloc, realloc, free.
1688 (Fgnutls_boot): No need to check for memory allocation failure,
1689 since xmalloc does that for us.
1690
ac32cd99 1691 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1692 * category.c (hash_get_category_set):
1693 * ccl.c (ccl_driver):
1694 * charset.c (Fdefine_charset_internal):
1695 * charset.h (struct charset.hash_index):
1696 * composite.c (get_composition_id, gstring_lookup_cache)
1697 (composition_gstring_put_cache):
1698 * composite.h (struct composition.hash_index):
1699 * dispextern.h (struct image.hash):
1700 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1701 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1702 (hashfn_equal, hashfn_user_defined, make_hash_table)
1703 (maybe_resize_hash_table, hash_lookup, hash_put)
1704 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1705 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1706 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1707 * image.c (make_image, search_image_cache, lookup_image)
1708 (xpm_put_color_table_h):
1709 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1710 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1711 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1712 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1713 * alloc.c (allocate_vectorlike):
1714 Check for overflow in vector size calculations.
1715 * ccl.c (ccl_driver):
1716 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1717 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1718 need to be updated by these changes.
40087514
PE
1719 * fns.c (make_hash_table, maybe_resize_hash_table):
1720 Check for integer overflow with large hash tables.
0de4bb68
PE
1721 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1722 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1723 (SXHASH_REDUCE): New macro.
1724 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1725 Use it instead of discarding useful hash info with large hash values.
1726 (sxhash_float): New function.
1727 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1728 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1729 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1730 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1731 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1732 Adjust signatures to match updated version of code.
1733 (consing_since_gc): Now EMACS_INT, since a single hash table can
1734 use more than INT_MAX bytes.
1735
698d32e2
DN
17362011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1737
1738 Make it possible to build with GCC-4.6+ -O2 -flto.
1739
1740 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1741
fd6fa53f
SM
17422011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1743
1744 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1745 Call minibuffer-inactive-mode.
1746
864db017
JB
17472011-05-31 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1750 Update dependencies.
1751
2ad0baf4
DN
17522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1753
1754 * data.c (init_data): Remove code for UTS, this system is not
1755 supported anymore.
1756
4fcc2638
DN
17572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1758
1759 Don't force ./temacs to start in terminal mode.
1760
1761 * frame.c (make_initial_frame): Initialize faces in all cases, not
1762 only when CANNOT_DUMP is defined.
1763 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1764
c56e0fd5
DN
17652011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1766
1767 * dispnew.c (add_window_display_history): Use const for the string
1768 pointer. Remove declaration, not needed.
1769
333d54da 17702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1771
55d4c1b2 1772 Use 'inline', not 'INLINE'.
333d54da 1773 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1774 * alloc.c, fontset.c (INLINE): Remove.
1775 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1776 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1777 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1778 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1779 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1780
738db178
DN
17812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1782
1783 Make it possible to run ./temacs.
1784
1785 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1786 syms_of_callproc does the same thing. Remove test for
1787 "initialized", do it in the caller.
1788 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1789
620c53a6
SM
17902011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1791
1792 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1793 (read_minibuf): Use get_minibuffer.
1794 (syms_of_minibuf): Use DEFSYM.
1795 (Qmetadata): New var.
1796 * data.c (Qbuffer): Don't make it static.
1797 (syms_of_data): Use DEFSYM.
1798
e003a292
PE
17992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1802 (CCL_CODE_MIN): New macro.
1803
ed008a6d
PE
18042011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1805
3687c2ef
PE
1806 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1807
ed008a6d
PE
1808 * eval.c (Qdebug): Now static.
1809 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1810 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1811 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1812
d66c4c7c
CY
18132011-05-29 Chong Yidong <cyd@stupidchicken.com>
1814
1815 * image.c: Various fixes to ImageMagick code comments.
1816 (Fimagemagick_types): Doc fix.
1817
5fbc2025
PE
18182011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1819
0196f88a
PE
1820 Minor fixes prompted by GCC 4.6.0 warnings.
1821
1822 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1823
5fbc2025
PE
1824 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1825 (x_clipboard_manager_save_all): Move extern decl to ...
1826 * xterm.h: ... here, so that it can be checked for consistency.
1827
1dd3c2d9
CY
18282011-05-29 Chong Yidong <cyd@stupidchicken.com>
1829
1830 * xselect.c (x_clipboard_manager_save_frame)
1831 (x_clipboard_manager_save_all): New functions.
1832 (Fx_clipboard_manager_save): Lisp function deleted.
1833
1834 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1835 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1836
1837 * xterm.h: Update prototype.
1838
5ba6571d
WX
18392011-05-28 William Xu <william.xwl@gmail.com>
1840
1841 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1842 exiting (Bug#8239).
1843
3eaff834
JM
18442011-05-28 Jim Meyering <meyering@redhat.com>
1845
e1900994 1846 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1847 * fns.c (to_uchar): Define.
1848 (crypto_hash_function): Use it to convert some newly-signed
1849 variables to unsigned, to avoid sign-extension bugs. For example,
1850 without this change, (md5 "truc") would evaluate to
1851 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1852 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1853 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1854
0f6990a7
PE
18552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 Integer overflow fixes.
c8a9ca5a 1858
08686060
PE
1859 * dbusbind.c: Serial number integer overflow fixes.
1860 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1861 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1862 to hold a serial number that is too large for a fixnum.
1863 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1864 Check for serial numbers out of range. Decode any serial number
59568bf0 1865 that was so large that it became a float. (Bug#8722)
08686060 1866
2d1fc3c7
PE
1867 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1868 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1869 Use XFASTINT rather than XUINT when numbers are nonnegative.
1870 (xd_append_arg, Fdbus_method_return_internal):
1871 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1872 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1873 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1874 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1875 (Bug#8722)
2d1fc3c7 1876
c8a9ca5a
PE
1877 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1878
519e1d69
PE
1879 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1880
30569699
PE
1881 ccl: add integer overflow checks
1882 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1883 (IN_INT_RANGE): New macros.
1884 (ccl_driver): Use them to check for integer overflow when
1885 decoding a CCL program. Many of the new checks are whether XINT (x)
1886 fits in int; it doesn't always, on 64-bit hosts. The new version
1887 doesn't catch all possible integer overflows, but it's an
847044ea 1888 improvement. (Bug#8719)
30569699 1889
c11285dc
PE
1890 * alloc.c (make_event_array): Use XINT, not XUINT.
1891 There's no need for unsigned here.
1892
fdccd48e
PE
1893 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1894 This follows up to the 2011-05-06 change that substituted uintptr_t
1895 for EMACS_INT. This case wasn't caught back then.
1896
37910ab2
PE
1897 Rework Fformat to avoid integer overflow issues.
1898 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1899 now (part of C89). Include <verify.h>.
1900 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1901 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1902 (Fformat): Avoid the prepass trying to compute sizes; it was only
1903 approximate and thus did not catch overflow reliably. Instead, walk
1904 through the format just once, formatting and computing sizes as we go,
1905 checking for integer overflow at every step, and allocating a larger
1906 buffer as needed. Keep track separately whether the format is
1907 multibyte. Keep only the most-recently calculated precision, rather
1908 than them all. Record whether each argument has been converted to
1909 string. Use EMACS_INT, not int, for byte and char and arg counts.
1910 Support field widths and precisions larger than INT_MAX. Avoid
1911 sprintf's undefined behavior with conversion specifications such as %#d
1912 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1913 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1914 formatting out-of-range floating point numbers with int
9173deec 1915 formats. (Bug#8668)
37910ab2 1916
2e6578fb
PE
1917 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1918
0ae6bdee
PE
1919 * data.c: Avoid integer truncation in expressions involving floats.
1920 * data.c: Include <intprops.h>.
1921 (arith_driver): When there's an integer overflow in an expression
1922 involving floating point, convert the integers to floating point
1923 so that the resulting value does not suffer from catastrophic
1924 integer truncation. For example, on a 64-bit host (* 4
1925 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1926 Do not rely on undefined behavior after integer overflow.
1927
de883a70
PE
1928 merge count_size_as_multibyte, parse_str_to_multibyte
1929 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1930 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1931 Check for integer overflow.
1932 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1933 since it's now a duplicate of the other. This is more of
1934 a character than a buffer op, so better that it's in character.c.
1935 * fns.c, print.c: Adjust to above changes.
1936
2ff916cb
PE
19372011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1938
1939 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1940
f1b54466
PE
19412011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1942
fb1ac845
PE
1943 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1944 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1945 (x_clipboard_manager_save): Now static.
1946 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1947
f1b54466
PE
1948 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1949 (crypto_hash_function): Now static.
1950 Fix pointer signedness problems. Avoid unnecessary initializations.
1951
a9f737ee
CY
19522011-05-27 Chong Yidong <cyd@stupidchicken.com>
1953
1954 * termhooks.h (Vselection_alist): Make it terminal-local.
1955
1956 * terminal.c (create_terminal): Initialize it.
1957
1958 * xselect.c: Support for clipboard managers.
1959 (Vselection_alist): Move to termhooks.h as terminal-local var.
1960 (LOCAL_SELECTION): New macro.
1961 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1962 (symbol_to_x_atom): Remove gratuitous arg.
1963 (x_handle_selection_request, lisp_data_to_selection_data)
1964 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1965 (x_own_selection, x_get_local_selection, x_convert_selection):
1966 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1967 (some_frame_on_display): Delete unused function.
1968 (Fx_own_selection_internal, Fx_get_selection_internal)
1969 (Fx_disown_selection_internal, Fx_selection_owner_p)
1970 (Fx_selection_exists_p): New optional frame arg.
1971 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1972 (x_handle_selection_clear): Don't treat other terminals with the
1973 same keyboard specially. Use the terminal-local Vselection_alist.
1974 (x_clear_frame_selections): Use Frun_hook_with_args.
1975
1976 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1977
1978 * xterm.h: Add support for those atoms.
1979
e067f0c1
CY
19802011-05-26 Chong Yidong <cyd@stupidchicken.com>
1981
1982 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1983 (converted_selections, conversion_fail_tag): New global variables.
1984 (x_selection_request_lisp_error): Free the above.
1985 (x_get_local_selection): Remove unnecessary code.
1986 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1987 of converted selections stored in converted_selections.
1988 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1989 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1990 (x_convert_selection): New function.
1991 (x_handle_selection_event): Simplify.
1992 (x_get_foreign_selection): Don't ignore incoming requests while
1993 waiting for an answer; this will fail when we implement
1994 SAVE_TARGETS, and seems unnecessary anyway.
1995 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1996 (Vx_sent_selection_functions): Doc fix.
1997
0f4aebc0
LL
19982011-05-26 Leo Liu <sdl.web@gmail.com>
1999
2000 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2001
e61124cd
YM
20022011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2003
2004 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2005
2006 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2007 for fringe update if it has periodic bitmap.
2008 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2009 and fringe_bitmap_periodic_p.
2010
2011 * fringe.c (get_fringe_bitmap_data): New function.
2012 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2013 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2014 row. Mark glyph row for fringe update if periodicity changed.
2015
2016 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2017 for fringe update unless it has periodic bitmap.
2018
f16d9837
KH
20192011-05-25 Kenichi Handa <handa@m17n.org>
2020
2021 * xdisp.c (get_next_display_element): Set correct it->face_id for
2022 a static composition.
2023
e1b90ef6
LL
20242011-05-24 Leo Liu <sdl.web@gmail.com>
2025
2026 * deps.mk (fns.o):
2027 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2028
2029 * fns.c (crypto_hash_function, Fsha1): New function.
2030 (Fmd5): Use crypto_hash_function.
2031 (syms_of_fns): Add Ssha1.
2032
7400048f
PE
20332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 * gnutls.c: Remove unused macros.
2036 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2037 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2038 Remove macros that are defined and never used.
2039 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2040
abb71cf4
CY
20412011-05-22 Chong Yidong <cyd@stupidchicken.com>
2042
2043 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2044 (Fx_get_selection_internal): Minor cleanup.
2045 (Fx_own_selection_internal): Rename arguments for consistency with
2046 select.el.
2047
6307db39
PE
20482011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2049
2050 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2051
f3d4e0a4
CY
20522011-05-22 Chong Yidong <cyd@stupidchicken.com>
2053
2054 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2055
4d8ade89
YM
20562011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2057
2058 * dispnew.c (scrolling_window): Don't exclude the case that the
2059 last enabled row in the desired matrix touches the bottom boundary.
2060
32078c8d
GM
20612011-05-21 Glenn Morris <rgm@gnu.org>
2062
2063 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2064 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2065 and add some more files.
32078c8d 2066
7285dc67
EZ
20672011-05-20 Eli Zaretskii <eliz@gnu.org>
2068
2069 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2070 report_file_error introduced by the change from 2011-05-07.
2071
89d1bd22
PE
20722011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 * systime.h (Time): Define only if emacs is defined.
2075 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2076 where the include path doesn't have X11/X.h by default. See
2077 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2078
e23640bb 20792011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2080
2081 * composite.c (find_automatic_composition): Fix previous change.
2082
b9704ad9
GM
20832011-05-20 Glenn Morris <rgm@gnu.org>
2084
2085 * lisp.mk: New file, split from Makefile.in.
2086 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2087 (shortlisp): Remove.
2088 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2089
4a720484
GM
20902011-05-19 Glenn Morris <rgm@gnu.org>
2091
2092 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2093 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2094 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2095 (lisp): Set the order to that of loadup.el.
2096 (shortlisp): Make it a copy of $lisp.
2097 (SOME_MACHINE_LISP): Remove.
2098 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2099 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2100
a28d4396
KH
21012011-05-18 Kenichi Handa <handa@m17n.org>
2102
2103 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2104 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2105 (find_automatic_composition): Mostly rewrite for efficiency.
2106
a2b1fa8e
JB
21072011-05-18 Juanma Barranquero <lekktu@gmail.com>
2108
2109 * makefile.w32-in: Update dependencies.
2110
8e1f5610
CS
21112011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2112
2113 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2114 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2115
7025ee00 21162011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2117
cdfa6eab
PE
2118 Fix some integer overflow issues, such as string length overflow.
2119
06d6db33
PE
2120 * insdel.c (count_size_as_multibyte): Check for string overflow.
2121
2b4560a8
PE
2122 * character.c (lisp_string_width): Check for string overflow.
2123 Use EMACS_INT, not int, for string indexes and lengths; in
2124 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2125 the resulting string length overflows an EMACS_INT; instead,
2126 report a string overflow if no precision given. When checking for
2127 precision exhaustion, use a check that cannot possibly have
2128 integer overflow. (Bug#8675)
2129 * character.h (lisp_string_width): Adjust to new signature.
2130
cb93f9be
PE
2131 * alloc.c (string_overflow): New function.
2132 (Fmake_string): Use it. This doesn't change behavior, but saves
2133 a few bytes and will simplify future changes.
2134 * character.c (string_escape_byte8): Likewise.
2135 * lisp.h (string_overflow): New decl.
2136
1a1f3366
PE
2137 Fixups, following up to the user-interface timestamp change.
2138 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2139 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2140 * msdos.c (mouse_get_pos): Likewise.
2141 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2142 * w32gui.h (Time): Define by including "systime.h" rather than by
2143 declaring it ourselves. (Bug#8664)
2144
d4e3e4d3
PE
2145 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2146 * image.c (clear_image_cache): Likewise.
2147
f6a24d19
PE
2148 * term.c (term_mouse_position): Don't assume time_t wraparound.
2149
08dc5ae6
PE
2150 Be more systematic about user-interface timestamps.
2151 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2152 and sometimes 'EMACS_UINT', to represent these timestamps.
2153 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2154 This makes the code easier to follow, and makes it easier to catch
2155 integer overflow bugs such as Bug#8664.
2156 * frame.c (Fmouse_position, Fmouse_pixel_position):
2157 Use Time, not unsigned long, for user-interface timestamps.
2158 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2159 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2160 * keyboard.h (last_event_timestamp): Likewise.
2161 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2162 * menu.h (xmenu_show): Likewise.
2163 * term.c (term_mouse_position): Likewise.
2164 * termhooks.h (struct input_event.timestamp): Likewise.
2165 (struct terminal.mouse_position_hook): Likewise.
2166 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2167 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2168 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2169 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2170 what it was before.
2171 * menu.h, termhooks.h: Include "systime.h", for Time.
2172
8e55734a
PE
2173 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2174 Don't assume that the difference between two unsigned long values
2175 can fit into an integer. At this point, we know button_down_time
2176 <= event->timestamp, so the difference must be nonnegative, so
2177 there's no need to cast the result if double-click-time is
2178 nonnegative, as it should be; check that it's nonnegative, just in
2179 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2180 apart (about 25 days). (Bug#8664)
8e55734a 2181
841f1b75 2182 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2183 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2184
3e26f69c
PE
2185 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2186 that always fit in int. Use a sentinel instead of a counter, to
2187 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2188 * frame.h (struct frame): Use int for menu_bar_items_used
2189 instead of EMACS_INT, since it always fits in int.
3e26f69c 2190
5cc152c0
PE
2191 * menu.c (grow_menu_items): Check for int overflow.
2192
d89eb65e
PE
2193 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2194
5235bd3e
PE
2195 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2196 Before, the code was not consistent. These values cannot exceed
2197 2**31 - 1 so there's no need to make them unsigned.
2198 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2199 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2200 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2201 as modifiers.
2202 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2203
bc827e23
PE
2204 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2205 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2206 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2207 presumably because the widths might not match.
2208
78eb494e
PE
2209 * window.c (size_window): Avoid needless test at loop start.
2210
04f2d78b
CB
22112011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2212
2213 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2214
d2fc7e3d 22152011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2216
2217 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2218
d2fc7e3d 22192011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2220
2221 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2222 `width' to `bar_area_x' and `bar_area_width', respectively.
2223 (x_scroll_run): Take account of fringe background extension.
2224
04f2d78b
CB
2225 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2226 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2227 `bar_area_width', respectively.
2228 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2229 background extension.
2230
79b70037
GM
22312011-05-10 Jim Meyering <meyering@redhat.com>
2232
2233 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2234
2f142cc5
JB
22352011-05-10 Juanma Barranquero <lekktu@gmail.com>
2236
2237 * image.c (Finit_image_library): Return t for built-in image types,
2238 like pbm and xbm. (Bug#8640)
2239
57679c86
AS
22402011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2241
2242 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2243
888c9e86
EZ
22442011-05-07 Eli Zaretskii <eliz@gnu.org>
2245
b0512a1d
EZ
2246 * w32console.c (Fset_screen_color): Doc fix.
2247 (Fget_screen_color): New function.
2248 (syms_of_ntterm): Defsubr it.
2249
7285dc67
EZ
2250 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2251 unlink the temporary file if Fcall_process didn't create it in the
2252 first place.
2253 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2254 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2255 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2256 cue to call_process_cleanup not to close that handle.
2257
4d3fcc8e
BK
22582011-05-07 Ben Key <bkey76@gmail.com>
2259
2260 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2261 one of two shell specific rules, either bootstrap-temacs-CMD or
2262 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2263 to the previous implementation of the bootstrap-temacs rule.
2264 The bootstrap-temacs-CMD rule is similar to the previous
2265 implementation of the bootstrap-temacs rule except that it
2266 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2267 variable.
2268
2269 These changes, along with some changes to nt/configure.bat,
2270 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2271 earlier fix to add support for --cflags and --ldflags options
2272 that include quotes so that it works whether make uses cmd or
2273 sh as the shell.
2274
b4289b64
MA
22752011-05-06 Michael Albinus <michael.albinus@gmx.de>
2276
2277 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2278 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2279 is a constant.
2280 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2281 a string. Handle both cases.
2282 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2283 (Fdbus_register_method): Use Qinvalid_function.
2284
af4c0e28
JB
22852011-05-06 Juanma Barranquero <lekktu@gmail.com>
2286
2287 * makefile.w32-in: Update dependencies.
2288 (LISP_H): Add inttypes.h and stdin.h.
2289 (PROCESS_H): Add unistd.h.
2290
c51453d9
EZ
22912011-05-06 Eli Zaretskii <eliz@gnu.org>
2292
2293 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2294 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2295
8ff0ac3c 22962011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2297
4c4b566b
PE
2298 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2299
aab2b9b5
PE
2300 * term.c (vfatal): Remove stray call to va_end.
2301 It's not needed and the C Standard doesn't allow it here anyway.
2302
c378da0b
PE
2303 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2304 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2305
288b08c7
PE
2306 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2307 bytes.
2308
e3601888
PE
2309 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2310
db6c0e74
PE
2311 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2312
dd5963ea
PE
2313 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2314
88c9450f
PE
2315 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2316
2f9442b8
PE
2317 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2318
c032b5f8
PE
2319 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2320 * charset.c (Fdefine_charset_internal): Don't initialize
2321 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2322 32-bit int (Bug#8600).
a108c10b
PE
2323
2324 * lread.c (read_integer): Be more consistent with string-to-number.
2325 Use string_to_number to do the actual conversion; this avoids
2326 rounding errors and fixes some other screwups. Without this fix,
2327 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2328 (digit_to_number): Move earlier, for benefit of read_integer.
2329 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2330 not a digit in any supported base. (Bug#8602)
a108c10b 2331
ad5f9eea
PE
2332 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2333
aec1708a
PE
2334 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2335 to match comment at start of function. This also removes a
2336 GCC warning about overflow in a 32+64-bit port.
2337
47be4ab5
PE
2338 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2339
371cac43
PE
2340 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2341 Reported by Stefan Monnier in
2342 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2343 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2344 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2345
d01a7826
PE
2346 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2347 (EMACS_UINTPTR): Likewise, with uintptr_t.
2348
7fd47d5c
PE
2349 * lisp.h: Prefer 64-bit EMACS_INT if available.
2350 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2351 on 32-bit hosts that have 64-bit int, so that they can access
2352 large files.
122b0c86
PE
2353 However, temporarily disable this change unless the temporary
2354 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2355
8727937b
PE
2356 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2357
8ac068ac
PE
2358 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2359 This removes an assumption that EMACS_INT and long are the same
2360 width as pointers. The assumption is true for Emacs porting targets
2361 now, but we want to make other targets possible.
2362 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2363 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2364 In the rest of the code, change types of integers that hold casted
2365 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2366 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2367 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2368 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2369 No need to cast type when ORing.
2370 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2371 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2372 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2373 assume EMACS_INT is the same width as char *.
2374 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2375 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2376 Remove no-longer-needed casts.
2377 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2378 (xg_tool_bar_help_callback, xg_make_tool_item):
2379 Use EMACS_INTPTR to hold an integer
2380 that will be cast to void *; this can avoid a GCC warning
2381 if EMACS_INT is not the same width as void *.
2382 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2383 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2384 (current_message_1, set_message_1):
2385 Use a local to convert to proper width without a cast.
2386 * xmenu.c (dialog_selection_callback): Likewise.
2387
ede49d71
PE
2388 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2389 Also, don't assume VALBITS / RAND_BITS is less than 5,
2390 and don't rely on undefined behavior when shifting a 1 left into
2391 the sign bit.
2392 * lisp.h (get_random): Change signature to match.
2393
2f30ecd0
PE
2394 * lread.c (hash_string): Use size_t, not int, for hash computation.
2395 Normally we prefer signed values; but hashing is special, because
2396 it's better to use unsigned division on hash table sizes so that
2397 the remainder is nonnegative. Also, size_t is the natural width
2398 for hashing into memory. The previous code used 'int', which doesn't
2399 retain enough info to hash well into very large tables.
2400 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2401
2a866e7b
PE
2402 * dbusbind.c: Don't possibly lose pointer info when converting.
2403 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2404 Use XPNTR rather than XHASH, so that the high-order bits of
2405 the pointer aren't lost when converting through void *.
2406
51639eac
PE
2407 * eval.c (Fautoload): Don't double-shift a pointer.
2408
92394119
PE
2409 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2410
dbdb9a7c
JB
24112011-05-06 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * gnutls.c (DEF_GNUTLS_FN):
2414 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2415
db7a0b4f
AS
24162011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2417
2418 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2419 marker. (Bug#8610)
2420
f7ff1b0f 24212011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2422
2423 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2424 New version that can reserve upto 2GB of heap space.
2425
f7ff1b0f 24262011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2427
2428 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2429
639c109b
TZ
24302011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2431
2432 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2433 `gnutls_certificate_set_x509_key_file'.
2434
d2127135
JB
24352011-05-05 Juanma Barranquero <lekktu@gmail.com>
2436
2437 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2438 Update dependencies.
2439
e968f4f3
JB
24402011-05-04 Juanma Barranquero <lekktu@gmail.com>
2441
2442 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2443 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2444 Remove unused parameter `fildes'.
2445 * process.c (read_process_output, send_process): Don't pass it.
2446
84d358f0
JB
24472011-05-04 Juanma Barranquero <lekktu@gmail.com>
2448
2449 Fix previous change: the library cache is defined in w32.c.
2450 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2451 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2452
0898ca10
JB
24532011-05-04 Juanma Barranquero <lekktu@gmail.com>
2454
2455 Implement dynamic loading of GnuTLS on Windows.
2456
2457 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2458 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2459 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2460 Declare.
2461
2462 * gnutls.c (Qgnutls_dll): Define.
2463 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2464 (gnutls_*): Declare function pointers.
2465 (init_gnutls_functions): New function to initialize function pointers.
2466 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2467 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2468 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2469 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2470 (emacs_gnutls_write, emacs_gnutls_read)
2471 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2472 (Fgnutls_available_p): New function.
2473 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2474 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2475 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2476
2477 * image.c: Include w32.h.
2478 (Vimage_type_cache): Delete.
2479 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2480 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2481 (w32_delayed_load): Move to w32.c.
2482
2483 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2484
2485 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2486 (w32_delayed_load): Move from image.c. When loading a library, record
2487 its filename in the :loaded-from property of the library id.
2488 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2489 Initialize and staticpro them.
2490 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2491
2492 * process.c: Include lisp.h before w32.h, not after.
2493 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2494 instead of gnutls_record_check_pending.
2495
2496 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2497
ff4de4aa
TZ
24982011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2499
2500 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2501 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2502 as passed in.
2503
abe95abb
JD
25042011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2505
2506 * xterm.c (x_set_frame_alpha): Do not set property on anything
2507 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2508
e16e55d4
JB
25092011-05-02 Juanma Barranquero <lekktu@gmail.com>
2510
2511 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2512
bafcf6a5
JB
25132011-05-02 Juanma Barranquero <lekktu@gmail.com>
2514
2515 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2516 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2517 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2518 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2519 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2520 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2521 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2522 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2523 (Qgnutls_bootprop_callbacks_verify): Make static.
2524
e7a6747f
AS
25252011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2526
19ed11ba
AS
2527 * callproc.c: Indentation fixup.
2528
e7a6747f 2529 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2530 (wait_for_termination, interruptible_wait_for_termination):
2531 Move after wait_for_termination_1.
e7a6747f 2532
1ef14cb4
LMI
25332011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2534
2535 * sysdep.c (interruptible_wait_for_termination): New function
2536 which is like wait_for_termination, but allows keyboard
2537 interruptions.
2538
2539 * callproc.c (Fcall_process): Add (:file "file") as an option for
2540 the STDOUT buffer.
2541 (Fcall_process_region): Ditto.
2542
330d880c
EZ
25432011-04-30 Eli Zaretskii <eliz@gnu.org>
2544
8db90b73
EZ
2545 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2546 rather than `XVECTOR (FOO)->size'.
2547
330d880c
EZ
2548 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2549 inttypes.h, as a gnulib replacement is used if it not available in
2550 system headers.
2551
15cbd324
EZ
25522011-04-21 Eli Zaretskii <eliz@gnu.org>
2553
2554 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2555 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2556 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2557
2558 * coding.c (coding_alloc_by_realloc): Error out if destination
2559 will grow beyond MOST_POSITIVE_FIXNUM.
2560 (decode_coding_emacs_mule): Abort if there isn't enough place in
2561 charbuf for the composition carryover bytes. Reserve an extra
2562 space for up to 2 characters produced in a loop.
2563 (decode_coding_iso_2022): Abort if there isn't enough place in
2564 charbuf for the composition carryover bytes.
2565
25662011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2567
ae940cca
EZ
2568 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2569 aborting when %lld or %lll format is passed.
2570 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2571 %llo or %llx format is passed. (Bug#8545)
2572
03ab8921
EZ
2573 * window.c (window_scroll_line_based): Use a marker instead of
2574 simple variables to record original value of point. (Bug#7952)
2575
afda1437
EZ
2576 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2577 produced by %s or %c overflows available buffer space. (Bug#8545)
2578
f76dee0c
PE
25792011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2580
2581 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2582 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2583
fdc5744d
JB
25842011-04-28 Juanma Barranquero <lekktu@gmail.com>
2585
2586 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2587
638f053a
JB
25882011-04-28 Juanma Barranquero <lekktu@gmail.com>
2589
2590 * keyboard.c (Qdelayed_warnings_hook): Define.
2591 (command_loop_1): Run `delayed-warnings-hook'
2592 if Vdelayed_warnings_list is non-nil.
2593 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2594 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2595
d178f871
EZ
25962011-04-28 Eli Zaretskii <eliz@gnu.org>
2597
2598 * doprnt.c (doprnt): Don't return value smaller than the buffer
2599 size if the message was truncated. (Bug#8545).
2600
b124fd93
JB
26012011-04-28 Juanma Barranquero <lekktu@gmail.com>
2602
2603 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2604 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2605
e810457d
PE
26062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2609
ea51cceb
JB
26102011-04-27 Juanma Barranquero <lekktu@gmail.com>
2611
2612 * makefile.w32-in: Update dependencies.
2613
94dcfacf
EZ
26142011-04-27 Eli Zaretskii <eliz@gnu.org>
2615
2616 Improve `doprnt' and its usage. (Bug#8545)
2617 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2618 `format_end'. Remove support for %l as a conversion specifier.
2619 Don't use xrealloc. Improve diagnostics when the %l size modifier
2620 is used. Update the commentary.
2621
2622 * eval.c (verror): Simplify calculation of size_t.
2623
2624 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2625 messages.
2626
f61f41d7
PE
26272011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2628
2629 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2630 change.
2631
96fb4434
PE
26322011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2635 This makes this file independent of the recent pseudovector change.
2636
671875da 26372011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2638
69e9b5a3
PE
2639 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2640
b5f869a7 2641 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2642 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2643 Remove unused local.
c8926152 2644 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2645
841a1577 2646 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2647 GCC 4.6.0 optimizes based on type-based alias analysis.
2648 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2649 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2650 != &v->size, and therefore "v->size = 1; b->size = 2; return
2651 v->size;" must therefore return 1. This assumption is incorrect
2652 for Emacs, since it type-puns struct Lisp_Vector * with many other
2653 types. To fix this problem, this patch adds a new type struct
f904488f 2654 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2655 and pseudovectors, and helps optimizing compilers not get fooled
2656 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2657 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2658 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2659 the size member.
eab3844f
PE
2660 (XSETPVECTYPE): Rewrite in terms of new macro.
2661 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2662 This is a bit clearer, and further avoids the possibility of
2663 undesirable aliasing.
2664 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2665 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2666 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2667 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2668 (ASIZE): Now uses header.size rather than size.
2669 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2670 to avoid the hassle of writing XVECTOR (foo)->header.size.
2671 (struct vectorlike_header): New type.
eab3844f
PE
2672 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2673 object, to help avoid aliasing.
2674 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2675 (SUBRP): Likewise, since Lisp_Subr is a special case.
2676 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2677 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2678 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2679 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2680 changed to be "header.size" and "header.next".
2681 * buffer.h (struct buffer): Likewise.
2682 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2683 * frame.h (struct frame): Likewise.
2684 * process.h (struct Lisp_Process): Likewise.
2685 * termhooks.h (struct terminal): Likewise.
2686 * window.c (struct save_window_data, struct saved_window): Likewise.
2687 * window.h (struct window): Likewise.
2688 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2689 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2690 * buffer.c (init_buffer_once): Likewise.
2691 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2692 special case.
2693 * process.c (Fformat_network_address): Use local var for size,
2694 for brevity.
2695
0df1eac5
PE
2696 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2697
847ab9d1 2698 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2699 * data.c (atof): Remove decl; no longer used or needed.
2700 (digit_to_number): Move to lread.c.
2701 (Fstring_to_number): Use new string_to_number function, to be
2702 consistent with how the Lisp reader treats infinities and NaNs.
2703 Do not assume that floating-point numbers represent EMACS_INT
2704 without losing information; this is not true on most 64-bit hosts.
2705 Avoid double-rounding errors, by insisting on integers when
2706 parsing non-base-10 numbers, as the documentation specifies.
2707 * lisp.h (string_to_number): New decl, replacing ...
2708 (isfloat_string): Remove.
bc0a5c13 2709 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2710 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2711 appears to have been a coding error. Similarly, do not accept
2712 strings like +-1e0 as floating point numbers. Do not report
2713 overflow for integer overflows unless the base is not 10 which
2714 means we have no simple and reliable way to continue.
2715 Break out the floating-point parsing into a new
2716 function string_to_number, so that Fstring_to_number parses
2717 floating point numbers consistently with the Lisp reader.
04f2d78b 2718 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2719 (E_CHAR, EXP_INT): Remove, replacing with ...
2720 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2721 (string_to_number): New function, replacing isfloat_string.
2722 This function checks for valid syntax and produces the resulting
2723 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2724 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2725 so that overflow for non-base-10 numbers is reported only when
2726 there's no portable and simple way to convert to floating point.
452f4150 2727
67769ffc
PE
2728 * textprop.c (set_text_properties_1): Rewrite for clarity,
2729 and to avoid GCC warning about integer overflow.
2730
c20db43f
PE
2731 * intervals.h (struct interval): Use EMACS_INT for members
2732 where EMACS_UINT might cause problems. See
2733 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2734 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2735 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2736 All uses changed.
37aa2f85
PE
2737 (offset_intervals): Tell GCC not to worry about length overflow
2738 when negating a negative length.
c20db43f 2739
2538aa2f
PE
2740 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2741 (overrun_check_free): Likewise.
2742
f2d3008d
PE
2743 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2744 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2745 word size.
2746
ec8df744
PE
2747 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2748 (gnutls_make_error): Rename local to avoid shadowing.
2749 (gnutls_emacs_global_deinit): ifdef out; not used.
2750 (Fgnutls_boot): Use const for pointer to readonly storage.
2751 Comment out unused local. Fix pointer signedness problems.
2752
640ee02d
PE
2753 * lread.c (openp): Don't stuff size_t into an 'int'.
2754 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2755 about possible signed overflow.
2756
6048fb2a
PE
2757 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2758 (GDK_KEY_g): Don't define if already defined.
2759 (xg_prepare_tooltip): Avoid pointer signedness problem.
2760 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2761
fa3c87e1
PE
2762 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2763 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2764
2172544b
PE
2765 * xfns.c (Fx_window_property): Simplify a bit,
2766 to make a bit faster and to avoid GCC 4.6.0 warning.
2767 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2768
9b821a21
PE
2769 * fns.c (internal_equal): Don't assume size_t fits in int.
2770
3c616cfa
PE
2771 * alloc.c (compact_small_strings): Tighten assertion a little.
2772
c2982e87
PE
2773 Replace pEd with more-general pI, and fix some printf arg casts.
2774 * lisp.h (pI): New macro, generalizing old pEd macro to other
2775 conversion specifiers. For example, use "...%"pI"d..." rather
2776 than "...%"pEd"...".
2777 (pEd): Remove. All uses replaced with similar uses of pI.
2778 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2779 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2780 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2781 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2782 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2783 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2784 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2785 64-bit hosts.
2786 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2787 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2788 * print.c (safe_debug_print, print_object): Likewise.
2789 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2790 to int.
6f04d126
PE
2791 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2792 avoiding the 0 flag, which is not portable.
c2982e87
PE
2793 * process.c (Fmake_network_process): Use pI to avoid cast.
2794 * region-cache.c (pp_cache): Likewise.
2795 * xdisp.c (decode_mode_spec): Likewise.
2796 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2797 behavior on 64-bit hosts with printf arg.
6f04d126 2798 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2799 (x_stop_queuing_selection_requests): Likewise.
2800 (x_get_window_property): Don't truncate byte count to an 'int'
2801 when tracing.
0b432f21 2802
5e073ec7
PE
2803 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2804 here, since it parses constructs like leading '-' and spaces,
2805 which are not wanted; and it overflows with large numbers.
2806 Instead, simply match F[0-9]+, which is what is wanted anyway.
2807
36372bf9
PE
2808 * alloc.c: Remove unportable assumptions about struct layout.
2809 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2810 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2811 (allocate_vectorlike, make_pure_vector): Use the new macros,
2812 plus offsetof, to remove unportable assumptions about struct layout.
2813 These assumptions hold on all porting targets that I know of, but
2814 they are not guaranteed, they're easy to remove, and removing them
2815 makes further changes easier.
2816
0b432f21
PE
2817 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2818 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2819 (string_overrun_cookie): Now const. Use initializers that
2820 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2821 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2822 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2823 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2824 multiple of sizeof (EMACS_INT); it need not be, if
2825 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2826 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2827
895009e1
JB
28282011-04-26 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2831
6a7a1b0b
TZ
28322011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2833
2834 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2835 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2836 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2837
841a1577 28382011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2839
2840 * lisp.h (Qdebug): List symbol.
895009e1 2841 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2842 * keyboard.c (debug-on-event): New variable.
2843 (handle_user_signal): Break into debugger when debug-on-event
2844 matches the current signal symbol.
2845
f2d3ba6f
DN
28462011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2847
2848 * alloc.c (check_sblock, check_string_bytes)
2849 (check_string_free_list): Convert to standard C.
2850
42ce4c63
TZ
28512011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2852
2853 * w32.c (emacs_gnutls_push): Fix typo.
2854
825cd63c
EZ
28552011-04-25 Eli Zaretskii <eliz@gnu.org>
2856
fb11d64d
EZ
2857 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2858 "cast to pointer from integer of different size".
2859
825cd63c
EZ
2860 Improve doprnt and its use in verror. (Bug#8545)
2861 * doprnt.c (doprnt): Document the set of format control sequences
2862 supported by the function. Use SAFE_ALLOCA instead of always
2863 using `alloca'.
2864
2865 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2866 is one byte too soon. Don't use xrealloc; instead xfree and
2867 xmalloc anew.
2868
e061a11b
TZ
28692011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2870
2871 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2872 callbacks stage.
2873
2874 * gnutls.c: Renamed global_initialized to
2875 gnutls_global_initialized. Added internals for the
2876 :verify-hostname-error, :verify-error, and :verify-flags
2877 parameters of `gnutls-boot' and documented those parameters in the
2878 docstring. Start callback support.
9173deec
JB
2879 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2880 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2881 on error. Return error code.
e061a11b
TZ
2882 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2883 (emacs_gnutls_read): Likewise.
2884 (Fgnutls_boot): Return handshake error code.
2885 (emacs_gnutls_handle_error): New function.
2886 (wsaerror_to_errno): Likewise.
2887
2888 * w32.h (emacs_gnutls_pull): Add prototype.
2889 (emacs_gnutls_push): Likewise.
2890
2891 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2892 (emacs_gnutls_push): Likewise.
2893
28942011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2895
2896 * process.c (wait_reading_process_output): Check if GnuTLS
2897 buffered some data internally if no FDs are set for TLS
2898 connections.
2899
2900 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2901 (LIBS): Link to USER_LIBS.
2902 ($(BLD)/gnutls.$(0)): New target.
2903
fa6996bc
EZ
29042011-04-24 Eli Zaretskii <eliz@gnu.org>
2905
eb35682e
EZ
2906 * xdisp.c (handle_single_display_spec): Rename the
2907 display_replaced_before_p argument into display_replaced_p, to
2908 make it consistent with the commentary. Fix typos in the
2909 commentary.
2910
e2ad650c
EZ
2911 * textprop.c (syms_of_textprop): Remove dead code.
2912 (copy_text_properties): Delete obsolete commentary about an
2913 interface that was deleted long ago. Fix typos in the description
2914 of arguments.
2915
1b2de274
EZ
2916 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2917 to changes in oldXMenu/XMenu.h from 2011-04-16.
2918 <menu_help_message, prev_menu_help_message>: Constify.
2919 (IT_menu_make_room): menu->help_text is now `const char **';
2920 adjust.
2921
2922 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2923 to changes in oldXMenu/XMenu.h from 2011-04-16.
2924 (struct XMenu): Declare `help_text' `const char **'.
2925
2926 * xfaces.c <Qunspecified>: Make extern again.
2927
2928 * syntax.c: Include sys/types.h before including regex.h, as
2929 required by Posix.
2930
762b15be
EZ
2931 * doc.c (get_doc_string): Improve the format passed to `error'.
2932
2933 * doprnt.c (doprnt): Improve commentary.
2934
2935 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2936
2937 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2938 them with etags.
2939
f1052e5d
EZ
2940 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2941 changes in globals.h immediately force recompilation.
762b15be
EZ
2942 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2943 $(CURDIR)/s/ms-w32.h.
2944 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2945
fa6996bc
EZ
2946 * character.c (Fchar_direction): Function deleted.
2947 (syms_of_character): Don't defsubr it.
2948 <char-direction-table>: Deleted.
2949
e6c3da20
EZ
29502011-04-23 Eli Zaretskii <eliz@gnu.org>
2951
2952 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2953 * doprnt.c: Include limits.h.
2954 (SIZE_MAX): New macro.
04f2d78b
CB
2955 (doprnt): Return a size_t value. 2nd arg is now size_t.
2956 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2957 Improve overflow protection. Support `l' modifier for integer
2958 conversions. Support %l conversion. Don't assume an EMACS_INT
2959 argument for integer conversions and for %c.
2960
2961 * lisp.h (doprnt): Restore prototype.
2962
2963 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2964 $(SRC)/character.h.
2965
2966 * Makefile.in (base_obj): Add back doprnt.o.
2967
2968 * deps.mk (doprnt.o): Add back prerequisites.
2969 (callint.o): Depend on character.h.
2970
2971 * eval.c (internal_lisp_condition_case): Include the handler
2972 representation in the error message.
2973 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2974 when breaking from the loop.
2975
2976 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2977
2978 * callint.c (Fcall_interactively): When displaying error message
2979 about invalid control letter, pass the character's codepoint, not
2980 a pointer to its multibyte form. Improve display of the character
2981 in octal and display also its hex code.
2982
2983 * character.c (char_string): Use %x to display the (unsigned)
2984 codepoint of an invalid character, to avoid displaying a bogus
2985 negative value.
2986
2987 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2988 `error', not SYMBOL_NAME itself.
2989
2990 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2991 character arguments to `error'.
2992
2993 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2994 to `error' in error message about FINAL_CHAR argument. Make sure
2995 FINAL_CHAR is a character, and use %c when it is passed as
2996 argument to `error'.
2997
4ffd0d6b 29982011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2999
3000 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3001
3002 * w32.c: Include <time.h>.
3003 (sys_localtime): New function.
3004
4ffd0d6b 30052011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3006
3007 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3008
4ffd0d6b 3009 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3010
4ffd0d6b 30112011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3012
4ffd0d6b
GM
3013 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3014 zombies (Bug#8467).
aac0c6e3 3015
04c56954
EZ
30162011-04-19 Eli Zaretskii <eliz@gnu.org>
3017
3018 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3019 gl_state.e_property when gl_state.object is Qt.
3020
3021 * insdel.c (make_gap_larger): Remove limitation of buffer size
3022 to <= INT_MAX.
3023
16a43933
CY
30242011-04-18 Chong Yidong <cyd@stupidchicken.com>
3025
3026 * xdisp.c (lookup_glyphless_char_display)
3027 (produce_glyphless_glyph): Handle cons cell entry in
3028 glyphless-char-display.
3029 (Vglyphless_char_display): Document it.
3030
3031 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3032 glyphless-char-display.
3033
4581706e
CY
30342011-04-17 Chong Yidong <cyd@stupidchicken.com>
3035
3036 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3037
3038 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3039
3040 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3041 definition for no-X builds.
3042
4887c6e2 30432011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3044
fd35b6f9
PE
3045 Static checks with GCC 4.6.0 and non-default toolkits.
3046
5c1ccb01
PE
3047 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3048
006c5daa
PE
3049 * process.c (keyboard_bit_set): Define only if SIGIO.
3050 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3051 (send_process): Repair possible setjmp clobbering.
3052
efc736d3
PE
3053 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3054
4e2fe2e6
PE
3055 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3056
f97334a2
PE
3057 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3058
4e75f29d
PE
3059 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3060 Define only if needed.
3061
90efadd1
PE
3062 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3063 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3064 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3065
3c647824
PE
3066 * dispextern.h (struct redisplay_interface): Rename param
3067 to avoid shadowing.
e264f262 3068 * termhooks.h (struct terminal): Likewise.
761383f4 3069 * xterm.c (xembed_send_message): Likewise.
3c647824 3070
b58c5c4a
PE
3071 * insdel.c (make_gap_smaller): Define only if
3072 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3073
cad59032
PE
3074 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3075 it.
3076
c339dc2e
PE
3077 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3078 so that we aren't warned about unused symbols.
3079
91a3e27b
PE
3080 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3081
399c71d3 3082 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3083
8ffc96f5
PE
3084 * xfns.c (x_real_positions): Mark locals as initialized.
3085
eef9bc79
PE
3086 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3087
098db9dd
PE
3088 * xterm.c: Fix problems found by static analysis with other toolkits.
3089 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3090 (x_dispatch_event): Declare static if USE_GTK, and
3091 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3092 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3093 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3094 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3095 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3096
eb18f6cc
PE
3097 * xmenu.c (menu_help_callback): Pointer type fixes.
3098 Use const pointers when pointing at readonly data. Avoid pointer
3099 signedness clashes.
3100 (FALSE): Remove unused macro.
3101 (update_frame_menubar): Remove unused decl.
3102
1fe72bf8
PE
3103 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3104
60d9e1db
PE
3105 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3106 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3107 (single_menu_item): Rename local to avoid shadowing.
3108
39261c26
PE
3109 * keyboard.c (make_lispy_event): Remove unused local var.
3110
018c5e19
PE
3111 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3112 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3113
63d2b86e
PE
3114 * bitmaps: Change bitmaps from unsigned char back to the X11
3115 compatible char. Avoid the old compiler warnings about
3116 out-of-range initializers by using, for example, '\xab' rather
3117 than 0xab.
3118
aefd87e1
PE
3119 * xgselect.c (xgselect_initialize): Check vs interface
3120 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3121
bf501fb9
PE
3122 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3123
e9829fdf
PE
3124 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3125 to read-only memory.
3126
1086c095
PE
3127 * fns.c (vector): Remove; this old hack is no longer needed.
3128
2baccd04 3129 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3130 Remove unused var.
dde42981 3131 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3132
72391843 3133 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3134
436c16df 3135 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3136 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3137 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3138
92bb796d 3139 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3140 (x_term_init): Remove local to avoid shadowing.
92bb796d 3141
764430a3 3142 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3143
3144 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3145 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3146
d1dfb56c
EZ
31472011-04-16 Eli Zaretskii <eliz@gnu.org>
3148
c4354cb4
EZ
3149 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3150
d1dfb56c
EZ
3151 Fix regex.c, syntax.c and friends for buffers > 2GB.
3152 * syntax.h (struct gl_state_s): Declare character position members
3153 EMACS_INT.
3154
3155 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3156
04f2d78b
CB
3157 * textprop.c (verify_interval_modification, interval_of):
3158 Declare arguments EMACS_INT.
d1dfb56c
EZ
3159
3160 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3161 EMACS_INT.
3162
3163 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3164
3165 * indent.c (Fvertical_motion): Local variable it_start is now
3166 EMACS_INT.
3167
3168 * regex.c (re_match, re_match_2, re_match_2_internal)
3169 (bcmp_translate, regcomp, regexec, print_double_string)
3170 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3171 (re_compile_pattern, re_exec): Declare arguments and local
3172 variables `size_t' and `ssize_t' and return values `regoff_t', as
3173 appropriate.
3174 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3175 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3176 <compile_stack_type>: `size' and `avail' are now `size_t'.
3177
3178 * regex.h <regoff_t>: Use ssize_t, not int.
3179 (re_search, re_search_2, re_match, re_match_2): Arguments that
3180 specify buffer/string position and length are now ssize_t and
3181 size_t. Return type is regoff_t.
3182
613052cd
BK
31832011-04-16 Ben Key <bkey76@gmail.com>
3184
3185 * nsfont.m: Fixed bugs in ns_get_family and
3186 ns_descriptor_to_entity that were caused by using free to
3187 deallocate memory blocks that were allocated by xmalloc (via
3188 xstrdup). This caused Emacs to crash when compiled with
3189 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3190 --enable-checking=xmallocoverrun). xfree is now used to
3191 deallocate these memory blocks.
3192
4170f62f 31932011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3194
71b41406
PE
3195 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3196
9587a89d
PE
3197 emacs_write: Accept and return EMACS_INT for sizes.
3198 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3199 et seq.
3200 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3201 Accept and return EMACS_INT.
3202 (emacs_gnutls_write): Return the number of bytes written on
3203 partial writes.
3204 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3205 (emacs_read, emacs_write): Remove check for negative size, as the
3206 Emacs source code has been audited now.
9587a89d
PE
3207 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3208 (emacs_read, emacs_write): Use it.
273a5f82
PE
3209 * process.c (send_process): Adjust to the new signatures of
3210 emacs_write and emacs_gnutls_write. Do not attempt to store
3211 a byte offset into an 'int'; it might overflow.
9587a89d 3212 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3213
3e047f51
PE
3214 * sound.c: Don't assume sizes fit in 'int'.
3215 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3216 Return EMACS_INT, not int.
3e047f51 3217 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3218 Accept EMACS_INT, not int.
3219 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3220 record read return values.
3221
cc39a9db
BK
32222011-04-15 Ben Key <bkey76@gmail.com>
3223
c9d0ec6d
JB
3224 * keyboard.c (Qundefined): Don't declare static since it is used
3225 in nsfns.m.
3226 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3227 static since they are used in nsfont.m.
cc39a9db 3228
6c60eb9f
SM
32292011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3230
3231 * process.c (Qprocessp): Don't declare static.
3232 * lisp.h (Qprocessp): Declare again.
3233
7990b61a
JB
32342011-04-15 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3237
5d4cb038
PE
32382011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3239
8bd7b830 3240 Improve C-level modularity by making more things 'static'.
cd64ea1d 3241
e3b27b31
PE
3242 Don't publish debugger-only interfaces to other modules.
3243 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3244 (verify_bytepos, count_markers): Move decls to the only modules
3245 that need them.
3246 * region-cache.h (pp_cache): Likewise.
3247 * window.h (check_all_windows): Likewise.
3248 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3249
5d4cb038
PE
3250 * sysdep.c (croak): Now static, if
3251 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3252 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3253
3254 * alloc.c (refill_memory_reserve): Now static if
3255 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3256 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3257
e87b6180
PE
3258 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3259 Define only if USE_LUCID.
3260
ac64929e
PE
3261 * xrdb.c (x_customization_string, x_rm_string): Now static.
3262
6f37259d
PE
3263 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3264 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3265
1683e3ab
PE
3266 * xdisp.c (draw_row_with_mouse_face): Now static.
3267 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3268
de9c2632
PE
3269 * window.h (check_all_windows): Mark externally visible.
3270
2b96acb7
PE
3271 * window.c (window_deletion_count): Now static.
3272
3273 * undo.c: Make symbols static if they're not exported.
3274 (last_undo_buffer, last_boundary_position, pending_boundary):
3275 Now static.
3276
50436f33
PE
3277 * textprop.c (interval_insert_behind_hooks): Now static.
3278 (interval_insert_in_front_hooks): Likewise.
3279
64520e5c
PE
3280 * term.c: Make symbols static if they're not exported.
3281 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3282 (max_frame_lines, tty_set_terminal_modes):
3283 (tty_reset_terminal_modes, tty_turn_off_highlight):
3284 (get_tty_terminal): Now static.
3285 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3286 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3287 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3288 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3289 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3290
1fa53021
PE
3291 * sysdep.c: Make symbols static if they're not exported.
3292 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3293 Now static.
3294 (sigprocmask_set, full_mask): Remove; unused.
3295 (wait_debugging): Mark as visible.
3296 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3297 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3298
d4b43b22
PE
3299 * syntax.c (syntax_temp): Define only if !__GNUC__.
3300
b7c513d0
PE
3301 * sound.c (current_sound_device, current_sound): Now static.
3302
989b29ad
PE
3303 * search.c (searchbufs, searchbuf_head): Now static.
3304
13a55a78
PE
3305 * scroll.c (scroll_cost): Remove; unused.
3306 * dispextern.h (scroll_cost): Remove decl.
3307
de68a1fc
PE
3308 * region-cache.h (pp_cache): Mark as externally visible.
3309
40ccffa6
PE
3310 * process.c: Make symbols static if they're not exported.
3311 (process_tick, update_tick, create_process, chan_process):
3312 (Vprocess_alist, proc_buffered_char, datagram_access):
3313 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3314 (deactivate_process): Mark defn as static, as well as decl.
3315 * lisp.h (create_process): Remove decl.
3316 * process.h (chan_process, Vprocess_alist): Remove decls.
3317
ad64fc97
PE
3318 * print.c: Make symbols static if they're not exported.
3319 (print_depth, new_backquote_output, being_printed, print_buffer):
3320 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3321 (print_interval, print_number_index, initial_stderr_stream):
3322 Now static.
3323 * lisp.h (Fprinc): Remove decl.
3324 (debug_output_compilation_hack): Mark as externally visible.
3325
adddb265
PE
3326 * sysdep.c (croak): Move decl from here to syssignal.h.
3327 * syssignal.h (croak): Put it here, so the API can be checked when
3328 'croak' is called from dissociate_if_controlling_tty.
3329
1717ede2
PE
3330 * minibuf.c: Make symbols static if they're not exported.
3331 (minibuf_save_list, choose_minibuf_frame): Now static.
3332 * lisp.h (choose_minibuf_frame): Remove decl.
3333
fa5fb2bc
PE
3334 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3335
1e3890d1
PE
3336 * lread.c: Make symbols static if they're not exported.
3337 (read_objects, initial_obarray, oblookup_last_bucket_number):
3338 Now static.
3339 (make_symbol): Remove; unused.
3340 * lisp.h (initial_obarray, make_symbol): Remove decls.
3341
8a1414fa
PE
3342 * keyboard.c: Make symbols static if they're not exported.
3343 (single_kboard, recent_keys_index, total_keys, recent_keys):
3344 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3345 (this_single_command_key_start, echoing, last_auto_save):
3346 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3347 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3348 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3349 (Vlispy_mouse_stem, double_click_count):
3350 Now static.
3351 (force_auto_save_soon): Define only if SIGDANGER.
3352 (ignore_mouse_drag_p): Now static if
3353 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3354 (print_help): Remove; unused.
3355 (stop_character, last_timer_event): Mark as externally visible.
3356 * keyboard.h (ignore_mouse_drag_p): Declare only if
3357 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3358 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3359 * lisp.h (echoing): Remove decl.
3360 (force_auto_save_soon): Declare only if SIGDANGER.
3361 * xdisp.c (redisplay_window): Simplify code, to make it more
3362 obvious that ignore_mouse_drag_p is not accessed if !defined
3363 USE_GTK && !defined HAVE_NS.
3364
93ea6e8f
PE
3365 * intervals.c: Make symbols static if they're not exported.
3366 (merge_properties_sticky, merge_interval_right, delete_interval):
3367 Now static.
3368 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3369
77382fcc
PE
3370 * insdel.c: Make symbols static if they're not exported.
3371 However, leave prepare_to_modify_buffer alone. It's never
3372 called from outside this function, but that appears to be a bug.
3373 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3374 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3375 (adjust_after_replace_noundo): Remove; unused.
3376 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3377 (signal_before_change): Remove decls.
77382fcc 3378
9306c32e
PE
3379 * indent.c (val_compute_motion, val_vmotion): Now static.
3380
cd44d2eb
PE
3381 * image.c: Make symbols static if they're not exported.
3382 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3383 if USE_GTK.
3384 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3385 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3386
ad9a7a06
PE
3387 * fringe.c (standard_bitmaps): Now static.
3388 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3389
81626931
PE
3390 * frame.c: Make symbols static if they're not exported.
3391 (x_report_frame_params, make_terminal_frame): Now static.
3392 (get_frame_param): Now static, unless HAVE_NS.
3393 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3394 (x_get_resource_string): Remove; not used.
3395 * frame.h (make_terminal_frame, x_report_frame_params):
3396 (x_get_resource_string); Remove decls.
3397 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3398 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3399
239f9db9
PE
3400 * font.c, fontset.c: Make symbols static if they're not exported.
3401 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3402 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3403 * font.c (font_close_object): Now static.
3404 * font.h (font_close_object): Remove.
3405 * fontset.c (FONTSET_OBJLIST): Remove.
3406 (free_realized_fontset) #if-0 the body, which does nothing.
3407 (face_suitable_for_char_p): #if-0, as it's never called.
3408 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3409 * xfaces.c (face_at_string_position):
3410 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3411 since 0 is always ASCII.
3412
dfcf3579
PE
3413 * fns.c (weak_hash_tables): Now static.
3414
5045092b
PE
3415 * fileio.c: Make symbols static if they're not exported.
3416 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3417 (Vwrite_region_annotation_buffers): Now static.
3418
57a96f5c
PE
3419 * eval.c: Make symbols static if they're not exported.
3420 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3421 * lisp.h (backtrace_list): Remove decl.
3422
35f08c38
PE
3423 * emacs.c: Make symbols static if they're not exported.
3424 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3425 (fatal_error_code, fatal_error_signal_hook, standard_args):
3426 Now static.
3427 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3428 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3429 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3430 * lisp.h (fatal_error_signal_hook): Remove decl.
3431 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3432
f44bd759
PE
3433 * editfns.c: Move a (normally-unused) function to its only use.
3434 * editfns.c, lisp.h (get_operating_system_release): Remove.
3435 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3436 worth the hassle of breaking this out.
3437
b532497d
PE
3438 * xterm.c: Make symbols static if they're not exported.
3439 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3440 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3441 (x_destroy_window, x_delete_display):
3442 Now static.
3443 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3444 (x_mouse_leave): Remove; unused.
3445 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3446 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3447 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3448 Remove decls.
3449 (x_mouse_leave): Declare only if WINDOWSNT.
3450 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3451 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3452 USE_X_TOOLKIT.
3453
1675728f
PE
3454 * ftxfont.c: Make symbols static if they're not exported.
3455 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3456 HAVE_FREETYPE.
3457 * font.h (ftxfont_driver): Likewise.
3458
e4cebfca
PE
3459 * xfns.c: Make symbols static if they're not exported.
3460 (x_last_font_name, x_display_info_for_name):
3461 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3462 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3463 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3464 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3465 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3466 (last_show_tip_args): Now static.
3467 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3468 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3469 (x_screen_planes): Remove; unused.
3470 * dispextern.h (x_screen_planes): Remove decl.
3471
5bf46f05
PE
3472 * dispnew.c: Make symbols static if they're not exported.
3473 * dispextern.h (redraw_garbaged_frames, scrolling):
3474 (increment_row_positions): Remove.
3475 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3476 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3477 Now static.
3478 (redraw_garbaged_frames): Remove; unused.
3479
435f4c28
PE
3480 * xfaces.c: Make symbols static if they're not exported.
3481 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3482 Remove decls.
3483 * xterm.h (defined_color): Remove decls.
3484 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3485 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3486 (menu_face_changed_default, defined_color, free_realized_face):
3487 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3488 (ascii_face_of_lisp_face): Remove; unused.
3489
8524aef3
PE
3490 * xdisp.c: Make symbols static if they're not exported.
3491 * dispextern.h (scratch_glyph_row, window_box_edges):
3492 (glyph_to_pixel_coords, set_cursor_from_row):
3493 (get_next_display_element, set_iterator_to_next):
3494 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3495 (show_mouse_face): Remove decls
3496 * frame.h (message_buf_print): Likewise.
3497 * lisp.h (pop_message, set_message, check_point_in_composition):
3498 Likewise.
3499 * xterm.h (set_vertical_scroll_bar): Likewise.
3500 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3501 (message_buf_print, scratch_glyph_row, displayed_buffer):
3502 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3503 (get_next_display_element, show_mouse_face, window_box_edges):
3504 (frame_to_window_pixel_xy, check_point_in_composition):
3505 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3506 (glyph_to_pixel_coords): Remove; unused.
3507
16390cd2
PE
3508 * dired.c (file_name_completion): Now static.
3509
3510 * dbusbind.c (xd_in_read_queued_messages): Now static.
3511
a25f4dfa
PE
3512 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3513 * data.c (circular_list_error): Remove.
3514
14a9c8df
PE
3515 * commands.h (last_point_position, last_point_position_buffer):
3516 (last_point_position_window): Remove decls.
3517 * keyboard.c: Make these variables static.
3518
04f2d78b
CB
3519 * coding.h (coding, code_convert_region, encode_coding_gap):
3520 Remove decls.
74ab6df5
PE
3521 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3522 (iso_code_class, detect_coding, code_convert_region): Now static.
3523 (encode_coding_gap): Remove; unused.
3524
38dfbee1
PE
3525 * chartab.c (chartab_chars, chartab_bits): Now static.
3526
a2cb4e63
PE
3527 * charset.h (charset_iso_8859_1): Remove decl.
3528 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3529 Now static.
3530
127198fd
PE
3531 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3532 * ccl.c (Vccl_program_table): Now static.
3533 (check_ccl_update): Remove; unused.
3534
d85b608f
PE
3535 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3536 * category.h: ... from here.
3537 * category.c (check_category_table, set_category_set): Now static.
3538
31cd66f3
PE
3539 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3540 * lisp.h: Remove these decls.
3541
c358e587
PE
3542 * buffer.c (buffer_count): Remove unused var.
3543
e78aecca
PE
3544 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3545 so that it's not optimized away.
3546 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3547 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3548 exported only to the debugger.
3549
e192d7d3 3550 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3551 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3552
92470028
PE
3553 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3554 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3555 was inaccessible from Lisp.
3556 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3557 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3558
244ed907
PE
3559 alloc.c: Import and export fewer symbols, and remove unused items.
3560 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3561 is defined.
3562 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3563 it's not optimized away by whole-program optimization.
3564 (message_enable_multibyte, free_misc): Remove.
3565 (catchlist, handlerlist, mark_backtrace):
3566 Declare only if BYTE_MARK_STACK.
3567 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3568 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3569 (message_enable_multibyte): Remove decl.
3570 (free_misc, interval_free_list, float_block, float_block_index):
3571 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3572 (cons_free_list, last_marked_index):
3573 Now static.
3574 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3575 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3576 (mark_backtrace): Define only if BYTE_MARK_STACK.
3577 * xdisp.c (message_enable_multibyte): Now static.
3578
61c2b50e 3579 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3580 This makes it easier for human readers (and static analyzers)
3581 to see whether these variables are used from other modules.
3582 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3583 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3584 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3585 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3586 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3587 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3588 * xmenu.c, xselect.c:
3589 Declare Q* vars static if they are not used in other modules.
3590 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3591 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3592 Remove decls of unexported vars.
3593 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3594
95c82688
PE
3595 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3596
16a97296
PE
3597 Make Emacs functions such as Fatom 'static' by default.
3598 This makes it easier for human readers (and static analyzers)
3599 to see whether these functions can be called from other modules.
3600 DEFUN now defines a static function. To make the function external
3601 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3602 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3603 (Finit_image_library):
16a97296
PE
3604 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3605 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3606 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3607 Remove decls, since these functions are now static.
3608 (Funintern, Fget_internal_run_time): New decls, since these functions
3609 were already external.
95c82688 3610
16a97296
PE
3611 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3612 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3613 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3614 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3615 * keyboard.c, keymap.c, lread.c:
3616 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3617 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3618 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3619 Mark functions with DEFUE instead of DEFUN,
3620 if they are used in other modules.
3621 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3622 decls for now-static functions.
3623 * buffer.h (Fdelete_overlay): Remove decl.
3624 * callproc.c (Fgetenv_internal): Mark as internal.
3625 * composite.c (Fremove_list_of_text_properties): Remove decl.
3626 (Fcomposition_get_gstring): New forward static decl.
3627 * composite.h (Fcomposite_get_gstring): Remove decl.
3628 * dired.c (Ffile_attributes): New forward static decl.
3629 * doc.c (Fdocumntation_property): New forward static decl.
3630 * eval.c (Ffetch_bytecode): New forward static decl.
3631 (Funintern): Remove extern decl; now in .h file where it belongs.
3632 * fileio.c (Fmake_symbolic_link): New forward static decl.
3633 * image.c (Finit_image_library): New forward static decl.
3634 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3635 * intervals.h (Fprevious_property_change):
3636 (Fremove_list_of_text_properties): Remove decls.
3637 * keyboard.c (Fthis_command_keys): Remove decl.
3638 (Fcommand_execute): New forward static decl.
3639 * keymap.c (Flookup_key): New forward static decl.
3640 (Fcopy_keymap): Now static.
3641 * keymap.h (Flookup_key): Remove decl.
3642 * process.c (Fget_process): New forward static decl.
3643 (Fprocess_datagram_address): Mark as internal.
3644 * syntax.c (Fsyntax_table_p): New forward static decl.
3645 (skip_chars): Remove duplicate decl.
3646 * textprop.c (Fprevious_property_change): New forward static decl.
3647 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3648 Now internal.
3649 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3650 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3651
785bbd42
PE
3652 * editfns.c (Fformat): Remove unreachable code.
3653
8b913b57
AS
36542011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3655
3656 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3657 change. (Bug#8496)
3658
a6744a35
EZ
36592011-04-13 Eli Zaretskii <eliz@gnu.org>
3660
3661 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3662 when at ZV. (Bug#8487)
3663
e7974947
AS
36642011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3665
baad03f0
AS
3666 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3667 (Bug#8437)
3668 * keyboard.c (parse_tool_bar_item): Likewise.
3669 * sound.c (sound_cleanup, alsa_close): Likewise.
3670 * termcap.c (tgetent): Likewise.
3671 * xfns.c (x_default_font_parameter): Likewise.
3672 * xsettings.c (read_and_apply_settings): Likewise.
3673
e7974947
AS
3674 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3675 (overrun_check_free): Protoize.
3676
28272684
PE
36772011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3678
3679 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3680 since callers should never pass a negative size.
3681 Change the signature to match that of plain 'read' and 'write'; see
3682 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3683 * lisp.h: Update prototypes of emacs_write and emacs_read.
3684
11997c76
EZ
36852011-04-11 Eli Zaretskii <eliz@gnu.org>
3686
3687 * xdisp.c (redisplay_window): Don't try to determine the character
3688 position of the scroll margin if the window start point w->startp
e896f03c 3689 is outside the buffer's accessible region. (Bug#8468)
11997c76 3690
8a2cbd72
EZ
36912011-04-10 Eli Zaretskii <eliz@gnu.org>
3692
3693 Fix write-region and its subroutines for buffers > 2GB.
3694 * fileio.c (a_write, e_write): Modify declaration of arguments and
3695 local variables to support buffers larger than 2GB.
3696 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3697
3698 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3699 argument, local variables, and return value.
3700
3701 * lisp.h: Update prototypes of emacs_write and emacs_read.
3702
3703 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3704
4073e537 37052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3706
1ebfdcb6
PE
3707 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3708
b2ded58d
PE
3709 Fix more problems found by GCC 4.6.0's static checks.
3710
7d66342c
PE
3711 * xdisp.c (vmessage): Use a better test for character truncation.
3712
bbf47d44
PE
3713 * charset.c (load_charset_map): <, not <=, for optimization,
3714 and to avoid potential problems with integer overflow.
9248994d 3715 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3716 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3717 * editfns.c (Fformat): Likewise.
1e69125e 3718 * syntax.c (skip_chars): Likewise.
3befa583 3719
e3019616
PE
3720 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3721 This also lets GCC 4.6.0 generate slightly better loop code.
3722
becfa255
PE
3723 * callint.c (Fcall_interactively): <, not <=, for optimization.
3724 (Fcall_interactively): Count the number of arguments produced,
3725 not the number of arguments given. This is simpler and lets GCC
3726 4.6.0 generate slightly better code.
3727
dae0cd48
PE
3728 * ftfont.c: Distingish more carefully between FcChar8 and char.
3729 The previous code passed unsigned char * to a functions like
3730 strlen and xstrcasecmp that expect char *, which does not
3731 conform to the C standard.
3732 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3733 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3734 char * when the C standard requires it.
3735
76032d70
PE
3736 * keyboard.c (read_char): Remove unused var.
3737
eb3f1cc8
PE
3738 * eval.c: Port to Windows vsnprintf (Bug#8435).
3739 Include <limits.h>.
3740 (SIZE_MAX): Define if the headers do not.
3741 (verror): Do not give up if vsnprintf returns a negative count.
3742 Instead, grow the buffer. This ports to Windows vsnprintf, which
3743 does not conform to C99. Problem reported by Eli Zaretskii.
3744 Also, simplify the allocation scheme, by avoiding the need for
3745 calling realloc, and removing the ALLOCATED variable.
3746
70476b54
PE
3747 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3748
12020a9e
PE
3749 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3750 But keep the doprint source code for now, as we might revamp it
3751 and use it again (Bug#8435).
ea6c7ae6
PE
3752 * lisp.h (doprnt): Remove.
3753 * Makefile.in (base_obj): Remove doprnt.o.
3754 * deps.mk (doprnt.o): Remove.
3755
5fdb398c
PE
3756 error: Print 32- and 64-bit integers portably (Bug#8435).
3757 Without this change, on typical 64-bit hosts error ("...%d...", N)
3758 was used to print both 32- and 64-bit integers N, which relied on
3759 undefined behavior.
3760 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3761 New macro.
3762 * lisp.h (error, verror): Mark as printf-like functions.
3763 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3764 Report overflow in size calculations when allocating printf buffer.
3765 Do not truncate output string at its first null byte.
3766 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3767 Truncate the output at a character boundary, since vsnprintf does not
3768 do that.
3769 * charset.c (check_iso_charset_parameter): Convert internal
3770 character to string before calling 'error', since %c now has the
3771 printf meaning.
3772 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3773 overflow when computing char to be passed to 'error'. Do not
3774 pass Lisp_Object to 'error'; pass the integer instead.
3775 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3776 formatted with plain %d.
3777
b189fa66
PE
3778 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3779
bff87ef0
PE
3780 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3781
7e2cac20
PE
3782 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3783
ce4d90b5
PE
3784 * xterm.c (x_catch_errors): Remove duplicate declaration.
3785
266c9547
PE
3786 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3787
79c49ad2
PE
3788 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3789
368f4090
JM
37902011-04-10 Jim Meyering <meyering@redhat.com>
3791
3792 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3793 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3794 return ssize_t not "int", and use size_t as the buffer length.
3795 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3796 * gnutls.h: Update declarations.
3797 * process.c (read_process_output): Use ssize_t, to match.
3798 (send_process): Likewise.
3799
a32d4040
CY
38002011-04-09 Chong Yidong <cyd@stupidchicken.com>
3801
3802 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3803
8546720e 38042011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3805
04f2d78b
CB
3806 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3807 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3808
8546720e
GM
3809 * xterm.c (handle_one_xevent):
3810 * xmenu.c (create_and_show_popup_menu):
3811 * xselect.c (x_decline_selection_request)
3812 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3813
0a2f5c1a 38142011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3815
3816 Fix some uses of `int' instead of EMACS_INT.
3817 * search.c (string_match_1, fast_string_match)
3818 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3819 (scan_buffer, find_next_newline_no_quit)
3820 (find_before_next_newline, search_command, Freplace_match)
3821 (Fmatch_data): Make some `int' variables be EMACS_INT.
3822
3823 * xdisp.c (display_count_lines): 3rd argument and return value now
3824 EMACS_INT. All callers changed.
3825 (pint2hrstr): Last argument is now EMACS_INT.
3826
3827 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3828 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3829 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3830 (decode_coding_utf_16, decode_coding_emacs_mule)
3831 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3832 (decode_coding_ccl, decode_coding_charset)
3833 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3834 (decode_coding_iso_2022, decode_coding_emacs_mule)
3835 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3836 <char_offset, last_offset>: Declare EMACS_INT.
3837 (encode_coding_utf_8, encode_coding_utf_16)
3838 (encode_coding_emacs_mule, encode_invocation_designation)
3839 (encode_designation_at_bol, encode_coding_iso_2022)
3840 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3841 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3842 Declare EMACS_INT.
3843 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3844 (encode_invocation_designation): Last argument P_NCHARS is now
3845 EMACS_INT.
3846 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3847 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3848
3849 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3850 All users changed.
3851
3852 * ccl.c (Fccl_execute_on_string): Declare some variables
3853 EMACS_INT.
3854
8546720e 38552011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3856
3857 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3858
4e19a977
CS
38592011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3860
3861 * process.c (Fformat_network_address): Doc fix.
3862
87302331
R
38632011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3864
3865 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3866
cbb59342
CY
38672011-04-08 Chong Yidong <cyd@stupidchicken.com>
3868
3869 * keyboard.c (read_char): Call Lisp function help-form-show,
3870 instead of using internal_with_output_to_temp_buffer.
3871 (Qhelp_form_show): New var.
e0d38eeb 3872 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3873
3874 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3875
3876 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3877
e67a13ab
CY
38782011-04-06 Chong Yidong <cyd@stupidchicken.com>
3879
04f2d78b
CB
3880 * process.c (Flist_processes): Remove to Lisp.
3881 (list_processes_1): Delete.
e67a13ab 3882
973f782d
EZ
38832011-04-06 Eli Zaretskii <eliz@gnu.org>
3884
7c106b1e
EZ
3885 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3886
973f782d
EZ
3887 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3888
41cf7d1a 38892011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3890
ca23cc88
PE
3891 Fix more problems found by GCC 4.6.0's static checks.
3892
f390e2d5
PE
3893 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3894
42eea0d0
PE
3895 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3896
b69769da 3897 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3898
f9541e84
PE
3899 * xdisp.c (vmessage): Mark as a printf-like function.
3900
13841b55
PE
3901 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3902
c136c10f
PE
3903 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3904
5e2d4a30
PE
3905 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3906 printf-like functions.
3907 (tiff_load): Add casts to remove these marks before passing them
3908 to system-supplied API.
3909
583f48b9
PE
3910 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3911
b25d760e
PE
3912 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3913 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3914 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3915 directly, rather than having caller test rule sign. This avoids
3916 some unnecessary tests.
3917 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3918 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3919 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3920
bc7b6697 3921 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3922 (xfont_open): Avoid unnecessary tests.
bc7b6697 3923
27ccc379
PE
3924 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3925
dcd5c89a
PE
3926 * composite.h, composite.c (composition_gstring_put_cache):
3927 Use EMACS_INT, not int, for length.
3928
b13a45c6
PE
3929 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3930 breaking out part of COMPOSITION_DECODE_RULE.
3931 (COMPOSITION_DECODE_RULE): Use it.
3932 * composite.c (get_composition_id): Remove unused local vars,
3933 by using the new macro.
3934
1e792e4d
PE
3935 * textprop.c (set_text_properties_1): Change while to do-while,
3936 since the condition is always true at first.
3937
dc6c6455 3938 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3939 (interval_deletion_adjustment): Return unsigned value.
3940 All uses changed.
dc6c6455 3941
aba7731a
PE
3942 * process.c (list_processes_1, create_pty, read_process_output):
3943 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3944 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3945 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3946 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3947 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3948
fdfc4bf3
PE
3949 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3950
fca8fe46 3951 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3952 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3953
06a0259a 3954 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3955 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3956 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3957
e7b9e80f
PE
3958 * print.c (print_error_message): Avoid int overflow.
3959
56201685
PE
3960 * font.c (font_list_entities): Redo for clarity,
3961 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3962
78834453 3963 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3964 (font_score): Avoid potential overflow in diff calculation.
78834453 3965
0bc0b309 3966 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3967 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3968
e610eaca
PE
3969 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3970
b895abce
PE
3971 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3972 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3973 can always succeed if overflow has undefined behavior.
3974
1f1d9321 3975 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3976 (wordify): Omit three unnecessary tests.
1f1d9321 3977
c59478bc
PE
3978 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3979 All callers changed. This avoids the need for an unused var.
3980
79b73827
PE
3981 * casefiddle.c (casify_region): Remove var that is set but not used.
3982
a4db5dfe
PE
3983 * dired.c (file_name_completion): Remove var that is set but not used.
3984
43aae36e
PE
3985 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3986
2a47c44d 3987 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3988 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3989
a37c69bf
PE
3990 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3991 Check for integer overflow on size calculations.
3992
328ab8e7
PE
3993 * buffer.c (Fprevious_overlay_change): Remove var that is set
3994 but not used.
3995
e5a2a5cb
PE
3996 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3997 Remove vars that are set but not used.
8d84a6eb 3998 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3999 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4000
a60e5f68
PE
4001 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4002
f661cb61 4003 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4004 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4005
f0397f5a
PE
4006 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4007 that are set but not used.
4008
8664db06 4009 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4010 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4011
6abdaa4a
PE
4012 * xselect.c (x_get_local_selection, x_handle_property_notify):
4013 Remove vars that are set but not used.
4014
0ce7538d 4015 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4016 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4017
9ae848fc
PE
4018 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4019 Remove var that is set but not used.
0b918413
PE
4020 (scroll_bar_windows_size): Now size_t, not int.
4021 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4022 Check for overflow.
9ae848fc 4023
a5a62657
PE
4024 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4025 (map_tty_color) [!defined MSDOS]: Likewise.
4026
5c5cdd39
PE
4027 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4028
66ebf983
PE
4029 * coding.c: Remove vars that are set but not used.
4030 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4031 All callers changed.
4032 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4033 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4034 (decode_coding_charset): Remove vars that are set but not used.
4035
1be4d761
PE
4036 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4037 that is set but not used.
4038
47553fa8
PE
4039 * print.c (print_object): Remove var that is set but not used.
4040
1f7196bf 4041 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4042 The gnulib version avoids calling malloc in the usual case,
4043 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4044 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4045 * filelock.c (current_lock_owner): Likewise.
4046 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4047 * sysdep.c: Include allocator.h, careadlinkat.h.
4048 (emacs_no_realloc_allocator): New static constant.
4049 (emacs_readlink): New function.
fdb61804
PE
4050 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4051 ../lib/careadlinkat.h.
d1fdcab7 4052
f84c17c7
SM
40532011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4054
4055 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4056 first non-nil return value).
4057
ef3862ad
JD
40582011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4059
4060 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4061 if not defined (Bug#8403).
4062
376a7006
JB
40632011-04-02 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * xdisp.c (display_count_lines): Remove parameter `start',
4066 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4067 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4068 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4069 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4070 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4071 and thereabouts. All callers changed.
4072 (get_per_char_metric): Remove parameter `f', unused since
4073 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4074
6ca3801d
JM
40752011-04-02 Jim Meyering <meyering@redhat.com>
4076
4077 do not dereference NULL upon failed strdup
4078 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4079 (ns_get_family): Likewise.
4080
d8e2b5ba
JB
40812011-04-02 Juanma Barranquero <lekktu@gmail.com>
4082
4083 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4084
8c74fcbd
JD
40852011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4086
4087 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4088 later (Bug#8403).
4089
7200d79c
SM
40902011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4091
03408648 4092 Add lexical binding.
7200d79c 4093
03408648
SM
4094 * window.c (Ftemp_output_buffer_show): New fun.
4095 (Fsave_window_excursion):
4096 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4097
4098 * lread.c (lisp_file_lexically_bound_p): New function.
4099 (Fload): Bind Qlexical_binding.
4100 (readevalloop): Remove `evalfun' arg.
4101 Bind Qinternal_interpreter_environment.
4102 (Feval_buffer): Bind Qlexical_binding.
4103 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4104 Mark as dynamic.
4105 (syms_of_lread): Declare `lexical-binding'.
4106
4107 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4108
4109 * keyboard.c (eval_dyn): New fun.
4110 (menu_item_eval_property): Use it.
ca105506
SM
4111
4112 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4113
03408648
SM
4114 * fns.c (concat, mapcar1): Accept byte-code-functions.
4115
4116 * eval.c (Fsetq): Handle lexical vars.
4117 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4118 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4119 (FletX, Flet): Obey lexical binding.
4120 (Fcommandp): Handle closures.
4121 (Feval): New `lexical' arg.
4122 (eval_sub): New function extracted from Feval. Use it almost
4123 everywhere where Feval was used. Look up vars in lexical env.
4124 Handle closures.
4125 (Ffunctionp): Move from subr.el.
4126 (Ffuncall): Handle closures.
4127 (apply_lambda): Remove `eval_flags'.
4128 (funcall_lambda): Handle closures and new byte-code-functions.
4129 (Fspecial_variable_p): New function.
4130 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4131 but without exporting it to Lisp.
23aba0ea 4132
23aba0ea 4133 * doc.c (Fdocumentation, store_function_docstring):
03408648 4134 * data.c (Finteractive_form): Handle closures.
23aba0ea 4135
03408648
SM
4136 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4137 interactive spec.
ba83908c 4138
04f2d78b
CB
4139 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4140 New byte-codes.
03408648
SM
4141 (exec_byte_code): New function extracted from Fbyte_code to handle new
4142 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4143
03408648 4144 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4145
03408648 4146 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4147
e2abce01
JB
41482011-03-31 Juanma Barranquero <lekktu@gmail.com>
4149
4150 * xdisp.c (redisplay_internal): Fix prototype.
4151
63696a73 41522011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4153
63696a73 4154 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4155 (try_scrolling): Use it when setting scroll_limit.
4156 Limit scrolling to 100 screen lines.
63696a73
EZ
4157 (redisplay_window): Even when falling back on "recentering",
4158 position point in the window according to scroll-conservatively,
4159 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4160
4161 (try_scrolling): When point is above the window, allow searching
4162 as far as scroll_max, or one screenful, to compute vertical
4163 distance from PT to the scroll margin position. This prevents
4164 try_scrolling from unnecessarily failing when
4165 scroll-conservatively is set to a value slightly larger than the
4166 window height. Clean up the case of PT below the margin at bottom
4167 of window: scroll_max can no longer be INT_MAX. When aggressive
4168 scrolling is in use, don't let point enter the opposite scroll
4169 margin as result of the scroll.
4170 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4171 threshold of 100 lines for never-recentering scrolling.
4172
e4cc2dfc
JB
41732011-03-31 Juanma Barranquero <lekktu@gmail.com>
4174
4175 * dispextern.h (move_it_by_lines):
4176 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4177 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4178 (message_log_check_duplicate): Remove parameters `prev_bol' and
4179 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4180 (redisplay_internal): Remove parameter `preserve_echo_area',
4181 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4182
4183 * indent.c (Fvertical_motion):
4184 * window.c (window_scroll_pixel_based, Frecenter):
4185 Don't pass `need_y_p' to `move_it_by_lines'.
4186
1c470562
SM
41872011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4188
44f230aa
SM
4189 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4190 steal a few bits to be more compact.
4191 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4192 Remove unneeded casts.
4193
1c470562
SM
4194 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4195
888adce9
ZK
41962011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4197
4198 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4199 binding" message (bug#7967).
4200
f838ed7b
PE
42012011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4202
77861b95
PE
4203 Fix more problems found by GCC 4.6.0's static checks.
4204
de6dbc14
PE
4205 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4206 Remove unused local var.
4207
f838ed7b
PE
4208 * editfns.c (Fmessage_box): Remove unused local var.
4209
792c7b2b
PE
4210 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4211 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4212 Omit unused local vars.
c499e557 4213 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4214 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4215 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4216 Omit unused local var.
4217
ba0165e1
PE
4218 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4219 Don't assume string length fits in int.
32ad8845 4220 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4221 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4222
3c59b4c9
PE
4223 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4224 instead of alloca (Bug#8344).
4225
a3eed478 4226 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4227 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4228
eb4d412d
PE
4229 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4230
1658b401
PE
4231 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4232 concerns.
4233
4234 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4235
4236 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4237
9a2c6e05
PE
4238 * keyboard.c (syms_of_keyboard): Use the same style as later
4239 in this function when indexing through an array. This also
4240 works around GCC bug 48267.
4241
03d0a109
PE
4242 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4243
44f730c8
PE
4244 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4245
fe75f926
PE
4246 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4247 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4248
ffa8c828
PE
4249 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4250 This avoids undefined behavior on integer overflow, and is a bit
4251 more convenient anyway since it is compared to a size_t variable.
4252
c5101a77
PE
4253 Variadic C functions now count arguments with size_t, not int.
4254 This avoids an unnecessary limitation on 64-bit machines, which
4255 caused (substring ...) to crash on large vectors (Bug#8344).
4256 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4257 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4258 All variadic functions and their callers changed accordingly.
c5101a77
PE
4259 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4260 * data.c (arith_driver, float_arith_driver): Likewise.
4261 * editfns.c (general_insert_function): Likewise.
4262 * eval.c (struct backtrace.nargs, interactive_p)
4263 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4264 (funcall_lambda, mark_backtrace): Likewise.
4265 * fns.c (concat): Likewise.
4266 * frame.c (x_set_frame_parameters): Likewise.
4267 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4268 0 if not found, not -1. All callers changed.
4269
dd3f25f7
PE
4270 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4271 (stack_copy_size): Now size_t, not int.
4272 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4273
461c2ab9
JB
42742011-03-28 Juanma Barranquero <lekktu@gmail.com>
4275
4276 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4277 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4278 All callers changed.
4279
4280 * lisp.h (multibyte_char_to_unibyte):
4281 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4282 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4283 * character.h (CHAR_TO_BYTE8):
4284 * cmds.c (internal_self_insert):
4285 * editfns.c (general_insert_function):
4286 * keymap.c (push_key_description):
4287 * search.c (Freplace_match):
4288 * xdisp.c (message_dolog, set_message_1): All callers changed.
4289
f6d62986
SM
42902011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4291
4292 * keyboard.c (safe_run_hook_funcall): New function.
4293 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4294 don't set the hook to nil, but remove the offending function instead.
4295 (Qcommand_hook_internal): Remove, unused.
4296 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4297 Vcommand_hook_internal.
4298
4299 * eval.c (enum run_hooks_condition): Remove.
4300 (funcall_nil, funcall_not): New functions.
4301 (run_hook_with_args): Call each function through a `funcall' argument.
4302 Remove `cond' argument, now redundant.
4303 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4304 (Frun_hook_with_args_until_failure): Adjust accordingly.
4305 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4306
1db5b1ad
JB
43072011-03-28 Juanma Barranquero <lekktu@gmail.com>
4308
4309 * dispextern.h (string_buffer_position): Remove declaration.
4310
4311 * print.c (strout): Remove parameter `multibyte', unused since
4312 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4313
4314 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4315 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4316 All callers changed.
4317
4318 * w32.c (_wsa_errlist): Use braces for struct initializers.
4319
4320 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4321 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4322 All callers changed.
4323 (string_buffer_position): Likewise. Also, make static (it's never
4324 used outside xdisp.c).
4325 (cursor_row_p): Remove parameter `w', unused since
4326 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4327 (decode_mode_spec): Remove parameter `precision', introduced during
4328 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4329 All callers changed.
4330
5ffb62aa
JD
43312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4332
4333 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4334
461c2ab9 43352011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4336
4337 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4338 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4339 (ns_update_auto_hide_menu_bar): New functions.
4340 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4341 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4342 ns_constrain_all_frames.
4343 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4344 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4345
5c380ffb
JD
43462011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4347
4348 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4349
9af30bdf
GM
43502011-03-27 Glenn Morris <rgm@gnu.org>
4351
4352 * syssignal.h: Replace RETSIGTYPE with void.
4353 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4354 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4355 Replace SIGTYPE with void everywhere.
4356 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4357 * s/template.h (SIGTYPE): Remove commented out definition.
4358
e2abce01
JB
43592011-03-26 Eli Zaretskii <eliz@gnu.org>
4360
4361 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4362 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4363
f868cd8a
JB
43642011-03-26 Juanma Barranquero <lekktu@gmail.com>
4365
59eb0929
JB
4366 * w32.c (read_unc_volume): Use parameter `henum', instead of
4367 global variable `wget_enum_handle'.
4368
4369 * keymap.c (describe_vector): Remove parameters `indices' and
4370 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4371 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4372
f868cd8a
JB
4373 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4374
4375 * keyboard.c (timer_check): Remove parameter `do_it_now',
4376 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4377 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4378 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4379
4380 * keyboard.c (read_char):
4381 * w32menu.c (w32_menu_display_help):
4382 * xmenu.c (show_help_event, menu_help_callback):
4383 Adjust calls to `show_help_echo'.
4384
4385 * gtkutil.c (xg_maybe_add_timer):
4386 * keyboard.c (readable_events):
4387 * process.c (wait_reading_process_output):
4388 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4389
4390 * insdel.c (adjust_markers_gap_motion):
4391 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4392 (gap_left, gap_right): Don't call it.
4393
2ecf6fdb
CY
43942011-03-25 Chong Yidong <cyd@stupidchicken.com>
4395
4396 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4397 incurred during fontification.
4398
6b1f9ba4
JB
43992011-03-25 Juanma Barranquero <lekktu@gmail.com>
4400
4401 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4402 (DEFVAR_PER_BUFFER): Don't pass it.
4403
4404 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4405 (scrolling_window): Don't pass it.
4406
0f4a96b5
JB
44072011-03-25 Juanma Barranquero <lekktu@gmail.com>
4408
4409 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4410
4411 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4412 and `suffix'.
4413 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4414 of variables specific to SELinux and computation of `encoded_absname'.
4415
4416 * image.c (XPutPixel): Remove unused variable `height'.
4417
4418 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4419
4420 * unexw32.c (get_section_info): Remove unused variable `section'.
4421
4422 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4423 (system_process_attributes): Remove unused variable `sess'.
4424 (sys_read): Remove unused variable `err'.
4425
4426 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4427 (w32_wnd_proc): Remove unused variable `isdead'.
4428 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4429 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4430 (x_create_tip_frame): Remove unused variable `tem'.
4431
4432 * w32inevt.c (w32_console_read_socket):
4433 Remove unused variable `no_events'.
4434
4435 * w32term.c (x_draw_composite_glyph_string_foreground):
4436 Remove unused variable `width'.
4437
1149507c
JB
44382011-03-24 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * w32term.c (x_set_glyph_string_clipping):
4441 Don't pass uninitialized region to CombineRgn.
4442
9c88f339
JB
44432011-03-23 Juanma Barranquero <lekktu@gmail.com>
4444
4445 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4446 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4447 (Fx_close_connection): Remove unused variable `i'.
4448
4449 * w32font.c (w32font_draw): Return number of glyphs.
4450 (w32font_open_internal): Remove unused variable `i'.
4451 (w32font_driver): Add missing initializer.
4452
4453 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4454 (fill_in_menu): Remove unused variable `items_added'.
4455
4456 * w32term.c (last_mouse_press_frame): Remove static global variable.
4457 (w32_clip_to_row): Remove unused variable `f'.
4458 (x_delete_terminal): Remove unused variable `i'.
4459
4460 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4461 (NOTHING): Remove unused static global variable.
4462 (uniscribe_check_otf): Remove unused variable `table'.
4463 (uniscribe_font_driver): Add missing initializers.
4464
dee091a3
JD
44652011-03-23 Julien Danjou <julien@danjou.info>
4466
4467 * term.c (Fsuspend_tty, Fresume_tty):
4468 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4469 * window.c (temp_output_buffer_show):
4470 * insdel.c (signal_before_change):
4471 * frame.c (Fhandle_switch_frame):
4472 * fileio.c (Fdo_auto_save):
4473 * emacs.c (Fkill_emacs):
4474 * editfns.c (save_excursion_restore):
4475 * cmds.c (internal_self_insert):
4476 * callint.c (Fcall_interactively):
4477 * buffer.c (Fkill_all_local_variables):
4478 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4479 Use Frun_hooks.
0f4a96b5 4480 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4481 unconditionnaly since it does the check itself.
4482
2c520ab5 44832011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4484
c9c49752
PE
4485 Fix more problems found by GCC 4.5.2's static checks.
4486
8abc3f12
PE
4487 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4488 the first time through the loop, since we know p0 < p1 then.
4489 This also avoids a gcc -Wstrict-overflow warning.
4490
a2d26660
PE
4491 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4492 leading to a memory leak, possible in functions like
4493 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4494 of objects (Bug#8318).
a2d26660 4495
916c72e9
PE
4496 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4497 that could (at least in theory) be that large.
4498
19ab8a18
PE
4499 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4500 This is less likely to overflow, and avoids undefined behavior if
4501 overflow does occur. All callers changed. Use strtoul to scan
4502 for the unsigned long integer.
b7cbbd6f
PE
4503 (pint2hrstr): Simplify and tune code slightly.
4504 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4505
f0641eff
PE
4506 * scroll.c (do_scrolling): Work around GCC bug 48228.
4507 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4508
7f650bb9
PE
4509 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4510 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4511 (validate_x_resource_name): Simplify count usage.
4512 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4513
37dd57d1
PE
4514 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4515 fail (Bug#8306).
81e56e61 4516
699979fc 4517 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4518
401bf9b4
PE
4519 * process.c (Fmake_network_process): Use socklen_t, not int,
4520 where POSIX says socklen_t is required in portable programs.
4521 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4522 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4523 (Fmake_network_process, server_accept_connection):
4524 (wait_reading_process_output, read_process_output):
4525 Likewise.
4526
b93aacde
PE
4527 * process.c: Rename or move locals to avoid shadowing.
4528 (list_processes_1, Fmake_network_process):
4529 (read_process_output_error_handler, exec_sentinel_error_handler):
4530 Rename or move locals.
4dc343ee 4531 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4532 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4533 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4534 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4535 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4536
af8a867c 4537 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4538 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4539 Include tparam.h instead, since it declares them.
af8a867c
PE
4540 * cm.h (PC): Remove extern decl; tparam.h now does this.
4541 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4542 * terminfo.c: Include tparam.h, to check interfaces.
4543 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4544 (tparam): Adjust signature to match interface in tparam.h;
4545 this removes some undefined behavior. Check that outstring and len
4546 are zero, which they always are with Emacs.
4547 * tparam.h (PC, BC, UP): New extern decls.
4548
0248044d 4549 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4550 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4551
8ff096c1 4552 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4553 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4554 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4555 (ftfont_list): Remove unused local.
49eaafba
PE
4556 (get_adstyle_property, ftfont_pattern_entity):
4557 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4558 Rename locals to avoid shadowing.
8ff096c1 4559
e2be39f6
PE
4560 * xfont.c (xfont_list_family): Mark var as initialized.
4561
c9735e30
PE
4562 * xml.c (make_dom): Now static.
4563
8f5201ae
PE
4564 * composite.c (composition_compute_stop_pos): Rename local to
4565 avoid shadowing.
b246f932
PE
4566 (composition_reseat_it): Remove unused locals.
4567 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4568 (composition_update_it): Mark var as initialized.
11b61122
PE
4569 (find_automatic_composition): Mark vars as initialized,
4570 with a FIXME (Bug#8290).
8f5201ae 4571
760fbc2c
PE
4572 character.h: Rename locals to avoid shadowing.
4573 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4574 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4575 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4576 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4577 to avoid shadowing.
4578
ff08eb85
PE
4579 * textprop.c (property_change_between_p): Remove; unused.
4580
fc7bf025
PE
4581 * intervals.c (interval_start_pos): Now static.
4582
235d7abc
PE
4583 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4584
44f230aa
SM
4585 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4586 Rename locals to avoid shadowing.
3e7d6594 4587
50060332
PE
4588 * sound.c (wav_play, au_play, Fplay_sound_internal):
4589 Fix pointer signedness.
d01f234b 4590 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4591 (wav_play): Initialize a variable to 0, to prevent undefined
4592 behavior (Bug#8278).
50060332 4593
c4fc4e30
PE
4594 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4595
918436ed
PE
4596 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4597
c939f91b
PE
4598 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4599 clobbering (Bug#8298).
b9c7f648
PE
4600 * sysdep.c (sys_subshell): Likewise.
4601 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4602
6bd8c144
PE
4603 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4604 This should get cleaned up, so that child_setup has the
4605 same signature on all platforms.
4606
7710357c 4607 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4608 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4609
c59da222
CY
46102011-03-22 Chong Yidong <cyd@stupidchicken.com>
4611
4612 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4613 not to be necessary, and produces flickering.
4614
66b87493
GM
46152011-03-20 Glenn Morris <rgm@gnu.org>
4616
4617 * config.in: Remove file.
4618
45b6f6d5
JB
46192011-03-20 Juanma Barranquero <lekktu@gmail.com>
4620
4621 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4622 are now in src/globals.h.
4623 (syms_of_minibuf): Remove spurious & from previous change.
4624
3ec03f7e
LL
46252011-03-20 Leo <sdl.web@gmail.com>
4626
4627 * minibuf.c (completing-read-function): New variable.
4628 (completing-read-default): Rename from completing-read.
4629 (completing-read): Call completing-read-function.
4630
b14e3e21
CY
46312011-03-19 Juanma Barranquero <lekktu@gmail.com>
4632
4633 * xfaces.c (Fx_load_color_file):
4634 Read color file from absolute filename (bug#8250).
4635
f2b726e6
JB
46362011-03-19 Juanma Barranquero <lekktu@gmail.com>
4637
4638 * makefile.w32-in: Update dependencies.
4639
09f6ff02
EZ
46402011-03-17 Eli Zaretskii <eliz@gnu.org>
4641
4642 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4643
29a6015a
PE
46442011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4645
a3a6c54e
PE
4646 Fix more problems found by GCC 4.5.2's static checks.
4647
b766f867
PE
4648 * process.c (make_serial_process_unwind, send_process_trap):
4649 (sigchld_handler): Now static.
4650
be02381c
PE
4651 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4652 That way, the code declares only the vars that it needs.
4653 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4654 * s/cygwin.h (PTY_ITERATION): Likewise.
4655 * s/darwin.h (PTY_ITERATION): Likewise.
4656 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4657
57048744
PE
4658 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4659 * process.c (allocate_pty): Don't declare stb unless it's needed.
4660
7914961c 4661 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4662 (CONSTANTLIM): Remove; unused.
4663 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4664 Define only if needed.
7914961c 4665
b3967b18
PE
4666 * unexelf.c (unexec): Name an expression,
4667 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4668 Use a different way to cause a compilation error if anyone uses
4669 n rather than nn, a way that does not involve shadowing.
73366a00 4670 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4671
29a6015a
PE
4672 * deps.mk (unexalpha.o): Remove; unused.
4673
43cfc33e 4674 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4675 * unexec.h: New file.
ce701a33
PE
4676 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4677 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4678 Depend on unexec.h.
4679 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4680 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4681 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4682 Change as necessary to match prototype in unexec.h.
ce701a33 4683
01f44d5a
PE
4684 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4685 shadowing.
4f63c6bb 4686 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4687
a6670b0b
PE
4688 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4689 Rename locals to avoid shadowing.
4690
cef2010d 4691 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4692 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4693
d4d7173a
PE
4694 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4695
f08b802a
PE
4696 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4697 warning when compiling print.c.
4698
3ddb0639
PE
4699 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4700 instead of using an uninitialized var.
5ad03b97 4701 (font_sort_entities): Mark var as initialized.
3ddb0639 4702
170a2692
PE
4703 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4704
e663c700
PE
4705 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4706 pointers to constants.
89bc529a 4707 (font_parse_fcname): Remove unused vars.
7b81e2d0 4708 (font_delete_unmatched): Now static.
ea838e10 4709 (font_get_spec): Remove; unused.
13a547c6
PE
4710 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4711 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4712 Rename or move locals to avoid shadowing.
e663c700 4713
2a80c887 4714 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4715 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4716
1384fa33 4717 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4718 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4719
8b2c52e9
PE
4720 * alloc.c (mark_backtrace): Move decl from here ...
4721 * lisp.h: ... to here, so that it can be checked.
4722
475545b5 4723 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4724 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4725 (lisp_indirect_variable): Name an expression,
4726 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4727 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4728
b1349114 4729 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4730 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4731 Use const pointer when appropriate.
b1349114 4732
a2928364
PE
4733 * lisp.h (get_system_name, get_operating_system_release):
4734 Move decls here, to check interfaces.
4735 * process.c (get_operating_system_release): Move decl to lisp.h.
4736 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4737 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4738 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4739 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4740 (Fformat_time_string, Fencode_time, Finsert_char):
4741 (Ftranslate_region_internal, Fformat):
4742 Rename or remove local vars to avoid shadowing.
9710023e 4743 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4744
a415e694
PE
4745 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4746 avoid shadowing.
4747
8ef4622d
PE
4748 * lisp.h (eassert): Check that the argument compiles, even if
4749 ENABLE_CHECKING is not defined.
4750
946f9a5b
PE
4751 * data.c (Findirect_variable): Name an expression, to avoid
4752 gcc -Wbad-function-cast warning.
112396d6 4753 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4754 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4755 (Fmake_variable_buffer_local, Fmake_local_variable):
4756 Mark variables as initialized.
52746918 4757 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4758
e5aab7e7 4759 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4760 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4761 Rename locals to avoid shadowing.
dff45157
PE
4762 (mark_stack): Move local variables into the #ifdef region where
4763 they're used.
7bc26fdb
PE
4764 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4765 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4766 needed otherwise.
4767 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4768 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4769 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4770
e5aab7e7
PE
4771 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4772 avoids undefined behavior in theory.
4773
4da60324
PE
4774 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4775
88043301
PE
4776 Use functions, not macros, for up- and down-casing (Bug#8254).
4777 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4778 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4779 to use the following functions instead of these macros.
4780 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4781 EMACS_INT, since callers assume the returned value fits in int.
4782 (upcase1): Likewise, for UPCASE_TABLE.
4783 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4784 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4785 the race-condition problem in the old DOWNCASE.
88043301 4786
19ed5445
PE
4787 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4788 Rename locals to avoid shadowing.
4789 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4790 (regex_compile, re_search_2, re_match_2_internal):
4791 Remove unused local vars.
952db0d7
PE
4792 (FREE_VAR): Rewrite so as not to use empty "else",
4793 which gcc can warn about.
da053e48 4794 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4795 (RETALLOC_IF): Define only if needed.
4796 (WORDCHAR_P): Likewise. This one is never needed, but is used
4797 only in a comment talking about a compiler bug, so put inside
4798 the #if 0 of that comment.
4799 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4800 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4801 Remove; unused.
19ed5445 4802
1f3561e4 4803 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4804 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4805 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4806
ded6f8f7
PE
4807 * search.c (simple_search): Remove unused var.
4808
dbd37a95
PE
4809 * dired.c (compile_pattern): Move decl from here ...
4810 * lisp.h: ... to here, so that it can be checked.
4811 (struct re_registers): New forward decl.
4812
7e47afad
PE
4813 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4814
85f24f61
PE
4815 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4816 All uses changed.
4817 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4818 Rename locals to avoid shadowing.
5671df8f 4819 (Fvertical_motion): Mark locals as initialized.
85f24f61 4820
181aa2be 4821 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4822 (casify_region): Mark local as initialized.
181aa2be 4823
930d429c
PE
4824 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4825
7082eac6
PE
4826 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4827 New macros, so that the caller can use some names other than
4828 gcpro1, gcpro2, etc.
4829 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4830 of the new macros.
4831 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4832 argument, for consistency with GCPRO2_VAR, etc: it is now the
4833 prefix of the variable, not the variable itself. All uses
4834 changed.
38b2c076
PE
4835 * dired.c (directory_files_internal, file_name_completion):
4836 Rename locals to avoid shadowing.
4837
15206ed9
PE
4838 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4839 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4840 dired.c's scmp function, had undefined behavior.
4841 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4842 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4843 * buffer.h: ... to here, because these macros use current_buffer,
4844 and the new implementation with inline functions needs to have
4845 current_buffer in scope now, rather than later when the macros
4846 are used.
4847 (downcase, upcase1): New static inline functions.
4848 (DOWNCASE, UPCASE1): Reimplement using these functions.
4849 This avoids undefined behavior in expressions like
4850 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4851 from race conditions in accessing the global variables
4852 case_temp1 and case_temp2.
4853 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4854 * lisp.h (case_temp1, case_temp2): Remove their decls.
4855 * character.h (ASCII_CHAR_P): Move from here ...
4856 * lisp.h: ... to here, so that the inline functions mentioned
4857 above can use them.
4858
4a6bea26
PE
4859 * dired.c (directory_files_internal_unwind): Now static.
4860
f14b7e14
PE
4861 * fileio.c (file_name_as_directory, directory_file_name):
4862 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4863 Now static.
2893f146
PE
4864 (file_name_as_directory): Use const pointers when appropriate.
4865 (Fexpand_file_name): Likewise. In particular, newdir might
4866 point at constant storage, so make it a const pointer.
fd4ead52 4867 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4868 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4869 signedness issues.
f839df0c
PE
4870 (Fset_file_times, Finsert_file_contents, auto_save_error):
4871 Rename locals to avoid shadowing.
f14b7e14 4872
5716756e 4873 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4874 (Ftry_completion, Fall_completions): Rename or remove locals
4875 to avoid shadowing.
5716756e 4876
b4c3046a
PE
4877 * marker.c (bytepos_to_charpos): Remove; unused.
4878
b45db522
PE
4879 * lisp.h (verify_bytepos, count_markers): New decls,
4880 so that gcc does not warn that these functions aren't declared.
4881
85876d07
PE
4882 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4883 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4884 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4885 (copy_text): Remove unused local var.
85876d07 4886
03d78a21 4887 * filelock.c (within_one_second): Now static.
b3dd38ab 4888 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4889
5df8f01b
PE
4890 * buffer.c (fix_overlays_before): Mark locals as initialized.
4891 (fix_start_end_in_overlays): Likewise. This function should be
4892 simplified by using pointers-to-pointers, but that's a different
4893 matter.
b1d876f1 4894 (switch_to_buffer_1): Now static.
8f54f30a
PE
4895 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4896 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4897
a70072c9 4898 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4899 Fix pointer signedness issue.
edced198
PE
4900 (sys_subshell): Mark local as volatile if checking for lint,
4901 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4902 (MAXPATHLEN): Define only if needed.
a70072c9 4903
a0977c44
PE
4904 * process.c (serial_open, serial_configure): Move decls from here ...
4905 * systty.h: ... to here, so that they can be checked.
4906
a884fdcc
PE
4907 * fns.c (get_random, seed_random): Move extern decls from here ...
4908 * lisp.h: ... to here, so that they can be checked.
4909
604efe86 4910 * sysdep.c (reset_io): Now static.
b8950c94 4911 (wait_for_termination_signal): Remove; unused.
604efe86 4912
38fc62d9
PE
4913 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4914 (copy_keymap_item, append_key, push_text_char_description):
4915 Now static.
1004a21a 4916 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4917 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4918 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4919 (describe_map_tree):
4920 Rename locals to avoid shadowing.
38fc62d9 4921
2f2650da
PE
4922 * keyboard.c: Declare functions static if they are not used elsewhere.
4923 (echo_char, echo_dash, cmd_error, top_level_2):
4924 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4925 (read_char, kbd_buffer_get_event, make_lispy_position):
4926 (make_lispy_event, make_lispy_movement, apply_modifiers):
4927 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4928 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4929 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4930 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4931 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4932
a053e86c 4933 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4934 (mark_kboards): Move decl here ...
4935 * alloc.c (mark_kboards): ... from here.
a053e86c 4936
4752793e
PE
4937 * lisp.h (force_auto_save_soon): New decl.
4938
74f10ca7 4939 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4940 (DEFINE_DUMMY_FUNCTION): New macro.
4941 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4942 Use it.
c03cd23f
PE
4943 (main): Add casts to avoid warnings
4944 if GCC considers string literals to be constants.
74f10ca7 4945
022e70d4
PE
4946 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4947
59d6fe83
PE
4948 * dbusbind.c: Pointer signedness fixes.
4949 (xd_signature, xd_append_arg, xd_initialize):
4950 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4951 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4952 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4953 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4954
78320123
PE
4955 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4956 if GCC considers string literals to be constants.
49cebcca 4957 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4958
35ac2a97
SM
49592011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4960
fb103ca9
SM
4961 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4962 (print_preprocess, print_object): New macro to fix last change.
4963
35ac2a97
SM
4964 * print.c (print_preprocess): Don't forget font objects.
4965
62973b41
JB
49662011-03-16 Juanma Barranquero <lekktu@gmail.com>
4967
4968 * emacs.c (USAGE3): Doc fixes.
4969
0e48bb22
AS
49702011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4971
4972 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4973 structure.
4974
7684e57b
JB
49752011-03-14 Juanma Barranquero <lekktu@gmail.com>
4976
4977 * lisp.h (VWindow_system, Qfile_name_history):
4978 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4979 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4980 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4981
4982 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4983 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4984
4985 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4986 * w32console.c (detect_input_pending, read_input_pending)
4987 (encode_terminal_code):
4988 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4989 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4990 (w32_system_caret_y, Qfile_name_history):
4991 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4992 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4993 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4994 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4995 * w32proc.c (Qlocal, report_file_error):
4996 * w32term.c (Vwindow_system, updating_frame):
4997 * w32uniscribe.c (initialized, uniscribe_font_driver):
4998 Remove unneeded extern declarations.
4999
2aa46d6c
CY
50002011-03-14 Chong Yidong <cyd@stupidchicken.com>
5001
c96bbc66 5002 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5003
cffc6f3b
CY
50042011-03-13 Chong Yidong <cyd@stupidchicken.com>
5005
5006 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5007 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5008 These macros can no longer be used for assignment.
5009
44f230aa
SM
5010 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5011 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5012 (record_buffer_markers, fetch_buffer_markers): New functions for
5013 recording and fetching special buffer markers.
5014 (set_buffer_internal_1, set_buffer_temp): Use them.
5015
5016 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5017
5018 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5019
5020 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5021 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5022
5023 * xdisp.c (hscroll_window_tree):
5024 (reconsider_clip_changes): Use PT instead of BUF_PT.
5025
d251f04b
EZ
50262011-03-13 Eli Zaretskii <eliz@gnu.org>
5027
5028 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5029 $(EMACS_ROOT)/lib/intprops.h.
5030
f0c77cd1
PE
50312011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5032
3eca4629
PE
5033 Fix more problems found by GCC 4.5.2's static checks.
5034
7c86ee98
PE
5035 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5036 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5037 (xg_free_frame_widgets): Make it clear that a local variable is
5038 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5039 (gdk_window_get_screen): Make it clear that this macro is needed
5040 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5041 (int_gtk_range_get_value): New function, which avoids a diagnostic
5042 from gcc -Wbad-function-cast.
5043 (xg_set_toolkit_scroll_bar_thumb): Use it.
5044 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5045 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5046 (get_utf8_string, xg_get_file_with_chooser):
5047 Rename locals to avoid shadowing.
5048 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5049
41729b81
PE
5050 * xgselect.c (xg_select): Remove unused var.
5051
f0c77cd1
PE
5052 * image.c (four_corners_best): Mark locals as initialized.
5053 (gif_load): Initialize transparent_p to zero (Bug#8238).
5054 Mark another local as initialized.
ec6cf4c6 5055 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5056
ce0ad53d 5057 * image.c (clear_image_cache): Now static.
d5d5a617 5058 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5059 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5060 (x_edge_detection): Remove unnecessary cast that
5061 gcc -Wbad-function-cast diagnoses.
2037898d 5062 (gif_load): Fix pointer signedness.
6ae141d6
PE
5063 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5064 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5065
33383987 50662011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5067
d32df629
PE
5068 Improve quality of tests for time stamp overflow.
5069 For example, without this patch (encode-time 0 0 0 1 1
5070 1152921504606846976) returns the obviously-bogus value (-948597
5071 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5072 reports time overflow. See
5073 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5074 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5075 * editfns.c: Include limits.h and intprops.h.
5076 (TIME_T_MIN, TIME_T_MAX): New macros.
5077 (time_overflow): Move earlier, to before first use.
5078 (hi_time, lo_time): New functions, for an accurate test for
5079 out-of-range times.
5080 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5081 (Fget_internal_run_time): Don't assume time_t fits in int.
5082 (make_time): Use list2 instead of Fcons twice.
5083 (Fdecode_time): More accurate test for out-of-range times.
5084 (check_tm_member): New function.
5085 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5086 (lisp_time_argument): Don't rely on undefined left-shift and
5087 right-shift behavior when checking for time stamp overflow.
8be6f318 5088
fe31d94c
PE
5089 * editfns.c (time_overflow): New function, refactoring common code.
5090 (Fformat_time_string, Fdecode_time, Fencode_time):
5091 (Fcurrent_time_string): Use it.
5092
8be6f318
PE
5093 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5094 * dired.c (make_time): Move to ...
5095 * editfns.c (make_time): ... here.
5096 * systime.h: Note the move.
5097
09d9db2c 50982011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5099
126bc0dc
YM
5100 * fringe.c (update_window_fringes): Remove unused variables.
5101
c47cbdfd
YM
5102 * unexmacosx.c (copy_data_segment): Also copy __got section.
5103 (Bug#8223)
5104
7ac80be9
EZ
51052011-03-12 Eli Zaretskii <eliz@gnu.org>
5106
c96bbc66 5107 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5108 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5109 Constify `char *' arguments and their references according to
5110 prototypes in tparam.h.
5111
ecb0f94d 5112 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5113
7ac80be9
EZ
5114 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5115 Adapt all references accordingly.
5116
5117 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5118
ef1fd07e
TT
51192011-03-11 Tom Tromey <tromey@redhat.com>
5120
5121 * buffer.c (syms_of_buffer): Remove obsolete comment.
5122
7ef4b50c
EZ
51232011-03-11 Eli Zaretskii <eliz@gnu.org>
5124
5125 * termhooks.h (encode_terminal_code): Declare prototype.
5126
5127 * msdos.c (encode_terminal_code): Don't declare prototype.
5128
5129 * term.c (encode_terminal_code): Now external again, used by
5130 w32console.c and msdos.c.
5131
44f230aa
SM
5132 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5133 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5134
4b1ec863 51352011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5136
1714f52b 5137 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5138
4b1ec863
PE
5139 * fringe.c (update_window_fringes): Mark locals as initialized
5140 (Bug#8227).
5141 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5142
524c7aa6
PE
5143 * alloc.c (mark_fringe_data): Move decl from here ...
5144 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5145 to check its interface.
5146 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5147
a5c0af81 5148 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5149 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5150 (fontset_font): Mark local as initialized.
a9a06e0b 5151 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5152
b4716021
PE
5153 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5154
811e9bac 5155 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5156 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5157 (x_own_selection, Fx_disown_selection_internal): Rename locals
5158 to avoid shadowing.
5159 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5160
7e3ab302
PE
5161 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5162 so that the caller can use some name other than gcpro1.
5163 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5164 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5165 (Fx_backspace_delete_keys_p):
5166 Use them to avoid shadowing, and rename vars to avoid shadowing.
5167 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5168 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5169 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5170 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5171 Remove unused locals.
7e3ab302
PE
5172 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5173 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5174 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5175 macros.
f78faa98 5176
e2b13473
PE
5177 * xterm.h (x_mouse_leave): New decl.
5178
77f23912
PE
5179 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5180 Remove unused functions.
cdf4ba58
PE
5181 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5182 (x_calc_absolute_position): Now static.
7411c686 5183 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5184 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5185 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5186 unless they are used.
38d0b34a
PE
5187 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5188 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5189 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5190 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5191 (x_error_catcher, x_connection_closed, x_error_handler):
5192 (x_error_quitter, xembed_send_message, x_iconify_frame):
5193 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5194 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5195 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5196
44f230aa
SM
5197 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5198 Rename or move locals to avoid shadowing.
6b463e58 5199 (tty_defined_color, merge_face_heights): Now static.
5967d051 5200 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5201 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5202 does not deduce is never used uninitialized.
73719eba
PE
5203 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5204 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5205
426994c3 5206 * terminal.c (store_terminal_param): Now static.
5489860b 5207
032f1620 5208 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5209 (set_frame_menubar): Remove unused local.
d4323972 5210 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5211 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5212 since they might point to immutable storage.
281585b0
PE
5213 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5214 since it's unused otherwise.
032f1620 5215
367c19e5 5216 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5217 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5218 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5219 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5220 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5221 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5222 does not deduce are never used uninitialized.
70739cbe 5223
07b48fa9
PE
5224 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5225
8868a238 5226 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5227 * window.c (window_loop, size_window):
5228 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5229
7e5cf297 5230 * window.c (display_buffer): Now static.
d6550a9f
PE
5231 (size_window): Mark variables that gcc -Wuninitialized
5232 does not deduce are never used uninitialized.
a586633d
PE
5233 * window.h (check_all_windows): New decl, to forestall
5234 gcc -Wmissing-prototypes diagnostic.
5b555da1 5235 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5236
f6095868
PE
5237 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5238 shadowing.
5239 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5240 Include <limits.h>.
5241 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5242 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5243 (load_charset_map): Mark variables that gcc -Wuninitialized
5244 does not deduce are never used uninitialized.
53df7c11 5245 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5246
f38b440c
PE
5247 * coding.c (coding_set_source, coding_set_destination):
5248 Use "else { /* comment */ }" rather than "else /* comment */;"
5249 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5250 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5251 a block, when the outer 'i' will do.
5252 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5253 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5254 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5255 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5256 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5257 Rename locals to avoid shadowing.
5258 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5259 * coding.c (emacs_mule_char, encode_invocation_designation):
5260 Now static, since they're not used elsewhere.
413bb2db 5261 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5262 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5263 (decode_coding_emacs_mule): Mark variables that gcc
5264 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5265 (detect_coding_iso_2022): Initialize a local variable that might
5266 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5267 this initialization is needed. (Bug#8211)
5f58e762
PE
5268 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5269 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5270 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5271 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5272 Remove unused macros.
f38b440c 5273
232b38b9 5274 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5275 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5276 * character.c (string_count_byte8): Likewise.
232b38b9 5277
fb90da1b
PE
5278 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5279 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5280
fb93dbc2
PE
5281 * chartab.c (copy_sub_char_table): Now static, since it's not used
5282 elsewhere.
5c156ace
PE
5283 (sub_char_table_ref_and_range, char_table_ref_and_range):
5284 Rename locals to avoid shadowing.
bbcd0949 5285 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5286
7d3b3862 5287 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5288 (BIDI_BOB): Remove unused macro.
7d3b3862 5289
6be7d3da
PE
5290 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5291 deduce are never used uninitialized.
c2ed9c8b 5292 * term.c (encode_terminal_code): Likewise.
6be7d3da 5293
75f8807f 5294 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5295
50938595
PE
5296 * tparam.h: New file.
5297 * term.c, tparam.h: Include it.
5298 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5299 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5300 Move these decls to tparam.h, and make them agree with what
5301 is actually in tparam.c. The previous trick of using incompatible
5302 decls in different modules does not conform to the C standard.
5303 All callers of tparam changed to use tparam's actual API.
5304 * tparam.c (tparam1, tparam, tgoto):
5305 Use const pointers where appropriate.
5306
fbceeba2
PE
5307 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5308 * cm.h (struct cm): Likewise.
5309 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5310 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5311 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5312 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5313 (turn_on_face, init_tty): Likewise.
5314 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5315
7f3f1250
PE
5316 * term.c (term_mouse_position): Rename local to avoid shadowing.
5317
e6ca6543
PE
5318 * alloc.c (mark_ttys): Move decl from here ...
5319 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5320
c40f8d15
AS
53212011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5322
5323 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5324
cfe0661d
JB
53252011-03-09 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * search.c (compile_pattern_1): Remove argument regp, unused since
5328 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5329 (compile_pattern): Don't pass it.
5330
0afb4571
J
53312011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5332
5333 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5334 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5335 for ! HAVE_GTK3.
5336 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5337
5338 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5339
5340 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5341 gdk_window_get_screen, gdk_window_get_geometry,
5342 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5343 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5344 (xg_get_pixbuf_from_pixmap): New function.
5345 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5346 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5347 Call xg_get_pixbuf_from_pixmap instead of
5348 gdk_pixbuf_get_from_drawable.
5349 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5350 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5351 (xg_check_special_colors): Use GtkStyleContext and its functions
5352 for HAVE_GTK3.
5353 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5354 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5355 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5356 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5357 Call gtk_widget_get_preferred_size.
0afb4571
J
5358 (xg_frame_resized): gdk_window_get_geometry only takes 5
5359 parameters.
44f230aa
SM
5360 (xg_win_to_widget, xg_event_is_for_menubar):
5361 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5362 (xg_set_widget_bg): New function.
5363 (delete_cb): New function.
895009e1 5364 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5365 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5366 (xg_set_background_color): Call xg_set_widget_bg.
5367 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5368 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5369 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5370 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5371 if ! HAVE_GTK3.
5372 (update_frame_tool_bar): Call gtk_widget_hide.
5373 (xg_initialize): Use GDK_KEY_g.
5374
5375 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5376 if ! HAVE_GTK3
5377 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5378
5379 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5380 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5381 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5382
1c2cc4ef
JB
53832011-03-08 Juanma Barranquero <lekktu@gmail.com>
5384
5385 * w32xfns.c (select_palette): Check success of RealizePalette against
5386 GDI_ERROR, not zero.
5387
33383987 5388See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5389
5390;; Local Variables:
5391;; coding: utf-8
aac0c6e3
MR
5392;; End:
5393
33383987 5394 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5395
5396 This file is part of GNU Emacs.
5397
5398 GNU Emacs is free software: you can redistribute it and/or modify
5399 it under the terms of the GNU General Public License as published by
5400 the Free Software Foundation, either version 3 of the License, or
5401 (at your option) any later version.
5402
5403 GNU Emacs is distributed in the hope that it will be useful,
5404 but WITHOUT ANY WARRANTY; without even the implied warranty of
5405 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5406 GNU General Public License for more details.
5407
5408 You should have received a copy of the GNU General Public License
5409 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.