Remove unneeded #define POSIX
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ee1cf5cf
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
30fe9bf4
GM
3 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4 unused since 2011-01-17 change to systty.h.
5
ee1cf5cf
GM
6 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
7 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
8 Move HAVE_PTYS and HAVE_SOCKETS to configure.
9
63e47e07
PE
102012-07-11 Paul Eggert <eggert@cs.ucla.edu>
11
12 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
13
c43fb4c3
GM
142012-07-11 Glenn Morris <rgm@gnu.org>
15
16 * s/darwin.h, s/gnu-linux.h, s/template.h:
17 Move INTERRUPT_INPUT to configure.
18
e8df9267
DA
192012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
20
21 Minor adjustments to interning code.
22 * lisp.h (intern, intern_c_string): Redefine as static inline
23 wrappers for intern_1 and intern_c_string_1, respectively.
24 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
25 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
26 Vobarray checking.
e8df9267
DA
27 * font.c (font_intern_prop): Likewise. Adjust comment.
28 * w32font.c (intern_font_name): Likewise.
29
34348bd4
AS
302012-07-11 Andreas Schwab <schwab@linux-m68k.org>
31
d96a1e0c
AS
32 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
33
34348bd4
AS
34 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
35 of Fcar/Fcdr if possible.
36 * font.c (check_otf_features): Likewise.
37 * fontset.c (Fnew_fontset): Likewise.
38 * gnutls.c (Fgnutls_boot): Likewise.
39 * minibuf.c (read_minibuf): Likewise.
40 * msdos.c (IT_set_frame_parameters): Likewise.
41 * xmenu.c (Fx_popup_dialog): Likewise.
42 * w32menu.c (Fx_popup_dialog): Likewise.
43
c8add24e
GM
442012-07-11 Glenn Morris <rgm@gnu.org>
45
4b575b3c
GM
46 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
47 since nothing has defined it on these platforms.
48
09f4e3b0
GM
49 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
50 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
51
172bedef
GM
52 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
53 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
54 Move CLASH_DETECTION to configure.
55
249685df
GM
56 * s/gnu.h: Remove file, which is now empty.
57
c8add24e
GM
58 * s/gnu.h, s/gnu-linux.h:
59 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
60
b41253a3
JW
612012-07-11 John Wiegley <johnw@newartisans.com>
62
63 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
64 function attribute, so we only use it if it exists in the
65 compiler.
66
d923b542
DA
672012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
68
69 Avoid call to strlen in fast_c_string_match_ignore_case.
70 * search.c (fast_c_string_match_ignore_case): Change to use
71 length argument. Adjust users accordingly.
72 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
73
5ebbef1d
PE
742012-07-11 Paul Eggert <eggert@cs.ucla.edu>
75
bb352260
PE
76 Assume mkdir, rmdir.
77 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
78 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
79
57054ddd
PE
80 Assume rename.
81 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
82
b747d3f7
PE
83 Assume perror.
84 * s/hpux10-20.h (HAVE_PERROR): Remove.
85 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
86 Remove dummy definition, as this problem was obsolete long ago.
87
5ebbef1d
PE
88 Assume strerror.
89 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
90
984e7f30
DA
912012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
92
93 Avoid calls to strlen in font processing functions.
94 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 95 (font_open_by_name): Change to use length argument. Adjust
984e7f30 96 users accordingly.
d923b542
DA
97 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
98 Adjust prototypes.
99 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
100 Change to return ptrdiff_t.
984e7f30
DA
101 (xfont_list_pattern, xfont_match): Use length returned by
102 xfont_decode_coding_xlfd.
103 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
104
20e94fdd
GM
1052012-07-11 Glenn Morris <rgm@gnu.org>
106
9d596af3
GM
107 * s/darwin.h, s/freebsd.h, s/netbsd.h:
108 Move DONT_REOPEN_PTY to configure.
109
20e94fdd
GM
110 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
111 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
112
e99a530f
PE
1132012-07-10 Paul Eggert <eggert@cs.ucla.edu>
114
22ffb973
PE
115 Remove "#define unix" that is no longer needed (Bug#11905).
116 * s/aix4-2.h (unix): Remove; no longer needed.
117
e9a9ae03
PE
118 EMACS_TIME simplification (Bug#11875).
119 This replaces macros (which typically do not work in GDB)
120 with functions, typedefs and enums, making the code easier to debug.
121 The functional style also makes code easier to read and maintain.
122 * systime.h: Include <sys/time.h> on all hosts, not just if
123 WINDOWSNT, since 'struct timeval' is needed in general.
124 (EMACS_TIME): Now a typedef, not a macro.
125 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
126 not macros.
127 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
128 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
129 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
130 (EMACS_TIME_LE): Now functions, not macros.
131 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
132 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
133 which are not functions. All uses rewritten to use:
134 (make_emacs_time): New function.
135 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
136 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
137 not functions. All uses rewritten to use the following, respectively:
138 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
139 (add_emacs_time, sub_emacs_time): New functions.
140 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
141 * fileio.c (Fcopy_file):
142 * xterm.c (XTflash): Get the current time closer to when it's used.
143 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
144
ffacb126
PE
145 * bytecode.c (targets): Suppress -Woverride-init warnings.
146
e99a530f
PE
147 Simplify by avoiding confusing use of strncpy etc.
148 * doc.c (Fsnarf_documentation):
149 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
150 * frame.c (Fmake_terminal_frame):
151 * gtkutil.c (get_utf8_string):
152 * lread.c (openp):
153 * nsmenu.m (ns_update_menubar):
154 * regex.c (regerror):
155 Prefer memcpy to strncpy and strncat when either will do.
156 * fileio.c (Fsubstitute_in_file_name):
157 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
158 (menu_separator_name_p):
159 * nsmenu.m (ns_update_menubar):
160 Prefer memcmp to strncmp when either will do.
161 * nsterm.m: Include <ftoastr.h>.
162 (ns_get_color):
163 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
164 Prefer snprintf to strncpy.
165 * nsterm.m (ns_term_init):
166 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
167 * nsterm.m (ns_term_init):
168 Avoid the need for strncpy, by using build_string or
169 make_unibyte_string directly. Use dtoastr, not snprintf.
170 * process.c (Fmake_network_process): Diagnose service names that
171 are too long, rather than silently truncating them or creating
172 non-null-terminated names.
173 (Fnetwork_interface_info): Likewise, for interface names.
174 * sysdep.c (system_process_attributes) [GNU_LINUX]:
175 Prefer sprintf to strncat.
176 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
177 Prefer vsnprintf to vsprintf + strncpy.
178
c59592b3
GM
1792012-07-10 Glenn Morris <rgm@gnu.org>
180
181 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
182 Clarify fallback case.
183
7d7bbefd
DA
1842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
185
186 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
187 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
188 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 189 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
190 where argument type is known to be a Lisp_Cons.
191
3a4c8000
TT
1922012-07-10 Tom Tromey <tromey@redhat.com>
193
194 * bytecode.c (BYTE_CODE_THREADED): New macro.
195 (BYTE_CODES): New macro. Replaces all old byte-code defines.
196 (enum byte_code_op): New type.
197 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
198 (exec_byte_code): Use them. Use token threading when applicable.
199
2a0213a6
DA
2002012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
201
202 Optimize pure C strings initialization.
203 * lisp.h (make_pure_string): Fix prototype.
204 (build_pure_c_string): New function, defined as static inline. This
205 provides a better opportunity to optimize away calls to strlen when
206 the function is called with compile-time constant argument.
207 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
208 argument, adjust users accordingly. Use build_pure_c_string where
209 appropriate.
210 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
211 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
212 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
213
cb1caeaf
DA
2142012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Avoid calls to strlen in miscellaneous functions.
217 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
218 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
219 * lread.c (openp): Likewise.
220
c293e30c
DA
2212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
222
223 Avoid calls to strlen in path processing functions.
224 * fileio.c (file_name_as_directory): Add comment. Change to add
225 srclen argument and return the length of result. Adjust users
226 accordingly.
227 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 228 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
229 users accordingly.
230 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
231
9e059e3f
GM
2322012-07-10 Glenn Morris <rgm@gnu.org>
233
d02eb359
GM
234 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
235 Move PENDING_OUTPUT_COUNT definition to configure.
236
882cf227
GM
237 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
238 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
239 * s/gnu.h (DATA_START): Move definitions to configure.
240
af6e839f
GM
241 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
242 We include usg5-4-common.h, which defines them both.
243
40289a12
GM
244 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
245 O_RDONLY already includes it).
246
9e059e3f
GM
247 Stop ns builds setting the EMACSLOADPATH environment variable.
248 * nsterm.m (ns_load_path): Rename from ns_init_paths.
249 Now it does not set EMACSLOADPATH, just returns the load-path string.
250 * nsterm.h: Update accordingly.
251 * lread.c [HAVE_NS]: Include nsterm.h.
252 (init_lread) [HAVE_NS]: Use ns_load_path.
253 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
254
7c4e8ec0
GM
2552012-07-09 Glenn Morris <rgm@gnu.org>
256
d4f600ff
GM
257 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
258 since the included bsd-common.h does so.
259
cbb31951
GM
260 Stop ns builds setting the EMACSPATH environment variable.
261 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
262 (ns_init_paths): Do not set EMACSPATH.
263 * nsterm.h (ns_exec_path): Add it.
264 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
265 Use ns_exec_path.
266
7c4e8ec0
GM
267 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
268
26bccfae
PE
2692012-07-09 Paul Eggert <eggert@cs.ucla.edu>
270
a0bee46f
PE
271 * process.c (wait_reading_process_output): 'waitchannels' was unset
272 when read_kbd || !NILP (wait_for_cell); fix this.
273
5994c183
PE
274 Add GCC-style 'const' attribute to functions that can use it.
275 * character.h (char_resolve_modifier_mask):
276 * keyboard.h (make_ctrl_char):
277 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
278 (init_character_once, next_almost_prime, init_fns, init_image)
279 (flush_pending_output, init_sound):
280 * mem-limits.h (start_of_data):
281 * menu.h (finish_menu_items):
282 Add ATTRIBUTE_CONST.
283 * emacs.c (DEFINE_DUMMY_FUNCTION):
284 Declare the dummy function with ATTRIBUTE_CONST.
285 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
286 Add decls with ATTRIBUTE_CONST.
287
26bccfae
PE
288 Minor improvements to make_formatted_string.
289 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
290 where int is good enough, as vsprintf returns an int.
291 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
292
a8290ec3
DA
2932012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
294
295 Use make_formatted_string to avoid double length calculation.
296 * lisp.h (make_formatted_string): New prototype.
297 * alloc.c (make_formatted_string): New function.
298 * buffer.c (Fgenerate_new_buffer_name): Use it.
299 * dbus.c (syms_of_dbusbind): Likewise.
300 * editfns.c (Fcurrent_time_zone): Likewise.
301 * filelock.c (get_boot_time): Likewise.
302 * frame.c (make_terminal_frame, set_term_frame_name)
303 (x_report_frame_params): Likewise.
304 * image.c (gs_load): Likewise.
305 * minibuf.c (get_minibuffer): Likewise.
306 * msdos.c (dos_set_window_size): Likewise.
307 * process.c (make_process): Likewise.
308 * xdisp.c (ensure_echo_area_buffers): Likewise.
309 * xsettings.c (apply_xft_settings): Likewise.
310
d01ba2f1
GM
3112012-07-09 Glenn Morris <rgm@gnu.org>
312
313 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
314 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
315 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
316 * nsterm.h (ns_etc_directory): Add it.
317 * callproc.c [HAVE_NS]: Include nsterm.h.
318 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
319
f1f924b6
DA
3202012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Move marker debugging code under MARKER_DEBUG.
323 * marker.c (MARKER_DEBUG): Move marker debugging code under
324 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
325 for bootstrap with --enable-checking (~3x slowdown reported
326 by Juanma Barranquero <lekktu@gmail.com>).
327 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
328
ab531b66
PE
3292012-07-08 Paul Eggert <eggert@cs.ucla.edu>
330
331 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
332 See <http://bugs.gnu.org/11825#29>.
333
c4b3bc8a
EZ
3342012-07-08 Eli Zaretskii <eliz@gnu.org>
335
336 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
337 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
338 (display_line): Add commentary about displaying truncation glyphs
339 on GUI frames.
340 (produce_special_glyphs): Move here from term.c.
341
342 * term.c (produce_special_glyphs): Move to xdisp.c.
343
344 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
345 section.
c4b3bc8a 346
b676b881
AS
3472012-07-07 Andreas Schwab <schwab@linux-m68k.org>
348
f17c5273
AS
349 * xdisp.c (display_line): Avoid warning about implicit declaration
350 of FRAME_FONT.
351
298819b9
AS
352 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
353
b676b881
AS
354 * lisp.h: Remove empty conditional.
355
6045c4fd
PE
3562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
357
b3350bf9
PE
358 * lread.c (load_path_check): Now static.
359
6045c4fd
PE
360 Fix some minor --with-ns problems found by static checking.
361 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
362 (x_set_font) [!HAVE_X_WINDOWS]:
363 * image.c (xpm_load_image) [HAVE_NS]:
364 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
365 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
366 Remove unused local.
367 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
368 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
369 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
370 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
371 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
372 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
373 Fix pointer signedness problem.
374 * xfaces.c (FRAME_X_FONT_TABLE):
375 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
376
929e7845
GM
3772012-07-07 Glenn Morris <rgm@gnu.org>
378
379 * lread.c (load_path_check): New function, split from init_lread.
380 (init_lread): Reorganize. Motivation:
381 If EMACSLOADPATH is set, check/warn about that rather than the
382 defaults, which we are not going to use. Hence we can remove
383 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
384 Don't warn if site-lisp directories are missing.
385 If not installed, start from a blank load-path, since
386 PATH_LOADSEARCH refers to the eventual installation directories.
387
58dd0aa4
EZ
3882012-07-07 Eli Zaretskii <eliz@gnu.org>
389
390 Support truncation and continuation glyphs on GUI frames, when
391 fringes are disabled. (Bug#11832)
392 * xdisp.c (init_iterator): Get dimensions of truncation and
393 continuation glyphs even if on GUI frames. Adjust
394 it->last_visible_x on GUI frames when the left or right fringes,
395 or both, are absent.
396 (start_display, move_it_in_display_line_to): Handle the case of a
397 GUI frame without a fringe to display continuation or truncation
398 glyphs.
399 (insert_left_trunc_glyphs): Support GUI frames: make sure
400 truncation glyphs overwrite enough glyphs from the current line to
401 have sufficient space in pixels.
402 (display_line): Support truncation and continuation glyphs on GUI
403 frames. If some spare pixels are left on the line after inserting
404 the truncation glyphs, fill that space with a stretch glyph of a
405 suitably computed width.
406
407 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
408 produce_glyphs, to support GUI sessions.
409
31571fd7
PE
4102012-07-07 Paul Eggert <eggert@cs.ucla.edu>
411
5a16b9bc
PE
412 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
413
f3047c75
PE
414 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
415
31571fd7
PE
416 Do not require float-time's arg to fit in time_t (Bug#11825).
417 This works better on hosts where time_t is unsigned, and where
418 float-time is applied to the (negative) difference between two times.
419 * editfns.c (decode_time_components): Last arg is now double *,
420 not int *, and means to store all the result as a double, without
421 worrying about whether the seconds part fits in time_t.
422 All callers changed.
423 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
424 All callers changed.
425 (Ffloat_time): Do not fail merely because the specified time falls
426 outside of time_t range.
427
4516fbef
GM
4282012-07-07 Glenn Morris <rgm@gnu.org>
429
430 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
431 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
432 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
433
07adc2c6
JB
4342012-07-07 Juanma Barranquero <lekktu@gmail.com>
435
436 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
437 Update dependencies.
438
439 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
440
fd573f31
PE
4412012-07-06 Paul Eggert <eggert@cs.ucla.edu>
442
fee5959d
PE
443 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
444 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
445 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
446 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
447 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
448 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
449
fd573f31
PE
450 * xfont.c (compare_font_names): Redo to omit the need for casts.
451
ddadbc0e
AS
4522012-07-06 Andreas Schwab <schwab@linux-m68k.org>
453
fca8d6b6
AS
454 * xfns.c (Fx_change_window_property): Doc fix.
455 * w32fns.c (Fx_change_window_property): Doc fix.
456
ddadbc0e
AS
457 * w32fns.c (Fx_window_property): Accept the same arguments as the
458 X Windows version. Doc fix.
459 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
460
f247498e
JB
4612012-07-06 Juanma Barranquero <lekktu@gmail.com>
462 Eli Zaretskii <eliz@gnu.org>
463
464 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
465 Windows-specific code from nt/config.nt moved here.
466 Obsolete settings removed.
467
216ee680
PE
4682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
469
470 * process.c: Avoid unnecessary calls to gettime.
471 (wait_reading_process_output): Don't get the time of day
472 when gobbling data immediately and not waiting, as there's no need
473 for it in that case. This removes a FIXME.
474
bdd091e4
JD
4752012-07-06 Jan Djärv <jan.h.d@swipnet.se>
476
477 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
478 is defined (Bug#11768).
479
9d44f8ce
DA
4802012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
481
482 Fix marker debugging code.
483 * marker.c (byte_char_debug_check): Do not perform the check
484 if buffer is not multibyte.
090bd7cb
JB
485 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
486 Call byte_char_debug_check with correct arguments.
9d44f8ce 487
90fc4786
DA
4882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
489
490 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
491 * marker.c (byte_char_debug_check, count_markers):
492 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
493 (byte_debug_flag): Remove.
494 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
495 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
496
7b7ae965
DA
4972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
498
4e57b342
DA
499 Avoid code repetition in marker-related functions.
500 * marker.c (attach_marker): New function.
501 (Fset_marker, set_marker_restricted, set_marker_both)
502 (set_marker_restricted_both): Use it.
503 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
504 Consistently rename charno to charpos.
505 (marker_position): Add eassert.
506 (marker_byte_position): Convert to eassert.
507
5082012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
509
510 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 511 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 512 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 513
657924ff
DA
5142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
515
516 Introduce fast path for the widely used marker operation.
517 * alloc.c (build_marker): New function.
518 * lisp.h (build_marker): New prototype.
519 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
520 * composite.c (autocmp_chars): Likewise.
521 * editfns.c (buildmark): Remove.
522 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
523 (save_restriction_save): Use build_marker.
524 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
525 * window.c (save_window_save): Likewise.
526
041a49a6
DA
5272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
528
529 Do not use Fdelete_overlay in delete_all_overlays
530 to avoid redundant calls to unchain_overlay.
531 * buffer.c (drop_overlay): New function.
532 (delete_all_overlays, Fdelete_overlay): Use it.
533 * minibuf.c (get_minibuffer): Fix comment.
534
7dca65a4
PE
5352012-07-06 Paul Eggert <eggert@cs.ucla.edu>
536
537 Port to OpenBSD 5.1 amd64.
538 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
539 This is needed for OpenBSD, and should be harmless on all BSD systems.
540 Also, include <sys/sysctl.h>, as it should be available on all
541 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
542 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
543 use p_pid member, not kp_proc.pid.
544
8eb876e2
GM
5452012-07-06 Glenn Morris <rgm@gnu.org>
546
547 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
548
38182d90
PE
5492012-07-05 Paul Eggert <eggert@cs.ucla.edu>
550
551 More xmalloc and related cleanup.
552 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
553 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
554 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
555 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
556 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
557 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
558 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
559 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
560 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
561 * xterm.c:
562 Omit needless casts involving void * pointers and allocation.
563 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
564 as the former is more robust if P's type is changed.
565 Prefer xzalloc to xmalloc + memset 0.
566 Simplify malloc-or-realloc to realloc.
567 Don't worry about xmalloc returning a null pointer.
568 Prefer xstrdup to xmalloc + strcpy.
569 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
570 growing it.
571 * keyboard.c (apply_modifiers_uncached): Prefer local array to
572 alloca of a constant.
573
6dd5a677
EZ
5742012-07-05 Eli Zaretskii <eliz@gnu.org>
575
576 * xdisp.c (display_line): Fix horizontal pixel coordinates when
577 hscroll is larger than the line width. Fixes long and futile
578 looping inside extend_face_to_end_of_line (on a TTY) producing
579 glyphs that are not needed and thrown away.
580
6b312f0f
DA
5812012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
582
583 * marker.c (set_marker_restricted_both): Simplify by using
584 clip_to_bounds.
585
f520ef9b
PE
5862012-07-05 Paul Eggert <eggert@cs.ucla.edu>
587
588 * editfns.c (region_limit): Simplify by using clip_to_bounds.
589
383b7c95
JD
5902012-07-05 Jan Djärv <jan.h.d@swipnet.se>
591
592 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
593 not defined (Bug#11768).
594 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
595 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
596 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
597 followed by gtk_box_set_homogeneous (Bug#11768).
598 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
599 (update_theme_scrollbar_width, xg_create_scroll_bar):
600 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
601 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
602 (is_box_type): New function (Bug#11768).
603 (xg_tool_item_stale_p): Call is_box_type.
5293d758 604 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
605 with default display (Bug#11768).
606
d6e7bf45
EZ
6072012-07-05 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (window_hscroll_limited): New function.
610 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
611 coordinates when window's hscroll is set to insanely large
612 values. (Bug#11857)
613
431391ec
JB
6142012-07-05 Juanma Barranquero <lekktu@gmail.com>
615
616 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
617 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
618
23f86fce
DA
6192012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
620
621 Cleanup xmalloc.
622 * lisp.h (xzalloc): New prototype. Omit needless casts.
623 * alloc.c (xzalloc): New function. Omit needless casts.
624 * charset.c: Omit needless casts. Convert all calls to
625 xmalloc with following memset to xzalloc.
626 * dispnew.c: Likewise.
627 * fringe.c: Likewise.
628 * image.c: Likewise.
629 * sound.c: Likewise.
630 * term.c: Likewise.
631 * w32fns.c: Likewise.
632 * w32font.c: Likewise.
633 * w32term.c: Likewise.
634 * xfaces.c: Likewise.
635 * xfns.c: Likewise.
636 * xterm.c: Likewise.
637 * atimer.c: Omit needless casts.
638 * buffer.c: Likewise.
639 * callproc.c: Likewise.
640 * ccl.c: Likewise.
641 * coding.c: Likewise.
642 * composite.c: Likewise.
643 * doc.c: Likewise.
644 * doprnt.c: Likewise.
645 * editfns.c: Likewise.
646 * emacs.c: Likewise.
647 * eval.c: Likewise.
648 * filelock.c: Likewise.
649 * fns.c: Likewise.
650 * gtkutil.c: Likewise.
651 * keyboard.c: Likewise.
652 * lisp.h: Likewise.
653 * lread.c: Likewise.
654 * minibuf.c: Likewise.
655 * msdos.c: Likewise.
656 * print.c: Likewise.
657 * process.c: Likewise.
658 * region-cache.c: Likewise.
659 * search.c: Likewise.
660 * sysdep.c: Likewise.
661 * termcap.c: Likewise.
662 * terminal.c: Likewise.
663 * tparam.c: Likewise.
664 * w16select.c: Likewise.
665 * w32.c: Likewise.
666 * w32reg.c: Likewise.
667 * w32select.c: Likewise.
668 * w32uniscribe.c: Likewise.
669 * widget.c: Likewise.
670 * xdisp.c: Likewise.
671 * xmenu.c: Likewise.
672 * xrdb.c: Likewise.
673 * xselect.c: Likewise.
674
0497dc44
PE
6752012-07-05 Paul Eggert <eggert@cs.ucla.edu>
676
677 * fileio.c (time_error_value): Check the right error number.
678 Problem reported by Troels Nielsen in
679 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
680
356e7178
PE
6812012-07-04 Paul Eggert <eggert@cs.ucla.edu>
682
4e71fd89
PE
683 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
684 This should be fixed in a better way; see Eli Zaretskii in
685 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
686 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
687
f0941253
PE
688 * fileio.c (time_error_value): Rename from special_mtime.
689 The old name's problems were noted by Eli Zaretskii in
690 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
691
065c9eb4
PE
692 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
693 This variable's comment says Emacs needs at least one GDB-visible
694 symbol of type enum pvec_type, to work around GDB problems.
695 The symbol's value doesn't matter.
696
356e7178
PE
697 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
698 that causes compilation to fail on pre-C99 compilers.
699
95f61aa2
JB
7002012-07-04 Juanma Barranquero <lekktu@gmail.com>
701
702 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
703 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
704
3884d954
DA
7052012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
706
d209e2fb 707 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
708 headers for buffer_defaults and buffer_local_symbols.
709 Reported by Juanma Barranquero <lekktu@gmail.com>.
710
ee28be33
SM
7112012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
712
713 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
714 * lisp.h (enum pvec_type): Use fewer bits.
715 (PSEUDOVECTOR_SIZE_BITS): New constant.
716 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
717 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
718 change in pvec_type.
719 (PSEUDOVECTOR_TYPEP): New macro.
720 (TYPED_PSEUDOVECTORP): Use it.
721 * fns.c (internal_equal): Adapt code to extract pvectype.
722 * emacs.c (gdb_pvec_type): Update type.
723 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
724 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
725 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
726 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
727 (sweep_vectors): Use it. Use local var `total_bytes' instead of
728 abusing vector->header.next.nbytes.
729 (live_vector_p): Use PVEC_TYPE.
730 (mark_object): Adapt code to extract pvectype. Use switch.
731
c7f2cd7f
PE
7322012-07-04 Paul Eggert <eggert@cs.ucla.edu>
733
734 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
735 Tighten new eassert a bit.
736
8ce70ed2
DA
7372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
738
739 Fix compilation with --enable-gcc-warnings and -O1
740 optimization level.
741 * doprnt.c (doprnt): Change type of tem to int, initialize
742 to avoid compiler warning. Add eassert.
743 * search.c (simple_search): Initialize match_byte to avoid
744 compiler warning. Add eassert.
745
dea7f1e5
PE
7462012-07-04 Paul Eggert <eggert@cs.ucla.edu>
747
24a212eb
PE
748 Avoid weird behavior with large horizontal scrolls.
749 Without this change, for example, large hscroll values would
750 mess up Emacs's display on Fedora 15 x86, presumably due to
751 overflows in int calculations in the display code.
752 Also, if buffers had long lines, Emacs would freeze.
753 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
754 (set_window_hscroll): New function, containing the old guts of
755 Fset_window_hscroll. Return the clipped value.
756 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
757 This avoids the need to check against PTRDIFF_MAX.
758
dea7f1e5
PE
759 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
760
76046526
DA
7612012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
762
763 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
764
39adff0d
PE
7652012-07-04 Paul Eggert <eggert@cs.ucla.edu>
766
63807d47
PE
767 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
768 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
769 since GCC 4.4.6 issues a bogus warning for them.
770
39adff0d
PE
771 Fix bugs in file timestamp newness comparisons.
772 * fileio.c (Ffile_newer_than_file_p):
773 * lread.c (Fload): Use full timestamp resolution of files,
774 not just the 1-second resolution, so that files that are only
775 slightly newer still count as newer.
776 * fileio.c (Ffile_newer_than_file_p): Don't assume file
777 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
778
dbeed9a6
PE
7792012-07-03 Paul Eggert <eggert@cs.ucla.edu>
780
781 * fileio.c: Improve handling of file time marker. (Bug#11852)
782 (special_mtime): New function.
783 (Finsert_file_contents, Fverify_visited_file_modtime):
784 Use it to set special mtime values consistently.
785
636334d6
AS
7862012-07-03 Andreas Schwab <schwab@linux-m68k.org>
787
788 * fileio.c (Finsert_file_contents): Properly handle st_mtime
789 marker for non-existing file. (Bug#11852)
790
e2017fe2
GM
7912012-07-03 Glenn Morris <rgm@gnu.org>
792
793 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
794 and did not make it into globals.h).
795
404dbd37
TT
7962012-07-03 Tom Tromey <tromey@redhat.com>
797
798 * window.c (Fset_window_margins, Fset_window_fringes)
799 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
800 * textprop.c (Fprevious_property_change): No longer static.
801 * syntax.c (Fsyntax_table_p): No longer static.
802 * process.c (Fget_process, Fprocess_datagram_address): No longer
803 static.
804 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
805 * keyboard.c (Fcommand_execute): No longer static.
806 Remove EXFUN.
807 * insdel.c (Fcombine_after_change_execute): No longer static.
808 * image.c (Finit_image_library): No longer static.
809 * fileio.c (Fmake_symbolic_link): No longer static.
810 * eval.c (Ffetch_bytecode): No longer static.
811 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
812 * doc.c (Fdocumentation_property, Fsnarf_documentation):
813 No longer static.
404dbd37
TT
814 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
815 static.
816 * dired.c (Ffile_attributes): No longer static.
817 * composite.c (Fcomposition_get_gstring): No longer static.
818 * callproc.c (Fgetenv_internal): No longer static.
819
820 * ccl.h: Remove EXFUNs.
821 * buffer.h: Remove EXFUNs.
822 * dispextern.h: Remove EXFUNs.
823 * intervals.h: Remove EXFUNs.
824 * fontset.h: Remove EXFUN.
825 * font.h: Remove EXFUNs.
826 * dosfns.c (system_process_attributes): Remove EXFUN.
827 * keymap.h: Remove EXFUNs.
828 * lisp.h: Remove EXFUNs.
829 * w32term.h: Remove EXFUNs.
830 * window.h: Remove EXFUNs.
831 * xsettings.h: Remove EXFUN.
832 * xterm.h: Remove EXFUN.
833
8e4fd1e1
GM
8342012-07-03 Glenn Morris <rgm@gnu.org>
835
836 * lisp.h (Frandom): Make it visible to C.
837 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
838 buffer for invisible buffers. (Bug#1229)
839
ca95b3eb
DA
8402012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
843 values which aren't power of 2.
844 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
845 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
846 accordingly.
847
7555c33f
SM
8482012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
849
850 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
851
852 * alloc.c (mark_object): Revert part of last patch to use `switch'.
853
d12e8f5a
DA
8542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
855
856 * alloc.c (allocate_vector_block): Remove redundant
857 calls to mallopt if DOUG_LEA_MALLOC is defined.
858 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
859 avoid calls to mallopt if zero_vector is returned.
860
296094c3
DA
8612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
862
863 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
864 is enabled, avoid dereferencing NULL current_sblock if
865 running undumped.
866
36429c89
DA
8672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Cleanup basic buffer management.
870 * buffer.h (struct buffer): Change layout to use generic vector
871 marking code. Fix some comments. Change type of 'clip_changed'
872 to bitfield. Remove unused #ifndef old.
873 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
874 (GET_OVERLAYS_AT): Fix indentation.
875 (for_each_per_buffer_object_at): New macro.
876 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
877 (Fbuffer_local_variables): Use it.
878 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
879 * alloc.c (allocate_buffer): Adjust to match new layout of
880 struct buffer. Fix comment.
881 (mark_overlay): New function.
882 (mark_buffer): Use it. Use mark_vectorlike to mark normal
883 Lisp area of struct buffer.
884 (mark_object): Use it. Adjust marking of misc objects
885 and related comments.
886
3b3e4cac
PE
8872012-07-02 Paul Eggert <eggert@cs.ucla.edu>
888
889 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
890 wrapper that is not needed because the wrapped code is a no-op (zero
891 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
892 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
893
cf5c0175
DA
8942012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
895
896 * alloc.c (mark_buffer): Simplify. Remove prototype.
897 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 898 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
899 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
900 redundant calls to mark_vectorlike for bool vectors.
901
ca26824c
GM
9022012-06-30 Glenn Morris <rgm@gnu.org>
903
2e4c5312
GM
904 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
905
ca26824c
GM
906 * epaths.in (PATH_SITELOADSEARCH): New.
907 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
908 This is rather than relying on --enable-locallisppath elements
909 having "site-lisp" in their names. (Bug#10208#25, 11658)
910
0d23c240
EZ
9112012-06-30 Eli Zaretskii <eliz@gnu.org>
912
c9240d7a
EZ
913 * w32proc.c (sys_select): Accept and ignore one more argument.
914
915 * w32.c (emacs_gnutls_pull): Call select with one more argument.
916
0d23c240 917 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 918 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
919
920 * sysdep.c: Don't include dos.h and dosfns.h.
921
922 * process.c (sys_select):
923 * msdos.c (sys_select): Accept one more argument and ignore it.
924
925 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
926 adapt data types and code to that.
927
928 * dosfns.c:
929 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
930 which clashes with the gnulib function of the same name.
931
af5a5a98
AS
9322012-06-30 Andreas Schwab <schwab@linux-m68k.org>
933
c5e4379c
AS
934 * font.c (font_style_to_value, font_style_symbolic)
935 (font_prop_validate_style): Add type checks for values in
936 font_style_table.
937
af5a5a98
AS
938 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
939 argument.
940 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
941 uses.
942
8d38f461
EZ
9432012-06-29 Eli Zaretskii <eliz@gnu.org>
944
2e5a6631
EZ
945 * xdisp.c (try_window_id): Undo last change.
946
8d38f461
EZ
947 * w32.c (getwd): Adjust commentary about startup_dir.
948 (init_environment): Always call sys_access, even in non-MSVC
949 builds. Don't chdir to the directory of the Emacs executable.
950 This undoes code from 1997 which was justified by the need to
951 "avoid conflicts when removing and renaming directories". But its
952 downside was that every relative file name was being interpreted
953 relative to the directory of the Emacs executable, which can never
954 be TRT. In particular, it broke sys_access when called with
955 relative file names.
956 (sys_access): Map GetLastError to errno.
957
2af3565e
DA
9582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
959
960 * window.h (struct window): Change type of 'fringes_outside_margins'
961 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 962 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
963 Adjust comment.
964 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
965 to ptrdiff_t.
966
c8d3a25c 9672012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 968
c8d3a25c
GM
969 * gnutls.c (emacs_gnutls_handshake):
970 Add QUIT to make the loop interruptible.
57570cd3 971
c8d3a25c 9722012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 973
c8d3a25c
GM
974 * charset.c (init_charset): Make lack of etc/charsets fatal.
975
3e984ee8
DA
9762012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
977
978 * editfns.c (region_limit): Fix type mismatch.
979
ef884f23
DA
9802012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
981
982 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
983 undefined. Convert from xassert to eassert.
984 * nsmenu.m: Convert from xassert to eassert.
985 * nsterm.m: Likewise.
986
7d7e0027
SM
9872012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
988
989 * editfns.c (region_limit): Clip to narrowing (bug#11770).
990
aa754e6a
PE
9912012-06-28 Paul Eggert <eggert@cs.ucla.edu>
992
993 Avoid integer overflow on scroll-left and scroll-right.
994 * window.c (HSCROLL_MAX): New macro.
995 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
996 overflow when requested scroll falls outside ptrdiff_t range.
997
80b00b08
DA
9982012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 * window.h (struct window): Change type of 'hscroll',
1001 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1002 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1003 Adjust users accordingly.
1004 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1005 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1006 from EMACS_INT to ptrdiff_t.
1007 (make_window): Omit redundant initialization.
1008
62b2bcf6
JB
10092012-06-28 Juanma Barranquero <lekktu@gmail.com>
1010
1011 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1012
45942c7d
DA
10132012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 * window.h (struct window): Change type of 'use_time' and
1016 'sequence_number' from Lisp_Object to int.
1017 * frame.c (make_frame): Adjust users accordingly.
1018 * print.c (print_object): Likewise.
1019 * window.c (select_window, Fwindow_use_time, make_parent_window)
1020 (make_window): Likewise.
1021
e509cfa6
DA
10222012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1023
1024 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1025 enabled with --enable-checking=[all,glyphs] configure option.
1026 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1027 adjust comments accordingly.
1028 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1029 undefined, adjust comments accordingly.
1030 * image.c: Likewise.
1031 * scroll.c: Likewise.
1032 * w32fns.c: Likewise.
1033 * w32term.c: Likewise.
1034 * xdisp.c: Likewise.
1035 * xfaces.c: Likewise.
1036 * xfns.c: Likewise.
1037 * xterm.c: Likewise.
1038
a54e2c05
DA
10392012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1040
1041 Generalize run-time debugging checks.
1042 * dispextern.h (XASSERTS): Remove.
1043 * fontset.c (xassert): Remove.
1044 Convert from xassert to eassert.
1045 * alloc.c: Convert from xassert to eassert.
1046 * bidi.c: Likewise.
1047 * dispnew.c: Likewise.
1048 * fns.c: Likewise.
1049 * fringe.c: Likewise.
1050 * ftfont.c: Likewise.
1051 * gtkutil.c: Likewise.
1052 * image.c: Likewise.
1053 * keyboard.c: Likewise.
1054 * menu.c: Likewise.
1055 * process.c: Likewise.
1056 * scroll.c: Likewise.
1057 * sound.c: Likewise.
1058 * term.c: Likewise.
1059 * w32console.c: Likewise.
1060 * w32fns.c: Likewise.
1061 * w32term.c: Likewise.
1062 * window.c: Likewise.
1063 * xdisp.c: Likewise.
1064 * xfaces.c: Likewise.
1065 * xfns.c: Likewise.
1066 * xselect.c: Likewise.
1067 * xterm.c: Likewise.
1068
1ec4b7b2
SM
10692012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1070
1071 * fns.c (maybe_resize_hash_table): Output message when growing the
1072 purify-hashtable.
1073
2014308a
DA
10742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1075
1076 * alloc.c (allocate_string_data): Remove dead code.
1077 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1078 avoid GCC warning about unused macro.
1079
246155eb
DA
10802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1081
1082 * alloc.c (allocate_string): Omit intervals initialization.
1083 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1084 as in make_pure_string and make_pure_c_string.
1085
43184b7b
DA
10862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1087
d209e2fb 1088 * alloc.c (allocate_string): Fix last change.
43184b7b 1089
3fe6dd74
DA
10902012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1091
d209e2fb 1092 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1093 to memset, add explicit initialization where appropriate.
1094
1ba6038a
GM
10952012-06-27 Glenn Morris <rgm@gnu.org>
1096
1097 * lisp.mk (lisp): Remove paths.elc.
1098
c89926a5
CY
10992012-06-27 Chong Yidong <cyd@gnu.org>
1100
1101 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1102
ed6b3510
JW
11032012-06-26 John Wiegley <johnw@newartisans.com>
1104
1ec4b7b2 1105 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1106 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1107
ed6b3510
JW
1108 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1109 when building with Clang.
1110
8edd4a2b
SM
11112012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1112
1113 * eval.c (Fapply): Allow calling it with a single argument.
1114
f6f62d1b
EZ
11152012-06-26 Eli Zaretskii <eliz@gnu.org>
1116
1117 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1118 _stricmp and _strnicmp.
1119 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1120
62efea5e
DA
11212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1124 allocated window.
1125 (allocate_process): Likewise for new process.
8edd4a2b 1126 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1127 (allocate_frame): Likewise.
1128 * frame.c (make_frame): Omit redundant initialization.
1129 * window.c (make_parent_window): Use memset.
1130 (make_window): Omit redundant initialization.
1131 * process.c (make_process): Omit redundant initialization.
1132 * terminal.c (create_terminal): Likewise.
1133
42997f4d
DA
11342012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1135
1136 * term.c (delete_tty): Remove redundant call to memset.
1137
1130ecfc
DA
11382012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 * alloc.c: Remove build_string.
1141 * lisp.h: Define build_string as static inline. This provides
1142 a better opportunity to optimize away calls to strlen when the
1143 function is called with compile-time constant argument.
1144 * image.c (imagemagick_error): Convert to build_string.
1145 * w32proc.c (sys_spawnve): Likewise.
1146 * xterm.c (x_term_init): Likewise.
1147
cf38a720
PE
11482012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1149
99027bdd
PE
1150 Use sprintf return value instead of invoking strlen on result.
1151 In the old days this wasn't portable, since some sprintf
1152 implementations returned char *. But they died out years ago and
1153 Emacs already assumes sprintf returns int.
1154 Similarly for float_to_string.
1155 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1156 * ccl.c (ccl_driver):
1157 * character.c (string_escape_byte8):
1158 * data.c (Fnumber_to_string):
1159 * doprnt.c (doprnt):
1160 * print.c (print_object):
1161 * xdisp.c (message_dolog):
1162 * xfns.c (syms_of_xfns):
1163 Use sprintf or float_to_string result to avoid need to call strlen.
1164 * data.c (Fnumber_to_string):
1165 Use make_unibyte_string, since the string must be ASCII.
1166 * lisp.h, print.c (float_to_string): Now returns int length.
1167 * term.c (produce_glyphless_glyph):
1168 Use sprintf result rather than recomputing it.
1169
cf38a720
PE
1170 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1171 * Makefile.in (ALL_CFLAGS):
1172 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1173 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1174
3511c784
DA
11752012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1176
0a08eb21 1177 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1178 strcasecmp if available.
1179 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1180
fb7da12e
AS
11812012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1182
1183 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1184 Avoid comma operator.
1185 * menu.c (push_submenu_start, push_submenu_end)
1186 (push_left_right_boundary, push_menu_pane): Likewise.
1187 * msdos.c (dos_rawgetc): Likewise.
1188
afa2ffd8
DA
11892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1190
1191 * xfns.c (xic_create_fontsetname): Remove redundant calls
1192 to memset.
1193
b3b4476b
PE
11942012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1195
4495ff38
PE
1196 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1197 sprintf already null-terminates its output.
1198
b3b4476b
PE
1199 * xfns.c (x_window): Remove redundant cast.
1200
b00876c9
DA
12012012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1202
1203 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1204 `const char *' to `char *' to avoid compiler warning.
1205
d188e26b
PE
12062012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1207
885d1d74
PE
1208 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1209 instead of truncating it to 63 (admittedly a generous limit).
1210
d188e26b
PE
1211 * process.c: Fix spelling and caps in comments.
1212
e2f560b1
DN
12132012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1214
e86db54b 1215 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1216 * sysdep.c (setpgrp): Remove definition, not used in this file.
1217
7583a3a1
JB
12182012-06-24 Juanma Barranquero <lekktu@gmail.com>
1219
1220 * makefile.w32-in: Update dependencies.
1221
696056c2
EZ
12222012-06-24 Eli Zaretskii <eliz@gnu.org>
1223
1224 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1225 (SYSTIME_H): Add nt/inc/sys/time.h.
1226
1227 * systime.h [WINDOWSNT]: Include sys/time.h.
1228
1229 * s/ms-w32.h (struct timespec): Definition moved from
1230 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1231
845ca893
PE
12322012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1235 * buffer.h (buffer_slot_type_mismatch):
1236 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1237 * eval.c (unwind_to_catch):
1238 * image.c (my_png_error, my_error_exit):
1239 * keyboard.c (quit_throw_to_read_char, user_error)
1240 (Fexit_recursive_edit, Fabort_recursive_edit):
1241 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1242 (wrong_type_argument, buffer_overflow, __executable_start)
1243 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1244 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1245 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1246 (fatal):
1247 (child_setup) [!DOS_NT]:
1248 * lread.c (end_of_file_error, invalid_syntax):
1249 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1250 * puresize.h (pure_write_error):
1251 * search.c (matcher_overflow):
1252 * sound.c (sound_perror, alsa_sound_perror):
1253 * sysdep.c, syssignal.h (croak):
1254 * term.c (maybe_fatal, vfatal):
1255 * textprop.c (text_read_only):
1256 * undo.c (user_error):
1257 * unexmacosx.c (unexec_error):
1258 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1259 Use _Noreturn rather than NO_RETURN.
1260 No need for separate decl merely because of _Noreturn.
1261 * sound.c (sound_warning, parse_sound):
1262 Remove unnecessary forward decls.
1263
f1dd8073
PE
12642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1267 * lisp.h (WAIT_READING_MAX): New macro.
1268 * dispnew.c (Fsleep_for, sit_for):
1269 * keyboard.c (kbd_buffer_get_event):
1270 * process.c (Faccept_process_output):
1271 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1272 This improves on the previous patch, which introduced a bug
1273 when time_t is unsigned and as wide as intmax_t.
1274 See <http://bugs.gnu.org/9000#51>.
1275
b82c1755
EZ
12762012-06-23 Eli Zaretskii <eliz@gnu.org>
1277
1278 * dispnew.c (sit_for, Fsleep_for):
1279 * keyboard.c (kbd_buffer_get_event):
1280 * process.c (Faccept_process_output): Avoid compiler warnings when
1281 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1282
ca300656
JB
12832012-06-23 Juanma Barranquero <lekktu@gmail.com>
1284
049ec95b
JB
1285 * makefile.w32-in: Update dependencies.
1286
ca300656
JB
1287 * w32.c (ltime): Add return type and declare static.
1288 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1289
db7b8d06
PE
12902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1293 Privately reported by Herbert J. Skuhra.
1294 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1295 All uses changed.
1296 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1297 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1298
0bd8297f
EZ
12992012-06-23 Eli Zaretskii <eliz@gnu.org>
1300
96512555
EZ
1301 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1302 last argument of make_unibyte_string.
1303
0bd8297f
EZ
1304 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1305 language ID in the event parameters.
1306
1307 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1308 event.code, not the obscure "character set ID".
1309
63def6b6
CY
13102012-06-23 Chong Yidong <cyd@gnu.org>
1311
1312 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1313
e8a02204
EZ
13142012-06-23 Eli Zaretskii <eliz@gnu.org>
1315
388cdec0
EZ
1316 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1317 * w32.c (fdutimens): New function.
1318
1319 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1320
1321 * s/ms-w32.h (pselect): Redirect to sys_select.
1322
1323 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1324
e8a02204
EZ
1325 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1326 in the logic of incrementing and decrementing the value of
1327 use_relocatable_buffers.
1328
d054f3fb
PE
13292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1332 Privately reported by Herbert J. Skuhra.
1333 [__FreeBSD__]: Remove "*/" typo after "#include".
1334 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1335 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1336 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1337 Don't assume EMACS_TIME and struct timeval are the same type.
1338
d35af63c
PE
13392012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1340
1341 Support higher-resolution time stamps (Bug#9000).
1342 The time stamps are only nanosecond-resolution at the C level,
1343 since that's the best that any real-world system supports now.
1344 But they are picosecond-resolution at the Lisp level, as that's
1345 easy, and leaves room for future OS improvements.
1346
1347 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1348 (LIBES): Use it.
1349
1350 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1351 Don't get current time unless it's needed.
1352
1353 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1354 now provides it if it's absent.
1355 (start_atimer): Port to higher-res time stamps.
1356 Check for time stamp overflow. Don't get current time more
1357 often than is needed.
1358
1359 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1360 Include systime.h, not time.h.
1361 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1362
1363 * dired.c: Include stat-time.h.
1364 (Ffile-attributes): File times now have higher resolution.
1365
1366 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1367 (struct image): Timestamp now has higher resolution.
1368
1369 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1370 has at least microseconds now. All uses removed.
1371 (update_frame, update_single_window, update_window, update_frame_1)
1372 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1373
1374 * editfns.c (time_overflow): Now extern.
1375 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1376 (float-time, Fformat_time_string, Fcurrent_time_string)
1377 (Fcurrent_time_zone): Accept and generate higher-resolution
1378 time stamps.
1379 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1380 (decode_time_components, lisp_seconds_argument): New functions.
1381 (make_time): Now static.
1382 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1383 Report an error if the time is invalid, rather than having the caller
1384 do that.
1385
1386 * fileio.c: Include <stat-time.h>
1387 (Fcopy_file): Copy higher-resolution time stamps.
1388 Prefer to set the time stamp via a file descriptor if that works.
1389 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1390 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1391 (Fvisited_file_modtime, Fset_visited_file_modtime):
1392 Support higher-resolution time stamps.
1393
1394 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1395
1396 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1397
1398 * image.c (prepare_image_for_display, clear_image_cache)
1399 (lookup_image): Port to higer-resolution time stamps.
1400
1401 * keyboard.c (start_polling, bind_polling_period):
1402 Check for time stamp overflow.
1403 (read_char, kbd_buffer_get_event, timer_start_idle)
1404 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1405 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1406 Port to higher-resolution time stamps. Do not assume time_t is signed.
1407 (decode_timer): New function. Timers are now vectors of length 9,
1408 not 8, to accommodate the picosecond component.
1409 (timer_check_2): Use it.
1410
1411 * nsterm.m (select_timeout, timeval_subtract): Remove.
1412 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1413 as they're a bit more accurate and handle overflow better.
1414 (ns_select): Change prototype to be compatible with pselect.
1415 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1416 * nsterm.h (ns_select): Adjust prototype.
1417
1418 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1419 us-resolution time stamps.
1420 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1421
1422 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1423
1424 * lisp.h (time_overflow): New decl.
1425 (wait_reading_process_output): First arg is now intmax_t, not int,
1426 to accommodate larger waits.
1427
1428 * process.h (struct Lisp_Process.read_output_delay):
1429 Now counts nanoseconds, not microseconds.
1430 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1431 EMACS_HAS_USECS.
1432 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1433 (wait_reading_process_output):
1434 Port to ns-resolution time stamps.
1435 (Faccept_process_output, wait_reading_process_output):
1436 Check for time stamp overflow. Do not assume time_t is signed.
1437 (select_wrapper): Remove; we now use pselect.
1438 (Fprocess_attributes): Now generates ns-resolution time stamps.
1439
1440 * sysdep.c: Include utimens.h. Don't include utime.h
1441 or worry about struct utimbuf; gnulib does that for us now.
1442 (gettimeofday): Remove; gnulib provides a substitute.
1443 (make_timeval): New function.
1444 (set_file_times): Now sets ns-resolution time stamps.
1445 New arg FD; all uses changed.
1446 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1447 (system_process_attributes):
1448 Now returns ns-resolution time stamp. All uses changed.
1449 Check for time stamp overflow.
1450
1451 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1452 provides a substitute now.
1453
1454 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1455 since it guarantees struct timespec.
1456 (EMACS_TIME): Now struct timespec, so that we can support
1457 ns-resolution time stamps.
1458 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1459 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1460 (EMACS_USECS): Remove.
1461 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1462 so multiply the arg by 1000 before storing it.
1463 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1464 New macros.
1465 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1466 Port to ns-resolution time stamps.
1467 (EMACS_TIME_NEG_P): Remove; replaced by....
1468 (EMACS_TIME_SIGN): New macro.
1469 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1470 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1471 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1472 (make_timeval, make_lisp_time, decode_time_components): New decls.
1473 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1474 that it mishandled time_t overflow. You can't compare by subtracting!
1475 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1476 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1477
1478 * term.c: Include <sys/time.h>.
1479 (timeval_to_Time): New function, for proper overflow wraparound.
1480 (term_mouse_position, term_mouse_click): Use it.
1481
1482 * undo.c (record_first_change): Support higher-resolution time stamps
1483 in the undo buffer.
1484 (Fprimitive_undo): Use them when restoring time stamps.
1485
1486 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1487 (w32_get_internal_run_time):
1488 Port to higher-resolution Emacs time stamps.
1489 (ltime): Now accepts single 64-bit integer, as that's more convenient
1490 for callers.
1491
1492 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1493
1494 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1495 for compatibility with pselect. Support ns-resolution time stamps.
1496
1497 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1498
1499 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1500 Check for time stamp overflow, and support ns-resolution time stamps.
1501
1502 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1503 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1504 (timeval_subtract): Remove; no longer needed.
1505 (XTflash, XTring_bell, x_wait_for_event):
1506 Port to ns-resolution time stamps. Don't assume time_t is signed.
1507
b6a92dfe
CY
15082012-06-22 Chong Yidong <cyd@gnu.org>
1509
1510 * xdisp.c (x_consider_frame_title): Revert last change.
1511
d251c37c
EZ
15122012-06-22 Eli Zaretskii <eliz@gnu.org>
1513
1514 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1515 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1516 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1517 staticidx goes up to 1597 out of 1600 = 0x640.)
1518
f10deafb
PE
15192012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1520
1521 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1522 Otherwise, the umask might be mistakenly 0 while handling input signals.
1523
ec6de1e2
SM
15242012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1527
28be1ada
DA
15282012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1529
1530 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1531 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1532 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1533 access to `contents' member of Lisp_Vector objects with AREF and ASET
1534 where appropriate.
1535
c6bf3022
CY
15362012-06-19 Chong Yidong <cyd@gnu.org>
1537
1538 * frame.c (delete_frame): When selecting a frame on a different
1539 text terminal, do not alter the terminal's top-frame.
1540
1541 * xdisp.c (format_mode_line_unwind_data): Record the target
1542 frame's selected window and its terminal's top-frame.
1543 (unwind_format_mode_line): Restore them.
1544 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1545 Callers changed.
1546 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1547 since tty frames can be explicitly named.
1548 (prepare_menu_bars): Likewise.
1549
1550 * term.c (Ftty_top_frame): New function.
1551
defd4196
PE
15522012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1553
1554 Port byte-code-meter to modern targets.
1555 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1556 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1557 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1558 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1559 (METER_1, METER_2): Simplify.
1560
1053a871
SM
15612012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1562
1563 * data.c (Fdefalias): Return `symbol' (bug#11686).
1564
b7e8d081
MR
15652012-06-18 Martin Rudalics <rudalics@gmx.at>
1566
1567 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1568 gets killed during executing of this function (Bug#11665).
1569 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1570 (Vkill_buffer_query_functions): In doc-string say that functions
1571 run by this hook should not change the current buffer.
1572
7ea2b339
PE
15732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 Fix recently-introduced process.c problems found by static checking.
1576 * process.c (write_queue_push, write_queue_pop, send_process):
1577 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1578 (write_queue_pop): Fix pointer signedness problem.
1579 (send_process): Remove unused local.
1580
96a313a1
CY
15812012-06-17 Chong Yidong <cyd@gnu.org>
1582
1583 * xdisp.c (redisplay_internal): No need to redisplay terminal
1584 frames that are not on top.
1585
20ca2e94
TN
15862012-06-17 Troels Nielsen <bn.troels@gmail.com>
1587
1588 * process.c (make_process): Initialize write_queue.
1589 (write_queue_push, write_queue_pop): New functions.
1590 (send_process): Use them to maintain correct ordering of process
1591 writes (Bug#10815).
1592
9a900ca9
PE
15932012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1594
310fbfa8
PE
1595 * lisp.h (eassert): Assume C89 or later.
1596 This removes the need for CHECK.
1597 (CHECK): Remove. Its comments about always evaluating its
1598 argument were confusing, as 'eassert' typically does not evaluate
1599 its argument.
1600
27bb1ca4
PE
1601 * coding.c (produce_chars): Use ptrdiff_t, not int.
1602
9a900ca9
PE
1603 * xterm.c (x_draw_underwave): Check for integer overflow.
1604 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1605
41b7f8bc 16062012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1607
1608 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1609 referenced (Bug#11583).
1610
9b0e3eba
AA
16112012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1612
1613 Implement wave-style variant of underlining.
1614 * dispextern.h (face_underline_type): New enum.
1615 (face): Add field for underline type.
1616 * nsterm.m (ns_draw_underwave): New function.
1617 (ns_draw_text_decoration): Use it.
1618 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1619 New functions.
1620 (x_draw_glyph_string): Use them.
1621 * xfaces.c (Qline, Qwave): New Lisp objects.
1622 (check_lface_attrs, merge_face_ref)
1053a871
SM
1623 (Finternal_set_lisp_face_attribute, realize_x_face):
1624 Handle wave-style underline face attributes.
9b0e3eba
AA
1625 * xterm.c (x_draw_underwave): New function.
1626 (x_draw_glyph_string): Use it.
1627
0fb52f11
JB
16282012-06-16 Juanma Barranquero <lekktu@gmail.com>
1629
1630 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1631 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1632 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1633 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1634 ($(BLD)/w32select.$(O)): Update dependencies.
1635
e5560ff7
AS
16362012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1637
1638 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1639 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1640 * character.c (_fetch_multibyte_char_p): Remove.
1641 * alloc.c: Include "character.h" before "buffer.h".
1642 * bidi.c: Likewise.
1643 * buffer.c: Likewise.
1644 * bytecode.c: Likewise.
1645 * callint.c: Likewise.
1646 * callproc.c: Likewise.
1647 * casefiddle.c: Likewise.
1648 * casetab.c: Likewise.
1649 * category.c: Likewise.
1650 * cmds.c: Likewise.
1651 * coding.c: Likewise.
1652 * composite.c: Likewise.
1653 * dired.c: Likewise.
1654 * dispnew.c: Likewise.
1655 * doc.c: Likewise.
1656 * dosfns.c: Likewise.
1657 * editfns.c: Likewise.
1658 * emacs.c: Likewise.
1659 * fileio.c: Likewise.
1660 * filelock.c: Likewise.
1661 * font.c: Likewise.
1662 * fontset.c: Likewise.
1663 * fringe.c: Likewise.
1664 * indent.c: Likewise.
1665 * insdel.c: Likewise.
1666 * intervals.c: Likewise.
1667 * keyboard.c: Likewise.
1668 * keymap.c: Likewise.
1669 * lread.c: Likewise.
1670 * macros.c: Likewise.
1671 * marker.c: Likewise.
1672 * minibuf.c: Likewise.
1673 * nsfns.m: Likewise.
1674 * nsmenu.m: Likewise.
1675 * print.c: Likewise.
1676 * process.c: Likewise.
1677 * regex.c: Likewise.
1678 * region-cache.c: Likewise.
1679 * search.c: Likewise.
1680 * syntax.c: Likewise.
1681 * term.c: Likewise.
1682 * textprop.c: Likewise.
1683 * undo.c: Likewise.
1684 * unexsol.c: Likewise.
1685 * w16select.c: Likewise.
1686 * w32fns.c: Likewise.
1687 * w32menu.c: Likewise.
1688 * window.c: Likewise.
1689 * xdisp.c: Likewise.
1690 * xfns.c: Likewise.
1691 * xmenu.c: Likewise.
1692 * xml.c: Likewise.
1693 * xselect.c: Likewise.
1694
2f07e6af
EZ
16952012-06-16 Eli Zaretskii <eliz@gnu.org>
1696
1053a871
SM
1697 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1698 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1699 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1700 row.
1701 (handle_face_prop): Use chunk-relative overlay string index when
1702 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1703 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1704 the rightmost. (Bug#11720)
2f07e6af 1705
29b83cec
AS
17062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1709 (CATEGORY_MEMBER): Enforce 1/0 value.
1710 * category.c (_temp_category_set): Remove.
1711
4c5501e9
EZ
17122012-06-16 Eli Zaretskii <eliz@gnu.org>
1713
1714 * window.c (Fdelete_other_windows_internal)
1715 (Fdelete_window_internal): Don't access frame's mouse highlight
1716 info of the initial frame. (Bug#11677)
1717
2b570124
PE
17182012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1719
e93864f9
PE
1720 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1721 Assume USE_2_TAGS_FOR_INTS.
1722 (xreload): Adjust $tagmask width to match recent lisp.h change.
1723
2b570124
PE
1724 Simplify lisp.h in minor ways that should not affect code.
1725 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1726 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1727 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1728 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1729 (INTTYPEBITS): New macro, for clarity.
1730 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1731 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1732 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1733 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1734 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1735
81755f69
JB
17362012-06-13 Juanma Barranquero <lekktu@gmail.com>
1737
1738 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1739
16192a57
GM
17402012-06-13 Glenn Morris <rgm@gnu.org>
1741
1742 * s/bsd-common.h (BSD4_3):
1743 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1744
646b5f55
AS
17452012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1746
1747 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1748 instead of union.
1749 (XLI, XIL): Define.
1053a871
SM
1750 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1751 Use them.
1752 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1753 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1754 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1755 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1756 * frame.c (delete_frame): Remove outdated comment.
1757 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1758 USE_LISP_UNION_TYPE.
1759 (Fw32_unregister_hot_key): Likewise.
1760 (Fw32_toggle_lock_key): Likewise.
1761 * w32menu.c (add_menu_item): Likewise.
1762 (w32_menu_display_help): Use XIL instead of checking
1763 USE_LISP_UNION_TYPE.
1764 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1765 (init_heap): Likewise.
1766 * w32term.c (w32_read_socket): Update comment.
1767
1d3823c9
GM
17682012-06-13 Glenn Morris <rgm@gnu.org>
1769
c62ff706
GM
1770 * s/usg5-4-common.h, src/s/unixware.h:
1771 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1772
1d3823c9
GM
1773 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1774
bfe3e0a2
PE
17752012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1776
1777 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1778 * alloc.c (make_number) [!defined make_number]:
1779 Remove, as lisp.h always defines this now.
1780 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1781 (roundup_size): Verify that it is a power of 2.
1782 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1783 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1784 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1785 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1786 USE_LSB_TAG now is always defined to be either 0 or 1.
1787 All uses changed.
1788 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1789 code works fine either way, and efficiency is not a concern here,
1790 as the union type is for debugging, not for production.
1791 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1792 Use an inline function on all platforms when using the union type,
1793 since this is simpler and 'static inline' can be used portably
1794 within Emacs now.
1795 (LISP_INITIALLY_ZERO): New macro.
1796 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1797 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1798
45fa9c0f
GM
17992012-06-12 Glenn Morris <rgm@gnu.org>
1800
b4492cba
GM
1801 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1802
1803 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1804
45fa9c0f
GM
1805 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1806 Move BROKEN_SIGIO to configure.
1807
1808 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1809 Move NO_TERMIO to configure.
1810
0e25d334
CY
18112012-06-12 Chong Yidong <cyd@gnu.org>
1812
1813 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1814 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1815 MagickExportImagePixels is undefined.
1816
43682bb6
PE
18172012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1818
1819 * image.c (imagemagick_load_image): Remove unused label.
1820
a9be7d2b
GM
18212012-06-11 Glenn Morris <rgm@gnu.org>
1822
1823 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1824 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1825 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1826 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1827
3017f87f
SM
18282012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1829
1830 * alloc.c (make_byte_code): New function.
1831 (Fmake_byte_code): Use it. Don't purify here.
1832 * lread.c (read1): Use it as well to avoid extra allocation.
1833
1b9b4cf4
CY
18342012-06-11 Chong Yidong <cyd@gnu.org>
1835
1836 * image.c (imagemagick_load_image): Implement transparency.
1837
95988fcf
AS
18382012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1839
1840 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1841 account for preceding backslashes. (Bug#11663)
1842
cd4eb164
CY
18432012-06-09 Chong Yidong <cyd@gnu.org>
1844
1845 * term.c: Support italics in capable terminals (Bug#9652).
1846 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1847 (turn_on_face): Output using TS_enter_italic_mode if available.
1848 Don't handle unused blinking and alt-charset cases.
1849 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1850 and tty_alt_charset_p cases.
1851 (tty_capable_p, init_tty): Support italics.
1852
1853 * termchar.h (struct tty_display_info): Add field for italics.
1854 Remove unused blink field.
1855
1856 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1857 Handle slant.
1858
1859 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1860 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1861 tty_alt_charset_p. Add tty_italic_p.
1862
ff88beb8
MA
18632012-06-09 Michael Albinus <michael.albinus@gmx.de>
1864
1865 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1866 dbus_type_is_basic if available.
1867 (xd_extract_signed, xd_extract_unsigned): Rename from
1868 extract_signed and extract_unsigned, respectively. Adapt callers.
1869
44286096
CY
18702012-06-09 Chong Yidong <cyd@gnu.org>
1871
1682701f
CY
1872 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1873
44286096
CY
1874 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1875 case (Bug#9752).
1876
d86feb17
PE
18772012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 * xdisp.c (vmessage): Treat frame message as multibyte.
1880 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1881 would generate the diagnostic "Making \302\247 buffer-local while
1882 let-bound!".
1883
d5c20fe8
EZ
18842012-06-08 Eli Zaretskii <eliz@gnu.org>
1885
1886 * dispnew.c (showing_window_margins_p): Undo last change, which
1887 was done due to an inadvertent commit.
1888 (adjust_frame_glyphs_for_frame_redisplay): Do call
1889 showing_window_margins_p.
1890
513749ee
SM
18912012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1892
1893 * eval.c (Fmake_var_non_special): New primitive.
1894 (syms_of_eval): Defsubr it.
1895 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1896
d4a8f5c1
JB
18972012-06-08 Juanma Barranquero <lekktu@gmail.com>
1898
1899 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1900 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1901
8bbbc977
EZ
19022012-06-08 Eli Zaretskii <eliz@gnu.org>
1903
1904 * alloc.c (allocate_vectorlike): Fix last change.
1905
f3372c87
DA
19062012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 Block-based vector allocation of small vectors.
1909 * lisp.h (struct vectorlike_header): New field `nbytes',
1910 adjust comment accordingly.
1911 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1912 to denote vector blocks. Adjust users (live_vector_p,
1913 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1914 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1915 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1916 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1917 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1918 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1919 (roundup_size): New constant.
1920 (struct vector_block): New data type.
1921 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1922 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1923 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1924 (sweep_vectors): New functions.
1925 (allocate_vectorlike): Return `zero_vector' as the only vector of
1926 0 items. Allocate new vector from block if vector size is less than
1927 or equal to VBLOCK_BYTES_MAX.
1928 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1929 (init_alloc_once): Add call to init_vectors.
1930
4f18a4ed
SM
19312012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1932
1933 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1934
86f158bc
PE
19352012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1936
1937 * doprnt.c (doprnt): Truncate multibyte char correctly.
1938 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1939 would mishandle a string argument "Xc" if X was a multibyte
1940 character of length 2: it would truncate after X's first byte
1941 rather than including all of X.
1942
c5cfcbe0
CY
19432012-06-06 Chong Yidong <cyd@gnu.org>
1944
1945 * buffer.c (word_wrap): Doc fix.
1946
c05cf390
PE
19472012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1950
0c3461de
GM
19512012-06-03 Glenn Morris <rgm@gnu.org>
1952
1953 * xdisp.c (tool-bar-style): Doc fix.
1954
c71232db
UM
19552012-06-03 Ulrich Müller <ulm@gentoo.org>
1956
1957 * Makefile.in (PAXCTL): Define.
1958 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1959 binary via PaX flags if the paxctl utility is available.
1960 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1961 Restore PaX flags to their default. (Bug#11398)
1962
383f7350
CY
19632012-06-03 Chong Yidong <cyd@gnu.org>
1964
1965 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1966 buffer (Bug#11226).
1967
5f2c76c6
CY
19682012-06-03 Chong Yidong <cyd@gnu.org>
1969
1970 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1971 (note_mode_line_or_margin_highlight): If there is no help echo,
1972 use mode-line-default-help-echo. Handle the case where the mouse
1973 position is past the end of the mode line string.
1974
1975 * buffer.c (buffer_local_value_1): New function, split from
1976 Fbuffer_local_value; can return Qunbound.
1977 (Fbuffer_local_value): Use it.
1978 (Vmode_line_format): Docstring tweaks.
1979
773d47f6
PE
19802012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1981
1982 * sysdep.c (system_process_attributes): Improve comment.
1983
f2d6a3df
SM
19842012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1985
1986 * keyboard.c: Export real-this-command to Elisp.
1987 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1988 and DEFVAR it. Update all users.
1989
63810350
PE
19902012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1991
7bd5c1f4
PE
1992 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1993
63810350
PE
1994 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1995 Convert pctcpu and pctmem to Lisp float properly.
1996 Let the compiler fold better, as 100.0/0x8000 is exact.
1997
a2821611
AS
19982012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1999
2000 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2001 cons_block.
2002
5fceba1d
PE
20032012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2004
2005 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2006
c98ff5dd
DA
20072012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2008
2009 For a 'struct window', replace some Lisp_Object fields to
2010 bitfields where appropriate, remove unused fields.
2011 * window.h (struct window): Remove unused 'last_mark_x' and
2012 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2013 change it's type from Lisp_Object to bitfield.
2014 Change type of 'force_start', 'optional_new_start',
2015 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2016 fields from Lisp_Object to bitfield. Adjust users accordingly.
2017
ca34e0be
PE
20182012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2019
2020 Pacify gcc -Wdouble-precision when using Xaw.
2021 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2022 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2023 Use 'float' consistently, rather than 'float' in most places
2024 and 'double' in a couple of places.
2025
efc00ab1 20262012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2027
2028 * xdisp.c (handle_stop): Detect whether we have overlay strings
2029 loaded by testing it->current.overlay_string_index to be
2030 non-negative, instead of checking whether n_overlay_strings is
2031 positive. (Bug#11587)
2032
efc00ab1 20332012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2034
2035 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2036
2037 * doc.c (Fsubstitute_command_keys): Doc fix.
2038
efc00ab1 20392012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2040
2041 * search.c (search_buffer): Remove calls to
2042 r_alloc_inhibit_buffer_relocation, as it is now called by
2043 maybe_unify_char, which was the cause of relocation of buffer text
2044 in bug#11519.
2045
efc00ab1 20462012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2047
2048 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2049 for the duration of call to load_charset, to avoid problems with
2050 callers of maybe_unify_char that access buffer text through C
2051 pointers.
2052
2053 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2054 decrement the inhibition flag, instead of just setting or
2055 resetting it.
2056
ba93a187
PE
20572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2058
2059 Remove obsolete '#define static' cruft.
2060 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2061 This #undef was "temporary" in 2000; it is no longer needed
2062 now that '#define static' has gone away.
2063 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2064 (gray_bitmap_bits): Remove; no longer needed.
2065 All uses replaced with definiens.
2066 * xterm.c: Include "bitmaps/gray.xbm".
2067
9e4bf381
PE
20682012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2069
2070 Clean up __executable_start, monstartup when --enable-profiling.
2071 The following changes affect the code only when profiling.
2072 * dispnew.c (__executable_start): Rename from safe_bcopy.
2073 Define only on platforms that need it.
2074 * emacs.c: Include <sys/gmon.h> when profiling.
2075 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2076 (__executable_start): Remove decl, since lisp.h does it now.
2077 (safe_bcopy): Remove decl; no longer has that name.
2078 (main): Coalesce #if into single bit of code, for simplicity.
2079 Cast pointers to uintptr_t, since standard libraries want integers
2080 and not pointers.
2081 * lisp.h (__executable_start): New decl.
2082
32d72c2f
GM
20832012-05-31 Glenn Morris <rgm@gnu.org>
2084
2085 * image.c (Fimagemagick_types): Doc fix.
2086
baac5bc7
JM
20872012-05-30 Jim Meyering <meyering@redhat.com>
2088
2089 * callproc.c (Fcall_process_region): Include directory component
2090 in mkstemp error message (Bug#11586).
2091
72cb32cf
PE
20922012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2093
2094 * alloc.c, lisp.h (make_pure_vector): Now static.
2095
61b108cc
SM
20962012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2097
2098 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2099 Move to byte-run.el.
2100 (Fautoload): Do the hash-doc more carefully.
2101 * data.c (Fdefalias): Purify definition, except for keymaps.
2102 (Qdefun): Move from eval.c.
2103 * lisp.h (Qdefun): Remove.
2104 * lread.c (read1): Tiny simplification.
2105
471fe23d
TN
21062012-05-29 Troels Nielsen <bn.troels@gmail.com>
2107
934f3f58 2108 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2109 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2110 Bug#9642, but explicitly check that the buffer the overlay would
2111 be moved to is live and rearrange lines to make sure that errors
2112 will not put the overlay in an inconsistent state.
2113 (Fdelete_overlay): Cosmetics.
2114
85d0efd1
EZ
21152012-05-28 Eli Zaretskii <eliz@gnu.org>
2116
2117 * w32term.c (my_bring_window_to_top): New function.
2118 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2119 could be different from the original one.
2120 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2121 (Bug#11513)
2122
2123 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2124 by calling BringWindowToTop.
2125
2126 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2127 (WM_EMACS_END): Increase by one.
2128
da92a98c
PE
21292012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2130
2131 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2132 This avoids undefined behavior that might cause the eassert
2133 to not catch an out-of-range value.
2134
74d1f848
JB
21352012-05-28 Juanma Barranquero <lekktu@gmail.com>
2136
2137 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2138 Update dependencies.
2139
9e1a06fc
EZ
21402012-05-27 Eli Zaretskii <eliz@gnu.org>
2141
2142 * bidi.c (bidi_mirror_char): Fix last change.
2143
f3dd7312
AS
21442012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2145
2146 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2147 when referring to sectname field in printf format.
2148
81899c91
PE
21492012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2150
57b81a9f
PE
2151 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2152 Only r_alloc_inhibit_buffer_relocation needed to be added;
2153 the others were already declared.
2154
81899c91
PE
2155 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2156 before checking whether it's out of range. Put the check inside
2157 eassert. See
2158 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2159
33017faf 21602012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2161
2162 * callproc.c (Fcall_process): Restore a line that was accidentally
2163 commented out in the 2011-02-13 change (bug#11547).
2164
33017faf 21652012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2166
2167 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2168 defined on ralloc.c.
2169
2170 * buffer.c [REL_ALLOC]: Remove prototypes of
2171 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2172 they are now on lisp.h.
2173
2174 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2175
2176 * search.c (search_buffer): Use it to inhibit relocation of buffer
2177 text while re_search_2 is doing its job, because re_search_2 is
2178 passed C pointers to buffer text. (Bug#11519)
2179
23415acf
EZ
2180 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2181 Update value to 24.
2182
44e27368
EZ
2183 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2184 state after an additional call to move_it_in_display_line_to, keep
2185 the values of it->max_ascent and it->max_descent found for the
2186 entire line.
2187 (pos_visible_p): Revert the comparison against bottom_y to what it
2188 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2189 (Bug#11464)
2190
c1892f11
PE
21912012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2192
2193 Fix coding-related core dumps with gcc -ftrapv.
2194 The code was computing A - B, where A and B are pointers, and B is
2195 random garbage. This can lead to core dumps on platforms that
2196 have special pointer registers, and it also leads to core dumps on
2197 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2198 A - B only when B is initialized properly.
2199 * coding.c (coding_set_source, coding_set_destination): Return void.
2200 (coding_change_source, coding_change_destinations): New functions,
2201 with the old behaviors of coding_set_source and coding_set_destination.
2202 All callers that need an offset changed to use these new functions.
2203
eb7afdad
GM
22042012-05-26 Glenn Morris <rgm@gnu.org>
2205
2206 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2207
f12fdf02
EZ
22082012-05-26 Eli Zaretskii <eliz@gnu.org>
2209
53a63be6 2210 Extend mouse support on W32 text-mode console.
61b108cc
SM
2211 * xdisp.c (draw_row_with_mouse_face):
2212 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2213
eb3f6f01 2214 * w32console.c: Include window.h.
61b108cc
SM
2215 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2216 New functions.
eb3f6f01
EZ
2217 (initialize_w32_display): Initialize mouse-highlight data.
2218
53a63be6
EZ
2219 * w32inevt.c: Include termchar.h and window.h.
2220 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2221 moves, call note_mouse_highlight. If help_echo changed, call
2222 gen_help_event to produce help-echo message in the echo area.
2223 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2224 highlight info.
2225
4cfd81f6
PE
22262012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 * lread.c (read1): Simplify slightly to avoid an overflow warning
2229 with GCC 4.7.0 on x86-64.
2230
4446092a
EZ
22312012-05-26 Eli Zaretskii <eliz@gnu.org>
2232
2233 * bidi.c (bidi_mirror_char): Revert last change: an int is
2234 definitely wide enough here.
2235
42b2a986 22362012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2237
42b2a986 2238 Fix integer width and related bugs (Bug#9874).
eb106a49 2239 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2240 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2241 (string_bytes, check_sblock, allocate_string_data):
2242 (compact_small_strings, Fmake_bool_vector, make_string)
2243 (make_unibyte_string, make_multibyte_string)
2244 (make_string_from_bytes, make_specified_string)
2245 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2246 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2247 (mark_vectorlike):
2248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2249 (allocate_pseudovector):
2250 Use int, not EMACS_INT, where int is wide enough.
2251 (inhibit_garbage_collection, Fgarbage_collect):
2252 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2253 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2254 int might not be wide enough.
2255 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2256 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2257 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2258 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2259 (bidi_level_of_next_char, bidi_move_to_visually_next):
2260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2261 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2262 (Fkill_buffer, Fset_buffer_major_mode)
2263 (advance_to_char_boundary, Fbuffer_swap_text)
2264 (Fset_buffer_multibyte, overlays_at, overlays_in)
2265 (overlay_touches_p, struct sortvec, record_overlay_string)
2266 (overlay_strings, recenter_overlay_lists)
2267 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2268 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2269 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2270 (Foverlay_recenter, last_overlay_modification_hooks_used)
2271 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2273 (validate_region): Omit unnecessary test for b <= e,
2274 since that's guaranteed by the previous test.
d311d28c
PE
2275 (adjust_overlays_for_delete): Avoid pos + length overflow.
2276 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2277 (report_overlay_modification):
2278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2279 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2280 Omit pointer cast, which isn't needed anyway, and doesn't work
2281 after the EMACS_INT -> ptrdiff_t change.
02481186 2282 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2283 * buffer.h: Adjust decls to match defn changes elsewhere.
2284 (struct buffer_text, struct buffer):
2285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2286 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2287 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2288 not int, to avoid needless 32-bit limit on 64-bit hosts.
2289 (exec_byte_code): Use tighter memory-full test, one that checks
2290 for alloca overflow. Don't compute the address of the object just
2291 before an array, as that's not portable. Use EMACS_INT, not
2292 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2293 * callint.c (Fcall_interactively):
2294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2295 * callproc.c (call_process_kill, Fcall_process):
2296 Don't assume pid_t fits into an Emacs fixnum.
2297 (call_process_cleanup, Fcall_process, child_setup):
2298 Don't assume pid_t fits into int.
2299 (call_process_cleanup, Fcall_process, delete_temp_file)
2300 (Fcall_process_region):
2301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2302 (Fcall_process): Simplify handling of volatile integers.
2303 Use int, not EMACS_INT, where int will do.
2304 * casefiddle.c (casify_object, casify_region, operate_on_word)
2305 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2307 (casify_object): Avoid integer overflow when overallocating buffer.
2308 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2309 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2310 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2311 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2312 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2313 integers are now checked earlier. All uses replaced with XINT.
2314 (ccl_driver):
2315 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2316 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2317 (ccl_driver, Fregister_code_conversion_map):
2318 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2319 (resolve_symbol_ccl_program): Check that vector header is in range.
2320 Always copy the vector, so that we can check its contents reliably
2321 now rather than having to recheck each instruction as it's being
2322 executed. Check that vector words fit in 'int'.
2323 (ccl_get_compiled_code, Fregister_ccl_program)
2324 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2325 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2326 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2327 contents are in range.
2328 (Fccl_execute_on_string): Check that status is in range.
2329 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2330 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2331 Accept and return EMACS_INT, not int, because callers can pass values
2332 out of 'int' range.
2333 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2334 (multibyte_chars_in_text, parse_str_as_multibyte)
2335 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2336 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2337 (string_escape_byte8, Fget_byte):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2339 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2340 avoid mishandling large integers.
2341 * character.h: Adjust decls to match defn changes elsewhere.
2342 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2343 (Ffind_charset_region):
2344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2345 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2346 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2347 Don't assume fixnum fits in int.
d311d28c
PE
2348 (load_charset_map_from_vector, Fmap_charset_chars):
2349 Remove now-unnecessary CHECK_NATNUMs.
2350 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2351 Don't rely on undefined behavior with signed left shift overflow.
2352 Don't assume unsigned int fits into fixnum, or that fixnum fits
2353 into unsigned int. Don't require max_code to be a valid fixnum;
2354 that's not true for gb10830 4-byte on a 32-bit host. Allow
2355 invalid_code to be a cons, for the same reason. Require code_offset
2356 to be a character. Avoid int overflow if max_char is close
2357 to INT_MAX.
2358 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2359 this is intended anyway and avoids some undefined behavior.
2360 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2361 INDEX_TO_CODE_POINT, as that's what it expects.
2362 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2363 * charset.h (DECODE_CHAR): Return int, not unsigned;
2364 this is what was intended anyway, and it avoids undefined behavior.
2365 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2366 integer-overflow issues.
2367 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2368 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2369 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2370 * chartab.c (Fmake_char_table, Fset_char_table_range)
2371 (uniprop_get_decoder, uniprop_get_encoder):
2372 Don't assume fixnum fits in int.
2373 * cmds.c (move_point): New function, that does the gist of
2374 Fforward_char and Fbackward_char, but does so while checking
2375 for integer overflow more accurately.
c96e5d6a 2376 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2377 (Fforward_line, Fend_of_line, internal_self_insert)
2378 (internal_self_insert):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 Fix a FIXME, by checking for integer overflow when calculating
2381 target_clm and actual_clm.
2382 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2383 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2384 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2385 (coding_alloc_by_making_gap, alloc_destination)
2386 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2387 (encode_coding_utf_16, detect_coding_emacs_mule)
2388 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2389 (detect_coding_iso_2022, decode_coding_iso_2022)
2390 (encode_invocation_designation, encode_designation_at_bol)
2391 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2392 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2393 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2394 (encode_coding_ccl, encode_coding_raw_text)
2395 (detect_coding_charset, decode_coding_charset)
2396 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2397 (produce_composition, produce_charset, produce_annotation)
2398 (decode_coding, handle_composition_annotation)
2399 (handle_charset_annotation, consume_chars, decode_coding_gap)
2400 (decode_coding_object, encode_coding_object, detect_coding_system)
2401 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2402 (code_convert_region, code_convert_string)
8f50130c
PE
2403 (Fdefine_coding_system_internal)
2404 (coding_set_source, coding_set_destination):
d311d28c
PE
2405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2406 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2407 (Fdefine_coding_system_internal):
2408 Don't assume fixnums fit in int.
2409 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2410 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2411 (Funencodable_char_position, Fcheck_coding_systems_region)
2412 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2414 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2415 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2416 Don't access memory outside of the args array.
d311d28c 2417 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2418 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2419 result of ENCODE_CHAR.
d311d28c
PE
2420 * coding.h: Adjust decls to match defn changes elsewhere.
2421 (struct coding_system):
2422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2423 * composite.c (get_composition_id, find_composition)
2424 (run_composition_function, update_compositions)
2425 (compose_text, composition_gstring_put_cache)
2426 (composition_gstring_p, composition_gstring_width)
2427 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2428 (composition_compute_stop_pos, composition_reseat_it)
2429 (composition_update_it, struct position_record)
2430 (find_automatic_composition, composition_adjust_point)
2431 (Fcomposition_get_gstring, Ffind_composition_internal):
2432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2433 (update_compositions):
2434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2435 * composite.h: Adjust decls to match defn changes elsewhere.
2436 (struct composition):
2437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2438 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2439 Do not attempt to compute the address of the object just before a
2440 buffer; this is not portable.
2441 (Faref, Faset):
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2443 (Faset): Use int, not EMACS_INT, where int is wide enough.
2444 (Fstring_to_number): Don't assume fixnums fit in int.
2445 (Frem): Don't assume arg is nonnegative.
2446 * dbusbind.c (xd_append_arg): Check for integers out of range.
2447 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2448 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2449 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2450 (xd_get_connection_references): Return ptrdiff_t, not int.
2451 All uses changed.
2452 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2453 (xd_read_message_1):
2454 Use int, not unsigned, where the dbus API uses int.
2455 (Fdbus_message_internal): Don't overflow mtype.
2456 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2457 * dired.c (directory_files_internal, file_name_completion, scmp)
2458 (file_name_completion_stat):
2459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2460 (file_name_completion): Don't overflow matchcount.
2461 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2462 * dispextern.h: Adjust decls to match defn changes elsewhere.
2463 (struct text_pos, struct glyph, struct bidi_saved_info)
2464 (struct bidi_string_data, struct bidi_it, struct composition_it)
2465 (struct it):
2466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2467 (struct display_pos, struct composition_it, struct it):
2468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2469 * dispnew.c (increment_matrix_positions)
2470 (increment_row_positions, mode_line_string)
2471 (marginal_area_string):
2472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2473 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2474 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2475 (duration_to_sec_usec): New function, to check for overflow better.
2476 (Fsleep_for, sit_for): Use it.
2477 * doc.c (get_doc_string, store_function_docstring):
2478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2479 (get_doc_string, Fsnarf_documentation):
2480 Use int, not EMACS_INT, where int is wide enough.
2481 (get_doc_string):
2482 Use SAFE_ALLOCA, not alloca.
2483 Check for overflow when converting EMACS_INT to off_t.
2484 * doprnt.c (doprnt):
2485 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2486 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2487 Don't assume uid_t fits into fixnum.
2488 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2489 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2490 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2491 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2492 (general_insert_function)
2493 (Finsert_char, make_buffer_string, make_buffer_string_both)
2494 (update_buffer_properties, Fbuffer_substring)
2495 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2496 (Fsubst_char_in_region, check_translation)
2497 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2498 (transpose_markers, Ftranspose_regions):
2499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2500 (clip_to_bounds): Move to lisp.h as an inline function).
2501 (Fconstrain_to_field): Don't assume integers are nonnegative.
2502 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2503 (Fsubst_char_in_region, Fsave_restriction):
2504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2505 (Femacs_pid): Don't assume pid_t fits into fixnum.
2506 (lo_time): Use int, not EMACS_INT, when int suffices.
2507 (lisp_time_argument): Check for usec out of range.
2508 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2509 (Fuser_login_name, Fuser_full_name): Signal an error
2510 if a uid argument is out of range, rather than relying on
2511 undefined behavior.
c8d5c857
PE
2512 (Fformat_time_string): Remove now-unnecessary check.
2513 lisp_time_argument checks for out-of-range usec now.
243e0530 2514 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2515 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2516 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2517 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2518 (init_cmdargs, Fdump_emacs):
2519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2520 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2521 the bottom (typically) 32 bits of the fixnum.
2522 * eval.c (specpdl_size, call_debugger):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 (when_entered_debugger, Fbacktrace_debug):
2525 Don't assume fixnum can fit in int.
2526 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2527 the object just before a buffer; this is not portable.
2528 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2529 (grow_specpdl, unbind_to):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2532 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2533 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2534 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2535 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2537 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2538 (a_write, e_write):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 (Fcopy_file, non_regular_nbytes, read_non_regular)
2541 (Finsert_file_contents):
2542 Use int, not EMACS_INT, where int is wide enough.
2543 (READ_BUF_SIZE): Verify that it fits in int.
2544 (Finsert_file_contents): Check that counts are in proper range,
2545 rather than assuming fixnums fit into ptrdiff_t etc.
2546 Don't assume fixnums fit into int.
125b3835 2547 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2548 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2549 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2550 (string_char_to_byte, string_byte_to_char)
2551 (string_make_multibyte, string_to_multibyte)
2552 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2553 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2554 (substring_both, Fdelete, internal_equal, Ffillarray)
2555 (Fclear_string, mapcar1)
2556 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2557 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2558 (larger_vector, make_hash_table, maybe_resize_hash_table)
2559 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2560 (Fmaphash, secure_hash):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 (concat): Check for string index and length overflow.
2563 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2564 (Frequire):
2565 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2566 (larger_vector): New API (vec, incr_min, size_max) replaces old
2567 one (vec, new_size, init). This catches size overflow.
2568 INIT was removed because it was always Qnil.
2569 All callers changed.
2570 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2571 the upper bound on a hash table index size.
2572 (make_hash_table, maybe_resize_hash_table): Use it.
2573 (secure_hash): Computer start_byte and end_byte only after
2574 they're known to be in ptrdiff_t range.
2575 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2576 (Ffont_get_glyphs, Ffont_at):
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2579 (Flist_fonts, Fopen_font):
2580 Don't assume fixnum can fit in int.
2581 (check_gstring): Don't assume index can fit in int.
2582 (font_match_p): Check that fixnum is a character, not a nonnegative
2583 fixnum, since the later code needs to stuff it into an int.
2584 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2585 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2586 conversion overflow issues.
2587 (Fopen_font): Check for integer out of range.
2588 (Ffont_get_glyphs): Don't assume index can fit in int.
2589 * font.h: Adjust decls to match defn changes elsewhere.
2590 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2591 integer overflow.
2592 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2593 printmax_t, where ptrdiff_t is wide enough.
2594 (Finternal_char_font):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2597 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2598 (Fset_frame_position, x_set_frame_parameters)
2599 (x_set_line_spacing, x_set_border_width)
2600 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2601 Check that fixnums are in proper range for system types.
2602 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2604 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2605 Use SAFE_ALLOCA_LISP, not alloca.
2606 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2607 intptr_t is wide enough.
2608 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2609 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2610 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2611 Check for fixnum out of range.
2612 * ftfont.c (ftfont_list): Don't assume index fits in int.
2613 Check that fixnums are in proper range for system types.
2614 (ftfont_shape_by_flt):
2615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2616 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2618 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2619 Check that fixnums are in proper range for system types.
2620 * gnutls.h: Adjust decls to match defn changes elsewhere.
2621 * gtkutil.c (xg_dialog_run):
2622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2623 (update_frame_tool_bar):
2624 Check that fixnums are in proper range for system types.
2625 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2626 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2627 * indent.c (last_known_column, last_known_column_point):
2628 (current_column_bol_cache):
2629 (skip_invisible, current_column, check_display_width):
2630 (check_display_width, scan_for_column, current_column_1)
2631 (Findent_to, Fcurrent_indentation, position_indentation)
2632 (indented_beyond_p, Fmove_to_column, compute_motion):
2633 (Fcompute_motion, Fvertical_motion):
2634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2635 (last_known_column_modified): Use EMACS_INT, not int.
2636 (check_display_width):
2637 (Fcompute_motion):
2638 Check that fixnums and floats are in proper range for system types.
2639 (compute_motion): Don't assume index or fixnum fits in int.
2640 (compute_motion, Fcompute_motion):
2641 Use int, not EMACS_INT, when it is wide enough.
2642 (vmotion): Omit local var start_hpos that is always 0; that way
2643 we don't need to worry about overflow in expressions involving it.
2644 * indent.h: Adjust decls to match defn changes elsewhere.
2645 (struct position):
2646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2647 Use int, not EMACS_INT, where int is wide enough.
2648 Remove unused members ovstring_chars_done and tab_offset;
2649 all uses removed.
2650 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2651 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2652 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2653 (make_gap, copy_text, insert, insert_and_inherit)
2654 (insert_before_markers, insert_before_markers_and_inherit)
2655 (insert_1, count_combining_before, count_combining_after)
2656 (insert_1_both, insert_from_string)
2657 (insert_from_string_before_markers, insert_from_string_1)
2658 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2659 (adjust_after_replace, adjust_after_insert, replace_range)
2660 (replace_range_2, del_range, del_range_1, del_range_byte)
2661 (del_range_both, del_range_2, modify_region)
2662 (prepare_to_modify_buffer, signal_before_change)
2663 (signal_after_change, Fcombine_after_change_execute):
2664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2665 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2666 (balance_an_interval, split_interval_right, split_interval_left)
2667 (find_interval, next_interval, update_interval)
2668 (adjust_intervals_for_insertion, delete_node, delete_interval)
2669 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2670 (static_offset_intervals, offset_intervals)
2671 (merge_interval_right, merge_interval_left, make_new_interval)
2672 (graft_intervals_into_buffer, temp_set_point_both)
2673 (temp_set_point, set_point, adjust_for_invis_intang)
2674 (set_point_both, move_if_not_intangible, get_property_and_range)
2675 (get_local_map, copy_intervals, copy_intervals_to_string)
2676 (compare_string_intervals, set_intervals_multibyte_1):
2677 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2678 * intervals.h: Adjust decls to match defn changes elsewhere.
2679 (struct interval):
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 * keyboard.c (this_command_key_count, this_single_command_key_start)
2682 (before_command_key_count, before_command_echo_length, echo_now)
2683 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2684 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2685 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2686 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2688 (last_non_minibuf_size, last_point_position, echo_truncate)
2689 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2690 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2691 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2692 (stuff_buffered_input):
2693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2694 (last_auto_save, command_loop_1, read_char):
2695 Use EMACS_INT, not int, to avoid integer overflow.
2696 (record_char): Avoid overflow in total_keys computation.
2697 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2698 * keyboard.h: Adjust decls to match defn changes elsewhere.
2699 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2700 (Fkey_description, Fdescribe_vector, Flookup_key):
2701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2702 (click_position): New function, to check that positions are in range.
2703 (Fcurrent_active_maps):
2704 (describe_command):
2705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2706 (Faccessible_keymaps, Fkey_description):
2707 (preferred_sequence_p):
2708 Don't assume fixnum can fit into int.
2709 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2710 Check for integer overflow in size calculations.
2711 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2712 avoid mishandling large integers.
2713 * lisp.h: Adjust decls to match defn changes elsewhere.
2714 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2715 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2716 (struct Lisp_Marker):
2717 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2718 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2719 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2720 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2721 All callers changed.
2722 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2723 Assume the arg has valid form, since it always does.
2724 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2725 unsigned integer system type.
2726 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2727 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2729 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2730 (duration_to_sec_usec): New decl.
2731 * lread.c (read_from_string_index, read_from_string_index_byte)
2732 (read_from_string_limit, readchar, unreadchar, openp)
2733 (read_internal_start, read1, oblookup):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (Fload, readevalloop, Feval_buffer, Feval_region):
2736 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2737 (openp): Check for out-of-range argument to 'access'.
2738 (read1): Use int, not EMACS_INT, where int is wide enough.
2739 Don't assume fixnum fits into int.
6efdadfd 2740 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2741 (read_filtered_event): Use duration_to_sec_usec
2742 to do proper overflow checking on durations.
d311d28c
PE
2743 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2744 in size calculation.
2745 (Fexecute_kbd_macro):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2748 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2749 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2750 (set_marker_both, set_marker_restricted_both, marker_position)
2751 (marker_byte_position, Fbuffer_has_markers_at):
2752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2753 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2754 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2755 It now merely ensures that the menu is large enough, without
2756 necessarily growing it, as this avoids some integer overflow issues.
2757 All callers changed.
2758 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2760 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2761 Use SAFE_ALLOCA_LISP, not alloca.
2762 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2763 to EMACS_INT. Check that fixnums are in proper range for system types.
2764 * minibuf.c (minibuf_prompt_width, string_to_object)
2765 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2766 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2767 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2768 (get_minibuffer, read_minibuf_unwind):
2769 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2770 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2771 this simplifies overflow checking. All callers changed.
2772 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2773 (Ftest_completion):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2776 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2777 Check that fixnums are in proper range for system types.
2778 (Fx_create_frame, Fx_show_tip):
2779 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2780 * nsfont.m (ns_findfonts, nsfont_list_family):
2781 Don't assume fixnum fits in long.
2782 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2785 wide enough.
17fdb222 2786 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2787 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2788 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2789 (PRINTDECLARE, PRINTPREPARE):
2790 (strout, print_string):
2791 (print, print_preprocess, print_check_string_charset_prop)
2792 (print_object):
2793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2794 (PRINTDECLARE):
2795 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2796 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2797 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2798 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2799 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2800 (print_error_message): Use SAFE_ALLOCA, not alloca.
2801 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2802 (print_depth, new_backquote_output, print_number_index):
2803 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2804 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2805 (Fset_process_window_size, Fformat_network_address)
2806 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2807 (sigchld_handler):
d311d28c 2808 Check that fixnums are in proper range for system types.
d44287d4 2809 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2810 Check for process-ids out of pid_t range rather than relying on
2811 undefined behavior.
e4d81efc 2812 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2813 (Fformat_network_address, read_process_output, send_process)
2814 (Fprocess_send_region, status_notify):
2815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2816 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2817 (wait_reading_process_output, read_process_output, exec_sentinel):
2818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2819 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2820 (Faccept_process_output): Use duration_to_sec_usec to do proper
2821 overflow checking on durations.
dde14581
PE
2822 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2823 Don't assume pid_t fits in int.
02481186
PE
2824 * process.h (struct Lisp_Process): Members tick and update_tick
2825 are now of type EMACS_INT, not int.
b62b53e8
PE
2826 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2827 configured --with-wide-int.
d311d28c
PE
2828 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2829 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2830 * search.c (looking_at_1, string_match_1):
2831 (fast_string_match, fast_c_string_match_ignore_case)
2832 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2833 (scan_newline, find_before_next_newline, search_command)
2834 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2835 (set_search_regs, wordify):
2836 (Freplace_match):
2837 (Fmatch_data):
2838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2839 (string_match_1, search_buffer, set_search_regs):
2840 (Fmatch_data):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 (wordify): Check for overflow in size calculation.
2843 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2844 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2845 Check that fixnums are in proper range for system types.
2846 * sound.c (struct sound_device)
2847 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (Fplay_sound_internal):
2850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2851 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2852 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2853 (Fparse_partial_sexp):
2854 Don't assume fixnums can fit in int.
2855 (struct lisp_parse_state, find_start_pos, find_start_value)
2856 (find_start_value_byte, find_start_begv)
2857 (update_syntax_table, char_quoted, dec_bytepos)
2858 (find_defun_start, prev_char_comend_first, back_comment):
2859 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2860 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2862 (Finternal_describe_syntax_value): Check that match_lisp is a
2863 character, not an integer, since the code stuffs it into int.
2864 (scan_words, scan_sexps_forward):
2865 Check that fixnums are in proper range for system types.
2866 (Fforward_word):
2867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2868 (scan_sexps_forward):
2869 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2870 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2871 * syntax.h: Adjust decls to match defn changes elsewhere.
2872 (struct gl_state_s):
2873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2874 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2875 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2876 * sysdep.c (wait_for_termination_1, wait_for_termination)
2877 (interruptible_wait_for_termination, mkdir):
2878 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2879 (emacs_read, emacs_write):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2881 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2882 and double all fit in int.
d311d28c
PE
2883 * term.c (set_tty_color_mode):
2884 Check that fixnums are in proper range for system types.
2885 * termhooks.h (struct input_event):
2886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2887 * textprop.c (validate_interval_range, interval_of)
2888 (Fadd_text_properties, set_text_properties_1)
2889 (Fremove_text_properties, Fremove_list_of_text_properties)
2890 (Ftext_property_any, Ftext_property_not_all)
2891 (copy_text_properties, text_property_list, extend_property_ranges)
2892 (verify_interval_modification):
2893 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2894 (Fnext_single_char_property_change)
2895 (Fprevious_single_char_property_change):
2896 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2897 (copy_text_properties):
2898 Check for integer overflow in index calculation.
d311d28c
PE
2899 * undo.c (last_boundary_position, record_point, record_insert)
2900 (record_delete, record_marker_adjustment, record_change)
2901 (record_property_change):
2902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2903 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2906 (Fx_hide_tip, Fx_file_dialog):
2907 * w32menu.c (set_frame_menubar):
2908 Use ptrdiff_t, not int, for consistency with rest of code.
2909 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2910 (select_window, Fdelete_other_windows_internal)
2911 (window_scroll_pixel_based, window_scroll_line_based)
2912 (Frecenter, Fset_window_configuration):
2913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2914 (Fset_window_hscroll, run_window_configuration_change_hook)
2915 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2916 (Fscroll_other_window, Frecenter):
d311d28c
PE
2917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2918 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2919 Don't assume fixnum fits in int.
2920 (Fset_window_scroll_bars):
2921 Check that fixnums are in proper range for system types.
2922 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2923 (string_pos, c_string_pos, number_of_chars, init_iterator)
2924 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2925 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2926 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2927 (face_before_or_after_it_pos, handle_invisible_prop)
2928 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2929 (display_prop_intangible_p, string_buffer_position_lim)
2930 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2931 (get_overlay_strings_1, get_overlay_strings)
2932 (iterate_out_of_display_property, forward_to_next_line_start)
2933 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2934 (get_next_display_element, set_iterator_to_next)
2935 (get_visually_first_element, compute_stop_pos_backwards)
2936 (handle_stop_backwards, next_element_from_buffer)
2937 (move_it_in_display_line_to, move_it_in_display_line)
2938 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2939 (add_to_log, message_dolog, message_log_check_duplicate)
2940 (message2, message2_nolog, message3, message3_nolog
2941 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2942 (current_message_1, truncate_echo_area, truncate_message_1)
2943 (set_message, set_message_1, store_mode_line_noprop)
2944 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2945 (text_outside_line_unchanged_p, check_point_in_composition)
2946 (reconsider_clip_changes)
2947 (redisplay_internal, set_cursor_from_row, try_scrolling)
2948 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2949 (redisplay_window, find_last_unchanged_at_beg_row)
2950 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2951 (trailing_whitespace_p, find_row_edges, display_line)
2952 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2953 (display_mode_element, store_mode_line_string)
2954 (pint2str, pint2hrstr, decode_mode_spec)
2955 (display_count_lines, display_string, draw_glyphs)
2956 (x_produce_glyphs, x_insert_glyphs)
2957 (rows_from_pos_range, mouse_face_from_buffer_pos)
2958 (fast_find_string_pos, mouse_face_from_string_pos)
2959 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2961 (safe_call, init_from_display_pos, handle_fontified_prop)
2962 (handle_single_display_spec, load_overlay_strings)
2963 (with_echo_area_buffer, setup_echo_area_for_printing)
2964 (display_echo_area, echo_area_display)
2965 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2966 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2967 (redisplay_window, dump_glyph_row, display_mode_line)
2968 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2969 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2970 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2971 (handle_single_display_spec, build_desired_tool_bar_string)
2972 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2973 (get_specified_cursor_type):
2974 Check that fixnums are in proper range for system types.
2975 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2976 (Flookup_image_map):
2977 Don't assume fixnums fit in int.
2978 (compare_overlay_entries):
2979 Avoid mishandling comparisons due to subtraction overflow.
2980 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2981 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2982 (handle_tool_bar_click):
2983 Use int, not unsigned, since we prefer signed and the signedness
2984 doesn't matter here.
2985 (get_next_display_element, next_element_from_display_vector):
2986 Use int, not EMACS_INT, when int is wide enough.
2987 (start_hourglass): Use duration_to_sec_usec to do proper
2988 overflow checking on durations.
2989 * xfaces.c (Fbitmap_spec_p):
2990 Check that fixnums are in proper range for system types.
2991 (compare_fonts_by_sort_order):
2992 Avoid mishandling comparisons due to subtraction overflow.
2993 (Fx_family_fonts, realize_basic_faces):
2994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2995 (Fx_family_fonts):
2996 Don't assume fixnum fits in int.
2997 Use SAFE_ALLOCA_LISP, not alloca.
2998 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2999 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3000 (face_at_buffer_position, face_for_overlay_string)
3001 (face_at_string_position):
3002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3003 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3004 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3005 (Fx_show_tip):
3006 Check that fixnums are in proper range for system types.
3007 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3008 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3010 (Fx_change_window_property): Don't assume fixnums fit in int.
3011 * xfont.c (xfont_chars_supported):
3012 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3013 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3014 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3016 * xml.c (parse_region):
3017 * xrdb.c (magic_file_p):
3018 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3019 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3020 (x_get_local_selection, x_reply_selection_request)
3021 (x_handle_selection_request, wait_for_property_change):
3022 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3023 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3024 short is wide enough.
3025 (x_send_client_event): Don't assume fixnum fits in int.
3026 * xterm.c (x_x_to_emacs_modifiers):
3027 Don't assume EMACS_INT overflows nicely into int.
3028 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3029 may come from Lisp.
3030 (handle_one_xevent): NATNUMP can eval its arg twice.
3031 (x_connection_closed):
3032 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3033 * xterm.h: Adjust decls to match defn changes elsewhere.
3034 (struct scroll_bar): Use struct vectorlike_header
3035 rather than rolling our own approximation.
3036 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3037
c6574eb5
GM
30382012-05-25 Glenn Morris <rgm@gnu.org>
3039
3040 * lisp.mk (lisp): Update for more files being compiled now.
3041
e8d32c7e
SM
30422012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3043
48def666
SM
3044 * lread.c: Remove `read_pure' which makes no difference.
3045 (read_pure): Remove var.
3046 (unreadpure): Remove function.
3047 (readevalloop): Don't call read_list with -1 flag.
3048 (read1, read_vector): Don't test read_pure any more.
3049 (read_list): Simplify.
3050
e8d32c7e
SM
3051 * fileio.c, character.h: Minor style tweaks.
3052
4b2addb7
DA
30532012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3054
3055 * window.h (clip_changed): Remove useless declaration.
3056
584461b2
JB
30572012-05-22 Juanma Barranquero <lekktu@gmail.com>
3058
3059 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3060 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3061
34374650
PE
30622012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Remove src/m/*.
3065 This directory predates autoconf and is no longer needed nowadays.
3066 Move its few remaining bits of functionality to where they're needed.
3067 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3068 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3069 * m/template.h: Remove.
3070 * Makefile.in (M_FILE): Remove. All uses removed.
3071 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3072 * lisp.h (USE_LSB_TAG):
3073 * mem-limits.h (EXCEEDS_LISP_PTR):
3074 Use VAL_MAX, not VALBITS, in #if.
3075 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3076 (EMACS_UINT): Define unconditionally now.
3077 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3078 (BITS_PER_EMACS_INT): New constants, replacing
3079 what used to be in config.h, but not useful in #if.
3080 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3081 define them any more.
3082 (VAL_MAX): New macro.
3083 (VALMASK): Use it.
3084 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3085 BITS_PER_EMACS_INT, in #if.
3086 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3087 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3088 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3089 * s/ms-w32.h (DATA_START):
3090 Move here from removed file m/intel386.h.
3091 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3092 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3093
261cb4bb
PE
30942012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3095
3096 Assume C89 or later.
3097 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3098 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3099 (xrealloc):
3100 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3101 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3102 * textprop.c, tparam.c (NULL): Remove.
3103 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3104 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3105 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3106 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3107 * xterm.c (input_signal_count): Assume volatile works.
3108
ff23cd9f
KB
31092012-05-21 Ken Brown <kbrown@cornell.edu>
3110
3111 * xgselect.c (xg_select): Fix first argument in call to 'select'
3112 (bug#11508).
3113
1b170bc6
KB
31142012-05-20 Ken Brown <kbrown@cornell.edu>
3115
3116 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3117 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3118
b2f4d39f
KB
31192012-05-19 Ken Brown <kbrown@cornell.edu>
3120
3121 * xfns.c (x_in_use): Remove `static' qualifier.
3122 * xterm.h (x_in_use): Declare.
3123 * xgselect.c: Include xterm.h.
3124 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3125 and `display_arg' (bug#9754).
3126
003fdae2
PE
31272012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3128
9232a6d9
PE
3129 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3130
003fdae2
PE
3131 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3132 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3133
784b56e2
EZ
31342012-05-18 Eli Zaretskii <eliz@gnu.org>
3135
3136 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3137
3138 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3139 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3140
3141 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3142 reference to image_cache->refcount.
3143 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3144
a0a79cde
JL
31452012-05-17 Juri Linkov <juri@jurta.org>
3146
3147 * search.c (Fword_search_regexp, Fword_search_backward)
3148 (Fword_search_forward, Fword_search_backward_lax)
3149 (Fword_search_forward_lax): Move functions to isearch.el
3150 (bug#10145, bug#11381).
3151
b0572523
PE
31522012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3153
3154 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3155
9660f5fc
SM
31562012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3157
3158 * lread.c (init_obarray): Declare Qt and Qnil as special.
3159
4374de83
GM
31602012-05-14 Glenn Morris <rgm@gnu.org>
3161
3162 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3163 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3164
dc44c39a
PE
31652012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3166
078c97cb
PE
3167 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3168
dc44c39a
PE
3169 * unexaix.c: Port to more-recent AIX compilers.
3170 (report_error, report_error_1, make_hdr, copy_sym)
3171 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3172 Make arguments const char *, not char *, to avoid violations of C
3173 standard and to fix some AIX warnings reported by Gilles Pion.
3174
e18afed7 31752012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3176
3177 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3178 already have overlays loaded.
3179 (handle_single_display_spec): Before returning without displaying
3180 fringe bitmap, synchronize the bidi iterator with the main display
3181 iterator, by calling iterate_out_of_display_property.
3182 (iterate_out_of_display_property): Detect buffer iteration by
3183 testing that it->string is a Lisp string.
3184 (get_next_display_element): When the current object is exhausted,
3185 and there's something on it->stack, call set_iterator_to_next to
3186 proceed with what's on the stack, instead of returning zero.
3187 (set_iterator_to_next): If called at the end of a Lisp string,
3188 proceed to consider_string_end without incrementing string
3189 position. Don't increment display vector index past the end of
3190 the display vector. (Bug#11417)
c8fb9dc6
EZ
3191 (pos_visible_p): Don't report a position visible when move_it_to
3192 stopped at the last line of window, which happens to be scanned
3193 backwards by the bidi iteration. (Bug#11464)
ac268e67 3194
e18afed7 31952012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3196
3197 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3198 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3199 are on a TTY, and thus unable to display on the fringes.
3200 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3201 so we need to signal to the caller that this is a "replacing"
3202 display spec. This fixes display when the spec is invalid or we
3203 are on a TTY.
3204
e18afed7 32052012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3206
3207 * unexaix.c (make_hdr): Fix typo in prototype.
3208 This bug broke the build on AIX. Problem reported by Gilles Pion.
3209
9d0a235a
MA
32102012-05-14 Michael Albinus <michael.albinus@gmx.de>
3211
3212 * keyboard.c (kbd_buffer_get_event): Read special events also in
3213 batch mode. (Bug#11415)
3214
9e6b06ed
GM
32152012-05-12 Glenn Morris <rgm@gnu.org>
3216
3217 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3218
c1a1d7a3
EZ
32192012-05-12 Eli Zaretskii <eliz@gnu.org>
3220
3221 * lisp.mk (lisp): Add newcomment.elc.
3222
3fe7cdc8
GM
32232012-05-12 Glenn Morris <rgm@gnu.org>
3224
3225 * Makefile.in (MKDIR_P): New, set by configure.
3226 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3227
53f7d2c0
PE
32282012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3229
3230 Remove unused function hourglass_started.
3231 * dispextern.h (hourglass_started):
3232 * w32fns.c (hourglass_started):
3233 * xdisp.c (hourglass_started): Remove.
3234
75aafb17
JB
32352012-05-10 Juanma Barranquero <lekktu@gmail.com>
3236
3237 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3238 Update dependencies.
3239
12959e8e
PE
32402012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3241
97107e2e
PE
3242 * xgselect.c (xg_select): Put maxfds+1 into a var.
3243 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3244
12959e8e
PE
3245 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3246
836d29b3
DA
32472012-05-10 Dave Abrahams <dave@boostpro.com>
3248
3249 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3250 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3251
5cb67954
MA
32522012-05-09 Michael Albinus <michael.albinus@gmx.de>
3253
3254 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3255 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3256 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3257 Initialize xd_registered_buses.
3258
3478ec45
PE
32592012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3260
b263a6b0
PE
3261 Untag more efficiently if USE_LSB_TAG.
3262 This is based on a proposal by YAMAMOTO Mitsuharu in
3263 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3264 For an admittedly artificial (nth 8000 longlist) benchmark on
3265 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3266 Emacs's overall text size by 1%.
3267 * lisp.h (XUNTAG): New macro.
3268 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3269 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3270 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3271 * eval.c (Fautoload):
3272 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3273 * frame.h (XFRAME): Use XUNTAG.
3274
3478ec45
PE
3275 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3276 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3277 Remove unportable assumptions about print widths of types like
3278 dbus_uint32_t.
3279 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3280 intptr_t when converting between pointer and integer, to avoid GCC
3281 warnings about wrong width.
3282
666b903b 32832012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3284
3285 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3286 stack for each reader_thread, instead of defaulting to 8MB
3287 determined by the linker. This avoids failures in creating
3288 subprocesses on Windows 7, see the discussion in this thread:
3289 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3290
b120cc17
JC
32912012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3292
3293 Fix up display of the *Minibuf-0* buffer in the mini window.
3294 * keyboard.c (read_char): Don't clear the echo area if there's no
3295 message to clear.
3296 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3297 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3298
9a4b36f8
MA
32992012-05-07 Michael Albinus <michael.albinus@gmx.de>
3300
3301 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3302 batch mode.
3303
e5f9458f
CY
33042012-05-06 Chong Yidong <cyd@gnu.org>
3305
3306 * lisp.mk (lisp): Update.
3307
eceeb5fc 33082012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3309
3310 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3311
71873e2b
SM
33122012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3313
3314 * data.c (PUT_ERROR): New macro.
3315 (syms_of_data): Use it. Add new error type `user-error'.
3316 * undo.c (user_error): New function.
3317 (Fprimitive_undo): Use it.
3318 * print.c (print_error_message): Adjust print style for `user-error'.
3319 * keyboard.c (user_error): New function.
3320 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3321
ab0fa4e4
PE
33222012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3323
3324 Do not limit current-time-string to years 1000..9999.
3325 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3326 (Fcurrent_time_string): Support any year that is supported by the
3327 underlying localtime representation. Don't use asctime, as it
3328 has undefined behavior for years outside the range -999..9999.
3329
7ed806a7
PE
33302012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3331
3332 Fix race conditions involving setenv, gmtime, localtime, asctime.
3333 Without this fix, interrupts could mess up code that uses these
3334 nonreentrant functions, since setting TZ invalidates existing
3335 tm_zone or tzname values, and since most of these functions return
3336 pointers to static storage.
3337 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3338 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3339 Grow the critical sections to include not just invoking
3340 localtime/gmtime, but also accessing these functions' results
3341 including their tm_zone values if any, and any related TZ setting.
3342 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3343 so that the struct tm is saved in the critical section.
3344 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3345 motivated by the fact that memory allocation needs to be outside
3346 the critical section.
3347
0c16dfed
DA
33482012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3349
3350 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3351 with RESET_INTERVAL.
3352
3353 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3354 Remove duplicated buffer name initialization.
3355
3f83ace8
JM
33562012-05-02 Jim Meyering <jim@meyering.net>
3357
3358 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3359
c7b8541e
JM
3360 * xfns.c (x_window): Use xstrdup (Bug#11375).
3361
90207a15 33622012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3363
3364 * xdisp.c (pos_visible_p): If already at a newline from the
3365 display string before the 'while' loop, don't walk back the glyphs
3366 from it3.glyph_row. Solves assertion violation when the display
3367 string begins with a newline (egg.el). (Bug#11367)
3368
b593d6a9
AH
33692012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3372 Move to simple.el.
3373
4737362e
GM
33742012-05-01 Glenn Morris <rgm@gnu.org>
3375
99cf43f9
GM
3376 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3377 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3378 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3379 All were removed before 23.1.
3380
9311dcff
GM
3381 * dispnew.c: Remove HAVE_LIBNCURSES test;
3382 it is always true on relevant platforms.
3383
4d5c6349
GM
3384 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3385 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3386
4737362e
GM
3387 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3388
74dd3a6b
AS
33892012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3390
3391 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3392 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3393 Remove.
3394
13c379ee
PE
33952012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 Do not avoid creating empty evaporating overlays (Bug#9642).
3398 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3399 That is, do not delete an evaporating overlay if it becomes
3400 empty after its bounds are adjusted to fit within its buffer.
3401 This fix caused other problems, and I'm reverting it until we get
3402 to the bottom of them.
3403
a8e7d6d7 34042012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3405
3406 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3407
a8e7d6d7 34082012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3409
3410 * xdisp.c (pos_visible_p): If the window start position is beyond
3411 ZV, start the display from buffer beginning. Prevents assertion
3412 violation in init_iterator when the minibuffer window is scrolled
3413 via the scroll bar.
3414
3415 * window.c (window_scroll_pixel_based): Likewise.
3416
a8e7d6d7 34172012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3418
3419 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3420
a8e7d6d7 34212012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3422
3423 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3424 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3425
a8e7d6d7 34262012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3427
b593d6a9
AH
3428 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3429 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3430
1c6900d9
EZ
34312012-04-26 Eli Zaretskii <eliz@gnu.org>
3432
4c3fa1d9
EZ
3433 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3434 display element, check also the underlying string or buffer
3435 character. (Bug#11341)
3436
1c6900d9
EZ
3437 * w32menu.c: Include w32heap.h.
3438 (add_menu_item): If the call to AppendMenuW (via
3439 unicode_append_menu) fails, disable Unicode menus only if we are
3440 running on Windows 9X/Me.
3441
42bf8205
AS
34422012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3443
3444 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3445 (xgetint): Add missing shift for LSB tags.
3446
b1bac16e
MR
34472012-04-24 Martin Rudalics <rudalics@gmx.at>
3448
3449 * keyboard.c (read_char): Don't wipe echo area for select window
3450 events: These might get delayed via `mouse-autoselect-window'
3451 (Bug#11304).
3452
d69621cc
JB
34532012-04-24 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3456 manipulation of :loaded-from data.
3457
02fd101b
JB
34582012-04-23 Juanma Barranquero <lekktu@gmail.com>
3459
3460 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3461 now a cons (bug#11311).
3462
888bec30
PE
34632012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3464
89a438bd
PE
3465 Do not create empty overlays with the evaporate property (Bug#9642).
3466 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3467 if it becomes empty after its bounds are adjusted to fit within
3468 its buffer. Without this fix, in a nonempty buffer (let ((o
3469 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3470 yields an empty overlay that has the evaporate property, which is
3471 not supposed to happen.
3472
1068fe4d
PE
3473 Fix minor GTK3 problems found by static checking.
3474 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3475 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3476 (struct _EmacsFixedClass, emacs_fixed_get_type):
3477 Move decls here from emacsgtkfixed.h, since they needn't be public.
3478 (emacs_fixed_get_type): Now static.
3479 (emacs_fixed_class_init): Omit unused local.
3480 (emacs_fixed_child_type): Remove; unused.
3481 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3482 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3483 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3484 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3485 (EMACS_FIXED_GET_CLASS): Remove; unused.
3486 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3487
888bec30
PE
3488 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3489 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3490
de85e130
PE
34912012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3492
d0baac98 3493 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3494 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3495 (__malloc_size_t, __malloc_ptrdiff_t):
3496 Remove. All uses removed, replaced by the definiens if needed,
3497 since we can assume C89 or better now.
3498 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3499 (protect_malloc_state, align, get_contiguous_space)
3500 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3501 (malloc_atfork_handler_child, malloc_enable_thread)
3502 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3503 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3504 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3505 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3506 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3507 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3508 Define using prototypes, not old style.
3509 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3510 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3511 (align): Don't assume that signed integer overflow wraps around.
3512 Omit unused local var.
3513 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3514 (_free_internal_nolock, memalign, mallochook, reallochook):
3515 Omit no-longer-needed casts.
3516 (valloc): Use getpagesize, not __getpagesize.
3517 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3518 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3519
de85e130
PE
3520 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3521
dcbf5805
MA
35222012-04-22 Michael Albinus <michael.albinus@gmx.de>
3523
3524 Move functions from C to Lisp. Make non-blocking method calls
3525 the default. Implement further D-Bus standard interfaces.
3526
3527 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3528 (QCdbus_request_name_allow_replacement)
3529 (QCdbus_request_name_replace_existing)
3530 (QCdbus_request_name_do_not_queue)
3531 (QCdbus_request_name_reply_primary_owner)
3532 (QCdbus_request_name_reply_in_queue)
3533 (QCdbus_request_name_reply_exists)
3534 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3535 (QCdbus_registered_serial, QCdbus_registered_method)
3536 (QCdbus_registered_signal): New Lisp objects.
3537 (XD_DEBUG_MESSAGE): Use sizeof.
3538 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3539 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3540 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3541 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3542 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3543 (xd_signature, xd_append_arg): Allow float for integer types.
3544 (xd_get_connection_references): New function.
b593d6a9
AH
3545 (xd_get_connection_address): Rename from xd_initialize.
3546 Return cached address.
dcbf5805
MA
3547 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3548 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3549 level.
3550 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3551 Return number of refcounts.
dcbf5805
MA
3552 (Fdbus_get_unique_name): Make stronger parameter check.
3553 (Fdbus_message_internal): New defun.
3554 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3555 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3556 (Fdbus_send_signal, Fdbus_register_service)
3557 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3558 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3559 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3560 (Vdbus_compiled_version, Vdbus_runtime_version)
3561 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3562 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3563 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3564 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3565 Adapt docstring.
dcbf5805 3566
52828e02
PE
35672012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3568
da05bc4c
PE
3569 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3570 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3571 Do not assume ptrdiff_t is the same width as 'int'.
3572
52828e02
PE
3573 * alloc.c: Handle unusual debugging option combinations.
3574 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3575 since the two debugging options are incompatible.
3576 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3577 is defined.
3578 (mem_init, mem_insert, mem_insert_fixup):
3579 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3580 (NEED_MEM_INSERT): Remove; no longer needed.
3581
f01769f9
LL
35822012-04-22 Leo Liu <sdl.web@gmail.com>
3583
3584 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3585
5790543d
PE
35862012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3587
3588 * sysdep.c [__FreeBSD__]: Minor cleanups.
3589 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3590 Use Emacs indenting style more consistently. Avoid some casts.
3591 Use 'double' consistently rather than mixing 'float' and 'double'.
3592
b91b7e4d
EW
35932012-04-21 Eduard Wiebe <usenet@pusto.de>
3594
b593d6a9
AH
3595 * sysdep.c (list_system_processes, system_process_attributes):
3596 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3597
6114eb15
AS
35982012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3599
3600 * lisp.mk (lisp): Update.
3601
2f38dff7
PE
36022012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3603
3604 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3605 It is never used otherwise.
3606
4ae29f89
SM
36072012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3608
3609 * print.c (print_preprocess): Only check print_depth if print-circle
3610 is nil.
3611 (print_object): Check for cycles even when print-circle is nil and
3612 print-gensym is t, but only check print_depth if print-circle is nil.
3613
f30d612a
CY
36142012-04-20 Chong Yidong <cyd@gnu.org>
3615
3616 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3617 set the status to "failed" and ensure that sentinel is run.
3618
c07a4c0b 36192012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3620
3621 * process.c (Fset_process_inherit_coding_system_flag)
3622 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3623 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3624
c07a4c0b 36252012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3626
3627 * xdisp.c (string_buffer_position_lim): Limit starting position to
3628 BEGV.
3629 (set_cursor_from_row): If called for a mode-line or header-line
3630 row, return zero immediately.
3631 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3632 farther than the first row after the header line, if any.
3633 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3634 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3635
c07a4c0b 36362012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3637
4ae29f89
SM
3638 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3639 (bug#11238).
ad3a2b41 3640
c07a4c0b 36412012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36422012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3643
3644 configure: new option --enable-gcc-warnings (Bug#11207)
3645 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3646 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3647 (ALL_CFLAGS): Use new macros rather than old.
3648 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3649 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3650 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3651 -Wunused-result, -Wunused-variable. This should go away once
3652 the Emacs and Gnulib regex code is merged.
3653 (xmalloc, xrealloc): Now static.
3654
aba027e8
PE
36552012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3656
3657 * dired.c (Fsystem_groups): Remove unused local.
3658
e5a36063
GM
36592012-04-17 Glenn Morris <rgm@gnu.org>
3660
3661 * dired.c (Fsystem_users): Doc fix.
3662
316411f0
DA
36632012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3664
3665 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3666 (syms_of_dired): Add them.
3667
9426aba4
PE
36682012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3669
b62a57be
PE
3670 Fix minor alloc.c problems found by static checking.
3671 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3672 New extern decls, to avoid calling undeclared functions.
3673 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3674 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3675 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3676 (NEED_MEM_INSERT): New macro.
3677 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3678 Remove one incorrect comment and fix another.
b62a57be 3679
3539f31f
PE
3680 Fix minor ralloc.c problems found by static checking.
3681 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3682 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3683 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3684 (r_alloc_sbrk): Now static.
3685
a041960a
PE
3686 Improve ralloc.c interface checking.
3687 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3688 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3689 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3690 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3691 [REL_ALLOC]: ... to here, to check interface.
3692 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3693 Remove decls. This fixes an "It stinks!".
3694
9426aba4
PE
3695 * alloc.c (which_symbols): Fix alignment issue / type clash.
3696
d55c12ed
AS
36972012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3698
3699 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3700 (struct Lisp_Misc_Any): Likewise.
3701 (struct Lisp_Free): Likewise.
3702 * alloc.c (union aligned_Lisp_Symbol): Define.
3703 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3704 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3705 (union aligned_Lisp_Misc): Define.
3706 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3707 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3708 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3709
b948ce8b
PE
37102012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3711
3712 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3713 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3714 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3715 * s/netbsd.h, s/sol2-6.h:
3716 Remove definition of GC_MARK_STACK, since the default now works.
3717 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3718 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3719 no longer the default.
3720 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3721
35dc09a1 37222012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3723
35dc09a1
GM
3724 * lread.c (lisp_file_lexically_bound_p):
3725 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3726
35dc09a1
GM
37272012-04-14 Eli Zaretskii <eliz@gnu.org>
3728
3729 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3730 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3731
37322012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3733
3734 * nsterm.m (constrainFrameRect): Always constrain when there is only
3735 one screen (Bug#10962).
3736
bcd86815
KB
37372012-04-13 Ken Brown <kbrown@cornell.edu>
3738
3739 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3740
c25df26e
RT
37412012-04-13 Reuben Thomas <rrt@sc3d.org>
3742
3743 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3744
0fc59f1e
DC
37452012-04-11 Daniel Colascione <dancol@dancol.org>
3746
3747 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3748 against is gone. It's better to use vfork now so that when Cygwin
3749 gains a new, working vfork, we use it automatically (bug#10398).
3750
de8c03dc
SM
37512012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3752
3753 * window.c (save_window_save): Obey window-point-insertion-type.
3754
2f097256
GM
37552012-04-11 Glenn Morris <rgm@gnu.org>
3756
3757 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3758
453b951e
SM
37592012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3760
3761 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3762
75f1671a 37632012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3764
3765 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3766 (force_quit_count): New var.
3767 (handle_interrupt): Use it.
3768
2a8ce227
JB
37692012-04-10 Juanma Barranquero <lekktu@gmail.com>
3770
3771 * w32.c (w32_delayed_load): Record the full path of the library
3772 being loaded (bug#10424).
3773
935396c0
GM
37742012-04-09 Glenn Morris <rgm@gnu.org>
3775
05920a43
GM
3776 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3777 not just in the obarray, before snarfing them. (Bug#11036)
3778
935396c0
GM
3779 * Makefile.in ($(leimdir)/leim-list.el):
3780 Pass EMACS rather than BUILT_EMACS.
3781
a18ecafa
TZ
37822012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3783
3784 * process.c (make_process):
3785 * process.h: Add integer `gnutls_handshakes_tried' member to
3786 process struct.
3787
6bbef4e5
JC
3788 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3789 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3790
3791 * gnutls.c (gnutls_log_function2i): Convenience log function.
3792 (emacs_gnutls_read): Use new log functions,
3793 `gnutls_handshakes_tried' process member, and
3794 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3795 attempts per process (connection).
3796
b4d3bc10
CY
37972012-04-09 Chong Yidong <cyd@gnu.org>
3798
3799 * eval.c (Fuser_variable_p, user_variable_p_eh)
3800 (lisp_indirect_variable): Functions deleted.
3801 (Fdefvar): Caller changed.
3802
3803 * callint.c (Finteractive, Fcall_interactively):
3804 * minibuf.c (Fread_variable): Callers changed.
3805
70f4d973
EZ
38062012-04-09 Eli Zaretskii <eliz@gnu.org>
3807
3808 * xdisp.c (set_cursor_from_row): If the display string appears in
3809 the buffer at position that is closer to point than the position
3810 after the display string, display the cursor on the first glyph of
3811 the display string. Fixes cursor display when a 'display' text
3812 property immediately follows invisible text. (Bug#11094)
3813
cb3c2e3e
PE
38142012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 composite.c: use 'double' consistently
3817 * composite.c (get_composition_id): Use 'double' consistently
3818 instead of converting 'float' to 'double' and vice versa; this is
3819 easier to understand and avoids a GCC warning.
3820
fd06db5d
GM
38212012-04-09 Glenn Morris <rgm@gnu.org>
3822
50fe702a
GM
3823 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3824 preparation for dumping it with emacs. (Bug#4789)
3825 (leimdir): New variable.
3826 ($(leimdir)/leim-list.el): New rule.
3827 (emacs$(EXEEXT)): Depend on leim-list.el.
3828
fd06db5d
GM
3829 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3830 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3831 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3832
55c131ee
AS
38332012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3834
3835 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3836 proper alignment.
3837
9209588f
JB
38382012-04-07 Juanma Barranquero <lekktu@gmail.com>
3839
3840 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3841 Remove unused local variable.
3842
e3fb2efb
PE
38432012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3846 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3847 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3848 objects, as mark_maybe_pointer will catch them otherwise.
3849 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3850 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3851
b5385551
PE
38522012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 Fix typo that broke non-Windows builds.
3855 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3856
9078ead6
EZ
38572012-04-07 Eli Zaretskii <eliz@gnu.org>
3858
3859 Support building on MS-Windows with libxml2.
3860
3861 * makefile.w32-in (OBJ2): Add xml.$(O).
3862 (GLOBAL_SOURCES): Add xml.c.
3863 ($(BLD)/xml.$(O)): New dependency list.
3864
3865 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3866 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3867 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3868 [!WINDOWSNT]: New macros.
3869 (init_libxml2_functions, libxml2_loaded_p): New functions.
3870 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3871 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3872 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3873 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3874 linked in).
6bbef4e5
JC
3875 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3876 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3877 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3878
3879 * emacs.c: Don't include libxml/parser.h.
3880 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3881 xmlCleanupParser directly.
3882
3883 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3884
3811fdf3
EZ
38852012-04-07 Eli Zaretskii <eliz@gnu.org>
3886
3887 * indent.c (Fvertical_motion): If there is a display string at
3888 point, use it.vpos to compute how many lines to backtrack after
3889 move_it_to point. (Bug#11133)
3890
2f8e16b2
EZ
38912012-04-06 Eli Zaretskii <eliz@gnu.org>
3892
3893 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3894 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3895 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3896 macros related to unification of CJK characters. For the details,
3897 see the discussion following the message here:
3898 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3899
3d439cd1
CY
39002012-04-04 Chong Yidong <cyd@gnu.org>
3901
3902 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3903
8bc53d00
EZ
39042012-04-01 Eli Zaretskii <eliz@gnu.org>
3905
3906 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3907 instead of alloca. (Bug#11138)
3908
3b0512a3
AS
39092012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3910
3911 * w32menu.c (is_simple_dialog): Properly check lisp types.
3912 (Bug#11141)
3913
8427ddd2
EZ
39142012-03-31 Eli Zaretskii <eliz@gnu.org>
3915
979022ef
EZ
3916 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3917 position we get to after a call to move_it_to fails the
3918 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3919 only if we wind up in a string from display property. (Bug#11063)
3920
a6b1c7cc
EZ
3921 * window.c (Fdelete_other_windows_internal): Invalidate the row
3922 and column information about mouse highlight, so that redisplay
3923 restores it after reallocating the glyph matrices. (Bug#7464)
3924
8427ddd2
EZ
3925 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3926 string comes from a `display' text property, use the buffer
3927 position of that property as if we actually saw that position in
3928 the row's glyphs.
697ba24b
EZ
3929 (move_it_by_lines): Remove the assertion that
3930 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3931 violated when there's a before-string at the beginning of a line.
3932 (Bug#11063)
8427ddd2 3933
65a0a738
EZ
39342012-03-30 Eli Zaretskii <eliz@gnu.org>
3935
3936 * xdisp.c (append_space_for_newline): If the default face was
3937 remapped, use the remapped face for the appended newline.
3938 (extend_face_to_end_of_line): Use the remapped default face for
3939 extending the face to the end of the line.
3940 (display_line): Call extend_face_to_end_of_line when the default
3941 face was remapped. (Bug#11068)
3942
581355cc
EZ
39432012-03-29 Eli Zaretskii <eliz@gnu.org>
3944
3945 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3946
e8fc049f
SM
39472012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3948
3949 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3950
4fb9a543
GM
39512012-03-27 Glenn Morris <rgm@gnu.org>
3952
3953 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3954 Doc fixes.
3955
679910f1
KH
39562012-03-26 Kenichi Handa <handa@m17n.org>
3957
3958 * dispextern.h (struct glyph): Fix previous change. Change the
3959 bit length of glyphless.ch to 25 (Bug#11082).
3960
90d49b7f
CY
39612012-03-26 Chong Yidong <cyd@gnu.org>
3962
3963 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3964 (command_loop_1): Use it; inhibit selection update for
3965 handle-select-window too (Bug#8996).
3966
f514f6f0
FP
39672012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3968
e8fc049f 3969 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3970
bf43fa51
KH
39712012-03-25 Kenichi Handa <handa@m17n.org>
3972
3973 * dispextern.h (struct glyph): Change the bit length of
3974 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3975
8a0c01dd
EZ
39762012-03-24 Eli Zaretskii <eliz@gnu.org>
3977
3978 * s/ms-w32.h (tzname): Include time.h before redirecting to
3979 _tzname. Fixes the MSVC build. (Bug#9960)
3980
7d1c3a76
AS
39812012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3982
8ed79523
AS
3983 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3984 characters.
3985
7d1c3a76
AS
3986 * xterm.c (XTread_socket): Only modify handling_signal if
3987 !SYNC_INPUT. (Bug#11080)
3988
e99a9b8b
EZ
39892012-03-23 Eli Zaretskii <eliz@gnu.org>
3990
3991 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3992 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3993 when fetching a multibyte character consumes more bytes than
3994 CHAR_BYTES returns, due to unification of CJK characters in
3995 string_char. (Bug#11073)
3996
5063c0e1
TN
39972012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3998
3999 * process.c (wait_reading_process_output): Handle pty disconnect
4000 by refraining from sending oneself a SIGCHLD (bug#10933).
4001
9f851fbd
CY
40022012-03-22 Chong Yidong <cyd@gnu.org>
4003
4004 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4005
5063c0e1 4006 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4007 Mark string as coming from a prefix property.
4008 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4009 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4010
fb5b8aca
CY
40112012-03-21 Chong Yidong <cyd@gnu.org>
4012
4013 * xfaces.c (Vface_remapping_alist): Doc fix.
4014
62356a1b
EZ
40152012-03-20 Eli Zaretskii <eliz@gnu.org>
4016
4017 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4018 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4019 Doc fixes.
62356a1b 4020
025de85b
CY
40212012-03-20 Chong Yidong <cyd@gnu.org>
4022
4023 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4024 to reflect default non-nil value of redisplay-dont-pause.
4025
4827f94e
KH
40262012-03-19 Kenichi Handa <handa@m17n.org>
4027
4028 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4029 it fit in a valid range (Bug#11003).
4030
e50a24a2
EZ
40312012-03-18 Eli Zaretskii <eliz@gnu.org>
4032
4033 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4034 that is not from display property, accept the row as a "cursor
4035 row" if one of the string's character has a non-nil `cursor'
4036 property. Fixes cursor positioning when there are newlines in
4037 overlay strings, e.g. in icomplete.el. (Bug#11035)
4038
9af5ed87
PE
40392012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4042
d1f55f16
CY
40432012-03-12 Chong Yidong <cyd@gnu.org>
4044
4045 * eval.c (inhibit_lisp_code): Rename from
4046 inhibit_window_configuration_change_hook; move from window.c.
4047
4048 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4049 * window.c (run_window_configuration_change_hook)
4050 (syms_of_window): Callers changed.
4051
66c5eebd
CY
40522012-03-11 Chong Yidong <cyd@gnu.org>
4053
413df973
CY
4054 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4055
66c5eebd
CY
4056 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4057
1de11f56
CY
40582012-03-10 Chong Yidong <cyd@gnu.org>
4059
4060 * frame.c (other_visible_frames): Don't assume the selected frame
4061 is visible (Bug#10955).
4062
cae07000
SM
40632012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4064
4065 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4066
89c94350
JD
40672012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4068
4069 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4070 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4071 zero (Bug#10954).
4072
999dd333
GM
40732012-03-03 Glenn Morris <rgm@gnu.org>
4074
01a6dcc8 4075 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4076
de0100f2
EZ
40772012-03-02 Eli Zaretskii <eliz@gnu.org>
4078
4079 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4080 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4081 (redisplay_window, next_element_from_string): Fix typos in
4082 comments.
3e441275
EZ
4083 (redisplay_window): Pass to move_it_vertically the margin in
4084 pixels, not in screen lines.
de0100f2 4085
96a72ee9
GM
40862012-03-02 Glenn Morris <rgm@gnu.org>
4087
4088 * buffer.c (buffer-list-update-hook): Doc fix.
4089
312508d7
EZ
40902012-02-29 Eli Zaretskii <eliz@gnu.org>
4091
4092 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4093 push_it before setting up the iterator for the first overlay
4094 string, even if we have an empty string loaded.
4095 (next_overlay_string): If there's an empty string on the iterator
4096 stack, pop the stack. (Bug#10903)
4097
27f3c637
PE
40982012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4101 Suggested by Stefan Monnier in
4102 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4103 * alloc.c (widen_to_Lisp_Object): New static function.
4104 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4105 and widening them to Lisp_Objects. This would work even if
4106 USE_LSB_TAG is defined and wide integers are used, which might
4107 happen in a future version of Emacs.
4108
3c9dfce6
CY
41092012-02-25 Chong Yidong <cyd@gnu.org>
4110
fa74b241
CY
4111 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4112 Doc fix.
4113
3c9dfce6
CY
4114 * xselect.c (Fx_selection_exists_p): Doc fix.
4115 (x_clipboard_manager_save_all): Print an informative message
4116 before saving to clipboard manager.
4117
9486df08
CY
41182012-02-24 Chong Yidong <cyd@gnu.org>
4119
4120 * keyboard.c (process_special_events): Handle all X selection
4121 requests in kbd_buffer, not just the next one (Bug#8869).
4122
f01d3321
CY
41232012-02-23 Chong Yidong <cyd@gnu.org>
4124
4125 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4126 call when setting menu-bar-lines and tool-bar-lines parameters.
4127 (unwind_create_frame_1): New helper function.
4128
4129 * window.c (inhibit_window_configuration_change_hook): New var.
4130 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4131 (syms_of_window): Initialize it.
f01d3321 4132
86b847b6
CY
41332012-02-22 Chong Yidong <cyd@gnu.org>
4134
4135 * xterm.c (x_draw_image_relief): Add missing type check for
4136 Vtool_bar_button_margin (Bug#10743).
4137
a59225b1
CY
41382012-02-21 Chong Yidong <cyd@gnu.org>
4139
4140 * fileio.c (Vfile_name_handler_alist): Doc fix.
4141
4142 * buffer.c (Fget_file_buffer): Protect against invalid file
4143 handler return value.
4144
310f5bd4
PE
41452012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4146
cb3a28cc
PE
4147 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4148 when computing $valmask.
4149
310f5bd4
PE
4150 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4151 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4152 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4153 It's useless in that case, and it can cause problems on hosts
4154 that allocate halves of EMACS_INT values separately.
4155 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4156 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4157 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4158 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4159 it avoids undefined behavior on hosts where shifting right by more
4160 than the word width has undefined behavior.
4161
2375c96a
CY
41622012-02-19 Chong Yidong <cyd@gnu.org>
4163
4164 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4165 (Funhandled_file_name_directory, Ffile_name_as_directory)
4166 (Fdirectory_file_name, Fexpand_file_name)
4167 (Fsubstitute_in_file_name): Protect against invalid file handler
4168 return values (Bug#10845).
4169
3eb49e71
EZ
41702012-02-18 Eli Zaretskii <eliz@gnu.org>
4171
4172 * .gdbinit (pitx): Fix incorrect references to fields of the
4173 iterator stack.
4174
7b926f3f
CY
41752012-02-17 Chong Yidong <cyd@gnu.org>
4176
4177 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4178
11273115
PE
41792012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4180
4181 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4182 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4183
c3a70e2b
CY
41842012-02-15 Chong Yidong <cyd@gnu.org>
4185
4186 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4187 marked as special. Also, starting docstrings with * is obsolete.
4188
0ca43699
AS
41892012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4190
4191 * gnutls.c (emacs_gnutls_write): Fix last change.
4192
2e8f3c56
LI
41932012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4194
4195 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4196 send_process.
4197
af70074f
SM
41982012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4199
4200 * keymap.c (Fsingle_key_description): Handle char ranges.
4201
95986d52
CY
42022012-02-12 Chong Yidong <cyd@gnu.org>
4203
afd83bd1
CY
4204 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4205 as that creates a dangerous corner case.
4206
95986d52
CY
4207 * window.c (Fdelete_window_internal): Invalidate the mouse
4208 highlight (Bug#9904).
4209
bd7da63e
GM
42102012-02-12 Glenn Morris <rgm@gnu.org>
4211
4212 * xselect.c (Fx_own_selection_internal)
4213 (Fx_get_selection_internal, Fx_disown_selection_internal)
4214 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4215 * nsselect.m (Fx_own_selection_internal)
4216 (Fx_disown_selection_internal, Fx_selection_exists_p)
4217 (Fx_selection_owner_p, Fx_get_selection_internal):
4218 Sync docs and argument specs with the xselect.c versions.
4219
77abcbc2
LI
42202012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4221
4222 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4223
90b671e2
EZ
42242012-02-11 Eli Zaretskii <eliz@gnu.org>
4225
1c0ca0b7
EZ
4226 * w32select.c (Fx_selection_exists_p): Sync doc string and
4227 argument list with xselect.c. (Bug#10783)
4228
4229 * w16select.c (Fx_selection_exists_p): Sync doc string and
4230 argument list with xselect.c. (Bug#10783)
90b671e2 4231
49241268
GM
42322012-02-10 Glenn Morris <rgm@gnu.org>
4233
4234 * fns.c (Fsecure_hash): Doc fix.
4235
f998bbe7 42362012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4237
4238 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4239
0992bd9c
CY
42402012-02-07 Chong Yidong <cyd@gnu.org>
4241
4242 * buffer.c (Fbuffer_local_variables)
4243 (buffer_lisp_local_variables): Handle unbound vars correctly;
4244 don't let Qunbound leak into Lisp.
4245
af008560
GM
42462012-02-07 Glenn Morris <rgm@gnu.org>
4247
dd605cc4
GM
4248 * image.c (Fimagemagick_types): Doc fix.
4249
af008560
GM
4250 * image.c (imagemagick-render-type): Change it from a lisp object
4251 to an integer. Move the doc here from the lisp manual.
4252 Treat all values not equal to 0 the same.
4253
1449fa1d
CY
42542012-02-06 Chong Yidong <cyd@gnu.org>
4255
4256 * doc.c (store_function_docstring): Avoid applying docstring of
4257 alias to base function (Bug#2603).
4258
3723ec07
AS
42592012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4260
4261 * .gdbinit (pp1, pv1): Remove redundant defines.
4262 (pr): Use pp.
4263
79c1cc1e
CY
42642012-02-04 Chong Yidong <cyd@gnu.org>
4265
4266 * nsterm.m: Declare a global (Bug#10694).
4267
d7f29f8e
EZ
42682012-02-04 Eli Zaretskii <eliz@gnu.org>
4269
cae07000
SM
4270 * w32.c (get_emacs_configuration_options):
4271 Include --enable-checking, if specified, in the return value.
d7f29f8e 4272
3b95a6f9
MR
42732012-02-04 Martin Rudalics <rudalics@gmx.at>
4274
4275 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4276 after rounding frame sizes. (Bug#9723)
4277
d6fa96a6
EZ
42782012-02-04 Eli Zaretskii <eliz@gnu.org>
4279
4280 * keyboard.c (adjust_point_for_property): Don't position point
4281 before BEGV. (Bug#10696)
4282
df0b2940
PE
42832012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4284
4285 Handle overflow when computing char display width (Bug#9496).
4286 * character.c (char_width): Return EMACS_INT, not int.
4287 (char_width, c_string_width): Check for overflow when
4288 computing the width; this is possible now that individual
4289 characters can have unbounded width. Problem introduced
4290 by merge from Emacs 23 on 2012-01-19.
4291
6bee44d6
MA
42922012-02-02 Michael Albinus <michael.albinus@gmx.de>
4293
4294 * dbusbind.c (Fdbus_register_method): Mention the return value
4295 :ignore in the docstring.
4296
44f92739
GM
42972012-02-02 Glenn Morris <rgm@gnu.org>
4298
1b9f60cc
GM
4299 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4300
44f92739
GM
4301 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4302 Unconditionally set to t. (Bug#10673)
4303 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4304 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4305 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4306
c5d3843c
KH
43072012-02-02 Kenichi Handa <handa@m17n.org>
4308
4309 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4310 0, do not call append_composite_glyph.
4311
159462d4 43122012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4313
4314 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4315 NULL (Bug#6988).
4316 (x_produce_glyphs): If the component of a composition is a null
4317 string, set it->pixel_width to 1 to avoid zero-width glyph.
4318
78cef877
EZ
43192012-02-01 Eli Zaretskii <eliz@gnu.org>
4320
4321 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4322 first 2 arguments are identical. This makes inserting large
4323 output from a subprocess an order of magnitude faster on
4324 MS-Windows, where all sbrk'ed memory is always contiguous.
4325
97897668
GM
43262012-01-31 Glenn Morris <rgm@gnu.org>
4327
4328 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4329 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4330 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4331
31fd3586
GM
43322012-01-29 Glenn Morris <rgm@gnu.org>
4333
4334 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4335
0e24a8b2
CY
43362012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4337
4338 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4339
cc0adcb0
CY
43402012-01-28 Chong Yidong <cyd@gnu.org>
4341
4342 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4343
acc28cb9
CY
43442012-01-26 Chong Yidong <cyd@gnu.org>
4345
9c69cfb7
CY
4346 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4347
acc28cb9
CY
4348 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4349 repeat counts (Bug#10507).
4350
48da7392
GM
43512012-01-26 Glenn Morris <rgm@gnu.org>
4352
4353 * lread.c (syms_of_lread): Doc fix.
4354
14af5f7f
CY
43552012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4356
4357 * coding.c (encode_designation_at_bol): Change return value to
4358 EMACS_INT.
4359
0b21c100
CY
43602012-01-25 Chong Yidong <cyd@gnu.org>
4361
4362 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4363
3c2907f7
CY
43642012-01-21 Chong Yidong <cyd@gnu.org>
4365
4366 * floatfns.c (Fcopysign): Make the second argument non-optional,
4367 since nil is not allowed anyway.
4368
959ad23f
AS
43692012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4370
4371 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4372 (send_process): Likewise.
4373
34a02f46
MR
43742012-01-19 Martin Rudalics <rudalics@gmx.at>
4375
4376 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4377 (Vwindow_persistent_parameters): Do not use Qstate.
4378 Rewrite doc-strings.
34a02f46 4379
1259009a 43802012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4381
4382 * character.c (char_width): New function.
70d4fdf6
GM
4383 (Fchar_width, c_string_width, lisp_string_width):
4384 Use char_width (Bug#9496).
25ed9e61 4385
6a6ee00d
MR
43862012-01-16 Martin Rudalics <rudalics@gmx.at>
4387
4388 * window.c (Vwindow_persistent_parameters): New variable.
4389 (Fset_window_configuration, save_window_save): Handle persistent
4390 window parameters.
4391
c85efaf7
EZ
43922012-01-14 Eli Zaretskii <eliz@gnu.org>
4393
4394 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4395 thrashing the stack of the thread. (Bug#9087)
4396
5944709e
PE
43972012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4398
4399 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4400
e71f5d99
EZ
44012012-01-11 Eli Zaretskii <eliz@gnu.org>
4402
4403 * xdisp.c (rows_from_pos_range): Handle the case where the
4404 highlight ends on a newline. (Bug#10464)
4405 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4406 he end column for display of highlight that ends on a newline
4407 before a R2L line.
4408
ce316182
GM
44092012-01-11 Glenn Morris <rgm@gnu.org>
4410
4411 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4412 from load-path also when installation-directory is nil. (Bug#10208)
4413
5b43da69
GM
44142012-01-10 Glenn Morris <rgm@gnu.org>
4415
74cc8ff9
GM
4416 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4417
7d8d6e4e
GM
4418 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4419 Update template values to be closer to their typical values these days.
5b43da69 4420
a0db8d43
EZ
44212012-01-09 Eli Zaretskii <eliz@gnu.org>
4422
4423 * xdisp.c (rows_from_pos_range): Accept additional argument
4424 DISP_STRING, and accept any glyph in a row whose object is that
4425 string as eligible for mouse highlight. Fixes mouse highlight of
4426 display strings from overlays. (Bug#10464)
4427
9a0115ab 44282012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4429
b9110d6a 4430 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4431 * fileio.c (auto_saving_dir_umask): New static var.
4432 (Fmake_directory_internal): Use it.
4433 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4434 creating the directory. The old code temporarily assigns
4435 too-generous permissions to the directory.
4436 (do_auto_save_eh): Clear it.
b9110d6a 4437 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4438 that the var is always cleared.
4439
6c1bd3f3
EZ
44402012-01-07 Eli Zaretskii <eliz@gnu.org>
4441
4442 * search.c (scan_buffer): Pass character positions to
4443 know_region_cache, not byte positions. (Bug#6540)
4444
069d2b50
L
44452012-01-07 LynX <_LynX@bk.ru> (tiny change)
4446
4447 * w32.c (sys_rename): Report EXDEV when rename of a directory
4448 fails because the target is on another logical disk. (Bug#10284)
4449
75bf0d33
DB
44502012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4451
4452 * xterm.c (x_embed_request_focus): New function.
4453
4454 * xterm.h: Add prototype.
4455
4456 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4457
1c6e5a32
GM
44582012-01-05 Glenn Morris <rgm@gnu.org>
4459
4460 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4461
651e947e
EZ
44622012-01-01 Eli Zaretskii <eliz@gnu.org>
4463
4464 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4465 Load gnutls_transport_set_lowat only if GnuTLS version is below
4466 2.11.1.
4467 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4468 GnuTLS versions below 2.11.1.
4469
3778cdd8
AL
44702011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4471
4472 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4473 to the doc string advising against its use for altering the way
4474 windows are scrolled.
4475
0e5317f7
KH
44762011-12-28 Kenichi Handa <handa@m17n.org>
4477
4478 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4479 coding-system ASCII compatible only when it does not produce BOM
4480 on encoding (Bug#10383).
4481
93d5ca1f
JD
44822011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4483
4484 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4485 can scroll.
4486 (create_and_show_popup_menu): Always use menu_position_func for
4487 Gtk3 (Bug#10361).
4488
ca22b785
AS
44892011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4490
4491 * callint.c (Fcall_interactively): Don't truncate prompt string.
4492
d048e1e6
EZ
44932011-12-23 Eli Zaretskii <eliz@gnu.org>
4494
4495 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4496 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4497 resumed from there (after widening). (Bug#10360)
d048e1e6 4498
5ccaba1f
JD
44992011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4500
4501 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4502
204ee57f
JD
45032011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4504
b81d40f0
JB
4505 * nsterm.m (x_free_frame_resources):
4506 Release f->output_data.ns->miniimage.
204ee57f
JD
4507 (ns_index_color): Fix indentation. Do not retain
4508 color_table->colors[i].
4509
4510 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4511 before returning.
4512
4513 * nsfns.m (x_set_background_color): Assign return value from
4514 ns_index_color to face-background instead of NSColor*.
4515 (ns_implicitly_set_icon_type): Fix indentation.
4516 Change assignment in for loop to comparison.
4517
4518 * emacs.c (ns_pool): New variable.
4519 (main): Assign ns_pool.
4520 (Fkill_emacs): Call ns_release_autorelease_pool.
4521
4522 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4523 autorelease fdesc, release fdAttrs and tdict.
4524 (ns_get_covering_families): Release charset.
4525 (ns_findfonts): Release NSFontDescriptor created with new.
4526 (ns_uni_to_glyphs): Fix indentation.
4527 (setString): Release attrStr before assigning new value.
4528
c803b2b7
JD
45292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4530
678f4426
JD
4531 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4532 and NS_IMPL_COCOA.
4533 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4534 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4535
cd394be1 45362011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4537
5fecd5fc
JD
4538 * nsterm.m (ns_term_init): Subscribe for notifications
4539 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4540 to method trackingNotification in EmacsMenu.
4541
4542 * nsmenu.m (trackingMenu): New variable.
3771cb17 4543 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4544 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4545 from Aquamacs (Bug#7030).
678f4426
JD
4546
45472011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4548
c803b2b7
JD
4549 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4550 (symbol_to_nsstring): Fix indentation.
4551 (ns_symbol_to_pb): New function.
cae07000
SM
4552 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4553 (Fns_rotate_cut_buffers_internal): Remove.
4554 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4555 Fns_store_cut_buffer_internal.
4556 (ns_get_foreign_selection, Fx_own_selection_internal)
4557 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4558 (Fns_get_selection_internal, Fns_store_selection_internal):
4559 Use ns_symbol_to_pb and check if return value is nil.
4560 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4561 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4562 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4563 renamed to Sns_store_selection_internal.
4564 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4565 and remove this function.
4566 (ns_handle_selection_clear): Remove, never used.
4567 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4568 here.
4569
e1b01a3a
KB
45702011-12-17 Ken Brown <kbrown@cornell.edu>
4571
4572 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4573 GID is unknown (Bug#10257).
4574
2adb6e85
PE
45752011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4578 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4579 which caused a build failure on GNU/Linux IA-64. This problem was
4580 introduced by my 2011-10-07 patch.
4581
d1d7b339
JL
45822011-12-15 Juri Linkov <juri@jurta.org>
4583
4584 * image.c (imagemagick_error): New function. (Bug#10112)
4585 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4586 Use `imagemagick_error' where ImageMagick functions return
4587 `MagickFalse'.
4588 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4589 proper order.
4590
100d5755
KH
45912011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4592
4593 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4594 fill background (Bug#8992).
4595
454592a6
MR
45962011-12-13 Martin Rudalics <rudalics@gmx.at>
4597
4598 * window.c (Vwindow_combination_resize)
4599 (Vwindow_combination_limit): Use t instead of non-nil in
4600 doc-strings.
61d4b438
MR
4601 (Vrecenter_redisplay): Add first sentence of doc-string on
4602 separate line.
53524d93 4603 (Frecenter): Fix doc-string typo.
454592a6 4604
3633e3aa
KH
46052011-12-11 Kenichi Handa <handa@m17n.org>
4606
4607 * coding.c (Funencodable_char_position): Pay attention to the
4608 buffer text relocation (Bug#9389).
4609
7b9d523a 46102011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4611
7b9d523a
JD
4612 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4613 gtk_init (Bug#10100).
4614
b73189c6
EZ
46152011-12-10 Eli Zaretskii <eliz@gnu.org>
4616
4617 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4618 IT->string is nil. (Bug#10263)
4619
f7dfe5d6
JD
46202011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4621
83faebb4
JD
4622 * nsterm.h (x_free_frame_resources): Declare.
4623
f7dfe5d6
JD
4624 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4625 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4626
4627 * nsterm.h (ns_get_defaults_value): Declare.
4628
4629 * nsterm.m (ns_default): Call ns_get_defaults_value.
4630
7cd4e72c
EZ
46312011-12-09 Eli Zaretskii <eliz@gnu.org>
4632
4633 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4634 (Bug#10170)
4635
b34d7317
YM
46362011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4637
4638 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4639 that where the value of an _OBJC_* symbol points to is in the .bss
4640 section (Bug#10240).
4641
76470ad1
KH
46422011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4643
4644 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4645 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4646
745fff94
KH
46472011-12-08 Kenichi Handa <handa@m17n.org>
4648
4649 * ftfont.c (get_adstyle_property): Fix previous change
4650 (Bug#10233).
4651
6e44397c
JB
46522011-12-07 Juanma Barranquero <lekktu@gmail.com>
4653
4654 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4655 dirs from the default value of EMACSLOADPATH (bug#10208).
4656
7efa6272
GM
46572011-12-07 Glenn Morris <rgm@gnu.org>
4658
4659 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4660 installation and source directories as well. (Bug#10208)
4661
f6fc4d87
CY
46622011-12-06 Chong Yidong <cyd@gnu.org>
4663
4664 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4665
2bf26180
GM
46662011-12-06 Glenn Morris <rgm@gnu.org>
4667
4668 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4669 as an error, not just -1. (Bug#10217)
4670
3a6ad4f0
CY
46712011-12-05 Chong Yidong <cyd@gnu.org>
4672
4673 * keyboard.c (process_special_events): New function.
4674 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4675
75a3b399
PE
46762011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4677
4678 * coding.c (encode_designation_at_bol): Don't use uninitialized
4679 local variable (Bug#9318).
4680
c3c9e25e
KH
46812011-12-05 Kenichi Handa <handa@m17n.org>
4682
4683 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4684 return Qnil (Bug#8046, Bug#10193).
4685
5eb05ea3
KH
46862011-12-05 Kenichi Handa <handa@m17n.org>
4687
4688 * coding.c (encode_designation_at_bol): New args charbuf_end and
4689 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4690 (coding_set_source): Return how many bytes coding->source was
4691 relocated.
4692 (coding_set_destination): Return how many bytes
4693 coding->destination was relocated.
4694 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4695 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4696
46972011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4698
4699 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4700 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4701 macro (Bug#9318).
4702
47032011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4704
4705 The following changes are to fix Bug#9318.
4706
a79703f5 4707 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4708 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4709 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4710 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4711
7dbda6df
JB
47122011-12-05 Juanma Barranquero <lekktu@gmail.com>
4713
4714 * lisp.h (process_quit_flag): Fix external declaration.
4715
6d5eb5b0
SM
47162011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4717
4718 Don't macro-inline non-performance-critical code.
4719 * eval.c (process_quit_flag): New function.
4720 * lisp.h (QUIT): Use it.
4721
a0c3fad0
JD
47222011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4723
4724 * nsfns.m (get_geometry_from_preferences): New function.
4725 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4726
6c07aac2
AS
47272011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4728
4729 * emacs.c (Qkill_emacs): Define.
4730 (syms_of_emacs): Initialize it.
4731 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4732 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4733 (quit_throw_to_read_char): Add parameter `from_signal'.
4734 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4735 * lisp.h (QUIT): Call Fkill_emacs if requested.
4736
c052ead4
JD
47372011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4738
4739 * widget.c (update_wm_hints): Return if wmshell is null.
4740 (widget_update_wm_size_hints): New function.
4741
4742 * widget.h (widget_update_wm_size_hints): Declare.
4743
4744 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4745 widget_update_wm_size_hints (Bug#10104).
4746
9e49252b
EZ
47472011-12-03 Eli Zaretskii <eliz@gnu.org>
4748
4749 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4750 before a newline, prepare the bidi iterator for consuming the
4751 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4752 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4753
02b16839
JL
47542011-12-02 Juri Linkov <juri@jurta.org>
4755
4756 * search.c (Fword_search_regexp): New Lisp function created from
4757 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4758 (Fword_search_backward, Fword_search_forward)
4759 (Fword_search_backward_lax, Fword_search_forward_lax):
4760 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4761 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4762
0068070e
SM
47632011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4764
4765 * fileio.c (Finsert_file_contents): Move after-change-function call
4766 to before the "handled:" label, since all "goto handled" appear in
4767 cases where the *-change-functions have already been properly called
4768 (bug#10117).
4769
3360a3fc
AS
47702011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4771
4772 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4773 waiting for input. (Bug#10169)
4774
73d6c093
EZ
47752011-11-30 Eli Zaretskii <eliz@gnu.org>
4776
4777 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4778 verifies glyph row's hash code--we have just reallocated the
4779 glyphs, so their contents can be complete garbage. (Bug#10164)
4780
febe6bea
JB
47812011-11-30 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4784
801a4313
EZ
47852011-11-30 Eli Zaretskii <eliz@gnu.org>
4786
4787 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4788 attributes are tested _before_ calling verify_row_hash, to protect
4789 against GCC re-ordering of the tests. (Bug#10164)
4790
2b56b87e
JD
47912011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4792
4793 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4794
4795 * xterm.c (handle_one_xevent): Only set async_visible and friends
4796 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4797 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4798 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4799
dbf31225
PE
48002011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4801
4802 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4803 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4804 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4805 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4806 All uses changed to use GCPRO1 etc.
4807 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4808 Revert to old implementation (i.e., before 2011-03-11).
4809
1305621b
YM
48102011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4811
4812 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4813 of scroll runs so as to avoid assigning disabled bogus rows and
4814 unnecessary graphics copy operations.
4815
8c9afb46
EZ
48162011-11-27 Eli Zaretskii <eliz@gnu.org>
4817
4818 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4819 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4820 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4821 (malloc, free, realloc, calloc): Redirect to e_* only when
4822 compiling Emacs.
4823
4824 * lisp.h (GCTYPEBITS): Move before first use.
4825 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4826 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4827 this macro definition.
4828
4829 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4830 _MSC_VER.
4831
54e9e3bf
JD
48322011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4833
6d5eb5b0
SM
4834 * gtkutil.c (xg_create_frame_widgets):
4835 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4836 present with Gtk+ 2.0.
4837
83aca1cb
PE
48382011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4839
4840 * fileio.c (Finsert_file_contents): Undo previous change; see
4841 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4842
5b76caa4
PE
48432011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4844
4845 Rename locals to avoid shadowing.
4846 * fileio.c (Finsert_file_contents):
4847 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4848 * process.c (wait_reading_process_output):
4849 Rename inner 'proc' to 'p' to avoid shadowing.
4850 Indent for consistency with usual Emacs style.
4851
8c535114
EZ
48522011-11-25 Eli Zaretskii <eliz@gnu.org>
4853
4854 * xdisp.c (redisplay_window): If cursor row is not fully visible
4855 after recentering, and scroll-conservatively is set to a large
4856 number, scroll window by a few more lines to make the cursor fully
4857 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4858 (start_display): Don't move to the next line if the display should
4859 start at a newline that is part of a display vector or an overlay
4860 string. (Bug#10119)
8c535114 4861
fa4fdb5c
JL
48622011-11-24 Juri Linkov <juri@jurta.org>
4863
4864 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4865 after the `MagickPingImage' call. (Bug#10112)
4866
90ec88df
CY
48672011-11-23 Chong Yidong <cyd@gnu.org>
4868
4869 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4870
56e2e794
MR
48712011-11-23 Martin Rudalics <rudalics@gmx.at>
4872
4873 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4874 making another buffer current. (Bug#10114)
4875
b6e64c41
GM
48762011-11-23 Glenn Morris <rgm@gnu.org>
4877
4878 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4879
6b21de18
CY
48802011-11-23 Chong Yidong <cyd@gnu.org>
4881
4882 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4883 using it (Bug#5984).
4884
b12cd789
EZ
48852011-11-22 Eli Zaretskii <eliz@gnu.org>
4886
4887 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4888 and header-lines, as they don't have one computed for them.
4889 (Bug#10098)
4890
4891 * .gdbinit (prow): Make displayed values more self-explaining.
4892 Add row's hash code.
4893
261b6fd4
LMI
48942011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4895
4896 * process.c (wait_reading_process_output): Fix asynchrounous
4897 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4898 (wait_reading_process_output): Add comment and URL.
261b6fd4 4899
e7cfd277
JD
49002011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4901
4902 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4903
a9b9b7f5
CY
49042011-11-21 Chong Yidong <cyd@gnu.org>
4905
4906 * window.c (Fnext_window, Fprevious_window): Doc fix.
4907
b0d15b4f
SM
49082011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4909
4910 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4911
fe7a3057
JB
49122011-11-20 Juanma Barranquero <lekktu@gmail.com>
4913
4914 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4915
d2999b1a
MR
49162011-11-20 Martin Rudalics <rudalics@gmx.at>
4917
4918 * window.c (Fset_window_combination_limit): Rename argument
4919 STATUS to LIMIT.
4920 (Vwindow_combination_limit): Remove "status" from doc-string.
4921
d5ff9cd0
AS
49222011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * m/ibms390.h: Remove.
4925 * m/ibms390x.h: Don't include "ibms390.h".
4926
a5bb9bd3
SM
49272011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4928
4929 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4930 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4931
cd1181db
JB
49322011-11-20 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * casetab.c (Fset_case_table):
4935 * charset.c (Fcharset_after): Fix typos.
4936
615a3b8d 49372011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4938
17e845af
PE
4939 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4940 Otherwise, valgrind does not work on some platforms.
4941 Problem reported by Andreas Schwab in
6a0bf43d
PE
4942 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4943 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4944 is set, removing the need for VIRT_ADDRESS_VARIES.
4945 (PURE_P): Use a more-efficient implementation that needs just one
4946 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4947 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4948 to 4 (xorl, subq, cmpq, setbe).
4949 * alloc.c (pure): Always extern now, since that's the
4950 VIRT_ADDR_VARIES behavior.
4951 (PURE_POINTER_P): Use a single comparison, not two, for
4952 consistency with the new puresize.h.
4953 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4954 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4955 Remove VIRT_ADDR_VARIES no longer needed.
4956
f8fe6f96
EZ
49572011-11-19 Eli Zaretskii <eliz@gnu.org>
4958
4959 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4960 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4961 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4962 behave as if the cursor position were at the window margin.
4963
4964 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4965 and the cursor position is out of bounds, behave as if the cursor
4966 position were at the window margin. (Bug#10075)
4967
df05a53c
CY
49682011-11-18 Chong Yidong <cyd@gnu.org>
4969
4970 * window.c (Fwindow_combination_limit): Make first argument
4971 non-optional, since it is meaningless for live windows like the
4972 selected window.
61ccba97 4973
2071918e
DA
49742011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4975
4976 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4977
b50a28de
SM
49782011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4979
4980 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4981 (graft_intervals_into_buffer): Simplify.
4982
015137db
EZ
49832011-11-18 Eli Zaretskii <eliz@gnu.org>
4984
4985 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4986 hash values of the two rows.
4987 (copy_row_except_pointers): Preserve the used[] arrays and the
4988 hash values of the two rows. (Bug#10035)
68c95424 4989 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4990
4991 * xdisp.c (row_hash): New function, body extracted from
4992 compute_line_metrics.
4993 (compute_line_metrics): Call row_hash, instead of computing the
4994 hash code inline.
4995
4996 * dispnew.c (verify_row_hash): Call row_hash for computing the
4997 hash code of a row, instead of duplicating code from xdisp.c.
4998
4999 * dispextern.h (row_hash): Add prototype.
5000
a2addb04
TH
50012011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5002
5003 * frame.c (delete_frame): Don't delete the terminal when the last
5004 X frame is closed if emacs is built with GTK toolkit.
5005
df85d315
JB
50062011-11-17 Juanma Barranquero <lekktu@gmail.com>
5007
5008 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5009
a0c2d0ae
MR
50102011-11-17 Martin Rudalics <rudalics@gmx.at>
5011
5012 * window.c (Vwindow_splits): Rename to
5013 Vwindow_combination_resize. Suggested by Juri Linkov.
5014 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5015 of Vwindow_splits.
5016
58179cce
JB
50172011-11-16 Juanma Barranquero <lekktu@gmail.com>
5018
7877f373
JB
5019 * nsfns.m (Fns_font_name):
5020 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5021
b6f67890
MR
50222011-11-16 Martin Rudalics <rudalics@gmx.at>
5023
5024 * window.h (window): Rename slot "nest" to "combination_limit".
5025 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5026 (Fset_window_nest): Rename to Fset_window_combination_limit.
5027 (Vwindow_nest): Rename to Vwindow_combination_limit.
5028 (recombine_windows, make_parent_window, make_window)
5029 (Fsplit_window_internal, saved_window)
5030 (Fset_window_configuration, save_window_save): Rename all
5031 occurrences of window_nest to window_combination_limit.
5032
c7015153
JB
50332011-11-15 Juanma Barranquero <lekktu@gmail.com>
5034
5035 * image.c (imagemagick_load_image): Fix typo.
5036
322ad6ec
EZ
50372011-11-14 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (display_line): Move the call to
5040 highlight_trailing_whitespace before the call to
5041 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5042 faces of all the glyphs to compute ROW's hash value.
5043 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5044
f067b8ec
JB
50452011-11-14 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5048 just return (bug#10044).
5049
1e5b2111
EZ
50502011-11-12 Eli Zaretskii <eliz@gnu.org>
5051
7ef3cbd5
EZ
5052 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5053 with user-defined heap size. Bump the default size of the temacs
5054 heap to 27MB, to avoid memory warning when running temacs.
5055 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5056
1e5b2111
EZ
5057 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5058 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5059 (verify_row_hash) [XASSERTS]: New function.
5060 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5061 that the hash value of glyph rows is correct.
1e5b2111 5062
89d61221
MR
50632011-11-12 Martin Rudalics <rudalics@gmx.at>
5064
5065 * window.h (window): Remove splits slot.
5066 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5067 (Fdelete_other_windows_internal, make_parent_window)
5068 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5069 (Fset_window_configuration, save_window_save): Don't deal with
5070 split status of windows.
5071 (saved_window): Remove splits slot.
5072 (Vwindow_splits): Rewrite doc-string.
5073
97f18cc8
JD
50742011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5075
5076 * xfns.c (unwind_create_frame):
5077 * nsfns.m (unwind_create_frame):
5078 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5079 Vframe_list (Bug#9999).
5080
22a648b4
DA
50812011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5082
0b381c7e 5083 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5084
659afede
KH
50852011-11-11 Kenichi Handa <handa@m17n.org>
5086
5087 * callproc.c (Fcall_process): Set the member dst_multibyte of
5088 process_coding.
5089
9ac0394b
KH
50902011-11-11 Johan Bockgård <bojohan@gnu.org>
5091
5092 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5093 avoid a crash (bug#9496).
5094
2fbdc249
CY
50952011-11-09 Chong Yidong <cyd@gnu.org>
5096
5097 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5098 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5099
ac6b1f81
PE
51002011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5103
09db192c
PE
51042011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5105
5106 Avoid some portability problems by eschewing 'extern inline' functions.
5107 The trivial performance wins aren't worth the portability hassles; see
5108 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5109 et seq.
5110 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5111 (window_box_width, window_box_left, window_box_left_offset)
5112 (window_box_right, window_box_right_offset): Undo previous change,
5113 by removing the "extern"s.
5114 * intervals.c (adjust_intervals_for_insertion)
5115 (adjust_intervals_for_deletion): Undo previous change,
5116 making these static again.
5117 (offset_intervals, temp_set_point_both, temp_set_point)
5118 (copy_intervals_to_string): No longer inline.
5119 * xdisp.c (window_text_bottom_y, window_box_width)
5120 (window_box_height, window_box_left_offset)
5121 (window_box_right_offset, window_box_left, window_box_right)
5122 (window_box): No longer inline.
5123
105216ed
CY
51242011-11-08 Chong Yidong <cyd@gnu.org>
5125
5126 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5127 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5128 Signal an error if not a live window.
105216ed
CY
5129 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5130 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5131
ae9e237f
JB
51322011-11-07 Juanma Barranquero <lekktu@gmail.com>
5133
5134 * lisp.h (syms_of_abbrev): Remove declaration.
5135 Reported by CHENG Gao <chenggao@royau.me>.
5136
c7aa8333
EZ
51372011-11-07 Eli Zaretskii <eliz@gnu.org>
5138
5139 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5140 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5141 of temacs in GUI mode.
5142
be7f5545
MR
51432011-11-07 Martin Rudalics <rudalics@gmx.at>
5144
5145 * window.h: Declare delete_all_child_windows instead of
5146 delete_all_subwindows.
5147 * window.c (Fwindow_nest, Fset_window_nest)
5148 (Fset_window_new_total, Fset_window_new_normal)
5149 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5150 (delete_all_subwindows): Rename to delete_all_child_windows.
5151 (Fdelete_other_windows_internal, Fset_window_configuration):
5152 Call delete_all_child_windows instead of delete_all_subwindows.
5153 * frame.c (delete_frame): Call delete_all_child_windows instead
5154 of delete_all_subwindows.
5155
ca78dc43
PE
51562011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5157
5158 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5159 This is also needed for porting to any host where GC_MARK_STACK is
5160 not GC_MAKE_GCPROS_NOOPS.
5161 (which_symbols): Use it.
5162
a0241d01
KH
51632011-11-07 Kenichi Handa <handa@m17n.org>
5164
5165 * coding.c (coding_set_destination): Check coding->src_pos only
5166 when coding->src_object is a buffer (bug#9910).
5167
5168 * process.c (send_process): Set the member src_multibyte of coding
5169 to 0 (bug#9911) when sending a unibyte text.
5170
5171 * callproc.c (Fcall_process): Set the member src_multibyte of
5172 process_coding to 0 (bug#9912).
5173
a64bfdfa 51742011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5175
5176 * xmenu.c (cleanup_widget_value_tree): New function.
5177 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5178 calling free_menubar_widget_value_tree directly (Bug#9830).
5179
cb41b32a
PE
51802011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5181
5182 Fix some portability problems with 'inline'.
5183 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5184 (window_box_width, window_box_left, window_box_left_offset)
5185 (window_box_right, window_box_right_offset): Declare extern.
5186 Otherwise, these inline functions do not conform to C99 and
5187 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5188 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5189 * intervals.c (adjust_intervals_for_insertion)
5190 (adjust_intervals_for_deletion): Now extern, because otherwise the
5191 extern inline functions 'offset_intervals' couldn't refer to it.
5192 (static_offset_intervals): Remove.
5193 (offset_intervals): Rewrite using the old contents of
5194 static_offset_intervals. The old version didn't conform to C99
5195 because an extern inline function contained a reference to an
5196 identifier with static linkage.
5197
b7041366
AS
51982011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5199
5200 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5201 GC.
5202
88a37c4d
EZ
52032011-11-06 Eli Zaretskii <eliz@gnu.org>
5204
5205 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5206 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5207 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5208 return Qleft_to_right.
5209
49745b39
CY
52102011-11-06 Chong Yidong <cyd@gnu.org>
5211
5212 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5213 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5214 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5215 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5216 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5217 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5218 (Fwindow_vscroll): Doc fix.
5219 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5220 argument, since it makes no sense to pass a live window and for
5221 consistency with window-child.
5222
1f05cd82
CS
52232011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5224
5225 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5226 support MSVC.
5227
22610910
JR
52282011-11-05 Jason Rumney <jasonr@gnu.org>
5229
5230 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5231 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5232 fonts (Bug#6029).
5233 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5234 bitwise arithmetic preventing use of unicode-sip and non-truetype
5235 opentype fonts.
5236
a06776b2
EZ
52372011-11-05 Eli Zaretskii <eliz@gnu.org>
5238
3ad924ba
EZ
5239 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5240 "emacs"-only part.
5241
a06776b2
EZ
5242 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5243 initialization code to keep similarity to xfns.c after changes
5244 from 2011-11-05.
5245
c9e7db78
JD
52462011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5247
a97f8f3f
JD
5248 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5249 (unwind_create_frame): New function (Bug#9943).
5250 (Fx_create_frame): Restructure code to be more similar to the one in
5251 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5252 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5253 Move terminal->reference_count++ just before making the frame official
5254 (Bug#9943).
5255
5256 * nsterm.m (x_free_frame_resources): New function.
5257 (x_destroy_window): Move code to x_free_frame_resources.
5258
c9e7db78 5259 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5260 (Fx_create_frame, x_create_tip_frame):
5261 Move terminal->reference_count++ just before making the frame
75f1671a 5262 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5263 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5264
a6fc3b5c
EZ
52652011-11-05 Eli Zaretskii <eliz@gnu.org>
5266
5267 Support MSVC build with newer versions of Visual Studio.
5268 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5269 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5270 nt/gmake.defs.
5271
5272 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5273 which are not supported by MSVC.
5274 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5275 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5276 bitfields.
5277 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5278 types in bitfields.
5279 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5280
5281 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5282
58179cce 52832011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5284
5285 Support MSVC build with newer versions of Visual Studio.
5286 * w32.c: Don't include w32api.h for MSVC.
5287 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5288
5289 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5290 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5291 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5292 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5293 e_* cousins.
5294 (alloca) [_MSC_VER]: Define to _alloca.
5295
5296 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5297
5298 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5299
a58c13ed
EZ
53002011-11-04 Eli Zaretskii <eliz@gnu.org>
5301
5302 * xdisp.c (note_mouse_highlight): If either of
5303 previous/next-single-property-change returns nil, treat that as
5304 the beginning or the end of the buffer. (Bug#9955)
5305
fe0b6370
JD
53062011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5307
a58c13ed 5308 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5309 label is not null (Bug#9951).
5310 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5311 may be NULL.
5312
89bd5ee1
EZ
53132011-11-04 Eli Zaretskii <eliz@gnu.org>
5314
5315 * window.c (Fwindow_body_size): Mention in the doc string that the
5316 return value is in frame's canonical units. (Bug#9949)
5317
84c3edb9
EZ
53182011-11-03 Eli Zaretskii <eliz@gnu.org>
5319
4e2fb5c7
EZ
5320 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5321
84c3edb9 5322 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5323 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5324 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5325
bc17a887
EZ
53262011-11-01 Eli Zaretskii <eliz@gnu.org>
5327
5328 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5329 Don't stop backward scan on the continuation glyph, even though
5330 its CHARPOS is positive.
6d5eb5b0
SM
5331 (mouse_face_from_buffer_pos, note_mouse_highlight):
5332 Rename cover_string to disp_string.
bc17a887 5333
4ee88440
MR
53342011-11-01 Martin Rudalics <rudalics@gmx.at>
5335
5336 * window.c (temp_output_buffer_show): Don't use
5337 Vtemp_buffer_show_specifiers.
5338 (Vtemp_buffer_show_specifiers): Remove unused variable.
5339
c2ff3c02
EZ
53402011-10-30 Eli Zaretskii <eliz@gnu.org>
5341
5342 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5343 past the beginning of the current glyph matrix.
5344
58179cce 53452011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5346
5347 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5348 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5349 HAVE_GTK3 (Bug#9869).
b77a6a7f 5350
3b574623
JD
5351 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5352 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5353
b77a6a7f
JD
5354 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5355
5356 * xterm.c: Declare x_handle_net_wm_state to return int.
5357 (handle_one_xevent): Check if we are iconified but don't have
5358 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5359 (get_current_wm_state): Return non-zero if not hidden,
5360 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5361 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5362 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5363 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5364
196e41e4
PE
53652011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5366
5367 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5368 so that this new function doesn't get optimized away by a
5369 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5370
021f2e1a
AS
53712011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5372
5373 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5374
8b058d44
EZ
53752011-10-29 Eli Zaretskii <eliz@gnu.org>
5376
5377 Fix the `xbytecode' command.
5378 * .gdbinit (xprintbytestr): New command.
b50a28de 5379 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5380 (xbytecode): Print the byte-code string as well.
5381
4452fb80
EZ
53822011-10-29 Kim Storm <storm@cua.dk>
5383
8b058d44
EZ
5384 * alloc.c (which_symbols): New function.
5385
21b72067
AS
53862011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5387
5388 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5389 line. (Bug#9903)
5390
83ed7b5c
GM
53912011-10-29 Glenn Morris <rgm@gnu.org>
5392
5393 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5394 Not clear what it was for, and it causes various bugs. (Bug#9839)
5395
5a7a728b
EZ
53962011-10-28 Eli Zaretskii <eliz@gnu.org>
5397
5398 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5399 possible random value that matches one of those tested as
5400 condition to clear the mouse face.
5401
d3d0842f
CY
54022011-10-28 Chong Yidong <cyd@gnu.org>
5403
5404 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5405
31b39d13
DN
54062011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5407
5408 * window.c (make_window): Initialize phys_cursor_on_p.
5409
9aba6043
SM
54102011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5411
5412 * lisp.h (struct Lisp_Symbol): Update comments.
5413
c20992f4
JB
54142011-10-28 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5417
db4f02f2
EZ
54182011-10-28 Eli Zaretskii <eliz@gnu.org>
5419
5420 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5421 <oslsachem@gmail.com> for helping to debug this.
5422
5423 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5424 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5425 (g_b_init_get_glyph_outline_w): New static variables.
5426 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5427 (GetGlyphOutlineW_Proc): New typedefs.
5428 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5429 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5430 New functions.
5431 (w32font_open_internal, compute_metrics):
5432 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5433 instead of calling the "wide" APIs directly.
5434
5435 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5436
5437 * w32.h (syms_of_w32font): Add prototype.
5438
87e68db4
JB
54392011-10-27 Juanma Barranquero <lekktu@gmail.com>
5440
5441 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5442 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5443 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5444 (Fmove_to_window_line): Doc fix.
5445
435c1d67
CY
54462011-10-27 Chong Yidong <cyd@gnu.org>
5447
5448 * process.c (make_process): Set gnutls_state to NULL.
5449
5450 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5451 non-NULL, regardless of GNUTLS_INITSTAGE.
5452 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5453 an error. Set process slots as soon as we allocate them.
5454
5455 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5456
9c6c6f49
CY
54572011-10-27 Chong Yidong <cyd@gnu.org>
5458
9aba6043
SM
5459 * gnutls.c (emacs_gnutls_deinit): New function.
5460 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5461 (Fgnutls_deinit, Fgnutls_boot): Use it.
5462
5463 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5464 (deactivate_process): Call emacs_gnutls_deinit.
5465
657d08d3
JB
54662011-10-27 Juanma Barranquero <lekktu@gmail.com>
5467
5468 * image.c (x_create_x_image_and_pixmap):
5469 * w32.c (sys_rename, w32_delayed_load):
5470 * w32font.c (fill_in_logfont):
5471 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5472
5430d399
JB
54732011-10-26 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * w32fns.c (w32_default_color_map): New function,
5476 extracted from Fw32_default_color_map.
a7ef684b 5477 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5478
fe0055fa
PE
54792011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5480
5481 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5482
e6346438
SM
54832011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5484
5485 * keyboard.c (test_undefined): New function (bug#9751).
5486 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5487
e112cc37
ET
54882011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5489
5490 * sysdep.c (init_sys_modes): Fix the check for the controlling
5491 terminal (Bug#6649).
5492
7b5d6677
EZ
54932011-10-20 Eli Zaretskii <eliz@gnu.org>
5494
5495 * dispextern.h (struct bidi_it): New member next_en_type.
5496
5497 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5498 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5499 current character, check also for next_en_type being WEAK_EN.
5500 (bidi_resolve_weak): Don't enter the expensive loop if the current
5501 position is before next_en_pos. Record the bidi type of the first
5502 non-ET, non-BN character we find, in addition to its position.
5503 (bidi_level_of_next_char): Invalidate next_en_type when
5504 next_en_pos is over-stepped.
5505
7da0b018
PE
55062011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5509 * editfns.c: Rewrite current-time-zone so that it invokes
5510 the equivalent of (format-time-string "%Z") to get the time zone name.
5511 This fixes a bug when the time zone name contains characters that
5512 need converting from the system time locale to Emacs internal format.
5513 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5514 that patch fixed format-time-string to do the conversion, but
5515 I forgot to fix current-time-zone.
5516 (format_time_string): New function, containing most of
5517 what Fformat_time_string used to contain.
5518 (Fformat_time_string): Rewrite in terms of format_time_string.
5519 This doesn't change this function's behavior.
5520 (current-time-zone): Rewrite to use format_time_string.
5521 This fixes the bug reported by Michael Schierl in
5522 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5523 Jason Rumney's 2007-06-07 change worked around this bug, but
5524 didn't fix it.
5525 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5526
8547b010
EZ
55272011-10-19 Eli Zaretskii <eliz@gnu.org>
5528
5529 * xdisp.c (start_display): If the character at POS is displayed
5530 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5531 (try_window_reusing_current_matrix): If a line ends in a display
5532 vector or the next line starts in a display vector, continue
5533 redrawing the window even though the character position of
5534 start_row was reached.
8547b010
EZ
5535 (Bug#9771, part 2)
5536
4e948d15
CY
55372011-10-18 Chong Yidong <cyd@gnu.org>
5538
5539 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5540 with nobreak-char-display too.
5541
4787455f
EZ
55422011-10-18 Eli Zaretskii <eliz@gnu.org>
5543
5544 Fix part 3 of bug#9771.
5545 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5546 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5547 non-neutral characters if the current character is a paragraph
5548 separator (a.k.a. Newline). This avoids running the same
5549 expensive loop twice, once when we consume the preceding newline
5550 and the other time when the line actually needs to be displayed.
5551 Avoid the loop when we see neutrals on the base embedding level
5552 following a character whose directionality is the same as the
5553 paragraph's. This avoids running the expensive loop when a line
5554 ends in a long sequence of neutrals, like control characters.
5555 Add assertion against STRONG_AL type. Slightly rearrange code
5556 that determines the type of a neutral given the first non-neutral
5557 that follows it.
5558 (bidi_level_of_next_char): Set next_en_pos to zero when
5559 invalidating its info.
5560
2c91f553
EZ
55612011-10-17 Eli Zaretskii <eliz@gnu.org>
5562
5563 * xdisp.c (push_display_prop): Determine whether to record string
5564 or buffer position by IT->string, not by IT->method. Allow
5565 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5566 (move_it_vertically_backward): Don't look for character position
5567 immediately after the newline when in a continuation line.
5568 (Bug#9771, part 1)
2c91f553 5569
c7b08b0d
MR
55702011-10-15 Martin Rudalics <rudalics@gmx.at>
5571
5572 * window.c (coordinates_in_window): Rewrite and delabelize
5573 vertical border check. (Bug#5357) (Bug#9618)
5574
6b02f655
SM
55752011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5576
5577 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5578 errors in XSetWindowBorder (bug#9310).
5579
81d40c92
DA
55802011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5581
5582 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5583 avoid crash when xmalloc overrun checking is enabled.
5584
d4172c3b
EZ
55852011-10-13 Eli Zaretskii <eliz@gnu.org>
5586
5587 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5588 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5589 cursor motion with <left> and <right> arrow keys.
5590
5591 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5592 some callers set that themselves.
5593
b00eea75
EZ
55942011-10-12 Eli Zaretskii <eliz@gnu.org>
5595
5596 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5597 display string and the previous row comes from the same string and
5598 is empty. (Bug#9739) (Bug#9738)
5599
8fe012c4
SM
56002011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5601
5602 * doc.c (get_doc_string): Encode file name (bug#9735).
5603
0074aef2
EZ
56042011-10-12 Eli Zaretskii <eliz@gnu.org>
5605
79beb178
EZ
5606 * bidi.c (bidi_level_of_next_char):
5607 * xdisp.c (get_visually_first_element): Remove old incorrect
5608 comments regarding the Unicode Line Separator character.
5609
0074aef2
EZ
5610 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5611
6e4b3fbe
DA
56122011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5613
5614 * alloc.c (Fgc_status): Do not access beyond zombies array
5615 boundary if nzombies > MAX_ZOMBIES.
5616 * alloc.c (dump_zombies): Add missing format specifier.
5617
0324f3af
PE
56182011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5619
b5525cac
PE
5620 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5621 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5622
0324f3af
PE
5623 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5624 Some packages use them to denote characters with modifiers.
5625
e9b5f888
AS
56262011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5627
5628 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5629 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5630 matching a pp-number. Rename parameter var to var1.
5631
127827c0
SM
56322011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5633
5634 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5635
c8fd3bd0
GM
56362011-10-08 Glenn Morris <rgm@gnu.org>
5637
5638 * callint.c (Fcall_interactively): Give a more explicit error for the
5639 'c' case with a non-character input. (Bug#8479)
5640
352ec8ff
EZ
56412011-10-08 Eli Zaretskii <eliz@gnu.org>
5642
03669ccb
EZ
5643 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5644 lines.
7061c986
EZ
5645 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5646 lines that are hscrolled on the left.
03669ccb 5647
352ec8ff
EZ
5648 * dispnew.c (buffer_posn_from_coords): Account for a possible
5649 presence of header-line. (Bug#4426)
5650
a66cfb1c
SM
56512011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5652
6b02f655
SM
5653 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5654 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5655
7c5ee88e
PE
56562011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5657
5658 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5659 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5660 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5661 this makes Emacs dump core during garbage collection on rare
5662 occasions. sizeof is obviously inferior to offsetof here, so
5663 stick with offsetof.
5664 (GC_POINTER_ALIGNMENT): New macro.
5665 (mark_memory): Omit 3rd (offset) arg; caller changed.
5666 Don't assume EMACS_INT alignment is the same as pointer alignment.
5667
df1bbe5b
SM
56682011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5669
5670 * keyboard.c (read_key_sequence_remapped): New var.
5671 (read_key_sequence): Compute remapping in the right buffer.
5672 (command_loop_1): Use read_key_sequence's remapping directly.
5673
51553db6
SM
56742011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5675
32c1fffd
SM
5676 * dired.c (file_name_completion): Don't expand file name.
5677 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5678 before checking file name handler.
5679
51553db6
SM
5680 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5681 they've been requested explicitly (bug#9591).
5682
b6bd1599 56832011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5684
5685 * keymap.c (Fsingle_key_description): Use make_specified_string
5686 instead of build_string to build string from push_key_description.
5687 (Bug#5193)
5688
f701dc2a
PE
56892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5690
4222c55d
PE
5691 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5692 This fixes a Y2038 bug on 64-bit hosts.
5693 * buffer.c (reset_buffer):
5694 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5695 (Fclear_buffer_auto_save_failure):
5696 Use 0, not -1, to represent an unset failure time, since time_t
5697 might not be signed.
5698
f701dc2a
PE
5699 Remove dependency on glibc malloc internals.
5700 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5701 Move back here from lisp.h, but with their new implementations.
5702 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5703 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5704 * charset.c (charset_table_init): New static var.
5705 (syms_of_charset): Use it instead of xmalloc. This removes a
5706 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5707 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5708 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5709 Move back to alloc.c.
5710 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5711 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5712
9ceebf39
JD
57132011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5714
5715 * nsterm.m (windowDidResize): Call x_set_window_size only when
5716 ns_in_resize is true. Otherwise set pixelwidth/height and
5717 call change_frame_size (Bug#9628).
5718
cb993c58
PE
57192011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5720
3930c88b
PE
5721 Port --enable-checking=all to Fedora 14 x86-64.
5722 * charset.c (syms_of_charset): Also account for glibc malloc's
5723 internal overhead when calculating the initial malloc maximum.
5724
cb993c58
PE
5725 Port --enable-checking=all to Fedora 14 x86.
5726 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5727 Move to lisp.h.
5728 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5729 (overrun_check_realloc, overrun_check_free):
5730 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5731 That way, xmalloc returns a properly-aligned pointer even if
5732 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5733 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5734 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5735 into account when calculating the initial malloc maximum.
5736 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5737 Move here from alloc.c, so that charset.c can use it too.
5738 Properly align; the old code wasn't right for common 32-bit hosts
5739 when configured with --enable-checking=all.
5740 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5741 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5742
31bed486
EZ
57432011-09-29 Eli Zaretskii <eliz@gnu.org>
5744
04c70788 5745 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5746 use EDOM.
5747
fbcaa2f3
EZ
57482011-09-28 Eli Zaretskii <eliz@gnu.org>
5749
5750 * xdisp.c (compute_display_string_end): If there's no display
5751 string at CHARPOS, return -1.
5752
5753 * bidi.c (bidi_fetch_char): When compute_display_string_end
5754 returns a negative value, treat the character as a normal
5755 character not covered by a display string. (Bug#9624)
5756
a239d4e9
JB
57572011-09-28 Juanma Barranquero <lekktu@gmail.com>
5758
5759 * lread.c (Fread_from_string): Fix typo in docstring.
5760
88652fd5
EZ
57612011-09-27 Eli Zaretskii <eliz@gnu.org>
5762
5763 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5764 newline, reseat the iterator instead of bidi-iterating there one
5765 character at a time. (Bug#9610)
32c1fffd
SM
5766 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5767 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5768
ed497dd4
AS
57692011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5770
5771 * lread.c (readevalloop): Use correct code for NBSP.
5772 (read1): Likewise. (Bug#9608)
5773
b2bf61aa
MA
57742011-09-25 Michael Albinus <michael.albinus@gmx.de>
5775
5776 * dbusbind.c (Fdbus_register_signal): When service is not
5777 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5778
32bbb17c
GM
57792011-09-25 Glenn Morris <rgm@gnu.org>
5780
5781 * buffer.c (truncate-lines): Doc fix.
5782
94e0933e
CY
57832011-09-24 Chong Yidong <cyd@stupidchicken.com>
5784
5785 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5786 (Fset_window_next_buffers): Doc fix.
5787
cddde921
GM
57882011-09-24 Glenn Morris <rgm@gnu.org>
5789
5790 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5791
1260aef1
PE
57922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5793
25b4bfa0
PE
5794 Fix minor problems found by static checking.
5795 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5796 * indent.c (Fvertical_motion): Fix == vs = typo.
5797
e3cbd34b
EZ
57982011-09-24 Eli Zaretskii <eliz@gnu.org>
5799
a66cfb1c
SM
5800 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5801 Default value is now t. Doc fix.
6bf7006f 5802
e3cbd34b 5803 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5804 logic when moving up, not only when moving down. Fix the
e3cbd34b 5805 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5806 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5807
5808 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5809 CHARPOS is covered by a display string which includes newlines.
5810 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5811 is covered by a display string with embedded newlines.
5812
a3de0cbd
MA
58132011-09-24 Michael Albinus <michael.albinus@gmx.de>
5814
5815 * dbusbind.c (Fdbus_register_signal): Add match rule to
5816 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5817 (Fdbus_register_method, Vdbus_registered_objects_table):
5818 Fix docstring.
a3de0cbd 5819
b260039d
JM
58202011-09-24 Jim Meyering <meyering@redhat.com>
5821
32c1fffd 5822 do not ignore write error for any output size
b260039d
JM
5823 The previous change was incomplete.
5824 While it makes emacs --batch detect the vast majority of stdout
5825 write failures, errors were still ignored whenever the output size is
5826 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5827 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5828 && echo FAIL: ignored write error
5829 FAIL: ignored write error
5830 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5831 && echo FAIL: ignored write error
5832 FAIL: ignored write error
5833 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5834
8eca8a7c
AS
58352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5836
5837 * emacs.c (Fkill_emacs): In noninteractive mode exit
5838 non-successfully if a write error occurred on stdout. (Bug#9574)
5839
3341db62
EZ
58402011-09-21 Eli Zaretskii <eliz@gnu.org>
5841
5842 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5843 the xassert test.
5844
5845 * dispextern.h (struct it): Update the comment documenting what
5846 can it->OBJECT be.
5847
8c203dbf
EZ
58482011-09-20 Eli Zaretskii <eliz@gnu.org>
5849
5850 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5851 a display string, extend search for cursor position to end of row.
5852 (find_row_edges): If the row ends in a newline from a display
5853 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5854 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5855 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5856 non-empty line. Fixes confusing cursor motion with arrow keys at
5857 the beginning of a line that starts with whitespace.
8c203dbf 5858
a4824228
LMI
58592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5860
5861 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5862 (bug#9493).
5863
33ed493b
CY
58642011-09-18 Chong Yidong <cyd@stupidchicken.com>
5865
5866 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5867 boolean (Bug#9154).
5868
56cd55c8
EZ
58692011-09-18 Eli Zaretskii <eliz@gnu.org>
5870
5871 * xdisp.c (display_line): Record maximum and minimum buffer
5872 positions even if no glyphs were produced (e.g., by a zero-width
5873 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5874 buffer positions that will be removed from the glyph row because
5875 they don't fit.
c02dcedf
EZ
5876 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5877 column is beyond frame width: don't subtract 1 "pixel" when
5878 computing width of the stretch.
3e62b7e0
EZ
5879 (reseat_at_next_visible_line_start): Undo the change made on
5880 2011-09-17 that saved paragraph information and restored it after
5881 the call to `reseat'. (Bug#9545)
56cd55c8 5882
5ed99d36 58832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5884
5885 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5886 and turn window cursor on if cleared (Bug#9415).
5887
5ed99d36 58882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5889
5890 * search.c (boyer_moore): Take unibyte characters from pattern
5891 literally. (Bug#9458)
5892
9bade7b2
EZ
58932011-09-18 Eli Zaretskii <eliz@gnu.org>
5894
5895 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5896
e5e9d610
PE
58972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5898
87e4427a
PE
5899 Fix minor problem found by static checking.
5900 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5901 initialized, to pacify gcc -Wuninitialized.
5902
e5e9d610
PE
5903 * fileio.c: Report proper errno when syscall falls.
5904 (Finsert_file_contents): Save and restore errno,
5905 so that report_file_error outputs the correct diagnostic.
5906 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5907
a1674f0b
EZ
59082011-09-18 Eli Zaretskii <eliz@gnu.org>
5909
5910 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5911
fbfb6dd4
EZ
59122011-09-17 Eli Zaretskii <eliz@gnu.org>
5913
5914 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5915 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5916
bb187662
EZ
59172011-09-17 Eli Zaretskii <eliz@gnu.org>
5918
1137e8b8 5919 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5920 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5921
5922 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5923 (bidi_find_paragraph_start): Search back for paragraph beginning
5924 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5925 (bidi_move_to_visually_next): Only trigger paragraph-related
5926 computations when the last character is a newline or at EOB, not
5927 just any NEUTRAL_B. (Bug#9470)
5928
bb187662
EZ
5929 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5930 truncated lines if point is covered by a display string. (Bug#9524)
5931
2e621251
PE
59322011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5933
5934 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5935 (cons_to_x_long): New function.
5936 (lisp_data_to_selection_data): Use it. Correct the test for
5937 short-versus-long data; it was negated. Break out of vector
5938 loop, for efficiency, when a long datum is discovered.
5939
91a15bc6
SM
59402011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5941
5942 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5943
b41c3a35
EZ
59442011-09-16 Eli Zaretskii <eliz@gnu.org>
5945
5946 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5947 GCC PR/17406) by declaring this function with external scope.
5948
7812ba2d
PE
59492011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5952 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5953
cf7edc2a
AS
59542011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5955
5956 * editfns.c (Fformat): Correctly handle text properties on "%%".
5957
bd01620e
EZ
59582011-09-15 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xterm.c (x_draw_composite_glyph_string_foreground):
5961 * w32term.c (x_draw_composite_glyph_string_foreground):
5962 * term.c (encode_terminal_code):
5963 * composite.c (composition_update_it, get_composition_id):
5964 * xdisp.c (get_next_display_element)
5965 (fill_composite_glyph_string): Add comments about special meaning
5966 of TAB characters in a composition.
5967
a02719a3
PE
59682011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5969
5970 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5971 This occurs when processing a multibyte format.
5972 Problem reported by Wolfgang Jenker.
a02719a3 5973
72589a3c
JB
59742011-09-15 Johan Bockgård <bojohan@gnu.org>
5975
5976 * xdisp.c (try_cursor_movement): Only check for exact match if
5977 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5978
1c14176c
PE
59792011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5980
5981 Remove unused external symbols.
5982 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5983 * xdisp.c (calc_pixel_width_or_height): Now static.
5984 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5985 * indent.c (check_display_width):
5986 * w32term.c: Fix comment to match code.
5987 * xterm.c, xterm.h (x_catching_errors): Remove.
5988
d2eea5b5
PE
59892011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5990
5991 * xselect.c: Use signed conversions more consistently (Bug#9498).
5992 (selection_data_to_lisp_data): Assume incoming selection data are
5993 signed integers, not unsigned. This is to be consistent with
5994 outgoing selection data, which was modified to use signed integers
5995 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5996 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5997 expects long, not unsigned long.
5998
46888499
EZ
59992011-09-14 Eli Zaretskii <eliz@gnu.org>
6000
6001 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6002 computation of loop end. Reported by Johan Bockgård
6003 <bojohan@gnu.org>.
6004
ef8ef9fb
CY
60052011-09-13 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * frame.c (Fother_visible_frames_p): Function deleted.
6008
fa819fed
EZ
60092011-09-12 Eli Zaretskii <eliz@gnu.org>
6010
6011 * indent.c (compute_motion): Process display vector front to back
6012 rather than the other way around. (Bug#2496)
6013
2ba8e008
SM
60142011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6015
6016 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6017
20f53c69
CY
60182011-09-11 Chong Yidong <cyd@stupidchicken.com>
6019
6020 * minibuf.c (Fread_from_minibuffer): Doc fix.
6021
d562d7a4
EZ
60222011-09-11 Eli Zaretskii <eliz@gnu.org>
6023
6024 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6025 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6026
1c4d7f3d
LMI
60272011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6028
6029 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6030 value for non-existent files.
6031
b885bf36
EZ
60322011-09-11 Eli Zaretskii <eliz@gnu.org>
6033
6034 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6035 set its "size" to -1. This will set the modtime_size field of
6036 the corresponding buffer to -1, which is what
6037 verify-visited-file-modtime expects for files that do not exist.
6038 (Bug#9139)
6039
6612f0bf
PE
60402011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6041
6042 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6043 here ...
6044 * lisp.h: ... from here. push_key_description is no longer
6045 defined in keyboard.c, so its declaration should not be in
6046 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6047 logically belongs with push_key_description.
6048
dfb3f755
PE
60492011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * buffer.h: Include <sys/types.h> instead of <time.h>.
6052 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6053 Problem reported by Herbert J. Skuhra.
6054
3134906c
LMI
60552011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6056
6057 * xml.c (parse_region): Make the parsing work for
6058 non-comment-starting XML files again (bug#9144).
6059
8d903f4e
AS
60602011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6061
6062 * image.c (gif_load): Fix calculation of bottom and right corner.
6063 (Bug#9468)
6064
80ad64f4
EZ
60652011-09-10 Eli Zaretskii <eliz@gnu.org>
6066
6067 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6068 redisplay in small windows.
6069
208a048d
EZ
60702011-09-09 Eli Zaretskii <eliz@gnu.org>
6071
6072 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6073
9b1c252e
MR
60742011-09-08 Martin Rudalics <rudalics@gmx.at>
6075
6076 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6077 Operate on live windows only.
6078
2949f33b
JB
60792011-09-08 Juanma Barranquero <lekktu@gmail.com>
6080
6081 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6082
e08dcafd
EZ
60832011-09-07 Eli Zaretskii <eliz@gnu.org>
6084
6085 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6086 only under bidi iteration.
6087
115b96bd
JD
60882011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6089
6090 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6091
c8199d0f
PE
60922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6093
6094 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6095 Without this fix, the command to link temacs failed due to an
6096 undefined symbol __builtin_isnan. This is because
6097 /usr/include/iso/math_c99.h #defines isnan(x) to
6098 __builtin_isnan(x), but the bundled gcc, which identifies itself
6099 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6100 a __builtin_isnan.
6101 * floatfns.c (isnan): #undef, and then #define to a clone of
6102 what's in data.c.
6103 (Fisnan): Always define, since it's always available now.
6104 (syms_of_floatfns): Always define isnan at the Lisp level.
6105
e39b275c 61062011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6107
6108 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6109
b2db44d9 61102011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6111
f4af5137 6112 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6113 The previous code assumed that file offsets (off_t values) fit in
6114 EMACS_INT variables, which is not true on typical 32-bit hosts.
6115 The code messed up by falsely reporting buffer overflow in cases
6116 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6117 when "big" contains more than 2**29 bytes, even though this
6118 inserts just one byte and does not overflow the buffer.
6119 (Finsert_file_contents): Store file offsets as off_t
6120 values, not as EMACS_INT values. Check for overflow when
6121 converting between EMACS_INT and off_t. When checking for
6122 buffer overflow or for overlap, take the offsets into account.
6123 Don't use EMACS_INT for small values where int suffices.
6124 When checking for overlap, fix a typo: ZV was used where
6125 ZV_BYTE was intended.
6126 (Fwrite_region): Don't assume off_t fits into 'long'.
6127 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6128
ecfc0a49
MA
61292011-09-05 Michael Albinus <michael.albinus@gmx.de>
6130
6131 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6132
6511acf2 61332011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6134
0999621a 6135 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6136
6137 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6138 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6139 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6140 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6141 (modify_event_symbol): Do not assume that the length of
6142 name_alist_or_stem is safe to alloca and fits in int.
6143 (Fexecute_extended_command): Likewise for function name and binding.
6144 (Frecursion_depth): Wrap around reliably on integer overflow.
6145 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6146 since some callers pass EMACS_INT values.
6147 (Fsingle_key_description): Don't crash if symbol name contains more
6148 than MAX_ALLOCA bytes.
6149 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6150 (get_minibuffer): Arg is now EMACS_INT, not int.
6151 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6152 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6153 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6154
2be7d702
PE
6155 * dbusbind.c (signature_cat): New function.
6156 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6157 Do not overrun buffer; instead, report string overflow.
6158
9d1df220
PE
6159 * dispnew.c (add_window_display_history): Don't overrun buffer.
6160 Truncate instead; this is OK since it's just a log.
6161
33ef5c64
PE
6162 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6163 even if the time zone offset is outlandishly large.
6164 Don't mishandle offset == INT_MIN.
6165
66c6fdd5
PE
6166 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6167 when creating daemon; the previous buffer-overflow check was incorrect.
6168
d749b01b
PE
6169 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6170 which has the guts of the old verror function.
6171
b5cd1905
PE
6172 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6173 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6174
6e1a67fb
PE
6175 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6176 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6177 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6178 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6179 length of string rather than counting it via multiple sprintfs;
6180 that's simpler and more reliable.
c21721cc
PE
6181 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6182 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6183 sprintf, in case result does not fit in int.
6184
c57b67fc
PE
6185 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6186 (fontset_from_font): Print it.
6187
8a401434
PE
6188 * frame.c (tty_frame_count): Now printmax_t, not int.
6189 (make_terminal_frame, set_term_frame_name): Print it.
6190 (x_report_frame_params): In X, window IDs are unsigned long,
6191 not signed long, so print them as unsigned.
6192 (validate_x_resource_name): Check for implausibly long names,
6193 and don't assume name length fits in 'int'.
6194 (x_get_resource_string): Don't blindly alloca invocation name;
6195 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6196 not fit in int.
6197
6e1a67fb
PE
6198 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6199 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6200 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6201
0df02bf3
PE
6202 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6203 Use esprintf, not sprintf, in case result does not fit in int.
6204
48e30793
PE
6205 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6206 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6207 it as a large positive number.
6208 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6209 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6210
a66ff6d8
PE
6211 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6212 in case result does not fit in int.
6213
aca216ff
PE
6214 * print.c (float_to_string): Detect width overflow more reliably.
6215 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6216 buffer overrun. Don't assume list length fits in 'int'. Treat
6217 print length of 0 as 0, not as infinity; to be consistent with other
6218 uses of print length in this function. Don't overflow print length
6219 index. Don't assume hash table size fits in 'long', or that
6220 vectorlike size fits in 'unsigned long'.
6221
31c286f7
PE
6222 * process.c (make_process): Use printmax_t, not int, to format
6223 process-name gensyms.
6224
55e5faa1
PE
6225 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6226
80f2e268
PE
6227 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6228 to avoid potential buffer overrun.
6229
670741ab
PE
6230 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6231 if X resource line is longer than 512 bytes.
6232
b7163a50
PE
6233 * xfns.c (x_window): Make sprintf buffer a bit bigger
6234 to avoid potential buffer overrun.
6235
ae58ff1f
PE
6236 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6237
c43c8a6a
PE
6238 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6239
3f8236f4
PE
62402011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6241
53e9fe90 6242 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6243 Without these, Emacs silently mishandles large integers sometimes.
6244 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6245 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6246
6511acf2
PE
6247 * xdisp.c (try_window_id): Check Emacs fixnum range before
6248 converting to 'int'.
806add1d 6249
6511acf2 6250 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6251 Check that an Emacs fixnum is in range before assigning it to 'int'.
6252 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6253 values converted from Emacs fixnums.
6254 (Frecenter): Don't wrap around a line count if it is out of 'int'
6255 range; instead, treat it as an extreme value.
6256 (Fset_window_configuration, compare_window_configurations):
6257 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6258
6511acf2
PE
6259 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6260 that can exceed INT_MAX. Check that EMACS_INT value is in range
6261 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6262 (match_limit): Don't assume that a fixnum can fit in 'int'.
6263
6511acf2 6264 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6265 exceed INT_MAX.
6266
6511acf2 6267 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6268 (Fvertical_motion): Don't wrap around LINES values that don't fit
6269 in 'int'. Instead, treat them as extreme values. This is good
6270 enough for windows, which can't have more than INT_MAX lines anyway.
6271
fcb901a7
LMI
62722011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6273
0f2f6b6d
LMI
6274 * Require libxml/parser.h to avoid compilation warning.
6275
fcb901a7
LMI
6276 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6277
6278 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6279 since this reportedly can destroy thread storage.
6280
6e20a0d4
CY
62812011-08-30 Chong Yidong <cyd@stupidchicken.com>
6282
6283 * syntax.c (find_defun_start): Update all cache variables if
6284 exiting early (Bug#9401).
6285
148ae00e
EZ
62862011-08-30 Eli Zaretskii <eliz@gnu.org>
6287
f6cfbd8f
EZ
6288 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6289
148ae00e
EZ
6290 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6291 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6292 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6293
6294 * term.c (tty_append_glyph): New function.
6295 (produce_stretch_glyph): Static function and its prototype deleted.
6296
a66cfb1c
SM
6297 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6298 Add prototypes.
148ae00e 6299
c4a07a4c
PE
63002011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6301
6302 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6303 when checking :margin (Bug#9390).
6304 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6305 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6306 so that the name doesn't mislead. All uses changed.
6307
6bc8cd65
JB
63082011-08-28 Johan Bockgård <bojohan@gnu.org>
6309
6310 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6311 set_tty_hooks.
6312
dca4927e
EZ
63132011-08-27 Eli Zaretskii <eliz@gnu.org>
6314
6315 * xdisp.c (move_it_to): Don't bail out early when reaching
6316 position beyond to_charpos, if we are scanning backwards.
6317 (move_it_vertically_backward): When DY == 0, make sure we get to
6318 the first character in the line after the newline.
6319
f2cad773
PE
63202011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6321
6322 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6323 (ccl_driver): Do not generate an out-of-range pointer.
6324 (Fccl_execute_on_string): Remove unnecessary check for
6325 integer overflow, noted by Stefan Monnier in
6326 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6327 Remove a FIXME that didn't need fixing.
6328 Simplify the newly-introduced buffer reallocation code.
6329
0cae2cdb
JB
63302011-08-27 Juanma Barranquero <lekktu@gmail.com>
6331
6332 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6333
5fc295a4 63342011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6335
70c60eb2 6336 Integer and memory overflow issues (Bug#9196).
726e0ab1 6337
d31850da
PE
6338 * doc.c (get_doc_string): Rework so that
6339 get_doc_string_buffer_size is the actual buffer size, rather than
6340 being 1 less than the actual buffer size; this makes xpalloc more
6341 convenient.
6342
a69fbedb
PE
6343 * image.c (x_allocate_bitmap_record, cache_image):
6344 * xselect.c (Fx_register_dnd_atom):
6345 Simplify previous changes by using xpalloc.
6346
fe5c5d37
PE
6347 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6348 since either will do and ptrdiff_t is convenient with xpalloc.
6349
0065d054
PE
6350 * charset.c (charset_table_size)
6351 (struct charset_sort_data.priority): Now ptrdiff_t.
6352 (charset_compare): Don't overflow if priorities differ greatly.
6353 (Fsort_charsets): Don't assume list length fits in int.
6354 Check for size-calculation overflow when allocating sort data.
6355 (syms_of_charset): Allocate an initial charset table that is
6356 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6357
6358 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6359
6360 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6361 The actual value is always <= INT_MAX, and leaving it unsigned made
6362 overflow checking harder.
6363
6364 * dispextern.h (struct glyph_matrix.rows_allocated)
6365 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6366 with xpalloc. The values are still always <= INT_MAX.
6367
6368 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6369
6370 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6371 (SAFE_NALLOCA): New macro.
6372
6373 * region-cache.c (struct boundary.pos, find_cache_boundary)
6374 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6375 (set_cache_region, invalidate_region_cache)
6376 (revalidate_region_cache, know_region_cache, region_cache_forward)
6377 (region_cache_backward, pp_cache):
6378 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6379 so that ptrdiff_t * can be passed to xpalloc.
6380 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6381 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6382 (pp_cache): Don't assume cache_len fits in int.
6383 * region-cache.h: Adjust extern decls to match.
6384
6385 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6386 EMACS_INT, since either will do, for xpalloc.
6387
6388 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6389 (xnmalloc, xnrealloc, xpalloc): New functions.
6390
726e0ab1
PE
6391 * bidi.c (bidi_shelve_header_size): New constant.
6392 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6393 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6394
51f30bc5 6395 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6396 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6397 (overlay_strings):
6398 Don't update size of array until after memory allocation succeeds,
6399 because xmalloc/xrealloc may not return.
0065d054
PE
6400 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6401 now that we have proper integer overflow checking.
6402 (record_overlay_string, overlay_strings): Catch overflows when
6403 calculating size of overlay_str_buf.
726e0ab1 6404
0065d054
PE
6405 * callproc.c (Fcall_process): Check for size overflow when
6406 calculating size of args2.
6407 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6408 Normally we prefer signed values, but sticking with ptrdiff_t would
6409 require adding more-complicated checks.
726e0ab1
PE
6410
6411 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6412 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6413 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6414 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6415
6416 * character.c (Fstring): Check for size-calculation overflow.
6417
6418 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6419 unnecessary integer overflow. Check for size overflow.
6420 (encode_coding_object): Don't update size until xmalloc succeeds.
6421
6422 * composite.c (get_composition_id): Check for overflow in glyph
6423 length calculations.
6424
6425 Integer and memory overflow fixes for display code.
6426 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6427 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6428 (scrolling_window): Check for overflow in size calculations.
6429 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6430 Don't assume glyph table len fits in int.
6431 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6432 (row_table_size): Now ptrdiff_t, not int.
6433 (scrolling_window): Avoid overflow in size calculations.
6434 Don't update size until allocation succeeds.
6435 * fns.c (concat): Check for overflow in size calculations.
6436 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6437 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6438 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6439
6440 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6441 (get_doc_string): Check for size calculation overflow.
6442 Don't update size until allocation succeeds.
6443 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6444 EMACS_INT, where ptrdiff_t will do.
6445 (Fsubstitute_command_keys): Check for string overflow.
6446
6447 * editfns.c (set_time_zone_rule): Don't assume environment length
6448 fits in int.
6449 (message_length): Now ptrdiff_t, not int.
6450 (Fmessage_box): Don't update size until allocation succeeds.
6451 Don't assume message length fits in int.
6452 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6453
0065d054
PE
6454 * emacs.c (main): Do not reallocate argv, since there is a null at
6455 the end that can be overwritten, and this way there's no need to
6456 worry about size-calculation overflow.
6457 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6458
6459 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6460 alloc succeeds.
6461 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6462
6463 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6464 (x_set_scroll_bar_width, x_figure_window_size):
6465 Check for integer overflow.
6466 (x_set_alpha): Do not assume XINT fits in int.
6467
6468 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6469 This is for the members text_lines, text_cols, total_lines, total_cols,
6470 where the system imposes an 'int' limit.
6471
6472 * fringe.c (Fdefine_fringe_bitmap):
6473 Don't update size until alloc works.
6474
6475 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6476 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6477
6478 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6479 Check for size-calculation overflow.
6480 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6481 do, as we prefer signed integers.
6482 (id_to_widget.max_size, id_to_widget.used)
6483 (xg_store_widget_in_map, xg_remove_widget_from_map)
6484 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6485 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6486 Use and return ptrdiff_t, not int.
6487 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6488 * gtkutil.h: Change prototypes to match the above.
6489
6490 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6491 are duplicate now that they've been promoted to lisp.h.
6492 (x_allocate_bitmap_record, x_alloc_image_color)
6493 (make_image_cache, cache_image, xpm_load):
6494 Don't update size until alloc is done.
6495 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6496 (x_detect_edges):
3256efce 6497 Check for size calculation overflow.
726e0ab1
PE
6498 (ct_colors_allocated_max): New constant.
6499 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6500 overflow.
3256efce 6501
726e0ab1
PE
6502 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6503 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6504 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6505 Use ptrdiff_t, not int, to count maps.
6506 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6507 calculations. Don't update size until allocation succeeds.
6508 Redo calculations to avoid overflow.
726e0ab1
PE
6509 * keyboard.h: Change prototypes to match the above.
6510
6511 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6512 to count maps.
6513 (current_minor_maps): Check for size calculation overflow.
6514 * keymap.h: Change prototypes to match the above.
6515
6516 * lread.c (read1, init_obarray): Don't update size until alloc done.
6517
6518 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6519 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6520
726e0ab1
PE
6521 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6522 Now ptrdiff_t, not int.
6523 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6524 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6525
6526 * process.c (Fnetwork_interface_list): Check for overflow
6527 in size calculation.
6528
6529 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6530
6531 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6532 overflow. Don't bother calling xmalloc when xrealloc will do.
6533
6534 * search.c (Freplace_match): Check for size calculation overflow.
6535 (Fset_match_data): Don't assume list lengths fit in 'int'.
6536
6537 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6538 for command line length. Do not attempt to address one before the
6539 beginning of an array, as that's not portable.
6540
6541 * term.c (max_frame_lines): Remove; unused.
6542 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6543 not int.
6544 (encode_terminal_code, calculate_costs): Check for size
6545 calculation overflow.
6546 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6547 table lengths and related sizes. Don't update size until alloc
6548 done. Redo calculations to avoid overflow.
6549 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6550
6551 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6552 subtracting pointers.
6553 (gobble_line): Check for overflow more carefully. Don't update size
6554 until alloc done.
6555
6556 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6557 Don't update size until alloc done.
6558 Redo size calculations to avoid overflow.
6559 Check for size calculation overflow.
0065d054 6560 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6561
6562 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6563 Use ptrdiff_t, not int, for sizes.
6564 (store_mode_line_noprop_char): Don't update size until alloc done.
6565
0065d054
PE
6566 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6567 Use ptrdiff_t, not int, for sizes.
6568 (Finternal_make_lisp_face, cache_face):
6569 Check for size calculation overflow.
6570 (cache_face): Treat size calculation overflows as if they were
6571 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6572
6573 * xfns.c (x_encode_text, x_set_name_internal)
6574 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6575 sizes, since they can exceed INT_MAX in size. Check for size
6576 calculation overflow.
6577
0065d054
PE
6578 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6579 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6580 Don't update size until alloc done.
6581
0065d054 6582 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6583 as sprintf is limited to int lengths.
1d526e2f 6584
252c5ee1
PE
6585 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6586 (X_LONG_MIN): New macros.
864d7ce7
PE
6587 Use them to make the following changes clearer.
6588 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6589 This change doesn't affect the value now, but it may help remind
6590 future maintainers not to raise the value too much later.
6591 (SELECTION_QUANTUM): Remove, replacing with ...
6592 (selection_quantum): ... new function, which avoids overflow.
6593 All uses changed.
6594 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6595 assumption that selection length fits in 'int'.
6596 (x_reply_selection_request, x_handle_selection_request)
6597 (x_get_window_property, receive_incremental_selection)
6598 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6599 (lisp_data_to_selection_data, clean_local_selection_data):
6600 Use ptrdiff_t, not int, to record length of selection.
6601 (x_reply_selection_request, x_get_window_property)
6602 (receive_incremental_selection, x_property_data_to_lisp):
6603 Redo calculations to avoid overflow.
6604 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6605 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6606 something.
6607 (x_get_window_property, receive_incremental_selection)
6608 (lisp_data_to_selection_data, x_property_data_to_lisp):
6609 Check for size-calculation overflow.
6610 (x_get_window_property, receive_incremental_selection)
6611 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6612 Don't store size until memory allocation succeeds.
6613 (x_get_window_property): Plug memory leak on memory exhaustion.
6614 Don't double-block input; malloc is safe here. Don't assume 2**34
6615 - 4 fits in unsigned long. Add an xassert to check
6616 XGetWindowProperty overflow. Be more careful about overflow
6617 calculations, and distinguish size from memory overflow better.
6618 (receive_incremental_selection): When tracing, don't assume
6619 unsigned int is less than INT_MAX.
6620 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6621 harmful) conversions of unsigned short to int.
6622 (lisp_data_to_selection_data): Don't assume that integers
6623 in the range -65535 through -1 fit in an X unsigned short.
6624 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6625 result parameters unless successful. Rely on cons_to_unsigned
6626 to report problems with elements; the old code wasn't right anyway.
6627 (x_check_property_data): Check for int overflow; we cannot use
6628 a wider type due to X limits.
6629 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6630
726e0ab1 6631 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6632
0065d054
PE
6633 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6634 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6635 (x_color_cells): Don't store size until memory allocation succeeds.
6636 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6637 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6638 (x_term_init): Don't assume length fits in int (sprintf is limited
6639 to int size).
bc18e09d 6640
ebfa62c0
PE
6641 Use ptrdiff_t for composition IDs.
6642 * character.c (lisp_string_width):
6643 * composite.c (composition_table_size, n_compositions)
6644 (get_composition_id, composition_gstring_from_id):
6645 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6646 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6647 * window.c (Frecenter):
6648 Use ptrdiff_t, not int, for composition IDs.
6649 * composite.c (get_composition_id): Check for integer overflow.
6650 * composite.h: Adjust prototypes to match the above changes.
6651
d3411f89
PE
6652 Use ptrdiff_t for hash table indexes.
6653 * category.c (hash_get_category_set):
6654 * ccl.c (ccl_driver):
6655 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6656 * coding.c (coding_system_charset_list, detect_coding_system):
6657 * coding.h (struct coding_system.id):
6658 * composite.c (get_composition_id, gstring_lookup_cache):
6659 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6660 * image.c (xpm_get_color_table_h):
6661 * lisp.h (hash_lookup, hash_put):
6662 * minibuf.c (Ftest_completion):
6663 Use ptrdiff_t for hash table indexes, not int (which is too
6664 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6665 32-bit --with-wide-int hosts).
6666
e097a6fa
PE
6667 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6668 Add a FIXME comment about memory leaks.
6669 (syms_of_charset): Don't assume xmalloc returns.
6670
5637687f
PE
6671 Don't assume that stated character widths fit in int.
6672 * character.c (Fchar_width, c_string_width, lisp_string_width):
6673 * character.h (CHAR_WIDTH):
6674 * indent.c (MULTIBYTE_BYTES_WIDTH):
6675 Use sanitize_char_width to avoid undefined and/or bad behavior
6676 with outlandish widths.
a66cfb1c 6677 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6678 now that we have two such functions. All uses changed.
6679 (sanitize_char_width): New inline function.
6680
a2271ba2
PE
6681 Don't assume that tab-width fits in int.
6682 * character.h (sanitize_width): New inline function.
6683 (SANE_TAB_WIDTH): New macro.
6684 (ASCII_CHAR_WIDTH): Use it.
6685 * indent.c (sane_tab_width): Remove. All uses replaced by
6686 SANE_TAB_WIDTH (current_buffer).
6687 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6688
18c52557
PE
6689 * fileio.c: Integer overflow issues with file modes.
6690 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6691
caeeedc1
PE
6692 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6693 Remove unreachable code.
6694 (read_hex, load_charset_map_from_file): Check for integer overflow.
6695
6df6ae42 6696 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6697 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6698 (x_send_scroll_bar_event): Likewise. Check that the size does not
6699 exceed limits imposed by XClientMessageEvent, as well as the usual
6700 ptrdiff_t and size_t limits.
6701
b13995db
PE
6702 * keyboard.c: Overflow, signedness and related fixes.
6703 (make_lispy_movement): Use same integer type in forward decl
6704 that is used in the definition.
6705 (read_key_sequence, keyremap_step):
6706 Change bufsize argument back to int, undoing my 2011-03-30 change.
6707 We prefer signed types, and int is wide enough here.
6708 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6709 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6710 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6711 length, not size_t. Use ptrdiff_t for index, not int.
6712 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6713 possibility of integer overflow.
6714
13464394
PE
6715 Overflow, signedness and related fixes for images.
6716
6717 * dispextern.h (struct it.stack[0].u.image.image_id)
6718 (struct_it.image_id, struct image.id, struct image_cache.size)
6719 (struct image_cache.used, struct image_cache.ref_count):
6720 * gtkutil.c (update_frame_tool_bar):
6721 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6722 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6723 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6724 * nsmenu.m (update_frame_tool_bar):
6725 * xdisp.c (calc_pixel_width_or_height):
6726 * xfns.c (image_cache_refcount):
6727 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6728 on typical 64-bit hosts.
6729
6730 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6731 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6732 Omit unnecessary casts to int.
6733 (parse_image_spec): Check that integers fall into 'int' range
6734 when the callers expect that.
6735 (image_ascent): Redo ascent calculation to avoid int overflow.
6736 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6737 (lookup_image): Remove unnecessary tests.
6738 (xbm_image_p): Locals are now of int, not EMACS_INT,
6739 since parse_image_check makes sure they fit into int.
6740 (png_load, gif_load, svg_load_image):
6741 Prefer int to unsigned where either will do.
6742 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6743 old tiff_error_handler and tiff_warning_handler.
6744 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6745 stack buffer overflows. It uses only the features of vsnprintf
6746 that are common to both POSIX and native Microsoft.
6747 (tiff_error_handler, tiff_warning_handler): Use it.
6748 (tiff_load, gif_load, imagemagick_load_image):
6749 Don't assume :index value fits in 'int'.
6750 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6751 (imagemagick_load_image): Check that crop parameters fit into
6752 the integer types that MagickCropImage accepts. Don't assume
6753 Vimagemagick_render_type has a nonnegative value. Don't assume
6754 size_t fits in 'long'.
6755 (gs_load): Use printmax_t to print the widest integers possible.
6756 Check for integer overflow when computing image height and width.
6757
c11821d4
EZ
67582011-08-26 Eli Zaretskii <eliz@gnu.org>
6759
6760 * xdisp.c (redisplay_window): Don't force window start if point
6761 will be invisible in the resulting window. (Bug#9324)
6762
0c95fcf7
EZ
67632011-08-25 Eli Zaretskii <eliz@gnu.org>
6764
6765 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6766 the display spec is of the form `(space ...)'.
6767 (handle_display_spec): Return the value returned by
6768 handle_single_display_spec, not just 1 or zero.
6769 (handle_single_display_spec): If the display spec is of the form
6770 `(space ...)', and specifies display in the text area, return 2
6771 rather than 1.
fee65a97 6772 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6773 accurately, and prefer exact match for point under bidi.
6774 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6775
6776 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6777 into disp_prop; all users changed.
6778
6779 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6780 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6781 for the text covered by the display property.
6782
e4ed06f1
CY
67832011-08-25 Chong Yidong <cyd@stupidchicken.com>
6784
6785 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6786 Change return value to nil.
6787 (Frecord_buffer): Delete unused function.
6788
f67cdd7f
EZ
67892011-08-24 Eli Zaretskii <eliz@gnu.org>
6790
5980d4c6
EZ
6791 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6792 buffers, return left-to-right.
8610fe8b
EZ
6793 (set_cursor_from_row): Consider candidate row a win if its glyph
6794 represents a newline and point is on that newline. Fixes cursor
6795 positioning on the newline at EOL of R2L text within L2R
6796 paragraph, and vice versa.
6797 (try_cursor_movement): Check continued rows, in addition to
6798 continuation rows. Fixes unwarranted scroll when point enters a
6799 continued line of R2L text within an L2R paragraph, or vice versa.
6800 (cursor_row_p): Consider the case of point being equal to
6801 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6802 from the end of a short line to the beginning of a continued line
6803 of R2L text within L2R paragraph.
6804 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6805 composed characters.
5980d4c6 6806
f67cdd7f
EZ
6807 * bidi.c (bidi_check_type): Use xassert.
6808 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6809 members.
6810
bca633fb
EZ
68112011-08-23 Eli Zaretskii <eliz@gnu.org>
6812
6813 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6814 a character.
6815
4a5885a7
CY
68162011-08-23 Chong Yidong <cyd@stupidchicken.com>
6817
6818 * nsfont.m (ns_otf_to_script): Fix typo.
6819
0902a04e
KH
68202011-08-22 Kenichi Handa <handa@m17n.org>
6821
6822 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6823 extra slot even if the purpose is char-code-property-table.
6824
1a2e6670
EZ
68252011-08-23 Eli Zaretskii <eliz@gnu.org>
6826
8ddde651
EZ
6827 * xdisp.c (redisplay_window): When computing centering_position,
6828 account for the height of the header line. (Bug#8874)
6829
425cc014
EZ
6830 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6831 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6832 candidate is selected by the mouse, and that candidate has a
6833 composed character under the mouse.
6834
1a2e6670
EZ
6835 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6836 coordinates reported by pos-visible-in-window-p for a composed
6837 character in column zero.
6838
8b76d6f8
SM
68392011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6840
6841 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6842
dac347dd
EZ
68432011-08-22 Eli Zaretskii <eliz@gnu.org>
6844
6845 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6846 consider it a hit if to_charpos is anywhere in the range of the
6847 composed buffer positions.
6848
e013fb34
CY
68492011-08-22 Chong Yidong <cyd@stupidchicken.com>
6850
6851 * image.c (gif_load): Don't assume that each subimage has the same
6852 dimensions as the base image. Handle disposal method that is
6853 "undefined" by the gif spec (Bug#9335).
6854
bd1ba3e8
CY
68552011-08-20 Chong Yidong <cyd@stupidchicken.com>
6856
6857 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6858 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6859
54a1215b
EZ
68602011-08-19 Eli Zaretskii <eliz@gnu.org>
6861
823564e5
EZ
6862 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6863 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6864 from an Org mode buffer to a Speedbar frame.
6865
54a1215b
EZ
6866 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6867 a composition, take its buffer position from IT->cmp_it.charpos.
6868 Fixes cursor positioning at the beginning of a line that begins
6869 with a composed character.
6870
9778ebcc
EZ
68712011-08-18 Eli Zaretskii <eliz@gnu.org>
6872
0be6ee06
EZ
6873 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6874 character bidirectional type, use STRONG_L instead. Fixes crashes
6875 in a buffer produced by `describe-categories'.
6876
9778ebcc
EZ
6877 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6878 members before the level stack, so they would be saved and
6879 restored when copying iterator state. Fixes incorrect reordering
6880 around TABs covered by display properties.
6881
156bffbe
AS
68822011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6883
6b02f655 6884 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6885
72ad093b
CY
68862011-08-17 Chong Yidong <cyd@stupidchicken.com>
6887
6888 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6889 (internal_condition_case_2, internal_condition_case_n):
6890 Remove unnecessary aborts (Bug#9081).
72ad093b 6891
35774242
EZ
68922011-08-17 Eli Zaretskii <eliz@gnu.org>
6893
6894 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6895 has no `load' handler, try opening the file locally. (Bug#9311)
6896
db76dd85
KB
68972011-08-16 Ken Brown <kbrown@cornell.edu>
6898
6899 * gmalloc.c: Expand comment.
6900
b215eee5
EZ
69012011-08-16 Eli Zaretskii <eliz@gnu.org>
6902
6903 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6904 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6905
a4579d33
KB
69062011-08-16 Ken Brown <kbrown@cornell.edu>
6907
6908 Fix memory allocation problems in Cygwin build (Bug#9273).
6909
6910 * unexcw.c ( __malloc_initialized): Declare external variable.
6911 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6912
8b76d6f8
SM
6913 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6914 New variables.
a4579d33
KB
6915 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6916 dumped emacs.
6917 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6918 in the static heap.
6919 [CYGWIN] (special_realloc): New function.
6920 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6921 requests to realloc storage in the static heap.
6922
3ebec551
PE
69232011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 * bidi.c (bidi_initialize): Remove unused local.
6926
9fd8be00
EZ
69272011-08-15 Eli Zaretskii <eliz@gnu.org>
6928
6b02f655
SM
6929 * bidimirror.h:
6930 * biditype.h: Remove file.
6931 * makefile.w32-in ($(BLD)/bidi.$(O)):
6932 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6933
6934 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6935
6936 * chartab.c: Improve commentary for the uniprop_table API.
6937
32413314
EZ
6938 * bidi.c (bidi_paragraph_init): Support zero value of
6939 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6940 (bidi_initialize): Use uniprop_table instead of including
6941 biditype.h and bidimirror.h.
32413314 6942
9fd8be00
EZ
6943 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6944 coordinates of the iterator when restoring from ppos_it.
6945 (Bug#9296)
6946
5cf2b69b
KH
69472011-08-14 Kenichi Handa <handa@m17n.org>
6948
6949 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6950 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6951
daf17d00
EZ
69522011-08-14 Eli Zaretskii <eliz@gnu.org>
6953
6954 * xdisp.c (move_it_in_display_line_to): Don't invoke
6955 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6956 ppos_it. Fixes vertical cursor motion when line beginning is
6957 covered by an image. (Bug#9296)
6958
08e3161a
JD
69592011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6960
6961 * nsterm.h (ns_run_ascript): Declare.
6962 (NSAPP_DATA2_RUNASSCRIPT): Define.
6963
6964 * nsfns.m (as_script, as_result, as_status): New static variables.
6965 (ns_run_ascript): New function.
5e617bc2 6966 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6967 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6968 the event loop. Get status from as_status (Bug#7276).
6969
6970 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6971 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6972 the event loop (Bug#7276).
6973
a3720aa2
AS
69742011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6975
6976 * gnutls.c (QCgnutls_bootprop_priority)
6977 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6978 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6979 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6980 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6981 (QCgnutls_bootprop_verify_hostname_error)
6982 (QCgnutls_bootprop_callbacks_verify): Rename from
6983 Qgnutls_bootprop_..., all uses changed.
6984
6985 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6986 uses changed.
6987
0a0d27fb
PE
69882011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6989
19d5c50c
PE
6990 * xfaces.c (Qframe_set_background_mode): Now static.
6991 * dispextern.h (Qframe_set_background_mode): Remove decl.
6992
0a0d27fb
PE
6993 * process.c (Fnetwork_interface_info): Declare local only if needed.
6994
377538cb
JD
69952011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6996
6997 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6998 (Fnetwork_interface_list): Allocate in increments of bytes instead
6999 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7000 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7001 sockaddr.
7002 (struct ifflag_def): notrailers is smart on OSX.
7003 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7004 Get hardware address with getifaddrs if available.
7005
08fff70c
EZ
70062011-08-12 Eli Zaretskii <eliz@gnu.org>
7007
7008 * xdisp.c (iterate_out_of_display_property): xassert that
7009 IT->position is set to within IT->object's boundaries. Break from
7010 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7011 when IT->position is set up wrongly due to some bug.
7012 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7013 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7014 entry. Force push_it to save on the stack the current
7015 buffer/string position, to be restored by pop_it. Fix flags in
7016 the iterator structure wrt the object coming from a display
7017 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7018 properties. (Bug#9284)
7019
7be1c708 70202011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7021
7be1c708
CY
7022 * fontset.c (fontset_get_font_group): Add proper type checks.
7023 (Bug#9172)
aac0c6e3 7024
7be1c708 70252011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7026
7be1c708
CY
7027 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7028 and LC_VERSION_MIN_MACOSX.
7029 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7030 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7031
97bb72a6
EZ
70322011-08-08 Eli Zaretskii <eliz@gnu.org>
7033
7034 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7035 no-display-properties-and-no-overlays under bidi display.
7036 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7037 properties and overlays.
97bb72a6 7038
d5617611
CY
70392011-08-08 Chong Yidong <cyd@stupidchicken.com>
7040
37e11a63
CY
7041 * editfns.c (Fset_time_zone_rule): Document relationship with the
7042 setenv function.
7043
d5617611
CY
7044 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7045 the font entity extracted from the cache (Bug#8109).
7046
58872834
CY
70472011-08-07 Chong Yidong <cyd@stupidchicken.com>
7048
7049 * composite.c (autocmp_chars): Don't reset point. That is done by
7050 restore_point_unwind (Bug#5984).
7051
75bfc667
JL
70522011-08-07 Juri Linkov <juri@jurta.org>
7053
7054 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7055 to show the arg `TIME' instead of `TIMEVAL'.
7056
d1410150
EZ
70572011-08-06 Eli Zaretskii <eliz@gnu.org>
7058
7059 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7060 display property strides EOL and includes a newline, as in
7061 longlines-mode. (Bug#9254)
75b771e4
EZ
7062 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7063 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7064
7065 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7066 is non-zero, even if the data buffer is NULL. Fixes a crash in
7067 vertical-motion with longlines-mode. (Bug#9254)
7068
35928349
EZ
70692011-08-05 Eli Zaretskii <eliz@gnu.org>
7070
ec7cc85b
EZ
7071 * bidi.c <bidi_cache_total_alloc>: Now static.
7072 (bidi_initialize): Initialize bidi_cache_total_alloc.
7073
8b76d6f8 7074 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7075 cache. (Bug#9221)
7076
7077 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7078 amount allocated this far in `bidi_cache_total_alloc'.
7079 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7080 non-zero, only free the data buffer without restoring the cache
7081 contents. All callers changed.
7082
7083 * dispextern.h (bidi_unshelve_cache): Update prototype.
7084
7085 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7086 (move_it_in_display_line, move_it_to)
7087 (move_it_vertically_backward, move_it_by_lines): Replace the call
7088 to xfree to an equivalent call to bidi_unshelve_cache.
7089 (move_it_in_display_line_to): Fix logic of returning
412b6358 7090 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7091
e2e2423b
EZ
70922011-08-05 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7095 came from a string character with a `cursor' property. (Bug#9229)
7096
ae9e757a
JD
70972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7098
7099 * Makefile.in (LIB_PTHREAD): New variable.
7100 (LIBES): Add LIB_PTHREAD (Bug#9216).
7101
7102 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7103 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7104
213bd7f2
AS
71052011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7106
6b02f655 7107 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7108
99aaf75f
JD
71092011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7110
7111 * xterm.c (x_find_topmost_parent): New function.
7112 (x_set_frame_alpha): Find topmost parent window with
7113 x_find_topmost_parent and set the property there also (bug#9181).
7114 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7115
c74e9d86
PE
71162011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7117
7118 * callproc.c (Fcall_process): Avoid vfork clobbering
7119 the local vars buffer, coding_systems, current_dir.
7120
640c8776
SM
71212011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7122
7123 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7124
f26d0e4c
PE
71252011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7126
8a10d76c
PE
7127 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7128 so that it is not optimized away.
7129
f26d0e4c
PE
7130 * xdisp.c (compute_display_string_pos): Remove unused local.
7131
55439c61
EZ
71322011-08-02 Eli Zaretskii <eliz@gnu.org>
7133
7134 Fix slow cursor motion and scrolling in large buffers with
7135 selective display, like Org Mode buffers. (Bug#9218)
7136
7137 * dispextern.h (struct bidi_it): New member disp_prop_p.
7138
7139 * xdisp.c: Remove one-slot cache of display string positions.
7140 (compute_display_string_pos): Accept an additional argument
5e617bc2 7141 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7142 for a display string or property. If found, set DISP_PROP_P
7143 non-zero.
7144
7145 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7146 DISP_PROP_P, and pass it to compute_display_string_pos.
7147 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7148 non-zero. All callers of bidi_fetch_char changed.
7149
fb33fa43
SM
71502011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7151
7152 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7153
b099e063
DM
71542010-12-03 Don March <don@ohspite.net>
7155
7156 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7157 last character M-[char] is translated to ESC [char] (bug#7541).
7158
5cc7f7af
KH
71592011-08-02 Kenichi Handa <handa@m17n.org>
7160
d0fffa3f 7161 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7162
7163 * chartab.c (uniprop_table): Make it non-static.
7164
525d5e6e
EZ
71652011-08-01 Eli Zaretskii <eliz@gnu.org>
7166
7167 * xdisp.c (forward_to_next_line_start): Accept additional argument
7168 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7169 on the newline.
7170 (reseat_at_next_visible_line_start): Use the bidi iterator state
7171 returned by forward_to_next_line_start to restore the state of
7172 it->bidi_it after backing up to previous newline. (Bug#9212)
7173
31011111
AS
71742011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7175
7176 * regex.c (re_comp): Protoize.
7177 (re_exec): Fix return type.
7178 (regexec): Fix type of `ret'. (Bug#9203)
7179
476371c4
PE
71802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7181
e5d76069
PE
7182 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7183 This is needed if max-image-size is a floating-point number.
7184
9a79b20c
AS
71852011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7186
7187 * print.c (print_object): Print empty symbol as ##.
7188
7189 * lread.c (read1): Read ## as empty symbol.
7190
d8c2fa78
AA
71912011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7192
7193 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7194 setting frame foreground color (Bug#9175).
7195 (x_set_background_color): Likewise.
7196
ffe57a7a
AA
7197 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7198 contents (Bug#9176).
7199 (EmacsTooltip -init): Remove bezels and add shadows to
7200 tooltip windows.
7201
bf3492a5
AA
7202 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7203 or scroll bar (Bug#8470).
7204
d55e9c53
AA
7205 * nsfont.m (nsfont_open): Remove assignment to voffset and
7206 unnecessary vars hshink, expand, hd, full_height, min_height.
7207 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7208
7209 * nsterm.h (nsfont_info): Remove voffset field.
7210
d8c2fa78 72112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7212
7213 Implement strike-through and overline on NextStep (Bug#8863).
7214
7215 * nsfont.m (nsfont_open): Use underline position provided by font,
7216 instead of hard-coded value of 2.
7217 (nsfont_draw): Call ns_draw_text_decoration instead.
7218
7219 * nsterm.h: Add declaration for ns_draw_text_decoration.
7220
7221 * nsterm.m (ns_draw_text_decoration): New function for drawing
7222 underline, overline, and strike-through.
7223 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7224 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7225 accommodate underlining, etc.
4843aac3 7226
4cc60b9b
EZ
72272011-07-28 Eli Zaretskii <eliz@gnu.org>
7228
bc7ece87
EZ
7229 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7230 default.
4cc60b9b 7231
476371c4
PE
72322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7233
66606eea
PE
7234 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7235 Without this fix, if a signal arrives just after memory fills up,
7236 'malloc' might be invoked reentrantly.
7237
476371c4
PE
7238 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7239 In other words, assume that every image size is allowed, on non-X
7240 hosts. This assumption is probably wrong, but it lets Emacs compile.
7241
f3fcc40d
AS
72422011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7243
7244 * regex.c (re_iswctype): Convert return values to boolean.
7245
350c992f
EZ
72462011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7247
7248 * xdisp.c (compute_display_string_pos): Don't use cached display
7249 string position if the buffer had its restriction changed.
7250 (Bug#9184)
7251
5266b4bb
PE
72522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7253
7254 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7255
2573a837 72562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7257
41f55ccd 7258 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7259
39e378da
PE
7260 * bidi.c: Integer size and overflow fixes.
7261 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7262 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7263 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7264 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7265 (bidi_find_other_level_edge):
7266 Use ptrdiff_t instead of EMACS_INT where either will do.
7267 This works better on 32-bit hosts configured --with-wide-int.
7268 (bidi_cache_ensure_space): Check for size-calculation overflow.
7269 Use % rather than repeated addition, for better worst-case speed.
7270 Don't set bidi_cache_size until after xrealloc returns, because it
7271 might not return.
7272 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7273 (bidi_cache_ensure_space): Also check that the bidi cache size
7274 does not exceed that of the largest Lisp string or buffer. See Eli
7275 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7276
5e927815
PE
7277 * alloc.c (__malloc_size_t): Remove.
7278 All uses replaced by size_t. See Andreas Schwab's note
7279 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7280
ca4aa935
PE
7281 * image.c: Improve checking for integer overflow.
7282 (check_image_size): Assume that f is nonnull, since
7283 it is always nonnull in practice. This is one less thing to
7284 worry about when checking for integer overflow later.
7285 (x_check_image_size): New function, which checks for integer
7286 overflow issues inside X.
7287 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7288 This removes the need for a memory_full check.
7289 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7290 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7291 (xbm_read_bitmap_data): Change locals back to 'int', since
7292 their values must fit in 'int'.
7293 (xpm_load_image, png_load, tiff_load):
7294 Invoke x_create_x_image_and_pixmap earlier,
7295 to avoid much needless work if the image is too large.
7296 (tiff_load): Treat overly large images as if
7297 x_create_x_image_and_pixmap failed, not as malloc failures.
7298 (gs_load): Use x_check_image_size.
7299
5f8f9cc2
PE
7300 * gtkutil.c: Omit integer casts.
7301 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7302 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7303
5adf60bc
PE
7304 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7305
c8907a93
PE
7306 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7307 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7308 would wrongly return t on a 64-bit host.
7309
e3c25c68
PE
7310 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7311 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7312 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7313 and therefore cause GCC to emit a bogus diagnostic in some cases.
7314
3f791afe
PE
7315 * image.c: Integer signedness and overflow and related fixes.
7316 This is not an exhaustive set of fixes, but it's time to
7317 record what I've got.
7318 (lookup_pixel_color, check_image_size): Remove redundant decls.
7319 (check_image_size): Don't assume that arbitrary EMACS_INT values
7320 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7321 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7322 (tiff_load, imagemagick_load_image):
7323 Check for overflow in size calculations.
7324 (x_create_x_image_and_pixmap): Remove unnecessary test for
7325 xmalloc returning NULL; that can't happen.
7326 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7327 (xpm_color_bucket): Use better integer hashing function.
7328 (xpm_cache_color): Don't possibly over-allocate memory.
7329 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7330 (gif_memory_source):
7331 Use ptrdiff_t, not int or size_t, to record sizes.
7332 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7333 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7334 either works, as we prefer signed integers.
7335 (tiff_read_from_memory, tiff_write_from_memory):
7336 Return tsize_t, not size_t, since that's what the TIFF API wants.
7337 (tiff_read_from_memory): Don't fail simply because the read would
7338 go past EOF; instead, return a short read.
7339 (tiff_load): Omit no-longer-needed casts.
7340 (Fimagemagick_types): Don't assume size fits into 'int'.
7341
3cc5a532
PE
7342 Improve hashing quality when configured --with-wide-int.
7343 * fns.c (hash_string): New function, taken from sxhash_string.
7344 Do not discard information about ASCII character case; this
7345 discarding is no longer needed.
7346 (sxhash-string): Use it. Change sig to match it. Caller changed.
7347 * lisp.h: Declare it.
7348 * lread.c (hash_string): Remove, since we now use fns.c's version.
7349 The fns.c version returns a wider integer if --with-wide-int is
7350 specified, so this should help the quality of the hashing a bit.
7351
b312a492
PE
7352 * emacs.c: Integer overflow minor fix.
7353 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7354 Define only if GNU_LINUX.
7355 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7356
dfd153ae
PE
7357 * dispnew.c: Integer signedness and overflow fixes.
7358 Remove unnecessary forward decls, that were a maintenance hassle.
7359 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7360 All uses changed.
7361 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7362 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7363 (prepare_desired_row, line_draw_cost):
7364 Use int, not unsigned, where either works.
7365 (save_current_matrix, restore_current_matrix):
7366 Use ptrdiff_t, not size_t, where either works.
7367 (init_display): Check for overflow more accurately, and without
7368 relying on undefined behavior.
7369
a81d11a3
PE
7370 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7371 Remove, replacing with the new symbols in lisp.h. All uses changed.
7372 * fileio.c (make_temp_name):
7373 * filelock.c (lock_file_1, lock_file):
7374 * xdisp.c (message_dolog):
7375 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7376 Use pMd etc. instead.
7377 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7378 replacing the pWIDE etc. symbols removed from editfns.c.
7379
3300e6fd
PE
7380 * keyboard.h (num_input_events): Now uintmax_t.
7381 This is (very slightly) less likely to mess up due to wraparound.
7382 All uses changed.
7383
fd05c7e9
PE
7384 * buffer.c: Integer signedness fixes.
7385 (alloc_buffer_text, enlarge_buffer_text):
7386 Use ptrdiff_t rather than size_t when either will do, as we prefer
7387 signed integers.
7388
903fe15d
PE
7389 * alloc.c: Integer signedness and overflow fixes.
7390 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7391 (__malloc_size_t): Default to size_t, not to int.
7392 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7393 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7394 Prefer ptrdiff_t to size_t when either would do, as we prefer
7395 signed integers.
7396 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7397 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7398 Now const. Initialize with values that are in range even if char
7399 is signed.
7400 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7401 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7402 These functions do the right thing with sizes > 2**32.
7403 (check_depth): Now ptrdiff_t, not int.
7404 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7405 Adjust to new way of storing sizes. Check for size overflow bugs
7406 in rest of code.
7407 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7408 slightly wrong anyway, as it missed one instance of
7409 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7410 (refill_memory_reserve): Omit needless cast to size_t.
7411 (mark_object_loop_halt): Mark as externally visible.
7412
ac82cc6a
PE
7413 * xselect.c: Integer signedness and overflow fixes.
7414 (Fx_register_dnd_atom, x_handle_dnd_message):
7415 Use ptrdiff_t, not size_t, since we prefer signed.
7416 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7417 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7418 x_dnd_atoms_size and x_dnd_atoms_length.
7419
c2d1e36d
PE
7420 * doprnt.c: Prefer signed to unsigned when either works.
7421 * eval.c (verror):
7422 * doprnt.c (doprnt):
7423 * lisp.h (doprnt):
7424 * xdisp.c (vmessage):
7425 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7426 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7427 prefer signed arithmetic to avoid comparison confusion.
7428 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7429 but is a bit tricky.
7430
0e926e56
PE
7431 Assume freestanding C89 headers, string.h, stdlib.h.
7432 * data.c, doprnt.c, floatfns.c, print.c:
7433 Include float.h unconditionally.
7434 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7435 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7436 * regex.c: Likewise for stddef.h, string.h.
7437 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7438 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7439 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7440 (STDC_HEADERS): Remove obsolete defines.
7441 * sysdep.c: Include limits.h unconditionally.
7442
9cfdb3ec
PE
7443 Assume support for memcmp, memcpy, memmove, memset.
7444 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7445 * regex.c (memcmp, memcpy):
7446 Remove; we assume C89 now.
7447
7448 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7449 (__malloc_safe_bcopy): Remove; no longer needed.
7450
cf950e6b 7451 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7452 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7453 well either way, and we prefer signed to unsigned.
7454
dbf38e02
LMI
74552011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7456
7457 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7458 closes the connection while we're reading (bug#9182).
7459
d6f0886c 74602011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7461
d6f0886c
JD
7462 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7463 are specified (Bug#9168).
24e0f6b1 7464
2eb1f9e6
PE
74652011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7466
7467 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7468 Found by GCC static checking and --with-wide-int on a 32-bit host.
7469
22381272 74702011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7471
7472 * xdisp.c (compute_display_string_pos): Fix logic of caching
7473 previous display string position. Initialize cached_prev_pos to
7474 -1. Fixes slow-down at the beginning of a buffer.
7475
f25e39b4
EZ
74762011-07-24 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7479 for attrs[LFACE_FONTSET_INDEX].
7480
04c4b52e
PE
74812011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7482
7483 * xml.c (parse_region): Remove unused local
7484 that was recently introduced.
7485
c1734fbd
EZ
74862011-07-23 Eli Zaretskii <eliz@gnu.org>
7487
be18c5a5
EZ
7488 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7489 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7490
c1734fbd
EZ
7491 * xdisp.c (move_it_in_display_line_to): Record the best matching
7492 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7493 exit if none of the characters scanned was an exact match.
7494 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7495 when exact match is impossible due to invisible text, and the
7496 lines are truncated.
7497
a258d627
JD
74982011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7499
7500 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7501 for OSX >= 10.7.
7502
b6d5a689
EZ
75032011-07-22 Eli Zaretskii <eliz@gnu.org>
7504
0f74f785
EZ
7505 Fix a significant slow-down of cursor motion with C-n, C-p,
7506 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7507 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7508 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7509 (next_element_from_buffer): Call compute_stop_pos_backwards to
7510 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7511 base_level_stop.
7512 (reseat): Don't look for prev_stop, as that could mean a very long
7513 run.
7514 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7515 <cached_disp_overlay_modiff>: Cache for last found display string
7516 position.
551918c1 7517 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7518 about the same buffer in the same area of character positions, and
7519 the buffer wasn't changed since the time the display string
7520 position was cached.
551918c1 7521
b2d0c91a
EZ
75222011-07-22 Eli Zaretskii <eliz@gnu.org>
7523
7524 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7525 is an integer, which is important for empty lines. (Bug#9149)
7526
043604ee
CY
75272011-07-22 Chong Yidong <cyd@stupidchicken.com>
7528
7529 * frame.c (Fmodify_frame_parameters): In tty case, update the
7530 default face if necessary (Bug#4238).
7531
da4adb04
CY
75322011-07-21 Chong Yidong <cyd@stupidchicken.com>
7533
7534 * editfns.c (Fstring_to_char): No need to explain what a character
7535 is in the docstring (Bug#6576).
7536
9abd0532
LMI
75372011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7538
7539 * xml.c (parse_region): Make sure we always return a tree.
7540
36881d16
HK
75412011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7542
7543 * xml.c (parse_region): If a document contains only comments,
7544 return that, too.
7545
1e98674d
LMI
75462011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7547
7548 * xml.c (make_dom): Return comments, too.
7549
590bd467
PE
75502011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7551
7552 Port to OpenBSD.
7553 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7554 and the surrounding thread.
7555 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7556 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7557 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7558 timer goes off.
7559 * s/openbsd.h (BROKEN_SIGIO): Define.
7560 * unexelf.c (unexec) [__OpenBSD__]:
7561 Don't update the .mdebug section of the Alpha COFF symbol table.
7562
f41628b2
LMI
75632011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7564
7565 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7566 (bug#8460).
7567
b59b67c5
PE
75682011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7569
15e3a074
PE
7570 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7571 This fixes some race conditions on the permissions of any newly
7572 created file.
7573
41bed37d
PE
7574 * alloc.c (valid_pointer_p): Use pipe, not open.
7575 This fixes some permissions issues when debugging.
7576
b59b67c5
PE
7577 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7578 If fchown fails to set both uid and gid, try to set just gid,
7579 as that is sometimes allowed. Adjust the file's mode to eliminate
7580 setuid or setgid bits that are inappropriate if fchown fails.
7581
925a6be7
SM
75822011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7583
7584 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7585 to compare Lisp_Objects.
7586 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7587 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7588 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7589
52968808
AS
75902011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7591
0a6a104b
AS
7592 * lread.c (read_integer): Unread even EOF character.
7593 (read1): Likewise. Properly record start position of symbol.
7594
52968808
AS
7595 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7596 symbol character follows.
7597
9e381cdd
PE
75982011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7599
7600 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7601 This works around a problem with the previous change to Fcopy_file.
7602 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7603 and without this change, GCC might complain about discarding
7604 fchown's return value.
7605
b5641435
JB
76062011-07-16 Juanma Barranquero <lekktu@gmail.com>
7607
7608 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7609
a8031457
PE
76102011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7611
7612 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7613
dd889327
LMI
76142011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7615
750c33f7
LMI
7616 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7617 it's used from the C level.
7618
dd889327
LMI
7619 * process.c: Use the same condition for POLL_FOR_INPUT in both
7620 keyboard.c and process.c (bug#1858).
7621
87e86684
LM
76222011-07-09 Lawrence Mitchell <wence@gmx.li>
7623
7624 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7625 (Fgnutls_boot): Use it.
7626
64348f40
AS
76272011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7628
7629 * doc.c (Fsubstitute_command_keys): Revert last change.
7630
1d698799
LMI
76312011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7632
f863868c
LMI
7633 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7634 quotes the next character, and doesn't affect other longer
7635 sequences (bug#8935).
7636
1d698799
LMI
7637 * lread.c (syms_of_lread): Clarify that is isn't only
7638 `eval-buffer' and `eval-defun' that's affected by
7639 `lexical-binding' (bug#8460).
7640
aa4b6df6
EZ
76412011-07-15 Eli Zaretskii <eliz@gnu.org>
7642
7643 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7644 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7645
5d856da6
PE
76462011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7647
ad6042bb
PE
7648 Fix minor problems found by static checking.
7649 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7650 (elsz): Now a signed constant, not a size_t var. We prefer signed
7651 types to unsigned, to avoid integer comparison confusion. Without
7652 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7653 "cannot optimize loop, the loop counter may overflow", a symptom
7654 of the confusion.
f00bbb22 7655 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7656 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7657
6468f31c
LMI
76582011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7659
49080b10
LMI
7660 * search.c (Fre_search_backward): Mention `case-fold-search' in
7661 all the re_search_* functions (bug#8138).
7662
6468f31c
LMI
7663 * keyboard.c (Fopen_dribble_file): Document when the file is
7664 closed (bug#8056).
7665
c965adc5
EZ
76662011-07-14 Eli Zaretskii <eliz@gnu.org>
7667
df9733bf
EZ
7668 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7669 bidi_cache_idx.
7670
0bb23927
EZ
7671 Support bidi reordering of display and overlay strings.
7672 * xdisp.c (compute_display_string_pos)
7673 (compute_display_string_end): Accept additional argument STRING.
7674 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7675 (reseat_to_string): Initialize bidi_it->string.s and
7676 bidi_it->string.schars.
7677 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7678 NULL (avoids a crash in bidi_paragraph_init).
7679 Initialize itb.string.lstring.
0bb23927
EZ
7680 (init_iterator): Call bidi_init_it only of a valid
7681 buffer position was specified. Initialize paragraph_embedding to
7682 L2R.
7683 (reseat_to_string): Initialize the bidi iterator.
7684 (display_string): If we need to ignore text properties of
7685 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7686 original value of -1 will not work with bidi.)
7687 (compute_display_string_pos): First arg is now struct
7688 `text_pos *'; all callers changed. Support display properties on
7689 Lisp strings.
7690 (compute_display_string_end): Support display properties on Lisp
7691 strings.
7692 (init_iterator, reseat_1, reseat_to_string): Initialize the
7693 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7694 when iterating on a string not from display properties).
640c8776
SM
7695 (compute_display_string_pos, compute_display_string_end):
7696 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7697 arrow keys.
7698 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7699 base_level_stop; instead, set base_level_stop to BEGV.
7700 Fixes crashes in vertical-motion.
0bb23927
EZ
7701 (next_element_from_buffer): Improve commentary for when
7702 the iterator is before prev_stop.
7703 (init_iterator): Initialize bidi_p from the default value of
7704 bidi-display-reordering, not from buffer-local value. Use the
7705 buffer-local value only if initializing for buffer iteration.
7706 (handle_invisible_prop): Support invisible properties on strings
7707 that are being bidi-reordered.
7708 (set_iterator_to_next): Support bidi reordering of C strings and
7709 Lisp strings.
7710 (next_element_from_string): Support bidi reordering of Lisp
7711 strings.
7712 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7713 (display_string): Support display of R2L glyph rows.
7714 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7715 (init_iterator): Don't initialize it->bidi_p for strings
7716 here.
7717 (reseat_to_string): Initialize it->bidi_p for strings here.
7718 (next_element_from_string, next_element_from_c_string)
7719 (next_element_from_buffer): Add xassert's for correspondence
7720 between IT's object being iterated and it->bidi_it.string
7721 structure.
7722 (face_before_or_after_it_pos): Support bidi iteration.
7723 (next_element_from_c_string): Handle the case of the first string
7724 character that is not the first one in the visual order.
7725 (get_visually_first_element): New function, refactored from common
7726 parts of next_element_from_buffer, next_element_from_string, and
7727 next_element_from_c_string.
7728 (tool_bar_lines_needed, redisplay_tool_bar)
7729 (display_menu_bar): Force left-to-right direction. Add a FIXME
7730 comment for making that be controlled by a user option.
7731 (push_it, pop_it): Save and restore the state of the
7732 bidi iterator. Save and restore the bidi_p flag.
7733 (pop_it): Iterate out of display property for string iteration as
7734 well.
7735 (iterate_out_of_display_property): Support iteration over strings.
7736 (handle_single_display_spec): Set up it->bidi_it for iteration
7737 over a display string, and call bidi_init_it.
7738 (handle_single_display_spec, next_overlay_string)
7739 (get_overlay_strings_1, push_display_prop): Set up the bidi
7740 iterator for displaying display or overlay strings.
7741 (forward_to_next_line_start): Don't use the shortcut if
7742 bidi-iterating.
7743 (back_to_previous_visible_line_start): If handle_display_prop
7744 pushed the iterator stack, restore the internal state of the bidi
7745 iterator by calling bidi_pop_it same number of times.
7746 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7747 and we are bidi-iterating, don't decrement the iterator position;
7748 instead, set the first_elt flag in the bidi iterator, to produce
7749 the same effect.
7750 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7751 (push_display_prop): xassert that we are iterating a buffer.
7752 (push_it, pop_it): Save and restore paragraph_embedding member.
7753 (handle_single_display_spec, next_overlay_string)
7754 (get_overlay_strings_1, reseat_1, reseat_to_string)
7755 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7756 correctly. Don't assume unibyte strings are not bidi-reordered.
7757 (compute_display_string_pos)
7758 (compute_display_string_end): Fix handling the case of C string.
7759 (push_it, pop_it): Save and restore from_disp_prop_p.
7760 (handle_single_display_spec, push_display_prop): Set the
7761 from_disp_prop_p flag.
7762 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7763 (pop_it): Call iterate_out_of_display_property only if we are
7764 popping after iteration over a string that came from a display
7765 property. Fix a typo in popping stretch info. Add an assertion
7766 for verifying that the iterator position is in sync with the bidi
7767 iterator.
7768 (handle_single_display_spec, get_overlay_strings_1)
7769 (push_display_prop): Fix initialization of paragraph direction for
7770 string when that of the parent object is not yet determined.
7771 (reseat_1): Call bidi_init_it to resync the bidi
7772 iterator with IT's position. (Bug#7616)
7773 (find_row_edges): If ROW->start.pos gives position
7774 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7775 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7776 Reset the from_disp_prop_p flag.
7777 (SAVE_IT, RESTORE_IT): New macros.
7778 (pos_visible_p, face_before_or_after_it_pos)
7779 (back_to_previous_visible_line_start)
7780 (move_it_in_display_line_to, move_it_in_display_line)
7781 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7782 (try_scrolling, redisplay_window, display_line): Use them when
7783 saving a temporary copy of the iterator and restoring it back.
7784 (back_to_previous_visible_line_start, reseat_1)
7785 (init_iterator): Empty the bidi cache "stack".
7786 (move_it_in_display_line_to): If iterator ended up at
7787 EOL, but we never saw any buffer positions smaller than
7788 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7789 motion in bidi-reordered lines.
7790 (move_it_in_display_line_to): Record prev_method and prev_pos
7791 immediately before the call to set_iterator_to_next. Fixes cursor
7792 motion in bidi-reordered lines with stretch glyphs and strings
7793 displayed in margins. (Bug#8133) (Bug#8867)
7794 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7795 TO_CHARPOS.
640c8776
SM
7796 (pos_visible_p): Support positions in bidi-reordered lines.
7797 Save and restore bidi cache.
0bb23927
EZ
7798
7799 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7800 (bidi_paragraph_info): Delete unused struct.
7801 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7802 (bidi_cache_start): New variable.
7803 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7804 to zero.
7805 (bidi_cache_fetch_state, bidi_cache_search)
7806 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7807 (bidi_cache_find, bidi_peek_at_next_level)
7808 (bidi_level_of_next_char, bidi_find_other_level_edge)
7809 (bidi_move_to_visually_next): Compare cache index with
7810 bidi_cache_start rather than with zero.
7811 (bidi_fetch_char): Accept new argument STRING; all callers
7812 changed. Support iteration over a string. Support strings with
7813 display properties. Support unibyte strings. Fix the type of
7814 `len' according to what STRING_CHAR_AND_LENGTH expects.
7815 (bidi_paragraph_init, bidi_resolve_explicit_1)
7816 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7817 (bidi_level_of_next_char, bidi_move_to_visually_next):
7818 Support iteration over a string.
0bb23927
EZ
7819 (bidi_set_sor_type, bidi_resolve_explicit_1)
7820 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7821 can now be zero (for strings); special values 0 and -1 were
7822 changed to -1 and -2, respectively.
7823 (bidi_char_at_pos): New function.
7824 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7825 Call it instead of FETCH_MULTIBYTE_CHAR.
7826 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7827 initialized to valid values.
7828 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7829 values.
7830 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7831 the test for valid cached positions. Fix the logic for looking up
7832 the sentinel state in the cache. GCPRO the Lisp string we are
7833 iterating.
7834 (bidi_push_it, bidi_pop_it): New functions.
7835 (bidi_initialize): Initialize the bidi cache start stack pointer.
7836 (bidi_cache_ensure_space): New function, refactored from part of
7837 bidi_cache_iterator_state. Don't assume the required size is just
7838 one BIDI_CACHE_CHUNK away.
7839 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7840 (bidi_count_bytes, bidi_char_at_pos): New functions.
7841 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7842 always valid if bidi_cache_idx is valid.
7843 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7844 is valid if it's going to be used.
7845 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7846 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7847 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7848 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7849 (bidi_find_other_level_edge, bidi_cache_start_stack):
7850 All variables related to cache indices are now EMACS_INT.
c965adc5 7851
0bb23927
EZ
7852 * dispextern.h (struct bidi_string_data): New structure.
7853 (struct bidi_it): New member `string'. Make flag members be 1-bit
7854 fields, and put them last in the struct.
640c8776
SM
7855 (compute_display_string_pos, compute_display_string_end):
7856 Update prototypes.
0bb23927
EZ
7857 (bidi_push_it, bidi_pop_it): Add prototypes.
7858 (struct iterator_stack_entry): New members bidi_p,
7859 paragraph_embedding, and from_disp_prop_p.
7860 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7861 (bidi_shelve_cache, bidi_unshelve_cache):
7862 Declare prototypes.
0bb23927
EZ
7863
7864 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7865 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7866 and vector-like objects.
7867
7868 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7869 cache around display iteration.
7870
7871 * window.c (Fwindow_end, window_scroll_pixel_based)
7872 (displayed_window_lines, Frecenter): Save and restore the bidi
7873 cache around display iteration.
7874
3bbd2265
LMI
78752011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7876
7877 * editfns.c (Fdelete_region): Clarify the use of the named
7878 parameters (bug#6788).
7879
adc47434
MR
78802011-07-14 Martin Rudalics <rudalics@gmx.at>
7881
7882 * indent.c (Fvertical_motion): Set and restore w->pointm when
7883 saving and restoring the window's buffer (Bug#9006).
7884
837c31f8
LMI
78852011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7886
7887 * editfns.c (Fstring_to_char): Clarify just what is returned
7888 (bug#6576). Text by Eli Zaretskii.
7889
ac389d0c
JB
78902011-07-13 Juanma Barranquero <lekktu@gmail.com>
7891
7892 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7893
0be0ce47
EZ
78942011-07-13 Eli Zaretskii <eliz@gnu.org>
7895
7896 * buffer.c (mmap_find): Fix a typo.
7897
cd18e7e3
JB
78982011-07-13 Johan Bockgård <bojohan@gnu.org>
7899
7900 Fix execution of x selection hooks.
7901 * xselect.c (Qx_lost_selection_functions)
7902 (Qx_sent_selection_functions): New vars.
7903 (syms_of_xselect): DEFSYM them.
7904 (x_handle_selection_request): Pass Qx_sent_selection_functions
7905 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7906 (x_handle_selection_clear,x_clear_frame_selections):
7907 Pass Qx_lost_selection_functions rather than
7908 Vx_lost_selection_functions to Frun_hook_with_args.
7909
47ea7f44
PE
79102011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7911
ac389d0c 7912 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7913 The old code sometimes used this field without initializing it.
7914
47ea7f44
PE
7915 * alloc.c (gc_sweep): Don't read past end of array.
7916 In theory, the old code could also have corrupted Emacs internals,
7917 though it'd be very unlikely.
7918
bc985c87
AS
79192011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7920
7921 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7922 argument. (Bug#4026)
bc985c87 7923
0cf34688
LMI
79242011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7925
b3dadd76
LMI
7926 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7927 key" (bug#4257).
7928
0cf34688
LMI
7929 * window.c (Fset_window_start): Doc fix (bug#4199).
7930 (Fset_window_hscroll): Ditto.
7931
270768cd
PE
79322011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7933
077e3dda 7934 Fix minor new problems caught by GCC 4.6.1.
270768cd 7935 * term.c (init_tty): Remove unused local.
490011a6 7936 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7937 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7938 not used otherwise.
270768cd 7939
b1f58454
CY
79402011-07-12 Chong Yidong <cyd@stupidchicken.com>
7941
7942 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7943
22b9578d
LMI
79442011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7945
6e70ab07
LMI
7946 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7947 are the mini-buffer and the echo area (bug#3320).
7948
22b9578d
LMI
7949 * term.c (init_tty): Remove support for supdup, c10 and perq
7950 terminals, which are no longer supported (bug#1482).
7951
8974cc9f
JB
79522011-07-10 Johan Bockgård <bojohan@gnu.org>
7953
7954 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7955
a560d974
JD
79562011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7957
7958 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7959 for non-popups (Bug#3642).
7960
1dae0f0a
AS
79612011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7962
268c2c36 7963 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7964 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7965 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7966 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7967 * data.c (fmod): Likewise.
7968 * dispnew.c (swap_glyphs_in_rows): Likewise.
7969 * emacs.c (memory_warning_signal): Likewise.
7970 * floatfns.c (float_error): Likewise.
7971 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7972 (otf_open, font_otf_capability, generate_otf_features)
7973 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7974 Likewise.
7975 * image.c (pbm_read_file): Likewise.
7976 * indent.c (string_display_width): Likewise.
7977 * intervals.c (check_for_interval, search_for_interval)
7978 (inc_interval_count, count_intervals, root_interval)
7979 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7980 * lread.c (defalias): Likewise.
268c2c36 7981 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7982 * regex.c (set_image_of_range_1, set_image_of_range)
7983 (regex_grow_registers): Likewise.
7984 * sysdep.c (strerror): Likewise.
7985 * termcap.c (valid_filename_p, tprint, main): Likewise.
7986 * tparam.c (main): Likewise.
7987 * unexhp9k800.c (run_time_remap, save_data_space)
7988 (update_file_ptrs, read_header, write_header, calculate_checksum)
7989 (copy_file, copy_rest, display_header): Likewise.
7990 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7991 Likewise.
7992 * xdisp.c (check_it): Likewise.
7993 * xfaces.c (register_color, unregister_color, unregister_colors):
7994 Likewise.
7995 * xfns.c (print_fontset_result): Likewise.
7996 * xrdb.c (member, fatal, main): Likewise.
7997
99033785
PE
79982011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7999
8000 Fix minor problems found by static checking (Bug#9031).
8001 * chartab.c (char_table_set_range, map_sub_char_table):
8002 Remove unused locals.
8003 (uniprop_table): Now static.
8004 * composite.c (_work_char): Remove unused static var.
8005
9cb2ac56
JB
80062011-07-09 Juanma Barranquero <lekktu@gmail.com>
8007
8008 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8009
f25661f0
JD
80102011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8011
8012 * gtkutil.c (qttip_cb): Remove code without function.
8013
8278c4fe
EZ
80142011-07-09 Eli Zaretskii <eliz@gnu.org>
8015
8016 * w32.c (pthread_sigmask): New stub.
8017
1692ae2d 80182011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8019
8a6ebd58 8020 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8021 sigprocmask is portable only for single-threaded applications, and
8022 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8023 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8024 (LIBES): Use it.
8025 * callproc.c (Fcall_process):
8026 * process.c (create_process):
8027 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8028 Use pthread_sigmask, not sigprocmask.
123403e4 8029
1b854618
JD
80302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8031
8032 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8033 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8034 wrong (Bug#8591).
8035
3fe4b549
JD
80362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8037
0ce7e563
JD
8038 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8039 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8040 (xg_hide_tooltip): Fix comment.
8041
3fe4b549
JD
8042 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8043 in registerServicesMenuSendTypes.
8044 (validRequestorForSendType): Don't check ns_return_types.
8045
8046 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8047 ns_return_type.
8048
5df75e47
JR
80492011-07-08 Jason Rumney <jasonr@gnu.org>
8050
22610910
JR
8051 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8052 SH_SHOW for hidden windows (Bug#5482).
8053
5df75e47
JR
8054 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8055 frame struct members of non-existent frames (Bug#6284).
8056
699c10bd
JD
80572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8058
4393663b
JD
8059 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8060 variable firstTime not needed on OSX >= 10.6.
8061 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8062 >= 10.5. Use setKnobProportion, setDoubleValue.
8063
8064 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8065 (MAC_OS_X_VERSION_10_5): Define if not defined.
8066 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8067 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8068 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8069
8070 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8071 cString and lossyCString on OSX >= 10.4.
4393663b 8072
58179cce 8073 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8074 sizeToFit on OSX >= 10.2.
8075
8076 * nsimage.m (allocInitFromFile): Don't use deprecated method
8077 bestRepresentationForDevice on OSX >= 10.6.
8078
8079 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8080 to avoid warning.
8081
8082 * emacs.c: Declare unexec_init_emacs_zone.
8083
a63e0781
JD
8084 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8085
699c10bd
JD
8086 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8087
8088 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8089 on svcsMenu (Bug#8842).
8090
8091 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8092 ns_return_types.
8093 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8094
8095 * nsterm.m (QUTF8_STRING): Declare.
8096 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8097 (validRequestorForSendType): Return type is (id).
8098 Change indexOfObjectIdenticalTo to indexOfObject.
8099 Check if we have local selection before returning self (Bug#8842).
8100 (writeSelectionToPasteboard): Put local selection into paste board
8101 if we have a local selection (Bug#8842).
8102 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8103
8104 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8105 (ns_get_local_selection): Declare.
8106
54e10184
LMI
81072011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8108
9888ff71
LMI
8109 * keymap.c (describe_map_tree): Don't insert a double newline at
8110 the end of the buffer (bug#1169) and return whether we inserted
8111 something.
8112
54e10184
LMI
8113 * callint.c (Fcall_interactively): Change "reading args" to
8114 "providing args" to try to clarify what it does (bug#1010).
8115
15fa4783
KH
81162011-07-07 Kenichi Handa <handa@m17n.org>
8117
8118 * composite.c (composition_compute_stop_pos): Ignore a static
8119 composition starting before CHARPOS (Bug#8915).
8120
8121 * xdisp.c (handle_composition_prop): Likewise.
8122
a8815b00
EZ
81232011-07-07 Eli Zaretskii <eliz@gnu.org>
8124
8125 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8126 (Bug#9015)
8127
ef7b981d 81282011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8129
8130 * character.h (unicode_category_t): New enum type.
8131
8132 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8133 (Qchar_code_property_table): New variable.
8134 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8135 (UNIPROP_COMPRESSED_FORM_P): New macros.
8136 (char_table_ascii): Uncompress the compressed values.
8137 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8138 Uncompress the compressed values.
ac389d0c 8139 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8140 (char_table_ref_and_range): Uncompress the compressed values.
8141 (sub_char_table_set): New arg is_uniprop. Callers changed.
8142 Uncompress the compressed values.
8143 (sub_char_table_set_range): Args changed. Callers changed.
8144 (char_table_set_range): Adjuted for the above change.
8145 (map_sub_char_table): Delete args default_val and parent. Add arg
8146 top. Give decoded values to a Lisp function.
640c8776 8147 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8148 values to a Lisp function. Gcpro more variables.
8149 (uniprop_table_uncompress)
8150 (uniprop_decode_value_run_length): New functions.
8151 (uniprop_decoder, uniprop_decoder_count): New variables.
8152 (uniprop_get_decoder, uniprop_encode_value_character)
8153 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8154 New functions.
8155 (uniprop_encoder, uniprop_encoder_count): New variables.
8156 (uniprop_get_encoder, uniprop_table)
8157 (Funicode_property_table_internal, Fget_unicode_property_internal)
8158 (Fput_unicode_property_internal): New functions.
8159 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8160 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8161 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8162 char-code-property-alist.
8163
640c8776 8164 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8165 Vunicode_category_table.
8166
640c8776 8167 * font.c (font_range): Adjust for the change of
c805dec0
KH
8168 Vunicode_category_table.
8169
76b397fb
DN
81702011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8171
8172 * m/iris4d.h: Remove file, move contents ...
8173 * s/irix6-5.h: ... here.
8174
22b4128e
PE
81752011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8176
8177 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8178 * alloc.c (mark_buffer):
8179 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8180 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8181 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8182 This isn't true in general, and it's particularly not true
8183 if Emacs is configured with --with-wide-int.
8184 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8185 New macros, used in the buffer.c change.
8186
869795d6
JD
81872011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8188
8189 * xsettings.c: Use both GConf and GSettings if both are available.
8190 (store_config_changed_event): Add comment.
8191 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8192 (store_tool_bar_style_changed): New functions.
5e617bc2 8193 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8194 (struct xsettings): Move font inside HAVE_XFT.
8195 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8196 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8197 Move inside HAVE_XFT.
640c8776 8198 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8199 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8200 also.
8201 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8202 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8203 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8204 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8205 (parse_settings): Move check for font inside HAVE_XFT.
8206 (read_settings, apply_xft_settings): Add comment.
8207 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8208 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8209 call store_font_name_changed.
8210 (xft_settings_event): Add comment.
8211 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8212 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8213 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8214 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8215 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8216 (xsettings_get_system_font, xsettings_get_system_normal_font):
8217 Add comment.
869795d6 8218
d8ed26bd
PE
82192011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8220
8221 Random fixes. E.g., (random) never returned negative values.
8222 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8223 subseconds part to the entropy, as that's a bit more random.
8224 Prefer signed to unsigned, since the signedness doesn't matter and
8225 in general we prefer signed. When given a limit, use a
8226 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8227 latter isn't right if USE_2_TAGS_FOR_INTS.
8228 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8229 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8230
cabf1cac
SM
82312011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8232
8233 * textprop.c (text_property_stickiness):
8234 Obey Vtext_property_default_nonsticky.
8235 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8236 * w32fns.c (syms_of_w32fns):
8237 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8238
6e9b2be9
PE
82392011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8240
8241 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8242 This is more efficient than Ffile_directory_p and avoids a minor race.
8243
90186c68
LMI
82442011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8245
7c301272
LMI
8246 * buffer.c (Foverlay_put): Say what the return value is
8247 (bug#7835).
8248
c4f2d8d4
LMI
8249 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8250 is a directory before asking whether to use the file name
8251 (bug#7564).
ad637907
LMI
8252 (barf_or_query_if_file_exists): Make the "File is a directory"
8253 error be more correct.
c4f2d8d4 8254
90186c68
LMI
8255 * fns.c (Frequire): Remove the mention of the .gz files, since
8256 that's installation-specific, but keep the mention of
8257 `get-load-suffixes'.
8258
da64016e
PE
82592011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8260
8261 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8262 Report string overflow if the output is too long.
8263
7d47b580
JB
82642011-07-04 Juanma Barranquero <lekktu@gmail.com>
8265
a555cb87
JB
8266 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8267 (syms_of_gnutls): Remove duplicate DEFSYM for
8268 Qgnutls_bootprop_verify_hostname_error, an error for
8269 Qgnutls_bootprop_verify_error (which is no longer used).
8270
7d47b580
JB
8271 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8272 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8273 Also (re)move comments that are misplaced or no longer relevant.
8274
1e49bfab
LMI
82752011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8276
8277 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8278
1485f4c0
CY
82792011-07-03 Chong Yidong <cyd@stupidchicken.com>
8280
8281 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8282 and background color parameters if they have been changed.
8283
a9ab721e
LMI
82842011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8285
8286 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8287
cf7cff57
PE
82882011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8289
2e13213d
PE
8290 * xsettings.c (SYSTEM_FONT): Define only when used.
8291 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8292
cf7cff57
PE
8293 * keymap.c (access_keymap_1): Now static.
8294
7a8e04f7
CY
82952011-07-02 Chong Yidong <cyd@stupidchicken.com>
8296
8297 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8298 leave any prefix arg for the up event (Bug#1586).
8299
61352f62
LMI
83002011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8301
69bb1ef7
LMI
8302 * lread.c (syms_of_lread): Mention single symbols defined by
8303 `defvar' or `defconst' (bug#7154).
8304
61352f62 8305 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8306 (Frequire): Mention get-load-suffixes.
61352f62 8307
28545e04
MR
83082011-07-02 Martin Rudalics <rudalics@gmx.at>
8309
8310 * window.h (window): Remove clone_number slot.
8311 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8312 Remove.
8313 (make_parent_window, make_window, saved_window)
8314 (Fset_window_configuration, save_window_save): Don't deal with
8315 clone numbers.
8316 * buffer.c (Qclone_number): Remove declaration.
8317 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8318
3349e122
SM
83192011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8320
8321 Add multiple inheritance to keymaps.
8322 * keymap.c (Fmake_composed_keymap): New function.
8323 (Fset_keymap_parent): Simplify.
8324 (fix_submap_inheritance): Remove.
8325 (access_keymap_1): New function extracted from access_keymap to handle
8326 embedded parents and handle lists of maps.
8327 (access_keymap): Use it.
8328 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8329 (Fcopy_keymap): Handle embedded parents.
8330 (Fcommand_remapping, define_as_prefix): Simplify.
8331 (Fkey_binding): Simplify.
8332 (syms_of_keymap): Move minibuffer-local-completion-map,
8333 minibuffer-local-filename-completion-map,
8334 minibuffer-local-must-match-map, and
8335 minibuffer-local-filename-must-match-map to Elisp.
8336 (syms_of_keymap): Defsubr make-composed-keymap.
8337 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8338 (parse_menu_item): Trivial simplification.
8339
3279eb87
GM
83402011-07-01 Glenn Morris <rgm@gnu.org>
8341
8342 * Makefile.in (SETTINGS_LIBS): Fix typo.
8343
4550efdf
KI
83442011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8345
8346 * coding.c (Fencode_coding_string): Record the last coding system
8347 used, as the function doc string says (bug#8738).
8348
0949d2b6
JD
83492011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8350
8351 * xsettings.c (store_monospaced_changed): Take new font as arg and
8352 check for change against current_mono_font.
8353 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8354 (emacs_settings_constructor, emacs_settings_get_property)
8355 (emacs_settings_set_property, emacs_settings_class_init)
8356 (emacs_settings_init, gsettings_obj): Remove.
8357 (something_changedCB): New function for HAVE_GSETTINGS.
8358 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8359 with value as argument.
8360 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8361 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8362 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8363 "changed".
8364
8365 * xgselect.c: Add defined (HAVE_GSETTINGS).
8366 (xgselect_initialize): Ditto.
8367
8368 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8369 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8370 xg_select.
8371
bbc6b304
PE
83722011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8373
8374 * eval.c (struct backtrace): Simplify and port the data structure.
8375 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8376 signed bit field, as this assumption is not portable and it makes
8377 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8378 "char debug_on_exit : 1" as this is not portable either; instead,
8379 use the portable "unsigned int debug_on_exit : 1". Remove unused
8380 member evalargs. Remove obsolete comments about cc bombing out.
8381
9851bfc5
JD
83822011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8383
51bb811f 8384 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8385 Let HAVE_GSETTINGS override HAVE_GCONF.
8386 (store_monospaced_changed): New function.
8387 (EMACS_SETTINGS): A new type derived from GObject to handle
8388 GSettings notifications.
8389 (emacs_settings_constructor, emacs_settings_get_property)
8390 (emacs_settings_set_property, emacs_settings_class_init):
8391 New functions.
8392 (gsettings_client, gsettings_obj): New variables.
8393 (GSETTINGS_SCHEMA): New define.
8394 (something_changedCB): Call store_monospaced_changed.
8395 (init_gsettings): New function.
8396 (xsettings_initialize): Call init_gsettings.
8397 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8398 to NULL.
8399
640c8776 8400 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8401 GCONF_CFLAGS/LIBS.
8402
5386012d
MR
84032011-06-29 Martin Rudalics <rudalics@gmx.at>
8404
8405 * window.c (resize_root_window, grow_mini_window)
8406 (shrink_mini_window): Rename Qresize_root_window to
8407 Qwindow_resize_root_window and Qresize_root_window_vertically to
8408 Qwindow_resize_root_window_vertically.
8409
f13e0b08
PE
84102011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8411
8412 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8413
94515237
JB
84142011-06-27 Juanma Barranquero <lekktu@gmail.com>
8415
8416 * makefile.w32-in: Redesign dependencies so they reflect more
8417 clearly which files are directly included by each source file,
8418 and not through other includes.
8419
e43b6e43
MR
84202011-06-27 Martin Rudalics <rudalics@gmx.at>
8421
8422 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8423 (sort_overlays, overlay_strings): When an overlay's clone number
8424 matches the window's clone number process the overlay even if
8425 the overlay's window property doesn't match the current window.
8426
d68443dc
MR
8427 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8428 (Fwindow_hchild): Rename to Fwindow_left_child.
8429 (Fwindow_next): Rename to Fwindow_next_sibling.
8430 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8431 (resize_window_check): Rename to window_resize_check.
8432 (resize_window_apply): Rename to window_resize_apply.
8433 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8434 (Fdelete_other_windows_internal, resize_frame_windows)
8435 (Fsplit_window_internal, Fdelete_window_internal)
8436 (grow_mini_window, shrink_mini_window)
8437 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8438
c7e73be5
JD
84392011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8440
8441 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8442 (emacs_fixed_set_min_size): Remove.
8443 (emacs_fixed_new): Take frame as argument.
8444
8445 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8446 (_EmacsFixedPrivate): Remove minwidth/height.
8447 Add struct frame *f.
8448 (emacs_fixed_init): Initialize priv->f.
8449 (get_parent_class, emacs_fixed_set_min_size): Remove.
8450 (emacs_fixed_new): Set priv->f to argument.
8451 (emacs_fixed_get_preferred_width)
8452 (emacs_fixed_get_preferred_height): Use min_width/height from
8453 frames size_hint to set minimum and natural (Bug#8919).
8454 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8455 and use min_width/height from frames size_hint to set
8456 min_width/height (Bug#8919).
8457
8458 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8459 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8460 Fix indentation.
c7e73be5 8461
cf99dcf8
EZ
84622011-06-26 Eli Zaretskii <eliz@gnu.org>
8463
8464 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8465 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8466 called at ZV.
8467
029529ac
CY
84682011-06-26 Chong Yidong <cyd@stupidchicken.com>
8469
8470 * process.c (wait_reading_process_output): Bypass select if
8471 waiting for a cell while ignoring keyboard input, and input is
8472 pending. Suggested by Jan Djärv (Bug#8869).
8473
7a7ef429
PE
84742011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8475
8476 Use gnulib's dup2 module instead of rolling our own.
8477 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8478
11fdef7d 84792011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8480
8481 * dispnew.c (scrolling_window): Before scrolling, turn off a
8482 mouse-highlight in the window being scrolled.
8483
cd3520a4
JB
84842011-06-24 Juanma Barranquero <lekktu@gmail.com>
8485
8486 Move DEFSYM to lisp.h and use everywhere.
8487
8488 * character.h (DEFSYM): Move declaration...
8489 * lisp.h (DEFSYM): ...here.
8490
8491 * gnutls.c:
8492 * minibuf.c:
8493 * w32menu.c:
8494 * w32proc.c:
8495 * w32select.c: Don't include character.h.
8496
8497 * alloc.c (syms_of_alloc):
8498 * buffer.c (syms_of_buffer):
8499 * bytecode.c (syms_of_bytecode):
8500 * callint.c (syms_of_callint):
8501 * casefiddle.c (syms_of_casefiddle):
8502 * casetab.c (init_casetab_once):
8503 * category.c (init_category_once, syms_of_category):
8504 * ccl.c (syms_of_ccl):
8505 * cmds.c (syms_of_cmds):
8506 * composite.c (syms_of_composite):
8507 * dbusbind.c (syms_of_dbusbind):
8508 * dired.c (syms_of_dired):
8509 * dispnew.c (syms_of_display):
8510 * doc.c (syms_of_doc):
8511 * editfns.c (syms_of_editfns):
8512 * emacs.c (syms_of_emacs):
8513 * eval.c (syms_of_eval):
8514 * fileio.c (syms_of_fileio):
8515 * fns.c (syms_of_fns):
8516 * frame.c (syms_of_frame):
8517 * fringe.c (syms_of_fringe):
8518 * insdel.c (syms_of_insdel):
8519 * keymap.c (syms_of_keymap):
8520 * lread.c (init_obarray, syms_of_lread):
8521 * macros.c (syms_of_macros):
8522 * msdos.c (syms_of_msdos):
8523 * print.c (syms_of_print):
8524 * process.c (syms_of_process):
8525 * search.c (syms_of_search):
8526 * sound.c (syms_of_sound):
8527 * syntax.c (init_syntax_once, syms_of_syntax):
8528 * terminal.c (syms_of_terminal):
8529 * textprop.c (syms_of_textprop):
8530 * undo.c (syms_of_undo):
8531 * w32.c (globals_of_w32):
8532 * window.c (syms_of_window):
8533 * xdisp.c (syms_of_xdisp):
8534 * xfaces.c (syms_of_xfaces):
8535 * xfns.c (syms_of_xfns):
8536 * xmenu.c (syms_of_xmenu):
8537 * xsettings.c (syms_of_xsettings):
8538 * xterm.c (syms_of_xterm): Use DEFSYM.
8539
4228cf16
TZ
85402011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8541
cd3520a4 8542 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8543
7fcccf1e
PE
85442011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8545
7efb4e0e
PE
8546 Integer and buffer overflow fixes (Bug#8873).
8547
ff5844ad
PE
8548 * print.c (printchar, strout): Check for string overflow.
8549 (PRINTPREPARE, printchar, strout):
8550 Don't set size unless allocation succeeds.
8551
90532f02
PE
8552 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8553 for sizes. Check for string overflow more accurately.
8554 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8555
6d84508d
PE
8556 * macros.c: Integer and buffer overflow fixes.
8557 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8558 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8559 Use ptrdiff_t, not int, for sizes.
8560 Don't increment bufsize until after realloc succeeds.
8561 Check for size-calculation overflow.
8562 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8563
437b2cb4
PE
8564 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8565
8b9ac8b4
PE
8566 * lread.c: Integer overflow fixes.
8567 (read_integer): Radix is now EMACS_INT, not int,
8568 to improve quality of diagnostics for out-of-range radices.
8569 Calculate buffer size correctly for out-of-range radices.
8570 (read1): Check for integer overflow in radices, and in
8571 read-circle numbers.
82cb60d3
PE
8572 (read_escape): Avoid int overflow.
8573 (Fload, openp, read_buffer_size, read1)
8574 (substitute_object_recurse, read_vector, read_list, map_obarray):
8575 Use ptrdiff_t, not int, for sizes.
8576 (read1): Use EMACS_INT, not int, for sizes.
20270765 8577 Check for size overflow.
8b9ac8b4 8578
7fcccf1e
PE
8579 * image.c (cache_image): Check for size arithmetic overflow.
8580
bfbbd7e7
PE
8581 * lread.c: Integer overflow issues.
8582 (saved_doc_string_size, saved_doc_string_length)
8583 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8584 Now ptrdiff_t, not int.
8585 (read1): Don't assume doc string length fits in int. Check for
8586 out-of-range doc string lengths.
8587 (read_list): Don't assume file position fits in int.
39019e54 8588 (read_escape): Check for hex character overflow.
bfbbd7e7 8589
4e323265
LL
85902011-06-22 Leo Liu <sdl.web@gmail.com>
8591
8592 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8593 Move to minibuffer.el.
8594
85fece3e
PE
85952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8596
20b84ce9 8597 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8598 The following patches are for when GLYPH_DEBUG && !XASSERT.
8599 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8600 * dispnew.c (flush_stdout):
8601 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8602 Mark as externally visible.
8603 * dispnew.c (check_window_matrix_pointers): Now static.
8604 * dispnew.c (window_to_frame_vpos):
8605 * xfns.c (unwind_create_frame):
8606 * xterm.c (x_check_font): Remove unused local.
8607 * scroll.c (CHECK_BOUNDS):
8608 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8609 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8610 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8611 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8612 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8613 Now static.
8614 (debug_method_add): Use va_list and vsprintf rather than relying
8615 on undefined behavior with wrong number of arguments.
8616 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8617 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8618 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8619 since we're not interested in debugging glyphs with old libraries.
8620 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8621 GCC 4.6.0's static checking.
8622
0766b489
PE
86232011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8624
31fd4b32
PE
8625 Integer overflow and signedness fixes (Bug#8873).
8626 A few related buffer overrun fixes, too.
8627
b79e8648
PE
8628 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8629
0766b489
PE
8630 * dispextern.h (struct face.stipple):
8631 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8632 (x_bitmap_mask, x_allocate_bitmap_record)
8633 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8634 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8635 (x_create_bitmap_from_xpm_data):
8636 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8637 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8638 (.bitmaps_last):
8639 * xfaces.c (load_pixmap):
8640 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8641 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8642 (.bitmaps_last, struct x_output.icon_bitmap):
8643 Use ptrdiff_t, not int, for bitmap indexes.
8644 (x_allocate_bitmap_record): Check for size overflow.
8645 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8646
b081724f
PE
8647 Use ptrdiff_t, not int, for overlay counts.
8648 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8649 * editfns.c (overlays_around, get_pos_property):
8650 * textprop.c (get_char_property_and_overlay):
8651 * xdisp.c (next_overlay_change, note_mouse_highlight):
8652 * xfaces.c (face_at_buffer_position):
21514da7
PE
8653 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8654 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8655 (Fnext_overlay_change, Fprevious_overlay_change)
8656 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8657 Use ptrdiff_t, not int, for sizes.
21514da7 8658 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8659
3de73e5e
PE
8660 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8661
2606c57b
PE
8662 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8663 (x_session_initialize): Do not assume string length fits in int.
8664
aaafe47a
PE
8665 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8666 This is unlikely, but can occur if DPI is outlandish.
8667
2674ddc8 8668 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8669 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8670
28154962
PE
8671 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8672 * xrdb.c (magic_file_p, search_magic_path):
8673 Omit last arg SUFFIX; it was always 0. All callers changed.
8674 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8675
7de51af5
PE
8676 * xfont.c (xfont_match): Avoid need for strlen.
8677
25ed6cc3
PE
8678 * xfns.c: Don't assume strlen fits in int.
8679 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8680
4eab31dd
PE
8681 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8682 not unsigned long, as we prefer signed integers. All callers changed.
8683 Detect integer overflow in repeat count.
8684 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8685 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8686
171e2a58
PE
8687 * termcap.c: Don't assume sizes fit in int and never overflow.
8688 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8689 (gobble_line): Check for size-calculation overflow.
8690
ad39faca 8691 * minibuf.c (Fread_buffer):
6e5bb2dc 8692 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8693 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8694 Don't assume string length fits in int.
8695
52c61c22 8696 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8697 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8698
b5b8c9e5
PE
8699 * font.c: Don't assume string length fits in int.
8700 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8701 Use ptrdiff_t, not int.
ccd6111c
PE
8702 (font_intern_prop): Don't assume string length fits in int.
8703 Don't assume integer property fits in fixnum.
8704 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8705
882f0d81 8706 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8707 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8708 Reformulate so as not to need the command string.
8709 Invoke gzip -cd rather than gunzip, as it's more portable.
8710 (lock_info_type, lock_file_1, lock_file):
8711 Don't assume pid_t and time_t fit in unsigned long.
8712 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8713 (current_lock_owner): Prefer signed type for sizes.
8714 Use memcpy, not strncpy, where memcpy is what is really wanted.
8715 Don't assume (via atoi) that time_t and pid_t fit in int.
8716 Check for time_t and/or pid_t out of range, e.g., via a network share.
8717 Don't alloca where an auto var works fine.
8718
93f4cf88
PE
8719 * fileio.c: Fix some integer overflow issues.
8720 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8721 Don't assume string length fits in int.
8722 (directory_file_name): Don't assume string length fits in long.
8723 (make_temp_name): Don't assume pid fits in int, or that its print
8724 length is less than 20.
8725
f3e92b69
PE
8726 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8727
1bfdaf10
PE
8728 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8729
35016e9a
PE
8730 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8731
3d1e65a1
PE
8732 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8733 We prefer signed integers, even for size calculations.
8734
0b963a93
PE
8735 * emacs.c: Don't assume string length fits in 'int'.
8736 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8737 (main): Don't invoke strlen when not needed.
8738
573f4b54
PE
8739 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8740 (XD_DEBUG_MESSAGE): Don't waste a byte.
8741
989f33ba
PE
8742 * callproc.c (getenv_internal_1, getenv_internal)
8743 (Fgetenv_internal):
965d34eb
PE
8744 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8745
e4d29b33
PE
8746 * lread.c (invalid_syntax): Omit length argument.
8747 All uses changed. This doesn't fix a bug, but it simplifies the
8748 code away from its former Hollerith-constant appearance, and it's
8749 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8750 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8751
eb49b136
PE
8752 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8753 This didn't break anything, but it didn't help either.
8754 It's confusing to put a bogus integer in a place where the actual
8755 value does not matter.
9f62aeb1 8756 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8757 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8758
15375a22
PE
8759 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8760 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8761 implementation.
b61cc01c
PE
8762 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8763 We prefer signed types, and the value cannot exceed the EMACS_INT
8764 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8765 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8766 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8767 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8768
53b2623d
PE
8769 * indent.c (sane_tab_width): New function.
8770 (current_column, scan_for_column, Findent_to, position_indentation)
8771 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8772 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8773
51cab52b 8774 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8775
f2ed8a70
PE
8776 * lisp.h (lint_assume): New macro.
8777 * composite.c (composition_gstring_put_cache):
8778 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8779
abe80cc6
PE
8780 * editfns.c, insdel.c:
8781 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8782
b02c740e
PE
8783 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8784
ebc96716
PE
8785 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8786
b4e50fa0 8787 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8788 Use much-faster test for byte-length change.
311d5d7c 8789 Don't assume string byte-length fits in 'int'.
a4cf38e4 8790 Check that character arg fits in 'int'.
85461888 8791 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8792
c0c1ee9f
PE
8793 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8794
a498d7f4
PE
8795 * fns.c (concat): Catch string overflow earlier.
8796 Do not rely on integer wraparound.
8797
51cab52b
PE
8798 * dispextern.h (struct it.overlay_strings_charpos)
8799 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8800 * xdisp.c (forward_to_next_line_start)
8801 (back_to_previous_visible_line_start)
8802 (reseat_at_next_visible_line_start, next_element_from_buffer):
8803 Don't arbitrarily truncate the value of 'selective' to int.
8804
76031fad
PE
8805 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8806
5eb55db9
PE
8807 * composite.c: Don't truncate sizes to 'int'.
8808 (composition_gstring_p, composition_reseat_it)
8809 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8810 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8811 not EMACS_UINT, for indexes.
5eb55db9 8812
0703a717
PE
8813 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8814
d6202519
PE
8815 * buffer.c: Include <verify.h>.
8816 (struct sortvec.priority, struct sortstr.priority):
8961a454 8817 Now EMACS_INT, not int.
c20998a7 8818 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8819 (struct sortstr.size, record_overlay_string)
8820 (struct sortstrlist.size, struct sortlist.used):
8821 Don't truncate size to int.
8822 (record_overlay_string): Check for size-calculation overflow.
d6202519 8823 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8824
d5a19415
JM
88252011-06-22 Jim Meyering <meyering@redhat.com>
8826
029529ac 8827 Don't leak an XBM-image-sized buffer
d5a19415
JM
8828 * image.c (xbm_load): Free the image buffer after using it.
8829
a9041e6c
PE
88302011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8831
8832 Port to Sun C.
8833 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8834 that Sun C diagnosed.
8835 * fns.c (secure_hash): Fix pointer signedness issue.
8836 * intervals.c (static_offset_intervals): New function.
8837 (offset_intervals): Use it.
8838
7f3f739f
LL
88392011-06-21 Leo Liu <sdl.web@gmail.com>
8840
8841 * deps.mk (fns.o):
8842 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8843 sha512.h.
8844
8845 * fns.c (secure_hash): Rename from crypto_hash_function and change
8846 the first arg to accept symbols.
5b66d427 8847 (Fsecure_hash): New primitive.
7f3f739f
LL
8848 (syms_of_fns): New symbols.
8849
76147d94
DD
88502011-06-20 Deniz Dogan <deniz@dogan.se>
8851
8852 * process.c (Fset_process_buffer): Clarify return value in
8853 docstring.
8854
7d7d0045
CY
88552011-06-18 Chong Yidong <cyd@stupidchicken.com>
8856
8857 * dispnew.c (add_window_display_history): Use BVAR.
8858
8859 * xdisp.c (debug_method_add): Use BVAR.
8860 (check_window_end, dump_glyph_matrix, dump_glyph)
8861 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8862
8863 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8864 Likewise.
8865
8866 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8867 check till after the cache is created in init_frame_faces.
8868
ff2bc410
SM
88692011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8870
8871 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8872
28177add
PE
88732011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8874
dd3482fe
PE
8875 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8876 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8877 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8878
393d71f3 8879 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8880 * fileio.c (Finsert_file_contents):
8881 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8882 Remove the old (too-loose) buffer overflow checks.
8883 They weren't needed, since make_gap checks for buffer overflow.
8884 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8885 The old code merely checked for Emacs fixnum overflow, and relied
8886 on undefined (wraparound) behavior. The new code avoids undefined
8887 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8888
2e6813b0 8889 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8890 Tune. Don't use wider integers than needed. Don't use alloca.
8891 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8892
599a9e4f
PE
8893 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8894
99561444
PE
8895 * insdel.c, lisp.h (buffer_overflow): New function.
8896 (insert_from_buffer_1, replace_range, replace_range_2):
8897 * insdel.c (make_gap_larger):
8898 * editfns.c (Finsert_char):
8899 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8900
28177add
PE
8901 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8902
e69dafad
PE
89032011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8904
4baa020d 8905 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8906
b1c46f02
PE
8907 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8908 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8909
e69dafad
PE
8910 * fileio.c: Don't assume EMACS_INT fits in off_t.
8911 (emacs_lseek): New static function.
8912 (Finsert_file_contents, Fwrite_region): Use it.
8913 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8914
566684ea
PE
8915 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8916
e6966cd6
PE
8917 * fns.c: Don't overflow int when computing a list length.
8918 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8919 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8920 truncation on 64-bit hosts. Check for QUIT every
8921 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8922 faster and is responsive enough.
8923 (Flength): Report an error instead of overflowing an integer.
8924 (Fsafe_length): Return a float if the value is not representable
8925 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8926 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8927 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8928
dd0b0efb
PE
8929 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8930 (header_size, word_size): New constants.
8931 (allocate_vectorlike): Don't check size overflow here.
8932 (allocate_vector): Check it here instead, since this is the only
8933 caller of allocate_vectorlike that could cause overflow.
8934 Check that the new vector's length is representable as a fixnum.
8935
86fe5cfe
PE
8936 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8937 The previous code was bogus. For example, next_almost_prime (32)
8938 returned 39, which is undesirable as it is a multiple of 3; and
8939 next_almost_prime (24) returned 25, which is a multiple of 5 so
8940 why was the code bothering to check for multiples of 7?
8941
80e88859
PE
8942 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8943
4a2f0ad6
PE
8944 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8945
f66c7cf8
PE
8946 Variadic C functions now count arguments with ptrdiff_t.
8947 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8948 Back then I didn't know that the Emacs coding style prefers signed int.
8949 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8950 were being counted with int, which may truncate counts on 64-bit
8951 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8952 * lisp.h (struct Lisp_Subr.function.aMANY)
8953 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8954 Arg counts are now ptrdiff_t, not size_t.
8955 All variadic functions and their callers changed accordingly.
8956 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8957 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8958 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8959 * callint.c (Fcall_interactively): Check arg count for overflow,
8960 to avoid potential buffer overrun. Use signed char, not 'int',
8961 for 'varies' array, so that we needn't bother to check its size
8962 calculation for overflow.
8963 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8964 * eval.c (apply_lambda):
8965 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8966 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8967 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8968
a1759b76
PE
8969 * callint.c (Fcall_interactively): Don't use index var as event count.
8970
d96be9fc
PE
8971 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8972 * mem-limits.h (SIZE): Remove; no longer used.
8973
a690a978 8974 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8975
578c21e6
PE
8976 Remove unnecessary casts.
8977 * xterm.c (x_term_init):
8978 * xfns.c (x_set_border_pixel):
8979 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8980 These aren't needed now that we assume ANSI C.
8981
96f53c6c
PE
8982 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8983 It's more likely to cause problems (due to unsigned overflow)
8984 than to cure them.
8985
83c77d31
PE
8986 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8987
ee2079f1
PE
8988 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8989
6da65536
PE
8990 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8991
7147c4a4
PE
8992 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8993
193e32d9
PE
8994 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8995
e5533da6
PE
8996 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8997
9910e595
PE
8998 GLYPH_CODE_FACE returns EMACS_INT, not int.
8999 * dispextern.h (merge_faces):
9000 * xfaces.c (merge_faces):
01103c44
PE
9001 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9002 Don't assume EMACS_INT fits in int.
9910e595 9003
2638320e
PE
9004 * character.h (CHAR_VALID_P): Remove unused parameter.
9005 * fontset.c, lisp.h, xdisp.c: All uses changed.
9006
045eb8d9
PE
9007 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9008
c1f134b5
PE
9009 * fns.c (concat): Minor tuning based on overflow analysis.
9010 This doesn't fix any bugs. Use int to hold character, instead
9011 of constantly refetching from Emacs object. Use XFASTINT, not
9012 XINT, for value known to be a character. Don't bother comparing
9013 a single byte to 0400, as it's always less.
9014
395fcb93 9015 * floatfns.c (Fexpt):
327eeec8
PE
9016 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9017
abbd3d23
PE
9018 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9019 for characters.
9020
684a03ef
PE
9021 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9022
0fed43f3
PE
9023 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9024 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9025 incorrectly succeed when S was a string, because 4294967386 was
9026 truncated before it was used.
9027
8fd02eb7
PE
9028 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9029 Otherwise, an out-of-range integer could cause undefined behavior
9030 on a 64-bit host.
9031
f8c86b69
PE
9032 * composite.c: Use int, not EMACS_INT, for characters.
9033 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9034 EMACS_INT, for values that are known to be in character range.
9035 This doesn't fix any bugs but is the usual style inside Emacs and
9036 may generate better code on 32-bit machines.
9037
34206dd2
PE
9038 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9039 This is for reasons similar to the recent CHAR_STRING fix.
9040 * charset.c (Fencode_char): Check that character arg is actually
9041 a character. Pass an int to ENCODE_CHAR.
9042 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9043 wider than 'int', as a compile-time check to prevent future regressions
9044 in this area.
9045
c5958d4c 9046 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9047
9048 Make sure a 64-bit char is never passed to CHAR_STRING.
9049 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9050 by silently ignoring the top 32 bits, allowing some values
9051 that were far too large to be valid characters.
9052 * character.h: Include <verify.h>.
9053 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9054 arguments are no wider than unsigned, as a compile-time check
9055 to prevent future regressions in this area.
9056 * data.c (Faset):
01103c44 9057 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9058 (Fsubst_char_in_region):
9059 * fns.c (concat):
9060 * xdisp.c (decode_mode_spec_coding):
9061 Adjust to CHAR_STRING's new requirement.
9062 * editfns.c (Finsert_char, Fsubst_char_in_region):
9063 * fns.c (concat): Check that character args are actually
9064 characters. Without this test, these functions did the wrong
9065 thing with wildly out-of-range values on 64-bit hosts.
9066
d37ca623
PE
9067 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9068 These casts should not be needed on 32-bit hosts, either.
9069 * keyboard.c (read_char):
9070 * lread.c (Fload): Remove casts to unsigned.
9071
ea204efb
PE
9072 * lisp.h (UNSIGNED_CMP): New macro.
9073 This fixes comparison bugs on 64-bit hosts.
9074 (ASCII_CHAR_P): Use it.
9075 * casefiddle.c (casify_object):
01103c44 9076 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9077 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9078 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9079 * dispextern.h (FACE_FROM_ID):
9080 * keyboard.c (read_char): Use UNSIGNED_CMP.
9081
41cb286c
PE
9082 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9083 not to EMACS_INT, to avoid GCC warning.
9084
4a1b9832
PE
9085 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9086
55daad71
PE
9087 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9088 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9089 isn't needed on 32-bit machines.
8f95c75c 9090
01103c44
PE
9091 * buffer.c (Fgenerate_new_buffer_name):
9092 Use EMACS_INT for count, not int.
0ceccced 9093 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9094
9095 * data.c (Qcompiled_function): Now static.
9096
c6f072e7
PE
9097 * window.c (window_body_lines): Now static.
9098
20ce5912
PE
9099 * image.c (gif_load): Rename local to avoid shadowing.
9100
9c4c5f81
PE
9101 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9102 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9103 * alloc.c (make_save_value): Integer argument is now of type
9104 ptrdiff_t, not int.
9105 (mark_object): Use ptrdiff_t, not int.
9106 * lisp.h (pD): New macro.
9107 * print.c (print_object): Use it.
9108
c0c5c8ae
PE
9109 * alloc.c: Use EMACS_INT, not int, to count objects.
9110 (total_conses, total_markers, total_symbols, total_vector_size)
9111 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9112 (total_free_floats, total_floats, total_free_intervals)
9113 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9114 Now EMACS_INT, not int. All uses changed.
9115 (Fgarbage_collect): Compute overall total using a double, so that
9116 integer overflow is less likely to be a problem. Check for overflow
9117 when converting back to an integer.
5a25e253
PE
9118 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9119 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9120 These were 'int' variables that could overflow on 64-bit hosts;
9121 they were never used, so remove them instead of repairing them.
211a0b2a 9122 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9123 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9124 Previously, this ceilinged at INT_MAX, but that doesn't work on
9125 64-bit machines.
e46bb31a 9126 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9127
c78baabf 9128 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9129 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9130 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9131 when a (possibly-narrower) signed value would do just as well.
9132 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9133
c9d624c6
PE
9134 * alloc.c: Catch some string size overflows that we were missing.
9135 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9136 for convenience in STRING_BYTES_MAX.
9137 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9138 The definition here is exact; the one in lisp.h was approximate.
9139 (allocate_string_data): Check for string overflow. This catches
9140 some instances we weren't catching before. Also, it catches
9141 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9142 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9143 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9144
c9d624c6
PE
9145 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9146 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9147 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9148
353032ce
PE
9149 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9150
2bccce07
PE
9151 * alloc.c (Fmake_string): Check for out-of-range init.
9152
0ac30604
SM
91532011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9154
9155 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9156
c195f2de
JD
91572011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9158
9159 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9160 xg_get_default_scrollbar_width.
9161
9162 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9163 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9164 (style_changed_cb): Call update_theme_scrollbar_width and call
9165 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9166 all frames (Bug#8505).
9167 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9168 Call gtk_window_set_resizable if HAVE_GTK3.
9169 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9170 and height if HAVE_GTK3 (Bug#8505).
9171 (scroll_bar_width_for_theme): New variable.
9172 (update_theme_scrollbar_width): New function.
9173 (xg_get_default_scrollbar_width): Move code to
9174 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9175 (xg_initialize): Call update_theme_scrollbar_width.
9176
9177 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9178
9179 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9180
e10ac9f1
MR
91812011-06-12 Martin Rudalics <rudalics@gmx.at>
9182
9183 * frame.c (make_frame): Call other_buffer_safely instead of
9184 other_buffer.
9185
9186 * window.c (temp_output_buffer_show): Call display_buffer with
9187 second argument Vtemp_buffer_show_specifiers and reset latter
9188 immediately after the call.
9189 (Vtemp_buffer_show_specifiers): New variable.
9190 (auto_window_vscroll_p, next_screen_context_lines)
9191 (Vscroll_preserve_screen_position): Remove leading asterisks from
9192 doc-strings.
9193
2d3c217e 91942011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9195
7b7f97e8 9196 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9197 * buffer.c (Qclone_number): Remove for now, as it's unused.
9198 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9199 (record_buffer): Remove unused local.
9200 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9201 (set_frame_buffer_list): Remove; unused.
9202 * frame.h (other_visible_frames): Remove decl.
9203 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9204 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9205 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9206 if HAVE_GPM.
9207 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9208 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9209 Define only if HAVE_GPM.
9210 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9211 (update_hints_inhibit): Remove; never set. All uses removed.
9212 * widgetprv.h (emacsFrameClassRec): Remove decl.
9213 * window.c (delete_deletable_window): Now returns void, since it
9214 wasn't returning anything.
9215 (compare_window_configurations): Remove unused locals.
9216 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9217 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9218 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9219 the same widths as pointers. This follows up on the 2011-05-06 patch.
9220 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9221 * xterm.h: Likewise.
9222 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9223
1384b89e
JB
92242011-06-12 Juanma Barranquero <lekktu@gmail.com>
9225
9226 * makefile.w32-in: Update dependencies.
9227 (LISP_H): Add lib/intprops.h.
9228
1100a63c
CY
92292011-06-11 Chong Yidong <cyd@stupidchicken.com>
9230
9231 * image.c (gif_load): Add animation frame delay to the metadata.
9232 (syms_of_image): Use DEFSYM. New symbol `delay'.
9233
6198ccd0
MR
92342011-06-11 Martin Rudalics <rudalics@gmx.at>
9235
9236 * window.c (delete_deletable_window): Re-add.
9237 (Fset_window_configuration): Rewrite to handle dead buffers and
9238 consequently deletable windows.
9239 (window_tree, Fwindow_tree): Remove. Supply functionality in
9240 window.el.
9241 (compare_window_configurations): Simplify code.
9242
b6e3633c
AS
92432011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9244
1ab0dee5
AS
9245 * image.c (imagemagick_load_image): Fix type mismatch.
9246 (Fimagemagick_types): Likewise.
9247
b6e3633c
AS
9248 * window.h (replace_buffer_in_windows): Declare.
9249
9397e56f
MR
92502011-06-11 Martin Rudalics <rudalics@gmx.at>
9251
9252 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9253 Qclone_number. Remove external declaration of Qdelete_window.
9254 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9255 code.
640c8776
SM
9256 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9257 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9258 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9259 buffer list implementation.
9260 (other_buffer_safely): New function.
9261 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9262 calls to replace_buffer_in_windows and
9263 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9264 if allowed.
9265 (record_buffer): Inhibit quitting and rewrite using quittable
9266 functions. Run Qbuffer_list_update_hook if allowed.
9267 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9268 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9269 Move switch-to-buffer to window.el.
9397e56f
MR
9270 (bury-buffer): Move to window.el.
9271 (Vbuffer_list_update_hook): New variable.
9272
9273 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9274 section.
9275
9276 * window.h (resize_frame_windows): Move up in code.
9277 (Fwindow_frame): Remove EXFUN.
9278 (replace_buffer_in_all_windows): Remove prototype.
9279 (replace_buffer_in_windows_safely): Add prototype.
9280
9281 * window.c: Declare Qdelete_window static again. Move down
9282 declaration of select_count.
9283 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9284 (Fother_window): Move to window.el.
9285 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9286 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9287 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9288 window.el.
9289 (replace_buffer_in_windows): Implement by calling
9290 Qreplace_buffer_in_windows.
9291 (replace_buffer_in_all_windows): Remove with some functionality
9292 moved into replace_buffer_in_windows_safely.
9293 (replace_buffer_in_windows_safely): New function.
9294 (select_window_norecord, select_frame_norecord): Move in front
9295 of run_window_configuration_change_hook. Remove now obsolete
9296 declarations.
640c8776
SM
9297 (Fset_window_buffer): Rewrite doc-string.
9298 Call Qrecord_window_buffer.
9397e56f
MR
9299 (keys_of_window): Move binding for other-window to window.el.
9300
b50691aa
CY
93012011-06-11 Chong Yidong <cyd@stupidchicken.com>
9302
9303 * dispextern.h (struct image): Replace data member, whose int_val
9304 and ptr_val fields were not used by anything, with a single
9305 lisp_val object.
9306
9307 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9308 (gif_clear_image, gif_load, imagemagick_load_image)
9309 (gs_clear_image, gs_load): Callers changed.
9310
3f754b86
PE
93112011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9312
cca69397
PE
9313 * buffer.h: Include <time.h>, for time_t.
9314 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9315
109e28d0
PE
9316 Fix minor problems found by static checking.
9317
60737f02
PE
9318 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9319
4b66faf3
PE
9320 Make identifiers static if they are not used in other modules.
9321 * data.c (Qcompiled_function, Qframe, Qvector):
9322 * image.c (QimageMagick, Qsvg):
9323 * minibuf.c (Qmetadata):
9324 * window.c (resize_window_check, resize_root_window): Now static.
9325 * window.h (resize_window_check, resize_root_window): Remove decls.
9326
109e28d0
PE
9327 * window.c (window_deletion_count, delete_deletable_window):
9328 Remove; unused.
46a4ce9e
PE
9329 (window_body_lines): Now static.
9330 (Fdelete_other_windows_internal): Mark vars as initialized.
9331 Make sure 'resize_failed' is initialized.
9332 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9333 (resize_window_apply): Remove unused local.
9334 * window.h (delete_deletable_window): Remove decl.
9335
109e28d0 9336 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9337 (imagemagick_load_image): Fix pointer signedness problem by changing
9338 last arg from unsigned char * to char *. All uses changed.
9339 Also, fix a local for similar reasons.
9340 Remove unused locals. Remove locals to avoid shadowing.
9341 (fn_rsvg_handle_free): Remove; unused.
9342 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9343 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9344
3f754b86
PE
9345 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9346
2547adb1
CY
93472011-06-10 Chong Yidong <cyd@stupidchicken.com>
9348
9349 * image.c (gif_load): Fix omitted cast error introduced by
9350 2011-06-06 change.
9351
2c8e37d4
MR
93522011-06-10 Martin Rudalics <rudalics@gmx.at>
9353
9354 * window.h (resize_proportionally, orig_total_lines)
9355 (orig_top_line): Remove from window structure.
9356 (set_window_height, set_window_width, change_window_heights)
9357 (Fdelete_window): Remove prototypes.
9358 (resize_frame_windows): Remove duplicate declaration.
9359
440a42e3
EZ
93602011-06-10 Eli Zaretskii <eliz@gnu.org>
9361
9362 * window.h (resize_frame_windows, resize_window_check)
9363 (delete_deletable_window, resize_root_window)
9364 (resize_frame_windows): Declare prototypes.
9365
9366 * window.c (resize_window_apply): Make definition be "static" to
9367 match the prototype.
9368
562dd5e9
MR
93692011-06-10 Martin Rudalics <rudalics@gmx.at>
9370
9371 * window.c: Remove declarations of Qwindow_size_fixed,
9372 window_min_size_1, window_min_size_2, window_min_size,
9373 size_window, window_fixed_size_p, enlarge_window, delete_window.
9374 Remove static from declaration of Qdelete_window, it's
9375 temporarily needed by Fbury_buffer.
9376 (replace_window): Don't assign orig_top_line and
9377 orig_total_lines.
9378 (Fdelete_window, delete_window): Remove. Window deletion is
9379 handled by window.el.
640c8776
SM
9380 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9381 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9382 (Fdelete_other_windows): Remove. Deleting other windows is
9383 handled by window.el.
9384 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9385 handled in window.el.
9386 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9387 Window minimum sizes are handled in window.el.
9388 (shrink_windows, size_window, set_window_height)
9389 (set_window_width, change_window_heights, window_height)
9390 (window_width, CURBEG, CURSIZE, enlarge_window)
9391 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9392 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9393 handled in window.el.
9394 (make_dummy_parent): Rename to make_parent_window and give it a
9395 second argument horflag.
9396 (make_window): Don't set resize_proportionally any more.
9397 (Fsplit_window): Remove. Windows are split in window.el.
9398 (save_restore_action, save_restore_orig_size)
9399 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9400 Resize mini windows in window.el.
9401 (grow_mini_window, shrink_mini_window): Implement by calling
9402 Qresize_root_window_vertically, resize_window_check and
9403 resize_window_apply.
640c8776
SM
9404 (saved_window, Fset_window_configuration, save_window_save):
9405 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9406 resize_proportionally.
9407 (window_min_height, window_min_width): Move to window.el.
9408 (keys_of_window): Move bindings for delete-other-windows,
9409 split-window, delete-window and enlarge-window to window.el.
9410
9411 * buffer.c: Temporarily extern Qdelete_window.
9412 (Fbury_buffer): Temporarily call Qdelete_window instead of
9413 Fdelete_window (Fbury_buffer will move to window.el soon).
9414
9415 * frame.c (set_menu_bar_lines_1): Remove code handling
9416 orig_top_line and orig_total_lines.
9417
9418 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9419 set_window_height but set heights directly.
9420 (change_frame_size_1): Use resize_frame_windows.
9421
9422 * xdisp.c (init_xdisp): Don't use set_window_height but set
9423 heights directly.
9424
640c8776
SM
9425 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9426 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9427 run_window_configuration_change_hook.
9428
9429 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9430 instead of change_window_heights and run
9431 run_window_configuration_change_hook.
9432
1a13852e
MR
94332011-06-09 Martin Rudalics <rudalics@gmx.at>
9434
9435 * window.c (replace_window): Rename second argument REPLACEMENT to
9436 NEW. New third argument SETFLAG. Rewrite.
9437 (delete_window, make_dummy_parent): Call replace_window with
9438 third argument 1.
9439 (window_list_1): Move down in code.
9440 (run_window_configuration_change_hook): Move set_buffer part
9441 before select_frame_norecord part in order to unwind correctly.
9442 Rename count1 to count.
9443 (recombine_windows, delete_deletable_window, resize_root_window)
9444 (Fdelete_other_windows_internal)
9445 (Frun_window_configuration_change_hook, make_parent_window)
9446 (resize_window_check, resize_window_apply, Fresize_window_apply)
9447 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9448 (Fdelete_window_internal, Fresize_mini_window_internal):
9449 New functions.
1a13852e
MR
9450 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9451
f3d1777e
MR
94522011-06-08 Martin Rudalics <rudalics@gmx.at>
9453
496e208e
MR
9454 * window.h (window): Add some new members to window structure -
9455 normal_lines, normal_cols, new_total, new_normal, clone_number,
9456 splits, nest, prev_buffers, next_buffers.
9457 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9458 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9459
f3d1777e
MR
9460 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9461 Remove.
496e208e
MR
9462 (make_dummy_parent): Set new members of windows structure.
9463 (make_window): Move down in code. Handle new members of window
9464 structure.
9465 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9466 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9467 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9468 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9469 (Fset_window_next_buffers, Fset_window_clone_number):
9470 New functions.
496e208e
MR
9471 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9472 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9473 Doc-string fixes.
9474 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9475 Argument WINDOW can be now internal window too.
9476 (Fwindow_use_time): Move up in code.
9477 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9478 Rewrite doc-string.
9479 (Fset_window_configuration, saved_window)
9480 (Fcurrent_window_configuration, save_window_save): Handle new
9481 members of window structure.
b9e809c2
MR
9482 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9483 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9484 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9485 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9486 Qget_mru_window, Qresize_root_window,
9487 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9488 Qauto_buffer_name; staticpro them.
f3d1777e 9489
abde8f8c
MR
94902011-06-07 Martin Rudalics <rudalics@gmx.at>
9491
9492 * window.c (Fwindow_total_size, Fwindow_left_column)
9493 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9494 (Fwindow_list_1): New functions.
9495 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9496 (Fwindow_width, Fscroll_left, Fscroll_right):
9497 Use window_body_cols instead of window_box_text_cols.
9498 (delete_window, Fset_window_configuration):
9499 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9500 (delete_all_subwindows): Take a window as argument and not a
9501 structure. Rewrite.
190b47e6
MR
9502 (window_loop): Remove handling of GET_LRU_WINDOW and
9503 GET_LARGEST_WINDOW.
9504 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9505
9506 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9507 window_box_text_cols. delete_all_subwindows now takes a
9508 Lisp_Object as argument.
abde8f8c 9509
640c8776
SM
9510 * indent.c (compute_motion, Fcompute_motion):
9511 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9512
fa8a67e6
MR
9513 * frame.c (delete_frame): Call delete_all_subwindows with root
9514 window as argument.
9515
a54e3482
DC
95162011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9517
9518 * fns.c (Fputhash): Document return value.
9519
60002bf5
CY
95202011-06-06 Chong Yidong <cyd@stupidchicken.com>
9521
9522 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9523
0c671da6 95242011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9525
b862a52a 9526 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9527
be44ca6c
PE
9528 Check for overflow when converting integer to cons and back.
9529 * charset.c (Fdefine_charset_internal, Fdecode_char):
9530 Use cons_to_unsigned to catch overflow.
9531 (Fencode_char): Use INTEGER_TO_CONS.
9532 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9533 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9534 * data.c (long_to_cons, cons_to_long): Remove.
9535 (cons_to_unsigned, cons_to_signed): New functions.
9536 These signal an error for invalid or out-of-range values.
9537 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9538 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9539 * font.c (Ffont_variation_glyphs):
9540 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9541 * lisp.h: Include <intprops.h>.
9542 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9543 (cons_to_signed, cons_to_unsigned): New decls.
9544 (long_to_cons, cons_to_long): Remove decls.
9545 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9546 (Fprimitive_undo): Use CONS_TO_INTEGER.
9547 * xfns.c (Fx_window_property): Likewise.
9548 * xselect.c: Include <limits.h>.
9549 (x_own_selection, selection_data_to_lisp_data):
9550 Use INTEGER_TO_CONS.
9551 (x_handle_selection_request, x_handle_selection_clear)
9552 (x_get_foreign_selection, Fx_disown_selection_internal)
9553 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9554 (lisp_data_to_selection_data): Use cons_to_unsigned.
9555 (x_fill_property_data): Use cons_to_signed.
9556 Report values out of range.
9557
d1f3d2af
PE
9558 Check for buffer and string overflow more precisely.
9559 * buffer.h (BUF_BYTES_MAX): New macro.
9560 * lisp.h (STRING_BYTES_MAX): New macro.
9561 * alloc.c (Fmake_string):
9562 * character.c (string_escape_byte8):
9563 * coding.c (coding_alloc_by_realloc):
9564 * doprnt.c (doprnt):
9565 * editfns.c (Fformat):
9566 * eval.c (verror):
9567 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9568 since they may not be the same number.
9569 * editfns.c (Finsert_char):
9570 * fileio.c (Finsert_file_contents):
9571 Likewise for BUF_BYTES_MAX.
9572
dd52fcea
PE
9573 * image.c: Use ptrdiff_t, not int, for sizes.
9574 (slurp_file): Switch from int to ptrdiff_t.
9575 All uses changed.
9576 (slurp_file): Check that file size fits in both size_t (for
9577 malloc) and ptrdiff_t (for sanity and safety).
9578
7f9bbdbb
PE
9579 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9580 if b->modtime has its maximal value.
9581
dfe18f82
PE
9582 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9583
84acfcf0
PE
9584 Don't assume time_t can fit into int.
9585 * buffer.h (struct buffer.modtime): Now time_t, not int.
9586 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9587 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9588
ccd9a01a
PE
9589 Minor fixes for signed vs unsigned integers.
9590 * character.h (MAYBE_UNIFY_CHAR):
9591 * charset.c (maybe_unify_char):
9592 * keyboard.c (read_char, reorder_modifiers):
9593 XINT -> XFASTINT, since the integer must be nonnegative.
9594 * ftfont.c (ftfont_spec_pattern):
9595 * keymap.c (access_keymap, silly_event_symbol_error):
9596 XUINT -> XFASTINT, since the integer must be nonnegative.
9597 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9598 since it makes no difference and we prefer signed.
9599 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9600 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9601 nonnegative.
9602
d6d100dd
SM
96032011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9604
9605 * window.h (Fwindow_frame): Declare.
9606
2b6148e4
PE
96072011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9608
9609 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9610 (SPARE_MEMORY): Always define.
9611 (LARGE_REQUEST): Remove.
9612 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9613
f230ecc9
MR
96142011-06-06 Martin Rudalics <rudalics@gmx.at>
9615
727e958e
MR
9616 * lisp.h: Move EXFUNS for Fframe_root_window,
9617 Fframe_first_window and Fset_frame_selected_window to window.h.
9618
9619 * window.h: Move EXFUNS for Fframe_root_window,
9620 Fframe_first_window and Fset_frame_selected_window here from
9621 lisp.h.
9622
9623 * frame.c (Fwindow_frame, Fframe_first_window)
9624 (Fframe_root_window, Fframe_selected_window)
9625 (Fset_frame_selected_window): Move to window.c.
9626 (Factive_minibuffer_window): Move to minibuf.c.
9627 (Fother_visible_frames_p): New function.
9628
9629 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9630
f230ecc9
MR
9631 * window.c (decode_window, decode_any_window): Move up in code.
9632 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9633 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9634 (Fwindow_buffer): Move up and rewrite doc-string.
9635 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9636 (Fwindow_prev): New functions.
727e958e
MR
9637 (Fwindow_frame): Move here from frame.c. Accept any window as
9638 argument.
9639 (Fframe_root_window, Fframe_first_window)
9640 (Fframe_selected_window): Move here from frame.c. Accept frame
9641 or arbitrary window as argument. Update doc-strings.
9642 (Fminibuffer_window): Move up in code.
9643 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9644 (Fset_frame_selected_window): Move here from frame.c.
9645 Marginal rewrite.
727e958e
MR
9646 (Fselected_window, select_window, Fselect_window): Move up in
9647 code. Minor doc-string fixes.
f230ecc9 9648
4d09bcf6
PE
96492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9650
9651 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9652 Do not assume that spare memory exists; that assumption is valid
9653 only if SYSTEM_MALLOC.
9654 (LARGE_REQUEST): New macro, so that the issue of large requests
9655 is separated from the issue of spare memory.
9656
810928a2
AS
96572011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9658
172418ad
AS
9659 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9660 format. (Bug#8806)
9661
43f862f7
AS
9662 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9663
810928a2
AS
9664 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9665 before statements.
9666
a059fe24
JD
96672011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9668
9669 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9670
9671 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9672
9673 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9674 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9675
989bf368
JB
96762011-06-05 Juanma Barranquero <lekktu@gmail.com>
9677
9678 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9679
4b80f674
CY
96802011-06-04 Chong Yidong <cyd@stupidchicken.com>
9681
9682 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9683 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9684 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9685 New error handlers.
4b80f674
CY
9686 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9687 Obey Vx_select_enable_clipboard_manager. Catch errors in
9688 x_clipboard_manager_save (Bug#8779).
9689 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9690 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9691
99a33b77 96922011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9693
9694 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9695
99a33b77 96962011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9697
9698 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9699 in the current matrix if keep_current_p is non-zero.
9700
8264569d
EZ
97012011-06-04 Eli Zaretskii <eliz@gnu.org>
9702
9703 * bidi.c (bidi_level_of_next_char): Fix last change.
9704
57f97249
EZ
97052011-06-03 Eli Zaretskii <eliz@gnu.org>
9706
fec2107c 9707 Support bidi reordering of text covered by display properties.
57f97249 9708
fec2107c
EZ
9709 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9710 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9711 (bidi_cache_search, bidi_cache_iterator_state)
9712 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9713 (bidi_level_of_next_char, bidi_move_to_visually_next):
9714 Support character positions inside a run of characters covered by a
fec2107c
EZ
9715 display string.
9716 (bidi_paragraph_init, bidi_resolve_explicit_1)
9717 (bidi_level_of_next_char): Call bidi_fetch_char and
9718 bidi_fetch_char_advance instead of FETCH_CHAR and
9719 FETCH_CHAR_ADVANCE.
9720 (bidi_init_it): Initialize new members.
9721 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9722 definitions.
9723 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9724 instead of using explicit *_CHAR codes.
d6d100dd
SM
9725 (bidi_resolve_explicit, bidi_resolve_weak):
9726 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9727 bidirectional text is supported only in multibyte buffers.
9728 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9729 it to initialize the frame_window_p member of struct bidi_it.
9730 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9731 (bidi_resolve_explicit, bidi_resolve_weak)
9732 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9733 bidi_it->nchars is non-positive.
9734 (bidi_level_of_next_char): Don't try to lookup the cache for the
9735 next/previous character if nothing is cached there yet, or if we
9736 were just reseat()'ed to a new position.
c40e2fb2 9737
0e14fe90
EZ
9738 * xdisp.c (set_cursor_from_row): Set start and stop points
9739 according to the row's direction when priming the loop that looks
9740 for the glyph on which to display cursor.
9741 (single_display_spec_intangible_p): Function deleted.
9742 (display_prop_intangible_p): Reimplement to call
9743 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9744 Accept 3 additional arguments needed by handle_display_spec.
9745 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9746 values: lists, `(when COND...)' forms, etc.
9747 (single_display_spec_string_p): Support property values that are
9748 lists with the argument STRING its top-level element.
9749 (display_prop_string_p): Fix the condition for processing a
9750 property that is a list to be consistent with handle_display_spec.
fec2107c 9751 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9752 last portion of handle_display_prop.
9753 (compute_display_string_pos): Accept additional argument
9754 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9755 value of a `display' property is a "replacing spec".
9756 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9757 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9758 the display property, but just return a value indicating whether
9759 the display property will replace the characters it covers.
9760 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9761 frame_window_p members of struct bidi_it.
d6d100dd
SM
9762 (compute_display_string_pos, compute_display_string_end):
9763 New functions.
fec2107c
EZ
9764 (push_it): Accept second argument POSITION, where pop_it should
9765 jump to continue iteration.
9766 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9767
fec2107c
EZ
9768 * keyboard.c (adjust_point_for_property): Adjust the call to
9769 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9770
9771 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9772 (bidi_init_it): Update prototypes.
9773 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9774 (compute_display_string_pos, compute_display_string_end):
9775 Declare prototypes.
fec2107c
EZ
9776 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9777 EMACS_INT.
fc6f18ce 9778
40087514 97792011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9780
57f53182
PE
9781 Malloc failure behavior now depends on size of allocation.
9782 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9783 * lisp.h: Change signatures accordingly.
9784 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9785 All callers changed. (Bug#8762)
9786
9787 * gnutls.c: Use Emacs's memory allocators.
9788 Without this change, the gnutls library would invoke malloc etc.
9789 directly, which causes problems on non-SYNC_INPUT hosts, and which
9790 runs afoul of improving memory_full behavior. (Bug#8761)
9791 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9792 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9793 xfree instead of the default malloc, realloc, free.
9794 (Fgnutls_boot): No need to check for memory allocation failure,
9795 since xmalloc does that for us.
9796
ac32cd99 9797 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9798 * category.c (hash_get_category_set):
9799 * ccl.c (ccl_driver):
9800 * charset.c (Fdefine_charset_internal):
9801 * charset.h (struct charset.hash_index):
9802 * composite.c (get_composition_id, gstring_lookup_cache)
9803 (composition_gstring_put_cache):
9804 * composite.h (struct composition.hash_index):
9805 * dispextern.h (struct image.hash):
9806 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9807 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9808 (hashfn_equal, hashfn_user_defined, make_hash_table)
9809 (maybe_resize_hash_table, hash_lookup, hash_put)
9810 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9811 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9812 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9813 * image.c (make_image, search_image_cache, lookup_image)
9814 (xpm_put_color_table_h):
9815 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9816 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9817 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9818 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9819 * alloc.c (allocate_vectorlike):
9820 Check for overflow in vector size calculations.
9821 * ccl.c (ccl_driver):
9822 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9823 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9824 need to be updated by these changes.
40087514
PE
9825 * fns.c (make_hash_table, maybe_resize_hash_table):
9826 Check for integer overflow with large hash tables.
0de4bb68
PE
9827 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9828 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9829 (SXHASH_REDUCE): New macro.
9830 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9831 Use it instead of discarding useful hash info with large hash values.
9832 (sxhash_float): New function.
9833 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9834 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9835 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9836 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9837 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9838 Adjust signatures to match updated version of code.
9839 (consing_since_gc): Now EMACS_INT, since a single hash table can
9840 use more than INT_MAX bytes.
9841
698d32e2
DN
98422011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9843
9844 Make it possible to build with GCC-4.6+ -O2 -flto.
9845
9846 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9847
fd6fa53f
SM
98482011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9849
9850 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9851 Call minibuffer-inactive-mode.
9852
864db017
JB
98532011-05-31 Juanma Barranquero <lekktu@gmail.com>
9854
9855 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9856 Update dependencies.
9857
2ad0baf4
DN
98582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9859
9860 * data.c (init_data): Remove code for UTS, this system is not
9861 supported anymore.
9862
4fcc2638
DN
98632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9864
9865 Don't force ./temacs to start in terminal mode.
9866
9867 * frame.c (make_initial_frame): Initialize faces in all cases, not
9868 only when CANNOT_DUMP is defined.
9869 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9870
c56e0fd5
DN
98712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9872
9873 * dispnew.c (add_window_display_history): Use const for the string
9874 pointer. Remove declaration, not needed.
9875
333d54da 98762011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9877
55d4c1b2 9878 Use 'inline', not 'INLINE'.
333d54da 9879 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9880 * alloc.c, fontset.c (INLINE): Remove.
9881 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9882 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9883 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9884 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9885 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9886
738db178
DN
98872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9888
9889 Make it possible to run ./temacs.
9890
9891 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9892 syms_of_callproc does the same thing. Remove test for
9893 "initialized", do it in the caller.
9894 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9895
620c53a6
SM
98962011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9897
9898 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9899 (read_minibuf): Use get_minibuffer.
9900 (syms_of_minibuf): Use DEFSYM.
9901 (Qmetadata): New var.
9902 * data.c (Qbuffer): Don't make it static.
9903 (syms_of_data): Use DEFSYM.
9904
e003a292
PE
99052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9906
9907 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9908 (CCL_CODE_MIN): New macro.
9909
ed008a6d
PE
99102011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9911
3687c2ef
PE
9912 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9913
ed008a6d
PE
9914 * eval.c (Qdebug): Now static.
9915 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9916 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9917 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9918
d66c4c7c
CY
99192011-05-29 Chong Yidong <cyd@stupidchicken.com>
9920
9921 * image.c: Various fixes to ImageMagick code comments.
9922 (Fimagemagick_types): Doc fix.
9923
5fbc2025
PE
99242011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9925
0196f88a
PE
9926 Minor fixes prompted by GCC 4.6.0 warnings.
9927
9928 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9929
5fbc2025
PE
9930 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9931 (x_clipboard_manager_save_all): Move extern decl to ...
9932 * xterm.h: ... here, so that it can be checked for consistency.
9933
1dd3c2d9
CY
99342011-05-29 Chong Yidong <cyd@stupidchicken.com>
9935
9936 * xselect.c (x_clipboard_manager_save_frame)
9937 (x_clipboard_manager_save_all): New functions.
9938 (Fx_clipboard_manager_save): Lisp function deleted.
9939
9940 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9941 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9942
9943 * xterm.h: Update prototype.
9944
5ba6571d
WX
99452011-05-28 William Xu <william.xwl@gmail.com>
9946
9947 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9948 exiting (Bug#8239).
9949
3eaff834
JM
99502011-05-28 Jim Meyering <meyering@redhat.com>
9951
e1900994 9952 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9953 * fns.c (to_uchar): Define.
9954 (crypto_hash_function): Use it to convert some newly-signed
9955 variables to unsigned, to avoid sign-extension bugs. For example,
9956 without this change, (md5 "truc") would evaluate to
9957 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9958 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9959 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9960
0f6990a7
PE
99612011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9962
9963 Integer overflow fixes.
c8a9ca5a 9964
08686060
PE
9965 * dbusbind.c: Serial number integer overflow fixes.
9966 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9967 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9968 to hold a serial number that is too large for a fixnum.
9969 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9970 Check for serial numbers out of range. Decode any serial number
59568bf0 9971 that was so large that it became a float. (Bug#8722)
08686060 9972
2d1fc3c7
PE
9973 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9974 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9975 Use XFASTINT rather than XUINT when numbers are nonnegative.
9976 (xd_append_arg, Fdbus_method_return_internal):
9977 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9978 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9979 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9980 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9981 (Bug#8722)
2d1fc3c7 9982
c8a9ca5a
PE
9983 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9984
519e1d69
PE
9985 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9986
6df6ae42 9987 ccl: Add integer overflow checks.
30569699
PE
9988 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9989 (IN_INT_RANGE): New macros.
9990 (ccl_driver): Use them to check for integer overflow when
9991 decoding a CCL program. Many of the new checks are whether XINT (x)
9992 fits in int; it doesn't always, on 64-bit hosts. The new version
9993 doesn't catch all possible integer overflows, but it's an
847044ea 9994 improvement. (Bug#8719)
30569699 9995
c11285dc
PE
9996 * alloc.c (make_event_array): Use XINT, not XUINT.
9997 There's no need for unsigned here.
9998
fdccd48e
PE
9999 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10000 This follows up to the 2011-05-06 change that substituted uintptr_t
10001 for EMACS_INT. This case wasn't caught back then.
10002
37910ab2
PE
10003 Rework Fformat to avoid integer overflow issues.
10004 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10005 now (part of C89). Include <verify.h>.
10006 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10007 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10008 (Fformat): Avoid the prepass trying to compute sizes; it was only
10009 approximate and thus did not catch overflow reliably. Instead, walk
10010 through the format just once, formatting and computing sizes as we go,
10011 checking for integer overflow at every step, and allocating a larger
10012 buffer as needed. Keep track separately whether the format is
10013 multibyte. Keep only the most-recently calculated precision, rather
10014 than them all. Record whether each argument has been converted to
10015 string. Use EMACS_INT, not int, for byte and char and arg counts.
10016 Support field widths and precisions larger than INT_MAX. Avoid
10017 sprintf's undefined behavior with conversion specifications such as %#d
10018 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10019 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10020 formatting out-of-range floating point numbers with int
9173deec 10021 formats. (Bug#8668)
37910ab2 10022
2e6578fb
PE
10023 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10024
0ae6bdee
PE
10025 * data.c: Avoid integer truncation in expressions involving floats.
10026 * data.c: Include <intprops.h>.
10027 (arith_driver): When there's an integer overflow in an expression
10028 involving floating point, convert the integers to floating point
10029 so that the resulting value does not suffer from catastrophic
10030 integer truncation. For example, on a 64-bit host (* 4
10031 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10032 Do not rely on undefined behavior after integer overflow.
10033
de883a70
PE
10034 merge count_size_as_multibyte, parse_str_to_multibyte
10035 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10036 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10037 Check for integer overflow.
10038 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10039 since it's now a duplicate of the other. This is more of
10040 a character than a buffer op, so better that it's in character.c.
10041 * fns.c, print.c: Adjust to above changes.
10042
2ff916cb
PE
100432011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10044
10045 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10046
f1b54466
PE
100472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10048
fb1ac845
PE
10049 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10050 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10051 (x_clipboard_manager_save): Now static.
10052 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10053
f1b54466
PE
10054 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10055 (crypto_hash_function): Now static.
10056 Fix pointer signedness problems. Avoid unnecessary initializations.
10057
a9f737ee
CY
100582011-05-27 Chong Yidong <cyd@stupidchicken.com>
10059
10060 * termhooks.h (Vselection_alist): Make it terminal-local.
10061
10062 * terminal.c (create_terminal): Initialize it.
10063
10064 * xselect.c: Support for clipboard managers.
10065 (Vselection_alist): Move to termhooks.h as terminal-local var.
10066 (LOCAL_SELECTION): New macro.
10067 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10068 (symbol_to_x_atom): Remove gratuitous arg.
10069 (x_handle_selection_request, lisp_data_to_selection_data)
10070 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10071 (x_own_selection, x_get_local_selection, x_convert_selection):
10072 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10073 (some_frame_on_display): Delete unused function.
10074 (Fx_own_selection_internal, Fx_get_selection_internal)
10075 (Fx_disown_selection_internal, Fx_selection_owner_p)
10076 (Fx_selection_exists_p): New optional frame arg.
10077 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10078 (x_handle_selection_clear): Don't treat other terminals with the
10079 same keyboard specially. Use the terminal-local Vselection_alist.
10080 (x_clear_frame_selections): Use Frun_hook_with_args.
10081
10082 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10083
10084 * xterm.h: Add support for those atoms.
10085
e067f0c1
CY
100862011-05-26 Chong Yidong <cyd@stupidchicken.com>
10087
10088 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10089 (converted_selections, conversion_fail_tag): New global variables.
10090 (x_selection_request_lisp_error): Free the above.
10091 (x_get_local_selection): Remove unnecessary code.
10092 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10093 of converted selections stored in converted_selections.
10094 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10095 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10096 (x_convert_selection): New function.
10097 (x_handle_selection_event): Simplify.
10098 (x_get_foreign_selection): Don't ignore incoming requests while
10099 waiting for an answer; this will fail when we implement
10100 SAVE_TARGETS, and seems unnecessary anyway.
10101 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10102 (Vx_sent_selection_functions): Doc fix.
10103
0f4aebc0
LL
101042011-05-26 Leo Liu <sdl.web@gmail.com>
10105
10106 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10107
e61124cd
YM
101082011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10109
10110 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10111
10112 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10113 for fringe update if it has periodic bitmap.
ac389d0c 10114 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10115 and fringe_bitmap_periodic_p.
10116
10117 * fringe.c (get_fringe_bitmap_data): New function.
10118 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10119 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10120 row. Mark glyph row for fringe update if periodicity changed.
10121
10122 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10123 for fringe update unless it has periodic bitmap.
10124
f16d9837
KH
101252011-05-25 Kenichi Handa <handa@m17n.org>
10126
10127 * xdisp.c (get_next_display_element): Set correct it->face_id for
10128 a static composition.
10129
e1b90ef6
LL
101302011-05-24 Leo Liu <sdl.web@gmail.com>
10131
10132 * deps.mk (fns.o):
10133 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10134
10135 * fns.c (crypto_hash_function, Fsha1): New function.
10136 (Fmd5): Use crypto_hash_function.
10137 (syms_of_fns): Add Ssha1.
10138
7400048f
PE
101392011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10140
10141 * gnutls.c: Remove unused macros.
10142 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10143 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10144 Remove macros that are defined and never used.
10145 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10146
abb71cf4
CY
101472011-05-22 Chong Yidong <cyd@stupidchicken.com>
10148
10149 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10150 (Fx_get_selection_internal): Minor cleanup.
10151 (Fx_own_selection_internal): Rename arguments for consistency with
10152 select.el.
10153
6307db39
PE
101542011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10155
10156 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10157
f3d4e0a4
CY
101582011-05-22 Chong Yidong <cyd@stupidchicken.com>
10159
10160 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10161
4d8ade89
YM
101622011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10163
10164 * dispnew.c (scrolling_window): Don't exclude the case that the
10165 last enabled row in the desired matrix touches the bottom boundary.
10166
32078c8d
GM
101672011-05-21 Glenn Morris <rgm@gnu.org>
10168
10169 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10170 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10171 and add some more files.
32078c8d 10172
7285dc67
EZ
101732011-05-20 Eli Zaretskii <eliz@gnu.org>
10174
10175 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10176 report_file_error introduced by the change from 2011-05-07.
10177
89d1bd22
PE
101782011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10179
10180 * systime.h (Time): Define only if emacs is defined.
10181 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10182 where the include path doesn't have X11/X.h by default. See
10183 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10184
cd394be1 101852011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10186
10187 * composite.c (find_automatic_composition): Fix previous change.
10188
b9704ad9
GM
101892011-05-20 Glenn Morris <rgm@gnu.org>
10190
10191 * lisp.mk: New file, split from Makefile.in.
10192 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10193 (shortlisp): Remove.
10194 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10195
4a720484
GM
101962011-05-19 Glenn Morris <rgm@gnu.org>
10197
10198 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10199 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10200 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10201 (lisp): Set the order to that of loadup.el.
10202 (shortlisp): Make it a copy of $lisp.
10203 (SOME_MACHINE_LISP): Remove.
10204 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10205 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10206
a28d4396
KH
102072011-05-18 Kenichi Handa <handa@m17n.org>
10208
10209 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10210 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10211 (find_automatic_composition): Mostly rewrite for efficiency.
10212
a2b1fa8e
JB
102132011-05-18 Juanma Barranquero <lekktu@gmail.com>
10214
10215 * makefile.w32-in: Update dependencies.
10216
8e1f5610
CS
102172011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10218
10219 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10220 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10221
7025ee00 102222011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10223
cdfa6eab
PE
10224 Fix some integer overflow issues, such as string length overflow.
10225
06d6db33
PE
10226 * insdel.c (count_size_as_multibyte): Check for string overflow.
10227
2b4560a8
PE
10228 * character.c (lisp_string_width): Check for string overflow.
10229 Use EMACS_INT, not int, for string indexes and lengths; in
10230 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10231 the resulting string length overflows an EMACS_INT; instead,
10232 report a string overflow if no precision given. When checking for
10233 precision exhaustion, use a check that cannot possibly have
10234 integer overflow. (Bug#8675)
10235 * character.h (lisp_string_width): Adjust to new signature.
10236
cb93f9be
PE
10237 * alloc.c (string_overflow): New function.
10238 (Fmake_string): Use it. This doesn't change behavior, but saves
10239 a few bytes and will simplify future changes.
10240 * character.c (string_escape_byte8): Likewise.
10241 * lisp.h (string_overflow): New decl.
10242
1a1f3366
PE
10243 Fixups, following up to the user-interface timestamp change.
10244 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10245 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10246 * msdos.c (mouse_get_pos): Likewise.
10247 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10248 * w32gui.h (Time): Define by including "systime.h" rather than by
10249 declaring it ourselves. (Bug#8664)
10250
d4e3e4d3
PE
10251 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10252 * image.c (clear_image_cache): Likewise.
10253
f6a24d19
PE
10254 * term.c (term_mouse_position): Don't assume time_t wraparound.
10255
08dc5ae6
PE
10256 Be more systematic about user-interface timestamps.
10257 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10258 and sometimes 'EMACS_UINT', to represent these timestamps.
10259 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10260 This makes the code easier to follow, and makes it easier to catch
10261 integer overflow bugs such as Bug#8664.
10262 * frame.c (Fmouse_position, Fmouse_pixel_position):
10263 Use Time, not unsigned long, for user-interface timestamps.
10264 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10265 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10266 * keyboard.h (last_event_timestamp): Likewise.
10267 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10268 * menu.h (xmenu_show): Likewise.
10269 * term.c (term_mouse_position): Likewise.
10270 * termhooks.h (struct input_event.timestamp): Likewise.
10271 (struct terminal.mouse_position_hook): Likewise.
10272 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10273 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10274 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10275 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10276 what it was before.
10277 * menu.h, termhooks.h: Include "systime.h", for Time.
10278
8e55734a
PE
10279 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10280 Don't assume that the difference between two unsigned long values
10281 can fit into an integer. At this point, we know button_down_time
10282 <= event->timestamp, so the difference must be nonnegative, so
10283 there's no need to cast the result if double-click-time is
10284 nonnegative, as it should be; check that it's nonnegative, just in
10285 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10286 apart (about 25 days). (Bug#8664)
8e55734a 10287
841f1b75 10288 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10289 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10290
3e26f69c
PE
10291 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10292 that always fit in int. Use a sentinel instead of a counter, to
10293 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10294 * frame.h (struct frame): Use int for menu_bar_items_used
10295 instead of EMACS_INT, since it always fits in int.
3e26f69c 10296
5cc152c0
PE
10297 * menu.c (grow_menu_items): Check for int overflow.
10298
d89eb65e
PE
10299 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10300
5235bd3e
PE
10301 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10302 Before, the code was not consistent. These values cannot exceed
10303 2**31 - 1 so there's no need to make them unsigned.
10304 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10305 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10306 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10307 as modifiers.
10308 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10309
bc827e23
PE
10310 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10311 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10312 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10313 presumably because the widths might not match.
10314
78eb494e
PE
10315 * window.c (size_window): Avoid needless test at loop start.
10316
04f2d78b
CB
103172011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10318
10319 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10320
d2fc7e3d 103212011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10322
10323 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10324
d2fc7e3d 103252011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10326
10327 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10328 `width' to `bar_area_x' and `bar_area_width', respectively.
10329 (x_scroll_run): Take account of fringe background extension.
10330
04f2d78b
CB
10331 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10332 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10333 `bar_area_width', respectively.
10334 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10335 background extension.
10336
79b70037
GM
103372011-05-10 Jim Meyering <meyering@redhat.com>
10338
10339 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10340
2f142cc5
JB
103412011-05-10 Juanma Barranquero <lekktu@gmail.com>
10342
10343 * image.c (Finit_image_library): Return t for built-in image types,
10344 like pbm and xbm. (Bug#8640)
10345
57679c86
AS
103462011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10347
10348 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10349
888c9e86
EZ
103502011-05-07 Eli Zaretskii <eliz@gnu.org>
10351
b0512a1d
EZ
10352 * w32console.c (Fset_screen_color): Doc fix.
10353 (Fget_screen_color): New function.
10354 (syms_of_ntterm): Defsubr it.
10355
7285dc67
EZ
10356 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10357 unlink the temporary file if Fcall_process didn't create it in the
10358 first place.
10359 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10360 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10361 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10362 cue to call_process_cleanup not to close that handle.
10363
4d3fcc8e
BK
103642011-05-07 Ben Key <bkey76@gmail.com>
10365
10366 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10367 one of two shell specific rules, either bootstrap-temacs-CMD or
10368 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10369 to the previous implementation of the bootstrap-temacs rule.
10370 The bootstrap-temacs-CMD rule is similar to the previous
10371 implementation of the bootstrap-temacs rule except that it
10372 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10373 variable.
10374
10375 These changes, along with some changes to nt/configure.bat,
10376 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10377 earlier fix to add support for --cflags and --ldflags options
10378 that include quotes so that it works whether make uses cmd or
10379 sh as the shell.
10380
b4289b64
MA
103812011-05-06 Michael Albinus <michael.albinus@gmx.de>
10382
10383 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10384 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10385 is a constant.
10386 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10387 a string. Handle both cases.
10388 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10389 (Fdbus_register_method): Use Qinvalid_function.
10390
af4c0e28
JB
103912011-05-06 Juanma Barranquero <lekktu@gmail.com>
10392
10393 * makefile.w32-in: Update dependencies.
10394 (LISP_H): Add inttypes.h and stdin.h.
10395 (PROCESS_H): Add unistd.h.
10396
c51453d9
EZ
103972011-05-06 Eli Zaretskii <eliz@gnu.org>
10398
10399 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10400 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10401
8ff0ac3c 104022011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10403
4c4b566b
PE
10404 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10405
aab2b9b5
PE
10406 * term.c (vfatal): Remove stray call to va_end.
10407 It's not needed and the C Standard doesn't allow it here anyway.
10408
c378da0b
PE
10409 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10410 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10411
288b08c7
PE
10412 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10413 bytes.
10414
e3601888
PE
10415 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10416
db6c0e74
PE
10417 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10418
dd5963ea
PE
10419 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10420
88c9450f
PE
10421 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10422
2f9442b8
PE
10423 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10424
c032b5f8
PE
10425 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10426 * charset.c (Fdefine_charset_internal): Don't initialize
10427 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10428 32-bit int (Bug#8600).
a108c10b
PE
10429
10430 * lread.c (read_integer): Be more consistent with string-to-number.
10431 Use string_to_number to do the actual conversion; this avoids
10432 rounding errors and fixes some other screwups. Without this fix,
10433 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10434 (digit_to_number): Move earlier, for benefit of read_integer.
10435 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10436 not a digit in any supported base. (Bug#8602)
a108c10b 10437
ad5f9eea
PE
10438 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10439
aec1708a
PE
10440 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10441 to match comment at start of function. This also removes a
10442 GCC warning about overflow in a 32+64-bit port.
10443
47be4ab5
PE
10444 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10445
371cac43
PE
10446 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10447 Reported by Stefan Monnier in
10448 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10449 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10450 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10451
d01a7826
PE
10452 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10453 (EMACS_UINTPTR): Likewise, with uintptr_t.
10454
7fd47d5c
PE
10455 * lisp.h: Prefer 64-bit EMACS_INT if available.
10456 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10457 on 32-bit hosts that have 64-bit int, so that they can access
10458 large files.
122b0c86
PE
10459 However, temporarily disable this change unless the temporary
10460 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10461
8727937b
PE
10462 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10463
8ac068ac
PE
10464 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10465 This removes an assumption that EMACS_INT and long are the same
10466 width as pointers. The assumption is true for Emacs porting targets
10467 now, but we want to make other targets possible.
10468 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10469 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10470 In the rest of the code, change types of integers that hold casted
10471 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10472 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10473 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10474 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10475 No need to cast type when ORing.
10476 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10477 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10478 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10479 assume EMACS_INT is the same width as char *.
10480 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10481 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10482 Remove no-longer-needed casts.
10483 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10484 (xg_tool_bar_help_callback, xg_make_tool_item):
10485 Use EMACS_INTPTR to hold an integer
10486 that will be cast to void *; this can avoid a GCC warning
10487 if EMACS_INT is not the same width as void *.
10488 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10489 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10490 (current_message_1, set_message_1):
10491 Use a local to convert to proper width without a cast.
10492 * xmenu.c (dialog_selection_callback): Likewise.
10493
ede49d71
PE
10494 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10495 Also, don't assume VALBITS / RAND_BITS is less than 5,
10496 and don't rely on undefined behavior when shifting a 1 left into
10497 the sign bit.
10498 * lisp.h (get_random): Change signature to match.
10499
2f30ecd0
PE
10500 * lread.c (hash_string): Use size_t, not int, for hash computation.
10501 Normally we prefer signed values; but hashing is special, because
10502 it's better to use unsigned division on hash table sizes so that
10503 the remainder is nonnegative. Also, size_t is the natural width
10504 for hashing into memory. The previous code used 'int', which doesn't
10505 retain enough info to hash well into very large tables.
10506 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10507
2a866e7b
PE
10508 * dbusbind.c: Don't possibly lose pointer info when converting.
10509 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10510 Use XPNTR rather than XHASH, so that the high-order bits of
10511 the pointer aren't lost when converting through void *.
10512
51639eac
PE
10513 * eval.c (Fautoload): Don't double-shift a pointer.
10514
92394119
PE
10515 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10516
dbdb9a7c
JB
105172011-05-06 Juanma Barranquero <lekktu@gmail.com>
10518
10519 * gnutls.c (DEF_GNUTLS_FN):
10520 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10521
db7a0b4f
AS
105222011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10523
10524 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10525 marker. (Bug#8610)
10526
cd394be1 105272011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10528
10529 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10530 New version that can reserve upto 2GB of heap space.
10531
f7ff1b0f 105322011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10533
10534 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10535
639c109b
TZ
105362011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10537
10538 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10539 `gnutls_certificate_set_x509_key_file'.
10540
d2127135
JB
105412011-05-05 Juanma Barranquero <lekktu@gmail.com>
10542
10543 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10544 Update dependencies.
10545
e968f4f3
JB
105462011-05-04 Juanma Barranquero <lekktu@gmail.com>
10547
10548 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10549 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10550 Remove unused parameter `fildes'.
10551 * process.c (read_process_output, send_process): Don't pass it.
10552
84d358f0
JB
105532011-05-04 Juanma Barranquero <lekktu@gmail.com>
10554
10555 Fix previous change: the library cache is defined in w32.c.
10556 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10557 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10558
0898ca10
JB
105592011-05-04 Juanma Barranquero <lekktu@gmail.com>
10560
10561 Implement dynamic loading of GnuTLS on Windows.
10562
10563 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10564 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10565 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10566 Declare.
10567
10568 * gnutls.c (Qgnutls_dll): Define.
10569 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10570 (gnutls_*): Declare function pointers.
10571 (init_gnutls_functions): New function to initialize function pointers.
10572 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10573 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10574 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10575 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10576 (emacs_gnutls_write, emacs_gnutls_read)
10577 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10578 (Fgnutls_available_p): New function.
10579 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10580 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10581 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10582
10583 * image.c: Include w32.h.
10584 (Vimage_type_cache): Delete.
10585 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10586 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10587 (w32_delayed_load): Move to w32.c.
10588
10589 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10590
10591 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10592 (w32_delayed_load): Move from image.c. When loading a library, record
10593 its filename in the :loaded-from property of the library id.
10594 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10595 Initialize and staticpro them.
10596 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10597
10598 * process.c: Include lisp.h before w32.h, not after.
10599 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10600 instead of gnutls_record_check_pending.
10601
10602 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10603
ff4de4aa
TZ
106042011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10605
10606 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10607 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10608 as passed in.
10609
abe95abb
JD
106102011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10611
10612 * xterm.c (x_set_frame_alpha): Do not set property on anything
10613 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10614
e16e55d4
JB
106152011-05-02 Juanma Barranquero <lekktu@gmail.com>
10616
10617 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10618
bafcf6a5
JB
106192011-05-02 Juanma Barranquero <lekktu@gmail.com>
10620
10621 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10622 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10623 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10624 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10625 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10626 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10627 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10628 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10629 (Qgnutls_bootprop_callbacks_verify): Make static.
10630
e7a6747f
AS
106312011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10632
19ed11ba
AS
10633 * callproc.c: Indentation fixup.
10634
e7a6747f 10635 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10636 (wait_for_termination, interruptible_wait_for_termination):
10637 Move after wait_for_termination_1.
e7a6747f 10638
1ef14cb4
LMI
106392011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10640
10641 * sysdep.c (interruptible_wait_for_termination): New function
10642 which is like wait_for_termination, but allows keyboard
10643 interruptions.
10644
10645 * callproc.c (Fcall_process): Add (:file "file") as an option for
10646 the STDOUT buffer.
10647 (Fcall_process_region): Ditto.
10648
330d880c
EZ
106492011-04-30 Eli Zaretskii <eliz@gnu.org>
10650
8db90b73
EZ
10651 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10652 rather than `XVECTOR (FOO)->size'.
10653
330d880c
EZ
10654 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10655 inttypes.h, as a gnulib replacement is used if it not available in
10656 system headers.
10657
15cbd324
EZ
106582011-04-21 Eli Zaretskii <eliz@gnu.org>
10659
10660 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10661 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10662 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10663
10664 * coding.c (coding_alloc_by_realloc): Error out if destination
10665 will grow beyond MOST_POSITIVE_FIXNUM.
10666 (decode_coding_emacs_mule): Abort if there isn't enough place in
10667 charbuf for the composition carryover bytes. Reserve an extra
10668 space for up to 2 characters produced in a loop.
10669 (decode_coding_iso_2022): Abort if there isn't enough place in
10670 charbuf for the composition carryover bytes.
10671
106722011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10673
ae940cca
EZ
10674 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10675 aborting when %lld or %lll format is passed.
10676 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10677 %llo or %llx format is passed. (Bug#8545)
10678
03ab8921
EZ
10679 * window.c (window_scroll_line_based): Use a marker instead of
10680 simple variables to record original value of point. (Bug#7952)
10681
afda1437
EZ
10682 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10683 produced by %s or %c overflows available buffer space. (Bug#8545)
10684
f76dee0c
PE
106852011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10686
10687 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10688 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10689
fdc5744d
JB
106902011-04-28 Juanma Barranquero <lekktu@gmail.com>
10691
10692 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10693
638f053a
JB
106942011-04-28 Juanma Barranquero <lekktu@gmail.com>
10695
10696 * keyboard.c (Qdelayed_warnings_hook): Define.
10697 (command_loop_1): Run `delayed-warnings-hook'
10698 if Vdelayed_warnings_list is non-nil.
10699 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10700 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10701
d178f871
EZ
107022011-04-28 Eli Zaretskii <eliz@gnu.org>
10703
10704 * doprnt.c (doprnt): Don't return value smaller than the buffer
10705 size if the message was truncated. (Bug#8545).
10706
b124fd93
JB
107072011-04-28 Juanma Barranquero <lekktu@gmail.com>
10708
10709 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10710 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10711
e810457d
PE
107122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10713
10714 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10715
ea51cceb
JB
107162011-04-27 Juanma Barranquero <lekktu@gmail.com>
10717
10718 * makefile.w32-in: Update dependencies.
10719
94dcfacf
EZ
107202011-04-27 Eli Zaretskii <eliz@gnu.org>
10721
10722 Improve `doprnt' and its usage. (Bug#8545)
10723 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10724 `format_end'. Remove support for %l as a conversion specifier.
10725 Don't use xrealloc. Improve diagnostics when the %l size modifier
10726 is used. Update the commentary.
10727
10728 * eval.c (verror): Simplify calculation of size_t.
10729
10730 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10731 messages.
10732
f61f41d7
PE
107332011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10734
10735 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10736 change.
10737
96fb4434
PE
107382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10739
10740 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10741 This makes this file independent of the recent pseudovector change.
10742
671875da 107432011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10744
69e9b5a3
PE
10745 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10746
b5f869a7 10747 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10748 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10749 Remove unused local.
c8926152 10750 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10751
841a1577 10752 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10753 GCC 4.6.0 optimizes based on type-based alias analysis.
10754 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10755 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10756 != &v->size, and therefore "v->size = 1; b->size = 2; return
10757 v->size;" must therefore return 1. This assumption is incorrect
10758 for Emacs, since it type-puns struct Lisp_Vector * with many other
10759 types. To fix this problem, this patch adds a new type struct
f904488f 10760 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10761 and pseudovectors, and helps optimizing compilers not get fooled
10762 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10763 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10764 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10765 the size member.
eab3844f
PE
10766 (XSETPVECTYPE): Rewrite in terms of new macro.
10767 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10768 This is a bit clearer, and further avoids the possibility of
10769 undesirable aliasing.
10770 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10771 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10772 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10773 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10774 (ASIZE): Now uses header.size rather than size.
10775 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10776 to avoid the hassle of writing XVECTOR (foo)->header.size.
10777 (struct vectorlike_header): New type.
eab3844f
PE
10778 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10779 object, to help avoid aliasing.
10780 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10781 (SUBRP): Likewise, since Lisp_Subr is a special case.
10782 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10783 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10784 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10785 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10786 changed to be "header.size" and "header.next".
10787 * buffer.h (struct buffer): Likewise.
10788 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10789 * frame.h (struct frame): Likewise.
10790 * process.h (struct Lisp_Process): Likewise.
10791 * termhooks.h (struct terminal): Likewise.
10792 * window.c (struct save_window_data, struct saved_window): Likewise.
10793 * window.h (struct window): Likewise.
10794 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10795 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10796 * buffer.c (init_buffer_once): Likewise.
10797 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10798 special case.
10799 * process.c (Fformat_network_address): Use local var for size,
10800 for brevity.
10801
0df1eac5
PE
10802 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10803
847ab9d1 10804 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10805 * data.c (atof): Remove decl; no longer used or needed.
10806 (digit_to_number): Move to lread.c.
10807 (Fstring_to_number): Use new string_to_number function, to be
10808 consistent with how the Lisp reader treats infinities and NaNs.
10809 Do not assume that floating-point numbers represent EMACS_INT
10810 without losing information; this is not true on most 64-bit hosts.
10811 Avoid double-rounding errors, by insisting on integers when
10812 parsing non-base-10 numbers, as the documentation specifies.
10813 * lisp.h (string_to_number): New decl, replacing ...
10814 (isfloat_string): Remove.
bc0a5c13 10815 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10816 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10817 appears to have been a coding error. Similarly, do not accept
10818 strings like +-1e0 as floating point numbers. Do not report
10819 overflow for integer overflows unless the base is not 10 which
10820 means we have no simple and reliable way to continue.
10821 Break out the floating-point parsing into a new
10822 function string_to_number, so that Fstring_to_number parses
10823 floating point numbers consistently with the Lisp reader.
04f2d78b 10824 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10825 (E_CHAR, EXP_INT): Remove, replacing with ...
10826 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10827 (string_to_number): New function, replacing isfloat_string.
10828 This function checks for valid syntax and produces the resulting
10829 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10830 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10831 so that overflow for non-base-10 numbers is reported only when
10832 there's no portable and simple way to convert to floating point.
452f4150 10833
67769ffc
PE
10834 * textprop.c (set_text_properties_1): Rewrite for clarity,
10835 and to avoid GCC warning about integer overflow.
10836
c20db43f
PE
10837 * intervals.h (struct interval): Use EMACS_INT for members
10838 where EMACS_UINT might cause problems. See
10839 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10840 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10841 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10842 All uses changed.
37aa2f85
PE
10843 (offset_intervals): Tell GCC not to worry about length overflow
10844 when negating a negative length.
c20db43f 10845
2538aa2f
PE
10846 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10847 (overrun_check_free): Likewise.
10848
f2d3008d
PE
10849 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10850 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10851 word size.
10852
ec8df744
PE
10853 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10854 (gnutls_make_error): Rename local to avoid shadowing.
10855 (gnutls_emacs_global_deinit): ifdef out; not used.
10856 (Fgnutls_boot): Use const for pointer to readonly storage.
10857 Comment out unused local. Fix pointer signedness problems.
10858
640ee02d
PE
10859 * lread.c (openp): Don't stuff size_t into an 'int'.
10860 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10861 about possible signed overflow.
10862
6048fb2a
PE
10863 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10864 (GDK_KEY_g): Don't define if already defined.
10865 (xg_prepare_tooltip): Avoid pointer signedness problem.
10866 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10867
fa3c87e1
PE
10868 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10869 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10870
2172544b
PE
10871 * xfns.c (Fx_window_property): Simplify a bit,
10872 to make a bit faster and to avoid GCC 4.6.0 warning.
10873 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10874
9b821a21
PE
10875 * fns.c (internal_equal): Don't assume size_t fits in int.
10876
3c616cfa
PE
10877 * alloc.c (compact_small_strings): Tighten assertion a little.
10878
c2982e87
PE
10879 Replace pEd with more-general pI, and fix some printf arg casts.
10880 * lisp.h (pI): New macro, generalizing old pEd macro to other
10881 conversion specifiers. For example, use "...%"pI"d..." rather
10882 than "...%"pEd"...".
10883 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10884 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10885 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10886 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10887 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10888 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10889 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10890 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10891 64-bit hosts.
10892 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10893 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10894 * print.c (safe_debug_print, print_object): Likewise.
10895 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10896 to int.
6f04d126
PE
10897 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10898 avoiding the 0 flag, which is not portable.
c2982e87
PE
10899 * process.c (Fmake_network_process): Use pI to avoid cast.
10900 * region-cache.c (pp_cache): Likewise.
10901 * xdisp.c (decode_mode_spec): Likewise.
10902 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10903 behavior on 64-bit hosts with printf arg.
6f04d126 10904 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10905 (x_stop_queuing_selection_requests): Likewise.
10906 (x_get_window_property): Don't truncate byte count to an 'int'
10907 when tracing.
0b432f21 10908
5e073ec7
PE
10909 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10910 here, since it parses constructs like leading '-' and spaces,
10911 which are not wanted; and it overflows with large numbers.
10912 Instead, simply match F[0-9]+, which is what is wanted anyway.
10913
36372bf9
PE
10914 * alloc.c: Remove unportable assumptions about struct layout.
10915 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10916 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10917 (allocate_vectorlike, make_pure_vector): Use the new macros,
10918 plus offsetof, to remove unportable assumptions about struct layout.
10919 These assumptions hold on all porting targets that I know of, but
10920 they are not guaranteed, they're easy to remove, and removing them
10921 makes further changes easier.
10922
0b432f21
PE
10923 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10924 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10925 (string_overrun_cookie): Now const. Use initializers that
10926 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10927 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10928 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10929 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10930 multiple of sizeof (EMACS_INT); it need not be, if
10931 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10932 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10933
895009e1
JB
109342011-04-26 Juanma Barranquero <lekktu@gmail.com>
10935
10936 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10937
6a7a1b0b
TZ
109382011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10939
10940 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10941 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10942 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10943
841a1577 109442011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10945
10946 * lisp.h (Qdebug): List symbol.
895009e1 10947 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10948 * keyboard.c (debug-on-event): New variable.
10949 (handle_user_signal): Break into debugger when debug-on-event
10950 matches the current signal symbol.
10951
f2d3ba6f
DN
109522011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10953
10954 * alloc.c (check_sblock, check_string_bytes)
10955 (check_string_free_list): Convert to standard C.
10956
42ce4c63
TZ
109572011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10958
10959 * w32.c (emacs_gnutls_push): Fix typo.
10960
825cd63c
EZ
109612011-04-25 Eli Zaretskii <eliz@gnu.org>
10962
fb11d64d
EZ
10963 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10964 "cast to pointer from integer of different size".
10965
825cd63c
EZ
10966 Improve doprnt and its use in verror. (Bug#8545)
10967 * doprnt.c (doprnt): Document the set of format control sequences
10968 supported by the function. Use SAFE_ALLOCA instead of always
10969 using `alloca'.
10970
10971 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10972 is one byte too soon. Don't use xrealloc; instead xfree and
10973 xmalloc anew.
10974
e061a11b
TZ
109752011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10976
10977 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10978 callbacks stage.
10979
10980 * gnutls.c: Renamed global_initialized to
10981 gnutls_global_initialized. Added internals for the
10982 :verify-hostname-error, :verify-error, and :verify-flags
10983 parameters of `gnutls-boot' and documented those parameters in the
10984 docstring. Start callback support.
9173deec
JB
10985 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10986 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10987 on error. Return error code.
e061a11b
TZ
10988 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10989 (emacs_gnutls_read): Likewise.
10990 (Fgnutls_boot): Return handshake error code.
10991 (emacs_gnutls_handle_error): New function.
10992 (wsaerror_to_errno): Likewise.
10993
10994 * w32.h (emacs_gnutls_pull): Add prototype.
10995 (emacs_gnutls_push): Likewise.
10996
10997 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10998 (emacs_gnutls_push): Likewise.
10999
110002011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11001
11002 * process.c (wait_reading_process_output): Check if GnuTLS
11003 buffered some data internally if no FDs are set for TLS
11004 connections.
11005
11006 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11007 (LIBS): Link to USER_LIBS.
11008 ($(BLD)/gnutls.$(0)): New target.
11009
fa6996bc
EZ
110102011-04-24 Eli Zaretskii <eliz@gnu.org>
11011
eb35682e
EZ
11012 * xdisp.c (handle_single_display_spec): Rename the
11013 display_replaced_before_p argument into display_replaced_p, to
11014 make it consistent with the commentary. Fix typos in the
11015 commentary.
11016
e2ad650c
EZ
11017 * textprop.c (syms_of_textprop): Remove dead code.
11018 (copy_text_properties): Delete obsolete commentary about an
11019 interface that was deleted long ago. Fix typos in the description
11020 of arguments.
11021
1b2de274
EZ
11022 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11023 to changes in oldXMenu/XMenu.h from 2011-04-16.
11024 <menu_help_message, prev_menu_help_message>: Constify.
11025 (IT_menu_make_room): menu->help_text is now `const char **';
11026 adjust.
11027
11028 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11029 to changes in oldXMenu/XMenu.h from 2011-04-16.
11030 (struct XMenu): Declare `help_text' `const char **'.
11031
11032 * xfaces.c <Qunspecified>: Make extern again.
11033
11034 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11035 required by POSIX.
1b2de274 11036
762b15be
EZ
11037 * doc.c (get_doc_string): Improve the format passed to `error'.
11038
11039 * doprnt.c (doprnt): Improve commentary.
11040
11041 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11042
11043 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11044 them with etags.
11045
f1052e5d
EZ
11046 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11047 changes in globals.h immediately force recompilation.
762b15be
EZ
11048 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11049 $(CURDIR)/s/ms-w32.h.
11050 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11051
fa6996bc
EZ
11052 * character.c (Fchar_direction): Function deleted.
11053 (syms_of_character): Don't defsubr it.
11054 <char-direction-table>: Deleted.
11055
e6c3da20
EZ
110562011-04-23 Eli Zaretskii <eliz@gnu.org>
11057
11058 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11059 * doprnt.c: Include limits.h.
11060 (SIZE_MAX): New macro.
04f2d78b
CB
11061 (doprnt): Return a size_t value. 2nd arg is now size_t.
11062 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11063 Improve overflow protection. Support `l' modifier for integer
11064 conversions. Support %l conversion. Don't assume an EMACS_INT
11065 argument for integer conversions and for %c.
11066
11067 * lisp.h (doprnt): Restore prototype.
11068
11069 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11070 $(SRC)/character.h.
11071
11072 * Makefile.in (base_obj): Add back doprnt.o.
11073
11074 * deps.mk (doprnt.o): Add back prerequisites.
11075 (callint.o): Depend on character.h.
11076
11077 * eval.c (internal_lisp_condition_case): Include the handler
11078 representation in the error message.
11079 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11080 when breaking from the loop.
11081
11082 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11083
11084 * callint.c (Fcall_interactively): When displaying error message
11085 about invalid control letter, pass the character's codepoint, not
11086 a pointer to its multibyte form. Improve display of the character
11087 in octal and display also its hex code.
11088
11089 * character.c (char_string): Use %x to display the (unsigned)
11090 codepoint of an invalid character, to avoid displaying a bogus
11091 negative value.
11092
11093 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11094 `error', not SYMBOL_NAME itself.
11095
11096 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11097 character arguments to `error'.
11098
11099 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11100 to `error' in error message about FINAL_CHAR argument. Make sure
11101 FINAL_CHAR is a character, and use %c when it is passed as
11102 argument to `error'.
11103
4ffd0d6b 111042011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11105
11106 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11107
11108 * w32.c: Include <time.h>.
11109 (sys_localtime): New function.
11110
4ffd0d6b 111112011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11112
11113 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11114
4ffd0d6b 11115 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11116
4ffd0d6b 111172011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11118
4ffd0d6b
GM
11119 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11120 zombies (Bug#8467).
aac0c6e3 11121
04c56954
EZ
111222011-04-19 Eli Zaretskii <eliz@gnu.org>
11123
11124 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11125 gl_state.e_property when gl_state.object is Qt.
11126
11127 * insdel.c (make_gap_larger): Remove limitation of buffer size
11128 to <= INT_MAX.
11129
16a43933
CY
111302011-04-18 Chong Yidong <cyd@stupidchicken.com>
11131
11132 * xdisp.c (lookup_glyphless_char_display)
11133 (produce_glyphless_glyph): Handle cons cell entry in
11134 glyphless-char-display.
11135 (Vglyphless_char_display): Document it.
11136
11137 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11138 glyphless-char-display.
11139
4581706e
CY
111402011-04-17 Chong Yidong <cyd@stupidchicken.com>
11141
11142 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11143
11144 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11145
11146 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11147 definition for no-X builds.
11148
4887c6e2 111492011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11150
fd35b6f9
PE
11151 Static checks with GCC 4.6.0 and non-default toolkits.
11152
5c1ccb01
PE
11153 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11154
006c5daa
PE
11155 * process.c (keyboard_bit_set): Define only if SIGIO.
11156 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11157 (send_process): Repair possible setjmp clobbering.
11158
efc736d3
PE
11159 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11160
4e2fe2e6
PE
11161 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11162
f97334a2
PE
11163 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11164
4e75f29d
PE
11165 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11166 Define only if needed.
11167
90efadd1
PE
11168 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11169 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11170 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11171
3c647824
PE
11172 * dispextern.h (struct redisplay_interface): Rename param
11173 to avoid shadowing.
e264f262 11174 * termhooks.h (struct terminal): Likewise.
761383f4 11175 * xterm.c (xembed_send_message): Likewise.
3c647824 11176
b58c5c4a
PE
11177 * insdel.c (make_gap_smaller): Define only if
11178 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11179
cad59032
PE
11180 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11181 it.
11182
c339dc2e
PE
11183 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11184 so that we aren't warned about unused symbols.
11185
91a3e27b
PE
11186 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11187
399c71d3 11188 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11189
8ffc96f5
PE
11190 * xfns.c (x_real_positions): Mark locals as initialized.
11191
eef9bc79
PE
11192 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11193
098db9dd
PE
11194 * xterm.c: Fix problems found by static analysis with other toolkits.
11195 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11196 (x_dispatch_event): Declare static if USE_GTK, and
11197 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11198 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11199 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11200 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11201 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11202
eb18f6cc
PE
11203 * xmenu.c (menu_help_callback): Pointer type fixes.
11204 Use const pointers when pointing at readonly data. Avoid pointer
11205 signedness clashes.
11206 (FALSE): Remove unused macro.
11207 (update_frame_menubar): Remove unused decl.
11208
1fe72bf8
PE
11209 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11210
60d9e1db
PE
11211 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11212 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11213 (single_menu_item): Rename local to avoid shadowing.
11214
39261c26
PE
11215 * keyboard.c (make_lispy_event): Remove unused local var.
11216
018c5e19
PE
11217 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11218 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11219
63d2b86e
PE
11220 * bitmaps: Change bitmaps from unsigned char back to the X11
11221 compatible char. Avoid the old compiler warnings about
11222 out-of-range initializers by using, for example, '\xab' rather
11223 than 0xab.
11224
aefd87e1
PE
11225 * xgselect.c (xgselect_initialize): Check vs interface
11226 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11227
bf501fb9
PE
11228 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11229
e9829fdf
PE
11230 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11231 to read-only memory.
11232
1086c095
PE
11233 * fns.c (vector): Remove; this old hack is no longer needed.
11234
2baccd04 11235 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11236 Remove unused var.
dde42981 11237 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11238
72391843 11239 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11240
436c16df 11241 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11242 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11243 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11244
92bb796d 11245 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11246 (x_term_init): Remove local to avoid shadowing.
92bb796d 11247
764430a3 11248 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11249
11250 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11251 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11252
d1dfb56c
EZ
112532011-04-16 Eli Zaretskii <eliz@gnu.org>
11254
c4354cb4
EZ
11255 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11256
d1dfb56c
EZ
11257 Fix regex.c, syntax.c and friends for buffers > 2GB.
11258 * syntax.h (struct gl_state_s): Declare character position members
11259 EMACS_INT.
11260
11261 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11262
04f2d78b
CB
11263 * textprop.c (verify_interval_modification, interval_of):
11264 Declare arguments EMACS_INT.
d1dfb56c
EZ
11265
11266 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11267 EMACS_INT.
11268
11269 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11270
11271 * indent.c (Fvertical_motion): Local variable it_start is now
11272 EMACS_INT.
11273
11274 * regex.c (re_match, re_match_2, re_match_2_internal)
11275 (bcmp_translate, regcomp, regexec, print_double_string)
11276 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11277 (re_compile_pattern, re_exec): Declare arguments and local
11278 variables `size_t' and `ssize_t' and return values `regoff_t', as
11279 appropriate.
11280 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11281 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11282 <compile_stack_type>: `size' and `avail' are now `size_t'.
11283
11284 * regex.h <regoff_t>: Use ssize_t, not int.
11285 (re_search, re_search_2, re_match, re_match_2): Arguments that
11286 specify buffer/string position and length are now ssize_t and
11287 size_t. Return type is regoff_t.
11288
613052cd
BK
112892011-04-16 Ben Key <bkey76@gmail.com>
11290
11291 * nsfont.m: Fixed bugs in ns_get_family and
11292 ns_descriptor_to_entity that were caused by using free to
11293 deallocate memory blocks that were allocated by xmalloc (via
11294 xstrdup). This caused Emacs to crash when compiled with
11295 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11296 --enable-checking=xmallocoverrun). xfree is now used to
11297 deallocate these memory blocks.
11298
4170f62f 112992011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11300
71b41406
PE
11301 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11302
9587a89d
PE
11303 emacs_write: Accept and return EMACS_INT for sizes.
11304 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11305 et seq.
11306 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11307 Accept and return EMACS_INT.
11308 (emacs_gnutls_write): Return the number of bytes written on
11309 partial writes.
11310 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11311 (emacs_read, emacs_write): Remove check for negative size, as the
11312 Emacs source code has been audited now.
9587a89d
PE
11313 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11314 (emacs_read, emacs_write): Use it.
273a5f82
PE
11315 * process.c (send_process): Adjust to the new signatures of
11316 emacs_write and emacs_gnutls_write. Do not attempt to store
11317 a byte offset into an 'int'; it might overflow.
9587a89d 11318 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11319
3e047f51
PE
11320 * sound.c: Don't assume sizes fit in 'int'.
11321 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11322 Return EMACS_INT, not int.
3e047f51 11323 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11324 Accept EMACS_INT, not int.
11325 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11326 record read return values.
11327
cc39a9db
BK
113282011-04-15 Ben Key <bkey76@gmail.com>
11329
c9d0ec6d
JB
11330 * keyboard.c (Qundefined): Don't declare static since it is used
11331 in nsfns.m.
11332 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11333 static since they are used in nsfont.m.
cc39a9db 11334
6c60eb9f
SM
113352011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11336
11337 * process.c (Qprocessp): Don't declare static.
11338 * lisp.h (Qprocessp): Declare again.
11339
7990b61a
JB
113402011-04-15 Juanma Barranquero <lekktu@gmail.com>
11341
11342 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11343
5d4cb038
PE
113442011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11345
8bd7b830 11346 Improve C-level modularity by making more things 'static'.
cd64ea1d 11347
e3b27b31
PE
11348 Don't publish debugger-only interfaces to other modules.
11349 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11350 (verify_bytepos, count_markers): Move decls to the only modules
11351 that need them.
11352 * region-cache.h (pp_cache): Likewise.
11353 * window.h (check_all_windows): Likewise.
11354 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11355
5d4cb038
PE
11356 * sysdep.c (croak): Now static, if
11357 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11358 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11359
11360 * alloc.c (refill_memory_reserve): Now static if
11361 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11362 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11363
e87b6180
PE
11364 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11365 Define only if USE_LUCID.
11366
ac64929e
PE
11367 * xrdb.c (x_customization_string, x_rm_string): Now static.
11368
6f37259d
PE
11369 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11370 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11371
1683e3ab
PE
11372 * xdisp.c (draw_row_with_mouse_face): Now static.
11373 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11374
de9c2632
PE
11375 * window.h (check_all_windows): Mark externally visible.
11376
2b96acb7
PE
11377 * window.c (window_deletion_count): Now static.
11378
11379 * undo.c: Make symbols static if they're not exported.
11380 (last_undo_buffer, last_boundary_position, pending_boundary):
11381 Now static.
11382
50436f33
PE
11383 * textprop.c (interval_insert_behind_hooks): Now static.
11384 (interval_insert_in_front_hooks): Likewise.
11385
64520e5c
PE
11386 * term.c: Make symbols static if they're not exported.
11387 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11388 (max_frame_lines, tty_set_terminal_modes):
11389 (tty_reset_terminal_modes, tty_turn_off_highlight):
11390 (get_tty_terminal): Now static.
11391 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11392 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11393 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11394 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11395 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11396
1fa53021
PE
11397 * sysdep.c: Make symbols static if they're not exported.
11398 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11399 Now static.
11400 (sigprocmask_set, full_mask): Remove; unused.
11401 (wait_debugging): Mark as visible.
11402 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11403 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11404
d4b43b22
PE
11405 * syntax.c (syntax_temp): Define only if !__GNUC__.
11406
b7c513d0
PE
11407 * sound.c (current_sound_device, current_sound): Now static.
11408
989b29ad
PE
11409 * search.c (searchbufs, searchbuf_head): Now static.
11410
13a55a78
PE
11411 * scroll.c (scroll_cost): Remove; unused.
11412 * dispextern.h (scroll_cost): Remove decl.
11413
de68a1fc
PE
11414 * region-cache.h (pp_cache): Mark as externally visible.
11415
40ccffa6
PE
11416 * process.c: Make symbols static if they're not exported.
11417 (process_tick, update_tick, create_process, chan_process):
11418 (Vprocess_alist, proc_buffered_char, datagram_access):
11419 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11420 (deactivate_process): Mark defn as static, as well as decl.
11421 * lisp.h (create_process): Remove decl.
11422 * process.h (chan_process, Vprocess_alist): Remove decls.
11423
ad64fc97
PE
11424 * print.c: Make symbols static if they're not exported.
11425 (print_depth, new_backquote_output, being_printed, print_buffer):
11426 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11427 (print_interval, print_number_index, initial_stderr_stream):
11428 Now static.
11429 * lisp.h (Fprinc): Remove decl.
11430 (debug_output_compilation_hack): Mark as externally visible.
11431
adddb265
PE
11432 * sysdep.c (croak): Move decl from here to syssignal.h.
11433 * syssignal.h (croak): Put it here, so the API can be checked when
11434 'croak' is called from dissociate_if_controlling_tty.
11435
1717ede2
PE
11436 * minibuf.c: Make symbols static if they're not exported.
11437 (minibuf_save_list, choose_minibuf_frame): Now static.
11438 * lisp.h (choose_minibuf_frame): Remove decl.
11439
fa5fb2bc
PE
11440 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11441
1e3890d1
PE
11442 * lread.c: Make symbols static if they're not exported.
11443 (read_objects, initial_obarray, oblookup_last_bucket_number):
11444 Now static.
11445 (make_symbol): Remove; unused.
11446 * lisp.h (initial_obarray, make_symbol): Remove decls.
11447
8a1414fa
PE
11448 * keyboard.c: Make symbols static if they're not exported.
11449 (single_kboard, recent_keys_index, total_keys, recent_keys):
11450 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11451 (this_single_command_key_start, echoing, last_auto_save):
11452 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11453 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11454 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11455 (Vlispy_mouse_stem, double_click_count):
11456 Now static.
11457 (force_auto_save_soon): Define only if SIGDANGER.
11458 (ignore_mouse_drag_p): Now static if
11459 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11460 (print_help): Remove; unused.
11461 (stop_character, last_timer_event): Mark as externally visible.
11462 * keyboard.h (ignore_mouse_drag_p): Declare only if
11463 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11464 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11465 * lisp.h (echoing): Remove decl.
11466 (force_auto_save_soon): Declare only if SIGDANGER.
11467 * xdisp.c (redisplay_window): Simplify code, to make it more
11468 obvious that ignore_mouse_drag_p is not accessed if !defined
11469 USE_GTK && !defined HAVE_NS.
11470
93ea6e8f
PE
11471 * intervals.c: Make symbols static if they're not exported.
11472 (merge_properties_sticky, merge_interval_right, delete_interval):
11473 Now static.
11474 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11475
77382fcc
PE
11476 * insdel.c: Make symbols static if they're not exported.
11477 However, leave prepare_to_modify_buffer alone. It's never
11478 called from outside this function, but that appears to be a bug.
11479 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11480 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11481 (adjust_after_replace_noundo): Remove; unused.
11482 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11483 (signal_before_change): Remove decls.
77382fcc 11484
9306c32e
PE
11485 * indent.c (val_compute_motion, val_vmotion): Now static.
11486
cd44d2eb
PE
11487 * image.c: Make symbols static if they're not exported.
11488 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11489 if USE_GTK.
11490 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11491 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11492
ad9a7a06
PE
11493 * fringe.c (standard_bitmaps): Now static.
11494 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11495
81626931
PE
11496 * frame.c: Make symbols static if they're not exported.
11497 (x_report_frame_params, make_terminal_frame): Now static.
11498 (get_frame_param): Now static, unless HAVE_NS.
11499 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11500 (x_get_resource_string): Remove; not used.
11501 * frame.h (make_terminal_frame, x_report_frame_params):
11502 (x_get_resource_string); Remove decls.
11503 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11504 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11505
239f9db9
PE
11506 * font.c, fontset.c: Make symbols static if they're not exported.
11507 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11508 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11509 * font.c (font_close_object): Now static.
11510 * font.h (font_close_object): Remove.
11511 * fontset.c (FONTSET_OBJLIST): Remove.
11512 (free_realized_fontset) #if-0 the body, which does nothing.
11513 (face_suitable_for_char_p): #if-0, as it's never called.
11514 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11515 * xfaces.c (face_at_string_position):
11516 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11517 since 0 is always ASCII.
11518
dfcf3579
PE
11519 * fns.c (weak_hash_tables): Now static.
11520
5045092b
PE
11521 * fileio.c: Make symbols static if they're not exported.
11522 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11523 (Vwrite_region_annotation_buffers): Now static.
11524
57a96f5c
PE
11525 * eval.c: Make symbols static if they're not exported.
11526 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11527 * lisp.h (backtrace_list): Remove decl.
11528
35f08c38
PE
11529 * emacs.c: Make symbols static if they're not exported.
11530 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11531 (fatal_error_code, fatal_error_signal_hook, standard_args):
11532 Now static.
11533 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11534 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11535 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11536 * lisp.h (fatal_error_signal_hook): Remove decl.
11537 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11538
f44bd759
PE
11539 * editfns.c: Move a (normally-unused) function to its only use.
11540 * editfns.c, lisp.h (get_operating_system_release): Remove.
11541 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11542 worth the hassle of breaking this out.
11543
b532497d
PE
11544 * xterm.c: Make symbols static if they're not exported.
11545 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11546 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11547 (x_destroy_window, x_delete_display):
11548 Now static.
11549 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11550 (x_mouse_leave): Remove; unused.
11551 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11552 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11553 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11554 Remove decls.
11555 (x_mouse_leave): Declare only if WINDOWSNT.
11556 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11557 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11558 USE_X_TOOLKIT.
11559
1675728f
PE
11560 * ftxfont.c: Make symbols static if they're not exported.
11561 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11562 HAVE_FREETYPE.
11563 * font.h (ftxfont_driver): Likewise.
11564
e4cebfca
PE
11565 * xfns.c: Make symbols static if they're not exported.
11566 (x_last_font_name, x_display_info_for_name):
11567 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11568 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11569 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11570 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11571 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11572 (last_show_tip_args): Now static.
11573 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11574 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11575 (x_screen_planes): Remove; unused.
11576 * dispextern.h (x_screen_planes): Remove decl.
11577
5bf46f05
PE
11578 * dispnew.c: Make symbols static if they're not exported.
11579 * dispextern.h (redraw_garbaged_frames, scrolling):
11580 (increment_row_positions): Remove.
11581 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11582 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11583 Now static.
11584 (redraw_garbaged_frames): Remove; unused.
11585
435f4c28
PE
11586 * xfaces.c: Make symbols static if they're not exported.
11587 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11588 Remove decls.
11589 * xterm.h (defined_color): Remove decls.
11590 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11591 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11592 (menu_face_changed_default, defined_color, free_realized_face):
11593 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11594 (ascii_face_of_lisp_face): Remove; unused.
11595
8524aef3
PE
11596 * xdisp.c: Make symbols static if they're not exported.
11597 * dispextern.h (scratch_glyph_row, window_box_edges):
11598 (glyph_to_pixel_coords, set_cursor_from_row):
11599 (get_next_display_element, set_iterator_to_next):
11600 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11601 (show_mouse_face): Remove decls
11602 * frame.h (message_buf_print): Likewise.
11603 * lisp.h (pop_message, set_message, check_point_in_composition):
11604 Likewise.
11605 * xterm.h (set_vertical_scroll_bar): Likewise.
11606 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11607 (message_buf_print, scratch_glyph_row, displayed_buffer):
11608 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11609 (get_next_display_element, show_mouse_face, window_box_edges):
11610 (frame_to_window_pixel_xy, check_point_in_composition):
11611 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11612 (glyph_to_pixel_coords): Remove; unused.
11613
16390cd2
PE
11614 * dired.c (file_name_completion): Now static.
11615
11616 * dbusbind.c (xd_in_read_queued_messages): Now static.
11617
a25f4dfa
PE
11618 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11619 * data.c (circular_list_error): Remove.
11620
14a9c8df
PE
11621 * commands.h (last_point_position, last_point_position_buffer):
11622 (last_point_position_window): Remove decls.
11623 * keyboard.c: Make these variables static.
11624
04f2d78b
CB
11625 * coding.h (coding, code_convert_region, encode_coding_gap):
11626 Remove decls.
74ab6df5
PE
11627 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11628 (iso_code_class, detect_coding, code_convert_region): Now static.
11629 (encode_coding_gap): Remove; unused.
11630
38dfbee1
PE
11631 * chartab.c (chartab_chars, chartab_bits): Now static.
11632
a2cb4e63
PE
11633 * charset.h (charset_iso_8859_1): Remove decl.
11634 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11635 Now static.
11636
127198fd
PE
11637 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11638 * ccl.c (Vccl_program_table): Now static.
11639 (check_ccl_update): Remove; unused.
11640
d85b608f
PE
11641 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11642 * category.h: ... from here.
11643 * category.c (check_category_table, set_category_set): Now static.
11644
31cd66f3
PE
11645 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11646 * lisp.h: Remove these decls.
11647
c358e587
PE
11648 * buffer.c (buffer_count): Remove unused var.
11649
e78aecca
PE
11650 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11651 so that it's not optimized away.
11652 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11653 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11654 exported only to the debugger.
11655
e192d7d3 11656 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11657 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11658
92470028
PE
11659 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11660 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11661 was inaccessible from Lisp.
11662 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11663 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11664
244ed907
PE
11665 alloc.c: Import and export fewer symbols, and remove unused items.
11666 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11667 is defined.
11668 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11669 it's not optimized away by whole-program optimization.
11670 (message_enable_multibyte, free_misc): Remove.
11671 (catchlist, handlerlist, mark_backtrace):
11672 Declare only if BYTE_MARK_STACK.
11673 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11674 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11675 (message_enable_multibyte): Remove decl.
11676 (free_misc, interval_free_list, float_block, float_block_index):
11677 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11678 (cons_free_list, last_marked_index):
11679 Now static.
11680 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11681 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11682 (mark_backtrace): Define only if BYTE_MARK_STACK.
11683 * xdisp.c (message_enable_multibyte): Now static.
11684
61c2b50e 11685 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11686 This makes it easier for human readers (and static analyzers)
11687 to see whether these variables are used from other modules.
11688 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11689 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11690 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11691 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11692 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11693 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11694 * xmenu.c, xselect.c:
11695 Declare Q* vars static if they are not used in other modules.
11696 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11697 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11698 Remove decls of unexported vars.
11699 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11700
95c82688
PE
11701 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11702
16a97296
PE
11703 Make Emacs functions such as Fatom 'static' by default.
11704 This makes it easier for human readers (and static analyzers)
11705 to see whether these functions can be called from other modules.
11706 DEFUN now defines a static function. To make the function external
11707 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11708 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11709 (Finit_image_library):
16a97296
PE
11710 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11711 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11712 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11713 Remove decls, since these functions are now static.
11714 (Funintern, Fget_internal_run_time): New decls, since these functions
11715 were already external.
95c82688 11716
16a97296
PE
11717 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11718 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11719 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11720 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11721 * keyboard.c, keymap.c, lread.c:
11722 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11723 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11724 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11725 Mark functions with DEFUE instead of DEFUN,
11726 if they are used in other modules.
11727 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11728 decls for now-static functions.
11729 * buffer.h (Fdelete_overlay): Remove decl.
11730 * callproc.c (Fgetenv_internal): Mark as internal.
11731 * composite.c (Fremove_list_of_text_properties): Remove decl.
11732 (Fcomposition_get_gstring): New forward static decl.
11733 * composite.h (Fcomposite_get_gstring): Remove decl.
11734 * dired.c (Ffile_attributes): New forward static decl.
11735 * doc.c (Fdocumntation_property): New forward static decl.
11736 * eval.c (Ffetch_bytecode): New forward static decl.
11737 (Funintern): Remove extern decl; now in .h file where it belongs.
11738 * fileio.c (Fmake_symbolic_link): New forward static decl.
11739 * image.c (Finit_image_library): New forward static decl.
11740 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11741 * intervals.h (Fprevious_property_change):
11742 (Fremove_list_of_text_properties): Remove decls.
11743 * keyboard.c (Fthis_command_keys): Remove decl.
11744 (Fcommand_execute): New forward static decl.
11745 * keymap.c (Flookup_key): New forward static decl.
11746 (Fcopy_keymap): Now static.
11747 * keymap.h (Flookup_key): Remove decl.
11748 * process.c (Fget_process): New forward static decl.
11749 (Fprocess_datagram_address): Mark as internal.
11750 * syntax.c (Fsyntax_table_p): New forward static decl.
11751 (skip_chars): Remove duplicate decl.
11752 * textprop.c (Fprevious_property_change): New forward static decl.
11753 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11754 Now internal.
11755 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11756 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11757
785bbd42
PE
11758 * editfns.c (Fformat): Remove unreachable code.
11759
8b913b57
AS
117602011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11761
11762 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11763 change. (Bug#8496)
11764
a6744a35
EZ
117652011-04-13 Eli Zaretskii <eliz@gnu.org>
11766
11767 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11768 when at ZV. (Bug#8487)
11769
e7974947
AS
117702011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11771
baad03f0
AS
11772 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11773 (Bug#8437)
11774 * keyboard.c (parse_tool_bar_item): Likewise.
11775 * sound.c (sound_cleanup, alsa_close): Likewise.
11776 * termcap.c (tgetent): Likewise.
11777 * xfns.c (x_default_font_parameter): Likewise.
11778 * xsettings.c (read_and_apply_settings): Likewise.
11779
e7974947
AS
11780 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11781 (overrun_check_free): Protoize.
11782
28272684
PE
117832011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11784
11785 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11786 since callers should never pass a negative size.
11787 Change the signature to match that of plain 'read' and 'write'; see
11788 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11789 * lisp.h: Update prototypes of emacs_write and emacs_read.
11790
11997c76
EZ
117912011-04-11 Eli Zaretskii <eliz@gnu.org>
11792
11793 * xdisp.c (redisplay_window): Don't try to determine the character
11794 position of the scroll margin if the window start point w->startp
e896f03c 11795 is outside the buffer's accessible region. (Bug#8468)
11997c76 11796
8a2cbd72
EZ
117972011-04-10 Eli Zaretskii <eliz@gnu.org>
11798
11799 Fix write-region and its subroutines for buffers > 2GB.
11800 * fileio.c (a_write, e_write): Modify declaration of arguments and
11801 local variables to support buffers larger than 2GB.
11802 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11803
11804 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11805 argument, local variables, and return value.
11806
11807 * lisp.h: Update prototypes of emacs_write and emacs_read.
11808
11809 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11810
4073e537 118112011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11812
1ebfdcb6
PE
11813 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11814
b2ded58d
PE
11815 Fix more problems found by GCC 4.6.0's static checks.
11816
7d66342c
PE
11817 * xdisp.c (vmessage): Use a better test for character truncation.
11818
bbf47d44
PE
11819 * charset.c (load_charset_map): <, not <=, for optimization,
11820 and to avoid potential problems with integer overflow.
9248994d 11821 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11822 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11823 * editfns.c (Fformat): Likewise.
1e69125e 11824 * syntax.c (skip_chars): Likewise.
3befa583 11825
e3019616
PE
11826 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11827 This also lets GCC 4.6.0 generate slightly better loop code.
11828
becfa255
PE
11829 * callint.c (Fcall_interactively): <, not <=, for optimization.
11830 (Fcall_interactively): Count the number of arguments produced,
11831 not the number of arguments given. This is simpler and lets GCC
11832 4.6.0 generate slightly better code.
11833
dae0cd48
PE
11834 * ftfont.c: Distingish more carefully between FcChar8 and char.
11835 The previous code passed unsigned char * to a functions like
11836 strlen and xstrcasecmp that expect char *, which does not
11837 conform to the C standard.
11838 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11839 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11840 char * when the C standard requires it.
11841
76032d70
PE
11842 * keyboard.c (read_char): Remove unused var.
11843
eb3f1cc8
PE
11844 * eval.c: Port to Windows vsnprintf (Bug#8435).
11845 Include <limits.h>.
11846 (SIZE_MAX): Define if the headers do not.
11847 (verror): Do not give up if vsnprintf returns a negative count.
11848 Instead, grow the buffer. This ports to Windows vsnprintf, which
11849 does not conform to C99. Problem reported by Eli Zaretskii.
11850 Also, simplify the allocation scheme, by avoiding the need for
11851 calling realloc, and removing the ALLOCATED variable.
11852
70476b54
PE
11853 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11854
12020a9e
PE
11855 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11856 But keep the doprint source code for now, as we might revamp it
11857 and use it again (Bug#8435).
ea6c7ae6
PE
11858 * lisp.h (doprnt): Remove.
11859 * Makefile.in (base_obj): Remove doprnt.o.
11860 * deps.mk (doprnt.o): Remove.
11861
5fdb398c
PE
11862 error: Print 32- and 64-bit integers portably (Bug#8435).
11863 Without this change, on typical 64-bit hosts error ("...%d...", N)
11864 was used to print both 32- and 64-bit integers N, which relied on
11865 undefined behavior.
61bdb816 11866 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11867 * lisp.h (error, verror): Mark as printf-like functions.
11868 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11869 Report overflow in size calculations when allocating printf buffer.
11870 Do not truncate output string at its first null byte.
11871 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11872 Truncate the output at a character boundary, since vsnprintf does not
11873 do that.
11874 * charset.c (check_iso_charset_parameter): Convert internal
11875 character to string before calling 'error', since %c now has the
11876 printf meaning.
11877 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11878 overflow when computing char to be passed to 'error'. Do not
11879 pass Lisp_Object to 'error'; pass the integer instead.
11880 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11881 formatted with plain %d.
11882
b189fa66
PE
11883 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11884
bff87ef0
PE
11885 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11886
7e2cac20
PE
11887 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11888
ce4d90b5
PE
11889 * xterm.c (x_catch_errors): Remove duplicate declaration.
11890
266c9547
PE
11891 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11892
79c49ad2
PE
11893 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11894
368f4090
JM
118952011-04-10 Jim Meyering <meyering@redhat.com>
11896
11897 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11898 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11899 return ssize_t not "int", and use size_t as the buffer length.
11900 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11901 * gnutls.h: Update declarations.
11902 * process.c (read_process_output): Use ssize_t, to match.
11903 (send_process): Likewise.
11904
a32d4040
CY
119052011-04-09 Chong Yidong <cyd@stupidchicken.com>
11906
11907 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11908
8546720e 119092011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11910
04f2d78b
CB
11911 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11912 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11913
8546720e
GM
11914 * xterm.c (handle_one_xevent):
11915 * xmenu.c (create_and_show_popup_menu):
11916 * xselect.c (x_decline_selection_request)
11917 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11918
0a2f5c1a 119192011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11920
11921 Fix some uses of `int' instead of EMACS_INT.
11922 * search.c (string_match_1, fast_string_match)
11923 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11924 (scan_buffer, find_next_newline_no_quit)
11925 (find_before_next_newline, search_command, Freplace_match)
11926 (Fmatch_data): Make some `int' variables be EMACS_INT.
11927
11928 * xdisp.c (display_count_lines): 3rd argument and return value now
11929 EMACS_INT. All callers changed.
11930 (pint2hrstr): Last argument is now EMACS_INT.
11931
11932 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11933 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11934 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11935 (decode_coding_utf_16, decode_coding_emacs_mule)
11936 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11937 (decode_coding_ccl, decode_coding_charset)
11938 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11939 (decode_coding_iso_2022, decode_coding_emacs_mule)
11940 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11941 <char_offset, last_offset>: Declare EMACS_INT.
11942 (encode_coding_utf_8, encode_coding_utf_16)
11943 (encode_coding_emacs_mule, encode_invocation_designation)
11944 (encode_designation_at_bol, encode_coding_iso_2022)
11945 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11946 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11947 Declare EMACS_INT.
11948 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11949 (encode_invocation_designation): Last argument P_NCHARS is now
11950 EMACS_INT.
11951 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11952 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11953
11954 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11955 All users changed.
11956
11957 * ccl.c (Fccl_execute_on_string): Declare some variables
11958 EMACS_INT.
11959
8546720e 119602011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11961
11962 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11963
4e19a977
CS
119642011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11965
11966 * process.c (Fformat_network_address): Doc fix.
11967
87302331
R
119682011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11969
ee7683eb 11970 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11971
cbb59342
CY
119722011-04-08 Chong Yidong <cyd@stupidchicken.com>
11973
11974 * keyboard.c (read_char): Call Lisp function help-form-show,
11975 instead of using internal_with_output_to_temp_buffer.
11976 (Qhelp_form_show): New var.
e0d38eeb 11977 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11978
11979 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11980
11981 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11982
e67a13ab
CY
119832011-04-06 Chong Yidong <cyd@stupidchicken.com>
11984
04f2d78b
CB
11985 * process.c (Flist_processes): Remove to Lisp.
11986 (list_processes_1): Delete.
e67a13ab 11987
973f782d
EZ
119882011-04-06 Eli Zaretskii <eliz@gnu.org>
11989
7c106b1e
EZ
11990 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11991
973f782d
EZ
11992 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11993
41cf7d1a 119942011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11995
ca23cc88
PE
11996 Fix more problems found by GCC 4.6.0's static checks.
11997
f390e2d5
PE
11998 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11999
42eea0d0
PE
12000 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12001
b69769da 12002 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12003
f9541e84
PE
12004 * xdisp.c (vmessage): Mark as a printf-like function.
12005
13841b55
PE
12006 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12007
c136c10f
PE
12008 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12009
5e2d4a30
PE
12010 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12011 printf-like functions.
12012 (tiff_load): Add casts to remove these marks before passing them
12013 to system-supplied API.
12014
583f48b9
PE
12015 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12016
b25d760e
PE
12017 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12018 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12019 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12020 directly, rather than having caller test rule sign. This avoids
12021 some unnecessary tests.
12022 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12023 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12024 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12025
bc7b6697 12026 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12027 (xfont_open): Avoid unnecessary tests.
bc7b6697 12028
27ccc379
PE
12029 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12030
dcd5c89a
PE
12031 * composite.h, composite.c (composition_gstring_put_cache):
12032 Use EMACS_INT, not int, for length.
12033
b13a45c6
PE
12034 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12035 breaking out part of COMPOSITION_DECODE_RULE.
12036 (COMPOSITION_DECODE_RULE): Use it.
12037 * composite.c (get_composition_id): Remove unused local vars,
12038 by using the new macro.
12039
1e792e4d
PE
12040 * textprop.c (set_text_properties_1): Change while to do-while,
12041 since the condition is always true at first.
12042
dc6c6455 12043 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12044 (interval_deletion_adjustment): Return unsigned value.
12045 All uses changed.
dc6c6455 12046
aba7731a
PE
12047 * process.c (list_processes_1, create_pty, read_process_output):
12048 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12049 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12050 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12051 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12052 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12053
fdfc4bf3
PE
12054 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12055
fca8fe46 12056 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12057 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12058
06a0259a 12059 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12060 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12061 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12062
e7b9e80f
PE
12063 * print.c (print_error_message): Avoid int overflow.
12064
56201685
PE
12065 * font.c (font_list_entities): Redo for clarity,
12066 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12067
78834453 12068 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12069 (font_score): Avoid potential overflow in diff calculation.
78834453 12070
0bc0b309 12071 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12072 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12073
e610eaca
PE
12074 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12075
b895abce
PE
12076 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12077 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12078 can always succeed if overflow has undefined behavior.
12079
1f1d9321 12080 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12081 (wordify): Omit three unnecessary tests.
1f1d9321 12082
c59478bc
PE
12083 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12084 All callers changed. This avoids the need for an unused var.
12085
79b73827
PE
12086 * casefiddle.c (casify_region): Remove var that is set but not used.
12087
a4db5dfe
PE
12088 * dired.c (file_name_completion): Remove var that is set but not used.
12089
43aae36e
PE
12090 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12091
2a47c44d 12092 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12093 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12094
a37c69bf
PE
12095 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12096 Check for integer overflow on size calculations.
12097
328ab8e7
PE
12098 * buffer.c (Fprevious_overlay_change): Remove var that is set
12099 but not used.
12100
e5a2a5cb
PE
12101 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12102 Remove vars that are set but not used.
8d84a6eb 12103 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12104 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12105
a60e5f68
PE
12106 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12107
f661cb61 12108 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12109 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12110
f0397f5a
PE
12111 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12112 that are set but not used.
12113
8664db06 12114 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12115 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12116
6abdaa4a
PE
12117 * xselect.c (x_get_local_selection, x_handle_property_notify):
12118 Remove vars that are set but not used.
12119
0ce7538d 12120 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12121 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12122
9ae848fc
PE
12123 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12124 Remove var that is set but not used.
0b918413
PE
12125 (scroll_bar_windows_size): Now size_t, not int.
12126 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12127 Check for overflow.
9ae848fc 12128
a5a62657
PE
12129 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12130 (map_tty_color) [!defined MSDOS]: Likewise.
12131
5c5cdd39
PE
12132 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12133
66ebf983
PE
12134 * coding.c: Remove vars that are set but not used.
12135 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12136 All callers changed.
12137 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12138 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12139 (decode_coding_charset): Remove vars that are set but not used.
12140
1be4d761
PE
12141 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12142 that is set but not used.
12143
47553fa8
PE
12144 * print.c (print_object): Remove var that is set but not used.
12145
1f7196bf 12146 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12147 The gnulib version avoids calling malloc in the usual case,
12148 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12149 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12150 * filelock.c (current_lock_owner): Likewise.
12151 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12152 * sysdep.c: Include allocator.h, careadlinkat.h.
12153 (emacs_no_realloc_allocator): New static constant.
12154 (emacs_readlink): New function.
fdb61804
PE
12155 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12156 ../lib/careadlinkat.h.
d1fdcab7 12157
f84c17c7
SM
121582011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12159
12160 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12161 first non-nil return value).
12162
ef3862ad
JD
121632011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12164
12165 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12166 if not defined (Bug#8403).
12167
376a7006
JB
121682011-04-02 Juanma Barranquero <lekktu@gmail.com>
12169
12170 * xdisp.c (display_count_lines): Remove parameter `start',
12171 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12172 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12173 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12174 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12175 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12176 and thereabouts. All callers changed.
12177 (get_per_char_metric): Remove parameter `f', unused since
12178 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12179
6ca3801d
JM
121802011-04-02 Jim Meyering <meyering@redhat.com>
12181
12182 do not dereference NULL upon failed strdup
12183 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12184 (ns_get_family): Likewise.
12185
d8e2b5ba
JB
121862011-04-02 Juanma Barranquero <lekktu@gmail.com>
12187
12188 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12189
8c74fcbd
JD
121902011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12191
12192 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12193 later (Bug#8403).
12194
7200d79c
SM
121952011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12196
03408648 12197 Add lexical binding.
7200d79c 12198
03408648
SM
12199 * window.c (Ftemp_output_buffer_show): New fun.
12200 (Fsave_window_excursion):
12201 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12202
12203 * lread.c (lisp_file_lexically_bound_p): New function.
12204 (Fload): Bind Qlexical_binding.
12205 (readevalloop): Remove `evalfun' arg.
12206 Bind Qinternal_interpreter_environment.
12207 (Feval_buffer): Bind Qlexical_binding.
12208 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12209 Mark as dynamic.
12210 (syms_of_lread): Declare `lexical-binding'.
12211
12212 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12213
12214 * keyboard.c (eval_dyn): New fun.
12215 (menu_item_eval_property): Use it.
ca105506
SM
12216
12217 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12218
03408648
SM
12219 * fns.c (concat, mapcar1): Accept byte-code-functions.
12220
12221 * eval.c (Fsetq): Handle lexical vars.
12222 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12223 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12224 (FletX, Flet): Obey lexical binding.
12225 (Fcommandp): Handle closures.
12226 (Feval): New `lexical' arg.
12227 (eval_sub): New function extracted from Feval. Use it almost
12228 everywhere where Feval was used. Look up vars in lexical env.
12229 Handle closures.
12230 (Ffunctionp): Move from subr.el.
12231 (Ffuncall): Handle closures.
12232 (apply_lambda): Remove `eval_flags'.
12233 (funcall_lambda): Handle closures and new byte-code-functions.
12234 (Fspecial_variable_p): New function.
12235 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12236 but without exporting it to Lisp.
23aba0ea 12237
23aba0ea 12238 * doc.c (Fdocumentation, store_function_docstring):
03408648 12239 * data.c (Finteractive_form): Handle closures.
23aba0ea 12240
03408648
SM
12241 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12242 interactive spec.
ba83908c 12243
04f2d78b
CB
12244 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12245 New byte-codes.
03408648
SM
12246 (exec_byte_code): New function extracted from Fbyte_code to handle new
12247 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12248
03408648 12249 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12250
03408648 12251 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12252
e2abce01
JB
122532011-03-31 Juanma Barranquero <lekktu@gmail.com>
12254
12255 * xdisp.c (redisplay_internal): Fix prototype.
12256
63696a73 122572011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12258
63696a73 12259 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12260 (try_scrolling): Use it when setting scroll_limit.
12261 Limit scrolling to 100 screen lines.
63696a73
EZ
12262 (redisplay_window): Even when falling back on "recentering",
12263 position point in the window according to scroll-conservatively,
12264 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12265
12266 (try_scrolling): When point is above the window, allow searching
12267 as far as scroll_max, or one screenful, to compute vertical
12268 distance from PT to the scroll margin position. This prevents
12269 try_scrolling from unnecessarily failing when
12270 scroll-conservatively is set to a value slightly larger than the
12271 window height. Clean up the case of PT below the margin at bottom
12272 of window: scroll_max can no longer be INT_MAX. When aggressive
12273 scrolling is in use, don't let point enter the opposite scroll
12274 margin as result of the scroll.
12275 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12276 threshold of 100 lines for never-recentering scrolling.
12277
e4cc2dfc
JB
122782011-03-31 Juanma Barranquero <lekktu@gmail.com>
12279
12280 * dispextern.h (move_it_by_lines):
12281 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12282 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12283 (message_log_check_duplicate): Remove parameters `prev_bol' and
12284 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12285 (redisplay_internal): Remove parameter `preserve_echo_area',
12286 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12287
12288 * indent.c (Fvertical_motion):
12289 * window.c (window_scroll_pixel_based, Frecenter):
12290 Don't pass `need_y_p' to `move_it_by_lines'.
12291
1c470562
SM
122922011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12293
44f230aa
SM
12294 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12295 steal a few bits to be more compact.
12296 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12297 Remove unneeded casts.
12298
1c470562
SM
12299 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12300
888adce9
ZK
123012011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12302
12303 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12304 binding" message (bug#7967).
12305
f838ed7b
PE
123062011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12307
77861b95
PE
12308 Fix more problems found by GCC 4.6.0's static checks.
12309
de6dbc14
PE
12310 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12311 Remove unused local var.
12312
f838ed7b
PE
12313 * editfns.c (Fmessage_box): Remove unused local var.
12314
792c7b2b
PE
12315 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12316 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12317 Omit unused local vars.
c499e557 12318 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12319 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12320 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12321 Omit unused local var.
12322
ba0165e1
PE
12323 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12324 Don't assume string length fits in int.
32ad8845 12325 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12326 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12327
3c59b4c9
PE
12328 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12329 instead of alloca (Bug#8344).
12330
a3eed478 12331 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12332 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12333
eb4d412d
PE
12334 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12335
1658b401
PE
12336 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12337 concerns.
12338
12339 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12340
12341 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12342
9a2c6e05
PE
12343 * keyboard.c (syms_of_keyboard): Use the same style as later
12344 in this function when indexing through an array. This also
12345 works around GCC bug 48267.
12346
03d0a109
PE
12347 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12348
44f730c8
PE
12349 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12350
fe75f926
PE
12351 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12352 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12353
ffa8c828
PE
12354 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12355 This avoids undefined behavior on integer overflow, and is a bit
12356 more convenient anyway since it is compared to a size_t variable.
12357
c5101a77
PE
12358 Variadic C functions now count arguments with size_t, not int.
12359 This avoids an unnecessary limitation on 64-bit machines, which
12360 caused (substring ...) to crash on large vectors (Bug#8344).
12361 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12362 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12363 All variadic functions and their callers changed accordingly.
c5101a77
PE
12364 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12365 * data.c (arith_driver, float_arith_driver): Likewise.
12366 * editfns.c (general_insert_function): Likewise.
12367 * eval.c (struct backtrace.nargs, interactive_p)
12368 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12369 (funcall_lambda, mark_backtrace): Likewise.
12370 * fns.c (concat): Likewise.
12371 * frame.c (x_set_frame_parameters): Likewise.
12372 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12373 0 if not found, not -1. All callers changed.
12374
dd3f25f7
PE
12375 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12376 (stack_copy_size): Now size_t, not int.
12377 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12378
461c2ab9
JB
123792011-03-28 Juanma Barranquero <lekktu@gmail.com>
12380
12381 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12382 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12383 All callers changed.
12384
12385 * lisp.h (multibyte_char_to_unibyte):
12386 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12387 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12388 * character.h (CHAR_TO_BYTE8):
12389 * cmds.c (internal_self_insert):
12390 * editfns.c (general_insert_function):
12391 * keymap.c (push_key_description):
12392 * search.c (Freplace_match):
12393 * xdisp.c (message_dolog, set_message_1): All callers changed.
12394
f6d62986
SM
123952011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12396
12397 * keyboard.c (safe_run_hook_funcall): New function.
12398 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12399 don't set the hook to nil, but remove the offending function instead.
12400 (Qcommand_hook_internal): Remove, unused.
12401 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12402 Vcommand_hook_internal.
12403
12404 * eval.c (enum run_hooks_condition): Remove.
12405 (funcall_nil, funcall_not): New functions.
12406 (run_hook_with_args): Call each function through a `funcall' argument.
12407 Remove `cond' argument, now redundant.
12408 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12409 (Frun_hook_with_args_until_failure): Adjust accordingly.
12410 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12411
1db5b1ad
JB
124122011-03-28 Juanma Barranquero <lekktu@gmail.com>
12413
12414 * dispextern.h (string_buffer_position): Remove declaration.
12415
12416 * print.c (strout): Remove parameter `multibyte', unused since
12417 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12418
12419 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12420 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12421 All callers changed.
12422
12423 * w32.c (_wsa_errlist): Use braces for struct initializers.
12424
12425 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12426 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12427 All callers changed.
12428 (string_buffer_position): Likewise. Also, make static (it's never
12429 used outside xdisp.c).
12430 (cursor_row_p): Remove parameter `w', unused since
12431 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12432 (decode_mode_spec): Remove parameter `precision', introduced during
12433 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12434 All callers changed.
12435
5ffb62aa
JD
124362011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12437
12438 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12439
461c2ab9 124402011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12441
12442 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12443 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12444 (ns_update_auto_hide_menu_bar): New functions.
12445 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12446 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12447 ns_constrain_all_frames.
12448 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12449 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12450
5c380ffb
JD
124512011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12452
12453 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12454
9af30bdf
GM
124552011-03-27 Glenn Morris <rgm@gnu.org>
12456
12457 * syssignal.h: Replace RETSIGTYPE with void.
12458 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12459 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12460 Replace SIGTYPE with void everywhere.
12461 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12462 * s/template.h (SIGTYPE): Remove commented out definition.
12463
e2abce01
JB
124642011-03-26 Eli Zaretskii <eliz@gnu.org>
12465
12466 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12467 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12468
f868cd8a
JB
124692011-03-26 Juanma Barranquero <lekktu@gmail.com>
12470
59eb0929
JB
12471 * w32.c (read_unc_volume): Use parameter `henum', instead of
12472 global variable `wget_enum_handle'.
12473
12474 * keymap.c (describe_vector): Remove parameters `indices' and
12475 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12476 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12477
f868cd8a
JB
12478 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12479
12480 * keyboard.c (timer_check): Remove parameter `do_it_now',
12481 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12482 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12483 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12484
12485 * keyboard.c (read_char):
12486 * w32menu.c (w32_menu_display_help):
12487 * xmenu.c (show_help_event, menu_help_callback):
12488 Adjust calls to `show_help_echo'.
12489
12490 * gtkutil.c (xg_maybe_add_timer):
12491 * keyboard.c (readable_events):
12492 * process.c (wait_reading_process_output):
12493 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12494
12495 * insdel.c (adjust_markers_gap_motion):
12496 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12497 (gap_left, gap_right): Don't call it.
12498
2ecf6fdb
CY
124992011-03-25 Chong Yidong <cyd@stupidchicken.com>
12500
12501 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12502 incurred during fontification.
12503
6b1f9ba4
JB
125042011-03-25 Juanma Barranquero <lekktu@gmail.com>
12505
12506 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12507 (DEFVAR_PER_BUFFER): Don't pass it.
12508
12509 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12510 (scrolling_window): Don't pass it.
12511
0f4a96b5
JB
125122011-03-25 Juanma Barranquero <lekktu@gmail.com>
12513
12514 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12515
12516 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12517 and `suffix'.
12518 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12519 of variables specific to SELinux and computation of `encoded_absname'.
12520
12521 * image.c (XPutPixel): Remove unused variable `height'.
12522
12523 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12524
12525 * unexw32.c (get_section_info): Remove unused variable `section'.
12526
12527 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12528 (system_process_attributes): Remove unused variable `sess'.
12529 (sys_read): Remove unused variable `err'.
12530
12531 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12532 (w32_wnd_proc): Remove unused variable `isdead'.
12533 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12534 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12535 (x_create_tip_frame): Remove unused variable `tem'.
12536
12537 * w32inevt.c (w32_console_read_socket):
12538 Remove unused variable `no_events'.
12539
12540 * w32term.c (x_draw_composite_glyph_string_foreground):
12541 Remove unused variable `width'.
12542
1149507c
JB
125432011-03-24 Juanma Barranquero <lekktu@gmail.com>
12544
12545 * w32term.c (x_set_glyph_string_clipping):
12546 Don't pass uninitialized region to CombineRgn.
12547
9c88f339
JB
125482011-03-23 Juanma Barranquero <lekktu@gmail.com>
12549
12550 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12551 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12552 (Fx_close_connection): Remove unused variable `i'.
12553
12554 * w32font.c (w32font_draw): Return number of glyphs.
12555 (w32font_open_internal): Remove unused variable `i'.
12556 (w32font_driver): Add missing initializer.
12557
12558 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12559 (fill_in_menu): Remove unused variable `items_added'.
12560
12561 * w32term.c (last_mouse_press_frame): Remove static global variable.
12562 (w32_clip_to_row): Remove unused variable `f'.
12563 (x_delete_terminal): Remove unused variable `i'.
12564
12565 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12566 (NOTHING): Remove unused static global variable.
12567 (uniscribe_check_otf): Remove unused variable `table'.
12568 (uniscribe_font_driver): Add missing initializers.
12569
dee091a3
JD
125702011-03-23 Julien Danjou <julien@danjou.info>
12571
12572 * term.c (Fsuspend_tty, Fresume_tty):
12573 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12574 * window.c (temp_output_buffer_show):
12575 * insdel.c (signal_before_change):
12576 * frame.c (Fhandle_switch_frame):
12577 * fileio.c (Fdo_auto_save):
12578 * emacs.c (Fkill_emacs):
12579 * editfns.c (save_excursion_restore):
12580 * cmds.c (internal_self_insert):
12581 * callint.c (Fcall_interactively):
12582 * buffer.c (Fkill_all_local_variables):
12583 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12584 Use Frun_hooks.
0f4a96b5 12585 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12586 unconditionally since it does the check itself.
dee091a3 12587
2c520ab5 125882011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12589
c9c49752
PE
12590 Fix more problems found by GCC 4.5.2's static checks.
12591
8abc3f12
PE
12592 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12593 the first time through the loop, since we know p0 < p1 then.
12594 This also avoids a gcc -Wstrict-overflow warning.
12595
a2d26660
PE
12596 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12597 leading to a memory leak, possible in functions like
12598 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12599 of objects (Bug#8318).
a2d26660 12600
916c72e9
PE
12601 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12602 that could (at least in theory) be that large.
12603
19ab8a18
PE
12604 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12605 This is less likely to overflow, and avoids undefined behavior if
12606 overflow does occur. All callers changed. Use strtoul to scan
12607 for the unsigned long integer.
b7cbbd6f
PE
12608 (pint2hrstr): Simplify and tune code slightly.
12609 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12610
f0641eff
PE
12611 * scroll.c (do_scrolling): Work around GCC bug 48228.
12612 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12613
7f650bb9
PE
12614 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12615 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12616 (validate_x_resource_name): Simplify count usage.
12617 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12618
37dd57d1
PE
12619 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12620 fail (Bug#8306).
81e56e61 12621
699979fc 12622 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12623
401bf9b4
PE
12624 * process.c (Fmake_network_process): Use socklen_t, not int,
12625 where POSIX says socklen_t is required in portable programs.
12626 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12627 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12628 (Fmake_network_process, server_accept_connection):
12629 (wait_reading_process_output, read_process_output):
12630 Likewise.
12631
b93aacde
PE
12632 * process.c: Rename or move locals to avoid shadowing.
12633 (list_processes_1, Fmake_network_process):
12634 (read_process_output_error_handler, exec_sentinel_error_handler):
12635 Rename or move locals.
4dc343ee 12636 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12637 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12638 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12639 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12640 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12641
af8a867c 12642 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12643 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12644 Include tparam.h instead, since it declares them.
af8a867c
PE
12645 * cm.h (PC): Remove extern decl; tparam.h now does this.
12646 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12647 * terminfo.c: Include tparam.h, to check interfaces.
12648 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12649 (tparam): Adjust signature to match interface in tparam.h;
12650 this removes some undefined behavior. Check that outstring and len
12651 are zero, which they always are with Emacs.
12652 * tparam.h (PC, BC, UP): New extern decls.
12653
0248044d 12654 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12655 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12656
8ff096c1 12657 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12658 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12659 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12660 (ftfont_list): Remove unused local.
49eaafba
PE
12661 (get_adstyle_property, ftfont_pattern_entity):
12662 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12663 Rename locals to avoid shadowing.
8ff096c1 12664
e2be39f6
PE
12665 * xfont.c (xfont_list_family): Mark var as initialized.
12666
c9735e30
PE
12667 * xml.c (make_dom): Now static.
12668
8f5201ae
PE
12669 * composite.c (composition_compute_stop_pos): Rename local to
12670 avoid shadowing.
b246f932
PE
12671 (composition_reseat_it): Remove unused locals.
12672 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12673 (composition_update_it): Mark var as initialized.
11b61122
PE
12674 (find_automatic_composition): Mark vars as initialized,
12675 with a FIXME (Bug#8290).
8f5201ae 12676
760fbc2c
PE
12677 character.h: Rename locals to avoid shadowing.
12678 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12679 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12680 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12681 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12682 to avoid shadowing.
12683
ff08eb85
PE
12684 * textprop.c (property_change_between_p): Remove; unused.
12685
fc7bf025
PE
12686 * intervals.c (interval_start_pos): Now static.
12687
235d7abc
PE
12688 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12689
44f230aa
SM
12690 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12691 Rename locals to avoid shadowing.
3e7d6594 12692
50060332
PE
12693 * sound.c (wav_play, au_play, Fplay_sound_internal):
12694 Fix pointer signedness.
d01f234b 12695 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12696 (wav_play): Initialize a variable to 0, to prevent undefined
12697 behavior (Bug#8278).
50060332 12698
c4fc4e30
PE
12699 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12700
918436ed
PE
12701 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12702
c939f91b
PE
12703 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12704 clobbering (Bug#8298).
b9c7f648
PE
12705 * sysdep.c (sys_subshell): Likewise.
12706 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12707
6bd8c144
PE
12708 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12709 This should get cleaned up, so that child_setup has the
12710 same signature on all platforms.
12711
7710357c 12712 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12713 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12714
c59da222
CY
127152011-03-22 Chong Yidong <cyd@stupidchicken.com>
12716
12717 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12718 not to be necessary, and produces flickering.
12719
66b87493
GM
127202011-03-20 Glenn Morris <rgm@gnu.org>
12721
12722 * config.in: Remove file.
12723
45b6f6d5
JB
127242011-03-20 Juanma Barranquero <lekktu@gmail.com>
12725
12726 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12727 are now in src/globals.h.
12728 (syms_of_minibuf): Remove spurious & from previous change.
12729
cd394be1 127302011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12731
12732 * minibuf.c (completing-read-function): New variable.
12733 (completing-read-default): Rename from completing-read.
12734 (completing-read): Call completing-read-function.
12735
b14e3e21
CY
127362011-03-19 Juanma Barranquero <lekktu@gmail.com>
12737
12738 * xfaces.c (Fx_load_color_file):
12739 Read color file from absolute filename (bug#8250).
12740
f2b726e6
JB
127412011-03-19 Juanma Barranquero <lekktu@gmail.com>
12742
12743 * makefile.w32-in: Update dependencies.
12744
09f6ff02
EZ
127452011-03-17 Eli Zaretskii <eliz@gnu.org>
12746
12747 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12748
29a6015a
PE
127492011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12750
a3a6c54e
PE
12751 Fix more problems found by GCC 4.5.2's static checks.
12752
b766f867
PE
12753 * process.c (make_serial_process_unwind, send_process_trap):
12754 (sigchld_handler): Now static.
12755
be02381c
PE
12756 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12757 That way, the code declares only the vars that it needs.
12758 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12759 * s/cygwin.h (PTY_ITERATION): Likewise.
12760 * s/darwin.h (PTY_ITERATION): Likewise.
12761 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12762
57048744
PE
12763 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12764 * process.c (allocate_pty): Don't declare stb unless it's needed.
12765
7914961c 12766 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12767 (CONSTANTLIM): Remove; unused.
12768 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12769 Define only if needed.
7914961c 12770
b3967b18
PE
12771 * unexelf.c (unexec): Name an expression,
12772 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12773 Use a different way to cause a compilation error if anyone uses
12774 n rather than nn, a way that does not involve shadowing.
73366a00 12775 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12776
29a6015a
PE
12777 * deps.mk (unexalpha.o): Remove; unused.
12778
43cfc33e 12779 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12780 * unexec.h: New file.
ce701a33
PE
12781 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12782 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12783 Depend on unexec.h.
12784 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12785 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12786 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12787 Change as necessary to match prototype in unexec.h.
ce701a33 12788
01f44d5a
PE
12789 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12790 shadowing.
4f63c6bb 12791 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12792
a6670b0b
PE
12793 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12794 Rename locals to avoid shadowing.
12795
cef2010d 12796 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12797 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12798
d4d7173a
PE
12799 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12800
f08b802a
PE
12801 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12802 warning when compiling print.c.
12803
3ddb0639
PE
12804 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12805 instead of using an uninitialized var.
5ad03b97 12806 (font_sort_entities): Mark var as initialized.
3ddb0639 12807
170a2692
PE
12808 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12809
e663c700
PE
12810 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12811 pointers to constants.
89bc529a 12812 (font_parse_fcname): Remove unused vars.
7b81e2d0 12813 (font_delete_unmatched): Now static.
ea838e10 12814 (font_get_spec): Remove; unused.
13a547c6
PE
12815 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12816 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12817 Rename or move locals to avoid shadowing.
e663c700 12818
2a80c887 12819 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12820 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12821
1384fa33 12822 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12823 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12824
8b2c52e9
PE
12825 * alloc.c (mark_backtrace): Move decl from here ...
12826 * lisp.h: ... to here, so that it can be checked.
12827
475545b5 12828 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12829 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12830 (lisp_indirect_variable): Name an expression,
12831 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12832 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12833
b1349114 12834 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12835 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12836 Use const pointer when appropriate.
b1349114 12837
a2928364
PE
12838 * lisp.h (get_system_name, get_operating_system_release):
12839 Move decls here, to check interfaces.
12840 * process.c (get_operating_system_release): Move decl to lisp.h.
12841 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12842 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12843 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12844 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12845 (Fformat_time_string, Fencode_time, Finsert_char):
12846 (Ftranslate_region_internal, Fformat):
12847 Rename or remove local vars to avoid shadowing.
9710023e 12848 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12849
a415e694
PE
12850 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12851 avoid shadowing.
12852
8ef4622d
PE
12853 * lisp.h (eassert): Check that the argument compiles, even if
12854 ENABLE_CHECKING is not defined.
12855
946f9a5b
PE
12856 * data.c (Findirect_variable): Name an expression, to avoid
12857 gcc -Wbad-function-cast warning.
112396d6 12858 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12859 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12860 (Fmake_variable_buffer_local, Fmake_local_variable):
12861 Mark variables as initialized.
52746918 12862 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12863
e5aab7e7 12864 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12865 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12866 Rename locals to avoid shadowing.
dff45157
PE
12867 (mark_stack): Move local variables into the #ifdef region where
12868 they're used.
7bc26fdb
PE
12869 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12870 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12871 needed otherwise.
12872 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12873 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12874 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12875
e5aab7e7
PE
12876 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12877 avoids undefined behavior in theory.
12878
4da60324
PE
12879 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12880
88043301
PE
12881 Use functions, not macros, for up- and down-casing (Bug#8254).
12882 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12883 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12884 to use the following functions instead of these macros.
12885 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12886 EMACS_INT, since callers assume the returned value fits in int.
12887 (upcase1): Likewise, for UPCASE_TABLE.
12888 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12889 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12890 the race-condition problem in the old DOWNCASE.
88043301 12891
19ed5445
PE
12892 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12893 Rename locals to avoid shadowing.
12894 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12895 (regex_compile, re_search_2, re_match_2_internal):
12896 Remove unused local vars.
952db0d7
PE
12897 (FREE_VAR): Rewrite so as not to use empty "else",
12898 which gcc can warn about.
da053e48 12899 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12900 (RETALLOC_IF): Define only if needed.
12901 (WORDCHAR_P): Likewise. This one is never needed, but is used
12902 only in a comment talking about a compiler bug, so put inside
12903 the #if 0 of that comment.
12904 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12905 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12906 Remove; unused.
19ed5445 12907
1f3561e4 12908 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12909 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12910 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12911
ded6f8f7
PE
12912 * search.c (simple_search): Remove unused var.
12913
dbd37a95
PE
12914 * dired.c (compile_pattern): Move decl from here ...
12915 * lisp.h: ... to here, so that it can be checked.
12916 (struct re_registers): New forward decl.
12917
7e47afad
PE
12918 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12919
85f24f61
PE
12920 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12921 All uses changed.
12922 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12923 Rename locals to avoid shadowing.
5671df8f 12924 (Fvertical_motion): Mark locals as initialized.
85f24f61 12925
181aa2be 12926 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12927 (casify_region): Mark local as initialized.
181aa2be 12928
930d429c
PE
12929 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12930
7082eac6
PE
12931 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12932 New macros, so that the caller can use some names other than
12933 gcpro1, gcpro2, etc.
12934 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12935 of the new macros.
12936 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12937 argument, for consistency with GCPRO2_VAR, etc: it is now the
12938 prefix of the variable, not the variable itself. All uses
12939 changed.
38b2c076
PE
12940 * dired.c (directory_files_internal, file_name_completion):
12941 Rename locals to avoid shadowing.
12942
15206ed9
PE
12943 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12944 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12945 dired.c's scmp function, had undefined behavior.
12946 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12947 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12948 * buffer.h: ... to here, because these macros use current_buffer,
12949 and the new implementation with inline functions needs to have
12950 current_buffer in scope now, rather than later when the macros
12951 are used.
12952 (downcase, upcase1): New static inline functions.
12953 (DOWNCASE, UPCASE1): Reimplement using these functions.
12954 This avoids undefined behavior in expressions like
12955 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12956 from race conditions in accessing the global variables
12957 case_temp1 and case_temp2.
12958 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12959 * lisp.h (case_temp1, case_temp2): Remove their decls.
12960 * character.h (ASCII_CHAR_P): Move from here ...
12961 * lisp.h: ... to here, so that the inline functions mentioned
12962 above can use them.
12963
4a6bea26
PE
12964 * dired.c (directory_files_internal_unwind): Now static.
12965
f14b7e14
PE
12966 * fileio.c (file_name_as_directory, directory_file_name):
12967 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12968 Now static.
2893f146
PE
12969 (file_name_as_directory): Use const pointers when appropriate.
12970 (Fexpand_file_name): Likewise. In particular, newdir might
12971 point at constant storage, so make it a const pointer.
fd4ead52 12972 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12973 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12974 signedness issues.
f839df0c
PE
12975 (Fset_file_times, Finsert_file_contents, auto_save_error):
12976 Rename locals to avoid shadowing.
f14b7e14 12977
5716756e 12978 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12979 (Ftry_completion, Fall_completions): Rename or remove locals
12980 to avoid shadowing.
5716756e 12981
b4c3046a
PE
12982 * marker.c (bytepos_to_charpos): Remove; unused.
12983
b45db522
PE
12984 * lisp.h (verify_bytepos, count_markers): New decls,
12985 so that gcc does not warn that these functions aren't declared.
12986
85876d07
PE
12987 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12988 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12989 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12990 (copy_text): Remove unused local var.
85876d07 12991
03d78a21 12992 * filelock.c (within_one_second): Now static.
b3dd38ab 12993 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12994
5df8f01b
PE
12995 * buffer.c (fix_overlays_before): Mark locals as initialized.
12996 (fix_start_end_in_overlays): Likewise. This function should be
12997 simplified by using pointers-to-pointers, but that's a different
12998 matter.
b1d876f1 12999 (switch_to_buffer_1): Now static.
8f54f30a
PE
13000 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13001 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13002
a70072c9 13003 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13004 Fix pointer signedness issue.
edced198
PE
13005 (sys_subshell): Mark local as volatile if checking for lint,
13006 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13007 (MAXPATHLEN): Define only if needed.
a70072c9 13008
a0977c44
PE
13009 * process.c (serial_open, serial_configure): Move decls from here ...
13010 * systty.h: ... to here, so that they can be checked.
13011
a884fdcc
PE
13012 * fns.c (get_random, seed_random): Move extern decls from here ...
13013 * lisp.h: ... to here, so that they can be checked.
13014
604efe86 13015 * sysdep.c (reset_io): Now static.
b8950c94 13016 (wait_for_termination_signal): Remove; unused.
604efe86 13017
38fc62d9
PE
13018 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13019 (copy_keymap_item, append_key, push_text_char_description):
13020 Now static.
1004a21a 13021 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13022 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13023 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13024 (describe_map_tree):
13025 Rename locals to avoid shadowing.
38fc62d9 13026
2f2650da
PE
13027 * keyboard.c: Declare functions static if they are not used elsewhere.
13028 (echo_char, echo_dash, cmd_error, top_level_2):
13029 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13030 (read_char, kbd_buffer_get_event, make_lispy_position):
13031 (make_lispy_event, make_lispy_movement, apply_modifiers):
13032 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13033 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13034 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13035 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13036 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13037
a053e86c 13038 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13039 (mark_kboards): Move decl here ...
13040 * alloc.c (mark_kboards): ... from here.
a053e86c 13041
4752793e
PE
13042 * lisp.h (force_auto_save_soon): New decl.
13043
74f10ca7 13044 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13045 (DEFINE_DUMMY_FUNCTION): New macro.
13046 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13047 Use it.
c03cd23f
PE
13048 (main): Add casts to avoid warnings
13049 if GCC considers string literals to be constants.
74f10ca7 13050
022e70d4
PE
13051 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13052
59d6fe83
PE
13053 * dbusbind.c: Pointer signedness fixes.
13054 (xd_signature, xd_append_arg, xd_initialize):
13055 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13056 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13057 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13058 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13059
78320123
PE
13060 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13061 if GCC considers string literals to be constants.
49cebcca 13062 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13063
35ac2a97
SM
130642011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13065
fb103ca9
SM
13066 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13067 (print_preprocess, print_object): New macro to fix last change.
13068
35ac2a97
SM
13069 * print.c (print_preprocess): Don't forget font objects.
13070
62973b41
JB
130712011-03-16 Juanma Barranquero <lekktu@gmail.com>
13072
13073 * emacs.c (USAGE3): Doc fixes.
13074
0e48bb22
AS
130752011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13076
13077 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13078 structure.
13079
7684e57b
JB
130802011-03-14 Juanma Barranquero <lekktu@gmail.com>
13081
13082 * lisp.h (VWindow_system, Qfile_name_history):
13083 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13084 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13085 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13086
13087 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13088 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13089
13090 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13091 * w32console.c (detect_input_pending, read_input_pending)
13092 (encode_terminal_code):
13093 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13094 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13095 (w32_system_caret_y, Qfile_name_history):
13096 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13097 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13098 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13099 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13100 * w32proc.c (Qlocal, report_file_error):
13101 * w32term.c (Vwindow_system, updating_frame):
13102 * w32uniscribe.c (initialized, uniscribe_font_driver):
13103 Remove unneeded extern declarations.
13104
2aa46d6c
CY
131052011-03-14 Chong Yidong <cyd@stupidchicken.com>
13106
c96bbc66 13107 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13108
cffc6f3b
CY
131092011-03-13 Chong Yidong <cyd@stupidchicken.com>
13110
13111 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13112 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13113 These macros can no longer be used for assignment.
13114
44f230aa
SM
13115 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13116 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13117 (record_buffer_markers, fetch_buffer_markers): New functions for
13118 recording and fetching special buffer markers.
13119 (set_buffer_internal_1, set_buffer_temp): Use them.
13120
13121 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13122
13123 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13124
13125 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13126 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13127
13128 * xdisp.c (hscroll_window_tree):
13129 (reconsider_clip_changes): Use PT instead of BUF_PT.
13130
d251f04b
EZ
131312011-03-13 Eli Zaretskii <eliz@gnu.org>
13132
13133 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13134 $(EMACS_ROOT)/lib/intprops.h.
13135
f0c77cd1
PE
131362011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13137
3eca4629
PE
13138 Fix more problems found by GCC 4.5.2's static checks.
13139
7c86ee98
PE
13140 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13141 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13142 (xg_free_frame_widgets): Make it clear that a local variable is
13143 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13144 (gdk_window_get_screen): Make it clear that this macro is needed
13145 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13146 (int_gtk_range_get_value): New function, which avoids a diagnostic
13147 from gcc -Wbad-function-cast.
13148 (xg_set_toolkit_scroll_bar_thumb): Use it.
13149 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13150 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13151 (get_utf8_string, xg_get_file_with_chooser):
13152 Rename locals to avoid shadowing.
13153 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13154
41729b81
PE
13155 * xgselect.c (xg_select): Remove unused var.
13156
f0c77cd1
PE
13157 * image.c (four_corners_best): Mark locals as initialized.
13158 (gif_load): Initialize transparent_p to zero (Bug#8238).
13159 Mark another local as initialized.
ec6cf4c6 13160 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13161
ce0ad53d 13162 * image.c (clear_image_cache): Now static.
d5d5a617 13163 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13164 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13165 (x_edge_detection): Remove unnecessary cast that
13166 gcc -Wbad-function-cast diagnoses.
2037898d 13167 (gif_load): Fix pointer signedness.
6ae141d6
PE
13168 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13169 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13170
33383987 131712011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13172
d32df629
PE
13173 Improve quality of tests for time stamp overflow.
13174 For example, without this patch (encode-time 0 0 0 1 1
13175 1152921504606846976) returns the obviously-bogus value (-948597
13176 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13177 reports time overflow. See
13178 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13179 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13180 * editfns.c: Include limits.h and intprops.h.
13181 (TIME_T_MIN, TIME_T_MAX): New macros.
13182 (time_overflow): Move earlier, to before first use.
13183 (hi_time, lo_time): New functions, for an accurate test for
13184 out-of-range times.
13185 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13186 (Fget_internal_run_time): Don't assume time_t fits in int.
13187 (make_time): Use list2 instead of Fcons twice.
13188 (Fdecode_time): More accurate test for out-of-range times.
13189 (check_tm_member): New function.
13190 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13191 (lisp_time_argument): Don't rely on undefined left-shift and
13192 right-shift behavior when checking for time stamp overflow.
8be6f318 13193
fe31d94c
PE
13194 * editfns.c (time_overflow): New function, refactoring common code.
13195 (Fformat_time_string, Fdecode_time, Fencode_time):
13196 (Fcurrent_time_string): Use it.
13197
8be6f318
PE
13198 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13199 * dired.c (make_time): Move to ...
13200 * editfns.c (make_time): ... here.
13201 * systime.h: Note the move.
13202
09d9db2c 132032011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13204
126bc0dc
YM
13205 * fringe.c (update_window_fringes): Remove unused variables.
13206
c47cbdfd
YM
13207 * unexmacosx.c (copy_data_segment): Also copy __got section.
13208 (Bug#8223)
13209
7ac80be9
EZ
132102011-03-12 Eli Zaretskii <eliz@gnu.org>
13211
c96bbc66 13212 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13213 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13214 Constify `char *' arguments and their references according to
13215 prototypes in tparam.h.
13216
ecb0f94d 13217 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13218
7ac80be9
EZ
13219 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13220 Adapt all references accordingly.
13221
13222 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13223
ef1fd07e
TT
132242011-03-11 Tom Tromey <tromey@redhat.com>
13225
13226 * buffer.c (syms_of_buffer): Remove obsolete comment.
13227
7ef4b50c
EZ
132282011-03-11 Eli Zaretskii <eliz@gnu.org>
13229
13230 * termhooks.h (encode_terminal_code): Declare prototype.
13231
13232 * msdos.c (encode_terminal_code): Don't declare prototype.
13233
13234 * term.c (encode_terminal_code): Now external again, used by
13235 w32console.c and msdos.c.
13236
44f230aa
SM
13237 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13238 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13239
4b1ec863 132402011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13241
1714f52b 13242 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13243
4b1ec863
PE
13244 * fringe.c (update_window_fringes): Mark locals as initialized
13245 (Bug#8227).
13246 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13247
524c7aa6
PE
13248 * alloc.c (mark_fringe_data): Move decl from here ...
13249 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13250 to check its interface.
13251 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13252
a5c0af81 13253 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13254 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13255 (fontset_font): Mark local as initialized.
a9a06e0b 13256 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13257
b4716021
PE
13258 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13259
811e9bac 13260 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13261 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13262 (x_own_selection, Fx_disown_selection_internal): Rename locals
13263 to avoid shadowing.
13264 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13265
7e3ab302
PE
13266 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13267 so that the caller can use some name other than gcpro1.
13268 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13269 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13270 (Fx_backspace_delete_keys_p):
13271 Use them to avoid shadowing, and rename vars to avoid shadowing.
13272 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13273 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13274 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13275 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13276 Remove unused locals.
7e3ab302
PE
13277 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13278 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13279 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13280 macros.
f78faa98 13281
e2b13473
PE
13282 * xterm.h (x_mouse_leave): New decl.
13283
77f23912
PE
13284 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13285 Remove unused functions.
cdf4ba58
PE
13286 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13287 (x_calc_absolute_position): Now static.
7411c686 13288 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13289 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13290 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13291 unless they are used.
38d0b34a
PE
13292 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13293 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13294 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13295 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13296 (x_error_catcher, x_connection_closed, x_error_handler):
13297 (x_error_quitter, xembed_send_message, x_iconify_frame):
13298 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13299 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13300 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13301
44f230aa
SM
13302 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13303 Rename or move locals to avoid shadowing.
6b463e58 13304 (tty_defined_color, merge_face_heights): Now static.
5967d051 13305 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13306 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13307 does not deduce is never used uninitialized.
73719eba
PE
13308 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13309 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13310
426994c3 13311 * terminal.c (store_terminal_param): Now static.
5489860b 13312
032f1620 13313 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13314 (set_frame_menubar): Remove unused local.
d4323972 13315 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13316 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13317 since they might point to immutable storage.
281585b0
PE
13318 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13319 since it's unused otherwise.
032f1620 13320
367c19e5 13321 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13322 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13323 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13324 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13325 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13326 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13327 does not deduce are never used uninitialized.
70739cbe 13328
07b48fa9
PE
13329 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13330
8868a238 13331 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13332 * window.c (window_loop, size_window):
13333 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13334
7e5cf297 13335 * window.c (display_buffer): Now static.
d6550a9f
PE
13336 (size_window): Mark variables that gcc -Wuninitialized
13337 does not deduce are never used uninitialized.
a586633d
PE
13338 * window.h (check_all_windows): New decl, to forestall
13339 gcc -Wmissing-prototypes diagnostic.
5b555da1 13340 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13341
f6095868
PE
13342 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13343 shadowing.
13344 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13345 Include <limits.h>.
13346 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13347 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13348 (load_charset_map): Mark variables that gcc -Wuninitialized
13349 does not deduce are never used uninitialized.
53df7c11 13350 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13351
f38b440c
PE
13352 * coding.c (coding_set_source, coding_set_destination):
13353 Use "else { /* comment */ }" rather than "else /* comment */;"
13354 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13355 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13356 a block, when the outer 'i' will do.
13357 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13358 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13359 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13360 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13361 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13362 Rename locals to avoid shadowing.
13363 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13364 * coding.c (emacs_mule_char, encode_invocation_designation):
13365 Now static, since they're not used elsewhere.
413bb2db 13366 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13367 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13368 (decode_coding_emacs_mule): Mark variables that gcc
13369 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13370 (detect_coding_iso_2022): Initialize a local variable that might
13371 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13372 this initialization is needed. (Bug#8211)
5f58e762
PE
13373 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13374 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13375 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13376 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13377 Remove unused macros.
f38b440c 13378
232b38b9 13379 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13380 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13381 * character.c (string_count_byte8): Likewise.
232b38b9 13382
fb90da1b
PE
13383 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13384 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13385
fb93dbc2
PE
13386 * chartab.c (copy_sub_char_table): Now static, since it's not used
13387 elsewhere.
5c156ace
PE
13388 (sub_char_table_ref_and_range, char_table_ref_and_range):
13389 Rename locals to avoid shadowing.
bbcd0949 13390 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13391
7d3b3862 13392 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13393 (BIDI_BOB): Remove unused macro.
7d3b3862 13394
6be7d3da
PE
13395 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13396 deduce are never used uninitialized.
c2ed9c8b 13397 * term.c (encode_terminal_code): Likewise.
6be7d3da 13398
75f8807f 13399 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13400
50938595
PE
13401 * tparam.h: New file.
13402 * term.c, tparam.h: Include it.
13403 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13404 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13405 Move these decls to tparam.h, and make them agree with what
13406 is actually in tparam.c. The previous trick of using incompatible
13407 decls in different modules does not conform to the C standard.
13408 All callers of tparam changed to use tparam's actual API.
13409 * tparam.c (tparam1, tparam, tgoto):
13410 Use const pointers where appropriate.
13411
fbceeba2
PE
13412 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13413 * cm.h (struct cm): Likewise.
13414 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13415 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13416 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13417 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13418 (turn_on_face, init_tty): Likewise.
13419 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13420
7f3f1250
PE
13421 * term.c (term_mouse_position): Rename local to avoid shadowing.
13422
e6ca6543
PE
13423 * alloc.c (mark_ttys): Move decl from here ...
13424 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13425
c40f8d15
AS
134262011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13427
13428 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13429
cfe0661d
JB
134302011-03-09 Juanma Barranquero <lekktu@gmail.com>
13431
13432 * search.c (compile_pattern_1): Remove argument regp, unused since
13433 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13434 (compile_pattern): Don't pass it.
13435
0afb4571
J
134362011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13437
13438 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13439 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13440 for ! HAVE_GTK3.
13441 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13442
13443 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13444
13445 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13446 gdk_window_get_screen, gdk_window_get_geometry,
13447 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13448 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13449 (xg_get_pixbuf_from_pixmap): New function.
13450 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13451 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13452 Call xg_get_pixbuf_from_pixmap instead of
13453 gdk_pixbuf_get_from_drawable.
13454 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13455 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13456 (xg_check_special_colors): Use GtkStyleContext and its functions
13457 for HAVE_GTK3.
13458 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13459 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13460 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13461 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13462 Call gtk_widget_get_preferred_size.
0afb4571
J
13463 (xg_frame_resized): gdk_window_get_geometry only takes 5
13464 parameters.
44f230aa
SM
13465 (xg_win_to_widget, xg_event_is_for_menubar):
13466 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13467 (xg_set_widget_bg): New function.
13468 (delete_cb): New function.
895009e1 13469 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13470 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13471 (xg_set_background_color): Call xg_set_widget_bg.
13472 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13473 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13474 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13475 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13476 if ! HAVE_GTK3.
13477 (update_frame_tool_bar): Call gtk_widget_hide.
13478 (xg_initialize): Use GDK_KEY_g.
13479
13480 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13481 if ! HAVE_GTK3
13482 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13483
13484 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13485 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13486 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13487
1c2cc4ef
JB
134882011-03-08 Juanma Barranquero <lekktu@gmail.com>
13489
13490 * w32xfns.c (select_palette): Check success of RealizePalette against
13491 GDI_ERROR, not zero.
13492
33383987 13493See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13494
13495;; Local Variables:
13496;; coding: utf-8
aac0c6e3
MR
13497;; End:
13498
2f097256 13499 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13500
13501 This file is part of GNU Emacs.
13502
13503 GNU Emacs is free software: you can redistribute it and/or modify
13504 it under the terms of the GNU General Public License as published by
13505 the Free Software Foundation, either version 3 of the License, or
13506 (at your option) any later version.
13507
13508 GNU Emacs is distributed in the hope that it will be useful,
13509 but WITHOUT ANY WARRANTY; without even the implied warranty of
13510 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13511 GNU General Public License for more details.
13512
13513 You should have received a copy of the GNU General Public License
13514 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.