* alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
356e7178
PE
12012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2
3 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
4 that causes compilation to fail on pre-C99 compilers.
5
95f61aa2
JB
62012-07-04 Juanma Barranquero <lekktu@gmail.com>
7
8 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
9 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
10
3884d954
DA
112012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
12
d209e2fb 13 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
14 headers for buffer_defaults and buffer_local_symbols.
15 Reported by Juanma Barranquero <lekktu@gmail.com>.
16
ee28be33
SM
172012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
18
19 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
20 * lisp.h (enum pvec_type): Use fewer bits.
21 (PSEUDOVECTOR_SIZE_BITS): New constant.
22 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
23 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
24 change in pvec_type.
25 (PSEUDOVECTOR_TYPEP): New macro.
26 (TYPED_PSEUDOVECTORP): Use it.
27 * fns.c (internal_equal): Adapt code to extract pvectype.
28 * emacs.c (gdb_pvec_type): Update type.
29 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
30 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
31 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
32 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
33 (sweep_vectors): Use it. Use local var `total_bytes' instead of
34 abusing vector->header.next.nbytes.
35 (live_vector_p): Use PVEC_TYPE.
36 (mark_object): Adapt code to extract pvectype. Use switch.
37
c7f2cd7f
PE
382012-07-04 Paul Eggert <eggert@cs.ucla.edu>
39
40 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
41 Tighten new eassert a bit.
42
8ce70ed2
DA
432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
44
45 Fix compilation with --enable-gcc-warnings and -O1
46 optimization level.
47 * doprnt.c (doprnt): Change type of tem to int, initialize
48 to avoid compiler warning. Add eassert.
49 * search.c (simple_search): Initialize match_byte to avoid
50 compiler warning. Add eassert.
51
dea7f1e5
PE
522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
53
24a212eb
PE
54 Avoid weird behavior with large horizontal scrolls.
55 Without this change, for example, large hscroll values would
56 mess up Emacs's display on Fedora 15 x86, presumably due to
57 overflows in int calculations in the display code.
58 Also, if buffers had long lines, Emacs would freeze.
59 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
60 (set_window_hscroll): New function, containing the old guts of
61 Fset_window_hscroll. Return the clipped value.
62 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
63 This avoids the need to check against PTRDIFF_MAX.
64
dea7f1e5
PE
65 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
66
76046526
DA
672012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
68
69 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
70
39adff0d
PE
712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
72
63807d47
PE
73 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
74 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
75 since GCC 4.4.6 issues a bogus warning for them.
76
39adff0d
PE
77 Fix bugs in file timestamp newness comparisons.
78 * fileio.c (Ffile_newer_than_file_p):
79 * lread.c (Fload): Use full timestamp resolution of files,
80 not just the 1-second resolution, so that files that are only
81 slightly newer still count as newer.
82 * fileio.c (Ffile_newer_than_file_p): Don't assume file
83 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
84
dbeed9a6
PE
852012-07-03 Paul Eggert <eggert@cs.ucla.edu>
86
87 * fileio.c: Improve handling of file time marker. (Bug#11852)
88 (special_mtime): New function.
89 (Finsert_file_contents, Fverify_visited_file_modtime):
90 Use it to set special mtime values consistently.
91
636334d6
AS
922012-07-03 Andreas Schwab <schwab@linux-m68k.org>
93
94 * fileio.c (Finsert_file_contents): Properly handle st_mtime
95 marker for non-existing file. (Bug#11852)
96
e2017fe2
GM
972012-07-03 Glenn Morris <rgm@gnu.org>
98
99 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
100 and did not make it into globals.h).
101
404dbd37
TT
1022012-07-03 Tom Tromey <tromey@redhat.com>
103
104 * window.c (Fset_window_margins, Fset_window_fringes)
105 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
106 * textprop.c (Fprevious_property_change): No longer static.
107 * syntax.c (Fsyntax_table_p): No longer static.
108 * process.c (Fget_process, Fprocess_datagram_address): No longer
109 static.
110 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
111 * keyboard.c (Fcommand_execute): No longer static.
112 Remove EXFUN.
113 * insdel.c (Fcombine_after_change_execute): No longer static.
114 * image.c (Finit_image_library): No longer static.
115 * fileio.c (Fmake_symbolic_link): No longer static.
116 * eval.c (Ffetch_bytecode): No longer static.
117 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
118 * doc.c (Fdocumentation_property, Fsnarf_documentation):
119 No longer static.
404dbd37
TT
120 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
121 static.
122 * dired.c (Ffile_attributes): No longer static.
123 * composite.c (Fcomposition_get_gstring): No longer static.
124 * callproc.c (Fgetenv_internal): No longer static.
125
126 * ccl.h: Remove EXFUNs.
127 * buffer.h: Remove EXFUNs.
128 * dispextern.h: Remove EXFUNs.
129 * intervals.h: Remove EXFUNs.
130 * fontset.h: Remove EXFUN.
131 * font.h: Remove EXFUNs.
132 * dosfns.c (system_process_attributes): Remove EXFUN.
133 * keymap.h: Remove EXFUNs.
134 * lisp.h: Remove EXFUNs.
135 * w32term.h: Remove EXFUNs.
136 * window.h: Remove EXFUNs.
137 * xsettings.h: Remove EXFUN.
138 * xterm.h: Remove EXFUN.
139
8e4fd1e1
GM
1402012-07-03 Glenn Morris <rgm@gnu.org>
141
142 * lisp.h (Frandom): Make it visible to C.
143 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
144 buffer for invisible buffers. (Bug#1229)
145
ca95b3eb
DA
1462012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
147
148 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
149 values which aren't power of 2.
150 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
151 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
152 accordingly.
153
7555c33f
SM
1542012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
157
158 * alloc.c (mark_object): Revert part of last patch to use `switch'.
159
d12e8f5a
DA
1602012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
161
162 * alloc.c (allocate_vector_block): Remove redundant
163 calls to mallopt if DOUG_LEA_MALLOC is defined.
164 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
165 avoid calls to mallopt if zero_vector is returned.
166
296094c3
DA
1672012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
168
169 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
170 is enabled, avoid dereferencing NULL current_sblock if
171 running undumped.
172
36429c89
DA
1732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
174
175 Cleanup basic buffer management.
176 * buffer.h (struct buffer): Change layout to use generic vector
177 marking code. Fix some comments. Change type of 'clip_changed'
178 to bitfield. Remove unused #ifndef old.
179 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
180 (GET_OVERLAYS_AT): Fix indentation.
181 (for_each_per_buffer_object_at): New macro.
182 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
183 (Fbuffer_local_variables): Use it.
184 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
185 * alloc.c (allocate_buffer): Adjust to match new layout of
186 struct buffer. Fix comment.
187 (mark_overlay): New function.
188 (mark_buffer): Use it. Use mark_vectorlike to mark normal
189 Lisp area of struct buffer.
190 (mark_object): Use it. Adjust marking of misc objects
191 and related comments.
192
3b3e4cac
PE
1932012-07-02 Paul Eggert <eggert@cs.ucla.edu>
194
195 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
196 wrapper that is not needed because the wrapped code is a no-op (zero
197 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
198 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
199
cf5c0175
DA
2002012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
201
202 * alloc.c (mark_buffer): Simplify. Remove prototype.
203 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 204 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
205 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
206 redundant calls to mark_vectorlike for bool vectors.
207
ca26824c
GM
2082012-06-30 Glenn Morris <rgm@gnu.org>
209
2e4c5312
GM
210 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
211
ca26824c
GM
212 * epaths.in (PATH_SITELOADSEARCH): New.
213 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
214 This is rather than relying on --enable-locallisppath elements
215 having "site-lisp" in their names. (Bug#10208#25, 11658)
216
0d23c240
EZ
2172012-06-30 Eli Zaretskii <eliz@gnu.org>
218
c9240d7a
EZ
219 * w32proc.c (sys_select): Accept and ignore one more argument.
220
221 * w32.c (emacs_gnutls_pull): Call select with one more argument.
222
0d23c240 223 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 224 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
225
226 * sysdep.c: Don't include dos.h and dosfns.h.
227
228 * process.c (sys_select):
229 * msdos.c (sys_select): Accept one more argument and ignore it.
230
231 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
232 adapt data types and code to that.
233
234 * dosfns.c:
235 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
236 which clashes with the gnulib function of the same name.
237
af5a5a98
AS
2382012-06-30 Andreas Schwab <schwab@linux-m68k.org>
239
c5e4379c
AS
240 * font.c (font_style_to_value, font_style_symbolic)
241 (font_prop_validate_style): Add type checks for values in
242 font_style_table.
243
af5a5a98
AS
244 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
245 argument.
246 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
247 uses.
248
8d38f461
EZ
2492012-06-29 Eli Zaretskii <eliz@gnu.org>
250
2e5a6631
EZ
251 * xdisp.c (try_window_id): Undo last change.
252
8d38f461
EZ
253 * w32.c (getwd): Adjust commentary about startup_dir.
254 (init_environment): Always call sys_access, even in non-MSVC
255 builds. Don't chdir to the directory of the Emacs executable.
256 This undoes code from 1997 which was justified by the need to
257 "avoid conflicts when removing and renaming directories". But its
258 downside was that every relative file name was being interpreted
259 relative to the directory of the Emacs executable, which can never
260 be TRT. In particular, it broke sys_access when called with
261 relative file names.
262 (sys_access): Map GetLastError to errno.
263
2af3565e
DA
2642012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
265
266 * window.h (struct window): Change type of 'fringes_outside_margins'
267 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 268 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
269 Adjust comment.
270 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
271 to ptrdiff_t.
272
c8d3a25c 2732012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 274
c8d3a25c
GM
275 * gnutls.c (emacs_gnutls_handshake):
276 Add QUIT to make the loop interruptible.
57570cd3 277
c8d3a25c 2782012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 279
c8d3a25c
GM
280 * charset.c (init_charset): Make lack of etc/charsets fatal.
281
3e984ee8
DA
2822012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
283
284 * editfns.c (region_limit): Fix type mismatch.
285
ef884f23
DA
2862012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
287
288 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
289 undefined. Convert from xassert to eassert.
290 * nsmenu.m: Convert from xassert to eassert.
291 * nsterm.m: Likewise.
292
7d7e0027
SM
2932012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
294
295 * editfns.c (region_limit): Clip to narrowing (bug#11770).
296
aa754e6a
PE
2972012-06-28 Paul Eggert <eggert@cs.ucla.edu>
298
299 Avoid integer overflow on scroll-left and scroll-right.
300 * window.c (HSCROLL_MAX): New macro.
301 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
302 overflow when requested scroll falls outside ptrdiff_t range.
303
80b00b08
DA
3042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
305
306 * window.h (struct window): Change type of 'hscroll',
307 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
308 'last_modified' and 'last_overlay_modified' to EMACS_INT.
309 Adjust users accordingly.
310 * xdisp.c (try_cursor_movement): Replace type check with eassert.
311 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
312 from EMACS_INT to ptrdiff_t.
313 (make_window): Omit redundant initialization.
314
62b2bcf6
JB
3152012-06-28 Juanma Barranquero <lekktu@gmail.com>
316
317 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
318
45942c7d
DA
3192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
320
321 * window.h (struct window): Change type of 'use_time' and
322 'sequence_number' from Lisp_Object to int.
323 * frame.c (make_frame): Adjust users accordingly.
324 * print.c (print_object): Likewise.
325 * window.c (select_window, Fwindow_use_time, make_parent_window)
326 (make_window): Likewise.
327
e509cfa6
DA
3282012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
329
330 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
331 enabled with --enable-checking=[all,glyphs] configure option.
332 Fix GLYPH_DEBUG usage assuming that it may be undefined,
333 adjust comments accordingly.
334 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
335 undefined, adjust comments accordingly.
336 * image.c: Likewise.
337 * scroll.c: Likewise.
338 * w32fns.c: Likewise.
339 * w32term.c: Likewise.
340 * xdisp.c: Likewise.
341 * xfaces.c: Likewise.
342 * xfns.c: Likewise.
343 * xterm.c: Likewise.
344
a54e2c05
DA
3452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
346
347 Generalize run-time debugging checks.
348 * dispextern.h (XASSERTS): Remove.
349 * fontset.c (xassert): Remove.
350 Convert from xassert to eassert.
351 * alloc.c: Convert from xassert to eassert.
352 * bidi.c: Likewise.
353 * dispnew.c: Likewise.
354 * fns.c: Likewise.
355 * fringe.c: Likewise.
356 * ftfont.c: Likewise.
357 * gtkutil.c: Likewise.
358 * image.c: Likewise.
359 * keyboard.c: Likewise.
360 * menu.c: Likewise.
361 * process.c: Likewise.
362 * scroll.c: Likewise.
363 * sound.c: Likewise.
364 * term.c: Likewise.
365 * w32console.c: Likewise.
366 * w32fns.c: Likewise.
367 * w32term.c: Likewise.
368 * window.c: Likewise.
369 * xdisp.c: Likewise.
370 * xfaces.c: Likewise.
371 * xfns.c: Likewise.
372 * xselect.c: Likewise.
373 * xterm.c: Likewise.
374
1ec4b7b2
SM
3752012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * fns.c (maybe_resize_hash_table): Output message when growing the
378 purify-hashtable.
379
2014308a
DA
3802012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
381
382 * alloc.c (allocate_string_data): Remove dead code.
383 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
384 avoid GCC warning about unused macro.
385
246155eb
DA
3862012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
387
388 * alloc.c (allocate_string): Omit intervals initialization.
389 * alloc.c (make_uninit_multibyte_string): Initialize intervals
390 as in make_pure_string and make_pure_c_string.
391
43184b7b
DA
3922012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
393
d209e2fb 394 * alloc.c (allocate_string): Fix last change.
43184b7b 395
3fe6dd74
DA
3962012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
397
d209e2fb 398 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
399 to memset, add explicit initialization where appropriate.
400
1ba6038a
GM
4012012-06-27 Glenn Morris <rgm@gnu.org>
402
403 * lisp.mk (lisp): Remove paths.elc.
404
c89926a5
CY
4052012-06-27 Chong Yidong <cyd@gnu.org>
406
407 * doc.c (Fsubstitute_command_keys): Fix punctuation.
408
ed6b3510
JW
4092012-06-26 John Wiegley <johnw@newartisans.com>
410
1ec4b7b2 411 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
412 on Mac OS X Lion: __mod_init_func and __mod_term_func.
413
ed6b3510
JW
414 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
415 when building with Clang.
416
8edd4a2b
SM
4172012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
418
419 * eval.c (Fapply): Allow calling it with a single argument.
420
f6f62d1b
EZ
4212012-06-26 Eli Zaretskii <eliz@gnu.org>
422
423 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
424 _stricmp and _strnicmp.
425 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
426
62efea5e
DA
4272012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
428
429 * alloc.c (allocate_window): Zero out non-Lisp part of newly
430 allocated window.
431 (allocate_process): Likewise for new process.
8edd4a2b 432 (allocate_terminal): Change to use offsetof.
62efea5e
DA
433 (allocate_frame): Likewise.
434 * frame.c (make_frame): Omit redundant initialization.
435 * window.c (make_parent_window): Use memset.
436 (make_window): Omit redundant initialization.
437 * process.c (make_process): Omit redundant initialization.
438 * terminal.c (create_terminal): Likewise.
439
42997f4d
DA
4402012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
441
442 * term.c (delete_tty): Remove redundant call to memset.
443
1130ecfc
DA
4442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
445
446 * alloc.c: Remove build_string.
447 * lisp.h: Define build_string as static inline. This provides
448 a better opportunity to optimize away calls to strlen when the
449 function is called with compile-time constant argument.
450 * image.c (imagemagick_error): Convert to build_string.
451 * w32proc.c (sys_spawnve): Likewise.
452 * xterm.c (x_term_init): Likewise.
453
cf38a720
PE
4542012-06-26 Paul Eggert <eggert@cs.ucla.edu>
455
99027bdd
PE
456 Use sprintf return value instead of invoking strlen on result.
457 In the old days this wasn't portable, since some sprintf
458 implementations returned char *. But they died out years ago and
459 Emacs already assumes sprintf returns int.
460 Similarly for float_to_string.
461 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
462 * ccl.c (ccl_driver):
463 * character.c (string_escape_byte8):
464 * data.c (Fnumber_to_string):
465 * doprnt.c (doprnt):
466 * print.c (print_object):
467 * xdisp.c (message_dolog):
468 * xfns.c (syms_of_xfns):
469 Use sprintf or float_to_string result to avoid need to call strlen.
470 * data.c (Fnumber_to_string):
471 Use make_unibyte_string, since the string must be ASCII.
472 * lisp.h, print.c (float_to_string): Now returns int length.
473 * term.c (produce_glyphless_glyph):
474 Use sprintf result rather than recomputing it.
475
cf38a720
PE
476 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
477 * Makefile.in (ALL_CFLAGS):
478 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
479 * gmalloc.c, regex.c: Include <config.h> unconditionally.
480
3511c784
DA
4812012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
482
0a08eb21 483 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
484 strcasecmp if available.
485 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
486
fb7da12e
AS
4872012-06-25 Andreas Schwab <schwab@linux-m68k.org>
488
489 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
490 Avoid comma operator.
491 * menu.c (push_submenu_start, push_submenu_end)
492 (push_left_right_boundary, push_menu_pane): Likewise.
493 * msdos.c (dos_rawgetc): Likewise.
494
afa2ffd8
DA
4952012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
496
497 * xfns.c (xic_create_fontsetname): Remove redundant calls
498 to memset.
499
b3b4476b
PE
5002012-06-25 Paul Eggert <eggert@cs.ucla.edu>
501
4495ff38
PE
502 * gtkutil.c (get_utf8_string): Remove redundant assignment.
503 sprintf already null-terminates its output.
504
b3b4476b
PE
505 * xfns.c (x_window): Remove redundant cast.
506
b00876c9
DA
5072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
508
509 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
510 `const char *' to `char *' to avoid compiler warning.
511
d188e26b
PE
5122012-06-24 Paul Eggert <eggert@cs.ucla.edu>
513
885d1d74
PE
514 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
515 instead of truncating it to 63 (admittedly a generous limit).
516
d188e26b
PE
517 * process.c: Fix spelling and caps in comments.
518
e2f560b1
DN
5192012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
520
e86db54b 521 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
522 * sysdep.c (setpgrp): Remove definition, not used in this file.
523
7583a3a1
JB
5242012-06-24 Juanma Barranquero <lekktu@gmail.com>
525
526 * makefile.w32-in: Update dependencies.
527
696056c2
EZ
5282012-06-24 Eli Zaretskii <eliz@gnu.org>
529
530 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
531 (SYSTIME_H): Add nt/inc/sys/time.h.
532
533 * systime.h [WINDOWSNT]: Include sys/time.h.
534
535 * s/ms-w32.h (struct timespec): Definition moved from
536 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
537
845ca893
PE
5382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
539
540 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
541 * buffer.h (buffer_slot_type_mismatch):
542 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
543 * eval.c (unwind_to_catch):
544 * image.c (my_png_error, my_error_exit):
545 * keyboard.c (quit_throw_to_read_char, user_error)
546 (Fexit_recursive_edit, Fabort_recursive_edit):
547 * lisp.h (die, args_out_of_range, args_out_of_range_3)
548 (wrong_type_argument, buffer_overflow, __executable_start)
549 (memory_full, buffer_memory_full, string_overflow, Fthrow)
550 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
551 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
552 (fatal):
553 (child_setup) [!DOS_NT]:
554 * lread.c (end_of_file_error, invalid_syntax):
555 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
556 * puresize.h (pure_write_error):
557 * search.c (matcher_overflow):
558 * sound.c (sound_perror, alsa_sound_perror):
559 * sysdep.c, syssignal.h (croak):
560 * term.c (maybe_fatal, vfatal):
561 * textprop.c (text_read_only):
562 * undo.c (user_error):
563 * unexmacosx.c (unexec_error):
564 * xterm.c (x_ins_del_lines, x_delete_glyphs):
565 Use _Noreturn rather than NO_RETURN.
566 No need for separate decl merely because of _Noreturn.
567 * sound.c (sound_warning, parse_sound):
568 Remove unnecessary forward decls.
569
f1dd8073
PE
5702012-06-24 Paul Eggert <eggert@cs.ucla.edu>
571
572 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
573 * lisp.h (WAIT_READING_MAX): New macro.
574 * dispnew.c (Fsleep_for, sit_for):
575 * keyboard.c (kbd_buffer_get_event):
576 * process.c (Faccept_process_output):
577 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
578 This improves on the previous patch, which introduced a bug
579 when time_t is unsigned and as wide as intmax_t.
580 See <http://bugs.gnu.org/9000#51>.
581
b82c1755
EZ
5822012-06-23 Eli Zaretskii <eliz@gnu.org>
583
584 * dispnew.c (sit_for, Fsleep_for):
585 * keyboard.c (kbd_buffer_get_event):
586 * process.c (Faccept_process_output): Avoid compiler warnings when
587 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
588
ca300656
JB
5892012-06-23 Juanma Barranquero <lekktu@gmail.com>
590
049ec95b
JB
591 * makefile.w32-in: Update dependencies.
592
ca300656
JB
593 * w32.c (ltime): Add return type and declare static.
594 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
595
db7b8d06
PE
5962012-06-23 Paul Eggert <eggert@cs.ucla.edu>
597
598 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
599 Privately reported by Herbert J. Skuhra.
600 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
601 All uses changed.
602 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
603 not make_lisp_timeval, when the argument is of type EMACS_TIME.
604
0bd8297f
EZ
6052012-06-23 Eli Zaretskii <eliz@gnu.org>
606
96512555
EZ
607 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
608 last argument of make_unibyte_string.
609
0bd8297f
EZ
610 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
611 language ID in the event parameters.
612
613 * w32term.c (w32_read_socket): Put the new keyboard codepage into
614 event.code, not the obscure "character set ID".
615
63def6b6
CY
6162012-06-23 Chong Yidong <cyd@gnu.org>
617
618 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
619
e8a02204
EZ
6202012-06-23 Eli Zaretskii <eliz@gnu.org>
621
388cdec0
EZ
622 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
623 * w32.c (fdutimens): New function.
624
625 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
626
627 * s/ms-w32.h (pselect): Redirect to sys_select.
628
629 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
630
e8a02204
EZ
631 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
632 in the logic of incrementing and decrementing the value of
633 use_relocatable_buffers.
634
d054f3fb
PE
6352012-06-23 Paul Eggert <eggert@cs.ucla.edu>
636
637 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
638 Privately reported by Herbert J. Skuhra.
639 [__FreeBSD__]: Remove "*/" typo after "#include".
640 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
641 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
642 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
643 Don't assume EMACS_TIME and struct timeval are the same type.
644
d35af63c
PE
6452012-06-22 Paul Eggert <eggert@cs.ucla.edu>
646
647 Support higher-resolution time stamps (Bug#9000).
648 The time stamps are only nanosecond-resolution at the C level,
649 since that's the best that any real-world system supports now.
650 But they are picosecond-resolution at the Lisp level, as that's
651 easy, and leaves room for future OS improvements.
652
653 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
654 (LIBES): Use it.
655
656 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
657 Don't get current time unless it's needed.
658
659 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
660 now provides it if it's absent.
661 (start_atimer): Port to higher-res time stamps.
662 Check for time stamp overflow. Don't get current time more
663 often than is needed.
664
665 * buffer.h (struct buffer): Buffer modtime now has high resolution.
666 Include systime.h, not time.h.
667 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
668
669 * dired.c: Include stat-time.h.
670 (Ffile-attributes): File times now have higher resolution.
671
672 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
673 (struct image): Timestamp now has higher resolution.
674
675 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
676 has at least microseconds now. All uses removed.
677 (update_frame, update_single_window, update_window, update_frame_1)
678 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
679
680 * editfns.c (time_overflow): Now extern.
681 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
682 (float-time, Fformat_time_string, Fcurrent_time_string)
683 (Fcurrent_time_zone): Accept and generate higher-resolution
684 time stamps.
685 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
686 (decode_time_components, lisp_seconds_argument): New functions.
687 (make_time): Now static.
688 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
689 Report an error if the time is invalid, rather than having the caller
690 do that.
691
692 * fileio.c: Include <stat-time.h>
693 (Fcopy_file): Copy higher-resolution time stamps.
694 Prefer to set the time stamp via a file descriptor if that works.
695 (Fset_file_times, Finsert_file_contents, Fwrite_region)
696 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
697 (Fvisited_file_modtime, Fset_visited_file_modtime):
698 Support higher-resolution time stamps.
699
700 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
701
702 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
703
704 * image.c (prepare_image_for_display, clear_image_cache)
705 (lookup_image): Port to higer-resolution time stamps.
706
707 * keyboard.c (start_polling, bind_polling_period):
708 Check for time stamp overflow.
709 (read_char, kbd_buffer_get_event, timer_start_idle)
710 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
711 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
712 Port to higher-resolution time stamps. Do not assume time_t is signed.
713 (decode_timer): New function. Timers are now vectors of length 9,
714 not 8, to accommodate the picosecond component.
715 (timer_check_2): Use it.
716
717 * nsterm.m (select_timeout, timeval_subtract): Remove.
718 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
719 as they're a bit more accurate and handle overflow better.
720 (ns_select): Change prototype to be compatible with pselect.
721 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
722 * nsterm.h (ns_select): Adjust prototype.
723
724 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
725 us-resolution time stamps.
726 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
727
728 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
729
730 * lisp.h (time_overflow): New decl.
731 (wait_reading_process_output): First arg is now intmax_t, not int,
732 to accommodate larger waits.
733
734 * process.h (struct Lisp_Process.read_output_delay):
735 Now counts nanoseconds, not microseconds.
736 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
737 EMACS_HAS_USECS.
738 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
739 (wait_reading_process_output):
740 Port to ns-resolution time stamps.
741 (Faccept_process_output, wait_reading_process_output):
742 Check for time stamp overflow. Do not assume time_t is signed.
743 (select_wrapper): Remove; we now use pselect.
744 (Fprocess_attributes): Now generates ns-resolution time stamps.
745
746 * sysdep.c: Include utimens.h. Don't include utime.h
747 or worry about struct utimbuf; gnulib does that for us now.
748 (gettimeofday): Remove; gnulib provides a substitute.
749 (make_timeval): New function.
750 (set_file_times): Now sets ns-resolution time stamps.
751 New arg FD; all uses changed.
752 (time_from_jiffies, ltime_from_jiffies, get_up_time)
753 (system_process_attributes):
754 Now returns ns-resolution time stamp. All uses changed.
755 Check for time stamp overflow.
756
757 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
758 provides a substitute now.
759
760 * systime.h: Include timespec.h rather than sys/time.h and time.h,
761 since it guarantees struct timespec.
762 (EMACS_TIME): Now struct timespec, so that we can support
763 ns-resolution time stamps.
764 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
765 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
766 (EMACS_USECS): Remove.
767 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
768 so multiply the arg by 1000 before storing it.
769 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
770 New macros.
771 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
772 Port to ns-resolution time stamps.
773 (EMACS_TIME_NEG_P): Remove; replaced by....
774 (EMACS_TIME_SIGN): New macro.
775 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
776 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
777 (set_file_times, make_time, lisp_time_argument): Adjust signature.
778 (make_timeval, make_lisp_time, decode_time_components): New decls.
779 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
780 that it mishandled time_t overflow. You can't compare by subtracting!
781 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
782 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
783
784 * term.c: Include <sys/time.h>.
785 (timeval_to_Time): New function, for proper overflow wraparound.
786 (term_mouse_position, term_mouse_click): Use it.
787
788 * undo.c (record_first_change): Support higher-resolution time stamps
789 in the undo buffer.
790 (Fprimitive_undo): Use them when restoring time stamps.
791
792 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
793 (w32_get_internal_run_time):
794 Port to higher-resolution Emacs time stamps.
795 (ltime): Now accepts single 64-bit integer, as that's more convenient
796 for callers.
797
798 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
799
800 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
801 for compatibility with pselect. Support ns-resolution time stamps.
802
803 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
804
805 * xselect.c (wait_for_property_change, x_get_foreign_selection):
806 Check for time stamp overflow, and support ns-resolution time stamps.
807
808 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
809 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
810 (timeval_subtract): Remove; no longer needed.
811 (XTflash, XTring_bell, x_wait_for_event):
812 Port to ns-resolution time stamps. Don't assume time_t is signed.
813
b6a92dfe
CY
8142012-06-22 Chong Yidong <cyd@gnu.org>
815
816 * xdisp.c (x_consider_frame_title): Revert last change.
817
d251c37c
EZ
8182012-06-22 Eli Zaretskii <eliz@gnu.org>
819
820 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
821 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
822 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
823 staticidx goes up to 1597 out of 1600 = 0x640.)
824
f10deafb
PE
8252012-06-20 Paul Eggert <eggert@cs.ucla.edu>
826
827 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
828 Otherwise, the umask might be mistakenly 0 while handling input signals.
829
ec6de1e2
SM
8302012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
833
28be1ada
DA
8342012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
835
836 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
837 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
838 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
839 access to `contents' member of Lisp_Vector objects with AREF and ASET
840 where appropriate.
841
c6bf3022
CY
8422012-06-19 Chong Yidong <cyd@gnu.org>
843
844 * frame.c (delete_frame): When selecting a frame on a different
845 text terminal, do not alter the terminal's top-frame.
846
847 * xdisp.c (format_mode_line_unwind_data): Record the target
848 frame's selected window and its terminal's top-frame.
849 (unwind_format_mode_line): Restore them.
850 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
851 Callers changed.
852 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
853 since tty frames can be explicitly named.
854 (prepare_menu_bars): Likewise.
855
856 * term.c (Ftty_top_frame): New function.
857
defd4196
PE
8582012-06-18 Paul Eggert <eggert@cs.ucla.edu>
859
860 Port byte-code-meter to modern targets.
861 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
862 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 863 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
864 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
865 (METER_1, METER_2): Simplify.
866
1053a871
SM
8672012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
868
869 * data.c (Fdefalias): Return `symbol' (bug#11686).
870
b7e8d081
MR
8712012-06-18 Martin Rudalics <rudalics@gmx.at>
872
873 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
874 gets killed during executing of this function (Bug#11665).
875 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
876 (Vkill_buffer_query_functions): In doc-string say that functions
877 run by this hook should not change the current buffer.
878
7ea2b339
PE
8792012-06-18 Paul Eggert <eggert@cs.ucla.edu>
880
881 Fix recently-introduced process.c problems found by static checking.
882 * process.c (write_queue_push, write_queue_pop, send_process):
883 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
884 (write_queue_pop): Fix pointer signedness problem.
885 (send_process): Remove unused local.
886
96a313a1
CY
8872012-06-17 Chong Yidong <cyd@gnu.org>
888
889 * xdisp.c (redisplay_internal): No need to redisplay terminal
890 frames that are not on top.
891
20ca2e94
TN
8922012-06-17 Troels Nielsen <bn.troels@gmail.com>
893
894 * process.c (make_process): Initialize write_queue.
895 (write_queue_push, write_queue_pop): New functions.
896 (send_process): Use them to maintain correct ordering of process
897 writes (Bug#10815).
898
9a900ca9
PE
8992012-06-17 Paul Eggert <eggert@cs.ucla.edu>
900
310fbfa8
PE
901 * lisp.h (eassert): Assume C89 or later.
902 This removes the need for CHECK.
903 (CHECK): Remove. Its comments about always evaluating its
904 argument were confusing, as 'eassert' typically does not evaluate
905 its argument.
906
27bb1ca4
PE
907 * coding.c (produce_chars): Use ptrdiff_t, not int.
908
9a900ca9
PE
909 * xterm.c (x_draw_underwave): Check for integer overflow.
910 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
911
41b7f8bc 9122012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
913
914 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
915 referenced (Bug#11583).
916
9b0e3eba
AA
9172012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
918
919 Implement wave-style variant of underlining.
920 * dispextern.h (face_underline_type): New enum.
921 (face): Add field for underline type.
922 * nsterm.m (ns_draw_underwave): New function.
923 (ns_draw_text_decoration): Use it.
924 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
925 New functions.
926 (x_draw_glyph_string): Use them.
927 * xfaces.c (Qline, Qwave): New Lisp objects.
928 (check_lface_attrs, merge_face_ref)
1053a871
SM
929 (Finternal_set_lisp_face_attribute, realize_x_face):
930 Handle wave-style underline face attributes.
9b0e3eba
AA
931 * xterm.c (x_draw_underwave): New function.
932 (x_draw_glyph_string): Use it.
933
0fb52f11
JB
9342012-06-16 Juanma Barranquero <lekktu@gmail.com>
935
936 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
937 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
938 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
939 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
940 ($(BLD)/w32select.$(O)): Update dependencies.
941
e5560ff7
AS
9422012-06-16 Andreas Schwab <schwab@linux-m68k.org>
943
944 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
945 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
946 * character.c (_fetch_multibyte_char_p): Remove.
947 * alloc.c: Include "character.h" before "buffer.h".
948 * bidi.c: Likewise.
949 * buffer.c: Likewise.
950 * bytecode.c: Likewise.
951 * callint.c: Likewise.
952 * callproc.c: Likewise.
953 * casefiddle.c: Likewise.
954 * casetab.c: Likewise.
955 * category.c: Likewise.
956 * cmds.c: Likewise.
957 * coding.c: Likewise.
958 * composite.c: Likewise.
959 * dired.c: Likewise.
960 * dispnew.c: Likewise.
961 * doc.c: Likewise.
962 * dosfns.c: Likewise.
963 * editfns.c: Likewise.
964 * emacs.c: Likewise.
965 * fileio.c: Likewise.
966 * filelock.c: Likewise.
967 * font.c: Likewise.
968 * fontset.c: Likewise.
969 * fringe.c: Likewise.
970 * indent.c: Likewise.
971 * insdel.c: Likewise.
972 * intervals.c: Likewise.
973 * keyboard.c: Likewise.
974 * keymap.c: Likewise.
975 * lread.c: Likewise.
976 * macros.c: Likewise.
977 * marker.c: Likewise.
978 * minibuf.c: Likewise.
979 * nsfns.m: Likewise.
980 * nsmenu.m: Likewise.
981 * print.c: Likewise.
982 * process.c: Likewise.
983 * regex.c: Likewise.
984 * region-cache.c: Likewise.
985 * search.c: Likewise.
986 * syntax.c: Likewise.
987 * term.c: Likewise.
988 * textprop.c: Likewise.
989 * undo.c: Likewise.
990 * unexsol.c: Likewise.
991 * w16select.c: Likewise.
992 * w32fns.c: Likewise.
993 * w32menu.c: Likewise.
994 * window.c: Likewise.
995 * xdisp.c: Likewise.
996 * xfns.c: Likewise.
997 * xmenu.c: Likewise.
998 * xml.c: Likewise.
999 * xselect.c: Likewise.
1000
2f07e6af
EZ
10012012-06-16 Eli Zaretskii <eliz@gnu.org>
1002
1053a871
SM
1003 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1004 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1005 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1006 row.
1007 (handle_face_prop): Use chunk-relative overlay string index when
1008 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1009 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1010 the rightmost. (Bug#11720)
2f07e6af 1011
29b83cec
AS
10122012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1013
1014 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1015 (CATEGORY_MEMBER): Enforce 1/0 value.
1016 * category.c (_temp_category_set): Remove.
1017
4c5501e9
EZ
10182012-06-16 Eli Zaretskii <eliz@gnu.org>
1019
1020 * window.c (Fdelete_other_windows_internal)
1021 (Fdelete_window_internal): Don't access frame's mouse highlight
1022 info of the initial frame. (Bug#11677)
1023
2b570124
PE
10242012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1025
e93864f9
PE
1026 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1027 Assume USE_2_TAGS_FOR_INTS.
1028 (xreload): Adjust $tagmask width to match recent lisp.h change.
1029
2b570124
PE
1030 Simplify lisp.h in minor ways that should not affect code.
1031 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1032 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1033 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1034 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1035 (INTTYPEBITS): New macro, for clarity.
1036 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1037 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1038 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1039 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1040 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1041
81755f69
JB
10422012-06-13 Juanma Barranquero <lekktu@gmail.com>
1043
1044 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1045
16192a57
GM
10462012-06-13 Glenn Morris <rgm@gnu.org>
1047
1048 * s/bsd-common.h (BSD4_3):
1049 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1050
646b5f55
AS
10512012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1054 instead of union.
1055 (XLI, XIL): Define.
1053a871
SM
1056 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1057 Use them.
1058 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1059 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1060 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1061 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1062 * frame.c (delete_frame): Remove outdated comment.
1063 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1064 USE_LISP_UNION_TYPE.
1065 (Fw32_unregister_hot_key): Likewise.
1066 (Fw32_toggle_lock_key): Likewise.
1067 * w32menu.c (add_menu_item): Likewise.
1068 (w32_menu_display_help): Use XIL instead of checking
1069 USE_LISP_UNION_TYPE.
1070 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1071 (init_heap): Likewise.
1072 * w32term.c (w32_read_socket): Update comment.
1073
1d3823c9
GM
10742012-06-13 Glenn Morris <rgm@gnu.org>
1075
c62ff706
GM
1076 * s/usg5-4-common.h, src/s/unixware.h:
1077 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1078
1d3823c9
GM
1079 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1080
bfe3e0a2
PE
10812012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1084 * alloc.c (make_number) [!defined make_number]:
1085 Remove, as lisp.h always defines this now.
1086 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1087 (roundup_size): Verify that it is a power of 2.
1088 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1089 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1090 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1091 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1092 USE_LSB_TAG now is always defined to be either 0 or 1.
1093 All uses changed.
1094 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1095 code works fine either way, and efficiency is not a concern here,
1096 as the union type is for debugging, not for production.
1097 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1098 Use an inline function on all platforms when using the union type,
1099 since this is simpler and 'static inline' can be used portably
1100 within Emacs now.
1101 (LISP_INITIALLY_ZERO): New macro.
1102 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1103 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1104
45fa9c0f
GM
11052012-06-12 Glenn Morris <rgm@gnu.org>
1106
b4492cba
GM
1107 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1108
1109 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1110
45fa9c0f
GM
1111 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1112 Move BROKEN_SIGIO to configure.
1113
1114 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1115 Move NO_TERMIO to configure.
1116
0e25d334
CY
11172012-06-12 Chong Yidong <cyd@gnu.org>
1118
1119 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1120 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1121 MagickExportImagePixels is undefined.
1122
43682bb6
PE
11232012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1124
1125 * image.c (imagemagick_load_image): Remove unused label.
1126
a9be7d2b
GM
11272012-06-11 Glenn Morris <rgm@gnu.org>
1128
1129 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1130 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1131 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1132 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1133
3017f87f
SM
11342012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1135
1136 * alloc.c (make_byte_code): New function.
1137 (Fmake_byte_code): Use it. Don't purify here.
1138 * lread.c (read1): Use it as well to avoid extra allocation.
1139
1b9b4cf4
CY
11402012-06-11 Chong Yidong <cyd@gnu.org>
1141
1142 * image.c (imagemagick_load_image): Implement transparency.
1143
95988fcf
AS
11442012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1145
1146 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1147 account for preceding backslashes. (Bug#11663)
1148
cd4eb164
CY
11492012-06-09 Chong Yidong <cyd@gnu.org>
1150
1151 * term.c: Support italics in capable terminals (Bug#9652).
1152 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1153 (turn_on_face): Output using TS_enter_italic_mode if available.
1154 Don't handle unused blinking and alt-charset cases.
1155 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1156 and tty_alt_charset_p cases.
1157 (tty_capable_p, init_tty): Support italics.
1158
1159 * termchar.h (struct tty_display_info): Add field for italics.
1160 Remove unused blink field.
1161
1162 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1163 Handle slant.
1164
1165 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1166 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1167 tty_alt_charset_p. Add tty_italic_p.
1168
ff88beb8
MA
11692012-06-09 Michael Albinus <michael.albinus@gmx.de>
1170
1171 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1172 dbus_type_is_basic if available.
1173 (xd_extract_signed, xd_extract_unsigned): Rename from
1174 extract_signed and extract_unsigned, respectively. Adapt callers.
1175
44286096
CY
11762012-06-09 Chong Yidong <cyd@gnu.org>
1177
1682701f
CY
1178 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1179
44286096
CY
1180 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1181 case (Bug#9752).
1182
d86feb17
PE
11832012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 * xdisp.c (vmessage): Treat frame message as multibyte.
1186 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1187 would generate the diagnostic "Making \302\247 buffer-local while
1188 let-bound!".
1189
d5c20fe8
EZ
11902012-06-08 Eli Zaretskii <eliz@gnu.org>
1191
1192 * dispnew.c (showing_window_margins_p): Undo last change, which
1193 was done due to an inadvertent commit.
1194 (adjust_frame_glyphs_for_frame_redisplay): Do call
1195 showing_window_margins_p.
1196
513749ee
SM
11972012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1198
1199 * eval.c (Fmake_var_non_special): New primitive.
1200 (syms_of_eval): Defsubr it.
1201 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1202
d4a8f5c1
JB
12032012-06-08 Juanma Barranquero <lekktu@gmail.com>
1204
1205 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1206 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1207
8bbbc977
EZ
12082012-06-08 Eli Zaretskii <eliz@gnu.org>
1209
1210 * alloc.c (allocate_vectorlike): Fix last change.
1211
f3372c87
DA
12122012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1213
1214 Block-based vector allocation of small vectors.
1215 * lisp.h (struct vectorlike_header): New field `nbytes',
1216 adjust comment accordingly.
1217 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1218 to denote vector blocks. Adjust users (live_vector_p,
1219 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1220 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1221 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1222 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1223 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1224 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1225 (roundup_size): New constant.
1226 (struct vector_block): New data type.
1227 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1228 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1229 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1230 (sweep_vectors): New functions.
1231 (allocate_vectorlike): Return `zero_vector' as the only vector of
1232 0 items. Allocate new vector from block if vector size is less than
1233 or equal to VBLOCK_BYTES_MAX.
1234 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1235 (init_alloc_once): Add call to init_vectors.
1236
4f18a4ed
SM
12372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1238
1239 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1240
86f158bc
PE
12412012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * doprnt.c (doprnt): Truncate multibyte char correctly.
1244 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1245 would mishandle a string argument "Xc" if X was a multibyte
1246 character of length 2: it would truncate after X's first byte
1247 rather than including all of X.
1248
c5cfcbe0
CY
12492012-06-06 Chong Yidong <cyd@gnu.org>
1250
1251 * buffer.c (word_wrap): Doc fix.
1252
c05cf390
PE
12532012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1254
1255 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1256
0c3461de
GM
12572012-06-03 Glenn Morris <rgm@gnu.org>
1258
1259 * xdisp.c (tool-bar-style): Doc fix.
1260
c71232db
UM
12612012-06-03 Ulrich Müller <ulm@gentoo.org>
1262
1263 * Makefile.in (PAXCTL): Define.
1264 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1265 binary via PaX flags if the paxctl utility is available.
1266 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1267 Restore PaX flags to their default. (Bug#11398)
1268
383f7350
CY
12692012-06-03 Chong Yidong <cyd@gnu.org>
1270
1271 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1272 buffer (Bug#11226).
1273
5f2c76c6
CY
12742012-06-03 Chong Yidong <cyd@gnu.org>
1275
1276 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1277 (note_mode_line_or_margin_highlight): If there is no help echo,
1278 use mode-line-default-help-echo. Handle the case where the mouse
1279 position is past the end of the mode line string.
1280
1281 * buffer.c (buffer_local_value_1): New function, split from
1282 Fbuffer_local_value; can return Qunbound.
1283 (Fbuffer_local_value): Use it.
1284 (Vmode_line_format): Docstring tweaks.
1285
773d47f6
PE
12862012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1287
1288 * sysdep.c (system_process_attributes): Improve comment.
1289
f2d6a3df
SM
12902012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1291
1292 * keyboard.c: Export real-this-command to Elisp.
1293 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1294 and DEFVAR it. Update all users.
1295
63810350
PE
12962012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1297
7bd5c1f4
PE
1298 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1299
63810350
PE
1300 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1301 Convert pctcpu and pctmem to Lisp float properly.
1302 Let the compiler fold better, as 100.0/0x8000 is exact.
1303
a2821611
AS
13042012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1305
1306 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1307 cons_block.
1308
5fceba1d
PE
13092012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1312
c98ff5dd
DA
13132012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1314
1315 For a 'struct window', replace some Lisp_Object fields to
1316 bitfields where appropriate, remove unused fields.
1317 * window.h (struct window): Remove unused 'last_mark_x' and
1318 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1319 change it's type from Lisp_Object to bitfield.
1320 Change type of 'force_start', 'optional_new_start',
1321 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1322 fields from Lisp_Object to bitfield. Adjust users accordingly.
1323
ca34e0be
PE
13242012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1325
1326 Pacify gcc -Wdouble-precision when using Xaw.
1327 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1328 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1329 Use 'float' consistently, rather than 'float' in most places
1330 and 'double' in a couple of places.
1331
efc00ab1 13322012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1333
1334 * xdisp.c (handle_stop): Detect whether we have overlay strings
1335 loaded by testing it->current.overlay_string_index to be
1336 non-negative, instead of checking whether n_overlay_strings is
1337 positive. (Bug#11587)
1338
efc00ab1 13392012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1340
1341 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1342
1343 * doc.c (Fsubstitute_command_keys): Doc fix.
1344
efc00ab1 13452012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1346
1347 * search.c (search_buffer): Remove calls to
1348 r_alloc_inhibit_buffer_relocation, as it is now called by
1349 maybe_unify_char, which was the cause of relocation of buffer text
1350 in bug#11519.
1351
efc00ab1 13522012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1353
1354 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1355 for the duration of call to load_charset, to avoid problems with
1356 callers of maybe_unify_char that access buffer text through C
1357 pointers.
1358
1359 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1360 decrement the inhibition flag, instead of just setting or
1361 resetting it.
1362
ba93a187
PE
13632012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 Remove obsolete '#define static' cruft.
1366 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1367 This #undef was "temporary" in 2000; it is no longer needed
1368 now that '#define static' has gone away.
1369 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1370 (gray_bitmap_bits): Remove; no longer needed.
1371 All uses replaced with definiens.
1372 * xterm.c: Include "bitmaps/gray.xbm".
1373
9e4bf381
PE
13742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1375
1376 Clean up __executable_start, monstartup when --enable-profiling.
1377 The following changes affect the code only when profiling.
1378 * dispnew.c (__executable_start): Rename from safe_bcopy.
1379 Define only on platforms that need it.
1380 * emacs.c: Include <sys/gmon.h> when profiling.
1381 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1382 (__executable_start): Remove decl, since lisp.h does it now.
1383 (safe_bcopy): Remove decl; no longer has that name.
1384 (main): Coalesce #if into single bit of code, for simplicity.
1385 Cast pointers to uintptr_t, since standard libraries want integers
1386 and not pointers.
1387 * lisp.h (__executable_start): New decl.
1388
32d72c2f
GM
13892012-05-31 Glenn Morris <rgm@gnu.org>
1390
1391 * image.c (Fimagemagick_types): Doc fix.
1392
baac5bc7
JM
13932012-05-30 Jim Meyering <meyering@redhat.com>
1394
1395 * callproc.c (Fcall_process_region): Include directory component
1396 in mkstemp error message (Bug#11586).
1397
72cb32cf
PE
13982012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1399
1400 * alloc.c, lisp.h (make_pure_vector): Now static.
1401
61b108cc
SM
14022012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1403
1404 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1405 Move to byte-run.el.
1406 (Fautoload): Do the hash-doc more carefully.
1407 * data.c (Fdefalias): Purify definition, except for keymaps.
1408 (Qdefun): Move from eval.c.
1409 * lisp.h (Qdefun): Remove.
1410 * lread.c (read1): Tiny simplification.
1411
471fe23d
TN
14122012-05-29 Troels Nielsen <bn.troels@gmail.com>
1413
934f3f58 1414 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1415 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1416 Bug#9642, but explicitly check that the buffer the overlay would
1417 be moved to is live and rearrange lines to make sure that errors
1418 will not put the overlay in an inconsistent state.
1419 (Fdelete_overlay): Cosmetics.
1420
85d0efd1
EZ
14212012-05-28 Eli Zaretskii <eliz@gnu.org>
1422
1423 * w32term.c (my_bring_window_to_top): New function.
1424 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1425 could be different from the original one.
1426 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1427 (Bug#11513)
1428
1429 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1430 by calling BringWindowToTop.
1431
1432 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1433 (WM_EMACS_END): Increase by one.
1434
da92a98c
PE
14352012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1438 This avoids undefined behavior that might cause the eassert
1439 to not catch an out-of-range value.
1440
74d1f848
JB
14412012-05-28 Juanma Barranquero <lekktu@gmail.com>
1442
1443 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1444 Update dependencies.
1445
9e1a06fc
EZ
14462012-05-27 Eli Zaretskii <eliz@gnu.org>
1447
1448 * bidi.c (bidi_mirror_char): Fix last change.
1449
f3dd7312
AS
14502012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1451
1452 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1453 when referring to sectname field in printf format.
1454
81899c91
PE
14552012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1456
57b81a9f
PE
1457 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1458 Only r_alloc_inhibit_buffer_relocation needed to be added;
1459 the others were already declared.
1460
81899c91
PE
1461 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1462 before checking whether it's out of range. Put the check inside
1463 eassert. See
1464 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1465
33017faf 14662012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1467
1468 * callproc.c (Fcall_process): Restore a line that was accidentally
1469 commented out in the 2011-02-13 change (bug#11547).
1470
33017faf 14712012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1472
1473 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1474 defined on ralloc.c.
1475
1476 * buffer.c [REL_ALLOC]: Remove prototypes of
1477 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1478 they are now on lisp.h.
1479
1480 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1481
1482 * search.c (search_buffer): Use it to inhibit relocation of buffer
1483 text while re_search_2 is doing its job, because re_search_2 is
1484 passed C pointers to buffer text. (Bug#11519)
1485
23415acf
EZ
1486 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1487 Update value to 24.
1488
44e27368
EZ
1489 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1490 state after an additional call to move_it_in_display_line_to, keep
1491 the values of it->max_ascent and it->max_descent found for the
1492 entire line.
1493 (pos_visible_p): Revert the comparison against bottom_y to what it
1494 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1495 (Bug#11464)
1496
c1892f11
PE
14972012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 Fix coding-related core dumps with gcc -ftrapv.
1500 The code was computing A - B, where A and B are pointers, and B is
1501 random garbage. This can lead to core dumps on platforms that
1502 have special pointer registers, and it also leads to core dumps on
1503 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1504 A - B only when B is initialized properly.
1505 * coding.c (coding_set_source, coding_set_destination): Return void.
1506 (coding_change_source, coding_change_destinations): New functions,
1507 with the old behaviors of coding_set_source and coding_set_destination.
1508 All callers that need an offset changed to use these new functions.
1509
eb7afdad
GM
15102012-05-26 Glenn Morris <rgm@gnu.org>
1511
1512 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1513
f12fdf02
EZ
15142012-05-26 Eli Zaretskii <eliz@gnu.org>
1515
53a63be6 1516 Extend mouse support on W32 text-mode console.
61b108cc
SM
1517 * xdisp.c (draw_row_with_mouse_face):
1518 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1519
eb3f6f01 1520 * w32console.c: Include window.h.
61b108cc
SM
1521 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1522 New functions.
eb3f6f01
EZ
1523 (initialize_w32_display): Initialize mouse-highlight data.
1524
53a63be6
EZ
1525 * w32inevt.c: Include termchar.h and window.h.
1526 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1527 moves, call note_mouse_highlight. If help_echo changed, call
1528 gen_help_event to produce help-echo message in the echo area.
1529 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1530 highlight info.
1531
4cfd81f6
PE
15322012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1533
1534 * lread.c (read1): Simplify slightly to avoid an overflow warning
1535 with GCC 4.7.0 on x86-64.
1536
4446092a
EZ
15372012-05-26 Eli Zaretskii <eliz@gnu.org>
1538
1539 * bidi.c (bidi_mirror_char): Revert last change: an int is
1540 definitely wide enough here.
1541
42b2a986 15422012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1543
42b2a986 1544 Fix integer width and related bugs (Bug#9874).
eb106a49 1545 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1546 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1547 (string_bytes, check_sblock, allocate_string_data):
1548 (compact_small_strings, Fmake_bool_vector, make_string)
1549 (make_unibyte_string, make_multibyte_string)
1550 (make_string_from_bytes, make_specified_string)
1551 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1552 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1553 (mark_vectorlike):
1554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1555 (allocate_pseudovector):
1556 Use int, not EMACS_INT, where int is wide enough.
1557 (inhibit_garbage_collection, Fgarbage_collect):
1558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1559 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1560 int might not be wide enough.
1561 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1562 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1563 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1564 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1565 (bidi_level_of_next_char, bidi_move_to_visually_next):
1566 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1567 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1568 (Fkill_buffer, Fset_buffer_major_mode)
1569 (advance_to_char_boundary, Fbuffer_swap_text)
1570 (Fset_buffer_multibyte, overlays_at, overlays_in)
1571 (overlay_touches_p, struct sortvec, record_overlay_string)
1572 (overlay_strings, recenter_overlay_lists)
1573 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1574 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1575 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1576 (Foverlay_recenter, last_overlay_modification_hooks_used)
1577 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1579 (validate_region): Omit unnecessary test for b <= e,
1580 since that's guaranteed by the previous test.
d311d28c
PE
1581 (adjust_overlays_for_delete): Avoid pos + length overflow.
1582 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1583 (report_overlay_modification):
1584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1585 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1586 Omit pointer cast, which isn't needed anyway, and doesn't work
1587 after the EMACS_INT -> ptrdiff_t change.
02481186 1588 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1589 * buffer.h: Adjust decls to match defn changes elsewhere.
1590 (struct buffer_text, struct buffer):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1592 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1593 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1594 not int, to avoid needless 32-bit limit on 64-bit hosts.
1595 (exec_byte_code): Use tighter memory-full test, one that checks
1596 for alloca overflow. Don't compute the address of the object just
1597 before an array, as that's not portable. Use EMACS_INT, not
1598 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1599 * callint.c (Fcall_interactively):
1600 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1601 * callproc.c (call_process_kill, Fcall_process):
1602 Don't assume pid_t fits into an Emacs fixnum.
1603 (call_process_cleanup, Fcall_process, child_setup):
1604 Don't assume pid_t fits into int.
1605 (call_process_cleanup, Fcall_process, delete_temp_file)
1606 (Fcall_process_region):
1607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1608 (Fcall_process): Simplify handling of volatile integers.
1609 Use int, not EMACS_INT, where int will do.
1610 * casefiddle.c (casify_object, casify_region, operate_on_word)
1611 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1613 (casify_object): Avoid integer overflow when overallocating buffer.
1614 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1615 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1616 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1617 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1618 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1619 integers are now checked earlier. All uses replaced with XINT.
1620 (ccl_driver):
1621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1622 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1623 (ccl_driver, Fregister_code_conversion_map):
1624 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1625 (resolve_symbol_ccl_program): Check that vector header is in range.
1626 Always copy the vector, so that we can check its contents reliably
1627 now rather than having to recheck each instruction as it's being
1628 executed. Check that vector words fit in 'int'.
1629 (ccl_get_compiled_code, Fregister_ccl_program)
1630 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1631 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1632 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1633 contents are in range.
1634 (Fccl_execute_on_string): Check that status is in range.
1635 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1636 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1637 Accept and return EMACS_INT, not int, because callers can pass values
1638 out of 'int' range.
1639 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1640 (multibyte_chars_in_text, parse_str_as_multibyte)
1641 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1642 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1643 (string_escape_byte8, Fget_byte):
1644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1645 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1646 avoid mishandling large integers.
1647 * character.h: Adjust decls to match defn changes elsewhere.
1648 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1649 (Ffind_charset_region):
1650 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1651 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1652 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1653 Don't assume fixnum fits in int.
d311d28c
PE
1654 (load_charset_map_from_vector, Fmap_charset_chars):
1655 Remove now-unnecessary CHECK_NATNUMs.
1656 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1657 Don't rely on undefined behavior with signed left shift overflow.
1658 Don't assume unsigned int fits into fixnum, or that fixnum fits
1659 into unsigned int. Don't require max_code to be a valid fixnum;
1660 that's not true for gb10830 4-byte on a 32-bit host. Allow
1661 invalid_code to be a cons, for the same reason. Require code_offset
1662 to be a character. Avoid int overflow if max_char is close
1663 to INT_MAX.
1664 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1665 this is intended anyway and avoids some undefined behavior.
1666 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1667 INDEX_TO_CODE_POINT, as that's what it expects.
1668 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1669 * charset.h (DECODE_CHAR): Return int, not unsigned;
1670 this is what was intended anyway, and it avoids undefined behavior.
1671 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1672 integer-overflow issues.
1673 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1674 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1675 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1676 * chartab.c (Fmake_char_table, Fset_char_table_range)
1677 (uniprop_get_decoder, uniprop_get_encoder):
1678 Don't assume fixnum fits in int.
1679 * cmds.c (move_point): New function, that does the gist of
1680 Fforward_char and Fbackward_char, but does so while checking
1681 for integer overflow more accurately.
c96e5d6a 1682 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1683 (Fforward_line, Fend_of_line, internal_self_insert)
1684 (internal_self_insert):
1685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1686 Fix a FIXME, by checking for integer overflow when calculating
1687 target_clm and actual_clm.
1688 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1689 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1690 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1691 (coding_alloc_by_making_gap, alloc_destination)
1692 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1693 (encode_coding_utf_16, detect_coding_emacs_mule)
1694 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1695 (detect_coding_iso_2022, decode_coding_iso_2022)
1696 (encode_invocation_designation, encode_designation_at_bol)
1697 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1698 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1699 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1700 (encode_coding_ccl, encode_coding_raw_text)
1701 (detect_coding_charset, decode_coding_charset)
1702 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1703 (produce_composition, produce_charset, produce_annotation)
1704 (decode_coding, handle_composition_annotation)
1705 (handle_charset_annotation, consume_chars, decode_coding_gap)
1706 (decode_coding_object, encode_coding_object, detect_coding_system)
1707 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1708 (code_convert_region, code_convert_string)
8f50130c
PE
1709 (Fdefine_coding_system_internal)
1710 (coding_set_source, coding_set_destination):
d311d28c
PE
1711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1712 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1713 (Fdefine_coding_system_internal):
1714 Don't assume fixnums fit in int.
1715 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1716 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1717 (Funencodable_char_position, Fcheck_coding_systems_region)
1718 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1719 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1720 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1721 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1722 Don't access memory outside of the args array.
d311d28c 1723 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1724 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1725 result of ENCODE_CHAR.
d311d28c
PE
1726 * coding.h: Adjust decls to match defn changes elsewhere.
1727 (struct coding_system):
1728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1729 * composite.c (get_composition_id, find_composition)
1730 (run_composition_function, update_compositions)
1731 (compose_text, composition_gstring_put_cache)
1732 (composition_gstring_p, composition_gstring_width)
1733 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1734 (composition_compute_stop_pos, composition_reseat_it)
1735 (composition_update_it, struct position_record)
1736 (find_automatic_composition, composition_adjust_point)
1737 (Fcomposition_get_gstring, Ffind_composition_internal):
1738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1739 (update_compositions):
1740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1741 * composite.h: Adjust decls to match defn changes elsewhere.
1742 (struct composition):
1743 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1744 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1745 Do not attempt to compute the address of the object just before a
1746 buffer; this is not portable.
1747 (Faref, Faset):
1748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1749 (Faset): Use int, not EMACS_INT, where int is wide enough.
1750 (Fstring_to_number): Don't assume fixnums fit in int.
1751 (Frem): Don't assume arg is nonnegative.
1752 * dbusbind.c (xd_append_arg): Check for integers out of range.
1753 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1754 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1755 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1756 (xd_get_connection_references): Return ptrdiff_t, not int.
1757 All uses changed.
1758 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1759 (xd_read_message_1):
1760 Use int, not unsigned, where the dbus API uses int.
1761 (Fdbus_message_internal): Don't overflow mtype.
1762 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1763 * dired.c (directory_files_internal, file_name_completion, scmp)
1764 (file_name_completion_stat):
1765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1766 (file_name_completion): Don't overflow matchcount.
1767 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1768 * dispextern.h: Adjust decls to match defn changes elsewhere.
1769 (struct text_pos, struct glyph, struct bidi_saved_info)
1770 (struct bidi_string_data, struct bidi_it, struct composition_it)
1771 (struct it):
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1773 (struct display_pos, struct composition_it, struct it):
1774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1775 * dispnew.c (increment_matrix_positions)
1776 (increment_row_positions, mode_line_string)
1777 (marginal_area_string):
1778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1779 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1781 (duration_to_sec_usec): New function, to check for overflow better.
1782 (Fsleep_for, sit_for): Use it.
1783 * doc.c (get_doc_string, store_function_docstring):
1784 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1785 (get_doc_string, Fsnarf_documentation):
1786 Use int, not EMACS_INT, where int is wide enough.
1787 (get_doc_string):
1788 Use SAFE_ALLOCA, not alloca.
1789 Check for overflow when converting EMACS_INT to off_t.
1790 * doprnt.c (doprnt):
1791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1792 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1793 Don't assume uid_t fits into fixnum.
1794 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1795 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1796 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1797 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1798 (general_insert_function)
1799 (Finsert_char, make_buffer_string, make_buffer_string_both)
1800 (update_buffer_properties, Fbuffer_substring)
1801 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1802 (Fsubst_char_in_region, check_translation)
1803 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1804 (transpose_markers, Ftranspose_regions):
1805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1806 (clip_to_bounds): Move to lisp.h as an inline function).
1807 (Fconstrain_to_field): Don't assume integers are nonnegative.
1808 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1809 (Fsubst_char_in_region, Fsave_restriction):
1810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1811 (Femacs_pid): Don't assume pid_t fits into fixnum.
1812 (lo_time): Use int, not EMACS_INT, when int suffices.
1813 (lisp_time_argument): Check for usec out of range.
1814 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1815 (Fuser_login_name, Fuser_full_name): Signal an error
1816 if a uid argument is out of range, rather than relying on
1817 undefined behavior.
c8d5c857
PE
1818 (Fformat_time_string): Remove now-unnecessary check.
1819 lisp_time_argument checks for out-of-range usec now.
243e0530 1820 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1821 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1822 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1823 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1824 (init_cmdargs, Fdump_emacs):
1825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1826 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1827 the bottom (typically) 32 bits of the fixnum.
1828 * eval.c (specpdl_size, call_debugger):
1829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1830 (when_entered_debugger, Fbacktrace_debug):
1831 Don't assume fixnum can fit in int.
1832 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1833 the object just before a buffer; this is not portable.
1834 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1835 (grow_specpdl, unbind_to):
1836 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1837 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1838 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1839 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1840 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1841 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1843 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1844 (a_write, e_write):
1845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1846 (Fcopy_file, non_regular_nbytes, read_non_regular)
1847 (Finsert_file_contents):
1848 Use int, not EMACS_INT, where int is wide enough.
1849 (READ_BUF_SIZE): Verify that it fits in int.
1850 (Finsert_file_contents): Check that counts are in proper range,
1851 rather than assuming fixnums fit into ptrdiff_t etc.
1852 Don't assume fixnums fit into int.
125b3835 1853 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1854 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1855 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1856 (string_char_to_byte, string_byte_to_char)
1857 (string_make_multibyte, string_to_multibyte)
1858 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1859 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1860 (substring_both, Fdelete, internal_equal, Ffillarray)
1861 (Fclear_string, mapcar1)
1862 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1863 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1864 (larger_vector, make_hash_table, maybe_resize_hash_table)
1865 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1866 (Fmaphash, secure_hash):
1867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1868 (concat): Check for string index and length overflow.
1869 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1870 (Frequire):
1871 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1872 (larger_vector): New API (vec, incr_min, size_max) replaces old
1873 one (vec, new_size, init). This catches size overflow.
1874 INIT was removed because it was always Qnil.
1875 All callers changed.
1876 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1877 the upper bound on a hash table index size.
1878 (make_hash_table, maybe_resize_hash_table): Use it.
1879 (secure_hash): Computer start_byte and end_byte only after
1880 they're known to be in ptrdiff_t range.
1881 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1882 (Ffont_get_glyphs, Ffont_at):
1883 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1884 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1885 (Flist_fonts, Fopen_font):
1886 Don't assume fixnum can fit in int.
1887 (check_gstring): Don't assume index can fit in int.
1888 (font_match_p): Check that fixnum is a character, not a nonnegative
1889 fixnum, since the later code needs to stuff it into an int.
1890 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1891 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1892 conversion overflow issues.
1893 (Fopen_font): Check for integer out of range.
1894 (Ffont_get_glyphs): Don't assume index can fit in int.
1895 * font.h: Adjust decls to match defn changes elsewhere.
1896 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1897 integer overflow.
1898 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1899 printmax_t, where ptrdiff_t is wide enough.
1900 (Finternal_char_font):
1901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1902 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1903 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1904 (Fset_frame_position, x_set_frame_parameters)
1905 (x_set_line_spacing, x_set_border_width)
1906 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1907 Check that fixnums are in proper range for system types.
1908 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1910 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1911 Use SAFE_ALLOCA_LISP, not alloca.
1912 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1913 intptr_t is wide enough.
1914 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1915 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1916 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1917 Check for fixnum out of range.
1918 * ftfont.c (ftfont_list): Don't assume index fits in int.
1919 Check that fixnums are in proper range for system types.
1920 (ftfont_shape_by_flt):
1921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1922 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1924 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1925 Check that fixnums are in proper range for system types.
1926 * gnutls.h: Adjust decls to match defn changes elsewhere.
1927 * gtkutil.c (xg_dialog_run):
1928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1929 (update_frame_tool_bar):
1930 Check that fixnums are in proper range for system types.
1931 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1932 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1933 * indent.c (last_known_column, last_known_column_point):
1934 (current_column_bol_cache):
1935 (skip_invisible, current_column, check_display_width):
1936 (check_display_width, scan_for_column, current_column_1)
1937 (Findent_to, Fcurrent_indentation, position_indentation)
1938 (indented_beyond_p, Fmove_to_column, compute_motion):
1939 (Fcompute_motion, Fvertical_motion):
1940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1941 (last_known_column_modified): Use EMACS_INT, not int.
1942 (check_display_width):
1943 (Fcompute_motion):
1944 Check that fixnums and floats are in proper range for system types.
1945 (compute_motion): Don't assume index or fixnum fits in int.
1946 (compute_motion, Fcompute_motion):
1947 Use int, not EMACS_INT, when it is wide enough.
1948 (vmotion): Omit local var start_hpos that is always 0; that way
1949 we don't need to worry about overflow in expressions involving it.
1950 * indent.h: Adjust decls to match defn changes elsewhere.
1951 (struct position):
1952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1953 Use int, not EMACS_INT, where int is wide enough.
1954 Remove unused members ovstring_chars_done and tab_offset;
1955 all uses removed.
1956 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1957 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1958 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1959 (make_gap, copy_text, insert, insert_and_inherit)
1960 (insert_before_markers, insert_before_markers_and_inherit)
1961 (insert_1, count_combining_before, count_combining_after)
1962 (insert_1_both, insert_from_string)
1963 (insert_from_string_before_markers, insert_from_string_1)
1964 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1965 (adjust_after_replace, adjust_after_insert, replace_range)
1966 (replace_range_2, del_range, del_range_1, del_range_byte)
1967 (del_range_both, del_range_2, modify_region)
1968 (prepare_to_modify_buffer, signal_before_change)
1969 (signal_after_change, Fcombine_after_change_execute):
1970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1971 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1972 (balance_an_interval, split_interval_right, split_interval_left)
1973 (find_interval, next_interval, update_interval)
1974 (adjust_intervals_for_insertion, delete_node, delete_interval)
1975 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1976 (static_offset_intervals, offset_intervals)
1977 (merge_interval_right, merge_interval_left, make_new_interval)
1978 (graft_intervals_into_buffer, temp_set_point_both)
1979 (temp_set_point, set_point, adjust_for_invis_intang)
1980 (set_point_both, move_if_not_intangible, get_property_and_range)
1981 (get_local_map, copy_intervals, copy_intervals_to_string)
1982 (compare_string_intervals, set_intervals_multibyte_1):
1983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1984 * intervals.h: Adjust decls to match defn changes elsewhere.
1985 (struct interval):
1986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1987 * keyboard.c (this_command_key_count, this_single_command_key_start)
1988 (before_command_key_count, before_command_echo_length, echo_now)
1989 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1990 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1991 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1992 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1993 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1994 (last_non_minibuf_size, last_point_position, echo_truncate)
1995 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1996 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1997 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1998 (stuff_buffered_input):
1999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2000 (last_auto_save, command_loop_1, read_char):
2001 Use EMACS_INT, not int, to avoid integer overflow.
2002 (record_char): Avoid overflow in total_keys computation.
2003 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2004 * keyboard.h: Adjust decls to match defn changes elsewhere.
2005 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2006 (Fkey_description, Fdescribe_vector, Flookup_key):
2007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2008 (click_position): New function, to check that positions are in range.
2009 (Fcurrent_active_maps):
2010 (describe_command):
2011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2012 (Faccessible_keymaps, Fkey_description):
2013 (preferred_sequence_p):
2014 Don't assume fixnum can fit into int.
2015 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2016 Check for integer overflow in size calculations.
2017 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2018 avoid mishandling large integers.
2019 * lisp.h: Adjust decls to match defn changes elsewhere.
2020 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2021 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2022 (struct Lisp_Marker):
2023 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2024 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2025 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2026 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2027 All callers changed.
2028 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2029 Assume the arg has valid form, since it always does.
2030 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2031 unsigned integer system type.
2032 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2033 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2036 (duration_to_sec_usec): New decl.
2037 * lread.c (read_from_string_index, read_from_string_index_byte)
2038 (read_from_string_limit, readchar, unreadchar, openp)
2039 (read_internal_start, read1, oblookup):
2040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2041 (Fload, readevalloop, Feval_buffer, Feval_region):
2042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2043 (openp): Check for out-of-range argument to 'access'.
2044 (read1): Use int, not EMACS_INT, where int is wide enough.
2045 Don't assume fixnum fits into int.
6efdadfd 2046 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2047 (read_filtered_event): Use duration_to_sec_usec
2048 to do proper overflow checking on durations.
d311d28c
PE
2049 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2050 in size calculation.
2051 (Fexecute_kbd_macro):
2052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2053 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2054 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2055 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2056 (set_marker_both, set_marker_restricted_both, marker_position)
2057 (marker_byte_position, Fbuffer_has_markers_at):
2058 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2059 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2060 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2061 It now merely ensures that the menu is large enough, without
2062 necessarily growing it, as this avoids some integer overflow issues.
2063 All callers changed.
2064 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2065 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2067 Use SAFE_ALLOCA_LISP, not alloca.
2068 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2069 to EMACS_INT. Check that fixnums are in proper range for system types.
2070 * minibuf.c (minibuf_prompt_width, string_to_object)
2071 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2072 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2074 (get_minibuffer, read_minibuf_unwind):
2075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2076 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2077 this simplifies overflow checking. All callers changed.
2078 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2079 (Ftest_completion):
2080 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2081 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2082 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2083 Check that fixnums are in proper range for system types.
2084 (Fx_create_frame, Fx_show_tip):
2085 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2086 * nsfont.m (ns_findfonts, nsfont_list_family):
2087 Don't assume fixnum fits in long.
2088 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2090 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2091 wide enough.
17fdb222 2092 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2094 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2095 (PRINTDECLARE, PRINTPREPARE):
2096 (strout, print_string):
2097 (print, print_preprocess, print_check_string_charset_prop)
2098 (print_object):
2099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2100 (PRINTDECLARE):
2101 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2102 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2103 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2104 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2105 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2106 (print_error_message): Use SAFE_ALLOCA, not alloca.
2107 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2108 (print_depth, new_backquote_output, print_number_index):
2109 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2110 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2111 (Fset_process_window_size, Fformat_network_address)
2112 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2113 (sigchld_handler):
d311d28c 2114 Check that fixnums are in proper range for system types.
d44287d4 2115 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2116 Check for process-ids out of pid_t range rather than relying on
2117 undefined behavior.
e4d81efc 2118 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2119 (Fformat_network_address, read_process_output, send_process)
2120 (Fprocess_send_region, status_notify):
2121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2122 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2123 (wait_reading_process_output, read_process_output, exec_sentinel):
2124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2125 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2126 (Faccept_process_output): Use duration_to_sec_usec to do proper
2127 overflow checking on durations.
dde14581
PE
2128 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2129 Don't assume pid_t fits in int.
02481186
PE
2130 * process.h (struct Lisp_Process): Members tick and update_tick
2131 are now of type EMACS_INT, not int.
b62b53e8
PE
2132 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2133 configured --with-wide-int.
d311d28c
PE
2134 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2135 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2136 * search.c (looking_at_1, string_match_1):
2137 (fast_string_match, fast_c_string_match_ignore_case)
2138 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2139 (scan_newline, find_before_next_newline, search_command)
2140 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2141 (set_search_regs, wordify):
2142 (Freplace_match):
2143 (Fmatch_data):
2144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2145 (string_match_1, search_buffer, set_search_regs):
2146 (Fmatch_data):
2147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2148 (wordify): Check for overflow in size calculation.
2149 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2150 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2151 Check that fixnums are in proper range for system types.
2152 * sound.c (struct sound_device)
2153 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2155 (Fplay_sound_internal):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2157 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2158 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2159 (Fparse_partial_sexp):
2160 Don't assume fixnums can fit in int.
2161 (struct lisp_parse_state, find_start_pos, find_start_value)
2162 (find_start_value_byte, find_start_begv)
2163 (update_syntax_table, char_quoted, dec_bytepos)
2164 (find_defun_start, prev_char_comend_first, back_comment):
2165 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2166 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 (Finternal_describe_syntax_value): Check that match_lisp is a
2169 character, not an integer, since the code stuffs it into int.
2170 (scan_words, scan_sexps_forward):
2171 Check that fixnums are in proper range for system types.
2172 (Fforward_word):
2173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2174 (scan_sexps_forward):
2175 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2176 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2177 * syntax.h: Adjust decls to match defn changes elsewhere.
2178 (struct gl_state_s):
2179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2180 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2181 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2182 * sysdep.c (wait_for_termination_1, wait_for_termination)
2183 (interruptible_wait_for_termination, mkdir):
2184 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2185 (emacs_read, emacs_write):
2186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2187 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2188 and double all fit in int.
d311d28c
PE
2189 * term.c (set_tty_color_mode):
2190 Check that fixnums are in proper range for system types.
2191 * termhooks.h (struct input_event):
2192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2193 * textprop.c (validate_interval_range, interval_of)
2194 (Fadd_text_properties, set_text_properties_1)
2195 (Fremove_text_properties, Fremove_list_of_text_properties)
2196 (Ftext_property_any, Ftext_property_not_all)
2197 (copy_text_properties, text_property_list, extend_property_ranges)
2198 (verify_interval_modification):
2199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2200 (Fnext_single_char_property_change)
2201 (Fprevious_single_char_property_change):
2202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2203 (copy_text_properties):
2204 Check for integer overflow in index calculation.
d311d28c
PE
2205 * undo.c (last_boundary_position, record_point, record_insert)
2206 (record_delete, record_marker_adjustment, record_change)
2207 (record_property_change):
2208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2209 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2210 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2211 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2212 (Fx_hide_tip, Fx_file_dialog):
2213 * w32menu.c (set_frame_menubar):
2214 Use ptrdiff_t, not int, for consistency with rest of code.
2215 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2216 (select_window, Fdelete_other_windows_internal)
2217 (window_scroll_pixel_based, window_scroll_line_based)
2218 (Frecenter, Fset_window_configuration):
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 (Fset_window_hscroll, run_window_configuration_change_hook)
2221 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2222 (Fscroll_other_window, Frecenter):
d311d28c
PE
2223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2224 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2225 Don't assume fixnum fits in int.
2226 (Fset_window_scroll_bars):
2227 Check that fixnums are in proper range for system types.
2228 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2229 (string_pos, c_string_pos, number_of_chars, init_iterator)
2230 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2231 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2232 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2233 (face_before_or_after_it_pos, handle_invisible_prop)
2234 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2235 (display_prop_intangible_p, string_buffer_position_lim)
2236 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2237 (get_overlay_strings_1, get_overlay_strings)
2238 (iterate_out_of_display_property, forward_to_next_line_start)
2239 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2240 (get_next_display_element, set_iterator_to_next)
2241 (get_visually_first_element, compute_stop_pos_backwards)
2242 (handle_stop_backwards, next_element_from_buffer)
2243 (move_it_in_display_line_to, move_it_in_display_line)
2244 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2245 (add_to_log, message_dolog, message_log_check_duplicate)
2246 (message2, message2_nolog, message3, message3_nolog
2247 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2248 (current_message_1, truncate_echo_area, truncate_message_1)
2249 (set_message, set_message_1, store_mode_line_noprop)
2250 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2251 (text_outside_line_unchanged_p, check_point_in_composition)
2252 (reconsider_clip_changes)
2253 (redisplay_internal, set_cursor_from_row, try_scrolling)
2254 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2255 (redisplay_window, find_last_unchanged_at_beg_row)
2256 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2257 (trailing_whitespace_p, find_row_edges, display_line)
2258 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2259 (display_mode_element, store_mode_line_string)
2260 (pint2str, pint2hrstr, decode_mode_spec)
2261 (display_count_lines, display_string, draw_glyphs)
2262 (x_produce_glyphs, x_insert_glyphs)
2263 (rows_from_pos_range, mouse_face_from_buffer_pos)
2264 (fast_find_string_pos, mouse_face_from_string_pos)
2265 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2267 (safe_call, init_from_display_pos, handle_fontified_prop)
2268 (handle_single_display_spec, load_overlay_strings)
2269 (with_echo_area_buffer, setup_echo_area_for_printing)
2270 (display_echo_area, echo_area_display)
2271 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2272 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2273 (redisplay_window, dump_glyph_row, display_mode_line)
2274 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2275 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2276 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2277 (handle_single_display_spec, build_desired_tool_bar_string)
2278 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2279 (get_specified_cursor_type):
2280 Check that fixnums are in proper range for system types.
2281 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2282 (Flookup_image_map):
2283 Don't assume fixnums fit in int.
2284 (compare_overlay_entries):
2285 Avoid mishandling comparisons due to subtraction overflow.
2286 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2287 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2288 (handle_tool_bar_click):
2289 Use int, not unsigned, since we prefer signed and the signedness
2290 doesn't matter here.
2291 (get_next_display_element, next_element_from_display_vector):
2292 Use int, not EMACS_INT, when int is wide enough.
2293 (start_hourglass): Use duration_to_sec_usec to do proper
2294 overflow checking on durations.
2295 * xfaces.c (Fbitmap_spec_p):
2296 Check that fixnums are in proper range for system types.
2297 (compare_fonts_by_sort_order):
2298 Avoid mishandling comparisons due to subtraction overflow.
2299 (Fx_family_fonts, realize_basic_faces):
2300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2301 (Fx_family_fonts):
2302 Don't assume fixnum fits in int.
2303 Use SAFE_ALLOCA_LISP, not alloca.
2304 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2305 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2306 (face_at_buffer_position, face_for_overlay_string)
2307 (face_at_string_position):
2308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2309 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2310 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2311 (Fx_show_tip):
2312 Check that fixnums are in proper range for system types.
2313 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2314 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2315 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2316 (Fx_change_window_property): Don't assume fixnums fit in int.
2317 * xfont.c (xfont_chars_supported):
2318 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2319 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2320 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2322 * xml.c (parse_region):
2323 * xrdb.c (magic_file_p):
2324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2325 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2326 (x_get_local_selection, x_reply_selection_request)
2327 (x_handle_selection_request, wait_for_property_change):
2328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2329 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2330 short is wide enough.
2331 (x_send_client_event): Don't assume fixnum fits in int.
2332 * xterm.c (x_x_to_emacs_modifiers):
2333 Don't assume EMACS_INT overflows nicely into int.
2334 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2335 may come from Lisp.
2336 (handle_one_xevent): NATNUMP can eval its arg twice.
2337 (x_connection_closed):
2338 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2339 * xterm.h: Adjust decls to match defn changes elsewhere.
2340 (struct scroll_bar): Use struct vectorlike_header
2341 rather than rolling our own approximation.
2342 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2343
c6574eb5
GM
23442012-05-25 Glenn Morris <rgm@gnu.org>
2345
2346 * lisp.mk (lisp): Update for more files being compiled now.
2347
e8d32c7e
SM
23482012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2349
48def666
SM
2350 * lread.c: Remove `read_pure' which makes no difference.
2351 (read_pure): Remove var.
2352 (unreadpure): Remove function.
2353 (readevalloop): Don't call read_list with -1 flag.
2354 (read1, read_vector): Don't test read_pure any more.
2355 (read_list): Simplify.
2356
e8d32c7e
SM
2357 * fileio.c, character.h: Minor style tweaks.
2358
4b2addb7
DA
23592012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 * window.h (clip_changed): Remove useless declaration.
2362
584461b2
JB
23632012-05-22 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2366 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2367
34374650
PE
23682012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 Remove src/m/*.
2371 This directory predates autoconf and is no longer needed nowadays.
2372 Move its few remaining bits of functionality to where they're needed.
2373 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2374 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2375 * m/template.h: Remove.
2376 * Makefile.in (M_FILE): Remove. All uses removed.
2377 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2378 * lisp.h (USE_LSB_TAG):
2379 * mem-limits.h (EXCEEDS_LISP_PTR):
2380 Use VAL_MAX, not VALBITS, in #if.
2381 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2382 (EMACS_UINT): Define unconditionally now.
2383 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2384 (BITS_PER_EMACS_INT): New constants, replacing
2385 what used to be in config.h, but not useful in #if.
2386 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2387 define them any more.
2388 (VAL_MAX): New macro.
2389 (VALMASK): Use it.
2390 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2391 BITS_PER_EMACS_INT, in #if.
2392 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2393 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2394 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2395 * s/ms-w32.h (DATA_START):
2396 Move here from removed file m/intel386.h.
2397 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2398 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2399
261cb4bb
PE
24002012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2401
2402 Assume C89 or later.
2403 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2404 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2405 (xrealloc):
2406 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2407 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2408 * textprop.c, tparam.c (NULL): Remove.
2409 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2410 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2411 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2412 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2413 * xterm.c (input_signal_count): Assume volatile works.
2414
ff23cd9f
KB
24152012-05-21 Ken Brown <kbrown@cornell.edu>
2416
2417 * xgselect.c (xg_select): Fix first argument in call to 'select'
2418 (bug#11508).
2419
1b170bc6
KB
24202012-05-20 Ken Brown <kbrown@cornell.edu>
2421
2422 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2423 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2424
b2f4d39f
KB
24252012-05-19 Ken Brown <kbrown@cornell.edu>
2426
2427 * xfns.c (x_in_use): Remove `static' qualifier.
2428 * xterm.h (x_in_use): Declare.
2429 * xgselect.c: Include xterm.h.
2430 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2431 and `display_arg' (bug#9754).
2432
003fdae2
PE
24332012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2434
9232a6d9
PE
2435 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2436
003fdae2
PE
2437 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2438 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2439
784b56e2
EZ
24402012-05-18 Eli Zaretskii <eliz@gnu.org>
2441
2442 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2443
2444 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2445 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2446
2447 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2448 reference to image_cache->refcount.
2449 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2450
a0a79cde
JL
24512012-05-17 Juri Linkov <juri@jurta.org>
2452
2453 * search.c (Fword_search_regexp, Fword_search_backward)
2454 (Fword_search_forward, Fword_search_backward_lax)
2455 (Fword_search_forward_lax): Move functions to isearch.el
2456 (bug#10145, bug#11381).
2457
b0572523
PE
24582012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2461
9660f5fc
SM
24622012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2463
2464 * lread.c (init_obarray): Declare Qt and Qnil as special.
2465
4374de83
GM
24662012-05-14 Glenn Morris <rgm@gnu.org>
2467
2468 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2469 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2470
dc44c39a
PE
24712012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2472
078c97cb
PE
2473 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2474
dc44c39a
PE
2475 * unexaix.c: Port to more-recent AIX compilers.
2476 (report_error, report_error_1, make_hdr, copy_sym)
2477 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2478 Make arguments const char *, not char *, to avoid violations of C
2479 standard and to fix some AIX warnings reported by Gilles Pion.
2480
e18afed7 24812012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2482
2483 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2484 already have overlays loaded.
2485 (handle_single_display_spec): Before returning without displaying
2486 fringe bitmap, synchronize the bidi iterator with the main display
2487 iterator, by calling iterate_out_of_display_property.
2488 (iterate_out_of_display_property): Detect buffer iteration by
2489 testing that it->string is a Lisp string.
2490 (get_next_display_element): When the current object is exhausted,
2491 and there's something on it->stack, call set_iterator_to_next to
2492 proceed with what's on the stack, instead of returning zero.
2493 (set_iterator_to_next): If called at the end of a Lisp string,
2494 proceed to consider_string_end without incrementing string
2495 position. Don't increment display vector index past the end of
2496 the display vector. (Bug#11417)
c8fb9dc6
EZ
2497 (pos_visible_p): Don't report a position visible when move_it_to
2498 stopped at the last line of window, which happens to be scanned
2499 backwards by the bidi iteration. (Bug#11464)
ac268e67 2500
e18afed7 25012012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2502
2503 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2504 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2505 are on a TTY, and thus unable to display on the fringes.
2506 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2507 so we need to signal to the caller that this is a "replacing"
2508 display spec. This fixes display when the spec is invalid or we
2509 are on a TTY.
2510
e18afed7 25112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2512
2513 * unexaix.c (make_hdr): Fix typo in prototype.
2514 This bug broke the build on AIX. Problem reported by Gilles Pion.
2515
9d0a235a
MA
25162012-05-14 Michael Albinus <michael.albinus@gmx.de>
2517
2518 * keyboard.c (kbd_buffer_get_event): Read special events also in
2519 batch mode. (Bug#11415)
2520
9e6b06ed
GM
25212012-05-12 Glenn Morris <rgm@gnu.org>
2522
2523 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2524
c1a1d7a3
EZ
25252012-05-12 Eli Zaretskii <eliz@gnu.org>
2526
2527 * lisp.mk (lisp): Add newcomment.elc.
2528
3fe7cdc8
GM
25292012-05-12 Glenn Morris <rgm@gnu.org>
2530
2531 * Makefile.in (MKDIR_P): New, set by configure.
2532 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2533
53f7d2c0
PE
25342012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 Remove unused function hourglass_started.
2537 * dispextern.h (hourglass_started):
2538 * w32fns.c (hourglass_started):
2539 * xdisp.c (hourglass_started): Remove.
2540
75aafb17
JB
25412012-05-10 Juanma Barranquero <lekktu@gmail.com>
2542
2543 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2544 Update dependencies.
2545
12959e8e
PE
25462012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2547
97107e2e
PE
2548 * xgselect.c (xg_select): Put maxfds+1 into a var.
2549 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2550
12959e8e
PE
2551 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2552
836d29b3
DA
25532012-05-10 Dave Abrahams <dave@boostpro.com>
2554
2555 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2556 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2557
5cb67954
MA
25582012-05-09 Michael Albinus <michael.albinus@gmx.de>
2559
2560 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2561 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2562 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2563 Initialize xd_registered_buses.
2564
3478ec45
PE
25652012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2566
b263a6b0
PE
2567 Untag more efficiently if USE_LSB_TAG.
2568 This is based on a proposal by YAMAMOTO Mitsuharu in
2569 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2570 For an admittedly artificial (nth 8000 longlist) benchmark on
2571 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2572 Emacs's overall text size by 1%.
2573 * lisp.h (XUNTAG): New macro.
2574 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2575 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2576 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2577 * eval.c (Fautoload):
2578 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2579 * frame.h (XFRAME): Use XUNTAG.
2580
3478ec45
PE
2581 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2582 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2583 Remove unportable assumptions about print widths of types like
2584 dbus_uint32_t.
2585 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2586 intptr_t when converting between pointer and integer, to avoid GCC
2587 warnings about wrong width.
2588
666b903b 25892012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2590
2591 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2592 stack for each reader_thread, instead of defaulting to 8MB
2593 determined by the linker. This avoids failures in creating
2594 subprocesses on Windows 7, see the discussion in this thread:
2595 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2596
b120cc17
JC
25972012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2598
2599 Fix up display of the *Minibuf-0* buffer in the mini window.
2600 * keyboard.c (read_char): Don't clear the echo area if there's no
2601 message to clear.
2602 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2603 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2604
9a4b36f8
MA
26052012-05-07 Michael Albinus <michael.albinus@gmx.de>
2606
2607 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2608 batch mode.
2609
e5f9458f
CY
26102012-05-06 Chong Yidong <cyd@gnu.org>
2611
2612 * lisp.mk (lisp): Update.
2613
eceeb5fc 26142012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2615
2616 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2617
71873e2b
SM
26182012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2619
2620 * data.c (PUT_ERROR): New macro.
2621 (syms_of_data): Use it. Add new error type `user-error'.
2622 * undo.c (user_error): New function.
2623 (Fprimitive_undo): Use it.
2624 * print.c (print_error_message): Adjust print style for `user-error'.
2625 * keyboard.c (user_error): New function.
2626 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2627
ab0fa4e4
PE
26282012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 Do not limit current-time-string to years 1000..9999.
2631 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2632 (Fcurrent_time_string): Support any year that is supported by the
2633 underlying localtime representation. Don't use asctime, as it
2634 has undefined behavior for years outside the range -999..9999.
2635
7ed806a7
PE
26362012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2637
2638 Fix race conditions involving setenv, gmtime, localtime, asctime.
2639 Without this fix, interrupts could mess up code that uses these
2640 nonreentrant functions, since setting TZ invalidates existing
2641 tm_zone or tzname values, and since most of these functions return
2642 pointers to static storage.
2643 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2644 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2645 Grow the critical sections to include not just invoking
2646 localtime/gmtime, but also accessing these functions' results
2647 including their tm_zone values if any, and any related TZ setting.
2648 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2649 so that the struct tm is saved in the critical section.
2650 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2651 motivated by the fact that memory allocation needs to be outside
2652 the critical section.
2653
0c16dfed
DA
26542012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2655
2656 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2657 with RESET_INTERVAL.
2658
2659 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2660 Remove duplicated buffer name initialization.
2661
3f83ace8
JM
26622012-05-02 Jim Meyering <jim@meyering.net>
2663
2664 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2665
c7b8541e
JM
2666 * xfns.c (x_window): Use xstrdup (Bug#11375).
2667
90207a15 26682012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2669
2670 * xdisp.c (pos_visible_p): If already at a newline from the
2671 display string before the 'while' loop, don't walk back the glyphs
2672 from it3.glyph_row. Solves assertion violation when the display
2673 string begins with a newline (egg.el). (Bug#11367)
2674
b593d6a9
AH
26752012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2678 Move to simple.el.
2679
4737362e
GM
26802012-05-01 Glenn Morris <rgm@gnu.org>
2681
99cf43f9
GM
2682 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2683 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2684 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2685 All were removed before 23.1.
2686
9311dcff
GM
2687 * dispnew.c: Remove HAVE_LIBNCURSES test;
2688 it is always true on relevant platforms.
2689
4d5c6349
GM
2690 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2691 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2692
4737362e
GM
2693 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2694
74dd3a6b
AS
26952012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2696
2697 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2698 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2699 Remove.
2700
13c379ee
PE
27012012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 Do not avoid creating empty evaporating overlays (Bug#9642).
2704 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2705 That is, do not delete an evaporating overlay if it becomes
2706 empty after its bounds are adjusted to fit within its buffer.
2707 This fix caused other problems, and I'm reverting it until we get
2708 to the bottom of them.
2709
a8e7d6d7 27102012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2711
2712 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2713
a8e7d6d7 27142012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2715
2716 * xdisp.c (pos_visible_p): If the window start position is beyond
2717 ZV, start the display from buffer beginning. Prevents assertion
2718 violation in init_iterator when the minibuffer window is scrolled
2719 via the scroll bar.
2720
2721 * window.c (window_scroll_pixel_based): Likewise.
2722
a8e7d6d7 27232012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2724
2725 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2726
a8e7d6d7 27272012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2728
2729 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2730 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2731
a8e7d6d7 27322012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2733
b593d6a9
AH
2734 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2735 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2736
1c6900d9
EZ
27372012-04-26 Eli Zaretskii <eliz@gnu.org>
2738
4c3fa1d9
EZ
2739 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2740 display element, check also the underlying string or buffer
2741 character. (Bug#11341)
2742
1c6900d9
EZ
2743 * w32menu.c: Include w32heap.h.
2744 (add_menu_item): If the call to AppendMenuW (via
2745 unicode_append_menu) fails, disable Unicode menus only if we are
2746 running on Windows 9X/Me.
2747
42bf8205
AS
27482012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2749
2750 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2751 (xgetint): Add missing shift for LSB tags.
2752
b1bac16e
MR
27532012-04-24 Martin Rudalics <rudalics@gmx.at>
2754
2755 * keyboard.c (read_char): Don't wipe echo area for select window
2756 events: These might get delayed via `mouse-autoselect-window'
2757 (Bug#11304).
2758
d69621cc
JB
27592012-04-24 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2762 manipulation of :loaded-from data.
2763
02fd101b
JB
27642012-04-23 Juanma Barranquero <lekktu@gmail.com>
2765
2766 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2767 now a cons (bug#11311).
2768
888bec30
PE
27692012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2770
89a438bd
PE
2771 Do not create empty overlays with the evaporate property (Bug#9642).
2772 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2773 if it becomes empty after its bounds are adjusted to fit within
2774 its buffer. Without this fix, in a nonempty buffer (let ((o
2775 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2776 yields an empty overlay that has the evaporate property, which is
2777 not supposed to happen.
2778
1068fe4d
PE
2779 Fix minor GTK3 problems found by static checking.
2780 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2781 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2782 (struct _EmacsFixedClass, emacs_fixed_get_type):
2783 Move decls here from emacsgtkfixed.h, since they needn't be public.
2784 (emacs_fixed_get_type): Now static.
2785 (emacs_fixed_class_init): Omit unused local.
2786 (emacs_fixed_child_type): Remove; unused.
2787 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2788 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2789 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2790 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2791 (EMACS_FIXED_GET_CLASS): Remove; unused.
2792 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2793
888bec30
PE
2794 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2795 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2796
de85e130
PE
27972012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2798
d0baac98 2799 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2800 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2801 (__malloc_size_t, __malloc_ptrdiff_t):
2802 Remove. All uses removed, replaced by the definiens if needed,
2803 since we can assume C89 or better now.
2804 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2805 (protect_malloc_state, align, get_contiguous_space)
2806 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2807 (malloc_atfork_handler_child, malloc_enable_thread)
2808 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2809 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2810 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2811 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2812 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2813 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2814 Define using prototypes, not old style.
2815 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2816 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2817 (align): Don't assume that signed integer overflow wraps around.
2818 Omit unused local var.
2819 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2820 (_free_internal_nolock, memalign, mallochook, reallochook):
2821 Omit no-longer-needed casts.
2822 (valloc): Use getpagesize, not __getpagesize.
2823 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2824 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2825
de85e130
PE
2826 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2827
dcbf5805
MA
28282012-04-22 Michael Albinus <michael.albinus@gmx.de>
2829
2830 Move functions from C to Lisp. Make non-blocking method calls
2831 the default. Implement further D-Bus standard interfaces.
2832
2833 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2834 (QCdbus_request_name_allow_replacement)
2835 (QCdbus_request_name_replace_existing)
2836 (QCdbus_request_name_do_not_queue)
2837 (QCdbus_request_name_reply_primary_owner)
2838 (QCdbus_request_name_reply_in_queue)
2839 (QCdbus_request_name_reply_exists)
2840 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2841 (QCdbus_registered_serial, QCdbus_registered_method)
2842 (QCdbus_registered_signal): New Lisp objects.
2843 (XD_DEBUG_MESSAGE): Use sizeof.
2844 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2845 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2846 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2847 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2848 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2849 (xd_signature, xd_append_arg): Allow float for integer types.
2850 (xd_get_connection_references): New function.
b593d6a9
AH
2851 (xd_get_connection_address): Rename from xd_initialize.
2852 Return cached address.
dcbf5805
MA
2853 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2854 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2855 level.
2856 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2857 Return number of refcounts.
dcbf5805
MA
2858 (Fdbus_get_unique_name): Make stronger parameter check.
2859 (Fdbus_message_internal): New defun.
2860 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2861 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2862 (Fdbus_send_signal, Fdbus_register_service)
2863 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2864 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2865 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2866 (Vdbus_compiled_version, Vdbus_runtime_version)
2867 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2868 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2869 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2870 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2871 Adapt docstring.
dcbf5805 2872
52828e02
PE
28732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2874
da05bc4c
PE
2875 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2876 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2877 Do not assume ptrdiff_t is the same width as 'int'.
2878
52828e02
PE
2879 * alloc.c: Handle unusual debugging option combinations.
2880 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2881 since the two debugging options are incompatible.
2882 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2883 is defined.
2884 (mem_init, mem_insert, mem_insert_fixup):
2885 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2886 (NEED_MEM_INSERT): Remove; no longer needed.
2887
f01769f9
LL
28882012-04-22 Leo Liu <sdl.web@gmail.com>
2889
2890 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2891
5790543d
PE
28922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * sysdep.c [__FreeBSD__]: Minor cleanups.
2895 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2896 Use Emacs indenting style more consistently. Avoid some casts.
2897 Use 'double' consistently rather than mixing 'float' and 'double'.
2898
b91b7e4d
EW
28992012-04-21 Eduard Wiebe <usenet@pusto.de>
2900
b593d6a9
AH
2901 * sysdep.c (list_system_processes, system_process_attributes):
2902 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2903
6114eb15
AS
29042012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2905
2906 * lisp.mk (lisp): Update.
2907
2f38dff7
PE
29082012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2909
2910 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2911 It is never used otherwise.
2912
4ae29f89
SM
29132012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2914
2915 * print.c (print_preprocess): Only check print_depth if print-circle
2916 is nil.
2917 (print_object): Check for cycles even when print-circle is nil and
2918 print-gensym is t, but only check print_depth if print-circle is nil.
2919
f30d612a
CY
29202012-04-20 Chong Yidong <cyd@gnu.org>
2921
2922 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2923 set the status to "failed" and ensure that sentinel is run.
2924
c07a4c0b 29252012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2926
2927 * process.c (Fset_process_inherit_coding_system_flag)
2928 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2929 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2930
c07a4c0b 29312012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2932
2933 * xdisp.c (string_buffer_position_lim): Limit starting position to
2934 BEGV.
2935 (set_cursor_from_row): If called for a mode-line or header-line
2936 row, return zero immediately.
2937 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2938 farther than the first row after the header line, if any.
2939 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2940 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2941
c07a4c0b 29422012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2943
4ae29f89
SM
2944 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2945 (bug#11238).
ad3a2b41 2946
c07a4c0b 29472012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 29482012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2949
2950 configure: new option --enable-gcc-warnings (Bug#11207)
2951 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2952 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2953 (ALL_CFLAGS): Use new macros rather than old.
2954 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2955 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2956 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2957 -Wunused-result, -Wunused-variable. This should go away once
2958 the Emacs and Gnulib regex code is merged.
2959 (xmalloc, xrealloc): Now static.
2960
aba027e8
PE
29612012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2962
2963 * dired.c (Fsystem_groups): Remove unused local.
2964
e5a36063
GM
29652012-04-17 Glenn Morris <rgm@gnu.org>
2966
2967 * dired.c (Fsystem_users): Doc fix.
2968
316411f0
DA
29692012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2970
2971 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2972 (syms_of_dired): Add them.
2973
9426aba4
PE
29742012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2975
b62a57be
PE
2976 Fix minor alloc.c problems found by static checking.
2977 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2978 New extern decls, to avoid calling undeclared functions.
2979 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2980 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2981 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2982 (NEED_MEM_INSERT): New macro.
2983 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2984 Remove one incorrect comment and fix another.
b62a57be 2985
3539f31f
PE
2986 Fix minor ralloc.c problems found by static checking.
2987 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2988 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2989 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2990 (r_alloc_sbrk): Now static.
2991
a041960a
PE
2992 Improve ralloc.c interface checking.
2993 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2994 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2995 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2996 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2997 [REL_ALLOC]: ... to here, to check interface.
2998 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2999 Remove decls. This fixes an "It stinks!".
3000
9426aba4
PE
3001 * alloc.c (which_symbols): Fix alignment issue / type clash.
3002
d55c12ed
AS
30032012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3004
3005 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3006 (struct Lisp_Misc_Any): Likewise.
3007 (struct Lisp_Free): Likewise.
3008 * alloc.c (union aligned_Lisp_Symbol): Define.
3009 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3010 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3011 (union aligned_Lisp_Misc): Define.
3012 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3013 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3014 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3015
b948ce8b
PE
30162012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3017
3018 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3019 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3020 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3021 * s/netbsd.h, s/sol2-6.h:
3022 Remove definition of GC_MARK_STACK, since the default now works.
3023 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3024 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3025 no longer the default.
3026 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3027
35dc09a1 30282012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3029
35dc09a1
GM
3030 * lread.c (lisp_file_lexically_bound_p):
3031 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3032
35dc09a1
GM
30332012-04-14 Eli Zaretskii <eliz@gnu.org>
3034
3035 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3036 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3037
30382012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3039
3040 * nsterm.m (constrainFrameRect): Always constrain when there is only
3041 one screen (Bug#10962).
3042
bcd86815
KB
30432012-04-13 Ken Brown <kbrown@cornell.edu>
3044
3045 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3046
c25df26e
RT
30472012-04-13 Reuben Thomas <rrt@sc3d.org>
3048
3049 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3050
0fc59f1e
DC
30512012-04-11 Daniel Colascione <dancol@dancol.org>
3052
3053 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3054 against is gone. It's better to use vfork now so that when Cygwin
3055 gains a new, working vfork, we use it automatically (bug#10398).
3056
de8c03dc
SM
30572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3058
3059 * window.c (save_window_save): Obey window-point-insertion-type.
3060
2f097256
GM
30612012-04-11 Glenn Morris <rgm@gnu.org>
3062
3063 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3064
453b951e
SM
30652012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3066
3067 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3068
75f1671a 30692012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3070
3071 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3072 (force_quit_count): New var.
3073 (handle_interrupt): Use it.
3074
2a8ce227
JB
30752012-04-10 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * w32.c (w32_delayed_load): Record the full path of the library
3078 being loaded (bug#10424).
3079
935396c0
GM
30802012-04-09 Glenn Morris <rgm@gnu.org>
3081
05920a43
GM
3082 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3083 not just in the obarray, before snarfing them. (Bug#11036)
3084
935396c0
GM
3085 * Makefile.in ($(leimdir)/leim-list.el):
3086 Pass EMACS rather than BUILT_EMACS.
3087
a18ecafa
TZ
30882012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3089
3090 * process.c (make_process):
3091 * process.h: Add integer `gnutls_handshakes_tried' member to
3092 process struct.
3093
6bbef4e5
JC
3094 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3095 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3096
3097 * gnutls.c (gnutls_log_function2i): Convenience log function.
3098 (emacs_gnutls_read): Use new log functions,
3099 `gnutls_handshakes_tried' process member, and
3100 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3101 attempts per process (connection).
3102
b4d3bc10
CY
31032012-04-09 Chong Yidong <cyd@gnu.org>
3104
3105 * eval.c (Fuser_variable_p, user_variable_p_eh)
3106 (lisp_indirect_variable): Functions deleted.
3107 (Fdefvar): Caller changed.
3108
3109 * callint.c (Finteractive, Fcall_interactively):
3110 * minibuf.c (Fread_variable): Callers changed.
3111
70f4d973
EZ
31122012-04-09 Eli Zaretskii <eliz@gnu.org>
3113
3114 * xdisp.c (set_cursor_from_row): If the display string appears in
3115 the buffer at position that is closer to point than the position
3116 after the display string, display the cursor on the first glyph of
3117 the display string. Fixes cursor display when a 'display' text
3118 property immediately follows invisible text. (Bug#11094)
3119
cb3c2e3e
PE
31202012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3121
3122 composite.c: use 'double' consistently
3123 * composite.c (get_composition_id): Use 'double' consistently
3124 instead of converting 'float' to 'double' and vice versa; this is
3125 easier to understand and avoids a GCC warning.
3126
fd06db5d
GM
31272012-04-09 Glenn Morris <rgm@gnu.org>
3128
50fe702a
GM
3129 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3130 preparation for dumping it with emacs. (Bug#4789)
3131 (leimdir): New variable.
3132 ($(leimdir)/leim-list.el): New rule.
3133 (emacs$(EXEEXT)): Depend on leim-list.el.
3134
fd06db5d
GM
3135 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3136 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3137 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3138
55c131ee
AS
31392012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3140
3141 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3142 proper alignment.
3143
9209588f
JB
31442012-04-07 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3147 Remove unused local variable.
3148
e3fb2efb
PE
31492012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3150
3151 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3152 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3153 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3154 objects, as mark_maybe_pointer will catch them otherwise.
3155 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3156 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3157
b5385551
PE
31582012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3159
3160 Fix typo that broke non-Windows builds.
3161 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3162
9078ead6
EZ
31632012-04-07 Eli Zaretskii <eliz@gnu.org>
3164
3165 Support building on MS-Windows with libxml2.
3166
3167 * makefile.w32-in (OBJ2): Add xml.$(O).
3168 (GLOBAL_SOURCES): Add xml.c.
3169 ($(BLD)/xml.$(O)): New dependency list.
3170
3171 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3172 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3173 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3174 [!WINDOWSNT]: New macros.
3175 (init_libxml2_functions, libxml2_loaded_p): New functions.
3176 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3177 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3178 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3179 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3180 linked in).
6bbef4e5
JC
3181 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3182 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3183 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3184
3185 * emacs.c: Don't include libxml/parser.h.
3186 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3187 xmlCleanupParser directly.
3188
3189 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3190
3811fdf3
EZ
31912012-04-07 Eli Zaretskii <eliz@gnu.org>
3192
3193 * indent.c (Fvertical_motion): If there is a display string at
3194 point, use it.vpos to compute how many lines to backtrack after
3195 move_it_to point. (Bug#11133)
3196
2f8e16b2
EZ
31972012-04-06 Eli Zaretskii <eliz@gnu.org>
3198
3199 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3200 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3201 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3202 macros related to unification of CJK characters. For the details,
3203 see the discussion following the message here:
3204 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3205
3d439cd1
CY
32062012-04-04 Chong Yidong <cyd@gnu.org>
3207
3208 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3209
8bc53d00
EZ
32102012-04-01 Eli Zaretskii <eliz@gnu.org>
3211
3212 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3213 instead of alloca. (Bug#11138)
3214
3b0512a3
AS
32152012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3216
3217 * w32menu.c (is_simple_dialog): Properly check lisp types.
3218 (Bug#11141)
3219
8427ddd2
EZ
32202012-03-31 Eli Zaretskii <eliz@gnu.org>
3221
979022ef
EZ
3222 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3223 position we get to after a call to move_it_to fails the
3224 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3225 only if we wind up in a string from display property. (Bug#11063)
3226
a6b1c7cc
EZ
3227 * window.c (Fdelete_other_windows_internal): Invalidate the row
3228 and column information about mouse highlight, so that redisplay
3229 restores it after reallocating the glyph matrices. (Bug#7464)
3230
8427ddd2
EZ
3231 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3232 string comes from a `display' text property, use the buffer
3233 position of that property as if we actually saw that position in
3234 the row's glyphs.
697ba24b
EZ
3235 (move_it_by_lines): Remove the assertion that
3236 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3237 violated when there's a before-string at the beginning of a line.
3238 (Bug#11063)
8427ddd2 3239
65a0a738
EZ
32402012-03-30 Eli Zaretskii <eliz@gnu.org>
3241
3242 * xdisp.c (append_space_for_newline): If the default face was
3243 remapped, use the remapped face for the appended newline.
3244 (extend_face_to_end_of_line): Use the remapped default face for
3245 extending the face to the end of the line.
3246 (display_line): Call extend_face_to_end_of_line when the default
3247 face was remapped. (Bug#11068)
3248
581355cc
EZ
32492012-03-29 Eli Zaretskii <eliz@gnu.org>
3250
3251 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3252
e8fc049f
SM
32532012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3254
3255 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3256
4fb9a543
GM
32572012-03-27 Glenn Morris <rgm@gnu.org>
3258
3259 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3260 Doc fixes.
3261
679910f1
KH
32622012-03-26 Kenichi Handa <handa@m17n.org>
3263
3264 * dispextern.h (struct glyph): Fix previous change. Change the
3265 bit length of glyphless.ch to 25 (Bug#11082).
3266
90d49b7f
CY
32672012-03-26 Chong Yidong <cyd@gnu.org>
3268
3269 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3270 (command_loop_1): Use it; inhibit selection update for
3271 handle-select-window too (Bug#8996).
3272
f514f6f0
FP
32732012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3274
e8fc049f 3275 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3276
bf43fa51
KH
32772012-03-25 Kenichi Handa <handa@m17n.org>
3278
3279 * dispextern.h (struct glyph): Change the bit length of
3280 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3281
8a0c01dd
EZ
32822012-03-24 Eli Zaretskii <eliz@gnu.org>
3283
3284 * s/ms-w32.h (tzname): Include time.h before redirecting to
3285 _tzname. Fixes the MSVC build. (Bug#9960)
3286
7d1c3a76
AS
32872012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3288
8ed79523
AS
3289 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3290 characters.
3291
7d1c3a76
AS
3292 * xterm.c (XTread_socket): Only modify handling_signal if
3293 !SYNC_INPUT. (Bug#11080)
3294
e99a9b8b
EZ
32952012-03-23 Eli Zaretskii <eliz@gnu.org>
3296
3297 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3298 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3299 when fetching a multibyte character consumes more bytes than
3300 CHAR_BYTES returns, due to unification of CJK characters in
3301 string_char. (Bug#11073)
3302
5063c0e1
TN
33032012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3304
3305 * process.c (wait_reading_process_output): Handle pty disconnect
3306 by refraining from sending oneself a SIGCHLD (bug#10933).
3307
9f851fbd
CY
33082012-03-22 Chong Yidong <cyd@gnu.org>
3309
3310 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3311
5063c0e1 3312 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3313 Mark string as coming from a prefix property.
3314 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3315 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3316
fb5b8aca
CY
33172012-03-21 Chong Yidong <cyd@gnu.org>
3318
3319 * xfaces.c (Vface_remapping_alist): Doc fix.
3320
62356a1b
EZ
33212012-03-20 Eli Zaretskii <eliz@gnu.org>
3322
3323 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3324 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3325 Doc fixes.
62356a1b 3326
025de85b
CY
33272012-03-20 Chong Yidong <cyd@gnu.org>
3328
3329 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3330 to reflect default non-nil value of redisplay-dont-pause.
3331
4827f94e
KH
33322012-03-19 Kenichi Handa <handa@m17n.org>
3333
3334 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3335 it fit in a valid range (Bug#11003).
3336
e50a24a2
EZ
33372012-03-18 Eli Zaretskii <eliz@gnu.org>
3338
3339 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3340 that is not from display property, accept the row as a "cursor
3341 row" if one of the string's character has a non-nil `cursor'
3342 property. Fixes cursor positioning when there are newlines in
3343 overlay strings, e.g. in icomplete.el. (Bug#11035)
3344
9af5ed87
PE
33452012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3348
d1f55f16
CY
33492012-03-12 Chong Yidong <cyd@gnu.org>
3350
3351 * eval.c (inhibit_lisp_code): Rename from
3352 inhibit_window_configuration_change_hook; move from window.c.
3353
3354 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3355 * window.c (run_window_configuration_change_hook)
3356 (syms_of_window): Callers changed.
3357
66c5eebd
CY
33582012-03-11 Chong Yidong <cyd@gnu.org>
3359
413df973
CY
3360 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3361
66c5eebd
CY
3362 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3363
1de11f56
CY
33642012-03-10 Chong Yidong <cyd@gnu.org>
3365
3366 * frame.c (other_visible_frames): Don't assume the selected frame
3367 is visible (Bug#10955).
3368
cae07000
SM
33692012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3370
3371 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3372
89c94350
JD
33732012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3374
3375 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3376 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3377 zero (Bug#10954).
3378
999dd333
GM
33792012-03-03 Glenn Morris <rgm@gnu.org>
3380
01a6dcc8 3381 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3382
de0100f2
EZ
33832012-03-02 Eli Zaretskii <eliz@gnu.org>
3384
3385 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3386 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3387 (redisplay_window, next_element_from_string): Fix typos in
3388 comments.
3e441275
EZ
3389 (redisplay_window): Pass to move_it_vertically the margin in
3390 pixels, not in screen lines.
de0100f2 3391
96a72ee9
GM
33922012-03-02 Glenn Morris <rgm@gnu.org>
3393
3394 * buffer.c (buffer-list-update-hook): Doc fix.
3395
312508d7
EZ
33962012-02-29 Eli Zaretskii <eliz@gnu.org>
3397
3398 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3399 push_it before setting up the iterator for the first overlay
3400 string, even if we have an empty string loaded.
3401 (next_overlay_string): If there's an empty string on the iterator
3402 stack, pop the stack. (Bug#10903)
3403
27f3c637
PE
34042012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3405
3406 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3407 Suggested by Stefan Monnier in
3408 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3409 * alloc.c (widen_to_Lisp_Object): New static function.
3410 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3411 and widening them to Lisp_Objects. This would work even if
3412 USE_LSB_TAG is defined and wide integers are used, which might
3413 happen in a future version of Emacs.
3414
3c9dfce6
CY
34152012-02-25 Chong Yidong <cyd@gnu.org>
3416
fa74b241
CY
3417 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3418 Doc fix.
3419
3c9dfce6
CY
3420 * xselect.c (Fx_selection_exists_p): Doc fix.
3421 (x_clipboard_manager_save_all): Print an informative message
3422 before saving to clipboard manager.
3423
9486df08
CY
34242012-02-24 Chong Yidong <cyd@gnu.org>
3425
3426 * keyboard.c (process_special_events): Handle all X selection
3427 requests in kbd_buffer, not just the next one (Bug#8869).
3428
f01d3321
CY
34292012-02-23 Chong Yidong <cyd@gnu.org>
3430
3431 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3432 call when setting menu-bar-lines and tool-bar-lines parameters.
3433 (unwind_create_frame_1): New helper function.
3434
3435 * window.c (inhibit_window_configuration_change_hook): New var.
3436 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3437 (syms_of_window): Initialize it.
f01d3321 3438
86b847b6
CY
34392012-02-22 Chong Yidong <cyd@gnu.org>
3440
3441 * xterm.c (x_draw_image_relief): Add missing type check for
3442 Vtool_bar_button_margin (Bug#10743).
3443
a59225b1
CY
34442012-02-21 Chong Yidong <cyd@gnu.org>
3445
3446 * fileio.c (Vfile_name_handler_alist): Doc fix.
3447
3448 * buffer.c (Fget_file_buffer): Protect against invalid file
3449 handler return value.
3450
310f5bd4
PE
34512012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3452
cb3a28cc
PE
3453 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3454 when computing $valmask.
3455
310f5bd4
PE
3456 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3457 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3458 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3459 It's useless in that case, and it can cause problems on hosts
3460 that allocate halves of EMACS_INT values separately.
3461 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3462 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3463 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3464 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3465 it avoids undefined behavior on hosts where shifting right by more
3466 than the word width has undefined behavior.
3467
2375c96a
CY
34682012-02-19 Chong Yidong <cyd@gnu.org>
3469
3470 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3471 (Funhandled_file_name_directory, Ffile_name_as_directory)
3472 (Fdirectory_file_name, Fexpand_file_name)
3473 (Fsubstitute_in_file_name): Protect against invalid file handler
3474 return values (Bug#10845).
3475
3eb49e71
EZ
34762012-02-18 Eli Zaretskii <eliz@gnu.org>
3477
3478 * .gdbinit (pitx): Fix incorrect references to fields of the
3479 iterator stack.
3480
7b926f3f
CY
34812012-02-17 Chong Yidong <cyd@gnu.org>
3482
3483 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3484
11273115
PE
34852012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3488 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3489
c3a70e2b
CY
34902012-02-15 Chong Yidong <cyd@gnu.org>
3491
3492 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3493 marked as special. Also, starting docstrings with * is obsolete.
3494
0ca43699
AS
34952012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3496
3497 * gnutls.c (emacs_gnutls_write): Fix last change.
3498
2e8f3c56
LI
34992012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3500
3501 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3502 send_process.
3503
af70074f
SM
35042012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 * keymap.c (Fsingle_key_description): Handle char ranges.
3507
95986d52
CY
35082012-02-12 Chong Yidong <cyd@gnu.org>
3509
afd83bd1
CY
3510 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3511 as that creates a dangerous corner case.
3512
95986d52
CY
3513 * window.c (Fdelete_window_internal): Invalidate the mouse
3514 highlight (Bug#9904).
3515
bd7da63e
GM
35162012-02-12 Glenn Morris <rgm@gnu.org>
3517
3518 * xselect.c (Fx_own_selection_internal)
3519 (Fx_get_selection_internal, Fx_disown_selection_internal)
3520 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3521 * nsselect.m (Fx_own_selection_internal)
3522 (Fx_disown_selection_internal, Fx_selection_exists_p)
3523 (Fx_selection_owner_p, Fx_get_selection_internal):
3524 Sync docs and argument specs with the xselect.c versions.
3525
77abcbc2
LI
35262012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3527
3528 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3529
90b671e2
EZ
35302012-02-11 Eli Zaretskii <eliz@gnu.org>
3531
1c0ca0b7
EZ
3532 * w32select.c (Fx_selection_exists_p): Sync doc string and
3533 argument list with xselect.c. (Bug#10783)
3534
3535 * w16select.c (Fx_selection_exists_p): Sync doc string and
3536 argument list with xselect.c. (Bug#10783)
90b671e2 3537
49241268
GM
35382012-02-10 Glenn Morris <rgm@gnu.org>
3539
3540 * fns.c (Fsecure_hash): Doc fix.
3541
f998bbe7 35422012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3543
3544 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3545
0992bd9c
CY
35462012-02-07 Chong Yidong <cyd@gnu.org>
3547
3548 * buffer.c (Fbuffer_local_variables)
3549 (buffer_lisp_local_variables): Handle unbound vars correctly;
3550 don't let Qunbound leak into Lisp.
3551
af008560
GM
35522012-02-07 Glenn Morris <rgm@gnu.org>
3553
dd605cc4
GM
3554 * image.c (Fimagemagick_types): Doc fix.
3555
af008560
GM
3556 * image.c (imagemagick-render-type): Change it from a lisp object
3557 to an integer. Move the doc here from the lisp manual.
3558 Treat all values not equal to 0 the same.
3559
1449fa1d
CY
35602012-02-06 Chong Yidong <cyd@gnu.org>
3561
3562 * doc.c (store_function_docstring): Avoid applying docstring of
3563 alias to base function (Bug#2603).
3564
3723ec07
AS
35652012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * .gdbinit (pp1, pv1): Remove redundant defines.
3568 (pr): Use pp.
3569
79c1cc1e
CY
35702012-02-04 Chong Yidong <cyd@gnu.org>
3571
3572 * nsterm.m: Declare a global (Bug#10694).
3573
d7f29f8e
EZ
35742012-02-04 Eli Zaretskii <eliz@gnu.org>
3575
cae07000
SM
3576 * w32.c (get_emacs_configuration_options):
3577 Include --enable-checking, if specified, in the return value.
d7f29f8e 3578
3b95a6f9
MR
35792012-02-04 Martin Rudalics <rudalics@gmx.at>
3580
3581 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3582 after rounding frame sizes. (Bug#9723)
3583
d6fa96a6
EZ
35842012-02-04 Eli Zaretskii <eliz@gnu.org>
3585
3586 * keyboard.c (adjust_point_for_property): Don't position point
3587 before BEGV. (Bug#10696)
3588
df0b2940
PE
35892012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 Handle overflow when computing char display width (Bug#9496).
3592 * character.c (char_width): Return EMACS_INT, not int.
3593 (char_width, c_string_width): Check for overflow when
3594 computing the width; this is possible now that individual
3595 characters can have unbounded width. Problem introduced
3596 by merge from Emacs 23 on 2012-01-19.
3597
6bee44d6
MA
35982012-02-02 Michael Albinus <michael.albinus@gmx.de>
3599
3600 * dbusbind.c (Fdbus_register_method): Mention the return value
3601 :ignore in the docstring.
3602
44f92739
GM
36032012-02-02 Glenn Morris <rgm@gnu.org>
3604
1b9f60cc
GM
3605 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3606
44f92739
GM
3607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3608 Unconditionally set to t. (Bug#10673)
3609 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3610 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3611 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3612
c5d3843c
KH
36132012-02-02 Kenichi Handa <handa@m17n.org>
3614
3615 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3616 0, do not call append_composite_glyph.
3617
159462d4 36182012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3619
3620 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3621 NULL (Bug#6988).
3622 (x_produce_glyphs): If the component of a composition is a null
3623 string, set it->pixel_width to 1 to avoid zero-width glyph.
3624
78cef877
EZ
36252012-02-01 Eli Zaretskii <eliz@gnu.org>
3626
3627 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3628 first 2 arguments are identical. This makes inserting large
3629 output from a subprocess an order of magnitude faster on
3630 MS-Windows, where all sbrk'ed memory is always contiguous.
3631
97897668
GM
36322012-01-31 Glenn Morris <rgm@gnu.org>
3633
3634 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3635 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3636 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3637
31fd3586
GM
36382012-01-29 Glenn Morris <rgm@gnu.org>
3639
3640 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3641
0e24a8b2
CY
36422012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3643
3644 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3645
cc0adcb0
CY
36462012-01-28 Chong Yidong <cyd@gnu.org>
3647
3648 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3649
acc28cb9
CY
36502012-01-26 Chong Yidong <cyd@gnu.org>
3651
9c69cfb7
CY
3652 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3653
acc28cb9
CY
3654 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3655 repeat counts (Bug#10507).
3656
48da7392
GM
36572012-01-26 Glenn Morris <rgm@gnu.org>
3658
3659 * lread.c (syms_of_lread): Doc fix.
3660
14af5f7f
CY
36612012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3662
3663 * coding.c (encode_designation_at_bol): Change return value to
3664 EMACS_INT.
3665
0b21c100
CY
36662012-01-25 Chong Yidong <cyd@gnu.org>
3667
3668 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3669
3c2907f7
CY
36702012-01-21 Chong Yidong <cyd@gnu.org>
3671
3672 * floatfns.c (Fcopysign): Make the second argument non-optional,
3673 since nil is not allowed anyway.
3674
959ad23f
AS
36752012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3676
3677 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3678 (send_process): Likewise.
3679
34a02f46
MR
36802012-01-19 Martin Rudalics <rudalics@gmx.at>
3681
3682 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3683 (Vwindow_persistent_parameters): Do not use Qstate.
3684 Rewrite doc-strings.
34a02f46 3685
1259009a 36862012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3687
3688 * character.c (char_width): New function.
70d4fdf6
GM
3689 (Fchar_width, c_string_width, lisp_string_width):
3690 Use char_width (Bug#9496).
25ed9e61 3691
6a6ee00d
MR
36922012-01-16 Martin Rudalics <rudalics@gmx.at>
3693
3694 * window.c (Vwindow_persistent_parameters): New variable.
3695 (Fset_window_configuration, save_window_save): Handle persistent
3696 window parameters.
3697
c85efaf7
EZ
36982012-01-14 Eli Zaretskii <eliz@gnu.org>
3699
3700 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3701 thrashing the stack of the thread. (Bug#9087)
3702
5944709e
PE
37032012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3706
e71f5d99
EZ
37072012-01-11 Eli Zaretskii <eliz@gnu.org>
3708
3709 * xdisp.c (rows_from_pos_range): Handle the case where the
3710 highlight ends on a newline. (Bug#10464)
3711 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3712 he end column for display of highlight that ends on a newline
3713 before a R2L line.
3714
ce316182
GM
37152012-01-11 Glenn Morris <rgm@gnu.org>
3716
3717 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3718 from load-path also when installation-directory is nil. (Bug#10208)
3719
5b43da69
GM
37202012-01-10 Glenn Morris <rgm@gnu.org>
3721
74cc8ff9
GM
3722 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3723
7d8d6e4e
GM
3724 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3725 Update template values to be closer to their typical values these days.
5b43da69 3726
a0db8d43
EZ
37272012-01-09 Eli Zaretskii <eliz@gnu.org>
3728
3729 * xdisp.c (rows_from_pos_range): Accept additional argument
3730 DISP_STRING, and accept any glyph in a row whose object is that
3731 string as eligible for mouse highlight. Fixes mouse highlight of
3732 display strings from overlays. (Bug#10464)
3733
9a0115ab 37342012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3735
b9110d6a 3736 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3737 * fileio.c (auto_saving_dir_umask): New static var.
3738 (Fmake_directory_internal): Use it.
3739 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3740 creating the directory. The old code temporarily assigns
3741 too-generous permissions to the directory.
3742 (do_auto_save_eh): Clear it.
b9110d6a 3743 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3744 that the var is always cleared.
3745
6c1bd3f3
EZ
37462012-01-07 Eli Zaretskii <eliz@gnu.org>
3747
3748 * search.c (scan_buffer): Pass character positions to
3749 know_region_cache, not byte positions. (Bug#6540)
3750
069d2b50
L
37512012-01-07 LynX <_LynX@bk.ru> (tiny change)
3752
3753 * w32.c (sys_rename): Report EXDEV when rename of a directory
3754 fails because the target is on another logical disk. (Bug#10284)
3755
75bf0d33
DB
37562012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3757
3758 * xterm.c (x_embed_request_focus): New function.
3759
3760 * xterm.h: Add prototype.
3761
3762 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3763
1c6e5a32
GM
37642012-01-05 Glenn Morris <rgm@gnu.org>
3765
3766 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3767
651e947e
EZ
37682012-01-01 Eli Zaretskii <eliz@gnu.org>
3769
3770 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3771 Load gnutls_transport_set_lowat only if GnuTLS version is below
3772 2.11.1.
3773 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3774 GnuTLS versions below 2.11.1.
3775
3778cdd8
AL
37762011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3777
3778 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3779 to the doc string advising against its use for altering the way
3780 windows are scrolled.
3781
0e5317f7
KH
37822011-12-28 Kenichi Handa <handa@m17n.org>
3783
3784 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3785 coding-system ASCII compatible only when it does not produce BOM
3786 on encoding (Bug#10383).
3787
93d5ca1f
JD
37882011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3789
3790 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3791 can scroll.
3792 (create_and_show_popup_menu): Always use menu_position_func for
3793 Gtk3 (Bug#10361).
3794
ca22b785
AS
37952011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3796
3797 * callint.c (Fcall_interactively): Don't truncate prompt string.
3798
d048e1e6
EZ
37992011-12-23 Eli Zaretskii <eliz@gnu.org>
3800
3801 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3802 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3803 resumed from there (after widening). (Bug#10360)
d048e1e6 3804
5ccaba1f
JD
38052011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3806
3807 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3808
204ee57f
JD
38092011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3810
b81d40f0
JB
3811 * nsterm.m (x_free_frame_resources):
3812 Release f->output_data.ns->miniimage.
204ee57f
JD
3813 (ns_index_color): Fix indentation. Do not retain
3814 color_table->colors[i].
3815
3816 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3817 before returning.
3818
3819 * nsfns.m (x_set_background_color): Assign return value from
3820 ns_index_color to face-background instead of NSColor*.
3821 (ns_implicitly_set_icon_type): Fix indentation.
3822 Change assignment in for loop to comparison.
3823
3824 * emacs.c (ns_pool): New variable.
3825 (main): Assign ns_pool.
3826 (Fkill_emacs): Call ns_release_autorelease_pool.
3827
3828 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3829 autorelease fdesc, release fdAttrs and tdict.
3830 (ns_get_covering_families): Release charset.
3831 (ns_findfonts): Release NSFontDescriptor created with new.
3832 (ns_uni_to_glyphs): Fix indentation.
3833 (setString): Release attrStr before assigning new value.
3834
c803b2b7
JD
38352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3836
678f4426
JD
3837 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3838 and NS_IMPL_COCOA.
3839 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3840 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3841
cd394be1 38422011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3843
5fecd5fc
JD
3844 * nsterm.m (ns_term_init): Subscribe for notifications
3845 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3846 to method trackingNotification in EmacsMenu.
3847
3848 * nsmenu.m (trackingMenu): New variable.
3771cb17 3849 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3850 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3851 from Aquamacs (Bug#7030).
678f4426
JD
3852
38532011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3854
c803b2b7
JD
3855 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3856 (symbol_to_nsstring): Fix indentation.
3857 (ns_symbol_to_pb): New function.
cae07000
SM
3858 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3859 (Fns_rotate_cut_buffers_internal): Remove.
3860 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3861 Fns_store_cut_buffer_internal.
3862 (ns_get_foreign_selection, Fx_own_selection_internal)
3863 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3864 (Fns_get_selection_internal, Fns_store_selection_internal):
3865 Use ns_symbol_to_pb and check if return value is nil.
3866 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3867 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3868 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3869 renamed to Sns_store_selection_internal.
3870 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3871 and remove this function.
3872 (ns_handle_selection_clear): Remove, never used.
3873 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3874 here.
3875
e1b01a3a
KB
38762011-12-17 Ken Brown <kbrown@cornell.edu>
3877
3878 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3879 GID is unknown (Bug#10257).
3880
2adb6e85
PE
38812011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3884 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3885 which caused a build failure on GNU/Linux IA-64. This problem was
3886 introduced by my 2011-10-07 patch.
3887
d1d7b339
JL
38882011-12-15 Juri Linkov <juri@jurta.org>
3889
3890 * image.c (imagemagick_error): New function. (Bug#10112)
3891 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3892 Use `imagemagick_error' where ImageMagick functions return
3893 `MagickFalse'.
3894 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3895 proper order.
3896
100d5755
KH
38972011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3898
3899 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3900 fill background (Bug#8992).
3901
454592a6
MR
39022011-12-13 Martin Rudalics <rudalics@gmx.at>
3903
3904 * window.c (Vwindow_combination_resize)
3905 (Vwindow_combination_limit): Use t instead of non-nil in
3906 doc-strings.
61d4b438
MR
3907 (Vrecenter_redisplay): Add first sentence of doc-string on
3908 separate line.
53524d93 3909 (Frecenter): Fix doc-string typo.
454592a6 3910
3633e3aa
KH
39112011-12-11 Kenichi Handa <handa@m17n.org>
3912
3913 * coding.c (Funencodable_char_position): Pay attention to the
3914 buffer text relocation (Bug#9389).
3915
7b9d523a 39162011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3917
7b9d523a
JD
3918 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3919 gtk_init (Bug#10100).
3920
b73189c6
EZ
39212011-12-10 Eli Zaretskii <eliz@gnu.org>
3922
3923 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3924 IT->string is nil. (Bug#10263)
3925
f7dfe5d6
JD
39262011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3927
83faebb4
JD
3928 * nsterm.h (x_free_frame_resources): Declare.
3929
f7dfe5d6
JD
3930 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3931 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3932
3933 * nsterm.h (ns_get_defaults_value): Declare.
3934
3935 * nsterm.m (ns_default): Call ns_get_defaults_value.
3936
7cd4e72c
EZ
39372011-12-09 Eli Zaretskii <eliz@gnu.org>
3938
3939 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3940 (Bug#10170)
3941
b34d7317
YM
39422011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3943
3944 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3945 that where the value of an _OBJC_* symbol points to is in the .bss
3946 section (Bug#10240).
3947
76470ad1
KH
39482011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3949
3950 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3951 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3952
745fff94
KH
39532011-12-08 Kenichi Handa <handa@m17n.org>
3954
3955 * ftfont.c (get_adstyle_property): Fix previous change
3956 (Bug#10233).
3957
6e44397c
JB
39582011-12-07 Juanma Barranquero <lekktu@gmail.com>
3959
3960 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3961 dirs from the default value of EMACSLOADPATH (bug#10208).
3962
7efa6272
GM
39632011-12-07 Glenn Morris <rgm@gnu.org>
3964
3965 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3966 installation and source directories as well. (Bug#10208)
3967
f6fc4d87
CY
39682011-12-06 Chong Yidong <cyd@gnu.org>
3969
3970 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3971
2bf26180
GM
39722011-12-06 Glenn Morris <rgm@gnu.org>
3973
3974 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3975 as an error, not just -1. (Bug#10217)
3976
3a6ad4f0
CY
39772011-12-05 Chong Yidong <cyd@gnu.org>
3978
3979 * keyboard.c (process_special_events): New function.
3980 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3981
75a3b399
PE
39822011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3983
3984 * coding.c (encode_designation_at_bol): Don't use uninitialized
3985 local variable (Bug#9318).
3986
c3c9e25e
KH
39872011-12-05 Kenichi Handa <handa@m17n.org>
3988
3989 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3990 return Qnil (Bug#8046, Bug#10193).
3991
5eb05ea3
KH
39922011-12-05 Kenichi Handa <handa@m17n.org>
3993
3994 * coding.c (encode_designation_at_bol): New args charbuf_end and
3995 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3996 (coding_set_source): Return how many bytes coding->source was
3997 relocated.
3998 (coding_set_destination): Return how many bytes
3999 coding->destination was relocated.
4000 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4001 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4002
40032011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4004
4005 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4006 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4007 macro (Bug#9318).
4008
40092011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4010
4011 The following changes are to fix Bug#9318.
4012
a79703f5 4013 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4014 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4015 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4016 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4017
7dbda6df
JB
40182011-12-05 Juanma Barranquero <lekktu@gmail.com>
4019
4020 * lisp.h (process_quit_flag): Fix external declaration.
4021
6d5eb5b0
SM
40222011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 Don't macro-inline non-performance-critical code.
4025 * eval.c (process_quit_flag): New function.
4026 * lisp.h (QUIT): Use it.
4027
a0c3fad0
JD
40282011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4029
4030 * nsfns.m (get_geometry_from_preferences): New function.
4031 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4032
6c07aac2
AS
40332011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4034
4035 * emacs.c (Qkill_emacs): Define.
4036 (syms_of_emacs): Initialize it.
4037 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4038 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4039 (quit_throw_to_read_char): Add parameter `from_signal'.
4040 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4041 * lisp.h (QUIT): Call Fkill_emacs if requested.
4042
c052ead4
JD
40432011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4044
4045 * widget.c (update_wm_hints): Return if wmshell is null.
4046 (widget_update_wm_size_hints): New function.
4047
4048 * widget.h (widget_update_wm_size_hints): Declare.
4049
4050 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4051 widget_update_wm_size_hints (Bug#10104).
4052
9e49252b
EZ
40532011-12-03 Eli Zaretskii <eliz@gnu.org>
4054
4055 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4056 before a newline, prepare the bidi iterator for consuming the
4057 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4058 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4059
02b16839
JL
40602011-12-02 Juri Linkov <juri@jurta.org>
4061
4062 * search.c (Fword_search_regexp): New Lisp function created from
4063 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4064 (Fword_search_backward, Fword_search_forward)
4065 (Fword_search_backward_lax, Fword_search_forward_lax):
4066 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4067 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4068
0068070e
SM
40692011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4070
4071 * fileio.c (Finsert_file_contents): Move after-change-function call
4072 to before the "handled:" label, since all "goto handled" appear in
4073 cases where the *-change-functions have already been properly called
4074 (bug#10117).
4075
3360a3fc
AS
40762011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4077
4078 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4079 waiting for input. (Bug#10169)
4080
73d6c093
EZ
40812011-11-30 Eli Zaretskii <eliz@gnu.org>
4082
4083 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4084 verifies glyph row's hash code--we have just reallocated the
4085 glyphs, so their contents can be complete garbage. (Bug#10164)
4086
febe6bea
JB
40872011-11-30 Juanma Barranquero <lekktu@gmail.com>
4088
4089 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4090
801a4313
EZ
40912011-11-30 Eli Zaretskii <eliz@gnu.org>
4092
4093 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4094 attributes are tested _before_ calling verify_row_hash, to protect
4095 against GCC re-ordering of the tests. (Bug#10164)
4096
2b56b87e
JD
40972011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4098
4099 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4100
4101 * xterm.c (handle_one_xevent): Only set async_visible and friends
4102 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4103 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4104 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4105
dbf31225
PE
41062011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4107
4108 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4109 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4110 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4111 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4112 All uses changed to use GCPRO1 etc.
4113 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4114 Revert to old implementation (i.e., before 2011-03-11).
4115
1305621b
YM
41162011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4117
4118 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4119 of scroll runs so as to avoid assigning disabled bogus rows and
4120 unnecessary graphics copy operations.
4121
8c9afb46
EZ
41222011-11-27 Eli Zaretskii <eliz@gnu.org>
4123
4124 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4125 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4126 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4127 (malloc, free, realloc, calloc): Redirect to e_* only when
4128 compiling Emacs.
4129
4130 * lisp.h (GCTYPEBITS): Move before first use.
4131 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4132 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4133 this macro definition.
4134
4135 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4136 _MSC_VER.
4137
54e9e3bf
JD
41382011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4139
6d5eb5b0
SM
4140 * gtkutil.c (xg_create_frame_widgets):
4141 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4142 present with Gtk+ 2.0.
4143
83aca1cb
PE
41442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * fileio.c (Finsert_file_contents): Undo previous change; see
4147 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4148
5b76caa4
PE
41492011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 Rename locals to avoid shadowing.
4152 * fileio.c (Finsert_file_contents):
4153 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4154 * process.c (wait_reading_process_output):
4155 Rename inner 'proc' to 'p' to avoid shadowing.
4156 Indent for consistency with usual Emacs style.
4157
8c535114
EZ
41582011-11-25 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xdisp.c (redisplay_window): If cursor row is not fully visible
4161 after recentering, and scroll-conservatively is set to a large
4162 number, scroll window by a few more lines to make the cursor fully
4163 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4164 (start_display): Don't move to the next line if the display should
4165 start at a newline that is part of a display vector or an overlay
4166 string. (Bug#10119)
8c535114 4167
fa4fdb5c
JL
41682011-11-24 Juri Linkov <juri@jurta.org>
4169
4170 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4171 after the `MagickPingImage' call. (Bug#10112)
4172
90ec88df
CY
41732011-11-23 Chong Yidong <cyd@gnu.org>
4174
4175 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4176
56e2e794
MR
41772011-11-23 Martin Rudalics <rudalics@gmx.at>
4178
4179 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4180 making another buffer current. (Bug#10114)
4181
b6e64c41
GM
41822011-11-23 Glenn Morris <rgm@gnu.org>
4183
4184 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4185
6b21de18
CY
41862011-11-23 Chong Yidong <cyd@gnu.org>
4187
4188 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4189 using it (Bug#5984).
4190
b12cd789
EZ
41912011-11-22 Eli Zaretskii <eliz@gnu.org>
4192
4193 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4194 and header-lines, as they don't have one computed for them.
4195 (Bug#10098)
4196
4197 * .gdbinit (prow): Make displayed values more self-explaining.
4198 Add row's hash code.
4199
261b6fd4
LMI
42002011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4201
4202 * process.c (wait_reading_process_output): Fix asynchrounous
4203 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4204 (wait_reading_process_output): Add comment and URL.
261b6fd4 4205
e7cfd277
JD
42062011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4207
4208 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4209
a9b9b7f5
CY
42102011-11-21 Chong Yidong <cyd@gnu.org>
4211
4212 * window.c (Fnext_window, Fprevious_window): Doc fix.
4213
b0d15b4f
SM
42142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4215
4216 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4217
fe7a3057
JB
42182011-11-20 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4221
d2999b1a
MR
42222011-11-20 Martin Rudalics <rudalics@gmx.at>
4223
4224 * window.c (Fset_window_combination_limit): Rename argument
4225 STATUS to LIMIT.
4226 (Vwindow_combination_limit): Remove "status" from doc-string.
4227
d5ff9cd0
AS
42282011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4229
4230 * m/ibms390.h: Remove.
4231 * m/ibms390x.h: Don't include "ibms390.h".
4232
a5bb9bd3
SM
42332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4234
4235 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4236 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4237
cd1181db
JB
42382011-11-20 Juanma Barranquero <lekktu@gmail.com>
4239
4240 * casetab.c (Fset_case_table):
4241 * charset.c (Fcharset_after): Fix typos.
4242
615a3b8d 42432011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4244
17e845af
PE
4245 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4246 Otherwise, valgrind does not work on some platforms.
4247 Problem reported by Andreas Schwab in
6a0bf43d
PE
4248 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4249 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4250 is set, removing the need for VIRT_ADDRESS_VARIES.
4251 (PURE_P): Use a more-efficient implementation that needs just one
4252 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4253 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4254 to 4 (xorl, subq, cmpq, setbe).
4255 * alloc.c (pure): Always extern now, since that's the
4256 VIRT_ADDR_VARIES behavior.
4257 (PURE_POINTER_P): Use a single comparison, not two, for
4258 consistency with the new puresize.h.
4259 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4260 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4261 Remove VIRT_ADDR_VARIES no longer needed.
4262
f8fe6f96
EZ
42632011-11-19 Eli Zaretskii <eliz@gnu.org>
4264
4265 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4266 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4267 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4268 behave as if the cursor position were at the window margin.
4269
4270 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4271 and the cursor position is out of bounds, behave as if the cursor
4272 position were at the window margin. (Bug#10075)
4273
df05a53c
CY
42742011-11-18 Chong Yidong <cyd@gnu.org>
4275
4276 * window.c (Fwindow_combination_limit): Make first argument
4277 non-optional, since it is meaningless for live windows like the
4278 selected window.
61ccba97 4279
2071918e
DA
42802011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4281
4282 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4283
b50a28de
SM
42842011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4285
4286 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4287 (graft_intervals_into_buffer): Simplify.
4288
015137db
EZ
42892011-11-18 Eli Zaretskii <eliz@gnu.org>
4290
4291 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4292 hash values of the two rows.
4293 (copy_row_except_pointers): Preserve the used[] arrays and the
4294 hash values of the two rows. (Bug#10035)
68c95424 4295 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4296
4297 * xdisp.c (row_hash): New function, body extracted from
4298 compute_line_metrics.
4299 (compute_line_metrics): Call row_hash, instead of computing the
4300 hash code inline.
4301
4302 * dispnew.c (verify_row_hash): Call row_hash for computing the
4303 hash code of a row, instead of duplicating code from xdisp.c.
4304
4305 * dispextern.h (row_hash): Add prototype.
4306
a2addb04
TH
43072011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4308
4309 * frame.c (delete_frame): Don't delete the terminal when the last
4310 X frame is closed if emacs is built with GTK toolkit.
4311
df85d315
JB
43122011-11-17 Juanma Barranquero <lekktu@gmail.com>
4313
4314 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4315
a0c2d0ae
MR
43162011-11-17 Martin Rudalics <rudalics@gmx.at>
4317
4318 * window.c (Vwindow_splits): Rename to
4319 Vwindow_combination_resize. Suggested by Juri Linkov.
4320 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4321 of Vwindow_splits.
4322
58179cce
JB
43232011-11-16 Juanma Barranquero <lekktu@gmail.com>
4324
7877f373
JB
4325 * nsfns.m (Fns_font_name):
4326 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4327
b6f67890
MR
43282011-11-16 Martin Rudalics <rudalics@gmx.at>
4329
4330 * window.h (window): Rename slot "nest" to "combination_limit".
4331 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4332 (Fset_window_nest): Rename to Fset_window_combination_limit.
4333 (Vwindow_nest): Rename to Vwindow_combination_limit.
4334 (recombine_windows, make_parent_window, make_window)
4335 (Fsplit_window_internal, saved_window)
4336 (Fset_window_configuration, save_window_save): Rename all
4337 occurrences of window_nest to window_combination_limit.
4338
c7015153
JB
43392011-11-15 Juanma Barranquero <lekktu@gmail.com>
4340
4341 * image.c (imagemagick_load_image): Fix typo.
4342
322ad6ec
EZ
43432011-11-14 Eli Zaretskii <eliz@gnu.org>
4344
4345 * xdisp.c (display_line): Move the call to
4346 highlight_trailing_whitespace before the call to
4347 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4348 faces of all the glyphs to compute ROW's hash value.
4349 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4350
f067b8ec
JB
43512011-11-14 Juanma Barranquero <lekktu@gmail.com>
4352
4353 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4354 just return (bug#10044).
4355
1e5b2111
EZ
43562011-11-12 Eli Zaretskii <eliz@gnu.org>
4357
7ef3cbd5
EZ
4358 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4359 with user-defined heap size. Bump the default size of the temacs
4360 heap to 27MB, to avoid memory warning when running temacs.
4361 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4362
1e5b2111
EZ
4363 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4364 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4365 (verify_row_hash) [XASSERTS]: New function.
4366 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4367 that the hash value of glyph rows is correct.
1e5b2111 4368
89d61221
MR
43692011-11-12 Martin Rudalics <rudalics@gmx.at>
4370
4371 * window.h (window): Remove splits slot.
4372 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4373 (Fdelete_other_windows_internal, make_parent_window)
4374 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4375 (Fset_window_configuration, save_window_save): Don't deal with
4376 split status of windows.
4377 (saved_window): Remove splits slot.
4378 (Vwindow_splits): Rewrite doc-string.
4379
97f18cc8
JD
43802011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4381
4382 * xfns.c (unwind_create_frame):
4383 * nsfns.m (unwind_create_frame):
4384 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4385 Vframe_list (Bug#9999).
4386
22a648b4
DA
43872011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4388
0b381c7e 4389 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4390
659afede
KH
43912011-11-11 Kenichi Handa <handa@m17n.org>
4392
4393 * callproc.c (Fcall_process): Set the member dst_multibyte of
4394 process_coding.
4395
9ac0394b
KH
43962011-11-11 Johan Bockgård <bojohan@gnu.org>
4397
4398 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4399 avoid a crash (bug#9496).
4400
2fbdc249
CY
44012011-11-09 Chong Yidong <cyd@gnu.org>
4402
4403 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4404 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4405
ac6b1f81
PE
44062011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4407
4408 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4409
09db192c
PE
44102011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 Avoid some portability problems by eschewing 'extern inline' functions.
4413 The trivial performance wins aren't worth the portability hassles; see
4414 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4415 et seq.
4416 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4417 (window_box_width, window_box_left, window_box_left_offset)
4418 (window_box_right, window_box_right_offset): Undo previous change,
4419 by removing the "extern"s.
4420 * intervals.c (adjust_intervals_for_insertion)
4421 (adjust_intervals_for_deletion): Undo previous change,
4422 making these static again.
4423 (offset_intervals, temp_set_point_both, temp_set_point)
4424 (copy_intervals_to_string): No longer inline.
4425 * xdisp.c (window_text_bottom_y, window_box_width)
4426 (window_box_height, window_box_left_offset)
4427 (window_box_right_offset, window_box_left, window_box_right)
4428 (window_box): No longer inline.
4429
105216ed
CY
44302011-11-08 Chong Yidong <cyd@gnu.org>
4431
4432 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4433 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4434 Signal an error if not a live window.
105216ed
CY
4435 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4436 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4437
ae9e237f
JB
44382011-11-07 Juanma Barranquero <lekktu@gmail.com>
4439
4440 * lisp.h (syms_of_abbrev): Remove declaration.
4441 Reported by CHENG Gao <chenggao@royau.me>.
4442
c7aa8333
EZ
44432011-11-07 Eli Zaretskii <eliz@gnu.org>
4444
4445 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4446 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4447 of temacs in GUI mode.
4448
be7f5545
MR
44492011-11-07 Martin Rudalics <rudalics@gmx.at>
4450
4451 * window.h: Declare delete_all_child_windows instead of
4452 delete_all_subwindows.
4453 * window.c (Fwindow_nest, Fset_window_nest)
4454 (Fset_window_new_total, Fset_window_new_normal)
4455 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4456 (delete_all_subwindows): Rename to delete_all_child_windows.
4457 (Fdelete_other_windows_internal, Fset_window_configuration):
4458 Call delete_all_child_windows instead of delete_all_subwindows.
4459 * frame.c (delete_frame): Call delete_all_child_windows instead
4460 of delete_all_subwindows.
4461
ca78dc43
PE
44622011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4463
4464 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4465 This is also needed for porting to any host where GC_MARK_STACK is
4466 not GC_MAKE_GCPROS_NOOPS.
4467 (which_symbols): Use it.
4468
a0241d01
KH
44692011-11-07 Kenichi Handa <handa@m17n.org>
4470
4471 * coding.c (coding_set_destination): Check coding->src_pos only
4472 when coding->src_object is a buffer (bug#9910).
4473
4474 * process.c (send_process): Set the member src_multibyte of coding
4475 to 0 (bug#9911) when sending a unibyte text.
4476
4477 * callproc.c (Fcall_process): Set the member src_multibyte of
4478 process_coding to 0 (bug#9912).
4479
a64bfdfa 44802011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4481
4482 * xmenu.c (cleanup_widget_value_tree): New function.
4483 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4484 calling free_menubar_widget_value_tree directly (Bug#9830).
4485
cb41b32a
PE
44862011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 Fix some portability problems with 'inline'.
4489 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4490 (window_box_width, window_box_left, window_box_left_offset)
4491 (window_box_right, window_box_right_offset): Declare extern.
4492 Otherwise, these inline functions do not conform to C99 and
4493 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4494 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4495 * intervals.c (adjust_intervals_for_insertion)
4496 (adjust_intervals_for_deletion): Now extern, because otherwise the
4497 extern inline functions 'offset_intervals' couldn't refer to it.
4498 (static_offset_intervals): Remove.
4499 (offset_intervals): Rewrite using the old contents of
4500 static_offset_intervals. The old version didn't conform to C99
4501 because an extern inline function contained a reference to an
4502 identifier with static linkage.
4503
b7041366
AS
45042011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4505
4506 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4507 GC.
4508
88a37c4d
EZ
45092011-11-06 Eli Zaretskii <eliz@gnu.org>
4510
4511 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4512 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4513 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4514 return Qleft_to_right.
4515
49745b39
CY
45162011-11-06 Chong Yidong <cyd@gnu.org>
4517
4518 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4519 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4520 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4521 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4522 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4523 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4524 (Fwindow_vscroll): Doc fix.
4525 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4526 argument, since it makes no sense to pass a live window and for
4527 consistency with window-child.
4528
1f05cd82
CS
45292011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4530
4531 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4532 support MSVC.
4533
22610910
JR
45342011-11-05 Jason Rumney <jasonr@gnu.org>
4535
4536 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4537 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4538 fonts (Bug#6029).
4539 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4540 bitwise arithmetic preventing use of unicode-sip and non-truetype
4541 opentype fonts.
4542
a06776b2
EZ
45432011-11-05 Eli Zaretskii <eliz@gnu.org>
4544
3ad924ba
EZ
4545 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4546 "emacs"-only part.
4547
a06776b2
EZ
4548 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4549 initialization code to keep similarity to xfns.c after changes
4550 from 2011-11-05.
4551
c9e7db78
JD
45522011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4553
a97f8f3f
JD
4554 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4555 (unwind_create_frame): New function (Bug#9943).
4556 (Fx_create_frame): Restructure code to be more similar to the one in
4557 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4558 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4559 Move terminal->reference_count++ just before making the frame official
4560 (Bug#9943).
4561
4562 * nsterm.m (x_free_frame_resources): New function.
4563 (x_destroy_window): Move code to x_free_frame_resources.
4564
c9e7db78 4565 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4566 (Fx_create_frame, x_create_tip_frame):
4567 Move terminal->reference_count++ just before making the frame
75f1671a 4568 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4569 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4570
a6fc3b5c
EZ
45712011-11-05 Eli Zaretskii <eliz@gnu.org>
4572
4573 Support MSVC build with newer versions of Visual Studio.
4574 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4575 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4576 nt/gmake.defs.
4577
4578 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4579 which are not supported by MSVC.
4580 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4581 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4582 bitfields.
4583 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4584 types in bitfields.
4585 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4586
4587 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4588
58179cce 45892011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4590
4591 Support MSVC build with newer versions of Visual Studio.
4592 * w32.c: Don't include w32api.h for MSVC.
4593 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4594
4595 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4596 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4597 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4598 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4599 e_* cousins.
4600 (alloca) [_MSC_VER]: Define to _alloca.
4601
4602 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4603
4604 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4605
a58c13ed
EZ
46062011-11-04 Eli Zaretskii <eliz@gnu.org>
4607
4608 * xdisp.c (note_mouse_highlight): If either of
4609 previous/next-single-property-change returns nil, treat that as
4610 the beginning or the end of the buffer. (Bug#9955)
4611
fe0b6370
JD
46122011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4613
a58c13ed 4614 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4615 label is not null (Bug#9951).
4616 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4617 may be NULL.
4618
89bd5ee1
EZ
46192011-11-04 Eli Zaretskii <eliz@gnu.org>
4620
4621 * window.c (Fwindow_body_size): Mention in the doc string that the
4622 return value is in frame's canonical units. (Bug#9949)
4623
84c3edb9
EZ
46242011-11-03 Eli Zaretskii <eliz@gnu.org>
4625
4e2fb5c7
EZ
4626 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4627
84c3edb9 4628 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4629 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4630 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4631
bc17a887
EZ
46322011-11-01 Eli Zaretskii <eliz@gnu.org>
4633
4634 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4635 Don't stop backward scan on the continuation glyph, even though
4636 its CHARPOS is positive.
6d5eb5b0
SM
4637 (mouse_face_from_buffer_pos, note_mouse_highlight):
4638 Rename cover_string to disp_string.
bc17a887 4639
4ee88440
MR
46402011-11-01 Martin Rudalics <rudalics@gmx.at>
4641
4642 * window.c (temp_output_buffer_show): Don't use
4643 Vtemp_buffer_show_specifiers.
4644 (Vtemp_buffer_show_specifiers): Remove unused variable.
4645
c2ff3c02
EZ
46462011-10-30 Eli Zaretskii <eliz@gnu.org>
4647
4648 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4649 past the beginning of the current glyph matrix.
4650
58179cce 46512011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4652
4653 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4654 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4655 HAVE_GTK3 (Bug#9869).
b77a6a7f 4656
3b574623
JD
4657 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4658 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4659
b77a6a7f
JD
4660 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4661
4662 * xterm.c: Declare x_handle_net_wm_state to return int.
4663 (handle_one_xevent): Check if we are iconified but don't have
4664 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4665 (get_current_wm_state): Return non-zero if not hidden,
4666 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4667 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4668 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4669 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4670
196e41e4
PE
46712011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4672
4673 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4674 so that this new function doesn't get optimized away by a
4675 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4676
021f2e1a
AS
46772011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4678
4679 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4680
8b058d44
EZ
46812011-10-29 Eli Zaretskii <eliz@gnu.org>
4682
4683 Fix the `xbytecode' command.
4684 * .gdbinit (xprintbytestr): New command.
b50a28de 4685 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4686 (xbytecode): Print the byte-code string as well.
4687
4452fb80
EZ
46882011-10-29 Kim Storm <storm@cua.dk>
4689
8b058d44
EZ
4690 * alloc.c (which_symbols): New function.
4691
21b72067
AS
46922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4693
4694 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4695 line. (Bug#9903)
4696
83ed7b5c
GM
46972011-10-29 Glenn Morris <rgm@gnu.org>
4698
4699 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4700 Not clear what it was for, and it causes various bugs. (Bug#9839)
4701
5a7a728b
EZ
47022011-10-28 Eli Zaretskii <eliz@gnu.org>
4703
4704 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4705 possible random value that matches one of those tested as
4706 condition to clear the mouse face.
4707
d3d0842f
CY
47082011-10-28 Chong Yidong <cyd@gnu.org>
4709
4710 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4711
31b39d13
DN
47122011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4713
4714 * window.c (make_window): Initialize phys_cursor_on_p.
4715
9aba6043
SM
47162011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4717
4718 * lisp.h (struct Lisp_Symbol): Update comments.
4719
c20992f4
JB
47202011-10-28 Juanma Barranquero <lekktu@gmail.com>
4721
4722 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4723
db4f02f2
EZ
47242011-10-28 Eli Zaretskii <eliz@gnu.org>
4725
4726 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4727 <oslsachem@gmail.com> for helping to debug this.
4728
4729 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4730 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4731 (g_b_init_get_glyph_outline_w): New static variables.
4732 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4733 (GetGlyphOutlineW_Proc): New typedefs.
4734 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4735 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4736 New functions.
4737 (w32font_open_internal, compute_metrics):
4738 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4739 instead of calling the "wide" APIs directly.
4740
4741 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4742
4743 * w32.h (syms_of_w32font): Add prototype.
4744
87e68db4
JB
47452011-10-27 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4748 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4749 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4750 (Fmove_to_window_line): Doc fix.
4751
435c1d67
CY
47522011-10-27 Chong Yidong <cyd@gnu.org>
4753
4754 * process.c (make_process): Set gnutls_state to NULL.
4755
4756 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4757 non-NULL, regardless of GNUTLS_INITSTAGE.
4758 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4759 an error. Set process slots as soon as we allocate them.
4760
4761 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4762
9c6c6f49
CY
47632011-10-27 Chong Yidong <cyd@gnu.org>
4764
9aba6043
SM
4765 * gnutls.c (emacs_gnutls_deinit): New function.
4766 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4767 (Fgnutls_deinit, Fgnutls_boot): Use it.
4768
4769 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4770 (deactivate_process): Call emacs_gnutls_deinit.
4771
657d08d3
JB
47722011-10-27 Juanma Barranquero <lekktu@gmail.com>
4773
4774 * image.c (x_create_x_image_and_pixmap):
4775 * w32.c (sys_rename, w32_delayed_load):
4776 * w32font.c (fill_in_logfont):
4777 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4778
5430d399
JB
47792011-10-26 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * w32fns.c (w32_default_color_map): New function,
4782 extracted from Fw32_default_color_map.
a7ef684b 4783 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4784
fe0055fa
PE
47852011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4786
4787 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4788
e6346438
SM
47892011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4790
4791 * keyboard.c (test_undefined): New function (bug#9751).
4792 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4793
e112cc37
ET
47942011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4795
4796 * sysdep.c (init_sys_modes): Fix the check for the controlling
4797 terminal (Bug#6649).
4798
7b5d6677
EZ
47992011-10-20 Eli Zaretskii <eliz@gnu.org>
4800
4801 * dispextern.h (struct bidi_it): New member next_en_type.
4802
4803 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4804 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4805 current character, check also for next_en_type being WEAK_EN.
4806 (bidi_resolve_weak): Don't enter the expensive loop if the current
4807 position is before next_en_pos. Record the bidi type of the first
4808 non-ET, non-BN character we find, in addition to its position.
4809 (bidi_level_of_next_char): Invalidate next_en_type when
4810 next_en_pos is over-stepped.
4811
7da0b018
PE
48122011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4815 * editfns.c: Rewrite current-time-zone so that it invokes
4816 the equivalent of (format-time-string "%Z") to get the time zone name.
4817 This fixes a bug when the time zone name contains characters that
4818 need converting from the system time locale to Emacs internal format.
4819 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4820 that patch fixed format-time-string to do the conversion, but
4821 I forgot to fix current-time-zone.
4822 (format_time_string): New function, containing most of
4823 what Fformat_time_string used to contain.
4824 (Fformat_time_string): Rewrite in terms of format_time_string.
4825 This doesn't change this function's behavior.
4826 (current-time-zone): Rewrite to use format_time_string.
4827 This fixes the bug reported by Michael Schierl in
4828 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4829 Jason Rumney's 2007-06-07 change worked around this bug, but
4830 didn't fix it.
4831 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4832
8547b010
EZ
48332011-10-19 Eli Zaretskii <eliz@gnu.org>
4834
4835 * xdisp.c (start_display): If the character at POS is displayed
4836 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4837 (try_window_reusing_current_matrix): If a line ends in a display
4838 vector or the next line starts in a display vector, continue
4839 redrawing the window even though the character position of
4840 start_row was reached.
8547b010
EZ
4841 (Bug#9771, part 2)
4842
4e948d15
CY
48432011-10-18 Chong Yidong <cyd@gnu.org>
4844
4845 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4846 with nobreak-char-display too.
4847
4787455f
EZ
48482011-10-18 Eli Zaretskii <eliz@gnu.org>
4849
4850 Fix part 3 of bug#9771.
4851 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4852 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4853 non-neutral characters if the current character is a paragraph
4854 separator (a.k.a. Newline). This avoids running the same
4855 expensive loop twice, once when we consume the preceding newline
4856 and the other time when the line actually needs to be displayed.
4857 Avoid the loop when we see neutrals on the base embedding level
4858 following a character whose directionality is the same as the
4859 paragraph's. This avoids running the expensive loop when a line
4860 ends in a long sequence of neutrals, like control characters.
4861 Add assertion against STRONG_AL type. Slightly rearrange code
4862 that determines the type of a neutral given the first non-neutral
4863 that follows it.
4864 (bidi_level_of_next_char): Set next_en_pos to zero when
4865 invalidating its info.
4866
2c91f553
EZ
48672011-10-17 Eli Zaretskii <eliz@gnu.org>
4868
4869 * xdisp.c (push_display_prop): Determine whether to record string
4870 or buffer position by IT->string, not by IT->method. Allow
4871 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4872 (move_it_vertically_backward): Don't look for character position
4873 immediately after the newline when in a continuation line.
4874 (Bug#9771, part 1)
2c91f553 4875
c7b08b0d
MR
48762011-10-15 Martin Rudalics <rudalics@gmx.at>
4877
4878 * window.c (coordinates_in_window): Rewrite and delabelize
4879 vertical border check. (Bug#5357) (Bug#9618)
4880
6b02f655
SM
48812011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4882
4883 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4884 errors in XSetWindowBorder (bug#9310).
4885
81d40c92
DA
48862011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4887
4888 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4889 avoid crash when xmalloc overrun checking is enabled.
4890
d4172c3b
EZ
48912011-10-13 Eli Zaretskii <eliz@gnu.org>
4892
4893 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4894 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4895 cursor motion with <left> and <right> arrow keys.
4896
4897 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4898 some callers set that themselves.
4899
b00eea75
EZ
49002011-10-12 Eli Zaretskii <eliz@gnu.org>
4901
4902 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4903 display string and the previous row comes from the same string and
4904 is empty. (Bug#9739) (Bug#9738)
4905
8fe012c4
SM
49062011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4907
4908 * doc.c (get_doc_string): Encode file name (bug#9735).
4909
0074aef2
EZ
49102011-10-12 Eli Zaretskii <eliz@gnu.org>
4911
79beb178
EZ
4912 * bidi.c (bidi_level_of_next_char):
4913 * xdisp.c (get_visually_first_element): Remove old incorrect
4914 comments regarding the Unicode Line Separator character.
4915
0074aef2
EZ
4916 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4917
6e4b3fbe
DA
49182011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4919
4920 * alloc.c (Fgc_status): Do not access beyond zombies array
4921 boundary if nzombies > MAX_ZOMBIES.
4922 * alloc.c (dump_zombies): Add missing format specifier.
4923
0324f3af
PE
49242011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4925
b5525cac
PE
4926 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4927 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4928
0324f3af
PE
4929 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4930 Some packages use them to denote characters with modifiers.
4931
e9b5f888
AS
49322011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4933
4934 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4935 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4936 matching a pp-number. Rename parameter var to var1.
4937
127827c0
SM
49382011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4939
4940 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4941
c8fd3bd0
GM
49422011-10-08 Glenn Morris <rgm@gnu.org>
4943
4944 * callint.c (Fcall_interactively): Give a more explicit error for the
4945 'c' case with a non-character input. (Bug#8479)
4946
352ec8ff
EZ
49472011-10-08 Eli Zaretskii <eliz@gnu.org>
4948
03669ccb
EZ
4949 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4950 lines.
7061c986
EZ
4951 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4952 lines that are hscrolled on the left.
03669ccb 4953
352ec8ff
EZ
4954 * dispnew.c (buffer_posn_from_coords): Account for a possible
4955 presence of header-line. (Bug#4426)
4956
a66cfb1c
SM
49572011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4958
6b02f655
SM
4959 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4960 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4961
7c5ee88e
PE
49622011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4963
4964 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4965 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4966 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4967 this makes Emacs dump core during garbage collection on rare
4968 occasions. sizeof is obviously inferior to offsetof here, so
4969 stick with offsetof.
4970 (GC_POINTER_ALIGNMENT): New macro.
4971 (mark_memory): Omit 3rd (offset) arg; caller changed.
4972 Don't assume EMACS_INT alignment is the same as pointer alignment.
4973
df1bbe5b
SM
49742011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4975
4976 * keyboard.c (read_key_sequence_remapped): New var.
4977 (read_key_sequence): Compute remapping in the right buffer.
4978 (command_loop_1): Use read_key_sequence's remapping directly.
4979
51553db6
SM
49802011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4981
32c1fffd
SM
4982 * dired.c (file_name_completion): Don't expand file name.
4983 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4984 before checking file name handler.
4985
51553db6
SM
4986 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4987 they've been requested explicitly (bug#9591).
4988
b6bd1599 49892011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4990
4991 * keymap.c (Fsingle_key_description): Use make_specified_string
4992 instead of build_string to build string from push_key_description.
4993 (Bug#5193)
4994
f701dc2a
PE
49952011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4996
4222c55d
PE
4997 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4998 This fixes a Y2038 bug on 64-bit hosts.
4999 * buffer.c (reset_buffer):
5000 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5001 (Fclear_buffer_auto_save_failure):
5002 Use 0, not -1, to represent an unset failure time, since time_t
5003 might not be signed.
5004
f701dc2a
PE
5005 Remove dependency on glibc malloc internals.
5006 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5007 Move back here from lisp.h, but with their new implementations.
5008 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5009 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5010 * charset.c (charset_table_init): New static var.
5011 (syms_of_charset): Use it instead of xmalloc. This removes a
5012 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5013 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5014 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5015 Move back to alloc.c.
5016 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5017 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5018
9ceebf39
JD
50192011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5020
5021 * nsterm.m (windowDidResize): Call x_set_window_size only when
5022 ns_in_resize is true. Otherwise set pixelwidth/height and
5023 call change_frame_size (Bug#9628).
5024
cb993c58
PE
50252011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5026
3930c88b
PE
5027 Port --enable-checking=all to Fedora 14 x86-64.
5028 * charset.c (syms_of_charset): Also account for glibc malloc's
5029 internal overhead when calculating the initial malloc maximum.
5030
cb993c58
PE
5031 Port --enable-checking=all to Fedora 14 x86.
5032 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5033 Move to lisp.h.
5034 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5035 (overrun_check_realloc, overrun_check_free):
5036 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5037 That way, xmalloc returns a properly-aligned pointer even if
5038 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5039 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5040 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5041 into account when calculating the initial malloc maximum.
5042 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5043 Move here from alloc.c, so that charset.c can use it too.
5044 Properly align; the old code wasn't right for common 32-bit hosts
5045 when configured with --enable-checking=all.
5046 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5047 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5048
31bed486
EZ
50492011-09-29 Eli Zaretskii <eliz@gnu.org>
5050
04c70788 5051 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5052 use EDOM.
5053
fbcaa2f3
EZ
50542011-09-28 Eli Zaretskii <eliz@gnu.org>
5055
5056 * xdisp.c (compute_display_string_end): If there's no display
5057 string at CHARPOS, return -1.
5058
5059 * bidi.c (bidi_fetch_char): When compute_display_string_end
5060 returns a negative value, treat the character as a normal
5061 character not covered by a display string. (Bug#9624)
5062
a239d4e9
JB
50632011-09-28 Juanma Barranquero <lekktu@gmail.com>
5064
5065 * lread.c (Fread_from_string): Fix typo in docstring.
5066
88652fd5
EZ
50672011-09-27 Eli Zaretskii <eliz@gnu.org>
5068
5069 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5070 newline, reseat the iterator instead of bidi-iterating there one
5071 character at a time. (Bug#9610)
32c1fffd
SM
5072 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5073 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5074
ed497dd4
AS
50752011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5076
5077 * lread.c (readevalloop): Use correct code for NBSP.
5078 (read1): Likewise. (Bug#9608)
5079
b2bf61aa
MA
50802011-09-25 Michael Albinus <michael.albinus@gmx.de>
5081
5082 * dbusbind.c (Fdbus_register_signal): When service is not
5083 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5084
32bbb17c
GM
50852011-09-25 Glenn Morris <rgm@gnu.org>
5086
5087 * buffer.c (truncate-lines): Doc fix.
5088
94e0933e
CY
50892011-09-24 Chong Yidong <cyd@stupidchicken.com>
5090
5091 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5092 (Fset_window_next_buffers): Doc fix.
5093
cddde921
GM
50942011-09-24 Glenn Morris <rgm@gnu.org>
5095
5096 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5097
1260aef1
PE
50982011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5099
25b4bfa0
PE
5100 Fix minor problems found by static checking.
5101 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5102 * indent.c (Fvertical_motion): Fix == vs = typo.
5103
e3cbd34b
EZ
51042011-09-24 Eli Zaretskii <eliz@gnu.org>
5105
a66cfb1c
SM
5106 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5107 Default value is now t. Doc fix.
6bf7006f 5108
e3cbd34b 5109 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5110 logic when moving up, not only when moving down. Fix the
e3cbd34b 5111 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5112 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5113
5114 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5115 CHARPOS is covered by a display string which includes newlines.
5116 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5117 is covered by a display string with embedded newlines.
5118
a3de0cbd
MA
51192011-09-24 Michael Albinus <michael.albinus@gmx.de>
5120
5121 * dbusbind.c (Fdbus_register_signal): Add match rule to
5122 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5123 (Fdbus_register_method, Vdbus_registered_objects_table):
5124 Fix docstring.
a3de0cbd 5125
b260039d
JM
51262011-09-24 Jim Meyering <meyering@redhat.com>
5127
32c1fffd 5128 do not ignore write error for any output size
b260039d
JM
5129 The previous change was incomplete.
5130 While it makes emacs --batch detect the vast majority of stdout
5131 write failures, errors were still ignored whenever the output size is
5132 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5133 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5134 && echo FAIL: ignored write error
5135 FAIL: ignored write error
5136 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5137 && echo FAIL: ignored write error
5138 FAIL: ignored write error
5139 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5140
8eca8a7c
AS
51412011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5142
5143 * emacs.c (Fkill_emacs): In noninteractive mode exit
5144 non-successfully if a write error occurred on stdout. (Bug#9574)
5145
3341db62
EZ
51462011-09-21 Eli Zaretskii <eliz@gnu.org>
5147
5148 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5149 the xassert test.
5150
5151 * dispextern.h (struct it): Update the comment documenting what
5152 can it->OBJECT be.
5153
8c203dbf
EZ
51542011-09-20 Eli Zaretskii <eliz@gnu.org>
5155
5156 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5157 a display string, extend search for cursor position to end of row.
5158 (find_row_edges): If the row ends in a newline from a display
5159 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5160 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5161 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5162 non-empty line. Fixes confusing cursor motion with arrow keys at
5163 the beginning of a line that starts with whitespace.
8c203dbf 5164
a4824228
LMI
51652011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5166
5167 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5168 (bug#9493).
5169
33ed493b
CY
51702011-09-18 Chong Yidong <cyd@stupidchicken.com>
5171
5172 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5173 boolean (Bug#9154).
5174
56cd55c8
EZ
51752011-09-18 Eli Zaretskii <eliz@gnu.org>
5176
5177 * xdisp.c (display_line): Record maximum and minimum buffer
5178 positions even if no glyphs were produced (e.g., by a zero-width
5179 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5180 buffer positions that will be removed from the glyph row because
5181 they don't fit.
c02dcedf
EZ
5182 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5183 column is beyond frame width: don't subtract 1 "pixel" when
5184 computing width of the stretch.
3e62b7e0
EZ
5185 (reseat_at_next_visible_line_start): Undo the change made on
5186 2011-09-17 that saved paragraph information and restored it after
5187 the call to `reseat'. (Bug#9545)
56cd55c8 5188
5ed99d36 51892011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5190
5191 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5192 and turn window cursor on if cleared (Bug#9415).
5193
5ed99d36 51942011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5195
5196 * search.c (boyer_moore): Take unibyte characters from pattern
5197 literally. (Bug#9458)
5198
9bade7b2
EZ
51992011-09-18 Eli Zaretskii <eliz@gnu.org>
5200
5201 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5202
e5e9d610
PE
52032011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5204
87e4427a
PE
5205 Fix minor problem found by static checking.
5206 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5207 initialized, to pacify gcc -Wuninitialized.
5208
e5e9d610
PE
5209 * fileio.c: Report proper errno when syscall falls.
5210 (Finsert_file_contents): Save and restore errno,
5211 so that report_file_error outputs the correct diagnostic.
5212 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5213
a1674f0b
EZ
52142011-09-18 Eli Zaretskii <eliz@gnu.org>
5215
5216 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5217
fbfb6dd4
EZ
52182011-09-17 Eli Zaretskii <eliz@gnu.org>
5219
5220 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5221 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5222
bb187662
EZ
52232011-09-17 Eli Zaretskii <eliz@gnu.org>
5224
1137e8b8 5225 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5226 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5227
5228 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5229 (bidi_find_paragraph_start): Search back for paragraph beginning
5230 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5231 (bidi_move_to_visually_next): Only trigger paragraph-related
5232 computations when the last character is a newline or at EOB, not
5233 just any NEUTRAL_B. (Bug#9470)
5234
bb187662
EZ
5235 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5236 truncated lines if point is covered by a display string. (Bug#9524)
5237
2e621251
PE
52382011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5241 (cons_to_x_long): New function.
5242 (lisp_data_to_selection_data): Use it. Correct the test for
5243 short-versus-long data; it was negated. Break out of vector
5244 loop, for efficiency, when a long datum is discovered.
5245
91a15bc6
SM
52462011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5247
5248 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5249
b41c3a35
EZ
52502011-09-16 Eli Zaretskii <eliz@gnu.org>
5251
5252 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5253 GCC PR/17406) by declaring this function with external scope.
5254
7812ba2d
PE
52552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5256
5257 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5258 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5259
cf7edc2a
AS
52602011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5261
5262 * editfns.c (Fformat): Correctly handle text properties on "%%".
5263
bd01620e
EZ
52642011-09-15 Eli Zaretskii <eliz@gnu.org>
5265
5266 * xterm.c (x_draw_composite_glyph_string_foreground):
5267 * w32term.c (x_draw_composite_glyph_string_foreground):
5268 * term.c (encode_terminal_code):
5269 * composite.c (composition_update_it, get_composition_id):
5270 * xdisp.c (get_next_display_element)
5271 (fill_composite_glyph_string): Add comments about special meaning
5272 of TAB characters in a composition.
5273
a02719a3
PE
52742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5275
5276 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5277 This occurs when processing a multibyte format.
5278 Problem reported by Wolfgang Jenker.
a02719a3 5279
72589a3c
JB
52802011-09-15 Johan Bockgård <bojohan@gnu.org>
5281
5282 * xdisp.c (try_cursor_movement): Only check for exact match if
5283 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5284
1c14176c
PE
52852011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5286
5287 Remove unused external symbols.
5288 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5289 * xdisp.c (calc_pixel_width_or_height): Now static.
5290 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5291 * indent.c (check_display_width):
5292 * w32term.c: Fix comment to match code.
5293 * xterm.c, xterm.h (x_catching_errors): Remove.
5294
d2eea5b5
PE
52952011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5296
5297 * xselect.c: Use signed conversions more consistently (Bug#9498).
5298 (selection_data_to_lisp_data): Assume incoming selection data are
5299 signed integers, not unsigned. This is to be consistent with
5300 outgoing selection data, which was modified to use signed integers
5301 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5302 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5303 expects long, not unsigned long.
5304
46888499
EZ
53052011-09-14 Eli Zaretskii <eliz@gnu.org>
5306
5307 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5308 computation of loop end. Reported by Johan Bockgård
5309 <bojohan@gnu.org>.
5310
ef8ef9fb
CY
53112011-09-13 Chong Yidong <cyd@stupidchicken.com>
5312
5313 * frame.c (Fother_visible_frames_p): Function deleted.
5314
fa819fed
EZ
53152011-09-12 Eli Zaretskii <eliz@gnu.org>
5316
5317 * indent.c (compute_motion): Process display vector front to back
5318 rather than the other way around. (Bug#2496)
5319
2ba8e008
SM
53202011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5321
5322 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5323
20f53c69
CY
53242011-09-11 Chong Yidong <cyd@stupidchicken.com>
5325
5326 * minibuf.c (Fread_from_minibuffer): Doc fix.
5327
d562d7a4
EZ
53282011-09-11 Eli Zaretskii <eliz@gnu.org>
5329
5330 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5331 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5332
1c4d7f3d
LMI
53332011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5334
5335 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5336 value for non-existent files.
5337
b885bf36
EZ
53382011-09-11 Eli Zaretskii <eliz@gnu.org>
5339
5340 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5341 set its "size" to -1. This will set the modtime_size field of
5342 the corresponding buffer to -1, which is what
5343 verify-visited-file-modtime expects for files that do not exist.
5344 (Bug#9139)
5345
6612f0bf
PE
53462011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5349 here ...
5350 * lisp.h: ... from here. push_key_description is no longer
5351 defined in keyboard.c, so its declaration should not be in
5352 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5353 logically belongs with push_key_description.
5354
dfb3f755
PE
53552011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 * buffer.h: Include <sys/types.h> instead of <time.h>.
5358 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5359 Problem reported by Herbert J. Skuhra.
5360
3134906c
LMI
53612011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5362
5363 * xml.c (parse_region): Make the parsing work for
5364 non-comment-starting XML files again (bug#9144).
5365
8d903f4e
AS
53662011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5367
5368 * image.c (gif_load): Fix calculation of bottom and right corner.
5369 (Bug#9468)
5370
80ad64f4
EZ
53712011-09-10 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5374 redisplay in small windows.
5375
208a048d
EZ
53762011-09-09 Eli Zaretskii <eliz@gnu.org>
5377
5378 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5379
9b1c252e
MR
53802011-09-08 Martin Rudalics <rudalics@gmx.at>
5381
5382 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5383 Operate on live windows only.
5384
2949f33b
JB
53852011-09-08 Juanma Barranquero <lekktu@gmail.com>
5386
5387 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5388
e08dcafd
EZ
53892011-09-07 Eli Zaretskii <eliz@gnu.org>
5390
5391 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5392 only under bidi iteration.
5393
115b96bd
JD
53942011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5395
5396 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5397
c8199d0f
PE
53982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5399
5400 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5401 Without this fix, the command to link temacs failed due to an
5402 undefined symbol __builtin_isnan. This is because
5403 /usr/include/iso/math_c99.h #defines isnan(x) to
5404 __builtin_isnan(x), but the bundled gcc, which identifies itself
5405 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5406 a __builtin_isnan.
5407 * floatfns.c (isnan): #undef, and then #define to a clone of
5408 what's in data.c.
5409 (Fisnan): Always define, since it's always available now.
5410 (syms_of_floatfns): Always define isnan at the Lisp level.
5411
e39b275c 54122011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5413
5414 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5415
b2db44d9 54162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5417
f4af5137 5418 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5419 The previous code assumed that file offsets (off_t values) fit in
5420 EMACS_INT variables, which is not true on typical 32-bit hosts.
5421 The code messed up by falsely reporting buffer overflow in cases
5422 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5423 when "big" contains more than 2**29 bytes, even though this
5424 inserts just one byte and does not overflow the buffer.
5425 (Finsert_file_contents): Store file offsets as off_t
5426 values, not as EMACS_INT values. Check for overflow when
5427 converting between EMACS_INT and off_t. When checking for
5428 buffer overflow or for overlap, take the offsets into account.
5429 Don't use EMACS_INT for small values where int suffices.
5430 When checking for overlap, fix a typo: ZV was used where
5431 ZV_BYTE was intended.
5432 (Fwrite_region): Don't assume off_t fits into 'long'.
5433 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5434
ecfc0a49
MA
54352011-09-05 Michael Albinus <michael.albinus@gmx.de>
5436
5437 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5438
6511acf2 54392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5440
0999621a 5441 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5442
5443 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5444 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5445 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5446 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5447 (modify_event_symbol): Do not assume that the length of
5448 name_alist_or_stem is safe to alloca and fits in int.
5449 (Fexecute_extended_command): Likewise for function name and binding.
5450 (Frecursion_depth): Wrap around reliably on integer overflow.
5451 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5452 since some callers pass EMACS_INT values.
5453 (Fsingle_key_description): Don't crash if symbol name contains more
5454 than MAX_ALLOCA bytes.
5455 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5456 (get_minibuffer): Arg is now EMACS_INT, not int.
5457 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5458 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5459 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5460
2be7d702
PE
5461 * dbusbind.c (signature_cat): New function.
5462 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5463 Do not overrun buffer; instead, report string overflow.
5464
9d1df220
PE
5465 * dispnew.c (add_window_display_history): Don't overrun buffer.
5466 Truncate instead; this is OK since it's just a log.
5467
33ef5c64
PE
5468 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5469 even if the time zone offset is outlandishly large.
5470 Don't mishandle offset == INT_MIN.
5471
66c6fdd5
PE
5472 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5473 when creating daemon; the previous buffer-overflow check was incorrect.
5474
d749b01b
PE
5475 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5476 which has the guts of the old verror function.
5477
b5cd1905
PE
5478 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5479 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5480
6e1a67fb
PE
5481 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5482 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5483 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5484 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5485 length of string rather than counting it via multiple sprintfs;
5486 that's simpler and more reliable.
c21721cc
PE
5487 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5488 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5489 sprintf, in case result does not fit in int.
5490
c57b67fc
PE
5491 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5492 (fontset_from_font): Print it.
5493
8a401434
PE
5494 * frame.c (tty_frame_count): Now printmax_t, not int.
5495 (make_terminal_frame, set_term_frame_name): Print it.
5496 (x_report_frame_params): In X, window IDs are unsigned long,
5497 not signed long, so print them as unsigned.
5498 (validate_x_resource_name): Check for implausibly long names,
5499 and don't assume name length fits in 'int'.
5500 (x_get_resource_string): Don't blindly alloca invocation name;
5501 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5502 not fit in int.
5503
6e1a67fb
PE
5504 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5505 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5506 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5507
0df02bf3
PE
5508 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5509 Use esprintf, not sprintf, in case result does not fit in int.
5510
48e30793
PE
5511 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5512 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5513 it as a large positive number.
5514 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5515 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5516
a66ff6d8
PE
5517 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5518 in case result does not fit in int.
5519
aca216ff
PE
5520 * print.c (float_to_string): Detect width overflow more reliably.
5521 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5522 buffer overrun. Don't assume list length fits in 'int'. Treat
5523 print length of 0 as 0, not as infinity; to be consistent with other
5524 uses of print length in this function. Don't overflow print length
5525 index. Don't assume hash table size fits in 'long', or that
5526 vectorlike size fits in 'unsigned long'.
5527
31c286f7
PE
5528 * process.c (make_process): Use printmax_t, not int, to format
5529 process-name gensyms.
5530
55e5faa1
PE
5531 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5532
80f2e268
PE
5533 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5534 to avoid potential buffer overrun.
5535
670741ab
PE
5536 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5537 if X resource line is longer than 512 bytes.
5538
b7163a50
PE
5539 * xfns.c (x_window): Make sprintf buffer a bit bigger
5540 to avoid potential buffer overrun.
5541
ae58ff1f
PE
5542 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5543
c43c8a6a
PE
5544 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5545
3f8236f4
PE
55462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5547
53e9fe90 5548 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5549 Without these, Emacs silently mishandles large integers sometimes.
5550 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5551 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5552
6511acf2
PE
5553 * xdisp.c (try_window_id): Check Emacs fixnum range before
5554 converting to 'int'.
806add1d 5555
6511acf2 5556 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5557 Check that an Emacs fixnum is in range before assigning it to 'int'.
5558 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5559 values converted from Emacs fixnums.
5560 (Frecenter): Don't wrap around a line count if it is out of 'int'
5561 range; instead, treat it as an extreme value.
5562 (Fset_window_configuration, compare_window_configurations):
5563 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5564
6511acf2
PE
5565 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5566 that can exceed INT_MAX. Check that EMACS_INT value is in range
5567 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5568 (match_limit): Don't assume that a fixnum can fit in 'int'.
5569
6511acf2 5570 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5571 exceed INT_MAX.
5572
6511acf2 5573 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5574 (Fvertical_motion): Don't wrap around LINES values that don't fit
5575 in 'int'. Instead, treat them as extreme values. This is good
5576 enough for windows, which can't have more than INT_MAX lines anyway.
5577
fcb901a7
LMI
55782011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5579
0f2f6b6d
LMI
5580 * Require libxml/parser.h to avoid compilation warning.
5581
fcb901a7
LMI
5582 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5583
5584 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5585 since this reportedly can destroy thread storage.
5586
6e20a0d4
CY
55872011-08-30 Chong Yidong <cyd@stupidchicken.com>
5588
5589 * syntax.c (find_defun_start): Update all cache variables if
5590 exiting early (Bug#9401).
5591
148ae00e
EZ
55922011-08-30 Eli Zaretskii <eliz@gnu.org>
5593
f6cfbd8f
EZ
5594 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5595
148ae00e
EZ
5596 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5597 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5598 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5599
5600 * term.c (tty_append_glyph): New function.
5601 (produce_stretch_glyph): Static function and its prototype deleted.
5602
a66cfb1c
SM
5603 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5604 Add prototypes.
148ae00e 5605
c4a07a4c
PE
56062011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5607
5608 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5609 when checking :margin (Bug#9390).
5610 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5611 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5612 so that the name doesn't mislead. All uses changed.
5613
6bc8cd65
JB
56142011-08-28 Johan Bockgård <bojohan@gnu.org>
5615
5616 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5617 set_tty_hooks.
5618
dca4927e
EZ
56192011-08-27 Eli Zaretskii <eliz@gnu.org>
5620
5621 * xdisp.c (move_it_to): Don't bail out early when reaching
5622 position beyond to_charpos, if we are scanning backwards.
5623 (move_it_vertically_backward): When DY == 0, make sure we get to
5624 the first character in the line after the newline.
5625
f2cad773
PE
56262011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5627
5628 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5629 (ccl_driver): Do not generate an out-of-range pointer.
5630 (Fccl_execute_on_string): Remove unnecessary check for
5631 integer overflow, noted by Stefan Monnier in
5632 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5633 Remove a FIXME that didn't need fixing.
5634 Simplify the newly-introduced buffer reallocation code.
5635
0cae2cdb
JB
56362011-08-27 Juanma Barranquero <lekktu@gmail.com>
5637
5638 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5639
5fc295a4 56402011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5641
70c60eb2 5642 Integer and memory overflow issues (Bug#9196).
726e0ab1 5643
d31850da
PE
5644 * doc.c (get_doc_string): Rework so that
5645 get_doc_string_buffer_size is the actual buffer size, rather than
5646 being 1 less than the actual buffer size; this makes xpalloc more
5647 convenient.
5648
a69fbedb
PE
5649 * image.c (x_allocate_bitmap_record, cache_image):
5650 * xselect.c (Fx_register_dnd_atom):
5651 Simplify previous changes by using xpalloc.
5652
fe5c5d37
PE
5653 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5654 since either will do and ptrdiff_t is convenient with xpalloc.
5655
0065d054
PE
5656 * charset.c (charset_table_size)
5657 (struct charset_sort_data.priority): Now ptrdiff_t.
5658 (charset_compare): Don't overflow if priorities differ greatly.
5659 (Fsort_charsets): Don't assume list length fits in int.
5660 Check for size-calculation overflow when allocating sort data.
5661 (syms_of_charset): Allocate an initial charset table that is
5662 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5663
5664 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5665
5666 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5667 The actual value is always <= INT_MAX, and leaving it unsigned made
5668 overflow checking harder.
5669
5670 * dispextern.h (struct glyph_matrix.rows_allocated)
5671 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5672 with xpalloc. The values are still always <= INT_MAX.
5673
5674 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5675
5676 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5677 (SAFE_NALLOCA): New macro.
5678
5679 * region-cache.c (struct boundary.pos, find_cache_boundary)
5680 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5681 (set_cache_region, invalidate_region_cache)
5682 (revalidate_region_cache, know_region_cache, region_cache_forward)
5683 (region_cache_backward, pp_cache):
5684 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5685 so that ptrdiff_t * can be passed to xpalloc.
5686 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5687 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5688 (pp_cache): Don't assume cache_len fits in int.
5689 * region-cache.h: Adjust extern decls to match.
5690
5691 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5692 EMACS_INT, since either will do, for xpalloc.
5693
5694 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5695 (xnmalloc, xnrealloc, xpalloc): New functions.
5696
726e0ab1
PE
5697 * bidi.c (bidi_shelve_header_size): New constant.
5698 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5699 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5700
51f30bc5 5701 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5702 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5703 (overlay_strings):
5704 Don't update size of array until after memory allocation succeeds,
5705 because xmalloc/xrealloc may not return.
0065d054
PE
5706 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5707 now that we have proper integer overflow checking.
5708 (record_overlay_string, overlay_strings): Catch overflows when
5709 calculating size of overlay_str_buf.
726e0ab1 5710
0065d054
PE
5711 * callproc.c (Fcall_process): Check for size overflow when
5712 calculating size of args2.
5713 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5714 Normally we prefer signed values, but sticking with ptrdiff_t would
5715 require adding more-complicated checks.
726e0ab1
PE
5716
5717 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5718 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5719 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5720 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5721
5722 * character.c (Fstring): Check for size-calculation overflow.
5723
5724 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5725 unnecessary integer overflow. Check for size overflow.
5726 (encode_coding_object): Don't update size until xmalloc succeeds.
5727
5728 * composite.c (get_composition_id): Check for overflow in glyph
5729 length calculations.
5730
5731 Integer and memory overflow fixes for display code.
5732 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5733 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5734 (scrolling_window): Check for overflow in size calculations.
5735 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5736 Don't assume glyph table len fits in int.
5737 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5738 (row_table_size): Now ptrdiff_t, not int.
5739 (scrolling_window): Avoid overflow in size calculations.
5740 Don't update size until allocation succeeds.
5741 * fns.c (concat): Check for overflow in size calculations.
5742 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5743 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5744 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5745
5746 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5747 (get_doc_string): Check for size calculation overflow.
5748 Don't update size until allocation succeeds.
5749 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5750 EMACS_INT, where ptrdiff_t will do.
5751 (Fsubstitute_command_keys): Check for string overflow.
5752
5753 * editfns.c (set_time_zone_rule): Don't assume environment length
5754 fits in int.
5755 (message_length): Now ptrdiff_t, not int.
5756 (Fmessage_box): Don't update size until allocation succeeds.
5757 Don't assume message length fits in int.
5758 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5759
0065d054
PE
5760 * emacs.c (main): Do not reallocate argv, since there is a null at
5761 the end that can be overwritten, and this way there's no need to
5762 worry about size-calculation overflow.
5763 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5764
5765 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5766 alloc succeeds.
5767 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5768
5769 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5770 (x_set_scroll_bar_width, x_figure_window_size):
5771 Check for integer overflow.
5772 (x_set_alpha): Do not assume XINT fits in int.
5773
5774 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5775 This is for the members text_lines, text_cols, total_lines, total_cols,
5776 where the system imposes an 'int' limit.
5777
5778 * fringe.c (Fdefine_fringe_bitmap):
5779 Don't update size until alloc works.
5780
5781 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5782 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5783
5784 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5785 Check for size-calculation overflow.
5786 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5787 do, as we prefer signed integers.
5788 (id_to_widget.max_size, id_to_widget.used)
5789 (xg_store_widget_in_map, xg_remove_widget_from_map)
5790 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5791 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5792 Use and return ptrdiff_t, not int.
5793 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5794 * gtkutil.h: Change prototypes to match the above.
5795
5796 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5797 are duplicate now that they've been promoted to lisp.h.
5798 (x_allocate_bitmap_record, x_alloc_image_color)
5799 (make_image_cache, cache_image, xpm_load):
5800 Don't update size until alloc is done.
5801 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5802 (x_detect_edges):
3256efce 5803 Check for size calculation overflow.
726e0ab1
PE
5804 (ct_colors_allocated_max): New constant.
5805 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5806 overflow.
3256efce 5807
726e0ab1
PE
5808 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5809 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5810 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5811 Use ptrdiff_t, not int, to count maps.
5812 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5813 calculations. Don't update size until allocation succeeds.
5814 Redo calculations to avoid overflow.
726e0ab1
PE
5815 * keyboard.h: Change prototypes to match the above.
5816
5817 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5818 to count maps.
5819 (current_minor_maps): Check for size calculation overflow.
5820 * keymap.h: Change prototypes to match the above.
5821
5822 * lread.c (read1, init_obarray): Don't update size until alloc done.
5823
5824 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5825 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5826
726e0ab1
PE
5827 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5828 Now ptrdiff_t, not int.
5829 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5830 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5831
5832 * process.c (Fnetwork_interface_list): Check for overflow
5833 in size calculation.
5834
5835 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5836
5837 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5838 overflow. Don't bother calling xmalloc when xrealloc will do.
5839
5840 * search.c (Freplace_match): Check for size calculation overflow.
5841 (Fset_match_data): Don't assume list lengths fit in 'int'.
5842
5843 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5844 for command line length. Do not attempt to address one before the
5845 beginning of an array, as that's not portable.
5846
5847 * term.c (max_frame_lines): Remove; unused.
5848 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5849 not int.
5850 (encode_terminal_code, calculate_costs): Check for size
5851 calculation overflow.
5852 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5853 table lengths and related sizes. Don't update size until alloc
5854 done. Redo calculations to avoid overflow.
5855 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5856
5857 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5858 subtracting pointers.
5859 (gobble_line): Check for overflow more carefully. Don't update size
5860 until alloc done.
5861
5862 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5863 Don't update size until alloc done.
5864 Redo size calculations to avoid overflow.
5865 Check for size calculation overflow.
0065d054 5866 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5867
5868 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5869 Use ptrdiff_t, not int, for sizes.
5870 (store_mode_line_noprop_char): Don't update size until alloc done.
5871
0065d054
PE
5872 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5873 Use ptrdiff_t, not int, for sizes.
5874 (Finternal_make_lisp_face, cache_face):
5875 Check for size calculation overflow.
5876 (cache_face): Treat size calculation overflows as if they were
5877 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5878
5879 * xfns.c (x_encode_text, x_set_name_internal)
5880 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5881 sizes, since they can exceed INT_MAX in size. Check for size
5882 calculation overflow.
5883
0065d054
PE
5884 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5885 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5886 Don't update size until alloc done.
5887
0065d054 5888 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5889 as sprintf is limited to int lengths.
1d526e2f 5890
252c5ee1
PE
5891 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5892 (X_LONG_MIN): New macros.
864d7ce7
PE
5893 Use them to make the following changes clearer.
5894 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5895 This change doesn't affect the value now, but it may help remind
5896 future maintainers not to raise the value too much later.
5897 (SELECTION_QUANTUM): Remove, replacing with ...
5898 (selection_quantum): ... new function, which avoids overflow.
5899 All uses changed.
5900 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5901 assumption that selection length fits in 'int'.
5902 (x_reply_selection_request, x_handle_selection_request)
5903 (x_get_window_property, receive_incremental_selection)
5904 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5905 (lisp_data_to_selection_data, clean_local_selection_data):
5906 Use ptrdiff_t, not int, to record length of selection.
5907 (x_reply_selection_request, x_get_window_property)
5908 (receive_incremental_selection, x_property_data_to_lisp):
5909 Redo calculations to avoid overflow.
5910 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5911 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5912 something.
5913 (x_get_window_property, receive_incremental_selection)
5914 (lisp_data_to_selection_data, x_property_data_to_lisp):
5915 Check for size-calculation overflow.
5916 (x_get_window_property, receive_incremental_selection)
5917 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5918 Don't store size until memory allocation succeeds.
5919 (x_get_window_property): Plug memory leak on memory exhaustion.
5920 Don't double-block input; malloc is safe here. Don't assume 2**34
5921 - 4 fits in unsigned long. Add an xassert to check
5922 XGetWindowProperty overflow. Be more careful about overflow
5923 calculations, and distinguish size from memory overflow better.
5924 (receive_incremental_selection): When tracing, don't assume
5925 unsigned int is less than INT_MAX.
5926 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5927 harmful) conversions of unsigned short to int.
5928 (lisp_data_to_selection_data): Don't assume that integers
5929 in the range -65535 through -1 fit in an X unsigned short.
5930 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5931 result parameters unless successful. Rely on cons_to_unsigned
5932 to report problems with elements; the old code wasn't right anyway.
5933 (x_check_property_data): Check for int overflow; we cannot use
5934 a wider type due to X limits.
5935 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5936
726e0ab1 5937 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5938
0065d054
PE
5939 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5940 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5941 (x_color_cells): Don't store size until memory allocation succeeds.
5942 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5943 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5944 (x_term_init): Don't assume length fits in int (sprintf is limited
5945 to int size).
bc18e09d 5946
ebfa62c0
PE
5947 Use ptrdiff_t for composition IDs.
5948 * character.c (lisp_string_width):
5949 * composite.c (composition_table_size, n_compositions)
5950 (get_composition_id, composition_gstring_from_id):
5951 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5952 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5953 * window.c (Frecenter):
5954 Use ptrdiff_t, not int, for composition IDs.
5955 * composite.c (get_composition_id): Check for integer overflow.
5956 * composite.h: Adjust prototypes to match the above changes.
5957
d3411f89
PE
5958 Use ptrdiff_t for hash table indexes.
5959 * category.c (hash_get_category_set):
5960 * ccl.c (ccl_driver):
5961 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5962 * coding.c (coding_system_charset_list, detect_coding_system):
5963 * coding.h (struct coding_system.id):
5964 * composite.c (get_composition_id, gstring_lookup_cache):
5965 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5966 * image.c (xpm_get_color_table_h):
5967 * lisp.h (hash_lookup, hash_put):
5968 * minibuf.c (Ftest_completion):
5969 Use ptrdiff_t for hash table indexes, not int (which is too
5970 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5971 32-bit --with-wide-int hosts).
5972
e097a6fa
PE
5973 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5974 Add a FIXME comment about memory leaks.
5975 (syms_of_charset): Don't assume xmalloc returns.
5976
5637687f
PE
5977 Don't assume that stated character widths fit in int.
5978 * character.c (Fchar_width, c_string_width, lisp_string_width):
5979 * character.h (CHAR_WIDTH):
5980 * indent.c (MULTIBYTE_BYTES_WIDTH):
5981 Use sanitize_char_width to avoid undefined and/or bad behavior
5982 with outlandish widths.
a66cfb1c 5983 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5984 now that we have two such functions. All uses changed.
5985 (sanitize_char_width): New inline function.
5986
a2271ba2
PE
5987 Don't assume that tab-width fits in int.
5988 * character.h (sanitize_width): New inline function.
5989 (SANE_TAB_WIDTH): New macro.
5990 (ASCII_CHAR_WIDTH): Use it.
5991 * indent.c (sane_tab_width): Remove. All uses replaced by
5992 SANE_TAB_WIDTH (current_buffer).
5993 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5994
18c52557
PE
5995 * fileio.c: Integer overflow issues with file modes.
5996 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5997
caeeedc1
PE
5998 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5999 Remove unreachable code.
6000 (read_hex, load_charset_map_from_file): Check for integer overflow.
6001
6df6ae42 6002 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6003 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6004 (x_send_scroll_bar_event): Likewise. Check that the size does not
6005 exceed limits imposed by XClientMessageEvent, as well as the usual
6006 ptrdiff_t and size_t limits.
6007
b13995db
PE
6008 * keyboard.c: Overflow, signedness and related fixes.
6009 (make_lispy_movement): Use same integer type in forward decl
6010 that is used in the definition.
6011 (read_key_sequence, keyremap_step):
6012 Change bufsize argument back to int, undoing my 2011-03-30 change.
6013 We prefer signed types, and int is wide enough here.
6014 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6015 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6016 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6017 length, not size_t. Use ptrdiff_t for index, not int.
6018 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6019 possibility of integer overflow.
6020
13464394
PE
6021 Overflow, signedness and related fixes for images.
6022
6023 * dispextern.h (struct it.stack[0].u.image.image_id)
6024 (struct_it.image_id, struct image.id, struct image_cache.size)
6025 (struct image_cache.used, struct image_cache.ref_count):
6026 * gtkutil.c (update_frame_tool_bar):
6027 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6028 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6029 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6030 * nsmenu.m (update_frame_tool_bar):
6031 * xdisp.c (calc_pixel_width_or_height):
6032 * xfns.c (image_cache_refcount):
6033 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6034 on typical 64-bit hosts.
6035
6036 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6037 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6038 Omit unnecessary casts to int.
6039 (parse_image_spec): Check that integers fall into 'int' range
6040 when the callers expect that.
6041 (image_ascent): Redo ascent calculation to avoid int overflow.
6042 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6043 (lookup_image): Remove unnecessary tests.
6044 (xbm_image_p): Locals are now of int, not EMACS_INT,
6045 since parse_image_check makes sure they fit into int.
6046 (png_load, gif_load, svg_load_image):
6047 Prefer int to unsigned where either will do.
6048 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6049 old tiff_error_handler and tiff_warning_handler.
6050 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6051 stack buffer overflows. It uses only the features of vsnprintf
6052 that are common to both POSIX and native Microsoft.
6053 (tiff_error_handler, tiff_warning_handler): Use it.
6054 (tiff_load, gif_load, imagemagick_load_image):
6055 Don't assume :index value fits in 'int'.
6056 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6057 (imagemagick_load_image): Check that crop parameters fit into
6058 the integer types that MagickCropImage accepts. Don't assume
6059 Vimagemagick_render_type has a nonnegative value. Don't assume
6060 size_t fits in 'long'.
6061 (gs_load): Use printmax_t to print the widest integers possible.
6062 Check for integer overflow when computing image height and width.
6063
c11821d4
EZ
60642011-08-26 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (redisplay_window): Don't force window start if point
6067 will be invisible in the resulting window. (Bug#9324)
6068
0c95fcf7
EZ
60692011-08-25 Eli Zaretskii <eliz@gnu.org>
6070
6071 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6072 the display spec is of the form `(space ...)'.
6073 (handle_display_spec): Return the value returned by
6074 handle_single_display_spec, not just 1 or zero.
6075 (handle_single_display_spec): If the display spec is of the form
6076 `(space ...)', and specifies display in the text area, return 2
6077 rather than 1.
fee65a97 6078 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6079 accurately, and prefer exact match for point under bidi.
6080 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6081
6082 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6083 into disp_prop; all users changed.
6084
6085 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6086 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6087 for the text covered by the display property.
6088
e4ed06f1
CY
60892011-08-25 Chong Yidong <cyd@stupidchicken.com>
6090
6091 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6092 Change return value to nil.
6093 (Frecord_buffer): Delete unused function.
6094
f67cdd7f
EZ
60952011-08-24 Eli Zaretskii <eliz@gnu.org>
6096
5980d4c6
EZ
6097 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6098 buffers, return left-to-right.
8610fe8b
EZ
6099 (set_cursor_from_row): Consider candidate row a win if its glyph
6100 represents a newline and point is on that newline. Fixes cursor
6101 positioning on the newline at EOL of R2L text within L2R
6102 paragraph, and vice versa.
6103 (try_cursor_movement): Check continued rows, in addition to
6104 continuation rows. Fixes unwarranted scroll when point enters a
6105 continued line of R2L text within an L2R paragraph, or vice versa.
6106 (cursor_row_p): Consider the case of point being equal to
6107 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6108 from the end of a short line to the beginning of a continued line
6109 of R2L text within L2R paragraph.
6110 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6111 composed characters.
5980d4c6 6112
f67cdd7f
EZ
6113 * bidi.c (bidi_check_type): Use xassert.
6114 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6115 members.
6116
bca633fb
EZ
61172011-08-23 Eli Zaretskii <eliz@gnu.org>
6118
6119 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6120 a character.
6121
4a5885a7
CY
61222011-08-23 Chong Yidong <cyd@stupidchicken.com>
6123
6124 * nsfont.m (ns_otf_to_script): Fix typo.
6125
0902a04e
KH
61262011-08-22 Kenichi Handa <handa@m17n.org>
6127
6128 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6129 extra slot even if the purpose is char-code-property-table.
6130
1a2e6670
EZ
61312011-08-23 Eli Zaretskii <eliz@gnu.org>
6132
8ddde651
EZ
6133 * xdisp.c (redisplay_window): When computing centering_position,
6134 account for the height of the header line. (Bug#8874)
6135
425cc014
EZ
6136 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6137 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6138 candidate is selected by the mouse, and that candidate has a
6139 composed character under the mouse.
6140
1a2e6670
EZ
6141 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6142 coordinates reported by pos-visible-in-window-p for a composed
6143 character in column zero.
6144
8b76d6f8
SM
61452011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6146
6147 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6148
dac347dd
EZ
61492011-08-22 Eli Zaretskii <eliz@gnu.org>
6150
6151 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6152 consider it a hit if to_charpos is anywhere in the range of the
6153 composed buffer positions.
6154
e013fb34
CY
61552011-08-22 Chong Yidong <cyd@stupidchicken.com>
6156
6157 * image.c (gif_load): Don't assume that each subimage has the same
6158 dimensions as the base image. Handle disposal method that is
6159 "undefined" by the gif spec (Bug#9335).
6160
bd1ba3e8
CY
61612011-08-20 Chong Yidong <cyd@stupidchicken.com>
6162
6163 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6164 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6165
54a1215b
EZ
61662011-08-19 Eli Zaretskii <eliz@gnu.org>
6167
823564e5
EZ
6168 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6169 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6170 from an Org mode buffer to a Speedbar frame.
6171
54a1215b
EZ
6172 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6173 a composition, take its buffer position from IT->cmp_it.charpos.
6174 Fixes cursor positioning at the beginning of a line that begins
6175 with a composed character.
6176
9778ebcc
EZ
61772011-08-18 Eli Zaretskii <eliz@gnu.org>
6178
0be6ee06
EZ
6179 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6180 character bidirectional type, use STRONG_L instead. Fixes crashes
6181 in a buffer produced by `describe-categories'.
6182
9778ebcc
EZ
6183 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6184 members before the level stack, so they would be saved and
6185 restored when copying iterator state. Fixes incorrect reordering
6186 around TABs covered by display properties.
6187
156bffbe
AS
61882011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6189
6b02f655 6190 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6191
72ad093b
CY
61922011-08-17 Chong Yidong <cyd@stupidchicken.com>
6193
6194 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6195 (internal_condition_case_2, internal_condition_case_n):
6196 Remove unnecessary aborts (Bug#9081).
72ad093b 6197
35774242
EZ
61982011-08-17 Eli Zaretskii <eliz@gnu.org>
6199
6200 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6201 has no `load' handler, try opening the file locally. (Bug#9311)
6202
db76dd85
KB
62032011-08-16 Ken Brown <kbrown@cornell.edu>
6204
6205 * gmalloc.c: Expand comment.
6206
b215eee5
EZ
62072011-08-16 Eli Zaretskii <eliz@gnu.org>
6208
6209 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6210 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6211
a4579d33
KB
62122011-08-16 Ken Brown <kbrown@cornell.edu>
6213
6214 Fix memory allocation problems in Cygwin build (Bug#9273).
6215
6216 * unexcw.c ( __malloc_initialized): Declare external variable.
6217 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6218
8b76d6f8
SM
6219 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6220 New variables.
a4579d33
KB
6221 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6222 dumped emacs.
6223 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6224 in the static heap.
6225 [CYGWIN] (special_realloc): New function.
6226 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6227 requests to realloc storage in the static heap.
6228
3ebec551
PE
62292011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6230
6231 * bidi.c (bidi_initialize): Remove unused local.
6232
9fd8be00
EZ
62332011-08-15 Eli Zaretskii <eliz@gnu.org>
6234
6b02f655
SM
6235 * bidimirror.h:
6236 * biditype.h: Remove file.
6237 * makefile.w32-in ($(BLD)/bidi.$(O)):
6238 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6239
6240 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6241
6242 * chartab.c: Improve commentary for the uniprop_table API.
6243
32413314
EZ
6244 * bidi.c (bidi_paragraph_init): Support zero value of
6245 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6246 (bidi_initialize): Use uniprop_table instead of including
6247 biditype.h and bidimirror.h.
32413314 6248
9fd8be00
EZ
6249 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6250 coordinates of the iterator when restoring from ppos_it.
6251 (Bug#9296)
6252
5cf2b69b
KH
62532011-08-14 Kenichi Handa <handa@m17n.org>
6254
6255 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6256 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6257
daf17d00
EZ
62582011-08-14 Eli Zaretskii <eliz@gnu.org>
6259
6260 * xdisp.c (move_it_in_display_line_to): Don't invoke
6261 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6262 ppos_it. Fixes vertical cursor motion when line beginning is
6263 covered by an image. (Bug#9296)
6264
08e3161a
JD
62652011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6266
6267 * nsterm.h (ns_run_ascript): Declare.
6268 (NSAPP_DATA2_RUNASSCRIPT): Define.
6269
6270 * nsfns.m (as_script, as_result, as_status): New static variables.
6271 (ns_run_ascript): New function.
5e617bc2 6272 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6273 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6274 the event loop. Get status from as_status (Bug#7276).
6275
6276 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6277 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6278 the event loop (Bug#7276).
6279
a3720aa2
AS
62802011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6281
6282 * gnutls.c (QCgnutls_bootprop_priority)
6283 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6284 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6285 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6286 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6287 (QCgnutls_bootprop_verify_hostname_error)
6288 (QCgnutls_bootprop_callbacks_verify): Rename from
6289 Qgnutls_bootprop_..., all uses changed.
6290
6291 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6292 uses changed.
6293
0a0d27fb
PE
62942011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6295
19d5c50c
PE
6296 * xfaces.c (Qframe_set_background_mode): Now static.
6297 * dispextern.h (Qframe_set_background_mode): Remove decl.
6298
0a0d27fb
PE
6299 * process.c (Fnetwork_interface_info): Declare local only if needed.
6300
377538cb
JD
63012011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6302
6303 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6304 (Fnetwork_interface_list): Allocate in increments of bytes instead
6305 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6306 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6307 sockaddr.
6308 (struct ifflag_def): notrailers is smart on OSX.
6309 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6310 Get hardware address with getifaddrs if available.
6311
08fff70c
EZ
63122011-08-12 Eli Zaretskii <eliz@gnu.org>
6313
6314 * xdisp.c (iterate_out_of_display_property): xassert that
6315 IT->position is set to within IT->object's boundaries. Break from
6316 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6317 when IT->position is set up wrongly due to some bug.
6318 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6319 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6320 entry. Force push_it to save on the stack the current
6321 buffer/string position, to be restored by pop_it. Fix flags in
6322 the iterator structure wrt the object coming from a display
6323 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6324 properties. (Bug#9284)
6325
7be1c708 63262011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6327
7be1c708
CY
6328 * fontset.c (fontset_get_font_group): Add proper type checks.
6329 (Bug#9172)
aac0c6e3 6330
7be1c708 63312011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6332
7be1c708
CY
6333 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6334 and LC_VERSION_MIN_MACOSX.
6335 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6336 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6337
97bb72a6
EZ
63382011-08-08 Eli Zaretskii <eliz@gnu.org>
6339
6340 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6341 no-display-properties-and-no-overlays under bidi display.
6342 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6343 properties and overlays.
97bb72a6 6344
d5617611
CY
63452011-08-08 Chong Yidong <cyd@stupidchicken.com>
6346
37e11a63
CY
6347 * editfns.c (Fset_time_zone_rule): Document relationship with the
6348 setenv function.
6349
d5617611
CY
6350 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6351 the font entity extracted from the cache (Bug#8109).
6352
58872834
CY
63532011-08-07 Chong Yidong <cyd@stupidchicken.com>
6354
6355 * composite.c (autocmp_chars): Don't reset point. That is done by
6356 restore_point_unwind (Bug#5984).
6357
75bfc667
JL
63582011-08-07 Juri Linkov <juri@jurta.org>
6359
6360 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6361 to show the arg `TIME' instead of `TIMEVAL'.
6362
d1410150
EZ
63632011-08-06 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6366 display property strides EOL and includes a newline, as in
6367 longlines-mode. (Bug#9254)
75b771e4
EZ
6368 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6369 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6370
6371 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6372 is non-zero, even if the data buffer is NULL. Fixes a crash in
6373 vertical-motion with longlines-mode. (Bug#9254)
6374
35928349
EZ
63752011-08-05 Eli Zaretskii <eliz@gnu.org>
6376
ec7cc85b
EZ
6377 * bidi.c <bidi_cache_total_alloc>: Now static.
6378 (bidi_initialize): Initialize bidi_cache_total_alloc.
6379
8b76d6f8 6380 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6381 cache. (Bug#9221)
6382
6383 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6384 amount allocated this far in `bidi_cache_total_alloc'.
6385 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6386 non-zero, only free the data buffer without restoring the cache
6387 contents. All callers changed.
6388
6389 * dispextern.h (bidi_unshelve_cache): Update prototype.
6390
6391 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6392 (move_it_in_display_line, move_it_to)
6393 (move_it_vertically_backward, move_it_by_lines): Replace the call
6394 to xfree to an equivalent call to bidi_unshelve_cache.
6395 (move_it_in_display_line_to): Fix logic of returning
412b6358 6396 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6397
e2e2423b
EZ
63982011-08-05 Eli Zaretskii <eliz@gnu.org>
6399
6400 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6401 came from a string character with a `cursor' property. (Bug#9229)
6402
ae9e757a
JD
64032011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6404
6405 * Makefile.in (LIB_PTHREAD): New variable.
6406 (LIBES): Add LIB_PTHREAD (Bug#9216).
6407
6408 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6409 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6410
213bd7f2
AS
64112011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6412
6b02f655 6413 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6414
99aaf75f
JD
64152011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6416
6417 * xterm.c (x_find_topmost_parent): New function.
6418 (x_set_frame_alpha): Find topmost parent window with
6419 x_find_topmost_parent and set the property there also (bug#9181).
6420 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6421
c74e9d86
PE
64222011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 * callproc.c (Fcall_process): Avoid vfork clobbering
6425 the local vars buffer, coding_systems, current_dir.
6426
640c8776
SM
64272011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6428
6429 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6430
f26d0e4c
PE
64312011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6432
8a10d76c
PE
6433 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6434 so that it is not optimized away.
6435
f26d0e4c
PE
6436 * xdisp.c (compute_display_string_pos): Remove unused local.
6437
55439c61
EZ
64382011-08-02 Eli Zaretskii <eliz@gnu.org>
6439
6440 Fix slow cursor motion and scrolling in large buffers with
6441 selective display, like Org Mode buffers. (Bug#9218)
6442
6443 * dispextern.h (struct bidi_it): New member disp_prop_p.
6444
6445 * xdisp.c: Remove one-slot cache of display string positions.
6446 (compute_display_string_pos): Accept an additional argument
5e617bc2 6447 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6448 for a display string or property. If found, set DISP_PROP_P
6449 non-zero.
6450
6451 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6452 DISP_PROP_P, and pass it to compute_display_string_pos.
6453 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6454 non-zero. All callers of bidi_fetch_char changed.
6455
fb33fa43
SM
64562011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6457
6458 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6459
b099e063
DM
64602010-12-03 Don March <don@ohspite.net>
6461
6462 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6463 last character M-[char] is translated to ESC [char] (bug#7541).
6464
5cc7f7af
KH
64652011-08-02 Kenichi Handa <handa@m17n.org>
6466
d0fffa3f 6467 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6468
6469 * chartab.c (uniprop_table): Make it non-static.
6470
525d5e6e
EZ
64712011-08-01 Eli Zaretskii <eliz@gnu.org>
6472
6473 * xdisp.c (forward_to_next_line_start): Accept additional argument
6474 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6475 on the newline.
6476 (reseat_at_next_visible_line_start): Use the bidi iterator state
6477 returned by forward_to_next_line_start to restore the state of
6478 it->bidi_it after backing up to previous newline. (Bug#9212)
6479
31011111
AS
64802011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6481
6482 * regex.c (re_comp): Protoize.
6483 (re_exec): Fix return type.
6484 (regexec): Fix type of `ret'. (Bug#9203)
6485
476371c4
PE
64862011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6487
e5d76069
PE
6488 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6489 This is needed if max-image-size is a floating-point number.
6490
9a79b20c
AS
64912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6492
6493 * print.c (print_object): Print empty symbol as ##.
6494
6495 * lread.c (read1): Read ## as empty symbol.
6496
d8c2fa78
AA
64972011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6498
6499 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6500 setting frame foreground color (Bug#9175).
6501 (x_set_background_color): Likewise.
6502
ffe57a7a
AA
6503 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6504 contents (Bug#9176).
6505 (EmacsTooltip -init): Remove bezels and add shadows to
6506 tooltip windows.
6507
bf3492a5
AA
6508 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6509 or scroll bar (Bug#8470).
6510
d55e9c53
AA
6511 * nsfont.m (nsfont_open): Remove assignment to voffset and
6512 unnecessary vars hshink, expand, hd, full_height, min_height.
6513 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6514
6515 * nsterm.h (nsfont_info): Remove voffset field.
6516
d8c2fa78 65172011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6518
6519 Implement strike-through and overline on NextStep (Bug#8863).
6520
6521 * nsfont.m (nsfont_open): Use underline position provided by font,
6522 instead of hard-coded value of 2.
6523 (nsfont_draw): Call ns_draw_text_decoration instead.
6524
6525 * nsterm.h: Add declaration for ns_draw_text_decoration.
6526
6527 * nsterm.m (ns_draw_text_decoration): New function for drawing
6528 underline, overline, and strike-through.
6529 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6530 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6531 accommodate underlining, etc.
4843aac3 6532
4cc60b9b
EZ
65332011-07-28 Eli Zaretskii <eliz@gnu.org>
6534
bc7ece87
EZ
6535 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6536 default.
4cc60b9b 6537
476371c4
PE
65382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6539
66606eea
PE
6540 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6541 Without this fix, if a signal arrives just after memory fills up,
6542 'malloc' might be invoked reentrantly.
6543
476371c4
PE
6544 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6545 In other words, assume that every image size is allowed, on non-X
6546 hosts. This assumption is probably wrong, but it lets Emacs compile.
6547
f3fcc40d
AS
65482011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6549
6550 * regex.c (re_iswctype): Convert return values to boolean.
6551
350c992f
EZ
65522011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6553
6554 * xdisp.c (compute_display_string_pos): Don't use cached display
6555 string position if the buffer had its restriction changed.
6556 (Bug#9184)
6557
5266b4bb
PE
65582011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6559
6560 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6561
2573a837 65622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6563
41f55ccd 6564 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6565
39e378da
PE
6566 * bidi.c: Integer size and overflow fixes.
6567 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6568 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6569 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6570 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6571 (bidi_find_other_level_edge):
6572 Use ptrdiff_t instead of EMACS_INT where either will do.
6573 This works better on 32-bit hosts configured --with-wide-int.
6574 (bidi_cache_ensure_space): Check for size-calculation overflow.
6575 Use % rather than repeated addition, for better worst-case speed.
6576 Don't set bidi_cache_size until after xrealloc returns, because it
6577 might not return.
6578 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6579 (bidi_cache_ensure_space): Also check that the bidi cache size
6580 does not exceed that of the largest Lisp string or buffer. See Eli
6581 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6582
5e927815
PE
6583 * alloc.c (__malloc_size_t): Remove.
6584 All uses replaced by size_t. See Andreas Schwab's note
6585 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6586
ca4aa935
PE
6587 * image.c: Improve checking for integer overflow.
6588 (check_image_size): Assume that f is nonnull, since
6589 it is always nonnull in practice. This is one less thing to
6590 worry about when checking for integer overflow later.
6591 (x_check_image_size): New function, which checks for integer
6592 overflow issues inside X.
6593 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6594 This removes the need for a memory_full check.
6595 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6596 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6597 (xbm_read_bitmap_data): Change locals back to 'int', since
6598 their values must fit in 'int'.
6599 (xpm_load_image, png_load, tiff_load):
6600 Invoke x_create_x_image_and_pixmap earlier,
6601 to avoid much needless work if the image is too large.
6602 (tiff_load): Treat overly large images as if
6603 x_create_x_image_and_pixmap failed, not as malloc failures.
6604 (gs_load): Use x_check_image_size.
6605
5f8f9cc2
PE
6606 * gtkutil.c: Omit integer casts.
6607 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6608 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6609
5adf60bc
PE
6610 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6611
c8907a93
PE
6612 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6613 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6614 would wrongly return t on a 64-bit host.
6615
e3c25c68
PE
6616 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6617 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6618 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6619 and therefore cause GCC to emit a bogus diagnostic in some cases.
6620
3f791afe
PE
6621 * image.c: Integer signedness and overflow and related fixes.
6622 This is not an exhaustive set of fixes, but it's time to
6623 record what I've got.
6624 (lookup_pixel_color, check_image_size): Remove redundant decls.
6625 (check_image_size): Don't assume that arbitrary EMACS_INT values
6626 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6627 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6628 (tiff_load, imagemagick_load_image):
6629 Check for overflow in size calculations.
6630 (x_create_x_image_and_pixmap): Remove unnecessary test for
6631 xmalloc returning NULL; that can't happen.
6632 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6633 (xpm_color_bucket): Use better integer hashing function.
6634 (xpm_cache_color): Don't possibly over-allocate memory.
6635 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6636 (gif_memory_source):
6637 Use ptrdiff_t, not int or size_t, to record sizes.
6638 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6639 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6640 either works, as we prefer signed integers.
6641 (tiff_read_from_memory, tiff_write_from_memory):
6642 Return tsize_t, not size_t, since that's what the TIFF API wants.
6643 (tiff_read_from_memory): Don't fail simply because the read would
6644 go past EOF; instead, return a short read.
6645 (tiff_load): Omit no-longer-needed casts.
6646 (Fimagemagick_types): Don't assume size fits into 'int'.
6647
3cc5a532
PE
6648 Improve hashing quality when configured --with-wide-int.
6649 * fns.c (hash_string): New function, taken from sxhash_string.
6650 Do not discard information about ASCII character case; this
6651 discarding is no longer needed.
6652 (sxhash-string): Use it. Change sig to match it. Caller changed.
6653 * lisp.h: Declare it.
6654 * lread.c (hash_string): Remove, since we now use fns.c's version.
6655 The fns.c version returns a wider integer if --with-wide-int is
6656 specified, so this should help the quality of the hashing a bit.
6657
b312a492
PE
6658 * emacs.c: Integer overflow minor fix.
6659 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6660 Define only if GNU_LINUX.
6661 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6662
dfd153ae
PE
6663 * dispnew.c: Integer signedness and overflow fixes.
6664 Remove unnecessary forward decls, that were a maintenance hassle.
6665 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6666 All uses changed.
6667 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6668 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6669 (prepare_desired_row, line_draw_cost):
6670 Use int, not unsigned, where either works.
6671 (save_current_matrix, restore_current_matrix):
6672 Use ptrdiff_t, not size_t, where either works.
6673 (init_display): Check for overflow more accurately, and without
6674 relying on undefined behavior.
6675
a81d11a3
PE
6676 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6677 Remove, replacing with the new symbols in lisp.h. All uses changed.
6678 * fileio.c (make_temp_name):
6679 * filelock.c (lock_file_1, lock_file):
6680 * xdisp.c (message_dolog):
6681 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6682 Use pMd etc. instead.
6683 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6684 replacing the pWIDE etc. symbols removed from editfns.c.
6685
3300e6fd
PE
6686 * keyboard.h (num_input_events): Now uintmax_t.
6687 This is (very slightly) less likely to mess up due to wraparound.
6688 All uses changed.
6689
fd05c7e9
PE
6690 * buffer.c: Integer signedness fixes.
6691 (alloc_buffer_text, enlarge_buffer_text):
6692 Use ptrdiff_t rather than size_t when either will do, as we prefer
6693 signed integers.
6694
903fe15d
PE
6695 * alloc.c: Integer signedness and overflow fixes.
6696 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6697 (__malloc_size_t): Default to size_t, not to int.
6698 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6699 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6700 Prefer ptrdiff_t to size_t when either would do, as we prefer
6701 signed integers.
6702 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6703 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6704 Now const. Initialize with values that are in range even if char
6705 is signed.
6706 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6707 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6708 These functions do the right thing with sizes > 2**32.
6709 (check_depth): Now ptrdiff_t, not int.
6710 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6711 Adjust to new way of storing sizes. Check for size overflow bugs
6712 in rest of code.
6713 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6714 slightly wrong anyway, as it missed one instance of
6715 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6716 (refill_memory_reserve): Omit needless cast to size_t.
6717 (mark_object_loop_halt): Mark as externally visible.
6718
ac82cc6a
PE
6719 * xselect.c: Integer signedness and overflow fixes.
6720 (Fx_register_dnd_atom, x_handle_dnd_message):
6721 Use ptrdiff_t, not size_t, since we prefer signed.
6722 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6723 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6724 x_dnd_atoms_size and x_dnd_atoms_length.
6725
c2d1e36d
PE
6726 * doprnt.c: Prefer signed to unsigned when either works.
6727 * eval.c (verror):
6728 * doprnt.c (doprnt):
6729 * lisp.h (doprnt):
6730 * xdisp.c (vmessage):
6731 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6732 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6733 prefer signed arithmetic to avoid comparison confusion.
6734 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6735 but is a bit tricky.
6736
0e926e56
PE
6737 Assume freestanding C89 headers, string.h, stdlib.h.
6738 * data.c, doprnt.c, floatfns.c, print.c:
6739 Include float.h unconditionally.
6740 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6741 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6742 * regex.c: Likewise for stddef.h, string.h.
6743 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6744 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6745 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6746 (STDC_HEADERS): Remove obsolete defines.
6747 * sysdep.c: Include limits.h unconditionally.
6748
9cfdb3ec
PE
6749 Assume support for memcmp, memcpy, memmove, memset.
6750 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6751 * regex.c (memcmp, memcpy):
6752 Remove; we assume C89 now.
6753
6754 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6755 (__malloc_safe_bcopy): Remove; no longer needed.
6756
cf950e6b 6757 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6758 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6759 well either way, and we prefer signed to unsigned.
6760
dbf38e02
LMI
67612011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6762
6763 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6764 closes the connection while we're reading (bug#9182).
6765
d6f0886c 67662011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6767
d6f0886c
JD
6768 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6769 are specified (Bug#9168).
24e0f6b1 6770
2eb1f9e6
PE
67712011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6772
6773 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6774 Found by GCC static checking and --with-wide-int on a 32-bit host.
6775
22381272 67762011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6777
6778 * xdisp.c (compute_display_string_pos): Fix logic of caching
6779 previous display string position. Initialize cached_prev_pos to
6780 -1. Fixes slow-down at the beginning of a buffer.
6781
f25e39b4
EZ
67822011-07-24 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6785 for attrs[LFACE_FONTSET_INDEX].
6786
04c4b52e
PE
67872011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6788
6789 * xml.c (parse_region): Remove unused local
6790 that was recently introduced.
6791
c1734fbd
EZ
67922011-07-23 Eli Zaretskii <eliz@gnu.org>
6793
be18c5a5
EZ
6794 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6795 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6796
c1734fbd
EZ
6797 * xdisp.c (move_it_in_display_line_to): Record the best matching
6798 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6799 exit if none of the characters scanned was an exact match.
6800 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6801 when exact match is impossible due to invisible text, and the
6802 lines are truncated.
6803
a258d627
JD
68042011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6805
6806 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6807 for OSX >= 10.7.
6808
b6d5a689
EZ
68092011-07-22 Eli Zaretskii <eliz@gnu.org>
6810
0f74f785
EZ
6811 Fix a significant slow-down of cursor motion with C-n, C-p,
6812 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6813 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6814 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6815 (next_element_from_buffer): Call compute_stop_pos_backwards to
6816 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6817 base_level_stop.
6818 (reseat): Don't look for prev_stop, as that could mean a very long
6819 run.
6820 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6821 <cached_disp_overlay_modiff>: Cache for last found display string
6822 position.
551918c1 6823 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6824 about the same buffer in the same area of character positions, and
6825 the buffer wasn't changed since the time the display string
6826 position was cached.
551918c1 6827
b2d0c91a
EZ
68282011-07-22 Eli Zaretskii <eliz@gnu.org>
6829
6830 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6831 is an integer, which is important for empty lines. (Bug#9149)
6832
043604ee
CY
68332011-07-22 Chong Yidong <cyd@stupidchicken.com>
6834
6835 * frame.c (Fmodify_frame_parameters): In tty case, update the
6836 default face if necessary (Bug#4238).
6837
da4adb04
CY
68382011-07-21 Chong Yidong <cyd@stupidchicken.com>
6839
6840 * editfns.c (Fstring_to_char): No need to explain what a character
6841 is in the docstring (Bug#6576).
6842
9abd0532
LMI
68432011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6844
6845 * xml.c (parse_region): Make sure we always return a tree.
6846
36881d16
HK
68472011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6848
6849 * xml.c (parse_region): If a document contains only comments,
6850 return that, too.
6851
1e98674d
LMI
68522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6853
6854 * xml.c (make_dom): Return comments, too.
6855
590bd467
PE
68562011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6857
6858 Port to OpenBSD.
6859 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6860 and the surrounding thread.
6861 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6862 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6863 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6864 timer goes off.
6865 * s/openbsd.h (BROKEN_SIGIO): Define.
6866 * unexelf.c (unexec) [__OpenBSD__]:
6867 Don't update the .mdebug section of the Alpha COFF symbol table.
6868
f41628b2
LMI
68692011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6870
6871 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6872 (bug#8460).
6873
b59b67c5
PE
68742011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6875
15e3a074
PE
6876 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6877 This fixes some race conditions on the permissions of any newly
6878 created file.
6879
41bed37d
PE
6880 * alloc.c (valid_pointer_p): Use pipe, not open.
6881 This fixes some permissions issues when debugging.
6882
b59b67c5
PE
6883 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6884 If fchown fails to set both uid and gid, try to set just gid,
6885 as that is sometimes allowed. Adjust the file's mode to eliminate
6886 setuid or setgid bits that are inappropriate if fchown fails.
6887
925a6be7
SM
68882011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6889
6890 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6891 to compare Lisp_Objects.
6892 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6893 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6894 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6895
52968808
AS
68962011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6897
0a6a104b
AS
6898 * lread.c (read_integer): Unread even EOF character.
6899 (read1): Likewise. Properly record start position of symbol.
6900
52968808
AS
6901 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6902 symbol character follows.
6903
9e381cdd
PE
69042011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6905
6906 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6907 This works around a problem with the previous change to Fcopy_file.
6908 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6909 and without this change, GCC might complain about discarding
6910 fchown's return value.
6911
b5641435
JB
69122011-07-16 Juanma Barranquero <lekktu@gmail.com>
6913
6914 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6915
a8031457
PE
69162011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6917
6918 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6919
dd889327
LMI
69202011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6921
750c33f7
LMI
6922 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6923 it's used from the C level.
6924
dd889327
LMI
6925 * process.c: Use the same condition for POLL_FOR_INPUT in both
6926 keyboard.c and process.c (bug#1858).
6927
87e86684
LM
69282011-07-09 Lawrence Mitchell <wence@gmx.li>
6929
6930 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6931 (Fgnutls_boot): Use it.
6932
64348f40
AS
69332011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6934
6935 * doc.c (Fsubstitute_command_keys): Revert last change.
6936
1d698799
LMI
69372011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6938
f863868c
LMI
6939 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6940 quotes the next character, and doesn't affect other longer
6941 sequences (bug#8935).
6942
1d698799
LMI
6943 * lread.c (syms_of_lread): Clarify that is isn't only
6944 `eval-buffer' and `eval-defun' that's affected by
6945 `lexical-binding' (bug#8460).
6946
aa4b6df6
EZ
69472011-07-15 Eli Zaretskii <eliz@gnu.org>
6948
6949 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6950 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6951
5d856da6
PE
69522011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6953
ad6042bb
PE
6954 Fix minor problems found by static checking.
6955 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6956 (elsz): Now a signed constant, not a size_t var. We prefer signed
6957 types to unsigned, to avoid integer comparison confusion. Without
6958 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6959 "cannot optimize loop, the loop counter may overflow", a symptom
6960 of the confusion.
f00bbb22 6961 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6962 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6963
6468f31c
LMI
69642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6965
49080b10
LMI
6966 * search.c (Fre_search_backward): Mention `case-fold-search' in
6967 all the re_search_* functions (bug#8138).
6968
6468f31c
LMI
6969 * keyboard.c (Fopen_dribble_file): Document when the file is
6970 closed (bug#8056).
6971
c965adc5
EZ
69722011-07-14 Eli Zaretskii <eliz@gnu.org>
6973
df9733bf
EZ
6974 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6975 bidi_cache_idx.
6976
0bb23927
EZ
6977 Support bidi reordering of display and overlay strings.
6978 * xdisp.c (compute_display_string_pos)
6979 (compute_display_string_end): Accept additional argument STRING.
6980 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6981 (reseat_to_string): Initialize bidi_it->string.s and
6982 bidi_it->string.schars.
6983 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6984 NULL (avoids a crash in bidi_paragraph_init).
6985 Initialize itb.string.lstring.
0bb23927
EZ
6986 (init_iterator): Call bidi_init_it only of a valid
6987 buffer position was specified. Initialize paragraph_embedding to
6988 L2R.
6989 (reseat_to_string): Initialize the bidi iterator.
6990 (display_string): If we need to ignore text properties of
6991 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6992 original value of -1 will not work with bidi.)
6993 (compute_display_string_pos): First arg is now struct
6994 `text_pos *'; all callers changed. Support display properties on
6995 Lisp strings.
6996 (compute_display_string_end): Support display properties on Lisp
6997 strings.
6998 (init_iterator, reseat_1, reseat_to_string): Initialize the
6999 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7000 when iterating on a string not from display properties).
640c8776
SM
7001 (compute_display_string_pos, compute_display_string_end):
7002 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7003 arrow keys.
7004 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7005 base_level_stop; instead, set base_level_stop to BEGV.
7006 Fixes crashes in vertical-motion.
0bb23927
EZ
7007 (next_element_from_buffer): Improve commentary for when
7008 the iterator is before prev_stop.
7009 (init_iterator): Initialize bidi_p from the default value of
7010 bidi-display-reordering, not from buffer-local value. Use the
7011 buffer-local value only if initializing for buffer iteration.
7012 (handle_invisible_prop): Support invisible properties on strings
7013 that are being bidi-reordered.
7014 (set_iterator_to_next): Support bidi reordering of C strings and
7015 Lisp strings.
7016 (next_element_from_string): Support bidi reordering of Lisp
7017 strings.
7018 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7019 (display_string): Support display of R2L glyph rows.
7020 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7021 (init_iterator): Don't initialize it->bidi_p for strings
7022 here.
7023 (reseat_to_string): Initialize it->bidi_p for strings here.
7024 (next_element_from_string, next_element_from_c_string)
7025 (next_element_from_buffer): Add xassert's for correspondence
7026 between IT's object being iterated and it->bidi_it.string
7027 structure.
7028 (face_before_or_after_it_pos): Support bidi iteration.
7029 (next_element_from_c_string): Handle the case of the first string
7030 character that is not the first one in the visual order.
7031 (get_visually_first_element): New function, refactored from common
7032 parts of next_element_from_buffer, next_element_from_string, and
7033 next_element_from_c_string.
7034 (tool_bar_lines_needed, redisplay_tool_bar)
7035 (display_menu_bar): Force left-to-right direction. Add a FIXME
7036 comment for making that be controlled by a user option.
7037 (push_it, pop_it): Save and restore the state of the
7038 bidi iterator. Save and restore the bidi_p flag.
7039 (pop_it): Iterate out of display property for string iteration as
7040 well.
7041 (iterate_out_of_display_property): Support iteration over strings.
7042 (handle_single_display_spec): Set up it->bidi_it for iteration
7043 over a display string, and call bidi_init_it.
7044 (handle_single_display_spec, next_overlay_string)
7045 (get_overlay_strings_1, push_display_prop): Set up the bidi
7046 iterator for displaying display or overlay strings.
7047 (forward_to_next_line_start): Don't use the shortcut if
7048 bidi-iterating.
7049 (back_to_previous_visible_line_start): If handle_display_prop
7050 pushed the iterator stack, restore the internal state of the bidi
7051 iterator by calling bidi_pop_it same number of times.
7052 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7053 and we are bidi-iterating, don't decrement the iterator position;
7054 instead, set the first_elt flag in the bidi iterator, to produce
7055 the same effect.
7056 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7057 (push_display_prop): xassert that we are iterating a buffer.
7058 (push_it, pop_it): Save and restore paragraph_embedding member.
7059 (handle_single_display_spec, next_overlay_string)
7060 (get_overlay_strings_1, reseat_1, reseat_to_string)
7061 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7062 correctly. Don't assume unibyte strings are not bidi-reordered.
7063 (compute_display_string_pos)
7064 (compute_display_string_end): Fix handling the case of C string.
7065 (push_it, pop_it): Save and restore from_disp_prop_p.
7066 (handle_single_display_spec, push_display_prop): Set the
7067 from_disp_prop_p flag.
7068 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7069 (pop_it): Call iterate_out_of_display_property only if we are
7070 popping after iteration over a string that came from a display
7071 property. Fix a typo in popping stretch info. Add an assertion
7072 for verifying that the iterator position is in sync with the bidi
7073 iterator.
7074 (handle_single_display_spec, get_overlay_strings_1)
7075 (push_display_prop): Fix initialization of paragraph direction for
7076 string when that of the parent object is not yet determined.
7077 (reseat_1): Call bidi_init_it to resync the bidi
7078 iterator with IT's position. (Bug#7616)
7079 (find_row_edges): If ROW->start.pos gives position
7080 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7081 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7082 Reset the from_disp_prop_p flag.
7083 (SAVE_IT, RESTORE_IT): New macros.
7084 (pos_visible_p, face_before_or_after_it_pos)
7085 (back_to_previous_visible_line_start)
7086 (move_it_in_display_line_to, move_it_in_display_line)
7087 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7088 (try_scrolling, redisplay_window, display_line): Use them when
7089 saving a temporary copy of the iterator and restoring it back.
7090 (back_to_previous_visible_line_start, reseat_1)
7091 (init_iterator): Empty the bidi cache "stack".
7092 (move_it_in_display_line_to): If iterator ended up at
7093 EOL, but we never saw any buffer positions smaller than
7094 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7095 motion in bidi-reordered lines.
7096 (move_it_in_display_line_to): Record prev_method and prev_pos
7097 immediately before the call to set_iterator_to_next. Fixes cursor
7098 motion in bidi-reordered lines with stretch glyphs and strings
7099 displayed in margins. (Bug#8133) (Bug#8867)
7100 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7101 TO_CHARPOS.
640c8776
SM
7102 (pos_visible_p): Support positions in bidi-reordered lines.
7103 Save and restore bidi cache.
0bb23927
EZ
7104
7105 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7106 (bidi_paragraph_info): Delete unused struct.
7107 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7108 (bidi_cache_start): New variable.
7109 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7110 to zero.
7111 (bidi_cache_fetch_state, bidi_cache_search)
7112 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7113 (bidi_cache_find, bidi_peek_at_next_level)
7114 (bidi_level_of_next_char, bidi_find_other_level_edge)
7115 (bidi_move_to_visually_next): Compare cache index with
7116 bidi_cache_start rather than with zero.
7117 (bidi_fetch_char): Accept new argument STRING; all callers
7118 changed. Support iteration over a string. Support strings with
7119 display properties. Support unibyte strings. Fix the type of
7120 `len' according to what STRING_CHAR_AND_LENGTH expects.
7121 (bidi_paragraph_init, bidi_resolve_explicit_1)
7122 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7123 (bidi_level_of_next_char, bidi_move_to_visually_next):
7124 Support iteration over a string.
0bb23927
EZ
7125 (bidi_set_sor_type, bidi_resolve_explicit_1)
7126 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7127 can now be zero (for strings); special values 0 and -1 were
7128 changed to -1 and -2, respectively.
7129 (bidi_char_at_pos): New function.
7130 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7131 Call it instead of FETCH_MULTIBYTE_CHAR.
7132 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7133 initialized to valid values.
7134 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7135 values.
7136 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7137 the test for valid cached positions. Fix the logic for looking up
7138 the sentinel state in the cache. GCPRO the Lisp string we are
7139 iterating.
7140 (bidi_push_it, bidi_pop_it): New functions.
7141 (bidi_initialize): Initialize the bidi cache start stack pointer.
7142 (bidi_cache_ensure_space): New function, refactored from part of
7143 bidi_cache_iterator_state. Don't assume the required size is just
7144 one BIDI_CACHE_CHUNK away.
7145 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7146 (bidi_count_bytes, bidi_char_at_pos): New functions.
7147 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7148 always valid if bidi_cache_idx is valid.
7149 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7150 is valid if it's going to be used.
7151 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7152 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7153 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7154 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7155 (bidi_find_other_level_edge, bidi_cache_start_stack):
7156 All variables related to cache indices are now EMACS_INT.
c965adc5 7157
0bb23927
EZ
7158 * dispextern.h (struct bidi_string_data): New structure.
7159 (struct bidi_it): New member `string'. Make flag members be 1-bit
7160 fields, and put them last in the struct.
640c8776
SM
7161 (compute_display_string_pos, compute_display_string_end):
7162 Update prototypes.
0bb23927
EZ
7163 (bidi_push_it, bidi_pop_it): Add prototypes.
7164 (struct iterator_stack_entry): New members bidi_p,
7165 paragraph_embedding, and from_disp_prop_p.
7166 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7167 (bidi_shelve_cache, bidi_unshelve_cache):
7168 Declare prototypes.
0bb23927
EZ
7169
7170 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7171 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7172 and vector-like objects.
7173
7174 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7175 cache around display iteration.
7176
7177 * window.c (Fwindow_end, window_scroll_pixel_based)
7178 (displayed_window_lines, Frecenter): Save and restore the bidi
7179 cache around display iteration.
7180
3bbd2265
LMI
71812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7182
7183 * editfns.c (Fdelete_region): Clarify the use of the named
7184 parameters (bug#6788).
7185
adc47434
MR
71862011-07-14 Martin Rudalics <rudalics@gmx.at>
7187
7188 * indent.c (Fvertical_motion): Set and restore w->pointm when
7189 saving and restoring the window's buffer (Bug#9006).
7190
837c31f8
LMI
71912011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7192
7193 * editfns.c (Fstring_to_char): Clarify just what is returned
7194 (bug#6576). Text by Eli Zaretskii.
7195
ac389d0c
JB
71962011-07-13 Juanma Barranquero <lekktu@gmail.com>
7197
7198 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7199
0be0ce47
EZ
72002011-07-13 Eli Zaretskii <eliz@gnu.org>
7201
7202 * buffer.c (mmap_find): Fix a typo.
7203
cd18e7e3
JB
72042011-07-13 Johan Bockgård <bojohan@gnu.org>
7205
7206 Fix execution of x selection hooks.
7207 * xselect.c (Qx_lost_selection_functions)
7208 (Qx_sent_selection_functions): New vars.
7209 (syms_of_xselect): DEFSYM them.
7210 (x_handle_selection_request): Pass Qx_sent_selection_functions
7211 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7212 (x_handle_selection_clear,x_clear_frame_selections):
7213 Pass Qx_lost_selection_functions rather than
7214 Vx_lost_selection_functions to Frun_hook_with_args.
7215
47ea7f44
PE
72162011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7217
ac389d0c 7218 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7219 The old code sometimes used this field without initializing it.
7220
47ea7f44
PE
7221 * alloc.c (gc_sweep): Don't read past end of array.
7222 In theory, the old code could also have corrupted Emacs internals,
7223 though it'd be very unlikely.
7224
bc985c87
AS
72252011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7226
7227 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7228 argument. (Bug#4026)
bc985c87 7229
0cf34688
LMI
72302011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7231
b3dadd76
LMI
7232 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7233 key" (bug#4257).
7234
0cf34688
LMI
7235 * window.c (Fset_window_start): Doc fix (bug#4199).
7236 (Fset_window_hscroll): Ditto.
7237
270768cd
PE
72382011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7239
077e3dda 7240 Fix minor new problems caught by GCC 4.6.1.
270768cd 7241 * term.c (init_tty): Remove unused local.
490011a6 7242 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7243 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7244 not used otherwise.
270768cd 7245
b1f58454
CY
72462011-07-12 Chong Yidong <cyd@stupidchicken.com>
7247
7248 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7249
22b9578d
LMI
72502011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7251
6e70ab07
LMI
7252 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7253 are the mini-buffer and the echo area (bug#3320).
7254
22b9578d
LMI
7255 * term.c (init_tty): Remove support for supdup, c10 and perq
7256 terminals, which are no longer supported (bug#1482).
7257
8974cc9f
JB
72582011-07-10 Johan Bockgård <bojohan@gnu.org>
7259
7260 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7261
a560d974
JD
72622011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7263
7264 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7265 for non-popups (Bug#3642).
7266
1dae0f0a
AS
72672011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7268
268c2c36 7269 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7270 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7271 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7272 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7273 * data.c (fmod): Likewise.
7274 * dispnew.c (swap_glyphs_in_rows): Likewise.
7275 * emacs.c (memory_warning_signal): Likewise.
7276 * floatfns.c (float_error): Likewise.
7277 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7278 (otf_open, font_otf_capability, generate_otf_features)
7279 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7280 Likewise.
7281 * image.c (pbm_read_file): Likewise.
7282 * indent.c (string_display_width): Likewise.
7283 * intervals.c (check_for_interval, search_for_interval)
7284 (inc_interval_count, count_intervals, root_interval)
7285 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7286 * lread.c (defalias): Likewise.
268c2c36 7287 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7288 * regex.c (set_image_of_range_1, set_image_of_range)
7289 (regex_grow_registers): Likewise.
7290 * sysdep.c (strerror): Likewise.
7291 * termcap.c (valid_filename_p, tprint, main): Likewise.
7292 * tparam.c (main): Likewise.
7293 * unexhp9k800.c (run_time_remap, save_data_space)
7294 (update_file_ptrs, read_header, write_header, calculate_checksum)
7295 (copy_file, copy_rest, display_header): Likewise.
7296 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7297 Likewise.
7298 * xdisp.c (check_it): Likewise.
7299 * xfaces.c (register_color, unregister_color, unregister_colors):
7300 Likewise.
7301 * xfns.c (print_fontset_result): Likewise.
7302 * xrdb.c (member, fatal, main): Likewise.
7303
99033785
PE
73042011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7305
7306 Fix minor problems found by static checking (Bug#9031).
7307 * chartab.c (char_table_set_range, map_sub_char_table):
7308 Remove unused locals.
7309 (uniprop_table): Now static.
7310 * composite.c (_work_char): Remove unused static var.
7311
9cb2ac56
JB
73122011-07-09 Juanma Barranquero <lekktu@gmail.com>
7313
7314 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7315
f25661f0
JD
73162011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7317
7318 * gtkutil.c (qttip_cb): Remove code without function.
7319
8278c4fe
EZ
73202011-07-09 Eli Zaretskii <eliz@gnu.org>
7321
7322 * w32.c (pthread_sigmask): New stub.
7323
1692ae2d 73242011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7325
8a6ebd58 7326 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7327 sigprocmask is portable only for single-threaded applications, and
7328 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7329 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7330 (LIBES): Use it.
7331 * callproc.c (Fcall_process):
7332 * process.c (create_process):
7333 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7334 Use pthread_sigmask, not sigprocmask.
123403e4 7335
1b854618
JD
73362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7337
7338 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7339 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7340 wrong (Bug#8591).
7341
3fe4b549
JD
73422011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7343
0ce7e563
JD
7344 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7345 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7346 (xg_hide_tooltip): Fix comment.
7347
3fe4b549
JD
7348 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7349 in registerServicesMenuSendTypes.
7350 (validRequestorForSendType): Don't check ns_return_types.
7351
7352 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7353 ns_return_type.
7354
5df75e47
JR
73552011-07-08 Jason Rumney <jasonr@gnu.org>
7356
22610910
JR
7357 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7358 SH_SHOW for hidden windows (Bug#5482).
7359
5df75e47
JR
7360 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7361 frame struct members of non-existent frames (Bug#6284).
7362
699c10bd
JD
73632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7364
4393663b
JD
7365 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7366 variable firstTime not needed on OSX >= 10.6.
7367 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7368 >= 10.5. Use setKnobProportion, setDoubleValue.
7369
7370 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7371 (MAC_OS_X_VERSION_10_5): Define if not defined.
7372 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7373 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7374 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7375
7376 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7377 cString and lossyCString on OSX >= 10.4
7378
58179cce 7379 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7380 sizeToFit on OSX >= 10.2.
7381
7382 * nsimage.m (allocInitFromFile): Don't use deprecated method
7383 bestRepresentationForDevice on OSX >= 10.6.
7384
7385 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7386 to avoid warning.
7387
7388 * emacs.c: Declare unexec_init_emacs_zone.
7389
a63e0781
JD
7390 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7391
699c10bd
JD
7392 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7393
7394 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7395 on svcsMenu (Bug#8842).
7396
7397 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7398 ns_return_types.
7399 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7400
7401 * nsterm.m (QUTF8_STRING): Declare.
7402 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7403 (validRequestorForSendType): Return type is (id).
7404 Change indexOfObjectIdenticalTo to indexOfObject.
7405 Check if we have local selection before returning self (Bug#8842).
7406 (writeSelectionToPasteboard): Put local selection into paste board
7407 if we have a local selection (Bug#8842).
7408 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7409
7410 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7411 (ns_get_local_selection): Declare.
7412
54e10184
LMI
74132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7414
9888ff71
LMI
7415 * keymap.c (describe_map_tree): Don't insert a double newline at
7416 the end of the buffer (bug#1169) and return whether we inserted
7417 something.
7418
54e10184
LMI
7419 * callint.c (Fcall_interactively): Change "reading args" to
7420 "providing args" to try to clarify what it does (bug#1010).
7421
15fa4783
KH
74222011-07-07 Kenichi Handa <handa@m17n.org>
7423
7424 * composite.c (composition_compute_stop_pos): Ignore a static
7425 composition starting before CHARPOS (Bug#8915).
7426
7427 * xdisp.c (handle_composition_prop): Likewise.
7428
a8815b00
EZ
74292011-07-07 Eli Zaretskii <eliz@gnu.org>
7430
7431 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7432 (Bug#9015)
7433
ef7b981d 74342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7435
7436 * character.h (unicode_category_t): New enum type.
7437
7438 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7439 (Qchar_code_property_table): New variable.
7440 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7441 (UNIPROP_COMPRESSED_FORM_P): New macros.
7442 (char_table_ascii): Uncompress the compressed values.
7443 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7444 Uncompress the compressed values.
ac389d0c 7445 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7446 (char_table_ref_and_range): Uncompress the compressed values.
7447 (sub_char_table_set): New arg is_uniprop. Callers changed.
7448 Uncompress the compressed values.
7449 (sub_char_table_set_range): Args changed. Callers changed.
7450 (char_table_set_range): Adjuted for the above change.
7451 (map_sub_char_table): Delete args default_val and parent. Add arg
7452 top. Give decoded values to a Lisp function.
640c8776 7453 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7454 values to a Lisp function. Gcpro more variables.
7455 (uniprop_table_uncompress)
7456 (uniprop_decode_value_run_length): New functions.
7457 (uniprop_decoder, uniprop_decoder_count): New variables.
7458 (uniprop_get_decoder, uniprop_encode_value_character)
7459 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7460 New functions.
7461 (uniprop_encoder, uniprop_encoder_count): New variables.
7462 (uniprop_get_encoder, uniprop_table)
7463 (Funicode_property_table_internal, Fget_unicode_property_internal)
7464 (Fput_unicode_property_internal): New functions.
7465 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7466 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7467 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7468 char-code-property-alist.
7469
640c8776 7470 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7471 Vunicode_category_table.
7472
640c8776 7473 * font.c (font_range): Adjust for the change of
c805dec0
KH
7474 Vunicode_category_table.
7475
76b397fb
DN
74762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7477
7478 * m/iris4d.h: Remove file, move contents ...
7479 * s/irix6-5.h: ... here.
7480
22b4128e
PE
74812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7482
7483 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7484 * alloc.c (mark_buffer):
7485 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7486 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7487 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7488 This isn't true in general, and it's particularly not true
7489 if Emacs is configured with --with-wide-int.
7490 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7491 New macros, used in the buffer.c change.
7492
869795d6
JD
74932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7494
7495 * xsettings.c: Use both GConf and GSettings if both are available.
7496 (store_config_changed_event): Add comment.
7497 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7498 (store_tool_bar_style_changed): New functions.
5e617bc2 7499 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7500 (struct xsettings): Move font inside HAVE_XFT.
7501 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7502 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7503 Move inside HAVE_XFT.
640c8776 7504 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7505 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7506 also.
7507 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7508 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7509 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7510 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7511 (parse_settings): Move check for font inside HAVE_XFT.
7512 (read_settings, apply_xft_settings): Add comment.
7513 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7514 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7515 call store_font_name_changed.
7516 (xft_settings_event): Add comment.
7517 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7518 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7519 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7520 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7521 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7522 (xsettings_get_system_font, xsettings_get_system_normal_font):
7523 Add comment.
869795d6 7524
d8ed26bd
PE
75252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7526
7527 Random fixes. E.g., (random) never returned negative values.
7528 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7529 subseconds part to the entropy, as that's a bit more random.
7530 Prefer signed to unsigned, since the signedness doesn't matter and
7531 in general we prefer signed. When given a limit, use a
7532 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7533 latter isn't right if USE_2_TAGS_FOR_INTS.
7534 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7535 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7536
cabf1cac
SM
75372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7538
7539 * textprop.c (text_property_stickiness):
7540 Obey Vtext_property_default_nonsticky.
7541 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7542 * w32fns.c (syms_of_w32fns):
7543 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7544
6e9b2be9
PE
75452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7546
7547 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7548 This is more efficient than Ffile_directory_p and avoids a minor race.
7549
90186c68
LMI
75502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7551
7c301272
LMI
7552 * buffer.c (Foverlay_put): Say what the return value is
7553 (bug#7835).
7554
c4f2d8d4
LMI
7555 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7556 is a directory before asking whether to use the file name
7557 (bug#7564).
ad637907
LMI
7558 (barf_or_query_if_file_exists): Make the "File is a directory"
7559 error be more correct.
c4f2d8d4 7560
90186c68
LMI
7561 * fns.c (Frequire): Remove the mention of the .gz files, since
7562 that's installation-specific, but keep the mention of
7563 `get-load-suffixes'.
7564
da64016e
PE
75652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7566
7567 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7568 Report string overflow if the output is too long.
7569
7d47b580
JB
75702011-07-04 Juanma Barranquero <lekktu@gmail.com>
7571
a555cb87
JB
7572 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7573 (syms_of_gnutls): Remove duplicate DEFSYM for
7574 Qgnutls_bootprop_verify_hostname_error, an error for
7575 Qgnutls_bootprop_verify_error (which is no longer used).
7576
7d47b580
JB
7577 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7578 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7579 Also (re)move comments that are misplaced or no longer relevant.
7580
1e49bfab
LMI
75812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7582
7583 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7584
1485f4c0
CY
75852011-07-03 Chong Yidong <cyd@stupidchicken.com>
7586
7587 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7588 and background color parameters if they have been changed.
7589
a9ab721e
LMI
75902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7591
7592 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7593
cf7cff57
PE
75942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7595
2e13213d
PE
7596 * xsettings.c (SYSTEM_FONT): Define only when used.
7597 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7598
cf7cff57
PE
7599 * keymap.c (access_keymap_1): Now static.
7600
7a8e04f7
CY
76012011-07-02 Chong Yidong <cyd@stupidchicken.com>
7602
7603 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7604 leave any prefix arg for the up event (Bug#1586).
7605
61352f62
LMI
76062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7607
69bb1ef7
LMI
7608 * lread.c (syms_of_lread): Mention single symbols defined by
7609 `defvar' or `defconst' (bug#7154).
7610
61352f62 7611 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7612 (Frequire): Mention get-load-suffixes.
61352f62 7613
28545e04
MR
76142011-07-02 Martin Rudalics <rudalics@gmx.at>
7615
7616 * window.h (window): Remove clone_number slot.
7617 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7618 Remove.
7619 (make_parent_window, make_window, saved_window)
7620 (Fset_window_configuration, save_window_save): Don't deal with
7621 clone numbers.
7622 * buffer.c (Qclone_number): Remove declaration.
7623 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7624
3349e122
SM
76252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7626
7627 Add multiple inheritance to keymaps.
7628 * keymap.c (Fmake_composed_keymap): New function.
7629 (Fset_keymap_parent): Simplify.
7630 (fix_submap_inheritance): Remove.
7631 (access_keymap_1): New function extracted from access_keymap to handle
7632 embedded parents and handle lists of maps.
7633 (access_keymap): Use it.
7634 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7635 (Fcopy_keymap): Handle embedded parents.
7636 (Fcommand_remapping, define_as_prefix): Simplify.
7637 (Fkey_binding): Simplify.
7638 (syms_of_keymap): Move minibuffer-local-completion-map,
7639 minibuffer-local-filename-completion-map,
7640 minibuffer-local-must-match-map, and
7641 minibuffer-local-filename-must-match-map to Elisp.
7642 (syms_of_keymap): Defsubr make-composed-keymap.
7643 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7644 (parse_menu_item): Trivial simplification.
7645
3279eb87
GM
76462011-07-01 Glenn Morris <rgm@gnu.org>
7647
7648 * Makefile.in (SETTINGS_LIBS): Fix typo.
7649
4550efdf
KI
76502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7651
7652 * coding.c (Fencode_coding_string): Record the last coding system
7653 used, as the function doc string says (bug#8738).
7654
0949d2b6
JD
76552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7656
7657 * xsettings.c (store_monospaced_changed): Take new font as arg and
7658 check for change against current_mono_font.
7659 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7660 (emacs_settings_constructor, emacs_settings_get_property)
7661 (emacs_settings_set_property, emacs_settings_class_init)
7662 (emacs_settings_init, gsettings_obj): Remove.
7663 (something_changedCB): New function for HAVE_GSETTINGS.
7664 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7665 with value as argument.
7666 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7667 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7668 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7669 "changed".
7670
7671 * xgselect.c: Add defined (HAVE_GSETTINGS).
7672 (xgselect_initialize): Ditto.
7673
7674 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7675 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7676 xg_select.
7677
bbc6b304
PE
76782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7679
7680 * eval.c (struct backtrace): Simplify and port the data structure.
7681 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7682 signed bit field, as this assumption is not portable and it makes
7683 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7684 "char debug_on_exit : 1" as this is not portable either; instead,
7685 use the portable "unsigned int debug_on_exit : 1". Remove unused
7686 member evalargs. Remove obsolete comments about cc bombing out.
7687
9851bfc5
JD
76882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7689
51bb811f 7690 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7691 Let HAVE_GSETTINGS override HAVE_GCONF.
7692 (store_monospaced_changed): New function.
7693 (EMACS_SETTINGS): A new type derived from GObject to handle
7694 GSettings notifications.
7695 (emacs_settings_constructor, emacs_settings_get_property)
7696 (emacs_settings_set_property, emacs_settings_class_init):
7697 New functions.
7698 (gsettings_client, gsettings_obj): New variables.
7699 (GSETTINGS_SCHEMA): New define.
7700 (something_changedCB): Call store_monospaced_changed.
7701 (init_gsettings): New function.
7702 (xsettings_initialize): Call init_gsettings.
7703 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7704 to NULL.
7705
640c8776 7706 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7707 GCONF_CFLAGS/LIBS.
7708
5386012d
MR
77092011-06-29 Martin Rudalics <rudalics@gmx.at>
7710
7711 * window.c (resize_root_window, grow_mini_window)
7712 (shrink_mini_window): Rename Qresize_root_window to
7713 Qwindow_resize_root_window and Qresize_root_window_vertically to
7714 Qwindow_resize_root_window_vertically.
7715
f13e0b08
PE
77162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7717
7718 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7719
94515237
JB
77202011-06-27 Juanma Barranquero <lekktu@gmail.com>
7721
7722 * makefile.w32-in: Redesign dependencies so they reflect more
7723 clearly which files are directly included by each source file,
7724 and not through other includes.
7725
e43b6e43
MR
77262011-06-27 Martin Rudalics <rudalics@gmx.at>
7727
7728 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7729 (sort_overlays, overlay_strings): When an overlay's clone number
7730 matches the window's clone number process the overlay even if
7731 the overlay's window property doesn't match the current window.
7732
d68443dc
MR
7733 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7734 (Fwindow_hchild): Rename to Fwindow_left_child.
7735 (Fwindow_next): Rename to Fwindow_next_sibling.
7736 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7737 (resize_window_check): Rename to window_resize_check.
7738 (resize_window_apply): Rename to window_resize_apply.
7739 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7740 (Fdelete_other_windows_internal, resize_frame_windows)
7741 (Fsplit_window_internal, Fdelete_window_internal)
7742 (grow_mini_window, shrink_mini_window)
7743 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7744
c7e73be5
JD
77452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7746
7747 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7748 (emacs_fixed_set_min_size): Remove.
7749 (emacs_fixed_new): Take frame as argument.
7750
7751 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7752 (_EmacsFixedPrivate): Remove minwidth/height.
7753 Add struct frame *f.
7754 (emacs_fixed_init): Initialize priv->f.
7755 (get_parent_class, emacs_fixed_set_min_size): Remove.
7756 (emacs_fixed_new): Set priv->f to argument.
7757 (emacs_fixed_get_preferred_width)
7758 (emacs_fixed_get_preferred_height): Use min_width/height from
7759 frames size_hint to set minimum and natural (Bug#8919).
7760 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7761 and use min_width/height from frames size_hint to set
7762 min_width/height (Bug#8919).
7763
7764 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7765 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7766 Fix indentation.
c7e73be5 7767
cf99dcf8
EZ
77682011-06-26 Eli Zaretskii <eliz@gnu.org>
7769
7770 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7771 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7772 called at ZV.
7773
029529ac
CY
77742011-06-26 Chong Yidong <cyd@stupidchicken.com>
7775
7776 * process.c (wait_reading_process_output): Bypass select if
7777 waiting for a cell while ignoring keyboard input, and input is
7778 pending. Suggested by Jan Djärv (Bug#8869).
7779
7a7ef429
PE
77802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7781
7782 Use gnulib's dup2 module instead of rolling our own.
7783 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7784
11fdef7d 77852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7786
7787 * dispnew.c (scrolling_window): Before scrolling, turn off a
7788 mouse-highlight in the window being scrolled.
7789
cd3520a4
JB
77902011-06-24 Juanma Barranquero <lekktu@gmail.com>
7791
7792 Move DEFSYM to lisp.h and use everywhere.
7793
7794 * character.h (DEFSYM): Move declaration...
7795 * lisp.h (DEFSYM): ...here.
7796
7797 * gnutls.c:
7798 * minibuf.c:
7799 * w32menu.c:
7800 * w32proc.c:
7801 * w32select.c: Don't include character.h.
7802
7803 * alloc.c (syms_of_alloc):
7804 * buffer.c (syms_of_buffer):
7805 * bytecode.c (syms_of_bytecode):
7806 * callint.c (syms_of_callint):
7807 * casefiddle.c (syms_of_casefiddle):
7808 * casetab.c (init_casetab_once):
7809 * category.c (init_category_once, syms_of_category):
7810 * ccl.c (syms_of_ccl):
7811 * cmds.c (syms_of_cmds):
7812 * composite.c (syms_of_composite):
7813 * dbusbind.c (syms_of_dbusbind):
7814 * dired.c (syms_of_dired):
7815 * dispnew.c (syms_of_display):
7816 * doc.c (syms_of_doc):
7817 * editfns.c (syms_of_editfns):
7818 * emacs.c (syms_of_emacs):
7819 * eval.c (syms_of_eval):
7820 * fileio.c (syms_of_fileio):
7821 * fns.c (syms_of_fns):
7822 * frame.c (syms_of_frame):
7823 * fringe.c (syms_of_fringe):
7824 * insdel.c (syms_of_insdel):
7825 * keymap.c (syms_of_keymap):
7826 * lread.c (init_obarray, syms_of_lread):
7827 * macros.c (syms_of_macros):
7828 * msdos.c (syms_of_msdos):
7829 * print.c (syms_of_print):
7830 * process.c (syms_of_process):
7831 * search.c (syms_of_search):
7832 * sound.c (syms_of_sound):
7833 * syntax.c (init_syntax_once, syms_of_syntax):
7834 * terminal.c (syms_of_terminal):
7835 * textprop.c (syms_of_textprop):
7836 * undo.c (syms_of_undo):
7837 * w32.c (globals_of_w32):
7838 * window.c (syms_of_window):
7839 * xdisp.c (syms_of_xdisp):
7840 * xfaces.c (syms_of_xfaces):
7841 * xfns.c (syms_of_xfns):
7842 * xmenu.c (syms_of_xmenu):
7843 * xsettings.c (syms_of_xsettings):
7844 * xterm.c (syms_of_xterm): Use DEFSYM.
7845
4228cf16
TZ
78462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7847
cd3520a4 7848 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7849
7fcccf1e
PE
78502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7851
7efb4e0e
PE
7852 Integer and buffer overflow fixes (Bug#8873).
7853
ff5844ad
PE
7854 * print.c (printchar, strout): Check for string overflow.
7855 (PRINTPREPARE, printchar, strout):
7856 Don't set size unless allocation succeeds.
7857
90532f02
PE
7858 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7859 for sizes. Check for string overflow more accurately.
7860 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7861
6d84508d
PE
7862 * macros.c: Integer and buffer overflow fixes.
7863 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7864 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7865 Use ptrdiff_t, not int, for sizes.
7866 Don't increment bufsize until after realloc succeeds.
7867 Check for size-calculation overflow.
7868 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7869
437b2cb4
PE
7870 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7871
8b9ac8b4
PE
7872 * lread.c: Integer overflow fixes.
7873 (read_integer): Radix is now EMACS_INT, not int,
7874 to improve quality of diagnostics for out-of-range radices.
7875 Calculate buffer size correctly for out-of-range radices.
7876 (read1): Check for integer overflow in radices, and in
7877 read-circle numbers.
82cb60d3
PE
7878 (read_escape): Avoid int overflow.
7879 (Fload, openp, read_buffer_size, read1)
7880 (substitute_object_recurse, read_vector, read_list, map_obarray):
7881 Use ptrdiff_t, not int, for sizes.
7882 (read1): Use EMACS_INT, not int, for sizes.
20270765 7883 Check for size overflow.
8b9ac8b4 7884
7fcccf1e
PE
7885 * image.c (cache_image): Check for size arithmetic overflow.
7886
bfbbd7e7
PE
7887 * lread.c: Integer overflow issues.
7888 (saved_doc_string_size, saved_doc_string_length)
7889 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7890 Now ptrdiff_t, not int.
7891 (read1): Don't assume doc string length fits in int. Check for
7892 out-of-range doc string lengths.
7893 (read_list): Don't assume file position fits in int.
39019e54 7894 (read_escape): Check for hex character overflow.
bfbbd7e7 7895
4e323265
LL
78962011-06-22 Leo Liu <sdl.web@gmail.com>
7897
7898 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7899 Move to minibuffer.el.
7900
85fece3e
PE
79012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7902
20b84ce9 7903 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7904 The following patches are for when GLYPH_DEBUG && !XASSERT.
7905 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7906 * dispnew.c (flush_stdout):
7907 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7908 Mark as externally visible.
7909 * dispnew.c (check_window_matrix_pointers): Now static.
7910 * dispnew.c (window_to_frame_vpos):
7911 * xfns.c (unwind_create_frame):
7912 * xterm.c (x_check_font): Remove unused local.
7913 * scroll.c (CHECK_BOUNDS):
7914 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7915 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7916 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7917 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7918 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7919 Now static.
7920 (debug_method_add): Use va_list and vsprintf rather than relying
7921 on undefined behavior with wrong number of arguments.
7922 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7923 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7924 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7925 since we're not interested in debugging glyphs with old libraries.
7926 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7927 GCC 4.6.0's static checking.
7928
0766b489
PE
79292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7930
31fd4b32
PE
7931 Integer overflow and signedness fixes (Bug#8873).
7932 A few related buffer overrun fixes, too.
7933
b79e8648
PE
7934 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7935
0766b489
PE
7936 * dispextern.h (struct face.stipple):
7937 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7938 (x_bitmap_mask, x_allocate_bitmap_record)
7939 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7940 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7941 (x_create_bitmap_from_xpm_data):
7942 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7943 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7944 (.bitmaps_last):
7945 * xfaces.c (load_pixmap):
7946 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7947 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7948 (.bitmaps_last, struct x_output.icon_bitmap):
7949 Use ptrdiff_t, not int, for bitmap indexes.
7950 (x_allocate_bitmap_record): Check for size overflow.
7951 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7952
b081724f
PE
7953 Use ptrdiff_t, not int, for overlay counts.
7954 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7955 * editfns.c (overlays_around, get_pos_property):
7956 * textprop.c (get_char_property_and_overlay):
7957 * xdisp.c (next_overlay_change, note_mouse_highlight):
7958 * xfaces.c (face_at_buffer_position):
21514da7
PE
7959 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7960 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7961 (Fnext_overlay_change, Fprevious_overlay_change)
7962 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7963 Use ptrdiff_t, not int, for sizes.
21514da7 7964 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7965
3de73e5e
PE
7966 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7967
2606c57b
PE
7968 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7969 (x_session_initialize): Do not assume string length fits in int.
7970
aaafe47a
PE
7971 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7972 This is unlikely, but can occur if DPI is outlandish.
7973
2674ddc8 7974 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7975 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7976
28154962
PE
7977 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7978 * xrdb.c (magic_file_p, search_magic_path):
7979 Omit last arg SUFFIX; it was always 0. All callers changed.
7980 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7981
7de51af5
PE
7982 * xfont.c (xfont_match): Avoid need for strlen.
7983
25ed6cc3
PE
7984 * xfns.c: Don't assume strlen fits in int.
7985 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7986
4eab31dd
PE
7987 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7988 not unsigned long, as we prefer signed integers. All callers changed.
7989 Detect integer overflow in repeat count.
7990 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7991 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7992
171e2a58
PE
7993 * termcap.c: Don't assume sizes fit in int and never overflow.
7994 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7995 (gobble_line): Check for size-calculation overflow.
7996
ad39faca 7997 * minibuf.c (Fread_buffer):
6e5bb2dc 7998 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7999 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8000 Don't assume string length fits in int.
8001
52c61c22 8002 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8003 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8004
b5b8c9e5
PE
8005 * font.c: Don't assume string length fits in int.
8006 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8007 Use ptrdiff_t, not int.
ccd6111c
PE
8008 (font_intern_prop): Don't assume string length fits in int.
8009 Don't assume integer property fits in fixnum.
8010 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8011
882f0d81 8012 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8013 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8014 Reformulate so as not to need the command string.
8015 Invoke gzip -cd rather than gunzip, as it's more portable.
8016 (lock_info_type, lock_file_1, lock_file):
8017 Don't assume pid_t and time_t fit in unsigned long.
8018 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8019 (current_lock_owner): Prefer signed type for sizes.
8020 Use memcpy, not strncpy, where memcpy is what is really wanted.
8021 Don't assume (via atoi) that time_t and pid_t fit in int.
8022 Check for time_t and/or pid_t out of range, e.g., via a network share.
8023 Don't alloca where an auto var works fine.
8024
93f4cf88
PE
8025 * fileio.c: Fix some integer overflow issues.
8026 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8027 Don't assume string length fits in int.
8028 (directory_file_name): Don't assume string length fits in long.
8029 (make_temp_name): Don't assume pid fits in int, or that its print
8030 length is less than 20.
8031
f3e92b69
PE
8032 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8033
1bfdaf10
PE
8034 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8035
35016e9a
PE
8036 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8037
3d1e65a1
PE
8038 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8039 We prefer signed integers, even for size calculations.
8040
0b963a93
PE
8041 * emacs.c: Don't assume string length fits in 'int'.
8042 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8043 (main): Don't invoke strlen when not needed.
8044
573f4b54
PE
8045 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8046 (XD_DEBUG_MESSAGE): Don't waste a byte.
8047
989f33ba
PE
8048 * callproc.c (getenv_internal_1, getenv_internal)
8049 (Fgetenv_internal):
965d34eb
PE
8050 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8051
e4d29b33
PE
8052 * lread.c (invalid_syntax): Omit length argument.
8053 All uses changed. This doesn't fix a bug, but it simplifies the
8054 code away from its former Hollerith-constant appearance, and it's
8055 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8056 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8057
eb49b136
PE
8058 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8059 This didn't break anything, but it didn't help either.
8060 It's confusing to put a bogus integer in a place where the actual
8061 value does not matter.
9f62aeb1 8062 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8063 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8064
15375a22
PE
8065 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8066 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8067 implementation.
b61cc01c
PE
8068 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8069 We prefer signed types, and the value cannot exceed the EMACS_INT
8070 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8071 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8072 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8073 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8074
53b2623d
PE
8075 * indent.c (sane_tab_width): New function.
8076 (current_column, scan_for_column, Findent_to, position_indentation)
8077 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8078 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8079
51cab52b 8080 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8081
f2ed8a70
PE
8082 * lisp.h (lint_assume): New macro.
8083 * composite.c (composition_gstring_put_cache):
8084 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8085
abe80cc6
PE
8086 * editfns.c, insdel.c:
8087 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8088
b02c740e
PE
8089 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8090
ebc96716
PE
8091 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8092
b4e50fa0 8093 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8094 Use much-faster test for byte-length change.
311d5d7c 8095 Don't assume string byte-length fits in 'int'.
a4cf38e4 8096 Check that character arg fits in 'int'.
85461888 8097 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8098
c0c1ee9f
PE
8099 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8100
a498d7f4
PE
8101 * fns.c (concat): Catch string overflow earlier.
8102 Do not rely on integer wraparound.
8103
51cab52b
PE
8104 * dispextern.h (struct it.overlay_strings_charpos)
8105 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8106 * xdisp.c (forward_to_next_line_start)
8107 (back_to_previous_visible_line_start)
8108 (reseat_at_next_visible_line_start, next_element_from_buffer):
8109 Don't arbitrarily truncate the value of 'selective' to int.
8110
76031fad
PE
8111 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8112
5eb55db9
PE
8113 * composite.c: Don't truncate sizes to 'int'.
8114 (composition_gstring_p, composition_reseat_it)
8115 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8116 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8117 not EMACS_UINT, for indexes.
5eb55db9 8118
0703a717
PE
8119 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8120
d6202519
PE
8121 * buffer.c: Include <verify.h>.
8122 (struct sortvec.priority, struct sortstr.priority):
8961a454 8123 Now EMACS_INT, not int.
c20998a7 8124 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8125 (struct sortstr.size, record_overlay_string)
8126 (struct sortstrlist.size, struct sortlist.used):
8127 Don't truncate size to int.
8128 (record_overlay_string): Check for size-calculation overflow.
d6202519 8129 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8130
d5a19415
JM
81312011-06-22 Jim Meyering <meyering@redhat.com>
8132
029529ac 8133 Don't leak an XBM-image-sized buffer
d5a19415
JM
8134 * image.c (xbm_load): Free the image buffer after using it.
8135
a9041e6c
PE
81362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8137
8138 Port to Sun C.
8139 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8140 that Sun C diagnosed.
8141 * fns.c (secure_hash): Fix pointer signedness issue.
8142 * intervals.c (static_offset_intervals): New function.
8143 (offset_intervals): Use it.
8144
7f3f739f
LL
81452011-06-21 Leo Liu <sdl.web@gmail.com>
8146
8147 * deps.mk (fns.o):
8148 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8149 sha512.h.
8150
8151 * fns.c (secure_hash): Rename from crypto_hash_function and change
8152 the first arg to accept symbols.
5b66d427 8153 (Fsecure_hash): New primitive.
7f3f739f
LL
8154 (syms_of_fns): New symbols.
8155
76147d94
DD
81562011-06-20 Deniz Dogan <deniz@dogan.se>
8157
8158 * process.c (Fset_process_buffer): Clarify return value in
8159 docstring.
8160
7d7d0045
CY
81612011-06-18 Chong Yidong <cyd@stupidchicken.com>
8162
8163 * dispnew.c (add_window_display_history): Use BVAR.
8164
8165 * xdisp.c (debug_method_add): Use BVAR.
8166 (check_window_end, dump_glyph_matrix, dump_glyph)
8167 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8168
8169 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8170 Likewise.
8171
8172 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8173 check till after the cache is created in init_frame_faces.
8174
ff2bc410
SM
81752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8176
8177 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8178
28177add
PE
81792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8180
dd3482fe
PE
8181 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8182 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8183 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8184
393d71f3 8185 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8186 * fileio.c (Finsert_file_contents):
8187 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8188 Remove the old (too-loose) buffer overflow checks.
8189 They weren't needed, since make_gap checks for buffer overflow.
8190 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8191 The old code merely checked for Emacs fixnum overflow, and relied
8192 on undefined (wraparound) behavior. The new code avoids undefined
8193 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8194
2e6813b0 8195 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8196 Tune. Don't use wider integers than needed. Don't use alloca.
8197 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8198
599a9e4f
PE
8199 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8200
99561444
PE
8201 * insdel.c, lisp.h (buffer_overflow): New function.
8202 (insert_from_buffer_1, replace_range, replace_range_2):
8203 * insdel.c (make_gap_larger):
8204 * editfns.c (Finsert_char):
8205 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8206
28177add
PE
8207 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8208
e69dafad
PE
82092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8210
4baa020d 8211 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8212
b1c46f02
PE
8213 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8214 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8215
e69dafad
PE
8216 * fileio.c: Don't assume EMACS_INT fits in off_t.
8217 (emacs_lseek): New static function.
8218 (Finsert_file_contents, Fwrite_region): Use it.
8219 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8220
566684ea
PE
8221 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8222
e6966cd6
PE
8223 * fns.c: Don't overflow int when computing a list length.
8224 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8225 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8226 truncation on 64-bit hosts. Check for QUIT every
8227 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8228 faster and is responsive enough.
8229 (Flength): Report an error instead of overflowing an integer.
8230 (Fsafe_length): Return a float if the value is not representable
8231 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8232 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8233 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8234
dd0b0efb
PE
8235 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8236 (header_size, word_size): New constants.
8237 (allocate_vectorlike): Don't check size overflow here.
8238 (allocate_vector): Check it here instead, since this is the only
8239 caller of allocate_vectorlike that could cause overflow.
8240 Check that the new vector's length is representable as a fixnum.
8241
86fe5cfe
PE
8242 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8243 The previous code was bogus. For example, next_almost_prime (32)
8244 returned 39, which is undesirable as it is a multiple of 3; and
8245 next_almost_prime (24) returned 25, which is a multiple of 5 so
8246 why was the code bothering to check for multiples of 7?
8247
80e88859
PE
8248 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8249
4a2f0ad6
PE
8250 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8251
f66c7cf8
PE
8252 Variadic C functions now count arguments with ptrdiff_t.
8253 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8254 Back then I didn't know that the Emacs coding style prefers signed int.
8255 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8256 were being counted with int, which may truncate counts on 64-bit
8257 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8258 * lisp.h (struct Lisp_Subr.function.aMANY)
8259 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8260 Arg counts are now ptrdiff_t, not size_t.
8261 All variadic functions and their callers changed accordingly.
8262 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8263 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8264 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8265 * callint.c (Fcall_interactively): Check arg count for overflow,
8266 to avoid potential buffer overrun. Use signed char, not 'int',
8267 for 'varies' array, so that we needn't bother to check its size
8268 calculation for overflow.
8269 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8270 * eval.c (apply_lambda):
8271 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8272 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8273 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8274
a1759b76
PE
8275 * callint.c (Fcall_interactively): Don't use index var as event count.
8276
d96be9fc
PE
8277 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8278 * mem-limits.h (SIZE): Remove; no longer used.
8279
a690a978 8280 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8281
578c21e6
PE
8282 Remove unnecessary casts.
8283 * xterm.c (x_term_init):
8284 * xfns.c (x_set_border_pixel):
8285 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8286 These aren't needed now that we assume ANSI C.
8287
96f53c6c
PE
8288 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8289 It's more likely to cause problems (due to unsigned overflow)
8290 than to cure them.
8291
83c77d31
PE
8292 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8293
ee2079f1
PE
8294 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8295
6da65536
PE
8296 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8297
7147c4a4
PE
8298 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8299
193e32d9
PE
8300 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8301
e5533da6
PE
8302 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8303
9910e595
PE
8304 GLYPH_CODE_FACE returns EMACS_INT, not int.
8305 * dispextern.h (merge_faces):
8306 * xfaces.c (merge_faces):
01103c44
PE
8307 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8308 Don't assume EMACS_INT fits in int.
9910e595 8309
2638320e
PE
8310 * character.h (CHAR_VALID_P): Remove unused parameter.
8311 * fontset.c, lisp.h, xdisp.c: All uses changed.
8312
045eb8d9
PE
8313 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8314
c1f134b5
PE
8315 * fns.c (concat): Minor tuning based on overflow analysis.
8316 This doesn't fix any bugs. Use int to hold character, instead
8317 of constantly refetching from Emacs object. Use XFASTINT, not
8318 XINT, for value known to be a character. Don't bother comparing
8319 a single byte to 0400, as it's always less.
8320
395fcb93 8321 * floatfns.c (Fexpt):
327eeec8
PE
8322 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8323
abbd3d23
PE
8324 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8325 for characters.
8326
684a03ef
PE
8327 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8328
0fed43f3
PE
8329 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8330 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8331 incorrectly succeed when S was a string, because 4294967386 was
8332 truncated before it was used.
8333
8fd02eb7
PE
8334 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8335 Otherwise, an out-of-range integer could cause undefined behavior
8336 on a 64-bit host.
8337
f8c86b69
PE
8338 * composite.c: Use int, not EMACS_INT, for characters.
8339 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8340 EMACS_INT, for values that are known to be in character range.
8341 This doesn't fix any bugs but is the usual style inside Emacs and
8342 may generate better code on 32-bit machines.
8343
34206dd2
PE
8344 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8345 This is for reasons similar to the recent CHAR_STRING fix.
8346 * charset.c (Fencode_char): Check that character arg is actually
8347 a character. Pass an int to ENCODE_CHAR.
8348 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8349 wider than 'int', as a compile-time check to prevent future regressions
8350 in this area.
8351
c5958d4c 8352 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8353
8354 Make sure a 64-bit char is never passed to CHAR_STRING.
8355 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8356 by silently ignoring the top 32 bits, allowing some values
8357 that were far too large to be valid characters.
8358 * character.h: Include <verify.h>.
8359 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8360 arguments are no wider than unsigned, as a compile-time check
8361 to prevent future regressions in this area.
8362 * data.c (Faset):
01103c44 8363 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8364 (Fsubst_char_in_region):
8365 * fns.c (concat):
8366 * xdisp.c (decode_mode_spec_coding):
8367 Adjust to CHAR_STRING's new requirement.
8368 * editfns.c (Finsert_char, Fsubst_char_in_region):
8369 * fns.c (concat): Check that character args are actually
8370 characters. Without this test, these functions did the wrong
8371 thing with wildly out-of-range values on 64-bit hosts.
8372
d37ca623
PE
8373 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8374 These casts should not be needed on 32-bit hosts, either.
8375 * keyboard.c (read_char):
8376 * lread.c (Fload): Remove casts to unsigned.
8377
ea204efb
PE
8378 * lisp.h (UNSIGNED_CMP): New macro.
8379 This fixes comparison bugs on 64-bit hosts.
8380 (ASCII_CHAR_P): Use it.
8381 * casefiddle.c (casify_object):
01103c44 8382 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8383 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8384 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8385 * dispextern.h (FACE_FROM_ID):
8386 * keyboard.c (read_char): Use UNSIGNED_CMP.
8387
41cb286c
PE
8388 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8389 not to EMACS_INT, to avoid GCC warning.
8390
4a1b9832
PE
8391 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8392
55daad71
PE
8393 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8394 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8395 isn't needed on 32-bit machines.
8f95c75c 8396
01103c44
PE
8397 * buffer.c (Fgenerate_new_buffer_name):
8398 Use EMACS_INT for count, not int.
0ceccced 8399 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8400
8401 * data.c (Qcompiled_function): Now static.
8402
c6f072e7
PE
8403 * window.c (window_body_lines): Now static.
8404
20ce5912
PE
8405 * image.c (gif_load): Rename local to avoid shadowing.
8406
9c4c5f81
PE
8407 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8408 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8409 * alloc.c (make_save_value): Integer argument is now of type
8410 ptrdiff_t, not int.
8411 (mark_object): Use ptrdiff_t, not int.
8412 * lisp.h (pD): New macro.
8413 * print.c (print_object): Use it.
8414
c0c5c8ae
PE
8415 * alloc.c: Use EMACS_INT, not int, to count objects.
8416 (total_conses, total_markers, total_symbols, total_vector_size)
8417 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8418 (total_free_floats, total_floats, total_free_intervals)
8419 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8420 Now EMACS_INT, not int. All uses changed.
8421 (Fgarbage_collect): Compute overall total using a double, so that
8422 integer overflow is less likely to be a problem. Check for overflow
8423 when converting back to an integer.
5a25e253
PE
8424 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8425 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8426 These were 'int' variables that could overflow on 64-bit hosts;
8427 they were never used, so remove them instead of repairing them.
211a0b2a 8428 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8429 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8430 Previously, this ceilinged at INT_MAX, but that doesn't work on
8431 64-bit machines.
e46bb31a 8432 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8433
c78baabf 8434 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8435 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8436 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8437 when a (possibly-narrower) signed value would do just as well.
8438 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8439
c9d624c6
PE
8440 * alloc.c: Catch some string size overflows that we were missing.
8441 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8442 for convenience in STRING_BYTES_MAX.
8443 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8444 The definition here is exact; the one in lisp.h was approximate.
8445 (allocate_string_data): Check for string overflow. This catches
8446 some instances we weren't catching before. Also, it catches
8447 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8448 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8449 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8450
c9d624c6
PE
8451 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8452 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8453 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8454
353032ce
PE
8455 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8456
2bccce07
PE
8457 * alloc.c (Fmake_string): Check for out-of-range init.
8458
0ac30604
SM
84592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8460
8461 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8462
c195f2de
JD
84632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8464
8465 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8466 xg_get_default_scrollbar_width.
8467
8468 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8469 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8470 (style_changed_cb): Call update_theme_scrollbar_width and call
8471 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8472 all frames (Bug#8505).
8473 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8474 Call gtk_window_set_resizable if HAVE_GTK3.
8475 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8476 and height if HAVE_GTK3 (Bug#8505).
8477 (scroll_bar_width_for_theme): New variable.
8478 (update_theme_scrollbar_width): New function.
8479 (xg_get_default_scrollbar_width): Move code to
8480 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8481 (xg_initialize): Call update_theme_scrollbar_width.
8482
8483 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8484
8485 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8486
e10ac9f1
MR
84872011-06-12 Martin Rudalics <rudalics@gmx.at>
8488
8489 * frame.c (make_frame): Call other_buffer_safely instead of
8490 other_buffer.
8491
8492 * window.c (temp_output_buffer_show): Call display_buffer with
8493 second argument Vtemp_buffer_show_specifiers and reset latter
8494 immediately after the call.
8495 (Vtemp_buffer_show_specifiers): New variable.
8496 (auto_window_vscroll_p, next_screen_context_lines)
8497 (Vscroll_preserve_screen_position): Remove leading asterisks from
8498 doc-strings.
8499
2d3c217e 85002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8501
7b7f97e8 8502 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8503 * buffer.c (Qclone_number): Remove for now, as it's unused.
8504 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8505 (record_buffer): Remove unused local.
8506 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8507 (set_frame_buffer_list): Remove; unused.
8508 * frame.h (other_visible_frames): Remove decl.
8509 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8510 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8511 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8512 if HAVE_GPM.
8513 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8514 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8515 Define only if HAVE_GPM.
8516 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8517 (update_hints_inhibit): Remove; never set. All uses removed.
8518 * widgetprv.h (emacsFrameClassRec): Remove decl.
8519 * window.c (delete_deletable_window): Now returns void, since it
8520 wasn't returning anything.
8521 (compare_window_configurations): Remove unused locals.
8522 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8523 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8524 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8525 the same widths as pointers. This follows up on the 2011-05-06 patch.
8526 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8527 * xterm.h: Likewise.
8528 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8529
1384b89e
JB
85302011-06-12 Juanma Barranquero <lekktu@gmail.com>
8531
8532 * makefile.w32-in: Update dependencies.
8533 (LISP_H): Add lib/intprops.h.
8534
1100a63c
CY
85352011-06-11 Chong Yidong <cyd@stupidchicken.com>
8536
8537 * image.c (gif_load): Add animation frame delay to the metadata.
8538 (syms_of_image): Use DEFSYM. New symbol `delay'.
8539
6198ccd0
MR
85402011-06-11 Martin Rudalics <rudalics@gmx.at>
8541
8542 * window.c (delete_deletable_window): Re-add.
8543 (Fset_window_configuration): Rewrite to handle dead buffers and
8544 consequently deletable windows.
8545 (window_tree, Fwindow_tree): Remove. Supply functionality in
8546 window.el.
8547 (compare_window_configurations): Simplify code.
8548
b6e3633c
AS
85492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8550
1ab0dee5
AS
8551 * image.c (imagemagick_load_image): Fix type mismatch.
8552 (Fimagemagick_types): Likewise.
8553
b6e3633c
AS
8554 * window.h (replace_buffer_in_windows): Declare.
8555
9397e56f
MR
85562011-06-11 Martin Rudalics <rudalics@gmx.at>
8557
8558 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8559 Qclone_number. Remove external declaration of Qdelete_window.
8560 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8561 code.
640c8776
SM
8562 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8563 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8564 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8565 buffer list implementation.
8566 (other_buffer_safely): New function.
8567 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8568 calls to replace_buffer_in_windows and
8569 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8570 if allowed.
8571 (record_buffer): Inhibit quitting and rewrite using quittable
8572 functions. Run Qbuffer_list_update_hook if allowed.
8573 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8574 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8575 Move switch-to-buffer to window.el.
9397e56f
MR
8576 (bury-buffer): Move to window.el.
8577 (Vbuffer_list_update_hook): New variable.
8578
8579 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8580 section.
8581
8582 * window.h (resize_frame_windows): Move up in code.
8583 (Fwindow_frame): Remove EXFUN.
8584 (replace_buffer_in_all_windows): Remove prototype.
8585 (replace_buffer_in_windows_safely): Add prototype.
8586
8587 * window.c: Declare Qdelete_window static again. Move down
8588 declaration of select_count.
8589 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8590 (Fother_window): Move to window.el.
8591 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8592 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8593 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8594 window.el.
8595 (replace_buffer_in_windows): Implement by calling
8596 Qreplace_buffer_in_windows.
8597 (replace_buffer_in_all_windows): Remove with some functionality
8598 moved into replace_buffer_in_windows_safely.
8599 (replace_buffer_in_windows_safely): New function.
8600 (select_window_norecord, select_frame_norecord): Move in front
8601 of run_window_configuration_change_hook. Remove now obsolete
8602 declarations.
640c8776
SM
8603 (Fset_window_buffer): Rewrite doc-string.
8604 Call Qrecord_window_buffer.
9397e56f
MR
8605 (keys_of_window): Move binding for other-window to window.el.
8606
b50691aa
CY
86072011-06-11 Chong Yidong <cyd@stupidchicken.com>
8608
8609 * dispextern.h (struct image): Replace data member, whose int_val
8610 and ptr_val fields were not used by anything, with a single
8611 lisp_val object.
8612
8613 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8614 (gif_clear_image, gif_load, imagemagick_load_image)
8615 (gs_clear_image, gs_load): Callers changed.
8616
3f754b86
PE
86172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8618
cca69397
PE
8619 * buffer.h: Include <time.h>, for time_t.
8620 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8621
109e28d0
PE
8622 Fix minor problems found by static checking.
8623
60737f02
PE
8624 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8625
4b66faf3
PE
8626 Make identifiers static if they are not used in other modules.
8627 * data.c (Qcompiled_function, Qframe, Qvector):
8628 * image.c (QimageMagick, Qsvg):
8629 * minibuf.c (Qmetadata):
8630 * window.c (resize_window_check, resize_root_window): Now static.
8631 * window.h (resize_window_check, resize_root_window): Remove decls.
8632
109e28d0
PE
8633 * window.c (window_deletion_count, delete_deletable_window):
8634 Remove; unused.
46a4ce9e
PE
8635 (window_body_lines): Now static.
8636 (Fdelete_other_windows_internal): Mark vars as initialized.
8637 Make sure 'resize_failed' is initialized.
8638 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8639 (resize_window_apply): Remove unused local.
8640 * window.h (delete_deletable_window): Remove decl.
8641
109e28d0 8642 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8643 (imagemagick_load_image): Fix pointer signedness problem by changing
8644 last arg from unsigned char * to char *. All uses changed.
8645 Also, fix a local for similar reasons.
8646 Remove unused locals. Remove locals to avoid shadowing.
8647 (fn_rsvg_handle_free): Remove; unused.
8648 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8649 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8650
3f754b86
PE
8651 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8652
2547adb1
CY
86532011-06-10 Chong Yidong <cyd@stupidchicken.com>
8654
8655 * image.c (gif_load): Fix omitted cast error introduced by
8656 2011-06-06 change.
8657
2c8e37d4
MR
86582011-06-10 Martin Rudalics <rudalics@gmx.at>
8659
8660 * window.h (resize_proportionally, orig_total_lines)
8661 (orig_top_line): Remove from window structure.
8662 (set_window_height, set_window_width, change_window_heights)
8663 (Fdelete_window): Remove prototypes.
8664 (resize_frame_windows): Remove duplicate declaration.
8665
440a42e3
EZ
86662011-06-10 Eli Zaretskii <eliz@gnu.org>
8667
8668 * window.h (resize_frame_windows, resize_window_check)
8669 (delete_deletable_window, resize_root_window)
8670 (resize_frame_windows): Declare prototypes.
8671
8672 * window.c (resize_window_apply): Make definition be "static" to
8673 match the prototype.
8674
562dd5e9
MR
86752011-06-10 Martin Rudalics <rudalics@gmx.at>
8676
8677 * window.c: Remove declarations of Qwindow_size_fixed,
8678 window_min_size_1, window_min_size_2, window_min_size,
8679 size_window, window_fixed_size_p, enlarge_window, delete_window.
8680 Remove static from declaration of Qdelete_window, it's
8681 temporarily needed by Fbury_buffer.
8682 (replace_window): Don't assign orig_top_line and
8683 orig_total_lines.
8684 (Fdelete_window, delete_window): Remove. Window deletion is
8685 handled by window.el.
640c8776
SM
8686 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8687 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8688 (Fdelete_other_windows): Remove. Deleting other windows is
8689 handled by window.el.
8690 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8691 handled in window.el.
8692 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8693 Window minimum sizes are handled in window.el.
8694 (shrink_windows, size_window, set_window_height)
8695 (set_window_width, change_window_heights, window_height)
8696 (window_width, CURBEG, CURSIZE, enlarge_window)
8697 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8698 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8699 handled in window.el.
8700 (make_dummy_parent): Rename to make_parent_window and give it a
8701 second argument horflag.
8702 (make_window): Don't set resize_proportionally any more.
8703 (Fsplit_window): Remove. Windows are split in window.el.
8704 (save_restore_action, save_restore_orig_size)
8705 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8706 Resize mini windows in window.el.
8707 (grow_mini_window, shrink_mini_window): Implement by calling
8708 Qresize_root_window_vertically, resize_window_check and
8709 resize_window_apply.
640c8776
SM
8710 (saved_window, Fset_window_configuration, save_window_save):
8711 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8712 resize_proportionally.
8713 (window_min_height, window_min_width): Move to window.el.
8714 (keys_of_window): Move bindings for delete-other-windows,
8715 split-window, delete-window and enlarge-window to window.el.
8716
8717 * buffer.c: Temporarily extern Qdelete_window.
8718 (Fbury_buffer): Temporarily call Qdelete_window instead of
8719 Fdelete_window (Fbury_buffer will move to window.el soon).
8720
8721 * frame.c (set_menu_bar_lines_1): Remove code handling
8722 orig_top_line and orig_total_lines.
8723
8724 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8725 set_window_height but set heights directly.
8726 (change_frame_size_1): Use resize_frame_windows.
8727
8728 * xdisp.c (init_xdisp): Don't use set_window_height but set
8729 heights directly.
8730
640c8776
SM
8731 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8732 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8733 run_window_configuration_change_hook.
8734
8735 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8736 instead of change_window_heights and run
8737 run_window_configuration_change_hook.
8738
1a13852e
MR
87392011-06-09 Martin Rudalics <rudalics@gmx.at>
8740
8741 * window.c (replace_window): Rename second argument REPLACEMENT to
8742 NEW. New third argument SETFLAG. Rewrite.
8743 (delete_window, make_dummy_parent): Call replace_window with
8744 third argument 1.
8745 (window_list_1): Move down in code.
8746 (run_window_configuration_change_hook): Move set_buffer part
8747 before select_frame_norecord part in order to unwind correctly.
8748 Rename count1 to count.
8749 (recombine_windows, delete_deletable_window, resize_root_window)
8750 (Fdelete_other_windows_internal)
8751 (Frun_window_configuration_change_hook, make_parent_window)
8752 (resize_window_check, resize_window_apply, Fresize_window_apply)
8753 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8754 (Fdelete_window_internal, Fresize_mini_window_internal):
8755 New functions.
1a13852e
MR
8756 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8757
f3d1777e
MR
87582011-06-08 Martin Rudalics <rudalics@gmx.at>
8759
496e208e
MR
8760 * window.h (window): Add some new members to window structure -
8761 normal_lines, normal_cols, new_total, new_normal, clone_number,
8762 splits, nest, prev_buffers, next_buffers.
8763 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8764 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8765
f3d1777e
MR
8766 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8767 Remove.
496e208e
MR
8768 (make_dummy_parent): Set new members of windows structure.
8769 (make_window): Move down in code. Handle new members of window
8770 structure.
8771 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8772 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8773 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8774 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8775 (Fset_window_next_buffers, Fset_window_clone_number):
8776 New functions.
496e208e
MR
8777 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8778 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8779 Doc-string fixes.
8780 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8781 Argument WINDOW can be now internal window too.
8782 (Fwindow_use_time): Move up in code.
8783 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8784 Rewrite doc-string.
8785 (Fset_window_configuration, saved_window)
8786 (Fcurrent_window_configuration, save_window_save): Handle new
8787 members of window structure.
b9e809c2
MR
8788 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8789 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8790 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8791 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8792 Qget_mru_window, Qresize_root_window,
8793 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8794 Qauto_buffer_name; staticpro them.
f3d1777e 8795
abde8f8c
MR
87962011-06-07 Martin Rudalics <rudalics@gmx.at>
8797
8798 * window.c (Fwindow_total_size, Fwindow_left_column)
8799 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8800 (Fwindow_list_1): New functions.
8801 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8802 (Fwindow_width, Fscroll_left, Fscroll_right):
8803 Use window_body_cols instead of window_box_text_cols.
8804 (delete_window, Fset_window_configuration):
8805 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8806 (delete_all_subwindows): Take a window as argument and not a
8807 structure. Rewrite.
190b47e6
MR
8808 (window_loop): Remove handling of GET_LRU_WINDOW and
8809 GET_LARGEST_WINDOW.
8810 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8811
8812 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8813 window_box_text_cols. delete_all_subwindows now takes a
8814 Lisp_Object as argument.
abde8f8c 8815
640c8776
SM
8816 * indent.c (compute_motion, Fcompute_motion):
8817 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8818
fa8a67e6
MR
8819 * frame.c (delete_frame): Call delete_all_subwindows with root
8820 window as argument.
8821
a54e3482
DC
88222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8823
8824 * fns.c (Fputhash): Document return value.
8825
60002bf5
CY
88262011-06-06 Chong Yidong <cyd@stupidchicken.com>
8827
8828 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8829
0c671da6 88302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8831
b862a52a 8832 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8833
be44ca6c
PE
8834 Check for overflow when converting integer to cons and back.
8835 * charset.c (Fdefine_charset_internal, Fdecode_char):
8836 Use cons_to_unsigned to catch overflow.
8837 (Fencode_char): Use INTEGER_TO_CONS.
8838 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8839 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8840 * data.c (long_to_cons, cons_to_long): Remove.
8841 (cons_to_unsigned, cons_to_signed): New functions.
8842 These signal an error for invalid or out-of-range values.
8843 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8844 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8845 * font.c (Ffont_variation_glyphs):
8846 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8847 * lisp.h: Include <intprops.h>.
8848 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8849 (cons_to_signed, cons_to_unsigned): New decls.
8850 (long_to_cons, cons_to_long): Remove decls.
8851 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8852 (Fprimitive_undo): Use CONS_TO_INTEGER.
8853 * xfns.c (Fx_window_property): Likewise.
8854 * xselect.c: Include <limits.h>.
8855 (x_own_selection, selection_data_to_lisp_data):
8856 Use INTEGER_TO_CONS.
8857 (x_handle_selection_request, x_handle_selection_clear)
8858 (x_get_foreign_selection, Fx_disown_selection_internal)
8859 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8860 (lisp_data_to_selection_data): Use cons_to_unsigned.
8861 (x_fill_property_data): Use cons_to_signed.
8862 Report values out of range.
8863
d1f3d2af
PE
8864 Check for buffer and string overflow more precisely.
8865 * buffer.h (BUF_BYTES_MAX): New macro.
8866 * lisp.h (STRING_BYTES_MAX): New macro.
8867 * alloc.c (Fmake_string):
8868 * character.c (string_escape_byte8):
8869 * coding.c (coding_alloc_by_realloc):
8870 * doprnt.c (doprnt):
8871 * editfns.c (Fformat):
8872 * eval.c (verror):
8873 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8874 since they may not be the same number.
8875 * editfns.c (Finsert_char):
8876 * fileio.c (Finsert_file_contents):
8877 Likewise for BUF_BYTES_MAX.
8878
dd52fcea
PE
8879 * image.c: Use ptrdiff_t, not int, for sizes.
8880 (slurp_file): Switch from int to ptrdiff_t.
8881 All uses changed.
8882 (slurp_file): Check that file size fits in both size_t (for
8883 malloc) and ptrdiff_t (for sanity and safety).
8884
7f9bbdbb
PE
8885 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8886 if b->modtime has its maximal value.
8887
dfe18f82
PE
8888 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8889
84acfcf0
PE
8890 Don't assume time_t can fit into int.
8891 * buffer.h (struct buffer.modtime): Now time_t, not int.
8892 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8893 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8894
ccd9a01a
PE
8895 Minor fixes for signed vs unsigned integers.
8896 * character.h (MAYBE_UNIFY_CHAR):
8897 * charset.c (maybe_unify_char):
8898 * keyboard.c (read_char, reorder_modifiers):
8899 XINT -> XFASTINT, since the integer must be nonnegative.
8900 * ftfont.c (ftfont_spec_pattern):
8901 * keymap.c (access_keymap, silly_event_symbol_error):
8902 XUINT -> XFASTINT, since the integer must be nonnegative.
8903 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8904 since it makes no difference and we prefer signed.
8905 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8906 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8907 nonnegative.
8908
d6d100dd
SM
89092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8910
8911 * window.h (Fwindow_frame): Declare.
8912
2b6148e4
PE
89132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8914
8915 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8916 (SPARE_MEMORY): Always define.
8917 (LARGE_REQUEST): Remove.
8918 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8919
f230ecc9
MR
89202011-06-06 Martin Rudalics <rudalics@gmx.at>
8921
727e958e
MR
8922 * lisp.h: Move EXFUNS for Fframe_root_window,
8923 Fframe_first_window and Fset_frame_selected_window to window.h.
8924
8925 * window.h: Move EXFUNS for Fframe_root_window,
8926 Fframe_first_window and Fset_frame_selected_window here from
8927 lisp.h.
8928
8929 * frame.c (Fwindow_frame, Fframe_first_window)
8930 (Fframe_root_window, Fframe_selected_window)
8931 (Fset_frame_selected_window): Move to window.c.
8932 (Factive_minibuffer_window): Move to minibuf.c.
8933 (Fother_visible_frames_p): New function.
8934
8935 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8936
f230ecc9
MR
8937 * window.c (decode_window, decode_any_window): Move up in code.
8938 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8939 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8940 (Fwindow_buffer): Move up and rewrite doc-string.
8941 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8942 (Fwindow_prev): New functions.
727e958e
MR
8943 (Fwindow_frame): Move here from frame.c. Accept any window as
8944 argument.
8945 (Fframe_root_window, Fframe_first_window)
8946 (Fframe_selected_window): Move here from frame.c. Accept frame
8947 or arbitrary window as argument. Update doc-strings.
8948 (Fminibuffer_window): Move up in code.
8949 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8950 (Fset_frame_selected_window): Move here from frame.c.
8951 Marginal rewrite.
727e958e
MR
8952 (Fselected_window, select_window, Fselect_window): Move up in
8953 code. Minor doc-string fixes.
f230ecc9 8954
4d09bcf6
PE
89552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8956
8957 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8958 Do not assume that spare memory exists; that assumption is valid
8959 only if SYSTEM_MALLOC.
8960 (LARGE_REQUEST): New macro, so that the issue of large requests
8961 is separated from the issue of spare memory.
8962
810928a2
AS
89632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8964
172418ad
AS
8965 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8966 format. (Bug#8806)
8967
43f862f7
AS
8968 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8969
810928a2
AS
8970 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8971 before statements.
8972
a059fe24
JD
89732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8974
8975 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8976
8977 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8978
8979 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8980 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8981
989bf368
JB
89822011-06-05 Juanma Barranquero <lekktu@gmail.com>
8983
8984 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8985
4b80f674
CY
89862011-06-04 Chong Yidong <cyd@stupidchicken.com>
8987
8988 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8989 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8990 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8991 New error handlers.
4b80f674
CY
8992 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8993 Obey Vx_select_enable_clipboard_manager. Catch errors in
8994 x_clipboard_manager_save (Bug#8779).
8995 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8996 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8997
99a33b77 89982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8999
9000 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9001
99a33b77 90022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9003
9004 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9005 in the current matrix if keep_current_p is non-zero.
9006
8264569d
EZ
90072011-06-04 Eli Zaretskii <eliz@gnu.org>
9008
9009 * bidi.c (bidi_level_of_next_char): Fix last change.
9010
57f97249
EZ
90112011-06-03 Eli Zaretskii <eliz@gnu.org>
9012
fec2107c 9013 Support bidi reordering of text covered by display properties.
57f97249 9014
fec2107c
EZ
9015 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9016 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9017 (bidi_cache_search, bidi_cache_iterator_state)
9018 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9019 (bidi_level_of_next_char, bidi_move_to_visually_next):
9020 Support character positions inside a run of characters covered by a
fec2107c
EZ
9021 display string.
9022 (bidi_paragraph_init, bidi_resolve_explicit_1)
9023 (bidi_level_of_next_char): Call bidi_fetch_char and
9024 bidi_fetch_char_advance instead of FETCH_CHAR and
9025 FETCH_CHAR_ADVANCE.
9026 (bidi_init_it): Initialize new members.
9027 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9028 definitions.
9029 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9030 instead of using explicit *_CHAR codes.
d6d100dd
SM
9031 (bidi_resolve_explicit, bidi_resolve_weak):
9032 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9033 bidirectional text is supported only in multibyte buffers.
9034 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9035 it to initialize the frame_window_p member of struct bidi_it.
9036 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9037 (bidi_resolve_explicit, bidi_resolve_weak)
9038 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9039 bidi_it->nchars is non-positive.
9040 (bidi_level_of_next_char): Don't try to lookup the cache for the
9041 next/previous character if nothing is cached there yet, or if we
9042 were just reseat()'ed to a new position.
c40e2fb2 9043
0e14fe90
EZ
9044 * xdisp.c (set_cursor_from_row): Set start and stop points
9045 according to the row's direction when priming the loop that looks
9046 for the glyph on which to display cursor.
9047 (single_display_spec_intangible_p): Function deleted.
9048 (display_prop_intangible_p): Reimplement to call
9049 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9050 Accept 3 additional arguments needed by handle_display_spec.
9051 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9052 values: lists, `(when COND...)' forms, etc.
9053 (single_display_spec_string_p): Support property values that are
9054 lists with the argument STRING its top-level element.
9055 (display_prop_string_p): Fix the condition for processing a
9056 property that is a list to be consistent with handle_display_spec.
fec2107c 9057 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9058 last portion of handle_display_prop.
9059 (compute_display_string_pos): Accept additional argument
9060 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9061 value of a `display' property is a "replacing spec".
9062 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9063 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9064 the display property, but just return a value indicating whether
9065 the display property will replace the characters it covers.
9066 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9067 frame_window_p members of struct bidi_it.
d6d100dd
SM
9068 (compute_display_string_pos, compute_display_string_end):
9069 New functions.
fec2107c
EZ
9070 (push_it): Accept second argument POSITION, where pop_it should
9071 jump to continue iteration.
9072 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9073
fec2107c
EZ
9074 * keyboard.c (adjust_point_for_property): Adjust the call to
9075 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9076
9077 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9078 (bidi_init_it): Update prototypes.
9079 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9080 (compute_display_string_pos, compute_display_string_end):
9081 Declare prototypes.
fec2107c
EZ
9082 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9083 EMACS_INT.
fc6f18ce 9084
40087514 90852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9086
57f53182
PE
9087 Malloc failure behavior now depends on size of allocation.
9088 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9089 * lisp.h: Change signatures accordingly.
9090 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9091 All callers changed. (Bug#8762)
9092
9093 * gnutls.c: Use Emacs's memory allocators.
9094 Without this change, the gnutls library would invoke malloc etc.
9095 directly, which causes problems on non-SYNC_INPUT hosts, and which
9096 runs afoul of improving memory_full behavior. (Bug#8761)
9097 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9098 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9099 xfree instead of the default malloc, realloc, free.
9100 (Fgnutls_boot): No need to check for memory allocation failure,
9101 since xmalloc does that for us.
9102
ac32cd99 9103 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9104 * category.c (hash_get_category_set):
9105 * ccl.c (ccl_driver):
9106 * charset.c (Fdefine_charset_internal):
9107 * charset.h (struct charset.hash_index):
9108 * composite.c (get_composition_id, gstring_lookup_cache)
9109 (composition_gstring_put_cache):
9110 * composite.h (struct composition.hash_index):
9111 * dispextern.h (struct image.hash):
9112 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9113 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9114 (hashfn_equal, hashfn_user_defined, make_hash_table)
9115 (maybe_resize_hash_table, hash_lookup, hash_put)
9116 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9117 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9118 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9119 * image.c (make_image, search_image_cache, lookup_image)
9120 (xpm_put_color_table_h):
9121 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9122 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9123 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9124 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9125 * alloc.c (allocate_vectorlike):
9126 Check for overflow in vector size calculations.
9127 * ccl.c (ccl_driver):
9128 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9129 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9130 need to be updated by these changes.
40087514
PE
9131 * fns.c (make_hash_table, maybe_resize_hash_table):
9132 Check for integer overflow with large hash tables.
0de4bb68
PE
9133 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9134 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9135 (SXHASH_REDUCE): New macro.
9136 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9137 Use it instead of discarding useful hash info with large hash values.
9138 (sxhash_float): New function.
9139 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9140 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9141 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9142 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9143 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9144 Adjust signatures to match updated version of code.
9145 (consing_since_gc): Now EMACS_INT, since a single hash table can
9146 use more than INT_MAX bytes.
9147
698d32e2
DN
91482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9149
9150 Make it possible to build with GCC-4.6+ -O2 -flto.
9151
9152 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9153
fd6fa53f
SM
91542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9155
9156 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9157 Call minibuffer-inactive-mode.
9158
864db017
JB
91592011-05-31 Juanma Barranquero <lekktu@gmail.com>
9160
9161 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9162 Update dependencies.
9163
2ad0baf4
DN
91642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9165
9166 * data.c (init_data): Remove code for UTS, this system is not
9167 supported anymore.
9168
4fcc2638
DN
91692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9170
9171 Don't force ./temacs to start in terminal mode.
9172
9173 * frame.c (make_initial_frame): Initialize faces in all cases, not
9174 only when CANNOT_DUMP is defined.
9175 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9176
c56e0fd5
DN
91772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9178
9179 * dispnew.c (add_window_display_history): Use const for the string
9180 pointer. Remove declaration, not needed.
9181
333d54da 91822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9183
55d4c1b2 9184 Use 'inline', not 'INLINE'.
333d54da 9185 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9186 * alloc.c, fontset.c (INLINE): Remove.
9187 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9188 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9189 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9190 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9191 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9192
738db178
DN
91932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9194
9195 Make it possible to run ./temacs.
9196
9197 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9198 syms_of_callproc does the same thing. Remove test for
9199 "initialized", do it in the caller.
9200 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9201
620c53a6
SM
92022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9203
9204 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9205 (read_minibuf): Use get_minibuffer.
9206 (syms_of_minibuf): Use DEFSYM.
9207 (Qmetadata): New var.
9208 * data.c (Qbuffer): Don't make it static.
9209 (syms_of_data): Use DEFSYM.
9210
e003a292
PE
92112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9212
9213 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9214 (CCL_CODE_MIN): New macro.
9215
ed008a6d
PE
92162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9217
3687c2ef
PE
9218 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9219
ed008a6d
PE
9220 * eval.c (Qdebug): Now static.
9221 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9222 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9223 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9224
d66c4c7c
CY
92252011-05-29 Chong Yidong <cyd@stupidchicken.com>
9226
9227 * image.c: Various fixes to ImageMagick code comments.
9228 (Fimagemagick_types): Doc fix.
9229
5fbc2025
PE
92302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9231
0196f88a
PE
9232 Minor fixes prompted by GCC 4.6.0 warnings.
9233
9234 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9235
5fbc2025
PE
9236 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9237 (x_clipboard_manager_save_all): Move extern decl to ...
9238 * xterm.h: ... here, so that it can be checked for consistency.
9239
1dd3c2d9
CY
92402011-05-29 Chong Yidong <cyd@stupidchicken.com>
9241
9242 * xselect.c (x_clipboard_manager_save_frame)
9243 (x_clipboard_manager_save_all): New functions.
9244 (Fx_clipboard_manager_save): Lisp function deleted.
9245
9246 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9247 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9248
9249 * xterm.h: Update prototype.
9250
5ba6571d
WX
92512011-05-28 William Xu <william.xwl@gmail.com>
9252
9253 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9254 exiting (Bug#8239).
9255
3eaff834
JM
92562011-05-28 Jim Meyering <meyering@redhat.com>
9257
e1900994 9258 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9259 * fns.c (to_uchar): Define.
9260 (crypto_hash_function): Use it to convert some newly-signed
9261 variables to unsigned, to avoid sign-extension bugs. For example,
9262 without this change, (md5 "truc") would evaluate to
9263 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9264 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9265 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9266
0f6990a7
PE
92672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9268
9269 Integer overflow fixes.
c8a9ca5a 9270
08686060
PE
9271 * dbusbind.c: Serial number integer overflow fixes.
9272 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9273 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9274 to hold a serial number that is too large for a fixnum.
9275 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9276 Check for serial numbers out of range. Decode any serial number
59568bf0 9277 that was so large that it became a float. (Bug#8722)
08686060 9278
2d1fc3c7
PE
9279 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9280 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9281 Use XFASTINT rather than XUINT when numbers are nonnegative.
9282 (xd_append_arg, Fdbus_method_return_internal):
9283 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9284 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9285 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9286 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9287 (Bug#8722)
2d1fc3c7 9288
c8a9ca5a
PE
9289 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9290
519e1d69
PE
9291 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9292
6df6ae42 9293 ccl: Add integer overflow checks.
30569699
PE
9294 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9295 (IN_INT_RANGE): New macros.
9296 (ccl_driver): Use them to check for integer overflow when
9297 decoding a CCL program. Many of the new checks are whether XINT (x)
9298 fits in int; it doesn't always, on 64-bit hosts. The new version
9299 doesn't catch all possible integer overflows, but it's an
847044ea 9300 improvement. (Bug#8719)
30569699 9301
c11285dc
PE
9302 * alloc.c (make_event_array): Use XINT, not XUINT.
9303 There's no need for unsigned here.
9304
fdccd48e
PE
9305 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9306 This follows up to the 2011-05-06 change that substituted uintptr_t
9307 for EMACS_INT. This case wasn't caught back then.
9308
37910ab2
PE
9309 Rework Fformat to avoid integer overflow issues.
9310 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9311 now (part of C89). Include <verify.h>.
9312 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9313 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9314 (Fformat): Avoid the prepass trying to compute sizes; it was only
9315 approximate and thus did not catch overflow reliably. Instead, walk
9316 through the format just once, formatting and computing sizes as we go,
9317 checking for integer overflow at every step, and allocating a larger
9318 buffer as needed. Keep track separately whether the format is
9319 multibyte. Keep only the most-recently calculated precision, rather
9320 than them all. Record whether each argument has been converted to
9321 string. Use EMACS_INT, not int, for byte and char and arg counts.
9322 Support field widths and precisions larger than INT_MAX. Avoid
9323 sprintf's undefined behavior with conversion specifications such as %#d
9324 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9325 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9326 formatting out-of-range floating point numbers with int
9173deec 9327 formats. (Bug#8668)
37910ab2 9328
2e6578fb
PE
9329 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9330
0ae6bdee
PE
9331 * data.c: Avoid integer truncation in expressions involving floats.
9332 * data.c: Include <intprops.h>.
9333 (arith_driver): When there's an integer overflow in an expression
9334 involving floating point, convert the integers to floating point
9335 so that the resulting value does not suffer from catastrophic
9336 integer truncation. For example, on a 64-bit host (* 4
9337 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9338 Do not rely on undefined behavior after integer overflow.
9339
de883a70
PE
9340 merge count_size_as_multibyte, parse_str_to_multibyte
9341 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9342 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9343 Check for integer overflow.
9344 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9345 since it's now a duplicate of the other. This is more of
9346 a character than a buffer op, so better that it's in character.c.
9347 * fns.c, print.c: Adjust to above changes.
9348
2ff916cb
PE
93492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9350
9351 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9352
f1b54466
PE
93532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9354
fb1ac845
PE
9355 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9356 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9357 (x_clipboard_manager_save): Now static.
9358 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9359
f1b54466
PE
9360 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9361 (crypto_hash_function): Now static.
9362 Fix pointer signedness problems. Avoid unnecessary initializations.
9363
a9f737ee
CY
93642011-05-27 Chong Yidong <cyd@stupidchicken.com>
9365
9366 * termhooks.h (Vselection_alist): Make it terminal-local.
9367
9368 * terminal.c (create_terminal): Initialize it.
9369
9370 * xselect.c: Support for clipboard managers.
9371 (Vselection_alist): Move to termhooks.h as terminal-local var.
9372 (LOCAL_SELECTION): New macro.
9373 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9374 (symbol_to_x_atom): Remove gratuitous arg.
9375 (x_handle_selection_request, lisp_data_to_selection_data)
9376 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9377 (x_own_selection, x_get_local_selection, x_convert_selection):
9378 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9379 (some_frame_on_display): Delete unused function.
9380 (Fx_own_selection_internal, Fx_get_selection_internal)
9381 (Fx_disown_selection_internal, Fx_selection_owner_p)
9382 (Fx_selection_exists_p): New optional frame arg.
9383 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9384 (x_handle_selection_clear): Don't treat other terminals with the
9385 same keyboard specially. Use the terminal-local Vselection_alist.
9386 (x_clear_frame_selections): Use Frun_hook_with_args.
9387
9388 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9389
9390 * xterm.h: Add support for those atoms.
9391
e067f0c1
CY
93922011-05-26 Chong Yidong <cyd@stupidchicken.com>
9393
9394 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9395 (converted_selections, conversion_fail_tag): New global variables.
9396 (x_selection_request_lisp_error): Free the above.
9397 (x_get_local_selection): Remove unnecessary code.
9398 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9399 of converted selections stored in converted_selections.
9400 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9401 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9402 (x_convert_selection): New function.
9403 (x_handle_selection_event): Simplify.
9404 (x_get_foreign_selection): Don't ignore incoming requests while
9405 waiting for an answer; this will fail when we implement
9406 SAVE_TARGETS, and seems unnecessary anyway.
9407 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9408 (Vx_sent_selection_functions): Doc fix.
9409
0f4aebc0
LL
94102011-05-26 Leo Liu <sdl.web@gmail.com>
9411
9412 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9413
e61124cd
YM
94142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9415
9416 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9417
9418 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9419 for fringe update if it has periodic bitmap.
ac389d0c 9420 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9421 and fringe_bitmap_periodic_p.
9422
9423 * fringe.c (get_fringe_bitmap_data): New function.
9424 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9425 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9426 row. Mark glyph row for fringe update if periodicity changed.
9427
9428 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9429 for fringe update unless it has periodic bitmap.
9430
f16d9837
KH
94312011-05-25 Kenichi Handa <handa@m17n.org>
9432
9433 * xdisp.c (get_next_display_element): Set correct it->face_id for
9434 a static composition.
9435
e1b90ef6
LL
94362011-05-24 Leo Liu <sdl.web@gmail.com>
9437
9438 * deps.mk (fns.o):
9439 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9440
9441 * fns.c (crypto_hash_function, Fsha1): New function.
9442 (Fmd5): Use crypto_hash_function.
9443 (syms_of_fns): Add Ssha1.
9444
7400048f
PE
94452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9446
9447 * gnutls.c: Remove unused macros.
9448 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9449 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9450 Remove macros that are defined and never used.
9451 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9452
abb71cf4
CY
94532011-05-22 Chong Yidong <cyd@stupidchicken.com>
9454
9455 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9456 (Fx_get_selection_internal): Minor cleanup.
9457 (Fx_own_selection_internal): Rename arguments for consistency with
9458 select.el.
9459
6307db39
PE
94602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9461
9462 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9463
f3d4e0a4
CY
94642011-05-22 Chong Yidong <cyd@stupidchicken.com>
9465
9466 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9467
4d8ade89
YM
94682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9469
9470 * dispnew.c (scrolling_window): Don't exclude the case that the
9471 last enabled row in the desired matrix touches the bottom boundary.
9472
32078c8d
GM
94732011-05-21 Glenn Morris <rgm@gnu.org>
9474
9475 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9476 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9477 and add some more files.
32078c8d 9478
7285dc67
EZ
94792011-05-20 Eli Zaretskii <eliz@gnu.org>
9480
9481 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9482 report_file_error introduced by the change from 2011-05-07.
9483
89d1bd22
PE
94842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9485
9486 * systime.h (Time): Define only if emacs is defined.
9487 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9488 where the include path doesn't have X11/X.h by default. See
9489 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9490
cd394be1 94912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9492
9493 * composite.c (find_automatic_composition): Fix previous change.
9494
b9704ad9
GM
94952011-05-20 Glenn Morris <rgm@gnu.org>
9496
9497 * lisp.mk: New file, split from Makefile.in.
9498 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9499 (shortlisp): Remove.
9500 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9501
4a720484
GM
95022011-05-19 Glenn Morris <rgm@gnu.org>
9503
9504 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9505 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9506 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9507 (lisp): Set the order to that of loadup.el.
9508 (shortlisp): Make it a copy of $lisp.
9509 (SOME_MACHINE_LISP): Remove.
9510 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9511 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9512
a28d4396
KH
95132011-05-18 Kenichi Handa <handa@m17n.org>
9514
9515 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9516 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9517 (find_automatic_composition): Mostly rewrite for efficiency.
9518
a2b1fa8e
JB
95192011-05-18 Juanma Barranquero <lekktu@gmail.com>
9520
9521 * makefile.w32-in: Update dependencies.
9522
8e1f5610
CS
95232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9524
9525 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9526 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9527
7025ee00 95282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9529
cdfa6eab
PE
9530 Fix some integer overflow issues, such as string length overflow.
9531
06d6db33
PE
9532 * insdel.c (count_size_as_multibyte): Check for string overflow.
9533
2b4560a8
PE
9534 * character.c (lisp_string_width): Check for string overflow.
9535 Use EMACS_INT, not int, for string indexes and lengths; in
9536 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9537 the resulting string length overflows an EMACS_INT; instead,
9538 report a string overflow if no precision given. When checking for
9539 precision exhaustion, use a check that cannot possibly have
9540 integer overflow. (Bug#8675)
9541 * character.h (lisp_string_width): Adjust to new signature.
9542
cb93f9be
PE
9543 * alloc.c (string_overflow): New function.
9544 (Fmake_string): Use it. This doesn't change behavior, but saves
9545 a few bytes and will simplify future changes.
9546 * character.c (string_escape_byte8): Likewise.
9547 * lisp.h (string_overflow): New decl.
9548
1a1f3366
PE
9549 Fixups, following up to the user-interface timestamp change.
9550 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9551 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9552 * msdos.c (mouse_get_pos): Likewise.
9553 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9554 * w32gui.h (Time): Define by including "systime.h" rather than by
9555 declaring it ourselves. (Bug#8664)
9556
d4e3e4d3
PE
9557 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9558 * image.c (clear_image_cache): Likewise.
9559
f6a24d19
PE
9560 * term.c (term_mouse_position): Don't assume time_t wraparound.
9561
08dc5ae6
PE
9562 Be more systematic about user-interface timestamps.
9563 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9564 and sometimes 'EMACS_UINT', to represent these timestamps.
9565 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9566 This makes the code easier to follow, and makes it easier to catch
9567 integer overflow bugs such as Bug#8664.
9568 * frame.c (Fmouse_position, Fmouse_pixel_position):
9569 Use Time, not unsigned long, for user-interface timestamps.
9570 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9571 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9572 * keyboard.h (last_event_timestamp): Likewise.
9573 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9574 * menu.h (xmenu_show): Likewise.
9575 * term.c (term_mouse_position): Likewise.
9576 * termhooks.h (struct input_event.timestamp): Likewise.
9577 (struct terminal.mouse_position_hook): Likewise.
9578 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9579 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9580 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9581 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9582 what it was before.
9583 * menu.h, termhooks.h: Include "systime.h", for Time.
9584
8e55734a
PE
9585 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9586 Don't assume that the difference between two unsigned long values
9587 can fit into an integer. At this point, we know button_down_time
9588 <= event->timestamp, so the difference must be nonnegative, so
9589 there's no need to cast the result if double-click-time is
9590 nonnegative, as it should be; check that it's nonnegative, just in
9591 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9592 apart (about 25 days). (Bug#8664)
8e55734a 9593
841f1b75 9594 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9595 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9596
3e26f69c
PE
9597 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9598 that always fit in int. Use a sentinel instead of a counter, to
9599 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9600 * frame.h (struct frame): Use int for menu_bar_items_used
9601 instead of EMACS_INT, since it always fits in int.
3e26f69c 9602
5cc152c0
PE
9603 * menu.c (grow_menu_items): Check for int overflow.
9604
d89eb65e
PE
9605 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9606
5235bd3e
PE
9607 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9608 Before, the code was not consistent. These values cannot exceed
9609 2**31 - 1 so there's no need to make them unsigned.
9610 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9611 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9612 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9613 as modifiers.
9614 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9615
bc827e23
PE
9616 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9617 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9618 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9619 presumably because the widths might not match.
9620
78eb494e
PE
9621 * window.c (size_window): Avoid needless test at loop start.
9622
04f2d78b
CB
96232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9624
9625 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9626
d2fc7e3d 96272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9628
9629 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9630
d2fc7e3d 96312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9632
9633 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9634 `width' to `bar_area_x' and `bar_area_width', respectively.
9635 (x_scroll_run): Take account of fringe background extension.
9636
04f2d78b
CB
9637 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9638 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9639 `bar_area_width', respectively.
9640 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9641 background extension.
9642
79b70037
GM
96432011-05-10 Jim Meyering <meyering@redhat.com>
9644
9645 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9646
2f142cc5
JB
96472011-05-10 Juanma Barranquero <lekktu@gmail.com>
9648
9649 * image.c (Finit_image_library): Return t for built-in image types,
9650 like pbm and xbm. (Bug#8640)
9651
57679c86
AS
96522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9653
9654 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9655
888c9e86
EZ
96562011-05-07 Eli Zaretskii <eliz@gnu.org>
9657
b0512a1d
EZ
9658 * w32console.c (Fset_screen_color): Doc fix.
9659 (Fget_screen_color): New function.
9660 (syms_of_ntterm): Defsubr it.
9661
7285dc67
EZ
9662 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9663 unlink the temporary file if Fcall_process didn't create it in the
9664 first place.
9665 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9666 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9667 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9668 cue to call_process_cleanup not to close that handle.
9669
4d3fcc8e
BK
96702011-05-07 Ben Key <bkey76@gmail.com>
9671
9672 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9673 one of two shell specific rules, either bootstrap-temacs-CMD or
9674 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9675 to the previous implementation of the bootstrap-temacs rule.
9676 The bootstrap-temacs-CMD rule is similar to the previous
9677 implementation of the bootstrap-temacs rule except that it
9678 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9679 variable.
9680
9681 These changes, along with some changes to nt/configure.bat,
9682 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9683 earlier fix to add support for --cflags and --ldflags options
9684 that include quotes so that it works whether make uses cmd or
9685 sh as the shell.
9686
b4289b64
MA
96872011-05-06 Michael Albinus <michael.albinus@gmx.de>
9688
9689 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9690 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9691 is a constant.
9692 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9693 a string. Handle both cases.
9694 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9695 (Fdbus_register_method): Use Qinvalid_function.
9696
af4c0e28
JB
96972011-05-06 Juanma Barranquero <lekktu@gmail.com>
9698
9699 * makefile.w32-in: Update dependencies.
9700 (LISP_H): Add inttypes.h and stdin.h.
9701 (PROCESS_H): Add unistd.h.
9702
c51453d9
EZ
97032011-05-06 Eli Zaretskii <eliz@gnu.org>
9704
9705 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9706 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9707
8ff0ac3c 97082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9709
4c4b566b
PE
9710 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9711
aab2b9b5
PE
9712 * term.c (vfatal): Remove stray call to va_end.
9713 It's not needed and the C Standard doesn't allow it here anyway.
9714
c378da0b
PE
9715 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9716 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9717
288b08c7
PE
9718 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9719 bytes.
9720
e3601888
PE
9721 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9722
db6c0e74
PE
9723 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9724
dd5963ea
PE
9725 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9726
88c9450f
PE
9727 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9728
2f9442b8
PE
9729 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9730
c032b5f8
PE
9731 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9732 * charset.c (Fdefine_charset_internal): Don't initialize
9733 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9734 32-bit int (Bug#8600).
a108c10b
PE
9735
9736 * lread.c (read_integer): Be more consistent with string-to-number.
9737 Use string_to_number to do the actual conversion; this avoids
9738 rounding errors and fixes some other screwups. Without this fix,
9739 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9740 (digit_to_number): Move earlier, for benefit of read_integer.
9741 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9742 not a digit in any supported base. (Bug#8602)
a108c10b 9743
ad5f9eea
PE
9744 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9745
aec1708a
PE
9746 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9747 to match comment at start of function. This also removes a
9748 GCC warning about overflow in a 32+64-bit port.
9749
47be4ab5
PE
9750 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9751
371cac43
PE
9752 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9753 Reported by Stefan Monnier in
9754 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9756 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9757
d01a7826
PE
9758 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9759 (EMACS_UINTPTR): Likewise, with uintptr_t.
9760
7fd47d5c
PE
9761 * lisp.h: Prefer 64-bit EMACS_INT if available.
9762 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9763 on 32-bit hosts that have 64-bit int, so that they can access
9764 large files.
122b0c86
PE
9765 However, temporarily disable this change unless the temporary
9766 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9767
8727937b
PE
9768 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9769
8ac068ac
PE
9770 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9771 This removes an assumption that EMACS_INT and long are the same
9772 width as pointers. The assumption is true for Emacs porting targets
9773 now, but we want to make other targets possible.
9774 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9775 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9776 In the rest of the code, change types of integers that hold casted
9777 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9778 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9779 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9780 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9781 No need to cast type when ORing.
9782 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9783 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9784 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9785 assume EMACS_INT is the same width as char *.
9786 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9787 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9788 Remove no-longer-needed casts.
9789 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9790 (xg_tool_bar_help_callback, xg_make_tool_item):
9791 Use EMACS_INTPTR to hold an integer
9792 that will be cast to void *; this can avoid a GCC warning
9793 if EMACS_INT is not the same width as void *.
9794 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9795 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9796 (current_message_1, set_message_1):
9797 Use a local to convert to proper width without a cast.
9798 * xmenu.c (dialog_selection_callback): Likewise.
9799
ede49d71
PE
9800 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9801 Also, don't assume VALBITS / RAND_BITS is less than 5,
9802 and don't rely on undefined behavior when shifting a 1 left into
9803 the sign bit.
9804 * lisp.h (get_random): Change signature to match.
9805
2f30ecd0
PE
9806 * lread.c (hash_string): Use size_t, not int, for hash computation.
9807 Normally we prefer signed values; but hashing is special, because
9808 it's better to use unsigned division on hash table sizes so that
9809 the remainder is nonnegative. Also, size_t is the natural width
9810 for hashing into memory. The previous code used 'int', which doesn't
9811 retain enough info to hash well into very large tables.
9812 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9813
2a866e7b
PE
9814 * dbusbind.c: Don't possibly lose pointer info when converting.
9815 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9816 Use XPNTR rather than XHASH, so that the high-order bits of
9817 the pointer aren't lost when converting through void *.
9818
51639eac
PE
9819 * eval.c (Fautoload): Don't double-shift a pointer.
9820
92394119
PE
9821 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9822
dbdb9a7c
JB
98232011-05-06 Juanma Barranquero <lekktu@gmail.com>
9824
9825 * gnutls.c (DEF_GNUTLS_FN):
9826 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9827
db7a0b4f
AS
98282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9829
9830 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9831 marker. (Bug#8610)
9832
cd394be1 98332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9834
9835 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9836 New version that can reserve upto 2GB of heap space.
9837
f7ff1b0f 98382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9839
9840 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9841
639c109b
TZ
98422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9843
9844 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9845 `gnutls_certificate_set_x509_key_file'.
9846
d2127135
JB
98472011-05-05 Juanma Barranquero <lekktu@gmail.com>
9848
9849 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9850 Update dependencies.
9851
e968f4f3
JB
98522011-05-04 Juanma Barranquero <lekktu@gmail.com>
9853
9854 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9855 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9856 Remove unused parameter `fildes'.
9857 * process.c (read_process_output, send_process): Don't pass it.
9858
84d358f0
JB
98592011-05-04 Juanma Barranquero <lekktu@gmail.com>
9860
9861 Fix previous change: the library cache is defined in w32.c.
9862 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9863 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9864
0898ca10
JB
98652011-05-04 Juanma Barranquero <lekktu@gmail.com>
9866
9867 Implement dynamic loading of GnuTLS on Windows.
9868
9869 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9870 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9871 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9872 Declare.
9873
9874 * gnutls.c (Qgnutls_dll): Define.
9875 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9876 (gnutls_*): Declare function pointers.
9877 (init_gnutls_functions): New function to initialize function pointers.
9878 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9879 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9880 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9881 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9882 (emacs_gnutls_write, emacs_gnutls_read)
9883 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9884 (Fgnutls_available_p): New function.
9885 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9886 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9887 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9888
9889 * image.c: Include w32.h.
9890 (Vimage_type_cache): Delete.
9891 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9892 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9893 (w32_delayed_load): Move to w32.c.
9894
9895 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9896
9897 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9898 (w32_delayed_load): Move from image.c. When loading a library, record
9899 its filename in the :loaded-from property of the library id.
9900 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9901 Initialize and staticpro them.
9902 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9903
9904 * process.c: Include lisp.h before w32.h, not after.
9905 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9906 instead of gnutls_record_check_pending.
9907
9908 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9909
ff4de4aa
TZ
99102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9911
9912 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9913 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9914 as passed in.
9915
abe95abb
JD
99162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9917
9918 * xterm.c (x_set_frame_alpha): Do not set property on anything
9919 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9920
e16e55d4
JB
99212011-05-02 Juanma Barranquero <lekktu@gmail.com>
9922
9923 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9924
bafcf6a5
JB
99252011-05-02 Juanma Barranquero <lekktu@gmail.com>
9926
9927 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9928 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9929 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9930 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9931 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9932 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9933 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9934 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9935 (Qgnutls_bootprop_callbacks_verify): Make static.
9936
e7a6747f
AS
99372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9938
19ed11ba
AS
9939 * callproc.c: Indentation fixup.
9940
e7a6747f 9941 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9942 (wait_for_termination, interruptible_wait_for_termination):
9943 Move after wait_for_termination_1.
e7a6747f 9944
1ef14cb4
LMI
99452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9946
9947 * sysdep.c (interruptible_wait_for_termination): New function
9948 which is like wait_for_termination, but allows keyboard
9949 interruptions.
9950
9951 * callproc.c (Fcall_process): Add (:file "file") as an option for
9952 the STDOUT buffer.
9953 (Fcall_process_region): Ditto.
9954
330d880c
EZ
99552011-04-30 Eli Zaretskii <eliz@gnu.org>
9956
8db90b73
EZ
9957 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9958 rather than `XVECTOR (FOO)->size'.
9959
330d880c
EZ
9960 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9961 inttypes.h, as a gnulib replacement is used if it not available in
9962 system headers.
9963
15cbd324
EZ
99642011-04-21 Eli Zaretskii <eliz@gnu.org>
9965
9966 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9967 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9968 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9969
9970 * coding.c (coding_alloc_by_realloc): Error out if destination
9971 will grow beyond MOST_POSITIVE_FIXNUM.
9972 (decode_coding_emacs_mule): Abort if there isn't enough place in
9973 charbuf for the composition carryover bytes. Reserve an extra
9974 space for up to 2 characters produced in a loop.
9975 (decode_coding_iso_2022): Abort if there isn't enough place in
9976 charbuf for the composition carryover bytes.
9977
99782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9979
ae940cca
EZ
9980 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9981 aborting when %lld or %lll format is passed.
9982 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9983 %llo or %llx format is passed. (Bug#8545)
9984
03ab8921
EZ
9985 * window.c (window_scroll_line_based): Use a marker instead of
9986 simple variables to record original value of point. (Bug#7952)
9987
afda1437
EZ
9988 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9989 produced by %s or %c overflows available buffer space. (Bug#8545)
9990
f76dee0c
PE
99912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9992
9993 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9994 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9995
fdc5744d
JB
99962011-04-28 Juanma Barranquero <lekktu@gmail.com>
9997
9998 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9999
638f053a
JB
100002011-04-28 Juanma Barranquero <lekktu@gmail.com>
10001
10002 * keyboard.c (Qdelayed_warnings_hook): Define.
10003 (command_loop_1): Run `delayed-warnings-hook'
10004 if Vdelayed_warnings_list is non-nil.
10005 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10006 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10007
d178f871
EZ
100082011-04-28 Eli Zaretskii <eliz@gnu.org>
10009
10010 * doprnt.c (doprnt): Don't return value smaller than the buffer
10011 size if the message was truncated. (Bug#8545).
10012
b124fd93
JB
100132011-04-28 Juanma Barranquero <lekktu@gmail.com>
10014
10015 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10016 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10017
e810457d
PE
100182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10019
10020 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10021
ea51cceb
JB
100222011-04-27 Juanma Barranquero <lekktu@gmail.com>
10023
10024 * makefile.w32-in: Update dependencies.
10025
94dcfacf
EZ
100262011-04-27 Eli Zaretskii <eliz@gnu.org>
10027
10028 Improve `doprnt' and its usage. (Bug#8545)
10029 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10030 `format_end'. Remove support for %l as a conversion specifier.
10031 Don't use xrealloc. Improve diagnostics when the %l size modifier
10032 is used. Update the commentary.
10033
10034 * eval.c (verror): Simplify calculation of size_t.
10035
10036 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10037 messages.
10038
f61f41d7
PE
100392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10040
10041 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10042 change.
10043
96fb4434
PE
100442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10045
10046 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10047 This makes this file independent of the recent pseudovector change.
10048
671875da 100492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10050
69e9b5a3
PE
10051 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10052
b5f869a7 10053 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10054 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10055 Remove unused local.
c8926152 10056 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10057
841a1577 10058 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10059 GCC 4.6.0 optimizes based on type-based alias analysis.
10060 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10061 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10062 != &v->size, and therefore "v->size = 1; b->size = 2; return
10063 v->size;" must therefore return 1. This assumption is incorrect
10064 for Emacs, since it type-puns struct Lisp_Vector * with many other
10065 types. To fix this problem, this patch adds a new type struct
f904488f 10066 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10067 and pseudovectors, and helps optimizing compilers not get fooled
10068 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10069 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10070 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10071 the size member.
eab3844f
PE
10072 (XSETPVECTYPE): Rewrite in terms of new macro.
10073 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10074 This is a bit clearer, and further avoids the possibility of
10075 undesirable aliasing.
10076 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10077 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10078 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10079 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10080 (ASIZE): Now uses header.size rather than size.
10081 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10082 to avoid the hassle of writing XVECTOR (foo)->header.size.
10083 (struct vectorlike_header): New type.
eab3844f
PE
10084 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10085 object, to help avoid aliasing.
10086 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10087 (SUBRP): Likewise, since Lisp_Subr is a special case.
10088 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10089 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10090 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10091 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10092 changed to be "header.size" and "header.next".
10093 * buffer.h (struct buffer): Likewise.
10094 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10095 * frame.h (struct frame): Likewise.
10096 * process.h (struct Lisp_Process): Likewise.
10097 * termhooks.h (struct terminal): Likewise.
10098 * window.c (struct save_window_data, struct saved_window): Likewise.
10099 * window.h (struct window): Likewise.
10100 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10101 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10102 * buffer.c (init_buffer_once): Likewise.
10103 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10104 special case.
10105 * process.c (Fformat_network_address): Use local var for size,
10106 for brevity.
10107
0df1eac5
PE
10108 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10109
847ab9d1 10110 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10111 * data.c (atof): Remove decl; no longer used or needed.
10112 (digit_to_number): Move to lread.c.
10113 (Fstring_to_number): Use new string_to_number function, to be
10114 consistent with how the Lisp reader treats infinities and NaNs.
10115 Do not assume that floating-point numbers represent EMACS_INT
10116 without losing information; this is not true on most 64-bit hosts.
10117 Avoid double-rounding errors, by insisting on integers when
10118 parsing non-base-10 numbers, as the documentation specifies.
10119 * lisp.h (string_to_number): New decl, replacing ...
10120 (isfloat_string): Remove.
bc0a5c13 10121 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10122 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10123 appears to have been a coding error. Similarly, do not accept
10124 strings like +-1e0 as floating point numbers. Do not report
10125 overflow for integer overflows unless the base is not 10 which
10126 means we have no simple and reliable way to continue.
10127 Break out the floating-point parsing into a new
10128 function string_to_number, so that Fstring_to_number parses
10129 floating point numbers consistently with the Lisp reader.
04f2d78b 10130 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10131 (E_CHAR, EXP_INT): Remove, replacing with ...
10132 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10133 (string_to_number): New function, replacing isfloat_string.
10134 This function checks for valid syntax and produces the resulting
10135 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10136 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10137 so that overflow for non-base-10 numbers is reported only when
10138 there's no portable and simple way to convert to floating point.
452f4150 10139
67769ffc
PE
10140 * textprop.c (set_text_properties_1): Rewrite for clarity,
10141 and to avoid GCC warning about integer overflow.
10142
c20db43f
PE
10143 * intervals.h (struct interval): Use EMACS_INT for members
10144 where EMACS_UINT might cause problems. See
10145 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10146 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10147 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10148 All uses changed.
37aa2f85
PE
10149 (offset_intervals): Tell GCC not to worry about length overflow
10150 when negating a negative length.
c20db43f 10151
2538aa2f
PE
10152 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10153 (overrun_check_free): Likewise.
10154
f2d3008d
PE
10155 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10156 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10157 word size.
10158
ec8df744
PE
10159 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10160 (gnutls_make_error): Rename local to avoid shadowing.
10161 (gnutls_emacs_global_deinit): ifdef out; not used.
10162 (Fgnutls_boot): Use const for pointer to readonly storage.
10163 Comment out unused local. Fix pointer signedness problems.
10164
640ee02d
PE
10165 * lread.c (openp): Don't stuff size_t into an 'int'.
10166 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10167 about possible signed overflow.
10168
6048fb2a
PE
10169 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10170 (GDK_KEY_g): Don't define if already defined.
10171 (xg_prepare_tooltip): Avoid pointer signedness problem.
10172 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10173
fa3c87e1
PE
10174 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10175 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10176
2172544b
PE
10177 * xfns.c (Fx_window_property): Simplify a bit,
10178 to make a bit faster and to avoid GCC 4.6.0 warning.
10179 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10180
9b821a21
PE
10181 * fns.c (internal_equal): Don't assume size_t fits in int.
10182
3c616cfa
PE
10183 * alloc.c (compact_small_strings): Tighten assertion a little.
10184
c2982e87
PE
10185 Replace pEd with more-general pI, and fix some printf arg casts.
10186 * lisp.h (pI): New macro, generalizing old pEd macro to other
10187 conversion specifiers. For example, use "...%"pI"d..." rather
10188 than "...%"pEd"...".
10189 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10190 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10191 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10192 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10193 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10194 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10195 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10196 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10197 64-bit hosts.
10198 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10199 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10200 * print.c (safe_debug_print, print_object): Likewise.
10201 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10202 to int.
6f04d126
PE
10203 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10204 avoiding the 0 flag, which is not portable.
c2982e87
PE
10205 * process.c (Fmake_network_process): Use pI to avoid cast.
10206 * region-cache.c (pp_cache): Likewise.
10207 * xdisp.c (decode_mode_spec): Likewise.
10208 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10209 behavior on 64-bit hosts with printf arg.
6f04d126 10210 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10211 (x_stop_queuing_selection_requests): Likewise.
10212 (x_get_window_property): Don't truncate byte count to an 'int'
10213 when tracing.
0b432f21 10214
5e073ec7
PE
10215 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10216 here, since it parses constructs like leading '-' and spaces,
10217 which are not wanted; and it overflows with large numbers.
10218 Instead, simply match F[0-9]+, which is what is wanted anyway.
10219
36372bf9
PE
10220 * alloc.c: Remove unportable assumptions about struct layout.
10221 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10222 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10223 (allocate_vectorlike, make_pure_vector): Use the new macros,
10224 plus offsetof, to remove unportable assumptions about struct layout.
10225 These assumptions hold on all porting targets that I know of, but
10226 they are not guaranteed, they're easy to remove, and removing them
10227 makes further changes easier.
10228
0b432f21
PE
10229 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10230 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10231 (string_overrun_cookie): Now const. Use initializers that
10232 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10233 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10234 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10235 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10236 multiple of sizeof (EMACS_INT); it need not be, if
10237 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10238 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10239
895009e1
JB
102402011-04-26 Juanma Barranquero <lekktu@gmail.com>
10241
10242 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10243
6a7a1b0b
TZ
102442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10245
10246 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10247 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10248 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10249
841a1577 102502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10251
10252 * lisp.h (Qdebug): List symbol.
895009e1 10253 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10254 * keyboard.c (debug-on-event): New variable.
10255 (handle_user_signal): Break into debugger when debug-on-event
10256 matches the current signal symbol.
10257
f2d3ba6f
DN
102582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10259
10260 * alloc.c (check_sblock, check_string_bytes)
10261 (check_string_free_list): Convert to standard C.
10262
42ce4c63
TZ
102632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10264
10265 * w32.c (emacs_gnutls_push): Fix typo.
10266
825cd63c
EZ
102672011-04-25 Eli Zaretskii <eliz@gnu.org>
10268
fb11d64d
EZ
10269 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10270 "cast to pointer from integer of different size".
10271
825cd63c
EZ
10272 Improve doprnt and its use in verror. (Bug#8545)
10273 * doprnt.c (doprnt): Document the set of format control sequences
10274 supported by the function. Use SAFE_ALLOCA instead of always
10275 using `alloca'.
10276
10277 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10278 is one byte too soon. Don't use xrealloc; instead xfree and
10279 xmalloc anew.
10280
e061a11b
TZ
102812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10282
10283 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10284 callbacks stage.
10285
10286 * gnutls.c: Renamed global_initialized to
10287 gnutls_global_initialized. Added internals for the
10288 :verify-hostname-error, :verify-error, and :verify-flags
10289 parameters of `gnutls-boot' and documented those parameters in the
10290 docstring. Start callback support.
9173deec
JB
10291 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10292 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10293 on error. Return error code.
e061a11b
TZ
10294 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10295 (emacs_gnutls_read): Likewise.
10296 (Fgnutls_boot): Return handshake error code.
10297 (emacs_gnutls_handle_error): New function.
10298 (wsaerror_to_errno): Likewise.
10299
10300 * w32.h (emacs_gnutls_pull): Add prototype.
10301 (emacs_gnutls_push): Likewise.
10302
10303 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10304 (emacs_gnutls_push): Likewise.
10305
103062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10307
10308 * process.c (wait_reading_process_output): Check if GnuTLS
10309 buffered some data internally if no FDs are set for TLS
10310 connections.
10311
10312 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10313 (LIBS): Link to USER_LIBS.
10314 ($(BLD)/gnutls.$(0)): New target.
10315
fa6996bc
EZ
103162011-04-24 Eli Zaretskii <eliz@gnu.org>
10317
eb35682e
EZ
10318 * xdisp.c (handle_single_display_spec): Rename the
10319 display_replaced_before_p argument into display_replaced_p, to
10320 make it consistent with the commentary. Fix typos in the
10321 commentary.
10322
e2ad650c
EZ
10323 * textprop.c (syms_of_textprop): Remove dead code.
10324 (copy_text_properties): Delete obsolete commentary about an
10325 interface that was deleted long ago. Fix typos in the description
10326 of arguments.
10327
1b2de274
EZ
10328 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10329 to changes in oldXMenu/XMenu.h from 2011-04-16.
10330 <menu_help_message, prev_menu_help_message>: Constify.
10331 (IT_menu_make_room): menu->help_text is now `const char **';
10332 adjust.
10333
10334 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10335 to changes in oldXMenu/XMenu.h from 2011-04-16.
10336 (struct XMenu): Declare `help_text' `const char **'.
10337
10338 * xfaces.c <Qunspecified>: Make extern again.
10339
10340 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10341 required by POSIX.
1b2de274 10342
762b15be
EZ
10343 * doc.c (get_doc_string): Improve the format passed to `error'.
10344
10345 * doprnt.c (doprnt): Improve commentary.
10346
10347 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10348
10349 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10350 them with etags.
10351
f1052e5d
EZ
10352 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10353 changes in globals.h immediately force recompilation.
762b15be
EZ
10354 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10355 $(CURDIR)/s/ms-w32.h.
10356 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10357
fa6996bc
EZ
10358 * character.c (Fchar_direction): Function deleted.
10359 (syms_of_character): Don't defsubr it.
10360 <char-direction-table>: Deleted.
10361
e6c3da20
EZ
103622011-04-23 Eli Zaretskii <eliz@gnu.org>
10363
10364 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10365 * doprnt.c: Include limits.h.
10366 (SIZE_MAX): New macro.
04f2d78b
CB
10367 (doprnt): Return a size_t value. 2nd arg is now size_t.
10368 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10369 Improve overflow protection. Support `l' modifier for integer
10370 conversions. Support %l conversion. Don't assume an EMACS_INT
10371 argument for integer conversions and for %c.
10372
10373 * lisp.h (doprnt): Restore prototype.
10374
10375 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10376 $(SRC)/character.h.
10377
10378 * Makefile.in (base_obj): Add back doprnt.o.
10379
10380 * deps.mk (doprnt.o): Add back prerequisites.
10381 (callint.o): Depend on character.h.
10382
10383 * eval.c (internal_lisp_condition_case): Include the handler
10384 representation in the error message.
10385 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10386 when breaking from the loop.
10387
10388 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10389
10390 * callint.c (Fcall_interactively): When displaying error message
10391 about invalid control letter, pass the character's codepoint, not
10392 a pointer to its multibyte form. Improve display of the character
10393 in octal and display also its hex code.
10394
10395 * character.c (char_string): Use %x to display the (unsigned)
10396 codepoint of an invalid character, to avoid displaying a bogus
10397 negative value.
10398
10399 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10400 `error', not SYMBOL_NAME itself.
10401
10402 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10403 character arguments to `error'.
10404
10405 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10406 to `error' in error message about FINAL_CHAR argument. Make sure
10407 FINAL_CHAR is a character, and use %c when it is passed as
10408 argument to `error'.
10409
4ffd0d6b 104102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10411
10412 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10413
10414 * w32.c: Include <time.h>.
10415 (sys_localtime): New function.
10416
4ffd0d6b 104172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10418
10419 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10420
4ffd0d6b 10421 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10422
4ffd0d6b 104232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10424
4ffd0d6b
GM
10425 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10426 zombies (Bug#8467).
aac0c6e3 10427
04c56954
EZ
104282011-04-19 Eli Zaretskii <eliz@gnu.org>
10429
10430 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10431 gl_state.e_property when gl_state.object is Qt.
10432
10433 * insdel.c (make_gap_larger): Remove limitation of buffer size
10434 to <= INT_MAX.
10435
16a43933
CY
104362011-04-18 Chong Yidong <cyd@stupidchicken.com>
10437
10438 * xdisp.c (lookup_glyphless_char_display)
10439 (produce_glyphless_glyph): Handle cons cell entry in
10440 glyphless-char-display.
10441 (Vglyphless_char_display): Document it.
10442
10443 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10444 glyphless-char-display.
10445
4581706e
CY
104462011-04-17 Chong Yidong <cyd@stupidchicken.com>
10447
10448 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10449
10450 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10451
10452 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10453 definition for no-X builds.
10454
4887c6e2 104552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10456
fd35b6f9
PE
10457 Static checks with GCC 4.6.0 and non-default toolkits.
10458
5c1ccb01
PE
10459 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10460
006c5daa
PE
10461 * process.c (keyboard_bit_set): Define only if SIGIO.
10462 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10463 (send_process): Repair possible setjmp clobbering.
10464
efc736d3
PE
10465 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10466
4e2fe2e6
PE
10467 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10468
f97334a2
PE
10469 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10470
4e75f29d
PE
10471 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10472 Define only if needed.
10473
90efadd1
PE
10474 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10475 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10476 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10477
3c647824
PE
10478 * dispextern.h (struct redisplay_interface): Rename param
10479 to avoid shadowing.
e264f262 10480 * termhooks.h (struct terminal): Likewise.
761383f4 10481 * xterm.c (xembed_send_message): Likewise.
3c647824 10482
b58c5c4a
PE
10483 * insdel.c (make_gap_smaller): Define only if
10484 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10485
cad59032
PE
10486 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10487 it.
10488
c339dc2e
PE
10489 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10490 so that we aren't warned about unused symbols.
10491
91a3e27b
PE
10492 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10493
399c71d3 10494 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10495
8ffc96f5
PE
10496 * xfns.c (x_real_positions): Mark locals as initialized.
10497
eef9bc79
PE
10498 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10499
098db9dd
PE
10500 * xterm.c: Fix problems found by static analysis with other toolkits.
10501 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10502 (x_dispatch_event): Declare static if USE_GTK, and
10503 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10504 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10505 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10506 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10507 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10508
eb18f6cc
PE
10509 * xmenu.c (menu_help_callback): Pointer type fixes.
10510 Use const pointers when pointing at readonly data. Avoid pointer
10511 signedness clashes.
10512 (FALSE): Remove unused macro.
10513 (update_frame_menubar): Remove unused decl.
10514
1fe72bf8
PE
10515 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10516
60d9e1db
PE
10517 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10518 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10519 (single_menu_item): Rename local to avoid shadowing.
10520
39261c26
PE
10521 * keyboard.c (make_lispy_event): Remove unused local var.
10522
018c5e19
PE
10523 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10524 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10525
63d2b86e
PE
10526 * bitmaps: Change bitmaps from unsigned char back to the X11
10527 compatible char. Avoid the old compiler warnings about
10528 out-of-range initializers by using, for example, '\xab' rather
10529 than 0xab.
10530
aefd87e1
PE
10531 * xgselect.c (xgselect_initialize): Check vs interface
10532 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10533
bf501fb9
PE
10534 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10535
e9829fdf
PE
10536 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10537 to read-only memory.
10538
1086c095
PE
10539 * fns.c (vector): Remove; this old hack is no longer needed.
10540
2baccd04 10541 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10542 Remove unused var.
dde42981 10543 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10544
72391843 10545 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10546
436c16df 10547 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10548 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10549 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10550
92bb796d 10551 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10552 (x_term_init): Remove local to avoid shadowing.
92bb796d 10553
764430a3 10554 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10555
10556 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10557 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10558
d1dfb56c
EZ
105592011-04-16 Eli Zaretskii <eliz@gnu.org>
10560
c4354cb4
EZ
10561 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10562
d1dfb56c
EZ
10563 Fix regex.c, syntax.c and friends for buffers > 2GB.
10564 * syntax.h (struct gl_state_s): Declare character position members
10565 EMACS_INT.
10566
10567 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10568
04f2d78b
CB
10569 * textprop.c (verify_interval_modification, interval_of):
10570 Declare arguments EMACS_INT.
d1dfb56c
EZ
10571
10572 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10573 EMACS_INT.
10574
10575 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10576
10577 * indent.c (Fvertical_motion): Local variable it_start is now
10578 EMACS_INT.
10579
10580 * regex.c (re_match, re_match_2, re_match_2_internal)
10581 (bcmp_translate, regcomp, regexec, print_double_string)
10582 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10583 (re_compile_pattern, re_exec): Declare arguments and local
10584 variables `size_t' and `ssize_t' and return values `regoff_t', as
10585 appropriate.
10586 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10587 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10588 <compile_stack_type>: `size' and `avail' are now `size_t'.
10589
10590 * regex.h <regoff_t>: Use ssize_t, not int.
10591 (re_search, re_search_2, re_match, re_match_2): Arguments that
10592 specify buffer/string position and length are now ssize_t and
10593 size_t. Return type is regoff_t.
10594
613052cd
BK
105952011-04-16 Ben Key <bkey76@gmail.com>
10596
10597 * nsfont.m: Fixed bugs in ns_get_family and
10598 ns_descriptor_to_entity that were caused by using free to
10599 deallocate memory blocks that were allocated by xmalloc (via
10600 xstrdup). This caused Emacs to crash when compiled with
10601 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10602 --enable-checking=xmallocoverrun). xfree is now used to
10603 deallocate these memory blocks.
10604
4170f62f 106052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10606
71b41406
PE
10607 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10608
9587a89d
PE
10609 emacs_write: Accept and return EMACS_INT for sizes.
10610 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10611 et seq.
10612 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10613 Accept and return EMACS_INT.
10614 (emacs_gnutls_write): Return the number of bytes written on
10615 partial writes.
10616 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10617 (emacs_read, emacs_write): Remove check for negative size, as the
10618 Emacs source code has been audited now.
9587a89d
PE
10619 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10620 (emacs_read, emacs_write): Use it.
273a5f82
PE
10621 * process.c (send_process): Adjust to the new signatures of
10622 emacs_write and emacs_gnutls_write. Do not attempt to store
10623 a byte offset into an 'int'; it might overflow.
9587a89d 10624 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10625
3e047f51
PE
10626 * sound.c: Don't assume sizes fit in 'int'.
10627 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10628 Return EMACS_INT, not int.
3e047f51 10629 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10630 Accept EMACS_INT, not int.
10631 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10632 record read return values.
10633
cc39a9db
BK
106342011-04-15 Ben Key <bkey76@gmail.com>
10635
c9d0ec6d
JB
10636 * keyboard.c (Qundefined): Don't declare static since it is used
10637 in nsfns.m.
10638 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10639 static since they are used in nsfont.m.
cc39a9db 10640
6c60eb9f
SM
106412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10642
10643 * process.c (Qprocessp): Don't declare static.
10644 * lisp.h (Qprocessp): Declare again.
10645
7990b61a
JB
106462011-04-15 Juanma Barranquero <lekktu@gmail.com>
10647
10648 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10649
5d4cb038
PE
106502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10651
8bd7b830 10652 Improve C-level modularity by making more things 'static'.
cd64ea1d 10653
e3b27b31
PE
10654 Don't publish debugger-only interfaces to other modules.
10655 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10656 (verify_bytepos, count_markers): Move decls to the only modules
10657 that need them.
10658 * region-cache.h (pp_cache): Likewise.
10659 * window.h (check_all_windows): Likewise.
10660 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10661
5d4cb038
PE
10662 * sysdep.c (croak): Now static, if
10663 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10664 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10665
10666 * alloc.c (refill_memory_reserve): Now static if
10667 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10668 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10669
e87b6180
PE
10670 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10671 Define only if USE_LUCID.
10672
ac64929e
PE
10673 * xrdb.c (x_customization_string, x_rm_string): Now static.
10674
6f37259d
PE
10675 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10676 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10677
1683e3ab
PE
10678 * xdisp.c (draw_row_with_mouse_face): Now static.
10679 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10680
de9c2632
PE
10681 * window.h (check_all_windows): Mark externally visible.
10682
2b96acb7
PE
10683 * window.c (window_deletion_count): Now static.
10684
10685 * undo.c: Make symbols static if they're not exported.
10686 (last_undo_buffer, last_boundary_position, pending_boundary):
10687 Now static.
10688
50436f33
PE
10689 * textprop.c (interval_insert_behind_hooks): Now static.
10690 (interval_insert_in_front_hooks): Likewise.
10691
64520e5c
PE
10692 * term.c: Make symbols static if they're not exported.
10693 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10694 (max_frame_lines, tty_set_terminal_modes):
10695 (tty_reset_terminal_modes, tty_turn_off_highlight):
10696 (get_tty_terminal): Now static.
10697 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10698 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10699 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10700 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10701 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10702
1fa53021
PE
10703 * sysdep.c: Make symbols static if they're not exported.
10704 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10705 Now static.
10706 (sigprocmask_set, full_mask): Remove; unused.
10707 (wait_debugging): Mark as visible.
10708 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10709 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10710
d4b43b22
PE
10711 * syntax.c (syntax_temp): Define only if !__GNUC__.
10712
b7c513d0
PE
10713 * sound.c (current_sound_device, current_sound): Now static.
10714
989b29ad
PE
10715 * search.c (searchbufs, searchbuf_head): Now static.
10716
13a55a78
PE
10717 * scroll.c (scroll_cost): Remove; unused.
10718 * dispextern.h (scroll_cost): Remove decl.
10719
de68a1fc
PE
10720 * region-cache.h (pp_cache): Mark as externally visible.
10721
40ccffa6
PE
10722 * process.c: Make symbols static if they're not exported.
10723 (process_tick, update_tick, create_process, chan_process):
10724 (Vprocess_alist, proc_buffered_char, datagram_access):
10725 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10726 (deactivate_process): Mark defn as static, as well as decl.
10727 * lisp.h (create_process): Remove decl.
10728 * process.h (chan_process, Vprocess_alist): Remove decls.
10729
ad64fc97
PE
10730 * print.c: Make symbols static if they're not exported.
10731 (print_depth, new_backquote_output, being_printed, print_buffer):
10732 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10733 (print_interval, print_number_index, initial_stderr_stream):
10734 Now static.
10735 * lisp.h (Fprinc): Remove decl.
10736 (debug_output_compilation_hack): Mark as externally visible.
10737
adddb265
PE
10738 * sysdep.c (croak): Move decl from here to syssignal.h.
10739 * syssignal.h (croak): Put it here, so the API can be checked when
10740 'croak' is called from dissociate_if_controlling_tty.
10741
1717ede2
PE
10742 * minibuf.c: Make symbols static if they're not exported.
10743 (minibuf_save_list, choose_minibuf_frame): Now static.
10744 * lisp.h (choose_minibuf_frame): Remove decl.
10745
fa5fb2bc
PE
10746 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10747
1e3890d1
PE
10748 * lread.c: Make symbols static if they're not exported.
10749 (read_objects, initial_obarray, oblookup_last_bucket_number):
10750 Now static.
10751 (make_symbol): Remove; unused.
10752 * lisp.h (initial_obarray, make_symbol): Remove decls.
10753
8a1414fa
PE
10754 * keyboard.c: Make symbols static if they're not exported.
10755 (single_kboard, recent_keys_index, total_keys, recent_keys):
10756 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10757 (this_single_command_key_start, echoing, last_auto_save):
10758 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10759 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10760 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10761 (Vlispy_mouse_stem, double_click_count):
10762 Now static.
10763 (force_auto_save_soon): Define only if SIGDANGER.
10764 (ignore_mouse_drag_p): Now static if
10765 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10766 (print_help): Remove; unused.
10767 (stop_character, last_timer_event): Mark as externally visible.
10768 * keyboard.h (ignore_mouse_drag_p): Declare only if
10769 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10770 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10771 * lisp.h (echoing): Remove decl.
10772 (force_auto_save_soon): Declare only if SIGDANGER.
10773 * xdisp.c (redisplay_window): Simplify code, to make it more
10774 obvious that ignore_mouse_drag_p is not accessed if !defined
10775 USE_GTK && !defined HAVE_NS.
10776
93ea6e8f
PE
10777 * intervals.c: Make symbols static if they're not exported.
10778 (merge_properties_sticky, merge_interval_right, delete_interval):
10779 Now static.
10780 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10781
77382fcc
PE
10782 * insdel.c: Make symbols static if they're not exported.
10783 However, leave prepare_to_modify_buffer alone. It's never
10784 called from outside this function, but that appears to be a bug.
10785 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10786 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10787 (adjust_after_replace_noundo): Remove; unused.
10788 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10789 (signal_before_change): Remove decls.
77382fcc 10790
9306c32e
PE
10791 * indent.c (val_compute_motion, val_vmotion): Now static.
10792
cd44d2eb
PE
10793 * image.c: Make symbols static if they're not exported.
10794 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10795 if USE_GTK.
10796 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10797 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10798
ad9a7a06
PE
10799 * fringe.c (standard_bitmaps): Now static.
10800 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10801
81626931
PE
10802 * frame.c: Make symbols static if they're not exported.
10803 (x_report_frame_params, make_terminal_frame): Now static.
10804 (get_frame_param): Now static, unless HAVE_NS.
10805 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10806 (x_get_resource_string): Remove; not used.
10807 * frame.h (make_terminal_frame, x_report_frame_params):
10808 (x_get_resource_string); Remove decls.
10809 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10810 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10811
239f9db9
PE
10812 * font.c, fontset.c: Make symbols static if they're not exported.
10813 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10814 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10815 * font.c (font_close_object): Now static.
10816 * font.h (font_close_object): Remove.
10817 * fontset.c (FONTSET_OBJLIST): Remove.
10818 (free_realized_fontset) #if-0 the body, which does nothing.
10819 (face_suitable_for_char_p): #if-0, as it's never called.
10820 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10821 * xfaces.c (face_at_string_position):
10822 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10823 since 0 is always ASCII.
10824
dfcf3579
PE
10825 * fns.c (weak_hash_tables): Now static.
10826
5045092b
PE
10827 * fileio.c: Make symbols static if they're not exported.
10828 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10829 (Vwrite_region_annotation_buffers): Now static.
10830
57a96f5c
PE
10831 * eval.c: Make symbols static if they're not exported.
10832 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10833 * lisp.h (backtrace_list): Remove decl.
10834
35f08c38
PE
10835 * emacs.c: Make symbols static if they're not exported.
10836 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10837 (fatal_error_code, fatal_error_signal_hook, standard_args):
10838 Now static.
10839 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10840 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10841 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10842 * lisp.h (fatal_error_signal_hook): Remove decl.
10843 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10844
f44bd759
PE
10845 * editfns.c: Move a (normally-unused) function to its only use.
10846 * editfns.c, lisp.h (get_operating_system_release): Remove.
10847 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10848 worth the hassle of breaking this out.
10849
b532497d
PE
10850 * xterm.c: Make symbols static if they're not exported.
10851 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10852 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10853 (x_destroy_window, x_delete_display):
10854 Now static.
10855 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10856 (x_mouse_leave): Remove; unused.
10857 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10858 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10859 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10860 Remove decls.
10861 (x_mouse_leave): Declare only if WINDOWSNT.
10862 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10863 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10864 USE_X_TOOLKIT.
10865
1675728f
PE
10866 * ftxfont.c: Make symbols static if they're not exported.
10867 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10868 HAVE_FREETYPE.
10869 * font.h (ftxfont_driver): Likewise.
10870
e4cebfca
PE
10871 * xfns.c: Make symbols static if they're not exported.
10872 (x_last_font_name, x_display_info_for_name):
10873 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10874 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10875 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10876 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10877 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10878 (last_show_tip_args): Now static.
10879 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10880 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10881 (x_screen_planes): Remove; unused.
10882 * dispextern.h (x_screen_planes): Remove decl.
10883
5bf46f05
PE
10884 * dispnew.c: Make symbols static if they're not exported.
10885 * dispextern.h (redraw_garbaged_frames, scrolling):
10886 (increment_row_positions): Remove.
10887 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10888 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10889 Now static.
10890 (redraw_garbaged_frames): Remove; unused.
10891
435f4c28
PE
10892 * xfaces.c: Make symbols static if they're not exported.
10893 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10894 Remove decls.
10895 * xterm.h (defined_color): Remove decls.
10896 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10897 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10898 (menu_face_changed_default, defined_color, free_realized_face):
10899 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10900 (ascii_face_of_lisp_face): Remove; unused.
10901
8524aef3
PE
10902 * xdisp.c: Make symbols static if they're not exported.
10903 * dispextern.h (scratch_glyph_row, window_box_edges):
10904 (glyph_to_pixel_coords, set_cursor_from_row):
10905 (get_next_display_element, set_iterator_to_next):
10906 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10907 (show_mouse_face): Remove decls
10908 * frame.h (message_buf_print): Likewise.
10909 * lisp.h (pop_message, set_message, check_point_in_composition):
10910 Likewise.
10911 * xterm.h (set_vertical_scroll_bar): Likewise.
10912 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10913 (message_buf_print, scratch_glyph_row, displayed_buffer):
10914 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10915 (get_next_display_element, show_mouse_face, window_box_edges):
10916 (frame_to_window_pixel_xy, check_point_in_composition):
10917 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10918 (glyph_to_pixel_coords): Remove; unused.
10919
16390cd2
PE
10920 * dired.c (file_name_completion): Now static.
10921
10922 * dbusbind.c (xd_in_read_queued_messages): Now static.
10923
a25f4dfa
PE
10924 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10925 * data.c (circular_list_error): Remove.
10926
14a9c8df
PE
10927 * commands.h (last_point_position, last_point_position_buffer):
10928 (last_point_position_window): Remove decls.
10929 * keyboard.c: Make these variables static.
10930
04f2d78b
CB
10931 * coding.h (coding, code_convert_region, encode_coding_gap):
10932 Remove decls.
74ab6df5
PE
10933 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10934 (iso_code_class, detect_coding, code_convert_region): Now static.
10935 (encode_coding_gap): Remove; unused.
10936
38dfbee1
PE
10937 * chartab.c (chartab_chars, chartab_bits): Now static.
10938
a2cb4e63
PE
10939 * charset.h (charset_iso_8859_1): Remove decl.
10940 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10941 Now static.
10942
127198fd
PE
10943 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10944 * ccl.c (Vccl_program_table): Now static.
10945 (check_ccl_update): Remove; unused.
10946
d85b608f
PE
10947 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10948 * category.h: ... from here.
10949 * category.c (check_category_table, set_category_set): Now static.
10950
31cd66f3
PE
10951 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10952 * lisp.h: Remove these decls.
10953
c358e587
PE
10954 * buffer.c (buffer_count): Remove unused var.
10955
e78aecca
PE
10956 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10957 so that it's not optimized away.
10958 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10959 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10960 exported only to the debugger.
10961
e192d7d3 10962 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10963 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10964
92470028
PE
10965 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10966 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10967 was inaccessible from Lisp.
10968 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10969 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10970
244ed907
PE
10971 alloc.c: Import and export fewer symbols, and remove unused items.
10972 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10973 is defined.
10974 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10975 it's not optimized away by whole-program optimization.
10976 (message_enable_multibyte, free_misc): Remove.
10977 (catchlist, handlerlist, mark_backtrace):
10978 Declare only if BYTE_MARK_STACK.
10979 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10980 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10981 (message_enable_multibyte): Remove decl.
10982 (free_misc, interval_free_list, float_block, float_block_index):
10983 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10984 (cons_free_list, last_marked_index):
10985 Now static.
10986 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10987 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10988 (mark_backtrace): Define only if BYTE_MARK_STACK.
10989 * xdisp.c (message_enable_multibyte): Now static.
10990
61c2b50e 10991 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10992 This makes it easier for human readers (and static analyzers)
10993 to see whether these variables are used from other modules.
10994 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10995 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10996 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10997 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10998 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10999 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11000 * xmenu.c, xselect.c:
11001 Declare Q* vars static if they are not used in other modules.
11002 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11003 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11004 Remove decls of unexported vars.
11005 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11006
95c82688
PE
11007 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11008
16a97296
PE
11009 Make Emacs functions such as Fatom 'static' by default.
11010 This makes it easier for human readers (and static analyzers)
11011 to see whether these functions can be called from other modules.
11012 DEFUN now defines a static function. To make the function external
11013 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11014 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11015 (Finit_image_library):
16a97296
PE
11016 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11017 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11018 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11019 Remove decls, since these functions are now static.
11020 (Funintern, Fget_internal_run_time): New decls, since these functions
11021 were already external.
95c82688 11022
16a97296
PE
11023 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11024 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11025 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11026 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11027 * keyboard.c, keymap.c, lread.c:
11028 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11029 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11030 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11031 Mark functions with DEFUE instead of DEFUN,
11032 if they are used in other modules.
11033 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11034 decls for now-static functions.
11035 * buffer.h (Fdelete_overlay): Remove decl.
11036 * callproc.c (Fgetenv_internal): Mark as internal.
11037 * composite.c (Fremove_list_of_text_properties): Remove decl.
11038 (Fcomposition_get_gstring): New forward static decl.
11039 * composite.h (Fcomposite_get_gstring): Remove decl.
11040 * dired.c (Ffile_attributes): New forward static decl.
11041 * doc.c (Fdocumntation_property): New forward static decl.
11042 * eval.c (Ffetch_bytecode): New forward static decl.
11043 (Funintern): Remove extern decl; now in .h file where it belongs.
11044 * fileio.c (Fmake_symbolic_link): New forward static decl.
11045 * image.c (Finit_image_library): New forward static decl.
11046 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11047 * intervals.h (Fprevious_property_change):
11048 (Fremove_list_of_text_properties): Remove decls.
11049 * keyboard.c (Fthis_command_keys): Remove decl.
11050 (Fcommand_execute): New forward static decl.
11051 * keymap.c (Flookup_key): New forward static decl.
11052 (Fcopy_keymap): Now static.
11053 * keymap.h (Flookup_key): Remove decl.
11054 * process.c (Fget_process): New forward static decl.
11055 (Fprocess_datagram_address): Mark as internal.
11056 * syntax.c (Fsyntax_table_p): New forward static decl.
11057 (skip_chars): Remove duplicate decl.
11058 * textprop.c (Fprevious_property_change): New forward static decl.
11059 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11060 Now internal.
11061 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11062 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11063
785bbd42
PE
11064 * editfns.c (Fformat): Remove unreachable code.
11065
8b913b57
AS
110662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11067
11068 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11069 change. (Bug#8496)
11070
a6744a35
EZ
110712011-04-13 Eli Zaretskii <eliz@gnu.org>
11072
11073 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11074 when at ZV. (Bug#8487)
11075
e7974947
AS
110762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11077
baad03f0
AS
11078 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11079 (Bug#8437)
11080 * keyboard.c (parse_tool_bar_item): Likewise.
11081 * sound.c (sound_cleanup, alsa_close): Likewise.
11082 * termcap.c (tgetent): Likewise.
11083 * xfns.c (x_default_font_parameter): Likewise.
11084 * xsettings.c (read_and_apply_settings): Likewise.
11085
e7974947
AS
11086 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11087 (overrun_check_free): Protoize.
11088
28272684
PE
110892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11090
11091 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11092 since callers should never pass a negative size.
11093 Change the signature to match that of plain 'read' and 'write'; see
11094 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11095 * lisp.h: Update prototypes of emacs_write and emacs_read.
11096
11997c76
EZ
110972011-04-11 Eli Zaretskii <eliz@gnu.org>
11098
11099 * xdisp.c (redisplay_window): Don't try to determine the character
11100 position of the scroll margin if the window start point w->startp
e896f03c 11101 is outside the buffer's accessible region. (Bug#8468)
11997c76 11102
8a2cbd72
EZ
111032011-04-10 Eli Zaretskii <eliz@gnu.org>
11104
11105 Fix write-region and its subroutines for buffers > 2GB.
11106 * fileio.c (a_write, e_write): Modify declaration of arguments and
11107 local variables to support buffers larger than 2GB.
11108 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11109
11110 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11111 argument, local variables, and return value.
11112
11113 * lisp.h: Update prototypes of emacs_write and emacs_read.
11114
11115 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11116
4073e537 111172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11118
1ebfdcb6
PE
11119 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11120
b2ded58d
PE
11121 Fix more problems found by GCC 4.6.0's static checks.
11122
7d66342c
PE
11123 * xdisp.c (vmessage): Use a better test for character truncation.
11124
bbf47d44
PE
11125 * charset.c (load_charset_map): <, not <=, for optimization,
11126 and to avoid potential problems with integer overflow.
9248994d 11127 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11128 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11129 * editfns.c (Fformat): Likewise.
1e69125e 11130 * syntax.c (skip_chars): Likewise.
3befa583 11131
e3019616
PE
11132 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11133 This also lets GCC 4.6.0 generate slightly better loop code.
11134
becfa255
PE
11135 * callint.c (Fcall_interactively): <, not <=, for optimization.
11136 (Fcall_interactively): Count the number of arguments produced,
11137 not the number of arguments given. This is simpler and lets GCC
11138 4.6.0 generate slightly better code.
11139
dae0cd48
PE
11140 * ftfont.c: Distingish more carefully between FcChar8 and char.
11141 The previous code passed unsigned char * to a functions like
11142 strlen and xstrcasecmp that expect char *, which does not
11143 conform to the C standard.
11144 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11145 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11146 char * when the C standard requires it.
11147
76032d70
PE
11148 * keyboard.c (read_char): Remove unused var.
11149
eb3f1cc8
PE
11150 * eval.c: Port to Windows vsnprintf (Bug#8435).
11151 Include <limits.h>.
11152 (SIZE_MAX): Define if the headers do not.
11153 (verror): Do not give up if vsnprintf returns a negative count.
11154 Instead, grow the buffer. This ports to Windows vsnprintf, which
11155 does not conform to C99. Problem reported by Eli Zaretskii.
11156 Also, simplify the allocation scheme, by avoiding the need for
11157 calling realloc, and removing the ALLOCATED variable.
11158
70476b54
PE
11159 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11160
12020a9e
PE
11161 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11162 But keep the doprint source code for now, as we might revamp it
11163 and use it again (Bug#8435).
ea6c7ae6
PE
11164 * lisp.h (doprnt): Remove.
11165 * Makefile.in (base_obj): Remove doprnt.o.
11166 * deps.mk (doprnt.o): Remove.
11167
5fdb398c
PE
11168 error: Print 32- and 64-bit integers portably (Bug#8435).
11169 Without this change, on typical 64-bit hosts error ("...%d...", N)
11170 was used to print both 32- and 64-bit integers N, which relied on
11171 undefined behavior.
61bdb816 11172 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11173 * lisp.h (error, verror): Mark as printf-like functions.
11174 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11175 Report overflow in size calculations when allocating printf buffer.
11176 Do not truncate output string at its first null byte.
11177 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11178 Truncate the output at a character boundary, since vsnprintf does not
11179 do that.
11180 * charset.c (check_iso_charset_parameter): Convert internal
11181 character to string before calling 'error', since %c now has the
11182 printf meaning.
11183 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11184 overflow when computing char to be passed to 'error'. Do not
11185 pass Lisp_Object to 'error'; pass the integer instead.
11186 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11187 formatted with plain %d.
11188
b189fa66
PE
11189 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11190
bff87ef0
PE
11191 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11192
7e2cac20
PE
11193 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11194
ce4d90b5
PE
11195 * xterm.c (x_catch_errors): Remove duplicate declaration.
11196
266c9547
PE
11197 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11198
79c49ad2
PE
11199 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11200
368f4090
JM
112012011-04-10 Jim Meyering <meyering@redhat.com>
11202
11203 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11204 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11205 return ssize_t not "int", and use size_t as the buffer length.
11206 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11207 * gnutls.h: Update declarations.
11208 * process.c (read_process_output): Use ssize_t, to match.
11209 (send_process): Likewise.
11210
a32d4040
CY
112112011-04-09 Chong Yidong <cyd@stupidchicken.com>
11212
11213 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11214
8546720e 112152011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11216
04f2d78b
CB
11217 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11218 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11219
8546720e
GM
11220 * xterm.c (handle_one_xevent):
11221 * xmenu.c (create_and_show_popup_menu):
11222 * xselect.c (x_decline_selection_request)
11223 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11224
0a2f5c1a 112252011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11226
11227 Fix some uses of `int' instead of EMACS_INT.
11228 * search.c (string_match_1, fast_string_match)
11229 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11230 (scan_buffer, find_next_newline_no_quit)
11231 (find_before_next_newline, search_command, Freplace_match)
11232 (Fmatch_data): Make some `int' variables be EMACS_INT.
11233
11234 * xdisp.c (display_count_lines): 3rd argument and return value now
11235 EMACS_INT. All callers changed.
11236 (pint2hrstr): Last argument is now EMACS_INT.
11237
11238 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11239 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11240 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11241 (decode_coding_utf_16, decode_coding_emacs_mule)
11242 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11243 (decode_coding_ccl, decode_coding_charset)
11244 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11245 (decode_coding_iso_2022, decode_coding_emacs_mule)
11246 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11247 <char_offset, last_offset>: Declare EMACS_INT.
11248 (encode_coding_utf_8, encode_coding_utf_16)
11249 (encode_coding_emacs_mule, encode_invocation_designation)
11250 (encode_designation_at_bol, encode_coding_iso_2022)
11251 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11252 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11253 Declare EMACS_INT.
11254 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11255 (encode_invocation_designation): Last argument P_NCHARS is now
11256 EMACS_INT.
11257 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11258 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11259
11260 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11261 All users changed.
11262
11263 * ccl.c (Fccl_execute_on_string): Declare some variables
11264 EMACS_INT.
11265
8546720e 112662011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11267
11268 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11269
4e19a977
CS
112702011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11271
11272 * process.c (Fformat_network_address): Doc fix.
11273
87302331
R
112742011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11275
ee7683eb 11276 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11277
cbb59342
CY
112782011-04-08 Chong Yidong <cyd@stupidchicken.com>
11279
11280 * keyboard.c (read_char): Call Lisp function help-form-show,
11281 instead of using internal_with_output_to_temp_buffer.
11282 (Qhelp_form_show): New var.
e0d38eeb 11283 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11284
11285 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11286
11287 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11288
e67a13ab
CY
112892011-04-06 Chong Yidong <cyd@stupidchicken.com>
11290
04f2d78b
CB
11291 * process.c (Flist_processes): Remove to Lisp.
11292 (list_processes_1): Delete.
e67a13ab 11293
973f782d
EZ
112942011-04-06 Eli Zaretskii <eliz@gnu.org>
11295
7c106b1e
EZ
11296 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11297
973f782d
EZ
11298 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11299
41cf7d1a 113002011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11301
ca23cc88
PE
11302 Fix more problems found by GCC 4.6.0's static checks.
11303
f390e2d5
PE
11304 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11305
42eea0d0
PE
11306 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11307
b69769da 11308 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11309
f9541e84
PE
11310 * xdisp.c (vmessage): Mark as a printf-like function.
11311
13841b55
PE
11312 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11313
c136c10f
PE
11314 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11315
5e2d4a30
PE
11316 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11317 printf-like functions.
11318 (tiff_load): Add casts to remove these marks before passing them
11319 to system-supplied API.
11320
583f48b9
PE
11321 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11322
b25d760e
PE
11323 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11324 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11325 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11326 directly, rather than having caller test rule sign. This avoids
11327 some unnecessary tests.
11328 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11329 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11330 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11331
bc7b6697 11332 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11333 (xfont_open): Avoid unnecessary tests.
bc7b6697 11334
27ccc379
PE
11335 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11336
dcd5c89a
PE
11337 * composite.h, composite.c (composition_gstring_put_cache):
11338 Use EMACS_INT, not int, for length.
11339
b13a45c6
PE
11340 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11341 breaking out part of COMPOSITION_DECODE_RULE.
11342 (COMPOSITION_DECODE_RULE): Use it.
11343 * composite.c (get_composition_id): Remove unused local vars,
11344 by using the new macro.
11345
1e792e4d
PE
11346 * textprop.c (set_text_properties_1): Change while to do-while,
11347 since the condition is always true at first.
11348
dc6c6455 11349 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11350 (interval_deletion_adjustment): Return unsigned value.
11351 All uses changed.
dc6c6455 11352
aba7731a
PE
11353 * process.c (list_processes_1, create_pty, read_process_output):
11354 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11355 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11356 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11357 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11358 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11359
fdfc4bf3
PE
11360 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11361
fca8fe46 11362 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11363 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11364
06a0259a 11365 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11366 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11367 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11368
e7b9e80f
PE
11369 * print.c (print_error_message): Avoid int overflow.
11370
56201685
PE
11371 * font.c (font_list_entities): Redo for clarity,
11372 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11373
78834453 11374 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11375 (font_score): Avoid potential overflow in diff calculation.
78834453 11376
0bc0b309 11377 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11378 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11379
e610eaca
PE
11380 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11381
b895abce
PE
11382 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11383 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11384 can always succeed if overflow has undefined behavior.
11385
1f1d9321 11386 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11387 (wordify): Omit three unnecessary tests.
1f1d9321 11388
c59478bc
PE
11389 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11390 All callers changed. This avoids the need for an unused var.
11391
79b73827
PE
11392 * casefiddle.c (casify_region): Remove var that is set but not used.
11393
a4db5dfe
PE
11394 * dired.c (file_name_completion): Remove var that is set but not used.
11395
43aae36e
PE
11396 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11397
2a47c44d 11398 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11399 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11400
a37c69bf
PE
11401 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11402 Check for integer overflow on size calculations.
11403
328ab8e7
PE
11404 * buffer.c (Fprevious_overlay_change): Remove var that is set
11405 but not used.
11406
e5a2a5cb
PE
11407 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11408 Remove vars that are set but not used.
8d84a6eb 11409 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11410 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11411
a60e5f68
PE
11412 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11413
f661cb61 11414 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11415 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11416
f0397f5a
PE
11417 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11418 that are set but not used.
11419
8664db06 11420 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11421 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11422
6abdaa4a
PE
11423 * xselect.c (x_get_local_selection, x_handle_property_notify):
11424 Remove vars that are set but not used.
11425
0ce7538d 11426 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11427 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11428
9ae848fc
PE
11429 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11430 Remove var that is set but not used.
0b918413
PE
11431 (scroll_bar_windows_size): Now size_t, not int.
11432 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11433 Check for overflow.
9ae848fc 11434
a5a62657
PE
11435 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11436 (map_tty_color) [!defined MSDOS]: Likewise.
11437
5c5cdd39
PE
11438 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11439
66ebf983
PE
11440 * coding.c: Remove vars that are set but not used.
11441 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11442 All callers changed.
11443 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11444 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11445 (decode_coding_charset): Remove vars that are set but not used.
11446
1be4d761
PE
11447 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11448 that is set but not used.
11449
47553fa8
PE
11450 * print.c (print_object): Remove var that is set but not used.
11451
1f7196bf 11452 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11453 The gnulib version avoids calling malloc in the usual case,
11454 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11455 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11456 * filelock.c (current_lock_owner): Likewise.
11457 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11458 * sysdep.c: Include allocator.h, careadlinkat.h.
11459 (emacs_no_realloc_allocator): New static constant.
11460 (emacs_readlink): New function.
fdb61804
PE
11461 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11462 ../lib/careadlinkat.h.
d1fdcab7 11463
f84c17c7
SM
114642011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11465
11466 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11467 first non-nil return value).
11468
ef3862ad
JD
114692011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11470
11471 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11472 if not defined (Bug#8403).
11473
376a7006
JB
114742011-04-02 Juanma Barranquero <lekktu@gmail.com>
11475
11476 * xdisp.c (display_count_lines): Remove parameter `start',
11477 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11478 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11479 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11480 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11481 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11482 and thereabouts. All callers changed.
11483 (get_per_char_metric): Remove parameter `f', unused since
11484 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11485
6ca3801d
JM
114862011-04-02 Jim Meyering <meyering@redhat.com>
11487
11488 do not dereference NULL upon failed strdup
11489 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11490 (ns_get_family): Likewise.
11491
d8e2b5ba
JB
114922011-04-02 Juanma Barranquero <lekktu@gmail.com>
11493
11494 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11495
8c74fcbd
JD
114962011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11497
11498 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11499 later (Bug#8403).
11500
7200d79c
SM
115012011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11502
03408648 11503 Add lexical binding.
7200d79c 11504
03408648
SM
11505 * window.c (Ftemp_output_buffer_show): New fun.
11506 (Fsave_window_excursion):
11507 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11508
11509 * lread.c (lisp_file_lexically_bound_p): New function.
11510 (Fload): Bind Qlexical_binding.
11511 (readevalloop): Remove `evalfun' arg.
11512 Bind Qinternal_interpreter_environment.
11513 (Feval_buffer): Bind Qlexical_binding.
11514 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11515 Mark as dynamic.
11516 (syms_of_lread): Declare `lexical-binding'.
11517
11518 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11519
11520 * keyboard.c (eval_dyn): New fun.
11521 (menu_item_eval_property): Use it.
ca105506
SM
11522
11523 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11524
03408648
SM
11525 * fns.c (concat, mapcar1): Accept byte-code-functions.
11526
11527 * eval.c (Fsetq): Handle lexical vars.
11528 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11529 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11530 (FletX, Flet): Obey lexical binding.
11531 (Fcommandp): Handle closures.
11532 (Feval): New `lexical' arg.
11533 (eval_sub): New function extracted from Feval. Use it almost
11534 everywhere where Feval was used. Look up vars in lexical env.
11535 Handle closures.
11536 (Ffunctionp): Move from subr.el.
11537 (Ffuncall): Handle closures.
11538 (apply_lambda): Remove `eval_flags'.
11539 (funcall_lambda): Handle closures and new byte-code-functions.
11540 (Fspecial_variable_p): New function.
11541 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11542 but without exporting it to Lisp.
23aba0ea 11543
23aba0ea 11544 * doc.c (Fdocumentation, store_function_docstring):
03408648 11545 * data.c (Finteractive_form): Handle closures.
23aba0ea 11546
03408648
SM
11547 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11548 interactive spec.
ba83908c 11549
04f2d78b
CB
11550 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11551 New byte-codes.
03408648
SM
11552 (exec_byte_code): New function extracted from Fbyte_code to handle new
11553 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11554
03408648 11555 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11556
03408648 11557 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11558
e2abce01
JB
115592011-03-31 Juanma Barranquero <lekktu@gmail.com>
11560
11561 * xdisp.c (redisplay_internal): Fix prototype.
11562
63696a73 115632011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11564
63696a73 11565 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11566 (try_scrolling): Use it when setting scroll_limit.
11567 Limit scrolling to 100 screen lines.
63696a73
EZ
11568 (redisplay_window): Even when falling back on "recentering",
11569 position point in the window according to scroll-conservatively,
11570 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11571
11572 (try_scrolling): When point is above the window, allow searching
11573 as far as scroll_max, or one screenful, to compute vertical
11574 distance from PT to the scroll margin position. This prevents
11575 try_scrolling from unnecessarily failing when
11576 scroll-conservatively is set to a value slightly larger than the
11577 window height. Clean up the case of PT below the margin at bottom
11578 of window: scroll_max can no longer be INT_MAX. When aggressive
11579 scrolling is in use, don't let point enter the opposite scroll
11580 margin as result of the scroll.
11581 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11582 threshold of 100 lines for never-recentering scrolling.
11583
e4cc2dfc
JB
115842011-03-31 Juanma Barranquero <lekktu@gmail.com>
11585
11586 * dispextern.h (move_it_by_lines):
11587 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11588 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11589 (message_log_check_duplicate): Remove parameters `prev_bol' and
11590 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11591 (redisplay_internal): Remove parameter `preserve_echo_area',
11592 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11593
11594 * indent.c (Fvertical_motion):
11595 * window.c (window_scroll_pixel_based, Frecenter):
11596 Don't pass `need_y_p' to `move_it_by_lines'.
11597
1c470562
SM
115982011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11599
44f230aa
SM
11600 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11601 steal a few bits to be more compact.
11602 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11603 Remove unneeded casts.
11604
1c470562
SM
11605 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11606
888adce9
ZK
116072011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11608
11609 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11610 binding" message (bug#7967).
11611
f838ed7b
PE
116122011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11613
77861b95
PE
11614 Fix more problems found by GCC 4.6.0's static checks.
11615
de6dbc14
PE
11616 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11617 Remove unused local var.
11618
f838ed7b
PE
11619 * editfns.c (Fmessage_box): Remove unused local var.
11620
792c7b2b
PE
11621 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11622 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11623 Omit unused local vars.
c499e557 11624 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11625 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11626 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11627 Omit unused local var.
11628
ba0165e1
PE
11629 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11630 Don't assume string length fits in int.
32ad8845 11631 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11632 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11633
3c59b4c9
PE
11634 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11635 instead of alloca (Bug#8344).
11636
a3eed478 11637 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11638 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11639
eb4d412d
PE
11640 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11641
1658b401
PE
11642 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11643 concerns.
11644
11645 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11646
11647 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11648
9a2c6e05
PE
11649 * keyboard.c (syms_of_keyboard): Use the same style as later
11650 in this function when indexing through an array. This also
11651 works around GCC bug 48267.
11652
03d0a109
PE
11653 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11654
44f730c8
PE
11655 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11656
fe75f926
PE
11657 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11658 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11659
ffa8c828
PE
11660 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11661 This avoids undefined behavior on integer overflow, and is a bit
11662 more convenient anyway since it is compared to a size_t variable.
11663
c5101a77
PE
11664 Variadic C functions now count arguments with size_t, not int.
11665 This avoids an unnecessary limitation on 64-bit machines, which
11666 caused (substring ...) to crash on large vectors (Bug#8344).
11667 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11668 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11669 All variadic functions and their callers changed accordingly.
c5101a77
PE
11670 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11671 * data.c (arith_driver, float_arith_driver): Likewise.
11672 * editfns.c (general_insert_function): Likewise.
11673 * eval.c (struct backtrace.nargs, interactive_p)
11674 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11675 (funcall_lambda, mark_backtrace): Likewise.
11676 * fns.c (concat): Likewise.
11677 * frame.c (x_set_frame_parameters): Likewise.
11678 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11679 0 if not found, not -1. All callers changed.
11680
dd3f25f7
PE
11681 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11682 (stack_copy_size): Now size_t, not int.
11683 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11684
461c2ab9
JB
116852011-03-28 Juanma Barranquero <lekktu@gmail.com>
11686
11687 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11688 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11689 All callers changed.
11690
11691 * lisp.h (multibyte_char_to_unibyte):
11692 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11693 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11694 * character.h (CHAR_TO_BYTE8):
11695 * cmds.c (internal_self_insert):
11696 * editfns.c (general_insert_function):
11697 * keymap.c (push_key_description):
11698 * search.c (Freplace_match):
11699 * xdisp.c (message_dolog, set_message_1): All callers changed.
11700
f6d62986
SM
117012011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11702
11703 * keyboard.c (safe_run_hook_funcall): New function.
11704 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11705 don't set the hook to nil, but remove the offending function instead.
11706 (Qcommand_hook_internal): Remove, unused.
11707 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11708 Vcommand_hook_internal.
11709
11710 * eval.c (enum run_hooks_condition): Remove.
11711 (funcall_nil, funcall_not): New functions.
11712 (run_hook_with_args): Call each function through a `funcall' argument.
11713 Remove `cond' argument, now redundant.
11714 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11715 (Frun_hook_with_args_until_failure): Adjust accordingly.
11716 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11717
1db5b1ad
JB
117182011-03-28 Juanma Barranquero <lekktu@gmail.com>
11719
11720 * dispextern.h (string_buffer_position): Remove declaration.
11721
11722 * print.c (strout): Remove parameter `multibyte', unused since
11723 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11724
11725 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11726 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11727 All callers changed.
11728
11729 * w32.c (_wsa_errlist): Use braces for struct initializers.
11730
11731 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11732 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11733 All callers changed.
11734 (string_buffer_position): Likewise. Also, make static (it's never
11735 used outside xdisp.c).
11736 (cursor_row_p): Remove parameter `w', unused since
11737 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11738 (decode_mode_spec): Remove parameter `precision', introduced during
11739 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11740 All callers changed.
11741
5ffb62aa
JD
117422011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11743
11744 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11745
461c2ab9 117462011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11747
11748 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11749 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11750 (ns_update_auto_hide_menu_bar): New functions.
11751 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11752 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11753 ns_constrain_all_frames.
11754 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11755 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11756
5c380ffb
JD
117572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11758
11759 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11760
9af30bdf
GM
117612011-03-27 Glenn Morris <rgm@gnu.org>
11762
11763 * syssignal.h: Replace RETSIGTYPE with void.
11764 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11765 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11766 Replace SIGTYPE with void everywhere.
11767 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11768 * s/template.h (SIGTYPE): Remove commented out definition.
11769
e2abce01
JB
117702011-03-26 Eli Zaretskii <eliz@gnu.org>
11771
11772 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11773 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11774
f868cd8a
JB
117752011-03-26 Juanma Barranquero <lekktu@gmail.com>
11776
59eb0929
JB
11777 * w32.c (read_unc_volume): Use parameter `henum', instead of
11778 global variable `wget_enum_handle'.
11779
11780 * keymap.c (describe_vector): Remove parameters `indices' and
11781 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11782 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11783
f868cd8a
JB
11784 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11785
11786 * keyboard.c (timer_check): Remove parameter `do_it_now',
11787 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11788 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11789 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11790
11791 * keyboard.c (read_char):
11792 * w32menu.c (w32_menu_display_help):
11793 * xmenu.c (show_help_event, menu_help_callback):
11794 Adjust calls to `show_help_echo'.
11795
11796 * gtkutil.c (xg_maybe_add_timer):
11797 * keyboard.c (readable_events):
11798 * process.c (wait_reading_process_output):
11799 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11800
11801 * insdel.c (adjust_markers_gap_motion):
11802 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11803 (gap_left, gap_right): Don't call it.
11804
2ecf6fdb
CY
118052011-03-25 Chong Yidong <cyd@stupidchicken.com>
11806
11807 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11808 incurred during fontification.
11809
6b1f9ba4
JB
118102011-03-25 Juanma Barranquero <lekktu@gmail.com>
11811
11812 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11813 (DEFVAR_PER_BUFFER): Don't pass it.
11814
11815 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11816 (scrolling_window): Don't pass it.
11817
0f4a96b5
JB
118182011-03-25 Juanma Barranquero <lekktu@gmail.com>
11819
11820 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11821
11822 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11823 and `suffix'.
11824 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11825 of variables specific to SELinux and computation of `encoded_absname'.
11826
11827 * image.c (XPutPixel): Remove unused variable `height'.
11828
11829 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11830
11831 * unexw32.c (get_section_info): Remove unused variable `section'.
11832
11833 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11834 (system_process_attributes): Remove unused variable `sess'.
11835 (sys_read): Remove unused variable `err'.
11836
11837 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11838 (w32_wnd_proc): Remove unused variable `isdead'.
11839 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11840 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11841 (x_create_tip_frame): Remove unused variable `tem'.
11842
11843 * w32inevt.c (w32_console_read_socket):
11844 Remove unused variable `no_events'.
11845
11846 * w32term.c (x_draw_composite_glyph_string_foreground):
11847 Remove unused variable `width'.
11848
1149507c
JB
118492011-03-24 Juanma Barranquero <lekktu@gmail.com>
11850
11851 * w32term.c (x_set_glyph_string_clipping):
11852 Don't pass uninitialized region to CombineRgn.
11853
9c88f339
JB
118542011-03-23 Juanma Barranquero <lekktu@gmail.com>
11855
11856 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11857 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11858 (Fx_close_connection): Remove unused variable `i'.
11859
11860 * w32font.c (w32font_draw): Return number of glyphs.
11861 (w32font_open_internal): Remove unused variable `i'.
11862 (w32font_driver): Add missing initializer.
11863
11864 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11865 (fill_in_menu): Remove unused variable `items_added'.
11866
11867 * w32term.c (last_mouse_press_frame): Remove static global variable.
11868 (w32_clip_to_row): Remove unused variable `f'.
11869 (x_delete_terminal): Remove unused variable `i'.
11870
11871 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11872 (NOTHING): Remove unused static global variable.
11873 (uniscribe_check_otf): Remove unused variable `table'.
11874 (uniscribe_font_driver): Add missing initializers.
11875
dee091a3
JD
118762011-03-23 Julien Danjou <julien@danjou.info>
11877
11878 * term.c (Fsuspend_tty, Fresume_tty):
11879 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11880 * window.c (temp_output_buffer_show):
11881 * insdel.c (signal_before_change):
11882 * frame.c (Fhandle_switch_frame):
11883 * fileio.c (Fdo_auto_save):
11884 * emacs.c (Fkill_emacs):
11885 * editfns.c (save_excursion_restore):
11886 * cmds.c (internal_self_insert):
11887 * callint.c (Fcall_interactively):
11888 * buffer.c (Fkill_all_local_variables):
11889 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11890 Use Frun_hooks.
0f4a96b5 11891 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11892 unconditionally since it does the check itself.
dee091a3 11893
2c520ab5 118942011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11895
c9c49752
PE
11896 Fix more problems found by GCC 4.5.2's static checks.
11897
8abc3f12
PE
11898 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11899 the first time through the loop, since we know p0 < p1 then.
11900 This also avoids a gcc -Wstrict-overflow warning.
11901
a2d26660
PE
11902 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11903 leading to a memory leak, possible in functions like
11904 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11905 of objects (Bug#8318).
a2d26660 11906
916c72e9
PE
11907 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11908 that could (at least in theory) be that large.
11909
19ab8a18
PE
11910 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11911 This is less likely to overflow, and avoids undefined behavior if
11912 overflow does occur. All callers changed. Use strtoul to scan
11913 for the unsigned long integer.
b7cbbd6f
PE
11914 (pint2hrstr): Simplify and tune code slightly.
11915 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11916
f0641eff
PE
11917 * scroll.c (do_scrolling): Work around GCC bug 48228.
11918 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11919
7f650bb9
PE
11920 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11921 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11922 (validate_x_resource_name): Simplify count usage.
11923 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11924
37dd57d1
PE
11925 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11926 fail (Bug#8306).
81e56e61 11927
699979fc 11928 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11929
401bf9b4
PE
11930 * process.c (Fmake_network_process): Use socklen_t, not int,
11931 where POSIX says socklen_t is required in portable programs.
11932 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11933 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11934 (Fmake_network_process, server_accept_connection):
11935 (wait_reading_process_output, read_process_output):
11936 Likewise.
11937
b93aacde
PE
11938 * process.c: Rename or move locals to avoid shadowing.
11939 (list_processes_1, Fmake_network_process):
11940 (read_process_output_error_handler, exec_sentinel_error_handler):
11941 Rename or move locals.
4dc343ee 11942 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11943 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11944 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11945 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11946 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11947
af8a867c 11948 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11949 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11950 Include tparam.h instead, since it declares them.
af8a867c
PE
11951 * cm.h (PC): Remove extern decl; tparam.h now does this.
11952 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11953 * terminfo.c: Include tparam.h, to check interfaces.
11954 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11955 (tparam): Adjust signature to match interface in tparam.h;
11956 this removes some undefined behavior. Check that outstring and len
11957 are zero, which they always are with Emacs.
11958 * tparam.h (PC, BC, UP): New extern decls.
11959
0248044d 11960 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11961 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11962
8ff096c1 11963 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11964 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11965 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11966 (ftfont_list): Remove unused local.
49eaafba
PE
11967 (get_adstyle_property, ftfont_pattern_entity):
11968 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11969 Rename locals to avoid shadowing.
8ff096c1 11970
e2be39f6
PE
11971 * xfont.c (xfont_list_family): Mark var as initialized.
11972
c9735e30
PE
11973 * xml.c (make_dom): Now static.
11974
8f5201ae
PE
11975 * composite.c (composition_compute_stop_pos): Rename local to
11976 avoid shadowing.
b246f932
PE
11977 (composition_reseat_it): Remove unused locals.
11978 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11979 (composition_update_it): Mark var as initialized.
11b61122
PE
11980 (find_automatic_composition): Mark vars as initialized,
11981 with a FIXME (Bug#8290).
8f5201ae 11982
760fbc2c
PE
11983 character.h: Rename locals to avoid shadowing.
11984 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11985 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11986 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11987 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11988 to avoid shadowing.
11989
ff08eb85
PE
11990 * textprop.c (property_change_between_p): Remove; unused.
11991
fc7bf025
PE
11992 * intervals.c (interval_start_pos): Now static.
11993
235d7abc
PE
11994 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11995
44f230aa
SM
11996 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11997 Rename locals to avoid shadowing.
3e7d6594 11998
50060332
PE
11999 * sound.c (wav_play, au_play, Fplay_sound_internal):
12000 Fix pointer signedness.
d01f234b 12001 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12002 (wav_play): Initialize a variable to 0, to prevent undefined
12003 behavior (Bug#8278).
50060332 12004
c4fc4e30
PE
12005 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12006
918436ed
PE
12007 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12008
c939f91b
PE
12009 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12010 clobbering (Bug#8298).
b9c7f648
PE
12011 * sysdep.c (sys_subshell): Likewise.
12012 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12013
6bd8c144
PE
12014 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12015 This should get cleaned up, so that child_setup has the
12016 same signature on all platforms.
12017
7710357c 12018 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12019 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12020
c59da222
CY
120212011-03-22 Chong Yidong <cyd@stupidchicken.com>
12022
12023 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12024 not to be necessary, and produces flickering.
12025
66b87493
GM
120262011-03-20 Glenn Morris <rgm@gnu.org>
12027
12028 * config.in: Remove file.
12029
45b6f6d5
JB
120302011-03-20 Juanma Barranquero <lekktu@gmail.com>
12031
12032 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12033 are now in src/globals.h.
12034 (syms_of_minibuf): Remove spurious & from previous change.
12035
cd394be1 120362011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12037
12038 * minibuf.c (completing-read-function): New variable.
12039 (completing-read-default): Rename from completing-read.
12040 (completing-read): Call completing-read-function.
12041
b14e3e21
CY
120422011-03-19 Juanma Barranquero <lekktu@gmail.com>
12043
12044 * xfaces.c (Fx_load_color_file):
12045 Read color file from absolute filename (bug#8250).
12046
f2b726e6
JB
120472011-03-19 Juanma Barranquero <lekktu@gmail.com>
12048
12049 * makefile.w32-in: Update dependencies.
12050
09f6ff02
EZ
120512011-03-17 Eli Zaretskii <eliz@gnu.org>
12052
12053 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12054
29a6015a
PE
120552011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12056
a3a6c54e
PE
12057 Fix more problems found by GCC 4.5.2's static checks.
12058
b766f867
PE
12059 * process.c (make_serial_process_unwind, send_process_trap):
12060 (sigchld_handler): Now static.
12061
be02381c
PE
12062 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12063 That way, the code declares only the vars that it needs.
12064 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12065 * s/cygwin.h (PTY_ITERATION): Likewise.
12066 * s/darwin.h (PTY_ITERATION): Likewise.
12067 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12068
57048744
PE
12069 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12070 * process.c (allocate_pty): Don't declare stb unless it's needed.
12071
7914961c 12072 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12073 (CONSTANTLIM): Remove; unused.
12074 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12075 Define only if needed.
7914961c 12076
b3967b18
PE
12077 * unexelf.c (unexec): Name an expression,
12078 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12079 Use a different way to cause a compilation error if anyone uses
12080 n rather than nn, a way that does not involve shadowing.
73366a00 12081 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12082
29a6015a
PE
12083 * deps.mk (unexalpha.o): Remove; unused.
12084
43cfc33e 12085 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12086 * unexec.h: New file.
ce701a33
PE
12087 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12088 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12089 Depend on unexec.h.
12090 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12091 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12092 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12093 Change as necessary to match prototype in unexec.h.
ce701a33 12094
01f44d5a
PE
12095 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12096 shadowing.
4f63c6bb 12097 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12098
a6670b0b
PE
12099 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12100 Rename locals to avoid shadowing.
12101
cef2010d 12102 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12103 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12104
d4d7173a
PE
12105 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12106
f08b802a
PE
12107 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12108 warning when compiling print.c.
12109
3ddb0639
PE
12110 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12111 instead of using an uninitialized var.
5ad03b97 12112 (font_sort_entities): Mark var as initialized.
3ddb0639 12113
170a2692
PE
12114 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12115
e663c700
PE
12116 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12117 pointers to constants.
89bc529a 12118 (font_parse_fcname): Remove unused vars.
7b81e2d0 12119 (font_delete_unmatched): Now static.
ea838e10 12120 (font_get_spec): Remove; unused.
13a547c6
PE
12121 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12122 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12123 Rename or move locals to avoid shadowing.
e663c700 12124
2a80c887 12125 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12126 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12127
1384fa33 12128 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12129 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12130
8b2c52e9
PE
12131 * alloc.c (mark_backtrace): Move decl from here ...
12132 * lisp.h: ... to here, so that it can be checked.
12133
475545b5 12134 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12135 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12136 (lisp_indirect_variable): Name an expression,
12137 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12138 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12139
b1349114 12140 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12141 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12142 Use const pointer when appropriate.
b1349114 12143
a2928364
PE
12144 * lisp.h (get_system_name, get_operating_system_release):
12145 Move decls here, to check interfaces.
12146 * process.c (get_operating_system_release): Move decl to lisp.h.
12147 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12148 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12149 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12150 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12151 (Fformat_time_string, Fencode_time, Finsert_char):
12152 (Ftranslate_region_internal, Fformat):
12153 Rename or remove local vars to avoid shadowing.
9710023e 12154 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12155
a415e694
PE
12156 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12157 avoid shadowing.
12158
8ef4622d
PE
12159 * lisp.h (eassert): Check that the argument compiles, even if
12160 ENABLE_CHECKING is not defined.
12161
946f9a5b
PE
12162 * data.c (Findirect_variable): Name an expression, to avoid
12163 gcc -Wbad-function-cast warning.
112396d6 12164 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12165 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12166 (Fmake_variable_buffer_local, Fmake_local_variable):
12167 Mark variables as initialized.
52746918 12168 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12169
e5aab7e7 12170 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12171 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12172 Rename locals to avoid shadowing.
dff45157
PE
12173 (mark_stack): Move local variables into the #ifdef region where
12174 they're used.
7bc26fdb
PE
12175 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12176 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12177 needed otherwise.
12178 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12179 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12180 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12181
e5aab7e7
PE
12182 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12183 avoids undefined behavior in theory.
12184
4da60324
PE
12185 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12186
88043301
PE
12187 Use functions, not macros, for up- and down-casing (Bug#8254).
12188 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12189 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12190 to use the following functions instead of these macros.
12191 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12192 EMACS_INT, since callers assume the returned value fits in int.
12193 (upcase1): Likewise, for UPCASE_TABLE.
12194 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12195 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12196 the race-condition problem in the old DOWNCASE.
88043301 12197
19ed5445
PE
12198 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12199 Rename locals to avoid shadowing.
12200 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12201 (regex_compile, re_search_2, re_match_2_internal):
12202 Remove unused local vars.
952db0d7
PE
12203 (FREE_VAR): Rewrite so as not to use empty "else",
12204 which gcc can warn about.
da053e48 12205 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12206 (RETALLOC_IF): Define only if needed.
12207 (WORDCHAR_P): Likewise. This one is never needed, but is used
12208 only in a comment talking about a compiler bug, so put inside
12209 the #if 0 of that comment.
12210 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12211 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12212 Remove; unused.
19ed5445 12213
1f3561e4 12214 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12215 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12216 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12217
ded6f8f7
PE
12218 * search.c (simple_search): Remove unused var.
12219
dbd37a95
PE
12220 * dired.c (compile_pattern): Move decl from here ...
12221 * lisp.h: ... to here, so that it can be checked.
12222 (struct re_registers): New forward decl.
12223
7e47afad
PE
12224 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12225
85f24f61
PE
12226 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12227 All uses changed.
12228 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12229 Rename locals to avoid shadowing.
5671df8f 12230 (Fvertical_motion): Mark locals as initialized.
85f24f61 12231
181aa2be 12232 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12233 (casify_region): Mark local as initialized.
181aa2be 12234
930d429c
PE
12235 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12236
7082eac6
PE
12237 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12238 New macros, so that the caller can use some names other than
12239 gcpro1, gcpro2, etc.
12240 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12241 of the new macros.
12242 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12243 argument, for consistency with GCPRO2_VAR, etc: it is now the
12244 prefix of the variable, not the variable itself. All uses
12245 changed.
38b2c076
PE
12246 * dired.c (directory_files_internal, file_name_completion):
12247 Rename locals to avoid shadowing.
12248
15206ed9
PE
12249 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12250 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12251 dired.c's scmp function, had undefined behavior.
12252 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12253 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12254 * buffer.h: ... to here, because these macros use current_buffer,
12255 and the new implementation with inline functions needs to have
12256 current_buffer in scope now, rather than later when the macros
12257 are used.
12258 (downcase, upcase1): New static inline functions.
12259 (DOWNCASE, UPCASE1): Reimplement using these functions.
12260 This avoids undefined behavior in expressions like
12261 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12262 from race conditions in accessing the global variables
12263 case_temp1 and case_temp2.
12264 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12265 * lisp.h (case_temp1, case_temp2): Remove their decls.
12266 * character.h (ASCII_CHAR_P): Move from here ...
12267 * lisp.h: ... to here, so that the inline functions mentioned
12268 above can use them.
12269
4a6bea26
PE
12270 * dired.c (directory_files_internal_unwind): Now static.
12271
f14b7e14
PE
12272 * fileio.c (file_name_as_directory, directory_file_name):
12273 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12274 Now static.
2893f146
PE
12275 (file_name_as_directory): Use const pointers when appropriate.
12276 (Fexpand_file_name): Likewise. In particular, newdir might
12277 point at constant storage, so make it a const pointer.
fd4ead52 12278 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12279 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12280 signedness issues.
f839df0c
PE
12281 (Fset_file_times, Finsert_file_contents, auto_save_error):
12282 Rename locals to avoid shadowing.
f14b7e14 12283
5716756e 12284 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12285 (Ftry_completion, Fall_completions): Rename or remove locals
12286 to avoid shadowing.
5716756e 12287
b4c3046a
PE
12288 * marker.c (bytepos_to_charpos): Remove; unused.
12289
b45db522
PE
12290 * lisp.h (verify_bytepos, count_markers): New decls,
12291 so that gcc does not warn that these functions aren't declared.
12292
85876d07
PE
12293 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12294 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12295 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12296 (copy_text): Remove unused local var.
85876d07 12297
03d78a21 12298 * filelock.c (within_one_second): Now static.
b3dd38ab 12299 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12300
5df8f01b
PE
12301 * buffer.c (fix_overlays_before): Mark locals as initialized.
12302 (fix_start_end_in_overlays): Likewise. This function should be
12303 simplified by using pointers-to-pointers, but that's a different
12304 matter.
b1d876f1 12305 (switch_to_buffer_1): Now static.
8f54f30a
PE
12306 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12307 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12308
a70072c9 12309 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12310 Fix pointer signedness issue.
edced198
PE
12311 (sys_subshell): Mark local as volatile if checking for lint,
12312 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12313 (MAXPATHLEN): Define only if needed.
a70072c9 12314
a0977c44
PE
12315 * process.c (serial_open, serial_configure): Move decls from here ...
12316 * systty.h: ... to here, so that they can be checked.
12317
a884fdcc
PE
12318 * fns.c (get_random, seed_random): Move extern decls from here ...
12319 * lisp.h: ... to here, so that they can be checked.
12320
604efe86 12321 * sysdep.c (reset_io): Now static.
b8950c94 12322 (wait_for_termination_signal): Remove; unused.
604efe86 12323
38fc62d9
PE
12324 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12325 (copy_keymap_item, append_key, push_text_char_description):
12326 Now static.
1004a21a 12327 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12328 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12329 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12330 (describe_map_tree):
12331 Rename locals to avoid shadowing.
38fc62d9 12332
2f2650da
PE
12333 * keyboard.c: Declare functions static if they are not used elsewhere.
12334 (echo_char, echo_dash, cmd_error, top_level_2):
12335 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12336 (read_char, kbd_buffer_get_event, make_lispy_position):
12337 (make_lispy_event, make_lispy_movement, apply_modifiers):
12338 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12339 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12340 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12341 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12342 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12343
a053e86c 12344 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12345 (mark_kboards): Move decl here ...
12346 * alloc.c (mark_kboards): ... from here.
a053e86c 12347
4752793e
PE
12348 * lisp.h (force_auto_save_soon): New decl.
12349
74f10ca7 12350 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12351 (DEFINE_DUMMY_FUNCTION): New macro.
12352 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12353 Use it.
c03cd23f
PE
12354 (main): Add casts to avoid warnings
12355 if GCC considers string literals to be constants.
74f10ca7 12356
022e70d4
PE
12357 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12358
59d6fe83
PE
12359 * dbusbind.c: Pointer signedness fixes.
12360 (xd_signature, xd_append_arg, xd_initialize):
12361 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12362 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12363 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12364 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12365
78320123
PE
12366 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12367 if GCC considers string literals to be constants.
49cebcca 12368 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12369
35ac2a97
SM
123702011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12371
fb103ca9
SM
12372 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12373 (print_preprocess, print_object): New macro to fix last change.
12374
35ac2a97
SM
12375 * print.c (print_preprocess): Don't forget font objects.
12376
62973b41
JB
123772011-03-16 Juanma Barranquero <lekktu@gmail.com>
12378
12379 * emacs.c (USAGE3): Doc fixes.
12380
0e48bb22
AS
123812011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12382
12383 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12384 structure.
12385
7684e57b
JB
123862011-03-14 Juanma Barranquero <lekktu@gmail.com>
12387
12388 * lisp.h (VWindow_system, Qfile_name_history):
12389 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12390 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12391 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12392
12393 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12394 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12395
12396 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12397 * w32console.c (detect_input_pending, read_input_pending)
12398 (encode_terminal_code):
12399 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12400 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12401 (w32_system_caret_y, Qfile_name_history):
12402 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12403 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12404 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12405 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12406 * w32proc.c (Qlocal, report_file_error):
12407 * w32term.c (Vwindow_system, updating_frame):
12408 * w32uniscribe.c (initialized, uniscribe_font_driver):
12409 Remove unneeded extern declarations.
12410
2aa46d6c
CY
124112011-03-14 Chong Yidong <cyd@stupidchicken.com>
12412
c96bbc66 12413 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12414
cffc6f3b
CY
124152011-03-13 Chong Yidong <cyd@stupidchicken.com>
12416
12417 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12418 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12419 These macros can no longer be used for assignment.
12420
44f230aa
SM
12421 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12422 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12423 (record_buffer_markers, fetch_buffer_markers): New functions for
12424 recording and fetching special buffer markers.
12425 (set_buffer_internal_1, set_buffer_temp): Use them.
12426
12427 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12428
12429 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12430
12431 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12432 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12433
12434 * xdisp.c (hscroll_window_tree):
12435 (reconsider_clip_changes): Use PT instead of BUF_PT.
12436
d251f04b
EZ
124372011-03-13 Eli Zaretskii <eliz@gnu.org>
12438
12439 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12440 $(EMACS_ROOT)/lib/intprops.h.
12441
f0c77cd1
PE
124422011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12443
3eca4629
PE
12444 Fix more problems found by GCC 4.5.2's static checks.
12445
7c86ee98
PE
12446 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12447 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12448 (xg_free_frame_widgets): Make it clear that a local variable is
12449 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12450 (gdk_window_get_screen): Make it clear that this macro is needed
12451 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12452 (int_gtk_range_get_value): New function, which avoids a diagnostic
12453 from gcc -Wbad-function-cast.
12454 (xg_set_toolkit_scroll_bar_thumb): Use it.
12455 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12456 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12457 (get_utf8_string, xg_get_file_with_chooser):
12458 Rename locals to avoid shadowing.
12459 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12460
41729b81
PE
12461 * xgselect.c (xg_select): Remove unused var.
12462
f0c77cd1
PE
12463 * image.c (four_corners_best): Mark locals as initialized.
12464 (gif_load): Initialize transparent_p to zero (Bug#8238).
12465 Mark another local as initialized.
ec6cf4c6 12466 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12467
ce0ad53d 12468 * image.c (clear_image_cache): Now static.
d5d5a617 12469 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12470 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12471 (x_edge_detection): Remove unnecessary cast that
12472 gcc -Wbad-function-cast diagnoses.
2037898d 12473 (gif_load): Fix pointer signedness.
6ae141d6
PE
12474 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12475 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12476
33383987 124772011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12478
d32df629
PE
12479 Improve quality of tests for time stamp overflow.
12480 For example, without this patch (encode-time 0 0 0 1 1
12481 1152921504606846976) returns the obviously-bogus value (-948597
12482 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12483 reports time overflow. See
12484 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12485 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12486 * editfns.c: Include limits.h and intprops.h.
12487 (TIME_T_MIN, TIME_T_MAX): New macros.
12488 (time_overflow): Move earlier, to before first use.
12489 (hi_time, lo_time): New functions, for an accurate test for
12490 out-of-range times.
12491 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12492 (Fget_internal_run_time): Don't assume time_t fits in int.
12493 (make_time): Use list2 instead of Fcons twice.
12494 (Fdecode_time): More accurate test for out-of-range times.
12495 (check_tm_member): New function.
12496 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12497 (lisp_time_argument): Don't rely on undefined left-shift and
12498 right-shift behavior when checking for time stamp overflow.
8be6f318 12499
fe31d94c
PE
12500 * editfns.c (time_overflow): New function, refactoring common code.
12501 (Fformat_time_string, Fdecode_time, Fencode_time):
12502 (Fcurrent_time_string): Use it.
12503
8be6f318
PE
12504 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12505 * dired.c (make_time): Move to ...
12506 * editfns.c (make_time): ... here.
12507 * systime.h: Note the move.
12508
09d9db2c 125092011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12510
126bc0dc
YM
12511 * fringe.c (update_window_fringes): Remove unused variables.
12512
c47cbdfd
YM
12513 * unexmacosx.c (copy_data_segment): Also copy __got section.
12514 (Bug#8223)
12515
7ac80be9
EZ
125162011-03-12 Eli Zaretskii <eliz@gnu.org>
12517
c96bbc66 12518 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12519 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12520 Constify `char *' arguments and their references according to
12521 prototypes in tparam.h.
12522
ecb0f94d 12523 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12524
7ac80be9
EZ
12525 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12526 Adapt all references accordingly.
12527
12528 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12529
ef1fd07e
TT
125302011-03-11 Tom Tromey <tromey@redhat.com>
12531
12532 * buffer.c (syms_of_buffer): Remove obsolete comment.
12533
7ef4b50c
EZ
125342011-03-11 Eli Zaretskii <eliz@gnu.org>
12535
12536 * termhooks.h (encode_terminal_code): Declare prototype.
12537
12538 * msdos.c (encode_terminal_code): Don't declare prototype.
12539
12540 * term.c (encode_terminal_code): Now external again, used by
12541 w32console.c and msdos.c.
12542
44f230aa
SM
12543 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12544 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12545
4b1ec863 125462011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12547
1714f52b 12548 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12549
4b1ec863
PE
12550 * fringe.c (update_window_fringes): Mark locals as initialized
12551 (Bug#8227).
12552 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12553
524c7aa6
PE
12554 * alloc.c (mark_fringe_data): Move decl from here ...
12555 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12556 to check its interface.
12557 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12558
a5c0af81 12559 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12560 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12561 (fontset_font): Mark local as initialized.
a9a06e0b 12562 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12563
b4716021
PE
12564 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12565
811e9bac 12566 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12567 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12568 (x_own_selection, Fx_disown_selection_internal): Rename locals
12569 to avoid shadowing.
12570 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12571
7e3ab302
PE
12572 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12573 so that the caller can use some name other than gcpro1.
12574 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12575 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12576 (Fx_backspace_delete_keys_p):
12577 Use them to avoid shadowing, and rename vars to avoid shadowing.
12578 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12579 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12580 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12581 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12582 Remove unused locals.
7e3ab302
PE
12583 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12584 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12585 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12586 macros.
f78faa98 12587
e2b13473
PE
12588 * xterm.h (x_mouse_leave): New decl.
12589
77f23912
PE
12590 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12591 Remove unused functions.
cdf4ba58
PE
12592 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12593 (x_calc_absolute_position): Now static.
7411c686 12594 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12595 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12596 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12597 unless they are used.
38d0b34a
PE
12598 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12599 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12600 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12601 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12602 (x_error_catcher, x_connection_closed, x_error_handler):
12603 (x_error_quitter, xembed_send_message, x_iconify_frame):
12604 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12605 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12606 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12607
44f230aa
SM
12608 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12609 Rename or move locals to avoid shadowing.
6b463e58 12610 (tty_defined_color, merge_face_heights): Now static.
5967d051 12611 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12612 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12613 does not deduce is never used uninitialized.
73719eba
PE
12614 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12615 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12616
426994c3 12617 * terminal.c (store_terminal_param): Now static.
5489860b 12618
032f1620 12619 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12620 (set_frame_menubar): Remove unused local.
d4323972 12621 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12622 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12623 since they might point to immutable storage.
281585b0
PE
12624 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12625 since it's unused otherwise.
032f1620 12626
367c19e5 12627 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12628 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12629 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12630 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12631 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12632 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12633 does not deduce are never used uninitialized.
70739cbe 12634
07b48fa9
PE
12635 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12636
8868a238 12637 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12638 * window.c (window_loop, size_window):
12639 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12640
7e5cf297 12641 * window.c (display_buffer): Now static.
d6550a9f
PE
12642 (size_window): Mark variables that gcc -Wuninitialized
12643 does not deduce are never used uninitialized.
a586633d
PE
12644 * window.h (check_all_windows): New decl, to forestall
12645 gcc -Wmissing-prototypes diagnostic.
5b555da1 12646 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12647
f6095868
PE
12648 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12649 shadowing.
12650 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12651 Include <limits.h>.
12652 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12653 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12654 (load_charset_map): Mark variables that gcc -Wuninitialized
12655 does not deduce are never used uninitialized.
53df7c11 12656 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12657
f38b440c
PE
12658 * coding.c (coding_set_source, coding_set_destination):
12659 Use "else { /* comment */ }" rather than "else /* comment */;"
12660 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12661 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12662 a block, when the outer 'i' will do.
12663 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12664 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12665 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12666 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12667 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12668 Rename locals to avoid shadowing.
12669 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12670 * coding.c (emacs_mule_char, encode_invocation_designation):
12671 Now static, since they're not used elsewhere.
413bb2db 12672 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12673 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12674 (decode_coding_emacs_mule): Mark variables that gcc
12675 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12676 (detect_coding_iso_2022): Initialize a local variable that might
12677 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12678 this initialization is needed. (Bug#8211)
5f58e762
PE
12679 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12680 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12681 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12682 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12683 Remove unused macros.
f38b440c 12684
232b38b9 12685 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12686 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12687 * character.c (string_count_byte8): Likewise.
232b38b9 12688
fb90da1b
PE
12689 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12690 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12691
fb93dbc2
PE
12692 * chartab.c (copy_sub_char_table): Now static, since it's not used
12693 elsewhere.
5c156ace
PE
12694 (sub_char_table_ref_and_range, char_table_ref_and_range):
12695 Rename locals to avoid shadowing.
bbcd0949 12696 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12697
7d3b3862 12698 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12699 (BIDI_BOB): Remove unused macro.
7d3b3862 12700
6be7d3da
PE
12701 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12702 deduce are never used uninitialized.
c2ed9c8b 12703 * term.c (encode_terminal_code): Likewise.
6be7d3da 12704
75f8807f 12705 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12706
50938595
PE
12707 * tparam.h: New file.
12708 * term.c, tparam.h: Include it.
12709 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12710 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12711 Move these decls to tparam.h, and make them agree with what
12712 is actually in tparam.c. The previous trick of using incompatible
12713 decls in different modules does not conform to the C standard.
12714 All callers of tparam changed to use tparam's actual API.
12715 * tparam.c (tparam1, tparam, tgoto):
12716 Use const pointers where appropriate.
12717
fbceeba2
PE
12718 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12719 * cm.h (struct cm): Likewise.
12720 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12721 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12722 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12723 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12724 (turn_on_face, init_tty): Likewise.
12725 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12726
7f3f1250
PE
12727 * term.c (term_mouse_position): Rename local to avoid shadowing.
12728
e6ca6543
PE
12729 * alloc.c (mark_ttys): Move decl from here ...
12730 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12731
c40f8d15
AS
127322011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12733
12734 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12735
cfe0661d
JB
127362011-03-09 Juanma Barranquero <lekktu@gmail.com>
12737
12738 * search.c (compile_pattern_1): Remove argument regp, unused since
12739 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12740 (compile_pattern): Don't pass it.
12741
0afb4571
J
127422011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12743
12744 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12745 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12746 for ! HAVE_GTK3.
12747 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12748
12749 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12750
12751 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12752 gdk_window_get_screen, gdk_window_get_geometry,
12753 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12754 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12755 (xg_get_pixbuf_from_pixmap): New function.
12756 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12757 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12758 Call xg_get_pixbuf_from_pixmap instead of
12759 gdk_pixbuf_get_from_drawable.
12760 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12761 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12762 (xg_check_special_colors): Use GtkStyleContext and its functions
12763 for HAVE_GTK3.
12764 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12765 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12766 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12767 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12768 Call gtk_widget_get_preferred_size.
0afb4571
J
12769 (xg_frame_resized): gdk_window_get_geometry only takes 5
12770 parameters.
44f230aa
SM
12771 (xg_win_to_widget, xg_event_is_for_menubar):
12772 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12773 (xg_set_widget_bg): New function.
12774 (delete_cb): New function.
895009e1 12775 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12776 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12777 (xg_set_background_color): Call xg_set_widget_bg.
12778 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12779 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12780 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12781 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12782 if ! HAVE_GTK3.
12783 (update_frame_tool_bar): Call gtk_widget_hide.
12784 (xg_initialize): Use GDK_KEY_g.
12785
12786 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12787 if ! HAVE_GTK3
12788 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12789
12790 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12791 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12792 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12793
1c2cc4ef
JB
127942011-03-08 Juanma Barranquero <lekktu@gmail.com>
12795
12796 * w32xfns.c (select_palette): Check success of RealizePalette against
12797 GDI_ERROR, not zero.
12798
33383987 12799See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12800
12801;; Local Variables:
12802;; coding: utf-8
aac0c6e3
MR
12803;; End:
12804
2f097256 12805 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12806
12807 This file is part of GNU Emacs.
12808
12809 GNU Emacs is free software: you can redistribute it and/or modify
12810 it under the terms of the GNU General Public License as published by
12811 the Free Software Foundation, either version 3 of the License, or
12812 (at your option) any later version.
12813
12814 GNU Emacs is distributed in the hope that it will be useful,
12815 but WITHOUT ANY WARRANTY; without even the implied warranty of
12816 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12817 GNU General Public License for more details.
12818
12819 You should have received a copy of the GNU General Public License
12820 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.