* ccl.c (ccl_driver, Fregister_code_conversion_map): Check that Vcode_version_map_vec...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c801946a 12011-09-27 Paul Eggert <eggert@cs.ucla.edu>
d311d28c
PE
2
3 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5 (string_bytes, check_sblock, allocate_string_data):
6 (compact_small_strings, Fmake_bool_vector, make_string)
7 (make_unibyte_string, make_multibyte_string)
8 (make_string_from_bytes, make_specified_string)
9 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
10 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
11 (mark_vectorlike):
12 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
13 (allocate_pseudovector):
14 Use int, not EMACS_INT, where int is wide enough.
15 (inhibit_garbage_collection, Fgarbage_collect):
16 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
17 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
18 int might not be wide enough.
19 (bidi_cache_search, bidi_cache_find, bidi_init_it)
20 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
21 (bidi_at_paragraph_end, bidi_find_paragraph_start)
22 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
23 (bidi_level_of_next_char, bidi_move_to_visually_next):
24 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
25 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
26 (Fkill_buffer, Fset_buffer_major_mode)
27 (advance_to_char_boundary, Fbuffer_swap_text)
28 (Fset_buffer_multibyte, overlays_at, overlays_in)
29 (overlay_touches_p, struct sortvec, record_overlay_string)
30 (overlay_strings, recenter_overlay_lists)
31 (adjust_overlays_for_insert, adjust_overlays_for_delete)
32 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
33 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
34 (Foverlay_recenter, last_overlay_modification_hooks_used)
35 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
36 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
37 (validate_region): Omit unnecessary test for b <= e, since
38 that's guaranteed by the previous test.
39 (adjust_overlays_for_delete): Avoid pos + length overflow.
40 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
41 (report_overlay_modification):
42 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
43 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
44 Omit pointer cast, which isn't needed anyway, and doesn't work
45 after the EMACS_INT -> ptrdiff_t change.
46 * buffer.h: Adjust decls to match defn changes elsewhere.
47 (struct buffer_text, struct buffer):
48 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
49 Use EMACS_INT, not int, where int might not be wide enough.
50 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
51 needless 32-bit limit on 64-bit hosts. Remove unnecessary
52 memory-full test. Use EMACS_INT, not ptrdiff_t or int, where
53 ptrdiff_t or int might not be wide enough.
54 * callint.c (Fcall_interactively):
55 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
56 * callproc.c (call_process_kill, Fcall_process):
57 Don't assume pid_t fits into an Emacs fixnum.
58 (call_process_cleanup, Fcall_process, child_setup):
59 Don't assume pid_t fits into int.
60 (call_process_cleanup, Fcall_process, delete_temp_file)
61 (Fcall_process_region):
62 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
63 (Fcall_process): Simplify handling of volatile integers.
64 Use int, not EMACS_INT, where int will do.
65 * casefiddle.c (casify_object, casify_region, operate_on_word)
66 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
67 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
68 (casify_object): Avoid integer overflow when overallocating buffer.
69 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 70 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
71 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
72 * category.h (CATEGORYP): Don't assume arg is nonnegative.
73 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
74 integers are now checked earlier. All uses replaced with XINT.
75 (ccl_driver):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
78 (ccl_driver, Fregister_code_conversion_map):
79 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
80 (resolve_symbol_ccl_program): Check that vector header is in range.
81 Always copy the vector, so that we can check its contents reliably
82 now rather than having to recheck each instruction as it's being
83 executed. Check that vector words fit in 'int'.
84 (ccl_get_compiled_code, Fregister_ccl_program)
85 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
86 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
87 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
88 contents are in range.
89 (Fccl_execute_on_string): Check that status is in range.
90 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
91 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
92 Accept and return EMACS_INT, not int, because callers can pass values
93 out of 'int' range.
94 (c_string_width, strwidth, lisp_string_width, chars_in_text)
95 (multibyte_chars_in_text, parse_str_as_multibyte)
96 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
97 (str_as_unibyte, str_to_unibyte, string_count_byte8)
98 (string_escape_byte8, Fget_byte):
99 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
100 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
101 avoid mishandling large integers.
102 * character.h: Adjust decls to match defn changes elsewhere.
103 * charset.c (load_charset_map_from_file, find_charsets_in_text)
104 (Ffind_charset_region):
105 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
106 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
107 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 108 Don't assume fixnum fits in int.
d311d28c
PE
109 (load_charset_map_from_vector, Fmap_charset_chars):
110 Remove now-unnecessary CHECK_NATNUMs.
111 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
112 Don't rely on undefined behavior with signed left shift overflow.
113 Don't assume unsigned int fits into fixnum, or that fixnum fits
114 into unsigned int. Don't require max_code to be a valid fixnum;
115 that's not true for gb10830 4-byte on a 32-bit host. Allow
116 invalid_code to be a cons, for the same reason. Require code_offset
117 to be a character. Avoid int overflow if max_char is close
118 to INT_MAX.
119 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
120 this is intended anyway and avoids some undefined behavior.
121 (load_charset_map): Pass unsigned, not int, as 2nd arg of
122 INDEX_TO_CODE_POINT, as that's what it expects.
123 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
124 * charset.h (DECODE_CHAR): Return int, not unsigned;
125 this is what was intended anyway, and it avoids undefined behavior.
126 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
127 integer-overflow issues.
128 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
129 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
130 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
131 * chartab.c (Fmake_char_table, Fset_char_table_range)
132 (uniprop_get_decoder, uniprop_get_encoder):
133 Don't assume fixnum fits in int.
134 * cmds.c (move_point): New function, that does the gist of
135 Fforward_char and Fbackward_char, but does so while checking
136 for integer overflow more accurately.
c96e5d6a 137 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
138 (Fforward_line, Fend_of_line, internal_self_insert)
139 (internal_self_insert):
140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
141 Fix a FIXME, by checking for integer overflow when calculating
142 target_clm and actual_clm.
143 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
144 (ASSURE_DESTINATION, coding_alloc_by_realloc)
145 (coding_alloc_by_making_gap, alloc_destination)
146 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
147 (encode_coding_utf_16, detect_coding_emacs_mule)
148 (decode_coding_emacs_mule, encode_coding_emacs_mule)
149 (detect_coding_iso_2022, decode_coding_iso_2022)
150 (encode_invocation_designation, encode_designation_at_bol)
151 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
152 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
153 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
154 (encode_coding_ccl, encode_coding_raw_text)
155 (detect_coding_charset, decode_coding_charset)
156 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
157 (produce_composition, produce_charset, produce_annotation)
158 (decode_coding, handle_composition_annotation)
159 (handle_charset_annotation, consume_chars, decode_coding_gap)
160 (decode_coding_object, encode_coding_object, detect_coding_system)
161 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
162 (code_convert_region, code_convert_string)
163 (Fdefine_coding_system_internal):
164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
165 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
166 (Fdefine_coding_system_internal):
167 Don't assume fixnums fit in int.
168 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9
PE
169 (Fread_coding_system, Fdetect_coding_region)
170 (Funencodable_char_position, Fcheck_coding_systems_region):
d311d28c
PE
171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
172 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
173 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
174 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
175 result of ENCODE_CHAR.
d311d28c
PE
176 * coding.h: Adjust decls to match defn changes elsewhere.
177 (struct coding_system):
178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
179 * composite.c (get_composition_id, find_composition)
180 (run_composition_function, update_compositions)
181 (compose_text, composition_gstring_put_cache)
182 (composition_gstring_p, composition_gstring_width)
183 (fill_gstring_header, fill_gstring_body, autocmp_chars)
184 (composition_compute_stop_pos, composition_reseat_it)
185 (composition_update_it, struct position_record)
186 (find_automatic_composition, composition_adjust_point)
187 (Fcomposition_get_gstring, Ffind_composition_internal):
188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
189 (update_compositions):
190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
191 * composite.h: Adjust decls to match defn changes elsewhere.
192 (struct composition):
193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
194 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
195 Do not attempt to compute the address of the object just before a
196 buffer; this is not portable.
197 (Faref, Faset):
198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
199 (Faset): Use int, not EMACS_INT, where int is wide enough.
200 (Fstring_to_number): Don't assume fixnums fit in int.
201 (Frem): Don't assume arg is nonnegative.
202 * dbusbind.c (xd_append_arg): Check for integers out of range.
203 (Fdbus_call_method): Don't overflow the timeout int.
204 * dired.c (directory_files_internal, file_name_completion, scmp)
205 (file_name_completion_stat):
206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
207 (file_name_completion): Don't overflow matchcount.
208 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
209 * dispextern.h: Adjust decls to match defn changes elsewhere.
210 (struct text_pos, struct glyph, struct bidi_saved_info)
211 (struct bidi_string_data, struct bidi_it, struct composition_it)
212 (struct it):
213 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
214 (struct display_pos, struct composition_it, struct it):
215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
216 * dispnew.c (increment_matrix_positions)
217 (increment_row_positions, mode_line_string)
218 (marginal_area_string):
219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
220 (change_frame_size_1, Fredisplay):
221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
222 (duration_to_sec_usec): New function, to check for overflow better.
223 (Fsleep_for, sit_for): Use it.
224 * doc.c (get_doc_string, store_function_docstring):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (get_doc_string, Fsnarf_documentation):
227 Use int, not EMACS_INT, where int is wide enough.
228 (get_doc_string):
229 Use SAFE_ALLOCA, not alloca.
230 Check for overflow when converting EMACS_INT to off_t.
231 * doprnt.c (doprnt):
232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
233 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
234 Don't assume uid_t fits into fixnum.
235 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
236 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
237 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
238 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
239 (general_insert_function)
240 (Finsert_char, make_buffer_string, make_buffer_string_both)
241 (update_buffer_properties, Fbuffer_substring)
242 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
243 (Fsubst_char_in_region, check_translation)
244 (Ftranslate_region_internal, save_restriction_restore, Fformat)
245 (transpose_markers, Ftranspose_regions):
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 (clip_to_bounds): Move to lisp.h as an inline function).
248 (Fconstrain_to_field): Don't assume integers are nonnegative.
249 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
250 (Fsubst_char_in_region, Fsave_restriction):
251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
252 (Femacs_pid): Don't assume pid_t fits into fixnum.
253 (lo_time): Use int, not EMACS_INT, when int suffices.
254 (lisp_time_argument): Check for usec out of range.
255 (Fencode_time): Don't assume fixnum fits in int.
256 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
257 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
258 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
259 (init_cmdargs, Fdump_emacs):
260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
261 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
262 the bottom (typically) 32 bits of the fixnum.
263 * eval.c (specpdl_size, call_debugger):
264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
265 (when_entered_debugger, Fbacktrace_debug):
266 Don't assume fixnum can fit in int.
267 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
268 the object just before a buffer; this is not portable.
269 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
270 (grow_specpdl, unbind_to):
271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
272 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
273 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 274 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
275 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
276 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
279 (a_write, e_write):
280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
281 (Fcopy_file, non_regular_nbytes, read_non_regular)
282 (Finsert_file_contents):
283 Use int, not EMACS_INT, where int is wide enough.
284 (READ_BUF_SIZE): Verify that it fits in int.
285 (Finsert_file_contents): Check that counts are in proper range,
286 rather than assuming fixnums fit into ptrdiff_t etc.
287 Don't assume fixnums fit into int.
288 (Fdo_auto_save, Fset_buffer_auto_saved)
289 (Fclear_buffer_auto_save_failure):
290 Don't assume time_t is signed, or that it fits in int.
125b3835 291 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
292 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
293 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
294 (string_char_to_byte, string_byte_to_char)
295 (string_make_multibyte, string_to_multibyte)
296 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
297 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
298 (substring_both, Fdelete, internal_equal, Ffillarray)
299 (Fclear_string, mapcar1)
300 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
301 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
302 (larger_vector, make_hash_table, maybe_resize_hash_table)
303 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
304 (Fmaphash, secure_hash):
305 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
306 (concat): Check for string index and length overflow.
307 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
308 (Frequire):
309 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
310 (larger_vector): New API (vec, incr_min, size_max) replaces old
311 one (vec, new_size, init). This catches size overflow.
312 INIT was removed because it was always Qnil.
313 All callers changed.
314 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
315 the upper bound on a hash table index size.
316 (make_hash_table, maybe_resize_hash_table): Use it.
317 (secure_hash): Computer start_byte and end_byte only after
318 they're known to be in ptrdiff_t range.
319 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
320 (Ffont_get_glyphs, Ffont_at):
321 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
322 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
323 (Flist_fonts, Fopen_font):
324 Don't assume fixnum can fit in int.
325 (check_gstring): Don't assume index can fit in int.
326 (font_match_p): Check that fixnum is a character, not a nonnegative
327 fixnum, since the later code needs to stuff it into an int.
328 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
329 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
330 conversion overflow issues.
331 (Fopen_font): Check for integer out of range.
332 (Ffont_get_glyphs): Don't assume index can fit in int.
333 * font.h: Adjust decls to match defn changes elsewhere.
334 * fontset.c (reorder_font_vector): Redo score calculation to avoid
335 integer overflow.
336 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
337 printmax_t, where ptrdiff_t is wide enough.
338 (Finternal_char_font):
339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
340 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
341 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
342 (Fset_frame_position, x_set_frame_parameters)
343 (x_set_line_spacing, x_set_border_width)
344 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
345 Check that fixnums are in proper range for system types.
346 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
349 Use SAFE_ALLOCA_LISP, not alloca.
350 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
351 intptr_t is wide enough.
352 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
353 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
354 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
355 Check for fixnum out of range.
356 * ftfont.c (ftfont_list): Don't assume index fits in int.
357 Check that fixnums are in proper range for system types.
358 (ftfont_shape_by_flt):
359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
360 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
363 Check that fixnums are in proper range for system types.
364 * gnutls.h: Adjust decls to match defn changes elsewhere.
365 * gtkutil.c (xg_dialog_run):
366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
367 (update_frame_tool_bar):
368 Check that fixnums are in proper range for system types.
369 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 370 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
371 * indent.c (last_known_column, last_known_column_point):
372 (current_column_bol_cache):
373 (skip_invisible, current_column, check_display_width):
374 (check_display_width, scan_for_column, current_column_1)
375 (Findent_to, Fcurrent_indentation, position_indentation)
376 (indented_beyond_p, Fmove_to_column, compute_motion):
377 (Fcompute_motion, Fvertical_motion):
378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
379 (last_known_column_modified): Use EMACS_INT, not int.
380 (check_display_width):
381 (Fcompute_motion):
382 Check that fixnums and floats are in proper range for system types.
383 (compute_motion): Don't assume index or fixnum fits in int.
384 (compute_motion, Fcompute_motion):
385 Use int, not EMACS_INT, when it is wide enough.
386 (vmotion): Omit local var start_hpos that is always 0; that way
387 we don't need to worry about overflow in expressions involving it.
388 * indent.h: Adjust decls to match defn changes elsewhere.
389 (struct position):
390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
391 Use int, not EMACS_INT, where int is wide enough.
392 Remove unused members ovstring_chars_done and tab_offset;
393 all uses removed.
394 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
395 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
396 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
397 (make_gap, copy_text, insert, insert_and_inherit)
398 (insert_before_markers, insert_before_markers_and_inherit)
399 (insert_1, count_combining_before, count_combining_after)
400 (insert_1_both, insert_from_string)
401 (insert_from_string_before_markers, insert_from_string_1)
402 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
403 (adjust_after_replace, adjust_after_insert, replace_range)
404 (replace_range_2, del_range, del_range_1, del_range_byte)
405 (del_range_both, del_range_2, modify_region)
406 (prepare_to_modify_buffer, signal_before_change)
407 (signal_after_change, Fcombine_after_change_execute):
408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
409 * intervals.c (traverse_intervals, rotate_right, rotate_left)
410 (balance_an_interval, split_interval_right, split_interval_left)
411 (find_interval, next_interval, update_interval)
412 (adjust_intervals_for_insertion, delete_node, delete_interval)
413 (interval_deletion_adjustment, adjust_intervals_for_deletion)
414 (static_offset_intervals, offset_intervals)
415 (merge_interval_right, merge_interval_left, make_new_interval)
416 (graft_intervals_into_buffer, temp_set_point_both)
417 (temp_set_point, set_point, adjust_for_invis_intang)
418 (set_point_both, move_if_not_intangible, get_property_and_range)
419 (get_local_map, copy_intervals, copy_intervals_to_string)
420 (compare_string_intervals, set_intervals_multibyte_1):
421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
422 * intervals.h: Adjust decls to match defn changes elsewhere.
423 (struct interval):
424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
425 * keyboard.c (this_command_key_count, this_single_command_key_start)
426 (before_command_key_count, before_command_echo_length, echo_now)
427 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
428 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
429 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
430 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
431 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
432 (last_non_minibuf_size, last_point_position, echo_truncate)
433 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
434 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
435 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
436 (stuff_buffered_input):
437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
438 (last_auto_save, command_loop_1, read_char):
439 Use EMACS_INT, not int, to avoid integer overflow.
440 (record_char): Avoid overflow in total_keys computation.
441 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
442 * keyboard.h: Adjust decls to match defn changes elsewhere.
443 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
444 (Fkey_description, Fdescribe_vector, Flookup_key):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (click_position): New function, to check that positions are in range.
447 (Fcurrent_active_maps):
448 (describe_command):
449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
450 (Faccessible_keymaps, Fkey_description):
451 (preferred_sequence_p):
452 Don't assume fixnum can fit into int.
453 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
454 Check for integer overflow in size calculations.
455 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
456 avoid mishandling large integers.
457 * lisp.h: Adjust decls to match defn changes elsewhere.
458 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
459 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
460 (struct Lisp_Marker):
461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
462 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
463 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
464 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
465 All callers changed.
466 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
467 Assume the arg has valid form, since it always does.
468 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
469 unsigned integer system type.
470 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
471 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
473 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
474 (duration_to_sec_usec): New decl.
475 * lread.c (read_from_string_index, read_from_string_index_byte)
476 (read_from_string_limit, readchar, unreadchar, openp)
477 (read_internal_start, read1, oblookup):
478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
479 (Fload, readevalloop, Feval_buffer, Feval_region):
480 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
481 (openp): Check for out-of-range argument to 'access'.
482 (read1): Use int, not EMACS_INT, where int is wide enough.
483 Don't assume fixnum fits into int.
1ab7b8ac
PE
484 (read_filtered_event): Use duration_to_sec_usec
485 to do proper overflow checking on durations.
d311d28c
PE
486 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
487 in size calculation.
488 (Fexecute_kbd_macro):
489 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
490 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
491 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
492 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
493 (set_marker_both, set_marker_restricted_both, marker_position)
494 (marker_byte_position, Fbuffer_has_markers_at):
495 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
496 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
497 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
498 It now merely ensures that the menu is large enough, without
499 necessarily growing it, as this avoids some integer overflow issues.
500 All callers changed.
501 (keymap_panes, parse_single_submenu, Fx_popup_menu):
502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
503 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
504 Use SAFE_ALLOCA_LISP, not alloca.
505 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
506 to EMACS_INT. Check that fixnums are in proper range for system types.
507 * minibuf.c (minibuf_prompt_width, string_to_object)
508 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
509 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (get_minibuffer, read_minibuf_unwind):
512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
513 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
514 this simplifies overflow checking. All callers changed.
515 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
516 (Ftest_completion):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
519 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
520 Check that fixnums are in proper range for system types.
521 (Fx_create_frame, Fx_show_tip):
522 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
523 * nsfont.m (ns_findfonts, nsfont_list_family):
524 Don't assume fixnum fits in long.
525 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
527 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
528 wide enough.
529 * nsselect.m (ns_get_local_selection):
530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
531 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
532 (PRINTDECLARE, PRINTPREPARE):
533 (strout, print_string):
534 (print, print_preprocess, print_check_string_charset_prop)
535 (print_object):
536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
537 (PRINTDECLARE):
538 (temp_output_buffer_setup, Fprin1_to_string, print_object):
539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
540 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
541 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
542 (printchar, strout): Use xpalloc to catch size calculation overflow.
543 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
544 to avoid mishandling large integers.
545 (print_error_message): Use SAFE_ALLOCA, not alloca.
546 (print_object): Use int, not EMACS_INT, where int is wide enough.
547 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
548 (Fset_process_window_size, Fformat_network_address)
549 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
550 (Fsignal_process, sigchld_handler):
551 Check that fixnums are in proper range for system types.
552 (Fformat_network_address, read_process_output, send_process)
553 (Fprocess_send_region, status_notify):
554 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
555 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
556 (wait_reading_process_output, read_process_output, exec_sentinel):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
559 (Faccept_process_output): Use duration_to_sec_usec to do proper
560 overflow checking on durations.
b62b53e8
PE
561 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
562 configured --with-wide-int.
d311d28c
PE
563 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
564 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
565 * search.c (looking_at_1, string_match_1):
566 (fast_string_match, fast_c_string_match_ignore_case)
567 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
568 (scan_newline, find_before_next_newline, search_command)
569 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
570 (set_search_regs, wordify):
571 (Freplace_match):
572 (Fmatch_data):
573 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
574 (string_match_1, search_buffer, set_search_regs):
575 (Fmatch_data):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (wordify): Check for overflow in size calculation.
578 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
579 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
580 Check that fixnums are in proper range for system types.
581 * sound.c (struct sound_device)
582 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
584 (Fplay_sound_internal):
585 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
586 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
587 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
588 for the respective integer ranges. This fixes a bug with
589 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
590 (struct lisp_parse_state, find_start_modiff)
591 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
592 (Fparse_partial_sexp):
593 Don't assume fixnums can fit in int.
594 (struct lisp_parse_state, find_start_pos, find_start_value)
595 (find_start_value_byte, find_start_begv)
596 (update_syntax_table, char_quoted, dec_bytepos)
597 (find_defun_start, prev_char_comend_first, back_comment):
598 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
599 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Finternal_describe_syntax_value): Check that match_lisp is a
602 character, not an integer, since the code stuffs it into int.
603 (scan_words, scan_sexps_forward):
604 Check that fixnums are in proper range for system types.
605 (Fforward_word):
606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
607 (scan_sexps_forward):
608 Use CHARACTERP, not INTEGERP, since the value must fit into int.
609 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
610 * syntax.h: Adjust decls to match defn changes elsewhere.
611 (struct gl_state_s):
612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
613 * sysdep.c (wait_for_termination_1, wait_for_termination)
614 (interruptible_wait_for_termination, mkdir):
615 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
616 (emacs_read, emacs_write):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
618 (system_process_attributes): Don't assume uid_t, gid_t, and
619 double all fit in int or even EMACS_INT.
620 * term.c (set_tty_color_mode):
621 Check that fixnums are in proper range for system types.
622 * termhooks.h (struct input_event):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 * textprop.c (validate_interval_range, interval_of)
625 (Fadd_text_properties, set_text_properties_1)
626 (Fremove_text_properties, Fremove_list_of_text_properties)
627 (Ftext_property_any, Ftext_property_not_all)
628 (copy_text_properties, text_property_list, extend_property_ranges)
629 (verify_interval_modification):
630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
631 (Fnext_single_char_property_change)
632 (Fprevious_single_char_property_change):
633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
634 (copy_text_properties):
635 Check for integer overflow in index calculation.
d311d28c
PE
636 * undo.c (last_boundary_position, record_point, record_insert)
637 (record_delete, record_marker_adjustment, record_change)
638 (record_property_change):
639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
640 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
641 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
642 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
643 (Fx_hide_tip, Fx_file_dialog):
644 * w32menu.c (set_frame_menubar):
645 Use ptrdiff_t, not int, for consistency with rest of code.
646 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
647 (select_window, Fdelete_other_windows_internal)
648 (window_scroll_pixel_based, window_scroll_line_based)
649 (Frecenter, Fset_window_configuration):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (Fset_window_hscroll, run_window_configuration_change_hook)
652 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 653 (Fscroll_other_window, Frecenter):
d311d28c
PE
654 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
655 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
656 Don't assume fixnum fits in int.
657 (Fset_window_scroll_bars):
658 Check that fixnums are in proper range for system types.
659 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
660 (string_pos, c_string_pos, number_of_chars, init_iterator)
661 (in_ellipses_for_invisible_text_p, init_from_display_pos)
662 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
663 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
664 (face_before_or_after_it_pos, handle_invisible_prop)
665 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
666 (display_prop_intangible_p, string_buffer_position_lim)
667 (string_buffer_position, handle_composition_prop, load_overlay_strings)
668 (get_overlay_strings_1, get_overlay_strings)
669 (iterate_out_of_display_property, forward_to_next_line_start)
670 (back_to_previous_visible_line_start, reseat, reseat_to_string)
671 (get_next_display_element, set_iterator_to_next)
672 (get_visually_first_element, compute_stop_pos_backwards)
673 (handle_stop_backwards, next_element_from_buffer)
674 (move_it_in_display_line_to, move_it_in_display_line)
675 (move_it_to, move_it_vertically_backward, move_it_by_lines)
676 (add_to_log, message_dolog, message_log_check_duplicate)
677 (message2, message2_nolog, message3, message3_nolog
678 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
679 (current_message_1, truncate_echo_area, truncate_message_1)
680 (set_message, set_message_1, store_mode_line_noprop)
681 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
682 (text_outside_line_unchanged_p, check_point_in_composition)
683 (reconsider_clip_changes)
684 (redisplay_internal, set_cursor_from_row, try_scrolling)
685 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
686 (redisplay_window, find_last_unchanged_at_beg_row)
687 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
688 (trailing_whitespace_p, find_row_edges, display_line)
689 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
690 (display_mode_element, store_mode_line_string)
691 (pint2str, pint2hrstr, decode_mode_spec)
692 (display_count_lines, display_string, draw_glyphs)
693 (x_produce_glyphs, x_insert_glyphs)
694 (rows_from_pos_range, mouse_face_from_buffer_pos)
695 (fast_find_string_pos, mouse_face_from_string_pos)
696 (note_mode_line_or_margin_highlight, note_mouse_highlight):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (safe_call, init_from_display_pos, handle_fontified_prop)
699 (handle_single_display_spec, load_overlay_strings)
700 (with_echo_area_buffer, setup_echo_area_for_printing)
701 (display_echo_area, echo_area_display)
702 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
703 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
704 (redisplay_window, dump_glyph_row, display_mode_line)
705 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
d311d28c
PE
706 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
707 (handle_single_display_spec, build_desired_tool_bar_string)
708 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
709 (get_specified_cursor_type):
710 Check that fixnums are in proper range for system types.
711 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
712 (Flookup_image_map):
713 Don't assume fixnums fit in int.
714 (compare_overlay_entries):
715 Avoid mishandling comparisons due to subtraction overflow.
716 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
717 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
718 (handle_tool_bar_click):
719 Use int, not unsigned, since we prefer signed and the signedness
720 doesn't matter here.
721 (get_next_display_element, next_element_from_display_vector):
722 Use int, not EMACS_INT, when int is wide enough.
723 (start_hourglass): Use duration_to_sec_usec to do proper
724 overflow checking on durations.
725 * xfaces.c (Fbitmap_spec_p):
726 Check that fixnums are in proper range for system types.
727 (compare_fonts_by_sort_order):
728 Avoid mishandling comparisons due to subtraction overflow.
729 (Fx_family_fonts, realize_basic_faces):
730 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
731 (Fx_family_fonts):
732 Don't assume fixnum fits in int.
733 Use SAFE_ALLOCA_LISP, not alloca.
734 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
735 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
736 (face_at_buffer_position, face_for_overlay_string)
737 (face_at_string_position):
738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
739 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
740 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
741 (Fx_show_tip):
742 Check that fixnums are in proper range for system types.
743 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
744 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (Fx_change_window_property): Don't assume fixnums fit in int.
747 * xfont.c (xfont_chars_supported):
748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
749 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
750 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
752 * xml.c (parse_region):
753 * xrdb.c (magic_file_p):
754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
755 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
756 (x_get_local_selection, x_reply_selection_request)
757 (x_handle_selection_request, wait_for_property_change):
758 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
759 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
760 short is wide enough.
761 (x_send_client_event): Don't assume fixnum fits in int.
762 * xterm.c (x_x_to_emacs_modifiers):
763 Don't assume EMACS_INT overflows nicely into int.
764 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
765 may come from Lisp.
766 (handle_one_xevent): NATNUMP can eval its arg twice.
767 (x_connection_closed):
768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
769 * xterm.h: Adjust decls to match defn changes elsewhere.
770 (struct scroll_bar): Use struct vectorlike_header
771 rather than rolling our own approximation.
772 (SCROLL_BAR_VEC_SIZE): Remove; not used.
773
b2bf61aa
MA
7742011-09-25 Michael Albinus <michael.albinus@gmx.de>
775
776 * dbusbind.c (Fdbus_register_signal): When service is not
777 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
778
32bbb17c
GM
7792011-09-25 Glenn Morris <rgm@gnu.org>
780
781 * buffer.c (truncate-lines): Doc fix.
782
94e0933e
CY
7832011-09-24 Chong Yidong <cyd@stupidchicken.com>
784
785 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
786 (Fset_window_next_buffers): Doc fix.
787
cddde921
GM
7882011-09-24 Glenn Morris <rgm@gnu.org>
789
790 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
791
1260aef1
PE
7922011-09-24 Paul Eggert <eggert@cs.ucla.edu>
793
25b4bfa0
PE
794 Fix minor problems found by static checking.
795 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
796 * indent.c (Fvertical_motion): Fix == vs = typo.
797
e3cbd34b
EZ
7982011-09-24 Eli Zaretskii <eliz@gnu.org>
799
6bf7006f
EZ
800 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
801 value is now t. Doc fix.
802
e3cbd34b
EZ
803 * indent.c (Fvertical_motion): Compute and apply the overshoot
804 logic when moving up, not only when moving down. Fix the
805 confusing name and values of the it_overshoot_expected variable;
806 logic changes accordingly. (Bug#9254) (Bug#9549)
807
808 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
809 CHARPOS is covered by a display string which includes newlines.
810 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
811 is covered by a display string with embedded newlines.
812
a3de0cbd
MA
8132011-09-24 Michael Albinus <michael.albinus@gmx.de>
814
815 * dbusbind.c (Fdbus_register_signal): Add match rule to
816 Vdbus_registered_objects_table. (Bug#9581)
817 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
818 docstring.
819
b260039d
JM
8202011-09-24 Jim Meyering <meyering@redhat.com>
821
822 do not ignore write error for any output size
823 The previous change was incomplete.
824 While it makes emacs --batch detect the vast majority of stdout
825 write failures, errors were still ignored whenever the output size is
826 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
827 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
828 && echo FAIL: ignored write error
829 FAIL: ignored write error
830 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
831 && echo FAIL: ignored write error
832 FAIL: ignored write error
833 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
834
8eca8a7c
AS
8352011-09-23 Andreas Schwab <schwab@linux-m68k.org>
836
837 * emacs.c (Fkill_emacs): In noninteractive mode exit
838 non-successfully if a write error occurred on stdout. (Bug#9574)
839
3341db62
EZ
8402011-09-21 Eli Zaretskii <eliz@gnu.org>
841
842 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
843 the xassert test.
844
845 * dispextern.h (struct it): Update the comment documenting what
846 can it->OBJECT be.
847
8c203dbf
EZ
8482011-09-20 Eli Zaretskii <eliz@gnu.org>
849
850 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
851 a display string, extend search for cursor position to end of row.
852 (find_row_edges): If the row ends in a newline from a display
853 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
854 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
855 (Fcurrent_bidi_paragraph_direction): Fix search for previous
856 non-empty line. Fixes confusing cursor motion with arrow keys at
857 the beginning of a line that starts with whitespace.
8c203dbf 858
a4824228
LMI
8592011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
860
861 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
862 (bug#9493).
863
33ed493b
CY
8642011-09-18 Chong Yidong <cyd@stupidchicken.com>
865
866 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
867 boolean (Bug#9154).
868
56cd55c8
EZ
8692011-09-18 Eli Zaretskii <eliz@gnu.org>
870
871 * xdisp.c (display_line): Record maximum and minimum buffer
872 positions even if no glyphs were produced (e.g., by a zero-width
873 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
874 buffer positions that will be removed from the glyph row because
875 they don't fit.
c02dcedf
EZ
876 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
877 column is beyond frame width: don't subtract 1 "pixel" when
878 computing width of the stretch.
3e62b7e0
EZ
879 (reseat_at_next_visible_line_start): Undo the change made on
880 2011-09-17 that saved paragraph information and restored it after
881 the call to `reseat'. (Bug#9545)
56cd55c8 882
5ed99d36 8832011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
884
885 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
886 and turn window cursor on if cleared (Bug#9415).
887
5ed99d36 8882011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
889
890 * search.c (boyer_moore): Take unibyte characters from pattern
891 literally. (Bug#9458)
892
9bade7b2
EZ
8932011-09-18 Eli Zaretskii <eliz@gnu.org>
894
895 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
896
e5e9d610
PE
8972011-09-18 Paul Eggert <eggert@cs.ucla.edu>
898
87e4427a
PE
899 Fix minor problem found by static checking.
900 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
901 initialized, to pacify gcc -Wuninitialized.
902
e5e9d610
PE
903 * fileio.c: Report proper errno when syscall falls.
904 (Finsert_file_contents): Save and restore errno,
905 so that report_file_error outputs the correct diagnostic.
906 (Fwrite_region) [CLASH_DETECTION]: Likewise.
907
a1674f0b
EZ
9082011-09-18 Eli Zaretskii <eliz@gnu.org>
909
910 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
911
fbfb6dd4
EZ
9122011-09-17 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
915 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
916
bb187662
EZ
9172011-09-17 Eli Zaretskii <eliz@gnu.org>
918
1137e8b8
EZ
919 * xdisp.c (reseat_at_next_visible_line_start): Keep information
920 about the current paragraph and restore it after the call to
921 reseat.
922
923 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
924 (bidi_find_paragraph_start): Search back for paragraph beginning
925 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
926 (bidi_move_to_visually_next): Only trigger paragraph-related
927 computations when the last character is a newline or at EOB, not
928 just any NEUTRAL_B. (Bug#9470)
929
bb187662
EZ
930 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
931 truncated lines if point is covered by a display string. (Bug#9524)
932
2e621251
PE
9332011-09-16 Paul Eggert <eggert@cs.ucla.edu>
934
935 * xselect.c: Relax test for outgoing X longs (Bug#9498).
936 (cons_to_x_long): New function.
937 (lisp_data_to_selection_data): Use it. Correct the test for
938 short-versus-long data; it was negated. Break out of vector
939 loop, for efficiency, when a long datum is discovered.
940
91a15bc6
SM
9412011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
942
943 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
944
b41c3a35
EZ
9452011-09-16 Eli Zaretskii <eliz@gnu.org>
946
947 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
948 GCC PR/17406) by declaring this function with external scope.
949
7812ba2d
PE
9502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
951
952 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
953 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
954
cf7edc2a
AS
9552011-09-15 Andreas Schwab <schwab@linux-m68k.org>
956
957 * editfns.c (Fformat): Correctly handle text properties on "%%".
958
bd01620e
EZ
9592011-09-15 Eli Zaretskii <eliz@gnu.org>
960
961 * xterm.c (x_draw_composite_glyph_string_foreground):
962 * w32term.c (x_draw_composite_glyph_string_foreground):
963 * term.c (encode_terminal_code):
964 * composite.c (composition_update_it, get_composition_id):
965 * xdisp.c (get_next_display_element)
966 (fill_composite_glyph_string): Add comments about special meaning
967 of TAB characters in a composition.
968
a02719a3
PE
9692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
970
971 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
972 This occurs when processing a multibyte format.
973 Problem reported by Wolfgang Jenker.
a02719a3 974
72589a3c
JB
9752011-09-15 Johan Bockgård <bojohan@gnu.org>
976
977 * xdisp.c (try_cursor_movement): Only check for exact match if
978 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
979
1c14176c
PE
9802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
981
982 Remove unused external symbols.
983 * dispextern.h (calc_pixel_width_or_height): Remove decl.
984 * xdisp.c (calc_pixel_width_or_height): Now static.
985 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
986 * indent.c (check_display_width):
987 * w32term.c: Fix comment to match code.
988 * xterm.c, xterm.h (x_catching_errors): Remove.
989
d2eea5b5
PE
9902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
991
992 * xselect.c: Use signed conversions more consistently (Bug#9498).
993 (selection_data_to_lisp_data): Assume incoming selection data are
994 signed integers, not unsigned. This is to be consistent with
995 outgoing selection data, which was modified to use signed integers
996 in as part of the fix to Bug#9196 in response to Jan D.'s comment
997 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
998 expects long, not unsigned long.
999
46888499
EZ
10002011-09-14 Eli Zaretskii <eliz@gnu.org>
1001
1002 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1003 computation of loop end. Reported by Johan Bockgård
1004 <bojohan@gnu.org>.
1005
ef8ef9fb
CY
10062011-09-13 Chong Yidong <cyd@stupidchicken.com>
1007
1008 * frame.c (Fother_visible_frames_p): Function deleted.
1009
fa819fed
EZ
10102011-09-12 Eli Zaretskii <eliz@gnu.org>
1011
1012 * indent.c (compute_motion): Process display vector front to back
1013 rather than the other way around. (Bug#2496)
1014
2ba8e008
SM
10152011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1016
1017 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1018
20f53c69
CY
10192011-09-11 Chong Yidong <cyd@stupidchicken.com>
1020
1021 * minibuf.c (Fread_from_minibuffer): Doc fix.
1022
d562d7a4
EZ
10232011-09-11 Eli Zaretskii <eliz@gnu.org>
1024
1025 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1026 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1027
1c4d7f3d
LMI
10282011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1029
1030 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1031 value for non-existent files.
1032
b885bf36
EZ
10332011-09-11 Eli Zaretskii <eliz@gnu.org>
1034
1035 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1036 set its "size" to -1. This will set the modtime_size field of
1037 the corresponding buffer to -1, which is what
1038 verify-visited-file-modtime expects for files that do not exist.
1039 (Bug#9139)
1040
6612f0bf
PE
10412011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1042
1043 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1044 here ...
1045 * lisp.h: ... from here. push_key_description is no longer
1046 defined in keyboard.c, so its declaration should not be in
1047 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1048 logically belongs with push_key_description.
1049
dfb3f755
PE
10502011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1051
1052 * buffer.h: Include <sys/types.h> instead of <time.h>.
1053 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1054 Problem reported by Herbert J. Skuhra.
1055
3134906c
LMI
10562011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1057
1058 * xml.c (parse_region): Make the parsing work for
1059 non-comment-starting XML files again (bug#9144).
1060
8d903f4e
AS
10612011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1062
1063 * image.c (gif_load): Fix calculation of bottom and right corner.
1064 (Bug#9468)
1065
80ad64f4
EZ
10662011-09-10 Eli Zaretskii <eliz@gnu.org>
1067
1068 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1069 redisplay in small windows.
1070
208a048d
EZ
10712011-09-09 Eli Zaretskii <eliz@gnu.org>
1072
1073 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1074
9b1c252e
MR
10752011-09-08 Martin Rudalics <rudalics@gmx.at>
1076
1077 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1078 Operate on live windows only.
1079
2949f33b
JB
10802011-09-08 Juanma Barranquero <lekktu@gmail.com>
1081
1082 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1083
e08dcafd
EZ
10842011-09-07 Eli Zaretskii <eliz@gnu.org>
1085
1086 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1087 only under bidi iteration.
1088
115b96bd
JD
10892011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1090
1091 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1092
c8199d0f
PE
10932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1094
1095 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1096 Without this fix, the command to link temacs failed due to an
1097 undefined symbol __builtin_isnan. This is because
1098 /usr/include/iso/math_c99.h #defines isnan(x) to
1099 __builtin_isnan(x), but the bundled gcc, which identifies itself
1100 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1101 a __builtin_isnan.
1102 * floatfns.c (isnan): #undef, and then #define to a clone of
1103 what's in data.c.
1104 (Fisnan): Always define, since it's always available now.
1105 (syms_of_floatfns): Always define isnan at the Lisp level.
1106
e39b275c 11072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1108
1109 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1110
b2db44d9 11112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1112
f4af5137 1113 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1114 The previous code assumed that file offsets (off_t values) fit in
1115 EMACS_INT variables, which is not true on typical 32-bit hosts.
1116 The code messed up by falsely reporting buffer overflow in cases
1117 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1118 when "big" contains more than 2**29 bytes, even though this
1119 inserts just one byte and does not overflow the buffer.
1120 (Finsert_file_contents): Store file offsets as off_t
1121 values, not as EMACS_INT values. Check for overflow when
1122 converting between EMACS_INT and off_t. When checking for
1123 buffer overflow or for overlap, take the offsets into account.
1124 Don't use EMACS_INT for small values where int suffices.
1125 When checking for overlap, fix a typo: ZV was used where
1126 ZV_BYTE was intended.
1127 (Fwrite_region): Don't assume off_t fits into 'long'.
1128 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1129
ecfc0a49
MA
11302011-09-05 Michael Albinus <michael.albinus@gmx.de>
1131
1132 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1133
6511acf2 11342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1135
0999621a 1136 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1137
1138 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1139 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1140 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1141 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1142 (modify_event_symbol): Do not assume that the length of
1143 name_alist_or_stem is safe to alloca and fits in int.
1144 (Fexecute_extended_command): Likewise for function name and binding.
1145 (Frecursion_depth): Wrap around reliably on integer overflow.
1146 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1147 since some callers pass EMACS_INT values.
1148 (Fsingle_key_description): Don't crash if symbol name contains more
1149 than MAX_ALLOCA bytes.
1150 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1151 (get_minibuffer): Arg is now EMACS_INT, not int.
1152 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1153 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1154 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1155
2be7d702
PE
1156 * dbusbind.c (signature_cat): New function.
1157 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1158 Do not overrun buffer; instead, report string overflow.
1159
9d1df220
PE
1160 * dispnew.c (add_window_display_history): Don't overrun buffer.
1161 Truncate instead; this is OK since it's just a log.
1162
33ef5c64
PE
1163 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1164 even if the time zone offset is outlandishly large.
1165 Don't mishandle offset == INT_MIN.
1166
66c6fdd5
PE
1167 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1168 when creating daemon; the previous buffer-overflow check was incorrect.
1169
d749b01b
PE
1170 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1171 which has the guts of the old verror function.
1172
b5cd1905
PE
1173 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1174 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1175
6e1a67fb
PE
1176 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1177 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1178 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1179 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1180 length of string rather than counting it via multiple sprintfs;
1181 that's simpler and more reliable.
c21721cc
PE
1182 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1183 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1184 sprintf, in case result does not fit in int.
1185
c57b67fc
PE
1186 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1187 (fontset_from_font): Print it.
1188
8a401434
PE
1189 * frame.c (tty_frame_count): Now printmax_t, not int.
1190 (make_terminal_frame, set_term_frame_name): Print it.
1191 (x_report_frame_params): In X, window IDs are unsigned long,
1192 not signed long, so print them as unsigned.
1193 (validate_x_resource_name): Check for implausibly long names,
1194 and don't assume name length fits in 'int'.
1195 (x_get_resource_string): Don't blindly alloca invocation name;
1196 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1197 not fit in int.
1198
6e1a67fb
PE
1199 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1200 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1201 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1202
0df02bf3
PE
1203 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1204 Use esprintf, not sprintf, in case result does not fit in int.
1205
48e30793
PE
1206 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1207 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1208 it as a large positive number.
1209 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1210 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1211
a66ff6d8
PE
1212 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1213 in case result does not fit in int.
1214
aca216ff
PE
1215 * print.c (float_to_string): Detect width overflow more reliably.
1216 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1217 buffer overrun. Don't assume list length fits in 'int'. Treat
1218 print length of 0 as 0, not as infinity; to be consistent with other
1219 uses of print length in this function. Don't overflow print length
1220 index. Don't assume hash table size fits in 'long', or that
1221 vectorlike size fits in 'unsigned long'.
1222
31c286f7
PE
1223 * process.c (make_process): Use printmax_t, not int, to format
1224 process-name gensyms.
1225
55e5faa1
PE
1226 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1227
80f2e268
PE
1228 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1229 to avoid potential buffer overrun.
1230
670741ab
PE
1231 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1232 if X resource line is longer than 512 bytes.
1233
b7163a50
PE
1234 * xfns.c (x_window): Make sprintf buffer a bit bigger
1235 to avoid potential buffer overrun.
1236
ae58ff1f
PE
1237 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1238
c43c8a6a
PE
1239 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1240
3f8236f4
PE
12412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1242
53e9fe90 1243 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1244 Without these, Emacs silently mishandles large integers sometimes.
1245 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1246 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1247
6511acf2
PE
1248 * xdisp.c (try_window_id): Check Emacs fixnum range before
1249 converting to 'int'.
806add1d 1250
6511acf2 1251 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1252 Check that an Emacs fixnum is in range before assigning it to 'int'.
1253 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1254 values converted from Emacs fixnums.
1255 (Frecenter): Don't wrap around a line count if it is out of 'int'
1256 range; instead, treat it as an extreme value.
1257 (Fset_window_configuration, compare_window_configurations):
1258 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1259
6511acf2
PE
1260 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1261 that can exceed INT_MAX. Check that EMACS_INT value is in range
1262 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1263 (match_limit): Don't assume that a fixnum can fit in 'int'.
1264
6511acf2 1265 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1266 exceed INT_MAX.
1267
6511acf2 1268 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1269 (Fvertical_motion): Don't wrap around LINES values that don't fit
1270 in 'int'. Instead, treat them as extreme values. This is good
1271 enough for windows, which can't have more than INT_MAX lines anyway.
1272
fcb901a7
LMI
12732011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1274
0f2f6b6d
LMI
1275 * Require libxml/parser.h to avoid compilation warning.
1276
fcb901a7
LMI
1277 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1278
1279 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1280 since this reportedly can destroy thread storage.
1281
6e20a0d4
CY
12822011-08-30 Chong Yidong <cyd@stupidchicken.com>
1283
1284 * syntax.c (find_defun_start): Update all cache variables if
1285 exiting early (Bug#9401).
1286
148ae00e
EZ
12872011-08-30 Eli Zaretskii <eliz@gnu.org>
1288
f6cfbd8f
EZ
1289 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1290
148ae00e
EZ
1291 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1292 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1293 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1294
1295 * term.c (tty_append_glyph): New function.
1296 (produce_stretch_glyph): Static function and its prototype deleted.
1297
1298 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1299 prototypes.
1300
c4a07a4c
PE
13012011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1304 when checking :margin (Bug#9390).
1305 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1306 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1307 so that the name doesn't mislead. All uses changed.
1308
6bc8cd65
JB
13092011-08-28 Johan Bockgård <bojohan@gnu.org>
1310
1311 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1312 set_tty_hooks.
1313
dca4927e
EZ
13142011-08-27 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xdisp.c (move_it_to): Don't bail out early when reaching
1317 position beyond to_charpos, if we are scanning backwards.
1318 (move_it_vertically_backward): When DY == 0, make sure we get to
1319 the first character in the line after the newline.
1320
f2cad773
PE
13212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1322
1323 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1324 (ccl_driver): Do not generate an out-of-range pointer.
1325 (Fccl_execute_on_string): Remove unnecessary check for
1326 integer overflow, noted by Stefan Monnier in
1327 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1328 Remove a FIXME that didn't need fixing.
1329 Simplify the newly-introduced buffer reallocation code.
1330
0cae2cdb
JB
13312011-08-27 Juanma Barranquero <lekktu@gmail.com>
1332
1333 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1334
5fc295a4 13352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1336
70c60eb2 1337 Integer and memory overflow issues (Bug#9196).
726e0ab1 1338
d31850da
PE
1339 * doc.c (get_doc_string): Rework so that
1340 get_doc_string_buffer_size is the actual buffer size, rather than
1341 being 1 less than the actual buffer size; this makes xpalloc more
1342 convenient.
1343
a69fbedb
PE
1344 * image.c (x_allocate_bitmap_record, cache_image):
1345 * xselect.c (Fx_register_dnd_atom):
1346 Simplify previous changes by using xpalloc.
1347
fe5c5d37
PE
1348 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1349 since either will do and ptrdiff_t is convenient with xpalloc.
1350
0065d054
PE
1351 * charset.c (charset_table_size)
1352 (struct charset_sort_data.priority): Now ptrdiff_t.
1353 (charset_compare): Don't overflow if priorities differ greatly.
1354 (Fsort_charsets): Don't assume list length fits in int.
1355 Check for size-calculation overflow when allocating sort data.
1356 (syms_of_charset): Allocate an initial charset table that is
1357 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1358
1359 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1360
1361 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1362 The actual value is always <= INT_MAX, and leaving it unsigned made
1363 overflow checking harder.
1364
1365 * dispextern.h (struct glyph_matrix.rows_allocated)
1366 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1367 with xpalloc. The values are still always <= INT_MAX.
1368
1369 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1370
1371 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1372 (SAFE_NALLOCA): New macro.
1373
1374 * region-cache.c (struct boundary.pos, find_cache_boundary)
1375 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1376 (set_cache_region, invalidate_region_cache)
1377 (revalidate_region_cache, know_region_cache, region_cache_forward)
1378 (region_cache_backward, pp_cache):
1379 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1380 so that ptrdiff_t * can be passed to xpalloc.
1381 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1382 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1383 (pp_cache): Don't assume cache_len fits in int.
1384 * region-cache.h: Adjust extern decls to match.
1385
1386 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1387 EMACS_INT, since either will do, for xpalloc.
1388
1389 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1390 (xnmalloc, xnrealloc, xpalloc): New functions.
1391
726e0ab1
PE
1392 * bidi.c (bidi_shelve_header_size): New constant.
1393 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1394 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1395
51f30bc5 1396 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1397 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1398 (overlay_strings):
1399 Don't update size of array until after memory allocation succeeds,
1400 because xmalloc/xrealloc may not return.
0065d054
PE
1401 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1402 now that we have proper integer overflow checking.
1403 (record_overlay_string, overlay_strings): Catch overflows when
1404 calculating size of overlay_str_buf.
726e0ab1 1405
0065d054
PE
1406 * callproc.c (Fcall_process): Check for size overflow when
1407 calculating size of args2.
1408 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1409 Normally we prefer signed values, but sticking with ptrdiff_t would
1410 require adding more-complicated checks.
726e0ab1
PE
1411
1412 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1413 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1414 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1415 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1416
1417 * character.c (Fstring): Check for size-calculation overflow.
1418
1419 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1420 unnecessary integer overflow. Check for size overflow.
1421 (encode_coding_object): Don't update size until xmalloc succeeds.
1422
1423 * composite.c (get_composition_id): Check for overflow in glyph
1424 length calculations.
1425
1426 Integer and memory overflow fixes for display code.
1427 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1428 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1429 (scrolling_window): Check for overflow in size calculations.
1430 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1431 Don't assume glyph table len fits in int.
1432 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1433 (row_table_size): Now ptrdiff_t, not int.
1434 (scrolling_window): Avoid overflow in size calculations.
1435 Don't update size until allocation succeeds.
1436 * fns.c (concat): Check for overflow in size calculations.
1437 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1438 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1439 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1440
1441 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1442 (get_doc_string): Check for size calculation overflow.
1443 Don't update size until allocation succeeds.
1444 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1445 EMACS_INT, where ptrdiff_t will do.
1446 (Fsubstitute_command_keys): Check for string overflow.
1447
1448 * editfns.c (set_time_zone_rule): Don't assume environment length
1449 fits in int.
1450 (message_length): Now ptrdiff_t, not int.
1451 (Fmessage_box): Don't update size until allocation succeeds.
1452 Don't assume message length fits in int.
1453 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1454
0065d054
PE
1455 * emacs.c (main): Do not reallocate argv, since there is a null at
1456 the end that can be overwritten, and this way there's no need to
1457 worry about size-calculation overflow.
1458 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1459
1460 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1461 alloc succeeds.
1462 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1463
1464 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1465 (x_set_scroll_bar_width, x_figure_window_size):
1466 Check for integer overflow.
1467 (x_set_alpha): Do not assume XINT fits in int.
1468
1469 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1470 This is for the members text_lines, text_cols, total_lines, total_cols,
1471 where the system imposes an 'int' limit.
1472
1473 * fringe.c (Fdefine_fringe_bitmap):
1474 Don't update size until alloc works.
1475
1476 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1477 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1478
1479 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1480 Check for size-calculation overflow.
1481 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1482 do, as we prefer signed integers.
1483 (id_to_widget.max_size, id_to_widget.used)
1484 (xg_store_widget_in_map, xg_remove_widget_from_map)
1485 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1486 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1487 Use and return ptrdiff_t, not int.
1488 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1489 * gtkutil.h: Change prototypes to match the above.
1490
1491 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1492 are duplicate now that they've been promoted to lisp.h.
1493 (x_allocate_bitmap_record, x_alloc_image_color)
1494 (make_image_cache, cache_image, xpm_load):
1495 Don't update size until alloc is done.
1496 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1497 (x_detect_edges):
3256efce 1498 Check for size calculation overflow.
726e0ab1
PE
1499 (ct_colors_allocated_max): New constant.
1500 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1501 overflow.
3256efce 1502
726e0ab1
PE
1503 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1504 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1505 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1506 Use ptrdiff_t, not int, to count maps.
1507 (read_char_minibuf_menu_prompt): Check for overflow in size
1508 calculations. Don't update size until allocation succeeds. Redo
1509 calculations to avoid overflow.
1510 * keyboard.h: Change prototypes to match the above.
1511
1512 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1513 to count maps.
1514 (current_minor_maps): Check for size calculation overflow.
1515 * keymap.h: Change prototypes to match the above.
1516
1517 * lread.c (read1, init_obarray): Don't update size until alloc done.
1518
1519 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1520 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1521
726e0ab1
PE
1522 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1523 Now ptrdiff_t, not int.
1524 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1525 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1526
1527 * process.c (Fnetwork_interface_list): Check for overflow
1528 in size calculation.
1529
1530 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1531
1532 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1533 overflow. Don't bother calling xmalloc when xrealloc will do.
1534
1535 * search.c (Freplace_match): Check for size calculation overflow.
1536 (Fset_match_data): Don't assume list lengths fit in 'int'.
1537
1538 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1539 for command line length. Do not attempt to address one before the
1540 beginning of an array, as that's not portable.
1541
1542 * term.c (max_frame_lines): Remove; unused.
1543 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1544 not int.
1545 (encode_terminal_code, calculate_costs): Check for size
1546 calculation overflow.
1547 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1548 table lengths and related sizes. Don't update size until alloc
1549 done. Redo calculations to avoid overflow.
1550 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1551
1552 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1553 subtracting pointers.
1554 (gobble_line): Check for overflow more carefully. Don't update size
1555 until alloc done.
1556
1557 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1558 Don't update size until alloc done.
1559 Redo size calculations to avoid overflow.
1560 Check for size calculation overflow.
0065d054 1561 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1562
1563 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1564 Use ptrdiff_t, not int, for sizes.
1565 (store_mode_line_noprop_char): Don't update size until alloc done.
1566
0065d054
PE
1567 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1568 Use ptrdiff_t, not int, for sizes.
1569 (Finternal_make_lisp_face, cache_face):
1570 Check for size calculation overflow.
1571 (cache_face): Treat size calculation overflows as if they were
1572 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1573
1574 * xfns.c (x_encode_text, x_set_name_internal)
1575 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1576 sizes, since they can exceed INT_MAX in size. Check for size
1577 calculation overflow.
1578
0065d054
PE
1579 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1580 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1581 Don't update size until alloc done.
1582
0065d054 1583 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1584 as sprintf is limited to int lengths.
1d526e2f 1585
252c5ee1
PE
1586 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1587 (X_LONG_MIN): New macros.
864d7ce7
PE
1588 Use them to make the following changes clearer.
1589 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1590 This change doesn't affect the value now, but it may help remind
1591 future maintainers not to raise the value too much later.
1592 (SELECTION_QUANTUM): Remove, replacing with ...
1593 (selection_quantum): ... new function, which avoids overflow.
1594 All uses changed.
1595 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1596 assumption that selection length fits in 'int'.
1597 (x_reply_selection_request, x_handle_selection_request)
1598 (x_get_window_property, receive_incremental_selection)
1599 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1600 (lisp_data_to_selection_data, clean_local_selection_data):
1601 Use ptrdiff_t, not int, to record length of selection.
1602 (x_reply_selection_request, x_get_window_property)
1603 (receive_incremental_selection, x_property_data_to_lisp):
1604 Redo calculations to avoid overflow.
1605 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1606 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1607 something.
1608 (x_get_window_property, receive_incremental_selection)
1609 (lisp_data_to_selection_data, x_property_data_to_lisp):
1610 Check for size-calculation overflow.
1611 (x_get_window_property, receive_incremental_selection)
1612 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1613 Don't store size until memory allocation succeeds.
1614 (x_get_window_property): Plug memory leak on memory exhaustion.
1615 Don't double-block input; malloc is safe here. Don't assume 2**34
1616 - 4 fits in unsigned long. Add an xassert to check
1617 XGetWindowProperty overflow. Be more careful about overflow
1618 calculations, and distinguish size from memory overflow better.
1619 (receive_incremental_selection): When tracing, don't assume
1620 unsigned int is less than INT_MAX.
1621 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1622 harmful) conversions of unsigned short to int.
1623 (lisp_data_to_selection_data): Don't assume that integers
1624 in the range -65535 through -1 fit in an X unsigned short.
1625 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1626 result parameters unless successful. Rely on cons_to_unsigned
1627 to report problems with elements; the old code wasn't right anyway.
1628 (x_check_property_data): Check for int overflow; we cannot use
1629 a wider type due to X limits.
1630 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1631
726e0ab1 1632 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1633
0065d054
PE
1634 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1635 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1636 (x_color_cells): Don't store size until memory allocation succeeds.
1637 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1638 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1639 (x_term_init): Don't assume length fits in int (sprintf is limited
1640 to int size).
bc18e09d 1641
ebfa62c0
PE
1642 Use ptrdiff_t for composition IDs.
1643 * character.c (lisp_string_width):
1644 * composite.c (composition_table_size, n_compositions)
1645 (get_composition_id, composition_gstring_from_id):
1646 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1647 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1648 * window.c (Frecenter):
1649 Use ptrdiff_t, not int, for composition IDs.
1650 * composite.c (get_composition_id): Check for integer overflow.
1651 * composite.h: Adjust prototypes to match the above changes.
1652
d3411f89
PE
1653 Use ptrdiff_t for hash table indexes.
1654 * category.c (hash_get_category_set):
1655 * ccl.c (ccl_driver):
1656 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1657 * coding.c (coding_system_charset_list, detect_coding_system):
1658 * coding.h (struct coding_system.id):
1659 * composite.c (get_composition_id, gstring_lookup_cache):
1660 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1661 * image.c (xpm_get_color_table_h):
1662 * lisp.h (hash_lookup, hash_put):
1663 * minibuf.c (Ftest_completion):
1664 Use ptrdiff_t for hash table indexes, not int (which is too
1665 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1666 32-bit --with-wide-int hosts).
1667
e097a6fa
PE
1668 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1669 Add a FIXME comment about memory leaks.
1670 (syms_of_charset): Don't assume xmalloc returns.
1671
5637687f
PE
1672 Don't assume that stated character widths fit in int.
1673 * character.c (Fchar_width, c_string_width, lisp_string_width):
1674 * character.h (CHAR_WIDTH):
1675 * indent.c (MULTIBYTE_BYTES_WIDTH):
1676 Use sanitize_char_width to avoid undefined and/or bad behavior
1677 with outlandish widths.
1678 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1679 now that we have two such functions. All uses changed.
1680 (sanitize_char_width): New inline function.
1681
a2271ba2
PE
1682 Don't assume that tab-width fits in int.
1683 * character.h (sanitize_width): New inline function.
1684 (SANE_TAB_WIDTH): New macro.
1685 (ASCII_CHAR_WIDTH): Use it.
1686 * indent.c (sane_tab_width): Remove. All uses replaced by
1687 SANE_TAB_WIDTH (current_buffer).
1688 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1689
18c52557
PE
1690 * fileio.c: Integer overflow issues with file modes.
1691 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1692
caeeedc1
PE
1693 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1694 Remove unreachable code.
1695 (read_hex, load_charset_map_from_file): Check for integer overflow.
1696
50849c52
PE
1697 * xterm.c: don't go over XClientMessageEvent limit
1698 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1699 (x_send_scroll_bar_event): Likewise. Check that the size does not
1700 exceed limits imposed by XClientMessageEvent, as well as the usual
1701 ptrdiff_t and size_t limits.
1702
b13995db
PE
1703 * keyboard.c: Overflow, signedness and related fixes.
1704 (make_lispy_movement): Use same integer type in forward decl
1705 that is used in the definition.
1706 (read_key_sequence, keyremap_step):
1707 Change bufsize argument back to int, undoing my 2011-03-30 change.
1708 We prefer signed types, and int is wide enough here.
1709 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1710 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1711 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1712 length, not size_t. Use ptrdiff_t for index, not int.
1713 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1714 possibility of integer overflow.
1715
13464394
PE
1716 Overflow, signedness and related fixes for images.
1717
1718 * dispextern.h (struct it.stack[0].u.image.image_id)
1719 (struct_it.image_id, struct image.id, struct image_cache.size)
1720 (struct image_cache.used, struct image_cache.ref_count):
1721 * gtkutil.c (update_frame_tool_bar):
1722 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1723 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1724 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1725 * nsmenu.m (update_frame_tool_bar):
1726 * xdisp.c (calc_pixel_width_or_height):
1727 * xfns.c (image_cache_refcount):
1728 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1729 on typical 64-bit hosts.
1730
1731 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1732 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1733 Omit unnecessary casts to int.
1734 (parse_image_spec): Check that integers fall into 'int' range
1735 when the callers expect that.
1736 (image_ascent): Redo ascent calculation to avoid int overflow.
1737 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1738 (lookup_image): Remove unnecessary tests.
1739 (xbm_image_p): Locals are now of int, not EMACS_INT,
1740 since parse_image_check makes sure they fit into int.
1741 (png_load, gif_load, svg_load_image):
1742 Prefer int to unsigned where either will do.
1743 (tiff_handler): New function, combining the cores of the
1744 old tiff_error_handler and tiff_warning_handler. This
1745 function is rewritten to use vsnprintf and thereby avoid
1746 stack buffer overflows. It uses only the features of vsnprintf
1747 that are common to both POSIX and native Microsoft.
1748 (tiff_error_handler, tiff_warning_handler): Use it.
1749 (tiff_load, gif_load, imagemagick_load_image):
1750 Don't assume :index value fits in 'int'.
1751 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1752 (imagemagick_load_image): Check that crop parameters fit into
1753 the integer types that MagickCropImage accepts. Don't assume
1754 Vimagemagick_render_type has a nonnegative value. Don't assume
1755 size_t fits in 'long'.
1756 (gs_load): Use printmax_t to print the widest integers possible.
1757 Check for integer overflow when computing image height and width.
1758
c11821d4
EZ
17592011-08-26 Eli Zaretskii <eliz@gnu.org>
1760
1761 * xdisp.c (redisplay_window): Don't force window start if point
1762 will be invisible in the resulting window. (Bug#9324)
1763
0c95fcf7
EZ
17642011-08-25 Eli Zaretskii <eliz@gnu.org>
1765
1766 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1767 the display spec is of the form `(space ...)'.
1768 (handle_display_spec): Return the value returned by
1769 handle_single_display_spec, not just 1 or zero.
1770 (handle_single_display_spec): If the display spec is of the form
1771 `(space ...)', and specifies display in the text area, return 2
1772 rather than 1.
fee65a97 1773 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1774 accurately, and prefer exact match for point under bidi. Don't
1775 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1776
1777 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1778 into disp_prop; all users changed.
1779
1780 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1781 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1782 for the text covered by the display property.
1783
e4ed06f1
CY
17842011-08-25 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1787 Change return value to nil.
1788 (Frecord_buffer): Delete unused function.
1789
f67cdd7f
EZ
17902011-08-24 Eli Zaretskii <eliz@gnu.org>
1791
5980d4c6
EZ
1792 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1793 buffers, return left-to-right.
8610fe8b
EZ
1794 (set_cursor_from_row): Consider candidate row a win if its glyph
1795 represents a newline and point is on that newline. Fixes cursor
1796 positioning on the newline at EOL of R2L text within L2R
1797 paragraph, and vice versa.
1798 (try_cursor_movement): Check continued rows, in addition to
1799 continuation rows. Fixes unwarranted scroll when point enters a
1800 continued line of R2L text within an L2R paragraph, or vice versa.
1801 (cursor_row_p): Consider the case of point being equal to
1802 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1803 from the end of a short line to the beginning of a continued line
1804 of R2L text within L2R paragraph.
1805 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1806 composed characters.
5980d4c6 1807
f67cdd7f
EZ
1808 * bidi.c (bidi_check_type): Use xassert.
1809 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1810 members.
1811
bca633fb
EZ
18122011-08-23 Eli Zaretskii <eliz@gnu.org>
1813
1814 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1815 a character.
1816
4a5885a7
CY
18172011-08-23 Chong Yidong <cyd@stupidchicken.com>
1818
1819 * nsfont.m (ns_otf_to_script): Fix typo.
1820
0902a04e
KH
18212011-08-22 Kenichi Handa <handa@m17n.org>
1822
1823 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1824 extra slot even if the purpose is char-code-property-table.
1825
1a2e6670
EZ
18262011-08-23 Eli Zaretskii <eliz@gnu.org>
1827
8ddde651
EZ
1828 * xdisp.c (redisplay_window): When computing centering_position,
1829 account for the height of the header line. (Bug#8874)
1830
425cc014
EZ
1831 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1832 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1833 candidate is selected by the mouse, and that candidate has a
1834 composed character under the mouse.
1835
1a2e6670
EZ
1836 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1837 coordinates reported by pos-visible-in-window-p for a composed
1838 character in column zero.
1839
8b76d6f8
SM
18402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1841
1842 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1843
dac347dd
EZ
18442011-08-22 Eli Zaretskii <eliz@gnu.org>
1845
1846 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1847 consider it a hit if to_charpos is anywhere in the range of the
1848 composed buffer positions.
1849
e013fb34
CY
18502011-08-22 Chong Yidong <cyd@stupidchicken.com>
1851
1852 * image.c (gif_load): Don't assume that each subimage has the same
1853 dimensions as the base image. Handle disposal method that is
1854 "undefined" by the gif spec (Bug#9335).
1855
bd1ba3e8
CY
18562011-08-20 Chong Yidong <cyd@stupidchicken.com>
1857
1858 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1859 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1860
54a1215b
EZ
18612011-08-19 Eli Zaretskii <eliz@gnu.org>
1862
823564e5
EZ
1863 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1864 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1865 from an Org mode buffer to a Speedbar frame.
1866
54a1215b
EZ
1867 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1868 a composition, take its buffer position from IT->cmp_it.charpos.
1869 Fixes cursor positioning at the beginning of a line that begins
1870 with a composed character.
1871
9778ebcc
EZ
18722011-08-18 Eli Zaretskii <eliz@gnu.org>
1873
0be6ee06
EZ
1874 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1875 character bidirectional type, use STRONG_L instead. Fixes crashes
1876 in a buffer produced by `describe-categories'.
1877
9778ebcc
EZ
1878 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1879 members before the level stack, so they would be saved and
1880 restored when copying iterator state. Fixes incorrect reordering
1881 around TABs covered by display properties.
1882
156bffbe
AS
18832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1884
1885 * process.c (Fnetwork_interface_list): Correctly determine buffer
1886 size.
1887
72ad093b
CY
18882011-08-17 Chong Yidong <cyd@stupidchicken.com>
1889
1890 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1891 (internal_condition_case_2, internal_condition_case_n):
1892 Remove unnecessary aborts (Bug#9081).
72ad093b 1893
35774242
EZ
18942011-08-17 Eli Zaretskii <eliz@gnu.org>
1895
1896 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1897 has no `load' handler, try opening the file locally. (Bug#9311)
1898
db76dd85
KB
18992011-08-16 Ken Brown <kbrown@cornell.edu>
1900
1901 * gmalloc.c: Expand comment.
1902
b215eee5
EZ
19032011-08-16 Eli Zaretskii <eliz@gnu.org>
1904
1905 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1906 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1907
a4579d33
KB
19082011-08-16 Ken Brown <kbrown@cornell.edu>
1909
1910 Fix memory allocation problems in Cygwin build (Bug#9273).
1911
1912 * unexcw.c ( __malloc_initialized): Declare external variable.
1913 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1914
8b76d6f8
SM
1915 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1916 New variables.
a4579d33
KB
1917 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1918 dumped emacs.
1919 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1920 in the static heap.
1921 [CYGWIN] (special_realloc): New function.
1922 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1923 requests to realloc storage in the static heap.
1924
3ebec551
PE
19252011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1926
1927 * bidi.c (bidi_initialize): Remove unused local.
1928
9fd8be00
EZ
19292011-08-15 Eli Zaretskii <eliz@gnu.org>
1930
474a8465
EZ
1931 * biditype.h: File removed.
1932
1933 * bidimirror.h: File removed.
1934
1935 * deps.mk (bidi.o): Remove biditype.h and
1936 bidimirror.h.
1937
1938 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1939 bidimirror.h.
1940
1941 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1942
1943 * chartab.c: Improve commentary for the uniprop_table API.
1944
32413314
EZ
1945 * bidi.c (bidi_paragraph_init): Support zero value of
1946 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1947 (bidi_initialize): Use uniprop_table instead of including
1948 biditype.h and bidimirror.h.
32413314 1949
9fd8be00
EZ
1950 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1951 coordinates of the iterator when restoring from ppos_it.
1952 (Bug#9296)
1953
5cf2b69b
KH
19542011-08-14 Kenichi Handa <handa@m17n.org>
1955
1956 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1957 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1958
daf17d00
EZ
19592011-08-14 Eli Zaretskii <eliz@gnu.org>
1960
1961 * xdisp.c (move_it_in_display_line_to): Don't invoke
1962 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1963 ppos_it. Fixes vertical cursor motion when line beginning is
1964 covered by an image. (Bug#9296)
1965
08e3161a
JD
19662011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * nsterm.h (ns_run_ascript): Declare.
1969 (NSAPP_DATA2_RUNASSCRIPT): Define.
1970
1971 * nsfns.m (as_script, as_result, as_status): New static variables.
1972 (ns_run_ascript): New function.
5e617bc2 1973 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1974 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1975 the event loop. Get status from as_status (Bug#7276).
1976
1977 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1978 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1979 the event loop (Bug#7276).
1980
a3720aa2
AS
19812011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1982
1983 * gnutls.c (QCgnutls_bootprop_priority)
1984 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1985 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1986 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1987 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1988 (QCgnutls_bootprop_verify_hostname_error)
1989 (QCgnutls_bootprop_callbacks_verify): Rename from
1990 Qgnutls_bootprop_..., all uses changed.
1991
1992 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1993 uses changed.
1994
0a0d27fb
PE
19952011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1996
19d5c50c
PE
1997 * xfaces.c (Qframe_set_background_mode): Now static.
1998 * dispextern.h (Qframe_set_background_mode): Remove decl.
1999
0a0d27fb
PE
2000 * process.c (Fnetwork_interface_info): Declare local only if needed.
2001
377538cb
JD
20022011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2003
2004 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2005 (Fnetwork_interface_list): Allocate in increments of bytes instead
2006 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2007 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2008 sockaddr.
2009 (struct ifflag_def): notrailers is smart on OSX.
2010 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2011 Get hardware address with getifaddrs if available.
2012
08fff70c
EZ
20132011-08-12 Eli Zaretskii <eliz@gnu.org>
2014
2015 * xdisp.c (iterate_out_of_display_property): xassert that
2016 IT->position is set to within IT->object's boundaries. Break from
2017 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2018 when IT->position is set up wrongly due to some bug.
2019 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2020 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2021 entry. Force push_it to save on the stack the current
2022 buffer/string position, to be restored by pop_it. Fix flags in
2023 the iterator structure wrt the object coming from a display
2024 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2025 properties. (Bug#9284)
2026
7be1c708 20272011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2028
7be1c708
CY
2029 * fontset.c (fontset_get_font_group): Add proper type checks.
2030 (Bug#9172)
aac0c6e3 2031
7be1c708 20322011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2033
7be1c708
CY
2034 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2035 and LC_VERSION_MIN_MACOSX.
2036 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2037 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2038
97bb72a6
EZ
20392011-08-08 Eli Zaretskii <eliz@gnu.org>
2040
2041 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2042 no-display-properties-and-no-overlays under bidi display.
2043 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2044 properties and overlays.
97bb72a6 2045
d5617611
CY
20462011-08-08 Chong Yidong <cyd@stupidchicken.com>
2047
37e11a63
CY
2048 * editfns.c (Fset_time_zone_rule): Document relationship with the
2049 setenv function.
2050
d5617611
CY
2051 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2052 the font entity extracted from the cache (Bug#8109).
2053
58872834
CY
20542011-08-07 Chong Yidong <cyd@stupidchicken.com>
2055
2056 * composite.c (autocmp_chars): Don't reset point. That is done by
2057 restore_point_unwind (Bug#5984).
2058
75bfc667
JL
20592011-08-07 Juri Linkov <juri@jurta.org>
2060
2061 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2062 to show the arg `TIME' instead of `TIMEVAL'.
2063
d1410150
EZ
20642011-08-06 Eli Zaretskii <eliz@gnu.org>
2065
2066 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2067 display property strides EOL and includes a newline, as in
2068 longlines-mode. (Bug#9254)
75b771e4
EZ
2069 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2070 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2071
2072 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2073 is non-zero, even if the data buffer is NULL. Fixes a crash in
2074 vertical-motion with longlines-mode. (Bug#9254)
2075
35928349
EZ
20762011-08-05 Eli Zaretskii <eliz@gnu.org>
2077
ec7cc85b
EZ
2078 * bidi.c <bidi_cache_total_alloc>: Now static.
2079 (bidi_initialize): Initialize bidi_cache_total_alloc.
2080
8b76d6f8 2081 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2082 cache. (Bug#9221)
2083
2084 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2085 amount allocated this far in `bidi_cache_total_alloc'.
2086 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2087 non-zero, only free the data buffer without restoring the cache
2088 contents. All callers changed.
2089
2090 * dispextern.h (bidi_unshelve_cache): Update prototype.
2091
2092 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2093 (move_it_in_display_line, move_it_to)
2094 (move_it_vertically_backward, move_it_by_lines): Replace the call
2095 to xfree to an equivalent call to bidi_unshelve_cache.
2096 (move_it_in_display_line_to): Fix logic of returning
412b6358 2097 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2098
e2e2423b
EZ
20992011-08-05 Eli Zaretskii <eliz@gnu.org>
2100
2101 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2102 came from a string character with a `cursor' property. (Bug#9229)
2103
ae9e757a
JD
21042011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2105
2106 * Makefile.in (LIB_PTHREAD): New variable.
2107 (LIBES): Add LIB_PTHREAD (Bug#9216).
2108
2109 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2110 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2111
213bd7f2
AS
21122011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * regex.c (re_iswctype): Remove some redundant boolean
2115 conversions.
2116
99aaf75f
JD
21172011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2118
2119 * xterm.c (x_find_topmost_parent): New function.
2120 (x_set_frame_alpha): Find topmost parent window with
2121 x_find_topmost_parent and set the property there also (bug#9181).
2122 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2123
c74e9d86
PE
21242011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * callproc.c (Fcall_process): Avoid vfork clobbering
2127 the local vars buffer, coding_systems, current_dir.
2128
640c8776
SM
21292011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2130
2131 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2132
f26d0e4c
PE
21332011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2134
8a10d76c
PE
2135 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2136 so that it is not optimized away.
2137
f26d0e4c
PE
2138 * xdisp.c (compute_display_string_pos): Remove unused local.
2139
55439c61
EZ
21402011-08-02 Eli Zaretskii <eliz@gnu.org>
2141
2142 Fix slow cursor motion and scrolling in large buffers with
2143 selective display, like Org Mode buffers. (Bug#9218)
2144
2145 * dispextern.h (struct bidi_it): New member disp_prop_p.
2146
2147 * xdisp.c: Remove one-slot cache of display string positions.
2148 (compute_display_string_pos): Accept an additional argument
5e617bc2 2149 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2150 for a display string or property. If found, set DISP_PROP_P
2151 non-zero.
2152
2153 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2154 DISP_PROP_P, and pass it to compute_display_string_pos.
2155 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2156 non-zero. All callers of bidi_fetch_char changed.
2157
fb33fa43
SM
21582011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2159
2160 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2161
b099e063
DM
21622010-12-03 Don March <don@ohspite.net>
2163
2164 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2165 last character M-[char] is translated to ESC [char] (bug#7541).
2166
5cc7f7af
KH
21672011-08-02 Kenichi Handa <handa@m17n.org>
2168
d0fffa3f 2169 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2170
2171 * chartab.c (uniprop_table): Make it non-static.
2172
525d5e6e
EZ
21732011-08-01 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (forward_to_next_line_start): Accept additional argument
2176 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2177 on the newline.
2178 (reseat_at_next_visible_line_start): Use the bidi iterator state
2179 returned by forward_to_next_line_start to restore the state of
2180 it->bidi_it after backing up to previous newline. (Bug#9212)
2181
31011111
AS
21822011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2183
2184 * regex.c (re_comp): Protoize.
2185 (re_exec): Fix return type.
2186 (regexec): Fix type of `ret'. (Bug#9203)
2187
476371c4
PE
21882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2189
e5d76069
PE
2190 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2191 This is needed if max-image-size is a floating-point number.
2192
9a79b20c
AS
21932011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2194
2195 * print.c (print_object): Print empty symbol as ##.
2196
2197 * lread.c (read1): Read ## as empty symbol.
2198
d8c2fa78
AA
21992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2200
2201 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2202 setting frame foreground color (Bug#9175).
2203 (x_set_background_color): Likewise.
2204
ffe57a7a
AA
2205 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2206 contents (Bug#9176).
2207 (EmacsTooltip -init): Remove bezels and add shadows to
2208 tooltip windows.
2209
bf3492a5
AA
2210 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2211 or scroll bar (Bug#8470).
2212
d55e9c53
AA
2213 * nsfont.m (nsfont_open): Remove assignment to voffset and
2214 unnecessary vars hshink, expand, hd, full_height, min_height.
2215 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2216
2217 * nsterm.h (nsfont_info): Remove voffset field.
2218
d8c2fa78 22192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2220
2221 Implement strike-through and overline on NextStep (Bug#8863).
2222
2223 * nsfont.m (nsfont_open): Use underline position provided by font,
2224 instead of hard-coded value of 2.
2225 (nsfont_draw): Call ns_draw_text_decoration instead.
2226
2227 * nsterm.h: Add declaration for ns_draw_text_decoration.
2228
2229 * nsterm.m (ns_draw_text_decoration): New function for drawing
2230 underline, overline, and strike-through.
2231 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2232 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2233 accommodate underlining, etc.
4843aac3 2234
4cc60b9b
EZ
22352011-07-28 Eli Zaretskii <eliz@gnu.org>
2236
bc7ece87
EZ
2237 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2238 default.
4cc60b9b 2239
476371c4
PE
22402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2241
66606eea
PE
2242 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2243 Without this fix, if a signal arrives just after memory fills up,
2244 'malloc' might be invoked reentrantly.
2245
476371c4
PE
2246 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2247 In other words, assume that every image size is allowed, on non-X
2248 hosts. This assumption is probably wrong, but it lets Emacs compile.
2249
f3fcc40d
AS
22502011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2251
2252 * regex.c (re_iswctype): Convert return values to boolean.
2253
350c992f
EZ
22542011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2255
2256 * xdisp.c (compute_display_string_pos): Don't use cached display
2257 string position if the buffer had its restriction changed.
2258 (Bug#9184)
2259
5266b4bb
PE
22602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2263
2573a837 22642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2265
41f55ccd 2266 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2267
39e378da
PE
2268 * bidi.c: Integer size and overflow fixes.
2269 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2270 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2271 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2272 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2273 (bidi_find_other_level_edge):
2274 Use ptrdiff_t instead of EMACS_INT where either will do.
2275 This works better on 32-bit hosts configured --with-wide-int.
2276 (bidi_cache_ensure_space): Check for size-calculation overflow.
2277 Use % rather than repeated addition, for better worst-case speed.
2278 Don't set bidi_cache_size until after xrealloc returns, because it
2279 might not return.
2280 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2281 (bidi_cache_ensure_space): Also check that the bidi cache size
2282 does not exceed that of the largest Lisp string or buffer. See Eli
2283 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2284
5e927815
PE
2285 * alloc.c (__malloc_size_t): Remove.
2286 All uses replaced by size_t. See Andreas Schwab's note
2287 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2288
ca4aa935
PE
2289 * image.c: Improve checking for integer overflow.
2290 (check_image_size): Assume that f is nonnull, since
2291 it is always nonnull in practice. This is one less thing to
2292 worry about when checking for integer overflow later.
2293 (x_check_image_size): New function, which checks for integer
2294 overflow issues inside X.
2295 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2296 This removes the need for a memory_full check.
2297 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2298 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2299 (xbm_read_bitmap_data): Change locals back to 'int', since
2300 their values must fit in 'int'.
2301 (xpm_load_image, png_load, tiff_load):
2302 Invoke x_create_x_image_and_pixmap earlier,
2303 to avoid much needless work if the image is too large.
2304 (tiff_load): Treat overly large images as if
2305 x_create_x_image_and_pixmap failed, not as malloc failures.
2306 (gs_load): Use x_check_image_size.
2307
5f8f9cc2
PE
2308 * gtkutil.c: Omit integer casts.
2309 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2310 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2311
5adf60bc
PE
2312 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2313
c8907a93
PE
2314 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2315 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2316 would wrongly return t on a 64-bit host.
2317
e3c25c68
PE
2318 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2319 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2320 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2321 and therefore cause GCC to emit a bogus diagnostic in some cases.
2322
3f791afe
PE
2323 * image.c: Integer signedness and overflow and related fixes.
2324 This is not an exhaustive set of fixes, but it's time to
2325 record what I've got.
2326 (lookup_pixel_color, check_image_size): Remove redundant decls.
2327 (check_image_size): Don't assume that arbitrary EMACS_INT values
2328 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2329 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2330 (tiff_load, imagemagick_load_image):
2331 Check for overflow in size calculations.
2332 (x_create_x_image_and_pixmap): Remove unnecessary test for
2333 xmalloc returning NULL; that can't happen.
2334 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2335 (xpm_color_bucket): Use better integer hashing function.
2336 (xpm_cache_color): Don't possibly over-allocate memory.
2337 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2338 (gif_memory_source):
2339 Use ptrdiff_t, not int or size_t, to record sizes.
2340 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2341 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2342 either works, as we prefer signed integers.
2343 (tiff_read_from_memory, tiff_write_from_memory):
2344 Return tsize_t, not size_t, since that's what the TIFF API wants.
2345 (tiff_read_from_memory): Don't fail simply because the read would
2346 go past EOF; instead, return a short read.
2347 (tiff_load): Omit no-longer-needed casts.
2348 (Fimagemagick_types): Don't assume size fits into 'int'.
2349
3cc5a532
PE
2350 Improve hashing quality when configured --with-wide-int.
2351 * fns.c (hash_string): New function, taken from sxhash_string.
2352 Do not discard information about ASCII character case; this
2353 discarding is no longer needed.
2354 (sxhash-string): Use it. Change sig to match it. Caller changed.
2355 * lisp.h: Declare it.
2356 * lread.c (hash_string): Remove, since we now use fns.c's version.
2357 The fns.c version returns a wider integer if --with-wide-int is
2358 specified, so this should help the quality of the hashing a bit.
2359
b312a492
PE
2360 * emacs.c: Integer overflow minor fix.
2361 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2362 Define only if GNU_LINUX.
2363 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2364
dfd153ae
PE
2365 * dispnew.c: Integer signedness and overflow fixes.
2366 Remove unnecessary forward decls, that were a maintenance hassle.
2367 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2368 All uses changed.
2369 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2370 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2371 (prepare_desired_row, line_draw_cost):
2372 Use int, not unsigned, where either works.
2373 (save_current_matrix, restore_current_matrix):
2374 Use ptrdiff_t, not size_t, where either works.
2375 (init_display): Check for overflow more accurately, and without
2376 relying on undefined behavior.
2377
a81d11a3
PE
2378 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2379 Remove, replacing with the new symbols in lisp.h. All uses changed.
2380 * fileio.c (make_temp_name):
2381 * filelock.c (lock_file_1, lock_file):
2382 * xdisp.c (message_dolog):
2383 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2384 Use pMd etc. instead.
2385 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2386 replacing the pWIDE etc. symbols removed from editfns.c.
2387
3300e6fd
PE
2388 * keyboard.h (num_input_events): Now uintmax_t.
2389 This is (very slightly) less likely to mess up due to wraparound.
2390 All uses changed.
2391
fd05c7e9
PE
2392 * buffer.c: Integer signedness fixes.
2393 (alloc_buffer_text, enlarge_buffer_text):
2394 Use ptrdiff_t rather than size_t when either will do, as we prefer
2395 signed integers.
2396
903fe15d
PE
2397 * alloc.c: Integer signedness and overflow fixes.
2398 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2399 (__malloc_size_t): Default to size_t, not to int.
2400 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2401 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2402 Prefer ptrdiff_t to size_t when either would do, as we prefer
2403 signed integers.
2404 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2405 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2406 Now const. Initialize with values that are in range even if char
2407 is signed.
2408 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2409 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2410 These functions do the right thing with sizes > 2**32.
2411 (check_depth): Now ptrdiff_t, not int.
2412 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2413 Adjust to new way of storing sizes. Check for size overflow bugs
2414 in rest of code.
2415 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2416 slightly wrong anyway, as it missed one instance of
2417 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2418 (refill_memory_reserve): Omit needless cast to size_t.
2419 (mark_object_loop_halt): Mark as externally visible.
2420
ac82cc6a
PE
2421 * xselect.c: Integer signedness and overflow fixes.
2422 (Fx_register_dnd_atom, x_handle_dnd_message):
2423 Use ptrdiff_t, not size_t, since we prefer signed.
2424 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2425 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2426 x_dnd_atoms_size and x_dnd_atoms_length.
2427
c2d1e36d
PE
2428 * doprnt.c: Prefer signed to unsigned when either works.
2429 * eval.c (verror):
2430 * doprnt.c (doprnt):
2431 * lisp.h (doprnt):
2432 * xdisp.c (vmessage):
2433 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2434 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2435 prefer signed arithmetic to avoid comparison confusion.
2436 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2437 but is a bit tricky.
2438
0e926e56
PE
2439 Assume freestanding C89 headers, string.h, stdlib.h.
2440 * data.c, doprnt.c, floatfns.c, print.c:
2441 Include float.h unconditionally.
2442 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2443 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2444 * regex.c: Likewise for stddef.h, string.h.
2445 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2446 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2447 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2448 (STDC_HEADERS): Remove obsolete defines.
2449 * sysdep.c: Include limits.h unconditionally.
2450
9cfdb3ec
PE
2451 Assume support for memcmp, memcpy, memmove, memset.
2452 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2453 * regex.c (memcmp, memcpy):
2454 Remove; we assume C89 now.
2455
2456 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2457 (__malloc_safe_bcopy): Remove; no longer needed.
2458
cf950e6b 2459 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2460 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2461 well either way, and we prefer signed to unsigned.
2462
dbf38e02
LMI
24632011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2464
2465 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2466 closes the connection while we're reading (bug#9182).
2467
d6f0886c 24682011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2469
d6f0886c
JD
2470 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2471 are specified (Bug#9168).
24e0f6b1 2472
2eb1f9e6
PE
24732011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2476 Found by GCC static checking and --with-wide-int on a 32-bit host.
2477
22381272 24782011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2479
2480 * xdisp.c (compute_display_string_pos): Fix logic of caching
2481 previous display string position. Initialize cached_prev_pos to
2482 -1. Fixes slow-down at the beginning of a buffer.
2483
f25e39b4
EZ
24842011-07-24 Eli Zaretskii <eliz@gnu.org>
2485
2486 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2487 for attrs[LFACE_FONTSET_INDEX].
2488
04c4b52e
PE
24892011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 * xml.c (parse_region): Remove unused local
2492 that was recently introduced.
2493
c1734fbd
EZ
24942011-07-23 Eli Zaretskii <eliz@gnu.org>
2495
be18c5a5
EZ
2496 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2497 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2498
c1734fbd
EZ
2499 * xdisp.c (move_it_in_display_line_to): Record the best matching
2500 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2501 exit if none of the characters scanned was an exact match.
2502 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2503 when exact match is impossible due to invisible text, and the
2504 lines are truncated.
2505
a258d627
JD
25062011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2507
2508 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2509 for OSX >= 10.7.
2510
b6d5a689
EZ
25112011-07-22 Eli Zaretskii <eliz@gnu.org>
2512
0f74f785
EZ
2513 Fix a significant slow-down of cursor motion with C-n, C-p,
2514 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2515 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2516 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2517 (next_element_from_buffer): Call compute_stop_pos_backwards to
2518 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2519 base_level_stop.
2520 (reseat): Don't look for prev_stop, as that could mean a very long
2521 run.
2522 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2523 <cached_disp_overlay_modiff>: Cache for last found display string
2524 position.
551918c1 2525 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2526 about the same buffer in the same area of character positions, and
2527 the buffer wasn't changed since the time the display string
2528 position was cached.
551918c1 2529
b2d0c91a
EZ
25302011-07-22 Eli Zaretskii <eliz@gnu.org>
2531
2532 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2533 is an integer, which is important for empty lines. (Bug#9149)
2534
043604ee
CY
25352011-07-22 Chong Yidong <cyd@stupidchicken.com>
2536
2537 * frame.c (Fmodify_frame_parameters): In tty case, update the
2538 default face if necessary (Bug#4238).
2539
da4adb04
CY
25402011-07-21 Chong Yidong <cyd@stupidchicken.com>
2541
2542 * editfns.c (Fstring_to_char): No need to explain what a character
2543 is in the docstring (Bug#6576).
2544
9abd0532
LMI
25452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2546
2547 * xml.c (parse_region): Make sure we always return a tree.
2548
36881d16
HK
25492011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2550
2551 * xml.c (parse_region): If a document contains only comments,
2552 return that, too.
2553
1e98674d
LMI
25542011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2555
2556 * xml.c (make_dom): Return comments, too.
2557
590bd467
PE
25582011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2559
2560 Port to OpenBSD.
2561 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2562 and the surrounding thread.
2563 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2564 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2565 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2566 timer goes off.
2567 * s/openbsd.h (BROKEN_SIGIO): Define.
2568 * unexelf.c (unexec) [__OpenBSD__]:
2569 Don't update the .mdebug section of the Alpha COFF symbol table.
2570
f41628b2
LMI
25712011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2572
2573 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2574 (bug#8460).
2575
b59b67c5
PE
25762011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2577
15e3a074
PE
2578 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2579 This fixes some race conditions on the permissions of any newly
2580 created file.
2581
41bed37d
PE
2582 * alloc.c (valid_pointer_p): Use pipe, not open.
2583 This fixes some permissions issues when debugging.
2584
b59b67c5
PE
2585 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2586 If fchown fails to set both uid and gid, try to set just gid,
2587 as that is sometimes allowed. Adjust the file's mode to eliminate
2588 setuid or setgid bits that are inappropriate if fchown fails.
2589
925a6be7
SM
25902011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2591
2592 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2593 to compare Lisp_Objects.
2594 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2595 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2596 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2597
52968808
AS
25982011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2599
0a6a104b
AS
2600 * lread.c (read_integer): Unread even EOF character.
2601 (read1): Likewise. Properly record start position of symbol.
2602
52968808
AS
2603 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2604 symbol character follows.
2605
9e381cdd
PE
26062011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2607
2608 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2609 This works around a problem with the previous change to Fcopy_file.
2610 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2611 and without this change, GCC might complain about discarding
2612 fchown's return value.
2613
b5641435
JB
26142011-07-16 Juanma Barranquero <lekktu@gmail.com>
2615
2616 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2617
a8031457
PE
26182011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2619
2620 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2621
dd889327
LMI
26222011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2623
750c33f7
LMI
2624 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2625 it's used from the C level.
2626
dd889327
LMI
2627 * process.c: Use the same condition for POLL_FOR_INPUT in both
2628 keyboard.c and process.c (bug#1858).
2629
87e86684
LM
26302011-07-09 Lawrence Mitchell <wence@gmx.li>
2631
2632 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2633 (Fgnutls_boot): Use it.
2634
64348f40
AS
26352011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2636
2637 * doc.c (Fsubstitute_command_keys): Revert last change.
2638
1d698799
LMI
26392011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2640
f863868c
LMI
2641 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2642 quotes the next character, and doesn't affect other longer
2643 sequences (bug#8935).
2644
1d698799
LMI
2645 * lread.c (syms_of_lread): Clarify that is isn't only
2646 `eval-buffer' and `eval-defun' that's affected by
2647 `lexical-binding' (bug#8460).
2648
aa4b6df6
EZ
26492011-07-15 Eli Zaretskii <eliz@gnu.org>
2650
2651 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2652 bidi redisplay when a line includes both an image and is
2653 truncated.
2654
5d856da6
PE
26552011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2656
ad6042bb
PE
2657 Fix minor problems found by static checking.
2658 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2659 (elsz): Now a signed constant, not a size_t var. We prefer signed
2660 types to unsigned, to avoid integer comparison confusion. Without
2661 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2662 "cannot optimize loop, the loop counter may overflow", a symptom
2663 of the confusion.
f00bbb22 2664 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2665 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2666
6468f31c
LMI
26672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2668
49080b10
LMI
2669 * search.c (Fre_search_backward): Mention `case-fold-search' in
2670 all the re_search_* functions (bug#8138).
2671
6468f31c
LMI
2672 * keyboard.c (Fopen_dribble_file): Document when the file is
2673 closed (bug#8056).
2674
c965adc5
EZ
26752011-07-14 Eli Zaretskii <eliz@gnu.org>
2676
df9733bf
EZ
2677 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2678 bidi_cache_idx.
2679
0bb23927
EZ
2680 Support bidi reordering of display and overlay strings.
2681 * xdisp.c (compute_display_string_pos)
2682 (compute_display_string_end): Accept additional argument STRING.
2683 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2684 (reseat_to_string): Initialize bidi_it->string.s and
2685 bidi_it->string.schars.
2686 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2687 NULL (avoids a crash in bidi_paragraph_init).
2688 Initialize itb.string.lstring.
0bb23927
EZ
2689 (init_iterator): Call bidi_init_it only of a valid
2690 buffer position was specified. Initialize paragraph_embedding to
2691 L2R.
2692 (reseat_to_string): Initialize the bidi iterator.
2693 (display_string): If we need to ignore text properties of
2694 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2695 original value of -1 will not work with bidi.)
2696 (compute_display_string_pos): First arg is now struct
2697 `text_pos *'; all callers changed. Support display properties on
2698 Lisp strings.
2699 (compute_display_string_end): Support display properties on Lisp
2700 strings.
2701 (init_iterator, reseat_1, reseat_to_string): Initialize the
2702 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2703 when iterating on a string not from display properties).
640c8776
SM
2704 (compute_display_string_pos, compute_display_string_end):
2705 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2706 arrow keys.
2707 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2708 base_level_stop; instead, set base_level_stop to BEGV.
2709 Fixes crashes in vertical-motion.
0bb23927
EZ
2710 (next_element_from_buffer): Improve commentary for when
2711 the iterator is before prev_stop.
2712 (init_iterator): Initialize bidi_p from the default value of
2713 bidi-display-reordering, not from buffer-local value. Use the
2714 buffer-local value only if initializing for buffer iteration.
2715 (handle_invisible_prop): Support invisible properties on strings
2716 that are being bidi-reordered.
2717 (set_iterator_to_next): Support bidi reordering of C strings and
2718 Lisp strings.
2719 (next_element_from_string): Support bidi reordering of Lisp
2720 strings.
2721 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2722 (display_string): Support display of R2L glyph rows.
2723 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2724 (init_iterator): Don't initialize it->bidi_p for strings
2725 here.
2726 (reseat_to_string): Initialize it->bidi_p for strings here.
2727 (next_element_from_string, next_element_from_c_string)
2728 (next_element_from_buffer): Add xassert's for correspondence
2729 between IT's object being iterated and it->bidi_it.string
2730 structure.
2731 (face_before_or_after_it_pos): Support bidi iteration.
2732 (next_element_from_c_string): Handle the case of the first string
2733 character that is not the first one in the visual order.
2734 (get_visually_first_element): New function, refactored from common
2735 parts of next_element_from_buffer, next_element_from_string, and
2736 next_element_from_c_string.
2737 (tool_bar_lines_needed, redisplay_tool_bar)
2738 (display_menu_bar): Force left-to-right direction. Add a FIXME
2739 comment for making that be controlled by a user option.
2740 (push_it, pop_it): Save and restore the state of the
2741 bidi iterator. Save and restore the bidi_p flag.
2742 (pop_it): Iterate out of display property for string iteration as
2743 well.
2744 (iterate_out_of_display_property): Support iteration over strings.
2745 (handle_single_display_spec): Set up it->bidi_it for iteration
2746 over a display string, and call bidi_init_it.
2747 (handle_single_display_spec, next_overlay_string)
2748 (get_overlay_strings_1, push_display_prop): Set up the bidi
2749 iterator for displaying display or overlay strings.
2750 (forward_to_next_line_start): Don't use the shortcut if
2751 bidi-iterating.
2752 (back_to_previous_visible_line_start): If handle_display_prop
2753 pushed the iterator stack, restore the internal state of the bidi
2754 iterator by calling bidi_pop_it same number of times.
2755 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2756 and we are bidi-iterating, don't decrement the iterator position;
2757 instead, set the first_elt flag in the bidi iterator, to produce
2758 the same effect.
2759 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2760 (push_display_prop): xassert that we are iterating a buffer.
2761 (push_it, pop_it): Save and restore paragraph_embedding member.
2762 (handle_single_display_spec, next_overlay_string)
2763 (get_overlay_strings_1, reseat_1, reseat_to_string)
2764 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2765 correctly. Don't assume unibyte strings are not bidi-reordered.
2766 (compute_display_string_pos)
2767 (compute_display_string_end): Fix handling the case of C string.
2768 (push_it, pop_it): Save and restore from_disp_prop_p.
2769 (handle_single_display_spec, push_display_prop): Set the
2770 from_disp_prop_p flag.
2771 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2772 (pop_it): Call iterate_out_of_display_property only if we are
2773 popping after iteration over a string that came from a display
2774 property. Fix a typo in popping stretch info. Add an assertion
2775 for verifying that the iterator position is in sync with the bidi
2776 iterator.
2777 (handle_single_display_spec, get_overlay_strings_1)
2778 (push_display_prop): Fix initialization of paragraph direction for
2779 string when that of the parent object is not yet determined.
2780 (reseat_1): Call bidi_init_it to resync the bidi
2781 iterator with IT's position. (Bug#7616)
2782 (find_row_edges): If ROW->start.pos gives position
2783 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2784 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2785 Reset the from_disp_prop_p flag.
2786 (SAVE_IT, RESTORE_IT): New macros.
2787 (pos_visible_p, face_before_or_after_it_pos)
2788 (back_to_previous_visible_line_start)
2789 (move_it_in_display_line_to, move_it_in_display_line)
2790 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2791 (try_scrolling, redisplay_window, display_line): Use them when
2792 saving a temporary copy of the iterator and restoring it back.
2793 (back_to_previous_visible_line_start, reseat_1)
2794 (init_iterator): Empty the bidi cache "stack".
2795 (move_it_in_display_line_to): If iterator ended up at
2796 EOL, but we never saw any buffer positions smaller than
2797 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2798 motion in bidi-reordered lines.
2799 (move_it_in_display_line_to): Record prev_method and prev_pos
2800 immediately before the call to set_iterator_to_next. Fixes cursor
2801 motion in bidi-reordered lines with stretch glyphs and strings
2802 displayed in margins. (Bug#8133) (Bug#8867)
2803 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2804 TO_CHARPOS.
640c8776
SM
2805 (pos_visible_p): Support positions in bidi-reordered lines.
2806 Save and restore bidi cache.
0bb23927
EZ
2807
2808 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2809 (bidi_paragraph_info): Delete unused struct.
2810 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2811 (bidi_cache_start): New variable.
2812 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2813 to zero.
2814 (bidi_cache_fetch_state, bidi_cache_search)
2815 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2816 (bidi_cache_find, bidi_peek_at_next_level)
2817 (bidi_level_of_next_char, bidi_find_other_level_edge)
2818 (bidi_move_to_visually_next): Compare cache index with
2819 bidi_cache_start rather than with zero.
2820 (bidi_fetch_char): Accept new argument STRING; all callers
2821 changed. Support iteration over a string. Support strings with
2822 display properties. Support unibyte strings. Fix the type of
2823 `len' according to what STRING_CHAR_AND_LENGTH expects.
2824 (bidi_paragraph_init, bidi_resolve_explicit_1)
2825 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2826 (bidi_level_of_next_char, bidi_move_to_visually_next):
2827 Support iteration over a string.
0bb23927
EZ
2828 (bidi_set_sor_type, bidi_resolve_explicit_1)
2829 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2830 can now be zero (for strings); special values 0 and -1 were
2831 changed to -1 and -2, respectively.
2832 (bidi_char_at_pos): New function.
2833 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2834 Call it instead of FETCH_MULTIBYTE_CHAR.
2835 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2836 initialized to valid values.
2837 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2838 values.
2839 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2840 the test for valid cached positions. Fix the logic for looking up
2841 the sentinel state in the cache. GCPRO the Lisp string we are
2842 iterating.
2843 (bidi_push_it, bidi_pop_it): New functions.
2844 (bidi_initialize): Initialize the bidi cache start stack pointer.
2845 (bidi_cache_ensure_space): New function, refactored from part of
2846 bidi_cache_iterator_state. Don't assume the required size is just
2847 one BIDI_CACHE_CHUNK away.
2848 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2849 (bidi_count_bytes, bidi_char_at_pos): New functions.
2850 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2851 always valid if bidi_cache_idx is valid.
2852 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2853 is valid if it's going to be used.
2854 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2855 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2856 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2857 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2858 (bidi_find_other_level_edge, bidi_cache_start_stack):
2859 All variables related to cache indices are now EMACS_INT.
c965adc5 2860
0bb23927
EZ
2861 * dispextern.h (struct bidi_string_data): New structure.
2862 (struct bidi_it): New member `string'. Make flag members be 1-bit
2863 fields, and put them last in the struct.
640c8776
SM
2864 (compute_display_string_pos, compute_display_string_end):
2865 Update prototypes.
0bb23927
EZ
2866 (bidi_push_it, bidi_pop_it): Add prototypes.
2867 (struct iterator_stack_entry): New members bidi_p,
2868 paragraph_embedding, and from_disp_prop_p.
2869 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2870 (bidi_shelve_cache, bidi_unshelve_cache):
2871 Declare prototypes.
0bb23927
EZ
2872
2873 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2874 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2875 and vector-like objects.
2876
2877 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2878 cache around display iteration.
2879
2880 * window.c (Fwindow_end, window_scroll_pixel_based)
2881 (displayed_window_lines, Frecenter): Save and restore the bidi
2882 cache around display iteration.
2883
3bbd2265
LMI
28842011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2885
2886 * editfns.c (Fdelete_region): Clarify the use of the named
2887 parameters (bug#6788).
2888
adc47434
MR
28892011-07-14 Martin Rudalics <rudalics@gmx.at>
2890
2891 * indent.c (Fvertical_motion): Set and restore w->pointm when
2892 saving and restoring the window's buffer (Bug#9006).
2893
837c31f8
LMI
28942011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2895
2896 * editfns.c (Fstring_to_char): Clarify just what is returned
2897 (bug#6576). Text by Eli Zaretskii.
2898
ac389d0c
JB
28992011-07-13 Juanma Barranquero <lekktu@gmail.com>
2900
2901 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2902
0be0ce47
EZ
29032011-07-13 Eli Zaretskii <eliz@gnu.org>
2904
2905 * buffer.c (mmap_find): Fix a typo.
2906
cd18e7e3
JB
29072011-07-13 Johan Bockgård <bojohan@gnu.org>
2908
2909 Fix execution of x selection hooks.
2910 * xselect.c (Qx_lost_selection_functions)
2911 (Qx_sent_selection_functions): New vars.
2912 (syms_of_xselect): DEFSYM them.
2913 (x_handle_selection_request): Pass Qx_sent_selection_functions
2914 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2915 (x_handle_selection_clear,x_clear_frame_selections):
2916 Pass Qx_lost_selection_functions rather than
2917 Vx_lost_selection_functions to Frun_hook_with_args.
2918
47ea7f44
PE
29192011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2920
ac389d0c 2921 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2922 The old code sometimes used this field without initializing it.
2923
47ea7f44
PE
2924 * alloc.c (gc_sweep): Don't read past end of array.
2925 In theory, the old code could also have corrupted Emacs internals,
2926 though it'd be very unlikely.
2927
bc985c87
AS
29282011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2929
2930 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2931 argument. (Bug#4026)
bc985c87 2932
0cf34688
LMI
29332011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2934
b3dadd76
LMI
2935 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2936 key" (bug#4257).
2937
0cf34688
LMI
2938 * window.c (Fset_window_start): Doc fix (bug#4199).
2939 (Fset_window_hscroll): Ditto.
2940
270768cd
PE
29412011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2942
077e3dda 2943 Fix minor new problems caught by GCC 4.6.1.
270768cd 2944 * term.c (init_tty): Remove unused local.
490011a6 2945 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2946 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2947 not used otherwise.
270768cd 2948
b1f58454
CY
29492011-07-12 Chong Yidong <cyd@stupidchicken.com>
2950
2951 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2952
22b9578d
LMI
29532011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2954
6e70ab07
LMI
2955 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2956 are the mini-buffer and the echo area (bug#3320).
2957
22b9578d
LMI
2958 * term.c (init_tty): Remove support for supdup, c10 and perq
2959 terminals, which are no longer supported (bug#1482).
2960
8974cc9f
JB
29612011-07-10 Johan Bockgård <bojohan@gnu.org>
2962
2963 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2964
a560d974
JD
29652011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2966
2967 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2968 for non-popups (Bug#3642).
2969
1dae0f0a
AS
29702011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2971
268c2c36 2972 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2973 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2974 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2975 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2976 * data.c (fmod): Likewise.
2977 * dispnew.c (swap_glyphs_in_rows): Likewise.
2978 * emacs.c (memory_warning_signal): Likewise.
2979 * floatfns.c (float_error): Likewise.
2980 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2981 (otf_open, font_otf_capability, generate_otf_features)
2982 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2983 Likewise.
2984 * image.c (pbm_read_file): Likewise.
2985 * indent.c (string_display_width): Likewise.
2986 * intervals.c (check_for_interval, search_for_interval)
2987 (inc_interval_count, count_intervals, root_interval)
2988 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2989 * lread.c (defalias): Likewise.
268c2c36 2990 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2991 * regex.c (set_image_of_range_1, set_image_of_range)
2992 (regex_grow_registers): Likewise.
2993 * sysdep.c (strerror): Likewise.
2994 * termcap.c (valid_filename_p, tprint, main): Likewise.
2995 * tparam.c (main): Likewise.
2996 * unexhp9k800.c (run_time_remap, save_data_space)
2997 (update_file_ptrs, read_header, write_header, calculate_checksum)
2998 (copy_file, copy_rest, display_header): Likewise.
2999 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3000 Likewise.
3001 * xdisp.c (check_it): Likewise.
3002 * xfaces.c (register_color, unregister_color, unregister_colors):
3003 Likewise.
3004 * xfns.c (print_fontset_result): Likewise.
3005 * xrdb.c (member, fatal, main): Likewise.
3006
99033785
PE
30072011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 Fix minor problems found by static checking (Bug#9031).
3010 * chartab.c (char_table_set_range, map_sub_char_table):
3011 Remove unused locals.
3012 (uniprop_table): Now static.
3013 * composite.c (_work_char): Remove unused static var.
3014
9cb2ac56
JB
30152011-07-09 Juanma Barranquero <lekktu@gmail.com>
3016
3017 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3018
f25661f0
JD
30192011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3020
3021 * gtkutil.c (qttip_cb): Remove code without function.
3022
8278c4fe
EZ
30232011-07-09 Eli Zaretskii <eliz@gnu.org>
3024
3025 * w32.c (pthread_sigmask): New stub.
3026
1692ae2d 30272011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3028
8a6ebd58 3029 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3030 sigprocmask is portable only for single-threaded applications, and
3031 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3032 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3033 (LIBES): Use it.
3034 * callproc.c (Fcall_process):
3035 * process.c (create_process):
3036 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3037 Use pthread_sigmask, not sigprocmask.
123403e4 3038
1b854618
JD
30392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3040
3041 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3042 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3043 wrong (Bug#8591).
3044
3fe4b549
JD
30452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3046
0ce7e563
JD
3047 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3048 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3049 (xg_hide_tooltip): Fix comment.
3050
3fe4b549
JD
3051 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3052 in registerServicesMenuSendTypes.
3053 (validRequestorForSendType): Don't check ns_return_types.
3054
3055 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3056 ns_return_type.
3057
5df75e47
JR
30582011-07-08 Jason Rumney <jasonr@gnu.org>
3059
3060 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3061 frame struct members of non-existent frames (Bug#6284).
3062
699c10bd
JD
30632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3064
4393663b
JD
3065 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3066 variable firstTime not needed on OSX >= 10.6.
3067 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3068 >= 10.5. Use setKnobProportion, setDoubleValue.
3069
3070 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3071 (MAC_OS_X_VERSION_10_5): Define if not defined.
3072 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3073 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3074 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3075
3076 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3077 cString and lossyCString on OSX >= 10.4
3078
3079 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3080 sizeToFit on OSX >= 10.2.
3081
3082 * nsimage.m (allocInitFromFile): Don't use deprecated method
3083 bestRepresentationForDevice on OSX >= 10.6.
3084
3085 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3086 to avoid warning.
3087
3088 * emacs.c: Declare unexec_init_emacs_zone.
3089
a63e0781
JD
3090 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3091
699c10bd
JD
3092 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3093
3094 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3095 on svcsMenu (Bug#8842).
3096
3097 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3098 ns_return_types.
3099 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3100
3101 * nsterm.m (QUTF8_STRING): Declare.
3102 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3103 (validRequestorForSendType): Return type is (id).
3104 Change indexOfObjectIdenticalTo to indexOfObject.
3105 Check if we have local selection before returning self (Bug#8842).
3106 (writeSelectionToPasteboard): Put local selection into paste board
3107 if we have a local selection (Bug#8842).
3108 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3109
3110 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3111 (ns_get_local_selection): Declare.
3112
54e10184
LMI
31132011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3114
9888ff71
LMI
3115 * keymap.c (describe_map_tree): Don't insert a double newline at
3116 the end of the buffer (bug#1169) and return whether we inserted
3117 something.
3118
54e10184
LMI
3119 * callint.c (Fcall_interactively): Change "reading args" to
3120 "providing args" to try to clarify what it does (bug#1010).
3121
15fa4783
KH
31222011-07-07 Kenichi Handa <handa@m17n.org>
3123
3124 * composite.c (composition_compute_stop_pos): Ignore a static
3125 composition starting before CHARPOS (Bug#8915).
3126
3127 * xdisp.c (handle_composition_prop): Likewise.
3128
a8815b00
EZ
31292011-07-07 Eli Zaretskii <eliz@gnu.org>
3130
3131 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3132 (Bug#9015)
3133
ef7b981d 31342011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3135
3136 * character.h (unicode_category_t): New enum type.
3137
3138 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3139 (Qchar_code_property_table): New variable.
3140 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3141 (UNIPROP_COMPRESSED_FORM_P): New macros.
3142 (char_table_ascii): Uncompress the compressed values.
3143 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3144 Uncompress the compressed values.
ac389d0c 3145 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3146 (char_table_ref_and_range): Uncompress the compressed values.
3147 (sub_char_table_set): New arg is_uniprop. Callers changed.
3148 Uncompress the compressed values.
3149 (sub_char_table_set_range): Args changed. Callers changed.
3150 (char_table_set_range): Adjuted for the above change.
3151 (map_sub_char_table): Delete args default_val and parent. Add arg
3152 top. Give decoded values to a Lisp function.
640c8776 3153 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3154 values to a Lisp function. Gcpro more variables.
3155 (uniprop_table_uncompress)
3156 (uniprop_decode_value_run_length): New functions.
3157 (uniprop_decoder, uniprop_decoder_count): New variables.
3158 (uniprop_get_decoder, uniprop_encode_value_character)
3159 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3160 New functions.
3161 (uniprop_encoder, uniprop_encoder_count): New variables.
3162 (uniprop_get_encoder, uniprop_table)
3163 (Funicode_property_table_internal, Fget_unicode_property_internal)
3164 (Fput_unicode_property_internal): New functions.
3165 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3166 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3167 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3168 char-code-property-alist.
3169
640c8776 3170 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3171 Vunicode_category_table.
3172
640c8776 3173 * font.c (font_range): Adjust for the change of
c805dec0
KH
3174 Vunicode_category_table.
3175
76b397fb
DN
31762011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3177
3178 * m/iris4d.h: Remove file, move contents ...
3179 * s/irix6-5.h: ... here.
3180
22b4128e
PE
31812011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3182
3183 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3184 * alloc.c (mark_buffer):
3185 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3186 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3187 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3188 This isn't true in general, and it's particularly not true
3189 if Emacs is configured with --with-wide-int.
3190 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3191 New macros, used in the buffer.c change.
3192
869795d6
JD
31932011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3194
3195 * xsettings.c: Use both GConf and GSettings if both are available.
3196 (store_config_changed_event): Add comment.
3197 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3198 (store_tool_bar_style_changed): New functions.
5e617bc2 3199 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3200 (struct xsettings): Move font inside HAVE_XFT.
3201 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3202 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3203 Move inside HAVE_XFT.
640c8776 3204 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3205 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3206 also.
3207 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3208 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3209 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3210 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3211 (parse_settings): Move check for font inside HAVE_XFT.
3212 (read_settings, apply_xft_settings): Add comment.
3213 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3214 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3215 call store_font_name_changed.
3216 (xft_settings_event): Add comment.
3217 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3218 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3219 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3220 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3221 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3222 (xsettings_get_system_font, xsettings_get_system_normal_font):
3223 Add comment.
869795d6 3224
d8ed26bd
PE
32252011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Random fixes. E.g., (random) never returned negative values.
3228 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3229 subseconds part to the entropy, as that's a bit more random.
3230 Prefer signed to unsigned, since the signedness doesn't matter and
3231 in general we prefer signed. When given a limit, use a
3232 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3233 latter isn't right if USE_2_TAGS_FOR_INTS.
3234 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3235 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3236
cabf1cac
SM
32372011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3238
3239 * textprop.c (text_property_stickiness):
3240 Obey Vtext_property_default_nonsticky.
3241 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3242 * w32fns.c (syms_of_w32fns):
3243 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3244
6e9b2be9
PE
32452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3246
3247 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3248 This is more efficient than Ffile_directory_p and avoids a minor race.
3249
90186c68
LMI
32502011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3251
7c301272
LMI
3252 * buffer.c (Foverlay_put): Say what the return value is
3253 (bug#7835).
3254
c4f2d8d4
LMI
3255 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3256 is a directory before asking whether to use the file name
3257 (bug#7564).
ad637907
LMI
3258 (barf_or_query_if_file_exists): Make the "File is a directory"
3259 error be more correct.
c4f2d8d4 3260
90186c68
LMI
3261 * fns.c (Frequire): Remove the mention of the .gz files, since
3262 that's installation-specific, but keep the mention of
3263 `get-load-suffixes'.
3264
da64016e
PE
32652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3268 Report string overflow if the output is too long.
3269
7d47b580
JB
32702011-07-04 Juanma Barranquero <lekktu@gmail.com>
3271
a555cb87
JB
3272 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3273 (syms_of_gnutls): Remove duplicate DEFSYM for
3274 Qgnutls_bootprop_verify_hostname_error, an error for
3275 Qgnutls_bootprop_verify_error (which is no longer used).
3276
7d47b580
JB
3277 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3278 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3279 Also (re)move comments that are misplaced or no longer relevant.
3280
1e49bfab
LMI
32812011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3282
3283 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3284
1485f4c0
CY
32852011-07-03 Chong Yidong <cyd@stupidchicken.com>
3286
3287 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3288 and background color parameters if they have been changed.
3289
a9ab721e
LMI
32902011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3291
3292 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3293
cf7cff57
PE
32942011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3295
2e13213d
PE
3296 * xsettings.c (SYSTEM_FONT): Define only when used.
3297 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3298
cf7cff57
PE
3299 * keymap.c (access_keymap_1): Now static.
3300
7a8e04f7
CY
33012011-07-02 Chong Yidong <cyd@stupidchicken.com>
3302
3303 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3304 leave any prefix arg for the up event (Bug#1586).
3305
61352f62
LMI
33062011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3307
69bb1ef7
LMI
3308 * lread.c (syms_of_lread): Mention single symbols defined by
3309 `defvar' or `defconst' (bug#7154).
3310
61352f62 3311 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3312 (Frequire): Mention get-load-suffixes.
61352f62 3313
28545e04
MR
33142011-07-02 Martin Rudalics <rudalics@gmx.at>
3315
3316 * window.h (window): Remove clone_number slot.
3317 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3318 Remove.
3319 (make_parent_window, make_window, saved_window)
3320 (Fset_window_configuration, save_window_save): Don't deal with
3321 clone numbers.
3322 * buffer.c (Qclone_number): Remove declaration.
3323 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3324
3349e122
SM
33252011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3326
3327 Add multiple inheritance to keymaps.
3328 * keymap.c (Fmake_composed_keymap): New function.
3329 (Fset_keymap_parent): Simplify.
3330 (fix_submap_inheritance): Remove.
3331 (access_keymap_1): New function extracted from access_keymap to handle
3332 embedded parents and handle lists of maps.
3333 (access_keymap): Use it.
3334 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3335 (Fcopy_keymap): Handle embedded parents.
3336 (Fcommand_remapping, define_as_prefix): Simplify.
3337 (Fkey_binding): Simplify.
3338 (syms_of_keymap): Move minibuffer-local-completion-map,
3339 minibuffer-local-filename-completion-map,
3340 minibuffer-local-must-match-map, and
3341 minibuffer-local-filename-must-match-map to Elisp.
3342 (syms_of_keymap): Defsubr make-composed-keymap.
3343 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3344 (parse_menu_item): Trivial simplification.
3345
3279eb87
GM
33462011-07-01 Glenn Morris <rgm@gnu.org>
3347
3348 * Makefile.in (SETTINGS_LIBS): Fix typo.
3349
4550efdf
KI
33502011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3351
3352 * coding.c (Fencode_coding_string): Record the last coding system
3353 used, as the function doc string says (bug#8738).
3354
0949d2b6
JD
33552011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3356
3357 * xsettings.c (store_monospaced_changed): Take new font as arg and
3358 check for change against current_mono_font.
3359 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3360 (emacs_settings_constructor, emacs_settings_get_property)
3361 (emacs_settings_set_property, emacs_settings_class_init)
3362 (emacs_settings_init, gsettings_obj): Remove.
3363 (something_changedCB): New function for HAVE_GSETTINGS.
3364 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3365 with value as argument.
3366 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3367 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3368 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3369 "changed".
3370
3371 * xgselect.c: Add defined (HAVE_GSETTINGS).
3372 (xgselect_initialize): Ditto.
3373
3374 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3375 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3376 xg_select.
3377
bbc6b304
PE
33782011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3379
3380 * eval.c (struct backtrace): Simplify and port the data structure.
3381 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3382 signed bit field, as this assumption is not portable and it makes
3383 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3384 "char debug_on_exit : 1" as this is not portable either; instead,
3385 use the portable "unsigned int debug_on_exit : 1". Remove unused
3386 member evalargs. Remove obsolete comments about cc bombing out.
3387
9851bfc5
JD
33882011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3389
51bb811f 3390 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3391 Let HAVE_GSETTINGS override HAVE_GCONF.
3392 (store_monospaced_changed): New function.
3393 (EMACS_SETTINGS): A new type derived from GObject to handle
3394 GSettings notifications.
3395 (emacs_settings_constructor, emacs_settings_get_property)
3396 (emacs_settings_set_property, emacs_settings_class_init):
3397 New functions.
3398 (gsettings_client, gsettings_obj): New variables.
3399 (GSETTINGS_SCHEMA): New define.
3400 (something_changedCB): Call store_monospaced_changed.
3401 (init_gsettings): New function.
3402 (xsettings_initialize): Call init_gsettings.
3403 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3404 to NULL.
3405
640c8776 3406 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3407 GCONF_CFLAGS/LIBS.
3408
5386012d
MR
34092011-06-29 Martin Rudalics <rudalics@gmx.at>
3410
3411 * window.c (resize_root_window, grow_mini_window)
3412 (shrink_mini_window): Rename Qresize_root_window to
3413 Qwindow_resize_root_window and Qresize_root_window_vertically to
3414 Qwindow_resize_root_window_vertically.
3415
f13e0b08
PE
34162011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3417
3418 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3419
94515237
JB
34202011-06-27 Juanma Barranquero <lekktu@gmail.com>
3421
3422 * makefile.w32-in: Redesign dependencies so they reflect more
3423 clearly which files are directly included by each source file,
3424 and not through other includes.
3425
e43b6e43
MR
34262011-06-27 Martin Rudalics <rudalics@gmx.at>
3427
3428 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3429 (sort_overlays, overlay_strings): When an overlay's clone number
3430 matches the window's clone number process the overlay even if
3431 the overlay's window property doesn't match the current window.
3432
d68443dc
MR
3433 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3434 (Fwindow_hchild): Rename to Fwindow_left_child.
3435 (Fwindow_next): Rename to Fwindow_next_sibling.
3436 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3437 (resize_window_check): Rename to window_resize_check.
3438 (resize_window_apply): Rename to window_resize_apply.
3439 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3440 (Fdelete_other_windows_internal, resize_frame_windows)
3441 (Fsplit_window_internal, Fdelete_window_internal)
3442 (grow_mini_window, shrink_mini_window)
3443 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3444
c7e73be5
JD
34452011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3446
3447 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3448 (emacs_fixed_set_min_size): Remove.
3449 (emacs_fixed_new): Take frame as argument.
3450
3451 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3452 (_EmacsFixedPrivate): Remove minwidth/height.
3453 Add struct frame *f.
3454 (emacs_fixed_init): Initialize priv->f.
3455 (get_parent_class, emacs_fixed_set_min_size): Remove.
3456 (emacs_fixed_new): Set priv->f to argument.
3457 (emacs_fixed_get_preferred_width)
3458 (emacs_fixed_get_preferred_height): Use min_width/height from
3459 frames size_hint to set minimum and natural (Bug#8919).
3460 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3461 and use min_width/height from frames size_hint to set
3462 min_width/height (Bug#8919).
3463
3464 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3465 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3466 Fix indentation.
c7e73be5 3467
cf99dcf8
EZ
34682011-06-26 Eli Zaretskii <eliz@gnu.org>
3469
3470 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3471 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3472 called at ZV.
3473
029529ac
CY
34742011-06-26 Chong Yidong <cyd@stupidchicken.com>
3475
3476 * process.c (wait_reading_process_output): Bypass select if
3477 waiting for a cell while ignoring keyboard input, and input is
3478 pending. Suggested by Jan Djärv (Bug#8869).
3479
7a7ef429
PE
34802011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 Use gnulib's dup2 module instead of rolling our own.
3483 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3484
11fdef7d 34852011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3486
3487 * dispnew.c (scrolling_window): Before scrolling, turn off a
3488 mouse-highlight in the window being scrolled.
3489
cd3520a4
JB
34902011-06-24 Juanma Barranquero <lekktu@gmail.com>
3491
3492 Move DEFSYM to lisp.h and use everywhere.
3493
3494 * character.h (DEFSYM): Move declaration...
3495 * lisp.h (DEFSYM): ...here.
3496
3497 * gnutls.c:
3498 * minibuf.c:
3499 * w32menu.c:
3500 * w32proc.c:
3501 * w32select.c: Don't include character.h.
3502
3503 * alloc.c (syms_of_alloc):
3504 * buffer.c (syms_of_buffer):
3505 * bytecode.c (syms_of_bytecode):
3506 * callint.c (syms_of_callint):
3507 * casefiddle.c (syms_of_casefiddle):
3508 * casetab.c (init_casetab_once):
3509 * category.c (init_category_once, syms_of_category):
3510 * ccl.c (syms_of_ccl):
3511 * cmds.c (syms_of_cmds):
3512 * composite.c (syms_of_composite):
3513 * dbusbind.c (syms_of_dbusbind):
3514 * dired.c (syms_of_dired):
3515 * dispnew.c (syms_of_display):
3516 * doc.c (syms_of_doc):
3517 * editfns.c (syms_of_editfns):
3518 * emacs.c (syms_of_emacs):
3519 * eval.c (syms_of_eval):
3520 * fileio.c (syms_of_fileio):
3521 * fns.c (syms_of_fns):
3522 * frame.c (syms_of_frame):
3523 * fringe.c (syms_of_fringe):
3524 * insdel.c (syms_of_insdel):
3525 * keymap.c (syms_of_keymap):
3526 * lread.c (init_obarray, syms_of_lread):
3527 * macros.c (syms_of_macros):
3528 * msdos.c (syms_of_msdos):
3529 * print.c (syms_of_print):
3530 * process.c (syms_of_process):
3531 * search.c (syms_of_search):
3532 * sound.c (syms_of_sound):
3533 * syntax.c (init_syntax_once, syms_of_syntax):
3534 * terminal.c (syms_of_terminal):
3535 * textprop.c (syms_of_textprop):
3536 * undo.c (syms_of_undo):
3537 * w32.c (globals_of_w32):
3538 * window.c (syms_of_window):
3539 * xdisp.c (syms_of_xdisp):
3540 * xfaces.c (syms_of_xfaces):
3541 * xfns.c (syms_of_xfns):
3542 * xmenu.c (syms_of_xmenu):
3543 * xsettings.c (syms_of_xsettings):
3544 * xterm.c (syms_of_xterm): Use DEFSYM.
3545
4228cf16
TZ
35462011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3547
cd3520a4 3548 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3549
7fcccf1e
PE
35502011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3551
7efb4e0e
PE
3552 Integer and buffer overflow fixes (Bug#8873).
3553
ff5844ad
PE
3554 * print.c (printchar, strout): Check for string overflow.
3555 (PRINTPREPARE, printchar, strout):
3556 Don't set size unless allocation succeeds.
3557
90532f02
PE
3558 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3559 for sizes. Check for string overflow more accurately.
3560 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3561
6d84508d
PE
3562 * macros.c: Integer and buffer overflow fixes.
3563 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3564 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3565 Use ptrdiff_t, not int, for sizes.
3566 Don't increment bufsize until after realloc succeeds.
3567 Check for size-calculation overflow.
3568 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3569
437b2cb4
PE
3570 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3571
8b9ac8b4
PE
3572 * lread.c: Integer overflow fixes.
3573 (read_integer): Radix is now EMACS_INT, not int,
3574 to improve quality of diagnostics for out-of-range radices.
3575 Calculate buffer size correctly for out-of-range radices.
3576 (read1): Check for integer overflow in radices, and in
3577 read-circle numbers.
82cb60d3
PE
3578 (read_escape): Avoid int overflow.
3579 (Fload, openp, read_buffer_size, read1)
3580 (substitute_object_recurse, read_vector, read_list, map_obarray):
3581 Use ptrdiff_t, not int, for sizes.
3582 (read1): Use EMACS_INT, not int, for sizes.
20270765 3583 Check for size overflow.
8b9ac8b4 3584
7fcccf1e
PE
3585 * image.c (cache_image): Check for size arithmetic overflow.
3586
bfbbd7e7
PE
3587 * lread.c: Integer overflow issues.
3588 (saved_doc_string_size, saved_doc_string_length)
3589 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3590 Now ptrdiff_t, not int.
3591 (read1): Don't assume doc string length fits in int. Check for
3592 out-of-range doc string lengths.
3593 (read_list): Don't assume file position fits in int.
39019e54 3594 (read_escape): Check for hex character overflow.
bfbbd7e7 3595
4e323265
LL
35962011-06-22 Leo Liu <sdl.web@gmail.com>
3597
3598 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3599 Move to minibuffer.el.
3600
85fece3e
PE
36012011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3602
20b84ce9 3603 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3604 The following patches are for when GLYPH_DEBUG && !XASSERT.
3605 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3606 * dispnew.c (flush_stdout):
3607 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3608 Mark as externally visible.
3609 * dispnew.c (check_window_matrix_pointers): Now static.
3610 * dispnew.c (window_to_frame_vpos):
3611 * xfns.c (unwind_create_frame):
3612 * xterm.c (x_check_font): Remove unused local.
3613 * scroll.c (CHECK_BOUNDS):
3614 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3615 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3616 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3617 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3618 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3619 Now static.
3620 (debug_method_add): Use va_list and vsprintf rather than relying
3621 on undefined behavior with wrong number of arguments.
3622 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3623 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3624 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3625 since we're not interested in debugging glyphs with old libraries.
3626 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3627 GCC 4.6.0's static checking.
3628
0766b489
PE
36292011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3630
31fd4b32
PE
3631 Integer overflow and signedness fixes (Bug#8873).
3632 A few related buffer overrun fixes, too.
3633
b79e8648
PE
3634 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3635
0766b489
PE
3636 * dispextern.h (struct face.stipple):
3637 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3638 (x_bitmap_mask, x_allocate_bitmap_record)
3639 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3640 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3641 (x_create_bitmap_from_xpm_data):
3642 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3643 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3644 (.bitmaps_last):
3645 * xfaces.c (load_pixmap):
3646 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3647 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3648 (.bitmaps_last, struct x_output.icon_bitmap):
3649 Use ptrdiff_t, not int, for bitmap indexes.
3650 (x_allocate_bitmap_record): Check for size overflow.
3651 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3652
b081724f
PE
3653 Use ptrdiff_t, not int, for overlay counts.
3654 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3655 * editfns.c (overlays_around, get_pos_property):
3656 * textprop.c (get_char_property_and_overlay):
3657 * xdisp.c (next_overlay_change, note_mouse_highlight):
3658 * xfaces.c (face_at_buffer_position):
21514da7
PE
3659 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3660 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3661 (Fnext_overlay_change, Fprevious_overlay_change)
3662 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3663 Use ptrdiff_t, not int, for sizes.
21514da7 3664 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3665
3de73e5e
PE
3666 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3667
2606c57b
PE
3668 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3669 (x_session_initialize): Do not assume string length fits in int.
3670
aaafe47a
PE
3671 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3672 This is unlikely, but can occur if DPI is outlandish.
3673
2674ddc8 3674 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3675 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3676
28154962
PE
3677 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3678 * xrdb.c (magic_file_p, search_magic_path):
3679 Omit last arg SUFFIX; it was always 0. All callers changed.
3680 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3681
7de51af5
PE
3682 * xfont.c (xfont_match): Avoid need for strlen.
3683
25ed6cc3
PE
3684 * xfns.c: Don't assume strlen fits in int.
3685 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3686
4eab31dd
PE
3687 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3688 not unsigned long, as we prefer signed integers. All callers changed.
3689 Detect integer overflow in repeat count.
3690 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3691 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3692
171e2a58
PE
3693 * termcap.c: Don't assume sizes fit in int and never overflow.
3694 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3695 (gobble_line): Check for size-calculation overflow.
3696
ad39faca 3697 * minibuf.c (Fread_buffer):
6e5bb2dc 3698 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3699 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3700 Don't assume string length fits in int.
3701
52c61c22 3702 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3703 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3704
b5b8c9e5
PE
3705 * font.c: Don't assume string length fits in int.
3706 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3707 Use ptrdiff_t, not int.
ccd6111c
PE
3708 (font_intern_prop): Don't assume string length fits in int.
3709 Don't assume integer property fits in fixnum.
3710 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3711
882f0d81 3712 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3713 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3714 Reformulate so as not to need the command string.
3715 Invoke gzip -cd rather than gunzip, as it's more portable.
3716 (lock_info_type, lock_file_1, lock_file):
3717 Don't assume pid_t and time_t fit in unsigned long.
3718 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3719 (current_lock_owner): Prefer signed type for sizes.
3720 Use memcpy, not strncpy, where memcpy is what is really wanted.
3721 Don't assume (via atoi) that time_t and pid_t fit in int.
3722 Check for time_t and/or pid_t out of range, e.g., via a network share.
3723 Don't alloca where an auto var works fine.
3724
93f4cf88
PE
3725 * fileio.c: Fix some integer overflow issues.
3726 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3727 Don't assume string length fits in int.
3728 (directory_file_name): Don't assume string length fits in long.
3729 (make_temp_name): Don't assume pid fits in int, or that its print
3730 length is less than 20.
3731
f3e92b69
PE
3732 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3733
1bfdaf10
PE
3734 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3735
35016e9a
PE
3736 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3737
3d1e65a1
PE
3738 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3739 We prefer signed integers, even for size calculations.
3740
0b963a93
PE
3741 * emacs.c: Don't assume string length fits in 'int'.
3742 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3743 (main): Don't invoke strlen when not needed.
3744
573f4b54
PE
3745 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3746 (XD_DEBUG_MESSAGE): Don't waste a byte.
3747
989f33ba
PE
3748 * callproc.c (getenv_internal_1, getenv_internal)
3749 (Fgetenv_internal):
965d34eb
PE
3750 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3751
e4d29b33
PE
3752 * lread.c (invalid_syntax): Omit length argument.
3753 All uses changed. This doesn't fix a bug, but it simplifies the
3754 code away from its former Hollerith-constant appearance, and it's
3755 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3756 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3757
eb49b136
PE
3758 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3759 This didn't break anything, but it didn't help either.
3760 It's confusing to put a bogus integer in a place where the actual
3761 value does not matter.
9f62aeb1 3762 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3763 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3764
15375a22
PE
3765 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3766 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3767 implementation.
b61cc01c
PE
3768 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3769 We prefer signed types, and the value cannot exceed the EMACS_INT
3770 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3771 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3772 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3773 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3774
53b2623d
PE
3775 * indent.c (sane_tab_width): New function.
3776 (current_column, scan_for_column, Findent_to, position_indentation)
3777 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3778 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3779
51cab52b 3780 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3781
f2ed8a70
PE
3782 * lisp.h (lint_assume): New macro.
3783 * composite.c (composition_gstring_put_cache):
3784 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3785
abe80cc6
PE
3786 * editfns.c, insdel.c:
3787 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3788
b02c740e
PE
3789 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3790
ebc96716
PE
3791 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3792
b4e50fa0 3793 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3794 Use much-faster test for byte-length change.
311d5d7c 3795 Don't assume string byte-length fits in 'int'.
a4cf38e4 3796 Check that character arg fits in 'int'.
85461888 3797 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3798
c0c1ee9f
PE
3799 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3800
a498d7f4
PE
3801 * fns.c (concat): Catch string overflow earlier.
3802 Do not rely on integer wraparound.
3803
51cab52b
PE
3804 * dispextern.h (struct it.overlay_strings_charpos)
3805 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3806 * xdisp.c (forward_to_next_line_start)
3807 (back_to_previous_visible_line_start)
3808 (reseat_at_next_visible_line_start, next_element_from_buffer):
3809 Don't arbitrarily truncate the value of 'selective' to int.
3810
76031fad
PE
3811 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3812
5eb55db9
PE
3813 * composite.c: Don't truncate sizes to 'int'.
3814 (composition_gstring_p, composition_reseat_it)
3815 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3816 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3817 not EMACS_UINT, for indexes.
5eb55db9 3818
0703a717
PE
3819 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3820
d6202519
PE
3821 * buffer.c: Include <verify.h>.
3822 (struct sortvec.priority, struct sortstr.priority):
8961a454 3823 Now EMACS_INT, not int.
c20998a7 3824 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3825 (struct sortstr.size, record_overlay_string)
3826 (struct sortstrlist.size, struct sortlist.used):
3827 Don't truncate size to int.
3828 (record_overlay_string): Check for size-calculation overflow.
d6202519 3829 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3830
d5a19415
JM
38312011-06-22 Jim Meyering <meyering@redhat.com>
3832
029529ac 3833 Don't leak an XBM-image-sized buffer
d5a19415
JM
3834 * image.c (xbm_load): Free the image buffer after using it.
3835
a9041e6c
PE
38362011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3837
3838 Port to Sun C.
3839 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3840 that Sun C diagnosed.
3841 * fns.c (secure_hash): Fix pointer signedness issue.
3842 * intervals.c (static_offset_intervals): New function.
3843 (offset_intervals): Use it.
3844
7f3f739f
LL
38452011-06-21 Leo Liu <sdl.web@gmail.com>
3846
3847 * deps.mk (fns.o):
3848 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3849 sha512.h.
3850
3851 * fns.c (secure_hash): Rename from crypto_hash_function and change
3852 the first arg to accept symbols.
5b66d427 3853 (Fsecure_hash): New primitive.
7f3f739f
LL
3854 (syms_of_fns): New symbols.
3855
76147d94
DD
38562011-06-20 Deniz Dogan <deniz@dogan.se>
3857
3858 * process.c (Fset_process_buffer): Clarify return value in
3859 docstring.
3860
7d7d0045
CY
38612011-06-18 Chong Yidong <cyd@stupidchicken.com>
3862
3863 * dispnew.c (add_window_display_history): Use BVAR.
3864
3865 * xdisp.c (debug_method_add): Use BVAR.
3866 (check_window_end, dump_glyph_matrix, dump_glyph)
3867 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3868
3869 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3870 Likewise.
3871
3872 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3873 check till after the cache is created in init_frame_faces.
3874
ff2bc410
SM
38752011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3876
3877 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3878
28177add
PE
38792011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3880
dd3482fe
PE
3881 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3882 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3883 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3884
393d71f3 3885 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3886 * fileio.c (Finsert_file_contents):
3887 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3888 Remove the old (too-loose) buffer overflow checks.
3889 They weren't needed, since make_gap checks for buffer overflow.
3890 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3891 The old code merely checked for Emacs fixnum overflow, and relied
3892 on undefined (wraparound) behavior. The new code avoids undefined
3893 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3894
2e6813b0 3895 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3896 Tune. Don't use wider integers than needed. Don't use alloca.
3897 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3898
599a9e4f
PE
3899 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3900
99561444
PE
3901 * insdel.c, lisp.h (buffer_overflow): New function.
3902 (insert_from_buffer_1, replace_range, replace_range_2):
3903 * insdel.c (make_gap_larger):
3904 * editfns.c (Finsert_char):
3905 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3906
28177add
PE
3907 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3908
e69dafad
PE
39092011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3910
a7af7fde 3911 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3912
b1c46f02
PE
3913 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3914 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3915
e69dafad
PE
3916 * fileio.c: Don't assume EMACS_INT fits in off_t.
3917 (emacs_lseek): New static function.
3918 (Finsert_file_contents, Fwrite_region): Use it.
3919 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3920
566684ea
PE
3921 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3922
e6966cd6
PE
3923 * fns.c: Don't overflow int when computing a list length.
3924 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3925 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3926 truncation on 64-bit hosts. Check for QUIT every
3927 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3928 faster and is responsive enough.
3929 (Flength): Report an error instead of overflowing an integer.
3930 (Fsafe_length): Return a float if the value is not representable
3931 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3932 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3933 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3934
dd0b0efb
PE
3935 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3936 (header_size, word_size): New constants.
3937 (allocate_vectorlike): Don't check size overflow here.
3938 (allocate_vector): Check it here instead, since this is the only
3939 caller of allocate_vectorlike that could cause overflow.
3940 Check that the new vector's length is representable as a fixnum.
3941
86fe5cfe
PE
3942 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3943 The previous code was bogus. For example, next_almost_prime (32)
3944 returned 39, which is undesirable as it is a multiple of 3; and
3945 next_almost_prime (24) returned 25, which is a multiple of 5 so
3946 why was the code bothering to check for multiples of 7?
3947
80e88859
PE
3948 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3949
4a2f0ad6
PE
3950 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3951
f66c7cf8
PE
3952 Variadic C functions now count arguments with ptrdiff_t.
3953 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3954 Back then I didn't know that the Emacs coding style prefers signed int.
3955 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3956 were being counted with int, which may truncate counts on 64-bit
3957 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3958 * lisp.h (struct Lisp_Subr.function.aMANY)
3959 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3960 Arg counts are now ptrdiff_t, not size_t.
3961 All variadic functions and their callers changed accordingly.
3962 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3963 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3964 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3965 * callint.c (Fcall_interactively): Check arg count for overflow,
3966 to avoid potential buffer overrun. Use signed char, not 'int',
3967 for 'varies' array, so that we needn't bother to check its size
3968 calculation for overflow.
3969 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3970 * eval.c (apply_lambda):
3971 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3972 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3973 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3974
a1759b76
PE
3975 * callint.c (Fcall_interactively): Don't use index var as event count.
3976
d96be9fc
PE
3977 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3978 * mem-limits.h (SIZE): Remove; no longer used.
3979
a690a978 3980 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3981
578c21e6
PE
3982 Remove unnecessary casts.
3983 * xterm.c (x_term_init):
3984 * xfns.c (x_set_border_pixel):
3985 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3986 These aren't needed now that we assume ANSI C.
3987
96f53c6c
PE
3988 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3989 It's more likely to cause problems (due to unsigned overflow)
3990 than to cure them.
3991
83c77d31
PE
3992 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3993
ee2079f1
PE
3994 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3995
6da65536
PE
3996 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3997
7147c4a4
PE
3998 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3999
193e32d9
PE
4000 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4001
e5533da6
PE
4002 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4003
9910e595
PE
4004 GLYPH_CODE_FACE returns EMACS_INT, not int.
4005 * dispextern.h (merge_faces):
4006 * xfaces.c (merge_faces):
01103c44
PE
4007 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4008 Don't assume EMACS_INT fits in int.
9910e595 4009
2638320e
PE
4010 * character.h (CHAR_VALID_P): Remove unused parameter.
4011 * fontset.c, lisp.h, xdisp.c: All uses changed.
4012
045eb8d9
PE
4013 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4014
c1f134b5
PE
4015 * fns.c (concat): Minor tuning based on overflow analysis.
4016 This doesn't fix any bugs. Use int to hold character, instead
4017 of constantly refetching from Emacs object. Use XFASTINT, not
4018 XINT, for value known to be a character. Don't bother comparing
4019 a single byte to 0400, as it's always less.
4020
395fcb93 4021 * floatfns.c (Fexpt):
327eeec8
PE
4022 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4023
abbd3d23
PE
4024 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4025 for characters.
4026
684a03ef
PE
4027 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4028
0fed43f3
PE
4029 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4030 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4031 incorrectly succeed when S was a string, because 4294967386 was
4032 truncated before it was used.
4033
8fd02eb7
PE
4034 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4035 Otherwise, an out-of-range integer could cause undefined behavior
4036 on a 64-bit host.
4037
f8c86b69
PE
4038 * composite.c: Use int, not EMACS_INT, for characters.
4039 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4040 EMACS_INT, for values that are known to be in character range.
4041 This doesn't fix any bugs but is the usual style inside Emacs and
4042 may generate better code on 32-bit machines.
4043
34206dd2
PE
4044 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4045 This is for reasons similar to the recent CHAR_STRING fix.
4046 * charset.c (Fencode_char): Check that character arg is actually
4047 a character. Pass an int to ENCODE_CHAR.
4048 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4049 wider than 'int', as a compile-time check to prevent future regressions
4050 in this area.
4051
c5958d4c 4052 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4053
4054 Make sure a 64-bit char is never passed to CHAR_STRING.
4055 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4056 by silently ignoring the top 32 bits, allowing some values
4057 that were far too large to be valid characters.
4058 * character.h: Include <verify.h>.
4059 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4060 arguments are no wider than unsigned, as a compile-time check
4061 to prevent future regressions in this area.
4062 * data.c (Faset):
01103c44 4063 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4064 (Fsubst_char_in_region):
4065 * fns.c (concat):
4066 * xdisp.c (decode_mode_spec_coding):
4067 Adjust to CHAR_STRING's new requirement.
4068 * editfns.c (Finsert_char, Fsubst_char_in_region):
4069 * fns.c (concat): Check that character args are actually
4070 characters. Without this test, these functions did the wrong
4071 thing with wildly out-of-range values on 64-bit hosts.
4072
d37ca623
PE
4073 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4074 These casts should not be needed on 32-bit hosts, either.
4075 * keyboard.c (read_char):
4076 * lread.c (Fload): Remove casts to unsigned.
4077
ea204efb
PE
4078 * lisp.h (UNSIGNED_CMP): New macro.
4079 This fixes comparison bugs on 64-bit hosts.
4080 (ASCII_CHAR_P): Use it.
4081 * casefiddle.c (casify_object):
01103c44 4082 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4083 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4084 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4085 * dispextern.h (FACE_FROM_ID):
4086 * keyboard.c (read_char): Use UNSIGNED_CMP.
4087
41cb286c
PE
4088 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4089 not to EMACS_INT, to avoid GCC warning.
4090
4a1b9832
PE
4091 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4092
55daad71
PE
4093 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4094 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4095 isn't needed on 32-bit machines.
8f95c75c 4096
01103c44
PE
4097 * buffer.c (Fgenerate_new_buffer_name):
4098 Use EMACS_INT for count, not int.
0ceccced 4099 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4100
4101 * data.c (Qcompiled_function): Now static.
4102
c6f072e7
PE
4103 * window.c (window_body_lines): Now static.
4104
20ce5912
PE
4105 * image.c (gif_load): Rename local to avoid shadowing.
4106
9c4c5f81
PE
4107 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4108 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4109 * alloc.c (make_save_value): Integer argument is now of type
4110 ptrdiff_t, not int.
4111 (mark_object): Use ptrdiff_t, not int.
4112 * lisp.h (pD): New macro.
4113 * print.c (print_object): Use it.
4114
c0c5c8ae
PE
4115 * alloc.c: Use EMACS_INT, not int, to count objects.
4116 (total_conses, total_markers, total_symbols, total_vector_size)
4117 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4118 (total_free_floats, total_floats, total_free_intervals)
4119 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4120 Now EMACS_INT, not int. All uses changed.
4121 (Fgarbage_collect): Compute overall total using a double, so that
4122 integer overflow is less likely to be a problem. Check for overflow
4123 when converting back to an integer.
5a25e253
PE
4124 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4125 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4126 These were 'int' variables that could overflow on 64-bit hosts;
4127 they were never used, so remove them instead of repairing them.
211a0b2a 4128 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4129 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4130 Previously, this ceilinged at INT_MAX, but that doesn't work on
4131 64-bit machines.
e46bb31a 4132 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4133
c78baabf 4134 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4135 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4136 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4137 when a (possibly-narrower) signed value would do just as well.
4138 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4139
c9d624c6
PE
4140 * alloc.c: Catch some string size overflows that we were missing.
4141 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4142 for convenience in STRING_BYTES_MAX.
4143 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4144 The definition here is exact; the one in lisp.h was approximate.
4145 (allocate_string_data): Check for string overflow. This catches
4146 some instances we weren't catching before. Also, it catches
4147 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4148 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4149 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4150
c9d624c6
PE
4151 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4152 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4153 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4154
353032ce
PE
4155 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4156
2bccce07
PE
4157 * alloc.c (Fmake_string): Check for out-of-range init.
4158
0ac30604
SM
41592011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4160
4161 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4162
c195f2de
JD
41632011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4164
4165 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4166 xg_get_default_scrollbar_width.
4167
4168 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4169 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4170 (style_changed_cb): Call update_theme_scrollbar_width and call
4171 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4172 all frames (Bug#8505).
4173 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4174 Call gtk_window_set_resizable if HAVE_GTK3.
4175 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4176 and height if HAVE_GTK3 (Bug#8505).
4177 (scroll_bar_width_for_theme): New variable.
4178 (update_theme_scrollbar_width): New function.
4179 (xg_get_default_scrollbar_width): Move code to
4180 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4181 (xg_initialize): Call update_theme_scrollbar_width.
4182
4183 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4184
4185 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4186
e10ac9f1
MR
41872011-06-12 Martin Rudalics <rudalics@gmx.at>
4188
4189 * frame.c (make_frame): Call other_buffer_safely instead of
4190 other_buffer.
4191
4192 * window.c (temp_output_buffer_show): Call display_buffer with
4193 second argument Vtemp_buffer_show_specifiers and reset latter
4194 immediately after the call.
4195 (Vtemp_buffer_show_specifiers): New variable.
4196 (auto_window_vscroll_p, next_screen_context_lines)
4197 (Vscroll_preserve_screen_position): Remove leading asterisks from
4198 doc-strings.
4199
2d3c217e 42002011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4201
7b7f97e8 4202 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4203 * buffer.c (Qclone_number): Remove for now, as it's unused.
4204 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4205 (record_buffer): Remove unused local.
4206 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4207 (set_frame_buffer_list): Remove; unused.
4208 * frame.h (other_visible_frames): Remove decl.
4209 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4210 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4211 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4212 if HAVE_GPM.
4213 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4214 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4215 Define only if HAVE_GPM.
4216 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4217 (update_hints_inhibit): Remove; never set. All uses removed.
4218 * widgetprv.h (emacsFrameClassRec): Remove decl.
4219 * window.c (delete_deletable_window): Now returns void, since it
4220 wasn't returning anything.
4221 (compare_window_configurations): Remove unused locals.
4222 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4223 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4224 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4225 the same widths as pointers. This follows up on the 2011-05-06 patch.
4226 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4227 * xterm.h: Likewise.
4228 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4229
1384b89e
JB
42302011-06-12 Juanma Barranquero <lekktu@gmail.com>
4231
4232 * makefile.w32-in: Update dependencies.
4233 (LISP_H): Add lib/intprops.h.
4234
1100a63c
CY
42352011-06-11 Chong Yidong <cyd@stupidchicken.com>
4236
4237 * image.c (gif_load): Add animation frame delay to the metadata.
4238 (syms_of_image): Use DEFSYM. New symbol `delay'.
4239
6198ccd0
MR
42402011-06-11 Martin Rudalics <rudalics@gmx.at>
4241
4242 * window.c (delete_deletable_window): Re-add.
4243 (Fset_window_configuration): Rewrite to handle dead buffers and
4244 consequently deletable windows.
4245 (window_tree, Fwindow_tree): Remove. Supply functionality in
4246 window.el.
4247 (compare_window_configurations): Simplify code.
4248
b6e3633c
AS
42492011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4250
1ab0dee5
AS
4251 * image.c (imagemagick_load_image): Fix type mismatch.
4252 (Fimagemagick_types): Likewise.
4253
b6e3633c
AS
4254 * window.h (replace_buffer_in_windows): Declare.
4255
9397e56f
MR
42562011-06-11 Martin Rudalics <rudalics@gmx.at>
4257
4258 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4259 Qclone_number. Remove external declaration of Qdelete_window.
4260 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4261 code.
640c8776
SM
4262 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4263 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4264 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4265 buffer list implementation.
4266 (other_buffer_safely): New function.
4267 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4268 calls to replace_buffer_in_windows and
4269 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4270 if allowed.
4271 (record_buffer): Inhibit quitting and rewrite using quittable
4272 functions. Run Qbuffer_list_update_hook if allowed.
4273 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4274 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4275 Move switch-to-buffer to window.el.
9397e56f
MR
4276 (bury-buffer): Move to window.el.
4277 (Vbuffer_list_update_hook): New variable.
4278
4279 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4280 section.
4281
4282 * window.h (resize_frame_windows): Move up in code.
4283 (Fwindow_frame): Remove EXFUN.
4284 (replace_buffer_in_all_windows): Remove prototype.
4285 (replace_buffer_in_windows_safely): Add prototype.
4286
4287 * window.c: Declare Qdelete_window static again. Move down
4288 declaration of select_count.
4289 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4290 (Fother_window): Move to window.el.
4291 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4292 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4293 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4294 window.el.
4295 (replace_buffer_in_windows): Implement by calling
4296 Qreplace_buffer_in_windows.
4297 (replace_buffer_in_all_windows): Remove with some functionality
4298 moved into replace_buffer_in_windows_safely.
4299 (replace_buffer_in_windows_safely): New function.
4300 (select_window_norecord, select_frame_norecord): Move in front
4301 of run_window_configuration_change_hook. Remove now obsolete
4302 declarations.
640c8776
SM
4303 (Fset_window_buffer): Rewrite doc-string.
4304 Call Qrecord_window_buffer.
9397e56f
MR
4305 (keys_of_window): Move binding for other-window to window.el.
4306
b50691aa
CY
43072011-06-11 Chong Yidong <cyd@stupidchicken.com>
4308
4309 * dispextern.h (struct image): Replace data member, whose int_val
4310 and ptr_val fields were not used by anything, with a single
4311 lisp_val object.
4312
4313 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4314 (gif_clear_image, gif_load, imagemagick_load_image)
4315 (gs_clear_image, gs_load): Callers changed.
4316
3f754b86
PE
43172011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4318
cca69397
PE
4319 * buffer.h: Include <time.h>, for time_t.
4320 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4321
109e28d0
PE
4322 Fix minor problems found by static checking.
4323
60737f02
PE
4324 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4325
4b66faf3
PE
4326 Make identifiers static if they are not used in other modules.
4327 * data.c (Qcompiled_function, Qframe, Qvector):
4328 * image.c (QimageMagick, Qsvg):
4329 * minibuf.c (Qmetadata):
4330 * window.c (resize_window_check, resize_root_window): Now static.
4331 * window.h (resize_window_check, resize_root_window): Remove decls.
4332
109e28d0
PE
4333 * window.c (window_deletion_count, delete_deletable_window):
4334 Remove; unused.
46a4ce9e
PE
4335 (window_body_lines): Now static.
4336 (Fdelete_other_windows_internal): Mark vars as initialized.
4337 Make sure 'resize_failed' is initialized.
4338 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4339 (resize_window_apply): Remove unused local.
4340 * window.h (delete_deletable_window): Remove decl.
4341
109e28d0 4342 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4343 (imagemagick_load_image): Fix pointer signedness problem by changing
4344 last arg from unsigned char * to char *. All uses changed.
4345 Also, fix a local for similar reasons.
4346 Remove unused locals. Remove locals to avoid shadowing.
4347 (fn_rsvg_handle_free): Remove; unused.
4348 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4349 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4350
3f754b86
PE
4351 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4352
2547adb1
CY
43532011-06-10 Chong Yidong <cyd@stupidchicken.com>
4354
4355 * image.c (gif_load): Fix omitted cast error introduced by
4356 2011-06-06 change.
4357
2c8e37d4
MR
43582011-06-10 Martin Rudalics <rudalics@gmx.at>
4359
4360 * window.h (resize_proportionally, orig_total_lines)
4361 (orig_top_line): Remove from window structure.
4362 (set_window_height, set_window_width, change_window_heights)
4363 (Fdelete_window): Remove prototypes.
4364 (resize_frame_windows): Remove duplicate declaration.
4365
440a42e3
EZ
43662011-06-10 Eli Zaretskii <eliz@gnu.org>
4367
4368 * window.h (resize_frame_windows, resize_window_check)
4369 (delete_deletable_window, resize_root_window)
4370 (resize_frame_windows): Declare prototypes.
4371
4372 * window.c (resize_window_apply): Make definition be "static" to
4373 match the prototype.
4374
562dd5e9
MR
43752011-06-10 Martin Rudalics <rudalics@gmx.at>
4376
4377 * window.c: Remove declarations of Qwindow_size_fixed,
4378 window_min_size_1, window_min_size_2, window_min_size,
4379 size_window, window_fixed_size_p, enlarge_window, delete_window.
4380 Remove static from declaration of Qdelete_window, it's
4381 temporarily needed by Fbury_buffer.
4382 (replace_window): Don't assign orig_top_line and
4383 orig_total_lines.
4384 (Fdelete_window, delete_window): Remove. Window deletion is
4385 handled by window.el.
640c8776
SM
4386 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4387 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4388 (Fdelete_other_windows): Remove. Deleting other windows is
4389 handled by window.el.
4390 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4391 handled in window.el.
4392 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4393 Window minimum sizes are handled in window.el.
4394 (shrink_windows, size_window, set_window_height)
4395 (set_window_width, change_window_heights, window_height)
4396 (window_width, CURBEG, CURSIZE, enlarge_window)
4397 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4398 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4399 handled in window.el.
4400 (make_dummy_parent): Rename to make_parent_window and give it a
4401 second argument horflag.
4402 (make_window): Don't set resize_proportionally any more.
4403 (Fsplit_window): Remove. Windows are split in window.el.
4404 (save_restore_action, save_restore_orig_size)
4405 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4406 Resize mini windows in window.el.
4407 (grow_mini_window, shrink_mini_window): Implement by calling
4408 Qresize_root_window_vertically, resize_window_check and
4409 resize_window_apply.
640c8776
SM
4410 (saved_window, Fset_window_configuration, save_window_save):
4411 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4412 resize_proportionally.
4413 (window_min_height, window_min_width): Move to window.el.
4414 (keys_of_window): Move bindings for delete-other-windows,
4415 split-window, delete-window and enlarge-window to window.el.
4416
4417 * buffer.c: Temporarily extern Qdelete_window.
4418 (Fbury_buffer): Temporarily call Qdelete_window instead of
4419 Fdelete_window (Fbury_buffer will move to window.el soon).
4420
4421 * frame.c (set_menu_bar_lines_1): Remove code handling
4422 orig_top_line and orig_total_lines.
4423
4424 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4425 set_window_height but set heights directly.
4426 (change_frame_size_1): Use resize_frame_windows.
4427
4428 * xdisp.c (init_xdisp): Don't use set_window_height but set
4429 heights directly.
4430
640c8776
SM
4431 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4432 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4433 run_window_configuration_change_hook.
4434
4435 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4436 instead of change_window_heights and run
4437 run_window_configuration_change_hook.
4438
1a13852e
MR
44392011-06-09 Martin Rudalics <rudalics@gmx.at>
4440
4441 * window.c (replace_window): Rename second argument REPLACEMENT to
4442 NEW. New third argument SETFLAG. Rewrite.
4443 (delete_window, make_dummy_parent): Call replace_window with
4444 third argument 1.
4445 (window_list_1): Move down in code.
4446 (run_window_configuration_change_hook): Move set_buffer part
4447 before select_frame_norecord part in order to unwind correctly.
4448 Rename count1 to count.
4449 (recombine_windows, delete_deletable_window, resize_root_window)
4450 (Fdelete_other_windows_internal)
4451 (Frun_window_configuration_change_hook, make_parent_window)
4452 (resize_window_check, resize_window_apply, Fresize_window_apply)
4453 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4454 (Fdelete_window_internal, Fresize_mini_window_internal):
4455 New functions.
1a13852e
MR
4456 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4457
f3d1777e
MR
44582011-06-08 Martin Rudalics <rudalics@gmx.at>
4459
496e208e
MR
4460 * window.h (window): Add some new members to window structure -
4461 normal_lines, normal_cols, new_total, new_normal, clone_number,
4462 splits, nest, prev_buffers, next_buffers.
4463 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4464 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4465
f3d1777e
MR
4466 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4467 Remove.
496e208e
MR
4468 (make_dummy_parent): Set new members of windows structure.
4469 (make_window): Move down in code. Handle new members of window
4470 structure.
4471 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4472 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4473 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4474 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4475 (Fset_window_next_buffers, Fset_window_clone_number):
4476 New functions.
496e208e
MR
4477 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4478 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4479 Doc-string fixes.
4480 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4481 Argument WINDOW can be now internal window too.
4482 (Fwindow_use_time): Move up in code.
4483 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4484 Rewrite doc-string.
4485 (Fset_window_configuration, saved_window)
4486 (Fcurrent_window_configuration, save_window_save): Handle new
4487 members of window structure.
b9e809c2
MR
4488 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4489 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4490 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4491 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4492 Qget_mru_window, Qresize_root_window,
4493 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4494 Qauto_buffer_name; staticpro them.
f3d1777e 4495
abde8f8c
MR
44962011-06-07 Martin Rudalics <rudalics@gmx.at>
4497
4498 * window.c (Fwindow_total_size, Fwindow_left_column)
4499 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4500 (Fwindow_list_1): New functions.
4501 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4502 (Fwindow_width, Fscroll_left, Fscroll_right):
4503 Use window_body_cols instead of window_box_text_cols.
4504 (delete_window, Fset_window_configuration):
4505 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4506 (delete_all_subwindows): Take a window as argument and not a
4507 structure. Rewrite.
190b47e6
MR
4508 (window_loop): Remove handling of GET_LRU_WINDOW and
4509 GET_LARGEST_WINDOW.
4510 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4511
4512 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4513 window_box_text_cols. delete_all_subwindows now takes a
4514 Lisp_Object as argument.
abde8f8c 4515
640c8776
SM
4516 * indent.c (compute_motion, Fcompute_motion):
4517 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4518
fa8a67e6
MR
4519 * frame.c (delete_frame): Call delete_all_subwindows with root
4520 window as argument.
4521
a54e3482
DC
45222011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4523
4524 * fns.c (Fputhash): Document return value.
4525
60002bf5
CY
45262011-06-06 Chong Yidong <cyd@stupidchicken.com>
4527
4528 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4529
0c671da6 45302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4531
b862a52a 4532 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4533
be44ca6c
PE
4534 Check for overflow when converting integer to cons and back.
4535 * charset.c (Fdefine_charset_internal, Fdecode_char):
4536 Use cons_to_unsigned to catch overflow.
4537 (Fencode_char): Use INTEGER_TO_CONS.
4538 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4539 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4540 * data.c (long_to_cons, cons_to_long): Remove.
4541 (cons_to_unsigned, cons_to_signed): New functions.
4542 These signal an error for invalid or out-of-range values.
4543 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4544 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4545 * font.c (Ffont_variation_glyphs):
4546 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4547 * lisp.h: Include <intprops.h>.
4548 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4549 (cons_to_signed, cons_to_unsigned): New decls.
4550 (long_to_cons, cons_to_long): Remove decls.
4551 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4552 (Fprimitive_undo): Use CONS_TO_INTEGER.
4553 * xfns.c (Fx_window_property): Likewise.
4554 * xselect.c: Include <limits.h>.
4555 (x_own_selection, selection_data_to_lisp_data):
4556 Use INTEGER_TO_CONS.
4557 (x_handle_selection_request, x_handle_selection_clear)
4558 (x_get_foreign_selection, Fx_disown_selection_internal)
4559 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4560 (lisp_data_to_selection_data): Use cons_to_unsigned.
4561 (x_fill_property_data): Use cons_to_signed.
4562 Report values out of range.
4563
d1f3d2af
PE
4564 Check for buffer and string overflow more precisely.
4565 * buffer.h (BUF_BYTES_MAX): New macro.
4566 * lisp.h (STRING_BYTES_MAX): New macro.
4567 * alloc.c (Fmake_string):
4568 * character.c (string_escape_byte8):
4569 * coding.c (coding_alloc_by_realloc):
4570 * doprnt.c (doprnt):
4571 * editfns.c (Fformat):
4572 * eval.c (verror):
4573 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4574 since they may not be the same number.
4575 * editfns.c (Finsert_char):
4576 * fileio.c (Finsert_file_contents):
4577 Likewise for BUF_BYTES_MAX.
4578
dd52fcea
PE
4579 * image.c: Use ptrdiff_t, not int, for sizes.
4580 (slurp_file): Switch from int to ptrdiff_t.
4581 All uses changed.
4582 (slurp_file): Check that file size fits in both size_t (for
4583 malloc) and ptrdiff_t (for sanity and safety).
4584
7f9bbdbb
PE
4585 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4586 if b->modtime has its maximal value.
4587
dfe18f82
PE
4588 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4589
84acfcf0
PE
4590 Don't assume time_t can fit into int.
4591 * buffer.h (struct buffer.modtime): Now time_t, not int.
4592 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4593 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4594
ccd9a01a
PE
4595 Minor fixes for signed vs unsigned integers.
4596 * character.h (MAYBE_UNIFY_CHAR):
4597 * charset.c (maybe_unify_char):
4598 * keyboard.c (read_char, reorder_modifiers):
4599 XINT -> XFASTINT, since the integer must be nonnegative.
4600 * ftfont.c (ftfont_spec_pattern):
4601 * keymap.c (access_keymap, silly_event_symbol_error):
4602 XUINT -> XFASTINT, since the integer must be nonnegative.
4603 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4604 since it makes no difference and we prefer signed.
4605 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4606 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4607 nonnegative.
4608
d6d100dd
SM
46092011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4610
4611 * window.h (Fwindow_frame): Declare.
4612
2b6148e4
PE
46132011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4616 (SPARE_MEMORY): Always define.
4617 (LARGE_REQUEST): Remove.
4618 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4619
f230ecc9
MR
46202011-06-06 Martin Rudalics <rudalics@gmx.at>
4621
727e958e
MR
4622 * lisp.h: Move EXFUNS for Fframe_root_window,
4623 Fframe_first_window and Fset_frame_selected_window to window.h.
4624
4625 * window.h: Move EXFUNS for Fframe_root_window,
4626 Fframe_first_window and Fset_frame_selected_window here from
4627 lisp.h.
4628
4629 * frame.c (Fwindow_frame, Fframe_first_window)
4630 (Fframe_root_window, Fframe_selected_window)
4631 (Fset_frame_selected_window): Move to window.c.
4632 (Factive_minibuffer_window): Move to minibuf.c.
4633 (Fother_visible_frames_p): New function.
4634
4635 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4636
f230ecc9
MR
4637 * window.c (decode_window, decode_any_window): Move up in code.
4638 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4639 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4640 (Fwindow_buffer): Move up and rewrite doc-string.
4641 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4642 (Fwindow_prev): New functions.
727e958e
MR
4643 (Fwindow_frame): Move here from frame.c. Accept any window as
4644 argument.
4645 (Fframe_root_window, Fframe_first_window)
4646 (Fframe_selected_window): Move here from frame.c. Accept frame
4647 or arbitrary window as argument. Update doc-strings.
4648 (Fminibuffer_window): Move up in code.
4649 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4650 (Fset_frame_selected_window): Move here from frame.c.
4651 Marginal rewrite.
727e958e
MR
4652 (Fselected_window, select_window, Fselect_window): Move up in
4653 code. Minor doc-string fixes.
f230ecc9 4654
4d09bcf6
PE
46552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4656
4657 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4658 Do not assume that spare memory exists; that assumption is valid
4659 only if SYSTEM_MALLOC.
4660 (LARGE_REQUEST): New macro, so that the issue of large requests
4661 is separated from the issue of spare memory.
4662
810928a2
AS
46632011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4664
172418ad
AS
4665 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4666 format. (Bug#8806)
4667
43f862f7
AS
4668 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4669
810928a2
AS
4670 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4671 before statements.
4672
a059fe24
JD
46732011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4674
4675 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4676
4677 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4678
4679 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4680 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4681
989bf368
JB
46822011-06-05 Juanma Barranquero <lekktu@gmail.com>
4683
4684 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4685
4b80f674
CY
46862011-06-04 Chong Yidong <cyd@stupidchicken.com>
4687
4688 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4689 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4690 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4691 New error handlers.
4b80f674
CY
4692 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4693 Obey Vx_select_enable_clipboard_manager. Catch errors in
4694 x_clipboard_manager_save (Bug#8779).
4695 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4696 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4697
99a33b77 46982011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4699
4700 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4701
99a33b77 47022011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4703
4704 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4705 in the current matrix if keep_current_p is non-zero.
4706
8264569d
EZ
47072011-06-04 Eli Zaretskii <eliz@gnu.org>
4708
4709 * bidi.c (bidi_level_of_next_char): Fix last change.
4710
57f97249
EZ
47112011-06-03 Eli Zaretskii <eliz@gnu.org>
4712
fec2107c 4713 Support bidi reordering of text covered by display properties.
57f97249 4714
fec2107c
EZ
4715 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4716 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4717 (bidi_cache_search, bidi_cache_iterator_state)
4718 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4719 (bidi_level_of_next_char, bidi_move_to_visually_next):
4720 Support character positions inside a run of characters covered by a
fec2107c
EZ
4721 display string.
4722 (bidi_paragraph_init, bidi_resolve_explicit_1)
4723 (bidi_level_of_next_char): Call bidi_fetch_char and
4724 bidi_fetch_char_advance instead of FETCH_CHAR and
4725 FETCH_CHAR_ADVANCE.
4726 (bidi_init_it): Initialize new members.
4727 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4728 definitions.
4729 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4730 instead of using explicit *_CHAR codes.
d6d100dd
SM
4731 (bidi_resolve_explicit, bidi_resolve_weak):
4732 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4733 bidirectional text is supported only in multibyte buffers.
4734 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4735 it to initialize the frame_window_p member of struct bidi_it.
4736 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4737 (bidi_resolve_explicit, bidi_resolve_weak)
4738 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4739 bidi_it->nchars is non-positive.
4740 (bidi_level_of_next_char): Don't try to lookup the cache for the
4741 next/previous character if nothing is cached there yet, or if we
4742 were just reseat()'ed to a new position.
c40e2fb2 4743
0e14fe90
EZ
4744 * xdisp.c (set_cursor_from_row): Set start and stop points
4745 according to the row's direction when priming the loop that looks
4746 for the glyph on which to display cursor.
4747 (single_display_spec_intangible_p): Function deleted.
4748 (display_prop_intangible_p): Reimplement to call
4749 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4750 Accept 3 additional arguments needed by handle_display_spec.
4751 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4752 values: lists, `(when COND...)' forms, etc.
4753 (single_display_spec_string_p): Support property values that are
4754 lists with the argument STRING its top-level element.
4755 (display_prop_string_p): Fix the condition for processing a
4756 property that is a list to be consistent with handle_display_spec.
fec2107c 4757 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4758 last portion of handle_display_prop.
4759 (compute_display_string_pos): Accept additional argument
4760 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4761 value of a `display' property is a "replacing spec".
4762 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4763 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4764 the display property, but just return a value indicating whether
4765 the display property will replace the characters it covers.
4766 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4767 frame_window_p members of struct bidi_it.
d6d100dd
SM
4768 (compute_display_string_pos, compute_display_string_end):
4769 New functions.
fec2107c
EZ
4770 (push_it): Accept second argument POSITION, where pop_it should
4771 jump to continue iteration.
4772 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4773
fec2107c
EZ
4774 * keyboard.c (adjust_point_for_property): Adjust the call to
4775 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4776
4777 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4778 (bidi_init_it): Update prototypes.
4779 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4780 (compute_display_string_pos, compute_display_string_end):
4781 Declare prototypes.
fec2107c
EZ
4782 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4783 EMACS_INT.
fc6f18ce 4784
40087514 47852011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4786
57f53182
PE
4787 Malloc failure behavior now depends on size of allocation.
4788 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4789 * lisp.h: Change signatures accordingly.
4790 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4791 All callers changed. (Bug#8762)
4792
4793 * gnutls.c: Use Emacs's memory allocators.
4794 Without this change, the gnutls library would invoke malloc etc.
4795 directly, which causes problems on non-SYNC_INPUT hosts, and which
4796 runs afoul of improving memory_full behavior. (Bug#8761)
4797 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4798 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4799 xfree instead of the default malloc, realloc, free.
4800 (Fgnutls_boot): No need to check for memory allocation failure,
4801 since xmalloc does that for us.
4802
ac32cd99 4803 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4804 * category.c (hash_get_category_set):
4805 * ccl.c (ccl_driver):
4806 * charset.c (Fdefine_charset_internal):
4807 * charset.h (struct charset.hash_index):
4808 * composite.c (get_composition_id, gstring_lookup_cache)
4809 (composition_gstring_put_cache):
4810 * composite.h (struct composition.hash_index):
4811 * dispextern.h (struct image.hash):
4812 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4813 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4814 (hashfn_equal, hashfn_user_defined, make_hash_table)
4815 (maybe_resize_hash_table, hash_lookup, hash_put)
4816 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4817 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4818 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4819 * image.c (make_image, search_image_cache, lookup_image)
4820 (xpm_put_color_table_h):
4821 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4822 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4823 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4824 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4825 * alloc.c (allocate_vectorlike):
4826 Check for overflow in vector size calculations.
4827 * ccl.c (ccl_driver):
4828 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4829 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4830 need to be updated by these changes.
40087514
PE
4831 * fns.c (make_hash_table, maybe_resize_hash_table):
4832 Check for integer overflow with large hash tables.
0de4bb68
PE
4833 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4834 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4835 (SXHASH_REDUCE): New macro.
4836 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4837 Use it instead of discarding useful hash info with large hash values.
4838 (sxhash_float): New function.
4839 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4840 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4841 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4842 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4843 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4844 Adjust signatures to match updated version of code.
4845 (consing_since_gc): Now EMACS_INT, since a single hash table can
4846 use more than INT_MAX bytes.
4847
698d32e2
DN
48482011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4849
4850 Make it possible to build with GCC-4.6+ -O2 -flto.
4851
4852 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4853
fd6fa53f
SM
48542011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4855
4856 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4857 Call minibuffer-inactive-mode.
4858
864db017
JB
48592011-05-31 Juanma Barranquero <lekktu@gmail.com>
4860
4861 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4862 Update dependencies.
4863
2ad0baf4
DN
48642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4865
4866 * data.c (init_data): Remove code for UTS, this system is not
4867 supported anymore.
4868
4fcc2638
DN
48692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4870
4871 Don't force ./temacs to start in terminal mode.
4872
4873 * frame.c (make_initial_frame): Initialize faces in all cases, not
4874 only when CANNOT_DUMP is defined.
4875 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4876
c56e0fd5
DN
48772011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4878
4879 * dispnew.c (add_window_display_history): Use const for the string
4880 pointer. Remove declaration, not needed.
4881
333d54da 48822011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4883
55d4c1b2 4884 Use 'inline', not 'INLINE'.
333d54da 4885 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4886 * alloc.c, fontset.c (INLINE): Remove.
4887 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4888 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4889 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4890 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4891 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4892
738db178
DN
48932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4894
4895 Make it possible to run ./temacs.
4896
4897 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4898 syms_of_callproc does the same thing. Remove test for
4899 "initialized", do it in the caller.
4900 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4901
620c53a6
SM
49022011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4903
4904 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4905 (read_minibuf): Use get_minibuffer.
4906 (syms_of_minibuf): Use DEFSYM.
4907 (Qmetadata): New var.
4908 * data.c (Qbuffer): Don't make it static.
4909 (syms_of_data): Use DEFSYM.
4910
e003a292
PE
49112011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4912
4913 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4914 (CCL_CODE_MIN): New macro.
4915
ed008a6d
PE
49162011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4917
3687c2ef
PE
4918 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4919
ed008a6d
PE
4920 * eval.c (Qdebug): Now static.
4921 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4922 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4923 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4924
d66c4c7c
CY
49252011-05-29 Chong Yidong <cyd@stupidchicken.com>
4926
4927 * image.c: Various fixes to ImageMagick code comments.
4928 (Fimagemagick_types): Doc fix.
4929
5fbc2025
PE
49302011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4931
0196f88a
PE
4932 Minor fixes prompted by GCC 4.6.0 warnings.
4933
4934 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4935
5fbc2025
PE
4936 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4937 (x_clipboard_manager_save_all): Move extern decl to ...
4938 * xterm.h: ... here, so that it can be checked for consistency.
4939
1dd3c2d9
CY
49402011-05-29 Chong Yidong <cyd@stupidchicken.com>
4941
4942 * xselect.c (x_clipboard_manager_save_frame)
4943 (x_clipboard_manager_save_all): New functions.
4944 (Fx_clipboard_manager_save): Lisp function deleted.
4945
4946 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4947 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4948
4949 * xterm.h: Update prototype.
4950
5ba6571d
WX
49512011-05-28 William Xu <william.xwl@gmail.com>
4952
4953 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4954 exiting (Bug#8239).
4955
3eaff834
JM
49562011-05-28 Jim Meyering <meyering@redhat.com>
4957
e1900994 4958 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4959 * fns.c (to_uchar): Define.
4960 (crypto_hash_function): Use it to convert some newly-signed
4961 variables to unsigned, to avoid sign-extension bugs. For example,
4962 without this change, (md5 "truc") would evaluate to
4963 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4964 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4965 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4966
0f6990a7
PE
49672011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4968
4969 Integer overflow fixes.
c8a9ca5a 4970
08686060
PE
4971 * dbusbind.c: Serial number integer overflow fixes.
4972 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4973 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4974 to hold a serial number that is too large for a fixnum.
4975 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4976 Check for serial numbers out of range. Decode any serial number
59568bf0 4977 that was so large that it became a float. (Bug#8722)
08686060 4978
2d1fc3c7
PE
4979 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4980 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4981 Use XFASTINT rather than XUINT when numbers are nonnegative.
4982 (xd_append_arg, Fdbus_method_return_internal):
4983 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4984 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4985 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4986 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4987 (Bug#8722)
2d1fc3c7 4988
c8a9ca5a
PE
4989 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4990
519e1d69
PE
4991 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4992
30569699
PE
4993 ccl: add integer overflow checks
4994 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4995 (IN_INT_RANGE): New macros.
4996 (ccl_driver): Use them to check for integer overflow when
4997 decoding a CCL program. Many of the new checks are whether XINT (x)
4998 fits in int; it doesn't always, on 64-bit hosts. The new version
4999 doesn't catch all possible integer overflows, but it's an
847044ea 5000 improvement. (Bug#8719)
30569699 5001
c11285dc
PE
5002 * alloc.c (make_event_array): Use XINT, not XUINT.
5003 There's no need for unsigned here.
5004
fdccd48e
PE
5005 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5006 This follows up to the 2011-05-06 change that substituted uintptr_t
5007 for EMACS_INT. This case wasn't caught back then.
5008
37910ab2
PE
5009 Rework Fformat to avoid integer overflow issues.
5010 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5011 now (part of C89). Include <verify.h>.
5012 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5013 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5014 (Fformat): Avoid the prepass trying to compute sizes; it was only
5015 approximate and thus did not catch overflow reliably. Instead, walk
5016 through the format just once, formatting and computing sizes as we go,
5017 checking for integer overflow at every step, and allocating a larger
5018 buffer as needed. Keep track separately whether the format is
5019 multibyte. Keep only the most-recently calculated precision, rather
5020 than them all. Record whether each argument has been converted to
5021 string. Use EMACS_INT, not int, for byte and char and arg counts.
5022 Support field widths and precisions larger than INT_MAX. Avoid
5023 sprintf's undefined behavior with conversion specifications such as %#d
5024 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5025 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5026 formatting out-of-range floating point numbers with int
9173deec 5027 formats. (Bug#8668)
37910ab2 5028
2e6578fb
PE
5029 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5030
0ae6bdee
PE
5031 * data.c: Avoid integer truncation in expressions involving floats.
5032 * data.c: Include <intprops.h>.
5033 (arith_driver): When there's an integer overflow in an expression
5034 involving floating point, convert the integers to floating point
5035 so that the resulting value does not suffer from catastrophic
5036 integer truncation. For example, on a 64-bit host (* 4
5037 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5038 Do not rely on undefined behavior after integer overflow.
5039
de883a70
PE
5040 merge count_size_as_multibyte, parse_str_to_multibyte
5041 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5042 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5043 Check for integer overflow.
5044 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5045 since it's now a duplicate of the other. This is more of
5046 a character than a buffer op, so better that it's in character.c.
5047 * fns.c, print.c: Adjust to above changes.
5048
2ff916cb
PE
50492011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5052
f1b54466
PE
50532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5054
fb1ac845
PE
5055 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5056 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5057 (x_clipboard_manager_save): Now static.
5058 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5059
f1b54466
PE
5060 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5061 (crypto_hash_function): Now static.
5062 Fix pointer signedness problems. Avoid unnecessary initializations.
5063
a9f737ee
CY
50642011-05-27 Chong Yidong <cyd@stupidchicken.com>
5065
5066 * termhooks.h (Vselection_alist): Make it terminal-local.
5067
5068 * terminal.c (create_terminal): Initialize it.
5069
5070 * xselect.c: Support for clipboard managers.
5071 (Vselection_alist): Move to termhooks.h as terminal-local var.
5072 (LOCAL_SELECTION): New macro.
5073 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5074 (symbol_to_x_atom): Remove gratuitous arg.
5075 (x_handle_selection_request, lisp_data_to_selection_data)
5076 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5077 (x_own_selection, x_get_local_selection, x_convert_selection):
5078 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5079 (some_frame_on_display): Delete unused function.
5080 (Fx_own_selection_internal, Fx_get_selection_internal)
5081 (Fx_disown_selection_internal, Fx_selection_owner_p)
5082 (Fx_selection_exists_p): New optional frame arg.
5083 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5084 (x_handle_selection_clear): Don't treat other terminals with the
5085 same keyboard specially. Use the terminal-local Vselection_alist.
5086 (x_clear_frame_selections): Use Frun_hook_with_args.
5087
5088 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5089
5090 * xterm.h: Add support for those atoms.
5091
e067f0c1
CY
50922011-05-26 Chong Yidong <cyd@stupidchicken.com>
5093
5094 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5095 (converted_selections, conversion_fail_tag): New global variables.
5096 (x_selection_request_lisp_error): Free the above.
5097 (x_get_local_selection): Remove unnecessary code.
5098 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5099 of converted selections stored in converted_selections.
5100 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5101 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5102 (x_convert_selection): New function.
5103 (x_handle_selection_event): Simplify.
5104 (x_get_foreign_selection): Don't ignore incoming requests while
5105 waiting for an answer; this will fail when we implement
5106 SAVE_TARGETS, and seems unnecessary anyway.
5107 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5108 (Vx_sent_selection_functions): Doc fix.
5109
0f4aebc0
LL
51102011-05-26 Leo Liu <sdl.web@gmail.com>
5111
5112 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5113
e61124cd
YM
51142011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5115
5116 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5117
5118 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5119 for fringe update if it has periodic bitmap.
ac389d0c 5120 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5121 and fringe_bitmap_periodic_p.
5122
5123 * fringe.c (get_fringe_bitmap_data): New function.
5124 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5125 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5126 row. Mark glyph row for fringe update if periodicity changed.
5127
5128 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5129 for fringe update unless it has periodic bitmap.
5130
f16d9837
KH
51312011-05-25 Kenichi Handa <handa@m17n.org>
5132
5133 * xdisp.c (get_next_display_element): Set correct it->face_id for
5134 a static composition.
5135
e1b90ef6
LL
51362011-05-24 Leo Liu <sdl.web@gmail.com>
5137
5138 * deps.mk (fns.o):
5139 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5140
5141 * fns.c (crypto_hash_function, Fsha1): New function.
5142 (Fmd5): Use crypto_hash_function.
5143 (syms_of_fns): Add Ssha1.
5144
7400048f
PE
51452011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5146
5147 * gnutls.c: Remove unused macros.
5148 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5149 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5150 Remove macros that are defined and never used.
5151 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5152
abb71cf4
CY
51532011-05-22 Chong Yidong <cyd@stupidchicken.com>
5154
5155 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5156 (Fx_get_selection_internal): Minor cleanup.
5157 (Fx_own_selection_internal): Rename arguments for consistency with
5158 select.el.
5159
6307db39
PE
51602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5161
5162 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5163
f3d4e0a4
CY
51642011-05-22 Chong Yidong <cyd@stupidchicken.com>
5165
5166 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5167
4d8ade89
YM
51682011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5169
5170 * dispnew.c (scrolling_window): Don't exclude the case that the
5171 last enabled row in the desired matrix touches the bottom boundary.
5172
32078c8d
GM
51732011-05-21 Glenn Morris <rgm@gnu.org>
5174
5175 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5176 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5177 and add some more files.
32078c8d 5178
7285dc67
EZ
51792011-05-20 Eli Zaretskii <eliz@gnu.org>
5180
5181 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5182 report_file_error introduced by the change from 2011-05-07.
5183
89d1bd22
PE
51842011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5185
5186 * systime.h (Time): Define only if emacs is defined.
5187 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5188 where the include path doesn't have X11/X.h by default. See
5189 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5190
e23640bb 51912011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5192
5193 * composite.c (find_automatic_composition): Fix previous change.
5194
b9704ad9
GM
51952011-05-20 Glenn Morris <rgm@gnu.org>
5196
5197 * lisp.mk: New file, split from Makefile.in.
5198 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5199 (shortlisp): Remove.
5200 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5201
4a720484
GM
52022011-05-19 Glenn Morris <rgm@gnu.org>
5203
5204 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5205 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5206 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5207 (lisp): Set the order to that of loadup.el.
5208 (shortlisp): Make it a copy of $lisp.
5209 (SOME_MACHINE_LISP): Remove.
5210 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5211 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5212
a28d4396
KH
52132011-05-18 Kenichi Handa <handa@m17n.org>
5214
5215 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5216 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5217 (find_automatic_composition): Mostly rewrite for efficiency.
5218
a2b1fa8e
JB
52192011-05-18 Juanma Barranquero <lekktu@gmail.com>
5220
5221 * makefile.w32-in: Update dependencies.
5222
8e1f5610
CS
52232011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5224
5225 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5226 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5227
7025ee00 52282011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5229
cdfa6eab
PE
5230 Fix some integer overflow issues, such as string length overflow.
5231
06d6db33
PE
5232 * insdel.c (count_size_as_multibyte): Check for string overflow.
5233
2b4560a8
PE
5234 * character.c (lisp_string_width): Check for string overflow.
5235 Use EMACS_INT, not int, for string indexes and lengths; in
5236 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5237 the resulting string length overflows an EMACS_INT; instead,
5238 report a string overflow if no precision given. When checking for
5239 precision exhaustion, use a check that cannot possibly have
5240 integer overflow. (Bug#8675)
5241 * character.h (lisp_string_width): Adjust to new signature.
5242
cb93f9be
PE
5243 * alloc.c (string_overflow): New function.
5244 (Fmake_string): Use it. This doesn't change behavior, but saves
5245 a few bytes and will simplify future changes.
5246 * character.c (string_escape_byte8): Likewise.
5247 * lisp.h (string_overflow): New decl.
5248
1a1f3366
PE
5249 Fixups, following up to the user-interface timestamp change.
5250 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5251 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5252 * msdos.c (mouse_get_pos): Likewise.
5253 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5254 * w32gui.h (Time): Define by including "systime.h" rather than by
5255 declaring it ourselves. (Bug#8664)
5256
d4e3e4d3
PE
5257 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5258 * image.c (clear_image_cache): Likewise.
5259
f6a24d19
PE
5260 * term.c (term_mouse_position): Don't assume time_t wraparound.
5261
08dc5ae6
PE
5262 Be more systematic about user-interface timestamps.
5263 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5264 and sometimes 'EMACS_UINT', to represent these timestamps.
5265 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5266 This makes the code easier to follow, and makes it easier to catch
5267 integer overflow bugs such as Bug#8664.
5268 * frame.c (Fmouse_position, Fmouse_pixel_position):
5269 Use Time, not unsigned long, for user-interface timestamps.
5270 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5271 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5272 * keyboard.h (last_event_timestamp): Likewise.
5273 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5274 * menu.h (xmenu_show): Likewise.
5275 * term.c (term_mouse_position): Likewise.
5276 * termhooks.h (struct input_event.timestamp): Likewise.
5277 (struct terminal.mouse_position_hook): Likewise.
5278 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5279 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5280 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5281 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5282 what it was before.
5283 * menu.h, termhooks.h: Include "systime.h", for Time.
5284
8e55734a
PE
5285 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5286 Don't assume that the difference between two unsigned long values
5287 can fit into an integer. At this point, we know button_down_time
5288 <= event->timestamp, so the difference must be nonnegative, so
5289 there's no need to cast the result if double-click-time is
5290 nonnegative, as it should be; check that it's nonnegative, just in
5291 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5292 apart (about 25 days). (Bug#8664)
8e55734a 5293
841f1b75 5294 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5295 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5296
3e26f69c
PE
5297 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5298 that always fit in int. Use a sentinel instead of a counter, to
5299 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5300 * frame.h (struct frame): Use int for menu_bar_items_used
5301 instead of EMACS_INT, since it always fits in int.
3e26f69c 5302
5cc152c0
PE
5303 * menu.c (grow_menu_items): Check for int overflow.
5304
d89eb65e
PE
5305 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5306
5235bd3e
PE
5307 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5308 Before, the code was not consistent. These values cannot exceed
5309 2**31 - 1 so there's no need to make them unsigned.
5310 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5311 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5312 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5313 as modifiers.
5314 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5315
bc827e23
PE
5316 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5317 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5318 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5319 presumably because the widths might not match.
5320
78eb494e
PE
5321 * window.c (size_window): Avoid needless test at loop start.
5322
04f2d78b
CB
53232011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5324
5325 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5326
d2fc7e3d 53272011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5328
5329 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5330
d2fc7e3d 53312011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5332
5333 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5334 `width' to `bar_area_x' and `bar_area_width', respectively.
5335 (x_scroll_run): Take account of fringe background extension.
5336
04f2d78b
CB
5337 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5338 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5339 `bar_area_width', respectively.
5340 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5341 background extension.
5342
79b70037
GM
53432011-05-10 Jim Meyering <meyering@redhat.com>
5344
5345 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5346
2f142cc5
JB
53472011-05-10 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * image.c (Finit_image_library): Return t for built-in image types,
5350 like pbm and xbm. (Bug#8640)
5351
57679c86
AS
53522011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5353
5354 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5355
888c9e86
EZ
53562011-05-07 Eli Zaretskii <eliz@gnu.org>
5357
b0512a1d
EZ
5358 * w32console.c (Fset_screen_color): Doc fix.
5359 (Fget_screen_color): New function.
5360 (syms_of_ntterm): Defsubr it.
5361
7285dc67
EZ
5362 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5363 unlink the temporary file if Fcall_process didn't create it in the
5364 first place.
5365 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5366 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5367 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5368 cue to call_process_cleanup not to close that handle.
5369
4d3fcc8e
BK
53702011-05-07 Ben Key <bkey76@gmail.com>
5371
5372 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5373 one of two shell specific rules, either bootstrap-temacs-CMD or
5374 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5375 to the previous implementation of the bootstrap-temacs rule.
5376 The bootstrap-temacs-CMD rule is similar to the previous
5377 implementation of the bootstrap-temacs rule except that it
5378 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5379 variable.
5380
5381 These changes, along with some changes to nt/configure.bat,
5382 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5383 earlier fix to add support for --cflags and --ldflags options
5384 that include quotes so that it works whether make uses cmd or
5385 sh as the shell.
5386
b4289b64
MA
53872011-05-06 Michael Albinus <michael.albinus@gmx.de>
5388
5389 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5390 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5391 is a constant.
5392 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5393 a string. Handle both cases.
5394 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5395 (Fdbus_register_method): Use Qinvalid_function.
5396
af4c0e28
JB
53972011-05-06 Juanma Barranquero <lekktu@gmail.com>
5398
5399 * makefile.w32-in: Update dependencies.
5400 (LISP_H): Add inttypes.h and stdin.h.
5401 (PROCESS_H): Add unistd.h.
5402
c51453d9
EZ
54032011-05-06 Eli Zaretskii <eliz@gnu.org>
5404
5405 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5406 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5407
8ff0ac3c 54082011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5409
4c4b566b
PE
5410 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5411
aab2b9b5
PE
5412 * term.c (vfatal): Remove stray call to va_end.
5413 It's not needed and the C Standard doesn't allow it here anyway.
5414
c378da0b
PE
5415 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5416 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5417
288b08c7
PE
5418 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5419 bytes.
5420
e3601888
PE
5421 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5422
db6c0e74
PE
5423 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5424
dd5963ea
PE
5425 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5426
88c9450f
PE
5427 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5428
2f9442b8
PE
5429 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5430
c032b5f8
PE
5431 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5432 * charset.c (Fdefine_charset_internal): Don't initialize
5433 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5434 32-bit int (Bug#8600).
a108c10b
PE
5435
5436 * lread.c (read_integer): Be more consistent with string-to-number.
5437 Use string_to_number to do the actual conversion; this avoids
5438 rounding errors and fixes some other screwups. Without this fix,
5439 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5440 (digit_to_number): Move earlier, for benefit of read_integer.
5441 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5442 not a digit in any supported base. (Bug#8602)
a108c10b 5443
ad5f9eea
PE
5444 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5445
aec1708a
PE
5446 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5447 to match comment at start of function. This also removes a
5448 GCC warning about overflow in a 32+64-bit port.
5449
47be4ab5
PE
5450 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5451
371cac43
PE
5452 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5453 Reported by Stefan Monnier in
5454 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5455 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5456 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5457
d01a7826
PE
5458 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5459 (EMACS_UINTPTR): Likewise, with uintptr_t.
5460
7fd47d5c
PE
5461 * lisp.h: Prefer 64-bit EMACS_INT if available.
5462 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5463 on 32-bit hosts that have 64-bit int, so that they can access
5464 large files.
122b0c86
PE
5465 However, temporarily disable this change unless the temporary
5466 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5467
8727937b
PE
5468 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5469
8ac068ac
PE
5470 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5471 This removes an assumption that EMACS_INT and long are the same
5472 width as pointers. The assumption is true for Emacs porting targets
5473 now, but we want to make other targets possible.
5474 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5475 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5476 In the rest of the code, change types of integers that hold casted
5477 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5478 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5479 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5480 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5481 No need to cast type when ORing.
5482 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5483 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5484 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5485 assume EMACS_INT is the same width as char *.
5486 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5487 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5488 Remove no-longer-needed casts.
5489 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5490 (xg_tool_bar_help_callback, xg_make_tool_item):
5491 Use EMACS_INTPTR to hold an integer
5492 that will be cast to void *; this can avoid a GCC warning
5493 if EMACS_INT is not the same width as void *.
5494 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5495 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5496 (current_message_1, set_message_1):
5497 Use a local to convert to proper width without a cast.
5498 * xmenu.c (dialog_selection_callback): Likewise.
5499
ede49d71
PE
5500 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5501 Also, don't assume VALBITS / RAND_BITS is less than 5,
5502 and don't rely on undefined behavior when shifting a 1 left into
5503 the sign bit.
5504 * lisp.h (get_random): Change signature to match.
5505
2f30ecd0
PE
5506 * lread.c (hash_string): Use size_t, not int, for hash computation.
5507 Normally we prefer signed values; but hashing is special, because
5508 it's better to use unsigned division on hash table sizes so that
5509 the remainder is nonnegative. Also, size_t is the natural width
5510 for hashing into memory. The previous code used 'int', which doesn't
5511 retain enough info to hash well into very large tables.
5512 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5513
2a866e7b
PE
5514 * dbusbind.c: Don't possibly lose pointer info when converting.
5515 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5516 Use XPNTR rather than XHASH, so that the high-order bits of
5517 the pointer aren't lost when converting through void *.
5518
51639eac
PE
5519 * eval.c (Fautoload): Don't double-shift a pointer.
5520
92394119
PE
5521 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5522
dbdb9a7c
JB
55232011-05-06 Juanma Barranquero <lekktu@gmail.com>
5524
5525 * gnutls.c (DEF_GNUTLS_FN):
5526 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5527
db7a0b4f
AS
55282011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5529
5530 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5531 marker. (Bug#8610)
5532
f7ff1b0f 55332011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5534
5535 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5536 New version that can reserve upto 2GB of heap space.
5537
f7ff1b0f 55382011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5539
5540 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5541
639c109b
TZ
55422011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5543
5544 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5545 `gnutls_certificate_set_x509_key_file'.
5546
d2127135
JB
55472011-05-05 Juanma Barranquero <lekktu@gmail.com>
5548
5549 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5550 Update dependencies.
5551
e968f4f3
JB
55522011-05-04 Juanma Barranquero <lekktu@gmail.com>
5553
5554 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5555 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5556 Remove unused parameter `fildes'.
5557 * process.c (read_process_output, send_process): Don't pass it.
5558
84d358f0
JB
55592011-05-04 Juanma Barranquero <lekktu@gmail.com>
5560
5561 Fix previous change: the library cache is defined in w32.c.
5562 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5563 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5564
0898ca10
JB
55652011-05-04 Juanma Barranquero <lekktu@gmail.com>
5566
5567 Implement dynamic loading of GnuTLS on Windows.
5568
5569 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5570 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5571 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5572 Declare.
5573
5574 * gnutls.c (Qgnutls_dll): Define.
5575 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5576 (gnutls_*): Declare function pointers.
5577 (init_gnutls_functions): New function to initialize function pointers.
5578 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5579 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5580 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5581 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5582 (emacs_gnutls_write, emacs_gnutls_read)
5583 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5584 (Fgnutls_available_p): New function.
5585 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5586 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5587 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5588
5589 * image.c: Include w32.h.
5590 (Vimage_type_cache): Delete.
5591 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5592 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5593 (w32_delayed_load): Move to w32.c.
5594
5595 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5596
5597 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5598 (w32_delayed_load): Move from image.c. When loading a library, record
5599 its filename in the :loaded-from property of the library id.
5600 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5601 Initialize and staticpro them.
5602 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5603
5604 * process.c: Include lisp.h before w32.h, not after.
5605 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5606 instead of gnutls_record_check_pending.
5607
5608 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5609
ff4de4aa
TZ
56102011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5611
5612 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5613 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5614 as passed in.
5615
abe95abb
JD
56162011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5617
5618 * xterm.c (x_set_frame_alpha): Do not set property on anything
5619 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5620
e16e55d4
JB
56212011-05-02 Juanma Barranquero <lekktu@gmail.com>
5622
5623 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5624
bafcf6a5
JB
56252011-05-02 Juanma Barranquero <lekktu@gmail.com>
5626
5627 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5628 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5629 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5630 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5631 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5632 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5633 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5634 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5635 (Qgnutls_bootprop_callbacks_verify): Make static.
5636
e7a6747f
AS
56372011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5638
19ed11ba
AS
5639 * callproc.c: Indentation fixup.
5640
e7a6747f 5641 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5642 (wait_for_termination, interruptible_wait_for_termination):
5643 Move after wait_for_termination_1.
e7a6747f 5644
1ef14cb4
LMI
56452011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5646
5647 * sysdep.c (interruptible_wait_for_termination): New function
5648 which is like wait_for_termination, but allows keyboard
5649 interruptions.
5650
5651 * callproc.c (Fcall_process): Add (:file "file") as an option for
5652 the STDOUT buffer.
5653 (Fcall_process_region): Ditto.
5654
330d880c
EZ
56552011-04-30 Eli Zaretskii <eliz@gnu.org>
5656
8db90b73
EZ
5657 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5658 rather than `XVECTOR (FOO)->size'.
5659
330d880c
EZ
5660 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5661 inttypes.h, as a gnulib replacement is used if it not available in
5662 system headers.
5663
15cbd324
EZ
56642011-04-21 Eli Zaretskii <eliz@gnu.org>
5665
5666 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5667 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5668 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5669
5670 * coding.c (coding_alloc_by_realloc): Error out if destination
5671 will grow beyond MOST_POSITIVE_FIXNUM.
5672 (decode_coding_emacs_mule): Abort if there isn't enough place in
5673 charbuf for the composition carryover bytes. Reserve an extra
5674 space for up to 2 characters produced in a loop.
5675 (decode_coding_iso_2022): Abort if there isn't enough place in
5676 charbuf for the composition carryover bytes.
5677
56782011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5679
ae940cca
EZ
5680 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5681 aborting when %lld or %lll format is passed.
5682 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5683 %llo or %llx format is passed. (Bug#8545)
5684
03ab8921
EZ
5685 * window.c (window_scroll_line_based): Use a marker instead of
5686 simple variables to record original value of point. (Bug#7952)
5687
afda1437
EZ
5688 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5689 produced by %s or %c overflows available buffer space. (Bug#8545)
5690
f76dee0c
PE
56912011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5692
5693 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5694 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5695
fdc5744d
JB
56962011-04-28 Juanma Barranquero <lekktu@gmail.com>
5697
5698 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5699
638f053a
JB
57002011-04-28 Juanma Barranquero <lekktu@gmail.com>
5701
5702 * keyboard.c (Qdelayed_warnings_hook): Define.
5703 (command_loop_1): Run `delayed-warnings-hook'
5704 if Vdelayed_warnings_list is non-nil.
5705 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5706 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5707
d178f871
EZ
57082011-04-28 Eli Zaretskii <eliz@gnu.org>
5709
5710 * doprnt.c (doprnt): Don't return value smaller than the buffer
5711 size if the message was truncated. (Bug#8545).
5712
b124fd93
JB
57132011-04-28 Juanma Barranquero <lekktu@gmail.com>
5714
5715 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5716 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5717
e810457d
PE
57182011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5721
ea51cceb
JB
57222011-04-27 Juanma Barranquero <lekktu@gmail.com>
5723
5724 * makefile.w32-in: Update dependencies.
5725
94dcfacf
EZ
57262011-04-27 Eli Zaretskii <eliz@gnu.org>
5727
5728 Improve `doprnt' and its usage. (Bug#8545)
5729 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5730 `format_end'. Remove support for %l as a conversion specifier.
5731 Don't use xrealloc. Improve diagnostics when the %l size modifier
5732 is used. Update the commentary.
5733
5734 * eval.c (verror): Simplify calculation of size_t.
5735
5736 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5737 messages.
5738
f61f41d7
PE
57392011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5740
5741 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5742 change.
5743
96fb4434
PE
57442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5745
5746 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5747 This makes this file independent of the recent pseudovector change.
5748
671875da 57492011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5750
69e9b5a3
PE
5751 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5752
b5f869a7 5753 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5754 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5755 Remove unused local.
c8926152 5756 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5757
841a1577 5758 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5759 GCC 4.6.0 optimizes based on type-based alias analysis.
5760 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5761 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5762 != &v->size, and therefore "v->size = 1; b->size = 2; return
5763 v->size;" must therefore return 1. This assumption is incorrect
5764 for Emacs, since it type-puns struct Lisp_Vector * with many other
5765 types. To fix this problem, this patch adds a new type struct
f904488f 5766 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5767 and pseudovectors, and helps optimizing compilers not get fooled
5768 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5769 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5770 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5771 the size member.
eab3844f
PE
5772 (XSETPVECTYPE): Rewrite in terms of new macro.
5773 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5774 This is a bit clearer, and further avoids the possibility of
5775 undesirable aliasing.
5776 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5777 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5778 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5779 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5780 (ASIZE): Now uses header.size rather than size.
5781 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5782 to avoid the hassle of writing XVECTOR (foo)->header.size.
5783 (struct vectorlike_header): New type.
eab3844f
PE
5784 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5785 object, to help avoid aliasing.
5786 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5787 (SUBRP): Likewise, since Lisp_Subr is a special case.
5788 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5789 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5790 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5791 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5792 changed to be "header.size" and "header.next".
5793 * buffer.h (struct buffer): Likewise.
5794 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5795 * frame.h (struct frame): Likewise.
5796 * process.h (struct Lisp_Process): Likewise.
5797 * termhooks.h (struct terminal): Likewise.
5798 * window.c (struct save_window_data, struct saved_window): Likewise.
5799 * window.h (struct window): Likewise.
5800 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5801 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5802 * buffer.c (init_buffer_once): Likewise.
5803 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5804 special case.
5805 * process.c (Fformat_network_address): Use local var for size,
5806 for brevity.
5807
0df1eac5
PE
5808 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5809
847ab9d1 5810 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5811 * data.c (atof): Remove decl; no longer used or needed.
5812 (digit_to_number): Move to lread.c.
5813 (Fstring_to_number): Use new string_to_number function, to be
5814 consistent with how the Lisp reader treats infinities and NaNs.
5815 Do not assume that floating-point numbers represent EMACS_INT
5816 without losing information; this is not true on most 64-bit hosts.
5817 Avoid double-rounding errors, by insisting on integers when
5818 parsing non-base-10 numbers, as the documentation specifies.
5819 * lisp.h (string_to_number): New decl, replacing ...
5820 (isfloat_string): Remove.
bc0a5c13 5821 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5822 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5823 appears to have been a coding error. Similarly, do not accept
5824 strings like +-1e0 as floating point numbers. Do not report
5825 overflow for integer overflows unless the base is not 10 which
5826 means we have no simple and reliable way to continue.
5827 Break out the floating-point parsing into a new
5828 function string_to_number, so that Fstring_to_number parses
5829 floating point numbers consistently with the Lisp reader.
04f2d78b 5830 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5831 (E_CHAR, EXP_INT): Remove, replacing with ...
5832 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5833 (string_to_number): New function, replacing isfloat_string.
5834 This function checks for valid syntax and produces the resulting
5835 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5836 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5837 so that overflow for non-base-10 numbers is reported only when
5838 there's no portable and simple way to convert to floating point.
452f4150 5839
67769ffc
PE
5840 * textprop.c (set_text_properties_1): Rewrite for clarity,
5841 and to avoid GCC warning about integer overflow.
5842
c20db43f
PE
5843 * intervals.h (struct interval): Use EMACS_INT for members
5844 where EMACS_UINT might cause problems. See
5845 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5846 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5847 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5848 All uses changed.
37aa2f85
PE
5849 (offset_intervals): Tell GCC not to worry about length overflow
5850 when negating a negative length.
c20db43f 5851
2538aa2f
PE
5852 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5853 (overrun_check_free): Likewise.
5854
f2d3008d
PE
5855 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5856 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5857 word size.
5858
ec8df744
PE
5859 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5860 (gnutls_make_error): Rename local to avoid shadowing.
5861 (gnutls_emacs_global_deinit): ifdef out; not used.
5862 (Fgnutls_boot): Use const for pointer to readonly storage.
5863 Comment out unused local. Fix pointer signedness problems.
5864
640ee02d
PE
5865 * lread.c (openp): Don't stuff size_t into an 'int'.
5866 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5867 about possible signed overflow.
5868
6048fb2a
PE
5869 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5870 (GDK_KEY_g): Don't define if already defined.
5871 (xg_prepare_tooltip): Avoid pointer signedness problem.
5872 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5873
fa3c87e1
PE
5874 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5875 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5876
2172544b
PE
5877 * xfns.c (Fx_window_property): Simplify a bit,
5878 to make a bit faster and to avoid GCC 4.6.0 warning.
5879 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5880
9b821a21
PE
5881 * fns.c (internal_equal): Don't assume size_t fits in int.
5882
3c616cfa
PE
5883 * alloc.c (compact_small_strings): Tighten assertion a little.
5884
c2982e87
PE
5885 Replace pEd with more-general pI, and fix some printf arg casts.
5886 * lisp.h (pI): New macro, generalizing old pEd macro to other
5887 conversion specifiers. For example, use "...%"pI"d..." rather
5888 than "...%"pEd"...".
5889 (pEd): Remove. All uses replaced with similar uses of pI.
5890 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5891 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5892 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5893 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5894 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5895 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5896 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5897 64-bit hosts.
5898 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5899 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5900 * print.c (safe_debug_print, print_object): Likewise.
5901 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5902 to int.
6f04d126
PE
5903 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5904 avoiding the 0 flag, which is not portable.
c2982e87
PE
5905 * process.c (Fmake_network_process): Use pI to avoid cast.
5906 * region-cache.c (pp_cache): Likewise.
5907 * xdisp.c (decode_mode_spec): Likewise.
5908 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5909 behavior on 64-bit hosts with printf arg.
6f04d126 5910 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5911 (x_stop_queuing_selection_requests): Likewise.
5912 (x_get_window_property): Don't truncate byte count to an 'int'
5913 when tracing.
0b432f21 5914
5e073ec7
PE
5915 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5916 here, since it parses constructs like leading '-' and spaces,
5917 which are not wanted; and it overflows with large numbers.
5918 Instead, simply match F[0-9]+, which is what is wanted anyway.
5919
36372bf9
PE
5920 * alloc.c: Remove unportable assumptions about struct layout.
5921 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5922 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5923 (allocate_vectorlike, make_pure_vector): Use the new macros,
5924 plus offsetof, to remove unportable assumptions about struct layout.
5925 These assumptions hold on all porting targets that I know of, but
5926 they are not guaranteed, they're easy to remove, and removing them
5927 makes further changes easier.
5928
0b432f21
PE
5929 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5930 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5931 (string_overrun_cookie): Now const. Use initializers that
5932 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5933 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5934 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5935 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5936 multiple of sizeof (EMACS_INT); it need not be, if
5937 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5938 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5939
895009e1
JB
59402011-04-26 Juanma Barranquero <lekktu@gmail.com>
5941
5942 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5943
6a7a1b0b
TZ
59442011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5945
5946 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5947 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5948 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5949
841a1577 59502011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5951
5952 * lisp.h (Qdebug): List symbol.
895009e1 5953 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5954 * keyboard.c (debug-on-event): New variable.
5955 (handle_user_signal): Break into debugger when debug-on-event
5956 matches the current signal symbol.
5957
f2d3ba6f
DN
59582011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5959
5960 * alloc.c (check_sblock, check_string_bytes)
5961 (check_string_free_list): Convert to standard C.
5962
42ce4c63
TZ
59632011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5964
5965 * w32.c (emacs_gnutls_push): Fix typo.
5966
825cd63c
EZ
59672011-04-25 Eli Zaretskii <eliz@gnu.org>
5968
fb11d64d
EZ
5969 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5970 "cast to pointer from integer of different size".
5971
825cd63c
EZ
5972 Improve doprnt and its use in verror. (Bug#8545)
5973 * doprnt.c (doprnt): Document the set of format control sequences
5974 supported by the function. Use SAFE_ALLOCA instead of always
5975 using `alloca'.
5976
5977 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5978 is one byte too soon. Don't use xrealloc; instead xfree and
5979 xmalloc anew.
5980
e061a11b
TZ
59812011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5982
5983 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5984 callbacks stage.
5985
5986 * gnutls.c: Renamed global_initialized to
5987 gnutls_global_initialized. Added internals for the
5988 :verify-hostname-error, :verify-error, and :verify-flags
5989 parameters of `gnutls-boot' and documented those parameters in the
5990 docstring. Start callback support.
9173deec
JB
5991 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5992 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5993 on error. Return error code.
e061a11b
TZ
5994 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5995 (emacs_gnutls_read): Likewise.
5996 (Fgnutls_boot): Return handshake error code.
5997 (emacs_gnutls_handle_error): New function.
5998 (wsaerror_to_errno): Likewise.
5999
6000 * w32.h (emacs_gnutls_pull): Add prototype.
6001 (emacs_gnutls_push): Likewise.
6002
6003 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6004 (emacs_gnutls_push): Likewise.
6005
60062011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6007
6008 * process.c (wait_reading_process_output): Check if GnuTLS
6009 buffered some data internally if no FDs are set for TLS
6010 connections.
6011
6012 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6013 (LIBS): Link to USER_LIBS.
6014 ($(BLD)/gnutls.$(0)): New target.
6015
fa6996bc
EZ
60162011-04-24 Eli Zaretskii <eliz@gnu.org>
6017
eb35682e
EZ
6018 * xdisp.c (handle_single_display_spec): Rename the
6019 display_replaced_before_p argument into display_replaced_p, to
6020 make it consistent with the commentary. Fix typos in the
6021 commentary.
6022
e2ad650c
EZ
6023 * textprop.c (syms_of_textprop): Remove dead code.
6024 (copy_text_properties): Delete obsolete commentary about an
6025 interface that was deleted long ago. Fix typos in the description
6026 of arguments.
6027
1b2de274
EZ
6028 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6029 to changes in oldXMenu/XMenu.h from 2011-04-16.
6030 <menu_help_message, prev_menu_help_message>: Constify.
6031 (IT_menu_make_room): menu->help_text is now `const char **';
6032 adjust.
6033
6034 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6035 to changes in oldXMenu/XMenu.h from 2011-04-16.
6036 (struct XMenu): Declare `help_text' `const char **'.
6037
6038 * xfaces.c <Qunspecified>: Make extern again.
6039
6040 * syntax.c: Include sys/types.h before including regex.h, as
6041 required by Posix.
6042
762b15be
EZ
6043 * doc.c (get_doc_string): Improve the format passed to `error'.
6044
6045 * doprnt.c (doprnt): Improve commentary.
6046
6047 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6048
6049 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6050 them with etags.
6051
f1052e5d
EZ
6052 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6053 changes in globals.h immediately force recompilation.
762b15be
EZ
6054 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6055 $(CURDIR)/s/ms-w32.h.
6056 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6057
fa6996bc
EZ
6058 * character.c (Fchar_direction): Function deleted.
6059 (syms_of_character): Don't defsubr it.
6060 <char-direction-table>: Deleted.
6061
e6c3da20
EZ
60622011-04-23 Eli Zaretskii <eliz@gnu.org>
6063
6064 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6065 * doprnt.c: Include limits.h.
6066 (SIZE_MAX): New macro.
04f2d78b
CB
6067 (doprnt): Return a size_t value. 2nd arg is now size_t.
6068 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6069 Improve overflow protection. Support `l' modifier for integer
6070 conversions. Support %l conversion. Don't assume an EMACS_INT
6071 argument for integer conversions and for %c.
6072
6073 * lisp.h (doprnt): Restore prototype.
6074
6075 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6076 $(SRC)/character.h.
6077
6078 * Makefile.in (base_obj): Add back doprnt.o.
6079
6080 * deps.mk (doprnt.o): Add back prerequisites.
6081 (callint.o): Depend on character.h.
6082
6083 * eval.c (internal_lisp_condition_case): Include the handler
6084 representation in the error message.
6085 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6086 when breaking from the loop.
6087
6088 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6089
6090 * callint.c (Fcall_interactively): When displaying error message
6091 about invalid control letter, pass the character's codepoint, not
6092 a pointer to its multibyte form. Improve display of the character
6093 in octal and display also its hex code.
6094
6095 * character.c (char_string): Use %x to display the (unsigned)
6096 codepoint of an invalid character, to avoid displaying a bogus
6097 negative value.
6098
6099 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6100 `error', not SYMBOL_NAME itself.
6101
6102 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6103 character arguments to `error'.
6104
6105 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6106 to `error' in error message about FINAL_CHAR argument. Make sure
6107 FINAL_CHAR is a character, and use %c when it is passed as
6108 argument to `error'.
6109
4ffd0d6b 61102011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6111
6112 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6113
6114 * w32.c: Include <time.h>.
6115 (sys_localtime): New function.
6116
4ffd0d6b 61172011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6118
6119 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6120
4ffd0d6b 6121 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6122
4ffd0d6b 61232011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6124
4ffd0d6b
GM
6125 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6126 zombies (Bug#8467).
aac0c6e3 6127
04c56954
EZ
61282011-04-19 Eli Zaretskii <eliz@gnu.org>
6129
6130 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6131 gl_state.e_property when gl_state.object is Qt.
6132
6133 * insdel.c (make_gap_larger): Remove limitation of buffer size
6134 to <= INT_MAX.
6135
16a43933
CY
61362011-04-18 Chong Yidong <cyd@stupidchicken.com>
6137
6138 * xdisp.c (lookup_glyphless_char_display)
6139 (produce_glyphless_glyph): Handle cons cell entry in
6140 glyphless-char-display.
6141 (Vglyphless_char_display): Document it.
6142
6143 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6144 glyphless-char-display.
6145
4581706e
CY
61462011-04-17 Chong Yidong <cyd@stupidchicken.com>
6147
6148 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6149
6150 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6151
6152 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6153 definition for no-X builds.
6154
4887c6e2 61552011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6156
fd35b6f9
PE
6157 Static checks with GCC 4.6.0 and non-default toolkits.
6158
5c1ccb01
PE
6159 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6160
006c5daa
PE
6161 * process.c (keyboard_bit_set): Define only if SIGIO.
6162 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6163 (send_process): Repair possible setjmp clobbering.
6164
efc736d3
PE
6165 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6166
4e2fe2e6
PE
6167 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6168
f97334a2
PE
6169 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6170
4e75f29d
PE
6171 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6172 Define only if needed.
6173
90efadd1
PE
6174 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6175 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6176 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6177
3c647824
PE
6178 * dispextern.h (struct redisplay_interface): Rename param
6179 to avoid shadowing.
e264f262 6180 * termhooks.h (struct terminal): Likewise.
761383f4 6181 * xterm.c (xembed_send_message): Likewise.
3c647824 6182
b58c5c4a
PE
6183 * insdel.c (make_gap_smaller): Define only if
6184 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6185
cad59032
PE
6186 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6187 it.
6188
c339dc2e
PE
6189 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6190 so that we aren't warned about unused symbols.
6191
91a3e27b
PE
6192 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6193
399c71d3 6194 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6195
8ffc96f5
PE
6196 * xfns.c (x_real_positions): Mark locals as initialized.
6197
eef9bc79
PE
6198 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6199
098db9dd
PE
6200 * xterm.c: Fix problems found by static analysis with other toolkits.
6201 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6202 (x_dispatch_event): Declare static if USE_GTK, and
6203 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6204 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6205 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6206 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6207 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6208
eb18f6cc
PE
6209 * xmenu.c (menu_help_callback): Pointer type fixes.
6210 Use const pointers when pointing at readonly data. Avoid pointer
6211 signedness clashes.
6212 (FALSE): Remove unused macro.
6213 (update_frame_menubar): Remove unused decl.
6214
1fe72bf8
PE
6215 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6216
60d9e1db
PE
6217 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6218 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6219 (single_menu_item): Rename local to avoid shadowing.
6220
39261c26
PE
6221 * keyboard.c (make_lispy_event): Remove unused local var.
6222
018c5e19
PE
6223 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6224 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6225
63d2b86e
PE
6226 * bitmaps: Change bitmaps from unsigned char back to the X11
6227 compatible char. Avoid the old compiler warnings about
6228 out-of-range initializers by using, for example, '\xab' rather
6229 than 0xab.
6230
aefd87e1
PE
6231 * xgselect.c (xgselect_initialize): Check vs interface
6232 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6233
bf501fb9
PE
6234 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6235
e9829fdf
PE
6236 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6237 to read-only memory.
6238
1086c095
PE
6239 * fns.c (vector): Remove; this old hack is no longer needed.
6240
2baccd04 6241 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6242 Remove unused var.
dde42981 6243 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6244
72391843 6245 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6246
436c16df 6247 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6248 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6249 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6250
92bb796d 6251 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6252 (x_term_init): Remove local to avoid shadowing.
92bb796d 6253
764430a3 6254 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6255
6256 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6257 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6258
d1dfb56c
EZ
62592011-04-16 Eli Zaretskii <eliz@gnu.org>
6260
c4354cb4
EZ
6261 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6262
d1dfb56c
EZ
6263 Fix regex.c, syntax.c and friends for buffers > 2GB.
6264 * syntax.h (struct gl_state_s): Declare character position members
6265 EMACS_INT.
6266
6267 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6268
04f2d78b
CB
6269 * textprop.c (verify_interval_modification, interval_of):
6270 Declare arguments EMACS_INT.
d1dfb56c
EZ
6271
6272 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6273 EMACS_INT.
6274
6275 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6276
6277 * indent.c (Fvertical_motion): Local variable it_start is now
6278 EMACS_INT.
6279
6280 * regex.c (re_match, re_match_2, re_match_2_internal)
6281 (bcmp_translate, regcomp, regexec, print_double_string)
6282 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6283 (re_compile_pattern, re_exec): Declare arguments and local
6284 variables `size_t' and `ssize_t' and return values `regoff_t', as
6285 appropriate.
6286 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6287 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6288 <compile_stack_type>: `size' and `avail' are now `size_t'.
6289
6290 * regex.h <regoff_t>: Use ssize_t, not int.
6291 (re_search, re_search_2, re_match, re_match_2): Arguments that
6292 specify buffer/string position and length are now ssize_t and
6293 size_t. Return type is regoff_t.
6294
613052cd
BK
62952011-04-16 Ben Key <bkey76@gmail.com>
6296
6297 * nsfont.m: Fixed bugs in ns_get_family and
6298 ns_descriptor_to_entity that were caused by using free to
6299 deallocate memory blocks that were allocated by xmalloc (via
6300 xstrdup). This caused Emacs to crash when compiled with
6301 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6302 --enable-checking=xmallocoverrun). xfree is now used to
6303 deallocate these memory blocks.
6304
4170f62f 63052011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6306
71b41406
PE
6307 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6308
9587a89d
PE
6309 emacs_write: Accept and return EMACS_INT for sizes.
6310 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6311 et seq.
6312 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6313 Accept and return EMACS_INT.
6314 (emacs_gnutls_write): Return the number of bytes written on
6315 partial writes.
6316 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6317 (emacs_read, emacs_write): Remove check for negative size, as the
6318 Emacs source code has been audited now.
9587a89d
PE
6319 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6320 (emacs_read, emacs_write): Use it.
273a5f82
PE
6321 * process.c (send_process): Adjust to the new signatures of
6322 emacs_write and emacs_gnutls_write. Do not attempt to store
6323 a byte offset into an 'int'; it might overflow.
9587a89d 6324 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6325
3e047f51
PE
6326 * sound.c: Don't assume sizes fit in 'int'.
6327 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6328 Return EMACS_INT, not int.
3e047f51 6329 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6330 Accept EMACS_INT, not int.
6331 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6332 record read return values.
6333
cc39a9db
BK
63342011-04-15 Ben Key <bkey76@gmail.com>
6335
c9d0ec6d
JB
6336 * keyboard.c (Qundefined): Don't declare static since it is used
6337 in nsfns.m.
6338 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6339 static since they are used in nsfont.m.
cc39a9db 6340
6c60eb9f
SM
63412011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6342
6343 * process.c (Qprocessp): Don't declare static.
6344 * lisp.h (Qprocessp): Declare again.
6345
7990b61a
JB
63462011-04-15 Juanma Barranquero <lekktu@gmail.com>
6347
6348 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6349
5d4cb038
PE
63502011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6351
8bd7b830 6352 Improve C-level modularity by making more things 'static'.
cd64ea1d 6353
e3b27b31
PE
6354 Don't publish debugger-only interfaces to other modules.
6355 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6356 (verify_bytepos, count_markers): Move decls to the only modules
6357 that need them.
6358 * region-cache.h (pp_cache): Likewise.
6359 * window.h (check_all_windows): Likewise.
6360 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6361
5d4cb038
PE
6362 * sysdep.c (croak): Now static, if
6363 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6364 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6365
6366 * alloc.c (refill_memory_reserve): Now static if
6367 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6368 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6369
e87b6180
PE
6370 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6371 Define only if USE_LUCID.
6372
ac64929e
PE
6373 * xrdb.c (x_customization_string, x_rm_string): Now static.
6374
6f37259d
PE
6375 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6376 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6377
1683e3ab
PE
6378 * xdisp.c (draw_row_with_mouse_face): Now static.
6379 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6380
de9c2632
PE
6381 * window.h (check_all_windows): Mark externally visible.
6382
2b96acb7
PE
6383 * window.c (window_deletion_count): Now static.
6384
6385 * undo.c: Make symbols static if they're not exported.
6386 (last_undo_buffer, last_boundary_position, pending_boundary):
6387 Now static.
6388
50436f33
PE
6389 * textprop.c (interval_insert_behind_hooks): Now static.
6390 (interval_insert_in_front_hooks): Likewise.
6391
64520e5c
PE
6392 * term.c: Make symbols static if they're not exported.
6393 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6394 (max_frame_lines, tty_set_terminal_modes):
6395 (tty_reset_terminal_modes, tty_turn_off_highlight):
6396 (get_tty_terminal): Now static.
6397 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6398 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6399 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6400 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6401 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6402
1fa53021
PE
6403 * sysdep.c: Make symbols static if they're not exported.
6404 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6405 Now static.
6406 (sigprocmask_set, full_mask): Remove; unused.
6407 (wait_debugging): Mark as visible.
6408 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6409 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6410
d4b43b22
PE
6411 * syntax.c (syntax_temp): Define only if !__GNUC__.
6412
b7c513d0
PE
6413 * sound.c (current_sound_device, current_sound): Now static.
6414
989b29ad
PE
6415 * search.c (searchbufs, searchbuf_head): Now static.
6416
13a55a78
PE
6417 * scroll.c (scroll_cost): Remove; unused.
6418 * dispextern.h (scroll_cost): Remove decl.
6419
de68a1fc
PE
6420 * region-cache.h (pp_cache): Mark as externally visible.
6421
40ccffa6
PE
6422 * process.c: Make symbols static if they're not exported.
6423 (process_tick, update_tick, create_process, chan_process):
6424 (Vprocess_alist, proc_buffered_char, datagram_access):
6425 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6426 (deactivate_process): Mark defn as static, as well as decl.
6427 * lisp.h (create_process): Remove decl.
6428 * process.h (chan_process, Vprocess_alist): Remove decls.
6429
ad64fc97
PE
6430 * print.c: Make symbols static if they're not exported.
6431 (print_depth, new_backquote_output, being_printed, print_buffer):
6432 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6433 (print_interval, print_number_index, initial_stderr_stream):
6434 Now static.
6435 * lisp.h (Fprinc): Remove decl.
6436 (debug_output_compilation_hack): Mark as externally visible.
6437
adddb265
PE
6438 * sysdep.c (croak): Move decl from here to syssignal.h.
6439 * syssignal.h (croak): Put it here, so the API can be checked when
6440 'croak' is called from dissociate_if_controlling_tty.
6441
1717ede2
PE
6442 * minibuf.c: Make symbols static if they're not exported.
6443 (minibuf_save_list, choose_minibuf_frame): Now static.
6444 * lisp.h (choose_minibuf_frame): Remove decl.
6445
fa5fb2bc
PE
6446 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6447
1e3890d1
PE
6448 * lread.c: Make symbols static if they're not exported.
6449 (read_objects, initial_obarray, oblookup_last_bucket_number):
6450 Now static.
6451 (make_symbol): Remove; unused.
6452 * lisp.h (initial_obarray, make_symbol): Remove decls.
6453
8a1414fa
PE
6454 * keyboard.c: Make symbols static if they're not exported.
6455 (single_kboard, recent_keys_index, total_keys, recent_keys):
6456 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6457 (this_single_command_key_start, echoing, last_auto_save):
6458 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6459 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6460 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6461 (Vlispy_mouse_stem, double_click_count):
6462 Now static.
6463 (force_auto_save_soon): Define only if SIGDANGER.
6464 (ignore_mouse_drag_p): Now static if
6465 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6466 (print_help): Remove; unused.
6467 (stop_character, last_timer_event): Mark as externally visible.
6468 * keyboard.h (ignore_mouse_drag_p): Declare only if
6469 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6470 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6471 * lisp.h (echoing): Remove decl.
6472 (force_auto_save_soon): Declare only if SIGDANGER.
6473 * xdisp.c (redisplay_window): Simplify code, to make it more
6474 obvious that ignore_mouse_drag_p is not accessed if !defined
6475 USE_GTK && !defined HAVE_NS.
6476
93ea6e8f
PE
6477 * intervals.c: Make symbols static if they're not exported.
6478 (merge_properties_sticky, merge_interval_right, delete_interval):
6479 Now static.
6480 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6481
77382fcc
PE
6482 * insdel.c: Make symbols static if they're not exported.
6483 However, leave prepare_to_modify_buffer alone. It's never
6484 called from outside this function, but that appears to be a bug.
6485 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6486 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6487 (adjust_after_replace_noundo): Remove; unused.
6488 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6489 (signal_before_change): Remove decls.
77382fcc 6490
9306c32e
PE
6491 * indent.c (val_compute_motion, val_vmotion): Now static.
6492
cd44d2eb
PE
6493 * image.c: Make symbols static if they're not exported.
6494 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6495 if USE_GTK.
6496 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6497 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6498
ad9a7a06
PE
6499 * fringe.c (standard_bitmaps): Now static.
6500 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6501
81626931
PE
6502 * frame.c: Make symbols static if they're not exported.
6503 (x_report_frame_params, make_terminal_frame): Now static.
6504 (get_frame_param): Now static, unless HAVE_NS.
6505 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6506 (x_get_resource_string): Remove; not used.
6507 * frame.h (make_terminal_frame, x_report_frame_params):
6508 (x_get_resource_string); Remove decls.
6509 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6510 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6511
239f9db9
PE
6512 * font.c, fontset.c: Make symbols static if they're not exported.
6513 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6514 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6515 * font.c (font_close_object): Now static.
6516 * font.h (font_close_object): Remove.
6517 * fontset.c (FONTSET_OBJLIST): Remove.
6518 (free_realized_fontset) #if-0 the body, which does nothing.
6519 (face_suitable_for_char_p): #if-0, as it's never called.
6520 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6521 * xfaces.c (face_at_string_position):
6522 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6523 since 0 is always ASCII.
6524
dfcf3579
PE
6525 * fns.c (weak_hash_tables): Now static.
6526
5045092b
PE
6527 * fileio.c: Make symbols static if they're not exported.
6528 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6529 (Vwrite_region_annotation_buffers): Now static.
6530
57a96f5c
PE
6531 * eval.c: Make symbols static if they're not exported.
6532 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6533 * lisp.h (backtrace_list): Remove decl.
6534
35f08c38
PE
6535 * emacs.c: Make symbols static if they're not exported.
6536 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6537 (fatal_error_code, fatal_error_signal_hook, standard_args):
6538 Now static.
6539 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6540 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6541 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6542 * lisp.h (fatal_error_signal_hook): Remove decl.
6543 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6544
f44bd759
PE
6545 * editfns.c: Move a (normally-unused) function to its only use.
6546 * editfns.c, lisp.h (get_operating_system_release): Remove.
6547 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6548 worth the hassle of breaking this out.
6549
b532497d
PE
6550 * xterm.c: Make symbols static if they're not exported.
6551 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6552 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6553 (x_destroy_window, x_delete_display):
6554 Now static.
6555 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6556 (x_mouse_leave): Remove; unused.
6557 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6558 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6559 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6560 Remove decls.
6561 (x_mouse_leave): Declare only if WINDOWSNT.
6562 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6563 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6564 USE_X_TOOLKIT.
6565
1675728f
PE
6566 * ftxfont.c: Make symbols static if they're not exported.
6567 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6568 HAVE_FREETYPE.
6569 * font.h (ftxfont_driver): Likewise.
6570
e4cebfca
PE
6571 * xfns.c: Make symbols static if they're not exported.
6572 (x_last_font_name, x_display_info_for_name):
6573 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6574 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6575 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6576 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6577 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6578 (last_show_tip_args): Now static.
6579 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6580 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6581 (x_screen_planes): Remove; unused.
6582 * dispextern.h (x_screen_planes): Remove decl.
6583
5bf46f05
PE
6584 * dispnew.c: Make symbols static if they're not exported.
6585 * dispextern.h (redraw_garbaged_frames, scrolling):
6586 (increment_row_positions): Remove.
6587 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6588 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6589 Now static.
6590 (redraw_garbaged_frames): Remove; unused.
6591
435f4c28
PE
6592 * xfaces.c: Make symbols static if they're not exported.
6593 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6594 Remove decls.
6595 * xterm.h (defined_color): Remove decls.
6596 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6597 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6598 (menu_face_changed_default, defined_color, free_realized_face):
6599 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6600 (ascii_face_of_lisp_face): Remove; unused.
6601
8524aef3
PE
6602 * xdisp.c: Make symbols static if they're not exported.
6603 * dispextern.h (scratch_glyph_row, window_box_edges):
6604 (glyph_to_pixel_coords, set_cursor_from_row):
6605 (get_next_display_element, set_iterator_to_next):
6606 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6607 (show_mouse_face): Remove decls
6608 * frame.h (message_buf_print): Likewise.
6609 * lisp.h (pop_message, set_message, check_point_in_composition):
6610 Likewise.
6611 * xterm.h (set_vertical_scroll_bar): Likewise.
6612 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6613 (message_buf_print, scratch_glyph_row, displayed_buffer):
6614 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6615 (get_next_display_element, show_mouse_face, window_box_edges):
6616 (frame_to_window_pixel_xy, check_point_in_composition):
6617 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6618 (glyph_to_pixel_coords): Remove; unused.
6619
16390cd2
PE
6620 * dired.c (file_name_completion): Now static.
6621
6622 * dbusbind.c (xd_in_read_queued_messages): Now static.
6623
a25f4dfa
PE
6624 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6625 * data.c (circular_list_error): Remove.
6626
14a9c8df
PE
6627 * commands.h (last_point_position, last_point_position_buffer):
6628 (last_point_position_window): Remove decls.
6629 * keyboard.c: Make these variables static.
6630
04f2d78b
CB
6631 * coding.h (coding, code_convert_region, encode_coding_gap):
6632 Remove decls.
74ab6df5
PE
6633 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6634 (iso_code_class, detect_coding, code_convert_region): Now static.
6635 (encode_coding_gap): Remove; unused.
6636
38dfbee1
PE
6637 * chartab.c (chartab_chars, chartab_bits): Now static.
6638
a2cb4e63
PE
6639 * charset.h (charset_iso_8859_1): Remove decl.
6640 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6641 Now static.
6642
127198fd
PE
6643 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6644 * ccl.c (Vccl_program_table): Now static.
6645 (check_ccl_update): Remove; unused.
6646
d85b608f
PE
6647 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6648 * category.h: ... from here.
6649 * category.c (check_category_table, set_category_set): Now static.
6650
31cd66f3
PE
6651 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6652 * lisp.h: Remove these decls.
6653
c358e587
PE
6654 * buffer.c (buffer_count): Remove unused var.
6655
e78aecca
PE
6656 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6657 so that it's not optimized away.
6658 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6659 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6660 exported only to the debugger.
6661
e192d7d3 6662 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6663 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6664
92470028
PE
6665 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6666 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6667 was inaccessible from Lisp.
6668 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6669 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6670
244ed907
PE
6671 alloc.c: Import and export fewer symbols, and remove unused items.
6672 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6673 is defined.
6674 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6675 it's not optimized away by whole-program optimization.
6676 (message_enable_multibyte, free_misc): Remove.
6677 (catchlist, handlerlist, mark_backtrace):
6678 Declare only if BYTE_MARK_STACK.
6679 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6680 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6681 (message_enable_multibyte): Remove decl.
6682 (free_misc, interval_free_list, float_block, float_block_index):
6683 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6684 (cons_free_list, last_marked_index):
6685 Now static.
6686 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6687 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6688 (mark_backtrace): Define only if BYTE_MARK_STACK.
6689 * xdisp.c (message_enable_multibyte): Now static.
6690
61c2b50e 6691 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6692 This makes it easier for human readers (and static analyzers)
6693 to see whether these variables are used from other modules.
6694 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6695 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6696 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6697 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6698 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6699 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6700 * xmenu.c, xselect.c:
6701 Declare Q* vars static if they are not used in other modules.
6702 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6703 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6704 Remove decls of unexported vars.
6705 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6706
95c82688
PE
6707 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6708
16a97296
PE
6709 Make Emacs functions such as Fatom 'static' by default.
6710 This makes it easier for human readers (and static analyzers)
6711 to see whether these functions can be called from other modules.
6712 DEFUN now defines a static function. To make the function external
6713 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6714 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6715 (Finit_image_library):
16a97296
PE
6716 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6717 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6718 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6719 Remove decls, since these functions are now static.
6720 (Funintern, Fget_internal_run_time): New decls, since these functions
6721 were already external.
95c82688 6722
16a97296
PE
6723 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6724 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6725 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6726 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6727 * keyboard.c, keymap.c, lread.c:
6728 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6729 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6730 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6731 Mark functions with DEFUE instead of DEFUN,
6732 if they are used in other modules.
6733 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6734 decls for now-static functions.
6735 * buffer.h (Fdelete_overlay): Remove decl.
6736 * callproc.c (Fgetenv_internal): Mark as internal.
6737 * composite.c (Fremove_list_of_text_properties): Remove decl.
6738 (Fcomposition_get_gstring): New forward static decl.
6739 * composite.h (Fcomposite_get_gstring): Remove decl.
6740 * dired.c (Ffile_attributes): New forward static decl.
6741 * doc.c (Fdocumntation_property): New forward static decl.
6742 * eval.c (Ffetch_bytecode): New forward static decl.
6743 (Funintern): Remove extern decl; now in .h file where it belongs.
6744 * fileio.c (Fmake_symbolic_link): New forward static decl.
6745 * image.c (Finit_image_library): New forward static decl.
6746 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6747 * intervals.h (Fprevious_property_change):
6748 (Fremove_list_of_text_properties): Remove decls.
6749 * keyboard.c (Fthis_command_keys): Remove decl.
6750 (Fcommand_execute): New forward static decl.
6751 * keymap.c (Flookup_key): New forward static decl.
6752 (Fcopy_keymap): Now static.
6753 * keymap.h (Flookup_key): Remove decl.
6754 * process.c (Fget_process): New forward static decl.
6755 (Fprocess_datagram_address): Mark as internal.
6756 * syntax.c (Fsyntax_table_p): New forward static decl.
6757 (skip_chars): Remove duplicate decl.
6758 * textprop.c (Fprevious_property_change): New forward static decl.
6759 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6760 Now internal.
6761 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6762 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6763
785bbd42
PE
6764 * editfns.c (Fformat): Remove unreachable code.
6765
8b913b57
AS
67662011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6767
6768 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6769 change. (Bug#8496)
6770
a6744a35
EZ
67712011-04-13 Eli Zaretskii <eliz@gnu.org>
6772
6773 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6774 when at ZV. (Bug#8487)
6775
e7974947
AS
67762011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6777
baad03f0
AS
6778 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6779 (Bug#8437)
6780 * keyboard.c (parse_tool_bar_item): Likewise.
6781 * sound.c (sound_cleanup, alsa_close): Likewise.
6782 * termcap.c (tgetent): Likewise.
6783 * xfns.c (x_default_font_parameter): Likewise.
6784 * xsettings.c (read_and_apply_settings): Likewise.
6785
e7974947
AS
6786 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6787 (overrun_check_free): Protoize.
6788
28272684
PE
67892011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6790
6791 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6792 since callers should never pass a negative size.
6793 Change the signature to match that of plain 'read' and 'write'; see
6794 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6795 * lisp.h: Update prototypes of emacs_write and emacs_read.
6796
11997c76
EZ
67972011-04-11 Eli Zaretskii <eliz@gnu.org>
6798
6799 * xdisp.c (redisplay_window): Don't try to determine the character
6800 position of the scroll margin if the window start point w->startp
e896f03c 6801 is outside the buffer's accessible region. (Bug#8468)
11997c76 6802
8a2cbd72
EZ
68032011-04-10 Eli Zaretskii <eliz@gnu.org>
6804
6805 Fix write-region and its subroutines for buffers > 2GB.
6806 * fileio.c (a_write, e_write): Modify declaration of arguments and
6807 local variables to support buffers larger than 2GB.
6808 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6809
6810 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6811 argument, local variables, and return value.
6812
6813 * lisp.h: Update prototypes of emacs_write and emacs_read.
6814
6815 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6816
4073e537 68172011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6818
1ebfdcb6
PE
6819 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6820
b2ded58d
PE
6821 Fix more problems found by GCC 4.6.0's static checks.
6822
7d66342c
PE
6823 * xdisp.c (vmessage): Use a better test for character truncation.
6824
bbf47d44
PE
6825 * charset.c (load_charset_map): <, not <=, for optimization,
6826 and to avoid potential problems with integer overflow.
9248994d 6827 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6828 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6829 * editfns.c (Fformat): Likewise.
1e69125e 6830 * syntax.c (skip_chars): Likewise.
3befa583 6831
e3019616
PE
6832 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6833 This also lets GCC 4.6.0 generate slightly better loop code.
6834
becfa255
PE
6835 * callint.c (Fcall_interactively): <, not <=, for optimization.
6836 (Fcall_interactively): Count the number of arguments produced,
6837 not the number of arguments given. This is simpler and lets GCC
6838 4.6.0 generate slightly better code.
6839
dae0cd48
PE
6840 * ftfont.c: Distingish more carefully between FcChar8 and char.
6841 The previous code passed unsigned char * to a functions like
6842 strlen and xstrcasecmp that expect char *, which does not
6843 conform to the C standard.
6844 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6845 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6846 char * when the C standard requires it.
6847
76032d70
PE
6848 * keyboard.c (read_char): Remove unused var.
6849
eb3f1cc8
PE
6850 * eval.c: Port to Windows vsnprintf (Bug#8435).
6851 Include <limits.h>.
6852 (SIZE_MAX): Define if the headers do not.
6853 (verror): Do not give up if vsnprintf returns a negative count.
6854 Instead, grow the buffer. This ports to Windows vsnprintf, which
6855 does not conform to C99. Problem reported by Eli Zaretskii.
6856 Also, simplify the allocation scheme, by avoiding the need for
6857 calling realloc, and removing the ALLOCATED variable.
6858
70476b54
PE
6859 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6860
12020a9e
PE
6861 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6862 But keep the doprint source code for now, as we might revamp it
6863 and use it again (Bug#8435).
ea6c7ae6
PE
6864 * lisp.h (doprnt): Remove.
6865 * Makefile.in (base_obj): Remove doprnt.o.
6866 * deps.mk (doprnt.o): Remove.
6867
5fdb398c
PE
6868 error: Print 32- and 64-bit integers portably (Bug#8435).
6869 Without this change, on typical 64-bit hosts error ("...%d...", N)
6870 was used to print both 32- and 64-bit integers N, which relied on
6871 undefined behavior.
6872 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6873 New macro.
6874 * lisp.h (error, verror): Mark as printf-like functions.
6875 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6876 Report overflow in size calculations when allocating printf buffer.
6877 Do not truncate output string at its first null byte.
6878 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6879 Truncate the output at a character boundary, since vsnprintf does not
6880 do that.
6881 * charset.c (check_iso_charset_parameter): Convert internal
6882 character to string before calling 'error', since %c now has the
6883 printf meaning.
6884 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6885 overflow when computing char to be passed to 'error'. Do not
6886 pass Lisp_Object to 'error'; pass the integer instead.
6887 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6888 formatted with plain %d.
6889
b189fa66
PE
6890 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6891
bff87ef0
PE
6892 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6893
7e2cac20
PE
6894 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6895
ce4d90b5
PE
6896 * xterm.c (x_catch_errors): Remove duplicate declaration.
6897
266c9547
PE
6898 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6899
79c49ad2
PE
6900 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6901
368f4090
JM
69022011-04-10 Jim Meyering <meyering@redhat.com>
6903
6904 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6905 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6906 return ssize_t not "int", and use size_t as the buffer length.
6907 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6908 * gnutls.h: Update declarations.
6909 * process.c (read_process_output): Use ssize_t, to match.
6910 (send_process): Likewise.
6911
a32d4040
CY
69122011-04-09 Chong Yidong <cyd@stupidchicken.com>
6913
6914 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6915
8546720e 69162011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6917
04f2d78b
CB
6918 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6919 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6920
8546720e
GM
6921 * xterm.c (handle_one_xevent):
6922 * xmenu.c (create_and_show_popup_menu):
6923 * xselect.c (x_decline_selection_request)
6924 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6925
0a2f5c1a 69262011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6927
6928 Fix some uses of `int' instead of EMACS_INT.
6929 * search.c (string_match_1, fast_string_match)
6930 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6931 (scan_buffer, find_next_newline_no_quit)
6932 (find_before_next_newline, search_command, Freplace_match)
6933 (Fmatch_data): Make some `int' variables be EMACS_INT.
6934
6935 * xdisp.c (display_count_lines): 3rd argument and return value now
6936 EMACS_INT. All callers changed.
6937 (pint2hrstr): Last argument is now EMACS_INT.
6938
6939 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6940 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6941 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6942 (decode_coding_utf_16, decode_coding_emacs_mule)
6943 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6944 (decode_coding_ccl, decode_coding_charset)
6945 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6946 (decode_coding_iso_2022, decode_coding_emacs_mule)
6947 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6948 <char_offset, last_offset>: Declare EMACS_INT.
6949 (encode_coding_utf_8, encode_coding_utf_16)
6950 (encode_coding_emacs_mule, encode_invocation_designation)
6951 (encode_designation_at_bol, encode_coding_iso_2022)
6952 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6953 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6954 Declare EMACS_INT.
6955 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6956 (encode_invocation_designation): Last argument P_NCHARS is now
6957 EMACS_INT.
6958 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6959 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6960
6961 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6962 All users changed.
6963
6964 * ccl.c (Fccl_execute_on_string): Declare some variables
6965 EMACS_INT.
6966
8546720e 69672011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6968
6969 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6970
4e19a977
CS
69712011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6972
6973 * process.c (Fformat_network_address): Doc fix.
6974
87302331
R
69752011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6976
6977 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6978
cbb59342
CY
69792011-04-08 Chong Yidong <cyd@stupidchicken.com>
6980
6981 * keyboard.c (read_char): Call Lisp function help-form-show,
6982 instead of using internal_with_output_to_temp_buffer.
6983 (Qhelp_form_show): New var.
e0d38eeb 6984 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6985
6986 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6987
6988 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6989
e67a13ab
CY
69902011-04-06 Chong Yidong <cyd@stupidchicken.com>
6991
04f2d78b
CB
6992 * process.c (Flist_processes): Remove to Lisp.
6993 (list_processes_1): Delete.
e67a13ab 6994
973f782d
EZ
69952011-04-06 Eli Zaretskii <eliz@gnu.org>
6996
7c106b1e
EZ
6997 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6998
973f782d
EZ
6999 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7000
41cf7d1a 70012011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7002
ca23cc88
PE
7003 Fix more problems found by GCC 4.6.0's static checks.
7004
f390e2d5
PE
7005 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7006
42eea0d0
PE
7007 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7008
b69769da 7009 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7010
f9541e84
PE
7011 * xdisp.c (vmessage): Mark as a printf-like function.
7012
13841b55
PE
7013 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7014
c136c10f
PE
7015 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7016
5e2d4a30
PE
7017 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7018 printf-like functions.
7019 (tiff_load): Add casts to remove these marks before passing them
7020 to system-supplied API.
7021
583f48b9
PE
7022 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7023
b25d760e
PE
7024 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7025 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7026 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7027 directly, rather than having caller test rule sign. This avoids
7028 some unnecessary tests.
7029 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7030 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7031 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7032
bc7b6697 7033 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7034 (xfont_open): Avoid unnecessary tests.
bc7b6697 7035
27ccc379
PE
7036 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7037
dcd5c89a
PE
7038 * composite.h, composite.c (composition_gstring_put_cache):
7039 Use EMACS_INT, not int, for length.
7040
b13a45c6
PE
7041 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7042 breaking out part of COMPOSITION_DECODE_RULE.
7043 (COMPOSITION_DECODE_RULE): Use it.
7044 * composite.c (get_composition_id): Remove unused local vars,
7045 by using the new macro.
7046
1e792e4d
PE
7047 * textprop.c (set_text_properties_1): Change while to do-while,
7048 since the condition is always true at first.
7049
dc6c6455 7050 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7051 (interval_deletion_adjustment): Return unsigned value.
7052 All uses changed.
dc6c6455 7053
aba7731a
PE
7054 * process.c (list_processes_1, create_pty, read_process_output):
7055 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7056 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7057 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7058 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7059 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7060
fdfc4bf3
PE
7061 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7062
fca8fe46 7063 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7064 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7065
06a0259a 7066 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7067 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7068 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7069
e7b9e80f
PE
7070 * print.c (print_error_message): Avoid int overflow.
7071
56201685
PE
7072 * font.c (font_list_entities): Redo for clarity,
7073 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7074
78834453 7075 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7076 (font_score): Avoid potential overflow in diff calculation.
78834453 7077
0bc0b309 7078 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7079 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7080
e610eaca
PE
7081 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7082
b895abce
PE
7083 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7084 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7085 can always succeed if overflow has undefined behavior.
7086
1f1d9321 7087 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7088 (wordify): Omit three unnecessary tests.
1f1d9321 7089
c59478bc
PE
7090 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7091 All callers changed. This avoids the need for an unused var.
7092
79b73827
PE
7093 * casefiddle.c (casify_region): Remove var that is set but not used.
7094
a4db5dfe
PE
7095 * dired.c (file_name_completion): Remove var that is set but not used.
7096
43aae36e
PE
7097 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7098
2a47c44d 7099 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7100 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7101
a37c69bf
PE
7102 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7103 Check for integer overflow on size calculations.
7104
328ab8e7
PE
7105 * buffer.c (Fprevious_overlay_change): Remove var that is set
7106 but not used.
7107
e5a2a5cb
PE
7108 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7109 Remove vars that are set but not used.
8d84a6eb 7110 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7111 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7112
a60e5f68
PE
7113 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7114
f661cb61 7115 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7116 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7117
f0397f5a
PE
7118 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7119 that are set but not used.
7120
8664db06 7121 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7122 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7123
6abdaa4a
PE
7124 * xselect.c (x_get_local_selection, x_handle_property_notify):
7125 Remove vars that are set but not used.
7126
0ce7538d 7127 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7128 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7129
9ae848fc
PE
7130 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7131 Remove var that is set but not used.
0b918413
PE
7132 (scroll_bar_windows_size): Now size_t, not int.
7133 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7134 Check for overflow.
9ae848fc 7135
a5a62657
PE
7136 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7137 (map_tty_color) [!defined MSDOS]: Likewise.
7138
5c5cdd39
PE
7139 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7140
66ebf983
PE
7141 * coding.c: Remove vars that are set but not used.
7142 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7143 All callers changed.
7144 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7145 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7146 (decode_coding_charset): Remove vars that are set but not used.
7147
1be4d761
PE
7148 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7149 that is set but not used.
7150
47553fa8
PE
7151 * print.c (print_object): Remove var that is set but not used.
7152
1f7196bf 7153 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7154 The gnulib version avoids calling malloc in the usual case,
7155 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7156 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7157 * filelock.c (current_lock_owner): Likewise.
7158 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7159 * sysdep.c: Include allocator.h, careadlinkat.h.
7160 (emacs_no_realloc_allocator): New static constant.
7161 (emacs_readlink): New function.
fdb61804
PE
7162 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7163 ../lib/careadlinkat.h.
d1fdcab7 7164
f84c17c7
SM
71652011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7166
7167 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7168 first non-nil return value).
7169
ef3862ad
JD
71702011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7171
7172 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7173 if not defined (Bug#8403).
7174
376a7006
JB
71752011-04-02 Juanma Barranquero <lekktu@gmail.com>
7176
7177 * xdisp.c (display_count_lines): Remove parameter `start',
7178 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7179 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7180 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7181 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7182 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7183 and thereabouts. All callers changed.
7184 (get_per_char_metric): Remove parameter `f', unused since
7185 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7186
6ca3801d
JM
71872011-04-02 Jim Meyering <meyering@redhat.com>
7188
7189 do not dereference NULL upon failed strdup
7190 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7191 (ns_get_family): Likewise.
7192
d8e2b5ba
JB
71932011-04-02 Juanma Barranquero <lekktu@gmail.com>
7194
7195 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7196
8c74fcbd
JD
71972011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7198
7199 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7200 later (Bug#8403).
7201
7200d79c
SM
72022011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7203
03408648 7204 Add lexical binding.
7200d79c 7205
03408648
SM
7206 * window.c (Ftemp_output_buffer_show): New fun.
7207 (Fsave_window_excursion):
7208 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7209
7210 * lread.c (lisp_file_lexically_bound_p): New function.
7211 (Fload): Bind Qlexical_binding.
7212 (readevalloop): Remove `evalfun' arg.
7213 Bind Qinternal_interpreter_environment.
7214 (Feval_buffer): Bind Qlexical_binding.
7215 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7216 Mark as dynamic.
7217 (syms_of_lread): Declare `lexical-binding'.
7218
7219 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7220
7221 * keyboard.c (eval_dyn): New fun.
7222 (menu_item_eval_property): Use it.
ca105506
SM
7223
7224 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7225
03408648
SM
7226 * fns.c (concat, mapcar1): Accept byte-code-functions.
7227
7228 * eval.c (Fsetq): Handle lexical vars.
7229 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7230 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7231 (FletX, Flet): Obey lexical binding.
7232 (Fcommandp): Handle closures.
7233 (Feval): New `lexical' arg.
7234 (eval_sub): New function extracted from Feval. Use it almost
7235 everywhere where Feval was used. Look up vars in lexical env.
7236 Handle closures.
7237 (Ffunctionp): Move from subr.el.
7238 (Ffuncall): Handle closures.
7239 (apply_lambda): Remove `eval_flags'.
7240 (funcall_lambda): Handle closures and new byte-code-functions.
7241 (Fspecial_variable_p): New function.
7242 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7243 but without exporting it to Lisp.
23aba0ea 7244
23aba0ea 7245 * doc.c (Fdocumentation, store_function_docstring):
03408648 7246 * data.c (Finteractive_form): Handle closures.
23aba0ea 7247
03408648
SM
7248 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7249 interactive spec.
ba83908c 7250
04f2d78b
CB
7251 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7252 New byte-codes.
03408648
SM
7253 (exec_byte_code): New function extracted from Fbyte_code to handle new
7254 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7255
03408648 7256 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7257
03408648 7258 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7259
e2abce01
JB
72602011-03-31 Juanma Barranquero <lekktu@gmail.com>
7261
7262 * xdisp.c (redisplay_internal): Fix prototype.
7263
63696a73 72642011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7265
63696a73 7266 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7267 (try_scrolling): Use it when setting scroll_limit.
7268 Limit scrolling to 100 screen lines.
63696a73
EZ
7269 (redisplay_window): Even when falling back on "recentering",
7270 position point in the window according to scroll-conservatively,
7271 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7272
7273 (try_scrolling): When point is above the window, allow searching
7274 as far as scroll_max, or one screenful, to compute vertical
7275 distance from PT to the scroll margin position. This prevents
7276 try_scrolling from unnecessarily failing when
7277 scroll-conservatively is set to a value slightly larger than the
7278 window height. Clean up the case of PT below the margin at bottom
7279 of window: scroll_max can no longer be INT_MAX. When aggressive
7280 scrolling is in use, don't let point enter the opposite scroll
7281 margin as result of the scroll.
7282 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7283 threshold of 100 lines for never-recentering scrolling.
7284
e4cc2dfc
JB
72852011-03-31 Juanma Barranquero <lekktu@gmail.com>
7286
7287 * dispextern.h (move_it_by_lines):
7288 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7289 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7290 (message_log_check_duplicate): Remove parameters `prev_bol' and
7291 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7292 (redisplay_internal): Remove parameter `preserve_echo_area',
7293 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7294
7295 * indent.c (Fvertical_motion):
7296 * window.c (window_scroll_pixel_based, Frecenter):
7297 Don't pass `need_y_p' to `move_it_by_lines'.
7298
1c470562
SM
72992011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7300
44f230aa
SM
7301 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7302 steal a few bits to be more compact.
7303 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7304 Remove unneeded casts.
7305
1c470562
SM
7306 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7307
888adce9
ZK
73082011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7309
7310 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7311 binding" message (bug#7967).
7312
f838ed7b
PE
73132011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7314
77861b95
PE
7315 Fix more problems found by GCC 4.6.0's static checks.
7316
de6dbc14
PE
7317 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7318 Remove unused local var.
7319
f838ed7b
PE
7320 * editfns.c (Fmessage_box): Remove unused local var.
7321
792c7b2b
PE
7322 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7323 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7324 Omit unused local vars.
c499e557 7325 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7326 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7327 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7328 Omit unused local var.
7329
ba0165e1
PE
7330 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7331 Don't assume string length fits in int.
32ad8845 7332 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7333 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7334
3c59b4c9
PE
7335 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7336 instead of alloca (Bug#8344).
7337
a3eed478 7338 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7339 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7340
eb4d412d
PE
7341 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7342
1658b401
PE
7343 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7344 concerns.
7345
7346 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7347
7348 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7349
9a2c6e05
PE
7350 * keyboard.c (syms_of_keyboard): Use the same style as later
7351 in this function when indexing through an array. This also
7352 works around GCC bug 48267.
7353
03d0a109
PE
7354 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7355
44f730c8
PE
7356 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7357
fe75f926
PE
7358 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7359 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7360
ffa8c828
PE
7361 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7362 This avoids undefined behavior on integer overflow, and is a bit
7363 more convenient anyway since it is compared to a size_t variable.
7364
c5101a77
PE
7365 Variadic C functions now count arguments with size_t, not int.
7366 This avoids an unnecessary limitation on 64-bit machines, which
7367 caused (substring ...) to crash on large vectors (Bug#8344).
7368 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7369 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7370 All variadic functions and their callers changed accordingly.
c5101a77
PE
7371 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7372 * data.c (arith_driver, float_arith_driver): Likewise.
7373 * editfns.c (general_insert_function): Likewise.
7374 * eval.c (struct backtrace.nargs, interactive_p)
7375 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7376 (funcall_lambda, mark_backtrace): Likewise.
7377 * fns.c (concat): Likewise.
7378 * frame.c (x_set_frame_parameters): Likewise.
7379 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7380 0 if not found, not -1. All callers changed.
7381
dd3f25f7
PE
7382 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7383 (stack_copy_size): Now size_t, not int.
7384 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7385
461c2ab9
JB
73862011-03-28 Juanma Barranquero <lekktu@gmail.com>
7387
7388 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7389 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7390 All callers changed.
7391
7392 * lisp.h (multibyte_char_to_unibyte):
7393 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7394 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7395 * character.h (CHAR_TO_BYTE8):
7396 * cmds.c (internal_self_insert):
7397 * editfns.c (general_insert_function):
7398 * keymap.c (push_key_description):
7399 * search.c (Freplace_match):
7400 * xdisp.c (message_dolog, set_message_1): All callers changed.
7401
f6d62986
SM
74022011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7403
7404 * keyboard.c (safe_run_hook_funcall): New function.
7405 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7406 don't set the hook to nil, but remove the offending function instead.
7407 (Qcommand_hook_internal): Remove, unused.
7408 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7409 Vcommand_hook_internal.
7410
7411 * eval.c (enum run_hooks_condition): Remove.
7412 (funcall_nil, funcall_not): New functions.
7413 (run_hook_with_args): Call each function through a `funcall' argument.
7414 Remove `cond' argument, now redundant.
7415 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7416 (Frun_hook_with_args_until_failure): Adjust accordingly.
7417 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7418
1db5b1ad
JB
74192011-03-28 Juanma Barranquero <lekktu@gmail.com>
7420
7421 * dispextern.h (string_buffer_position): Remove declaration.
7422
7423 * print.c (strout): Remove parameter `multibyte', unused since
7424 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7425
7426 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7427 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7428 All callers changed.
7429
7430 * w32.c (_wsa_errlist): Use braces for struct initializers.
7431
7432 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7433 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7434 All callers changed.
7435 (string_buffer_position): Likewise. Also, make static (it's never
7436 used outside xdisp.c).
7437 (cursor_row_p): Remove parameter `w', unused since
7438 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7439 (decode_mode_spec): Remove parameter `precision', introduced during
7440 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7441 All callers changed.
7442
5ffb62aa
JD
74432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7444
7445 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7446
461c2ab9 74472011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7448
7449 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7450 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7451 (ns_update_auto_hide_menu_bar): New functions.
7452 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7453 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7454 ns_constrain_all_frames.
7455 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7456 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7457
5c380ffb
JD
74582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7459
7460 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7461
9af30bdf
GM
74622011-03-27 Glenn Morris <rgm@gnu.org>
7463
7464 * syssignal.h: Replace RETSIGTYPE with void.
7465 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7466 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7467 Replace SIGTYPE with void everywhere.
7468 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7469 * s/template.h (SIGTYPE): Remove commented out definition.
7470
e2abce01
JB
74712011-03-26 Eli Zaretskii <eliz@gnu.org>
7472
7473 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7474 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7475
f868cd8a
JB
74762011-03-26 Juanma Barranquero <lekktu@gmail.com>
7477
59eb0929
JB
7478 * w32.c (read_unc_volume): Use parameter `henum', instead of
7479 global variable `wget_enum_handle'.
7480
7481 * keymap.c (describe_vector): Remove parameters `indices' and
7482 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7483 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7484
f868cd8a
JB
7485 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7486
7487 * keyboard.c (timer_check): Remove parameter `do_it_now',
7488 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7489 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7490 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7491
7492 * keyboard.c (read_char):
7493 * w32menu.c (w32_menu_display_help):
7494 * xmenu.c (show_help_event, menu_help_callback):
7495 Adjust calls to `show_help_echo'.
7496
7497 * gtkutil.c (xg_maybe_add_timer):
7498 * keyboard.c (readable_events):
7499 * process.c (wait_reading_process_output):
7500 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7501
7502 * insdel.c (adjust_markers_gap_motion):
7503 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7504 (gap_left, gap_right): Don't call it.
7505
2ecf6fdb
CY
75062011-03-25 Chong Yidong <cyd@stupidchicken.com>
7507
7508 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7509 incurred during fontification.
7510
6b1f9ba4
JB
75112011-03-25 Juanma Barranquero <lekktu@gmail.com>
7512
7513 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7514 (DEFVAR_PER_BUFFER): Don't pass it.
7515
7516 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7517 (scrolling_window): Don't pass it.
7518
0f4a96b5
JB
75192011-03-25 Juanma Barranquero <lekktu@gmail.com>
7520
7521 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7522
7523 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7524 and `suffix'.
7525 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7526 of variables specific to SELinux and computation of `encoded_absname'.
7527
7528 * image.c (XPutPixel): Remove unused variable `height'.
7529
7530 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7531
7532 * unexw32.c (get_section_info): Remove unused variable `section'.
7533
7534 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7535 (system_process_attributes): Remove unused variable `sess'.
7536 (sys_read): Remove unused variable `err'.
7537
7538 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7539 (w32_wnd_proc): Remove unused variable `isdead'.
7540 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7541 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7542 (x_create_tip_frame): Remove unused variable `tem'.
7543
7544 * w32inevt.c (w32_console_read_socket):
7545 Remove unused variable `no_events'.
7546
7547 * w32term.c (x_draw_composite_glyph_string_foreground):
7548 Remove unused variable `width'.
7549
1149507c
JB
75502011-03-24 Juanma Barranquero <lekktu@gmail.com>
7551
7552 * w32term.c (x_set_glyph_string_clipping):
7553 Don't pass uninitialized region to CombineRgn.
7554
9c88f339
JB
75552011-03-23 Juanma Barranquero <lekktu@gmail.com>
7556
7557 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7558 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7559 (Fx_close_connection): Remove unused variable `i'.
7560
7561 * w32font.c (w32font_draw): Return number of glyphs.
7562 (w32font_open_internal): Remove unused variable `i'.
7563 (w32font_driver): Add missing initializer.
7564
7565 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7566 (fill_in_menu): Remove unused variable `items_added'.
7567
7568 * w32term.c (last_mouse_press_frame): Remove static global variable.
7569 (w32_clip_to_row): Remove unused variable `f'.
7570 (x_delete_terminal): Remove unused variable `i'.
7571
7572 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7573 (NOTHING): Remove unused static global variable.
7574 (uniscribe_check_otf): Remove unused variable `table'.
7575 (uniscribe_font_driver): Add missing initializers.
7576
dee091a3
JD
75772011-03-23 Julien Danjou <julien@danjou.info>
7578
7579 * term.c (Fsuspend_tty, Fresume_tty):
7580 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7581 * window.c (temp_output_buffer_show):
7582 * insdel.c (signal_before_change):
7583 * frame.c (Fhandle_switch_frame):
7584 * fileio.c (Fdo_auto_save):
7585 * emacs.c (Fkill_emacs):
7586 * editfns.c (save_excursion_restore):
7587 * cmds.c (internal_self_insert):
7588 * callint.c (Fcall_interactively):
7589 * buffer.c (Fkill_all_local_variables):
7590 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7591 Use Frun_hooks.
0f4a96b5 7592 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7593 unconditionnaly since it does the check itself.
7594
2c520ab5 75952011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7596
c9c49752
PE
7597 Fix more problems found by GCC 4.5.2's static checks.
7598
8abc3f12
PE
7599 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7600 the first time through the loop, since we know p0 < p1 then.
7601 This also avoids a gcc -Wstrict-overflow warning.
7602
a2d26660
PE
7603 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7604 leading to a memory leak, possible in functions like
7605 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7606 of objects (Bug#8318).
a2d26660 7607
916c72e9
PE
7608 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7609 that could (at least in theory) be that large.
7610
19ab8a18
PE
7611 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7612 This is less likely to overflow, and avoids undefined behavior if
7613 overflow does occur. All callers changed. Use strtoul to scan
7614 for the unsigned long integer.
b7cbbd6f
PE
7615 (pint2hrstr): Simplify and tune code slightly.
7616 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7617
f0641eff
PE
7618 * scroll.c (do_scrolling): Work around GCC bug 48228.
7619 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7620
7f650bb9
PE
7621 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7622 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7623 (validate_x_resource_name): Simplify count usage.
7624 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7625
37dd57d1
PE
7626 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7627 fail (Bug#8306).
81e56e61 7628
699979fc 7629 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7630
401bf9b4
PE
7631 * process.c (Fmake_network_process): Use socklen_t, not int,
7632 where POSIX says socklen_t is required in portable programs.
7633 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7634 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7635 (Fmake_network_process, server_accept_connection):
7636 (wait_reading_process_output, read_process_output):
7637 Likewise.
7638
b93aacde
PE
7639 * process.c: Rename or move locals to avoid shadowing.
7640 (list_processes_1, Fmake_network_process):
7641 (read_process_output_error_handler, exec_sentinel_error_handler):
7642 Rename or move locals.
4dc343ee 7643 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7644 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7645 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7646 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7647 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7648
af8a867c 7649 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7650 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7651 Include tparam.h instead, since it declares them.
af8a867c
PE
7652 * cm.h (PC): Remove extern decl; tparam.h now does this.
7653 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7654 * terminfo.c: Include tparam.h, to check interfaces.
7655 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7656 (tparam): Adjust signature to match interface in tparam.h;
7657 this removes some undefined behavior. Check that outstring and len
7658 are zero, which they always are with Emacs.
7659 * tparam.h (PC, BC, UP): New extern decls.
7660
0248044d 7661 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7662 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7663
8ff096c1 7664 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7665 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7666 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7667 (ftfont_list): Remove unused local.
49eaafba
PE
7668 (get_adstyle_property, ftfont_pattern_entity):
7669 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7670 Rename locals to avoid shadowing.
8ff096c1 7671
e2be39f6
PE
7672 * xfont.c (xfont_list_family): Mark var as initialized.
7673
c9735e30
PE
7674 * xml.c (make_dom): Now static.
7675
8f5201ae
PE
7676 * composite.c (composition_compute_stop_pos): Rename local to
7677 avoid shadowing.
b246f932
PE
7678 (composition_reseat_it): Remove unused locals.
7679 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7680 (composition_update_it): Mark var as initialized.
11b61122
PE
7681 (find_automatic_composition): Mark vars as initialized,
7682 with a FIXME (Bug#8290).
8f5201ae 7683
760fbc2c
PE
7684 character.h: Rename locals to avoid shadowing.
7685 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7686 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7687 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7688 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7689 to avoid shadowing.
7690
ff08eb85
PE
7691 * textprop.c (property_change_between_p): Remove; unused.
7692
fc7bf025
PE
7693 * intervals.c (interval_start_pos): Now static.
7694
235d7abc
PE
7695 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7696
44f230aa
SM
7697 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7698 Rename locals to avoid shadowing.
3e7d6594 7699
50060332
PE
7700 * sound.c (wav_play, au_play, Fplay_sound_internal):
7701 Fix pointer signedness.
d01f234b 7702 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7703 (wav_play): Initialize a variable to 0, to prevent undefined
7704 behavior (Bug#8278).
50060332 7705
c4fc4e30
PE
7706 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7707
918436ed
PE
7708 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7709
c939f91b
PE
7710 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7711 clobbering (Bug#8298).
b9c7f648
PE
7712 * sysdep.c (sys_subshell): Likewise.
7713 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7714
6bd8c144
PE
7715 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7716 This should get cleaned up, so that child_setup has the
7717 same signature on all platforms.
7718
7710357c 7719 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7720 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7721
c59da222
CY
77222011-03-22 Chong Yidong <cyd@stupidchicken.com>
7723
7724 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7725 not to be necessary, and produces flickering.
7726
66b87493
GM
77272011-03-20 Glenn Morris <rgm@gnu.org>
7728
7729 * config.in: Remove file.
7730
45b6f6d5
JB
77312011-03-20 Juanma Barranquero <lekktu@gmail.com>
7732
7733 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7734 are now in src/globals.h.
7735 (syms_of_minibuf): Remove spurious & from previous change.
7736
3ec03f7e
LL
77372011-03-20 Leo <sdl.web@gmail.com>
7738
7739 * minibuf.c (completing-read-function): New variable.
7740 (completing-read-default): Rename from completing-read.
7741 (completing-read): Call completing-read-function.
7742
b14e3e21
CY
77432011-03-19 Juanma Barranquero <lekktu@gmail.com>
7744
7745 * xfaces.c (Fx_load_color_file):
7746 Read color file from absolute filename (bug#8250).
7747
f2b726e6
JB
77482011-03-19 Juanma Barranquero <lekktu@gmail.com>
7749
7750 * makefile.w32-in: Update dependencies.
7751
09f6ff02
EZ
77522011-03-17 Eli Zaretskii <eliz@gnu.org>
7753
7754 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7755
29a6015a
PE
77562011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7757
a3a6c54e
PE
7758 Fix more problems found by GCC 4.5.2's static checks.
7759
b766f867
PE
7760 * process.c (make_serial_process_unwind, send_process_trap):
7761 (sigchld_handler): Now static.
7762
be02381c
PE
7763 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7764 That way, the code declares only the vars that it needs.
7765 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7766 * s/cygwin.h (PTY_ITERATION): Likewise.
7767 * s/darwin.h (PTY_ITERATION): Likewise.
7768 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7769
57048744
PE
7770 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7771 * process.c (allocate_pty): Don't declare stb unless it's needed.
7772
7914961c 7773 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7774 (CONSTANTLIM): Remove; unused.
7775 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7776 Define only if needed.
7914961c 7777
b3967b18
PE
7778 * unexelf.c (unexec): Name an expression,
7779 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7780 Use a different way to cause a compilation error if anyone uses
7781 n rather than nn, a way that does not involve shadowing.
73366a00 7782 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7783
29a6015a
PE
7784 * deps.mk (unexalpha.o): Remove; unused.
7785
43cfc33e 7786 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7787 * unexec.h: New file.
ce701a33
PE
7788 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7789 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7790 Depend on unexec.h.
7791 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7792 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7793 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7794 Change as necessary to match prototype in unexec.h.
ce701a33 7795
01f44d5a
PE
7796 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7797 shadowing.
4f63c6bb 7798 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7799
a6670b0b
PE
7800 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7801 Rename locals to avoid shadowing.
7802
cef2010d 7803 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7804 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7805
d4d7173a
PE
7806 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7807
f08b802a
PE
7808 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7809 warning when compiling print.c.
7810
3ddb0639
PE
7811 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7812 instead of using an uninitialized var.
5ad03b97 7813 (font_sort_entities): Mark var as initialized.
3ddb0639 7814
170a2692
PE
7815 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7816
e663c700
PE
7817 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7818 pointers to constants.
89bc529a 7819 (font_parse_fcname): Remove unused vars.
7b81e2d0 7820 (font_delete_unmatched): Now static.
ea838e10 7821 (font_get_spec): Remove; unused.
13a547c6
PE
7822 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7823 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7824 Rename or move locals to avoid shadowing.
e663c700 7825
2a80c887 7826 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7827 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7828
1384fa33 7829 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7830 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7831
8b2c52e9
PE
7832 * alloc.c (mark_backtrace): Move decl from here ...
7833 * lisp.h: ... to here, so that it can be checked.
7834
475545b5 7835 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7836 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7837 (lisp_indirect_variable): Name an expression,
7838 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7839 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7840
b1349114 7841 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7842 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7843 Use const pointer when appropriate.
b1349114 7844
a2928364
PE
7845 * lisp.h (get_system_name, get_operating_system_release):
7846 Move decls here, to check interfaces.
7847 * process.c (get_operating_system_release): Move decl to lisp.h.
7848 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7849 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7850 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7851 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7852 (Fformat_time_string, Fencode_time, Finsert_char):
7853 (Ftranslate_region_internal, Fformat):
7854 Rename or remove local vars to avoid shadowing.
9710023e 7855 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7856
a415e694
PE
7857 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7858 avoid shadowing.
7859
8ef4622d
PE
7860 * lisp.h (eassert): Check that the argument compiles, even if
7861 ENABLE_CHECKING is not defined.
7862
946f9a5b
PE
7863 * data.c (Findirect_variable): Name an expression, to avoid
7864 gcc -Wbad-function-cast warning.
112396d6 7865 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7866 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7867 (Fmake_variable_buffer_local, Fmake_local_variable):
7868 Mark variables as initialized.
52746918 7869 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7870
e5aab7e7 7871 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7872 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7873 Rename locals to avoid shadowing.
dff45157
PE
7874 (mark_stack): Move local variables into the #ifdef region where
7875 they're used.
7bc26fdb
PE
7876 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7877 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7878 needed otherwise.
7879 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7880 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7881 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7882
e5aab7e7
PE
7883 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7884 avoids undefined behavior in theory.
7885
4da60324
PE
7886 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7887
88043301
PE
7888 Use functions, not macros, for up- and down-casing (Bug#8254).
7889 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7890 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7891 to use the following functions instead of these macros.
7892 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7893 EMACS_INT, since callers assume the returned value fits in int.
7894 (upcase1): Likewise, for UPCASE_TABLE.
7895 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7896 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7897 the race-condition problem in the old DOWNCASE.
88043301 7898
19ed5445
PE
7899 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7900 Rename locals to avoid shadowing.
7901 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7902 (regex_compile, re_search_2, re_match_2_internal):
7903 Remove unused local vars.
952db0d7
PE
7904 (FREE_VAR): Rewrite so as not to use empty "else",
7905 which gcc can warn about.
da053e48 7906 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7907 (RETALLOC_IF): Define only if needed.
7908 (WORDCHAR_P): Likewise. This one is never needed, but is used
7909 only in a comment talking about a compiler bug, so put inside
7910 the #if 0 of that comment.
7911 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7912 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7913 Remove; unused.
19ed5445 7914
1f3561e4 7915 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7916 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7917 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7918
ded6f8f7
PE
7919 * search.c (simple_search): Remove unused var.
7920
dbd37a95
PE
7921 * dired.c (compile_pattern): Move decl from here ...
7922 * lisp.h: ... to here, so that it can be checked.
7923 (struct re_registers): New forward decl.
7924
7e47afad
PE
7925 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7926
85f24f61
PE
7927 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7928 All uses changed.
7929 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7930 Rename locals to avoid shadowing.
5671df8f 7931 (Fvertical_motion): Mark locals as initialized.
85f24f61 7932
181aa2be 7933 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7934 (casify_region): Mark local as initialized.
181aa2be 7935
930d429c
PE
7936 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7937
7082eac6
PE
7938 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7939 New macros, so that the caller can use some names other than
7940 gcpro1, gcpro2, etc.
7941 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7942 of the new macros.
7943 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7944 argument, for consistency with GCPRO2_VAR, etc: it is now the
7945 prefix of the variable, not the variable itself. All uses
7946 changed.
38b2c076
PE
7947 * dired.c (directory_files_internal, file_name_completion):
7948 Rename locals to avoid shadowing.
7949
15206ed9
PE
7950 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7951 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7952 dired.c's scmp function, had undefined behavior.
7953 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7954 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7955 * buffer.h: ... to here, because these macros use current_buffer,
7956 and the new implementation with inline functions needs to have
7957 current_buffer in scope now, rather than later when the macros
7958 are used.
7959 (downcase, upcase1): New static inline functions.
7960 (DOWNCASE, UPCASE1): Reimplement using these functions.
7961 This avoids undefined behavior in expressions like
7962 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7963 from race conditions in accessing the global variables
7964 case_temp1 and case_temp2.
7965 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7966 * lisp.h (case_temp1, case_temp2): Remove their decls.
7967 * character.h (ASCII_CHAR_P): Move from here ...
7968 * lisp.h: ... to here, so that the inline functions mentioned
7969 above can use them.
7970
4a6bea26
PE
7971 * dired.c (directory_files_internal_unwind): Now static.
7972
f14b7e14
PE
7973 * fileio.c (file_name_as_directory, directory_file_name):
7974 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7975 Now static.
2893f146
PE
7976 (file_name_as_directory): Use const pointers when appropriate.
7977 (Fexpand_file_name): Likewise. In particular, newdir might
7978 point at constant storage, so make it a const pointer.
fd4ead52 7979 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7980 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7981 signedness issues.
f839df0c
PE
7982 (Fset_file_times, Finsert_file_contents, auto_save_error):
7983 Rename locals to avoid shadowing.
f14b7e14 7984
5716756e 7985 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7986 (Ftry_completion, Fall_completions): Rename or remove locals
7987 to avoid shadowing.
5716756e 7988
b4c3046a
PE
7989 * marker.c (bytepos_to_charpos): Remove; unused.
7990
b45db522
PE
7991 * lisp.h (verify_bytepos, count_markers): New decls,
7992 so that gcc does not warn that these functions aren't declared.
7993
85876d07
PE
7994 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7995 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7996 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7997 (copy_text): Remove unused local var.
85876d07 7998
03d78a21 7999 * filelock.c (within_one_second): Now static.
b3dd38ab 8000 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8001
5df8f01b
PE
8002 * buffer.c (fix_overlays_before): Mark locals as initialized.
8003 (fix_start_end_in_overlays): Likewise. This function should be
8004 simplified by using pointers-to-pointers, but that's a different
8005 matter.
b1d876f1 8006 (switch_to_buffer_1): Now static.
8f54f30a
PE
8007 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8008 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8009
a70072c9 8010 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8011 Fix pointer signedness issue.
edced198
PE
8012 (sys_subshell): Mark local as volatile if checking for lint,
8013 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8014 (MAXPATHLEN): Define only if needed.
a70072c9 8015
a0977c44
PE
8016 * process.c (serial_open, serial_configure): Move decls from here ...
8017 * systty.h: ... to here, so that they can be checked.
8018
a884fdcc
PE
8019 * fns.c (get_random, seed_random): Move extern decls from here ...
8020 * lisp.h: ... to here, so that they can be checked.
8021
604efe86 8022 * sysdep.c (reset_io): Now static.
b8950c94 8023 (wait_for_termination_signal): Remove; unused.
604efe86 8024
38fc62d9
PE
8025 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8026 (copy_keymap_item, append_key, push_text_char_description):
8027 Now static.
1004a21a 8028 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8029 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8030 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8031 (describe_map_tree):
8032 Rename locals to avoid shadowing.
38fc62d9 8033
2f2650da
PE
8034 * keyboard.c: Declare functions static if they are not used elsewhere.
8035 (echo_char, echo_dash, cmd_error, top_level_2):
8036 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8037 (read_char, kbd_buffer_get_event, make_lispy_position):
8038 (make_lispy_event, make_lispy_movement, apply_modifiers):
8039 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8040 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8041 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8042 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8043 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8044
a053e86c 8045 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8046 (mark_kboards): Move decl here ...
8047 * alloc.c (mark_kboards): ... from here.
a053e86c 8048
4752793e
PE
8049 * lisp.h (force_auto_save_soon): New decl.
8050
74f10ca7 8051 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8052 (DEFINE_DUMMY_FUNCTION): New macro.
8053 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8054 Use it.
c03cd23f
PE
8055 (main): Add casts to avoid warnings
8056 if GCC considers string literals to be constants.
74f10ca7 8057
022e70d4
PE
8058 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8059
59d6fe83
PE
8060 * dbusbind.c: Pointer signedness fixes.
8061 (xd_signature, xd_append_arg, xd_initialize):
8062 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8063 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8064 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8065 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8066
78320123
PE
8067 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8068 if GCC considers string literals to be constants.
49cebcca 8069 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8070
35ac2a97
SM
80712011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8072
fb103ca9
SM
8073 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8074 (print_preprocess, print_object): New macro to fix last change.
8075
35ac2a97
SM
8076 * print.c (print_preprocess): Don't forget font objects.
8077
62973b41
JB
80782011-03-16 Juanma Barranquero <lekktu@gmail.com>
8079
8080 * emacs.c (USAGE3): Doc fixes.
8081
0e48bb22
AS
80822011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8083
8084 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8085 structure.
8086
7684e57b
JB
80872011-03-14 Juanma Barranquero <lekktu@gmail.com>
8088
8089 * lisp.h (VWindow_system, Qfile_name_history):
8090 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8091 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8092 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8093
8094 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8095 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8096
8097 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8098 * w32console.c (detect_input_pending, read_input_pending)
8099 (encode_terminal_code):
8100 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8101 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8102 (w32_system_caret_y, Qfile_name_history):
8103 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8104 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8105 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8106 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8107 * w32proc.c (Qlocal, report_file_error):
8108 * w32term.c (Vwindow_system, updating_frame):
8109 * w32uniscribe.c (initialized, uniscribe_font_driver):
8110 Remove unneeded extern declarations.
8111
2aa46d6c
CY
81122011-03-14 Chong Yidong <cyd@stupidchicken.com>
8113
c96bbc66 8114 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8115
cffc6f3b
CY
81162011-03-13 Chong Yidong <cyd@stupidchicken.com>
8117
8118 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8119 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8120 These macros can no longer be used for assignment.
8121
44f230aa
SM
8122 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8123 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8124 (record_buffer_markers, fetch_buffer_markers): New functions for
8125 recording and fetching special buffer markers.
8126 (set_buffer_internal_1, set_buffer_temp): Use them.
8127
8128 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8129
8130 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8131
8132 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8133 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8134
8135 * xdisp.c (hscroll_window_tree):
8136 (reconsider_clip_changes): Use PT instead of BUF_PT.
8137
d251f04b
EZ
81382011-03-13 Eli Zaretskii <eliz@gnu.org>
8139
8140 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8141 $(EMACS_ROOT)/lib/intprops.h.
8142
f0c77cd1
PE
81432011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8144
3eca4629
PE
8145 Fix more problems found by GCC 4.5.2's static checks.
8146
7c86ee98
PE
8147 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8148 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8149 (xg_free_frame_widgets): Make it clear that a local variable is
8150 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8151 (gdk_window_get_screen): Make it clear that this macro is needed
8152 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8153 (int_gtk_range_get_value): New function, which avoids a diagnostic
8154 from gcc -Wbad-function-cast.
8155 (xg_set_toolkit_scroll_bar_thumb): Use it.
8156 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8157 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8158 (get_utf8_string, xg_get_file_with_chooser):
8159 Rename locals to avoid shadowing.
8160 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8161
41729b81
PE
8162 * xgselect.c (xg_select): Remove unused var.
8163
f0c77cd1
PE
8164 * image.c (four_corners_best): Mark locals as initialized.
8165 (gif_load): Initialize transparent_p to zero (Bug#8238).
8166 Mark another local as initialized.
ec6cf4c6 8167 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8168
ce0ad53d 8169 * image.c (clear_image_cache): Now static.
d5d5a617 8170 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8171 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8172 (x_edge_detection): Remove unnecessary cast that
8173 gcc -Wbad-function-cast diagnoses.
2037898d 8174 (gif_load): Fix pointer signedness.
6ae141d6
PE
8175 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8176 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8177
33383987 81782011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8179
d32df629
PE
8180 Improve quality of tests for time stamp overflow.
8181 For example, without this patch (encode-time 0 0 0 1 1
8182 1152921504606846976) returns the obviously-bogus value (-948597
8183 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8184 reports time overflow. See
8185 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8186 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8187 * editfns.c: Include limits.h and intprops.h.
8188 (TIME_T_MIN, TIME_T_MAX): New macros.
8189 (time_overflow): Move earlier, to before first use.
8190 (hi_time, lo_time): New functions, for an accurate test for
8191 out-of-range times.
8192 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8193 (Fget_internal_run_time): Don't assume time_t fits in int.
8194 (make_time): Use list2 instead of Fcons twice.
8195 (Fdecode_time): More accurate test for out-of-range times.
8196 (check_tm_member): New function.
8197 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8198 (lisp_time_argument): Don't rely on undefined left-shift and
8199 right-shift behavior when checking for time stamp overflow.
8be6f318 8200
fe31d94c
PE
8201 * editfns.c (time_overflow): New function, refactoring common code.
8202 (Fformat_time_string, Fdecode_time, Fencode_time):
8203 (Fcurrent_time_string): Use it.
8204
8be6f318
PE
8205 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8206 * dired.c (make_time): Move to ...
8207 * editfns.c (make_time): ... here.
8208 * systime.h: Note the move.
8209
09d9db2c 82102011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8211
126bc0dc
YM
8212 * fringe.c (update_window_fringes): Remove unused variables.
8213
c47cbdfd
YM
8214 * unexmacosx.c (copy_data_segment): Also copy __got section.
8215 (Bug#8223)
8216
7ac80be9
EZ
82172011-03-12 Eli Zaretskii <eliz@gnu.org>
8218
c96bbc66 8219 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8220 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8221 Constify `char *' arguments and their references according to
8222 prototypes in tparam.h.
8223
ecb0f94d 8224 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8225
7ac80be9
EZ
8226 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8227 Adapt all references accordingly.
8228
8229 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8230
ef1fd07e
TT
82312011-03-11 Tom Tromey <tromey@redhat.com>
8232
8233 * buffer.c (syms_of_buffer): Remove obsolete comment.
8234
7ef4b50c
EZ
82352011-03-11 Eli Zaretskii <eliz@gnu.org>
8236
8237 * termhooks.h (encode_terminal_code): Declare prototype.
8238
8239 * msdos.c (encode_terminal_code): Don't declare prototype.
8240
8241 * term.c (encode_terminal_code): Now external again, used by
8242 w32console.c and msdos.c.
8243
44f230aa
SM
8244 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8245 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8246
4b1ec863 82472011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8248
1714f52b 8249 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8250
4b1ec863
PE
8251 * fringe.c (update_window_fringes): Mark locals as initialized
8252 (Bug#8227).
8253 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8254
524c7aa6
PE
8255 * alloc.c (mark_fringe_data): Move decl from here ...
8256 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8257 to check its interface.
8258 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8259
a5c0af81 8260 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8261 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8262 (fontset_font): Mark local as initialized.
a9a06e0b 8263 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8264
b4716021
PE
8265 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8266
811e9bac 8267 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8268 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8269 (x_own_selection, Fx_disown_selection_internal): Rename locals
8270 to avoid shadowing.
8271 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8272
7e3ab302
PE
8273 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8274 so that the caller can use some name other than gcpro1.
8275 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8276 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8277 (Fx_backspace_delete_keys_p):
8278 Use them to avoid shadowing, and rename vars to avoid shadowing.
8279 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8280 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8281 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8282 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8283 Remove unused locals.
7e3ab302
PE
8284 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8285 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8286 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8287 macros.
f78faa98 8288
e2b13473
PE
8289 * xterm.h (x_mouse_leave): New decl.
8290
77f23912
PE
8291 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8292 Remove unused functions.
cdf4ba58
PE
8293 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8294 (x_calc_absolute_position): Now static.
7411c686 8295 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8296 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8297 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8298 unless they are used.
38d0b34a
PE
8299 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8300 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8301 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8302 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8303 (x_error_catcher, x_connection_closed, x_error_handler):
8304 (x_error_quitter, xembed_send_message, x_iconify_frame):
8305 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8306 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8307 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8308
44f230aa
SM
8309 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8310 Rename or move locals to avoid shadowing.
6b463e58 8311 (tty_defined_color, merge_face_heights): Now static.
5967d051 8312 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8313 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8314 does not deduce is never used uninitialized.
73719eba
PE
8315 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8316 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8317
426994c3 8318 * terminal.c (store_terminal_param): Now static.
5489860b 8319
032f1620 8320 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8321 (set_frame_menubar): Remove unused local.
d4323972 8322 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8323 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8324 since they might point to immutable storage.
281585b0
PE
8325 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8326 since it's unused otherwise.
032f1620 8327
367c19e5 8328 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8329 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8330 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8331 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8332 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8333 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8334 does not deduce are never used uninitialized.
70739cbe 8335
07b48fa9
PE
8336 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8337
8868a238 8338 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8339 * window.c (window_loop, size_window):
8340 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8341
7e5cf297 8342 * window.c (display_buffer): Now static.
d6550a9f
PE
8343 (size_window): Mark variables that gcc -Wuninitialized
8344 does not deduce are never used uninitialized.
a586633d
PE
8345 * window.h (check_all_windows): New decl, to forestall
8346 gcc -Wmissing-prototypes diagnostic.
5b555da1 8347 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8348
f6095868
PE
8349 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8350 shadowing.
8351 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8352 Include <limits.h>.
8353 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8354 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8355 (load_charset_map): Mark variables that gcc -Wuninitialized
8356 does not deduce are never used uninitialized.
53df7c11 8357 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8358
f38b440c
PE
8359 * coding.c (coding_set_source, coding_set_destination):
8360 Use "else { /* comment */ }" rather than "else /* comment */;"
8361 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8362 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8363 a block, when the outer 'i' will do.
8364 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8365 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8366 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8367 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8368 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8369 Rename locals to avoid shadowing.
8370 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8371 * coding.c (emacs_mule_char, encode_invocation_designation):
8372 Now static, since they're not used elsewhere.
413bb2db 8373 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8374 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8375 (decode_coding_emacs_mule): Mark variables that gcc
8376 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8377 (detect_coding_iso_2022): Initialize a local variable that might
8378 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8379 this initialization is needed. (Bug#8211)
5f58e762
PE
8380 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8381 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8382 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8383 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8384 Remove unused macros.
f38b440c 8385
232b38b9 8386 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8387 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8388 * character.c (string_count_byte8): Likewise.
232b38b9 8389
fb90da1b
PE
8390 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8391 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8392
fb93dbc2
PE
8393 * chartab.c (copy_sub_char_table): Now static, since it's not used
8394 elsewhere.
5c156ace
PE
8395 (sub_char_table_ref_and_range, char_table_ref_and_range):
8396 Rename locals to avoid shadowing.
bbcd0949 8397 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8398
7d3b3862 8399 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8400 (BIDI_BOB): Remove unused macro.
7d3b3862 8401
6be7d3da
PE
8402 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8403 deduce are never used uninitialized.
c2ed9c8b 8404 * term.c (encode_terminal_code): Likewise.
6be7d3da 8405
75f8807f 8406 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8407
50938595
PE
8408 * tparam.h: New file.
8409 * term.c, tparam.h: Include it.
8410 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8411 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8412 Move these decls to tparam.h, and make them agree with what
8413 is actually in tparam.c. The previous trick of using incompatible
8414 decls in different modules does not conform to the C standard.
8415 All callers of tparam changed to use tparam's actual API.
8416 * tparam.c (tparam1, tparam, tgoto):
8417 Use const pointers where appropriate.
8418
fbceeba2
PE
8419 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8420 * cm.h (struct cm): Likewise.
8421 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8422 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8423 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8424 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8425 (turn_on_face, init_tty): Likewise.
8426 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8427
7f3f1250
PE
8428 * term.c (term_mouse_position): Rename local to avoid shadowing.
8429
e6ca6543
PE
8430 * alloc.c (mark_ttys): Move decl from here ...
8431 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8432
c40f8d15
AS
84332011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8434
8435 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8436
cfe0661d
JB
84372011-03-09 Juanma Barranquero <lekktu@gmail.com>
8438
8439 * search.c (compile_pattern_1): Remove argument regp, unused since
8440 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8441 (compile_pattern): Don't pass it.
8442
0afb4571
J
84432011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8444
8445 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8446 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8447 for ! HAVE_GTK3.
8448 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8449
8450 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8451
8452 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8453 gdk_window_get_screen, gdk_window_get_geometry,
8454 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8455 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8456 (xg_get_pixbuf_from_pixmap): New function.
8457 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8458 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8459 Call xg_get_pixbuf_from_pixmap instead of
8460 gdk_pixbuf_get_from_drawable.
8461 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8462 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8463 (xg_check_special_colors): Use GtkStyleContext and its functions
8464 for HAVE_GTK3.
8465 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8466 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8467 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8468 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8469 Call gtk_widget_get_preferred_size.
0afb4571
J
8470 (xg_frame_resized): gdk_window_get_geometry only takes 5
8471 parameters.
44f230aa
SM
8472 (xg_win_to_widget, xg_event_is_for_menubar):
8473 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8474 (xg_set_widget_bg): New function.
8475 (delete_cb): New function.
895009e1 8476 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8477 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8478 (xg_set_background_color): Call xg_set_widget_bg.
8479 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8480 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8481 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8482 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8483 if ! HAVE_GTK3.
8484 (update_frame_tool_bar): Call gtk_widget_hide.
8485 (xg_initialize): Use GDK_KEY_g.
8486
8487 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8488 if ! HAVE_GTK3
8489 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8490
8491 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8492 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8493 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8494
1c2cc4ef
JB
84952011-03-08 Juanma Barranquero <lekktu@gmail.com>
8496
8497 * w32xfns.c (select_palette): Check success of RealizePalette against
8498 GDI_ERROR, not zero.
8499
33383987 8500See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8501
8502;; Local Variables:
8503;; coding: utf-8
aac0c6e3
MR
8504;; End:
8505
33383987 8506 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8507
8508 This file is part of GNU Emacs.
8509
8510 GNU Emacs is free software: you can redistribute it and/or modify
8511 it under the terms of the GNU General Public License as published by
8512 the Free Software Foundation, either version 3 of the License, or
8513 (at your option) any later version.
8514
8515 GNU Emacs is distributed in the hope that it will be useful,
8516 but WITHOUT ANY WARRANTY; without even the implied warranty of
8517 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8518 GNU General Public License for more details.
8519
8520 You should have received a copy of the GNU General Public License
8521 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.