* data.c: Avoid integer truncation in expressions involving floats.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0ae6bdee
PE
12011-05-21 Paul Eggert <eggert@cs.ucla.edu>
2
3 * data.c: Avoid integer truncation in expressions involving floats.
4 * data.c: Include <intprops.h>.
5 (arith_driver): When there's an integer overflow in an expression
6 involving floating point, convert the integers to floating point
7 so that the resulting value does not suffer from catastrophic
8 integer truncation. For example, on a 64-bit host (* 4
9 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10 Do not rely on undefined behavior after integer overflow.
11
de883a70
PE
122011-05-20 Paul Eggert <eggert@cs.ucla.edu>
13
14 merge count_size_as_multibyte, parse_str_to_multibyte
15 * character.c, character.h (count_size_as_multibyte):
16 Renamed from parse_str_to_multibyte; all uses changed.
17 Check for integer overflow.
18 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
19 since it's now a duplicate of the other. This is more of
20 a character than a buffer op, so better that it's in character.c.
21 * fns.c, print.c: Adjust to above changes.
22
7285dc67
EZ
232011-05-20 Eli Zaretskii <eliz@gnu.org>
24
25 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
26 report_file_error introduced by the change from 2011-05-07.
27
89d1bd22
PE
282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
29
30 * systime.h (Time): Define only if emacs is defined.
31 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
32 where the include path doesn't have X11/X.h by default. See
33 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
34
e23640bb 352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
36
37 * composite.c (find_automatic_composition): Fix previous change.
38
b9704ad9
GM
392011-05-20 Glenn Morris <rgm@gnu.org>
40
41 * lisp.mk: New file, split from Makefile.in.
42 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
43 (shortlisp): Remove.
44 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
45
4a720484
GM
462011-05-19 Glenn Morris <rgm@gnu.org>
47
48 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
49 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
50 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
51 (lisp): Set the order to that of loadup.el.
52 (shortlisp): Make it a copy of $lisp.
53 (SOME_MACHINE_LISP): Remove.
54 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
55 Use just $shortlisp, not $SOME_MACHINE_LISP too.
56
a28d4396
KH
572011-05-18 Kenichi Handa <handa@m17n.org>
58
59 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
60 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
61 (find_automatic_composition): Mostly rewrite for efficiency.
62
a2b1fa8e
JB
632011-05-18 Juanma Barranquero <lekktu@gmail.com>
64
65 * makefile.w32-in: Update dependencies.
66
8e1f5610
CS
672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
68
69 * menu.c: Include limits.h (fixes the MS-Windows build broken by
70 revision 104625).
71
7025ee00 722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 73
cdfa6eab
PE
74 Fix some integer overflow issues, such as string length overflow.
75
06d6db33
PE
76 * insdel.c (count_size_as_multibyte): Check for string overflow.
77
2b4560a8
PE
78 * character.c (lisp_string_width): Check for string overflow.
79 Use EMACS_INT, not int, for string indexes and lengths; in
80 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
81 the resulting string length overflows an EMACS_INT; instead,
82 report a string overflow if no precision given. When checking for
83 precision exhaustion, use a check that cannot possibly have
84 integer overflow. (Bug#8675)
85 * character.h (lisp_string_width): Adjust to new signature.
86
cb93f9be
PE
87 * alloc.c (string_overflow): New function.
88 (Fmake_string): Use it. This doesn't change behavior, but saves
89 a few bytes and will simplify future changes.
90 * character.c (string_escape_byte8): Likewise.
91 * lisp.h (string_overflow): New decl.
92
1a1f3366
PE
93 Fixups, following up to the user-interface timestamp change.
94 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
95 for UI timestamps, instead of unsigned long.
9fbd6841
PE
96 * msdos.c (mouse_get_pos): Likewise.
97 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
98 * w32gui.h (Time): Define by including "systime.h" rather than by
99 declaring it ourselves. (Bug#8664)
100
d4e3e4d3
PE
101 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
102 * image.c (clear_image_cache): Likewise.
103
f6a24d19
PE
104 * term.c (term_mouse_position): Don't assume time_t wraparound.
105
08dc5ae6
PE
106 Be more systematic about user-interface timestamps.
107 Before, the code sometimes used 'Time', sometimes 'unsigned long',
108 and sometimes 'EMACS_UINT', to represent these timestamps. This
109 change causes it to use 'Time' uniformly, as that's what X uses.
110 This makes the code easier to follow, and makes it easier to catch
111 integer overflow bugs such as Bug#8664.
112 * frame.c (Fmouse_position, Fmouse_pixel_position):
113 Use Time, not unsigned long, for user-interface timestamps.
114 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
115 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
116 * keyboard.h (last_event_timestamp): Likewise.
117 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
118 * menu.h (xmenu_show): Likewise.
119 * term.c (term_mouse_position): Likewise.
120 * termhooks.h (struct input_event.timestamp): Likewise.
121 (struct terminal.mouse_position_hook): Likewise.
122 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
123 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
124 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
125 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
126 what it was before.
127 * menu.h, termhooks.h: Include "systime.h", for Time.
128
8e55734a
PE
129 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
130 Don't assume that the difference between two unsigned long values
131 can fit into an integer. At this point, we know button_down_time
132 <= event->timestamp, so the difference must be nonnegative, so
133 there's no need to cast the result if double-click-time is
134 nonnegative, as it should be; check that it's nonnegative, just in
135 case. This bug is triggered when events are more than 2**31 ms
86db42d2 136 apart (about 25 days). (Bug#8664)
8e55734a 137
841f1b75 138 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 139 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 140
3e26f69c
PE
141 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
142 that always fit in int. Use a sentinel instead of a counter, to
143 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
144 * frame.h (struct frame): Use int for menu_bar_items_used
145 instead of EMACS_INT, since it always fits in int.
3e26f69c 146
5cc152c0
PE
147 * menu.c (grow_menu_items): Check for int overflow.
148
d89eb65e
PE
149 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
150
5235bd3e
PE
151 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
152 Before, the code was not consistent. These values cannot exceed
153 2**31 - 1 so there's no need to make them unsigned.
154 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
155 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
156 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
157 as modifiers.
158 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
159
bc827e23
PE
160 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
161 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
162 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
163 presumably because the widths might not match.
164
78eb494e
PE
165 * window.c (size_window): Avoid needless test at loop start.
166
04f2d78b
CB
1672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
168
169 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
170
d2fc7e3d 1712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
172
173 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
174
d2fc7e3d 1752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
176
177 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
178 `width' to `bar_area_x' and `bar_area_width', respectively.
179 (x_scroll_run): Take account of fringe background extension.
180
04f2d78b
CB
181 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
182 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
183 `bar_area_width', respectively.
184 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
185 background extension.
186
79b70037
GM
1872011-05-10 Jim Meyering <meyering@redhat.com>
188
189 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
190
2f142cc5
JB
1912011-05-10 Juanma Barranquero <lekktu@gmail.com>
192
193 * image.c (Finit_image_library): Return t for built-in image types,
194 like pbm and xbm. (Bug#8640)
195
57679c86
AS
1962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
197
198 * w32menu.c (set_frame_menubar): Fix submenu allocation.
199
888c9e86
EZ
2002011-05-07 Eli Zaretskii <eliz@gnu.org>
201
b0512a1d
EZ
202 * w32console.c (Fset_screen_color): Doc fix.
203 (Fget_screen_color): New function.
204 (syms_of_ntterm): Defsubr it.
205
7285dc67
EZ
206 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
207 unlink the temporary file if Fcall_process didn't create it in the
208 first place.
209 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
210 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
211 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
212 cue to call_process_cleanup not to close that handle.
213
4d3fcc8e
BK
2142011-05-07 Ben Key <bkey76@gmail.com>
215
216 * makefile.w32-in: The bootstrap-temacs rule now makes use of
217 one of two shell specific rules, either bootstrap-temacs-CMD or
218 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
219 to the previous implementation of the bootstrap-temacs rule.
220 The bootstrap-temacs-CMD rule is similar to the previous
221 implementation of the bootstrap-temacs rule except that it
222 makes use of the ESC_CFLAGS variable instead of the CFLAGS
223 variable.
224
225 These changes, along with some changes to nt/configure.bat,
226 nt/gmake.defs, and nt/nmake.defs, are required to extend my
227 earlier fix to add support for --cflags and --ldflags options
228 that include quotes so that it works whether make uses cmd or
229 sh as the shell.
230
b4289b64
MA
2312011-05-06 Michael Albinus <michael.albinus@gmx.de>
232
233 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
234 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
235 is a constant.
236 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
237 a string. Handle both cases.
238 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
239 (Fdbus_register_method): Use Qinvalid_function.
240
af4c0e28
JB
2412011-05-06 Juanma Barranquero <lekktu@gmail.com>
242
243 * makefile.w32-in: Update dependencies.
244 (LISP_H): Add inttypes.h and stdin.h.
245 (PROCESS_H): Add unistd.h.
246
c51453d9
EZ
2472011-05-06 Eli Zaretskii <eliz@gnu.org>
248
249 * lread.c: Include limits.h (fixes the MS-Windows build broken by
250 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
251
8ff0ac3c 2522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 253
4c4b566b
PE
254 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
255
aab2b9b5
PE
256 * term.c (vfatal): Remove stray call to va_end.
257 It's not needed and the C Standard doesn't allow it here anyway.
258
c378da0b
PE
259 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
260 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
261
288b08c7
PE
262 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
263 bytes.
264
e3601888
PE
265 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
266
db6c0e74
PE
267 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
268
dd5963ea
PE
269 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
270
88c9450f
PE
271 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
272
2f9442b8
PE
273 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
274
c032b5f8
PE
275 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
276 * charset.c (Fdefine_charset_internal): Don't initialize
277 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 278 32-bit int (Bug#8600).
a108c10b
PE
279
280 * lread.c (read_integer): Be more consistent with string-to-number.
281 Use string_to_number to do the actual conversion; this avoids
282 rounding errors and fixes some other screwups. Without this fix,
283 for example, #x1fffffffffffffff was misread as -2305843009213693952.
284 (digit_to_number): Move earlier, for benefit of read_integer.
285 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 286 not a digit in any supported base. (Bug#8602)
a108c10b 287
ad5f9eea
PE
288 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
289
aec1708a
PE
290 * dispnew.c (scrolling_window): Return 1 if we scrolled,
291 to match comment at start of function. This also removes a
292 GCC warning about overflow in a 32+64-bit port.
293
47be4ab5
PE
294 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
295
371cac43
PE
296 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
297 Reported by Stefan Monnier in
298 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
299 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
300 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 301
d01a7826
PE
302 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
303 (EMACS_UINTPTR): Likewise, with uintptr_t.
304
7fd47d5c
PE
305 * lisp.h: Prefer 64-bit EMACS_INT if available.
306 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
307 on 32-bit hosts that have 64-bit int, so that they can access
308 large files.
122b0c86
PE
309 However, temporarily disable this change unless the temporary
310 symbol WIDE_EMACS_INT is defined.
7fd47d5c 311
8727937b
PE
312 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
313
8ac068ac
PE
314 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
315 This removes an assumption that EMACS_INT and long are the same
316 width as pointers. The assumption is true for Emacs porting targets
317 now, but we want to make other targets possible.
318 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
319 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
320 In the rest of the code, change types of integers that hold casted
321 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
322 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
323 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
324 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
325 No need to cast type when ORing.
326 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
327 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
328 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
329 assume EMACS_INT is the same width as char *.
330 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
331 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
332 Remove no-longer-needed casts.
333 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
334 (xg_tool_bar_help_callback, xg_make_tool_item):
335 Use EMACS_INTPTR to hold an integer
336 that will be cast to void *; this can avoid a GCC warning
337 if EMACS_INT is not the same width as void *.
338 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
339 * xdisp.c (display_echo_area_1, resize_mini_window_1):
340 (current_message_1, set_message_1):
341 Use a local to convert to proper width without a cast.
342 * xmenu.c (dialog_selection_callback): Likewise.
343
ede49d71
PE
344 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
345 Also, don't assume VALBITS / RAND_BITS is less than 5,
346 and don't rely on undefined behavior when shifting a 1 left into
347 the sign bit.
348 * lisp.h (get_random): Change signature to match.
349
2f30ecd0
PE
350 * lread.c (hash_string): Use size_t, not int, for hash computation.
351 Normally we prefer signed values; but hashing is special, because
352 it's better to use unsigned division on hash table sizes so that
353 the remainder is nonnegative. Also, size_t is the natural width
354 for hashing into memory. The previous code used 'int', which doesn't
355 retain enough info to hash well into very large tables.
356 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
357
2a866e7b
PE
358 * dbusbind.c: Don't possibly lose pointer info when converting.
359 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
360 Use XPNTR rather than XHASH, so that the high-order bits of
361 the pointer aren't lost when converting through void *.
362
51639eac
PE
363 * eval.c (Fautoload): Don't double-shift a pointer.
364
92394119
PE
365 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
366
dbdb9a7c
JB
3672011-05-06 Juanma Barranquero <lekktu@gmail.com>
368
369 * gnutls.c (DEF_GNUTLS_FN):
370 * image.c (DEF_IMGLIB_FN): Make function pointers static.
371
db7a0b4f
AS
3722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
373
374 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
375 marker. (Bug#8610)
376
f7ff1b0f 3772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
378
379 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
380 New version that can reserve upto 2GB of heap space.
381
f7ff1b0f 3822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
383
384 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
385
639c109b
TZ
3862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
387
388 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
389 `gnutls_certificate_set_x509_key_file'.
390
d2127135
JB
3912011-05-05 Juanma Barranquero <lekktu@gmail.com>
392
393 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
394 Update dependencies.
395
e968f4f3
JB
3962011-05-04 Juanma Barranquero <lekktu@gmail.com>
397
398 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
399 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
400 Remove unused parameter `fildes'.
401 * process.c (read_process_output, send_process): Don't pass it.
402
84d358f0
JB
4032011-05-04 Juanma Barranquero <lekktu@gmail.com>
404
405 Fix previous change: the library cache is defined in w32.c.
406 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
407 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
408
0898ca10
JB
4092011-05-04 Juanma Barranquero <lekktu@gmail.com>
410
411 Implement dynamic loading of GnuTLS on Windows.
412
413 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
414 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
415 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
416 Declare.
417
418 * gnutls.c (Qgnutls_dll): Define.
419 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
420 (gnutls_*): Declare function pointers.
421 (init_gnutls_functions): New function to initialize function pointers.
422 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
423 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
424 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
425 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
426 (emacs_gnutls_write, emacs_gnutls_read)
427 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
428 (Fgnutls_available_p): New function.
429 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
430 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
431 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
432
433 * image.c: Include w32.h.
434 (Vimage_type_cache): Delete.
435 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
436 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
437 (w32_delayed_load): Move to w32.c.
438
439 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
440
441 * w32.c (QCloaded_from, Vlibrary_cache): Define.
442 (w32_delayed_load): Move from image.c. When loading a library, record
443 its filename in the :loaded-from property of the library id.
444 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
445 Initialize and staticpro them.
446 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
447
448 * process.c: Include lisp.h before w32.h, not after.
449 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
450 instead of gnutls_record_check_pending.
451
452 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
453
ff4de4aa
TZ
4542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
455
456 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
457 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
458 as passed in.
459
abe95abb
JD
4602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
461
462 * xterm.c (x_set_frame_alpha): Do not set property on anything
463 else than FRAME_X_OUTER_WINDOW (Bug#8608).
464
e16e55d4
JB
4652011-05-02 Juanma Barranquero <lekktu@gmail.com>
466
467 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
468
bafcf6a5
JB
4692011-05-02 Juanma Barranquero <lekktu@gmail.com>
470
471 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
472 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
473 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
474 (gnutls_global_initialized, Qgnutls_bootprop_priority)
475 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
476 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
477 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
478 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
479 (Qgnutls_bootprop_callbacks_verify): Make static.
480
e7a6747f
AS
4812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
482
19ed11ba
AS
483 * callproc.c: Indentation fixup.
484
e7a6747f 485 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
486 (wait_for_termination, interruptible_wait_for_termination):
487 Move after wait_for_termination_1.
e7a6747f 488
1ef14cb4
LMI
4892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
490
491 * sysdep.c (interruptible_wait_for_termination): New function
492 which is like wait_for_termination, but allows keyboard
493 interruptions.
494
495 * callproc.c (Fcall_process): Add (:file "file") as an option for
496 the STDOUT buffer.
497 (Fcall_process_region): Ditto.
498
330d880c
EZ
4992011-04-30 Eli Zaretskii <eliz@gnu.org>
500
8db90b73
EZ
501 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
502 rather than `XVECTOR (FOO)->size'.
503
330d880c
EZ
504 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
505 inttypes.h, as a gnulib replacement is used if it not available in
506 system headers.
507
15cbd324
EZ
5082011-04-21 Eli Zaretskii <eliz@gnu.org>
509
510 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
511 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
512 of MOST_POSITIVE_FIXNUM. (Bug#8528)
513
514 * coding.c (coding_alloc_by_realloc): Error out if destination
515 will grow beyond MOST_POSITIVE_FIXNUM.
516 (decode_coding_emacs_mule): Abort if there isn't enough place in
517 charbuf for the composition carryover bytes. Reserve an extra
518 space for up to 2 characters produced in a loop.
519 (decode_coding_iso_2022): Abort if there isn't enough place in
520 charbuf for the composition carryover bytes.
521
5222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 523
ae940cca
EZ
524 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
525 aborting when %lld or %lll format is passed.
526 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
527 %llo or %llx format is passed. (Bug#8545)
528
03ab8921
EZ
529 * window.c (window_scroll_line_based): Use a marker instead of
530 simple variables to record original value of point. (Bug#7952)
531
afda1437
EZ
532 * doprnt.c (doprnt): Fix the case where a multibyte sequence
533 produced by %s or %c overflows available buffer space. (Bug#8545)
534
f76dee0c
PE
5352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
536
537 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 538 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 539
fdc5744d
JB
5402011-04-28 Juanma Barranquero <lekktu@gmail.com>
541
542 * w32.c (init_environment): Warn about defaulting HOME to C:\.
543
638f053a
JB
5442011-04-28 Juanma Barranquero <lekktu@gmail.com>
545
546 * keyboard.c (Qdelayed_warnings_hook): Define.
547 (command_loop_1): Run `delayed-warnings-hook'
548 if Vdelayed_warnings_list is non-nil.
549 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
550 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
551
d178f871
EZ
5522011-04-28 Eli Zaretskii <eliz@gnu.org>
553
554 * doprnt.c (doprnt): Don't return value smaller than the buffer
555 size if the message was truncated. (Bug#8545).
556
b124fd93
JB
5572011-04-28 Juanma Barranquero <lekktu@gmail.com>
558
559 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
560 (Fx_window_property): #if-0 the whole functions, not just the bodies.
561
e810457d
PE
5622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
563
564 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
565
ea51cceb
JB
5662011-04-27 Juanma Barranquero <lekktu@gmail.com>
567
568 * makefile.w32-in: Update dependencies.
569
94dcfacf
EZ
5702011-04-27 Eli Zaretskii <eliz@gnu.org>
571
572 Improve `doprnt' and its usage. (Bug#8545)
573 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
574 `format_end'. Remove support for %l as a conversion specifier.
575 Don't use xrealloc. Improve diagnostics when the %l size modifier
576 is used. Update the commentary.
577
578 * eval.c (verror): Simplify calculation of size_t.
579
580 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
581 messages.
582
f61f41d7
PE
5832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
584
585 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
586 change.
587
96fb4434
PE
5882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
589
590 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
591 This makes this file independent of the recent pseudovector change.
592
671875da 5932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 594
69e9b5a3
PE
595 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
596
b5f869a7 597 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 598 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 599 Remove unused local.
c8926152 600 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 601
841a1577 602 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
603 GCC 4.6.0 optimizes based on type-based alias analysis.
604 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
605 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
606 != &v->size, and therefore "v->size = 1; b->size = 2; return
607 v->size;" must therefore return 1. This assumption is incorrect
608 for Emacs, since it type-puns struct Lisp_Vector * with many other
609 types. To fix this problem, this patch adds a new type struct
f904488f 610 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
611 and pseudovectors, and helps optimizing compilers not get fooled
612 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
613 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
614 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
615 the size member.
eab3844f
PE
616 (XSETPVECTYPE): Rewrite in terms of new macro.
617 (XSETPVECTYPESIZE): New macro, specifying both type and size.
618 This is a bit clearer, and further avoids the possibility of
619 undesirable aliasing.
620 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 621 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
622 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
623 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
624 (ASIZE): Now uses header.size rather than size.
625 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
626 to avoid the hassle of writing XVECTOR (foo)->header.size.
627 (struct vectorlike_header): New type.
eab3844f
PE
628 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
629 object, to help avoid aliasing.
630 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
631 (SUBRP): Likewise, since Lisp_Subr is a special case.
632 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
633 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
634 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 635 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
636 changed to be "header.size" and "header.next".
637 * buffer.h (struct buffer): Likewise.
638 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
639 * frame.h (struct frame): Likewise.
640 * process.h (struct Lisp_Process): Likewise.
641 * termhooks.h (struct terminal): Likewise.
642 * window.c (struct save_window_data, struct saved_window): Likewise.
643 * window.h (struct window): Likewise.
644 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
645 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
646 * buffer.c (init_buffer_once): Likewise.
647 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
648 special case.
649 * process.c (Fformat_network_address): Use local var for size,
650 for brevity.
651
0df1eac5
PE
652 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
653
847ab9d1 654 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
655 * data.c (atof): Remove decl; no longer used or needed.
656 (digit_to_number): Move to lread.c.
657 (Fstring_to_number): Use new string_to_number function, to be
658 consistent with how the Lisp reader treats infinities and NaNs.
659 Do not assume that floating-point numbers represent EMACS_INT
660 without losing information; this is not true on most 64-bit hosts.
661 Avoid double-rounding errors, by insisting on integers when
662 parsing non-base-10 numbers, as the documentation specifies.
663 * lisp.h (string_to_number): New decl, replacing ...
664 (isfloat_string): Remove.
bc0a5c13 665 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 666 (read1): Do not accept +. and -. as integers; this
452f4150
PE
667 appears to have been a coding error. Similarly, do not accept
668 strings like +-1e0 as floating point numbers. Do not report
669 overflow for integer overflows unless the base is not 10 which
670 means we have no simple and reliable way to continue.
671 Break out the floating-point parsing into a new
672 function string_to_number, so that Fstring_to_number parses
673 floating point numbers consistently with the Lisp reader.
04f2d78b 674 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
675 (E_CHAR, EXP_INT): Remove, replacing with ...
676 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
677 (string_to_number): New function, replacing isfloat_string.
678 This function checks for valid syntax and produces the resulting
679 Lisp float number too. Rework it so that string-to-number
bc0a5c13 680 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
681 so that overflow for non-base-10 numbers is reported only when
682 there's no portable and simple way to convert to floating point.
452f4150 683
67769ffc
PE
684 * textprop.c (set_text_properties_1): Rewrite for clarity,
685 and to avoid GCC warning about integer overflow.
686
c20db43f
PE
687 * intervals.h (struct interval): Use EMACS_INT for members
688 where EMACS_UINT might cause problems. See
689 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
690 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
691 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
692 All uses changed.
37aa2f85
PE
693 (offset_intervals): Tell GCC not to worry about length overflow
694 when negating a negative length.
c20db43f 695
2538aa2f
PE
696 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
697 (overrun_check_free): Likewise.
698
f2d3008d
PE
699 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
700 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
701 word size.
702
ec8df744
PE
703 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
704 (gnutls_make_error): Rename local to avoid shadowing.
705 (gnutls_emacs_global_deinit): ifdef out; not used.
706 (Fgnutls_boot): Use const for pointer to readonly storage.
707 Comment out unused local. Fix pointer signedness problems.
708
640ee02d
PE
709 * lread.c (openp): Don't stuff size_t into an 'int'.
710 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
711 about possible signed overflow.
712
6048fb2a
PE
713 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
714 (GDK_KEY_g): Don't define if already defined.
715 (xg_prepare_tooltip): Avoid pointer signedness problem.
716 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
717
fa3c87e1
PE
718 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
719 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
720
2172544b
PE
721 * xfns.c (Fx_window_property): Simplify a bit,
722 to make a bit faster and to avoid GCC 4.6.0 warning.
723 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
724
9b821a21
PE
725 * fns.c (internal_equal): Don't assume size_t fits in int.
726
3c616cfa
PE
727 * alloc.c (compact_small_strings): Tighten assertion a little.
728
c2982e87
PE
729 Replace pEd with more-general pI, and fix some printf arg casts.
730 * lisp.h (pI): New macro, generalizing old pEd macro to other
731 conversion specifiers. For example, use "...%"pI"d..." rather
732 than "...%"pEd"...".
733 (pEd): Remove. All uses replaced with similar uses of pI.
734 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
735 * alloc.c (check_pure_size): Don't overflow by converting size to int.
736 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
737 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
738 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
739 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
740 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
741 64-bit hosts.
742 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
743 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
744 * print.c (safe_debug_print, print_object): Likewise.
745 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
746 to int.
6f04d126
PE
747 Use pI instead of if-then-else-abort. Use %p to avoid casts,
748 avoiding the 0 flag, which is not portable.
c2982e87
PE
749 * process.c (Fmake_network_process): Use pI to avoid cast.
750 * region-cache.c (pp_cache): Likewise.
751 * xdisp.c (decode_mode_spec): Likewise.
752 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
753 behavior on 64-bit hosts with printf arg.
6f04d126 754 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
755 (x_stop_queuing_selection_requests): Likewise.
756 (x_get_window_property): Don't truncate byte count to an 'int'
757 when tracing.
0b432f21 758
5e073ec7
PE
759 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
760 here, since it parses constructs like leading '-' and spaces,
761 which are not wanted; and it overflows with large numbers.
762 Instead, simply match F[0-9]+, which is what is wanted anyway.
763
36372bf9
PE
764 * alloc.c: Remove unportable assumptions about struct layout.
765 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
766 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
767 (allocate_vectorlike, make_pure_vector): Use the new macros,
768 plus offsetof, to remove unportable assumptions about struct layout.
769 These assumptions hold on all porting targets that I know of, but
770 they are not guaranteed, they're easy to remove, and removing them
771 makes further changes easier.
772
0b432f21
PE
773 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
774 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
775 (string_overrun_cookie): Now const. Use initializers that
776 don't formally overflow signed char, to avoid warnings.
000098c1
PE
777 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
778 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
779 (allocate_buffer): Don't assume sizeof (struct buffer) is a
780 multiple of sizeof (EMACS_INT); it need not be, if
781 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 782 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 783
895009e1
JB
7842011-04-26 Juanma Barranquero <lekktu@gmail.com>
785
786 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
787
6a7a1b0b
TZ
7882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
789
790 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 791 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
792 Reported by Paul Eggert <eggert@cs.ucla.edu>.
793
841a1577 7942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
795
796 * lisp.h (Qdebug): List symbol.
895009e1 797 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
798 * keyboard.c (debug-on-event): New variable.
799 (handle_user_signal): Break into debugger when debug-on-event
800 matches the current signal symbol.
801
f2d3ba6f
DN
8022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
803
804 * alloc.c (check_sblock, check_string_bytes)
805 (check_string_free_list): Convert to standard C.
806
42ce4c63
TZ
8072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
808
809 * w32.c (emacs_gnutls_push): Fix typo.
810
825cd63c
EZ
8112011-04-25 Eli Zaretskii <eliz@gnu.org>
812
fb11d64d
EZ
813 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
814 "cast to pointer from integer of different size".
815
825cd63c
EZ
816 Improve doprnt and its use in verror. (Bug#8545)
817 * doprnt.c (doprnt): Document the set of format control sequences
818 supported by the function. Use SAFE_ALLOCA instead of always
819 using `alloca'.
820
821 * eval.c (verror): Don't limit the buffer size at size_max-1, that
822 is one byte too soon. Don't use xrealloc; instead xfree and
823 xmalloc anew.
824
e061a11b
TZ
8252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
826
827 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
828 callbacks stage.
829
830 * gnutls.c: Renamed global_initialized to
831 gnutls_global_initialized. Added internals for the
832 :verify-hostname-error, :verify-error, and :verify-flags
833 parameters of `gnutls-boot' and documented those parameters in the
834 docstring. Start callback support.
835 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
836 unless a fatal error occured. Call gnutls_alert_send_appropriate
837 on error. Return error code.
838 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
839 (emacs_gnutls_read): Likewise.
840 (Fgnutls_boot): Return handshake error code.
841 (emacs_gnutls_handle_error): New function.
842 (wsaerror_to_errno): Likewise.
843
844 * w32.h (emacs_gnutls_pull): Add prototype.
845 (emacs_gnutls_push): Likewise.
846
847 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
848 (emacs_gnutls_push): Likewise.
849
8502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
851
852 * process.c (wait_reading_process_output): Check if GnuTLS
853 buffered some data internally if no FDs are set for TLS
854 connections.
855
856 * makefile.w32-in (OBJ2): Add gnutls.$(O).
857 (LIBS): Link to USER_LIBS.
858 ($(BLD)/gnutls.$(0)): New target.
859
fa6996bc
EZ
8602011-04-24 Eli Zaretskii <eliz@gnu.org>
861
eb35682e
EZ
862 * xdisp.c (handle_single_display_spec): Rename the
863 display_replaced_before_p argument into display_replaced_p, to
864 make it consistent with the commentary. Fix typos in the
865 commentary.
866
e2ad650c
EZ
867 * textprop.c (syms_of_textprop): Remove dead code.
868 (copy_text_properties): Delete obsolete commentary about an
869 interface that was deleted long ago. Fix typos in the description
870 of arguments.
871
1b2de274
EZ
872 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
873 to changes in oldXMenu/XMenu.h from 2011-04-16.
874 <menu_help_message, prev_menu_help_message>: Constify.
875 (IT_menu_make_room): menu->help_text is now `const char **';
876 adjust.
877
878 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
879 to changes in oldXMenu/XMenu.h from 2011-04-16.
880 (struct XMenu): Declare `help_text' `const char **'.
881
882 * xfaces.c <Qunspecified>: Make extern again.
883
884 * syntax.c: Include sys/types.h before including regex.h, as
885 required by Posix.
886
762b15be
EZ
887 * doc.c (get_doc_string): Improve the format passed to `error'.
888
889 * doprnt.c (doprnt): Improve commentary.
890
891 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
892
893 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
894 them with etags.
895
f1052e5d
EZ
896 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
897 changes in globals.h immediately force recompilation.
762b15be
EZ
898 (TAGS): Depend on $(CURDIR)/m/intel386.h and
899 $(CURDIR)/s/ms-w32.h.
900 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 901
fa6996bc
EZ
902 * character.c (Fchar_direction): Function deleted.
903 (syms_of_character): Don't defsubr it.
904 <char-direction-table>: Deleted.
905
e6c3da20
EZ
9062011-04-23 Eli Zaretskii <eliz@gnu.org>
907
908 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
909 * doprnt.c: Include limits.h.
910 (SIZE_MAX): New macro.
04f2d78b
CB
911 (doprnt): Return a size_t value. 2nd arg is now size_t.
912 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
913 Improve overflow protection. Support `l' modifier for integer
914 conversions. Support %l conversion. Don't assume an EMACS_INT
915 argument for integer conversions and for %c.
916
917 * lisp.h (doprnt): Restore prototype.
918
919 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
920 $(SRC)/character.h.
921
922 * Makefile.in (base_obj): Add back doprnt.o.
923
924 * deps.mk (doprnt.o): Add back prerequisites.
925 (callint.o): Depend on character.h.
926
927 * eval.c (internal_lisp_condition_case): Include the handler
928 representation in the error message.
929 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
930 when breaking from the loop.
931
932 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
933
934 * callint.c (Fcall_interactively): When displaying error message
935 about invalid control letter, pass the character's codepoint, not
936 a pointer to its multibyte form. Improve display of the character
937 in octal and display also its hex code.
938
939 * character.c (char_string): Use %x to display the (unsigned)
940 codepoint of an invalid character, to avoid displaying a bogus
941 negative value.
942
943 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
944 `error', not SYMBOL_NAME itself.
945
946 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
947 character arguments to `error'.
948
949 * charset.c (check_iso_charset_parameter): Fix incorrect argument
950 to `error' in error message about FINAL_CHAR argument. Make sure
951 FINAL_CHAR is a character, and use %c when it is passed as
952 argument to `error'.
953
4ffd0d6b 9542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
955
956 * s/ms-w32.h (localtime): Redirect to sys_localtime.
957
958 * w32.c: Include <time.h>.
959 (sys_localtime): New function.
960
4ffd0d6b 9612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
962
963 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
964
4ffd0d6b 965 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 966
4ffd0d6b 9672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 968
4ffd0d6b
GM
969 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
970 zombies (Bug#8467).
aac0c6e3 971
04c56954
EZ
9722011-04-19 Eli Zaretskii <eliz@gnu.org>
973
974 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
975 gl_state.e_property when gl_state.object is Qt.
976
977 * insdel.c (make_gap_larger): Remove limitation of buffer size
978 to <= INT_MAX.
979
16a43933
CY
9802011-04-18 Chong Yidong <cyd@stupidchicken.com>
981
982 * xdisp.c (lookup_glyphless_char_display)
983 (produce_glyphless_glyph): Handle cons cell entry in
984 glyphless-char-display.
985 (Vglyphless_char_display): Document it.
986
987 * term.c (produce_glyphless_glyph): Handle cons cell entry in
988 glyphless-char-display.
989
4581706e
CY
9902011-04-17 Chong Yidong <cyd@stupidchicken.com>
991
992 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
993
994 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
995
996 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
997 definition for no-X builds.
998
4887c6e2 9992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1000
fd35b6f9
PE
1001 Static checks with GCC 4.6.0 and non-default toolkits.
1002
5c1ccb01
PE
1003 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1004
006c5daa
PE
1005 * process.c (keyboard_bit_set): Define only if SIGIO.
1006 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1007 (send_process): Repair possible setjmp clobbering.
1008
efc736d3
PE
1009 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1010
4e2fe2e6
PE
1011 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1012
f97334a2
PE
1013 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1014
4e75f29d
PE
1015 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1016 Define only if needed.
1017
90efadd1
PE
1018 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1019 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1020 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1021
3c647824
PE
1022 * dispextern.h (struct redisplay_interface): Rename param
1023 to avoid shadowing.
e264f262 1024 * termhooks.h (struct terminal): Likewise.
761383f4 1025 * xterm.c (xembed_send_message): Likewise.
3c647824 1026
b58c5c4a
PE
1027 * insdel.c (make_gap_smaller): Define only if
1028 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1029
cad59032
PE
1030 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1031 it.
1032
c339dc2e
PE
1033 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1034 so that we aren't warned about unused symbols.
1035
91a3e27b
PE
1036 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1037
399c71d3 1038 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1039
8ffc96f5
PE
1040 * xfns.c (x_real_positions): Mark locals as initialized.
1041
eef9bc79
PE
1042 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1043
098db9dd
PE
1044 * xterm.c: Fix problems found by static analysis with other toolkits.
1045 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1046 (x_dispatch_event): Declare static if USE_GTK, and
1047 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1048 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1049 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1050 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1051 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1052
eb18f6cc
PE
1053 * xmenu.c (menu_help_callback): Pointer type fixes.
1054 Use const pointers when pointing at readonly data. Avoid pointer
1055 signedness clashes.
1056 (FALSE): Remove unused macro.
1057 (update_frame_menubar): Remove unused decl.
1058
1fe72bf8
PE
1059 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1060
60d9e1db
PE
1061 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1062 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1063 (single_menu_item): Rename local to avoid shadowing.
1064
39261c26
PE
1065 * keyboard.c (make_lispy_event): Remove unused local var.
1066
018c5e19
PE
1067 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1068 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1069
63d2b86e
PE
1070 * bitmaps: Change bitmaps from unsigned char back to the X11
1071 compatible char. Avoid the old compiler warnings about
1072 out-of-range initializers by using, for example, '\xab' rather
1073 than 0xab.
1074
aefd87e1
PE
1075 * xgselect.c (xgselect_initialize): Check vs interface
1076 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1077
bf501fb9
PE
1078 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1079
e9829fdf
PE
1080 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1081 to read-only memory.
1082
1086c095
PE
1083 * fns.c (vector): Remove; this old hack is no longer needed.
1084
2baccd04 1085 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1086 Remove unused var.
dde42981 1087 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1088
72391843 1089 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1090
436c16df 1091 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1092 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1093 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1094
92bb796d 1095 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1096 (x_term_init): Remove local to avoid shadowing.
92bb796d 1097
764430a3 1098 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1099
1100 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1101 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1102
d1dfb56c
EZ
11032011-04-16 Eli Zaretskii <eliz@gnu.org>
1104
c4354cb4
EZ
1105 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1106
d1dfb56c
EZ
1107 Fix regex.c, syntax.c and friends for buffers > 2GB.
1108 * syntax.h (struct gl_state_s): Declare character position members
1109 EMACS_INT.
1110
1111 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1112
04f2d78b
CB
1113 * textprop.c (verify_interval_modification, interval_of):
1114 Declare arguments EMACS_INT.
d1dfb56c
EZ
1115
1116 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1117 EMACS_INT.
1118
1119 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1120
1121 * indent.c (Fvertical_motion): Local variable it_start is now
1122 EMACS_INT.
1123
1124 * regex.c (re_match, re_match_2, re_match_2_internal)
1125 (bcmp_translate, regcomp, regexec, print_double_string)
1126 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1127 (re_compile_pattern, re_exec): Declare arguments and local
1128 variables `size_t' and `ssize_t' and return values `regoff_t', as
1129 appropriate.
1130 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1131 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1132 <compile_stack_type>: `size' and `avail' are now `size_t'.
1133
1134 * regex.h <regoff_t>: Use ssize_t, not int.
1135 (re_search, re_search_2, re_match, re_match_2): Arguments that
1136 specify buffer/string position and length are now ssize_t and
1137 size_t. Return type is regoff_t.
1138
613052cd
BK
11392011-04-16 Ben Key <bkey76@gmail.com>
1140
1141 * nsfont.m: Fixed bugs in ns_get_family and
1142 ns_descriptor_to_entity that were caused by using free to
1143 deallocate memory blocks that were allocated by xmalloc (via
1144 xstrdup). This caused Emacs to crash when compiled with
1145 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1146 --enable-checking=xmallocoverrun). xfree is now used to
1147 deallocate these memory blocks.
1148
4170f62f 11492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1150
71b41406
PE
1151 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1152
9587a89d
PE
1153 emacs_write: Accept and return EMACS_INT for sizes.
1154 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1155 et seq.
1156 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1157 Accept and return EMACS_INT.
1158 (emacs_gnutls_write): Return the number of bytes written on
1159 partial writes.
1160 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1161 (emacs_read, emacs_write): Remove check for negative size, as the
1162 Emacs source code has been audited now.
9587a89d
PE
1163 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1164 (emacs_read, emacs_write): Use it.
273a5f82
PE
1165 * process.c (send_process): Adjust to the new signatures of
1166 emacs_write and emacs_gnutls_write. Do not attempt to store
1167 a byte offset into an 'int'; it might overflow.
9587a89d 1168 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1169
3e047f51
PE
1170 * sound.c: Don't assume sizes fit in 'int'.
1171 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1172 Return EMACS_INT, not int.
3e047f51 1173 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1174 Accept EMACS_INT, not int.
1175 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1176 record read return values.
1177
cc39a9db
BK
11782011-04-15 Ben Key <bkey76@gmail.com>
1179
c9d0ec6d
JB
1180 * keyboard.c (Qundefined): Don't declare static since it is used
1181 in nsfns.m.
1182 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1183 static since they are used in nsfont.m.
cc39a9db 1184
6c60eb9f
SM
11852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1186
1187 * process.c (Qprocessp): Don't declare static.
1188 * lisp.h (Qprocessp): Declare again.
1189
7990b61a
JB
11902011-04-15 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1193
5d4cb038
PE
11942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1195
8bd7b830 1196 Improve C-level modularity by making more things 'static'.
cd64ea1d 1197
e3b27b31
PE
1198 Don't publish debugger-only interfaces to other modules.
1199 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1200 (verify_bytepos, count_markers): Move decls to the only modules
1201 that need them.
1202 * region-cache.h (pp_cache): Likewise.
1203 * window.h (check_all_windows): Likewise.
1204 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1205
5d4cb038
PE
1206 * sysdep.c (croak): Now static, if
1207 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1208 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1209
1210 * alloc.c (refill_memory_reserve): Now static if
1211 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1212 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1213
e87b6180
PE
1214 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1215 Define only if USE_LUCID.
1216
ac64929e
PE
1217 * xrdb.c (x_customization_string, x_rm_string): Now static.
1218
6f37259d
PE
1219 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1220 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1221
1683e3ab
PE
1222 * xdisp.c (draw_row_with_mouse_face): Now static.
1223 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1224
de9c2632
PE
1225 * window.h (check_all_windows): Mark externally visible.
1226
2b96acb7
PE
1227 * window.c (window_deletion_count): Now static.
1228
1229 * undo.c: Make symbols static if they're not exported.
1230 (last_undo_buffer, last_boundary_position, pending_boundary):
1231 Now static.
1232
50436f33
PE
1233 * textprop.c (interval_insert_behind_hooks): Now static.
1234 (interval_insert_in_front_hooks): Likewise.
1235
64520e5c
PE
1236 * term.c: Make symbols static if they're not exported.
1237 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1238 (max_frame_lines, tty_set_terminal_modes):
1239 (tty_reset_terminal_modes, tty_turn_off_highlight):
1240 (get_tty_terminal): Now static.
1241 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1242 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1243 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1244 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1245 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1246
1fa53021
PE
1247 * sysdep.c: Make symbols static if they're not exported.
1248 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1249 Now static.
1250 (sigprocmask_set, full_mask): Remove; unused.
1251 (wait_debugging): Mark as visible.
1252 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1253 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1254
d4b43b22
PE
1255 * syntax.c (syntax_temp): Define only if !__GNUC__.
1256
b7c513d0
PE
1257 * sound.c (current_sound_device, current_sound): Now static.
1258
989b29ad
PE
1259 * search.c (searchbufs, searchbuf_head): Now static.
1260
13a55a78
PE
1261 * scroll.c (scroll_cost): Remove; unused.
1262 * dispextern.h (scroll_cost): Remove decl.
1263
de68a1fc
PE
1264 * region-cache.h (pp_cache): Mark as externally visible.
1265
40ccffa6
PE
1266 * process.c: Make symbols static if they're not exported.
1267 (process_tick, update_tick, create_process, chan_process):
1268 (Vprocess_alist, proc_buffered_char, datagram_access):
1269 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1270 (deactivate_process): Mark defn as static, as well as decl.
1271 * lisp.h (create_process): Remove decl.
1272 * process.h (chan_process, Vprocess_alist): Remove decls.
1273
ad64fc97
PE
1274 * print.c: Make symbols static if they're not exported.
1275 (print_depth, new_backquote_output, being_printed, print_buffer):
1276 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1277 (print_interval, print_number_index, initial_stderr_stream):
1278 Now static.
1279 * lisp.h (Fprinc): Remove decl.
1280 (debug_output_compilation_hack): Mark as externally visible.
1281
adddb265
PE
1282 * sysdep.c (croak): Move decl from here to syssignal.h.
1283 * syssignal.h (croak): Put it here, so the API can be checked when
1284 'croak' is called from dissociate_if_controlling_tty.
1285
1717ede2
PE
1286 * minibuf.c: Make symbols static if they're not exported.
1287 (minibuf_save_list, choose_minibuf_frame): Now static.
1288 * lisp.h (choose_minibuf_frame): Remove decl.
1289
fa5fb2bc
PE
1290 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1291
1e3890d1
PE
1292 * lread.c: Make symbols static if they're not exported.
1293 (read_objects, initial_obarray, oblookup_last_bucket_number):
1294 Now static.
1295 (make_symbol): Remove; unused.
1296 * lisp.h (initial_obarray, make_symbol): Remove decls.
1297
8a1414fa
PE
1298 * keyboard.c: Make symbols static if they're not exported.
1299 (single_kboard, recent_keys_index, total_keys, recent_keys):
1300 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1301 (this_single_command_key_start, echoing, last_auto_save):
1302 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1303 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1304 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1305 (Vlispy_mouse_stem, double_click_count):
1306 Now static.
1307 (force_auto_save_soon): Define only if SIGDANGER.
1308 (ignore_mouse_drag_p): Now static if
1309 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1310 (print_help): Remove; unused.
1311 (stop_character, last_timer_event): Mark as externally visible.
1312 * keyboard.h (ignore_mouse_drag_p): Declare only if
1313 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1314 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1315 * lisp.h (echoing): Remove decl.
1316 (force_auto_save_soon): Declare only if SIGDANGER.
1317 * xdisp.c (redisplay_window): Simplify code, to make it more
1318 obvious that ignore_mouse_drag_p is not accessed if !defined
1319 USE_GTK && !defined HAVE_NS.
1320
93ea6e8f
PE
1321 * intervals.c: Make symbols static if they're not exported.
1322 (merge_properties_sticky, merge_interval_right, delete_interval):
1323 Now static.
1324 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1325
77382fcc
PE
1326 * insdel.c: Make symbols static if they're not exported.
1327 However, leave prepare_to_modify_buffer alone. It's never
1328 called from outside this function, but that appears to be a bug.
1329 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1330 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1331 (adjust_after_replace_noundo): Remove; unused.
1332 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1333 (signal_before_change): Remove decls.
77382fcc 1334
9306c32e
PE
1335 * indent.c (val_compute_motion, val_vmotion): Now static.
1336
cd44d2eb
PE
1337 * image.c: Make symbols static if they're not exported.
1338 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1339 if USE_GTK.
1340 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1341 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1342
ad9a7a06
PE
1343 * fringe.c (standard_bitmaps): Now static.
1344 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1345
81626931
PE
1346 * frame.c: Make symbols static if they're not exported.
1347 (x_report_frame_params, make_terminal_frame): Now static.
1348 (get_frame_param): Now static, unless HAVE_NS.
1349 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1350 (x_get_resource_string): Remove; not used.
1351 * frame.h (make_terminal_frame, x_report_frame_params):
1352 (x_get_resource_string); Remove decls.
1353 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1354 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1355
239f9db9
PE
1356 * font.c, fontset.c: Make symbols static if they're not exported.
1357 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1358 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1359 * font.c (font_close_object): Now static.
1360 * font.h (font_close_object): Remove.
1361 * fontset.c (FONTSET_OBJLIST): Remove.
1362 (free_realized_fontset) #if-0 the body, which does nothing.
1363 (face_suitable_for_char_p): #if-0, as it's never called.
1364 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1365 * xfaces.c (face_at_string_position):
1366 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1367 since 0 is always ASCII.
1368
dfcf3579
PE
1369 * fns.c (weak_hash_tables): Now static.
1370
5045092b
PE
1371 * fileio.c: Make symbols static if they're not exported.
1372 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1373 (Vwrite_region_annotation_buffers): Now static.
1374
57a96f5c
PE
1375 * eval.c: Make symbols static if they're not exported.
1376 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1377 * lisp.h (backtrace_list): Remove decl.
1378
35f08c38
PE
1379 * emacs.c: Make symbols static if they're not exported.
1380 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1381 (fatal_error_code, fatal_error_signal_hook, standard_args):
1382 Now static.
1383 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1384 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1385 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1386 * lisp.h (fatal_error_signal_hook): Remove decl.
1387 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1388
f44bd759
PE
1389 * editfns.c: Move a (normally-unused) function to its only use.
1390 * editfns.c, lisp.h (get_operating_system_release): Remove.
1391 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1392 worth the hassle of breaking this out.
1393
b532497d
PE
1394 * xterm.c: Make symbols static if they're not exported.
1395 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1396 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1397 (x_destroy_window, x_delete_display):
1398 Now static.
1399 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1400 (x_mouse_leave): Remove; unused.
1401 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1402 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1403 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1404 Remove decls.
1405 (x_mouse_leave): Declare only if WINDOWSNT.
1406 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1407 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1408 USE_X_TOOLKIT.
1409
1675728f
PE
1410 * ftxfont.c: Make symbols static if they're not exported.
1411 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1412 HAVE_FREETYPE.
1413 * font.h (ftxfont_driver): Likewise.
1414
e4cebfca
PE
1415 * xfns.c: Make symbols static if they're not exported.
1416 (x_last_font_name, x_display_info_for_name):
1417 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1418 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1419 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1420 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1421 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1422 (last_show_tip_args): Now static.
1423 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1424 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1425 (x_screen_planes): Remove; unused.
1426 * dispextern.h (x_screen_planes): Remove decl.
1427
5bf46f05
PE
1428 * dispnew.c: Make symbols static if they're not exported.
1429 * dispextern.h (redraw_garbaged_frames, scrolling):
1430 (increment_row_positions): Remove.
1431 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1432 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1433 Now static.
1434 (redraw_garbaged_frames): Remove; unused.
1435
435f4c28
PE
1436 * xfaces.c: Make symbols static if they're not exported.
1437 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1438 Remove decls.
1439 * xterm.h (defined_color): Remove decls.
1440 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1441 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1442 (menu_face_changed_default, defined_color, free_realized_face):
1443 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1444 (ascii_face_of_lisp_face): Remove; unused.
1445
8524aef3
PE
1446 * xdisp.c: Make symbols static if they're not exported.
1447 * dispextern.h (scratch_glyph_row, window_box_edges):
1448 (glyph_to_pixel_coords, set_cursor_from_row):
1449 (get_next_display_element, set_iterator_to_next):
1450 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1451 (show_mouse_face): Remove decls
1452 * frame.h (message_buf_print): Likewise.
1453 * lisp.h (pop_message, set_message, check_point_in_composition):
1454 Likewise.
1455 * xterm.h (set_vertical_scroll_bar): Likewise.
1456 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1457 (message_buf_print, scratch_glyph_row, displayed_buffer):
1458 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1459 (get_next_display_element, show_mouse_face, window_box_edges):
1460 (frame_to_window_pixel_xy, check_point_in_composition):
1461 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1462 (glyph_to_pixel_coords): Remove; unused.
1463
16390cd2
PE
1464 * dired.c (file_name_completion): Now static.
1465
1466 * dbusbind.c (xd_in_read_queued_messages): Now static.
1467
a25f4dfa
PE
1468 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1469 * data.c (circular_list_error): Remove.
1470
14a9c8df
PE
1471 * commands.h (last_point_position, last_point_position_buffer):
1472 (last_point_position_window): Remove decls.
1473 * keyboard.c: Make these variables static.
1474
04f2d78b
CB
1475 * coding.h (coding, code_convert_region, encode_coding_gap):
1476 Remove decls.
74ab6df5
PE
1477 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1478 (iso_code_class, detect_coding, code_convert_region): Now static.
1479 (encode_coding_gap): Remove; unused.
1480
38dfbee1
PE
1481 * chartab.c (chartab_chars, chartab_bits): Now static.
1482
a2cb4e63
PE
1483 * charset.h (charset_iso_8859_1): Remove decl.
1484 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1485 Now static.
1486
127198fd
PE
1487 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1488 * ccl.c (Vccl_program_table): Now static.
1489 (check_ccl_update): Remove; unused.
1490
d85b608f
PE
1491 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1492 * category.h: ... from here.
1493 * category.c (check_category_table, set_category_set): Now static.
1494
31cd66f3
PE
1495 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1496 * lisp.h: Remove these decls.
1497
c358e587
PE
1498 * buffer.c (buffer_count): Remove unused var.
1499
e78aecca
PE
1500 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1501 so that it's not optimized away.
1502 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1503 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1504 exported only to the debugger.
1505
e192d7d3 1506 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1507 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1508
92470028
PE
1509 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1510 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1511 was inaccessible from Lisp.
1512 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1513 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1514
244ed907
PE
1515 alloc.c: Import and export fewer symbols, and remove unused items.
1516 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1517 is defined.
1518 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1519 it's not optimized away by whole-program optimization.
1520 (message_enable_multibyte, free_misc): Remove.
1521 (catchlist, handlerlist, mark_backtrace):
1522 Declare only if BYTE_MARK_STACK.
1523 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1524 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1525 (message_enable_multibyte): Remove decl.
1526 (free_misc, interval_free_list, float_block, float_block_index):
1527 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1528 (cons_free_list, last_marked_index):
1529 Now static.
1530 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1531 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1532 (mark_backtrace): Define only if BYTE_MARK_STACK.
1533 * xdisp.c (message_enable_multibyte): Now static.
1534
61c2b50e 1535 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1536 This makes it easier for human readers (and static analyzers)
1537 to see whether these variables are used from other modules.
1538 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1539 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1540 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1541 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1542 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1543 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1544 * xmenu.c, xselect.c:
1545 Declare Q* vars static if they are not used in other modules.
1546 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1547 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1548 Remove decls of unexported vars.
1549 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1550
95c82688
PE
1551 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1552
16a97296
PE
1553 Make Emacs functions such as Fatom 'static' by default.
1554 This makes it easier for human readers (and static analyzers)
1555 to see whether these functions can be called from other modules.
1556 DEFUN now defines a static function. To make the function external
1557 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1558 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1559 (Finit_image_library):
16a97296
PE
1560 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1561 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1562 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1563 Remove decls, since these functions are now static.
1564 (Funintern, Fget_internal_run_time): New decls, since these functions
1565 were already external.
95c82688 1566
16a97296
PE
1567 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1568 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1569 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1570 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1571 * keyboard.c, keymap.c, lread.c:
1572 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1573 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1574 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1575 Mark functions with DEFUE instead of DEFUN,
1576 if they are used in other modules.
1577 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1578 decls for now-static functions.
1579 * buffer.h (Fdelete_overlay): Remove decl.
1580 * callproc.c (Fgetenv_internal): Mark as internal.
1581 * composite.c (Fremove_list_of_text_properties): Remove decl.
1582 (Fcomposition_get_gstring): New forward static decl.
1583 * composite.h (Fcomposite_get_gstring): Remove decl.
1584 * dired.c (Ffile_attributes): New forward static decl.
1585 * doc.c (Fdocumntation_property): New forward static decl.
1586 * eval.c (Ffetch_bytecode): New forward static decl.
1587 (Funintern): Remove extern decl; now in .h file where it belongs.
1588 * fileio.c (Fmake_symbolic_link): New forward static decl.
1589 * image.c (Finit_image_library): New forward static decl.
1590 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1591 * intervals.h (Fprevious_property_change):
1592 (Fremove_list_of_text_properties): Remove decls.
1593 * keyboard.c (Fthis_command_keys): Remove decl.
1594 (Fcommand_execute): New forward static decl.
1595 * keymap.c (Flookup_key): New forward static decl.
1596 (Fcopy_keymap): Now static.
1597 * keymap.h (Flookup_key): Remove decl.
1598 * process.c (Fget_process): New forward static decl.
1599 (Fprocess_datagram_address): Mark as internal.
1600 * syntax.c (Fsyntax_table_p): New forward static decl.
1601 (skip_chars): Remove duplicate decl.
1602 * textprop.c (Fprevious_property_change): New forward static decl.
1603 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1604 Now internal.
1605 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1606 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1607
785bbd42
PE
1608 * editfns.c (Fformat): Remove unreachable code.
1609
8b913b57
AS
16102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1611
1612 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1613 change. (Bug#8496)
1614
a6744a35
EZ
16152011-04-13 Eli Zaretskii <eliz@gnu.org>
1616
1617 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1618 when at ZV. (Bug#8487)
1619
e7974947
AS
16202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1621
baad03f0
AS
1622 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1623 (Bug#8437)
1624 * keyboard.c (parse_tool_bar_item): Likewise.
1625 * sound.c (sound_cleanup, alsa_close): Likewise.
1626 * termcap.c (tgetent): Likewise.
1627 * xfns.c (x_default_font_parameter): Likewise.
1628 * xsettings.c (read_and_apply_settings): Likewise.
1629
e7974947
AS
1630 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1631 (overrun_check_free): Protoize.
1632
28272684
PE
16332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1634
1635 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1636 since callers should never pass a negative size.
1637 Change the signature to match that of plain 'read' and 'write'; see
1638 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1639 * lisp.h: Update prototypes of emacs_write and emacs_read.
1640
11997c76
EZ
16412011-04-11 Eli Zaretskii <eliz@gnu.org>
1642
1643 * xdisp.c (redisplay_window): Don't try to determine the character
1644 position of the scroll margin if the window start point w->startp
e896f03c 1645 is outside the buffer's accessible region. (Bug#8468)
11997c76 1646
8a2cbd72
EZ
16472011-04-10 Eli Zaretskii <eliz@gnu.org>
1648
1649 Fix write-region and its subroutines for buffers > 2GB.
1650 * fileio.c (a_write, e_write): Modify declaration of arguments and
1651 local variables to support buffers larger than 2GB.
1652 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1653
1654 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1655 argument, local variables, and return value.
1656
1657 * lisp.h: Update prototypes of emacs_write and emacs_read.
1658
1659 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1660
4073e537 16612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1662
1ebfdcb6
PE
1663 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1664
b2ded58d
PE
1665 Fix more problems found by GCC 4.6.0's static checks.
1666
7d66342c
PE
1667 * xdisp.c (vmessage): Use a better test for character truncation.
1668
bbf47d44
PE
1669 * charset.c (load_charset_map): <, not <=, for optimization,
1670 and to avoid potential problems with integer overflow.
9248994d 1671 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1672 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1673 * editfns.c (Fformat): Likewise.
1e69125e 1674 * syntax.c (skip_chars): Likewise.
3befa583 1675
e3019616
PE
1676 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1677 This also lets GCC 4.6.0 generate slightly better loop code.
1678
becfa255
PE
1679 * callint.c (Fcall_interactively): <, not <=, for optimization.
1680 (Fcall_interactively): Count the number of arguments produced,
1681 not the number of arguments given. This is simpler and lets GCC
1682 4.6.0 generate slightly better code.
1683
dae0cd48
PE
1684 * ftfont.c: Distingish more carefully between FcChar8 and char.
1685 The previous code passed unsigned char * to a functions like
1686 strlen and xstrcasecmp that expect char *, which does not
1687 conform to the C standard.
1688 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1689 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1690 char * when the C standard requires it.
1691
76032d70
PE
1692 * keyboard.c (read_char): Remove unused var.
1693
eb3f1cc8
PE
1694 * eval.c: Port to Windows vsnprintf (Bug#8435).
1695 Include <limits.h>.
1696 (SIZE_MAX): Define if the headers do not.
1697 (verror): Do not give up if vsnprintf returns a negative count.
1698 Instead, grow the buffer. This ports to Windows vsnprintf, which
1699 does not conform to C99. Problem reported by Eli Zaretskii.
1700 Also, simplify the allocation scheme, by avoiding the need for
1701 calling realloc, and removing the ALLOCATED variable.
1702
70476b54
PE
1703 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1704
12020a9e
PE
1705 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1706 But keep the doprint source code for now, as we might revamp it
1707 and use it again (Bug#8435).
ea6c7ae6
PE
1708 * lisp.h (doprnt): Remove.
1709 * Makefile.in (base_obj): Remove doprnt.o.
1710 * deps.mk (doprnt.o): Remove.
1711
5fdb398c
PE
1712 error: Print 32- and 64-bit integers portably (Bug#8435).
1713 Without this change, on typical 64-bit hosts error ("...%d...", N)
1714 was used to print both 32- and 64-bit integers N, which relied on
1715 undefined behavior.
1716 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1717 New macro.
1718 * lisp.h (error, verror): Mark as printf-like functions.
1719 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1720 Report overflow in size calculations when allocating printf buffer.
1721 Do not truncate output string at its first null byte.
1722 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1723 Truncate the output at a character boundary, since vsnprintf does not
1724 do that.
1725 * charset.c (check_iso_charset_parameter): Convert internal
1726 character to string before calling 'error', since %c now has the
1727 printf meaning.
1728 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1729 overflow when computing char to be passed to 'error'. Do not
1730 pass Lisp_Object to 'error'; pass the integer instead.
1731 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1732 formatted with plain %d.
1733
b189fa66
PE
1734 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1735
bff87ef0
PE
1736 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1737
7e2cac20
PE
1738 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1739
ce4d90b5
PE
1740 * xterm.c (x_catch_errors): Remove duplicate declaration.
1741
266c9547
PE
1742 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1743
79c49ad2
PE
1744 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1745
368f4090
JM
17462011-04-10 Jim Meyering <meyering@redhat.com>
1747
1748 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1749 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1750 return ssize_t not "int", and use size_t as the buffer length.
1751 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1752 * gnutls.h: Update declarations.
1753 * process.c (read_process_output): Use ssize_t, to match.
1754 (send_process): Likewise.
1755
a32d4040
CY
17562011-04-09 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1759
8546720e 17602011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1761
04f2d78b
CB
1762 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1763 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1764
8546720e
GM
1765 * xterm.c (handle_one_xevent):
1766 * xmenu.c (create_and_show_popup_menu):
1767 * xselect.c (x_decline_selection_request)
1768 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1769
0a2f5c1a 17702011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1771
1772 Fix some uses of `int' instead of EMACS_INT.
1773 * search.c (string_match_1, fast_string_match)
1774 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1775 (scan_buffer, find_next_newline_no_quit)
1776 (find_before_next_newline, search_command, Freplace_match)
1777 (Fmatch_data): Make some `int' variables be EMACS_INT.
1778
1779 * xdisp.c (display_count_lines): 3rd argument and return value now
1780 EMACS_INT. All callers changed.
1781 (pint2hrstr): Last argument is now EMACS_INT.
1782
1783 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1784 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1785 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1786 (decode_coding_utf_16, decode_coding_emacs_mule)
1787 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1788 (decode_coding_ccl, decode_coding_charset)
1789 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1790 (decode_coding_iso_2022, decode_coding_emacs_mule)
1791 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1792 <char_offset, last_offset>: Declare EMACS_INT.
1793 (encode_coding_utf_8, encode_coding_utf_16)
1794 (encode_coding_emacs_mule, encode_invocation_designation)
1795 (encode_designation_at_bol, encode_coding_iso_2022)
1796 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1797 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1798 Declare EMACS_INT.
1799 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1800 (encode_invocation_designation): Last argument P_NCHARS is now
1801 EMACS_INT.
1802 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1803 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1804
1805 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1806 All users changed.
1807
1808 * ccl.c (Fccl_execute_on_string): Declare some variables
1809 EMACS_INT.
1810
8546720e 18112011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1812
1813 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1814
4e19a977
CS
18152011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1816
1817 * process.c (Fformat_network_address): Doc fix.
1818
87302331
R
18192011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1820
1821 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1822
cbb59342
CY
18232011-04-08 Chong Yidong <cyd@stupidchicken.com>
1824
1825 * keyboard.c (read_char): Call Lisp function help-form-show,
1826 instead of using internal_with_output_to_temp_buffer.
1827 (Qhelp_form_show): New var.
e0d38eeb 1828 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1829
1830 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1831
1832 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1833
e67a13ab
CY
18342011-04-06 Chong Yidong <cyd@stupidchicken.com>
1835
04f2d78b
CB
1836 * process.c (Flist_processes): Remove to Lisp.
1837 (list_processes_1): Delete.
e67a13ab 1838
973f782d
EZ
18392011-04-06 Eli Zaretskii <eliz@gnu.org>
1840
7c106b1e
EZ
1841 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1842
973f782d
EZ
1843 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1844
41cf7d1a 18452011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1846
ca23cc88
PE
1847 Fix more problems found by GCC 4.6.0's static checks.
1848
f390e2d5
PE
1849 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1850
42eea0d0
PE
1851 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1852
b69769da 1853 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1854
f9541e84
PE
1855 * xdisp.c (vmessage): Mark as a printf-like function.
1856
13841b55
PE
1857 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1858
c136c10f
PE
1859 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1860
5e2d4a30
PE
1861 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1862 printf-like functions.
1863 (tiff_load): Add casts to remove these marks before passing them
1864 to system-supplied API.
1865
583f48b9
PE
1866 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1867
b25d760e
PE
1868 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1869 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1870 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1871 directly, rather than having caller test rule sign. This avoids
1872 some unnecessary tests.
1873 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1874 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1875 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1876
bc7b6697 1877 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1878 (xfont_open): Avoid unnecessary tests.
bc7b6697 1879
27ccc379
PE
1880 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1881
dcd5c89a
PE
1882 * composite.h, composite.c (composition_gstring_put_cache):
1883 Use EMACS_INT, not int, for length.
1884
b13a45c6
PE
1885 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1886 breaking out part of COMPOSITION_DECODE_RULE.
1887 (COMPOSITION_DECODE_RULE): Use it.
1888 * composite.c (get_composition_id): Remove unused local vars,
1889 by using the new macro.
1890
1e792e4d
PE
1891 * textprop.c (set_text_properties_1): Change while to do-while,
1892 since the condition is always true at first.
1893
dc6c6455 1894 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1895 (interval_deletion_adjustment): Return unsigned value.
1896 All uses changed.
dc6c6455 1897
aba7731a
PE
1898 * process.c (list_processes_1, create_pty, read_process_output):
1899 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1900 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1901 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1902 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1903 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1904
fdfc4bf3
PE
1905 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1906
fca8fe46 1907 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1908 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1909
06a0259a 1910 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1911 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1912 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1913
e7b9e80f
PE
1914 * print.c (print_error_message): Avoid int overflow.
1915
56201685
PE
1916 * font.c (font_list_entities): Redo for clarity,
1917 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1918
78834453 1919 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1920 (font_score): Avoid potential overflow in diff calculation.
78834453 1921
0bc0b309 1922 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1923 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1924
e610eaca
PE
1925 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1926
b895abce
PE
1927 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1928 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1929 can always succeed if overflow has undefined behavior.
1930
1f1d9321 1931 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1932 (wordify): Omit three unnecessary tests.
1f1d9321 1933
c59478bc
PE
1934 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1935 All callers changed. This avoids the need for an unused var.
1936
79b73827
PE
1937 * casefiddle.c (casify_region): Remove var that is set but not used.
1938
a4db5dfe
PE
1939 * dired.c (file_name_completion): Remove var that is set but not used.
1940
43aae36e
PE
1941 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1942
2a47c44d 1943 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1944 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1945
a37c69bf
PE
1946 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1947 Check for integer overflow on size calculations.
1948
328ab8e7
PE
1949 * buffer.c (Fprevious_overlay_change): Remove var that is set
1950 but not used.
1951
e5a2a5cb
PE
1952 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1953 Remove vars that are set but not used.
8d84a6eb 1954 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1955 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1956
a60e5f68
PE
1957 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1958
f661cb61 1959 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1960 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1961
f0397f5a
PE
1962 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1963 that are set but not used.
1964
8664db06 1965 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1966 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1967
6abdaa4a
PE
1968 * xselect.c (x_get_local_selection, x_handle_property_notify):
1969 Remove vars that are set but not used.
1970
0ce7538d 1971 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1972 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1973
9ae848fc
PE
1974 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1975 Remove var that is set but not used.
0b918413
PE
1976 (scroll_bar_windows_size): Now size_t, not int.
1977 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1978 Check for overflow.
9ae848fc 1979
a5a62657
PE
1980 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1981 (map_tty_color) [!defined MSDOS]: Likewise.
1982
5c5cdd39
PE
1983 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1984
66ebf983
PE
1985 * coding.c: Remove vars that are set but not used.
1986 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1987 All callers changed.
1988 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1989 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1990 (decode_coding_charset): Remove vars that are set but not used.
1991
1be4d761
PE
1992 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1993 that is set but not used.
1994
47553fa8
PE
1995 * print.c (print_object): Remove var that is set but not used.
1996
1f7196bf 1997 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1998 The gnulib version avoids calling malloc in the usual case,
1999 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2000 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2001 * filelock.c (current_lock_owner): Likewise.
2002 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2003 * sysdep.c: Include allocator.h, careadlinkat.h.
2004 (emacs_no_realloc_allocator): New static constant.
2005 (emacs_readlink): New function.
fdb61804
PE
2006 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2007 ../lib/careadlinkat.h.
d1fdcab7 2008
f84c17c7
SM
20092011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2010
2011 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2012 first non-nil return value).
2013
ef3862ad
JD
20142011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2015
2016 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2017 if not defined (Bug#8403).
2018
376a7006
JB
20192011-04-02 Juanma Barranquero <lekktu@gmail.com>
2020
2021 * xdisp.c (display_count_lines): Remove parameter `start',
2022 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2023 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2024 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2025 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2026 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2027 and thereabouts. All callers changed.
2028 (get_per_char_metric): Remove parameter `f', unused since
2029 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2030
6ca3801d
JM
20312011-04-02 Jim Meyering <meyering@redhat.com>
2032
2033 do not dereference NULL upon failed strdup
2034 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2035 (ns_get_family): Likewise.
2036
d8e2b5ba
JB
20372011-04-02 Juanma Barranquero <lekktu@gmail.com>
2038
2039 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2040
8c74fcbd
JD
20412011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2042
2043 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2044 later (Bug#8403).
2045
7200d79c
SM
20462011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2047
03408648 2048 Add lexical binding.
7200d79c 2049
03408648
SM
2050 * window.c (Ftemp_output_buffer_show): New fun.
2051 (Fsave_window_excursion):
2052 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2053
2054 * lread.c (lisp_file_lexically_bound_p): New function.
2055 (Fload): Bind Qlexical_binding.
2056 (readevalloop): Remove `evalfun' arg.
2057 Bind Qinternal_interpreter_environment.
2058 (Feval_buffer): Bind Qlexical_binding.
2059 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2060 Mark as dynamic.
2061 (syms_of_lread): Declare `lexical-binding'.
2062
2063 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2064
2065 * keyboard.c (eval_dyn): New fun.
2066 (menu_item_eval_property): Use it.
ca105506
SM
2067
2068 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2069
03408648
SM
2070 * fns.c (concat, mapcar1): Accept byte-code-functions.
2071
2072 * eval.c (Fsetq): Handle lexical vars.
2073 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2074 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2075 (FletX, Flet): Obey lexical binding.
2076 (Fcommandp): Handle closures.
2077 (Feval): New `lexical' arg.
2078 (eval_sub): New function extracted from Feval. Use it almost
2079 everywhere where Feval was used. Look up vars in lexical env.
2080 Handle closures.
2081 (Ffunctionp): Move from subr.el.
2082 (Ffuncall): Handle closures.
2083 (apply_lambda): Remove `eval_flags'.
2084 (funcall_lambda): Handle closures and new byte-code-functions.
2085 (Fspecial_variable_p): New function.
2086 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2087 but without exporting it to Lisp.
23aba0ea 2088
23aba0ea 2089 * doc.c (Fdocumentation, store_function_docstring):
03408648 2090 * data.c (Finteractive_form): Handle closures.
23aba0ea 2091
03408648
SM
2092 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2093 interactive spec.
ba83908c 2094
04f2d78b
CB
2095 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2096 New byte-codes.
03408648
SM
2097 (exec_byte_code): New function extracted from Fbyte_code to handle new
2098 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2099
03408648 2100 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2101
03408648 2102 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2103
e2abce01
JB
21042011-03-31 Juanma Barranquero <lekktu@gmail.com>
2105
2106 * xdisp.c (redisplay_internal): Fix prototype.
2107
63696a73 21082011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2109
63696a73 2110 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2111 (try_scrolling): Use it when setting scroll_limit.
2112 Limit scrolling to 100 screen lines.
63696a73
EZ
2113 (redisplay_window): Even when falling back on "recentering",
2114 position point in the window according to scroll-conservatively,
2115 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2116
2117 (try_scrolling): When point is above the window, allow searching
2118 as far as scroll_max, or one screenful, to compute vertical
2119 distance from PT to the scroll margin position. This prevents
2120 try_scrolling from unnecessarily failing when
2121 scroll-conservatively is set to a value slightly larger than the
2122 window height. Clean up the case of PT below the margin at bottom
2123 of window: scroll_max can no longer be INT_MAX. When aggressive
2124 scrolling is in use, don't let point enter the opposite scroll
2125 margin as result of the scroll.
2126 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2127 threshold of 100 lines for never-recentering scrolling.
2128
e4cc2dfc
JB
21292011-03-31 Juanma Barranquero <lekktu@gmail.com>
2130
2131 * dispextern.h (move_it_by_lines):
2132 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2133 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2134 (message_log_check_duplicate): Remove parameters `prev_bol' and
2135 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2136 (redisplay_internal): Remove parameter `preserve_echo_area',
2137 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2138
2139 * indent.c (Fvertical_motion):
2140 * window.c (window_scroll_pixel_based, Frecenter):
2141 Don't pass `need_y_p' to `move_it_by_lines'.
2142
1c470562
SM
21432011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2144
44f230aa
SM
2145 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2146 steal a few bits to be more compact.
2147 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2148 Remove unneeded casts.
2149
1c470562
SM
2150 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2151
888adce9
ZK
21522011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2153
2154 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2155 binding" message (bug#7967).
2156
f838ed7b
PE
21572011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2158
77861b95
PE
2159 Fix more problems found by GCC 4.6.0's static checks.
2160
de6dbc14
PE
2161 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2162 Remove unused local var.
2163
f838ed7b
PE
2164 * editfns.c (Fmessage_box): Remove unused local var.
2165
792c7b2b
PE
2166 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2167 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2168 Omit unused local vars.
c499e557 2169 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2170 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2171 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2172 Omit unused local var.
2173
ba0165e1
PE
2174 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2175 Don't assume string length fits in int.
32ad8845 2176 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2177 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2178
3c59b4c9
PE
2179 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2180 instead of alloca (Bug#8344).
2181
a3eed478 2182 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2183 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2184
eb4d412d
PE
2185 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2186
1658b401
PE
2187 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2188 concerns.
2189
2190 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2191
2192 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2193
9a2c6e05
PE
2194 * keyboard.c (syms_of_keyboard): Use the same style as later
2195 in this function when indexing through an array. This also
2196 works around GCC bug 48267.
2197
03d0a109
PE
2198 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2199
44f730c8
PE
2200 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2201
fe75f926
PE
2202 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2203 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2204
ffa8c828
PE
2205 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2206 This avoids undefined behavior on integer overflow, and is a bit
2207 more convenient anyway since it is compared to a size_t variable.
2208
c5101a77
PE
2209 Variadic C functions now count arguments with size_t, not int.
2210 This avoids an unnecessary limitation on 64-bit machines, which
2211 caused (substring ...) to crash on large vectors (Bug#8344).
2212 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2213 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2214 All variadic functions and their callers changed accordingly.
c5101a77
PE
2215 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2216 * data.c (arith_driver, float_arith_driver): Likewise.
2217 * editfns.c (general_insert_function): Likewise.
2218 * eval.c (struct backtrace.nargs, interactive_p)
2219 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2220 (funcall_lambda, mark_backtrace): Likewise.
2221 * fns.c (concat): Likewise.
2222 * frame.c (x_set_frame_parameters): Likewise.
2223 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2224 0 if not found, not -1. All callers changed.
2225
dd3f25f7
PE
2226 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2227 (stack_copy_size): Now size_t, not int.
2228 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2229
461c2ab9
JB
22302011-03-28 Juanma Barranquero <lekktu@gmail.com>
2231
2232 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2233 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2234 All callers changed.
2235
2236 * lisp.h (multibyte_char_to_unibyte):
2237 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2238 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2239 * character.h (CHAR_TO_BYTE8):
2240 * cmds.c (internal_self_insert):
2241 * editfns.c (general_insert_function):
2242 * keymap.c (push_key_description):
2243 * search.c (Freplace_match):
2244 * xdisp.c (message_dolog, set_message_1): All callers changed.
2245
f6d62986
SM
22462011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2247
2248 * keyboard.c (safe_run_hook_funcall): New function.
2249 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2250 don't set the hook to nil, but remove the offending function instead.
2251 (Qcommand_hook_internal): Remove, unused.
2252 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2253 Vcommand_hook_internal.
2254
2255 * eval.c (enum run_hooks_condition): Remove.
2256 (funcall_nil, funcall_not): New functions.
2257 (run_hook_with_args): Call each function through a `funcall' argument.
2258 Remove `cond' argument, now redundant.
2259 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2260 (Frun_hook_with_args_until_failure): Adjust accordingly.
2261 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2262
1db5b1ad
JB
22632011-03-28 Juanma Barranquero <lekktu@gmail.com>
2264
2265 * dispextern.h (string_buffer_position): Remove declaration.
2266
2267 * print.c (strout): Remove parameter `multibyte', unused since
2268 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2269
2270 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2271 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2272 All callers changed.
2273
2274 * w32.c (_wsa_errlist): Use braces for struct initializers.
2275
2276 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2277 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2278 All callers changed.
2279 (string_buffer_position): Likewise. Also, make static (it's never
2280 used outside xdisp.c).
2281 (cursor_row_p): Remove parameter `w', unused since
2282 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2283 (decode_mode_spec): Remove parameter `precision', introduced during
2284 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2285 All callers changed.
2286
5ffb62aa
JD
22872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2290
461c2ab9 22912011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2292
2293 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2294 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2295 (ns_update_auto_hide_menu_bar): New functions.
2296 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2297 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2298 ns_constrain_all_frames.
2299 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2300 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2301
5c380ffb
JD
23022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2303
2304 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2305
9af30bdf
GM
23062011-03-27 Glenn Morris <rgm@gnu.org>
2307
2308 * syssignal.h: Replace RETSIGTYPE with void.
2309 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2310 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2311 Replace SIGTYPE with void everywhere.
2312 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2313 * s/template.h (SIGTYPE): Remove commented out definition.
2314
e2abce01
JB
23152011-03-26 Eli Zaretskii <eliz@gnu.org>
2316
2317 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2318 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2319
f868cd8a
JB
23202011-03-26 Juanma Barranquero <lekktu@gmail.com>
2321
59eb0929
JB
2322 * w32.c (read_unc_volume): Use parameter `henum', instead of
2323 global variable `wget_enum_handle'.
2324
2325 * keymap.c (describe_vector): Remove parameters `indices' and
2326 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2327 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2328
f868cd8a
JB
2329 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2330
2331 * keyboard.c (timer_check): Remove parameter `do_it_now',
2332 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2333 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2334 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2335
2336 * keyboard.c (read_char):
2337 * w32menu.c (w32_menu_display_help):
2338 * xmenu.c (show_help_event, menu_help_callback):
2339 Adjust calls to `show_help_echo'.
2340
2341 * gtkutil.c (xg_maybe_add_timer):
2342 * keyboard.c (readable_events):
2343 * process.c (wait_reading_process_output):
2344 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2345
2346 * insdel.c (adjust_markers_gap_motion):
2347 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2348 (gap_left, gap_right): Don't call it.
2349
2ecf6fdb
CY
23502011-03-25 Chong Yidong <cyd@stupidchicken.com>
2351
2352 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2353 incurred during fontification.
2354
6b1f9ba4
JB
23552011-03-25 Juanma Barranquero <lekktu@gmail.com>
2356
2357 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2358 (DEFVAR_PER_BUFFER): Don't pass it.
2359
2360 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2361 (scrolling_window): Don't pass it.
2362
0f4a96b5
JB
23632011-03-25 Juanma Barranquero <lekktu@gmail.com>
2364
2365 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2366
2367 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2368 and `suffix'.
2369 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2370 of variables specific to SELinux and computation of `encoded_absname'.
2371
2372 * image.c (XPutPixel): Remove unused variable `height'.
2373
2374 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2375
2376 * unexw32.c (get_section_info): Remove unused variable `section'.
2377
2378 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2379 (system_process_attributes): Remove unused variable `sess'.
2380 (sys_read): Remove unused variable `err'.
2381
2382 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2383 (w32_wnd_proc): Remove unused variable `isdead'.
2384 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2385 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2386 (x_create_tip_frame): Remove unused variable `tem'.
2387
2388 * w32inevt.c (w32_console_read_socket):
2389 Remove unused variable `no_events'.
2390
2391 * w32term.c (x_draw_composite_glyph_string_foreground):
2392 Remove unused variable `width'.
2393
1149507c
JB
23942011-03-24 Juanma Barranquero <lekktu@gmail.com>
2395
2396 * w32term.c (x_set_glyph_string_clipping):
2397 Don't pass uninitialized region to CombineRgn.
2398
9c88f339
JB
23992011-03-23 Juanma Barranquero <lekktu@gmail.com>
2400
2401 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2402 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2403 (Fx_close_connection): Remove unused variable `i'.
2404
2405 * w32font.c (w32font_draw): Return number of glyphs.
2406 (w32font_open_internal): Remove unused variable `i'.
2407 (w32font_driver): Add missing initializer.
2408
2409 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2410 (fill_in_menu): Remove unused variable `items_added'.
2411
2412 * w32term.c (last_mouse_press_frame): Remove static global variable.
2413 (w32_clip_to_row): Remove unused variable `f'.
2414 (x_delete_terminal): Remove unused variable `i'.
2415
2416 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2417 (NOTHING): Remove unused static global variable.
2418 (uniscribe_check_otf): Remove unused variable `table'.
2419 (uniscribe_font_driver): Add missing initializers.
2420
dee091a3
JD
24212011-03-23 Julien Danjou <julien@danjou.info>
2422
2423 * term.c (Fsuspend_tty, Fresume_tty):
2424 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2425 * window.c (temp_output_buffer_show):
2426 * insdel.c (signal_before_change):
2427 * frame.c (Fhandle_switch_frame):
2428 * fileio.c (Fdo_auto_save):
2429 * emacs.c (Fkill_emacs):
2430 * editfns.c (save_excursion_restore):
2431 * cmds.c (internal_self_insert):
2432 * callint.c (Fcall_interactively):
2433 * buffer.c (Fkill_all_local_variables):
2434 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2435 Use Frun_hooks.
0f4a96b5 2436 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2437 unconditionnaly since it does the check itself.
2438
2c520ab5 24392011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2440
c9c49752
PE
2441 Fix more problems found by GCC 4.5.2's static checks.
2442
8abc3f12
PE
2443 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2444 the first time through the loop, since we know p0 < p1 then.
2445 This also avoids a gcc -Wstrict-overflow warning.
2446
a2d26660
PE
2447 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2448 leading to a memory leak, possible in functions like
2449 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2450 of objects (Bug#8318).
a2d26660 2451
916c72e9
PE
2452 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2453 that could (at least in theory) be that large.
2454
19ab8a18
PE
2455 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2456 This is less likely to overflow, and avoids undefined behavior if
2457 overflow does occur. All callers changed. Use strtoul to scan
2458 for the unsigned long integer.
b7cbbd6f
PE
2459 (pint2hrstr): Simplify and tune code slightly.
2460 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2461
f0641eff
PE
2462 * scroll.c (do_scrolling): Work around GCC bug 48228.
2463 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2464
7f650bb9
PE
2465 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2466 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2467 (validate_x_resource_name): Simplify count usage.
2468 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2469
37dd57d1
PE
2470 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2471 fail (Bug#8306).
81e56e61 2472
699979fc 2473 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2474
401bf9b4
PE
2475 * process.c (Fmake_network_process): Use socklen_t, not int,
2476 where POSIX says socklen_t is required in portable programs.
2477 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2478 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2479 (Fmake_network_process, server_accept_connection):
2480 (wait_reading_process_output, read_process_output):
2481 Likewise.
2482
b93aacde
PE
2483 * process.c: Rename or move locals to avoid shadowing.
2484 (list_processes_1, Fmake_network_process):
2485 (read_process_output_error_handler, exec_sentinel_error_handler):
2486 Rename or move locals.
4dc343ee 2487 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2488 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2489 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2490 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2491 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2492
af8a867c 2493 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2494 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2495 Include tparam.h instead, since it declares them.
af8a867c
PE
2496 * cm.h (PC): Remove extern decl; tparam.h now does this.
2497 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2498 * terminfo.c: Include tparam.h, to check interfaces.
2499 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2500 (tparam): Adjust signature to match interface in tparam.h;
2501 this removes some undefined behavior. Check that outstring and len
2502 are zero, which they always are with Emacs.
2503 * tparam.h (PC, BC, UP): New extern decls.
2504
0248044d 2505 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2506 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2507
8ff096c1 2508 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2509 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2510 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2511 (ftfont_list): Remove unused local.
49eaafba
PE
2512 (get_adstyle_property, ftfont_pattern_entity):
2513 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2514 Rename locals to avoid shadowing.
8ff096c1 2515
e2be39f6
PE
2516 * xfont.c (xfont_list_family): Mark var as initialized.
2517
c9735e30
PE
2518 * xml.c (make_dom): Now static.
2519
8f5201ae
PE
2520 * composite.c (composition_compute_stop_pos): Rename local to
2521 avoid shadowing.
b246f932
PE
2522 (composition_reseat_it): Remove unused locals.
2523 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2524 (composition_update_it): Mark var as initialized.
11b61122
PE
2525 (find_automatic_composition): Mark vars as initialized,
2526 with a FIXME (Bug#8290).
8f5201ae 2527
760fbc2c
PE
2528 character.h: Rename locals to avoid shadowing.
2529 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2530 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2531 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2532 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2533 to avoid shadowing.
2534
ff08eb85
PE
2535 * textprop.c (property_change_between_p): Remove; unused.
2536
fc7bf025
PE
2537 * intervals.c (interval_start_pos): Now static.
2538
235d7abc
PE
2539 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2540
44f230aa
SM
2541 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2542 Rename locals to avoid shadowing.
3e7d6594 2543
50060332
PE
2544 * sound.c (wav_play, au_play, Fplay_sound_internal):
2545 Fix pointer signedness.
d01f234b 2546 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2547 (wav_play): Initialize a variable to 0, to prevent undefined
2548 behavior (Bug#8278).
50060332 2549
c4fc4e30
PE
2550 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2551
918436ed
PE
2552 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2553
c939f91b
PE
2554 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2555 clobbering (Bug#8298).
b9c7f648
PE
2556 * sysdep.c (sys_subshell): Likewise.
2557 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2558
6bd8c144
PE
2559 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2560 This should get cleaned up, so that child_setup has the
2561 same signature on all platforms.
2562
7710357c 2563 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2564 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2565
c59da222
CY
25662011-03-22 Chong Yidong <cyd@stupidchicken.com>
2567
2568 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2569 not to be necessary, and produces flickering.
2570
66b87493
GM
25712011-03-20 Glenn Morris <rgm@gnu.org>
2572
2573 * config.in: Remove file.
2574
45b6f6d5
JB
25752011-03-20 Juanma Barranquero <lekktu@gmail.com>
2576
2577 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2578 are now in src/globals.h.
2579 (syms_of_minibuf): Remove spurious & from previous change.
2580
3ec03f7e
LL
25812011-03-20 Leo <sdl.web@gmail.com>
2582
2583 * minibuf.c (completing-read-function): New variable.
2584 (completing-read-default): Rename from completing-read.
2585 (completing-read): Call completing-read-function.
2586
b14e3e21
CY
25872011-03-19 Juanma Barranquero <lekktu@gmail.com>
2588
2589 * xfaces.c (Fx_load_color_file):
2590 Read color file from absolute filename (bug#8250).
2591
f2b726e6
JB
25922011-03-19 Juanma Barranquero <lekktu@gmail.com>
2593
2594 * makefile.w32-in: Update dependencies.
2595
09f6ff02
EZ
25962011-03-17 Eli Zaretskii <eliz@gnu.org>
2597
2598 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2599
29a6015a
PE
26002011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2601
a3a6c54e
PE
2602 Fix more problems found by GCC 4.5.2's static checks.
2603
b766f867
PE
2604 * process.c (make_serial_process_unwind, send_process_trap):
2605 (sigchld_handler): Now static.
2606
be02381c
PE
2607 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2608 That way, the code declares only the vars that it needs.
2609 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2610 * s/cygwin.h (PTY_ITERATION): Likewise.
2611 * s/darwin.h (PTY_ITERATION): Likewise.
2612 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2613
57048744
PE
2614 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2615 * process.c (allocate_pty): Don't declare stb unless it's needed.
2616
7914961c 2617 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2618 (CONSTANTLIM): Remove; unused.
2619 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2620 Define only if needed.
7914961c 2621
b3967b18
PE
2622 * unexelf.c (unexec): Name an expression,
2623 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2624 Use a different way to cause a compilation error if anyone uses
2625 n rather than nn, a way that does not involve shadowing.
73366a00 2626 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2627
29a6015a
PE
2628 * deps.mk (unexalpha.o): Remove; unused.
2629
43cfc33e 2630 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2631 * unexec.h: New file.
ce701a33
PE
2632 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2633 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2634 Depend on unexec.h.
2635 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2636 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2637 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2638 Change as necessary to match prototype in unexec.h.
ce701a33 2639
01f44d5a
PE
2640 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2641 shadowing.
4f63c6bb 2642 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2643
a6670b0b
PE
2644 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2645 Rename locals to avoid shadowing.
2646
cef2010d 2647 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2648 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2649
d4d7173a
PE
2650 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2651
f08b802a
PE
2652 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2653 warning when compiling print.c.
2654
3ddb0639
PE
2655 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2656 instead of using an uninitialized var.
5ad03b97 2657 (font_sort_entities): Mark var as initialized.
3ddb0639 2658
170a2692
PE
2659 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2660
e663c700
PE
2661 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2662 pointers to constants.
89bc529a 2663 (font_parse_fcname): Remove unused vars.
7b81e2d0 2664 (font_delete_unmatched): Now static.
ea838e10 2665 (font_get_spec): Remove; unused.
13a547c6
PE
2666 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2667 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2668 Rename or move locals to avoid shadowing.
e663c700 2669
2a80c887 2670 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2671 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2672
1384fa33 2673 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2674 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2675
8b2c52e9
PE
2676 * alloc.c (mark_backtrace): Move decl from here ...
2677 * lisp.h: ... to here, so that it can be checked.
2678
475545b5 2679 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2680 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2681 (lisp_indirect_variable): Name an expression,
2682 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2683 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2684
b1349114 2685 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2686 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2687 Use const pointer when appropriate.
b1349114 2688
a2928364
PE
2689 * lisp.h (get_system_name, get_operating_system_release):
2690 Move decls here, to check interfaces.
2691 * process.c (get_operating_system_release): Move decl to lisp.h.
2692 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2693 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2694 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2695 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2696 (Fformat_time_string, Fencode_time, Finsert_char):
2697 (Ftranslate_region_internal, Fformat):
2698 Rename or remove local vars to avoid shadowing.
9710023e 2699 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2700
a415e694
PE
2701 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2702 avoid shadowing.
2703
8ef4622d
PE
2704 * lisp.h (eassert): Check that the argument compiles, even if
2705 ENABLE_CHECKING is not defined.
2706
946f9a5b
PE
2707 * data.c (Findirect_variable): Name an expression, to avoid
2708 gcc -Wbad-function-cast warning.
112396d6 2709 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2710 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2711 (Fmake_variable_buffer_local, Fmake_local_variable):
2712 Mark variables as initialized.
52746918 2713 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2714
e5aab7e7 2715 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2716 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2717 Rename locals to avoid shadowing.
dff45157
PE
2718 (mark_stack): Move local variables into the #ifdef region where
2719 they're used.
7bc26fdb
PE
2720 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2721 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2722 needed otherwise.
2723 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2724 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2725 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2726
e5aab7e7
PE
2727 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2728 avoids undefined behavior in theory.
2729
4da60324
PE
2730 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2731
88043301
PE
2732 Use functions, not macros, for up- and down-casing (Bug#8254).
2733 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2734 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2735 to use the following functions instead of these macros.
2736 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2737 EMACS_INT, since callers assume the returned value fits in int.
2738 (upcase1): Likewise, for UPCASE_TABLE.
2739 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2740 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2741 the race-condition problem in the old DOWNCASE.
88043301 2742
19ed5445
PE
2743 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2744 Rename locals to avoid shadowing.
2745 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2746 (regex_compile, re_search_2, re_match_2_internal):
2747 Remove unused local vars.
952db0d7
PE
2748 (FREE_VAR): Rewrite so as not to use empty "else",
2749 which gcc can warn about.
da053e48 2750 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2751 (RETALLOC_IF): Define only if needed.
2752 (WORDCHAR_P): Likewise. This one is never needed, but is used
2753 only in a comment talking about a compiler bug, so put inside
2754 the #if 0 of that comment.
2755 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2756 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2757 Remove; unused.
19ed5445 2758
1f3561e4 2759 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2760 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2761 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2762
ded6f8f7
PE
2763 * search.c (simple_search): Remove unused var.
2764
dbd37a95
PE
2765 * dired.c (compile_pattern): Move decl from here ...
2766 * lisp.h: ... to here, so that it can be checked.
2767 (struct re_registers): New forward decl.
2768
7e47afad
PE
2769 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2770
85f24f61
PE
2771 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2772 All uses changed.
2773 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2774 Rename locals to avoid shadowing.
5671df8f 2775 (Fvertical_motion): Mark locals as initialized.
85f24f61 2776
181aa2be 2777 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2778 (casify_region): Mark local as initialized.
181aa2be 2779
930d429c
PE
2780 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2781
7082eac6
PE
2782 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2783 New macros, so that the caller can use some names other than
2784 gcpro1, gcpro2, etc.
2785 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2786 of the new macros.
2787 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2788 argument, for consistency with GCPRO2_VAR, etc: it is now the
2789 prefix of the variable, not the variable itself. All uses
2790 changed.
38b2c076
PE
2791 * dired.c (directory_files_internal, file_name_completion):
2792 Rename locals to avoid shadowing.
2793
15206ed9
PE
2794 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2795 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2796 dired.c's scmp function, had undefined behavior.
2797 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2798 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2799 * buffer.h: ... to here, because these macros use current_buffer,
2800 and the new implementation with inline functions needs to have
2801 current_buffer in scope now, rather than later when the macros
2802 are used.
2803 (downcase, upcase1): New static inline functions.
2804 (DOWNCASE, UPCASE1): Reimplement using these functions.
2805 This avoids undefined behavior in expressions like
2806 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2807 from race conditions in accessing the global variables
2808 case_temp1 and case_temp2.
2809 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2810 * lisp.h (case_temp1, case_temp2): Remove their decls.
2811 * character.h (ASCII_CHAR_P): Move from here ...
2812 * lisp.h: ... to here, so that the inline functions mentioned
2813 above can use them.
2814
4a6bea26
PE
2815 * dired.c (directory_files_internal_unwind): Now static.
2816
f14b7e14
PE
2817 * fileio.c (file_name_as_directory, directory_file_name):
2818 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2819 Now static.
2893f146
PE
2820 (file_name_as_directory): Use const pointers when appropriate.
2821 (Fexpand_file_name): Likewise. In particular, newdir might
2822 point at constant storage, so make it a const pointer.
fd4ead52 2823 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2824 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2825 signedness issues.
f839df0c
PE
2826 (Fset_file_times, Finsert_file_contents, auto_save_error):
2827 Rename locals to avoid shadowing.
f14b7e14 2828
5716756e 2829 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2830 (Ftry_completion, Fall_completions): Rename or remove locals
2831 to avoid shadowing.
5716756e 2832
b4c3046a
PE
2833 * marker.c (bytepos_to_charpos): Remove; unused.
2834
b45db522
PE
2835 * lisp.h (verify_bytepos, count_markers): New decls,
2836 so that gcc does not warn that these functions aren't declared.
2837
85876d07
PE
2838 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2839 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2840 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2841 (copy_text): Remove unused local var.
85876d07 2842
03d78a21 2843 * filelock.c (within_one_second): Now static.
b3dd38ab 2844 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2845
5df8f01b
PE
2846 * buffer.c (fix_overlays_before): Mark locals as initialized.
2847 (fix_start_end_in_overlays): Likewise. This function should be
2848 simplified by using pointers-to-pointers, but that's a different
2849 matter.
b1d876f1 2850 (switch_to_buffer_1): Now static.
8f54f30a
PE
2851 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2852 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2853
a70072c9 2854 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2855 Fix pointer signedness issue.
edced198
PE
2856 (sys_subshell): Mark local as volatile if checking for lint,
2857 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2858 (MAXPATHLEN): Define only if needed.
a70072c9 2859
a0977c44
PE
2860 * process.c (serial_open, serial_configure): Move decls from here ...
2861 * systty.h: ... to here, so that they can be checked.
2862
a884fdcc
PE
2863 * fns.c (get_random, seed_random): Move extern decls from here ...
2864 * lisp.h: ... to here, so that they can be checked.
2865
604efe86 2866 * sysdep.c (reset_io): Now static.
b8950c94 2867 (wait_for_termination_signal): Remove; unused.
604efe86 2868
38fc62d9
PE
2869 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2870 (copy_keymap_item, append_key, push_text_char_description):
2871 Now static.
1004a21a 2872 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2873 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2874 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2875 (describe_map_tree):
2876 Rename locals to avoid shadowing.
38fc62d9 2877
2f2650da
PE
2878 * keyboard.c: Declare functions static if they are not used elsewhere.
2879 (echo_char, echo_dash, cmd_error, top_level_2):
2880 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2881 (read_char, kbd_buffer_get_event, make_lispy_position):
2882 (make_lispy_event, make_lispy_movement, apply_modifiers):
2883 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2884 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2885 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2886 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2887 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2888
a053e86c 2889 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2890 (mark_kboards): Move decl here ...
2891 * alloc.c (mark_kboards): ... from here.
a053e86c 2892
4752793e
PE
2893 * lisp.h (force_auto_save_soon): New decl.
2894
74f10ca7 2895 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2896 (DEFINE_DUMMY_FUNCTION): New macro.
2897 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2898 Use it.
c03cd23f
PE
2899 (main): Add casts to avoid warnings
2900 if GCC considers string literals to be constants.
74f10ca7 2901
022e70d4
PE
2902 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2903
59d6fe83
PE
2904 * dbusbind.c: Pointer signedness fixes.
2905 (xd_signature, xd_append_arg, xd_initialize):
2906 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2907 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2908 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2909 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2910
78320123
PE
2911 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2912 if GCC considers string literals to be constants.
49cebcca 2913 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2914
35ac2a97
SM
29152011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2916
fb103ca9
SM
2917 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2918 (print_preprocess, print_object): New macro to fix last change.
2919
35ac2a97
SM
2920 * print.c (print_preprocess): Don't forget font objects.
2921
62973b41
JB
29222011-03-16 Juanma Barranquero <lekktu@gmail.com>
2923
2924 * emacs.c (USAGE3): Doc fixes.
2925
0e48bb22
AS
29262011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2927
2928 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2929 structure.
2930
7684e57b
JB
29312011-03-14 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * lisp.h (VWindow_system, Qfile_name_history):
2934 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2935 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2936 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2937
2938 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2939 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2940
2941 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2942 * w32console.c (detect_input_pending, read_input_pending)
2943 (encode_terminal_code):
2944 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2945 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2946 (w32_system_caret_y, Qfile_name_history):
2947 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2948 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2949 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2950 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2951 * w32proc.c (Qlocal, report_file_error):
2952 * w32term.c (Vwindow_system, updating_frame):
2953 * w32uniscribe.c (initialized, uniscribe_font_driver):
2954 Remove unneeded extern declarations.
2955
2aa46d6c
CY
29562011-03-14 Chong Yidong <cyd@stupidchicken.com>
2957
c96bbc66 2958 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2959
cffc6f3b
CY
29602011-03-13 Chong Yidong <cyd@stupidchicken.com>
2961
2962 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2963 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2964 These macros can no longer be used for assignment.
2965
44f230aa
SM
2966 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2967 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2968 (record_buffer_markers, fetch_buffer_markers): New functions for
2969 recording and fetching special buffer markers.
2970 (set_buffer_internal_1, set_buffer_temp): Use them.
2971
2972 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2973
2974 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2975
2976 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2977 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2978
2979 * xdisp.c (hscroll_window_tree):
2980 (reconsider_clip_changes): Use PT instead of BUF_PT.
2981
d251f04b
EZ
29822011-03-13 Eli Zaretskii <eliz@gnu.org>
2983
2984 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2985 $(EMACS_ROOT)/lib/intprops.h.
2986
f0c77cd1
PE
29872011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2988
3eca4629
PE
2989 Fix more problems found by GCC 4.5.2's static checks.
2990
7c86ee98
PE
2991 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2992 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2993 (xg_free_frame_widgets): Make it clear that a local variable is
2994 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2995 (gdk_window_get_screen): Make it clear that this macro is needed
2996 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2997 (int_gtk_range_get_value): New function, which avoids a diagnostic
2998 from gcc -Wbad-function-cast.
2999 (xg_set_toolkit_scroll_bar_thumb): Use it.
3000 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3001 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3002 (get_utf8_string, xg_get_file_with_chooser):
3003 Rename locals to avoid shadowing.
3004 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3005
41729b81
PE
3006 * xgselect.c (xg_select): Remove unused var.
3007
f0c77cd1
PE
3008 * image.c (four_corners_best): Mark locals as initialized.
3009 (gif_load): Initialize transparent_p to zero (Bug#8238).
3010 Mark another local as initialized.
ec6cf4c6 3011 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3012
ce0ad53d 3013 * image.c (clear_image_cache): Now static.
d5d5a617 3014 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3015 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3016 (x_edge_detection): Remove unnecessary cast that
3017 gcc -Wbad-function-cast diagnoses.
2037898d 3018 (gif_load): Fix pointer signedness.
6ae141d6
PE
3019 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3020 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3021
33383987 30222011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3023
d32df629
PE
3024 Improve quality of tests for time stamp overflow.
3025 For example, without this patch (encode-time 0 0 0 1 1
3026 1152921504606846976) returns the obviously-bogus value (-948597
3027 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3028 reports time overflow. See
3029 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3030 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3031 * editfns.c: Include limits.h and intprops.h.
3032 (TIME_T_MIN, TIME_T_MAX): New macros.
3033 (time_overflow): Move earlier, to before first use.
3034 (hi_time, lo_time): New functions, for an accurate test for
3035 out-of-range times.
3036 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3037 (Fget_internal_run_time): Don't assume time_t fits in int.
3038 (make_time): Use list2 instead of Fcons twice.
3039 (Fdecode_time): More accurate test for out-of-range times.
3040 (check_tm_member): New function.
3041 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3042 (lisp_time_argument): Don't rely on undefined left-shift and
3043 right-shift behavior when checking for time stamp overflow.
8be6f318 3044
fe31d94c
PE
3045 * editfns.c (time_overflow): New function, refactoring common code.
3046 (Fformat_time_string, Fdecode_time, Fencode_time):
3047 (Fcurrent_time_string): Use it.
3048
8be6f318
PE
3049 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3050 * dired.c (make_time): Move to ...
3051 * editfns.c (make_time): ... here.
3052 * systime.h: Note the move.
3053
09d9db2c 30542011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3055
126bc0dc
YM
3056 * fringe.c (update_window_fringes): Remove unused variables.
3057
c47cbdfd
YM
3058 * unexmacosx.c (copy_data_segment): Also copy __got section.
3059 (Bug#8223)
3060
7ac80be9
EZ
30612011-03-12 Eli Zaretskii <eliz@gnu.org>
3062
c96bbc66 3063 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3064 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3065 Constify `char *' arguments and their references according to
3066 prototypes in tparam.h.
3067
ecb0f94d 3068 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3069
7ac80be9
EZ
3070 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3071 Adapt all references accordingly.
3072
3073 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3074
ef1fd07e
TT
30752011-03-11 Tom Tromey <tromey@redhat.com>
3076
3077 * buffer.c (syms_of_buffer): Remove obsolete comment.
3078
7ef4b50c
EZ
30792011-03-11 Eli Zaretskii <eliz@gnu.org>
3080
3081 * termhooks.h (encode_terminal_code): Declare prototype.
3082
3083 * msdos.c (encode_terminal_code): Don't declare prototype.
3084
3085 * term.c (encode_terminal_code): Now external again, used by
3086 w32console.c and msdos.c.
3087
44f230aa
SM
3088 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3089 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3090
4b1ec863 30912011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3092
1714f52b 3093 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3094
4b1ec863
PE
3095 * fringe.c (update_window_fringes): Mark locals as initialized
3096 (Bug#8227).
3097 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3098
524c7aa6
PE
3099 * alloc.c (mark_fringe_data): Move decl from here ...
3100 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3101 to check its interface.
3102 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3103
a5c0af81 3104 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3105 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3106 (fontset_font): Mark local as initialized.
a9a06e0b 3107 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3108
b4716021
PE
3109 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3110
811e9bac 3111 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3112 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3113 (x_own_selection, Fx_disown_selection_internal): Rename locals
3114 to avoid shadowing.
3115 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3116
7e3ab302
PE
3117 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3118 so that the caller can use some name other than gcpro1.
3119 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3120 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3121 (Fx_backspace_delete_keys_p):
3122 Use them to avoid shadowing, and rename vars to avoid shadowing.
3123 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3124 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3125 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3126 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3127 Remove unused locals.
7e3ab302
PE
3128 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3129 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3130 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3131 macros.
f78faa98 3132
e2b13473
PE
3133 * xterm.h (x_mouse_leave): New decl.
3134
77f23912
PE
3135 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3136 Remove unused functions.
cdf4ba58
PE
3137 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3138 (x_calc_absolute_position): Now static.
7411c686 3139 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3140 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3141 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3142 unless they are used.
38d0b34a
PE
3143 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3144 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3145 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3146 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3147 (x_error_catcher, x_connection_closed, x_error_handler):
3148 (x_error_quitter, xembed_send_message, x_iconify_frame):
3149 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3150 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3151 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3152
44f230aa
SM
3153 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3154 Rename or move locals to avoid shadowing.
6b463e58 3155 (tty_defined_color, merge_face_heights): Now static.
5967d051 3156 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3157 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3158 does not deduce is never used uninitialized.
73719eba
PE
3159 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3160 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3161
426994c3 3162 * terminal.c (store_terminal_param): Now static.
5489860b 3163
032f1620 3164 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3165 (set_frame_menubar): Remove unused local.
d4323972 3166 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3167 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3168 since they might point to immutable storage.
281585b0
PE
3169 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3170 since it's unused otherwise.
032f1620 3171
367c19e5 3172 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3173 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3174 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3175 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3176 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3177 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3178 does not deduce are never used uninitialized.
70739cbe 3179
07b48fa9
PE
3180 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3181
8868a238 3182 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3183 * window.c (window_loop, size_window):
3184 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3185
7e5cf297 3186 * window.c (display_buffer): Now static.
d6550a9f
PE
3187 (size_window): Mark variables that gcc -Wuninitialized
3188 does not deduce are never used uninitialized.
a586633d
PE
3189 * window.h (check_all_windows): New decl, to forestall
3190 gcc -Wmissing-prototypes diagnostic.
5b555da1 3191 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3192
f6095868
PE
3193 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3194 shadowing.
3195 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3196 Include <limits.h>.
3197 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3198 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3199 (load_charset_map): Mark variables that gcc -Wuninitialized
3200 does not deduce are never used uninitialized.
53df7c11 3201 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3202
f38b440c
PE
3203 * coding.c (coding_set_source, coding_set_destination):
3204 Use "else { /* comment */ }" rather than "else /* comment */;"
3205 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3206 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3207 a block, when the outer 'i' will do.
3208 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3209 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3210 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3211 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3212 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3213 Rename locals to avoid shadowing.
3214 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3215 * coding.c (emacs_mule_char, encode_invocation_designation):
3216 Now static, since they're not used elsewhere.
413bb2db 3217 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3218 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3219 (decode_coding_emacs_mule): Mark variables that gcc
3220 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3221 (detect_coding_iso_2022): Initialize a local variable that might
3222 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3223 this initialization is needed. (Bug#8211)
5f58e762
PE
3224 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3225 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3226 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3227 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3228 Remove unused macros.
f38b440c 3229
232b38b9 3230 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3231 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3232 * character.c (string_count_byte8): Likewise.
232b38b9 3233
fb90da1b
PE
3234 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3235 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3236
fb93dbc2
PE
3237 * chartab.c (copy_sub_char_table): Now static, since it's not used
3238 elsewhere.
5c156ace
PE
3239 (sub_char_table_ref_and_range, char_table_ref_and_range):
3240 Rename locals to avoid shadowing.
bbcd0949 3241 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3242
7d3b3862 3243 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3244 (BIDI_BOB): Remove unused macro.
7d3b3862 3245
6be7d3da
PE
3246 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3247 deduce are never used uninitialized.
c2ed9c8b 3248 * term.c (encode_terminal_code): Likewise.
6be7d3da 3249
75f8807f 3250 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3251
50938595
PE
3252 * tparam.h: New file.
3253 * term.c, tparam.h: Include it.
3254 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3255 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3256 Move these decls to tparam.h, and make them agree with what
3257 is actually in tparam.c. The previous trick of using incompatible
3258 decls in different modules does not conform to the C standard.
3259 All callers of tparam changed to use tparam's actual API.
3260 * tparam.c (tparam1, tparam, tgoto):
3261 Use const pointers where appropriate.
3262
fbceeba2
PE
3263 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3264 * cm.h (struct cm): Likewise.
3265 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3266 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3267 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3268 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3269 (turn_on_face, init_tty): Likewise.
3270 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3271
7f3f1250
PE
3272 * term.c (term_mouse_position): Rename local to avoid shadowing.
3273
e6ca6543
PE
3274 * alloc.c (mark_ttys): Move decl from here ...
3275 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3276
c40f8d15
AS
32772011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3280
cfe0661d
JB
32812011-03-09 Juanma Barranquero <lekktu@gmail.com>
3282
3283 * search.c (compile_pattern_1): Remove argument regp, unused since
3284 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3285 (compile_pattern): Don't pass it.
3286
0afb4571
J
32872011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3288
3289 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3290 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3291 for ! HAVE_GTK3.
3292 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3293
3294 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3295
3296 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3297 gdk_window_get_screen, gdk_window_get_geometry,
3298 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3299 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3300 (xg_get_pixbuf_from_pixmap): New function.
3301 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3302 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3303 Call xg_get_pixbuf_from_pixmap instead of
3304 gdk_pixbuf_get_from_drawable.
3305 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3306 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3307 (xg_check_special_colors): Use GtkStyleContext and its functions
3308 for HAVE_GTK3.
3309 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3310 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3311 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3312 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3313 Call gtk_widget_get_preferred_size.
0afb4571
J
3314 (xg_frame_resized): gdk_window_get_geometry only takes 5
3315 parameters.
44f230aa
SM
3316 (xg_win_to_widget, xg_event_is_for_menubar):
3317 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3318 (xg_set_widget_bg): New function.
3319 (delete_cb): New function.
895009e1 3320 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3321 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3322 (xg_set_background_color): Call xg_set_widget_bg.
3323 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3324 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3325 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3326 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3327 if ! HAVE_GTK3.
3328 (update_frame_tool_bar): Call gtk_widget_hide.
3329 (xg_initialize): Use GDK_KEY_g.
3330
3331 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3332 if ! HAVE_GTK3
3333 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3334
3335 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3336 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3337 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3338
1c2cc4ef
JB
33392011-03-08 Juanma Barranquero <lekktu@gmail.com>
3340
3341 * w32xfns.c (select_palette): Check success of RealizePalette against
3342 GDI_ERROR, not zero.
3343
33383987 3344See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3345
3346;; Local Variables:
3347;; coding: utf-8
aac0c6e3
MR
3348;; End:
3349
33383987 3350 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3351
3352 This file is part of GNU Emacs.
3353
3354 GNU Emacs is free software: you can redistribute it and/or modify
3355 it under the terms of the GNU General Public License as published by
3356 the Free Software Foundation, either version 3 of the License, or
3357 (at your option) any later version.
3358
3359 GNU Emacs is distributed in the hope that it will be useful,
3360 but WITHOUT ANY WARRANTY; without even the implied warranty of
3361 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3362 GNU General Public License for more details.
3363
3364 You should have received a copy of the GNU General Public License
3365 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.