* lisp/window.el: Make special-display like display-buffer-alist.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ae9e237f
JB
12011-11-07 Juanma Barranquero <lekktu@gmail.com>
2
3 * lisp.h (syms_of_abbrev): Remove declaration.
4 Reported by CHENG Gao <chenggao@royau.me>.
5
c7aa8333
EZ
62011-11-07 Eli Zaretskii <eliz@gnu.org>
7
8 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
10 of temacs in GUI mode.
11
be7f5545
MR
122011-11-07 Martin Rudalics <rudalics@gmx.at>
13
14 * window.h: Declare delete_all_child_windows instead of
15 delete_all_subwindows.
16 * window.c (Fwindow_nest, Fset_window_nest)
17 (Fset_window_new_total, Fset_window_new_normal)
18 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
19 (delete_all_subwindows): Rename to delete_all_child_windows.
20 (Fdelete_other_windows_internal, Fset_window_configuration):
21 Call delete_all_child_windows instead of delete_all_subwindows.
22 * frame.c (delete_frame): Call delete_all_child_windows instead
23 of delete_all_subwindows.
24
ca78dc43
PE
252011-11-07 Paul Eggert <eggert@cs.ucla.edu>
26
27 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
28 This is also needed for porting to any host where GC_MARK_STACK is
29 not GC_MAKE_GCPROS_NOOPS.
30 (which_symbols): Use it.
31
a0241d01
KH
322011-11-07 Kenichi Handa <handa@m17n.org>
33
34 * coding.c (coding_set_destination): Check coding->src_pos only
35 when coding->src_object is a buffer (bug#9910).
36
37 * process.c (send_process): Set the member src_multibyte of coding
38 to 0 (bug#9911) when sending a unibyte text.
39
40 * callproc.c (Fcall_process): Set the member src_multibyte of
41 process_coding to 0 (bug#9912).
42
a64bfdfa 432011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
44
45 * xmenu.c (cleanup_widget_value_tree): New function.
46 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
47 calling free_menubar_widget_value_tree directly (Bug#9830).
48
cb41b32a
PE
492011-11-06 Paul Eggert <eggert@cs.ucla.edu>
50
51 Fix some portability problems with 'inline'.
52 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
53 (window_box_width, window_box_left, window_box_left_offset)
54 (window_box_right, window_box_right_offset): Declare extern.
55 Otherwise, these inline functions do not conform to C99 and
56 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
57 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
58 * intervals.c (adjust_intervals_for_insertion)
59 (adjust_intervals_for_deletion): Now extern, because otherwise the
60 extern inline functions 'offset_intervals' couldn't refer to it.
61 (static_offset_intervals): Remove.
62 (offset_intervals): Rewrite using the old contents of
63 static_offset_intervals. The old version didn't conform to C99
64 because an extern inline function contained a reference to an
65 identifier with static linkage.
66
b7041366
AS
672011-11-06 Andreas Schwab <schwab@linux-m68k.org>
68
69 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
70 GC.
71
88a37c4d
EZ
722011-11-06 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (init_iterator, reseat_to_string): Don't set the
75 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
76 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
77 return Qleft_to_right.
78
49745b39
CY
792011-11-06 Chong Yidong <cyd@gnu.org>
80
81 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
82 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
83 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
84 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
85 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
86 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
87 (Fwindow_vscroll): Doc fix.
88 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
89 argument, since it makes no sense to pass a live window and for
90 consistency with window-child.
91
1f05cd82
CS
922011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
93
94 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
95 support MSVC.
96
22610910
JR
972011-11-05 Jason Rumney <jasonr@gnu.org>
98
99 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
100 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
101 fonts (Bug#6029).
102 (add_font_entity_to_list): Fix logic errors in mixed boolean and
103 bitwise arithmetic preventing use of unicode-sip and non-truetype
104 opentype fonts.
105
a06776b2
EZ
1062011-11-05 Eli Zaretskii <eliz@gnu.org>
107
3ad924ba
EZ
108 * s/ms-w32.h (fstat, stat, utime): Move redirections to
109 "emacs"-only part.
110
a06776b2
EZ
111 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
112 initialization code to keep similarity to xfns.c after changes
113 from 2011-11-05.
114
c9e7db78
JD
1152011-11-05 Jan Djärv <jan.h.d@swipnet.se>
116
a97f8f3f
JD
117 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
118 (unwind_create_frame): New function (Bug#9943).
119 (Fx_create_frame): Restructure code to be more similar to the one in
120 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
121 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
122 Move terminal->reference_count++ just before making the frame official
123 (Bug#9943).
124
125 * nsterm.m (x_free_frame_resources): New function.
126 (x_destroy_window): Move code to x_free_frame_resources.
127
c9e7db78
JD
128 * xfns.c (unwind_create_frame): Fix comment.
129 (Fx_create_frame, x_create_tip_frame): Move
130 terminal->reference_count++ just before making the frame
131 official. Move initialization of image_cache_refcount and
132 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
133
a6fc3b5c
EZ
1342011-11-05 Eli Zaretskii <eliz@gnu.org>
135
136 Support MSVC build with newer versions of Visual Studio.
137 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
138 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
139 nt/gmake.defs.
140
141 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
142 which are not supported by MSVC.
143 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
144 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
145 bitfields.
146 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
147 types in bitfields.
148 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
149
150 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
151
1522011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
153
154 Support MSVC build with newer versions of Visual Studio.
155 * w32.c: Don't include w32api.h for MSVC.
156 (init_environment) [_MSC_VER]: Call sys_access, not _access.
157
158 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
159 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
160 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
161 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
162 e_* cousins.
163 (alloca) [_MSC_VER]: Define to _alloca.
164
165 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
166
167 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
168
a58c13ed
EZ
1692011-11-04 Eli Zaretskii <eliz@gnu.org>
170
171 * xdisp.c (note_mouse_highlight): If either of
172 previous/next-single-property-change returns nil, treat that as
173 the beginning or the end of the buffer. (Bug#9955)
174
fe0b6370
JD
1752011-11-04 Jan Djärv <jan.h.d@swipnet.se>
176
a58c13ed 177 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
178 label is not null (Bug#9951).
179 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
180 may be NULL.
181
89bd5ee1
EZ
1822011-11-04 Eli Zaretskii <eliz@gnu.org>
183
184 * window.c (Fwindow_body_size): Mention in the doc string that the
185 return value is in frame's canonical units. (Bug#9949)
186
84c3edb9
EZ
1872011-11-03 Eli Zaretskii <eliz@gnu.org>
188
4e2fb5c7
EZ
189 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
190
84c3edb9 191 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 192 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 193 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 194
bc17a887
EZ
1952011-11-01 Eli Zaretskii <eliz@gnu.org>
196
197 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
198 Don't stop backward scan on the continuation glyph, even though
199 its CHARPOS is positive.
26b46e51
EZ
200 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
201 cover_string to disp_string.
bc17a887 202
4ee88440
MR
2032011-11-01 Martin Rudalics <rudalics@gmx.at>
204
205 * window.c (temp_output_buffer_show): Don't use
206 Vtemp_buffer_show_specifiers.
207 (Vtemp_buffer_show_specifiers): Remove unused variable.
208
c2ff3c02
EZ
2092011-10-30 Eli Zaretskii <eliz@gnu.org>
210
211 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
212 past the beginning of the current glyph matrix.
213
6e56383b
JD
2142011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
215
216 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
217 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
218 HAVE_GTK3 (Bug#9869).
b77a6a7f 219
3b574623
JD
220 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
221 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
222
b77a6a7f
JD
223 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
224
225 * xterm.c: Declare x_handle_net_wm_state to return int.
226 (handle_one_xevent): Check if we are iconified but don't have
227 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
228 (get_current_wm_state): Return non-zero if not hidden,
229 check for _NET_WM_STATE_HIDDEN (Bug#9893).
230 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
231 (x_handle_net_wm_state): Return what get_current_wm_state returns.
232 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
233
196e41e4
PE
2342011-10-29 Paul Eggert <eggert@cs.ucla.edu>
235
236 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
237 so that this new function doesn't get optimized away by a
238 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
239
021f2e1a
AS
2402011-10-29 Andreas Schwab <schwab@linux-m68k.org>
241
242 * frame.h (MOUSE_HL_INFO): Remove excess parens.
243
8b058d44
EZ
2442011-10-29 Eli Zaretskii <eliz@gnu.org>
245
246 Fix the `xbytecode' command.
247 * .gdbinit (xprintbytestr): New command.
248 (xwhichsymbols): Renamed from `which'; all callers changed.
249 (xbytecode): Print the byte-code string as well.
250
4452fb80
EZ
2512011-10-29 Kim Storm <storm@cua.dk>
252
8b058d44
EZ
253 * alloc.c (which_symbols): New function.
254
21b72067
AS
2552011-10-29 Andreas Schwab <schwab@linux-m68k.org>
256
257 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
258 line. (Bug#9903)
259
83ed7b5c
GM
2602011-10-29 Glenn Morris <rgm@gnu.org>
261
262 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
263 Not clear what it was for, and it causes various bugs. (Bug#9839)
264
5a7a728b
EZ
2652011-10-28 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
268 possible random value that matches one of those tested as
269 condition to clear the mouse face.
270
d3d0842f
CY
2712011-10-28 Chong Yidong <cyd@gnu.org>
272
273 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
274
31b39d13
DN
2752011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
276
277 * window.c (make_window): Initialize phys_cursor_on_p.
278
9aba6043
SM
2792011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
280
281 * lisp.h (struct Lisp_Symbol): Update comments.
282
c20992f4
JB
2832011-10-28 Juanma Barranquero <lekktu@gmail.com>
284
285 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
286
db4f02f2
EZ
2872011-10-28 Eli Zaretskii <eliz@gnu.org>
288
289 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
290 <oslsachem@gmail.com> for helping to debug this.
291
292 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
293 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
294 (g_b_init_get_glyph_outline_w): New static variables.
295 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
296 (GetGlyphOutlineW_Proc): New typedefs.
297 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
298 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
299 New functions.
300 (w32font_open_internal, compute_metrics):
301 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
302 instead of calling the "wide" APIs directly.
303
304 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
305
306 * w32.h (syms_of_w32font): Add prototype.
307
87e68db4
JB
3082011-10-27 Juanma Barranquero <lekktu@gmail.com>
309
310 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
311 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
312 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
313 (Fmove_to_window_line): Doc fix.
314
435c1d67
CY
3152011-10-27 Chong Yidong <cyd@gnu.org>
316
317 * process.c (make_process): Set gnutls_state to NULL.
318
319 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
320 non-NULL, regardless of GNUTLS_INITSTAGE.
321 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
322 an error. Set process slots as soon as we allocate them.
323
324 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
325
9c6c6f49
CY
3262011-10-27 Chong Yidong <cyd@gnu.org>
327
9aba6043
SM
328 * gnutls.c (emacs_gnutls_deinit): New function.
329 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
330 (Fgnutls_deinit, Fgnutls_boot): Use it.
331
332 * process.c (make_process): Initialize GnuTLS credentials to NULL.
333 (deactivate_process): Call emacs_gnutls_deinit.
334
657d08d3
JB
3352011-10-27 Juanma Barranquero <lekktu@gmail.com>
336
337 * image.c (x_create_x_image_and_pixmap):
338 * w32.c (sys_rename, w32_delayed_load):
339 * w32font.c (fill_in_logfont):
340 * w32reg.c (x_get_string_resource): Silence compiler warnings.
341
5430d399
JB
3422011-10-26 Juanma Barranquero <lekktu@gmail.com>
343
344 * w32fns.c (w32_default_color_map): New function,
345 extracted from Fw32_default_color_map.
a7ef684b 346 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 347
fe0055fa
PE
3482011-10-25 Paul Eggert <eggert@cs.ucla.edu>
349
350 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
351
e6346438
SM
3522011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
353
354 * keyboard.c (test_undefined): New function (bug#9751).
355 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
356
e112cc37
ET
3572011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
358
359 * sysdep.c (init_sys_modes): Fix the check for the controlling
360 terminal (Bug#6649).
361
7b5d6677
EZ
3622011-10-20 Eli Zaretskii <eliz@gnu.org>
363
364 * dispextern.h (struct bidi_it): New member next_en_type.
365
366 * bidi.c (bidi_line_init): Initialize the next_en_type member.
367 (bidi_resolve_explicit_1): When next_en_pos is valid for the
368 current character, check also for next_en_type being WEAK_EN.
369 (bidi_resolve_weak): Don't enter the expensive loop if the current
370 position is before next_en_pos. Record the bidi type of the first
371 non-ET, non-BN character we find, in addition to its position.
372 (bidi_level_of_next_char): Invalidate next_en_type when
373 next_en_pos is over-stepped.
374
7da0b018
PE
3752011-10-20 Paul Eggert <eggert@cs.ucla.edu>
376
377 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
378 * editfns.c: Rewrite current-time-zone so that it invokes
379 the equivalent of (format-time-string "%Z") to get the time zone name.
380 This fixes a bug when the time zone name contains characters that
381 need converting from the system time locale to Emacs internal format.
382 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
383 that patch fixed format-time-string to do the conversion, but
384 I forgot to fix current-time-zone.
385 (format_time_string): New function, containing most of
386 what Fformat_time_string used to contain.
387 (Fformat_time_string): Rewrite in terms of format_time_string.
388 This doesn't change this function's behavior.
389 (current-time-zone): Rewrite to use format_time_string.
390 This fixes the bug reported by Michael Schierl in
391 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
392 Jason Rumney's 2007-06-07 change worked around this bug, but
393 didn't fix it.
394 * systime.h (tzname, timezone): Remove no-longer-used declarations.
395
8547b010
EZ
3962011-10-19 Eli Zaretskii <eliz@gnu.org>
397
398 * xdisp.c (start_display): If the character at POS is displayed
399 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
400 (try_window_reusing_current_matrix): If a line ends in a display
401 vector or the next line starts in a display vector, continue
402 redrawing the window even though the character position of
403 start_row was reached.
8547b010
EZ
404 (Bug#9771, part 2)
405
4e948d15
CY
4062011-10-18 Chong Yidong <cyd@gnu.org>
407
408 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
409 with nobreak-char-display too.
410
4787455f
EZ
4112011-10-18 Eli Zaretskii <eliz@gnu.org>
412
413 Fix part 3 of bug#9771.
414 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
415 (bidi_resolve_neutral): Don't enter the expensive loop looking for
416 non-neutral characters if the current character is a paragraph
417 separator (a.k.a. Newline). This avoids running the same
418 expensive loop twice, once when we consume the preceding newline
419 and the other time when the line actually needs to be displayed.
420 Avoid the loop when we see neutrals on the base embedding level
421 following a character whose directionality is the same as the
422 paragraph's. This avoids running the expensive loop when a line
423 ends in a long sequence of neutrals, like control characters.
424 Add assertion against STRONG_AL type. Slightly rearrange code
425 that determines the type of a neutral given the first non-neutral
426 that follows it.
427 (bidi_level_of_next_char): Set next_en_pos to zero when
428 invalidating its info.
429
2c91f553
EZ
4302011-10-17 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (push_display_prop): Determine whether to record string
433 or buffer position by IT->string, not by IT->method. Allow
434 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
435 (move_it_vertically_backward): Don't look for character position
436 immediately after the newline when in a continuation line.
437 (Bug#9771, part 1)
2c91f553 438
c7b08b0d
MR
4392011-10-15 Martin Rudalics <rudalics@gmx.at>
440
441 * window.c (coordinates_in_window): Rewrite and delabelize
442 vertical border check. (Bug#5357) (Bug#9618)
443
6b02f655
SM
4442011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
445
446 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
447 errors in XSetWindowBorder (bug#9310).
448
81d40c92
DA
4492011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
450
451 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
452 avoid crash when xmalloc overrun checking is enabled.
453
d4172c3b
EZ
4542011-10-13 Eli Zaretskii <eliz@gnu.org>
455
456 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
457 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
458 cursor motion with <left> and <right> arrow keys.
459
460 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
461 some callers set that themselves.
462
b00eea75
EZ
4632011-10-12 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
466 display string and the previous row comes from the same string and
467 is empty. (Bug#9739) (Bug#9738)
468
8fe012c4
SM
4692011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
470
471 * doc.c (get_doc_string): Encode file name (bug#9735).
472
0074aef2
EZ
4732011-10-12 Eli Zaretskii <eliz@gnu.org>
474
79beb178
EZ
475 * bidi.c (bidi_level_of_next_char):
476 * xdisp.c (get_visually_first_element): Remove old incorrect
477 comments regarding the Unicode Line Separator character.
478
0074aef2
EZ
479 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
480
6e4b3fbe
DA
4812011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
482
483 * alloc.c (Fgc_status): Do not access beyond zombies array
484 boundary if nzombies > MAX_ZOMBIES.
485 * alloc.c (dump_zombies): Add missing format specifier.
486
0324f3af
PE
4872011-10-12 Paul Eggert <eggert@cs.ucla.edu>
488
b5525cac
PE
489 * xdisp.c (set_cursor_from_row): Simplify conditionals,
490 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
491
0324f3af
PE
492 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
493 Some packages use them to denote characters with modifiers.
494
e9b5f888
AS
4952011-10-11 Andreas Schwab <schwab@linux-m68k.org>
496
497 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
498 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
499 matching a pp-number. Rename parameter var to var1.
500
127827c0
SM
5012011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
502
503 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
504
c8fd3bd0
GM
5052011-10-08 Glenn Morris <rgm@gnu.org>
506
507 * callint.c (Fcall_interactively): Give a more explicit error for the
508 'c' case with a non-character input. (Bug#8479)
509
352ec8ff
EZ
5102011-10-08 Eli Zaretskii <eliz@gnu.org>
511
03669ccb
EZ
512 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
513 lines.
7061c986
EZ
514 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
515 lines that are hscrolled on the left.
03669ccb 516
352ec8ff
EZ
517 * dispnew.c (buffer_posn_from_coords): Account for a possible
518 presence of header-line. (Bug#4426)
519
a66cfb1c
SM
5202011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
521
6b02f655
SM
522 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
523 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 524
7c5ee88e
PE
5252011-10-07 Paul Eggert <eggert@cs.ucla.edu>
526
527 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
528 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
529 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
530 this makes Emacs dump core during garbage collection on rare
531 occasions. sizeof is obviously inferior to offsetof here, so
532 stick with offsetof.
533 (GC_POINTER_ALIGNMENT): New macro.
534 (mark_memory): Omit 3rd (offset) arg; caller changed.
535 Don't assume EMACS_INT alignment is the same as pointer alignment.
536
df1bbe5b
SM
5372011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
538
539 * keyboard.c (read_key_sequence_remapped): New var.
540 (read_key_sequence): Compute remapping in the right buffer.
541 (command_loop_1): Use read_key_sequence's remapping directly.
542
51553db6
SM
5432011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
544
32c1fffd
SM
545 * dired.c (file_name_completion): Don't expand file name.
546 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
547 before checking file name handler.
548
51553db6
SM
549 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
550 they've been requested explicitly (bug#9591).
551
b6bd1599 5522011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
553
554 * keymap.c (Fsingle_key_description): Use make_specified_string
555 instead of build_string to build string from push_key_description.
556 (Bug#5193)
557
f701dc2a
PE
5582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
559
4222c55d
PE
560 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
561 This fixes a Y2038 bug on 64-bit hosts.
562 * buffer.c (reset_buffer):
563 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
564 (Fclear_buffer_auto_save_failure):
565 Use 0, not -1, to represent an unset failure time, since time_t
566 might not be signed.
567
f701dc2a
PE
568 Remove dependency on glibc malloc internals.
569 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
570 Move back here from lisp.h, but with their new implementations.
571 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
572 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
573 * charset.c (charset_table_init): New static var.
574 (syms_of_charset): Use it instead of xmalloc. This removes a
575 dependency on glibc malloc internals. See Eli Zaretskii's comment in
576 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
577 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
578 Move back to alloc.c.
579 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
580 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
581
9ceebf39
JD
5822011-09-30 Jan Djärv <jan.h.d@swipnet.se>
583
584 * nsterm.m (windowDidResize): Call x_set_window_size only when
585 ns_in_resize is true. Otherwise set pixelwidth/height and
586 call change_frame_size (Bug#9628).
587
cb993c58
PE
5882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
589
3930c88b
PE
590 Port --enable-checking=all to Fedora 14 x86-64.
591 * charset.c (syms_of_charset): Also account for glibc malloc's
592 internal overhead when calculating the initial malloc maximum.
593
cb993c58
PE
594 Port --enable-checking=all to Fedora 14 x86.
595 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
596 Move to lisp.h.
597 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
598 (overrun_check_realloc, overrun_check_free):
599 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
600 That way, xmalloc returns a properly-aligned pointer even if
601 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
602 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
603 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
604 into account when calculating the initial malloc maximum.
605 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
606 Move here from alloc.c, so that charset.c can use it too.
607 Properly align; the old code wasn't right for common 32-bit hosts
608 when configured with --enable-checking=all.
609 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
610 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
611
31bed486
EZ
6122011-09-29 Eli Zaretskii <eliz@gnu.org>
613
04c70788 614 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
615 use EDOM.
616
fbcaa2f3
EZ
6172011-09-28 Eli Zaretskii <eliz@gnu.org>
618
619 * xdisp.c (compute_display_string_end): If there's no display
620 string at CHARPOS, return -1.
621
622 * bidi.c (bidi_fetch_char): When compute_display_string_end
623 returns a negative value, treat the character as a normal
624 character not covered by a display string. (Bug#9624)
625
a239d4e9
JB
6262011-09-28 Juanma Barranquero <lekktu@gmail.com>
627
628 * lread.c (Fread_from_string): Fix typo in docstring.
629
88652fd5
EZ
6302011-09-27 Eli Zaretskii <eliz@gnu.org>
631
632 * xdisp.c (handle_invisible_prop): If invisible text ends on a
633 newline, reseat the iterator instead of bidi-iterating there one
634 character at a time. (Bug#9610)
32c1fffd
SM
635 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
636 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 637
ed497dd4
AS
6382011-09-27 Andreas Schwab <schwab@linux-m68k.org>
639
640 * lread.c (readevalloop): Use correct code for NBSP.
641 (read1): Likewise. (Bug#9608)
642
b2bf61aa
MA
6432011-09-25 Michael Albinus <michael.albinus@gmx.de>
644
645 * dbusbind.c (Fdbus_register_signal): When service is not
646 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
647
32bbb17c
GM
6482011-09-25 Glenn Morris <rgm@gnu.org>
649
650 * buffer.c (truncate-lines): Doc fix.
651
94e0933e
CY
6522011-09-24 Chong Yidong <cyd@stupidchicken.com>
653
654 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
655 (Fset_window_next_buffers): Doc fix.
656
cddde921
GM
6572011-09-24 Glenn Morris <rgm@gnu.org>
658
659 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
660
1260aef1
PE
6612011-09-24 Paul Eggert <eggert@cs.ucla.edu>
662
25b4bfa0
PE
663 Fix minor problems found by static checking.
664 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
665 * indent.c (Fvertical_motion): Fix == vs = typo.
666
e3cbd34b
EZ
6672011-09-24 Eli Zaretskii <eliz@gnu.org>
668
a66cfb1c
SM
669 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
670 Default value is now t. Doc fix.
6bf7006f 671
e3cbd34b 672 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 673 logic when moving up, not only when moving down. Fix the
e3cbd34b 674 confusing name and values of the it_overshoot_expected variable;
32c1fffd 675 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
676
677 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
678 CHARPOS is covered by a display string which includes newlines.
679 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
680 is covered by a display string with embedded newlines.
681
a3de0cbd
MA
6822011-09-24 Michael Albinus <michael.albinus@gmx.de>
683
684 * dbusbind.c (Fdbus_register_signal): Add match rule to
685 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
686 (Fdbus_register_method, Vdbus_registered_objects_table):
687 Fix docstring.
a3de0cbd 688
b260039d
JM
6892011-09-24 Jim Meyering <meyering@redhat.com>
690
32c1fffd 691 do not ignore write error for any output size
b260039d
JM
692 The previous change was incomplete.
693 While it makes emacs --batch detect the vast majority of stdout
694 write failures, errors were still ignored whenever the output size is
695 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
696 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
697 && echo FAIL: ignored write error
698 FAIL: ignored write error
699 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
700 && echo FAIL: ignored write error
701 FAIL: ignored write error
702 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
703
8eca8a7c
AS
7042011-09-23 Andreas Schwab <schwab@linux-m68k.org>
705
706 * emacs.c (Fkill_emacs): In noninteractive mode exit
707 non-successfully if a write error occurred on stdout. (Bug#9574)
708
3341db62
EZ
7092011-09-21 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
712 the xassert test.
713
714 * dispextern.h (struct it): Update the comment documenting what
715 can it->OBJECT be.
716
8c203dbf
EZ
7172011-09-20 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
720 a display string, extend search for cursor position to end of row.
721 (find_row_edges): If the row ends in a newline from a display
722 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
723 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
724 (Fcurrent_bidi_paragraph_direction): Fix search for previous
725 non-empty line. Fixes confusing cursor motion with arrow keys at
726 the beginning of a line that starts with whitespace.
8c203dbf 727
a4824228
LMI
7282011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
729
730 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
731 (bug#9493).
732
33ed493b
CY
7332011-09-18 Chong Yidong <cyd@stupidchicken.com>
734
735 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
736 boolean (Bug#9154).
737
56cd55c8
EZ
7382011-09-18 Eli Zaretskii <eliz@gnu.org>
739
740 * xdisp.c (display_line): Record maximum and minimum buffer
741 positions even if no glyphs were produced (e.g., by a zero-width
742 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
743 buffer positions that will be removed from the glyph row because
744 they don't fit.
c02dcedf
EZ
745 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
746 column is beyond frame width: don't subtract 1 "pixel" when
747 computing width of the stretch.
3e62b7e0
EZ
748 (reseat_at_next_visible_line_start): Undo the change made on
749 2011-09-17 that saved paragraph information and restored it after
750 the call to `reseat'. (Bug#9545)
56cd55c8 751
5ed99d36 7522011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
753
754 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
755 and turn window cursor on if cleared (Bug#9415).
756
5ed99d36 7572011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
758
759 * search.c (boyer_moore): Take unibyte characters from pattern
760 literally. (Bug#9458)
761
9bade7b2
EZ
7622011-09-18 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
765
e5e9d610
PE
7662011-09-18 Paul Eggert <eggert@cs.ucla.edu>
767
87e4427a
PE
768 Fix minor problem found by static checking.
769 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
770 initialized, to pacify gcc -Wuninitialized.
771
e5e9d610
PE
772 * fileio.c: Report proper errno when syscall falls.
773 (Finsert_file_contents): Save and restore errno,
774 so that report_file_error outputs the correct diagnostic.
775 (Fwrite_region) [CLASH_DETECTION]: Likewise.
776
a1674f0b
EZ
7772011-09-18 Eli Zaretskii <eliz@gnu.org>
778
779 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
780
fbfb6dd4
EZ
7812011-09-17 Eli Zaretskii <eliz@gnu.org>
782
783 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
784 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
785
bb187662
EZ
7862011-09-17 Eli Zaretskii <eliz@gnu.org>
787
1137e8b8 788 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 789 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
790
791 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
792 (bidi_find_paragraph_start): Search back for paragraph beginning
793 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
794 (bidi_move_to_visually_next): Only trigger paragraph-related
795 computations when the last character is a newline or at EOB, not
796 just any NEUTRAL_B. (Bug#9470)
797
bb187662
EZ
798 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
799 truncated lines if point is covered by a display string. (Bug#9524)
800
2e621251
PE
8012011-09-16 Paul Eggert <eggert@cs.ucla.edu>
802
803 * xselect.c: Relax test for outgoing X longs (Bug#9498).
804 (cons_to_x_long): New function.
805 (lisp_data_to_selection_data): Use it. Correct the test for
806 short-versus-long data; it was negated. Break out of vector
807 loop, for efficiency, when a long datum is discovered.
808
91a15bc6
SM
8092011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
810
811 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
812
b41c3a35
EZ
8132011-09-16 Eli Zaretskii <eliz@gnu.org>
814
815 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
816 GCC PR/17406) by declaring this function with external scope.
817
7812ba2d
PE
8182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
819
820 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
821 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
822
cf7edc2a
AS
8232011-09-15 Andreas Schwab <schwab@linux-m68k.org>
824
825 * editfns.c (Fformat): Correctly handle text properties on "%%".
826
bd01620e
EZ
8272011-09-15 Eli Zaretskii <eliz@gnu.org>
828
829 * xterm.c (x_draw_composite_glyph_string_foreground):
830 * w32term.c (x_draw_composite_glyph_string_foreground):
831 * term.c (encode_terminal_code):
832 * composite.c (composition_update_it, get_composition_id):
833 * xdisp.c (get_next_display_element)
834 (fill_composite_glyph_string): Add comments about special meaning
835 of TAB characters in a composition.
836
a02719a3
PE
8372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
838
839 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
840 This occurs when processing a multibyte format.
841 Problem reported by Wolfgang Jenker.
a02719a3 842
72589a3c
JB
8432011-09-15 Johan Bockgård <bojohan@gnu.org>
844
845 * xdisp.c (try_cursor_movement): Only check for exact match if
846 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
847
1c14176c
PE
8482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
849
850 Remove unused external symbols.
851 * dispextern.h (calc_pixel_width_or_height): Remove decl.
852 * xdisp.c (calc_pixel_width_or_height): Now static.
853 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
854 * indent.c (check_display_width):
855 * w32term.c: Fix comment to match code.
856 * xterm.c, xterm.h (x_catching_errors): Remove.
857
d2eea5b5
PE
8582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
859
860 * xselect.c: Use signed conversions more consistently (Bug#9498).
861 (selection_data_to_lisp_data): Assume incoming selection data are
862 signed integers, not unsigned. This is to be consistent with
863 outgoing selection data, which was modified to use signed integers
864 in as part of the fix to Bug#9196 in response to Jan D.'s comment
865 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
866 expects long, not unsigned long.
867
46888499
EZ
8682011-09-14 Eli Zaretskii <eliz@gnu.org>
869
870 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
871 computation of loop end. Reported by Johan Bockgård
872 <bojohan@gnu.org>.
873
ef8ef9fb
CY
8742011-09-13 Chong Yidong <cyd@stupidchicken.com>
875
876 * frame.c (Fother_visible_frames_p): Function deleted.
877
fa819fed
EZ
8782011-09-12 Eli Zaretskii <eliz@gnu.org>
879
880 * indent.c (compute_motion): Process display vector front to back
881 rather than the other way around. (Bug#2496)
882
2ba8e008
SM
8832011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
886
20f53c69
CY
8872011-09-11 Chong Yidong <cyd@stupidchicken.com>
888
889 * minibuf.c (Fread_from_minibuffer): Doc fix.
890
d562d7a4
EZ
8912011-09-11 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
894 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
895
1c4d7f3d
LMI
8962011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
897
898 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
899 value for non-existent files.
900
b885bf36
EZ
9012011-09-11 Eli Zaretskii <eliz@gnu.org>
902
903 * fileio.c (Finsert_file_contents): If the file cannot be opened,
904 set its "size" to -1. This will set the modtime_size field of
905 the corresponding buffer to -1, which is what
906 verify-visited-file-modtime expects for files that do not exist.
907 (Bug#9139)
908
6612f0bf
PE
9092011-09-11 Paul Eggert <eggert@cs.ucla.edu>
910
911 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
912 here ...
913 * lisp.h: ... from here. push_key_description is no longer
914 defined in keyboard.c, so its declaration should not be in
915 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
916 logically belongs with push_key_description.
917
dfb3f755
PE
9182011-09-10 Paul Eggert <eggert@cs.ucla.edu>
919
920 * buffer.h: Include <sys/types.h> instead of <time.h>.
921 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
922 Problem reported by Herbert J. Skuhra.
923
3134906c
LMI
9242011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
925
926 * xml.c (parse_region): Make the parsing work for
927 non-comment-starting XML files again (bug#9144).
928
8d903f4e
AS
9292011-09-10 Andreas Schwab <schwab@linux-m68k.org>
930
931 * image.c (gif_load): Fix calculation of bottom and right corner.
932 (Bug#9468)
933
80ad64f4
EZ
9342011-09-10 Eli Zaretskii <eliz@gnu.org>
935
936 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
937 redisplay in small windows.
938
208a048d
EZ
9392011-09-09 Eli Zaretskii <eliz@gnu.org>
940
941 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
942
9b1c252e
MR
9432011-09-08 Martin Rudalics <rudalics@gmx.at>
944
945 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
946 Operate on live windows only.
947
2949f33b
JB
9482011-09-08 Juanma Barranquero <lekktu@gmail.com>
949
950 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
951
e08dcafd
EZ
9522011-09-07 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
955 only under bidi iteration.
956
115b96bd
JD
9572011-09-07 Jan Djärv <jan.h.d@swipnet.se>
958
959 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
960
c8199d0f
PE
9612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
962
963 isnan: Fix porting problem to Solaris 10 with bundled gcc.
964 Without this fix, the command to link temacs failed due to an
965 undefined symbol __builtin_isnan. This is because
966 /usr/include/iso/math_c99.h #defines isnan(x) to
967 __builtin_isnan(x), but the bundled gcc, which identifies itself
968 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
969 a __builtin_isnan.
970 * floatfns.c (isnan): #undef, and then #define to a clone of
971 what's in data.c.
972 (Fisnan): Always define, since it's always available now.
973 (syms_of_floatfns): Always define isnan at the Lisp level.
974
e39b275c 9752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
976
977 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
978
b2db44d9 9792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 980
f4af5137 981 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
982 The previous code assumed that file offsets (off_t values) fit in
983 EMACS_INT variables, which is not true on typical 32-bit hosts.
984 The code messed up by falsely reporting buffer overflow in cases
985 such as (insert-file-contents "big" nil 1 2) into an empty buffer
986 when "big" contains more than 2**29 bytes, even though this
987 inserts just one byte and does not overflow the buffer.
988 (Finsert_file_contents): Store file offsets as off_t
989 values, not as EMACS_INT values. Check for overflow when
990 converting between EMACS_INT and off_t. When checking for
991 buffer overflow or for overlap, take the offsets into account.
992 Don't use EMACS_INT for small values where int suffices.
993 When checking for overlap, fix a typo: ZV was used where
994 ZV_BYTE was intended.
995 (Fwrite_region): Don't assume off_t fits into 'long'.
996 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
997
ecfc0a49
MA
9982011-09-05 Michael Albinus <michael.albinus@gmx.de>
999
1000 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1001
6511acf2 10022011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1003
0999621a 1004 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1005
1006 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1007 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1008 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1009 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1010 (modify_event_symbol): Do not assume that the length of
1011 name_alist_or_stem is safe to alloca and fits in int.
1012 (Fexecute_extended_command): Likewise for function name and binding.
1013 (Frecursion_depth): Wrap around reliably on integer overflow.
1014 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1015 since some callers pass EMACS_INT values.
1016 (Fsingle_key_description): Don't crash if symbol name contains more
1017 than MAX_ALLOCA bytes.
1018 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1019 (get_minibuffer): Arg is now EMACS_INT, not int.
1020 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1021 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1022 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1023
2be7d702
PE
1024 * dbusbind.c (signature_cat): New function.
1025 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1026 Do not overrun buffer; instead, report string overflow.
1027
9d1df220
PE
1028 * dispnew.c (add_window_display_history): Don't overrun buffer.
1029 Truncate instead; this is OK since it's just a log.
1030
33ef5c64
PE
1031 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1032 even if the time zone offset is outlandishly large.
1033 Don't mishandle offset == INT_MIN.
1034
66c6fdd5
PE
1035 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1036 when creating daemon; the previous buffer-overflow check was incorrect.
1037
d749b01b
PE
1038 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1039 which has the guts of the old verror function.
1040
b5cd1905
PE
1041 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1042 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1043
6e1a67fb
PE
1044 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1045 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1046 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1047 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1048 length of string rather than counting it via multiple sprintfs;
1049 that's simpler and more reliable.
c21721cc
PE
1050 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1051 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1052 sprintf, in case result does not fit in int.
1053
c57b67fc
PE
1054 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1055 (fontset_from_font): Print it.
1056
8a401434
PE
1057 * frame.c (tty_frame_count): Now printmax_t, not int.
1058 (make_terminal_frame, set_term_frame_name): Print it.
1059 (x_report_frame_params): In X, window IDs are unsigned long,
1060 not signed long, so print them as unsigned.
1061 (validate_x_resource_name): Check for implausibly long names,
1062 and don't assume name length fits in 'int'.
1063 (x_get_resource_string): Don't blindly alloca invocation name;
1064 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1065 not fit in int.
1066
6e1a67fb
PE
1067 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1068 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1069 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1070
0df02bf3
PE
1071 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1072 Use esprintf, not sprintf, in case result does not fit in int.
1073
48e30793
PE
1074 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1075 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1076 it as a large positive number.
1077 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1078 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1079
a66ff6d8
PE
1080 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1081 in case result does not fit in int.
1082
aca216ff
PE
1083 * print.c (float_to_string): Detect width overflow more reliably.
1084 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1085 buffer overrun. Don't assume list length fits in 'int'. Treat
1086 print length of 0 as 0, not as infinity; to be consistent with other
1087 uses of print length in this function. Don't overflow print length
1088 index. Don't assume hash table size fits in 'long', or that
1089 vectorlike size fits in 'unsigned long'.
1090
31c286f7
PE
1091 * process.c (make_process): Use printmax_t, not int, to format
1092 process-name gensyms.
1093
55e5faa1
PE
1094 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1095
80f2e268
PE
1096 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1097 to avoid potential buffer overrun.
1098
670741ab
PE
1099 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1100 if X resource line is longer than 512 bytes.
1101
b7163a50
PE
1102 * xfns.c (x_window): Make sprintf buffer a bit bigger
1103 to avoid potential buffer overrun.
1104
ae58ff1f
PE
1105 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1106
c43c8a6a
PE
1107 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1108
3f8236f4
PE
11092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1110
53e9fe90 1111 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1112 Without these, Emacs silently mishandles large integers sometimes.
1113 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1114 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1115
6511acf2
PE
1116 * xdisp.c (try_window_id): Check Emacs fixnum range before
1117 converting to 'int'.
806add1d 1118
6511acf2 1119 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1120 Check that an Emacs fixnum is in range before assigning it to 'int'.
1121 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1122 values converted from Emacs fixnums.
1123 (Frecenter): Don't wrap around a line count if it is out of 'int'
1124 range; instead, treat it as an extreme value.
1125 (Fset_window_configuration, compare_window_configurations):
1126 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1127
6511acf2
PE
1128 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1129 that can exceed INT_MAX. Check that EMACS_INT value is in range
1130 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1131 (match_limit): Don't assume that a fixnum can fit in 'int'.
1132
6511acf2 1133 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1134 exceed INT_MAX.
1135
6511acf2 1136 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1137 (Fvertical_motion): Don't wrap around LINES values that don't fit
1138 in 'int'. Instead, treat them as extreme values. This is good
1139 enough for windows, which can't have more than INT_MAX lines anyway.
1140
fcb901a7
LMI
11412011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1142
0f2f6b6d
LMI
1143 * Require libxml/parser.h to avoid compilation warning.
1144
fcb901a7
LMI
1145 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1146
1147 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1148 since this reportedly can destroy thread storage.
1149
6e20a0d4
CY
11502011-08-30 Chong Yidong <cyd@stupidchicken.com>
1151
1152 * syntax.c (find_defun_start): Update all cache variables if
1153 exiting early (Bug#9401).
1154
148ae00e
EZ
11552011-08-30 Eli Zaretskii <eliz@gnu.org>
1156
f6cfbd8f
EZ
1157 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1158
148ae00e
EZ
1159 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1160 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1161 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1162
1163 * term.c (tty_append_glyph): New function.
1164 (produce_stretch_glyph): Static function and its prototype deleted.
1165
a66cfb1c
SM
1166 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1167 Add prototypes.
148ae00e 1168
c4a07a4c
PE
11692011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1172 when checking :margin (Bug#9390).
1173 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1174 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1175 so that the name doesn't mislead. All uses changed.
1176
6bc8cd65
JB
11772011-08-28 Johan Bockgård <bojohan@gnu.org>
1178
1179 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1180 set_tty_hooks.
1181
dca4927e
EZ
11822011-08-27 Eli Zaretskii <eliz@gnu.org>
1183
1184 * xdisp.c (move_it_to): Don't bail out early when reaching
1185 position beyond to_charpos, if we are scanning backwards.
1186 (move_it_vertically_backward): When DY == 0, make sure we get to
1187 the first character in the line after the newline.
1188
f2cad773
PE
11892011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1190
1191 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1192 (ccl_driver): Do not generate an out-of-range pointer.
1193 (Fccl_execute_on_string): Remove unnecessary check for
1194 integer overflow, noted by Stefan Monnier in
1195 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1196 Remove a FIXME that didn't need fixing.
1197 Simplify the newly-introduced buffer reallocation code.
1198
0cae2cdb
JB
11992011-08-27 Juanma Barranquero <lekktu@gmail.com>
1200
1201 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1202
5fc295a4 12032011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1204
70c60eb2 1205 Integer and memory overflow issues (Bug#9196).
726e0ab1 1206
d31850da
PE
1207 * doc.c (get_doc_string): Rework so that
1208 get_doc_string_buffer_size is the actual buffer size, rather than
1209 being 1 less than the actual buffer size; this makes xpalloc more
1210 convenient.
1211
a69fbedb
PE
1212 * image.c (x_allocate_bitmap_record, cache_image):
1213 * xselect.c (Fx_register_dnd_atom):
1214 Simplify previous changes by using xpalloc.
1215
fe5c5d37
PE
1216 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1217 since either will do and ptrdiff_t is convenient with xpalloc.
1218
0065d054
PE
1219 * charset.c (charset_table_size)
1220 (struct charset_sort_data.priority): Now ptrdiff_t.
1221 (charset_compare): Don't overflow if priorities differ greatly.
1222 (Fsort_charsets): Don't assume list length fits in int.
1223 Check for size-calculation overflow when allocating sort data.
1224 (syms_of_charset): Allocate an initial charset table that is
1225 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1226
1227 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1228
1229 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1230 The actual value is always <= INT_MAX, and leaving it unsigned made
1231 overflow checking harder.
1232
1233 * dispextern.h (struct glyph_matrix.rows_allocated)
1234 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1235 with xpalloc. The values are still always <= INT_MAX.
1236
1237 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1238
1239 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1240 (SAFE_NALLOCA): New macro.
1241
1242 * region-cache.c (struct boundary.pos, find_cache_boundary)
1243 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1244 (set_cache_region, invalidate_region_cache)
1245 (revalidate_region_cache, know_region_cache, region_cache_forward)
1246 (region_cache_backward, pp_cache):
1247 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1248 so that ptrdiff_t * can be passed to xpalloc.
1249 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1250 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1251 (pp_cache): Don't assume cache_len fits in int.
1252 * region-cache.h: Adjust extern decls to match.
1253
1254 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1255 EMACS_INT, since either will do, for xpalloc.
1256
1257 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1258 (xnmalloc, xnrealloc, xpalloc): New functions.
1259
726e0ab1
PE
1260 * bidi.c (bidi_shelve_header_size): New constant.
1261 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1262 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1263
51f30bc5 1264 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1265 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1266 (overlay_strings):
1267 Don't update size of array until after memory allocation succeeds,
1268 because xmalloc/xrealloc may not return.
0065d054
PE
1269 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1270 now that we have proper integer overflow checking.
1271 (record_overlay_string, overlay_strings): Catch overflows when
1272 calculating size of overlay_str_buf.
726e0ab1 1273
0065d054
PE
1274 * callproc.c (Fcall_process): Check for size overflow when
1275 calculating size of args2.
1276 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1277 Normally we prefer signed values, but sticking with ptrdiff_t would
1278 require adding more-complicated checks.
726e0ab1
PE
1279
1280 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1281 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1282 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1283 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1284
1285 * character.c (Fstring): Check for size-calculation overflow.
1286
1287 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1288 unnecessary integer overflow. Check for size overflow.
1289 (encode_coding_object): Don't update size until xmalloc succeeds.
1290
1291 * composite.c (get_composition_id): Check for overflow in glyph
1292 length calculations.
1293
1294 Integer and memory overflow fixes for display code.
1295 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1296 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1297 (scrolling_window): Check for overflow in size calculations.
1298 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1299 Don't assume glyph table len fits in int.
1300 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1301 (row_table_size): Now ptrdiff_t, not int.
1302 (scrolling_window): Avoid overflow in size calculations.
1303 Don't update size until allocation succeeds.
1304 * fns.c (concat): Check for overflow in size calculations.
1305 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1306 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1307 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1308
1309 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1310 (get_doc_string): Check for size calculation overflow.
1311 Don't update size until allocation succeeds.
1312 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1313 EMACS_INT, where ptrdiff_t will do.
1314 (Fsubstitute_command_keys): Check for string overflow.
1315
1316 * editfns.c (set_time_zone_rule): Don't assume environment length
1317 fits in int.
1318 (message_length): Now ptrdiff_t, not int.
1319 (Fmessage_box): Don't update size until allocation succeeds.
1320 Don't assume message length fits in int.
1321 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1322
0065d054
PE
1323 * emacs.c (main): Do not reallocate argv, since there is a null at
1324 the end that can be overwritten, and this way there's no need to
1325 worry about size-calculation overflow.
1326 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1327
1328 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1329 alloc succeeds.
1330 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1331
1332 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1333 (x_set_scroll_bar_width, x_figure_window_size):
1334 Check for integer overflow.
1335 (x_set_alpha): Do not assume XINT fits in int.
1336
1337 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1338 This is for the members text_lines, text_cols, total_lines, total_cols,
1339 where the system imposes an 'int' limit.
1340
1341 * fringe.c (Fdefine_fringe_bitmap):
1342 Don't update size until alloc works.
1343
1344 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1345 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1346
1347 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1348 Check for size-calculation overflow.
1349 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1350 do, as we prefer signed integers.
1351 (id_to_widget.max_size, id_to_widget.used)
1352 (xg_store_widget_in_map, xg_remove_widget_from_map)
1353 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1354 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1355 Use and return ptrdiff_t, not int.
1356 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1357 * gtkutil.h: Change prototypes to match the above.
1358
1359 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1360 are duplicate now that they've been promoted to lisp.h.
1361 (x_allocate_bitmap_record, x_alloc_image_color)
1362 (make_image_cache, cache_image, xpm_load):
1363 Don't update size until alloc is done.
1364 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1365 (x_detect_edges):
3256efce 1366 Check for size calculation overflow.
726e0ab1
PE
1367 (ct_colors_allocated_max): New constant.
1368 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1369 overflow.
3256efce 1370
726e0ab1
PE
1371 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1372 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1373 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1374 Use ptrdiff_t, not int, to count maps.
1375 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1376 calculations. Don't update size until allocation succeeds.
1377 Redo calculations to avoid overflow.
726e0ab1
PE
1378 * keyboard.h: Change prototypes to match the above.
1379
1380 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1381 to count maps.
1382 (current_minor_maps): Check for size calculation overflow.
1383 * keymap.h: Change prototypes to match the above.
1384
1385 * lread.c (read1, init_obarray): Don't update size until alloc done.
1386
1387 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1388 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1389
726e0ab1
PE
1390 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1391 Now ptrdiff_t, not int.
1392 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1393 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1394
1395 * process.c (Fnetwork_interface_list): Check for overflow
1396 in size calculation.
1397
1398 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1399
1400 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1401 overflow. Don't bother calling xmalloc when xrealloc will do.
1402
1403 * search.c (Freplace_match): Check for size calculation overflow.
1404 (Fset_match_data): Don't assume list lengths fit in 'int'.
1405
1406 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1407 for command line length. Do not attempt to address one before the
1408 beginning of an array, as that's not portable.
1409
1410 * term.c (max_frame_lines): Remove; unused.
1411 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1412 not int.
1413 (encode_terminal_code, calculate_costs): Check for size
1414 calculation overflow.
1415 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1416 table lengths and related sizes. Don't update size until alloc
1417 done. Redo calculations to avoid overflow.
1418 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1419
1420 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1421 subtracting pointers.
1422 (gobble_line): Check for overflow more carefully. Don't update size
1423 until alloc done.
1424
1425 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1426 Don't update size until alloc done.
1427 Redo size calculations to avoid overflow.
1428 Check for size calculation overflow.
0065d054 1429 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1430
1431 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1432 Use ptrdiff_t, not int, for sizes.
1433 (store_mode_line_noprop_char): Don't update size until alloc done.
1434
0065d054
PE
1435 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1436 Use ptrdiff_t, not int, for sizes.
1437 (Finternal_make_lisp_face, cache_face):
1438 Check for size calculation overflow.
1439 (cache_face): Treat size calculation overflows as if they were
1440 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1441
1442 * xfns.c (x_encode_text, x_set_name_internal)
1443 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1444 sizes, since they can exceed INT_MAX in size. Check for size
1445 calculation overflow.
1446
0065d054
PE
1447 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1448 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1449 Don't update size until alloc done.
1450
0065d054 1451 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1452 as sprintf is limited to int lengths.
1d526e2f 1453
252c5ee1
PE
1454 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1455 (X_LONG_MIN): New macros.
864d7ce7
PE
1456 Use them to make the following changes clearer.
1457 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1458 This change doesn't affect the value now, but it may help remind
1459 future maintainers not to raise the value too much later.
1460 (SELECTION_QUANTUM): Remove, replacing with ...
1461 (selection_quantum): ... new function, which avoids overflow.
1462 All uses changed.
1463 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1464 assumption that selection length fits in 'int'.
1465 (x_reply_selection_request, x_handle_selection_request)
1466 (x_get_window_property, receive_incremental_selection)
1467 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1468 (lisp_data_to_selection_data, clean_local_selection_data):
1469 Use ptrdiff_t, not int, to record length of selection.
1470 (x_reply_selection_request, x_get_window_property)
1471 (receive_incremental_selection, x_property_data_to_lisp):
1472 Redo calculations to avoid overflow.
1473 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1474 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1475 something.
1476 (x_get_window_property, receive_incremental_selection)
1477 (lisp_data_to_selection_data, x_property_data_to_lisp):
1478 Check for size-calculation overflow.
1479 (x_get_window_property, receive_incremental_selection)
1480 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1481 Don't store size until memory allocation succeeds.
1482 (x_get_window_property): Plug memory leak on memory exhaustion.
1483 Don't double-block input; malloc is safe here. Don't assume 2**34
1484 - 4 fits in unsigned long. Add an xassert to check
1485 XGetWindowProperty overflow. Be more careful about overflow
1486 calculations, and distinguish size from memory overflow better.
1487 (receive_incremental_selection): When tracing, don't assume
1488 unsigned int is less than INT_MAX.
1489 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1490 harmful) conversions of unsigned short to int.
1491 (lisp_data_to_selection_data): Don't assume that integers
1492 in the range -65535 through -1 fit in an X unsigned short.
1493 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1494 result parameters unless successful. Rely on cons_to_unsigned
1495 to report problems with elements; the old code wasn't right anyway.
1496 (x_check_property_data): Check for int overflow; we cannot use
1497 a wider type due to X limits.
1498 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1499
726e0ab1 1500 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1501
0065d054
PE
1502 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1503 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1504 (x_color_cells): Don't store size until memory allocation succeeds.
1505 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1506 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1507 (x_term_init): Don't assume length fits in int (sprintf is limited
1508 to int size).
bc18e09d 1509
ebfa62c0
PE
1510 Use ptrdiff_t for composition IDs.
1511 * character.c (lisp_string_width):
1512 * composite.c (composition_table_size, n_compositions)
1513 (get_composition_id, composition_gstring_from_id):
1514 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1515 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1516 * window.c (Frecenter):
1517 Use ptrdiff_t, not int, for composition IDs.
1518 * composite.c (get_composition_id): Check for integer overflow.
1519 * composite.h: Adjust prototypes to match the above changes.
1520
d3411f89
PE
1521 Use ptrdiff_t for hash table indexes.
1522 * category.c (hash_get_category_set):
1523 * ccl.c (ccl_driver):
1524 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1525 * coding.c (coding_system_charset_list, detect_coding_system):
1526 * coding.h (struct coding_system.id):
1527 * composite.c (get_composition_id, gstring_lookup_cache):
1528 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1529 * image.c (xpm_get_color_table_h):
1530 * lisp.h (hash_lookup, hash_put):
1531 * minibuf.c (Ftest_completion):
1532 Use ptrdiff_t for hash table indexes, not int (which is too
1533 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1534 32-bit --with-wide-int hosts).
1535
e097a6fa
PE
1536 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1537 Add a FIXME comment about memory leaks.
1538 (syms_of_charset): Don't assume xmalloc returns.
1539
5637687f
PE
1540 Don't assume that stated character widths fit in int.
1541 * character.c (Fchar_width, c_string_width, lisp_string_width):
1542 * character.h (CHAR_WIDTH):
1543 * indent.c (MULTIBYTE_BYTES_WIDTH):
1544 Use sanitize_char_width to avoid undefined and/or bad behavior
1545 with outlandish widths.
a66cfb1c 1546 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1547 now that we have two such functions. All uses changed.
1548 (sanitize_char_width): New inline function.
1549
a2271ba2
PE
1550 Don't assume that tab-width fits in int.
1551 * character.h (sanitize_width): New inline function.
1552 (SANE_TAB_WIDTH): New macro.
1553 (ASCII_CHAR_WIDTH): Use it.
1554 * indent.c (sane_tab_width): Remove. All uses replaced by
1555 SANE_TAB_WIDTH (current_buffer).
1556 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1557
18c52557
PE
1558 * fileio.c: Integer overflow issues with file modes.
1559 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1560
caeeedc1
PE
1561 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1562 Remove unreachable code.
1563 (read_hex, load_charset_map_from_file): Check for integer overflow.
1564
50849c52
PE
1565 * xterm.c: don't go over XClientMessageEvent limit
1566 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1567 (x_send_scroll_bar_event): Likewise. Check that the size does not
1568 exceed limits imposed by XClientMessageEvent, as well as the usual
1569 ptrdiff_t and size_t limits.
1570
b13995db
PE
1571 * keyboard.c: Overflow, signedness and related fixes.
1572 (make_lispy_movement): Use same integer type in forward decl
1573 that is used in the definition.
1574 (read_key_sequence, keyremap_step):
1575 Change bufsize argument back to int, undoing my 2011-03-30 change.
1576 We prefer signed types, and int is wide enough here.
1577 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1578 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1579 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1580 length, not size_t. Use ptrdiff_t for index, not int.
1581 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1582 possibility of integer overflow.
1583
13464394
PE
1584 Overflow, signedness and related fixes for images.
1585
1586 * dispextern.h (struct it.stack[0].u.image.image_id)
1587 (struct_it.image_id, struct image.id, struct image_cache.size)
1588 (struct image_cache.used, struct image_cache.ref_count):
1589 * gtkutil.c (update_frame_tool_bar):
1590 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1591 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1592 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1593 * nsmenu.m (update_frame_tool_bar):
1594 * xdisp.c (calc_pixel_width_or_height):
1595 * xfns.c (image_cache_refcount):
1596 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1597 on typical 64-bit hosts.
1598
1599 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1600 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1601 Omit unnecessary casts to int.
1602 (parse_image_spec): Check that integers fall into 'int' range
1603 when the callers expect that.
1604 (image_ascent): Redo ascent calculation to avoid int overflow.
1605 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1606 (lookup_image): Remove unnecessary tests.
1607 (xbm_image_p): Locals are now of int, not EMACS_INT,
1608 since parse_image_check makes sure they fit into int.
1609 (png_load, gif_load, svg_load_image):
1610 Prefer int to unsigned where either will do.
1611 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1612 old tiff_error_handler and tiff_warning_handler.
1613 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1614 stack buffer overflows. It uses only the features of vsnprintf
1615 that are common to both POSIX and native Microsoft.
1616 (tiff_error_handler, tiff_warning_handler): Use it.
1617 (tiff_load, gif_load, imagemagick_load_image):
1618 Don't assume :index value fits in 'int'.
1619 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1620 (imagemagick_load_image): Check that crop parameters fit into
1621 the integer types that MagickCropImage accepts. Don't assume
1622 Vimagemagick_render_type has a nonnegative value. Don't assume
1623 size_t fits in 'long'.
1624 (gs_load): Use printmax_t to print the widest integers possible.
1625 Check for integer overflow when computing image height and width.
1626
c11821d4
EZ
16272011-08-26 Eli Zaretskii <eliz@gnu.org>
1628
1629 * xdisp.c (redisplay_window): Don't force window start if point
1630 will be invisible in the resulting window. (Bug#9324)
1631
0c95fcf7
EZ
16322011-08-25 Eli Zaretskii <eliz@gnu.org>
1633
1634 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1635 the display spec is of the form `(space ...)'.
1636 (handle_display_spec): Return the value returned by
1637 handle_single_display_spec, not just 1 or zero.
1638 (handle_single_display_spec): If the display spec is of the form
1639 `(space ...)', and specifies display in the text area, return 2
1640 rather than 1.
fee65a97 1641 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1642 accurately, and prefer exact match for point under bidi.
1643 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1644
1645 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1646 into disp_prop; all users changed.
1647
1648 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1649 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1650 for the text covered by the display property.
1651
e4ed06f1
CY
16522011-08-25 Chong Yidong <cyd@stupidchicken.com>
1653
1654 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1655 Change return value to nil.
1656 (Frecord_buffer): Delete unused function.
1657
f67cdd7f
EZ
16582011-08-24 Eli Zaretskii <eliz@gnu.org>
1659
5980d4c6
EZ
1660 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1661 buffers, return left-to-right.
8610fe8b
EZ
1662 (set_cursor_from_row): Consider candidate row a win if its glyph
1663 represents a newline and point is on that newline. Fixes cursor
1664 positioning on the newline at EOL of R2L text within L2R
1665 paragraph, and vice versa.
1666 (try_cursor_movement): Check continued rows, in addition to
1667 continuation rows. Fixes unwarranted scroll when point enters a
1668 continued line of R2L text within an L2R paragraph, or vice versa.
1669 (cursor_row_p): Consider the case of point being equal to
1670 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1671 from the end of a short line to the beginning of a continued line
1672 of R2L text within L2R paragraph.
1673 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1674 composed characters.
5980d4c6 1675
f67cdd7f
EZ
1676 * bidi.c (bidi_check_type): Use xassert.
1677 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1678 members.
1679
bca633fb
EZ
16802011-08-23 Eli Zaretskii <eliz@gnu.org>
1681
1682 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1683 a character.
1684
4a5885a7
CY
16852011-08-23 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * nsfont.m (ns_otf_to_script): Fix typo.
1688
0902a04e
KH
16892011-08-22 Kenichi Handa <handa@m17n.org>
1690
1691 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1692 extra slot even if the purpose is char-code-property-table.
1693
1a2e6670
EZ
16942011-08-23 Eli Zaretskii <eliz@gnu.org>
1695
8ddde651
EZ
1696 * xdisp.c (redisplay_window): When computing centering_position,
1697 account for the height of the header line. (Bug#8874)
1698
425cc014
EZ
1699 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1700 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1701 candidate is selected by the mouse, and that candidate has a
1702 composed character under the mouse.
1703
1a2e6670
EZ
1704 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1705 coordinates reported by pos-visible-in-window-p for a composed
1706 character in column zero.
1707
8b76d6f8
SM
17082011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1709
1710 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1711
dac347dd
EZ
17122011-08-22 Eli Zaretskii <eliz@gnu.org>
1713
1714 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1715 consider it a hit if to_charpos is anywhere in the range of the
1716 composed buffer positions.
1717
e013fb34
CY
17182011-08-22 Chong Yidong <cyd@stupidchicken.com>
1719
1720 * image.c (gif_load): Don't assume that each subimage has the same
1721 dimensions as the base image. Handle disposal method that is
1722 "undefined" by the gif spec (Bug#9335).
1723
bd1ba3e8
CY
17242011-08-20 Chong Yidong <cyd@stupidchicken.com>
1725
1726 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1727 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1728
54a1215b
EZ
17292011-08-19 Eli Zaretskii <eliz@gnu.org>
1730
823564e5
EZ
1731 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1732 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1733 from an Org mode buffer to a Speedbar frame.
1734
54a1215b
EZ
1735 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1736 a composition, take its buffer position from IT->cmp_it.charpos.
1737 Fixes cursor positioning at the beginning of a line that begins
1738 with a composed character.
1739
9778ebcc
EZ
17402011-08-18 Eli Zaretskii <eliz@gnu.org>
1741
0be6ee06
EZ
1742 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1743 character bidirectional type, use STRONG_L instead. Fixes crashes
1744 in a buffer produced by `describe-categories'.
1745
9778ebcc
EZ
1746 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1747 members before the level stack, so they would be saved and
1748 restored when copying iterator state. Fixes incorrect reordering
1749 around TABs covered by display properties.
1750
156bffbe
AS
17512011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1752
6b02f655 1753 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 1754
72ad093b
CY
17552011-08-17 Chong Yidong <cyd@stupidchicken.com>
1756
1757 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1758 (internal_condition_case_2, internal_condition_case_n):
1759 Remove unnecessary aborts (Bug#9081).
72ad093b 1760
35774242
EZ
17612011-08-17 Eli Zaretskii <eliz@gnu.org>
1762
1763 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1764 has no `load' handler, try opening the file locally. (Bug#9311)
1765
db76dd85
KB
17662011-08-16 Ken Brown <kbrown@cornell.edu>
1767
1768 * gmalloc.c: Expand comment.
1769
b215eee5
EZ
17702011-08-16 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1773 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1774
a4579d33
KB
17752011-08-16 Ken Brown <kbrown@cornell.edu>
1776
1777 Fix memory allocation problems in Cygwin build (Bug#9273).
1778
1779 * unexcw.c ( __malloc_initialized): Declare external variable.
1780 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1781
8b76d6f8
SM
1782 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1783 New variables.
a4579d33
KB
1784 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1785 dumped emacs.
1786 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1787 in the static heap.
1788 [CYGWIN] (special_realloc): New function.
1789 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1790 requests to realloc storage in the static heap.
1791
3ebec551
PE
17922011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1793
1794 * bidi.c (bidi_initialize): Remove unused local.
1795
9fd8be00
EZ
17962011-08-15 Eli Zaretskii <eliz@gnu.org>
1797
6b02f655
SM
1798 * bidimirror.h:
1799 * biditype.h: Remove file.
1800 * makefile.w32-in ($(BLD)/bidi.$(O)):
1801 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
1802
1803 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1804
1805 * chartab.c: Improve commentary for the uniprop_table API.
1806
32413314
EZ
1807 * bidi.c (bidi_paragraph_init): Support zero value of
1808 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1809 (bidi_initialize): Use uniprop_table instead of including
1810 biditype.h and bidimirror.h.
32413314 1811
9fd8be00
EZ
1812 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1813 coordinates of the iterator when restoring from ppos_it.
1814 (Bug#9296)
1815
5cf2b69b
KH
18162011-08-14 Kenichi Handa <handa@m17n.org>
1817
1818 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1819 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1820
daf17d00
EZ
18212011-08-14 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (move_it_in_display_line_to): Don't invoke
1824 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1825 ppos_it. Fixes vertical cursor motion when line beginning is
1826 covered by an image. (Bug#9296)
1827
08e3161a
JD
18282011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1829
1830 * nsterm.h (ns_run_ascript): Declare.
1831 (NSAPP_DATA2_RUNASSCRIPT): Define.
1832
1833 * nsfns.m (as_script, as_result, as_status): New static variables.
1834 (ns_run_ascript): New function.
5e617bc2 1835 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1836 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1837 the event loop. Get status from as_status (Bug#7276).
1838
1839 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1840 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1841 the event loop (Bug#7276).
1842
a3720aa2
AS
18432011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1844
1845 * gnutls.c (QCgnutls_bootprop_priority)
1846 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1847 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1848 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1849 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1850 (QCgnutls_bootprop_verify_hostname_error)
1851 (QCgnutls_bootprop_callbacks_verify): Rename from
1852 Qgnutls_bootprop_..., all uses changed.
1853
1854 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1855 uses changed.
1856
0a0d27fb
PE
18572011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1858
19d5c50c
PE
1859 * xfaces.c (Qframe_set_background_mode): Now static.
1860 * dispextern.h (Qframe_set_background_mode): Remove decl.
1861
0a0d27fb
PE
1862 * process.c (Fnetwork_interface_info): Declare local only if needed.
1863
377538cb
JD
18642011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1865
1866 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1867 (Fnetwork_interface_list): Allocate in increments of bytes instead
1868 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1869 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1870 sockaddr.
1871 (struct ifflag_def): notrailers is smart on OSX.
1872 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1873 Get hardware address with getifaddrs if available.
1874
08fff70c
EZ
18752011-08-12 Eli Zaretskii <eliz@gnu.org>
1876
1877 * xdisp.c (iterate_out_of_display_property): xassert that
1878 IT->position is set to within IT->object's boundaries. Break from
1879 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1880 when IT->position is set up wrongly due to some bug.
1881 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1882 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1883 entry. Force push_it to save on the stack the current
1884 buffer/string position, to be restored by pop_it. Fix flags in
1885 the iterator structure wrt the object coming from a display
1886 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1887 properties. (Bug#9284)
1888
7be1c708 18892011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1890
7be1c708
CY
1891 * fontset.c (fontset_get_font_group): Add proper type checks.
1892 (Bug#9172)
aac0c6e3 1893
7be1c708 18942011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1895
7be1c708
CY
1896 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1897 and LC_VERSION_MIN_MACOSX.
1898 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1899 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1900
97bb72a6
EZ
19012011-08-08 Eli Zaretskii <eliz@gnu.org>
1902
1903 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1904 no-display-properties-and-no-overlays under bidi display.
1905 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1906 properties and overlays.
97bb72a6 1907
d5617611
CY
19082011-08-08 Chong Yidong <cyd@stupidchicken.com>
1909
37e11a63
CY
1910 * editfns.c (Fset_time_zone_rule): Document relationship with the
1911 setenv function.
1912
d5617611
CY
1913 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1914 the font entity extracted from the cache (Bug#8109).
1915
58872834
CY
19162011-08-07 Chong Yidong <cyd@stupidchicken.com>
1917
1918 * composite.c (autocmp_chars): Don't reset point. That is done by
1919 restore_point_unwind (Bug#5984).
1920
75bfc667
JL
19212011-08-07 Juri Linkov <juri@jurta.org>
1922
1923 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1924 to show the arg `TIME' instead of `TIMEVAL'.
1925
d1410150
EZ
19262011-08-06 Eli Zaretskii <eliz@gnu.org>
1927
1928 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1929 display property strides EOL and includes a newline, as in
1930 longlines-mode. (Bug#9254)
75b771e4
EZ
1931 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1932 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1933
1934 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1935 is non-zero, even if the data buffer is NULL. Fixes a crash in
1936 vertical-motion with longlines-mode. (Bug#9254)
1937
35928349
EZ
19382011-08-05 Eli Zaretskii <eliz@gnu.org>
1939
ec7cc85b
EZ
1940 * bidi.c <bidi_cache_total_alloc>: Now static.
1941 (bidi_initialize): Initialize bidi_cache_total_alloc.
1942
8b76d6f8 1943 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1944 cache. (Bug#9221)
1945
1946 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1947 amount allocated this far in `bidi_cache_total_alloc'.
1948 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1949 non-zero, only free the data buffer without restoring the cache
1950 contents. All callers changed.
1951
1952 * dispextern.h (bidi_unshelve_cache): Update prototype.
1953
1954 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1955 (move_it_in_display_line, move_it_to)
1956 (move_it_vertically_backward, move_it_by_lines): Replace the call
1957 to xfree to an equivalent call to bidi_unshelve_cache.
1958 (move_it_in_display_line_to): Fix logic of returning
412b6358 1959 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1960
e2e2423b
EZ
19612011-08-05 Eli Zaretskii <eliz@gnu.org>
1962
1963 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1964 came from a string character with a `cursor' property. (Bug#9229)
1965
ae9e757a
JD
19662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1967
1968 * Makefile.in (LIB_PTHREAD): New variable.
1969 (LIBES): Add LIB_PTHREAD (Bug#9216).
1970
1971 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1972 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1973
213bd7f2
AS
19742011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1975
6b02f655 1976 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 1977
99aaf75f
JD
19782011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1979
1980 * xterm.c (x_find_topmost_parent): New function.
1981 (x_set_frame_alpha): Find topmost parent window with
1982 x_find_topmost_parent and set the property there also (bug#9181).
1983 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1984
c74e9d86
PE
19852011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 * callproc.c (Fcall_process): Avoid vfork clobbering
1988 the local vars buffer, coding_systems, current_dir.
1989
640c8776
SM
19902011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1991
1992 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1993
f26d0e4c
PE
19942011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1995
8a10d76c
PE
1996 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1997 so that it is not optimized away.
1998
f26d0e4c
PE
1999 * xdisp.c (compute_display_string_pos): Remove unused local.
2000
55439c61
EZ
20012011-08-02 Eli Zaretskii <eliz@gnu.org>
2002
2003 Fix slow cursor motion and scrolling in large buffers with
2004 selective display, like Org Mode buffers. (Bug#9218)
2005
2006 * dispextern.h (struct bidi_it): New member disp_prop_p.
2007
2008 * xdisp.c: Remove one-slot cache of display string positions.
2009 (compute_display_string_pos): Accept an additional argument
5e617bc2 2010 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2011 for a display string or property. If found, set DISP_PROP_P
2012 non-zero.
2013
2014 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2015 DISP_PROP_P, and pass it to compute_display_string_pos.
2016 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2017 non-zero. All callers of bidi_fetch_char changed.
2018
fb33fa43
SM
20192011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2020
2021 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2022
b099e063
DM
20232010-12-03 Don March <don@ohspite.net>
2024
2025 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2026 last character M-[char] is translated to ESC [char] (bug#7541).
2027
5cc7f7af
KH
20282011-08-02 Kenichi Handa <handa@m17n.org>
2029
d0fffa3f 2030 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2031
2032 * chartab.c (uniprop_table): Make it non-static.
2033
525d5e6e
EZ
20342011-08-01 Eli Zaretskii <eliz@gnu.org>
2035
2036 * xdisp.c (forward_to_next_line_start): Accept additional argument
2037 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2038 on the newline.
2039 (reseat_at_next_visible_line_start): Use the bidi iterator state
2040 returned by forward_to_next_line_start to restore the state of
2041 it->bidi_it after backing up to previous newline. (Bug#9212)
2042
31011111
AS
20432011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2044
2045 * regex.c (re_comp): Protoize.
2046 (re_exec): Fix return type.
2047 (regexec): Fix type of `ret'. (Bug#9203)
2048
476371c4
PE
20492011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2050
e5d76069
PE
2051 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2052 This is needed if max-image-size is a floating-point number.
2053
9a79b20c
AS
20542011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2055
2056 * print.c (print_object): Print empty symbol as ##.
2057
2058 * lread.c (read1): Read ## as empty symbol.
2059
d8c2fa78
AA
20602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2061
2062 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2063 setting frame foreground color (Bug#9175).
2064 (x_set_background_color): Likewise.
2065
ffe57a7a
AA
2066 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2067 contents (Bug#9176).
2068 (EmacsTooltip -init): Remove bezels and add shadows to
2069 tooltip windows.
2070
bf3492a5
AA
2071 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2072 or scroll bar (Bug#8470).
2073
d55e9c53
AA
2074 * nsfont.m (nsfont_open): Remove assignment to voffset and
2075 unnecessary vars hshink, expand, hd, full_height, min_height.
2076 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2077
2078 * nsterm.h (nsfont_info): Remove voffset field.
2079
d8c2fa78 20802011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2081
2082 Implement strike-through and overline on NextStep (Bug#8863).
2083
2084 * nsfont.m (nsfont_open): Use underline position provided by font,
2085 instead of hard-coded value of 2.
2086 (nsfont_draw): Call ns_draw_text_decoration instead.
2087
2088 * nsterm.h: Add declaration for ns_draw_text_decoration.
2089
2090 * nsterm.m (ns_draw_text_decoration): New function for drawing
2091 underline, overline, and strike-through.
2092 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2093 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2094 accommodate underlining, etc.
4843aac3 2095
4cc60b9b
EZ
20962011-07-28 Eli Zaretskii <eliz@gnu.org>
2097
bc7ece87
EZ
2098 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2099 default.
4cc60b9b 2100
476371c4
PE
21012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2102
66606eea
PE
2103 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2104 Without this fix, if a signal arrives just after memory fills up,
2105 'malloc' might be invoked reentrantly.
2106
476371c4
PE
2107 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2108 In other words, assume that every image size is allowed, on non-X
2109 hosts. This assumption is probably wrong, but it lets Emacs compile.
2110
f3fcc40d
AS
21112011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2112
2113 * regex.c (re_iswctype): Convert return values to boolean.
2114
350c992f
EZ
21152011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2116
2117 * xdisp.c (compute_display_string_pos): Don't use cached display
2118 string position if the buffer had its restriction changed.
2119 (Bug#9184)
2120
5266b4bb
PE
21212011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2124
2573a837 21252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2126
41f55ccd 2127 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2128
39e378da
PE
2129 * bidi.c: Integer size and overflow fixes.
2130 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2131 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2132 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2133 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2134 (bidi_find_other_level_edge):
2135 Use ptrdiff_t instead of EMACS_INT where either will do.
2136 This works better on 32-bit hosts configured --with-wide-int.
2137 (bidi_cache_ensure_space): Check for size-calculation overflow.
2138 Use % rather than repeated addition, for better worst-case speed.
2139 Don't set bidi_cache_size until after xrealloc returns, because it
2140 might not return.
2141 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2142 (bidi_cache_ensure_space): Also check that the bidi cache size
2143 does not exceed that of the largest Lisp string or buffer. See Eli
2144 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2145
5e927815
PE
2146 * alloc.c (__malloc_size_t): Remove.
2147 All uses replaced by size_t. See Andreas Schwab's note
2148 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2149
ca4aa935
PE
2150 * image.c: Improve checking for integer overflow.
2151 (check_image_size): Assume that f is nonnull, since
2152 it is always nonnull in practice. This is one less thing to
2153 worry about when checking for integer overflow later.
2154 (x_check_image_size): New function, which checks for integer
2155 overflow issues inside X.
2156 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2157 This removes the need for a memory_full check.
2158 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2159 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2160 (xbm_read_bitmap_data): Change locals back to 'int', since
2161 their values must fit in 'int'.
2162 (xpm_load_image, png_load, tiff_load):
2163 Invoke x_create_x_image_and_pixmap earlier,
2164 to avoid much needless work if the image is too large.
2165 (tiff_load): Treat overly large images as if
2166 x_create_x_image_and_pixmap failed, not as malloc failures.
2167 (gs_load): Use x_check_image_size.
2168
5f8f9cc2
PE
2169 * gtkutil.c: Omit integer casts.
2170 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2171 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2172
5adf60bc
PE
2173 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2174
c8907a93
PE
2175 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2176 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2177 would wrongly return t on a 64-bit host.
2178
e3c25c68
PE
2179 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2180 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2181 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2182 and therefore cause GCC to emit a bogus diagnostic in some cases.
2183
3f791afe
PE
2184 * image.c: Integer signedness and overflow and related fixes.
2185 This is not an exhaustive set of fixes, but it's time to
2186 record what I've got.
2187 (lookup_pixel_color, check_image_size): Remove redundant decls.
2188 (check_image_size): Don't assume that arbitrary EMACS_INT values
2189 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2190 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2191 (tiff_load, imagemagick_load_image):
2192 Check for overflow in size calculations.
2193 (x_create_x_image_and_pixmap): Remove unnecessary test for
2194 xmalloc returning NULL; that can't happen.
2195 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2196 (xpm_color_bucket): Use better integer hashing function.
2197 (xpm_cache_color): Don't possibly over-allocate memory.
2198 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2199 (gif_memory_source):
2200 Use ptrdiff_t, not int or size_t, to record sizes.
2201 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2202 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2203 either works, as we prefer signed integers.
2204 (tiff_read_from_memory, tiff_write_from_memory):
2205 Return tsize_t, not size_t, since that's what the TIFF API wants.
2206 (tiff_read_from_memory): Don't fail simply because the read would
2207 go past EOF; instead, return a short read.
2208 (tiff_load): Omit no-longer-needed casts.
2209 (Fimagemagick_types): Don't assume size fits into 'int'.
2210
3cc5a532
PE
2211 Improve hashing quality when configured --with-wide-int.
2212 * fns.c (hash_string): New function, taken from sxhash_string.
2213 Do not discard information about ASCII character case; this
2214 discarding is no longer needed.
2215 (sxhash-string): Use it. Change sig to match it. Caller changed.
2216 * lisp.h: Declare it.
2217 * lread.c (hash_string): Remove, since we now use fns.c's version.
2218 The fns.c version returns a wider integer if --with-wide-int is
2219 specified, so this should help the quality of the hashing a bit.
2220
b312a492
PE
2221 * emacs.c: Integer overflow minor fix.
2222 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2223 Define only if GNU_LINUX.
2224 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2225
dfd153ae
PE
2226 * dispnew.c: Integer signedness and overflow fixes.
2227 Remove unnecessary forward decls, that were a maintenance hassle.
2228 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2229 All uses changed.
2230 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2231 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2232 (prepare_desired_row, line_draw_cost):
2233 Use int, not unsigned, where either works.
2234 (save_current_matrix, restore_current_matrix):
2235 Use ptrdiff_t, not size_t, where either works.
2236 (init_display): Check for overflow more accurately, and without
2237 relying on undefined behavior.
2238
a81d11a3
PE
2239 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2240 Remove, replacing with the new symbols in lisp.h. All uses changed.
2241 * fileio.c (make_temp_name):
2242 * filelock.c (lock_file_1, lock_file):
2243 * xdisp.c (message_dolog):
2244 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2245 Use pMd etc. instead.
2246 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2247 replacing the pWIDE etc. symbols removed from editfns.c.
2248
3300e6fd
PE
2249 * keyboard.h (num_input_events): Now uintmax_t.
2250 This is (very slightly) less likely to mess up due to wraparound.
2251 All uses changed.
2252
fd05c7e9
PE
2253 * buffer.c: Integer signedness fixes.
2254 (alloc_buffer_text, enlarge_buffer_text):
2255 Use ptrdiff_t rather than size_t when either will do, as we prefer
2256 signed integers.
2257
903fe15d
PE
2258 * alloc.c: Integer signedness and overflow fixes.
2259 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2260 (__malloc_size_t): Default to size_t, not to int.
2261 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2262 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2263 Prefer ptrdiff_t to size_t when either would do, as we prefer
2264 signed integers.
2265 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2266 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2267 Now const. Initialize with values that are in range even if char
2268 is signed.
2269 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2270 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2271 These functions do the right thing with sizes > 2**32.
2272 (check_depth): Now ptrdiff_t, not int.
2273 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2274 Adjust to new way of storing sizes. Check for size overflow bugs
2275 in rest of code.
2276 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2277 slightly wrong anyway, as it missed one instance of
2278 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2279 (refill_memory_reserve): Omit needless cast to size_t.
2280 (mark_object_loop_halt): Mark as externally visible.
2281
ac82cc6a
PE
2282 * xselect.c: Integer signedness and overflow fixes.
2283 (Fx_register_dnd_atom, x_handle_dnd_message):
2284 Use ptrdiff_t, not size_t, since we prefer signed.
2285 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2286 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2287 x_dnd_atoms_size and x_dnd_atoms_length.
2288
c2d1e36d
PE
2289 * doprnt.c: Prefer signed to unsigned when either works.
2290 * eval.c (verror):
2291 * doprnt.c (doprnt):
2292 * lisp.h (doprnt):
2293 * xdisp.c (vmessage):
2294 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2295 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2296 prefer signed arithmetic to avoid comparison confusion.
2297 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2298 but is a bit tricky.
2299
0e926e56
PE
2300 Assume freestanding C89 headers, string.h, stdlib.h.
2301 * data.c, doprnt.c, floatfns.c, print.c:
2302 Include float.h unconditionally.
2303 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2304 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2305 * regex.c: Likewise for stddef.h, string.h.
2306 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2307 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2308 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2309 (STDC_HEADERS): Remove obsolete defines.
2310 * sysdep.c: Include limits.h unconditionally.
2311
9cfdb3ec
PE
2312 Assume support for memcmp, memcpy, memmove, memset.
2313 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2314 * regex.c (memcmp, memcpy):
2315 Remove; we assume C89 now.
2316
2317 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2318 (__malloc_safe_bcopy): Remove; no longer needed.
2319
cf950e6b 2320 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2321 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2322 well either way, and we prefer signed to unsigned.
2323
dbf38e02
LMI
23242011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2325
2326 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2327 closes the connection while we're reading (bug#9182).
2328
d6f0886c 23292011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2330
d6f0886c
JD
2331 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2332 are specified (Bug#9168).
24e0f6b1 2333
2eb1f9e6
PE
23342011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2335
2336 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2337 Found by GCC static checking and --with-wide-int on a 32-bit host.
2338
22381272 23392011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2340
2341 * xdisp.c (compute_display_string_pos): Fix logic of caching
2342 previous display string position. Initialize cached_prev_pos to
2343 -1. Fixes slow-down at the beginning of a buffer.
2344
f25e39b4
EZ
23452011-07-24 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2348 for attrs[LFACE_FONTSET_INDEX].
2349
04c4b52e
PE
23502011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2351
2352 * xml.c (parse_region): Remove unused local
2353 that was recently introduced.
2354
c1734fbd
EZ
23552011-07-23 Eli Zaretskii <eliz@gnu.org>
2356
be18c5a5
EZ
2357 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2358 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2359
c1734fbd
EZ
2360 * xdisp.c (move_it_in_display_line_to): Record the best matching
2361 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2362 exit if none of the characters scanned was an exact match.
2363 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2364 when exact match is impossible due to invisible text, and the
2365 lines are truncated.
2366
a258d627
JD
23672011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2368
2369 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2370 for OSX >= 10.7.
2371
b6d5a689
EZ
23722011-07-22 Eli Zaretskii <eliz@gnu.org>
2373
0f74f785
EZ
2374 Fix a significant slow-down of cursor motion with C-n, C-p,
2375 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2376 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2377 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2378 (next_element_from_buffer): Call compute_stop_pos_backwards to
2379 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2380 base_level_stop.
2381 (reseat): Don't look for prev_stop, as that could mean a very long
2382 run.
2383 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2384 <cached_disp_overlay_modiff>: Cache for last found display string
2385 position.
551918c1 2386 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2387 about the same buffer in the same area of character positions, and
2388 the buffer wasn't changed since the time the display string
2389 position was cached.
551918c1 2390
b2d0c91a
EZ
23912011-07-22 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2394 is an integer, which is important for empty lines. (Bug#9149)
2395
043604ee
CY
23962011-07-22 Chong Yidong <cyd@stupidchicken.com>
2397
2398 * frame.c (Fmodify_frame_parameters): In tty case, update the
2399 default face if necessary (Bug#4238).
2400
da4adb04
CY
24012011-07-21 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * editfns.c (Fstring_to_char): No need to explain what a character
2404 is in the docstring (Bug#6576).
2405
9abd0532
LMI
24062011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2407
2408 * xml.c (parse_region): Make sure we always return a tree.
2409
36881d16
HK
24102011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2411
2412 * xml.c (parse_region): If a document contains only comments,
2413 return that, too.
2414
1e98674d
LMI
24152011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2416
2417 * xml.c (make_dom): Return comments, too.
2418
590bd467
PE
24192011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Port to OpenBSD.
2422 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2423 and the surrounding thread.
2424 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2425 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2426 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2427 timer goes off.
2428 * s/openbsd.h (BROKEN_SIGIO): Define.
2429 * unexelf.c (unexec) [__OpenBSD__]:
2430 Don't update the .mdebug section of the Alpha COFF symbol table.
2431
f41628b2
LMI
24322011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2433
2434 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2435 (bug#8460).
2436
b59b67c5
PE
24372011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2438
15e3a074
PE
2439 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2440 This fixes some race conditions on the permissions of any newly
2441 created file.
2442
41bed37d
PE
2443 * alloc.c (valid_pointer_p): Use pipe, not open.
2444 This fixes some permissions issues when debugging.
2445
b59b67c5
PE
2446 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2447 If fchown fails to set both uid and gid, try to set just gid,
2448 as that is sometimes allowed. Adjust the file's mode to eliminate
2449 setuid or setgid bits that are inappropriate if fchown fails.
2450
925a6be7
SM
24512011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2452
2453 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2454 to compare Lisp_Objects.
2455 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2456 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2457 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2458
52968808
AS
24592011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2460
0a6a104b
AS
2461 * lread.c (read_integer): Unread even EOF character.
2462 (read1): Likewise. Properly record start position of symbol.
2463
52968808
AS
2464 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2465 symbol character follows.
2466
9e381cdd
PE
24672011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2468
2469 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2470 This works around a problem with the previous change to Fcopy_file.
2471 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2472 and without this change, GCC might complain about discarding
2473 fchown's return value.
2474
b5641435
JB
24752011-07-16 Juanma Barranquero <lekktu@gmail.com>
2476
2477 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2478
a8031457
PE
24792011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2480
2481 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2482
dd889327
LMI
24832011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2484
750c33f7
LMI
2485 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2486 it's used from the C level.
2487
dd889327
LMI
2488 * process.c: Use the same condition for POLL_FOR_INPUT in both
2489 keyboard.c and process.c (bug#1858).
2490
87e86684
LM
24912011-07-09 Lawrence Mitchell <wence@gmx.li>
2492
2493 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2494 (Fgnutls_boot): Use it.
2495
64348f40
AS
24962011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2497
2498 * doc.c (Fsubstitute_command_keys): Revert last change.
2499
1d698799
LMI
25002011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2501
f863868c
LMI
2502 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2503 quotes the next character, and doesn't affect other longer
2504 sequences (bug#8935).
2505
1d698799
LMI
2506 * lread.c (syms_of_lread): Clarify that is isn't only
2507 `eval-buffer' and `eval-defun' that's affected by
2508 `lexical-binding' (bug#8460).
2509
aa4b6df6
EZ
25102011-07-15 Eli Zaretskii <eliz@gnu.org>
2511
2512 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2513 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2514
5d856da6
PE
25152011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2516
ad6042bb
PE
2517 Fix minor problems found by static checking.
2518 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2519 (elsz): Now a signed constant, not a size_t var. We prefer signed
2520 types to unsigned, to avoid integer comparison confusion. Without
2521 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2522 "cannot optimize loop, the loop counter may overflow", a symptom
2523 of the confusion.
f00bbb22 2524 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2525 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2526
6468f31c
LMI
25272011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2528
49080b10
LMI
2529 * search.c (Fre_search_backward): Mention `case-fold-search' in
2530 all the re_search_* functions (bug#8138).
2531
6468f31c
LMI
2532 * keyboard.c (Fopen_dribble_file): Document when the file is
2533 closed (bug#8056).
2534
c965adc5
EZ
25352011-07-14 Eli Zaretskii <eliz@gnu.org>
2536
df9733bf
EZ
2537 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2538 bidi_cache_idx.
2539
0bb23927
EZ
2540 Support bidi reordering of display and overlay strings.
2541 * xdisp.c (compute_display_string_pos)
2542 (compute_display_string_end): Accept additional argument STRING.
2543 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2544 (reseat_to_string): Initialize bidi_it->string.s and
2545 bidi_it->string.schars.
2546 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2547 NULL (avoids a crash in bidi_paragraph_init).
2548 Initialize itb.string.lstring.
0bb23927
EZ
2549 (init_iterator): Call bidi_init_it only of a valid
2550 buffer position was specified. Initialize paragraph_embedding to
2551 L2R.
2552 (reseat_to_string): Initialize the bidi iterator.
2553 (display_string): If we need to ignore text properties of
2554 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2555 original value of -1 will not work with bidi.)
2556 (compute_display_string_pos): First arg is now struct
2557 `text_pos *'; all callers changed. Support display properties on
2558 Lisp strings.
2559 (compute_display_string_end): Support display properties on Lisp
2560 strings.
2561 (init_iterator, reseat_1, reseat_to_string): Initialize the
2562 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2563 when iterating on a string not from display properties).
640c8776
SM
2564 (compute_display_string_pos, compute_display_string_end):
2565 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2566 arrow keys.
2567 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2568 base_level_stop; instead, set base_level_stop to BEGV.
2569 Fixes crashes in vertical-motion.
0bb23927
EZ
2570 (next_element_from_buffer): Improve commentary for when
2571 the iterator is before prev_stop.
2572 (init_iterator): Initialize bidi_p from the default value of
2573 bidi-display-reordering, not from buffer-local value. Use the
2574 buffer-local value only if initializing for buffer iteration.
2575 (handle_invisible_prop): Support invisible properties on strings
2576 that are being bidi-reordered.
2577 (set_iterator_to_next): Support bidi reordering of C strings and
2578 Lisp strings.
2579 (next_element_from_string): Support bidi reordering of Lisp
2580 strings.
2581 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2582 (display_string): Support display of R2L glyph rows.
2583 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2584 (init_iterator): Don't initialize it->bidi_p for strings
2585 here.
2586 (reseat_to_string): Initialize it->bidi_p for strings here.
2587 (next_element_from_string, next_element_from_c_string)
2588 (next_element_from_buffer): Add xassert's for correspondence
2589 between IT's object being iterated and it->bidi_it.string
2590 structure.
2591 (face_before_or_after_it_pos): Support bidi iteration.
2592 (next_element_from_c_string): Handle the case of the first string
2593 character that is not the first one in the visual order.
2594 (get_visually_first_element): New function, refactored from common
2595 parts of next_element_from_buffer, next_element_from_string, and
2596 next_element_from_c_string.
2597 (tool_bar_lines_needed, redisplay_tool_bar)
2598 (display_menu_bar): Force left-to-right direction. Add a FIXME
2599 comment for making that be controlled by a user option.
2600 (push_it, pop_it): Save and restore the state of the
2601 bidi iterator. Save and restore the bidi_p flag.
2602 (pop_it): Iterate out of display property for string iteration as
2603 well.
2604 (iterate_out_of_display_property): Support iteration over strings.
2605 (handle_single_display_spec): Set up it->bidi_it for iteration
2606 over a display string, and call bidi_init_it.
2607 (handle_single_display_spec, next_overlay_string)
2608 (get_overlay_strings_1, push_display_prop): Set up the bidi
2609 iterator for displaying display or overlay strings.
2610 (forward_to_next_line_start): Don't use the shortcut if
2611 bidi-iterating.
2612 (back_to_previous_visible_line_start): If handle_display_prop
2613 pushed the iterator stack, restore the internal state of the bidi
2614 iterator by calling bidi_pop_it same number of times.
2615 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2616 and we are bidi-iterating, don't decrement the iterator position;
2617 instead, set the first_elt flag in the bidi iterator, to produce
2618 the same effect.
2619 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2620 (push_display_prop): xassert that we are iterating a buffer.
2621 (push_it, pop_it): Save and restore paragraph_embedding member.
2622 (handle_single_display_spec, next_overlay_string)
2623 (get_overlay_strings_1, reseat_1, reseat_to_string)
2624 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2625 correctly. Don't assume unibyte strings are not bidi-reordered.
2626 (compute_display_string_pos)
2627 (compute_display_string_end): Fix handling the case of C string.
2628 (push_it, pop_it): Save and restore from_disp_prop_p.
2629 (handle_single_display_spec, push_display_prop): Set the
2630 from_disp_prop_p flag.
2631 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2632 (pop_it): Call iterate_out_of_display_property only if we are
2633 popping after iteration over a string that came from a display
2634 property. Fix a typo in popping stretch info. Add an assertion
2635 for verifying that the iterator position is in sync with the bidi
2636 iterator.
2637 (handle_single_display_spec, get_overlay_strings_1)
2638 (push_display_prop): Fix initialization of paragraph direction for
2639 string when that of the parent object is not yet determined.
2640 (reseat_1): Call bidi_init_it to resync the bidi
2641 iterator with IT's position. (Bug#7616)
2642 (find_row_edges): If ROW->start.pos gives position
2643 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2644 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2645 Reset the from_disp_prop_p flag.
2646 (SAVE_IT, RESTORE_IT): New macros.
2647 (pos_visible_p, face_before_or_after_it_pos)
2648 (back_to_previous_visible_line_start)
2649 (move_it_in_display_line_to, move_it_in_display_line)
2650 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2651 (try_scrolling, redisplay_window, display_line): Use them when
2652 saving a temporary copy of the iterator and restoring it back.
2653 (back_to_previous_visible_line_start, reseat_1)
2654 (init_iterator): Empty the bidi cache "stack".
2655 (move_it_in_display_line_to): If iterator ended up at
2656 EOL, but we never saw any buffer positions smaller than
2657 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2658 motion in bidi-reordered lines.
2659 (move_it_in_display_line_to): Record prev_method and prev_pos
2660 immediately before the call to set_iterator_to_next. Fixes cursor
2661 motion in bidi-reordered lines with stretch glyphs and strings
2662 displayed in margins. (Bug#8133) (Bug#8867)
2663 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2664 TO_CHARPOS.
640c8776
SM
2665 (pos_visible_p): Support positions in bidi-reordered lines.
2666 Save and restore bidi cache.
0bb23927
EZ
2667
2668 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2669 (bidi_paragraph_info): Delete unused struct.
2670 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2671 (bidi_cache_start): New variable.
2672 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2673 to zero.
2674 (bidi_cache_fetch_state, bidi_cache_search)
2675 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2676 (bidi_cache_find, bidi_peek_at_next_level)
2677 (bidi_level_of_next_char, bidi_find_other_level_edge)
2678 (bidi_move_to_visually_next): Compare cache index with
2679 bidi_cache_start rather than with zero.
2680 (bidi_fetch_char): Accept new argument STRING; all callers
2681 changed. Support iteration over a string. Support strings with
2682 display properties. Support unibyte strings. Fix the type of
2683 `len' according to what STRING_CHAR_AND_LENGTH expects.
2684 (bidi_paragraph_init, bidi_resolve_explicit_1)
2685 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2686 (bidi_level_of_next_char, bidi_move_to_visually_next):
2687 Support iteration over a string.
0bb23927
EZ
2688 (bidi_set_sor_type, bidi_resolve_explicit_1)
2689 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2690 can now be zero (for strings); special values 0 and -1 were
2691 changed to -1 and -2, respectively.
2692 (bidi_char_at_pos): New function.
2693 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2694 Call it instead of FETCH_MULTIBYTE_CHAR.
2695 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2696 initialized to valid values.
2697 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2698 values.
2699 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2700 the test for valid cached positions. Fix the logic for looking up
2701 the sentinel state in the cache. GCPRO the Lisp string we are
2702 iterating.
2703 (bidi_push_it, bidi_pop_it): New functions.
2704 (bidi_initialize): Initialize the bidi cache start stack pointer.
2705 (bidi_cache_ensure_space): New function, refactored from part of
2706 bidi_cache_iterator_state. Don't assume the required size is just
2707 one BIDI_CACHE_CHUNK away.
2708 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2709 (bidi_count_bytes, bidi_char_at_pos): New functions.
2710 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2711 always valid if bidi_cache_idx is valid.
2712 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2713 is valid if it's going to be used.
2714 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2715 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2716 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2717 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2718 (bidi_find_other_level_edge, bidi_cache_start_stack):
2719 All variables related to cache indices are now EMACS_INT.
c965adc5 2720
0bb23927
EZ
2721 * dispextern.h (struct bidi_string_data): New structure.
2722 (struct bidi_it): New member `string'. Make flag members be 1-bit
2723 fields, and put them last in the struct.
640c8776
SM
2724 (compute_display_string_pos, compute_display_string_end):
2725 Update prototypes.
0bb23927
EZ
2726 (bidi_push_it, bidi_pop_it): Add prototypes.
2727 (struct iterator_stack_entry): New members bidi_p,
2728 paragraph_embedding, and from_disp_prop_p.
2729 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2730 (bidi_shelve_cache, bidi_unshelve_cache):
2731 Declare prototypes.
0bb23927
EZ
2732
2733 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2734 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2735 and vector-like objects.
2736
2737 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2738 cache around display iteration.
2739
2740 * window.c (Fwindow_end, window_scroll_pixel_based)
2741 (displayed_window_lines, Frecenter): Save and restore the bidi
2742 cache around display iteration.
2743
3bbd2265
LMI
27442011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2745
2746 * editfns.c (Fdelete_region): Clarify the use of the named
2747 parameters (bug#6788).
2748
adc47434
MR
27492011-07-14 Martin Rudalics <rudalics@gmx.at>
2750
2751 * indent.c (Fvertical_motion): Set and restore w->pointm when
2752 saving and restoring the window's buffer (Bug#9006).
2753
837c31f8
LMI
27542011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2755
2756 * editfns.c (Fstring_to_char): Clarify just what is returned
2757 (bug#6576). Text by Eli Zaretskii.
2758
ac389d0c
JB
27592011-07-13 Juanma Barranquero <lekktu@gmail.com>
2760
2761 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2762
0be0ce47
EZ
27632011-07-13 Eli Zaretskii <eliz@gnu.org>
2764
2765 * buffer.c (mmap_find): Fix a typo.
2766
cd18e7e3
JB
27672011-07-13 Johan Bockgård <bojohan@gnu.org>
2768
2769 Fix execution of x selection hooks.
2770 * xselect.c (Qx_lost_selection_functions)
2771 (Qx_sent_selection_functions): New vars.
2772 (syms_of_xselect): DEFSYM them.
2773 (x_handle_selection_request): Pass Qx_sent_selection_functions
2774 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2775 (x_handle_selection_clear,x_clear_frame_selections):
2776 Pass Qx_lost_selection_functions rather than
2777 Vx_lost_selection_functions to Frun_hook_with_args.
2778
47ea7f44
PE
27792011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2780
ac389d0c 2781 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2782 The old code sometimes used this field without initializing it.
2783
47ea7f44
PE
2784 * alloc.c (gc_sweep): Don't read past end of array.
2785 In theory, the old code could also have corrupted Emacs internals,
2786 though it'd be very unlikely.
2787
bc985c87
AS
27882011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2789
2790 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2791 argument. (Bug#4026)
bc985c87 2792
0cf34688
LMI
27932011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2794
b3dadd76
LMI
2795 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2796 key" (bug#4257).
2797
0cf34688
LMI
2798 * window.c (Fset_window_start): Doc fix (bug#4199).
2799 (Fset_window_hscroll): Ditto.
2800
270768cd
PE
28012011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2802
077e3dda 2803 Fix minor new problems caught by GCC 4.6.1.
270768cd 2804 * term.c (init_tty): Remove unused local.
490011a6 2805 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2806 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2807 not used otherwise.
270768cd 2808
b1f58454
CY
28092011-07-12 Chong Yidong <cyd@stupidchicken.com>
2810
2811 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2812
22b9578d
LMI
28132011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2814
6e70ab07
LMI
2815 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2816 are the mini-buffer and the echo area (bug#3320).
2817
22b9578d
LMI
2818 * term.c (init_tty): Remove support for supdup, c10 and perq
2819 terminals, which are no longer supported (bug#1482).
2820
8974cc9f
JB
28212011-07-10 Johan Bockgård <bojohan@gnu.org>
2822
2823 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2824
a560d974
JD
28252011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2826
2827 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2828 for non-popups (Bug#3642).
2829
1dae0f0a
AS
28302011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2831
268c2c36 2832 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2833 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2834 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2835 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2836 * data.c (fmod): Likewise.
2837 * dispnew.c (swap_glyphs_in_rows): Likewise.
2838 * emacs.c (memory_warning_signal): Likewise.
2839 * floatfns.c (float_error): Likewise.
2840 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2841 (otf_open, font_otf_capability, generate_otf_features)
2842 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2843 Likewise.
2844 * image.c (pbm_read_file): Likewise.
2845 * indent.c (string_display_width): Likewise.
2846 * intervals.c (check_for_interval, search_for_interval)
2847 (inc_interval_count, count_intervals, root_interval)
2848 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2849 * lread.c (defalias): Likewise.
268c2c36 2850 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2851 * regex.c (set_image_of_range_1, set_image_of_range)
2852 (regex_grow_registers): Likewise.
2853 * sysdep.c (strerror): Likewise.
2854 * termcap.c (valid_filename_p, tprint, main): Likewise.
2855 * tparam.c (main): Likewise.
2856 * unexhp9k800.c (run_time_remap, save_data_space)
2857 (update_file_ptrs, read_header, write_header, calculate_checksum)
2858 (copy_file, copy_rest, display_header): Likewise.
2859 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2860 Likewise.
2861 * xdisp.c (check_it): Likewise.
2862 * xfaces.c (register_color, unregister_color, unregister_colors):
2863 Likewise.
2864 * xfns.c (print_fontset_result): Likewise.
2865 * xrdb.c (member, fatal, main): Likewise.
2866
99033785
PE
28672011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2868
2869 Fix minor problems found by static checking (Bug#9031).
2870 * chartab.c (char_table_set_range, map_sub_char_table):
2871 Remove unused locals.
2872 (uniprop_table): Now static.
2873 * composite.c (_work_char): Remove unused static var.
2874
9cb2ac56
JB
28752011-07-09 Juanma Barranquero <lekktu@gmail.com>
2876
2877 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2878
f25661f0
JD
28792011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2880
2881 * gtkutil.c (qttip_cb): Remove code without function.
2882
8278c4fe
EZ
28832011-07-09 Eli Zaretskii <eliz@gnu.org>
2884
2885 * w32.c (pthread_sigmask): New stub.
2886
1692ae2d 28872011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2888
8a6ebd58 2889 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2890 sigprocmask is portable only for single-threaded applications, and
2891 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2892 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2893 (LIBES): Use it.
2894 * callproc.c (Fcall_process):
2895 * process.c (create_process):
2896 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2897 Use pthread_sigmask, not sigprocmask.
123403e4 2898
1b854618
JD
28992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2900
2901 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2902 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2903 wrong (Bug#8591).
2904
3fe4b549
JD
29052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2906
0ce7e563
JD
2907 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2908 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2909 (xg_hide_tooltip): Fix comment.
2910
3fe4b549
JD
2911 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2912 in registerServicesMenuSendTypes.
2913 (validRequestorForSendType): Don't check ns_return_types.
2914
2915 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2916 ns_return_type.
2917
5df75e47
JR
29182011-07-08 Jason Rumney <jasonr@gnu.org>
2919
22610910
JR
2920 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2921 SH_SHOW for hidden windows (Bug#5482).
2922
5df75e47
JR
2923 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2924 frame struct members of non-existent frames (Bug#6284).
2925
699c10bd
JD
29262011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2927
4393663b
JD
2928 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2929 variable firstTime not needed on OSX >= 10.6.
2930 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2931 >= 10.5. Use setKnobProportion, setDoubleValue.
2932
2933 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2934 (MAC_OS_X_VERSION_10_5): Define if not defined.
2935 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2936 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2937 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2938
2939 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2940 cString and lossyCString on OSX >= 10.4
2941
2942 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2943 sizeToFit on OSX >= 10.2.
2944
2945 * nsimage.m (allocInitFromFile): Don't use deprecated method
2946 bestRepresentationForDevice on OSX >= 10.6.
2947
2948 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2949 to avoid warning.
2950
2951 * emacs.c: Declare unexec_init_emacs_zone.
2952
a63e0781
JD
2953 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2954
699c10bd
JD
2955 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2956
2957 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2958 on svcsMenu (Bug#8842).
2959
2960 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2961 ns_return_types.
2962 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2963
2964 * nsterm.m (QUTF8_STRING): Declare.
2965 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2966 (validRequestorForSendType): Return type is (id).
2967 Change indexOfObjectIdenticalTo to indexOfObject.
2968 Check if we have local selection before returning self (Bug#8842).
2969 (writeSelectionToPasteboard): Put local selection into paste board
2970 if we have a local selection (Bug#8842).
2971 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2972
2973 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2974 (ns_get_local_selection): Declare.
2975
54e10184
LMI
29762011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2977
9888ff71
LMI
2978 * keymap.c (describe_map_tree): Don't insert a double newline at
2979 the end of the buffer (bug#1169) and return whether we inserted
2980 something.
2981
54e10184
LMI
2982 * callint.c (Fcall_interactively): Change "reading args" to
2983 "providing args" to try to clarify what it does (bug#1010).
2984
15fa4783
KH
29852011-07-07 Kenichi Handa <handa@m17n.org>
2986
2987 * composite.c (composition_compute_stop_pos): Ignore a static
2988 composition starting before CHARPOS (Bug#8915).
2989
2990 * xdisp.c (handle_composition_prop): Likewise.
2991
a8815b00
EZ
29922011-07-07 Eli Zaretskii <eliz@gnu.org>
2993
2994 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2995 (Bug#9015)
2996
ef7b981d 29972011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2998
2999 * character.h (unicode_category_t): New enum type.
3000
3001 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3002 (Qchar_code_property_table): New variable.
3003 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3004 (UNIPROP_COMPRESSED_FORM_P): New macros.
3005 (char_table_ascii): Uncompress the compressed values.
3006 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3007 Uncompress the compressed values.
ac389d0c 3008 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3009 (char_table_ref_and_range): Uncompress the compressed values.
3010 (sub_char_table_set): New arg is_uniprop. Callers changed.
3011 Uncompress the compressed values.
3012 (sub_char_table_set_range): Args changed. Callers changed.
3013 (char_table_set_range): Adjuted for the above change.
3014 (map_sub_char_table): Delete args default_val and parent. Add arg
3015 top. Give decoded values to a Lisp function.
640c8776 3016 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3017 values to a Lisp function. Gcpro more variables.
3018 (uniprop_table_uncompress)
3019 (uniprop_decode_value_run_length): New functions.
3020 (uniprop_decoder, uniprop_decoder_count): New variables.
3021 (uniprop_get_decoder, uniprop_encode_value_character)
3022 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3023 New functions.
3024 (uniprop_encoder, uniprop_encoder_count): New variables.
3025 (uniprop_get_encoder, uniprop_table)
3026 (Funicode_property_table_internal, Fget_unicode_property_internal)
3027 (Fput_unicode_property_internal): New functions.
3028 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3029 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3030 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3031 char-code-property-alist.
3032
640c8776 3033 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3034 Vunicode_category_table.
3035
640c8776 3036 * font.c (font_range): Adjust for the change of
c805dec0
KH
3037 Vunicode_category_table.
3038
76b397fb
DN
30392011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3040
3041 * m/iris4d.h: Remove file, move contents ...
3042 * s/irix6-5.h: ... here.
3043
22b4128e
PE
30442011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3045
3046 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3047 * alloc.c (mark_buffer):
3048 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3049 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3050 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3051 This isn't true in general, and it's particularly not true
3052 if Emacs is configured with --with-wide-int.
3053 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3054 New macros, used in the buffer.c change.
3055
869795d6
JD
30562011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3057
3058 * xsettings.c: Use both GConf and GSettings if both are available.
3059 (store_config_changed_event): Add comment.
3060 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3061 (store_tool_bar_style_changed): New functions.
5e617bc2 3062 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3063 (struct xsettings): Move font inside HAVE_XFT.
3064 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3065 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3066 Move inside HAVE_XFT.
640c8776 3067 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3068 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3069 also.
3070 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3071 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3072 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3073 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3074 (parse_settings): Move check for font inside HAVE_XFT.
3075 (read_settings, apply_xft_settings): Add comment.
3076 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3077 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3078 call store_font_name_changed.
3079 (xft_settings_event): Add comment.
3080 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3081 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3082 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3083 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3084 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3085 (xsettings_get_system_font, xsettings_get_system_normal_font):
3086 Add comment.
869795d6 3087
d8ed26bd
PE
30882011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3089
3090 Random fixes. E.g., (random) never returned negative values.
3091 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3092 subseconds part to the entropy, as that's a bit more random.
3093 Prefer signed to unsigned, since the signedness doesn't matter and
3094 in general we prefer signed. When given a limit, use a
3095 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3096 latter isn't right if USE_2_TAGS_FOR_INTS.
3097 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3098 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3099
cabf1cac
SM
31002011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3101
3102 * textprop.c (text_property_stickiness):
3103 Obey Vtext_property_default_nonsticky.
3104 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3105 * w32fns.c (syms_of_w32fns):
3106 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3107
6e9b2be9
PE
31082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3109
3110 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3111 This is more efficient than Ffile_directory_p and avoids a minor race.
3112
90186c68
LMI
31132011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3114
7c301272
LMI
3115 * buffer.c (Foverlay_put): Say what the return value is
3116 (bug#7835).
3117
c4f2d8d4
LMI
3118 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3119 is a directory before asking whether to use the file name
3120 (bug#7564).
ad637907
LMI
3121 (barf_or_query_if_file_exists): Make the "File is a directory"
3122 error be more correct.
c4f2d8d4 3123
90186c68
LMI
3124 * fns.c (Frequire): Remove the mention of the .gz files, since
3125 that's installation-specific, but keep the mention of
3126 `get-load-suffixes'.
3127
da64016e
PE
31282011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3131 Report string overflow if the output is too long.
3132
7d47b580
JB
31332011-07-04 Juanma Barranquero <lekktu@gmail.com>
3134
a555cb87
JB
3135 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3136 (syms_of_gnutls): Remove duplicate DEFSYM for
3137 Qgnutls_bootprop_verify_hostname_error, an error for
3138 Qgnutls_bootprop_verify_error (which is no longer used).
3139
7d47b580
JB
3140 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3141 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3142 Also (re)move comments that are misplaced or no longer relevant.
3143
1e49bfab
LMI
31442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3145
3146 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3147
1485f4c0
CY
31482011-07-03 Chong Yidong <cyd@stupidchicken.com>
3149
3150 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3151 and background color parameters if they have been changed.
3152
a9ab721e
LMI
31532011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3154
3155 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3156
cf7cff57
PE
31572011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3158
2e13213d
PE
3159 * xsettings.c (SYSTEM_FONT): Define only when used.
3160 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3161
cf7cff57
PE
3162 * keymap.c (access_keymap_1): Now static.
3163
7a8e04f7
CY
31642011-07-02 Chong Yidong <cyd@stupidchicken.com>
3165
3166 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3167 leave any prefix arg for the up event (Bug#1586).
3168
61352f62
LMI
31692011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3170
69bb1ef7
LMI
3171 * lread.c (syms_of_lread): Mention single symbols defined by
3172 `defvar' or `defconst' (bug#7154).
3173
61352f62 3174 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3175 (Frequire): Mention get-load-suffixes.
61352f62 3176
28545e04
MR
31772011-07-02 Martin Rudalics <rudalics@gmx.at>
3178
3179 * window.h (window): Remove clone_number slot.
3180 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3181 Remove.
3182 (make_parent_window, make_window, saved_window)
3183 (Fset_window_configuration, save_window_save): Don't deal with
3184 clone numbers.
3185 * buffer.c (Qclone_number): Remove declaration.
3186 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3187
3349e122
SM
31882011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3189
3190 Add multiple inheritance to keymaps.
3191 * keymap.c (Fmake_composed_keymap): New function.
3192 (Fset_keymap_parent): Simplify.
3193 (fix_submap_inheritance): Remove.
3194 (access_keymap_1): New function extracted from access_keymap to handle
3195 embedded parents and handle lists of maps.
3196 (access_keymap): Use it.
3197 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3198 (Fcopy_keymap): Handle embedded parents.
3199 (Fcommand_remapping, define_as_prefix): Simplify.
3200 (Fkey_binding): Simplify.
3201 (syms_of_keymap): Move minibuffer-local-completion-map,
3202 minibuffer-local-filename-completion-map,
3203 minibuffer-local-must-match-map, and
3204 minibuffer-local-filename-must-match-map to Elisp.
3205 (syms_of_keymap): Defsubr make-composed-keymap.
3206 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3207 (parse_menu_item): Trivial simplification.
3208
3279eb87
GM
32092011-07-01 Glenn Morris <rgm@gnu.org>
3210
3211 * Makefile.in (SETTINGS_LIBS): Fix typo.
3212
4550efdf
KI
32132011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3214
3215 * coding.c (Fencode_coding_string): Record the last coding system
3216 used, as the function doc string says (bug#8738).
3217
0949d2b6
JD
32182011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3219
3220 * xsettings.c (store_monospaced_changed): Take new font as arg and
3221 check for change against current_mono_font.
3222 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3223 (emacs_settings_constructor, emacs_settings_get_property)
3224 (emacs_settings_set_property, emacs_settings_class_init)
3225 (emacs_settings_init, gsettings_obj): Remove.
3226 (something_changedCB): New function for HAVE_GSETTINGS.
3227 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3228 with value as argument.
3229 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3230 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3231 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3232 "changed".
3233
3234 * xgselect.c: Add defined (HAVE_GSETTINGS).
3235 (xgselect_initialize): Ditto.
3236
3237 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3238 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3239 xg_select.
3240
bbc6b304
PE
32412011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * eval.c (struct backtrace): Simplify and port the data structure.
3244 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3245 signed bit field, as this assumption is not portable and it makes
3246 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3247 "char debug_on_exit : 1" as this is not portable either; instead,
3248 use the portable "unsigned int debug_on_exit : 1". Remove unused
3249 member evalargs. Remove obsolete comments about cc bombing out.
3250
9851bfc5
JD
32512011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3252
51bb811f 3253 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3254 Let HAVE_GSETTINGS override HAVE_GCONF.
3255 (store_monospaced_changed): New function.
3256 (EMACS_SETTINGS): A new type derived from GObject to handle
3257 GSettings notifications.
3258 (emacs_settings_constructor, emacs_settings_get_property)
3259 (emacs_settings_set_property, emacs_settings_class_init):
3260 New functions.
3261 (gsettings_client, gsettings_obj): New variables.
3262 (GSETTINGS_SCHEMA): New define.
3263 (something_changedCB): Call store_monospaced_changed.
3264 (init_gsettings): New function.
3265 (xsettings_initialize): Call init_gsettings.
3266 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3267 to NULL.
3268
640c8776 3269 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3270 GCONF_CFLAGS/LIBS.
3271
5386012d
MR
32722011-06-29 Martin Rudalics <rudalics@gmx.at>
3273
3274 * window.c (resize_root_window, grow_mini_window)
3275 (shrink_mini_window): Rename Qresize_root_window to
3276 Qwindow_resize_root_window and Qresize_root_window_vertically to
3277 Qwindow_resize_root_window_vertically.
3278
f13e0b08
PE
32792011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3282
94515237
JB
32832011-06-27 Juanma Barranquero <lekktu@gmail.com>
3284
3285 * makefile.w32-in: Redesign dependencies so they reflect more
3286 clearly which files are directly included by each source file,
3287 and not through other includes.
3288
e43b6e43
MR
32892011-06-27 Martin Rudalics <rudalics@gmx.at>
3290
3291 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3292 (sort_overlays, overlay_strings): When an overlay's clone number
3293 matches the window's clone number process the overlay even if
3294 the overlay's window property doesn't match the current window.
3295
d68443dc
MR
3296 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3297 (Fwindow_hchild): Rename to Fwindow_left_child.
3298 (Fwindow_next): Rename to Fwindow_next_sibling.
3299 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3300 (resize_window_check): Rename to window_resize_check.
3301 (resize_window_apply): Rename to window_resize_apply.
3302 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3303 (Fdelete_other_windows_internal, resize_frame_windows)
3304 (Fsplit_window_internal, Fdelete_window_internal)
3305 (grow_mini_window, shrink_mini_window)
3306 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3307
c7e73be5
JD
33082011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3309
3310 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3311 (emacs_fixed_set_min_size): Remove.
3312 (emacs_fixed_new): Take frame as argument.
3313
3314 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3315 (_EmacsFixedPrivate): Remove minwidth/height.
3316 Add struct frame *f.
3317 (emacs_fixed_init): Initialize priv->f.
3318 (get_parent_class, emacs_fixed_set_min_size): Remove.
3319 (emacs_fixed_new): Set priv->f to argument.
3320 (emacs_fixed_get_preferred_width)
3321 (emacs_fixed_get_preferred_height): Use min_width/height from
3322 frames size_hint to set minimum and natural (Bug#8919).
3323 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3324 and use min_width/height from frames size_hint to set
3325 min_width/height (Bug#8919).
3326
3327 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3328 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3329 Fix indentation.
c7e73be5 3330
cf99dcf8
EZ
33312011-06-26 Eli Zaretskii <eliz@gnu.org>
3332
3333 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3334 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3335 called at ZV.
3336
029529ac
CY
33372011-06-26 Chong Yidong <cyd@stupidchicken.com>
3338
3339 * process.c (wait_reading_process_output): Bypass select if
3340 waiting for a cell while ignoring keyboard input, and input is
3341 pending. Suggested by Jan Djärv (Bug#8869).
3342
7a7ef429
PE
33432011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3344
3345 Use gnulib's dup2 module instead of rolling our own.
3346 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3347
11fdef7d 33482011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3349
3350 * dispnew.c (scrolling_window): Before scrolling, turn off a
3351 mouse-highlight in the window being scrolled.
3352
cd3520a4
JB
33532011-06-24 Juanma Barranquero <lekktu@gmail.com>
3354
3355 Move DEFSYM to lisp.h and use everywhere.
3356
3357 * character.h (DEFSYM): Move declaration...
3358 * lisp.h (DEFSYM): ...here.
3359
3360 * gnutls.c:
3361 * minibuf.c:
3362 * w32menu.c:
3363 * w32proc.c:
3364 * w32select.c: Don't include character.h.
3365
3366 * alloc.c (syms_of_alloc):
3367 * buffer.c (syms_of_buffer):
3368 * bytecode.c (syms_of_bytecode):
3369 * callint.c (syms_of_callint):
3370 * casefiddle.c (syms_of_casefiddle):
3371 * casetab.c (init_casetab_once):
3372 * category.c (init_category_once, syms_of_category):
3373 * ccl.c (syms_of_ccl):
3374 * cmds.c (syms_of_cmds):
3375 * composite.c (syms_of_composite):
3376 * dbusbind.c (syms_of_dbusbind):
3377 * dired.c (syms_of_dired):
3378 * dispnew.c (syms_of_display):
3379 * doc.c (syms_of_doc):
3380 * editfns.c (syms_of_editfns):
3381 * emacs.c (syms_of_emacs):
3382 * eval.c (syms_of_eval):
3383 * fileio.c (syms_of_fileio):
3384 * fns.c (syms_of_fns):
3385 * frame.c (syms_of_frame):
3386 * fringe.c (syms_of_fringe):
3387 * insdel.c (syms_of_insdel):
3388 * keymap.c (syms_of_keymap):
3389 * lread.c (init_obarray, syms_of_lread):
3390 * macros.c (syms_of_macros):
3391 * msdos.c (syms_of_msdos):
3392 * print.c (syms_of_print):
3393 * process.c (syms_of_process):
3394 * search.c (syms_of_search):
3395 * sound.c (syms_of_sound):
3396 * syntax.c (init_syntax_once, syms_of_syntax):
3397 * terminal.c (syms_of_terminal):
3398 * textprop.c (syms_of_textprop):
3399 * undo.c (syms_of_undo):
3400 * w32.c (globals_of_w32):
3401 * window.c (syms_of_window):
3402 * xdisp.c (syms_of_xdisp):
3403 * xfaces.c (syms_of_xfaces):
3404 * xfns.c (syms_of_xfns):
3405 * xmenu.c (syms_of_xmenu):
3406 * xsettings.c (syms_of_xsettings):
3407 * xterm.c (syms_of_xterm): Use DEFSYM.
3408
4228cf16
TZ
34092011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3410
cd3520a4 3411 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3412
7fcccf1e
PE
34132011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3414
7efb4e0e
PE
3415 Integer and buffer overflow fixes (Bug#8873).
3416
ff5844ad
PE
3417 * print.c (printchar, strout): Check for string overflow.
3418 (PRINTPREPARE, printchar, strout):
3419 Don't set size unless allocation succeeds.
3420
90532f02
PE
3421 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3422 for sizes. Check for string overflow more accurately.
3423 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3424
6d84508d
PE
3425 * macros.c: Integer and buffer overflow fixes.
3426 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3427 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3428 Use ptrdiff_t, not int, for sizes.
3429 Don't increment bufsize until after realloc succeeds.
3430 Check for size-calculation overflow.
3431 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3432
437b2cb4
PE
3433 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3434
8b9ac8b4
PE
3435 * lread.c: Integer overflow fixes.
3436 (read_integer): Radix is now EMACS_INT, not int,
3437 to improve quality of diagnostics for out-of-range radices.
3438 Calculate buffer size correctly for out-of-range radices.
3439 (read1): Check for integer overflow in radices, and in
3440 read-circle numbers.
82cb60d3
PE
3441 (read_escape): Avoid int overflow.
3442 (Fload, openp, read_buffer_size, read1)
3443 (substitute_object_recurse, read_vector, read_list, map_obarray):
3444 Use ptrdiff_t, not int, for sizes.
3445 (read1): Use EMACS_INT, not int, for sizes.
20270765 3446 Check for size overflow.
8b9ac8b4 3447
7fcccf1e
PE
3448 * image.c (cache_image): Check for size arithmetic overflow.
3449
bfbbd7e7
PE
3450 * lread.c: Integer overflow issues.
3451 (saved_doc_string_size, saved_doc_string_length)
3452 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3453 Now ptrdiff_t, not int.
3454 (read1): Don't assume doc string length fits in int. Check for
3455 out-of-range doc string lengths.
3456 (read_list): Don't assume file position fits in int.
39019e54 3457 (read_escape): Check for hex character overflow.
bfbbd7e7 3458
4e323265
LL
34592011-06-22 Leo Liu <sdl.web@gmail.com>
3460
3461 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3462 Move to minibuffer.el.
3463
85fece3e
PE
34642011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3465
20b84ce9 3466 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3467 The following patches are for when GLYPH_DEBUG && !XASSERT.
3468 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3469 * dispnew.c (flush_stdout):
3470 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3471 Mark as externally visible.
3472 * dispnew.c (check_window_matrix_pointers): Now static.
3473 * dispnew.c (window_to_frame_vpos):
3474 * xfns.c (unwind_create_frame):
3475 * xterm.c (x_check_font): Remove unused local.
3476 * scroll.c (CHECK_BOUNDS):
3477 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3478 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3479 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3480 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3481 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3482 Now static.
3483 (debug_method_add): Use va_list and vsprintf rather than relying
3484 on undefined behavior with wrong number of arguments.
3485 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3486 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3487 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3488 since we're not interested in debugging glyphs with old libraries.
3489 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3490 GCC 4.6.0's static checking.
3491
0766b489
PE
34922011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3493
31fd4b32
PE
3494 Integer overflow and signedness fixes (Bug#8873).
3495 A few related buffer overrun fixes, too.
3496
b79e8648
PE
3497 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3498
0766b489
PE
3499 * dispextern.h (struct face.stipple):
3500 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3501 (x_bitmap_mask, x_allocate_bitmap_record)
3502 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3503 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3504 (x_create_bitmap_from_xpm_data):
3505 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3506 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3507 (.bitmaps_last):
3508 * xfaces.c (load_pixmap):
3509 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3510 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3511 (.bitmaps_last, struct x_output.icon_bitmap):
3512 Use ptrdiff_t, not int, for bitmap indexes.
3513 (x_allocate_bitmap_record): Check for size overflow.
3514 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3515
b081724f
PE
3516 Use ptrdiff_t, not int, for overlay counts.
3517 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3518 * editfns.c (overlays_around, get_pos_property):
3519 * textprop.c (get_char_property_and_overlay):
3520 * xdisp.c (next_overlay_change, note_mouse_highlight):
3521 * xfaces.c (face_at_buffer_position):
21514da7
PE
3522 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3523 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3524 (Fnext_overlay_change, Fprevious_overlay_change)
3525 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3526 Use ptrdiff_t, not int, for sizes.
21514da7 3527 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3528
3de73e5e
PE
3529 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3530
2606c57b
PE
3531 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3532 (x_session_initialize): Do not assume string length fits in int.
3533
aaafe47a
PE
3534 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3535 This is unlikely, but can occur if DPI is outlandish.
3536
2674ddc8 3537 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3538 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3539
28154962
PE
3540 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3541 * xrdb.c (magic_file_p, search_magic_path):
3542 Omit last arg SUFFIX; it was always 0. All callers changed.
3543 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3544
7de51af5
PE
3545 * xfont.c (xfont_match): Avoid need for strlen.
3546
25ed6cc3
PE
3547 * xfns.c: Don't assume strlen fits in int.
3548 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3549
4eab31dd
PE
3550 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3551 not unsigned long, as we prefer signed integers. All callers changed.
3552 Detect integer overflow in repeat count.
3553 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3554 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3555
171e2a58
PE
3556 * termcap.c: Don't assume sizes fit in int and never overflow.
3557 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3558 (gobble_line): Check for size-calculation overflow.
3559
ad39faca 3560 * minibuf.c (Fread_buffer):
6e5bb2dc 3561 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3562 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3563 Don't assume string length fits in int.
3564
52c61c22 3565 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3566 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3567
b5b8c9e5
PE
3568 * font.c: Don't assume string length fits in int.
3569 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3570 Use ptrdiff_t, not int.
ccd6111c
PE
3571 (font_intern_prop): Don't assume string length fits in int.
3572 Don't assume integer property fits in fixnum.
3573 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3574
882f0d81 3575 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3576 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3577 Reformulate so as not to need the command string.
3578 Invoke gzip -cd rather than gunzip, as it's more portable.
3579 (lock_info_type, lock_file_1, lock_file):
3580 Don't assume pid_t and time_t fit in unsigned long.
3581 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3582 (current_lock_owner): Prefer signed type for sizes.
3583 Use memcpy, not strncpy, where memcpy is what is really wanted.
3584 Don't assume (via atoi) that time_t and pid_t fit in int.
3585 Check for time_t and/or pid_t out of range, e.g., via a network share.
3586 Don't alloca where an auto var works fine.
3587
93f4cf88
PE
3588 * fileio.c: Fix some integer overflow issues.
3589 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3590 Don't assume string length fits in int.
3591 (directory_file_name): Don't assume string length fits in long.
3592 (make_temp_name): Don't assume pid fits in int, or that its print
3593 length is less than 20.
3594
f3e92b69
PE
3595 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3596
1bfdaf10
PE
3597 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3598
35016e9a
PE
3599 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3600
3d1e65a1
PE
3601 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3602 We prefer signed integers, even for size calculations.
3603
0b963a93
PE
3604 * emacs.c: Don't assume string length fits in 'int'.
3605 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3606 (main): Don't invoke strlen when not needed.
3607
573f4b54
PE
3608 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3609 (XD_DEBUG_MESSAGE): Don't waste a byte.
3610
989f33ba
PE
3611 * callproc.c (getenv_internal_1, getenv_internal)
3612 (Fgetenv_internal):
965d34eb
PE
3613 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3614
e4d29b33
PE
3615 * lread.c (invalid_syntax): Omit length argument.
3616 All uses changed. This doesn't fix a bug, but it simplifies the
3617 code away from its former Hollerith-constant appearance, and it's
3618 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3619 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3620
eb49b136
PE
3621 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3622 This didn't break anything, but it didn't help either.
3623 It's confusing to put a bogus integer in a place where the actual
3624 value does not matter.
9f62aeb1 3625 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3626 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3627
15375a22
PE
3628 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3629 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3630 implementation.
b61cc01c
PE
3631 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3632 We prefer signed types, and the value cannot exceed the EMACS_INT
3633 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3634 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3635 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3636 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3637
53b2623d
PE
3638 * indent.c (sane_tab_width): New function.
3639 (current_column, scan_for_column, Findent_to, position_indentation)
3640 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3641 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3642
51cab52b 3643 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3644
f2ed8a70
PE
3645 * lisp.h (lint_assume): New macro.
3646 * composite.c (composition_gstring_put_cache):
3647 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3648
abe80cc6
PE
3649 * editfns.c, insdel.c:
3650 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3651
b02c740e
PE
3652 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3653
ebc96716
PE
3654 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3655
b4e50fa0 3656 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3657 Use much-faster test for byte-length change.
311d5d7c 3658 Don't assume string byte-length fits in 'int'.
a4cf38e4 3659 Check that character arg fits in 'int'.
85461888 3660 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3661
c0c1ee9f
PE
3662 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3663
a498d7f4
PE
3664 * fns.c (concat): Catch string overflow earlier.
3665 Do not rely on integer wraparound.
3666
51cab52b
PE
3667 * dispextern.h (struct it.overlay_strings_charpos)
3668 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3669 * xdisp.c (forward_to_next_line_start)
3670 (back_to_previous_visible_line_start)
3671 (reseat_at_next_visible_line_start, next_element_from_buffer):
3672 Don't arbitrarily truncate the value of 'selective' to int.
3673
76031fad
PE
3674 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3675
5eb55db9
PE
3676 * composite.c: Don't truncate sizes to 'int'.
3677 (composition_gstring_p, composition_reseat_it)
3678 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3679 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3680 not EMACS_UINT, for indexes.
5eb55db9 3681
0703a717
PE
3682 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3683
d6202519
PE
3684 * buffer.c: Include <verify.h>.
3685 (struct sortvec.priority, struct sortstr.priority):
8961a454 3686 Now EMACS_INT, not int.
c20998a7 3687 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3688 (struct sortstr.size, record_overlay_string)
3689 (struct sortstrlist.size, struct sortlist.used):
3690 Don't truncate size to int.
3691 (record_overlay_string): Check for size-calculation overflow.
d6202519 3692 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3693
d5a19415
JM
36942011-06-22 Jim Meyering <meyering@redhat.com>
3695
029529ac 3696 Don't leak an XBM-image-sized buffer
d5a19415
JM
3697 * image.c (xbm_load): Free the image buffer after using it.
3698
a9041e6c
PE
36992011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 Port to Sun C.
3702 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3703 that Sun C diagnosed.
3704 * fns.c (secure_hash): Fix pointer signedness issue.
3705 * intervals.c (static_offset_intervals): New function.
3706 (offset_intervals): Use it.
3707
7f3f739f
LL
37082011-06-21 Leo Liu <sdl.web@gmail.com>
3709
3710 * deps.mk (fns.o):
3711 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3712 sha512.h.
3713
3714 * fns.c (secure_hash): Rename from crypto_hash_function and change
3715 the first arg to accept symbols.
5b66d427 3716 (Fsecure_hash): New primitive.
7f3f739f
LL
3717 (syms_of_fns): New symbols.
3718
76147d94
DD
37192011-06-20 Deniz Dogan <deniz@dogan.se>
3720
3721 * process.c (Fset_process_buffer): Clarify return value in
3722 docstring.
3723
7d7d0045
CY
37242011-06-18 Chong Yidong <cyd@stupidchicken.com>
3725
3726 * dispnew.c (add_window_display_history): Use BVAR.
3727
3728 * xdisp.c (debug_method_add): Use BVAR.
3729 (check_window_end, dump_glyph_matrix, dump_glyph)
3730 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3731
3732 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3733 Likewise.
3734
3735 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3736 check till after the cache is created in init_frame_faces.
3737
ff2bc410
SM
37382011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3739
3740 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3741
28177add
PE
37422011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3743
dd3482fe
PE
3744 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3745 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3746 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3747
393d71f3 3748 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3749 * fileio.c (Finsert_file_contents):
3750 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3751 Remove the old (too-loose) buffer overflow checks.
3752 They weren't needed, since make_gap checks for buffer overflow.
3753 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3754 The old code merely checked for Emacs fixnum overflow, and relied
3755 on undefined (wraparound) behavior. The new code avoids undefined
3756 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3757
2e6813b0 3758 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3759 Tune. Don't use wider integers than needed. Don't use alloca.
3760 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3761
599a9e4f
PE
3762 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3763
99561444
PE
3764 * insdel.c, lisp.h (buffer_overflow): New function.
3765 (insert_from_buffer_1, replace_range, replace_range_2):
3766 * insdel.c (make_gap_larger):
3767 * editfns.c (Finsert_char):
3768 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3769
28177add
PE
3770 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3771
e69dafad
PE
37722011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3773
a7af7fde 3774 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3775
b1c46f02
PE
3776 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3777 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3778
e69dafad
PE
3779 * fileio.c: Don't assume EMACS_INT fits in off_t.
3780 (emacs_lseek): New static function.
3781 (Finsert_file_contents, Fwrite_region): Use it.
3782 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3783
566684ea
PE
3784 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3785
e6966cd6
PE
3786 * fns.c: Don't overflow int when computing a list length.
3787 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3788 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3789 truncation on 64-bit hosts. Check for QUIT every
3790 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3791 faster and is responsive enough.
3792 (Flength): Report an error instead of overflowing an integer.
3793 (Fsafe_length): Return a float if the value is not representable
3794 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3795 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3796 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3797
dd0b0efb
PE
3798 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3799 (header_size, word_size): New constants.
3800 (allocate_vectorlike): Don't check size overflow here.
3801 (allocate_vector): Check it here instead, since this is the only
3802 caller of allocate_vectorlike that could cause overflow.
3803 Check that the new vector's length is representable as a fixnum.
3804
86fe5cfe
PE
3805 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3806 The previous code was bogus. For example, next_almost_prime (32)
3807 returned 39, which is undesirable as it is a multiple of 3; and
3808 next_almost_prime (24) returned 25, which is a multiple of 5 so
3809 why was the code bothering to check for multiples of 7?
3810
80e88859
PE
3811 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3812
4a2f0ad6
PE
3813 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3814
f66c7cf8
PE
3815 Variadic C functions now count arguments with ptrdiff_t.
3816 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3817 Back then I didn't know that the Emacs coding style prefers signed int.
3818 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3819 were being counted with int, which may truncate counts on 64-bit
3820 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3821 * lisp.h (struct Lisp_Subr.function.aMANY)
3822 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3823 Arg counts are now ptrdiff_t, not size_t.
3824 All variadic functions and their callers changed accordingly.
3825 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3826 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3827 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3828 * callint.c (Fcall_interactively): Check arg count for overflow,
3829 to avoid potential buffer overrun. Use signed char, not 'int',
3830 for 'varies' array, so that we needn't bother to check its size
3831 calculation for overflow.
3832 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3833 * eval.c (apply_lambda):
3834 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3835 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3836 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3837
a1759b76
PE
3838 * callint.c (Fcall_interactively): Don't use index var as event count.
3839
d96be9fc
PE
3840 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3841 * mem-limits.h (SIZE): Remove; no longer used.
3842
a690a978 3843 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3844
578c21e6
PE
3845 Remove unnecessary casts.
3846 * xterm.c (x_term_init):
3847 * xfns.c (x_set_border_pixel):
3848 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3849 These aren't needed now that we assume ANSI C.
3850
96f53c6c
PE
3851 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3852 It's more likely to cause problems (due to unsigned overflow)
3853 than to cure them.
3854
83c77d31
PE
3855 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3856
ee2079f1
PE
3857 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3858
6da65536
PE
3859 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3860
7147c4a4
PE
3861 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3862
193e32d9
PE
3863 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3864
e5533da6
PE
3865 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3866
9910e595
PE
3867 GLYPH_CODE_FACE returns EMACS_INT, not int.
3868 * dispextern.h (merge_faces):
3869 * xfaces.c (merge_faces):
01103c44
PE
3870 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3871 Don't assume EMACS_INT fits in int.
9910e595 3872
2638320e
PE
3873 * character.h (CHAR_VALID_P): Remove unused parameter.
3874 * fontset.c, lisp.h, xdisp.c: All uses changed.
3875
045eb8d9
PE
3876 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3877
c1f134b5
PE
3878 * fns.c (concat): Minor tuning based on overflow analysis.
3879 This doesn't fix any bugs. Use int to hold character, instead
3880 of constantly refetching from Emacs object. Use XFASTINT, not
3881 XINT, for value known to be a character. Don't bother comparing
3882 a single byte to 0400, as it's always less.
3883
395fcb93 3884 * floatfns.c (Fexpt):
327eeec8
PE
3885 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3886
abbd3d23
PE
3887 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3888 for characters.
3889
684a03ef
PE
3890 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3891
0fed43f3
PE
3892 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3893 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3894 incorrectly succeed when S was a string, because 4294967386 was
3895 truncated before it was used.
3896
8fd02eb7
PE
3897 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3898 Otherwise, an out-of-range integer could cause undefined behavior
3899 on a 64-bit host.
3900
f8c86b69
PE
3901 * composite.c: Use int, not EMACS_INT, for characters.
3902 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3903 EMACS_INT, for values that are known to be in character range.
3904 This doesn't fix any bugs but is the usual style inside Emacs and
3905 may generate better code on 32-bit machines.
3906
34206dd2
PE
3907 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3908 This is for reasons similar to the recent CHAR_STRING fix.
3909 * charset.c (Fencode_char): Check that character arg is actually
3910 a character. Pass an int to ENCODE_CHAR.
3911 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3912 wider than 'int', as a compile-time check to prevent future regressions
3913 in this area.
3914
c5958d4c 3915 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3916
3917 Make sure a 64-bit char is never passed to CHAR_STRING.
3918 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3919 by silently ignoring the top 32 bits, allowing some values
3920 that were far too large to be valid characters.
3921 * character.h: Include <verify.h>.
3922 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3923 arguments are no wider than unsigned, as a compile-time check
3924 to prevent future regressions in this area.
3925 * data.c (Faset):
01103c44 3926 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3927 (Fsubst_char_in_region):
3928 * fns.c (concat):
3929 * xdisp.c (decode_mode_spec_coding):
3930 Adjust to CHAR_STRING's new requirement.
3931 * editfns.c (Finsert_char, Fsubst_char_in_region):
3932 * fns.c (concat): Check that character args are actually
3933 characters. Without this test, these functions did the wrong
3934 thing with wildly out-of-range values on 64-bit hosts.
3935
d37ca623
PE
3936 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3937 These casts should not be needed on 32-bit hosts, either.
3938 * keyboard.c (read_char):
3939 * lread.c (Fload): Remove casts to unsigned.
3940
ea204efb
PE
3941 * lisp.h (UNSIGNED_CMP): New macro.
3942 This fixes comparison bugs on 64-bit hosts.
3943 (ASCII_CHAR_P): Use it.
3944 * casefiddle.c (casify_object):
01103c44 3945 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3946 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3947 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3948 * dispextern.h (FACE_FROM_ID):
3949 * keyboard.c (read_char): Use UNSIGNED_CMP.
3950
41cb286c
PE
3951 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3952 not to EMACS_INT, to avoid GCC warning.
3953
4a1b9832
PE
3954 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3955
55daad71
PE
3956 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3957 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3958 isn't needed on 32-bit machines.
8f95c75c 3959
01103c44
PE
3960 * buffer.c (Fgenerate_new_buffer_name):
3961 Use EMACS_INT for count, not int.
0ceccced 3962 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3963
3964 * data.c (Qcompiled_function): Now static.
3965
c6f072e7
PE
3966 * window.c (window_body_lines): Now static.
3967
20ce5912
PE
3968 * image.c (gif_load): Rename local to avoid shadowing.
3969
9c4c5f81
PE
3970 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3971 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3972 * alloc.c (make_save_value): Integer argument is now of type
3973 ptrdiff_t, not int.
3974 (mark_object): Use ptrdiff_t, not int.
3975 * lisp.h (pD): New macro.
3976 * print.c (print_object): Use it.
3977
c0c5c8ae
PE
3978 * alloc.c: Use EMACS_INT, not int, to count objects.
3979 (total_conses, total_markers, total_symbols, total_vector_size)
3980 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3981 (total_free_floats, total_floats, total_free_intervals)
3982 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3983 Now EMACS_INT, not int. All uses changed.
3984 (Fgarbage_collect): Compute overall total using a double, so that
3985 integer overflow is less likely to be a problem. Check for overflow
3986 when converting back to an integer.
5a25e253
PE
3987 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3988 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3989 These were 'int' variables that could overflow on 64-bit hosts;
3990 they were never used, so remove them instead of repairing them.
211a0b2a 3991 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3992 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3993 Previously, this ceilinged at INT_MAX, but that doesn't work on
3994 64-bit machines.
e46bb31a 3995 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3996
c78baabf 3997 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3998 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3999 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4000 when a (possibly-narrower) signed value would do just as well.
4001 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4002
c9d624c6
PE
4003 * alloc.c: Catch some string size overflows that we were missing.
4004 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4005 for convenience in STRING_BYTES_MAX.
4006 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4007 The definition here is exact; the one in lisp.h was approximate.
4008 (allocate_string_data): Check for string overflow. This catches
4009 some instances we weren't catching before. Also, it catches
4010 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4011 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4012 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4013
c9d624c6
PE
4014 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4015 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4016 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4017
353032ce
PE
4018 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4019
2bccce07
PE
4020 * alloc.c (Fmake_string): Check for out-of-range init.
4021
0ac30604
SM
40222011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4023
4024 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4025
c195f2de
JD
40262011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4027
4028 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4029 xg_get_default_scrollbar_width.
4030
4031 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4032 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4033 (style_changed_cb): Call update_theme_scrollbar_width and call
4034 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4035 all frames (Bug#8505).
4036 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4037 Call gtk_window_set_resizable if HAVE_GTK3.
4038 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4039 and height if HAVE_GTK3 (Bug#8505).
4040 (scroll_bar_width_for_theme): New variable.
4041 (update_theme_scrollbar_width): New function.
4042 (xg_get_default_scrollbar_width): Move code to
4043 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4044 (xg_initialize): Call update_theme_scrollbar_width.
4045
4046 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4047
4048 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4049
e10ac9f1
MR
40502011-06-12 Martin Rudalics <rudalics@gmx.at>
4051
4052 * frame.c (make_frame): Call other_buffer_safely instead of
4053 other_buffer.
4054
4055 * window.c (temp_output_buffer_show): Call display_buffer with
4056 second argument Vtemp_buffer_show_specifiers and reset latter
4057 immediately after the call.
4058 (Vtemp_buffer_show_specifiers): New variable.
4059 (auto_window_vscroll_p, next_screen_context_lines)
4060 (Vscroll_preserve_screen_position): Remove leading asterisks from
4061 doc-strings.
4062
2d3c217e 40632011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4064
7b7f97e8 4065 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4066 * buffer.c (Qclone_number): Remove for now, as it's unused.
4067 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4068 (record_buffer): Remove unused local.
4069 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4070 (set_frame_buffer_list): Remove; unused.
4071 * frame.h (other_visible_frames): Remove decl.
4072 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4073 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4074 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4075 if HAVE_GPM.
4076 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4077 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4078 Define only if HAVE_GPM.
4079 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4080 (update_hints_inhibit): Remove; never set. All uses removed.
4081 * widgetprv.h (emacsFrameClassRec): Remove decl.
4082 * window.c (delete_deletable_window): Now returns void, since it
4083 wasn't returning anything.
4084 (compare_window_configurations): Remove unused locals.
4085 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4086 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4087 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4088 the same widths as pointers. This follows up on the 2011-05-06 patch.
4089 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4090 * xterm.h: Likewise.
4091 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4092
1384b89e
JB
40932011-06-12 Juanma Barranquero <lekktu@gmail.com>
4094
4095 * makefile.w32-in: Update dependencies.
4096 (LISP_H): Add lib/intprops.h.
4097
1100a63c
CY
40982011-06-11 Chong Yidong <cyd@stupidchicken.com>
4099
4100 * image.c (gif_load): Add animation frame delay to the metadata.
4101 (syms_of_image): Use DEFSYM. New symbol `delay'.
4102
6198ccd0
MR
41032011-06-11 Martin Rudalics <rudalics@gmx.at>
4104
4105 * window.c (delete_deletable_window): Re-add.
4106 (Fset_window_configuration): Rewrite to handle dead buffers and
4107 consequently deletable windows.
4108 (window_tree, Fwindow_tree): Remove. Supply functionality in
4109 window.el.
4110 (compare_window_configurations): Simplify code.
4111
b6e3633c
AS
41122011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4113
1ab0dee5
AS
4114 * image.c (imagemagick_load_image): Fix type mismatch.
4115 (Fimagemagick_types): Likewise.
4116
b6e3633c
AS
4117 * window.h (replace_buffer_in_windows): Declare.
4118
9397e56f
MR
41192011-06-11 Martin Rudalics <rudalics@gmx.at>
4120
4121 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4122 Qclone_number. Remove external declaration of Qdelete_window.
4123 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4124 code.
640c8776
SM
4125 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4126 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4127 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4128 buffer list implementation.
4129 (other_buffer_safely): New function.
4130 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4131 calls to replace_buffer_in_windows and
4132 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4133 if allowed.
4134 (record_buffer): Inhibit quitting and rewrite using quittable
4135 functions. Run Qbuffer_list_update_hook if allowed.
4136 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4137 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4138 Move switch-to-buffer to window.el.
9397e56f
MR
4139 (bury-buffer): Move to window.el.
4140 (Vbuffer_list_update_hook): New variable.
4141
4142 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4143 section.
4144
4145 * window.h (resize_frame_windows): Move up in code.
4146 (Fwindow_frame): Remove EXFUN.
4147 (replace_buffer_in_all_windows): Remove prototype.
4148 (replace_buffer_in_windows_safely): Add prototype.
4149
4150 * window.c: Declare Qdelete_window static again. Move down
4151 declaration of select_count.
4152 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4153 (Fother_window): Move to window.el.
4154 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4155 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4156 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4157 window.el.
4158 (replace_buffer_in_windows): Implement by calling
4159 Qreplace_buffer_in_windows.
4160 (replace_buffer_in_all_windows): Remove with some functionality
4161 moved into replace_buffer_in_windows_safely.
4162 (replace_buffer_in_windows_safely): New function.
4163 (select_window_norecord, select_frame_norecord): Move in front
4164 of run_window_configuration_change_hook. Remove now obsolete
4165 declarations.
640c8776
SM
4166 (Fset_window_buffer): Rewrite doc-string.
4167 Call Qrecord_window_buffer.
9397e56f
MR
4168 (keys_of_window): Move binding for other-window to window.el.
4169
b50691aa
CY
41702011-06-11 Chong Yidong <cyd@stupidchicken.com>
4171
4172 * dispextern.h (struct image): Replace data member, whose int_val
4173 and ptr_val fields were not used by anything, with a single
4174 lisp_val object.
4175
4176 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4177 (gif_clear_image, gif_load, imagemagick_load_image)
4178 (gs_clear_image, gs_load): Callers changed.
4179
3f754b86
PE
41802011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4181
cca69397
PE
4182 * buffer.h: Include <time.h>, for time_t.
4183 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4184
109e28d0
PE
4185 Fix minor problems found by static checking.
4186
60737f02
PE
4187 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4188
4b66faf3
PE
4189 Make identifiers static if they are not used in other modules.
4190 * data.c (Qcompiled_function, Qframe, Qvector):
4191 * image.c (QimageMagick, Qsvg):
4192 * minibuf.c (Qmetadata):
4193 * window.c (resize_window_check, resize_root_window): Now static.
4194 * window.h (resize_window_check, resize_root_window): Remove decls.
4195
109e28d0
PE
4196 * window.c (window_deletion_count, delete_deletable_window):
4197 Remove; unused.
46a4ce9e
PE
4198 (window_body_lines): Now static.
4199 (Fdelete_other_windows_internal): Mark vars as initialized.
4200 Make sure 'resize_failed' is initialized.
4201 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4202 (resize_window_apply): Remove unused local.
4203 * window.h (delete_deletable_window): Remove decl.
4204
109e28d0 4205 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4206 (imagemagick_load_image): Fix pointer signedness problem by changing
4207 last arg from unsigned char * to char *. All uses changed.
4208 Also, fix a local for similar reasons.
4209 Remove unused locals. Remove locals to avoid shadowing.
4210 (fn_rsvg_handle_free): Remove; unused.
4211 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4212 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4213
3f754b86
PE
4214 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4215
2547adb1
CY
42162011-06-10 Chong Yidong <cyd@stupidchicken.com>
4217
4218 * image.c (gif_load): Fix omitted cast error introduced by
4219 2011-06-06 change.
4220
2c8e37d4
MR
42212011-06-10 Martin Rudalics <rudalics@gmx.at>
4222
4223 * window.h (resize_proportionally, orig_total_lines)
4224 (orig_top_line): Remove from window structure.
4225 (set_window_height, set_window_width, change_window_heights)
4226 (Fdelete_window): Remove prototypes.
4227 (resize_frame_windows): Remove duplicate declaration.
4228
440a42e3
EZ
42292011-06-10 Eli Zaretskii <eliz@gnu.org>
4230
4231 * window.h (resize_frame_windows, resize_window_check)
4232 (delete_deletable_window, resize_root_window)
4233 (resize_frame_windows): Declare prototypes.
4234
4235 * window.c (resize_window_apply): Make definition be "static" to
4236 match the prototype.
4237
562dd5e9
MR
42382011-06-10 Martin Rudalics <rudalics@gmx.at>
4239
4240 * window.c: Remove declarations of Qwindow_size_fixed,
4241 window_min_size_1, window_min_size_2, window_min_size,
4242 size_window, window_fixed_size_p, enlarge_window, delete_window.
4243 Remove static from declaration of Qdelete_window, it's
4244 temporarily needed by Fbury_buffer.
4245 (replace_window): Don't assign orig_top_line and
4246 orig_total_lines.
4247 (Fdelete_window, delete_window): Remove. Window deletion is
4248 handled by window.el.
640c8776
SM
4249 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4250 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4251 (Fdelete_other_windows): Remove. Deleting other windows is
4252 handled by window.el.
4253 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4254 handled in window.el.
4255 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4256 Window minimum sizes are handled in window.el.
4257 (shrink_windows, size_window, set_window_height)
4258 (set_window_width, change_window_heights, window_height)
4259 (window_width, CURBEG, CURSIZE, enlarge_window)
4260 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4261 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4262 handled in window.el.
4263 (make_dummy_parent): Rename to make_parent_window and give it a
4264 second argument horflag.
4265 (make_window): Don't set resize_proportionally any more.
4266 (Fsplit_window): Remove. Windows are split in window.el.
4267 (save_restore_action, save_restore_orig_size)
4268 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4269 Resize mini windows in window.el.
4270 (grow_mini_window, shrink_mini_window): Implement by calling
4271 Qresize_root_window_vertically, resize_window_check and
4272 resize_window_apply.
640c8776
SM
4273 (saved_window, Fset_window_configuration, save_window_save):
4274 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4275 resize_proportionally.
4276 (window_min_height, window_min_width): Move to window.el.
4277 (keys_of_window): Move bindings for delete-other-windows,
4278 split-window, delete-window and enlarge-window to window.el.
4279
4280 * buffer.c: Temporarily extern Qdelete_window.
4281 (Fbury_buffer): Temporarily call Qdelete_window instead of
4282 Fdelete_window (Fbury_buffer will move to window.el soon).
4283
4284 * frame.c (set_menu_bar_lines_1): Remove code handling
4285 orig_top_line and orig_total_lines.
4286
4287 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4288 set_window_height but set heights directly.
4289 (change_frame_size_1): Use resize_frame_windows.
4290
4291 * xdisp.c (init_xdisp): Don't use set_window_height but set
4292 heights directly.
4293
640c8776
SM
4294 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4295 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4296 run_window_configuration_change_hook.
4297
4298 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4299 instead of change_window_heights and run
4300 run_window_configuration_change_hook.
4301
1a13852e
MR
43022011-06-09 Martin Rudalics <rudalics@gmx.at>
4303
4304 * window.c (replace_window): Rename second argument REPLACEMENT to
4305 NEW. New third argument SETFLAG. Rewrite.
4306 (delete_window, make_dummy_parent): Call replace_window with
4307 third argument 1.
4308 (window_list_1): Move down in code.
4309 (run_window_configuration_change_hook): Move set_buffer part
4310 before select_frame_norecord part in order to unwind correctly.
4311 Rename count1 to count.
4312 (recombine_windows, delete_deletable_window, resize_root_window)
4313 (Fdelete_other_windows_internal)
4314 (Frun_window_configuration_change_hook, make_parent_window)
4315 (resize_window_check, resize_window_apply, Fresize_window_apply)
4316 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4317 (Fdelete_window_internal, Fresize_mini_window_internal):
4318 New functions.
1a13852e
MR
4319 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4320
f3d1777e
MR
43212011-06-08 Martin Rudalics <rudalics@gmx.at>
4322
496e208e
MR
4323 * window.h (window): Add some new members to window structure -
4324 normal_lines, normal_cols, new_total, new_normal, clone_number,
4325 splits, nest, prev_buffers, next_buffers.
4326 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4327 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4328
f3d1777e
MR
4329 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4330 Remove.
496e208e
MR
4331 (make_dummy_parent): Set new members of windows structure.
4332 (make_window): Move down in code. Handle new members of window
4333 structure.
4334 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4335 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4336 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4337 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4338 (Fset_window_next_buffers, Fset_window_clone_number):
4339 New functions.
496e208e
MR
4340 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4341 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4342 Doc-string fixes.
4343 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4344 Argument WINDOW can be now internal window too.
4345 (Fwindow_use_time): Move up in code.
4346 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4347 Rewrite doc-string.
4348 (Fset_window_configuration, saved_window)
4349 (Fcurrent_window_configuration, save_window_save): Handle new
4350 members of window structure.
b9e809c2
MR
4351 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4352 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4353 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4354 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4355 Qget_mru_window, Qresize_root_window,
4356 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4357 Qauto_buffer_name; staticpro them.
f3d1777e 4358
abde8f8c
MR
43592011-06-07 Martin Rudalics <rudalics@gmx.at>
4360
4361 * window.c (Fwindow_total_size, Fwindow_left_column)
4362 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4363 (Fwindow_list_1): New functions.
4364 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4365 (Fwindow_width, Fscroll_left, Fscroll_right):
4366 Use window_body_cols instead of window_box_text_cols.
4367 (delete_window, Fset_window_configuration):
4368 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4369 (delete_all_subwindows): Take a window as argument and not a
4370 structure. Rewrite.
190b47e6
MR
4371 (window_loop): Remove handling of GET_LRU_WINDOW and
4372 GET_LARGEST_WINDOW.
4373 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4374
4375 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4376 window_box_text_cols. delete_all_subwindows now takes a
4377 Lisp_Object as argument.
abde8f8c 4378
640c8776
SM
4379 * indent.c (compute_motion, Fcompute_motion):
4380 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4381
fa8a67e6
MR
4382 * frame.c (delete_frame): Call delete_all_subwindows with root
4383 window as argument.
4384
a54e3482
DC
43852011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4386
4387 * fns.c (Fputhash): Document return value.
4388
60002bf5
CY
43892011-06-06 Chong Yidong <cyd@stupidchicken.com>
4390
4391 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4392
0c671da6 43932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4394
b862a52a 4395 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4396
be44ca6c
PE
4397 Check for overflow when converting integer to cons and back.
4398 * charset.c (Fdefine_charset_internal, Fdecode_char):
4399 Use cons_to_unsigned to catch overflow.
4400 (Fencode_char): Use INTEGER_TO_CONS.
4401 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4402 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4403 * data.c (long_to_cons, cons_to_long): Remove.
4404 (cons_to_unsigned, cons_to_signed): New functions.
4405 These signal an error for invalid or out-of-range values.
4406 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4407 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4408 * font.c (Ffont_variation_glyphs):
4409 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4410 * lisp.h: Include <intprops.h>.
4411 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4412 (cons_to_signed, cons_to_unsigned): New decls.
4413 (long_to_cons, cons_to_long): Remove decls.
4414 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4415 (Fprimitive_undo): Use CONS_TO_INTEGER.
4416 * xfns.c (Fx_window_property): Likewise.
4417 * xselect.c: Include <limits.h>.
4418 (x_own_selection, selection_data_to_lisp_data):
4419 Use INTEGER_TO_CONS.
4420 (x_handle_selection_request, x_handle_selection_clear)
4421 (x_get_foreign_selection, Fx_disown_selection_internal)
4422 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4423 (lisp_data_to_selection_data): Use cons_to_unsigned.
4424 (x_fill_property_data): Use cons_to_signed.
4425 Report values out of range.
4426
d1f3d2af
PE
4427 Check for buffer and string overflow more precisely.
4428 * buffer.h (BUF_BYTES_MAX): New macro.
4429 * lisp.h (STRING_BYTES_MAX): New macro.
4430 * alloc.c (Fmake_string):
4431 * character.c (string_escape_byte8):
4432 * coding.c (coding_alloc_by_realloc):
4433 * doprnt.c (doprnt):
4434 * editfns.c (Fformat):
4435 * eval.c (verror):
4436 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4437 since they may not be the same number.
4438 * editfns.c (Finsert_char):
4439 * fileio.c (Finsert_file_contents):
4440 Likewise for BUF_BYTES_MAX.
4441
dd52fcea
PE
4442 * image.c: Use ptrdiff_t, not int, for sizes.
4443 (slurp_file): Switch from int to ptrdiff_t.
4444 All uses changed.
4445 (slurp_file): Check that file size fits in both size_t (for
4446 malloc) and ptrdiff_t (for sanity and safety).
4447
7f9bbdbb
PE
4448 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4449 if b->modtime has its maximal value.
4450
dfe18f82
PE
4451 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4452
84acfcf0
PE
4453 Don't assume time_t can fit into int.
4454 * buffer.h (struct buffer.modtime): Now time_t, not int.
4455 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4456 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4457
ccd9a01a
PE
4458 Minor fixes for signed vs unsigned integers.
4459 * character.h (MAYBE_UNIFY_CHAR):
4460 * charset.c (maybe_unify_char):
4461 * keyboard.c (read_char, reorder_modifiers):
4462 XINT -> XFASTINT, since the integer must be nonnegative.
4463 * ftfont.c (ftfont_spec_pattern):
4464 * keymap.c (access_keymap, silly_event_symbol_error):
4465 XUINT -> XFASTINT, since the integer must be nonnegative.
4466 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4467 since it makes no difference and we prefer signed.
4468 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4469 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4470 nonnegative.
4471
d6d100dd
SM
44722011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4473
4474 * window.h (Fwindow_frame): Declare.
4475
2b6148e4
PE
44762011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4479 (SPARE_MEMORY): Always define.
4480 (LARGE_REQUEST): Remove.
4481 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4482
f230ecc9
MR
44832011-06-06 Martin Rudalics <rudalics@gmx.at>
4484
727e958e
MR
4485 * lisp.h: Move EXFUNS for Fframe_root_window,
4486 Fframe_first_window and Fset_frame_selected_window to window.h.
4487
4488 * window.h: Move EXFUNS for Fframe_root_window,
4489 Fframe_first_window and Fset_frame_selected_window here from
4490 lisp.h.
4491
4492 * frame.c (Fwindow_frame, Fframe_first_window)
4493 (Fframe_root_window, Fframe_selected_window)
4494 (Fset_frame_selected_window): Move to window.c.
4495 (Factive_minibuffer_window): Move to minibuf.c.
4496 (Fother_visible_frames_p): New function.
4497
4498 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4499
f230ecc9
MR
4500 * window.c (decode_window, decode_any_window): Move up in code.
4501 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4502 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4503 (Fwindow_buffer): Move up and rewrite doc-string.
4504 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4505 (Fwindow_prev): New functions.
727e958e
MR
4506 (Fwindow_frame): Move here from frame.c. Accept any window as
4507 argument.
4508 (Fframe_root_window, Fframe_first_window)
4509 (Fframe_selected_window): Move here from frame.c. Accept frame
4510 or arbitrary window as argument. Update doc-strings.
4511 (Fminibuffer_window): Move up in code.
4512 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4513 (Fset_frame_selected_window): Move here from frame.c.
4514 Marginal rewrite.
727e958e
MR
4515 (Fselected_window, select_window, Fselect_window): Move up in
4516 code. Minor doc-string fixes.
f230ecc9 4517
4d09bcf6
PE
45182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4521 Do not assume that spare memory exists; that assumption is valid
4522 only if SYSTEM_MALLOC.
4523 (LARGE_REQUEST): New macro, so that the issue of large requests
4524 is separated from the issue of spare memory.
4525
810928a2
AS
45262011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4527
172418ad
AS
4528 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4529 format. (Bug#8806)
4530
43f862f7
AS
4531 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4532
810928a2
AS
4533 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4534 before statements.
4535
a059fe24
JD
45362011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4537
4538 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4539
4540 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4541
4542 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4543 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4544
989bf368
JB
45452011-06-05 Juanma Barranquero <lekktu@gmail.com>
4546
4547 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4548
4b80f674
CY
45492011-06-04 Chong Yidong <cyd@stupidchicken.com>
4550
4551 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4552 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4553 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4554 New error handlers.
4b80f674
CY
4555 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4556 Obey Vx_select_enable_clipboard_manager. Catch errors in
4557 x_clipboard_manager_save (Bug#8779).
4558 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4559 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4560
99a33b77 45612011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4562
4563 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4564
99a33b77 45652011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4566
4567 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4568 in the current matrix if keep_current_p is non-zero.
4569
8264569d
EZ
45702011-06-04 Eli Zaretskii <eliz@gnu.org>
4571
4572 * bidi.c (bidi_level_of_next_char): Fix last change.
4573
57f97249
EZ
45742011-06-03 Eli Zaretskii <eliz@gnu.org>
4575
fec2107c 4576 Support bidi reordering of text covered by display properties.
57f97249 4577
fec2107c
EZ
4578 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4579 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4580 (bidi_cache_search, bidi_cache_iterator_state)
4581 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4582 (bidi_level_of_next_char, bidi_move_to_visually_next):
4583 Support character positions inside a run of characters covered by a
fec2107c
EZ
4584 display string.
4585 (bidi_paragraph_init, bidi_resolve_explicit_1)
4586 (bidi_level_of_next_char): Call bidi_fetch_char and
4587 bidi_fetch_char_advance instead of FETCH_CHAR and
4588 FETCH_CHAR_ADVANCE.
4589 (bidi_init_it): Initialize new members.
4590 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4591 definitions.
4592 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4593 instead of using explicit *_CHAR codes.
d6d100dd
SM
4594 (bidi_resolve_explicit, bidi_resolve_weak):
4595 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4596 bidirectional text is supported only in multibyte buffers.
4597 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4598 it to initialize the frame_window_p member of struct bidi_it.
4599 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4600 (bidi_resolve_explicit, bidi_resolve_weak)
4601 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4602 bidi_it->nchars is non-positive.
4603 (bidi_level_of_next_char): Don't try to lookup the cache for the
4604 next/previous character if nothing is cached there yet, or if we
4605 were just reseat()'ed to a new position.
c40e2fb2 4606
0e14fe90
EZ
4607 * xdisp.c (set_cursor_from_row): Set start and stop points
4608 according to the row's direction when priming the loop that looks
4609 for the glyph on which to display cursor.
4610 (single_display_spec_intangible_p): Function deleted.
4611 (display_prop_intangible_p): Reimplement to call
4612 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4613 Accept 3 additional arguments needed by handle_display_spec.
4614 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4615 values: lists, `(when COND...)' forms, etc.
4616 (single_display_spec_string_p): Support property values that are
4617 lists with the argument STRING its top-level element.
4618 (display_prop_string_p): Fix the condition for processing a
4619 property that is a list to be consistent with handle_display_spec.
fec2107c 4620 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4621 last portion of handle_display_prop.
4622 (compute_display_string_pos): Accept additional argument
4623 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4624 value of a `display' property is a "replacing spec".
4625 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4626 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4627 the display property, but just return a value indicating whether
4628 the display property will replace the characters it covers.
4629 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4630 frame_window_p members of struct bidi_it.
d6d100dd
SM
4631 (compute_display_string_pos, compute_display_string_end):
4632 New functions.
fec2107c
EZ
4633 (push_it): Accept second argument POSITION, where pop_it should
4634 jump to continue iteration.
4635 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4636
fec2107c
EZ
4637 * keyboard.c (adjust_point_for_property): Adjust the call to
4638 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4639
4640 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4641 (bidi_init_it): Update prototypes.
4642 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4643 (compute_display_string_pos, compute_display_string_end):
4644 Declare prototypes.
fec2107c
EZ
4645 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4646 EMACS_INT.
fc6f18ce 4647
40087514 46482011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4649
57f53182
PE
4650 Malloc failure behavior now depends on size of allocation.
4651 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4652 * lisp.h: Change signatures accordingly.
4653 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4654 All callers changed. (Bug#8762)
4655
4656 * gnutls.c: Use Emacs's memory allocators.
4657 Without this change, the gnutls library would invoke malloc etc.
4658 directly, which causes problems on non-SYNC_INPUT hosts, and which
4659 runs afoul of improving memory_full behavior. (Bug#8761)
4660 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4661 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4662 xfree instead of the default malloc, realloc, free.
4663 (Fgnutls_boot): No need to check for memory allocation failure,
4664 since xmalloc does that for us.
4665
ac32cd99 4666 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4667 * category.c (hash_get_category_set):
4668 * ccl.c (ccl_driver):
4669 * charset.c (Fdefine_charset_internal):
4670 * charset.h (struct charset.hash_index):
4671 * composite.c (get_composition_id, gstring_lookup_cache)
4672 (composition_gstring_put_cache):
4673 * composite.h (struct composition.hash_index):
4674 * dispextern.h (struct image.hash):
4675 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4676 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4677 (hashfn_equal, hashfn_user_defined, make_hash_table)
4678 (maybe_resize_hash_table, hash_lookup, hash_put)
4679 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4680 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4681 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4682 * image.c (make_image, search_image_cache, lookup_image)
4683 (xpm_put_color_table_h):
4684 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4685 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4686 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4687 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4688 * alloc.c (allocate_vectorlike):
4689 Check for overflow in vector size calculations.
4690 * ccl.c (ccl_driver):
4691 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4692 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4693 need to be updated by these changes.
40087514
PE
4694 * fns.c (make_hash_table, maybe_resize_hash_table):
4695 Check for integer overflow with large hash tables.
0de4bb68
PE
4696 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4697 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4698 (SXHASH_REDUCE): New macro.
4699 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4700 Use it instead of discarding useful hash info with large hash values.
4701 (sxhash_float): New function.
4702 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4703 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4704 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4705 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4706 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4707 Adjust signatures to match updated version of code.
4708 (consing_since_gc): Now EMACS_INT, since a single hash table can
4709 use more than INT_MAX bytes.
4710
698d32e2
DN
47112011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4712
4713 Make it possible to build with GCC-4.6+ -O2 -flto.
4714
4715 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4716
fd6fa53f
SM
47172011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4718
4719 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4720 Call minibuffer-inactive-mode.
4721
864db017
JB
47222011-05-31 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4725 Update dependencies.
4726
2ad0baf4
DN
47272011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4728
4729 * data.c (init_data): Remove code for UTS, this system is not
4730 supported anymore.
4731
4fcc2638
DN
47322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4733
4734 Don't force ./temacs to start in terminal mode.
4735
4736 * frame.c (make_initial_frame): Initialize faces in all cases, not
4737 only when CANNOT_DUMP is defined.
4738 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4739
c56e0fd5
DN
47402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4741
4742 * dispnew.c (add_window_display_history): Use const for the string
4743 pointer. Remove declaration, not needed.
4744
333d54da 47452011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4746
55d4c1b2 4747 Use 'inline', not 'INLINE'.
333d54da 4748 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4749 * alloc.c, fontset.c (INLINE): Remove.
4750 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4751 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4752 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4753 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4754 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4755
738db178
DN
47562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4757
4758 Make it possible to run ./temacs.
4759
4760 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4761 syms_of_callproc does the same thing. Remove test for
4762 "initialized", do it in the caller.
4763 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4764
620c53a6
SM
47652011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4766
4767 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4768 (read_minibuf): Use get_minibuffer.
4769 (syms_of_minibuf): Use DEFSYM.
4770 (Qmetadata): New var.
4771 * data.c (Qbuffer): Don't make it static.
4772 (syms_of_data): Use DEFSYM.
4773
e003a292
PE
47742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4777 (CCL_CODE_MIN): New macro.
4778
ed008a6d
PE
47792011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4780
3687c2ef
PE
4781 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4782
ed008a6d
PE
4783 * eval.c (Qdebug): Now static.
4784 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4785 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4786 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4787
d66c4c7c
CY
47882011-05-29 Chong Yidong <cyd@stupidchicken.com>
4789
4790 * image.c: Various fixes to ImageMagick code comments.
4791 (Fimagemagick_types): Doc fix.
4792
5fbc2025
PE
47932011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4794
0196f88a
PE
4795 Minor fixes prompted by GCC 4.6.0 warnings.
4796
4797 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4798
5fbc2025
PE
4799 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4800 (x_clipboard_manager_save_all): Move extern decl to ...
4801 * xterm.h: ... here, so that it can be checked for consistency.
4802
1dd3c2d9
CY
48032011-05-29 Chong Yidong <cyd@stupidchicken.com>
4804
4805 * xselect.c (x_clipboard_manager_save_frame)
4806 (x_clipboard_manager_save_all): New functions.
4807 (Fx_clipboard_manager_save): Lisp function deleted.
4808
4809 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4810 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4811
4812 * xterm.h: Update prototype.
4813
5ba6571d
WX
48142011-05-28 William Xu <william.xwl@gmail.com>
4815
4816 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4817 exiting (Bug#8239).
4818
3eaff834
JM
48192011-05-28 Jim Meyering <meyering@redhat.com>
4820
e1900994 4821 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4822 * fns.c (to_uchar): Define.
4823 (crypto_hash_function): Use it to convert some newly-signed
4824 variables to unsigned, to avoid sign-extension bugs. For example,
4825 without this change, (md5 "truc") would evaluate to
4826 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4827 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4828 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4829
0f6990a7
PE
48302011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 Integer overflow fixes.
c8a9ca5a 4833
08686060
PE
4834 * dbusbind.c: Serial number integer overflow fixes.
4835 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4836 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4837 to hold a serial number that is too large for a fixnum.
4838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4839 Check for serial numbers out of range. Decode any serial number
59568bf0 4840 that was so large that it became a float. (Bug#8722)
08686060 4841
2d1fc3c7
PE
4842 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4843 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4844 Use XFASTINT rather than XUINT when numbers are nonnegative.
4845 (xd_append_arg, Fdbus_method_return_internal):
4846 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4847 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4848 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4849 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4850 (Bug#8722)
2d1fc3c7 4851
c8a9ca5a
PE
4852 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4853
519e1d69
PE
4854 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4855
30569699
PE
4856 ccl: add integer overflow checks
4857 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4858 (IN_INT_RANGE): New macros.
4859 (ccl_driver): Use them to check for integer overflow when
4860 decoding a CCL program. Many of the new checks are whether XINT (x)
4861 fits in int; it doesn't always, on 64-bit hosts. The new version
4862 doesn't catch all possible integer overflows, but it's an
847044ea 4863 improvement. (Bug#8719)
30569699 4864
c11285dc
PE
4865 * alloc.c (make_event_array): Use XINT, not XUINT.
4866 There's no need for unsigned here.
4867
fdccd48e
PE
4868 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4869 This follows up to the 2011-05-06 change that substituted uintptr_t
4870 for EMACS_INT. This case wasn't caught back then.
4871
37910ab2
PE
4872 Rework Fformat to avoid integer overflow issues.
4873 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4874 now (part of C89). Include <verify.h>.
4875 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4876 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4877 (Fformat): Avoid the prepass trying to compute sizes; it was only
4878 approximate and thus did not catch overflow reliably. Instead, walk
4879 through the format just once, formatting and computing sizes as we go,
4880 checking for integer overflow at every step, and allocating a larger
4881 buffer as needed. Keep track separately whether the format is
4882 multibyte. Keep only the most-recently calculated precision, rather
4883 than them all. Record whether each argument has been converted to
4884 string. Use EMACS_INT, not int, for byte and char and arg counts.
4885 Support field widths and precisions larger than INT_MAX. Avoid
4886 sprintf's undefined behavior with conversion specifications such as %#d
4887 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4888 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4889 formatting out-of-range floating point numbers with int
9173deec 4890 formats. (Bug#8668)
37910ab2 4891
2e6578fb
PE
4892 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4893
0ae6bdee
PE
4894 * data.c: Avoid integer truncation in expressions involving floats.
4895 * data.c: Include <intprops.h>.
4896 (arith_driver): When there's an integer overflow in an expression
4897 involving floating point, convert the integers to floating point
4898 so that the resulting value does not suffer from catastrophic
4899 integer truncation. For example, on a 64-bit host (* 4
4900 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4901 Do not rely on undefined behavior after integer overflow.
4902
de883a70
PE
4903 merge count_size_as_multibyte, parse_str_to_multibyte
4904 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4905 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4906 Check for integer overflow.
4907 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4908 since it's now a duplicate of the other. This is more of
4909 a character than a buffer op, so better that it's in character.c.
4910 * fns.c, print.c: Adjust to above changes.
4911
2ff916cb
PE
49122011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4913
4914 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4915
f1b54466
PE
49162011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4917
fb1ac845
PE
4918 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4919 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4920 (x_clipboard_manager_save): Now static.
4921 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4922
f1b54466
PE
4923 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4924 (crypto_hash_function): Now static.
4925 Fix pointer signedness problems. Avoid unnecessary initializations.
4926
a9f737ee
CY
49272011-05-27 Chong Yidong <cyd@stupidchicken.com>
4928
4929 * termhooks.h (Vselection_alist): Make it terminal-local.
4930
4931 * terminal.c (create_terminal): Initialize it.
4932
4933 * xselect.c: Support for clipboard managers.
4934 (Vselection_alist): Move to termhooks.h as terminal-local var.
4935 (LOCAL_SELECTION): New macro.
4936 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4937 (symbol_to_x_atom): Remove gratuitous arg.
4938 (x_handle_selection_request, lisp_data_to_selection_data)
4939 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4940 (x_own_selection, x_get_local_selection, x_convert_selection):
4941 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4942 (some_frame_on_display): Delete unused function.
4943 (Fx_own_selection_internal, Fx_get_selection_internal)
4944 (Fx_disown_selection_internal, Fx_selection_owner_p)
4945 (Fx_selection_exists_p): New optional frame arg.
4946 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4947 (x_handle_selection_clear): Don't treat other terminals with the
4948 same keyboard specially. Use the terminal-local Vselection_alist.
4949 (x_clear_frame_selections): Use Frun_hook_with_args.
4950
4951 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4952
4953 * xterm.h: Add support for those atoms.
4954
e067f0c1
CY
49552011-05-26 Chong Yidong <cyd@stupidchicken.com>
4956
4957 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4958 (converted_selections, conversion_fail_tag): New global variables.
4959 (x_selection_request_lisp_error): Free the above.
4960 (x_get_local_selection): Remove unnecessary code.
4961 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4962 of converted selections stored in converted_selections.
4963 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4964 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4965 (x_convert_selection): New function.
4966 (x_handle_selection_event): Simplify.
4967 (x_get_foreign_selection): Don't ignore incoming requests while
4968 waiting for an answer; this will fail when we implement
4969 SAVE_TARGETS, and seems unnecessary anyway.
4970 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4971 (Vx_sent_selection_functions): Doc fix.
4972
0f4aebc0
LL
49732011-05-26 Leo Liu <sdl.web@gmail.com>
4974
4975 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4976
e61124cd
YM
49772011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4978
4979 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4980
4981 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4982 for fringe update if it has periodic bitmap.
ac389d0c 4983 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4984 and fringe_bitmap_periodic_p.
4985
4986 * fringe.c (get_fringe_bitmap_data): New function.
4987 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4988 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4989 row. Mark glyph row for fringe update if periodicity changed.
4990
4991 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4992 for fringe update unless it has periodic bitmap.
4993
f16d9837
KH
49942011-05-25 Kenichi Handa <handa@m17n.org>
4995
4996 * xdisp.c (get_next_display_element): Set correct it->face_id for
4997 a static composition.
4998
e1b90ef6
LL
49992011-05-24 Leo Liu <sdl.web@gmail.com>
5000
5001 * deps.mk (fns.o):
5002 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5003
5004 * fns.c (crypto_hash_function, Fsha1): New function.
5005 (Fmd5): Use crypto_hash_function.
5006 (syms_of_fns): Add Ssha1.
5007
7400048f
PE
50082011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * gnutls.c: Remove unused macros.
5011 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5012 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5013 Remove macros that are defined and never used.
5014 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5015
abb71cf4
CY
50162011-05-22 Chong Yidong <cyd@stupidchicken.com>
5017
5018 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5019 (Fx_get_selection_internal): Minor cleanup.
5020 (Fx_own_selection_internal): Rename arguments for consistency with
5021 select.el.
5022
6307db39
PE
50232011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5026
f3d4e0a4
CY
50272011-05-22 Chong Yidong <cyd@stupidchicken.com>
5028
5029 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5030
4d8ade89
YM
50312011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5032
5033 * dispnew.c (scrolling_window): Don't exclude the case that the
5034 last enabled row in the desired matrix touches the bottom boundary.
5035
32078c8d
GM
50362011-05-21 Glenn Morris <rgm@gnu.org>
5037
5038 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5039 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5040 and add some more files.
32078c8d 5041
7285dc67
EZ
50422011-05-20 Eli Zaretskii <eliz@gnu.org>
5043
5044 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5045 report_file_error introduced by the change from 2011-05-07.
5046
89d1bd22
PE
50472011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5048
5049 * systime.h (Time): Define only if emacs is defined.
5050 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5051 where the include path doesn't have X11/X.h by default. See
5052 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5053
e23640bb 50542011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5055
5056 * composite.c (find_automatic_composition): Fix previous change.
5057
b9704ad9
GM
50582011-05-20 Glenn Morris <rgm@gnu.org>
5059
5060 * lisp.mk: New file, split from Makefile.in.
5061 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5062 (shortlisp): Remove.
5063 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5064
4a720484
GM
50652011-05-19 Glenn Morris <rgm@gnu.org>
5066
5067 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5068 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5069 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5070 (lisp): Set the order to that of loadup.el.
5071 (shortlisp): Make it a copy of $lisp.
5072 (SOME_MACHINE_LISP): Remove.
5073 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5074 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5075
a28d4396
KH
50762011-05-18 Kenichi Handa <handa@m17n.org>
5077
5078 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5079 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5080 (find_automatic_composition): Mostly rewrite for efficiency.
5081
a2b1fa8e
JB
50822011-05-18 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * makefile.w32-in: Update dependencies.
5085
8e1f5610
CS
50862011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5087
5088 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5089 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5090
7025ee00 50912011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5092
cdfa6eab
PE
5093 Fix some integer overflow issues, such as string length overflow.
5094
06d6db33
PE
5095 * insdel.c (count_size_as_multibyte): Check for string overflow.
5096
2b4560a8
PE
5097 * character.c (lisp_string_width): Check for string overflow.
5098 Use EMACS_INT, not int, for string indexes and lengths; in
5099 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5100 the resulting string length overflows an EMACS_INT; instead,
5101 report a string overflow if no precision given. When checking for
5102 precision exhaustion, use a check that cannot possibly have
5103 integer overflow. (Bug#8675)
5104 * character.h (lisp_string_width): Adjust to new signature.
5105
cb93f9be
PE
5106 * alloc.c (string_overflow): New function.
5107 (Fmake_string): Use it. This doesn't change behavior, but saves
5108 a few bytes and will simplify future changes.
5109 * character.c (string_escape_byte8): Likewise.
5110 * lisp.h (string_overflow): New decl.
5111
1a1f3366
PE
5112 Fixups, following up to the user-interface timestamp change.
5113 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5114 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5115 * msdos.c (mouse_get_pos): Likewise.
5116 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5117 * w32gui.h (Time): Define by including "systime.h" rather than by
5118 declaring it ourselves. (Bug#8664)
5119
d4e3e4d3
PE
5120 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5121 * image.c (clear_image_cache): Likewise.
5122
f6a24d19
PE
5123 * term.c (term_mouse_position): Don't assume time_t wraparound.
5124
08dc5ae6
PE
5125 Be more systematic about user-interface timestamps.
5126 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5127 and sometimes 'EMACS_UINT', to represent these timestamps.
5128 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5129 This makes the code easier to follow, and makes it easier to catch
5130 integer overflow bugs such as Bug#8664.
5131 * frame.c (Fmouse_position, Fmouse_pixel_position):
5132 Use Time, not unsigned long, for user-interface timestamps.
5133 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5134 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5135 * keyboard.h (last_event_timestamp): Likewise.
5136 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5137 * menu.h (xmenu_show): Likewise.
5138 * term.c (term_mouse_position): Likewise.
5139 * termhooks.h (struct input_event.timestamp): Likewise.
5140 (struct terminal.mouse_position_hook): Likewise.
5141 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5142 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5143 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5144 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5145 what it was before.
5146 * menu.h, termhooks.h: Include "systime.h", for Time.
5147
8e55734a
PE
5148 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5149 Don't assume that the difference between two unsigned long values
5150 can fit into an integer. At this point, we know button_down_time
5151 <= event->timestamp, so the difference must be nonnegative, so
5152 there's no need to cast the result if double-click-time is
5153 nonnegative, as it should be; check that it's nonnegative, just in
5154 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5155 apart (about 25 days). (Bug#8664)
8e55734a 5156
841f1b75 5157 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5158 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5159
3e26f69c
PE
5160 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5161 that always fit in int. Use a sentinel instead of a counter, to
5162 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5163 * frame.h (struct frame): Use int for menu_bar_items_used
5164 instead of EMACS_INT, since it always fits in int.
3e26f69c 5165
5cc152c0
PE
5166 * menu.c (grow_menu_items): Check for int overflow.
5167
d89eb65e
PE
5168 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5169
5235bd3e
PE
5170 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5171 Before, the code was not consistent. These values cannot exceed
5172 2**31 - 1 so there's no need to make them unsigned.
5173 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5174 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5175 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5176 as modifiers.
5177 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5178
bc827e23
PE
5179 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5180 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5181 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5182 presumably because the widths might not match.
5183
78eb494e
PE
5184 * window.c (size_window): Avoid needless test at loop start.
5185
04f2d78b
CB
51862011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5187
5188 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5189
d2fc7e3d 51902011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5191
5192 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5193
d2fc7e3d 51942011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5195
5196 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5197 `width' to `bar_area_x' and `bar_area_width', respectively.
5198 (x_scroll_run): Take account of fringe background extension.
5199
04f2d78b
CB
5200 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5201 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5202 `bar_area_width', respectively.
5203 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5204 background extension.
5205
79b70037
GM
52062011-05-10 Jim Meyering <meyering@redhat.com>
5207
5208 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5209
2f142cc5
JB
52102011-05-10 Juanma Barranquero <lekktu@gmail.com>
5211
5212 * image.c (Finit_image_library): Return t for built-in image types,
5213 like pbm and xbm. (Bug#8640)
5214
57679c86
AS
52152011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5216
5217 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5218
888c9e86
EZ
52192011-05-07 Eli Zaretskii <eliz@gnu.org>
5220
b0512a1d
EZ
5221 * w32console.c (Fset_screen_color): Doc fix.
5222 (Fget_screen_color): New function.
5223 (syms_of_ntterm): Defsubr it.
5224
7285dc67
EZ
5225 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5226 unlink the temporary file if Fcall_process didn't create it in the
5227 first place.
5228 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5229 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5230 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5231 cue to call_process_cleanup not to close that handle.
5232
4d3fcc8e
BK
52332011-05-07 Ben Key <bkey76@gmail.com>
5234
5235 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5236 one of two shell specific rules, either bootstrap-temacs-CMD or
5237 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5238 to the previous implementation of the bootstrap-temacs rule.
5239 The bootstrap-temacs-CMD rule is similar to the previous
5240 implementation of the bootstrap-temacs rule except that it
5241 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5242 variable.
5243
5244 These changes, along with some changes to nt/configure.bat,
5245 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5246 earlier fix to add support for --cflags and --ldflags options
5247 that include quotes so that it works whether make uses cmd or
5248 sh as the shell.
5249
b4289b64
MA
52502011-05-06 Michael Albinus <michael.albinus@gmx.de>
5251
5252 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5253 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5254 is a constant.
5255 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5256 a string. Handle both cases.
5257 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5258 (Fdbus_register_method): Use Qinvalid_function.
5259
af4c0e28
JB
52602011-05-06 Juanma Barranquero <lekktu@gmail.com>
5261
5262 * makefile.w32-in: Update dependencies.
5263 (LISP_H): Add inttypes.h and stdin.h.
5264 (PROCESS_H): Add unistd.h.
5265
c51453d9
EZ
52662011-05-06 Eli Zaretskii <eliz@gnu.org>
5267
5268 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5269 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5270
8ff0ac3c 52712011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5272
4c4b566b
PE
5273 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5274
aab2b9b5
PE
5275 * term.c (vfatal): Remove stray call to va_end.
5276 It's not needed and the C Standard doesn't allow it here anyway.
5277
c378da0b
PE
5278 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5279 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5280
288b08c7
PE
5281 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5282 bytes.
5283
e3601888
PE
5284 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5285
db6c0e74
PE
5286 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5287
dd5963ea
PE
5288 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5289
88c9450f
PE
5290 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5291
2f9442b8
PE
5292 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5293
c032b5f8
PE
5294 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5295 * charset.c (Fdefine_charset_internal): Don't initialize
5296 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5297 32-bit int (Bug#8600).
a108c10b
PE
5298
5299 * lread.c (read_integer): Be more consistent with string-to-number.
5300 Use string_to_number to do the actual conversion; this avoids
5301 rounding errors and fixes some other screwups. Without this fix,
5302 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5303 (digit_to_number): Move earlier, for benefit of read_integer.
5304 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5305 not a digit in any supported base. (Bug#8602)
a108c10b 5306
ad5f9eea
PE
5307 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5308
aec1708a
PE
5309 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5310 to match comment at start of function. This also removes a
5311 GCC warning about overflow in a 32+64-bit port.
5312
47be4ab5
PE
5313 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5314
371cac43
PE
5315 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5316 Reported by Stefan Monnier in
5317 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5318 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5319 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5320
d01a7826
PE
5321 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5322 (EMACS_UINTPTR): Likewise, with uintptr_t.
5323
7fd47d5c
PE
5324 * lisp.h: Prefer 64-bit EMACS_INT if available.
5325 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5326 on 32-bit hosts that have 64-bit int, so that they can access
5327 large files.
122b0c86
PE
5328 However, temporarily disable this change unless the temporary
5329 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5330
8727937b
PE
5331 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5332
8ac068ac
PE
5333 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5334 This removes an assumption that EMACS_INT and long are the same
5335 width as pointers. The assumption is true for Emacs porting targets
5336 now, but we want to make other targets possible.
5337 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5338 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5339 In the rest of the code, change types of integers that hold casted
5340 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5341 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5342 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5343 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5344 No need to cast type when ORing.
5345 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5346 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5347 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5348 assume EMACS_INT is the same width as char *.
5349 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5350 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5351 Remove no-longer-needed casts.
5352 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5353 (xg_tool_bar_help_callback, xg_make_tool_item):
5354 Use EMACS_INTPTR to hold an integer
5355 that will be cast to void *; this can avoid a GCC warning
5356 if EMACS_INT is not the same width as void *.
5357 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5358 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5359 (current_message_1, set_message_1):
5360 Use a local to convert to proper width without a cast.
5361 * xmenu.c (dialog_selection_callback): Likewise.
5362
ede49d71
PE
5363 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5364 Also, don't assume VALBITS / RAND_BITS is less than 5,
5365 and don't rely on undefined behavior when shifting a 1 left into
5366 the sign bit.
5367 * lisp.h (get_random): Change signature to match.
5368
2f30ecd0
PE
5369 * lread.c (hash_string): Use size_t, not int, for hash computation.
5370 Normally we prefer signed values; but hashing is special, because
5371 it's better to use unsigned division on hash table sizes so that
5372 the remainder is nonnegative. Also, size_t is the natural width
5373 for hashing into memory. The previous code used 'int', which doesn't
5374 retain enough info to hash well into very large tables.
5375 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5376
2a866e7b
PE
5377 * dbusbind.c: Don't possibly lose pointer info when converting.
5378 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5379 Use XPNTR rather than XHASH, so that the high-order bits of
5380 the pointer aren't lost when converting through void *.
5381
51639eac
PE
5382 * eval.c (Fautoload): Don't double-shift a pointer.
5383
92394119
PE
5384 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5385
dbdb9a7c
JB
53862011-05-06 Juanma Barranquero <lekktu@gmail.com>
5387
5388 * gnutls.c (DEF_GNUTLS_FN):
5389 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5390
db7a0b4f
AS
53912011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5392
5393 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5394 marker. (Bug#8610)
5395
f7ff1b0f 53962011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5397
5398 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5399 New version that can reserve upto 2GB of heap space.
5400
f7ff1b0f 54012011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5402
5403 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5404
639c109b
TZ
54052011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5406
5407 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5408 `gnutls_certificate_set_x509_key_file'.
5409
d2127135
JB
54102011-05-05 Juanma Barranquero <lekktu@gmail.com>
5411
5412 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5413 Update dependencies.
5414
e968f4f3
JB
54152011-05-04 Juanma Barranquero <lekktu@gmail.com>
5416
5417 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5418 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5419 Remove unused parameter `fildes'.
5420 * process.c (read_process_output, send_process): Don't pass it.
5421
84d358f0
JB
54222011-05-04 Juanma Barranquero <lekktu@gmail.com>
5423
5424 Fix previous change: the library cache is defined in w32.c.
5425 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5426 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5427
0898ca10
JB
54282011-05-04 Juanma Barranquero <lekktu@gmail.com>
5429
5430 Implement dynamic loading of GnuTLS on Windows.
5431
5432 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5433 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5434 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5435 Declare.
5436
5437 * gnutls.c (Qgnutls_dll): Define.
5438 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5439 (gnutls_*): Declare function pointers.
5440 (init_gnutls_functions): New function to initialize function pointers.
5441 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5442 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5443 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5444 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5445 (emacs_gnutls_write, emacs_gnutls_read)
5446 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5447 (Fgnutls_available_p): New function.
5448 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5449 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5450 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5451
5452 * image.c: Include w32.h.
5453 (Vimage_type_cache): Delete.
5454 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5455 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5456 (w32_delayed_load): Move to w32.c.
5457
5458 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5459
5460 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5461 (w32_delayed_load): Move from image.c. When loading a library, record
5462 its filename in the :loaded-from property of the library id.
5463 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5464 Initialize and staticpro them.
5465 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5466
5467 * process.c: Include lisp.h before w32.h, not after.
5468 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5469 instead of gnutls_record_check_pending.
5470
5471 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5472
ff4de4aa
TZ
54732011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5474
5475 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5476 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5477 as passed in.
5478
abe95abb
JD
54792011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5480
5481 * xterm.c (x_set_frame_alpha): Do not set property on anything
5482 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5483
e16e55d4
JB
54842011-05-02 Juanma Barranquero <lekktu@gmail.com>
5485
5486 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5487
bafcf6a5
JB
54882011-05-02 Juanma Barranquero <lekktu@gmail.com>
5489
5490 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5491 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5492 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5493 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5494 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5495 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5496 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5497 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5498 (Qgnutls_bootprop_callbacks_verify): Make static.
5499
e7a6747f
AS
55002011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5501
19ed11ba
AS
5502 * callproc.c: Indentation fixup.
5503
e7a6747f 5504 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5505 (wait_for_termination, interruptible_wait_for_termination):
5506 Move after wait_for_termination_1.
e7a6747f 5507
1ef14cb4
LMI
55082011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5509
5510 * sysdep.c (interruptible_wait_for_termination): New function
5511 which is like wait_for_termination, but allows keyboard
5512 interruptions.
5513
5514 * callproc.c (Fcall_process): Add (:file "file") as an option for
5515 the STDOUT buffer.
5516 (Fcall_process_region): Ditto.
5517
330d880c
EZ
55182011-04-30 Eli Zaretskii <eliz@gnu.org>
5519
8db90b73
EZ
5520 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5521 rather than `XVECTOR (FOO)->size'.
5522
330d880c
EZ
5523 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5524 inttypes.h, as a gnulib replacement is used if it not available in
5525 system headers.
5526
15cbd324
EZ
55272011-04-21 Eli Zaretskii <eliz@gnu.org>
5528
5529 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5530 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5531 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5532
5533 * coding.c (coding_alloc_by_realloc): Error out if destination
5534 will grow beyond MOST_POSITIVE_FIXNUM.
5535 (decode_coding_emacs_mule): Abort if there isn't enough place in
5536 charbuf for the composition carryover bytes. Reserve an extra
5537 space for up to 2 characters produced in a loop.
5538 (decode_coding_iso_2022): Abort if there isn't enough place in
5539 charbuf for the composition carryover bytes.
5540
55412011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5542
ae940cca
EZ
5543 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5544 aborting when %lld or %lll format is passed.
5545 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5546 %llo or %llx format is passed. (Bug#8545)
5547
03ab8921
EZ
5548 * window.c (window_scroll_line_based): Use a marker instead of
5549 simple variables to record original value of point. (Bug#7952)
5550
afda1437
EZ
5551 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5552 produced by %s or %c overflows available buffer space. (Bug#8545)
5553
f76dee0c
PE
55542011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5555
5556 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5557 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5558
fdc5744d
JB
55592011-04-28 Juanma Barranquero <lekktu@gmail.com>
5560
5561 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5562
638f053a
JB
55632011-04-28 Juanma Barranquero <lekktu@gmail.com>
5564
5565 * keyboard.c (Qdelayed_warnings_hook): Define.
5566 (command_loop_1): Run `delayed-warnings-hook'
5567 if Vdelayed_warnings_list is non-nil.
5568 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5569 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5570
d178f871
EZ
55712011-04-28 Eli Zaretskii <eliz@gnu.org>
5572
5573 * doprnt.c (doprnt): Don't return value smaller than the buffer
5574 size if the message was truncated. (Bug#8545).
5575
b124fd93
JB
55762011-04-28 Juanma Barranquero <lekktu@gmail.com>
5577
5578 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5579 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5580
e810457d
PE
55812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5582
5583 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5584
ea51cceb
JB
55852011-04-27 Juanma Barranquero <lekktu@gmail.com>
5586
5587 * makefile.w32-in: Update dependencies.
5588
94dcfacf
EZ
55892011-04-27 Eli Zaretskii <eliz@gnu.org>
5590
5591 Improve `doprnt' and its usage. (Bug#8545)
5592 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5593 `format_end'. Remove support for %l as a conversion specifier.
5594 Don't use xrealloc. Improve diagnostics when the %l size modifier
5595 is used. Update the commentary.
5596
5597 * eval.c (verror): Simplify calculation of size_t.
5598
5599 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5600 messages.
5601
f61f41d7
PE
56022011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5603
5604 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5605 change.
5606
96fb4434
PE
56072011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5608
5609 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5610 This makes this file independent of the recent pseudovector change.
5611
671875da 56122011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5613
69e9b5a3
PE
5614 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5615
b5f869a7 5616 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5617 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5618 Remove unused local.
c8926152 5619 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5620
841a1577 5621 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5622 GCC 4.6.0 optimizes based on type-based alias analysis.
5623 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5624 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5625 != &v->size, and therefore "v->size = 1; b->size = 2; return
5626 v->size;" must therefore return 1. This assumption is incorrect
5627 for Emacs, since it type-puns struct Lisp_Vector * with many other
5628 types. To fix this problem, this patch adds a new type struct
f904488f 5629 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5630 and pseudovectors, and helps optimizing compilers not get fooled
5631 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5632 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5633 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5634 the size member.
eab3844f
PE
5635 (XSETPVECTYPE): Rewrite in terms of new macro.
5636 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5637 This is a bit clearer, and further avoids the possibility of
5638 undesirable aliasing.
5639 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5640 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5641 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5642 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5643 (ASIZE): Now uses header.size rather than size.
5644 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5645 to avoid the hassle of writing XVECTOR (foo)->header.size.
5646 (struct vectorlike_header): New type.
eab3844f
PE
5647 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5648 object, to help avoid aliasing.
5649 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5650 (SUBRP): Likewise, since Lisp_Subr is a special case.
5651 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5652 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5653 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5654 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5655 changed to be "header.size" and "header.next".
5656 * buffer.h (struct buffer): Likewise.
5657 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5658 * frame.h (struct frame): Likewise.
5659 * process.h (struct Lisp_Process): Likewise.
5660 * termhooks.h (struct terminal): Likewise.
5661 * window.c (struct save_window_data, struct saved_window): Likewise.
5662 * window.h (struct window): Likewise.
5663 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5664 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5665 * buffer.c (init_buffer_once): Likewise.
5666 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5667 special case.
5668 * process.c (Fformat_network_address): Use local var for size,
5669 for brevity.
5670
0df1eac5
PE
5671 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5672
847ab9d1 5673 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5674 * data.c (atof): Remove decl; no longer used or needed.
5675 (digit_to_number): Move to lread.c.
5676 (Fstring_to_number): Use new string_to_number function, to be
5677 consistent with how the Lisp reader treats infinities and NaNs.
5678 Do not assume that floating-point numbers represent EMACS_INT
5679 without losing information; this is not true on most 64-bit hosts.
5680 Avoid double-rounding errors, by insisting on integers when
5681 parsing non-base-10 numbers, as the documentation specifies.
5682 * lisp.h (string_to_number): New decl, replacing ...
5683 (isfloat_string): Remove.
bc0a5c13 5684 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5685 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5686 appears to have been a coding error. Similarly, do not accept
5687 strings like +-1e0 as floating point numbers. Do not report
5688 overflow for integer overflows unless the base is not 10 which
5689 means we have no simple and reliable way to continue.
5690 Break out the floating-point parsing into a new
5691 function string_to_number, so that Fstring_to_number parses
5692 floating point numbers consistently with the Lisp reader.
04f2d78b 5693 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5694 (E_CHAR, EXP_INT): Remove, replacing with ...
5695 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5696 (string_to_number): New function, replacing isfloat_string.
5697 This function checks for valid syntax and produces the resulting
5698 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5699 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5700 so that overflow for non-base-10 numbers is reported only when
5701 there's no portable and simple way to convert to floating point.
452f4150 5702
67769ffc
PE
5703 * textprop.c (set_text_properties_1): Rewrite for clarity,
5704 and to avoid GCC warning about integer overflow.
5705
c20db43f
PE
5706 * intervals.h (struct interval): Use EMACS_INT for members
5707 where EMACS_UINT might cause problems. See
5708 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5709 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5710 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5711 All uses changed.
37aa2f85
PE
5712 (offset_intervals): Tell GCC not to worry about length overflow
5713 when negating a negative length.
c20db43f 5714
2538aa2f
PE
5715 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5716 (overrun_check_free): Likewise.
5717
f2d3008d
PE
5718 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5719 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5720 word size.
5721
ec8df744
PE
5722 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5723 (gnutls_make_error): Rename local to avoid shadowing.
5724 (gnutls_emacs_global_deinit): ifdef out; not used.
5725 (Fgnutls_boot): Use const for pointer to readonly storage.
5726 Comment out unused local. Fix pointer signedness problems.
5727
640ee02d
PE
5728 * lread.c (openp): Don't stuff size_t into an 'int'.
5729 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5730 about possible signed overflow.
5731
6048fb2a
PE
5732 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5733 (GDK_KEY_g): Don't define if already defined.
5734 (xg_prepare_tooltip): Avoid pointer signedness problem.
5735 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5736
fa3c87e1
PE
5737 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5738 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5739
2172544b
PE
5740 * xfns.c (Fx_window_property): Simplify a bit,
5741 to make a bit faster and to avoid GCC 4.6.0 warning.
5742 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5743
9b821a21
PE
5744 * fns.c (internal_equal): Don't assume size_t fits in int.
5745
3c616cfa
PE
5746 * alloc.c (compact_small_strings): Tighten assertion a little.
5747
c2982e87
PE
5748 Replace pEd with more-general pI, and fix some printf arg casts.
5749 * lisp.h (pI): New macro, generalizing old pEd macro to other
5750 conversion specifiers. For example, use "...%"pI"d..." rather
5751 than "...%"pEd"...".
5752 (pEd): Remove. All uses replaced with similar uses of pI.
5753 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5754 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5755 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5756 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5757 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5758 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5759 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5760 64-bit hosts.
5761 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5762 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5763 * print.c (safe_debug_print, print_object): Likewise.
5764 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5765 to int.
6f04d126
PE
5766 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5767 avoiding the 0 flag, which is not portable.
c2982e87
PE
5768 * process.c (Fmake_network_process): Use pI to avoid cast.
5769 * region-cache.c (pp_cache): Likewise.
5770 * xdisp.c (decode_mode_spec): Likewise.
5771 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5772 behavior on 64-bit hosts with printf arg.
6f04d126 5773 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5774 (x_stop_queuing_selection_requests): Likewise.
5775 (x_get_window_property): Don't truncate byte count to an 'int'
5776 when tracing.
0b432f21 5777
5e073ec7
PE
5778 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5779 here, since it parses constructs like leading '-' and spaces,
5780 which are not wanted; and it overflows with large numbers.
5781 Instead, simply match F[0-9]+, which is what is wanted anyway.
5782
36372bf9
PE
5783 * alloc.c: Remove unportable assumptions about struct layout.
5784 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5785 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5786 (allocate_vectorlike, make_pure_vector): Use the new macros,
5787 plus offsetof, to remove unportable assumptions about struct layout.
5788 These assumptions hold on all porting targets that I know of, but
5789 they are not guaranteed, they're easy to remove, and removing them
5790 makes further changes easier.
5791
0b432f21
PE
5792 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5793 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5794 (string_overrun_cookie): Now const. Use initializers that
5795 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5796 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5797 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5798 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5799 multiple of sizeof (EMACS_INT); it need not be, if
5800 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5801 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5802
895009e1
JB
58032011-04-26 Juanma Barranquero <lekktu@gmail.com>
5804
5805 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5806
6a7a1b0b
TZ
58072011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5808
5809 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5810 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5811 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5812
841a1577 58132011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5814
5815 * lisp.h (Qdebug): List symbol.
895009e1 5816 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5817 * keyboard.c (debug-on-event): New variable.
5818 (handle_user_signal): Break into debugger when debug-on-event
5819 matches the current signal symbol.
5820
f2d3ba6f
DN
58212011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5822
5823 * alloc.c (check_sblock, check_string_bytes)
5824 (check_string_free_list): Convert to standard C.
5825
42ce4c63
TZ
58262011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5827
5828 * w32.c (emacs_gnutls_push): Fix typo.
5829
825cd63c
EZ
58302011-04-25 Eli Zaretskii <eliz@gnu.org>
5831
fb11d64d
EZ
5832 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5833 "cast to pointer from integer of different size".
5834
825cd63c
EZ
5835 Improve doprnt and its use in verror. (Bug#8545)
5836 * doprnt.c (doprnt): Document the set of format control sequences
5837 supported by the function. Use SAFE_ALLOCA instead of always
5838 using `alloca'.
5839
5840 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5841 is one byte too soon. Don't use xrealloc; instead xfree and
5842 xmalloc anew.
5843
e061a11b
TZ
58442011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5845
5846 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5847 callbacks stage.
5848
5849 * gnutls.c: Renamed global_initialized to
5850 gnutls_global_initialized. Added internals for the
5851 :verify-hostname-error, :verify-error, and :verify-flags
5852 parameters of `gnutls-boot' and documented those parameters in the
5853 docstring. Start callback support.
9173deec
JB
5854 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5855 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5856 on error. Return error code.
e061a11b
TZ
5857 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5858 (emacs_gnutls_read): Likewise.
5859 (Fgnutls_boot): Return handshake error code.
5860 (emacs_gnutls_handle_error): New function.
5861 (wsaerror_to_errno): Likewise.
5862
5863 * w32.h (emacs_gnutls_pull): Add prototype.
5864 (emacs_gnutls_push): Likewise.
5865
5866 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5867 (emacs_gnutls_push): Likewise.
5868
58692011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5870
5871 * process.c (wait_reading_process_output): Check if GnuTLS
5872 buffered some data internally if no FDs are set for TLS
5873 connections.
5874
5875 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5876 (LIBS): Link to USER_LIBS.
5877 ($(BLD)/gnutls.$(0)): New target.
5878
fa6996bc
EZ
58792011-04-24 Eli Zaretskii <eliz@gnu.org>
5880
eb35682e
EZ
5881 * xdisp.c (handle_single_display_spec): Rename the
5882 display_replaced_before_p argument into display_replaced_p, to
5883 make it consistent with the commentary. Fix typos in the
5884 commentary.
5885
e2ad650c
EZ
5886 * textprop.c (syms_of_textprop): Remove dead code.
5887 (copy_text_properties): Delete obsolete commentary about an
5888 interface that was deleted long ago. Fix typos in the description
5889 of arguments.
5890
1b2de274
EZ
5891 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5892 to changes in oldXMenu/XMenu.h from 2011-04-16.
5893 <menu_help_message, prev_menu_help_message>: Constify.
5894 (IT_menu_make_room): menu->help_text is now `const char **';
5895 adjust.
5896
5897 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5898 to changes in oldXMenu/XMenu.h from 2011-04-16.
5899 (struct XMenu): Declare `help_text' `const char **'.
5900
5901 * xfaces.c <Qunspecified>: Make extern again.
5902
5903 * syntax.c: Include sys/types.h before including regex.h, as
5904 required by Posix.
5905
762b15be
EZ
5906 * doc.c (get_doc_string): Improve the format passed to `error'.
5907
5908 * doprnt.c (doprnt): Improve commentary.
5909
5910 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5911
5912 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5913 them with etags.
5914
f1052e5d
EZ
5915 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5916 changes in globals.h immediately force recompilation.
762b15be
EZ
5917 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5918 $(CURDIR)/s/ms-w32.h.
5919 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5920
fa6996bc
EZ
5921 * character.c (Fchar_direction): Function deleted.
5922 (syms_of_character): Don't defsubr it.
5923 <char-direction-table>: Deleted.
5924
e6c3da20
EZ
59252011-04-23 Eli Zaretskii <eliz@gnu.org>
5926
5927 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5928 * doprnt.c: Include limits.h.
5929 (SIZE_MAX): New macro.
04f2d78b
CB
5930 (doprnt): Return a size_t value. 2nd arg is now size_t.
5931 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5932 Improve overflow protection. Support `l' modifier for integer
5933 conversions. Support %l conversion. Don't assume an EMACS_INT
5934 argument for integer conversions and for %c.
5935
5936 * lisp.h (doprnt): Restore prototype.
5937
5938 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5939 $(SRC)/character.h.
5940
5941 * Makefile.in (base_obj): Add back doprnt.o.
5942
5943 * deps.mk (doprnt.o): Add back prerequisites.
5944 (callint.o): Depend on character.h.
5945
5946 * eval.c (internal_lisp_condition_case): Include the handler
5947 representation in the error message.
5948 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5949 when breaking from the loop.
5950
5951 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5952
5953 * callint.c (Fcall_interactively): When displaying error message
5954 about invalid control letter, pass the character's codepoint, not
5955 a pointer to its multibyte form. Improve display of the character
5956 in octal and display also its hex code.
5957
5958 * character.c (char_string): Use %x to display the (unsigned)
5959 codepoint of an invalid character, to avoid displaying a bogus
5960 negative value.
5961
5962 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5963 `error', not SYMBOL_NAME itself.
5964
5965 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5966 character arguments to `error'.
5967
5968 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5969 to `error' in error message about FINAL_CHAR argument. Make sure
5970 FINAL_CHAR is a character, and use %c when it is passed as
5971 argument to `error'.
5972
4ffd0d6b 59732011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5974
5975 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5976
5977 * w32.c: Include <time.h>.
5978 (sys_localtime): New function.
5979
4ffd0d6b 59802011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5981
5982 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5983
4ffd0d6b 5984 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5985
4ffd0d6b 59862011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5987
4ffd0d6b
GM
5988 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5989 zombies (Bug#8467).
aac0c6e3 5990
04c56954
EZ
59912011-04-19 Eli Zaretskii <eliz@gnu.org>
5992
5993 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5994 gl_state.e_property when gl_state.object is Qt.
5995
5996 * insdel.c (make_gap_larger): Remove limitation of buffer size
5997 to <= INT_MAX.
5998
16a43933
CY
59992011-04-18 Chong Yidong <cyd@stupidchicken.com>
6000
6001 * xdisp.c (lookup_glyphless_char_display)
6002 (produce_glyphless_glyph): Handle cons cell entry in
6003 glyphless-char-display.
6004 (Vglyphless_char_display): Document it.
6005
6006 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6007 glyphless-char-display.
6008
4581706e
CY
60092011-04-17 Chong Yidong <cyd@stupidchicken.com>
6010
6011 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6012
6013 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6014
6015 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6016 definition for no-X builds.
6017
4887c6e2 60182011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6019
fd35b6f9
PE
6020 Static checks with GCC 4.6.0 and non-default toolkits.
6021
5c1ccb01
PE
6022 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6023
006c5daa
PE
6024 * process.c (keyboard_bit_set): Define only if SIGIO.
6025 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6026 (send_process): Repair possible setjmp clobbering.
6027
efc736d3
PE
6028 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6029
4e2fe2e6
PE
6030 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6031
f97334a2
PE
6032 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6033
4e75f29d
PE
6034 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6035 Define only if needed.
6036
90efadd1
PE
6037 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6038 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6039 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6040
3c647824
PE
6041 * dispextern.h (struct redisplay_interface): Rename param
6042 to avoid shadowing.
e264f262 6043 * termhooks.h (struct terminal): Likewise.
761383f4 6044 * xterm.c (xembed_send_message): Likewise.
3c647824 6045
b58c5c4a
PE
6046 * insdel.c (make_gap_smaller): Define only if
6047 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6048
cad59032
PE
6049 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6050 it.
6051
c339dc2e
PE
6052 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6053 so that we aren't warned about unused symbols.
6054
91a3e27b
PE
6055 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6056
399c71d3 6057 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6058
8ffc96f5
PE
6059 * xfns.c (x_real_positions): Mark locals as initialized.
6060
eef9bc79
PE
6061 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6062
098db9dd
PE
6063 * xterm.c: Fix problems found by static analysis with other toolkits.
6064 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6065 (x_dispatch_event): Declare static if USE_GTK, and
6066 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6067 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6068 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6069 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6070 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6071
eb18f6cc
PE
6072 * xmenu.c (menu_help_callback): Pointer type fixes.
6073 Use const pointers when pointing at readonly data. Avoid pointer
6074 signedness clashes.
6075 (FALSE): Remove unused macro.
6076 (update_frame_menubar): Remove unused decl.
6077
1fe72bf8
PE
6078 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6079
60d9e1db
PE
6080 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6081 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6082 (single_menu_item): Rename local to avoid shadowing.
6083
39261c26
PE
6084 * keyboard.c (make_lispy_event): Remove unused local var.
6085
018c5e19
PE
6086 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6087 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6088
63d2b86e
PE
6089 * bitmaps: Change bitmaps from unsigned char back to the X11
6090 compatible char. Avoid the old compiler warnings about
6091 out-of-range initializers by using, for example, '\xab' rather
6092 than 0xab.
6093
aefd87e1
PE
6094 * xgselect.c (xgselect_initialize): Check vs interface
6095 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6096
bf501fb9
PE
6097 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6098
e9829fdf
PE
6099 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6100 to read-only memory.
6101
1086c095
PE
6102 * fns.c (vector): Remove; this old hack is no longer needed.
6103
2baccd04 6104 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6105 Remove unused var.
dde42981 6106 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6107
72391843 6108 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6109
436c16df 6110 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6111 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6112 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6113
92bb796d 6114 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6115 (x_term_init): Remove local to avoid shadowing.
92bb796d 6116
764430a3 6117 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6118
6119 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6120 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6121
d1dfb56c
EZ
61222011-04-16 Eli Zaretskii <eliz@gnu.org>
6123
c4354cb4
EZ
6124 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6125
d1dfb56c
EZ
6126 Fix regex.c, syntax.c and friends for buffers > 2GB.
6127 * syntax.h (struct gl_state_s): Declare character position members
6128 EMACS_INT.
6129
6130 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6131
04f2d78b
CB
6132 * textprop.c (verify_interval_modification, interval_of):
6133 Declare arguments EMACS_INT.
d1dfb56c
EZ
6134
6135 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6136 EMACS_INT.
6137
6138 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6139
6140 * indent.c (Fvertical_motion): Local variable it_start is now
6141 EMACS_INT.
6142
6143 * regex.c (re_match, re_match_2, re_match_2_internal)
6144 (bcmp_translate, regcomp, regexec, print_double_string)
6145 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6146 (re_compile_pattern, re_exec): Declare arguments and local
6147 variables `size_t' and `ssize_t' and return values `regoff_t', as
6148 appropriate.
6149 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6150 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6151 <compile_stack_type>: `size' and `avail' are now `size_t'.
6152
6153 * regex.h <regoff_t>: Use ssize_t, not int.
6154 (re_search, re_search_2, re_match, re_match_2): Arguments that
6155 specify buffer/string position and length are now ssize_t and
6156 size_t. Return type is regoff_t.
6157
613052cd
BK
61582011-04-16 Ben Key <bkey76@gmail.com>
6159
6160 * nsfont.m: Fixed bugs in ns_get_family and
6161 ns_descriptor_to_entity that were caused by using free to
6162 deallocate memory blocks that were allocated by xmalloc (via
6163 xstrdup). This caused Emacs to crash when compiled with
6164 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6165 --enable-checking=xmallocoverrun). xfree is now used to
6166 deallocate these memory blocks.
6167
4170f62f 61682011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6169
71b41406
PE
6170 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6171
9587a89d
PE
6172 emacs_write: Accept and return EMACS_INT for sizes.
6173 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6174 et seq.
6175 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6176 Accept and return EMACS_INT.
6177 (emacs_gnutls_write): Return the number of bytes written on
6178 partial writes.
6179 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6180 (emacs_read, emacs_write): Remove check for negative size, as the
6181 Emacs source code has been audited now.
9587a89d
PE
6182 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6183 (emacs_read, emacs_write): Use it.
273a5f82
PE
6184 * process.c (send_process): Adjust to the new signatures of
6185 emacs_write and emacs_gnutls_write. Do not attempt to store
6186 a byte offset into an 'int'; it might overflow.
9587a89d 6187 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6188
3e047f51
PE
6189 * sound.c: Don't assume sizes fit in 'int'.
6190 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6191 Return EMACS_INT, not int.
3e047f51 6192 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6193 Accept EMACS_INT, not int.
6194 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6195 record read return values.
6196
cc39a9db
BK
61972011-04-15 Ben Key <bkey76@gmail.com>
6198
c9d0ec6d
JB
6199 * keyboard.c (Qundefined): Don't declare static since it is used
6200 in nsfns.m.
6201 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6202 static since they are used in nsfont.m.
cc39a9db 6203
6c60eb9f
SM
62042011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6205
6206 * process.c (Qprocessp): Don't declare static.
6207 * lisp.h (Qprocessp): Declare again.
6208
7990b61a
JB
62092011-04-15 Juanma Barranquero <lekktu@gmail.com>
6210
6211 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6212
5d4cb038
PE
62132011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6214
8bd7b830 6215 Improve C-level modularity by making more things 'static'.
cd64ea1d 6216
e3b27b31
PE
6217 Don't publish debugger-only interfaces to other modules.
6218 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6219 (verify_bytepos, count_markers): Move decls to the only modules
6220 that need them.
6221 * region-cache.h (pp_cache): Likewise.
6222 * window.h (check_all_windows): Likewise.
6223 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6224
5d4cb038
PE
6225 * sysdep.c (croak): Now static, if
6226 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6227 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6228
6229 * alloc.c (refill_memory_reserve): Now static if
6230 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6231 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6232
e87b6180
PE
6233 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6234 Define only if USE_LUCID.
6235
ac64929e
PE
6236 * xrdb.c (x_customization_string, x_rm_string): Now static.
6237
6f37259d
PE
6238 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6239 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6240
1683e3ab
PE
6241 * xdisp.c (draw_row_with_mouse_face): Now static.
6242 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6243
de9c2632
PE
6244 * window.h (check_all_windows): Mark externally visible.
6245
2b96acb7
PE
6246 * window.c (window_deletion_count): Now static.
6247
6248 * undo.c: Make symbols static if they're not exported.
6249 (last_undo_buffer, last_boundary_position, pending_boundary):
6250 Now static.
6251
50436f33
PE
6252 * textprop.c (interval_insert_behind_hooks): Now static.
6253 (interval_insert_in_front_hooks): Likewise.
6254
64520e5c
PE
6255 * term.c: Make symbols static if they're not exported.
6256 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6257 (max_frame_lines, tty_set_terminal_modes):
6258 (tty_reset_terminal_modes, tty_turn_off_highlight):
6259 (get_tty_terminal): Now static.
6260 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6261 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6262 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6263 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6264 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6265
1fa53021
PE
6266 * sysdep.c: Make symbols static if they're not exported.
6267 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6268 Now static.
6269 (sigprocmask_set, full_mask): Remove; unused.
6270 (wait_debugging): Mark as visible.
6271 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6272 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6273
d4b43b22
PE
6274 * syntax.c (syntax_temp): Define only if !__GNUC__.
6275
b7c513d0
PE
6276 * sound.c (current_sound_device, current_sound): Now static.
6277
989b29ad
PE
6278 * search.c (searchbufs, searchbuf_head): Now static.
6279
13a55a78
PE
6280 * scroll.c (scroll_cost): Remove; unused.
6281 * dispextern.h (scroll_cost): Remove decl.
6282
de68a1fc
PE
6283 * region-cache.h (pp_cache): Mark as externally visible.
6284
40ccffa6
PE
6285 * process.c: Make symbols static if they're not exported.
6286 (process_tick, update_tick, create_process, chan_process):
6287 (Vprocess_alist, proc_buffered_char, datagram_access):
6288 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6289 (deactivate_process): Mark defn as static, as well as decl.
6290 * lisp.h (create_process): Remove decl.
6291 * process.h (chan_process, Vprocess_alist): Remove decls.
6292
ad64fc97
PE
6293 * print.c: Make symbols static if they're not exported.
6294 (print_depth, new_backquote_output, being_printed, print_buffer):
6295 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6296 (print_interval, print_number_index, initial_stderr_stream):
6297 Now static.
6298 * lisp.h (Fprinc): Remove decl.
6299 (debug_output_compilation_hack): Mark as externally visible.
6300
adddb265
PE
6301 * sysdep.c (croak): Move decl from here to syssignal.h.
6302 * syssignal.h (croak): Put it here, so the API can be checked when
6303 'croak' is called from dissociate_if_controlling_tty.
6304
1717ede2
PE
6305 * minibuf.c: Make symbols static if they're not exported.
6306 (minibuf_save_list, choose_minibuf_frame): Now static.
6307 * lisp.h (choose_minibuf_frame): Remove decl.
6308
fa5fb2bc
PE
6309 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6310
1e3890d1
PE
6311 * lread.c: Make symbols static if they're not exported.
6312 (read_objects, initial_obarray, oblookup_last_bucket_number):
6313 Now static.
6314 (make_symbol): Remove; unused.
6315 * lisp.h (initial_obarray, make_symbol): Remove decls.
6316
8a1414fa
PE
6317 * keyboard.c: Make symbols static if they're not exported.
6318 (single_kboard, recent_keys_index, total_keys, recent_keys):
6319 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6320 (this_single_command_key_start, echoing, last_auto_save):
6321 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6322 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6323 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6324 (Vlispy_mouse_stem, double_click_count):
6325 Now static.
6326 (force_auto_save_soon): Define only if SIGDANGER.
6327 (ignore_mouse_drag_p): Now static if
6328 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6329 (print_help): Remove; unused.
6330 (stop_character, last_timer_event): Mark as externally visible.
6331 * keyboard.h (ignore_mouse_drag_p): Declare only if
6332 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6333 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6334 * lisp.h (echoing): Remove decl.
6335 (force_auto_save_soon): Declare only if SIGDANGER.
6336 * xdisp.c (redisplay_window): Simplify code, to make it more
6337 obvious that ignore_mouse_drag_p is not accessed if !defined
6338 USE_GTK && !defined HAVE_NS.
6339
93ea6e8f
PE
6340 * intervals.c: Make symbols static if they're not exported.
6341 (merge_properties_sticky, merge_interval_right, delete_interval):
6342 Now static.
6343 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6344
77382fcc
PE
6345 * insdel.c: Make symbols static if they're not exported.
6346 However, leave prepare_to_modify_buffer alone. It's never
6347 called from outside this function, but that appears to be a bug.
6348 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6349 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6350 (adjust_after_replace_noundo): Remove; unused.
6351 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6352 (signal_before_change): Remove decls.
77382fcc 6353
9306c32e
PE
6354 * indent.c (val_compute_motion, val_vmotion): Now static.
6355
cd44d2eb
PE
6356 * image.c: Make symbols static if they're not exported.
6357 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6358 if USE_GTK.
6359 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6360 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6361
ad9a7a06
PE
6362 * fringe.c (standard_bitmaps): Now static.
6363 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6364
81626931
PE
6365 * frame.c: Make symbols static if they're not exported.
6366 (x_report_frame_params, make_terminal_frame): Now static.
6367 (get_frame_param): Now static, unless HAVE_NS.
6368 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6369 (x_get_resource_string): Remove; not used.
6370 * frame.h (make_terminal_frame, x_report_frame_params):
6371 (x_get_resource_string); Remove decls.
6372 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6373 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6374
239f9db9
PE
6375 * font.c, fontset.c: Make symbols static if they're not exported.
6376 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6377 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6378 * font.c (font_close_object): Now static.
6379 * font.h (font_close_object): Remove.
6380 * fontset.c (FONTSET_OBJLIST): Remove.
6381 (free_realized_fontset) #if-0 the body, which does nothing.
6382 (face_suitable_for_char_p): #if-0, as it's never called.
6383 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6384 * xfaces.c (face_at_string_position):
6385 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6386 since 0 is always ASCII.
6387
dfcf3579
PE
6388 * fns.c (weak_hash_tables): Now static.
6389
5045092b
PE
6390 * fileio.c: Make symbols static if they're not exported.
6391 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6392 (Vwrite_region_annotation_buffers): Now static.
6393
57a96f5c
PE
6394 * eval.c: Make symbols static if they're not exported.
6395 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6396 * lisp.h (backtrace_list): Remove decl.
6397
35f08c38
PE
6398 * emacs.c: Make symbols static if they're not exported.
6399 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6400 (fatal_error_code, fatal_error_signal_hook, standard_args):
6401 Now static.
6402 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6403 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6404 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6405 * lisp.h (fatal_error_signal_hook): Remove decl.
6406 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6407
f44bd759
PE
6408 * editfns.c: Move a (normally-unused) function to its only use.
6409 * editfns.c, lisp.h (get_operating_system_release): Remove.
6410 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6411 worth the hassle of breaking this out.
6412
b532497d
PE
6413 * xterm.c: Make symbols static if they're not exported.
6414 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6415 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6416 (x_destroy_window, x_delete_display):
6417 Now static.
6418 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6419 (x_mouse_leave): Remove; unused.
6420 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6421 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6422 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6423 Remove decls.
6424 (x_mouse_leave): Declare only if WINDOWSNT.
6425 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6426 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6427 USE_X_TOOLKIT.
6428
1675728f
PE
6429 * ftxfont.c: Make symbols static if they're not exported.
6430 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6431 HAVE_FREETYPE.
6432 * font.h (ftxfont_driver): Likewise.
6433
e4cebfca
PE
6434 * xfns.c: Make symbols static if they're not exported.
6435 (x_last_font_name, x_display_info_for_name):
6436 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6437 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6438 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6439 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6440 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6441 (last_show_tip_args): Now static.
6442 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6443 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6444 (x_screen_planes): Remove; unused.
6445 * dispextern.h (x_screen_planes): Remove decl.
6446
5bf46f05
PE
6447 * dispnew.c: Make symbols static if they're not exported.
6448 * dispextern.h (redraw_garbaged_frames, scrolling):
6449 (increment_row_positions): Remove.
6450 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6451 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6452 Now static.
6453 (redraw_garbaged_frames): Remove; unused.
6454
435f4c28
PE
6455 * xfaces.c: Make symbols static if they're not exported.
6456 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6457 Remove decls.
6458 * xterm.h (defined_color): Remove decls.
6459 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6460 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6461 (menu_face_changed_default, defined_color, free_realized_face):
6462 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6463 (ascii_face_of_lisp_face): Remove; unused.
6464
8524aef3
PE
6465 * xdisp.c: Make symbols static if they're not exported.
6466 * dispextern.h (scratch_glyph_row, window_box_edges):
6467 (glyph_to_pixel_coords, set_cursor_from_row):
6468 (get_next_display_element, set_iterator_to_next):
6469 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6470 (show_mouse_face): Remove decls
6471 * frame.h (message_buf_print): Likewise.
6472 * lisp.h (pop_message, set_message, check_point_in_composition):
6473 Likewise.
6474 * xterm.h (set_vertical_scroll_bar): Likewise.
6475 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6476 (message_buf_print, scratch_glyph_row, displayed_buffer):
6477 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6478 (get_next_display_element, show_mouse_face, window_box_edges):
6479 (frame_to_window_pixel_xy, check_point_in_composition):
6480 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6481 (glyph_to_pixel_coords): Remove; unused.
6482
16390cd2
PE
6483 * dired.c (file_name_completion): Now static.
6484
6485 * dbusbind.c (xd_in_read_queued_messages): Now static.
6486
a25f4dfa
PE
6487 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6488 * data.c (circular_list_error): Remove.
6489
14a9c8df
PE
6490 * commands.h (last_point_position, last_point_position_buffer):
6491 (last_point_position_window): Remove decls.
6492 * keyboard.c: Make these variables static.
6493
04f2d78b
CB
6494 * coding.h (coding, code_convert_region, encode_coding_gap):
6495 Remove decls.
74ab6df5
PE
6496 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6497 (iso_code_class, detect_coding, code_convert_region): Now static.
6498 (encode_coding_gap): Remove; unused.
6499
38dfbee1
PE
6500 * chartab.c (chartab_chars, chartab_bits): Now static.
6501
a2cb4e63
PE
6502 * charset.h (charset_iso_8859_1): Remove decl.
6503 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6504 Now static.
6505
127198fd
PE
6506 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6507 * ccl.c (Vccl_program_table): Now static.
6508 (check_ccl_update): Remove; unused.
6509
d85b608f
PE
6510 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6511 * category.h: ... from here.
6512 * category.c (check_category_table, set_category_set): Now static.
6513
31cd66f3
PE
6514 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6515 * lisp.h: Remove these decls.
6516
c358e587
PE
6517 * buffer.c (buffer_count): Remove unused var.
6518
e78aecca
PE
6519 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6520 so that it's not optimized away.
6521 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6522 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6523 exported only to the debugger.
6524
e192d7d3 6525 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6526 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6527
92470028
PE
6528 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6529 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6530 was inaccessible from Lisp.
6531 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6532 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6533
244ed907
PE
6534 alloc.c: Import and export fewer symbols, and remove unused items.
6535 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6536 is defined.
6537 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6538 it's not optimized away by whole-program optimization.
6539 (message_enable_multibyte, free_misc): Remove.
6540 (catchlist, handlerlist, mark_backtrace):
6541 Declare only if BYTE_MARK_STACK.
6542 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6543 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6544 (message_enable_multibyte): Remove decl.
6545 (free_misc, interval_free_list, float_block, float_block_index):
6546 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6547 (cons_free_list, last_marked_index):
6548 Now static.
6549 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6550 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6551 (mark_backtrace): Define only if BYTE_MARK_STACK.
6552 * xdisp.c (message_enable_multibyte): Now static.
6553
61c2b50e 6554 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6555 This makes it easier for human readers (and static analyzers)
6556 to see whether these variables are used from other modules.
6557 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6558 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6559 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6560 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6561 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6562 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6563 * xmenu.c, xselect.c:
6564 Declare Q* vars static if they are not used in other modules.
6565 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6566 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6567 Remove decls of unexported vars.
6568 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6569
95c82688
PE
6570 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6571
16a97296
PE
6572 Make Emacs functions such as Fatom 'static' by default.
6573 This makes it easier for human readers (and static analyzers)
6574 to see whether these functions can be called from other modules.
6575 DEFUN now defines a static function. To make the function external
6576 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6577 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6578 (Finit_image_library):
16a97296
PE
6579 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6580 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6581 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6582 Remove decls, since these functions are now static.
6583 (Funintern, Fget_internal_run_time): New decls, since these functions
6584 were already external.
95c82688 6585
16a97296
PE
6586 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6587 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6588 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6589 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6590 * keyboard.c, keymap.c, lread.c:
6591 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6592 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6593 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6594 Mark functions with DEFUE instead of DEFUN,
6595 if they are used in other modules.
6596 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6597 decls for now-static functions.
6598 * buffer.h (Fdelete_overlay): Remove decl.
6599 * callproc.c (Fgetenv_internal): Mark as internal.
6600 * composite.c (Fremove_list_of_text_properties): Remove decl.
6601 (Fcomposition_get_gstring): New forward static decl.
6602 * composite.h (Fcomposite_get_gstring): Remove decl.
6603 * dired.c (Ffile_attributes): New forward static decl.
6604 * doc.c (Fdocumntation_property): New forward static decl.
6605 * eval.c (Ffetch_bytecode): New forward static decl.
6606 (Funintern): Remove extern decl; now in .h file where it belongs.
6607 * fileio.c (Fmake_symbolic_link): New forward static decl.
6608 * image.c (Finit_image_library): New forward static decl.
6609 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6610 * intervals.h (Fprevious_property_change):
6611 (Fremove_list_of_text_properties): Remove decls.
6612 * keyboard.c (Fthis_command_keys): Remove decl.
6613 (Fcommand_execute): New forward static decl.
6614 * keymap.c (Flookup_key): New forward static decl.
6615 (Fcopy_keymap): Now static.
6616 * keymap.h (Flookup_key): Remove decl.
6617 * process.c (Fget_process): New forward static decl.
6618 (Fprocess_datagram_address): Mark as internal.
6619 * syntax.c (Fsyntax_table_p): New forward static decl.
6620 (skip_chars): Remove duplicate decl.
6621 * textprop.c (Fprevious_property_change): New forward static decl.
6622 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6623 Now internal.
6624 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6625 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6626
785bbd42
PE
6627 * editfns.c (Fformat): Remove unreachable code.
6628
8b913b57
AS
66292011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6630
6631 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6632 change. (Bug#8496)
6633
a6744a35
EZ
66342011-04-13 Eli Zaretskii <eliz@gnu.org>
6635
6636 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6637 when at ZV. (Bug#8487)
6638
e7974947
AS
66392011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6640
baad03f0
AS
6641 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6642 (Bug#8437)
6643 * keyboard.c (parse_tool_bar_item): Likewise.
6644 * sound.c (sound_cleanup, alsa_close): Likewise.
6645 * termcap.c (tgetent): Likewise.
6646 * xfns.c (x_default_font_parameter): Likewise.
6647 * xsettings.c (read_and_apply_settings): Likewise.
6648
e7974947
AS
6649 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6650 (overrun_check_free): Protoize.
6651
28272684
PE
66522011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6653
6654 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6655 since callers should never pass a negative size.
6656 Change the signature to match that of plain 'read' and 'write'; see
6657 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6658 * lisp.h: Update prototypes of emacs_write and emacs_read.
6659
11997c76
EZ
66602011-04-11 Eli Zaretskii <eliz@gnu.org>
6661
6662 * xdisp.c (redisplay_window): Don't try to determine the character
6663 position of the scroll margin if the window start point w->startp
e896f03c 6664 is outside the buffer's accessible region. (Bug#8468)
11997c76 6665
8a2cbd72
EZ
66662011-04-10 Eli Zaretskii <eliz@gnu.org>
6667
6668 Fix write-region and its subroutines for buffers > 2GB.
6669 * fileio.c (a_write, e_write): Modify declaration of arguments and
6670 local variables to support buffers larger than 2GB.
6671 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6672
6673 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6674 argument, local variables, and return value.
6675
6676 * lisp.h: Update prototypes of emacs_write and emacs_read.
6677
6678 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6679
4073e537 66802011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6681
1ebfdcb6
PE
6682 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6683
b2ded58d
PE
6684 Fix more problems found by GCC 4.6.0's static checks.
6685
7d66342c
PE
6686 * xdisp.c (vmessage): Use a better test for character truncation.
6687
bbf47d44
PE
6688 * charset.c (load_charset_map): <, not <=, for optimization,
6689 and to avoid potential problems with integer overflow.
9248994d 6690 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6691 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6692 * editfns.c (Fformat): Likewise.
1e69125e 6693 * syntax.c (skip_chars): Likewise.
3befa583 6694
e3019616
PE
6695 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6696 This also lets GCC 4.6.0 generate slightly better loop code.
6697
becfa255
PE
6698 * callint.c (Fcall_interactively): <, not <=, for optimization.
6699 (Fcall_interactively): Count the number of arguments produced,
6700 not the number of arguments given. This is simpler and lets GCC
6701 4.6.0 generate slightly better code.
6702
dae0cd48
PE
6703 * ftfont.c: Distingish more carefully between FcChar8 and char.
6704 The previous code passed unsigned char * to a functions like
6705 strlen and xstrcasecmp that expect char *, which does not
6706 conform to the C standard.
6707 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6708 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6709 char * when the C standard requires it.
6710
76032d70
PE
6711 * keyboard.c (read_char): Remove unused var.
6712
eb3f1cc8
PE
6713 * eval.c: Port to Windows vsnprintf (Bug#8435).
6714 Include <limits.h>.
6715 (SIZE_MAX): Define if the headers do not.
6716 (verror): Do not give up if vsnprintf returns a negative count.
6717 Instead, grow the buffer. This ports to Windows vsnprintf, which
6718 does not conform to C99. Problem reported by Eli Zaretskii.
6719 Also, simplify the allocation scheme, by avoiding the need for
6720 calling realloc, and removing the ALLOCATED variable.
6721
70476b54
PE
6722 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6723
12020a9e
PE
6724 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6725 But keep the doprint source code for now, as we might revamp it
6726 and use it again (Bug#8435).
ea6c7ae6
PE
6727 * lisp.h (doprnt): Remove.
6728 * Makefile.in (base_obj): Remove doprnt.o.
6729 * deps.mk (doprnt.o): Remove.
6730
5fdb398c
PE
6731 error: Print 32- and 64-bit integers portably (Bug#8435).
6732 Without this change, on typical 64-bit hosts error ("...%d...", N)
6733 was used to print both 32- and 64-bit integers N, which relied on
6734 undefined behavior.
6735 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6736 New macro.
6737 * lisp.h (error, verror): Mark as printf-like functions.
6738 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6739 Report overflow in size calculations when allocating printf buffer.
6740 Do not truncate output string at its first null byte.
6741 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6742 Truncate the output at a character boundary, since vsnprintf does not
6743 do that.
6744 * charset.c (check_iso_charset_parameter): Convert internal
6745 character to string before calling 'error', since %c now has the
6746 printf meaning.
6747 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6748 overflow when computing char to be passed to 'error'. Do not
6749 pass Lisp_Object to 'error'; pass the integer instead.
6750 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6751 formatted with plain %d.
6752
b189fa66
PE
6753 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6754
bff87ef0
PE
6755 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6756
7e2cac20
PE
6757 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6758
ce4d90b5
PE
6759 * xterm.c (x_catch_errors): Remove duplicate declaration.
6760
266c9547
PE
6761 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6762
79c49ad2
PE
6763 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6764
368f4090
JM
67652011-04-10 Jim Meyering <meyering@redhat.com>
6766
6767 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6768 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6769 return ssize_t not "int", and use size_t as the buffer length.
6770 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6771 * gnutls.h: Update declarations.
6772 * process.c (read_process_output): Use ssize_t, to match.
6773 (send_process): Likewise.
6774
a32d4040
CY
67752011-04-09 Chong Yidong <cyd@stupidchicken.com>
6776
6777 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6778
8546720e 67792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6780
04f2d78b
CB
6781 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6782 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6783
8546720e
GM
6784 * xterm.c (handle_one_xevent):
6785 * xmenu.c (create_and_show_popup_menu):
6786 * xselect.c (x_decline_selection_request)
6787 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6788
0a2f5c1a 67892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6790
6791 Fix some uses of `int' instead of EMACS_INT.
6792 * search.c (string_match_1, fast_string_match)
6793 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6794 (scan_buffer, find_next_newline_no_quit)
6795 (find_before_next_newline, search_command, Freplace_match)
6796 (Fmatch_data): Make some `int' variables be EMACS_INT.
6797
6798 * xdisp.c (display_count_lines): 3rd argument and return value now
6799 EMACS_INT. All callers changed.
6800 (pint2hrstr): Last argument is now EMACS_INT.
6801
6802 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6803 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6804 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6805 (decode_coding_utf_16, decode_coding_emacs_mule)
6806 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6807 (decode_coding_ccl, decode_coding_charset)
6808 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6809 (decode_coding_iso_2022, decode_coding_emacs_mule)
6810 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6811 <char_offset, last_offset>: Declare EMACS_INT.
6812 (encode_coding_utf_8, encode_coding_utf_16)
6813 (encode_coding_emacs_mule, encode_invocation_designation)
6814 (encode_designation_at_bol, encode_coding_iso_2022)
6815 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6816 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6817 Declare EMACS_INT.
6818 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6819 (encode_invocation_designation): Last argument P_NCHARS is now
6820 EMACS_INT.
6821 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6822 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6823
6824 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6825 All users changed.
6826
6827 * ccl.c (Fccl_execute_on_string): Declare some variables
6828 EMACS_INT.
6829
8546720e 68302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6831
6832 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6833
4e19a977
CS
68342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6835
6836 * process.c (Fformat_network_address): Doc fix.
6837
87302331
R
68382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6839
6840 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6841
cbb59342
CY
68422011-04-08 Chong Yidong <cyd@stupidchicken.com>
6843
6844 * keyboard.c (read_char): Call Lisp function help-form-show,
6845 instead of using internal_with_output_to_temp_buffer.
6846 (Qhelp_form_show): New var.
e0d38eeb 6847 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6848
6849 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6850
6851 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6852
e67a13ab
CY
68532011-04-06 Chong Yidong <cyd@stupidchicken.com>
6854
04f2d78b
CB
6855 * process.c (Flist_processes): Remove to Lisp.
6856 (list_processes_1): Delete.
e67a13ab 6857
973f782d
EZ
68582011-04-06 Eli Zaretskii <eliz@gnu.org>
6859
7c106b1e
EZ
6860 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6861
973f782d
EZ
6862 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6863
41cf7d1a 68642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6865
ca23cc88
PE
6866 Fix more problems found by GCC 4.6.0's static checks.
6867
f390e2d5
PE
6868 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6869
42eea0d0
PE
6870 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6871
b69769da 6872 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6873
f9541e84
PE
6874 * xdisp.c (vmessage): Mark as a printf-like function.
6875
13841b55
PE
6876 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6877
c136c10f
PE
6878 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6879
5e2d4a30
PE
6880 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6881 printf-like functions.
6882 (tiff_load): Add casts to remove these marks before passing them
6883 to system-supplied API.
6884
583f48b9
PE
6885 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6886
b25d760e
PE
6887 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6888 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6889 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6890 directly, rather than having caller test rule sign. This avoids
6891 some unnecessary tests.
6892 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6893 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6894 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6895
bc7b6697 6896 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6897 (xfont_open): Avoid unnecessary tests.
bc7b6697 6898
27ccc379
PE
6899 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6900
dcd5c89a
PE
6901 * composite.h, composite.c (composition_gstring_put_cache):
6902 Use EMACS_INT, not int, for length.
6903
b13a45c6
PE
6904 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6905 breaking out part of COMPOSITION_DECODE_RULE.
6906 (COMPOSITION_DECODE_RULE): Use it.
6907 * composite.c (get_composition_id): Remove unused local vars,
6908 by using the new macro.
6909
1e792e4d
PE
6910 * textprop.c (set_text_properties_1): Change while to do-while,
6911 since the condition is always true at first.
6912
dc6c6455 6913 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6914 (interval_deletion_adjustment): Return unsigned value.
6915 All uses changed.
dc6c6455 6916
aba7731a
PE
6917 * process.c (list_processes_1, create_pty, read_process_output):
6918 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6919 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6920 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6921 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6922 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6923
fdfc4bf3
PE
6924 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6925
fca8fe46 6926 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6927 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6928
06a0259a 6929 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6930 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6931 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6932
e7b9e80f
PE
6933 * print.c (print_error_message): Avoid int overflow.
6934
56201685
PE
6935 * font.c (font_list_entities): Redo for clarity,
6936 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6937
78834453 6938 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6939 (font_score): Avoid potential overflow in diff calculation.
78834453 6940
0bc0b309 6941 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6942 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6943
e610eaca
PE
6944 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6945
b895abce
PE
6946 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6947 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6948 can always succeed if overflow has undefined behavior.
6949
1f1d9321 6950 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6951 (wordify): Omit three unnecessary tests.
1f1d9321 6952
c59478bc
PE
6953 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6954 All callers changed. This avoids the need for an unused var.
6955
79b73827
PE
6956 * casefiddle.c (casify_region): Remove var that is set but not used.
6957
a4db5dfe
PE
6958 * dired.c (file_name_completion): Remove var that is set but not used.
6959
43aae36e
PE
6960 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6961
2a47c44d 6962 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6963 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6964
a37c69bf
PE
6965 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6966 Check for integer overflow on size calculations.
6967
328ab8e7
PE
6968 * buffer.c (Fprevious_overlay_change): Remove var that is set
6969 but not used.
6970
e5a2a5cb
PE
6971 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6972 Remove vars that are set but not used.
8d84a6eb 6973 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6974 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6975
a60e5f68
PE
6976 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6977
f661cb61 6978 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6979 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6980
f0397f5a
PE
6981 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6982 that are set but not used.
6983
8664db06 6984 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6985 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6986
6abdaa4a
PE
6987 * xselect.c (x_get_local_selection, x_handle_property_notify):
6988 Remove vars that are set but not used.
6989
0ce7538d 6990 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6991 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6992
9ae848fc
PE
6993 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6994 Remove var that is set but not used.
0b918413
PE
6995 (scroll_bar_windows_size): Now size_t, not int.
6996 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6997 Check for overflow.
9ae848fc 6998
a5a62657
PE
6999 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7000 (map_tty_color) [!defined MSDOS]: Likewise.
7001
5c5cdd39
PE
7002 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7003
66ebf983
PE
7004 * coding.c: Remove vars that are set but not used.
7005 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7006 All callers changed.
7007 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7008 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7009 (decode_coding_charset): Remove vars that are set but not used.
7010
1be4d761
PE
7011 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7012 that is set but not used.
7013
47553fa8
PE
7014 * print.c (print_object): Remove var that is set but not used.
7015
1f7196bf 7016 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7017 The gnulib version avoids calling malloc in the usual case,
7018 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7019 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7020 * filelock.c (current_lock_owner): Likewise.
7021 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7022 * sysdep.c: Include allocator.h, careadlinkat.h.
7023 (emacs_no_realloc_allocator): New static constant.
7024 (emacs_readlink): New function.
fdb61804
PE
7025 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7026 ../lib/careadlinkat.h.
d1fdcab7 7027
f84c17c7
SM
70282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7029
7030 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7031 first non-nil return value).
7032
ef3862ad
JD
70332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7034
7035 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7036 if not defined (Bug#8403).
7037
376a7006
JB
70382011-04-02 Juanma Barranquero <lekktu@gmail.com>
7039
7040 * xdisp.c (display_count_lines): Remove parameter `start',
7041 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7042 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7043 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7044 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7045 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7046 and thereabouts. All callers changed.
7047 (get_per_char_metric): Remove parameter `f', unused since
7048 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7049
6ca3801d
JM
70502011-04-02 Jim Meyering <meyering@redhat.com>
7051
7052 do not dereference NULL upon failed strdup
7053 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7054 (ns_get_family): Likewise.
7055
d8e2b5ba
JB
70562011-04-02 Juanma Barranquero <lekktu@gmail.com>
7057
7058 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7059
8c74fcbd
JD
70602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7061
7062 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7063 later (Bug#8403).
7064
7200d79c
SM
70652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7066
03408648 7067 Add lexical binding.
7200d79c 7068
03408648
SM
7069 * window.c (Ftemp_output_buffer_show): New fun.
7070 (Fsave_window_excursion):
7071 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7072
7073 * lread.c (lisp_file_lexically_bound_p): New function.
7074 (Fload): Bind Qlexical_binding.
7075 (readevalloop): Remove `evalfun' arg.
7076 Bind Qinternal_interpreter_environment.
7077 (Feval_buffer): Bind Qlexical_binding.
7078 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7079 Mark as dynamic.
7080 (syms_of_lread): Declare `lexical-binding'.
7081
7082 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7083
7084 * keyboard.c (eval_dyn): New fun.
7085 (menu_item_eval_property): Use it.
ca105506
SM
7086
7087 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7088
03408648
SM
7089 * fns.c (concat, mapcar1): Accept byte-code-functions.
7090
7091 * eval.c (Fsetq): Handle lexical vars.
7092 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7093 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7094 (FletX, Flet): Obey lexical binding.
7095 (Fcommandp): Handle closures.
7096 (Feval): New `lexical' arg.
7097 (eval_sub): New function extracted from Feval. Use it almost
7098 everywhere where Feval was used. Look up vars in lexical env.
7099 Handle closures.
7100 (Ffunctionp): Move from subr.el.
7101 (Ffuncall): Handle closures.
7102 (apply_lambda): Remove `eval_flags'.
7103 (funcall_lambda): Handle closures and new byte-code-functions.
7104 (Fspecial_variable_p): New function.
7105 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7106 but without exporting it to Lisp.
23aba0ea 7107
23aba0ea 7108 * doc.c (Fdocumentation, store_function_docstring):
03408648 7109 * data.c (Finteractive_form): Handle closures.
23aba0ea 7110
03408648
SM
7111 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7112 interactive spec.
ba83908c 7113
04f2d78b
CB
7114 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7115 New byte-codes.
03408648
SM
7116 (exec_byte_code): New function extracted from Fbyte_code to handle new
7117 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7118
03408648 7119 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7120
03408648 7121 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7122
e2abce01
JB
71232011-03-31 Juanma Barranquero <lekktu@gmail.com>
7124
7125 * xdisp.c (redisplay_internal): Fix prototype.
7126
63696a73 71272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7128
63696a73 7129 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7130 (try_scrolling): Use it when setting scroll_limit.
7131 Limit scrolling to 100 screen lines.
63696a73
EZ
7132 (redisplay_window): Even when falling back on "recentering",
7133 position point in the window according to scroll-conservatively,
7134 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7135
7136 (try_scrolling): When point is above the window, allow searching
7137 as far as scroll_max, or one screenful, to compute vertical
7138 distance from PT to the scroll margin position. This prevents
7139 try_scrolling from unnecessarily failing when
7140 scroll-conservatively is set to a value slightly larger than the
7141 window height. Clean up the case of PT below the margin at bottom
7142 of window: scroll_max can no longer be INT_MAX. When aggressive
7143 scrolling is in use, don't let point enter the opposite scroll
7144 margin as result of the scroll.
7145 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7146 threshold of 100 lines for never-recentering scrolling.
7147
e4cc2dfc
JB
71482011-03-31 Juanma Barranquero <lekktu@gmail.com>
7149
7150 * dispextern.h (move_it_by_lines):
7151 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7152 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7153 (message_log_check_duplicate): Remove parameters `prev_bol' and
7154 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7155 (redisplay_internal): Remove parameter `preserve_echo_area',
7156 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7157
7158 * indent.c (Fvertical_motion):
7159 * window.c (window_scroll_pixel_based, Frecenter):
7160 Don't pass `need_y_p' to `move_it_by_lines'.
7161
1c470562
SM
71622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7163
44f230aa
SM
7164 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7165 steal a few bits to be more compact.
7166 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7167 Remove unneeded casts.
7168
1c470562
SM
7169 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7170
888adce9
ZK
71712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7172
7173 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7174 binding" message (bug#7967).
7175
f838ed7b
PE
71762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7177
77861b95
PE
7178 Fix more problems found by GCC 4.6.0's static checks.
7179
de6dbc14
PE
7180 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7181 Remove unused local var.
7182
f838ed7b
PE
7183 * editfns.c (Fmessage_box): Remove unused local var.
7184
792c7b2b
PE
7185 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7186 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7187 Omit unused local vars.
c499e557 7188 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7189 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7190 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7191 Omit unused local var.
7192
ba0165e1
PE
7193 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7194 Don't assume string length fits in int.
32ad8845 7195 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7196 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7197
3c59b4c9
PE
7198 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7199 instead of alloca (Bug#8344).
7200
a3eed478 7201 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7202 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7203
eb4d412d
PE
7204 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7205
1658b401
PE
7206 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7207 concerns.
7208
7209 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7210
7211 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7212
9a2c6e05
PE
7213 * keyboard.c (syms_of_keyboard): Use the same style as later
7214 in this function when indexing through an array. This also
7215 works around GCC bug 48267.
7216
03d0a109
PE
7217 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7218
44f730c8
PE
7219 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7220
fe75f926
PE
7221 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7222 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7223
ffa8c828
PE
7224 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7225 This avoids undefined behavior on integer overflow, and is a bit
7226 more convenient anyway since it is compared to a size_t variable.
7227
c5101a77
PE
7228 Variadic C functions now count arguments with size_t, not int.
7229 This avoids an unnecessary limitation on 64-bit machines, which
7230 caused (substring ...) to crash on large vectors (Bug#8344).
7231 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7232 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7233 All variadic functions and their callers changed accordingly.
c5101a77
PE
7234 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7235 * data.c (arith_driver, float_arith_driver): Likewise.
7236 * editfns.c (general_insert_function): Likewise.
7237 * eval.c (struct backtrace.nargs, interactive_p)
7238 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7239 (funcall_lambda, mark_backtrace): Likewise.
7240 * fns.c (concat): Likewise.
7241 * frame.c (x_set_frame_parameters): Likewise.
7242 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7243 0 if not found, not -1. All callers changed.
7244
dd3f25f7
PE
7245 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7246 (stack_copy_size): Now size_t, not int.
7247 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7248
461c2ab9
JB
72492011-03-28 Juanma Barranquero <lekktu@gmail.com>
7250
7251 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7252 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7253 All callers changed.
7254
7255 * lisp.h (multibyte_char_to_unibyte):
7256 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7257 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7258 * character.h (CHAR_TO_BYTE8):
7259 * cmds.c (internal_self_insert):
7260 * editfns.c (general_insert_function):
7261 * keymap.c (push_key_description):
7262 * search.c (Freplace_match):
7263 * xdisp.c (message_dolog, set_message_1): All callers changed.
7264
f6d62986
SM
72652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7266
7267 * keyboard.c (safe_run_hook_funcall): New function.
7268 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7269 don't set the hook to nil, but remove the offending function instead.
7270 (Qcommand_hook_internal): Remove, unused.
7271 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7272 Vcommand_hook_internal.
7273
7274 * eval.c (enum run_hooks_condition): Remove.
7275 (funcall_nil, funcall_not): New functions.
7276 (run_hook_with_args): Call each function through a `funcall' argument.
7277 Remove `cond' argument, now redundant.
7278 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7279 (Frun_hook_with_args_until_failure): Adjust accordingly.
7280 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7281
1db5b1ad
JB
72822011-03-28 Juanma Barranquero <lekktu@gmail.com>
7283
7284 * dispextern.h (string_buffer_position): Remove declaration.
7285
7286 * print.c (strout): Remove parameter `multibyte', unused since
7287 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7288
7289 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7290 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7291 All callers changed.
7292
7293 * w32.c (_wsa_errlist): Use braces for struct initializers.
7294
7295 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7296 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7297 All callers changed.
7298 (string_buffer_position): Likewise. Also, make static (it's never
7299 used outside xdisp.c).
7300 (cursor_row_p): Remove parameter `w', unused since
7301 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7302 (decode_mode_spec): Remove parameter `precision', introduced during
7303 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7304 All callers changed.
7305
5ffb62aa
JD
73062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7307
7308 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7309
461c2ab9 73102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7311
7312 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7313 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7314 (ns_update_auto_hide_menu_bar): New functions.
7315 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7316 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7317 ns_constrain_all_frames.
7318 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7319 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7320
5c380ffb
JD
73212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7322
7323 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7324
9af30bdf
GM
73252011-03-27 Glenn Morris <rgm@gnu.org>
7326
7327 * syssignal.h: Replace RETSIGTYPE with void.
7328 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7329 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7330 Replace SIGTYPE with void everywhere.
7331 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7332 * s/template.h (SIGTYPE): Remove commented out definition.
7333
e2abce01
JB
73342011-03-26 Eli Zaretskii <eliz@gnu.org>
7335
7336 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7337 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7338
f868cd8a
JB
73392011-03-26 Juanma Barranquero <lekktu@gmail.com>
7340
59eb0929
JB
7341 * w32.c (read_unc_volume): Use parameter `henum', instead of
7342 global variable `wget_enum_handle'.
7343
7344 * keymap.c (describe_vector): Remove parameters `indices' and
7345 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7346 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7347
f868cd8a
JB
7348 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7349
7350 * keyboard.c (timer_check): Remove parameter `do_it_now',
7351 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7352 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7353 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7354
7355 * keyboard.c (read_char):
7356 * w32menu.c (w32_menu_display_help):
7357 * xmenu.c (show_help_event, menu_help_callback):
7358 Adjust calls to `show_help_echo'.
7359
7360 * gtkutil.c (xg_maybe_add_timer):
7361 * keyboard.c (readable_events):
7362 * process.c (wait_reading_process_output):
7363 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7364
7365 * insdel.c (adjust_markers_gap_motion):
7366 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7367 (gap_left, gap_right): Don't call it.
7368
2ecf6fdb
CY
73692011-03-25 Chong Yidong <cyd@stupidchicken.com>
7370
7371 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7372 incurred during fontification.
7373
6b1f9ba4
JB
73742011-03-25 Juanma Barranquero <lekktu@gmail.com>
7375
7376 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7377 (DEFVAR_PER_BUFFER): Don't pass it.
7378
7379 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7380 (scrolling_window): Don't pass it.
7381
0f4a96b5
JB
73822011-03-25 Juanma Barranquero <lekktu@gmail.com>
7383
7384 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7385
7386 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7387 and `suffix'.
7388 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7389 of variables specific to SELinux and computation of `encoded_absname'.
7390
7391 * image.c (XPutPixel): Remove unused variable `height'.
7392
7393 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7394
7395 * unexw32.c (get_section_info): Remove unused variable `section'.
7396
7397 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7398 (system_process_attributes): Remove unused variable `sess'.
7399 (sys_read): Remove unused variable `err'.
7400
7401 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7402 (w32_wnd_proc): Remove unused variable `isdead'.
7403 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7404 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7405 (x_create_tip_frame): Remove unused variable `tem'.
7406
7407 * w32inevt.c (w32_console_read_socket):
7408 Remove unused variable `no_events'.
7409
7410 * w32term.c (x_draw_composite_glyph_string_foreground):
7411 Remove unused variable `width'.
7412
1149507c
JB
74132011-03-24 Juanma Barranquero <lekktu@gmail.com>
7414
7415 * w32term.c (x_set_glyph_string_clipping):
7416 Don't pass uninitialized region to CombineRgn.
7417
9c88f339
JB
74182011-03-23 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7421 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7422 (Fx_close_connection): Remove unused variable `i'.
7423
7424 * w32font.c (w32font_draw): Return number of glyphs.
7425 (w32font_open_internal): Remove unused variable `i'.
7426 (w32font_driver): Add missing initializer.
7427
7428 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7429 (fill_in_menu): Remove unused variable `items_added'.
7430
7431 * w32term.c (last_mouse_press_frame): Remove static global variable.
7432 (w32_clip_to_row): Remove unused variable `f'.
7433 (x_delete_terminal): Remove unused variable `i'.
7434
7435 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7436 (NOTHING): Remove unused static global variable.
7437 (uniscribe_check_otf): Remove unused variable `table'.
7438 (uniscribe_font_driver): Add missing initializers.
7439
dee091a3
JD
74402011-03-23 Julien Danjou <julien@danjou.info>
7441
7442 * term.c (Fsuspend_tty, Fresume_tty):
7443 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7444 * window.c (temp_output_buffer_show):
7445 * insdel.c (signal_before_change):
7446 * frame.c (Fhandle_switch_frame):
7447 * fileio.c (Fdo_auto_save):
7448 * emacs.c (Fkill_emacs):
7449 * editfns.c (save_excursion_restore):
7450 * cmds.c (internal_self_insert):
7451 * callint.c (Fcall_interactively):
7452 * buffer.c (Fkill_all_local_variables):
7453 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7454 Use Frun_hooks.
0f4a96b5 7455 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7456 unconditionnaly since it does the check itself.
7457
2c520ab5 74582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7459
c9c49752
PE
7460 Fix more problems found by GCC 4.5.2's static checks.
7461
8abc3f12
PE
7462 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7463 the first time through the loop, since we know p0 < p1 then.
7464 This also avoids a gcc -Wstrict-overflow warning.
7465
a2d26660
PE
7466 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7467 leading to a memory leak, possible in functions like
7468 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7469 of objects (Bug#8318).
a2d26660 7470
916c72e9
PE
7471 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7472 that could (at least in theory) be that large.
7473
19ab8a18
PE
7474 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7475 This is less likely to overflow, and avoids undefined behavior if
7476 overflow does occur. All callers changed. Use strtoul to scan
7477 for the unsigned long integer.
b7cbbd6f
PE
7478 (pint2hrstr): Simplify and tune code slightly.
7479 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7480
f0641eff
PE
7481 * scroll.c (do_scrolling): Work around GCC bug 48228.
7482 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7483
7f650bb9
PE
7484 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7485 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7486 (validate_x_resource_name): Simplify count usage.
7487 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7488
37dd57d1
PE
7489 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7490 fail (Bug#8306).
81e56e61 7491
699979fc 7492 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7493
401bf9b4
PE
7494 * process.c (Fmake_network_process): Use socklen_t, not int,
7495 where POSIX says socklen_t is required in portable programs.
7496 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7497 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7498 (Fmake_network_process, server_accept_connection):
7499 (wait_reading_process_output, read_process_output):
7500 Likewise.
7501
b93aacde
PE
7502 * process.c: Rename or move locals to avoid shadowing.
7503 (list_processes_1, Fmake_network_process):
7504 (read_process_output_error_handler, exec_sentinel_error_handler):
7505 Rename or move locals.
4dc343ee 7506 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7507 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7508 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7509 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7510 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7511
af8a867c 7512 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7513 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7514 Include tparam.h instead, since it declares them.
af8a867c
PE
7515 * cm.h (PC): Remove extern decl; tparam.h now does this.
7516 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7517 * terminfo.c: Include tparam.h, to check interfaces.
7518 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7519 (tparam): Adjust signature to match interface in tparam.h;
7520 this removes some undefined behavior. Check that outstring and len
7521 are zero, which they always are with Emacs.
7522 * tparam.h (PC, BC, UP): New extern decls.
7523
0248044d 7524 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7525 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7526
8ff096c1 7527 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7528 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7529 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7530 (ftfont_list): Remove unused local.
49eaafba
PE
7531 (get_adstyle_property, ftfont_pattern_entity):
7532 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7533 Rename locals to avoid shadowing.
8ff096c1 7534
e2be39f6
PE
7535 * xfont.c (xfont_list_family): Mark var as initialized.
7536
c9735e30
PE
7537 * xml.c (make_dom): Now static.
7538
8f5201ae
PE
7539 * composite.c (composition_compute_stop_pos): Rename local to
7540 avoid shadowing.
b246f932
PE
7541 (composition_reseat_it): Remove unused locals.
7542 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7543 (composition_update_it): Mark var as initialized.
11b61122
PE
7544 (find_automatic_composition): Mark vars as initialized,
7545 with a FIXME (Bug#8290).
8f5201ae 7546
760fbc2c
PE
7547 character.h: Rename locals to avoid shadowing.
7548 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7549 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7550 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7551 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7552 to avoid shadowing.
7553
ff08eb85
PE
7554 * textprop.c (property_change_between_p): Remove; unused.
7555
fc7bf025
PE
7556 * intervals.c (interval_start_pos): Now static.
7557
235d7abc
PE
7558 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7559
44f230aa
SM
7560 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7561 Rename locals to avoid shadowing.
3e7d6594 7562
50060332
PE
7563 * sound.c (wav_play, au_play, Fplay_sound_internal):
7564 Fix pointer signedness.
d01f234b 7565 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7566 (wav_play): Initialize a variable to 0, to prevent undefined
7567 behavior (Bug#8278).
50060332 7568
c4fc4e30
PE
7569 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7570
918436ed
PE
7571 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7572
c939f91b
PE
7573 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7574 clobbering (Bug#8298).
b9c7f648
PE
7575 * sysdep.c (sys_subshell): Likewise.
7576 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7577
6bd8c144
PE
7578 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7579 This should get cleaned up, so that child_setup has the
7580 same signature on all platforms.
7581
7710357c 7582 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7583 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7584
c59da222
CY
75852011-03-22 Chong Yidong <cyd@stupidchicken.com>
7586
7587 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7588 not to be necessary, and produces flickering.
7589
66b87493
GM
75902011-03-20 Glenn Morris <rgm@gnu.org>
7591
7592 * config.in: Remove file.
7593
45b6f6d5
JB
75942011-03-20 Juanma Barranquero <lekktu@gmail.com>
7595
7596 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7597 are now in src/globals.h.
7598 (syms_of_minibuf): Remove spurious & from previous change.
7599
3ec03f7e
LL
76002011-03-20 Leo <sdl.web@gmail.com>
7601
7602 * minibuf.c (completing-read-function): New variable.
7603 (completing-read-default): Rename from completing-read.
7604 (completing-read): Call completing-read-function.
7605
b14e3e21
CY
76062011-03-19 Juanma Barranquero <lekktu@gmail.com>
7607
7608 * xfaces.c (Fx_load_color_file):
7609 Read color file from absolute filename (bug#8250).
7610
f2b726e6
JB
76112011-03-19 Juanma Barranquero <lekktu@gmail.com>
7612
7613 * makefile.w32-in: Update dependencies.
7614
09f6ff02
EZ
76152011-03-17 Eli Zaretskii <eliz@gnu.org>
7616
7617 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7618
29a6015a
PE
76192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7620
a3a6c54e
PE
7621 Fix more problems found by GCC 4.5.2's static checks.
7622
b766f867
PE
7623 * process.c (make_serial_process_unwind, send_process_trap):
7624 (sigchld_handler): Now static.
7625
be02381c
PE
7626 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7627 That way, the code declares only the vars that it needs.
7628 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7629 * s/cygwin.h (PTY_ITERATION): Likewise.
7630 * s/darwin.h (PTY_ITERATION): Likewise.
7631 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7632
57048744
PE
7633 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7634 * process.c (allocate_pty): Don't declare stb unless it's needed.
7635
7914961c 7636 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7637 (CONSTANTLIM): Remove; unused.
7638 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7639 Define only if needed.
7914961c 7640
b3967b18
PE
7641 * unexelf.c (unexec): Name an expression,
7642 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7643 Use a different way to cause a compilation error if anyone uses
7644 n rather than nn, a way that does not involve shadowing.
73366a00 7645 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7646
29a6015a
PE
7647 * deps.mk (unexalpha.o): Remove; unused.
7648
43cfc33e 7649 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7650 * unexec.h: New file.
ce701a33
PE
7651 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7652 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7653 Depend on unexec.h.
7654 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7655 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7656 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7657 Change as necessary to match prototype in unexec.h.
ce701a33 7658
01f44d5a
PE
7659 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7660 shadowing.
4f63c6bb 7661 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7662
a6670b0b
PE
7663 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7664 Rename locals to avoid shadowing.
7665
cef2010d 7666 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7667 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7668
d4d7173a
PE
7669 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7670
f08b802a
PE
7671 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7672 warning when compiling print.c.
7673
3ddb0639
PE
7674 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7675 instead of using an uninitialized var.
5ad03b97 7676 (font_sort_entities): Mark var as initialized.
3ddb0639 7677
170a2692
PE
7678 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7679
e663c700
PE
7680 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7681 pointers to constants.
89bc529a 7682 (font_parse_fcname): Remove unused vars.
7b81e2d0 7683 (font_delete_unmatched): Now static.
ea838e10 7684 (font_get_spec): Remove; unused.
13a547c6
PE
7685 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7686 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7687 Rename or move locals to avoid shadowing.
e663c700 7688
2a80c887 7689 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7690 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7691
1384fa33 7692 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7693 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7694
8b2c52e9
PE
7695 * alloc.c (mark_backtrace): Move decl from here ...
7696 * lisp.h: ... to here, so that it can be checked.
7697
475545b5 7698 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7699 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7700 (lisp_indirect_variable): Name an expression,
7701 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7702 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7703
b1349114 7704 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7705 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7706 Use const pointer when appropriate.
b1349114 7707
a2928364
PE
7708 * lisp.h (get_system_name, get_operating_system_release):
7709 Move decls here, to check interfaces.
7710 * process.c (get_operating_system_release): Move decl to lisp.h.
7711 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7712 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7713 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7714 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7715 (Fformat_time_string, Fencode_time, Finsert_char):
7716 (Ftranslate_region_internal, Fformat):
7717 Rename or remove local vars to avoid shadowing.
9710023e 7718 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7719
a415e694
PE
7720 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7721 avoid shadowing.
7722
8ef4622d
PE
7723 * lisp.h (eassert): Check that the argument compiles, even if
7724 ENABLE_CHECKING is not defined.
7725
946f9a5b
PE
7726 * data.c (Findirect_variable): Name an expression, to avoid
7727 gcc -Wbad-function-cast warning.
112396d6 7728 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7729 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7730 (Fmake_variable_buffer_local, Fmake_local_variable):
7731 Mark variables as initialized.
52746918 7732 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7733
e5aab7e7 7734 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7735 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7736 Rename locals to avoid shadowing.
dff45157
PE
7737 (mark_stack): Move local variables into the #ifdef region where
7738 they're used.
7bc26fdb
PE
7739 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7740 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7741 needed otherwise.
7742 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7743 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7744 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7745
e5aab7e7
PE
7746 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7747 avoids undefined behavior in theory.
7748
4da60324
PE
7749 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7750
88043301
PE
7751 Use functions, not macros, for up- and down-casing (Bug#8254).
7752 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7753 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7754 to use the following functions instead of these macros.
7755 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7756 EMACS_INT, since callers assume the returned value fits in int.
7757 (upcase1): Likewise, for UPCASE_TABLE.
7758 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7759 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7760 the race-condition problem in the old DOWNCASE.
88043301 7761
19ed5445
PE
7762 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7763 Rename locals to avoid shadowing.
7764 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7765 (regex_compile, re_search_2, re_match_2_internal):
7766 Remove unused local vars.
952db0d7
PE
7767 (FREE_VAR): Rewrite so as not to use empty "else",
7768 which gcc can warn about.
da053e48 7769 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7770 (RETALLOC_IF): Define only if needed.
7771 (WORDCHAR_P): Likewise. This one is never needed, but is used
7772 only in a comment talking about a compiler bug, so put inside
7773 the #if 0 of that comment.
7774 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7775 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7776 Remove; unused.
19ed5445 7777
1f3561e4 7778 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7779 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7780 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7781
ded6f8f7
PE
7782 * search.c (simple_search): Remove unused var.
7783
dbd37a95
PE
7784 * dired.c (compile_pattern): Move decl from here ...
7785 * lisp.h: ... to here, so that it can be checked.
7786 (struct re_registers): New forward decl.
7787
7e47afad
PE
7788 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7789
85f24f61
PE
7790 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7791 All uses changed.
7792 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7793 Rename locals to avoid shadowing.
5671df8f 7794 (Fvertical_motion): Mark locals as initialized.
85f24f61 7795
181aa2be 7796 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7797 (casify_region): Mark local as initialized.
181aa2be 7798
930d429c
PE
7799 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7800
7082eac6
PE
7801 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7802 New macros, so that the caller can use some names other than
7803 gcpro1, gcpro2, etc.
7804 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7805 of the new macros.
7806 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7807 argument, for consistency with GCPRO2_VAR, etc: it is now the
7808 prefix of the variable, not the variable itself. All uses
7809 changed.
38b2c076
PE
7810 * dired.c (directory_files_internal, file_name_completion):
7811 Rename locals to avoid shadowing.
7812
15206ed9
PE
7813 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7814 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7815 dired.c's scmp function, had undefined behavior.
7816 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7817 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7818 * buffer.h: ... to here, because these macros use current_buffer,
7819 and the new implementation with inline functions needs to have
7820 current_buffer in scope now, rather than later when the macros
7821 are used.
7822 (downcase, upcase1): New static inline functions.
7823 (DOWNCASE, UPCASE1): Reimplement using these functions.
7824 This avoids undefined behavior in expressions like
7825 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7826 from race conditions in accessing the global variables
7827 case_temp1 and case_temp2.
7828 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7829 * lisp.h (case_temp1, case_temp2): Remove their decls.
7830 * character.h (ASCII_CHAR_P): Move from here ...
7831 * lisp.h: ... to here, so that the inline functions mentioned
7832 above can use them.
7833
4a6bea26
PE
7834 * dired.c (directory_files_internal_unwind): Now static.
7835
f14b7e14
PE
7836 * fileio.c (file_name_as_directory, directory_file_name):
7837 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7838 Now static.
2893f146
PE
7839 (file_name_as_directory): Use const pointers when appropriate.
7840 (Fexpand_file_name): Likewise. In particular, newdir might
7841 point at constant storage, so make it a const pointer.
fd4ead52 7842 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7843 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7844 signedness issues.
f839df0c
PE
7845 (Fset_file_times, Finsert_file_contents, auto_save_error):
7846 Rename locals to avoid shadowing.
f14b7e14 7847
5716756e 7848 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7849 (Ftry_completion, Fall_completions): Rename or remove locals
7850 to avoid shadowing.
5716756e 7851
b4c3046a
PE
7852 * marker.c (bytepos_to_charpos): Remove; unused.
7853
b45db522
PE
7854 * lisp.h (verify_bytepos, count_markers): New decls,
7855 so that gcc does not warn that these functions aren't declared.
7856
85876d07
PE
7857 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7858 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7859 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7860 (copy_text): Remove unused local var.
85876d07 7861
03d78a21 7862 * filelock.c (within_one_second): Now static.
b3dd38ab 7863 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7864
5df8f01b
PE
7865 * buffer.c (fix_overlays_before): Mark locals as initialized.
7866 (fix_start_end_in_overlays): Likewise. This function should be
7867 simplified by using pointers-to-pointers, but that's a different
7868 matter.
b1d876f1 7869 (switch_to_buffer_1): Now static.
8f54f30a
PE
7870 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7871 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7872
a70072c9 7873 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7874 Fix pointer signedness issue.
edced198
PE
7875 (sys_subshell): Mark local as volatile if checking for lint,
7876 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7877 (MAXPATHLEN): Define only if needed.
a70072c9 7878
a0977c44
PE
7879 * process.c (serial_open, serial_configure): Move decls from here ...
7880 * systty.h: ... to here, so that they can be checked.
7881
a884fdcc
PE
7882 * fns.c (get_random, seed_random): Move extern decls from here ...
7883 * lisp.h: ... to here, so that they can be checked.
7884
604efe86 7885 * sysdep.c (reset_io): Now static.
b8950c94 7886 (wait_for_termination_signal): Remove; unused.
604efe86 7887
38fc62d9
PE
7888 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7889 (copy_keymap_item, append_key, push_text_char_description):
7890 Now static.
1004a21a 7891 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7892 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7893 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7894 (describe_map_tree):
7895 Rename locals to avoid shadowing.
38fc62d9 7896
2f2650da
PE
7897 * keyboard.c: Declare functions static if they are not used elsewhere.
7898 (echo_char, echo_dash, cmd_error, top_level_2):
7899 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7900 (read_char, kbd_buffer_get_event, make_lispy_position):
7901 (make_lispy_event, make_lispy_movement, apply_modifiers):
7902 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7903 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7904 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7905 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7906 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7907
a053e86c 7908 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7909 (mark_kboards): Move decl here ...
7910 * alloc.c (mark_kboards): ... from here.
a053e86c 7911
4752793e
PE
7912 * lisp.h (force_auto_save_soon): New decl.
7913
74f10ca7 7914 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7915 (DEFINE_DUMMY_FUNCTION): New macro.
7916 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7917 Use it.
c03cd23f
PE
7918 (main): Add casts to avoid warnings
7919 if GCC considers string literals to be constants.
74f10ca7 7920
022e70d4
PE
7921 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7922
59d6fe83
PE
7923 * dbusbind.c: Pointer signedness fixes.
7924 (xd_signature, xd_append_arg, xd_initialize):
7925 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7926 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7927 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7928 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7929
78320123
PE
7930 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7931 if GCC considers string literals to be constants.
49cebcca 7932 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7933
35ac2a97
SM
79342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7935
fb103ca9
SM
7936 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7937 (print_preprocess, print_object): New macro to fix last change.
7938
35ac2a97
SM
7939 * print.c (print_preprocess): Don't forget font objects.
7940
62973b41
JB
79412011-03-16 Juanma Barranquero <lekktu@gmail.com>
7942
7943 * emacs.c (USAGE3): Doc fixes.
7944
0e48bb22
AS
79452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7946
7947 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7948 structure.
7949
7684e57b
JB
79502011-03-14 Juanma Barranquero <lekktu@gmail.com>
7951
7952 * lisp.h (VWindow_system, Qfile_name_history):
7953 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7954 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7955 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7956
7957 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7958 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7959
7960 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7961 * w32console.c (detect_input_pending, read_input_pending)
7962 (encode_terminal_code):
7963 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7964 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7965 (w32_system_caret_y, Qfile_name_history):
7966 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7967 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7968 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7969 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7970 * w32proc.c (Qlocal, report_file_error):
7971 * w32term.c (Vwindow_system, updating_frame):
7972 * w32uniscribe.c (initialized, uniscribe_font_driver):
7973 Remove unneeded extern declarations.
7974
2aa46d6c
CY
79752011-03-14 Chong Yidong <cyd@stupidchicken.com>
7976
c96bbc66 7977 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7978
cffc6f3b
CY
79792011-03-13 Chong Yidong <cyd@stupidchicken.com>
7980
7981 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7982 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7983 These macros can no longer be used for assignment.
7984
44f230aa
SM
7985 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7986 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7987 (record_buffer_markers, fetch_buffer_markers): New functions for
7988 recording and fetching special buffer markers.
7989 (set_buffer_internal_1, set_buffer_temp): Use them.
7990
7991 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7992
7993 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7994
7995 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7996 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7997
7998 * xdisp.c (hscroll_window_tree):
7999 (reconsider_clip_changes): Use PT instead of BUF_PT.
8000
d251f04b
EZ
80012011-03-13 Eli Zaretskii <eliz@gnu.org>
8002
8003 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8004 $(EMACS_ROOT)/lib/intprops.h.
8005
f0c77cd1
PE
80062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8007
3eca4629
PE
8008 Fix more problems found by GCC 4.5.2's static checks.
8009
7c86ee98
PE
8010 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8011 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8012 (xg_free_frame_widgets): Make it clear that a local variable is
8013 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8014 (gdk_window_get_screen): Make it clear that this macro is needed
8015 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8016 (int_gtk_range_get_value): New function, which avoids a diagnostic
8017 from gcc -Wbad-function-cast.
8018 (xg_set_toolkit_scroll_bar_thumb): Use it.
8019 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8020 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8021 (get_utf8_string, xg_get_file_with_chooser):
8022 Rename locals to avoid shadowing.
8023 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8024
41729b81
PE
8025 * xgselect.c (xg_select): Remove unused var.
8026
f0c77cd1
PE
8027 * image.c (four_corners_best): Mark locals as initialized.
8028 (gif_load): Initialize transparent_p to zero (Bug#8238).
8029 Mark another local as initialized.
ec6cf4c6 8030 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8031
ce0ad53d 8032 * image.c (clear_image_cache): Now static.
d5d5a617 8033 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8034 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8035 (x_edge_detection): Remove unnecessary cast that
8036 gcc -Wbad-function-cast diagnoses.
2037898d 8037 (gif_load): Fix pointer signedness.
6ae141d6
PE
8038 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8039 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8040
33383987 80412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8042
d32df629
PE
8043 Improve quality of tests for time stamp overflow.
8044 For example, without this patch (encode-time 0 0 0 1 1
8045 1152921504606846976) returns the obviously-bogus value (-948597
8046 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8047 reports time overflow. See
8048 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8049 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8050 * editfns.c: Include limits.h and intprops.h.
8051 (TIME_T_MIN, TIME_T_MAX): New macros.
8052 (time_overflow): Move earlier, to before first use.
8053 (hi_time, lo_time): New functions, for an accurate test for
8054 out-of-range times.
8055 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8056 (Fget_internal_run_time): Don't assume time_t fits in int.
8057 (make_time): Use list2 instead of Fcons twice.
8058 (Fdecode_time): More accurate test for out-of-range times.
8059 (check_tm_member): New function.
8060 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8061 (lisp_time_argument): Don't rely on undefined left-shift and
8062 right-shift behavior when checking for time stamp overflow.
8be6f318 8063
fe31d94c
PE
8064 * editfns.c (time_overflow): New function, refactoring common code.
8065 (Fformat_time_string, Fdecode_time, Fencode_time):
8066 (Fcurrent_time_string): Use it.
8067
8be6f318
PE
8068 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8069 * dired.c (make_time): Move to ...
8070 * editfns.c (make_time): ... here.
8071 * systime.h: Note the move.
8072
09d9db2c 80732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8074
126bc0dc
YM
8075 * fringe.c (update_window_fringes): Remove unused variables.
8076
c47cbdfd
YM
8077 * unexmacosx.c (copy_data_segment): Also copy __got section.
8078 (Bug#8223)
8079
7ac80be9
EZ
80802011-03-12 Eli Zaretskii <eliz@gnu.org>
8081
c96bbc66 8082 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8083 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8084 Constify `char *' arguments and their references according to
8085 prototypes in tparam.h.
8086
ecb0f94d 8087 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8088
7ac80be9
EZ
8089 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8090 Adapt all references accordingly.
8091
8092 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8093
ef1fd07e
TT
80942011-03-11 Tom Tromey <tromey@redhat.com>
8095
8096 * buffer.c (syms_of_buffer): Remove obsolete comment.
8097
7ef4b50c
EZ
80982011-03-11 Eli Zaretskii <eliz@gnu.org>
8099
8100 * termhooks.h (encode_terminal_code): Declare prototype.
8101
8102 * msdos.c (encode_terminal_code): Don't declare prototype.
8103
8104 * term.c (encode_terminal_code): Now external again, used by
8105 w32console.c and msdos.c.
8106
44f230aa
SM
8107 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8108 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8109
4b1ec863 81102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8111
1714f52b 8112 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8113
4b1ec863
PE
8114 * fringe.c (update_window_fringes): Mark locals as initialized
8115 (Bug#8227).
8116 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8117
524c7aa6
PE
8118 * alloc.c (mark_fringe_data): Move decl from here ...
8119 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8120 to check its interface.
8121 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8122
a5c0af81 8123 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8124 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8125 (fontset_font): Mark local as initialized.
a9a06e0b 8126 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8127
b4716021
PE
8128 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8129
811e9bac 8130 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8131 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8132 (x_own_selection, Fx_disown_selection_internal): Rename locals
8133 to avoid shadowing.
8134 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8135
7e3ab302
PE
8136 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8137 so that the caller can use some name other than gcpro1.
8138 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8139 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8140 (Fx_backspace_delete_keys_p):
8141 Use them to avoid shadowing, and rename vars to avoid shadowing.
8142 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8143 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8144 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8145 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8146 Remove unused locals.
7e3ab302
PE
8147 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8148 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8149 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8150 macros.
f78faa98 8151
e2b13473
PE
8152 * xterm.h (x_mouse_leave): New decl.
8153
77f23912
PE
8154 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8155 Remove unused functions.
cdf4ba58
PE
8156 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8157 (x_calc_absolute_position): Now static.
7411c686 8158 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8159 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8160 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8161 unless they are used.
38d0b34a
PE
8162 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8163 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8164 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8165 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8166 (x_error_catcher, x_connection_closed, x_error_handler):
8167 (x_error_quitter, xembed_send_message, x_iconify_frame):
8168 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8169 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8170 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8171
44f230aa
SM
8172 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8173 Rename or move locals to avoid shadowing.
6b463e58 8174 (tty_defined_color, merge_face_heights): Now static.
5967d051 8175 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8176 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8177 does not deduce is never used uninitialized.
73719eba
PE
8178 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8179 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8180
426994c3 8181 * terminal.c (store_terminal_param): Now static.
5489860b 8182
032f1620 8183 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8184 (set_frame_menubar): Remove unused local.
d4323972 8185 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8186 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8187 since they might point to immutable storage.
281585b0
PE
8188 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8189 since it's unused otherwise.
032f1620 8190
367c19e5 8191 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8192 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8193 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8194 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8195 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8196 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8197 does not deduce are never used uninitialized.
70739cbe 8198
07b48fa9
PE
8199 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8200
8868a238 8201 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8202 * window.c (window_loop, size_window):
8203 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8204
7e5cf297 8205 * window.c (display_buffer): Now static.
d6550a9f
PE
8206 (size_window): Mark variables that gcc -Wuninitialized
8207 does not deduce are never used uninitialized.
a586633d
PE
8208 * window.h (check_all_windows): New decl, to forestall
8209 gcc -Wmissing-prototypes diagnostic.
5b555da1 8210 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8211
f6095868
PE
8212 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8213 shadowing.
8214 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8215 Include <limits.h>.
8216 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8217 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8218 (load_charset_map): Mark variables that gcc -Wuninitialized
8219 does not deduce are never used uninitialized.
53df7c11 8220 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8221
f38b440c
PE
8222 * coding.c (coding_set_source, coding_set_destination):
8223 Use "else { /* comment */ }" rather than "else /* comment */;"
8224 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8225 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8226 a block, when the outer 'i' will do.
8227 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8228 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8229 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8230 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8231 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8232 Rename locals to avoid shadowing.
8233 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8234 * coding.c (emacs_mule_char, encode_invocation_designation):
8235 Now static, since they're not used elsewhere.
413bb2db 8236 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8237 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8238 (decode_coding_emacs_mule): Mark variables that gcc
8239 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8240 (detect_coding_iso_2022): Initialize a local variable that might
8241 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8242 this initialization is needed. (Bug#8211)
5f58e762
PE
8243 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8244 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8245 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8246 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8247 Remove unused macros.
f38b440c 8248
232b38b9 8249 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8250 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8251 * character.c (string_count_byte8): Likewise.
232b38b9 8252
fb90da1b
PE
8253 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8254 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8255
fb93dbc2
PE
8256 * chartab.c (copy_sub_char_table): Now static, since it's not used
8257 elsewhere.
5c156ace
PE
8258 (sub_char_table_ref_and_range, char_table_ref_and_range):
8259 Rename locals to avoid shadowing.
bbcd0949 8260 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8261
7d3b3862 8262 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8263 (BIDI_BOB): Remove unused macro.
7d3b3862 8264
6be7d3da
PE
8265 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8266 deduce are never used uninitialized.
c2ed9c8b 8267 * term.c (encode_terminal_code): Likewise.
6be7d3da 8268
75f8807f 8269 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8270
50938595
PE
8271 * tparam.h: New file.
8272 * term.c, tparam.h: Include it.
8273 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8274 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8275 Move these decls to tparam.h, and make them agree with what
8276 is actually in tparam.c. The previous trick of using incompatible
8277 decls in different modules does not conform to the C standard.
8278 All callers of tparam changed to use tparam's actual API.
8279 * tparam.c (tparam1, tparam, tgoto):
8280 Use const pointers where appropriate.
8281
fbceeba2
PE
8282 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8283 * cm.h (struct cm): Likewise.
8284 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8285 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8286 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8287 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8288 (turn_on_face, init_tty): Likewise.
8289 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8290
7f3f1250
PE
8291 * term.c (term_mouse_position): Rename local to avoid shadowing.
8292
e6ca6543
PE
8293 * alloc.c (mark_ttys): Move decl from here ...
8294 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8295
c40f8d15
AS
82962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8297
8298 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8299
cfe0661d
JB
83002011-03-09 Juanma Barranquero <lekktu@gmail.com>
8301
8302 * search.c (compile_pattern_1): Remove argument regp, unused since
8303 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8304 (compile_pattern): Don't pass it.
8305
0afb4571
J
83062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8307
8308 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8309 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8310 for ! HAVE_GTK3.
8311 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8312
8313 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8314
8315 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8316 gdk_window_get_screen, gdk_window_get_geometry,
8317 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8318 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8319 (xg_get_pixbuf_from_pixmap): New function.
8320 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8321 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8322 Call xg_get_pixbuf_from_pixmap instead of
8323 gdk_pixbuf_get_from_drawable.
8324 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8325 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8326 (xg_check_special_colors): Use GtkStyleContext and its functions
8327 for HAVE_GTK3.
8328 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8329 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8330 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8331 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8332 Call gtk_widget_get_preferred_size.
0afb4571
J
8333 (xg_frame_resized): gdk_window_get_geometry only takes 5
8334 parameters.
44f230aa
SM
8335 (xg_win_to_widget, xg_event_is_for_menubar):
8336 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8337 (xg_set_widget_bg): New function.
8338 (delete_cb): New function.
895009e1 8339 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8340 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8341 (xg_set_background_color): Call xg_set_widget_bg.
8342 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8343 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8344 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8345 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8346 if ! HAVE_GTK3.
8347 (update_frame_tool_bar): Call gtk_widget_hide.
8348 (xg_initialize): Use GDK_KEY_g.
8349
8350 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8351 if ! HAVE_GTK3
8352 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8353
8354 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8355 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8356 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8357
1c2cc4ef
JB
83582011-03-08 Juanma Barranquero <lekktu@gmail.com>
8359
8360 * w32xfns.c (select_palette): Check success of RealizePalette against
8361 GDI_ERROR, not zero.
8362
33383987 8363See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8364
8365;; Local Variables:
8366;; coding: utf-8
aac0c6e3
MR
8367;; End:
8368
33383987 8369 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8370
8371 This file is part of GNU Emacs.
8372
8373 GNU Emacs is free software: you can redistribute it and/or modify
8374 it under the terms of the GNU General Public License as published by
8375 the Free Software Foundation, either version 3 of the License, or
8376 (at your option) any later version.
8377
8378 GNU Emacs is distributed in the hope that it will be useful,
8379 but WITHOUT ANY WARRANTY; without even the implied warranty of
8380 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8381 GNU General Public License for more details.
8382
8383 You should have received a copy of the GNU General Public License
8384 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.