merge trunk
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0902a04e
KH
12011-08-22 Kenichi Handa <handa@m17n.org>
2
3 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4 extra slot even if the purpose is char-code-property-table.
5
1a2e6670
EZ
62011-08-23 Eli Zaretskii <eliz@gnu.org>
7
8ddde651
EZ
8 * xdisp.c (redisplay_window): When computing centering_position,
9 account for the height of the header line. (Bug#8874)
10
425cc014
EZ
11 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
12 instead of CHAR_TO_BYTE. Fixes a crash when a completion
13 candidate is selected by the mouse, and that candidate has a
14 composed character under the mouse.
15
1a2e6670
EZ
16 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
17 coordinates reported by pos-visible-in-window-p for a composed
18 character in column zero.
19
8b76d6f8
SM
202011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
21
22 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
23
dac347dd
EZ
242011-08-22 Eli Zaretskii <eliz@gnu.org>
25
26 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
27 consider it a hit if to_charpos is anywhere in the range of the
28 composed buffer positions.
29
e013fb34
CY
302011-08-22 Chong Yidong <cyd@stupidchicken.com>
31
32 * image.c (gif_load): Don't assume that each subimage has the same
33 dimensions as the base image. Handle disposal method that is
34 "undefined" by the gif spec (Bug#9335).
35
bd1ba3e8
CY
362011-08-20 Chong Yidong <cyd@stupidchicken.com>
37
38 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 39 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 40
54a1215b
EZ
412011-08-19 Eli Zaretskii <eliz@gnu.org>
42
823564e5
EZ
43 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
44 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
45 from an Org mode buffer to a Speedbar frame.
46
54a1215b
EZ
47 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
48 a composition, take its buffer position from IT->cmp_it.charpos.
49 Fixes cursor positioning at the beginning of a line that begins
50 with a composed character.
51
9778ebcc
EZ
522011-08-18 Eli Zaretskii <eliz@gnu.org>
53
0be6ee06
EZ
54 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
55 character bidirectional type, use STRONG_L instead. Fixes crashes
56 in a buffer produced by `describe-categories'.
57
9778ebcc
EZ
58 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
59 members before the level stack, so they would be saved and
60 restored when copying iterator state. Fixes incorrect reordering
61 around TABs covered by display properties.
62
156bffbe
AS
632011-08-18 Andreas Schwab <schwab@linux-m68k.org>
64
65 * process.c (Fnetwork_interface_list): Correctly determine buffer
66 size.
67
72ad093b
CY
682011-08-17 Chong Yidong <cyd@stupidchicken.com>
69
70 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
71 (internal_condition_case_2, internal_condition_case_n):
72 Remove unnecessary aborts (Bug#9081).
72ad093b 73
35774242
EZ
742011-08-17 Eli Zaretskii <eliz@gnu.org>
75
76 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
77 has no `load' handler, try opening the file locally. (Bug#9311)
78
db76dd85
KB
792011-08-16 Ken Brown <kbrown@cornell.edu>
80
81 * gmalloc.c: Expand comment.
82
b215eee5
EZ
832011-08-16 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
86 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
87
a4579d33
KB
882011-08-16 Ken Brown <kbrown@cornell.edu>
89
90 Fix memory allocation problems in Cygwin build (Bug#9273).
91
92 * unexcw.c ( __malloc_initialized): Declare external variable.
93 (fixup_executable): Force the dumped emacs to reinitialize malloc.
94
8b76d6f8
SM
95 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
96 New variables.
a4579d33
KB
97 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
98 dumped emacs.
99 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
100 in the static heap.
101 [CYGWIN] (special_realloc): New function.
102 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
103 requests to realloc storage in the static heap.
104
3ebec551
PE
1052011-08-15 Paul Eggert <eggert@cs.ucla.edu>
106
107 * bidi.c (bidi_initialize): Remove unused local.
108
9fd8be00
EZ
1092011-08-15 Eli Zaretskii <eliz@gnu.org>
110
474a8465
EZ
111 * biditype.h: File removed.
112
113 * bidimirror.h: File removed.
114
115 * deps.mk (bidi.o): Remove biditype.h and
116 bidimirror.h.
117
118 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
119 bidimirror.h.
120
121 * dispextern.h: Fix a typo in the comment to bidi_type_t.
122
123 * chartab.c: Improve commentary for the uniprop_table API.
124
32413314
EZ
125 * bidi.c (bidi_paragraph_init): Support zero value of
126 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
127 (bidi_initialize): Use uniprop_table instead of including
128 biditype.h and bidimirror.h.
32413314 129
9fd8be00
EZ
130 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
131 coordinates of the iterator when restoring from ppos_it.
132 (Bug#9296)
133
5cf2b69b
KH
1342011-08-14 Kenichi Handa <handa@m17n.org>
135
136 * process.c (create_process): Call setup_process_coding_systems
72ad093b 137 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 138
daf17d00
EZ
1392011-08-14 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (move_it_in_display_line_to): Don't invoke
142 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
143 ppos_it. Fixes vertical cursor motion when line beginning is
144 covered by an image. (Bug#9296)
145
08e3161a
JD
1462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
147
148 * nsterm.h (ns_run_ascript): Declare.
149 (NSAPP_DATA2_RUNASSCRIPT): Define.
150
151 * nsfns.m (as_script, as_result, as_status): New static variables.
152 (ns_run_ascript): New function.
153 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
154 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
155 the event loop. Get status from as_status (Bug#7276).
156
157 * nsterm.m (sendEvent): If event is NSApplicationDefined and
158 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
159 the event loop (Bug#7276).
160
a3720aa2
AS
1612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
162
163 * gnutls.c (QCgnutls_bootprop_priority)
164 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
165 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
166 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
167 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
168 (QCgnutls_bootprop_verify_hostname_error)
169 (QCgnutls_bootprop_callbacks_verify): Rename from
170 Qgnutls_bootprop_..., all uses changed.
171
172 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
173 uses changed.
174
0a0d27fb
PE
1752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
176
19d5c50c
PE
177 * xfaces.c (Qframe_set_background_mode): Now static.
178 * dispextern.h (Qframe_set_background_mode): Remove decl.
179
0a0d27fb
PE
180 * process.c (Fnetwork_interface_info): Declare local only if needed.
181
377538cb
JD
1822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
183
184 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
185 (Fnetwork_interface_list): Allocate in increments of bytes instead
186 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
187 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
188 sockaddr.
189 (struct ifflag_def): notrailers is smart on OSX.
190 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
191 Get hardware address with getifaddrs if available.
192
08fff70c
EZ
1932011-08-12 Eli Zaretskii <eliz@gnu.org>
194
195 * xdisp.c (iterate_out_of_display_property): xassert that
196 IT->position is set to within IT->object's boundaries. Break from
197 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
198 when IT->position is set up wrongly due to some bug.
199 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
200 (push_display_prop): Allow GET_FROM_STRING as IT->method on
201 entry. Force push_it to save on the stack the current
202 buffer/string position, to be restored by pop_it. Fix flags in
203 the iterator structure wrt the object coming from a display
204 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
205 properties. (Bug#9284)
206
7be1c708 2072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 208
7be1c708
CY
209 * fontset.c (fontset_get_font_group): Add proper type checks.
210 (Bug#9172)
aac0c6e3 211
7be1c708 2122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 213
7be1c708
CY
214 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
215 and LC_VERSION_MIN_MACOSX.
216 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
217 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 218
97bb72a6
EZ
2192011-08-08 Eli Zaretskii <eliz@gnu.org>
220
221 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
222 no-display-properties-and-no-overlays under bidi display.
223 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 224 properties and overlays.
97bb72a6 225
d5617611
CY
2262011-08-08 Chong Yidong <cyd@stupidchicken.com>
227
37e11a63
CY
228 * editfns.c (Fset_time_zone_rule): Document relationship with the
229 setenv function.
230
d5617611
CY
231 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
232 the font entity extracted from the cache (Bug#8109).
233
58872834
CY
2342011-08-07 Chong Yidong <cyd@stupidchicken.com>
235
236 * composite.c (autocmp_chars): Don't reset point. That is done by
237 restore_point_unwind (Bug#5984).
238
75bfc667
JL
2392011-08-07 Juri Linkov <juri@jurta.org>
240
241 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
242 to show the arg `TIME' instead of `TIMEVAL'.
243
d1410150
EZ
2442011-08-06 Eli Zaretskii <eliz@gnu.org>
245
246 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
247 display property strides EOL and includes a newline, as in
248 longlines-mode. (Bug#9254)
75b771e4
EZ
249 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
250 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
251
252 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
253 is non-zero, even if the data buffer is NULL. Fixes a crash in
254 vertical-motion with longlines-mode. (Bug#9254)
255
35928349
EZ
2562011-08-05 Eli Zaretskii <eliz@gnu.org>
257
ec7cc85b
EZ
258 * bidi.c <bidi_cache_total_alloc>: Now static.
259 (bidi_initialize): Initialize bidi_cache_total_alloc.
260
8b76d6f8 261 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
262 cache. (Bug#9221)
263
264 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
265 amount allocated this far in `bidi_cache_total_alloc'.
266 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
267 non-zero, only free the data buffer without restoring the cache
268 contents. All callers changed.
269
270 * dispextern.h (bidi_unshelve_cache): Update prototype.
271
272 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
273 (move_it_in_display_line, move_it_to)
274 (move_it_vertically_backward, move_it_by_lines): Replace the call
275 to xfree to an equivalent call to bidi_unshelve_cache.
276 (move_it_in_display_line_to): Fix logic of returning
412b6358 277 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 278
e2e2423b
EZ
2792011-08-05 Eli Zaretskii <eliz@gnu.org>
280
281 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
282 came from a string character with a `cursor' property. (Bug#9229)
283
ae9e757a
JD
2842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
285
286 * Makefile.in (LIB_PTHREAD): New variable.
287 (LIBES): Add LIB_PTHREAD (Bug#9216).
288
289 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
290 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
291
213bd7f2
AS
2922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
293
294 * regex.c (re_iswctype): Remove some redundant boolean
295 conversions.
296
99aaf75f
JD
2972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
298
299 * xterm.c (x_find_topmost_parent): New function.
300 (x_set_frame_alpha): Find topmost parent window with
301 x_find_topmost_parent and set the property there also (bug#9181).
302 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
303
c74e9d86
PE
3042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
305
306 * callproc.c (Fcall_process): Avoid vfork clobbering
307 the local vars buffer, coding_systems, current_dir.
308
640c8776
SM
3092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
310
311 * keymap.c (Fmake_composed_keymap): Move to subr.el.
312
f26d0e4c
PE
3132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
314
8a10d76c
PE
315 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
316 so that it is not optimized away.
317
f26d0e4c
PE
318 * xdisp.c (compute_display_string_pos): Remove unused local.
319
55439c61
EZ
3202011-08-02 Eli Zaretskii <eliz@gnu.org>
321
322 Fix slow cursor motion and scrolling in large buffers with
323 selective display, like Org Mode buffers. (Bug#9218)
324
325 * dispextern.h (struct bidi_it): New member disp_prop_p.
326
327 * xdisp.c: Remove one-slot cache of display string positions.
328 (compute_display_string_pos): Accept an additional argument
329 DISP_PROP_P; callers changed. Scan at most 5K characters forward
330 for a display string or property. If found, set DISP_PROP_P
331 non-zero.
332
333 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
334 DISP_PROP_P, and pass it to compute_display_string_pos.
335 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
336 non-zero. All callers of bidi_fetch_char changed.
337
fb33fa43
SM
3382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
339
340 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
341
b099e063
DM
3422010-12-03 Don March <don@ohspite.net>
343
344 * keymap.c (Fdefine_key): Fix non-prefix key error message when
345 last character M-[char] is translated to ESC [char] (bug#7541).
346
5cc7f7af
KH
3472011-08-02 Kenichi Handa <handa@m17n.org>
348
d0fffa3f 349 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
350
351 * chartab.c (uniprop_table): Make it non-static.
352
525d5e6e
EZ
3532011-08-01 Eli Zaretskii <eliz@gnu.org>
354
355 * xdisp.c (forward_to_next_line_start): Accept additional argument
356 BIDI_IT_PREV, and store into it the state of the bidi iterator had
357 on the newline.
358 (reseat_at_next_visible_line_start): Use the bidi iterator state
359 returned by forward_to_next_line_start to restore the state of
360 it->bidi_it after backing up to previous newline. (Bug#9212)
361
31011111
AS
3622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
363
364 * regex.c (re_comp): Protoize.
365 (re_exec): Fix return type.
366 (regexec): Fix type of `ret'. (Bug#9203)
367
e5d76069
PE
3682011-07-29 Paul Eggert <eggert@cs.ucla.edu>
369
370 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
371 This is needed if max-image-size is a floating-point number.
372
9a79b20c
AS
3732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
374
375 * print.c (print_object): Print empty symbol as ##.
376
377 * lread.c (read1): Read ## as empty symbol.
378
d8c2fa78
AA
3792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
380
381 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
382 setting frame foreground color (Bug#9175).
383 (x_set_background_color): Likewise.
384
ffe57a7a
AA
385 * nsmenu.m (-setText): Size tooltip dimensions precisely to
386 contents (Bug#9176).
387 (EmacsTooltip -init): Remove bezels and add shadows to
388 tooltip windows.
389
bf3492a5
AA
390 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
391 or scroll bar (Bug#8470).
392
d55e9c53
AA
393 * nsfont.m (nsfont_open): Remove assignment to voffset and
394 unnecessary vars hshink, expand, hd, full_height, min_height.
395 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
396
397 * nsterm.h (nsfont_info): Remove voffset field.
398
d8c2fa78 3992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
400
401 Implement strike-through and overline on NextStep (Bug#8863).
402
403 * nsfont.m (nsfont_open): Use underline position provided by font,
404 instead of hard-coded value of 2.
405 (nsfont_draw): Call ns_draw_text_decoration instead.
406
407 * nsterm.h: Add declaration for ns_draw_text_decoration.
408
409 * nsterm.m (ns_draw_text_decoration): New function for drawing
410 underline, overline, and strike-through.
411 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
412 ns_draw_text_decoration. Change treatment of cursor drawing to
413 accomodate underlining, etc.
414
4cc60b9b
EZ
4152011-07-28 Eli Zaretskii <eliz@gnu.org>
416
bc7ece87
EZ
417 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
418 default.
4cc60b9b 419
476371c4
PE
4202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
421
66606eea
PE
422 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
423 Without this fix, if a signal arrives just after memory fills up,
424 'malloc' might be invoked reentrantly.
425
476371c4
PE
426 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
427 In other words, assume that every image size is allowed, on non-X
428 hosts. This assumption is probably wrong, but it lets Emacs compile.
429
f3fcc40d
AS
4302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
431
432 * regex.c (re_iswctype): Convert return values to boolean.
433
350c992f
EZ
4342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
435
436 * xdisp.c (compute_display_string_pos): Don't use cached display
437 string position if the buffer had its restriction changed.
438 (Bug#9184)
439
5266b4bb
PE
4402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
441
442 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
443
2573a837 4442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 445
41f55ccd 446 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 447
39e378da
PE
448 * bidi.c: Integer size and overflow fixes.
449 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
450 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
451 (bidi_cache_find_level_change, bidi_cache_ensure_space)
452 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
453 (bidi_find_other_level_edge):
454 Use ptrdiff_t instead of EMACS_INT where either will do.
455 This works better on 32-bit hosts configured --with-wide-int.
456 (bidi_cache_ensure_space): Check for size-calculation overflow.
457 Use % rather than repeated addition, for better worst-case speed.
458 Don't set bidi_cache_size until after xrealloc returns, because it
459 might not return.
460 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
461 (bidi_cache_ensure_space): Also check that the bidi cache size
462 does not exceed that of the largest Lisp string or buffer. See Eli
463 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 464
5e927815
PE
465 * alloc.c (__malloc_size_t): Remove.
466 All uses replaced by size_t. See Andreas Schwab's note
467 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
468
ca4aa935
PE
469 * image.c: Improve checking for integer overflow.
470 (check_image_size): Assume that f is nonnull, since
471 it is always nonnull in practice. This is one less thing to
472 worry about when checking for integer overflow later.
473 (x_check_image_size): New function, which checks for integer
474 overflow issues inside X.
475 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
476 This removes the need for a memory_full check.
477 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
478 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
479 (xbm_read_bitmap_data): Change locals back to 'int', since
480 their values must fit in 'int'.
481 (xpm_load_image, png_load, tiff_load):
482 Invoke x_create_x_image_and_pixmap earlier,
483 to avoid much needless work if the image is too large.
484 (tiff_load): Treat overly large images as if
485 x_create_x_image_and_pixmap failed, not as malloc failures.
486 (gs_load): Use x_check_image_size.
487
5f8f9cc2
PE
488 * gtkutil.c: Omit integer casts.
489 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
490 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
491
5adf60bc
PE
492 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
493
c8907a93
PE
494 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
495 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
496 would wrongly return t on a 64-bit host.
497
e3c25c68
PE
498 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
499 The plain *_OVERFLOW macros run afoul of GCC bug 49705
500 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
501 and therefore cause GCC to emit a bogus diagnostic in some cases.
502
3f791afe
PE
503 * image.c: Integer signedness and overflow and related fixes.
504 This is not an exhaustive set of fixes, but it's time to
505 record what I've got.
506 (lookup_pixel_color, check_image_size): Remove redundant decls.
507 (check_image_size): Don't assume that arbitrary EMACS_INT values
508 fit in 'int', or that arbitrary 'double' values fit in 'int'.
509 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
510 (tiff_load, imagemagick_load_image):
511 Check for overflow in size calculations.
512 (x_create_x_image_and_pixmap): Remove unnecessary test for
513 xmalloc returning NULL; that can't happen.
514 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
515 (xpm_color_bucket): Use better integer hashing function.
516 (xpm_cache_color): Don't possibly over-allocate memory.
517 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
518 (gif_memory_source):
519 Use ptrdiff_t, not int or size_t, to record sizes.
520 (png_load): Don't assume values greater than 2**31 fit in 'int'.
521 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
522 either works, as we prefer signed integers.
523 (tiff_read_from_memory, tiff_write_from_memory):
524 Return tsize_t, not size_t, since that's what the TIFF API wants.
525 (tiff_read_from_memory): Don't fail simply because the read would
526 go past EOF; instead, return a short read.
527 (tiff_load): Omit no-longer-needed casts.
528 (Fimagemagick_types): Don't assume size fits into 'int'.
529
3cc5a532
PE
530 Improve hashing quality when configured --with-wide-int.
531 * fns.c (hash_string): New function, taken from sxhash_string.
532 Do not discard information about ASCII character case; this
533 discarding is no longer needed.
534 (sxhash-string): Use it. Change sig to match it. Caller changed.
535 * lisp.h: Declare it.
536 * lread.c (hash_string): Remove, since we now use fns.c's version.
537 The fns.c version returns a wider integer if --with-wide-int is
538 specified, so this should help the quality of the hashing a bit.
539
b312a492
PE
540 * emacs.c: Integer overflow minor fix.
541 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
542 Define only if GNU_LINUX.
543 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
544
dfd153ae
PE
545 * dispnew.c: Integer signedness and overflow fixes.
546 Remove unnecessary forward decls, that were a maintenance hassle.
547 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
548 All uses changed.
549 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
550 (scrolling_window): Use ptrdiff_t, not int, for byte count.
551 (prepare_desired_row, line_draw_cost):
552 Use int, not unsigned, where either works.
553 (save_current_matrix, restore_current_matrix):
554 Use ptrdiff_t, not size_t, where either works.
555 (init_display): Check for overflow more accurately, and without
556 relying on undefined behavior.
557
a81d11a3
PE
558 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
559 Remove, replacing with the new symbols in lisp.h. All uses changed.
560 * fileio.c (make_temp_name):
561 * filelock.c (lock_file_1, lock_file):
562 * xdisp.c (message_dolog):
563 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
564 Use pMd etc. instead.
565 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
566 replacing the pWIDE etc. symbols removed from editfns.c.
567
3300e6fd
PE
568 * keyboard.h (num_input_events): Now uintmax_t.
569 This is (very slightly) less likely to mess up due to wraparound.
570 All uses changed.
571
fd05c7e9
PE
572 * buffer.c: Integer signedness fixes.
573 (alloc_buffer_text, enlarge_buffer_text):
574 Use ptrdiff_t rather than size_t when either will do, as we prefer
575 signed integers.
576
903fe15d
PE
577 * alloc.c: Integer signedness and overflow fixes.
578 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
579 (__malloc_size_t): Default to size_t, not to int.
580 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
581 (Fgarbage_collect, mark_object_loop_halt, mark_object):
582 Prefer ptrdiff_t to size_t when either would do, as we prefer
583 signed integers.
584 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
585 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
586 Now const. Initialize with values that are in range even if char
587 is signed.
588 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
589 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
590 These functions do the right thing with sizes > 2**32.
591 (check_depth): Now ptrdiff_t, not int.
592 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
593 Adjust to new way of storing sizes. Check for size overflow bugs
594 in rest of code.
595 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
596 slightly wrong anyway, as it missed one instance of
597 XMALLOC_OVERRUN_CHECK_OVERHEAD.
598 (refill_memory_reserve): Omit needless cast to size_t.
599 (mark_object_loop_halt): Mark as externally visible.
600
ac82cc6a
PE
601 * xselect.c: Integer signedness and overflow fixes.
602 (Fx_register_dnd_atom, x_handle_dnd_message):
603 Use ptrdiff_t, not size_t, since we prefer signed.
604 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
605 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
606 x_dnd_atoms_size and x_dnd_atoms_length.
607
c2d1e36d
PE
608 * doprnt.c: Prefer signed to unsigned when either works.
609 * eval.c (verror):
610 * doprnt.c (doprnt):
611 * lisp.h (doprnt):
612 * xdisp.c (vmessage):
613 Use ptrdiff_t, not size_t, when using or implementing doprnt,
614 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
615 prefer signed arithmetic to avoid comparison confusion.
616 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
617 but is a bit tricky.
618
0e926e56
PE
619 Assume freestanding C89 headers, string.h, stdlib.h.
620 * data.c, doprnt.c, floatfns.c, print.c:
621 Include float.h unconditionally.
622 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
623 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
624 * regex.c: Likewise for stddef.h, string.h.
625 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
626 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
627 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
628 (STDC_HEADERS): Remove obsolete defines.
629 * sysdep.c: Include limits.h unconditionally.
630
9cfdb3ec
PE
631 Assume support for memcmp, memcpy, memmove, memset.
632 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
633 * regex.c (memcmp, memcpy):
634 Remove; we assume C89 now.
635
636 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
637 (__malloc_safe_bcopy): Remove; no longer needed.
638
cf950e6b 639 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
640 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
641 well either way, and we prefer signed to unsigned.
642
dbf38e02
LMI
6432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
644
645 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
646 closes the connection while we're reading (bug#9182).
647
d6f0886c
JD
6482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
649
650 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
651 are specified (Bug#9168).
652
2eb1f9e6
PE
6532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
654
655 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
656 Found by GCC static checking and --with-wide-int on a 32-bit host.
657
22381272 6582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
659
660 * xdisp.c (compute_display_string_pos): Fix logic of caching
661 previous display string position. Initialize cached_prev_pos to
662 -1. Fixes slow-down at the beginning of a buffer.
663
f25e39b4
EZ
6642011-07-24 Eli Zaretskii <eliz@gnu.org>
665
666 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
667 for attrs[LFACE_FONTSET_INDEX].
668
04c4b52e
PE
6692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
670
671 * xml.c (parse_region): Remove unused local
672 that was recently introduced.
673
c1734fbd
EZ
6742011-07-23 Eli Zaretskii <eliz@gnu.org>
675
be18c5a5
EZ
676 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
677 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
678
c1734fbd
EZ
679 * xdisp.c (move_it_in_display_line_to): Record the best matching
680 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
681 exit if none of the characters scanned was an exact match.
682 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
683 when exact match is impossible due to invisible text, and the
684 lines are truncated.
685
a258d627
JD
6862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
687
688 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
689 for OSX >= 10.7.
690
b6d5a689
EZ
6912011-07-22 Eli Zaretskii <eliz@gnu.org>
692
0f74f785
EZ
693 Fix a significant slow-down of cursor motion with C-n, C-p,
694 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
695 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 696 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
697 (next_element_from_buffer): Call compute_stop_pos_backwards to
698 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
699 base_level_stop.
700 (reseat): Don't look for prev_stop, as that could mean a very long
701 run.
702 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
703 <cached_disp_overlay_modiff>: Cache for last found display string
704 position.
551918c1 705 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
706 about the same buffer in the same area of character positions, and
707 the buffer wasn't changed since the time the display string
708 position was cached.
551918c1 709
b2d0c91a
EZ
7102011-07-22 Eli Zaretskii <eliz@gnu.org>
711
712 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
713 is an integer, which is important for empty lines. (Bug#9149)
714
043604ee
CY
7152011-07-22 Chong Yidong <cyd@stupidchicken.com>
716
717 * frame.c (Fmodify_frame_parameters): In tty case, update the
718 default face if necessary (Bug#4238).
719
da4adb04
CY
7202011-07-21 Chong Yidong <cyd@stupidchicken.com>
721
722 * editfns.c (Fstring_to_char): No need to explain what a character
723 is in the docstring (Bug#6576).
724
9abd0532
LMI
7252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
726
727 * xml.c (parse_region): Make sure we always return a tree.
728
36881d16
HK
7292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
730
731 * xml.c (parse_region): If a document contains only comments,
732 return that, too.
733
1e98674d
LMI
7342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
735
736 * xml.c (make_dom): Return comments, too.
737
590bd467
PE
7382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
739
740 Port to OpenBSD.
741 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
742 and the surrounding thread.
743 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
744 rather than fgets, and retry after EINTR. Otherwise, 'emacs
745 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
746 timer goes off.
747 * s/openbsd.h (BROKEN_SIGIO): Define.
748 * unexelf.c (unexec) [__OpenBSD__]:
749 Don't update the .mdebug section of the Alpha COFF symbol table.
750
f41628b2
LMI
7512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
752
753 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
754 (bug#8460).
755
b59b67c5
PE
7562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
757
15e3a074
PE
758 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
759 This fixes some race conditions on the permissions of any newly
760 created file.
761
41bed37d
PE
762 * alloc.c (valid_pointer_p): Use pipe, not open.
763 This fixes some permissions issues when debugging.
764
b59b67c5
PE
765 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
766 If fchown fails to set both uid and gid, try to set just gid,
767 as that is sometimes allowed. Adjust the file's mode to eliminate
768 setuid or setgid bits that are inappropriate if fchown fails.
769
925a6be7
SM
7702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
771
772 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
773 to compare Lisp_Objects.
774 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
775 global_gnutls_log_level, don't mistake it for a Lisp_Object.
776 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
777
52968808
AS
7782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
779
0a6a104b
AS
780 * lread.c (read_integer): Unread even EOF character.
781 (read1): Likewise. Properly record start position of symbol.
782
52968808
AS
783 * lread.c (read1): Read `#:' as empty uninterned symbol if no
784 symbol character follows.
785
9e381cdd
PE
7862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
787
788 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
789 This works around a problem with the previous change to Fcopy_file.
790 Recent glibc declares fchown with __attribute__((warn_unused_result)),
791 and without this change, GCC might complain about discarding
792 fchown's return value.
793
b5641435
JB
7942011-07-16 Juanma Barranquero <lekktu@gmail.com>
795
796 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
797
a8031457
PE
7982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
799
800 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
801
dd889327
LMI
8022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
803
750c33f7
LMI
804 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
805 it's used from the C level.
806
dd889327
LMI
807 * process.c: Use the same condition for POLL_FOR_INPUT in both
808 keyboard.c and process.c (bug#1858).
809
87e86684
LM
8102011-07-09 Lawrence Mitchell <wence@gmx.li>
811
812 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
813 (Fgnutls_boot): Use it.
814
64348f40
AS
8152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
816
817 * doc.c (Fsubstitute_command_keys): Revert last change.
818
1d698799
LMI
8192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
820
f863868c
LMI
821 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
822 quotes the next character, and doesn't affect other longer
823 sequences (bug#8935).
824
1d698799
LMI
825 * lread.c (syms_of_lread): Clarify that is isn't only
826 `eval-buffer' and `eval-defun' that's affected by
827 `lexical-binding' (bug#8460).
828
aa4b6df6
EZ
8292011-07-15 Eli Zaretskii <eliz@gnu.org>
830
831 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
832 bidi redisplay when a line includes both an image and is
833 truncated.
834
5d856da6
PE
8352011-07-14 Paul Eggert <eggert@cs.ucla.edu>
836
ad6042bb
PE
837 Fix minor problems found by static checking.
838 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
839 (elsz): Now a signed constant, not a size_t var. We prefer signed
840 types to unsigned, to avoid integer comparison confusion. Without
841 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
842 "cannot optimize loop, the loop counter may overflow", a symptom
843 of the confusion.
f00bbb22 844 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
845 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
846
6468f31c
LMI
8472011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
848
49080b10
LMI
849 * search.c (Fre_search_backward): Mention `case-fold-search' in
850 all the re_search_* functions (bug#8138).
851
6468f31c
LMI
852 * keyboard.c (Fopen_dribble_file): Document when the file is
853 closed (bug#8056).
854
c965adc5
EZ
8552011-07-14 Eli Zaretskii <eliz@gnu.org>
856
df9733bf
EZ
857 * bidi.c (bidi_dump_cached_states): Fix format of displaying
858 bidi_cache_idx.
859
0bb23927
EZ
860 Support bidi reordering of display and overlay strings.
861 * xdisp.c (compute_display_string_pos)
862 (compute_display_string_end): Accept additional argument STRING.
863 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
864 (reseat_to_string): Initialize bidi_it->string.s and
865 bidi_it->string.schars.
866 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
867 NULL (avoids a crash in bidi_paragraph_init).
868 Initialize itb.string.lstring.
0bb23927
EZ
869 (init_iterator): Call bidi_init_it only of a valid
870 buffer position was specified. Initialize paragraph_embedding to
871 L2R.
872 (reseat_to_string): Initialize the bidi iterator.
873 (display_string): If we need to ignore text properties of
874 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
875 original value of -1 will not work with bidi.)
876 (compute_display_string_pos): First arg is now struct
877 `text_pos *'; all callers changed. Support display properties on
878 Lisp strings.
879 (compute_display_string_end): Support display properties on Lisp
880 strings.
881 (init_iterator, reseat_1, reseat_to_string): Initialize the
882 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
883 when iterating on a string not from display properties).
640c8776
SM
884 (compute_display_string_pos, compute_display_string_end):
885 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
886 arrow keys.
887 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
888 base_level_stop; instead, set base_level_stop to BEGV.
889 Fixes crashes in vertical-motion.
0bb23927
EZ
890 (next_element_from_buffer): Improve commentary for when
891 the iterator is before prev_stop.
892 (init_iterator): Initialize bidi_p from the default value of
893 bidi-display-reordering, not from buffer-local value. Use the
894 buffer-local value only if initializing for buffer iteration.
895 (handle_invisible_prop): Support invisible properties on strings
896 that are being bidi-reordered.
897 (set_iterator_to_next): Support bidi reordering of C strings and
898 Lisp strings.
899 (next_element_from_string): Support bidi reordering of Lisp
900 strings.
901 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
902 (display_string): Support display of R2L glyph rows.
903 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
904 (init_iterator): Don't initialize it->bidi_p for strings
905 here.
906 (reseat_to_string): Initialize it->bidi_p for strings here.
907 (next_element_from_string, next_element_from_c_string)
908 (next_element_from_buffer): Add xassert's for correspondence
909 between IT's object being iterated and it->bidi_it.string
910 structure.
911 (face_before_or_after_it_pos): Support bidi iteration.
912 (next_element_from_c_string): Handle the case of the first string
913 character that is not the first one in the visual order.
914 (get_visually_first_element): New function, refactored from common
915 parts of next_element_from_buffer, next_element_from_string, and
916 next_element_from_c_string.
917 (tool_bar_lines_needed, redisplay_tool_bar)
918 (display_menu_bar): Force left-to-right direction. Add a FIXME
919 comment for making that be controlled by a user option.
920 (push_it, pop_it): Save and restore the state of the
921 bidi iterator. Save and restore the bidi_p flag.
922 (pop_it): Iterate out of display property for string iteration as
923 well.
924 (iterate_out_of_display_property): Support iteration over strings.
925 (handle_single_display_spec): Set up it->bidi_it for iteration
926 over a display string, and call bidi_init_it.
927 (handle_single_display_spec, next_overlay_string)
928 (get_overlay_strings_1, push_display_prop): Set up the bidi
929 iterator for displaying display or overlay strings.
930 (forward_to_next_line_start): Don't use the shortcut if
931 bidi-iterating.
932 (back_to_previous_visible_line_start): If handle_display_prop
933 pushed the iterator stack, restore the internal state of the bidi
934 iterator by calling bidi_pop_it same number of times.
935 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
936 and we are bidi-iterating, don't decrement the iterator position;
937 instead, set the first_elt flag in the bidi iterator, to produce
938 the same effect.
939 (reseat_1): Remove redundant setting of string_from_display_prop_p.
940 (push_display_prop): xassert that we are iterating a buffer.
941 (push_it, pop_it): Save and restore paragraph_embedding member.
942 (handle_single_display_spec, next_overlay_string)
943 (get_overlay_strings_1, reseat_1, reseat_to_string)
944 (push_display_prop): Set up the `unibyte' member of bidi_it.string
945 correctly. Don't assume unibyte strings are not bidi-reordered.
946 (compute_display_string_pos)
947 (compute_display_string_end): Fix handling the case of C string.
948 (push_it, pop_it): Save and restore from_disp_prop_p.
949 (handle_single_display_spec, push_display_prop): Set the
950 from_disp_prop_p flag.
951 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
952 (pop_it): Call iterate_out_of_display_property only if we are
953 popping after iteration over a string that came from a display
954 property. Fix a typo in popping stretch info. Add an assertion
955 for verifying that the iterator position is in sync with the bidi
956 iterator.
957 (handle_single_display_spec, get_overlay_strings_1)
958 (push_display_prop): Fix initialization of paragraph direction for
959 string when that of the parent object is not yet determined.
960 (reseat_1): Call bidi_init_it to resync the bidi
961 iterator with IT's position. (Bug#7616)
962 (find_row_edges): If ROW->start.pos gives position
963 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
964 (handle_stop, back_to_previous_visible_line_start, reseat_1):
965 Reset the from_disp_prop_p flag.
966 (SAVE_IT, RESTORE_IT): New macros.
967 (pos_visible_p, face_before_or_after_it_pos)
968 (back_to_previous_visible_line_start)
969 (move_it_in_display_line_to, move_it_in_display_line)
970 (move_it_to, move_it_vertically_backward, move_it_by_lines)
971 (try_scrolling, redisplay_window, display_line): Use them when
972 saving a temporary copy of the iterator and restoring it back.
973 (back_to_previous_visible_line_start, reseat_1)
974 (init_iterator): Empty the bidi cache "stack".
975 (move_it_in_display_line_to): If iterator ended up at
976 EOL, but we never saw any buffer positions smaller than
977 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
978 motion in bidi-reordered lines.
979 (move_it_in_display_line_to): Record prev_method and prev_pos
980 immediately before the call to set_iterator_to_next. Fixes cursor
981 motion in bidi-reordered lines with stretch glyphs and strings
982 displayed in margins. (Bug#8133) (Bug#8867)
983 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
984 TO_CHARPOS.
640c8776
SM
985 (pos_visible_p): Support positions in bidi-reordered lines.
986 Save and restore bidi cache.
0bb23927
EZ
987
988 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
989 (bidi_paragraph_info): Delete unused struct.
990 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
991 (bidi_cache_start): New variable.
992 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
993 to zero.
994 (bidi_cache_fetch_state, bidi_cache_search)
995 (bidi_cache_find_level_change, bidi_cache_iterator_state)
996 (bidi_cache_find, bidi_peek_at_next_level)
997 (bidi_level_of_next_char, bidi_find_other_level_edge)
998 (bidi_move_to_visually_next): Compare cache index with
999 bidi_cache_start rather than with zero.
1000 (bidi_fetch_char): Accept new argument STRING; all callers
1001 changed. Support iteration over a string. Support strings with
1002 display properties. Support unibyte strings. Fix the type of
1003 `len' according to what STRING_CHAR_AND_LENGTH expects.
1004 (bidi_paragraph_init, bidi_resolve_explicit_1)
1005 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1006 (bidi_level_of_next_char, bidi_move_to_visually_next):
1007 Support iteration over a string.
0bb23927
EZ
1008 (bidi_set_sor_type, bidi_resolve_explicit_1)
1009 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1010 can now be zero (for strings); special values 0 and -1 were
1011 changed to -1 and -2, respectively.
1012 (bidi_char_at_pos): New function.
1013 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1014 Call it instead of FETCH_MULTIBYTE_CHAR.
1015 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1016 initialized to valid values.
1017 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1018 values.
1019 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1020 the test for valid cached positions. Fix the logic for looking up
1021 the sentinel state in the cache. GCPRO the Lisp string we are
1022 iterating.
1023 (bidi_push_it, bidi_pop_it): New functions.
1024 (bidi_initialize): Initialize the bidi cache start stack pointer.
1025 (bidi_cache_ensure_space): New function, refactored from part of
1026 bidi_cache_iterator_state. Don't assume the required size is just
1027 one BIDI_CACHE_CHUNK away.
1028 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1029 (bidi_count_bytes, bidi_char_at_pos): New functions.
1030 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1031 always valid if bidi_cache_idx is valid.
1032 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1033 is valid if it's going to be used.
1034 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1035 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1036 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1037 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1038 (bidi_find_other_level_edge, bidi_cache_start_stack):
1039 All variables related to cache indices are now EMACS_INT.
c965adc5 1040
0bb23927
EZ
1041 * dispextern.h (struct bidi_string_data): New structure.
1042 (struct bidi_it): New member `string'. Make flag members be 1-bit
1043 fields, and put them last in the struct.
640c8776
SM
1044 (compute_display_string_pos, compute_display_string_end):
1045 Update prototypes.
0bb23927
EZ
1046 (bidi_push_it, bidi_pop_it): Add prototypes.
1047 (struct iterator_stack_entry): New members bidi_p,
1048 paragraph_embedding, and from_disp_prop_p.
1049 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1050 (bidi_shelve_cache, bidi_unshelve_cache):
1051 Declare prototypes.
0bb23927
EZ
1052
1053 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1054 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1055 and vector-like objects.
1056
1057 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1058 cache around display iteration.
1059
1060 * window.c (Fwindow_end, window_scroll_pixel_based)
1061 (displayed_window_lines, Frecenter): Save and restore the bidi
1062 cache around display iteration.
1063
3bbd2265
LMI
10642011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1065
1066 * editfns.c (Fdelete_region): Clarify the use of the named
1067 parameters (bug#6788).
1068
adc47434
MR
10692011-07-14 Martin Rudalics <rudalics@gmx.at>
1070
1071 * indent.c (Fvertical_motion): Set and restore w->pointm when
1072 saving and restoring the window's buffer (Bug#9006).
1073
837c31f8
LMI
10742011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1075
1076 * editfns.c (Fstring_to_char): Clarify just what is returned
1077 (bug#6576). Text by Eli Zaretskii.
1078
ac389d0c
JB
10792011-07-13 Juanma Barranquero <lekktu@gmail.com>
1080
1081 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1082
0be0ce47
EZ
10832011-07-13 Eli Zaretskii <eliz@gnu.org>
1084
1085 * buffer.c (mmap_find): Fix a typo.
1086
cd18e7e3
JB
10872011-07-13 Johan Bockgård <bojohan@gnu.org>
1088
1089 Fix execution of x selection hooks.
1090 * xselect.c (Qx_lost_selection_functions)
1091 (Qx_sent_selection_functions): New vars.
1092 (syms_of_xselect): DEFSYM them.
1093 (x_handle_selection_request): Pass Qx_sent_selection_functions
1094 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1095 (x_handle_selection_clear,x_clear_frame_selections):
1096 Pass Qx_lost_selection_functions rather than
1097 Vx_lost_selection_functions to Frun_hook_with_args.
1098
47ea7f44
PE
10992011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1100
ac389d0c 1101 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1102 The old code sometimes used this field without initializing it.
1103
47ea7f44
PE
1104 * alloc.c (gc_sweep): Don't read past end of array.
1105 In theory, the old code could also have corrupted Emacs internals,
1106 though it'd be very unlikely.
1107
bc985c87
AS
11082011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1109
1110 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1111 argument. (Bug#4026)
bc985c87 1112
0cf34688
LMI
11132011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1114
b3dadd76
LMI
1115 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1116 key" (bug#4257).
1117
0cf34688
LMI
1118 * window.c (Fset_window_start): Doc fix (bug#4199).
1119 (Fset_window_hscroll): Ditto.
1120
270768cd
PE
11212011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1122
077e3dda 1123 Fix minor new problems caught by GCC 4.6.1.
270768cd 1124 * term.c (init_tty): Remove unused local.
490011a6 1125 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1126 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1127 not used otherwise.
270768cd 1128
b1f58454
CY
11292011-07-12 Chong Yidong <cyd@stupidchicken.com>
1130
1131 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1132
22b9578d
LMI
11332011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1134
6e70ab07
LMI
1135 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1136 are the mini-buffer and the echo area (bug#3320).
1137
22b9578d
LMI
1138 * term.c (init_tty): Remove support for supdup, c10 and perq
1139 terminals, which are no longer supported (bug#1482).
1140
8974cc9f
JB
11412011-07-10 Johan Bockgård <bojohan@gnu.org>
1142
1143 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1144
a560d974
JD
11452011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1146
1147 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1148 for non-popups (Bug#3642).
1149
1dae0f0a
AS
11502011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1151
268c2c36 1152 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1153 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1154 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1155 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1156 * data.c (fmod): Likewise.
1157 * dispnew.c (swap_glyphs_in_rows): Likewise.
1158 * emacs.c (memory_warning_signal): Likewise.
1159 * floatfns.c (float_error): Likewise.
1160 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1161 (otf_open, font_otf_capability, generate_otf_features)
1162 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1163 Likewise.
1164 * image.c (pbm_read_file): Likewise.
1165 * indent.c (string_display_width): Likewise.
1166 * intervals.c (check_for_interval, search_for_interval)
1167 (inc_interval_count, count_intervals, root_interval)
1168 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1169 * lread.c (defalias): Likewise.
268c2c36 1170 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1171 * regex.c (set_image_of_range_1, set_image_of_range)
1172 (regex_grow_registers): Likewise.
1173 * sysdep.c (strerror): Likewise.
1174 * termcap.c (valid_filename_p, tprint, main): Likewise.
1175 * tparam.c (main): Likewise.
1176 * unexhp9k800.c (run_time_remap, save_data_space)
1177 (update_file_ptrs, read_header, write_header, calculate_checksum)
1178 (copy_file, copy_rest, display_header): Likewise.
1179 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1180 Likewise.
1181 * xdisp.c (check_it): Likewise.
1182 * xfaces.c (register_color, unregister_color, unregister_colors):
1183 Likewise.
1184 * xfns.c (print_fontset_result): Likewise.
1185 * xrdb.c (member, fatal, main): Likewise.
1186
99033785
PE
11872011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 Fix minor problems found by static checking (Bug#9031).
1190 * chartab.c (char_table_set_range, map_sub_char_table):
1191 Remove unused locals.
1192 (uniprop_table): Now static.
1193 * composite.c (_work_char): Remove unused static var.
1194
9cb2ac56
JB
11952011-07-09 Juanma Barranquero <lekktu@gmail.com>
1196
1197 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1198
f25661f0
JD
11992011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1200
1201 * gtkutil.c (qttip_cb): Remove code without function.
1202
8278c4fe
EZ
12032011-07-09 Eli Zaretskii <eliz@gnu.org>
1204
1205 * w32.c (pthread_sigmask): New stub.
1206
1692ae2d 12072011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1208
8a6ebd58 1209 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1210 sigprocmask is portable only for single-threaded applications, and
1211 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1212 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1213 (LIBES): Use it.
1214 * callproc.c (Fcall_process):
1215 * process.c (create_process):
1216 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1217 Use pthread_sigmask, not sigprocmask.
123403e4 1218
1b854618
JD
12192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1220
1221 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1222 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1223 wrong (Bug#8591).
1224
3fe4b549
JD
12252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1226
0ce7e563
JD
1227 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1228 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1229 (xg_hide_tooltip): Fix comment.
1230
3fe4b549
JD
1231 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1232 in registerServicesMenuSendTypes.
1233 (validRequestorForSendType): Don't check ns_return_types.
1234
1235 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1236 ns_return_type.
1237
5df75e47
JR
12382011-07-08 Jason Rumney <jasonr@gnu.org>
1239
1240 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1241 frame struct members of non-existent frames (Bug#6284).
1242
699c10bd
JD
12432011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1244
4393663b
JD
1245 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1246 variable firstTime not needed on OSX >= 10.6.
1247 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1248 >= 10.5. Use setKnobProportion, setDoubleValue.
1249
1250 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1251 (MAC_OS_X_VERSION_10_5): Define if not defined.
1252 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1253 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1254 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1255
1256 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1257 cString and lossyCString on OSX >= 10.4
1258
1259 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1260 sizeToFit on OSX >= 10.2.
1261
1262 * nsimage.m (allocInitFromFile): Don't use deprecated method
1263 bestRepresentationForDevice on OSX >= 10.6.
1264
1265 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1266 to avoid warning.
1267
1268 * emacs.c: Declare unexec_init_emacs_zone.
1269
a63e0781
JD
1270 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1271
699c10bd
JD
1272 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1273
1274 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1275 on svcsMenu (Bug#8842).
1276
1277 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1278 ns_return_types.
1279 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1280
1281 * nsterm.m (QUTF8_STRING): Declare.
1282 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1283 (validRequestorForSendType): Return type is (id).
1284 Change indexOfObjectIdenticalTo to indexOfObject.
1285 Check if we have local selection before returning self (Bug#8842).
1286 (writeSelectionToPasteboard): Put local selection into paste board
1287 if we have a local selection (Bug#8842).
1288 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1289
1290 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1291 (ns_get_local_selection): Declare.
1292
54e10184
LMI
12932011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1294
9888ff71
LMI
1295 * keymap.c (describe_map_tree): Don't insert a double newline at
1296 the end of the buffer (bug#1169) and return whether we inserted
1297 something.
1298
54e10184
LMI
1299 * callint.c (Fcall_interactively): Change "reading args" to
1300 "providing args" to try to clarify what it does (bug#1010).
1301
15fa4783
KH
13022011-07-07 Kenichi Handa <handa@m17n.org>
1303
1304 * composite.c (composition_compute_stop_pos): Ignore a static
1305 composition starting before CHARPOS (Bug#8915).
1306
1307 * xdisp.c (handle_composition_prop): Likewise.
1308
a8815b00
EZ
13092011-07-07 Eli Zaretskii <eliz@gnu.org>
1310
1311 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1312 (Bug#9015)
1313
ef7b981d 13142011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1315
1316 * character.h (unicode_category_t): New enum type.
1317
1318 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1319 (Qchar_code_property_table): New variable.
1320 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1321 (UNIPROP_COMPRESSED_FORM_P): New macros.
1322 (char_table_ascii): Uncompress the compressed values.
1323 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1324 Uncompress the compressed values.
ac389d0c 1325 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1326 (char_table_ref_and_range): Uncompress the compressed values.
1327 (sub_char_table_set): New arg is_uniprop. Callers changed.
1328 Uncompress the compressed values.
1329 (sub_char_table_set_range): Args changed. Callers changed.
1330 (char_table_set_range): Adjuted for the above change.
1331 (map_sub_char_table): Delete args default_val and parent. Add arg
1332 top. Give decoded values to a Lisp function.
640c8776 1333 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1334 values to a Lisp function. Gcpro more variables.
1335 (uniprop_table_uncompress)
1336 (uniprop_decode_value_run_length): New functions.
1337 (uniprop_decoder, uniprop_decoder_count): New variables.
1338 (uniprop_get_decoder, uniprop_encode_value_character)
1339 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1340 New functions.
1341 (uniprop_encoder, uniprop_encoder_count): New variables.
1342 (uniprop_get_encoder, uniprop_table)
1343 (Funicode_property_table_internal, Fget_unicode_property_internal)
1344 (Fput_unicode_property_internal): New functions.
1345 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1346 Sunicode_property_table_internal, Sget_unicode_property_internal,
1347 and Sput_unicode_property_internal. Defvar_lisp
1348 char-code-property-alist.
1349
640c8776 1350 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1351 Vunicode_category_table.
1352
640c8776 1353 * font.c (font_range): Adjust for the change of
c805dec0
KH
1354 Vunicode_category_table.
1355
76b397fb
DN
13562011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1357
1358 * m/iris4d.h: Remove file, move contents ...
1359 * s/irix6-5.h: ... here.
1360
22b4128e
PE
13612011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1362
1363 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1364 * alloc.c (mark_buffer):
1365 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1366 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1367 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1368 This isn't true in general, and it's particularly not true
1369 if Emacs is configured with --with-wide-int.
1370 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1371 New macros, used in the buffer.c change.
1372
869795d6
JD
13732011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1374
1375 * xsettings.c: Use both GConf and GSettings if both are available.
1376 (store_config_changed_event): Add comment.
1377 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1378 (store_tool_bar_style_changed): New functions.
1379 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1380 (struct xsettings): Move font inside HAVE_XFT.
1381 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1382 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1383 Move inside HAVE_XFT.
640c8776 1384 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1385 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1386 also.
1387 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1388 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1389 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1390 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1391 (parse_settings): Move check for font inside HAVE_XFT.
1392 (read_settings, apply_xft_settings): Add comment.
1393 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1394 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1395 call store_font_name_changed.
1396 (xft_settings_event): Add comment.
1397 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1398 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1399 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1400 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1401 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1402 (xsettings_get_system_font, xsettings_get_system_normal_font):
1403 Add comment.
869795d6 1404
d8ed26bd
PE
14052011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1406
1407 Random fixes. E.g., (random) never returned negative values.
1408 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1409 subseconds part to the entropy, as that's a bit more random.
1410 Prefer signed to unsigned, since the signedness doesn't matter and
1411 in general we prefer signed. When given a limit, use a
1412 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1413 latter isn't right if USE_2_TAGS_FOR_INTS.
1414 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1415 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1416
cabf1cac
SM
14172011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1418
1419 * textprop.c (text_property_stickiness):
1420 Obey Vtext_property_default_nonsticky.
1421 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1422 * w32fns.c (syms_of_w32fns):
1423 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1424
6e9b2be9
PE
14252011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1426
1427 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1428 This is more efficient than Ffile_directory_p and avoids a minor race.
1429
90186c68
LMI
14302011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1431
7c301272
LMI
1432 * buffer.c (Foverlay_put): Say what the return value is
1433 (bug#7835).
1434
c4f2d8d4
LMI
1435 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1436 is a directory before asking whether to use the file name
1437 (bug#7564).
ad637907
LMI
1438 (barf_or_query_if_file_exists): Make the "File is a directory"
1439 error be more correct.
c4f2d8d4 1440
90186c68
LMI
1441 * fns.c (Frequire): Remove the mention of the .gz files, since
1442 that's installation-specific, but keep the mention of
1443 `get-load-suffixes'.
1444
da64016e
PE
14452011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1446
1447 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1448 Report string overflow if the output is too long.
1449
7d47b580
JB
14502011-07-04 Juanma Barranquero <lekktu@gmail.com>
1451
a555cb87
JB
1452 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1453 (syms_of_gnutls): Remove duplicate DEFSYM for
1454 Qgnutls_bootprop_verify_hostname_error, an error for
1455 Qgnutls_bootprop_verify_error (which is no longer used).
1456
7d47b580
JB
1457 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1458 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1459 Also (re)move comments that are misplaced or no longer relevant.
1460
1e49bfab
LMI
14612011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1462
1463 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1464
1485f4c0
CY
14652011-07-03 Chong Yidong <cyd@stupidchicken.com>
1466
1467 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1468 and background color parameters if they have been changed.
1469
a9ab721e
LMI
14702011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1471
1472 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1473
cf7cff57
PE
14742011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1475
2e13213d
PE
1476 * xsettings.c (SYSTEM_FONT): Define only when used.
1477 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1478
cf7cff57
PE
1479 * keymap.c (access_keymap_1): Now static.
1480
7a8e04f7
CY
14812011-07-02 Chong Yidong <cyd@stupidchicken.com>
1482
1483 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1484 leave any prefix arg for the up event (Bug#1586).
1485
61352f62
LMI
14862011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1487
69bb1ef7
LMI
1488 * lread.c (syms_of_lread): Mention single symbols defined by
1489 `defvar' or `defconst' (bug#7154).
1490
61352f62 1491 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1492 (Frequire): Mention get-load-suffixes.
61352f62 1493
28545e04
MR
14942011-07-02 Martin Rudalics <rudalics@gmx.at>
1495
1496 * window.h (window): Remove clone_number slot.
1497 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1498 Remove.
1499 (make_parent_window, make_window, saved_window)
1500 (Fset_window_configuration, save_window_save): Don't deal with
1501 clone numbers.
1502 * buffer.c (Qclone_number): Remove declaration.
1503 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1504
3349e122
SM
15052011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1506
1507 Add multiple inheritance to keymaps.
1508 * keymap.c (Fmake_composed_keymap): New function.
1509 (Fset_keymap_parent): Simplify.
1510 (fix_submap_inheritance): Remove.
1511 (access_keymap_1): New function extracted from access_keymap to handle
1512 embedded parents and handle lists of maps.
1513 (access_keymap): Use it.
1514 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1515 (Fcopy_keymap): Handle embedded parents.
1516 (Fcommand_remapping, define_as_prefix): Simplify.
1517 (Fkey_binding): Simplify.
1518 (syms_of_keymap): Move minibuffer-local-completion-map,
1519 minibuffer-local-filename-completion-map,
1520 minibuffer-local-must-match-map, and
1521 minibuffer-local-filename-must-match-map to Elisp.
1522 (syms_of_keymap): Defsubr make-composed-keymap.
1523 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1524 (parse_menu_item): Trivial simplification.
1525
3279eb87
GM
15262011-07-01 Glenn Morris <rgm@gnu.org>
1527
1528 * Makefile.in (SETTINGS_LIBS): Fix typo.
1529
4550efdf
KI
15302011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1531
1532 * coding.c (Fencode_coding_string): Record the last coding system
1533 used, as the function doc string says (bug#8738).
1534
0949d2b6
JD
15352011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1536
1537 * xsettings.c (store_monospaced_changed): Take new font as arg and
1538 check for change against current_mono_font.
1539 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1540 (emacs_settings_constructor, emacs_settings_get_property)
1541 (emacs_settings_set_property, emacs_settings_class_init)
1542 (emacs_settings_init, gsettings_obj): Remove.
1543 (something_changedCB): New function for HAVE_GSETTINGS.
1544 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1545 with value as argument.
1546 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1547 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1548 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1549 "changed".
1550
1551 * xgselect.c: Add defined (HAVE_GSETTINGS).
1552 (xgselect_initialize): Ditto.
1553
1554 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1555 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1556 xg_select.
1557
bbc6b304
PE
15582011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1559
1560 * eval.c (struct backtrace): Simplify and port the data structure.
1561 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1562 signed bit field, as this assumption is not portable and it makes
1563 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1564 "char debug_on_exit : 1" as this is not portable either; instead,
1565 use the portable "unsigned int debug_on_exit : 1". Remove unused
1566 member evalargs. Remove obsolete comments about cc bombing out.
1567
9851bfc5
JD
15682011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1569
51bb811f 1570 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1571 Let HAVE_GSETTINGS override HAVE_GCONF.
1572 (store_monospaced_changed): New function.
1573 (EMACS_SETTINGS): A new type derived from GObject to handle
1574 GSettings notifications.
1575 (emacs_settings_constructor, emacs_settings_get_property)
1576 (emacs_settings_set_property, emacs_settings_class_init):
1577 New functions.
1578 (gsettings_client, gsettings_obj): New variables.
1579 (GSETTINGS_SCHEMA): New define.
1580 (something_changedCB): Call store_monospaced_changed.
1581 (init_gsettings): New function.
1582 (xsettings_initialize): Call init_gsettings.
1583 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1584 to NULL.
1585
640c8776 1586 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1587 GCONF_CFLAGS/LIBS.
1588
5386012d
MR
15892011-06-29 Martin Rudalics <rudalics@gmx.at>
1590
1591 * window.c (resize_root_window, grow_mini_window)
1592 (shrink_mini_window): Rename Qresize_root_window to
1593 Qwindow_resize_root_window and Qresize_root_window_vertically to
1594 Qwindow_resize_root_window_vertically.
1595
f13e0b08
PE
15962011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1599
94515237
JB
16002011-06-27 Juanma Barranquero <lekktu@gmail.com>
1601
1602 * makefile.w32-in: Redesign dependencies so they reflect more
1603 clearly which files are directly included by each source file,
1604 and not through other includes.
1605
e43b6e43
MR
16062011-06-27 Martin Rudalics <rudalics@gmx.at>
1607
1608 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1609 (sort_overlays, overlay_strings): When an overlay's clone number
1610 matches the window's clone number process the overlay even if
1611 the overlay's window property doesn't match the current window.
1612
d68443dc
MR
1613 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1614 (Fwindow_hchild): Rename to Fwindow_left_child.
1615 (Fwindow_next): Rename to Fwindow_next_sibling.
1616 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1617 (resize_window_check): Rename to window_resize_check.
1618 (resize_window_apply): Rename to window_resize_apply.
1619 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1620 (Fdelete_other_windows_internal, resize_frame_windows)
1621 (Fsplit_window_internal, Fdelete_window_internal)
1622 (grow_mini_window, shrink_mini_window)
1623 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1624
c7e73be5
JD
16252011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1626
1627 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1628 (emacs_fixed_set_min_size): Remove.
1629 (emacs_fixed_new): Take frame as argument.
1630
1631 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1632 (_EmacsFixedPrivate): Remove minwidth/height.
1633 Add struct frame *f.
1634 (emacs_fixed_init): Initialize priv->f.
1635 (get_parent_class, emacs_fixed_set_min_size): Remove.
1636 (emacs_fixed_new): Set priv->f to argument.
1637 (emacs_fixed_get_preferred_width)
1638 (emacs_fixed_get_preferred_height): Use min_width/height from
1639 frames size_hint to set minimum and natural (Bug#8919).
1640 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1641 and use min_width/height from frames size_hint to set
1642 min_width/height (Bug#8919).
1643
1644 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1645 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1646 Fix indentation.
c7e73be5 1647
cf99dcf8
EZ
16482011-06-26 Eli Zaretskii <eliz@gnu.org>
1649
1650 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1651 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1652 called at ZV.
1653
029529ac
CY
16542011-06-26 Chong Yidong <cyd@stupidchicken.com>
1655
1656 * process.c (wait_reading_process_output): Bypass select if
1657 waiting for a cell while ignoring keyboard input, and input is
1658 pending. Suggested by Jan Djärv (Bug#8869).
1659
7a7ef429
PE
16602011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1661
1662 Use gnulib's dup2 module instead of rolling our own.
1663 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1664
11fdef7d 16652011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1666
1667 * dispnew.c (scrolling_window): Before scrolling, turn off a
1668 mouse-highlight in the window being scrolled.
1669
cd3520a4
JB
16702011-06-24 Juanma Barranquero <lekktu@gmail.com>
1671
1672 Move DEFSYM to lisp.h and use everywhere.
1673
1674 * character.h (DEFSYM): Move declaration...
1675 * lisp.h (DEFSYM): ...here.
1676
1677 * gnutls.c:
1678 * minibuf.c:
1679 * w32menu.c:
1680 * w32proc.c:
1681 * w32select.c: Don't include character.h.
1682
1683 * alloc.c (syms_of_alloc):
1684 * buffer.c (syms_of_buffer):
1685 * bytecode.c (syms_of_bytecode):
1686 * callint.c (syms_of_callint):
1687 * casefiddle.c (syms_of_casefiddle):
1688 * casetab.c (init_casetab_once):
1689 * category.c (init_category_once, syms_of_category):
1690 * ccl.c (syms_of_ccl):
1691 * cmds.c (syms_of_cmds):
1692 * composite.c (syms_of_composite):
1693 * dbusbind.c (syms_of_dbusbind):
1694 * dired.c (syms_of_dired):
1695 * dispnew.c (syms_of_display):
1696 * doc.c (syms_of_doc):
1697 * editfns.c (syms_of_editfns):
1698 * emacs.c (syms_of_emacs):
1699 * eval.c (syms_of_eval):
1700 * fileio.c (syms_of_fileio):
1701 * fns.c (syms_of_fns):
1702 * frame.c (syms_of_frame):
1703 * fringe.c (syms_of_fringe):
1704 * insdel.c (syms_of_insdel):
1705 * keymap.c (syms_of_keymap):
1706 * lread.c (init_obarray, syms_of_lread):
1707 * macros.c (syms_of_macros):
1708 * msdos.c (syms_of_msdos):
1709 * print.c (syms_of_print):
1710 * process.c (syms_of_process):
1711 * search.c (syms_of_search):
1712 * sound.c (syms_of_sound):
1713 * syntax.c (init_syntax_once, syms_of_syntax):
1714 * terminal.c (syms_of_terminal):
1715 * textprop.c (syms_of_textprop):
1716 * undo.c (syms_of_undo):
1717 * w32.c (globals_of_w32):
1718 * window.c (syms_of_window):
1719 * xdisp.c (syms_of_xdisp):
1720 * xfaces.c (syms_of_xfaces):
1721 * xfns.c (syms_of_xfns):
1722 * xmenu.c (syms_of_xmenu):
1723 * xsettings.c (syms_of_xsettings):
1724 * xterm.c (syms_of_xterm): Use DEFSYM.
1725
4228cf16
TZ
17262011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1727
cd3520a4 1728 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1729
7fcccf1e
PE
17302011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1731
7efb4e0e
PE
1732 Integer and buffer overflow fixes (Bug#8873).
1733
ff5844ad
PE
1734 * print.c (printchar, strout): Check for string overflow.
1735 (PRINTPREPARE, printchar, strout):
1736 Don't set size unless allocation succeeds.
1737
90532f02
PE
1738 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1739 for sizes. Check for string overflow more accurately.
1740 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1741
6d84508d
PE
1742 * macros.c: Integer and buffer overflow fixes.
1743 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1744 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1745 Use ptrdiff_t, not int, for sizes.
1746 Don't increment bufsize until after realloc succeeds.
1747 Check for size-calculation overflow.
1748 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1749
437b2cb4
PE
1750 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1751
8b9ac8b4
PE
1752 * lread.c: Integer overflow fixes.
1753 (read_integer): Radix is now EMACS_INT, not int,
1754 to improve quality of diagnostics for out-of-range radices.
1755 Calculate buffer size correctly for out-of-range radices.
1756 (read1): Check for integer overflow in radices, and in
1757 read-circle numbers.
82cb60d3
PE
1758 (read_escape): Avoid int overflow.
1759 (Fload, openp, read_buffer_size, read1)
1760 (substitute_object_recurse, read_vector, read_list, map_obarray):
1761 Use ptrdiff_t, not int, for sizes.
1762 (read1): Use EMACS_INT, not int, for sizes.
20270765 1763 Check for size overflow.
8b9ac8b4 1764
7fcccf1e
PE
1765 * image.c (cache_image): Check for size arithmetic overflow.
1766
bfbbd7e7
PE
1767 * lread.c: Integer overflow issues.
1768 (saved_doc_string_size, saved_doc_string_length)
1769 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1770 Now ptrdiff_t, not int.
1771 (read1): Don't assume doc string length fits in int. Check for
1772 out-of-range doc string lengths.
1773 (read_list): Don't assume file position fits in int.
39019e54 1774 (read_escape): Check for hex character overflow.
bfbbd7e7 1775
4e323265
LL
17762011-06-22 Leo Liu <sdl.web@gmail.com>
1777
1778 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1779 Move to minibuffer.el.
1780
85fece3e
PE
17812011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1782
20b84ce9 1783 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1784 The following patches are for when GLYPH_DEBUG && !XASSERT.
1785 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1786 * dispnew.c (flush_stdout):
1787 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1788 Mark as externally visible.
1789 * dispnew.c (check_window_matrix_pointers): Now static.
1790 * dispnew.c (window_to_frame_vpos):
1791 * xfns.c (unwind_create_frame):
1792 * xterm.c (x_check_font): Remove unused local.
1793 * scroll.c (CHECK_BOUNDS):
1794 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1795 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1796 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1797 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1798 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1799 Now static.
1800 (debug_method_add): Use va_list and vsprintf rather than relying
1801 on undefined behavior with wrong number of arguments.
1802 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1803 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1804 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1805 since we're not interested in debugging glyphs with old libraries.
1806 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1807 GCC 4.6.0's static checking.
1808
0766b489
PE
18092011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1810
31fd4b32
PE
1811 Integer overflow and signedness fixes (Bug#8873).
1812 A few related buffer overrun fixes, too.
1813
b79e8648
PE
1814 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1815
0766b489
PE
1816 * dispextern.h (struct face.stipple):
1817 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1818 (x_bitmap_mask, x_allocate_bitmap_record)
1819 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1820 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1821 (x_create_bitmap_from_xpm_data):
1822 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1823 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1824 (.bitmaps_last):
1825 * xfaces.c (load_pixmap):
1826 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1827 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1828 (.bitmaps_last, struct x_output.icon_bitmap):
1829 Use ptrdiff_t, not int, for bitmap indexes.
1830 (x_allocate_bitmap_record): Check for size overflow.
1831 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1832
b081724f
PE
1833 Use ptrdiff_t, not int, for overlay counts.
1834 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1835 * editfns.c (overlays_around, get_pos_property):
1836 * textprop.c (get_char_property_and_overlay):
1837 * xdisp.c (next_overlay_change, note_mouse_highlight):
1838 * xfaces.c (face_at_buffer_position):
21514da7
PE
1839 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1840 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1841 (Fnext_overlay_change, Fprevious_overlay_change)
1842 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1843 Use ptrdiff_t, not int, for sizes.
21514da7 1844 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1845
3de73e5e
PE
1846 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1847
2606c57b
PE
1848 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1849 (x_session_initialize): Do not assume string length fits in int.
1850
aaafe47a
PE
1851 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1852 This is unlikely, but can occur if DPI is outlandish.
1853
2674ddc8 1854 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1855 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1856
28154962
PE
1857 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1858 * xrdb.c (magic_file_p, search_magic_path):
1859 Omit last arg SUFFIX; it was always 0. All callers changed.
1860 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1861
7de51af5
PE
1862 * xfont.c (xfont_match): Avoid need for strlen.
1863
25ed6cc3
PE
1864 * xfns.c: Don't assume strlen fits in int.
1865 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1866
4eab31dd
PE
1867 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1868 not unsigned long, as we prefer signed integers. All callers changed.
1869 Detect integer overflow in repeat count.
1870 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1871 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1872
171e2a58
PE
1873 * termcap.c: Don't assume sizes fit in int and never overflow.
1874 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1875 (gobble_line): Check for size-calculation overflow.
1876
ad39faca 1877 * minibuf.c (Fread_buffer):
6e5bb2dc 1878 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1879 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1880 Don't assume string length fits in int.
1881
52c61c22 1882 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1883 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1884
b5b8c9e5
PE
1885 * font.c: Don't assume string length fits in int.
1886 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1887 Use ptrdiff_t, not int.
ccd6111c
PE
1888 (font_intern_prop): Don't assume string length fits in int.
1889 Don't assume integer property fits in fixnum.
1890 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1891
882f0d81 1892 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1893 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1894 Reformulate so as not to need the command string.
1895 Invoke gzip -cd rather than gunzip, as it's more portable.
1896 (lock_info_type, lock_file_1, lock_file):
1897 Don't assume pid_t and time_t fit in unsigned long.
1898 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1899 (current_lock_owner): Prefer signed type for sizes.
1900 Use memcpy, not strncpy, where memcpy is what is really wanted.
1901 Don't assume (via atoi) that time_t and pid_t fit in int.
1902 Check for time_t and/or pid_t out of range, e.g., via a network share.
1903 Don't alloca where an auto var works fine.
1904
93f4cf88
PE
1905 * fileio.c: Fix some integer overflow issues.
1906 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1907 Don't assume string length fits in int.
1908 (directory_file_name): Don't assume string length fits in long.
1909 (make_temp_name): Don't assume pid fits in int, or that its print
1910 length is less than 20.
1911
f3e92b69
PE
1912 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1913
1bfdaf10
PE
1914 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1915
35016e9a
PE
1916 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1917
3d1e65a1
PE
1918 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1919 We prefer signed integers, even for size calculations.
1920
0b963a93
PE
1921 * emacs.c: Don't assume string length fits in 'int'.
1922 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1923 (main): Don't invoke strlen when not needed.
1924
573f4b54
PE
1925 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1926 (XD_DEBUG_MESSAGE): Don't waste a byte.
1927
989f33ba
PE
1928 * callproc.c (getenv_internal_1, getenv_internal)
1929 (Fgetenv_internal):
965d34eb
PE
1930 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1931
e4d29b33
PE
1932 * lread.c (invalid_syntax): Omit length argument.
1933 All uses changed. This doesn't fix a bug, but it simplifies the
1934 code away from its former Hollerith-constant appearance, and it's
1935 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1936 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1937
eb49b136
PE
1938 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1939 This didn't break anything, but it didn't help either.
1940 It's confusing to put a bogus integer in a place where the actual
1941 value does not matter.
9f62aeb1 1942 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1943 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1944
15375a22
PE
1945 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1946 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1947 implementation.
b61cc01c
PE
1948 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1949 We prefer signed types, and the value cannot exceed the EMACS_INT
1950 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1951 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1952 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1953 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1954
53b2623d
PE
1955 * indent.c (sane_tab_width): New function.
1956 (current_column, scan_for_column, Findent_to, position_indentation)
1957 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1958 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1959
51cab52b 1960 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1961
f2ed8a70
PE
1962 * lisp.h (lint_assume): New macro.
1963 * composite.c (composition_gstring_put_cache):
1964 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1965
abe80cc6
PE
1966 * editfns.c, insdel.c:
1967 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1968
b02c740e
PE
1969 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1970
ebc96716
PE
1971 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1972
b4e50fa0 1973 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1974 Use much-faster test for byte-length change.
311d5d7c 1975 Don't assume string byte-length fits in 'int'.
a4cf38e4 1976 Check that character arg fits in 'int'.
85461888 1977 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1978
c0c1ee9f
PE
1979 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1980
a498d7f4
PE
1981 * fns.c (concat): Catch string overflow earlier.
1982 Do not rely on integer wraparound.
1983
51cab52b
PE
1984 * dispextern.h (struct it.overlay_strings_charpos)
1985 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1986 * xdisp.c (forward_to_next_line_start)
1987 (back_to_previous_visible_line_start)
1988 (reseat_at_next_visible_line_start, next_element_from_buffer):
1989 Don't arbitrarily truncate the value of 'selective' to int.
1990
76031fad
PE
1991 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1992
5eb55db9
PE
1993 * composite.c: Don't truncate sizes to 'int'.
1994 (composition_gstring_p, composition_reseat_it)
1995 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1996 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1997 not EMACS_UINT, for indexes.
5eb55db9 1998
0703a717
PE
1999 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2000
d6202519
PE
2001 * buffer.c: Include <verify.h>.
2002 (struct sortvec.priority, struct sortstr.priority):
8961a454 2003 Now EMACS_INT, not int.
c20998a7 2004 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2005 (struct sortstr.size, record_overlay_string)
2006 (struct sortstrlist.size, struct sortlist.used):
2007 Don't truncate size to int.
2008 (record_overlay_string): Check for size-calculation overflow.
d6202519 2009 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2010
d5a19415
JM
20112011-06-22 Jim Meyering <meyering@redhat.com>
2012
029529ac 2013 Don't leak an XBM-image-sized buffer
d5a19415
JM
2014 * image.c (xbm_load): Free the image buffer after using it.
2015
a9041e6c
PE
20162011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 Port to Sun C.
2019 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2020 that Sun C diagnosed.
2021 * fns.c (secure_hash): Fix pointer signedness issue.
2022 * intervals.c (static_offset_intervals): New function.
2023 (offset_intervals): Use it.
2024
7f3f739f
LL
20252011-06-21 Leo Liu <sdl.web@gmail.com>
2026
2027 * deps.mk (fns.o):
2028 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2029 sha512.h.
2030
2031 * fns.c (secure_hash): Rename from crypto_hash_function and change
2032 the first arg to accept symbols.
5b66d427 2033 (Fsecure_hash): New primitive.
7f3f739f
LL
2034 (syms_of_fns): New symbols.
2035
76147d94
DD
20362011-06-20 Deniz Dogan <deniz@dogan.se>
2037
2038 * process.c (Fset_process_buffer): Clarify return value in
2039 docstring.
2040
7d7d0045
CY
20412011-06-18 Chong Yidong <cyd@stupidchicken.com>
2042
2043 * dispnew.c (add_window_display_history): Use BVAR.
2044
2045 * xdisp.c (debug_method_add): Use BVAR.
2046 (check_window_end, dump_glyph_matrix, dump_glyph)
2047 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2048
2049 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2050 Likewise.
2051
2052 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2053 check till after the cache is created in init_frame_faces.
2054
ff2bc410
SM
20552011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2056
2057 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2058
28177add
PE
20592011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2060
dd3482fe
PE
2061 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2062 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2063 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2064
393d71f3 2065 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2066 * fileio.c (Finsert_file_contents):
2067 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2068 Remove the old (too-loose) buffer overflow checks.
2069 They weren't needed, since make_gap checks for buffer overflow.
2070 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2071 The old code merely checked for Emacs fixnum overflow, and relied
2072 on undefined (wraparound) behavior. The new code avoids undefined
2073 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2074
2e6813b0 2075 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2076 Tune. Don't use wider integers than needed. Don't use alloca.
2077 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2078
599a9e4f
PE
2079 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2080
99561444
PE
2081 * insdel.c, lisp.h (buffer_overflow): New function.
2082 (insert_from_buffer_1, replace_range, replace_range_2):
2083 * insdel.c (make_gap_larger):
2084 * editfns.c (Finsert_char):
2085 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2086
28177add
PE
2087 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2088
e69dafad
PE
20892011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2090
a7af7fde 2091 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2092
b1c46f02
PE
2093 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2094 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2095
e69dafad
PE
2096 * fileio.c: Don't assume EMACS_INT fits in off_t.
2097 (emacs_lseek): New static function.
2098 (Finsert_file_contents, Fwrite_region): Use it.
2099 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2100
566684ea
PE
2101 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2102
e6966cd6
PE
2103 * fns.c: Don't overflow int when computing a list length.
2104 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2105 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2106 truncation on 64-bit hosts. Check for QUIT every
2107 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2108 faster and is responsive enough.
2109 (Flength): Report an error instead of overflowing an integer.
2110 (Fsafe_length): Return a float if the value is not representable
2111 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2112 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2113 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2114
dd0b0efb
PE
2115 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2116 (header_size, word_size): New constants.
2117 (allocate_vectorlike): Don't check size overflow here.
2118 (allocate_vector): Check it here instead, since this is the only
2119 caller of allocate_vectorlike that could cause overflow.
2120 Check that the new vector's length is representable as a fixnum.
2121
86fe5cfe
PE
2122 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2123 The previous code was bogus. For example, next_almost_prime (32)
2124 returned 39, which is undesirable as it is a multiple of 3; and
2125 next_almost_prime (24) returned 25, which is a multiple of 5 so
2126 why was the code bothering to check for multiples of 7?
2127
80e88859
PE
2128 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2129
4a2f0ad6
PE
2130 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2131
f66c7cf8
PE
2132 Variadic C functions now count arguments with ptrdiff_t.
2133 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2134 Back then I didn't know that the Emacs coding style prefers signed int.
2135 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2136 were being counted with int, which may truncate counts on 64-bit
2137 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2138 * lisp.h (struct Lisp_Subr.function.aMANY)
2139 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2140 Arg counts are now ptrdiff_t, not size_t.
2141 All variadic functions and their callers changed accordingly.
2142 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2143 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2144 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2145 * callint.c (Fcall_interactively): Check arg count for overflow,
2146 to avoid potential buffer overrun. Use signed char, not 'int',
2147 for 'varies' array, so that we needn't bother to check its size
2148 calculation for overflow.
2149 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2150 * eval.c (apply_lambda):
2151 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2152 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2153 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2154
a1759b76
PE
2155 * callint.c (Fcall_interactively): Don't use index var as event count.
2156
d96be9fc
PE
2157 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2158 * mem-limits.h (SIZE): Remove; no longer used.
2159
a690a978 2160 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2161
578c21e6
PE
2162 Remove unnecessary casts.
2163 * xterm.c (x_term_init):
2164 * xfns.c (x_set_border_pixel):
2165 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2166 These aren't needed now that we assume ANSI C.
2167
96f53c6c
PE
2168 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2169 It's more likely to cause problems (due to unsigned overflow)
2170 than to cure them.
2171
83c77d31
PE
2172 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2173
ee2079f1
PE
2174 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2175
6da65536
PE
2176 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2177
7147c4a4
PE
2178 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2179
193e32d9
PE
2180 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2181
e5533da6
PE
2182 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2183
9910e595
PE
2184 GLYPH_CODE_FACE returns EMACS_INT, not int.
2185 * dispextern.h (merge_faces):
2186 * xfaces.c (merge_faces):
01103c44
PE
2187 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2188 Don't assume EMACS_INT fits in int.
9910e595 2189
2638320e
PE
2190 * character.h (CHAR_VALID_P): Remove unused parameter.
2191 * fontset.c, lisp.h, xdisp.c: All uses changed.
2192
045eb8d9
PE
2193 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2194
c1f134b5
PE
2195 * fns.c (concat): Minor tuning based on overflow analysis.
2196 This doesn't fix any bugs. Use int to hold character, instead
2197 of constantly refetching from Emacs object. Use XFASTINT, not
2198 XINT, for value known to be a character. Don't bother comparing
2199 a single byte to 0400, as it's always less.
2200
395fcb93 2201 * floatfns.c (Fexpt):
327eeec8
PE
2202 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2203
abbd3d23
PE
2204 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2205 for characters.
2206
684a03ef
PE
2207 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2208
0fed43f3
PE
2209 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2210 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2211 incorrectly succeed when S was a string, because 4294967386 was
2212 truncated before it was used.
2213
8fd02eb7
PE
2214 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2215 Otherwise, an out-of-range integer could cause undefined behavior
2216 on a 64-bit host.
2217
f8c86b69
PE
2218 * composite.c: Use int, not EMACS_INT, for characters.
2219 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2220 EMACS_INT, for values that are known to be in character range.
2221 This doesn't fix any bugs but is the usual style inside Emacs and
2222 may generate better code on 32-bit machines.
2223
34206dd2
PE
2224 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2225 This is for reasons similar to the recent CHAR_STRING fix.
2226 * charset.c (Fencode_char): Check that character arg is actually
2227 a character. Pass an int to ENCODE_CHAR.
2228 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2229 wider than 'int', as a compile-time check to prevent future regressions
2230 in this area.
2231
c5958d4c 2232 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2233
2234 Make sure a 64-bit char is never passed to CHAR_STRING.
2235 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2236 by silently ignoring the top 32 bits, allowing some values
2237 that were far too large to be valid characters.
2238 * character.h: Include <verify.h>.
2239 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2240 arguments are no wider than unsigned, as a compile-time check
2241 to prevent future regressions in this area.
2242 * data.c (Faset):
01103c44 2243 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2244 (Fsubst_char_in_region):
2245 * fns.c (concat):
2246 * xdisp.c (decode_mode_spec_coding):
2247 Adjust to CHAR_STRING's new requirement.
2248 * editfns.c (Finsert_char, Fsubst_char_in_region):
2249 * fns.c (concat): Check that character args are actually
2250 characters. Without this test, these functions did the wrong
2251 thing with wildly out-of-range values on 64-bit hosts.
2252
d37ca623
PE
2253 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2254 These casts should not be needed on 32-bit hosts, either.
2255 * keyboard.c (read_char):
2256 * lread.c (Fload): Remove casts to unsigned.
2257
ea204efb
PE
2258 * lisp.h (UNSIGNED_CMP): New macro.
2259 This fixes comparison bugs on 64-bit hosts.
2260 (ASCII_CHAR_P): Use it.
2261 * casefiddle.c (casify_object):
01103c44 2262 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2263 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2264 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2265 * dispextern.h (FACE_FROM_ID):
2266 * keyboard.c (read_char): Use UNSIGNED_CMP.
2267
41cb286c
PE
2268 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2269 not to EMACS_INT, to avoid GCC warning.
2270
4a1b9832
PE
2271 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2272
55daad71
PE
2273 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2274 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2275 isn't needed on 32-bit machines.
8f95c75c 2276
01103c44
PE
2277 * buffer.c (Fgenerate_new_buffer_name):
2278 Use EMACS_INT for count, not int.
0ceccced 2279 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2280
2281 * data.c (Qcompiled_function): Now static.
2282
c6f072e7
PE
2283 * window.c (window_body_lines): Now static.
2284
20ce5912
PE
2285 * image.c (gif_load): Rename local to avoid shadowing.
2286
9c4c5f81
PE
2287 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2288 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2289 * alloc.c (make_save_value): Integer argument is now of type
2290 ptrdiff_t, not int.
2291 (mark_object): Use ptrdiff_t, not int.
2292 * lisp.h (pD): New macro.
2293 * print.c (print_object): Use it.
2294
c0c5c8ae
PE
2295 * alloc.c: Use EMACS_INT, not int, to count objects.
2296 (total_conses, total_markers, total_symbols, total_vector_size)
2297 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2298 (total_free_floats, total_floats, total_free_intervals)
2299 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2300 Now EMACS_INT, not int. All uses changed.
2301 (Fgarbage_collect): Compute overall total using a double, so that
2302 integer overflow is less likely to be a problem. Check for overflow
2303 when converting back to an integer.
5a25e253
PE
2304 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2305 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2306 These were 'int' variables that could overflow on 64-bit hosts;
2307 they were never used, so remove them instead of repairing them.
211a0b2a 2308 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2309 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2310 Previously, this ceilinged at INT_MAX, but that doesn't work on
2311 64-bit machines.
e46bb31a 2312 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2313
c78baabf 2314 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2315 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2316 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2317 when a (possibly-narrower) signed value would do just as well.
2318 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2319
c9d624c6
PE
2320 * alloc.c: Catch some string size overflows that we were missing.
2321 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2322 for convenience in STRING_BYTES_MAX.
2323 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2324 The definition here is exact; the one in lisp.h was approximate.
2325 (allocate_string_data): Check for string overflow. This catches
2326 some instances we weren't catching before. Also, it catches
2327 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2328 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2329 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2330
c9d624c6
PE
2331 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2332 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2333 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2334
353032ce
PE
2335 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2336
2bccce07
PE
2337 * alloc.c (Fmake_string): Check for out-of-range init.
2338
0ac30604
SM
23392011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2340
2341 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2342
c195f2de
JD
23432011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2344
2345 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2346 xg_get_default_scrollbar_width.
2347
2348 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2349 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2350 (style_changed_cb): Call update_theme_scrollbar_width and call
2351 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2352 all frames (Bug#8505).
2353 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2354 Call gtk_window_set_resizable if HAVE_GTK3.
2355 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2356 and height if HAVE_GTK3 (Bug#8505).
2357 (scroll_bar_width_for_theme): New variable.
2358 (update_theme_scrollbar_width): New function.
2359 (xg_get_default_scrollbar_width): Move code to
2360 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2361 (xg_initialize): Call update_theme_scrollbar_width.
2362
2363 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2364
2365 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2366
e10ac9f1
MR
23672011-06-12 Martin Rudalics <rudalics@gmx.at>
2368
2369 * frame.c (make_frame): Call other_buffer_safely instead of
2370 other_buffer.
2371
2372 * window.c (temp_output_buffer_show): Call display_buffer with
2373 second argument Vtemp_buffer_show_specifiers and reset latter
2374 immediately after the call.
2375 (Vtemp_buffer_show_specifiers): New variable.
2376 (auto_window_vscroll_p, next_screen_context_lines)
2377 (Vscroll_preserve_screen_position): Remove leading asterisks from
2378 doc-strings.
2379
2d3c217e 23802011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2381
7b7f97e8 2382 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2383 * buffer.c (Qclone_number): Remove for now, as it's unused.
2384 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2385 (record_buffer): Remove unused local.
2386 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2387 (set_frame_buffer_list): Remove; unused.
2388 * frame.h (other_visible_frames): Remove decl.
2389 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2390 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2391 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2392 if HAVE_GPM.
2393 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2394 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2395 Define only if HAVE_GPM.
2396 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2397 (update_hints_inhibit): Remove; never set. All uses removed.
2398 * widgetprv.h (emacsFrameClassRec): Remove decl.
2399 * window.c (delete_deletable_window): Now returns void, since it
2400 wasn't returning anything.
2401 (compare_window_configurations): Remove unused locals.
2402 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2403 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2404 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2405 the same widths as pointers. This follows up on the 2011-05-06 patch.
2406 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2407 * xterm.h: Likewise.
2408 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2409
1384b89e
JB
24102011-06-12 Juanma Barranquero <lekktu@gmail.com>
2411
2412 * makefile.w32-in: Update dependencies.
2413 (LISP_H): Add lib/intprops.h.
2414
1100a63c
CY
24152011-06-11 Chong Yidong <cyd@stupidchicken.com>
2416
2417 * image.c (gif_load): Add animation frame delay to the metadata.
2418 (syms_of_image): Use DEFSYM. New symbol `delay'.
2419
6198ccd0
MR
24202011-06-11 Martin Rudalics <rudalics@gmx.at>
2421
2422 * window.c (delete_deletable_window): Re-add.
2423 (Fset_window_configuration): Rewrite to handle dead buffers and
2424 consequently deletable windows.
2425 (window_tree, Fwindow_tree): Remove. Supply functionality in
2426 window.el.
2427 (compare_window_configurations): Simplify code.
2428
b6e3633c
AS
24292011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2430
1ab0dee5
AS
2431 * image.c (imagemagick_load_image): Fix type mismatch.
2432 (Fimagemagick_types): Likewise.
2433
b6e3633c
AS
2434 * window.h (replace_buffer_in_windows): Declare.
2435
9397e56f
MR
24362011-06-11 Martin Rudalics <rudalics@gmx.at>
2437
2438 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2439 Qclone_number. Remove external declaration of Qdelete_window.
2440 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2441 code.
640c8776
SM
2442 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2443 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2444 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2445 buffer list implementation.
2446 (other_buffer_safely): New function.
2447 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2448 calls to replace_buffer_in_windows and
2449 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2450 if allowed.
2451 (record_buffer): Inhibit quitting and rewrite using quittable
2452 functions. Run Qbuffer_list_update_hook if allowed.
2453 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2454 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2455 Move switch-to-buffer to window.el.
9397e56f
MR
2456 (bury-buffer): Move to window.el.
2457 (Vbuffer_list_update_hook): New variable.
2458
2459 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2460 section.
2461
2462 * window.h (resize_frame_windows): Move up in code.
2463 (Fwindow_frame): Remove EXFUN.
2464 (replace_buffer_in_all_windows): Remove prototype.
2465 (replace_buffer_in_windows_safely): Add prototype.
2466
2467 * window.c: Declare Qdelete_window static again. Move down
2468 declaration of select_count.
2469 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2470 (Fother_window): Move to window.el.
2471 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2472 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2473 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2474 window.el.
2475 (replace_buffer_in_windows): Implement by calling
2476 Qreplace_buffer_in_windows.
2477 (replace_buffer_in_all_windows): Remove with some functionality
2478 moved into replace_buffer_in_windows_safely.
2479 (replace_buffer_in_windows_safely): New function.
2480 (select_window_norecord, select_frame_norecord): Move in front
2481 of run_window_configuration_change_hook. Remove now obsolete
2482 declarations.
640c8776
SM
2483 (Fset_window_buffer): Rewrite doc-string.
2484 Call Qrecord_window_buffer.
9397e56f
MR
2485 (keys_of_window): Move binding for other-window to window.el.
2486
b50691aa
CY
24872011-06-11 Chong Yidong <cyd@stupidchicken.com>
2488
2489 * dispextern.h (struct image): Replace data member, whose int_val
2490 and ptr_val fields were not used by anything, with a single
2491 lisp_val object.
2492
2493 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2494 (gif_clear_image, gif_load, imagemagick_load_image)
2495 (gs_clear_image, gs_load): Callers changed.
2496
3f754b86
PE
24972011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2498
cca69397
PE
2499 * buffer.h: Include <time.h>, for time_t.
2500 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2501
109e28d0
PE
2502 Fix minor problems found by static checking.
2503
60737f02
PE
2504 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2505
4b66faf3
PE
2506 Make identifiers static if they are not used in other modules.
2507 * data.c (Qcompiled_function, Qframe, Qvector):
2508 * image.c (QimageMagick, Qsvg):
2509 * minibuf.c (Qmetadata):
2510 * window.c (resize_window_check, resize_root_window): Now static.
2511 * window.h (resize_window_check, resize_root_window): Remove decls.
2512
109e28d0
PE
2513 * window.c (window_deletion_count, delete_deletable_window):
2514 Remove; unused.
46a4ce9e
PE
2515 (window_body_lines): Now static.
2516 (Fdelete_other_windows_internal): Mark vars as initialized.
2517 Make sure 'resize_failed' is initialized.
2518 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2519 (resize_window_apply): Remove unused local.
2520 * window.h (delete_deletable_window): Remove decl.
2521
109e28d0 2522 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2523 (imagemagick_load_image): Fix pointer signedness problem by changing
2524 last arg from unsigned char * to char *. All uses changed.
2525 Also, fix a local for similar reasons.
2526 Remove unused locals. Remove locals to avoid shadowing.
2527 (fn_rsvg_handle_free): Remove; unused.
2528 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2529 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2530
3f754b86
PE
2531 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2532
2547adb1
CY
25332011-06-10 Chong Yidong <cyd@stupidchicken.com>
2534
2535 * image.c (gif_load): Fix omitted cast error introduced by
2536 2011-06-06 change.
2537
2c8e37d4
MR
25382011-06-10 Martin Rudalics <rudalics@gmx.at>
2539
2540 * window.h (resize_proportionally, orig_total_lines)
2541 (orig_top_line): Remove from window structure.
2542 (set_window_height, set_window_width, change_window_heights)
2543 (Fdelete_window): Remove prototypes.
2544 (resize_frame_windows): Remove duplicate declaration.
2545
440a42e3
EZ
25462011-06-10 Eli Zaretskii <eliz@gnu.org>
2547
2548 * window.h (resize_frame_windows, resize_window_check)
2549 (delete_deletable_window, resize_root_window)
2550 (resize_frame_windows): Declare prototypes.
2551
2552 * window.c (resize_window_apply): Make definition be "static" to
2553 match the prototype.
2554
562dd5e9
MR
25552011-06-10 Martin Rudalics <rudalics@gmx.at>
2556
2557 * window.c: Remove declarations of Qwindow_size_fixed,
2558 window_min_size_1, window_min_size_2, window_min_size,
2559 size_window, window_fixed_size_p, enlarge_window, delete_window.
2560 Remove static from declaration of Qdelete_window, it's
2561 temporarily needed by Fbury_buffer.
2562 (replace_window): Don't assign orig_top_line and
2563 orig_total_lines.
2564 (Fdelete_window, delete_window): Remove. Window deletion is
2565 handled by window.el.
640c8776
SM
2566 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2567 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2568 (Fdelete_other_windows): Remove. Deleting other windows is
2569 handled by window.el.
2570 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2571 handled in window.el.
2572 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2573 Window minimum sizes are handled in window.el.
2574 (shrink_windows, size_window, set_window_height)
2575 (set_window_width, change_window_heights, window_height)
2576 (window_width, CURBEG, CURSIZE, enlarge_window)
2577 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2578 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2579 handled in window.el.
2580 (make_dummy_parent): Rename to make_parent_window and give it a
2581 second argument horflag.
2582 (make_window): Don't set resize_proportionally any more.
2583 (Fsplit_window): Remove. Windows are split in window.el.
2584 (save_restore_action, save_restore_orig_size)
2585 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2586 Resize mini windows in window.el.
2587 (grow_mini_window, shrink_mini_window): Implement by calling
2588 Qresize_root_window_vertically, resize_window_check and
2589 resize_window_apply.
640c8776
SM
2590 (saved_window, Fset_window_configuration, save_window_save):
2591 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2592 resize_proportionally.
2593 (window_min_height, window_min_width): Move to window.el.
2594 (keys_of_window): Move bindings for delete-other-windows,
2595 split-window, delete-window and enlarge-window to window.el.
2596
2597 * buffer.c: Temporarily extern Qdelete_window.
2598 (Fbury_buffer): Temporarily call Qdelete_window instead of
2599 Fdelete_window (Fbury_buffer will move to window.el soon).
2600
2601 * frame.c (set_menu_bar_lines_1): Remove code handling
2602 orig_top_line and orig_total_lines.
2603
2604 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2605 set_window_height but set heights directly.
2606 (change_frame_size_1): Use resize_frame_windows.
2607
2608 * xdisp.c (init_xdisp): Don't use set_window_height but set
2609 heights directly.
2610
640c8776
SM
2611 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2612 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2613 run_window_configuration_change_hook.
2614
2615 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2616 instead of change_window_heights and run
2617 run_window_configuration_change_hook.
2618
1a13852e
MR
26192011-06-09 Martin Rudalics <rudalics@gmx.at>
2620
2621 * window.c (replace_window): Rename second argument REPLACEMENT to
2622 NEW. New third argument SETFLAG. Rewrite.
2623 (delete_window, make_dummy_parent): Call replace_window with
2624 third argument 1.
2625 (window_list_1): Move down in code.
2626 (run_window_configuration_change_hook): Move set_buffer part
2627 before select_frame_norecord part in order to unwind correctly.
2628 Rename count1 to count.
2629 (recombine_windows, delete_deletable_window, resize_root_window)
2630 (Fdelete_other_windows_internal)
2631 (Frun_window_configuration_change_hook, make_parent_window)
2632 (resize_window_check, resize_window_apply, Fresize_window_apply)
2633 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2634 (Fdelete_window_internal, Fresize_mini_window_internal):
2635 New functions.
1a13852e
MR
2636 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2637
f3d1777e
MR
26382011-06-08 Martin Rudalics <rudalics@gmx.at>
2639
496e208e
MR
2640 * window.h (window): Add some new members to window structure -
2641 normal_lines, normal_cols, new_total, new_normal, clone_number,
2642 splits, nest, prev_buffers, next_buffers.
2643 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2644 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2645
f3d1777e
MR
2646 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2647 Remove.
496e208e
MR
2648 (make_dummy_parent): Set new members of windows structure.
2649 (make_window): Move down in code. Handle new members of window
2650 structure.
2651 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2652 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2653 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2654 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2655 (Fset_window_next_buffers, Fset_window_clone_number):
2656 New functions.
496e208e
MR
2657 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2658 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2659 Doc-string fixes.
2660 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2661 Argument WINDOW can be now internal window too.
2662 (Fwindow_use_time): Move up in code.
2663 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2664 Rewrite doc-string.
2665 (Fset_window_configuration, saved_window)
2666 (Fcurrent_window_configuration, save_window_save): Handle new
2667 members of window structure.
b9e809c2
MR
2668 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2669 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2670 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2671 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2672 Qget_mru_window, Qresize_root_window,
2673 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2674 Qauto_buffer_name; staticpro them.
f3d1777e 2675
abde8f8c
MR
26762011-06-07 Martin Rudalics <rudalics@gmx.at>
2677
2678 * window.c (Fwindow_total_size, Fwindow_left_column)
2679 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2680 (Fwindow_list_1): New functions.
2681 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2682 (Fwindow_width, Fscroll_left, Fscroll_right):
2683 Use window_body_cols instead of window_box_text_cols.
2684 (delete_window, Fset_window_configuration):
2685 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2686 (delete_all_subwindows): Take a window as argument and not a
2687 structure. Rewrite.
190b47e6
MR
2688 (window_loop): Remove handling of GET_LRU_WINDOW and
2689 GET_LARGEST_WINDOW.
2690 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2691
2692 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2693 window_box_text_cols. delete_all_subwindows now takes a
2694 Lisp_Object as argument.
abde8f8c 2695
640c8776
SM
2696 * indent.c (compute_motion, Fcompute_motion):
2697 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2698
fa8a67e6
MR
2699 * frame.c (delete_frame): Call delete_all_subwindows with root
2700 window as argument.
2701
a54e3482
DC
27022011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2703
2704 * fns.c (Fputhash): Document return value.
2705
60002bf5
CY
27062011-06-06 Chong Yidong <cyd@stupidchicken.com>
2707
2708 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2709
0c671da6 27102011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2711
b862a52a 2712 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2713
be44ca6c
PE
2714 Check for overflow when converting integer to cons and back.
2715 * charset.c (Fdefine_charset_internal, Fdecode_char):
2716 Use cons_to_unsigned to catch overflow.
2717 (Fencode_char): Use INTEGER_TO_CONS.
2718 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2719 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2720 * data.c (long_to_cons, cons_to_long): Remove.
2721 (cons_to_unsigned, cons_to_signed): New functions.
2722 These signal an error for invalid or out-of-range values.
2723 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2724 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2725 * font.c (Ffont_variation_glyphs):
2726 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2727 * lisp.h: Include <intprops.h>.
2728 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2729 (cons_to_signed, cons_to_unsigned): New decls.
2730 (long_to_cons, cons_to_long): Remove decls.
2731 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2732 (Fprimitive_undo): Use CONS_TO_INTEGER.
2733 * xfns.c (Fx_window_property): Likewise.
2734 * xselect.c: Include <limits.h>.
2735 (x_own_selection, selection_data_to_lisp_data):
2736 Use INTEGER_TO_CONS.
2737 (x_handle_selection_request, x_handle_selection_clear)
2738 (x_get_foreign_selection, Fx_disown_selection_internal)
2739 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2740 (lisp_data_to_selection_data): Use cons_to_unsigned.
2741 (x_fill_property_data): Use cons_to_signed.
2742 Report values out of range.
2743
d1f3d2af
PE
2744 Check for buffer and string overflow more precisely.
2745 * buffer.h (BUF_BYTES_MAX): New macro.
2746 * lisp.h (STRING_BYTES_MAX): New macro.
2747 * alloc.c (Fmake_string):
2748 * character.c (string_escape_byte8):
2749 * coding.c (coding_alloc_by_realloc):
2750 * doprnt.c (doprnt):
2751 * editfns.c (Fformat):
2752 * eval.c (verror):
2753 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2754 since they may not be the same number.
2755 * editfns.c (Finsert_char):
2756 * fileio.c (Finsert_file_contents):
2757 Likewise for BUF_BYTES_MAX.
2758
dd52fcea
PE
2759 * image.c: Use ptrdiff_t, not int, for sizes.
2760 (slurp_file): Switch from int to ptrdiff_t.
2761 All uses changed.
2762 (slurp_file): Check that file size fits in both size_t (for
2763 malloc) and ptrdiff_t (for sanity and safety).
2764
7f9bbdbb
PE
2765 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2766 if b->modtime has its maximal value.
2767
dfe18f82
PE
2768 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2769
84acfcf0
PE
2770 Don't assume time_t can fit into int.
2771 * buffer.h (struct buffer.modtime): Now time_t, not int.
2772 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2773 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2774
ccd9a01a
PE
2775 Minor fixes for signed vs unsigned integers.
2776 * character.h (MAYBE_UNIFY_CHAR):
2777 * charset.c (maybe_unify_char):
2778 * keyboard.c (read_char, reorder_modifiers):
2779 XINT -> XFASTINT, since the integer must be nonnegative.
2780 * ftfont.c (ftfont_spec_pattern):
2781 * keymap.c (access_keymap, silly_event_symbol_error):
2782 XUINT -> XFASTINT, since the integer must be nonnegative.
2783 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2784 since it makes no difference and we prefer signed.
2785 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2786 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2787 nonnegative.
2788
d6d100dd
SM
27892011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2790
2791 * window.h (Fwindow_frame): Declare.
2792
2b6148e4
PE
27932011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2794
2795 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2796 (SPARE_MEMORY): Always define.
2797 (LARGE_REQUEST): Remove.
2798 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2799
f230ecc9
MR
28002011-06-06 Martin Rudalics <rudalics@gmx.at>
2801
727e958e
MR
2802 * lisp.h: Move EXFUNS for Fframe_root_window,
2803 Fframe_first_window and Fset_frame_selected_window to window.h.
2804
2805 * window.h: Move EXFUNS for Fframe_root_window,
2806 Fframe_first_window and Fset_frame_selected_window here from
2807 lisp.h.
2808
2809 * frame.c (Fwindow_frame, Fframe_first_window)
2810 (Fframe_root_window, Fframe_selected_window)
2811 (Fset_frame_selected_window): Move to window.c.
2812 (Factive_minibuffer_window): Move to minibuf.c.
2813 (Fother_visible_frames_p): New function.
2814
2815 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2816
f230ecc9
MR
2817 * window.c (decode_window, decode_any_window): Move up in code.
2818 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2819 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2820 (Fwindow_buffer): Move up and rewrite doc-string.
2821 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2822 (Fwindow_prev): New functions.
727e958e
MR
2823 (Fwindow_frame): Move here from frame.c. Accept any window as
2824 argument.
2825 (Fframe_root_window, Fframe_first_window)
2826 (Fframe_selected_window): Move here from frame.c. Accept frame
2827 or arbitrary window as argument. Update doc-strings.
2828 (Fminibuffer_window): Move up in code.
2829 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2830 (Fset_frame_selected_window): Move here from frame.c.
2831 Marginal rewrite.
727e958e
MR
2832 (Fselected_window, select_window, Fselect_window): Move up in
2833 code. Minor doc-string fixes.
f230ecc9 2834
4d09bcf6
PE
28352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2836
2837 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2838 Do not assume that spare memory exists; that assumption is valid
2839 only if SYSTEM_MALLOC.
2840 (LARGE_REQUEST): New macro, so that the issue of large requests
2841 is separated from the issue of spare memory.
2842
810928a2
AS
28432011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2844
172418ad
AS
2845 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2846 format. (Bug#8806)
2847
43f862f7
AS
2848 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2849
810928a2
AS
2850 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2851 before statements.
2852
a059fe24
JD
28532011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2854
2855 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2856
2857 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2858
2859 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2860 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2861
989bf368
JB
28622011-06-05 Juanma Barranquero <lekktu@gmail.com>
2863
2864 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2865
4b80f674
CY
28662011-06-04 Chong Yidong <cyd@stupidchicken.com>
2867
2868 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2869 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2870 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2871 New error handlers.
4b80f674
CY
2872 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2873 Obey Vx_select_enable_clipboard_manager. Catch errors in
2874 x_clipboard_manager_save (Bug#8779).
2875 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2876 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2877
99a33b77 28782011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2879
2880 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2881
99a33b77 28822011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2883
2884 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2885 in the current matrix if keep_current_p is non-zero.
2886
8264569d
EZ
28872011-06-04 Eli Zaretskii <eliz@gnu.org>
2888
2889 * bidi.c (bidi_level_of_next_char): Fix last change.
2890
57f97249
EZ
28912011-06-03 Eli Zaretskii <eliz@gnu.org>
2892
fec2107c 2893 Support bidi reordering of text covered by display properties.
57f97249 2894
fec2107c
EZ
2895 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2896 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2897 (bidi_cache_search, bidi_cache_iterator_state)
2898 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2899 (bidi_level_of_next_char, bidi_move_to_visually_next):
2900 Support character positions inside a run of characters covered by a
fec2107c
EZ
2901 display string.
2902 (bidi_paragraph_init, bidi_resolve_explicit_1)
2903 (bidi_level_of_next_char): Call bidi_fetch_char and
2904 bidi_fetch_char_advance instead of FETCH_CHAR and
2905 FETCH_CHAR_ADVANCE.
2906 (bidi_init_it): Initialize new members.
2907 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2908 definitions.
2909 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2910 instead of using explicit *_CHAR codes.
d6d100dd
SM
2911 (bidi_resolve_explicit, bidi_resolve_weak):
2912 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2913 bidirectional text is supported only in multibyte buffers.
2914 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2915 it to initialize the frame_window_p member of struct bidi_it.
2916 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2917 (bidi_resolve_explicit, bidi_resolve_weak)
2918 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2919 bidi_it->nchars is non-positive.
2920 (bidi_level_of_next_char): Don't try to lookup the cache for the
2921 next/previous character if nothing is cached there yet, or if we
2922 were just reseat()'ed to a new position.
c40e2fb2 2923
0e14fe90
EZ
2924 * xdisp.c (set_cursor_from_row): Set start and stop points
2925 according to the row's direction when priming the loop that looks
2926 for the glyph on which to display cursor.
2927 (single_display_spec_intangible_p): Function deleted.
2928 (display_prop_intangible_p): Reimplement to call
2929 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2930 Accept 3 additional arguments needed by handle_display_spec.
2931 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2932 values: lists, `(when COND...)' forms, etc.
2933 (single_display_spec_string_p): Support property values that are
2934 lists with the argument STRING its top-level element.
2935 (display_prop_string_p): Fix the condition for processing a
2936 property that is a list to be consistent with handle_display_spec.
fec2107c 2937 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2938 last portion of handle_display_prop.
2939 (compute_display_string_pos): Accept additional argument
2940 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2941 value of a `display' property is a "replacing spec".
2942 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2943 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2944 the display property, but just return a value indicating whether
2945 the display property will replace the characters it covers.
2946 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2947 frame_window_p members of struct bidi_it.
d6d100dd
SM
2948 (compute_display_string_pos, compute_display_string_end):
2949 New functions.
fec2107c
EZ
2950 (push_it): Accept second argument POSITION, where pop_it should
2951 jump to continue iteration.
2952 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2953
fec2107c
EZ
2954 * keyboard.c (adjust_point_for_property): Adjust the call to
2955 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2956
2957 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2958 (bidi_init_it): Update prototypes.
2959 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2960 (compute_display_string_pos, compute_display_string_end):
2961 Declare prototypes.
fec2107c
EZ
2962 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2963 EMACS_INT.
fc6f18ce 2964
40087514 29652011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2966
57f53182
PE
2967 Malloc failure behavior now depends on size of allocation.
2968 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2969 * lisp.h: Change signatures accordingly.
2970 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2971 All callers changed. (Bug#8762)
2972
2973 * gnutls.c: Use Emacs's memory allocators.
2974 Without this change, the gnutls library would invoke malloc etc.
2975 directly, which causes problems on non-SYNC_INPUT hosts, and which
2976 runs afoul of improving memory_full behavior. (Bug#8761)
2977 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2978 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2979 xfree instead of the default malloc, realloc, free.
2980 (Fgnutls_boot): No need to check for memory allocation failure,
2981 since xmalloc does that for us.
2982
ac32cd99 2983 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2984 * category.c (hash_get_category_set):
2985 * ccl.c (ccl_driver):
2986 * charset.c (Fdefine_charset_internal):
2987 * charset.h (struct charset.hash_index):
2988 * composite.c (get_composition_id, gstring_lookup_cache)
2989 (composition_gstring_put_cache):
2990 * composite.h (struct composition.hash_index):
2991 * dispextern.h (struct image.hash):
2992 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2993 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2994 (hashfn_equal, hashfn_user_defined, make_hash_table)
2995 (maybe_resize_hash_table, hash_lookup, hash_put)
2996 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2997 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2998 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2999 * image.c (make_image, search_image_cache, lookup_image)
3000 (xpm_put_color_table_h):
3001 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3002 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3003 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3004 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3005 * alloc.c (allocate_vectorlike):
3006 Check for overflow in vector size calculations.
3007 * ccl.c (ccl_driver):
3008 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3009 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3010 need to be updated by these changes.
40087514
PE
3011 * fns.c (make_hash_table, maybe_resize_hash_table):
3012 Check for integer overflow with large hash tables.
0de4bb68
PE
3013 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3014 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3015 (SXHASH_REDUCE): New macro.
3016 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3017 Use it instead of discarding useful hash info with large hash values.
3018 (sxhash_float): New function.
3019 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3020 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3021 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3022 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3023 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3024 Adjust signatures to match updated version of code.
3025 (consing_since_gc): Now EMACS_INT, since a single hash table can
3026 use more than INT_MAX bytes.
3027
698d32e2
DN
30282011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3029
3030 Make it possible to build with GCC-4.6+ -O2 -flto.
3031
3032 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3033
fd6fa53f
SM
30342011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3035
3036 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3037 Call minibuffer-inactive-mode.
3038
864db017
JB
30392011-05-31 Juanma Barranquero <lekktu@gmail.com>
3040
3041 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3042 Update dependencies.
3043
2ad0baf4
DN
30442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3045
3046 * data.c (init_data): Remove code for UTS, this system is not
3047 supported anymore.
3048
4fcc2638
DN
30492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3050
3051 Don't force ./temacs to start in terminal mode.
3052
3053 * frame.c (make_initial_frame): Initialize faces in all cases, not
3054 only when CANNOT_DUMP is defined.
3055 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3056
c56e0fd5
DN
30572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3058
3059 * dispnew.c (add_window_display_history): Use const for the string
3060 pointer. Remove declaration, not needed.
3061
333d54da 30622011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3063
55d4c1b2 3064 Use 'inline', not 'INLINE'.
333d54da 3065 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3066 * alloc.c, fontset.c (INLINE): Remove.
3067 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3068 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3069 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3070 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3071 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3072
738db178
DN
30732011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3074
3075 Make it possible to run ./temacs.
3076
3077 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3078 syms_of_callproc does the same thing. Remove test for
3079 "initialized", do it in the caller.
3080 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3081
620c53a6
SM
30822011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3083
3084 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3085 (read_minibuf): Use get_minibuffer.
3086 (syms_of_minibuf): Use DEFSYM.
3087 (Qmetadata): New var.
3088 * data.c (Qbuffer): Don't make it static.
3089 (syms_of_data): Use DEFSYM.
3090
e003a292
PE
30912011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3092
3093 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3094 (CCL_CODE_MIN): New macro.
3095
ed008a6d
PE
30962011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3097
3687c2ef
PE
3098 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3099
ed008a6d
PE
3100 * eval.c (Qdebug): Now static.
3101 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3102 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3103 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3104
d66c4c7c
CY
31052011-05-29 Chong Yidong <cyd@stupidchicken.com>
3106
3107 * image.c: Various fixes to ImageMagick code comments.
3108 (Fimagemagick_types): Doc fix.
3109
5fbc2025
PE
31102011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3111
0196f88a
PE
3112 Minor fixes prompted by GCC 4.6.0 warnings.
3113
3114 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3115
5fbc2025
PE
3116 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3117 (x_clipboard_manager_save_all): Move extern decl to ...
3118 * xterm.h: ... here, so that it can be checked for consistency.
3119
1dd3c2d9
CY
31202011-05-29 Chong Yidong <cyd@stupidchicken.com>
3121
3122 * xselect.c (x_clipboard_manager_save_frame)
3123 (x_clipboard_manager_save_all): New functions.
3124 (Fx_clipboard_manager_save): Lisp function deleted.
3125
3126 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3127 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3128
3129 * xterm.h: Update prototype.
3130
5ba6571d
WX
31312011-05-28 William Xu <william.xwl@gmail.com>
3132
3133 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3134 exiting (Bug#8239).
3135
3eaff834
JM
31362011-05-28 Jim Meyering <meyering@redhat.com>
3137
e1900994 3138 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3139 * fns.c (to_uchar): Define.
3140 (crypto_hash_function): Use it to convert some newly-signed
3141 variables to unsigned, to avoid sign-extension bugs. For example,
3142 without this change, (md5 "truc") would evaluate to
3143 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3144 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3145 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3146
0f6990a7
PE
31472011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 Integer overflow fixes.
c8a9ca5a 3150
08686060
PE
3151 * dbusbind.c: Serial number integer overflow fixes.
3152 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3153 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3154 to hold a serial number that is too large for a fixnum.
3155 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3156 Check for serial numbers out of range. Decode any serial number
59568bf0 3157 that was so large that it became a float. (Bug#8722)
08686060 3158
2d1fc3c7
PE
3159 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3160 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3161 Use XFASTINT rather than XUINT when numbers are nonnegative.
3162 (xd_append_arg, Fdbus_method_return_internal):
3163 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3164 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3165 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3166 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3167 (Bug#8722)
2d1fc3c7 3168
c8a9ca5a
PE
3169 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3170
519e1d69
PE
3171 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3172
30569699
PE
3173 ccl: add integer overflow checks
3174 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3175 (IN_INT_RANGE): New macros.
3176 (ccl_driver): Use them to check for integer overflow when
3177 decoding a CCL program. Many of the new checks are whether XINT (x)
3178 fits in int; it doesn't always, on 64-bit hosts. The new version
3179 doesn't catch all possible integer overflows, but it's an
847044ea 3180 improvement. (Bug#8719)
30569699 3181
c11285dc
PE
3182 * alloc.c (make_event_array): Use XINT, not XUINT.
3183 There's no need for unsigned here.
3184
fdccd48e
PE
3185 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3186 This follows up to the 2011-05-06 change that substituted uintptr_t
3187 for EMACS_INT. This case wasn't caught back then.
3188
37910ab2
PE
3189 Rework Fformat to avoid integer overflow issues.
3190 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3191 now (part of C89). Include <verify.h>.
3192 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3193 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3194 (Fformat): Avoid the prepass trying to compute sizes; it was only
3195 approximate and thus did not catch overflow reliably. Instead, walk
3196 through the format just once, formatting and computing sizes as we go,
3197 checking for integer overflow at every step, and allocating a larger
3198 buffer as needed. Keep track separately whether the format is
3199 multibyte. Keep only the most-recently calculated precision, rather
3200 than them all. Record whether each argument has been converted to
3201 string. Use EMACS_INT, not int, for byte and char and arg counts.
3202 Support field widths and precisions larger than INT_MAX. Avoid
3203 sprintf's undefined behavior with conversion specifications such as %#d
3204 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3205 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3206 formatting out-of-range floating point numbers with int
9173deec 3207 formats. (Bug#8668)
37910ab2 3208
2e6578fb
PE
3209 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3210
0ae6bdee
PE
3211 * data.c: Avoid integer truncation in expressions involving floats.
3212 * data.c: Include <intprops.h>.
3213 (arith_driver): When there's an integer overflow in an expression
3214 involving floating point, convert the integers to floating point
3215 so that the resulting value does not suffer from catastrophic
3216 integer truncation. For example, on a 64-bit host (* 4
3217 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3218 Do not rely on undefined behavior after integer overflow.
3219
de883a70
PE
3220 merge count_size_as_multibyte, parse_str_to_multibyte
3221 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3222 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3223 Check for integer overflow.
3224 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3225 since it's now a duplicate of the other. This is more of
3226 a character than a buffer op, so better that it's in character.c.
3227 * fns.c, print.c: Adjust to above changes.
3228
2ff916cb
PE
32292011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3230
3231 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3232
f1b54466
PE
32332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3234
fb1ac845
PE
3235 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3236 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3237 (x_clipboard_manager_save): Now static.
3238 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3239
f1b54466
PE
3240 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3241 (crypto_hash_function): Now static.
3242 Fix pointer signedness problems. Avoid unnecessary initializations.
3243
a9f737ee
CY
32442011-05-27 Chong Yidong <cyd@stupidchicken.com>
3245
3246 * termhooks.h (Vselection_alist): Make it terminal-local.
3247
3248 * terminal.c (create_terminal): Initialize it.
3249
3250 * xselect.c: Support for clipboard managers.
3251 (Vselection_alist): Move to termhooks.h as terminal-local var.
3252 (LOCAL_SELECTION): New macro.
3253 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3254 (symbol_to_x_atom): Remove gratuitous arg.
3255 (x_handle_selection_request, lisp_data_to_selection_data)
3256 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3257 (x_own_selection, x_get_local_selection, x_convert_selection):
3258 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3259 (some_frame_on_display): Delete unused function.
3260 (Fx_own_selection_internal, Fx_get_selection_internal)
3261 (Fx_disown_selection_internal, Fx_selection_owner_p)
3262 (Fx_selection_exists_p): New optional frame arg.
3263 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3264 (x_handle_selection_clear): Don't treat other terminals with the
3265 same keyboard specially. Use the terminal-local Vselection_alist.
3266 (x_clear_frame_selections): Use Frun_hook_with_args.
3267
3268 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3269
3270 * xterm.h: Add support for those atoms.
3271
e067f0c1
CY
32722011-05-26 Chong Yidong <cyd@stupidchicken.com>
3273
3274 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3275 (converted_selections, conversion_fail_tag): New global variables.
3276 (x_selection_request_lisp_error): Free the above.
3277 (x_get_local_selection): Remove unnecessary code.
3278 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3279 of converted selections stored in converted_selections.
3280 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3281 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3282 (x_convert_selection): New function.
3283 (x_handle_selection_event): Simplify.
3284 (x_get_foreign_selection): Don't ignore incoming requests while
3285 waiting for an answer; this will fail when we implement
3286 SAVE_TARGETS, and seems unnecessary anyway.
3287 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3288 (Vx_sent_selection_functions): Doc fix.
3289
0f4aebc0
LL
32902011-05-26 Leo Liu <sdl.web@gmail.com>
3291
3292 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3293
e61124cd
YM
32942011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3295
3296 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3297
3298 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3299 for fringe update if it has periodic bitmap.
ac389d0c 3300 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3301 and fringe_bitmap_periodic_p.
3302
3303 * fringe.c (get_fringe_bitmap_data): New function.
3304 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3305 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3306 row. Mark glyph row for fringe update if periodicity changed.
3307
3308 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3309 for fringe update unless it has periodic bitmap.
3310
f16d9837
KH
33112011-05-25 Kenichi Handa <handa@m17n.org>
3312
3313 * xdisp.c (get_next_display_element): Set correct it->face_id for
3314 a static composition.
3315
e1b90ef6
LL
33162011-05-24 Leo Liu <sdl.web@gmail.com>
3317
3318 * deps.mk (fns.o):
3319 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3320
3321 * fns.c (crypto_hash_function, Fsha1): New function.
3322 (Fmd5): Use crypto_hash_function.
3323 (syms_of_fns): Add Ssha1.
3324
7400048f
PE
33252011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3326
3327 * gnutls.c: Remove unused macros.
3328 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3329 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3330 Remove macros that are defined and never used.
3331 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3332
abb71cf4
CY
33332011-05-22 Chong Yidong <cyd@stupidchicken.com>
3334
3335 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3336 (Fx_get_selection_internal): Minor cleanup.
3337 (Fx_own_selection_internal): Rename arguments for consistency with
3338 select.el.
3339
6307db39
PE
33402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3343
f3d4e0a4
CY
33442011-05-22 Chong Yidong <cyd@stupidchicken.com>
3345
3346 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3347
4d8ade89
YM
33482011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3349
3350 * dispnew.c (scrolling_window): Don't exclude the case that the
3351 last enabled row in the desired matrix touches the bottom boundary.
3352
32078c8d
GM
33532011-05-21 Glenn Morris <rgm@gnu.org>
3354
3355 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3356 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3357 and add some more files.
32078c8d 3358
7285dc67
EZ
33592011-05-20 Eli Zaretskii <eliz@gnu.org>
3360
3361 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3362 report_file_error introduced by the change from 2011-05-07.
3363
89d1bd22
PE
33642011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 * systime.h (Time): Define only if emacs is defined.
3367 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3368 where the include path doesn't have X11/X.h by default. See
3369 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3370
e23640bb 33712011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3372
3373 * composite.c (find_automatic_composition): Fix previous change.
3374
b9704ad9
GM
33752011-05-20 Glenn Morris <rgm@gnu.org>
3376
3377 * lisp.mk: New file, split from Makefile.in.
3378 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3379 (shortlisp): Remove.
3380 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3381
4a720484
GM
33822011-05-19 Glenn Morris <rgm@gnu.org>
3383
3384 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3385 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3386 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3387 (lisp): Set the order to that of loadup.el.
3388 (shortlisp): Make it a copy of $lisp.
3389 (SOME_MACHINE_LISP): Remove.
3390 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3391 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3392
a28d4396
KH
33932011-05-18 Kenichi Handa <handa@m17n.org>
3394
3395 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3396 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3397 (find_automatic_composition): Mostly rewrite for efficiency.
3398
a2b1fa8e
JB
33992011-05-18 Juanma Barranquero <lekktu@gmail.com>
3400
3401 * makefile.w32-in: Update dependencies.
3402
8e1f5610
CS
34032011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3404
3405 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3406 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3407
7025ee00 34082011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3409
cdfa6eab
PE
3410 Fix some integer overflow issues, such as string length overflow.
3411
06d6db33
PE
3412 * insdel.c (count_size_as_multibyte): Check for string overflow.
3413
2b4560a8
PE
3414 * character.c (lisp_string_width): Check for string overflow.
3415 Use EMACS_INT, not int, for string indexes and lengths; in
3416 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3417 the resulting string length overflows an EMACS_INT; instead,
3418 report a string overflow if no precision given. When checking for
3419 precision exhaustion, use a check that cannot possibly have
3420 integer overflow. (Bug#8675)
3421 * character.h (lisp_string_width): Adjust to new signature.
3422
cb93f9be
PE
3423 * alloc.c (string_overflow): New function.
3424 (Fmake_string): Use it. This doesn't change behavior, but saves
3425 a few bytes and will simplify future changes.
3426 * character.c (string_escape_byte8): Likewise.
3427 * lisp.h (string_overflow): New decl.
3428
1a1f3366
PE
3429 Fixups, following up to the user-interface timestamp change.
3430 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3431 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3432 * msdos.c (mouse_get_pos): Likewise.
3433 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3434 * w32gui.h (Time): Define by including "systime.h" rather than by
3435 declaring it ourselves. (Bug#8664)
3436
d4e3e4d3
PE
3437 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3438 * image.c (clear_image_cache): Likewise.
3439
f6a24d19
PE
3440 * term.c (term_mouse_position): Don't assume time_t wraparound.
3441
08dc5ae6
PE
3442 Be more systematic about user-interface timestamps.
3443 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3444 and sometimes 'EMACS_UINT', to represent these timestamps.
3445 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3446 This makes the code easier to follow, and makes it easier to catch
3447 integer overflow bugs such as Bug#8664.
3448 * frame.c (Fmouse_position, Fmouse_pixel_position):
3449 Use Time, not unsigned long, for user-interface timestamps.
3450 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3451 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3452 * keyboard.h (last_event_timestamp): Likewise.
3453 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3454 * menu.h (xmenu_show): Likewise.
3455 * term.c (term_mouse_position): Likewise.
3456 * termhooks.h (struct input_event.timestamp): Likewise.
3457 (struct terminal.mouse_position_hook): Likewise.
3458 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3459 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3460 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3461 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3462 what it was before.
3463 * menu.h, termhooks.h: Include "systime.h", for Time.
3464
8e55734a
PE
3465 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3466 Don't assume that the difference between two unsigned long values
3467 can fit into an integer. At this point, we know button_down_time
3468 <= event->timestamp, so the difference must be nonnegative, so
3469 there's no need to cast the result if double-click-time is
3470 nonnegative, as it should be; check that it's nonnegative, just in
3471 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3472 apart (about 25 days). (Bug#8664)
8e55734a 3473
841f1b75 3474 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3475 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3476
3e26f69c
PE
3477 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3478 that always fit in int. Use a sentinel instead of a counter, to
3479 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3480 * frame.h (struct frame): Use int for menu_bar_items_used
3481 instead of EMACS_INT, since it always fits in int.
3e26f69c 3482
5cc152c0
PE
3483 * menu.c (grow_menu_items): Check for int overflow.
3484
d89eb65e
PE
3485 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3486
5235bd3e
PE
3487 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3488 Before, the code was not consistent. These values cannot exceed
3489 2**31 - 1 so there's no need to make them unsigned.
3490 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3491 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3492 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3493 as modifiers.
3494 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3495
bc827e23
PE
3496 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3497 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3498 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3499 presumably because the widths might not match.
3500
78eb494e
PE
3501 * window.c (size_window): Avoid needless test at loop start.
3502
04f2d78b
CB
35032011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3504
3505 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3506
d2fc7e3d 35072011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3508
3509 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3510
d2fc7e3d 35112011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3512
3513 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3514 `width' to `bar_area_x' and `bar_area_width', respectively.
3515 (x_scroll_run): Take account of fringe background extension.
3516
04f2d78b
CB
3517 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3518 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3519 `bar_area_width', respectively.
3520 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3521 background extension.
3522
79b70037
GM
35232011-05-10 Jim Meyering <meyering@redhat.com>
3524
3525 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3526
2f142cc5
JB
35272011-05-10 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * image.c (Finit_image_library): Return t for built-in image types,
3530 like pbm and xbm. (Bug#8640)
3531
57679c86
AS
35322011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3533
3534 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3535
888c9e86
EZ
35362011-05-07 Eli Zaretskii <eliz@gnu.org>
3537
b0512a1d
EZ
3538 * w32console.c (Fset_screen_color): Doc fix.
3539 (Fget_screen_color): New function.
3540 (syms_of_ntterm): Defsubr it.
3541
7285dc67
EZ
3542 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3543 unlink the temporary file if Fcall_process didn't create it in the
3544 first place.
3545 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3546 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3547 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3548 cue to call_process_cleanup not to close that handle.
3549
4d3fcc8e
BK
35502011-05-07 Ben Key <bkey76@gmail.com>
3551
3552 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3553 one of two shell specific rules, either bootstrap-temacs-CMD or
3554 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3555 to the previous implementation of the bootstrap-temacs rule.
3556 The bootstrap-temacs-CMD rule is similar to the previous
3557 implementation of the bootstrap-temacs rule except that it
3558 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3559 variable.
3560
3561 These changes, along with some changes to nt/configure.bat,
3562 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3563 earlier fix to add support for --cflags and --ldflags options
3564 that include quotes so that it works whether make uses cmd or
3565 sh as the shell.
3566
b4289b64
MA
35672011-05-06 Michael Albinus <michael.albinus@gmx.de>
3568
3569 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3570 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3571 is a constant.
3572 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3573 a string. Handle both cases.
3574 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3575 (Fdbus_register_method): Use Qinvalid_function.
3576
af4c0e28
JB
35772011-05-06 Juanma Barranquero <lekktu@gmail.com>
3578
3579 * makefile.w32-in: Update dependencies.
3580 (LISP_H): Add inttypes.h and stdin.h.
3581 (PROCESS_H): Add unistd.h.
3582
c51453d9
EZ
35832011-05-06 Eli Zaretskii <eliz@gnu.org>
3584
3585 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3586 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3587
8ff0ac3c 35882011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3589
4c4b566b
PE
3590 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3591
aab2b9b5
PE
3592 * term.c (vfatal): Remove stray call to va_end.
3593 It's not needed and the C Standard doesn't allow it here anyway.
3594
c378da0b
PE
3595 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3596 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3597
288b08c7
PE
3598 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3599 bytes.
3600
e3601888
PE
3601 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3602
db6c0e74
PE
3603 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3604
dd5963ea
PE
3605 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3606
88c9450f
PE
3607 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3608
2f9442b8
PE
3609 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3610
c032b5f8
PE
3611 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3612 * charset.c (Fdefine_charset_internal): Don't initialize
3613 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3614 32-bit int (Bug#8600).
a108c10b
PE
3615
3616 * lread.c (read_integer): Be more consistent with string-to-number.
3617 Use string_to_number to do the actual conversion; this avoids
3618 rounding errors and fixes some other screwups. Without this fix,
3619 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3620 (digit_to_number): Move earlier, for benefit of read_integer.
3621 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3622 not a digit in any supported base. (Bug#8602)
a108c10b 3623
ad5f9eea
PE
3624 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3625
aec1708a
PE
3626 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3627 to match comment at start of function. This also removes a
3628 GCC warning about overflow in a 32+64-bit port.
3629
47be4ab5
PE
3630 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3631
371cac43
PE
3632 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3633 Reported by Stefan Monnier in
3634 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3635 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3636 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3637
d01a7826
PE
3638 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3639 (EMACS_UINTPTR): Likewise, with uintptr_t.
3640
7fd47d5c
PE
3641 * lisp.h: Prefer 64-bit EMACS_INT if available.
3642 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3643 on 32-bit hosts that have 64-bit int, so that they can access
3644 large files.
122b0c86
PE
3645 However, temporarily disable this change unless the temporary
3646 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3647
8727937b
PE
3648 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3649
8ac068ac
PE
3650 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3651 This removes an assumption that EMACS_INT and long are the same
3652 width as pointers. The assumption is true for Emacs porting targets
3653 now, but we want to make other targets possible.
3654 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3655 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3656 In the rest of the code, change types of integers that hold casted
3657 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3658 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3659 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3660 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3661 No need to cast type when ORing.
3662 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3663 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3664 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3665 assume EMACS_INT is the same width as char *.
3666 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3667 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3668 Remove no-longer-needed casts.
3669 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3670 (xg_tool_bar_help_callback, xg_make_tool_item):
3671 Use EMACS_INTPTR to hold an integer
3672 that will be cast to void *; this can avoid a GCC warning
3673 if EMACS_INT is not the same width as void *.
3674 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3675 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3676 (current_message_1, set_message_1):
3677 Use a local to convert to proper width without a cast.
3678 * xmenu.c (dialog_selection_callback): Likewise.
3679
ede49d71
PE
3680 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3681 Also, don't assume VALBITS / RAND_BITS is less than 5,
3682 and don't rely on undefined behavior when shifting a 1 left into
3683 the sign bit.
3684 * lisp.h (get_random): Change signature to match.
3685
2f30ecd0
PE
3686 * lread.c (hash_string): Use size_t, not int, for hash computation.
3687 Normally we prefer signed values; but hashing is special, because
3688 it's better to use unsigned division on hash table sizes so that
3689 the remainder is nonnegative. Also, size_t is the natural width
3690 for hashing into memory. The previous code used 'int', which doesn't
3691 retain enough info to hash well into very large tables.
3692 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3693
2a866e7b
PE
3694 * dbusbind.c: Don't possibly lose pointer info when converting.
3695 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3696 Use XPNTR rather than XHASH, so that the high-order bits of
3697 the pointer aren't lost when converting through void *.
3698
51639eac
PE
3699 * eval.c (Fautoload): Don't double-shift a pointer.
3700
92394119
PE
3701 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3702
dbdb9a7c
JB
37032011-05-06 Juanma Barranquero <lekktu@gmail.com>
3704
3705 * gnutls.c (DEF_GNUTLS_FN):
3706 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3707
db7a0b4f
AS
37082011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3709
3710 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3711 marker. (Bug#8610)
3712
f7ff1b0f 37132011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3714
3715 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3716 New version that can reserve upto 2GB of heap space.
3717
f7ff1b0f 37182011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3719
3720 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3721
639c109b
TZ
37222011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3723
3724 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3725 `gnutls_certificate_set_x509_key_file'.
3726
d2127135
JB
37272011-05-05 Juanma Barranquero <lekktu@gmail.com>
3728
3729 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3730 Update dependencies.
3731
e968f4f3
JB
37322011-05-04 Juanma Barranquero <lekktu@gmail.com>
3733
3734 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3735 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3736 Remove unused parameter `fildes'.
3737 * process.c (read_process_output, send_process): Don't pass it.
3738
84d358f0
JB
37392011-05-04 Juanma Barranquero <lekktu@gmail.com>
3740
3741 Fix previous change: the library cache is defined in w32.c.
3742 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3743 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3744
0898ca10
JB
37452011-05-04 Juanma Barranquero <lekktu@gmail.com>
3746
3747 Implement dynamic loading of GnuTLS on Windows.
3748
3749 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3750 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3751 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3752 Declare.
3753
3754 * gnutls.c (Qgnutls_dll): Define.
3755 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3756 (gnutls_*): Declare function pointers.
3757 (init_gnutls_functions): New function to initialize function pointers.
3758 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3759 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3760 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3761 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3762 (emacs_gnutls_write, emacs_gnutls_read)
3763 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3764 (Fgnutls_available_p): New function.
3765 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3766 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3767 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3768
3769 * image.c: Include w32.h.
3770 (Vimage_type_cache): Delete.
3771 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3772 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3773 (w32_delayed_load): Move to w32.c.
3774
3775 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3776
3777 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3778 (w32_delayed_load): Move from image.c. When loading a library, record
3779 its filename in the :loaded-from property of the library id.
3780 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3781 Initialize and staticpro them.
3782 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3783
3784 * process.c: Include lisp.h before w32.h, not after.
3785 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3786 instead of gnutls_record_check_pending.
3787
3788 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3789
ff4de4aa
TZ
37902011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3791
3792 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3793 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3794 as passed in.
3795
abe95abb
JD
37962011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3797
3798 * xterm.c (x_set_frame_alpha): Do not set property on anything
3799 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3800
e16e55d4
JB
38012011-05-02 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3804
bafcf6a5
JB
38052011-05-02 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3808 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3809 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3810 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3811 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3812 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3813 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3814 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3815 (Qgnutls_bootprop_callbacks_verify): Make static.
3816
e7a6747f
AS
38172011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3818
19ed11ba
AS
3819 * callproc.c: Indentation fixup.
3820
e7a6747f 3821 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3822 (wait_for_termination, interruptible_wait_for_termination):
3823 Move after wait_for_termination_1.
e7a6747f 3824
1ef14cb4
LMI
38252011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826
3827 * sysdep.c (interruptible_wait_for_termination): New function
3828 which is like wait_for_termination, but allows keyboard
3829 interruptions.
3830
3831 * callproc.c (Fcall_process): Add (:file "file") as an option for
3832 the STDOUT buffer.
3833 (Fcall_process_region): Ditto.
3834
330d880c
EZ
38352011-04-30 Eli Zaretskii <eliz@gnu.org>
3836
8db90b73
EZ
3837 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3838 rather than `XVECTOR (FOO)->size'.
3839
330d880c
EZ
3840 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3841 inttypes.h, as a gnulib replacement is used if it not available in
3842 system headers.
3843
15cbd324
EZ
38442011-04-21 Eli Zaretskii <eliz@gnu.org>
3845
3846 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3847 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3848 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3849
3850 * coding.c (coding_alloc_by_realloc): Error out if destination
3851 will grow beyond MOST_POSITIVE_FIXNUM.
3852 (decode_coding_emacs_mule): Abort if there isn't enough place in
3853 charbuf for the composition carryover bytes. Reserve an extra
3854 space for up to 2 characters produced in a loop.
3855 (decode_coding_iso_2022): Abort if there isn't enough place in
3856 charbuf for the composition carryover bytes.
3857
38582011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3859
ae940cca
EZ
3860 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3861 aborting when %lld or %lll format is passed.
3862 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3863 %llo or %llx format is passed. (Bug#8545)
3864
03ab8921
EZ
3865 * window.c (window_scroll_line_based): Use a marker instead of
3866 simple variables to record original value of point. (Bug#7952)
3867
afda1437
EZ
3868 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3869 produced by %s or %c overflows available buffer space. (Bug#8545)
3870
f76dee0c
PE
38712011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3874 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3875
fdc5744d
JB
38762011-04-28 Juanma Barranquero <lekktu@gmail.com>
3877
3878 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3879
638f053a
JB
38802011-04-28 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * keyboard.c (Qdelayed_warnings_hook): Define.
3883 (command_loop_1): Run `delayed-warnings-hook'
3884 if Vdelayed_warnings_list is non-nil.
3885 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3886 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3887
d178f871
EZ
38882011-04-28 Eli Zaretskii <eliz@gnu.org>
3889
3890 * doprnt.c (doprnt): Don't return value smaller than the buffer
3891 size if the message was truncated. (Bug#8545).
3892
b124fd93
JB
38932011-04-28 Juanma Barranquero <lekktu@gmail.com>
3894
3895 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3896 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3897
e810457d
PE
38982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3899
3900 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3901
ea51cceb
JB
39022011-04-27 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * makefile.w32-in: Update dependencies.
3905
94dcfacf
EZ
39062011-04-27 Eli Zaretskii <eliz@gnu.org>
3907
3908 Improve `doprnt' and its usage. (Bug#8545)
3909 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3910 `format_end'. Remove support for %l as a conversion specifier.
3911 Don't use xrealloc. Improve diagnostics when the %l size modifier
3912 is used. Update the commentary.
3913
3914 * eval.c (verror): Simplify calculation of size_t.
3915
3916 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3917 messages.
3918
f61f41d7
PE
39192011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3920
3921 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3922 change.
3923
96fb4434
PE
39242011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3925
3926 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3927 This makes this file independent of the recent pseudovector change.
3928
671875da 39292011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3930
69e9b5a3
PE
3931 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3932
b5f869a7 3933 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3934 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3935 Remove unused local.
c8926152 3936 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3937
841a1577 3938 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3939 GCC 4.6.0 optimizes based on type-based alias analysis.
3940 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3941 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3942 != &v->size, and therefore "v->size = 1; b->size = 2; return
3943 v->size;" must therefore return 1. This assumption is incorrect
3944 for Emacs, since it type-puns struct Lisp_Vector * with many other
3945 types. To fix this problem, this patch adds a new type struct
f904488f 3946 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3947 and pseudovectors, and helps optimizing compilers not get fooled
3948 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3949 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3950 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3951 the size member.
eab3844f
PE
3952 (XSETPVECTYPE): Rewrite in terms of new macro.
3953 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3954 This is a bit clearer, and further avoids the possibility of
3955 undesirable aliasing.
3956 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3957 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3958 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3959 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3960 (ASIZE): Now uses header.size rather than size.
3961 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3962 to avoid the hassle of writing XVECTOR (foo)->header.size.
3963 (struct vectorlike_header): New type.
eab3844f
PE
3964 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3965 object, to help avoid aliasing.
3966 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3967 (SUBRP): Likewise, since Lisp_Subr is a special case.
3968 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3969 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3970 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3971 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3972 changed to be "header.size" and "header.next".
3973 * buffer.h (struct buffer): Likewise.
3974 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3975 * frame.h (struct frame): Likewise.
3976 * process.h (struct Lisp_Process): Likewise.
3977 * termhooks.h (struct terminal): Likewise.
3978 * window.c (struct save_window_data, struct saved_window): Likewise.
3979 * window.h (struct window): Likewise.
3980 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3981 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3982 * buffer.c (init_buffer_once): Likewise.
3983 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3984 special case.
3985 * process.c (Fformat_network_address): Use local var for size,
3986 for brevity.
3987
0df1eac5
PE
3988 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3989
847ab9d1 3990 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3991 * data.c (atof): Remove decl; no longer used or needed.
3992 (digit_to_number): Move to lread.c.
3993 (Fstring_to_number): Use new string_to_number function, to be
3994 consistent with how the Lisp reader treats infinities and NaNs.
3995 Do not assume that floating-point numbers represent EMACS_INT
3996 without losing information; this is not true on most 64-bit hosts.
3997 Avoid double-rounding errors, by insisting on integers when
3998 parsing non-base-10 numbers, as the documentation specifies.
3999 * lisp.h (string_to_number): New decl, replacing ...
4000 (isfloat_string): Remove.
bc0a5c13 4001 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4002 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4003 appears to have been a coding error. Similarly, do not accept
4004 strings like +-1e0 as floating point numbers. Do not report
4005 overflow for integer overflows unless the base is not 10 which
4006 means we have no simple and reliable way to continue.
4007 Break out the floating-point parsing into a new
4008 function string_to_number, so that Fstring_to_number parses
4009 floating point numbers consistently with the Lisp reader.
04f2d78b 4010 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4011 (E_CHAR, EXP_INT): Remove, replacing with ...
4012 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4013 (string_to_number): New function, replacing isfloat_string.
4014 This function checks for valid syntax and produces the resulting
4015 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4016 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4017 so that overflow for non-base-10 numbers is reported only when
4018 there's no portable and simple way to convert to floating point.
452f4150 4019
67769ffc
PE
4020 * textprop.c (set_text_properties_1): Rewrite for clarity,
4021 and to avoid GCC warning about integer overflow.
4022
c20db43f
PE
4023 * intervals.h (struct interval): Use EMACS_INT for members
4024 where EMACS_UINT might cause problems. See
4025 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4026 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4027 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4028 All uses changed.
37aa2f85
PE
4029 (offset_intervals): Tell GCC not to worry about length overflow
4030 when negating a negative length.
c20db43f 4031
2538aa2f
PE
4032 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4033 (overrun_check_free): Likewise.
4034
f2d3008d
PE
4035 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4036 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4037 word size.
4038
ec8df744
PE
4039 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4040 (gnutls_make_error): Rename local to avoid shadowing.
4041 (gnutls_emacs_global_deinit): ifdef out; not used.
4042 (Fgnutls_boot): Use const for pointer to readonly storage.
4043 Comment out unused local. Fix pointer signedness problems.
4044
640ee02d
PE
4045 * lread.c (openp): Don't stuff size_t into an 'int'.
4046 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4047 about possible signed overflow.
4048
6048fb2a
PE
4049 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4050 (GDK_KEY_g): Don't define if already defined.
4051 (xg_prepare_tooltip): Avoid pointer signedness problem.
4052 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4053
fa3c87e1
PE
4054 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4055 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4056
2172544b
PE
4057 * xfns.c (Fx_window_property): Simplify a bit,
4058 to make a bit faster and to avoid GCC 4.6.0 warning.
4059 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4060
9b821a21
PE
4061 * fns.c (internal_equal): Don't assume size_t fits in int.
4062
3c616cfa
PE
4063 * alloc.c (compact_small_strings): Tighten assertion a little.
4064
c2982e87
PE
4065 Replace pEd with more-general pI, and fix some printf arg casts.
4066 * lisp.h (pI): New macro, generalizing old pEd macro to other
4067 conversion specifiers. For example, use "...%"pI"d..." rather
4068 than "...%"pEd"...".
4069 (pEd): Remove. All uses replaced with similar uses of pI.
4070 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4071 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4072 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4073 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4074 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4075 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4076 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4077 64-bit hosts.
4078 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4079 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4080 * print.c (safe_debug_print, print_object): Likewise.
4081 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4082 to int.
6f04d126
PE
4083 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4084 avoiding the 0 flag, which is not portable.
c2982e87
PE
4085 * process.c (Fmake_network_process): Use pI to avoid cast.
4086 * region-cache.c (pp_cache): Likewise.
4087 * xdisp.c (decode_mode_spec): Likewise.
4088 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4089 behavior on 64-bit hosts with printf arg.
6f04d126 4090 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4091 (x_stop_queuing_selection_requests): Likewise.
4092 (x_get_window_property): Don't truncate byte count to an 'int'
4093 when tracing.
0b432f21 4094
5e073ec7
PE
4095 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4096 here, since it parses constructs like leading '-' and spaces,
4097 which are not wanted; and it overflows with large numbers.
4098 Instead, simply match F[0-9]+, which is what is wanted anyway.
4099
36372bf9
PE
4100 * alloc.c: Remove unportable assumptions about struct layout.
4101 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4102 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4103 (allocate_vectorlike, make_pure_vector): Use the new macros,
4104 plus offsetof, to remove unportable assumptions about struct layout.
4105 These assumptions hold on all porting targets that I know of, but
4106 they are not guaranteed, they're easy to remove, and removing them
4107 makes further changes easier.
4108
0b432f21
PE
4109 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4110 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4111 (string_overrun_cookie): Now const. Use initializers that
4112 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4113 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4114 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4115 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4116 multiple of sizeof (EMACS_INT); it need not be, if
4117 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4118 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4119
895009e1
JB
41202011-04-26 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4123
6a7a1b0b
TZ
41242011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4125
4126 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4127 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4128 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4129
841a1577 41302011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4131
4132 * lisp.h (Qdebug): List symbol.
895009e1 4133 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4134 * keyboard.c (debug-on-event): New variable.
4135 (handle_user_signal): Break into debugger when debug-on-event
4136 matches the current signal symbol.
4137
f2d3ba6f
DN
41382011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4139
4140 * alloc.c (check_sblock, check_string_bytes)
4141 (check_string_free_list): Convert to standard C.
4142
42ce4c63
TZ
41432011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4144
4145 * w32.c (emacs_gnutls_push): Fix typo.
4146
825cd63c
EZ
41472011-04-25 Eli Zaretskii <eliz@gnu.org>
4148
fb11d64d
EZ
4149 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4150 "cast to pointer from integer of different size".
4151
825cd63c
EZ
4152 Improve doprnt and its use in verror. (Bug#8545)
4153 * doprnt.c (doprnt): Document the set of format control sequences
4154 supported by the function. Use SAFE_ALLOCA instead of always
4155 using `alloca'.
4156
4157 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4158 is one byte too soon. Don't use xrealloc; instead xfree and
4159 xmalloc anew.
4160
e061a11b
TZ
41612011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4162
4163 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4164 callbacks stage.
4165
4166 * gnutls.c: Renamed global_initialized to
4167 gnutls_global_initialized. Added internals for the
4168 :verify-hostname-error, :verify-error, and :verify-flags
4169 parameters of `gnutls-boot' and documented those parameters in the
4170 docstring. Start callback support.
9173deec
JB
4171 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4172 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4173 on error. Return error code.
e061a11b
TZ
4174 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4175 (emacs_gnutls_read): Likewise.
4176 (Fgnutls_boot): Return handshake error code.
4177 (emacs_gnutls_handle_error): New function.
4178 (wsaerror_to_errno): Likewise.
4179
4180 * w32.h (emacs_gnutls_pull): Add prototype.
4181 (emacs_gnutls_push): Likewise.
4182
4183 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4184 (emacs_gnutls_push): Likewise.
4185
41862011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4187
4188 * process.c (wait_reading_process_output): Check if GnuTLS
4189 buffered some data internally if no FDs are set for TLS
4190 connections.
4191
4192 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4193 (LIBS): Link to USER_LIBS.
4194 ($(BLD)/gnutls.$(0)): New target.
4195
fa6996bc
EZ
41962011-04-24 Eli Zaretskii <eliz@gnu.org>
4197
eb35682e
EZ
4198 * xdisp.c (handle_single_display_spec): Rename the
4199 display_replaced_before_p argument into display_replaced_p, to
4200 make it consistent with the commentary. Fix typos in the
4201 commentary.
4202
e2ad650c
EZ
4203 * textprop.c (syms_of_textprop): Remove dead code.
4204 (copy_text_properties): Delete obsolete commentary about an
4205 interface that was deleted long ago. Fix typos in the description
4206 of arguments.
4207
1b2de274
EZ
4208 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4209 to changes in oldXMenu/XMenu.h from 2011-04-16.
4210 <menu_help_message, prev_menu_help_message>: Constify.
4211 (IT_menu_make_room): menu->help_text is now `const char **';
4212 adjust.
4213
4214 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4215 to changes in oldXMenu/XMenu.h from 2011-04-16.
4216 (struct XMenu): Declare `help_text' `const char **'.
4217
4218 * xfaces.c <Qunspecified>: Make extern again.
4219
4220 * syntax.c: Include sys/types.h before including regex.h, as
4221 required by Posix.
4222
762b15be
EZ
4223 * doc.c (get_doc_string): Improve the format passed to `error'.
4224
4225 * doprnt.c (doprnt): Improve commentary.
4226
4227 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4228
4229 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4230 them with etags.
4231
f1052e5d
EZ
4232 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4233 changes in globals.h immediately force recompilation.
762b15be
EZ
4234 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4235 $(CURDIR)/s/ms-w32.h.
4236 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4237
fa6996bc
EZ
4238 * character.c (Fchar_direction): Function deleted.
4239 (syms_of_character): Don't defsubr it.
4240 <char-direction-table>: Deleted.
4241
e6c3da20
EZ
42422011-04-23 Eli Zaretskii <eliz@gnu.org>
4243
4244 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4245 * doprnt.c: Include limits.h.
4246 (SIZE_MAX): New macro.
04f2d78b
CB
4247 (doprnt): Return a size_t value. 2nd arg is now size_t.
4248 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4249 Improve overflow protection. Support `l' modifier for integer
4250 conversions. Support %l conversion. Don't assume an EMACS_INT
4251 argument for integer conversions and for %c.
4252
4253 * lisp.h (doprnt): Restore prototype.
4254
4255 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4256 $(SRC)/character.h.
4257
4258 * Makefile.in (base_obj): Add back doprnt.o.
4259
4260 * deps.mk (doprnt.o): Add back prerequisites.
4261 (callint.o): Depend on character.h.
4262
4263 * eval.c (internal_lisp_condition_case): Include the handler
4264 representation in the error message.
4265 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4266 when breaking from the loop.
4267
4268 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4269
4270 * callint.c (Fcall_interactively): When displaying error message
4271 about invalid control letter, pass the character's codepoint, not
4272 a pointer to its multibyte form. Improve display of the character
4273 in octal and display also its hex code.
4274
4275 * character.c (char_string): Use %x to display the (unsigned)
4276 codepoint of an invalid character, to avoid displaying a bogus
4277 negative value.
4278
4279 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4280 `error', not SYMBOL_NAME itself.
4281
4282 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4283 character arguments to `error'.
4284
4285 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4286 to `error' in error message about FINAL_CHAR argument. Make sure
4287 FINAL_CHAR is a character, and use %c when it is passed as
4288 argument to `error'.
4289
4ffd0d6b 42902011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4291
4292 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4293
4294 * w32.c: Include <time.h>.
4295 (sys_localtime): New function.
4296
4ffd0d6b 42972011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4298
4299 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4300
4ffd0d6b 4301 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4302
4ffd0d6b 43032011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4304
4ffd0d6b
GM
4305 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4306 zombies (Bug#8467).
aac0c6e3 4307
04c56954
EZ
43082011-04-19 Eli Zaretskii <eliz@gnu.org>
4309
4310 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4311 gl_state.e_property when gl_state.object is Qt.
4312
4313 * insdel.c (make_gap_larger): Remove limitation of buffer size
4314 to <= INT_MAX.
4315
16a43933
CY
43162011-04-18 Chong Yidong <cyd@stupidchicken.com>
4317
4318 * xdisp.c (lookup_glyphless_char_display)
4319 (produce_glyphless_glyph): Handle cons cell entry in
4320 glyphless-char-display.
4321 (Vglyphless_char_display): Document it.
4322
4323 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4324 glyphless-char-display.
4325
4581706e
CY
43262011-04-17 Chong Yidong <cyd@stupidchicken.com>
4327
4328 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4329
4330 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4331
4332 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4333 definition for no-X builds.
4334
4887c6e2 43352011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4336
fd35b6f9
PE
4337 Static checks with GCC 4.6.0 and non-default toolkits.
4338
5c1ccb01
PE
4339 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4340
006c5daa
PE
4341 * process.c (keyboard_bit_set): Define only if SIGIO.
4342 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4343 (send_process): Repair possible setjmp clobbering.
4344
efc736d3
PE
4345 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4346
4e2fe2e6
PE
4347 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4348
f97334a2
PE
4349 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4350
4e75f29d
PE
4351 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4352 Define only if needed.
4353
90efadd1
PE
4354 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4355 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4356 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4357
3c647824
PE
4358 * dispextern.h (struct redisplay_interface): Rename param
4359 to avoid shadowing.
e264f262 4360 * termhooks.h (struct terminal): Likewise.
761383f4 4361 * xterm.c (xembed_send_message): Likewise.
3c647824 4362
b58c5c4a
PE
4363 * insdel.c (make_gap_smaller): Define only if
4364 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4365
cad59032
PE
4366 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4367 it.
4368
c339dc2e
PE
4369 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4370 so that we aren't warned about unused symbols.
4371
91a3e27b
PE
4372 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4373
399c71d3 4374 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4375
8ffc96f5
PE
4376 * xfns.c (x_real_positions): Mark locals as initialized.
4377
eef9bc79
PE
4378 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4379
098db9dd
PE
4380 * xterm.c: Fix problems found by static analysis with other toolkits.
4381 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4382 (x_dispatch_event): Declare static if USE_GTK, and
4383 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4384 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4385 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4386 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4387 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4388
eb18f6cc
PE
4389 * xmenu.c (menu_help_callback): Pointer type fixes.
4390 Use const pointers when pointing at readonly data. Avoid pointer
4391 signedness clashes.
4392 (FALSE): Remove unused macro.
4393 (update_frame_menubar): Remove unused decl.
4394
1fe72bf8
PE
4395 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4396
60d9e1db
PE
4397 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4398 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4399 (single_menu_item): Rename local to avoid shadowing.
4400
39261c26
PE
4401 * keyboard.c (make_lispy_event): Remove unused local var.
4402
018c5e19
PE
4403 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4404 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4405
63d2b86e
PE
4406 * bitmaps: Change bitmaps from unsigned char back to the X11
4407 compatible char. Avoid the old compiler warnings about
4408 out-of-range initializers by using, for example, '\xab' rather
4409 than 0xab.
4410
aefd87e1
PE
4411 * xgselect.c (xgselect_initialize): Check vs interface
4412 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4413
bf501fb9
PE
4414 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4415
e9829fdf
PE
4416 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4417 to read-only memory.
4418
1086c095
PE
4419 * fns.c (vector): Remove; this old hack is no longer needed.
4420
2baccd04 4421 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4422 Remove unused var.
dde42981 4423 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4424
72391843 4425 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4426
436c16df 4427 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4428 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4429 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4430
92bb796d 4431 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4432 (x_term_init): Remove local to avoid shadowing.
92bb796d 4433
764430a3 4434 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4435
4436 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4437 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4438
d1dfb56c
EZ
44392011-04-16 Eli Zaretskii <eliz@gnu.org>
4440
c4354cb4
EZ
4441 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4442
d1dfb56c
EZ
4443 Fix regex.c, syntax.c and friends for buffers > 2GB.
4444 * syntax.h (struct gl_state_s): Declare character position members
4445 EMACS_INT.
4446
4447 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4448
04f2d78b
CB
4449 * textprop.c (verify_interval_modification, interval_of):
4450 Declare arguments EMACS_INT.
d1dfb56c
EZ
4451
4452 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4453 EMACS_INT.
4454
4455 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4456
4457 * indent.c (Fvertical_motion): Local variable it_start is now
4458 EMACS_INT.
4459
4460 * regex.c (re_match, re_match_2, re_match_2_internal)
4461 (bcmp_translate, regcomp, regexec, print_double_string)
4462 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4463 (re_compile_pattern, re_exec): Declare arguments and local
4464 variables `size_t' and `ssize_t' and return values `regoff_t', as
4465 appropriate.
4466 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4467 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4468 <compile_stack_type>: `size' and `avail' are now `size_t'.
4469
4470 * regex.h <regoff_t>: Use ssize_t, not int.
4471 (re_search, re_search_2, re_match, re_match_2): Arguments that
4472 specify buffer/string position and length are now ssize_t and
4473 size_t. Return type is regoff_t.
4474
613052cd
BK
44752011-04-16 Ben Key <bkey76@gmail.com>
4476
4477 * nsfont.m: Fixed bugs in ns_get_family and
4478 ns_descriptor_to_entity that were caused by using free to
4479 deallocate memory blocks that were allocated by xmalloc (via
4480 xstrdup). This caused Emacs to crash when compiled with
4481 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4482 --enable-checking=xmallocoverrun). xfree is now used to
4483 deallocate these memory blocks.
4484
4170f62f 44852011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4486
71b41406
PE
4487 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4488
9587a89d
PE
4489 emacs_write: Accept and return EMACS_INT for sizes.
4490 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4491 et seq.
4492 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4493 Accept and return EMACS_INT.
4494 (emacs_gnutls_write): Return the number of bytes written on
4495 partial writes.
4496 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4497 (emacs_read, emacs_write): Remove check for negative size, as the
4498 Emacs source code has been audited now.
9587a89d
PE
4499 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4500 (emacs_read, emacs_write): Use it.
273a5f82
PE
4501 * process.c (send_process): Adjust to the new signatures of
4502 emacs_write and emacs_gnutls_write. Do not attempt to store
4503 a byte offset into an 'int'; it might overflow.
9587a89d 4504 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4505
3e047f51
PE
4506 * sound.c: Don't assume sizes fit in 'int'.
4507 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4508 Return EMACS_INT, not int.
3e047f51 4509 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4510 Accept EMACS_INT, not int.
4511 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4512 record read return values.
4513
cc39a9db
BK
45142011-04-15 Ben Key <bkey76@gmail.com>
4515
c9d0ec6d
JB
4516 * keyboard.c (Qundefined): Don't declare static since it is used
4517 in nsfns.m.
4518 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4519 static since they are used in nsfont.m.
cc39a9db 4520
6c60eb9f
SM
45212011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4522
4523 * process.c (Qprocessp): Don't declare static.
4524 * lisp.h (Qprocessp): Declare again.
4525
7990b61a
JB
45262011-04-15 Juanma Barranquero <lekktu@gmail.com>
4527
4528 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4529
5d4cb038
PE
45302011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4531
8bd7b830 4532 Improve C-level modularity by making more things 'static'.
cd64ea1d 4533
e3b27b31
PE
4534 Don't publish debugger-only interfaces to other modules.
4535 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4536 (verify_bytepos, count_markers): Move decls to the only modules
4537 that need them.
4538 * region-cache.h (pp_cache): Likewise.
4539 * window.h (check_all_windows): Likewise.
4540 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4541
5d4cb038
PE
4542 * sysdep.c (croak): Now static, if
4543 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4544 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4545
4546 * alloc.c (refill_memory_reserve): Now static if
4547 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4548 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4549
e87b6180
PE
4550 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4551 Define only if USE_LUCID.
4552
ac64929e
PE
4553 * xrdb.c (x_customization_string, x_rm_string): Now static.
4554
6f37259d
PE
4555 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4556 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4557
1683e3ab
PE
4558 * xdisp.c (draw_row_with_mouse_face): Now static.
4559 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4560
de9c2632
PE
4561 * window.h (check_all_windows): Mark externally visible.
4562
2b96acb7
PE
4563 * window.c (window_deletion_count): Now static.
4564
4565 * undo.c: Make symbols static if they're not exported.
4566 (last_undo_buffer, last_boundary_position, pending_boundary):
4567 Now static.
4568
50436f33
PE
4569 * textprop.c (interval_insert_behind_hooks): Now static.
4570 (interval_insert_in_front_hooks): Likewise.
4571
64520e5c
PE
4572 * term.c: Make symbols static if they're not exported.
4573 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4574 (max_frame_lines, tty_set_terminal_modes):
4575 (tty_reset_terminal_modes, tty_turn_off_highlight):
4576 (get_tty_terminal): Now static.
4577 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4578 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4579 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4580 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4581 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4582
1fa53021
PE
4583 * sysdep.c: Make symbols static if they're not exported.
4584 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4585 Now static.
4586 (sigprocmask_set, full_mask): Remove; unused.
4587 (wait_debugging): Mark as visible.
4588 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4589 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4590
d4b43b22
PE
4591 * syntax.c (syntax_temp): Define only if !__GNUC__.
4592
b7c513d0
PE
4593 * sound.c (current_sound_device, current_sound): Now static.
4594
989b29ad
PE
4595 * search.c (searchbufs, searchbuf_head): Now static.
4596
13a55a78
PE
4597 * scroll.c (scroll_cost): Remove; unused.
4598 * dispextern.h (scroll_cost): Remove decl.
4599
de68a1fc
PE
4600 * region-cache.h (pp_cache): Mark as externally visible.
4601
40ccffa6
PE
4602 * process.c: Make symbols static if they're not exported.
4603 (process_tick, update_tick, create_process, chan_process):
4604 (Vprocess_alist, proc_buffered_char, datagram_access):
4605 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4606 (deactivate_process): Mark defn as static, as well as decl.
4607 * lisp.h (create_process): Remove decl.
4608 * process.h (chan_process, Vprocess_alist): Remove decls.
4609
ad64fc97
PE
4610 * print.c: Make symbols static if they're not exported.
4611 (print_depth, new_backquote_output, being_printed, print_buffer):
4612 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4613 (print_interval, print_number_index, initial_stderr_stream):
4614 Now static.
4615 * lisp.h (Fprinc): Remove decl.
4616 (debug_output_compilation_hack): Mark as externally visible.
4617
adddb265
PE
4618 * sysdep.c (croak): Move decl from here to syssignal.h.
4619 * syssignal.h (croak): Put it here, so the API can be checked when
4620 'croak' is called from dissociate_if_controlling_tty.
4621
1717ede2
PE
4622 * minibuf.c: Make symbols static if they're not exported.
4623 (minibuf_save_list, choose_minibuf_frame): Now static.
4624 * lisp.h (choose_minibuf_frame): Remove decl.
4625
fa5fb2bc
PE
4626 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4627
1e3890d1
PE
4628 * lread.c: Make symbols static if they're not exported.
4629 (read_objects, initial_obarray, oblookup_last_bucket_number):
4630 Now static.
4631 (make_symbol): Remove; unused.
4632 * lisp.h (initial_obarray, make_symbol): Remove decls.
4633
8a1414fa
PE
4634 * keyboard.c: Make symbols static if they're not exported.
4635 (single_kboard, recent_keys_index, total_keys, recent_keys):
4636 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4637 (this_single_command_key_start, echoing, last_auto_save):
4638 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4639 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4640 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4641 (Vlispy_mouse_stem, double_click_count):
4642 Now static.
4643 (force_auto_save_soon): Define only if SIGDANGER.
4644 (ignore_mouse_drag_p): Now static if
4645 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4646 (print_help): Remove; unused.
4647 (stop_character, last_timer_event): Mark as externally visible.
4648 * keyboard.h (ignore_mouse_drag_p): Declare only if
4649 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4650 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4651 * lisp.h (echoing): Remove decl.
4652 (force_auto_save_soon): Declare only if SIGDANGER.
4653 * xdisp.c (redisplay_window): Simplify code, to make it more
4654 obvious that ignore_mouse_drag_p is not accessed if !defined
4655 USE_GTK && !defined HAVE_NS.
4656
93ea6e8f
PE
4657 * intervals.c: Make symbols static if they're not exported.
4658 (merge_properties_sticky, merge_interval_right, delete_interval):
4659 Now static.
4660 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4661
77382fcc
PE
4662 * insdel.c: Make symbols static if they're not exported.
4663 However, leave prepare_to_modify_buffer alone. It's never
4664 called from outside this function, but that appears to be a bug.
4665 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4666 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4667 (adjust_after_replace_noundo): Remove; unused.
4668 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4669 (signal_before_change): Remove decls.
77382fcc 4670
9306c32e
PE
4671 * indent.c (val_compute_motion, val_vmotion): Now static.
4672
cd44d2eb
PE
4673 * image.c: Make symbols static if they're not exported.
4674 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4675 if USE_GTK.
4676 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4677 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4678
ad9a7a06
PE
4679 * fringe.c (standard_bitmaps): Now static.
4680 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4681
81626931
PE
4682 * frame.c: Make symbols static if they're not exported.
4683 (x_report_frame_params, make_terminal_frame): Now static.
4684 (get_frame_param): Now static, unless HAVE_NS.
4685 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4686 (x_get_resource_string): Remove; not used.
4687 * frame.h (make_terminal_frame, x_report_frame_params):
4688 (x_get_resource_string); Remove decls.
4689 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4690 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4691
239f9db9
PE
4692 * font.c, fontset.c: Make symbols static if they're not exported.
4693 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4694 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4695 * font.c (font_close_object): Now static.
4696 * font.h (font_close_object): Remove.
4697 * fontset.c (FONTSET_OBJLIST): Remove.
4698 (free_realized_fontset) #if-0 the body, which does nothing.
4699 (face_suitable_for_char_p): #if-0, as it's never called.
4700 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4701 * xfaces.c (face_at_string_position):
4702 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4703 since 0 is always ASCII.
4704
dfcf3579
PE
4705 * fns.c (weak_hash_tables): Now static.
4706
5045092b
PE
4707 * fileio.c: Make symbols static if they're not exported.
4708 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4709 (Vwrite_region_annotation_buffers): Now static.
4710
57a96f5c
PE
4711 * eval.c: Make symbols static if they're not exported.
4712 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4713 * lisp.h (backtrace_list): Remove decl.
4714
35f08c38
PE
4715 * emacs.c: Make symbols static if they're not exported.
4716 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4717 (fatal_error_code, fatal_error_signal_hook, standard_args):
4718 Now static.
4719 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4720 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4721 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4722 * lisp.h (fatal_error_signal_hook): Remove decl.
4723 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4724
f44bd759
PE
4725 * editfns.c: Move a (normally-unused) function to its only use.
4726 * editfns.c, lisp.h (get_operating_system_release): Remove.
4727 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4728 worth the hassle of breaking this out.
4729
b532497d
PE
4730 * xterm.c: Make symbols static if they're not exported.
4731 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4732 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4733 (x_destroy_window, x_delete_display):
4734 Now static.
4735 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4736 (x_mouse_leave): Remove; unused.
4737 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4738 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4739 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4740 Remove decls.
4741 (x_mouse_leave): Declare only if WINDOWSNT.
4742 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4743 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4744 USE_X_TOOLKIT.
4745
1675728f
PE
4746 * ftxfont.c: Make symbols static if they're not exported.
4747 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4748 HAVE_FREETYPE.
4749 * font.h (ftxfont_driver): Likewise.
4750
e4cebfca
PE
4751 * xfns.c: Make symbols static if they're not exported.
4752 (x_last_font_name, x_display_info_for_name):
4753 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4754 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4755 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4756 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4757 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4758 (last_show_tip_args): Now static.
4759 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4760 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4761 (x_screen_planes): Remove; unused.
4762 * dispextern.h (x_screen_planes): Remove decl.
4763
5bf46f05
PE
4764 * dispnew.c: Make symbols static if they're not exported.
4765 * dispextern.h (redraw_garbaged_frames, scrolling):
4766 (increment_row_positions): Remove.
4767 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4768 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4769 Now static.
4770 (redraw_garbaged_frames): Remove; unused.
4771
435f4c28
PE
4772 * xfaces.c: Make symbols static if they're not exported.
4773 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4774 Remove decls.
4775 * xterm.h (defined_color): Remove decls.
4776 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4777 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4778 (menu_face_changed_default, defined_color, free_realized_face):
4779 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4780 (ascii_face_of_lisp_face): Remove; unused.
4781
8524aef3
PE
4782 * xdisp.c: Make symbols static if they're not exported.
4783 * dispextern.h (scratch_glyph_row, window_box_edges):
4784 (glyph_to_pixel_coords, set_cursor_from_row):
4785 (get_next_display_element, set_iterator_to_next):
4786 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4787 (show_mouse_face): Remove decls
4788 * frame.h (message_buf_print): Likewise.
4789 * lisp.h (pop_message, set_message, check_point_in_composition):
4790 Likewise.
4791 * xterm.h (set_vertical_scroll_bar): Likewise.
4792 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4793 (message_buf_print, scratch_glyph_row, displayed_buffer):
4794 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4795 (get_next_display_element, show_mouse_face, window_box_edges):
4796 (frame_to_window_pixel_xy, check_point_in_composition):
4797 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4798 (glyph_to_pixel_coords): Remove; unused.
4799
16390cd2
PE
4800 * dired.c (file_name_completion): Now static.
4801
4802 * dbusbind.c (xd_in_read_queued_messages): Now static.
4803
a25f4dfa
PE
4804 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4805 * data.c (circular_list_error): Remove.
4806
14a9c8df
PE
4807 * commands.h (last_point_position, last_point_position_buffer):
4808 (last_point_position_window): Remove decls.
4809 * keyboard.c: Make these variables static.
4810
04f2d78b
CB
4811 * coding.h (coding, code_convert_region, encode_coding_gap):
4812 Remove decls.
74ab6df5
PE
4813 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4814 (iso_code_class, detect_coding, code_convert_region): Now static.
4815 (encode_coding_gap): Remove; unused.
4816
38dfbee1
PE
4817 * chartab.c (chartab_chars, chartab_bits): Now static.
4818
a2cb4e63
PE
4819 * charset.h (charset_iso_8859_1): Remove decl.
4820 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4821 Now static.
4822
127198fd
PE
4823 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4824 * ccl.c (Vccl_program_table): Now static.
4825 (check_ccl_update): Remove; unused.
4826
d85b608f
PE
4827 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4828 * category.h: ... from here.
4829 * category.c (check_category_table, set_category_set): Now static.
4830
31cd66f3
PE
4831 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4832 * lisp.h: Remove these decls.
4833
c358e587
PE
4834 * buffer.c (buffer_count): Remove unused var.
4835
e78aecca
PE
4836 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4837 so that it's not optimized away.
4838 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4839 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4840 exported only to the debugger.
4841
e192d7d3 4842 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4843 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4844
92470028
PE
4845 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4846 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4847 was inaccessible from Lisp.
4848 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4849 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4850
244ed907
PE
4851 alloc.c: Import and export fewer symbols, and remove unused items.
4852 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4853 is defined.
4854 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4855 it's not optimized away by whole-program optimization.
4856 (message_enable_multibyte, free_misc): Remove.
4857 (catchlist, handlerlist, mark_backtrace):
4858 Declare only if BYTE_MARK_STACK.
4859 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4860 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4861 (message_enable_multibyte): Remove decl.
4862 (free_misc, interval_free_list, float_block, float_block_index):
4863 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4864 (cons_free_list, last_marked_index):
4865 Now static.
4866 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4867 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4868 (mark_backtrace): Define only if BYTE_MARK_STACK.
4869 * xdisp.c (message_enable_multibyte): Now static.
4870
61c2b50e 4871 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4872 This makes it easier for human readers (and static analyzers)
4873 to see whether these variables are used from other modules.
4874 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4875 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4876 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4877 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4878 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4879 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4880 * xmenu.c, xselect.c:
4881 Declare Q* vars static if they are not used in other modules.
4882 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4883 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4884 Remove decls of unexported vars.
4885 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4886
95c82688
PE
4887 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4888
16a97296
PE
4889 Make Emacs functions such as Fatom 'static' by default.
4890 This makes it easier for human readers (and static analyzers)
4891 to see whether these functions can be called from other modules.
4892 DEFUN now defines a static function. To make the function external
4893 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4894 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4895 (Finit_image_library):
16a97296
PE
4896 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4897 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4898 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4899 Remove decls, since these functions are now static.
4900 (Funintern, Fget_internal_run_time): New decls, since these functions
4901 were already external.
95c82688 4902
16a97296
PE
4903 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4904 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4905 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4906 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4907 * keyboard.c, keymap.c, lread.c:
4908 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4909 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4910 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4911 Mark functions with DEFUE instead of DEFUN,
4912 if they are used in other modules.
4913 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4914 decls for now-static functions.
4915 * buffer.h (Fdelete_overlay): Remove decl.
4916 * callproc.c (Fgetenv_internal): Mark as internal.
4917 * composite.c (Fremove_list_of_text_properties): Remove decl.
4918 (Fcomposition_get_gstring): New forward static decl.
4919 * composite.h (Fcomposite_get_gstring): Remove decl.
4920 * dired.c (Ffile_attributes): New forward static decl.
4921 * doc.c (Fdocumntation_property): New forward static decl.
4922 * eval.c (Ffetch_bytecode): New forward static decl.
4923 (Funintern): Remove extern decl; now in .h file where it belongs.
4924 * fileio.c (Fmake_symbolic_link): New forward static decl.
4925 * image.c (Finit_image_library): New forward static decl.
4926 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4927 * intervals.h (Fprevious_property_change):
4928 (Fremove_list_of_text_properties): Remove decls.
4929 * keyboard.c (Fthis_command_keys): Remove decl.
4930 (Fcommand_execute): New forward static decl.
4931 * keymap.c (Flookup_key): New forward static decl.
4932 (Fcopy_keymap): Now static.
4933 * keymap.h (Flookup_key): Remove decl.
4934 * process.c (Fget_process): New forward static decl.
4935 (Fprocess_datagram_address): Mark as internal.
4936 * syntax.c (Fsyntax_table_p): New forward static decl.
4937 (skip_chars): Remove duplicate decl.
4938 * textprop.c (Fprevious_property_change): New forward static decl.
4939 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4940 Now internal.
4941 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4942 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4943
785bbd42
PE
4944 * editfns.c (Fformat): Remove unreachable code.
4945
8b913b57
AS
49462011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4947
4948 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4949 change. (Bug#8496)
4950
a6744a35
EZ
49512011-04-13 Eli Zaretskii <eliz@gnu.org>
4952
4953 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4954 when at ZV. (Bug#8487)
4955
e7974947
AS
49562011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4957
baad03f0
AS
4958 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4959 (Bug#8437)
4960 * keyboard.c (parse_tool_bar_item): Likewise.
4961 * sound.c (sound_cleanup, alsa_close): Likewise.
4962 * termcap.c (tgetent): Likewise.
4963 * xfns.c (x_default_font_parameter): Likewise.
4964 * xsettings.c (read_and_apply_settings): Likewise.
4965
e7974947
AS
4966 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4967 (overrun_check_free): Protoize.
4968
28272684
PE
49692011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4972 since callers should never pass a negative size.
4973 Change the signature to match that of plain 'read' and 'write'; see
4974 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4975 * lisp.h: Update prototypes of emacs_write and emacs_read.
4976
11997c76
EZ
49772011-04-11 Eli Zaretskii <eliz@gnu.org>
4978
4979 * xdisp.c (redisplay_window): Don't try to determine the character
4980 position of the scroll margin if the window start point w->startp
e896f03c 4981 is outside the buffer's accessible region. (Bug#8468)
11997c76 4982
8a2cbd72
EZ
49832011-04-10 Eli Zaretskii <eliz@gnu.org>
4984
4985 Fix write-region and its subroutines for buffers > 2GB.
4986 * fileio.c (a_write, e_write): Modify declaration of arguments and
4987 local variables to support buffers larger than 2GB.
4988 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4989
4990 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4991 argument, local variables, and return value.
4992
4993 * lisp.h: Update prototypes of emacs_write and emacs_read.
4994
4995 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4996
4073e537 49972011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4998
1ebfdcb6
PE
4999 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5000
b2ded58d
PE
5001 Fix more problems found by GCC 4.6.0's static checks.
5002
7d66342c
PE
5003 * xdisp.c (vmessage): Use a better test for character truncation.
5004
bbf47d44
PE
5005 * charset.c (load_charset_map): <, not <=, for optimization,
5006 and to avoid potential problems with integer overflow.
9248994d 5007 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5008 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5009 * editfns.c (Fformat): Likewise.
1e69125e 5010 * syntax.c (skip_chars): Likewise.
3befa583 5011
e3019616
PE
5012 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5013 This also lets GCC 4.6.0 generate slightly better loop code.
5014
becfa255
PE
5015 * callint.c (Fcall_interactively): <, not <=, for optimization.
5016 (Fcall_interactively): Count the number of arguments produced,
5017 not the number of arguments given. This is simpler and lets GCC
5018 4.6.0 generate slightly better code.
5019
dae0cd48
PE
5020 * ftfont.c: Distingish more carefully between FcChar8 and char.
5021 The previous code passed unsigned char * to a functions like
5022 strlen and xstrcasecmp that expect char *, which does not
5023 conform to the C standard.
5024 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5025 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5026 char * when the C standard requires it.
5027
76032d70
PE
5028 * keyboard.c (read_char): Remove unused var.
5029
eb3f1cc8
PE
5030 * eval.c: Port to Windows vsnprintf (Bug#8435).
5031 Include <limits.h>.
5032 (SIZE_MAX): Define if the headers do not.
5033 (verror): Do not give up if vsnprintf returns a negative count.
5034 Instead, grow the buffer. This ports to Windows vsnprintf, which
5035 does not conform to C99. Problem reported by Eli Zaretskii.
5036 Also, simplify the allocation scheme, by avoiding the need for
5037 calling realloc, and removing the ALLOCATED variable.
5038
70476b54
PE
5039 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5040
12020a9e
PE
5041 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5042 But keep the doprint source code for now, as we might revamp it
5043 and use it again (Bug#8435).
ea6c7ae6
PE
5044 * lisp.h (doprnt): Remove.
5045 * Makefile.in (base_obj): Remove doprnt.o.
5046 * deps.mk (doprnt.o): Remove.
5047
5fdb398c
PE
5048 error: Print 32- and 64-bit integers portably (Bug#8435).
5049 Without this change, on typical 64-bit hosts error ("...%d...", N)
5050 was used to print both 32- and 64-bit integers N, which relied on
5051 undefined behavior.
5052 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5053 New macro.
5054 * lisp.h (error, verror): Mark as printf-like functions.
5055 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5056 Report overflow in size calculations when allocating printf buffer.
5057 Do not truncate output string at its first null byte.
5058 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5059 Truncate the output at a character boundary, since vsnprintf does not
5060 do that.
5061 * charset.c (check_iso_charset_parameter): Convert internal
5062 character to string before calling 'error', since %c now has the
5063 printf meaning.
5064 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5065 overflow when computing char to be passed to 'error'. Do not
5066 pass Lisp_Object to 'error'; pass the integer instead.
5067 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5068 formatted with plain %d.
5069
b189fa66
PE
5070 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5071
bff87ef0
PE
5072 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5073
7e2cac20
PE
5074 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5075
ce4d90b5
PE
5076 * xterm.c (x_catch_errors): Remove duplicate declaration.
5077
266c9547
PE
5078 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5079
79c49ad2
PE
5080 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5081
368f4090
JM
50822011-04-10 Jim Meyering <meyering@redhat.com>
5083
5084 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5085 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5086 return ssize_t not "int", and use size_t as the buffer length.
5087 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5088 * gnutls.h: Update declarations.
5089 * process.c (read_process_output): Use ssize_t, to match.
5090 (send_process): Likewise.
5091
a32d4040
CY
50922011-04-09 Chong Yidong <cyd@stupidchicken.com>
5093
5094 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5095
8546720e 50962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5097
04f2d78b
CB
5098 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5099 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5100
8546720e
GM
5101 * xterm.c (handle_one_xevent):
5102 * xmenu.c (create_and_show_popup_menu):
5103 * xselect.c (x_decline_selection_request)
5104 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5105
0a2f5c1a 51062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5107
5108 Fix some uses of `int' instead of EMACS_INT.
5109 * search.c (string_match_1, fast_string_match)
5110 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5111 (scan_buffer, find_next_newline_no_quit)
5112 (find_before_next_newline, search_command, Freplace_match)
5113 (Fmatch_data): Make some `int' variables be EMACS_INT.
5114
5115 * xdisp.c (display_count_lines): 3rd argument and return value now
5116 EMACS_INT. All callers changed.
5117 (pint2hrstr): Last argument is now EMACS_INT.
5118
5119 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5120 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5121 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5122 (decode_coding_utf_16, decode_coding_emacs_mule)
5123 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5124 (decode_coding_ccl, decode_coding_charset)
5125 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5126 (decode_coding_iso_2022, decode_coding_emacs_mule)
5127 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5128 <char_offset, last_offset>: Declare EMACS_INT.
5129 (encode_coding_utf_8, encode_coding_utf_16)
5130 (encode_coding_emacs_mule, encode_invocation_designation)
5131 (encode_designation_at_bol, encode_coding_iso_2022)
5132 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5133 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5134 Declare EMACS_INT.
5135 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5136 (encode_invocation_designation): Last argument P_NCHARS is now
5137 EMACS_INT.
5138 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5139 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5140
5141 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5142 All users changed.
5143
5144 * ccl.c (Fccl_execute_on_string): Declare some variables
5145 EMACS_INT.
5146
8546720e 51472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5148
5149 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5150
4e19a977
CS
51512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5152
5153 * process.c (Fformat_network_address): Doc fix.
5154
87302331
R
51552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5156
5157 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5158
cbb59342
CY
51592011-04-08 Chong Yidong <cyd@stupidchicken.com>
5160
5161 * keyboard.c (read_char): Call Lisp function help-form-show,
5162 instead of using internal_with_output_to_temp_buffer.
5163 (Qhelp_form_show): New var.
e0d38eeb 5164 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5165
5166 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5167
5168 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5169
e67a13ab
CY
51702011-04-06 Chong Yidong <cyd@stupidchicken.com>
5171
04f2d78b
CB
5172 * process.c (Flist_processes): Remove to Lisp.
5173 (list_processes_1): Delete.
e67a13ab 5174
973f782d
EZ
51752011-04-06 Eli Zaretskii <eliz@gnu.org>
5176
7c106b1e
EZ
5177 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5178
973f782d
EZ
5179 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5180
41cf7d1a 51812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5182
ca23cc88
PE
5183 Fix more problems found by GCC 4.6.0's static checks.
5184
f390e2d5
PE
5185 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5186
42eea0d0
PE
5187 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5188
b69769da 5189 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5190
f9541e84
PE
5191 * xdisp.c (vmessage): Mark as a printf-like function.
5192
13841b55
PE
5193 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5194
c136c10f
PE
5195 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5196
5e2d4a30
PE
5197 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5198 printf-like functions.
5199 (tiff_load): Add casts to remove these marks before passing them
5200 to system-supplied API.
5201
583f48b9
PE
5202 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5203
b25d760e
PE
5204 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5205 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5206 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5207 directly, rather than having caller test rule sign. This avoids
5208 some unnecessary tests.
5209 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5210 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5211 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5212
bc7b6697 5213 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5214 (xfont_open): Avoid unnecessary tests.
bc7b6697 5215
27ccc379
PE
5216 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5217
dcd5c89a
PE
5218 * composite.h, composite.c (composition_gstring_put_cache):
5219 Use EMACS_INT, not int, for length.
5220
b13a45c6
PE
5221 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5222 breaking out part of COMPOSITION_DECODE_RULE.
5223 (COMPOSITION_DECODE_RULE): Use it.
5224 * composite.c (get_composition_id): Remove unused local vars,
5225 by using the new macro.
5226
1e792e4d
PE
5227 * textprop.c (set_text_properties_1): Change while to do-while,
5228 since the condition is always true at first.
5229
dc6c6455 5230 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5231 (interval_deletion_adjustment): Return unsigned value.
5232 All uses changed.
dc6c6455 5233
aba7731a
PE
5234 * process.c (list_processes_1, create_pty, read_process_output):
5235 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5236 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5237 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5238 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5239 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5240
fdfc4bf3
PE
5241 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5242
fca8fe46 5243 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5244 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5245
06a0259a 5246 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5247 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5248 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5249
e7b9e80f
PE
5250 * print.c (print_error_message): Avoid int overflow.
5251
56201685
PE
5252 * font.c (font_list_entities): Redo for clarity,
5253 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5254
78834453 5255 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5256 (font_score): Avoid potential overflow in diff calculation.
78834453 5257
0bc0b309 5258 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5259 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5260
e610eaca
PE
5261 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5262
b895abce
PE
5263 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5264 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5265 can always succeed if overflow has undefined behavior.
5266
1f1d9321 5267 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5268 (wordify): Omit three unnecessary tests.
1f1d9321 5269
c59478bc
PE
5270 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5271 All callers changed. This avoids the need for an unused var.
5272
79b73827
PE
5273 * casefiddle.c (casify_region): Remove var that is set but not used.
5274
a4db5dfe
PE
5275 * dired.c (file_name_completion): Remove var that is set but not used.
5276
43aae36e
PE
5277 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5278
2a47c44d 5279 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5280 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5281
a37c69bf
PE
5282 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5283 Check for integer overflow on size calculations.
5284
328ab8e7
PE
5285 * buffer.c (Fprevious_overlay_change): Remove var that is set
5286 but not used.
5287
e5a2a5cb
PE
5288 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5289 Remove vars that are set but not used.
8d84a6eb 5290 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5291 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5292
a60e5f68
PE
5293 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5294
f661cb61 5295 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5296 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5297
f0397f5a
PE
5298 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5299 that are set but not used.
5300
8664db06 5301 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5302 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5303
6abdaa4a
PE
5304 * xselect.c (x_get_local_selection, x_handle_property_notify):
5305 Remove vars that are set but not used.
5306
0ce7538d 5307 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5308 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5309
9ae848fc
PE
5310 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5311 Remove var that is set but not used.
0b918413
PE
5312 (scroll_bar_windows_size): Now size_t, not int.
5313 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5314 Check for overflow.
9ae848fc 5315
a5a62657
PE
5316 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5317 (map_tty_color) [!defined MSDOS]: Likewise.
5318
5c5cdd39
PE
5319 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5320
66ebf983
PE
5321 * coding.c: Remove vars that are set but not used.
5322 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5323 All callers changed.
5324 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5325 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5326 (decode_coding_charset): Remove vars that are set but not used.
5327
1be4d761
PE
5328 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5329 that is set but not used.
5330
47553fa8
PE
5331 * print.c (print_object): Remove var that is set but not used.
5332
1f7196bf 5333 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5334 The gnulib version avoids calling malloc in the usual case,
5335 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5336 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5337 * filelock.c (current_lock_owner): Likewise.
5338 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5339 * sysdep.c: Include allocator.h, careadlinkat.h.
5340 (emacs_no_realloc_allocator): New static constant.
5341 (emacs_readlink): New function.
fdb61804
PE
5342 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5343 ../lib/careadlinkat.h.
d1fdcab7 5344
f84c17c7
SM
53452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5346
5347 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5348 first non-nil return value).
5349
ef3862ad
JD
53502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5351
5352 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5353 if not defined (Bug#8403).
5354
376a7006
JB
53552011-04-02 Juanma Barranquero <lekktu@gmail.com>
5356
5357 * xdisp.c (display_count_lines): Remove parameter `start',
5358 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5359 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5360 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5361 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5362 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5363 and thereabouts. All callers changed.
5364 (get_per_char_metric): Remove parameter `f', unused since
5365 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5366
6ca3801d
JM
53672011-04-02 Jim Meyering <meyering@redhat.com>
5368
5369 do not dereference NULL upon failed strdup
5370 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5371 (ns_get_family): Likewise.
5372
d8e2b5ba
JB
53732011-04-02 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5376
8c74fcbd
JD
53772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5378
5379 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5380 later (Bug#8403).
5381
7200d79c
SM
53822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5383
03408648 5384 Add lexical binding.
7200d79c 5385
03408648
SM
5386 * window.c (Ftemp_output_buffer_show): New fun.
5387 (Fsave_window_excursion):
5388 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5389
5390 * lread.c (lisp_file_lexically_bound_p): New function.
5391 (Fload): Bind Qlexical_binding.
5392 (readevalloop): Remove `evalfun' arg.
5393 Bind Qinternal_interpreter_environment.
5394 (Feval_buffer): Bind Qlexical_binding.
5395 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5396 Mark as dynamic.
5397 (syms_of_lread): Declare `lexical-binding'.
5398
5399 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5400
5401 * keyboard.c (eval_dyn): New fun.
5402 (menu_item_eval_property): Use it.
ca105506
SM
5403
5404 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5405
03408648
SM
5406 * fns.c (concat, mapcar1): Accept byte-code-functions.
5407
5408 * eval.c (Fsetq): Handle lexical vars.
5409 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5410 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5411 (FletX, Flet): Obey lexical binding.
5412 (Fcommandp): Handle closures.
5413 (Feval): New `lexical' arg.
5414 (eval_sub): New function extracted from Feval. Use it almost
5415 everywhere where Feval was used. Look up vars in lexical env.
5416 Handle closures.
5417 (Ffunctionp): Move from subr.el.
5418 (Ffuncall): Handle closures.
5419 (apply_lambda): Remove `eval_flags'.
5420 (funcall_lambda): Handle closures and new byte-code-functions.
5421 (Fspecial_variable_p): New function.
5422 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5423 but without exporting it to Lisp.
23aba0ea 5424
23aba0ea 5425 * doc.c (Fdocumentation, store_function_docstring):
03408648 5426 * data.c (Finteractive_form): Handle closures.
23aba0ea 5427
03408648
SM
5428 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5429 interactive spec.
ba83908c 5430
04f2d78b
CB
5431 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5432 New byte-codes.
03408648
SM
5433 (exec_byte_code): New function extracted from Fbyte_code to handle new
5434 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5435
03408648 5436 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5437
03408648 5438 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5439
e2abce01
JB
54402011-03-31 Juanma Barranquero <lekktu@gmail.com>
5441
5442 * xdisp.c (redisplay_internal): Fix prototype.
5443
63696a73 54442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5445
63696a73 5446 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5447 (try_scrolling): Use it when setting scroll_limit.
5448 Limit scrolling to 100 screen lines.
63696a73
EZ
5449 (redisplay_window): Even when falling back on "recentering",
5450 position point in the window according to scroll-conservatively,
5451 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5452
5453 (try_scrolling): When point is above the window, allow searching
5454 as far as scroll_max, or one screenful, to compute vertical
5455 distance from PT to the scroll margin position. This prevents
5456 try_scrolling from unnecessarily failing when
5457 scroll-conservatively is set to a value slightly larger than the
5458 window height. Clean up the case of PT below the margin at bottom
5459 of window: scroll_max can no longer be INT_MAX. When aggressive
5460 scrolling is in use, don't let point enter the opposite scroll
5461 margin as result of the scroll.
5462 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5463 threshold of 100 lines for never-recentering scrolling.
5464
e4cc2dfc
JB
54652011-03-31 Juanma Barranquero <lekktu@gmail.com>
5466
5467 * dispextern.h (move_it_by_lines):
5468 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5469 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5470 (message_log_check_duplicate): Remove parameters `prev_bol' and
5471 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5472 (redisplay_internal): Remove parameter `preserve_echo_area',
5473 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5474
5475 * indent.c (Fvertical_motion):
5476 * window.c (window_scroll_pixel_based, Frecenter):
5477 Don't pass `need_y_p' to `move_it_by_lines'.
5478
1c470562
SM
54792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5480
44f230aa
SM
5481 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5482 steal a few bits to be more compact.
5483 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5484 Remove unneeded casts.
5485
1c470562
SM
5486 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5487
888adce9
ZK
54882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5489
5490 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5491 binding" message (bug#7967).
5492
f838ed7b
PE
54932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5494
77861b95
PE
5495 Fix more problems found by GCC 4.6.0's static checks.
5496
de6dbc14
PE
5497 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5498 Remove unused local var.
5499
f838ed7b
PE
5500 * editfns.c (Fmessage_box): Remove unused local var.
5501
792c7b2b
PE
5502 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5503 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5504 Omit unused local vars.
c499e557 5505 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5506 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5507 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5508 Omit unused local var.
5509
ba0165e1
PE
5510 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5511 Don't assume string length fits in int.
32ad8845 5512 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5513 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5514
3c59b4c9
PE
5515 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5516 instead of alloca (Bug#8344).
5517
a3eed478 5518 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5519 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5520
eb4d412d
PE
5521 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5522
1658b401
PE
5523 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5524 concerns.
5525
5526 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5527
5528 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5529
9a2c6e05
PE
5530 * keyboard.c (syms_of_keyboard): Use the same style as later
5531 in this function when indexing through an array. This also
5532 works around GCC bug 48267.
5533
03d0a109
PE
5534 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5535
44f730c8
PE
5536 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5537
fe75f926
PE
5538 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5539 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5540
ffa8c828
PE
5541 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5542 This avoids undefined behavior on integer overflow, and is a bit
5543 more convenient anyway since it is compared to a size_t variable.
5544
c5101a77
PE
5545 Variadic C functions now count arguments with size_t, not int.
5546 This avoids an unnecessary limitation on 64-bit machines, which
5547 caused (substring ...) to crash on large vectors (Bug#8344).
5548 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5549 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5550 All variadic functions and their callers changed accordingly.
c5101a77
PE
5551 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5552 * data.c (arith_driver, float_arith_driver): Likewise.
5553 * editfns.c (general_insert_function): Likewise.
5554 * eval.c (struct backtrace.nargs, interactive_p)
5555 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5556 (funcall_lambda, mark_backtrace): Likewise.
5557 * fns.c (concat): Likewise.
5558 * frame.c (x_set_frame_parameters): Likewise.
5559 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5560 0 if not found, not -1. All callers changed.
5561
dd3f25f7
PE
5562 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5563 (stack_copy_size): Now size_t, not int.
5564 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5565
461c2ab9
JB
55662011-03-28 Juanma Barranquero <lekktu@gmail.com>
5567
5568 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5569 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5570 All callers changed.
5571
5572 * lisp.h (multibyte_char_to_unibyte):
5573 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5574 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5575 * character.h (CHAR_TO_BYTE8):
5576 * cmds.c (internal_self_insert):
5577 * editfns.c (general_insert_function):
5578 * keymap.c (push_key_description):
5579 * search.c (Freplace_match):
5580 * xdisp.c (message_dolog, set_message_1): All callers changed.
5581
f6d62986
SM
55822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5583
5584 * keyboard.c (safe_run_hook_funcall): New function.
5585 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5586 don't set the hook to nil, but remove the offending function instead.
5587 (Qcommand_hook_internal): Remove, unused.
5588 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5589 Vcommand_hook_internal.
5590
5591 * eval.c (enum run_hooks_condition): Remove.
5592 (funcall_nil, funcall_not): New functions.
5593 (run_hook_with_args): Call each function through a `funcall' argument.
5594 Remove `cond' argument, now redundant.
5595 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5596 (Frun_hook_with_args_until_failure): Adjust accordingly.
5597 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5598
1db5b1ad
JB
55992011-03-28 Juanma Barranquero <lekktu@gmail.com>
5600
5601 * dispextern.h (string_buffer_position): Remove declaration.
5602
5603 * print.c (strout): Remove parameter `multibyte', unused since
5604 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5605
5606 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5607 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5608 All callers changed.
5609
5610 * w32.c (_wsa_errlist): Use braces for struct initializers.
5611
5612 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5613 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5614 All callers changed.
5615 (string_buffer_position): Likewise. Also, make static (it's never
5616 used outside xdisp.c).
5617 (cursor_row_p): Remove parameter `w', unused since
5618 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5619 (decode_mode_spec): Remove parameter `precision', introduced during
5620 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5621 All callers changed.
5622
5ffb62aa
JD
56232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5624
5625 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5626
461c2ab9 56272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5628
5629 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5630 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5631 (ns_update_auto_hide_menu_bar): New functions.
5632 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5633 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5634 ns_constrain_all_frames.
5635 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5636 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5637
5c380ffb
JD
56382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5639
5640 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5641
9af30bdf
GM
56422011-03-27 Glenn Morris <rgm@gnu.org>
5643
5644 * syssignal.h: Replace RETSIGTYPE with void.
5645 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5646 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5647 Replace SIGTYPE with void everywhere.
5648 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5649 * s/template.h (SIGTYPE): Remove commented out definition.
5650
e2abce01
JB
56512011-03-26 Eli Zaretskii <eliz@gnu.org>
5652
5653 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5654 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5655
f868cd8a
JB
56562011-03-26 Juanma Barranquero <lekktu@gmail.com>
5657
59eb0929
JB
5658 * w32.c (read_unc_volume): Use parameter `henum', instead of
5659 global variable `wget_enum_handle'.
5660
5661 * keymap.c (describe_vector): Remove parameters `indices' and
5662 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5663 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5664
f868cd8a
JB
5665 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5666
5667 * keyboard.c (timer_check): Remove parameter `do_it_now',
5668 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5669 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5670 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5671
5672 * keyboard.c (read_char):
5673 * w32menu.c (w32_menu_display_help):
5674 * xmenu.c (show_help_event, menu_help_callback):
5675 Adjust calls to `show_help_echo'.
5676
5677 * gtkutil.c (xg_maybe_add_timer):
5678 * keyboard.c (readable_events):
5679 * process.c (wait_reading_process_output):
5680 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5681
5682 * insdel.c (adjust_markers_gap_motion):
5683 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5684 (gap_left, gap_right): Don't call it.
5685
2ecf6fdb
CY
56862011-03-25 Chong Yidong <cyd@stupidchicken.com>
5687
5688 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5689 incurred during fontification.
5690
6b1f9ba4
JB
56912011-03-25 Juanma Barranquero <lekktu@gmail.com>
5692
5693 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5694 (DEFVAR_PER_BUFFER): Don't pass it.
5695
5696 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5697 (scrolling_window): Don't pass it.
5698
0f4a96b5
JB
56992011-03-25 Juanma Barranquero <lekktu@gmail.com>
5700
5701 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5702
5703 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5704 and `suffix'.
5705 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5706 of variables specific to SELinux and computation of `encoded_absname'.
5707
5708 * image.c (XPutPixel): Remove unused variable `height'.
5709
5710 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5711
5712 * unexw32.c (get_section_info): Remove unused variable `section'.
5713
5714 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5715 (system_process_attributes): Remove unused variable `sess'.
5716 (sys_read): Remove unused variable `err'.
5717
5718 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5719 (w32_wnd_proc): Remove unused variable `isdead'.
5720 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5721 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5722 (x_create_tip_frame): Remove unused variable `tem'.
5723
5724 * w32inevt.c (w32_console_read_socket):
5725 Remove unused variable `no_events'.
5726
5727 * w32term.c (x_draw_composite_glyph_string_foreground):
5728 Remove unused variable `width'.
5729
1149507c
JB
57302011-03-24 Juanma Barranquero <lekktu@gmail.com>
5731
5732 * w32term.c (x_set_glyph_string_clipping):
5733 Don't pass uninitialized region to CombineRgn.
5734
9c88f339
JB
57352011-03-23 Juanma Barranquero <lekktu@gmail.com>
5736
5737 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5738 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5739 (Fx_close_connection): Remove unused variable `i'.
5740
5741 * w32font.c (w32font_draw): Return number of glyphs.
5742 (w32font_open_internal): Remove unused variable `i'.
5743 (w32font_driver): Add missing initializer.
5744
5745 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5746 (fill_in_menu): Remove unused variable `items_added'.
5747
5748 * w32term.c (last_mouse_press_frame): Remove static global variable.
5749 (w32_clip_to_row): Remove unused variable `f'.
5750 (x_delete_terminal): Remove unused variable `i'.
5751
5752 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5753 (NOTHING): Remove unused static global variable.
5754 (uniscribe_check_otf): Remove unused variable `table'.
5755 (uniscribe_font_driver): Add missing initializers.
5756
dee091a3
JD
57572011-03-23 Julien Danjou <julien@danjou.info>
5758
5759 * term.c (Fsuspend_tty, Fresume_tty):
5760 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5761 * window.c (temp_output_buffer_show):
5762 * insdel.c (signal_before_change):
5763 * frame.c (Fhandle_switch_frame):
5764 * fileio.c (Fdo_auto_save):
5765 * emacs.c (Fkill_emacs):
5766 * editfns.c (save_excursion_restore):
5767 * cmds.c (internal_self_insert):
5768 * callint.c (Fcall_interactively):
5769 * buffer.c (Fkill_all_local_variables):
5770 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5771 Use Frun_hooks.
0f4a96b5 5772 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5773 unconditionnaly since it does the check itself.
5774
2c520ab5 57752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5776
c9c49752
PE
5777 Fix more problems found by GCC 4.5.2's static checks.
5778
8abc3f12
PE
5779 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5780 the first time through the loop, since we know p0 < p1 then.
5781 This also avoids a gcc -Wstrict-overflow warning.
5782
a2d26660
PE
5783 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5784 leading to a memory leak, possible in functions like
5785 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5786 of objects (Bug#8318).
a2d26660 5787
916c72e9
PE
5788 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5789 that could (at least in theory) be that large.
5790
19ab8a18
PE
5791 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5792 This is less likely to overflow, and avoids undefined behavior if
5793 overflow does occur. All callers changed. Use strtoul to scan
5794 for the unsigned long integer.
b7cbbd6f
PE
5795 (pint2hrstr): Simplify and tune code slightly.
5796 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5797
f0641eff
PE
5798 * scroll.c (do_scrolling): Work around GCC bug 48228.
5799 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5800
7f650bb9
PE
5801 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5802 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5803 (validate_x_resource_name): Simplify count usage.
5804 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5805
37dd57d1
PE
5806 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5807 fail (Bug#8306).
81e56e61 5808
699979fc 5809 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5810
401bf9b4
PE
5811 * process.c (Fmake_network_process): Use socklen_t, not int,
5812 where POSIX says socklen_t is required in portable programs.
5813 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5814 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5815 (Fmake_network_process, server_accept_connection):
5816 (wait_reading_process_output, read_process_output):
5817 Likewise.
5818
b93aacde
PE
5819 * process.c: Rename or move locals to avoid shadowing.
5820 (list_processes_1, Fmake_network_process):
5821 (read_process_output_error_handler, exec_sentinel_error_handler):
5822 Rename or move locals.
4dc343ee 5823 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5824 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5825 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5826 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5827 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5828
af8a867c 5829 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5830 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5831 Include tparam.h instead, since it declares them.
af8a867c
PE
5832 * cm.h (PC): Remove extern decl; tparam.h now does this.
5833 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5834 * terminfo.c: Include tparam.h, to check interfaces.
5835 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5836 (tparam): Adjust signature to match interface in tparam.h;
5837 this removes some undefined behavior. Check that outstring and len
5838 are zero, which they always are with Emacs.
5839 * tparam.h (PC, BC, UP): New extern decls.
5840
0248044d 5841 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5842 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5843
8ff096c1 5844 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5845 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5846 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5847 (ftfont_list): Remove unused local.
49eaafba
PE
5848 (get_adstyle_property, ftfont_pattern_entity):
5849 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5850 Rename locals to avoid shadowing.
8ff096c1 5851
e2be39f6
PE
5852 * xfont.c (xfont_list_family): Mark var as initialized.
5853
c9735e30
PE
5854 * xml.c (make_dom): Now static.
5855
8f5201ae
PE
5856 * composite.c (composition_compute_stop_pos): Rename local to
5857 avoid shadowing.
b246f932
PE
5858 (composition_reseat_it): Remove unused locals.
5859 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5860 (composition_update_it): Mark var as initialized.
11b61122
PE
5861 (find_automatic_composition): Mark vars as initialized,
5862 with a FIXME (Bug#8290).
8f5201ae 5863
760fbc2c
PE
5864 character.h: Rename locals to avoid shadowing.
5865 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5866 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5867 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5868 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5869 to avoid shadowing.
5870
ff08eb85
PE
5871 * textprop.c (property_change_between_p): Remove; unused.
5872
fc7bf025
PE
5873 * intervals.c (interval_start_pos): Now static.
5874
235d7abc
PE
5875 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5876
44f230aa
SM
5877 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5878 Rename locals to avoid shadowing.
3e7d6594 5879
50060332
PE
5880 * sound.c (wav_play, au_play, Fplay_sound_internal):
5881 Fix pointer signedness.
d01f234b 5882 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5883 (wav_play): Initialize a variable to 0, to prevent undefined
5884 behavior (Bug#8278).
50060332 5885
c4fc4e30
PE
5886 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5887
918436ed
PE
5888 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5889
c939f91b
PE
5890 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5891 clobbering (Bug#8298).
b9c7f648
PE
5892 * sysdep.c (sys_subshell): Likewise.
5893 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5894
6bd8c144
PE
5895 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5896 This should get cleaned up, so that child_setup has the
5897 same signature on all platforms.
5898
7710357c 5899 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5900 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5901
c59da222
CY
59022011-03-22 Chong Yidong <cyd@stupidchicken.com>
5903
5904 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5905 not to be necessary, and produces flickering.
5906
66b87493
GM
59072011-03-20 Glenn Morris <rgm@gnu.org>
5908
5909 * config.in: Remove file.
5910
45b6f6d5
JB
59112011-03-20 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5914 are now in src/globals.h.
5915 (syms_of_minibuf): Remove spurious & from previous change.
5916
3ec03f7e
LL
59172011-03-20 Leo <sdl.web@gmail.com>
5918
5919 * minibuf.c (completing-read-function): New variable.
5920 (completing-read-default): Rename from completing-read.
5921 (completing-read): Call completing-read-function.
5922
b14e3e21
CY
59232011-03-19 Juanma Barranquero <lekktu@gmail.com>
5924
5925 * xfaces.c (Fx_load_color_file):
5926 Read color file from absolute filename (bug#8250).
5927
f2b726e6
JB
59282011-03-19 Juanma Barranquero <lekktu@gmail.com>
5929
5930 * makefile.w32-in: Update dependencies.
5931
09f6ff02
EZ
59322011-03-17 Eli Zaretskii <eliz@gnu.org>
5933
5934 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5935
29a6015a
PE
59362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5937
a3a6c54e
PE
5938 Fix more problems found by GCC 4.5.2's static checks.
5939
b766f867
PE
5940 * process.c (make_serial_process_unwind, send_process_trap):
5941 (sigchld_handler): Now static.
5942
be02381c
PE
5943 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5944 That way, the code declares only the vars that it needs.
5945 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5946 * s/cygwin.h (PTY_ITERATION): Likewise.
5947 * s/darwin.h (PTY_ITERATION): Likewise.
5948 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5949
57048744
PE
5950 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5951 * process.c (allocate_pty): Don't declare stb unless it's needed.
5952
7914961c 5953 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5954 (CONSTANTLIM): Remove; unused.
5955 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5956 Define only if needed.
7914961c 5957
b3967b18
PE
5958 * unexelf.c (unexec): Name an expression,
5959 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5960 Use a different way to cause a compilation error if anyone uses
5961 n rather than nn, a way that does not involve shadowing.
73366a00 5962 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5963
29a6015a
PE
5964 * deps.mk (unexalpha.o): Remove; unused.
5965
43cfc33e 5966 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5967 * unexec.h: New file.
ce701a33
PE
5968 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5969 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5970 Depend on unexec.h.
5971 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5972 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5973 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5974 Change as necessary to match prototype in unexec.h.
ce701a33 5975
01f44d5a
PE
5976 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5977 shadowing.
4f63c6bb 5978 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5979
a6670b0b
PE
5980 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5981 Rename locals to avoid shadowing.
5982
cef2010d 5983 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5984 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5985
d4d7173a
PE
5986 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5987
f08b802a
PE
5988 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5989 warning when compiling print.c.
5990
3ddb0639
PE
5991 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5992 instead of using an uninitialized var.
5ad03b97 5993 (font_sort_entities): Mark var as initialized.
3ddb0639 5994
170a2692
PE
5995 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5996
e663c700
PE
5997 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5998 pointers to constants.
89bc529a 5999 (font_parse_fcname): Remove unused vars.
7b81e2d0 6000 (font_delete_unmatched): Now static.
ea838e10 6001 (font_get_spec): Remove; unused.
13a547c6
PE
6002 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6003 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6004 Rename or move locals to avoid shadowing.
e663c700 6005
2a80c887 6006 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6007 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6008
1384fa33 6009 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6010 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6011
8b2c52e9
PE
6012 * alloc.c (mark_backtrace): Move decl from here ...
6013 * lisp.h: ... to here, so that it can be checked.
6014
475545b5 6015 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6016 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6017 (lisp_indirect_variable): Name an expression,
6018 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6019 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6020
b1349114 6021 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6022 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6023 Use const pointer when appropriate.
b1349114 6024
a2928364
PE
6025 * lisp.h (get_system_name, get_operating_system_release):
6026 Move decls here, to check interfaces.
6027 * process.c (get_operating_system_release): Move decl to lisp.h.
6028 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6029 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6030 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6031 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6032 (Fformat_time_string, Fencode_time, Finsert_char):
6033 (Ftranslate_region_internal, Fformat):
6034 Rename or remove local vars to avoid shadowing.
9710023e 6035 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6036
a415e694
PE
6037 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6038 avoid shadowing.
6039
8ef4622d
PE
6040 * lisp.h (eassert): Check that the argument compiles, even if
6041 ENABLE_CHECKING is not defined.
6042
946f9a5b
PE
6043 * data.c (Findirect_variable): Name an expression, to avoid
6044 gcc -Wbad-function-cast warning.
112396d6 6045 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6046 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6047 (Fmake_variable_buffer_local, Fmake_local_variable):
6048 Mark variables as initialized.
52746918 6049 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6050
e5aab7e7 6051 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6052 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6053 Rename locals to avoid shadowing.
dff45157
PE
6054 (mark_stack): Move local variables into the #ifdef region where
6055 they're used.
7bc26fdb
PE
6056 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6057 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6058 needed otherwise.
6059 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6060 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6061 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6062
e5aab7e7
PE
6063 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6064 avoids undefined behavior in theory.
6065
4da60324
PE
6066 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6067
88043301
PE
6068 Use functions, not macros, for up- and down-casing (Bug#8254).
6069 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6070 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6071 to use the following functions instead of these macros.
6072 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6073 EMACS_INT, since callers assume the returned value fits in int.
6074 (upcase1): Likewise, for UPCASE_TABLE.
6075 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6076 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6077 the race-condition problem in the old DOWNCASE.
88043301 6078
19ed5445
PE
6079 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6080 Rename locals to avoid shadowing.
6081 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6082 (regex_compile, re_search_2, re_match_2_internal):
6083 Remove unused local vars.
952db0d7
PE
6084 (FREE_VAR): Rewrite so as not to use empty "else",
6085 which gcc can warn about.
da053e48 6086 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6087 (RETALLOC_IF): Define only if needed.
6088 (WORDCHAR_P): Likewise. This one is never needed, but is used
6089 only in a comment talking about a compiler bug, so put inside
6090 the #if 0 of that comment.
6091 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6092 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6093 Remove; unused.
19ed5445 6094
1f3561e4 6095 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6096 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6097 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6098
ded6f8f7
PE
6099 * search.c (simple_search): Remove unused var.
6100
dbd37a95
PE
6101 * dired.c (compile_pattern): Move decl from here ...
6102 * lisp.h: ... to here, so that it can be checked.
6103 (struct re_registers): New forward decl.
6104
7e47afad
PE
6105 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6106
85f24f61
PE
6107 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6108 All uses changed.
6109 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6110 Rename locals to avoid shadowing.
5671df8f 6111 (Fvertical_motion): Mark locals as initialized.
85f24f61 6112
181aa2be 6113 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6114 (casify_region): Mark local as initialized.
181aa2be 6115
930d429c
PE
6116 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6117
7082eac6
PE
6118 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6119 New macros, so that the caller can use some names other than
6120 gcpro1, gcpro2, etc.
6121 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6122 of the new macros.
6123 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6124 argument, for consistency with GCPRO2_VAR, etc: it is now the
6125 prefix of the variable, not the variable itself. All uses
6126 changed.
38b2c076
PE
6127 * dired.c (directory_files_internal, file_name_completion):
6128 Rename locals to avoid shadowing.
6129
15206ed9
PE
6130 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6131 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6132 dired.c's scmp function, had undefined behavior.
6133 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6134 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6135 * buffer.h: ... to here, because these macros use current_buffer,
6136 and the new implementation with inline functions needs to have
6137 current_buffer in scope now, rather than later when the macros
6138 are used.
6139 (downcase, upcase1): New static inline functions.
6140 (DOWNCASE, UPCASE1): Reimplement using these functions.
6141 This avoids undefined behavior in expressions like
6142 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6143 from race conditions in accessing the global variables
6144 case_temp1 and case_temp2.
6145 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6146 * lisp.h (case_temp1, case_temp2): Remove their decls.
6147 * character.h (ASCII_CHAR_P): Move from here ...
6148 * lisp.h: ... to here, so that the inline functions mentioned
6149 above can use them.
6150
4a6bea26
PE
6151 * dired.c (directory_files_internal_unwind): Now static.
6152
f14b7e14
PE
6153 * fileio.c (file_name_as_directory, directory_file_name):
6154 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6155 Now static.
2893f146
PE
6156 (file_name_as_directory): Use const pointers when appropriate.
6157 (Fexpand_file_name): Likewise. In particular, newdir might
6158 point at constant storage, so make it a const pointer.
fd4ead52 6159 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6160 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6161 signedness issues.
f839df0c
PE
6162 (Fset_file_times, Finsert_file_contents, auto_save_error):
6163 Rename locals to avoid shadowing.
f14b7e14 6164
5716756e 6165 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6166 (Ftry_completion, Fall_completions): Rename or remove locals
6167 to avoid shadowing.
5716756e 6168
b4c3046a
PE
6169 * marker.c (bytepos_to_charpos): Remove; unused.
6170
b45db522
PE
6171 * lisp.h (verify_bytepos, count_markers): New decls,
6172 so that gcc does not warn that these functions aren't declared.
6173
85876d07
PE
6174 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6175 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6176 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6177 (copy_text): Remove unused local var.
85876d07 6178
03d78a21 6179 * filelock.c (within_one_second): Now static.
b3dd38ab 6180 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6181
5df8f01b
PE
6182 * buffer.c (fix_overlays_before): Mark locals as initialized.
6183 (fix_start_end_in_overlays): Likewise. This function should be
6184 simplified by using pointers-to-pointers, but that's a different
6185 matter.
b1d876f1 6186 (switch_to_buffer_1): Now static.
8f54f30a
PE
6187 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6188 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6189
a70072c9 6190 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6191 Fix pointer signedness issue.
edced198
PE
6192 (sys_subshell): Mark local as volatile if checking for lint,
6193 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6194 (MAXPATHLEN): Define only if needed.
a70072c9 6195
a0977c44
PE
6196 * process.c (serial_open, serial_configure): Move decls from here ...
6197 * systty.h: ... to here, so that they can be checked.
6198
a884fdcc
PE
6199 * fns.c (get_random, seed_random): Move extern decls from here ...
6200 * lisp.h: ... to here, so that they can be checked.
6201
604efe86 6202 * sysdep.c (reset_io): Now static.
b8950c94 6203 (wait_for_termination_signal): Remove; unused.
604efe86 6204
38fc62d9
PE
6205 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6206 (copy_keymap_item, append_key, push_text_char_description):
6207 Now static.
1004a21a 6208 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6209 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6210 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6211 (describe_map_tree):
6212 Rename locals to avoid shadowing.
38fc62d9 6213
2f2650da
PE
6214 * keyboard.c: Declare functions static if they are not used elsewhere.
6215 (echo_char, echo_dash, cmd_error, top_level_2):
6216 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6217 (read_char, kbd_buffer_get_event, make_lispy_position):
6218 (make_lispy_event, make_lispy_movement, apply_modifiers):
6219 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6220 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6221 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6222 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6223 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6224
a053e86c 6225 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6226 (mark_kboards): Move decl here ...
6227 * alloc.c (mark_kboards): ... from here.
a053e86c 6228
4752793e
PE
6229 * lisp.h (force_auto_save_soon): New decl.
6230
74f10ca7 6231 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6232 (DEFINE_DUMMY_FUNCTION): New macro.
6233 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6234 Use it.
c03cd23f
PE
6235 (main): Add casts to avoid warnings
6236 if GCC considers string literals to be constants.
74f10ca7 6237
022e70d4
PE
6238 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6239
59d6fe83
PE
6240 * dbusbind.c: Pointer signedness fixes.
6241 (xd_signature, xd_append_arg, xd_initialize):
6242 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6243 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6244 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6245 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6246
78320123
PE
6247 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6248 if GCC considers string literals to be constants.
49cebcca 6249 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6250
35ac2a97
SM
62512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6252
fb103ca9
SM
6253 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6254 (print_preprocess, print_object): New macro to fix last change.
6255
35ac2a97
SM
6256 * print.c (print_preprocess): Don't forget font objects.
6257
62973b41
JB
62582011-03-16 Juanma Barranquero <lekktu@gmail.com>
6259
6260 * emacs.c (USAGE3): Doc fixes.
6261
0e48bb22
AS
62622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6263
6264 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6265 structure.
6266
7684e57b
JB
62672011-03-14 Juanma Barranquero <lekktu@gmail.com>
6268
6269 * lisp.h (VWindow_system, Qfile_name_history):
6270 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6271 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6272 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6273
6274 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6275 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6276
6277 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6278 * w32console.c (detect_input_pending, read_input_pending)
6279 (encode_terminal_code):
6280 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6281 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6282 (w32_system_caret_y, Qfile_name_history):
6283 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6284 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6285 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6286 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6287 * w32proc.c (Qlocal, report_file_error):
6288 * w32term.c (Vwindow_system, updating_frame):
6289 * w32uniscribe.c (initialized, uniscribe_font_driver):
6290 Remove unneeded extern declarations.
6291
2aa46d6c
CY
62922011-03-14 Chong Yidong <cyd@stupidchicken.com>
6293
c96bbc66 6294 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6295
cffc6f3b
CY
62962011-03-13 Chong Yidong <cyd@stupidchicken.com>
6297
6298 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6299 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6300 These macros can no longer be used for assignment.
6301
44f230aa
SM
6302 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6303 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6304 (record_buffer_markers, fetch_buffer_markers): New functions for
6305 recording and fetching special buffer markers.
6306 (set_buffer_internal_1, set_buffer_temp): Use them.
6307
6308 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6309
6310 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6311
6312 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6313 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6314
6315 * xdisp.c (hscroll_window_tree):
6316 (reconsider_clip_changes): Use PT instead of BUF_PT.
6317
d251f04b
EZ
63182011-03-13 Eli Zaretskii <eliz@gnu.org>
6319
6320 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6321 $(EMACS_ROOT)/lib/intprops.h.
6322
f0c77cd1
PE
63232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6324
3eca4629
PE
6325 Fix more problems found by GCC 4.5.2's static checks.
6326
7c86ee98
PE
6327 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6328 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6329 (xg_free_frame_widgets): Make it clear that a local variable is
6330 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6331 (gdk_window_get_screen): Make it clear that this macro is needed
6332 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6333 (int_gtk_range_get_value): New function, which avoids a diagnostic
6334 from gcc -Wbad-function-cast.
6335 (xg_set_toolkit_scroll_bar_thumb): Use it.
6336 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6337 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6338 (get_utf8_string, xg_get_file_with_chooser):
6339 Rename locals to avoid shadowing.
6340 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6341
41729b81
PE
6342 * xgselect.c (xg_select): Remove unused var.
6343
f0c77cd1
PE
6344 * image.c (four_corners_best): Mark locals as initialized.
6345 (gif_load): Initialize transparent_p to zero (Bug#8238).
6346 Mark another local as initialized.
ec6cf4c6 6347 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6348
ce0ad53d 6349 * image.c (clear_image_cache): Now static.
d5d5a617 6350 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6351 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6352 (x_edge_detection): Remove unnecessary cast that
6353 gcc -Wbad-function-cast diagnoses.
2037898d 6354 (gif_load): Fix pointer signedness.
6ae141d6
PE
6355 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6356 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6357
33383987 63582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6359
d32df629
PE
6360 Improve quality of tests for time stamp overflow.
6361 For example, without this patch (encode-time 0 0 0 1 1
6362 1152921504606846976) returns the obviously-bogus value (-948597
6363 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6364 reports time overflow. See
6365 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6366 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6367 * editfns.c: Include limits.h and intprops.h.
6368 (TIME_T_MIN, TIME_T_MAX): New macros.
6369 (time_overflow): Move earlier, to before first use.
6370 (hi_time, lo_time): New functions, for an accurate test for
6371 out-of-range times.
6372 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6373 (Fget_internal_run_time): Don't assume time_t fits in int.
6374 (make_time): Use list2 instead of Fcons twice.
6375 (Fdecode_time): More accurate test for out-of-range times.
6376 (check_tm_member): New function.
6377 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6378 (lisp_time_argument): Don't rely on undefined left-shift and
6379 right-shift behavior when checking for time stamp overflow.
8be6f318 6380
fe31d94c
PE
6381 * editfns.c (time_overflow): New function, refactoring common code.
6382 (Fformat_time_string, Fdecode_time, Fencode_time):
6383 (Fcurrent_time_string): Use it.
6384
8be6f318
PE
6385 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6386 * dired.c (make_time): Move to ...
6387 * editfns.c (make_time): ... here.
6388 * systime.h: Note the move.
6389
09d9db2c 63902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6391
126bc0dc
YM
6392 * fringe.c (update_window_fringes): Remove unused variables.
6393
c47cbdfd
YM
6394 * unexmacosx.c (copy_data_segment): Also copy __got section.
6395 (Bug#8223)
6396
7ac80be9
EZ
63972011-03-12 Eli Zaretskii <eliz@gnu.org>
6398
c96bbc66 6399 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6400 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6401 Constify `char *' arguments and their references according to
6402 prototypes in tparam.h.
6403
ecb0f94d 6404 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6405
7ac80be9
EZ
6406 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6407 Adapt all references accordingly.
6408
6409 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6410
ef1fd07e
TT
64112011-03-11 Tom Tromey <tromey@redhat.com>
6412
6413 * buffer.c (syms_of_buffer): Remove obsolete comment.
6414
7ef4b50c
EZ
64152011-03-11 Eli Zaretskii <eliz@gnu.org>
6416
6417 * termhooks.h (encode_terminal_code): Declare prototype.
6418
6419 * msdos.c (encode_terminal_code): Don't declare prototype.
6420
6421 * term.c (encode_terminal_code): Now external again, used by
6422 w32console.c and msdos.c.
6423
44f230aa
SM
6424 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6425 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6426
4b1ec863 64272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6428
1714f52b 6429 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6430
4b1ec863
PE
6431 * fringe.c (update_window_fringes): Mark locals as initialized
6432 (Bug#8227).
6433 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6434
524c7aa6
PE
6435 * alloc.c (mark_fringe_data): Move decl from here ...
6436 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6437 to check its interface.
6438 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6439
a5c0af81 6440 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6441 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6442 (fontset_font): Mark local as initialized.
a9a06e0b 6443 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6444
b4716021
PE
6445 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6446
811e9bac 6447 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6448 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6449 (x_own_selection, Fx_disown_selection_internal): Rename locals
6450 to avoid shadowing.
6451 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6452
7e3ab302
PE
6453 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6454 so that the caller can use some name other than gcpro1.
6455 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6456 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6457 (Fx_backspace_delete_keys_p):
6458 Use them to avoid shadowing, and rename vars to avoid shadowing.
6459 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6460 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6461 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6462 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6463 Remove unused locals.
7e3ab302
PE
6464 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6465 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6466 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6467 macros.
f78faa98 6468
e2b13473
PE
6469 * xterm.h (x_mouse_leave): New decl.
6470
77f23912
PE
6471 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6472 Remove unused functions.
cdf4ba58
PE
6473 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6474 (x_calc_absolute_position): Now static.
7411c686 6475 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6476 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6477 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6478 unless they are used.
38d0b34a
PE
6479 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6480 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6481 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6482 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6483 (x_error_catcher, x_connection_closed, x_error_handler):
6484 (x_error_quitter, xembed_send_message, x_iconify_frame):
6485 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6486 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6487 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6488
44f230aa
SM
6489 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6490 Rename or move locals to avoid shadowing.
6b463e58 6491 (tty_defined_color, merge_face_heights): Now static.
5967d051 6492 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6493 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6494 does not deduce is never used uninitialized.
73719eba
PE
6495 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6496 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6497
426994c3 6498 * terminal.c (store_terminal_param): Now static.
5489860b 6499
032f1620 6500 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6501 (set_frame_menubar): Remove unused local.
d4323972 6502 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6503 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6504 since they might point to immutable storage.
281585b0
PE
6505 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6506 since it's unused otherwise.
032f1620 6507
367c19e5 6508 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6509 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6510 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6511 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6512 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6513 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6514 does not deduce are never used uninitialized.
70739cbe 6515
07b48fa9
PE
6516 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6517
8868a238 6518 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6519 * window.c (window_loop, size_window):
6520 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6521
7e5cf297 6522 * window.c (display_buffer): Now static.
d6550a9f
PE
6523 (size_window): Mark variables that gcc -Wuninitialized
6524 does not deduce are never used uninitialized.
a586633d
PE
6525 * window.h (check_all_windows): New decl, to forestall
6526 gcc -Wmissing-prototypes diagnostic.
5b555da1 6527 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6528
f6095868
PE
6529 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6530 shadowing.
6531 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6532 Include <limits.h>.
6533 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6534 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6535 (load_charset_map): Mark variables that gcc -Wuninitialized
6536 does not deduce are never used uninitialized.
53df7c11 6537 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6538
f38b440c
PE
6539 * coding.c (coding_set_source, coding_set_destination):
6540 Use "else { /* comment */ }" rather than "else /* comment */;"
6541 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6542 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6543 a block, when the outer 'i' will do.
6544 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6545 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6546 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6547 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6548 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6549 Rename locals to avoid shadowing.
6550 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6551 * coding.c (emacs_mule_char, encode_invocation_designation):
6552 Now static, since they're not used elsewhere.
413bb2db 6553 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6554 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6555 (decode_coding_emacs_mule): Mark variables that gcc
6556 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6557 (detect_coding_iso_2022): Initialize a local variable that might
6558 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6559 this initialization is needed. (Bug#8211)
5f58e762
PE
6560 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6561 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6562 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6563 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6564 Remove unused macros.
f38b440c 6565
232b38b9 6566 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6567 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6568 * character.c (string_count_byte8): Likewise.
232b38b9 6569
fb90da1b
PE
6570 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6571 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6572
fb93dbc2
PE
6573 * chartab.c (copy_sub_char_table): Now static, since it's not used
6574 elsewhere.
5c156ace
PE
6575 (sub_char_table_ref_and_range, char_table_ref_and_range):
6576 Rename locals to avoid shadowing.
bbcd0949 6577 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6578
7d3b3862 6579 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6580 (BIDI_BOB): Remove unused macro.
7d3b3862 6581
6be7d3da
PE
6582 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6583 deduce are never used uninitialized.
c2ed9c8b 6584 * term.c (encode_terminal_code): Likewise.
6be7d3da 6585
75f8807f 6586 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6587
50938595
PE
6588 * tparam.h: New file.
6589 * term.c, tparam.h: Include it.
6590 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6591 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6592 Move these decls to tparam.h, and make them agree with what
6593 is actually in tparam.c. The previous trick of using incompatible
6594 decls in different modules does not conform to the C standard.
6595 All callers of tparam changed to use tparam's actual API.
6596 * tparam.c (tparam1, tparam, tgoto):
6597 Use const pointers where appropriate.
6598
fbceeba2
PE
6599 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6600 * cm.h (struct cm): Likewise.
6601 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6602 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6603 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6604 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6605 (turn_on_face, init_tty): Likewise.
6606 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6607
7f3f1250
PE
6608 * term.c (term_mouse_position): Rename local to avoid shadowing.
6609
e6ca6543
PE
6610 * alloc.c (mark_ttys): Move decl from here ...
6611 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6612
c40f8d15
AS
66132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6614
6615 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6616
cfe0661d
JB
66172011-03-09 Juanma Barranquero <lekktu@gmail.com>
6618
6619 * search.c (compile_pattern_1): Remove argument regp, unused since
6620 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6621 (compile_pattern): Don't pass it.
6622
0afb4571
J
66232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6624
6625 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6626 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6627 for ! HAVE_GTK3.
6628 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6629
6630 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6631
6632 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6633 gdk_window_get_screen, gdk_window_get_geometry,
6634 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6635 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6636 (xg_get_pixbuf_from_pixmap): New function.
6637 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6638 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6639 Call xg_get_pixbuf_from_pixmap instead of
6640 gdk_pixbuf_get_from_drawable.
6641 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6642 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6643 (xg_check_special_colors): Use GtkStyleContext and its functions
6644 for HAVE_GTK3.
6645 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6646 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6647 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6648 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6649 Call gtk_widget_get_preferred_size.
0afb4571
J
6650 (xg_frame_resized): gdk_window_get_geometry only takes 5
6651 parameters.
44f230aa
SM
6652 (xg_win_to_widget, xg_event_is_for_menubar):
6653 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6654 (xg_set_widget_bg): New function.
6655 (delete_cb): New function.
895009e1 6656 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6657 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6658 (xg_set_background_color): Call xg_set_widget_bg.
6659 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6660 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6661 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6662 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6663 if ! HAVE_GTK3.
6664 (update_frame_tool_bar): Call gtk_widget_hide.
6665 (xg_initialize): Use GDK_KEY_g.
6666
6667 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6668 if ! HAVE_GTK3
6669 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6670
6671 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6672 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6673 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6674
1c2cc4ef
JB
66752011-03-08 Juanma Barranquero <lekktu@gmail.com>
6676
6677 * w32xfns.c (select_palette): Check success of RealizePalette against
6678 GDI_ERROR, not zero.
6679
33383987 6680See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6681
6682;; Local Variables:
6683;; coding: utf-8
aac0c6e3
MR
6684;; End:
6685
33383987 6686 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6687
6688 This file is part of GNU Emacs.
6689
6690 GNU Emacs is free software: you can redistribute it and/or modify
6691 it under the terms of the GNU General Public License as published by
6692 the Free Software Foundation, either version 3 of the License, or
6693 (at your option) any later version.
6694
6695 GNU Emacs is distributed in the hope that it will be useful,
6696 but WITHOUT ANY WARRANTY; without even the implied warranty of
6697 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6698 GNU General Public License for more details.
6699
6700 You should have received a copy of the GNU General Public License
6701 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.