* frames.texi (Basic Parameters): Document the `explicit-name'
[bpt/emacs.git] / src / ChangeLog
CommitLineData
28545e04
MR
12011-07-02 Martin Rudalics <rudalics@gmx.at>
2
3 * window.h (window): Remove clone_number slot.
4 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5 Remove.
6 (make_parent_window, make_window, saved_window)
7 (Fset_window_configuration, save_window_save): Don't deal with
8 clone numbers.
9 * buffer.c (Qclone_number): Remove declaration.
10 (sort_overlays, overlay_strings): Don't deal with clone numbers.
11
3349e122
SM
122011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
13
14 Add multiple inheritance to keymaps.
15 * keymap.c (Fmake_composed_keymap): New function.
16 (Fset_keymap_parent): Simplify.
17 (fix_submap_inheritance): Remove.
18 (access_keymap_1): New function extracted from access_keymap to handle
19 embedded parents and handle lists of maps.
20 (access_keymap): Use it.
21 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
22 (Fcopy_keymap): Handle embedded parents.
23 (Fcommand_remapping, define_as_prefix): Simplify.
24 (Fkey_binding): Simplify.
25 (syms_of_keymap): Move minibuffer-local-completion-map,
26 minibuffer-local-filename-completion-map,
27 minibuffer-local-must-match-map, and
28 minibuffer-local-filename-must-match-map to Elisp.
29 (syms_of_keymap): Defsubr make-composed-keymap.
30 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
31 (parse_menu_item): Trivial simplification.
32
3279eb87
GM
332011-07-01 Glenn Morris <rgm@gnu.org>
34
35 * Makefile.in (SETTINGS_LIBS): Fix typo.
36
4550efdf
KI
372011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
38
39 * coding.c (Fencode_coding_string): Record the last coding system
40 used, as the function doc string says (bug#8738).
41
0949d2b6
JD
422011-07-01 Jan Djärv <jan.h.d@swipnet.se>
43
44 * xsettings.c (store_monospaced_changed): Take new font as arg and
45 check for change against current_mono_font.
46 (EMACS_TYPE_SETTINGS): Remove this and related defines.
47 (emacs_settings_constructor, emacs_settings_get_property)
48 (emacs_settings_set_property, emacs_settings_class_init)
49 (emacs_settings_init, gsettings_obj): Remove.
50 (something_changedCB): New function for HAVE_GSETTINGS.
51 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
52 with value as argument.
53 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
54 g_settings_new (Bug#8967). Do not create gsettings_obj.
55 Remove calls to g_settings_bind. Connect something_changedCB to
56 "changed".
57
58 * xgselect.c: Add defined (HAVE_GSETTINGS).
59 (xgselect_initialize): Ditto.
60
61 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
62 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
63 xg_select.
64
bbc6b304
PE
652011-07-01 Paul Eggert <eggert@cs.ucla.edu>
66
67 * eval.c (struct backtrace): Simplify and port the data structure.
68 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
69 signed bit field, as this assumption is not portable and it makes
70 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
71 "char debug_on_exit : 1" as this is not portable either; instead,
72 use the portable "unsigned int debug_on_exit : 1". Remove unused
73 member evalargs. Remove obsolete comments about cc bombing out.
74
9851bfc5
JD
752011-06-30 Jan Djärv <jan.h.d@swipnet.se>
76
51bb811f 77 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
78 Let HAVE_GSETTINGS override HAVE_GCONF.
79 (store_monospaced_changed): New function.
80 (EMACS_SETTINGS): A new type derived from GObject to handle
81 GSettings notifications.
82 (emacs_settings_constructor, emacs_settings_get_property)
83 (emacs_settings_set_property, emacs_settings_class_init):
84 New functions.
85 (gsettings_client, gsettings_obj): New variables.
86 (GSETTINGS_SCHEMA): New define.
87 (something_changedCB): Call store_monospaced_changed.
88 (init_gsettings): New function.
89 (xsettings_initialize): Call init_gsettings.
90 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
91 to NULL.
92
93 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
94 GCONF_CFLAGS/LIBS.
95
5386012d
MR
962011-06-29 Martin Rudalics <rudalics@gmx.at>
97
98 * window.c (resize_root_window, grow_mini_window)
99 (shrink_mini_window): Rename Qresize_root_window to
100 Qwindow_resize_root_window and Qresize_root_window_vertically to
101 Qwindow_resize_root_window_vertically.
102
f13e0b08
PE
1032011-06-28 Paul Eggert <eggert@cs.ucla.edu>
104
105 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
106
94515237
JB
1072011-06-27 Juanma Barranquero <lekktu@gmail.com>
108
109 * makefile.w32-in: Redesign dependencies so they reflect more
110 clearly which files are directly included by each source file,
111 and not through other includes.
112
e43b6e43
MR
1132011-06-27 Martin Rudalics <rudalics@gmx.at>
114
115 * buffer.c (Qclone_number): Declare static and DEFSYM it.
116 (sort_overlays, overlay_strings): When an overlay's clone number
117 matches the window's clone number process the overlay even if
118 the overlay's window property doesn't match the current window.
119
d68443dc
MR
120 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
121 (Fwindow_hchild): Rename to Fwindow_left_child.
122 (Fwindow_next): Rename to Fwindow_next_sibling.
123 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
124 (resize_window_check): Rename to window_resize_check.
125 (resize_window_apply): Rename to window_resize_apply.
126 (Fresize_window_apply): Rename to Fwindow_resize_apply.
127 (Fdelete_other_windows_internal, resize_frame_windows)
128 (Fsplit_window_internal, Fdelete_window_internal)
129 (grow_mini_window, shrink_mini_window)
130 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 131
c7e73be5
JD
1322011-06-26 Jan Djärv <jan.h.d@swipnet.se>
133
134 * emacsgtkfixed.h: State that this is only used with Gtk+3.
135 (emacs_fixed_set_min_size): Remove.
136 (emacs_fixed_new): Take frame as argument.
137
138 * emacsgtkfixed.c: State that this is only used with Gtk+3.
139 (_EmacsFixedPrivate): Remove minwidth/height.
140 Add struct frame *f.
141 (emacs_fixed_init): Initialize priv->f.
142 (get_parent_class, emacs_fixed_set_min_size): Remove.
143 (emacs_fixed_new): Set priv->f to argument.
144 (emacs_fixed_get_preferred_width)
145 (emacs_fixed_get_preferred_height): Use min_width/height from
146 frames size_hint to set minimum and natural (Bug#8919).
147 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
148 and use min_width/height from frames size_hint to set
149 min_width/height (Bug#8919).
150
151 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
152 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
153 indentation.
154
cf99dcf8
EZ
1552011-06-26 Eli Zaretskii <eliz@gnu.org>
156
157 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
158 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
159 called at ZV.
160
029529ac
CY
1612011-06-26 Chong Yidong <cyd@stupidchicken.com>
162
163 * process.c (wait_reading_process_output): Bypass select if
164 waiting for a cell while ignoring keyboard input, and input is
165 pending. Suggested by Jan Djärv (Bug#8869).
166
7a7ef429
PE
1672011-06-25 Paul Eggert <eggert@cs.ucla.edu>
168
169 Use gnulib's dup2 module instead of rolling our own.
170 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
171
11fdef7d 1722011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
173
174 * dispnew.c (scrolling_window): Before scrolling, turn off a
175 mouse-highlight in the window being scrolled.
176
cd3520a4
JB
1772011-06-24 Juanma Barranquero <lekktu@gmail.com>
178
179 Move DEFSYM to lisp.h and use everywhere.
180
181 * character.h (DEFSYM): Move declaration...
182 * lisp.h (DEFSYM): ...here.
183
184 * gnutls.c:
185 * minibuf.c:
186 * w32menu.c:
187 * w32proc.c:
188 * w32select.c: Don't include character.h.
189
190 * alloc.c (syms_of_alloc):
191 * buffer.c (syms_of_buffer):
192 * bytecode.c (syms_of_bytecode):
193 * callint.c (syms_of_callint):
194 * casefiddle.c (syms_of_casefiddle):
195 * casetab.c (init_casetab_once):
196 * category.c (init_category_once, syms_of_category):
197 * ccl.c (syms_of_ccl):
198 * cmds.c (syms_of_cmds):
199 * composite.c (syms_of_composite):
200 * dbusbind.c (syms_of_dbusbind):
201 * dired.c (syms_of_dired):
202 * dispnew.c (syms_of_display):
203 * doc.c (syms_of_doc):
204 * editfns.c (syms_of_editfns):
205 * emacs.c (syms_of_emacs):
206 * eval.c (syms_of_eval):
207 * fileio.c (syms_of_fileio):
208 * fns.c (syms_of_fns):
209 * frame.c (syms_of_frame):
210 * fringe.c (syms_of_fringe):
211 * insdel.c (syms_of_insdel):
212 * keymap.c (syms_of_keymap):
213 * lread.c (init_obarray, syms_of_lread):
214 * macros.c (syms_of_macros):
215 * msdos.c (syms_of_msdos):
216 * print.c (syms_of_print):
217 * process.c (syms_of_process):
218 * search.c (syms_of_search):
219 * sound.c (syms_of_sound):
220 * syntax.c (init_syntax_once, syms_of_syntax):
221 * terminal.c (syms_of_terminal):
222 * textprop.c (syms_of_textprop):
223 * undo.c (syms_of_undo):
224 * w32.c (globals_of_w32):
225 * window.c (syms_of_window):
226 * xdisp.c (syms_of_xdisp):
227 * xfaces.c (syms_of_xfaces):
228 * xfns.c (syms_of_xfns):
229 * xmenu.c (syms_of_xmenu):
230 * xsettings.c (syms_of_xsettings):
231 * xterm.c (syms_of_xterm): Use DEFSYM.
232
4228cf16
TZ
2332011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
234
cd3520a4 235 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 236
7fcccf1e
PE
2372011-06-23 Paul Eggert <eggert@cs.ucla.edu>
238
7efb4e0e
PE
239 Integer and buffer overflow fixes (Bug#8873).
240
ff5844ad
PE
241 * print.c (printchar, strout): Check for string overflow.
242 (PRINTPREPARE, printchar, strout):
243 Don't set size unless allocation succeeds.
244
90532f02
PE
245 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
246 for sizes. Check for string overflow more accurately.
247 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
248
6d84508d
PE
249 * macros.c: Integer and buffer overflow fixes.
250 * keyboard.h (struct keyboard.kbd_macro_bufsize):
251 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
252 Use ptrdiff_t, not int, for sizes.
253 Don't increment bufsize until after realloc succeeds.
254 Check for size-calculation overflow.
255 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
256
437b2cb4
PE
257 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
258
8b9ac8b4
PE
259 * lread.c: Integer overflow fixes.
260 (read_integer): Radix is now EMACS_INT, not int,
261 to improve quality of diagnostics for out-of-range radices.
262 Calculate buffer size correctly for out-of-range radices.
263 (read1): Check for integer overflow in radices, and in
264 read-circle numbers.
82cb60d3
PE
265 (read_escape): Avoid int overflow.
266 (Fload, openp, read_buffer_size, read1)
267 (substitute_object_recurse, read_vector, read_list, map_obarray):
268 Use ptrdiff_t, not int, for sizes.
269 (read1): Use EMACS_INT, not int, for sizes.
20270765 270 Check for size overflow.
8b9ac8b4 271
7fcccf1e
PE
272 * image.c (cache_image): Check for size arithmetic overflow.
273
bfbbd7e7
PE
274 * lread.c: Integer overflow issues.
275 (saved_doc_string_size, saved_doc_string_length)
276 (prev_saved_doc_string_size, prev_saved_doc_string_length):
277 Now ptrdiff_t, not int.
278 (read1): Don't assume doc string length fits in int. Check for
279 out-of-range doc string lengths.
280 (read_list): Don't assume file position fits in int.
39019e54 281 (read_escape): Check for hex character overflow.
bfbbd7e7 282
4e323265
LL
2832011-06-22 Leo Liu <sdl.web@gmail.com>
284
285 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
286 Move to minibuffer.el.
287
85fece3e
PE
2882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
289
20b84ce9 290 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
291 The following patches are for when GLYPH_DEBUG && !XASSERT.
292 * dispextern.h (trace_redisplay_p, dump_glyph_string):
293 * dispnew.c (flush_stdout):
294 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
295 Mark as externally visible.
296 * dispnew.c (check_window_matrix_pointers): Now static.
297 * dispnew.c (window_to_frame_vpos):
298 * xfns.c (unwind_create_frame):
299 * xterm.c (x_check_font): Remove unused local.
300 * scroll.c (CHECK_BOUNDS):
301 * xfaces.c (cache_fache): Rename local to avoid shadowing.
302 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
303 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
304 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
305 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
306 Now static.
307 (debug_method_add): Use va_list and vsprintf rather than relying
308 on undefined behavior with wrong number of arguments.
309 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
310 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
311 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
312 since we're not interested in debugging glyphs with old libraries.
313 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
314 GCC 4.6.0's static checking.
315
0766b489
PE
3162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
317
31fd4b32
PE
318 Integer overflow and signedness fixes (Bug#8873).
319 A few related buffer overrun fixes, too.
320
b79e8648
PE
321 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
322
0766b489
PE
323 * dispextern.h (struct face.stipple):
324 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
325 (x_bitmap_mask, x_allocate_bitmap_record)
326 (x_create_bitmap_from_data, x_create_bitmap_from_file)
327 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
328 (x_create_bitmap_from_xpm_data):
329 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
330 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
331 (.bitmaps_last):
332 * xfaces.c (load_pixmap):
333 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
334 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
335 (.bitmaps_last, struct x_output.icon_bitmap):
336 Use ptrdiff_t, not int, for bitmap indexes.
337 (x_allocate_bitmap_record): Check for size overflow.
338 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
339
b081724f
PE
340 Use ptrdiff_t, not int, for overlay counts.
341 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
342 * editfns.c (overlays_around, get_pos_property):
343 * textprop.c (get_char_property_and_overlay):
344 * xdisp.c (next_overlay_change, note_mouse_highlight):
345 * xfaces.c (face_at_buffer_position):
21514da7
PE
346 * buffer.c (OVERLAY_COUNT_MAX): New macro.
347 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
348 (Fnext_overlay_change, Fprevious_overlay_change)
349 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 350 Use ptrdiff_t, not int, for sizes.
21514da7 351 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 352
3de73e5e
PE
353 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
354
2606c57b
PE
355 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
356 (x_session_initialize): Do not assume string length fits in int.
357
aaafe47a
PE
358 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
359 This is unlikely, but can occur if DPI is outlandish.
360
2674ddc8 361 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
362 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
363
28154962
PE
364 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
365 * xrdb.c (magic_file_p, search_magic_path):
366 Omit last arg SUFFIX; it was always 0. All callers changed.
367 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
368
7de51af5
PE
369 * xfont.c (xfont_match): Avoid need for strlen.
370
25ed6cc3
PE
371 * xfns.c: Don't assume strlen fits in int.
372 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
373
4eab31dd
PE
374 * xdisp.c (message_log_check_duplicate): Return intmax_t,
375 not unsigned long, as we prefer signed integers. All callers changed.
376 Detect integer overflow in repeat count.
377 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 378 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 379
171e2a58
PE
380 * termcap.c: Don't assume sizes fit in int and never overflow.
381 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
382 (gobble_line): Check for size-calculation overflow.
383
ad39faca 384 * minibuf.c (Fread_buffer):
6e5bb2dc 385 * lread.c (intern, intern_c_string):
74ca2eb3
PE
386 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
387 Don't assume string length fits in int.
388
52c61c22 389 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
390 * gtkutil.c (style_changed_cb): Avoid need for strlen.
391
b5b8c9e5
PE
392 * font.c: Don't assume string length fits in int.
393 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
394 Use ptrdiff_t, not int.
ccd6111c
PE
395 (font_intern_prop): Don't assume string length fits in int.
396 Don't assume integer property fits in fixnum.
397 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 398
882f0d81 399 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 400 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
401 Reformulate so as not to need the command string.
402 Invoke gzip -cd rather than gunzip, as it's more portable.
403 (lock_info_type, lock_file_1, lock_file):
404 Don't assume pid_t and time_t fit in unsigned long.
405 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
406 (current_lock_owner): Prefer signed type for sizes.
407 Use memcpy, not strncpy, where memcpy is what is really wanted.
408 Don't assume (via atoi) that time_t and pid_t fit in int.
409 Check for time_t and/or pid_t out of range, e.g., via a network share.
410 Don't alloca where an auto var works fine.
411
93f4cf88
PE
412 * fileio.c: Fix some integer overflow issues.
413 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
414 Don't assume string length fits in int.
415 (directory_file_name): Don't assume string length fits in long.
416 (make_temp_name): Don't assume pid fits in int, or that its print
417 length is less than 20.
418
f3e92b69
PE
419 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
420
1bfdaf10
PE
421 * coding.c (make_subsidiaries): Don't assume string length fits in int.
422
35016e9a
PE
423 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
424
3d1e65a1
PE
425 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
426 We prefer signed integers, even for size calculations.
427
0b963a93
PE
428 * emacs.c: Don't assume string length fits in 'int'.
429 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
430 (main): Don't invoke strlen when not needed.
431
573f4b54
PE
432 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
433 (XD_DEBUG_MESSAGE): Don't waste a byte.
434
989f33ba
PE
435 * callproc.c (getenv_internal_1, getenv_internal)
436 (Fgetenv_internal):
965d34eb
PE
437 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
438
e4d29b33
PE
439 * lread.c (invalid_syntax): Omit length argument.
440 All uses changed. This doesn't fix a bug, but it simplifies the
441 code away from its former Hollerith-constant appearance, and it's
442 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 443 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 444
eb49b136
PE
445 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
446 This didn't break anything, but it didn't help either.
447 It's confusing to put a bogus integer in a place where the actual
448 value does not matter.
9f62aeb1 449 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 450 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 451
15375a22
PE
452 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
453 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
454 implementation.
b61cc01c
PE
455 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
456 We prefer signed types, and the value cannot exceed the EMACS_INT
457 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
458 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
459 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
460 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 461
53b2623d
PE
462 * indent.c (sane_tab_width): New function.
463 (current_column, scan_for_column, Findent_to, position_indentation)
464 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 465 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 466
51cab52b 467 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 468
f2ed8a70
PE
469 * lisp.h (lint_assume): New macro.
470 * composite.c (composition_gstring_put_cache):
471 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
472
abe80cc6
PE
473 * editfns.c, insdel.c:
474 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 475
b02c740e
PE
476 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
477
ebc96716
PE
478 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
479
b4e50fa0 480 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 481 Use much-faster test for byte-length change.
311d5d7c 482 Don't assume string byte-length fits in 'int'.
a4cf38e4 483 Check that character arg fits in 'int'.
85461888 484 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 485
c0c1ee9f
PE
486 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
487
a498d7f4
PE
488 * fns.c (concat): Catch string overflow earlier.
489 Do not rely on integer wraparound.
490
51cab52b
PE
491 * dispextern.h (struct it.overlay_strings_charpos)
492 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
493 * xdisp.c (forward_to_next_line_start)
494 (back_to_previous_visible_line_start)
495 (reseat_at_next_visible_line_start, next_element_from_buffer):
496 Don't arbitrarily truncate the value of 'selective' to int.
497
76031fad
PE
498 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
499
5eb55db9
PE
500 * composite.c: Don't truncate sizes to 'int'.
501 (composition_gstring_p, composition_reseat_it)
502 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
503 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
504 not EMACS_UINT, for indexes.
5eb55db9 505
0703a717
PE
506 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
507
d6202519
PE
508 * buffer.c: Include <verify.h>.
509 (struct sortvec.priority, struct sortstr.priority):
8961a454 510 Now EMACS_INT, not int.
c20998a7 511 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
512 (struct sortstr.size, record_overlay_string)
513 (struct sortstrlist.size, struct sortlist.used):
514 Don't truncate size to int.
515 (record_overlay_string): Check for size-calculation overflow.
d6202519 516 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 517
d5a19415
JM
5182011-06-22 Jim Meyering <meyering@redhat.com>
519
029529ac 520 Don't leak an XBM-image-sized buffer
d5a19415
JM
521 * image.c (xbm_load): Free the image buffer after using it.
522
a9041e6c
PE
5232011-06-21 Paul Eggert <eggert@cs.ucla.edu>
524
525 Port to Sun C.
526 * composite.c (find_automatic_composition): Omit needless 'return 0;'
527 that Sun C diagnosed.
528 * fns.c (secure_hash): Fix pointer signedness issue.
529 * intervals.c (static_offset_intervals): New function.
530 (offset_intervals): Use it.
531
7f3f739f
LL
5322011-06-21 Leo Liu <sdl.web@gmail.com>
533
534 * deps.mk (fns.o):
535 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
536 sha512.h.
537
538 * fns.c (secure_hash): Rename from crypto_hash_function and change
539 the first arg to accept symbols.
5b66d427 540 (Fsecure_hash): New primitive.
7f3f739f
LL
541 (syms_of_fns): New symbols.
542
76147d94
DD
5432011-06-20 Deniz Dogan <deniz@dogan.se>
544
545 * process.c (Fset_process_buffer): Clarify return value in
546 docstring.
547
7d7d0045
CY
5482011-06-18 Chong Yidong <cyd@stupidchicken.com>
549
550 * dispnew.c (add_window_display_history): Use BVAR.
551
552 * xdisp.c (debug_method_add): Use BVAR.
553 (check_window_end, dump_glyph_matrix, dump_glyph)
554 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
555
556 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
557 Likewise.
558
559 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
560 check till after the cache is created in init_frame_faces.
561
ff2bc410
SM
5622011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
563
564 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
565
28177add
PE
5662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
567
dd3482fe
PE
568 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
569 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
570 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
571
393d71f3 572 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
573 * fileio.c (Finsert_file_contents):
574 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
575 Remove the old (too-loose) buffer overflow checks.
576 They weren't needed, since make_gap checks for buffer overflow.
577 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
578 The old code merely checked for Emacs fixnum overflow, and relied
579 on undefined (wraparound) behavior. The new code avoids undefined
580 behavior, and also checks for ptrdiff_t and/or size_t overflow.
581
2e6813b0 582 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
583 Tune. Don't use wider integers than needed. Don't use alloca.
584 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 585
599a9e4f
PE
586 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
587
99561444
PE
588 * insdel.c, lisp.h (buffer_overflow): New function.
589 (insert_from_buffer_1, replace_range, replace_range_2):
590 * insdel.c (make_gap_larger):
591 * editfns.c (Finsert_char):
592 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
593
28177add
PE
594 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
595
e69dafad
PE
5962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
597
a7af7fde 598 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 599
b1c46f02
PE
600 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
601 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
602
e69dafad
PE
603 * fileio.c: Don't assume EMACS_INT fits in off_t.
604 (emacs_lseek): New static function.
605 (Finsert_file_contents, Fwrite_region): Use it.
606 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
607
566684ea
PE
608 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
609
e6966cd6
PE
610 * fns.c: Don't overflow int when computing a list length.
611 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
612 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
613 truncation on 64-bit hosts. Check for QUIT every
614 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
615 faster and is responsive enough.
616 (Flength): Report an error instead of overflowing an integer.
617 (Fsafe_length): Return a float if the value is not representable
618 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 619 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 620 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 621
dd0b0efb
PE
622 * alloc.c: Check that resized vectors' lengths fit in fixnums.
623 (header_size, word_size): New constants.
624 (allocate_vectorlike): Don't check size overflow here.
625 (allocate_vector): Check it here instead, since this is the only
626 caller of allocate_vectorlike that could cause overflow.
627 Check that the new vector's length is representable as a fixnum.
628
86fe5cfe
PE
629 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
630 The previous code was bogus. For example, next_almost_prime (32)
631 returned 39, which is undesirable as it is a multiple of 3; and
632 next_almost_prime (24) returned 25, which is a multiple of 5 so
633 why was the code bothering to check for multiples of 7?
634
80e88859
PE
635 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
636
4a2f0ad6
PE
637 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
638
f66c7cf8
PE
639 Variadic C functions now count arguments with ptrdiff_t.
640 This partly undoes my 2011-03-30 change, which replaced int with size_t.
641 Back then I didn't know that the Emacs coding style prefers signed int.
642 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
643 were being counted with int, which may truncate counts on 64-bit
644 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
645 * lisp.h (struct Lisp_Subr.function.aMANY)
646 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
647 Arg counts are now ptrdiff_t, not size_t.
648 All variadic functions and their callers changed accordingly.
649 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
650 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
651 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
652 * callint.c (Fcall_interactively): Check arg count for overflow,
653 to avoid potential buffer overrun. Use signed char, not 'int',
654 for 'varies' array, so that we needn't bother to check its size
655 calculation for overflow.
656 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
657 * eval.c (apply_lambda):
658 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
659 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
660 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
661
a1759b76
PE
662 * callint.c (Fcall_interactively): Don't use index var as event count.
663
d96be9fc
PE
664 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
665 * mem-limits.h (SIZE): Remove; no longer used.
666
a690a978 667 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 668
578c21e6
PE
669 Remove unnecessary casts.
670 * xterm.c (x_term_init):
671 * xfns.c (x_set_border_pixel):
672 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
673 These aren't needed now that we assume ANSI C.
674
96f53c6c
PE
675 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
676 It's more likely to cause problems (due to unsigned overflow)
677 than to cure them.
678
83c77d31
PE
679 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
680
ee2079f1
PE
681 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
682
6da65536
PE
683 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
684
7147c4a4
PE
685 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
686
193e32d9
PE
687 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
688
e5533da6
PE
689 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
690
9910e595
PE
691 GLYPH_CODE_FACE returns EMACS_INT, not int.
692 * dispextern.h (merge_faces):
693 * xfaces.c (merge_faces):
01103c44
PE
694 * xdisp.c (get_next_display_element, next_element_from_display_vector):
695 Don't assume EMACS_INT fits in int.
9910e595 696
2638320e
PE
697 * character.h (CHAR_VALID_P): Remove unused parameter.
698 * fontset.c, lisp.h, xdisp.c: All uses changed.
699
045eb8d9
PE
700 * editfns.c (Ftranslate_region_internal): Omit redundant test.
701
c1f134b5
PE
702 * fns.c (concat): Minor tuning based on overflow analysis.
703 This doesn't fix any bugs. Use int to hold character, instead
704 of constantly refetching from Emacs object. Use XFASTINT, not
705 XINT, for value known to be a character. Don't bother comparing
706 a single byte to 0400, as it's always less.
707
395fcb93 708 * floatfns.c (Fexpt):
327eeec8
PE
709 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
710
abbd3d23
PE
711 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
712 for characters.
713
684a03ef
PE
714 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
715
0fed43f3
PE
716 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
717 Without this fix, on a 64-bit host (aset S 0 4294967386) would
718 incorrectly succeed when S was a string, because 4294967386 was
719 truncated before it was used.
720
8fd02eb7
PE
721 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
722 Otherwise, an out-of-range integer could cause undefined behavior
723 on a 64-bit host.
724
f8c86b69
PE
725 * composite.c: Use int, not EMACS_INT, for characters.
726 (fill_gstring_body, composition_compute_stop_pos): Use int, not
727 EMACS_INT, for values that are known to be in character range.
728 This doesn't fix any bugs but is the usual style inside Emacs and
729 may generate better code on 32-bit machines.
730
34206dd2
PE
731 Make sure a 64-bit char is never passed to ENCODE_CHAR.
732 This is for reasons similar to the recent CHAR_STRING fix.
733 * charset.c (Fencode_char): Check that character arg is actually
734 a character. Pass an int to ENCODE_CHAR.
735 * charset.h (ENCODE_CHAR): Verify that the character argument is no
736 wider than 'int', as a compile-time check to prevent future regressions
737 in this area.
738
c5958d4c 739 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
740
741 Make sure a 64-bit char is never passed to CHAR_STRING.
742 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
743 by silently ignoring the top 32 bits, allowing some values
744 that were far too large to be valid characters.
745 * character.h: Include <verify.h>.
746 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
747 arguments are no wider than unsigned, as a compile-time check
748 to prevent future regressions in this area.
749 * data.c (Faset):
01103c44 750 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
751 (Fsubst_char_in_region):
752 * fns.c (concat):
753 * xdisp.c (decode_mode_spec_coding):
754 Adjust to CHAR_STRING's new requirement.
755 * editfns.c (Finsert_char, Fsubst_char_in_region):
756 * fns.c (concat): Check that character args are actually
757 characters. Without this test, these functions did the wrong
758 thing with wildly out-of-range values on 64-bit hosts.
759
d37ca623
PE
760 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
761 These casts should not be needed on 32-bit hosts, either.
762 * keyboard.c (read_char):
763 * lread.c (Fload): Remove casts to unsigned.
764
ea204efb
PE
765 * lisp.h (UNSIGNED_CMP): New macro.
766 This fixes comparison bugs on 64-bit hosts.
767 (ASCII_CHAR_P): Use it.
768 * casefiddle.c (casify_object):
01103c44 769 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
770 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
771 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
772 * dispextern.h (FACE_FROM_ID):
773 * keyboard.c (read_char): Use UNSIGNED_CMP.
774
41cb286c
PE
775 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
776 not to EMACS_INT, to avoid GCC warning.
777
4a1b9832
PE
778 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
779
55daad71
PE
780 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
781 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
782 isn't needed on 32-bit machines.
8f95c75c 783
01103c44
PE
784 * buffer.c (Fgenerate_new_buffer_name):
785 Use EMACS_INT for count, not int.
0ceccced 786 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
787
788 * data.c (Qcompiled_function): Now static.
789
c6f072e7
PE
790 * window.c (window_body_lines): Now static.
791
20ce5912
PE
792 * image.c (gif_load): Rename local to avoid shadowing.
793
9c4c5f81
PE
794 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
795 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
796 * alloc.c (make_save_value): Integer argument is now of type
797 ptrdiff_t, not int.
798 (mark_object): Use ptrdiff_t, not int.
799 * lisp.h (pD): New macro.
800 * print.c (print_object): Use it.
801
c0c5c8ae
PE
802 * alloc.c: Use EMACS_INT, not int, to count objects.
803 (total_conses, total_markers, total_symbols, total_vector_size)
804 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
805 (total_free_floats, total_floats, total_free_intervals)
806 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
807 Now EMACS_INT, not int. All uses changed.
808 (Fgarbage_collect): Compute overall total using a double, so that
809 integer overflow is less likely to be a problem. Check for overflow
810 when converting back to an integer.
5a25e253
PE
811 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
812 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
813 These were 'int' variables that could overflow on 64-bit hosts;
814 they were never used, so remove them instead of repairing them.
211a0b2a 815 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
816 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
817 Previously, this ceilinged at INT_MAX, but that doesn't work on
818 64-bit machines.
e46bb31a 819 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 820
c78baabf 821 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 822 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
823 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
824 when a (possibly-narrower) signed value would do just as well.
825 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 826
c9d624c6
PE
827 * alloc.c: Catch some string size overflows that we were missing.
828 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
829 for convenience in STRING_BYTES_MAX.
830 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
831 The definition here is exact; the one in lisp.h was approximate.
832 (allocate_string_data): Check for string overflow. This catches
833 some instances we weren't catching before. Also, it catches
834 size_t overflow on (unusual) hosts where SIZE_MAX <= min
835 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
836 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 837
c9d624c6
PE
838 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
839 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
840 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
841
353032ce
PE
842 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
843
2bccce07
PE
844 * alloc.c (Fmake_string): Check for out-of-range init.
845
0ac30604
SM
8462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
847
848 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
849
c195f2de
JD
8502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
851
852 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
853 xg_get_default_scrollbar_width.
854
855 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
856 (int_gtk_range_get_value): Move to the scroll bar part of the file.
857 (style_changed_cb): Call update_theme_scrollbar_width and call
858 x_set_scroll_bar_default_width and xg_frame_set_char_size for
859 all frames (Bug#8505).
860 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
861 Call gtk_window_set_resizable if HAVE_GTK3.
862 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
863 and height if HAVE_GTK3 (Bug#8505).
864 (scroll_bar_width_for_theme): New variable.
865 (update_theme_scrollbar_width): New function.
866 (xg_get_default_scrollbar_width): Move code to
867 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
868 (xg_initialize): Call update_theme_scrollbar_width.
869
870 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
871
872 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
873
e10ac9f1
MR
8742011-06-12 Martin Rudalics <rudalics@gmx.at>
875
876 * frame.c (make_frame): Call other_buffer_safely instead of
877 other_buffer.
878
879 * window.c (temp_output_buffer_show): Call display_buffer with
880 second argument Vtemp_buffer_show_specifiers and reset latter
881 immediately after the call.
882 (Vtemp_buffer_show_specifiers): New variable.
883 (auto_window_vscroll_p, next_screen_context_lines)
884 (Vscroll_preserve_screen_position): Remove leading asterisks from
885 doc-strings.
886
2d3c217e 8872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 888
7b7f97e8 889 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
890 * buffer.c (Qclone_number): Remove for now, as it's unused.
891 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
892 (record_buffer): Remove unused local.
893 * frame.c (other_visible_frames, frame_buffer_list): Now static.
894 (set_frame_buffer_list): Remove; unused.
895 * frame.h (other_visible_frames): Remove decl.
896 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
897 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
898 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
899 if HAVE_GPM.
900 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
901 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
902 Define only if HAVE_GPM.
903 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
904 (update_hints_inhibit): Remove; never set. All uses removed.
905 * widgetprv.h (emacsFrameClassRec): Remove decl.
906 * window.c (delete_deletable_window): Now returns void, since it
907 wasn't returning anything.
908 (compare_window_configurations): Remove unused locals.
909 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
910 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
911 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
912 the same widths as pointers. This follows up on the 2011-05-06 patch.
913 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
914 * xterm.h: Likewise.
915 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
916
1384b89e
JB
9172011-06-12 Juanma Barranquero <lekktu@gmail.com>
918
919 * makefile.w32-in: Update dependencies.
920 (LISP_H): Add lib/intprops.h.
921
1100a63c
CY
9222011-06-11 Chong Yidong <cyd@stupidchicken.com>
923
924 * image.c (gif_load): Add animation frame delay to the metadata.
925 (syms_of_image): Use DEFSYM. New symbol `delay'.
926
6198ccd0
MR
9272011-06-11 Martin Rudalics <rudalics@gmx.at>
928
929 * window.c (delete_deletable_window): Re-add.
930 (Fset_window_configuration): Rewrite to handle dead buffers and
931 consequently deletable windows.
932 (window_tree, Fwindow_tree): Remove. Supply functionality in
933 window.el.
934 (compare_window_configurations): Simplify code.
935
b6e3633c
AS
9362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
937
1ab0dee5
AS
938 * image.c (imagemagick_load_image): Fix type mismatch.
939 (Fimagemagick_types): Likewise.
940
b6e3633c
AS
941 * window.h (replace_buffer_in_windows): Declare.
942
9397e56f
MR
9432011-06-11 Martin Rudalics <rudalics@gmx.at>
944
945 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
946 Qclone_number. Remove external declaration of Qdelete_window.
947 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
948 code.
949 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
950 Qbuffer_list_update_hook if allowed.
951 (Fother_buffer): Rewrite doc-string. Major rewrite for new
952 buffer list implementation.
953 (other_buffer_safely): New function.
954 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
955 calls to replace_buffer_in_windows and
956 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
957 if allowed.
958 (record_buffer): Inhibit quitting and rewrite using quittable
959 functions. Run Qbuffer_list_update_hook if allowed.
960 (Frecord_buffer, Funrecord_buffer): New functions.
961 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
962 switch-to-buffer to window.el.
963 (bury-buffer): Move to window.el.
964 (Vbuffer_list_update_hook): New variable.
965
966 * lisp.h (other_buffer_safely): Add prototype in buffer.c
967 section.
968
969 * window.h (resize_frame_windows): Move up in code.
970 (Fwindow_frame): Remove EXFUN.
971 (replace_buffer_in_all_windows): Remove prototype.
972 (replace_buffer_in_windows_safely): Add prototype.
973
974 * window.c: Declare Qdelete_window static again. Move down
975 declaration of select_count.
976 (Fnext_window, Fprevious_window): Rewrite doc-strings.
977 (Fother_window): Move to window.el.
978 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
979 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
980 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
981 window.el.
982 (replace_buffer_in_windows): Implement by calling
983 Qreplace_buffer_in_windows.
984 (replace_buffer_in_all_windows): Remove with some functionality
985 moved into replace_buffer_in_windows_safely.
986 (replace_buffer_in_windows_safely): New function.
987 (select_window_norecord, select_frame_norecord): Move in front
988 of run_window_configuration_change_hook. Remove now obsolete
989 declarations.
990 (Fset_window_buffer): Rewrite doc-string. Call
991 Qrecord_window_buffer.
992 (keys_of_window): Move binding for other-window to window.el.
993
b50691aa
CY
9942011-06-11 Chong Yidong <cyd@stupidchicken.com>
995
996 * dispextern.h (struct image): Replace data member, whose int_val
997 and ptr_val fields were not used by anything, with a single
998 lisp_val object.
999
1000 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1001 (gif_clear_image, gif_load, imagemagick_load_image)
1002 (gs_clear_image, gs_load): Callers changed.
1003
3f754b86
PE
10042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1005
cca69397
PE
1006 * buffer.h: Include <time.h>, for time_t.
1007 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1008
109e28d0
PE
1009 Fix minor problems found by static checking.
1010
60737f02
PE
1011 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1012
4b66faf3
PE
1013 Make identifiers static if they are not used in other modules.
1014 * data.c (Qcompiled_function, Qframe, Qvector):
1015 * image.c (QimageMagick, Qsvg):
1016 * minibuf.c (Qmetadata):
1017 * window.c (resize_window_check, resize_root_window): Now static.
1018 * window.h (resize_window_check, resize_root_window): Remove decls.
1019
109e28d0
PE
1020 * window.c (window_deletion_count, delete_deletable_window):
1021 Remove; unused.
46a4ce9e
PE
1022 (window_body_lines): Now static.
1023 (Fdelete_other_windows_internal): Mark vars as initialized.
1024 Make sure 'resize_failed' is initialized.
1025 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1026 (resize_window_apply): Remove unused local.
1027 * window.h (delete_deletable_window): Remove decl.
1028
109e28d0 1029 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1030 (imagemagick_load_image): Fix pointer signedness problem by changing
1031 last arg from unsigned char * to char *. All uses changed.
1032 Also, fix a local for similar reasons.
1033 Remove unused locals. Remove locals to avoid shadowing.
1034 (fn_rsvg_handle_free): Remove; unused.
1035 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1036 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1037
3f754b86
PE
1038 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1039
2547adb1
CY
10402011-06-10 Chong Yidong <cyd@stupidchicken.com>
1041
1042 * image.c (gif_load): Fix omitted cast error introduced by
1043 2011-06-06 change.
1044
2c8e37d4
MR
10452011-06-10 Martin Rudalics <rudalics@gmx.at>
1046
1047 * window.h (resize_proportionally, orig_total_lines)
1048 (orig_top_line): Remove from window structure.
1049 (set_window_height, set_window_width, change_window_heights)
1050 (Fdelete_window): Remove prototypes.
1051 (resize_frame_windows): Remove duplicate declaration.
1052
440a42e3
EZ
10532011-06-10 Eli Zaretskii <eliz@gnu.org>
1054
1055 * window.h (resize_frame_windows, resize_window_check)
1056 (delete_deletable_window, resize_root_window)
1057 (resize_frame_windows): Declare prototypes.
1058
1059 * window.c (resize_window_apply): Make definition be "static" to
1060 match the prototype.
1061
562dd5e9
MR
10622011-06-10 Martin Rudalics <rudalics@gmx.at>
1063
1064 * window.c: Remove declarations of Qwindow_size_fixed,
1065 window_min_size_1, window_min_size_2, window_min_size,
1066 size_window, window_fixed_size_p, enlarge_window, delete_window.
1067 Remove static from declaration of Qdelete_window, it's
1068 temporarily needed by Fbury_buffer.
1069 (replace_window): Don't assign orig_top_line and
1070 orig_total_lines.
1071 (Fdelete_window, delete_window): Remove. Window deletion is
1072 handled by window.el.
1073 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1074 Fdelete_window calls with calls to Qdelete_window.
1075 (Fdelete_other_windows): Remove. Deleting other windows is
1076 handled by window.el.
1077 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1078 handled in window.el.
1079 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1080 Window minimum sizes are handled in window.el.
1081 (shrink_windows, size_window, set_window_height)
1082 (set_window_width, change_window_heights, window_height)
1083 (window_width, CURBEG, CURSIZE, enlarge_window)
1084 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1085 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1086 handled in window.el.
1087 (make_dummy_parent): Rename to make_parent_window and give it a
1088 second argument horflag.
1089 (make_window): Don't set resize_proportionally any more.
1090 (Fsplit_window): Remove. Windows are split in window.el.
1091 (save_restore_action, save_restore_orig_size)
1092 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1093 Resize mini windows in window.el.
1094 (grow_mini_window, shrink_mini_window): Implement by calling
1095 Qresize_root_window_vertically, resize_window_check and
1096 resize_window_apply.
1097 (saved_window, Fset_window_configuration, save_window_save): Do
1098 not handle orig_top_line, orig_total_lines, and
1099 resize_proportionally.
1100 (window_min_height, window_min_width): Move to window.el.
1101 (keys_of_window): Move bindings for delete-other-windows,
1102 split-window, delete-window and enlarge-window to window.el.
1103
1104 * buffer.c: Temporarily extern Qdelete_window.
1105 (Fbury_buffer): Temporarily call Qdelete_window instead of
1106 Fdelete_window (Fbury_buffer will move to window.el soon).
1107
1108 * frame.c (set_menu_bar_lines_1): Remove code handling
1109 orig_top_line and orig_total_lines.
1110
1111 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1112 set_window_height but set heights directly.
1113 (change_frame_size_1): Use resize_frame_windows.
1114
1115 * xdisp.c (init_xdisp): Don't use set_window_height but set
1116 heights directly.
1117
1118 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1119 resize_frame_windows instead of change_window_heights and run
1120 run_window_configuration_change_hook.
1121
1122 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1123 instead of change_window_heights and run
1124 run_window_configuration_change_hook.
1125
1a13852e
MR
11262011-06-09 Martin Rudalics <rudalics@gmx.at>
1127
1128 * window.c (replace_window): Rename second argument REPLACEMENT to
1129 NEW. New third argument SETFLAG. Rewrite.
1130 (delete_window, make_dummy_parent): Call replace_window with
1131 third argument 1.
1132 (window_list_1): Move down in code.
1133 (run_window_configuration_change_hook): Move set_buffer part
1134 before select_frame_norecord part in order to unwind correctly.
1135 Rename count1 to count.
1136 (recombine_windows, delete_deletable_window, resize_root_window)
1137 (Fdelete_other_windows_internal)
1138 (Frun_window_configuration_change_hook, make_parent_window)
1139 (resize_window_check, resize_window_apply, Fresize_window_apply)
1140 (resize_frame_windows, Fsplit_window_internal)
1141 (Fdelete_window_internal, Fresize_mini_window_internal): New
1142 functions.
1143 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1144
f3d1777e
MR
11452011-06-08 Martin Rudalics <rudalics@gmx.at>
1146
496e208e
MR
1147 * window.h (window): Add some new members to window structure -
1148 normal_lines, normal_cols, new_total, new_normal, clone_number,
1149 splits, nest, prev_buffers, next_buffers.
1150 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1151 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1152
f3d1777e
MR
1153 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1154 Remove.
496e208e
MR
1155 (make_dummy_parent): Set new members of windows structure.
1156 (make_window): Move down in code. Handle new members of window
1157 structure.
1158 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1159 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1160 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1161 (Fset_window_prev_buffers, Fwindow_next_buffers)
1162 (Fset_window_next_buffers, Fset_window_clone_number): New
1163 functions.
1164 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1165 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1166 Doc-string fixes.
1167 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1168 Argument WINDOW can be now internal window too.
1169 (Fwindow_use_time): Move up in code.
1170 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1171 Rewrite doc-string.
1172 (Fset_window_configuration, saved_window)
1173 (Fcurrent_window_configuration, save_window_save): Handle new
1174 members of window structure.
b9e809c2
MR
1175 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1176 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1177 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1178 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1179 Qget_mru_window, Qresize_root_window,
1180 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1181 Qauto_buffer_name; staticpro them.
f3d1777e 1182
abde8f8c
MR
11832011-06-07 Martin Rudalics <rudalics@gmx.at>
1184
1185 * window.c (Fwindow_total_size, Fwindow_left_column)
1186 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1187 (Fwindow_list_1): New functions.
1188 (window_box_text_cols): Replace with window_body_cols.
1189 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1190 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1191 (delete_window, Fset_window_configuration): Call
1192 delete_all_subwindows with window as argument.
1193 (delete_all_subwindows): Take a window as argument and not a
1194 structure. Rewrite.
190b47e6
MR
1195 (window_loop): Remove handling of GET_LRU_WINDOW and
1196 GET_LARGEST_WINDOW.
1197 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1198
1199 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1200 window_box_text_cols. delete_all_subwindows now takes a
1201 Lisp_Object as argument.
abde8f8c
MR
1202
1203 * indent.c (compute_motion, Fcompute_motion): Use
1204 window_body_cols instead of window_box_text_cols.
1205
fa8a67e6
MR
1206 * frame.c (delete_frame): Call delete_all_subwindows with root
1207 window as argument.
1208
a54e3482
DC
12092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1210
1211 * fns.c (Fputhash): Document return value.
1212
60002bf5
CY
12132011-06-06 Chong Yidong <cyd@stupidchicken.com>
1214
1215 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1216
0c671da6 12172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1218
b862a52a 1219 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1220
be44ca6c
PE
1221 Check for overflow when converting integer to cons and back.
1222 * charset.c (Fdefine_charset_internal, Fdecode_char):
1223 Use cons_to_unsigned to catch overflow.
1224 (Fencode_char): Use INTEGER_TO_CONS.
1225 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1226 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1227 * data.c (long_to_cons, cons_to_long): Remove.
1228 (cons_to_unsigned, cons_to_signed): New functions.
1229 These signal an error for invalid or out-of-range values.
1230 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1231 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1232 * font.c (Ffont_variation_glyphs):
1233 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1234 * lisp.h: Include <intprops.h>.
1235 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1236 (cons_to_signed, cons_to_unsigned): New decls.
1237 (long_to_cons, cons_to_long): Remove decls.
1238 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1239 (Fprimitive_undo): Use CONS_TO_INTEGER.
1240 * xfns.c (Fx_window_property): Likewise.
1241 * xselect.c: Include <limits.h>.
1242 (x_own_selection, selection_data_to_lisp_data):
1243 Use INTEGER_TO_CONS.
1244 (x_handle_selection_request, x_handle_selection_clear)
1245 (x_get_foreign_selection, Fx_disown_selection_internal)
1246 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1247 (lisp_data_to_selection_data): Use cons_to_unsigned.
1248 (x_fill_property_data): Use cons_to_signed.
1249 Report values out of range.
1250
d1f3d2af
PE
1251 Check for buffer and string overflow more precisely.
1252 * buffer.h (BUF_BYTES_MAX): New macro.
1253 * lisp.h (STRING_BYTES_MAX): New macro.
1254 * alloc.c (Fmake_string):
1255 * character.c (string_escape_byte8):
1256 * coding.c (coding_alloc_by_realloc):
1257 * doprnt.c (doprnt):
1258 * editfns.c (Fformat):
1259 * eval.c (verror):
1260 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1261 since they may not be the same number.
1262 * editfns.c (Finsert_char):
1263 * fileio.c (Finsert_file_contents):
1264 Likewise for BUF_BYTES_MAX.
1265
dd52fcea
PE
1266 * image.c: Use ptrdiff_t, not int, for sizes.
1267 (slurp_file): Switch from int to ptrdiff_t.
1268 All uses changed.
1269 (slurp_file): Check that file size fits in both size_t (for
1270 malloc) and ptrdiff_t (for sanity and safety).
1271
7f9bbdbb
PE
1272 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1273 if b->modtime has its maximal value.
1274
dfe18f82
PE
1275 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1276
84acfcf0
PE
1277 Don't assume time_t can fit into int.
1278 * buffer.h (struct buffer.modtime): Now time_t, not int.
1279 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1280 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1281
ccd9a01a
PE
1282 Minor fixes for signed vs unsigned integers.
1283 * character.h (MAYBE_UNIFY_CHAR):
1284 * charset.c (maybe_unify_char):
1285 * keyboard.c (read_char, reorder_modifiers):
1286 XINT -> XFASTINT, since the integer must be nonnegative.
1287 * ftfont.c (ftfont_spec_pattern):
1288 * keymap.c (access_keymap, silly_event_symbol_error):
1289 XUINT -> XFASTINT, since the integer must be nonnegative.
1290 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1291 since it makes no difference and we prefer signed.
1292 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1293 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1294 nonnegative.
1295
d6d100dd
SM
12962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1297
1298 * window.h (Fwindow_frame): Declare.
1299
2b6148e4
PE
13002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1303 (SPARE_MEMORY): Always define.
1304 (LARGE_REQUEST): Remove.
1305 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1306
f230ecc9
MR
13072011-06-06 Martin Rudalics <rudalics@gmx.at>
1308
727e958e
MR
1309 * lisp.h: Move EXFUNS for Fframe_root_window,
1310 Fframe_first_window and Fset_frame_selected_window to window.h.
1311
1312 * window.h: Move EXFUNS for Fframe_root_window,
1313 Fframe_first_window and Fset_frame_selected_window here from
1314 lisp.h.
1315
1316 * frame.c (Fwindow_frame, Fframe_first_window)
1317 (Fframe_root_window, Fframe_selected_window)
1318 (Fset_frame_selected_window): Move to window.c.
1319 (Factive_minibuffer_window): Move to minibuf.c.
1320 (Fother_visible_frames_p): New function.
1321
1322 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1323
f230ecc9
MR
1324 * window.c (decode_window, decode_any_window): Move up in code.
1325 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1326 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1327 (Fwindow_buffer): Move up and rewrite doc-string.
1328 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1329 (Fwindow_prev): New functions.
727e958e
MR
1330 (Fwindow_frame): Move here from frame.c. Accept any window as
1331 argument.
1332 (Fframe_root_window, Fframe_first_window)
1333 (Fframe_selected_window): Move here from frame.c. Accept frame
1334 or arbitrary window as argument. Update doc-strings.
1335 (Fminibuffer_window): Move up in code.
1336 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1337 (Fset_frame_selected_window): Move here from frame.c.
1338 Marginal rewrite.
727e958e
MR
1339 (Fselected_window, select_window, Fselect_window): Move up in
1340 code. Minor doc-string fixes.
f230ecc9 1341
4d09bcf6
PE
13422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1345 Do not assume that spare memory exists; that assumption is valid
1346 only if SYSTEM_MALLOC.
1347 (LARGE_REQUEST): New macro, so that the issue of large requests
1348 is separated from the issue of spare memory.
1349
810928a2
AS
13502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1351
172418ad
AS
1352 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1353 format. (Bug#8806)
1354
43f862f7
AS
1355 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1356
810928a2
AS
1357 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1358 before statements.
1359
a059fe24
JD
13602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1361
1362 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1363
1364 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1365
1366 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1367 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1368
989bf368
JB
13692011-06-05 Juanma Barranquero <lekktu@gmail.com>
1370
1371 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1372
4b80f674
CY
13732011-06-04 Chong Yidong <cyd@stupidchicken.com>
1374
1375 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1376 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1377 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1378 New error handlers.
4b80f674
CY
1379 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1380 Obey Vx_select_enable_clipboard_manager. Catch errors in
1381 x_clipboard_manager_save (Bug#8779).
1382 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1383 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1384
99a33b77 13852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1386
1387 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1388
99a33b77 13892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1390
1391 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1392 in the current matrix if keep_current_p is non-zero.
1393
8264569d
EZ
13942011-06-04 Eli Zaretskii <eliz@gnu.org>
1395
1396 * bidi.c (bidi_level_of_next_char): Fix last change.
1397
57f97249
EZ
13982011-06-03 Eli Zaretskii <eliz@gnu.org>
1399
fec2107c 1400 Support bidi reordering of text covered by display properties.
57f97249 1401
fec2107c
EZ
1402 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1403 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1404 (bidi_cache_search, bidi_cache_iterator_state)
1405 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1406 (bidi_level_of_next_char, bidi_move_to_visually_next):
1407 Support character positions inside a run of characters covered by a
fec2107c
EZ
1408 display string.
1409 (bidi_paragraph_init, bidi_resolve_explicit_1)
1410 (bidi_level_of_next_char): Call bidi_fetch_char and
1411 bidi_fetch_char_advance instead of FETCH_CHAR and
1412 FETCH_CHAR_ADVANCE.
1413 (bidi_init_it): Initialize new members.
1414 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1415 definitions.
1416 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1417 instead of using explicit *_CHAR codes.
d6d100dd
SM
1418 (bidi_resolve_explicit, bidi_resolve_weak):
1419 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1420 bidirectional text is supported only in multibyte buffers.
1421 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1422 it to initialize the frame_window_p member of struct bidi_it.
1423 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1424 (bidi_resolve_explicit, bidi_resolve_weak)
1425 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1426 bidi_it->nchars is non-positive.
1427 (bidi_level_of_next_char): Don't try to lookup the cache for the
1428 next/previous character if nothing is cached there yet, or if we
1429 were just reseat()'ed to a new position.
c40e2fb2 1430
0e14fe90
EZ
1431 * xdisp.c (set_cursor_from_row): Set start and stop points
1432 according to the row's direction when priming the loop that looks
1433 for the glyph on which to display cursor.
1434 (single_display_spec_intangible_p): Function deleted.
1435 (display_prop_intangible_p): Reimplement to call
1436 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1437 Accept 3 additional arguments needed by handle_display_spec.
1438 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1439 values: lists, `(when COND...)' forms, etc.
1440 (single_display_spec_string_p): Support property values that are
1441 lists with the argument STRING its top-level element.
1442 (display_prop_string_p): Fix the condition for processing a
1443 property that is a list to be consistent with handle_display_spec.
fec2107c 1444 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1445 last portion of handle_display_prop.
1446 (compute_display_string_pos): Accept additional argument
1447 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1448 value of a `display' property is a "replacing spec".
1449 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1450 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1451 the display property, but just return a value indicating whether
1452 the display property will replace the characters it covers.
1453 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1454 frame_window_p members of struct bidi_it.
d6d100dd
SM
1455 (compute_display_string_pos, compute_display_string_end):
1456 New functions.
fec2107c
EZ
1457 (push_it): Accept second argument POSITION, where pop_it should
1458 jump to continue iteration.
1459 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1460
fec2107c
EZ
1461 * keyboard.c (adjust_point_for_property): Adjust the call to
1462 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1463
1464 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1465 (bidi_init_it): Update prototypes.
1466 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1467 (compute_display_string_pos, compute_display_string_end):
1468 Declare prototypes.
fec2107c
EZ
1469 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1470 EMACS_INT.
fc6f18ce 1471
40087514 14722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1473
57f53182
PE
1474 Malloc failure behavior now depends on size of allocation.
1475 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1476 * lisp.h: Change signatures accordingly.
1477 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1478 All callers changed. (Bug#8762)
1479
1480 * gnutls.c: Use Emacs's memory allocators.
1481 Without this change, the gnutls library would invoke malloc etc.
1482 directly, which causes problems on non-SYNC_INPUT hosts, and which
1483 runs afoul of improving memory_full behavior. (Bug#8761)
1484 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1485 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1486 xfree instead of the default malloc, realloc, free.
1487 (Fgnutls_boot): No need to check for memory allocation failure,
1488 since xmalloc does that for us.
1489
ac32cd99 1490 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1491 * category.c (hash_get_category_set):
1492 * ccl.c (ccl_driver):
1493 * charset.c (Fdefine_charset_internal):
1494 * charset.h (struct charset.hash_index):
1495 * composite.c (get_composition_id, gstring_lookup_cache)
1496 (composition_gstring_put_cache):
1497 * composite.h (struct composition.hash_index):
1498 * dispextern.h (struct image.hash):
1499 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1500 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1501 (hashfn_equal, hashfn_user_defined, make_hash_table)
1502 (maybe_resize_hash_table, hash_lookup, hash_put)
1503 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1504 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1505 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1506 * image.c (make_image, search_image_cache, lookup_image)
1507 (xpm_put_color_table_h):
1508 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1509 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1510 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1511 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1512 * alloc.c (allocate_vectorlike):
1513 Check for overflow in vector size calculations.
1514 * ccl.c (ccl_driver):
1515 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1516 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1517 need to be updated by these changes.
40087514
PE
1518 * fns.c (make_hash_table, maybe_resize_hash_table):
1519 Check for integer overflow with large hash tables.
0de4bb68
PE
1520 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1521 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1522 (SXHASH_REDUCE): New macro.
1523 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1524 Use it instead of discarding useful hash info with large hash values.
1525 (sxhash_float): New function.
1526 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1527 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1528 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1529 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1530 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1531 Adjust signatures to match updated version of code.
1532 (consing_since_gc): Now EMACS_INT, since a single hash table can
1533 use more than INT_MAX bytes.
1534
698d32e2
DN
15352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1536
1537 Make it possible to build with GCC-4.6+ -O2 -flto.
1538
1539 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1540
fd6fa53f
SM
15412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1542
1543 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1544 Call minibuffer-inactive-mode.
1545
864db017
JB
15462011-05-31 Juanma Barranquero <lekktu@gmail.com>
1547
1548 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1549 Update dependencies.
1550
2ad0baf4
DN
15512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1552
1553 * data.c (init_data): Remove code for UTS, this system is not
1554 supported anymore.
1555
4fcc2638
DN
15562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1557
1558 Don't force ./temacs to start in terminal mode.
1559
1560 * frame.c (make_initial_frame): Initialize faces in all cases, not
1561 only when CANNOT_DUMP is defined.
1562 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1563
c56e0fd5
DN
15642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1565
1566 * dispnew.c (add_window_display_history): Use const for the string
1567 pointer. Remove declaration, not needed.
1568
333d54da 15692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1570
55d4c1b2 1571 Use 'inline', not 'INLINE'.
333d54da 1572 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1573 * alloc.c, fontset.c (INLINE): Remove.
1574 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1575 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1576 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1577 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1578 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1579
738db178
DN
15802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1581
1582 Make it possible to run ./temacs.
1583
1584 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1585 syms_of_callproc does the same thing. Remove test for
1586 "initialized", do it in the caller.
1587 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1588
620c53a6
SM
15892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1590
1591 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1592 (read_minibuf): Use get_minibuffer.
1593 (syms_of_minibuf): Use DEFSYM.
1594 (Qmetadata): New var.
1595 * data.c (Qbuffer): Don't make it static.
1596 (syms_of_data): Use DEFSYM.
1597
e003a292
PE
15982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1601 (CCL_CODE_MIN): New macro.
1602
ed008a6d
PE
16032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1604
3687c2ef
PE
1605 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1606
ed008a6d
PE
1607 * eval.c (Qdebug): Now static.
1608 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1609 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1610 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1611
d66c4c7c
CY
16122011-05-29 Chong Yidong <cyd@stupidchicken.com>
1613
1614 * image.c: Various fixes to ImageMagick code comments.
1615 (Fimagemagick_types): Doc fix.
1616
5fbc2025
PE
16172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1618
0196f88a
PE
1619 Minor fixes prompted by GCC 4.6.0 warnings.
1620
1621 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1622
5fbc2025
PE
1623 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1624 (x_clipboard_manager_save_all): Move extern decl to ...
1625 * xterm.h: ... here, so that it can be checked for consistency.
1626
1dd3c2d9
CY
16272011-05-29 Chong Yidong <cyd@stupidchicken.com>
1628
1629 * xselect.c (x_clipboard_manager_save_frame)
1630 (x_clipboard_manager_save_all): New functions.
1631 (Fx_clipboard_manager_save): Lisp function deleted.
1632
1633 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1634 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1635
1636 * xterm.h: Update prototype.
1637
5ba6571d
WX
16382011-05-28 William Xu <william.xwl@gmail.com>
1639
1640 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1641 exiting (Bug#8239).
1642
3eaff834
JM
16432011-05-28 Jim Meyering <meyering@redhat.com>
1644
e1900994 1645 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1646 * fns.c (to_uchar): Define.
1647 (crypto_hash_function): Use it to convert some newly-signed
1648 variables to unsigned, to avoid sign-extension bugs. For example,
1649 without this change, (md5 "truc") would evaluate to
1650 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1651 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1652 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1653
0f6990a7
PE
16542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1655
1656 Integer overflow fixes.
c8a9ca5a 1657
08686060
PE
1658 * dbusbind.c: Serial number integer overflow fixes.
1659 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1660 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1661 to hold a serial number that is too large for a fixnum.
1662 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1663 Check for serial numbers out of range. Decode any serial number
59568bf0 1664 that was so large that it became a float. (Bug#8722)
08686060 1665
2d1fc3c7
PE
1666 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1667 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1668 Use XFASTINT rather than XUINT when numbers are nonnegative.
1669 (xd_append_arg, Fdbus_method_return_internal):
1670 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1671 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1672 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1673 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1674 (Bug#8722)
2d1fc3c7 1675
c8a9ca5a
PE
1676 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1677
519e1d69
PE
1678 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1679
30569699
PE
1680 ccl: add integer overflow checks
1681 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1682 (IN_INT_RANGE): New macros.
1683 (ccl_driver): Use them to check for integer overflow when
1684 decoding a CCL program. Many of the new checks are whether XINT (x)
1685 fits in int; it doesn't always, on 64-bit hosts. The new version
1686 doesn't catch all possible integer overflows, but it's an
847044ea 1687 improvement. (Bug#8719)
30569699 1688
c11285dc
PE
1689 * alloc.c (make_event_array): Use XINT, not XUINT.
1690 There's no need for unsigned here.
1691
fdccd48e
PE
1692 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1693 This follows up to the 2011-05-06 change that substituted uintptr_t
1694 for EMACS_INT. This case wasn't caught back then.
1695
37910ab2
PE
1696 Rework Fformat to avoid integer overflow issues.
1697 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1698 now (part of C89). Include <verify.h>.
1699 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1700 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1701 (Fformat): Avoid the prepass trying to compute sizes; it was only
1702 approximate and thus did not catch overflow reliably. Instead, walk
1703 through the format just once, formatting and computing sizes as we go,
1704 checking for integer overflow at every step, and allocating a larger
1705 buffer as needed. Keep track separately whether the format is
1706 multibyte. Keep only the most-recently calculated precision, rather
1707 than them all. Record whether each argument has been converted to
1708 string. Use EMACS_INT, not int, for byte and char and arg counts.
1709 Support field widths and precisions larger than INT_MAX. Avoid
1710 sprintf's undefined behavior with conversion specifications such as %#d
1711 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1712 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1713 formatting out-of-range floating point numbers with int
1714 formats. (Bug#8668)
1715
2e6578fb
PE
1716 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1717
0ae6bdee
PE
1718 * data.c: Avoid integer truncation in expressions involving floats.
1719 * data.c: Include <intprops.h>.
1720 (arith_driver): When there's an integer overflow in an expression
1721 involving floating point, convert the integers to floating point
1722 so that the resulting value does not suffer from catastrophic
1723 integer truncation. For example, on a 64-bit host (* 4
1724 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1725 Do not rely on undefined behavior after integer overflow.
1726
de883a70
PE
1727 merge count_size_as_multibyte, parse_str_to_multibyte
1728 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1729 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1730 Check for integer overflow.
1731 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1732 since it's now a duplicate of the other. This is more of
1733 a character than a buffer op, so better that it's in character.c.
1734 * fns.c, print.c: Adjust to above changes.
1735
2ff916cb
PE
17362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1739
f1b54466
PE
17402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1741
fb1ac845
PE
1742 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1743 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1744 (x_clipboard_manager_save): Now static.
1745 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1746
f1b54466
PE
1747 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1748 (crypto_hash_function): Now static.
1749 Fix pointer signedness problems. Avoid unnecessary initializations.
1750
a9f737ee
CY
17512011-05-27 Chong Yidong <cyd@stupidchicken.com>
1752
1753 * termhooks.h (Vselection_alist): Make it terminal-local.
1754
1755 * terminal.c (create_terminal): Initialize it.
1756
1757 * xselect.c: Support for clipboard managers.
1758 (Vselection_alist): Move to termhooks.h as terminal-local var.
1759 (LOCAL_SELECTION): New macro.
1760 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1761 (symbol_to_x_atom): Remove gratuitous arg.
1762 (x_handle_selection_request, lisp_data_to_selection_data)
1763 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1764 (x_own_selection, x_get_local_selection, x_convert_selection):
1765 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1766 (some_frame_on_display): Delete unused function.
1767 (Fx_own_selection_internal, Fx_get_selection_internal)
1768 (Fx_disown_selection_internal, Fx_selection_owner_p)
1769 (Fx_selection_exists_p): New optional frame arg.
1770 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1771 (x_handle_selection_clear): Don't treat other terminals with the
1772 same keyboard specially. Use the terminal-local Vselection_alist.
1773 (x_clear_frame_selections): Use Frun_hook_with_args.
1774
1775 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1776
1777 * xterm.h: Add support for those atoms.
1778
e067f0c1
CY
17792011-05-26 Chong Yidong <cyd@stupidchicken.com>
1780
1781 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1782 (converted_selections, conversion_fail_tag): New global variables.
1783 (x_selection_request_lisp_error): Free the above.
1784 (x_get_local_selection): Remove unnecessary code.
1785 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1786 of converted selections stored in converted_selections.
1787 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1788 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1789 (x_convert_selection): New function.
1790 (x_handle_selection_event): Simplify.
1791 (x_get_foreign_selection): Don't ignore incoming requests while
1792 waiting for an answer; this will fail when we implement
1793 SAVE_TARGETS, and seems unnecessary anyway.
1794 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1795 (Vx_sent_selection_functions): Doc fix.
1796
0f4aebc0
LL
17972011-05-26 Leo Liu <sdl.web@gmail.com>
1798
1799 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1800
e61124cd
YM
18012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1802
1803 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1804
1805 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1806 for fringe update if it has periodic bitmap.
1807 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1808 and fringe_bitmap_periodic_p.
1809
1810 * fringe.c (get_fringe_bitmap_data): New function.
1811 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1812 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1813 row. Mark glyph row for fringe update if periodicity changed.
1814
1815 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1816 for fringe update unless it has periodic bitmap.
1817
f16d9837
KH
18182011-05-25 Kenichi Handa <handa@m17n.org>
1819
1820 * xdisp.c (get_next_display_element): Set correct it->face_id for
1821 a static composition.
1822
e1b90ef6
LL
18232011-05-24 Leo Liu <sdl.web@gmail.com>
1824
1825 * deps.mk (fns.o):
1826 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1827
1828 * fns.c (crypto_hash_function, Fsha1): New function.
1829 (Fmd5): Use crypto_hash_function.
1830 (syms_of_fns): Add Ssha1.
1831
7400048f
PE
18322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1833
1834 * gnutls.c: Remove unused macros.
1835 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1836 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1837 Remove macros that are defined and never used.
1838 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1839
abb71cf4
CY
18402011-05-22 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1843 (Fx_get_selection_internal): Minor cleanup.
1844 (Fx_own_selection_internal): Rename arguments for consistency with
1845 select.el.
1846
6307db39
PE
18472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1850
f3d4e0a4
CY
18512011-05-22 Chong Yidong <cyd@stupidchicken.com>
1852
1853 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1854
4d8ade89
YM
18552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1856
1857 * dispnew.c (scrolling_window): Don't exclude the case that the
1858 last enabled row in the desired matrix touches the bottom boundary.
1859
32078c8d
GM
18602011-05-21 Glenn Morris <rgm@gnu.org>
1861
1862 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1863 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1864 and add some more files.
32078c8d 1865
7285dc67
EZ
18662011-05-20 Eli Zaretskii <eliz@gnu.org>
1867
1868 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1869 report_file_error introduced by the change from 2011-05-07.
1870
89d1bd22
PE
18712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * systime.h (Time): Define only if emacs is defined.
1874 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1875 where the include path doesn't have X11/X.h by default. See
1876 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1877
e23640bb 18782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1879
1880 * composite.c (find_automatic_composition): Fix previous change.
1881
b9704ad9
GM
18822011-05-20 Glenn Morris <rgm@gnu.org>
1883
1884 * lisp.mk: New file, split from Makefile.in.
1885 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1886 (shortlisp): Remove.
1887 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1888
4a720484
GM
18892011-05-19 Glenn Morris <rgm@gnu.org>
1890
1891 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1892 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1893 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1894 (lisp): Set the order to that of loadup.el.
1895 (shortlisp): Make it a copy of $lisp.
1896 (SOME_MACHINE_LISP): Remove.
1897 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1898 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1899
a28d4396
KH
19002011-05-18 Kenichi Handa <handa@m17n.org>
1901
1902 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1903 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1904 (find_automatic_composition): Mostly rewrite for efficiency.
1905
a2b1fa8e
JB
19062011-05-18 Juanma Barranquero <lekktu@gmail.com>
1907
1908 * makefile.w32-in: Update dependencies.
1909
8e1f5610
CS
19102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1911
1912 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1913 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1914
7025ee00 19152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1916
cdfa6eab
PE
1917 Fix some integer overflow issues, such as string length overflow.
1918
06d6db33
PE
1919 * insdel.c (count_size_as_multibyte): Check for string overflow.
1920
2b4560a8
PE
1921 * character.c (lisp_string_width): Check for string overflow.
1922 Use EMACS_INT, not int, for string indexes and lengths; in
1923 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1924 the resulting string length overflows an EMACS_INT; instead,
1925 report a string overflow if no precision given. When checking for
1926 precision exhaustion, use a check that cannot possibly have
1927 integer overflow. (Bug#8675)
1928 * character.h (lisp_string_width): Adjust to new signature.
1929
cb93f9be
PE
1930 * alloc.c (string_overflow): New function.
1931 (Fmake_string): Use it. This doesn't change behavior, but saves
1932 a few bytes and will simplify future changes.
1933 * character.c (string_escape_byte8): Likewise.
1934 * lisp.h (string_overflow): New decl.
1935
1a1f3366
PE
1936 Fixups, following up to the user-interface timestamp change.
1937 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1938 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1939 * msdos.c (mouse_get_pos): Likewise.
1940 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1941 * w32gui.h (Time): Define by including "systime.h" rather than by
1942 declaring it ourselves. (Bug#8664)
1943
d4e3e4d3
PE
1944 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1945 * image.c (clear_image_cache): Likewise.
1946
f6a24d19
PE
1947 * term.c (term_mouse_position): Don't assume time_t wraparound.
1948
08dc5ae6
PE
1949 Be more systematic about user-interface timestamps.
1950 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1951 and sometimes 'EMACS_UINT', to represent these timestamps.
1952 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1953 This makes the code easier to follow, and makes it easier to catch
1954 integer overflow bugs such as Bug#8664.
1955 * frame.c (Fmouse_position, Fmouse_pixel_position):
1956 Use Time, not unsigned long, for user-interface timestamps.
1957 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1958 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1959 * keyboard.h (last_event_timestamp): Likewise.
1960 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1961 * menu.h (xmenu_show): Likewise.
1962 * term.c (term_mouse_position): Likewise.
1963 * termhooks.h (struct input_event.timestamp): Likewise.
1964 (struct terminal.mouse_position_hook): Likewise.
1965 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1966 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1967 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1968 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1969 what it was before.
1970 * menu.h, termhooks.h: Include "systime.h", for Time.
1971
8e55734a
PE
1972 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1973 Don't assume that the difference between two unsigned long values
1974 can fit into an integer. At this point, we know button_down_time
1975 <= event->timestamp, so the difference must be nonnegative, so
1976 there's no need to cast the result if double-click-time is
1977 nonnegative, as it should be; check that it's nonnegative, just in
1978 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1979 apart (about 25 days). (Bug#8664)
8e55734a 1980
841f1b75 1981 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1982 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1983
3e26f69c
PE
1984 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1985 that always fit in int. Use a sentinel instead of a counter, to
1986 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1987 * frame.h (struct frame): Use int for menu_bar_items_used
1988 instead of EMACS_INT, since it always fits in int.
3e26f69c 1989
5cc152c0
PE
1990 * menu.c (grow_menu_items): Check for int overflow.
1991
d89eb65e
PE
1992 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1993
5235bd3e
PE
1994 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1995 Before, the code was not consistent. These values cannot exceed
1996 2**31 - 1 so there's no need to make them unsigned.
1997 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1998 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1999 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2000 as modifiers.
2001 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2002
bc827e23
PE
2003 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2004 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2005 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2006 presumably because the widths might not match.
2007
78eb494e
PE
2008 * window.c (size_window): Avoid needless test at loop start.
2009
04f2d78b
CB
20102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2011
2012 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2013
d2fc7e3d 20142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2015
2016 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2017
d2fc7e3d 20182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2019
2020 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2021 `width' to `bar_area_x' and `bar_area_width', respectively.
2022 (x_scroll_run): Take account of fringe background extension.
2023
04f2d78b
CB
2024 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2025 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2026 `bar_area_width', respectively.
2027 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2028 background extension.
2029
79b70037
GM
20302011-05-10 Jim Meyering <meyering@redhat.com>
2031
2032 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2033
2f142cc5
JB
20342011-05-10 Juanma Barranquero <lekktu@gmail.com>
2035
2036 * image.c (Finit_image_library): Return t for built-in image types,
2037 like pbm and xbm. (Bug#8640)
2038
57679c86
AS
20392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2040
2041 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2042
888c9e86
EZ
20432011-05-07 Eli Zaretskii <eliz@gnu.org>
2044
b0512a1d
EZ
2045 * w32console.c (Fset_screen_color): Doc fix.
2046 (Fget_screen_color): New function.
2047 (syms_of_ntterm): Defsubr it.
2048
7285dc67
EZ
2049 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2050 unlink the temporary file if Fcall_process didn't create it in the
2051 first place.
2052 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2053 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2054 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2055 cue to call_process_cleanup not to close that handle.
2056
4d3fcc8e
BK
20572011-05-07 Ben Key <bkey76@gmail.com>
2058
2059 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2060 one of two shell specific rules, either bootstrap-temacs-CMD or
2061 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2062 to the previous implementation of the bootstrap-temacs rule.
2063 The bootstrap-temacs-CMD rule is similar to the previous
2064 implementation of the bootstrap-temacs rule except that it
2065 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2066 variable.
2067
2068 These changes, along with some changes to nt/configure.bat,
2069 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2070 earlier fix to add support for --cflags and --ldflags options
2071 that include quotes so that it works whether make uses cmd or
2072 sh as the shell.
2073
b4289b64
MA
20742011-05-06 Michael Albinus <michael.albinus@gmx.de>
2075
2076 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2077 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2078 is a constant.
2079 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2080 a string. Handle both cases.
2081 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2082 (Fdbus_register_method): Use Qinvalid_function.
2083
af4c0e28
JB
20842011-05-06 Juanma Barranquero <lekktu@gmail.com>
2085
2086 * makefile.w32-in: Update dependencies.
2087 (LISP_H): Add inttypes.h and stdin.h.
2088 (PROCESS_H): Add unistd.h.
2089
c51453d9
EZ
20902011-05-06 Eli Zaretskii <eliz@gnu.org>
2091
2092 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2093 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2094
8ff0ac3c 20952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2096
4c4b566b
PE
2097 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2098
aab2b9b5
PE
2099 * term.c (vfatal): Remove stray call to va_end.
2100 It's not needed and the C Standard doesn't allow it here anyway.
2101
c378da0b
PE
2102 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2103 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2104
288b08c7
PE
2105 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2106 bytes.
2107
e3601888
PE
2108 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2109
db6c0e74
PE
2110 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2111
dd5963ea
PE
2112 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2113
88c9450f
PE
2114 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2115
2f9442b8
PE
2116 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2117
c032b5f8
PE
2118 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2119 * charset.c (Fdefine_charset_internal): Don't initialize
2120 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2121 32-bit int (Bug#8600).
a108c10b
PE
2122
2123 * lread.c (read_integer): Be more consistent with string-to-number.
2124 Use string_to_number to do the actual conversion; this avoids
2125 rounding errors and fixes some other screwups. Without this fix,
2126 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2127 (digit_to_number): Move earlier, for benefit of read_integer.
2128 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2129 not a digit in any supported base. (Bug#8602)
a108c10b 2130
ad5f9eea
PE
2131 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2132
aec1708a
PE
2133 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2134 to match comment at start of function. This also removes a
2135 GCC warning about overflow in a 32+64-bit port.
2136
47be4ab5
PE
2137 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2138
371cac43
PE
2139 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2140 Reported by Stefan Monnier in
2141 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2142 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2143 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2144
d01a7826
PE
2145 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2146 (EMACS_UINTPTR): Likewise, with uintptr_t.
2147
7fd47d5c
PE
2148 * lisp.h: Prefer 64-bit EMACS_INT if available.
2149 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2150 on 32-bit hosts that have 64-bit int, so that they can access
2151 large files.
122b0c86
PE
2152 However, temporarily disable this change unless the temporary
2153 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2154
8727937b
PE
2155 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2156
8ac068ac
PE
2157 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2158 This removes an assumption that EMACS_INT and long are the same
2159 width as pointers. The assumption is true for Emacs porting targets
2160 now, but we want to make other targets possible.
2161 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2162 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2163 In the rest of the code, change types of integers that hold casted
2164 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2165 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2166 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2167 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2168 No need to cast type when ORing.
2169 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2170 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2171 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2172 assume EMACS_INT is the same width as char *.
2173 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2174 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2175 Remove no-longer-needed casts.
2176 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2177 (xg_tool_bar_help_callback, xg_make_tool_item):
2178 Use EMACS_INTPTR to hold an integer
2179 that will be cast to void *; this can avoid a GCC warning
2180 if EMACS_INT is not the same width as void *.
2181 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2182 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2183 (current_message_1, set_message_1):
2184 Use a local to convert to proper width without a cast.
2185 * xmenu.c (dialog_selection_callback): Likewise.
2186
ede49d71
PE
2187 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2188 Also, don't assume VALBITS / RAND_BITS is less than 5,
2189 and don't rely on undefined behavior when shifting a 1 left into
2190 the sign bit.
2191 * lisp.h (get_random): Change signature to match.
2192
2f30ecd0
PE
2193 * lread.c (hash_string): Use size_t, not int, for hash computation.
2194 Normally we prefer signed values; but hashing is special, because
2195 it's better to use unsigned division on hash table sizes so that
2196 the remainder is nonnegative. Also, size_t is the natural width
2197 for hashing into memory. The previous code used 'int', which doesn't
2198 retain enough info to hash well into very large tables.
2199 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2200
2a866e7b
PE
2201 * dbusbind.c: Don't possibly lose pointer info when converting.
2202 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2203 Use XPNTR rather than XHASH, so that the high-order bits of
2204 the pointer aren't lost when converting through void *.
2205
51639eac
PE
2206 * eval.c (Fautoload): Don't double-shift a pointer.
2207
92394119
PE
2208 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2209
dbdb9a7c
JB
22102011-05-06 Juanma Barranquero <lekktu@gmail.com>
2211
2212 * gnutls.c (DEF_GNUTLS_FN):
2213 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2214
db7a0b4f
AS
22152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2218 marker. (Bug#8610)
2219
f7ff1b0f 22202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2221
2222 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2223 New version that can reserve upto 2GB of heap space.
2224
f7ff1b0f 22252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2226
2227 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2228
639c109b
TZ
22292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2230
2231 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2232 `gnutls_certificate_set_x509_key_file'.
2233
d2127135
JB
22342011-05-05 Juanma Barranquero <lekktu@gmail.com>
2235
2236 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2237 Update dependencies.
2238
e968f4f3
JB
22392011-05-04 Juanma Barranquero <lekktu@gmail.com>
2240
2241 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2242 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2243 Remove unused parameter `fildes'.
2244 * process.c (read_process_output, send_process): Don't pass it.
2245
84d358f0
JB
22462011-05-04 Juanma Barranquero <lekktu@gmail.com>
2247
2248 Fix previous change: the library cache is defined in w32.c.
2249 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2250 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2251
0898ca10
JB
22522011-05-04 Juanma Barranquero <lekktu@gmail.com>
2253
2254 Implement dynamic loading of GnuTLS on Windows.
2255
2256 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2257 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2258 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2259 Declare.
2260
2261 * gnutls.c (Qgnutls_dll): Define.
2262 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2263 (gnutls_*): Declare function pointers.
2264 (init_gnutls_functions): New function to initialize function pointers.
2265 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2266 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2267 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2268 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2269 (emacs_gnutls_write, emacs_gnutls_read)
2270 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2271 (Fgnutls_available_p): New function.
2272 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2273 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2274 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2275
2276 * image.c: Include w32.h.
2277 (Vimage_type_cache): Delete.
2278 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2279 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2280 (w32_delayed_load): Move to w32.c.
2281
2282 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2283
2284 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2285 (w32_delayed_load): Move from image.c. When loading a library, record
2286 its filename in the :loaded-from property of the library id.
2287 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2288 Initialize and staticpro them.
2289 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2290
2291 * process.c: Include lisp.h before w32.h, not after.
2292 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2293 instead of gnutls_record_check_pending.
2294
2295 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2296
ff4de4aa
TZ
22972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2298
2299 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2300 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2301 as passed in.
2302
abe95abb
JD
23032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2304
2305 * xterm.c (x_set_frame_alpha): Do not set property on anything
2306 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2307
e16e55d4
JB
23082011-05-02 Juanma Barranquero <lekktu@gmail.com>
2309
2310 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2311
bafcf6a5
JB
23122011-05-02 Juanma Barranquero <lekktu@gmail.com>
2313
2314 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2315 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2316 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2317 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2318 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2319 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2320 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2321 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2322 (Qgnutls_bootprop_callbacks_verify): Make static.
2323
e7a6747f
AS
23242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2325
19ed11ba
AS
2326 * callproc.c: Indentation fixup.
2327
e7a6747f 2328 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2329 (wait_for_termination, interruptible_wait_for_termination):
2330 Move after wait_for_termination_1.
e7a6747f 2331
1ef14cb4
LMI
23322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2333
2334 * sysdep.c (interruptible_wait_for_termination): New function
2335 which is like wait_for_termination, but allows keyboard
2336 interruptions.
2337
2338 * callproc.c (Fcall_process): Add (:file "file") as an option for
2339 the STDOUT buffer.
2340 (Fcall_process_region): Ditto.
2341
330d880c
EZ
23422011-04-30 Eli Zaretskii <eliz@gnu.org>
2343
8db90b73
EZ
2344 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2345 rather than `XVECTOR (FOO)->size'.
2346
330d880c
EZ
2347 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2348 inttypes.h, as a gnulib replacement is used if it not available in
2349 system headers.
2350
15cbd324
EZ
23512011-04-21 Eli Zaretskii <eliz@gnu.org>
2352
2353 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2354 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2355 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2356
2357 * coding.c (coding_alloc_by_realloc): Error out if destination
2358 will grow beyond MOST_POSITIVE_FIXNUM.
2359 (decode_coding_emacs_mule): Abort if there isn't enough place in
2360 charbuf for the composition carryover bytes. Reserve an extra
2361 space for up to 2 characters produced in a loop.
2362 (decode_coding_iso_2022): Abort if there isn't enough place in
2363 charbuf for the composition carryover bytes.
2364
23652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2366
ae940cca
EZ
2367 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2368 aborting when %lld or %lll format is passed.
2369 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2370 %llo or %llx format is passed. (Bug#8545)
2371
03ab8921
EZ
2372 * window.c (window_scroll_line_based): Use a marker instead of
2373 simple variables to record original value of point. (Bug#7952)
2374
afda1437
EZ
2375 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2376 produced by %s or %c overflows available buffer space. (Bug#8545)
2377
f76dee0c
PE
23782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2381 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2382
fdc5744d
JB
23832011-04-28 Juanma Barranquero <lekktu@gmail.com>
2384
2385 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2386
638f053a
JB
23872011-04-28 Juanma Barranquero <lekktu@gmail.com>
2388
2389 * keyboard.c (Qdelayed_warnings_hook): Define.
2390 (command_loop_1): Run `delayed-warnings-hook'
2391 if Vdelayed_warnings_list is non-nil.
2392 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2393 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2394
d178f871
EZ
23952011-04-28 Eli Zaretskii <eliz@gnu.org>
2396
2397 * doprnt.c (doprnt): Don't return value smaller than the buffer
2398 size if the message was truncated. (Bug#8545).
2399
b124fd93
JB
24002011-04-28 Juanma Barranquero <lekktu@gmail.com>
2401
2402 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2403 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2404
e810457d
PE
24052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2406
2407 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2408
ea51cceb
JB
24092011-04-27 Juanma Barranquero <lekktu@gmail.com>
2410
2411 * makefile.w32-in: Update dependencies.
2412
94dcfacf
EZ
24132011-04-27 Eli Zaretskii <eliz@gnu.org>
2414
2415 Improve `doprnt' and its usage. (Bug#8545)
2416 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2417 `format_end'. Remove support for %l as a conversion specifier.
2418 Don't use xrealloc. Improve diagnostics when the %l size modifier
2419 is used. Update the commentary.
2420
2421 * eval.c (verror): Simplify calculation of size_t.
2422
2423 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2424 messages.
2425
f61f41d7
PE
24262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2427
2428 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2429 change.
2430
96fb4434
PE
24312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2434 This makes this file independent of the recent pseudovector change.
2435
671875da 24362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2437
69e9b5a3
PE
2438 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2439
b5f869a7 2440 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2441 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2442 Remove unused local.
c8926152 2443 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2444
841a1577 2445 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2446 GCC 4.6.0 optimizes based on type-based alias analysis.
2447 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2448 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2449 != &v->size, and therefore "v->size = 1; b->size = 2; return
2450 v->size;" must therefore return 1. This assumption is incorrect
2451 for Emacs, since it type-puns struct Lisp_Vector * with many other
2452 types. To fix this problem, this patch adds a new type struct
f904488f 2453 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2454 and pseudovectors, and helps optimizing compilers not get fooled
2455 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2456 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2457 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2458 the size member.
eab3844f
PE
2459 (XSETPVECTYPE): Rewrite in terms of new macro.
2460 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2461 This is a bit clearer, and further avoids the possibility of
2462 undesirable aliasing.
2463 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2464 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2465 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2466 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2467 (ASIZE): Now uses header.size rather than size.
2468 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2469 to avoid the hassle of writing XVECTOR (foo)->header.size.
2470 (struct vectorlike_header): New type.
eab3844f
PE
2471 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2472 object, to help avoid aliasing.
2473 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2474 (SUBRP): Likewise, since Lisp_Subr is a special case.
2475 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2476 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2477 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2478 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2479 changed to be "header.size" and "header.next".
2480 * buffer.h (struct buffer): Likewise.
2481 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2482 * frame.h (struct frame): Likewise.
2483 * process.h (struct Lisp_Process): Likewise.
2484 * termhooks.h (struct terminal): Likewise.
2485 * window.c (struct save_window_data, struct saved_window): Likewise.
2486 * window.h (struct window): Likewise.
2487 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2488 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2489 * buffer.c (init_buffer_once): Likewise.
2490 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2491 special case.
2492 * process.c (Fformat_network_address): Use local var for size,
2493 for brevity.
2494
0df1eac5
PE
2495 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2496
847ab9d1 2497 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2498 * data.c (atof): Remove decl; no longer used or needed.
2499 (digit_to_number): Move to lread.c.
2500 (Fstring_to_number): Use new string_to_number function, to be
2501 consistent with how the Lisp reader treats infinities and NaNs.
2502 Do not assume that floating-point numbers represent EMACS_INT
2503 without losing information; this is not true on most 64-bit hosts.
2504 Avoid double-rounding errors, by insisting on integers when
2505 parsing non-base-10 numbers, as the documentation specifies.
2506 * lisp.h (string_to_number): New decl, replacing ...
2507 (isfloat_string): Remove.
bc0a5c13 2508 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2509 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2510 appears to have been a coding error. Similarly, do not accept
2511 strings like +-1e0 as floating point numbers. Do not report
2512 overflow for integer overflows unless the base is not 10 which
2513 means we have no simple and reliable way to continue.
2514 Break out the floating-point parsing into a new
2515 function string_to_number, so that Fstring_to_number parses
2516 floating point numbers consistently with the Lisp reader.
04f2d78b 2517 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2518 (E_CHAR, EXP_INT): Remove, replacing with ...
2519 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2520 (string_to_number): New function, replacing isfloat_string.
2521 This function checks for valid syntax and produces the resulting
2522 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2523 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2524 so that overflow for non-base-10 numbers is reported only when
2525 there's no portable and simple way to convert to floating point.
452f4150 2526
67769ffc
PE
2527 * textprop.c (set_text_properties_1): Rewrite for clarity,
2528 and to avoid GCC warning about integer overflow.
2529
c20db43f
PE
2530 * intervals.h (struct interval): Use EMACS_INT for members
2531 where EMACS_UINT might cause problems. See
2532 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2533 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2534 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2535 All uses changed.
37aa2f85
PE
2536 (offset_intervals): Tell GCC not to worry about length overflow
2537 when negating a negative length.
c20db43f 2538
2538aa2f
PE
2539 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2540 (overrun_check_free): Likewise.
2541
f2d3008d
PE
2542 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2543 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2544 word size.
2545
ec8df744
PE
2546 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2547 (gnutls_make_error): Rename local to avoid shadowing.
2548 (gnutls_emacs_global_deinit): ifdef out; not used.
2549 (Fgnutls_boot): Use const for pointer to readonly storage.
2550 Comment out unused local. Fix pointer signedness problems.
2551
640ee02d
PE
2552 * lread.c (openp): Don't stuff size_t into an 'int'.
2553 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2554 about possible signed overflow.
2555
6048fb2a
PE
2556 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2557 (GDK_KEY_g): Don't define if already defined.
2558 (xg_prepare_tooltip): Avoid pointer signedness problem.
2559 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2560
fa3c87e1
PE
2561 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2562 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2563
2172544b
PE
2564 * xfns.c (Fx_window_property): Simplify a bit,
2565 to make a bit faster and to avoid GCC 4.6.0 warning.
2566 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2567
9b821a21
PE
2568 * fns.c (internal_equal): Don't assume size_t fits in int.
2569
3c616cfa
PE
2570 * alloc.c (compact_small_strings): Tighten assertion a little.
2571
c2982e87
PE
2572 Replace pEd with more-general pI, and fix some printf arg casts.
2573 * lisp.h (pI): New macro, generalizing old pEd macro to other
2574 conversion specifiers. For example, use "...%"pI"d..." rather
2575 than "...%"pEd"...".
2576 (pEd): Remove. All uses replaced with similar uses of pI.
2577 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2578 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2579 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2580 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2581 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2582 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2583 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2584 64-bit hosts.
2585 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2586 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2587 * print.c (safe_debug_print, print_object): Likewise.
2588 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2589 to int.
6f04d126
PE
2590 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2591 avoiding the 0 flag, which is not portable.
c2982e87
PE
2592 * process.c (Fmake_network_process): Use pI to avoid cast.
2593 * region-cache.c (pp_cache): Likewise.
2594 * xdisp.c (decode_mode_spec): Likewise.
2595 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2596 behavior on 64-bit hosts with printf arg.
6f04d126 2597 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2598 (x_stop_queuing_selection_requests): Likewise.
2599 (x_get_window_property): Don't truncate byte count to an 'int'
2600 when tracing.
0b432f21 2601
5e073ec7
PE
2602 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2603 here, since it parses constructs like leading '-' and spaces,
2604 which are not wanted; and it overflows with large numbers.
2605 Instead, simply match F[0-9]+, which is what is wanted anyway.
2606
36372bf9
PE
2607 * alloc.c: Remove unportable assumptions about struct layout.
2608 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2609 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2610 (allocate_vectorlike, make_pure_vector): Use the new macros,
2611 plus offsetof, to remove unportable assumptions about struct layout.
2612 These assumptions hold on all porting targets that I know of, but
2613 they are not guaranteed, they're easy to remove, and removing them
2614 makes further changes easier.
2615
0b432f21
PE
2616 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2617 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2618 (string_overrun_cookie): Now const. Use initializers that
2619 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2620 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2621 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2622 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2623 multiple of sizeof (EMACS_INT); it need not be, if
2624 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2625 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2626
895009e1
JB
26272011-04-26 Juanma Barranquero <lekktu@gmail.com>
2628
2629 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2630
6a7a1b0b
TZ
26312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2632
2633 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2634 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2635 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2636
841a1577 26372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2638
2639 * lisp.h (Qdebug): List symbol.
895009e1 2640 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2641 * keyboard.c (debug-on-event): New variable.
2642 (handle_user_signal): Break into debugger when debug-on-event
2643 matches the current signal symbol.
2644
f2d3ba6f
DN
26452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2646
2647 * alloc.c (check_sblock, check_string_bytes)
2648 (check_string_free_list): Convert to standard C.
2649
42ce4c63
TZ
26502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2651
2652 * w32.c (emacs_gnutls_push): Fix typo.
2653
825cd63c
EZ
26542011-04-25 Eli Zaretskii <eliz@gnu.org>
2655
fb11d64d
EZ
2656 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2657 "cast to pointer from integer of different size".
2658
825cd63c
EZ
2659 Improve doprnt and its use in verror. (Bug#8545)
2660 * doprnt.c (doprnt): Document the set of format control sequences
2661 supported by the function. Use SAFE_ALLOCA instead of always
2662 using `alloca'.
2663
2664 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2665 is one byte too soon. Don't use xrealloc; instead xfree and
2666 xmalloc anew.
2667
e061a11b
TZ
26682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2669
2670 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2671 callbacks stage.
2672
2673 * gnutls.c: Renamed global_initialized to
2674 gnutls_global_initialized. Added internals for the
2675 :verify-hostname-error, :verify-error, and :verify-flags
2676 parameters of `gnutls-boot' and documented those parameters in the
2677 docstring. Start callback support.
2678 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2679 unless a fatal error occured. Call gnutls_alert_send_appropriate
2680 on error. Return error code.
2681 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2682 (emacs_gnutls_read): Likewise.
2683 (Fgnutls_boot): Return handshake error code.
2684 (emacs_gnutls_handle_error): New function.
2685 (wsaerror_to_errno): Likewise.
2686
2687 * w32.h (emacs_gnutls_pull): Add prototype.
2688 (emacs_gnutls_push): Likewise.
2689
2690 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2691 (emacs_gnutls_push): Likewise.
2692
26932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2694
2695 * process.c (wait_reading_process_output): Check if GnuTLS
2696 buffered some data internally if no FDs are set for TLS
2697 connections.
2698
2699 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2700 (LIBS): Link to USER_LIBS.
2701 ($(BLD)/gnutls.$(0)): New target.
2702
fa6996bc
EZ
27032011-04-24 Eli Zaretskii <eliz@gnu.org>
2704
eb35682e
EZ
2705 * xdisp.c (handle_single_display_spec): Rename the
2706 display_replaced_before_p argument into display_replaced_p, to
2707 make it consistent with the commentary. Fix typos in the
2708 commentary.
2709
e2ad650c
EZ
2710 * textprop.c (syms_of_textprop): Remove dead code.
2711 (copy_text_properties): Delete obsolete commentary about an
2712 interface that was deleted long ago. Fix typos in the description
2713 of arguments.
2714
1b2de274
EZ
2715 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2716 to changes in oldXMenu/XMenu.h from 2011-04-16.
2717 <menu_help_message, prev_menu_help_message>: Constify.
2718 (IT_menu_make_room): menu->help_text is now `const char **';
2719 adjust.
2720
2721 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2722 to changes in oldXMenu/XMenu.h from 2011-04-16.
2723 (struct XMenu): Declare `help_text' `const char **'.
2724
2725 * xfaces.c <Qunspecified>: Make extern again.
2726
2727 * syntax.c: Include sys/types.h before including regex.h, as
2728 required by Posix.
2729
762b15be
EZ
2730 * doc.c (get_doc_string): Improve the format passed to `error'.
2731
2732 * doprnt.c (doprnt): Improve commentary.
2733
2734 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2735
2736 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2737 them with etags.
2738
f1052e5d
EZ
2739 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2740 changes in globals.h immediately force recompilation.
762b15be
EZ
2741 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2742 $(CURDIR)/s/ms-w32.h.
2743 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2744
fa6996bc
EZ
2745 * character.c (Fchar_direction): Function deleted.
2746 (syms_of_character): Don't defsubr it.
2747 <char-direction-table>: Deleted.
2748
e6c3da20
EZ
27492011-04-23 Eli Zaretskii <eliz@gnu.org>
2750
2751 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2752 * doprnt.c: Include limits.h.
2753 (SIZE_MAX): New macro.
04f2d78b
CB
2754 (doprnt): Return a size_t value. 2nd arg is now size_t.
2755 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2756 Improve overflow protection. Support `l' modifier for integer
2757 conversions. Support %l conversion. Don't assume an EMACS_INT
2758 argument for integer conversions and for %c.
2759
2760 * lisp.h (doprnt): Restore prototype.
2761
2762 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2763 $(SRC)/character.h.
2764
2765 * Makefile.in (base_obj): Add back doprnt.o.
2766
2767 * deps.mk (doprnt.o): Add back prerequisites.
2768 (callint.o): Depend on character.h.
2769
2770 * eval.c (internal_lisp_condition_case): Include the handler
2771 representation in the error message.
2772 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2773 when breaking from the loop.
2774
2775 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2776
2777 * callint.c (Fcall_interactively): When displaying error message
2778 about invalid control letter, pass the character's codepoint, not
2779 a pointer to its multibyte form. Improve display of the character
2780 in octal and display also its hex code.
2781
2782 * character.c (char_string): Use %x to display the (unsigned)
2783 codepoint of an invalid character, to avoid displaying a bogus
2784 negative value.
2785
2786 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2787 `error', not SYMBOL_NAME itself.
2788
2789 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2790 character arguments to `error'.
2791
2792 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2793 to `error' in error message about FINAL_CHAR argument. Make sure
2794 FINAL_CHAR is a character, and use %c when it is passed as
2795 argument to `error'.
2796
4ffd0d6b 27972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2798
2799 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2800
2801 * w32.c: Include <time.h>.
2802 (sys_localtime): New function.
2803
4ffd0d6b 28042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2805
2806 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2807
4ffd0d6b 2808 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2809
4ffd0d6b 28102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2811
4ffd0d6b
GM
2812 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2813 zombies (Bug#8467).
aac0c6e3 2814
04c56954
EZ
28152011-04-19 Eli Zaretskii <eliz@gnu.org>
2816
2817 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2818 gl_state.e_property when gl_state.object is Qt.
2819
2820 * insdel.c (make_gap_larger): Remove limitation of buffer size
2821 to <= INT_MAX.
2822
16a43933
CY
28232011-04-18 Chong Yidong <cyd@stupidchicken.com>
2824
2825 * xdisp.c (lookup_glyphless_char_display)
2826 (produce_glyphless_glyph): Handle cons cell entry in
2827 glyphless-char-display.
2828 (Vglyphless_char_display): Document it.
2829
2830 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2831 glyphless-char-display.
2832
4581706e
CY
28332011-04-17 Chong Yidong <cyd@stupidchicken.com>
2834
2835 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2836
2837 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2838
2839 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2840 definition for no-X builds.
2841
4887c6e2 28422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2843
fd35b6f9
PE
2844 Static checks with GCC 4.6.0 and non-default toolkits.
2845
5c1ccb01
PE
2846 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2847
006c5daa
PE
2848 * process.c (keyboard_bit_set): Define only if SIGIO.
2849 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2850 (send_process): Repair possible setjmp clobbering.
2851
efc736d3
PE
2852 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2853
4e2fe2e6
PE
2854 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2855
f97334a2
PE
2856 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2857
4e75f29d
PE
2858 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2859 Define only if needed.
2860
90efadd1
PE
2861 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2862 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2863 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2864
3c647824
PE
2865 * dispextern.h (struct redisplay_interface): Rename param
2866 to avoid shadowing.
e264f262 2867 * termhooks.h (struct terminal): Likewise.
761383f4 2868 * xterm.c (xembed_send_message): Likewise.
3c647824 2869
b58c5c4a
PE
2870 * insdel.c (make_gap_smaller): Define only if
2871 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2872
cad59032
PE
2873 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2874 it.
2875
c339dc2e
PE
2876 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2877 so that we aren't warned about unused symbols.
2878
91a3e27b
PE
2879 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2880
399c71d3 2881 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2882
8ffc96f5
PE
2883 * xfns.c (x_real_positions): Mark locals as initialized.
2884
eef9bc79
PE
2885 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2886
098db9dd
PE
2887 * xterm.c: Fix problems found by static analysis with other toolkits.
2888 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2889 (x_dispatch_event): Declare static if USE_GTK, and
2890 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2891 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2892 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2893 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2894 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2895
eb18f6cc
PE
2896 * xmenu.c (menu_help_callback): Pointer type fixes.
2897 Use const pointers when pointing at readonly data. Avoid pointer
2898 signedness clashes.
2899 (FALSE): Remove unused macro.
2900 (update_frame_menubar): Remove unused decl.
2901
1fe72bf8
PE
2902 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2903
60d9e1db
PE
2904 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2905 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2906 (single_menu_item): Rename local to avoid shadowing.
2907
39261c26
PE
2908 * keyboard.c (make_lispy_event): Remove unused local var.
2909
018c5e19
PE
2910 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2911 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2912
63d2b86e
PE
2913 * bitmaps: Change bitmaps from unsigned char back to the X11
2914 compatible char. Avoid the old compiler warnings about
2915 out-of-range initializers by using, for example, '\xab' rather
2916 than 0xab.
2917
aefd87e1
PE
2918 * xgselect.c (xgselect_initialize): Check vs interface
2919 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2920
bf501fb9
PE
2921 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2922
e9829fdf
PE
2923 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2924 to read-only memory.
2925
1086c095
PE
2926 * fns.c (vector): Remove; this old hack is no longer needed.
2927
2baccd04 2928 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2929 Remove unused var.
dde42981 2930 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2931
72391843 2932 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2933
436c16df 2934 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2935 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2936 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2937
92bb796d 2938 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2939 (x_term_init): Remove local to avoid shadowing.
92bb796d 2940
764430a3 2941 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2942
2943 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2944 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2945
d1dfb56c
EZ
29462011-04-16 Eli Zaretskii <eliz@gnu.org>
2947
c4354cb4
EZ
2948 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2949
d1dfb56c
EZ
2950 Fix regex.c, syntax.c and friends for buffers > 2GB.
2951 * syntax.h (struct gl_state_s): Declare character position members
2952 EMACS_INT.
2953
2954 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2955
04f2d78b
CB
2956 * textprop.c (verify_interval_modification, interval_of):
2957 Declare arguments EMACS_INT.
d1dfb56c
EZ
2958
2959 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2960 EMACS_INT.
2961
2962 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2963
2964 * indent.c (Fvertical_motion): Local variable it_start is now
2965 EMACS_INT.
2966
2967 * regex.c (re_match, re_match_2, re_match_2_internal)
2968 (bcmp_translate, regcomp, regexec, print_double_string)
2969 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2970 (re_compile_pattern, re_exec): Declare arguments and local
2971 variables `size_t' and `ssize_t' and return values `regoff_t', as
2972 appropriate.
2973 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2974 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2975 <compile_stack_type>: `size' and `avail' are now `size_t'.
2976
2977 * regex.h <regoff_t>: Use ssize_t, not int.
2978 (re_search, re_search_2, re_match, re_match_2): Arguments that
2979 specify buffer/string position and length are now ssize_t and
2980 size_t. Return type is regoff_t.
2981
613052cd
BK
29822011-04-16 Ben Key <bkey76@gmail.com>
2983
2984 * nsfont.m: Fixed bugs in ns_get_family and
2985 ns_descriptor_to_entity that were caused by using free to
2986 deallocate memory blocks that were allocated by xmalloc (via
2987 xstrdup). This caused Emacs to crash when compiled with
2988 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2989 --enable-checking=xmallocoverrun). xfree is now used to
2990 deallocate these memory blocks.
2991
4170f62f 29922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2993
71b41406
PE
2994 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2995
9587a89d
PE
2996 emacs_write: Accept and return EMACS_INT for sizes.
2997 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2998 et seq.
2999 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3000 Accept and return EMACS_INT.
3001 (emacs_gnutls_write): Return the number of bytes written on
3002 partial writes.
3003 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3004 (emacs_read, emacs_write): Remove check for negative size, as the
3005 Emacs source code has been audited now.
9587a89d
PE
3006 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3007 (emacs_read, emacs_write): Use it.
273a5f82
PE
3008 * process.c (send_process): Adjust to the new signatures of
3009 emacs_write and emacs_gnutls_write. Do not attempt to store
3010 a byte offset into an 'int'; it might overflow.
9587a89d 3011 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3012
3e047f51
PE
3013 * sound.c: Don't assume sizes fit in 'int'.
3014 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3015 Return EMACS_INT, not int.
3e047f51 3016 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3017 Accept EMACS_INT, not int.
3018 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3019 record read return values.
3020
cc39a9db
BK
30212011-04-15 Ben Key <bkey76@gmail.com>
3022
c9d0ec6d
JB
3023 * keyboard.c (Qundefined): Don't declare static since it is used
3024 in nsfns.m.
3025 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3026 static since they are used in nsfont.m.
cc39a9db 3027
6c60eb9f
SM
30282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3029
3030 * process.c (Qprocessp): Don't declare static.
3031 * lisp.h (Qprocessp): Declare again.
3032
7990b61a
JB
30332011-04-15 Juanma Barranquero <lekktu@gmail.com>
3034
3035 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3036
5d4cb038
PE
30372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3038
8bd7b830 3039 Improve C-level modularity by making more things 'static'.
cd64ea1d 3040
e3b27b31
PE
3041 Don't publish debugger-only interfaces to other modules.
3042 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3043 (verify_bytepos, count_markers): Move decls to the only modules
3044 that need them.
3045 * region-cache.h (pp_cache): Likewise.
3046 * window.h (check_all_windows): Likewise.
3047 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3048
5d4cb038
PE
3049 * sysdep.c (croak): Now static, if
3050 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3051 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3052
3053 * alloc.c (refill_memory_reserve): Now static if
3054 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3055 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3056
e87b6180
PE
3057 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3058 Define only if USE_LUCID.
3059
ac64929e
PE
3060 * xrdb.c (x_customization_string, x_rm_string): Now static.
3061
6f37259d
PE
3062 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3063 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3064
1683e3ab
PE
3065 * xdisp.c (draw_row_with_mouse_face): Now static.
3066 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3067
de9c2632
PE
3068 * window.h (check_all_windows): Mark externally visible.
3069
2b96acb7
PE
3070 * window.c (window_deletion_count): Now static.
3071
3072 * undo.c: Make symbols static if they're not exported.
3073 (last_undo_buffer, last_boundary_position, pending_boundary):
3074 Now static.
3075
50436f33
PE
3076 * textprop.c (interval_insert_behind_hooks): Now static.
3077 (interval_insert_in_front_hooks): Likewise.
3078
64520e5c
PE
3079 * term.c: Make symbols static if they're not exported.
3080 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3081 (max_frame_lines, tty_set_terminal_modes):
3082 (tty_reset_terminal_modes, tty_turn_off_highlight):
3083 (get_tty_terminal): Now static.
3084 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3085 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3086 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3087 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3088 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3089
1fa53021
PE
3090 * sysdep.c: Make symbols static if they're not exported.
3091 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3092 Now static.
3093 (sigprocmask_set, full_mask): Remove; unused.
3094 (wait_debugging): Mark as visible.
3095 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3096 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3097
d4b43b22
PE
3098 * syntax.c (syntax_temp): Define only if !__GNUC__.
3099
b7c513d0
PE
3100 * sound.c (current_sound_device, current_sound): Now static.
3101
989b29ad
PE
3102 * search.c (searchbufs, searchbuf_head): Now static.
3103
13a55a78
PE
3104 * scroll.c (scroll_cost): Remove; unused.
3105 * dispextern.h (scroll_cost): Remove decl.
3106
de68a1fc
PE
3107 * region-cache.h (pp_cache): Mark as externally visible.
3108
40ccffa6
PE
3109 * process.c: Make symbols static if they're not exported.
3110 (process_tick, update_tick, create_process, chan_process):
3111 (Vprocess_alist, proc_buffered_char, datagram_access):
3112 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3113 (deactivate_process): Mark defn as static, as well as decl.
3114 * lisp.h (create_process): Remove decl.
3115 * process.h (chan_process, Vprocess_alist): Remove decls.
3116
ad64fc97
PE
3117 * print.c: Make symbols static if they're not exported.
3118 (print_depth, new_backquote_output, being_printed, print_buffer):
3119 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3120 (print_interval, print_number_index, initial_stderr_stream):
3121 Now static.
3122 * lisp.h (Fprinc): Remove decl.
3123 (debug_output_compilation_hack): Mark as externally visible.
3124
adddb265
PE
3125 * sysdep.c (croak): Move decl from here to syssignal.h.
3126 * syssignal.h (croak): Put it here, so the API can be checked when
3127 'croak' is called from dissociate_if_controlling_tty.
3128
1717ede2
PE
3129 * minibuf.c: Make symbols static if they're not exported.
3130 (minibuf_save_list, choose_minibuf_frame): Now static.
3131 * lisp.h (choose_minibuf_frame): Remove decl.
3132
fa5fb2bc
PE
3133 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3134
1e3890d1
PE
3135 * lread.c: Make symbols static if they're not exported.
3136 (read_objects, initial_obarray, oblookup_last_bucket_number):
3137 Now static.
3138 (make_symbol): Remove; unused.
3139 * lisp.h (initial_obarray, make_symbol): Remove decls.
3140
8a1414fa
PE
3141 * keyboard.c: Make symbols static if they're not exported.
3142 (single_kboard, recent_keys_index, total_keys, recent_keys):
3143 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3144 (this_single_command_key_start, echoing, last_auto_save):
3145 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3146 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3147 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3148 (Vlispy_mouse_stem, double_click_count):
3149 Now static.
3150 (force_auto_save_soon): Define only if SIGDANGER.
3151 (ignore_mouse_drag_p): Now static if
3152 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3153 (print_help): Remove; unused.
3154 (stop_character, last_timer_event): Mark as externally visible.
3155 * keyboard.h (ignore_mouse_drag_p): Declare only if
3156 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3157 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3158 * lisp.h (echoing): Remove decl.
3159 (force_auto_save_soon): Declare only if SIGDANGER.
3160 * xdisp.c (redisplay_window): Simplify code, to make it more
3161 obvious that ignore_mouse_drag_p is not accessed if !defined
3162 USE_GTK && !defined HAVE_NS.
3163
93ea6e8f
PE
3164 * intervals.c: Make symbols static if they're not exported.
3165 (merge_properties_sticky, merge_interval_right, delete_interval):
3166 Now static.
3167 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3168
77382fcc
PE
3169 * insdel.c: Make symbols static if they're not exported.
3170 However, leave prepare_to_modify_buffer alone. It's never
3171 called from outside this function, but that appears to be a bug.
3172 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3173 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3174 (adjust_after_replace_noundo): Remove; unused.
3175 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3176 (signal_before_change): Remove decls.
77382fcc 3177
9306c32e
PE
3178 * indent.c (val_compute_motion, val_vmotion): Now static.
3179
cd44d2eb
PE
3180 * image.c: Make symbols static if they're not exported.
3181 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3182 if USE_GTK.
3183 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3184 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3185
ad9a7a06
PE
3186 * fringe.c (standard_bitmaps): Now static.
3187 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3188
81626931
PE
3189 * frame.c: Make symbols static if they're not exported.
3190 (x_report_frame_params, make_terminal_frame): Now static.
3191 (get_frame_param): Now static, unless HAVE_NS.
3192 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3193 (x_get_resource_string): Remove; not used.
3194 * frame.h (make_terminal_frame, x_report_frame_params):
3195 (x_get_resource_string); Remove decls.
3196 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3197 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3198
239f9db9
PE
3199 * font.c, fontset.c: Make symbols static if they're not exported.
3200 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3201 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3202 * font.c (font_close_object): Now static.
3203 * font.h (font_close_object): Remove.
3204 * fontset.c (FONTSET_OBJLIST): Remove.
3205 (free_realized_fontset) #if-0 the body, which does nothing.
3206 (face_suitable_for_char_p): #if-0, as it's never called.
3207 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3208 * xfaces.c (face_at_string_position):
3209 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3210 since 0 is always ASCII.
3211
dfcf3579
PE
3212 * fns.c (weak_hash_tables): Now static.
3213
5045092b
PE
3214 * fileio.c: Make symbols static if they're not exported.
3215 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3216 (Vwrite_region_annotation_buffers): Now static.
3217
57a96f5c
PE
3218 * eval.c: Make symbols static if they're not exported.
3219 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3220 * lisp.h (backtrace_list): Remove decl.
3221
35f08c38
PE
3222 * emacs.c: Make symbols static if they're not exported.
3223 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3224 (fatal_error_code, fatal_error_signal_hook, standard_args):
3225 Now static.
3226 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3227 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3228 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3229 * lisp.h (fatal_error_signal_hook): Remove decl.
3230 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3231
f44bd759
PE
3232 * editfns.c: Move a (normally-unused) function to its only use.
3233 * editfns.c, lisp.h (get_operating_system_release): Remove.
3234 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3235 worth the hassle of breaking this out.
3236
b532497d
PE
3237 * xterm.c: Make symbols static if they're not exported.
3238 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3239 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3240 (x_destroy_window, x_delete_display):
3241 Now static.
3242 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3243 (x_mouse_leave): Remove; unused.
3244 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3245 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3246 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3247 Remove decls.
3248 (x_mouse_leave): Declare only if WINDOWSNT.
3249 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3250 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3251 USE_X_TOOLKIT.
3252
1675728f
PE
3253 * ftxfont.c: Make symbols static if they're not exported.
3254 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3255 HAVE_FREETYPE.
3256 * font.h (ftxfont_driver): Likewise.
3257
e4cebfca
PE
3258 * xfns.c: Make symbols static if they're not exported.
3259 (x_last_font_name, x_display_info_for_name):
3260 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3261 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3262 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3263 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3264 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3265 (last_show_tip_args): Now static.
3266 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3267 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3268 (x_screen_planes): Remove; unused.
3269 * dispextern.h (x_screen_planes): Remove decl.
3270
5bf46f05
PE
3271 * dispnew.c: Make symbols static if they're not exported.
3272 * dispextern.h (redraw_garbaged_frames, scrolling):
3273 (increment_row_positions): Remove.
3274 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3275 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3276 Now static.
3277 (redraw_garbaged_frames): Remove; unused.
3278
435f4c28
PE
3279 * xfaces.c: Make symbols static if they're not exported.
3280 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3281 Remove decls.
3282 * xterm.h (defined_color): Remove decls.
3283 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3284 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3285 (menu_face_changed_default, defined_color, free_realized_face):
3286 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3287 (ascii_face_of_lisp_face): Remove; unused.
3288
8524aef3
PE
3289 * xdisp.c: Make symbols static if they're not exported.
3290 * dispextern.h (scratch_glyph_row, window_box_edges):
3291 (glyph_to_pixel_coords, set_cursor_from_row):
3292 (get_next_display_element, set_iterator_to_next):
3293 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3294 (show_mouse_face): Remove decls
3295 * frame.h (message_buf_print): Likewise.
3296 * lisp.h (pop_message, set_message, check_point_in_composition):
3297 Likewise.
3298 * xterm.h (set_vertical_scroll_bar): Likewise.
3299 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3300 (message_buf_print, scratch_glyph_row, displayed_buffer):
3301 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3302 (get_next_display_element, show_mouse_face, window_box_edges):
3303 (frame_to_window_pixel_xy, check_point_in_composition):
3304 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3305 (glyph_to_pixel_coords): Remove; unused.
3306
16390cd2
PE
3307 * dired.c (file_name_completion): Now static.
3308
3309 * dbusbind.c (xd_in_read_queued_messages): Now static.
3310
a25f4dfa
PE
3311 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3312 * data.c (circular_list_error): Remove.
3313
14a9c8df
PE
3314 * commands.h (last_point_position, last_point_position_buffer):
3315 (last_point_position_window): Remove decls.
3316 * keyboard.c: Make these variables static.
3317
04f2d78b
CB
3318 * coding.h (coding, code_convert_region, encode_coding_gap):
3319 Remove decls.
74ab6df5
PE
3320 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3321 (iso_code_class, detect_coding, code_convert_region): Now static.
3322 (encode_coding_gap): Remove; unused.
3323
38dfbee1
PE
3324 * chartab.c (chartab_chars, chartab_bits): Now static.
3325
a2cb4e63
PE
3326 * charset.h (charset_iso_8859_1): Remove decl.
3327 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3328 Now static.
3329
127198fd
PE
3330 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3331 * ccl.c (Vccl_program_table): Now static.
3332 (check_ccl_update): Remove; unused.
3333
d85b608f
PE
3334 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3335 * category.h: ... from here.
3336 * category.c (check_category_table, set_category_set): Now static.
3337
31cd66f3
PE
3338 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3339 * lisp.h: Remove these decls.
3340
c358e587
PE
3341 * buffer.c (buffer_count): Remove unused var.
3342
e78aecca
PE
3343 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3344 so that it's not optimized away.
3345 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3346 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3347 exported only to the debugger.
3348
e192d7d3 3349 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3350 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3351
92470028
PE
3352 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3353 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3354 was inaccessible from Lisp.
3355 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3356 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3357
244ed907
PE
3358 alloc.c: Import and export fewer symbols, and remove unused items.
3359 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3360 is defined.
3361 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3362 it's not optimized away by whole-program optimization.
3363 (message_enable_multibyte, free_misc): Remove.
3364 (catchlist, handlerlist, mark_backtrace):
3365 Declare only if BYTE_MARK_STACK.
3366 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3367 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3368 (message_enable_multibyte): Remove decl.
3369 (free_misc, interval_free_list, float_block, float_block_index):
3370 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3371 (cons_free_list, last_marked_index):
3372 Now static.
3373 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3374 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3375 (mark_backtrace): Define only if BYTE_MARK_STACK.
3376 * xdisp.c (message_enable_multibyte): Now static.
3377
61c2b50e 3378 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3379 This makes it easier for human readers (and static analyzers)
3380 to see whether these variables are used from other modules.
3381 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3382 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3383 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3384 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3385 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3386 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3387 * xmenu.c, xselect.c:
3388 Declare Q* vars static if they are not used in other modules.
3389 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3390 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3391 Remove decls of unexported vars.
3392 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3393
95c82688
PE
3394 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3395
16a97296
PE
3396 Make Emacs functions such as Fatom 'static' by default.
3397 This makes it easier for human readers (and static analyzers)
3398 to see whether these functions can be called from other modules.
3399 DEFUN now defines a static function. To make the function external
3400 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3401 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3402 (Finit_image_library):
16a97296
PE
3403 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3404 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3405 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3406 Remove decls, since these functions are now static.
3407 (Funintern, Fget_internal_run_time): New decls, since these functions
3408 were already external.
95c82688 3409
16a97296
PE
3410 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3411 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3412 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3413 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3414 * keyboard.c, keymap.c, lread.c:
3415 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3416 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3417 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3418 Mark functions with DEFUE instead of DEFUN,
3419 if they are used in other modules.
3420 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3421 decls for now-static functions.
3422 * buffer.h (Fdelete_overlay): Remove decl.
3423 * callproc.c (Fgetenv_internal): Mark as internal.
3424 * composite.c (Fremove_list_of_text_properties): Remove decl.
3425 (Fcomposition_get_gstring): New forward static decl.
3426 * composite.h (Fcomposite_get_gstring): Remove decl.
3427 * dired.c (Ffile_attributes): New forward static decl.
3428 * doc.c (Fdocumntation_property): New forward static decl.
3429 * eval.c (Ffetch_bytecode): New forward static decl.
3430 (Funintern): Remove extern decl; now in .h file where it belongs.
3431 * fileio.c (Fmake_symbolic_link): New forward static decl.
3432 * image.c (Finit_image_library): New forward static decl.
3433 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3434 * intervals.h (Fprevious_property_change):
3435 (Fremove_list_of_text_properties): Remove decls.
3436 * keyboard.c (Fthis_command_keys): Remove decl.
3437 (Fcommand_execute): New forward static decl.
3438 * keymap.c (Flookup_key): New forward static decl.
3439 (Fcopy_keymap): Now static.
3440 * keymap.h (Flookup_key): Remove decl.
3441 * process.c (Fget_process): New forward static decl.
3442 (Fprocess_datagram_address): Mark as internal.
3443 * syntax.c (Fsyntax_table_p): New forward static decl.
3444 (skip_chars): Remove duplicate decl.
3445 * textprop.c (Fprevious_property_change): New forward static decl.
3446 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3447 Now internal.
3448 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3449 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3450
785bbd42
PE
3451 * editfns.c (Fformat): Remove unreachable code.
3452
8b913b57
AS
34532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3454
3455 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3456 change. (Bug#8496)
3457
a6744a35
EZ
34582011-04-13 Eli Zaretskii <eliz@gnu.org>
3459
3460 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3461 when at ZV. (Bug#8487)
3462
e7974947
AS
34632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3464
baad03f0
AS
3465 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3466 (Bug#8437)
3467 * keyboard.c (parse_tool_bar_item): Likewise.
3468 * sound.c (sound_cleanup, alsa_close): Likewise.
3469 * termcap.c (tgetent): Likewise.
3470 * xfns.c (x_default_font_parameter): Likewise.
3471 * xsettings.c (read_and_apply_settings): Likewise.
3472
e7974947
AS
3473 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3474 (overrun_check_free): Protoize.
3475
28272684
PE
34762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3477
3478 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3479 since callers should never pass a negative size.
3480 Change the signature to match that of plain 'read' and 'write'; see
3481 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3482 * lisp.h: Update prototypes of emacs_write and emacs_read.
3483
11997c76
EZ
34842011-04-11 Eli Zaretskii <eliz@gnu.org>
3485
3486 * xdisp.c (redisplay_window): Don't try to determine the character
3487 position of the scroll margin if the window start point w->startp
e896f03c 3488 is outside the buffer's accessible region. (Bug#8468)
11997c76 3489
8a2cbd72
EZ
34902011-04-10 Eli Zaretskii <eliz@gnu.org>
3491
3492 Fix write-region and its subroutines for buffers > 2GB.
3493 * fileio.c (a_write, e_write): Modify declaration of arguments and
3494 local variables to support buffers larger than 2GB.
3495 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3496
3497 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3498 argument, local variables, and return value.
3499
3500 * lisp.h: Update prototypes of emacs_write and emacs_read.
3501
3502 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3503
4073e537 35042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3505
1ebfdcb6
PE
3506 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3507
b2ded58d
PE
3508 Fix more problems found by GCC 4.6.0's static checks.
3509
7d66342c
PE
3510 * xdisp.c (vmessage): Use a better test for character truncation.
3511
bbf47d44
PE
3512 * charset.c (load_charset_map): <, not <=, for optimization,
3513 and to avoid potential problems with integer overflow.
9248994d 3514 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3515 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3516 * editfns.c (Fformat): Likewise.
1e69125e 3517 * syntax.c (skip_chars): Likewise.
3befa583 3518
e3019616
PE
3519 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3520 This also lets GCC 4.6.0 generate slightly better loop code.
3521
becfa255
PE
3522 * callint.c (Fcall_interactively): <, not <=, for optimization.
3523 (Fcall_interactively): Count the number of arguments produced,
3524 not the number of arguments given. This is simpler and lets GCC
3525 4.6.0 generate slightly better code.
3526
dae0cd48
PE
3527 * ftfont.c: Distingish more carefully between FcChar8 and char.
3528 The previous code passed unsigned char * to a functions like
3529 strlen and xstrcasecmp that expect char *, which does not
3530 conform to the C standard.
3531 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3532 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3533 char * when the C standard requires it.
3534
76032d70
PE
3535 * keyboard.c (read_char): Remove unused var.
3536
eb3f1cc8
PE
3537 * eval.c: Port to Windows vsnprintf (Bug#8435).
3538 Include <limits.h>.
3539 (SIZE_MAX): Define if the headers do not.
3540 (verror): Do not give up if vsnprintf returns a negative count.
3541 Instead, grow the buffer. This ports to Windows vsnprintf, which
3542 does not conform to C99. Problem reported by Eli Zaretskii.
3543 Also, simplify the allocation scheme, by avoiding the need for
3544 calling realloc, and removing the ALLOCATED variable.
3545
70476b54
PE
3546 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3547
12020a9e
PE
3548 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3549 But keep the doprint source code for now, as we might revamp it
3550 and use it again (Bug#8435).
ea6c7ae6
PE
3551 * lisp.h (doprnt): Remove.
3552 * Makefile.in (base_obj): Remove doprnt.o.
3553 * deps.mk (doprnt.o): Remove.
3554
5fdb398c
PE
3555 error: Print 32- and 64-bit integers portably (Bug#8435).
3556 Without this change, on typical 64-bit hosts error ("...%d...", N)
3557 was used to print both 32- and 64-bit integers N, which relied on
3558 undefined behavior.
3559 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3560 New macro.
3561 * lisp.h (error, verror): Mark as printf-like functions.
3562 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3563 Report overflow in size calculations when allocating printf buffer.
3564 Do not truncate output string at its first null byte.
3565 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3566 Truncate the output at a character boundary, since vsnprintf does not
3567 do that.
3568 * charset.c (check_iso_charset_parameter): Convert internal
3569 character to string before calling 'error', since %c now has the
3570 printf meaning.
3571 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3572 overflow when computing char to be passed to 'error'. Do not
3573 pass Lisp_Object to 'error'; pass the integer instead.
3574 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3575 formatted with plain %d.
3576
b189fa66
PE
3577 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3578
bff87ef0
PE
3579 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3580
7e2cac20
PE
3581 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3582
ce4d90b5
PE
3583 * xterm.c (x_catch_errors): Remove duplicate declaration.
3584
266c9547
PE
3585 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3586
79c49ad2
PE
3587 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3588
368f4090
JM
35892011-04-10 Jim Meyering <meyering@redhat.com>
3590
3591 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3592 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3593 return ssize_t not "int", and use size_t as the buffer length.
3594 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3595 * gnutls.h: Update declarations.
3596 * process.c (read_process_output): Use ssize_t, to match.
3597 (send_process): Likewise.
3598
a32d4040
CY
35992011-04-09 Chong Yidong <cyd@stupidchicken.com>
3600
3601 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3602
8546720e 36032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3604
04f2d78b
CB
3605 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3606 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3607
8546720e
GM
3608 * xterm.c (handle_one_xevent):
3609 * xmenu.c (create_and_show_popup_menu):
3610 * xselect.c (x_decline_selection_request)
3611 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3612
0a2f5c1a 36132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3614
3615 Fix some uses of `int' instead of EMACS_INT.
3616 * search.c (string_match_1, fast_string_match)
3617 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3618 (scan_buffer, find_next_newline_no_quit)
3619 (find_before_next_newline, search_command, Freplace_match)
3620 (Fmatch_data): Make some `int' variables be EMACS_INT.
3621
3622 * xdisp.c (display_count_lines): 3rd argument and return value now
3623 EMACS_INT. All callers changed.
3624 (pint2hrstr): Last argument is now EMACS_INT.
3625
3626 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3627 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3628 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3629 (decode_coding_utf_16, decode_coding_emacs_mule)
3630 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3631 (decode_coding_ccl, decode_coding_charset)
3632 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3633 (decode_coding_iso_2022, decode_coding_emacs_mule)
3634 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3635 <char_offset, last_offset>: Declare EMACS_INT.
3636 (encode_coding_utf_8, encode_coding_utf_16)
3637 (encode_coding_emacs_mule, encode_invocation_designation)
3638 (encode_designation_at_bol, encode_coding_iso_2022)
3639 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3640 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3641 Declare EMACS_INT.
3642 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3643 (encode_invocation_designation): Last argument P_NCHARS is now
3644 EMACS_INT.
3645 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3646 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3647
3648 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3649 All users changed.
3650
3651 * ccl.c (Fccl_execute_on_string): Declare some variables
3652 EMACS_INT.
3653
8546720e 36542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3655
3656 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3657
4e19a977
CS
36582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3659
3660 * process.c (Fformat_network_address): Doc fix.
3661
87302331
R
36622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3663
3664 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3665
cbb59342
CY
36662011-04-08 Chong Yidong <cyd@stupidchicken.com>
3667
3668 * keyboard.c (read_char): Call Lisp function help-form-show,
3669 instead of using internal_with_output_to_temp_buffer.
3670 (Qhelp_form_show): New var.
e0d38eeb 3671 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3672
3673 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3674
3675 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3676
e67a13ab
CY
36772011-04-06 Chong Yidong <cyd@stupidchicken.com>
3678
04f2d78b
CB
3679 * process.c (Flist_processes): Remove to Lisp.
3680 (list_processes_1): Delete.
e67a13ab 3681
973f782d
EZ
36822011-04-06 Eli Zaretskii <eliz@gnu.org>
3683
7c106b1e
EZ
3684 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3685
973f782d
EZ
3686 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3687
41cf7d1a 36882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3689
ca23cc88
PE
3690 Fix more problems found by GCC 4.6.0's static checks.
3691
f390e2d5
PE
3692 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3693
42eea0d0
PE
3694 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3695
b69769da 3696 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3697
f9541e84
PE
3698 * xdisp.c (vmessage): Mark as a printf-like function.
3699
13841b55
PE
3700 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3701
c136c10f
PE
3702 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3703
5e2d4a30
PE
3704 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3705 printf-like functions.
3706 (tiff_load): Add casts to remove these marks before passing them
3707 to system-supplied API.
3708
583f48b9
PE
3709 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3710
b25d760e
PE
3711 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3712 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3713 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3714 directly, rather than having caller test rule sign. This avoids
3715 some unnecessary tests.
3716 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3717 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3718 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3719
bc7b6697 3720 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3721 (xfont_open): Avoid unnecessary tests.
bc7b6697 3722
27ccc379
PE
3723 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3724
dcd5c89a
PE
3725 * composite.h, composite.c (composition_gstring_put_cache):
3726 Use EMACS_INT, not int, for length.
3727
b13a45c6
PE
3728 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3729 breaking out part of COMPOSITION_DECODE_RULE.
3730 (COMPOSITION_DECODE_RULE): Use it.
3731 * composite.c (get_composition_id): Remove unused local vars,
3732 by using the new macro.
3733
1e792e4d
PE
3734 * textprop.c (set_text_properties_1): Change while to do-while,
3735 since the condition is always true at first.
3736
dc6c6455 3737 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3738 (interval_deletion_adjustment): Return unsigned value.
3739 All uses changed.
dc6c6455 3740
aba7731a
PE
3741 * process.c (list_processes_1, create_pty, read_process_output):
3742 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3743 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3744 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3745 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3746 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3747
fdfc4bf3
PE
3748 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3749
fca8fe46 3750 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3751 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3752
06a0259a 3753 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3754 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3755 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3756
e7b9e80f
PE
3757 * print.c (print_error_message): Avoid int overflow.
3758
56201685
PE
3759 * font.c (font_list_entities): Redo for clarity,
3760 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3761
78834453 3762 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3763 (font_score): Avoid potential overflow in diff calculation.
78834453 3764
0bc0b309 3765 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3766 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3767
e610eaca
PE
3768 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3769
b895abce
PE
3770 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3771 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3772 can always succeed if overflow has undefined behavior.
3773
1f1d9321 3774 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3775 (wordify): Omit three unnecessary tests.
1f1d9321 3776
c59478bc
PE
3777 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3778 All callers changed. This avoids the need for an unused var.
3779
79b73827
PE
3780 * casefiddle.c (casify_region): Remove var that is set but not used.
3781
a4db5dfe
PE
3782 * dired.c (file_name_completion): Remove var that is set but not used.
3783
43aae36e
PE
3784 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3785
2a47c44d 3786 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3787 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3788
a37c69bf
PE
3789 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3790 Check for integer overflow on size calculations.
3791
328ab8e7
PE
3792 * buffer.c (Fprevious_overlay_change): Remove var that is set
3793 but not used.
3794
e5a2a5cb
PE
3795 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3796 Remove vars that are set but not used.
8d84a6eb 3797 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3798 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3799
a60e5f68
PE
3800 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3801
f661cb61 3802 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3803 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3804
f0397f5a
PE
3805 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3806 that are set but not used.
3807
8664db06 3808 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3809 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3810
6abdaa4a
PE
3811 * xselect.c (x_get_local_selection, x_handle_property_notify):
3812 Remove vars that are set but not used.
3813
0ce7538d 3814 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3815 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3816
9ae848fc
PE
3817 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3818 Remove var that is set but not used.
0b918413
PE
3819 (scroll_bar_windows_size): Now size_t, not int.
3820 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3821 Check for overflow.
9ae848fc 3822
a5a62657
PE
3823 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3824 (map_tty_color) [!defined MSDOS]: Likewise.
3825
5c5cdd39
PE
3826 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3827
66ebf983
PE
3828 * coding.c: Remove vars that are set but not used.
3829 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3830 All callers changed.
3831 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3832 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3833 (decode_coding_charset): Remove vars that are set but not used.
3834
1be4d761
PE
3835 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3836 that is set but not used.
3837
47553fa8
PE
3838 * print.c (print_object): Remove var that is set but not used.
3839
1f7196bf 3840 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3841 The gnulib version avoids calling malloc in the usual case,
3842 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3843 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3844 * filelock.c (current_lock_owner): Likewise.
3845 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3846 * sysdep.c: Include allocator.h, careadlinkat.h.
3847 (emacs_no_realloc_allocator): New static constant.
3848 (emacs_readlink): New function.
fdb61804
PE
3849 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3850 ../lib/careadlinkat.h.
d1fdcab7 3851
f84c17c7
SM
38522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3853
3854 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3855 first non-nil return value).
3856
ef3862ad
JD
38572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3858
3859 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3860 if not defined (Bug#8403).
3861
376a7006
JB
38622011-04-02 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * xdisp.c (display_count_lines): Remove parameter `start',
3865 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3866 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3867 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3868 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3869 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3870 and thereabouts. All callers changed.
3871 (get_per_char_metric): Remove parameter `f', unused since
3872 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3873
6ca3801d
JM
38742011-04-02 Jim Meyering <meyering@redhat.com>
3875
3876 do not dereference NULL upon failed strdup
3877 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3878 (ns_get_family): Likewise.
3879
d8e2b5ba
JB
38802011-04-02 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3883
8c74fcbd
JD
38842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3885
3886 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3887 later (Bug#8403).
3888
7200d79c
SM
38892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3890
03408648 3891 Add lexical binding.
7200d79c 3892
03408648
SM
3893 * window.c (Ftemp_output_buffer_show): New fun.
3894 (Fsave_window_excursion):
3895 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3896
3897 * lread.c (lisp_file_lexically_bound_p): New function.
3898 (Fload): Bind Qlexical_binding.
3899 (readevalloop): Remove `evalfun' arg.
3900 Bind Qinternal_interpreter_environment.
3901 (Feval_buffer): Bind Qlexical_binding.
3902 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3903 Mark as dynamic.
3904 (syms_of_lread): Declare `lexical-binding'.
3905
3906 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3907
3908 * keyboard.c (eval_dyn): New fun.
3909 (menu_item_eval_property): Use it.
ca105506
SM
3910
3911 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3912
03408648
SM
3913 * fns.c (concat, mapcar1): Accept byte-code-functions.
3914
3915 * eval.c (Fsetq): Handle lexical vars.
3916 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3917 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3918 (FletX, Flet): Obey lexical binding.
3919 (Fcommandp): Handle closures.
3920 (Feval): New `lexical' arg.
3921 (eval_sub): New function extracted from Feval. Use it almost
3922 everywhere where Feval was used. Look up vars in lexical env.
3923 Handle closures.
3924 (Ffunctionp): Move from subr.el.
3925 (Ffuncall): Handle closures.
3926 (apply_lambda): Remove `eval_flags'.
3927 (funcall_lambda): Handle closures and new byte-code-functions.
3928 (Fspecial_variable_p): New function.
3929 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3930 but without exporting it to Lisp.
23aba0ea 3931
23aba0ea 3932 * doc.c (Fdocumentation, store_function_docstring):
03408648 3933 * data.c (Finteractive_form): Handle closures.
23aba0ea 3934
03408648
SM
3935 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3936 interactive spec.
ba83908c 3937
04f2d78b
CB
3938 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3939 New byte-codes.
03408648
SM
3940 (exec_byte_code): New function extracted from Fbyte_code to handle new
3941 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3942
03408648 3943 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3944
03408648 3945 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3946
e2abce01
JB
39472011-03-31 Juanma Barranquero <lekktu@gmail.com>
3948
3949 * xdisp.c (redisplay_internal): Fix prototype.
3950
63696a73 39512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3952
63696a73 3953 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3954 (try_scrolling): Use it when setting scroll_limit.
3955 Limit scrolling to 100 screen lines.
63696a73
EZ
3956 (redisplay_window): Even when falling back on "recentering",
3957 position point in the window according to scroll-conservatively,
3958 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3959
3960 (try_scrolling): When point is above the window, allow searching
3961 as far as scroll_max, or one screenful, to compute vertical
3962 distance from PT to the scroll margin position. This prevents
3963 try_scrolling from unnecessarily failing when
3964 scroll-conservatively is set to a value slightly larger than the
3965 window height. Clean up the case of PT below the margin at bottom
3966 of window: scroll_max can no longer be INT_MAX. When aggressive
3967 scrolling is in use, don't let point enter the opposite scroll
3968 margin as result of the scroll.
3969 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3970 threshold of 100 lines for never-recentering scrolling.
3971
e4cc2dfc
JB
39722011-03-31 Juanma Barranquero <lekktu@gmail.com>
3973
3974 * dispextern.h (move_it_by_lines):
3975 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3976 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3977 (message_log_check_duplicate): Remove parameters `prev_bol' and
3978 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3979 (redisplay_internal): Remove parameter `preserve_echo_area',
3980 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3981
3982 * indent.c (Fvertical_motion):
3983 * window.c (window_scroll_pixel_based, Frecenter):
3984 Don't pass `need_y_p' to `move_it_by_lines'.
3985
1c470562
SM
39862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3987
44f230aa
SM
3988 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3989 steal a few bits to be more compact.
3990 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3991 Remove unneeded casts.
3992
1c470562
SM
3993 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3994
888adce9
ZK
39952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3996
3997 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3998 binding" message (bug#7967).
3999
f838ed7b
PE
40002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4001
77861b95
PE
4002 Fix more problems found by GCC 4.6.0's static checks.
4003
de6dbc14
PE
4004 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4005 Remove unused local var.
4006
f838ed7b
PE
4007 * editfns.c (Fmessage_box): Remove unused local var.
4008
792c7b2b
PE
4009 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4010 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4011 Omit unused local vars.
c499e557 4012 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4013 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4014 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4015 Omit unused local var.
4016
ba0165e1
PE
4017 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4018 Don't assume string length fits in int.
32ad8845 4019 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4020 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4021
3c59b4c9
PE
4022 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4023 instead of alloca (Bug#8344).
4024
a3eed478 4025 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4026 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4027
eb4d412d
PE
4028 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4029
1658b401
PE
4030 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4031 concerns.
4032
4033 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4034
4035 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4036
9a2c6e05
PE
4037 * keyboard.c (syms_of_keyboard): Use the same style as later
4038 in this function when indexing through an array. This also
4039 works around GCC bug 48267.
4040
03d0a109
PE
4041 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4042
44f730c8
PE
4043 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4044
fe75f926
PE
4045 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4046 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4047
ffa8c828
PE
4048 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4049 This avoids undefined behavior on integer overflow, and is a bit
4050 more convenient anyway since it is compared to a size_t variable.
4051
c5101a77
PE
4052 Variadic C functions now count arguments with size_t, not int.
4053 This avoids an unnecessary limitation on 64-bit machines, which
4054 caused (substring ...) to crash on large vectors (Bug#8344).
4055 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4056 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4057 All variadic functions and their callers changed accordingly.
c5101a77
PE
4058 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4059 * data.c (arith_driver, float_arith_driver): Likewise.
4060 * editfns.c (general_insert_function): Likewise.
4061 * eval.c (struct backtrace.nargs, interactive_p)
4062 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4063 (funcall_lambda, mark_backtrace): Likewise.
4064 * fns.c (concat): Likewise.
4065 * frame.c (x_set_frame_parameters): Likewise.
4066 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4067 0 if not found, not -1. All callers changed.
4068
dd3f25f7
PE
4069 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4070 (stack_copy_size): Now size_t, not int.
4071 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4072
461c2ab9
JB
40732011-03-28 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4076 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4077 All callers changed.
4078
4079 * lisp.h (multibyte_char_to_unibyte):
4080 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4081 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4082 * character.h (CHAR_TO_BYTE8):
4083 * cmds.c (internal_self_insert):
4084 * editfns.c (general_insert_function):
4085 * keymap.c (push_key_description):
4086 * search.c (Freplace_match):
4087 * xdisp.c (message_dolog, set_message_1): All callers changed.
4088
f6d62986
SM
40892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4090
4091 * keyboard.c (safe_run_hook_funcall): New function.
4092 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4093 don't set the hook to nil, but remove the offending function instead.
4094 (Qcommand_hook_internal): Remove, unused.
4095 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4096 Vcommand_hook_internal.
4097
4098 * eval.c (enum run_hooks_condition): Remove.
4099 (funcall_nil, funcall_not): New functions.
4100 (run_hook_with_args): Call each function through a `funcall' argument.
4101 Remove `cond' argument, now redundant.
4102 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4103 (Frun_hook_with_args_until_failure): Adjust accordingly.
4104 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4105
1db5b1ad
JB
41062011-03-28 Juanma Barranquero <lekktu@gmail.com>
4107
4108 * dispextern.h (string_buffer_position): Remove declaration.
4109
4110 * print.c (strout): Remove parameter `multibyte', unused since
4111 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4112
4113 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4114 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4115 All callers changed.
4116
4117 * w32.c (_wsa_errlist): Use braces for struct initializers.
4118
4119 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4120 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4121 All callers changed.
4122 (string_buffer_position): Likewise. Also, make static (it's never
4123 used outside xdisp.c).
4124 (cursor_row_p): Remove parameter `w', unused since
4125 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4126 (decode_mode_spec): Remove parameter `precision', introduced during
4127 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4128 All callers changed.
4129
5ffb62aa
JD
41302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4131
4132 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4133
461c2ab9 41342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4135
4136 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4137 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4138 (ns_update_auto_hide_menu_bar): New functions.
4139 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4140 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4141 ns_constrain_all_frames.
4142 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4143 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4144
5c380ffb
JD
41452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4146
4147 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4148
9af30bdf
GM
41492011-03-27 Glenn Morris <rgm@gnu.org>
4150
4151 * syssignal.h: Replace RETSIGTYPE with void.
4152 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4153 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4154 Replace SIGTYPE with void everywhere.
4155 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4156 * s/template.h (SIGTYPE): Remove commented out definition.
4157
e2abce01
JB
41582011-03-26 Eli Zaretskii <eliz@gnu.org>
4159
4160 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4161 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4162
f868cd8a
JB
41632011-03-26 Juanma Barranquero <lekktu@gmail.com>
4164
59eb0929
JB
4165 * w32.c (read_unc_volume): Use parameter `henum', instead of
4166 global variable `wget_enum_handle'.
4167
4168 * keymap.c (describe_vector): Remove parameters `indices' and
4169 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4170 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4171
f868cd8a
JB
4172 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4173
4174 * keyboard.c (timer_check): Remove parameter `do_it_now',
4175 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4176 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4177 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4178
4179 * keyboard.c (read_char):
4180 * w32menu.c (w32_menu_display_help):
4181 * xmenu.c (show_help_event, menu_help_callback):
4182 Adjust calls to `show_help_echo'.
4183
4184 * gtkutil.c (xg_maybe_add_timer):
4185 * keyboard.c (readable_events):
4186 * process.c (wait_reading_process_output):
4187 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4188
4189 * insdel.c (adjust_markers_gap_motion):
4190 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4191 (gap_left, gap_right): Don't call it.
4192
2ecf6fdb
CY
41932011-03-25 Chong Yidong <cyd@stupidchicken.com>
4194
4195 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4196 incurred during fontification.
4197
6b1f9ba4
JB
41982011-03-25 Juanma Barranquero <lekktu@gmail.com>
4199
4200 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4201 (DEFVAR_PER_BUFFER): Don't pass it.
4202
4203 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4204 (scrolling_window): Don't pass it.
4205
0f4a96b5
JB
42062011-03-25 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4209
4210 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4211 and `suffix'.
4212 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4213 of variables specific to SELinux and computation of `encoded_absname'.
4214
4215 * image.c (XPutPixel): Remove unused variable `height'.
4216
4217 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4218
4219 * unexw32.c (get_section_info): Remove unused variable `section'.
4220
4221 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4222 (system_process_attributes): Remove unused variable `sess'.
4223 (sys_read): Remove unused variable `err'.
4224
4225 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4226 (w32_wnd_proc): Remove unused variable `isdead'.
4227 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4228 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4229 (x_create_tip_frame): Remove unused variable `tem'.
4230
4231 * w32inevt.c (w32_console_read_socket):
4232 Remove unused variable `no_events'.
4233
4234 * w32term.c (x_draw_composite_glyph_string_foreground):
4235 Remove unused variable `width'.
4236
1149507c
JB
42372011-03-24 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * w32term.c (x_set_glyph_string_clipping):
4240 Don't pass uninitialized region to CombineRgn.
4241
9c88f339
JB
42422011-03-23 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4245 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4246 (Fx_close_connection): Remove unused variable `i'.
4247
4248 * w32font.c (w32font_draw): Return number of glyphs.
4249 (w32font_open_internal): Remove unused variable `i'.
4250 (w32font_driver): Add missing initializer.
4251
4252 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4253 (fill_in_menu): Remove unused variable `items_added'.
4254
4255 * w32term.c (last_mouse_press_frame): Remove static global variable.
4256 (w32_clip_to_row): Remove unused variable `f'.
4257 (x_delete_terminal): Remove unused variable `i'.
4258
4259 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4260 (NOTHING): Remove unused static global variable.
4261 (uniscribe_check_otf): Remove unused variable `table'.
4262 (uniscribe_font_driver): Add missing initializers.
4263
dee091a3
JD
42642011-03-23 Julien Danjou <julien@danjou.info>
4265
4266 * term.c (Fsuspend_tty, Fresume_tty):
4267 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4268 * window.c (temp_output_buffer_show):
4269 * insdel.c (signal_before_change):
4270 * frame.c (Fhandle_switch_frame):
4271 * fileio.c (Fdo_auto_save):
4272 * emacs.c (Fkill_emacs):
4273 * editfns.c (save_excursion_restore):
4274 * cmds.c (internal_self_insert):
4275 * callint.c (Fcall_interactively):
4276 * buffer.c (Fkill_all_local_variables):
4277 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4278 Use Frun_hooks.
0f4a96b5 4279 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4280 unconditionnaly since it does the check itself.
4281
2c520ab5 42822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4283
c9c49752
PE
4284 Fix more problems found by GCC 4.5.2's static checks.
4285
8abc3f12
PE
4286 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4287 the first time through the loop, since we know p0 < p1 then.
4288 This also avoids a gcc -Wstrict-overflow warning.
4289
a2d26660
PE
4290 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4291 leading to a memory leak, possible in functions like
4292 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4293 of objects (Bug#8318).
a2d26660 4294
916c72e9
PE
4295 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4296 that could (at least in theory) be that large.
4297
19ab8a18
PE
4298 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4299 This is less likely to overflow, and avoids undefined behavior if
4300 overflow does occur. All callers changed. Use strtoul to scan
4301 for the unsigned long integer.
b7cbbd6f
PE
4302 (pint2hrstr): Simplify and tune code slightly.
4303 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4304
f0641eff
PE
4305 * scroll.c (do_scrolling): Work around GCC bug 48228.
4306 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4307
7f650bb9
PE
4308 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4309 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4310 (validate_x_resource_name): Simplify count usage.
4311 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4312
37dd57d1
PE
4313 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4314 fail (Bug#8306).
81e56e61 4315
699979fc 4316 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4317
401bf9b4
PE
4318 * process.c (Fmake_network_process): Use socklen_t, not int,
4319 where POSIX says socklen_t is required in portable programs.
4320 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4321 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4322 (Fmake_network_process, server_accept_connection):
4323 (wait_reading_process_output, read_process_output):
4324 Likewise.
4325
b93aacde
PE
4326 * process.c: Rename or move locals to avoid shadowing.
4327 (list_processes_1, Fmake_network_process):
4328 (read_process_output_error_handler, exec_sentinel_error_handler):
4329 Rename or move locals.
4dc343ee 4330 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4331 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4332 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4333 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4334 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4335
af8a867c 4336 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4337 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4338 Include tparam.h instead, since it declares them.
af8a867c
PE
4339 * cm.h (PC): Remove extern decl; tparam.h now does this.
4340 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4341 * terminfo.c: Include tparam.h, to check interfaces.
4342 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4343 (tparam): Adjust signature to match interface in tparam.h;
4344 this removes some undefined behavior. Check that outstring and len
4345 are zero, which they always are with Emacs.
4346 * tparam.h (PC, BC, UP): New extern decls.
4347
0248044d 4348 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4349 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4350
8ff096c1 4351 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4352 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4353 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4354 (ftfont_list): Remove unused local.
49eaafba
PE
4355 (get_adstyle_property, ftfont_pattern_entity):
4356 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4357 Rename locals to avoid shadowing.
8ff096c1 4358
e2be39f6
PE
4359 * xfont.c (xfont_list_family): Mark var as initialized.
4360
c9735e30
PE
4361 * xml.c (make_dom): Now static.
4362
8f5201ae
PE
4363 * composite.c (composition_compute_stop_pos): Rename local to
4364 avoid shadowing.
b246f932
PE
4365 (composition_reseat_it): Remove unused locals.
4366 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4367 (composition_update_it): Mark var as initialized.
11b61122
PE
4368 (find_automatic_composition): Mark vars as initialized,
4369 with a FIXME (Bug#8290).
8f5201ae 4370
760fbc2c
PE
4371 character.h: Rename locals to avoid shadowing.
4372 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4373 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4374 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4375 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4376 to avoid shadowing.
4377
ff08eb85
PE
4378 * textprop.c (property_change_between_p): Remove; unused.
4379
fc7bf025
PE
4380 * intervals.c (interval_start_pos): Now static.
4381
235d7abc
PE
4382 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4383
44f230aa
SM
4384 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4385 Rename locals to avoid shadowing.
3e7d6594 4386
50060332
PE
4387 * sound.c (wav_play, au_play, Fplay_sound_internal):
4388 Fix pointer signedness.
d01f234b 4389 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4390 (wav_play): Initialize a variable to 0, to prevent undefined
4391 behavior (Bug#8278).
50060332 4392
c4fc4e30
PE
4393 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4394
918436ed
PE
4395 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4396
c939f91b
PE
4397 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4398 clobbering (Bug#8298).
b9c7f648
PE
4399 * sysdep.c (sys_subshell): Likewise.
4400 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4401
6bd8c144
PE
4402 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4403 This should get cleaned up, so that child_setup has the
4404 same signature on all platforms.
4405
7710357c 4406 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4407 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4408
c59da222
CY
44092011-03-22 Chong Yidong <cyd@stupidchicken.com>
4410
4411 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4412 not to be necessary, and produces flickering.
4413
66b87493
GM
44142011-03-20 Glenn Morris <rgm@gnu.org>
4415
4416 * config.in: Remove file.
4417
45b6f6d5
JB
44182011-03-20 Juanma Barranquero <lekktu@gmail.com>
4419
4420 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4421 are now in src/globals.h.
4422 (syms_of_minibuf): Remove spurious & from previous change.
4423
3ec03f7e
LL
44242011-03-20 Leo <sdl.web@gmail.com>
4425
4426 * minibuf.c (completing-read-function): New variable.
4427 (completing-read-default): Rename from completing-read.
4428 (completing-read): Call completing-read-function.
4429
b14e3e21
CY
44302011-03-19 Juanma Barranquero <lekktu@gmail.com>
4431
4432 * xfaces.c (Fx_load_color_file):
4433 Read color file from absolute filename (bug#8250).
4434
f2b726e6
JB
44352011-03-19 Juanma Barranquero <lekktu@gmail.com>
4436
4437 * makefile.w32-in: Update dependencies.
4438
09f6ff02
EZ
44392011-03-17 Eli Zaretskii <eliz@gnu.org>
4440
4441 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4442
29a6015a
PE
44432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4444
a3a6c54e
PE
4445 Fix more problems found by GCC 4.5.2's static checks.
4446
b766f867
PE
4447 * process.c (make_serial_process_unwind, send_process_trap):
4448 (sigchld_handler): Now static.
4449
be02381c
PE
4450 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4451 That way, the code declares only the vars that it needs.
4452 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4453 * s/cygwin.h (PTY_ITERATION): Likewise.
4454 * s/darwin.h (PTY_ITERATION): Likewise.
4455 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4456
57048744
PE
4457 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4458 * process.c (allocate_pty): Don't declare stb unless it's needed.
4459
7914961c 4460 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4461 (CONSTANTLIM): Remove; unused.
4462 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4463 Define only if needed.
7914961c 4464
b3967b18
PE
4465 * unexelf.c (unexec): Name an expression,
4466 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4467 Use a different way to cause a compilation error if anyone uses
4468 n rather than nn, a way that does not involve shadowing.
73366a00 4469 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4470
29a6015a
PE
4471 * deps.mk (unexalpha.o): Remove; unused.
4472
43cfc33e 4473 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4474 * unexec.h: New file.
ce701a33
PE
4475 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4476 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4477 Depend on unexec.h.
4478 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4479 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4480 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4481 Change as necessary to match prototype in unexec.h.
ce701a33 4482
01f44d5a
PE
4483 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4484 shadowing.
4f63c6bb 4485 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4486
a6670b0b
PE
4487 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4488 Rename locals to avoid shadowing.
4489
cef2010d 4490 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4491 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4492
d4d7173a
PE
4493 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4494
f08b802a
PE
4495 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4496 warning when compiling print.c.
4497
3ddb0639
PE
4498 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4499 instead of using an uninitialized var.
5ad03b97 4500 (font_sort_entities): Mark var as initialized.
3ddb0639 4501
170a2692
PE
4502 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4503
e663c700
PE
4504 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4505 pointers to constants.
89bc529a 4506 (font_parse_fcname): Remove unused vars.
7b81e2d0 4507 (font_delete_unmatched): Now static.
ea838e10 4508 (font_get_spec): Remove; unused.
13a547c6
PE
4509 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4510 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4511 Rename or move locals to avoid shadowing.
e663c700 4512
2a80c887 4513 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4514 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4515
1384fa33 4516 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4517 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4518
8b2c52e9
PE
4519 * alloc.c (mark_backtrace): Move decl from here ...
4520 * lisp.h: ... to here, so that it can be checked.
4521
475545b5 4522 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4523 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4524 (lisp_indirect_variable): Name an expression,
4525 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4526 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4527
b1349114 4528 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4529 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4530 Use const pointer when appropriate.
b1349114 4531
a2928364
PE
4532 * lisp.h (get_system_name, get_operating_system_release):
4533 Move decls here, to check interfaces.
4534 * process.c (get_operating_system_release): Move decl to lisp.h.
4535 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4536 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4537 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4538 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4539 (Fformat_time_string, Fencode_time, Finsert_char):
4540 (Ftranslate_region_internal, Fformat):
4541 Rename or remove local vars to avoid shadowing.
9710023e 4542 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4543
a415e694
PE
4544 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4545 avoid shadowing.
4546
8ef4622d
PE
4547 * lisp.h (eassert): Check that the argument compiles, even if
4548 ENABLE_CHECKING is not defined.
4549
946f9a5b
PE
4550 * data.c (Findirect_variable): Name an expression, to avoid
4551 gcc -Wbad-function-cast warning.
112396d6 4552 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4553 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4554 (Fmake_variable_buffer_local, Fmake_local_variable):
4555 Mark variables as initialized.
52746918 4556 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4557
e5aab7e7 4558 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4559 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4560 Rename locals to avoid shadowing.
dff45157
PE
4561 (mark_stack): Move local variables into the #ifdef region where
4562 they're used.
7bc26fdb
PE
4563 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4564 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4565 needed otherwise.
4566 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4567 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4568 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4569
e5aab7e7
PE
4570 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4571 avoids undefined behavior in theory.
4572
4da60324
PE
4573 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4574
88043301
PE
4575 Use functions, not macros, for up- and down-casing (Bug#8254).
4576 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4577 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4578 to use the following functions instead of these macros.
4579 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4580 EMACS_INT, since callers assume the returned value fits in int.
4581 (upcase1): Likewise, for UPCASE_TABLE.
4582 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4583 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4584 the race-condition problem in the old DOWNCASE.
88043301 4585
19ed5445
PE
4586 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4587 Rename locals to avoid shadowing.
4588 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4589 (regex_compile, re_search_2, re_match_2_internal):
4590 Remove unused local vars.
952db0d7
PE
4591 (FREE_VAR): Rewrite so as not to use empty "else",
4592 which gcc can warn about.
da053e48 4593 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4594 (RETALLOC_IF): Define only if needed.
4595 (WORDCHAR_P): Likewise. This one is never needed, but is used
4596 only in a comment talking about a compiler bug, so put inside
4597 the #if 0 of that comment.
4598 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4599 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4600 Remove; unused.
19ed5445 4601
1f3561e4 4602 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4603 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4604 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4605
ded6f8f7
PE
4606 * search.c (simple_search): Remove unused var.
4607
dbd37a95
PE
4608 * dired.c (compile_pattern): Move decl from here ...
4609 * lisp.h: ... to here, so that it can be checked.
4610 (struct re_registers): New forward decl.
4611
7e47afad
PE
4612 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4613
85f24f61
PE
4614 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4615 All uses changed.
4616 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4617 Rename locals to avoid shadowing.
5671df8f 4618 (Fvertical_motion): Mark locals as initialized.
85f24f61 4619
181aa2be 4620 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4621 (casify_region): Mark local as initialized.
181aa2be 4622
930d429c
PE
4623 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4624
7082eac6
PE
4625 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4626 New macros, so that the caller can use some names other than
4627 gcpro1, gcpro2, etc.
4628 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4629 of the new macros.
4630 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4631 argument, for consistency with GCPRO2_VAR, etc: it is now the
4632 prefix of the variable, not the variable itself. All uses
4633 changed.
38b2c076
PE
4634 * dired.c (directory_files_internal, file_name_completion):
4635 Rename locals to avoid shadowing.
4636
15206ed9
PE
4637 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4638 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4639 dired.c's scmp function, had undefined behavior.
4640 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4641 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4642 * buffer.h: ... to here, because these macros use current_buffer,
4643 and the new implementation with inline functions needs to have
4644 current_buffer in scope now, rather than later when the macros
4645 are used.
4646 (downcase, upcase1): New static inline functions.
4647 (DOWNCASE, UPCASE1): Reimplement using these functions.
4648 This avoids undefined behavior in expressions like
4649 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4650 from race conditions in accessing the global variables
4651 case_temp1 and case_temp2.
4652 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4653 * lisp.h (case_temp1, case_temp2): Remove their decls.
4654 * character.h (ASCII_CHAR_P): Move from here ...
4655 * lisp.h: ... to here, so that the inline functions mentioned
4656 above can use them.
4657
4a6bea26
PE
4658 * dired.c (directory_files_internal_unwind): Now static.
4659
f14b7e14
PE
4660 * fileio.c (file_name_as_directory, directory_file_name):
4661 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4662 Now static.
2893f146
PE
4663 (file_name_as_directory): Use const pointers when appropriate.
4664 (Fexpand_file_name): Likewise. In particular, newdir might
4665 point at constant storage, so make it a const pointer.
fd4ead52 4666 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4667 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4668 signedness issues.
f839df0c
PE
4669 (Fset_file_times, Finsert_file_contents, auto_save_error):
4670 Rename locals to avoid shadowing.
f14b7e14 4671
5716756e 4672 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4673 (Ftry_completion, Fall_completions): Rename or remove locals
4674 to avoid shadowing.
5716756e 4675
b4c3046a
PE
4676 * marker.c (bytepos_to_charpos): Remove; unused.
4677
b45db522
PE
4678 * lisp.h (verify_bytepos, count_markers): New decls,
4679 so that gcc does not warn that these functions aren't declared.
4680
85876d07
PE
4681 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4682 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4683 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4684 (copy_text): Remove unused local var.
85876d07 4685
03d78a21 4686 * filelock.c (within_one_second): Now static.
b3dd38ab 4687 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4688
5df8f01b
PE
4689 * buffer.c (fix_overlays_before): Mark locals as initialized.
4690 (fix_start_end_in_overlays): Likewise. This function should be
4691 simplified by using pointers-to-pointers, but that's a different
4692 matter.
b1d876f1 4693 (switch_to_buffer_1): Now static.
8f54f30a
PE
4694 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4695 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4696
a70072c9 4697 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4698 Fix pointer signedness issue.
edced198
PE
4699 (sys_subshell): Mark local as volatile if checking for lint,
4700 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4701 (MAXPATHLEN): Define only if needed.
a70072c9 4702
a0977c44
PE
4703 * process.c (serial_open, serial_configure): Move decls from here ...
4704 * systty.h: ... to here, so that they can be checked.
4705
a884fdcc
PE
4706 * fns.c (get_random, seed_random): Move extern decls from here ...
4707 * lisp.h: ... to here, so that they can be checked.
4708
604efe86 4709 * sysdep.c (reset_io): Now static.
b8950c94 4710 (wait_for_termination_signal): Remove; unused.
604efe86 4711
38fc62d9
PE
4712 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4713 (copy_keymap_item, append_key, push_text_char_description):
4714 Now static.
1004a21a 4715 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4716 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4717 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4718 (describe_map_tree):
4719 Rename locals to avoid shadowing.
38fc62d9 4720
2f2650da
PE
4721 * keyboard.c: Declare functions static if they are not used elsewhere.
4722 (echo_char, echo_dash, cmd_error, top_level_2):
4723 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4724 (read_char, kbd_buffer_get_event, make_lispy_position):
4725 (make_lispy_event, make_lispy_movement, apply_modifiers):
4726 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4727 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4728 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4729 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4730 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4731
a053e86c 4732 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4733 (mark_kboards): Move decl here ...
4734 * alloc.c (mark_kboards): ... from here.
a053e86c 4735
4752793e
PE
4736 * lisp.h (force_auto_save_soon): New decl.
4737
74f10ca7 4738 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4739 (DEFINE_DUMMY_FUNCTION): New macro.
4740 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4741 Use it.
c03cd23f
PE
4742 (main): Add casts to avoid warnings
4743 if GCC considers string literals to be constants.
74f10ca7 4744
022e70d4
PE
4745 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4746
59d6fe83
PE
4747 * dbusbind.c: Pointer signedness fixes.
4748 (xd_signature, xd_append_arg, xd_initialize):
4749 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4750 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4751 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4752 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4753
78320123
PE
4754 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4755 if GCC considers string literals to be constants.
49cebcca 4756 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4757
35ac2a97
SM
47582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4759
fb103ca9
SM
4760 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4761 (print_preprocess, print_object): New macro to fix last change.
4762
35ac2a97
SM
4763 * print.c (print_preprocess): Don't forget font objects.
4764
62973b41
JB
47652011-03-16 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * emacs.c (USAGE3): Doc fixes.
4768
0e48bb22
AS
47692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4770
4771 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4772 structure.
4773
7684e57b
JB
47742011-03-14 Juanma Barranquero <lekktu@gmail.com>
4775
4776 * lisp.h (VWindow_system, Qfile_name_history):
4777 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4778 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4779 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4780
4781 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4782 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4783
4784 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4785 * w32console.c (detect_input_pending, read_input_pending)
4786 (encode_terminal_code):
4787 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4788 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4789 (w32_system_caret_y, Qfile_name_history):
4790 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4791 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4792 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4793 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4794 * w32proc.c (Qlocal, report_file_error):
4795 * w32term.c (Vwindow_system, updating_frame):
4796 * w32uniscribe.c (initialized, uniscribe_font_driver):
4797 Remove unneeded extern declarations.
4798
2aa46d6c
CY
47992011-03-14 Chong Yidong <cyd@stupidchicken.com>
4800
c96bbc66 4801 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4802
cffc6f3b
CY
48032011-03-13 Chong Yidong <cyd@stupidchicken.com>
4804
4805 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4806 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4807 These macros can no longer be used for assignment.
4808
44f230aa
SM
4809 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4810 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4811 (record_buffer_markers, fetch_buffer_markers): New functions for
4812 recording and fetching special buffer markers.
4813 (set_buffer_internal_1, set_buffer_temp): Use them.
4814
4815 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4816
4817 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4818
4819 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4820 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4821
4822 * xdisp.c (hscroll_window_tree):
4823 (reconsider_clip_changes): Use PT instead of BUF_PT.
4824
d251f04b
EZ
48252011-03-13 Eli Zaretskii <eliz@gnu.org>
4826
4827 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4828 $(EMACS_ROOT)/lib/intprops.h.
4829
f0c77cd1
PE
48302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4831
3eca4629
PE
4832 Fix more problems found by GCC 4.5.2's static checks.
4833
7c86ee98
PE
4834 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4835 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4836 (xg_free_frame_widgets): Make it clear that a local variable is
4837 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4838 (gdk_window_get_screen): Make it clear that this macro is needed
4839 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4840 (int_gtk_range_get_value): New function, which avoids a diagnostic
4841 from gcc -Wbad-function-cast.
4842 (xg_set_toolkit_scroll_bar_thumb): Use it.
4843 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4844 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4845 (get_utf8_string, xg_get_file_with_chooser):
4846 Rename locals to avoid shadowing.
4847 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4848
41729b81
PE
4849 * xgselect.c (xg_select): Remove unused var.
4850
f0c77cd1
PE
4851 * image.c (four_corners_best): Mark locals as initialized.
4852 (gif_load): Initialize transparent_p to zero (Bug#8238).
4853 Mark another local as initialized.
ec6cf4c6 4854 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4855
ce0ad53d 4856 * image.c (clear_image_cache): Now static.
d5d5a617 4857 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4858 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4859 (x_edge_detection): Remove unnecessary cast that
4860 gcc -Wbad-function-cast diagnoses.
2037898d 4861 (gif_load): Fix pointer signedness.
6ae141d6
PE
4862 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4863 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4864
33383987 48652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4866
d32df629
PE
4867 Improve quality of tests for time stamp overflow.
4868 For example, without this patch (encode-time 0 0 0 1 1
4869 1152921504606846976) returns the obviously-bogus value (-948597
4870 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4871 reports time overflow. See
4872 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4873 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4874 * editfns.c: Include limits.h and intprops.h.
4875 (TIME_T_MIN, TIME_T_MAX): New macros.
4876 (time_overflow): Move earlier, to before first use.
4877 (hi_time, lo_time): New functions, for an accurate test for
4878 out-of-range times.
4879 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4880 (Fget_internal_run_time): Don't assume time_t fits in int.
4881 (make_time): Use list2 instead of Fcons twice.
4882 (Fdecode_time): More accurate test for out-of-range times.
4883 (check_tm_member): New function.
4884 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4885 (lisp_time_argument): Don't rely on undefined left-shift and
4886 right-shift behavior when checking for time stamp overflow.
8be6f318 4887
fe31d94c
PE
4888 * editfns.c (time_overflow): New function, refactoring common code.
4889 (Fformat_time_string, Fdecode_time, Fencode_time):
4890 (Fcurrent_time_string): Use it.
4891
8be6f318
PE
4892 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4893 * dired.c (make_time): Move to ...
4894 * editfns.c (make_time): ... here.
4895 * systime.h: Note the move.
4896
09d9db2c 48972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4898
126bc0dc
YM
4899 * fringe.c (update_window_fringes): Remove unused variables.
4900
c47cbdfd
YM
4901 * unexmacosx.c (copy_data_segment): Also copy __got section.
4902 (Bug#8223)
4903
7ac80be9
EZ
49042011-03-12 Eli Zaretskii <eliz@gnu.org>
4905
c96bbc66 4906 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4907 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4908 Constify `char *' arguments and their references according to
4909 prototypes in tparam.h.
4910
ecb0f94d 4911 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4912
7ac80be9
EZ
4913 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4914 Adapt all references accordingly.
4915
4916 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4917
ef1fd07e
TT
49182011-03-11 Tom Tromey <tromey@redhat.com>
4919
4920 * buffer.c (syms_of_buffer): Remove obsolete comment.
4921
7ef4b50c
EZ
49222011-03-11 Eli Zaretskii <eliz@gnu.org>
4923
4924 * termhooks.h (encode_terminal_code): Declare prototype.
4925
4926 * msdos.c (encode_terminal_code): Don't declare prototype.
4927
4928 * term.c (encode_terminal_code): Now external again, used by
4929 w32console.c and msdos.c.
4930
44f230aa
SM
4931 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4932 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4933
4b1ec863 49342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4935
1714f52b 4936 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4937
4b1ec863
PE
4938 * fringe.c (update_window_fringes): Mark locals as initialized
4939 (Bug#8227).
4940 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4941
524c7aa6
PE
4942 * alloc.c (mark_fringe_data): Move decl from here ...
4943 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4944 to check its interface.
4945 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4946
a5c0af81 4947 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4948 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4949 (fontset_font): Mark local as initialized.
a9a06e0b 4950 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4951
b4716021
PE
4952 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4953
811e9bac 4954 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4955 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4956 (x_own_selection, Fx_disown_selection_internal): Rename locals
4957 to avoid shadowing.
4958 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4959
7e3ab302
PE
4960 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4961 so that the caller can use some name other than gcpro1.
4962 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4963 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4964 (Fx_backspace_delete_keys_p):
4965 Use them to avoid shadowing, and rename vars to avoid shadowing.
4966 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4967 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4968 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4969 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4970 Remove unused locals.
7e3ab302
PE
4971 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4972 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4973 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4974 macros.
f78faa98 4975
e2b13473
PE
4976 * xterm.h (x_mouse_leave): New decl.
4977
77f23912
PE
4978 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4979 Remove unused functions.
cdf4ba58
PE
4980 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4981 (x_calc_absolute_position): Now static.
7411c686 4982 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4983 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4984 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4985 unless they are used.
38d0b34a
PE
4986 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4987 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4988 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4989 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4990 (x_error_catcher, x_connection_closed, x_error_handler):
4991 (x_error_quitter, xembed_send_message, x_iconify_frame):
4992 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4993 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4994 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4995
44f230aa
SM
4996 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4997 Rename or move locals to avoid shadowing.
6b463e58 4998 (tty_defined_color, merge_face_heights): Now static.
5967d051 4999 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5000 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5001 does not deduce is never used uninitialized.
73719eba
PE
5002 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5003 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5004
426994c3 5005 * terminal.c (store_terminal_param): Now static.
5489860b 5006
032f1620 5007 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5008 (set_frame_menubar): Remove unused local.
d4323972 5009 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5010 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5011 since they might point to immutable storage.
281585b0
PE
5012 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5013 since it's unused otherwise.
032f1620 5014
367c19e5 5015 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5016 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5017 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5018 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5019 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5020 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5021 does not deduce are never used uninitialized.
70739cbe 5022
07b48fa9
PE
5023 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5024
8868a238 5025 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5026 * window.c (window_loop, size_window):
5027 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5028
7e5cf297 5029 * window.c (display_buffer): Now static.
d6550a9f
PE
5030 (size_window): Mark variables that gcc -Wuninitialized
5031 does not deduce are never used uninitialized.
a586633d
PE
5032 * window.h (check_all_windows): New decl, to forestall
5033 gcc -Wmissing-prototypes diagnostic.
5b555da1 5034 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5035
f6095868
PE
5036 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5037 shadowing.
5038 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5039 Include <limits.h>.
5040 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5041 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5042 (load_charset_map): Mark variables that gcc -Wuninitialized
5043 does not deduce are never used uninitialized.
53df7c11 5044 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5045
f38b440c
PE
5046 * coding.c (coding_set_source, coding_set_destination):
5047 Use "else { /* comment */ }" rather than "else /* comment */;"
5048 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5049 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5050 a block, when the outer 'i' will do.
5051 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5052 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5053 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5054 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5055 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5056 Rename locals to avoid shadowing.
5057 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5058 * coding.c (emacs_mule_char, encode_invocation_designation):
5059 Now static, since they're not used elsewhere.
413bb2db 5060 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5061 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5062 (decode_coding_emacs_mule): Mark variables that gcc
5063 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5064 (detect_coding_iso_2022): Initialize a local variable that might
5065 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5066 this initialization is needed. (Bug#8211)
5f58e762
PE
5067 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5068 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5069 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5070 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5071 Remove unused macros.
f38b440c 5072
232b38b9 5073 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5074 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5075 * character.c (string_count_byte8): Likewise.
232b38b9 5076
fb90da1b
PE
5077 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5078 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5079
fb93dbc2
PE
5080 * chartab.c (copy_sub_char_table): Now static, since it's not used
5081 elsewhere.
5c156ace
PE
5082 (sub_char_table_ref_and_range, char_table_ref_and_range):
5083 Rename locals to avoid shadowing.
bbcd0949 5084 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5085
7d3b3862 5086 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5087 (BIDI_BOB): Remove unused macro.
7d3b3862 5088
6be7d3da
PE
5089 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5090 deduce are never used uninitialized.
c2ed9c8b 5091 * term.c (encode_terminal_code): Likewise.
6be7d3da 5092
75f8807f 5093 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5094
50938595
PE
5095 * tparam.h: New file.
5096 * term.c, tparam.h: Include it.
5097 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5098 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5099 Move these decls to tparam.h, and make them agree with what
5100 is actually in tparam.c. The previous trick of using incompatible
5101 decls in different modules does not conform to the C standard.
5102 All callers of tparam changed to use tparam's actual API.
5103 * tparam.c (tparam1, tparam, tgoto):
5104 Use const pointers where appropriate.
5105
fbceeba2
PE
5106 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5107 * cm.h (struct cm): Likewise.
5108 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5109 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5110 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5111 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5112 (turn_on_face, init_tty): Likewise.
5113 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5114
7f3f1250
PE
5115 * term.c (term_mouse_position): Rename local to avoid shadowing.
5116
e6ca6543
PE
5117 * alloc.c (mark_ttys): Move decl from here ...
5118 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5119
c40f8d15
AS
51202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5121
5122 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5123
cfe0661d
JB
51242011-03-09 Juanma Barranquero <lekktu@gmail.com>
5125
5126 * search.c (compile_pattern_1): Remove argument regp, unused since
5127 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5128 (compile_pattern): Don't pass it.
5129
0afb4571
J
51302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5131
5132 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5133 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5134 for ! HAVE_GTK3.
5135 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5136
5137 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5138
5139 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5140 gdk_window_get_screen, gdk_window_get_geometry,
5141 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5142 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5143 (xg_get_pixbuf_from_pixmap): New function.
5144 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5145 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5146 Call xg_get_pixbuf_from_pixmap instead of
5147 gdk_pixbuf_get_from_drawable.
5148 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5149 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5150 (xg_check_special_colors): Use GtkStyleContext and its functions
5151 for HAVE_GTK3.
5152 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5153 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5154 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5155 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5156 Call gtk_widget_get_preferred_size.
0afb4571
J
5157 (xg_frame_resized): gdk_window_get_geometry only takes 5
5158 parameters.
44f230aa
SM
5159 (xg_win_to_widget, xg_event_is_for_menubar):
5160 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5161 (xg_set_widget_bg): New function.
5162 (delete_cb): New function.
895009e1 5163 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5164 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5165 (xg_set_background_color): Call xg_set_widget_bg.
5166 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5167 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5168 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5169 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5170 if ! HAVE_GTK3.
5171 (update_frame_tool_bar): Call gtk_widget_hide.
5172 (xg_initialize): Use GDK_KEY_g.
5173
5174 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5175 if ! HAVE_GTK3
5176 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5177
5178 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5179 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5180 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5181
1c2cc4ef
JB
51822011-03-08 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * w32xfns.c (select_palette): Check success of RealizePalette against
5185 GDI_ERROR, not zero.
5186
33383987 5187See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5188
5189;; Local Variables:
5190;; coding: utf-8
aac0c6e3
MR
5191;; End:
5192
33383987 5193 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5194
5195 This file is part of GNU Emacs.
5196
5197 GNU Emacs is free software: you can redistribute it and/or modify
5198 it under the terms of the GNU General Public License as published by
5199 the Free Software Foundation, either version 3 of the License, or
5200 (at your option) any later version.
5201
5202 GNU Emacs is distributed in the hope that it will be useful,
5203 but WITHOUT ANY WARRANTY; without even the implied warranty of
5204 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5205 GNU General Public License for more details.
5206
5207 You should have received a copy of the GNU General Public License
5208 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.