* buffer.h (PTR_BYTE_POS): Don't assume a byte count fits in 'unsigned'.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e762cafe 12011-06-09 Paul Eggert <eggert@cs.ucla.edu>
666398f3 2
8f95c75c
PE
3 * buffer.h (PTR_BYTE_POS): Don't assume a byte count fits in 'unsigned'.
4
666398f3 5 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 6 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7
8 * data.c (Qcompiled_function): Now static.
9
c9d624c6
PE
102011-06-08 Paul Eggert <eggert@cs.ucla.edu>
11
c6f072e7
PE
12 * window.c (window_body_lines): Now static.
13
20ce5912
PE
14 * image.c (gif_load): Rename local to avoid shadowing.
15
9c4c5f81
PE
16 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
17 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
18 * alloc.c (make_save_value): Integer argument is now of type
19 ptrdiff_t, not int.
20 (mark_object): Use ptrdiff_t, not int.
21 * lisp.h (pD): New macro.
22 * print.c (print_object): Use it.
23
c0c5c8ae
PE
24 * alloc.c: Use EMACS_INT, not int, to count objects.
25 (total_conses, total_markers, total_symbols, total_vector_size)
26 (total_free_conses, total_free_markers, total_free_symbols)
27 (total_free_floats, total_floats, total_free_intervals, total_intervals)
28 (total_strings, total_free_strings):
29 Now EMACS_INT, not int. All uses changed.
30 (Fgarbage_collect): Compute overall total using a double, so that
31 integer overflow is less likely to be a problem. Check for overflow
32 when converting back to an integer.
5a25e253
PE
33 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
34 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
35 These were 'int' variables that could overflow on 64-bit hosts;
36 they were never used, so remove them instead of repairing them.
211a0b2a 37 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
38 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
39 Previously, this ceilinged at INT_MAX, but that doesn't work on
40 64-bit machines.
e46bb31a 41 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 42
c78baabf 43 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 44 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
45 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
46 when a (possibly-narrower) signed value would do just as well.
47 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 48
c9d624c6
PE
49 * alloc.c: Catch some string size overflows that we were missing.
50 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
51 for convenience in STRING_BYTES_MAX.
52 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
53 The definition here is exact; the one in lisp.h was approximate.
54 (allocate_string_data): Check for string overflow. This catches
55 some instances we weren't catching before. Also, it catches
56 size_t overflow on (unusual) hosts where SIZE_MAX <= min
57 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
58 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 59
c9d624c6
PE
60 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
61 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
62 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
63
353032ce
PE
64 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
65
2bccce07
PE
66 * alloc.c (Fmake_string): Check for out-of-range init.
67
f3d1777e
MR
682011-06-08 Martin Rudalics <rudalics@gmx.at>
69
496e208e
MR
70 * window.h (window): Add some new members to window structure -
71 normal_lines, normal_cols, new_total, new_normal, clone_number,
72 splits, nest, prev_buffers, next_buffers.
73 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 74 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 75
f3d1777e
MR
76 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
77 Remove.
496e208e
MR
78 (make_dummy_parent): Set new members of windows structure.
79 (make_window): Move down in code. Handle new members of window
80 structure.
81 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
82 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
83 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
84 (Fset_window_prev_buffers, Fwindow_next_buffers)
85 (Fset_window_next_buffers, Fset_window_clone_number): New
86 functions.
87 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
88 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
89 Doc-string fixes.
90 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
91 Argument WINDOW can be now internal window too.
92 (Fwindow_use_time): Move up in code.
93 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
94 Rewrite doc-string.
95 (Fset_window_configuration, saved_window)
96 (Fcurrent_window_configuration, save_window_save): Handle new
97 members of window structure.
b9e809c2
MR
98 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
99 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
100 (syms_of_window): New Lisp objects Qrecord_window_buffer,
101 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
102 Qget_mru_window, Qresize_root_window,
103 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
104 Qauto_buffer_name; staticpro them.
f3d1777e 105
abde8f8c
MR
1062011-06-07 Martin Rudalics <rudalics@gmx.at>
107
108 * window.c (Fwindow_total_size, Fwindow_left_column)
109 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
110 (Fwindow_list_1): New functions.
111 (window_box_text_cols): Replace with window_body_cols.
112 (Fwindow_width, Fscroll_left, Fscroll_right): Use
113 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
114 (delete_window, Fset_window_configuration): Call
115 delete_all_subwindows with window as argument.
116 (delete_all_subwindows): Take a window as argument and not a
117 structure. Rewrite.
190b47e6
MR
118 (window_loop): Remove handling of GET_LRU_WINDOW and
119 GET_LARGEST_WINDOW.
120 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
121
122 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
123 window_box_text_cols. delete_all_subwindows now takes a
124 Lisp_Object as argument.
abde8f8c
MR
125
126 * indent.c (compute_motion, Fcompute_motion): Use
127 window_body_cols instead of window_box_text_cols.
128
fa8a67e6
MR
129 * frame.c (delete_frame): Call delete_all_subwindows with root
130 window as argument.
131
a54e3482
DC
1322011-06-07 Daniel Colascione <dan.colascione@gmail.com>
133
134 * fns.c (Fputhash): Document return value.
135
60002bf5
CY
1362011-06-06 Chong Yidong <cyd@stupidchicken.com>
137
138 * image.c (gif_load): Implement gif89a spec "no disposal" method.
139
0c671da6 1402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 141
b862a52a 142 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 143
be44ca6c
PE
144 Check for overflow when converting integer to cons and back.
145 * charset.c (Fdefine_charset_internal, Fdecode_char):
146 Use cons_to_unsigned to catch overflow.
147 (Fencode_char): Use INTEGER_TO_CONS.
148 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
149 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
150 * data.c (long_to_cons, cons_to_long): Remove.
151 (cons_to_unsigned, cons_to_signed): New functions.
152 These signal an error for invalid or out-of-range values.
153 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
154 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
155 * font.c (Ffont_variation_glyphs):
156 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
157 * lisp.h: Include <intprops.h>.
158 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
159 (cons_to_signed, cons_to_unsigned): New decls.
160 (long_to_cons, cons_to_long): Remove decls.
161 * undo.c (record_first_change): Use INTEGER_TO_CONS.
162 (Fprimitive_undo): Use CONS_TO_INTEGER.
163 * xfns.c (Fx_window_property): Likewise.
164 * xselect.c: Include <limits.h>.
165 (x_own_selection, selection_data_to_lisp_data):
166 Use INTEGER_TO_CONS.
167 (x_handle_selection_request, x_handle_selection_clear)
168 (x_get_foreign_selection, Fx_disown_selection_internal)
169 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
170 (lisp_data_to_selection_data): Use cons_to_unsigned.
171 (x_fill_property_data): Use cons_to_signed.
172 Report values out of range.
173
d1f3d2af
PE
174 Check for buffer and string overflow more precisely.
175 * buffer.h (BUF_BYTES_MAX): New macro.
176 * lisp.h (STRING_BYTES_MAX): New macro.
177 * alloc.c (Fmake_string):
178 * character.c (string_escape_byte8):
179 * coding.c (coding_alloc_by_realloc):
180 * doprnt.c (doprnt):
181 * editfns.c (Fformat):
182 * eval.c (verror):
183 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
184 since they may not be the same number.
185 * editfns.c (Finsert_char):
186 * fileio.c (Finsert_file_contents):
187 Likewise for BUF_BYTES_MAX.
188
dd52fcea
PE
189 * image.c: Use ptrdiff_t, not int, for sizes.
190 (slurp_file): Switch from int to ptrdiff_t.
191 All uses changed.
192 (slurp_file): Check that file size fits in both size_t (for
193 malloc) and ptrdiff_t (for sanity and safety).
194
7f9bbdbb
PE
195 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
196 if b->modtime has its maximal value.
197
dfe18f82
PE
198 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
199
84acfcf0
PE
200 Don't assume time_t can fit into int.
201 * buffer.h (struct buffer.modtime): Now time_t, not int.
202 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
203 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
204
ccd9a01a
PE
205 Minor fixes for signed vs unsigned integers.
206 * character.h (MAYBE_UNIFY_CHAR):
207 * charset.c (maybe_unify_char):
208 * keyboard.c (read_char, reorder_modifiers):
209 XINT -> XFASTINT, since the integer must be nonnegative.
210 * ftfont.c (ftfont_spec_pattern):
211 * keymap.c (access_keymap, silly_event_symbol_error):
212 XUINT -> XFASTINT, since the integer must be nonnegative.
213 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
214 since it makes no difference and we prefer signed.
215 * keyboard.c (record_char): Use XUINT when all the neighbors do.
216 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
217 nonnegative.
218
d6d100dd
SM
2192011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
220
221 * window.h (Fwindow_frame): Declare.
222
2b6148e4
PE
2232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
224
225 * alloc.c: Simplify handling of large-request failures (Bug#8800).
226 (SPARE_MEMORY): Always define.
227 (LARGE_REQUEST): Remove.
228 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
229
f230ecc9
MR
2302011-06-06 Martin Rudalics <rudalics@gmx.at>
231
727e958e
MR
232 * lisp.h: Move EXFUNS for Fframe_root_window,
233 Fframe_first_window and Fset_frame_selected_window to window.h.
234
235 * window.h: Move EXFUNS for Fframe_root_window,
236 Fframe_first_window and Fset_frame_selected_window here from
237 lisp.h.
238
239 * frame.c (Fwindow_frame, Fframe_first_window)
240 (Fframe_root_window, Fframe_selected_window)
241 (Fset_frame_selected_window): Move to window.c.
242 (Factive_minibuffer_window): Move to minibuf.c.
243 (Fother_visible_frames_p): New function.
244
245 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
246
f230ecc9
MR
247 * window.c (decode_window, decode_any_window): Move up in code.
248 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
249 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
250 (Fwindow_buffer): Move up and rewrite doc-string.
251 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
252 (Fwindow_prev): New functions.
727e958e
MR
253 (Fwindow_frame): Move here from frame.c. Accept any window as
254 argument.
255 (Fframe_root_window, Fframe_first_window)
256 (Fframe_selected_window): Move here from frame.c. Accept frame
257 or arbitrary window as argument. Update doc-strings.
258 (Fminibuffer_window): Move up in code.
259 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
260 (Fset_frame_selected_window): Move here from frame.c.
261 Marginal rewrite.
727e958e
MR
262 (Fselected_window, select_window, Fselect_window): Move up in
263 code. Minor doc-string fixes.
f230ecc9 264
4d09bcf6
PE
2652011-06-06 Paul Eggert <eggert@cs.ucla.edu>
266
267 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
268 Do not assume that spare memory exists; that assumption is valid
269 only if SYSTEM_MALLOC.
270 (LARGE_REQUEST): New macro, so that the issue of large requests
271 is separated from the issue of spare memory.
272
810928a2
AS
2732011-06-05 Andreas Schwab <schwab@linux-m68k.org>
274
172418ad
AS
275 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
276 format. (Bug#8806)
277
43f862f7
AS
278 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
279
810928a2
AS
280 * xfns.c (x_set_scroll_bar_default_width): Move declarations
281 before statements.
282
a059fe24
JD
2832011-06-05 Jan Djärv <jan.h.d@swipnet.se>
284
285 * gtkutil.c (xg_get_default_scrollbar_width): New function.
286
287 * gtkutil.h: Declare xg_get_default_scrollbar_width.
288
289 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
290 min width by calling x_set_scroll_bar_default_width (Bug#8505).
291
989bf368
JB
2922011-06-05 Juanma Barranquero <lekktu@gmail.com>
293
294 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
295
4b80f674
CY
2962011-06-04 Chong Yidong <cyd@stupidchicken.com>
297
298 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
299 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
300 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
301 New error handlers.
4b80f674
CY
302 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
303 Obey Vx_select_enable_clipboard_manager. Catch errors in
304 x_clipboard_manager_save (Bug#8779).
305 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 306 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 307
99a33b77 3082011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
309
310 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
311
99a33b77 3122011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
313
314 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
315 in the current matrix if keep_current_p is non-zero.
316
8264569d
EZ
3172011-06-04 Eli Zaretskii <eliz@gnu.org>
318
319 * bidi.c (bidi_level_of_next_char): Fix last change.
320
57f97249
EZ
3212011-06-03 Eli Zaretskii <eliz@gnu.org>
322
fec2107c 323 Support bidi reordering of text covered by display properties.
57f97249 324
fec2107c
EZ
325 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
326 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
327 (bidi_cache_search, bidi_cache_iterator_state)
328 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
329 (bidi_level_of_next_char, bidi_move_to_visually_next):
330 Support character positions inside a run of characters covered by a
fec2107c
EZ
331 display string.
332 (bidi_paragraph_init, bidi_resolve_explicit_1)
333 (bidi_level_of_next_char): Call bidi_fetch_char and
334 bidi_fetch_char_advance instead of FETCH_CHAR and
335 FETCH_CHAR_ADVANCE.
336 (bidi_init_it): Initialize new members.
337 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
338 definitions.
339 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
340 instead of using explicit *_CHAR codes.
d6d100dd
SM
341 (bidi_resolve_explicit, bidi_resolve_weak):
342 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
343 bidirectional text is supported only in multibyte buffers.
344 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
345 it to initialize the frame_window_p member of struct bidi_it.
346 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
347 (bidi_resolve_explicit, bidi_resolve_weak)
348 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
349 bidi_it->nchars is non-positive.
350 (bidi_level_of_next_char): Don't try to lookup the cache for the
351 next/previous character if nothing is cached there yet, or if we
352 were just reseat()'ed to a new position.
c40e2fb2 353
0e14fe90
EZ
354 * xdisp.c (set_cursor_from_row): Set start and stop points
355 according to the row's direction when priming the loop that looks
356 for the glyph on which to display cursor.
357 (single_display_spec_intangible_p): Function deleted.
358 (display_prop_intangible_p): Reimplement to call
359 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
360 Accept 3 additional arguments needed by handle_display_spec.
361 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
362 values: lists, `(when COND...)' forms, etc.
363 (single_display_spec_string_p): Support property values that are
364 lists with the argument STRING its top-level element.
365 (display_prop_string_p): Fix the condition for processing a
366 property that is a list to be consistent with handle_display_spec.
fec2107c 367 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
368 last portion of handle_display_prop.
369 (compute_display_string_pos): Accept additional argument
370 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
371 value of a `display' property is a "replacing spec".
372 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
373 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
374 the display property, but just return a value indicating whether
375 the display property will replace the characters it covers.
376 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
377 frame_window_p members of struct bidi_it.
d6d100dd
SM
378 (compute_display_string_pos, compute_display_string_end):
379 New functions.
fec2107c
EZ
380 (push_it): Accept second argument POSITION, where pop_it should
381 jump to continue iteration.
382 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 383
fec2107c
EZ
384 * keyboard.c (adjust_point_for_property): Adjust the call to
385 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
386
387 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
388 (bidi_init_it): Update prototypes.
389 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
390 (compute_display_string_pos, compute_display_string_end):
391 Declare prototypes.
fec2107c
EZ
392 (struct bidi_it): New members nchars and disp_pos. ch_len is now
393 EMACS_INT.
fc6f18ce 394
40087514 3952011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 396
57f53182
PE
397 Malloc failure behavior now depends on size of allocation.
398 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
399 * lisp.h: Change signatures accordingly.
400 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
401 All callers changed. (Bug#8762)
402
403 * gnutls.c: Use Emacs's memory allocators.
404 Without this change, the gnutls library would invoke malloc etc.
405 directly, which causes problems on non-SYNC_INPUT hosts, and which
406 runs afoul of improving memory_full behavior. (Bug#8761)
407 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
408 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
409 xfree instead of the default malloc, realloc, free.
410 (Fgnutls_boot): No need to check for memory allocation failure,
411 since xmalloc does that for us.
412
ac32cd99 413 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
414 * category.c (hash_get_category_set):
415 * ccl.c (ccl_driver):
416 * charset.c (Fdefine_charset_internal):
417 * charset.h (struct charset.hash_index):
418 * composite.c (get_composition_id, gstring_lookup_cache)
419 (composition_gstring_put_cache):
420 * composite.h (struct composition.hash_index):
421 * dispextern.h (struct image.hash):
422 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
423 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
424 (hashfn_equal, hashfn_user_defined, make_hash_table)
425 (maybe_resize_hash_table, hash_lookup, hash_put)
426 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
427 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
428 (Fsxhash, Fgethash, Fputhash, Fmaphash):
429 * image.c (make_image, search_image_cache, lookup_image)
430 (xpm_put_color_table_h):
431 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 432 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
433 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
434 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
435 * alloc.c (allocate_vectorlike):
436 Check for overflow in vector size calculations.
437 * ccl.c (ccl_driver):
438 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
439 * fns.c, image.c: Remove unnecessary static decls that would otherwise
440 need to be updated by these changes.
40087514
PE
441 * fns.c (make_hash_table, maybe_resize_hash_table):
442 Check for integer overflow with large hash tables.
0de4bb68
PE
443 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
444 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
445 (SXHASH_REDUCE): New macro.
446 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
447 Use it instead of discarding useful hash info with large hash values.
448 (sxhash_float): New function.
449 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
450 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
451 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
452 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
453 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
454 Adjust signatures to match updated version of code.
455 (consing_since_gc): Now EMACS_INT, since a single hash table can
456 use more than INT_MAX bytes.
457
698d32e2
DN
4582011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
459
460 Make it possible to build with GCC-4.6+ -O2 -flto.
461
462 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
463
fd6fa53f
SM
4642011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
465
466 * minibuf.c (get_minibuffer, read_minibuf_unwind):
467 Call minibuffer-inactive-mode.
468
864db017
JB
4692011-05-31 Juanma Barranquero <lekktu@gmail.com>
470
471 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
472 Update dependencies.
473
2ad0baf4
DN
4742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
475
476 * data.c (init_data): Remove code for UTS, this system is not
477 supported anymore.
478
4fcc2638
DN
4792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
480
481 Don't force ./temacs to start in terminal mode.
482
483 * frame.c (make_initial_frame): Initialize faces in all cases, not
484 only when CANNOT_DUMP is defined.
485 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
486
c56e0fd5
DN
4872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
488
489 * dispnew.c (add_window_display_history): Use const for the string
490 pointer. Remove declaration, not needed.
491
333d54da 4922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 493
55d4c1b2 494 Use 'inline', not 'INLINE'.
333d54da 495 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
496 * alloc.c, fontset.c (INLINE): Remove.
497 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
498 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
499 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
500 * gmalloc.c (register_heapinfo): Use inline unconditionally.
501 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
502
738db178
DN
5032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
504
505 Make it possible to run ./temacs.
506
507 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
508 syms_of_callproc does the same thing. Remove test for
509 "initialized", do it in the caller.
510 * emacs.c (main): Avoid calling set_initial_environment when dumping.
511
620c53a6
SM
5122011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
513
514 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
515 (read_minibuf): Use get_minibuffer.
516 (syms_of_minibuf): Use DEFSYM.
517 (Qmetadata): New var.
518 * data.c (Qbuffer): Don't make it static.
519 (syms_of_data): Use DEFSYM.
520
e003a292
PE
5212011-05-31 Paul Eggert <eggert@cs.ucla.edu>
522
523 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
524 (CCL_CODE_MIN): New macro.
525
ed008a6d
PE
5262011-05-30 Paul Eggert <eggert@cs.ucla.edu>
527
3687c2ef
PE
528 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
529
ed008a6d
PE
530 * eval.c (Qdebug): Now static.
531 * lisp.h (Qdebug): Remove decl. This reverts a part of the
532 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
533 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
534
d66c4c7c
CY
5352011-05-29 Chong Yidong <cyd@stupidchicken.com>
536
537 * image.c: Various fixes to ImageMagick code comments.
538 (Fimagemagick_types): Doc fix.
539
5fbc2025
PE
5402011-05-29 Paul Eggert <eggert@cs.ucla.edu>
541
0196f88a
PE
542 Minor fixes prompted by GCC 4.6.0 warnings.
543
544 * xselect.c (converted_selections, conversion_fail_tag): Now static.
545
5fbc2025
PE
546 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
547 (x_clipboard_manager_save_all): Move extern decl to ...
548 * xterm.h: ... here, so that it can be checked for consistency.
549
1dd3c2d9
CY
5502011-05-29 Chong Yidong <cyd@stupidchicken.com>
551
552 * xselect.c (x_clipboard_manager_save_frame)
553 (x_clipboard_manager_save_all): New functions.
554 (Fx_clipboard_manager_save): Lisp function deleted.
555
556 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
557 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
558
559 * xterm.h: Update prototype.
560
5ba6571d
WX
5612011-05-28 William Xu <william.xwl@gmail.com>
562
563 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
564 exiting (Bug#8239).
565
3eaff834
JM
5662011-05-28 Jim Meyering <meyering@redhat.com>
567
e1900994 568 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
569 * fns.c (to_uchar): Define.
570 (crypto_hash_function): Use it to convert some newly-signed
571 variables to unsigned, to avoid sign-extension bugs. For example,
572 without this change, (md5 "truc") would evaluate to
573 45723a2aff78ff4fff7fff1114760e62 rather than the expected
574 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 575 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 576
0f6990a7
PE
5772011-05-27 Paul Eggert <eggert@cs.ucla.edu>
578
579 Integer overflow fixes.
c8a9ca5a 580
08686060
PE
581 * dbusbind.c: Serial number integer overflow fixes.
582 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
583 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
584 to hold a serial number that is too large for a fixnum.
585 (Fdbus_method_return_internal, Fdbus_method_error_internal):
586 Check for serial numbers out of range. Decode any serial number
59568bf0 587 that was so large that it became a float. (Bug#8722)
08686060 588
2d1fc3c7
PE
589 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
590 (Fdbus_call_method, Fdbus_call_method_asynchronously):
591 Use XFASTINT rather than XUINT when numbers are nonnegative.
592 (xd_append_arg, Fdbus_method_return_internal):
593 (Fdbus_method_error_internal): Likewise. Also, for unsigned
594 arguments, check that Lisp number is nonnegative, rather than
59568bf0 595 silently wrapping negative numbers around. (Bug#8722)
30217ff0 596 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 597 (Bug#8722)
2d1fc3c7 598
c8a9ca5a
PE
599 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
600
519e1d69
PE
601 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
602
30569699
PE
603 ccl: add integer overflow checks
604 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
605 (IN_INT_RANGE): New macros.
606 (ccl_driver): Use them to check for integer overflow when
607 decoding a CCL program. Many of the new checks are whether XINT (x)
608 fits in int; it doesn't always, on 64-bit hosts. The new version
609 doesn't catch all possible integer overflows, but it's an
847044ea 610 improvement. (Bug#8719)
30569699 611
c11285dc
PE
612 * alloc.c (make_event_array): Use XINT, not XUINT.
613 There's no need for unsigned here.
614
fdccd48e
PE
615 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
616 This follows up to the 2011-05-06 change that substituted uintptr_t
617 for EMACS_INT. This case wasn't caught back then.
618
37910ab2
PE
619 Rework Fformat to avoid integer overflow issues.
620 * editfns.c: Include <float.h> unconditionally, as it's everywhere
621 now (part of C89). Include <verify.h>.
622 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
623 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
624 (Fformat): Avoid the prepass trying to compute sizes; it was only
625 approximate and thus did not catch overflow reliably. Instead, walk
626 through the format just once, formatting and computing sizes as we go,
627 checking for integer overflow at every step, and allocating a larger
628 buffer as needed. Keep track separately whether the format is
629 multibyte. Keep only the most-recently calculated precision, rather
630 than them all. Record whether each argument has been converted to
631 string. Use EMACS_INT, not int, for byte and char and arg counts.
632 Support field widths and precisions larger than INT_MAX. Avoid
633 sprintf's undefined behavior with conversion specifications such as %#d
634 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
635 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
636 formatting out-of-range floating point numbers with int
637 formats. (Bug#8668)
638
2e6578fb
PE
639 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
640
0ae6bdee
PE
641 * data.c: Avoid integer truncation in expressions involving floats.
642 * data.c: Include <intprops.h>.
643 (arith_driver): When there's an integer overflow in an expression
644 involving floating point, convert the integers to floating point
645 so that the resulting value does not suffer from catastrophic
646 integer truncation. For example, on a 64-bit host (* 4
647 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
648 Do not rely on undefined behavior after integer overflow.
649
de883a70
PE
650 merge count_size_as_multibyte, parse_str_to_multibyte
651 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 652 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
653 Check for integer overflow.
654 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
655 since it's now a duplicate of the other. This is more of
656 a character than a buffer op, so better that it's in character.c.
657 * fns.c, print.c: Adjust to above changes.
658
2ff916cb
PE
6592011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
660
661 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
662
f1b54466
PE
6632011-05-27 Paul Eggert <eggert@cs.ucla.edu>
664
fb1ac845
PE
665 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
666 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
667 (x_clipboard_manager_save): Now static.
668 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
669
f1b54466
PE
670 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
671 (crypto_hash_function): Now static.
672 Fix pointer signedness problems. Avoid unnecessary initializations.
673
a9f737ee
CY
6742011-05-27 Chong Yidong <cyd@stupidchicken.com>
675
676 * termhooks.h (Vselection_alist): Make it terminal-local.
677
678 * terminal.c (create_terminal): Initialize it.
679
680 * xselect.c: Support for clipboard managers.
681 (Vselection_alist): Move to termhooks.h as terminal-local var.
682 (LOCAL_SELECTION): New macro.
683 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
684 (symbol_to_x_atom): Remove gratuitous arg.
685 (x_handle_selection_request, lisp_data_to_selection_data)
686 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
687 (x_own_selection, x_get_local_selection, x_convert_selection):
688 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
689 (some_frame_on_display): Delete unused function.
690 (Fx_own_selection_internal, Fx_get_selection_internal)
691 (Fx_disown_selection_internal, Fx_selection_owner_p)
692 (Fx_selection_exists_p): New optional frame arg.
693 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
694 (x_handle_selection_clear): Don't treat other terminals with the
695 same keyboard specially. Use the terminal-local Vselection_alist.
696 (x_clear_frame_selections): Use Frun_hook_with_args.
697
698 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
699
700 * xterm.h: Add support for those atoms.
701
e067f0c1
CY
7022011-05-26 Chong Yidong <cyd@stupidchicken.com>
703
704 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
705 (converted_selections, conversion_fail_tag): New global variables.
706 (x_selection_request_lisp_error): Free the above.
707 (x_get_local_selection): Remove unnecessary code.
708 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
709 of converted selections stored in converted_selections.
710 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
711 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
712 (x_convert_selection): New function.
713 (x_handle_selection_event): Simplify.
714 (x_get_foreign_selection): Don't ignore incoming requests while
715 waiting for an answer; this will fail when we implement
716 SAVE_TARGETS, and seems unnecessary anyway.
717 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
718 (Vx_sent_selection_functions): Doc fix.
719
0f4aebc0
LL
7202011-05-26 Leo Liu <sdl.web@gmail.com>
721
722 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
723
e61124cd
YM
7242011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
725
726 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
727
728 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
729 for fringe update if it has periodic bitmap.
730 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
731 and fringe_bitmap_periodic_p.
732
733 * fringe.c (get_fringe_bitmap_data): New function.
734 (draw_fringe_bitmap_1, update_window_fringes): Use it.
735 (update_window_fringes): Record periodicity of fringe bitmap in glyph
736 row. Mark glyph row for fringe update if periodicity changed.
737
738 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
739 for fringe update unless it has periodic bitmap.
740
f16d9837
KH
7412011-05-25 Kenichi Handa <handa@m17n.org>
742
743 * xdisp.c (get_next_display_element): Set correct it->face_id for
744 a static composition.
745
e1b90ef6
LL
7462011-05-24 Leo Liu <sdl.web@gmail.com>
747
748 * deps.mk (fns.o):
749 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
750
751 * fns.c (crypto_hash_function, Fsha1): New function.
752 (Fmd5): Use crypto_hash_function.
753 (syms_of_fns): Add Ssha1.
754
7400048f
PE
7552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
756
757 * gnutls.c: Remove unused macros.
758 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
759 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
760 Remove macros that are defined and never used.
761 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
762
abb71cf4
CY
7632011-05-22 Chong Yidong <cyd@stupidchicken.com>
764
765 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
766 (Fx_get_selection_internal): Minor cleanup.
767 (Fx_own_selection_internal): Rename arguments for consistency with
768 select.el.
769
6307db39
PE
7702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
771
772 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
773
f3d4e0a4
CY
7742011-05-22 Chong Yidong <cyd@stupidchicken.com>
775
776 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
777
4d8ade89
YM
7782011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
779
780 * dispnew.c (scrolling_window): Don't exclude the case that the
781 last enabled row in the desired matrix touches the bottom boundary.
782
32078c8d
GM
7832011-05-21 Glenn Morris <rgm@gnu.org>
784
785 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
786 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
787 and add some more files.
32078c8d 788
7285dc67
EZ
7892011-05-20 Eli Zaretskii <eliz@gnu.org>
790
791 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
792 report_file_error introduced by the change from 2011-05-07.
793
89d1bd22
PE
7942011-05-20 Paul Eggert <eggert@cs.ucla.edu>
795
796 * systime.h (Time): Define only if emacs is defined.
797 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
798 where the include path doesn't have X11/X.h by default. See
799 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
800
e23640bb 8012011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
802
803 * composite.c (find_automatic_composition): Fix previous change.
804
b9704ad9
GM
8052011-05-20 Glenn Morris <rgm@gnu.org>
806
807 * lisp.mk: New file, split from Makefile.in.
808 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
809 (shortlisp): Remove.
810 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
811
4a720484
GM
8122011-05-19 Glenn Morris <rgm@gnu.org>
813
814 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
815 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
816 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
817 (lisp): Set the order to that of loadup.el.
818 (shortlisp): Make it a copy of $lisp.
819 (SOME_MACHINE_LISP): Remove.
820 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
821 Use just $shortlisp, not $SOME_MACHINE_LISP too.
822
a28d4396
KH
8232011-05-18 Kenichi Handa <handa@m17n.org>
824
825 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
826 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
827 (find_automatic_composition): Mostly rewrite for efficiency.
828
a2b1fa8e
JB
8292011-05-18 Juanma Barranquero <lekktu@gmail.com>
830
831 * makefile.w32-in: Update dependencies.
832
8e1f5610
CS
8332011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
834
835 * menu.c: Include limits.h (fixes the MS-Windows build broken by
836 revision 104625).
837
7025ee00 8382011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 839
cdfa6eab
PE
840 Fix some integer overflow issues, such as string length overflow.
841
06d6db33
PE
842 * insdel.c (count_size_as_multibyte): Check for string overflow.
843
2b4560a8
PE
844 * character.c (lisp_string_width): Check for string overflow.
845 Use EMACS_INT, not int, for string indexes and lengths; in
846 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
847 the resulting string length overflows an EMACS_INT; instead,
848 report a string overflow if no precision given. When checking for
849 precision exhaustion, use a check that cannot possibly have
850 integer overflow. (Bug#8675)
851 * character.h (lisp_string_width): Adjust to new signature.
852
cb93f9be
PE
853 * alloc.c (string_overflow): New function.
854 (Fmake_string): Use it. This doesn't change behavior, but saves
855 a few bytes and will simplify future changes.
856 * character.c (string_escape_byte8): Likewise.
857 * lisp.h (string_overflow): New decl.
858
1a1f3366
PE
859 Fixups, following up to the user-interface timestamp change.
860 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
861 for UI timestamps, instead of unsigned long.
9fbd6841
PE
862 * msdos.c (mouse_get_pos): Likewise.
863 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
864 * w32gui.h (Time): Define by including "systime.h" rather than by
865 declaring it ourselves. (Bug#8664)
866
d4e3e4d3
PE
867 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
868 * image.c (clear_image_cache): Likewise.
869
f6a24d19
PE
870 * term.c (term_mouse_position): Don't assume time_t wraparound.
871
08dc5ae6
PE
872 Be more systematic about user-interface timestamps.
873 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
874 and sometimes 'EMACS_UINT', to represent these timestamps.
875 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
876 This makes the code easier to follow, and makes it easier to catch
877 integer overflow bugs such as Bug#8664.
878 * frame.c (Fmouse_position, Fmouse_pixel_position):
879 Use Time, not unsigned long, for user-interface timestamps.
880 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
881 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
882 * keyboard.h (last_event_timestamp): Likewise.
883 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
884 * menu.h (xmenu_show): Likewise.
885 * term.c (term_mouse_position): Likewise.
886 * termhooks.h (struct input_event.timestamp): Likewise.
887 (struct terminal.mouse_position_hook): Likewise.
888 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
889 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
890 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
891 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
892 what it was before.
893 * menu.h, termhooks.h: Include "systime.h", for Time.
894
8e55734a
PE
895 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
896 Don't assume that the difference between two unsigned long values
897 can fit into an integer. At this point, we know button_down_time
898 <= event->timestamp, so the difference must be nonnegative, so
899 there's no need to cast the result if double-click-time is
900 nonnegative, as it should be; check that it's nonnegative, just in
901 case. This bug is triggered when events are more than 2**31 ms
86db42d2 902 apart (about 25 days). (Bug#8664)
8e55734a 903
841f1b75 904 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 905 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 906
3e26f69c
PE
907 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
908 that always fit in int. Use a sentinel instead of a counter, to
909 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
910 * frame.h (struct frame): Use int for menu_bar_items_used
911 instead of EMACS_INT, since it always fits in int.
3e26f69c 912
5cc152c0
PE
913 * menu.c (grow_menu_items): Check for int overflow.
914
d89eb65e
PE
915 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
916
5235bd3e
PE
917 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
918 Before, the code was not consistent. These values cannot exceed
919 2**31 - 1 so there's no need to make them unsigned.
920 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
921 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
922 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
923 as modifiers.
924 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
925
bc827e23
PE
926 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
927 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
928 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
929 presumably because the widths might not match.
930
78eb494e
PE
931 * window.c (size_window): Avoid needless test at loop start.
932
04f2d78b
CB
9332011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
934
935 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
936
d2fc7e3d 9372011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
938
939 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
940
d2fc7e3d 9412011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
942
943 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
944 `width' to `bar_area_x' and `bar_area_width', respectively.
945 (x_scroll_run): Take account of fringe background extension.
946
04f2d78b
CB
947 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
948 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
949 `bar_area_width', respectively.
950 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
951 background extension.
952
79b70037
GM
9532011-05-10 Jim Meyering <meyering@redhat.com>
954
955 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
956
2f142cc5
JB
9572011-05-10 Juanma Barranquero <lekktu@gmail.com>
958
959 * image.c (Finit_image_library): Return t for built-in image types,
960 like pbm and xbm. (Bug#8640)
961
57679c86
AS
9622011-05-09 Andreas Schwab <schwab@linux-m68k.org>
963
964 * w32menu.c (set_frame_menubar): Fix submenu allocation.
965
888c9e86
EZ
9662011-05-07 Eli Zaretskii <eliz@gnu.org>
967
b0512a1d
EZ
968 * w32console.c (Fset_screen_color): Doc fix.
969 (Fget_screen_color): New function.
970 (syms_of_ntterm): Defsubr it.
971
7285dc67
EZ
972 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
973 unlink the temporary file if Fcall_process didn't create it in the
974 first place.
975 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
976 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
977 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
978 cue to call_process_cleanup not to close that handle.
979
4d3fcc8e
BK
9802011-05-07 Ben Key <bkey76@gmail.com>
981
982 * makefile.w32-in: The bootstrap-temacs rule now makes use of
983 one of two shell specific rules, either bootstrap-temacs-CMD or
984 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
985 to the previous implementation of the bootstrap-temacs rule.
986 The bootstrap-temacs-CMD rule is similar to the previous
987 implementation of the bootstrap-temacs rule except that it
988 makes use of the ESC_CFLAGS variable instead of the CFLAGS
989 variable.
990
991 These changes, along with some changes to nt/configure.bat,
992 nt/gmake.defs, and nt/nmake.defs, are required to extend my
993 earlier fix to add support for --cflags and --ldflags options
994 that include quotes so that it works whether make uses cmd or
995 sh as the shell.
996
b4289b64
MA
9972011-05-06 Michael Albinus <michael.albinus@gmx.de>
998
999 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1000 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1001 is a constant.
1002 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1003 a string. Handle both cases.
1004 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1005 (Fdbus_register_method): Use Qinvalid_function.
1006
af4c0e28
JB
10072011-05-06 Juanma Barranquero <lekktu@gmail.com>
1008
1009 * makefile.w32-in: Update dependencies.
1010 (LISP_H): Add inttypes.h and stdin.h.
1011 (PROCESS_H): Add unistd.h.
1012
c51453d9
EZ
10132011-05-06 Eli Zaretskii <eliz@gnu.org>
1014
1015 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1016 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1017
8ff0ac3c 10182011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1019
4c4b566b
PE
1020 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1021
aab2b9b5
PE
1022 * term.c (vfatal): Remove stray call to va_end.
1023 It's not needed and the C Standard doesn't allow it here anyway.
1024
c378da0b
PE
1025 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1026 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1027
288b08c7
PE
1028 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1029 bytes.
1030
e3601888
PE
1031 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1032
db6c0e74
PE
1033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1034
dd5963ea
PE
1035 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1036
88c9450f
PE
1037 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1038
2f9442b8
PE
1039 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1040
c032b5f8
PE
1041 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1042 * charset.c (Fdefine_charset_internal): Don't initialize
1043 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1044 32-bit int (Bug#8600).
a108c10b
PE
1045
1046 * lread.c (read_integer): Be more consistent with string-to-number.
1047 Use string_to_number to do the actual conversion; this avoids
1048 rounding errors and fixes some other screwups. Without this fix,
1049 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1050 (digit_to_number): Move earlier, for benefit of read_integer.
1051 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1052 not a digit in any supported base. (Bug#8602)
a108c10b 1053
ad5f9eea
PE
1054 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1055
aec1708a
PE
1056 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1057 to match comment at start of function. This also removes a
1058 GCC warning about overflow in a 32+64-bit port.
1059
47be4ab5
PE
1060 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1061
371cac43
PE
1062 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1063 Reported by Stefan Monnier in
1064 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1065 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1066 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1067
d01a7826
PE
1068 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1069 (EMACS_UINTPTR): Likewise, with uintptr_t.
1070
7fd47d5c
PE
1071 * lisp.h: Prefer 64-bit EMACS_INT if available.
1072 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1073 on 32-bit hosts that have 64-bit int, so that they can access
1074 large files.
122b0c86
PE
1075 However, temporarily disable this change unless the temporary
1076 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1077
8727937b
PE
1078 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1079
8ac068ac
PE
1080 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1081 This removes an assumption that EMACS_INT and long are the same
1082 width as pointers. The assumption is true for Emacs porting targets
1083 now, but we want to make other targets possible.
1084 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1085 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1086 In the rest of the code, change types of integers that hold casted
1087 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1088 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1089 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1090 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1091 No need to cast type when ORing.
1092 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1093 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1094 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1095 assume EMACS_INT is the same width as char *.
1096 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1097 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1098 Remove no-longer-needed casts.
1099 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1100 (xg_tool_bar_help_callback, xg_make_tool_item):
1101 Use EMACS_INTPTR to hold an integer
1102 that will be cast to void *; this can avoid a GCC warning
1103 if EMACS_INT is not the same width as void *.
1104 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1105 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1106 (current_message_1, set_message_1):
1107 Use a local to convert to proper width without a cast.
1108 * xmenu.c (dialog_selection_callback): Likewise.
1109
ede49d71
PE
1110 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1111 Also, don't assume VALBITS / RAND_BITS is less than 5,
1112 and don't rely on undefined behavior when shifting a 1 left into
1113 the sign bit.
1114 * lisp.h (get_random): Change signature to match.
1115
2f30ecd0
PE
1116 * lread.c (hash_string): Use size_t, not int, for hash computation.
1117 Normally we prefer signed values; but hashing is special, because
1118 it's better to use unsigned division on hash table sizes so that
1119 the remainder is nonnegative. Also, size_t is the natural width
1120 for hashing into memory. The previous code used 'int', which doesn't
1121 retain enough info to hash well into very large tables.
1122 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1123
2a866e7b
PE
1124 * dbusbind.c: Don't possibly lose pointer info when converting.
1125 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1126 Use XPNTR rather than XHASH, so that the high-order bits of
1127 the pointer aren't lost when converting through void *.
1128
51639eac
PE
1129 * eval.c (Fautoload): Don't double-shift a pointer.
1130
92394119
PE
1131 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1132
dbdb9a7c
JB
11332011-05-06 Juanma Barranquero <lekktu@gmail.com>
1134
1135 * gnutls.c (DEF_GNUTLS_FN):
1136 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1137
db7a0b4f
AS
11382011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1139
1140 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1141 marker. (Bug#8610)
1142
f7ff1b0f 11432011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1144
1145 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1146 New version that can reserve upto 2GB of heap space.
1147
f7ff1b0f 11482011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1149
1150 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1151
639c109b
TZ
11522011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1153
1154 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1155 `gnutls_certificate_set_x509_key_file'.
1156
d2127135
JB
11572011-05-05 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1160 Update dependencies.
1161
e968f4f3
JB
11622011-05-04 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1165 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1166 Remove unused parameter `fildes'.
1167 * process.c (read_process_output, send_process): Don't pass it.
1168
84d358f0
JB
11692011-05-04 Juanma Barranquero <lekktu@gmail.com>
1170
1171 Fix previous change: the library cache is defined in w32.c.
1172 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1173 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1174
0898ca10
JB
11752011-05-04 Juanma Barranquero <lekktu@gmail.com>
1176
1177 Implement dynamic loading of GnuTLS on Windows.
1178
1179 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1180 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1181 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1182 Declare.
1183
1184 * gnutls.c (Qgnutls_dll): Define.
1185 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1186 (gnutls_*): Declare function pointers.
1187 (init_gnutls_functions): New function to initialize function pointers.
1188 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1189 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1190 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1191 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1192 (emacs_gnutls_write, emacs_gnutls_read)
1193 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1194 (Fgnutls_available_p): New function.
1195 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1196 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1197 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1198
1199 * image.c: Include w32.h.
1200 (Vimage_type_cache): Delete.
1201 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1202 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1203 (w32_delayed_load): Move to w32.c.
1204
1205 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1206
1207 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1208 (w32_delayed_load): Move from image.c. When loading a library, record
1209 its filename in the :loaded-from property of the library id.
1210 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1211 Initialize and staticpro them.
1212 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1213
1214 * process.c: Include lisp.h before w32.h, not after.
1215 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1216 instead of gnutls_record_check_pending.
1217
1218 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1219
ff4de4aa
TZ
12202011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1221
1222 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1223 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1224 as passed in.
1225
abe95abb
JD
12262011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1227
1228 * xterm.c (x_set_frame_alpha): Do not set property on anything
1229 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1230
e16e55d4
JB
12312011-05-02 Juanma Barranquero <lekktu@gmail.com>
1232
1233 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1234
bafcf6a5
JB
12352011-05-02 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1238 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1239 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1240 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1241 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1242 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1243 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1244 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1245 (Qgnutls_bootprop_callbacks_verify): Make static.
1246
e7a6747f
AS
12472011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1248
19ed11ba
AS
1249 * callproc.c: Indentation fixup.
1250
e7a6747f 1251 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1252 (wait_for_termination, interruptible_wait_for_termination):
1253 Move after wait_for_termination_1.
e7a6747f 1254
1ef14cb4
LMI
12552011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1256
1257 * sysdep.c (interruptible_wait_for_termination): New function
1258 which is like wait_for_termination, but allows keyboard
1259 interruptions.
1260
1261 * callproc.c (Fcall_process): Add (:file "file") as an option for
1262 the STDOUT buffer.
1263 (Fcall_process_region): Ditto.
1264
330d880c
EZ
12652011-04-30 Eli Zaretskii <eliz@gnu.org>
1266
8db90b73
EZ
1267 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1268 rather than `XVECTOR (FOO)->size'.
1269
330d880c
EZ
1270 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1271 inttypes.h, as a gnulib replacement is used if it not available in
1272 system headers.
1273
15cbd324
EZ
12742011-04-21 Eli Zaretskii <eliz@gnu.org>
1275
1276 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1277 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1278 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1279
1280 * coding.c (coding_alloc_by_realloc): Error out if destination
1281 will grow beyond MOST_POSITIVE_FIXNUM.
1282 (decode_coding_emacs_mule): Abort if there isn't enough place in
1283 charbuf for the composition carryover bytes. Reserve an extra
1284 space for up to 2 characters produced in a loop.
1285 (decode_coding_iso_2022): Abort if there isn't enough place in
1286 charbuf for the composition carryover bytes.
1287
12882011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1289
ae940cca
EZ
1290 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1291 aborting when %lld or %lll format is passed.
1292 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1293 %llo or %llx format is passed. (Bug#8545)
1294
03ab8921
EZ
1295 * window.c (window_scroll_line_based): Use a marker instead of
1296 simple variables to record original value of point. (Bug#7952)
1297
afda1437
EZ
1298 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1299 produced by %s or %c overflows available buffer space. (Bug#8545)
1300
f76dee0c
PE
13012011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1302
1303 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1304 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1305
fdc5744d
JB
13062011-04-28 Juanma Barranquero <lekktu@gmail.com>
1307
1308 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1309
638f053a
JB
13102011-04-28 Juanma Barranquero <lekktu@gmail.com>
1311
1312 * keyboard.c (Qdelayed_warnings_hook): Define.
1313 (command_loop_1): Run `delayed-warnings-hook'
1314 if Vdelayed_warnings_list is non-nil.
1315 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1316 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1317
d178f871
EZ
13182011-04-28 Eli Zaretskii <eliz@gnu.org>
1319
1320 * doprnt.c (doprnt): Don't return value smaller than the buffer
1321 size if the message was truncated. (Bug#8545).
1322
b124fd93
JB
13232011-04-28 Juanma Barranquero <lekktu@gmail.com>
1324
1325 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1326 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1327
e810457d
PE
13282011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1331
ea51cceb
JB
13322011-04-27 Juanma Barranquero <lekktu@gmail.com>
1333
1334 * makefile.w32-in: Update dependencies.
1335
94dcfacf
EZ
13362011-04-27 Eli Zaretskii <eliz@gnu.org>
1337
1338 Improve `doprnt' and its usage. (Bug#8545)
1339 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1340 `format_end'. Remove support for %l as a conversion specifier.
1341 Don't use xrealloc. Improve diagnostics when the %l size modifier
1342 is used. Update the commentary.
1343
1344 * eval.c (verror): Simplify calculation of size_t.
1345
1346 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1347 messages.
1348
f61f41d7
PE
13492011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1350
1351 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1352 change.
1353
96fb4434
PE
13542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1357 This makes this file independent of the recent pseudovector change.
1358
671875da 13592011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1360
69e9b5a3
PE
1361 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1362
b5f869a7 1363 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1364 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1365 Remove unused local.
c8926152 1366 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1367
841a1577 1368 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1369 GCC 4.6.0 optimizes based on type-based alias analysis.
1370 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1371 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1372 != &v->size, and therefore "v->size = 1; b->size = 2; return
1373 v->size;" must therefore return 1. This assumption is incorrect
1374 for Emacs, since it type-puns struct Lisp_Vector * with many other
1375 types. To fix this problem, this patch adds a new type struct
f904488f 1376 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1377 and pseudovectors, and helps optimizing compilers not get fooled
1378 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1379 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1380 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1381 the size member.
eab3844f
PE
1382 (XSETPVECTYPE): Rewrite in terms of new macro.
1383 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1384 This is a bit clearer, and further avoids the possibility of
1385 undesirable aliasing.
1386 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1387 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1388 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1389 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1390 (ASIZE): Now uses header.size rather than size.
1391 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1392 to avoid the hassle of writing XVECTOR (foo)->header.size.
1393 (struct vectorlike_header): New type.
eab3844f
PE
1394 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1395 object, to help avoid aliasing.
1396 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1397 (SUBRP): Likewise, since Lisp_Subr is a special case.
1398 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1399 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1400 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1401 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1402 changed to be "header.size" and "header.next".
1403 * buffer.h (struct buffer): Likewise.
1404 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1405 * frame.h (struct frame): Likewise.
1406 * process.h (struct Lisp_Process): Likewise.
1407 * termhooks.h (struct terminal): Likewise.
1408 * window.c (struct save_window_data, struct saved_window): Likewise.
1409 * window.h (struct window): Likewise.
1410 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1411 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1412 * buffer.c (init_buffer_once): Likewise.
1413 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1414 special case.
1415 * process.c (Fformat_network_address): Use local var for size,
1416 for brevity.
1417
0df1eac5
PE
1418 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1419
847ab9d1 1420 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1421 * data.c (atof): Remove decl; no longer used or needed.
1422 (digit_to_number): Move to lread.c.
1423 (Fstring_to_number): Use new string_to_number function, to be
1424 consistent with how the Lisp reader treats infinities and NaNs.
1425 Do not assume that floating-point numbers represent EMACS_INT
1426 without losing information; this is not true on most 64-bit hosts.
1427 Avoid double-rounding errors, by insisting on integers when
1428 parsing non-base-10 numbers, as the documentation specifies.
1429 * lisp.h (string_to_number): New decl, replacing ...
1430 (isfloat_string): Remove.
bc0a5c13 1431 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1432 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1433 appears to have been a coding error. Similarly, do not accept
1434 strings like +-1e0 as floating point numbers. Do not report
1435 overflow for integer overflows unless the base is not 10 which
1436 means we have no simple and reliable way to continue.
1437 Break out the floating-point parsing into a new
1438 function string_to_number, so that Fstring_to_number parses
1439 floating point numbers consistently with the Lisp reader.
04f2d78b 1440 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1441 (E_CHAR, EXP_INT): Remove, replacing with ...
1442 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1443 (string_to_number): New function, replacing isfloat_string.
1444 This function checks for valid syntax and produces the resulting
1445 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1446 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1447 so that overflow for non-base-10 numbers is reported only when
1448 there's no portable and simple way to convert to floating point.
452f4150 1449
67769ffc
PE
1450 * textprop.c (set_text_properties_1): Rewrite for clarity,
1451 and to avoid GCC warning about integer overflow.
1452
c20db43f
PE
1453 * intervals.h (struct interval): Use EMACS_INT for members
1454 where EMACS_UINT might cause problems. See
1455 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1456 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1457 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1458 All uses changed.
37aa2f85
PE
1459 (offset_intervals): Tell GCC not to worry about length overflow
1460 when negating a negative length.
c20db43f 1461
2538aa2f
PE
1462 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1463 (overrun_check_free): Likewise.
1464
f2d3008d
PE
1465 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1466 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1467 word size.
1468
ec8df744
PE
1469 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1470 (gnutls_make_error): Rename local to avoid shadowing.
1471 (gnutls_emacs_global_deinit): ifdef out; not used.
1472 (Fgnutls_boot): Use const for pointer to readonly storage.
1473 Comment out unused local. Fix pointer signedness problems.
1474
640ee02d
PE
1475 * lread.c (openp): Don't stuff size_t into an 'int'.
1476 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1477 about possible signed overflow.
1478
6048fb2a
PE
1479 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1480 (GDK_KEY_g): Don't define if already defined.
1481 (xg_prepare_tooltip): Avoid pointer signedness problem.
1482 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1483
fa3c87e1
PE
1484 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1485 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1486
2172544b
PE
1487 * xfns.c (Fx_window_property): Simplify a bit,
1488 to make a bit faster and to avoid GCC 4.6.0 warning.
1489 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1490
9b821a21
PE
1491 * fns.c (internal_equal): Don't assume size_t fits in int.
1492
3c616cfa
PE
1493 * alloc.c (compact_small_strings): Tighten assertion a little.
1494
c2982e87
PE
1495 Replace pEd with more-general pI, and fix some printf arg casts.
1496 * lisp.h (pI): New macro, generalizing old pEd macro to other
1497 conversion specifiers. For example, use "...%"pI"d..." rather
1498 than "...%"pEd"...".
1499 (pEd): Remove. All uses replaced with similar uses of pI.
1500 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1501 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1502 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1503 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1504 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1505 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1506 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1507 64-bit hosts.
1508 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1509 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1510 * print.c (safe_debug_print, print_object): Likewise.
1511 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1512 to int.
6f04d126
PE
1513 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1514 avoiding the 0 flag, which is not portable.
c2982e87
PE
1515 * process.c (Fmake_network_process): Use pI to avoid cast.
1516 * region-cache.c (pp_cache): Likewise.
1517 * xdisp.c (decode_mode_spec): Likewise.
1518 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1519 behavior on 64-bit hosts with printf arg.
6f04d126 1520 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1521 (x_stop_queuing_selection_requests): Likewise.
1522 (x_get_window_property): Don't truncate byte count to an 'int'
1523 when tracing.
0b432f21 1524
5e073ec7
PE
1525 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1526 here, since it parses constructs like leading '-' and spaces,
1527 which are not wanted; and it overflows with large numbers.
1528 Instead, simply match F[0-9]+, which is what is wanted anyway.
1529
36372bf9
PE
1530 * alloc.c: Remove unportable assumptions about struct layout.
1531 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1532 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1533 (allocate_vectorlike, make_pure_vector): Use the new macros,
1534 plus offsetof, to remove unportable assumptions about struct layout.
1535 These assumptions hold on all porting targets that I know of, but
1536 they are not guaranteed, they're easy to remove, and removing them
1537 makes further changes easier.
1538
0b432f21
PE
1539 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1540 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1541 (string_overrun_cookie): Now const. Use initializers that
1542 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1543 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1544 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1545 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1546 multiple of sizeof (EMACS_INT); it need not be, if
1547 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1548 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1549
895009e1
JB
15502011-04-26 Juanma Barranquero <lekktu@gmail.com>
1551
1552 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1553
6a7a1b0b
TZ
15542011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1555
1556 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1557 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1558 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1559
841a1577 15602011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1561
1562 * lisp.h (Qdebug): List symbol.
895009e1 1563 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1564 * keyboard.c (debug-on-event): New variable.
1565 (handle_user_signal): Break into debugger when debug-on-event
1566 matches the current signal symbol.
1567
f2d3ba6f
DN
15682011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1569
1570 * alloc.c (check_sblock, check_string_bytes)
1571 (check_string_free_list): Convert to standard C.
1572
42ce4c63
TZ
15732011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1574
1575 * w32.c (emacs_gnutls_push): Fix typo.
1576
825cd63c
EZ
15772011-04-25 Eli Zaretskii <eliz@gnu.org>
1578
fb11d64d
EZ
1579 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1580 "cast to pointer from integer of different size".
1581
825cd63c
EZ
1582 Improve doprnt and its use in verror. (Bug#8545)
1583 * doprnt.c (doprnt): Document the set of format control sequences
1584 supported by the function. Use SAFE_ALLOCA instead of always
1585 using `alloca'.
1586
1587 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1588 is one byte too soon. Don't use xrealloc; instead xfree and
1589 xmalloc anew.
1590
e061a11b
TZ
15912011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1592
1593 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1594 callbacks stage.
1595
1596 * gnutls.c: Renamed global_initialized to
1597 gnutls_global_initialized. Added internals for the
1598 :verify-hostname-error, :verify-error, and :verify-flags
1599 parameters of `gnutls-boot' and documented those parameters in the
1600 docstring. Start callback support.
1601 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1602 unless a fatal error occured. Call gnutls_alert_send_appropriate
1603 on error. Return error code.
1604 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1605 (emacs_gnutls_read): Likewise.
1606 (Fgnutls_boot): Return handshake error code.
1607 (emacs_gnutls_handle_error): New function.
1608 (wsaerror_to_errno): Likewise.
1609
1610 * w32.h (emacs_gnutls_pull): Add prototype.
1611 (emacs_gnutls_push): Likewise.
1612
1613 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1614 (emacs_gnutls_push): Likewise.
1615
16162011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1617
1618 * process.c (wait_reading_process_output): Check if GnuTLS
1619 buffered some data internally if no FDs are set for TLS
1620 connections.
1621
1622 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1623 (LIBS): Link to USER_LIBS.
1624 ($(BLD)/gnutls.$(0)): New target.
1625
fa6996bc
EZ
16262011-04-24 Eli Zaretskii <eliz@gnu.org>
1627
eb35682e
EZ
1628 * xdisp.c (handle_single_display_spec): Rename the
1629 display_replaced_before_p argument into display_replaced_p, to
1630 make it consistent with the commentary. Fix typos in the
1631 commentary.
1632
e2ad650c
EZ
1633 * textprop.c (syms_of_textprop): Remove dead code.
1634 (copy_text_properties): Delete obsolete commentary about an
1635 interface that was deleted long ago. Fix typos in the description
1636 of arguments.
1637
1b2de274
EZ
1638 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1639 to changes in oldXMenu/XMenu.h from 2011-04-16.
1640 <menu_help_message, prev_menu_help_message>: Constify.
1641 (IT_menu_make_room): menu->help_text is now `const char **';
1642 adjust.
1643
1644 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1645 to changes in oldXMenu/XMenu.h from 2011-04-16.
1646 (struct XMenu): Declare `help_text' `const char **'.
1647
1648 * xfaces.c <Qunspecified>: Make extern again.
1649
1650 * syntax.c: Include sys/types.h before including regex.h, as
1651 required by Posix.
1652
762b15be
EZ
1653 * doc.c (get_doc_string): Improve the format passed to `error'.
1654
1655 * doprnt.c (doprnt): Improve commentary.
1656
1657 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1658
1659 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1660 them with etags.
1661
f1052e5d
EZ
1662 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1663 changes in globals.h immediately force recompilation.
762b15be
EZ
1664 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1665 $(CURDIR)/s/ms-w32.h.
1666 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1667
fa6996bc
EZ
1668 * character.c (Fchar_direction): Function deleted.
1669 (syms_of_character): Don't defsubr it.
1670 <char-direction-table>: Deleted.
1671
e6c3da20
EZ
16722011-04-23 Eli Zaretskii <eliz@gnu.org>
1673
1674 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1675 * doprnt.c: Include limits.h.
1676 (SIZE_MAX): New macro.
04f2d78b
CB
1677 (doprnt): Return a size_t value. 2nd arg is now size_t.
1678 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1679 Improve overflow protection. Support `l' modifier for integer
1680 conversions. Support %l conversion. Don't assume an EMACS_INT
1681 argument for integer conversions and for %c.
1682
1683 * lisp.h (doprnt): Restore prototype.
1684
1685 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1686 $(SRC)/character.h.
1687
1688 * Makefile.in (base_obj): Add back doprnt.o.
1689
1690 * deps.mk (doprnt.o): Add back prerequisites.
1691 (callint.o): Depend on character.h.
1692
1693 * eval.c (internal_lisp_condition_case): Include the handler
1694 representation in the error message.
1695 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1696 when breaking from the loop.
1697
1698 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1699
1700 * callint.c (Fcall_interactively): When displaying error message
1701 about invalid control letter, pass the character's codepoint, not
1702 a pointer to its multibyte form. Improve display of the character
1703 in octal and display also its hex code.
1704
1705 * character.c (char_string): Use %x to display the (unsigned)
1706 codepoint of an invalid character, to avoid displaying a bogus
1707 negative value.
1708
1709 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1710 `error', not SYMBOL_NAME itself.
1711
1712 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1713 character arguments to `error'.
1714
1715 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1716 to `error' in error message about FINAL_CHAR argument. Make sure
1717 FINAL_CHAR is a character, and use %c when it is passed as
1718 argument to `error'.
1719
4ffd0d6b 17202011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1721
1722 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1723
1724 * w32.c: Include <time.h>.
1725 (sys_localtime): New function.
1726
4ffd0d6b 17272011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1728
1729 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1730
4ffd0d6b 1731 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1732
4ffd0d6b 17332011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1734
4ffd0d6b
GM
1735 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1736 zombies (Bug#8467).
aac0c6e3 1737
04c56954
EZ
17382011-04-19 Eli Zaretskii <eliz@gnu.org>
1739
1740 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1741 gl_state.e_property when gl_state.object is Qt.
1742
1743 * insdel.c (make_gap_larger): Remove limitation of buffer size
1744 to <= INT_MAX.
1745
16a43933
CY
17462011-04-18 Chong Yidong <cyd@stupidchicken.com>
1747
1748 * xdisp.c (lookup_glyphless_char_display)
1749 (produce_glyphless_glyph): Handle cons cell entry in
1750 glyphless-char-display.
1751 (Vglyphless_char_display): Document it.
1752
1753 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1754 glyphless-char-display.
1755
4581706e
CY
17562011-04-17 Chong Yidong <cyd@stupidchicken.com>
1757
1758 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1759
1760 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1761
1762 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1763 definition for no-X builds.
1764
4887c6e2 17652011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1766
fd35b6f9
PE
1767 Static checks with GCC 4.6.0 and non-default toolkits.
1768
5c1ccb01
PE
1769 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1770
006c5daa
PE
1771 * process.c (keyboard_bit_set): Define only if SIGIO.
1772 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1773 (send_process): Repair possible setjmp clobbering.
1774
efc736d3
PE
1775 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1776
4e2fe2e6
PE
1777 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1778
f97334a2
PE
1779 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1780
4e75f29d
PE
1781 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1782 Define only if needed.
1783
90efadd1
PE
1784 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1785 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1786 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1787
3c647824
PE
1788 * dispextern.h (struct redisplay_interface): Rename param
1789 to avoid shadowing.
e264f262 1790 * termhooks.h (struct terminal): Likewise.
761383f4 1791 * xterm.c (xembed_send_message): Likewise.
3c647824 1792
b58c5c4a
PE
1793 * insdel.c (make_gap_smaller): Define only if
1794 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1795
cad59032
PE
1796 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1797 it.
1798
c339dc2e
PE
1799 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1800 so that we aren't warned about unused symbols.
1801
91a3e27b
PE
1802 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1803
399c71d3 1804 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1805
8ffc96f5
PE
1806 * xfns.c (x_real_positions): Mark locals as initialized.
1807
eef9bc79
PE
1808 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1809
098db9dd
PE
1810 * xterm.c: Fix problems found by static analysis with other toolkits.
1811 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1812 (x_dispatch_event): Declare static if USE_GTK, and
1813 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1814 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1815 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1816 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1817 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1818
eb18f6cc
PE
1819 * xmenu.c (menu_help_callback): Pointer type fixes.
1820 Use const pointers when pointing at readonly data. Avoid pointer
1821 signedness clashes.
1822 (FALSE): Remove unused macro.
1823 (update_frame_menubar): Remove unused decl.
1824
1fe72bf8
PE
1825 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1826
60d9e1db
PE
1827 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1828 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1829 (single_menu_item): Rename local to avoid shadowing.
1830
39261c26
PE
1831 * keyboard.c (make_lispy_event): Remove unused local var.
1832
018c5e19
PE
1833 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1834 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1835
63d2b86e
PE
1836 * bitmaps: Change bitmaps from unsigned char back to the X11
1837 compatible char. Avoid the old compiler warnings about
1838 out-of-range initializers by using, for example, '\xab' rather
1839 than 0xab.
1840
aefd87e1
PE
1841 * xgselect.c (xgselect_initialize): Check vs interface
1842 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1843
bf501fb9
PE
1844 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1845
e9829fdf
PE
1846 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1847 to read-only memory.
1848
1086c095
PE
1849 * fns.c (vector): Remove; this old hack is no longer needed.
1850
2baccd04 1851 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1852 Remove unused var.
dde42981 1853 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1854
72391843 1855 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1856
436c16df 1857 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1858 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1859 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1860
92bb796d 1861 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1862 (x_term_init): Remove local to avoid shadowing.
92bb796d 1863
764430a3 1864 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1865
1866 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1867 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1868
d1dfb56c
EZ
18692011-04-16 Eli Zaretskii <eliz@gnu.org>
1870
c4354cb4
EZ
1871 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1872
d1dfb56c
EZ
1873 Fix regex.c, syntax.c and friends for buffers > 2GB.
1874 * syntax.h (struct gl_state_s): Declare character position members
1875 EMACS_INT.
1876
1877 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1878
04f2d78b
CB
1879 * textprop.c (verify_interval_modification, interval_of):
1880 Declare arguments EMACS_INT.
d1dfb56c
EZ
1881
1882 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1883 EMACS_INT.
1884
1885 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1886
1887 * indent.c (Fvertical_motion): Local variable it_start is now
1888 EMACS_INT.
1889
1890 * regex.c (re_match, re_match_2, re_match_2_internal)
1891 (bcmp_translate, regcomp, regexec, print_double_string)
1892 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1893 (re_compile_pattern, re_exec): Declare arguments and local
1894 variables `size_t' and `ssize_t' and return values `regoff_t', as
1895 appropriate.
1896 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1897 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1898 <compile_stack_type>: `size' and `avail' are now `size_t'.
1899
1900 * regex.h <regoff_t>: Use ssize_t, not int.
1901 (re_search, re_search_2, re_match, re_match_2): Arguments that
1902 specify buffer/string position and length are now ssize_t and
1903 size_t. Return type is regoff_t.
1904
613052cd
BK
19052011-04-16 Ben Key <bkey76@gmail.com>
1906
1907 * nsfont.m: Fixed bugs in ns_get_family and
1908 ns_descriptor_to_entity that were caused by using free to
1909 deallocate memory blocks that were allocated by xmalloc (via
1910 xstrdup). This caused Emacs to crash when compiled with
1911 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1912 --enable-checking=xmallocoverrun). xfree is now used to
1913 deallocate these memory blocks.
1914
4170f62f 19152011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1916
71b41406
PE
1917 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1918
9587a89d
PE
1919 emacs_write: Accept and return EMACS_INT for sizes.
1920 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1921 et seq.
1922 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1923 Accept and return EMACS_INT.
1924 (emacs_gnutls_write): Return the number of bytes written on
1925 partial writes.
1926 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1927 (emacs_read, emacs_write): Remove check for negative size, as the
1928 Emacs source code has been audited now.
9587a89d
PE
1929 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1930 (emacs_read, emacs_write): Use it.
273a5f82
PE
1931 * process.c (send_process): Adjust to the new signatures of
1932 emacs_write and emacs_gnutls_write. Do not attempt to store
1933 a byte offset into an 'int'; it might overflow.
9587a89d 1934 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1935
3e047f51
PE
1936 * sound.c: Don't assume sizes fit in 'int'.
1937 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1938 Return EMACS_INT, not int.
3e047f51 1939 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1940 Accept EMACS_INT, not int.
1941 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1942 record read return values.
1943
cc39a9db
BK
19442011-04-15 Ben Key <bkey76@gmail.com>
1945
c9d0ec6d
JB
1946 * keyboard.c (Qundefined): Don't declare static since it is used
1947 in nsfns.m.
1948 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1949 static since they are used in nsfont.m.
cc39a9db 1950
6c60eb9f
SM
19512011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1952
1953 * process.c (Qprocessp): Don't declare static.
1954 * lisp.h (Qprocessp): Declare again.
1955
7990b61a
JB
19562011-04-15 Juanma Barranquero <lekktu@gmail.com>
1957
1958 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1959
5d4cb038
PE
19602011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1961
8bd7b830 1962 Improve C-level modularity by making more things 'static'.
cd64ea1d 1963
e3b27b31
PE
1964 Don't publish debugger-only interfaces to other modules.
1965 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1966 (verify_bytepos, count_markers): Move decls to the only modules
1967 that need them.
1968 * region-cache.h (pp_cache): Likewise.
1969 * window.h (check_all_windows): Likewise.
1970 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1971
5d4cb038
PE
1972 * sysdep.c (croak): Now static, if
1973 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1974 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1975
1976 * alloc.c (refill_memory_reserve): Now static if
1977 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1978 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1979
e87b6180
PE
1980 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1981 Define only if USE_LUCID.
1982
ac64929e
PE
1983 * xrdb.c (x_customization_string, x_rm_string): Now static.
1984
6f37259d
PE
1985 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1986 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1987
1683e3ab
PE
1988 * xdisp.c (draw_row_with_mouse_face): Now static.
1989 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1990
de9c2632
PE
1991 * window.h (check_all_windows): Mark externally visible.
1992
2b96acb7
PE
1993 * window.c (window_deletion_count): Now static.
1994
1995 * undo.c: Make symbols static if they're not exported.
1996 (last_undo_buffer, last_boundary_position, pending_boundary):
1997 Now static.
1998
50436f33
PE
1999 * textprop.c (interval_insert_behind_hooks): Now static.
2000 (interval_insert_in_front_hooks): Likewise.
2001
64520e5c
PE
2002 * term.c: Make symbols static if they're not exported.
2003 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2004 (max_frame_lines, tty_set_terminal_modes):
2005 (tty_reset_terminal_modes, tty_turn_off_highlight):
2006 (get_tty_terminal): Now static.
2007 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2008 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2009 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2010 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2011 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2012
1fa53021
PE
2013 * sysdep.c: Make symbols static if they're not exported.
2014 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2015 Now static.
2016 (sigprocmask_set, full_mask): Remove; unused.
2017 (wait_debugging): Mark as visible.
2018 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2019 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2020
d4b43b22
PE
2021 * syntax.c (syntax_temp): Define only if !__GNUC__.
2022
b7c513d0
PE
2023 * sound.c (current_sound_device, current_sound): Now static.
2024
989b29ad
PE
2025 * search.c (searchbufs, searchbuf_head): Now static.
2026
13a55a78
PE
2027 * scroll.c (scroll_cost): Remove; unused.
2028 * dispextern.h (scroll_cost): Remove decl.
2029
de68a1fc
PE
2030 * region-cache.h (pp_cache): Mark as externally visible.
2031
40ccffa6
PE
2032 * process.c: Make symbols static if they're not exported.
2033 (process_tick, update_tick, create_process, chan_process):
2034 (Vprocess_alist, proc_buffered_char, datagram_access):
2035 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2036 (deactivate_process): Mark defn as static, as well as decl.
2037 * lisp.h (create_process): Remove decl.
2038 * process.h (chan_process, Vprocess_alist): Remove decls.
2039
ad64fc97
PE
2040 * print.c: Make symbols static if they're not exported.
2041 (print_depth, new_backquote_output, being_printed, print_buffer):
2042 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2043 (print_interval, print_number_index, initial_stderr_stream):
2044 Now static.
2045 * lisp.h (Fprinc): Remove decl.
2046 (debug_output_compilation_hack): Mark as externally visible.
2047
adddb265
PE
2048 * sysdep.c (croak): Move decl from here to syssignal.h.
2049 * syssignal.h (croak): Put it here, so the API can be checked when
2050 'croak' is called from dissociate_if_controlling_tty.
2051
1717ede2
PE
2052 * minibuf.c: Make symbols static if they're not exported.
2053 (minibuf_save_list, choose_minibuf_frame): Now static.
2054 * lisp.h (choose_minibuf_frame): Remove decl.
2055
fa5fb2bc
PE
2056 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2057
1e3890d1
PE
2058 * lread.c: Make symbols static if they're not exported.
2059 (read_objects, initial_obarray, oblookup_last_bucket_number):
2060 Now static.
2061 (make_symbol): Remove; unused.
2062 * lisp.h (initial_obarray, make_symbol): Remove decls.
2063
8a1414fa
PE
2064 * keyboard.c: Make symbols static if they're not exported.
2065 (single_kboard, recent_keys_index, total_keys, recent_keys):
2066 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2067 (this_single_command_key_start, echoing, last_auto_save):
2068 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2069 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2070 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2071 (Vlispy_mouse_stem, double_click_count):
2072 Now static.
2073 (force_auto_save_soon): Define only if SIGDANGER.
2074 (ignore_mouse_drag_p): Now static if
2075 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2076 (print_help): Remove; unused.
2077 (stop_character, last_timer_event): Mark as externally visible.
2078 * keyboard.h (ignore_mouse_drag_p): Declare only if
2079 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2080 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2081 * lisp.h (echoing): Remove decl.
2082 (force_auto_save_soon): Declare only if SIGDANGER.
2083 * xdisp.c (redisplay_window): Simplify code, to make it more
2084 obvious that ignore_mouse_drag_p is not accessed if !defined
2085 USE_GTK && !defined HAVE_NS.
2086
93ea6e8f
PE
2087 * intervals.c: Make symbols static if they're not exported.
2088 (merge_properties_sticky, merge_interval_right, delete_interval):
2089 Now static.
2090 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2091
77382fcc
PE
2092 * insdel.c: Make symbols static if they're not exported.
2093 However, leave prepare_to_modify_buffer alone. It's never
2094 called from outside this function, but that appears to be a bug.
2095 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2096 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2097 (adjust_after_replace_noundo): Remove; unused.
2098 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2099 (signal_before_change): Remove decls.
77382fcc 2100
9306c32e
PE
2101 * indent.c (val_compute_motion, val_vmotion): Now static.
2102
cd44d2eb
PE
2103 * image.c: Make symbols static if they're not exported.
2104 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2105 if USE_GTK.
2106 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2107 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2108
ad9a7a06
PE
2109 * fringe.c (standard_bitmaps): Now static.
2110 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2111
81626931
PE
2112 * frame.c: Make symbols static if they're not exported.
2113 (x_report_frame_params, make_terminal_frame): Now static.
2114 (get_frame_param): Now static, unless HAVE_NS.
2115 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2116 (x_get_resource_string): Remove; not used.
2117 * frame.h (make_terminal_frame, x_report_frame_params):
2118 (x_get_resource_string); Remove decls.
2119 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2120 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2121
239f9db9
PE
2122 * font.c, fontset.c: Make symbols static if they're not exported.
2123 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2124 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2125 * font.c (font_close_object): Now static.
2126 * font.h (font_close_object): Remove.
2127 * fontset.c (FONTSET_OBJLIST): Remove.
2128 (free_realized_fontset) #if-0 the body, which does nothing.
2129 (face_suitable_for_char_p): #if-0, as it's never called.
2130 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2131 * xfaces.c (face_at_string_position):
2132 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2133 since 0 is always ASCII.
2134
dfcf3579
PE
2135 * fns.c (weak_hash_tables): Now static.
2136
5045092b
PE
2137 * fileio.c: Make symbols static if they're not exported.
2138 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2139 (Vwrite_region_annotation_buffers): Now static.
2140
57a96f5c
PE
2141 * eval.c: Make symbols static if they're not exported.
2142 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2143 * lisp.h (backtrace_list): Remove decl.
2144
35f08c38
PE
2145 * emacs.c: Make symbols static if they're not exported.
2146 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2147 (fatal_error_code, fatal_error_signal_hook, standard_args):
2148 Now static.
2149 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2150 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2151 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2152 * lisp.h (fatal_error_signal_hook): Remove decl.
2153 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2154
f44bd759
PE
2155 * editfns.c: Move a (normally-unused) function to its only use.
2156 * editfns.c, lisp.h (get_operating_system_release): Remove.
2157 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2158 worth the hassle of breaking this out.
2159
b532497d
PE
2160 * xterm.c: Make symbols static if they're not exported.
2161 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2162 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2163 (x_destroy_window, x_delete_display):
2164 Now static.
2165 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2166 (x_mouse_leave): Remove; unused.
2167 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2168 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2169 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2170 Remove decls.
2171 (x_mouse_leave): Declare only if WINDOWSNT.
2172 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2173 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2174 USE_X_TOOLKIT.
2175
1675728f
PE
2176 * ftxfont.c: Make symbols static if they're not exported.
2177 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2178 HAVE_FREETYPE.
2179 * font.h (ftxfont_driver): Likewise.
2180
e4cebfca
PE
2181 * xfns.c: Make symbols static if they're not exported.
2182 (x_last_font_name, x_display_info_for_name):
2183 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2184 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2185 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2186 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2187 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2188 (last_show_tip_args): Now static.
2189 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2190 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2191 (x_screen_planes): Remove; unused.
2192 * dispextern.h (x_screen_planes): Remove decl.
2193
5bf46f05
PE
2194 * dispnew.c: Make symbols static if they're not exported.
2195 * dispextern.h (redraw_garbaged_frames, scrolling):
2196 (increment_row_positions): Remove.
2197 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2198 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2199 Now static.
2200 (redraw_garbaged_frames): Remove; unused.
2201
435f4c28
PE
2202 * xfaces.c: Make symbols static if they're not exported.
2203 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2204 Remove decls.
2205 * xterm.h (defined_color): Remove decls.
2206 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2207 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2208 (menu_face_changed_default, defined_color, free_realized_face):
2209 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2210 (ascii_face_of_lisp_face): Remove; unused.
2211
8524aef3
PE
2212 * xdisp.c: Make symbols static if they're not exported.
2213 * dispextern.h (scratch_glyph_row, window_box_edges):
2214 (glyph_to_pixel_coords, set_cursor_from_row):
2215 (get_next_display_element, set_iterator_to_next):
2216 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2217 (show_mouse_face): Remove decls
2218 * frame.h (message_buf_print): Likewise.
2219 * lisp.h (pop_message, set_message, check_point_in_composition):
2220 Likewise.
2221 * xterm.h (set_vertical_scroll_bar): Likewise.
2222 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2223 (message_buf_print, scratch_glyph_row, displayed_buffer):
2224 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2225 (get_next_display_element, show_mouse_face, window_box_edges):
2226 (frame_to_window_pixel_xy, check_point_in_composition):
2227 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2228 (glyph_to_pixel_coords): Remove; unused.
2229
16390cd2
PE
2230 * dired.c (file_name_completion): Now static.
2231
2232 * dbusbind.c (xd_in_read_queued_messages): Now static.
2233
a25f4dfa
PE
2234 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2235 * data.c (circular_list_error): Remove.
2236
14a9c8df
PE
2237 * commands.h (last_point_position, last_point_position_buffer):
2238 (last_point_position_window): Remove decls.
2239 * keyboard.c: Make these variables static.
2240
04f2d78b
CB
2241 * coding.h (coding, code_convert_region, encode_coding_gap):
2242 Remove decls.
74ab6df5
PE
2243 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2244 (iso_code_class, detect_coding, code_convert_region): Now static.
2245 (encode_coding_gap): Remove; unused.
2246
38dfbee1
PE
2247 * chartab.c (chartab_chars, chartab_bits): Now static.
2248
a2cb4e63
PE
2249 * charset.h (charset_iso_8859_1): Remove decl.
2250 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2251 Now static.
2252
127198fd
PE
2253 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2254 * ccl.c (Vccl_program_table): Now static.
2255 (check_ccl_update): Remove; unused.
2256
d85b608f
PE
2257 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2258 * category.h: ... from here.
2259 * category.c (check_category_table, set_category_set): Now static.
2260
31cd66f3
PE
2261 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2262 * lisp.h: Remove these decls.
2263
c358e587
PE
2264 * buffer.c (buffer_count): Remove unused var.
2265
e78aecca
PE
2266 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2267 so that it's not optimized away.
2268 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2269 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2270 exported only to the debugger.
2271
e192d7d3 2272 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2273 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2274
92470028
PE
2275 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2276 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2277 was inaccessible from Lisp.
2278 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2279 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2280
244ed907
PE
2281 alloc.c: Import and export fewer symbols, and remove unused items.
2282 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2283 is defined.
2284 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2285 it's not optimized away by whole-program optimization.
2286 (message_enable_multibyte, free_misc): Remove.
2287 (catchlist, handlerlist, mark_backtrace):
2288 Declare only if BYTE_MARK_STACK.
2289 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2290 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2291 (message_enable_multibyte): Remove decl.
2292 (free_misc, interval_free_list, float_block, float_block_index):
2293 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2294 (cons_free_list, last_marked_index):
2295 Now static.
2296 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2297 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2298 (mark_backtrace): Define only if BYTE_MARK_STACK.
2299 * xdisp.c (message_enable_multibyte): Now static.
2300
61c2b50e 2301 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2302 This makes it easier for human readers (and static analyzers)
2303 to see whether these variables are used from other modules.
2304 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2305 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2306 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2307 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2308 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2309 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2310 * xmenu.c, xselect.c:
2311 Declare Q* vars static if they are not used in other modules.
2312 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2313 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2314 Remove decls of unexported vars.
2315 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2316
95c82688
PE
2317 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2318
16a97296
PE
2319 Make Emacs functions such as Fatom 'static' by default.
2320 This makes it easier for human readers (and static analyzers)
2321 to see whether these functions can be called from other modules.
2322 DEFUN now defines a static function. To make the function external
2323 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2324 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2325 (Finit_image_library):
16a97296
PE
2326 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2327 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2328 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2329 Remove decls, since these functions are now static.
2330 (Funintern, Fget_internal_run_time): New decls, since these functions
2331 were already external.
95c82688 2332
16a97296
PE
2333 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2334 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2335 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2336 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2337 * keyboard.c, keymap.c, lread.c:
2338 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2339 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2340 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2341 Mark functions with DEFUE instead of DEFUN,
2342 if they are used in other modules.
2343 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2344 decls for now-static functions.
2345 * buffer.h (Fdelete_overlay): Remove decl.
2346 * callproc.c (Fgetenv_internal): Mark as internal.
2347 * composite.c (Fremove_list_of_text_properties): Remove decl.
2348 (Fcomposition_get_gstring): New forward static decl.
2349 * composite.h (Fcomposite_get_gstring): Remove decl.
2350 * dired.c (Ffile_attributes): New forward static decl.
2351 * doc.c (Fdocumntation_property): New forward static decl.
2352 * eval.c (Ffetch_bytecode): New forward static decl.
2353 (Funintern): Remove extern decl; now in .h file where it belongs.
2354 * fileio.c (Fmake_symbolic_link): New forward static decl.
2355 * image.c (Finit_image_library): New forward static decl.
2356 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2357 * intervals.h (Fprevious_property_change):
2358 (Fremove_list_of_text_properties): Remove decls.
2359 * keyboard.c (Fthis_command_keys): Remove decl.
2360 (Fcommand_execute): New forward static decl.
2361 * keymap.c (Flookup_key): New forward static decl.
2362 (Fcopy_keymap): Now static.
2363 * keymap.h (Flookup_key): Remove decl.
2364 * process.c (Fget_process): New forward static decl.
2365 (Fprocess_datagram_address): Mark as internal.
2366 * syntax.c (Fsyntax_table_p): New forward static decl.
2367 (skip_chars): Remove duplicate decl.
2368 * textprop.c (Fprevious_property_change): New forward static decl.
2369 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2370 Now internal.
2371 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2372 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2373
785bbd42
PE
2374 * editfns.c (Fformat): Remove unreachable code.
2375
8b913b57
AS
23762011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2377
2378 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2379 change. (Bug#8496)
2380
a6744a35
EZ
23812011-04-13 Eli Zaretskii <eliz@gnu.org>
2382
2383 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2384 when at ZV. (Bug#8487)
2385
e7974947
AS
23862011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2387
baad03f0
AS
2388 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2389 (Bug#8437)
2390 * keyboard.c (parse_tool_bar_item): Likewise.
2391 * sound.c (sound_cleanup, alsa_close): Likewise.
2392 * termcap.c (tgetent): Likewise.
2393 * xfns.c (x_default_font_parameter): Likewise.
2394 * xsettings.c (read_and_apply_settings): Likewise.
2395
e7974947
AS
2396 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2397 (overrun_check_free): Protoize.
2398
28272684
PE
23992011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2400
2401 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2402 since callers should never pass a negative size.
2403 Change the signature to match that of plain 'read' and 'write'; see
2404 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2405 * lisp.h: Update prototypes of emacs_write and emacs_read.
2406
11997c76
EZ
24072011-04-11 Eli Zaretskii <eliz@gnu.org>
2408
2409 * xdisp.c (redisplay_window): Don't try to determine the character
2410 position of the scroll margin if the window start point w->startp
e896f03c 2411 is outside the buffer's accessible region. (Bug#8468)
11997c76 2412
8a2cbd72
EZ
24132011-04-10 Eli Zaretskii <eliz@gnu.org>
2414
2415 Fix write-region and its subroutines for buffers > 2GB.
2416 * fileio.c (a_write, e_write): Modify declaration of arguments and
2417 local variables to support buffers larger than 2GB.
2418 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2419
2420 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2421 argument, local variables, and return value.
2422
2423 * lisp.h: Update prototypes of emacs_write and emacs_read.
2424
2425 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2426
4073e537 24272011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2428
1ebfdcb6
PE
2429 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2430
b2ded58d
PE
2431 Fix more problems found by GCC 4.6.0's static checks.
2432
7d66342c
PE
2433 * xdisp.c (vmessage): Use a better test for character truncation.
2434
bbf47d44
PE
2435 * charset.c (load_charset_map): <, not <=, for optimization,
2436 and to avoid potential problems with integer overflow.
9248994d 2437 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2438 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2439 * editfns.c (Fformat): Likewise.
1e69125e 2440 * syntax.c (skip_chars): Likewise.
3befa583 2441
e3019616
PE
2442 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2443 This also lets GCC 4.6.0 generate slightly better loop code.
2444
becfa255
PE
2445 * callint.c (Fcall_interactively): <, not <=, for optimization.
2446 (Fcall_interactively): Count the number of arguments produced,
2447 not the number of arguments given. This is simpler and lets GCC
2448 4.6.0 generate slightly better code.
2449
dae0cd48
PE
2450 * ftfont.c: Distingish more carefully between FcChar8 and char.
2451 The previous code passed unsigned char * to a functions like
2452 strlen and xstrcasecmp that expect char *, which does not
2453 conform to the C standard.
2454 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2455 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2456 char * when the C standard requires it.
2457
76032d70
PE
2458 * keyboard.c (read_char): Remove unused var.
2459
eb3f1cc8
PE
2460 * eval.c: Port to Windows vsnprintf (Bug#8435).
2461 Include <limits.h>.
2462 (SIZE_MAX): Define if the headers do not.
2463 (verror): Do not give up if vsnprintf returns a negative count.
2464 Instead, grow the buffer. This ports to Windows vsnprintf, which
2465 does not conform to C99. Problem reported by Eli Zaretskii.
2466 Also, simplify the allocation scheme, by avoiding the need for
2467 calling realloc, and removing the ALLOCATED variable.
2468
70476b54
PE
2469 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2470
12020a9e
PE
2471 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2472 But keep the doprint source code for now, as we might revamp it
2473 and use it again (Bug#8435).
ea6c7ae6
PE
2474 * lisp.h (doprnt): Remove.
2475 * Makefile.in (base_obj): Remove doprnt.o.
2476 * deps.mk (doprnt.o): Remove.
2477
5fdb398c
PE
2478 error: Print 32- and 64-bit integers portably (Bug#8435).
2479 Without this change, on typical 64-bit hosts error ("...%d...", N)
2480 was used to print both 32- and 64-bit integers N, which relied on
2481 undefined behavior.
2482 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2483 New macro.
2484 * lisp.h (error, verror): Mark as printf-like functions.
2485 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2486 Report overflow in size calculations when allocating printf buffer.
2487 Do not truncate output string at its first null byte.
2488 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2489 Truncate the output at a character boundary, since vsnprintf does not
2490 do that.
2491 * charset.c (check_iso_charset_parameter): Convert internal
2492 character to string before calling 'error', since %c now has the
2493 printf meaning.
2494 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2495 overflow when computing char to be passed to 'error'. Do not
2496 pass Lisp_Object to 'error'; pass the integer instead.
2497 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2498 formatted with plain %d.
2499
b189fa66
PE
2500 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2501
bff87ef0
PE
2502 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2503
7e2cac20
PE
2504 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2505
ce4d90b5
PE
2506 * xterm.c (x_catch_errors): Remove duplicate declaration.
2507
266c9547
PE
2508 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2509
79c49ad2
PE
2510 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2511
368f4090
JM
25122011-04-10 Jim Meyering <meyering@redhat.com>
2513
2514 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2515 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2516 return ssize_t not "int", and use size_t as the buffer length.
2517 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2518 * gnutls.h: Update declarations.
2519 * process.c (read_process_output): Use ssize_t, to match.
2520 (send_process): Likewise.
2521
a32d4040
CY
25222011-04-09 Chong Yidong <cyd@stupidchicken.com>
2523
2524 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2525
8546720e 25262011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2527
04f2d78b
CB
2528 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2529 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2530
8546720e
GM
2531 * xterm.c (handle_one_xevent):
2532 * xmenu.c (create_and_show_popup_menu):
2533 * xselect.c (x_decline_selection_request)
2534 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2535
0a2f5c1a 25362011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2537
2538 Fix some uses of `int' instead of EMACS_INT.
2539 * search.c (string_match_1, fast_string_match)
2540 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2541 (scan_buffer, find_next_newline_no_quit)
2542 (find_before_next_newline, search_command, Freplace_match)
2543 (Fmatch_data): Make some `int' variables be EMACS_INT.
2544
2545 * xdisp.c (display_count_lines): 3rd argument and return value now
2546 EMACS_INT. All callers changed.
2547 (pint2hrstr): Last argument is now EMACS_INT.
2548
2549 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2550 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2551 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2552 (decode_coding_utf_16, decode_coding_emacs_mule)
2553 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2554 (decode_coding_ccl, decode_coding_charset)
2555 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2556 (decode_coding_iso_2022, decode_coding_emacs_mule)
2557 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2558 <char_offset, last_offset>: Declare EMACS_INT.
2559 (encode_coding_utf_8, encode_coding_utf_16)
2560 (encode_coding_emacs_mule, encode_invocation_designation)
2561 (encode_designation_at_bol, encode_coding_iso_2022)
2562 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2563 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2564 Declare EMACS_INT.
2565 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2566 (encode_invocation_designation): Last argument P_NCHARS is now
2567 EMACS_INT.
2568 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2569 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2570
2571 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2572 All users changed.
2573
2574 * ccl.c (Fccl_execute_on_string): Declare some variables
2575 EMACS_INT.
2576
8546720e 25772011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2578
2579 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2580
4e19a977
CS
25812011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2582
2583 * process.c (Fformat_network_address): Doc fix.
2584
87302331
R
25852011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2586
2587 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2588
cbb59342
CY
25892011-04-08 Chong Yidong <cyd@stupidchicken.com>
2590
2591 * keyboard.c (read_char): Call Lisp function help-form-show,
2592 instead of using internal_with_output_to_temp_buffer.
2593 (Qhelp_form_show): New var.
e0d38eeb 2594 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2595
2596 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2597
2598 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2599
e67a13ab
CY
26002011-04-06 Chong Yidong <cyd@stupidchicken.com>
2601
04f2d78b
CB
2602 * process.c (Flist_processes): Remove to Lisp.
2603 (list_processes_1): Delete.
e67a13ab 2604
973f782d
EZ
26052011-04-06 Eli Zaretskii <eliz@gnu.org>
2606
7c106b1e
EZ
2607 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2608
973f782d
EZ
2609 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2610
41cf7d1a 26112011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2612
ca23cc88
PE
2613 Fix more problems found by GCC 4.6.0's static checks.
2614
f390e2d5
PE
2615 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2616
42eea0d0
PE
2617 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2618
b69769da 2619 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2620
f9541e84
PE
2621 * xdisp.c (vmessage): Mark as a printf-like function.
2622
13841b55
PE
2623 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2624
c136c10f
PE
2625 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2626
5e2d4a30
PE
2627 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2628 printf-like functions.
2629 (tiff_load): Add casts to remove these marks before passing them
2630 to system-supplied API.
2631
583f48b9
PE
2632 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2633
b25d760e
PE
2634 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2635 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2636 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2637 directly, rather than having caller test rule sign. This avoids
2638 some unnecessary tests.
2639 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2640 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2641 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2642
bc7b6697 2643 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2644 (xfont_open): Avoid unnecessary tests.
bc7b6697 2645
27ccc379
PE
2646 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2647
dcd5c89a
PE
2648 * composite.h, composite.c (composition_gstring_put_cache):
2649 Use EMACS_INT, not int, for length.
2650
b13a45c6
PE
2651 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2652 breaking out part of COMPOSITION_DECODE_RULE.
2653 (COMPOSITION_DECODE_RULE): Use it.
2654 * composite.c (get_composition_id): Remove unused local vars,
2655 by using the new macro.
2656
1e792e4d
PE
2657 * textprop.c (set_text_properties_1): Change while to do-while,
2658 since the condition is always true at first.
2659
dc6c6455 2660 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2661 (interval_deletion_adjustment): Return unsigned value.
2662 All uses changed.
dc6c6455 2663
aba7731a
PE
2664 * process.c (list_processes_1, create_pty, read_process_output):
2665 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2666 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2667 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2668 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2669 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2670
fdfc4bf3
PE
2671 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2672
fca8fe46 2673 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2674 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2675
06a0259a 2676 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2677 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2678 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2679
e7b9e80f
PE
2680 * print.c (print_error_message): Avoid int overflow.
2681
56201685
PE
2682 * font.c (font_list_entities): Redo for clarity,
2683 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2684
78834453 2685 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2686 (font_score): Avoid potential overflow in diff calculation.
78834453 2687
0bc0b309 2688 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2689 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2690
e610eaca
PE
2691 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2692
b895abce
PE
2693 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2694 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2695 can always succeed if overflow has undefined behavior.
2696
1f1d9321 2697 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2698 (wordify): Omit three unnecessary tests.
1f1d9321 2699
c59478bc
PE
2700 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2701 All callers changed. This avoids the need for an unused var.
2702
79b73827
PE
2703 * casefiddle.c (casify_region): Remove var that is set but not used.
2704
a4db5dfe
PE
2705 * dired.c (file_name_completion): Remove var that is set but not used.
2706
43aae36e
PE
2707 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2708
2a47c44d 2709 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2710 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2711
a37c69bf
PE
2712 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2713 Check for integer overflow on size calculations.
2714
328ab8e7
PE
2715 * buffer.c (Fprevious_overlay_change): Remove var that is set
2716 but not used.
2717
e5a2a5cb
PE
2718 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2719 Remove vars that are set but not used.
8d84a6eb 2720 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2721 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2722
a60e5f68
PE
2723 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2724
f661cb61 2725 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2726 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2727
f0397f5a
PE
2728 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2729 that are set but not used.
2730
8664db06 2731 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2732 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2733
6abdaa4a
PE
2734 * xselect.c (x_get_local_selection, x_handle_property_notify):
2735 Remove vars that are set but not used.
2736
0ce7538d 2737 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2738 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2739
9ae848fc
PE
2740 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2741 Remove var that is set but not used.
0b918413
PE
2742 (scroll_bar_windows_size): Now size_t, not int.
2743 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2744 Check for overflow.
9ae848fc 2745
a5a62657
PE
2746 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2747 (map_tty_color) [!defined MSDOS]: Likewise.
2748
5c5cdd39
PE
2749 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2750
66ebf983
PE
2751 * coding.c: Remove vars that are set but not used.
2752 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2753 All callers changed.
2754 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2755 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2756 (decode_coding_charset): Remove vars that are set but not used.
2757
1be4d761
PE
2758 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2759 that is set but not used.
2760
47553fa8
PE
2761 * print.c (print_object): Remove var that is set but not used.
2762
1f7196bf 2763 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2764 The gnulib version avoids calling malloc in the usual case,
2765 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2766 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2767 * filelock.c (current_lock_owner): Likewise.
2768 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2769 * sysdep.c: Include allocator.h, careadlinkat.h.
2770 (emacs_no_realloc_allocator): New static constant.
2771 (emacs_readlink): New function.
fdb61804
PE
2772 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2773 ../lib/careadlinkat.h.
d1fdcab7 2774
f84c17c7
SM
27752011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2776
2777 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2778 first non-nil return value).
2779
ef3862ad
JD
27802011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2781
2782 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2783 if not defined (Bug#8403).
2784
376a7006
JB
27852011-04-02 Juanma Barranquero <lekktu@gmail.com>
2786
2787 * xdisp.c (display_count_lines): Remove parameter `start',
2788 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2789 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2790 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2791 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2792 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2793 and thereabouts. All callers changed.
2794 (get_per_char_metric): Remove parameter `f', unused since
2795 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2796
6ca3801d
JM
27972011-04-02 Jim Meyering <meyering@redhat.com>
2798
2799 do not dereference NULL upon failed strdup
2800 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2801 (ns_get_family): Likewise.
2802
d8e2b5ba
JB
28032011-04-02 Juanma Barranquero <lekktu@gmail.com>
2804
2805 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2806
8c74fcbd
JD
28072011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2808
2809 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2810 later (Bug#8403).
2811
7200d79c
SM
28122011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2813
03408648 2814 Add lexical binding.
7200d79c 2815
03408648
SM
2816 * window.c (Ftemp_output_buffer_show): New fun.
2817 (Fsave_window_excursion):
2818 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2819
2820 * lread.c (lisp_file_lexically_bound_p): New function.
2821 (Fload): Bind Qlexical_binding.
2822 (readevalloop): Remove `evalfun' arg.
2823 Bind Qinternal_interpreter_environment.
2824 (Feval_buffer): Bind Qlexical_binding.
2825 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2826 Mark as dynamic.
2827 (syms_of_lread): Declare `lexical-binding'.
2828
2829 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2830
2831 * keyboard.c (eval_dyn): New fun.
2832 (menu_item_eval_property): Use it.
ca105506
SM
2833
2834 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2835
03408648
SM
2836 * fns.c (concat, mapcar1): Accept byte-code-functions.
2837
2838 * eval.c (Fsetq): Handle lexical vars.
2839 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2840 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2841 (FletX, Flet): Obey lexical binding.
2842 (Fcommandp): Handle closures.
2843 (Feval): New `lexical' arg.
2844 (eval_sub): New function extracted from Feval. Use it almost
2845 everywhere where Feval was used. Look up vars in lexical env.
2846 Handle closures.
2847 (Ffunctionp): Move from subr.el.
2848 (Ffuncall): Handle closures.
2849 (apply_lambda): Remove `eval_flags'.
2850 (funcall_lambda): Handle closures and new byte-code-functions.
2851 (Fspecial_variable_p): New function.
2852 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2853 but without exporting it to Lisp.
23aba0ea 2854
23aba0ea 2855 * doc.c (Fdocumentation, store_function_docstring):
03408648 2856 * data.c (Finteractive_form): Handle closures.
23aba0ea 2857
03408648
SM
2858 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2859 interactive spec.
ba83908c 2860
04f2d78b
CB
2861 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2862 New byte-codes.
03408648
SM
2863 (exec_byte_code): New function extracted from Fbyte_code to handle new
2864 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2865
03408648 2866 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2867
03408648 2868 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2869
e2abce01
JB
28702011-03-31 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * xdisp.c (redisplay_internal): Fix prototype.
2873
63696a73 28742011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2875
63696a73 2876 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2877 (try_scrolling): Use it when setting scroll_limit.
2878 Limit scrolling to 100 screen lines.
63696a73
EZ
2879 (redisplay_window): Even when falling back on "recentering",
2880 position point in the window according to scroll-conservatively,
2881 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2882
2883 (try_scrolling): When point is above the window, allow searching
2884 as far as scroll_max, or one screenful, to compute vertical
2885 distance from PT to the scroll margin position. This prevents
2886 try_scrolling from unnecessarily failing when
2887 scroll-conservatively is set to a value slightly larger than the
2888 window height. Clean up the case of PT below the margin at bottom
2889 of window: scroll_max can no longer be INT_MAX. When aggressive
2890 scrolling is in use, don't let point enter the opposite scroll
2891 margin as result of the scroll.
2892 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2893 threshold of 100 lines for never-recentering scrolling.
2894
e4cc2dfc
JB
28952011-03-31 Juanma Barranquero <lekktu@gmail.com>
2896
2897 * dispextern.h (move_it_by_lines):
2898 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2899 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2900 (message_log_check_duplicate): Remove parameters `prev_bol' and
2901 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2902 (redisplay_internal): Remove parameter `preserve_echo_area',
2903 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2904
2905 * indent.c (Fvertical_motion):
2906 * window.c (window_scroll_pixel_based, Frecenter):
2907 Don't pass `need_y_p' to `move_it_by_lines'.
2908
1c470562
SM
29092011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2910
44f230aa
SM
2911 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2912 steal a few bits to be more compact.
2913 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2914 Remove unneeded casts.
2915
1c470562
SM
2916 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2917
888adce9
ZK
29182011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2919
2920 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2921 binding" message (bug#7967).
2922
f838ed7b
PE
29232011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2924
77861b95
PE
2925 Fix more problems found by GCC 4.6.0's static checks.
2926
de6dbc14
PE
2927 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2928 Remove unused local var.
2929
f838ed7b
PE
2930 * editfns.c (Fmessage_box): Remove unused local var.
2931
792c7b2b
PE
2932 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2933 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2934 Omit unused local vars.
c499e557 2935 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2936 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2937 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2938 Omit unused local var.
2939
ba0165e1
PE
2940 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2941 Don't assume string length fits in int.
32ad8845 2942 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2943 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2944
3c59b4c9
PE
2945 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2946 instead of alloca (Bug#8344).
2947
a3eed478 2948 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2949 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2950
eb4d412d
PE
2951 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2952
1658b401
PE
2953 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2954 concerns.
2955
2956 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2957
2958 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2959
9a2c6e05
PE
2960 * keyboard.c (syms_of_keyboard): Use the same style as later
2961 in this function when indexing through an array. This also
2962 works around GCC bug 48267.
2963
03d0a109
PE
2964 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2965
44f730c8
PE
2966 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2967
fe75f926
PE
2968 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2969 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2970
ffa8c828
PE
2971 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2972 This avoids undefined behavior on integer overflow, and is a bit
2973 more convenient anyway since it is compared to a size_t variable.
2974
c5101a77
PE
2975 Variadic C functions now count arguments with size_t, not int.
2976 This avoids an unnecessary limitation on 64-bit machines, which
2977 caused (substring ...) to crash on large vectors (Bug#8344).
2978 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2979 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2980 All variadic functions and their callers changed accordingly.
c5101a77
PE
2981 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2982 * data.c (arith_driver, float_arith_driver): Likewise.
2983 * editfns.c (general_insert_function): Likewise.
2984 * eval.c (struct backtrace.nargs, interactive_p)
2985 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2986 (funcall_lambda, mark_backtrace): Likewise.
2987 * fns.c (concat): Likewise.
2988 * frame.c (x_set_frame_parameters): Likewise.
2989 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2990 0 if not found, not -1. All callers changed.
2991
dd3f25f7
PE
2992 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2993 (stack_copy_size): Now size_t, not int.
2994 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2995
461c2ab9
JB
29962011-03-28 Juanma Barranquero <lekktu@gmail.com>
2997
2998 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2999 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3000 All callers changed.
3001
3002 * lisp.h (multibyte_char_to_unibyte):
3003 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3004 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3005 * character.h (CHAR_TO_BYTE8):
3006 * cmds.c (internal_self_insert):
3007 * editfns.c (general_insert_function):
3008 * keymap.c (push_key_description):
3009 * search.c (Freplace_match):
3010 * xdisp.c (message_dolog, set_message_1): All callers changed.
3011
f6d62986
SM
30122011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3013
3014 * keyboard.c (safe_run_hook_funcall): New function.
3015 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3016 don't set the hook to nil, but remove the offending function instead.
3017 (Qcommand_hook_internal): Remove, unused.
3018 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3019 Vcommand_hook_internal.
3020
3021 * eval.c (enum run_hooks_condition): Remove.
3022 (funcall_nil, funcall_not): New functions.
3023 (run_hook_with_args): Call each function through a `funcall' argument.
3024 Remove `cond' argument, now redundant.
3025 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3026 (Frun_hook_with_args_until_failure): Adjust accordingly.
3027 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3028
1db5b1ad
JB
30292011-03-28 Juanma Barranquero <lekktu@gmail.com>
3030
3031 * dispextern.h (string_buffer_position): Remove declaration.
3032
3033 * print.c (strout): Remove parameter `multibyte', unused since
3034 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3035
3036 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3037 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3038 All callers changed.
3039
3040 * w32.c (_wsa_errlist): Use braces for struct initializers.
3041
3042 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3043 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3044 All callers changed.
3045 (string_buffer_position): Likewise. Also, make static (it's never
3046 used outside xdisp.c).
3047 (cursor_row_p): Remove parameter `w', unused since
3048 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3049 (decode_mode_spec): Remove parameter `precision', introduced during
3050 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3051 All callers changed.
3052
5ffb62aa
JD
30532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3054
3055 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3056
461c2ab9 30572011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3058
3059 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3060 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3061 (ns_update_auto_hide_menu_bar): New functions.
3062 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3063 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3064 ns_constrain_all_frames.
3065 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3066 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3067
5c380ffb
JD
30682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3069
3070 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3071
9af30bdf
GM
30722011-03-27 Glenn Morris <rgm@gnu.org>
3073
3074 * syssignal.h: Replace RETSIGTYPE with void.
3075 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3076 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3077 Replace SIGTYPE with void everywhere.
3078 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3079 * s/template.h (SIGTYPE): Remove commented out definition.
3080
e2abce01
JB
30812011-03-26 Eli Zaretskii <eliz@gnu.org>
3082
3083 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3084 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3085
f868cd8a
JB
30862011-03-26 Juanma Barranquero <lekktu@gmail.com>
3087
59eb0929
JB
3088 * w32.c (read_unc_volume): Use parameter `henum', instead of
3089 global variable `wget_enum_handle'.
3090
3091 * keymap.c (describe_vector): Remove parameters `indices' and
3092 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3093 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3094
f868cd8a
JB
3095 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3096
3097 * keyboard.c (timer_check): Remove parameter `do_it_now',
3098 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3099 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3100 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3101
3102 * keyboard.c (read_char):
3103 * w32menu.c (w32_menu_display_help):
3104 * xmenu.c (show_help_event, menu_help_callback):
3105 Adjust calls to `show_help_echo'.
3106
3107 * gtkutil.c (xg_maybe_add_timer):
3108 * keyboard.c (readable_events):
3109 * process.c (wait_reading_process_output):
3110 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3111
3112 * insdel.c (adjust_markers_gap_motion):
3113 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3114 (gap_left, gap_right): Don't call it.
3115
2ecf6fdb
CY
31162011-03-25 Chong Yidong <cyd@stupidchicken.com>
3117
3118 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3119 incurred during fontification.
3120
6b1f9ba4
JB
31212011-03-25 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3124 (DEFVAR_PER_BUFFER): Don't pass it.
3125
3126 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3127 (scrolling_window): Don't pass it.
3128
0f4a96b5
JB
31292011-03-25 Juanma Barranquero <lekktu@gmail.com>
3130
3131 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3132
3133 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3134 and `suffix'.
3135 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3136 of variables specific to SELinux and computation of `encoded_absname'.
3137
3138 * image.c (XPutPixel): Remove unused variable `height'.
3139
3140 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3141
3142 * unexw32.c (get_section_info): Remove unused variable `section'.
3143
3144 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3145 (system_process_attributes): Remove unused variable `sess'.
3146 (sys_read): Remove unused variable `err'.
3147
3148 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3149 (w32_wnd_proc): Remove unused variable `isdead'.
3150 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3151 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3152 (x_create_tip_frame): Remove unused variable `tem'.
3153
3154 * w32inevt.c (w32_console_read_socket):
3155 Remove unused variable `no_events'.
3156
3157 * w32term.c (x_draw_composite_glyph_string_foreground):
3158 Remove unused variable `width'.
3159
1149507c
JB
31602011-03-24 Juanma Barranquero <lekktu@gmail.com>
3161
3162 * w32term.c (x_set_glyph_string_clipping):
3163 Don't pass uninitialized region to CombineRgn.
3164
9c88f339
JB
31652011-03-23 Juanma Barranquero <lekktu@gmail.com>
3166
3167 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3168 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3169 (Fx_close_connection): Remove unused variable `i'.
3170
3171 * w32font.c (w32font_draw): Return number of glyphs.
3172 (w32font_open_internal): Remove unused variable `i'.
3173 (w32font_driver): Add missing initializer.
3174
3175 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3176 (fill_in_menu): Remove unused variable `items_added'.
3177
3178 * w32term.c (last_mouse_press_frame): Remove static global variable.
3179 (w32_clip_to_row): Remove unused variable `f'.
3180 (x_delete_terminal): Remove unused variable `i'.
3181
3182 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3183 (NOTHING): Remove unused static global variable.
3184 (uniscribe_check_otf): Remove unused variable `table'.
3185 (uniscribe_font_driver): Add missing initializers.
3186
dee091a3
JD
31872011-03-23 Julien Danjou <julien@danjou.info>
3188
3189 * term.c (Fsuspend_tty, Fresume_tty):
3190 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3191 * window.c (temp_output_buffer_show):
3192 * insdel.c (signal_before_change):
3193 * frame.c (Fhandle_switch_frame):
3194 * fileio.c (Fdo_auto_save):
3195 * emacs.c (Fkill_emacs):
3196 * editfns.c (save_excursion_restore):
3197 * cmds.c (internal_self_insert):
3198 * callint.c (Fcall_interactively):
3199 * buffer.c (Fkill_all_local_variables):
3200 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3201 Use Frun_hooks.
0f4a96b5 3202 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3203 unconditionnaly since it does the check itself.
3204
2c520ab5 32052011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3206
c9c49752
PE
3207 Fix more problems found by GCC 4.5.2's static checks.
3208
8abc3f12
PE
3209 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3210 the first time through the loop, since we know p0 < p1 then.
3211 This also avoids a gcc -Wstrict-overflow warning.
3212
a2d26660
PE
3213 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3214 leading to a memory leak, possible in functions like
3215 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3216 of objects (Bug#8318).
a2d26660 3217
916c72e9
PE
3218 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3219 that could (at least in theory) be that large.
3220
19ab8a18
PE
3221 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3222 This is less likely to overflow, and avoids undefined behavior if
3223 overflow does occur. All callers changed. Use strtoul to scan
3224 for the unsigned long integer.
b7cbbd6f
PE
3225 (pint2hrstr): Simplify and tune code slightly.
3226 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3227
f0641eff
PE
3228 * scroll.c (do_scrolling): Work around GCC bug 48228.
3229 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3230
7f650bb9
PE
3231 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3232 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3233 (validate_x_resource_name): Simplify count usage.
3234 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3235
37dd57d1
PE
3236 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3237 fail (Bug#8306).
81e56e61 3238
699979fc 3239 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3240
401bf9b4
PE
3241 * process.c (Fmake_network_process): Use socklen_t, not int,
3242 where POSIX says socklen_t is required in portable programs.
3243 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3244 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3245 (Fmake_network_process, server_accept_connection):
3246 (wait_reading_process_output, read_process_output):
3247 Likewise.
3248
b93aacde
PE
3249 * process.c: Rename or move locals to avoid shadowing.
3250 (list_processes_1, Fmake_network_process):
3251 (read_process_output_error_handler, exec_sentinel_error_handler):
3252 Rename or move locals.
4dc343ee 3253 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3254 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3255 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3256 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3257 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3258
af8a867c 3259 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3260 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3261 Include tparam.h instead, since it declares them.
af8a867c
PE
3262 * cm.h (PC): Remove extern decl; tparam.h now does this.
3263 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3264 * terminfo.c: Include tparam.h, to check interfaces.
3265 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3266 (tparam): Adjust signature to match interface in tparam.h;
3267 this removes some undefined behavior. Check that outstring and len
3268 are zero, which they always are with Emacs.
3269 * tparam.h (PC, BC, UP): New extern decls.
3270
0248044d 3271 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3272 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3273
8ff096c1 3274 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3275 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3276 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3277 (ftfont_list): Remove unused local.
49eaafba
PE
3278 (get_adstyle_property, ftfont_pattern_entity):
3279 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3280 Rename locals to avoid shadowing.
8ff096c1 3281
e2be39f6
PE
3282 * xfont.c (xfont_list_family): Mark var as initialized.
3283
c9735e30
PE
3284 * xml.c (make_dom): Now static.
3285
8f5201ae
PE
3286 * composite.c (composition_compute_stop_pos): Rename local to
3287 avoid shadowing.
b246f932
PE
3288 (composition_reseat_it): Remove unused locals.
3289 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3290 (composition_update_it): Mark var as initialized.
11b61122
PE
3291 (find_automatic_composition): Mark vars as initialized,
3292 with a FIXME (Bug#8290).
8f5201ae 3293
760fbc2c
PE
3294 character.h: Rename locals to avoid shadowing.
3295 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3296 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3297 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3298 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3299 to avoid shadowing.
3300
ff08eb85
PE
3301 * textprop.c (property_change_between_p): Remove; unused.
3302
fc7bf025
PE
3303 * intervals.c (interval_start_pos): Now static.
3304
235d7abc
PE
3305 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3306
44f230aa
SM
3307 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3308 Rename locals to avoid shadowing.
3e7d6594 3309
50060332
PE
3310 * sound.c (wav_play, au_play, Fplay_sound_internal):
3311 Fix pointer signedness.
d01f234b 3312 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3313 (wav_play): Initialize a variable to 0, to prevent undefined
3314 behavior (Bug#8278).
50060332 3315
c4fc4e30
PE
3316 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3317
918436ed
PE
3318 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3319
c939f91b
PE
3320 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3321 clobbering (Bug#8298).
b9c7f648
PE
3322 * sysdep.c (sys_subshell): Likewise.
3323 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3324
6bd8c144
PE
3325 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3326 This should get cleaned up, so that child_setup has the
3327 same signature on all platforms.
3328
7710357c 3329 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3330 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3331
c59da222
CY
33322011-03-22 Chong Yidong <cyd@stupidchicken.com>
3333
3334 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3335 not to be necessary, and produces flickering.
3336
66b87493
GM
33372011-03-20 Glenn Morris <rgm@gnu.org>
3338
3339 * config.in: Remove file.
3340
45b6f6d5
JB
33412011-03-20 Juanma Barranquero <lekktu@gmail.com>
3342
3343 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3344 are now in src/globals.h.
3345 (syms_of_minibuf): Remove spurious & from previous change.
3346
3ec03f7e
LL
33472011-03-20 Leo <sdl.web@gmail.com>
3348
3349 * minibuf.c (completing-read-function): New variable.
3350 (completing-read-default): Rename from completing-read.
3351 (completing-read): Call completing-read-function.
3352
b14e3e21
CY
33532011-03-19 Juanma Barranquero <lekktu@gmail.com>
3354
3355 * xfaces.c (Fx_load_color_file):
3356 Read color file from absolute filename (bug#8250).
3357
f2b726e6
JB
33582011-03-19 Juanma Barranquero <lekktu@gmail.com>
3359
3360 * makefile.w32-in: Update dependencies.
3361
09f6ff02
EZ
33622011-03-17 Eli Zaretskii <eliz@gnu.org>
3363
3364 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3365
29a6015a
PE
33662011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3367
a3a6c54e
PE
3368 Fix more problems found by GCC 4.5.2's static checks.
3369
b766f867
PE
3370 * process.c (make_serial_process_unwind, send_process_trap):
3371 (sigchld_handler): Now static.
3372
be02381c
PE
3373 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3374 That way, the code declares only the vars that it needs.
3375 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3376 * s/cygwin.h (PTY_ITERATION): Likewise.
3377 * s/darwin.h (PTY_ITERATION): Likewise.
3378 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3379
57048744
PE
3380 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3381 * process.c (allocate_pty): Don't declare stb unless it's needed.
3382
7914961c 3383 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3384 (CONSTANTLIM): Remove; unused.
3385 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3386 Define only if needed.
7914961c 3387
b3967b18
PE
3388 * unexelf.c (unexec): Name an expression,
3389 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3390 Use a different way to cause a compilation error if anyone uses
3391 n rather than nn, a way that does not involve shadowing.
73366a00 3392 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3393
29a6015a
PE
3394 * deps.mk (unexalpha.o): Remove; unused.
3395
43cfc33e 3396 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3397 * unexec.h: New file.
ce701a33
PE
3398 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3399 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3400 Depend on unexec.h.
3401 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3402 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3403 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3404 Change as necessary to match prototype in unexec.h.
ce701a33 3405
01f44d5a
PE
3406 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3407 shadowing.
4f63c6bb 3408 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3409
a6670b0b
PE
3410 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3411 Rename locals to avoid shadowing.
3412
cef2010d 3413 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3414 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3415
d4d7173a
PE
3416 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3417
f08b802a
PE
3418 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3419 warning when compiling print.c.
3420
3ddb0639
PE
3421 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3422 instead of using an uninitialized var.
5ad03b97 3423 (font_sort_entities): Mark var as initialized.
3ddb0639 3424
170a2692
PE
3425 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3426
e663c700
PE
3427 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3428 pointers to constants.
89bc529a 3429 (font_parse_fcname): Remove unused vars.
7b81e2d0 3430 (font_delete_unmatched): Now static.
ea838e10 3431 (font_get_spec): Remove; unused.
13a547c6
PE
3432 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3433 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3434 Rename or move locals to avoid shadowing.
e663c700 3435
2a80c887 3436 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3437 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3438
1384fa33 3439 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3440 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3441
8b2c52e9
PE
3442 * alloc.c (mark_backtrace): Move decl from here ...
3443 * lisp.h: ... to here, so that it can be checked.
3444
475545b5 3445 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3446 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3447 (lisp_indirect_variable): Name an expression,
3448 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3449 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3450
b1349114 3451 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3452 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3453 Use const pointer when appropriate.
b1349114 3454
a2928364
PE
3455 * lisp.h (get_system_name, get_operating_system_release):
3456 Move decls here, to check interfaces.
3457 * process.c (get_operating_system_release): Move decl to lisp.h.
3458 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3459 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3460 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3461 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3462 (Fformat_time_string, Fencode_time, Finsert_char):
3463 (Ftranslate_region_internal, Fformat):
3464 Rename or remove local vars to avoid shadowing.
9710023e 3465 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3466
a415e694
PE
3467 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3468 avoid shadowing.
3469
8ef4622d
PE
3470 * lisp.h (eassert): Check that the argument compiles, even if
3471 ENABLE_CHECKING is not defined.
3472
946f9a5b
PE
3473 * data.c (Findirect_variable): Name an expression, to avoid
3474 gcc -Wbad-function-cast warning.
112396d6 3475 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3476 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3477 (Fmake_variable_buffer_local, Fmake_local_variable):
3478 Mark variables as initialized.
52746918 3479 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3480
e5aab7e7 3481 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3482 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3483 Rename locals to avoid shadowing.
dff45157
PE
3484 (mark_stack): Move local variables into the #ifdef region where
3485 they're used.
7bc26fdb
PE
3486 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3487 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3488 needed otherwise.
3489 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3490 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3491 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3492
e5aab7e7
PE
3493 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3494 avoids undefined behavior in theory.
3495
4da60324
PE
3496 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3497
88043301
PE
3498 Use functions, not macros, for up- and down-casing (Bug#8254).
3499 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3500 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3501 to use the following functions instead of these macros.
3502 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3503 EMACS_INT, since callers assume the returned value fits in int.
3504 (upcase1): Likewise, for UPCASE_TABLE.
3505 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3506 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3507 the race-condition problem in the old DOWNCASE.
88043301 3508
19ed5445
PE
3509 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3510 Rename locals to avoid shadowing.
3511 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3512 (regex_compile, re_search_2, re_match_2_internal):
3513 Remove unused local vars.
952db0d7
PE
3514 (FREE_VAR): Rewrite so as not to use empty "else",
3515 which gcc can warn about.
da053e48 3516 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3517 (RETALLOC_IF): Define only if needed.
3518 (WORDCHAR_P): Likewise. This one is never needed, but is used
3519 only in a comment talking about a compiler bug, so put inside
3520 the #if 0 of that comment.
3521 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3522 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3523 Remove; unused.
19ed5445 3524
1f3561e4 3525 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3526 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3527 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3528
ded6f8f7
PE
3529 * search.c (simple_search): Remove unused var.
3530
dbd37a95
PE
3531 * dired.c (compile_pattern): Move decl from here ...
3532 * lisp.h: ... to here, so that it can be checked.
3533 (struct re_registers): New forward decl.
3534
7e47afad
PE
3535 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3536
85f24f61
PE
3537 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3538 All uses changed.
3539 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3540 Rename locals to avoid shadowing.
5671df8f 3541 (Fvertical_motion): Mark locals as initialized.
85f24f61 3542
181aa2be 3543 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3544 (casify_region): Mark local as initialized.
181aa2be 3545
930d429c
PE
3546 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3547
7082eac6
PE
3548 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3549 New macros, so that the caller can use some names other than
3550 gcpro1, gcpro2, etc.
3551 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3552 of the new macros.
3553 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3554 argument, for consistency with GCPRO2_VAR, etc: it is now the
3555 prefix of the variable, not the variable itself. All uses
3556 changed.
38b2c076
PE
3557 * dired.c (directory_files_internal, file_name_completion):
3558 Rename locals to avoid shadowing.
3559
15206ed9
PE
3560 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3561 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3562 dired.c's scmp function, had undefined behavior.
3563 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3564 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3565 * buffer.h: ... to here, because these macros use current_buffer,
3566 and the new implementation with inline functions needs to have
3567 current_buffer in scope now, rather than later when the macros
3568 are used.
3569 (downcase, upcase1): New static inline functions.
3570 (DOWNCASE, UPCASE1): Reimplement using these functions.
3571 This avoids undefined behavior in expressions like
3572 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3573 from race conditions in accessing the global variables
3574 case_temp1 and case_temp2.
3575 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3576 * lisp.h (case_temp1, case_temp2): Remove their decls.
3577 * character.h (ASCII_CHAR_P): Move from here ...
3578 * lisp.h: ... to here, so that the inline functions mentioned
3579 above can use them.
3580
4a6bea26
PE
3581 * dired.c (directory_files_internal_unwind): Now static.
3582
f14b7e14
PE
3583 * fileio.c (file_name_as_directory, directory_file_name):
3584 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3585 Now static.
2893f146
PE
3586 (file_name_as_directory): Use const pointers when appropriate.
3587 (Fexpand_file_name): Likewise. In particular, newdir might
3588 point at constant storage, so make it a const pointer.
fd4ead52 3589 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3590 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3591 signedness issues.
f839df0c
PE
3592 (Fset_file_times, Finsert_file_contents, auto_save_error):
3593 Rename locals to avoid shadowing.
f14b7e14 3594
5716756e 3595 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3596 (Ftry_completion, Fall_completions): Rename or remove locals
3597 to avoid shadowing.
5716756e 3598
b4c3046a
PE
3599 * marker.c (bytepos_to_charpos): Remove; unused.
3600
b45db522
PE
3601 * lisp.h (verify_bytepos, count_markers): New decls,
3602 so that gcc does not warn that these functions aren't declared.
3603
85876d07
PE
3604 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3605 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3606 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3607 (copy_text): Remove unused local var.
85876d07 3608
03d78a21 3609 * filelock.c (within_one_second): Now static.
b3dd38ab 3610 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3611
5df8f01b
PE
3612 * buffer.c (fix_overlays_before): Mark locals as initialized.
3613 (fix_start_end_in_overlays): Likewise. This function should be
3614 simplified by using pointers-to-pointers, but that's a different
3615 matter.
b1d876f1 3616 (switch_to_buffer_1): Now static.
8f54f30a
PE
3617 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3618 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3619
a70072c9 3620 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3621 Fix pointer signedness issue.
edced198
PE
3622 (sys_subshell): Mark local as volatile if checking for lint,
3623 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3624 (MAXPATHLEN): Define only if needed.
a70072c9 3625
a0977c44
PE
3626 * process.c (serial_open, serial_configure): Move decls from here ...
3627 * systty.h: ... to here, so that they can be checked.
3628
a884fdcc
PE
3629 * fns.c (get_random, seed_random): Move extern decls from here ...
3630 * lisp.h: ... to here, so that they can be checked.
3631
604efe86 3632 * sysdep.c (reset_io): Now static.
b8950c94 3633 (wait_for_termination_signal): Remove; unused.
604efe86 3634
38fc62d9
PE
3635 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3636 (copy_keymap_item, append_key, push_text_char_description):
3637 Now static.
1004a21a 3638 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3639 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3640 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3641 (describe_map_tree):
3642 Rename locals to avoid shadowing.
38fc62d9 3643
2f2650da
PE
3644 * keyboard.c: Declare functions static if they are not used elsewhere.
3645 (echo_char, echo_dash, cmd_error, top_level_2):
3646 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3647 (read_char, kbd_buffer_get_event, make_lispy_position):
3648 (make_lispy_event, make_lispy_movement, apply_modifiers):
3649 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3650 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3651 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3652 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3653 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3654
a053e86c 3655 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3656 (mark_kboards): Move decl here ...
3657 * alloc.c (mark_kboards): ... from here.
a053e86c 3658
4752793e
PE
3659 * lisp.h (force_auto_save_soon): New decl.
3660
74f10ca7 3661 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3662 (DEFINE_DUMMY_FUNCTION): New macro.
3663 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3664 Use it.
c03cd23f
PE
3665 (main): Add casts to avoid warnings
3666 if GCC considers string literals to be constants.
74f10ca7 3667
022e70d4
PE
3668 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3669
59d6fe83
PE
3670 * dbusbind.c: Pointer signedness fixes.
3671 (xd_signature, xd_append_arg, xd_initialize):
3672 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3673 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3674 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3675 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3676
78320123
PE
3677 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3678 if GCC considers string literals to be constants.
49cebcca 3679 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3680
35ac2a97
SM
36812011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3682
fb103ca9
SM
3683 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3684 (print_preprocess, print_object): New macro to fix last change.
3685
35ac2a97
SM
3686 * print.c (print_preprocess): Don't forget font objects.
3687
62973b41
JB
36882011-03-16 Juanma Barranquero <lekktu@gmail.com>
3689
3690 * emacs.c (USAGE3): Doc fixes.
3691
0e48bb22
AS
36922011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3693
3694 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3695 structure.
3696
7684e57b
JB
36972011-03-14 Juanma Barranquero <lekktu@gmail.com>
3698
3699 * lisp.h (VWindow_system, Qfile_name_history):
3700 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3701 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3702 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3703
3704 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3705 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3706
3707 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3708 * w32console.c (detect_input_pending, read_input_pending)
3709 (encode_terminal_code):
3710 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3711 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3712 (w32_system_caret_y, Qfile_name_history):
3713 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3714 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3715 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3716 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3717 * w32proc.c (Qlocal, report_file_error):
3718 * w32term.c (Vwindow_system, updating_frame):
3719 * w32uniscribe.c (initialized, uniscribe_font_driver):
3720 Remove unneeded extern declarations.
3721
2aa46d6c
CY
37222011-03-14 Chong Yidong <cyd@stupidchicken.com>
3723
c96bbc66 3724 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3725
cffc6f3b
CY
37262011-03-13 Chong Yidong <cyd@stupidchicken.com>
3727
3728 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3729 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3730 These macros can no longer be used for assignment.
3731
44f230aa
SM
3732 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3733 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3734 (record_buffer_markers, fetch_buffer_markers): New functions for
3735 recording and fetching special buffer markers.
3736 (set_buffer_internal_1, set_buffer_temp): Use them.
3737
3738 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3739
3740 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3741
3742 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3743 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3744
3745 * xdisp.c (hscroll_window_tree):
3746 (reconsider_clip_changes): Use PT instead of BUF_PT.
3747
d251f04b
EZ
37482011-03-13 Eli Zaretskii <eliz@gnu.org>
3749
3750 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3751 $(EMACS_ROOT)/lib/intprops.h.
3752
f0c77cd1
PE
37532011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3754
3eca4629
PE
3755 Fix more problems found by GCC 4.5.2's static checks.
3756
7c86ee98
PE
3757 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3758 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3759 (xg_free_frame_widgets): Make it clear that a local variable is
3760 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3761 (gdk_window_get_screen): Make it clear that this macro is needed
3762 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3763 (int_gtk_range_get_value): New function, which avoids a diagnostic
3764 from gcc -Wbad-function-cast.
3765 (xg_set_toolkit_scroll_bar_thumb): Use it.
3766 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3767 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3768 (get_utf8_string, xg_get_file_with_chooser):
3769 Rename locals to avoid shadowing.
3770 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3771
41729b81
PE
3772 * xgselect.c (xg_select): Remove unused var.
3773
f0c77cd1
PE
3774 * image.c (four_corners_best): Mark locals as initialized.
3775 (gif_load): Initialize transparent_p to zero (Bug#8238).
3776 Mark another local as initialized.
ec6cf4c6 3777 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3778
ce0ad53d 3779 * image.c (clear_image_cache): Now static.
d5d5a617 3780 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3781 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3782 (x_edge_detection): Remove unnecessary cast that
3783 gcc -Wbad-function-cast diagnoses.
2037898d 3784 (gif_load): Fix pointer signedness.
6ae141d6
PE
3785 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3786 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3787
33383987 37882011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3789
d32df629
PE
3790 Improve quality of tests for time stamp overflow.
3791 For example, without this patch (encode-time 0 0 0 1 1
3792 1152921504606846976) returns the obviously-bogus value (-948597
3793 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3794 reports time overflow. See
3795 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3796 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3797 * editfns.c: Include limits.h and intprops.h.
3798 (TIME_T_MIN, TIME_T_MAX): New macros.
3799 (time_overflow): Move earlier, to before first use.
3800 (hi_time, lo_time): New functions, for an accurate test for
3801 out-of-range times.
3802 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3803 (Fget_internal_run_time): Don't assume time_t fits in int.
3804 (make_time): Use list2 instead of Fcons twice.
3805 (Fdecode_time): More accurate test for out-of-range times.
3806 (check_tm_member): New function.
3807 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3808 (lisp_time_argument): Don't rely on undefined left-shift and
3809 right-shift behavior when checking for time stamp overflow.
8be6f318 3810
fe31d94c
PE
3811 * editfns.c (time_overflow): New function, refactoring common code.
3812 (Fformat_time_string, Fdecode_time, Fencode_time):
3813 (Fcurrent_time_string): Use it.
3814
8be6f318
PE
3815 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3816 * dired.c (make_time): Move to ...
3817 * editfns.c (make_time): ... here.
3818 * systime.h: Note the move.
3819
09d9db2c 38202011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3821
126bc0dc
YM
3822 * fringe.c (update_window_fringes): Remove unused variables.
3823
c47cbdfd
YM
3824 * unexmacosx.c (copy_data_segment): Also copy __got section.
3825 (Bug#8223)
3826
7ac80be9
EZ
38272011-03-12 Eli Zaretskii <eliz@gnu.org>
3828
c96bbc66 3829 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3830 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3831 Constify `char *' arguments and their references according to
3832 prototypes in tparam.h.
3833
ecb0f94d 3834 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3835
7ac80be9
EZ
3836 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3837 Adapt all references accordingly.
3838
3839 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3840
ef1fd07e
TT
38412011-03-11 Tom Tromey <tromey@redhat.com>
3842
3843 * buffer.c (syms_of_buffer): Remove obsolete comment.
3844
7ef4b50c
EZ
38452011-03-11 Eli Zaretskii <eliz@gnu.org>
3846
3847 * termhooks.h (encode_terminal_code): Declare prototype.
3848
3849 * msdos.c (encode_terminal_code): Don't declare prototype.
3850
3851 * term.c (encode_terminal_code): Now external again, used by
3852 w32console.c and msdos.c.
3853
44f230aa
SM
3854 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3855 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3856
4b1ec863 38572011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3858
1714f52b 3859 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3860
4b1ec863
PE
3861 * fringe.c (update_window_fringes): Mark locals as initialized
3862 (Bug#8227).
3863 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3864
524c7aa6
PE
3865 * alloc.c (mark_fringe_data): Move decl from here ...
3866 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3867 to check its interface.
3868 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3869
a5c0af81 3870 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3871 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3872 (fontset_font): Mark local as initialized.
a9a06e0b 3873 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3874
b4716021
PE
3875 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3876
811e9bac 3877 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3878 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3879 (x_own_selection, Fx_disown_selection_internal): Rename locals
3880 to avoid shadowing.
3881 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3882
7e3ab302
PE
3883 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3884 so that the caller can use some name other than gcpro1.
3885 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3886 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3887 (Fx_backspace_delete_keys_p):
3888 Use them to avoid shadowing, and rename vars to avoid shadowing.
3889 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3890 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3891 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3892 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3893 Remove unused locals.
7e3ab302
PE
3894 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3895 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3896 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3897 macros.
f78faa98 3898
e2b13473
PE
3899 * xterm.h (x_mouse_leave): New decl.
3900
77f23912
PE
3901 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3902 Remove unused functions.
cdf4ba58
PE
3903 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3904 (x_calc_absolute_position): Now static.
7411c686 3905 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3906 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3907 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3908 unless they are used.
38d0b34a
PE
3909 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3910 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3911 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3912 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3913 (x_error_catcher, x_connection_closed, x_error_handler):
3914 (x_error_quitter, xembed_send_message, x_iconify_frame):
3915 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3916 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3917 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3918
44f230aa
SM
3919 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3920 Rename or move locals to avoid shadowing.
6b463e58 3921 (tty_defined_color, merge_face_heights): Now static.
5967d051 3922 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3923 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3924 does not deduce is never used uninitialized.
73719eba
PE
3925 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3926 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3927
426994c3 3928 * terminal.c (store_terminal_param): Now static.
5489860b 3929
032f1620 3930 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3931 (set_frame_menubar): Remove unused local.
d4323972 3932 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3933 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3934 since they might point to immutable storage.
281585b0
PE
3935 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3936 since it's unused otherwise.
032f1620 3937
367c19e5 3938 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3939 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3940 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3941 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3942 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3943 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3944 does not deduce are never used uninitialized.
70739cbe 3945
07b48fa9
PE
3946 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3947
8868a238 3948 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3949 * window.c (window_loop, size_window):
3950 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3951
7e5cf297 3952 * window.c (display_buffer): Now static.
d6550a9f
PE
3953 (size_window): Mark variables that gcc -Wuninitialized
3954 does not deduce are never used uninitialized.
a586633d
PE
3955 * window.h (check_all_windows): New decl, to forestall
3956 gcc -Wmissing-prototypes diagnostic.
5b555da1 3957 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3958
f6095868
PE
3959 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3960 shadowing.
3961 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3962 Include <limits.h>.
3963 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3964 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3965 (load_charset_map): Mark variables that gcc -Wuninitialized
3966 does not deduce are never used uninitialized.
53df7c11 3967 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3968
f38b440c
PE
3969 * coding.c (coding_set_source, coding_set_destination):
3970 Use "else { /* comment */ }" rather than "else /* comment */;"
3971 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3972 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3973 a block, when the outer 'i' will do.
3974 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3975 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3976 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3977 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3978 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3979 Rename locals to avoid shadowing.
3980 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3981 * coding.c (emacs_mule_char, encode_invocation_designation):
3982 Now static, since they're not used elsewhere.
413bb2db 3983 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3984 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3985 (decode_coding_emacs_mule): Mark variables that gcc
3986 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3987 (detect_coding_iso_2022): Initialize a local variable that might
3988 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3989 this initialization is needed. (Bug#8211)
5f58e762
PE
3990 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3991 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3992 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3993 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3994 Remove unused macros.
f38b440c 3995
232b38b9 3996 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3997 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3998 * character.c (string_count_byte8): Likewise.
232b38b9 3999
fb90da1b
PE
4000 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4001 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4002
fb93dbc2
PE
4003 * chartab.c (copy_sub_char_table): Now static, since it's not used
4004 elsewhere.
5c156ace
PE
4005 (sub_char_table_ref_and_range, char_table_ref_and_range):
4006 Rename locals to avoid shadowing.
bbcd0949 4007 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4008
7d3b3862 4009 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4010 (BIDI_BOB): Remove unused macro.
7d3b3862 4011
6be7d3da
PE
4012 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4013 deduce are never used uninitialized.
c2ed9c8b 4014 * term.c (encode_terminal_code): Likewise.
6be7d3da 4015
75f8807f 4016 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4017
50938595
PE
4018 * tparam.h: New file.
4019 * term.c, tparam.h: Include it.
4020 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4021 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4022 Move these decls to tparam.h, and make them agree with what
4023 is actually in tparam.c. The previous trick of using incompatible
4024 decls in different modules does not conform to the C standard.
4025 All callers of tparam changed to use tparam's actual API.
4026 * tparam.c (tparam1, tparam, tgoto):
4027 Use const pointers where appropriate.
4028
fbceeba2
PE
4029 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4030 * cm.h (struct cm): Likewise.
4031 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4032 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4033 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4034 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4035 (turn_on_face, init_tty): Likewise.
4036 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4037
7f3f1250
PE
4038 * term.c (term_mouse_position): Rename local to avoid shadowing.
4039
e6ca6543
PE
4040 * alloc.c (mark_ttys): Move decl from here ...
4041 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4042
c40f8d15
AS
40432011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4044
4045 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4046
cfe0661d
JB
40472011-03-09 Juanma Barranquero <lekktu@gmail.com>
4048
4049 * search.c (compile_pattern_1): Remove argument regp, unused since
4050 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4051 (compile_pattern): Don't pass it.
4052
0afb4571
J
40532011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4054
4055 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4056 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4057 for ! HAVE_GTK3.
4058 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4059
4060 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4061
4062 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4063 gdk_window_get_screen, gdk_window_get_geometry,
4064 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4065 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4066 (xg_get_pixbuf_from_pixmap): New function.
4067 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4068 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4069 Call xg_get_pixbuf_from_pixmap instead of
4070 gdk_pixbuf_get_from_drawable.
4071 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4072 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4073 (xg_check_special_colors): Use GtkStyleContext and its functions
4074 for HAVE_GTK3.
4075 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4076 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4077 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4078 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4079 Call gtk_widget_get_preferred_size.
0afb4571
J
4080 (xg_frame_resized): gdk_window_get_geometry only takes 5
4081 parameters.
44f230aa
SM
4082 (xg_win_to_widget, xg_event_is_for_menubar):
4083 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4084 (xg_set_widget_bg): New function.
4085 (delete_cb): New function.
895009e1 4086 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4087 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4088 (xg_set_background_color): Call xg_set_widget_bg.
4089 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4090 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4091 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4092 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4093 if ! HAVE_GTK3.
4094 (update_frame_tool_bar): Call gtk_widget_hide.
4095 (xg_initialize): Use GDK_KEY_g.
4096
4097 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4098 if ! HAVE_GTK3
4099 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4100
4101 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4102 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4103 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4104
1c2cc4ef
JB
41052011-03-08 Juanma Barranquero <lekktu@gmail.com>
4106
4107 * w32xfns.c (select_palette): Check success of RealizePalette against
4108 GDI_ERROR, not zero.
4109
33383987 4110See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4111
4112;; Local Variables:
4113;; coding: utf-8
aac0c6e3
MR
4114;; End:
4115
33383987 4116 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4117
4118 This file is part of GNU Emacs.
4119
4120 GNU Emacs is free software: you can redistribute it and/or modify
4121 it under the terms of the GNU General Public License as published by
4122 the Free Software Foundation, either version 3 of the License, or
4123 (at your option) any later version.
4124
4125 GNU Emacs is distributed in the hope that it will be useful,
4126 but WITHOUT ANY WARRANTY; without even the implied warranty of
4127 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4128 GNU General Public License for more details.
4129
4130 You should have received a copy of the GNU General Public License
4131 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.