* editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
a02719a3
PE
12011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2
3 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4 This occurs when processing a multibyte format, which can happen
5 when using 'eval'. Problem reported by Wolfgang Jenker.
6
72589a3c
JB
72011-09-15 Johan Bockgård <bojohan@gnu.org>
8
9 * xdisp.c (try_cursor_movement): Only check for exact match if
10 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
11
1c14176c
PE
122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
13
14 Remove unused external symbols.
15 * dispextern.h (calc_pixel_width_or_height): Remove decl.
16 * xdisp.c (calc_pixel_width_or_height): Now static.
17 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
18 * indent.c (check_display_width):
19 * w32term.c: Fix comment to match code.
20 * xterm.c, xterm.h (x_catching_errors): Remove.
21
d2eea5b5
PE
222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
23
24 * xselect.c: Use signed conversions more consistently (Bug#9498).
25 (selection_data_to_lisp_data): Assume incoming selection data are
26 signed integers, not unsigned. This is to be consistent with
27 outgoing selection data, which was modified to use signed integers
28 in as part of the fix to Bug#9196 in response to Jan D.'s comment
29 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
30 expects long, not unsigned long.
31
46888499
EZ
322011-09-14 Eli Zaretskii <eliz@gnu.org>
33
34 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
35 computation of loop end. Reported by Johan Bockgård
36 <bojohan@gnu.org>.
37
ef8ef9fb
CY
382011-09-13 Chong Yidong <cyd@stupidchicken.com>
39
40 * frame.c (Fother_visible_frames_p): Function deleted.
41
fa819fed
EZ
422011-09-12 Eli Zaretskii <eliz@gnu.org>
43
44 * indent.c (compute_motion): Process display vector front to back
45 rather than the other way around. (Bug#2496)
46
2ba8e008
SM
472011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
48
49 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
50
20f53c69
CY
512011-09-11 Chong Yidong <cyd@stupidchicken.com>
52
53 * minibuf.c (Fread_from_minibuffer): Doc fix.
54
d562d7a4
EZ
552011-09-11 Eli Zaretskii <eliz@gnu.org>
56
57 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
58 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
59
1c4d7f3d
LMI
602011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
61
62 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
63 value for non-existent files.
64
b885bf36
EZ
652011-09-11 Eli Zaretskii <eliz@gnu.org>
66
67 * fileio.c (Finsert_file_contents): If the file cannot be opened,
68 set its "size" to -1. This will set the modtime_size field of
69 the corresponding buffer to -1, which is what
70 verify-visited-file-modtime expects for files that do not exist.
71 (Bug#9139)
72
6612f0bf
PE
732011-09-11 Paul Eggert <eggert@cs.ucla.edu>
74
75 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
76 here ...
77 * lisp.h: ... from here. push_key_description is no longer
78 defined in keyboard.c, so its declaration should not be in
79 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
80 logically belongs with push_key_description.
81
dfb3f755
PE
822011-09-10 Paul Eggert <eggert@cs.ucla.edu>
83
84 * buffer.h: Include <sys/types.h> instead of <time.h>.
85 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
86 Problem reported by Herbert J. Skuhra.
87
3134906c
LMI
882011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
89
90 * xml.c (parse_region): Make the parsing work for
91 non-comment-starting XML files again (bug#9144).
92
8d903f4e
AS
932011-09-10 Andreas Schwab <schwab@linux-m68k.org>
94
95 * image.c (gif_load): Fix calculation of bottom and right corner.
96 (Bug#9468)
97
80ad64f4
EZ
982011-09-10 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
101 redisplay in small windows.
102
208a048d
EZ
1032011-09-09 Eli Zaretskii <eliz@gnu.org>
104
105 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
106
9b1c252e
MR
1072011-09-08 Martin Rudalics <rudalics@gmx.at>
108
109 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
110 Operate on live windows only.
111
2949f33b
JB
1122011-09-08 Juanma Barranquero <lekktu@gmail.com>
113
114 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
115
e08dcafd
EZ
1162011-09-07 Eli Zaretskii <eliz@gnu.org>
117
118 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
119 only under bidi iteration.
120
115b96bd
JD
1212011-09-07 Jan Djärv <jan.h.d@swipnet.se>
122
123 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
124
c8199d0f
PE
1252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
126
127 isnan: Fix porting problem to Solaris 10 with bundled gcc.
128 Without this fix, the command to link temacs failed due to an
129 undefined symbol __builtin_isnan. This is because
130 /usr/include/iso/math_c99.h #defines isnan(x) to
131 __builtin_isnan(x), but the bundled gcc, which identifies itself
132 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
133 a __builtin_isnan.
134 * floatfns.c (isnan): #undef, and then #define to a clone of
135 what's in data.c.
136 (Fisnan): Always define, since it's always available now.
137 (syms_of_floatfns): Always define isnan at the Lisp level.
138
e39b275c 1392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
140
141 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
142
b2db44d9 1432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 144
f4af5137 145 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
146 The previous code assumed that file offsets (off_t values) fit in
147 EMACS_INT variables, which is not true on typical 32-bit hosts.
148 The code messed up by falsely reporting buffer overflow in cases
149 such as (insert-file-contents "big" nil 1 2) into an empty buffer
150 when "big" contains more than 2**29 bytes, even though this
151 inserts just one byte and does not overflow the buffer.
152 (Finsert_file_contents): Store file offsets as off_t
153 values, not as EMACS_INT values. Check for overflow when
154 converting between EMACS_INT and off_t. When checking for
155 buffer overflow or for overlap, take the offsets into account.
156 Don't use EMACS_INT for small values where int suffices.
157 When checking for overlap, fix a typo: ZV was used where
158 ZV_BYTE was intended.
159 (Fwrite_region): Don't assume off_t fits into 'long'.
160 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
161
ecfc0a49
MA
1622011-09-05 Michael Albinus <michael.albinus@gmx.de>
163
164 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
165
6511acf2 1662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 167
0999621a 168 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
169
170 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 171 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
172 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
173 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
174 (modify_event_symbol): Do not assume that the length of
175 name_alist_or_stem is safe to alloca and fits in int.
176 (Fexecute_extended_command): Likewise for function name and binding.
177 (Frecursion_depth): Wrap around reliably on integer overflow.
178 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
179 since some callers pass EMACS_INT values.
180 (Fsingle_key_description): Don't crash if symbol name contains more
181 than MAX_ALLOCA bytes.
182 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
183 (get_minibuffer): Arg is now EMACS_INT, not int.
184 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 185 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
186 * window.h (command_loop_level, minibuf_level): Reflect API changes.
187
2be7d702
PE
188 * dbusbind.c (signature_cat): New function.
189 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
190 Do not overrun buffer; instead, report string overflow.
191
9d1df220
PE
192 * dispnew.c (add_window_display_history): Don't overrun buffer.
193 Truncate instead; this is OK since it's just a log.
194
33ef5c64
PE
195 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
196 even if the time zone offset is outlandishly large.
197 Don't mishandle offset == INT_MIN.
198
66c6fdd5
PE
199 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
200 when creating daemon; the previous buffer-overflow check was incorrect.
201
d749b01b
PE
202 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
203 which has the guts of the old verror function.
204
b5cd1905
PE
205 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
206 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
207
6e1a67fb
PE
208 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
209 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 210 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 211 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
212 length of string rather than counting it via multiple sprintfs;
213 that's simpler and more reliable.
c21721cc
PE
214 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
215 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
216 sprintf, in case result does not fit in int.
217
c57b67fc
PE
218 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
219 (fontset_from_font): Print it.
220
8a401434
PE
221 * frame.c (tty_frame_count): Now printmax_t, not int.
222 (make_terminal_frame, set_term_frame_name): Print it.
223 (x_report_frame_params): In X, window IDs are unsigned long,
224 not signed long, so print them as unsigned.
225 (validate_x_resource_name): Check for implausibly long names,
226 and don't assume name length fits in 'int'.
227 (x_get_resource_string): Don't blindly alloca invocation name;
228 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
229 not fit in int.
230
6e1a67fb
PE
231 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
232 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
233 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
234
0df02bf3
PE
235 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
236 Use esprintf, not sprintf, in case result does not fit in int.
237
48e30793
PE
238 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
239 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
240 it as a large positive number.
241 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
242 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
243
a66ff6d8
PE
244 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
245 in case result does not fit in int.
246
aca216ff
PE
247 * print.c (float_to_string): Detect width overflow more reliably.
248 (print_object): Make sprintf buffer a bit bigger, to avoid potential
249 buffer overrun. Don't assume list length fits in 'int'. Treat
250 print length of 0 as 0, not as infinity; to be consistent with other
251 uses of print length in this function. Don't overflow print length
252 index. Don't assume hash table size fits in 'long', or that
253 vectorlike size fits in 'unsigned long'.
254
31c286f7
PE
255 * process.c (make_process): Use printmax_t, not int, to format
256 process-name gensyms.
257
55e5faa1
PE
258 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
259
80f2e268
PE
260 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
261 to avoid potential buffer overrun.
262
670741ab
PE
263 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
264 if X resource line is longer than 512 bytes.
265
b7163a50
PE
266 * xfns.c (x_window): Make sprintf buffer a bit bigger
267 to avoid potential buffer overrun.
268
ae58ff1f
PE
269 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
270
c43c8a6a
PE
271 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
272
3f8236f4
PE
2732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
274
53e9fe90 275 Integer overflow fixes for scrolling, etc.
6511acf2
PE
276 Without these, Emacs silently mishandles large integers sometimes.
277 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
278 it were "C-u 1 M-x recenter" on a typical 64-bit host.
279
6511acf2
PE
280 * xdisp.c (try_window_id): Check Emacs fixnum range before
281 converting to 'int'.
806add1d 282
6511acf2 283 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
284 Check that an Emacs fixnum is in range before assigning it to 'int'.
285 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
286 values converted from Emacs fixnums.
287 (Frecenter): Don't wrap around a line count if it is out of 'int'
288 range; instead, treat it as an extreme value.
289 (Fset_window_configuration, compare_window_configurations):
290 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
291
6511acf2
PE
292 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
293 that can exceed INT_MAX. Check that EMACS_INT value is in range
294 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
295 (match_limit): Don't assume that a fixnum can fit in 'int'.
296
6511acf2 297 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
298 exceed INT_MAX.
299
6511acf2 300 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
301 (Fvertical_motion): Don't wrap around LINES values that don't fit
302 in 'int'. Instead, treat them as extreme values. This is good
303 enough for windows, which can't have more than INT_MAX lines anyway.
304
fcb901a7
LMI
3052011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
306
0f2f6b6d
LMI
307 * Require libxml/parser.h to avoid compilation warning.
308
fcb901a7
LMI
309 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
310
311 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
312 since this reportedly can destroy thread storage.
313
6e20a0d4
CY
3142011-08-30 Chong Yidong <cyd@stupidchicken.com>
315
316 * syntax.c (find_defun_start): Update all cache variables if
317 exiting early (Bug#9401).
318
148ae00e
EZ
3192011-08-30 Eli Zaretskii <eliz@gnu.org>
320
f6cfbd8f
EZ
321 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
322
148ae00e
EZ
323 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
324 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
325 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
326
327 * term.c (tty_append_glyph): New function.
328 (produce_stretch_glyph): Static function and its prototype deleted.
329
330 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
331 prototypes.
332
c4a07a4c
PE
3332011-08-29 Paul Eggert <eggert@cs.ucla.edu>
334
335 * image.c (parse_image_spec): Check for nonnegative, not for positive,
336 when checking :margin (Bug#9390).
337 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
338 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
339 so that the name doesn't mislead. All uses changed.
340
6bc8cd65
JB
3412011-08-28 Johan Bockgård <bojohan@gnu.org>
342
343 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
344 set_tty_hooks.
345
dca4927e
EZ
3462011-08-27 Eli Zaretskii <eliz@gnu.org>
347
348 * xdisp.c (move_it_to): Don't bail out early when reaching
349 position beyond to_charpos, if we are scanning backwards.
350 (move_it_vertically_backward): When DY == 0, make sure we get to
351 the first character in the line after the newline.
352
f2cad773
PE
3532011-08-27 Paul Eggert <eggert@cs.ucla.edu>
354
355 * ccl.c: Improve and simplify overflow checking (Bug#9196).
356 (ccl_driver): Do not generate an out-of-range pointer.
357 (Fccl_execute_on_string): Remove unnecessary check for
358 integer overflow, noted by Stefan Monnier in
359 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
360 Remove a FIXME that didn't need fixing.
361 Simplify the newly-introduced buffer reallocation code.
362
0cae2cdb
JB
3632011-08-27 Juanma Barranquero <lekktu@gmail.com>
364
365 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
366
5fc295a4 3672011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 368
70c60eb2 369 Integer and memory overflow issues (Bug#9196).
726e0ab1 370
d31850da
PE
371 * doc.c (get_doc_string): Rework so that
372 get_doc_string_buffer_size is the actual buffer size, rather than
373 being 1 less than the actual buffer size; this makes xpalloc more
374 convenient.
375
a69fbedb
PE
376 * image.c (x_allocate_bitmap_record, cache_image):
377 * xselect.c (Fx_register_dnd_atom):
378 Simplify previous changes by using xpalloc.
379
fe5c5d37
PE
380 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
381 since either will do and ptrdiff_t is convenient with xpalloc.
382
0065d054
PE
383 * charset.c (charset_table_size)
384 (struct charset_sort_data.priority): Now ptrdiff_t.
385 (charset_compare): Don't overflow if priorities differ greatly.
386 (Fsort_charsets): Don't assume list length fits in int.
387 Check for size-calculation overflow when allocating sort data.
388 (syms_of_charset): Allocate an initial charset table that is
389 just under 64 KiB, to avoid problems with glibc malloc and mmap.
390
391 * cmds.c (internal_self_insert): Check for size-calculation overflow.
392
393 * composite.h (struct composition.glyph_len): Now int, not unsigned.
394 The actual value is always <= INT_MAX, and leaving it unsigned made
395 overflow checking harder.
396
397 * dispextern.h (struct glyph_matrix.rows_allocated)
398 (struct face_cache.size): Now ptrdiff_t, for convenience in use
399 with xpalloc. The values are still always <= INT_MAX.
400
401 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
402
403 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
404 (SAFE_NALLOCA): New macro.
405
406 * region-cache.c (struct boundary.pos, find_cache_boundary)
407 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
408 (set_cache_region, invalidate_region_cache)
409 (revalidate_region_cache, know_region_cache, region_cache_forward)
410 (region_cache_backward, pp_cache):
411 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
412 so that ptrdiff_t * can be passed to xpalloc.
413 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
414 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
415 (pp_cache): Don't assume cache_len fits in int.
416 * region-cache.h: Adjust extern decls to match.
417
418 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
419 EMACS_INT, since either will do, for xpalloc.
420
421 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
422 (xnmalloc, xnrealloc, xpalloc): New functions.
423
726e0ab1
PE
424 * bidi.c (bidi_shelve_header_size): New constant.
425 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
426 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
427
51f30bc5 428 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
429 * buffer.c (overlays_at, overlays_in, record_overlay_string)
430 (overlay_strings):
431 Don't update size of array until after memory allocation succeeds,
432 because xmalloc/xrealloc may not return.
0065d054
PE
433 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
434 now that we have proper integer overflow checking.
435 (record_overlay_string, overlay_strings): Catch overflows when
436 calculating size of overlay_str_buf.
726e0ab1 437
0065d054
PE
438 * callproc.c (Fcall_process): Check for size overflow when
439 calculating size of args2.
440 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
441 Normally we prefer signed values, but sticking with ptrdiff_t would
442 require adding more-complicated checks.
726e0ab1
PE
443
444 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
445 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
446 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 447 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
448
449 * character.c (Fstring): Check for size-calculation overflow.
450
451 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
452 unnecessary integer overflow. Check for size overflow.
453 (encode_coding_object): Don't update size until xmalloc succeeds.
454
455 * composite.c (get_composition_id): Check for overflow in glyph
456 length calculations.
457
458 Integer and memory overflow fixes for display code.
459 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
460 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
461 (scrolling_window): Check for overflow in size calculations.
462 (line_draw_cost, realloc_glyph_pool, add_row_entry):
463 Don't assume glyph table len fits in int.
464 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
465 (row_table_size): Now ptrdiff_t, not int.
466 (scrolling_window): Avoid overflow in size calculations.
467 Don't update size until allocation succeeds.
468 * fns.c (concat): Check for overflow in size calculations.
469 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
470 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
471 (NEXT_ALMOST_PRIME_LIMIT): New constant.
472
473 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
474 (get_doc_string): Check for size calculation overflow.
475 Don't update size until allocation succeeds.
476 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
477 EMACS_INT, where ptrdiff_t will do.
478 (Fsubstitute_command_keys): Check for string overflow.
479
480 * editfns.c (set_time_zone_rule): Don't assume environment length
481 fits in int.
482 (message_length): Now ptrdiff_t, not int.
483 (Fmessage_box): Don't update size until allocation succeeds.
484 Don't assume message length fits in int.
485 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
486
0065d054
PE
487 * emacs.c (main): Do not reallocate argv, since there is a null at
488 the end that can be overwritten, and this way there's no need to
489 worry about size-calculation overflow.
490 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
491
492 * eval.c (init_eval_once, grow_specpdl): Don't update size until
493 alloc succeeds.
494 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
495
496 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
497 (x_set_scroll_bar_width, x_figure_window_size):
498 Check for integer overflow.
499 (x_set_alpha): Do not assume XINT fits in int.
500
501 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
502 This is for the members text_lines, text_cols, total_lines, total_cols,
503 where the system imposes an 'int' limit.
504
505 * fringe.c (Fdefine_fringe_bitmap):
506 Don't update size until alloc works.
507
508 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
509 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
510
511 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
512 Check for size-calculation overflow.
513 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
514 do, as we prefer signed integers.
515 (id_to_widget.max_size, id_to_widget.used)
516 (xg_store_widget_in_map, xg_remove_widget_from_map)
517 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
518 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
519 Use and return ptrdiff_t, not int.
520 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
521 * gtkutil.h: Change prototypes to match the above.
522
523 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
524 are duplicate now that they've been promoted to lisp.h.
525 (x_allocate_bitmap_record, x_alloc_image_color)
526 (make_image_cache, cache_image, xpm_load):
527 Don't update size until alloc is done.
528 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
529 (x_detect_edges):
3256efce 530 Check for size calculation overflow.
726e0ab1
PE
531 (ct_colors_allocated_max): New constant.
532 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
533 overflow.
3256efce 534
726e0ab1
PE
535 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
536 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
537 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
538 Use ptrdiff_t, not int, to count maps.
539 (read_char_minibuf_menu_prompt): Check for overflow in size
540 calculations. Don't update size until allocation succeeds. Redo
541 calculations to avoid overflow.
542 * keyboard.h: Change prototypes to match the above.
543
544 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
545 to count maps.
546 (current_minor_maps): Check for size calculation overflow.
547 * keymap.h: Change prototypes to match the above.
548
549 * lread.c (read1, init_obarray): Don't update size until alloc done.
550
551 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
552 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
553
726e0ab1
PE
554 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
555 Now ptrdiff_t, not int.
556 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
557 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
558
559 * process.c (Fnetwork_interface_list): Check for overflow
560 in size calculation.
561
562 * region-cache.c (move_cache_gap): Check for size calculation overflow.
563
564 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
565 overflow. Don't bother calling xmalloc when xrealloc will do.
566
567 * search.c (Freplace_match): Check for size calculation overflow.
568 (Fset_match_data): Don't assume list lengths fit in 'int'.
569
570 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
571 for command line length. Do not attempt to address one before the
572 beginning of an array, as that's not portable.
573
574 * term.c (max_frame_lines): Remove; unused.
575 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
576 not int.
577 (encode_terminal_code, calculate_costs): Check for size
578 calculation overflow.
579 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
580 table lengths and related sizes. Don't update size until alloc
581 done. Redo calculations to avoid overflow.
582 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
583
584 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
585 subtracting pointers.
586 (gobble_line): Check for overflow more carefully. Don't update size
587 until alloc done.
588
589 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
590 Don't update size until alloc done.
591 Redo size calculations to avoid overflow.
592 Check for size calculation overflow.
0065d054 593 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
594
595 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
596 Use ptrdiff_t, not int, for sizes.
597 (store_mode_line_noprop_char): Don't update size until alloc done.
598
0065d054
PE
599 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
600 Use ptrdiff_t, not int, for sizes.
601 (Finternal_make_lisp_face, cache_face):
602 Check for size calculation overflow.
603 (cache_face): Treat size calculation overflows as if they were
604 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
605
606 * xfns.c (x_encode_text, x_set_name_internal)
607 (Fx_change_window_property): Use ptrdiff_t, not int, to count
608 sizes, since they can exceed INT_MAX in size. Check for size
609 calculation overflow.
610
0065d054
PE
611 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
612 (xg_select): Check for size calculation overflow.
726e0ab1
PE
613 Don't update size until alloc done.
614
0065d054 615 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 616 as sprintf is limited to int lengths.
1d526e2f 617
252c5ee1
PE
618 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
619 (X_LONG_MIN): New macros.
864d7ce7
PE
620 Use them to make the following changes clearer.
621 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
622 This change doesn't affect the value now, but it may help remind
623 future maintainers not to raise the value too much later.
624 (SELECTION_QUANTUM): Remove, replacing with ...
625 (selection_quantum): ... new function, which avoids overflow.
626 All uses changed.
627 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
628 assumption that selection length fits in 'int'.
629 (x_reply_selection_request, x_handle_selection_request)
630 (x_get_window_property, receive_incremental_selection)
631 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
632 (lisp_data_to_selection_data, clean_local_selection_data):
633 Use ptrdiff_t, not int, to record length of selection.
634 (x_reply_selection_request, x_get_window_property)
635 (receive_incremental_selection, x_property_data_to_lisp):
636 Redo calculations to avoid overflow.
637 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 638 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
639 something.
640 (x_get_window_property, receive_incremental_selection)
641 (lisp_data_to_selection_data, x_property_data_to_lisp):
642 Check for size-calculation overflow.
643 (x_get_window_property, receive_incremental_selection)
644 (lisp_data_to_selection_data, Fx_register_dnd_atom):
645 Don't store size until memory allocation succeeds.
646 (x_get_window_property): Plug memory leak on memory exhaustion.
647 Don't double-block input; malloc is safe here. Don't assume 2**34
648 - 4 fits in unsigned long. Add an xassert to check
649 XGetWindowProperty overflow. Be more careful about overflow
650 calculations, and distinguish size from memory overflow better.
651 (receive_incremental_selection): When tracing, don't assume
652 unsigned int is less than INT_MAX.
653 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
654 harmful) conversions of unsigned short to int.
655 (lisp_data_to_selection_data): Don't assume that integers
656 in the range -65535 through -1 fit in an X unsigned short.
657 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
658 result parameters unless successful. Rely on cons_to_unsigned
659 to report problems with elements; the old code wasn't right anyway.
660 (x_check_property_data): Check for int overflow; we cannot use
661 a wider type due to X limits.
662 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
663
726e0ab1 664 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 665
0065d054
PE
666 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
667 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
668 (x_color_cells): Don't store size until memory allocation succeeds.
669 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 670 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
671 (x_term_init): Don't assume length fits in int (sprintf is limited
672 to int size).
bc18e09d 673
ebfa62c0
PE
674 Use ptrdiff_t for composition IDs.
675 * character.c (lisp_string_width):
676 * composite.c (composition_table_size, n_compositions)
677 (get_composition_id, composition_gstring_from_id):
678 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
679 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
680 * window.c (Frecenter):
681 Use ptrdiff_t, not int, for composition IDs.
682 * composite.c (get_composition_id): Check for integer overflow.
683 * composite.h: Adjust prototypes to match the above changes.
684
d3411f89
PE
685 Use ptrdiff_t for hash table indexes.
686 * category.c (hash_get_category_set):
687 * ccl.c (ccl_driver):
688 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
689 * coding.c (coding_system_charset_list, detect_coding_system):
690 * coding.h (struct coding_system.id):
691 * composite.c (get_composition_id, gstring_lookup_cache):
692 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
693 * image.c (xpm_get_color_table_h):
694 * lisp.h (hash_lookup, hash_put):
695 * minibuf.c (Ftest_completion):
696 Use ptrdiff_t for hash table indexes, not int (which is too
697 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
698 32-bit --with-wide-int hosts).
699
e097a6fa
PE
700 * charset.c (Fdefine_charset_internal): Check for integer overflow.
701 Add a FIXME comment about memory leaks.
702 (syms_of_charset): Don't assume xmalloc returns.
703
5637687f
PE
704 Don't assume that stated character widths fit in int.
705 * character.c (Fchar_width, c_string_width, lisp_string_width):
706 * character.h (CHAR_WIDTH):
707 * indent.c (MULTIBYTE_BYTES_WIDTH):
708 Use sanitize_char_width to avoid undefined and/or bad behavior
709 with outlandish widths.
710 * character.h (sanitize_tab_width): Renamed from sanitize_width,
711 now that we have two such functions. All uses changed.
712 (sanitize_char_width): New inline function.
713
a2271ba2
PE
714 Don't assume that tab-width fits in int.
715 * character.h (sanitize_width): New inline function.
716 (SANE_TAB_WIDTH): New macro.
717 (ASCII_CHAR_WIDTH): Use it.
718 * indent.c (sane_tab_width): Remove. All uses replaced by
719 SANE_TAB_WIDTH (current_buffer).
720 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
721
18c52557
PE
722 * fileio.c: Integer overflow issues with file modes.
723 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
724
caeeedc1
PE
725 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
726 Remove unreachable code.
727 (read_hex, load_charset_map_from_file): Check for integer overflow.
728
50849c52
PE
729 * xterm.c: don't go over XClientMessageEvent limit
730 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
731 (x_send_scroll_bar_event): Likewise. Check that the size does not
732 exceed limits imposed by XClientMessageEvent, as well as the usual
733 ptrdiff_t and size_t limits.
734
b13995db
PE
735 * keyboard.c: Overflow, signedness and related fixes.
736 (make_lispy_movement): Use same integer type in forward decl
737 that is used in the definition.
738 (read_key_sequence, keyremap_step):
739 Change bufsize argument back to int, undoing my 2011-03-30 change.
740 We prefer signed types, and int is wide enough here.
741 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
742 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
743 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
744 length, not size_t. Use ptrdiff_t for index, not int.
745 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
746 possibility of integer overflow.
747
13464394
PE
748 Overflow, signedness and related fixes for images.
749
750 * dispextern.h (struct it.stack[0].u.image.image_id)
751 (struct_it.image_id, struct image.id, struct image_cache.size)
752 (struct image_cache.used, struct image_cache.ref_count):
753 * gtkutil.c (update_frame_tool_bar):
754 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
755 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
756 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
757 * nsmenu.m (update_frame_tool_bar):
758 * xdisp.c (calc_pixel_width_or_height):
759 * xfns.c (image_cache_refcount):
760 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
761 on typical 64-bit hosts.
762
763 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
764 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
765 Omit unnecessary casts to int.
766 (parse_image_spec): Check that integers fall into 'int' range
767 when the callers expect that.
768 (image_ascent): Redo ascent calculation to avoid int overflow.
769 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
770 (lookup_image): Remove unnecessary tests.
771 (xbm_image_p): Locals are now of int, not EMACS_INT,
772 since parse_image_check makes sure they fit into int.
773 (png_load, gif_load, svg_load_image):
774 Prefer int to unsigned where either will do.
775 (tiff_handler): New function, combining the cores of the
776 old tiff_error_handler and tiff_warning_handler. This
777 function is rewritten to use vsnprintf and thereby avoid
778 stack buffer overflows. It uses only the features of vsnprintf
779 that are common to both POSIX and native Microsoft.
780 (tiff_error_handler, tiff_warning_handler): Use it.
781 (tiff_load, gif_load, imagemagick_load_image):
782 Don't assume :index value fits in 'int'.
783 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
784 (imagemagick_load_image): Check that crop parameters fit into
785 the integer types that MagickCropImage accepts. Don't assume
786 Vimagemagick_render_type has a nonnegative value. Don't assume
787 size_t fits in 'long'.
788 (gs_load): Use printmax_t to print the widest integers possible.
789 Check for integer overflow when computing image height and width.
790
c11821d4
EZ
7912011-08-26 Eli Zaretskii <eliz@gnu.org>
792
793 * xdisp.c (redisplay_window): Don't force window start if point
794 will be invisible in the resulting window. (Bug#9324)
795
0c95fcf7
EZ
7962011-08-25 Eli Zaretskii <eliz@gnu.org>
797
798 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
799 the display spec is of the form `(space ...)'.
800 (handle_display_spec): Return the value returned by
801 handle_single_display_spec, not just 1 or zero.
802 (handle_single_display_spec): If the display spec is of the form
803 `(space ...)', and specifies display in the text area, return 2
804 rather than 1.
fee65a97 805 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
806 accurately, and prefer exact match for point under bidi. Don't
807 advance `row' beyond the last row of the window.
0c95fcf7
EZ
808
809 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
810 into disp_prop; all users changed.
811
812 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
813 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
814 for the text covered by the display property.
815
e4ed06f1
CY
8162011-08-25 Chong Yidong <cyd@stupidchicken.com>
817
818 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
819 Change return value to nil.
820 (Frecord_buffer): Delete unused function.
821
f67cdd7f
EZ
8222011-08-24 Eli Zaretskii <eliz@gnu.org>
823
5980d4c6
EZ
824 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
825 buffers, return left-to-right.
8610fe8b
EZ
826 (set_cursor_from_row): Consider candidate row a win if its glyph
827 represents a newline and point is on that newline. Fixes cursor
828 positioning on the newline at EOL of R2L text within L2R
829 paragraph, and vice versa.
830 (try_cursor_movement): Check continued rows, in addition to
831 continuation rows. Fixes unwarranted scroll when point enters a
832 continued line of R2L text within an L2R paragraph, or vice versa.
833 (cursor_row_p): Consider the case of point being equal to
834 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
835 from the end of a short line to the beginning of a continued line
836 of R2L text within L2R paragraph.
837 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
838 composed characters.
5980d4c6 839
f67cdd7f
EZ
840 * bidi.c (bidi_check_type): Use xassert.
841 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
842 members.
843
bca633fb
EZ
8442011-08-23 Eli Zaretskii <eliz@gnu.org>
845
846 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
847 a character.
848
4a5885a7
CY
8492011-08-23 Chong Yidong <cyd@stupidchicken.com>
850
851 * nsfont.m (ns_otf_to_script): Fix typo.
852
0902a04e
KH
8532011-08-22 Kenichi Handa <handa@m17n.org>
854
855 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
856 extra slot even if the purpose is char-code-property-table.
857
1a2e6670
EZ
8582011-08-23 Eli Zaretskii <eliz@gnu.org>
859
8ddde651
EZ
860 * xdisp.c (redisplay_window): When computing centering_position,
861 account for the height of the header line. (Bug#8874)
862
425cc014
EZ
863 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
864 instead of CHAR_TO_BYTE. Fixes a crash when a completion
865 candidate is selected by the mouse, and that candidate has a
866 composed character under the mouse.
867
1a2e6670
EZ
868 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
869 coordinates reported by pos-visible-in-window-p for a composed
870 character in column zero.
871
8b76d6f8
SM
8722011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
873
874 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
875
dac347dd
EZ
8762011-08-22 Eli Zaretskii <eliz@gnu.org>
877
878 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
879 consider it a hit if to_charpos is anywhere in the range of the
880 composed buffer positions.
881
e013fb34
CY
8822011-08-22 Chong Yidong <cyd@stupidchicken.com>
883
884 * image.c (gif_load): Don't assume that each subimage has the same
885 dimensions as the base image. Handle disposal method that is
886 "undefined" by the gif spec (Bug#9335).
887
bd1ba3e8
CY
8882011-08-20 Chong Yidong <cyd@stupidchicken.com>
889
890 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 891 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 892
54a1215b
EZ
8932011-08-19 Eli Zaretskii <eliz@gnu.org>
894
823564e5
EZ
895 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
896 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
897 from an Org mode buffer to a Speedbar frame.
898
54a1215b
EZ
899 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
900 a composition, take its buffer position from IT->cmp_it.charpos.
901 Fixes cursor positioning at the beginning of a line that begins
902 with a composed character.
903
9778ebcc
EZ
9042011-08-18 Eli Zaretskii <eliz@gnu.org>
905
0be6ee06
EZ
906 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
907 character bidirectional type, use STRONG_L instead. Fixes crashes
908 in a buffer produced by `describe-categories'.
909
9778ebcc
EZ
910 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
911 members before the level stack, so they would be saved and
912 restored when copying iterator state. Fixes incorrect reordering
913 around TABs covered by display properties.
914
156bffbe
AS
9152011-08-18 Andreas Schwab <schwab@linux-m68k.org>
916
917 * process.c (Fnetwork_interface_list): Correctly determine buffer
918 size.
919
72ad093b
CY
9202011-08-17 Chong Yidong <cyd@stupidchicken.com>
921
922 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
923 (internal_condition_case_2, internal_condition_case_n):
924 Remove unnecessary aborts (Bug#9081).
72ad093b 925
35774242
EZ
9262011-08-17 Eli Zaretskii <eliz@gnu.org>
927
928 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
929 has no `load' handler, try opening the file locally. (Bug#9311)
930
db76dd85
KB
9312011-08-16 Ken Brown <kbrown@cornell.edu>
932
933 * gmalloc.c: Expand comment.
934
b215eee5
EZ
9352011-08-16 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
938 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
939
a4579d33
KB
9402011-08-16 Ken Brown <kbrown@cornell.edu>
941
942 Fix memory allocation problems in Cygwin build (Bug#9273).
943
944 * unexcw.c ( __malloc_initialized): Declare external variable.
945 (fixup_executable): Force the dumped emacs to reinitialize malloc.
946
8b76d6f8
SM
947 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
948 New variables.
a4579d33
KB
949 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
950 dumped emacs.
951 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
952 in the static heap.
953 [CYGWIN] (special_realloc): New function.
954 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
955 requests to realloc storage in the static heap.
956
3ebec551
PE
9572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
958
959 * bidi.c (bidi_initialize): Remove unused local.
960
9fd8be00
EZ
9612011-08-15 Eli Zaretskii <eliz@gnu.org>
962
474a8465
EZ
963 * biditype.h: File removed.
964
965 * bidimirror.h: File removed.
966
967 * deps.mk (bidi.o): Remove biditype.h and
968 bidimirror.h.
969
970 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
971 bidimirror.h.
972
973 * dispextern.h: Fix a typo in the comment to bidi_type_t.
974
975 * chartab.c: Improve commentary for the uniprop_table API.
976
32413314
EZ
977 * bidi.c (bidi_paragraph_init): Support zero value of
978 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
979 (bidi_initialize): Use uniprop_table instead of including
980 biditype.h and bidimirror.h.
32413314 981
9fd8be00
EZ
982 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
983 coordinates of the iterator when restoring from ppos_it.
984 (Bug#9296)
985
5cf2b69b
KH
9862011-08-14 Kenichi Handa <handa@m17n.org>
987
988 * process.c (create_process): Call setup_process_coding_systems
72ad093b 989 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 990
daf17d00
EZ
9912011-08-14 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (move_it_in_display_line_to): Don't invoke
994 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
995 ppos_it. Fixes vertical cursor motion when line beginning is
996 covered by an image. (Bug#9296)
997
08e3161a
JD
9982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * nsterm.h (ns_run_ascript): Declare.
1001 (NSAPP_DATA2_RUNASSCRIPT): Define.
1002
1003 * nsfns.m (as_script, as_result, as_status): New static variables.
1004 (ns_run_ascript): New function.
5e617bc2 1005 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1006 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1007 the event loop. Get status from as_status (Bug#7276).
1008
1009 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1010 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1011 the event loop (Bug#7276).
1012
a3720aa2
AS
10132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * gnutls.c (QCgnutls_bootprop_priority)
1016 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1017 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1018 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1019 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1020 (QCgnutls_bootprop_verify_hostname_error)
1021 (QCgnutls_bootprop_callbacks_verify): Rename from
1022 Qgnutls_bootprop_..., all uses changed.
1023
1024 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1025 uses changed.
1026
0a0d27fb
PE
10272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1028
19d5c50c
PE
1029 * xfaces.c (Qframe_set_background_mode): Now static.
1030 * dispextern.h (Qframe_set_background_mode): Remove decl.
1031
0a0d27fb
PE
1032 * process.c (Fnetwork_interface_info): Declare local only if needed.
1033
377538cb
JD
10342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1035
1036 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1037 (Fnetwork_interface_list): Allocate in increments of bytes instead
1038 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1039 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1040 sockaddr.
1041 (struct ifflag_def): notrailers is smart on OSX.
1042 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1043 Get hardware address with getifaddrs if available.
1044
08fff70c
EZ
10452011-08-12 Eli Zaretskii <eliz@gnu.org>
1046
1047 * xdisp.c (iterate_out_of_display_property): xassert that
1048 IT->position is set to within IT->object's boundaries. Break from
1049 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1050 when IT->position is set up wrongly due to some bug.
1051 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1052 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1053 entry. Force push_it to save on the stack the current
1054 buffer/string position, to be restored by pop_it. Fix flags in
1055 the iterator structure wrt the object coming from a display
1056 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1057 properties. (Bug#9284)
1058
7be1c708 10592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1060
7be1c708
CY
1061 * fontset.c (fontset_get_font_group): Add proper type checks.
1062 (Bug#9172)
aac0c6e3 1063
7be1c708 10642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1065
7be1c708
CY
1066 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1067 and LC_VERSION_MIN_MACOSX.
1068 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1069 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1070
97bb72a6
EZ
10712011-08-08 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1074 no-display-properties-and-no-overlays under bidi display.
1075 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1076 properties and overlays.
97bb72a6 1077
d5617611
CY
10782011-08-08 Chong Yidong <cyd@stupidchicken.com>
1079
37e11a63
CY
1080 * editfns.c (Fset_time_zone_rule): Document relationship with the
1081 setenv function.
1082
d5617611
CY
1083 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1084 the font entity extracted from the cache (Bug#8109).
1085
58872834
CY
10862011-08-07 Chong Yidong <cyd@stupidchicken.com>
1087
1088 * composite.c (autocmp_chars): Don't reset point. That is done by
1089 restore_point_unwind (Bug#5984).
1090
75bfc667
JL
10912011-08-07 Juri Linkov <juri@jurta.org>
1092
1093 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1094 to show the arg `TIME' instead of `TIMEVAL'.
1095
d1410150
EZ
10962011-08-06 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1099 display property strides EOL and includes a newline, as in
1100 longlines-mode. (Bug#9254)
75b771e4
EZ
1101 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1102 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1103
1104 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1105 is non-zero, even if the data buffer is NULL. Fixes a crash in
1106 vertical-motion with longlines-mode. (Bug#9254)
1107
35928349
EZ
11082011-08-05 Eli Zaretskii <eliz@gnu.org>
1109
ec7cc85b
EZ
1110 * bidi.c <bidi_cache_total_alloc>: Now static.
1111 (bidi_initialize): Initialize bidi_cache_total_alloc.
1112
8b76d6f8 1113 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1114 cache. (Bug#9221)
1115
1116 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1117 amount allocated this far in `bidi_cache_total_alloc'.
1118 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1119 non-zero, only free the data buffer without restoring the cache
1120 contents. All callers changed.
1121
1122 * dispextern.h (bidi_unshelve_cache): Update prototype.
1123
1124 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1125 (move_it_in_display_line, move_it_to)
1126 (move_it_vertically_backward, move_it_by_lines): Replace the call
1127 to xfree to an equivalent call to bidi_unshelve_cache.
1128 (move_it_in_display_line_to): Fix logic of returning
412b6358 1129 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1130
e2e2423b
EZ
11312011-08-05 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1134 came from a string character with a `cursor' property. (Bug#9229)
1135
ae9e757a
JD
11362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1137
1138 * Makefile.in (LIB_PTHREAD): New variable.
1139 (LIBES): Add LIB_PTHREAD (Bug#9216).
1140
1141 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1142 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1143
213bd7f2
AS
11442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1145
1146 * regex.c (re_iswctype): Remove some redundant boolean
1147 conversions.
1148
99aaf75f
JD
11492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1150
1151 * xterm.c (x_find_topmost_parent): New function.
1152 (x_set_frame_alpha): Find topmost parent window with
1153 x_find_topmost_parent and set the property there also (bug#9181).
1154 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1155
c74e9d86
PE
11562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 * callproc.c (Fcall_process): Avoid vfork clobbering
1159 the local vars buffer, coding_systems, current_dir.
1160
640c8776
SM
11612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1162
1163 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1164
f26d0e4c
PE
11652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1166
8a10d76c
PE
1167 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1168 so that it is not optimized away.
1169
f26d0e4c
PE
1170 * xdisp.c (compute_display_string_pos): Remove unused local.
1171
55439c61
EZ
11722011-08-02 Eli Zaretskii <eliz@gnu.org>
1173
1174 Fix slow cursor motion and scrolling in large buffers with
1175 selective display, like Org Mode buffers. (Bug#9218)
1176
1177 * dispextern.h (struct bidi_it): New member disp_prop_p.
1178
1179 * xdisp.c: Remove one-slot cache of display string positions.
1180 (compute_display_string_pos): Accept an additional argument
5e617bc2 1181 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1182 for a display string or property. If found, set DISP_PROP_P
1183 non-zero.
1184
1185 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1186 DISP_PROP_P, and pass it to compute_display_string_pos.
1187 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1188 non-zero. All callers of bidi_fetch_char changed.
1189
fb33fa43
SM
11902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1191
1192 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1193
b099e063
DM
11942010-12-03 Don March <don@ohspite.net>
1195
1196 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1197 last character M-[char] is translated to ESC [char] (bug#7541).
1198
5cc7f7af
KH
11992011-08-02 Kenichi Handa <handa@m17n.org>
1200
d0fffa3f 1201 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1202
1203 * chartab.c (uniprop_table): Make it non-static.
1204
525d5e6e
EZ
12052011-08-01 Eli Zaretskii <eliz@gnu.org>
1206
1207 * xdisp.c (forward_to_next_line_start): Accept additional argument
1208 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1209 on the newline.
1210 (reseat_at_next_visible_line_start): Use the bidi iterator state
1211 returned by forward_to_next_line_start to restore the state of
1212 it->bidi_it after backing up to previous newline. (Bug#9212)
1213
31011111
AS
12142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1215
1216 * regex.c (re_comp): Protoize.
1217 (re_exec): Fix return type.
1218 (regexec): Fix type of `ret'. (Bug#9203)
1219
476371c4
PE
12202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1221
e5d76069
PE
1222 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1223 This is needed if max-image-size is a floating-point number.
1224
9a79b20c
AS
12252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1226
1227 * print.c (print_object): Print empty symbol as ##.
1228
1229 * lread.c (read1): Read ## as empty symbol.
1230
d8c2fa78
AA
12312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1232
1233 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1234 setting frame foreground color (Bug#9175).
1235 (x_set_background_color): Likewise.
1236
ffe57a7a
AA
1237 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1238 contents (Bug#9176).
1239 (EmacsTooltip -init): Remove bezels and add shadows to
1240 tooltip windows.
1241
bf3492a5
AA
1242 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1243 or scroll bar (Bug#8470).
1244
d55e9c53
AA
1245 * nsfont.m (nsfont_open): Remove assignment to voffset and
1246 unnecessary vars hshink, expand, hd, full_height, min_height.
1247 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1248
1249 * nsterm.h (nsfont_info): Remove voffset field.
1250
d8c2fa78 12512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1252
1253 Implement strike-through and overline on NextStep (Bug#8863).
1254
1255 * nsfont.m (nsfont_open): Use underline position provided by font,
1256 instead of hard-coded value of 2.
1257 (nsfont_draw): Call ns_draw_text_decoration instead.
1258
1259 * nsterm.h: Add declaration for ns_draw_text_decoration.
1260
1261 * nsterm.m (ns_draw_text_decoration): New function for drawing
1262 underline, overline, and strike-through.
1263 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1264 ns_draw_text_decoration. Change treatment of cursor drawing to
1265 accomodate underlining, etc.
1266
4cc60b9b
EZ
12672011-07-28 Eli Zaretskii <eliz@gnu.org>
1268
bc7ece87
EZ
1269 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1270 default.
4cc60b9b 1271
476371c4
PE
12722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1273
66606eea
PE
1274 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1275 Without this fix, if a signal arrives just after memory fills up,
1276 'malloc' might be invoked reentrantly.
1277
476371c4
PE
1278 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1279 In other words, assume that every image size is allowed, on non-X
1280 hosts. This assumption is probably wrong, but it lets Emacs compile.
1281
f3fcc40d
AS
12822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1283
1284 * regex.c (re_iswctype): Convert return values to boolean.
1285
350c992f
EZ
12862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1287
1288 * xdisp.c (compute_display_string_pos): Don't use cached display
1289 string position if the buffer had its restriction changed.
1290 (Bug#9184)
1291
5266b4bb
PE
12922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1295
2573a837 12962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1297
41f55ccd 1298 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1299
39e378da
PE
1300 * bidi.c: Integer size and overflow fixes.
1301 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1302 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1303 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1304 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1305 (bidi_find_other_level_edge):
1306 Use ptrdiff_t instead of EMACS_INT where either will do.
1307 This works better on 32-bit hosts configured --with-wide-int.
1308 (bidi_cache_ensure_space): Check for size-calculation overflow.
1309 Use % rather than repeated addition, for better worst-case speed.
1310 Don't set bidi_cache_size until after xrealloc returns, because it
1311 might not return.
1312 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1313 (bidi_cache_ensure_space): Also check that the bidi cache size
1314 does not exceed that of the largest Lisp string or buffer. See Eli
1315 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1316
5e927815
PE
1317 * alloc.c (__malloc_size_t): Remove.
1318 All uses replaced by size_t. See Andreas Schwab's note
1319 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1320
ca4aa935
PE
1321 * image.c: Improve checking for integer overflow.
1322 (check_image_size): Assume that f is nonnull, since
1323 it is always nonnull in practice. This is one less thing to
1324 worry about when checking for integer overflow later.
1325 (x_check_image_size): New function, which checks for integer
1326 overflow issues inside X.
1327 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1328 This removes the need for a memory_full check.
1329 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1330 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1331 (xbm_read_bitmap_data): Change locals back to 'int', since
1332 their values must fit in 'int'.
1333 (xpm_load_image, png_load, tiff_load):
1334 Invoke x_create_x_image_and_pixmap earlier,
1335 to avoid much needless work if the image is too large.
1336 (tiff_load): Treat overly large images as if
1337 x_create_x_image_and_pixmap failed, not as malloc failures.
1338 (gs_load): Use x_check_image_size.
1339
5f8f9cc2
PE
1340 * gtkutil.c: Omit integer casts.
1341 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1342 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1343
5adf60bc
PE
1344 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1345
c8907a93
PE
1346 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1347 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1348 would wrongly return t on a 64-bit host.
1349
e3c25c68
PE
1350 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1351 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1352 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1353 and therefore cause GCC to emit a bogus diagnostic in some cases.
1354
3f791afe
PE
1355 * image.c: Integer signedness and overflow and related fixes.
1356 This is not an exhaustive set of fixes, but it's time to
1357 record what I've got.
1358 (lookup_pixel_color, check_image_size): Remove redundant decls.
1359 (check_image_size): Don't assume that arbitrary EMACS_INT values
1360 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1361 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1362 (tiff_load, imagemagick_load_image):
1363 Check for overflow in size calculations.
1364 (x_create_x_image_and_pixmap): Remove unnecessary test for
1365 xmalloc returning NULL; that can't happen.
1366 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1367 (xpm_color_bucket): Use better integer hashing function.
1368 (xpm_cache_color): Don't possibly over-allocate memory.
1369 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1370 (gif_memory_source):
1371 Use ptrdiff_t, not int or size_t, to record sizes.
1372 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1373 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1374 either works, as we prefer signed integers.
1375 (tiff_read_from_memory, tiff_write_from_memory):
1376 Return tsize_t, not size_t, since that's what the TIFF API wants.
1377 (tiff_read_from_memory): Don't fail simply because the read would
1378 go past EOF; instead, return a short read.
1379 (tiff_load): Omit no-longer-needed casts.
1380 (Fimagemagick_types): Don't assume size fits into 'int'.
1381
3cc5a532
PE
1382 Improve hashing quality when configured --with-wide-int.
1383 * fns.c (hash_string): New function, taken from sxhash_string.
1384 Do not discard information about ASCII character case; this
1385 discarding is no longer needed.
1386 (sxhash-string): Use it. Change sig to match it. Caller changed.
1387 * lisp.h: Declare it.
1388 * lread.c (hash_string): Remove, since we now use fns.c's version.
1389 The fns.c version returns a wider integer if --with-wide-int is
1390 specified, so this should help the quality of the hashing a bit.
1391
b312a492
PE
1392 * emacs.c: Integer overflow minor fix.
1393 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1394 Define only if GNU_LINUX.
1395 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1396
dfd153ae
PE
1397 * dispnew.c: Integer signedness and overflow fixes.
1398 Remove unnecessary forward decls, that were a maintenance hassle.
1399 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1400 All uses changed.
1401 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1402 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1403 (prepare_desired_row, line_draw_cost):
1404 Use int, not unsigned, where either works.
1405 (save_current_matrix, restore_current_matrix):
1406 Use ptrdiff_t, not size_t, where either works.
1407 (init_display): Check for overflow more accurately, and without
1408 relying on undefined behavior.
1409
a81d11a3
PE
1410 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1411 Remove, replacing with the new symbols in lisp.h. All uses changed.
1412 * fileio.c (make_temp_name):
1413 * filelock.c (lock_file_1, lock_file):
1414 * xdisp.c (message_dolog):
1415 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1416 Use pMd etc. instead.
1417 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1418 replacing the pWIDE etc. symbols removed from editfns.c.
1419
3300e6fd
PE
1420 * keyboard.h (num_input_events): Now uintmax_t.
1421 This is (very slightly) less likely to mess up due to wraparound.
1422 All uses changed.
1423
fd05c7e9
PE
1424 * buffer.c: Integer signedness fixes.
1425 (alloc_buffer_text, enlarge_buffer_text):
1426 Use ptrdiff_t rather than size_t when either will do, as we prefer
1427 signed integers.
1428
903fe15d
PE
1429 * alloc.c: Integer signedness and overflow fixes.
1430 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1431 (__malloc_size_t): Default to size_t, not to int.
1432 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1433 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1434 Prefer ptrdiff_t to size_t when either would do, as we prefer
1435 signed integers.
1436 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1437 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1438 Now const. Initialize with values that are in range even if char
1439 is signed.
1440 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1441 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1442 These functions do the right thing with sizes > 2**32.
1443 (check_depth): Now ptrdiff_t, not int.
1444 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1445 Adjust to new way of storing sizes. Check for size overflow bugs
1446 in rest of code.
1447 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1448 slightly wrong anyway, as it missed one instance of
1449 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1450 (refill_memory_reserve): Omit needless cast to size_t.
1451 (mark_object_loop_halt): Mark as externally visible.
1452
ac82cc6a
PE
1453 * xselect.c: Integer signedness and overflow fixes.
1454 (Fx_register_dnd_atom, x_handle_dnd_message):
1455 Use ptrdiff_t, not size_t, since we prefer signed.
1456 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1457 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1458 x_dnd_atoms_size and x_dnd_atoms_length.
1459
c2d1e36d
PE
1460 * doprnt.c: Prefer signed to unsigned when either works.
1461 * eval.c (verror):
1462 * doprnt.c (doprnt):
1463 * lisp.h (doprnt):
1464 * xdisp.c (vmessage):
1465 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1466 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1467 prefer signed arithmetic to avoid comparison confusion.
1468 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1469 but is a bit tricky.
1470
0e926e56
PE
1471 Assume freestanding C89 headers, string.h, stdlib.h.
1472 * data.c, doprnt.c, floatfns.c, print.c:
1473 Include float.h unconditionally.
1474 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1475 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1476 * regex.c: Likewise for stddef.h, string.h.
1477 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1478 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1479 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1480 (STDC_HEADERS): Remove obsolete defines.
1481 * sysdep.c: Include limits.h unconditionally.
1482
9cfdb3ec
PE
1483 Assume support for memcmp, memcpy, memmove, memset.
1484 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1485 * regex.c (memcmp, memcpy):
1486 Remove; we assume C89 now.
1487
1488 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1489 (__malloc_safe_bcopy): Remove; no longer needed.
1490
cf950e6b 1491 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1492 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1493 well either way, and we prefer signed to unsigned.
1494
dbf38e02
LMI
14952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1496
1497 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1498 closes the connection while we're reading (bug#9182).
1499
d6f0886c 15002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1501
d6f0886c
JD
1502 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1503 are specified (Bug#9168).
24e0f6b1 1504
2eb1f9e6
PE
15052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1506
1507 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1508 Found by GCC static checking and --with-wide-int on a 32-bit host.
1509
22381272 15102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1511
1512 * xdisp.c (compute_display_string_pos): Fix logic of caching
1513 previous display string position. Initialize cached_prev_pos to
1514 -1. Fixes slow-down at the beginning of a buffer.
1515
f25e39b4
EZ
15162011-07-24 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1519 for attrs[LFACE_FONTSET_INDEX].
1520
04c4b52e
PE
15212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * xml.c (parse_region): Remove unused local
1524 that was recently introduced.
1525
c1734fbd
EZ
15262011-07-23 Eli Zaretskii <eliz@gnu.org>
1527
be18c5a5
EZ
1528 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1529 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1530
c1734fbd
EZ
1531 * xdisp.c (move_it_in_display_line_to): Record the best matching
1532 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1533 exit if none of the characters scanned was an exact match.
1534 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1535 when exact match is impossible due to invisible text, and the
1536 lines are truncated.
1537
a258d627
JD
15382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1539
1540 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1541 for OSX >= 10.7.
1542
b6d5a689
EZ
15432011-07-22 Eli Zaretskii <eliz@gnu.org>
1544
0f74f785
EZ
1545 Fix a significant slow-down of cursor motion with C-n, C-p,
1546 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1547 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1548 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1549 (next_element_from_buffer): Call compute_stop_pos_backwards to
1550 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1551 base_level_stop.
1552 (reseat): Don't look for prev_stop, as that could mean a very long
1553 run.
1554 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1555 <cached_disp_overlay_modiff>: Cache for last found display string
1556 position.
551918c1 1557 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1558 about the same buffer in the same area of character positions, and
1559 the buffer wasn't changed since the time the display string
1560 position was cached.
551918c1 1561
b2d0c91a
EZ
15622011-07-22 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1565 is an integer, which is important for empty lines. (Bug#9149)
1566
043604ee
CY
15672011-07-22 Chong Yidong <cyd@stupidchicken.com>
1568
1569 * frame.c (Fmodify_frame_parameters): In tty case, update the
1570 default face if necessary (Bug#4238).
1571
da4adb04
CY
15722011-07-21 Chong Yidong <cyd@stupidchicken.com>
1573
1574 * editfns.c (Fstring_to_char): No need to explain what a character
1575 is in the docstring (Bug#6576).
1576
9abd0532
LMI
15772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1578
1579 * xml.c (parse_region): Make sure we always return a tree.
1580
36881d16
HK
15812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1582
1583 * xml.c (parse_region): If a document contains only comments,
1584 return that, too.
1585
1e98674d
LMI
15862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1587
1588 * xml.c (make_dom): Return comments, too.
1589
590bd467
PE
15902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1591
1592 Port to OpenBSD.
1593 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1594 and the surrounding thread.
1595 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1596 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1597 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1598 timer goes off.
1599 * s/openbsd.h (BROKEN_SIGIO): Define.
1600 * unexelf.c (unexec) [__OpenBSD__]:
1601 Don't update the .mdebug section of the Alpha COFF symbol table.
1602
f41628b2
LMI
16032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1604
1605 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1606 (bug#8460).
1607
b59b67c5
PE
16082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1609
15e3a074
PE
1610 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1611 This fixes some race conditions on the permissions of any newly
1612 created file.
1613
41bed37d
PE
1614 * alloc.c (valid_pointer_p): Use pipe, not open.
1615 This fixes some permissions issues when debugging.
1616
b59b67c5
PE
1617 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1618 If fchown fails to set both uid and gid, try to set just gid,
1619 as that is sometimes allowed. Adjust the file's mode to eliminate
1620 setuid or setgid bits that are inappropriate if fchown fails.
1621
925a6be7
SM
16222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1625 to compare Lisp_Objects.
1626 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1627 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1628 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1629
52968808
AS
16302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1631
0a6a104b
AS
1632 * lread.c (read_integer): Unread even EOF character.
1633 (read1): Likewise. Properly record start position of symbol.
1634
52968808
AS
1635 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1636 symbol character follows.
1637
9e381cdd
PE
16382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1639
1640 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1641 This works around a problem with the previous change to Fcopy_file.
1642 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1643 and without this change, GCC might complain about discarding
1644 fchown's return value.
1645
b5641435
JB
16462011-07-16 Juanma Barranquero <lekktu@gmail.com>
1647
1648 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1649
a8031457
PE
16502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1653
dd889327
LMI
16542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1655
750c33f7
LMI
1656 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1657 it's used from the C level.
1658
dd889327
LMI
1659 * process.c: Use the same condition for POLL_FOR_INPUT in both
1660 keyboard.c and process.c (bug#1858).
1661
87e86684
LM
16622011-07-09 Lawrence Mitchell <wence@gmx.li>
1663
1664 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1665 (Fgnutls_boot): Use it.
1666
64348f40
AS
16672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1668
1669 * doc.c (Fsubstitute_command_keys): Revert last change.
1670
1d698799
LMI
16712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1672
f863868c
LMI
1673 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1674 quotes the next character, and doesn't affect other longer
1675 sequences (bug#8935).
1676
1d698799
LMI
1677 * lread.c (syms_of_lread): Clarify that is isn't only
1678 `eval-buffer' and `eval-defun' that's affected by
1679 `lexical-binding' (bug#8460).
1680
aa4b6df6
EZ
16812011-07-15 Eli Zaretskii <eliz@gnu.org>
1682
1683 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1684 bidi redisplay when a line includes both an image and is
1685 truncated.
1686
5d856da6
PE
16872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1688
ad6042bb
PE
1689 Fix minor problems found by static checking.
1690 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1691 (elsz): Now a signed constant, not a size_t var. We prefer signed
1692 types to unsigned, to avoid integer comparison confusion. Without
1693 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1694 "cannot optimize loop, the loop counter may overflow", a symptom
1695 of the confusion.
f00bbb22 1696 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1697 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1698
6468f31c
LMI
16992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1700
49080b10
LMI
1701 * search.c (Fre_search_backward): Mention `case-fold-search' in
1702 all the re_search_* functions (bug#8138).
1703
6468f31c
LMI
1704 * keyboard.c (Fopen_dribble_file): Document when the file is
1705 closed (bug#8056).
1706
c965adc5
EZ
17072011-07-14 Eli Zaretskii <eliz@gnu.org>
1708
df9733bf
EZ
1709 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1710 bidi_cache_idx.
1711
0bb23927
EZ
1712 Support bidi reordering of display and overlay strings.
1713 * xdisp.c (compute_display_string_pos)
1714 (compute_display_string_end): Accept additional argument STRING.
1715 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1716 (reseat_to_string): Initialize bidi_it->string.s and
1717 bidi_it->string.schars.
1718 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1719 NULL (avoids a crash in bidi_paragraph_init).
1720 Initialize itb.string.lstring.
0bb23927
EZ
1721 (init_iterator): Call bidi_init_it only of a valid
1722 buffer position was specified. Initialize paragraph_embedding to
1723 L2R.
1724 (reseat_to_string): Initialize the bidi iterator.
1725 (display_string): If we need to ignore text properties of
1726 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1727 original value of -1 will not work with bidi.)
1728 (compute_display_string_pos): First arg is now struct
1729 `text_pos *'; all callers changed. Support display properties on
1730 Lisp strings.
1731 (compute_display_string_end): Support display properties on Lisp
1732 strings.
1733 (init_iterator, reseat_1, reseat_to_string): Initialize the
1734 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1735 when iterating on a string not from display properties).
640c8776
SM
1736 (compute_display_string_pos, compute_display_string_end):
1737 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1738 arrow keys.
1739 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1740 base_level_stop; instead, set base_level_stop to BEGV.
1741 Fixes crashes in vertical-motion.
0bb23927
EZ
1742 (next_element_from_buffer): Improve commentary for when
1743 the iterator is before prev_stop.
1744 (init_iterator): Initialize bidi_p from the default value of
1745 bidi-display-reordering, not from buffer-local value. Use the
1746 buffer-local value only if initializing for buffer iteration.
1747 (handle_invisible_prop): Support invisible properties on strings
1748 that are being bidi-reordered.
1749 (set_iterator_to_next): Support bidi reordering of C strings and
1750 Lisp strings.
1751 (next_element_from_string): Support bidi reordering of Lisp
1752 strings.
1753 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1754 (display_string): Support display of R2L glyph rows.
1755 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1756 (init_iterator): Don't initialize it->bidi_p for strings
1757 here.
1758 (reseat_to_string): Initialize it->bidi_p for strings here.
1759 (next_element_from_string, next_element_from_c_string)
1760 (next_element_from_buffer): Add xassert's for correspondence
1761 between IT's object being iterated and it->bidi_it.string
1762 structure.
1763 (face_before_or_after_it_pos): Support bidi iteration.
1764 (next_element_from_c_string): Handle the case of the first string
1765 character that is not the first one in the visual order.
1766 (get_visually_first_element): New function, refactored from common
1767 parts of next_element_from_buffer, next_element_from_string, and
1768 next_element_from_c_string.
1769 (tool_bar_lines_needed, redisplay_tool_bar)
1770 (display_menu_bar): Force left-to-right direction. Add a FIXME
1771 comment for making that be controlled by a user option.
1772 (push_it, pop_it): Save and restore the state of the
1773 bidi iterator. Save and restore the bidi_p flag.
1774 (pop_it): Iterate out of display property for string iteration as
1775 well.
1776 (iterate_out_of_display_property): Support iteration over strings.
1777 (handle_single_display_spec): Set up it->bidi_it for iteration
1778 over a display string, and call bidi_init_it.
1779 (handle_single_display_spec, next_overlay_string)
1780 (get_overlay_strings_1, push_display_prop): Set up the bidi
1781 iterator for displaying display or overlay strings.
1782 (forward_to_next_line_start): Don't use the shortcut if
1783 bidi-iterating.
1784 (back_to_previous_visible_line_start): If handle_display_prop
1785 pushed the iterator stack, restore the internal state of the bidi
1786 iterator by calling bidi_pop_it same number of times.
1787 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1788 and we are bidi-iterating, don't decrement the iterator position;
1789 instead, set the first_elt flag in the bidi iterator, to produce
1790 the same effect.
1791 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1792 (push_display_prop): xassert that we are iterating a buffer.
1793 (push_it, pop_it): Save and restore paragraph_embedding member.
1794 (handle_single_display_spec, next_overlay_string)
1795 (get_overlay_strings_1, reseat_1, reseat_to_string)
1796 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1797 correctly. Don't assume unibyte strings are not bidi-reordered.
1798 (compute_display_string_pos)
1799 (compute_display_string_end): Fix handling the case of C string.
1800 (push_it, pop_it): Save and restore from_disp_prop_p.
1801 (handle_single_display_spec, push_display_prop): Set the
1802 from_disp_prop_p flag.
1803 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1804 (pop_it): Call iterate_out_of_display_property only if we are
1805 popping after iteration over a string that came from a display
1806 property. Fix a typo in popping stretch info. Add an assertion
1807 for verifying that the iterator position is in sync with the bidi
1808 iterator.
1809 (handle_single_display_spec, get_overlay_strings_1)
1810 (push_display_prop): Fix initialization of paragraph direction for
1811 string when that of the parent object is not yet determined.
1812 (reseat_1): Call bidi_init_it to resync the bidi
1813 iterator with IT's position. (Bug#7616)
1814 (find_row_edges): If ROW->start.pos gives position
1815 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1816 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1817 Reset the from_disp_prop_p flag.
1818 (SAVE_IT, RESTORE_IT): New macros.
1819 (pos_visible_p, face_before_or_after_it_pos)
1820 (back_to_previous_visible_line_start)
1821 (move_it_in_display_line_to, move_it_in_display_line)
1822 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1823 (try_scrolling, redisplay_window, display_line): Use them when
1824 saving a temporary copy of the iterator and restoring it back.
1825 (back_to_previous_visible_line_start, reseat_1)
1826 (init_iterator): Empty the bidi cache "stack".
1827 (move_it_in_display_line_to): If iterator ended up at
1828 EOL, but we never saw any buffer positions smaller than
1829 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1830 motion in bidi-reordered lines.
1831 (move_it_in_display_line_to): Record prev_method and prev_pos
1832 immediately before the call to set_iterator_to_next. Fixes cursor
1833 motion in bidi-reordered lines with stretch glyphs and strings
1834 displayed in margins. (Bug#8133) (Bug#8867)
1835 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1836 TO_CHARPOS.
640c8776
SM
1837 (pos_visible_p): Support positions in bidi-reordered lines.
1838 Save and restore bidi cache.
0bb23927
EZ
1839
1840 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1841 (bidi_paragraph_info): Delete unused struct.
1842 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1843 (bidi_cache_start): New variable.
1844 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1845 to zero.
1846 (bidi_cache_fetch_state, bidi_cache_search)
1847 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1848 (bidi_cache_find, bidi_peek_at_next_level)
1849 (bidi_level_of_next_char, bidi_find_other_level_edge)
1850 (bidi_move_to_visually_next): Compare cache index with
1851 bidi_cache_start rather than with zero.
1852 (bidi_fetch_char): Accept new argument STRING; all callers
1853 changed. Support iteration over a string. Support strings with
1854 display properties. Support unibyte strings. Fix the type of
1855 `len' according to what STRING_CHAR_AND_LENGTH expects.
1856 (bidi_paragraph_init, bidi_resolve_explicit_1)
1857 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1858 (bidi_level_of_next_char, bidi_move_to_visually_next):
1859 Support iteration over a string.
0bb23927
EZ
1860 (bidi_set_sor_type, bidi_resolve_explicit_1)
1861 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1862 can now be zero (for strings); special values 0 and -1 were
1863 changed to -1 and -2, respectively.
1864 (bidi_char_at_pos): New function.
1865 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1866 Call it instead of FETCH_MULTIBYTE_CHAR.
1867 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1868 initialized to valid values.
1869 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1870 values.
1871 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1872 the test for valid cached positions. Fix the logic for looking up
1873 the sentinel state in the cache. GCPRO the Lisp string we are
1874 iterating.
1875 (bidi_push_it, bidi_pop_it): New functions.
1876 (bidi_initialize): Initialize the bidi cache start stack pointer.
1877 (bidi_cache_ensure_space): New function, refactored from part of
1878 bidi_cache_iterator_state. Don't assume the required size is just
1879 one BIDI_CACHE_CHUNK away.
1880 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1881 (bidi_count_bytes, bidi_char_at_pos): New functions.
1882 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1883 always valid if bidi_cache_idx is valid.
1884 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1885 is valid if it's going to be used.
1886 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1887 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1888 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1889 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1890 (bidi_find_other_level_edge, bidi_cache_start_stack):
1891 All variables related to cache indices are now EMACS_INT.
c965adc5 1892
0bb23927
EZ
1893 * dispextern.h (struct bidi_string_data): New structure.
1894 (struct bidi_it): New member `string'. Make flag members be 1-bit
1895 fields, and put them last in the struct.
640c8776
SM
1896 (compute_display_string_pos, compute_display_string_end):
1897 Update prototypes.
0bb23927
EZ
1898 (bidi_push_it, bidi_pop_it): Add prototypes.
1899 (struct iterator_stack_entry): New members bidi_p,
1900 paragraph_embedding, and from_disp_prop_p.
1901 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1902 (bidi_shelve_cache, bidi_unshelve_cache):
1903 Declare prototypes.
0bb23927
EZ
1904
1905 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1906 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1907 and vector-like objects.
1908
1909 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1910 cache around display iteration.
1911
1912 * window.c (Fwindow_end, window_scroll_pixel_based)
1913 (displayed_window_lines, Frecenter): Save and restore the bidi
1914 cache around display iteration.
1915
3bbd2265
LMI
19162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1917
1918 * editfns.c (Fdelete_region): Clarify the use of the named
1919 parameters (bug#6788).
1920
adc47434
MR
19212011-07-14 Martin Rudalics <rudalics@gmx.at>
1922
1923 * indent.c (Fvertical_motion): Set and restore w->pointm when
1924 saving and restoring the window's buffer (Bug#9006).
1925
837c31f8
LMI
19262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1927
1928 * editfns.c (Fstring_to_char): Clarify just what is returned
1929 (bug#6576). Text by Eli Zaretskii.
1930
ac389d0c
JB
19312011-07-13 Juanma Barranquero <lekktu@gmail.com>
1932
1933 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1934
0be0ce47
EZ
19352011-07-13 Eli Zaretskii <eliz@gnu.org>
1936
1937 * buffer.c (mmap_find): Fix a typo.
1938
cd18e7e3
JB
19392011-07-13 Johan Bockgård <bojohan@gnu.org>
1940
1941 Fix execution of x selection hooks.
1942 * xselect.c (Qx_lost_selection_functions)
1943 (Qx_sent_selection_functions): New vars.
1944 (syms_of_xselect): DEFSYM them.
1945 (x_handle_selection_request): Pass Qx_sent_selection_functions
1946 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1947 (x_handle_selection_clear,x_clear_frame_selections):
1948 Pass Qx_lost_selection_functions rather than
1949 Vx_lost_selection_functions to Frun_hook_with_args.
1950
47ea7f44
PE
19512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1952
ac389d0c 1953 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1954 The old code sometimes used this field without initializing it.
1955
47ea7f44
PE
1956 * alloc.c (gc_sweep): Don't read past end of array.
1957 In theory, the old code could also have corrupted Emacs internals,
1958 though it'd be very unlikely.
1959
bc985c87
AS
19602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1961
1962 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1963 argument. (Bug#4026)
bc985c87 1964
0cf34688
LMI
19652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1966
b3dadd76
LMI
1967 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1968 key" (bug#4257).
1969
0cf34688
LMI
1970 * window.c (Fset_window_start): Doc fix (bug#4199).
1971 (Fset_window_hscroll): Ditto.
1972
270768cd
PE
19732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1974
077e3dda 1975 Fix minor new problems caught by GCC 4.6.1.
270768cd 1976 * term.c (init_tty): Remove unused local.
490011a6 1977 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1978 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1979 not used otherwise.
270768cd 1980
b1f58454
CY
19812011-07-12 Chong Yidong <cyd@stupidchicken.com>
1982
1983 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1984
22b9578d
LMI
19852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1986
6e70ab07
LMI
1987 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1988 are the mini-buffer and the echo area (bug#3320).
1989
22b9578d
LMI
1990 * term.c (init_tty): Remove support for supdup, c10 and perq
1991 terminals, which are no longer supported (bug#1482).
1992
8974cc9f
JB
19932011-07-10 Johan Bockgård <bojohan@gnu.org>
1994
1995 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1996
a560d974
JD
19972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1998
1999 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2000 for non-popups (Bug#3642).
2001
1dae0f0a
AS
20022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2003
268c2c36 2004 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2005 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2006 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2007 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2008 * data.c (fmod): Likewise.
2009 * dispnew.c (swap_glyphs_in_rows): Likewise.
2010 * emacs.c (memory_warning_signal): Likewise.
2011 * floatfns.c (float_error): Likewise.
2012 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2013 (otf_open, font_otf_capability, generate_otf_features)
2014 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2015 Likewise.
2016 * image.c (pbm_read_file): Likewise.
2017 * indent.c (string_display_width): Likewise.
2018 * intervals.c (check_for_interval, search_for_interval)
2019 (inc_interval_count, count_intervals, root_interval)
2020 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2021 * lread.c (defalias): Likewise.
268c2c36 2022 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2023 * regex.c (set_image_of_range_1, set_image_of_range)
2024 (regex_grow_registers): Likewise.
2025 * sysdep.c (strerror): Likewise.
2026 * termcap.c (valid_filename_p, tprint, main): Likewise.
2027 * tparam.c (main): Likewise.
2028 * unexhp9k800.c (run_time_remap, save_data_space)
2029 (update_file_ptrs, read_header, write_header, calculate_checksum)
2030 (copy_file, copy_rest, display_header): Likewise.
2031 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2032 Likewise.
2033 * xdisp.c (check_it): Likewise.
2034 * xfaces.c (register_color, unregister_color, unregister_colors):
2035 Likewise.
2036 * xfns.c (print_fontset_result): Likewise.
2037 * xrdb.c (member, fatal, main): Likewise.
2038
99033785
PE
20392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2040
2041 Fix minor problems found by static checking (Bug#9031).
2042 * chartab.c (char_table_set_range, map_sub_char_table):
2043 Remove unused locals.
2044 (uniprop_table): Now static.
2045 * composite.c (_work_char): Remove unused static var.
2046
9cb2ac56
JB
20472011-07-09 Juanma Barranquero <lekktu@gmail.com>
2048
2049 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2050
f25661f0
JD
20512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2052
2053 * gtkutil.c (qttip_cb): Remove code without function.
2054
8278c4fe
EZ
20552011-07-09 Eli Zaretskii <eliz@gnu.org>
2056
2057 * w32.c (pthread_sigmask): New stub.
2058
1692ae2d 20592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2060
8a6ebd58 2061 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2062 sigprocmask is portable only for single-threaded applications, and
2063 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2064 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2065 (LIBES): Use it.
2066 * callproc.c (Fcall_process):
2067 * process.c (create_process):
2068 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2069 Use pthread_sigmask, not sigprocmask.
123403e4 2070
1b854618
JD
20712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2072
2073 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2074 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2075 wrong (Bug#8591).
2076
3fe4b549
JD
20772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2078
0ce7e563
JD
2079 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2080 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2081 (xg_hide_tooltip): Fix comment.
2082
3fe4b549
JD
2083 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2084 in registerServicesMenuSendTypes.
2085 (validRequestorForSendType): Don't check ns_return_types.
2086
2087 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2088 ns_return_type.
2089
5df75e47
JR
20902011-07-08 Jason Rumney <jasonr@gnu.org>
2091
2092 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2093 frame struct members of non-existent frames (Bug#6284).
2094
699c10bd
JD
20952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2096
4393663b
JD
2097 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2098 variable firstTime not needed on OSX >= 10.6.
2099 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2100 >= 10.5. Use setKnobProportion, setDoubleValue.
2101
2102 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2103 (MAC_OS_X_VERSION_10_5): Define if not defined.
2104 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2105 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2106 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2107
2108 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2109 cString and lossyCString on OSX >= 10.4
2110
2111 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2112 sizeToFit on OSX >= 10.2.
2113
2114 * nsimage.m (allocInitFromFile): Don't use deprecated method
2115 bestRepresentationForDevice on OSX >= 10.6.
2116
2117 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2118 to avoid warning.
2119
2120 * emacs.c: Declare unexec_init_emacs_zone.
2121
a63e0781
JD
2122 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2123
699c10bd
JD
2124 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2125
2126 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2127 on svcsMenu (Bug#8842).
2128
2129 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2130 ns_return_types.
2131 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2132
2133 * nsterm.m (QUTF8_STRING): Declare.
2134 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2135 (validRequestorForSendType): Return type is (id).
2136 Change indexOfObjectIdenticalTo to indexOfObject.
2137 Check if we have local selection before returning self (Bug#8842).
2138 (writeSelectionToPasteboard): Put local selection into paste board
2139 if we have a local selection (Bug#8842).
2140 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2141
2142 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2143 (ns_get_local_selection): Declare.
2144
54e10184
LMI
21452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2146
9888ff71
LMI
2147 * keymap.c (describe_map_tree): Don't insert a double newline at
2148 the end of the buffer (bug#1169) and return whether we inserted
2149 something.
2150
54e10184
LMI
2151 * callint.c (Fcall_interactively): Change "reading args" to
2152 "providing args" to try to clarify what it does (bug#1010).
2153
15fa4783
KH
21542011-07-07 Kenichi Handa <handa@m17n.org>
2155
2156 * composite.c (composition_compute_stop_pos): Ignore a static
2157 composition starting before CHARPOS (Bug#8915).
2158
2159 * xdisp.c (handle_composition_prop): Likewise.
2160
a8815b00
EZ
21612011-07-07 Eli Zaretskii <eliz@gnu.org>
2162
2163 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2164 (Bug#9015)
2165
ef7b981d 21662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2167
2168 * character.h (unicode_category_t): New enum type.
2169
2170 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2171 (Qchar_code_property_table): New variable.
2172 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2173 (UNIPROP_COMPRESSED_FORM_P): New macros.
2174 (char_table_ascii): Uncompress the compressed values.
2175 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2176 Uncompress the compressed values.
ac389d0c 2177 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2178 (char_table_ref_and_range): Uncompress the compressed values.
2179 (sub_char_table_set): New arg is_uniprop. Callers changed.
2180 Uncompress the compressed values.
2181 (sub_char_table_set_range): Args changed. Callers changed.
2182 (char_table_set_range): Adjuted for the above change.
2183 (map_sub_char_table): Delete args default_val and parent. Add arg
2184 top. Give decoded values to a Lisp function.
640c8776 2185 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2186 values to a Lisp function. Gcpro more variables.
2187 (uniprop_table_uncompress)
2188 (uniprop_decode_value_run_length): New functions.
2189 (uniprop_decoder, uniprop_decoder_count): New variables.
2190 (uniprop_get_decoder, uniprop_encode_value_character)
2191 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2192 New functions.
2193 (uniprop_encoder, uniprop_encoder_count): New variables.
2194 (uniprop_get_encoder, uniprop_table)
2195 (Funicode_property_table_internal, Fget_unicode_property_internal)
2196 (Fput_unicode_property_internal): New functions.
2197 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2198 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2199 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2200 char-code-property-alist.
2201
640c8776 2202 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2203 Vunicode_category_table.
2204
640c8776 2205 * font.c (font_range): Adjust for the change of
c805dec0
KH
2206 Vunicode_category_table.
2207
76b397fb
DN
22082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2209
2210 * m/iris4d.h: Remove file, move contents ...
2211 * s/irix6-5.h: ... here.
2212
22b4128e
PE
22132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2216 * alloc.c (mark_buffer):
2217 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2218 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2219 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2220 This isn't true in general, and it's particularly not true
2221 if Emacs is configured with --with-wide-int.
2222 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2223 New macros, used in the buffer.c change.
2224
869795d6
JD
22252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2226
2227 * xsettings.c: Use both GConf and GSettings if both are available.
2228 (store_config_changed_event): Add comment.
2229 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2230 (store_tool_bar_style_changed): New functions.
5e617bc2 2231 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2232 (struct xsettings): Move font inside HAVE_XFT.
2233 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2234 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2235 Move inside HAVE_XFT.
640c8776 2236 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2237 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2238 also.
2239 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2240 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2241 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2242 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2243 (parse_settings): Move check for font inside HAVE_XFT.
2244 (read_settings, apply_xft_settings): Add comment.
2245 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2246 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2247 call store_font_name_changed.
2248 (xft_settings_event): Add comment.
2249 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2250 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2251 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2252 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2253 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2254 (xsettings_get_system_font, xsettings_get_system_normal_font):
2255 Add comment.
869795d6 2256
d8ed26bd
PE
22572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2258
2259 Random fixes. E.g., (random) never returned negative values.
2260 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2261 subseconds part to the entropy, as that's a bit more random.
2262 Prefer signed to unsigned, since the signedness doesn't matter and
2263 in general we prefer signed. When given a limit, use a
2264 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2265 latter isn't right if USE_2_TAGS_FOR_INTS.
2266 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2267 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2268
cabf1cac
SM
22692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2270
2271 * textprop.c (text_property_stickiness):
2272 Obey Vtext_property_default_nonsticky.
2273 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2274 * w32fns.c (syms_of_w32fns):
2275 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2276
6e9b2be9
PE
22772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2280 This is more efficient than Ffile_directory_p and avoids a minor race.
2281
90186c68
LMI
22822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283
7c301272
LMI
2284 * buffer.c (Foverlay_put): Say what the return value is
2285 (bug#7835).
2286
c4f2d8d4
LMI
2287 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2288 is a directory before asking whether to use the file name
2289 (bug#7564).
ad637907
LMI
2290 (barf_or_query_if_file_exists): Make the "File is a directory"
2291 error be more correct.
c4f2d8d4 2292
90186c68
LMI
2293 * fns.c (Frequire): Remove the mention of the .gz files, since
2294 that's installation-specific, but keep the mention of
2295 `get-load-suffixes'.
2296
da64016e
PE
22972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2298
2299 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2300 Report string overflow if the output is too long.
2301
7d47b580
JB
23022011-07-04 Juanma Barranquero <lekktu@gmail.com>
2303
a555cb87
JB
2304 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2305 (syms_of_gnutls): Remove duplicate DEFSYM for
2306 Qgnutls_bootprop_verify_hostname_error, an error for
2307 Qgnutls_bootprop_verify_error (which is no longer used).
2308
7d47b580
JB
2309 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2310 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2311 Also (re)move comments that are misplaced or no longer relevant.
2312
1e49bfab
LMI
23132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2314
2315 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2316
1485f4c0
CY
23172011-07-03 Chong Yidong <cyd@stupidchicken.com>
2318
2319 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2320 and background color parameters if they have been changed.
2321
a9ab721e
LMI
23222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2323
2324 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2325
cf7cff57
PE
23262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2327
2e13213d
PE
2328 * xsettings.c (SYSTEM_FONT): Define only when used.
2329 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2330
cf7cff57
PE
2331 * keymap.c (access_keymap_1): Now static.
2332
7a8e04f7
CY
23332011-07-02 Chong Yidong <cyd@stupidchicken.com>
2334
2335 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2336 leave any prefix arg for the up event (Bug#1586).
2337
61352f62
LMI
23382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2339
69bb1ef7
LMI
2340 * lread.c (syms_of_lread): Mention single symbols defined by
2341 `defvar' or `defconst' (bug#7154).
2342
61352f62 2343 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2344 (Frequire): Mention get-load-suffixes.
61352f62 2345
28545e04
MR
23462011-07-02 Martin Rudalics <rudalics@gmx.at>
2347
2348 * window.h (window): Remove clone_number slot.
2349 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2350 Remove.
2351 (make_parent_window, make_window, saved_window)
2352 (Fset_window_configuration, save_window_save): Don't deal with
2353 clone numbers.
2354 * buffer.c (Qclone_number): Remove declaration.
2355 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2356
3349e122
SM
23572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2358
2359 Add multiple inheritance to keymaps.
2360 * keymap.c (Fmake_composed_keymap): New function.
2361 (Fset_keymap_parent): Simplify.
2362 (fix_submap_inheritance): Remove.
2363 (access_keymap_1): New function extracted from access_keymap to handle
2364 embedded parents and handle lists of maps.
2365 (access_keymap): Use it.
2366 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2367 (Fcopy_keymap): Handle embedded parents.
2368 (Fcommand_remapping, define_as_prefix): Simplify.
2369 (Fkey_binding): Simplify.
2370 (syms_of_keymap): Move minibuffer-local-completion-map,
2371 minibuffer-local-filename-completion-map,
2372 minibuffer-local-must-match-map, and
2373 minibuffer-local-filename-must-match-map to Elisp.
2374 (syms_of_keymap): Defsubr make-composed-keymap.
2375 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2376 (parse_menu_item): Trivial simplification.
2377
3279eb87
GM
23782011-07-01 Glenn Morris <rgm@gnu.org>
2379
2380 * Makefile.in (SETTINGS_LIBS): Fix typo.
2381
4550efdf
KI
23822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2383
2384 * coding.c (Fencode_coding_string): Record the last coding system
2385 used, as the function doc string says (bug#8738).
2386
0949d2b6
JD
23872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2388
2389 * xsettings.c (store_monospaced_changed): Take new font as arg and
2390 check for change against current_mono_font.
2391 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2392 (emacs_settings_constructor, emacs_settings_get_property)
2393 (emacs_settings_set_property, emacs_settings_class_init)
2394 (emacs_settings_init, gsettings_obj): Remove.
2395 (something_changedCB): New function for HAVE_GSETTINGS.
2396 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2397 with value as argument.
2398 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2399 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2400 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2401 "changed".
2402
2403 * xgselect.c: Add defined (HAVE_GSETTINGS).
2404 (xgselect_initialize): Ditto.
2405
2406 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2407 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2408 xg_select.
2409
bbc6b304
PE
24102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * eval.c (struct backtrace): Simplify and port the data structure.
2413 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2414 signed bit field, as this assumption is not portable and it makes
2415 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2416 "char debug_on_exit : 1" as this is not portable either; instead,
2417 use the portable "unsigned int debug_on_exit : 1". Remove unused
2418 member evalargs. Remove obsolete comments about cc bombing out.
2419
9851bfc5
JD
24202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2421
51bb811f 2422 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2423 Let HAVE_GSETTINGS override HAVE_GCONF.
2424 (store_monospaced_changed): New function.
2425 (EMACS_SETTINGS): A new type derived from GObject to handle
2426 GSettings notifications.
2427 (emacs_settings_constructor, emacs_settings_get_property)
2428 (emacs_settings_set_property, emacs_settings_class_init):
2429 New functions.
2430 (gsettings_client, gsettings_obj): New variables.
2431 (GSETTINGS_SCHEMA): New define.
2432 (something_changedCB): Call store_monospaced_changed.
2433 (init_gsettings): New function.
2434 (xsettings_initialize): Call init_gsettings.
2435 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2436 to NULL.
2437
640c8776 2438 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2439 GCONF_CFLAGS/LIBS.
2440
5386012d
MR
24412011-06-29 Martin Rudalics <rudalics@gmx.at>
2442
2443 * window.c (resize_root_window, grow_mini_window)
2444 (shrink_mini_window): Rename Qresize_root_window to
2445 Qwindow_resize_root_window and Qresize_root_window_vertically to
2446 Qwindow_resize_root_window_vertically.
2447
f13e0b08
PE
24482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2451
94515237
JB
24522011-06-27 Juanma Barranquero <lekktu@gmail.com>
2453
2454 * makefile.w32-in: Redesign dependencies so they reflect more
2455 clearly which files are directly included by each source file,
2456 and not through other includes.
2457
e43b6e43
MR
24582011-06-27 Martin Rudalics <rudalics@gmx.at>
2459
2460 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2461 (sort_overlays, overlay_strings): When an overlay's clone number
2462 matches the window's clone number process the overlay even if
2463 the overlay's window property doesn't match the current window.
2464
d68443dc
MR
2465 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2466 (Fwindow_hchild): Rename to Fwindow_left_child.
2467 (Fwindow_next): Rename to Fwindow_next_sibling.
2468 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2469 (resize_window_check): Rename to window_resize_check.
2470 (resize_window_apply): Rename to window_resize_apply.
2471 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2472 (Fdelete_other_windows_internal, resize_frame_windows)
2473 (Fsplit_window_internal, Fdelete_window_internal)
2474 (grow_mini_window, shrink_mini_window)
2475 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2476
c7e73be5
JD
24772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2478
2479 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2480 (emacs_fixed_set_min_size): Remove.
2481 (emacs_fixed_new): Take frame as argument.
2482
2483 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2484 (_EmacsFixedPrivate): Remove minwidth/height.
2485 Add struct frame *f.
2486 (emacs_fixed_init): Initialize priv->f.
2487 (get_parent_class, emacs_fixed_set_min_size): Remove.
2488 (emacs_fixed_new): Set priv->f to argument.
2489 (emacs_fixed_get_preferred_width)
2490 (emacs_fixed_get_preferred_height): Use min_width/height from
2491 frames size_hint to set minimum and natural (Bug#8919).
2492 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2493 and use min_width/height from frames size_hint to set
2494 min_width/height (Bug#8919).
2495
2496 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2497 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2498 Fix indentation.
c7e73be5 2499
cf99dcf8
EZ
25002011-06-26 Eli Zaretskii <eliz@gnu.org>
2501
2502 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2503 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2504 called at ZV.
2505
029529ac
CY
25062011-06-26 Chong Yidong <cyd@stupidchicken.com>
2507
2508 * process.c (wait_reading_process_output): Bypass select if
2509 waiting for a cell while ignoring keyboard input, and input is
2510 pending. Suggested by Jan Djärv (Bug#8869).
2511
7a7ef429
PE
25122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2513
2514 Use gnulib's dup2 module instead of rolling our own.
2515 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2516
11fdef7d 25172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2518
2519 * dispnew.c (scrolling_window): Before scrolling, turn off a
2520 mouse-highlight in the window being scrolled.
2521
cd3520a4
JB
25222011-06-24 Juanma Barranquero <lekktu@gmail.com>
2523
2524 Move DEFSYM to lisp.h and use everywhere.
2525
2526 * character.h (DEFSYM): Move declaration...
2527 * lisp.h (DEFSYM): ...here.
2528
2529 * gnutls.c:
2530 * minibuf.c:
2531 * w32menu.c:
2532 * w32proc.c:
2533 * w32select.c: Don't include character.h.
2534
2535 * alloc.c (syms_of_alloc):
2536 * buffer.c (syms_of_buffer):
2537 * bytecode.c (syms_of_bytecode):
2538 * callint.c (syms_of_callint):
2539 * casefiddle.c (syms_of_casefiddle):
2540 * casetab.c (init_casetab_once):
2541 * category.c (init_category_once, syms_of_category):
2542 * ccl.c (syms_of_ccl):
2543 * cmds.c (syms_of_cmds):
2544 * composite.c (syms_of_composite):
2545 * dbusbind.c (syms_of_dbusbind):
2546 * dired.c (syms_of_dired):
2547 * dispnew.c (syms_of_display):
2548 * doc.c (syms_of_doc):
2549 * editfns.c (syms_of_editfns):
2550 * emacs.c (syms_of_emacs):
2551 * eval.c (syms_of_eval):
2552 * fileio.c (syms_of_fileio):
2553 * fns.c (syms_of_fns):
2554 * frame.c (syms_of_frame):
2555 * fringe.c (syms_of_fringe):
2556 * insdel.c (syms_of_insdel):
2557 * keymap.c (syms_of_keymap):
2558 * lread.c (init_obarray, syms_of_lread):
2559 * macros.c (syms_of_macros):
2560 * msdos.c (syms_of_msdos):
2561 * print.c (syms_of_print):
2562 * process.c (syms_of_process):
2563 * search.c (syms_of_search):
2564 * sound.c (syms_of_sound):
2565 * syntax.c (init_syntax_once, syms_of_syntax):
2566 * terminal.c (syms_of_terminal):
2567 * textprop.c (syms_of_textprop):
2568 * undo.c (syms_of_undo):
2569 * w32.c (globals_of_w32):
2570 * window.c (syms_of_window):
2571 * xdisp.c (syms_of_xdisp):
2572 * xfaces.c (syms_of_xfaces):
2573 * xfns.c (syms_of_xfns):
2574 * xmenu.c (syms_of_xmenu):
2575 * xsettings.c (syms_of_xsettings):
2576 * xterm.c (syms_of_xterm): Use DEFSYM.
2577
4228cf16
TZ
25782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2579
cd3520a4 2580 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2581
7fcccf1e
PE
25822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2583
7efb4e0e
PE
2584 Integer and buffer overflow fixes (Bug#8873).
2585
ff5844ad
PE
2586 * print.c (printchar, strout): Check for string overflow.
2587 (PRINTPREPARE, printchar, strout):
2588 Don't set size unless allocation succeeds.
2589
90532f02
PE
2590 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2591 for sizes. Check for string overflow more accurately.
2592 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2593
6d84508d
PE
2594 * macros.c: Integer and buffer overflow fixes.
2595 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2596 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2597 Use ptrdiff_t, not int, for sizes.
2598 Don't increment bufsize until after realloc succeeds.
2599 Check for size-calculation overflow.
2600 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2601
437b2cb4
PE
2602 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2603
8b9ac8b4
PE
2604 * lread.c: Integer overflow fixes.
2605 (read_integer): Radix is now EMACS_INT, not int,
2606 to improve quality of diagnostics for out-of-range radices.
2607 Calculate buffer size correctly for out-of-range radices.
2608 (read1): Check for integer overflow in radices, and in
2609 read-circle numbers.
82cb60d3
PE
2610 (read_escape): Avoid int overflow.
2611 (Fload, openp, read_buffer_size, read1)
2612 (substitute_object_recurse, read_vector, read_list, map_obarray):
2613 Use ptrdiff_t, not int, for sizes.
2614 (read1): Use EMACS_INT, not int, for sizes.
20270765 2615 Check for size overflow.
8b9ac8b4 2616
7fcccf1e
PE
2617 * image.c (cache_image): Check for size arithmetic overflow.
2618
bfbbd7e7
PE
2619 * lread.c: Integer overflow issues.
2620 (saved_doc_string_size, saved_doc_string_length)
2621 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2622 Now ptrdiff_t, not int.
2623 (read1): Don't assume doc string length fits in int. Check for
2624 out-of-range doc string lengths.
2625 (read_list): Don't assume file position fits in int.
39019e54 2626 (read_escape): Check for hex character overflow.
bfbbd7e7 2627
4e323265
LL
26282011-06-22 Leo Liu <sdl.web@gmail.com>
2629
2630 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2631 Move to minibuffer.el.
2632
85fece3e
PE
26332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2634
20b84ce9 2635 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2636 The following patches are for when GLYPH_DEBUG && !XASSERT.
2637 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2638 * dispnew.c (flush_stdout):
2639 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2640 Mark as externally visible.
2641 * dispnew.c (check_window_matrix_pointers): Now static.
2642 * dispnew.c (window_to_frame_vpos):
2643 * xfns.c (unwind_create_frame):
2644 * xterm.c (x_check_font): Remove unused local.
2645 * scroll.c (CHECK_BOUNDS):
2646 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2647 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2648 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2649 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2650 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2651 Now static.
2652 (debug_method_add): Use va_list and vsprintf rather than relying
2653 on undefined behavior with wrong number of arguments.
2654 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2655 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2656 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2657 since we're not interested in debugging glyphs with old libraries.
2658 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2659 GCC 4.6.0's static checking.
2660
0766b489
PE
26612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2662
31fd4b32
PE
2663 Integer overflow and signedness fixes (Bug#8873).
2664 A few related buffer overrun fixes, too.
2665
b79e8648
PE
2666 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2667
0766b489
PE
2668 * dispextern.h (struct face.stipple):
2669 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2670 (x_bitmap_mask, x_allocate_bitmap_record)
2671 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2672 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2673 (x_create_bitmap_from_xpm_data):
2674 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2675 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2676 (.bitmaps_last):
2677 * xfaces.c (load_pixmap):
2678 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2679 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2680 (.bitmaps_last, struct x_output.icon_bitmap):
2681 Use ptrdiff_t, not int, for bitmap indexes.
2682 (x_allocate_bitmap_record): Check for size overflow.
2683 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2684
b081724f
PE
2685 Use ptrdiff_t, not int, for overlay counts.
2686 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2687 * editfns.c (overlays_around, get_pos_property):
2688 * textprop.c (get_char_property_and_overlay):
2689 * xdisp.c (next_overlay_change, note_mouse_highlight):
2690 * xfaces.c (face_at_buffer_position):
21514da7
PE
2691 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2692 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2693 (Fnext_overlay_change, Fprevious_overlay_change)
2694 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2695 Use ptrdiff_t, not int, for sizes.
21514da7 2696 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2697
3de73e5e
PE
2698 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2699
2606c57b
PE
2700 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2701 (x_session_initialize): Do not assume string length fits in int.
2702
aaafe47a
PE
2703 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2704 This is unlikely, but can occur if DPI is outlandish.
2705
2674ddc8 2706 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2707 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2708
28154962
PE
2709 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2710 * xrdb.c (magic_file_p, search_magic_path):
2711 Omit last arg SUFFIX; it was always 0. All callers changed.
2712 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2713
7de51af5
PE
2714 * xfont.c (xfont_match): Avoid need for strlen.
2715
25ed6cc3
PE
2716 * xfns.c: Don't assume strlen fits in int.
2717 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2718
4eab31dd
PE
2719 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2720 not unsigned long, as we prefer signed integers. All callers changed.
2721 Detect integer overflow in repeat count.
2722 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2723 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2724
171e2a58
PE
2725 * termcap.c: Don't assume sizes fit in int and never overflow.
2726 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2727 (gobble_line): Check for size-calculation overflow.
2728
ad39faca 2729 * minibuf.c (Fread_buffer):
6e5bb2dc 2730 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2731 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2732 Don't assume string length fits in int.
2733
52c61c22 2734 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2735 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2736
b5b8c9e5
PE
2737 * font.c: Don't assume string length fits in int.
2738 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2739 Use ptrdiff_t, not int.
ccd6111c
PE
2740 (font_intern_prop): Don't assume string length fits in int.
2741 Don't assume integer property fits in fixnum.
2742 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2743
882f0d81 2744 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2745 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2746 Reformulate so as not to need the command string.
2747 Invoke gzip -cd rather than gunzip, as it's more portable.
2748 (lock_info_type, lock_file_1, lock_file):
2749 Don't assume pid_t and time_t fit in unsigned long.
2750 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2751 (current_lock_owner): Prefer signed type for sizes.
2752 Use memcpy, not strncpy, where memcpy is what is really wanted.
2753 Don't assume (via atoi) that time_t and pid_t fit in int.
2754 Check for time_t and/or pid_t out of range, e.g., via a network share.
2755 Don't alloca where an auto var works fine.
2756
93f4cf88
PE
2757 * fileio.c: Fix some integer overflow issues.
2758 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2759 Don't assume string length fits in int.
2760 (directory_file_name): Don't assume string length fits in long.
2761 (make_temp_name): Don't assume pid fits in int, or that its print
2762 length is less than 20.
2763
f3e92b69
PE
2764 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2765
1bfdaf10
PE
2766 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2767
35016e9a
PE
2768 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2769
3d1e65a1
PE
2770 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2771 We prefer signed integers, even for size calculations.
2772
0b963a93
PE
2773 * emacs.c: Don't assume string length fits in 'int'.
2774 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2775 (main): Don't invoke strlen when not needed.
2776
573f4b54
PE
2777 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2778 (XD_DEBUG_MESSAGE): Don't waste a byte.
2779
989f33ba
PE
2780 * callproc.c (getenv_internal_1, getenv_internal)
2781 (Fgetenv_internal):
965d34eb
PE
2782 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2783
e4d29b33
PE
2784 * lread.c (invalid_syntax): Omit length argument.
2785 All uses changed. This doesn't fix a bug, but it simplifies the
2786 code away from its former Hollerith-constant appearance, and it's
2787 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2788 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2789
eb49b136
PE
2790 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2791 This didn't break anything, but it didn't help either.
2792 It's confusing to put a bogus integer in a place where the actual
2793 value does not matter.
9f62aeb1 2794 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2795 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2796
15375a22
PE
2797 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2798 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2799 implementation.
b61cc01c
PE
2800 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2801 We prefer signed types, and the value cannot exceed the EMACS_INT
2802 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2803 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2804 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2805 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2806
53b2623d
PE
2807 * indent.c (sane_tab_width): New function.
2808 (current_column, scan_for_column, Findent_to, position_indentation)
2809 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2810 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2811
51cab52b 2812 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2813
f2ed8a70
PE
2814 * lisp.h (lint_assume): New macro.
2815 * composite.c (composition_gstring_put_cache):
2816 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2817
abe80cc6
PE
2818 * editfns.c, insdel.c:
2819 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2820
b02c740e
PE
2821 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2822
ebc96716
PE
2823 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2824
b4e50fa0 2825 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2826 Use much-faster test for byte-length change.
311d5d7c 2827 Don't assume string byte-length fits in 'int'.
a4cf38e4 2828 Check that character arg fits in 'int'.
85461888 2829 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2830
c0c1ee9f
PE
2831 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2832
a498d7f4
PE
2833 * fns.c (concat): Catch string overflow earlier.
2834 Do not rely on integer wraparound.
2835
51cab52b
PE
2836 * dispextern.h (struct it.overlay_strings_charpos)
2837 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2838 * xdisp.c (forward_to_next_line_start)
2839 (back_to_previous_visible_line_start)
2840 (reseat_at_next_visible_line_start, next_element_from_buffer):
2841 Don't arbitrarily truncate the value of 'selective' to int.
2842
76031fad
PE
2843 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2844
5eb55db9
PE
2845 * composite.c: Don't truncate sizes to 'int'.
2846 (composition_gstring_p, composition_reseat_it)
2847 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2848 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2849 not EMACS_UINT, for indexes.
5eb55db9 2850
0703a717
PE
2851 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2852
d6202519
PE
2853 * buffer.c: Include <verify.h>.
2854 (struct sortvec.priority, struct sortstr.priority):
8961a454 2855 Now EMACS_INT, not int.
c20998a7 2856 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2857 (struct sortstr.size, record_overlay_string)
2858 (struct sortstrlist.size, struct sortlist.used):
2859 Don't truncate size to int.
2860 (record_overlay_string): Check for size-calculation overflow.
d6202519 2861 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2862
d5a19415
JM
28632011-06-22 Jim Meyering <meyering@redhat.com>
2864
029529ac 2865 Don't leak an XBM-image-sized buffer
d5a19415
JM
2866 * image.c (xbm_load): Free the image buffer after using it.
2867
a9041e6c
PE
28682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2869
2870 Port to Sun C.
2871 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2872 that Sun C diagnosed.
2873 * fns.c (secure_hash): Fix pointer signedness issue.
2874 * intervals.c (static_offset_intervals): New function.
2875 (offset_intervals): Use it.
2876
7f3f739f
LL
28772011-06-21 Leo Liu <sdl.web@gmail.com>
2878
2879 * deps.mk (fns.o):
2880 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2881 sha512.h.
2882
2883 * fns.c (secure_hash): Rename from crypto_hash_function and change
2884 the first arg to accept symbols.
5b66d427 2885 (Fsecure_hash): New primitive.
7f3f739f
LL
2886 (syms_of_fns): New symbols.
2887
76147d94
DD
28882011-06-20 Deniz Dogan <deniz@dogan.se>
2889
2890 * process.c (Fset_process_buffer): Clarify return value in
2891 docstring.
2892
7d7d0045
CY
28932011-06-18 Chong Yidong <cyd@stupidchicken.com>
2894
2895 * dispnew.c (add_window_display_history): Use BVAR.
2896
2897 * xdisp.c (debug_method_add): Use BVAR.
2898 (check_window_end, dump_glyph_matrix, dump_glyph)
2899 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2900
2901 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2902 Likewise.
2903
2904 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2905 check till after the cache is created in init_frame_faces.
2906
ff2bc410
SM
29072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2908
2909 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2910
28177add
PE
29112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2912
dd3482fe
PE
2913 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2914 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2915 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2916
393d71f3 2917 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2918 * fileio.c (Finsert_file_contents):
2919 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2920 Remove the old (too-loose) buffer overflow checks.
2921 They weren't needed, since make_gap checks for buffer overflow.
2922 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2923 The old code merely checked for Emacs fixnum overflow, and relied
2924 on undefined (wraparound) behavior. The new code avoids undefined
2925 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2926
2e6813b0 2927 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2928 Tune. Don't use wider integers than needed. Don't use alloca.
2929 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2930
599a9e4f
PE
2931 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2932
99561444
PE
2933 * insdel.c, lisp.h (buffer_overflow): New function.
2934 (insert_from_buffer_1, replace_range, replace_range_2):
2935 * insdel.c (make_gap_larger):
2936 * editfns.c (Finsert_char):
2937 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2938
28177add
PE
2939 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2940
e69dafad
PE
29412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2942
a7af7fde 2943 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2944
b1c46f02
PE
2945 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2946 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2947
e69dafad
PE
2948 * fileio.c: Don't assume EMACS_INT fits in off_t.
2949 (emacs_lseek): New static function.
2950 (Finsert_file_contents, Fwrite_region): Use it.
2951 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2952
566684ea
PE
2953 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2954
e6966cd6
PE
2955 * fns.c: Don't overflow int when computing a list length.
2956 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2957 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2958 truncation on 64-bit hosts. Check for QUIT every
2959 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2960 faster and is responsive enough.
2961 (Flength): Report an error instead of overflowing an integer.
2962 (Fsafe_length): Return a float if the value is not representable
2963 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2964 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2965 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2966
dd0b0efb
PE
2967 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2968 (header_size, word_size): New constants.
2969 (allocate_vectorlike): Don't check size overflow here.
2970 (allocate_vector): Check it here instead, since this is the only
2971 caller of allocate_vectorlike that could cause overflow.
2972 Check that the new vector's length is representable as a fixnum.
2973
86fe5cfe
PE
2974 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2975 The previous code was bogus. For example, next_almost_prime (32)
2976 returned 39, which is undesirable as it is a multiple of 3; and
2977 next_almost_prime (24) returned 25, which is a multiple of 5 so
2978 why was the code bothering to check for multiples of 7?
2979
80e88859
PE
2980 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2981
4a2f0ad6
PE
2982 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2983
f66c7cf8
PE
2984 Variadic C functions now count arguments with ptrdiff_t.
2985 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2986 Back then I didn't know that the Emacs coding style prefers signed int.
2987 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2988 were being counted with int, which may truncate counts on 64-bit
2989 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2990 * lisp.h (struct Lisp_Subr.function.aMANY)
2991 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2992 Arg counts are now ptrdiff_t, not size_t.
2993 All variadic functions and their callers changed accordingly.
2994 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2995 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2996 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2997 * callint.c (Fcall_interactively): Check arg count for overflow,
2998 to avoid potential buffer overrun. Use signed char, not 'int',
2999 for 'varies' array, so that we needn't bother to check its size
3000 calculation for overflow.
3001 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3002 * eval.c (apply_lambda):
3003 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3004 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3005 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3006
a1759b76
PE
3007 * callint.c (Fcall_interactively): Don't use index var as event count.
3008
d96be9fc
PE
3009 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3010 * mem-limits.h (SIZE): Remove; no longer used.
3011
a690a978 3012 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3013
578c21e6
PE
3014 Remove unnecessary casts.
3015 * xterm.c (x_term_init):
3016 * xfns.c (x_set_border_pixel):
3017 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3018 These aren't needed now that we assume ANSI C.
3019
96f53c6c
PE
3020 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3021 It's more likely to cause problems (due to unsigned overflow)
3022 than to cure them.
3023
83c77d31
PE
3024 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3025
ee2079f1
PE
3026 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3027
6da65536
PE
3028 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3029
7147c4a4
PE
3030 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3031
193e32d9
PE
3032 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3033
e5533da6
PE
3034 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3035
9910e595
PE
3036 GLYPH_CODE_FACE returns EMACS_INT, not int.
3037 * dispextern.h (merge_faces):
3038 * xfaces.c (merge_faces):
01103c44
PE
3039 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3040 Don't assume EMACS_INT fits in int.
9910e595 3041
2638320e
PE
3042 * character.h (CHAR_VALID_P): Remove unused parameter.
3043 * fontset.c, lisp.h, xdisp.c: All uses changed.
3044
045eb8d9
PE
3045 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3046
c1f134b5
PE
3047 * fns.c (concat): Minor tuning based on overflow analysis.
3048 This doesn't fix any bugs. Use int to hold character, instead
3049 of constantly refetching from Emacs object. Use XFASTINT, not
3050 XINT, for value known to be a character. Don't bother comparing
3051 a single byte to 0400, as it's always less.
3052
395fcb93 3053 * floatfns.c (Fexpt):
327eeec8
PE
3054 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3055
abbd3d23
PE
3056 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3057 for characters.
3058
684a03ef
PE
3059 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3060
0fed43f3
PE
3061 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3062 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3063 incorrectly succeed when S was a string, because 4294967386 was
3064 truncated before it was used.
3065
8fd02eb7
PE
3066 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3067 Otherwise, an out-of-range integer could cause undefined behavior
3068 on a 64-bit host.
3069
f8c86b69
PE
3070 * composite.c: Use int, not EMACS_INT, for characters.
3071 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3072 EMACS_INT, for values that are known to be in character range.
3073 This doesn't fix any bugs but is the usual style inside Emacs and
3074 may generate better code on 32-bit machines.
3075
34206dd2
PE
3076 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3077 This is for reasons similar to the recent CHAR_STRING fix.
3078 * charset.c (Fencode_char): Check that character arg is actually
3079 a character. Pass an int to ENCODE_CHAR.
3080 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3081 wider than 'int', as a compile-time check to prevent future regressions
3082 in this area.
3083
c5958d4c 3084 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3085
3086 Make sure a 64-bit char is never passed to CHAR_STRING.
3087 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3088 by silently ignoring the top 32 bits, allowing some values
3089 that were far too large to be valid characters.
3090 * character.h: Include <verify.h>.
3091 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3092 arguments are no wider than unsigned, as a compile-time check
3093 to prevent future regressions in this area.
3094 * data.c (Faset):
01103c44 3095 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3096 (Fsubst_char_in_region):
3097 * fns.c (concat):
3098 * xdisp.c (decode_mode_spec_coding):
3099 Adjust to CHAR_STRING's new requirement.
3100 * editfns.c (Finsert_char, Fsubst_char_in_region):
3101 * fns.c (concat): Check that character args are actually
3102 characters. Without this test, these functions did the wrong
3103 thing with wildly out-of-range values on 64-bit hosts.
3104
d37ca623
PE
3105 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3106 These casts should not be needed on 32-bit hosts, either.
3107 * keyboard.c (read_char):
3108 * lread.c (Fload): Remove casts to unsigned.
3109
ea204efb
PE
3110 * lisp.h (UNSIGNED_CMP): New macro.
3111 This fixes comparison bugs on 64-bit hosts.
3112 (ASCII_CHAR_P): Use it.
3113 * casefiddle.c (casify_object):
01103c44 3114 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3115 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3116 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3117 * dispextern.h (FACE_FROM_ID):
3118 * keyboard.c (read_char): Use UNSIGNED_CMP.
3119
41cb286c
PE
3120 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3121 not to EMACS_INT, to avoid GCC warning.
3122
4a1b9832
PE
3123 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3124
55daad71
PE
3125 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3126 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3127 isn't needed on 32-bit machines.
8f95c75c 3128
01103c44
PE
3129 * buffer.c (Fgenerate_new_buffer_name):
3130 Use EMACS_INT for count, not int.
0ceccced 3131 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3132
3133 * data.c (Qcompiled_function): Now static.
3134
c6f072e7
PE
3135 * window.c (window_body_lines): Now static.
3136
20ce5912
PE
3137 * image.c (gif_load): Rename local to avoid shadowing.
3138
9c4c5f81
PE
3139 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3140 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3141 * alloc.c (make_save_value): Integer argument is now of type
3142 ptrdiff_t, not int.
3143 (mark_object): Use ptrdiff_t, not int.
3144 * lisp.h (pD): New macro.
3145 * print.c (print_object): Use it.
3146
c0c5c8ae
PE
3147 * alloc.c: Use EMACS_INT, not int, to count objects.
3148 (total_conses, total_markers, total_symbols, total_vector_size)
3149 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3150 (total_free_floats, total_floats, total_free_intervals)
3151 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3152 Now EMACS_INT, not int. All uses changed.
3153 (Fgarbage_collect): Compute overall total using a double, so that
3154 integer overflow is less likely to be a problem. Check for overflow
3155 when converting back to an integer.
5a25e253
PE
3156 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3157 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3158 These were 'int' variables that could overflow on 64-bit hosts;
3159 they were never used, so remove them instead of repairing them.
211a0b2a 3160 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3161 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3162 Previously, this ceilinged at INT_MAX, but that doesn't work on
3163 64-bit machines.
e46bb31a 3164 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3165
c78baabf 3166 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3167 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3168 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3169 when a (possibly-narrower) signed value would do just as well.
3170 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3171
c9d624c6
PE
3172 * alloc.c: Catch some string size overflows that we were missing.
3173 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3174 for convenience in STRING_BYTES_MAX.
3175 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3176 The definition here is exact; the one in lisp.h was approximate.
3177 (allocate_string_data): Check for string overflow. This catches
3178 some instances we weren't catching before. Also, it catches
3179 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3180 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3181 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3182
c9d624c6
PE
3183 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3184 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3185 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3186
353032ce
PE
3187 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3188
2bccce07
PE
3189 * alloc.c (Fmake_string): Check for out-of-range init.
3190
0ac30604
SM
31912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3192
3193 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3194
c195f2de
JD
31952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3196
3197 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3198 xg_get_default_scrollbar_width.
3199
3200 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3201 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3202 (style_changed_cb): Call update_theme_scrollbar_width and call
3203 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3204 all frames (Bug#8505).
3205 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3206 Call gtk_window_set_resizable if HAVE_GTK3.
3207 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3208 and height if HAVE_GTK3 (Bug#8505).
3209 (scroll_bar_width_for_theme): New variable.
3210 (update_theme_scrollbar_width): New function.
3211 (xg_get_default_scrollbar_width): Move code to
3212 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3213 (xg_initialize): Call update_theme_scrollbar_width.
3214
3215 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3216
3217 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3218
e10ac9f1
MR
32192011-06-12 Martin Rudalics <rudalics@gmx.at>
3220
3221 * frame.c (make_frame): Call other_buffer_safely instead of
3222 other_buffer.
3223
3224 * window.c (temp_output_buffer_show): Call display_buffer with
3225 second argument Vtemp_buffer_show_specifiers and reset latter
3226 immediately after the call.
3227 (Vtemp_buffer_show_specifiers): New variable.
3228 (auto_window_vscroll_p, next_screen_context_lines)
3229 (Vscroll_preserve_screen_position): Remove leading asterisks from
3230 doc-strings.
3231
2d3c217e 32322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3233
7b7f97e8 3234 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3235 * buffer.c (Qclone_number): Remove for now, as it's unused.
3236 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3237 (record_buffer): Remove unused local.
3238 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3239 (set_frame_buffer_list): Remove; unused.
3240 * frame.h (other_visible_frames): Remove decl.
3241 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3242 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3243 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3244 if HAVE_GPM.
3245 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3246 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3247 Define only if HAVE_GPM.
3248 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3249 (update_hints_inhibit): Remove; never set. All uses removed.
3250 * widgetprv.h (emacsFrameClassRec): Remove decl.
3251 * window.c (delete_deletable_window): Now returns void, since it
3252 wasn't returning anything.
3253 (compare_window_configurations): Remove unused locals.
3254 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3255 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3256 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3257 the same widths as pointers. This follows up on the 2011-05-06 patch.
3258 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3259 * xterm.h: Likewise.
3260 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3261
1384b89e
JB
32622011-06-12 Juanma Barranquero <lekktu@gmail.com>
3263
3264 * makefile.w32-in: Update dependencies.
3265 (LISP_H): Add lib/intprops.h.
3266
1100a63c
CY
32672011-06-11 Chong Yidong <cyd@stupidchicken.com>
3268
3269 * image.c (gif_load): Add animation frame delay to the metadata.
3270 (syms_of_image): Use DEFSYM. New symbol `delay'.
3271
6198ccd0
MR
32722011-06-11 Martin Rudalics <rudalics@gmx.at>
3273
3274 * window.c (delete_deletable_window): Re-add.
3275 (Fset_window_configuration): Rewrite to handle dead buffers and
3276 consequently deletable windows.
3277 (window_tree, Fwindow_tree): Remove. Supply functionality in
3278 window.el.
3279 (compare_window_configurations): Simplify code.
3280
b6e3633c
AS
32812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3282
1ab0dee5
AS
3283 * image.c (imagemagick_load_image): Fix type mismatch.
3284 (Fimagemagick_types): Likewise.
3285
b6e3633c
AS
3286 * window.h (replace_buffer_in_windows): Declare.
3287
9397e56f
MR
32882011-06-11 Martin Rudalics <rudalics@gmx.at>
3289
3290 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3291 Qclone_number. Remove external declaration of Qdelete_window.
3292 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3293 code.
640c8776
SM
3294 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3295 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3296 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3297 buffer list implementation.
3298 (other_buffer_safely): New function.
3299 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3300 calls to replace_buffer_in_windows and
3301 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3302 if allowed.
3303 (record_buffer): Inhibit quitting and rewrite using quittable
3304 functions. Run Qbuffer_list_update_hook if allowed.
3305 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3306 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3307 Move switch-to-buffer to window.el.
9397e56f
MR
3308 (bury-buffer): Move to window.el.
3309 (Vbuffer_list_update_hook): New variable.
3310
3311 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3312 section.
3313
3314 * window.h (resize_frame_windows): Move up in code.
3315 (Fwindow_frame): Remove EXFUN.
3316 (replace_buffer_in_all_windows): Remove prototype.
3317 (replace_buffer_in_windows_safely): Add prototype.
3318
3319 * window.c: Declare Qdelete_window static again. Move down
3320 declaration of select_count.
3321 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3322 (Fother_window): Move to window.el.
3323 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3324 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3325 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3326 window.el.
3327 (replace_buffer_in_windows): Implement by calling
3328 Qreplace_buffer_in_windows.
3329 (replace_buffer_in_all_windows): Remove with some functionality
3330 moved into replace_buffer_in_windows_safely.
3331 (replace_buffer_in_windows_safely): New function.
3332 (select_window_norecord, select_frame_norecord): Move in front
3333 of run_window_configuration_change_hook. Remove now obsolete
3334 declarations.
640c8776
SM
3335 (Fset_window_buffer): Rewrite doc-string.
3336 Call Qrecord_window_buffer.
9397e56f
MR
3337 (keys_of_window): Move binding for other-window to window.el.
3338
b50691aa
CY
33392011-06-11 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * dispextern.h (struct image): Replace data member, whose int_val
3342 and ptr_val fields were not used by anything, with a single
3343 lisp_val object.
3344
3345 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3346 (gif_clear_image, gif_load, imagemagick_load_image)
3347 (gs_clear_image, gs_load): Callers changed.
3348
3f754b86
PE
33492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3350
cca69397
PE
3351 * buffer.h: Include <time.h>, for time_t.
3352 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3353
109e28d0
PE
3354 Fix minor problems found by static checking.
3355
60737f02
PE
3356 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3357
4b66faf3
PE
3358 Make identifiers static if they are not used in other modules.
3359 * data.c (Qcompiled_function, Qframe, Qvector):
3360 * image.c (QimageMagick, Qsvg):
3361 * minibuf.c (Qmetadata):
3362 * window.c (resize_window_check, resize_root_window): Now static.
3363 * window.h (resize_window_check, resize_root_window): Remove decls.
3364
109e28d0
PE
3365 * window.c (window_deletion_count, delete_deletable_window):
3366 Remove; unused.
46a4ce9e
PE
3367 (window_body_lines): Now static.
3368 (Fdelete_other_windows_internal): Mark vars as initialized.
3369 Make sure 'resize_failed' is initialized.
3370 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3371 (resize_window_apply): Remove unused local.
3372 * window.h (delete_deletable_window): Remove decl.
3373
109e28d0 3374 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3375 (imagemagick_load_image): Fix pointer signedness problem by changing
3376 last arg from unsigned char * to char *. All uses changed.
3377 Also, fix a local for similar reasons.
3378 Remove unused locals. Remove locals to avoid shadowing.
3379 (fn_rsvg_handle_free): Remove; unused.
3380 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3381 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3382
3f754b86
PE
3383 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3384
2547adb1
CY
33852011-06-10 Chong Yidong <cyd@stupidchicken.com>
3386
3387 * image.c (gif_load): Fix omitted cast error introduced by
3388 2011-06-06 change.
3389
2c8e37d4
MR
33902011-06-10 Martin Rudalics <rudalics@gmx.at>
3391
3392 * window.h (resize_proportionally, orig_total_lines)
3393 (orig_top_line): Remove from window structure.
3394 (set_window_height, set_window_width, change_window_heights)
3395 (Fdelete_window): Remove prototypes.
3396 (resize_frame_windows): Remove duplicate declaration.
3397
440a42e3
EZ
33982011-06-10 Eli Zaretskii <eliz@gnu.org>
3399
3400 * window.h (resize_frame_windows, resize_window_check)
3401 (delete_deletable_window, resize_root_window)
3402 (resize_frame_windows): Declare prototypes.
3403
3404 * window.c (resize_window_apply): Make definition be "static" to
3405 match the prototype.
3406
562dd5e9
MR
34072011-06-10 Martin Rudalics <rudalics@gmx.at>
3408
3409 * window.c: Remove declarations of Qwindow_size_fixed,
3410 window_min_size_1, window_min_size_2, window_min_size,
3411 size_window, window_fixed_size_p, enlarge_window, delete_window.
3412 Remove static from declaration of Qdelete_window, it's
3413 temporarily needed by Fbury_buffer.
3414 (replace_window): Don't assign orig_top_line and
3415 orig_total_lines.
3416 (Fdelete_window, delete_window): Remove. Window deletion is
3417 handled by window.el.
640c8776
SM
3418 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3419 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3420 (Fdelete_other_windows): Remove. Deleting other windows is
3421 handled by window.el.
3422 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3423 handled in window.el.
3424 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3425 Window minimum sizes are handled in window.el.
3426 (shrink_windows, size_window, set_window_height)
3427 (set_window_width, change_window_heights, window_height)
3428 (window_width, CURBEG, CURSIZE, enlarge_window)
3429 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3430 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3431 handled in window.el.
3432 (make_dummy_parent): Rename to make_parent_window and give it a
3433 second argument horflag.
3434 (make_window): Don't set resize_proportionally any more.
3435 (Fsplit_window): Remove. Windows are split in window.el.
3436 (save_restore_action, save_restore_orig_size)
3437 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3438 Resize mini windows in window.el.
3439 (grow_mini_window, shrink_mini_window): Implement by calling
3440 Qresize_root_window_vertically, resize_window_check and
3441 resize_window_apply.
640c8776
SM
3442 (saved_window, Fset_window_configuration, save_window_save):
3443 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3444 resize_proportionally.
3445 (window_min_height, window_min_width): Move to window.el.
3446 (keys_of_window): Move bindings for delete-other-windows,
3447 split-window, delete-window and enlarge-window to window.el.
3448
3449 * buffer.c: Temporarily extern Qdelete_window.
3450 (Fbury_buffer): Temporarily call Qdelete_window instead of
3451 Fdelete_window (Fbury_buffer will move to window.el soon).
3452
3453 * frame.c (set_menu_bar_lines_1): Remove code handling
3454 orig_top_line and orig_total_lines.
3455
3456 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3457 set_window_height but set heights directly.
3458 (change_frame_size_1): Use resize_frame_windows.
3459
3460 * xdisp.c (init_xdisp): Don't use set_window_height but set
3461 heights directly.
3462
640c8776
SM
3463 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3464 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3465 run_window_configuration_change_hook.
3466
3467 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3468 instead of change_window_heights and run
3469 run_window_configuration_change_hook.
3470
1a13852e
MR
34712011-06-09 Martin Rudalics <rudalics@gmx.at>
3472
3473 * window.c (replace_window): Rename second argument REPLACEMENT to
3474 NEW. New third argument SETFLAG. Rewrite.
3475 (delete_window, make_dummy_parent): Call replace_window with
3476 third argument 1.
3477 (window_list_1): Move down in code.
3478 (run_window_configuration_change_hook): Move set_buffer part
3479 before select_frame_norecord part in order to unwind correctly.
3480 Rename count1 to count.
3481 (recombine_windows, delete_deletable_window, resize_root_window)
3482 (Fdelete_other_windows_internal)
3483 (Frun_window_configuration_change_hook, make_parent_window)
3484 (resize_window_check, resize_window_apply, Fresize_window_apply)
3485 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3486 (Fdelete_window_internal, Fresize_mini_window_internal):
3487 New functions.
1a13852e
MR
3488 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3489
f3d1777e
MR
34902011-06-08 Martin Rudalics <rudalics@gmx.at>
3491
496e208e
MR
3492 * window.h (window): Add some new members to window structure -
3493 normal_lines, normal_cols, new_total, new_normal, clone_number,
3494 splits, nest, prev_buffers, next_buffers.
3495 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3496 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3497
f3d1777e
MR
3498 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3499 Remove.
496e208e
MR
3500 (make_dummy_parent): Set new members of windows structure.
3501 (make_window): Move down in code. Handle new members of window
3502 structure.
3503 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3504 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3505 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3506 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3507 (Fset_window_next_buffers, Fset_window_clone_number):
3508 New functions.
496e208e
MR
3509 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3510 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3511 Doc-string fixes.
3512 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3513 Argument WINDOW can be now internal window too.
3514 (Fwindow_use_time): Move up in code.
3515 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3516 Rewrite doc-string.
3517 (Fset_window_configuration, saved_window)
3518 (Fcurrent_window_configuration, save_window_save): Handle new
3519 members of window structure.
b9e809c2
MR
3520 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3521 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3522 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3523 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3524 Qget_mru_window, Qresize_root_window,
3525 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3526 Qauto_buffer_name; staticpro them.
f3d1777e 3527
abde8f8c
MR
35282011-06-07 Martin Rudalics <rudalics@gmx.at>
3529
3530 * window.c (Fwindow_total_size, Fwindow_left_column)
3531 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3532 (Fwindow_list_1): New functions.
3533 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3534 (Fwindow_width, Fscroll_left, Fscroll_right):
3535 Use window_body_cols instead of window_box_text_cols.
3536 (delete_window, Fset_window_configuration):
3537 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3538 (delete_all_subwindows): Take a window as argument and not a
3539 structure. Rewrite.
190b47e6
MR
3540 (window_loop): Remove handling of GET_LRU_WINDOW and
3541 GET_LARGEST_WINDOW.
3542 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3543
3544 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3545 window_box_text_cols. delete_all_subwindows now takes a
3546 Lisp_Object as argument.
abde8f8c 3547
640c8776
SM
3548 * indent.c (compute_motion, Fcompute_motion):
3549 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3550
fa8a67e6
MR
3551 * frame.c (delete_frame): Call delete_all_subwindows with root
3552 window as argument.
3553
a54e3482
DC
35542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3555
3556 * fns.c (Fputhash): Document return value.
3557
60002bf5
CY
35582011-06-06 Chong Yidong <cyd@stupidchicken.com>
3559
3560 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3561
0c671da6 35622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3563
b862a52a 3564 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3565
be44ca6c
PE
3566 Check for overflow when converting integer to cons and back.
3567 * charset.c (Fdefine_charset_internal, Fdecode_char):
3568 Use cons_to_unsigned to catch overflow.
3569 (Fencode_char): Use INTEGER_TO_CONS.
3570 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3571 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3572 * data.c (long_to_cons, cons_to_long): Remove.
3573 (cons_to_unsigned, cons_to_signed): New functions.
3574 These signal an error for invalid or out-of-range values.
3575 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3576 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3577 * font.c (Ffont_variation_glyphs):
3578 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3579 * lisp.h: Include <intprops.h>.
3580 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3581 (cons_to_signed, cons_to_unsigned): New decls.
3582 (long_to_cons, cons_to_long): Remove decls.
3583 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3584 (Fprimitive_undo): Use CONS_TO_INTEGER.
3585 * xfns.c (Fx_window_property): Likewise.
3586 * xselect.c: Include <limits.h>.
3587 (x_own_selection, selection_data_to_lisp_data):
3588 Use INTEGER_TO_CONS.
3589 (x_handle_selection_request, x_handle_selection_clear)
3590 (x_get_foreign_selection, Fx_disown_selection_internal)
3591 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3592 (lisp_data_to_selection_data): Use cons_to_unsigned.
3593 (x_fill_property_data): Use cons_to_signed.
3594 Report values out of range.
3595
d1f3d2af
PE
3596 Check for buffer and string overflow more precisely.
3597 * buffer.h (BUF_BYTES_MAX): New macro.
3598 * lisp.h (STRING_BYTES_MAX): New macro.
3599 * alloc.c (Fmake_string):
3600 * character.c (string_escape_byte8):
3601 * coding.c (coding_alloc_by_realloc):
3602 * doprnt.c (doprnt):
3603 * editfns.c (Fformat):
3604 * eval.c (verror):
3605 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3606 since they may not be the same number.
3607 * editfns.c (Finsert_char):
3608 * fileio.c (Finsert_file_contents):
3609 Likewise for BUF_BYTES_MAX.
3610
dd52fcea
PE
3611 * image.c: Use ptrdiff_t, not int, for sizes.
3612 (slurp_file): Switch from int to ptrdiff_t.
3613 All uses changed.
3614 (slurp_file): Check that file size fits in both size_t (for
3615 malloc) and ptrdiff_t (for sanity and safety).
3616
7f9bbdbb
PE
3617 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3618 if b->modtime has its maximal value.
3619
dfe18f82
PE
3620 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3621
84acfcf0
PE
3622 Don't assume time_t can fit into int.
3623 * buffer.h (struct buffer.modtime): Now time_t, not int.
3624 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3625 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3626
ccd9a01a
PE
3627 Minor fixes for signed vs unsigned integers.
3628 * character.h (MAYBE_UNIFY_CHAR):
3629 * charset.c (maybe_unify_char):
3630 * keyboard.c (read_char, reorder_modifiers):
3631 XINT -> XFASTINT, since the integer must be nonnegative.
3632 * ftfont.c (ftfont_spec_pattern):
3633 * keymap.c (access_keymap, silly_event_symbol_error):
3634 XUINT -> XFASTINT, since the integer must be nonnegative.
3635 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3636 since it makes no difference and we prefer signed.
3637 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3638 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3639 nonnegative.
3640
d6d100dd
SM
36412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3642
3643 * window.h (Fwindow_frame): Declare.
3644
2b6148e4
PE
36452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3646
3647 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3648 (SPARE_MEMORY): Always define.
3649 (LARGE_REQUEST): Remove.
3650 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3651
f230ecc9
MR
36522011-06-06 Martin Rudalics <rudalics@gmx.at>
3653
727e958e
MR
3654 * lisp.h: Move EXFUNS for Fframe_root_window,
3655 Fframe_first_window and Fset_frame_selected_window to window.h.
3656
3657 * window.h: Move EXFUNS for Fframe_root_window,
3658 Fframe_first_window and Fset_frame_selected_window here from
3659 lisp.h.
3660
3661 * frame.c (Fwindow_frame, Fframe_first_window)
3662 (Fframe_root_window, Fframe_selected_window)
3663 (Fset_frame_selected_window): Move to window.c.
3664 (Factive_minibuffer_window): Move to minibuf.c.
3665 (Fother_visible_frames_p): New function.
3666
3667 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3668
f230ecc9
MR
3669 * window.c (decode_window, decode_any_window): Move up in code.
3670 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3671 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3672 (Fwindow_buffer): Move up and rewrite doc-string.
3673 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3674 (Fwindow_prev): New functions.
727e958e
MR
3675 (Fwindow_frame): Move here from frame.c. Accept any window as
3676 argument.
3677 (Fframe_root_window, Fframe_first_window)
3678 (Fframe_selected_window): Move here from frame.c. Accept frame
3679 or arbitrary window as argument. Update doc-strings.
3680 (Fminibuffer_window): Move up in code.
3681 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3682 (Fset_frame_selected_window): Move here from frame.c.
3683 Marginal rewrite.
727e958e
MR
3684 (Fselected_window, select_window, Fselect_window): Move up in
3685 code. Minor doc-string fixes.
f230ecc9 3686
4d09bcf6
PE
36872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3688
3689 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3690 Do not assume that spare memory exists; that assumption is valid
3691 only if SYSTEM_MALLOC.
3692 (LARGE_REQUEST): New macro, so that the issue of large requests
3693 is separated from the issue of spare memory.
3694
810928a2
AS
36952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3696
172418ad
AS
3697 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3698 format. (Bug#8806)
3699
43f862f7
AS
3700 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3701
810928a2
AS
3702 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3703 before statements.
3704
a059fe24
JD
37052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3706
3707 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3708
3709 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3710
3711 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3712 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3713
989bf368
JB
37142011-06-05 Juanma Barranquero <lekktu@gmail.com>
3715
3716 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3717
4b80f674
CY
37182011-06-04 Chong Yidong <cyd@stupidchicken.com>
3719
3720 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3721 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3722 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3723 New error handlers.
4b80f674
CY
3724 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3725 Obey Vx_select_enable_clipboard_manager. Catch errors in
3726 x_clipboard_manager_save (Bug#8779).
3727 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3728 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3729
99a33b77 37302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3731
3732 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3733
99a33b77 37342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3735
3736 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3737 in the current matrix if keep_current_p is non-zero.
3738
8264569d
EZ
37392011-06-04 Eli Zaretskii <eliz@gnu.org>
3740
3741 * bidi.c (bidi_level_of_next_char): Fix last change.
3742
57f97249
EZ
37432011-06-03 Eli Zaretskii <eliz@gnu.org>
3744
fec2107c 3745 Support bidi reordering of text covered by display properties.
57f97249 3746
fec2107c
EZ
3747 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3748 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3749 (bidi_cache_search, bidi_cache_iterator_state)
3750 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3751 (bidi_level_of_next_char, bidi_move_to_visually_next):
3752 Support character positions inside a run of characters covered by a
fec2107c
EZ
3753 display string.
3754 (bidi_paragraph_init, bidi_resolve_explicit_1)
3755 (bidi_level_of_next_char): Call bidi_fetch_char and
3756 bidi_fetch_char_advance instead of FETCH_CHAR and
3757 FETCH_CHAR_ADVANCE.
3758 (bidi_init_it): Initialize new members.
3759 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3760 definitions.
3761 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3762 instead of using explicit *_CHAR codes.
d6d100dd
SM
3763 (bidi_resolve_explicit, bidi_resolve_weak):
3764 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3765 bidirectional text is supported only in multibyte buffers.
3766 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3767 it to initialize the frame_window_p member of struct bidi_it.
3768 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3769 (bidi_resolve_explicit, bidi_resolve_weak)
3770 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3771 bidi_it->nchars is non-positive.
3772 (bidi_level_of_next_char): Don't try to lookup the cache for the
3773 next/previous character if nothing is cached there yet, or if we
3774 were just reseat()'ed to a new position.
c40e2fb2 3775
0e14fe90
EZ
3776 * xdisp.c (set_cursor_from_row): Set start and stop points
3777 according to the row's direction when priming the loop that looks
3778 for the glyph on which to display cursor.
3779 (single_display_spec_intangible_p): Function deleted.
3780 (display_prop_intangible_p): Reimplement to call
3781 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3782 Accept 3 additional arguments needed by handle_display_spec.
3783 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3784 values: lists, `(when COND...)' forms, etc.
3785 (single_display_spec_string_p): Support property values that are
3786 lists with the argument STRING its top-level element.
3787 (display_prop_string_p): Fix the condition for processing a
3788 property that is a list to be consistent with handle_display_spec.
fec2107c 3789 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3790 last portion of handle_display_prop.
3791 (compute_display_string_pos): Accept additional argument
3792 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3793 value of a `display' property is a "replacing spec".
3794 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3795 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3796 the display property, but just return a value indicating whether
3797 the display property will replace the characters it covers.
3798 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3799 frame_window_p members of struct bidi_it.
d6d100dd
SM
3800 (compute_display_string_pos, compute_display_string_end):
3801 New functions.
fec2107c
EZ
3802 (push_it): Accept second argument POSITION, where pop_it should
3803 jump to continue iteration.
3804 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3805
fec2107c
EZ
3806 * keyboard.c (adjust_point_for_property): Adjust the call to
3807 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3808
3809 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3810 (bidi_init_it): Update prototypes.
3811 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3812 (compute_display_string_pos, compute_display_string_end):
3813 Declare prototypes.
fec2107c
EZ
3814 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3815 EMACS_INT.
fc6f18ce 3816
40087514 38172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3818
57f53182
PE
3819 Malloc failure behavior now depends on size of allocation.
3820 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3821 * lisp.h: Change signatures accordingly.
3822 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3823 All callers changed. (Bug#8762)
3824
3825 * gnutls.c: Use Emacs's memory allocators.
3826 Without this change, the gnutls library would invoke malloc etc.
3827 directly, which causes problems on non-SYNC_INPUT hosts, and which
3828 runs afoul of improving memory_full behavior. (Bug#8761)
3829 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3830 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3831 xfree instead of the default malloc, realloc, free.
3832 (Fgnutls_boot): No need to check for memory allocation failure,
3833 since xmalloc does that for us.
3834
ac32cd99 3835 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3836 * category.c (hash_get_category_set):
3837 * ccl.c (ccl_driver):
3838 * charset.c (Fdefine_charset_internal):
3839 * charset.h (struct charset.hash_index):
3840 * composite.c (get_composition_id, gstring_lookup_cache)
3841 (composition_gstring_put_cache):
3842 * composite.h (struct composition.hash_index):
3843 * dispextern.h (struct image.hash):
3844 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3845 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3846 (hashfn_equal, hashfn_user_defined, make_hash_table)
3847 (maybe_resize_hash_table, hash_lookup, hash_put)
3848 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3849 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3850 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3851 * image.c (make_image, search_image_cache, lookup_image)
3852 (xpm_put_color_table_h):
3853 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3854 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3855 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3856 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3857 * alloc.c (allocate_vectorlike):
3858 Check for overflow in vector size calculations.
3859 * ccl.c (ccl_driver):
3860 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3861 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3862 need to be updated by these changes.
40087514
PE
3863 * fns.c (make_hash_table, maybe_resize_hash_table):
3864 Check for integer overflow with large hash tables.
0de4bb68
PE
3865 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3866 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3867 (SXHASH_REDUCE): New macro.
3868 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3869 Use it instead of discarding useful hash info with large hash values.
3870 (sxhash_float): New function.
3871 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3872 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3873 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3874 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3875 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3876 Adjust signatures to match updated version of code.
3877 (consing_since_gc): Now EMACS_INT, since a single hash table can
3878 use more than INT_MAX bytes.
3879
698d32e2
DN
38802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3881
3882 Make it possible to build with GCC-4.6+ -O2 -flto.
3883
3884 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3885
fd6fa53f
SM
38862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3887
3888 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3889 Call minibuffer-inactive-mode.
3890
864db017
JB
38912011-05-31 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3894 Update dependencies.
3895
2ad0baf4
DN
38962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3897
3898 * data.c (init_data): Remove code for UTS, this system is not
3899 supported anymore.
3900
4fcc2638
DN
39012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3902
3903 Don't force ./temacs to start in terminal mode.
3904
3905 * frame.c (make_initial_frame): Initialize faces in all cases, not
3906 only when CANNOT_DUMP is defined.
3907 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3908
c56e0fd5
DN
39092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3910
3911 * dispnew.c (add_window_display_history): Use const for the string
3912 pointer. Remove declaration, not needed.
3913
333d54da 39142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3915
55d4c1b2 3916 Use 'inline', not 'INLINE'.
333d54da 3917 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3918 * alloc.c, fontset.c (INLINE): Remove.
3919 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3920 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3921 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3922 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3923 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3924
738db178
DN
39252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3926
3927 Make it possible to run ./temacs.
3928
3929 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3930 syms_of_callproc does the same thing. Remove test for
3931 "initialized", do it in the caller.
3932 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3933
620c53a6
SM
39342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3937 (read_minibuf): Use get_minibuffer.
3938 (syms_of_minibuf): Use DEFSYM.
3939 (Qmetadata): New var.
3940 * data.c (Qbuffer): Don't make it static.
3941 (syms_of_data): Use DEFSYM.
3942
e003a292
PE
39432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3944
3945 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3946 (CCL_CODE_MIN): New macro.
3947
ed008a6d
PE
39482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3949
3687c2ef
PE
3950 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3951
ed008a6d
PE
3952 * eval.c (Qdebug): Now static.
3953 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3954 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3955 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3956
d66c4c7c
CY
39572011-05-29 Chong Yidong <cyd@stupidchicken.com>
3958
3959 * image.c: Various fixes to ImageMagick code comments.
3960 (Fimagemagick_types): Doc fix.
3961
5fbc2025
PE
39622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3963
0196f88a
PE
3964 Minor fixes prompted by GCC 4.6.0 warnings.
3965
3966 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3967
5fbc2025
PE
3968 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3969 (x_clipboard_manager_save_all): Move extern decl to ...
3970 * xterm.h: ... here, so that it can be checked for consistency.
3971
1dd3c2d9
CY
39722011-05-29 Chong Yidong <cyd@stupidchicken.com>
3973
3974 * xselect.c (x_clipboard_manager_save_frame)
3975 (x_clipboard_manager_save_all): New functions.
3976 (Fx_clipboard_manager_save): Lisp function deleted.
3977
3978 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3979 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3980
3981 * xterm.h: Update prototype.
3982
5ba6571d
WX
39832011-05-28 William Xu <william.xwl@gmail.com>
3984
3985 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3986 exiting (Bug#8239).
3987
3eaff834
JM
39882011-05-28 Jim Meyering <meyering@redhat.com>
3989
e1900994 3990 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3991 * fns.c (to_uchar): Define.
3992 (crypto_hash_function): Use it to convert some newly-signed
3993 variables to unsigned, to avoid sign-extension bugs. For example,
3994 without this change, (md5 "truc") would evaluate to
3995 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3996 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3997 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3998
0f6990a7
PE
39992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4000
4001 Integer overflow fixes.
c8a9ca5a 4002
08686060
PE
4003 * dbusbind.c: Serial number integer overflow fixes.
4004 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4005 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4006 to hold a serial number that is too large for a fixnum.
4007 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4008 Check for serial numbers out of range. Decode any serial number
59568bf0 4009 that was so large that it became a float. (Bug#8722)
08686060 4010
2d1fc3c7
PE
4011 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4012 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4013 Use XFASTINT rather than XUINT when numbers are nonnegative.
4014 (xd_append_arg, Fdbus_method_return_internal):
4015 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4016 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4017 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4018 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4019 (Bug#8722)
2d1fc3c7 4020
c8a9ca5a
PE
4021 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4022
519e1d69
PE
4023 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4024
30569699
PE
4025 ccl: add integer overflow checks
4026 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4027 (IN_INT_RANGE): New macros.
4028 (ccl_driver): Use them to check for integer overflow when
4029 decoding a CCL program. Many of the new checks are whether XINT (x)
4030 fits in int; it doesn't always, on 64-bit hosts. The new version
4031 doesn't catch all possible integer overflows, but it's an
847044ea 4032 improvement. (Bug#8719)
30569699 4033
c11285dc
PE
4034 * alloc.c (make_event_array): Use XINT, not XUINT.
4035 There's no need for unsigned here.
4036
fdccd48e
PE
4037 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4038 This follows up to the 2011-05-06 change that substituted uintptr_t
4039 for EMACS_INT. This case wasn't caught back then.
4040
37910ab2
PE
4041 Rework Fformat to avoid integer overflow issues.
4042 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4043 now (part of C89). Include <verify.h>.
4044 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4045 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4046 (Fformat): Avoid the prepass trying to compute sizes; it was only
4047 approximate and thus did not catch overflow reliably. Instead, walk
4048 through the format just once, formatting and computing sizes as we go,
4049 checking for integer overflow at every step, and allocating a larger
4050 buffer as needed. Keep track separately whether the format is
4051 multibyte. Keep only the most-recently calculated precision, rather
4052 than them all. Record whether each argument has been converted to
4053 string. Use EMACS_INT, not int, for byte and char and arg counts.
4054 Support field widths and precisions larger than INT_MAX. Avoid
4055 sprintf's undefined behavior with conversion specifications such as %#d
4056 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4057 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4058 formatting out-of-range floating point numbers with int
9173deec 4059 formats. (Bug#8668)
37910ab2 4060
2e6578fb
PE
4061 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4062
0ae6bdee
PE
4063 * data.c: Avoid integer truncation in expressions involving floats.
4064 * data.c: Include <intprops.h>.
4065 (arith_driver): When there's an integer overflow in an expression
4066 involving floating point, convert the integers to floating point
4067 so that the resulting value does not suffer from catastrophic
4068 integer truncation. For example, on a 64-bit host (* 4
4069 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4070 Do not rely on undefined behavior after integer overflow.
4071
de883a70
PE
4072 merge count_size_as_multibyte, parse_str_to_multibyte
4073 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4074 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4075 Check for integer overflow.
4076 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4077 since it's now a duplicate of the other. This is more of
4078 a character than a buffer op, so better that it's in character.c.
4079 * fns.c, print.c: Adjust to above changes.
4080
2ff916cb
PE
40812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4084
f1b54466
PE
40852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4086
fb1ac845
PE
4087 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4088 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4089 (x_clipboard_manager_save): Now static.
4090 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4091
f1b54466
PE
4092 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4093 (crypto_hash_function): Now static.
4094 Fix pointer signedness problems. Avoid unnecessary initializations.
4095
a9f737ee
CY
40962011-05-27 Chong Yidong <cyd@stupidchicken.com>
4097
4098 * termhooks.h (Vselection_alist): Make it terminal-local.
4099
4100 * terminal.c (create_terminal): Initialize it.
4101
4102 * xselect.c: Support for clipboard managers.
4103 (Vselection_alist): Move to termhooks.h as terminal-local var.
4104 (LOCAL_SELECTION): New macro.
4105 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4106 (symbol_to_x_atom): Remove gratuitous arg.
4107 (x_handle_selection_request, lisp_data_to_selection_data)
4108 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4109 (x_own_selection, x_get_local_selection, x_convert_selection):
4110 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4111 (some_frame_on_display): Delete unused function.
4112 (Fx_own_selection_internal, Fx_get_selection_internal)
4113 (Fx_disown_selection_internal, Fx_selection_owner_p)
4114 (Fx_selection_exists_p): New optional frame arg.
4115 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4116 (x_handle_selection_clear): Don't treat other terminals with the
4117 same keyboard specially. Use the terminal-local Vselection_alist.
4118 (x_clear_frame_selections): Use Frun_hook_with_args.
4119
4120 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4121
4122 * xterm.h: Add support for those atoms.
4123
e067f0c1
CY
41242011-05-26 Chong Yidong <cyd@stupidchicken.com>
4125
4126 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4127 (converted_selections, conversion_fail_tag): New global variables.
4128 (x_selection_request_lisp_error): Free the above.
4129 (x_get_local_selection): Remove unnecessary code.
4130 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4131 of converted selections stored in converted_selections.
4132 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4133 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4134 (x_convert_selection): New function.
4135 (x_handle_selection_event): Simplify.
4136 (x_get_foreign_selection): Don't ignore incoming requests while
4137 waiting for an answer; this will fail when we implement
4138 SAVE_TARGETS, and seems unnecessary anyway.
4139 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4140 (Vx_sent_selection_functions): Doc fix.
4141
0f4aebc0
LL
41422011-05-26 Leo Liu <sdl.web@gmail.com>
4143
4144 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4145
e61124cd
YM
41462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4147
4148 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4149
4150 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4151 for fringe update if it has periodic bitmap.
ac389d0c 4152 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4153 and fringe_bitmap_periodic_p.
4154
4155 * fringe.c (get_fringe_bitmap_data): New function.
4156 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4157 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4158 row. Mark glyph row for fringe update if periodicity changed.
4159
4160 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4161 for fringe update unless it has periodic bitmap.
4162
f16d9837
KH
41632011-05-25 Kenichi Handa <handa@m17n.org>
4164
4165 * xdisp.c (get_next_display_element): Set correct it->face_id for
4166 a static composition.
4167
e1b90ef6
LL
41682011-05-24 Leo Liu <sdl.web@gmail.com>
4169
4170 * deps.mk (fns.o):
4171 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4172
4173 * fns.c (crypto_hash_function, Fsha1): New function.
4174 (Fmd5): Use crypto_hash_function.
4175 (syms_of_fns): Add Ssha1.
4176
7400048f
PE
41772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4178
4179 * gnutls.c: Remove unused macros.
4180 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4181 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4182 Remove macros that are defined and never used.
4183 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4184
abb71cf4
CY
41852011-05-22 Chong Yidong <cyd@stupidchicken.com>
4186
4187 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4188 (Fx_get_selection_internal): Minor cleanup.
4189 (Fx_own_selection_internal): Rename arguments for consistency with
4190 select.el.
4191
6307db39
PE
41922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4193
4194 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4195
f3d4e0a4
CY
41962011-05-22 Chong Yidong <cyd@stupidchicken.com>
4197
4198 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4199
4d8ade89
YM
42002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4201
4202 * dispnew.c (scrolling_window): Don't exclude the case that the
4203 last enabled row in the desired matrix touches the bottom boundary.
4204
32078c8d
GM
42052011-05-21 Glenn Morris <rgm@gnu.org>
4206
4207 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4208 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4209 and add some more files.
32078c8d 4210
7285dc67
EZ
42112011-05-20 Eli Zaretskii <eliz@gnu.org>
4212
4213 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4214 report_file_error introduced by the change from 2011-05-07.
4215
89d1bd22
PE
42162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4217
4218 * systime.h (Time): Define only if emacs is defined.
4219 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4220 where the include path doesn't have X11/X.h by default. See
4221 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4222
e23640bb 42232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4224
4225 * composite.c (find_automatic_composition): Fix previous change.
4226
b9704ad9
GM
42272011-05-20 Glenn Morris <rgm@gnu.org>
4228
4229 * lisp.mk: New file, split from Makefile.in.
4230 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4231 (shortlisp): Remove.
4232 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4233
4a720484
GM
42342011-05-19 Glenn Morris <rgm@gnu.org>
4235
4236 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4237 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4238 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4239 (lisp): Set the order to that of loadup.el.
4240 (shortlisp): Make it a copy of $lisp.
4241 (SOME_MACHINE_LISP): Remove.
4242 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4243 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4244
a28d4396
KH
42452011-05-18 Kenichi Handa <handa@m17n.org>
4246
4247 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4248 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4249 (find_automatic_composition): Mostly rewrite for efficiency.
4250
a2b1fa8e
JB
42512011-05-18 Juanma Barranquero <lekktu@gmail.com>
4252
4253 * makefile.w32-in: Update dependencies.
4254
8e1f5610
CS
42552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4256
4257 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4258 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4259
7025ee00 42602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4261
cdfa6eab
PE
4262 Fix some integer overflow issues, such as string length overflow.
4263
06d6db33
PE
4264 * insdel.c (count_size_as_multibyte): Check for string overflow.
4265
2b4560a8
PE
4266 * character.c (lisp_string_width): Check for string overflow.
4267 Use EMACS_INT, not int, for string indexes and lengths; in
4268 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4269 the resulting string length overflows an EMACS_INT; instead,
4270 report a string overflow if no precision given. When checking for
4271 precision exhaustion, use a check that cannot possibly have
4272 integer overflow. (Bug#8675)
4273 * character.h (lisp_string_width): Adjust to new signature.
4274
cb93f9be
PE
4275 * alloc.c (string_overflow): New function.
4276 (Fmake_string): Use it. This doesn't change behavior, but saves
4277 a few bytes and will simplify future changes.
4278 * character.c (string_escape_byte8): Likewise.
4279 * lisp.h (string_overflow): New decl.
4280
1a1f3366
PE
4281 Fixups, following up to the user-interface timestamp change.
4282 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4283 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4284 * msdos.c (mouse_get_pos): Likewise.
4285 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4286 * w32gui.h (Time): Define by including "systime.h" rather than by
4287 declaring it ourselves. (Bug#8664)
4288
d4e3e4d3
PE
4289 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4290 * image.c (clear_image_cache): Likewise.
4291
f6a24d19
PE
4292 * term.c (term_mouse_position): Don't assume time_t wraparound.
4293
08dc5ae6
PE
4294 Be more systematic about user-interface timestamps.
4295 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4296 and sometimes 'EMACS_UINT', to represent these timestamps.
4297 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4298 This makes the code easier to follow, and makes it easier to catch
4299 integer overflow bugs such as Bug#8664.
4300 * frame.c (Fmouse_position, Fmouse_pixel_position):
4301 Use Time, not unsigned long, for user-interface timestamps.
4302 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4303 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4304 * keyboard.h (last_event_timestamp): Likewise.
4305 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4306 * menu.h (xmenu_show): Likewise.
4307 * term.c (term_mouse_position): Likewise.
4308 * termhooks.h (struct input_event.timestamp): Likewise.
4309 (struct terminal.mouse_position_hook): Likewise.
4310 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4311 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4312 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4313 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4314 what it was before.
4315 * menu.h, termhooks.h: Include "systime.h", for Time.
4316
8e55734a
PE
4317 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4318 Don't assume that the difference between two unsigned long values
4319 can fit into an integer. At this point, we know button_down_time
4320 <= event->timestamp, so the difference must be nonnegative, so
4321 there's no need to cast the result if double-click-time is
4322 nonnegative, as it should be; check that it's nonnegative, just in
4323 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4324 apart (about 25 days). (Bug#8664)
8e55734a 4325
841f1b75 4326 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4327 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4328
3e26f69c
PE
4329 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4330 that always fit in int. Use a sentinel instead of a counter, to
4331 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4332 * frame.h (struct frame): Use int for menu_bar_items_used
4333 instead of EMACS_INT, since it always fits in int.
3e26f69c 4334
5cc152c0
PE
4335 * menu.c (grow_menu_items): Check for int overflow.
4336
d89eb65e
PE
4337 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4338
5235bd3e
PE
4339 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4340 Before, the code was not consistent. These values cannot exceed
4341 2**31 - 1 so there's no need to make them unsigned.
4342 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4343 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4344 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4345 as modifiers.
4346 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4347
bc827e23
PE
4348 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4349 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4350 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4351 presumably because the widths might not match.
4352
78eb494e
PE
4353 * window.c (size_window): Avoid needless test at loop start.
4354
04f2d78b
CB
43552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4356
4357 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4358
d2fc7e3d 43592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4360
4361 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4362
d2fc7e3d 43632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4364
4365 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4366 `width' to `bar_area_x' and `bar_area_width', respectively.
4367 (x_scroll_run): Take account of fringe background extension.
4368
04f2d78b
CB
4369 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4370 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4371 `bar_area_width', respectively.
4372 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4373 background extension.
4374
79b70037
GM
43752011-05-10 Jim Meyering <meyering@redhat.com>
4376
4377 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4378
2f142cc5
JB
43792011-05-10 Juanma Barranquero <lekktu@gmail.com>
4380
4381 * image.c (Finit_image_library): Return t for built-in image types,
4382 like pbm and xbm. (Bug#8640)
4383
57679c86
AS
43842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4385
4386 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4387
888c9e86
EZ
43882011-05-07 Eli Zaretskii <eliz@gnu.org>
4389
b0512a1d
EZ
4390 * w32console.c (Fset_screen_color): Doc fix.
4391 (Fget_screen_color): New function.
4392 (syms_of_ntterm): Defsubr it.
4393
7285dc67
EZ
4394 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4395 unlink the temporary file if Fcall_process didn't create it in the
4396 first place.
4397 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4398 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4399 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4400 cue to call_process_cleanup not to close that handle.
4401
4d3fcc8e
BK
44022011-05-07 Ben Key <bkey76@gmail.com>
4403
4404 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4405 one of two shell specific rules, either bootstrap-temacs-CMD or
4406 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4407 to the previous implementation of the bootstrap-temacs rule.
4408 The bootstrap-temacs-CMD rule is similar to the previous
4409 implementation of the bootstrap-temacs rule except that it
4410 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4411 variable.
4412
4413 These changes, along with some changes to nt/configure.bat,
4414 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4415 earlier fix to add support for --cflags and --ldflags options
4416 that include quotes so that it works whether make uses cmd or
4417 sh as the shell.
4418
b4289b64
MA
44192011-05-06 Michael Albinus <michael.albinus@gmx.de>
4420
4421 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4422 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4423 is a constant.
4424 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4425 a string. Handle both cases.
4426 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4427 (Fdbus_register_method): Use Qinvalid_function.
4428
af4c0e28
JB
44292011-05-06 Juanma Barranquero <lekktu@gmail.com>
4430
4431 * makefile.w32-in: Update dependencies.
4432 (LISP_H): Add inttypes.h and stdin.h.
4433 (PROCESS_H): Add unistd.h.
4434
c51453d9
EZ
44352011-05-06 Eli Zaretskii <eliz@gnu.org>
4436
4437 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4438 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4439
8ff0ac3c 44402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4441
4c4b566b
PE
4442 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4443
aab2b9b5
PE
4444 * term.c (vfatal): Remove stray call to va_end.
4445 It's not needed and the C Standard doesn't allow it here anyway.
4446
c378da0b
PE
4447 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4448 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4449
288b08c7
PE
4450 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4451 bytes.
4452
e3601888
PE
4453 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4454
db6c0e74
PE
4455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4456
dd5963ea
PE
4457 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4458
88c9450f
PE
4459 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4460
2f9442b8
PE
4461 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4462
c032b5f8
PE
4463 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4464 * charset.c (Fdefine_charset_internal): Don't initialize
4465 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4466 32-bit int (Bug#8600).
a108c10b
PE
4467
4468 * lread.c (read_integer): Be more consistent with string-to-number.
4469 Use string_to_number to do the actual conversion; this avoids
4470 rounding errors and fixes some other screwups. Without this fix,
4471 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4472 (digit_to_number): Move earlier, for benefit of read_integer.
4473 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4474 not a digit in any supported base. (Bug#8602)
a108c10b 4475
ad5f9eea
PE
4476 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4477
aec1708a
PE
4478 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4479 to match comment at start of function. This also removes a
4480 GCC warning about overflow in a 32+64-bit port.
4481
47be4ab5
PE
4482 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4483
371cac43
PE
4484 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4485 Reported by Stefan Monnier in
4486 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4487 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4488 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4489
d01a7826
PE
4490 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4491 (EMACS_UINTPTR): Likewise, with uintptr_t.
4492
7fd47d5c
PE
4493 * lisp.h: Prefer 64-bit EMACS_INT if available.
4494 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4495 on 32-bit hosts that have 64-bit int, so that they can access
4496 large files.
122b0c86
PE
4497 However, temporarily disable this change unless the temporary
4498 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4499
8727937b
PE
4500 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4501
8ac068ac
PE
4502 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4503 This removes an assumption that EMACS_INT and long are the same
4504 width as pointers. The assumption is true for Emacs porting targets
4505 now, but we want to make other targets possible.
4506 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4507 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4508 In the rest of the code, change types of integers that hold casted
4509 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4510 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4511 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4512 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4513 No need to cast type when ORing.
4514 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4515 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4516 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4517 assume EMACS_INT is the same width as char *.
4518 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4519 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4520 Remove no-longer-needed casts.
4521 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4522 (xg_tool_bar_help_callback, xg_make_tool_item):
4523 Use EMACS_INTPTR to hold an integer
4524 that will be cast to void *; this can avoid a GCC warning
4525 if EMACS_INT is not the same width as void *.
4526 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4527 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4528 (current_message_1, set_message_1):
4529 Use a local to convert to proper width without a cast.
4530 * xmenu.c (dialog_selection_callback): Likewise.
4531
ede49d71
PE
4532 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4533 Also, don't assume VALBITS / RAND_BITS is less than 5,
4534 and don't rely on undefined behavior when shifting a 1 left into
4535 the sign bit.
4536 * lisp.h (get_random): Change signature to match.
4537
2f30ecd0
PE
4538 * lread.c (hash_string): Use size_t, not int, for hash computation.
4539 Normally we prefer signed values; but hashing is special, because
4540 it's better to use unsigned division on hash table sizes so that
4541 the remainder is nonnegative. Also, size_t is the natural width
4542 for hashing into memory. The previous code used 'int', which doesn't
4543 retain enough info to hash well into very large tables.
4544 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4545
2a866e7b
PE
4546 * dbusbind.c: Don't possibly lose pointer info when converting.
4547 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4548 Use XPNTR rather than XHASH, so that the high-order bits of
4549 the pointer aren't lost when converting through void *.
4550
51639eac
PE
4551 * eval.c (Fautoload): Don't double-shift a pointer.
4552
92394119
PE
4553 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4554
dbdb9a7c
JB
45552011-05-06 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * gnutls.c (DEF_GNUTLS_FN):
4558 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4559
db7a0b4f
AS
45602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4561
4562 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4563 marker. (Bug#8610)
4564
f7ff1b0f 45652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4566
4567 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4568 New version that can reserve upto 2GB of heap space.
4569
f7ff1b0f 45702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4571
4572 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4573
639c109b
TZ
45742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4575
4576 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4577 `gnutls_certificate_set_x509_key_file'.
4578
d2127135
JB
45792011-05-05 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4582 Update dependencies.
4583
e968f4f3
JB
45842011-05-04 Juanma Barranquero <lekktu@gmail.com>
4585
4586 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4587 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4588 Remove unused parameter `fildes'.
4589 * process.c (read_process_output, send_process): Don't pass it.
4590
84d358f0
JB
45912011-05-04 Juanma Barranquero <lekktu@gmail.com>
4592
4593 Fix previous change: the library cache is defined in w32.c.
4594 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4595 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4596
0898ca10
JB
45972011-05-04 Juanma Barranquero <lekktu@gmail.com>
4598
4599 Implement dynamic loading of GnuTLS on Windows.
4600
4601 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4602 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4603 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4604 Declare.
4605
4606 * gnutls.c (Qgnutls_dll): Define.
4607 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4608 (gnutls_*): Declare function pointers.
4609 (init_gnutls_functions): New function to initialize function pointers.
4610 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4611 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4612 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4613 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4614 (emacs_gnutls_write, emacs_gnutls_read)
4615 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4616 (Fgnutls_available_p): New function.
4617 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4618 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4619 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4620
4621 * image.c: Include w32.h.
4622 (Vimage_type_cache): Delete.
4623 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4624 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4625 (w32_delayed_load): Move to w32.c.
4626
4627 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4628
4629 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4630 (w32_delayed_load): Move from image.c. When loading a library, record
4631 its filename in the :loaded-from property of the library id.
4632 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4633 Initialize and staticpro them.
4634 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4635
4636 * process.c: Include lisp.h before w32.h, not after.
4637 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4638 instead of gnutls_record_check_pending.
4639
4640 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4641
ff4de4aa
TZ
46422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4643
4644 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4645 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4646 as passed in.
4647
abe95abb
JD
46482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4649
4650 * xterm.c (x_set_frame_alpha): Do not set property on anything
4651 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4652
e16e55d4
JB
46532011-05-02 Juanma Barranquero <lekktu@gmail.com>
4654
4655 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4656
bafcf6a5
JB
46572011-05-02 Juanma Barranquero <lekktu@gmail.com>
4658
4659 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4660 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4661 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4662 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4663 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4664 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4665 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4666 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4667 (Qgnutls_bootprop_callbacks_verify): Make static.
4668
e7a6747f
AS
46692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4670
19ed11ba
AS
4671 * callproc.c: Indentation fixup.
4672
e7a6747f 4673 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4674 (wait_for_termination, interruptible_wait_for_termination):
4675 Move after wait_for_termination_1.
e7a6747f 4676
1ef14cb4
LMI
46772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4678
4679 * sysdep.c (interruptible_wait_for_termination): New function
4680 which is like wait_for_termination, but allows keyboard
4681 interruptions.
4682
4683 * callproc.c (Fcall_process): Add (:file "file") as an option for
4684 the STDOUT buffer.
4685 (Fcall_process_region): Ditto.
4686
330d880c
EZ
46872011-04-30 Eli Zaretskii <eliz@gnu.org>
4688
8db90b73
EZ
4689 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4690 rather than `XVECTOR (FOO)->size'.
4691
330d880c
EZ
4692 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4693 inttypes.h, as a gnulib replacement is used if it not available in
4694 system headers.
4695
15cbd324
EZ
46962011-04-21 Eli Zaretskii <eliz@gnu.org>
4697
4698 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4699 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4700 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4701
4702 * coding.c (coding_alloc_by_realloc): Error out if destination
4703 will grow beyond MOST_POSITIVE_FIXNUM.
4704 (decode_coding_emacs_mule): Abort if there isn't enough place in
4705 charbuf for the composition carryover bytes. Reserve an extra
4706 space for up to 2 characters produced in a loop.
4707 (decode_coding_iso_2022): Abort if there isn't enough place in
4708 charbuf for the composition carryover bytes.
4709
47102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4711
ae940cca
EZ
4712 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4713 aborting when %lld or %lll format is passed.
4714 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4715 %llo or %llx format is passed. (Bug#8545)
4716
03ab8921
EZ
4717 * window.c (window_scroll_line_based): Use a marker instead of
4718 simple variables to record original value of point. (Bug#7952)
4719
afda1437
EZ
4720 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4721 produced by %s or %c overflows available buffer space. (Bug#8545)
4722
f76dee0c
PE
47232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4724
4725 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4726 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4727
fdc5744d
JB
47282011-04-28 Juanma Barranquero <lekktu@gmail.com>
4729
4730 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4731
638f053a
JB
47322011-04-28 Juanma Barranquero <lekktu@gmail.com>
4733
4734 * keyboard.c (Qdelayed_warnings_hook): Define.
4735 (command_loop_1): Run `delayed-warnings-hook'
4736 if Vdelayed_warnings_list is non-nil.
4737 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4738 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4739
d178f871
EZ
47402011-04-28 Eli Zaretskii <eliz@gnu.org>
4741
4742 * doprnt.c (doprnt): Don't return value smaller than the buffer
4743 size if the message was truncated. (Bug#8545).
4744
b124fd93
JB
47452011-04-28 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4748 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4749
e810457d
PE
47502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4751
4752 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4753
ea51cceb
JB
47542011-04-27 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * makefile.w32-in: Update dependencies.
4757
94dcfacf
EZ
47582011-04-27 Eli Zaretskii <eliz@gnu.org>
4759
4760 Improve `doprnt' and its usage. (Bug#8545)
4761 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4762 `format_end'. Remove support for %l as a conversion specifier.
4763 Don't use xrealloc. Improve diagnostics when the %l size modifier
4764 is used. Update the commentary.
4765
4766 * eval.c (verror): Simplify calculation of size_t.
4767
4768 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4769 messages.
4770
f61f41d7
PE
47712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4772
4773 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4774 change.
4775
96fb4434
PE
47762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4777
4778 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4779 This makes this file independent of the recent pseudovector change.
4780
671875da 47812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4782
69e9b5a3
PE
4783 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4784
b5f869a7 4785 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4786 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4787 Remove unused local.
c8926152 4788 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4789
841a1577 4790 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4791 GCC 4.6.0 optimizes based on type-based alias analysis.
4792 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4793 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4794 != &v->size, and therefore "v->size = 1; b->size = 2; return
4795 v->size;" must therefore return 1. This assumption is incorrect
4796 for Emacs, since it type-puns struct Lisp_Vector * with many other
4797 types. To fix this problem, this patch adds a new type struct
f904488f 4798 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4799 and pseudovectors, and helps optimizing compilers not get fooled
4800 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4801 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4802 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4803 the size member.
eab3844f
PE
4804 (XSETPVECTYPE): Rewrite in terms of new macro.
4805 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4806 This is a bit clearer, and further avoids the possibility of
4807 undesirable aliasing.
4808 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4809 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4810 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4811 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4812 (ASIZE): Now uses header.size rather than size.
4813 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4814 to avoid the hassle of writing XVECTOR (foo)->header.size.
4815 (struct vectorlike_header): New type.
eab3844f
PE
4816 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4817 object, to help avoid aliasing.
4818 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4819 (SUBRP): Likewise, since Lisp_Subr is a special case.
4820 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4821 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4822 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4823 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4824 changed to be "header.size" and "header.next".
4825 * buffer.h (struct buffer): Likewise.
4826 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4827 * frame.h (struct frame): Likewise.
4828 * process.h (struct Lisp_Process): Likewise.
4829 * termhooks.h (struct terminal): Likewise.
4830 * window.c (struct save_window_data, struct saved_window): Likewise.
4831 * window.h (struct window): Likewise.
4832 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4833 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4834 * buffer.c (init_buffer_once): Likewise.
4835 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4836 special case.
4837 * process.c (Fformat_network_address): Use local var for size,
4838 for brevity.
4839
0df1eac5
PE
4840 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4841
847ab9d1 4842 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4843 * data.c (atof): Remove decl; no longer used or needed.
4844 (digit_to_number): Move to lread.c.
4845 (Fstring_to_number): Use new string_to_number function, to be
4846 consistent with how the Lisp reader treats infinities and NaNs.
4847 Do not assume that floating-point numbers represent EMACS_INT
4848 without losing information; this is not true on most 64-bit hosts.
4849 Avoid double-rounding errors, by insisting on integers when
4850 parsing non-base-10 numbers, as the documentation specifies.
4851 * lisp.h (string_to_number): New decl, replacing ...
4852 (isfloat_string): Remove.
bc0a5c13 4853 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4854 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4855 appears to have been a coding error. Similarly, do not accept
4856 strings like +-1e0 as floating point numbers. Do not report
4857 overflow for integer overflows unless the base is not 10 which
4858 means we have no simple and reliable way to continue.
4859 Break out the floating-point parsing into a new
4860 function string_to_number, so that Fstring_to_number parses
4861 floating point numbers consistently with the Lisp reader.
04f2d78b 4862 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4863 (E_CHAR, EXP_INT): Remove, replacing with ...
4864 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4865 (string_to_number): New function, replacing isfloat_string.
4866 This function checks for valid syntax and produces the resulting
4867 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4868 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4869 so that overflow for non-base-10 numbers is reported only when
4870 there's no portable and simple way to convert to floating point.
452f4150 4871
67769ffc
PE
4872 * textprop.c (set_text_properties_1): Rewrite for clarity,
4873 and to avoid GCC warning about integer overflow.
4874
c20db43f
PE
4875 * intervals.h (struct interval): Use EMACS_INT for members
4876 where EMACS_UINT might cause problems. See
4877 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4878 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4879 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4880 All uses changed.
37aa2f85
PE
4881 (offset_intervals): Tell GCC not to worry about length overflow
4882 when negating a negative length.
c20db43f 4883
2538aa2f
PE
4884 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4885 (overrun_check_free): Likewise.
4886
f2d3008d
PE
4887 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4888 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4889 word size.
4890
ec8df744
PE
4891 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4892 (gnutls_make_error): Rename local to avoid shadowing.
4893 (gnutls_emacs_global_deinit): ifdef out; not used.
4894 (Fgnutls_boot): Use const for pointer to readonly storage.
4895 Comment out unused local. Fix pointer signedness problems.
4896
640ee02d
PE
4897 * lread.c (openp): Don't stuff size_t into an 'int'.
4898 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4899 about possible signed overflow.
4900
6048fb2a
PE
4901 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4902 (GDK_KEY_g): Don't define if already defined.
4903 (xg_prepare_tooltip): Avoid pointer signedness problem.
4904 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4905
fa3c87e1
PE
4906 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4907 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4908
2172544b
PE
4909 * xfns.c (Fx_window_property): Simplify a bit,
4910 to make a bit faster and to avoid GCC 4.6.0 warning.
4911 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4912
9b821a21
PE
4913 * fns.c (internal_equal): Don't assume size_t fits in int.
4914
3c616cfa
PE
4915 * alloc.c (compact_small_strings): Tighten assertion a little.
4916
c2982e87
PE
4917 Replace pEd with more-general pI, and fix some printf arg casts.
4918 * lisp.h (pI): New macro, generalizing old pEd macro to other
4919 conversion specifiers. For example, use "...%"pI"d..." rather
4920 than "...%"pEd"...".
4921 (pEd): Remove. All uses replaced with similar uses of pI.
4922 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4923 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4924 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4925 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4926 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4927 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4928 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4929 64-bit hosts.
4930 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4931 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4932 * print.c (safe_debug_print, print_object): Likewise.
4933 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4934 to int.
6f04d126
PE
4935 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4936 avoiding the 0 flag, which is not portable.
c2982e87
PE
4937 * process.c (Fmake_network_process): Use pI to avoid cast.
4938 * region-cache.c (pp_cache): Likewise.
4939 * xdisp.c (decode_mode_spec): Likewise.
4940 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4941 behavior on 64-bit hosts with printf arg.
6f04d126 4942 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4943 (x_stop_queuing_selection_requests): Likewise.
4944 (x_get_window_property): Don't truncate byte count to an 'int'
4945 when tracing.
0b432f21 4946
5e073ec7
PE
4947 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4948 here, since it parses constructs like leading '-' and spaces,
4949 which are not wanted; and it overflows with large numbers.
4950 Instead, simply match F[0-9]+, which is what is wanted anyway.
4951
36372bf9
PE
4952 * alloc.c: Remove unportable assumptions about struct layout.
4953 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4954 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4955 (allocate_vectorlike, make_pure_vector): Use the new macros,
4956 plus offsetof, to remove unportable assumptions about struct layout.
4957 These assumptions hold on all porting targets that I know of, but
4958 they are not guaranteed, they're easy to remove, and removing them
4959 makes further changes easier.
4960
0b432f21
PE
4961 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4962 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4963 (string_overrun_cookie): Now const. Use initializers that
4964 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4965 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4966 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4967 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4968 multiple of sizeof (EMACS_INT); it need not be, if
4969 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4970 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4971
895009e1
JB
49722011-04-26 Juanma Barranquero <lekktu@gmail.com>
4973
4974 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4975
6a7a1b0b
TZ
49762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4977
4978 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4979 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4980 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4981
841a1577 49822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4983
4984 * lisp.h (Qdebug): List symbol.
895009e1 4985 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4986 * keyboard.c (debug-on-event): New variable.
4987 (handle_user_signal): Break into debugger when debug-on-event
4988 matches the current signal symbol.
4989
f2d3ba6f
DN
49902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4991
4992 * alloc.c (check_sblock, check_string_bytes)
4993 (check_string_free_list): Convert to standard C.
4994
42ce4c63
TZ
49952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4996
4997 * w32.c (emacs_gnutls_push): Fix typo.
4998
825cd63c
EZ
49992011-04-25 Eli Zaretskii <eliz@gnu.org>
5000
fb11d64d
EZ
5001 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5002 "cast to pointer from integer of different size".
5003
825cd63c
EZ
5004 Improve doprnt and its use in verror. (Bug#8545)
5005 * doprnt.c (doprnt): Document the set of format control sequences
5006 supported by the function. Use SAFE_ALLOCA instead of always
5007 using `alloca'.
5008
5009 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5010 is one byte too soon. Don't use xrealloc; instead xfree and
5011 xmalloc anew.
5012
e061a11b
TZ
50132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5014
5015 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5016 callbacks stage.
5017
5018 * gnutls.c: Renamed global_initialized to
5019 gnutls_global_initialized. Added internals for the
5020 :verify-hostname-error, :verify-error, and :verify-flags
5021 parameters of `gnutls-boot' and documented those parameters in the
5022 docstring. Start callback support.
9173deec
JB
5023 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5024 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5025 on error. Return error code.
e061a11b
TZ
5026 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5027 (emacs_gnutls_read): Likewise.
5028 (Fgnutls_boot): Return handshake error code.
5029 (emacs_gnutls_handle_error): New function.
5030 (wsaerror_to_errno): Likewise.
5031
5032 * w32.h (emacs_gnutls_pull): Add prototype.
5033 (emacs_gnutls_push): Likewise.
5034
5035 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5036 (emacs_gnutls_push): Likewise.
5037
50382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5039
5040 * process.c (wait_reading_process_output): Check if GnuTLS
5041 buffered some data internally if no FDs are set for TLS
5042 connections.
5043
5044 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5045 (LIBS): Link to USER_LIBS.
5046 ($(BLD)/gnutls.$(0)): New target.
5047
fa6996bc
EZ
50482011-04-24 Eli Zaretskii <eliz@gnu.org>
5049
eb35682e
EZ
5050 * xdisp.c (handle_single_display_spec): Rename the
5051 display_replaced_before_p argument into display_replaced_p, to
5052 make it consistent with the commentary. Fix typos in the
5053 commentary.
5054
e2ad650c
EZ
5055 * textprop.c (syms_of_textprop): Remove dead code.
5056 (copy_text_properties): Delete obsolete commentary about an
5057 interface that was deleted long ago. Fix typos in the description
5058 of arguments.
5059
1b2de274
EZ
5060 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5061 to changes in oldXMenu/XMenu.h from 2011-04-16.
5062 <menu_help_message, prev_menu_help_message>: Constify.
5063 (IT_menu_make_room): menu->help_text is now `const char **';
5064 adjust.
5065
5066 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5067 to changes in oldXMenu/XMenu.h from 2011-04-16.
5068 (struct XMenu): Declare `help_text' `const char **'.
5069
5070 * xfaces.c <Qunspecified>: Make extern again.
5071
5072 * syntax.c: Include sys/types.h before including regex.h, as
5073 required by Posix.
5074
762b15be
EZ
5075 * doc.c (get_doc_string): Improve the format passed to `error'.
5076
5077 * doprnt.c (doprnt): Improve commentary.
5078
5079 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5080
5081 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5082 them with etags.
5083
f1052e5d
EZ
5084 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5085 changes in globals.h immediately force recompilation.
762b15be
EZ
5086 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5087 $(CURDIR)/s/ms-w32.h.
5088 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5089
fa6996bc
EZ
5090 * character.c (Fchar_direction): Function deleted.
5091 (syms_of_character): Don't defsubr it.
5092 <char-direction-table>: Deleted.
5093
e6c3da20
EZ
50942011-04-23 Eli Zaretskii <eliz@gnu.org>
5095
5096 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5097 * doprnt.c: Include limits.h.
5098 (SIZE_MAX): New macro.
04f2d78b
CB
5099 (doprnt): Return a size_t value. 2nd arg is now size_t.
5100 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5101 Improve overflow protection. Support `l' modifier for integer
5102 conversions. Support %l conversion. Don't assume an EMACS_INT
5103 argument for integer conversions and for %c.
5104
5105 * lisp.h (doprnt): Restore prototype.
5106
5107 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5108 $(SRC)/character.h.
5109
5110 * Makefile.in (base_obj): Add back doprnt.o.
5111
5112 * deps.mk (doprnt.o): Add back prerequisites.
5113 (callint.o): Depend on character.h.
5114
5115 * eval.c (internal_lisp_condition_case): Include the handler
5116 representation in the error message.
5117 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5118 when breaking from the loop.
5119
5120 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5121
5122 * callint.c (Fcall_interactively): When displaying error message
5123 about invalid control letter, pass the character's codepoint, not
5124 a pointer to its multibyte form. Improve display of the character
5125 in octal and display also its hex code.
5126
5127 * character.c (char_string): Use %x to display the (unsigned)
5128 codepoint of an invalid character, to avoid displaying a bogus
5129 negative value.
5130
5131 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5132 `error', not SYMBOL_NAME itself.
5133
5134 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5135 character arguments to `error'.
5136
5137 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5138 to `error' in error message about FINAL_CHAR argument. Make sure
5139 FINAL_CHAR is a character, and use %c when it is passed as
5140 argument to `error'.
5141
4ffd0d6b 51422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5143
5144 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5145
5146 * w32.c: Include <time.h>.
5147 (sys_localtime): New function.
5148
4ffd0d6b 51492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5150
5151 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5152
4ffd0d6b 5153 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5154
4ffd0d6b 51552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5156
4ffd0d6b
GM
5157 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5158 zombies (Bug#8467).
aac0c6e3 5159
04c56954
EZ
51602011-04-19 Eli Zaretskii <eliz@gnu.org>
5161
5162 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5163 gl_state.e_property when gl_state.object is Qt.
5164
5165 * insdel.c (make_gap_larger): Remove limitation of buffer size
5166 to <= INT_MAX.
5167
16a43933
CY
51682011-04-18 Chong Yidong <cyd@stupidchicken.com>
5169
5170 * xdisp.c (lookup_glyphless_char_display)
5171 (produce_glyphless_glyph): Handle cons cell entry in
5172 glyphless-char-display.
5173 (Vglyphless_char_display): Document it.
5174
5175 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5176 glyphless-char-display.
5177
4581706e
CY
51782011-04-17 Chong Yidong <cyd@stupidchicken.com>
5179
5180 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5181
5182 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5183
5184 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5185 definition for no-X builds.
5186
4887c6e2 51872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5188
fd35b6f9
PE
5189 Static checks with GCC 4.6.0 and non-default toolkits.
5190
5c1ccb01
PE
5191 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5192
006c5daa
PE
5193 * process.c (keyboard_bit_set): Define only if SIGIO.
5194 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5195 (send_process): Repair possible setjmp clobbering.
5196
efc736d3
PE
5197 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5198
4e2fe2e6
PE
5199 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5200
f97334a2
PE
5201 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5202
4e75f29d
PE
5203 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5204 Define only if needed.
5205
90efadd1
PE
5206 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5207 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5208 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5209
3c647824
PE
5210 * dispextern.h (struct redisplay_interface): Rename param
5211 to avoid shadowing.
e264f262 5212 * termhooks.h (struct terminal): Likewise.
761383f4 5213 * xterm.c (xembed_send_message): Likewise.
3c647824 5214
b58c5c4a
PE
5215 * insdel.c (make_gap_smaller): Define only if
5216 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5217
cad59032
PE
5218 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5219 it.
5220
c339dc2e
PE
5221 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5222 so that we aren't warned about unused symbols.
5223
91a3e27b
PE
5224 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5225
399c71d3 5226 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5227
8ffc96f5
PE
5228 * xfns.c (x_real_positions): Mark locals as initialized.
5229
eef9bc79
PE
5230 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5231
098db9dd
PE
5232 * xterm.c: Fix problems found by static analysis with other toolkits.
5233 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5234 (x_dispatch_event): Declare static if USE_GTK, and
5235 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5236 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5237 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5238 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5239 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5240
eb18f6cc
PE
5241 * xmenu.c (menu_help_callback): Pointer type fixes.
5242 Use const pointers when pointing at readonly data. Avoid pointer
5243 signedness clashes.
5244 (FALSE): Remove unused macro.
5245 (update_frame_menubar): Remove unused decl.
5246
1fe72bf8
PE
5247 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5248
60d9e1db
PE
5249 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5250 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5251 (single_menu_item): Rename local to avoid shadowing.
5252
39261c26
PE
5253 * keyboard.c (make_lispy_event): Remove unused local var.
5254
018c5e19
PE
5255 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5256 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5257
63d2b86e
PE
5258 * bitmaps: Change bitmaps from unsigned char back to the X11
5259 compatible char. Avoid the old compiler warnings about
5260 out-of-range initializers by using, for example, '\xab' rather
5261 than 0xab.
5262
aefd87e1
PE
5263 * xgselect.c (xgselect_initialize): Check vs interface
5264 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5265
bf501fb9
PE
5266 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5267
e9829fdf
PE
5268 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5269 to read-only memory.
5270
1086c095
PE
5271 * fns.c (vector): Remove; this old hack is no longer needed.
5272
2baccd04 5273 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5274 Remove unused var.
dde42981 5275 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5276
72391843 5277 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5278
436c16df 5279 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5280 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5281 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5282
92bb796d 5283 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5284 (x_term_init): Remove local to avoid shadowing.
92bb796d 5285
764430a3 5286 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5287
5288 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5289 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5290
d1dfb56c
EZ
52912011-04-16 Eli Zaretskii <eliz@gnu.org>
5292
c4354cb4
EZ
5293 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5294
d1dfb56c
EZ
5295 Fix regex.c, syntax.c and friends for buffers > 2GB.
5296 * syntax.h (struct gl_state_s): Declare character position members
5297 EMACS_INT.
5298
5299 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5300
04f2d78b
CB
5301 * textprop.c (verify_interval_modification, interval_of):
5302 Declare arguments EMACS_INT.
d1dfb56c
EZ
5303
5304 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5305 EMACS_INT.
5306
5307 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5308
5309 * indent.c (Fvertical_motion): Local variable it_start is now
5310 EMACS_INT.
5311
5312 * regex.c (re_match, re_match_2, re_match_2_internal)
5313 (bcmp_translate, regcomp, regexec, print_double_string)
5314 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5315 (re_compile_pattern, re_exec): Declare arguments and local
5316 variables `size_t' and `ssize_t' and return values `regoff_t', as
5317 appropriate.
5318 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5319 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5320 <compile_stack_type>: `size' and `avail' are now `size_t'.
5321
5322 * regex.h <regoff_t>: Use ssize_t, not int.
5323 (re_search, re_search_2, re_match, re_match_2): Arguments that
5324 specify buffer/string position and length are now ssize_t and
5325 size_t. Return type is regoff_t.
5326
613052cd
BK
53272011-04-16 Ben Key <bkey76@gmail.com>
5328
5329 * nsfont.m: Fixed bugs in ns_get_family and
5330 ns_descriptor_to_entity that were caused by using free to
5331 deallocate memory blocks that were allocated by xmalloc (via
5332 xstrdup). This caused Emacs to crash when compiled with
5333 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5334 --enable-checking=xmallocoverrun). xfree is now used to
5335 deallocate these memory blocks.
5336
4170f62f 53372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5338
71b41406
PE
5339 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5340
9587a89d
PE
5341 emacs_write: Accept and return EMACS_INT for sizes.
5342 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5343 et seq.
5344 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5345 Accept and return EMACS_INT.
5346 (emacs_gnutls_write): Return the number of bytes written on
5347 partial writes.
5348 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5349 (emacs_read, emacs_write): Remove check for negative size, as the
5350 Emacs source code has been audited now.
9587a89d
PE
5351 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5352 (emacs_read, emacs_write): Use it.
273a5f82
PE
5353 * process.c (send_process): Adjust to the new signatures of
5354 emacs_write and emacs_gnutls_write. Do not attempt to store
5355 a byte offset into an 'int'; it might overflow.
9587a89d 5356 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5357
3e047f51
PE
5358 * sound.c: Don't assume sizes fit in 'int'.
5359 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5360 Return EMACS_INT, not int.
3e047f51 5361 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5362 Accept EMACS_INT, not int.
5363 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5364 record read return values.
5365
cc39a9db
BK
53662011-04-15 Ben Key <bkey76@gmail.com>
5367
c9d0ec6d
JB
5368 * keyboard.c (Qundefined): Don't declare static since it is used
5369 in nsfns.m.
5370 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5371 static since they are used in nsfont.m.
cc39a9db 5372
6c60eb9f
SM
53732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * process.c (Qprocessp): Don't declare static.
5376 * lisp.h (Qprocessp): Declare again.
5377
7990b61a
JB
53782011-04-15 Juanma Barranquero <lekktu@gmail.com>
5379
5380 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5381
5d4cb038
PE
53822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5383
8bd7b830 5384 Improve C-level modularity by making more things 'static'.
cd64ea1d 5385
e3b27b31
PE
5386 Don't publish debugger-only interfaces to other modules.
5387 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5388 (verify_bytepos, count_markers): Move decls to the only modules
5389 that need them.
5390 * region-cache.h (pp_cache): Likewise.
5391 * window.h (check_all_windows): Likewise.
5392 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5393
5d4cb038
PE
5394 * sysdep.c (croak): Now static, if
5395 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5396 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5397
5398 * alloc.c (refill_memory_reserve): Now static if
5399 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5400 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5401
e87b6180
PE
5402 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5403 Define only if USE_LUCID.
5404
ac64929e
PE
5405 * xrdb.c (x_customization_string, x_rm_string): Now static.
5406
6f37259d
PE
5407 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5408 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5409
1683e3ab
PE
5410 * xdisp.c (draw_row_with_mouse_face): Now static.
5411 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5412
de9c2632
PE
5413 * window.h (check_all_windows): Mark externally visible.
5414
2b96acb7
PE
5415 * window.c (window_deletion_count): Now static.
5416
5417 * undo.c: Make symbols static if they're not exported.
5418 (last_undo_buffer, last_boundary_position, pending_boundary):
5419 Now static.
5420
50436f33
PE
5421 * textprop.c (interval_insert_behind_hooks): Now static.
5422 (interval_insert_in_front_hooks): Likewise.
5423
64520e5c
PE
5424 * term.c: Make symbols static if they're not exported.
5425 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5426 (max_frame_lines, tty_set_terminal_modes):
5427 (tty_reset_terminal_modes, tty_turn_off_highlight):
5428 (get_tty_terminal): Now static.
5429 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5430 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5431 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5432 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5433 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5434
1fa53021
PE
5435 * sysdep.c: Make symbols static if they're not exported.
5436 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5437 Now static.
5438 (sigprocmask_set, full_mask): Remove; unused.
5439 (wait_debugging): Mark as visible.
5440 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5441 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5442
d4b43b22
PE
5443 * syntax.c (syntax_temp): Define only if !__GNUC__.
5444
b7c513d0
PE
5445 * sound.c (current_sound_device, current_sound): Now static.
5446
989b29ad
PE
5447 * search.c (searchbufs, searchbuf_head): Now static.
5448
13a55a78
PE
5449 * scroll.c (scroll_cost): Remove; unused.
5450 * dispextern.h (scroll_cost): Remove decl.
5451
de68a1fc
PE
5452 * region-cache.h (pp_cache): Mark as externally visible.
5453
40ccffa6
PE
5454 * process.c: Make symbols static if they're not exported.
5455 (process_tick, update_tick, create_process, chan_process):
5456 (Vprocess_alist, proc_buffered_char, datagram_access):
5457 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5458 (deactivate_process): Mark defn as static, as well as decl.
5459 * lisp.h (create_process): Remove decl.
5460 * process.h (chan_process, Vprocess_alist): Remove decls.
5461
ad64fc97
PE
5462 * print.c: Make symbols static if they're not exported.
5463 (print_depth, new_backquote_output, being_printed, print_buffer):
5464 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5465 (print_interval, print_number_index, initial_stderr_stream):
5466 Now static.
5467 * lisp.h (Fprinc): Remove decl.
5468 (debug_output_compilation_hack): Mark as externally visible.
5469
adddb265
PE
5470 * sysdep.c (croak): Move decl from here to syssignal.h.
5471 * syssignal.h (croak): Put it here, so the API can be checked when
5472 'croak' is called from dissociate_if_controlling_tty.
5473
1717ede2
PE
5474 * minibuf.c: Make symbols static if they're not exported.
5475 (minibuf_save_list, choose_minibuf_frame): Now static.
5476 * lisp.h (choose_minibuf_frame): Remove decl.
5477
fa5fb2bc
PE
5478 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5479
1e3890d1
PE
5480 * lread.c: Make symbols static if they're not exported.
5481 (read_objects, initial_obarray, oblookup_last_bucket_number):
5482 Now static.
5483 (make_symbol): Remove; unused.
5484 * lisp.h (initial_obarray, make_symbol): Remove decls.
5485
8a1414fa
PE
5486 * keyboard.c: Make symbols static if they're not exported.
5487 (single_kboard, recent_keys_index, total_keys, recent_keys):
5488 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5489 (this_single_command_key_start, echoing, last_auto_save):
5490 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5491 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5492 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5493 (Vlispy_mouse_stem, double_click_count):
5494 Now static.
5495 (force_auto_save_soon): Define only if SIGDANGER.
5496 (ignore_mouse_drag_p): Now static if
5497 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5498 (print_help): Remove; unused.
5499 (stop_character, last_timer_event): Mark as externally visible.
5500 * keyboard.h (ignore_mouse_drag_p): Declare only if
5501 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5502 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5503 * lisp.h (echoing): Remove decl.
5504 (force_auto_save_soon): Declare only if SIGDANGER.
5505 * xdisp.c (redisplay_window): Simplify code, to make it more
5506 obvious that ignore_mouse_drag_p is not accessed if !defined
5507 USE_GTK && !defined HAVE_NS.
5508
93ea6e8f
PE
5509 * intervals.c: Make symbols static if they're not exported.
5510 (merge_properties_sticky, merge_interval_right, delete_interval):
5511 Now static.
5512 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5513
77382fcc
PE
5514 * insdel.c: Make symbols static if they're not exported.
5515 However, leave prepare_to_modify_buffer alone. It's never
5516 called from outside this function, but that appears to be a bug.
5517 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5518 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5519 (adjust_after_replace_noundo): Remove; unused.
5520 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5521 (signal_before_change): Remove decls.
77382fcc 5522
9306c32e
PE
5523 * indent.c (val_compute_motion, val_vmotion): Now static.
5524
cd44d2eb
PE
5525 * image.c: Make symbols static if they're not exported.
5526 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5527 if USE_GTK.
5528 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5529 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5530
ad9a7a06
PE
5531 * fringe.c (standard_bitmaps): Now static.
5532 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5533
81626931
PE
5534 * frame.c: Make symbols static if they're not exported.
5535 (x_report_frame_params, make_terminal_frame): Now static.
5536 (get_frame_param): Now static, unless HAVE_NS.
5537 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5538 (x_get_resource_string): Remove; not used.
5539 * frame.h (make_terminal_frame, x_report_frame_params):
5540 (x_get_resource_string); Remove decls.
5541 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5542 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5543
239f9db9
PE
5544 * font.c, fontset.c: Make symbols static if they're not exported.
5545 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5546 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5547 * font.c (font_close_object): Now static.
5548 * font.h (font_close_object): Remove.
5549 * fontset.c (FONTSET_OBJLIST): Remove.
5550 (free_realized_fontset) #if-0 the body, which does nothing.
5551 (face_suitable_for_char_p): #if-0, as it's never called.
5552 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5553 * xfaces.c (face_at_string_position):
5554 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5555 since 0 is always ASCII.
5556
dfcf3579
PE
5557 * fns.c (weak_hash_tables): Now static.
5558
5045092b
PE
5559 * fileio.c: Make symbols static if they're not exported.
5560 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5561 (Vwrite_region_annotation_buffers): Now static.
5562
57a96f5c
PE
5563 * eval.c: Make symbols static if they're not exported.
5564 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5565 * lisp.h (backtrace_list): Remove decl.
5566
35f08c38
PE
5567 * emacs.c: Make symbols static if they're not exported.
5568 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5569 (fatal_error_code, fatal_error_signal_hook, standard_args):
5570 Now static.
5571 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5572 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5573 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5574 * lisp.h (fatal_error_signal_hook): Remove decl.
5575 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5576
f44bd759
PE
5577 * editfns.c: Move a (normally-unused) function to its only use.
5578 * editfns.c, lisp.h (get_operating_system_release): Remove.
5579 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5580 worth the hassle of breaking this out.
5581
b532497d
PE
5582 * xterm.c: Make symbols static if they're not exported.
5583 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5584 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5585 (x_destroy_window, x_delete_display):
5586 Now static.
5587 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5588 (x_mouse_leave): Remove; unused.
5589 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5590 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5591 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5592 Remove decls.
5593 (x_mouse_leave): Declare only if WINDOWSNT.
5594 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5595 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5596 USE_X_TOOLKIT.
5597
1675728f
PE
5598 * ftxfont.c: Make symbols static if they're not exported.
5599 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5600 HAVE_FREETYPE.
5601 * font.h (ftxfont_driver): Likewise.
5602
e4cebfca
PE
5603 * xfns.c: Make symbols static if they're not exported.
5604 (x_last_font_name, x_display_info_for_name):
5605 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5606 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5607 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5608 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5609 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5610 (last_show_tip_args): Now static.
5611 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5612 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5613 (x_screen_planes): Remove; unused.
5614 * dispextern.h (x_screen_planes): Remove decl.
5615
5bf46f05
PE
5616 * dispnew.c: Make symbols static if they're not exported.
5617 * dispextern.h (redraw_garbaged_frames, scrolling):
5618 (increment_row_positions): Remove.
5619 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5620 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5621 Now static.
5622 (redraw_garbaged_frames): Remove; unused.
5623
435f4c28
PE
5624 * xfaces.c: Make symbols static if they're not exported.
5625 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5626 Remove decls.
5627 * xterm.h (defined_color): Remove decls.
5628 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5629 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5630 (menu_face_changed_default, defined_color, free_realized_face):
5631 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5632 (ascii_face_of_lisp_face): Remove; unused.
5633
8524aef3
PE
5634 * xdisp.c: Make symbols static if they're not exported.
5635 * dispextern.h (scratch_glyph_row, window_box_edges):
5636 (glyph_to_pixel_coords, set_cursor_from_row):
5637 (get_next_display_element, set_iterator_to_next):
5638 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5639 (show_mouse_face): Remove decls
5640 * frame.h (message_buf_print): Likewise.
5641 * lisp.h (pop_message, set_message, check_point_in_composition):
5642 Likewise.
5643 * xterm.h (set_vertical_scroll_bar): Likewise.
5644 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5645 (message_buf_print, scratch_glyph_row, displayed_buffer):
5646 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5647 (get_next_display_element, show_mouse_face, window_box_edges):
5648 (frame_to_window_pixel_xy, check_point_in_composition):
5649 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5650 (glyph_to_pixel_coords): Remove; unused.
5651
16390cd2
PE
5652 * dired.c (file_name_completion): Now static.
5653
5654 * dbusbind.c (xd_in_read_queued_messages): Now static.
5655
a25f4dfa
PE
5656 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5657 * data.c (circular_list_error): Remove.
5658
14a9c8df
PE
5659 * commands.h (last_point_position, last_point_position_buffer):
5660 (last_point_position_window): Remove decls.
5661 * keyboard.c: Make these variables static.
5662
04f2d78b
CB
5663 * coding.h (coding, code_convert_region, encode_coding_gap):
5664 Remove decls.
74ab6df5
PE
5665 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5666 (iso_code_class, detect_coding, code_convert_region): Now static.
5667 (encode_coding_gap): Remove; unused.
5668
38dfbee1
PE
5669 * chartab.c (chartab_chars, chartab_bits): Now static.
5670
a2cb4e63
PE
5671 * charset.h (charset_iso_8859_1): Remove decl.
5672 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5673 Now static.
5674
127198fd
PE
5675 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5676 * ccl.c (Vccl_program_table): Now static.
5677 (check_ccl_update): Remove; unused.
5678
d85b608f
PE
5679 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5680 * category.h: ... from here.
5681 * category.c (check_category_table, set_category_set): Now static.
5682
31cd66f3
PE
5683 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5684 * lisp.h: Remove these decls.
5685
c358e587
PE
5686 * buffer.c (buffer_count): Remove unused var.
5687
e78aecca
PE
5688 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5689 so that it's not optimized away.
5690 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5691 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5692 exported only to the debugger.
5693
e192d7d3 5694 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5695 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5696
92470028
PE
5697 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5698 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5699 was inaccessible from Lisp.
5700 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5701 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5702
244ed907
PE
5703 alloc.c: Import and export fewer symbols, and remove unused items.
5704 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5705 is defined.
5706 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5707 it's not optimized away by whole-program optimization.
5708 (message_enable_multibyte, free_misc): Remove.
5709 (catchlist, handlerlist, mark_backtrace):
5710 Declare only if BYTE_MARK_STACK.
5711 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5712 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5713 (message_enable_multibyte): Remove decl.
5714 (free_misc, interval_free_list, float_block, float_block_index):
5715 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5716 (cons_free_list, last_marked_index):
5717 Now static.
5718 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5719 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5720 (mark_backtrace): Define only if BYTE_MARK_STACK.
5721 * xdisp.c (message_enable_multibyte): Now static.
5722
61c2b50e 5723 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5724 This makes it easier for human readers (and static analyzers)
5725 to see whether these variables are used from other modules.
5726 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5727 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5728 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5729 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5730 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5731 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5732 * xmenu.c, xselect.c:
5733 Declare Q* vars static if they are not used in other modules.
5734 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5735 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5736 Remove decls of unexported vars.
5737 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5738
95c82688
PE
5739 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5740
16a97296
PE
5741 Make Emacs functions such as Fatom 'static' by default.
5742 This makes it easier for human readers (and static analyzers)
5743 to see whether these functions can be called from other modules.
5744 DEFUN now defines a static function. To make the function external
5745 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5746 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5747 (Finit_image_library):
16a97296
PE
5748 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5749 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5750 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5751 Remove decls, since these functions are now static.
5752 (Funintern, Fget_internal_run_time): New decls, since these functions
5753 were already external.
95c82688 5754
16a97296
PE
5755 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5756 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5757 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5758 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5759 * keyboard.c, keymap.c, lread.c:
5760 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5761 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5762 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5763 Mark functions with DEFUE instead of DEFUN,
5764 if they are used in other modules.
5765 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5766 decls for now-static functions.
5767 * buffer.h (Fdelete_overlay): Remove decl.
5768 * callproc.c (Fgetenv_internal): Mark as internal.
5769 * composite.c (Fremove_list_of_text_properties): Remove decl.
5770 (Fcomposition_get_gstring): New forward static decl.
5771 * composite.h (Fcomposite_get_gstring): Remove decl.
5772 * dired.c (Ffile_attributes): New forward static decl.
5773 * doc.c (Fdocumntation_property): New forward static decl.
5774 * eval.c (Ffetch_bytecode): New forward static decl.
5775 (Funintern): Remove extern decl; now in .h file where it belongs.
5776 * fileio.c (Fmake_symbolic_link): New forward static decl.
5777 * image.c (Finit_image_library): New forward static decl.
5778 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5779 * intervals.h (Fprevious_property_change):
5780 (Fremove_list_of_text_properties): Remove decls.
5781 * keyboard.c (Fthis_command_keys): Remove decl.
5782 (Fcommand_execute): New forward static decl.
5783 * keymap.c (Flookup_key): New forward static decl.
5784 (Fcopy_keymap): Now static.
5785 * keymap.h (Flookup_key): Remove decl.
5786 * process.c (Fget_process): New forward static decl.
5787 (Fprocess_datagram_address): Mark as internal.
5788 * syntax.c (Fsyntax_table_p): New forward static decl.
5789 (skip_chars): Remove duplicate decl.
5790 * textprop.c (Fprevious_property_change): New forward static decl.
5791 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5792 Now internal.
5793 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5794 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5795
785bbd42
PE
5796 * editfns.c (Fformat): Remove unreachable code.
5797
8b913b57
AS
57982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5799
5800 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5801 change. (Bug#8496)
5802
a6744a35
EZ
58032011-04-13 Eli Zaretskii <eliz@gnu.org>
5804
5805 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5806 when at ZV. (Bug#8487)
5807
e7974947
AS
58082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5809
baad03f0
AS
5810 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5811 (Bug#8437)
5812 * keyboard.c (parse_tool_bar_item): Likewise.
5813 * sound.c (sound_cleanup, alsa_close): Likewise.
5814 * termcap.c (tgetent): Likewise.
5815 * xfns.c (x_default_font_parameter): Likewise.
5816 * xsettings.c (read_and_apply_settings): Likewise.
5817
e7974947
AS
5818 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5819 (overrun_check_free): Protoize.
5820
28272684
PE
58212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5822
5823 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5824 since callers should never pass a negative size.
5825 Change the signature to match that of plain 'read' and 'write'; see
5826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5827 * lisp.h: Update prototypes of emacs_write and emacs_read.
5828
11997c76
EZ
58292011-04-11 Eli Zaretskii <eliz@gnu.org>
5830
5831 * xdisp.c (redisplay_window): Don't try to determine the character
5832 position of the scroll margin if the window start point w->startp
e896f03c 5833 is outside the buffer's accessible region. (Bug#8468)
11997c76 5834
8a2cbd72
EZ
58352011-04-10 Eli Zaretskii <eliz@gnu.org>
5836
5837 Fix write-region and its subroutines for buffers > 2GB.
5838 * fileio.c (a_write, e_write): Modify declaration of arguments and
5839 local variables to support buffers larger than 2GB.
5840 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5841
5842 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5843 argument, local variables, and return value.
5844
5845 * lisp.h: Update prototypes of emacs_write and emacs_read.
5846
5847 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5848
4073e537 58492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5850
1ebfdcb6
PE
5851 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5852
b2ded58d
PE
5853 Fix more problems found by GCC 4.6.0's static checks.
5854
7d66342c
PE
5855 * xdisp.c (vmessage): Use a better test for character truncation.
5856
bbf47d44
PE
5857 * charset.c (load_charset_map): <, not <=, for optimization,
5858 and to avoid potential problems with integer overflow.
9248994d 5859 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5860 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5861 * editfns.c (Fformat): Likewise.
1e69125e 5862 * syntax.c (skip_chars): Likewise.
3befa583 5863
e3019616
PE
5864 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5865 This also lets GCC 4.6.0 generate slightly better loop code.
5866
becfa255
PE
5867 * callint.c (Fcall_interactively): <, not <=, for optimization.
5868 (Fcall_interactively): Count the number of arguments produced,
5869 not the number of arguments given. This is simpler and lets GCC
5870 4.6.0 generate slightly better code.
5871
dae0cd48
PE
5872 * ftfont.c: Distingish more carefully between FcChar8 and char.
5873 The previous code passed unsigned char * to a functions like
5874 strlen and xstrcasecmp that expect char *, which does not
5875 conform to the C standard.
5876 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5877 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5878 char * when the C standard requires it.
5879
76032d70
PE
5880 * keyboard.c (read_char): Remove unused var.
5881
eb3f1cc8
PE
5882 * eval.c: Port to Windows vsnprintf (Bug#8435).
5883 Include <limits.h>.
5884 (SIZE_MAX): Define if the headers do not.
5885 (verror): Do not give up if vsnprintf returns a negative count.
5886 Instead, grow the buffer. This ports to Windows vsnprintf, which
5887 does not conform to C99. Problem reported by Eli Zaretskii.
5888 Also, simplify the allocation scheme, by avoiding the need for
5889 calling realloc, and removing the ALLOCATED variable.
5890
70476b54
PE
5891 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5892
12020a9e
PE
5893 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5894 But keep the doprint source code for now, as we might revamp it
5895 and use it again (Bug#8435).
ea6c7ae6
PE
5896 * lisp.h (doprnt): Remove.
5897 * Makefile.in (base_obj): Remove doprnt.o.
5898 * deps.mk (doprnt.o): Remove.
5899
5fdb398c
PE
5900 error: Print 32- and 64-bit integers portably (Bug#8435).
5901 Without this change, on typical 64-bit hosts error ("...%d...", N)
5902 was used to print both 32- and 64-bit integers N, which relied on
5903 undefined behavior.
5904 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5905 New macro.
5906 * lisp.h (error, verror): Mark as printf-like functions.
5907 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5908 Report overflow in size calculations when allocating printf buffer.
5909 Do not truncate output string at its first null byte.
5910 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5911 Truncate the output at a character boundary, since vsnprintf does not
5912 do that.
5913 * charset.c (check_iso_charset_parameter): Convert internal
5914 character to string before calling 'error', since %c now has the
5915 printf meaning.
5916 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5917 overflow when computing char to be passed to 'error'. Do not
5918 pass Lisp_Object to 'error'; pass the integer instead.
5919 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5920 formatted with plain %d.
5921
b189fa66
PE
5922 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5923
bff87ef0
PE
5924 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5925
7e2cac20
PE
5926 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5927
ce4d90b5
PE
5928 * xterm.c (x_catch_errors): Remove duplicate declaration.
5929
266c9547
PE
5930 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5931
79c49ad2
PE
5932 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5933
368f4090
JM
59342011-04-10 Jim Meyering <meyering@redhat.com>
5935
5936 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5937 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5938 return ssize_t not "int", and use size_t as the buffer length.
5939 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5940 * gnutls.h: Update declarations.
5941 * process.c (read_process_output): Use ssize_t, to match.
5942 (send_process): Likewise.
5943
a32d4040
CY
59442011-04-09 Chong Yidong <cyd@stupidchicken.com>
5945
5946 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5947
8546720e 59482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5949
04f2d78b
CB
5950 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5951 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5952
8546720e
GM
5953 * xterm.c (handle_one_xevent):
5954 * xmenu.c (create_and_show_popup_menu):
5955 * xselect.c (x_decline_selection_request)
5956 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5957
0a2f5c1a 59582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5959
5960 Fix some uses of `int' instead of EMACS_INT.
5961 * search.c (string_match_1, fast_string_match)
5962 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5963 (scan_buffer, find_next_newline_no_quit)
5964 (find_before_next_newline, search_command, Freplace_match)
5965 (Fmatch_data): Make some `int' variables be EMACS_INT.
5966
5967 * xdisp.c (display_count_lines): 3rd argument and return value now
5968 EMACS_INT. All callers changed.
5969 (pint2hrstr): Last argument is now EMACS_INT.
5970
5971 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5972 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5973 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5974 (decode_coding_utf_16, decode_coding_emacs_mule)
5975 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5976 (decode_coding_ccl, decode_coding_charset)
5977 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5978 (decode_coding_iso_2022, decode_coding_emacs_mule)
5979 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5980 <char_offset, last_offset>: Declare EMACS_INT.
5981 (encode_coding_utf_8, encode_coding_utf_16)
5982 (encode_coding_emacs_mule, encode_invocation_designation)
5983 (encode_designation_at_bol, encode_coding_iso_2022)
5984 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5985 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5986 Declare EMACS_INT.
5987 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5988 (encode_invocation_designation): Last argument P_NCHARS is now
5989 EMACS_INT.
5990 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5991 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5992
5993 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5994 All users changed.
5995
5996 * ccl.c (Fccl_execute_on_string): Declare some variables
5997 EMACS_INT.
5998
8546720e 59992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6000
6001 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6002
4e19a977
CS
60032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6004
6005 * process.c (Fformat_network_address): Doc fix.
6006
87302331
R
60072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6008
6009 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6010
cbb59342
CY
60112011-04-08 Chong Yidong <cyd@stupidchicken.com>
6012
6013 * keyboard.c (read_char): Call Lisp function help-form-show,
6014 instead of using internal_with_output_to_temp_buffer.
6015 (Qhelp_form_show): New var.
e0d38eeb 6016 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6017
6018 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6019
6020 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6021
e67a13ab
CY
60222011-04-06 Chong Yidong <cyd@stupidchicken.com>
6023
04f2d78b
CB
6024 * process.c (Flist_processes): Remove to Lisp.
6025 (list_processes_1): Delete.
e67a13ab 6026
973f782d
EZ
60272011-04-06 Eli Zaretskii <eliz@gnu.org>
6028
7c106b1e
EZ
6029 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6030
973f782d
EZ
6031 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6032
41cf7d1a 60332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6034
ca23cc88
PE
6035 Fix more problems found by GCC 4.6.0's static checks.
6036
f390e2d5
PE
6037 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6038
42eea0d0
PE
6039 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6040
b69769da 6041 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6042
f9541e84
PE
6043 * xdisp.c (vmessage): Mark as a printf-like function.
6044
13841b55
PE
6045 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6046
c136c10f
PE
6047 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6048
5e2d4a30
PE
6049 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6050 printf-like functions.
6051 (tiff_load): Add casts to remove these marks before passing them
6052 to system-supplied API.
6053
583f48b9
PE
6054 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6055
b25d760e
PE
6056 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6057 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6058 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6059 directly, rather than having caller test rule sign. This avoids
6060 some unnecessary tests.
6061 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6062 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6063 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6064
bc7b6697 6065 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6066 (xfont_open): Avoid unnecessary tests.
bc7b6697 6067
27ccc379
PE
6068 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6069
dcd5c89a
PE
6070 * composite.h, composite.c (composition_gstring_put_cache):
6071 Use EMACS_INT, not int, for length.
6072
b13a45c6
PE
6073 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6074 breaking out part of COMPOSITION_DECODE_RULE.
6075 (COMPOSITION_DECODE_RULE): Use it.
6076 * composite.c (get_composition_id): Remove unused local vars,
6077 by using the new macro.
6078
1e792e4d
PE
6079 * textprop.c (set_text_properties_1): Change while to do-while,
6080 since the condition is always true at first.
6081
dc6c6455 6082 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6083 (interval_deletion_adjustment): Return unsigned value.
6084 All uses changed.
dc6c6455 6085
aba7731a
PE
6086 * process.c (list_processes_1, create_pty, read_process_output):
6087 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6088 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6089 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6090 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6091 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6092
fdfc4bf3
PE
6093 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6094
fca8fe46 6095 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6096 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6097
06a0259a 6098 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6099 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6100 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6101
e7b9e80f
PE
6102 * print.c (print_error_message): Avoid int overflow.
6103
56201685
PE
6104 * font.c (font_list_entities): Redo for clarity,
6105 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6106
78834453 6107 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6108 (font_score): Avoid potential overflow in diff calculation.
78834453 6109
0bc0b309 6110 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6111 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6112
e610eaca
PE
6113 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6114
b895abce
PE
6115 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6116 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6117 can always succeed if overflow has undefined behavior.
6118
1f1d9321 6119 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6120 (wordify): Omit three unnecessary tests.
1f1d9321 6121
c59478bc
PE
6122 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6123 All callers changed. This avoids the need for an unused var.
6124
79b73827
PE
6125 * casefiddle.c (casify_region): Remove var that is set but not used.
6126
a4db5dfe
PE
6127 * dired.c (file_name_completion): Remove var that is set but not used.
6128
43aae36e
PE
6129 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6130
2a47c44d 6131 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6132 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6133
a37c69bf
PE
6134 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6135 Check for integer overflow on size calculations.
6136
328ab8e7
PE
6137 * buffer.c (Fprevious_overlay_change): Remove var that is set
6138 but not used.
6139
e5a2a5cb
PE
6140 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6141 Remove vars that are set but not used.
8d84a6eb 6142 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6143 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6144
a60e5f68
PE
6145 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6146
f661cb61 6147 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6148 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6149
f0397f5a
PE
6150 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6151 that are set but not used.
6152
8664db06 6153 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6154 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6155
6abdaa4a
PE
6156 * xselect.c (x_get_local_selection, x_handle_property_notify):
6157 Remove vars that are set but not used.
6158
0ce7538d 6159 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6160 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6161
9ae848fc
PE
6162 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6163 Remove var that is set but not used.
0b918413
PE
6164 (scroll_bar_windows_size): Now size_t, not int.
6165 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6166 Check for overflow.
9ae848fc 6167
a5a62657
PE
6168 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6169 (map_tty_color) [!defined MSDOS]: Likewise.
6170
5c5cdd39
PE
6171 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6172
66ebf983
PE
6173 * coding.c: Remove vars that are set but not used.
6174 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6175 All callers changed.
6176 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6177 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6178 (decode_coding_charset): Remove vars that are set but not used.
6179
1be4d761
PE
6180 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6181 that is set but not used.
6182
47553fa8
PE
6183 * print.c (print_object): Remove var that is set but not used.
6184
1f7196bf 6185 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6186 The gnulib version avoids calling malloc in the usual case,
6187 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6188 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6189 * filelock.c (current_lock_owner): Likewise.
6190 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6191 * sysdep.c: Include allocator.h, careadlinkat.h.
6192 (emacs_no_realloc_allocator): New static constant.
6193 (emacs_readlink): New function.
fdb61804
PE
6194 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6195 ../lib/careadlinkat.h.
d1fdcab7 6196
f84c17c7
SM
61972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6198
6199 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6200 first non-nil return value).
6201
ef3862ad
JD
62022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6203
6204 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6205 if not defined (Bug#8403).
6206
376a7006
JB
62072011-04-02 Juanma Barranquero <lekktu@gmail.com>
6208
6209 * xdisp.c (display_count_lines): Remove parameter `start',
6210 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6211 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6212 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6213 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6214 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6215 and thereabouts. All callers changed.
6216 (get_per_char_metric): Remove parameter `f', unused since
6217 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6218
6ca3801d
JM
62192011-04-02 Jim Meyering <meyering@redhat.com>
6220
6221 do not dereference NULL upon failed strdup
6222 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6223 (ns_get_family): Likewise.
6224
d8e2b5ba
JB
62252011-04-02 Juanma Barranquero <lekktu@gmail.com>
6226
6227 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6228
8c74fcbd
JD
62292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6230
6231 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6232 later (Bug#8403).
6233
7200d79c
SM
62342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6235
03408648 6236 Add lexical binding.
7200d79c 6237
03408648
SM
6238 * window.c (Ftemp_output_buffer_show): New fun.
6239 (Fsave_window_excursion):
6240 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6241
6242 * lread.c (lisp_file_lexically_bound_p): New function.
6243 (Fload): Bind Qlexical_binding.
6244 (readevalloop): Remove `evalfun' arg.
6245 Bind Qinternal_interpreter_environment.
6246 (Feval_buffer): Bind Qlexical_binding.
6247 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6248 Mark as dynamic.
6249 (syms_of_lread): Declare `lexical-binding'.
6250
6251 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6252
6253 * keyboard.c (eval_dyn): New fun.
6254 (menu_item_eval_property): Use it.
ca105506
SM
6255
6256 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6257
03408648
SM
6258 * fns.c (concat, mapcar1): Accept byte-code-functions.
6259
6260 * eval.c (Fsetq): Handle lexical vars.
6261 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6262 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6263 (FletX, Flet): Obey lexical binding.
6264 (Fcommandp): Handle closures.
6265 (Feval): New `lexical' arg.
6266 (eval_sub): New function extracted from Feval. Use it almost
6267 everywhere where Feval was used. Look up vars in lexical env.
6268 Handle closures.
6269 (Ffunctionp): Move from subr.el.
6270 (Ffuncall): Handle closures.
6271 (apply_lambda): Remove `eval_flags'.
6272 (funcall_lambda): Handle closures and new byte-code-functions.
6273 (Fspecial_variable_p): New function.
6274 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6275 but without exporting it to Lisp.
23aba0ea 6276
23aba0ea 6277 * doc.c (Fdocumentation, store_function_docstring):
03408648 6278 * data.c (Finteractive_form): Handle closures.
23aba0ea 6279
03408648
SM
6280 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6281 interactive spec.
ba83908c 6282
04f2d78b
CB
6283 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6284 New byte-codes.
03408648
SM
6285 (exec_byte_code): New function extracted from Fbyte_code to handle new
6286 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6287
03408648 6288 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6289
03408648 6290 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6291
e2abce01
JB
62922011-03-31 Juanma Barranquero <lekktu@gmail.com>
6293
6294 * xdisp.c (redisplay_internal): Fix prototype.
6295
63696a73 62962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6297
63696a73 6298 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6299 (try_scrolling): Use it when setting scroll_limit.
6300 Limit scrolling to 100 screen lines.
63696a73
EZ
6301 (redisplay_window): Even when falling back on "recentering",
6302 position point in the window according to scroll-conservatively,
6303 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6304
6305 (try_scrolling): When point is above the window, allow searching
6306 as far as scroll_max, or one screenful, to compute vertical
6307 distance from PT to the scroll margin position. This prevents
6308 try_scrolling from unnecessarily failing when
6309 scroll-conservatively is set to a value slightly larger than the
6310 window height. Clean up the case of PT below the margin at bottom
6311 of window: scroll_max can no longer be INT_MAX. When aggressive
6312 scrolling is in use, don't let point enter the opposite scroll
6313 margin as result of the scroll.
6314 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6315 threshold of 100 lines for never-recentering scrolling.
6316
e4cc2dfc
JB
63172011-03-31 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * dispextern.h (move_it_by_lines):
6320 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6321 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6322 (message_log_check_duplicate): Remove parameters `prev_bol' and
6323 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6324 (redisplay_internal): Remove parameter `preserve_echo_area',
6325 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6326
6327 * indent.c (Fvertical_motion):
6328 * window.c (window_scroll_pixel_based, Frecenter):
6329 Don't pass `need_y_p' to `move_it_by_lines'.
6330
1c470562
SM
63312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6332
44f230aa
SM
6333 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6334 steal a few bits to be more compact.
6335 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6336 Remove unneeded casts.
6337
1c470562
SM
6338 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6339
888adce9
ZK
63402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6341
6342 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6343 binding" message (bug#7967).
6344
f838ed7b
PE
63452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6346
77861b95
PE
6347 Fix more problems found by GCC 4.6.0's static checks.
6348
de6dbc14
PE
6349 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6350 Remove unused local var.
6351
f838ed7b
PE
6352 * editfns.c (Fmessage_box): Remove unused local var.
6353
792c7b2b
PE
6354 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6355 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6356 Omit unused local vars.
c499e557 6357 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6358 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6359 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6360 Omit unused local var.
6361
ba0165e1
PE
6362 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6363 Don't assume string length fits in int.
32ad8845 6364 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6365 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6366
3c59b4c9
PE
6367 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6368 instead of alloca (Bug#8344).
6369
a3eed478 6370 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6371 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6372
eb4d412d
PE
6373 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6374
1658b401
PE
6375 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6376 concerns.
6377
6378 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6379
6380 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6381
9a2c6e05
PE
6382 * keyboard.c (syms_of_keyboard): Use the same style as later
6383 in this function when indexing through an array. This also
6384 works around GCC bug 48267.
6385
03d0a109
PE
6386 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6387
44f730c8
PE
6388 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6389
fe75f926
PE
6390 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6391 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6392
ffa8c828
PE
6393 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6394 This avoids undefined behavior on integer overflow, and is a bit
6395 more convenient anyway since it is compared to a size_t variable.
6396
c5101a77
PE
6397 Variadic C functions now count arguments with size_t, not int.
6398 This avoids an unnecessary limitation on 64-bit machines, which
6399 caused (substring ...) to crash on large vectors (Bug#8344).
6400 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6401 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6402 All variadic functions and their callers changed accordingly.
c5101a77
PE
6403 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6404 * data.c (arith_driver, float_arith_driver): Likewise.
6405 * editfns.c (general_insert_function): Likewise.
6406 * eval.c (struct backtrace.nargs, interactive_p)
6407 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6408 (funcall_lambda, mark_backtrace): Likewise.
6409 * fns.c (concat): Likewise.
6410 * frame.c (x_set_frame_parameters): Likewise.
6411 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6412 0 if not found, not -1. All callers changed.
6413
dd3f25f7
PE
6414 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6415 (stack_copy_size): Now size_t, not int.
6416 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6417
461c2ab9
JB
64182011-03-28 Juanma Barranquero <lekktu@gmail.com>
6419
6420 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6421 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6422 All callers changed.
6423
6424 * lisp.h (multibyte_char_to_unibyte):
6425 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6426 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6427 * character.h (CHAR_TO_BYTE8):
6428 * cmds.c (internal_self_insert):
6429 * editfns.c (general_insert_function):
6430 * keymap.c (push_key_description):
6431 * search.c (Freplace_match):
6432 * xdisp.c (message_dolog, set_message_1): All callers changed.
6433
f6d62986
SM
64342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6435
6436 * keyboard.c (safe_run_hook_funcall): New function.
6437 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6438 don't set the hook to nil, but remove the offending function instead.
6439 (Qcommand_hook_internal): Remove, unused.
6440 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6441 Vcommand_hook_internal.
6442
6443 * eval.c (enum run_hooks_condition): Remove.
6444 (funcall_nil, funcall_not): New functions.
6445 (run_hook_with_args): Call each function through a `funcall' argument.
6446 Remove `cond' argument, now redundant.
6447 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6448 (Frun_hook_with_args_until_failure): Adjust accordingly.
6449 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6450
1db5b1ad
JB
64512011-03-28 Juanma Barranquero <lekktu@gmail.com>
6452
6453 * dispextern.h (string_buffer_position): Remove declaration.
6454
6455 * print.c (strout): Remove parameter `multibyte', unused since
6456 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6457
6458 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6459 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6460 All callers changed.
6461
6462 * w32.c (_wsa_errlist): Use braces for struct initializers.
6463
6464 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6465 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6466 All callers changed.
6467 (string_buffer_position): Likewise. Also, make static (it's never
6468 used outside xdisp.c).
6469 (cursor_row_p): Remove parameter `w', unused since
6470 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6471 (decode_mode_spec): Remove parameter `precision', introduced during
6472 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6473 All callers changed.
6474
5ffb62aa
JD
64752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6476
6477 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6478
461c2ab9 64792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6480
6481 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6482 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6483 (ns_update_auto_hide_menu_bar): New functions.
6484 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6485 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6486 ns_constrain_all_frames.
6487 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6488 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6489
5c380ffb
JD
64902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6491
6492 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6493
9af30bdf
GM
64942011-03-27 Glenn Morris <rgm@gnu.org>
6495
6496 * syssignal.h: Replace RETSIGTYPE with void.
6497 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6498 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6499 Replace SIGTYPE with void everywhere.
6500 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6501 * s/template.h (SIGTYPE): Remove commented out definition.
6502
e2abce01
JB
65032011-03-26 Eli Zaretskii <eliz@gnu.org>
6504
6505 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6506 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6507
f868cd8a
JB
65082011-03-26 Juanma Barranquero <lekktu@gmail.com>
6509
59eb0929
JB
6510 * w32.c (read_unc_volume): Use parameter `henum', instead of
6511 global variable `wget_enum_handle'.
6512
6513 * keymap.c (describe_vector): Remove parameters `indices' and
6514 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6515 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6516
f868cd8a
JB
6517 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6518
6519 * keyboard.c (timer_check): Remove parameter `do_it_now',
6520 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6521 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6522 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6523
6524 * keyboard.c (read_char):
6525 * w32menu.c (w32_menu_display_help):
6526 * xmenu.c (show_help_event, menu_help_callback):
6527 Adjust calls to `show_help_echo'.
6528
6529 * gtkutil.c (xg_maybe_add_timer):
6530 * keyboard.c (readable_events):
6531 * process.c (wait_reading_process_output):
6532 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6533
6534 * insdel.c (adjust_markers_gap_motion):
6535 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6536 (gap_left, gap_right): Don't call it.
6537
2ecf6fdb
CY
65382011-03-25 Chong Yidong <cyd@stupidchicken.com>
6539
6540 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6541 incurred during fontification.
6542
6b1f9ba4
JB
65432011-03-25 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6546 (DEFVAR_PER_BUFFER): Don't pass it.
6547
6548 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6549 (scrolling_window): Don't pass it.
6550
0f4a96b5
JB
65512011-03-25 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6554
6555 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6556 and `suffix'.
6557 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6558 of variables specific to SELinux and computation of `encoded_absname'.
6559
6560 * image.c (XPutPixel): Remove unused variable `height'.
6561
6562 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6563
6564 * unexw32.c (get_section_info): Remove unused variable `section'.
6565
6566 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6567 (system_process_attributes): Remove unused variable `sess'.
6568 (sys_read): Remove unused variable `err'.
6569
6570 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6571 (w32_wnd_proc): Remove unused variable `isdead'.
6572 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6573 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6574 (x_create_tip_frame): Remove unused variable `tem'.
6575
6576 * w32inevt.c (w32_console_read_socket):
6577 Remove unused variable `no_events'.
6578
6579 * w32term.c (x_draw_composite_glyph_string_foreground):
6580 Remove unused variable `width'.
6581
1149507c
JB
65822011-03-24 Juanma Barranquero <lekktu@gmail.com>
6583
6584 * w32term.c (x_set_glyph_string_clipping):
6585 Don't pass uninitialized region to CombineRgn.
6586
9c88f339
JB
65872011-03-23 Juanma Barranquero <lekktu@gmail.com>
6588
6589 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6590 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6591 (Fx_close_connection): Remove unused variable `i'.
6592
6593 * w32font.c (w32font_draw): Return number of glyphs.
6594 (w32font_open_internal): Remove unused variable `i'.
6595 (w32font_driver): Add missing initializer.
6596
6597 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6598 (fill_in_menu): Remove unused variable `items_added'.
6599
6600 * w32term.c (last_mouse_press_frame): Remove static global variable.
6601 (w32_clip_to_row): Remove unused variable `f'.
6602 (x_delete_terminal): Remove unused variable `i'.
6603
6604 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6605 (NOTHING): Remove unused static global variable.
6606 (uniscribe_check_otf): Remove unused variable `table'.
6607 (uniscribe_font_driver): Add missing initializers.
6608
dee091a3
JD
66092011-03-23 Julien Danjou <julien@danjou.info>
6610
6611 * term.c (Fsuspend_tty, Fresume_tty):
6612 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6613 * window.c (temp_output_buffer_show):
6614 * insdel.c (signal_before_change):
6615 * frame.c (Fhandle_switch_frame):
6616 * fileio.c (Fdo_auto_save):
6617 * emacs.c (Fkill_emacs):
6618 * editfns.c (save_excursion_restore):
6619 * cmds.c (internal_self_insert):
6620 * callint.c (Fcall_interactively):
6621 * buffer.c (Fkill_all_local_variables):
6622 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6623 Use Frun_hooks.
0f4a96b5 6624 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6625 unconditionnaly since it does the check itself.
6626
2c520ab5 66272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6628
c9c49752
PE
6629 Fix more problems found by GCC 4.5.2's static checks.
6630
8abc3f12
PE
6631 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6632 the first time through the loop, since we know p0 < p1 then.
6633 This also avoids a gcc -Wstrict-overflow warning.
6634
a2d26660
PE
6635 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6636 leading to a memory leak, possible in functions like
6637 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6638 of objects (Bug#8318).
a2d26660 6639
916c72e9
PE
6640 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6641 that could (at least in theory) be that large.
6642
19ab8a18
PE
6643 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6644 This is less likely to overflow, and avoids undefined behavior if
6645 overflow does occur. All callers changed. Use strtoul to scan
6646 for the unsigned long integer.
b7cbbd6f
PE
6647 (pint2hrstr): Simplify and tune code slightly.
6648 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6649
f0641eff
PE
6650 * scroll.c (do_scrolling): Work around GCC bug 48228.
6651 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6652
7f650bb9
PE
6653 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6654 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6655 (validate_x_resource_name): Simplify count usage.
6656 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6657
37dd57d1
PE
6658 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6659 fail (Bug#8306).
81e56e61 6660
699979fc 6661 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6662
401bf9b4
PE
6663 * process.c (Fmake_network_process): Use socklen_t, not int,
6664 where POSIX says socklen_t is required in portable programs.
6665 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6666 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6667 (Fmake_network_process, server_accept_connection):
6668 (wait_reading_process_output, read_process_output):
6669 Likewise.
6670
b93aacde
PE
6671 * process.c: Rename or move locals to avoid shadowing.
6672 (list_processes_1, Fmake_network_process):
6673 (read_process_output_error_handler, exec_sentinel_error_handler):
6674 Rename or move locals.
4dc343ee 6675 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6676 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6677 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6678 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6679 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6680
af8a867c 6681 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6682 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6683 Include tparam.h instead, since it declares them.
af8a867c
PE
6684 * cm.h (PC): Remove extern decl; tparam.h now does this.
6685 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6686 * terminfo.c: Include tparam.h, to check interfaces.
6687 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6688 (tparam): Adjust signature to match interface in tparam.h;
6689 this removes some undefined behavior. Check that outstring and len
6690 are zero, which they always are with Emacs.
6691 * tparam.h (PC, BC, UP): New extern decls.
6692
0248044d 6693 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6694 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6695
8ff096c1 6696 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6697 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6698 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6699 (ftfont_list): Remove unused local.
49eaafba
PE
6700 (get_adstyle_property, ftfont_pattern_entity):
6701 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6702 Rename locals to avoid shadowing.
8ff096c1 6703
e2be39f6
PE
6704 * xfont.c (xfont_list_family): Mark var as initialized.
6705
c9735e30
PE
6706 * xml.c (make_dom): Now static.
6707
8f5201ae
PE
6708 * composite.c (composition_compute_stop_pos): Rename local to
6709 avoid shadowing.
b246f932
PE
6710 (composition_reseat_it): Remove unused locals.
6711 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6712 (composition_update_it): Mark var as initialized.
11b61122
PE
6713 (find_automatic_composition): Mark vars as initialized,
6714 with a FIXME (Bug#8290).
8f5201ae 6715
760fbc2c
PE
6716 character.h: Rename locals to avoid shadowing.
6717 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6718 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6719 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6720 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6721 to avoid shadowing.
6722
ff08eb85
PE
6723 * textprop.c (property_change_between_p): Remove; unused.
6724
fc7bf025
PE
6725 * intervals.c (interval_start_pos): Now static.
6726
235d7abc
PE
6727 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6728
44f230aa
SM
6729 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6730 Rename locals to avoid shadowing.
3e7d6594 6731
50060332
PE
6732 * sound.c (wav_play, au_play, Fplay_sound_internal):
6733 Fix pointer signedness.
d01f234b 6734 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6735 (wav_play): Initialize a variable to 0, to prevent undefined
6736 behavior (Bug#8278).
50060332 6737
c4fc4e30
PE
6738 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6739
918436ed
PE
6740 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6741
c939f91b
PE
6742 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6743 clobbering (Bug#8298).
b9c7f648
PE
6744 * sysdep.c (sys_subshell): Likewise.
6745 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6746
6bd8c144
PE
6747 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6748 This should get cleaned up, so that child_setup has the
6749 same signature on all platforms.
6750
7710357c 6751 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6752 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6753
c59da222
CY
67542011-03-22 Chong Yidong <cyd@stupidchicken.com>
6755
6756 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6757 not to be necessary, and produces flickering.
6758
66b87493
GM
67592011-03-20 Glenn Morris <rgm@gnu.org>
6760
6761 * config.in: Remove file.
6762
45b6f6d5
JB
67632011-03-20 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6766 are now in src/globals.h.
6767 (syms_of_minibuf): Remove spurious & from previous change.
6768
3ec03f7e
LL
67692011-03-20 Leo <sdl.web@gmail.com>
6770
6771 * minibuf.c (completing-read-function): New variable.
6772 (completing-read-default): Rename from completing-read.
6773 (completing-read): Call completing-read-function.
6774
b14e3e21
CY
67752011-03-19 Juanma Barranquero <lekktu@gmail.com>
6776
6777 * xfaces.c (Fx_load_color_file):
6778 Read color file from absolute filename (bug#8250).
6779
f2b726e6
JB
67802011-03-19 Juanma Barranquero <lekktu@gmail.com>
6781
6782 * makefile.w32-in: Update dependencies.
6783
09f6ff02
EZ
67842011-03-17 Eli Zaretskii <eliz@gnu.org>
6785
6786 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6787
29a6015a
PE
67882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6789
a3a6c54e
PE
6790 Fix more problems found by GCC 4.5.2's static checks.
6791
b766f867
PE
6792 * process.c (make_serial_process_unwind, send_process_trap):
6793 (sigchld_handler): Now static.
6794
be02381c
PE
6795 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6796 That way, the code declares only the vars that it needs.
6797 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6798 * s/cygwin.h (PTY_ITERATION): Likewise.
6799 * s/darwin.h (PTY_ITERATION): Likewise.
6800 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6801
57048744
PE
6802 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6803 * process.c (allocate_pty): Don't declare stb unless it's needed.
6804
7914961c 6805 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6806 (CONSTANTLIM): Remove; unused.
6807 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6808 Define only if needed.
7914961c 6809
b3967b18
PE
6810 * unexelf.c (unexec): Name an expression,
6811 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6812 Use a different way to cause a compilation error if anyone uses
6813 n rather than nn, a way that does not involve shadowing.
73366a00 6814 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6815
29a6015a
PE
6816 * deps.mk (unexalpha.o): Remove; unused.
6817
43cfc33e 6818 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6819 * unexec.h: New file.
ce701a33
PE
6820 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6821 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6822 Depend on unexec.h.
6823 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6824 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6825 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6826 Change as necessary to match prototype in unexec.h.
ce701a33 6827
01f44d5a
PE
6828 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6829 shadowing.
4f63c6bb 6830 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6831
a6670b0b
PE
6832 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6833 Rename locals to avoid shadowing.
6834
cef2010d 6835 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6836 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6837
d4d7173a
PE
6838 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6839
f08b802a
PE
6840 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6841 warning when compiling print.c.
6842
3ddb0639
PE
6843 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6844 instead of using an uninitialized var.
5ad03b97 6845 (font_sort_entities): Mark var as initialized.
3ddb0639 6846
170a2692
PE
6847 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6848
e663c700
PE
6849 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6850 pointers to constants.
89bc529a 6851 (font_parse_fcname): Remove unused vars.
7b81e2d0 6852 (font_delete_unmatched): Now static.
ea838e10 6853 (font_get_spec): Remove; unused.
13a547c6
PE
6854 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6855 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6856 Rename or move locals to avoid shadowing.
e663c700 6857
2a80c887 6858 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6859 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6860
1384fa33 6861 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6862 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6863
8b2c52e9
PE
6864 * alloc.c (mark_backtrace): Move decl from here ...
6865 * lisp.h: ... to here, so that it can be checked.
6866
475545b5 6867 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6868 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6869 (lisp_indirect_variable): Name an expression,
6870 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6871 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6872
b1349114 6873 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6874 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6875 Use const pointer when appropriate.
b1349114 6876
a2928364
PE
6877 * lisp.h (get_system_name, get_operating_system_release):
6878 Move decls here, to check interfaces.
6879 * process.c (get_operating_system_release): Move decl to lisp.h.
6880 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6881 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6882 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6883 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6884 (Fformat_time_string, Fencode_time, Finsert_char):
6885 (Ftranslate_region_internal, Fformat):
6886 Rename or remove local vars to avoid shadowing.
9710023e 6887 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6888
a415e694
PE
6889 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6890 avoid shadowing.
6891
8ef4622d
PE
6892 * lisp.h (eassert): Check that the argument compiles, even if
6893 ENABLE_CHECKING is not defined.
6894
946f9a5b
PE
6895 * data.c (Findirect_variable): Name an expression, to avoid
6896 gcc -Wbad-function-cast warning.
112396d6 6897 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6898 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6899 (Fmake_variable_buffer_local, Fmake_local_variable):
6900 Mark variables as initialized.
52746918 6901 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6902
e5aab7e7 6903 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6904 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6905 Rename locals to avoid shadowing.
dff45157
PE
6906 (mark_stack): Move local variables into the #ifdef region where
6907 they're used.
7bc26fdb
PE
6908 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6909 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6910 needed otherwise.
6911 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6912 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6913 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6914
e5aab7e7
PE
6915 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6916 avoids undefined behavior in theory.
6917
4da60324
PE
6918 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6919
88043301
PE
6920 Use functions, not macros, for up- and down-casing (Bug#8254).
6921 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6922 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6923 to use the following functions instead of these macros.
6924 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6925 EMACS_INT, since callers assume the returned value fits in int.
6926 (upcase1): Likewise, for UPCASE_TABLE.
6927 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6928 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6929 the race-condition problem in the old DOWNCASE.
88043301 6930
19ed5445
PE
6931 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6932 Rename locals to avoid shadowing.
6933 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6934 (regex_compile, re_search_2, re_match_2_internal):
6935 Remove unused local vars.
952db0d7
PE
6936 (FREE_VAR): Rewrite so as not to use empty "else",
6937 which gcc can warn about.
da053e48 6938 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6939 (RETALLOC_IF): Define only if needed.
6940 (WORDCHAR_P): Likewise. This one is never needed, but is used
6941 only in a comment talking about a compiler bug, so put inside
6942 the #if 0 of that comment.
6943 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6944 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6945 Remove; unused.
19ed5445 6946
1f3561e4 6947 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6948 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6949 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6950
ded6f8f7
PE
6951 * search.c (simple_search): Remove unused var.
6952
dbd37a95
PE
6953 * dired.c (compile_pattern): Move decl from here ...
6954 * lisp.h: ... to here, so that it can be checked.
6955 (struct re_registers): New forward decl.
6956
7e47afad
PE
6957 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6958
85f24f61
PE
6959 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6960 All uses changed.
6961 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6962 Rename locals to avoid shadowing.
5671df8f 6963 (Fvertical_motion): Mark locals as initialized.
85f24f61 6964
181aa2be 6965 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6966 (casify_region): Mark local as initialized.
181aa2be 6967
930d429c
PE
6968 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6969
7082eac6
PE
6970 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6971 New macros, so that the caller can use some names other than
6972 gcpro1, gcpro2, etc.
6973 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6974 of the new macros.
6975 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6976 argument, for consistency with GCPRO2_VAR, etc: it is now the
6977 prefix of the variable, not the variable itself. All uses
6978 changed.
38b2c076
PE
6979 * dired.c (directory_files_internal, file_name_completion):
6980 Rename locals to avoid shadowing.
6981
15206ed9
PE
6982 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6983 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6984 dired.c's scmp function, had undefined behavior.
6985 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6986 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6987 * buffer.h: ... to here, because these macros use current_buffer,
6988 and the new implementation with inline functions needs to have
6989 current_buffer in scope now, rather than later when the macros
6990 are used.
6991 (downcase, upcase1): New static inline functions.
6992 (DOWNCASE, UPCASE1): Reimplement using these functions.
6993 This avoids undefined behavior in expressions like
6994 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6995 from race conditions in accessing the global variables
6996 case_temp1 and case_temp2.
6997 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6998 * lisp.h (case_temp1, case_temp2): Remove their decls.
6999 * character.h (ASCII_CHAR_P): Move from here ...
7000 * lisp.h: ... to here, so that the inline functions mentioned
7001 above can use them.
7002
4a6bea26
PE
7003 * dired.c (directory_files_internal_unwind): Now static.
7004
f14b7e14
PE
7005 * fileio.c (file_name_as_directory, directory_file_name):
7006 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7007 Now static.
2893f146
PE
7008 (file_name_as_directory): Use const pointers when appropriate.
7009 (Fexpand_file_name): Likewise. In particular, newdir might
7010 point at constant storage, so make it a const pointer.
fd4ead52 7011 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7012 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7013 signedness issues.
f839df0c
PE
7014 (Fset_file_times, Finsert_file_contents, auto_save_error):
7015 Rename locals to avoid shadowing.
f14b7e14 7016
5716756e 7017 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7018 (Ftry_completion, Fall_completions): Rename or remove locals
7019 to avoid shadowing.
5716756e 7020
b4c3046a
PE
7021 * marker.c (bytepos_to_charpos): Remove; unused.
7022
b45db522
PE
7023 * lisp.h (verify_bytepos, count_markers): New decls,
7024 so that gcc does not warn that these functions aren't declared.
7025
85876d07
PE
7026 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7027 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7028 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7029 (copy_text): Remove unused local var.
85876d07 7030
03d78a21 7031 * filelock.c (within_one_second): Now static.
b3dd38ab 7032 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7033
5df8f01b
PE
7034 * buffer.c (fix_overlays_before): Mark locals as initialized.
7035 (fix_start_end_in_overlays): Likewise. This function should be
7036 simplified by using pointers-to-pointers, but that's a different
7037 matter.
b1d876f1 7038 (switch_to_buffer_1): Now static.
8f54f30a
PE
7039 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7040 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7041
a70072c9 7042 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7043 Fix pointer signedness issue.
edced198
PE
7044 (sys_subshell): Mark local as volatile if checking for lint,
7045 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7046 (MAXPATHLEN): Define only if needed.
a70072c9 7047
a0977c44
PE
7048 * process.c (serial_open, serial_configure): Move decls from here ...
7049 * systty.h: ... to here, so that they can be checked.
7050
a884fdcc
PE
7051 * fns.c (get_random, seed_random): Move extern decls from here ...
7052 * lisp.h: ... to here, so that they can be checked.
7053
604efe86 7054 * sysdep.c (reset_io): Now static.
b8950c94 7055 (wait_for_termination_signal): Remove; unused.
604efe86 7056
38fc62d9
PE
7057 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7058 (copy_keymap_item, append_key, push_text_char_description):
7059 Now static.
1004a21a 7060 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7061 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7062 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7063 (describe_map_tree):
7064 Rename locals to avoid shadowing.
38fc62d9 7065
2f2650da
PE
7066 * keyboard.c: Declare functions static if they are not used elsewhere.
7067 (echo_char, echo_dash, cmd_error, top_level_2):
7068 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7069 (read_char, kbd_buffer_get_event, make_lispy_position):
7070 (make_lispy_event, make_lispy_movement, apply_modifiers):
7071 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7072 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7073 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7074 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7075 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7076
a053e86c 7077 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7078 (mark_kboards): Move decl here ...
7079 * alloc.c (mark_kboards): ... from here.
a053e86c 7080
4752793e
PE
7081 * lisp.h (force_auto_save_soon): New decl.
7082
74f10ca7 7083 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7084 (DEFINE_DUMMY_FUNCTION): New macro.
7085 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7086 Use it.
c03cd23f
PE
7087 (main): Add casts to avoid warnings
7088 if GCC considers string literals to be constants.
74f10ca7 7089
022e70d4
PE
7090 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7091
59d6fe83
PE
7092 * dbusbind.c: Pointer signedness fixes.
7093 (xd_signature, xd_append_arg, xd_initialize):
7094 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7095 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7096 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7097 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7098
78320123
PE
7099 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7100 if GCC considers string literals to be constants.
49cebcca 7101 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7102
35ac2a97
SM
71032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7104
fb103ca9
SM
7105 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7106 (print_preprocess, print_object): New macro to fix last change.
7107
35ac2a97
SM
7108 * print.c (print_preprocess): Don't forget font objects.
7109
62973b41
JB
71102011-03-16 Juanma Barranquero <lekktu@gmail.com>
7111
7112 * emacs.c (USAGE3): Doc fixes.
7113
0e48bb22
AS
71142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7115
7116 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7117 structure.
7118
7684e57b
JB
71192011-03-14 Juanma Barranquero <lekktu@gmail.com>
7120
7121 * lisp.h (VWindow_system, Qfile_name_history):
7122 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7123 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7124 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7125
7126 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7127 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7128
7129 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7130 * w32console.c (detect_input_pending, read_input_pending)
7131 (encode_terminal_code):
7132 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7133 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7134 (w32_system_caret_y, Qfile_name_history):
7135 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7136 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7137 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7138 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7139 * w32proc.c (Qlocal, report_file_error):
7140 * w32term.c (Vwindow_system, updating_frame):
7141 * w32uniscribe.c (initialized, uniscribe_font_driver):
7142 Remove unneeded extern declarations.
7143
2aa46d6c
CY
71442011-03-14 Chong Yidong <cyd@stupidchicken.com>
7145
c96bbc66 7146 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7147
cffc6f3b
CY
71482011-03-13 Chong Yidong <cyd@stupidchicken.com>
7149
7150 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7151 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7152 These macros can no longer be used for assignment.
7153
44f230aa
SM
7154 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7155 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7156 (record_buffer_markers, fetch_buffer_markers): New functions for
7157 recording and fetching special buffer markers.
7158 (set_buffer_internal_1, set_buffer_temp): Use them.
7159
7160 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7161
7162 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7163
7164 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7165 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7166
7167 * xdisp.c (hscroll_window_tree):
7168 (reconsider_clip_changes): Use PT instead of BUF_PT.
7169
d251f04b
EZ
71702011-03-13 Eli Zaretskii <eliz@gnu.org>
7171
7172 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7173 $(EMACS_ROOT)/lib/intprops.h.
7174
f0c77cd1
PE
71752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7176
3eca4629
PE
7177 Fix more problems found by GCC 4.5.2's static checks.
7178
7c86ee98
PE
7179 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7180 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7181 (xg_free_frame_widgets): Make it clear that a local variable is
7182 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7183 (gdk_window_get_screen): Make it clear that this macro is needed
7184 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7185 (int_gtk_range_get_value): New function, which avoids a diagnostic
7186 from gcc -Wbad-function-cast.
7187 (xg_set_toolkit_scroll_bar_thumb): Use it.
7188 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7189 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7190 (get_utf8_string, xg_get_file_with_chooser):
7191 Rename locals to avoid shadowing.
7192 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7193
41729b81
PE
7194 * xgselect.c (xg_select): Remove unused var.
7195
f0c77cd1
PE
7196 * image.c (four_corners_best): Mark locals as initialized.
7197 (gif_load): Initialize transparent_p to zero (Bug#8238).
7198 Mark another local as initialized.
ec6cf4c6 7199 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7200
ce0ad53d 7201 * image.c (clear_image_cache): Now static.
d5d5a617 7202 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7203 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7204 (x_edge_detection): Remove unnecessary cast that
7205 gcc -Wbad-function-cast diagnoses.
2037898d 7206 (gif_load): Fix pointer signedness.
6ae141d6
PE
7207 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7208 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7209
33383987 72102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7211
d32df629
PE
7212 Improve quality of tests for time stamp overflow.
7213 For example, without this patch (encode-time 0 0 0 1 1
7214 1152921504606846976) returns the obviously-bogus value (-948597
7215 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7216 reports time overflow. See
7217 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7218 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7219 * editfns.c: Include limits.h and intprops.h.
7220 (TIME_T_MIN, TIME_T_MAX): New macros.
7221 (time_overflow): Move earlier, to before first use.
7222 (hi_time, lo_time): New functions, for an accurate test for
7223 out-of-range times.
7224 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7225 (Fget_internal_run_time): Don't assume time_t fits in int.
7226 (make_time): Use list2 instead of Fcons twice.
7227 (Fdecode_time): More accurate test for out-of-range times.
7228 (check_tm_member): New function.
7229 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7230 (lisp_time_argument): Don't rely on undefined left-shift and
7231 right-shift behavior when checking for time stamp overflow.
8be6f318 7232
fe31d94c
PE
7233 * editfns.c (time_overflow): New function, refactoring common code.
7234 (Fformat_time_string, Fdecode_time, Fencode_time):
7235 (Fcurrent_time_string): Use it.
7236
8be6f318
PE
7237 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7238 * dired.c (make_time): Move to ...
7239 * editfns.c (make_time): ... here.
7240 * systime.h: Note the move.
7241
09d9db2c 72422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7243
126bc0dc
YM
7244 * fringe.c (update_window_fringes): Remove unused variables.
7245
c47cbdfd
YM
7246 * unexmacosx.c (copy_data_segment): Also copy __got section.
7247 (Bug#8223)
7248
7ac80be9
EZ
72492011-03-12 Eli Zaretskii <eliz@gnu.org>
7250
c96bbc66 7251 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7252 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7253 Constify `char *' arguments and their references according to
7254 prototypes in tparam.h.
7255
ecb0f94d 7256 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7257
7ac80be9
EZ
7258 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7259 Adapt all references accordingly.
7260
7261 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7262
ef1fd07e
TT
72632011-03-11 Tom Tromey <tromey@redhat.com>
7264
7265 * buffer.c (syms_of_buffer): Remove obsolete comment.
7266
7ef4b50c
EZ
72672011-03-11 Eli Zaretskii <eliz@gnu.org>
7268
7269 * termhooks.h (encode_terminal_code): Declare prototype.
7270
7271 * msdos.c (encode_terminal_code): Don't declare prototype.
7272
7273 * term.c (encode_terminal_code): Now external again, used by
7274 w32console.c and msdos.c.
7275
44f230aa
SM
7276 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7277 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7278
4b1ec863 72792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7280
1714f52b 7281 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7282
4b1ec863
PE
7283 * fringe.c (update_window_fringes): Mark locals as initialized
7284 (Bug#8227).
7285 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7286
524c7aa6
PE
7287 * alloc.c (mark_fringe_data): Move decl from here ...
7288 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7289 to check its interface.
7290 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7291
a5c0af81 7292 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7293 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7294 (fontset_font): Mark local as initialized.
a9a06e0b 7295 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7296
b4716021
PE
7297 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7298
811e9bac 7299 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7300 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7301 (x_own_selection, Fx_disown_selection_internal): Rename locals
7302 to avoid shadowing.
7303 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7304
7e3ab302
PE
7305 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7306 so that the caller can use some name other than gcpro1.
7307 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7308 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7309 (Fx_backspace_delete_keys_p):
7310 Use them to avoid shadowing, and rename vars to avoid shadowing.
7311 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7312 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7313 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7314 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7315 Remove unused locals.
7e3ab302
PE
7316 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7317 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7318 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7319 macros.
f78faa98 7320
e2b13473
PE
7321 * xterm.h (x_mouse_leave): New decl.
7322
77f23912
PE
7323 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7324 Remove unused functions.
cdf4ba58
PE
7325 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7326 (x_calc_absolute_position): Now static.
7411c686 7327 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7328 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7329 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7330 unless they are used.
38d0b34a
PE
7331 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7332 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7333 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7334 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7335 (x_error_catcher, x_connection_closed, x_error_handler):
7336 (x_error_quitter, xembed_send_message, x_iconify_frame):
7337 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7338 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7339 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7340
44f230aa
SM
7341 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7342 Rename or move locals to avoid shadowing.
6b463e58 7343 (tty_defined_color, merge_face_heights): Now static.
5967d051 7344 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7345 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7346 does not deduce is never used uninitialized.
73719eba
PE
7347 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7348 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7349
426994c3 7350 * terminal.c (store_terminal_param): Now static.
5489860b 7351
032f1620 7352 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7353 (set_frame_menubar): Remove unused local.
d4323972 7354 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7355 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7356 since they might point to immutable storage.
281585b0
PE
7357 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7358 since it's unused otherwise.
032f1620 7359
367c19e5 7360 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7361 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7362 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7363 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7364 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7365 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7366 does not deduce are never used uninitialized.
70739cbe 7367
07b48fa9
PE
7368 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7369
8868a238 7370 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7371 * window.c (window_loop, size_window):
7372 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7373
7e5cf297 7374 * window.c (display_buffer): Now static.
d6550a9f
PE
7375 (size_window): Mark variables that gcc -Wuninitialized
7376 does not deduce are never used uninitialized.
a586633d
PE
7377 * window.h (check_all_windows): New decl, to forestall
7378 gcc -Wmissing-prototypes diagnostic.
5b555da1 7379 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7380
f6095868
PE
7381 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7382 shadowing.
7383 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7384 Include <limits.h>.
7385 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7386 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7387 (load_charset_map): Mark variables that gcc -Wuninitialized
7388 does not deduce are never used uninitialized.
53df7c11 7389 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7390
f38b440c
PE
7391 * coding.c (coding_set_source, coding_set_destination):
7392 Use "else { /* comment */ }" rather than "else /* comment */;"
7393 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7394 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7395 a block, when the outer 'i' will do.
7396 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7397 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7398 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7399 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7400 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7401 Rename locals to avoid shadowing.
7402 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7403 * coding.c (emacs_mule_char, encode_invocation_designation):
7404 Now static, since they're not used elsewhere.
413bb2db 7405 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7406 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7407 (decode_coding_emacs_mule): Mark variables that gcc
7408 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7409 (detect_coding_iso_2022): Initialize a local variable that might
7410 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7411 this initialization is needed. (Bug#8211)
5f58e762
PE
7412 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7413 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7414 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7415 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7416 Remove unused macros.
f38b440c 7417
232b38b9 7418 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7419 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7420 * character.c (string_count_byte8): Likewise.
232b38b9 7421
fb90da1b
PE
7422 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7423 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7424
fb93dbc2
PE
7425 * chartab.c (copy_sub_char_table): Now static, since it's not used
7426 elsewhere.
5c156ace
PE
7427 (sub_char_table_ref_and_range, char_table_ref_and_range):
7428 Rename locals to avoid shadowing.
bbcd0949 7429 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7430
7d3b3862 7431 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7432 (BIDI_BOB): Remove unused macro.
7d3b3862 7433
6be7d3da
PE
7434 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7435 deduce are never used uninitialized.
c2ed9c8b 7436 * term.c (encode_terminal_code): Likewise.
6be7d3da 7437
75f8807f 7438 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7439
50938595
PE
7440 * tparam.h: New file.
7441 * term.c, tparam.h: Include it.
7442 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7443 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7444 Move these decls to tparam.h, and make them agree with what
7445 is actually in tparam.c. The previous trick of using incompatible
7446 decls in different modules does not conform to the C standard.
7447 All callers of tparam changed to use tparam's actual API.
7448 * tparam.c (tparam1, tparam, tgoto):
7449 Use const pointers where appropriate.
7450
fbceeba2
PE
7451 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7452 * cm.h (struct cm): Likewise.
7453 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7454 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7455 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7456 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7457 (turn_on_face, init_tty): Likewise.
7458 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7459
7f3f1250
PE
7460 * term.c (term_mouse_position): Rename local to avoid shadowing.
7461
e6ca6543
PE
7462 * alloc.c (mark_ttys): Move decl from here ...
7463 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7464
c40f8d15
AS
74652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7466
7467 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7468
cfe0661d
JB
74692011-03-09 Juanma Barranquero <lekktu@gmail.com>
7470
7471 * search.c (compile_pattern_1): Remove argument regp, unused since
7472 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7473 (compile_pattern): Don't pass it.
7474
0afb4571
J
74752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7476
7477 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7478 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7479 for ! HAVE_GTK3.
7480 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7481
7482 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7483
7484 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7485 gdk_window_get_screen, gdk_window_get_geometry,
7486 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7487 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7488 (xg_get_pixbuf_from_pixmap): New function.
7489 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7490 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7491 Call xg_get_pixbuf_from_pixmap instead of
7492 gdk_pixbuf_get_from_drawable.
7493 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7494 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7495 (xg_check_special_colors): Use GtkStyleContext and its functions
7496 for HAVE_GTK3.
7497 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7498 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7499 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7500 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7501 Call gtk_widget_get_preferred_size.
0afb4571
J
7502 (xg_frame_resized): gdk_window_get_geometry only takes 5
7503 parameters.
44f230aa
SM
7504 (xg_win_to_widget, xg_event_is_for_menubar):
7505 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7506 (xg_set_widget_bg): New function.
7507 (delete_cb): New function.
895009e1 7508 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7509 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7510 (xg_set_background_color): Call xg_set_widget_bg.
7511 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7512 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7513 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7514 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7515 if ! HAVE_GTK3.
7516 (update_frame_tool_bar): Call gtk_widget_hide.
7517 (xg_initialize): Use GDK_KEY_g.
7518
7519 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7520 if ! HAVE_GTK3
7521 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7522
7523 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7524 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7525 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7526
1c2cc4ef
JB
75272011-03-08 Juanma Barranquero <lekktu@gmail.com>
7528
7529 * w32xfns.c (select_palette): Check success of RealizePalette against
7530 GDI_ERROR, not zero.
7531
33383987 7532See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7533
7534;; Local Variables:
7535;; coding: utf-8
aac0c6e3
MR
7536;; End:
7537
33383987 7538 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7539
7540 This file is part of GNU Emacs.
7541
7542 GNU Emacs is free software: you can redistribute it and/or modify
7543 it under the terms of the GNU General Public License as published by
7544 the Free Software Foundation, either version 3 of the License, or
7545 (at your option) any later version.
7546
7547 GNU Emacs is distributed in the hope that it will be useful,
7548 but WITHOUT ANY WARRANTY; without even the implied warranty of
7549 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7550 GNU General Public License for more details.
7551
7552 You should have received a copy of the GNU General Public License
7553 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.