* lisp.h (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eb49b136
PE
12011-06-19 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4 This didn't break anything, but it didn't help either.
5 It's confusing to put a bogus integer in a place where the actual
6 value does not matter.
9f62aeb1 7 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9
e39e811e
PE
102011-06-18 Paul Eggert <eggert@cs.ucla.edu>
11
15375a22
PE
12 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
14 implementation.
b61cc01c
PE
15 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
16 We prefer signed types, and the value cannot exceed the EMACS_INT
17 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
18 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
19 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
20 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 21
53b2623d
PE
22 * indent.c (sane_tab_width): New function.
23 (current_column, scan_for_column, Findent_to, position_indentation)
24 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 25 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 26
45aebb64
PE
27 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
28
f2ed8a70
PE
29 * lisp.h (lint_assume): New macro.
30 * composite.c (composition_gstring_put_cache):
31 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
32
abe80cc6
PE
33 * editfns.c, insdel.c:
34 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 35
b02c740e
PE
36 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
37
ebc96716
PE
38 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
39
b4e50fa0 40 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 41 Use much-faster test for byte-length change.
311d5d7c 42 Don't assume string byte-length fits in 'int'.
a4cf38e4 43 Check that character arg fits in 'int'.
85461888 44 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 45
c0c1ee9f
PE
46 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
47
a498d7f4
PE
48 * fns.c (concat): Catch string overflow earlier.
49 Do not rely on integer wraparound.
50
e39e811e
PE
51 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
52
fadf4e30
PE
532011-06-17 Paul Eggert <eggert@cs.ucla.edu>
54
87830974
PE
55 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
56 * xdisp.c (forward_to_next_line_start)
57 (back_to_previous_visible_line_start)
58 (reseat_at_next_visible_line_start, next_element_from_buffer):
59 Don't arbitrarily truncate the value of 'selective' to int.
60
76031fad
PE
61 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
62
5eb55db9
PE
63 * composite.c: Don't truncate sizes to 'int'.
64 (composition_gstring_p, composition_reseat_it)
65 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
66 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
67 not EMACS_UINT, for indexes.
5eb55db9 68
0703a717
PE
69 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
70
d6202519
PE
71 * buffer.c: Include <verify.h>.
72 (struct sortvec.priority, struct sortstr.priority):
8961a454 73 Now EMACS_INT, not int.
c20998a7 74 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
75 (struct sortstr.size, record_overlay_string)
76 (struct sortstrlist.size, struct sortlist.used):
77 Don't truncate size to int.
78 (record_overlay_string): Check for size-calculation overflow.
d6202519 79 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 80
28177add
PE
812011-06-16 Paul Eggert <eggert@cs.ucla.edu>
82
dd3482fe
PE
83 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
84 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
85 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
86
393d71f3 87 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
88 * fileio.c (Finsert_file_contents):
89 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
90 Remove the old (too-loose) buffer overflow checks.
91 They weren't needed, since make_gap checks for buffer overflow.
92 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
93 The old code merely checked for Emacs fixnum overflow, and relied
94 on undefined (wraparound) behavior. The new code avoids undefined
95 behavior, and also checks for ptrdiff_t and/or size_t overflow.
96
2e6813b0 97 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
98 Tune. Don't use wider integers than needed. Don't use alloca.
99 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 100
599a9e4f
PE
101 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
102
99561444
PE
103 * insdel.c, lisp.h (buffer_overflow): New function.
104 (insert_from_buffer_1, replace_range, replace_range_2):
105 * insdel.c (make_gap_larger):
106 * editfns.c (Finsert_char):
107 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
108
28177add
PE
109 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
110
e69dafad
PE
1112011-06-15 Paul Eggert <eggert@cs.ucla.edu>
112
a7af7fde 113 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 114
b1c46f02
PE
115 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
116 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
117
e69dafad
PE
118 * fileio.c: Don't assume EMACS_INT fits in off_t.
119 (emacs_lseek): New static function.
120 (Finsert_file_contents, Fwrite_region): Use it.
121 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
122
566684ea
PE
123 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
124
e6966cd6
PE
125 * fns.c: Don't overflow int when computing a list length.
126 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
127 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
128 truncation on 64-bit hosts. Check for QUIT every
129 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
130 faster and is responsive enough.
131 (Flength): Report an error instead of overflowing an integer.
132 (Fsafe_length): Return a float if the value is not representable
133 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 134 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 135 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 136
dd0b0efb
PE
137 * alloc.c: Check that resized vectors' lengths fit in fixnums.
138 (header_size, word_size): New constants.
139 (allocate_vectorlike): Don't check size overflow here.
140 (allocate_vector): Check it here instead, since this is the only
141 caller of allocate_vectorlike that could cause overflow.
142 Check that the new vector's length is representable as a fixnum.
143
86fe5cfe
PE
144 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
145 The previous code was bogus. For example, next_almost_prime (32)
146 returned 39, which is undesirable as it is a multiple of 3; and
147 next_almost_prime (24) returned 25, which is a multiple of 5 so
148 why was the code bothering to check for multiples of 7?
149
80e88859
PE
150 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
151
4a2f0ad6
PE
152 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
153
f66c7cf8
PE
154 Variadic C functions now count arguments with ptrdiff_t.
155 This partly undoes my 2011-03-30 change, which replaced int with size_t.
156 Back then I didn't know that the Emacs coding style prefers signed int.
157 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
158 were being counted with int, which may truncate counts on 64-bit
159 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
160 * lisp.h (struct Lisp_Subr.function.aMANY)
161 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
162 Arg counts are now ptrdiff_t, not size_t.
163 All variadic functions and their callers changed accordingly.
164 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
165 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
166 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
167 * callint.c (Fcall_interactively): Check arg count for overflow,
168 to avoid potential buffer overrun. Use signed char, not 'int',
169 for 'varies' array, so that we needn't bother to check its size
170 calculation for overflow.
171 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
172 * eval.c (apply_lambda):
173 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
174 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
175 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
176
a1759b76
PE
177 * callint.c (Fcall_interactively): Don't use index var as event count.
178
d96be9fc
PE
179 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
180 * mem-limits.h (SIZE): Remove; no longer used.
181
a690a978 182 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 183
578c21e6
PE
184 Remove unnecessary casts.
185 * xterm.c (x_term_init):
186 * xfns.c (x_set_border_pixel):
187 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
188 These aren't needed now that we assume ANSI C.
189
96f53c6c
PE
190 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
191 It's more likely to cause problems (due to unsigned overflow)
192 than to cure them.
193
83c77d31
PE
194 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
195
ee2079f1
PE
196 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
197
6da65536
PE
198 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
199
7147c4a4
PE
200 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
201
193e32d9
PE
202 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
203
e5533da6
PE
204 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
205
9910e595
PE
206 GLYPH_CODE_FACE returns EMACS_INT, not int.
207 * dispextern.h (merge_faces):
208 * xfaces.c (merge_faces):
01103c44
PE
209 * xdisp.c (get_next_display_element, next_element_from_display_vector):
210 Don't assume EMACS_INT fits in int.
9910e595 211
2638320e
PE
212 * character.h (CHAR_VALID_P): Remove unused parameter.
213 * fontset.c, lisp.h, xdisp.c: All uses changed.
214
045eb8d9
PE
215 * editfns.c (Ftranslate_region_internal): Omit redundant test.
216
c1f134b5
PE
217 * fns.c (concat): Minor tuning based on overflow analysis.
218 This doesn't fix any bugs. Use int to hold character, instead
219 of constantly refetching from Emacs object. Use XFASTINT, not
220 XINT, for value known to be a character. Don't bother comparing
221 a single byte to 0400, as it's always less.
222
395fcb93 223 * floatfns.c (Fexpt):
327eeec8
PE
224 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
225
abbd3d23
PE
226 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
227 for characters.
228
684a03ef
PE
229 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
230
0fed43f3
PE
231 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
232 Without this fix, on a 64-bit host (aset S 0 4294967386) would
233 incorrectly succeed when S was a string, because 4294967386 was
234 truncated before it was used.
235
8fd02eb7
PE
236 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
237 Otherwise, an out-of-range integer could cause undefined behavior
238 on a 64-bit host.
239
f8c86b69
PE
240 * composite.c: Use int, not EMACS_INT, for characters.
241 (fill_gstring_body, composition_compute_stop_pos): Use int, not
242 EMACS_INT, for values that are known to be in character range.
243 This doesn't fix any bugs but is the usual style inside Emacs and
244 may generate better code on 32-bit machines.
245
34206dd2
PE
246 Make sure a 64-bit char is never passed to ENCODE_CHAR.
247 This is for reasons similar to the recent CHAR_STRING fix.
248 * charset.c (Fencode_char): Check that character arg is actually
249 a character. Pass an int to ENCODE_CHAR.
250 * charset.h (ENCODE_CHAR): Verify that the character argument is no
251 wider than 'int', as a compile-time check to prevent future regressions
252 in this area.
253
c5958d4c 254 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
255
256 Make sure a 64-bit char is never passed to CHAR_STRING.
257 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
258 by silently ignoring the top 32 bits, allowing some values
259 that were far too large to be valid characters.
260 * character.h: Include <verify.h>.
261 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
262 arguments are no wider than unsigned, as a compile-time check
263 to prevent future regressions in this area.
264 * data.c (Faset):
01103c44 265 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
266 (Fsubst_char_in_region):
267 * fns.c (concat):
268 * xdisp.c (decode_mode_spec_coding):
269 Adjust to CHAR_STRING's new requirement.
270 * editfns.c (Finsert_char, Fsubst_char_in_region):
271 * fns.c (concat): Check that character args are actually
272 characters. Without this test, these functions did the wrong
273 thing with wildly out-of-range values on 64-bit hosts.
274
d37ca623
PE
275 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
276 These casts should not be needed on 32-bit hosts, either.
277 * keyboard.c (read_char):
278 * lread.c (Fload): Remove casts to unsigned.
279
ea204efb
PE
280 * lisp.h (UNSIGNED_CMP): New macro.
281 This fixes comparison bugs on 64-bit hosts.
282 (ASCII_CHAR_P): Use it.
283 * casefiddle.c (casify_object):
01103c44 284 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
285 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
286 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
287 * dispextern.h (FACE_FROM_ID):
288 * keyboard.c (read_char): Use UNSIGNED_CMP.
289
41cb286c
PE
290 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
291 not to EMACS_INT, to avoid GCC warning.
292
4a1b9832
PE
293 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
294
55daad71
PE
295 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
296 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
297 isn't needed on 32-bit machines.
8f95c75c 298
01103c44
PE
299 * buffer.c (Fgenerate_new_buffer_name):
300 Use EMACS_INT for count, not int.
0ceccced 301 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
302
303 * data.c (Qcompiled_function): Now static.
304
c6f072e7
PE
305 * window.c (window_body_lines): Now static.
306
20ce5912
PE
307 * image.c (gif_load): Rename local to avoid shadowing.
308
9c4c5f81
PE
309 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
310 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
311 * alloc.c (make_save_value): Integer argument is now of type
312 ptrdiff_t, not int.
313 (mark_object): Use ptrdiff_t, not int.
314 * lisp.h (pD): New macro.
315 * print.c (print_object): Use it.
316
c0c5c8ae
PE
317 * alloc.c: Use EMACS_INT, not int, to count objects.
318 (total_conses, total_markers, total_symbols, total_vector_size)
319 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
320 (total_free_floats, total_floats, total_free_intervals)
321 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
322 Now EMACS_INT, not int. All uses changed.
323 (Fgarbage_collect): Compute overall total using a double, so that
324 integer overflow is less likely to be a problem. Check for overflow
325 when converting back to an integer.
5a25e253
PE
326 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
327 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
328 These were 'int' variables that could overflow on 64-bit hosts;
329 they were never used, so remove them instead of repairing them.
211a0b2a 330 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
331 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
332 Previously, this ceilinged at INT_MAX, but that doesn't work on
333 64-bit machines.
e46bb31a 334 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 335
c78baabf 336 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 337 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
338 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
339 when a (possibly-narrower) signed value would do just as well.
340 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 341
c9d624c6
PE
342 * alloc.c: Catch some string size overflows that we were missing.
343 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
344 for convenience in STRING_BYTES_MAX.
345 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
346 The definition here is exact; the one in lisp.h was approximate.
347 (allocate_string_data): Check for string overflow. This catches
348 some instances we weren't catching before. Also, it catches
349 size_t overflow on (unusual) hosts where SIZE_MAX <= min
350 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
351 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 352
c9d624c6
PE
353 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
354 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
355 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
356
353032ce
PE
357 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
358
2bccce07
PE
359 * alloc.c (Fmake_string): Check for out-of-range init.
360
0ac30604
SM
3612011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
364
c195f2de
JD
3652011-06-14 Jan Djärv <jan.h.d@swipnet.se>
366
367 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
368 xg_get_default_scrollbar_width.
369
370 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
371 (int_gtk_range_get_value): Move to the scroll bar part of the file.
372 (style_changed_cb): Call update_theme_scrollbar_width and call
373 x_set_scroll_bar_default_width and xg_frame_set_char_size for
374 all frames (Bug#8505).
375 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
376 Call gtk_window_set_resizable if HAVE_GTK3.
377 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
378 and height if HAVE_GTK3 (Bug#8505).
379 (scroll_bar_width_for_theme): New variable.
380 (update_theme_scrollbar_width): New function.
381 (xg_get_default_scrollbar_width): Move code to
382 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
383 (xg_initialize): Call update_theme_scrollbar_width.
384
385 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
386
387 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
388
e10ac9f1
MR
3892011-06-12 Martin Rudalics <rudalics@gmx.at>
390
391 * frame.c (make_frame): Call other_buffer_safely instead of
392 other_buffer.
393
394 * window.c (temp_output_buffer_show): Call display_buffer with
395 second argument Vtemp_buffer_show_specifiers and reset latter
396 immediately after the call.
397 (Vtemp_buffer_show_specifiers): New variable.
398 (auto_window_vscroll_p, next_screen_context_lines)
399 (Vscroll_preserve_screen_position): Remove leading asterisks from
400 doc-strings.
401
2d3c217e 4022011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 403
7b7f97e8 404 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
405 * buffer.c (Qclone_number): Remove for now, as it's unused.
406 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
407 (record_buffer): Remove unused local.
408 * frame.c (other_visible_frames, frame_buffer_list): Now static.
409 (set_frame_buffer_list): Remove; unused.
410 * frame.h (other_visible_frames): Remove decl.
411 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
412 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
413 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
414 if HAVE_GPM.
415 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
416 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
417 Define only if HAVE_GPM.
418 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
419 (update_hints_inhibit): Remove; never set. All uses removed.
420 * widgetprv.h (emacsFrameClassRec): Remove decl.
421 * window.c (delete_deletable_window): Now returns void, since it
422 wasn't returning anything.
423 (compare_window_configurations): Remove unused locals.
424 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
425 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
426 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
427 the same widths as pointers. This follows up on the 2011-05-06 patch.
428 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
429 * xterm.h: Likewise.
430 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
431
1384b89e
JB
4322011-06-12 Juanma Barranquero <lekktu@gmail.com>
433
434 * makefile.w32-in: Update dependencies.
435 (LISP_H): Add lib/intprops.h.
436
1100a63c
CY
4372011-06-11 Chong Yidong <cyd@stupidchicken.com>
438
439 * image.c (gif_load): Add animation frame delay to the metadata.
440 (syms_of_image): Use DEFSYM. New symbol `delay'.
441
6198ccd0
MR
4422011-06-11 Martin Rudalics <rudalics@gmx.at>
443
444 * window.c (delete_deletable_window): Re-add.
445 (Fset_window_configuration): Rewrite to handle dead buffers and
446 consequently deletable windows.
447 (window_tree, Fwindow_tree): Remove. Supply functionality in
448 window.el.
449 (compare_window_configurations): Simplify code.
450
b6e3633c
AS
4512011-06-11 Andreas Schwab <schwab@linux-m68k.org>
452
1ab0dee5
AS
453 * image.c (imagemagick_load_image): Fix type mismatch.
454 (Fimagemagick_types): Likewise.
455
b6e3633c
AS
456 * window.h (replace_buffer_in_windows): Declare.
457
9397e56f
MR
4582011-06-11 Martin Rudalics <rudalics@gmx.at>
459
460 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
461 Qclone_number. Remove external declaration of Qdelete_window.
462 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
463 code.
464 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
465 Qbuffer_list_update_hook if allowed.
466 (Fother_buffer): Rewrite doc-string. Major rewrite for new
467 buffer list implementation.
468 (other_buffer_safely): New function.
469 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
470 calls to replace_buffer_in_windows and
471 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
472 if allowed.
473 (record_buffer): Inhibit quitting and rewrite using quittable
474 functions. Run Qbuffer_list_update_hook if allowed.
475 (Frecord_buffer, Funrecord_buffer): New functions.
476 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
477 switch-to-buffer to window.el.
478 (bury-buffer): Move to window.el.
479 (Vbuffer_list_update_hook): New variable.
480
481 * lisp.h (other_buffer_safely): Add prototype in buffer.c
482 section.
483
484 * window.h (resize_frame_windows): Move up in code.
485 (Fwindow_frame): Remove EXFUN.
486 (replace_buffer_in_all_windows): Remove prototype.
487 (replace_buffer_in_windows_safely): Add prototype.
488
489 * window.c: Declare Qdelete_window static again. Move down
490 declaration of select_count.
491 (Fnext_window, Fprevious_window): Rewrite doc-strings.
492 (Fother_window): Move to window.el.
493 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
494 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
495 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
496 window.el.
497 (replace_buffer_in_windows): Implement by calling
498 Qreplace_buffer_in_windows.
499 (replace_buffer_in_all_windows): Remove with some functionality
500 moved into replace_buffer_in_windows_safely.
501 (replace_buffer_in_windows_safely): New function.
502 (select_window_norecord, select_frame_norecord): Move in front
503 of run_window_configuration_change_hook. Remove now obsolete
504 declarations.
505 (Fset_window_buffer): Rewrite doc-string. Call
506 Qrecord_window_buffer.
507 (keys_of_window): Move binding for other-window to window.el.
508
b50691aa
CY
5092011-06-11 Chong Yidong <cyd@stupidchicken.com>
510
511 * dispextern.h (struct image): Replace data member, whose int_val
512 and ptr_val fields were not used by anything, with a single
513 lisp_val object.
514
515 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
516 (gif_clear_image, gif_load, imagemagick_load_image)
517 (gs_clear_image, gs_load): Callers changed.
518
3f754b86
PE
5192011-06-10 Paul Eggert <eggert@cs.ucla.edu>
520
cca69397
PE
521 * buffer.h: Include <time.h>, for time_t.
522 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
523
109e28d0
PE
524 Fix minor problems found by static checking.
525
60737f02
PE
526 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
527
4b66faf3
PE
528 Make identifiers static if they are not used in other modules.
529 * data.c (Qcompiled_function, Qframe, Qvector):
530 * image.c (QimageMagick, Qsvg):
531 * minibuf.c (Qmetadata):
532 * window.c (resize_window_check, resize_root_window): Now static.
533 * window.h (resize_window_check, resize_root_window): Remove decls.
534
109e28d0
PE
535 * window.c (window_deletion_count, delete_deletable_window):
536 Remove; unused.
46a4ce9e
PE
537 (window_body_lines): Now static.
538 (Fdelete_other_windows_internal): Mark vars as initialized.
539 Make sure 'resize_failed' is initialized.
540 (run_window_configuration_change_hook): Rename local to avoid shadowing.
541 (resize_window_apply): Remove unused local.
542 * window.h (delete_deletable_window): Remove decl.
543
109e28d0 544 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
545 (imagemagick_load_image): Fix pointer signedness problem by changing
546 last arg from unsigned char * to char *. All uses changed.
547 Also, fix a local for similar reasons.
548 Remove unused locals. Remove locals to avoid shadowing.
549 (fn_rsvg_handle_free): Remove; unused.
550 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 551 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 552
3f754b86
PE
553 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
554
2547adb1
CY
5552011-06-10 Chong Yidong <cyd@stupidchicken.com>
556
557 * image.c (gif_load): Fix omitted cast error introduced by
558 2011-06-06 change.
559
2c8e37d4
MR
5602011-06-10 Martin Rudalics <rudalics@gmx.at>
561
562 * window.h (resize_proportionally, orig_total_lines)
563 (orig_top_line): Remove from window structure.
564 (set_window_height, set_window_width, change_window_heights)
565 (Fdelete_window): Remove prototypes.
566 (resize_frame_windows): Remove duplicate declaration.
567
440a42e3
EZ
5682011-06-10 Eli Zaretskii <eliz@gnu.org>
569
570 * window.h (resize_frame_windows, resize_window_check)
571 (delete_deletable_window, resize_root_window)
572 (resize_frame_windows): Declare prototypes.
573
574 * window.c (resize_window_apply): Make definition be "static" to
575 match the prototype.
576
562dd5e9
MR
5772011-06-10 Martin Rudalics <rudalics@gmx.at>
578
579 * window.c: Remove declarations of Qwindow_size_fixed,
580 window_min_size_1, window_min_size_2, window_min_size,
581 size_window, window_fixed_size_p, enlarge_window, delete_window.
582 Remove static from declaration of Qdelete_window, it's
583 temporarily needed by Fbury_buffer.
584 (replace_window): Don't assign orig_top_line and
585 orig_total_lines.
586 (Fdelete_window, delete_window): Remove. Window deletion is
587 handled by window.el.
588 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
589 Fdelete_window calls with calls to Qdelete_window.
590 (Fdelete_other_windows): Remove. Deleting other windows is
591 handled by window.el.
592 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
593 handled in window.el.
594 (window_min_size_2, window_min_size_1, window_min_size): Remove.
595 Window minimum sizes are handled in window.el.
596 (shrink_windows, size_window, set_window_height)
597 (set_window_width, change_window_heights, window_height)
598 (window_width, CURBEG, CURSIZE, enlarge_window)
599 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
600 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
601 handled in window.el.
602 (make_dummy_parent): Rename to make_parent_window and give it a
603 second argument horflag.
604 (make_window): Don't set resize_proportionally any more.
605 (Fsplit_window): Remove. Windows are split in window.el.
606 (save_restore_action, save_restore_orig_size)
607 (shrink_window_lowest_first, save_restore_orig_size): Remove.
608 Resize mini windows in window.el.
609 (grow_mini_window, shrink_mini_window): Implement by calling
610 Qresize_root_window_vertically, resize_window_check and
611 resize_window_apply.
612 (saved_window, Fset_window_configuration, save_window_save): Do
613 not handle orig_top_line, orig_total_lines, and
614 resize_proportionally.
615 (window_min_height, window_min_width): Move to window.el.
616 (keys_of_window): Move bindings for delete-other-windows,
617 split-window, delete-window and enlarge-window to window.el.
618
619 * buffer.c: Temporarily extern Qdelete_window.
620 (Fbury_buffer): Temporarily call Qdelete_window instead of
621 Fdelete_window (Fbury_buffer will move to window.el soon).
622
623 * frame.c (set_menu_bar_lines_1): Remove code handling
624 orig_top_line and orig_total_lines.
625
626 * dispnew.c (adjust_frame_glyphs_initially): Don't use
627 set_window_height but set heights directly.
628 (change_frame_size_1): Use resize_frame_windows.
629
630 * xdisp.c (init_xdisp): Don't use set_window_height but set
631 heights directly.
632
633 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
634 resize_frame_windows instead of change_window_heights and run
635 run_window_configuration_change_hook.
636
637 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
638 instead of change_window_heights and run
639 run_window_configuration_change_hook.
640
1a13852e
MR
6412011-06-09 Martin Rudalics <rudalics@gmx.at>
642
643 * window.c (replace_window): Rename second argument REPLACEMENT to
644 NEW. New third argument SETFLAG. Rewrite.
645 (delete_window, make_dummy_parent): Call replace_window with
646 third argument 1.
647 (window_list_1): Move down in code.
648 (run_window_configuration_change_hook): Move set_buffer part
649 before select_frame_norecord part in order to unwind correctly.
650 Rename count1 to count.
651 (recombine_windows, delete_deletable_window, resize_root_window)
652 (Fdelete_other_windows_internal)
653 (Frun_window_configuration_change_hook, make_parent_window)
654 (resize_window_check, resize_window_apply, Fresize_window_apply)
655 (resize_frame_windows, Fsplit_window_internal)
656 (Fdelete_window_internal, Fresize_mini_window_internal): New
657 functions.
658 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
659
f3d1777e
MR
6602011-06-08 Martin Rudalics <rudalics@gmx.at>
661
496e208e
MR
662 * window.h (window): Add some new members to window structure -
663 normal_lines, normal_cols, new_total, new_normal, clone_number,
664 splits, nest, prev_buffers, next_buffers.
665 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 666 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 667
f3d1777e
MR
668 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
669 Remove.
496e208e
MR
670 (make_dummy_parent): Set new members of windows structure.
671 (make_window): Move down in code. Handle new members of window
672 structure.
673 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
674 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
675 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
676 (Fset_window_prev_buffers, Fwindow_next_buffers)
677 (Fset_window_next_buffers, Fset_window_clone_number): New
678 functions.
679 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
680 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
681 Doc-string fixes.
682 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
683 Argument WINDOW can be now internal window too.
684 (Fwindow_use_time): Move up in code.
685 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
686 Rewrite doc-string.
687 (Fset_window_configuration, saved_window)
688 (Fcurrent_window_configuration, save_window_save): Handle new
689 members of window structure.
b9e809c2
MR
690 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
691 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
692 (syms_of_window): New Lisp objects Qrecord_window_buffer,
693 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
694 Qget_mru_window, Qresize_root_window,
695 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
696 Qauto_buffer_name; staticpro them.
f3d1777e 697
abde8f8c
MR
6982011-06-07 Martin Rudalics <rudalics@gmx.at>
699
700 * window.c (Fwindow_total_size, Fwindow_left_column)
701 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
702 (Fwindow_list_1): New functions.
703 (window_box_text_cols): Replace with window_body_cols.
704 (Fwindow_width, Fscroll_left, Fscroll_right): Use
705 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
706 (delete_window, Fset_window_configuration): Call
707 delete_all_subwindows with window as argument.
708 (delete_all_subwindows): Take a window as argument and not a
709 structure. Rewrite.
190b47e6
MR
710 (window_loop): Remove handling of GET_LRU_WINDOW and
711 GET_LARGEST_WINDOW.
712 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
713
714 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
715 window_box_text_cols. delete_all_subwindows now takes a
716 Lisp_Object as argument.
abde8f8c
MR
717
718 * indent.c (compute_motion, Fcompute_motion): Use
719 window_body_cols instead of window_box_text_cols.
720
fa8a67e6
MR
721 * frame.c (delete_frame): Call delete_all_subwindows with root
722 window as argument.
723
a54e3482
DC
7242011-06-07 Daniel Colascione <dan.colascione@gmail.com>
725
726 * fns.c (Fputhash): Document return value.
727
60002bf5
CY
7282011-06-06 Chong Yidong <cyd@stupidchicken.com>
729
730 * image.c (gif_load): Implement gif89a spec "no disposal" method.
731
0c671da6 7322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 733
b862a52a 734 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 735
be44ca6c
PE
736 Check for overflow when converting integer to cons and back.
737 * charset.c (Fdefine_charset_internal, Fdecode_char):
738 Use cons_to_unsigned to catch overflow.
739 (Fencode_char): Use INTEGER_TO_CONS.
740 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
741 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
742 * data.c (long_to_cons, cons_to_long): Remove.
743 (cons_to_unsigned, cons_to_signed): New functions.
744 These signal an error for invalid or out-of-range values.
745 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
746 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
747 * font.c (Ffont_variation_glyphs):
748 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
749 * lisp.h: Include <intprops.h>.
750 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
751 (cons_to_signed, cons_to_unsigned): New decls.
752 (long_to_cons, cons_to_long): Remove decls.
753 * undo.c (record_first_change): Use INTEGER_TO_CONS.
754 (Fprimitive_undo): Use CONS_TO_INTEGER.
755 * xfns.c (Fx_window_property): Likewise.
756 * xselect.c: Include <limits.h>.
757 (x_own_selection, selection_data_to_lisp_data):
758 Use INTEGER_TO_CONS.
759 (x_handle_selection_request, x_handle_selection_clear)
760 (x_get_foreign_selection, Fx_disown_selection_internal)
761 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
762 (lisp_data_to_selection_data): Use cons_to_unsigned.
763 (x_fill_property_data): Use cons_to_signed.
764 Report values out of range.
765
d1f3d2af
PE
766 Check for buffer and string overflow more precisely.
767 * buffer.h (BUF_BYTES_MAX): New macro.
768 * lisp.h (STRING_BYTES_MAX): New macro.
769 * alloc.c (Fmake_string):
770 * character.c (string_escape_byte8):
771 * coding.c (coding_alloc_by_realloc):
772 * doprnt.c (doprnt):
773 * editfns.c (Fformat):
774 * eval.c (verror):
775 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
776 since they may not be the same number.
777 * editfns.c (Finsert_char):
778 * fileio.c (Finsert_file_contents):
779 Likewise for BUF_BYTES_MAX.
780
dd52fcea
PE
781 * image.c: Use ptrdiff_t, not int, for sizes.
782 (slurp_file): Switch from int to ptrdiff_t.
783 All uses changed.
784 (slurp_file): Check that file size fits in both size_t (for
785 malloc) and ptrdiff_t (for sanity and safety).
786
7f9bbdbb
PE
787 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
788 if b->modtime has its maximal value.
789
dfe18f82
PE
790 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
791
84acfcf0
PE
792 Don't assume time_t can fit into int.
793 * buffer.h (struct buffer.modtime): Now time_t, not int.
794 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
795 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
796
ccd9a01a
PE
797 Minor fixes for signed vs unsigned integers.
798 * character.h (MAYBE_UNIFY_CHAR):
799 * charset.c (maybe_unify_char):
800 * keyboard.c (read_char, reorder_modifiers):
801 XINT -> XFASTINT, since the integer must be nonnegative.
802 * ftfont.c (ftfont_spec_pattern):
803 * keymap.c (access_keymap, silly_event_symbol_error):
804 XUINT -> XFASTINT, since the integer must be nonnegative.
805 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
806 since it makes no difference and we prefer signed.
807 * keyboard.c (record_char): Use XUINT when all the neighbors do.
808 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
809 nonnegative.
810
d6d100dd
SM
8112011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
812
813 * window.h (Fwindow_frame): Declare.
814
2b6148e4
PE
8152011-06-06 Paul Eggert <eggert@cs.ucla.edu>
816
817 * alloc.c: Simplify handling of large-request failures (Bug#8800).
818 (SPARE_MEMORY): Always define.
819 (LARGE_REQUEST): Remove.
820 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
821
f230ecc9
MR
8222011-06-06 Martin Rudalics <rudalics@gmx.at>
823
727e958e
MR
824 * lisp.h: Move EXFUNS for Fframe_root_window,
825 Fframe_first_window and Fset_frame_selected_window to window.h.
826
827 * window.h: Move EXFUNS for Fframe_root_window,
828 Fframe_first_window and Fset_frame_selected_window here from
829 lisp.h.
830
831 * frame.c (Fwindow_frame, Fframe_first_window)
832 (Fframe_root_window, Fframe_selected_window)
833 (Fset_frame_selected_window): Move to window.c.
834 (Factive_minibuffer_window): Move to minibuf.c.
835 (Fother_visible_frames_p): New function.
836
837 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
838
f230ecc9
MR
839 * window.c (decode_window, decode_any_window): Move up in code.
840 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
841 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
842 (Fwindow_buffer): Move up and rewrite doc-string.
843 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
844 (Fwindow_prev): New functions.
727e958e
MR
845 (Fwindow_frame): Move here from frame.c. Accept any window as
846 argument.
847 (Fframe_root_window, Fframe_first_window)
848 (Fframe_selected_window): Move here from frame.c. Accept frame
849 or arbitrary window as argument. Update doc-strings.
850 (Fminibuffer_window): Move up in code.
851 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
852 (Fset_frame_selected_window): Move here from frame.c.
853 Marginal rewrite.
727e958e
MR
854 (Fselected_window, select_window, Fselect_window): Move up in
855 code. Minor doc-string fixes.
f230ecc9 856
4d09bcf6
PE
8572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
858
859 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
860 Do not assume that spare memory exists; that assumption is valid
861 only if SYSTEM_MALLOC.
862 (LARGE_REQUEST): New macro, so that the issue of large requests
863 is separated from the issue of spare memory.
864
810928a2
AS
8652011-06-05 Andreas Schwab <schwab@linux-m68k.org>
866
172418ad
AS
867 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
868 format. (Bug#8806)
869
43f862f7
AS
870 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
871
810928a2
AS
872 * xfns.c (x_set_scroll_bar_default_width): Move declarations
873 before statements.
874
a059fe24
JD
8752011-06-05 Jan Djärv <jan.h.d@swipnet.se>
876
877 * gtkutil.c (xg_get_default_scrollbar_width): New function.
878
879 * gtkutil.h: Declare xg_get_default_scrollbar_width.
880
881 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
882 min width by calling x_set_scroll_bar_default_width (Bug#8505).
883
989bf368
JB
8842011-06-05 Juanma Barranquero <lekktu@gmail.com>
885
886 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
887
4b80f674
CY
8882011-06-04 Chong Yidong <cyd@stupidchicken.com>
889
890 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
891 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
892 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
893 New error handlers.
4b80f674
CY
894 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
895 Obey Vx_select_enable_clipboard_manager. Catch errors in
896 x_clipboard_manager_save (Bug#8779).
897 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 898 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 899
99a33b77 9002011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
901
902 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
903
99a33b77 9042011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
905
906 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
907 in the current matrix if keep_current_p is non-zero.
908
8264569d
EZ
9092011-06-04 Eli Zaretskii <eliz@gnu.org>
910
911 * bidi.c (bidi_level_of_next_char): Fix last change.
912
57f97249
EZ
9132011-06-03 Eli Zaretskii <eliz@gnu.org>
914
fec2107c 915 Support bidi reordering of text covered by display properties.
57f97249 916
fec2107c
EZ
917 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
918 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
919 (bidi_cache_search, bidi_cache_iterator_state)
920 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
921 (bidi_level_of_next_char, bidi_move_to_visually_next):
922 Support character positions inside a run of characters covered by a
fec2107c
EZ
923 display string.
924 (bidi_paragraph_init, bidi_resolve_explicit_1)
925 (bidi_level_of_next_char): Call bidi_fetch_char and
926 bidi_fetch_char_advance instead of FETCH_CHAR and
927 FETCH_CHAR_ADVANCE.
928 (bidi_init_it): Initialize new members.
929 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
930 definitions.
931 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
932 instead of using explicit *_CHAR codes.
d6d100dd
SM
933 (bidi_resolve_explicit, bidi_resolve_weak):
934 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
935 bidirectional text is supported only in multibyte buffers.
936 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
937 it to initialize the frame_window_p member of struct bidi_it.
938 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
939 (bidi_resolve_explicit, bidi_resolve_weak)
940 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
941 bidi_it->nchars is non-positive.
942 (bidi_level_of_next_char): Don't try to lookup the cache for the
943 next/previous character if nothing is cached there yet, or if we
944 were just reseat()'ed to a new position.
c40e2fb2 945
0e14fe90
EZ
946 * xdisp.c (set_cursor_from_row): Set start and stop points
947 according to the row's direction when priming the loop that looks
948 for the glyph on which to display cursor.
949 (single_display_spec_intangible_p): Function deleted.
950 (display_prop_intangible_p): Reimplement to call
951 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
952 Accept 3 additional arguments needed by handle_display_spec.
953 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
954 values: lists, `(when COND...)' forms, etc.
955 (single_display_spec_string_p): Support property values that are
956 lists with the argument STRING its top-level element.
957 (display_prop_string_p): Fix the condition for processing a
958 property that is a list to be consistent with handle_display_spec.
fec2107c 959 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
960 last portion of handle_display_prop.
961 (compute_display_string_pos): Accept additional argument
962 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
963 value of a `display' property is a "replacing spec".
964 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
965 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
966 the display property, but just return a value indicating whether
967 the display property will replace the characters it covers.
968 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
969 frame_window_p members of struct bidi_it.
d6d100dd
SM
970 (compute_display_string_pos, compute_display_string_end):
971 New functions.
fec2107c
EZ
972 (push_it): Accept second argument POSITION, where pop_it should
973 jump to continue iteration.
974 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 975
fec2107c
EZ
976 * keyboard.c (adjust_point_for_property): Adjust the call to
977 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
978
979 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
980 (bidi_init_it): Update prototypes.
981 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
982 (compute_display_string_pos, compute_display_string_end):
983 Declare prototypes.
fec2107c
EZ
984 (struct bidi_it): New members nchars and disp_pos. ch_len is now
985 EMACS_INT.
fc6f18ce 986
40087514 9872011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 988
57f53182
PE
989 Malloc failure behavior now depends on size of allocation.
990 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
991 * lisp.h: Change signatures accordingly.
992 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
993 All callers changed. (Bug#8762)
994
995 * gnutls.c: Use Emacs's memory allocators.
996 Without this change, the gnutls library would invoke malloc etc.
997 directly, which causes problems on non-SYNC_INPUT hosts, and which
998 runs afoul of improving memory_full behavior. (Bug#8761)
999 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1000 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1001 xfree instead of the default malloc, realloc, free.
1002 (Fgnutls_boot): No need to check for memory allocation failure,
1003 since xmalloc does that for us.
1004
ac32cd99 1005 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1006 * category.c (hash_get_category_set):
1007 * ccl.c (ccl_driver):
1008 * charset.c (Fdefine_charset_internal):
1009 * charset.h (struct charset.hash_index):
1010 * composite.c (get_composition_id, gstring_lookup_cache)
1011 (composition_gstring_put_cache):
1012 * composite.h (struct composition.hash_index):
1013 * dispextern.h (struct image.hash):
1014 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1015 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1016 (hashfn_equal, hashfn_user_defined, make_hash_table)
1017 (maybe_resize_hash_table, hash_lookup, hash_put)
1018 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1019 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1020 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1021 * image.c (make_image, search_image_cache, lookup_image)
1022 (xpm_put_color_table_h):
1023 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1024 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1025 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1026 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1027 * alloc.c (allocate_vectorlike):
1028 Check for overflow in vector size calculations.
1029 * ccl.c (ccl_driver):
1030 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1031 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1032 need to be updated by these changes.
40087514
PE
1033 * fns.c (make_hash_table, maybe_resize_hash_table):
1034 Check for integer overflow with large hash tables.
0de4bb68
PE
1035 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1036 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1037 (SXHASH_REDUCE): New macro.
1038 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1039 Use it instead of discarding useful hash info with large hash values.
1040 (sxhash_float): New function.
1041 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1042 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1043 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1044 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1045 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1046 Adjust signatures to match updated version of code.
1047 (consing_since_gc): Now EMACS_INT, since a single hash table can
1048 use more than INT_MAX bytes.
1049
698d32e2
DN
10502011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1051
1052 Make it possible to build with GCC-4.6+ -O2 -flto.
1053
1054 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1055
fd6fa53f
SM
10562011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1057
1058 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1059 Call minibuffer-inactive-mode.
1060
864db017
JB
10612011-05-31 Juanma Barranquero <lekktu@gmail.com>
1062
1063 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1064 Update dependencies.
1065
2ad0baf4
DN
10662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1067
1068 * data.c (init_data): Remove code for UTS, this system is not
1069 supported anymore.
1070
4fcc2638
DN
10712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1072
1073 Don't force ./temacs to start in terminal mode.
1074
1075 * frame.c (make_initial_frame): Initialize faces in all cases, not
1076 only when CANNOT_DUMP is defined.
1077 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1078
c56e0fd5
DN
10792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1080
1081 * dispnew.c (add_window_display_history): Use const for the string
1082 pointer. Remove declaration, not needed.
1083
333d54da 10842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1085
55d4c1b2 1086 Use 'inline', not 'INLINE'.
333d54da 1087 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1088 * alloc.c, fontset.c (INLINE): Remove.
1089 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1090 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1091 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1092 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1093 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1094
738db178
DN
10952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1096
1097 Make it possible to run ./temacs.
1098
1099 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1100 syms_of_callproc does the same thing. Remove test for
1101 "initialized", do it in the caller.
1102 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1103
620c53a6
SM
11042011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1105
1106 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1107 (read_minibuf): Use get_minibuffer.
1108 (syms_of_minibuf): Use DEFSYM.
1109 (Qmetadata): New var.
1110 * data.c (Qbuffer): Don't make it static.
1111 (syms_of_data): Use DEFSYM.
1112
e003a292
PE
11132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1114
1115 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1116 (CCL_CODE_MIN): New macro.
1117
ed008a6d
PE
11182011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1119
3687c2ef
PE
1120 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1121
ed008a6d
PE
1122 * eval.c (Qdebug): Now static.
1123 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1124 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1125 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1126
d66c4c7c
CY
11272011-05-29 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * image.c: Various fixes to ImageMagick code comments.
1130 (Fimagemagick_types): Doc fix.
1131
5fbc2025
PE
11322011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1133
0196f88a
PE
1134 Minor fixes prompted by GCC 4.6.0 warnings.
1135
1136 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1137
5fbc2025
PE
1138 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1139 (x_clipboard_manager_save_all): Move extern decl to ...
1140 * xterm.h: ... here, so that it can be checked for consistency.
1141
1dd3c2d9
CY
11422011-05-29 Chong Yidong <cyd@stupidchicken.com>
1143
1144 * xselect.c (x_clipboard_manager_save_frame)
1145 (x_clipboard_manager_save_all): New functions.
1146 (Fx_clipboard_manager_save): Lisp function deleted.
1147
1148 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1149 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1150
1151 * xterm.h: Update prototype.
1152
5ba6571d
WX
11532011-05-28 William Xu <william.xwl@gmail.com>
1154
1155 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1156 exiting (Bug#8239).
1157
3eaff834
JM
11582011-05-28 Jim Meyering <meyering@redhat.com>
1159
e1900994 1160 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1161 * fns.c (to_uchar): Define.
1162 (crypto_hash_function): Use it to convert some newly-signed
1163 variables to unsigned, to avoid sign-extension bugs. For example,
1164 without this change, (md5 "truc") would evaluate to
1165 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1166 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1167 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1168
0f6990a7
PE
11692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 Integer overflow fixes.
c8a9ca5a 1172
08686060
PE
1173 * dbusbind.c: Serial number integer overflow fixes.
1174 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1175 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1176 to hold a serial number that is too large for a fixnum.
1177 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1178 Check for serial numbers out of range. Decode any serial number
59568bf0 1179 that was so large that it became a float. (Bug#8722)
08686060 1180
2d1fc3c7
PE
1181 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1182 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1183 Use XFASTINT rather than XUINT when numbers are nonnegative.
1184 (xd_append_arg, Fdbus_method_return_internal):
1185 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1186 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1187 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1188 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1189 (Bug#8722)
2d1fc3c7 1190
c8a9ca5a
PE
1191 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1192
519e1d69
PE
1193 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1194
30569699
PE
1195 ccl: add integer overflow checks
1196 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1197 (IN_INT_RANGE): New macros.
1198 (ccl_driver): Use them to check for integer overflow when
1199 decoding a CCL program. Many of the new checks are whether XINT (x)
1200 fits in int; it doesn't always, on 64-bit hosts. The new version
1201 doesn't catch all possible integer overflows, but it's an
847044ea 1202 improvement. (Bug#8719)
30569699 1203
c11285dc
PE
1204 * alloc.c (make_event_array): Use XINT, not XUINT.
1205 There's no need for unsigned here.
1206
fdccd48e
PE
1207 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1208 This follows up to the 2011-05-06 change that substituted uintptr_t
1209 for EMACS_INT. This case wasn't caught back then.
1210
37910ab2
PE
1211 Rework Fformat to avoid integer overflow issues.
1212 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1213 now (part of C89). Include <verify.h>.
1214 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1215 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1216 (Fformat): Avoid the prepass trying to compute sizes; it was only
1217 approximate and thus did not catch overflow reliably. Instead, walk
1218 through the format just once, formatting and computing sizes as we go,
1219 checking for integer overflow at every step, and allocating a larger
1220 buffer as needed. Keep track separately whether the format is
1221 multibyte. Keep only the most-recently calculated precision, rather
1222 than them all. Record whether each argument has been converted to
1223 string. Use EMACS_INT, not int, for byte and char and arg counts.
1224 Support field widths and precisions larger than INT_MAX. Avoid
1225 sprintf's undefined behavior with conversion specifications such as %#d
1226 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1227 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1228 formatting out-of-range floating point numbers with int
1229 formats. (Bug#8668)
1230
2e6578fb
PE
1231 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1232
0ae6bdee
PE
1233 * data.c: Avoid integer truncation in expressions involving floats.
1234 * data.c: Include <intprops.h>.
1235 (arith_driver): When there's an integer overflow in an expression
1236 involving floating point, convert the integers to floating point
1237 so that the resulting value does not suffer from catastrophic
1238 integer truncation. For example, on a 64-bit host (* 4
1239 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1240 Do not rely on undefined behavior after integer overflow.
1241
de883a70
PE
1242 merge count_size_as_multibyte, parse_str_to_multibyte
1243 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1244 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1245 Check for integer overflow.
1246 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1247 since it's now a duplicate of the other. This is more of
1248 a character than a buffer op, so better that it's in character.c.
1249 * fns.c, print.c: Adjust to above changes.
1250
2ff916cb
PE
12512011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1252
1253 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1254
f1b54466
PE
12552011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1256
fb1ac845
PE
1257 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1258 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1259 (x_clipboard_manager_save): Now static.
1260 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1261
f1b54466
PE
1262 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1263 (crypto_hash_function): Now static.
1264 Fix pointer signedness problems. Avoid unnecessary initializations.
1265
a9f737ee
CY
12662011-05-27 Chong Yidong <cyd@stupidchicken.com>
1267
1268 * termhooks.h (Vselection_alist): Make it terminal-local.
1269
1270 * terminal.c (create_terminal): Initialize it.
1271
1272 * xselect.c: Support for clipboard managers.
1273 (Vselection_alist): Move to termhooks.h as terminal-local var.
1274 (LOCAL_SELECTION): New macro.
1275 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1276 (symbol_to_x_atom): Remove gratuitous arg.
1277 (x_handle_selection_request, lisp_data_to_selection_data)
1278 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1279 (x_own_selection, x_get_local_selection, x_convert_selection):
1280 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1281 (some_frame_on_display): Delete unused function.
1282 (Fx_own_selection_internal, Fx_get_selection_internal)
1283 (Fx_disown_selection_internal, Fx_selection_owner_p)
1284 (Fx_selection_exists_p): New optional frame arg.
1285 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1286 (x_handle_selection_clear): Don't treat other terminals with the
1287 same keyboard specially. Use the terminal-local Vselection_alist.
1288 (x_clear_frame_selections): Use Frun_hook_with_args.
1289
1290 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1291
1292 * xterm.h: Add support for those atoms.
1293
e067f0c1
CY
12942011-05-26 Chong Yidong <cyd@stupidchicken.com>
1295
1296 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1297 (converted_selections, conversion_fail_tag): New global variables.
1298 (x_selection_request_lisp_error): Free the above.
1299 (x_get_local_selection): Remove unnecessary code.
1300 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1301 of converted selections stored in converted_selections.
1302 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1303 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1304 (x_convert_selection): New function.
1305 (x_handle_selection_event): Simplify.
1306 (x_get_foreign_selection): Don't ignore incoming requests while
1307 waiting for an answer; this will fail when we implement
1308 SAVE_TARGETS, and seems unnecessary anyway.
1309 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1310 (Vx_sent_selection_functions): Doc fix.
1311
0f4aebc0
LL
13122011-05-26 Leo Liu <sdl.web@gmail.com>
1313
1314 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1315
e61124cd
YM
13162011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1317
1318 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1319
1320 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1321 for fringe update if it has periodic bitmap.
1322 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1323 and fringe_bitmap_periodic_p.
1324
1325 * fringe.c (get_fringe_bitmap_data): New function.
1326 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1327 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1328 row. Mark glyph row for fringe update if periodicity changed.
1329
1330 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1331 for fringe update unless it has periodic bitmap.
1332
f16d9837
KH
13332011-05-25 Kenichi Handa <handa@m17n.org>
1334
1335 * xdisp.c (get_next_display_element): Set correct it->face_id for
1336 a static composition.
1337
e1b90ef6
LL
13382011-05-24 Leo Liu <sdl.web@gmail.com>
1339
1340 * deps.mk (fns.o):
1341 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1342
1343 * fns.c (crypto_hash_function, Fsha1): New function.
1344 (Fmd5): Use crypto_hash_function.
1345 (syms_of_fns): Add Ssha1.
1346
7400048f
PE
13472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * gnutls.c: Remove unused macros.
1350 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1351 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1352 Remove macros that are defined and never used.
1353 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1354
abb71cf4
CY
13552011-05-22 Chong Yidong <cyd@stupidchicken.com>
1356
1357 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1358 (Fx_get_selection_internal): Minor cleanup.
1359 (Fx_own_selection_internal): Rename arguments for consistency with
1360 select.el.
1361
6307db39
PE
13622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1365
f3d4e0a4
CY
13662011-05-22 Chong Yidong <cyd@stupidchicken.com>
1367
1368 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1369
4d8ade89
YM
13702011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1371
1372 * dispnew.c (scrolling_window): Don't exclude the case that the
1373 last enabled row in the desired matrix touches the bottom boundary.
1374
32078c8d
GM
13752011-05-21 Glenn Morris <rgm@gnu.org>
1376
1377 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1378 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1379 and add some more files.
32078c8d 1380
7285dc67
EZ
13812011-05-20 Eli Zaretskii <eliz@gnu.org>
1382
1383 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1384 report_file_error introduced by the change from 2011-05-07.
1385
89d1bd22
PE
13862011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 * systime.h (Time): Define only if emacs is defined.
1389 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1390 where the include path doesn't have X11/X.h by default. See
1391 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1392
e23640bb 13932011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1394
1395 * composite.c (find_automatic_composition): Fix previous change.
1396
b9704ad9
GM
13972011-05-20 Glenn Morris <rgm@gnu.org>
1398
1399 * lisp.mk: New file, split from Makefile.in.
1400 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1401 (shortlisp): Remove.
1402 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1403
4a720484
GM
14042011-05-19 Glenn Morris <rgm@gnu.org>
1405
1406 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1407 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1408 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1409 (lisp): Set the order to that of loadup.el.
1410 (shortlisp): Make it a copy of $lisp.
1411 (SOME_MACHINE_LISP): Remove.
1412 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1413 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1414
a28d4396
KH
14152011-05-18 Kenichi Handa <handa@m17n.org>
1416
1417 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1418 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1419 (find_automatic_composition): Mostly rewrite for efficiency.
1420
a2b1fa8e
JB
14212011-05-18 Juanma Barranquero <lekktu@gmail.com>
1422
1423 * makefile.w32-in: Update dependencies.
1424
8e1f5610
CS
14252011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1426
1427 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1428 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1429
7025ee00 14302011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1431
cdfa6eab
PE
1432 Fix some integer overflow issues, such as string length overflow.
1433
06d6db33
PE
1434 * insdel.c (count_size_as_multibyte): Check for string overflow.
1435
2b4560a8
PE
1436 * character.c (lisp_string_width): Check for string overflow.
1437 Use EMACS_INT, not int, for string indexes and lengths; in
1438 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1439 the resulting string length overflows an EMACS_INT; instead,
1440 report a string overflow if no precision given. When checking for
1441 precision exhaustion, use a check that cannot possibly have
1442 integer overflow. (Bug#8675)
1443 * character.h (lisp_string_width): Adjust to new signature.
1444
cb93f9be
PE
1445 * alloc.c (string_overflow): New function.
1446 (Fmake_string): Use it. This doesn't change behavior, but saves
1447 a few bytes and will simplify future changes.
1448 * character.c (string_escape_byte8): Likewise.
1449 * lisp.h (string_overflow): New decl.
1450
1a1f3366
PE
1451 Fixups, following up to the user-interface timestamp change.
1452 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1453 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1454 * msdos.c (mouse_get_pos): Likewise.
1455 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1456 * w32gui.h (Time): Define by including "systime.h" rather than by
1457 declaring it ourselves. (Bug#8664)
1458
d4e3e4d3
PE
1459 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1460 * image.c (clear_image_cache): Likewise.
1461
f6a24d19
PE
1462 * term.c (term_mouse_position): Don't assume time_t wraparound.
1463
08dc5ae6
PE
1464 Be more systematic about user-interface timestamps.
1465 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1466 and sometimes 'EMACS_UINT', to represent these timestamps.
1467 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1468 This makes the code easier to follow, and makes it easier to catch
1469 integer overflow bugs such as Bug#8664.
1470 * frame.c (Fmouse_position, Fmouse_pixel_position):
1471 Use Time, not unsigned long, for user-interface timestamps.
1472 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1473 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1474 * keyboard.h (last_event_timestamp): Likewise.
1475 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1476 * menu.h (xmenu_show): Likewise.
1477 * term.c (term_mouse_position): Likewise.
1478 * termhooks.h (struct input_event.timestamp): Likewise.
1479 (struct terminal.mouse_position_hook): Likewise.
1480 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1481 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1482 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1483 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1484 what it was before.
1485 * menu.h, termhooks.h: Include "systime.h", for Time.
1486
8e55734a
PE
1487 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1488 Don't assume that the difference between two unsigned long values
1489 can fit into an integer. At this point, we know button_down_time
1490 <= event->timestamp, so the difference must be nonnegative, so
1491 there's no need to cast the result if double-click-time is
1492 nonnegative, as it should be; check that it's nonnegative, just in
1493 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1494 apart (about 25 days). (Bug#8664)
8e55734a 1495
841f1b75 1496 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1497 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1498
3e26f69c
PE
1499 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1500 that always fit in int. Use a sentinel instead of a counter, to
1501 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1502 * frame.h (struct frame): Use int for menu_bar_items_used
1503 instead of EMACS_INT, since it always fits in int.
3e26f69c 1504
5cc152c0
PE
1505 * menu.c (grow_menu_items): Check for int overflow.
1506
d89eb65e
PE
1507 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1508
5235bd3e
PE
1509 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1510 Before, the code was not consistent. These values cannot exceed
1511 2**31 - 1 so there's no need to make them unsigned.
1512 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1513 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1514 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1515 as modifiers.
1516 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1517
bc827e23
PE
1518 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1519 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1520 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1521 presumably because the widths might not match.
1522
78eb494e
PE
1523 * window.c (size_window): Avoid needless test at loop start.
1524
04f2d78b
CB
15252011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1526
1527 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1528
d2fc7e3d 15292011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1530
1531 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1532
d2fc7e3d 15332011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1534
1535 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1536 `width' to `bar_area_x' and `bar_area_width', respectively.
1537 (x_scroll_run): Take account of fringe background extension.
1538
04f2d78b
CB
1539 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1540 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1541 `bar_area_width', respectively.
1542 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1543 background extension.
1544
79b70037
GM
15452011-05-10 Jim Meyering <meyering@redhat.com>
1546
1547 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1548
2f142cc5
JB
15492011-05-10 Juanma Barranquero <lekktu@gmail.com>
1550
1551 * image.c (Finit_image_library): Return t for built-in image types,
1552 like pbm and xbm. (Bug#8640)
1553
57679c86
AS
15542011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1555
1556 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1557
888c9e86
EZ
15582011-05-07 Eli Zaretskii <eliz@gnu.org>
1559
b0512a1d
EZ
1560 * w32console.c (Fset_screen_color): Doc fix.
1561 (Fget_screen_color): New function.
1562 (syms_of_ntterm): Defsubr it.
1563
7285dc67
EZ
1564 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1565 unlink the temporary file if Fcall_process didn't create it in the
1566 first place.
1567 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1568 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1569 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1570 cue to call_process_cleanup not to close that handle.
1571
4d3fcc8e
BK
15722011-05-07 Ben Key <bkey76@gmail.com>
1573
1574 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1575 one of two shell specific rules, either bootstrap-temacs-CMD or
1576 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1577 to the previous implementation of the bootstrap-temacs rule.
1578 The bootstrap-temacs-CMD rule is similar to the previous
1579 implementation of the bootstrap-temacs rule except that it
1580 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1581 variable.
1582
1583 These changes, along with some changes to nt/configure.bat,
1584 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1585 earlier fix to add support for --cflags and --ldflags options
1586 that include quotes so that it works whether make uses cmd or
1587 sh as the shell.
1588
b4289b64
MA
15892011-05-06 Michael Albinus <michael.albinus@gmx.de>
1590
1591 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1592 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1593 is a constant.
1594 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1595 a string. Handle both cases.
1596 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1597 (Fdbus_register_method): Use Qinvalid_function.
1598
af4c0e28
JB
15992011-05-06 Juanma Barranquero <lekktu@gmail.com>
1600
1601 * makefile.w32-in: Update dependencies.
1602 (LISP_H): Add inttypes.h and stdin.h.
1603 (PROCESS_H): Add unistd.h.
1604
c51453d9
EZ
16052011-05-06 Eli Zaretskii <eliz@gnu.org>
1606
1607 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1608 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1609
8ff0ac3c 16102011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1611
4c4b566b
PE
1612 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1613
aab2b9b5
PE
1614 * term.c (vfatal): Remove stray call to va_end.
1615 It's not needed and the C Standard doesn't allow it here anyway.
1616
c378da0b
PE
1617 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1618 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1619
288b08c7
PE
1620 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1621 bytes.
1622
e3601888
PE
1623 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1624
db6c0e74
PE
1625 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1626
dd5963ea
PE
1627 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1628
88c9450f
PE
1629 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1630
2f9442b8
PE
1631 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1632
c032b5f8
PE
1633 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1634 * charset.c (Fdefine_charset_internal): Don't initialize
1635 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1636 32-bit int (Bug#8600).
a108c10b
PE
1637
1638 * lread.c (read_integer): Be more consistent with string-to-number.
1639 Use string_to_number to do the actual conversion; this avoids
1640 rounding errors and fixes some other screwups. Without this fix,
1641 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1642 (digit_to_number): Move earlier, for benefit of read_integer.
1643 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1644 not a digit in any supported base. (Bug#8602)
a108c10b 1645
ad5f9eea
PE
1646 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1647
aec1708a
PE
1648 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1649 to match comment at start of function. This also removes a
1650 GCC warning about overflow in a 32+64-bit port.
1651
47be4ab5
PE
1652 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1653
371cac43
PE
1654 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1655 Reported by Stefan Monnier in
1656 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1657 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1658 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1659
d01a7826
PE
1660 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1661 (EMACS_UINTPTR): Likewise, with uintptr_t.
1662
7fd47d5c
PE
1663 * lisp.h: Prefer 64-bit EMACS_INT if available.
1664 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1665 on 32-bit hosts that have 64-bit int, so that they can access
1666 large files.
122b0c86
PE
1667 However, temporarily disable this change unless the temporary
1668 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1669
8727937b
PE
1670 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1671
8ac068ac
PE
1672 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1673 This removes an assumption that EMACS_INT and long are the same
1674 width as pointers. The assumption is true for Emacs porting targets
1675 now, but we want to make other targets possible.
1676 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1677 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1678 In the rest of the code, change types of integers that hold casted
1679 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1680 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1681 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1682 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1683 No need to cast type when ORing.
1684 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1685 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1686 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1687 assume EMACS_INT is the same width as char *.
1688 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1689 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1690 Remove no-longer-needed casts.
1691 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1692 (xg_tool_bar_help_callback, xg_make_tool_item):
1693 Use EMACS_INTPTR to hold an integer
1694 that will be cast to void *; this can avoid a GCC warning
1695 if EMACS_INT is not the same width as void *.
1696 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1697 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1698 (current_message_1, set_message_1):
1699 Use a local to convert to proper width without a cast.
1700 * xmenu.c (dialog_selection_callback): Likewise.
1701
ede49d71
PE
1702 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1703 Also, don't assume VALBITS / RAND_BITS is less than 5,
1704 and don't rely on undefined behavior when shifting a 1 left into
1705 the sign bit.
1706 * lisp.h (get_random): Change signature to match.
1707
2f30ecd0
PE
1708 * lread.c (hash_string): Use size_t, not int, for hash computation.
1709 Normally we prefer signed values; but hashing is special, because
1710 it's better to use unsigned division on hash table sizes so that
1711 the remainder is nonnegative. Also, size_t is the natural width
1712 for hashing into memory. The previous code used 'int', which doesn't
1713 retain enough info to hash well into very large tables.
1714 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1715
2a866e7b
PE
1716 * dbusbind.c: Don't possibly lose pointer info when converting.
1717 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1718 Use XPNTR rather than XHASH, so that the high-order bits of
1719 the pointer aren't lost when converting through void *.
1720
51639eac
PE
1721 * eval.c (Fautoload): Don't double-shift a pointer.
1722
92394119
PE
1723 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1724
dbdb9a7c
JB
17252011-05-06 Juanma Barranquero <lekktu@gmail.com>
1726
1727 * gnutls.c (DEF_GNUTLS_FN):
1728 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1729
db7a0b4f
AS
17302011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1731
1732 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1733 marker. (Bug#8610)
1734
f7ff1b0f 17352011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1736
1737 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1738 New version that can reserve upto 2GB of heap space.
1739
f7ff1b0f 17402011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1741
1742 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1743
639c109b
TZ
17442011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1745
1746 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1747 `gnutls_certificate_set_x509_key_file'.
1748
d2127135
JB
17492011-05-05 Juanma Barranquero <lekktu@gmail.com>
1750
1751 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1752 Update dependencies.
1753
e968f4f3
JB
17542011-05-04 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1757 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1758 Remove unused parameter `fildes'.
1759 * process.c (read_process_output, send_process): Don't pass it.
1760
84d358f0
JB
17612011-05-04 Juanma Barranquero <lekktu@gmail.com>
1762
1763 Fix previous change: the library cache is defined in w32.c.
1764 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1765 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1766
0898ca10
JB
17672011-05-04 Juanma Barranquero <lekktu@gmail.com>
1768
1769 Implement dynamic loading of GnuTLS on Windows.
1770
1771 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1772 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1773 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1774 Declare.
1775
1776 * gnutls.c (Qgnutls_dll): Define.
1777 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1778 (gnutls_*): Declare function pointers.
1779 (init_gnutls_functions): New function to initialize function pointers.
1780 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1781 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1782 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1783 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1784 (emacs_gnutls_write, emacs_gnutls_read)
1785 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1786 (Fgnutls_available_p): New function.
1787 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1788 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1789 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1790
1791 * image.c: Include w32.h.
1792 (Vimage_type_cache): Delete.
1793 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1794 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1795 (w32_delayed_load): Move to w32.c.
1796
1797 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1798
1799 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1800 (w32_delayed_load): Move from image.c. When loading a library, record
1801 its filename in the :loaded-from property of the library id.
1802 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1803 Initialize and staticpro them.
1804 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1805
1806 * process.c: Include lisp.h before w32.h, not after.
1807 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1808 instead of gnutls_record_check_pending.
1809
1810 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1811
ff4de4aa
TZ
18122011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1813
1814 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1815 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1816 as passed in.
1817
abe95abb
JD
18182011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1819
1820 * xterm.c (x_set_frame_alpha): Do not set property on anything
1821 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1822
e16e55d4
JB
18232011-05-02 Juanma Barranquero <lekktu@gmail.com>
1824
1825 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1826
bafcf6a5
JB
18272011-05-02 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1830 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1831 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1832 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1833 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1834 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1835 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1836 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1837 (Qgnutls_bootprop_callbacks_verify): Make static.
1838
e7a6747f
AS
18392011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1840
19ed11ba
AS
1841 * callproc.c: Indentation fixup.
1842
e7a6747f 1843 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1844 (wait_for_termination, interruptible_wait_for_termination):
1845 Move after wait_for_termination_1.
e7a6747f 1846
1ef14cb4
LMI
18472011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1848
1849 * sysdep.c (interruptible_wait_for_termination): New function
1850 which is like wait_for_termination, but allows keyboard
1851 interruptions.
1852
1853 * callproc.c (Fcall_process): Add (:file "file") as an option for
1854 the STDOUT buffer.
1855 (Fcall_process_region): Ditto.
1856
330d880c
EZ
18572011-04-30 Eli Zaretskii <eliz@gnu.org>
1858
8db90b73
EZ
1859 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1860 rather than `XVECTOR (FOO)->size'.
1861
330d880c
EZ
1862 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1863 inttypes.h, as a gnulib replacement is used if it not available in
1864 system headers.
1865
15cbd324
EZ
18662011-04-21 Eli Zaretskii <eliz@gnu.org>
1867
1868 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1869 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1870 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1871
1872 * coding.c (coding_alloc_by_realloc): Error out if destination
1873 will grow beyond MOST_POSITIVE_FIXNUM.
1874 (decode_coding_emacs_mule): Abort if there isn't enough place in
1875 charbuf for the composition carryover bytes. Reserve an extra
1876 space for up to 2 characters produced in a loop.
1877 (decode_coding_iso_2022): Abort if there isn't enough place in
1878 charbuf for the composition carryover bytes.
1879
18802011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1881
ae940cca
EZ
1882 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1883 aborting when %lld or %lll format is passed.
1884 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1885 %llo or %llx format is passed. (Bug#8545)
1886
03ab8921
EZ
1887 * window.c (window_scroll_line_based): Use a marker instead of
1888 simple variables to record original value of point. (Bug#7952)
1889
afda1437
EZ
1890 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1891 produced by %s or %c overflows available buffer space. (Bug#8545)
1892
f76dee0c
PE
18932011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1894
1895 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1896 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1897
fdc5744d
JB
18982011-04-28 Juanma Barranquero <lekktu@gmail.com>
1899
1900 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1901
638f053a
JB
19022011-04-28 Juanma Barranquero <lekktu@gmail.com>
1903
1904 * keyboard.c (Qdelayed_warnings_hook): Define.
1905 (command_loop_1): Run `delayed-warnings-hook'
1906 if Vdelayed_warnings_list is non-nil.
1907 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1908 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1909
d178f871
EZ
19102011-04-28 Eli Zaretskii <eliz@gnu.org>
1911
1912 * doprnt.c (doprnt): Don't return value smaller than the buffer
1913 size if the message was truncated. (Bug#8545).
1914
b124fd93
JB
19152011-04-28 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1918 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1919
e810457d
PE
19202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1921
1922 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1923
ea51cceb
JB
19242011-04-27 Juanma Barranquero <lekktu@gmail.com>
1925
1926 * makefile.w32-in: Update dependencies.
1927
94dcfacf
EZ
19282011-04-27 Eli Zaretskii <eliz@gnu.org>
1929
1930 Improve `doprnt' and its usage. (Bug#8545)
1931 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1932 `format_end'. Remove support for %l as a conversion specifier.
1933 Don't use xrealloc. Improve diagnostics when the %l size modifier
1934 is used. Update the commentary.
1935
1936 * eval.c (verror): Simplify calculation of size_t.
1937
1938 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1939 messages.
1940
f61f41d7
PE
19412011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1942
1943 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1944 change.
1945
96fb4434
PE
19462011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1947
1948 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1949 This makes this file independent of the recent pseudovector change.
1950
671875da 19512011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1952
69e9b5a3
PE
1953 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1954
b5f869a7 1955 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1956 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1957 Remove unused local.
c8926152 1958 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1959
841a1577 1960 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1961 GCC 4.6.0 optimizes based on type-based alias analysis.
1962 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1963 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1964 != &v->size, and therefore "v->size = 1; b->size = 2; return
1965 v->size;" must therefore return 1. This assumption is incorrect
1966 for Emacs, since it type-puns struct Lisp_Vector * with many other
1967 types. To fix this problem, this patch adds a new type struct
f904488f 1968 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1969 and pseudovectors, and helps optimizing compilers not get fooled
1970 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1971 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1972 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1973 the size member.
eab3844f
PE
1974 (XSETPVECTYPE): Rewrite in terms of new macro.
1975 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1976 This is a bit clearer, and further avoids the possibility of
1977 undesirable aliasing.
1978 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1979 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1980 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1981 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1982 (ASIZE): Now uses header.size rather than size.
1983 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1984 to avoid the hassle of writing XVECTOR (foo)->header.size.
1985 (struct vectorlike_header): New type.
eab3844f
PE
1986 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1987 object, to help avoid aliasing.
1988 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1989 (SUBRP): Likewise, since Lisp_Subr is a special case.
1990 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1991 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1992 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1993 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1994 changed to be "header.size" and "header.next".
1995 * buffer.h (struct buffer): Likewise.
1996 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1997 * frame.h (struct frame): Likewise.
1998 * process.h (struct Lisp_Process): Likewise.
1999 * termhooks.h (struct terminal): Likewise.
2000 * window.c (struct save_window_data, struct saved_window): Likewise.
2001 * window.h (struct window): Likewise.
2002 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2003 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2004 * buffer.c (init_buffer_once): Likewise.
2005 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2006 special case.
2007 * process.c (Fformat_network_address): Use local var for size,
2008 for brevity.
2009
0df1eac5
PE
2010 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2011
847ab9d1 2012 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2013 * data.c (atof): Remove decl; no longer used or needed.
2014 (digit_to_number): Move to lread.c.
2015 (Fstring_to_number): Use new string_to_number function, to be
2016 consistent with how the Lisp reader treats infinities and NaNs.
2017 Do not assume that floating-point numbers represent EMACS_INT
2018 without losing information; this is not true on most 64-bit hosts.
2019 Avoid double-rounding errors, by insisting on integers when
2020 parsing non-base-10 numbers, as the documentation specifies.
2021 * lisp.h (string_to_number): New decl, replacing ...
2022 (isfloat_string): Remove.
bc0a5c13 2023 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2024 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2025 appears to have been a coding error. Similarly, do not accept
2026 strings like +-1e0 as floating point numbers. Do not report
2027 overflow for integer overflows unless the base is not 10 which
2028 means we have no simple and reliable way to continue.
2029 Break out the floating-point parsing into a new
2030 function string_to_number, so that Fstring_to_number parses
2031 floating point numbers consistently with the Lisp reader.
04f2d78b 2032 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2033 (E_CHAR, EXP_INT): Remove, replacing with ...
2034 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2035 (string_to_number): New function, replacing isfloat_string.
2036 This function checks for valid syntax and produces the resulting
2037 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2038 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2039 so that overflow for non-base-10 numbers is reported only when
2040 there's no portable and simple way to convert to floating point.
452f4150 2041
67769ffc
PE
2042 * textprop.c (set_text_properties_1): Rewrite for clarity,
2043 and to avoid GCC warning about integer overflow.
2044
c20db43f
PE
2045 * intervals.h (struct interval): Use EMACS_INT for members
2046 where EMACS_UINT might cause problems. See
2047 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2048 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2049 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2050 All uses changed.
37aa2f85
PE
2051 (offset_intervals): Tell GCC not to worry about length overflow
2052 when negating a negative length.
c20db43f 2053
2538aa2f
PE
2054 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2055 (overrun_check_free): Likewise.
2056
f2d3008d
PE
2057 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2058 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2059 word size.
2060
ec8df744
PE
2061 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2062 (gnutls_make_error): Rename local to avoid shadowing.
2063 (gnutls_emacs_global_deinit): ifdef out; not used.
2064 (Fgnutls_boot): Use const for pointer to readonly storage.
2065 Comment out unused local. Fix pointer signedness problems.
2066
640ee02d
PE
2067 * lread.c (openp): Don't stuff size_t into an 'int'.
2068 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2069 about possible signed overflow.
2070
6048fb2a
PE
2071 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2072 (GDK_KEY_g): Don't define if already defined.
2073 (xg_prepare_tooltip): Avoid pointer signedness problem.
2074 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2075
fa3c87e1
PE
2076 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2077 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2078
2172544b
PE
2079 * xfns.c (Fx_window_property): Simplify a bit,
2080 to make a bit faster and to avoid GCC 4.6.0 warning.
2081 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2082
9b821a21
PE
2083 * fns.c (internal_equal): Don't assume size_t fits in int.
2084
3c616cfa
PE
2085 * alloc.c (compact_small_strings): Tighten assertion a little.
2086
c2982e87
PE
2087 Replace pEd with more-general pI, and fix some printf arg casts.
2088 * lisp.h (pI): New macro, generalizing old pEd macro to other
2089 conversion specifiers. For example, use "...%"pI"d..." rather
2090 than "...%"pEd"...".
2091 (pEd): Remove. All uses replaced with similar uses of pI.
2092 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2093 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2094 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2095 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2096 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2097 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2098 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2099 64-bit hosts.
2100 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2101 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2102 * print.c (safe_debug_print, print_object): Likewise.
2103 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2104 to int.
6f04d126
PE
2105 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2106 avoiding the 0 flag, which is not portable.
c2982e87
PE
2107 * process.c (Fmake_network_process): Use pI to avoid cast.
2108 * region-cache.c (pp_cache): Likewise.
2109 * xdisp.c (decode_mode_spec): Likewise.
2110 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2111 behavior on 64-bit hosts with printf arg.
6f04d126 2112 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2113 (x_stop_queuing_selection_requests): Likewise.
2114 (x_get_window_property): Don't truncate byte count to an 'int'
2115 when tracing.
0b432f21 2116
5e073ec7
PE
2117 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2118 here, since it parses constructs like leading '-' and spaces,
2119 which are not wanted; and it overflows with large numbers.
2120 Instead, simply match F[0-9]+, which is what is wanted anyway.
2121
36372bf9
PE
2122 * alloc.c: Remove unportable assumptions about struct layout.
2123 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2124 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2125 (allocate_vectorlike, make_pure_vector): Use the new macros,
2126 plus offsetof, to remove unportable assumptions about struct layout.
2127 These assumptions hold on all porting targets that I know of, but
2128 they are not guaranteed, they're easy to remove, and removing them
2129 makes further changes easier.
2130
0b432f21
PE
2131 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2132 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2133 (string_overrun_cookie): Now const. Use initializers that
2134 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2135 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2136 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2137 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2138 multiple of sizeof (EMACS_INT); it need not be, if
2139 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2140 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2141
895009e1
JB
21422011-04-26 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2145
6a7a1b0b
TZ
21462011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2147
2148 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2149 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2150 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2151
841a1577 21522011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2153
2154 * lisp.h (Qdebug): List symbol.
895009e1 2155 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2156 * keyboard.c (debug-on-event): New variable.
2157 (handle_user_signal): Break into debugger when debug-on-event
2158 matches the current signal symbol.
2159
f2d3ba6f
DN
21602011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2161
2162 * alloc.c (check_sblock, check_string_bytes)
2163 (check_string_free_list): Convert to standard C.
2164
42ce4c63
TZ
21652011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2166
2167 * w32.c (emacs_gnutls_push): Fix typo.
2168
825cd63c
EZ
21692011-04-25 Eli Zaretskii <eliz@gnu.org>
2170
fb11d64d
EZ
2171 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2172 "cast to pointer from integer of different size".
2173
825cd63c
EZ
2174 Improve doprnt and its use in verror. (Bug#8545)
2175 * doprnt.c (doprnt): Document the set of format control sequences
2176 supported by the function. Use SAFE_ALLOCA instead of always
2177 using `alloca'.
2178
2179 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2180 is one byte too soon. Don't use xrealloc; instead xfree and
2181 xmalloc anew.
2182
e061a11b
TZ
21832011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2184
2185 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2186 callbacks stage.
2187
2188 * gnutls.c: Renamed global_initialized to
2189 gnutls_global_initialized. Added internals for the
2190 :verify-hostname-error, :verify-error, and :verify-flags
2191 parameters of `gnutls-boot' and documented those parameters in the
2192 docstring. Start callback support.
2193 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2194 unless a fatal error occured. Call gnutls_alert_send_appropriate
2195 on error. Return error code.
2196 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2197 (emacs_gnutls_read): Likewise.
2198 (Fgnutls_boot): Return handshake error code.
2199 (emacs_gnutls_handle_error): New function.
2200 (wsaerror_to_errno): Likewise.
2201
2202 * w32.h (emacs_gnutls_pull): Add prototype.
2203 (emacs_gnutls_push): Likewise.
2204
2205 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2206 (emacs_gnutls_push): Likewise.
2207
22082011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2209
2210 * process.c (wait_reading_process_output): Check if GnuTLS
2211 buffered some data internally if no FDs are set for TLS
2212 connections.
2213
2214 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2215 (LIBS): Link to USER_LIBS.
2216 ($(BLD)/gnutls.$(0)): New target.
2217
fa6996bc
EZ
22182011-04-24 Eli Zaretskii <eliz@gnu.org>
2219
eb35682e
EZ
2220 * xdisp.c (handle_single_display_spec): Rename the
2221 display_replaced_before_p argument into display_replaced_p, to
2222 make it consistent with the commentary. Fix typos in the
2223 commentary.
2224
e2ad650c
EZ
2225 * textprop.c (syms_of_textprop): Remove dead code.
2226 (copy_text_properties): Delete obsolete commentary about an
2227 interface that was deleted long ago. Fix typos in the description
2228 of arguments.
2229
1b2de274
EZ
2230 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2231 to changes in oldXMenu/XMenu.h from 2011-04-16.
2232 <menu_help_message, prev_menu_help_message>: Constify.
2233 (IT_menu_make_room): menu->help_text is now `const char **';
2234 adjust.
2235
2236 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2237 to changes in oldXMenu/XMenu.h from 2011-04-16.
2238 (struct XMenu): Declare `help_text' `const char **'.
2239
2240 * xfaces.c <Qunspecified>: Make extern again.
2241
2242 * syntax.c: Include sys/types.h before including regex.h, as
2243 required by Posix.
2244
762b15be
EZ
2245 * doc.c (get_doc_string): Improve the format passed to `error'.
2246
2247 * doprnt.c (doprnt): Improve commentary.
2248
2249 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2250
2251 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2252 them with etags.
2253
f1052e5d
EZ
2254 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2255 changes in globals.h immediately force recompilation.
762b15be
EZ
2256 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2257 $(CURDIR)/s/ms-w32.h.
2258 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2259
fa6996bc
EZ
2260 * character.c (Fchar_direction): Function deleted.
2261 (syms_of_character): Don't defsubr it.
2262 <char-direction-table>: Deleted.
2263
e6c3da20
EZ
22642011-04-23 Eli Zaretskii <eliz@gnu.org>
2265
2266 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2267 * doprnt.c: Include limits.h.
2268 (SIZE_MAX): New macro.
04f2d78b
CB
2269 (doprnt): Return a size_t value. 2nd arg is now size_t.
2270 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2271 Improve overflow protection. Support `l' modifier for integer
2272 conversions. Support %l conversion. Don't assume an EMACS_INT
2273 argument for integer conversions and for %c.
2274
2275 * lisp.h (doprnt): Restore prototype.
2276
2277 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2278 $(SRC)/character.h.
2279
2280 * Makefile.in (base_obj): Add back doprnt.o.
2281
2282 * deps.mk (doprnt.o): Add back prerequisites.
2283 (callint.o): Depend on character.h.
2284
2285 * eval.c (internal_lisp_condition_case): Include the handler
2286 representation in the error message.
2287 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2288 when breaking from the loop.
2289
2290 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2291
2292 * callint.c (Fcall_interactively): When displaying error message
2293 about invalid control letter, pass the character's codepoint, not
2294 a pointer to its multibyte form. Improve display of the character
2295 in octal and display also its hex code.
2296
2297 * character.c (char_string): Use %x to display the (unsigned)
2298 codepoint of an invalid character, to avoid displaying a bogus
2299 negative value.
2300
2301 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2302 `error', not SYMBOL_NAME itself.
2303
2304 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2305 character arguments to `error'.
2306
2307 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2308 to `error' in error message about FINAL_CHAR argument. Make sure
2309 FINAL_CHAR is a character, and use %c when it is passed as
2310 argument to `error'.
2311
4ffd0d6b 23122011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2313
2314 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2315
2316 * w32.c: Include <time.h>.
2317 (sys_localtime): New function.
2318
4ffd0d6b 23192011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2320
2321 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2322
4ffd0d6b 2323 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2324
4ffd0d6b 23252011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2326
4ffd0d6b
GM
2327 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2328 zombies (Bug#8467).
aac0c6e3 2329
04c56954
EZ
23302011-04-19 Eli Zaretskii <eliz@gnu.org>
2331
2332 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2333 gl_state.e_property when gl_state.object is Qt.
2334
2335 * insdel.c (make_gap_larger): Remove limitation of buffer size
2336 to <= INT_MAX.
2337
16a43933
CY
23382011-04-18 Chong Yidong <cyd@stupidchicken.com>
2339
2340 * xdisp.c (lookup_glyphless_char_display)
2341 (produce_glyphless_glyph): Handle cons cell entry in
2342 glyphless-char-display.
2343 (Vglyphless_char_display): Document it.
2344
2345 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2346 glyphless-char-display.
2347
4581706e
CY
23482011-04-17 Chong Yidong <cyd@stupidchicken.com>
2349
2350 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2351
2352 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2353
2354 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2355 definition for no-X builds.
2356
4887c6e2 23572011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2358
fd35b6f9
PE
2359 Static checks with GCC 4.6.0 and non-default toolkits.
2360
5c1ccb01
PE
2361 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2362
006c5daa
PE
2363 * process.c (keyboard_bit_set): Define only if SIGIO.
2364 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2365 (send_process): Repair possible setjmp clobbering.
2366
efc736d3
PE
2367 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2368
4e2fe2e6
PE
2369 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2370
f97334a2
PE
2371 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2372
4e75f29d
PE
2373 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2374 Define only if needed.
2375
90efadd1
PE
2376 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2377 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2378 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2379
3c647824
PE
2380 * dispextern.h (struct redisplay_interface): Rename param
2381 to avoid shadowing.
e264f262 2382 * termhooks.h (struct terminal): Likewise.
761383f4 2383 * xterm.c (xembed_send_message): Likewise.
3c647824 2384
b58c5c4a
PE
2385 * insdel.c (make_gap_smaller): Define only if
2386 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2387
cad59032
PE
2388 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2389 it.
2390
c339dc2e
PE
2391 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2392 so that we aren't warned about unused symbols.
2393
91a3e27b
PE
2394 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2395
399c71d3 2396 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2397
8ffc96f5
PE
2398 * xfns.c (x_real_positions): Mark locals as initialized.
2399
eef9bc79
PE
2400 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2401
098db9dd
PE
2402 * xterm.c: Fix problems found by static analysis with other toolkits.
2403 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2404 (x_dispatch_event): Declare static if USE_GTK, and
2405 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2406 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2407 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2408 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2409 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2410
eb18f6cc
PE
2411 * xmenu.c (menu_help_callback): Pointer type fixes.
2412 Use const pointers when pointing at readonly data. Avoid pointer
2413 signedness clashes.
2414 (FALSE): Remove unused macro.
2415 (update_frame_menubar): Remove unused decl.
2416
1fe72bf8
PE
2417 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2418
60d9e1db
PE
2419 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2420 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2421 (single_menu_item): Rename local to avoid shadowing.
2422
39261c26
PE
2423 * keyboard.c (make_lispy_event): Remove unused local var.
2424
018c5e19
PE
2425 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2426 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2427
63d2b86e
PE
2428 * bitmaps: Change bitmaps from unsigned char back to the X11
2429 compatible char. Avoid the old compiler warnings about
2430 out-of-range initializers by using, for example, '\xab' rather
2431 than 0xab.
2432
aefd87e1
PE
2433 * xgselect.c (xgselect_initialize): Check vs interface
2434 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2435
bf501fb9
PE
2436 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2437
e9829fdf
PE
2438 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2439 to read-only memory.
2440
1086c095
PE
2441 * fns.c (vector): Remove; this old hack is no longer needed.
2442
2baccd04 2443 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2444 Remove unused var.
dde42981 2445 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2446
72391843 2447 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2448
436c16df 2449 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2450 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2451 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2452
92bb796d 2453 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2454 (x_term_init): Remove local to avoid shadowing.
92bb796d 2455
764430a3 2456 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2457
2458 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2459 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2460
d1dfb56c
EZ
24612011-04-16 Eli Zaretskii <eliz@gnu.org>
2462
c4354cb4
EZ
2463 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2464
d1dfb56c
EZ
2465 Fix regex.c, syntax.c and friends for buffers > 2GB.
2466 * syntax.h (struct gl_state_s): Declare character position members
2467 EMACS_INT.
2468
2469 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2470
04f2d78b
CB
2471 * textprop.c (verify_interval_modification, interval_of):
2472 Declare arguments EMACS_INT.
d1dfb56c
EZ
2473
2474 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2475 EMACS_INT.
2476
2477 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2478
2479 * indent.c (Fvertical_motion): Local variable it_start is now
2480 EMACS_INT.
2481
2482 * regex.c (re_match, re_match_2, re_match_2_internal)
2483 (bcmp_translate, regcomp, regexec, print_double_string)
2484 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2485 (re_compile_pattern, re_exec): Declare arguments and local
2486 variables `size_t' and `ssize_t' and return values `regoff_t', as
2487 appropriate.
2488 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2489 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2490 <compile_stack_type>: `size' and `avail' are now `size_t'.
2491
2492 * regex.h <regoff_t>: Use ssize_t, not int.
2493 (re_search, re_search_2, re_match, re_match_2): Arguments that
2494 specify buffer/string position and length are now ssize_t and
2495 size_t. Return type is regoff_t.
2496
613052cd
BK
24972011-04-16 Ben Key <bkey76@gmail.com>
2498
2499 * nsfont.m: Fixed bugs in ns_get_family and
2500 ns_descriptor_to_entity that were caused by using free to
2501 deallocate memory blocks that were allocated by xmalloc (via
2502 xstrdup). This caused Emacs to crash when compiled with
2503 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2504 --enable-checking=xmallocoverrun). xfree is now used to
2505 deallocate these memory blocks.
2506
4170f62f 25072011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2508
71b41406
PE
2509 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2510
9587a89d
PE
2511 emacs_write: Accept and return EMACS_INT for sizes.
2512 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2513 et seq.
2514 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2515 Accept and return EMACS_INT.
2516 (emacs_gnutls_write): Return the number of bytes written on
2517 partial writes.
2518 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2519 (emacs_read, emacs_write): Remove check for negative size, as the
2520 Emacs source code has been audited now.
9587a89d
PE
2521 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2522 (emacs_read, emacs_write): Use it.
273a5f82
PE
2523 * process.c (send_process): Adjust to the new signatures of
2524 emacs_write and emacs_gnutls_write. Do not attempt to store
2525 a byte offset into an 'int'; it might overflow.
9587a89d 2526 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2527
3e047f51
PE
2528 * sound.c: Don't assume sizes fit in 'int'.
2529 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2530 Return EMACS_INT, not int.
3e047f51 2531 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2532 Accept EMACS_INT, not int.
2533 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2534 record read return values.
2535
cc39a9db
BK
25362011-04-15 Ben Key <bkey76@gmail.com>
2537
c9d0ec6d
JB
2538 * keyboard.c (Qundefined): Don't declare static since it is used
2539 in nsfns.m.
2540 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2541 static since they are used in nsfont.m.
cc39a9db 2542
6c60eb9f
SM
25432011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2544
2545 * process.c (Qprocessp): Don't declare static.
2546 * lisp.h (Qprocessp): Declare again.
2547
7990b61a
JB
25482011-04-15 Juanma Barranquero <lekktu@gmail.com>
2549
2550 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2551
5d4cb038
PE
25522011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2553
8bd7b830 2554 Improve C-level modularity by making more things 'static'.
cd64ea1d 2555
e3b27b31
PE
2556 Don't publish debugger-only interfaces to other modules.
2557 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2558 (verify_bytepos, count_markers): Move decls to the only modules
2559 that need them.
2560 * region-cache.h (pp_cache): Likewise.
2561 * window.h (check_all_windows): Likewise.
2562 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2563
5d4cb038
PE
2564 * sysdep.c (croak): Now static, if
2565 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2566 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2567
2568 * alloc.c (refill_memory_reserve): Now static if
2569 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2570 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2571
e87b6180
PE
2572 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2573 Define only if USE_LUCID.
2574
ac64929e
PE
2575 * xrdb.c (x_customization_string, x_rm_string): Now static.
2576
6f37259d
PE
2577 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2578 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2579
1683e3ab
PE
2580 * xdisp.c (draw_row_with_mouse_face): Now static.
2581 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2582
de9c2632
PE
2583 * window.h (check_all_windows): Mark externally visible.
2584
2b96acb7
PE
2585 * window.c (window_deletion_count): Now static.
2586
2587 * undo.c: Make symbols static if they're not exported.
2588 (last_undo_buffer, last_boundary_position, pending_boundary):
2589 Now static.
2590
50436f33
PE
2591 * textprop.c (interval_insert_behind_hooks): Now static.
2592 (interval_insert_in_front_hooks): Likewise.
2593
64520e5c
PE
2594 * term.c: Make symbols static if they're not exported.
2595 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2596 (max_frame_lines, tty_set_terminal_modes):
2597 (tty_reset_terminal_modes, tty_turn_off_highlight):
2598 (get_tty_terminal): Now static.
2599 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2600 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2601 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2602 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2603 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2604
1fa53021
PE
2605 * sysdep.c: Make symbols static if they're not exported.
2606 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2607 Now static.
2608 (sigprocmask_set, full_mask): Remove; unused.
2609 (wait_debugging): Mark as visible.
2610 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2611 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2612
d4b43b22
PE
2613 * syntax.c (syntax_temp): Define only if !__GNUC__.
2614
b7c513d0
PE
2615 * sound.c (current_sound_device, current_sound): Now static.
2616
989b29ad
PE
2617 * search.c (searchbufs, searchbuf_head): Now static.
2618
13a55a78
PE
2619 * scroll.c (scroll_cost): Remove; unused.
2620 * dispextern.h (scroll_cost): Remove decl.
2621
de68a1fc
PE
2622 * region-cache.h (pp_cache): Mark as externally visible.
2623
40ccffa6
PE
2624 * process.c: Make symbols static if they're not exported.
2625 (process_tick, update_tick, create_process, chan_process):
2626 (Vprocess_alist, proc_buffered_char, datagram_access):
2627 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2628 (deactivate_process): Mark defn as static, as well as decl.
2629 * lisp.h (create_process): Remove decl.
2630 * process.h (chan_process, Vprocess_alist): Remove decls.
2631
ad64fc97
PE
2632 * print.c: Make symbols static if they're not exported.
2633 (print_depth, new_backquote_output, being_printed, print_buffer):
2634 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2635 (print_interval, print_number_index, initial_stderr_stream):
2636 Now static.
2637 * lisp.h (Fprinc): Remove decl.
2638 (debug_output_compilation_hack): Mark as externally visible.
2639
adddb265
PE
2640 * sysdep.c (croak): Move decl from here to syssignal.h.
2641 * syssignal.h (croak): Put it here, so the API can be checked when
2642 'croak' is called from dissociate_if_controlling_tty.
2643
1717ede2
PE
2644 * minibuf.c: Make symbols static if they're not exported.
2645 (minibuf_save_list, choose_minibuf_frame): Now static.
2646 * lisp.h (choose_minibuf_frame): Remove decl.
2647
fa5fb2bc
PE
2648 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2649
1e3890d1
PE
2650 * lread.c: Make symbols static if they're not exported.
2651 (read_objects, initial_obarray, oblookup_last_bucket_number):
2652 Now static.
2653 (make_symbol): Remove; unused.
2654 * lisp.h (initial_obarray, make_symbol): Remove decls.
2655
8a1414fa
PE
2656 * keyboard.c: Make symbols static if they're not exported.
2657 (single_kboard, recent_keys_index, total_keys, recent_keys):
2658 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2659 (this_single_command_key_start, echoing, last_auto_save):
2660 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2661 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2662 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2663 (Vlispy_mouse_stem, double_click_count):
2664 Now static.
2665 (force_auto_save_soon): Define only if SIGDANGER.
2666 (ignore_mouse_drag_p): Now static if
2667 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2668 (print_help): Remove; unused.
2669 (stop_character, last_timer_event): Mark as externally visible.
2670 * keyboard.h (ignore_mouse_drag_p): Declare only if
2671 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2672 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2673 * lisp.h (echoing): Remove decl.
2674 (force_auto_save_soon): Declare only if SIGDANGER.
2675 * xdisp.c (redisplay_window): Simplify code, to make it more
2676 obvious that ignore_mouse_drag_p is not accessed if !defined
2677 USE_GTK && !defined HAVE_NS.
2678
93ea6e8f
PE
2679 * intervals.c: Make symbols static if they're not exported.
2680 (merge_properties_sticky, merge_interval_right, delete_interval):
2681 Now static.
2682 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2683
77382fcc
PE
2684 * insdel.c: Make symbols static if they're not exported.
2685 However, leave prepare_to_modify_buffer alone. It's never
2686 called from outside this function, but that appears to be a bug.
2687 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2688 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2689 (adjust_after_replace_noundo): Remove; unused.
2690 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2691 (signal_before_change): Remove decls.
77382fcc 2692
9306c32e
PE
2693 * indent.c (val_compute_motion, val_vmotion): Now static.
2694
cd44d2eb
PE
2695 * image.c: Make symbols static if they're not exported.
2696 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2697 if USE_GTK.
2698 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2699 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2700
ad9a7a06
PE
2701 * fringe.c (standard_bitmaps): Now static.
2702 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2703
81626931
PE
2704 * frame.c: Make symbols static if they're not exported.
2705 (x_report_frame_params, make_terminal_frame): Now static.
2706 (get_frame_param): Now static, unless HAVE_NS.
2707 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2708 (x_get_resource_string): Remove; not used.
2709 * frame.h (make_terminal_frame, x_report_frame_params):
2710 (x_get_resource_string); Remove decls.
2711 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2712 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2713
239f9db9
PE
2714 * font.c, fontset.c: Make symbols static if they're not exported.
2715 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2716 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2717 * font.c (font_close_object): Now static.
2718 * font.h (font_close_object): Remove.
2719 * fontset.c (FONTSET_OBJLIST): Remove.
2720 (free_realized_fontset) #if-0 the body, which does nothing.
2721 (face_suitable_for_char_p): #if-0, as it's never called.
2722 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2723 * xfaces.c (face_at_string_position):
2724 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2725 since 0 is always ASCII.
2726
dfcf3579
PE
2727 * fns.c (weak_hash_tables): Now static.
2728
5045092b
PE
2729 * fileio.c: Make symbols static if they're not exported.
2730 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2731 (Vwrite_region_annotation_buffers): Now static.
2732
57a96f5c
PE
2733 * eval.c: Make symbols static if they're not exported.
2734 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2735 * lisp.h (backtrace_list): Remove decl.
2736
35f08c38
PE
2737 * emacs.c: Make symbols static if they're not exported.
2738 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2739 (fatal_error_code, fatal_error_signal_hook, standard_args):
2740 Now static.
2741 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2742 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2743 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2744 * lisp.h (fatal_error_signal_hook): Remove decl.
2745 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2746
f44bd759
PE
2747 * editfns.c: Move a (normally-unused) function to its only use.
2748 * editfns.c, lisp.h (get_operating_system_release): Remove.
2749 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2750 worth the hassle of breaking this out.
2751
b532497d
PE
2752 * xterm.c: Make symbols static if they're not exported.
2753 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2754 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2755 (x_destroy_window, x_delete_display):
2756 Now static.
2757 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2758 (x_mouse_leave): Remove; unused.
2759 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2760 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2761 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2762 Remove decls.
2763 (x_mouse_leave): Declare only if WINDOWSNT.
2764 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2765 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2766 USE_X_TOOLKIT.
2767
1675728f
PE
2768 * ftxfont.c: Make symbols static if they're not exported.
2769 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2770 HAVE_FREETYPE.
2771 * font.h (ftxfont_driver): Likewise.
2772
e4cebfca
PE
2773 * xfns.c: Make symbols static if they're not exported.
2774 (x_last_font_name, x_display_info_for_name):
2775 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2776 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2777 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2778 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2779 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2780 (last_show_tip_args): Now static.
2781 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2782 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2783 (x_screen_planes): Remove; unused.
2784 * dispextern.h (x_screen_planes): Remove decl.
2785
5bf46f05
PE
2786 * dispnew.c: Make symbols static if they're not exported.
2787 * dispextern.h (redraw_garbaged_frames, scrolling):
2788 (increment_row_positions): Remove.
2789 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2790 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2791 Now static.
2792 (redraw_garbaged_frames): Remove; unused.
2793
435f4c28
PE
2794 * xfaces.c: Make symbols static if they're not exported.
2795 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2796 Remove decls.
2797 * xterm.h (defined_color): Remove decls.
2798 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2799 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2800 (menu_face_changed_default, defined_color, free_realized_face):
2801 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2802 (ascii_face_of_lisp_face): Remove; unused.
2803
8524aef3
PE
2804 * xdisp.c: Make symbols static if they're not exported.
2805 * dispextern.h (scratch_glyph_row, window_box_edges):
2806 (glyph_to_pixel_coords, set_cursor_from_row):
2807 (get_next_display_element, set_iterator_to_next):
2808 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2809 (show_mouse_face): Remove decls
2810 * frame.h (message_buf_print): Likewise.
2811 * lisp.h (pop_message, set_message, check_point_in_composition):
2812 Likewise.
2813 * xterm.h (set_vertical_scroll_bar): Likewise.
2814 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2815 (message_buf_print, scratch_glyph_row, displayed_buffer):
2816 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2817 (get_next_display_element, show_mouse_face, window_box_edges):
2818 (frame_to_window_pixel_xy, check_point_in_composition):
2819 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2820 (glyph_to_pixel_coords): Remove; unused.
2821
16390cd2
PE
2822 * dired.c (file_name_completion): Now static.
2823
2824 * dbusbind.c (xd_in_read_queued_messages): Now static.
2825
a25f4dfa
PE
2826 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2827 * data.c (circular_list_error): Remove.
2828
14a9c8df
PE
2829 * commands.h (last_point_position, last_point_position_buffer):
2830 (last_point_position_window): Remove decls.
2831 * keyboard.c: Make these variables static.
2832
04f2d78b
CB
2833 * coding.h (coding, code_convert_region, encode_coding_gap):
2834 Remove decls.
74ab6df5
PE
2835 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2836 (iso_code_class, detect_coding, code_convert_region): Now static.
2837 (encode_coding_gap): Remove; unused.
2838
38dfbee1
PE
2839 * chartab.c (chartab_chars, chartab_bits): Now static.
2840
a2cb4e63
PE
2841 * charset.h (charset_iso_8859_1): Remove decl.
2842 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2843 Now static.
2844
127198fd
PE
2845 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2846 * ccl.c (Vccl_program_table): Now static.
2847 (check_ccl_update): Remove; unused.
2848
d85b608f
PE
2849 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2850 * category.h: ... from here.
2851 * category.c (check_category_table, set_category_set): Now static.
2852
31cd66f3
PE
2853 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2854 * lisp.h: Remove these decls.
2855
c358e587
PE
2856 * buffer.c (buffer_count): Remove unused var.
2857
e78aecca
PE
2858 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2859 so that it's not optimized away.
2860 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2861 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2862 exported only to the debugger.
2863
e192d7d3 2864 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2865 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2866
92470028
PE
2867 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2868 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2869 was inaccessible from Lisp.
2870 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2871 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2872
244ed907
PE
2873 alloc.c: Import and export fewer symbols, and remove unused items.
2874 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2875 is defined.
2876 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2877 it's not optimized away by whole-program optimization.
2878 (message_enable_multibyte, free_misc): Remove.
2879 (catchlist, handlerlist, mark_backtrace):
2880 Declare only if BYTE_MARK_STACK.
2881 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2882 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2883 (message_enable_multibyte): Remove decl.
2884 (free_misc, interval_free_list, float_block, float_block_index):
2885 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2886 (cons_free_list, last_marked_index):
2887 Now static.
2888 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2889 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2890 (mark_backtrace): Define only if BYTE_MARK_STACK.
2891 * xdisp.c (message_enable_multibyte): Now static.
2892
61c2b50e 2893 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2894 This makes it easier for human readers (and static analyzers)
2895 to see whether these variables are used from other modules.
2896 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2897 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2898 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2899 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2900 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2901 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2902 * xmenu.c, xselect.c:
2903 Declare Q* vars static if they are not used in other modules.
2904 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2905 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2906 Remove decls of unexported vars.
2907 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2908
95c82688
PE
2909 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2910
16a97296
PE
2911 Make Emacs functions such as Fatom 'static' by default.
2912 This makes it easier for human readers (and static analyzers)
2913 to see whether these functions can be called from other modules.
2914 DEFUN now defines a static function. To make the function external
2915 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2916 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2917 (Finit_image_library):
16a97296
PE
2918 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2919 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2920 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2921 Remove decls, since these functions are now static.
2922 (Funintern, Fget_internal_run_time): New decls, since these functions
2923 were already external.
95c82688 2924
16a97296
PE
2925 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2926 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2927 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2928 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2929 * keyboard.c, keymap.c, lread.c:
2930 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2931 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2932 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2933 Mark functions with DEFUE instead of DEFUN,
2934 if they are used in other modules.
2935 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2936 decls for now-static functions.
2937 * buffer.h (Fdelete_overlay): Remove decl.
2938 * callproc.c (Fgetenv_internal): Mark as internal.
2939 * composite.c (Fremove_list_of_text_properties): Remove decl.
2940 (Fcomposition_get_gstring): New forward static decl.
2941 * composite.h (Fcomposite_get_gstring): Remove decl.
2942 * dired.c (Ffile_attributes): New forward static decl.
2943 * doc.c (Fdocumntation_property): New forward static decl.
2944 * eval.c (Ffetch_bytecode): New forward static decl.
2945 (Funintern): Remove extern decl; now in .h file where it belongs.
2946 * fileio.c (Fmake_symbolic_link): New forward static decl.
2947 * image.c (Finit_image_library): New forward static decl.
2948 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2949 * intervals.h (Fprevious_property_change):
2950 (Fremove_list_of_text_properties): Remove decls.
2951 * keyboard.c (Fthis_command_keys): Remove decl.
2952 (Fcommand_execute): New forward static decl.
2953 * keymap.c (Flookup_key): New forward static decl.
2954 (Fcopy_keymap): Now static.
2955 * keymap.h (Flookup_key): Remove decl.
2956 * process.c (Fget_process): New forward static decl.
2957 (Fprocess_datagram_address): Mark as internal.
2958 * syntax.c (Fsyntax_table_p): New forward static decl.
2959 (skip_chars): Remove duplicate decl.
2960 * textprop.c (Fprevious_property_change): New forward static decl.
2961 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2962 Now internal.
2963 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2964 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2965
785bbd42
PE
2966 * editfns.c (Fformat): Remove unreachable code.
2967
8b913b57
AS
29682011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2969
2970 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2971 change. (Bug#8496)
2972
a6744a35
EZ
29732011-04-13 Eli Zaretskii <eliz@gnu.org>
2974
2975 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2976 when at ZV. (Bug#8487)
2977
e7974947
AS
29782011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2979
baad03f0
AS
2980 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2981 (Bug#8437)
2982 * keyboard.c (parse_tool_bar_item): Likewise.
2983 * sound.c (sound_cleanup, alsa_close): Likewise.
2984 * termcap.c (tgetent): Likewise.
2985 * xfns.c (x_default_font_parameter): Likewise.
2986 * xsettings.c (read_and_apply_settings): Likewise.
2987
e7974947
AS
2988 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2989 (overrun_check_free): Protoize.
2990
28272684
PE
29912011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2992
2993 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2994 since callers should never pass a negative size.
2995 Change the signature to match that of plain 'read' and 'write'; see
2996 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2997 * lisp.h: Update prototypes of emacs_write and emacs_read.
2998
11997c76
EZ
29992011-04-11 Eli Zaretskii <eliz@gnu.org>
3000
3001 * xdisp.c (redisplay_window): Don't try to determine the character
3002 position of the scroll margin if the window start point w->startp
e896f03c 3003 is outside the buffer's accessible region. (Bug#8468)
11997c76 3004
8a2cbd72
EZ
30052011-04-10 Eli Zaretskii <eliz@gnu.org>
3006
3007 Fix write-region and its subroutines for buffers > 2GB.
3008 * fileio.c (a_write, e_write): Modify declaration of arguments and
3009 local variables to support buffers larger than 2GB.
3010 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3011
3012 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3013 argument, local variables, and return value.
3014
3015 * lisp.h: Update prototypes of emacs_write and emacs_read.
3016
3017 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3018
4073e537 30192011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3020
1ebfdcb6
PE
3021 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3022
b2ded58d
PE
3023 Fix more problems found by GCC 4.6.0's static checks.
3024
7d66342c
PE
3025 * xdisp.c (vmessage): Use a better test for character truncation.
3026
bbf47d44
PE
3027 * charset.c (load_charset_map): <, not <=, for optimization,
3028 and to avoid potential problems with integer overflow.
9248994d 3029 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3030 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3031 * editfns.c (Fformat): Likewise.
1e69125e 3032 * syntax.c (skip_chars): Likewise.
3befa583 3033
e3019616
PE
3034 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3035 This also lets GCC 4.6.0 generate slightly better loop code.
3036
becfa255
PE
3037 * callint.c (Fcall_interactively): <, not <=, for optimization.
3038 (Fcall_interactively): Count the number of arguments produced,
3039 not the number of arguments given. This is simpler and lets GCC
3040 4.6.0 generate slightly better code.
3041
dae0cd48
PE
3042 * ftfont.c: Distingish more carefully between FcChar8 and char.
3043 The previous code passed unsigned char * to a functions like
3044 strlen and xstrcasecmp that expect char *, which does not
3045 conform to the C standard.
3046 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3047 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3048 char * when the C standard requires it.
3049
76032d70
PE
3050 * keyboard.c (read_char): Remove unused var.
3051
eb3f1cc8
PE
3052 * eval.c: Port to Windows vsnprintf (Bug#8435).
3053 Include <limits.h>.
3054 (SIZE_MAX): Define if the headers do not.
3055 (verror): Do not give up if vsnprintf returns a negative count.
3056 Instead, grow the buffer. This ports to Windows vsnprintf, which
3057 does not conform to C99. Problem reported by Eli Zaretskii.
3058 Also, simplify the allocation scheme, by avoiding the need for
3059 calling realloc, and removing the ALLOCATED variable.
3060
70476b54
PE
3061 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3062
12020a9e
PE
3063 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3064 But keep the doprint source code for now, as we might revamp it
3065 and use it again (Bug#8435).
ea6c7ae6
PE
3066 * lisp.h (doprnt): Remove.
3067 * Makefile.in (base_obj): Remove doprnt.o.
3068 * deps.mk (doprnt.o): Remove.
3069
5fdb398c
PE
3070 error: Print 32- and 64-bit integers portably (Bug#8435).
3071 Without this change, on typical 64-bit hosts error ("...%d...", N)
3072 was used to print both 32- and 64-bit integers N, which relied on
3073 undefined behavior.
3074 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3075 New macro.
3076 * lisp.h (error, verror): Mark as printf-like functions.
3077 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3078 Report overflow in size calculations when allocating printf buffer.
3079 Do not truncate output string at its first null byte.
3080 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3081 Truncate the output at a character boundary, since vsnprintf does not
3082 do that.
3083 * charset.c (check_iso_charset_parameter): Convert internal
3084 character to string before calling 'error', since %c now has the
3085 printf meaning.
3086 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3087 overflow when computing char to be passed to 'error'. Do not
3088 pass Lisp_Object to 'error'; pass the integer instead.
3089 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3090 formatted with plain %d.
3091
b189fa66
PE
3092 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3093
bff87ef0
PE
3094 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3095
7e2cac20
PE
3096 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3097
ce4d90b5
PE
3098 * xterm.c (x_catch_errors): Remove duplicate declaration.
3099
266c9547
PE
3100 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3101
79c49ad2
PE
3102 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3103
368f4090
JM
31042011-04-10 Jim Meyering <meyering@redhat.com>
3105
3106 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3107 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3108 return ssize_t not "int", and use size_t as the buffer length.
3109 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3110 * gnutls.h: Update declarations.
3111 * process.c (read_process_output): Use ssize_t, to match.
3112 (send_process): Likewise.
3113
a32d4040
CY
31142011-04-09 Chong Yidong <cyd@stupidchicken.com>
3115
3116 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3117
8546720e 31182011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3119
04f2d78b
CB
3120 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3121 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3122
8546720e
GM
3123 * xterm.c (handle_one_xevent):
3124 * xmenu.c (create_and_show_popup_menu):
3125 * xselect.c (x_decline_selection_request)
3126 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3127
0a2f5c1a 31282011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3129
3130 Fix some uses of `int' instead of EMACS_INT.
3131 * search.c (string_match_1, fast_string_match)
3132 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3133 (scan_buffer, find_next_newline_no_quit)
3134 (find_before_next_newline, search_command, Freplace_match)
3135 (Fmatch_data): Make some `int' variables be EMACS_INT.
3136
3137 * xdisp.c (display_count_lines): 3rd argument and return value now
3138 EMACS_INT. All callers changed.
3139 (pint2hrstr): Last argument is now EMACS_INT.
3140
3141 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3142 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3143 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3144 (decode_coding_utf_16, decode_coding_emacs_mule)
3145 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3146 (decode_coding_ccl, decode_coding_charset)
3147 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3148 (decode_coding_iso_2022, decode_coding_emacs_mule)
3149 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3150 <char_offset, last_offset>: Declare EMACS_INT.
3151 (encode_coding_utf_8, encode_coding_utf_16)
3152 (encode_coding_emacs_mule, encode_invocation_designation)
3153 (encode_designation_at_bol, encode_coding_iso_2022)
3154 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3155 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3156 Declare EMACS_INT.
3157 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3158 (encode_invocation_designation): Last argument P_NCHARS is now
3159 EMACS_INT.
3160 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3161 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3162
3163 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3164 All users changed.
3165
3166 * ccl.c (Fccl_execute_on_string): Declare some variables
3167 EMACS_INT.
3168
8546720e 31692011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3170
3171 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3172
4e19a977
CS
31732011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3174
3175 * process.c (Fformat_network_address): Doc fix.
3176
87302331
R
31772011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3178
3179 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3180
cbb59342
CY
31812011-04-08 Chong Yidong <cyd@stupidchicken.com>
3182
3183 * keyboard.c (read_char): Call Lisp function help-form-show,
3184 instead of using internal_with_output_to_temp_buffer.
3185 (Qhelp_form_show): New var.
e0d38eeb 3186 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3187
3188 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3189
3190 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3191
e67a13ab
CY
31922011-04-06 Chong Yidong <cyd@stupidchicken.com>
3193
04f2d78b
CB
3194 * process.c (Flist_processes): Remove to Lisp.
3195 (list_processes_1): Delete.
e67a13ab 3196
973f782d
EZ
31972011-04-06 Eli Zaretskii <eliz@gnu.org>
3198
7c106b1e
EZ
3199 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3200
973f782d
EZ
3201 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3202
41cf7d1a 32032011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3204
ca23cc88
PE
3205 Fix more problems found by GCC 4.6.0's static checks.
3206
f390e2d5
PE
3207 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3208
42eea0d0
PE
3209 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3210
b69769da 3211 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3212
f9541e84
PE
3213 * xdisp.c (vmessage): Mark as a printf-like function.
3214
13841b55
PE
3215 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3216
c136c10f
PE
3217 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3218
5e2d4a30
PE
3219 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3220 printf-like functions.
3221 (tiff_load): Add casts to remove these marks before passing them
3222 to system-supplied API.
3223
583f48b9
PE
3224 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3225
b25d760e
PE
3226 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3227 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3228 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3229 directly, rather than having caller test rule sign. This avoids
3230 some unnecessary tests.
3231 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3232 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3233 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3234
bc7b6697 3235 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3236 (xfont_open): Avoid unnecessary tests.
bc7b6697 3237
27ccc379
PE
3238 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3239
dcd5c89a
PE
3240 * composite.h, composite.c (composition_gstring_put_cache):
3241 Use EMACS_INT, not int, for length.
3242
b13a45c6
PE
3243 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3244 breaking out part of COMPOSITION_DECODE_RULE.
3245 (COMPOSITION_DECODE_RULE): Use it.
3246 * composite.c (get_composition_id): Remove unused local vars,
3247 by using the new macro.
3248
1e792e4d
PE
3249 * textprop.c (set_text_properties_1): Change while to do-while,
3250 since the condition is always true at first.
3251
dc6c6455 3252 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3253 (interval_deletion_adjustment): Return unsigned value.
3254 All uses changed.
dc6c6455 3255
aba7731a
PE
3256 * process.c (list_processes_1, create_pty, read_process_output):
3257 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3258 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3259 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3260 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3261 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3262
fdfc4bf3
PE
3263 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3264
fca8fe46 3265 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3266 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3267
06a0259a 3268 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3269 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3270 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3271
e7b9e80f
PE
3272 * print.c (print_error_message): Avoid int overflow.
3273
56201685
PE
3274 * font.c (font_list_entities): Redo for clarity,
3275 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3276
78834453 3277 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3278 (font_score): Avoid potential overflow in diff calculation.
78834453 3279
0bc0b309 3280 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3281 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3282
e610eaca
PE
3283 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3284
b895abce
PE
3285 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3286 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3287 can always succeed if overflow has undefined behavior.
3288
1f1d9321 3289 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3290 (wordify): Omit three unnecessary tests.
1f1d9321 3291
c59478bc
PE
3292 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3293 All callers changed. This avoids the need for an unused var.
3294
79b73827
PE
3295 * casefiddle.c (casify_region): Remove var that is set but not used.
3296
a4db5dfe
PE
3297 * dired.c (file_name_completion): Remove var that is set but not used.
3298
43aae36e
PE
3299 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3300
2a47c44d 3301 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3302 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3303
a37c69bf
PE
3304 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3305 Check for integer overflow on size calculations.
3306
328ab8e7
PE
3307 * buffer.c (Fprevious_overlay_change): Remove var that is set
3308 but not used.
3309
e5a2a5cb
PE
3310 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3311 Remove vars that are set but not used.
8d84a6eb 3312 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3313 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3314
a60e5f68
PE
3315 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3316
f661cb61 3317 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3318 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3319
f0397f5a
PE
3320 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3321 that are set but not used.
3322
8664db06 3323 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3324 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3325
6abdaa4a
PE
3326 * xselect.c (x_get_local_selection, x_handle_property_notify):
3327 Remove vars that are set but not used.
3328
0ce7538d 3329 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3330 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3331
9ae848fc
PE
3332 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3333 Remove var that is set but not used.
0b918413
PE
3334 (scroll_bar_windows_size): Now size_t, not int.
3335 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3336 Check for overflow.
9ae848fc 3337
a5a62657
PE
3338 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3339 (map_tty_color) [!defined MSDOS]: Likewise.
3340
5c5cdd39
PE
3341 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3342
66ebf983
PE
3343 * coding.c: Remove vars that are set but not used.
3344 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3345 All callers changed.
3346 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3347 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3348 (decode_coding_charset): Remove vars that are set but not used.
3349
1be4d761
PE
3350 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3351 that is set but not used.
3352
47553fa8
PE
3353 * print.c (print_object): Remove var that is set but not used.
3354
1f7196bf 3355 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3356 The gnulib version avoids calling malloc in the usual case,
3357 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3358 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3359 * filelock.c (current_lock_owner): Likewise.
3360 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3361 * sysdep.c: Include allocator.h, careadlinkat.h.
3362 (emacs_no_realloc_allocator): New static constant.
3363 (emacs_readlink): New function.
fdb61804
PE
3364 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3365 ../lib/careadlinkat.h.
d1fdcab7 3366
f84c17c7
SM
33672011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3368
3369 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3370 first non-nil return value).
3371
ef3862ad
JD
33722011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3373
3374 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3375 if not defined (Bug#8403).
3376
376a7006
JB
33772011-04-02 Juanma Barranquero <lekktu@gmail.com>
3378
3379 * xdisp.c (display_count_lines): Remove parameter `start',
3380 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3381 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3382 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3383 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3384 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3385 and thereabouts. All callers changed.
3386 (get_per_char_metric): Remove parameter `f', unused since
3387 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3388
6ca3801d
JM
33892011-04-02 Jim Meyering <meyering@redhat.com>
3390
3391 do not dereference NULL upon failed strdup
3392 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3393 (ns_get_family): Likewise.
3394
d8e2b5ba
JB
33952011-04-02 Juanma Barranquero <lekktu@gmail.com>
3396
3397 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3398
8c74fcbd
JD
33992011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3400
3401 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3402 later (Bug#8403).
3403
7200d79c
SM
34042011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3405
03408648 3406 Add lexical binding.
7200d79c 3407
03408648
SM
3408 * window.c (Ftemp_output_buffer_show): New fun.
3409 (Fsave_window_excursion):
3410 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3411
3412 * lread.c (lisp_file_lexically_bound_p): New function.
3413 (Fload): Bind Qlexical_binding.
3414 (readevalloop): Remove `evalfun' arg.
3415 Bind Qinternal_interpreter_environment.
3416 (Feval_buffer): Bind Qlexical_binding.
3417 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3418 Mark as dynamic.
3419 (syms_of_lread): Declare `lexical-binding'.
3420
3421 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3422
3423 * keyboard.c (eval_dyn): New fun.
3424 (menu_item_eval_property): Use it.
ca105506
SM
3425
3426 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3427
03408648
SM
3428 * fns.c (concat, mapcar1): Accept byte-code-functions.
3429
3430 * eval.c (Fsetq): Handle lexical vars.
3431 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3432 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3433 (FletX, Flet): Obey lexical binding.
3434 (Fcommandp): Handle closures.
3435 (Feval): New `lexical' arg.
3436 (eval_sub): New function extracted from Feval. Use it almost
3437 everywhere where Feval was used. Look up vars in lexical env.
3438 Handle closures.
3439 (Ffunctionp): Move from subr.el.
3440 (Ffuncall): Handle closures.
3441 (apply_lambda): Remove `eval_flags'.
3442 (funcall_lambda): Handle closures and new byte-code-functions.
3443 (Fspecial_variable_p): New function.
3444 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3445 but without exporting it to Lisp.
23aba0ea 3446
23aba0ea 3447 * doc.c (Fdocumentation, store_function_docstring):
03408648 3448 * data.c (Finteractive_form): Handle closures.
23aba0ea 3449
03408648
SM
3450 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3451 interactive spec.
ba83908c 3452
04f2d78b
CB
3453 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3454 New byte-codes.
03408648
SM
3455 (exec_byte_code): New function extracted from Fbyte_code to handle new
3456 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3457
03408648 3458 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3459
03408648 3460 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3461
e2abce01
JB
34622011-03-31 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * xdisp.c (redisplay_internal): Fix prototype.
3465
63696a73 34662011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3467
63696a73 3468 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3469 (try_scrolling): Use it when setting scroll_limit.
3470 Limit scrolling to 100 screen lines.
63696a73
EZ
3471 (redisplay_window): Even when falling back on "recentering",
3472 position point in the window according to scroll-conservatively,
3473 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3474
3475 (try_scrolling): When point is above the window, allow searching
3476 as far as scroll_max, or one screenful, to compute vertical
3477 distance from PT to the scroll margin position. This prevents
3478 try_scrolling from unnecessarily failing when
3479 scroll-conservatively is set to a value slightly larger than the
3480 window height. Clean up the case of PT below the margin at bottom
3481 of window: scroll_max can no longer be INT_MAX. When aggressive
3482 scrolling is in use, don't let point enter the opposite scroll
3483 margin as result of the scroll.
3484 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3485 threshold of 100 lines for never-recentering scrolling.
3486
e4cc2dfc
JB
34872011-03-31 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * dispextern.h (move_it_by_lines):
3490 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3491 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3492 (message_log_check_duplicate): Remove parameters `prev_bol' and
3493 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3494 (redisplay_internal): Remove parameter `preserve_echo_area',
3495 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3496
3497 * indent.c (Fvertical_motion):
3498 * window.c (window_scroll_pixel_based, Frecenter):
3499 Don't pass `need_y_p' to `move_it_by_lines'.
3500
1c470562
SM
35012011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3502
44f230aa
SM
3503 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3504 steal a few bits to be more compact.
3505 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3506 Remove unneeded casts.
3507
1c470562
SM
3508 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3509
888adce9
ZK
35102011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3511
3512 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3513 binding" message (bug#7967).
3514
f838ed7b
PE
35152011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3516
77861b95
PE
3517 Fix more problems found by GCC 4.6.0's static checks.
3518
de6dbc14
PE
3519 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3520 Remove unused local var.
3521
f838ed7b
PE
3522 * editfns.c (Fmessage_box): Remove unused local var.
3523
792c7b2b
PE
3524 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3525 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3526 Omit unused local vars.
c499e557 3527 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3528 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3529 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3530 Omit unused local var.
3531
ba0165e1
PE
3532 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3533 Don't assume string length fits in int.
32ad8845 3534 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3535 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3536
3c59b4c9
PE
3537 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3538 instead of alloca (Bug#8344).
3539
a3eed478 3540 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3541 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3542
eb4d412d
PE
3543 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3544
1658b401
PE
3545 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3546 concerns.
3547
3548 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3549
3550 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3551
9a2c6e05
PE
3552 * keyboard.c (syms_of_keyboard): Use the same style as later
3553 in this function when indexing through an array. This also
3554 works around GCC bug 48267.
3555
03d0a109
PE
3556 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3557
44f730c8
PE
3558 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3559
fe75f926
PE
3560 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3561 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3562
ffa8c828
PE
3563 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3564 This avoids undefined behavior on integer overflow, and is a bit
3565 more convenient anyway since it is compared to a size_t variable.
3566
c5101a77
PE
3567 Variadic C functions now count arguments with size_t, not int.
3568 This avoids an unnecessary limitation on 64-bit machines, which
3569 caused (substring ...) to crash on large vectors (Bug#8344).
3570 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3571 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3572 All variadic functions and their callers changed accordingly.
c5101a77
PE
3573 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3574 * data.c (arith_driver, float_arith_driver): Likewise.
3575 * editfns.c (general_insert_function): Likewise.
3576 * eval.c (struct backtrace.nargs, interactive_p)
3577 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3578 (funcall_lambda, mark_backtrace): Likewise.
3579 * fns.c (concat): Likewise.
3580 * frame.c (x_set_frame_parameters): Likewise.
3581 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3582 0 if not found, not -1. All callers changed.
3583
dd3f25f7
PE
3584 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3585 (stack_copy_size): Now size_t, not int.
3586 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3587
461c2ab9
JB
35882011-03-28 Juanma Barranquero <lekktu@gmail.com>
3589
3590 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3591 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3592 All callers changed.
3593
3594 * lisp.h (multibyte_char_to_unibyte):
3595 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3596 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3597 * character.h (CHAR_TO_BYTE8):
3598 * cmds.c (internal_self_insert):
3599 * editfns.c (general_insert_function):
3600 * keymap.c (push_key_description):
3601 * search.c (Freplace_match):
3602 * xdisp.c (message_dolog, set_message_1): All callers changed.
3603
f6d62986
SM
36042011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3605
3606 * keyboard.c (safe_run_hook_funcall): New function.
3607 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3608 don't set the hook to nil, but remove the offending function instead.
3609 (Qcommand_hook_internal): Remove, unused.
3610 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3611 Vcommand_hook_internal.
3612
3613 * eval.c (enum run_hooks_condition): Remove.
3614 (funcall_nil, funcall_not): New functions.
3615 (run_hook_with_args): Call each function through a `funcall' argument.
3616 Remove `cond' argument, now redundant.
3617 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3618 (Frun_hook_with_args_until_failure): Adjust accordingly.
3619 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3620
1db5b1ad
JB
36212011-03-28 Juanma Barranquero <lekktu@gmail.com>
3622
3623 * dispextern.h (string_buffer_position): Remove declaration.
3624
3625 * print.c (strout): Remove parameter `multibyte', unused since
3626 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3627
3628 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3629 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3630 All callers changed.
3631
3632 * w32.c (_wsa_errlist): Use braces for struct initializers.
3633
3634 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3635 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3636 All callers changed.
3637 (string_buffer_position): Likewise. Also, make static (it's never
3638 used outside xdisp.c).
3639 (cursor_row_p): Remove parameter `w', unused since
3640 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3641 (decode_mode_spec): Remove parameter `precision', introduced during
3642 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3643 All callers changed.
3644
5ffb62aa
JD
36452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3648
461c2ab9 36492011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3650
3651 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3652 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3653 (ns_update_auto_hide_menu_bar): New functions.
3654 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3655 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3656 ns_constrain_all_frames.
3657 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3658 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3659
5c380ffb
JD
36602011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3661
3662 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3663
9af30bdf
GM
36642011-03-27 Glenn Morris <rgm@gnu.org>
3665
3666 * syssignal.h: Replace RETSIGTYPE with void.
3667 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3668 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3669 Replace SIGTYPE with void everywhere.
3670 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3671 * s/template.h (SIGTYPE): Remove commented out definition.
3672
e2abce01
JB
36732011-03-26 Eli Zaretskii <eliz@gnu.org>
3674
3675 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3676 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3677
f868cd8a
JB
36782011-03-26 Juanma Barranquero <lekktu@gmail.com>
3679
59eb0929
JB
3680 * w32.c (read_unc_volume): Use parameter `henum', instead of
3681 global variable `wget_enum_handle'.
3682
3683 * keymap.c (describe_vector): Remove parameters `indices' and
3684 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3685 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3686
f868cd8a
JB
3687 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3688
3689 * keyboard.c (timer_check): Remove parameter `do_it_now',
3690 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3691 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3692 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3693
3694 * keyboard.c (read_char):
3695 * w32menu.c (w32_menu_display_help):
3696 * xmenu.c (show_help_event, menu_help_callback):
3697 Adjust calls to `show_help_echo'.
3698
3699 * gtkutil.c (xg_maybe_add_timer):
3700 * keyboard.c (readable_events):
3701 * process.c (wait_reading_process_output):
3702 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3703
3704 * insdel.c (adjust_markers_gap_motion):
3705 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3706 (gap_left, gap_right): Don't call it.
3707
2ecf6fdb
CY
37082011-03-25 Chong Yidong <cyd@stupidchicken.com>
3709
3710 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3711 incurred during fontification.
3712
6b1f9ba4
JB
37132011-03-25 Juanma Barranquero <lekktu@gmail.com>
3714
3715 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3716 (DEFVAR_PER_BUFFER): Don't pass it.
3717
3718 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3719 (scrolling_window): Don't pass it.
3720
0f4a96b5
JB
37212011-03-25 Juanma Barranquero <lekktu@gmail.com>
3722
3723 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3724
3725 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3726 and `suffix'.
3727 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3728 of variables specific to SELinux and computation of `encoded_absname'.
3729
3730 * image.c (XPutPixel): Remove unused variable `height'.
3731
3732 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3733
3734 * unexw32.c (get_section_info): Remove unused variable `section'.
3735
3736 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3737 (system_process_attributes): Remove unused variable `sess'.
3738 (sys_read): Remove unused variable `err'.
3739
3740 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3741 (w32_wnd_proc): Remove unused variable `isdead'.
3742 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3743 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3744 (x_create_tip_frame): Remove unused variable `tem'.
3745
3746 * w32inevt.c (w32_console_read_socket):
3747 Remove unused variable `no_events'.
3748
3749 * w32term.c (x_draw_composite_glyph_string_foreground):
3750 Remove unused variable `width'.
3751
1149507c
JB
37522011-03-24 Juanma Barranquero <lekktu@gmail.com>
3753
3754 * w32term.c (x_set_glyph_string_clipping):
3755 Don't pass uninitialized region to CombineRgn.
3756
9c88f339
JB
37572011-03-23 Juanma Barranquero <lekktu@gmail.com>
3758
3759 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3760 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3761 (Fx_close_connection): Remove unused variable `i'.
3762
3763 * w32font.c (w32font_draw): Return number of glyphs.
3764 (w32font_open_internal): Remove unused variable `i'.
3765 (w32font_driver): Add missing initializer.
3766
3767 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3768 (fill_in_menu): Remove unused variable `items_added'.
3769
3770 * w32term.c (last_mouse_press_frame): Remove static global variable.
3771 (w32_clip_to_row): Remove unused variable `f'.
3772 (x_delete_terminal): Remove unused variable `i'.
3773
3774 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3775 (NOTHING): Remove unused static global variable.
3776 (uniscribe_check_otf): Remove unused variable `table'.
3777 (uniscribe_font_driver): Add missing initializers.
3778
dee091a3
JD
37792011-03-23 Julien Danjou <julien@danjou.info>
3780
3781 * term.c (Fsuspend_tty, Fresume_tty):
3782 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3783 * window.c (temp_output_buffer_show):
3784 * insdel.c (signal_before_change):
3785 * frame.c (Fhandle_switch_frame):
3786 * fileio.c (Fdo_auto_save):
3787 * emacs.c (Fkill_emacs):
3788 * editfns.c (save_excursion_restore):
3789 * cmds.c (internal_self_insert):
3790 * callint.c (Fcall_interactively):
3791 * buffer.c (Fkill_all_local_variables):
3792 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3793 Use Frun_hooks.
0f4a96b5 3794 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3795 unconditionnaly since it does the check itself.
3796
2c520ab5 37972011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3798
c9c49752
PE
3799 Fix more problems found by GCC 4.5.2's static checks.
3800
8abc3f12
PE
3801 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3802 the first time through the loop, since we know p0 < p1 then.
3803 This also avoids a gcc -Wstrict-overflow warning.
3804
a2d26660
PE
3805 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3806 leading to a memory leak, possible in functions like
3807 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3808 of objects (Bug#8318).
a2d26660 3809
916c72e9
PE
3810 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3811 that could (at least in theory) be that large.
3812
19ab8a18
PE
3813 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3814 This is less likely to overflow, and avoids undefined behavior if
3815 overflow does occur. All callers changed. Use strtoul to scan
3816 for the unsigned long integer.
b7cbbd6f
PE
3817 (pint2hrstr): Simplify and tune code slightly.
3818 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3819
f0641eff
PE
3820 * scroll.c (do_scrolling): Work around GCC bug 48228.
3821 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3822
7f650bb9
PE
3823 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3824 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3825 (validate_x_resource_name): Simplify count usage.
3826 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3827
37dd57d1
PE
3828 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3829 fail (Bug#8306).
81e56e61 3830
699979fc 3831 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3832
401bf9b4
PE
3833 * process.c (Fmake_network_process): Use socklen_t, not int,
3834 where POSIX says socklen_t is required in portable programs.
3835 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3836 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3837 (Fmake_network_process, server_accept_connection):
3838 (wait_reading_process_output, read_process_output):
3839 Likewise.
3840
b93aacde
PE
3841 * process.c: Rename or move locals to avoid shadowing.
3842 (list_processes_1, Fmake_network_process):
3843 (read_process_output_error_handler, exec_sentinel_error_handler):
3844 Rename or move locals.
4dc343ee 3845 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3846 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3847 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3848 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3849 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3850
af8a867c 3851 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3852 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3853 Include tparam.h instead, since it declares them.
af8a867c
PE
3854 * cm.h (PC): Remove extern decl; tparam.h now does this.
3855 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3856 * terminfo.c: Include tparam.h, to check interfaces.
3857 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3858 (tparam): Adjust signature to match interface in tparam.h;
3859 this removes some undefined behavior. Check that outstring and len
3860 are zero, which they always are with Emacs.
3861 * tparam.h (PC, BC, UP): New extern decls.
3862
0248044d 3863 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3864 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3865
8ff096c1 3866 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3867 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3868 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3869 (ftfont_list): Remove unused local.
49eaafba
PE
3870 (get_adstyle_property, ftfont_pattern_entity):
3871 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3872 Rename locals to avoid shadowing.
8ff096c1 3873
e2be39f6
PE
3874 * xfont.c (xfont_list_family): Mark var as initialized.
3875
c9735e30
PE
3876 * xml.c (make_dom): Now static.
3877
8f5201ae
PE
3878 * composite.c (composition_compute_stop_pos): Rename local to
3879 avoid shadowing.
b246f932
PE
3880 (composition_reseat_it): Remove unused locals.
3881 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3882 (composition_update_it): Mark var as initialized.
11b61122
PE
3883 (find_automatic_composition): Mark vars as initialized,
3884 with a FIXME (Bug#8290).
8f5201ae 3885
760fbc2c
PE
3886 character.h: Rename locals to avoid shadowing.
3887 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3888 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3889 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3890 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3891 to avoid shadowing.
3892
ff08eb85
PE
3893 * textprop.c (property_change_between_p): Remove; unused.
3894
fc7bf025
PE
3895 * intervals.c (interval_start_pos): Now static.
3896
235d7abc
PE
3897 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3898
44f230aa
SM
3899 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3900 Rename locals to avoid shadowing.
3e7d6594 3901
50060332
PE
3902 * sound.c (wav_play, au_play, Fplay_sound_internal):
3903 Fix pointer signedness.
d01f234b 3904 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3905 (wav_play): Initialize a variable to 0, to prevent undefined
3906 behavior (Bug#8278).
50060332 3907
c4fc4e30
PE
3908 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3909
918436ed
PE
3910 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3911
c939f91b
PE
3912 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3913 clobbering (Bug#8298).
b9c7f648
PE
3914 * sysdep.c (sys_subshell): Likewise.
3915 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3916
6bd8c144
PE
3917 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3918 This should get cleaned up, so that child_setup has the
3919 same signature on all platforms.
3920
7710357c 3921 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3922 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3923
c59da222
CY
39242011-03-22 Chong Yidong <cyd@stupidchicken.com>
3925
3926 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3927 not to be necessary, and produces flickering.
3928
66b87493
GM
39292011-03-20 Glenn Morris <rgm@gnu.org>
3930
3931 * config.in: Remove file.
3932
45b6f6d5
JB
39332011-03-20 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3936 are now in src/globals.h.
3937 (syms_of_minibuf): Remove spurious & from previous change.
3938
3ec03f7e
LL
39392011-03-20 Leo <sdl.web@gmail.com>
3940
3941 * minibuf.c (completing-read-function): New variable.
3942 (completing-read-default): Rename from completing-read.
3943 (completing-read): Call completing-read-function.
3944
b14e3e21
CY
39452011-03-19 Juanma Barranquero <lekktu@gmail.com>
3946
3947 * xfaces.c (Fx_load_color_file):
3948 Read color file from absolute filename (bug#8250).
3949
f2b726e6
JB
39502011-03-19 Juanma Barranquero <lekktu@gmail.com>
3951
3952 * makefile.w32-in: Update dependencies.
3953
09f6ff02
EZ
39542011-03-17 Eli Zaretskii <eliz@gnu.org>
3955
3956 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3957
29a6015a
PE
39582011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3959
a3a6c54e
PE
3960 Fix more problems found by GCC 4.5.2's static checks.
3961
b766f867
PE
3962 * process.c (make_serial_process_unwind, send_process_trap):
3963 (sigchld_handler): Now static.
3964
be02381c
PE
3965 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3966 That way, the code declares only the vars that it needs.
3967 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3968 * s/cygwin.h (PTY_ITERATION): Likewise.
3969 * s/darwin.h (PTY_ITERATION): Likewise.
3970 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3971
57048744
PE
3972 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3973 * process.c (allocate_pty): Don't declare stb unless it's needed.
3974
7914961c 3975 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3976 (CONSTANTLIM): Remove; unused.
3977 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3978 Define only if needed.
7914961c 3979
b3967b18
PE
3980 * unexelf.c (unexec): Name an expression,
3981 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3982 Use a different way to cause a compilation error if anyone uses
3983 n rather than nn, a way that does not involve shadowing.
73366a00 3984 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3985
29a6015a
PE
3986 * deps.mk (unexalpha.o): Remove; unused.
3987
43cfc33e 3988 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3989 * unexec.h: New file.
ce701a33
PE
3990 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3991 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3992 Depend on unexec.h.
3993 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3994 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3995 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3996 Change as necessary to match prototype in unexec.h.
ce701a33 3997
01f44d5a
PE
3998 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3999 shadowing.
4f63c6bb 4000 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4001
a6670b0b
PE
4002 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4003 Rename locals to avoid shadowing.
4004
cef2010d 4005 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4006 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4007
d4d7173a
PE
4008 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4009
f08b802a
PE
4010 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4011 warning when compiling print.c.
4012
3ddb0639
PE
4013 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4014 instead of using an uninitialized var.
5ad03b97 4015 (font_sort_entities): Mark var as initialized.
3ddb0639 4016
170a2692
PE
4017 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4018
e663c700
PE
4019 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4020 pointers to constants.
89bc529a 4021 (font_parse_fcname): Remove unused vars.
7b81e2d0 4022 (font_delete_unmatched): Now static.
ea838e10 4023 (font_get_spec): Remove; unused.
13a547c6
PE
4024 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4025 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4026 Rename or move locals to avoid shadowing.
e663c700 4027
2a80c887 4028 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4029 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4030
1384fa33 4031 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4032 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4033
8b2c52e9
PE
4034 * alloc.c (mark_backtrace): Move decl from here ...
4035 * lisp.h: ... to here, so that it can be checked.
4036
475545b5 4037 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4038 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4039 (lisp_indirect_variable): Name an expression,
4040 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4041 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4042
b1349114 4043 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4044 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4045 Use const pointer when appropriate.
b1349114 4046
a2928364
PE
4047 * lisp.h (get_system_name, get_operating_system_release):
4048 Move decls here, to check interfaces.
4049 * process.c (get_operating_system_release): Move decl to lisp.h.
4050 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4051 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4052 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4053 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4054 (Fformat_time_string, Fencode_time, Finsert_char):
4055 (Ftranslate_region_internal, Fformat):
4056 Rename or remove local vars to avoid shadowing.
9710023e 4057 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4058
a415e694
PE
4059 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4060 avoid shadowing.
4061
8ef4622d
PE
4062 * lisp.h (eassert): Check that the argument compiles, even if
4063 ENABLE_CHECKING is not defined.
4064
946f9a5b
PE
4065 * data.c (Findirect_variable): Name an expression, to avoid
4066 gcc -Wbad-function-cast warning.
112396d6 4067 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4068 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4069 (Fmake_variable_buffer_local, Fmake_local_variable):
4070 Mark variables as initialized.
52746918 4071 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4072
e5aab7e7 4073 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4074 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4075 Rename locals to avoid shadowing.
dff45157
PE
4076 (mark_stack): Move local variables into the #ifdef region where
4077 they're used.
7bc26fdb
PE
4078 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4079 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4080 needed otherwise.
4081 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4082 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4083 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4084
e5aab7e7
PE
4085 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4086 avoids undefined behavior in theory.
4087
4da60324
PE
4088 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4089
88043301
PE
4090 Use functions, not macros, for up- and down-casing (Bug#8254).
4091 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4092 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4093 to use the following functions instead of these macros.
4094 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4095 EMACS_INT, since callers assume the returned value fits in int.
4096 (upcase1): Likewise, for UPCASE_TABLE.
4097 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4098 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4099 the race-condition problem in the old DOWNCASE.
88043301 4100
19ed5445
PE
4101 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4102 Rename locals to avoid shadowing.
4103 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4104 (regex_compile, re_search_2, re_match_2_internal):
4105 Remove unused local vars.
952db0d7
PE
4106 (FREE_VAR): Rewrite so as not to use empty "else",
4107 which gcc can warn about.
da053e48 4108 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4109 (RETALLOC_IF): Define only if needed.
4110 (WORDCHAR_P): Likewise. This one is never needed, but is used
4111 only in a comment talking about a compiler bug, so put inside
4112 the #if 0 of that comment.
4113 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4114 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4115 Remove; unused.
19ed5445 4116
1f3561e4 4117 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4118 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4119 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4120
ded6f8f7
PE
4121 * search.c (simple_search): Remove unused var.
4122
dbd37a95
PE
4123 * dired.c (compile_pattern): Move decl from here ...
4124 * lisp.h: ... to here, so that it can be checked.
4125 (struct re_registers): New forward decl.
4126
7e47afad
PE
4127 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4128
85f24f61
PE
4129 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4130 All uses changed.
4131 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4132 Rename locals to avoid shadowing.
5671df8f 4133 (Fvertical_motion): Mark locals as initialized.
85f24f61 4134
181aa2be 4135 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4136 (casify_region): Mark local as initialized.
181aa2be 4137
930d429c
PE
4138 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4139
7082eac6
PE
4140 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4141 New macros, so that the caller can use some names other than
4142 gcpro1, gcpro2, etc.
4143 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4144 of the new macros.
4145 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4146 argument, for consistency with GCPRO2_VAR, etc: it is now the
4147 prefix of the variable, not the variable itself. All uses
4148 changed.
38b2c076
PE
4149 * dired.c (directory_files_internal, file_name_completion):
4150 Rename locals to avoid shadowing.
4151
15206ed9
PE
4152 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4153 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4154 dired.c's scmp function, had undefined behavior.
4155 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4156 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4157 * buffer.h: ... to here, because these macros use current_buffer,
4158 and the new implementation with inline functions needs to have
4159 current_buffer in scope now, rather than later when the macros
4160 are used.
4161 (downcase, upcase1): New static inline functions.
4162 (DOWNCASE, UPCASE1): Reimplement using these functions.
4163 This avoids undefined behavior in expressions like
4164 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4165 from race conditions in accessing the global variables
4166 case_temp1 and case_temp2.
4167 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4168 * lisp.h (case_temp1, case_temp2): Remove their decls.
4169 * character.h (ASCII_CHAR_P): Move from here ...
4170 * lisp.h: ... to here, so that the inline functions mentioned
4171 above can use them.
4172
4a6bea26
PE
4173 * dired.c (directory_files_internal_unwind): Now static.
4174
f14b7e14
PE
4175 * fileio.c (file_name_as_directory, directory_file_name):
4176 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4177 Now static.
2893f146
PE
4178 (file_name_as_directory): Use const pointers when appropriate.
4179 (Fexpand_file_name): Likewise. In particular, newdir might
4180 point at constant storage, so make it a const pointer.
fd4ead52 4181 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4182 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4183 signedness issues.
f839df0c
PE
4184 (Fset_file_times, Finsert_file_contents, auto_save_error):
4185 Rename locals to avoid shadowing.
f14b7e14 4186
5716756e 4187 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4188 (Ftry_completion, Fall_completions): Rename or remove locals
4189 to avoid shadowing.
5716756e 4190
b4c3046a
PE
4191 * marker.c (bytepos_to_charpos): Remove; unused.
4192
b45db522
PE
4193 * lisp.h (verify_bytepos, count_markers): New decls,
4194 so that gcc does not warn that these functions aren't declared.
4195
85876d07
PE
4196 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4197 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4198 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4199 (copy_text): Remove unused local var.
85876d07 4200
03d78a21 4201 * filelock.c (within_one_second): Now static.
b3dd38ab 4202 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4203
5df8f01b
PE
4204 * buffer.c (fix_overlays_before): Mark locals as initialized.
4205 (fix_start_end_in_overlays): Likewise. This function should be
4206 simplified by using pointers-to-pointers, but that's a different
4207 matter.
b1d876f1 4208 (switch_to_buffer_1): Now static.
8f54f30a
PE
4209 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4210 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4211
a70072c9 4212 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4213 Fix pointer signedness issue.
edced198
PE
4214 (sys_subshell): Mark local as volatile if checking for lint,
4215 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4216 (MAXPATHLEN): Define only if needed.
a70072c9 4217
a0977c44
PE
4218 * process.c (serial_open, serial_configure): Move decls from here ...
4219 * systty.h: ... to here, so that they can be checked.
4220
a884fdcc
PE
4221 * fns.c (get_random, seed_random): Move extern decls from here ...
4222 * lisp.h: ... to here, so that they can be checked.
4223
604efe86 4224 * sysdep.c (reset_io): Now static.
b8950c94 4225 (wait_for_termination_signal): Remove; unused.
604efe86 4226
38fc62d9
PE
4227 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4228 (copy_keymap_item, append_key, push_text_char_description):
4229 Now static.
1004a21a 4230 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4231 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4232 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4233 (describe_map_tree):
4234 Rename locals to avoid shadowing.
38fc62d9 4235
2f2650da
PE
4236 * keyboard.c: Declare functions static if they are not used elsewhere.
4237 (echo_char, echo_dash, cmd_error, top_level_2):
4238 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4239 (read_char, kbd_buffer_get_event, make_lispy_position):
4240 (make_lispy_event, make_lispy_movement, apply_modifiers):
4241 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4242 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4243 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4244 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4245 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4246
a053e86c 4247 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4248 (mark_kboards): Move decl here ...
4249 * alloc.c (mark_kboards): ... from here.
a053e86c 4250
4752793e
PE
4251 * lisp.h (force_auto_save_soon): New decl.
4252
74f10ca7 4253 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4254 (DEFINE_DUMMY_FUNCTION): New macro.
4255 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4256 Use it.
c03cd23f
PE
4257 (main): Add casts to avoid warnings
4258 if GCC considers string literals to be constants.
74f10ca7 4259
022e70d4
PE
4260 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4261
59d6fe83
PE
4262 * dbusbind.c: Pointer signedness fixes.
4263 (xd_signature, xd_append_arg, xd_initialize):
4264 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4265 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4266 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4267 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4268
78320123
PE
4269 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4270 if GCC considers string literals to be constants.
49cebcca 4271 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4272
35ac2a97
SM
42732011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4274
fb103ca9
SM
4275 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4276 (print_preprocess, print_object): New macro to fix last change.
4277
35ac2a97
SM
4278 * print.c (print_preprocess): Don't forget font objects.
4279
62973b41
JB
42802011-03-16 Juanma Barranquero <lekktu@gmail.com>
4281
4282 * emacs.c (USAGE3): Doc fixes.
4283
0e48bb22
AS
42842011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4285
4286 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4287 structure.
4288
7684e57b
JB
42892011-03-14 Juanma Barranquero <lekktu@gmail.com>
4290
4291 * lisp.h (VWindow_system, Qfile_name_history):
4292 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4293 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4294 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4295
4296 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4297 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4298
4299 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4300 * w32console.c (detect_input_pending, read_input_pending)
4301 (encode_terminal_code):
4302 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4303 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4304 (w32_system_caret_y, Qfile_name_history):
4305 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4306 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4307 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4308 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4309 * w32proc.c (Qlocal, report_file_error):
4310 * w32term.c (Vwindow_system, updating_frame):
4311 * w32uniscribe.c (initialized, uniscribe_font_driver):
4312 Remove unneeded extern declarations.
4313
2aa46d6c
CY
43142011-03-14 Chong Yidong <cyd@stupidchicken.com>
4315
c96bbc66 4316 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4317
cffc6f3b
CY
43182011-03-13 Chong Yidong <cyd@stupidchicken.com>
4319
4320 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4321 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4322 These macros can no longer be used for assignment.
4323
44f230aa
SM
4324 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4325 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4326 (record_buffer_markers, fetch_buffer_markers): New functions for
4327 recording and fetching special buffer markers.
4328 (set_buffer_internal_1, set_buffer_temp): Use them.
4329
4330 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4331
4332 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4333
4334 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4335 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4336
4337 * xdisp.c (hscroll_window_tree):
4338 (reconsider_clip_changes): Use PT instead of BUF_PT.
4339
d251f04b
EZ
43402011-03-13 Eli Zaretskii <eliz@gnu.org>
4341
4342 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4343 $(EMACS_ROOT)/lib/intprops.h.
4344
f0c77cd1
PE
43452011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4346
3eca4629
PE
4347 Fix more problems found by GCC 4.5.2's static checks.
4348
7c86ee98
PE
4349 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4350 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4351 (xg_free_frame_widgets): Make it clear that a local variable is
4352 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4353 (gdk_window_get_screen): Make it clear that this macro is needed
4354 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4355 (int_gtk_range_get_value): New function, which avoids a diagnostic
4356 from gcc -Wbad-function-cast.
4357 (xg_set_toolkit_scroll_bar_thumb): Use it.
4358 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4359 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4360 (get_utf8_string, xg_get_file_with_chooser):
4361 Rename locals to avoid shadowing.
4362 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4363
41729b81
PE
4364 * xgselect.c (xg_select): Remove unused var.
4365
f0c77cd1
PE
4366 * image.c (four_corners_best): Mark locals as initialized.
4367 (gif_load): Initialize transparent_p to zero (Bug#8238).
4368 Mark another local as initialized.
ec6cf4c6 4369 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4370
ce0ad53d 4371 * image.c (clear_image_cache): Now static.
d5d5a617 4372 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4373 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4374 (x_edge_detection): Remove unnecessary cast that
4375 gcc -Wbad-function-cast diagnoses.
2037898d 4376 (gif_load): Fix pointer signedness.
6ae141d6
PE
4377 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4378 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4379
33383987 43802011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4381
d32df629
PE
4382 Improve quality of tests for time stamp overflow.
4383 For example, without this patch (encode-time 0 0 0 1 1
4384 1152921504606846976) returns the obviously-bogus value (-948597
4385 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4386 reports time overflow. See
4387 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4388 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4389 * editfns.c: Include limits.h and intprops.h.
4390 (TIME_T_MIN, TIME_T_MAX): New macros.
4391 (time_overflow): Move earlier, to before first use.
4392 (hi_time, lo_time): New functions, for an accurate test for
4393 out-of-range times.
4394 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4395 (Fget_internal_run_time): Don't assume time_t fits in int.
4396 (make_time): Use list2 instead of Fcons twice.
4397 (Fdecode_time): More accurate test for out-of-range times.
4398 (check_tm_member): New function.
4399 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4400 (lisp_time_argument): Don't rely on undefined left-shift and
4401 right-shift behavior when checking for time stamp overflow.
8be6f318 4402
fe31d94c
PE
4403 * editfns.c (time_overflow): New function, refactoring common code.
4404 (Fformat_time_string, Fdecode_time, Fencode_time):
4405 (Fcurrent_time_string): Use it.
4406
8be6f318
PE
4407 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4408 * dired.c (make_time): Move to ...
4409 * editfns.c (make_time): ... here.
4410 * systime.h: Note the move.
4411
09d9db2c 44122011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4413
126bc0dc
YM
4414 * fringe.c (update_window_fringes): Remove unused variables.
4415
c47cbdfd
YM
4416 * unexmacosx.c (copy_data_segment): Also copy __got section.
4417 (Bug#8223)
4418
7ac80be9
EZ
44192011-03-12 Eli Zaretskii <eliz@gnu.org>
4420
c96bbc66 4421 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4422 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4423 Constify `char *' arguments and their references according to
4424 prototypes in tparam.h.
4425
ecb0f94d 4426 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4427
7ac80be9
EZ
4428 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4429 Adapt all references accordingly.
4430
4431 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4432
ef1fd07e
TT
44332011-03-11 Tom Tromey <tromey@redhat.com>
4434
4435 * buffer.c (syms_of_buffer): Remove obsolete comment.
4436
7ef4b50c
EZ
44372011-03-11 Eli Zaretskii <eliz@gnu.org>
4438
4439 * termhooks.h (encode_terminal_code): Declare prototype.
4440
4441 * msdos.c (encode_terminal_code): Don't declare prototype.
4442
4443 * term.c (encode_terminal_code): Now external again, used by
4444 w32console.c and msdos.c.
4445
44f230aa
SM
4446 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4447 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4448
4b1ec863 44492011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4450
1714f52b 4451 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4452
4b1ec863
PE
4453 * fringe.c (update_window_fringes): Mark locals as initialized
4454 (Bug#8227).
4455 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4456
524c7aa6
PE
4457 * alloc.c (mark_fringe_data): Move decl from here ...
4458 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4459 to check its interface.
4460 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4461
a5c0af81 4462 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4463 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4464 (fontset_font): Mark local as initialized.
a9a06e0b 4465 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4466
b4716021
PE
4467 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4468
811e9bac 4469 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4470 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4471 (x_own_selection, Fx_disown_selection_internal): Rename locals
4472 to avoid shadowing.
4473 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4474
7e3ab302
PE
4475 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4476 so that the caller can use some name other than gcpro1.
4477 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4478 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4479 (Fx_backspace_delete_keys_p):
4480 Use them to avoid shadowing, and rename vars to avoid shadowing.
4481 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4482 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4483 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4484 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4485 Remove unused locals.
7e3ab302
PE
4486 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4487 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4488 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4489 macros.
f78faa98 4490
e2b13473
PE
4491 * xterm.h (x_mouse_leave): New decl.
4492
77f23912
PE
4493 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4494 Remove unused functions.
cdf4ba58
PE
4495 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4496 (x_calc_absolute_position): Now static.
7411c686 4497 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4498 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4499 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4500 unless they are used.
38d0b34a
PE
4501 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4502 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4503 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4504 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4505 (x_error_catcher, x_connection_closed, x_error_handler):
4506 (x_error_quitter, xembed_send_message, x_iconify_frame):
4507 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4508 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4509 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4510
44f230aa
SM
4511 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4512 Rename or move locals to avoid shadowing.
6b463e58 4513 (tty_defined_color, merge_face_heights): Now static.
5967d051 4514 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4515 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4516 does not deduce is never used uninitialized.
73719eba
PE
4517 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4518 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4519
426994c3 4520 * terminal.c (store_terminal_param): Now static.
5489860b 4521
032f1620 4522 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4523 (set_frame_menubar): Remove unused local.
d4323972 4524 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4525 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4526 since they might point to immutable storage.
281585b0
PE
4527 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4528 since it's unused otherwise.
032f1620 4529
367c19e5 4530 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4531 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4532 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4533 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4534 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4535 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4536 does not deduce are never used uninitialized.
70739cbe 4537
07b48fa9
PE
4538 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4539
8868a238 4540 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4541 * window.c (window_loop, size_window):
4542 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4543
7e5cf297 4544 * window.c (display_buffer): Now static.
d6550a9f
PE
4545 (size_window): Mark variables that gcc -Wuninitialized
4546 does not deduce are never used uninitialized.
a586633d
PE
4547 * window.h (check_all_windows): New decl, to forestall
4548 gcc -Wmissing-prototypes diagnostic.
5b555da1 4549 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4550
f6095868
PE
4551 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4552 shadowing.
4553 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4554 Include <limits.h>.
4555 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4556 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4557 (load_charset_map): Mark variables that gcc -Wuninitialized
4558 does not deduce are never used uninitialized.
53df7c11 4559 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4560
f38b440c
PE
4561 * coding.c (coding_set_source, coding_set_destination):
4562 Use "else { /* comment */ }" rather than "else /* comment */;"
4563 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4564 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4565 a block, when the outer 'i' will do.
4566 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4567 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4568 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4569 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4570 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4571 Rename locals to avoid shadowing.
4572 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4573 * coding.c (emacs_mule_char, encode_invocation_designation):
4574 Now static, since they're not used elsewhere.
413bb2db 4575 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4576 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4577 (decode_coding_emacs_mule): Mark variables that gcc
4578 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4579 (detect_coding_iso_2022): Initialize a local variable that might
4580 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4581 this initialization is needed. (Bug#8211)
5f58e762
PE
4582 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4583 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4584 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4585 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4586 Remove unused macros.
f38b440c 4587
232b38b9 4588 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4589 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4590 * character.c (string_count_byte8): Likewise.
232b38b9 4591
fb90da1b
PE
4592 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4593 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4594
fb93dbc2
PE
4595 * chartab.c (copy_sub_char_table): Now static, since it's not used
4596 elsewhere.
5c156ace
PE
4597 (sub_char_table_ref_and_range, char_table_ref_and_range):
4598 Rename locals to avoid shadowing.
bbcd0949 4599 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4600
7d3b3862 4601 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4602 (BIDI_BOB): Remove unused macro.
7d3b3862 4603
6be7d3da
PE
4604 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4605 deduce are never used uninitialized.
c2ed9c8b 4606 * term.c (encode_terminal_code): Likewise.
6be7d3da 4607
75f8807f 4608 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4609
50938595
PE
4610 * tparam.h: New file.
4611 * term.c, tparam.h: Include it.
4612 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4613 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4614 Move these decls to tparam.h, and make them agree with what
4615 is actually in tparam.c. The previous trick of using incompatible
4616 decls in different modules does not conform to the C standard.
4617 All callers of tparam changed to use tparam's actual API.
4618 * tparam.c (tparam1, tparam, tgoto):
4619 Use const pointers where appropriate.
4620
fbceeba2
PE
4621 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4622 * cm.h (struct cm): Likewise.
4623 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4624 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4625 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4626 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4627 (turn_on_face, init_tty): Likewise.
4628 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4629
7f3f1250
PE
4630 * term.c (term_mouse_position): Rename local to avoid shadowing.
4631
e6ca6543
PE
4632 * alloc.c (mark_ttys): Move decl from here ...
4633 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4634
c40f8d15
AS
46352011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4636
4637 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4638
cfe0661d
JB
46392011-03-09 Juanma Barranquero <lekktu@gmail.com>
4640
4641 * search.c (compile_pattern_1): Remove argument regp, unused since
4642 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4643 (compile_pattern): Don't pass it.
4644
0afb4571
J
46452011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4646
4647 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4648 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4649 for ! HAVE_GTK3.
4650 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4651
4652 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4653
4654 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4655 gdk_window_get_screen, gdk_window_get_geometry,
4656 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4657 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4658 (xg_get_pixbuf_from_pixmap): New function.
4659 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4660 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4661 Call xg_get_pixbuf_from_pixmap instead of
4662 gdk_pixbuf_get_from_drawable.
4663 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4664 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4665 (xg_check_special_colors): Use GtkStyleContext and its functions
4666 for HAVE_GTK3.
4667 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4668 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4669 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4670 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4671 Call gtk_widget_get_preferred_size.
0afb4571
J
4672 (xg_frame_resized): gdk_window_get_geometry only takes 5
4673 parameters.
44f230aa
SM
4674 (xg_win_to_widget, xg_event_is_for_menubar):
4675 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4676 (xg_set_widget_bg): New function.
4677 (delete_cb): New function.
895009e1 4678 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4679 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4680 (xg_set_background_color): Call xg_set_widget_bg.
4681 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4682 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4683 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4684 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4685 if ! HAVE_GTK3.
4686 (update_frame_tool_bar): Call gtk_widget_hide.
4687 (xg_initialize): Use GDK_KEY_g.
4688
4689 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4690 if ! HAVE_GTK3
4691 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4692
4693 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4694 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4695 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4696
1c2cc4ef
JB
46972011-03-08 Juanma Barranquero <lekktu@gmail.com>
4698
4699 * w32xfns.c (select_palette): Check success of RealizePalette against
4700 GDI_ERROR, not zero.
4701
33383987 4702See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4703
4704;; Local Variables:
4705;; coding: utf-8
aac0c6e3
MR
4706;; End:
4707
33383987 4708 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4709
4710 This file is part of GNU Emacs.
4711
4712 GNU Emacs is free software: you can redistribute it and/or modify
4713 it under the terms of the GNU General Public License as published by
4714 the Free Software Foundation, either version 3 of the License, or
4715 (at your option) any later version.
4716
4717 GNU Emacs is distributed in the hope that it will be useful,
4718 but WITHOUT ANY WARRANTY; without even the implied warranty of
4719 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4720 GNU General Public License for more details.
4721
4722 You should have received a copy of the GNU General Public License
4723 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.