* pcmpl-gnu.el: Use lexical-binding.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51553db6
SM
12011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2
3 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4 they've been requested explicitly (bug#9591).
5
b6bd1599 62011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7
8 * keymap.c (Fsingle_key_description): Use make_specified_string
9 instead of build_string to build string from push_key_description.
10 (Bug#5193)
11
f701dc2a
PE
122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
13
4222c55d
PE
14 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
15 This fixes a Y2038 bug on 64-bit hosts.
16 * buffer.c (reset_buffer):
17 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
18 (Fclear_buffer_auto_save_failure):
19 Use 0, not -1, to represent an unset failure time, since time_t
20 might not be signed.
21
f701dc2a
PE
22 Remove dependency on glibc malloc internals.
23 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
24 Move back here from lisp.h, but with their new implementations.
25 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
26 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
27 * charset.c (charset_table_init): New static var.
28 (syms_of_charset): Use it instead of xmalloc. This removes a
29 dependency on glibc malloc internals. See Eli Zaretskii's comment in
30 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
31 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
32 Move back to alloc.c.
33 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
34 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
35
9ceebf39
JD
362011-09-30 Jan Djärv <jan.h.d@swipnet.se>
37
38 * nsterm.m (windowDidResize): Call x_set_window_size only when
39 ns_in_resize is true. Otherwise set pixelwidth/height and
40 call change_frame_size (Bug#9628).
41
cb993c58
PE
422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
43
3930c88b
PE
44 Port --enable-checking=all to Fedora 14 x86-64.
45 * charset.c (syms_of_charset): Also account for glibc malloc's
46 internal overhead when calculating the initial malloc maximum.
47
cb993c58
PE
48 Port --enable-checking=all to Fedora 14 x86.
49 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
50 Move to lisp.h.
51 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
52 (overrun_check_realloc, overrun_check_free):
53 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
54 That way, xmalloc returns a properly-aligned pointer even if
55 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
56 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
57 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
58 into account when calculating the initial malloc maximum.
59 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
60 Move here from alloc.c, so that charset.c can use it too.
61 Properly align; the old code wasn't right for common 32-bit hosts
62 when configured with --enable-checking=all.
63 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
64 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
65
31bed486
EZ
662011-09-29 Eli Zaretskii <eliz@gnu.org>
67
04c70788 68 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
69 use EDOM.
70
fbcaa2f3
EZ
712011-09-28 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (compute_display_string_end): If there's no display
74 string at CHARPOS, return -1.
75
76 * bidi.c (bidi_fetch_char): When compute_display_string_end
77 returns a negative value, treat the character as a normal
78 character not covered by a display string. (Bug#9624)
79
a239d4e9
JB
802011-09-28 Juanma Barranquero <lekktu@gmail.com>
81
82 * lread.c (Fread_from_string): Fix typo in docstring.
83
88652fd5
EZ
842011-09-27 Eli Zaretskii <eliz@gnu.org>
85
86 * xdisp.c (handle_invisible_prop): If invisible text ends on a
87 newline, reseat the iterator instead of bidi-iterating there one
88 character at a time. (Bug#9610)
04c70788
EZ
89 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail out when
90 past TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 91
ed497dd4
AS
922011-09-27 Andreas Schwab <schwab@linux-m68k.org>
93
94 * lread.c (readevalloop): Use correct code for NBSP.
95 (read1): Likewise. (Bug#9608)
96
b2bf61aa
MA
972011-09-25 Michael Albinus <michael.albinus@gmx.de>
98
99 * dbusbind.c (Fdbus_register_signal): When service is not
100 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
101
32bbb17c
GM
1022011-09-25 Glenn Morris <rgm@gnu.org>
103
104 * buffer.c (truncate-lines): Doc fix.
105
94e0933e
CY
1062011-09-24 Chong Yidong <cyd@stupidchicken.com>
107
108 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
109 (Fset_window_next_buffers): Doc fix.
110
cddde921
GM
1112011-09-24 Glenn Morris <rgm@gnu.org>
112
113 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
114
1260aef1
PE
1152011-09-24 Paul Eggert <eggert@cs.ucla.edu>
116
25b4bfa0
PE
117 Fix minor problems found by static checking.
118 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
119 * indent.c (Fvertical_motion): Fix == vs = typo.
120
e3cbd34b
EZ
1212011-09-24 Eli Zaretskii <eliz@gnu.org>
122
6bf7006f
EZ
123 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
124 value is now t. Doc fix.
125
e3cbd34b 126 * indent.c (Fvertical_motion): Compute and apply the overshoot
04c70788 127 logic also when moving up, not only when moving down. Fix the
e3cbd34b 128 confusing name and values of the it_overshoot_expected variable;
04c70788 129 logic changed accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
130
131 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
132 CHARPOS is covered by a display string which includes newlines.
133 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
134 is covered by a display string with embedded newlines.
135
a3de0cbd
MA
1362011-09-24 Michael Albinus <michael.albinus@gmx.de>
137
138 * dbusbind.c (Fdbus_register_signal): Add match rule to
139 Vdbus_registered_objects_table. (Bug#9581)
140 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
141 docstring.
142
b260039d
JM
1432011-09-24 Jim Meyering <meyering@redhat.com>
144
04c70788 145 Do not ignore write error for any output size.
b260039d
JM
146 The previous change was incomplete.
147 While it makes emacs --batch detect the vast majority of stdout
148 write failures, errors were still ignored whenever the output size is
149 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
150 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
151 && echo FAIL: ignored write error
152 FAIL: ignored write error
153 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
154 && echo FAIL: ignored write error
155 FAIL: ignored write error
156 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
157
8eca8a7c
AS
1582011-09-23 Andreas Schwab <schwab@linux-m68k.org>
159
160 * emacs.c (Fkill_emacs): In noninteractive mode exit
161 non-successfully if a write error occurred on stdout. (Bug#9574)
162
3341db62
EZ
1632011-09-21 Eli Zaretskii <eliz@gnu.org>
164
165 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
166 the xassert test.
167
168 * dispextern.h (struct it): Update the comment documenting what
169 can it->OBJECT be.
170
8c203dbf
EZ
1712011-09-20 Eli Zaretskii <eliz@gnu.org>
172
173 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
174 a display string, extend search for cursor position to end of row.
175 (find_row_edges): If the row ends in a newline from a display
176 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
177 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
178 (Fcurrent_bidi_paragraph_direction): Fix search for previous
179 non-empty line. Fixes confusing cursor motion with arrow keys at
180 the beginning of a line that starts with whitespace.
8c203dbf 181
a4824228
LMI
1822011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
183
184 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
185 (bug#9493).
186
33ed493b
CY
1872011-09-18 Chong Yidong <cyd@stupidchicken.com>
188
189 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
190 boolean (Bug#9154).
191
56cd55c8
EZ
1922011-09-18 Eli Zaretskii <eliz@gnu.org>
193
194 * xdisp.c (display_line): Record maximum and minimum buffer
195 positions even if no glyphs were produced (e.g., by a zero-width
196 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
197 buffer positions that will be removed from the glyph row because
198 they don't fit.
c02dcedf
EZ
199 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
200 column is beyond frame width: don't subtract 1 "pixel" when
201 computing width of the stretch.
3e62b7e0
EZ
202 (reseat_at_next_visible_line_start): Undo the change made on
203 2011-09-17 that saved paragraph information and restored it after
204 the call to `reseat'. (Bug#9545)
56cd55c8 205
5ed99d36 2062011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
207
208 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
209 and turn window cursor on if cleared (Bug#9415).
210
5ed99d36 2112011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
212
213 * search.c (boyer_moore): Take unibyte characters from pattern
214 literally. (Bug#9458)
215
9bade7b2
EZ
2162011-09-18 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
219
e5e9d610
PE
2202011-09-18 Paul Eggert <eggert@cs.ucla.edu>
221
87e4427a
PE
222 Fix minor problem found by static checking.
223 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
224 initialized, to pacify gcc -Wuninitialized.
225
e5e9d610
PE
226 * fileio.c: Report proper errno when syscall falls.
227 (Finsert_file_contents): Save and restore errno,
228 so that report_file_error outputs the correct diagnostic.
229 (Fwrite_region) [CLASH_DETECTION]: Likewise.
230
a1674f0b
EZ
2312011-09-18 Eli Zaretskii <eliz@gnu.org>
232
233 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
234
fbfb6dd4
EZ
2352011-09-17 Eli Zaretskii <eliz@gnu.org>
236
237 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
238 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
239
bb187662
EZ
2402011-09-17 Eli Zaretskii <eliz@gnu.org>
241
1137e8b8
EZ
242 * xdisp.c (reseat_at_next_visible_line_start): Keep information
243 about the current paragraph and restore it after the call to
244 reseat.
245
246 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
247 (bidi_find_paragraph_start): Search back for paragraph beginning
248 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
249 (bidi_move_to_visually_next): Only trigger paragraph-related
250 computations when the last character is a newline or at EOB, not
251 just any NEUTRAL_B. (Bug#9470)
252
bb187662
EZ
253 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
254 truncated lines if point is covered by a display string. (Bug#9524)
255
2e621251
PE
2562011-09-16 Paul Eggert <eggert@cs.ucla.edu>
257
258 * xselect.c: Relax test for outgoing X longs (Bug#9498).
259 (cons_to_x_long): New function.
260 (lisp_data_to_selection_data): Use it. Correct the test for
261 short-versus-long data; it was negated. Break out of vector
262 loop, for efficiency, when a long datum is discovered.
263
91a15bc6
SM
2642011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
267
b41c3a35
EZ
2682011-09-16 Eli Zaretskii <eliz@gnu.org>
269
270 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
271 GCC PR/17406) by declaring this function with external scope.
272
7812ba2d
PE
2732011-09-15 Paul Eggert <eggert@cs.ucla.edu>
274
275 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
276 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
277
cf7edc2a
AS
2782011-09-15 Andreas Schwab <schwab@linux-m68k.org>
279
280 * editfns.c (Fformat): Correctly handle text properties on "%%".
281
bd01620e
EZ
2822011-09-15 Eli Zaretskii <eliz@gnu.org>
283
284 * xterm.c (x_draw_composite_glyph_string_foreground):
285 * w32term.c (x_draw_composite_glyph_string_foreground):
286 * term.c (encode_terminal_code):
287 * composite.c (composition_update_it, get_composition_id):
288 * xdisp.c (get_next_display_element)
289 (fill_composite_glyph_string): Add comments about special meaning
290 of TAB characters in a composition.
291
a02719a3
PE
2922011-09-15 Paul Eggert <eggert@cs.ucla.edu>
293
294 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
295 This occurs when processing a multibyte format.
296 Problem reported by Wolfgang Jenker.
a02719a3 297
72589a3c
JB
2982011-09-15 Johan Bockgård <bojohan@gnu.org>
299
300 * xdisp.c (try_cursor_movement): Only check for exact match if
301 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
302
1c14176c
PE
3032011-09-14 Paul Eggert <eggert@cs.ucla.edu>
304
305 Remove unused external symbols.
306 * dispextern.h (calc_pixel_width_or_height): Remove decl.
307 * xdisp.c (calc_pixel_width_or_height): Now static.
308 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
309 * indent.c (check_display_width):
310 * w32term.c: Fix comment to match code.
311 * xterm.c, xterm.h (x_catching_errors): Remove.
312
d2eea5b5
PE
3132011-09-14 Paul Eggert <eggert@cs.ucla.edu>
314
315 * xselect.c: Use signed conversions more consistently (Bug#9498).
316 (selection_data_to_lisp_data): Assume incoming selection data are
317 signed integers, not unsigned. This is to be consistent with
318 outgoing selection data, which was modified to use signed integers
319 in as part of the fix to Bug#9196 in response to Jan D.'s comment
320 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
321 expects long, not unsigned long.
322
46888499
EZ
3232011-09-14 Eli Zaretskii <eliz@gnu.org>
324
325 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
326 computation of loop end. Reported by Johan Bockgård
327 <bojohan@gnu.org>.
328
ef8ef9fb
CY
3292011-09-13 Chong Yidong <cyd@stupidchicken.com>
330
331 * frame.c (Fother_visible_frames_p): Function deleted.
332
fa819fed
EZ
3332011-09-12 Eli Zaretskii <eliz@gnu.org>
334
335 * indent.c (compute_motion): Process display vector front to back
336 rather than the other way around. (Bug#2496)
337
2ba8e008
SM
3382011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
339
340 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
341
20f53c69
CY
3422011-09-11 Chong Yidong <cyd@stupidchicken.com>
343
344 * minibuf.c (Fread_from_minibuffer): Doc fix.
345
d562d7a4
EZ
3462011-09-11 Eli Zaretskii <eliz@gnu.org>
347
348 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
349 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
350
1c4d7f3d
LMI
3512011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
352
353 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
354 value for non-existent files.
355
b885bf36
EZ
3562011-09-11 Eli Zaretskii <eliz@gnu.org>
357
358 * fileio.c (Finsert_file_contents): If the file cannot be opened,
359 set its "size" to -1. This will set the modtime_size field of
360 the corresponding buffer to -1, which is what
361 verify-visited-file-modtime expects for files that do not exist.
362 (Bug#9139)
363
6612f0bf
PE
3642011-09-11 Paul Eggert <eggert@cs.ucla.edu>
365
366 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
367 here ...
368 * lisp.h: ... from here. push_key_description is no longer
369 defined in keyboard.c, so its declaration should not be in
370 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
371 logically belongs with push_key_description.
372
dfb3f755
PE
3732011-09-10 Paul Eggert <eggert@cs.ucla.edu>
374
375 * buffer.h: Include <sys/types.h> instead of <time.h>.
376 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
377 Problem reported by Herbert J. Skuhra.
378
3134906c
LMI
3792011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
380
381 * xml.c (parse_region): Make the parsing work for
382 non-comment-starting XML files again (bug#9144).
383
8d903f4e
AS
3842011-09-10 Andreas Schwab <schwab@linux-m68k.org>
385
386 * image.c (gif_load): Fix calculation of bottom and right corner.
387 (Bug#9468)
388
80ad64f4
EZ
3892011-09-10 Eli Zaretskii <eliz@gnu.org>
390
391 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
392 redisplay in small windows.
393
208a048d
EZ
3942011-09-09 Eli Zaretskii <eliz@gnu.org>
395
396 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
397
9b1c252e
MR
3982011-09-08 Martin Rudalics <rudalics@gmx.at>
399
400 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
401 Operate on live windows only.
402
2949f33b
JB
4032011-09-08 Juanma Barranquero <lekktu@gmail.com>
404
405 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
406
e08dcafd
EZ
4072011-09-07 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
410 only under bidi iteration.
411
115b96bd
JD
4122011-09-07 Jan Djärv <jan.h.d@swipnet.se>
413
414 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
415
c8199d0f
PE
4162011-09-06 Paul Eggert <eggert@cs.ucla.edu>
417
418 isnan: Fix porting problem to Solaris 10 with bundled gcc.
419 Without this fix, the command to link temacs failed due to an
420 undefined symbol __builtin_isnan. This is because
421 /usr/include/iso/math_c99.h #defines isnan(x) to
422 __builtin_isnan(x), but the bundled gcc, which identifies itself
423 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
424 a __builtin_isnan.
425 * floatfns.c (isnan): #undef, and then #define to a clone of
426 what's in data.c.
427 (Fisnan): Always define, since it's always available now.
428 (syms_of_floatfns): Always define isnan at the Lisp level.
429
e39b275c 4302011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
431
432 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
433
b2db44d9 4342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 435
f4af5137 436 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
437 The previous code assumed that file offsets (off_t values) fit in
438 EMACS_INT variables, which is not true on typical 32-bit hosts.
439 The code messed up by falsely reporting buffer overflow in cases
440 such as (insert-file-contents "big" nil 1 2) into an empty buffer
441 when "big" contains more than 2**29 bytes, even though this
442 inserts just one byte and does not overflow the buffer.
443 (Finsert_file_contents): Store file offsets as off_t
444 values, not as EMACS_INT values. Check for overflow when
445 converting between EMACS_INT and off_t. When checking for
446 buffer overflow or for overlap, take the offsets into account.
447 Don't use EMACS_INT for small values where int suffices.
448 When checking for overlap, fix a typo: ZV was used where
449 ZV_BYTE was intended.
450 (Fwrite_region): Don't assume off_t fits into 'long'.
451 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
452
ecfc0a49
MA
4532011-09-05 Michael Albinus <michael.albinus@gmx.de>
454
455 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
456
6511acf2 4572011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 458
0999621a 459 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
460
461 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 462 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
463 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
464 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
465 (modify_event_symbol): Do not assume that the length of
466 name_alist_or_stem is safe to alloca and fits in int.
467 (Fexecute_extended_command): Likewise for function name and binding.
468 (Frecursion_depth): Wrap around reliably on integer overflow.
469 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
470 since some callers pass EMACS_INT values.
471 (Fsingle_key_description): Don't crash if symbol name contains more
472 than MAX_ALLOCA bytes.
473 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
474 (get_minibuffer): Arg is now EMACS_INT, not int.
475 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 476 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
477 * window.h (command_loop_level, minibuf_level): Reflect API changes.
478
2be7d702
PE
479 * dbusbind.c (signature_cat): New function.
480 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
481 Do not overrun buffer; instead, report string overflow.
482
9d1df220
PE
483 * dispnew.c (add_window_display_history): Don't overrun buffer.
484 Truncate instead; this is OK since it's just a log.
485
33ef5c64
PE
486 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
487 even if the time zone offset is outlandishly large.
488 Don't mishandle offset == INT_MIN.
489
66c6fdd5
PE
490 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
491 when creating daemon; the previous buffer-overflow check was incorrect.
492
d749b01b
PE
493 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
494 which has the guts of the old verror function.
495
b5cd1905
PE
496 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
497 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
498
6e1a67fb
PE
499 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
500 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 501 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 502 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
503 length of string rather than counting it via multiple sprintfs;
504 that's simpler and more reliable.
c21721cc
PE
505 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
506 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
507 sprintf, in case result does not fit in int.
508
c57b67fc
PE
509 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
510 (fontset_from_font): Print it.
511
8a401434
PE
512 * frame.c (tty_frame_count): Now printmax_t, not int.
513 (make_terminal_frame, set_term_frame_name): Print it.
514 (x_report_frame_params): In X, window IDs are unsigned long,
515 not signed long, so print them as unsigned.
516 (validate_x_resource_name): Check for implausibly long names,
517 and don't assume name length fits in 'int'.
518 (x_get_resource_string): Don't blindly alloca invocation name;
519 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
520 not fit in int.
521
6e1a67fb
PE
522 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
523 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
524 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
525
0df02bf3
PE
526 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
527 Use esprintf, not sprintf, in case result does not fit in int.
528
48e30793
PE
529 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
530 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
531 it as a large positive number.
532 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
533 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
534
a66ff6d8
PE
535 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
536 in case result does not fit in int.
537
aca216ff
PE
538 * print.c (float_to_string): Detect width overflow more reliably.
539 (print_object): Make sprintf buffer a bit bigger, to avoid potential
540 buffer overrun. Don't assume list length fits in 'int'. Treat
541 print length of 0 as 0, not as infinity; to be consistent with other
542 uses of print length in this function. Don't overflow print length
543 index. Don't assume hash table size fits in 'long', or that
544 vectorlike size fits in 'unsigned long'.
545
31c286f7
PE
546 * process.c (make_process): Use printmax_t, not int, to format
547 process-name gensyms.
548
55e5faa1
PE
549 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
550
80f2e268
PE
551 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
552 to avoid potential buffer overrun.
553
670741ab
PE
554 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
555 if X resource line is longer than 512 bytes.
556
b7163a50
PE
557 * xfns.c (x_window): Make sprintf buffer a bit bigger
558 to avoid potential buffer overrun.
559
ae58ff1f
PE
560 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
561
c43c8a6a
PE
562 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
563
3f8236f4
PE
5642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
565
53e9fe90 566 Integer overflow fixes for scrolling, etc.
6511acf2
PE
567 Without these, Emacs silently mishandles large integers sometimes.
568 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
569 it were "C-u 1 M-x recenter" on a typical 64-bit host.
570
6511acf2
PE
571 * xdisp.c (try_window_id): Check Emacs fixnum range before
572 converting to 'int'.
806add1d 573
6511acf2 574 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
575 Check that an Emacs fixnum is in range before assigning it to 'int'.
576 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
577 values converted from Emacs fixnums.
578 (Frecenter): Don't wrap around a line count if it is out of 'int'
579 range; instead, treat it as an extreme value.
580 (Fset_window_configuration, compare_window_configurations):
581 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
582
6511acf2
PE
583 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
584 that can exceed INT_MAX. Check that EMACS_INT value is in range
585 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
586 (match_limit): Don't assume that a fixnum can fit in 'int'.
587
6511acf2 588 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
589 exceed INT_MAX.
590
6511acf2 591 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
592 (Fvertical_motion): Don't wrap around LINES values that don't fit
593 in 'int'. Instead, treat them as extreme values. This is good
594 enough for windows, which can't have more than INT_MAX lines anyway.
595
fcb901a7
LMI
5962011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
597
0f2f6b6d
LMI
598 * Require libxml/parser.h to avoid compilation warning.
599
fcb901a7
LMI
600 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
601
602 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
603 since this reportedly can destroy thread storage.
604
6e20a0d4
CY
6052011-08-30 Chong Yidong <cyd@stupidchicken.com>
606
607 * syntax.c (find_defun_start): Update all cache variables if
608 exiting early (Bug#9401).
609
148ae00e
EZ
6102011-08-30 Eli Zaretskii <eliz@gnu.org>
611
f6cfbd8f
EZ
612 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
613
148ae00e
EZ
614 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
615 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
616 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
617
618 * term.c (tty_append_glyph): New function.
619 (produce_stretch_glyph): Static function and its prototype deleted.
620
621 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
622 prototypes.
623
c4a07a4c
PE
6242011-08-29 Paul Eggert <eggert@cs.ucla.edu>
625
626 * image.c (parse_image_spec): Check for nonnegative, not for positive,
627 when checking :margin (Bug#9390).
628 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
629 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
630 so that the name doesn't mislead. All uses changed.
631
6bc8cd65
JB
6322011-08-28 Johan Bockgård <bojohan@gnu.org>
633
634 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
635 set_tty_hooks.
636
dca4927e
EZ
6372011-08-27 Eli Zaretskii <eliz@gnu.org>
638
639 * xdisp.c (move_it_to): Don't bail out early when reaching
640 position beyond to_charpos, if we are scanning backwards.
641 (move_it_vertically_backward): When DY == 0, make sure we get to
642 the first character in the line after the newline.
643
f2cad773
PE
6442011-08-27 Paul Eggert <eggert@cs.ucla.edu>
645
646 * ccl.c: Improve and simplify overflow checking (Bug#9196).
647 (ccl_driver): Do not generate an out-of-range pointer.
648 (Fccl_execute_on_string): Remove unnecessary check for
649 integer overflow, noted by Stefan Monnier in
650 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
651 Remove a FIXME that didn't need fixing.
652 Simplify the newly-introduced buffer reallocation code.
653
0cae2cdb
JB
6542011-08-27 Juanma Barranquero <lekktu@gmail.com>
655
656 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
657
5fc295a4 6582011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 659
70c60eb2 660 Integer and memory overflow issues (Bug#9196).
726e0ab1 661
d31850da
PE
662 * doc.c (get_doc_string): Rework so that
663 get_doc_string_buffer_size is the actual buffer size, rather than
664 being 1 less than the actual buffer size; this makes xpalloc more
665 convenient.
666
a69fbedb
PE
667 * image.c (x_allocate_bitmap_record, cache_image):
668 * xselect.c (Fx_register_dnd_atom):
669 Simplify previous changes by using xpalloc.
670
fe5c5d37
PE
671 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
672 since either will do and ptrdiff_t is convenient with xpalloc.
673
0065d054
PE
674 * charset.c (charset_table_size)
675 (struct charset_sort_data.priority): Now ptrdiff_t.
676 (charset_compare): Don't overflow if priorities differ greatly.
677 (Fsort_charsets): Don't assume list length fits in int.
678 Check for size-calculation overflow when allocating sort data.
679 (syms_of_charset): Allocate an initial charset table that is
680 just under 64 KiB, to avoid problems with glibc malloc and mmap.
681
682 * cmds.c (internal_self_insert): Check for size-calculation overflow.
683
684 * composite.h (struct composition.glyph_len): Now int, not unsigned.
685 The actual value is always <= INT_MAX, and leaving it unsigned made
686 overflow checking harder.
687
688 * dispextern.h (struct glyph_matrix.rows_allocated)
689 (struct face_cache.size): Now ptrdiff_t, for convenience in use
690 with xpalloc. The values are still always <= INT_MAX.
691
692 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
693
694 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
695 (SAFE_NALLOCA): New macro.
696
697 * region-cache.c (struct boundary.pos, find_cache_boundary)
698 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
699 (set_cache_region, invalidate_region_cache)
700 (revalidate_region_cache, know_region_cache, region_cache_forward)
701 (region_cache_backward, pp_cache):
702 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
703 so that ptrdiff_t * can be passed to xpalloc.
704 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
705 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
706 (pp_cache): Don't assume cache_len fits in int.
707 * region-cache.h: Adjust extern decls to match.
708
709 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
710 EMACS_INT, since either will do, for xpalloc.
711
712 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
713 (xnmalloc, xnrealloc, xpalloc): New functions.
714
726e0ab1
PE
715 * bidi.c (bidi_shelve_header_size): New constant.
716 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
717 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
718
51f30bc5 719 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
720 * buffer.c (overlays_at, overlays_in, record_overlay_string)
721 (overlay_strings):
722 Don't update size of array until after memory allocation succeeds,
723 because xmalloc/xrealloc may not return.
0065d054
PE
724 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
725 now that we have proper integer overflow checking.
726 (record_overlay_string, overlay_strings): Catch overflows when
727 calculating size of overlay_str_buf.
726e0ab1 728
0065d054
PE
729 * callproc.c (Fcall_process): Check for size overflow when
730 calculating size of args2.
731 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
732 Normally we prefer signed values, but sticking with ptrdiff_t would
733 require adding more-complicated checks.
726e0ab1
PE
734
735 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
736 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
737 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 738 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
739
740 * character.c (Fstring): Check for size-calculation overflow.
741
742 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
743 unnecessary integer overflow. Check for size overflow.
744 (encode_coding_object): Don't update size until xmalloc succeeds.
745
746 * composite.c (get_composition_id): Check for overflow in glyph
747 length calculations.
748
749 Integer and memory overflow fixes for display code.
750 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
751 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
752 (scrolling_window): Check for overflow in size calculations.
753 (line_draw_cost, realloc_glyph_pool, add_row_entry):
754 Don't assume glyph table len fits in int.
755 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
756 (row_table_size): Now ptrdiff_t, not int.
757 (scrolling_window): Avoid overflow in size calculations.
758 Don't update size until allocation succeeds.
759 * fns.c (concat): Check for overflow in size calculations.
760 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
761 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
762 (NEXT_ALMOST_PRIME_LIMIT): New constant.
763
764 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
765 (get_doc_string): Check for size calculation overflow.
766 Don't update size until allocation succeeds.
767 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
768 EMACS_INT, where ptrdiff_t will do.
769 (Fsubstitute_command_keys): Check for string overflow.
770
771 * editfns.c (set_time_zone_rule): Don't assume environment length
772 fits in int.
773 (message_length): Now ptrdiff_t, not int.
774 (Fmessage_box): Don't update size until allocation succeeds.
775 Don't assume message length fits in int.
776 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
777
0065d054
PE
778 * emacs.c (main): Do not reallocate argv, since there is a null at
779 the end that can be overwritten, and this way there's no need to
780 worry about size-calculation overflow.
781 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
782
783 * eval.c (init_eval_once, grow_specpdl): Don't update size until
784 alloc succeeds.
785 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
786
787 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
788 (x_set_scroll_bar_width, x_figure_window_size):
789 Check for integer overflow.
790 (x_set_alpha): Do not assume XINT fits in int.
791
792 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
793 This is for the members text_lines, text_cols, total_lines, total_cols,
794 where the system imposes an 'int' limit.
795
796 * fringe.c (Fdefine_fringe_bitmap):
797 Don't update size until alloc works.
798
799 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
800 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
801
802 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
803 Check for size-calculation overflow.
804 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
805 do, as we prefer signed integers.
806 (id_to_widget.max_size, id_to_widget.used)
807 (xg_store_widget_in_map, xg_remove_widget_from_map)
808 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
809 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
810 Use and return ptrdiff_t, not int.
811 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
812 * gtkutil.h: Change prototypes to match the above.
813
814 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
815 are duplicate now that they've been promoted to lisp.h.
816 (x_allocate_bitmap_record, x_alloc_image_color)
817 (make_image_cache, cache_image, xpm_load):
818 Don't update size until alloc is done.
819 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
820 (x_detect_edges):
3256efce 821 Check for size calculation overflow.
726e0ab1
PE
822 (ct_colors_allocated_max): New constant.
823 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
824 overflow.
3256efce 825
726e0ab1
PE
826 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
827 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
828 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
829 Use ptrdiff_t, not int, to count maps.
830 (read_char_minibuf_menu_prompt): Check for overflow in size
831 calculations. Don't update size until allocation succeeds. Redo
832 calculations to avoid overflow.
833 * keyboard.h: Change prototypes to match the above.
834
835 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
836 to count maps.
837 (current_minor_maps): Check for size calculation overflow.
838 * keymap.h: Change prototypes to match the above.
839
840 * lread.c (read1, init_obarray): Don't update size until alloc done.
841
842 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
843 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
844
726e0ab1
PE
845 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
846 Now ptrdiff_t, not int.
847 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
848 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
849
850 * process.c (Fnetwork_interface_list): Check for overflow
851 in size calculation.
852
853 * region-cache.c (move_cache_gap): Check for size calculation overflow.
854
855 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
856 overflow. Don't bother calling xmalloc when xrealloc will do.
857
858 * search.c (Freplace_match): Check for size calculation overflow.
859 (Fset_match_data): Don't assume list lengths fit in 'int'.
860
861 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
862 for command line length. Do not attempt to address one before the
863 beginning of an array, as that's not portable.
864
865 * term.c (max_frame_lines): Remove; unused.
866 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
867 not int.
868 (encode_terminal_code, calculate_costs): Check for size
869 calculation overflow.
870 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
871 table lengths and related sizes. Don't update size until alloc
872 done. Redo calculations to avoid overflow.
873 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
874
875 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
876 subtracting pointers.
877 (gobble_line): Check for overflow more carefully. Don't update size
878 until alloc done.
879
880 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
881 Don't update size until alloc done.
882 Redo size calculations to avoid overflow.
883 Check for size calculation overflow.
0065d054 884 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
885
886 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
887 Use ptrdiff_t, not int, for sizes.
888 (store_mode_line_noprop_char): Don't update size until alloc done.
889
0065d054
PE
890 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
891 Use ptrdiff_t, not int, for sizes.
892 (Finternal_make_lisp_face, cache_face):
893 Check for size calculation overflow.
894 (cache_face): Treat size calculation overflows as if they were
895 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
896
897 * xfns.c (x_encode_text, x_set_name_internal)
898 (Fx_change_window_property): Use ptrdiff_t, not int, to count
899 sizes, since they can exceed INT_MAX in size. Check for size
900 calculation overflow.
901
0065d054
PE
902 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
903 (xg_select): Check for size calculation overflow.
726e0ab1
PE
904 Don't update size until alloc done.
905
0065d054 906 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 907 as sprintf is limited to int lengths.
1d526e2f 908
252c5ee1
PE
909 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
910 (X_LONG_MIN): New macros.
864d7ce7
PE
911 Use them to make the following changes clearer.
912 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
913 This change doesn't affect the value now, but it may help remind
914 future maintainers not to raise the value too much later.
915 (SELECTION_QUANTUM): Remove, replacing with ...
916 (selection_quantum): ... new function, which avoids overflow.
917 All uses changed.
918 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
919 assumption that selection length fits in 'int'.
920 (x_reply_selection_request, x_handle_selection_request)
921 (x_get_window_property, receive_incremental_selection)
922 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
923 (lisp_data_to_selection_data, clean_local_selection_data):
924 Use ptrdiff_t, not int, to record length of selection.
925 (x_reply_selection_request, x_get_window_property)
926 (receive_incremental_selection, x_property_data_to_lisp):
927 Redo calculations to avoid overflow.
928 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 929 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
930 something.
931 (x_get_window_property, receive_incremental_selection)
932 (lisp_data_to_selection_data, x_property_data_to_lisp):
933 Check for size-calculation overflow.
934 (x_get_window_property, receive_incremental_selection)
935 (lisp_data_to_selection_data, Fx_register_dnd_atom):
936 Don't store size until memory allocation succeeds.
937 (x_get_window_property): Plug memory leak on memory exhaustion.
938 Don't double-block input; malloc is safe here. Don't assume 2**34
939 - 4 fits in unsigned long. Add an xassert to check
940 XGetWindowProperty overflow. Be more careful about overflow
941 calculations, and distinguish size from memory overflow better.
942 (receive_incremental_selection): When tracing, don't assume
943 unsigned int is less than INT_MAX.
944 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
945 harmful) conversions of unsigned short to int.
946 (lisp_data_to_selection_data): Don't assume that integers
947 in the range -65535 through -1 fit in an X unsigned short.
948 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
949 result parameters unless successful. Rely on cons_to_unsigned
950 to report problems with elements; the old code wasn't right anyway.
951 (x_check_property_data): Check for int overflow; we cannot use
952 a wider type due to X limits.
953 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
954
726e0ab1 955 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 956
0065d054
PE
957 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
958 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
959 (x_color_cells): Don't store size until memory allocation succeeds.
960 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 961 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
962 (x_term_init): Don't assume length fits in int (sprintf is limited
963 to int size).
bc18e09d 964
ebfa62c0
PE
965 Use ptrdiff_t for composition IDs.
966 * character.c (lisp_string_width):
967 * composite.c (composition_table_size, n_compositions)
968 (get_composition_id, composition_gstring_from_id):
969 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
970 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
971 * window.c (Frecenter):
972 Use ptrdiff_t, not int, for composition IDs.
973 * composite.c (get_composition_id): Check for integer overflow.
974 * composite.h: Adjust prototypes to match the above changes.
975
d3411f89
PE
976 Use ptrdiff_t for hash table indexes.
977 * category.c (hash_get_category_set):
978 * ccl.c (ccl_driver):
979 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
980 * coding.c (coding_system_charset_list, detect_coding_system):
981 * coding.h (struct coding_system.id):
982 * composite.c (get_composition_id, gstring_lookup_cache):
983 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
984 * image.c (xpm_get_color_table_h):
985 * lisp.h (hash_lookup, hash_put):
986 * minibuf.c (Ftest_completion):
987 Use ptrdiff_t for hash table indexes, not int (which is too
988 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
989 32-bit --with-wide-int hosts).
990
e097a6fa
PE
991 * charset.c (Fdefine_charset_internal): Check for integer overflow.
992 Add a FIXME comment about memory leaks.
993 (syms_of_charset): Don't assume xmalloc returns.
994
5637687f
PE
995 Don't assume that stated character widths fit in int.
996 * character.c (Fchar_width, c_string_width, lisp_string_width):
997 * character.h (CHAR_WIDTH):
998 * indent.c (MULTIBYTE_BYTES_WIDTH):
999 Use sanitize_char_width to avoid undefined and/or bad behavior
1000 with outlandish widths.
1001 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1002 now that we have two such functions. All uses changed.
1003 (sanitize_char_width): New inline function.
1004
a2271ba2
PE
1005 Don't assume that tab-width fits in int.
1006 * character.h (sanitize_width): New inline function.
1007 (SANE_TAB_WIDTH): New macro.
1008 (ASCII_CHAR_WIDTH): Use it.
1009 * indent.c (sane_tab_width): Remove. All uses replaced by
1010 SANE_TAB_WIDTH (current_buffer).
1011 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1012
18c52557
PE
1013 * fileio.c: Integer overflow issues with file modes.
1014 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1015
caeeedc1
PE
1016 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1017 Remove unreachable code.
1018 (read_hex, load_charset_map_from_file): Check for integer overflow.
1019
50849c52
PE
1020 * xterm.c: don't go over XClientMessageEvent limit
1021 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1022 (x_send_scroll_bar_event): Likewise. Check that the size does not
1023 exceed limits imposed by XClientMessageEvent, as well as the usual
1024 ptrdiff_t and size_t limits.
1025
b13995db
PE
1026 * keyboard.c: Overflow, signedness and related fixes.
1027 (make_lispy_movement): Use same integer type in forward decl
1028 that is used in the definition.
1029 (read_key_sequence, keyremap_step):
1030 Change bufsize argument back to int, undoing my 2011-03-30 change.
1031 We prefer signed types, and int is wide enough here.
1032 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1033 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1034 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1035 length, not size_t. Use ptrdiff_t for index, not int.
1036 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1037 possibility of integer overflow.
1038
13464394
PE
1039 Overflow, signedness and related fixes for images.
1040
1041 * dispextern.h (struct it.stack[0].u.image.image_id)
1042 (struct_it.image_id, struct image.id, struct image_cache.size)
1043 (struct image_cache.used, struct image_cache.ref_count):
1044 * gtkutil.c (update_frame_tool_bar):
1045 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1046 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1047 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1048 * nsmenu.m (update_frame_tool_bar):
1049 * xdisp.c (calc_pixel_width_or_height):
1050 * xfns.c (image_cache_refcount):
1051 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1052 on typical 64-bit hosts.
1053
1054 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1055 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1056 Omit unnecessary casts to int.
1057 (parse_image_spec): Check that integers fall into 'int' range
1058 when the callers expect that.
1059 (image_ascent): Redo ascent calculation to avoid int overflow.
1060 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1061 (lookup_image): Remove unnecessary tests.
1062 (xbm_image_p): Locals are now of int, not EMACS_INT,
1063 since parse_image_check makes sure they fit into int.
1064 (png_load, gif_load, svg_load_image):
1065 Prefer int to unsigned where either will do.
1066 (tiff_handler): New function, combining the cores of the
1067 old tiff_error_handler and tiff_warning_handler. This
1068 function is rewritten to use vsnprintf and thereby avoid
1069 stack buffer overflows. It uses only the features of vsnprintf
1070 that are common to both POSIX and native Microsoft.
1071 (tiff_error_handler, tiff_warning_handler): Use it.
1072 (tiff_load, gif_load, imagemagick_load_image):
1073 Don't assume :index value fits in 'int'.
1074 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1075 (imagemagick_load_image): Check that crop parameters fit into
1076 the integer types that MagickCropImage accepts. Don't assume
1077 Vimagemagick_render_type has a nonnegative value. Don't assume
1078 size_t fits in 'long'.
1079 (gs_load): Use printmax_t to print the widest integers possible.
1080 Check for integer overflow when computing image height and width.
1081
c11821d4
EZ
10822011-08-26 Eli Zaretskii <eliz@gnu.org>
1083
1084 * xdisp.c (redisplay_window): Don't force window start if point
1085 will be invisible in the resulting window. (Bug#9324)
1086
0c95fcf7
EZ
10872011-08-25 Eli Zaretskii <eliz@gnu.org>
1088
1089 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1090 the display spec is of the form `(space ...)'.
1091 (handle_display_spec): Return the value returned by
1092 handle_single_display_spec, not just 1 or zero.
1093 (handle_single_display_spec): If the display spec is of the form
1094 `(space ...)', and specifies display in the text area, return 2
1095 rather than 1.
fee65a97 1096 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1097 accurately, and prefer exact match for point under bidi. Don't
1098 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1099
1100 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1101 into disp_prop; all users changed.
1102
1103 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1104 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1105 for the text covered by the display property.
1106
e4ed06f1
CY
11072011-08-25 Chong Yidong <cyd@stupidchicken.com>
1108
1109 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1110 Change return value to nil.
1111 (Frecord_buffer): Delete unused function.
1112
f67cdd7f
EZ
11132011-08-24 Eli Zaretskii <eliz@gnu.org>
1114
5980d4c6
EZ
1115 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1116 buffers, return left-to-right.
8610fe8b
EZ
1117 (set_cursor_from_row): Consider candidate row a win if its glyph
1118 represents a newline and point is on that newline. Fixes cursor
1119 positioning on the newline at EOL of R2L text within L2R
1120 paragraph, and vice versa.
1121 (try_cursor_movement): Check continued rows, in addition to
1122 continuation rows. Fixes unwarranted scroll when point enters a
1123 continued line of R2L text within an L2R paragraph, or vice versa.
1124 (cursor_row_p): Consider the case of point being equal to
1125 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1126 from the end of a short line to the beginning of a continued line
1127 of R2L text within L2R paragraph.
1128 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1129 composed characters.
5980d4c6 1130
f67cdd7f
EZ
1131 * bidi.c (bidi_check_type): Use xassert.
1132 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1133 members.
1134
bca633fb
EZ
11352011-08-23 Eli Zaretskii <eliz@gnu.org>
1136
1137 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1138 a character.
1139
4a5885a7
CY
11402011-08-23 Chong Yidong <cyd@stupidchicken.com>
1141
1142 * nsfont.m (ns_otf_to_script): Fix typo.
1143
0902a04e
KH
11442011-08-22 Kenichi Handa <handa@m17n.org>
1145
1146 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1147 extra slot even if the purpose is char-code-property-table.
1148
1a2e6670
EZ
11492011-08-23 Eli Zaretskii <eliz@gnu.org>
1150
8ddde651
EZ
1151 * xdisp.c (redisplay_window): When computing centering_position,
1152 account for the height of the header line. (Bug#8874)
1153
425cc014
EZ
1154 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1155 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1156 candidate is selected by the mouse, and that candidate has a
1157 composed character under the mouse.
1158
1a2e6670
EZ
1159 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1160 coordinates reported by pos-visible-in-window-p for a composed
1161 character in column zero.
1162
8b76d6f8
SM
11632011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1164
1165 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1166
dac347dd
EZ
11672011-08-22 Eli Zaretskii <eliz@gnu.org>
1168
1169 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1170 consider it a hit if to_charpos is anywhere in the range of the
1171 composed buffer positions.
1172
e013fb34
CY
11732011-08-22 Chong Yidong <cyd@stupidchicken.com>
1174
1175 * image.c (gif_load): Don't assume that each subimage has the same
1176 dimensions as the base image. Handle disposal method that is
1177 "undefined" by the gif spec (Bug#9335).
1178
bd1ba3e8
CY
11792011-08-20 Chong Yidong <cyd@stupidchicken.com>
1180
1181 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1182 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1183
54a1215b
EZ
11842011-08-19 Eli Zaretskii <eliz@gnu.org>
1185
823564e5
EZ
1186 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1187 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1188 from an Org mode buffer to a Speedbar frame.
1189
54a1215b
EZ
1190 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1191 a composition, take its buffer position from IT->cmp_it.charpos.
1192 Fixes cursor positioning at the beginning of a line that begins
1193 with a composed character.
1194
9778ebcc
EZ
11952011-08-18 Eli Zaretskii <eliz@gnu.org>
1196
0be6ee06
EZ
1197 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1198 character bidirectional type, use STRONG_L instead. Fixes crashes
1199 in a buffer produced by `describe-categories'.
1200
9778ebcc
EZ
1201 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1202 members before the level stack, so they would be saved and
1203 restored when copying iterator state. Fixes incorrect reordering
1204 around TABs covered by display properties.
1205
156bffbe
AS
12062011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1207
1208 * process.c (Fnetwork_interface_list): Correctly determine buffer
1209 size.
1210
72ad093b
CY
12112011-08-17 Chong Yidong <cyd@stupidchicken.com>
1212
1213 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1214 (internal_condition_case_2, internal_condition_case_n):
1215 Remove unnecessary aborts (Bug#9081).
72ad093b 1216
35774242
EZ
12172011-08-17 Eli Zaretskii <eliz@gnu.org>
1218
1219 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1220 has no `load' handler, try opening the file locally. (Bug#9311)
1221
db76dd85
KB
12222011-08-16 Ken Brown <kbrown@cornell.edu>
1223
1224 * gmalloc.c: Expand comment.
1225
b215eee5
EZ
12262011-08-16 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1229 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1230
a4579d33
KB
12312011-08-16 Ken Brown <kbrown@cornell.edu>
1232
1233 Fix memory allocation problems in Cygwin build (Bug#9273).
1234
1235 * unexcw.c ( __malloc_initialized): Declare external variable.
1236 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1237
8b76d6f8
SM
1238 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1239 New variables.
a4579d33
KB
1240 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1241 dumped emacs.
1242 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1243 in the static heap.
1244 [CYGWIN] (special_realloc): New function.
1245 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1246 requests to realloc storage in the static heap.
1247
3ebec551
PE
12482011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1249
1250 * bidi.c (bidi_initialize): Remove unused local.
1251
9fd8be00
EZ
12522011-08-15 Eli Zaretskii <eliz@gnu.org>
1253
474a8465
EZ
1254 * biditype.h: File removed.
1255
1256 * bidimirror.h: File removed.
1257
1258 * deps.mk (bidi.o): Remove biditype.h and
1259 bidimirror.h.
1260
1261 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1262 bidimirror.h.
1263
1264 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1265
1266 * chartab.c: Improve commentary for the uniprop_table API.
1267
32413314
EZ
1268 * bidi.c (bidi_paragraph_init): Support zero value of
1269 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1270 (bidi_initialize): Use uniprop_table instead of including
1271 biditype.h and bidimirror.h.
32413314 1272
9fd8be00
EZ
1273 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1274 coordinates of the iterator when restoring from ppos_it.
1275 (Bug#9296)
1276
5cf2b69b
KH
12772011-08-14 Kenichi Handa <handa@m17n.org>
1278
1279 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1280 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1281
daf17d00
EZ
12822011-08-14 Eli Zaretskii <eliz@gnu.org>
1283
1284 * xdisp.c (move_it_in_display_line_to): Don't invoke
1285 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1286 ppos_it. Fixes vertical cursor motion when line beginning is
1287 covered by an image. (Bug#9296)
1288
08e3161a
JD
12892011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1290
1291 * nsterm.h (ns_run_ascript): Declare.
1292 (NSAPP_DATA2_RUNASSCRIPT): Define.
1293
1294 * nsfns.m (as_script, as_result, as_status): New static variables.
1295 (ns_run_ascript): New function.
5e617bc2 1296 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1297 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1298 the event loop. Get status from as_status (Bug#7276).
1299
1300 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1301 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1302 the event loop (Bug#7276).
1303
a3720aa2
AS
13042011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1305
1306 * gnutls.c (QCgnutls_bootprop_priority)
1307 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1308 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1309 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1310 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1311 (QCgnutls_bootprop_verify_hostname_error)
1312 (QCgnutls_bootprop_callbacks_verify): Rename from
1313 Qgnutls_bootprop_..., all uses changed.
1314
1315 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1316 uses changed.
1317
0a0d27fb
PE
13182011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1319
19d5c50c
PE
1320 * xfaces.c (Qframe_set_background_mode): Now static.
1321 * dispextern.h (Qframe_set_background_mode): Remove decl.
1322
0a0d27fb
PE
1323 * process.c (Fnetwork_interface_info): Declare local only if needed.
1324
377538cb
JD
13252011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1326
1327 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1328 (Fnetwork_interface_list): Allocate in increments of bytes instead
1329 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1330 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1331 sockaddr.
1332 (struct ifflag_def): notrailers is smart on OSX.
1333 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1334 Get hardware address with getifaddrs if available.
1335
08fff70c
EZ
13362011-08-12 Eli Zaretskii <eliz@gnu.org>
1337
1338 * xdisp.c (iterate_out_of_display_property): xassert that
1339 IT->position is set to within IT->object's boundaries. Break from
1340 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1341 when IT->position is set up wrongly due to some bug.
1342 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1343 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1344 entry. Force push_it to save on the stack the current
1345 buffer/string position, to be restored by pop_it. Fix flags in
1346 the iterator structure wrt the object coming from a display
1347 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1348 properties. (Bug#9284)
1349
7be1c708 13502011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1351
7be1c708
CY
1352 * fontset.c (fontset_get_font_group): Add proper type checks.
1353 (Bug#9172)
aac0c6e3 1354
7be1c708 13552011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1356
7be1c708
CY
1357 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1358 and LC_VERSION_MIN_MACOSX.
1359 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1360 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1361
97bb72a6
EZ
13622011-08-08 Eli Zaretskii <eliz@gnu.org>
1363
1364 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1365 no-display-properties-and-no-overlays under bidi display.
1366 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1367 properties and overlays.
97bb72a6 1368
d5617611
CY
13692011-08-08 Chong Yidong <cyd@stupidchicken.com>
1370
37e11a63
CY
1371 * editfns.c (Fset_time_zone_rule): Document relationship with the
1372 setenv function.
1373
d5617611
CY
1374 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1375 the font entity extracted from the cache (Bug#8109).
1376
58872834
CY
13772011-08-07 Chong Yidong <cyd@stupidchicken.com>
1378
1379 * composite.c (autocmp_chars): Don't reset point. That is done by
1380 restore_point_unwind (Bug#5984).
1381
75bfc667
JL
13822011-08-07 Juri Linkov <juri@jurta.org>
1383
1384 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1385 to show the arg `TIME' instead of `TIMEVAL'.
1386
d1410150
EZ
13872011-08-06 Eli Zaretskii <eliz@gnu.org>
1388
1389 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1390 display property strides EOL and includes a newline, as in
1391 longlines-mode. (Bug#9254)
75b771e4
EZ
1392 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1393 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1394
1395 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1396 is non-zero, even if the data buffer is NULL. Fixes a crash in
1397 vertical-motion with longlines-mode. (Bug#9254)
1398
35928349
EZ
13992011-08-05 Eli Zaretskii <eliz@gnu.org>
1400
ec7cc85b
EZ
1401 * bidi.c <bidi_cache_total_alloc>: Now static.
1402 (bidi_initialize): Initialize bidi_cache_total_alloc.
1403
8b76d6f8 1404 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1405 cache. (Bug#9221)
1406
1407 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1408 amount allocated this far in `bidi_cache_total_alloc'.
1409 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1410 non-zero, only free the data buffer without restoring the cache
1411 contents. All callers changed.
1412
1413 * dispextern.h (bidi_unshelve_cache): Update prototype.
1414
1415 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1416 (move_it_in_display_line, move_it_to)
1417 (move_it_vertically_backward, move_it_by_lines): Replace the call
1418 to xfree to an equivalent call to bidi_unshelve_cache.
1419 (move_it_in_display_line_to): Fix logic of returning
412b6358 1420 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1421
e2e2423b
EZ
14222011-08-05 Eli Zaretskii <eliz@gnu.org>
1423
1424 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1425 came from a string character with a `cursor' property. (Bug#9229)
1426
ae9e757a
JD
14272011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1428
1429 * Makefile.in (LIB_PTHREAD): New variable.
1430 (LIBES): Add LIB_PTHREAD (Bug#9216).
1431
1432 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1433 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1434
213bd7f2
AS
14352011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1436
1437 * regex.c (re_iswctype): Remove some redundant boolean
1438 conversions.
1439
99aaf75f
JD
14402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1441
1442 * xterm.c (x_find_topmost_parent): New function.
1443 (x_set_frame_alpha): Find topmost parent window with
1444 x_find_topmost_parent and set the property there also (bug#9181).
1445 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1446
c74e9d86
PE
14472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 * callproc.c (Fcall_process): Avoid vfork clobbering
1450 the local vars buffer, coding_systems, current_dir.
1451
640c8776
SM
14522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1453
1454 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1455
f26d0e4c
PE
14562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1457
8a10d76c
PE
1458 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1459 so that it is not optimized away.
1460
f26d0e4c
PE
1461 * xdisp.c (compute_display_string_pos): Remove unused local.
1462
55439c61
EZ
14632011-08-02 Eli Zaretskii <eliz@gnu.org>
1464
1465 Fix slow cursor motion and scrolling in large buffers with
1466 selective display, like Org Mode buffers. (Bug#9218)
1467
1468 * dispextern.h (struct bidi_it): New member disp_prop_p.
1469
1470 * xdisp.c: Remove one-slot cache of display string positions.
1471 (compute_display_string_pos): Accept an additional argument
5e617bc2 1472 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1473 for a display string or property. If found, set DISP_PROP_P
1474 non-zero.
1475
1476 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1477 DISP_PROP_P, and pass it to compute_display_string_pos.
1478 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1479 non-zero. All callers of bidi_fetch_char changed.
1480
fb33fa43
SM
14812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1482
1483 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1484
b099e063
DM
14852010-12-03 Don March <don@ohspite.net>
1486
1487 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1488 last character M-[char] is translated to ESC [char] (bug#7541).
1489
5cc7f7af
KH
14902011-08-02 Kenichi Handa <handa@m17n.org>
1491
d0fffa3f 1492 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1493
1494 * chartab.c (uniprop_table): Make it non-static.
1495
525d5e6e
EZ
14962011-08-01 Eli Zaretskii <eliz@gnu.org>
1497
1498 * xdisp.c (forward_to_next_line_start): Accept additional argument
1499 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1500 on the newline.
1501 (reseat_at_next_visible_line_start): Use the bidi iterator state
1502 returned by forward_to_next_line_start to restore the state of
1503 it->bidi_it after backing up to previous newline. (Bug#9212)
1504
31011111
AS
15052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1506
1507 * regex.c (re_comp): Protoize.
1508 (re_exec): Fix return type.
1509 (regexec): Fix type of `ret'. (Bug#9203)
1510
476371c4
PE
15112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1512
e5d76069
PE
1513 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1514 This is needed if max-image-size is a floating-point number.
1515
9a79b20c
AS
15162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1517
1518 * print.c (print_object): Print empty symbol as ##.
1519
1520 * lread.c (read1): Read ## as empty symbol.
1521
d8c2fa78
AA
15222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1523
1524 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1525 setting frame foreground color (Bug#9175).
1526 (x_set_background_color): Likewise.
1527
ffe57a7a
AA
1528 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1529 contents (Bug#9176).
1530 (EmacsTooltip -init): Remove bezels and add shadows to
1531 tooltip windows.
1532
bf3492a5
AA
1533 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1534 or scroll bar (Bug#8470).
1535
d55e9c53
AA
1536 * nsfont.m (nsfont_open): Remove assignment to voffset and
1537 unnecessary vars hshink, expand, hd, full_height, min_height.
1538 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1539
1540 * nsterm.h (nsfont_info): Remove voffset field.
1541
d8c2fa78 15422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1543
1544 Implement strike-through and overline on NextStep (Bug#8863).
1545
1546 * nsfont.m (nsfont_open): Use underline position provided by font,
1547 instead of hard-coded value of 2.
1548 (nsfont_draw): Call ns_draw_text_decoration instead.
1549
1550 * nsterm.h: Add declaration for ns_draw_text_decoration.
1551
1552 * nsterm.m (ns_draw_text_decoration): New function for drawing
1553 underline, overline, and strike-through.
1554 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1555 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1556 accommodate underlining, etc.
4843aac3 1557
4cc60b9b
EZ
15582011-07-28 Eli Zaretskii <eliz@gnu.org>
1559
bc7ece87
EZ
1560 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1561 default.
4cc60b9b 1562
476371c4
PE
15632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1564
66606eea
PE
1565 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1566 Without this fix, if a signal arrives just after memory fills up,
1567 'malloc' might be invoked reentrantly.
1568
476371c4
PE
1569 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1570 In other words, assume that every image size is allowed, on non-X
1571 hosts. This assumption is probably wrong, but it lets Emacs compile.
1572
f3fcc40d
AS
15732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1574
1575 * regex.c (re_iswctype): Convert return values to boolean.
1576
350c992f
EZ
15772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1578
1579 * xdisp.c (compute_display_string_pos): Don't use cached display
1580 string position if the buffer had its restriction changed.
1581 (Bug#9184)
1582
5266b4bb
PE
15832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1584
1585 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1586
2573a837 15872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1588
41f55ccd 1589 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1590
39e378da
PE
1591 * bidi.c: Integer size and overflow fixes.
1592 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1593 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1594 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1595 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1596 (bidi_find_other_level_edge):
1597 Use ptrdiff_t instead of EMACS_INT where either will do.
1598 This works better on 32-bit hosts configured --with-wide-int.
1599 (bidi_cache_ensure_space): Check for size-calculation overflow.
1600 Use % rather than repeated addition, for better worst-case speed.
1601 Don't set bidi_cache_size until after xrealloc returns, because it
1602 might not return.
1603 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1604 (bidi_cache_ensure_space): Also check that the bidi cache size
1605 does not exceed that of the largest Lisp string or buffer. See Eli
1606 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1607
5e927815
PE
1608 * alloc.c (__malloc_size_t): Remove.
1609 All uses replaced by size_t. See Andreas Schwab's note
1610 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1611
ca4aa935
PE
1612 * image.c: Improve checking for integer overflow.
1613 (check_image_size): Assume that f is nonnull, since
1614 it is always nonnull in practice. This is one less thing to
1615 worry about when checking for integer overflow later.
1616 (x_check_image_size): New function, which checks for integer
1617 overflow issues inside X.
1618 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1619 This removes the need for a memory_full check.
1620 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1621 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1622 (xbm_read_bitmap_data): Change locals back to 'int', since
1623 their values must fit in 'int'.
1624 (xpm_load_image, png_load, tiff_load):
1625 Invoke x_create_x_image_and_pixmap earlier,
1626 to avoid much needless work if the image is too large.
1627 (tiff_load): Treat overly large images as if
1628 x_create_x_image_and_pixmap failed, not as malloc failures.
1629 (gs_load): Use x_check_image_size.
1630
5f8f9cc2
PE
1631 * gtkutil.c: Omit integer casts.
1632 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1633 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1634
5adf60bc
PE
1635 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1636
c8907a93
PE
1637 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1638 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1639 would wrongly return t on a 64-bit host.
1640
e3c25c68
PE
1641 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1642 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1643 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1644 and therefore cause GCC to emit a bogus diagnostic in some cases.
1645
3f791afe
PE
1646 * image.c: Integer signedness and overflow and related fixes.
1647 This is not an exhaustive set of fixes, but it's time to
1648 record what I've got.
1649 (lookup_pixel_color, check_image_size): Remove redundant decls.
1650 (check_image_size): Don't assume that arbitrary EMACS_INT values
1651 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1652 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1653 (tiff_load, imagemagick_load_image):
1654 Check for overflow in size calculations.
1655 (x_create_x_image_and_pixmap): Remove unnecessary test for
1656 xmalloc returning NULL; that can't happen.
1657 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1658 (xpm_color_bucket): Use better integer hashing function.
1659 (xpm_cache_color): Don't possibly over-allocate memory.
1660 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1661 (gif_memory_source):
1662 Use ptrdiff_t, not int or size_t, to record sizes.
1663 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1664 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1665 either works, as we prefer signed integers.
1666 (tiff_read_from_memory, tiff_write_from_memory):
1667 Return tsize_t, not size_t, since that's what the TIFF API wants.
1668 (tiff_read_from_memory): Don't fail simply because the read would
1669 go past EOF; instead, return a short read.
1670 (tiff_load): Omit no-longer-needed casts.
1671 (Fimagemagick_types): Don't assume size fits into 'int'.
1672
3cc5a532
PE
1673 Improve hashing quality when configured --with-wide-int.
1674 * fns.c (hash_string): New function, taken from sxhash_string.
1675 Do not discard information about ASCII character case; this
1676 discarding is no longer needed.
1677 (sxhash-string): Use it. Change sig to match it. Caller changed.
1678 * lisp.h: Declare it.
1679 * lread.c (hash_string): Remove, since we now use fns.c's version.
1680 The fns.c version returns a wider integer if --with-wide-int is
1681 specified, so this should help the quality of the hashing a bit.
1682
b312a492
PE
1683 * emacs.c: Integer overflow minor fix.
1684 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1685 Define only if GNU_LINUX.
1686 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1687
dfd153ae
PE
1688 * dispnew.c: Integer signedness and overflow fixes.
1689 Remove unnecessary forward decls, that were a maintenance hassle.
1690 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1691 All uses changed.
1692 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1693 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1694 (prepare_desired_row, line_draw_cost):
1695 Use int, not unsigned, where either works.
1696 (save_current_matrix, restore_current_matrix):
1697 Use ptrdiff_t, not size_t, where either works.
1698 (init_display): Check for overflow more accurately, and without
1699 relying on undefined behavior.
1700
a81d11a3
PE
1701 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1702 Remove, replacing with the new symbols in lisp.h. All uses changed.
1703 * fileio.c (make_temp_name):
1704 * filelock.c (lock_file_1, lock_file):
1705 * xdisp.c (message_dolog):
1706 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1707 Use pMd etc. instead.
1708 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1709 replacing the pWIDE etc. symbols removed from editfns.c.
1710
3300e6fd
PE
1711 * keyboard.h (num_input_events): Now uintmax_t.
1712 This is (very slightly) less likely to mess up due to wraparound.
1713 All uses changed.
1714
fd05c7e9
PE
1715 * buffer.c: Integer signedness fixes.
1716 (alloc_buffer_text, enlarge_buffer_text):
1717 Use ptrdiff_t rather than size_t when either will do, as we prefer
1718 signed integers.
1719
903fe15d
PE
1720 * alloc.c: Integer signedness and overflow fixes.
1721 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1722 (__malloc_size_t): Default to size_t, not to int.
1723 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1724 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1725 Prefer ptrdiff_t to size_t when either would do, as we prefer
1726 signed integers.
1727 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1728 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1729 Now const. Initialize with values that are in range even if char
1730 is signed.
1731 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1732 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1733 These functions do the right thing with sizes > 2**32.
1734 (check_depth): Now ptrdiff_t, not int.
1735 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1736 Adjust to new way of storing sizes. Check for size overflow bugs
1737 in rest of code.
1738 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1739 slightly wrong anyway, as it missed one instance of
1740 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1741 (refill_memory_reserve): Omit needless cast to size_t.
1742 (mark_object_loop_halt): Mark as externally visible.
1743
ac82cc6a
PE
1744 * xselect.c: Integer signedness and overflow fixes.
1745 (Fx_register_dnd_atom, x_handle_dnd_message):
1746 Use ptrdiff_t, not size_t, since we prefer signed.
1747 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1748 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1749 x_dnd_atoms_size and x_dnd_atoms_length.
1750
c2d1e36d
PE
1751 * doprnt.c: Prefer signed to unsigned when either works.
1752 * eval.c (verror):
1753 * doprnt.c (doprnt):
1754 * lisp.h (doprnt):
1755 * xdisp.c (vmessage):
1756 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1757 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1758 prefer signed arithmetic to avoid comparison confusion.
1759 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1760 but is a bit tricky.
1761
0e926e56
PE
1762 Assume freestanding C89 headers, string.h, stdlib.h.
1763 * data.c, doprnt.c, floatfns.c, print.c:
1764 Include float.h unconditionally.
1765 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1766 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1767 * regex.c: Likewise for stddef.h, string.h.
1768 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1769 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1770 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1771 (STDC_HEADERS): Remove obsolete defines.
1772 * sysdep.c: Include limits.h unconditionally.
1773
9cfdb3ec
PE
1774 Assume support for memcmp, memcpy, memmove, memset.
1775 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1776 * regex.c (memcmp, memcpy):
1777 Remove; we assume C89 now.
1778
1779 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1780 (__malloc_safe_bcopy): Remove; no longer needed.
1781
cf950e6b 1782 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1783 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1784 well either way, and we prefer signed to unsigned.
1785
dbf38e02
LMI
17862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1787
1788 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1789 closes the connection while we're reading (bug#9182).
1790
d6f0886c 17912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1792
d6f0886c
JD
1793 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1794 are specified (Bug#9168).
24e0f6b1 1795
2eb1f9e6
PE
17962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1797
1798 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1799 Found by GCC static checking and --with-wide-int on a 32-bit host.
1800
22381272 18012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1802
1803 * xdisp.c (compute_display_string_pos): Fix logic of caching
1804 previous display string position. Initialize cached_prev_pos to
1805 -1. Fixes slow-down at the beginning of a buffer.
1806
f25e39b4
EZ
18072011-07-24 Eli Zaretskii <eliz@gnu.org>
1808
1809 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1810 for attrs[LFACE_FONTSET_INDEX].
1811
04c4b52e
PE
18122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1813
1814 * xml.c (parse_region): Remove unused local
1815 that was recently introduced.
1816
c1734fbd
EZ
18172011-07-23 Eli Zaretskii <eliz@gnu.org>
1818
be18c5a5
EZ
1819 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1820 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1821
c1734fbd
EZ
1822 * xdisp.c (move_it_in_display_line_to): Record the best matching
1823 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1824 exit if none of the characters scanned was an exact match.
1825 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1826 when exact match is impossible due to invisible text, and the
1827 lines are truncated.
1828
a258d627
JD
18292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1830
1831 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1832 for OSX >= 10.7.
1833
b6d5a689
EZ
18342011-07-22 Eli Zaretskii <eliz@gnu.org>
1835
0f74f785
EZ
1836 Fix a significant slow-down of cursor motion with C-n, C-p,
1837 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1838 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1839 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1840 (next_element_from_buffer): Call compute_stop_pos_backwards to
1841 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1842 base_level_stop.
1843 (reseat): Don't look for prev_stop, as that could mean a very long
1844 run.
1845 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1846 <cached_disp_overlay_modiff>: Cache for last found display string
1847 position.
551918c1 1848 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1849 about the same buffer in the same area of character positions, and
1850 the buffer wasn't changed since the time the display string
1851 position was cached.
551918c1 1852
b2d0c91a
EZ
18532011-07-22 Eli Zaretskii <eliz@gnu.org>
1854
1855 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1856 is an integer, which is important for empty lines. (Bug#9149)
1857
043604ee
CY
18582011-07-22 Chong Yidong <cyd@stupidchicken.com>
1859
1860 * frame.c (Fmodify_frame_parameters): In tty case, update the
1861 default face if necessary (Bug#4238).
1862
da4adb04
CY
18632011-07-21 Chong Yidong <cyd@stupidchicken.com>
1864
1865 * editfns.c (Fstring_to_char): No need to explain what a character
1866 is in the docstring (Bug#6576).
1867
9abd0532
LMI
18682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1869
1870 * xml.c (parse_region): Make sure we always return a tree.
1871
36881d16
HK
18722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1873
1874 * xml.c (parse_region): If a document contains only comments,
1875 return that, too.
1876
1e98674d
LMI
18772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1878
1879 * xml.c (make_dom): Return comments, too.
1880
590bd467
PE
18812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 Port to OpenBSD.
1884 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1885 and the surrounding thread.
1886 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1887 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1888 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1889 timer goes off.
1890 * s/openbsd.h (BROKEN_SIGIO): Define.
1891 * unexelf.c (unexec) [__OpenBSD__]:
1892 Don't update the .mdebug section of the Alpha COFF symbol table.
1893
f41628b2
LMI
18942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1895
1896 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1897 (bug#8460).
1898
b59b67c5
PE
18992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1900
15e3a074
PE
1901 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1902 This fixes some race conditions on the permissions of any newly
1903 created file.
1904
41bed37d
PE
1905 * alloc.c (valid_pointer_p): Use pipe, not open.
1906 This fixes some permissions issues when debugging.
1907
b59b67c5
PE
1908 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1909 If fchown fails to set both uid and gid, try to set just gid,
1910 as that is sometimes allowed. Adjust the file's mode to eliminate
1911 setuid or setgid bits that are inappropriate if fchown fails.
1912
925a6be7
SM
19132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1914
1915 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1916 to compare Lisp_Objects.
1917 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1918 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1919 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1920
52968808
AS
19212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1922
0a6a104b
AS
1923 * lread.c (read_integer): Unread even EOF character.
1924 (read1): Likewise. Properly record start position of symbol.
1925
52968808
AS
1926 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1927 symbol character follows.
1928
9e381cdd
PE
19292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1930
1931 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1932 This works around a problem with the previous change to Fcopy_file.
1933 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1934 and without this change, GCC might complain about discarding
1935 fchown's return value.
1936
b5641435
JB
19372011-07-16 Juanma Barranquero <lekktu@gmail.com>
1938
1939 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1940
a8031457
PE
19412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1942
1943 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1944
dd889327
LMI
19452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1946
750c33f7
LMI
1947 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1948 it's used from the C level.
1949
dd889327
LMI
1950 * process.c: Use the same condition for POLL_FOR_INPUT in both
1951 keyboard.c and process.c (bug#1858).
1952
87e86684
LM
19532011-07-09 Lawrence Mitchell <wence@gmx.li>
1954
1955 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1956 (Fgnutls_boot): Use it.
1957
64348f40
AS
19582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1959
1960 * doc.c (Fsubstitute_command_keys): Revert last change.
1961
1d698799
LMI
19622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1963
f863868c
LMI
1964 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1965 quotes the next character, and doesn't affect other longer
1966 sequences (bug#8935).
1967
1d698799
LMI
1968 * lread.c (syms_of_lread): Clarify that is isn't only
1969 `eval-buffer' and `eval-defun' that's affected by
1970 `lexical-binding' (bug#8460).
1971
aa4b6df6
EZ
19722011-07-15 Eli Zaretskii <eliz@gnu.org>
1973
1974 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1975 bidi redisplay when a line includes both an image and is
1976 truncated.
1977
5d856da6
PE
19782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1979
ad6042bb
PE
1980 Fix minor problems found by static checking.
1981 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1982 (elsz): Now a signed constant, not a size_t var. We prefer signed
1983 types to unsigned, to avoid integer comparison confusion. Without
1984 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1985 "cannot optimize loop, the loop counter may overflow", a symptom
1986 of the confusion.
f00bbb22 1987 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1988 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1989
6468f31c
LMI
19902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1991
49080b10
LMI
1992 * search.c (Fre_search_backward): Mention `case-fold-search' in
1993 all the re_search_* functions (bug#8138).
1994
6468f31c
LMI
1995 * keyboard.c (Fopen_dribble_file): Document when the file is
1996 closed (bug#8056).
1997
c965adc5
EZ
19982011-07-14 Eli Zaretskii <eliz@gnu.org>
1999
df9733bf
EZ
2000 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2001 bidi_cache_idx.
2002
0bb23927
EZ
2003 Support bidi reordering of display and overlay strings.
2004 * xdisp.c (compute_display_string_pos)
2005 (compute_display_string_end): Accept additional argument STRING.
2006 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2007 (reseat_to_string): Initialize bidi_it->string.s and
2008 bidi_it->string.schars.
2009 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2010 NULL (avoids a crash in bidi_paragraph_init).
2011 Initialize itb.string.lstring.
0bb23927
EZ
2012 (init_iterator): Call bidi_init_it only of a valid
2013 buffer position was specified. Initialize paragraph_embedding to
2014 L2R.
2015 (reseat_to_string): Initialize the bidi iterator.
2016 (display_string): If we need to ignore text properties of
2017 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2018 original value of -1 will not work with bidi.)
2019 (compute_display_string_pos): First arg is now struct
2020 `text_pos *'; all callers changed. Support display properties on
2021 Lisp strings.
2022 (compute_display_string_end): Support display properties on Lisp
2023 strings.
2024 (init_iterator, reseat_1, reseat_to_string): Initialize the
2025 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2026 when iterating on a string not from display properties).
640c8776
SM
2027 (compute_display_string_pos, compute_display_string_end):
2028 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2029 arrow keys.
2030 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2031 base_level_stop; instead, set base_level_stop to BEGV.
2032 Fixes crashes in vertical-motion.
0bb23927
EZ
2033 (next_element_from_buffer): Improve commentary for when
2034 the iterator is before prev_stop.
2035 (init_iterator): Initialize bidi_p from the default value of
2036 bidi-display-reordering, not from buffer-local value. Use the
2037 buffer-local value only if initializing for buffer iteration.
2038 (handle_invisible_prop): Support invisible properties on strings
2039 that are being bidi-reordered.
2040 (set_iterator_to_next): Support bidi reordering of C strings and
2041 Lisp strings.
2042 (next_element_from_string): Support bidi reordering of Lisp
2043 strings.
2044 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2045 (display_string): Support display of R2L glyph rows.
2046 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2047 (init_iterator): Don't initialize it->bidi_p for strings
2048 here.
2049 (reseat_to_string): Initialize it->bidi_p for strings here.
2050 (next_element_from_string, next_element_from_c_string)
2051 (next_element_from_buffer): Add xassert's for correspondence
2052 between IT's object being iterated and it->bidi_it.string
2053 structure.
2054 (face_before_or_after_it_pos): Support bidi iteration.
2055 (next_element_from_c_string): Handle the case of the first string
2056 character that is not the first one in the visual order.
2057 (get_visually_first_element): New function, refactored from common
2058 parts of next_element_from_buffer, next_element_from_string, and
2059 next_element_from_c_string.
2060 (tool_bar_lines_needed, redisplay_tool_bar)
2061 (display_menu_bar): Force left-to-right direction. Add a FIXME
2062 comment for making that be controlled by a user option.
2063 (push_it, pop_it): Save and restore the state of the
2064 bidi iterator. Save and restore the bidi_p flag.
2065 (pop_it): Iterate out of display property for string iteration as
2066 well.
2067 (iterate_out_of_display_property): Support iteration over strings.
2068 (handle_single_display_spec): Set up it->bidi_it for iteration
2069 over a display string, and call bidi_init_it.
2070 (handle_single_display_spec, next_overlay_string)
2071 (get_overlay_strings_1, push_display_prop): Set up the bidi
2072 iterator for displaying display or overlay strings.
2073 (forward_to_next_line_start): Don't use the shortcut if
2074 bidi-iterating.
2075 (back_to_previous_visible_line_start): If handle_display_prop
2076 pushed the iterator stack, restore the internal state of the bidi
2077 iterator by calling bidi_pop_it same number of times.
2078 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2079 and we are bidi-iterating, don't decrement the iterator position;
2080 instead, set the first_elt flag in the bidi iterator, to produce
2081 the same effect.
2082 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2083 (push_display_prop): xassert that we are iterating a buffer.
2084 (push_it, pop_it): Save and restore paragraph_embedding member.
2085 (handle_single_display_spec, next_overlay_string)
2086 (get_overlay_strings_1, reseat_1, reseat_to_string)
2087 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2088 correctly. Don't assume unibyte strings are not bidi-reordered.
2089 (compute_display_string_pos)
2090 (compute_display_string_end): Fix handling the case of C string.
2091 (push_it, pop_it): Save and restore from_disp_prop_p.
2092 (handle_single_display_spec, push_display_prop): Set the
2093 from_disp_prop_p flag.
2094 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2095 (pop_it): Call iterate_out_of_display_property only if we are
2096 popping after iteration over a string that came from a display
2097 property. Fix a typo in popping stretch info. Add an assertion
2098 for verifying that the iterator position is in sync with the bidi
2099 iterator.
2100 (handle_single_display_spec, get_overlay_strings_1)
2101 (push_display_prop): Fix initialization of paragraph direction for
2102 string when that of the parent object is not yet determined.
2103 (reseat_1): Call bidi_init_it to resync the bidi
2104 iterator with IT's position. (Bug#7616)
2105 (find_row_edges): If ROW->start.pos gives position
2106 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2107 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2108 Reset the from_disp_prop_p flag.
2109 (SAVE_IT, RESTORE_IT): New macros.
2110 (pos_visible_p, face_before_or_after_it_pos)
2111 (back_to_previous_visible_line_start)
2112 (move_it_in_display_line_to, move_it_in_display_line)
2113 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2114 (try_scrolling, redisplay_window, display_line): Use them when
2115 saving a temporary copy of the iterator and restoring it back.
2116 (back_to_previous_visible_line_start, reseat_1)
2117 (init_iterator): Empty the bidi cache "stack".
2118 (move_it_in_display_line_to): If iterator ended up at
2119 EOL, but we never saw any buffer positions smaller than
2120 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2121 motion in bidi-reordered lines.
2122 (move_it_in_display_line_to): Record prev_method and prev_pos
2123 immediately before the call to set_iterator_to_next. Fixes cursor
2124 motion in bidi-reordered lines with stretch glyphs and strings
2125 displayed in margins. (Bug#8133) (Bug#8867)
2126 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2127 TO_CHARPOS.
640c8776
SM
2128 (pos_visible_p): Support positions in bidi-reordered lines.
2129 Save and restore bidi cache.
0bb23927
EZ
2130
2131 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2132 (bidi_paragraph_info): Delete unused struct.
2133 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2134 (bidi_cache_start): New variable.
2135 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2136 to zero.
2137 (bidi_cache_fetch_state, bidi_cache_search)
2138 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2139 (bidi_cache_find, bidi_peek_at_next_level)
2140 (bidi_level_of_next_char, bidi_find_other_level_edge)
2141 (bidi_move_to_visually_next): Compare cache index with
2142 bidi_cache_start rather than with zero.
2143 (bidi_fetch_char): Accept new argument STRING; all callers
2144 changed. Support iteration over a string. Support strings with
2145 display properties. Support unibyte strings. Fix the type of
2146 `len' according to what STRING_CHAR_AND_LENGTH expects.
2147 (bidi_paragraph_init, bidi_resolve_explicit_1)
2148 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2149 (bidi_level_of_next_char, bidi_move_to_visually_next):
2150 Support iteration over a string.
0bb23927
EZ
2151 (bidi_set_sor_type, bidi_resolve_explicit_1)
2152 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2153 can now be zero (for strings); special values 0 and -1 were
2154 changed to -1 and -2, respectively.
2155 (bidi_char_at_pos): New function.
2156 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2157 Call it instead of FETCH_MULTIBYTE_CHAR.
2158 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2159 initialized to valid values.
2160 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2161 values.
2162 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2163 the test for valid cached positions. Fix the logic for looking up
2164 the sentinel state in the cache. GCPRO the Lisp string we are
2165 iterating.
2166 (bidi_push_it, bidi_pop_it): New functions.
2167 (bidi_initialize): Initialize the bidi cache start stack pointer.
2168 (bidi_cache_ensure_space): New function, refactored from part of
2169 bidi_cache_iterator_state. Don't assume the required size is just
2170 one BIDI_CACHE_CHUNK away.
2171 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2172 (bidi_count_bytes, bidi_char_at_pos): New functions.
2173 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2174 always valid if bidi_cache_idx is valid.
2175 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2176 is valid if it's going to be used.
2177 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2178 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2179 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2180 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2181 (bidi_find_other_level_edge, bidi_cache_start_stack):
2182 All variables related to cache indices are now EMACS_INT.
c965adc5 2183
0bb23927
EZ
2184 * dispextern.h (struct bidi_string_data): New structure.
2185 (struct bidi_it): New member `string'. Make flag members be 1-bit
2186 fields, and put them last in the struct.
640c8776
SM
2187 (compute_display_string_pos, compute_display_string_end):
2188 Update prototypes.
0bb23927
EZ
2189 (bidi_push_it, bidi_pop_it): Add prototypes.
2190 (struct iterator_stack_entry): New members bidi_p,
2191 paragraph_embedding, and from_disp_prop_p.
2192 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2193 (bidi_shelve_cache, bidi_unshelve_cache):
2194 Declare prototypes.
0bb23927
EZ
2195
2196 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2197 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2198 and vector-like objects.
2199
2200 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2201 cache around display iteration.
2202
2203 * window.c (Fwindow_end, window_scroll_pixel_based)
2204 (displayed_window_lines, Frecenter): Save and restore the bidi
2205 cache around display iteration.
2206
3bbd2265
LMI
22072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2208
2209 * editfns.c (Fdelete_region): Clarify the use of the named
2210 parameters (bug#6788).
2211
adc47434
MR
22122011-07-14 Martin Rudalics <rudalics@gmx.at>
2213
2214 * indent.c (Fvertical_motion): Set and restore w->pointm when
2215 saving and restoring the window's buffer (Bug#9006).
2216
837c31f8
LMI
22172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2218
2219 * editfns.c (Fstring_to_char): Clarify just what is returned
2220 (bug#6576). Text by Eli Zaretskii.
2221
ac389d0c
JB
22222011-07-13 Juanma Barranquero <lekktu@gmail.com>
2223
2224 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2225
0be0ce47
EZ
22262011-07-13 Eli Zaretskii <eliz@gnu.org>
2227
2228 * buffer.c (mmap_find): Fix a typo.
2229
cd18e7e3
JB
22302011-07-13 Johan Bockgård <bojohan@gnu.org>
2231
2232 Fix execution of x selection hooks.
2233 * xselect.c (Qx_lost_selection_functions)
2234 (Qx_sent_selection_functions): New vars.
2235 (syms_of_xselect): DEFSYM them.
2236 (x_handle_selection_request): Pass Qx_sent_selection_functions
2237 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2238 (x_handle_selection_clear,x_clear_frame_selections):
2239 Pass Qx_lost_selection_functions rather than
2240 Vx_lost_selection_functions to Frun_hook_with_args.
2241
47ea7f44
PE
22422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2243
ac389d0c 2244 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2245 The old code sometimes used this field without initializing it.
2246
47ea7f44
PE
2247 * alloc.c (gc_sweep): Don't read past end of array.
2248 In theory, the old code could also have corrupted Emacs internals,
2249 though it'd be very unlikely.
2250
bc985c87
AS
22512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2252
2253 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2254 argument. (Bug#4026)
bc985c87 2255
0cf34688
LMI
22562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2257
b3dadd76
LMI
2258 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2259 key" (bug#4257).
2260
0cf34688
LMI
2261 * window.c (Fset_window_start): Doc fix (bug#4199).
2262 (Fset_window_hscroll): Ditto.
2263
270768cd
PE
22642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2265
077e3dda 2266 Fix minor new problems caught by GCC 4.6.1.
270768cd 2267 * term.c (init_tty): Remove unused local.
490011a6 2268 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2269 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2270 not used otherwise.
270768cd 2271
b1f58454
CY
22722011-07-12 Chong Yidong <cyd@stupidchicken.com>
2273
2274 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2275
22b9578d
LMI
22762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2277
6e70ab07
LMI
2278 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2279 are the mini-buffer and the echo area (bug#3320).
2280
22b9578d
LMI
2281 * term.c (init_tty): Remove support for supdup, c10 and perq
2282 terminals, which are no longer supported (bug#1482).
2283
8974cc9f
JB
22842011-07-10 Johan Bockgård <bojohan@gnu.org>
2285
2286 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2287
a560d974
JD
22882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2289
2290 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2291 for non-popups (Bug#3642).
2292
1dae0f0a
AS
22932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2294
268c2c36 2295 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2296 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2297 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2298 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2299 * data.c (fmod): Likewise.
2300 * dispnew.c (swap_glyphs_in_rows): Likewise.
2301 * emacs.c (memory_warning_signal): Likewise.
2302 * floatfns.c (float_error): Likewise.
2303 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2304 (otf_open, font_otf_capability, generate_otf_features)
2305 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2306 Likewise.
2307 * image.c (pbm_read_file): Likewise.
2308 * indent.c (string_display_width): Likewise.
2309 * intervals.c (check_for_interval, search_for_interval)
2310 (inc_interval_count, count_intervals, root_interval)
2311 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2312 * lread.c (defalias): Likewise.
268c2c36 2313 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2314 * regex.c (set_image_of_range_1, set_image_of_range)
2315 (regex_grow_registers): Likewise.
2316 * sysdep.c (strerror): Likewise.
2317 * termcap.c (valid_filename_p, tprint, main): Likewise.
2318 * tparam.c (main): Likewise.
2319 * unexhp9k800.c (run_time_remap, save_data_space)
2320 (update_file_ptrs, read_header, write_header, calculate_checksum)
2321 (copy_file, copy_rest, display_header): Likewise.
2322 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2323 Likewise.
2324 * xdisp.c (check_it): Likewise.
2325 * xfaces.c (register_color, unregister_color, unregister_colors):
2326 Likewise.
2327 * xfns.c (print_fontset_result): Likewise.
2328 * xrdb.c (member, fatal, main): Likewise.
2329
99033785
PE
23302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2331
2332 Fix minor problems found by static checking (Bug#9031).
2333 * chartab.c (char_table_set_range, map_sub_char_table):
2334 Remove unused locals.
2335 (uniprop_table): Now static.
2336 * composite.c (_work_char): Remove unused static var.
2337
9cb2ac56
JB
23382011-07-09 Juanma Barranquero <lekktu@gmail.com>
2339
2340 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2341
f25661f0
JD
23422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2343
2344 * gtkutil.c (qttip_cb): Remove code without function.
2345
8278c4fe
EZ
23462011-07-09 Eli Zaretskii <eliz@gnu.org>
2347
2348 * w32.c (pthread_sigmask): New stub.
2349
1692ae2d 23502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2351
8a6ebd58 2352 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2353 sigprocmask is portable only for single-threaded applications, and
2354 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2355 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2356 (LIBES): Use it.
2357 * callproc.c (Fcall_process):
2358 * process.c (create_process):
2359 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2360 Use pthread_sigmask, not sigprocmask.
123403e4 2361
1b854618
JD
23622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2363
2364 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2365 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2366 wrong (Bug#8591).
2367
3fe4b549
JD
23682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2369
0ce7e563
JD
2370 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2371 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2372 (xg_hide_tooltip): Fix comment.
2373
3fe4b549
JD
2374 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2375 in registerServicesMenuSendTypes.
2376 (validRequestorForSendType): Don't check ns_return_types.
2377
2378 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2379 ns_return_type.
2380
5df75e47
JR
23812011-07-08 Jason Rumney <jasonr@gnu.org>
2382
2383 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2384 frame struct members of non-existent frames (Bug#6284).
2385
699c10bd
JD
23862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2387
4393663b
JD
2388 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2389 variable firstTime not needed on OSX >= 10.6.
2390 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2391 >= 10.5. Use setKnobProportion, setDoubleValue.
2392
2393 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2394 (MAC_OS_X_VERSION_10_5): Define if not defined.
2395 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2396 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2397 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2398
2399 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2400 cString and lossyCString on OSX >= 10.4
2401
2402 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2403 sizeToFit on OSX >= 10.2.
2404
2405 * nsimage.m (allocInitFromFile): Don't use deprecated method
2406 bestRepresentationForDevice on OSX >= 10.6.
2407
2408 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2409 to avoid warning.
2410
2411 * emacs.c: Declare unexec_init_emacs_zone.
2412
a63e0781
JD
2413 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2414
699c10bd
JD
2415 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2416
2417 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2418 on svcsMenu (Bug#8842).
2419
2420 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2421 ns_return_types.
2422 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2423
2424 * nsterm.m (QUTF8_STRING): Declare.
2425 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2426 (validRequestorForSendType): Return type is (id).
2427 Change indexOfObjectIdenticalTo to indexOfObject.
2428 Check if we have local selection before returning self (Bug#8842).
2429 (writeSelectionToPasteboard): Put local selection into paste board
2430 if we have a local selection (Bug#8842).
2431 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2432
2433 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2434 (ns_get_local_selection): Declare.
2435
54e10184
LMI
24362011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2437
9888ff71
LMI
2438 * keymap.c (describe_map_tree): Don't insert a double newline at
2439 the end of the buffer (bug#1169) and return whether we inserted
2440 something.
2441
54e10184
LMI
2442 * callint.c (Fcall_interactively): Change "reading args" to
2443 "providing args" to try to clarify what it does (bug#1010).
2444
15fa4783
KH
24452011-07-07 Kenichi Handa <handa@m17n.org>
2446
2447 * composite.c (composition_compute_stop_pos): Ignore a static
2448 composition starting before CHARPOS (Bug#8915).
2449
2450 * xdisp.c (handle_composition_prop): Likewise.
2451
a8815b00
EZ
24522011-07-07 Eli Zaretskii <eliz@gnu.org>
2453
2454 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2455 (Bug#9015)
2456
ef7b981d 24572011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2458
2459 * character.h (unicode_category_t): New enum type.
2460
2461 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2462 (Qchar_code_property_table): New variable.
2463 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2464 (UNIPROP_COMPRESSED_FORM_P): New macros.
2465 (char_table_ascii): Uncompress the compressed values.
2466 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2467 Uncompress the compressed values.
ac389d0c 2468 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2469 (char_table_ref_and_range): Uncompress the compressed values.
2470 (sub_char_table_set): New arg is_uniprop. Callers changed.
2471 Uncompress the compressed values.
2472 (sub_char_table_set_range): Args changed. Callers changed.
2473 (char_table_set_range): Adjuted for the above change.
2474 (map_sub_char_table): Delete args default_val and parent. Add arg
2475 top. Give decoded values to a Lisp function.
640c8776 2476 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2477 values to a Lisp function. Gcpro more variables.
2478 (uniprop_table_uncompress)
2479 (uniprop_decode_value_run_length): New functions.
2480 (uniprop_decoder, uniprop_decoder_count): New variables.
2481 (uniprop_get_decoder, uniprop_encode_value_character)
2482 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2483 New functions.
2484 (uniprop_encoder, uniprop_encoder_count): New variables.
2485 (uniprop_get_encoder, uniprop_table)
2486 (Funicode_property_table_internal, Fget_unicode_property_internal)
2487 (Fput_unicode_property_internal): New functions.
2488 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2489 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2490 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2491 char-code-property-alist.
2492
640c8776 2493 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2494 Vunicode_category_table.
2495
640c8776 2496 * font.c (font_range): Adjust for the change of
c805dec0
KH
2497 Vunicode_category_table.
2498
76b397fb
DN
24992011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2500
2501 * m/iris4d.h: Remove file, move contents ...
2502 * s/irix6-5.h: ... here.
2503
22b4128e
PE
25042011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2507 * alloc.c (mark_buffer):
2508 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2509 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2510 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2511 This isn't true in general, and it's particularly not true
2512 if Emacs is configured with --with-wide-int.
2513 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2514 New macros, used in the buffer.c change.
2515
869795d6
JD
25162011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * xsettings.c: Use both GConf and GSettings if both are available.
2519 (store_config_changed_event): Add comment.
2520 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2521 (store_tool_bar_style_changed): New functions.
5e617bc2 2522 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2523 (struct xsettings): Move font inside HAVE_XFT.
2524 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2525 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2526 Move inside HAVE_XFT.
640c8776 2527 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2528 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2529 also.
2530 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2531 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2532 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2533 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2534 (parse_settings): Move check for font inside HAVE_XFT.
2535 (read_settings, apply_xft_settings): Add comment.
2536 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2537 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2538 call store_font_name_changed.
2539 (xft_settings_event): Add comment.
2540 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2541 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2542 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2543 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2544 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2545 (xsettings_get_system_font, xsettings_get_system_normal_font):
2546 Add comment.
869795d6 2547
d8ed26bd
PE
25482011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Random fixes. E.g., (random) never returned negative values.
2551 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2552 subseconds part to the entropy, as that's a bit more random.
2553 Prefer signed to unsigned, since the signedness doesn't matter and
2554 in general we prefer signed. When given a limit, use a
2555 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2556 latter isn't right if USE_2_TAGS_FOR_INTS.
2557 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2558 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2559
cabf1cac
SM
25602011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2561
2562 * textprop.c (text_property_stickiness):
2563 Obey Vtext_property_default_nonsticky.
2564 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2565 * w32fns.c (syms_of_w32fns):
2566 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2567
6e9b2be9
PE
25682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2571 This is more efficient than Ffile_directory_p and avoids a minor race.
2572
90186c68
LMI
25732011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2574
7c301272
LMI
2575 * buffer.c (Foverlay_put): Say what the return value is
2576 (bug#7835).
2577
c4f2d8d4
LMI
2578 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2579 is a directory before asking whether to use the file name
2580 (bug#7564).
ad637907
LMI
2581 (barf_or_query_if_file_exists): Make the "File is a directory"
2582 error be more correct.
c4f2d8d4 2583
90186c68
LMI
2584 * fns.c (Frequire): Remove the mention of the .gz files, since
2585 that's installation-specific, but keep the mention of
2586 `get-load-suffixes'.
2587
da64016e
PE
25882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2591 Report string overflow if the output is too long.
2592
7d47b580
JB
25932011-07-04 Juanma Barranquero <lekktu@gmail.com>
2594
a555cb87
JB
2595 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2596 (syms_of_gnutls): Remove duplicate DEFSYM for
2597 Qgnutls_bootprop_verify_hostname_error, an error for
2598 Qgnutls_bootprop_verify_error (which is no longer used).
2599
7d47b580
JB
2600 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2601 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2602 Also (re)move comments that are misplaced or no longer relevant.
2603
1e49bfab
LMI
26042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2605
2606 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2607
1485f4c0
CY
26082011-07-03 Chong Yidong <cyd@stupidchicken.com>
2609
2610 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2611 and background color parameters if they have been changed.
2612
a9ab721e
LMI
26132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2614
2615 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2616
cf7cff57
PE
26172011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2618
2e13213d
PE
2619 * xsettings.c (SYSTEM_FONT): Define only when used.
2620 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2621
cf7cff57
PE
2622 * keymap.c (access_keymap_1): Now static.
2623
7a8e04f7
CY
26242011-07-02 Chong Yidong <cyd@stupidchicken.com>
2625
2626 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2627 leave any prefix arg for the up event (Bug#1586).
2628
61352f62
LMI
26292011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2630
69bb1ef7
LMI
2631 * lread.c (syms_of_lread): Mention single symbols defined by
2632 `defvar' or `defconst' (bug#7154).
2633
61352f62 2634 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2635 (Frequire): Mention get-load-suffixes.
61352f62 2636
28545e04
MR
26372011-07-02 Martin Rudalics <rudalics@gmx.at>
2638
2639 * window.h (window): Remove clone_number slot.
2640 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2641 Remove.
2642 (make_parent_window, make_window, saved_window)
2643 (Fset_window_configuration, save_window_save): Don't deal with
2644 clone numbers.
2645 * buffer.c (Qclone_number): Remove declaration.
2646 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2647
3349e122
SM
26482011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2649
2650 Add multiple inheritance to keymaps.
2651 * keymap.c (Fmake_composed_keymap): New function.
2652 (Fset_keymap_parent): Simplify.
2653 (fix_submap_inheritance): Remove.
2654 (access_keymap_1): New function extracted from access_keymap to handle
2655 embedded parents and handle lists of maps.
2656 (access_keymap): Use it.
2657 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2658 (Fcopy_keymap): Handle embedded parents.
2659 (Fcommand_remapping, define_as_prefix): Simplify.
2660 (Fkey_binding): Simplify.
2661 (syms_of_keymap): Move minibuffer-local-completion-map,
2662 minibuffer-local-filename-completion-map,
2663 minibuffer-local-must-match-map, and
2664 minibuffer-local-filename-must-match-map to Elisp.
2665 (syms_of_keymap): Defsubr make-composed-keymap.
2666 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2667 (parse_menu_item): Trivial simplification.
2668
3279eb87
GM
26692011-07-01 Glenn Morris <rgm@gnu.org>
2670
2671 * Makefile.in (SETTINGS_LIBS): Fix typo.
2672
4550efdf
KI
26732011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2674
2675 * coding.c (Fencode_coding_string): Record the last coding system
2676 used, as the function doc string says (bug#8738).
2677
0949d2b6
JD
26782011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2679
2680 * xsettings.c (store_monospaced_changed): Take new font as arg and
2681 check for change against current_mono_font.
2682 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2683 (emacs_settings_constructor, emacs_settings_get_property)
2684 (emacs_settings_set_property, emacs_settings_class_init)
2685 (emacs_settings_init, gsettings_obj): Remove.
2686 (something_changedCB): New function for HAVE_GSETTINGS.
2687 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2688 with value as argument.
2689 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2690 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2691 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2692 "changed".
2693
2694 * xgselect.c: Add defined (HAVE_GSETTINGS).
2695 (xgselect_initialize): Ditto.
2696
2697 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2698 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2699 xg_select.
2700
bbc6b304
PE
27012011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * eval.c (struct backtrace): Simplify and port the data structure.
2704 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2705 signed bit field, as this assumption is not portable and it makes
2706 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2707 "char debug_on_exit : 1" as this is not portable either; instead,
2708 use the portable "unsigned int debug_on_exit : 1". Remove unused
2709 member evalargs. Remove obsolete comments about cc bombing out.
2710
9851bfc5
JD
27112011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2712
51bb811f 2713 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2714 Let HAVE_GSETTINGS override HAVE_GCONF.
2715 (store_monospaced_changed): New function.
2716 (EMACS_SETTINGS): A new type derived from GObject to handle
2717 GSettings notifications.
2718 (emacs_settings_constructor, emacs_settings_get_property)
2719 (emacs_settings_set_property, emacs_settings_class_init):
2720 New functions.
2721 (gsettings_client, gsettings_obj): New variables.
2722 (GSETTINGS_SCHEMA): New define.
2723 (something_changedCB): Call store_monospaced_changed.
2724 (init_gsettings): New function.
2725 (xsettings_initialize): Call init_gsettings.
2726 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2727 to NULL.
2728
640c8776 2729 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2730 GCONF_CFLAGS/LIBS.
2731
5386012d
MR
27322011-06-29 Martin Rudalics <rudalics@gmx.at>
2733
2734 * window.c (resize_root_window, grow_mini_window)
2735 (shrink_mini_window): Rename Qresize_root_window to
2736 Qwindow_resize_root_window and Qresize_root_window_vertically to
2737 Qwindow_resize_root_window_vertically.
2738
f13e0b08
PE
27392011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2740
2741 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2742
94515237
JB
27432011-06-27 Juanma Barranquero <lekktu@gmail.com>
2744
2745 * makefile.w32-in: Redesign dependencies so they reflect more
2746 clearly which files are directly included by each source file,
2747 and not through other includes.
2748
e43b6e43
MR
27492011-06-27 Martin Rudalics <rudalics@gmx.at>
2750
2751 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2752 (sort_overlays, overlay_strings): When an overlay's clone number
2753 matches the window's clone number process the overlay even if
2754 the overlay's window property doesn't match the current window.
2755
d68443dc
MR
2756 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2757 (Fwindow_hchild): Rename to Fwindow_left_child.
2758 (Fwindow_next): Rename to Fwindow_next_sibling.
2759 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2760 (resize_window_check): Rename to window_resize_check.
2761 (resize_window_apply): Rename to window_resize_apply.
2762 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2763 (Fdelete_other_windows_internal, resize_frame_windows)
2764 (Fsplit_window_internal, Fdelete_window_internal)
2765 (grow_mini_window, shrink_mini_window)
2766 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2767
c7e73be5
JD
27682011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2769
2770 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2771 (emacs_fixed_set_min_size): Remove.
2772 (emacs_fixed_new): Take frame as argument.
2773
2774 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2775 (_EmacsFixedPrivate): Remove minwidth/height.
2776 Add struct frame *f.
2777 (emacs_fixed_init): Initialize priv->f.
2778 (get_parent_class, emacs_fixed_set_min_size): Remove.
2779 (emacs_fixed_new): Set priv->f to argument.
2780 (emacs_fixed_get_preferred_width)
2781 (emacs_fixed_get_preferred_height): Use min_width/height from
2782 frames size_hint to set minimum and natural (Bug#8919).
2783 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2784 and use min_width/height from frames size_hint to set
2785 min_width/height (Bug#8919).
2786
2787 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2788 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2789 Fix indentation.
c7e73be5 2790
cf99dcf8
EZ
27912011-06-26 Eli Zaretskii <eliz@gnu.org>
2792
2793 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2794 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2795 called at ZV.
2796
029529ac
CY
27972011-06-26 Chong Yidong <cyd@stupidchicken.com>
2798
2799 * process.c (wait_reading_process_output): Bypass select if
2800 waiting for a cell while ignoring keyboard input, and input is
2801 pending. Suggested by Jan Djärv (Bug#8869).
2802
7a7ef429
PE
28032011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Use gnulib's dup2 module instead of rolling our own.
2806 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2807
11fdef7d 28082011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2809
2810 * dispnew.c (scrolling_window): Before scrolling, turn off a
2811 mouse-highlight in the window being scrolled.
2812
cd3520a4
JB
28132011-06-24 Juanma Barranquero <lekktu@gmail.com>
2814
2815 Move DEFSYM to lisp.h and use everywhere.
2816
2817 * character.h (DEFSYM): Move declaration...
2818 * lisp.h (DEFSYM): ...here.
2819
2820 * gnutls.c:
2821 * minibuf.c:
2822 * w32menu.c:
2823 * w32proc.c:
2824 * w32select.c: Don't include character.h.
2825
2826 * alloc.c (syms_of_alloc):
2827 * buffer.c (syms_of_buffer):
2828 * bytecode.c (syms_of_bytecode):
2829 * callint.c (syms_of_callint):
2830 * casefiddle.c (syms_of_casefiddle):
2831 * casetab.c (init_casetab_once):
2832 * category.c (init_category_once, syms_of_category):
2833 * ccl.c (syms_of_ccl):
2834 * cmds.c (syms_of_cmds):
2835 * composite.c (syms_of_composite):
2836 * dbusbind.c (syms_of_dbusbind):
2837 * dired.c (syms_of_dired):
2838 * dispnew.c (syms_of_display):
2839 * doc.c (syms_of_doc):
2840 * editfns.c (syms_of_editfns):
2841 * emacs.c (syms_of_emacs):
2842 * eval.c (syms_of_eval):
2843 * fileio.c (syms_of_fileio):
2844 * fns.c (syms_of_fns):
2845 * frame.c (syms_of_frame):
2846 * fringe.c (syms_of_fringe):
2847 * insdel.c (syms_of_insdel):
2848 * keymap.c (syms_of_keymap):
2849 * lread.c (init_obarray, syms_of_lread):
2850 * macros.c (syms_of_macros):
2851 * msdos.c (syms_of_msdos):
2852 * print.c (syms_of_print):
2853 * process.c (syms_of_process):
2854 * search.c (syms_of_search):
2855 * sound.c (syms_of_sound):
2856 * syntax.c (init_syntax_once, syms_of_syntax):
2857 * terminal.c (syms_of_terminal):
2858 * textprop.c (syms_of_textprop):
2859 * undo.c (syms_of_undo):
2860 * w32.c (globals_of_w32):
2861 * window.c (syms_of_window):
2862 * xdisp.c (syms_of_xdisp):
2863 * xfaces.c (syms_of_xfaces):
2864 * xfns.c (syms_of_xfns):
2865 * xmenu.c (syms_of_xmenu):
2866 * xsettings.c (syms_of_xsettings):
2867 * xterm.c (syms_of_xterm): Use DEFSYM.
2868
4228cf16
TZ
28692011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2870
cd3520a4 2871 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2872
7fcccf1e
PE
28732011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2874
7efb4e0e
PE
2875 Integer and buffer overflow fixes (Bug#8873).
2876
ff5844ad
PE
2877 * print.c (printchar, strout): Check for string overflow.
2878 (PRINTPREPARE, printchar, strout):
2879 Don't set size unless allocation succeeds.
2880
90532f02
PE
2881 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2882 for sizes. Check for string overflow more accurately.
2883 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2884
6d84508d
PE
2885 * macros.c: Integer and buffer overflow fixes.
2886 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2887 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2888 Use ptrdiff_t, not int, for sizes.
2889 Don't increment bufsize until after realloc succeeds.
2890 Check for size-calculation overflow.
2891 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2892
437b2cb4
PE
2893 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2894
8b9ac8b4
PE
2895 * lread.c: Integer overflow fixes.
2896 (read_integer): Radix is now EMACS_INT, not int,
2897 to improve quality of diagnostics for out-of-range radices.
2898 Calculate buffer size correctly for out-of-range radices.
2899 (read1): Check for integer overflow in radices, and in
2900 read-circle numbers.
82cb60d3
PE
2901 (read_escape): Avoid int overflow.
2902 (Fload, openp, read_buffer_size, read1)
2903 (substitute_object_recurse, read_vector, read_list, map_obarray):
2904 Use ptrdiff_t, not int, for sizes.
2905 (read1): Use EMACS_INT, not int, for sizes.
20270765 2906 Check for size overflow.
8b9ac8b4 2907
7fcccf1e
PE
2908 * image.c (cache_image): Check for size arithmetic overflow.
2909
bfbbd7e7
PE
2910 * lread.c: Integer overflow issues.
2911 (saved_doc_string_size, saved_doc_string_length)
2912 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2913 Now ptrdiff_t, not int.
2914 (read1): Don't assume doc string length fits in int. Check for
2915 out-of-range doc string lengths.
2916 (read_list): Don't assume file position fits in int.
39019e54 2917 (read_escape): Check for hex character overflow.
bfbbd7e7 2918
4e323265
LL
29192011-06-22 Leo Liu <sdl.web@gmail.com>
2920
2921 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2922 Move to minibuffer.el.
2923
85fece3e
PE
29242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2925
20b84ce9 2926 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2927 The following patches are for when GLYPH_DEBUG && !XASSERT.
2928 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2929 * dispnew.c (flush_stdout):
2930 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2931 Mark as externally visible.
2932 * dispnew.c (check_window_matrix_pointers): Now static.
2933 * dispnew.c (window_to_frame_vpos):
2934 * xfns.c (unwind_create_frame):
2935 * xterm.c (x_check_font): Remove unused local.
2936 * scroll.c (CHECK_BOUNDS):
2937 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2938 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2939 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2940 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2941 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2942 Now static.
2943 (debug_method_add): Use va_list and vsprintf rather than relying
2944 on undefined behavior with wrong number of arguments.
2945 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2946 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2947 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2948 since we're not interested in debugging glyphs with old libraries.
2949 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2950 GCC 4.6.0's static checking.
2951
0766b489
PE
29522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2953
31fd4b32
PE
2954 Integer overflow and signedness fixes (Bug#8873).
2955 A few related buffer overrun fixes, too.
2956
b79e8648
PE
2957 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2958
0766b489
PE
2959 * dispextern.h (struct face.stipple):
2960 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2961 (x_bitmap_mask, x_allocate_bitmap_record)
2962 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2963 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2964 (x_create_bitmap_from_xpm_data):
2965 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2966 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2967 (.bitmaps_last):
2968 * xfaces.c (load_pixmap):
2969 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2970 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2971 (.bitmaps_last, struct x_output.icon_bitmap):
2972 Use ptrdiff_t, not int, for bitmap indexes.
2973 (x_allocate_bitmap_record): Check for size overflow.
2974 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2975
b081724f
PE
2976 Use ptrdiff_t, not int, for overlay counts.
2977 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2978 * editfns.c (overlays_around, get_pos_property):
2979 * textprop.c (get_char_property_and_overlay):
2980 * xdisp.c (next_overlay_change, note_mouse_highlight):
2981 * xfaces.c (face_at_buffer_position):
21514da7
PE
2982 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2983 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2984 (Fnext_overlay_change, Fprevious_overlay_change)
2985 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2986 Use ptrdiff_t, not int, for sizes.
21514da7 2987 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2988
3de73e5e
PE
2989 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2990
2606c57b
PE
2991 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2992 (x_session_initialize): Do not assume string length fits in int.
2993
aaafe47a
PE
2994 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2995 This is unlikely, but can occur if DPI is outlandish.
2996
2674ddc8 2997 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2998 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2999
28154962
PE
3000 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3001 * xrdb.c (magic_file_p, search_magic_path):
3002 Omit last arg SUFFIX; it was always 0. All callers changed.
3003 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3004
7de51af5
PE
3005 * xfont.c (xfont_match): Avoid need for strlen.
3006
25ed6cc3
PE
3007 * xfns.c: Don't assume strlen fits in int.
3008 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3009
4eab31dd
PE
3010 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3011 not unsigned long, as we prefer signed integers. All callers changed.
3012 Detect integer overflow in repeat count.
3013 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3014 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3015
171e2a58
PE
3016 * termcap.c: Don't assume sizes fit in int and never overflow.
3017 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3018 (gobble_line): Check for size-calculation overflow.
3019
ad39faca 3020 * minibuf.c (Fread_buffer):
6e5bb2dc 3021 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3022 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3023 Don't assume string length fits in int.
3024
52c61c22 3025 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3026 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3027
b5b8c9e5
PE
3028 * font.c: Don't assume string length fits in int.
3029 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3030 Use ptrdiff_t, not int.
ccd6111c
PE
3031 (font_intern_prop): Don't assume string length fits in int.
3032 Don't assume integer property fits in fixnum.
3033 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3034
882f0d81 3035 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3036 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3037 Reformulate so as not to need the command string.
3038 Invoke gzip -cd rather than gunzip, as it's more portable.
3039 (lock_info_type, lock_file_1, lock_file):
3040 Don't assume pid_t and time_t fit in unsigned long.
3041 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3042 (current_lock_owner): Prefer signed type for sizes.
3043 Use memcpy, not strncpy, where memcpy is what is really wanted.
3044 Don't assume (via atoi) that time_t and pid_t fit in int.
3045 Check for time_t and/or pid_t out of range, e.g., via a network share.
3046 Don't alloca where an auto var works fine.
3047
93f4cf88
PE
3048 * fileio.c: Fix some integer overflow issues.
3049 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3050 Don't assume string length fits in int.
3051 (directory_file_name): Don't assume string length fits in long.
3052 (make_temp_name): Don't assume pid fits in int, or that its print
3053 length is less than 20.
3054
f3e92b69
PE
3055 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3056
1bfdaf10
PE
3057 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3058
35016e9a
PE
3059 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3060
3d1e65a1
PE
3061 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3062 We prefer signed integers, even for size calculations.
3063
0b963a93
PE
3064 * emacs.c: Don't assume string length fits in 'int'.
3065 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3066 (main): Don't invoke strlen when not needed.
3067
573f4b54
PE
3068 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3069 (XD_DEBUG_MESSAGE): Don't waste a byte.
3070
989f33ba
PE
3071 * callproc.c (getenv_internal_1, getenv_internal)
3072 (Fgetenv_internal):
965d34eb
PE
3073 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3074
e4d29b33
PE
3075 * lread.c (invalid_syntax): Omit length argument.
3076 All uses changed. This doesn't fix a bug, but it simplifies the
3077 code away from its former Hollerith-constant appearance, and it's
3078 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3079 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3080
eb49b136
PE
3081 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3082 This didn't break anything, but it didn't help either.
3083 It's confusing to put a bogus integer in a place where the actual
3084 value does not matter.
9f62aeb1 3085 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3086 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3087
15375a22
PE
3088 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3089 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3090 implementation.
b61cc01c
PE
3091 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3092 We prefer signed types, and the value cannot exceed the EMACS_INT
3093 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3094 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3095 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3096 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3097
53b2623d
PE
3098 * indent.c (sane_tab_width): New function.
3099 (current_column, scan_for_column, Findent_to, position_indentation)
3100 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3101 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3102
51cab52b 3103 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3104
f2ed8a70
PE
3105 * lisp.h (lint_assume): New macro.
3106 * composite.c (composition_gstring_put_cache):
3107 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3108
abe80cc6
PE
3109 * editfns.c, insdel.c:
3110 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3111
b02c740e
PE
3112 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3113
ebc96716
PE
3114 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3115
b4e50fa0 3116 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3117 Use much-faster test for byte-length change.
311d5d7c 3118 Don't assume string byte-length fits in 'int'.
a4cf38e4 3119 Check that character arg fits in 'int'.
85461888 3120 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3121
c0c1ee9f
PE
3122 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3123
a498d7f4
PE
3124 * fns.c (concat): Catch string overflow earlier.
3125 Do not rely on integer wraparound.
3126
51cab52b
PE
3127 * dispextern.h (struct it.overlay_strings_charpos)
3128 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3129 * xdisp.c (forward_to_next_line_start)
3130 (back_to_previous_visible_line_start)
3131 (reseat_at_next_visible_line_start, next_element_from_buffer):
3132 Don't arbitrarily truncate the value of 'selective' to int.
3133
76031fad
PE
3134 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3135
5eb55db9
PE
3136 * composite.c: Don't truncate sizes to 'int'.
3137 (composition_gstring_p, composition_reseat_it)
3138 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3139 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3140 not EMACS_UINT, for indexes.
5eb55db9 3141
0703a717
PE
3142 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3143
d6202519
PE
3144 * buffer.c: Include <verify.h>.
3145 (struct sortvec.priority, struct sortstr.priority):
8961a454 3146 Now EMACS_INT, not int.
c20998a7 3147 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3148 (struct sortstr.size, record_overlay_string)
3149 (struct sortstrlist.size, struct sortlist.used):
3150 Don't truncate size to int.
3151 (record_overlay_string): Check for size-calculation overflow.
d6202519 3152 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3153
d5a19415
JM
31542011-06-22 Jim Meyering <meyering@redhat.com>
3155
029529ac 3156 Don't leak an XBM-image-sized buffer
d5a19415
JM
3157 * image.c (xbm_load): Free the image buffer after using it.
3158
a9041e6c
PE
31592011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3160
3161 Port to Sun C.
3162 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3163 that Sun C diagnosed.
3164 * fns.c (secure_hash): Fix pointer signedness issue.
3165 * intervals.c (static_offset_intervals): New function.
3166 (offset_intervals): Use it.
3167
7f3f739f
LL
31682011-06-21 Leo Liu <sdl.web@gmail.com>
3169
3170 * deps.mk (fns.o):
3171 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3172 sha512.h.
3173
3174 * fns.c (secure_hash): Rename from crypto_hash_function and change
3175 the first arg to accept symbols.
5b66d427 3176 (Fsecure_hash): New primitive.
7f3f739f
LL
3177 (syms_of_fns): New symbols.
3178
76147d94
DD
31792011-06-20 Deniz Dogan <deniz@dogan.se>
3180
3181 * process.c (Fset_process_buffer): Clarify return value in
3182 docstring.
3183
7d7d0045
CY
31842011-06-18 Chong Yidong <cyd@stupidchicken.com>
3185
3186 * dispnew.c (add_window_display_history): Use BVAR.
3187
3188 * xdisp.c (debug_method_add): Use BVAR.
3189 (check_window_end, dump_glyph_matrix, dump_glyph)
3190 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3191
3192 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3193 Likewise.
3194
3195 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3196 check till after the cache is created in init_frame_faces.
3197
ff2bc410
SM
31982011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3199
3200 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3201
28177add
PE
32022011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3203
dd3482fe
PE
3204 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3205 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3206 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3207
393d71f3 3208 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3209 * fileio.c (Finsert_file_contents):
3210 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3211 Remove the old (too-loose) buffer overflow checks.
3212 They weren't needed, since make_gap checks for buffer overflow.
3213 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3214 The old code merely checked for Emacs fixnum overflow, and relied
3215 on undefined (wraparound) behavior. The new code avoids undefined
3216 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3217
2e6813b0 3218 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3219 Tune. Don't use wider integers than needed. Don't use alloca.
3220 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3221
599a9e4f
PE
3222 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3223
99561444
PE
3224 * insdel.c, lisp.h (buffer_overflow): New function.
3225 (insert_from_buffer_1, replace_range, replace_range_2):
3226 * insdel.c (make_gap_larger):
3227 * editfns.c (Finsert_char):
3228 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3229
28177add
PE
3230 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3231
e69dafad
PE
32322011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3233
a7af7fde 3234 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3235
b1c46f02
PE
3236 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3237 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3238
e69dafad
PE
3239 * fileio.c: Don't assume EMACS_INT fits in off_t.
3240 (emacs_lseek): New static function.
3241 (Finsert_file_contents, Fwrite_region): Use it.
3242 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3243
566684ea
PE
3244 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3245
e6966cd6
PE
3246 * fns.c: Don't overflow int when computing a list length.
3247 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3248 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3249 truncation on 64-bit hosts. Check for QUIT every
3250 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3251 faster and is responsive enough.
3252 (Flength): Report an error instead of overflowing an integer.
3253 (Fsafe_length): Return a float if the value is not representable
3254 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3255 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3256 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3257
dd0b0efb
PE
3258 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3259 (header_size, word_size): New constants.
3260 (allocate_vectorlike): Don't check size overflow here.
3261 (allocate_vector): Check it here instead, since this is the only
3262 caller of allocate_vectorlike that could cause overflow.
3263 Check that the new vector's length is representable as a fixnum.
3264
86fe5cfe
PE
3265 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3266 The previous code was bogus. For example, next_almost_prime (32)
3267 returned 39, which is undesirable as it is a multiple of 3; and
3268 next_almost_prime (24) returned 25, which is a multiple of 5 so
3269 why was the code bothering to check for multiples of 7?
3270
80e88859
PE
3271 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3272
4a2f0ad6
PE
3273 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3274
f66c7cf8
PE
3275 Variadic C functions now count arguments with ptrdiff_t.
3276 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3277 Back then I didn't know that the Emacs coding style prefers signed int.
3278 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3279 were being counted with int, which may truncate counts on 64-bit
3280 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3281 * lisp.h (struct Lisp_Subr.function.aMANY)
3282 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3283 Arg counts are now ptrdiff_t, not size_t.
3284 All variadic functions and their callers changed accordingly.
3285 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3286 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3287 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3288 * callint.c (Fcall_interactively): Check arg count for overflow,
3289 to avoid potential buffer overrun. Use signed char, not 'int',
3290 for 'varies' array, so that we needn't bother to check its size
3291 calculation for overflow.
3292 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3293 * eval.c (apply_lambda):
3294 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3295 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3296 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3297
a1759b76
PE
3298 * callint.c (Fcall_interactively): Don't use index var as event count.
3299
d96be9fc
PE
3300 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3301 * mem-limits.h (SIZE): Remove; no longer used.
3302
a690a978 3303 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3304
578c21e6
PE
3305 Remove unnecessary casts.
3306 * xterm.c (x_term_init):
3307 * xfns.c (x_set_border_pixel):
3308 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3309 These aren't needed now that we assume ANSI C.
3310
96f53c6c
PE
3311 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3312 It's more likely to cause problems (due to unsigned overflow)
3313 than to cure them.
3314
83c77d31
PE
3315 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3316
ee2079f1
PE
3317 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3318
6da65536
PE
3319 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3320
7147c4a4
PE
3321 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3322
193e32d9
PE
3323 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3324
e5533da6
PE
3325 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3326
9910e595
PE
3327 GLYPH_CODE_FACE returns EMACS_INT, not int.
3328 * dispextern.h (merge_faces):
3329 * xfaces.c (merge_faces):
01103c44
PE
3330 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3331 Don't assume EMACS_INT fits in int.
9910e595 3332
2638320e
PE
3333 * character.h (CHAR_VALID_P): Remove unused parameter.
3334 * fontset.c, lisp.h, xdisp.c: All uses changed.
3335
045eb8d9
PE
3336 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3337
c1f134b5
PE
3338 * fns.c (concat): Minor tuning based on overflow analysis.
3339 This doesn't fix any bugs. Use int to hold character, instead
3340 of constantly refetching from Emacs object. Use XFASTINT, not
3341 XINT, for value known to be a character. Don't bother comparing
3342 a single byte to 0400, as it's always less.
3343
395fcb93 3344 * floatfns.c (Fexpt):
327eeec8
PE
3345 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3346
abbd3d23
PE
3347 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3348 for characters.
3349
684a03ef
PE
3350 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3351
0fed43f3
PE
3352 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3353 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3354 incorrectly succeed when S was a string, because 4294967386 was
3355 truncated before it was used.
3356
8fd02eb7
PE
3357 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3358 Otherwise, an out-of-range integer could cause undefined behavior
3359 on a 64-bit host.
3360
f8c86b69
PE
3361 * composite.c: Use int, not EMACS_INT, for characters.
3362 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3363 EMACS_INT, for values that are known to be in character range.
3364 This doesn't fix any bugs but is the usual style inside Emacs and
3365 may generate better code on 32-bit machines.
3366
34206dd2
PE
3367 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3368 This is for reasons similar to the recent CHAR_STRING fix.
3369 * charset.c (Fencode_char): Check that character arg is actually
3370 a character. Pass an int to ENCODE_CHAR.
3371 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3372 wider than 'int', as a compile-time check to prevent future regressions
3373 in this area.
3374
c5958d4c 3375 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3376
3377 Make sure a 64-bit char is never passed to CHAR_STRING.
3378 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3379 by silently ignoring the top 32 bits, allowing some values
3380 that were far too large to be valid characters.
3381 * character.h: Include <verify.h>.
3382 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3383 arguments are no wider than unsigned, as a compile-time check
3384 to prevent future regressions in this area.
3385 * data.c (Faset):
01103c44 3386 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3387 (Fsubst_char_in_region):
3388 * fns.c (concat):
3389 * xdisp.c (decode_mode_spec_coding):
3390 Adjust to CHAR_STRING's new requirement.
3391 * editfns.c (Finsert_char, Fsubst_char_in_region):
3392 * fns.c (concat): Check that character args are actually
3393 characters. Without this test, these functions did the wrong
3394 thing with wildly out-of-range values on 64-bit hosts.
3395
d37ca623
PE
3396 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3397 These casts should not be needed on 32-bit hosts, either.
3398 * keyboard.c (read_char):
3399 * lread.c (Fload): Remove casts to unsigned.
3400
ea204efb
PE
3401 * lisp.h (UNSIGNED_CMP): New macro.
3402 This fixes comparison bugs on 64-bit hosts.
3403 (ASCII_CHAR_P): Use it.
3404 * casefiddle.c (casify_object):
01103c44 3405 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3406 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3407 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3408 * dispextern.h (FACE_FROM_ID):
3409 * keyboard.c (read_char): Use UNSIGNED_CMP.
3410
41cb286c
PE
3411 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3412 not to EMACS_INT, to avoid GCC warning.
3413
4a1b9832
PE
3414 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3415
55daad71
PE
3416 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3417 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3418 isn't needed on 32-bit machines.
8f95c75c 3419
01103c44
PE
3420 * buffer.c (Fgenerate_new_buffer_name):
3421 Use EMACS_INT for count, not int.
0ceccced 3422 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3423
3424 * data.c (Qcompiled_function): Now static.
3425
c6f072e7
PE
3426 * window.c (window_body_lines): Now static.
3427
20ce5912
PE
3428 * image.c (gif_load): Rename local to avoid shadowing.
3429
9c4c5f81
PE
3430 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3431 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3432 * alloc.c (make_save_value): Integer argument is now of type
3433 ptrdiff_t, not int.
3434 (mark_object): Use ptrdiff_t, not int.
3435 * lisp.h (pD): New macro.
3436 * print.c (print_object): Use it.
3437
c0c5c8ae
PE
3438 * alloc.c: Use EMACS_INT, not int, to count objects.
3439 (total_conses, total_markers, total_symbols, total_vector_size)
3440 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3441 (total_free_floats, total_floats, total_free_intervals)
3442 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3443 Now EMACS_INT, not int. All uses changed.
3444 (Fgarbage_collect): Compute overall total using a double, so that
3445 integer overflow is less likely to be a problem. Check for overflow
3446 when converting back to an integer.
5a25e253
PE
3447 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3448 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3449 These were 'int' variables that could overflow on 64-bit hosts;
3450 they were never used, so remove them instead of repairing them.
211a0b2a 3451 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3452 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3453 Previously, this ceilinged at INT_MAX, but that doesn't work on
3454 64-bit machines.
e46bb31a 3455 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3456
c78baabf 3457 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3458 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3459 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3460 when a (possibly-narrower) signed value would do just as well.
3461 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3462
c9d624c6
PE
3463 * alloc.c: Catch some string size overflows that we were missing.
3464 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3465 for convenience in STRING_BYTES_MAX.
3466 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3467 The definition here is exact; the one in lisp.h was approximate.
3468 (allocate_string_data): Check for string overflow. This catches
3469 some instances we weren't catching before. Also, it catches
3470 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3471 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3472 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3473
c9d624c6
PE
3474 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3475 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3476 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3477
353032ce
PE
3478 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3479
2bccce07
PE
3480 * alloc.c (Fmake_string): Check for out-of-range init.
3481
0ac30604
SM
34822011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3483
3484 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3485
c195f2de
JD
34862011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3487
3488 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3489 xg_get_default_scrollbar_width.
3490
3491 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3492 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3493 (style_changed_cb): Call update_theme_scrollbar_width and call
3494 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3495 all frames (Bug#8505).
3496 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3497 Call gtk_window_set_resizable if HAVE_GTK3.
3498 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3499 and height if HAVE_GTK3 (Bug#8505).
3500 (scroll_bar_width_for_theme): New variable.
3501 (update_theme_scrollbar_width): New function.
3502 (xg_get_default_scrollbar_width): Move code to
3503 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3504 (xg_initialize): Call update_theme_scrollbar_width.
3505
3506 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3507
3508 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3509
e10ac9f1
MR
35102011-06-12 Martin Rudalics <rudalics@gmx.at>
3511
3512 * frame.c (make_frame): Call other_buffer_safely instead of
3513 other_buffer.
3514
3515 * window.c (temp_output_buffer_show): Call display_buffer with
3516 second argument Vtemp_buffer_show_specifiers and reset latter
3517 immediately after the call.
3518 (Vtemp_buffer_show_specifiers): New variable.
3519 (auto_window_vscroll_p, next_screen_context_lines)
3520 (Vscroll_preserve_screen_position): Remove leading asterisks from
3521 doc-strings.
3522
2d3c217e 35232011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3524
7b7f97e8 3525 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3526 * buffer.c (Qclone_number): Remove for now, as it's unused.
3527 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3528 (record_buffer): Remove unused local.
3529 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3530 (set_frame_buffer_list): Remove; unused.
3531 * frame.h (other_visible_frames): Remove decl.
3532 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3533 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3534 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3535 if HAVE_GPM.
3536 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3537 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3538 Define only if HAVE_GPM.
3539 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3540 (update_hints_inhibit): Remove; never set. All uses removed.
3541 * widgetprv.h (emacsFrameClassRec): Remove decl.
3542 * window.c (delete_deletable_window): Now returns void, since it
3543 wasn't returning anything.
3544 (compare_window_configurations): Remove unused locals.
3545 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3546 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3547 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3548 the same widths as pointers. This follows up on the 2011-05-06 patch.
3549 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3550 * xterm.h: Likewise.
3551 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3552
1384b89e
JB
35532011-06-12 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * makefile.w32-in: Update dependencies.
3556 (LISP_H): Add lib/intprops.h.
3557
1100a63c
CY
35582011-06-11 Chong Yidong <cyd@stupidchicken.com>
3559
3560 * image.c (gif_load): Add animation frame delay to the metadata.
3561 (syms_of_image): Use DEFSYM. New symbol `delay'.
3562
6198ccd0
MR
35632011-06-11 Martin Rudalics <rudalics@gmx.at>
3564
3565 * window.c (delete_deletable_window): Re-add.
3566 (Fset_window_configuration): Rewrite to handle dead buffers and
3567 consequently deletable windows.
3568 (window_tree, Fwindow_tree): Remove. Supply functionality in
3569 window.el.
3570 (compare_window_configurations): Simplify code.
3571
b6e3633c
AS
35722011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3573
1ab0dee5
AS
3574 * image.c (imagemagick_load_image): Fix type mismatch.
3575 (Fimagemagick_types): Likewise.
3576
b6e3633c
AS
3577 * window.h (replace_buffer_in_windows): Declare.
3578
9397e56f
MR
35792011-06-11 Martin Rudalics <rudalics@gmx.at>
3580
3581 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3582 Qclone_number. Remove external declaration of Qdelete_window.
3583 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3584 code.
640c8776
SM
3585 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3586 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3587 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3588 buffer list implementation.
3589 (other_buffer_safely): New function.
3590 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3591 calls to replace_buffer_in_windows and
3592 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3593 if allowed.
3594 (record_buffer): Inhibit quitting and rewrite using quittable
3595 functions. Run Qbuffer_list_update_hook if allowed.
3596 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3597 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3598 Move switch-to-buffer to window.el.
9397e56f
MR
3599 (bury-buffer): Move to window.el.
3600 (Vbuffer_list_update_hook): New variable.
3601
3602 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3603 section.
3604
3605 * window.h (resize_frame_windows): Move up in code.
3606 (Fwindow_frame): Remove EXFUN.
3607 (replace_buffer_in_all_windows): Remove prototype.
3608 (replace_buffer_in_windows_safely): Add prototype.
3609
3610 * window.c: Declare Qdelete_window static again. Move down
3611 declaration of select_count.
3612 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3613 (Fother_window): Move to window.el.
3614 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3615 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3616 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3617 window.el.
3618 (replace_buffer_in_windows): Implement by calling
3619 Qreplace_buffer_in_windows.
3620 (replace_buffer_in_all_windows): Remove with some functionality
3621 moved into replace_buffer_in_windows_safely.
3622 (replace_buffer_in_windows_safely): New function.
3623 (select_window_norecord, select_frame_norecord): Move in front
3624 of run_window_configuration_change_hook. Remove now obsolete
3625 declarations.
640c8776
SM
3626 (Fset_window_buffer): Rewrite doc-string.
3627 Call Qrecord_window_buffer.
9397e56f
MR
3628 (keys_of_window): Move binding for other-window to window.el.
3629
b50691aa
CY
36302011-06-11 Chong Yidong <cyd@stupidchicken.com>
3631
3632 * dispextern.h (struct image): Replace data member, whose int_val
3633 and ptr_val fields were not used by anything, with a single
3634 lisp_val object.
3635
3636 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3637 (gif_clear_image, gif_load, imagemagick_load_image)
3638 (gs_clear_image, gs_load): Callers changed.
3639
3f754b86
PE
36402011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3641
cca69397
PE
3642 * buffer.h: Include <time.h>, for time_t.
3643 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3644
109e28d0
PE
3645 Fix minor problems found by static checking.
3646
60737f02
PE
3647 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3648
4b66faf3
PE
3649 Make identifiers static if they are not used in other modules.
3650 * data.c (Qcompiled_function, Qframe, Qvector):
3651 * image.c (QimageMagick, Qsvg):
3652 * minibuf.c (Qmetadata):
3653 * window.c (resize_window_check, resize_root_window): Now static.
3654 * window.h (resize_window_check, resize_root_window): Remove decls.
3655
109e28d0
PE
3656 * window.c (window_deletion_count, delete_deletable_window):
3657 Remove; unused.
46a4ce9e
PE
3658 (window_body_lines): Now static.
3659 (Fdelete_other_windows_internal): Mark vars as initialized.
3660 Make sure 'resize_failed' is initialized.
3661 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3662 (resize_window_apply): Remove unused local.
3663 * window.h (delete_deletable_window): Remove decl.
3664
109e28d0 3665 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3666 (imagemagick_load_image): Fix pointer signedness problem by changing
3667 last arg from unsigned char * to char *. All uses changed.
3668 Also, fix a local for similar reasons.
3669 Remove unused locals. Remove locals to avoid shadowing.
3670 (fn_rsvg_handle_free): Remove; unused.
3671 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3672 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3673
3f754b86
PE
3674 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3675
2547adb1
CY
36762011-06-10 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * image.c (gif_load): Fix omitted cast error introduced by
3679 2011-06-06 change.
3680
2c8e37d4
MR
36812011-06-10 Martin Rudalics <rudalics@gmx.at>
3682
3683 * window.h (resize_proportionally, orig_total_lines)
3684 (orig_top_line): Remove from window structure.
3685 (set_window_height, set_window_width, change_window_heights)
3686 (Fdelete_window): Remove prototypes.
3687 (resize_frame_windows): Remove duplicate declaration.
3688
440a42e3
EZ
36892011-06-10 Eli Zaretskii <eliz@gnu.org>
3690
3691 * window.h (resize_frame_windows, resize_window_check)
3692 (delete_deletable_window, resize_root_window)
3693 (resize_frame_windows): Declare prototypes.
3694
3695 * window.c (resize_window_apply): Make definition be "static" to
3696 match the prototype.
3697
562dd5e9
MR
36982011-06-10 Martin Rudalics <rudalics@gmx.at>
3699
3700 * window.c: Remove declarations of Qwindow_size_fixed,
3701 window_min_size_1, window_min_size_2, window_min_size,
3702 size_window, window_fixed_size_p, enlarge_window, delete_window.
3703 Remove static from declaration of Qdelete_window, it's
3704 temporarily needed by Fbury_buffer.
3705 (replace_window): Don't assign orig_top_line and
3706 orig_total_lines.
3707 (Fdelete_window, delete_window): Remove. Window deletion is
3708 handled by window.el.
640c8776
SM
3709 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3710 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3711 (Fdelete_other_windows): Remove. Deleting other windows is
3712 handled by window.el.
3713 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3714 handled in window.el.
3715 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3716 Window minimum sizes are handled in window.el.
3717 (shrink_windows, size_window, set_window_height)
3718 (set_window_width, change_window_heights, window_height)
3719 (window_width, CURBEG, CURSIZE, enlarge_window)
3720 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3721 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3722 handled in window.el.
3723 (make_dummy_parent): Rename to make_parent_window and give it a
3724 second argument horflag.
3725 (make_window): Don't set resize_proportionally any more.
3726 (Fsplit_window): Remove. Windows are split in window.el.
3727 (save_restore_action, save_restore_orig_size)
3728 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3729 Resize mini windows in window.el.
3730 (grow_mini_window, shrink_mini_window): Implement by calling
3731 Qresize_root_window_vertically, resize_window_check and
3732 resize_window_apply.
640c8776
SM
3733 (saved_window, Fset_window_configuration, save_window_save):
3734 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3735 resize_proportionally.
3736 (window_min_height, window_min_width): Move to window.el.
3737 (keys_of_window): Move bindings for delete-other-windows,
3738 split-window, delete-window and enlarge-window to window.el.
3739
3740 * buffer.c: Temporarily extern Qdelete_window.
3741 (Fbury_buffer): Temporarily call Qdelete_window instead of
3742 Fdelete_window (Fbury_buffer will move to window.el soon).
3743
3744 * frame.c (set_menu_bar_lines_1): Remove code handling
3745 orig_top_line and orig_total_lines.
3746
3747 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3748 set_window_height but set heights directly.
3749 (change_frame_size_1): Use resize_frame_windows.
3750
3751 * xdisp.c (init_xdisp): Don't use set_window_height but set
3752 heights directly.
3753
640c8776
SM
3754 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3755 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3756 run_window_configuration_change_hook.
3757
3758 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3759 instead of change_window_heights and run
3760 run_window_configuration_change_hook.
3761
1a13852e
MR
37622011-06-09 Martin Rudalics <rudalics@gmx.at>
3763
3764 * window.c (replace_window): Rename second argument REPLACEMENT to
3765 NEW. New third argument SETFLAG. Rewrite.
3766 (delete_window, make_dummy_parent): Call replace_window with
3767 third argument 1.
3768 (window_list_1): Move down in code.
3769 (run_window_configuration_change_hook): Move set_buffer part
3770 before select_frame_norecord part in order to unwind correctly.
3771 Rename count1 to count.
3772 (recombine_windows, delete_deletable_window, resize_root_window)
3773 (Fdelete_other_windows_internal)
3774 (Frun_window_configuration_change_hook, make_parent_window)
3775 (resize_window_check, resize_window_apply, Fresize_window_apply)
3776 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3777 (Fdelete_window_internal, Fresize_mini_window_internal):
3778 New functions.
1a13852e
MR
3779 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3780
f3d1777e
MR
37812011-06-08 Martin Rudalics <rudalics@gmx.at>
3782
496e208e
MR
3783 * window.h (window): Add some new members to window structure -
3784 normal_lines, normal_cols, new_total, new_normal, clone_number,
3785 splits, nest, prev_buffers, next_buffers.
3786 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3787 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3788
f3d1777e
MR
3789 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3790 Remove.
496e208e
MR
3791 (make_dummy_parent): Set new members of windows structure.
3792 (make_window): Move down in code. Handle new members of window
3793 structure.
3794 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3795 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3796 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3797 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3798 (Fset_window_next_buffers, Fset_window_clone_number):
3799 New functions.
496e208e
MR
3800 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3801 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3802 Doc-string fixes.
3803 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3804 Argument WINDOW can be now internal window too.
3805 (Fwindow_use_time): Move up in code.
3806 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3807 Rewrite doc-string.
3808 (Fset_window_configuration, saved_window)
3809 (Fcurrent_window_configuration, save_window_save): Handle new
3810 members of window structure.
b9e809c2
MR
3811 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3812 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3813 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3814 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3815 Qget_mru_window, Qresize_root_window,
3816 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3817 Qauto_buffer_name; staticpro them.
f3d1777e 3818
abde8f8c
MR
38192011-06-07 Martin Rudalics <rudalics@gmx.at>
3820
3821 * window.c (Fwindow_total_size, Fwindow_left_column)
3822 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3823 (Fwindow_list_1): New functions.
3824 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3825 (Fwindow_width, Fscroll_left, Fscroll_right):
3826 Use window_body_cols instead of window_box_text_cols.
3827 (delete_window, Fset_window_configuration):
3828 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3829 (delete_all_subwindows): Take a window as argument and not a
3830 structure. Rewrite.
190b47e6
MR
3831 (window_loop): Remove handling of GET_LRU_WINDOW and
3832 GET_LARGEST_WINDOW.
3833 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3834
3835 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3836 window_box_text_cols. delete_all_subwindows now takes a
3837 Lisp_Object as argument.
abde8f8c 3838
640c8776
SM
3839 * indent.c (compute_motion, Fcompute_motion):
3840 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3841
fa8a67e6
MR
3842 * frame.c (delete_frame): Call delete_all_subwindows with root
3843 window as argument.
3844
a54e3482
DC
38452011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3846
3847 * fns.c (Fputhash): Document return value.
3848
60002bf5
CY
38492011-06-06 Chong Yidong <cyd@stupidchicken.com>
3850
3851 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3852
0c671da6 38532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3854
b862a52a 3855 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3856
be44ca6c
PE
3857 Check for overflow when converting integer to cons and back.
3858 * charset.c (Fdefine_charset_internal, Fdecode_char):
3859 Use cons_to_unsigned to catch overflow.
3860 (Fencode_char): Use INTEGER_TO_CONS.
3861 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3862 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3863 * data.c (long_to_cons, cons_to_long): Remove.
3864 (cons_to_unsigned, cons_to_signed): New functions.
3865 These signal an error for invalid or out-of-range values.
3866 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3867 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3868 * font.c (Ffont_variation_glyphs):
3869 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3870 * lisp.h: Include <intprops.h>.
3871 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3872 (cons_to_signed, cons_to_unsigned): New decls.
3873 (long_to_cons, cons_to_long): Remove decls.
3874 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3875 (Fprimitive_undo): Use CONS_TO_INTEGER.
3876 * xfns.c (Fx_window_property): Likewise.
3877 * xselect.c: Include <limits.h>.
3878 (x_own_selection, selection_data_to_lisp_data):
3879 Use INTEGER_TO_CONS.
3880 (x_handle_selection_request, x_handle_selection_clear)
3881 (x_get_foreign_selection, Fx_disown_selection_internal)
3882 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3883 (lisp_data_to_selection_data): Use cons_to_unsigned.
3884 (x_fill_property_data): Use cons_to_signed.
3885 Report values out of range.
3886
d1f3d2af
PE
3887 Check for buffer and string overflow more precisely.
3888 * buffer.h (BUF_BYTES_MAX): New macro.
3889 * lisp.h (STRING_BYTES_MAX): New macro.
3890 * alloc.c (Fmake_string):
3891 * character.c (string_escape_byte8):
3892 * coding.c (coding_alloc_by_realloc):
3893 * doprnt.c (doprnt):
3894 * editfns.c (Fformat):
3895 * eval.c (verror):
3896 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3897 since they may not be the same number.
3898 * editfns.c (Finsert_char):
3899 * fileio.c (Finsert_file_contents):
3900 Likewise for BUF_BYTES_MAX.
3901
dd52fcea
PE
3902 * image.c: Use ptrdiff_t, not int, for sizes.
3903 (slurp_file): Switch from int to ptrdiff_t.
3904 All uses changed.
3905 (slurp_file): Check that file size fits in both size_t (for
3906 malloc) and ptrdiff_t (for sanity and safety).
3907
7f9bbdbb
PE
3908 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3909 if b->modtime has its maximal value.
3910
dfe18f82
PE
3911 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3912
84acfcf0
PE
3913 Don't assume time_t can fit into int.
3914 * buffer.h (struct buffer.modtime): Now time_t, not int.
3915 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3916 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3917
ccd9a01a
PE
3918 Minor fixes for signed vs unsigned integers.
3919 * character.h (MAYBE_UNIFY_CHAR):
3920 * charset.c (maybe_unify_char):
3921 * keyboard.c (read_char, reorder_modifiers):
3922 XINT -> XFASTINT, since the integer must be nonnegative.
3923 * ftfont.c (ftfont_spec_pattern):
3924 * keymap.c (access_keymap, silly_event_symbol_error):
3925 XUINT -> XFASTINT, since the integer must be nonnegative.
3926 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3927 since it makes no difference and we prefer signed.
3928 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3929 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3930 nonnegative.
3931
d6d100dd
SM
39322011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3933
3934 * window.h (Fwindow_frame): Declare.
3935
2b6148e4
PE
39362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3937
3938 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3939 (SPARE_MEMORY): Always define.
3940 (LARGE_REQUEST): Remove.
3941 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3942
f230ecc9
MR
39432011-06-06 Martin Rudalics <rudalics@gmx.at>
3944
727e958e
MR
3945 * lisp.h: Move EXFUNS for Fframe_root_window,
3946 Fframe_first_window and Fset_frame_selected_window to window.h.
3947
3948 * window.h: Move EXFUNS for Fframe_root_window,
3949 Fframe_first_window and Fset_frame_selected_window here from
3950 lisp.h.
3951
3952 * frame.c (Fwindow_frame, Fframe_first_window)
3953 (Fframe_root_window, Fframe_selected_window)
3954 (Fset_frame_selected_window): Move to window.c.
3955 (Factive_minibuffer_window): Move to minibuf.c.
3956 (Fother_visible_frames_p): New function.
3957
3958 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3959
f230ecc9
MR
3960 * window.c (decode_window, decode_any_window): Move up in code.
3961 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3962 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3963 (Fwindow_buffer): Move up and rewrite doc-string.
3964 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3965 (Fwindow_prev): New functions.
727e958e
MR
3966 (Fwindow_frame): Move here from frame.c. Accept any window as
3967 argument.
3968 (Fframe_root_window, Fframe_first_window)
3969 (Fframe_selected_window): Move here from frame.c. Accept frame
3970 or arbitrary window as argument. Update doc-strings.
3971 (Fminibuffer_window): Move up in code.
3972 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3973 (Fset_frame_selected_window): Move here from frame.c.
3974 Marginal rewrite.
727e958e
MR
3975 (Fselected_window, select_window, Fselect_window): Move up in
3976 code. Minor doc-string fixes.
f230ecc9 3977
4d09bcf6
PE
39782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3979
3980 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3981 Do not assume that spare memory exists; that assumption is valid
3982 only if SYSTEM_MALLOC.
3983 (LARGE_REQUEST): New macro, so that the issue of large requests
3984 is separated from the issue of spare memory.
3985
810928a2
AS
39862011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3987
172418ad
AS
3988 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3989 format. (Bug#8806)
3990
43f862f7
AS
3991 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3992
810928a2
AS
3993 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3994 before statements.
3995
a059fe24
JD
39962011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3997
3998 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3999
4000 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4001
4002 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4003 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4004
989bf368
JB
40052011-06-05 Juanma Barranquero <lekktu@gmail.com>
4006
4007 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4008
4b80f674
CY
40092011-06-04 Chong Yidong <cyd@stupidchicken.com>
4010
4011 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4012 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4013 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4014 New error handlers.
4b80f674
CY
4015 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4016 Obey Vx_select_enable_clipboard_manager. Catch errors in
4017 x_clipboard_manager_save (Bug#8779).
4018 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4019 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4020
99a33b77 40212011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4022
4023 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4024
99a33b77 40252011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4026
4027 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4028 in the current matrix if keep_current_p is non-zero.
4029
8264569d
EZ
40302011-06-04 Eli Zaretskii <eliz@gnu.org>
4031
4032 * bidi.c (bidi_level_of_next_char): Fix last change.
4033
57f97249
EZ
40342011-06-03 Eli Zaretskii <eliz@gnu.org>
4035
fec2107c 4036 Support bidi reordering of text covered by display properties.
57f97249 4037
fec2107c
EZ
4038 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4039 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4040 (bidi_cache_search, bidi_cache_iterator_state)
4041 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4042 (bidi_level_of_next_char, bidi_move_to_visually_next):
4043 Support character positions inside a run of characters covered by a
fec2107c
EZ
4044 display string.
4045 (bidi_paragraph_init, bidi_resolve_explicit_1)
4046 (bidi_level_of_next_char): Call bidi_fetch_char and
4047 bidi_fetch_char_advance instead of FETCH_CHAR and
4048 FETCH_CHAR_ADVANCE.
4049 (bidi_init_it): Initialize new members.
4050 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4051 definitions.
4052 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4053 instead of using explicit *_CHAR codes.
d6d100dd
SM
4054 (bidi_resolve_explicit, bidi_resolve_weak):
4055 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4056 bidirectional text is supported only in multibyte buffers.
4057 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4058 it to initialize the frame_window_p member of struct bidi_it.
4059 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4060 (bidi_resolve_explicit, bidi_resolve_weak)
4061 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4062 bidi_it->nchars is non-positive.
4063 (bidi_level_of_next_char): Don't try to lookup the cache for the
4064 next/previous character if nothing is cached there yet, or if we
4065 were just reseat()'ed to a new position.
c40e2fb2 4066
0e14fe90
EZ
4067 * xdisp.c (set_cursor_from_row): Set start and stop points
4068 according to the row's direction when priming the loop that looks
4069 for the glyph on which to display cursor.
4070 (single_display_spec_intangible_p): Function deleted.
4071 (display_prop_intangible_p): Reimplement to call
4072 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4073 Accept 3 additional arguments needed by handle_display_spec.
4074 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4075 values: lists, `(when COND...)' forms, etc.
4076 (single_display_spec_string_p): Support property values that are
4077 lists with the argument STRING its top-level element.
4078 (display_prop_string_p): Fix the condition for processing a
4079 property that is a list to be consistent with handle_display_spec.
fec2107c 4080 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4081 last portion of handle_display_prop.
4082 (compute_display_string_pos): Accept additional argument
4083 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4084 value of a `display' property is a "replacing spec".
4085 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4086 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4087 the display property, but just return a value indicating whether
4088 the display property will replace the characters it covers.
4089 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4090 frame_window_p members of struct bidi_it.
d6d100dd
SM
4091 (compute_display_string_pos, compute_display_string_end):
4092 New functions.
fec2107c
EZ
4093 (push_it): Accept second argument POSITION, where pop_it should
4094 jump to continue iteration.
4095 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4096
fec2107c
EZ
4097 * keyboard.c (adjust_point_for_property): Adjust the call to
4098 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4099
4100 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4101 (bidi_init_it): Update prototypes.
4102 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4103 (compute_display_string_pos, compute_display_string_end):
4104 Declare prototypes.
fec2107c
EZ
4105 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4106 EMACS_INT.
fc6f18ce 4107
40087514 41082011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4109
57f53182
PE
4110 Malloc failure behavior now depends on size of allocation.
4111 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4112 * lisp.h: Change signatures accordingly.
4113 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4114 All callers changed. (Bug#8762)
4115
4116 * gnutls.c: Use Emacs's memory allocators.
4117 Without this change, the gnutls library would invoke malloc etc.
4118 directly, which causes problems on non-SYNC_INPUT hosts, and which
4119 runs afoul of improving memory_full behavior. (Bug#8761)
4120 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4121 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4122 xfree instead of the default malloc, realloc, free.
4123 (Fgnutls_boot): No need to check for memory allocation failure,
4124 since xmalloc does that for us.
4125
ac32cd99 4126 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4127 * category.c (hash_get_category_set):
4128 * ccl.c (ccl_driver):
4129 * charset.c (Fdefine_charset_internal):
4130 * charset.h (struct charset.hash_index):
4131 * composite.c (get_composition_id, gstring_lookup_cache)
4132 (composition_gstring_put_cache):
4133 * composite.h (struct composition.hash_index):
4134 * dispextern.h (struct image.hash):
4135 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4136 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4137 (hashfn_equal, hashfn_user_defined, make_hash_table)
4138 (maybe_resize_hash_table, hash_lookup, hash_put)
4139 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4140 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4141 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4142 * image.c (make_image, search_image_cache, lookup_image)
4143 (xpm_put_color_table_h):
4144 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4145 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4146 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4147 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4148 * alloc.c (allocate_vectorlike):
4149 Check for overflow in vector size calculations.
4150 * ccl.c (ccl_driver):
4151 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4152 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4153 need to be updated by these changes.
40087514
PE
4154 * fns.c (make_hash_table, maybe_resize_hash_table):
4155 Check for integer overflow with large hash tables.
0de4bb68
PE
4156 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4157 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4158 (SXHASH_REDUCE): New macro.
4159 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4160 Use it instead of discarding useful hash info with large hash values.
4161 (sxhash_float): New function.
4162 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4163 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4164 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4165 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4166 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4167 Adjust signatures to match updated version of code.
4168 (consing_since_gc): Now EMACS_INT, since a single hash table can
4169 use more than INT_MAX bytes.
4170
698d32e2
DN
41712011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4172
4173 Make it possible to build with GCC-4.6+ -O2 -flto.
4174
4175 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4176
fd6fa53f
SM
41772011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4178
4179 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4180 Call minibuffer-inactive-mode.
4181
864db017
JB
41822011-05-31 Juanma Barranquero <lekktu@gmail.com>
4183
4184 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4185 Update dependencies.
4186
2ad0baf4
DN
41872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4188
4189 * data.c (init_data): Remove code for UTS, this system is not
4190 supported anymore.
4191
4fcc2638
DN
41922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4193
4194 Don't force ./temacs to start in terminal mode.
4195
4196 * frame.c (make_initial_frame): Initialize faces in all cases, not
4197 only when CANNOT_DUMP is defined.
4198 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4199
c56e0fd5
DN
42002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4201
4202 * dispnew.c (add_window_display_history): Use const for the string
4203 pointer. Remove declaration, not needed.
4204
333d54da 42052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4206
55d4c1b2 4207 Use 'inline', not 'INLINE'.
333d54da 4208 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4209 * alloc.c, fontset.c (INLINE): Remove.
4210 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4211 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4212 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4213 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4214 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4215
738db178
DN
42162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4217
4218 Make it possible to run ./temacs.
4219
4220 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4221 syms_of_callproc does the same thing. Remove test for
4222 "initialized", do it in the caller.
4223 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4224
620c53a6
SM
42252011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4226
4227 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4228 (read_minibuf): Use get_minibuffer.
4229 (syms_of_minibuf): Use DEFSYM.
4230 (Qmetadata): New var.
4231 * data.c (Qbuffer): Don't make it static.
4232 (syms_of_data): Use DEFSYM.
4233
e003a292
PE
42342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4235
4236 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4237 (CCL_CODE_MIN): New macro.
4238
ed008a6d
PE
42392011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4240
3687c2ef
PE
4241 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4242
ed008a6d
PE
4243 * eval.c (Qdebug): Now static.
4244 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4245 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4246 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4247
d66c4c7c
CY
42482011-05-29 Chong Yidong <cyd@stupidchicken.com>
4249
4250 * image.c: Various fixes to ImageMagick code comments.
4251 (Fimagemagick_types): Doc fix.
4252
5fbc2025
PE
42532011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4254
0196f88a
PE
4255 Minor fixes prompted by GCC 4.6.0 warnings.
4256
4257 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4258
5fbc2025
PE
4259 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4260 (x_clipboard_manager_save_all): Move extern decl to ...
4261 * xterm.h: ... here, so that it can be checked for consistency.
4262
1dd3c2d9
CY
42632011-05-29 Chong Yidong <cyd@stupidchicken.com>
4264
4265 * xselect.c (x_clipboard_manager_save_frame)
4266 (x_clipboard_manager_save_all): New functions.
4267 (Fx_clipboard_manager_save): Lisp function deleted.
4268
4269 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4270 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4271
4272 * xterm.h: Update prototype.
4273
5ba6571d
WX
42742011-05-28 William Xu <william.xwl@gmail.com>
4275
4276 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4277 exiting (Bug#8239).
4278
3eaff834
JM
42792011-05-28 Jim Meyering <meyering@redhat.com>
4280
e1900994 4281 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4282 * fns.c (to_uchar): Define.
4283 (crypto_hash_function): Use it to convert some newly-signed
4284 variables to unsigned, to avoid sign-extension bugs. For example,
4285 without this change, (md5 "truc") would evaluate to
4286 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4287 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4288 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4289
0f6990a7
PE
42902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 Integer overflow fixes.
c8a9ca5a 4293
08686060
PE
4294 * dbusbind.c: Serial number integer overflow fixes.
4295 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4296 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4297 to hold a serial number that is too large for a fixnum.
4298 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4299 Check for serial numbers out of range. Decode any serial number
59568bf0 4300 that was so large that it became a float. (Bug#8722)
08686060 4301
2d1fc3c7
PE
4302 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4303 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4304 Use XFASTINT rather than XUINT when numbers are nonnegative.
4305 (xd_append_arg, Fdbus_method_return_internal):
4306 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4307 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4308 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4309 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4310 (Bug#8722)
2d1fc3c7 4311
c8a9ca5a
PE
4312 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4313
519e1d69
PE
4314 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4315
30569699
PE
4316 ccl: add integer overflow checks
4317 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4318 (IN_INT_RANGE): New macros.
4319 (ccl_driver): Use them to check for integer overflow when
4320 decoding a CCL program. Many of the new checks are whether XINT (x)
4321 fits in int; it doesn't always, on 64-bit hosts. The new version
4322 doesn't catch all possible integer overflows, but it's an
847044ea 4323 improvement. (Bug#8719)
30569699 4324
c11285dc
PE
4325 * alloc.c (make_event_array): Use XINT, not XUINT.
4326 There's no need for unsigned here.
4327
fdccd48e
PE
4328 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4329 This follows up to the 2011-05-06 change that substituted uintptr_t
4330 for EMACS_INT. This case wasn't caught back then.
4331
37910ab2
PE
4332 Rework Fformat to avoid integer overflow issues.
4333 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4334 now (part of C89). Include <verify.h>.
4335 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4336 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4337 (Fformat): Avoid the prepass trying to compute sizes; it was only
4338 approximate and thus did not catch overflow reliably. Instead, walk
4339 through the format just once, formatting and computing sizes as we go,
4340 checking for integer overflow at every step, and allocating a larger
4341 buffer as needed. Keep track separately whether the format is
4342 multibyte. Keep only the most-recently calculated precision, rather
4343 than them all. Record whether each argument has been converted to
4344 string. Use EMACS_INT, not int, for byte and char and arg counts.
4345 Support field widths and precisions larger than INT_MAX. Avoid
4346 sprintf's undefined behavior with conversion specifications such as %#d
4347 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4348 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4349 formatting out-of-range floating point numbers with int
9173deec 4350 formats. (Bug#8668)
37910ab2 4351
2e6578fb
PE
4352 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4353
0ae6bdee
PE
4354 * data.c: Avoid integer truncation in expressions involving floats.
4355 * data.c: Include <intprops.h>.
4356 (arith_driver): When there's an integer overflow in an expression
4357 involving floating point, convert the integers to floating point
4358 so that the resulting value does not suffer from catastrophic
4359 integer truncation. For example, on a 64-bit host (* 4
4360 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4361 Do not rely on undefined behavior after integer overflow.
4362
de883a70
PE
4363 merge count_size_as_multibyte, parse_str_to_multibyte
4364 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4365 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4366 Check for integer overflow.
4367 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4368 since it's now a duplicate of the other. This is more of
4369 a character than a buffer op, so better that it's in character.c.
4370 * fns.c, print.c: Adjust to above changes.
4371
2ff916cb
PE
43722011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4373
4374 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4375
f1b54466
PE
43762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4377
fb1ac845
PE
4378 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4379 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4380 (x_clipboard_manager_save): Now static.
4381 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4382
f1b54466
PE
4383 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4384 (crypto_hash_function): Now static.
4385 Fix pointer signedness problems. Avoid unnecessary initializations.
4386
a9f737ee
CY
43872011-05-27 Chong Yidong <cyd@stupidchicken.com>
4388
4389 * termhooks.h (Vselection_alist): Make it terminal-local.
4390
4391 * terminal.c (create_terminal): Initialize it.
4392
4393 * xselect.c: Support for clipboard managers.
4394 (Vselection_alist): Move to termhooks.h as terminal-local var.
4395 (LOCAL_SELECTION): New macro.
4396 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4397 (symbol_to_x_atom): Remove gratuitous arg.
4398 (x_handle_selection_request, lisp_data_to_selection_data)
4399 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4400 (x_own_selection, x_get_local_selection, x_convert_selection):
4401 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4402 (some_frame_on_display): Delete unused function.
4403 (Fx_own_selection_internal, Fx_get_selection_internal)
4404 (Fx_disown_selection_internal, Fx_selection_owner_p)
4405 (Fx_selection_exists_p): New optional frame arg.
4406 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4407 (x_handle_selection_clear): Don't treat other terminals with the
4408 same keyboard specially. Use the terminal-local Vselection_alist.
4409 (x_clear_frame_selections): Use Frun_hook_with_args.
4410
4411 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4412
4413 * xterm.h: Add support for those atoms.
4414
e067f0c1
CY
44152011-05-26 Chong Yidong <cyd@stupidchicken.com>
4416
4417 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4418 (converted_selections, conversion_fail_tag): New global variables.
4419 (x_selection_request_lisp_error): Free the above.
4420 (x_get_local_selection): Remove unnecessary code.
4421 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4422 of converted selections stored in converted_selections.
4423 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4424 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4425 (x_convert_selection): New function.
4426 (x_handle_selection_event): Simplify.
4427 (x_get_foreign_selection): Don't ignore incoming requests while
4428 waiting for an answer; this will fail when we implement
4429 SAVE_TARGETS, and seems unnecessary anyway.
4430 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4431 (Vx_sent_selection_functions): Doc fix.
4432
0f4aebc0
LL
44332011-05-26 Leo Liu <sdl.web@gmail.com>
4434
4435 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4436
e61124cd
YM
44372011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4438
4439 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4440
4441 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4442 for fringe update if it has periodic bitmap.
ac389d0c 4443 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4444 and fringe_bitmap_periodic_p.
4445
4446 * fringe.c (get_fringe_bitmap_data): New function.
4447 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4448 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4449 row. Mark glyph row for fringe update if periodicity changed.
4450
4451 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4452 for fringe update unless it has periodic bitmap.
4453
f16d9837
KH
44542011-05-25 Kenichi Handa <handa@m17n.org>
4455
4456 * xdisp.c (get_next_display_element): Set correct it->face_id for
4457 a static composition.
4458
e1b90ef6
LL
44592011-05-24 Leo Liu <sdl.web@gmail.com>
4460
4461 * deps.mk (fns.o):
4462 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4463
4464 * fns.c (crypto_hash_function, Fsha1): New function.
4465 (Fmd5): Use crypto_hash_function.
4466 (syms_of_fns): Add Ssha1.
4467
7400048f
PE
44682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4469
4470 * gnutls.c: Remove unused macros.
4471 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4472 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4473 Remove macros that are defined and never used.
4474 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4475
abb71cf4
CY
44762011-05-22 Chong Yidong <cyd@stupidchicken.com>
4477
4478 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4479 (Fx_get_selection_internal): Minor cleanup.
4480 (Fx_own_selection_internal): Rename arguments for consistency with
4481 select.el.
4482
6307db39
PE
44832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4484
4485 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4486
f3d4e0a4
CY
44872011-05-22 Chong Yidong <cyd@stupidchicken.com>
4488
4489 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4490
4d8ade89
YM
44912011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4492
4493 * dispnew.c (scrolling_window): Don't exclude the case that the
4494 last enabled row in the desired matrix touches the bottom boundary.
4495
32078c8d
GM
44962011-05-21 Glenn Morris <rgm@gnu.org>
4497
4498 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4499 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4500 and add some more files.
32078c8d 4501
7285dc67
EZ
45022011-05-20 Eli Zaretskii <eliz@gnu.org>
4503
4504 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4505 report_file_error introduced by the change from 2011-05-07.
4506
89d1bd22
PE
45072011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 * systime.h (Time): Define only if emacs is defined.
4510 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4511 where the include path doesn't have X11/X.h by default. See
4512 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4513
e23640bb 45142011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4515
4516 * composite.c (find_automatic_composition): Fix previous change.
4517
b9704ad9
GM
45182011-05-20 Glenn Morris <rgm@gnu.org>
4519
4520 * lisp.mk: New file, split from Makefile.in.
4521 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4522 (shortlisp): Remove.
4523 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4524
4a720484
GM
45252011-05-19 Glenn Morris <rgm@gnu.org>
4526
4527 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4528 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4529 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4530 (lisp): Set the order to that of loadup.el.
4531 (shortlisp): Make it a copy of $lisp.
4532 (SOME_MACHINE_LISP): Remove.
4533 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4534 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4535
a28d4396
KH
45362011-05-18 Kenichi Handa <handa@m17n.org>
4537
4538 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4539 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4540 (find_automatic_composition): Mostly rewrite for efficiency.
4541
a2b1fa8e
JB
45422011-05-18 Juanma Barranquero <lekktu@gmail.com>
4543
4544 * makefile.w32-in: Update dependencies.
4545
8e1f5610
CS
45462011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4547
4548 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4549 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4550
7025ee00 45512011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4552
cdfa6eab
PE
4553 Fix some integer overflow issues, such as string length overflow.
4554
06d6db33
PE
4555 * insdel.c (count_size_as_multibyte): Check for string overflow.
4556
2b4560a8
PE
4557 * character.c (lisp_string_width): Check for string overflow.
4558 Use EMACS_INT, not int, for string indexes and lengths; in
4559 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4560 the resulting string length overflows an EMACS_INT; instead,
4561 report a string overflow if no precision given. When checking for
4562 precision exhaustion, use a check that cannot possibly have
4563 integer overflow. (Bug#8675)
4564 * character.h (lisp_string_width): Adjust to new signature.
4565
cb93f9be
PE
4566 * alloc.c (string_overflow): New function.
4567 (Fmake_string): Use it. This doesn't change behavior, but saves
4568 a few bytes and will simplify future changes.
4569 * character.c (string_escape_byte8): Likewise.
4570 * lisp.h (string_overflow): New decl.
4571
1a1f3366
PE
4572 Fixups, following up to the user-interface timestamp change.
4573 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4574 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4575 * msdos.c (mouse_get_pos): Likewise.
4576 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4577 * w32gui.h (Time): Define by including "systime.h" rather than by
4578 declaring it ourselves. (Bug#8664)
4579
d4e3e4d3
PE
4580 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4581 * image.c (clear_image_cache): Likewise.
4582
f6a24d19
PE
4583 * term.c (term_mouse_position): Don't assume time_t wraparound.
4584
08dc5ae6
PE
4585 Be more systematic about user-interface timestamps.
4586 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4587 and sometimes 'EMACS_UINT', to represent these timestamps.
4588 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4589 This makes the code easier to follow, and makes it easier to catch
4590 integer overflow bugs such as Bug#8664.
4591 * frame.c (Fmouse_position, Fmouse_pixel_position):
4592 Use Time, not unsigned long, for user-interface timestamps.
4593 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4594 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4595 * keyboard.h (last_event_timestamp): Likewise.
4596 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4597 * menu.h (xmenu_show): Likewise.
4598 * term.c (term_mouse_position): Likewise.
4599 * termhooks.h (struct input_event.timestamp): Likewise.
4600 (struct terminal.mouse_position_hook): Likewise.
4601 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4602 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4603 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4604 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4605 what it was before.
4606 * menu.h, termhooks.h: Include "systime.h", for Time.
4607
8e55734a
PE
4608 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4609 Don't assume that the difference between two unsigned long values
4610 can fit into an integer. At this point, we know button_down_time
4611 <= event->timestamp, so the difference must be nonnegative, so
4612 there's no need to cast the result if double-click-time is
4613 nonnegative, as it should be; check that it's nonnegative, just in
4614 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4615 apart (about 25 days). (Bug#8664)
8e55734a 4616
841f1b75 4617 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4618 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4619
3e26f69c
PE
4620 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4621 that always fit in int. Use a sentinel instead of a counter, to
4622 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4623 * frame.h (struct frame): Use int for menu_bar_items_used
4624 instead of EMACS_INT, since it always fits in int.
3e26f69c 4625
5cc152c0
PE
4626 * menu.c (grow_menu_items): Check for int overflow.
4627
d89eb65e
PE
4628 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4629
5235bd3e
PE
4630 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4631 Before, the code was not consistent. These values cannot exceed
4632 2**31 - 1 so there's no need to make them unsigned.
4633 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4634 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4635 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4636 as modifiers.
4637 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4638
bc827e23
PE
4639 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4640 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4641 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4642 presumably because the widths might not match.
4643
78eb494e
PE
4644 * window.c (size_window): Avoid needless test at loop start.
4645
04f2d78b
CB
46462011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4647
4648 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4649
d2fc7e3d 46502011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4651
4652 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4653
d2fc7e3d 46542011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4655
4656 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4657 `width' to `bar_area_x' and `bar_area_width', respectively.
4658 (x_scroll_run): Take account of fringe background extension.
4659
04f2d78b
CB
4660 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4661 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4662 `bar_area_width', respectively.
4663 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4664 background extension.
4665
79b70037
GM
46662011-05-10 Jim Meyering <meyering@redhat.com>
4667
4668 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4669
2f142cc5
JB
46702011-05-10 Juanma Barranquero <lekktu@gmail.com>
4671
4672 * image.c (Finit_image_library): Return t for built-in image types,
4673 like pbm and xbm. (Bug#8640)
4674
57679c86
AS
46752011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4676
4677 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4678
888c9e86
EZ
46792011-05-07 Eli Zaretskii <eliz@gnu.org>
4680
b0512a1d
EZ
4681 * w32console.c (Fset_screen_color): Doc fix.
4682 (Fget_screen_color): New function.
4683 (syms_of_ntterm): Defsubr it.
4684
7285dc67
EZ
4685 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4686 unlink the temporary file if Fcall_process didn't create it in the
4687 first place.
4688 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4689 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4690 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4691 cue to call_process_cleanup not to close that handle.
4692
4d3fcc8e
BK
46932011-05-07 Ben Key <bkey76@gmail.com>
4694
4695 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4696 one of two shell specific rules, either bootstrap-temacs-CMD or
4697 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4698 to the previous implementation of the bootstrap-temacs rule.
4699 The bootstrap-temacs-CMD rule is similar to the previous
4700 implementation of the bootstrap-temacs rule except that it
4701 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4702 variable.
4703
4704 These changes, along with some changes to nt/configure.bat,
4705 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4706 earlier fix to add support for --cflags and --ldflags options
4707 that include quotes so that it works whether make uses cmd or
4708 sh as the shell.
4709
b4289b64
MA
47102011-05-06 Michael Albinus <michael.albinus@gmx.de>
4711
4712 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4713 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4714 is a constant.
4715 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4716 a string. Handle both cases.
4717 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4718 (Fdbus_register_method): Use Qinvalid_function.
4719
af4c0e28
JB
47202011-05-06 Juanma Barranquero <lekktu@gmail.com>
4721
4722 * makefile.w32-in: Update dependencies.
4723 (LISP_H): Add inttypes.h and stdin.h.
4724 (PROCESS_H): Add unistd.h.
4725
c51453d9
EZ
47262011-05-06 Eli Zaretskii <eliz@gnu.org>
4727
4728 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4729 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4730
8ff0ac3c 47312011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4732
4c4b566b
PE
4733 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4734
aab2b9b5
PE
4735 * term.c (vfatal): Remove stray call to va_end.
4736 It's not needed and the C Standard doesn't allow it here anyway.
4737
c378da0b
PE
4738 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4739 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4740
288b08c7
PE
4741 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4742 bytes.
4743
e3601888
PE
4744 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4745
db6c0e74
PE
4746 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4747
dd5963ea
PE
4748 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4749
88c9450f
PE
4750 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4751
2f9442b8
PE
4752 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4753
c032b5f8
PE
4754 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4755 * charset.c (Fdefine_charset_internal): Don't initialize
4756 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4757 32-bit int (Bug#8600).
a108c10b
PE
4758
4759 * lread.c (read_integer): Be more consistent with string-to-number.
4760 Use string_to_number to do the actual conversion; this avoids
4761 rounding errors and fixes some other screwups. Without this fix,
4762 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4763 (digit_to_number): Move earlier, for benefit of read_integer.
4764 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4765 not a digit in any supported base. (Bug#8602)
a108c10b 4766
ad5f9eea
PE
4767 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4768
aec1708a
PE
4769 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4770 to match comment at start of function. This also removes a
4771 GCC warning about overflow in a 32+64-bit port.
4772
47be4ab5
PE
4773 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4774
371cac43
PE
4775 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4776 Reported by Stefan Monnier in
4777 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4778 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4779 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4780
d01a7826
PE
4781 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4782 (EMACS_UINTPTR): Likewise, with uintptr_t.
4783
7fd47d5c
PE
4784 * lisp.h: Prefer 64-bit EMACS_INT if available.
4785 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4786 on 32-bit hosts that have 64-bit int, so that they can access
4787 large files.
122b0c86
PE
4788 However, temporarily disable this change unless the temporary
4789 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4790
8727937b
PE
4791 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4792
8ac068ac
PE
4793 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4794 This removes an assumption that EMACS_INT and long are the same
4795 width as pointers. The assumption is true for Emacs porting targets
4796 now, but we want to make other targets possible.
4797 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4798 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4799 In the rest of the code, change types of integers that hold casted
4800 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4801 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4802 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4803 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4804 No need to cast type when ORing.
4805 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4806 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4807 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4808 assume EMACS_INT is the same width as char *.
4809 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4810 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4811 Remove no-longer-needed casts.
4812 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4813 (xg_tool_bar_help_callback, xg_make_tool_item):
4814 Use EMACS_INTPTR to hold an integer
4815 that will be cast to void *; this can avoid a GCC warning
4816 if EMACS_INT is not the same width as void *.
4817 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4818 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4819 (current_message_1, set_message_1):
4820 Use a local to convert to proper width without a cast.
4821 * xmenu.c (dialog_selection_callback): Likewise.
4822
ede49d71
PE
4823 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4824 Also, don't assume VALBITS / RAND_BITS is less than 5,
4825 and don't rely on undefined behavior when shifting a 1 left into
4826 the sign bit.
4827 * lisp.h (get_random): Change signature to match.
4828
2f30ecd0
PE
4829 * lread.c (hash_string): Use size_t, not int, for hash computation.
4830 Normally we prefer signed values; but hashing is special, because
4831 it's better to use unsigned division on hash table sizes so that
4832 the remainder is nonnegative. Also, size_t is the natural width
4833 for hashing into memory. The previous code used 'int', which doesn't
4834 retain enough info to hash well into very large tables.
4835 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4836
2a866e7b
PE
4837 * dbusbind.c: Don't possibly lose pointer info when converting.
4838 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4839 Use XPNTR rather than XHASH, so that the high-order bits of
4840 the pointer aren't lost when converting through void *.
4841
51639eac
PE
4842 * eval.c (Fautoload): Don't double-shift a pointer.
4843
92394119
PE
4844 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4845
dbdb9a7c
JB
48462011-05-06 Juanma Barranquero <lekktu@gmail.com>
4847
4848 * gnutls.c (DEF_GNUTLS_FN):
4849 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4850
db7a0b4f
AS
48512011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4852
4853 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4854 marker. (Bug#8610)
4855
f7ff1b0f 48562011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4857
4858 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4859 New version that can reserve upto 2GB of heap space.
4860
f7ff1b0f 48612011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4862
4863 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4864
639c109b
TZ
48652011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4866
4867 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4868 `gnutls_certificate_set_x509_key_file'.
4869
d2127135
JB
48702011-05-05 Juanma Barranquero <lekktu@gmail.com>
4871
4872 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4873 Update dependencies.
4874
e968f4f3
JB
48752011-05-04 Juanma Barranquero <lekktu@gmail.com>
4876
4877 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4878 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4879 Remove unused parameter `fildes'.
4880 * process.c (read_process_output, send_process): Don't pass it.
4881
84d358f0
JB
48822011-05-04 Juanma Barranquero <lekktu@gmail.com>
4883
4884 Fix previous change: the library cache is defined in w32.c.
4885 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4886 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4887
0898ca10
JB
48882011-05-04 Juanma Barranquero <lekktu@gmail.com>
4889
4890 Implement dynamic loading of GnuTLS on Windows.
4891
4892 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4893 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4894 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4895 Declare.
4896
4897 * gnutls.c (Qgnutls_dll): Define.
4898 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4899 (gnutls_*): Declare function pointers.
4900 (init_gnutls_functions): New function to initialize function pointers.
4901 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4902 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4903 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4904 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4905 (emacs_gnutls_write, emacs_gnutls_read)
4906 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4907 (Fgnutls_available_p): New function.
4908 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4909 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4910 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4911
4912 * image.c: Include w32.h.
4913 (Vimage_type_cache): Delete.
4914 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4915 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4916 (w32_delayed_load): Move to w32.c.
4917
4918 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4919
4920 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4921 (w32_delayed_load): Move from image.c. When loading a library, record
4922 its filename in the :loaded-from property of the library id.
4923 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4924 Initialize and staticpro them.
4925 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4926
4927 * process.c: Include lisp.h before w32.h, not after.
4928 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4929 instead of gnutls_record_check_pending.
4930
4931 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4932
ff4de4aa
TZ
49332011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4934
4935 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4936 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4937 as passed in.
4938
abe95abb
JD
49392011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4940
4941 * xterm.c (x_set_frame_alpha): Do not set property on anything
4942 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4943
e16e55d4
JB
49442011-05-02 Juanma Barranquero <lekktu@gmail.com>
4945
4946 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4947
bafcf6a5
JB
49482011-05-02 Juanma Barranquero <lekktu@gmail.com>
4949
4950 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4951 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4952 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4953 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4954 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4955 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4956 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4957 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4958 (Qgnutls_bootprop_callbacks_verify): Make static.
4959
e7a6747f
AS
49602011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4961
19ed11ba
AS
4962 * callproc.c: Indentation fixup.
4963
e7a6747f 4964 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4965 (wait_for_termination, interruptible_wait_for_termination):
4966 Move after wait_for_termination_1.
e7a6747f 4967
1ef14cb4
LMI
49682011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4969
4970 * sysdep.c (interruptible_wait_for_termination): New function
4971 which is like wait_for_termination, but allows keyboard
4972 interruptions.
4973
4974 * callproc.c (Fcall_process): Add (:file "file") as an option for
4975 the STDOUT buffer.
4976 (Fcall_process_region): Ditto.
4977
330d880c
EZ
49782011-04-30 Eli Zaretskii <eliz@gnu.org>
4979
8db90b73
EZ
4980 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4981 rather than `XVECTOR (FOO)->size'.
4982
330d880c
EZ
4983 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4984 inttypes.h, as a gnulib replacement is used if it not available in
4985 system headers.
4986
15cbd324
EZ
49872011-04-21 Eli Zaretskii <eliz@gnu.org>
4988
4989 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4990 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4991 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4992
4993 * coding.c (coding_alloc_by_realloc): Error out if destination
4994 will grow beyond MOST_POSITIVE_FIXNUM.
4995 (decode_coding_emacs_mule): Abort if there isn't enough place in
4996 charbuf for the composition carryover bytes. Reserve an extra
4997 space for up to 2 characters produced in a loop.
4998 (decode_coding_iso_2022): Abort if there isn't enough place in
4999 charbuf for the composition carryover bytes.
5000
50012011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5002
ae940cca
EZ
5003 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5004 aborting when %lld or %lll format is passed.
5005 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5006 %llo or %llx format is passed. (Bug#8545)
5007
03ab8921
EZ
5008 * window.c (window_scroll_line_based): Use a marker instead of
5009 simple variables to record original value of point. (Bug#7952)
5010
afda1437
EZ
5011 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5012 produced by %s or %c overflows available buffer space. (Bug#8545)
5013
f76dee0c
PE
50142011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5015
5016 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5017 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5018
fdc5744d
JB
50192011-04-28 Juanma Barranquero <lekktu@gmail.com>
5020
5021 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5022
638f053a
JB
50232011-04-28 Juanma Barranquero <lekktu@gmail.com>
5024
5025 * keyboard.c (Qdelayed_warnings_hook): Define.
5026 (command_loop_1): Run `delayed-warnings-hook'
5027 if Vdelayed_warnings_list is non-nil.
5028 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5029 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5030
d178f871
EZ
50312011-04-28 Eli Zaretskii <eliz@gnu.org>
5032
5033 * doprnt.c (doprnt): Don't return value smaller than the buffer
5034 size if the message was truncated. (Bug#8545).
5035
b124fd93
JB
50362011-04-28 Juanma Barranquero <lekktu@gmail.com>
5037
5038 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5039 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5040
e810457d
PE
50412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5044
ea51cceb
JB
50452011-04-27 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * makefile.w32-in: Update dependencies.
5048
94dcfacf
EZ
50492011-04-27 Eli Zaretskii <eliz@gnu.org>
5050
5051 Improve `doprnt' and its usage. (Bug#8545)
5052 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5053 `format_end'. Remove support for %l as a conversion specifier.
5054 Don't use xrealloc. Improve diagnostics when the %l size modifier
5055 is used. Update the commentary.
5056
5057 * eval.c (verror): Simplify calculation of size_t.
5058
5059 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5060 messages.
5061
f61f41d7
PE
50622011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5063
5064 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5065 change.
5066
96fb4434
PE
50672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5070 This makes this file independent of the recent pseudovector change.
5071
671875da 50722011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5073
69e9b5a3
PE
5074 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5075
b5f869a7 5076 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5077 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5078 Remove unused local.
c8926152 5079 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5080
841a1577 5081 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5082 GCC 4.6.0 optimizes based on type-based alias analysis.
5083 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5084 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5085 != &v->size, and therefore "v->size = 1; b->size = 2; return
5086 v->size;" must therefore return 1. This assumption is incorrect
5087 for Emacs, since it type-puns struct Lisp_Vector * with many other
5088 types. To fix this problem, this patch adds a new type struct
f904488f 5089 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5090 and pseudovectors, and helps optimizing compilers not get fooled
5091 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5092 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5093 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5094 the size member.
eab3844f
PE
5095 (XSETPVECTYPE): Rewrite in terms of new macro.
5096 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5097 This is a bit clearer, and further avoids the possibility of
5098 undesirable aliasing.
5099 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5100 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5101 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5102 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5103 (ASIZE): Now uses header.size rather than size.
5104 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5105 to avoid the hassle of writing XVECTOR (foo)->header.size.
5106 (struct vectorlike_header): New type.
eab3844f
PE
5107 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5108 object, to help avoid aliasing.
5109 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5110 (SUBRP): Likewise, since Lisp_Subr is a special case.
5111 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5112 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5113 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5114 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5115 changed to be "header.size" and "header.next".
5116 * buffer.h (struct buffer): Likewise.
5117 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5118 * frame.h (struct frame): Likewise.
5119 * process.h (struct Lisp_Process): Likewise.
5120 * termhooks.h (struct terminal): Likewise.
5121 * window.c (struct save_window_data, struct saved_window): Likewise.
5122 * window.h (struct window): Likewise.
5123 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5124 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5125 * buffer.c (init_buffer_once): Likewise.
5126 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5127 special case.
5128 * process.c (Fformat_network_address): Use local var for size,
5129 for brevity.
5130
0df1eac5
PE
5131 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5132
847ab9d1 5133 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5134 * data.c (atof): Remove decl; no longer used or needed.
5135 (digit_to_number): Move to lread.c.
5136 (Fstring_to_number): Use new string_to_number function, to be
5137 consistent with how the Lisp reader treats infinities and NaNs.
5138 Do not assume that floating-point numbers represent EMACS_INT
5139 without losing information; this is not true on most 64-bit hosts.
5140 Avoid double-rounding errors, by insisting on integers when
5141 parsing non-base-10 numbers, as the documentation specifies.
5142 * lisp.h (string_to_number): New decl, replacing ...
5143 (isfloat_string): Remove.
bc0a5c13 5144 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5145 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5146 appears to have been a coding error. Similarly, do not accept
5147 strings like +-1e0 as floating point numbers. Do not report
5148 overflow for integer overflows unless the base is not 10 which
5149 means we have no simple and reliable way to continue.
5150 Break out the floating-point parsing into a new
5151 function string_to_number, so that Fstring_to_number parses
5152 floating point numbers consistently with the Lisp reader.
04f2d78b 5153 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5154 (E_CHAR, EXP_INT): Remove, replacing with ...
5155 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5156 (string_to_number): New function, replacing isfloat_string.
5157 This function checks for valid syntax and produces the resulting
5158 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5159 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5160 so that overflow for non-base-10 numbers is reported only when
5161 there's no portable and simple way to convert to floating point.
452f4150 5162
67769ffc
PE
5163 * textprop.c (set_text_properties_1): Rewrite for clarity,
5164 and to avoid GCC warning about integer overflow.
5165
c20db43f
PE
5166 * intervals.h (struct interval): Use EMACS_INT for members
5167 where EMACS_UINT might cause problems. See
5168 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5169 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5170 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5171 All uses changed.
37aa2f85
PE
5172 (offset_intervals): Tell GCC not to worry about length overflow
5173 when negating a negative length.
c20db43f 5174
2538aa2f
PE
5175 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5176 (overrun_check_free): Likewise.
5177
f2d3008d
PE
5178 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5179 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5180 word size.
5181
ec8df744
PE
5182 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5183 (gnutls_make_error): Rename local to avoid shadowing.
5184 (gnutls_emacs_global_deinit): ifdef out; not used.
5185 (Fgnutls_boot): Use const for pointer to readonly storage.
5186 Comment out unused local. Fix pointer signedness problems.
5187
640ee02d
PE
5188 * lread.c (openp): Don't stuff size_t into an 'int'.
5189 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5190 about possible signed overflow.
5191
6048fb2a
PE
5192 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5193 (GDK_KEY_g): Don't define if already defined.
5194 (xg_prepare_tooltip): Avoid pointer signedness problem.
5195 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5196
fa3c87e1
PE
5197 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5198 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5199
2172544b
PE
5200 * xfns.c (Fx_window_property): Simplify a bit,
5201 to make a bit faster and to avoid GCC 4.6.0 warning.
5202 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5203
9b821a21
PE
5204 * fns.c (internal_equal): Don't assume size_t fits in int.
5205
3c616cfa
PE
5206 * alloc.c (compact_small_strings): Tighten assertion a little.
5207
c2982e87
PE
5208 Replace pEd with more-general pI, and fix some printf arg casts.
5209 * lisp.h (pI): New macro, generalizing old pEd macro to other
5210 conversion specifiers. For example, use "...%"pI"d..." rather
5211 than "...%"pEd"...".
5212 (pEd): Remove. All uses replaced with similar uses of pI.
5213 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5214 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5215 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5216 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5217 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5218 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5219 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5220 64-bit hosts.
5221 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5222 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5223 * print.c (safe_debug_print, print_object): Likewise.
5224 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5225 to int.
6f04d126
PE
5226 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5227 avoiding the 0 flag, which is not portable.
c2982e87
PE
5228 * process.c (Fmake_network_process): Use pI to avoid cast.
5229 * region-cache.c (pp_cache): Likewise.
5230 * xdisp.c (decode_mode_spec): Likewise.
5231 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5232 behavior on 64-bit hosts with printf arg.
6f04d126 5233 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5234 (x_stop_queuing_selection_requests): Likewise.
5235 (x_get_window_property): Don't truncate byte count to an 'int'
5236 when tracing.
0b432f21 5237
5e073ec7
PE
5238 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5239 here, since it parses constructs like leading '-' and spaces,
5240 which are not wanted; and it overflows with large numbers.
5241 Instead, simply match F[0-9]+, which is what is wanted anyway.
5242
36372bf9
PE
5243 * alloc.c: Remove unportable assumptions about struct layout.
5244 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5245 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5246 (allocate_vectorlike, make_pure_vector): Use the new macros,
5247 plus offsetof, to remove unportable assumptions about struct layout.
5248 These assumptions hold on all porting targets that I know of, but
5249 they are not guaranteed, they're easy to remove, and removing them
5250 makes further changes easier.
5251
0b432f21
PE
5252 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5253 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5254 (string_overrun_cookie): Now const. Use initializers that
5255 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5256 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5257 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5258 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5259 multiple of sizeof (EMACS_INT); it need not be, if
5260 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5261 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5262
895009e1
JB
52632011-04-26 Juanma Barranquero <lekktu@gmail.com>
5264
5265 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5266
6a7a1b0b
TZ
52672011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5268
5269 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5270 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5271 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5272
841a1577 52732011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5274
5275 * lisp.h (Qdebug): List symbol.
895009e1 5276 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5277 * keyboard.c (debug-on-event): New variable.
5278 (handle_user_signal): Break into debugger when debug-on-event
5279 matches the current signal symbol.
5280
f2d3ba6f
DN
52812011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5282
5283 * alloc.c (check_sblock, check_string_bytes)
5284 (check_string_free_list): Convert to standard C.
5285
42ce4c63
TZ
52862011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5287
5288 * w32.c (emacs_gnutls_push): Fix typo.
5289
825cd63c
EZ
52902011-04-25 Eli Zaretskii <eliz@gnu.org>
5291
fb11d64d
EZ
5292 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5293 "cast to pointer from integer of different size".
5294
825cd63c
EZ
5295 Improve doprnt and its use in verror. (Bug#8545)
5296 * doprnt.c (doprnt): Document the set of format control sequences
5297 supported by the function. Use SAFE_ALLOCA instead of always
5298 using `alloca'.
5299
5300 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5301 is one byte too soon. Don't use xrealloc; instead xfree and
5302 xmalloc anew.
5303
e061a11b
TZ
53042011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5305
5306 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5307 callbacks stage.
5308
5309 * gnutls.c: Renamed global_initialized to
5310 gnutls_global_initialized. Added internals for the
5311 :verify-hostname-error, :verify-error, and :verify-flags
5312 parameters of `gnutls-boot' and documented those parameters in the
5313 docstring. Start callback support.
9173deec
JB
5314 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5315 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5316 on error. Return error code.
e061a11b
TZ
5317 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5318 (emacs_gnutls_read): Likewise.
5319 (Fgnutls_boot): Return handshake error code.
5320 (emacs_gnutls_handle_error): New function.
5321 (wsaerror_to_errno): Likewise.
5322
5323 * w32.h (emacs_gnutls_pull): Add prototype.
5324 (emacs_gnutls_push): Likewise.
5325
5326 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5327 (emacs_gnutls_push): Likewise.
5328
53292011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5330
5331 * process.c (wait_reading_process_output): Check if GnuTLS
5332 buffered some data internally if no FDs are set for TLS
5333 connections.
5334
5335 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5336 (LIBS): Link to USER_LIBS.
5337 ($(BLD)/gnutls.$(0)): New target.
5338
fa6996bc
EZ
53392011-04-24 Eli Zaretskii <eliz@gnu.org>
5340
eb35682e
EZ
5341 * xdisp.c (handle_single_display_spec): Rename the
5342 display_replaced_before_p argument into display_replaced_p, to
5343 make it consistent with the commentary. Fix typos in the
5344 commentary.
5345
e2ad650c
EZ
5346 * textprop.c (syms_of_textprop): Remove dead code.
5347 (copy_text_properties): Delete obsolete commentary about an
5348 interface that was deleted long ago. Fix typos in the description
5349 of arguments.
5350
1b2de274
EZ
5351 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5352 to changes in oldXMenu/XMenu.h from 2011-04-16.
5353 <menu_help_message, prev_menu_help_message>: Constify.
5354 (IT_menu_make_room): menu->help_text is now `const char **';
5355 adjust.
5356
5357 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5358 to changes in oldXMenu/XMenu.h from 2011-04-16.
5359 (struct XMenu): Declare `help_text' `const char **'.
5360
5361 * xfaces.c <Qunspecified>: Make extern again.
5362
5363 * syntax.c: Include sys/types.h before including regex.h, as
5364 required by Posix.
5365
762b15be
EZ
5366 * doc.c (get_doc_string): Improve the format passed to `error'.
5367
5368 * doprnt.c (doprnt): Improve commentary.
5369
5370 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5371
5372 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5373 them with etags.
5374
f1052e5d
EZ
5375 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5376 changes in globals.h immediately force recompilation.
762b15be
EZ
5377 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5378 $(CURDIR)/s/ms-w32.h.
5379 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5380
fa6996bc
EZ
5381 * character.c (Fchar_direction): Function deleted.
5382 (syms_of_character): Don't defsubr it.
5383 <char-direction-table>: Deleted.
5384
e6c3da20
EZ
53852011-04-23 Eli Zaretskii <eliz@gnu.org>
5386
5387 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5388 * doprnt.c: Include limits.h.
5389 (SIZE_MAX): New macro.
04f2d78b
CB
5390 (doprnt): Return a size_t value. 2nd arg is now size_t.
5391 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5392 Improve overflow protection. Support `l' modifier for integer
5393 conversions. Support %l conversion. Don't assume an EMACS_INT
5394 argument for integer conversions and for %c.
5395
5396 * lisp.h (doprnt): Restore prototype.
5397
5398 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5399 $(SRC)/character.h.
5400
5401 * Makefile.in (base_obj): Add back doprnt.o.
5402
5403 * deps.mk (doprnt.o): Add back prerequisites.
5404 (callint.o): Depend on character.h.
5405
5406 * eval.c (internal_lisp_condition_case): Include the handler
5407 representation in the error message.
5408 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5409 when breaking from the loop.
5410
5411 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5412
5413 * callint.c (Fcall_interactively): When displaying error message
5414 about invalid control letter, pass the character's codepoint, not
5415 a pointer to its multibyte form. Improve display of the character
5416 in octal and display also its hex code.
5417
5418 * character.c (char_string): Use %x to display the (unsigned)
5419 codepoint of an invalid character, to avoid displaying a bogus
5420 negative value.
5421
5422 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5423 `error', not SYMBOL_NAME itself.
5424
5425 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5426 character arguments to `error'.
5427
5428 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5429 to `error' in error message about FINAL_CHAR argument. Make sure
5430 FINAL_CHAR is a character, and use %c when it is passed as
5431 argument to `error'.
5432
4ffd0d6b 54332011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5434
5435 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5436
5437 * w32.c: Include <time.h>.
5438 (sys_localtime): New function.
5439
4ffd0d6b 54402011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5441
5442 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5443
4ffd0d6b 5444 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5445
4ffd0d6b 54462011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5447
4ffd0d6b
GM
5448 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5449 zombies (Bug#8467).
aac0c6e3 5450
04c56954
EZ
54512011-04-19 Eli Zaretskii <eliz@gnu.org>
5452
5453 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5454 gl_state.e_property when gl_state.object is Qt.
5455
5456 * insdel.c (make_gap_larger): Remove limitation of buffer size
5457 to <= INT_MAX.
5458
16a43933
CY
54592011-04-18 Chong Yidong <cyd@stupidchicken.com>
5460
5461 * xdisp.c (lookup_glyphless_char_display)
5462 (produce_glyphless_glyph): Handle cons cell entry in
5463 glyphless-char-display.
5464 (Vglyphless_char_display): Document it.
5465
5466 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5467 glyphless-char-display.
5468
4581706e
CY
54692011-04-17 Chong Yidong <cyd@stupidchicken.com>
5470
5471 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5472
5473 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5474
5475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5476 definition for no-X builds.
5477
4887c6e2 54782011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5479
fd35b6f9
PE
5480 Static checks with GCC 4.6.0 and non-default toolkits.
5481
5c1ccb01
PE
5482 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5483
006c5daa
PE
5484 * process.c (keyboard_bit_set): Define only if SIGIO.
5485 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5486 (send_process): Repair possible setjmp clobbering.
5487
efc736d3
PE
5488 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5489
4e2fe2e6
PE
5490 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5491
f97334a2
PE
5492 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5493
4e75f29d
PE
5494 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5495 Define only if needed.
5496
90efadd1
PE
5497 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5498 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5499 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5500
3c647824
PE
5501 * dispextern.h (struct redisplay_interface): Rename param
5502 to avoid shadowing.
e264f262 5503 * termhooks.h (struct terminal): Likewise.
761383f4 5504 * xterm.c (xembed_send_message): Likewise.
3c647824 5505
b58c5c4a
PE
5506 * insdel.c (make_gap_smaller): Define only if
5507 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5508
cad59032
PE
5509 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5510 it.
5511
c339dc2e
PE
5512 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5513 so that we aren't warned about unused symbols.
5514
91a3e27b
PE
5515 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5516
399c71d3 5517 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5518
8ffc96f5
PE
5519 * xfns.c (x_real_positions): Mark locals as initialized.
5520
eef9bc79
PE
5521 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5522
098db9dd
PE
5523 * xterm.c: Fix problems found by static analysis with other toolkits.
5524 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5525 (x_dispatch_event): Declare static if USE_GTK, and
5526 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5527 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5528 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5529 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5530 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5531
eb18f6cc
PE
5532 * xmenu.c (menu_help_callback): Pointer type fixes.
5533 Use const pointers when pointing at readonly data. Avoid pointer
5534 signedness clashes.
5535 (FALSE): Remove unused macro.
5536 (update_frame_menubar): Remove unused decl.
5537
1fe72bf8
PE
5538 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5539
60d9e1db
PE
5540 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5541 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5542 (single_menu_item): Rename local to avoid shadowing.
5543
39261c26
PE
5544 * keyboard.c (make_lispy_event): Remove unused local var.
5545
018c5e19
PE
5546 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5547 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5548
63d2b86e
PE
5549 * bitmaps: Change bitmaps from unsigned char back to the X11
5550 compatible char. Avoid the old compiler warnings about
5551 out-of-range initializers by using, for example, '\xab' rather
5552 than 0xab.
5553
aefd87e1
PE
5554 * xgselect.c (xgselect_initialize): Check vs interface
5555 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5556
bf501fb9
PE
5557 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5558
e9829fdf
PE
5559 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5560 to read-only memory.
5561
1086c095
PE
5562 * fns.c (vector): Remove; this old hack is no longer needed.
5563
2baccd04 5564 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5565 Remove unused var.
dde42981 5566 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5567
72391843 5568 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5569
436c16df 5570 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5571 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5572 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5573
92bb796d 5574 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5575 (x_term_init): Remove local to avoid shadowing.
92bb796d 5576
764430a3 5577 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5578
5579 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5580 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5581
d1dfb56c
EZ
55822011-04-16 Eli Zaretskii <eliz@gnu.org>
5583
c4354cb4
EZ
5584 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5585
d1dfb56c
EZ
5586 Fix regex.c, syntax.c and friends for buffers > 2GB.
5587 * syntax.h (struct gl_state_s): Declare character position members
5588 EMACS_INT.
5589
5590 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5591
04f2d78b
CB
5592 * textprop.c (verify_interval_modification, interval_of):
5593 Declare arguments EMACS_INT.
d1dfb56c
EZ
5594
5595 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5596 EMACS_INT.
5597
5598 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5599
5600 * indent.c (Fvertical_motion): Local variable it_start is now
5601 EMACS_INT.
5602
5603 * regex.c (re_match, re_match_2, re_match_2_internal)
5604 (bcmp_translate, regcomp, regexec, print_double_string)
5605 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5606 (re_compile_pattern, re_exec): Declare arguments and local
5607 variables `size_t' and `ssize_t' and return values `regoff_t', as
5608 appropriate.
5609 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5610 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5611 <compile_stack_type>: `size' and `avail' are now `size_t'.
5612
5613 * regex.h <regoff_t>: Use ssize_t, not int.
5614 (re_search, re_search_2, re_match, re_match_2): Arguments that
5615 specify buffer/string position and length are now ssize_t and
5616 size_t. Return type is regoff_t.
5617
613052cd
BK
56182011-04-16 Ben Key <bkey76@gmail.com>
5619
5620 * nsfont.m: Fixed bugs in ns_get_family and
5621 ns_descriptor_to_entity that were caused by using free to
5622 deallocate memory blocks that were allocated by xmalloc (via
5623 xstrdup). This caused Emacs to crash when compiled with
5624 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5625 --enable-checking=xmallocoverrun). xfree is now used to
5626 deallocate these memory blocks.
5627
4170f62f 56282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5629
71b41406
PE
5630 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5631
9587a89d
PE
5632 emacs_write: Accept and return EMACS_INT for sizes.
5633 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5634 et seq.
5635 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5636 Accept and return EMACS_INT.
5637 (emacs_gnutls_write): Return the number of bytes written on
5638 partial writes.
5639 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5640 (emacs_read, emacs_write): Remove check for negative size, as the
5641 Emacs source code has been audited now.
9587a89d
PE
5642 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5643 (emacs_read, emacs_write): Use it.
273a5f82
PE
5644 * process.c (send_process): Adjust to the new signatures of
5645 emacs_write and emacs_gnutls_write. Do not attempt to store
5646 a byte offset into an 'int'; it might overflow.
9587a89d 5647 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5648
3e047f51
PE
5649 * sound.c: Don't assume sizes fit in 'int'.
5650 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5651 Return EMACS_INT, not int.
3e047f51 5652 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5653 Accept EMACS_INT, not int.
5654 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5655 record read return values.
5656
cc39a9db
BK
56572011-04-15 Ben Key <bkey76@gmail.com>
5658
c9d0ec6d
JB
5659 * keyboard.c (Qundefined): Don't declare static since it is used
5660 in nsfns.m.
5661 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5662 static since they are used in nsfont.m.
cc39a9db 5663
6c60eb9f
SM
56642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5665
5666 * process.c (Qprocessp): Don't declare static.
5667 * lisp.h (Qprocessp): Declare again.
5668
7990b61a
JB
56692011-04-15 Juanma Barranquero <lekktu@gmail.com>
5670
5671 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5672
5d4cb038
PE
56732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5674
8bd7b830 5675 Improve C-level modularity by making more things 'static'.
cd64ea1d 5676
e3b27b31
PE
5677 Don't publish debugger-only interfaces to other modules.
5678 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5679 (verify_bytepos, count_markers): Move decls to the only modules
5680 that need them.
5681 * region-cache.h (pp_cache): Likewise.
5682 * window.h (check_all_windows): Likewise.
5683 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5684
5d4cb038
PE
5685 * sysdep.c (croak): Now static, if
5686 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5687 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5688
5689 * alloc.c (refill_memory_reserve): Now static if
5690 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5691 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5692
e87b6180
PE
5693 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5694 Define only if USE_LUCID.
5695
ac64929e
PE
5696 * xrdb.c (x_customization_string, x_rm_string): Now static.
5697
6f37259d
PE
5698 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5699 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5700
1683e3ab
PE
5701 * xdisp.c (draw_row_with_mouse_face): Now static.
5702 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5703
de9c2632
PE
5704 * window.h (check_all_windows): Mark externally visible.
5705
2b96acb7
PE
5706 * window.c (window_deletion_count): Now static.
5707
5708 * undo.c: Make symbols static if they're not exported.
5709 (last_undo_buffer, last_boundary_position, pending_boundary):
5710 Now static.
5711
50436f33
PE
5712 * textprop.c (interval_insert_behind_hooks): Now static.
5713 (interval_insert_in_front_hooks): Likewise.
5714
64520e5c
PE
5715 * term.c: Make symbols static if they're not exported.
5716 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5717 (max_frame_lines, tty_set_terminal_modes):
5718 (tty_reset_terminal_modes, tty_turn_off_highlight):
5719 (get_tty_terminal): Now static.
5720 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5721 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5722 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5723 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5724 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5725
1fa53021
PE
5726 * sysdep.c: Make symbols static if they're not exported.
5727 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5728 Now static.
5729 (sigprocmask_set, full_mask): Remove; unused.
5730 (wait_debugging): Mark as visible.
5731 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5732 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5733
d4b43b22
PE
5734 * syntax.c (syntax_temp): Define only if !__GNUC__.
5735
b7c513d0
PE
5736 * sound.c (current_sound_device, current_sound): Now static.
5737
989b29ad
PE
5738 * search.c (searchbufs, searchbuf_head): Now static.
5739
13a55a78
PE
5740 * scroll.c (scroll_cost): Remove; unused.
5741 * dispextern.h (scroll_cost): Remove decl.
5742
de68a1fc
PE
5743 * region-cache.h (pp_cache): Mark as externally visible.
5744
40ccffa6
PE
5745 * process.c: Make symbols static if they're not exported.
5746 (process_tick, update_tick, create_process, chan_process):
5747 (Vprocess_alist, proc_buffered_char, datagram_access):
5748 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5749 (deactivate_process): Mark defn as static, as well as decl.
5750 * lisp.h (create_process): Remove decl.
5751 * process.h (chan_process, Vprocess_alist): Remove decls.
5752
ad64fc97
PE
5753 * print.c: Make symbols static if they're not exported.
5754 (print_depth, new_backquote_output, being_printed, print_buffer):
5755 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5756 (print_interval, print_number_index, initial_stderr_stream):
5757 Now static.
5758 * lisp.h (Fprinc): Remove decl.
5759 (debug_output_compilation_hack): Mark as externally visible.
5760
adddb265
PE
5761 * sysdep.c (croak): Move decl from here to syssignal.h.
5762 * syssignal.h (croak): Put it here, so the API can be checked when
5763 'croak' is called from dissociate_if_controlling_tty.
5764
1717ede2
PE
5765 * minibuf.c: Make symbols static if they're not exported.
5766 (minibuf_save_list, choose_minibuf_frame): Now static.
5767 * lisp.h (choose_minibuf_frame): Remove decl.
5768
fa5fb2bc
PE
5769 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5770
1e3890d1
PE
5771 * lread.c: Make symbols static if they're not exported.
5772 (read_objects, initial_obarray, oblookup_last_bucket_number):
5773 Now static.
5774 (make_symbol): Remove; unused.
5775 * lisp.h (initial_obarray, make_symbol): Remove decls.
5776
8a1414fa
PE
5777 * keyboard.c: Make symbols static if they're not exported.
5778 (single_kboard, recent_keys_index, total_keys, recent_keys):
5779 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5780 (this_single_command_key_start, echoing, last_auto_save):
5781 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5782 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5783 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5784 (Vlispy_mouse_stem, double_click_count):
5785 Now static.
5786 (force_auto_save_soon): Define only if SIGDANGER.
5787 (ignore_mouse_drag_p): Now static if
5788 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5789 (print_help): Remove; unused.
5790 (stop_character, last_timer_event): Mark as externally visible.
5791 * keyboard.h (ignore_mouse_drag_p): Declare only if
5792 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5793 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5794 * lisp.h (echoing): Remove decl.
5795 (force_auto_save_soon): Declare only if SIGDANGER.
5796 * xdisp.c (redisplay_window): Simplify code, to make it more
5797 obvious that ignore_mouse_drag_p is not accessed if !defined
5798 USE_GTK && !defined HAVE_NS.
5799
93ea6e8f
PE
5800 * intervals.c: Make symbols static if they're not exported.
5801 (merge_properties_sticky, merge_interval_right, delete_interval):
5802 Now static.
5803 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5804
77382fcc
PE
5805 * insdel.c: Make symbols static if they're not exported.
5806 However, leave prepare_to_modify_buffer alone. It's never
5807 called from outside this function, but that appears to be a bug.
5808 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5809 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5810 (adjust_after_replace_noundo): Remove; unused.
5811 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5812 (signal_before_change): Remove decls.
77382fcc 5813
9306c32e
PE
5814 * indent.c (val_compute_motion, val_vmotion): Now static.
5815
cd44d2eb
PE
5816 * image.c: Make symbols static if they're not exported.
5817 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5818 if USE_GTK.
5819 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5820 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5821
ad9a7a06
PE
5822 * fringe.c (standard_bitmaps): Now static.
5823 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5824
81626931
PE
5825 * frame.c: Make symbols static if they're not exported.
5826 (x_report_frame_params, make_terminal_frame): Now static.
5827 (get_frame_param): Now static, unless HAVE_NS.
5828 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5829 (x_get_resource_string): Remove; not used.
5830 * frame.h (make_terminal_frame, x_report_frame_params):
5831 (x_get_resource_string); Remove decls.
5832 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5833 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5834
239f9db9
PE
5835 * font.c, fontset.c: Make symbols static if they're not exported.
5836 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5837 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5838 * font.c (font_close_object): Now static.
5839 * font.h (font_close_object): Remove.
5840 * fontset.c (FONTSET_OBJLIST): Remove.
5841 (free_realized_fontset) #if-0 the body, which does nothing.
5842 (face_suitable_for_char_p): #if-0, as it's never called.
5843 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5844 * xfaces.c (face_at_string_position):
5845 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5846 since 0 is always ASCII.
5847
dfcf3579
PE
5848 * fns.c (weak_hash_tables): Now static.
5849
5045092b
PE
5850 * fileio.c: Make symbols static if they're not exported.
5851 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5852 (Vwrite_region_annotation_buffers): Now static.
5853
57a96f5c
PE
5854 * eval.c: Make symbols static if they're not exported.
5855 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5856 * lisp.h (backtrace_list): Remove decl.
5857
35f08c38
PE
5858 * emacs.c: Make symbols static if they're not exported.
5859 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5860 (fatal_error_code, fatal_error_signal_hook, standard_args):
5861 Now static.
5862 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5863 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5864 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5865 * lisp.h (fatal_error_signal_hook): Remove decl.
5866 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5867
f44bd759
PE
5868 * editfns.c: Move a (normally-unused) function to its only use.
5869 * editfns.c, lisp.h (get_operating_system_release): Remove.
5870 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5871 worth the hassle of breaking this out.
5872
b532497d
PE
5873 * xterm.c: Make symbols static if they're not exported.
5874 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5875 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5876 (x_destroy_window, x_delete_display):
5877 Now static.
5878 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5879 (x_mouse_leave): Remove; unused.
5880 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5881 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5882 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5883 Remove decls.
5884 (x_mouse_leave): Declare only if WINDOWSNT.
5885 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5886 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5887 USE_X_TOOLKIT.
5888
1675728f
PE
5889 * ftxfont.c: Make symbols static if they're not exported.
5890 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5891 HAVE_FREETYPE.
5892 * font.h (ftxfont_driver): Likewise.
5893
e4cebfca
PE
5894 * xfns.c: Make symbols static if they're not exported.
5895 (x_last_font_name, x_display_info_for_name):
5896 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5897 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5898 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5899 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5900 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5901 (last_show_tip_args): Now static.
5902 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5903 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5904 (x_screen_planes): Remove; unused.
5905 * dispextern.h (x_screen_planes): Remove decl.
5906
5bf46f05
PE
5907 * dispnew.c: Make symbols static if they're not exported.
5908 * dispextern.h (redraw_garbaged_frames, scrolling):
5909 (increment_row_positions): Remove.
5910 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5911 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5912 Now static.
5913 (redraw_garbaged_frames): Remove; unused.
5914
435f4c28
PE
5915 * xfaces.c: Make symbols static if they're not exported.
5916 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5917 Remove decls.
5918 * xterm.h (defined_color): Remove decls.
5919 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5920 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5921 (menu_face_changed_default, defined_color, free_realized_face):
5922 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5923 (ascii_face_of_lisp_face): Remove; unused.
5924
8524aef3
PE
5925 * xdisp.c: Make symbols static if they're not exported.
5926 * dispextern.h (scratch_glyph_row, window_box_edges):
5927 (glyph_to_pixel_coords, set_cursor_from_row):
5928 (get_next_display_element, set_iterator_to_next):
5929 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5930 (show_mouse_face): Remove decls
5931 * frame.h (message_buf_print): Likewise.
5932 * lisp.h (pop_message, set_message, check_point_in_composition):
5933 Likewise.
5934 * xterm.h (set_vertical_scroll_bar): Likewise.
5935 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5936 (message_buf_print, scratch_glyph_row, displayed_buffer):
5937 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5938 (get_next_display_element, show_mouse_face, window_box_edges):
5939 (frame_to_window_pixel_xy, check_point_in_composition):
5940 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5941 (glyph_to_pixel_coords): Remove; unused.
5942
16390cd2
PE
5943 * dired.c (file_name_completion): Now static.
5944
5945 * dbusbind.c (xd_in_read_queued_messages): Now static.
5946
a25f4dfa
PE
5947 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5948 * data.c (circular_list_error): Remove.
5949
14a9c8df
PE
5950 * commands.h (last_point_position, last_point_position_buffer):
5951 (last_point_position_window): Remove decls.
5952 * keyboard.c: Make these variables static.
5953
04f2d78b
CB
5954 * coding.h (coding, code_convert_region, encode_coding_gap):
5955 Remove decls.
74ab6df5
PE
5956 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5957 (iso_code_class, detect_coding, code_convert_region): Now static.
5958 (encode_coding_gap): Remove; unused.
5959
38dfbee1
PE
5960 * chartab.c (chartab_chars, chartab_bits): Now static.
5961
a2cb4e63
PE
5962 * charset.h (charset_iso_8859_1): Remove decl.
5963 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5964 Now static.
5965
127198fd
PE
5966 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5967 * ccl.c (Vccl_program_table): Now static.
5968 (check_ccl_update): Remove; unused.
5969
d85b608f
PE
5970 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5971 * category.h: ... from here.
5972 * category.c (check_category_table, set_category_set): Now static.
5973
31cd66f3
PE
5974 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5975 * lisp.h: Remove these decls.
5976
c358e587
PE
5977 * buffer.c (buffer_count): Remove unused var.
5978
e78aecca
PE
5979 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5980 so that it's not optimized away.
5981 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5982 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5983 exported only to the debugger.
5984
e192d7d3 5985 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5986 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5987
92470028
PE
5988 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5989 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5990 was inaccessible from Lisp.
5991 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5992 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5993
244ed907
PE
5994 alloc.c: Import and export fewer symbols, and remove unused items.
5995 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5996 is defined.
5997 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5998 it's not optimized away by whole-program optimization.
5999 (message_enable_multibyte, free_misc): Remove.
6000 (catchlist, handlerlist, mark_backtrace):
6001 Declare only if BYTE_MARK_STACK.
6002 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6003 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6004 (message_enable_multibyte): Remove decl.
6005 (free_misc, interval_free_list, float_block, float_block_index):
6006 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6007 (cons_free_list, last_marked_index):
6008 Now static.
6009 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6010 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6011 (mark_backtrace): Define only if BYTE_MARK_STACK.
6012 * xdisp.c (message_enable_multibyte): Now static.
6013
61c2b50e 6014 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6015 This makes it easier for human readers (and static analyzers)
6016 to see whether these variables are used from other modules.
6017 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6018 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6019 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6020 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6021 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6022 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6023 * xmenu.c, xselect.c:
6024 Declare Q* vars static if they are not used in other modules.
6025 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6026 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6027 Remove decls of unexported vars.
6028 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6029
95c82688
PE
6030 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6031
16a97296
PE
6032 Make Emacs functions such as Fatom 'static' by default.
6033 This makes it easier for human readers (and static analyzers)
6034 to see whether these functions can be called from other modules.
6035 DEFUN now defines a static function. To make the function external
6036 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6037 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6038 (Finit_image_library):
16a97296
PE
6039 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6040 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6041 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6042 Remove decls, since these functions are now static.
6043 (Funintern, Fget_internal_run_time): New decls, since these functions
6044 were already external.
95c82688 6045
16a97296
PE
6046 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6047 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6048 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6049 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6050 * keyboard.c, keymap.c, lread.c:
6051 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6052 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6053 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6054 Mark functions with DEFUE instead of DEFUN,
6055 if they are used in other modules.
6056 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6057 decls for now-static functions.
6058 * buffer.h (Fdelete_overlay): Remove decl.
6059 * callproc.c (Fgetenv_internal): Mark as internal.
6060 * composite.c (Fremove_list_of_text_properties): Remove decl.
6061 (Fcomposition_get_gstring): New forward static decl.
6062 * composite.h (Fcomposite_get_gstring): Remove decl.
6063 * dired.c (Ffile_attributes): New forward static decl.
6064 * doc.c (Fdocumntation_property): New forward static decl.
6065 * eval.c (Ffetch_bytecode): New forward static decl.
6066 (Funintern): Remove extern decl; now in .h file where it belongs.
6067 * fileio.c (Fmake_symbolic_link): New forward static decl.
6068 * image.c (Finit_image_library): New forward static decl.
6069 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6070 * intervals.h (Fprevious_property_change):
6071 (Fremove_list_of_text_properties): Remove decls.
6072 * keyboard.c (Fthis_command_keys): Remove decl.
6073 (Fcommand_execute): New forward static decl.
6074 * keymap.c (Flookup_key): New forward static decl.
6075 (Fcopy_keymap): Now static.
6076 * keymap.h (Flookup_key): Remove decl.
6077 * process.c (Fget_process): New forward static decl.
6078 (Fprocess_datagram_address): Mark as internal.
6079 * syntax.c (Fsyntax_table_p): New forward static decl.
6080 (skip_chars): Remove duplicate decl.
6081 * textprop.c (Fprevious_property_change): New forward static decl.
6082 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6083 Now internal.
6084 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6085 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6086
785bbd42
PE
6087 * editfns.c (Fformat): Remove unreachable code.
6088
8b913b57
AS
60892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6090
6091 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6092 change. (Bug#8496)
6093
a6744a35
EZ
60942011-04-13 Eli Zaretskii <eliz@gnu.org>
6095
6096 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6097 when at ZV. (Bug#8487)
6098
e7974947
AS
60992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6100
baad03f0
AS
6101 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6102 (Bug#8437)
6103 * keyboard.c (parse_tool_bar_item): Likewise.
6104 * sound.c (sound_cleanup, alsa_close): Likewise.
6105 * termcap.c (tgetent): Likewise.
6106 * xfns.c (x_default_font_parameter): Likewise.
6107 * xsettings.c (read_and_apply_settings): Likewise.
6108
e7974947
AS
6109 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6110 (overrun_check_free): Protoize.
6111
28272684
PE
61122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6113
6114 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6115 since callers should never pass a negative size.
6116 Change the signature to match that of plain 'read' and 'write'; see
6117 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6118 * lisp.h: Update prototypes of emacs_write and emacs_read.
6119
11997c76
EZ
61202011-04-11 Eli Zaretskii <eliz@gnu.org>
6121
6122 * xdisp.c (redisplay_window): Don't try to determine the character
6123 position of the scroll margin if the window start point w->startp
e896f03c 6124 is outside the buffer's accessible region. (Bug#8468)
11997c76 6125
8a2cbd72
EZ
61262011-04-10 Eli Zaretskii <eliz@gnu.org>
6127
6128 Fix write-region and its subroutines for buffers > 2GB.
6129 * fileio.c (a_write, e_write): Modify declaration of arguments and
6130 local variables to support buffers larger than 2GB.
6131 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6132
6133 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6134 argument, local variables, and return value.
6135
6136 * lisp.h: Update prototypes of emacs_write and emacs_read.
6137
6138 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6139
4073e537 61402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6141
1ebfdcb6
PE
6142 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6143
b2ded58d
PE
6144 Fix more problems found by GCC 4.6.0's static checks.
6145
7d66342c
PE
6146 * xdisp.c (vmessage): Use a better test for character truncation.
6147
bbf47d44
PE
6148 * charset.c (load_charset_map): <, not <=, for optimization,
6149 and to avoid potential problems with integer overflow.
9248994d 6150 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6151 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6152 * editfns.c (Fformat): Likewise.
1e69125e 6153 * syntax.c (skip_chars): Likewise.
3befa583 6154
e3019616
PE
6155 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6156 This also lets GCC 4.6.0 generate slightly better loop code.
6157
becfa255
PE
6158 * callint.c (Fcall_interactively): <, not <=, for optimization.
6159 (Fcall_interactively): Count the number of arguments produced,
6160 not the number of arguments given. This is simpler and lets GCC
6161 4.6.0 generate slightly better code.
6162
dae0cd48
PE
6163 * ftfont.c: Distingish more carefully between FcChar8 and char.
6164 The previous code passed unsigned char * to a functions like
6165 strlen and xstrcasecmp that expect char *, which does not
6166 conform to the C standard.
6167 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6168 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6169 char * when the C standard requires it.
6170
76032d70
PE
6171 * keyboard.c (read_char): Remove unused var.
6172
eb3f1cc8
PE
6173 * eval.c: Port to Windows vsnprintf (Bug#8435).
6174 Include <limits.h>.
6175 (SIZE_MAX): Define if the headers do not.
6176 (verror): Do not give up if vsnprintf returns a negative count.
6177 Instead, grow the buffer. This ports to Windows vsnprintf, which
6178 does not conform to C99. Problem reported by Eli Zaretskii.
6179 Also, simplify the allocation scheme, by avoiding the need for
6180 calling realloc, and removing the ALLOCATED variable.
6181
70476b54
PE
6182 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6183
12020a9e
PE
6184 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6185 But keep the doprint source code for now, as we might revamp it
6186 and use it again (Bug#8435).
ea6c7ae6
PE
6187 * lisp.h (doprnt): Remove.
6188 * Makefile.in (base_obj): Remove doprnt.o.
6189 * deps.mk (doprnt.o): Remove.
6190
5fdb398c
PE
6191 error: Print 32- and 64-bit integers portably (Bug#8435).
6192 Without this change, on typical 64-bit hosts error ("...%d...", N)
6193 was used to print both 32- and 64-bit integers N, which relied on
6194 undefined behavior.
6195 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6196 New macro.
6197 * lisp.h (error, verror): Mark as printf-like functions.
6198 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6199 Report overflow in size calculations when allocating printf buffer.
6200 Do not truncate output string at its first null byte.
6201 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6202 Truncate the output at a character boundary, since vsnprintf does not
6203 do that.
6204 * charset.c (check_iso_charset_parameter): Convert internal
6205 character to string before calling 'error', since %c now has the
6206 printf meaning.
6207 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6208 overflow when computing char to be passed to 'error'. Do not
6209 pass Lisp_Object to 'error'; pass the integer instead.
6210 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6211 formatted with plain %d.
6212
b189fa66
PE
6213 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6214
bff87ef0
PE
6215 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6216
7e2cac20
PE
6217 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6218
ce4d90b5
PE
6219 * xterm.c (x_catch_errors): Remove duplicate declaration.
6220
266c9547
PE
6221 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6222
79c49ad2
PE
6223 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6224
368f4090
JM
62252011-04-10 Jim Meyering <meyering@redhat.com>
6226
6227 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6228 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6229 return ssize_t not "int", and use size_t as the buffer length.
6230 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6231 * gnutls.h: Update declarations.
6232 * process.c (read_process_output): Use ssize_t, to match.
6233 (send_process): Likewise.
6234
a32d4040
CY
62352011-04-09 Chong Yidong <cyd@stupidchicken.com>
6236
6237 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6238
8546720e 62392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6240
04f2d78b
CB
6241 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6242 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6243
8546720e
GM
6244 * xterm.c (handle_one_xevent):
6245 * xmenu.c (create_and_show_popup_menu):
6246 * xselect.c (x_decline_selection_request)
6247 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6248
0a2f5c1a 62492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6250
6251 Fix some uses of `int' instead of EMACS_INT.
6252 * search.c (string_match_1, fast_string_match)
6253 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6254 (scan_buffer, find_next_newline_no_quit)
6255 (find_before_next_newline, search_command, Freplace_match)
6256 (Fmatch_data): Make some `int' variables be EMACS_INT.
6257
6258 * xdisp.c (display_count_lines): 3rd argument and return value now
6259 EMACS_INT. All callers changed.
6260 (pint2hrstr): Last argument is now EMACS_INT.
6261
6262 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6263 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6264 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6265 (decode_coding_utf_16, decode_coding_emacs_mule)
6266 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6267 (decode_coding_ccl, decode_coding_charset)
6268 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6269 (decode_coding_iso_2022, decode_coding_emacs_mule)
6270 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6271 <char_offset, last_offset>: Declare EMACS_INT.
6272 (encode_coding_utf_8, encode_coding_utf_16)
6273 (encode_coding_emacs_mule, encode_invocation_designation)
6274 (encode_designation_at_bol, encode_coding_iso_2022)
6275 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6276 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6277 Declare EMACS_INT.
6278 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6279 (encode_invocation_designation): Last argument P_NCHARS is now
6280 EMACS_INT.
6281 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6282 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6283
6284 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6285 All users changed.
6286
6287 * ccl.c (Fccl_execute_on_string): Declare some variables
6288 EMACS_INT.
6289
8546720e 62902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6291
6292 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6293
4e19a977
CS
62942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6295
6296 * process.c (Fformat_network_address): Doc fix.
6297
87302331
R
62982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6299
6300 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6301
cbb59342
CY
63022011-04-08 Chong Yidong <cyd@stupidchicken.com>
6303
6304 * keyboard.c (read_char): Call Lisp function help-form-show,
6305 instead of using internal_with_output_to_temp_buffer.
6306 (Qhelp_form_show): New var.
e0d38eeb 6307 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6308
6309 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6310
6311 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6312
e67a13ab
CY
63132011-04-06 Chong Yidong <cyd@stupidchicken.com>
6314
04f2d78b
CB
6315 * process.c (Flist_processes): Remove to Lisp.
6316 (list_processes_1): Delete.
e67a13ab 6317
973f782d
EZ
63182011-04-06 Eli Zaretskii <eliz@gnu.org>
6319
7c106b1e
EZ
6320 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6321
973f782d
EZ
6322 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6323
41cf7d1a 63242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6325
ca23cc88
PE
6326 Fix more problems found by GCC 4.6.0's static checks.
6327
f390e2d5
PE
6328 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6329
42eea0d0
PE
6330 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6331
b69769da 6332 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6333
f9541e84
PE
6334 * xdisp.c (vmessage): Mark as a printf-like function.
6335
13841b55
PE
6336 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6337
c136c10f
PE
6338 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6339
5e2d4a30
PE
6340 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6341 printf-like functions.
6342 (tiff_load): Add casts to remove these marks before passing them
6343 to system-supplied API.
6344
583f48b9
PE
6345 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6346
b25d760e
PE
6347 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6348 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6349 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6350 directly, rather than having caller test rule sign. This avoids
6351 some unnecessary tests.
6352 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6353 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6354 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6355
bc7b6697 6356 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6357 (xfont_open): Avoid unnecessary tests.
bc7b6697 6358
27ccc379
PE
6359 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6360
dcd5c89a
PE
6361 * composite.h, composite.c (composition_gstring_put_cache):
6362 Use EMACS_INT, not int, for length.
6363
b13a45c6
PE
6364 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6365 breaking out part of COMPOSITION_DECODE_RULE.
6366 (COMPOSITION_DECODE_RULE): Use it.
6367 * composite.c (get_composition_id): Remove unused local vars,
6368 by using the new macro.
6369
1e792e4d
PE
6370 * textprop.c (set_text_properties_1): Change while to do-while,
6371 since the condition is always true at first.
6372
dc6c6455 6373 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6374 (interval_deletion_adjustment): Return unsigned value.
6375 All uses changed.
dc6c6455 6376
aba7731a
PE
6377 * process.c (list_processes_1, create_pty, read_process_output):
6378 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6379 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6380 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6381 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6382 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6383
fdfc4bf3
PE
6384 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6385
fca8fe46 6386 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6387 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6388
06a0259a 6389 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6390 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6391 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6392
e7b9e80f
PE
6393 * print.c (print_error_message): Avoid int overflow.
6394
56201685
PE
6395 * font.c (font_list_entities): Redo for clarity,
6396 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6397
78834453 6398 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6399 (font_score): Avoid potential overflow in diff calculation.
78834453 6400
0bc0b309 6401 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6402 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6403
e610eaca
PE
6404 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6405
b895abce
PE
6406 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6407 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6408 can always succeed if overflow has undefined behavior.
6409
1f1d9321 6410 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6411 (wordify): Omit three unnecessary tests.
1f1d9321 6412
c59478bc
PE
6413 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6414 All callers changed. This avoids the need for an unused var.
6415
79b73827
PE
6416 * casefiddle.c (casify_region): Remove var that is set but not used.
6417
a4db5dfe
PE
6418 * dired.c (file_name_completion): Remove var that is set but not used.
6419
43aae36e
PE
6420 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6421
2a47c44d 6422 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6423 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6424
a37c69bf
PE
6425 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6426 Check for integer overflow on size calculations.
6427
328ab8e7
PE
6428 * buffer.c (Fprevious_overlay_change): Remove var that is set
6429 but not used.
6430
e5a2a5cb
PE
6431 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6432 Remove vars that are set but not used.
8d84a6eb 6433 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6434 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6435
a60e5f68
PE
6436 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6437
f661cb61 6438 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6439 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6440
f0397f5a
PE
6441 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6442 that are set but not used.
6443
8664db06 6444 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6445 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6446
6abdaa4a
PE
6447 * xselect.c (x_get_local_selection, x_handle_property_notify):
6448 Remove vars that are set but not used.
6449
0ce7538d 6450 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6451 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6452
9ae848fc
PE
6453 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6454 Remove var that is set but not used.
0b918413
PE
6455 (scroll_bar_windows_size): Now size_t, not int.
6456 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6457 Check for overflow.
9ae848fc 6458
a5a62657
PE
6459 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6460 (map_tty_color) [!defined MSDOS]: Likewise.
6461
5c5cdd39
PE
6462 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6463
66ebf983
PE
6464 * coding.c: Remove vars that are set but not used.
6465 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6466 All callers changed.
6467 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6468 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6469 (decode_coding_charset): Remove vars that are set but not used.
6470
1be4d761
PE
6471 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6472 that is set but not used.
6473
47553fa8
PE
6474 * print.c (print_object): Remove var that is set but not used.
6475
1f7196bf 6476 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6477 The gnulib version avoids calling malloc in the usual case,
6478 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6479 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6480 * filelock.c (current_lock_owner): Likewise.
6481 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6482 * sysdep.c: Include allocator.h, careadlinkat.h.
6483 (emacs_no_realloc_allocator): New static constant.
6484 (emacs_readlink): New function.
fdb61804
PE
6485 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6486 ../lib/careadlinkat.h.
d1fdcab7 6487
f84c17c7
SM
64882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6489
6490 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6491 first non-nil return value).
6492
ef3862ad
JD
64932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6494
6495 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6496 if not defined (Bug#8403).
6497
376a7006
JB
64982011-04-02 Juanma Barranquero <lekktu@gmail.com>
6499
6500 * xdisp.c (display_count_lines): Remove parameter `start',
6501 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6502 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6503 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6504 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6505 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6506 and thereabouts. All callers changed.
6507 (get_per_char_metric): Remove parameter `f', unused since
6508 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6509
6ca3801d
JM
65102011-04-02 Jim Meyering <meyering@redhat.com>
6511
6512 do not dereference NULL upon failed strdup
6513 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6514 (ns_get_family): Likewise.
6515
d8e2b5ba
JB
65162011-04-02 Juanma Barranquero <lekktu@gmail.com>
6517
6518 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6519
8c74fcbd
JD
65202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6521
6522 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6523 later (Bug#8403).
6524
7200d79c
SM
65252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6526
03408648 6527 Add lexical binding.
7200d79c 6528
03408648
SM
6529 * window.c (Ftemp_output_buffer_show): New fun.
6530 (Fsave_window_excursion):
6531 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6532
6533 * lread.c (lisp_file_lexically_bound_p): New function.
6534 (Fload): Bind Qlexical_binding.
6535 (readevalloop): Remove `evalfun' arg.
6536 Bind Qinternal_interpreter_environment.
6537 (Feval_buffer): Bind Qlexical_binding.
6538 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6539 Mark as dynamic.
6540 (syms_of_lread): Declare `lexical-binding'.
6541
6542 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6543
6544 * keyboard.c (eval_dyn): New fun.
6545 (menu_item_eval_property): Use it.
ca105506
SM
6546
6547 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6548
03408648
SM
6549 * fns.c (concat, mapcar1): Accept byte-code-functions.
6550
6551 * eval.c (Fsetq): Handle lexical vars.
6552 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6553 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6554 (FletX, Flet): Obey lexical binding.
6555 (Fcommandp): Handle closures.
6556 (Feval): New `lexical' arg.
6557 (eval_sub): New function extracted from Feval. Use it almost
6558 everywhere where Feval was used. Look up vars in lexical env.
6559 Handle closures.
6560 (Ffunctionp): Move from subr.el.
6561 (Ffuncall): Handle closures.
6562 (apply_lambda): Remove `eval_flags'.
6563 (funcall_lambda): Handle closures and new byte-code-functions.
6564 (Fspecial_variable_p): New function.
6565 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6566 but without exporting it to Lisp.
23aba0ea 6567
23aba0ea 6568 * doc.c (Fdocumentation, store_function_docstring):
03408648 6569 * data.c (Finteractive_form): Handle closures.
23aba0ea 6570
03408648
SM
6571 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6572 interactive spec.
ba83908c 6573
04f2d78b
CB
6574 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6575 New byte-codes.
03408648
SM
6576 (exec_byte_code): New function extracted from Fbyte_code to handle new
6577 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6578
03408648 6579 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6580
03408648 6581 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6582
e2abce01
JB
65832011-03-31 Juanma Barranquero <lekktu@gmail.com>
6584
6585 * xdisp.c (redisplay_internal): Fix prototype.
6586
63696a73 65872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6588
63696a73 6589 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6590 (try_scrolling): Use it when setting scroll_limit.
6591 Limit scrolling to 100 screen lines.
63696a73
EZ
6592 (redisplay_window): Even when falling back on "recentering",
6593 position point in the window according to scroll-conservatively,
6594 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6595
6596 (try_scrolling): When point is above the window, allow searching
6597 as far as scroll_max, or one screenful, to compute vertical
6598 distance from PT to the scroll margin position. This prevents
6599 try_scrolling from unnecessarily failing when
6600 scroll-conservatively is set to a value slightly larger than the
6601 window height. Clean up the case of PT below the margin at bottom
6602 of window: scroll_max can no longer be INT_MAX. When aggressive
6603 scrolling is in use, don't let point enter the opposite scroll
6604 margin as result of the scroll.
6605 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6606 threshold of 100 lines for never-recentering scrolling.
6607
e4cc2dfc
JB
66082011-03-31 Juanma Barranquero <lekktu@gmail.com>
6609
6610 * dispextern.h (move_it_by_lines):
6611 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6612 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6613 (message_log_check_duplicate): Remove parameters `prev_bol' and
6614 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6615 (redisplay_internal): Remove parameter `preserve_echo_area',
6616 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6617
6618 * indent.c (Fvertical_motion):
6619 * window.c (window_scroll_pixel_based, Frecenter):
6620 Don't pass `need_y_p' to `move_it_by_lines'.
6621
1c470562
SM
66222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6623
44f230aa
SM
6624 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6625 steal a few bits to be more compact.
6626 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6627 Remove unneeded casts.
6628
1c470562
SM
6629 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6630
888adce9
ZK
66312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6632
6633 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6634 binding" message (bug#7967).
6635
f838ed7b
PE
66362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6637
77861b95
PE
6638 Fix more problems found by GCC 4.6.0's static checks.
6639
de6dbc14
PE
6640 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6641 Remove unused local var.
6642
f838ed7b
PE
6643 * editfns.c (Fmessage_box): Remove unused local var.
6644
792c7b2b
PE
6645 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6646 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6647 Omit unused local vars.
c499e557 6648 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6649 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6650 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6651 Omit unused local var.
6652
ba0165e1
PE
6653 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6654 Don't assume string length fits in int.
32ad8845 6655 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6656 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6657
3c59b4c9
PE
6658 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6659 instead of alloca (Bug#8344).
6660
a3eed478 6661 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6662 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6663
eb4d412d
PE
6664 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6665
1658b401
PE
6666 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6667 concerns.
6668
6669 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6670
6671 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6672
9a2c6e05
PE
6673 * keyboard.c (syms_of_keyboard): Use the same style as later
6674 in this function when indexing through an array. This also
6675 works around GCC bug 48267.
6676
03d0a109
PE
6677 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6678
44f730c8
PE
6679 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6680
fe75f926
PE
6681 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6682 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6683
ffa8c828
PE
6684 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6685 This avoids undefined behavior on integer overflow, and is a bit
6686 more convenient anyway since it is compared to a size_t variable.
6687
c5101a77
PE
6688 Variadic C functions now count arguments with size_t, not int.
6689 This avoids an unnecessary limitation on 64-bit machines, which
6690 caused (substring ...) to crash on large vectors (Bug#8344).
6691 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6692 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6693 All variadic functions and their callers changed accordingly.
c5101a77
PE
6694 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6695 * data.c (arith_driver, float_arith_driver): Likewise.
6696 * editfns.c (general_insert_function): Likewise.
6697 * eval.c (struct backtrace.nargs, interactive_p)
6698 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6699 (funcall_lambda, mark_backtrace): Likewise.
6700 * fns.c (concat): Likewise.
6701 * frame.c (x_set_frame_parameters): Likewise.
6702 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6703 0 if not found, not -1. All callers changed.
6704
dd3f25f7
PE
6705 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6706 (stack_copy_size): Now size_t, not int.
6707 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6708
461c2ab9
JB
67092011-03-28 Juanma Barranquero <lekktu@gmail.com>
6710
6711 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6712 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6713 All callers changed.
6714
6715 * lisp.h (multibyte_char_to_unibyte):
6716 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6717 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6718 * character.h (CHAR_TO_BYTE8):
6719 * cmds.c (internal_self_insert):
6720 * editfns.c (general_insert_function):
6721 * keymap.c (push_key_description):
6722 * search.c (Freplace_match):
6723 * xdisp.c (message_dolog, set_message_1): All callers changed.
6724
f6d62986
SM
67252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6726
6727 * keyboard.c (safe_run_hook_funcall): New function.
6728 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6729 don't set the hook to nil, but remove the offending function instead.
6730 (Qcommand_hook_internal): Remove, unused.
6731 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6732 Vcommand_hook_internal.
6733
6734 * eval.c (enum run_hooks_condition): Remove.
6735 (funcall_nil, funcall_not): New functions.
6736 (run_hook_with_args): Call each function through a `funcall' argument.
6737 Remove `cond' argument, now redundant.
6738 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6739 (Frun_hook_with_args_until_failure): Adjust accordingly.
6740 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6741
1db5b1ad
JB
67422011-03-28 Juanma Barranquero <lekktu@gmail.com>
6743
6744 * dispextern.h (string_buffer_position): Remove declaration.
6745
6746 * print.c (strout): Remove parameter `multibyte', unused since
6747 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6748
6749 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6750 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6751 All callers changed.
6752
6753 * w32.c (_wsa_errlist): Use braces for struct initializers.
6754
6755 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6756 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6757 All callers changed.
6758 (string_buffer_position): Likewise. Also, make static (it's never
6759 used outside xdisp.c).
6760 (cursor_row_p): Remove parameter `w', unused since
6761 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6762 (decode_mode_spec): Remove parameter `precision', introduced during
6763 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6764 All callers changed.
6765
5ffb62aa
JD
67662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6767
6768 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6769
461c2ab9 67702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6771
6772 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6773 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6774 (ns_update_auto_hide_menu_bar): New functions.
6775 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6776 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6777 ns_constrain_all_frames.
6778 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6779 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6780
5c380ffb
JD
67812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6782
6783 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6784
9af30bdf
GM
67852011-03-27 Glenn Morris <rgm@gnu.org>
6786
6787 * syssignal.h: Replace RETSIGTYPE with void.
6788 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6789 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6790 Replace SIGTYPE with void everywhere.
6791 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6792 * s/template.h (SIGTYPE): Remove commented out definition.
6793
e2abce01
JB
67942011-03-26 Eli Zaretskii <eliz@gnu.org>
6795
6796 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6797 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6798
f868cd8a
JB
67992011-03-26 Juanma Barranquero <lekktu@gmail.com>
6800
59eb0929
JB
6801 * w32.c (read_unc_volume): Use parameter `henum', instead of
6802 global variable `wget_enum_handle'.
6803
6804 * keymap.c (describe_vector): Remove parameters `indices' and
6805 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6806 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6807
f868cd8a
JB
6808 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6809
6810 * keyboard.c (timer_check): Remove parameter `do_it_now',
6811 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6812 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6813 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6814
6815 * keyboard.c (read_char):
6816 * w32menu.c (w32_menu_display_help):
6817 * xmenu.c (show_help_event, menu_help_callback):
6818 Adjust calls to `show_help_echo'.
6819
6820 * gtkutil.c (xg_maybe_add_timer):
6821 * keyboard.c (readable_events):
6822 * process.c (wait_reading_process_output):
6823 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6824
6825 * insdel.c (adjust_markers_gap_motion):
6826 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6827 (gap_left, gap_right): Don't call it.
6828
2ecf6fdb
CY
68292011-03-25 Chong Yidong <cyd@stupidchicken.com>
6830
6831 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6832 incurred during fontification.
6833
6b1f9ba4
JB
68342011-03-25 Juanma Barranquero <lekktu@gmail.com>
6835
6836 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6837 (DEFVAR_PER_BUFFER): Don't pass it.
6838
6839 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6840 (scrolling_window): Don't pass it.
6841
0f4a96b5
JB
68422011-03-25 Juanma Barranquero <lekktu@gmail.com>
6843
6844 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6845
6846 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6847 and `suffix'.
6848 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6849 of variables specific to SELinux and computation of `encoded_absname'.
6850
6851 * image.c (XPutPixel): Remove unused variable `height'.
6852
6853 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6854
6855 * unexw32.c (get_section_info): Remove unused variable `section'.
6856
6857 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6858 (system_process_attributes): Remove unused variable `sess'.
6859 (sys_read): Remove unused variable `err'.
6860
6861 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6862 (w32_wnd_proc): Remove unused variable `isdead'.
6863 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6864 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6865 (x_create_tip_frame): Remove unused variable `tem'.
6866
6867 * w32inevt.c (w32_console_read_socket):
6868 Remove unused variable `no_events'.
6869
6870 * w32term.c (x_draw_composite_glyph_string_foreground):
6871 Remove unused variable `width'.
6872
1149507c
JB
68732011-03-24 Juanma Barranquero <lekktu@gmail.com>
6874
6875 * w32term.c (x_set_glyph_string_clipping):
6876 Don't pass uninitialized region to CombineRgn.
6877
9c88f339
JB
68782011-03-23 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6881 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6882 (Fx_close_connection): Remove unused variable `i'.
6883
6884 * w32font.c (w32font_draw): Return number of glyphs.
6885 (w32font_open_internal): Remove unused variable `i'.
6886 (w32font_driver): Add missing initializer.
6887
6888 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6889 (fill_in_menu): Remove unused variable `items_added'.
6890
6891 * w32term.c (last_mouse_press_frame): Remove static global variable.
6892 (w32_clip_to_row): Remove unused variable `f'.
6893 (x_delete_terminal): Remove unused variable `i'.
6894
6895 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6896 (NOTHING): Remove unused static global variable.
6897 (uniscribe_check_otf): Remove unused variable `table'.
6898 (uniscribe_font_driver): Add missing initializers.
6899
dee091a3
JD
69002011-03-23 Julien Danjou <julien@danjou.info>
6901
6902 * term.c (Fsuspend_tty, Fresume_tty):
6903 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6904 * window.c (temp_output_buffer_show):
6905 * insdel.c (signal_before_change):
6906 * frame.c (Fhandle_switch_frame):
6907 * fileio.c (Fdo_auto_save):
6908 * emacs.c (Fkill_emacs):
6909 * editfns.c (save_excursion_restore):
6910 * cmds.c (internal_self_insert):
6911 * callint.c (Fcall_interactively):
6912 * buffer.c (Fkill_all_local_variables):
6913 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6914 Use Frun_hooks.
0f4a96b5 6915 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6916 unconditionnaly since it does the check itself.
6917
2c520ab5 69182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6919
c9c49752
PE
6920 Fix more problems found by GCC 4.5.2's static checks.
6921
8abc3f12
PE
6922 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6923 the first time through the loop, since we know p0 < p1 then.
6924 This also avoids a gcc -Wstrict-overflow warning.
6925
a2d26660
PE
6926 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6927 leading to a memory leak, possible in functions like
6928 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6929 of objects (Bug#8318).
a2d26660 6930
916c72e9
PE
6931 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6932 that could (at least in theory) be that large.
6933
19ab8a18
PE
6934 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6935 This is less likely to overflow, and avoids undefined behavior if
6936 overflow does occur. All callers changed. Use strtoul to scan
6937 for the unsigned long integer.
b7cbbd6f
PE
6938 (pint2hrstr): Simplify and tune code slightly.
6939 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6940
f0641eff
PE
6941 * scroll.c (do_scrolling): Work around GCC bug 48228.
6942 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6943
7f650bb9
PE
6944 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6945 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6946 (validate_x_resource_name): Simplify count usage.
6947 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6948
37dd57d1
PE
6949 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6950 fail (Bug#8306).
81e56e61 6951
699979fc 6952 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6953
401bf9b4
PE
6954 * process.c (Fmake_network_process): Use socklen_t, not int,
6955 where POSIX says socklen_t is required in portable programs.
6956 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6957 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6958 (Fmake_network_process, server_accept_connection):
6959 (wait_reading_process_output, read_process_output):
6960 Likewise.
6961
b93aacde
PE
6962 * process.c: Rename or move locals to avoid shadowing.
6963 (list_processes_1, Fmake_network_process):
6964 (read_process_output_error_handler, exec_sentinel_error_handler):
6965 Rename or move locals.
4dc343ee 6966 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6967 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6968 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6969 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6970 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6971
af8a867c 6972 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6973 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6974 Include tparam.h instead, since it declares them.
af8a867c
PE
6975 * cm.h (PC): Remove extern decl; tparam.h now does this.
6976 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6977 * terminfo.c: Include tparam.h, to check interfaces.
6978 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6979 (tparam): Adjust signature to match interface in tparam.h;
6980 this removes some undefined behavior. Check that outstring and len
6981 are zero, which they always are with Emacs.
6982 * tparam.h (PC, BC, UP): New extern decls.
6983
0248044d 6984 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6985 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6986
8ff096c1 6987 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6988 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6989 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6990 (ftfont_list): Remove unused local.
49eaafba
PE
6991 (get_adstyle_property, ftfont_pattern_entity):
6992 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6993 Rename locals to avoid shadowing.
8ff096c1 6994
e2be39f6
PE
6995 * xfont.c (xfont_list_family): Mark var as initialized.
6996
c9735e30
PE
6997 * xml.c (make_dom): Now static.
6998
8f5201ae
PE
6999 * composite.c (composition_compute_stop_pos): Rename local to
7000 avoid shadowing.
b246f932
PE
7001 (composition_reseat_it): Remove unused locals.
7002 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7003 (composition_update_it): Mark var as initialized.
11b61122
PE
7004 (find_automatic_composition): Mark vars as initialized,
7005 with a FIXME (Bug#8290).
8f5201ae 7006
760fbc2c
PE
7007 character.h: Rename locals to avoid shadowing.
7008 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7009 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7010 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7011 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7012 to avoid shadowing.
7013
ff08eb85
PE
7014 * textprop.c (property_change_between_p): Remove; unused.
7015
fc7bf025
PE
7016 * intervals.c (interval_start_pos): Now static.
7017
235d7abc
PE
7018 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7019
44f230aa
SM
7020 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7021 Rename locals to avoid shadowing.
3e7d6594 7022
50060332
PE
7023 * sound.c (wav_play, au_play, Fplay_sound_internal):
7024 Fix pointer signedness.
d01f234b 7025 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7026 (wav_play): Initialize a variable to 0, to prevent undefined
7027 behavior (Bug#8278).
50060332 7028
c4fc4e30
PE
7029 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7030
918436ed
PE
7031 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7032
c939f91b
PE
7033 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7034 clobbering (Bug#8298).
b9c7f648
PE
7035 * sysdep.c (sys_subshell): Likewise.
7036 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7037
6bd8c144
PE
7038 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7039 This should get cleaned up, so that child_setup has the
7040 same signature on all platforms.
7041
7710357c 7042 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7043 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7044
c59da222
CY
70452011-03-22 Chong Yidong <cyd@stupidchicken.com>
7046
7047 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7048 not to be necessary, and produces flickering.
7049
66b87493
GM
70502011-03-20 Glenn Morris <rgm@gnu.org>
7051
7052 * config.in: Remove file.
7053
45b6f6d5
JB
70542011-03-20 Juanma Barranquero <lekktu@gmail.com>
7055
7056 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7057 are now in src/globals.h.
7058 (syms_of_minibuf): Remove spurious & from previous change.
7059
3ec03f7e
LL
70602011-03-20 Leo <sdl.web@gmail.com>
7061
7062 * minibuf.c (completing-read-function): New variable.
7063 (completing-read-default): Rename from completing-read.
7064 (completing-read): Call completing-read-function.
7065
b14e3e21
CY
70662011-03-19 Juanma Barranquero <lekktu@gmail.com>
7067
7068 * xfaces.c (Fx_load_color_file):
7069 Read color file from absolute filename (bug#8250).
7070
f2b726e6
JB
70712011-03-19 Juanma Barranquero <lekktu@gmail.com>
7072
7073 * makefile.w32-in: Update dependencies.
7074
09f6ff02
EZ
70752011-03-17 Eli Zaretskii <eliz@gnu.org>
7076
7077 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7078
29a6015a
PE
70792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7080
a3a6c54e
PE
7081 Fix more problems found by GCC 4.5.2's static checks.
7082
b766f867
PE
7083 * process.c (make_serial_process_unwind, send_process_trap):
7084 (sigchld_handler): Now static.
7085
be02381c
PE
7086 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7087 That way, the code declares only the vars that it needs.
7088 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7089 * s/cygwin.h (PTY_ITERATION): Likewise.
7090 * s/darwin.h (PTY_ITERATION): Likewise.
7091 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7092
57048744
PE
7093 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7094 * process.c (allocate_pty): Don't declare stb unless it's needed.
7095
7914961c 7096 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7097 (CONSTANTLIM): Remove; unused.
7098 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7099 Define only if needed.
7914961c 7100
b3967b18
PE
7101 * unexelf.c (unexec): Name an expression,
7102 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7103 Use a different way to cause a compilation error if anyone uses
7104 n rather than nn, a way that does not involve shadowing.
73366a00 7105 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7106
29a6015a
PE
7107 * deps.mk (unexalpha.o): Remove; unused.
7108
43cfc33e 7109 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7110 * unexec.h: New file.
ce701a33
PE
7111 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7112 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7113 Depend on unexec.h.
7114 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7115 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7116 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7117 Change as necessary to match prototype in unexec.h.
ce701a33 7118
01f44d5a
PE
7119 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7120 shadowing.
4f63c6bb 7121 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7122
a6670b0b
PE
7123 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7124 Rename locals to avoid shadowing.
7125
cef2010d 7126 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7127 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7128
d4d7173a
PE
7129 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7130
f08b802a
PE
7131 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7132 warning when compiling print.c.
7133
3ddb0639
PE
7134 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7135 instead of using an uninitialized var.
5ad03b97 7136 (font_sort_entities): Mark var as initialized.
3ddb0639 7137
170a2692
PE
7138 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7139
e663c700
PE
7140 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7141 pointers to constants.
89bc529a 7142 (font_parse_fcname): Remove unused vars.
7b81e2d0 7143 (font_delete_unmatched): Now static.
ea838e10 7144 (font_get_spec): Remove; unused.
13a547c6
PE
7145 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7146 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7147 Rename or move locals to avoid shadowing.
e663c700 7148
2a80c887 7149 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7150 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7151
1384fa33 7152 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7153 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7154
8b2c52e9
PE
7155 * alloc.c (mark_backtrace): Move decl from here ...
7156 * lisp.h: ... to here, so that it can be checked.
7157
475545b5 7158 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7159 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7160 (lisp_indirect_variable): Name an expression,
7161 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7162 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7163
b1349114 7164 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7165 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7166 Use const pointer when appropriate.
b1349114 7167
a2928364
PE
7168 * lisp.h (get_system_name, get_operating_system_release):
7169 Move decls here, to check interfaces.
7170 * process.c (get_operating_system_release): Move decl to lisp.h.
7171 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7172 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7173 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7174 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7175 (Fformat_time_string, Fencode_time, Finsert_char):
7176 (Ftranslate_region_internal, Fformat):
7177 Rename or remove local vars to avoid shadowing.
9710023e 7178 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7179
a415e694
PE
7180 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7181 avoid shadowing.
7182
8ef4622d
PE
7183 * lisp.h (eassert): Check that the argument compiles, even if
7184 ENABLE_CHECKING is not defined.
7185
946f9a5b
PE
7186 * data.c (Findirect_variable): Name an expression, to avoid
7187 gcc -Wbad-function-cast warning.
112396d6 7188 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7189 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7190 (Fmake_variable_buffer_local, Fmake_local_variable):
7191 Mark variables as initialized.
52746918 7192 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7193
e5aab7e7 7194 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7195 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7196 Rename locals to avoid shadowing.
dff45157
PE
7197 (mark_stack): Move local variables into the #ifdef region where
7198 they're used.
7bc26fdb
PE
7199 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7200 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7201 needed otherwise.
7202 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7203 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7204 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7205
e5aab7e7
PE
7206 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7207 avoids undefined behavior in theory.
7208
4da60324
PE
7209 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7210
88043301
PE
7211 Use functions, not macros, for up- and down-casing (Bug#8254).
7212 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7213 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7214 to use the following functions instead of these macros.
7215 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7216 EMACS_INT, since callers assume the returned value fits in int.
7217 (upcase1): Likewise, for UPCASE_TABLE.
7218 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7219 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7220 the race-condition problem in the old DOWNCASE.
88043301 7221
19ed5445
PE
7222 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7223 Rename locals to avoid shadowing.
7224 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7225 (regex_compile, re_search_2, re_match_2_internal):
7226 Remove unused local vars.
952db0d7
PE
7227 (FREE_VAR): Rewrite so as not to use empty "else",
7228 which gcc can warn about.
da053e48 7229 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7230 (RETALLOC_IF): Define only if needed.
7231 (WORDCHAR_P): Likewise. This one is never needed, but is used
7232 only in a comment talking about a compiler bug, so put inside
7233 the #if 0 of that comment.
7234 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7235 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7236 Remove; unused.
19ed5445 7237
1f3561e4 7238 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7239 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7240 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7241
ded6f8f7
PE
7242 * search.c (simple_search): Remove unused var.
7243
dbd37a95
PE
7244 * dired.c (compile_pattern): Move decl from here ...
7245 * lisp.h: ... to here, so that it can be checked.
7246 (struct re_registers): New forward decl.
7247
7e47afad
PE
7248 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7249
85f24f61
PE
7250 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7251 All uses changed.
7252 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7253 Rename locals to avoid shadowing.
5671df8f 7254 (Fvertical_motion): Mark locals as initialized.
85f24f61 7255
181aa2be 7256 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7257 (casify_region): Mark local as initialized.
181aa2be 7258
930d429c
PE
7259 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7260
7082eac6
PE
7261 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7262 New macros, so that the caller can use some names other than
7263 gcpro1, gcpro2, etc.
7264 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7265 of the new macros.
7266 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7267 argument, for consistency with GCPRO2_VAR, etc: it is now the
7268 prefix of the variable, not the variable itself. All uses
7269 changed.
38b2c076
PE
7270 * dired.c (directory_files_internal, file_name_completion):
7271 Rename locals to avoid shadowing.
7272
15206ed9
PE
7273 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7274 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7275 dired.c's scmp function, had undefined behavior.
7276 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7277 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7278 * buffer.h: ... to here, because these macros use current_buffer,
7279 and the new implementation with inline functions needs to have
7280 current_buffer in scope now, rather than later when the macros
7281 are used.
7282 (downcase, upcase1): New static inline functions.
7283 (DOWNCASE, UPCASE1): Reimplement using these functions.
7284 This avoids undefined behavior in expressions like
7285 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7286 from race conditions in accessing the global variables
7287 case_temp1 and case_temp2.
7288 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7289 * lisp.h (case_temp1, case_temp2): Remove their decls.
7290 * character.h (ASCII_CHAR_P): Move from here ...
7291 * lisp.h: ... to here, so that the inline functions mentioned
7292 above can use them.
7293
4a6bea26
PE
7294 * dired.c (directory_files_internal_unwind): Now static.
7295
f14b7e14
PE
7296 * fileio.c (file_name_as_directory, directory_file_name):
7297 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7298 Now static.
2893f146
PE
7299 (file_name_as_directory): Use const pointers when appropriate.
7300 (Fexpand_file_name): Likewise. In particular, newdir might
7301 point at constant storage, so make it a const pointer.
fd4ead52 7302 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7303 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7304 signedness issues.
f839df0c
PE
7305 (Fset_file_times, Finsert_file_contents, auto_save_error):
7306 Rename locals to avoid shadowing.
f14b7e14 7307
5716756e 7308 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7309 (Ftry_completion, Fall_completions): Rename or remove locals
7310 to avoid shadowing.
5716756e 7311
b4c3046a
PE
7312 * marker.c (bytepos_to_charpos): Remove; unused.
7313
b45db522
PE
7314 * lisp.h (verify_bytepos, count_markers): New decls,
7315 so that gcc does not warn that these functions aren't declared.
7316
85876d07
PE
7317 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7318 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7319 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7320 (copy_text): Remove unused local var.
85876d07 7321
03d78a21 7322 * filelock.c (within_one_second): Now static.
b3dd38ab 7323 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7324
5df8f01b
PE
7325 * buffer.c (fix_overlays_before): Mark locals as initialized.
7326 (fix_start_end_in_overlays): Likewise. This function should be
7327 simplified by using pointers-to-pointers, but that's a different
7328 matter.
b1d876f1 7329 (switch_to_buffer_1): Now static.
8f54f30a
PE
7330 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7331 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7332
a70072c9 7333 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7334 Fix pointer signedness issue.
edced198
PE
7335 (sys_subshell): Mark local as volatile if checking for lint,
7336 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7337 (MAXPATHLEN): Define only if needed.
a70072c9 7338
a0977c44
PE
7339 * process.c (serial_open, serial_configure): Move decls from here ...
7340 * systty.h: ... to here, so that they can be checked.
7341
a884fdcc
PE
7342 * fns.c (get_random, seed_random): Move extern decls from here ...
7343 * lisp.h: ... to here, so that they can be checked.
7344
604efe86 7345 * sysdep.c (reset_io): Now static.
b8950c94 7346 (wait_for_termination_signal): Remove; unused.
604efe86 7347
38fc62d9
PE
7348 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7349 (copy_keymap_item, append_key, push_text_char_description):
7350 Now static.
1004a21a 7351 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7352 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7353 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7354 (describe_map_tree):
7355 Rename locals to avoid shadowing.
38fc62d9 7356
2f2650da
PE
7357 * keyboard.c: Declare functions static if they are not used elsewhere.
7358 (echo_char, echo_dash, cmd_error, top_level_2):
7359 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7360 (read_char, kbd_buffer_get_event, make_lispy_position):
7361 (make_lispy_event, make_lispy_movement, apply_modifiers):
7362 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7363 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7364 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7365 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7366 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7367
a053e86c 7368 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7369 (mark_kboards): Move decl here ...
7370 * alloc.c (mark_kboards): ... from here.
a053e86c 7371
4752793e
PE
7372 * lisp.h (force_auto_save_soon): New decl.
7373
74f10ca7 7374 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7375 (DEFINE_DUMMY_FUNCTION): New macro.
7376 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7377 Use it.
c03cd23f
PE
7378 (main): Add casts to avoid warnings
7379 if GCC considers string literals to be constants.
74f10ca7 7380
022e70d4
PE
7381 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7382
59d6fe83
PE
7383 * dbusbind.c: Pointer signedness fixes.
7384 (xd_signature, xd_append_arg, xd_initialize):
7385 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7386 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7387 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7388 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7389
78320123
PE
7390 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7391 if GCC considers string literals to be constants.
49cebcca 7392 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7393
35ac2a97
SM
73942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7395
fb103ca9
SM
7396 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7397 (print_preprocess, print_object): New macro to fix last change.
7398
35ac2a97
SM
7399 * print.c (print_preprocess): Don't forget font objects.
7400
62973b41
JB
74012011-03-16 Juanma Barranquero <lekktu@gmail.com>
7402
7403 * emacs.c (USAGE3): Doc fixes.
7404
0e48bb22
AS
74052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7406
7407 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7408 structure.
7409
7684e57b
JB
74102011-03-14 Juanma Barranquero <lekktu@gmail.com>
7411
7412 * lisp.h (VWindow_system, Qfile_name_history):
7413 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7414 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7415 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7416
7417 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7418 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7419
7420 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7421 * w32console.c (detect_input_pending, read_input_pending)
7422 (encode_terminal_code):
7423 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7424 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7425 (w32_system_caret_y, Qfile_name_history):
7426 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7427 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7428 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7429 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7430 * w32proc.c (Qlocal, report_file_error):
7431 * w32term.c (Vwindow_system, updating_frame):
7432 * w32uniscribe.c (initialized, uniscribe_font_driver):
7433 Remove unneeded extern declarations.
7434
2aa46d6c
CY
74352011-03-14 Chong Yidong <cyd@stupidchicken.com>
7436
c96bbc66 7437 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7438
cffc6f3b
CY
74392011-03-13 Chong Yidong <cyd@stupidchicken.com>
7440
7441 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7442 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7443 These macros can no longer be used for assignment.
7444
44f230aa
SM
7445 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7446 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7447 (record_buffer_markers, fetch_buffer_markers): New functions for
7448 recording and fetching special buffer markers.
7449 (set_buffer_internal_1, set_buffer_temp): Use them.
7450
7451 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7452
7453 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7454
7455 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7456 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7457
7458 * xdisp.c (hscroll_window_tree):
7459 (reconsider_clip_changes): Use PT instead of BUF_PT.
7460
d251f04b
EZ
74612011-03-13 Eli Zaretskii <eliz@gnu.org>
7462
7463 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7464 $(EMACS_ROOT)/lib/intprops.h.
7465
f0c77cd1
PE
74662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7467
3eca4629
PE
7468 Fix more problems found by GCC 4.5.2's static checks.
7469
7c86ee98
PE
7470 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7471 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7472 (xg_free_frame_widgets): Make it clear that a local variable is
7473 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7474 (gdk_window_get_screen): Make it clear that this macro is needed
7475 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7476 (int_gtk_range_get_value): New function, which avoids a diagnostic
7477 from gcc -Wbad-function-cast.
7478 (xg_set_toolkit_scroll_bar_thumb): Use it.
7479 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7480 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7481 (get_utf8_string, xg_get_file_with_chooser):
7482 Rename locals to avoid shadowing.
7483 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7484
41729b81
PE
7485 * xgselect.c (xg_select): Remove unused var.
7486
f0c77cd1
PE
7487 * image.c (four_corners_best): Mark locals as initialized.
7488 (gif_load): Initialize transparent_p to zero (Bug#8238).
7489 Mark another local as initialized.
ec6cf4c6 7490 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7491
ce0ad53d 7492 * image.c (clear_image_cache): Now static.
d5d5a617 7493 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7494 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7495 (x_edge_detection): Remove unnecessary cast that
7496 gcc -Wbad-function-cast diagnoses.
2037898d 7497 (gif_load): Fix pointer signedness.
6ae141d6
PE
7498 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7499 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7500
33383987 75012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7502
d32df629
PE
7503 Improve quality of tests for time stamp overflow.
7504 For example, without this patch (encode-time 0 0 0 1 1
7505 1152921504606846976) returns the obviously-bogus value (-948597
7506 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7507 reports time overflow. See
7508 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7509 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7510 * editfns.c: Include limits.h and intprops.h.
7511 (TIME_T_MIN, TIME_T_MAX): New macros.
7512 (time_overflow): Move earlier, to before first use.
7513 (hi_time, lo_time): New functions, for an accurate test for
7514 out-of-range times.
7515 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7516 (Fget_internal_run_time): Don't assume time_t fits in int.
7517 (make_time): Use list2 instead of Fcons twice.
7518 (Fdecode_time): More accurate test for out-of-range times.
7519 (check_tm_member): New function.
7520 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7521 (lisp_time_argument): Don't rely on undefined left-shift and
7522 right-shift behavior when checking for time stamp overflow.
8be6f318 7523
fe31d94c
PE
7524 * editfns.c (time_overflow): New function, refactoring common code.
7525 (Fformat_time_string, Fdecode_time, Fencode_time):
7526 (Fcurrent_time_string): Use it.
7527
8be6f318
PE
7528 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7529 * dired.c (make_time): Move to ...
7530 * editfns.c (make_time): ... here.
7531 * systime.h: Note the move.
7532
09d9db2c 75332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7534
126bc0dc
YM
7535 * fringe.c (update_window_fringes): Remove unused variables.
7536
c47cbdfd
YM
7537 * unexmacosx.c (copy_data_segment): Also copy __got section.
7538 (Bug#8223)
7539
7ac80be9
EZ
75402011-03-12 Eli Zaretskii <eliz@gnu.org>
7541
c96bbc66 7542 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7543 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7544 Constify `char *' arguments and their references according to
7545 prototypes in tparam.h.
7546
ecb0f94d 7547 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7548
7ac80be9
EZ
7549 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7550 Adapt all references accordingly.
7551
7552 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7553
ef1fd07e
TT
75542011-03-11 Tom Tromey <tromey@redhat.com>
7555
7556 * buffer.c (syms_of_buffer): Remove obsolete comment.
7557
7ef4b50c
EZ
75582011-03-11 Eli Zaretskii <eliz@gnu.org>
7559
7560 * termhooks.h (encode_terminal_code): Declare prototype.
7561
7562 * msdos.c (encode_terminal_code): Don't declare prototype.
7563
7564 * term.c (encode_terminal_code): Now external again, used by
7565 w32console.c and msdos.c.
7566
44f230aa
SM
7567 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7568 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7569
4b1ec863 75702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7571
1714f52b 7572 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7573
4b1ec863
PE
7574 * fringe.c (update_window_fringes): Mark locals as initialized
7575 (Bug#8227).
7576 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7577
524c7aa6
PE
7578 * alloc.c (mark_fringe_data): Move decl from here ...
7579 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7580 to check its interface.
7581 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7582
a5c0af81 7583 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7584 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7585 (fontset_font): Mark local as initialized.
a9a06e0b 7586 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7587
b4716021
PE
7588 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7589
811e9bac 7590 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7591 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7592 (x_own_selection, Fx_disown_selection_internal): Rename locals
7593 to avoid shadowing.
7594 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7595
7e3ab302
PE
7596 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7597 so that the caller can use some name other than gcpro1.
7598 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7599 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7600 (Fx_backspace_delete_keys_p):
7601 Use them to avoid shadowing, and rename vars to avoid shadowing.
7602 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7603 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7604 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7605 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7606 Remove unused locals.
7e3ab302
PE
7607 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7608 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7609 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7610 macros.
f78faa98 7611
e2b13473
PE
7612 * xterm.h (x_mouse_leave): New decl.
7613
77f23912
PE
7614 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7615 Remove unused functions.
cdf4ba58
PE
7616 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7617 (x_calc_absolute_position): Now static.
7411c686 7618 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7619 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7620 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7621 unless they are used.
38d0b34a
PE
7622 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7623 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7624 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7625 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7626 (x_error_catcher, x_connection_closed, x_error_handler):
7627 (x_error_quitter, xembed_send_message, x_iconify_frame):
7628 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7629 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7630 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7631
44f230aa
SM
7632 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7633 Rename or move locals to avoid shadowing.
6b463e58 7634 (tty_defined_color, merge_face_heights): Now static.
5967d051 7635 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7636 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7637 does not deduce is never used uninitialized.
73719eba
PE
7638 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7639 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7640
426994c3 7641 * terminal.c (store_terminal_param): Now static.
5489860b 7642
032f1620 7643 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7644 (set_frame_menubar): Remove unused local.
d4323972 7645 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7646 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7647 since they might point to immutable storage.
281585b0
PE
7648 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7649 since it's unused otherwise.
032f1620 7650
367c19e5 7651 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7652 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7653 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7654 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7655 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7656 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7657 does not deduce are never used uninitialized.
70739cbe 7658
07b48fa9
PE
7659 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7660
8868a238 7661 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7662 * window.c (window_loop, size_window):
7663 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7664
7e5cf297 7665 * window.c (display_buffer): Now static.
d6550a9f
PE
7666 (size_window): Mark variables that gcc -Wuninitialized
7667 does not deduce are never used uninitialized.
a586633d
PE
7668 * window.h (check_all_windows): New decl, to forestall
7669 gcc -Wmissing-prototypes diagnostic.
5b555da1 7670 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7671
f6095868
PE
7672 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7673 shadowing.
7674 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7675 Include <limits.h>.
7676 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7677 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7678 (load_charset_map): Mark variables that gcc -Wuninitialized
7679 does not deduce are never used uninitialized.
53df7c11 7680 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7681
f38b440c
PE
7682 * coding.c (coding_set_source, coding_set_destination):
7683 Use "else { /* comment */ }" rather than "else /* comment */;"
7684 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7685 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7686 a block, when the outer 'i' will do.
7687 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7688 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7689 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7690 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7691 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7692 Rename locals to avoid shadowing.
7693 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7694 * coding.c (emacs_mule_char, encode_invocation_designation):
7695 Now static, since they're not used elsewhere.
413bb2db 7696 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7697 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7698 (decode_coding_emacs_mule): Mark variables that gcc
7699 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7700 (detect_coding_iso_2022): Initialize a local variable that might
7701 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7702 this initialization is needed. (Bug#8211)
5f58e762
PE
7703 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7704 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7705 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7706 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7707 Remove unused macros.
f38b440c 7708
232b38b9 7709 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7710 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7711 * character.c (string_count_byte8): Likewise.
232b38b9 7712
fb90da1b
PE
7713 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7714 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7715
fb93dbc2
PE
7716 * chartab.c (copy_sub_char_table): Now static, since it's not used
7717 elsewhere.
5c156ace
PE
7718 (sub_char_table_ref_and_range, char_table_ref_and_range):
7719 Rename locals to avoid shadowing.
bbcd0949 7720 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7721
7d3b3862 7722 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7723 (BIDI_BOB): Remove unused macro.
7d3b3862 7724
6be7d3da
PE
7725 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7726 deduce are never used uninitialized.
c2ed9c8b 7727 * term.c (encode_terminal_code): Likewise.
6be7d3da 7728
75f8807f 7729 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7730
50938595
PE
7731 * tparam.h: New file.
7732 * term.c, tparam.h: Include it.
7733 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7734 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7735 Move these decls to tparam.h, and make them agree with what
7736 is actually in tparam.c. The previous trick of using incompatible
7737 decls in different modules does not conform to the C standard.
7738 All callers of tparam changed to use tparam's actual API.
7739 * tparam.c (tparam1, tparam, tgoto):
7740 Use const pointers where appropriate.
7741
fbceeba2
PE
7742 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7743 * cm.h (struct cm): Likewise.
7744 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7745 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7746 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7747 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7748 (turn_on_face, init_tty): Likewise.
7749 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7750
7f3f1250
PE
7751 * term.c (term_mouse_position): Rename local to avoid shadowing.
7752
e6ca6543
PE
7753 * alloc.c (mark_ttys): Move decl from here ...
7754 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7755
c40f8d15
AS
77562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7757
7758 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7759
cfe0661d
JB
77602011-03-09 Juanma Barranquero <lekktu@gmail.com>
7761
7762 * search.c (compile_pattern_1): Remove argument regp, unused since
7763 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7764 (compile_pattern): Don't pass it.
7765
0afb4571
J
77662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7767
7768 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7769 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7770 for ! HAVE_GTK3.
7771 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7772
7773 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7774
7775 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7776 gdk_window_get_screen, gdk_window_get_geometry,
7777 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7778 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7779 (xg_get_pixbuf_from_pixmap): New function.
7780 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7781 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7782 Call xg_get_pixbuf_from_pixmap instead of
7783 gdk_pixbuf_get_from_drawable.
7784 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7785 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7786 (xg_check_special_colors): Use GtkStyleContext and its functions
7787 for HAVE_GTK3.
7788 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7789 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7790 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7791 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7792 Call gtk_widget_get_preferred_size.
0afb4571
J
7793 (xg_frame_resized): gdk_window_get_geometry only takes 5
7794 parameters.
44f230aa
SM
7795 (xg_win_to_widget, xg_event_is_for_menubar):
7796 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7797 (xg_set_widget_bg): New function.
7798 (delete_cb): New function.
895009e1 7799 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7800 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7801 (xg_set_background_color): Call xg_set_widget_bg.
7802 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7803 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7804 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7805 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7806 if ! HAVE_GTK3.
7807 (update_frame_tool_bar): Call gtk_widget_hide.
7808 (xg_initialize): Use GDK_KEY_g.
7809
7810 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7811 if ! HAVE_GTK3
7812 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7813
7814 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7815 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7816 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7817
1c2cc4ef
JB
78182011-03-08 Juanma Barranquero <lekktu@gmail.com>
7819
7820 * w32xfns.c (select_palette): Check success of RealizePalette against
7821 GDI_ERROR, not zero.
7822
33383987 7823See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7824
7825;; Local Variables:
7826;; coding: utf-8
aac0c6e3
MR
7827;; End:
7828
33383987 7829 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7830
7831 This file is part of GNU Emacs.
7832
7833 GNU Emacs is free software: you can redistribute it and/or modify
7834 it under the terms of the GNU General Public License as published by
7835 the Free Software Foundation, either version 3 of the License, or
7836 (at your option) any later version.
7837
7838 GNU Emacs is distributed in the hope that it will be useful,
7839 but WITHOUT ANY WARRANTY; without even the implied warranty of
7840 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7841 GNU General Public License for more details.
7842
7843 You should have received a copy of the GNU General Public License
7844 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.