nt/config.nt: Sync with autogen/config.in.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
48de8b12
CY
12012-09-30 Chong Yidong <cyd@gnu.org>
2
3 * fns.c (Frandom): Doc fix.
4
5938d519
MR
52012-09-30 Martin Rudalics <rudalics@gmx.at>
6
7 * window.c (Vwindow_combination_limit): New default value.
8 (Qwindow_size): New symbol replacing Qtemp_buffer_resize.
9
cb5b0266
PE
102012-09-30 Paul Eggert <eggert@cs.ucla.edu>
11
12 * syssignal.h (PROFILER_CPU_SUPPORT): Don't define if PROFILING.
13 Suggested by Eli Zaretskii in
14 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00811.html>.
15
84f72efd
EZ
162012-09-30 Eli Zaretskii <eliz@gnu.org>
17
18 * profiler.c (Fprofiler_cpu_stop): Use timer_settime only if
19 HAVE_TIMER_SETTIME is defined.
20
9d4dcdc9
PE
212012-09-30 Paul Eggert <eggert@cs.ucla.edu>
22
d89460ed
PE
23 Profiler improvements: more-accurate timers, overflow checks.
24 * profiler.c: Don't include stdio.h, limits.h, sys/time.h,
25 signal.h, setjmp.h. Include systime.h instead.
26 (saturated_add): New function.
27 (record_backtrace, current_sample_interval): Use EMACS_INT, not size_t.
28 (record_backtrace, handle_profiler_signal): Saturate on fixnum overflow.
29 (profiler_timer, profiler_timer_ok) [HAVE_TIMER_SETTIME]:
30 New static vars.
84f72efd 31 (enum profiler_cpu_running): New enum.
d89460ed
PE
32 (profiler_cpu_running): Now of that enum type, not bool.
33 All uses changed to store the new value.
34 (handle_profiler_signal): Rename from sigprof_handler_1,
35 for consistency with other handlers. Do not check whether
36 cpu_log is a hash-table if garbage collecting, since it
37 doesn't matter in that case.
38 (deliver_profiler_signal): Rename from sigprof_handler,
39 for consistency with other handlers.
40 (setup_cpu_timer): New function, with much of what used to be in
41 Fprofiler_cpu_start. Check for out-of-range argument.
42 Prefer timer_settime if available, and prefer
43 thread cputime clocks, then process cputime clocks, then
44 monotonic clocks, to the old realtime clock. Use make_timeval
45 to round more-correctly when falling back to setitimer.
46 (Fprofiler_cpu_start): Use it.
47 (Fprofiler_cpu_stop): Prefer timer_settime if available.
48 Don't assume that passing NULL as the 2nd argument of setitimer
49 is the same as passing a pointer to all-zero storage.
50 Ignore SIGPROF afterwards.
51 (malloc_probe): Saturate at MOST_POSITIVE_FIXNUM.
52 * sysdep.c (emacs_sigaction_init): Also mask out SIGPROF in
53 non-fatal signal handlers. Ignore SIGPROF on startup.
54 * syssignal.h (PROFILER_CPU_SUPPORT): Define this macro here, not
55 in profiler.c, since sysdep.c now uses it.
56
9d4dcdc9
PE
57 * sysdep.c (handle_fatal_signal): Bump backtrace size to 40.
58 Suggested by Eli Zaretskii in
59 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
60
8e5691a0
JB
612012-09-29 Juanma Barranquero <lekktu@gmail.com>
62
63 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
64
e7c1b6ef
SM
652012-09-29 Stefan Monnier <monnier@iro.umontreal.ca>
66
67 * lisp.h (struct backtrace): Remove indirection for `function' field.
68 * xdisp.c (redisplay_internal):
69 * profiler.c (record_backtrace, sigprof_handler_1):
70 * alloc.c (Fgarbage_collect):
71 * eval.c (interactive_p, Fsignal, eval_sub, Ffuncall, Fbacktrace)
72 (Fbacktrace_frame): Adjust accordingly.
73
e61d39cd 742012-09-28 Glenn Morris <rgm@gnu.org>
d393cefb
GM
75
76 * eval.c (Frun_hook_with_args, Frun_hook_with_args_until_success)
77 (Frun_hook_with_args_until_failure): Doc fixes.
78
404043ea
EZ
792012-09-28 Eli Zaretskii <eliz@gnu.org>
80
81 * xdisp.c (syms_of_xdisp) <Qredisplay_internal>: Rename from
82 Qautomatic_redisplay and change the symbol name. All users changed.
83
704d3f45
TM
842012-09-28 Tomohiro Matsuyama <tomo@cx4a.org>
85
86 * profiler.c (sigprof_handler): Fix race condition.
87
757140ff
GM
882012-09-28 Glenn Morris <rgm@gnu.org>
89
90 * lread.c (lisp_file_lexically_bound_p): Handle #! lines. (Bug#12528)
91
a615a3ae
PE
922012-09-27 Paul Eggert <eggert@cs.ucla.edu>
93
94 Check more robustly for timer_settime.
89d17fd0
PE
95 * Makefile.in (LIB_TIMER_TIME): New macro.
96 (LIBES): Add it.
a615a3ae
PE
97 * atimer.c (alarm_timer, alarm_timer_ok, set_alarm, init_atimer):
98 Use HAVE_TIMER_SETTIME, not SIGEV_SIGNAL, to decide whether to
99 call timer_settime.
100
3670daf7
TM
1012012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
102
103 * profiler.c (Fprofiler_cpu_start): Remove unnecessary flag SA_SIGINFO.
104
6a586b7f
JB
1052012-09-26 Juanma Barranquero <lekktu@gmail.com>
106
107 * makefile.w32-in ($(BLD)/profiler.$(O)): Update dependencies.
108
41c8bfcf
PE
1092012-09-26 Paul Eggert <eggert@cs.ucla.edu>
110
111 * character.h (MAYBE_UNIFY_CHAR): Remove.
112 * charset.c, charset.h (maybe_unify_char): Now static.
113 * charset.c (decode_char): Use maybe_unify_char, not MAYBE_UNIFY_CHAR.
114 Since this stuff is now private to charset.c, there's no need for
115 a public macro and no need to inline by hand.
116
3a880af4
SM
1172012-09-26 Tomohiro Matsuyama <tomo@cx4a.org>
118 Stefan Monnier <monnier@iro.umontreal.ca>
119 Juanma Barranquero <lekktu@gmail.com>
611b7507 120
3a880af4
SM
121 * profiler.c: New file.
122 * Makefile.in (base_obj): Add profiler.o.
611b7507
JB
123 * makefile.w32-in (OBJ2, GLOBAL_SOURCES): Add profiler.c.
124 ($(BLD)/profiler.$(O)): New target.
3a880af4
SM
125 * emacs.c (main): Call syms_of_profiler.
126 * alloc.c (Qautomatic_gc): New constant.
127 (MALLOC_PROBE): New macro.
128 (xmalloc, xzalloc, xrealloc, lisp_malloc, lisp_align_malloc): Use it.
129 (total_bytes_of_live_objects): New function.
130 (Fgarbage_collect): Use it. Record itself in backtrace_list.
131 Call malloc_probe for the memory profiler.
132 (syms_of_alloc): Define Qautomatic_gc.
133 * eval.c (eval_sub, Ffuncall): Reorder assignments to avoid
134 race condition.
135 (struct backtrace): Move definition...
136 * lisp.h (struct backtrace): ..here.
137 (Qautomatic_gc, profiler_memory_running): Declare vars.
138 (malloc_probe, syms_of_profiler): Declare functions.
139 * xdisp.c (Qautomatic_redisplay): New constant.
140 (redisplay_internal): Record itself in backtrace_list.
141 (syms_of_xdisp): Define Qautomatic_redisplay.
611b7507 142
5938d519 1432012-09-25 Eli Zaretskii <eliz@gnu.org>
b67238c2
JB
1442012-09-25 Juanma Barranquero <lekktu@gmail.com>
145
146 * makefile.w32-in ($(BLD)/callproc.$(O)): Update dependencies.
147
e26fd2e4
PE
1482012-09-25 Paul Eggert <eggert@cs.ucla.edu>
149
150 Prefer POSIX timers if available.
151 They avoid a race if the timer is too close to the current time.
152 * atimer.c (alarm_timer, alarm_timer_ok) [SIGEV_SIGNAL]: New static vars.
153 (set_alarm) [SIGEV_SIGNAL]: Use POSIX timers if available.
9180598c 154 (init_atimer) [SIGEV_SIGNAL]: Initialize them.
e26fd2e4 155
eedec3ee
EZ
1562012-09-25 Eli Zaretskii <eliz@gnu.org>
157
158 * coding.c (CHAR_STRING_ADVANCE_NO_UNIFY): Make it an alias of
159 CHAR_STRING_ADVANCE.
160 (STRING_CHAR_ADVANCE_NO_UNIFY): Make it an alias of
161 STRING_CHAR_ADVANCE.
162
aa15c6bb
JB
1632012-09-25 Juanma Barranquero <lekktu@gmail.com>
164
165 Move Vlibrary_cache to emacs.c and reset before dumping.
166
167 * lisp.h (reset_image_types): Declare.
168 [WINDOWSNT] (Vlibrary_cache): Declare.
169
170 * image.c (reset_image_types): New function.
171
172 * emacs.c [WINDOWSNT] (Vlibrary_cache): Move from w32.c.
173 (syms_of_emacs) [WINDOWSNT] <Vlibrary_cache>: Initialize and staticpro.
174 (Fdump_emacs): Reset Vlibrary_cache and image_types.
175
176 * w32.c (Vlibrary_cache): Do not define; moved to emacs.c
177 (globals_of_w32) <Vlibrary_cache>: Do not initialize.
178
179 * w32.h (Vlibrary_cache): Do not declare.
180
54d629be
EZ
1812012-09-25 Eli Zaretskii <eliz@gnu.org>
182
16b22fef
EZ
183 * w32proc.c (sys_signal): Handle all signals defined by the
184 MS-Windows runtime, not just SIGCHLD. Actually install the signal
185 handlers for signals supported by Windows. Don't override
186 term_ntproc as the handler for SIGABRT.
187 (sigaction): Rewrite to call sys_signal instead of duplicating its
188 code.
189 (sys_kill): Improve commentary.
190
191 * w32.c (term_ntproc): Accept (and ignore) one argument, for
192 consistency with a signature of a signal handler. All callers
193 changed.
194 (init_ntproc): Accept an argument DUMPING. If dumping, don't
195 install term_ntproc as a signal handler for SIGABRT, as that
196 should be done by the dumped Emacs.
197
198 * w32.h (init_ntproc, term_ntproc): Adjust prototypes.
199
200 * w32select.c (term_w32select): Protect against repeated
201 invocation by setting clipboard_owner to NULL after calling
202 DestroyWindow.
203
204 * emacs.c (shut_down_emacs, main): Adapt the calls to init_ntproc
205 and term_ntproc to their modified signatures.
206
54d629be
EZ
207 * character.c (char_string, string_char): Remove calls to
208 MAYBE_UNIFY_CHAR. See the discussion starting at
209 http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00433.html
210 for the details.
211
59f7af81
CY
2122012-09-25 Chong Yidong <cyd@gnu.org>
213
214 * xdisp.c (mode_line_inverse_video): Delete obsolete variable.
215
22e8cf4a
SM
2162012-09-24 Stefan Monnier <monnier@iro.umontreal.ca>
217
218 * bytecode.c (exec_byte_code): Signal an error instead of aborting,
219 when encountering an unknown bytecode.
220
578098f3
PE
2212012-09-24 Paul Eggert <eggert@cs.ucla.edu>
222
223 image.c, indent.c: Use bool for booleans.
224 * dispextern.h (struct image_type): Members valid_p, load, init
225 now return bool, not int. All uses changed.
226 * image.c: Omit unnecessary static decls.
227 (x_create_bitmap_mask, x_build_heuristic_mask):
228 Return void, not int, since callers don't care about the return value.
229 (x_create_bitmap_mask, define_image_type, valid_image_p)
230 (struct image_keyword, parse_image_spec, image_spec_value)
231 (check_image_size, image_background)
232 (image_background_transparent, x_clear_image_1)
233 (postprocess_image, lookup_image, x_check_image_size)
234 (x_create_x_image_and_pixmap, xbm_image_p)
235 (Create_Pixmap_From_Bitmap_Data, xbm_read_bitmap_data)
236 (xbm_load_image, xbm_file_p, xbm_load, xpm_lookup_color)
237 (init_xpm_functions, xpm_valid_color_symbols_p, xpm_image_p)
238 (xpm_load, xpm_load_image, lookup_rgb_color, lookup_pixel_color)
239 (x_to_xcolors, x_build_heuristic_mask, pbm_image_p, pbm_load)
240 (png_image_p, init_png_functions, png_load_body, png_load)
241 (jpeg_image_p, init_jpeg_functions, jpeg_load_body, jpeg_load)
242 (tiff_image_p, init_tiff_functions, tiff_load, gif_image_p)
243 (init_gif_functions, gif_load, imagemagick_image_p)
244 (imagemagick_load_image, imagemagick_load, svg_image_p)
245 (init_svg_functions, svg_load, svg_load_image, gs_image_p)
246 (gs_load):
247 * nsimage.m (ns_load_image):
248 * nsterm.m (ns_defined_color):
249 * xfaces.c (tty_lookup_color, tty_defined_color, defined_color):
250 * xfns.c (x_defined_color):
251 * xterm.c (x_alloc_lighter_color_for_widget)
252 (x_alloc_nearest_color_1, x_alloc_nearest_color)
253 (x_alloc_lighter_color):
254 * indent.c (disptab_matches_widthtab, current_column)
255 (scan_for_column, string_display_width, indented_beyond_p)
256 (compute_motion, vmotion, Fvertical_motion):
257 Use bool for booleans.
258
a5f2b6ec
CY
2592012-09-24 Chong Yidong <cyd@gnu.org>
260
261 * chartab.c (Fset_char_table_default): Obsolete function removed.
262
18e27ea8
PE
2632012-09-23 Paul Eggert <eggert@cs.ucla.edu>
264
afea8a8a
PE
265 Move pid_t related decls out of lisp.h.
266 * lisp.h, syswait.h (record_child_status_change, wait_for_termination)
267 (interruptible_wait_for_termination):
268 Move these decls from lisp.h to syswait.h, since they use pid_t.
269 Needed on FreeBSD; see Herbert J. Skuhra in
270 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00571.html>.
271 * callproc.c: Include syswait.h.
272
18e27ea8
PE
273 gnutls.c, gtkutil.c: Use bool for boolean.
274 * gnutls.c (gnutls_global_initialized, init_gnutls_functions)
275 (emacs_gnutls_handle_error):
276 * gtkutil.c (xg_check_special_colors, xg_prepare_tooltip)
277 (xg_hide_tooltip, xg_create_frame_widgets)
278 (create_dialog, xg_uses_old_file_dialog)
279 (xg_get_file_with_chooser, xg_get_file_with_selection)
280 (xg_get_file_name, xg_have_tear_offs, create_menus, xg_create_widget)
281 (xg_item_label_same_p, xg_update_menubar)
282 (xg_modify_menubar_widgets, xg_event_is_for_menubar)
283 (xg_ignore_gtk_scrollbar, xg_set_toolkit_scroll_bar_thumb)
284 (xg_event_is_for_scrollbar, xg_pack_tool_bar, xg_make_tool_item)
285 (is_box_type, xg_tool_item_stale_p, xg_update_tool_bar_sizes)
286 (update_frame_tool_bar, free_frame_tool_bar):
287 * gtkutil.c, w32term.c, xterm.c (x_wm_set_size_hint):
288 * nsmenu.m (ns_update_menubar):
289 * nsmenu.m, w32menu.c, xmenu.c (set_frame_menubar):
290 * xfns.c (Fx_show_tip) [USE_GTK]:
291 Use bool for boolean.
292 * gtkutil.c (xg_update_frame_menubar):
293 * xmenu.c (update_frame_menubar):
294 Return void, not int, since caller ignores return value.
295 * gtkutil.c (xg_change_toolbar_position):
296 Return void, not 1.
297
af0e9f75
JB
2982012-09-23 Juanma Barranquero <lekktu@gmail.com>
299
300 * makefile.w32-in (BLOCKINPUT_H): Remove.
301 (SYSSIGNAL_H): New macro.
302 ($(BLD)/alloc.$(O), $(BLD)/atimer.$(O), $(BLD)/buffer.$(O))
303 ($(BLD)/callproc.$(O), $(BLD)/data.$(O), $(BLD)/dired.$(O))
304 ($(BLD)/dispnew.$(O), $(BLD)/editfns.$(O), $(BLD)/emacs.$(O))
305 ($(BLD)/eval.$(O), $(BLD)/fileio.$(O), $(BLD)/floatfns.$(O))
306 ($(BLD)/fns.$(O), $(BLD)/fontset.$(O), $(BLD)/frame.$(O))
307 ($(BLD)/fringe.$(O), $(BLD)/image.$(O), $(BLD)/insdel.$(O))
308 ($(BLD)/keyboard.$(O), $(BLD)/keymap.$(O), $(BLD)/lread.$(O))
309 ($(BLD)/menu.$(O), $(BLD)/w32inevt.$(O), $(BLD)/w32proc.$(O))
310 ($(BLD)/print.$(O), $(BLD)/process.$(O), $(BLD)/ralloc.$(O))
311 ($(BLD)/search.$(O), $(BLD)/sound.$(O), $(BLD)/sysdep.$(O))
312 ($(BLD)/term.$(O), $(BLD)/window.$(O), $(BLD)/xdisp.$(O))
313 ($(BLD)/xfaces.$(O), $(BLD)/w32fns.$(O), $(BLD)/w32menu.$(O))
314 ($(BLD)/w32term.$(O), $(BLD)/w32select.$(O), $(BLD)/w32reg.$(O))
315 ($(BLD)/w32xfns.$(O)): Update dependencies.
316
5101529e
EZ
3172012-09-23 Eli Zaretskii <eliz@gnu.org>
318
319 * .gdbinit: Set breakpoint on terminate_due_to_signal, not on
320 fatal_error_backtrace.
321
322 * w32proc.c (sys_kill): Undo last change: don't do anything when
323 invoked to deliver SIGABRT to our own process. This is now
324 handled by emacs_raise.
325
2c3ee0ad
JB
3262012-09-23 Juanma Barranquero <lekktu@gmail.com>
327
328 * w32term.c (w32_read_socket): Remove leftover reference to
329 interrupt_input_pending.
330
62a1d661
PE
3312012-09-23 Paul Eggert <eggert@cs.ucla.edu>
332
333 Do not use SA_NODEFER.
334 Problem reported by Dani Moncayo in
335 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00557.html>.
336 * alloc.c (die):
337 * sysdep.c (emacs_abort): Do not reset signal handler.
338 * emacs.c (terminate_due_to_signal): Reset signal handler here.
339 * sysdep.c (init_signals): Do not use SA_NODEFER. It wasn't
340 wanted even on POSIXish hosts, and it doesn't work on Windows.
341
a0942b9a
JD
3422012-09-23 Jan Djärv <jan.h.d@swipnet.se>
343
344 * xterm.c (x_term_init): Call fixup_locale before and after calling
345 gtk_init (Bug#12392).
346
d07ff9db
CY
3472012-09-23 Chong Yidong <cyd@gnu.org>
348
349 * w32.c (w32_delayed_load): Remove LIBRARIES argument; always use
350 Vdynamic_library_alist.
351
352 * gnutls.c (init_gnutls_functions): Caller changed; remove arg.
353 (Fgnutls_available_p): Caller changed.
354
355 * xml.c (init_libxml2_functions, Flibxml_parse_html_region)
356 (Flibxml_parse_xml_region): Likewise.
357
358 * dispextern.h (struct image_type): Remove arg from init function.
359
360 * image.c (Finit_image_library, lookup_image_type)
361 (define_image_type): Remove now-unneeded second arg.
362 (init_xpm_functions, init_png_functions, init_jpeg_functions)
363 (init_tiff_functions, init_gif_functions, init_svg_functions):
364 Arglist and w32_delayed_load calling convention changed.
365 (gs_type): Remove init_gs_functions; there is no such function.
641cfd14 366 (valid_image_p, make_image): Fix caller to lookup_image_type.
d07ff9db 367
4d7e6e51
PE
3682012-09-23 Paul Eggert <eggert@cs.ucla.edu>
369
370 Simplify and avoid signal-handling races (Bug#12471).
371 * alloc.c (die):
372 * sysdep.c (emacs_abort) [HAVE_NTGUI]:
373 Avoid recursive loop if there's a fatal error in the function itself.
374 * atimer.c (pending_atimers):
375 * blockinput.h: Don't include "atimer.h"; no longer needed.
376 (interrupt_input_pending): Remove. All uses removed.
377 pending_signals now counts both atimers and ordinary interrupts.
378 This is less racy than having three separate pending-signal flags.
379 (block_input, unblock_input, totally_unblock_input, unblock_input_to)
380 (input_blocked_p):
381 Rename from their upper-case counterparts BLOCK_INPUT,
382 UNBLOCK_INPUT, TOTALLY_UNBLOCK_INPUT, UNBLOCK_INPUT_TO,
383 INPUT_BLOCKED_P, and turn into functions. All uses changed.
384 This makes it easier to access volatile variables more accurately.
385 (BLOCK_INPUT_RESIGNAL): Remove. All uses replaced by unblock_input ().
386 (input_blocked_p): Prefer this to 'interrupt_input_blocked', as
387 that's more reliable if the code is buggy and sets
388 interrupt_input_blocked to a negative value. All uses changed.
389 * atimer.c (deliver_alarm_signal):
390 Remove. No need to deliver this to the parent; any thread can
391 handle this signal now. All uses replaced by underlying handler.
392 * atimer.c (turn_on_atimers):
393 * dispnew.c (handle_window_change_signal):
394 * emacs.c (handle_danger_signal):
395 * keyboard.c (kbd_buffer_get_event):
396 Don't reestablish signal handler; not needed with sigaction.
397 * blockinput.h (UNBLOCK_INPUT_TO, TOTALLY_UNBLOCK_INPUT)
398 (UNBLOCK_INPUT_TO):
399 Rework to avoid unnecessary accesses to volatile variables.
400 (UNBLOCK_INPUT_TO): Now a function.
401 (totally_unblock_input, unblock_input): New decls.
402 * data.c (handle_arith_signal, deliver_arith_signal): Move to sysdep.c
403 (init_data): Remove. Necessary stuff now done in init_signal.
404 * emacs.c, xdisp.c: Include "atimer.h", since we invoke atimer functions.
405 * emacs.c (handle_fatal_signal, deliver_fatal_signal): Move to sysdep.c.
406 (fatal_error_code): Remove; no longer needed.
407 (terminate_due_to_signal): Rename from fatal_error_backtrace, since
408 it doesn't always backtrace. All uses changed. No need to reset
409 signal to default, since sigaction and/or die does that for us now.
410 Use emacs_raise (FOO), not kill (getpid (), FOO).
411 (main): Check more-accurately whether we're dumping.
412 Move fatal-error setup to sysdep.c
413 * floatfns.c: Do not include "syssignal.h"; no longer needed.
414 * gtkutil.c (xg_get_file_name, xg_get_font):
415 Remove no-longer-needed signal-mask manipulation.
416 * keyboard.c, process.c (POLL_FOR_INPUT):
417 Don't depend on USE_ASYNC_EVENTS, a symbol that is never defined.
418 * keyboard.c (read_avail_input): Remove.
419 All uses replaced by gobble_input.
420 (Ftop_level): Use TOTALLY_UNBLOCK_INPUT rather than open code.
421 (kbd_buffer_store_event_hold, gobble_input):
422 (record_asynch_buffer_change) [USABLE_SIGIO]:
423 (store_user_signal_events):
424 No need to mess with signal mask.
425 (gobble_input): If blocking input and there are terminals, simply
426 set pending_signals to 1 and return. All hooks changed to not
427 worry about whether input is blocked.
428 (process_pending_signals): Clear pending_signals before processing
429 them, in case a signal comes in while we're processing.
430 By convention callers now test pending_signals before calling us.
431 (UNBLOCK_INPUT_TO, unblock_input, totally_unblock_input):
432 New functions, to support changes to blockinput.h.
433 (handle_input_available_signal): Now extern.
434 (reinvoke_input_signal): Remove. All uses replaced by
435 handle_async_input.
436 (quit_count): Now volatile, since a signal handler uses it.
3a880af4
SM
437 (handle_interrupt): Now takes bool IN_SIGNAL_HANDLER as arg.
438 All callers changed. Block SIGINT only if not already blocked.
4d7e6e51
PE
439 Clear sigmask reliably, even if Fsignal returns, which it can.
440 Omit unnecessary accesses to volatile var.
441 (quit_throw_to_read_char): No need to restore sigmask.
442 * keyboard.c (gobble_input, handle_user_signal):
443 * process.c (wait_reading_process_output):
444 Call signal-handling code rather than killing ourselves.
445 * lisp.h: Include <float.h>, for...
446 (IEEE_FLOATING_POINT): New macro, moved here to avoid duplication.
447 (pending_signals): Now volatile.
448 (syms_of_data): Now const if IEEE floating point.
449 (handle_input_available_signal) [USABLE_SIGIO]:
450 (terminate_due_to_signal, record_child_status_change): New decls.
451 * process.c (create_process): Avoid disaster if memory is exhausted
452 while we're processing a vfork, by tightening the critical section
453 around the vfork.
454 (send_process_frame, process_sent_to, handle_pipe_signal)
455 (deliver_pipe_signal): Remove. No longer needed, as Emacs now
456 ignores SIGPIPE.
457 (send_process): No need for setjmp/longjmp any more, since the
458 SIGPIPE stuff is now gone. Instead, report an error if errno
459 is EPIPE.
460 (record_child_status_change): Now extern. PID and W are now args.
461 Return void, not bool. All callers changed.
462 * sysdep.c (wait_debugging) [(BSD_SYSTEM || HPUX) && !defined (__GNU__)]:
463 Remove. All uses removed. This bug should be fixed now in a
464 different way.
465 (wait_for_termination_1): Use waitpid rather than sigsuspend,
466 and record the child status change directly. This avoids the
467 need to futz with the signal mask.
468 (process_fatal_action): Move here from emacs.c.
469 (emacs_sigaction_flags): New function, containing
470 much of what used to be in emacs_sigaction_init.
471 (emacs_sigaction_init): Use it. Block nonfatal system signals that are
472 caught by emacs, to make races less likely.
473 (deliver_process_signal): Rename from handle_on_main_thread.
474 All uses changed.
475 (BACKTRACE_LIMIT_MAX): Now at top level.
476 (thread_backtrace_buffer, threadback_backtrace_pointers):
477 New static vars.
478 (deliver_thread_signal, deliver_fatal_thread_signal):
479 New functions, for more-accurate delivery of thread-specific signals.
480 (handle_fatal_signal, deliver_fatal_signal): Move here from emacs.c.
481 (deliver_arith_signal): Handle in this thread, not
482 in the main thread, since it's triggered by this thread.
483 (maybe_fatal_sig): New function.
484 (init_signals): New arg DUMPING so that we can be more accurate
485 about whether we're dumping. Caller changed.
486 Treat thread-specific signals differently from process-general signals.
487 Block all signals while handling fatal error; that's safer.
488 xsignal from SIGFPE only on non-IEEE hosts, treating it as fatal
489 on IEEE hosts.
490 When batch, ignore SIGHUP, SIGINT, SIGTERM if they were already ignored.
491 Ignore SIGPIPE unless batch.
492 (emacs_backtrace): Output backtrace for the appropriate thread,
493 which is not necessarily the main thread.
494 * syssignal.h: Include <stdbool.h>.
495 (emacs_raise): New macro.
496 * xterm.c (x_connection_signal): Remove; no longer needed
497 now that we use sigaction.
498 (x_connection_closed): No need to mess with sigmask now.
499 (x_initialize): No need to reset SIGPIPE handler here, since
500 init_signals does this for us now.
501
8f4635e9
JD
5022012-09-23 Jan Djärv <jan.h.d@swipnet.se>
503
504 * nsterm.m (ns_dumpglyphs_image): dr is a new rect to draw image into,
fb39b937 505 background rect may be larger (Bug#12245).
8f4635e9 506
3296976d
CY
5072012-09-23 Chong Yidong <cyd@gnu.org>
508
509 * keyboard.c (timer_check): Avoid quitting during Fcopy_sequence.
510
d41e491e
PE
5112012-09-22 Paul Eggert <eggert@cs.ucla.edu>
512
513 * .gdbinit: Just stop at fatal_error_backtrace.
514 See Stefan Monnier's request in
515 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00549.html>.
516 Remove no-longer-used query of system type.
517
c88b867f
CY
5182012-09-22 Chong Yidong <cyd@gnu.org>
519
520 * search.c (Freplace_match): Doc fix (Bug#12325).
521
522 * minibuf.c (Finternal_complete_buffer): Doc fix (Bug#12391).
523
524 * editfns.c (Fline_beginning_position): Doc fix (Bug#12416).
525 (Fline_end_position): Doc fix.
526
527 * cmds.c (Fforward_char, Fbackward_char): Doc fix (Bug#12414).
528
bb4d86b4
CY
5292012-09-22 Chong Yidong <cyd@gnu.org>
530
531 * dispextern.h (struct image_type): Add new slot, storing a type
532 initialization function.
533
534 * image.c (define_image_type): Call the image initializer function
535 if it is defined. Arguments and return value changed.
536 (valid_image_p, make_image): Callers changed.
537 (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
3a880af4
SM
538 (gif_type, imagemagick_type, svg_type, gs_type):
539 Add initialization functions.
bb4d86b4
CY
540 (Finit_image_library): Call lookup_image_type.
541 (CHECK_LIB_AVAILABLE): Macro deleted.
542 (lookup_image_type): Call define_image_type here, rather than via
543 Finit_image_library, and without using CHECK_LIB_AVAILABLE.
544 (syms_of_image): Move define_image_type calls for xbm_type and
545 pbm_type to lookup_image_type.
546
df9685f3
EZ
5472012-09-22 Eli Zaretskii <eliz@gnu.org>
548
549 * keyboard.c (timer_check_2): Move calculation of 'timers' and
550 'idle_timers' from here ...
551 (timer_check): ... to here. Use Fcopy_sequence to copy the timer
552 lists, to avoid infloops when the timer does something stupid,
553 like reinvoke itself with the same or smaller time-out.
554 (Bug#12447)
555
8e17c9ba
MR
5562012-09-22 Martin Rudalics <rudalics@gmx.at>
557
558 * window.c (Fsplit_window_internal): Handle only Qt value of
559 Vwindow_combination_limit separately.
560 (Qtemp_buffer_resize): New symbol.
3a880af4
SM
561 (Vwindow_combination_limit): New default value.
562 Rewrite doc-string.
8e17c9ba 563
589bd69b
EZ
5642012-09-22 Eli Zaretskii <eliz@gnu.org>
565
566 * xdisp.c (next_overlay_string): Initialize it->end_charpos for
567 the new overlay string. (Bug#10159)
568
01108e3f
PE
5692012-09-22 Paul Eggert <eggert@cs.ucla.edu>
570
571 * emacs.c (shut_down_emacs): Don't assume stderr is buffered,
572 or that fprintf is async-signal-safe. POSIX doesn't require
573 either assumption.
574
82f8cd94
CY
5752012-09-22 Chong Yidong <cyd@gnu.org>
576
577 * buffer.c (Fset_buffer_modified_p): Handle indirect buffers
578 (Bug#8207).
579
3cccbd87
KH
5802012-09-22 Kenichi Handa <handa@gnu.org>
581
582 * composite.c (composition_reseat_it): Handle the case that a
583 grapheme cluster is not covered by a single font (Bug#12352).
584
09c01941
CY
5852012-09-21 Chong Yidong <cyd@gnu.org>
586
587 * image.c (define_image_type): Avoid adding duplicate types to
588 image_types (Bug#12463). Suggested by Jörg Walter.
589
acfa068f 5902012-09-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
e25c1a30
YM
591
592 * unexmacosx.c: Define LC_DATA_IN_CODE if not defined.
593 (print_load_command_name): Add case LC_DATA_IN_CODE.
594 (dump_it) [LC_DATA_IN_CODE]: Call copy_linkedit_data.
595
acfa068f 5962012-09-21 Glenn Morris <rgm@gnu.org>
1e9bbf47
GM
597
598 * eval.c (Frun_hook_with_args_until_success)
599 (Frun_hook_with_args_until_failure): Doc fixes. (Bug#12393)
600
acfa068f 6012012-09-21 Andreas Schwab <schwab@linux-m68k.org>
c6ba4138
AS
602
603 * fileio.c (Ffile_selinux_context): Only call freecon when
604 lgetfilecon succeeded.
605 (Fset_file_selinux_context): Likewise. (Bug#12444)
606
acfa068f 6072012-09-21 Eli Zaretskii <eliz@gnu.org>
aa36e4d2
EZ
608
609 * xdisp.c (try_window_reusing_current_matrix): Under bidi
610 reordering, locate the cursor by calling set_cursor_from_row; if
611 that fails, clear the desired glyph matrix before returning a
612 failure indication to the caller. Fixes leaving garbled display
613 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
614 (compute_stop_pos_backwards): Fix a typo that caused crashes while
615 scrolling through multibyte text.
aa36e4d2 616
e99f70c8
SM
6172012-09-20 Stefan Monnier <monnier@iro.umontreal.ca>
618
619 * alloc.c (mark_object) <PVEC_WINDOW>: Mark prev/next_buffers *after*
620 calling mark_vectorlike since that's the one that marks the window.
621 (mark_discard_killed_buffers): Mark the final cdr.
622 * window.h (struct window): Move prev/next_buffers to the
623 non-standard fields.
624 * window.c (make_window): Initialize prev/next_buffers manually.
625
f75beb47
PE
6262012-09-20 Paul Eggert <eggert@cs.ucla.edu>
627
628 Omit unused arg EXPECTED from socket hooks.
629 * keyboard.c (gobble_input, read_avail_input, tty_read_avail_input):
630 * nsterm.m (ns_term_init):
631 * termhooks.h (struct terminal.read_socket_hook):
632 * w32inevt.c (w32_console_read_socket):
633 * w32term.c (w32_read_socket):
634 * xterm.c (XTread_socket):
635 Omit unused arg EXPECTED. All callers changed.
636 (store_user_signal_events): Return void, not int, since callers no
637 longer care about the return value. All uses changed.
638
b019b76a
JB
6392012-09-20 Juanma Barranquero <lekktu@gmail.com>
640
641 * w32gui.h (XParseGeometry): Do not declare.
642
05642592
PE
6432012-09-19 Paul Eggert <eggert@cs.ucla.edu>
644
e4bce92a
PE
645 * w32inevt.c (w32_console_read_socket): Return -1 on failure, not 0.
646 Ignore 'expected'. See Eli Zaretskii in
647 <http://bugs.gnu.org/12471#8> (last line).
648
05642592
PE
649 * frame.c (read_integer): Remove. All uses replaced by strtol/strtoul.
650 (XParseGeometry): Now static. Substitute extremal values for
651 values that are out of range.
652
e543ae91
JD
6532012-09-19 Jan Djärv <jan.h.d@swipnet.se>
654
655 * w32xfns.c (read_integer, XParseGeometry): Move to frame.c.
656
657 * nsfns.m (XParseGeometry): Remove.
658 (Fx_create_frame): Call x_set_offset to correctly interpret
659 top_pos in geometry.
660
3a880af4 661 * frame.c (read_integer, XParseGeometry): Move from w32xfns.c.
e543ae91
JD
662 (Fx_parse_geometry): If there is a space in string, call
663 Qns_parse_geometry, otherwise do as on other terms (Bug#12368).
664
45ba16c7
EZ
6652012-09-17 Eli Zaretskii <eliz@gnu.org>
666
c8b9f1bc
EZ
667 * search.c (scan_buffer): Use character positions in calls to
668 region_cache_forward and region_cache_backward, not byte
669 positions. (Bug#12196)
670
b4c932a2
EZ
671 * w32term.c (w32_read_socket): Set pending_signals to 1, like
672 xterm.c does. Reported by Daniel Colascione <dancol@dancol.org>.
673
45ba16c7
EZ
674 * ralloc.c (r_alloc_init) [!SYSTEM_MALLOC]: Initialize
675 __malloc_extra_blocks to 32 instead of 64, like alloc.c did in
676 emacs_blocked_malloc, now deleted.
677
eeceac93
PE
6782012-09-17 Paul Eggert <eggert@cs.ucla.edu>
679
680 Remove no-longer-needed Solaris 2.4 vfork bug workaround.
681 The workaround was for improving performance on Solaris 2.4, but
682 is getting in the way now. Emacs will still work if someone is
683 still running Solaris 2.4 in a museum somewhere; Sun dropped
684 support for Solaris 2.4 in 2003.
685 * callproc.c (Fcall_process) [HAVE_WORKING_VFORK]:
686 * process.c (create_process) [HAVE_WORKING_VFORK]:
687 Omit now-unnecessary workaround for the Solaris 2.4 vfork bug,
688 since Emacs no longer uses vfork on that platform.
689
78f83752
GM
6902012-09-17 Glenn Morris <rgm@gnu.org>
691
692 * emacs.c: Use COPYRIGHT.
693
634b8cac
PE
6942012-09-16 Paul Eggert <eggert@cs.ucla.edu>
695
0caaedb1
PE
696 Remove configure's --without-sync-input option (Bug#12450).
697 When auditing signal-handling in preparation for cleaning it up,
698 I found that SYNC_INPUT has race conditions and would be a real
699 pain to fix. Since it's an undocumented and deprecated
700 configure-time option, now seems like a good time to remove it.
701 Also see <http://bugs.gnu.org/11080#16>.
702 * alloc.c (_bytes_used, __malloc_extra_blocks, _malloc_internal)
703 (_free_internal) [!DOUG_LEA_MALLOC]: Remove decls.
704 (alloc_mutex) [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
705 (malloc_hysteresis):
706 (check_depth) [XMALLOC_OVERRUN_CHECK]:
707 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT):
708 (__malloc_hook, __realloc_hook, __free_hook, BYTES_USED)
709 (dont_register_blocks, bytes_used_when_reconsidered)
710 (bytes_used_when_full, emacs_blocked_free, emacs_blocked_malloc)
711 (emacs_blocked_realloc, reset_malloc_hooks, uninterrupt_malloc):
712 [!SYSTEM_MALLOC && !SYNC_INPUT]:
713 Remove. All uses removed.
714 (MALLOC_BLOCK_INPUT, MALLOC_UNBLOCK_INPUT): Use a different
715 implementation, one that depends on whether the new macro
716 XMALLOC_BLOCK_INPUT_CHECK is defined, not on whether SYNC_INPUT
717 is defined.
718 * atimer.c (run_timers, handle_alarm_signal):
719 * keyboard.c (pending_signal, poll_for_input_1, poll_for_input)
720 (handle_async_input, process_pending_signals)
721 (handle_input_available_signal, init_keyboard):
722 * nsterm.m (ns_read_socket):
723 * process.c (wait_reading_process_output):
724 * regex.c (immediate_quit, IMMEDIATE_QUIT_CHECK):
725 * sysdep.c (emacs_sigaction_init) [SA_RESTART]:
726 (emacs_write):
727 * xterm.c (XTread_socket):
728 Assume SYNC_INPUT.
729 * conf_post.h (SA_RESTART) [IRIX6_5]: Do not #undef.
730 * eval.c (handling_signal): Remove. All uses removed.
731 * lisp.h (ELSE_PENDING_SIGNALS): Remove.
732 All uses replaced with the SYNC_INPUT version.
733 (reset_malloc_hooks, uninterrupt_malloc, handling_signal):
734 Remove decls.
735 * sysdep.c, syssignal.h (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
736 Now static.
737
634b8cac
PE
738 * font.c (Ffont_shape_gstring): Remove unused local.
739
83da1b55
GM
7402012-09-16 Glenn Morris <rgm@gnu.org>
741
518650a5
GM
742 * Makefile.in (clean): No longer run nextstep's clean.
743
83da1b55
GM
744 * Makefile.in (ns_appdir, ns_appbindir, ns_appsrc): Remove variables.
745 (ns_frag): Remove.
746 (ns-app): Move here from ns.mk, and simplify.
747 (clean): Simplify nextstep entry.
748 * ns.mk: Remove file.
749
85a43e2e
KH
7502012-09-17 Kenichi Handa <handa@gnu.org>
751
752 * font.c (Ffont_shape_gstring): Fix previous change; GLYPHs may
753 not covert the last few charactes.
754
ba13e616 7552012-09-16 Kenichi Handa <handa@gnu.org>
ea964864
KH
756
757 * font.c (Ffont_shape_gstring): Don't adjust grapheme cluster
758 here, but just check the validity of glyphs in the glyph-string.
759
a8c729af
MR
7602012-09-16 Martin Rudalics <rudalics@gmx.at>
761
3a880af4
SM
762 * window.c (Fwindow_parameter, Fset_window_parameter):
763 Accept any window as argument (Bug#12452).
a8c729af 764
c077c059
JD
7652012-09-16 Jan Djärv <jan.h.d@swipnet.se>
766
767 * nsfns.m (Fx_open_connection): Move initialization of ns_*_types
768 to ns_term_init to avoid memory leak.
769
770 * nsterm.m (ns_update_begin): Initialize bp after lcokFocus, use
771 explicit retain/release.
772 (ns_term_init): Only allow one display. Initialize outerpool and
773 ns_*_types.
774
39a57ad0
PE
7752012-09-15 Paul Eggert <eggert@cs.ucla.edu>
776
777 Port _setjmp fix to POSIXish hosts as well as Microsoft.
778 * image.c (_setjmp) [!HAVE__SETJMP]: Restore definition, as
779 it's needed on POSIXish hosts that lack _setjmp. Attempt to solve
780 the Microsoft problem in a different way, by altering ../nt/config.nt.
781
7105c8cb
EZ
7822012-09-15 Eli Zaretskii <eliz@gnu.org>
783
784 * w32xfns.c:
785 * w32uniscribe.c:
786 * w32term.c:
787 * w32select.c:
788 * w32reg.c:
789 * w32proc.c:
790 * w32menu.c:
791 * w32inevt.c:
792 * w32heap.c:
793 * w32font.c:
794 * w32fns.c:
795 * w32console.c:
796 * w32.c:
797 * w16select.c: Remove inclusion of setjmp.h, as it is now included
798 by lisp.h. This completes removal of setjmp.h inclusion
799 erroneously announced in the previous commit. (Bug#12446)
800
801 * lisp.h [!HAVE__SETJMP, !HAVE_SIGSETJMP]: Make the commentary
802 more accurate.
803
804 * image.c (_setjmp) [!HAVE__SETJMP]: Define only if 'setjmp' is
805 not defined as a macro. The latter happens on MS-Windows.
806 (Bug#12446)
807
0328b6de
PE
8082012-09-15 Paul Eggert <eggert@cs.ucla.edu>
809
810 Port better to POSIX hosts lacking _setjmp (Bug#12446).
811 * lisp.h: Include <setjmp.h> here, since we use its symbols here.
7105c8cb 812 Some instances of '#include <setjmp.h>' removed, if the
0328b6de
PE
813 only reason for the instance was because "lisp.h" was included.
814 (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
815 Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
816 and _longjmp with the new symbols. Emacs already uses _setjmp if
817 available, so this change affects only POSIXish hosts that have
818 sigsetjmp but not _setjmp, such as some versions of Solaris and
819 Unixware. (Also, POSIX-2008 marks _setjmp as obsolescent.)
820 * image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
821 (png_load_body) [HAVE_PNG]:
822 (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
823 (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
824 Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
825 since PNG requires jmp_buf. This is the only exception to the
826 general rule that we now use sys_setjmp and sys_longjmp.
827 This exception is OK since this code does not change the signal
828 mask or longjmp out of a signal handler.
829
2af03429
PE
8302012-09-14 Paul Eggert <eggert@cs.ucla.edu>
831
832 * alloc.c [!SYSTEM_MALLOC && !SYNC_INPUT && HAVE_PTHREAD]:
833 Include "syssignal.h", for 'main_thread'.
834
2f294edf
DA
8352012-09-14 Dmitry Antipov <dmantipov@yandex.ru>
836
837 Avoid out-of-range marker position (Bug#12426).
3a880af4
SM
838 * insdel.c (replace_range, replace_range_2):
839 Adjust markers before overlays, as suggested by comments.
2f294edf
DA
840 (insert_1_both, insert_from_buffer_1, adjust_after_replace):
841 Remove redundant check before calling offset_intervals.
842
6b533e9c
MR
8432012-09-14 Martin Rudalics <rudalics@gmx.at>
844
845 * xdisp.c (Fformat_mode_line): Unconditionally save/restore
846 current buffer (Bug#12387).
847
2a7931e3
JB
8482012-09-14 Juanma Barranquero <lekktu@gmail.com>
849
850 * makefile.w32-in ($(BLD)/alloc.$(O)): Update dependencies.
851
c18e885b
PE
8522012-09-13 Paul Eggert <eggert@cs.ucla.edu>
853
854 Use a more backwards-compatible timer format (Bug#12430).
855 * keyboard.c (decode_timer): Get PSECS from the 8th (origin-0)
856 vector element, not from the 4th, since PSECS is now at the end.
857 (Fcurrent_idle_time): Doc fix.
858
d59a1afb
DA
8592012-09-13 Dmitry Antipov <dmantipov@yandex.ru>
860
861 Function to mark objects and remove killed buffers at once.
862 * alloc.c (discard_killed_buffers): Rename to ...
863 (mark_discard_killed buffers) ... new name. Add marking
864 of remaining objects. Fix comment. Adjust users.
865 (mark_object): Do not touch frame buffer lists here.
866 * frame.c (delete_frame): Reset frame buffer lists here.
867
5f0cb45a
PE
8682012-09-13 Paul Eggert <eggert@cs.ucla.edu>
869
8ea47e3a
PE
870 Better workaround for GNOME bug when --enable-gcc-warnings.
871 * emacsgtkfixed.c (G_STATIC_ASSERT): Remove, undoing last change.
872 Instead, disable -Wunused-local-typedefs. See Dmitry Antipov in
873 <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00335.html>.
874
4a4bbad2
PE
875 Simplify SIGIO usage (Bug#12408).
876 The code that dealt with SIGIO was crufty and confusing, e.g., it
877 played tricks like "#undef SIGIO" but these tricks were not used
878 consistently. Simplify mostly by not #undeffing standard symbols,
879 e.g., use "defined USABLE_SIGIO" (our symbol, which we can define
880 or not as we please) rather than "defined SIGIO" (standard symbol
881 that we probably shouldn't #undef).
882 * conf_post.h [USG5_4]: Do not include <sys/wait.h> here.
883 Modules that need it can include it.
884 [USG5_4 && emacs]: Likewise, do not include the streams stuff here.
885 * dispextern.h (ignore_sigio): New decl.
886 * emacs.c (shut_down_emacs): Invoke unrequest_sigio
887 unconditionally, since it's now a no-op if !USABLE_SIGIO.
888 * emacs.c (shut_down_emacs):
889 * keyboard.c (kbd_buffer_store_event_hold):
890 Use ignore_sigio rather than invoking 'signal' directly.
891 * keyboard.c (USABLE_FIONREAD && USG5_4): Include <sys/filio.h>,
892 for FIONREAD.
893 (FIONREAD, SIGIO): Do not #undef.
894 (tty_read_avail_input): Use #error rather than a syntax error.
895 * process.c [USG5_4]: Include <sys/stream.h> and <sys/stropts.h>,
896 for I_PIPE, used by SETUP_SLAVE_PTY.
897 (DATAGRAM_SOCKETS): Simplify defn, based on USABLE_FIONREAD.
898 * sysdep.c (croak): Remove; no longer needed. This bit of
899 temporary code, with Fred N. Fish's comment that it's temporary,
900 has been in Emacs since at least 1992!
901 (init_sigio, reset_sigio, request_sigio, unrequest_sigio):
902 Arrange for them to be no-ops in all cases when ! USABLE_SIGIO.
903 * syssignal.h (croak): Remove decl.
904 (SIGIO, SIGPOO, SIGAIO, SIGPTY): Do not #undef; that's too fragile.
905 * systty.h [!NO_TERMIO]: Do not include <termio.h>; no longer needed
906 now that we're termios-only.
907 (FIONREAD, ASYNC) [BROKEN_FIONREAD]: Do not #undef.
908 * term.c (dissociate_if_controlling_tty): Use #error rather than
909 a run-time error.
910
5f0cb45a
PE
911 Work around GCC and GNOME bugs when --enable-gcc-warnings.
912 * emacsgtkfixed.c (G_STATIC_ASSERT): Redefine to use 'verify',
913 to work around GNOME bug 683906.
914 * image.c (jpeg_load_body) [HAVE_JPEG && lint]: Pacify gcc -Wclobber.
915 (struct my_jpeg_error_mgr) [HAVE_JPEG && lint]: New member fp.
916 This works around GCC bug 54561.
917
40bce90b
PE
9182012-09-12 Paul Eggert <eggert@cs.ucla.edu>
919
920 More fixes for 'volatile' and setjmp/longjmp.
921 * eval.c (Fdefvar, Fcondition_case): Remove unnecessary 'volatile's.
922 * image.c (struct png_load_context) [HAVE_PNG]: New type.
923 (png_load_body) [HAVE_PNG]:
924 (jpeg_load_body) [HAVE_JPEG]:
925 New function, with most of the old parent function's body.
926 (png_load) [HAVE_PNG]:
927 (jpeg_load) [HAVE_JPEG]:
928 Invoke the new function, to avoid longjmp munging our locals.
929 (struct my_jpeg_error_mgr) [HAVE_JPEG]: New members cinfo, failure_code.
930 (my_error_exit) [HAVE_JPEG]: Don't trust 'setjmp' to return 2 when
931 longjmp is passed 2, as the C standard doesn't guarantee this.
932 Instead, store the failure code into mgr->failure_code.
933
bfeae2cf
SM
9342012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
935
936 * keyboard.c (read_char, requeued_events_pending_p, Finput_pending_p)
937 (Fdiscard_input, quit_throw_to_read_char, init_keyboard)
938 (syms_of_keyboard): Remove support for unread-command-char.
939
8099e36b
EZ
9402012-09-12 Eli Zaretskii <eliz@gnu.org>
941
942 * w32proc.c (sys_kill): If PID is our process ID and the signal is
943 SIGABRT, call emacs_abort. Avoids silently exiting upon assertion
944 violation. (Bug#12426)
945
92547ff9
PE
9462012-09-12 Paul Eggert <eggert@cs.ucla.edu>
947
948 * image.c (jpeg_memory_src): Don't assume string len fits in unsigned.
949
45b82ad0
SM
9502012-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
951
952 * eval.c: Add `inhibit-debugger'.
953 (Qinhibit_debugger): New symbol.
954 (call_debugger): Bind it instead of Qdebug_on_error.
955 (maybe_call_debugger): Test Vinhibit_debugger.
956 (syms_of_eval): Define inhibit-debugger.
957 * xdisp.c (set_message): Don't bind Qinhibit_debug_on_message.
958 (syms_of_xdisp): Remove inhibit-debug-on-message.
959
5779a1dc
PE
9602012-09-11 Paul Eggert <eggert@cs.ucla.edu>
961
50f2e553
PE
962 Avoid _setjmp/_longjmp problems with local nonvolatile variables.
963 If a nonvolatile local variable is written before a _longjmp to
964 the frame containing the variable, and is read after the _longjmp,
965 the value read is indeterminate. Some local variables of type
966 'struct handler' and 'struct catchtag' are used in this way, so
967 mark each of their slots as volatile if the slot can be set before
968 _longjmp and read afterwards.
969 * lisp.h (struct handler): var and chosen_clause are now volatile.
970 (struct catchtag): val, next, and pdlcount are now volatile.
971
ae1d87e2
PE
972 * bidi.c (bidi_push_it, bidi_pop_it):
973 * fns.c (copy_hash_table):
974 * image.c (define_image_type):
975 * keyboard.c (kbd_buffer_store_event_hold):
976 * process.c (Fprocess_send_eof):
977 * xfaces.c (x_create_gc) [HAVE_NS]:
978 * xgselect.c (xg_select):
979 Prefer assignment to memcpy when either will do.
980
5779a1dc
PE
981 * alloc.c (discard_killed_buffers): Tune and simplify a bit.
982 Use pointer-to-a-pointer to simplify and avoid a NILP check each
983 time an item is removed. No need to mark this function 'inline';
984 the compiler knows better than we do.
985
c4c9756b
JD
9862012-09-11 Jan Djärv <jan.h.d@swipnet.se>
987
988 * nsterm.m (ns_judge_scroll_bars): Pass NO to updateFrameSize.
989 (updateFrameSize:): Add delay parameter to updateFrameSize, send it
990 to change_frame_size (Bug#12388).
991 (windowDidResize:): Pass YES to updateFrameSize.
992
993 * nsterm.h: Add delay parameter to updateFrameSize.
994
d73e321c
DA
9952012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
996
997 Discard killed buffers from deleted window and frame objects.
998 This reduces an amount of references to killed buffers and
999 helps GC to reclaim them faster.
1000 * alloc.c (discard_killed_buffers): New function.
1001 (mark_object): Use it for deleted windows and frames.
1002 (mark_object): If symbol's value is set up for a killed buffer
1003 or deleted frame, restore it's global binding.
1004 * data.c (swap_in_global_binding): Add GC notice.
1005 (swap_in_symval_forwarding): Use convenient set_blv_where.
1006 * window.c (wset_next_buffers, wset_prev_buffers): Move ...
1007 * window.h: ... to here.
1008
e578f381
DA
10092012-09-11 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 Convenient macro to check whether the buffer is live.
1012 * buffer.h (BUFFER_LIVE_P): New macro.
1013 * alloc.c, buffer.c, editfns.c, insdel.c, lread.c, marker.c:
1014 * minibuf.c, print.c, process.c, window.c, xdisp.c: Use it.
1015
3057e615
YM
10162012-09-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1017
1018 * xdisp.c (right_overwritten, right_overwriting): Also handle gstring
1019 composition cases (Bug#12364).
1020
1021 * xterm.c (x_draw_glyph_string): Avoid overwriting inverted left
1022 overhang of succeeding glyphs overlapping box cursor.
1023
1024 * w32term.c (x_draw_glyph_string): Likewise.
1025
6fda35f2
PE
10262012-09-11 Paul Eggert <eggert@cs.ucla.edu>
1027
c990426a
PE
1028 Simplify, document, and port floating-point (Bug#12381).
1029 The porting part of this patch fixes bugs on non-IEEE platforms
1030 with frexp, ldexp, logb.
1031 * data.c, lisp.h (Qdomain_error, Qsingularity_error, Qunderflow_error):
1032 Now static.
1033 * floatfns.c: Simplify discussion of functions that Emacs doesn't
1034 support, by removing commented-out code and briefly listing the
1035 C89 functions excluded. The commented-out stuff was confusing
1036 maintenance, e.g., we thought we needed cbrt but it was commented out.
1037 (logb): Remove decl; no longer needed.
1038 (isfinite): New macro, if not already supplied.
1039 (isnan): Don't replace any existing macro.
1040 (Ffrexp, Fldexp): Define even if !HAVE_COPYSIGN, as frexp and ldexp
1041 are present on all C89 platforms.
1042 (Ffrexp): Do not special-case zero, as frexp does the right thing
1043 for that case.
1044 (Flogb): Do not use logb, as it doesn't have the desired meaning
1045 on hosts that use non-base-2 floating point. Instead, stick with
1046 frexp, which is C89 anyway. Do not pass an infinity or a NaN to
1047 frexp, to avoid getting an unspecified result.
1048
6fda35f2
PE
1049 * xdisp.c (Qinhibit_debug_on_message): Now static.
1050
16130a58
JD
10512012-09-10 Jan Djärv <jan.h.d@swipnet.se>
1052
1053 * nsterm.m (ns_update_begin): Set clip path to whole view by using
1054 NSBezierPath (Bug#12131).
1055
d105a573
CY
10562012-09-10 Chong Yidong <cyd@gnu.org>
1057
1058 * fns.c (Fdelq, Fdelete): Doc fix.
1059
ff55dfe8
PE
10602012-09-10 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 * lisp.h (XSETINT, XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL)
1063 (XSETFLOAT, XSETMISC): Parenthesize macro bodies.
1064
e7032e7c
SM
10652012-09-09 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * lisp.h (make_lisp_ptr): New macro to replace XSET.
1068 (XSETCONS, XSETVECTOR, XSETSTRING, XSETSYMBOL, XSETFLOAT, XSETMISC):
1069 Use it.
1070
e9957956
EZ
10712012-09-09 Eli Zaretskii <eliz@gnu.org>
1072
aba05ce9
EZ
1073 * fringe.c (draw_fringe_bitmap_1): Don't reduce the width of the
1074 left fringe if the window has a left margin. This avoids leaving
1075 traces of the cursor because its leftmost pixel is not drawn over.
1076
e9957956
EZ
1077 * dispnew.c (update_window_line): When the left margin area of a
1078 screen line is updated, set the redraw_fringe_bitmaps_p flag of
1079 that screen line. (Bug#12277)
1080
f6196b87
PE
10812012-09-09 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 Assume C89 or later for math functions (Bug#12381).
1084 This simplifies the code, and makes it a bit smaller and faster,
1085 and (most important) makes it easier to clean up signal handling
1086 since we can stop worring about floating-point exceptions in
1087 library code. That was a problem before C89, but the problem
1088 went away many years ago on all practical Emacs targets.
1089 * data.c, image.c, lread.c, print.c:
1090 Don't include <math.h>; no longer needed.
1091 * data.c, floatfns.c (IEEE_FLOATING_POINT): Don't worry that it
1092 might be autoconfigured, as that never happens.
1093 * data.c (fmod):
1094 * doprnt.c (DBL_MAX_10_EXP):
1095 * print.c (DBL_DIG):
1096 Remove. C89 or later always defines these.
1097 * floatfns.c (HAVE_MATHERR, FLOAT_CHECK_ERRNO, FLOAT_CHECK_DOMAIN)
1098 (in_float, float_error_arg, float_error_arg2, float_error_fn_name)
1099 (arith_error, domain_error, domain_error2):
1100 Remove all this pre-C89 cruft. Do not include <errno.h> as that's
1101 no longer needed -- we simply return what C returns. All uses removed.
1102 (IN_FLOAT, IN_FLOAT2): Remove. All uses replaced with
1103 the wrapped code.
1104 (FLOAT_TO_INT, FLOAT_TO_INT2, range_error, range_error2):
1105 Remove. All uses expanded, as these macros are no longer used
1106 more than once and are now more trouble than they're worth.
1107 (Ftan): Use tan, not sin / cos.
1108 (Flogb): Assume C89 frexp.
1109 (fmod_float): Assume C89 fmod.
1110 (matherr) [HAVE_MATHERR]: Remove; no longer needed.
1111 (init_floatfns): Remove. All uses removed.
1112
9d7f1863
JD
11132012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1114
1115 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Take back
1116 compositeToPoint for OSX < 10.6 (Bug#12390).
1117
eabf0404
PE
11182012-09-08 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * floatfns.c (Ftan): Use tan (x), not (sin (x) / cos (x)).
1121 This produces more-accurate results.
1122
0b3b1d23
JD
11232012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1124
1125 * nsterm.m (updateFrameSize): Call setFrame: on the view when size
1126 changes (Bug#12088).
1127
6dcef6ec
CY
11282012-09-08 Chong Yidong <cyd@gnu.org>
1129
1130 * syntax.c (Fstring_to_syntax): Doc fix.
1131
aa7d57c5
JD
11322012-09-08 Jan Djärv <jan.h.d@swipnet.se>
1133
1134 * nsterm.m (ns_clip_to_row): Remove code that deals with drawing fringe
1135 in the internal border.
1136 (x_set_window_size): Remove static variables and their usage.
1137 (ns_redraw_scroll_bars): Fix NSTRACE arg.
3a880af4
SM
1138 (ns_after_update_window_line, ns_draw_fringe_bitmap):
1139 Remove fringe/internal border adjustment (Bug#11052).
aa7d57c5
JD
1140 (ns_draw_fringe_bitmap): Make code more like other terms (xterm.c).
1141 (ns_draw_window_cursor): Remove fringe/internal border adjustment.
1142 (ns_fix_rect_ibw): Remove.
1143 (ns_get_glyph_string_clip_rect): Remove call to ns_fix_rect_ibw.
1144 (ns_dumpglyphs_box_or_relief): Ditto.
1145 (ns_maybe_dumpglyphs_background): Remove fringe/internal border
1146 adjustment.
1147 (ns_dumpglyphs_image): Ditto.
fc0c31f8 1148 (ns_dumpglyphs_stretch): Fix coding style. Remove fringe/internal
aa7d57c5
JD
1149 border adjustment.
1150 (ns_set_vertical_scroll_bar): Remove variables barOnVeryLeft/Right and
1151 their usage. Add fringe_extended_p and its use as in other terms.
1152 (ns_judge_scroll_bars): Code style fix. Call updateFrameSize if
1153 scroll bar was removed.
1154 (updateFrameSize): New function.
1155 (windowDidResize): Move code to updateFrameSize and call it.
1156
1157 * nsterm.h (EmacsView): Add updateFrameSize.
1158
1a5432bc
CY
11592012-09-07 Chong Yidong <cyd@gnu.org>
1160
b4f5313e
CY
1161 * textprop.c (Fget_text_property): Minor doc fix (Bug#12323).
1162
1a5432bc
CY
1163 * data.c (Flocal_variable_if_set_p): Doc fix (Bug#10713).
1164
1a4f1e9b
PE
11652012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 More signal-handler cleanup (Bug#12327).
eddb36a7
PE
1168 * emacs.c (main): Convert three 'signal' calls to 'sigaction' calls.
1169 Problem introduced when merging patches. Noted by Eli Zaretskii in
1170 <http://bugs.gnu.org/12327#67>.
1a4f1e9b
PE
1171 * floatfns.c: Comment fix.
1172 * lisp.h (force_auto_save_soon): Declare regardless of SIGDANGER.
1173 SIGDANGER might not be in scope so "#ifdef SIGDANGER" is not right,
1174 and anyway the declaration is harmless even if SIGDANGER is not defined.
1175 * syssignal.h (SIGIO): Also #undef if (! defined FIONREAD ||
1176 defined BROKEN_FIONREAD). systty.h formerly did this, but other
1177 source files not surprisingly expected syssignal.h to define, or
1178 not define, SIGIO, and it's cleaner to do it that way, for consistency.
1179 Include <sys/ioctl.h>, for FIONREAD.
1180 * systty.h (SIGIO): Do not #undef here; it's now syssignal.h's job.
1181 This eliminates a problem whereby other files mysteriously had
1182 to include "syssignal.h" before including "systty.h" if they
1183 wanted to use "#ifdef SIGIO".
1184
bc8000ff
EZ
11852012-09-07 Eli Zaretskii <eliz@gnu.org>
1186
3e6d6928
EZ
1187 * w32proc.c (sigaction): New function, emulates Posix 'sigaction'.
1188
1189 * w32.c (sigemptyset): Empty the set.
1190 (sigsetmask, sigmask, sigblock, sigunblock): Remove unused functions.
1191
bc8000ff
EZ
1192 * alloc.c [ENABLE_CHECKING]: Include signal.h, since we need SIGABRT.
1193
b4fa72f2
DA
11942012-09-07 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 * alloc.c (mark_buffer): Revert unsafe marking optimization.
1197 (mark_object): Likewise for frame objects.
1198
30730c93
PE
11992012-09-07 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * syssignal.h (handle_on_main_thread): Always declare,
1202 even if FORWARD_SIGNAL_TO_MAIN_THREAD is not defined.
1203 This ports to platforms without HAVE_PTHREAD.
1204
2fe28299
PE
12052012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 Signal-handler cleanup (Bug#12327).
1208 Emacs's signal handlers were written in the old 4.2BSD style with
1209 sigblock and sigmask and so forth, and this led to some
1210 inefficiencies and confusion. Rewrite these to use
1211 pthread_sigmask etc. without copying signal sets around. Also,
1212 get rid of the confusing macros 'SIGNAL_THREAD_CHECK' and
1213 'signal', and instead use functions that do not attempt to take
1214 over the system name space. This patch causes Emacs's text
1215 segment to shrink by 0.7% on my platform, Fedora 17 x86-64.
1216 * alloc.c, emacsgtkfixed.c, nsfns.m, widget.c, xmenu.c:
1217 Do not include <signal.h> or "syssignal.h", as these
1218 modules do not use signals.
1219 * atimer.c, callproc.c, data.c, dispnew.c, emacs.c, floatfns.c:
1220 * gtkutil.c, keyboard.c, process.c, sound.c, sysdep.c, term.c, xterm.c:
1221 Do not include <signal.h>, as "syssignal.h" does that for us now.
1222 * atimer.c (sigmask_atimers): New function.
1223 (block_atimers, unblock_atimers): New functions,
1224 replacing the old macros BLOCK_ATIMERS and UNBLOCK_ATIMERS.
1225 All uses replaced.
1226 * conf_post.h [SIGNAL_H_AHB]: Do not include <signal.h>;
1227 no longer needed here.
1228 * emacs.c (main): Inspect existing signal handler with sigaction,
fc0c31f8 1229 so that there's no need to block and unblock SIGHUP.
2fe28299
PE
1230 * sysdep.c (struct save_signal): New member 'action', replacing
1231 old member 'handler'.
1232 (save_signal_handlers, restore_signal_handlers):
1233 Use sigaction instead of 'signal' to save and restore.
1234 (get_set_sighandler, set_sighandler) [!WINDOWSNT]:
1235 New function. All users of 'signal' modified to use set_sighandler
1236 if they're writeonly, and to use sys_signal if they're read+write.
1237 (emacs_sigaction_init, forwarded_signal): New functions.
1238 (sys_signal): Remove. All uses replaced by calls to sigaction
1239 and emacs_sigaction_init, or by direct calls to 'signal'.
1240 (sys_sigmask) [!__GNUC__]: Remove; no longer needed.
1241 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove;
1242 all uses replaced by pthread_sigmask etc. calls.
1243 * syssignal.h: Include <signal.h>.
1244 (emacs_sigaction_init, forwarded_signal): New decls.
1245 (SIGMASKTYPE): Remove. All uses replaced by its definiens, sigset_t.
1246 (SIGEMPTYMASK): Remove; all uses replaced by its definiens, empty_mask.
1247 (sigmask, sys_sigmask): Remove; no longer needed.
1248 (sigpause): Remove. All uses replaced by its definiens, sigsuspend.
1249 (sigblock, sigunblock, sigfree):
1250 (sigsetmask) [!defined sigsetmask]:
1251 Remove. All uses replaced by pthread_sigmask.
1252 (signal): Remove. Its remaining uses (with SIG_DFL and SIG_IGN)
1253 no longer need to be replaced, and its typical old uses
1254 are now done via emacs_sigaction_init and sigaction.
1255 (sys_sigblock, sys_sigunblock, sys_sigsetmask): Remove decls.
1256 (sys_sigdel): Remove; unused.
1257 (NSIG): Remove a FIXME; the code's fine. Remove an unnecessary ifdef.
1258
0216c128
EZ
12592012-09-06 Eli Zaretskii <eliz@gnu.org>
1260
1261 * process.c (CAN_HANDLE_MULTIPLE_CHILDREN): Fix a typo that broke
1262 SIGCHLD handling on systems that don't have WNOHANG. (Bug#12327)
1263
c752cfa9
DA
12642012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1265
1266 Explicitly mark buffer_defaults and buffer_local_symbols.
1267 * alloc.c (Fgarbage_collect): Mark buffer_defaults and
1268 mark_local_symbols here.
1269 (mark_object): If GC_CHECK_MARKED_OBJECTS, simplify checking
1270 since special buffers aren't marked here any more.
1271 (allocate_buffer): Chain new buffer with all_buffers here...
1272 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer): ...and
1273 not here.
1274 (Vbuffer_defaults, Vbuffer_local_symbols): Remove.
1275 (syms_of_buffer): Remove staticpro of the above.
1276 (init_buffer_once): Set names for buffer_defaults and
1277 buffer_local_symbols.
1278
a864ef14
PE
12792012-09-06 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 Use bool for booleans in font-related modules.
1282 * font.c (font_intern_prop, font_style_to_value)
1283 (font_style_symbolic, font_parse_xlfd, font_parse_fcname)
1284 (generate_otf_features, font_check_otf_features, font_check_otf)
1285 (font_match_p, font_list_entities, font_at):
1286 * fontset.c (fontset_id_valid_p, reorder_font_vector
1287 (fontset_find_font, Fset_fontset_font)
1288 (face_suitable_for_char_p) [0]:
1289 * ftfont.c (fc_initialized, ftfont_get_open_type_spec)
1290 (ftfont_open, ftfont_text_extents, ftfont_check_otf):
1291 (m17n_flt_initialized, ftfont_shape_by_flt):
1292 * ftxfont.c (ftxfont_draw_bitmap, ftxfont_draw):
1293 * nsfont.m (nsfont_draw):
1294 * w32font.c (w32font_draw):
1295 * w32term.c (x_draw_glyphless_glyph_string_foreground):
1296 Use bool for booleans.
1297 * font.h: Adjust to above API changes.
1298 (struct font, struct font_driver, struct font_driver_list):
1299 Use bool for booleans.
1300 (struct font): Remove useless member encoding_type.
1301 All users removed.
1302 * fontset.c, xftfont.c: Omit unnecessary static decls.
1303
0699fc18
DA
13042012-09-06 Dmitry Antipov <dmantipov@yandex.ru>
1305
1306 * alloc.c (mark_object): Revert window marking code
1307 since it's unsafe for the Fset_window_configuration.
1308
20ef56db
PE
13092012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1310
2fe28299 1311 Fix race conditions with signal handlers and errno (Bug#12327).
20ef56db
PE
1312 Be more systematic about preserving errno whenever a signal
1313 handler returns, even if it's not in the main thread. Do this by
1314 renaming signal handlers to distinguish between signal delivery
1315 and signal handling. All uses changed.
1316 * atimer.c (deliver_alarm_signal): Rename from alarm_signal_handler.
1317 * data.c (deliver_arith_signal): Rename from arith_error.
1318 * dispnew.c (deliver_window_change_signal): Rename from
1319 window_change_signal.
1320 * emacs.c (deliver_error_signal): Rename from fatal_error_signal.
1321 (deliver_danger_signal) [SIGDANGER]: Rename from memory_warning_signal.
1322 * keyboard.c (deliver_input_available_signal): Rename from
1323 input_available_signal.
1324 (deliver_user_signal): Rename from handle_user_signal.
1325 (deliver_interrupt_signal): Rename from interrupt_signal.
1326 * process.c (deliver_pipe_signal): Rename from send_process_trap.
1327 (deliver_child_signal): Rename from sigchld_handler.
1328 * atimer.c (handle_alarm_signal):
1329 * data.c (handle_arith_signal):
1330 * dispnew.c (handle_window_change_signal):
1331 * emacs.c (handle_fatal_signal, handle_danger_signal):
1332 * keyboard.c (handle_input_available_signal):
1333 * keyboard.c (handle_user_signal, handle_interrupt_signal):
1334 * process.c (handle_pipe_signal, handle_child_signal):
1335 New functions, with the actual signal-handling code taken from the
1336 original respective signal handlers, sans the sporadic attempts to
1337 preserve errno, since that's now done by handle_on_main_thread.
1338 * atimer.c (alarm_signal_handler): Remove unnecessary decl.
1339 * emacs.c, floatfns.c, lisp.h: Remove unused FLOAT_CATCH_SIGKILL cruft.
1340 * emacs.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1341 Move to sysdep.c.
1342 (main) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1343 Move initialization of main_thread to sysdep.c's init_signals.
1344 * process.c (waitpid) [!WNOHANG]: #define to wait; that's good enough for
1345 our usage, and simplifies the mainline code.
1346 (record_child_status_change): New static function, as a helper
1347 for handle_child_signal, and with most of the old child handler's
1348 contents.
1349 (CAN_HANDLE_MULTIPLE_CHILDREN): New constant.
1350 (handle_child_signal): Use the above.
1351 * sysdep.c (main_thread) [FORWARD_SIGNAL_TO_MAIN_THREAD]:
1352 Moved here from emacs.c.
1353 (init_signals) [FORWARD_SIGNAL_TO_MAIN_THREAD]: Initialize it;
1354 code moved here from emacs.c's main function.
1355 * sysdep.c, syssignal.h (handle_on_main_thread): New function,
3a880af4
SM
1356 replacing the old SIGNAL_THREAD_CHECK. All uses changed.
1357 This lets callers save and restore errno properly.
20ef56db 1358
e3ccf108
DA
13592012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1360
1361 Remove redundant or unused things here and there.
1362 * lisp.h (CYCLE_CHECK, CHAR_TABLE_TRANSLATE): Remove.
1363 * conf_post.h (RE_TRANSLATE): Use char_table_translate.
1364 * editfns.c (Fcompare_buffer_substrings): Likewise.
1365 * frame.h (struct terminal, struct font_driver_list):
1366 Remove redundant declarations.
1367 * window.h (Qleft, Qright): Likewise.
1368
697e1e39
DA
13692012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 Do not mark objects from deleted buffers, windows and frames.
1372 * alloc.c (mark_buffer): Mark just the buffer if it is dead.
1373 (mark_object): Likewise for windows and frames.
1374
c1ca42ca
DA
13752012-09-05 Dmitry Antipov <dmantipov@yandex.ru>
1376
1377 * alloc.c (valid_lisp_object_p): Treat killed buffers,
1378 buffer_defaults and buffer_local_symbols as valid objects.
1379 Return special value to denote them.
1380
014d93be
PE
13812012-09-05 Paul Eggert <eggert@cs.ucla.edu>
1382
f75d7a91
PE
1383 * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean.
1384 * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
1385 (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
1386 (file_name_absolute_p, Fsubstitute_in_file_name):
1387 (check_executable, check_writable, Ffile_accessible_directory_p)
1388 (Fset_file_selinux_context, Fdefault_file_modes)
1389 (Finsert_file_contents, choose_write_coding_system)
1390 (Fwrite_region, build_annotations, a_write, e_write)
1391 (Fdo_auto_save):
1392 * filelock.c (boot_time_initialized, get_boot_time)
1393 (get_boot_time_1, lock_file_1, within_one_second):
1394 * floatfns.c (in_float):
1395 * fns.c (concat, internal_equal, Frequire, base64_encode_1)
1396 (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
1397 (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
1398 * lisp.h (struct Lisp_Hash_Table.cmpfn):
1399 * window.c (compare_window_configurations):
1400 Use bool for booleans.
1401 * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
1402 (Fdefault_file_modes): Now mode_t, not int, for modes.
1403 (Fdo_auto_save): Set a boolean to 1 rather than using ++.
1404 (internal_delete_file): Now returns void, not a (boolean) int,
1405 since nobody was looking at the return value.
1406 * lisp.h, window.h: Adjust to above API changes.
1407
014d93be
PE
1408 * xdisp.c (set_message): Simplify and reindent last change.
1409
776f29e1
JB
14102012-09-05 Juanma Barranquero <lekktu@gmail.com>
1411
1412 * makefile.w32-in ($(BLD)/sysdep.$(O)): Update dependencies.
1413
7f7e0167
LI
14142012-09-04 Lars Ingebrigtsen <larsi@gnus.org>
1415
1416 * eval.c (call_debugger): Make the function non-static so that we
1417 can call it from set_message.
1418
1419 * xdisp.c (set_message): Implement the new variable `debug-on-message'.
1420 (syms_of_xdisp): Defvar it and `inhibit-debug-on-message'.
1421
cf29dd84
PE
14222012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 Give more-useful info on a fatal error (Bug#12328).
1425 * alloc.c [ENABLE_CHECKING]: Do not include <execinfo.h>.
1426 (die) [ENABLE_CHECKING]: Call fatal_error_backtrace instead
1427 of doing the work ourselves.
1428 * emacs.c (fatal_error_signal): Let fatal_error_backtrace
1429 do most of the work.
1430 (fatal_error_backtrace): New function, taken from the guts
1431 of the old fatal_error_signal, but with a new option to output
1432 a backtrace.
1433 (shut_down_emacs) [!DOS_NT]: Use strsignal to give more-useful
1434 info about the signal than just its number.
1435 * lisp.h (fatal_error_backtrace, emacs_backtrace): New decls.
1436 * sysdep.c: Include <execinfo.h>
1437 (emacs_backtrace): New function, taken partly from the previous
1438 code of the 'die' function.
1439 (emacs_abort): Call fatal_error_backtrace rather than abort.
1440
972debf2
SM
14412012-09-04 Stefan Monnier <monnier@iro.umontreal.ca>
1442
1443 * lread.c (readevalloop): Call internal-macroexpand-for-load to perform
1444 eager (load-time) macro-expansion.
1445 * lisp.mk (lisp): Add macroexp.
1446
1088b922
PE
14472012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1448
1449 Simplify redefinition of 'abort' (Bug#12316).
1450 Do not try to redefine the 'abort' function. Instead, redo
1451 the code so that it calls 'emacs_abort' rather than 'abort'.
1452 This removes the need for the NO_ABORT configure-time macro
1453 and makes it easier to change the abort code to do a backtrace.
1454 * .gdbinit: Just stop at emacs_abort, not at w32_abort or abort.
1455 * emacs.c (abort) [!DOS_NT && !NO_ABORT]:
1456 Remove; sysdep.c's emacs_abort now takes its place.
1457 * lisp.h (emacs_abort): New decl. All calls from Emacs code to
1458 'abort' changed to use 'emacs_abort'.
1459 * msdos.c (dos_abort) [defined abort]: Remove; not used.
1460 (abort) [!defined abort]: Rename to ...
1461 (emacs_abort): ... new name.
1462 * sysdep.c (emacs_abort) [!HAVE_NTGUI]: New function, taking
1463 the place of the old 'abort' in emacs.c.
1464 * w32.c, w32fns.c (abort): Do not #undef.
1465 * w32.c (emacs_abort): Rename from w32_abort.
1466
30934d33
EZ
14672012-09-04 Eli Zaretskii <eliz@gnu.org>
1468
1469 * w32uniscribe.c (uniscribe_shape): Reverse the sign of
1470 offsets[j].dv, since the y axis of the screen coordinates points
1471 down, while the y axis of the font definition coordinates points
1472 up. This fixes display of Arabic diacritics such as KASRA and
1473 KASRATAN. (Bug#11860)
1474
af26b72c
PE
14752012-09-04 Paul Eggert <eggert@cs.ucla.edu>
1476
1477 Be more systematic about _setjmp vs setjmp.
1478 * alloc.c (test_setjmp, mark_stack):
1479 * image.c (PNG_LONGJMP) [PNG_LIBPNG_VER < 10500]:
1480 (PNG_JMPBUF) [! (PNG_LIBPNG_VER < 10500)]:
1481 (png_load, my_error_exit, jpeg_load):
1482 * process.c (send_process_trap, send_process):
1483 Uniformly prefer _setjmp and _longjmp to setjmp and longjmp.
1484 The underscored versions are up to 30x faster on some hosts.
1485 Formerly, the code used setjmp+longjmp sometimes and
1486 _setjmp+_longjmp at other times, with no particular reason to
1487 prefer setjmp+longjmp.
1488
26d4541d
PE
14892012-09-03 Paul Eggert <eggert@cs.ucla.edu>
1490
d42f4f0f 1491 Fix minor problem found by static checking.
26d4541d 1492 * buffer.c (Fdelete_all_overlays): Return nil.
26d4541d 1493
c5e28e39
MR
14942012-09-03 Martin Rudalics <rudalics@gmx.at>
1495
1496 * buffer.c (Fdelete_all_overlays): New function.
1497
3eab3ca9
CY
14982012-09-03 Chong Yidong <cyd@gnu.org>
1499
1500 * gtkutil.c: Add extern decl for Qxft.
1501
c04889f8
PE
15022012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1503
1882aa38
PE
1504 * emacs.c, eval.c: Use bool for boolean.
1505 * emacs.c (initialized, inhibit_window_system, running_asynch_code):
1506 (malloc_using_checking) [DOUG_LEA_MALLOC]:
1507 (display_arg) [HAVE_X_WINDOWS || HAVE_NS]:
1508 (noninteractive, no_site_lisp, fatal_error_in_progress, argmatch)
1509 (main, decode_env_path, Fdaemon_initialized):
1510 * eval.c (call_debugger, Finteractive_p, interactive_p):
1511 (unwind_to_catch, Fsignal, wants_debugger, skip_debugger)
1512 (maybe_call_debugger, Fbacktrace):
1513 * process.c (read_process_output, exec_sentinel):
1514 Use bool for booleans.
1515 * emacs.c (shut_down_emacs): Omit unused boolean argument NO_X.
1516 All callers changed.
1517 * eval.c (interactive_p): Omit always-true boolean argument
1518 EXCLUDE_SUBRS_P. All callers changed.
1519 * dispextern.h, lisp.h: Reflect above API changes.
1520 * firstfile.c (dummy): Use the address of 'main', whose signature
1521 won't change, instead of the address of 'initialize', whose
1522 signature just changed from int to bool.
1523 * lisp.h (fatal_error_in_progress): New decl of boolean, moved here ...
1524 * msdos.c (fatal_error_in_progress): ... from here.
1525 * xdisp.c (redisplaying_p): Now a boolean. Set it to 1 instead
1526 of incrementing it.
1527 (redisplay_internal, unwind_redisplay): Simply clear
1528 REDISPLAYING_P when unwinding, instead of saving its previous,
1529 always-false value and then restoring it.
1530
a411ac43
PE
1531 Clean up some extern decls.
1532 Mostly, this hoists extern decls out of .c files and into .h files.
1533 That way, we're more likely to catch errors if the interfaces change.
1534 * alloc.c [USE_GTK]: Include "gtkutil.h" so that we need not
1535 declare xg_mark_data.
1536 * dispextern.h (x_frame_parm_handlers):
1537 * font.h (Qxft):
1538 * lisp.h (Qlexical_binding, Qinternal_interpreter_environment)
1539 (Qextra_light, Qlight, Qsemi_light, Qsemi_bold, Qbold, Qextra_bold)
1540 (Qultra_bold, Qoblique, Qitalic):
1541 Move extern decl here from .c file.
1542 * alloc.c (xg_mark_data) [USE_GTK]:
1543 * doc.c (Qclosure):
1544 * eval.c (Qlexical_binding):
1545 * fns.c (time) [!HAVE_UNISTD_H]:
1546 * gtkutil.c (Qxft, Qnormal, Qextra_light, Qlight, Qsemi_light)
1547 (Qsemi_bold, Qbold, Qextra_bold, Qultra_bold, Qoblique, Qitalic):
1548 * image.c (Vlibrary_cache, QCloaded_from) [HAVE_NTGUI]:
1549 * lread.c (Qinternal_interpreter_environment):
1550 * minibuf.c (Qbuffer):
1551 * process.c (QCfamily, QCfilter):
1552 * widget.c (free_frame_faces):
1553 * xfaces.c (free_frame_menubar) [USE_X_TOOLKIT]:
1554 * xfont.c (x_clear_errors):
1555 * xterm.c (x_frame_parm_handlers):
1556 Remove now-redundant extern decls.
1557 * keyboard.c, keyboard.h (ignore_mouse_drag_p) [USE_GTK || HAVE_NS]:
1558 * xfaces.c (Qultra_light, Qreverse_oblique, Qreverse_italic):
1559 Now static.
1560 * xfaces.c: Remove unnecessary static decls.
1561 * xterm.c (updating_frame): Remove decl of nonexistent object.
1562
c04889f8
PE
1563 * Makefile.in (gl-stamp): Don't scan $(SOME_MACHINE_OBJECTS)
1564 when building globals.h, as the objects that are not built on
1565 this host are not needed to compile C files on this host.
1566
8b339673
JD
15672012-09-02 Jan Djärv <jan.h.d@swipnet.se>
1568
1569 * gtkutil.h: Remove prototype for x_wm_set_size_hint.
1570
1571 * frame.h: Add missing prototype for x_wm_set_size_hint.
1572
a08d4ba7
PE
15732012-09-02 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * doc.c, editfns.c, insdel.c, intervals.c: Use bool for boolean.
1576 * doc.c (read_bytecode_char, get_doc_string, reread_doc_file)
1577 (Fdocumentation, Fdocumentation_property, Fsnarf_documentation)
1578 (Fsubstitute_command_keys):
1579 * editfns.c (region_limit, find_field, Fconstrain_to_field)
1580 (save_excursion_save, save_excursion_restore)
1581 (disassemble_lisp_time, decode_time_components, emacs_nmemftime)
1582 (format_time_string, general_insert_function)
1583 (make_buffer_string, make_buffer_string_both)
1584 (Fsubst_char_in_region, Ftranslate_region_internal, Fformat):
1585 * insdel.c (check_markers, gap_left, adjust_markers_for_insert)
1586 (copy_text, insert_1, insert_1_both, insert_from_string)
1587 (insert_from_string_before_markers, insert_from_string_1)
1588 (insert_from_buffer, insert_from_buffer_1, replace_range)
1589 (replace_range_2, del_range_1, del_range_byte, del_range_both)
1590 (del_range_2, modify_region):
1591 * intervals.c (intervals_equal, balance_possible_root_interval)
1592 (adjust_intervals_for_insertion, merge_properties_sticky)
1593 (graft_intervals_into_buffer, lookup_char_property)
1594 (adjust_for_invis_intang, set_point_both)
1595 (get_property_and_range, compare_string_intervals)
1596 (set_intervals_multibyte_1, set_intervals_multibyte):
1597 * keyboard.c (decode_timer):
1598 Use bool for boolean.
1599 * intervals.h, lisp.h, systime.h: Reflect above API changes.
1600 * editfns.c (struct info): Use 1-bit unsigned bitfields for booleans.
1601
48c948de
CY
16022012-09-02 Chong Yidong <cyd@gnu.org>
1603
1604 * keymap.c (push_key_description): Print M-TAB as C-M-i
1605 (Bug#11758).
1606
6c49a40b
JB
16072012-09-02 Juanma Barranquero <lekktu@gmail.com>
1608
1609 * makefile.w32-in (CCL_H, W32FONT_H): New macros.
1610 (ATIMER_H, FONT_H, $(BLD)/alloc.$(O), $(BLD)/callproc.$(O))
1611 ($(BLD)/editfns.$(O), $(BLD)/ccl.$(O), $(BLD)/chartab.$(O))
1612 ($(BLD)/coding.$(O), $(BLD)/sysdep.$(O), $(BLD)/fontset.$(O))
1613 ($(BLD)/sysdep.$(O), $(BLD)/w32fns.$(O), $(BLD)/keyboard.$(O))
1614 ($(BLD)/w32term.$(O), $(BLD)/w32menu.$(O), $(BLD)/process.$(O))
1615 ($(BLD)/w32font.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
1616
4dfbd238
EZ
16172012-09-01 Eli Zaretskii <eliz@gnu.org>
1618
7e510e28
EZ
1619 * w32uniscribe.c (uniscribe_shape): Handle correctly the case of
1620 more than one grapheme cluster passed to the shaper: compute the
1621 offset adjustment values separately for each cluster. (Bug#11860)
1622
4dfbd238
EZ
1623 * image.c: Restore mistakenly removed inclusion of w32.h. Without
1624 it, GCC doesn't see prototypes of w32_delayed_load, and complains
1625 about implicit conversions from integer to pointer.
1626
86571ae0
DC
16272012-09-01 Daniel Colascione <dancol@dancol.org>
1628
1629 * w32fns.c (x_display_info_for_name): Prevent crash if w32 window
1630 system used too early.
1631
0e23ef9d
PE
16322012-09-01 Paul Eggert <eggert@cs.ucla.edu>
1633
1634 Better seed support for (random).
1635 * emacs.c (main): Call init_random.
1636 * fns.c (Frandom): Set the seed from a string argument, if given.
1637 Remove long-obsolete Gentzel cruft.
1638 * lisp.h, sysdep.c (seed_random): Now takes address and size, not long.
1639 (init_random): New function.
1640
17a2cbbd
DC
16412012-09-01 Daniel Colascione <dancol@dancol.org>
1642
1643 * xterm.h: Add header guards. Declare x_menubar_window_to_frame.
1644 Remove x_set_frame_alpha, x_bitmap_icon, x_make_frame_visible,
1645 x_make_frame_invisible, x_iconify_frame, x_free_frame_resources,
1646 x_wm_set_size_hint, x_query_colors, x_real_positions,
1647 x_set_menu_bar_lines, x_char_width, x_char_height, x_sync,
1648 x_set_tool_bar_lines, x_activate_menubar, and free_frame_menubar,
1649 all of which have been moved to common code.
1650
1651 * xfaces.c: Include TERM_HEADER instead of listing all possible
1652 window-system headers.
1653
1654 * w32xfns.c (x_sync): Correct definition of x_sync (a no-op here)
1655 to match header.
1656
1657 * w32term.h (FRAME_X_WINDOW): Use FRAME_W32_WINDOW instead of
1658 directly accessing frame internals.
1659
f18cbb28 1660 * w32font.h: Include font.h. Define syms_of_w32font and
17a2cbbd
DC
1661 globals_of_w32font.
1662
1663 * process.c: Include TERM_HEADER instead of listing all possible
1664 window-system headers.
1665
3a880af4
SM
1666 * nsterm.h: Remove declarations now in frame.h.
1667 Define FRAME_X_SCREEN, FRAME_X_VISUAL.
17a2cbbd
DC
1668
1669 * menu.c: Include TERM_HEADER instead of listing all possible
1670 window-system headers.
1671
1672 * keyboard.h: Declare ignore_mouse_drag_p whenever we have a
1673 window system.
1674
1675 * keyboard.c: Include TERM_HEADER instead of listing all possible
1676 window-system headers.
1677
1678 * image.c: Include TERM_HEADER instead of listing all possible
1679 window-system headers. Declare Vlibrary_cache when compiling for
1680 Windows.
1681
1682 * gtkutil.h (xg_list_node_): Include xterm.h to pick up needed
1683 window system declarations.
1684
1685 * frame.h: Move common functions here: set_frame_menubar,
1686 x_set_window_size, x_sync, x_get_focus_frame,
1687 x_set_mouse_position, x_set_mouse_pixel_position,
1688 x_make_frame_visible, x_make_frame_invisible, x_iconify_frame,
1689 x_char_width, x_char_height, x_pixel_width, x_pixel_height,
1690 x_set_frame_alpha, x_set_menu_bar_lines, x_set_tool_bar_lines,
1691 x_activate_menubar, x_real_positions, x_bitmap_icon,
1692 x_set_menu_bar_lines, free_frame_menubar, x_free_frame_resources,
1693 and x_query_colors.
1694
1695 * frame.c: Include TERM_HEADER instead of listing all possible
1696 window-system headers.
1697
1698 * font.c: Include TERM_HEADER instead of listing all possible
1699 window-system headers.
1700
1701 * emacs.c: Include TERM_HEADER.
1702
f18cbb28
EZ
1703 * dispnew.c: Include TERM_HEADER instead of listing all possible
1704 window-system headers.
17a2cbbd 1705
f18cbb28 1706 * ccl.h: Include character.h.
17a2cbbd
DC
1707
1708 * Makefile.in: Define WINDOW_SYSTEM_OBJ to hold objects needed for
1709 the current window system; include in list of objects to link into
1710 Emacs.
1711
c650a5de
DA
17122012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1713
1714 Remove mark_ttys function and fix tty_display_info initialization.
1715 * lisp.h (mark_ttys): Remove prototype.
1716 * alloc.c (Fgarbage_collect): Remove redundant (and the only) call
1717 to mark_ttys because all possible values of 'top_frame' slot are
1718 the frames which are reachable from Vframe_list.
1719 * term.c (mark_ttys): Remove.
1720 (init_tty): Safely initialize 'top_frame' slot with Qnil.
1721
4e0f6479
DA
17222012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1723
1724 Change struct frame bitfields from unsigned char to unsigned.
1725 * frame.h (struct frame): Change type of 'display_preempted',
1726 'visible', 'iconified', 'has_minibuffer', 'wants_modeline',
1727 'auto_raise', 'auto_lower', 'no_split', 'explicit_name',
1728 'window_sizes_changed', 'mouse_moved' and 'pointer_invisible'
1729 bitfields from unsigned char to unsigned.
1730
8b96a52c
DA
17312012-08-31 Dmitry Antipov <dmantipov@yandex.ru>
1732
1733 Remove unused member of struct x_output and struct w32_output.
1734 * xterm.h (struct x_output): Remove unused field 'needs_exposure'.
1735 * w32term.h (struct w32_output): Likewise.
1736
b4444c8a
JD
17372012-08-30 Jan Djärv <jan.h.d@swipnet.se>
1738
1739 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
1740 does not become zero (Bug#12234).
1741
b98521db
PE
17422012-08-30 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 * dispnew.c (update_frame_1): Pacify gcc -Wstrict-overflow
1745 for GCC 4.7.1 x86-64.
1746
31d02438
GM
17472012-08-30 Glenn Morris <rgm@gnu.org>
1748
1749 * lread.c (init_lread): For out-of-tree builds, only add the
1750 source directory's site-lisp dir to the load-path if it exists,
1751 consistent with in-tree builds. (Bug#12302)
1752
7f8941d8
JD
17532012-08-28 Jan Djärv <jan.h.d@swipnet.se>
1754
1755 * nsmenu.m (initWithContentRect:styleMask:backing:defer:): Initialize
fc0c31f8 1756 button_values to NULL. Call setStykeMask so dialogs get a close button.
7f8941d8
JD
1757 (windowShouldClose:): Set window_closed.
1758 (dealloc): New member, free button_values.
fc0c31f8
JB
1759 (process_dialog:): Make member function. Remove window argument,
1760 replace window with self. Count buttons and allocate and store values
7f8941d8
JD
1761 in button_values.
1762 (addButton:value:row:): value is int with the name tag. Call setTag
fc0c31f8 1763 with tag. Remove return self, declare return value as void.
7f8941d8
JD
1764 (addString:row:): Remove return self, declare return value as void.
1765 (addSplit): Remove return self, declare return value as void.
1766 (clicked:): Remove return self, declare return value as void.
fc0c31f8 1767 Set dialog_return to button_values[seltag]. Code formatting change.
7f8941d8
JD
1768 (initFromContents:isQuestion:): Adjust call to process_dialog.
1769 Code formatting change.
1770 (timeout_handler:): Set timer_fired to YES.
1771 (runDialogAt:): Set timer_fired to NO.
1772 Handle click on close button as quit.
1773
1774 * nsterm.h (EmacsDialogPanel): Make timer_fired BOOL.
1775 Add window_closed and button_values. Add void as return value for
1776 add(Button|String|Split). addButton takes int instead of Lisp_Object.
1777 Add process_dialog as new member.
1778
eada0861 17792012-08-28 Eli Zaretskii <eliz@gnu.org>
19c17fc1 1780
eada0861
GM
1781 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
1782 is not one of the heaps we manage. (Bug#12242)
1783
17842012-08-28 Glenn Morris <rgm@gnu.org>
1785
1786 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
1787
457294dd
MR
17882012-08-28 Martin Rudalics <rudalics@gmx.at>
1789
1790 * window.c (Fset_window_configuration): Remove handling of
37b9743e
MR
1791 auto-buffer-name window parameter. Install revision of reverted
1792 fix.
457294dd 1793
4f2daf31
DA
17942012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1795
1796 Do not allow to set major mode for a dead buffer.
1797 * buffer.c (Fset_buffer_major_mode): Signal an error
1798 if the buffer is dead.
1799 (Fother_buffer, other_buffer_safely): Remove redundant
1800 nested declaration.
1801
66322887
DA
18022012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1803
1804 Always use set_buffer_if_live to restore original buffer at unwind.
1805 * buffer.h (record_unwind_current_buffer): New function.
1806 * bytecode.c, dispnew.c, editfns.c, fileio.c, fns.c, insdel.c:
1807 * keyboard.c, keymap.c, minibuf.c, print.c, process.c, textprop.c:
1808 * undo.c, window.c: Adjust users.
1809 * buffer.c (set_buffer_if_live): Fix comment.
1810
a3d794a1
DA
18112012-08-28 Dmitry Antipov <dmantipov@yandex.ru>
1812
1813 Fix usage of set_buffer_internal.
1814 * buffer.h (set_buffer_internal): Make it BUFFER_INLINE.
1815 * buffer.c (set_buffer_if_live): Use set_buffer_internal.
1816 * coding.c (decode_coding): Omit redundant test.
1817 * fileio.c (decide_coding_unwind): Likewise.
1818 * fns.c (secure_hash): Likewise.
1819 * insdel.c (modify_region): Likewise.
1820 * keyboard.c (command_loop_1): Likewise.
1821 * print.c (PRINTFINISH): Likewise.
1822 * xdisp.c (run_window_scroll_functions): Use set_buffer_internal.
1823
59ea14cd
PE
18242012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * dispnew.c: Use bool for boolean.
1827 (frame_garbaged, display_completed, delayed_size_change)
1828 (fonts_changed_p, add_window_display_history)
1829 (add_frame_display_history, verify_row_hash)
1830 (adjust_glyph_matrix, clear_window_matrices, glyph_row_slice_p)
1831 (row_equal_p, realloc_glyph_pool)
1832 (allocate_matrices_for_frame_redisplay)
1833 (showing_window_margins_p)
1834 (adjust_frame_glyphs_for_frame_redisplay)
1835 (build_frame_matrix_from_leaf_window, make_current)
1836 (mirrored_line_dance, mirror_line_dance, update_frame)
1837 (update_window_tree, update_single_window)
1838 (check_current_matrix_flags, update_window, update_text_area)
1839 (update_window_line, set_window_update_flags, scrolling_window)
1840 (update_frame_1, scrolling, buffer_posn_from_coords)
1841 (do_pending_window_change, change_frame_size)
1842 (change_frame_size_1, sit_for):
1843 Use bool for boolean.
1844 (clear_glyph_matrix_rows): Rename from enable_glyph_matrix_rows,
1845 and remove last int (actually boolean) argument, which was always 0.
1846 All callers changed.
1847 * dispextern.h, frame.h, lisp.h: Reflect above API changes.
1848 * dispextern.h (struct composition_it): Use bool for boolean.
1849 (struct glyph_matrix): Don't assume buffer sizes can fit in 'int'.
1850 (struct bidi_it): Use unsigned:1, not int, for boolean prev_was_pdf.
1851 * dired.c (file_name_completion):
1852 Use bool for boolean. (This was missed in an earlier change.)
1853
95072a94
MR
18542012-08-27 Martin Rudalics <rudalics@gmx.at>
1855
1856 * window.c (Fset_window_configuration): Revert first part of
1857 last change.
1858
0f19feff
JD
18592012-08-27 Jan Djärv <jan.h.d@swipnet.se>
1860
1861 * nsterm.h (NSPanel): New class variable dialog_return.
1862
3a880af4
SM
1863 * nsmenu.m (initWithContentRect:styleMask:backing:defer:):
1864 Initialize dialog_return.
0f19feff
JD
1865 (windowShouldClose:): Use stop instead of stopModalWithCode.
1866 (clicked:): Ditto, and also set dialog_return (Bug#12258).
1867 (timeout_handler:): Use stop instead of abortModal. Send a dummy
1868 event.
1869 (runDialogAt:): Make ret Lisp_Object. Set it from dialog_return when
1870 modal loop returns.
1871
f10fe38f
PE
18722012-08-27 Paul Eggert <eggert@cs.ucla.edu>
1873
de1339b0
PE
1874 * composite.c, data.c, dbusbind.c, dired.c: Use bool for booleans.
1875 * composite.c (find_composition, composition_gstring_p)
1876 (composition_reseat_it, find_automatic_composition):
1877 * data.c (let_shadows_buffer_binding_p)
1878 (let_shadows_global_binding_p, set_internal, make_blv)
1879 (Fmake_variable_buffer_local, Fmake_local_variable)
1880 (Fmake_variable_frame_local, arithcompare, cons_to_unsigned)
1881 (cons_to_signed, arith_driver):
1882 * dbusbind.c (xd_in_read_queued_messages):
1883 * dired.c (directory_files_internal, file_name_completion):
1884 Use bool for booleans.
1885 * dired.c (file_name_completion):
1886 * process.h (fd_callback):
1887 Omit int (actually boolean) argument. It wasn't being used.
1888 All uses changed.
1889 * composite.h, lisp.h: Reflect above API changes.
1890
f10fe38f
PE
1891 * cmds.c, coding.c: Use bool for booleans.
1892 * cmds.c (move_point, Fself_insert_command):
1893 * coding.h (struct composition status, struct coding_system):
1894 * coding.c (detect_coding_utf_8, encode_coding_utf_8)
1895 (detect_coding_utf_16, encode_coding_utf_16, detect_coding_emacs_mule)
1896 (emacs_mule_char, decode_coding_emacs_mule)
1897 (encode_coding_emacs_mule, detect_coding_iso_2022)
1898 (decode_coding_iso_2022, encode_invocation_designation)
1899 (encode_designation_at_bol, encode_coding_iso_2022)
1900 (detect_coding_sjis, detect_coding_big5, decode_coding_sjis)
1901 (decode_coding_big5, encode_coding_sjis, encode_coding_big5)
1902 (detect_coding_ccl, encode_coding_ccl, decode_coding_raw_text)
1903 (encode_coding_raw_text, detect_coding_charset)
1904 (decode_coding_charset, encode_coding_charset, detect_eol)
1905 (detect_coding, get_translation_table, produce_chars)
1906 (consume_chars, reused_workbuf_in_use)
1907 (make_conversion_work_buffer, code_conversion_save)
1908 (decode_coding_object, encode_coding_object)
1909 (detect_coding_system, char_encodable_p)
1910 (Funencodable_char_position, code_convert_region)
1911 (code_convert_string, code_convert_string_norecord)
1912 (Fset_coding_system_priority):
1913 * fileio.c (Finsert_file_contents):
1914 Use bool for booleans.
1915 * coding.h, lisp.h: Reflect above API changes.
1916 * coding.c: Remove unnecessary static function decls.
1917 (detect_coding): Use unsigned, not signed, to copy an unsigned field.
1918 (decode_coding, encode_coding, decode_coding_gap): Return 'void',
1919 not a boolean 'int', since callers never look at the return value.
1920 (ALLOC_CONVERSION_WORK_AREA): Assume caller returns 'void', not 'int'.
1921 * coding.h (decoding_buffer_size, encoding_buffer_size)
1922 (emacs_mule_string_char): Remove unused extern decls.
1923 (struct iso_2022_spec, struct coding_system):
1924 Use 'unsigned int : 1' for boolean fields, since there's more than one.
1925 (struct emacs_mule_spec): Remove unused field 'full_support'.
1926 All initializations removed.
1927 * cmds.c (internal_self_insert): Don't assume EMACS_INT fits in 'int'.
1928
5474c384
DA
19292012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1930
f10fe38f 1931 Fix spare memory change (Bug#12286).
5474c384
DA
1932 * alloc.c (mark_maybe_pointer): Handle MEM_TYPE_SPARE.
1933 (valid_lisp_object_p): Likewise.
1934
c4b6914d
MR
19352012-08-27 Martin Rudalics <rudalics@gmx.at>
1936
1937 * window.c (Fset_window_configuration): Record any window's old
1938 buffer if it's replaced (see Bug#8789). If the new current
1939 buffer doesn't appear in the selected window, go to its old
1940 point (Bug#12208).
1941
35aaa1ea
DA
19422012-08-27 Dmitry Antipov <dmantipov@yandex.ru>
1943
1944 Special MEM_TYPE_SPARE to denote reserved memory.
1945 * alloc.c (enum mem_type): New memory type.
1946 (refill_memory_reserve): Use new type for spare memory.
1947 This prevents live_cons_p and live_string_p from incorrect
1948 detection of uninitialized objects from spare memory as live.
1949
6af64513
PE
19502012-08-26 Paul Eggert <eggert@cs.ucla.edu>
1951
8b2e00a3
PE
1952 Spelling fixes.
1953 * Makefile.in (.PHONY): versioclean -> versionclean.
1954
b52d6985
PE
1955 Remove unused external symbols.
1956 * data.c (Qcons, Qfloat, Qmisc, Qstring, Qvector):
1957 * window.c (Qwindow_valid_p, decode_valid_window):
1958 Now static, not extern.
1959 * data.c (Qinterval): Remove; unused.
1960 (syms_of_data): Do not define 'interval'.
1961 * lisp.h (Qinteger, Qstring, Qmisc, Qvector, Qfloat, Qcons):
1962 * window.h (decode_valid_window):
1963 Remove decls.
1964
d5172d4f
PE
1965 * character.c, charset.c, chartab.c: Use bool for booleans.
1966 * character.c (lisp_string_width, string_count_byte8)
1967 (string_escape_byte8):
1968 * charset.c (charset_map_loaded, load_charset_map, read_hex):
1969 (load_charset_map_from_file, map_charset_chars)
1970 (Fdefine_charset_internal, define_charset_internal)
1971 (Fdeclare_equiv_charset, find_charsets_in_text)
1972 (Ffind_charset_region, char_charset, Fiso_charset):
1973 * chartab.c (sub_char_table_ref, sub_char_table_ref_and_range)
1974 (sub_char_table_set, sub_char_table_set_range)
1975 (char_table_set_range, optimize_sub_char_table)
1976 (map_sub_char_table):
1977 Use bool for boolean.
1978 * character.c (str_to_unibyte): Omit last boolean argument; it was
1979 always 0. All callers changed.
1980 * character.h, charset.h: Adjust to match previous changes.
1981 * character.h (char_printable_p): Remove decl of nonexistent function.
1982 * charset.h (struct charset): Members code_linear_p, iso_chars_96,
1983 ascii_compatible_p, supplementary_p, compact_codes_p, unified_p
1984 are all boolean, so make them single-bit bitfields.
1985
6af64513
PE
1986 * lisp.h (ASET): Remove attempt to detect side effects.
1987 It was meant to be temporary and it often doesn't work,
1988 because when IDX has side effects the behavior of IDX==IDX
1989 is undefined. See Stefan Monnier in
1990 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00762.html>.
1991
e1f29348
BR
19922012-08-26 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
1993
1994 * lisp.h (functionp): New function (extracted from Ffunctionp).
1995 (FUNCTIONP): Use it.
1996 * eval.c (Ffunctionp): Use it.
1997
17c05d74
PE
19982012-08-25 Paul Eggert <eggert@cs.ucla.edu>
1999
0f46bc75
PE
2000 * xgselect.c (xg_select): Use auto storage for the GPollFD buffer
2001 as that's faster and simpler than static storage. Don't bother
2002 with the g_main_context_query overhead if g_main_context_pending
2003 says no events are pending.
2004 (gfds, gfds_size): Remove these static vars.
2005 (xgselect_initialize): Remove; no longer needed.
2006 All uses and decls removed.
2007
ee4c0f69
PE
2008 * emacs.c (fatal_error_signal_hook): Remove.
2009 All uses removed. This leftover from old code was always 0.
2010
17c05d74
PE
2011 * casefiddle.c, casetab.c, category.c: Use bool for boolean.
2012 * casefiddle.c (casify_object, casify_region):
2013 * casetab.c (set_case_table):
2014 * category.c, category.h (word_boundary_p):
2015 * category.h (CHAR_HAS_CATEGORY):
2016 Use bool for booleans, instead of int.
2017
391ceac5
EZ
20182012-08-25 Eli Zaretskii <eliz@gnu.org>
2019
2020 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on $(GNU_LIB)/execinfo.h.
2021
2f221583
PE
20222012-08-25 Paul Eggert <eggert@cs.ucla.edu>
2023
f4a681b0
PE
2024 On assertion failure, print backtrace if available.
2025 * alloc.c [ENABLE_CHECKING]: Include <execinfo.h>.
2026 (die) [ENABLE_CHECKING]: Print a backtrace if available.
2027 * Makefile.in (LIB_EXECINFO): New macro.
2028 (LIBES): Use it.
2029
2f221583
PE
2030 * bytecode.c, callint.c, callproc.c: Use bool for boolean.
2031 * bytecode.c (exec_byte_code):
2032 * callint.c (check_mark, Fcall_interactively):
2033 * callproc.c (Fcall_process, add_env, child_setup, getenv_internal_1)
2034 (getenv_internal, sync_process_alive, call_process_exited):
2035 * lisp.h (USE_SAFE_ALLOCA):
2036 Use bool for booleans, instead of int.
2037 * lisp.h, process.h: Adjust prototypes to match above changes.
2038 * callint.c (Fcall_interactively): Don't assume the mark's
2039 offset fits in 'int'.
2040
37ef52bb
PE
20412012-08-24 Paul Eggert <eggert@cs.ucla.edu>
2042
2043 * buffer.c, buffer.h: Use bool for boolean.
2044 * buffer.c (reset_buffer_local_variables)
2045 (buffer_lisp_local_variables, Fset_buffer_modified_p)
2046 (Frestore_buffer_modified_p, Fset_buffer_multibyte):
2047 (overlays_at, overlays_in, mouse_face_overlay_overlaps)
2048 (overlay_touches_p, overlay_strings, Foverlay_put)
2049 (report_overlay_modification, call_overlay_mod_hooks):
2050 (mmap_enlarge, mmap_set_vars):
2051 * buffer.h (buffer_has_overlays, uppercasep, lowercasep):
2052 Use bool for booleans, instead of int.
2053 * buffer.c (compact_buffer, mmap_free_1): Return void, not int,
2054 since the 1-or-0 return value is always ignored anyway.
2055 (mmap_initialized_p):
2056 * buffer.h (struct buffer_text.inhibit_shrinking): Now bool, not int.
2057 * buffer.h, lisp.h: Adjust prototypes to match above changes.
2058
2cc21167
PE
20592012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * bidi.c: Use bool for boolean.
2062 This is a bit more readable, and makes the text segment of bidi.o
2063 0.4% smaller on my platform (GCC 4.7.1 x86-64, Fedora 15).
2064 Presumably it's faster too.
2065 (bidi_initialized, bidi_ignore_explicit_marks_for_paragraph_level):
2066 Now bool.
2067 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2068 (bidi_unshelve_cache, bidi_init_it, bidi_count_bytes)
2069 (bidi_char_at_pos, bidi_fetch_char, bidi_paragraph_init)
2070 (bidi_explicit_dir_char, bidi_level_of_next_char)
2071 (bidi_find_other_level_edge, bidi_move_to_visually_next):
2072 Use bool for booleans, instead of int.
2073 * dispextern.h (bidi_init_it, bidi_paragraph_init)
2074 (bidi_unshelve_cache): Adjust decls to match code.
2075
7db4ddf4
MR
20762012-08-23 Martin Rudalics <rudalics@gmx.at>
2077
2078 * keyboard.c (Fposn_at_x_y): Do not allow internal window as
2079 argument.
2080
b1bb8011
PE
20812012-08-23 Paul Eggert <eggert@cs.ucla.edu>
2082
2083 * atimer.c, atimer.h (turn_on_atimers): Use bool for boolean.
2084 * atimer.h: Include <stdbool.h>.
2085
ff687885
DN
20862012-08-22 Dan Nicolaescu <dann@gnu.org>
2087
2088 * frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_NS_P): Change to
2089 compile time tests instead of run time tests on systems that do
2090 not use them.
2091 (FRAME_MAC_P): Remove leftover from deleted code.
2092 * frame.c (syms_of_frame): Remove leftover from deleted code.
2093
4ce7a138
JD
20942012-08-22 Jan Djärv <jan.h.d@swipnet.se>
2095
2096 * nsterm.m (insertText:): Don't clear modifiers if code is space.
2097
d733ec6d
PE
20982012-08-22 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * fontset.c (FONTSET_ADD): Return void, not Lisp_Object.
2101 Otherwise, the compiler complains about (A?B:C) where B is void
fc0c31f8 2102 and C is Lisp_Object. This fixes an incompatibility with Sun C 5.12.
d733ec6d
PE
2103 (fontset_add): Return void, for FONTSET_ADD.
2104
d0d2d26f
PE
21052012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2106
fce31d69
PE
2107 * alloc.c: Use bool for booleans.
2108 (gc_in_progress, abort_on_gc)
2109 (setjmp_tested_p) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2110 (dont_register_blocks) [GC_MALLOC_CHECK]:
2111 (suppress_checking) [ENABLE_CHECKING]: Now bool, not int.
2112 (check_string_bytes, make_specified_string, memory_full)
2113 (live_string_p, live_cons_p, live_symbol_p, live_float_p)
2114 (live_misc_p, live_vector_p, live_buffer_p, mark_maybe_object)
2115 (mark_stack, valid_pointer_p, make_pure_string)
2116 (Fgarbage_collect, survives_gc_p, gc_sweep):
2117 Use bool for booleans, instead of int.
2118 (test_setjmp) [!GC_SAVE_REGISTERS_ON_STACK && !GC_SETJMP_WORKS]:
2119 Remove unused local.
2120 * alloc.c (PURE_POINTER_P):
2121 * lisp.h (STRING_MULTIBYTE): Document that it returns a boolean.
2122 * editfns.c (Fformat):
2123 * fileio.c (Fexpand_file_name, Fsubstitute_in_file_name)
2124 (Fdo_auto_save):
2125 * fns.c (sweep_weak_table):
2126 * lisp.h (suppress_checking, push_message, survives_gc_p)
2127 (make_pure_string, gc_in_progress, abort_on_gc):
2128 * lread.c (readchar, read1):
2129 * print.c (Fprin1_to_string):
2130 * xdisp.c (push_message):
2131 Use bool for booleans affected directly or indirectly by
2132 alloc.c's changes.
2133
d0d2d26f
PE
2134 Make recently-introduced setters macros.
2135 * fontset.c (set_fontset_id, set_fontset_name, set_fontset_ascii)
2136 (set_fontset_base, set_fontset_frame, set_fontset_nofont_face)
2137 (set_fontset_default, set_fontset_fallback): Rename from their
2138 upper-case counterparts, and make them functions rather than macros.
2139 This is more consistent with the other recently-introduced setters.
2140 These don't need to be inline, since they're local.
2141
d18e2bb6
JD
21422012-08-21 Jan Djärv <jan.h.d@swipnet.se>
2143
2144 * nsterm.m (fd_handler:): Alloc and release a NSAutoreleasePool in
2145 the loop (Bug#12247).
2146
1b9d9d16
PE
21472012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2148
2149 * lisp.h (vcopy): Use memcpy rather than our own loop.
2150 This fixes a performance regression introduced by the recent
2151 addition of vcopy. This means 'vcopy' will need to be modified
2152 for a copying collector, but that's OK. Also, tighten the
2153 checking in the assertion.
2154
b2f09701
EZ
21552012-08-21 Eli Zaretskii <eliz@gnu.org>
2156
2157 * w32uniscribe.c (uniscribe_shape): Fix producing gstring
2158 components for RTL text (Bug#11860). Adjust X-OFFSET of each
2159 non-base glyph for the width of the base character, according to
e1f29348
BR
2160 what x_draw_composite_glyph_string_foreground expects.
2161 Generate WADJUST value according to composition_gstring_width's
b2f09701
EZ
2162 expectations, to produce correct width of the composed character.
2163 Reverse the sign of the DU offset produced by ScriptPlace.
2164
9b994fed
PE
21652012-08-21 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 * dbusbind.c (xd_remove_watch): Do not assume C99 comments.
2168
086ca913
DA
21692012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2170
2171 Avoid direct writes to contents member of struct Lisp_Vector.
2172 * lisp.h (vcopy): New function to copy data into vector.
2173 * dispnew.c (Fframe_or_buffer_changed_p): Use AREF and ASET.
2174 * fns.c (Ffillarray): Use ASET.
2175 * keyboard.c (timer_check_2): Use AREF and ASET.
2176 (append_tool_bar_item, Frecent_keys): Use vcopy.
2177 * lread.c (read_vector): Use ASET.
2178 * msdos.c (Frecent_doskeys): Use vcopy.
2179 * xface.c (Finternal_copy_lisp_face): Use vcopy.
2180 (Finternal_merge_in_global_face): Use ASET and vcopy.
2181 * xfont.c (xfont_list_pattern): Likewise.
2182
5481664a
MR
21832012-08-21 Martin Rudalics <rudalics@gmx.at>
2184
2185 * window.c (Fwindow_point): For the selected window always return
2186 the position of its buffer's point.
2187 (Fset_window_point): For the selected window always go in its
2188 buffer to the specified position.
2189
6d470bdd
DA
21902012-08-21 Dmitry Antipov <dmantipov@yandex.ru>
2191
2192 Setter macros for fontsets.
2193 * fontset.c (SET_FONTSET_ID, SET_FONTSET_NAME, SET_FONTSET_ASCII)
2194 (SET_FONTSET_BASE, SET_FONTSET_FRAME, SET_FONTSET_NOFONT_FACE)
2195 (SET_FONTSET_DEFAULT, SET_FONTSET_FALLBACK): New macros.
2196 Adjust users.
2197
24564fe1
GM
21982012-08-20 Glenn Morris <rgm@gnu.org>
2199
2200 * Makefile.in (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2201 Don't assume that `ln -f' works.
2202
0a05a035
EZ
22032012-08-20 Eli Zaretskii <eliz@gnu.org>
2204
2205 * .gdbinit: Use "set $dummy = ..." to avoid warnings from GDB 7.5
2206 and later about non-assignments with no effect. See discussion at
2207 http://sourceware.org/ml/gdb-patches/2012-08/msg00518.html for
2208 details.
2209
e46f2325
DA
22102012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2211
2212 Inline setter functions for Lisp_Objects slots of struct specbinding.
2213 * eval.c (set_specpdl_symbol, set_specpdl_old_value): New functions.
2214 Adjust users.
2215
734fbd86
MR
22162012-08-20 Martin Rudalics <rudalics@gmx.at>
2217
2218 * window.c (select_window): Always make selected window's buffer
2219 current.
2220
f1a95992
DA
22212012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2222
2223 Use AREF and ASET for docstrings of category tables.
2224 * category.h (CATEGORY_DOCSTRING): Use AREF.
2225 (SET_CATEGORY_DOCSTRING): Use ASET.
2226 * category.c (Fdefine_category): Use SET_CATEGORY_DOCSTRING.
2227
e83064be
DA
22282012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 Inline setter functions for hash table members.
2231 * lisp.h (set_hash_key, set_hash_value, set_hash_next)
2232 (set_hash_hash, set_hash_index): Rename with _slot suffix.
2233 (set_hash_key_and_value, set_hash_index, set_hash_next)
2234 (set_hash_hash): New functions.
2235 * charset.c, fns.c: Adjust users.
2236
4ce60d2e
DA
22372012-08-20 Dmitry Antipov <dmantipov@yandex.ru>
2238
2239 Inline getter and setter functions for per-buffer values.
2240 * buffer.h (per_buffer_default, set_per_buffer_default)
2241 (per_buffer_value, set_per_buffer_value): New functions.
2242 (PER_BUFFER_VALUE, PER_BUFFER_DEFAULT): Remove.
2243 * buffer.c, data.c: Adjust users.
2244
c06c9690
JB
22452012-08-20 Juanma Barranquero <lekktu@gmail.com>
2246
2247 * makefile.w32-in ($(BLD)/vm-limit.$(O)): Update dependencies.
2248
32bd4250
PE
22492012-08-19 Paul Eggert <eggert@cs.ucla.edu>
2250
bad03192 2251 Rely on <config.h> + <unistd.h> to declare 'environ',
b69a6d22
PE
2252 as gnulib does this if the system doesn't.
2253 * callproc.c, editfns.c, process.c (environ) [!USE_CRT_DLL]:
72279493
EZ
2254 Remove declaration. MS-Windows declares it on stdlib.h which is
2255 included by conf_post.h.
b69a6d22
PE
2256 * emacs.c (environ) [DOUG_LEA_MALLOC]:
2257 * vm-limit.c (environ) [ORDINARY_LINK]: Remove decl.
2258 * vm-limit.c: Include <unistd.h>, for 'environ'.
2259
22d7feb2
PE
2260 * unexaix.c, unexcoff.c: Include "mem-limits.h".
2261 (start_of_data): Remove decl; mem-limits.h provides it.
2262
32bd4250
PE
2263 * xdisp.c (handle_invisible_prop): Make it a bit faster
2264 and avoid a gcc -Wmaybe-uninitialized diagnostic.
2265
450809af
CY
22662012-08-19 Chong Yidong <cyd@gnu.org>
2267
2268 * xdisp.c (handle_invisible_prop): Fix ellipses at overlay string
2269 ends (Bug#3874).
2270
9e677988
AS
22712012-08-19 Andreas Schwab <schwab@linux-m68k.org>
2272
6b1319ce
AS
2273 * .gdbinit: Use call instead of set when calling a function in the
2274 inferior.
2275
9e677988
AS
2276 * data.c (set_internal): Don't use set_blv_found.
2277 (Fkill_local_variable): Likewise.
2278
d7191076
AA
22792012-08-18 Alp Aker <alp.tekin.aker@gmail.com>
2280
2281 * nsfont.m (ns_ascii_average_width): Ensure the string
2282 ascii_printable is initialized with a null-terminated character
2283 array. Otherwise, it can contain undesired extra characters.
2284
e757f1c6
PE
22852012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2286
2287 port new setting code to Sun C 5.8 2005/10/13
2288 * chartab.c, lisp.h (char_table_set, char_table_set_range):
2289 Return void, not Lisp_Object. Otherwise, the compiler
2290 complains about (A?B:C) where B is void and C is Lisp_Object
2291 when compiling CHAR_TABLE_SET, due to the recent change to
2292 the API of sub_char_table_set_contents.
2293
a999ce26
CY
22942012-08-18 Chong Yidong <cyd@gnu.org>
2295
2296 * xdisp.c (handle_invisible_prop): Obey TEXT_PROP_MEANS_INVISIBLE
2297 for the string case (Bug#3874).
2298
3f22b86f
PE
22992012-08-18 Paul Eggert <eggert@cs.ucla.edu>
2300
39eb03f1
PE
2301 * buffer.h (BSET): Remove (Bug#12215).
2302 Replace all uses with calls to new setter functions.
2303 (bset_bidi_paragraph_direction, bset_case_canon_table)
2304 (bset_case_eqv_table, bset_directory, bset_display_count)
2305 (bset_display_time, bset_downcase_table)
2306 (bset_enable_multibyte_characters, bset_filename, bset_keymap)
2307 (bset_last_selected_window, bset_local_var_alist)
2308 (bset_mark_active, bset_point_before_scroll, bset_read_only)
2309 (bset_truncate_lines, bset_undo_list, bset_upcase_table)
2310 (bset_width_table):
2311 * buffer.c (bset_abbrev_mode, bset_abbrev_table)
2312 (bset_auto_fill_function, bset_auto_save_file_format)
2313 (bset_auto_save_file_name, bset_backed_up, bset_begv_marker)
2314 (bset_bidi_display_reordering, bset_buffer_file_coding_system)
2315 (bset_cache_long_line_scans, bset_case_fold_search)
2316 (bset_ctl_arrow, bset_cursor_in_non_selected_windows)
2317 (bset_cursor_type, bset_display_table, bset_extra_line_spacing)
2318 (bset_file_format, bset_file_truename, bset_fringe_cursor_alist)
2319 (bset_fringe_indicator_alist, bset_fringes_outside_margins)
2320 (bset_header_line_format, bset_indicate_buffer_boundaries)
2321 (bset_indicate_empty_lines, bset_invisibility_spec)
2322 (bset_left_fringe_width, bset_major_mode, bset_mark)
2323 (bset_minor_modes, bset_mode_line_format, bset_mode_name)
2324 (bset_name, bset_overwrite_mode, bset_pt_marker)
2325 (bset_right_fringe_width, bset_save_length)
2326 (bset_scroll_bar_width, bset_scroll_down_aggressively)
2327 (bset_scroll_up_aggressively, bset_selective_display)
2328 (bset_selective_display_ellipses, bset_vertical_scroll_bar_type)
2329 (bset_word_wrap, bset_zv_marker):
2330 * category.c (bset_category_table):
2331 * syntax.c (bset_syntax_table):
2332 New setter functions.
2333
6a09a33b
PE
2334 * process.h (PSET): Remove (Bug#12215).
2335 Replace all uses with calls to new setter functions.
2336 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2337 (PROCESS_INLINE): New macro.
2338 (pset_childp): New setter function.
2339 (pset_gnutls_cred_type) [HAVE_GNUTLS]: New setter function.
2340 * process.c (PROCESS_INLINE):
2341 Define to EXTERN_INLINE, so that the corresponding functions
2342 are compiled into code.
2343 (pset_buffer, pset_command, pset_decode_coding_system)
2344 (pset_decoding_buf, pset_encode_coding_system)
2345 (pset_encoding_buf, pset_filter, pset_log, pset_mark, pset_name)
2346 (pset_plist, pset_sentinel, pset_status, pset_tty_name)
2347 (pset_type, pset_write_queue): New setter functions.
2348
e8c17b81
PE
2349 * window.h (WSET): Remove (Bug#12215).
2350 Replace all uses with calls to new setter functions.
2351 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2352 (WINDOW_INLINE): New macro.
2353 (wset_buffer, wset_frame, wset_left_col, wset_next, wset_prev)
2354 (wset_redisplay_end_trigger, wset_top_line, wset_total_cols)
2355 (wset_total_lines, wset_vertical_scroll_bar)
2356 (wset_window_end_pos, wset_window_end_valid)
2357 (wset_window_end_vpos): New setter functions.
2358 * window.c (WINDOW_INLINE):
2359 Define to EXTERN_INLINE, so that the corresponding functions
2360 are compiled into code.
2361 (wset_combination_limit, wset_dedicated, wset_display_table)
2362 (wset_hchild, wset_left_fringe_width, wset_left_margin_cols)
2363 (wset_new_normal, wset_new_total, wset_next_buffers)
2364 (wset_normal_cols, wset_normal_lines, wset_parent, wset_pointm)
2365 (wset_prev_buffers, wset_right_fringe_width)
2366 (wset_right_margin_cols, wset_scroll_bar_width, wset_start)
2367 (wset_temslot, wset_vchild, wset_vertical_scroll_bar_type)
2368 (wset_window_parameters):
2369 * xdisp.c (wset_base_line_number, wset_base_line_pos)
2370 (wset_column_number_displayed, wset_region_showing):
2371 New setter functions.
2372
3f22b86f
PE
2373 * termhooks.h (TSET): Remove (Bug#12215).
2374 Replace all uses with calls to new setter functions.
2375 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2376 (TERMHOOKS_INLINE): New macro.
2377 (tset_charset_list, tset_selection_alist): New setter functions.
2378 * terminal.c (TERMHOOKS_INLINE):
2379 Define to EXTERN_INLINE, so that the corresponding functions
2380 are compiled into code.
2381 (tset_param_alist): New setter function.
2382
742af32f
PE
23832012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2384
15dbb4d6
PE
2385 * keyboard.h (KSET): Remove (Bug#12215).
2386 Replace all uses with calls to new setter functions.
2387 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2388 (KEYBOARD_INLINE): New macro.
2389 (kset_default_minibuffer_frame, kset_defining_kbd_macro)
2390 (kset_input_decode_map, kset_last_command, kset_last_kbd_macro)
2391 (kset_prefix_arg, kset_system_key_alist, kset_window_system):
2392 New setter functions.
2393 * keyboard.c (KEYBOARD_INLINE):
2394 Define to EXTERN_INLINE, so that the corresponding functions
2395 are compiled into code.
2396 (kset_echo_string, kset_kbd_queue)
2397 (kset_keyboard_translate_table, kset_last_prefix_arg)
2398 (kset_last_repeatable_command, kset_local_function_key_map)
2399 (kset_overriding_terminal_local_map, kset_real_last_command)
2400 (kset_system_key_syms): New setter functions.
2401
f00af5b1
PE
2402 * frame.h (FSET): Remove (Bug#12215).
2403 Replace all uses with calls to new setter functions.
2404 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2405 (FRAME_INLINE): New macro.
2406 (fset_buffer_list, fset_buried_buffer_list, fset_condemned_scroll_bars)
2407 (fset_current_tool_bar_string, fset_desired_tool_bar_string)
2408 (fset_face_alist, fset_focus_frame, fset_icon_name, fset_menu_bar_items)
2409 (fset_menu_bar_vector, fset_menu_bar_window, fset_name)
2410 (fset_param_alist, fset_root_window, fset_scroll_bars)
2411 (fset_selected_window, fset_title, fset_tool_bar_items)
2412 (fset_tool_bar_position, fset_tool_bar_window): New functions.
2413 * frame.c (FRAME_INLINE):
2414 Define to EXTERN_INLINE, so that the corresponding functions
2415 are compiled into code.
2416 (fset_buffer_predicate, fset_minibuffer_window): New setter functions.
2417
0c94c8d6
PE
2418 A few more naming-convention fixes for getters and setters.
2419 * buffer.c (set_buffer_overlays_before): Move here from buffer.h,
2420 and rename from buffer_overlays_set_before.
2421 (set_buffer_overlays_after): Move here from buffer.h, and rename
2422 from buffer_overlays_set_after.
2423 * buffer.h (buffer_intervals): Rename from buffer_get_intervals.
2424 All uses changed.
2425 (set_buffer_intervals): Rename from buffer_set_intervals.
2426 * intervals.c (set_interval_object): Move here from intervals.h,
2427 and rename from interval_set_object.
2428 (set_interval_left): Move here from intervals.h, and rename from
2429 interval_set_left.
2430 (set_interval_right): Move here from intervals.h, and rename from
2431 interval_set_right.
2432 (copy_interval_parent): Move here from intervals.h, and rename from
2433 interval_copy_parent.
2434 * intervals.h (set_interval_parent): Rename from interval_set_parent.
2435 (set_interval_plist): Rename from interval_set_plist.
2436 Return void, not Lisp_Object, since no caller uses the result.
2437 * lisp.h (string_intervals): Rename from string_get_intervals.
2438 (set_string_intervals): Rename from string_set_intervals.
2439
34dabdb7
PE
2440 * lisp.h (set_char_table_extras): Rename from char_table_set_extras.
2441 (set_char_table_contents): Rename from char_table_set_contents.
0b390a9d 2442 (set_sub_char_table_contents): Rename from sub_char_table_set_contents.
34dabdb7
PE
2443 All uses changed. See the end of
2444 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00549.html>.
2445
742af32f
PE
2446 * lisp.h (CSET): Remove (Bug#12215).
2447 (set_char_table_ascii, set_char_table_defalt, set_char_table_parent)
2448 (set_char_table_purpose): New functions,
2449 replacing CSET. All uses changed. For example, replace
2450 "CSET (XCHAR_TABLE (char_table), parent, parent);" with
c24eb18a 2451 "set_char_table_parent (char_table, parent);".
742af32f
PE
2452 The old version was confusing because it used the same name
2453 'parent' for two different things.
2454
a04e2c62
DA
24552012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2456
2457 Functions to get and set Lisp_Object fields of buffer-local variables.
2458 * lisp.h (blv_found, set_blv_found, blv_value, set_blv_value)
2459 (set_blv_where, set_blv_defcell, set_blv_valcell): New functions.
2460 (BLV_FOUND, SET_BLV_FOUND, BLV_VALUE, SET_BLV_VALUE): Remove.
2461 * data.c, eval.c, frame.c: Adjust users.
2462
383dcbf9
CY
24632012-08-17 Chong Yidong <cyd@gnu.org>
2464
2465 * xfaces.c (merge_face_vectors): If the target font specfies a
2466 font spec, make the font's attributes take precedence over
2467 directly-specified attributes.
2468 (merge_face_ref): Recognize :font.
2469
44386687
DA
24702012-08-17 Dmitry Antipov <dmantipov@yandex.ru>
2471
2472 Do not use memcpy for copying intervals.
2473 * intervals.c (reproduce_interval): New function.
2474 (reproduce_tree, reproduce_tree_obj): Use it.
2475 (reproduce_tree_obj): Remove prototype.
2476
927c7216
PE
24772012-08-17 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 * lisp.h (duration_to_sec_usec): Remove unused decl.
2480
93044f7b
AA
24812012-08-17 Alp Aker <alp.tekin.aker@gmail.com>
2482
2483 * nsfont.m (ns_ascii_average_width): Send initWithFormat selector
2484 to an allocated instance of NSString, not to the class itself.
2485
9851e4a5
JB
24862012-08-17 Juanma Barranquero <lekktu@gmail.com>
2487
2488 * makefile.w32-in (C_CTYPE_H): New macro.
2489 (LISP_H, $(BLD)/ccl.$(O), $(BLD)/doc.$(O), $(BLD)/w32console.$(O)):
2490 ($(BLD)/fontset.$(O), $(BLD)/frame.$(O), $(BLD)/composite.$(O)):
2491 ($(BLD)/sysdep.$(O), $(BLD)/w32uniscribe.$(O)): Update dependencies.
2492
620f13b0
PE
24932012-08-16 Paul Eggert <eggert@cs.ucla.edu>
2494
2495 Use ASCII tests for character types.
2496 * category.c, dispnew.c, doprnt.c, editfns.c, syntax.c, term.c:
2497 * xfns.c, xterm.c:
2498 Don't include <ctype.h>; was not needed.
2499 * charset.c, doc.c, fileio.c, font.c, frame.c, gtkutil.c, image.c:
2500 * sysdep.c, xfaces.c:
2501 Include <c-ctype.h> instead of <ctype.h>.
2502 * nsterm.m: Include <c-ctype.h>.
2503 * charset.c (read_hex):
2504 * doc.c (Fsnarf_documentation):
2505 * fileio.c (IS_DRIVE) [WINDOWSNT]:
2506 (DRIVE_LETTER) [DOS_NT]:
2507 (Ffile_name_directory, Fexpand_file_name)
2508 (Fsubstitute_in_file_name):
2509 * font.c (font_parse_xlfd, font_parse_fcname):
2510 * frame.c (x_set_font_backend):
2511 * gtkutil.c (xg_get_font):
2512 * image.c (xbm_scan, xpm_scan, pbm_scan_number):
2513 * nsimage.m (hexchar):
2514 * nsterm.m (ns_xlfd_to_fontname):
2515 * sysdep.c (system_process_attributes):
2516 * xfaces.c (hash_string_case_insensitive):
2517 Use C-locale tests instead of locale-specific tests for character
2518 types, since we want the ASCII interpretation here, not the
2519 interpretation suitable for whatever happens to be the current locale.
2520
52162052
MR
25212012-08-16 Martin Rudalics <rudalics@gmx.at>
2522
2523 Consistently check windows for validity/liveness
2524 (Bug#11984, Bug#12025, Bug#12026).
2525 * lisp.h (CHECK_VALID_WINDOW): New macro.
2526 * window.c (decode_window): Rename to decode_live_window.
2527 (decode_valid_window, Fwindow_valid_p): New functions.
2528 (Fwindow_frame, Fframe_root_window, Fwindow_minibuffer_p)
2529 (Fframe_first_window, Fframe_selected_window, Fwindow_parent)
2530 (Fwindow_top_child, Fwindow_left_child, Fwindow_next_sibling)
2531 (Fwindow_prev_sibling, Fwindow_combination_limit)
2532 (Fset_window_combination_limit, Fwindow_use_time)
2533 (Fwindow_total_height, Fwindow_total_width, Fwindow_new_total)
2534 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_left_column)
2535 (Fwindow_top_line, Fwindow_body_height, Fwindow_body_width)
2536 (Fwindow_hscroll, Fset_window_hscroll)
2537 (Fwindow_redisplay_end_trigger)
2538 (Fset_window_redisplay_end_trigger, Fwindow_edges)
2539 (Fwindow_pixel_edges, Fwindow_absolute_pixel_edges)
2540 (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2541 (Fcoordinates_in_window_p, Fwindow_point, Fwindow_start)
2542 (Fwindow_end, Fset_window_point, Fset_window_start)
2543 (Fpos_visible_in_window_p, Fwindow_line_height)
2544 (Fwindow_dedicated_p, Fset_window_dedicated_p)
2545 (Fwindow_prev_buffers, Fset_window_prev_buffers)
2546 (Fwindow_next_buffers, Fwindow_parameters, Fwindow_parameter)
2547 (Fset_window_parameter, Fwindow_display_table)
2548 (Fset_window_display_table, Fdelete_other_windows_internal)
2549 (Fset_window_buffer, Fset_window_new_total)
2550 (Fset_window_new_normal, Fdelete_window_internal)
2551 (Fwindow_text_height, Fset_window_margins, Fwindow_margins)
2552 (Fset_window_fringes, Fwindow_fringes, Fset_window_scroll_bars)
2553 (Fwindow_scroll_bars): Check whether argument window is a valid or
2554 live window. Update doc-strings.
2555 (syms_of_window): New symbol Qwindow_valid_p.
2556 * keyboard.c (Fposn_at_x_y): Check whether argument
2557 frame_or_window denotes a valid window.
2558
2751c80f
DA
25592012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2560
2561 Fix previous char table change.
2562 * lisp.h (CHAR_TABLE_SET): Use sub_char_table_set_contents.
2563 * chartab.c (optimize_sub_char_table): Likewise.
2564
032a42c8
CY
25652012-08-16 Chong Yidong <cyd@gnu.org>
2566
a2d19368
CY
2567 * gtkutil.c (xg_get_font): Demand an Xft font (Bug#3228).
2568
032a42c8
CY
2569 * xfont.c (xfont_open):
2570 * xftfont.c (xftfont_open): Set the font's max_width field.
2571
2572 * nsfont.m (nsfont_open): Similar to the Xft backend, set
2573 min_width to space_width and average_width to the average over
2574 printable ASCII characters.
2575 (ns_char_width): Code cleanup.
2576 (ns_ascii_average_width): New utility function.
2577
2578 * font.h (struct font): Update comments.
2579
a098c930
DA
25802012-08-16 Dmitry Antipov <dmantipov@yandex.ru>
2581
032a42c8 2582 Simple interface to set Lisp_Object fields of character tables.
a098c930
DA
2583 * lisp.h (CSET): New macro.
2584 (char_table_set_extras, char_table_set_contents)
2585 (sub_char_table_set_contents): New function.
2586 * casetab.c, category.c, chartab.c, fns.c, fontset.c, search.c:
2587 * syntax.c: Adjust users.
2588
8be3a09c
SM
25892012-08-16 Stefan Monnier <monnier@iro.umontreal.ca>
2590
2591 * eval.c (eval_sub): Bind lexical-binding.
2592 * lread.c (Qlexical_binding): Make non-static.
2593
ac4845a6
JD
25942012-08-15 Jan Djärv <jan.h.d@swipnet.se>
2595
ddee6515
JD
2596 * nsmenu.m (popupSession): Remove.
2597 (pop_down_menu): Remove endModalSession.
2598 (timeout_handler:): New method.
2599 (runDialogAt:): Get next timeout. Start a NSTimer with that timeout.
2600 Call runModalForWindow. Check timer_fired when it returns.
2601 If not set, cancel timer and break out of loop.
2602 Otherwise loop again, with a new timeout.
2603
2604 * nsterm.m: Include fcntl.h if present.
2605 (fd_entry, t_readfds, inNsSelect): Remove.
2606 (select_writefds, select_valid, select_timeout, selfds)
2607 (select_mutex, apploopnr): Add.
2608 (EV_TRAILER): Call kbd_buffer_store_event_hold only if q_event_ptr.
2609 Otherwise call kbd_buffer_store_event.
2610 (ns_send_appdefined): Remove release of fd_entry.
2611 (ns_read_socket): Always send appdefined. Remove inNsSelect check.
2612 Increment and decrement apploopnr.
2613 (ns_select): If no file descriptors, just do a NSTimer.
2614 Otherwise copy read/write masks and start select thread (fd_handler).
2615 Start main loop and wait for application defined event.
2616 Inform select thread to stop selecting after main loop is exited.
2617 (ns_term_init): Create selfds pipe and set non-blocking.
fc0c31f8 2618 Initialize select_mutex. Start the select thread (fd_handler).
ddee6515
JD
2619 (fd_handler:): Loop forever, wait for info from the main thread
2620 to either start or stop selecting. When select returns, send
2621 and appdefined event.
2622 (sendScrollEventAtLoc:fromEvent:): Check if q_event_ptr is set.
2623 If not call kbd_buffer_store_event.
2624
2625 * nsterm.h (EmacsApp): fd_handler takes id argument.
2626 (EmacsDialogPanel): Add timer_fired and timeout_handler.
2627
ac4845a6
JD
2628 * gtkutil.c (xg_mark_data): Use FRAME_X_P.
2629
eb424fe3
EZ
26302012-08-15 Eli Zaretskii <eliz@gnu.org>
2631
2632 * region-cache.c (move_cache_gap): Update gap_len using the actual
2633 growth of the boundaries array. Do not change cache_len.
2634 (Bug#12196)
2635
4e6a86c6
DA
26362012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 Generalize and cleanup font subsystem checks.
2639 * font.h (FONT_DEBUG, font_assert): Remove.
8be3a09c
SM
2640 * font.c, fontset.c, w32font.c, xfont.c, xftfont.c:
2641 Change font_assert to eassert. Use eassert where appropriate.
4e6a86c6 2642
5bf192ca
DA
26432012-08-15 Dmitry Antipov <dmantipov@yandex.ru>
2644
2645 * gtkutil.c (xg_get_font): Use pango_units_to_double.
2646
f2045622
CY
26472012-08-15 Chong Yidong <cyd@gnu.org>
2648
8be3a09c
SM
2649 * gtkutil.c (xg_get_font): Rename from xg_get_font_name.
2650 When using the new font chooser, use gtk_font_chooser_get_font_desc to
2651 extract the font descriptor instead of just the font name.
2652 In that case, return a font spec instead of a string.
f2045622
CY
2653 (x_last_font_name): Move to this file from xfns.c.
2654
2655 * xfns.c (Fx_select_font): The return value can also be a font
2656 spec. Move x_last_font_name management to gtkutil.c.
2657
2658 * xfaces.c: Make font weight and style symbols non-static.
2659
7f6feb56
SM
26602012-08-15 Stefan Monnier <monnier@iro.umontreal.ca>
2661
2662 * minibuf.c (read_minibuf): Ignore caller's inhibit-read-only
2663 (bug#12117).
2664
fecbd8ff
SM
26652012-08-14 Stefan Monnier <monnier@iro.umontreal.ca>
2666
2667 * alloc.c (Fgarbage_collect): Use plural form consistently.
2668
9b8d5165
EZ
26692012-08-14 Eli Zaretskii <eliz@gnu.org>
2670
2671 * keyboard.c (command_loop_1): Reset ignore_mouse_drag_p flag each
2672 iteration through the command loop. Fixes a problem whereby mouse
2673 movements are ignored until the first mouse click.
2674
f5d9e83a
PE
26752012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 Use bool, not int, for Lisp booleans.
2678 This is more natural, and on my platform (GCC 4.7.1 x86-64) it
2679 makes Emacs a bit smaller and presumably a bit faster.
2680 * lisp.h: Include <stdbool.h>.
2681 (struct Lisp_Boolfwd, defvar_bool):
2682 * lread.c (defvar_bool): Use bool, not int, for Lisp booleans.
2683 * regex.c [!emacs]: Include <stdbool.h>.
2684 (false, true): Remove; <stdbool.h> does this for us now.
2685
55802e4a
CY
26862012-08-14 Chong Yidong <cyd@gnu.org>
2687
4abcdac8
CY
2688 * character.c (Fcharacterp): Doc fix (Bug#12076).
2689
2690 * data.c (Findirect_variable): Doc fix (Bug#11040).
2691
55802e4a
CY
2692 * chartab.c (Fmap_char_table): Doc fix (Bug#12061).
2693
2694 * editfns.c (Fformat): Doc fix (Bug#12059).
4abcdac8 2695 (Fsave_current_buffer): Doc fix (Bug#11542).
55802e4a 2696
8e99d072
BR
26972012-08-14 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
2698
2699 * keyboard.c (access_keymap_keyremap): Accept anonymous functions
2700 (bug#12022).
2701
08908aca
MR
27022012-08-14 Martin Rudalics <rudalics@gmx.at>
2703
2704 * frame.c (make_frame_without_minibuffer, make_minibuffer_frame)
2705 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
2706 * minibuf.c (choose_minibuf_frame, read_minibuf):
2707 * w32fns.c (x_create_tip_frame):
2708 * xfns.c (x_create_tip_frame): Call set_window_buffer instead of
2709 Fset_window_buffer (Bug#11984, Bug#12025, Bug#12026).
2710
56120d6f
PE
27112012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2712
2713 * intervals.c (offset_intervals): Remove obsolete comment.
2714
67b77c0b
AS
27152012-08-14 Andreas Schwab <schwab@linux-m68k.org>
2716
2717 * gtkutil.c (find_rtl_image, update_frame_tool_bar): Use NILP.
2718
f48b82fd
GR
27192012-08-14 Gergely Risko <gergely@risko.hu>
2720
2721 * coding.c (decode_coding): Record buffer modification before
2722 disabling undo_list (Bug#11773).
2723
fd318b54
DA
27242012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2725
2726 Revert and cleanup some recent overlay changes.
2727 * buffer.h (enum overlay_type): Remove.
2728 (buffer_get_overlays, buffer_set_overlays): Likewise.
2729 (buffer_set_overlays_before, buffer_set_overlays_after):
2730 New function. Adjust users.
2731 (unchain_both): Add eassert.
2732
41a62dd9
DA
27332012-08-14 Dmitry Antipov <dmantipov@yandex.ru>
2734
2735 * gtkutil.c (update_frame_tool_bar): Use EQ where appropriate.
2736
5884c324
PE
27372012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 * gtkutil.c (xg_mark_data): Don't assume C99.
2740
ca06f160
JD
27412012-08-13 Jan Djärv <jan.h.d@swipnet.se>
2742
2743 * gtkutil.c (xg_frame_tb_info): New struct.
2744 (TB_INFO_KEY): New define.
2745 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
2746 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
2747 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
2748 if not present.
2749 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
fc0c31f8 2750 is up to date. Otherwise store new data.
ca06f160
JD
2751 (free_frame_tool_bar): Free xg_frame_tb_info if present.
2752
7864a3f7
DA
27532012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2754
2755 Use KSET for write access to Lisp_Object members of struct kboard.
2756 * keyboard.h (KSET): New macro.
2757 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
2758 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
2759 * xterm.c: Adjust users.
2760
4c31be61
DA
27612012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
2762
2763 Use BSET for write access to Lisp_Object members of struct buffer.
2764 * buffer.h (BSET): New macro.
2765 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
2766 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
2767 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
2768 * window.c, xdisp.c, xfns.c: Adjust users.
2769
14ae4239
BT
27702012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
2771
2772 * lread.c (syms_of_lread): Initialize Vlexical_binding.
2773
32bcadb4
JD
27742012-08-11 Jan Djärv <jan.h.d@swipnet.se>
2775
3d29b2ce 2776 * nsterm.m (not_in_argv): New function.
fc0c31f8 2777 (application:openFile, application:openTempFile:):
3d29b2ce
JD
2778 (application:openFileWithoutUI:, application:openFiles:): Open file
2779 if not_in_argv returns non-zero (bug#12171).
2780
32bcadb4 2781 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
2782 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
2783 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
2784 (xg_get_font_name): Use those functions/macros here.
2785 Reported by Frans Oilinki <moilinki@gmail.com>.
2786
9ff9402d 27872012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
2788
2789 * unexmacosx.c (copy_data_segment): Copy initialized data in
2790 statically linked libraries from input file rather than memory.
2791
db74a5fc
YM
2792 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
2793 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
2794 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
2795
25e65510
GM
27962012-08-10 Glenn Morris <rgm@gnu.org>
2797
2798 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
2799 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
2800
7961135c
DA
28012012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2802
2803 Fix last change to allow compilation with low optimization levels.
2804 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
2805 Reported by Jan Djärv <jan.h.d@swipnet.se>.
2806
42b3a444
DA
28072012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2808
2809 Use common inline syntax in intervals.h.
2810 * intervals.h (INTERVALS_INLINE): New macro.
2811 Change all users from LISP_INLINE.
2812
9fb0c957
DA
28132012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2814
2815 Define Qnone once for all platforms.
2816 * frame.c (Qnone): Define here.
2817 (syms_of_frame): DEFSYM it.
2818 * lisp.h (Qnone): New declaration.
2819 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
2820 * xfns.c: Remove duplication. Adjust users.
2821
65e8ee52
DA
28222012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
2823
2824 Remove unused macros from intervals.h.
2825 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
2826 * intervals.c: Adjust comment.
2827
9b855fd6
EZ
28282012-08-10 Eli Zaretskii <eliz@gnu.org>
2829
2830 * w32fns.c <w32_unicode_gui>: New static variable.
2831 (globals_of_w32fns): Initialize it according to os_subtype.
2832 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
2833 testing os_subtype.
2834
39cb9e56 28352012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
2836 Eli Zaretskii <eliz@gnu.org>
2837
2838 Fix bug #10299 with Unicode characters sent by customized
2839 keyboards created by MSKLC.
2840 * w32fns.c (INIT_WINDOW_CLASS): New macro.
2841 (w32_init_class): Use it to initialize the Emacs class with either
2842 ANSI or Unicode API calls.
2843 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
2844 later.
2845 (w32_wnd_proc): If the character code sent by WM_CHAR or
2846 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
2847 original message. Call DefWindowProcW on NT and later.
2848
9374581a
GM
28492012-08-10 Glenn Morris <rgm@gnu.org>
2850
4b94e8cf
GM
2851 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
2852
9374581a
GM
2853 * lisp.h (DIRECTORY_SEP): Let configure set it.
2854
a2752828
DA
28552012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
2856
2857 Use TSET for write access to Lisp_Object slots of struct terminal.
2858 * termhooks.h (TSET): New macro.
2859 * coding.c, terminal.c, xselect.c: Adjust users.
2860
cc92c454
SM
28612012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
2862
2863 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
2864 the failing expression, include them in the error message.
2865 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
2866 * lisp.h (internal_condition_case_n): Update declaration.
2867
4cb3e6b3
DA
28682012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2869
2870 Inline functions to examine and change buffer overlays.
2871 * buffer.c (unchain_both): New function.
2872 * buffer.h (buffer_get_overlays, buffer_set_overlays):
2873 (buffer_has_overlays): New function.
2874 (enum overlay_type): New enum.
2875 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
2876 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
2877
8707c1e5
DA
28782012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2879
2880 Inline functions to examine and change buffer intervals.
2881 * alloc.c (mark_interval_tree): Remove.
2882 (MARK_INTERVAL_TREE): Simplify.
2883 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
2884 * intervals.c (buffer_balance_intervals): New function.
2885 (graft_intervals_into_buffer): Adjust indentation.
2886 (set_intervals_multibyte): Simplify.
2887 * buffer.h (BUF_INTERVALS): Remove.
2888 (buffer_get_intervals, buffer_set_intervals): New function.
2889 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
2890 * intervals.c, textprop.c: Adjust users.
2891
ad8c997f
DA
28922012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2893
2894 Inline functions to examine and change string intervals.
2895 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
2896 (string_get_intervals, string_set_intervals): New function.
2897 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2898 * lread.c, print.c, textprop.c: Adjust users.
2899
32ac3a6b
GM
29002012-08-08 Glenn Morris <rgm@gnu.org>
2901
2902 * lisp.mk (lisp): Remove language/persian.elc.
2903
77c7bcb1
DA
29042012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2905
2906 Cleanup intervals.
2907 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
2908 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
2909 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
2910 Adjust comment. Move under #if 0.
77c7bcb1
DA
2911 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
2912 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
2913
9c08a8d4
DA
29142012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
2915
2916 Check total length of intervals with eassert.
2917 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
2918 * intervals.c: Change all users to eassert.
2919
26d16b35
EZ
29202012-08-07 Eli Zaretskii <eliz@gnu.org>
2921
14ae4239
BT
2922 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
2923 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
2924 INTERNAL_FIELD in Lisp_Cons.
2925
c644523b
DA
29262012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2927
2928 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
2929 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
2930 name since all xname users are fixed long time ago. Do not
2931 use INTERNAL_FIELD.
2932 (set_symbol_name, set_symbol_function, set_symbol_plist):
2933 (set_symbol_next, set_overlay_plist): New function.
2934 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
2935 (struct Lisp_Overlay): Likewise.
2936 (CVAR, MVAR, SVAR): Remove.
2937 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
2938 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
2939 * xterm.c: Adjust users.
2940 * .gdbinit: Change to use name field of struct Lisp_Symbol
2941 where appropriate.
2942
6a3d20cc
DA
29432012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2944
2945 Basic functions to set Lisp_Object and pointer slots of intervals.
2946 * intervals.h (interval_set_parent, interval_set_object):
2947 (interval_set_left, interval_set_right, interval_set_plist):
2948 (interval_copy_parent): New function.
2949 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
2950 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
2951 Adjust indentation.
6a3d20cc
DA
2952 (INTERVAL_SIZE): Remove. Adjust users.
2953 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
2954
4d2b044c
DA
29552012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2956
2957 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
2958 * process.h (PGET): Remove.
2959 (struct Lisp_Process): Do not use INTERNAL_FIELD.
2960 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
2961
d3d50620
DA
29622012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2963
2964 Drop WGET and revert read access to Lisp_Objects slots of struct window.
2965 * window.h (WGET): Remove.
2966 (struct window): Do not use INTERNAL_FIELD.
2967 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
2968 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
2969 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
2970 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
2971 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
2972 Adjust users.
2973
d10a51dc
CY
29742012-08-07 Chong Yidong <cyd@gnu.org>
2975
2976 * window.c (Fwindow_edges, Fwindow_pixel_edges)
2977 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
2978 (Fdelete_window_internal): Signal an error if the window is not on
2979 a live frame (Bug#12025).
2980
e69b0960
DA
29812012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
2982
2983 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
2984 * frame.h (FGET): Remove.
2985 (struct frame): Do not use INTERNAL_FIELD.
2986 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
2987 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
2988 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
2989 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
2990
25a20a3a
JB
29912012-08-06 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * w32.c: Silence compiler warnings.
2994 (map_w32_filename): Remove unused variable `is_fat'.
2995 (chase_symlinks): Add parentheses around expression.
2996
1c6f11f4
GM
29972012-08-06 Glenn Morris <rgm@gnu.org>
2998
1db4583a
GM
2999 * sysdep.c: Respect BROKEN_GETWD.
3000
1c6f11f4
GM
3001 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
3002 Let configure handle it.
3003 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
3004
2b90362b
DA
30052012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3006
3007 Use GCALIGNMENT where appropriate.
3008 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
3009 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
3010 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
3011
5f50daf2
EZ
30122012-08-06 Eli Zaretskii <eliz@gnu.org>
3013
14ae4239
BT
3014 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
3015 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 3016
cbcc7007
SM
30172012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * buffer.h (struct buffer): Revert `indirections' to a simple int;
3020 that should be sufficient for everyone.
3021
4d365fa4
JD
30222012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3023
3024 * keyboard.c (timer_check_2): Add break so timer_check returns next
3025 timeout.
3026
dd86bd82
DA
30272012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3028
3029 Fix Windows build errors introduced after converting to WGET and WSET.
3030 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
3031 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3032
054e1668
JD
30332012-08-06 Jan Djärv <jan.h.d@swipnet.se>
3034
3035 * nsterm.m (ns_frame_rehighlight): Use FSET.
3036
3037 * nsmenu.m (ns_update_menubar): Use FSET.
3038
21238f11
DA
30392012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3040
3041 Separate read and write access to Lisp_Object slots of Lisp_Process.
3042 * process.h (PGET, PSET): New macros similar to AREF and ASET.
3043 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
3044
077288cf
DA
30452012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3046
3047 Separate read and write access to Lisp_Object slots of struct window.
3048 * window.h (WGET, WSET): New macros similar to AREF and ASET.
3049 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3050 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3051 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
3052 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
3053 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
3054 Adjust users.
3055
71688bd7
DA
30562012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3057
3058 Fix Windows build errors introduced after converting to FGET and FSET.
3059 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
3060 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
3061 (w32_judge_scroll_bars): Change to use FSET.
3062 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
3063
f99bac93
DA
30642012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3065
3066 Fix replacement typo.
3067 * window.c (replace_window): Set root_window instead of
3068 selected_window. This fixes a total window subsystem
3069 malfunction reported by Bastien Guerry <bzg@gnu.org>.
3070
8c2a0f2d
GM
30712012-08-06 Glenn Morris <rgm@gnu.org>
3072
3073 * lisp.mk (lisp): Add language/persian.elc.
3074
edd74c35
DA
30752012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
3076
3077 Separate read and write access to Lisp_Object slots of struct frame.
3078 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
3079 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
3080 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
3081 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
3082 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
3083
8671676c
AS
30842012-08-05 Andreas Schwab <schwab@linux-m68k.org>
3085
3086 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
3087
663e2b3f
DA
30882012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
3089
3090 Generalize common compile-time constants.
3091 * lisp.h (header_size, bool_header_size, word_size): Now here.
3092 (struct Lisp_Vector): Add comment.
3093 (struct Lisp_Bool_Vector): Move up to define handy constants.
3094 (VECSIZE, PSEUDOVECSIZE): Simplify.
3095 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
3096 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
3097 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
3098 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
3099 * xfont.c, xmenu.c: Use word_size where appropriate.
3100
d32e47af
LM
31012012-08-05 Lawrence Mitchell <wence@gmx.li>
3102
3103 * search.c (Freplace_match): Treat \? in the replacement text
3104 literally (Bug#8161).
3105
e5d9c0d1
CY
31062012-08-05 Chong Yidong <cyd@gnu.org>
3107
3108 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
3109 * frame.c (Vdelete_frame_functions):
3110 * emacs.c (Vkill_emacs_hook): Doc fix.
3111
8da0576b
EZ
31122012-08-04 Eli Zaretskii <eliz@gnu.org>
3113
3114 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
3115 --with-x-toolkit=no builds.
3116 Reported by Carsten Mattner <carstenmattner@gmail.com>.
3117
02676e5d
CY
31182012-08-04 Chong Yidong <cyd@gnu.org>
3119
3120 * syntax.c (Fmodify_syntax_entry): Doc fix.
3121
97147da9
EZ
31222012-08-04 Eli Zaretskii <eliz@gnu.org>
3123
76151e2c
EZ
3124 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
3125 * w32.c (init_environment): Change the default values of many
3126 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
3127 them into environment when they were not already defined.
3128 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 3129 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
3130 (check_windows_init_file): Now external, not static.
3131 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
3132 called when Vload_path is already set up.
3133
3134 * w32.h (check_windows_init_file): Add prototype.
3135
3136 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
3137 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
3138 compatibility with Posix platforms.
3139 (main): Move the call to check_windows_init_file to here from
3140 w32.c.
3141 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
3142 any, in the DEFALT argument into the root of the Emacs build or
3143 installation tree, as appropriate.
3144
3145 * callproc.c (init_callproc_1): Call decode_env_path instead of
3146 doing its equivalent by hand.
3147 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
3148 the code that sets Vexec_path run on MS-Windows.
3149
3150 * lread.c (init_lread): Add comments to #ifdef's.
3151
97147da9
EZ
3152 * msdos.c (dos_set_window_size, IT_update_begin)
3153 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
3154 instead of direct references.
3155
185ee146
PE
31562012-08-04 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 Export DEFAULT_REHASH_* to GDB.
3159 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
3160 Now constants, not macros.
3161
8834c57a
PE
31622012-08-03 Paul Eggert <eggert@cs.ucla.edu>
3163
98c6f1e3
PE
3164 Remove unnecessary casts involving pointers.
3165 These casts are no longer needed now that we assume C89 or later,
3166 since they involve casting to or from void *.
3167 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
3168 (make_pure_float, make_pure_vector):
3169 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
3170 * macros.c (Fstart_kbd_macro):
3171 * menu.c (find_and_return_menu_selection):
3172 * minibuf.c (read_minibuf_noninteractive):
3173 * sysdep.c (closedir):
3174 * xdisp.c (x_produce_glyphs):
3175 * xfaces.c (compare_fonts_by_sort_order):
3176 * xfns.c (x_real_positions, select_visual):
3177 * xselect.c (x_stop_queuing_selection_requests)
3178 (x_get_window_property, x_get_window_property_as_lisp_data):
3179 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
3180 Remove unnecessary pointer casts.
3181 * alloc.c (record_xmalloc): New function.
3182 * lisp.h (record_xmalloc): New decl.
3183 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
3184 more like a function. This is because the pointer cast is not
3185 needed. All uses changed.
3186 * print.c (print_string, print_error_message): Avoid length recalc.
3187
8834c57a
PE
3188 Improve fix for macroexp crash with debugging (Bug#12118).
3189 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
3190 ARRAY_MARK_FLAG when checking subscripts, because ASET is
3191 not supposed to be invoked from the garbage collector.
3192 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
3193 (gc_aset): New function, which is like ASET but can be
3194 used in the garbage collector.
3195 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3196 (set_hash_index): Use it instead of ASET.
3197
6dad7178
EZ
31982012-08-03 Eli Zaretskii <eliz@gnu.org>
3199
3200 Support symlinks on latest versions of MS-Windows.
3201 * w32.c: Include winioctl.h and aclapi.h.
3202 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
3203 (revert_to_self): Forward declarations of static functions.
3204 <static BOOL g_b_init_get_security_info>:
3205 <g_b_init_create_symbolic_link>: New static flags.
3206 (globals_of_w32): Initialize them to zero.
3207 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
3208 (map_w32_filename): Improve commentary. Simplify switch.
3209 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
3210 headers (most versions of MinGW w32api don't).
3211 (get_security_info, create_symbolic_link)
3212 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
3213 New functions.
3214 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
3215 in the argument file name.
3216 (sys_access): Call unc_volume_file_attributes only if
3217 GetFileAttributes fails with network-related error codes.
3218 (sys_rename): Diagnose renaming of a symlink when the user doesn't
3219 have the required privileges.
14ae4239 3220 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
3221 get_file_security_desc.
3222 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
3223 with addition of handling of symlinks and support for 'lstat'.
3224 If possible, get file's attributes and security information by
6dad7178
EZ
3225 handle, not by name. Produce S_IFLNK bit for symlinks, when
3226 called from 'lstat'.
3227 (stat, lstat): New functions, call 'stat_worker'.
3228 (symlink, readlink, careadlinkat): Rewritten to create and resolve
3229 symlinks when the underlying filesystem supports them.
3230
f162bcc3
PE
32312012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3232
79ea6c20
PE
3233 Fix macroexp crash on Windows with debugging (Bug#12118).
3234 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
3235 checking subscripts; problem introduced with the recent
3236 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
3237 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
3238 since it's used in non-static inline functions now.
3239
c0ce93fd
PE
3240 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
3241 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 3242
f162bcc3
PE
3243 Use C99-style 'extern inline' if available.
3244 * buffer.h (BUFFER_INLINE):
3245 * category.h (CATEGORY_INLINE):
3246 * character.h (CHARACTER_INLINE):
3247 * charset.h (CHARSET_INLINE):
3248 * composite.h (COMPOSITE_INLINE):
3249 * dispextern.h (DISPEXTERN_INLINE):
3250 * lisp.h (LISP_INLINE):
3251 * systime.h (SYSTIME_INLINE):
3252 New macro, replacing 'static inline' in this header.
3253 * buffer.h, category.h, character.h, charset.h, composite.h:
3254 * dispextern.h, lisp.h, systime.h:
3255 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
3256 * alloc.c (LISP_INLINE):
3257 * buffer.c (BUFFER_INLINE):
3258 * category.c (CATEGORY_INLINE):
3259 * character.c (CHARACTER_INLINE):
3260 * charset.c (CHARSET_INLINE):
3261 * composite.c (COMPOSITE_INLINE):
3262 * dispnew.c (DISPEXTERN_INLINE):
3263 * sysdep.c (SYSTIME_INLINE):
3264 Define to EXTERN_INLINE, so that the corresponding functions
3265 are compiled into code.
3266 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
3267 (INLINE_HEADER_END): New macros.
3268 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
3269 since it's used in non-static inline functions now.
a8333d03 3270 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 3271
837b365b
GM
32722012-08-02 Glenn Morris <rgm@gnu.org>
3273
d66b744d
GM
3274 * s/: Remove empty directory.
3275
837b365b
GM
3276 * s/ms-w32.h: Move to ../nt/inc.
3277 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
3278 Update for new ms-w32.h location.
3279
13294f95
PE
32802012-08-02 Paul Eggert <eggert@cs.ucla.edu>
3281
3282 Port to Solaris 8.
3283 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
3284
90df0db3
GM
32852012-08-02 Glenn Morris <rgm@gnu.org>
3286
3287 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
3288 hard-coding the path separator.
3289
4939150c
PE
32902012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3291
3292 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
3293 This how ASET and AREF are supposed to work, and makes
3294 it easier to think about future improvements. See
3295 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
3296 * charset.h (set_charset_attr): New function.
3297 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
3298 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
3299 (aref_addr): New function. All uses of &AREF(...) changed.
3300 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
3301 (set_hash_index): New functions. All lvalue-style uses of
3302 HASH_KEY etc. changed.
3303 * keyboard.c (set_prop): New function. All lvalue-style uses
3304 of PROP changed.
3305
947b2afd
AA
33062012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
3307
3308 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
3309 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
3310 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
3311 * nsfns.m (ns_set_name_as_filename): Likewise.
3312 * nsmenu.m (ns_update_menubar): Likewise.
3313 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
3314
4f5d0325
EZ
33152012-08-01 Eli Zaretskii <eliz@gnu.org>
3316
2008beae
EZ
3317 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
3318 Adapt to latest changes in field names of the corresponding Lisp
288479f6 3319 objects.
2008beae 3320
4f5d0325
EZ
3321 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
3322
fe3cc771
GM
33232012-08-01 Glenn Morris <rgm@gnu.org>
3324
3325 * s/msdos.h: Remove file.
3326 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
3327 * Makefile.in (S_FILE): Remove.
3328 (config_h): Remove S_FILE.
3329
c90acc54
JB
33302012-08-01 Juanma Barranquero <lekktu@gmail.com>
3331
3332 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
3333 Remove; moved to nt/config.nt.
3334
d8a05828
DA
33352012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3336
3337 Use INTERNAL_FIELD for conses and overlays.
3338 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
3339 Remove obsolete comment.
3340 (MVAR): New macro.
3341 (struct Lisp_Overlay): Use INTERNAL_FIELD.
3342 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
3343
8271d590
DA
33442012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3345
3346 Use INTERNAL_FIELD for symbols.
3347 * lisp.h (SVAR): New macro. Adjust users.
3348 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
3349 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
3350
3193acd2
DA
33512012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3352
3353 Use INTERNAL_FIELD for processes.
3354 * process.h (PVAR): New macro. Adjust style.
3355 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
3356 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
3357
3a45383a
DA
33582012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
3359
3360 Use INTERNAL_FIELD for windows.
3361 * window.h (WVAR): New macro.
3362 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
3363 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
3364 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
3365 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
3366 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
3367 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3368
c1dbc63c
PE
33692012-08-01 Paul Eggert <eggert@cs.ucla.edu>
3370
3371 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
3372
5c0c0e8a
GM
33732012-08-01 Glenn Morris <rgm@gnu.org>
3374
3375 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
3376 Move to configure.ac.
3377
552a99b4
JB
33782012-08-01 Juanma Barranquero <lekktu@gmail.com>
3379
3380 * makefile.w32-in (CONFIG_H): Update dependencies.
3381 (CONF_POST_H): New macro.
3382
3383 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
3384
8d8e2dfe
GM
33852012-07-31 Glenn Morris <rgm@gnu.org>
3386
bc96620a
GM
3387 * Makefile.in (S_FILE): No longer set by configure.
3388
476b1b2d
GM
3389 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
3390 is available.
3391 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
3392
b2c7a106
GM
3393 * process.h (NULL_DEVICE):
3394 * emacs.c (SEPCHAR):
3395 * editfns.c (USER_FULL_NAME): Let configure set them.
3396
d53d062a
GM
3397 * s/README, s/template.h: Remove files.
3398
4515017f
GM
3399 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
3400
8d8e2dfe
GM
3401 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
3402 Move to configure.ac.
3403
5b20b3cc
EZ
34042012-07-31 Eli Zaretskii <eliz@gnu.org>
3405
1e0afd9a
EZ
3406 * .gdbinit (xframe): Adapt to introduction of FVAR and the
3407 resulting renaming of 'struct frame' members.
3408
5b20b3cc
EZ
3409 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
3410
3411 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
3412 after introduction of FVAR.
3413
f1310128
JD
34142012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3415
79e721e0
JD
3416 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
3417
3418 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
3419 instead of compositeToPoint.
3420 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
3421
8d7c7eed 3422 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 3423
e34f7f79
DA
34242012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3425
3426 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
3427 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 3428 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
3429 (BVAR): Change to use INTERNAL_FIELD.
3430 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
3431 (KVAR): Change to use INTERNAL_FIELD.
3432 * frame.h (FVAR): New macro.
3433 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
3434 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
3435 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
3436 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
3437 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
3438
c09bfb2f
DA
34392012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3440
3441 Miscellaneous fixes for non-default X toolkits.
3442 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
3443 * xterm.c (x_frame_of_widget): Remove redundant prototype.
3444 Move under #ifdef USE_LUCID.
3445 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
3446 definition and usage to avoid warnings.
3447
14c114ae
JD
34482012-07-31 Jan Djärv <jan.h.d@swipnet.se>
3449
3450 * nsterm.m (openFiles): Fix previous checkin.
3451
3bd21e82
PE
34522012-07-31 Paul Eggert <eggert@cs.ucla.edu>
3453
3454 * indent.c (compute_motion): Remove unused local.
3455
c1529ded
GM
34562012-07-31 Glenn Morris <rgm@gnu.org>
3457
400d5621
GM
3458 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
3459
268e2432
GM
3460 * conf_post.h [USG5_4]:
3461 Move remaining contents of s/usg5-4-common.h here.
3462 * s/usg5-4-common.h: Remove file.
3463
7552f3ee
GM
3464 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
3465 * s/irix6-5.h: Remove file.
3466
6a381852
GM
3467 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
3468 * s/darwin.h: Remove file.
3469
c1529ded
GM
3470 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
3471 * s/hpux10-20.h: Remove file, which is now empty.
3472
b429a4ee
GM
34732012-07-30 Glenn Morris <rgm@gnu.org>
3474
3475 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
3476 * Makefile.in (config_h): Add conf_post.h.
3477 * makefile.w32-in (CONFIG_H): Add conf_post.h.
3478
adff3182
JD
34792012-07-30 Jan Djärv <jan.h.d@swipnet.se>
3480
3481 * nsterm.m (ns_do_open_file): New variable.
b9031d69 3482 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
3483 (openFile, openTempFile, openFileWithoutUI, openFiles):
3484 Open files only if ns_do_open_file.
adff3182 3485
c32af1e4
PE
34862012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3487
7393bcbb
PE
3488 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
3489 This no-op macro hasn't been needed for many years.
3490 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
3491
c32af1e4
PE
3492 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
3493 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
3494 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
3495 gdb_make_enums_visible.
3496 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
3497 (DIRECTORY_SEP): Now a constant, not a macro.
3498
302fc036
EZ
34992012-07-30 Eli Zaretskii <eliz@gnu.org>
3500
3501 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
3502 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
3503
3504 * w32term.c <w32_keyboard_codepage>: Renamed from
3505 keyboard_codepage and now external. All users changed.
3506
3507 * w32term.h: Add declaration of w32_keyboard_codepage.
3508
3509 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
3510 the codepage to translate keys to Unicode. If this argument is
3511 -1, use the value returned by GetConsoleCP. All callers changed.
3512
88fb40b4
PE
35132012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3514
0aee6912
PE
3515 Update .PHONY listings in makefiles.
3516 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
3517 bootstrap-clean, distclean, maintainer-clean, versioclean,
3518 extraclean, frc.
3519
88fb40b4
PE
3520 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
3521 This is a bit clearer. Fix some commentary typos.
3522
0a763bd1
GM
35232012-07-30 Glenn Morris <rgm@gnu.org>
3524
32bac6d6
GM
3525 * s/netbsd.h: Let configure include signal.h if needed.
3526 Remove file, which is now empty.
3527
b65e7c46
GM
3528 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
3529 Let configure set them.
3530 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
3531 No more need to undefine.
0a763bd1 3532
169304bd
AS
35332012-07-30 Andreas Schwab <schwab@linux-m68k.org>
3534
3535 * keymap.c (Fkey_description): Don't remove 0x80 bit from
3536 non-single-byte char when adding meta modifier. (Bug#12090)
3537
6cd7a139
DA
35382012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3539
3540 Convert safe_call to use variable number of arguments.
3541 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
3542 (safe_call2): Fix comment.
3543 * lisp.h (safe_call): Adjust prototype.
3544 * coding.c (encode_coding_object): Change to use safe_call2.
3545 * xfaces.c (merge_face_heights): Change to use safe_call1.
3546
d34d6ffc
GM
35472012-07-30 Glenn Morris <rgm@gnu.org>
3548
7b8a48e4 3549 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 3550 does that unconditionally. Remove file, which is now empty.
7b8a48e4 3551
d34d6ffc
GM
3552 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
3553 Remove empty files.
3554
03a660a6
PE
35552012-07-30 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Export to GDB most of lisp.h's remaining object-like macros.
3558 * lisp.h (min, max): Move earlier, because they're used earlier now.
3559 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
3560 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
3561 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
3562 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
3563 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
3564 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
3565 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
3566 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
3567 Now constants, for GDB. They need not be macros.
3568 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
3569 Now constants, for GDB, as well as macros, for static initializers.
3570 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
3571 Move to after the definition of struct Lisp_Char_Table,
3572 since the former now needs that type defined.
3573 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
3574 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
3575 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
3576 New enums, for gdb_make_enums_visible.
3577 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 3578 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
3579 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
3580 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
3581 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
3582 enum maxargs, enum MAX_ALLOCA.
3583 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
3584 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
3585 no longer needed, now that they are done in lisp.h.
3586
e499d0ee
DA
35872012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
3588
3589 Cleanup string bytes checking.
3590 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
3591 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
3592 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
3593 (check_sblock, compact_small_strings): Simplify.
3594
d5040d2d
PE
35952012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
3598 These macros are confusing and no longer need to be defined, as
3599 the enum values now suffice. All uses replaced with definiens.
3600 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
3601
7f259ae6
JB
36022012-07-29 Juanma Barranquero <lekktu@gmail.com>
3603
3604 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
3605 ($(BLD)/w32console.$(O)): Update dependencies.
3606
7e63e0c3
DA
36072012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3608
3609 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
3610 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
3611 time. Adjust users.
3612 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
3613
ffd817eb
JD
36142012-07-29 Jan Djärv <jan.h.d@swipnet.se>
3615
3616 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
3617 setting sitelisp (Bug#12010).
3618
417a7a0e
EZ
36192012-07-29 Eli Zaretskii <eliz@gnu.org>
3620
14ae4239 3621 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
3622
3623 * w32heap.c (cache_system_info):
3624 * w32.c (sys_rename):
3625 * w32proc.c (find_child_console, sys_kill): All users changed.
3626
387d4d92
PE
36272012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
3630
55a6cca6
EZ
36312012-07-29 Eli Zaretskii <eliz@gnu.org>
3632
3633 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
3634
dbcf001c
DA
36352012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3636
3637 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
3638 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
3639 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 3640
e2688e4a
DA
36412012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
3642
3643 Generalize marker debugging code under MARKER_DEBUG and use eassert.
3644 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
3645 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
3646 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
3647 (replace_range, replace_range_2, del_range_2): Change to eassert.
3648 * marker.c (byte_char_debug_check): Adjust style.
3649
b46a6a83
PE
36502012-07-29 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
3653 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
3654 long-ago-commented-out code that talks about "WIN32".
3655 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
3656 All uses changed.
3657
e32a5799
PE
36582012-07-28 Paul Eggert <eggert@cs.ucla.edu>
3659
3660 Use Gnulib stdalign module (Bug#9772, Bug#9960).
3661 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
3662 Simplify by using alignof.
3663 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
3664 * lisp.h: Include <stdalign.h>.
3665 (GCALIGNMENT): New macro and constant.
3666 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
3667 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
3668 (stdalign): New macro, if not already defined.
3669
df81cd29
EZ
36702012-07-28 Eli Zaretskii <eliz@gnu.org>
3671
01bd1b0d
EZ
3672 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
3673 * w32inevt.c: Include w32inevt.h.
3674 (w32_read_console_input): New inline function, calls either
3675 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
3676 w32_console_unicode_input.
3677 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
3678 (w32_kbd_patch_key, key_event): Use the codepage returned by
3679 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
3680 (key_event): use uChar.UnicodeChar only if
3681 w32_console_unicode_input is non-zero.
3682
3683 * w32console.c: Include w32heap.h.
3684 <w32_console_unicode_input>: New global variable.
3685 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
3686 family of Windows, zero otherwise.
3687
3688 * w32inevt.h: Declare w32_console_unicode_input.
3689
df81cd29
EZ
3690 * xdisp.c (init_iterator): Don't reference tip_frame in a build
3691 --without-x. (Bug#11742)
3692
c20fdd9e
PE
36932012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3694
3695 Adjust GDB to reflect pvec_type changes (Bug#12036).
3696 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
3697 2012-07-04 changes to pseudovector representation.
3698 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 3699
32770973 37002012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
3701
3702 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
3703 bus address.
3704 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
3705
3438fe21
EZ
37062012-07-27 Eli Zaretskii <eliz@gnu.org>
3707
bcfbc9de
EZ
3708 * alloc.c (listn): Fix the order the arguments are consed onto the
3709 list.
3710
3438fe21
EZ
3711 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
3712 enumeration constants, as PURE and HEAP are too general, and clash
3713 with other headers and sources, such as gmalloc.c and the
3714 MS-Windows system headers. All users changed.
3715
eeaea515
DA
37162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3717
3718 Revert last save_excursion_save and save_excursion_restore changes.
3719 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
3720 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
3721
073c88c2
DA
37222012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3723
3724 Fix recently-introduced typos in Windows port.
3725 Reported by Martin Rudalics <rudalics@gmx.at>.
3726 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 3727 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 3728
4706125e
PE
37292012-07-27 Paul Eggert <eggert@cs.ucla.edu>
3730
3731 Improve GDB symbol export (Bug#12036).
3732 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
3733 arms of an 'if', not using conditional expressions; otherwise GDB
3734 complains about the types in the unevaluated arm when the argument
3735 is an integer literal.
3736 (xgetint): Simplify expression.
3737 * alloc.c (gdb_make_enums_visible): New constant. This ports to
3738 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
3739 Zaretskii in <http://bugs.gnu.org/12036#13>.
3740 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
3741 needed now that we have gdb_make_enums_visible.
3742 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
3743 (enum enum_USE_LSB_TAG):
3744 New enum types, packaging up enums that need to be exported to GDB.
3745
694b6c97
DA
37462012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3747
3748 Utility function to make a list from specified amount of objects.
3749 * lisp.h (enum constype): New datatype.
3750 (listn): New prototype.
3751 * alloc.c (listn): New function.
3752 (Fmemory_use_count, syms_of_alloc): Use it.
3753 * buffer.c (syms_of_buffer): Likewise.
3754 * callint.c (syms_of_callint): Likewise.
3755 * charset.c (define_charset_internal): Likewise.
3756 * coding.c (syms_of_coding): Likewise.
3757 * keymap.c (syms_of_keymap): Likewise.
3758 * search.c (syms_of_search): Likewise.
3759 * syntax.c (syms_of_syntax): Likewise.
3760 * w32.c (init_environment): Likewise.
3761 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
3762 * xdisp.c (syms_of_xdisp): Likewise.
3763 * xfns.c (syms_of_xfns): Likewise.
3764
6195f384
DA
37652012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
3766
3767 Fast save_excursion_save and save_excursion_restore.
3768 * lisp.h (struct Lisp_Excursion): New data type.
3769 (PVEC_EXCURSION): New pseudovector type.
3770 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
3771 to deal with it. Adjust comments.
3772 (init_marker, attach_marker): New prototype.
3773 (unchain_marker): Adjust prototype.
3774 * marker.c (attach_marker): Change to global.
3775 (init_marker): New function.
3776 * alloc.c (Fmake_marker, build_marker): Use it.
3777 (build_marker): More easserts.
3778 (mark_object): Handle struct Lisp_Excursion.
3779 * editfns.c (save_excursion_save, save_excursion_restore):
3780 Reimplement to use struct Lisp_Excursion. Add comments.
3781
5eceb8fb
PE
37822012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3783
3784 Fix export of symbols to GDB (Bug#12036).
3785 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
3786 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
3787 emacs.c, as this is a more-suitable home. Had this been done earlier
3788 the fix for 12036 would have avoided some of the problems noted in
3789 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
3790 would have been more obvious.
562157c8
PE
3791 * emacs.c: Do not include <verify.h>; no longer needed.
3792 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
3793 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
3794 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3795 Remove; now done in lisp.h.
3796 * lisp.h (PUBLISH_TO_GDB): New macro.
3797 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
3798 (DATA_SEG_BITS): Use it.
3799 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
3800 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
3801 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
3802 not be usable in #if. This simplifies things.
3803
d6749401
JB
38042012-07-26 Juanma Barranquero <lekktu@gmail.com>
3805
3806 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
3807
1781b9e9
PE
38082012-07-26 Paul Eggert <eggert@cs.ucla.edu>
3809
d89518db 3810 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
3811 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
3812 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
3813 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
3814 Adjust to changes in lisp.h and emacs.c, by using
3815 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
3816 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
3817 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
3818 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
3819 instead of gdb_valbits.
3820 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
3821 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
3822 instead of gdb_array_mark_flag.
3823 (xboolvector): Get size from $->size, not $->header.size.
3824 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
3825 (xreload, hook-run, hookpost-run): Remove.
3826 * emacs.c: Include <verify.h>.
3827 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
3828 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
3829 Remove.
3830 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
3831 (gdb_USE_LSB_TAG): New enum constants.
3832 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
3833 Also define these as enum constants, so they're visible to GDB.
3834 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
3835 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
3836 as constants, so they're visible to GDB.
3837 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
3838 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
3839 Now enum constants, not macros, so they're visible to GDB.
3840 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
3841 more convenient now. All uses changed.
3842 (VALMASK) [USE_LSB_TAG]: Also define in this case.
3843 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
3844
3628596a
DA
38452012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
3846
3847 Explicitly free restriction data that are not needed anymore.
3848 * editfns.c (save_restriction_restore): Free restriction data.
3849
7abaf5cc
SM
38502012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
3851
3852 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
3853 add argument, tune behavior, and adjust all callers.
3854
71f88e00
PE
38552012-07-25 Paul Eggert <eggert@cs.ucla.edu>
3856
3857 Use typedef for EMACS_INT, EMACS_UINT.
3858 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
3859 than macros. This simplifies debugging in the usual case, since
3860 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
3861 and it allows expressions involving EMACS_INT casts.
3862 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
3863
57ec3034
JD
38642012-07-25 Jan Djärv <jan.h.d@swipnet.se>
3865
3866 * nsterm.m (ns_read_socket): Return early if there is a modal
3867 window (Bug#12043).
3868
8137e7b3
MR
38692012-07-25 Martin Rudalics <rudalics@gmx.at>
3870
3871 * frame.c (Fredirect_frame_focus): In doc-string don't mention
3872 that FOCUS-FRAME can be omitted.
3873
04e9897c
DA
38742012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
3875
3876 Adjust buffer text indirection counters at the end of Fkill_buffer.
3877 * buffer.c (Fkill_buffer): Adjust indirection counters when the
3878 buffer is definitely dead. This should really fix an issue reported
3879 by Christoph Scholtes again. (Bug#12007).
3880 (init_buffer_once): Initialize indirection counters of
3881 buffer_defaults and buffer_local_symbols (for sanity and safety).
3882
8a0484e1
EZ
38832012-07-24 Eli Zaretskii <eliz@gnu.org>
3884
3885 * xdisp.c (init_iterator): Don't compute dimensions of truncation
3886 and continuation glyphs on tooltip frames, leave them at zero.
3887 Avoids continued lines in tooltips. (Bug#11832)
3888
fa691a83
DA
38892012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
3890
3891 Simplify copy_overlay.
04e9897c 3892 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
3893 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
3894
436bc8e0
EZ
38952012-07-23 Eli Zaretskii <eliz@gnu.org>
3896
3897 * print.c (print_object): Don't crash when a frame's name is nil
3898 or invalid. (Bug#12025)
3899
3900 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
3901 it signals an error when a tooltip frame is being created.
3902
d7a7fda3
DA
39032012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
3904
3905 Cleanup miscellaneous objects allocation and initialization.
3906 * alloc.c (allocate_misc): Change to static. Add argument to
3907 specify the subtype. Adjust comment and users.
3908 (build_overlay): New function.
3909 * buffer.c (copy_overlays, Fmake_overlay): Use it.
3910 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
3911 (allocate_misc): Remove prototype.
3912 (build_overlay): Add prototype.
3913
39142012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
3915
3916 Swap buffer text indirection counters in Fbuffer_swap_text.
3917 * buffer.c (Fbuffer_swap_text): Swap indirections too.
3918 This avoids crash reported by Christoph Scholtes at
3919 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
3920
9d7fa573
JD
39212012-07-22 Jan Djärv <jan.h.d@swipnet.se>
3922
3923 * nsmenu.m (Popdown_data): New struct.
3924 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
3925 free Popdown_data.
3926 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
3927 (initWithContentRect): Make imgView and contentView non-static
3928 and autorelease them. Also autorelease img and matrix (Bug#12005).
3929 (dealloc): Remove (Bug#12005).
3930
0dd6d66d
DA
39312012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3932
3933 Adjust consing_since_gc when objects are explicitly freed.
3934 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
3935 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
3936 (free_cons, free_misc): Subtract object size from consing_since_gc.
3937
d36d71df
DA
39382012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
3939
3940 Simplify and cleanup markers positioning code.
3941 * marker.c (attach_marker): More useful eassert.
3942 (live_buffer, set_marker_internal): New function.
3943 (Fset_marker, set_marker_restricted): Use set_marker_internal.
3944 (set_marker_both, set_marker_restricted_both): Use live_buffer.
3945
fb9ea40f
PE
39462012-07-22 Paul Eggert <eggert@cs.ucla.edu>
3947
3948 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
3949 as it's limited by the amount of memory, not by INT_MAX.
3950
2d5c5f7d
EZ
39512012-07-21 Eli Zaretskii <eliz@gnu.org>
3952
07fb592e
EZ
3953 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
3954 in special-event-map. See the discussion at
3955 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
3956 for the reasons.
3957
37a9eac8 3958 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
3959 info.dwItemData. Fixes crashes on 64-bit Windows.
3960 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 3961
c4328746
JD
39622012-07-21 Jan Djärv <jan.h.d@swipnet.se>
3963
fc0c31f8 3964 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 3965 (conversationIdentifier): Return value is NSInteger.
784051c4 3966 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 3967
6e5d1c12
CY
39682012-07-21 Chong Yidong <cyd@gnu.org>
3969
3970 * window.c (decode_any_window): Signal an error if the window is
3971 on a dead frame (Bug#11984).
3972
9928463d
DA
39732012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3974
3975 Add indirection counting to speed up Fkill_buffer.
3976 * buffer.h (struct buffer): New member.
3977 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
3978 (Fmake_indirect_buffer): Set indirection counter to -1, increment
3979 base buffer indirection counter.
3980 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
3981 (Fkill_buffer): Adjust indirection counters as needed, don't walk
3982 through buffer list if indirection counter is 0.
3983
f8643a6b
DA
39842012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3985
3986 Extend the value returned by Fgarbage_collect with heap statistics.
3987 * alloc.c (Qheap): New symbol.
3988 (syms_of_alloc): DEFSYM it.
3989 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
3990 (Fmemory_free): Remove.
3991 (syms_of_alloc): Don't defsubr it.
3992 * buffer.c (Fcompact_buffer): Remove.
3993 (syms_of_buffer): Don't defsubr it.
3994
dac616ff
DA
39952012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
3996
3997 Make maybe_gc inline.
3998 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
3999 * lisp.h (consing_since_gc, gc_relative_threshold)
4000 (memory_full_cons_threshold): Revert declaration.
4001 (maybe_gc): Remove prototype, define as inline.
4002 * alloc.c: Remove old commented-out code.
4003 (consing_since_gc, gc_relative_threshold)
4004 (memory_full_cons_threshold): Revert to global.
4005 (maybe_gc): Remove.
4006
d7ea76b4
DA
40072012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4008
4009 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
4010 * lisp.h (build_unibyte_string): New function.
4011 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
4012 * sysdep.c, w32fns.c, xfns.c: Use it.
4013 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
4014 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
4015 Adjust users accordingly.
4016 * font.h (font_open_by_name): Adjust prototype.
4017
765e61e3
DA
40182012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
4019
4020 Cleanup calls to Fgarbage_collect.
4021 * lisp.h (maybe_gc): New prototype.
4022 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4023 Remove declarations.
4024 * alloc.c (maybe_gc): New function.
4025 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
4026 Make them static.
4027 * bytecode.c (MAYBE_GC): Use maybe_gc.
4028 * eval.c (eval_sub, Ffuncall): Likewise.
4029 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
4030 to avoid dependency from auto-save feature.
4031
52b852c7
PE
40322012-07-19 Paul Eggert <eggert@cs.ucla.edu>
4033
4034 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
4035 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
4036 'for_each_per_buffer_object_at'.
4037 All uses changed. It's better to use upper-case for macros that
4038 cannot be implemented as functions, to give the reader a clue
4039 that they're special.
4040
5db81e33
SM
40412012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
4042
4043 * alloc.c (Fgarbage_collect): Tweak docstring.
4044
5b835e1d
DA
40452012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4046
4047 Tweak the value returned from Fgarbage_collect again.
4048 * alloc.c (Fgarbage_collect): New return value, as confirmed in
4049 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
4050 Adjust documentation.
4051 (total_vector_bytes): Rename to total_vector_slots, adjust
4052 accounting.
4053 (total_free_vector_bytes): Rename to total_free_vector_slots,
4054 adjust accounting.
4055 (Qstring_bytes, Qvector_slots): New symbols.
4056 (syms_of_alloc): DEFSYM them.
4057
9cd47b72
DA
40582012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4059
4060 Buffer compaction primitive which may be used from Lisp.
4061 * buffer.c (compact_buffer, Fcompact_buffer): New function.
4062 (syms_of_buffer): Register Fcompact_buffer.
4063 * alloc.c (Fgarbage_collect): Use compact_buffer.
4064 * buffer.h (compact_buffer): New prototype.
4065 (struct buffer_text): New member.
4066
d17337e5
DA
40672012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
4068
4069 New macro to iterate over all buffers, miscellaneous cleanups.
4070 * lisp.h (all_buffers): Remove declaration.
4071 * buffer.h (all_buffers): Add declaration, with comment.
4072 (for_each_buffer): New macro.
4073 * alloc.c (Fgarbage_collect, mark_object): Use it.
4074 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
4075 (init_buffer): Likewise.
4076 * data.c (Fset_default): Likewise.
4077 * coding.c (code_conversion_restore): Remove redundant check
4078 for dead buffer.
4079 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
4080
60cfd278
AS
40812012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4082
4083 Fix bug that created negative-length intervals.
4084 * intervals.c (merge_interval_right, merge_interval_left):
4085 Do not zero out this interval if it is absorbed by its children,
4086 as this interval's total length doesn't change in that case. See
4087 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
4088
d06714cb
PE
40892012-07-18 Paul Eggert <eggert@cs.ucla.edu>
4090
83713154
PE
4091 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
4092 when invoking (make-bool-vector N t) and N is a positive
4093 multiple of 8 -- the last 8 bits were mistakenly cleared.
4094
d06714cb
PE
4095 Remove some struct layout assumptions in bool vectors.
4096 * alloc.c (bool_header_size): New constant.
4097 (header_size, word_size): Move earlier, as they're now used earlier.
4098 Use 'word_size' in a few more places, where it's appropriate.
4099 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
4100 padding before the data member of a bool vector.
4101 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
4102 than doing the check by hand with an abort ().
4103
464d5a5e
SM
41042012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4105
5fbc0409
SM
4106 * eval.c (Fdefvar): Don't check constants since we only set the var if
4107 it's not yet defined anyway (bug#11904).
4108
464d5a5e
SM
4109 * lisp.h (last_undo_boundary): Declare new var.
4110 * keyboard.c (command_loop_1): Set it.
4111 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
4112 were auto-added by the command loop (bug#11774).
4113
8dc2e44a
AS
41142012-07-18 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * w32font.c (Qsymbol): Remove local definition.
4117 (syms_of_w32font): Don't DEFSYM it.
4118
169925ec
DA
41192012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4120
4121 Fix sweep_vectors to handle large bool vectors correctly.
4122 * alloc.c (sweep_vectors): Account total_vector_bytes for
4123 bool vectors larger than VBLOCK_BYTES_MAX.
4124
5fbfb018
CY
41252012-07-18 Chong Yidong <cyd@gnu.org>
4126
4127 * frame.c (x_set_frame_parameters): Revert bogus change introduced
4128 in 2012-05-25 commit by Paul Eggert (Bug#11738).
4129
3ab6e069
DA
41302012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
4131
4132 Return more descriptive data from Fgarbage_collect.
4133 Suggested by Stefan Monnier in
4134 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
4135 * alloc.c (bounded_number): New function.
4136 (total_buffers, total_vectors): New variable.
4137 (total_string_size): Rename to total_string_bytes, adjust users.
4138 (total_vector_size): Rename to total_vector_bytes, adjust users.
4139 (sweep_vectors): Account total_vectors and total_vector_bytes.
4140 (Fgarbage_collect): New return value. Adjust documentation.
4141 (gc_sweep): Account total_buffers.
4142 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
4143 (VECTOR_SIZE): Remove.
4144 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
4145 (Qinterval, Qmisc): New symbols.
4146 (syms_of_data): Initialize them.
4147 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
4148 (Qcons, Qbuffer): New declarations.
4149
6d02fe5b
PE
41502012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4151
4152 * alloc.c (Fmemory_free): Account for memory-free's own storage.
4153 Round up, not down. Improve doc.
4154
b7ffe040
DA
41552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4156
4157 Restore old code in allocate_string_data to avoid Faset breakage.
4158 Reported by Julien Danjou <julien@danjou.info> in
4159 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
4160 * alloc.c (allocate_string_data): Restore old code with minor
4161 adjustments, fix comment to explain this subtle issue.
4162
4dc7c8d5
SM
41632012-07-17 Eli Zaretskii <eliz@gnu.org>
4164
4165 Remove FILE_SYSTEM_CASE.
4166 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
4167
4168 * fileio.c (FILE_SYSTEM_CASE): Don't define.
4169 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
4170 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
4171 call-process-region passes it through expand-file-name.
4172
4173 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
4174
41752012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4176
4177 Fix crash when creating indirect buffer (Bug#11917)
4178 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
4179 Don't handle unbound variables specially if non-zero.
4180 (Fbuffer_local_variables): Pass zero.
4181 (clone_per_buffer_values): Pass non-zero.
4182
41832012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4184
4185 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
4186 to make the loop interruptible.
4187
41882012-07-17 Andreas Schwab <schwab@linux-m68k.org>
4189
4190 * gnutls.c (emacs_gnutls_handshake): Only retry if
4191 GNUTLS_E_INTERRUPTED.
4192
cce7fefc
DA
41932012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4194
4195 Cleanup and convert miscellaneous checks to eassert.
4196 * alloc.c (mark_interval): Fix comment, partially rephrase
4197 old comment from intervals.h (see below).
4198 * intervals.c (find_interval, adjust_intervals_for_insertion)
4199 (delete_interval, adjust_intervals_for_deletion)
4200 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
4201 Convert to eassert.
4202 (adjust_intervals_for_insertion, make_new_interval):
4203 Remove obsolete and unused code.
4204 * intervals.h (struct interval): Remove obsolete comment.
4205 * textprotp.c (erase_properties): Remove unused code.
4206 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
4207 (Fremove_list_of_text_properties): Convert to eassert.
4208
9ea10cc3
CY
42092012-07-17 Chong Yidong <cyd@gnu.org>
4210
4211 * editfns.c (Finsert_char): Doc fix.
4212
3900d5de
DA
42132012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4214
4215 Fix previous change to make Fmemory_free always accurate.
4216 * alloc.c (make_interval): Update total_free_intervals.
4217 (make_float): Likewise for total_free_floats.
4218 (free_cons, Fcons): Likewise for total_free_conses.
4219 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
4220 Likewise for total_free_vector_bytes.
4221 (Fmake_symbol): Likewise for total_free_symbols.
4222 (bytes_free): Remove.
4223
7098646f
DA
42242012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4225
4226 Simple free memory accounting feature.
4227 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
4228 (sweep_vectors): Accumulate size of free vectors.
4229 (Fgarbage_collect): Setup bytes_free.
4230 (Fmemory_free): New function.
4231 (syms_of_alloc): Register it.
4232
22657b40
DA
42332012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
4234
4235 Cleanup overlays checking.
4236 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
4237 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
4238 eassert and OVERLAYP.
4239 (sort_overlays): Change to use OVERLAYP.
4240
ddfc8813
RK
42412012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
4242
4243 * editfns.c (Finsert_char): Make it interactive, and make the
4244 second arg optional. Copy interactive spec and docstring from
4245 ucs-insert.
4246
7c26cf3c
PE
42472012-07-17 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
4250 Unlike the other wrapped functions, fabs has an unspecified
4251 effect on errno.
4252
5d127af9
JD
42532012-07-16 Jan Djärv <jan.h.d@swipnet.se>
4254
4255 * nsterm.m (keyDown): Interpret flags without left/right bits
4256 as the left key (Bug#11670).
4257
6a0dd1d7
DA
42582012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4259
4260 Remove empty and useless init functions.
4261 * lisp.h (init_character_once, init_fns, init_image)
4262 (init_filelock, init_sound): Remove prototype.
4263 * character.c (init_character_once): Remove.
4264 * filelock.c (init_filelock): Likewise.
4265 * fns.c (init_fns): Likewise.
4266 * image.c (init_image): Likewise.
4267 * sound.c (init_sound): Likewise.
4268 * emacs.c (main): Adjust accordingly.
4269
7a6136fd
DA
42702012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
4271
4272 * gtkutil.h: Tiny cleanups.
4273 (use_old_gtk_file_dialog): Remove useless declaration.
4274 (xg_uses_old_file_dialog): Add suggested const attribute.
4275
ce811ad9
EZ
42762012-07-15 Eli Zaretskii <eliz@gnu.org>
4277
4278 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
4279 (bidi_paragraph_init): Use it to limit search forward for a strong
4280 directional character in abnormally large paragraphs full of
4281 neutral or weak characters. (Bug#11943)
4282
c9adfeaa
SF
42832012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
4284
4285 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
4286 the toolbar (Bug#9451).
4287 (xg_make_tool_item): Give the widget event box a transparent
4288 background.
4289
fff62aa9
DA
42902012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4291
4292 Cleanup basic allocation variables and functions.
4293 * alloc.c (ignore_warnings, init_intervals, init_float)
4294 (init_cons, init_symbol, init_marker): Remove.
4295 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
4296 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
4297 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
4298 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
4299 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
4300 (staticidx, init_alloc_once, init_strings, free_ablock):
4301 Remove redundant initialization.
4302 * fns.c (init_weak_hash_tables): Remove.
4303 * lisp.h (init_weak_hash_tables): Remove prototype.
4304
9730daca
DA
43052012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
4306
4307 Use zero_vector where appropriate.
4308 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
4309 accordingly.
4310 * lisp.h (zero_vector): New declaration.
4311 * font.c (null_vector): Remove.
4312 (syms_of_font): Remove initialization and staticpro.
4313 (font_list_entities, font_find_for_lface): Change to use zero_vector.
4314 * keymap.c (Faccessible_keymaps): Likewise.
4315
2e2d2a13
LL
43162012-07-15 Leo Liu <sdl.web@gmail.com>
4317
4318 * fringe.c: Fix typo in comments.
4319
cd276f6e
LL
43202012-07-14 Leo Liu <sdl.web@gmail.com>
4321
4322 * fringe.c: Add a new bitmap exclamation-mark.
4323
5a1131d9
EZ
43242012-07-14 Eli Zaretskii <eliz@gnu.org>
4325
4326 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
4327
4328 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
4329 (HAVE_MENUS): Don't define, defined by editing config.in with
4330 msdos/sed2v2.inp.
4331 (GMALLOC_INHIBIT_VALLOC): Don't define.
4332 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
4333
22e983b7
JB
43342012-07-14 Juanma Barranquero <lekktu@gmail.com>
4335
4336 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
4337
5b3f250f
GM
43382012-07-14 Glenn Morris <rgm@gnu.org>
4339
4340 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
4341 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
4342 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
4343
33d63ff4
GM
43442012-07-13 Glenn Morris <rgm@gnu.org>
4345
5b633342
GM
4346 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
4347
33d63ff4
GM
4348 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
4349 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
4350
b55b9f85
JD
43512012-07-13 Jan Djärv <jan.h.d@swipnet.se>
4352
0dc8cf50
JD
4353 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
4354 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
4355 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
4356 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
4357 where appropriate.
4358 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
4359 as boolean expression.
4360 (x_set_window_size): Remove unused variable toolbar.
4361 (ns_get_color_default, ns_mod_to_lisp): Remove.
4362 (ns_mouse_position): Remove unused variables xchar and ychar.
4363 (ns_compute_glyph_string_overhangs): Remove unused variable face.
4364 (ns_set_vertical_scroll_bar): Remove unused variable count.
4365 (ns_delete_terminal): Remove unused variable i.
4366 (ns_term_init): Remove unused variables r, g and b.
4367 (mouseDown): Remove unused variable window.
4368 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
4369 (initFrameFromEmacs): Remove unused variable vbextra.
4370 (mouseEntered): Remove unused variables p and dpyinfo.
4371 (mouseExited): Remove unused variables p and r.
4372 (ns_define_frame_cursor, ns_clear_frame_area)
4373 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
4374 (menuDown): Assign [sender tag] to variable and cast the variable.
4375
4376 * nsterm.h (menuDown): Add id as type to argument sender.
4377 (ns_display_info_for_name): Add Lisp_Object argument.
4378 (ns_term_init): Add Lisp_Object argument.
4379 (ns_map_event_to_object): Add void argument.
4380 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
4381 prototype with arguments and only declare if __OBJC__.
4382 (nxatoms_of_nsselect): Add void argument.
4383 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
4384 (ns_alloc_autorelease_pool): Add void argument.
4385 (ns_release_autorelease_pool): Add void* argument.
4386 (ns_get_defaults_value): Add const char* argument.
4387
4388 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
4389 (initFromContents): Use SSDATA where appropriate.
4390 (ns_update_menubar): Add braces to ambigous if-else.
4391 (initWithTitle): Put () around assignment in if statement.
4392 (ns_menu_show): Remove unused variables window and keymap.
4393 (update_frame_tool_bar): Remove unused variable selected_p.
4394 (initWithContentRect): Remove unused variable this_cmd_name.
4395
4396 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
4397 appropriate.
4398 (setXBMColor): Remove unused variable len.
4399 (setPixmapData): Put () around assignment in loop statement.
4400
4401 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
4402 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
4403 where appropriate.
4404 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
4405 around assignment in loop statement.
4406 (nsfont_open): Remove unused variable i.
4407 (nsfont_open): Remove unused variable len.
4408 (nsfont_draw): Remove unused variable cs.
4409
4410 * nsfns.m (x_set_icon_name, ns_set_name_internal)
4411 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
4412 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
4413 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
4414 (Fns_font_name, Fns_perform_service)
4415 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
4416 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
4417 (ns_set_name): Remove unused variable view.
4418 (x_set_menu_bar_lines): Remove unused variable olines.
4419 (x_set_tool_bar_lines): Remove unused variable root_window.
4420 (Fns_list_colors): Put () around assignment in while statement.
4421 (Fns_perform_service): Remove unused variable len.
4422 (Fns_display_usable_bounds): Remove unused variable top.
4423 (syms_of_nsfns): Remove unused variable i.
4424
b55b9f85
JD
4425 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
4426 memcpy (Bug#11907).
4427
ed9265fc 44282012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
4429
4430 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
4431 and free it with DestroyExceptionInfo (Bug#11558).
4432
ef099b57
JB
44332012-07-13 Juanma Barranquero <lekktu@gmail.com>
4434
4435 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
4436 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
4437 Set here, not in nt/config.nt.
4438
ea814a5d
EZ
44392012-07-13 Eli Zaretskii <eliz@gnu.org>
4440
4441 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
4442 cursor overflow into the last glyph on display line when the right
4443 fringe is off. (Bug#11832)
4444
1a952767
PE
44452012-07-13 Paul Eggert <eggert@cs.ucla.edu>
4446
4447 * xdisp.c (produce_special_glyphs): Now static.
4448 * dispextern.h (produce_special_glyphs): Remove decl.
4449
983188fd
GM
44502012-07-13 Glenn Morris <rgm@gnu.org>
4451
8d7c7eed 4452 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
4453 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
4454
983188fd
GM
4455 * s/usg5-4-common.h (USG, USG5):
4456 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
4457 * s/sol2-6.h (SOLARIS2):
4458 * s/irix6-5.h (IRIX6_5):
4459 * s/hpux10-20.h (USG, USG5, HPUX):
4460 * s/gnu-linux.h (USG, GNU_LINUX):
4461 * s/freebsd.h (BSD_SYSTEM):
4462 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
4463 * s/cygwin.h (CYGWIN):
4464 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
4465 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
4466
d1e68667 44672012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
4468
4469 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 4470
6de0e799
GM
44712012-07-13 Glenn Morris <rgm@gnu.org>
4472
739ae010
GM
4473 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
4474
dbee5793
GM
4475 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
4476
6de0e799
GM
4477 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
4478 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
4479
b82da769
GM
44802012-07-12 Glenn Morris <rgm@gnu.org>
4481
4fae5a7a 4482 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
4483
4484 * process.c (init_process_emacs): Rename from init_process.
4485 The old name is also the name of a Mach system call.
4486 * lisp.h, emacs.c: Update for this name change.
4487 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
4488 longer needed.
4489
5a979817
EZ
44902012-07-12 Eli Zaretskii <eliz@gnu.org>
4491
4492 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
4493 memmove call that removes glyphs covered by the left truncation
4494 glyph. Improve commentary.
4495 (display_line): Fix display of continuation glyphs on GUI frames
4496 when the right fringe is turned off and variable-size fonts are
4497 used in the window. Move the code that appends a stretch glyph to
4498 produce_special_glyphs, so that it could be used for truncation
4499 and continuation glyphs alike.
4500 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
4501 glyph of a suitably computed width, to align the special glyphs at
4502 the window margin. Code moved from display_line. (Bug#11832)
4503
3e91a053
GM
45042012-07-12 Glenn Morris <rgm@gnu.org>
4505
ba9e4b84
GM
4506 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
4507
4508 * s/gnu-linux.h, s/hpux10-20.h:
4509 Do not unconditionally define HAVE_XRMSETDATABASE.
4510
3e91a053
GM
4511 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
4512
b300b1f4
PE
45132012-07-12 Paul Eggert <eggert@cs.ucla.edu>
4514
4515 Fix typos that broke OS X build.
4516 Reported by Randal L. Schwartz in
4517 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
4518 * nsterm.m (ns_timeout): Add missing local decl.
4519 (ns_get_color): snprintf -> sprintf, to fix typo.
4520
6e777848
GM
45212012-07-12 Glenn Morris <rgm@gnu.org>
4522
3f922c37
GM
4523 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
4524 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
4525 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
4526 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
4527
0ab7b23a
GM
4528 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
4529 Move PTY_OPEN to configure.
4530
6e777848
GM
4531 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4532 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
4533 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
4534
4a7edc24
DA
45352012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
4536
4537 Use empty_unibyte_string where applicable.
4538 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
4539 * lread.c (read1): Likewise.
4540 * xsettings.c (syms_of_xsettings): Likewise.
4541
308aab79
GM
45422012-07-12 Glenn Morris <rgm@gnu.org>
4543
42bd1719
GM
4544 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
4545 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
4546 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
4547 * s/hpux10-20.h (RUN_TIME_REMAP):
4548 * s/bsd-common.h (TABDLY): Move to configure.
4549
4550 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
4551
4552 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
4553
ea0bbd17 4554 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 4555 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
4556
4557 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 4558
308aab79
GM
4559 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
4560 * s/template.h: Move NARROWPROTO to configure.
4561
ee1cf5cf
GM
45622012-07-11 Glenn Morris <rgm@gnu.org>
4563
30fe9bf4
GM
4564 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
4565 unused since 2011-01-17 change to systty.h.
4566
ee1cf5cf
GM
4567 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
4568 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4569 Move HAVE_PTYS and HAVE_SOCKETS to configure.
4570
63e47e07
PE
45712012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4572
4573 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
4574
c43fb4c3
GM
45752012-07-11 Glenn Morris <rgm@gnu.org>
4576
4577 * s/darwin.h, s/gnu-linux.h, s/template.h:
4578 Move INTERRUPT_INPUT to configure.
4579
e8df9267
DA
45802012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4581
4582 Minor adjustments to interning code.
4583 * lisp.h (intern, intern_c_string): Redefine as static inline
4584 wrappers for intern_1 and intern_c_string_1, respectively.
4585 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
4586 * lread.c (intern_1, intern_c_string_1, oblookup):
4587 Simplify Vobarray checking.
e8df9267
DA
4588 * font.c (font_intern_prop): Likewise. Adjust comment.
4589 * w32font.c (intern_font_name): Likewise.
4590
34348bd4
AS
45912012-07-11 Andreas Schwab <schwab@linux-m68k.org>
4592
d96a1e0c
AS
4593 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
4594
34348bd4
AS
4595 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
4596 of Fcar/Fcdr if possible.
4597 * font.c (check_otf_features): Likewise.
4598 * fontset.c (Fnew_fontset): Likewise.
4599 * gnutls.c (Fgnutls_boot): Likewise.
4600 * minibuf.c (read_minibuf): Likewise.
4601 * msdos.c (IT_set_frame_parameters): Likewise.
4602 * xmenu.c (Fx_popup_dialog): Likewise.
4603 * w32menu.c (Fx_popup_dialog): Likewise.
4604
c8add24e
GM
46052012-07-11 Glenn Morris <rgm@gnu.org>
4606
4b575b3c
GM
4607 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
4608 since nothing has defined it on these platforms.
4609
09f4e3b0
GM
4610 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
4611 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
4612
172bedef
GM
4613 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
4614 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
4615 Move CLASH_DETECTION to configure.
4616
249685df
GM
4617 * s/gnu.h: Remove file, which is now empty.
4618
c8add24e
GM
4619 * s/gnu.h, s/gnu-linux.h:
4620 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
4621
b41253a3
JW
46222012-07-11 John Wiegley <johnw@newartisans.com>
4623
4624 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
4625 function attribute, so we only use it if it exists in the
4626 compiler.
4627
d923b542
DA
46282012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4629
4630 Avoid call to strlen in fast_c_string_match_ignore_case.
4631 * search.c (fast_c_string_match_ignore_case): Change to use
4632 length argument. Adjust users accordingly.
4633 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
4634
5ebbef1d
PE
46352012-07-11 Paul Eggert <eggert@cs.ucla.edu>
4636
bb352260
PE
4637 Assume mkdir, rmdir.
4638 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
4639 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
4640
57054ddd
PE
4641 Assume rename.
4642 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
4643
b747d3f7
PE
4644 Assume perror.
4645 * s/hpux10-20.h (HAVE_PERROR): Remove.
4646 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
4647 Remove dummy definition, as this problem was obsolete long ago.
4648
5ebbef1d
PE
4649 Assume strerror.
4650 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
4651
984e7f30
DA
46522012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
4653
4654 Avoid calls to strlen in font processing functions.
4655 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
4656 (font_open_by_name): Change to use length argument.
4657 Adjust users accordingly.
d923b542
DA
4658 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
4659 Adjust prototypes.
4660 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
4661 Change to return ptrdiff_t.
984e7f30
DA
4662 (xfont_list_pattern, xfont_match): Use length returned by
4663 xfont_decode_coding_xlfd.
4664 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
4665
20e94fdd
GM
46662012-07-11 Glenn Morris <rgm@gnu.org>
4667
9d596af3
GM
4668 * s/darwin.h, s/freebsd.h, s/netbsd.h:
4669 Move DONT_REOPEN_PTY to configure.
4670
20e94fdd
GM
4671 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
4672 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
4673
e99a530f
PE
46742012-07-10 Paul Eggert <eggert@cs.ucla.edu>
4675
22ffb973
PE
4676 Remove "#define unix" that is no longer needed (Bug#11905).
4677 * s/aix4-2.h (unix): Remove; no longer needed.
4678
e9a9ae03
PE
4679 EMACS_TIME simplification (Bug#11875).
4680 This replaces macros (which typically do not work in GDB)
4681 with functions, typedefs and enums, making the code easier to debug.
4682 The functional style also makes code easier to read and maintain.
4683 * systime.h: Include <sys/time.h> on all hosts, not just if
4684 WINDOWSNT, since 'struct timeval' is needed in general.
4685 (EMACS_TIME): Now a typedef, not a macro.
4686 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
4687 not macros.
4688 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
4689 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
4690 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
4691 (EMACS_TIME_LE): Now functions, not macros.
4692 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
4693 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
4694 which are not functions. All uses rewritten to use:
4695 (make_emacs_time): New function.
4696 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
4697 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
4698 not functions. All uses rewritten to use the following, respectively:
4699 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
4700 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 4701 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
4702 * fileio.c (Fcopy_file):
4703 * xterm.c (XTflash): Get the current time closer to when it's used.
4704 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
4705
ffacb126
PE
4706 * bytecode.c (targets): Suppress -Woverride-init warnings.
4707
e99a530f
PE
4708 Simplify by avoiding confusing use of strncpy etc.
4709 * doc.c (Fsnarf_documentation):
4710 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
4711 * frame.c (Fmake_terminal_frame):
4712 * gtkutil.c (get_utf8_string):
4713 * lread.c (openp):
4714 * nsmenu.m (ns_update_menubar):
4715 * regex.c (regerror):
4716 Prefer memcpy to strncpy and strncat when either will do.
4717 * fileio.c (Fsubstitute_in_file_name):
4718 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
4719 (menu_separator_name_p):
4720 * nsmenu.m (ns_update_menubar):
4721 Prefer memcmp to strncmp when either will do.
4722 * nsterm.m: Include <ftoastr.h>.
4723 (ns_get_color):
4724 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
4725 Prefer snprintf to strncpy.
4726 * nsterm.m (ns_term_init):
4727 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
4728 * nsterm.m (ns_term_init):
4729 Avoid the need for strncpy, by using build_string or
4730 make_unibyte_string directly. Use dtoastr, not snprintf.
4731 * process.c (Fmake_network_process): Diagnose service names that
4732 are too long, rather than silently truncating them or creating
4733 non-null-terminated names.
4734 (Fnetwork_interface_info): Likewise, for interface names.
4735 * sysdep.c (system_process_attributes) [GNU_LINUX]:
4736 Prefer sprintf to strncat.
4737 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
4738 Prefer vsnprintf to vsprintf + strncpy.
4739
c59592b3
GM
47402012-07-10 Glenn Morris <rgm@gnu.org>
4741
4742 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
4743 Clarify fallback case.
4744
7d7bbefd
DA
47452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4746
4747 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
4748 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
4749 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 4750 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
4751 where argument type is known to be a Lisp_Cons.
4752
3a4c8000
TT
47532012-07-10 Tom Tromey <tromey@redhat.com>
4754
4755 * bytecode.c (BYTE_CODE_THREADED): New macro.
4756 (BYTE_CODES): New macro. Replaces all old byte-code defines.
4757 (enum byte_code_op): New type.
4758 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
4759 (exec_byte_code): Use them. Use token threading when applicable.
4760
2a0213a6
DA
47612012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4762
4763 Optimize pure C strings initialization.
4764 * lisp.h (make_pure_string): Fix prototype.
4765 (build_pure_c_string): New function, defined as static inline. This
4766 provides a better opportunity to optimize away calls to strlen when
4767 the function is called with compile-time constant argument.
4768 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
4769 argument, adjust users accordingly. Use build_pure_c_string where
4770 appropriate.
4771 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
4772 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
4773 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
4774
cb1caeaf
DA
47752012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4776
4777 Avoid calls to strlen in miscellaneous functions.
4778 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
4779 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
4780 * lread.c (openp): Likewise.
4781
c293e30c
DA
47822012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
4783
4784 Avoid calls to strlen in path processing functions.
4785 * fileio.c (file_name_as_directory): Add comment. Change to add
4786 srclen argument and return the length of result. Adjust users
4787 accordingly.
4788 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
4789 swap 1st and 2nd arguments to obey the common convention.
4790 Adjust users accordingly.
c293e30c
DA
4791 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
4792
9e059e3f
GM
47932012-07-10 Glenn Morris <rgm@gnu.org>
4794
d02eb359
GM
4795 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
4796 Move PENDING_OUTPUT_COUNT definition to configure.
4797
882cf227
GM
4798 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
4799 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
4800 * s/gnu.h (DATA_START): Move definitions to configure.
4801
af6e839f
GM
4802 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4803 We include usg5-4-common.h, which defines them both.
4804
40289a12
GM
4805 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
4806 O_RDONLY already includes it).
4807
9e059e3f
GM
4808 Stop ns builds setting the EMACSLOADPATH environment variable.
4809 * nsterm.m (ns_load_path): Rename from ns_init_paths.
4810 Now it does not set EMACSLOADPATH, just returns the load-path string.
4811 * nsterm.h: Update accordingly.
4812 * lread.c [HAVE_NS]: Include nsterm.h.
4813 (init_lread) [HAVE_NS]: Use ns_load_path.
4814 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
4815
7c4e8ec0
GM
48162012-07-09 Glenn Morris <rgm@gnu.org>
4817
d4f600ff
GM
4818 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
4819 since the included bsd-common.h does so.
4820
cbb31951
GM
4821 Stop ns builds setting the EMACSPATH environment variable.
4822 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
4823 (ns_init_paths): Do not set EMACSPATH.
4824 * nsterm.h (ns_exec_path): Add it.
4825 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
4826 Use ns_exec_path.
4827
7c4e8ec0
GM
4828 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
4829
26bccfae
PE
48302012-07-09 Paul Eggert <eggert@cs.ucla.edu>
4831
a0bee46f
PE
4832 * process.c (wait_reading_process_output): 'waitchannels' was unset
4833 when read_kbd || !NILP (wait_for_cell); fix this.
4834
5994c183
PE
4835 Add GCC-style 'const' attribute to functions that can use it.
4836 * character.h (char_resolve_modifier_mask):
4837 * keyboard.h (make_ctrl_char):
4838 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
4839 (init_character_once, next_almost_prime, init_fns, init_image)
4840 (flush_pending_output, init_sound):
4841 * mem-limits.h (start_of_data):
4842 * menu.h (finish_menu_items):
4843 Add ATTRIBUTE_CONST.
4844 * emacs.c (DEFINE_DUMMY_FUNCTION):
4845 Declare the dummy function with ATTRIBUTE_CONST.
4846 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
4847 Add decls with ATTRIBUTE_CONST.
4848
26bccfae
PE
4849 Minor improvements to make_formatted_string.
4850 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
4851 where int is good enough, as vsprintf returns an int.
4852 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
4853
a8290ec3
DA
48542012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4855
4856 Use make_formatted_string to avoid double length calculation.
4857 * lisp.h (make_formatted_string): New prototype.
4858 * alloc.c (make_formatted_string): New function.
4859 * buffer.c (Fgenerate_new_buffer_name): Use it.
4860 * dbus.c (syms_of_dbusbind): Likewise.
4861 * editfns.c (Fcurrent_time_zone): Likewise.
4862 * filelock.c (get_boot_time): Likewise.
4863 * frame.c (make_terminal_frame, set_term_frame_name)
4864 (x_report_frame_params): Likewise.
4865 * image.c (gs_load): Likewise.
4866 * minibuf.c (get_minibuffer): Likewise.
4867 * msdos.c (dos_set_window_size): Likewise.
4868 * process.c (make_process): Likewise.
4869 * xdisp.c (ensure_echo_area_buffers): Likewise.
4870 * xsettings.c (apply_xft_settings): Likewise.
4871
d01ba2f1
GM
48722012-07-09 Glenn Morris <rgm@gnu.org>
4873
4874 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
4875 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
4876 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
4877 * nsterm.h (ns_etc_directory): Add it.
4878 * callproc.c [HAVE_NS]: Include nsterm.h.
4879 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
4880
f1f924b6
DA
48812012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
4882
4883 Move marker debugging code under MARKER_DEBUG.
4884 * marker.c (MARKER_DEBUG): Move marker debugging code under
4885 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
4886 for bootstrap with --enable-checking (~3x slowdown reported
4887 by Juanma Barranquero <lekktu@gmail.com>).
4888 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
4889
ab531b66
PE
48902012-07-08 Paul Eggert <eggert@cs.ucla.edu>
4891
4892 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
4893 See <http://bugs.gnu.org/11825#29>.
4894
c4b3bc8a
EZ
48952012-07-08 Eli Zaretskii <eliz@gnu.org>
4896
4897 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
4898 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
4899 (display_line): Add commentary about displaying truncation glyphs
4900 on GUI frames.
4901 (produce_special_glyphs): Move here from term.c.
4902
4903 * term.c (produce_special_glyphs): Move to xdisp.c.
4904
4905 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
4906 section.
c4b3bc8a 4907
b676b881
AS
49082012-07-07 Andreas Schwab <schwab@linux-m68k.org>
4909
f17c5273
AS
4910 * xdisp.c (display_line): Avoid warning about implicit declaration
4911 of FRAME_FONT.
4912
298819b9
AS
4913 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
4914
b676b881
AS
4915 * lisp.h: Remove empty conditional.
4916
6045c4fd
PE
49172012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4918
b3350bf9
PE
4919 * lread.c (load_path_check): Now static.
4920
6045c4fd
PE
4921 Fix some minor --with-ns problems found by static checking.
4922 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
4923 (x_set_font) [!HAVE_X_WINDOWS]:
4924 * image.c (xpm_load_image) [HAVE_NS]:
4925 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
4926 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
4927 Remove unused local.
4928 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
4929 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
4930 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
4931 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
4932 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
4933 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
4934 Fix pointer signedness problem.
4935 * xfaces.c (FRAME_X_FONT_TABLE):
4936 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
4937
929e7845
GM
49382012-07-07 Glenn Morris <rgm@gnu.org>
4939
4940 * lread.c (load_path_check): New function, split from init_lread.
4941 (init_lread): Reorganize. Motivation:
4942 If EMACSLOADPATH is set, check/warn about that rather than the
4943 defaults, which we are not going to use. Hence we can remove
4944 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
4945 Don't warn if site-lisp directories are missing.
4946 If not installed, start from a blank load-path, since
4947 PATH_LOADSEARCH refers to the eventual installation directories.
4948
58dd0aa4
EZ
49492012-07-07 Eli Zaretskii <eliz@gnu.org>
4950
4951 Support truncation and continuation glyphs on GUI frames, when
4952 fringes are disabled. (Bug#11832)
4953 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
4954 continuation glyphs even if on GUI frames.
4955 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
4956 or both, are absent.
4957 (start_display, move_it_in_display_line_to): Handle the case of a
4958 GUI frame without a fringe to display continuation or truncation
4959 glyphs.
4960 (insert_left_trunc_glyphs): Support GUI frames: make sure
4961 truncation glyphs overwrite enough glyphs from the current line to
4962 have sufficient space in pixels.
4963 (display_line): Support truncation and continuation glyphs on GUI
4964 frames. If some spare pixels are left on the line after inserting
4965 the truncation glyphs, fill that space with a stretch glyph of a
4966 suitably computed width.
4967
4968 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
4969 produce_glyphs, to support GUI sessions.
4970
31571fd7
PE
49712012-07-07 Paul Eggert <eggert@cs.ucla.edu>
4972
5a16b9bc
PE
4973 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
4974
f3047c75
PE
4975 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
4976
31571fd7
PE
4977 Do not require float-time's arg to fit in time_t (Bug#11825).
4978 This works better on hosts where time_t is unsigned, and where
4979 float-time is applied to the (negative) difference between two times.
4980 * editfns.c (decode_time_components): Last arg is now double *,
4981 not int *, and means to store all the result as a double, without
4982 worrying about whether the seconds part fits in time_t.
4983 All callers changed.
4984 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
4985 All callers changed.
4986 (Ffloat_time): Do not fail merely because the specified time falls
4987 outside of time_t range.
4988
4516fbef
GM
49892012-07-07 Glenn Morris <rgm@gnu.org>
4990
4991 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
4992 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
4993 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
4994
07adc2c6
JB
49952012-07-07 Juanma Barranquero <lekktu@gmail.com>
4996
4997 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
4998 Update dependencies.
4999
5000 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
5001
fd573f31
PE
50022012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5003
fee5959d
PE
5004 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
5005 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5006 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
5007 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
5008 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
5009 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
5010
fd573f31
PE
5011 * xfont.c (compare_font_names): Redo to omit the need for casts.
5012
ddadbc0e
AS
50132012-07-06 Andreas Schwab <schwab@linux-m68k.org>
5014
fca8d6b6
AS
5015 * xfns.c (Fx_change_window_property): Doc fix.
5016 * w32fns.c (Fx_change_window_property): Doc fix.
5017
ddadbc0e
AS
5018 * w32fns.c (Fx_window_property): Accept the same arguments as the
5019 X Windows version. Doc fix.
5020 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
5021
ed9265fc 50222012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
5023 Eli Zaretskii <eliz@gnu.org>
5024
5025 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
5026 Windows-specific code from nt/config.nt moved here.
5027 Obsolete settings removed.
5028
216ee680
PE
50292012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5030
5031 * process.c: Avoid unnecessary calls to gettime.
5032 (wait_reading_process_output): Don't get the time of day
5033 when gobbling data immediately and not waiting, as there's no need
5034 for it in that case. This removes a FIXME.
5035
bdd091e4
JD
50362012-07-06 Jan Djärv <jan.h.d@swipnet.se>
5037
5038 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
5039 is defined (Bug#11768).
5040
9d44f8ce
DA
50412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5042
5043 Fix marker debugging code.
5044 * marker.c (byte_char_debug_check): Do not perform the check
5045 if buffer is not multibyte.
090bd7cb
JB
5046 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5047 Call byte_char_debug_check with correct arguments.
9d44f8ce 5048
90fc4786
DA
50492012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5050
5051 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
5052 * marker.c (byte_char_debug_check, count_markers):
5053 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
5054 (byte_debug_flag): Remove.
5055 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
5056 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
5057
7b7ae965
DA
50582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5059
4e57b342
DA
5060 Avoid code repetition in marker-related functions.
5061 * marker.c (attach_marker): New function.
5062 (Fset_marker, set_marker_restricted, set_marker_both)
5063 (set_marker_restricted_both): Use it.
5064 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
5065 Consistently rename charno to charpos.
5066 (marker_position): Add eassert.
5067 (marker_byte_position): Convert to eassert.
5068
50692012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5070
5071 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 5072 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 5073 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 5074
657924ff
DA
50752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5076
5077 Introduce fast path for the widely used marker operation.
5078 * alloc.c (build_marker): New function.
5079 * lisp.h (build_marker): New prototype.
5080 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
5081 * composite.c (autocmp_chars): Likewise.
5082 * editfns.c (buildmark): Remove.
5083 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
5084 (save_restriction_save): Use build_marker.
5085 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
5086 * window.c (save_window_save): Likewise.
5087
041a49a6
DA
50882012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
5089
5090 Do not use Fdelete_overlay in delete_all_overlays
5091 to avoid redundant calls to unchain_overlay.
5092 * buffer.c (drop_overlay): New function.
5093 (delete_all_overlays, Fdelete_overlay): Use it.
5094 * minibuf.c (get_minibuffer): Fix comment.
5095
7dca65a4
PE
50962012-07-06 Paul Eggert <eggert@cs.ucla.edu>
5097
5098 Port to OpenBSD 5.1 amd64.
5099 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
5100 This is needed for OpenBSD, and should be harmless on all BSD systems.
5101 Also, include <sys/sysctl.h>, as it should be available on all
5102 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
5103 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
5104 use p_pid member, not kp_proc.pid.
5105
8eb876e2
GM
51062012-07-06 Glenn Morris <rgm@gnu.org>
5107
5108 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
5109
38182d90
PE
51102012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 More xmalloc and related cleanup.
5113 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
5114 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
5115 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
5116 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
5117 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
5118 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
5119 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
5120 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
5121 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
5122 * xterm.c:
5123 Omit needless casts involving void * pointers and allocation.
5124 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
5125 as the former is more robust if P's type is changed.
5126 Prefer xzalloc to xmalloc + memset 0.
5127 Simplify malloc-or-realloc to realloc.
5128 Don't worry about xmalloc returning a null pointer.
5129 Prefer xstrdup to xmalloc + strcpy.
5130 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
5131 growing it.
5132 * keyboard.c (apply_modifiers_uncached): Prefer local array to
5133 alloca of a constant.
5134
6dd5a677
EZ
51352012-07-05 Eli Zaretskii <eliz@gnu.org>
5136
5137 * xdisp.c (display_line): Fix horizontal pixel coordinates when
5138 hscroll is larger than the line width. Fixes long and futile
5139 looping inside extend_face_to_end_of_line (on a TTY) producing
5140 glyphs that are not needed and thrown away.
5141
6b312f0f
DA
51422012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5143
5144 * marker.c (set_marker_restricted_both): Simplify by using
5145 clip_to_bounds.
5146
f520ef9b
PE
51472012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5148
5149 * editfns.c (region_limit): Simplify by using clip_to_bounds.
5150
383b7c95
JD
51512012-07-05 Jan Djärv <jan.h.d@swipnet.se>
5152
5153 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
5154 not defined (Bug#11768).
5155 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
5156 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
5157 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
5158 followed by gtk_box_set_homogeneous (Bug#11768).
5159 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
5160 (update_theme_scrollbar_width, xg_create_scroll_bar):
5161 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
5162 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
5163 (is_box_type): New function (Bug#11768).
5164 (xg_tool_item_stale_p): Call is_box_type.
5293d758 5165 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
5166 with default display (Bug#11768).
5167
d6e7bf45
EZ
51682012-07-05 Eli Zaretskii <eliz@gnu.org>
5169
5170 * xdisp.c (window_hscroll_limited): New function.
5171 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
5172 coordinates when window's hscroll is set to insanely large
5173 values. (Bug#11857)
5174
431391ec
JB
51752012-07-05 Juanma Barranquero <lekktu@gmail.com>
5176
5177 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
5178 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
5179
23f86fce
DA
51802012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
5181
5182 Cleanup xmalloc.
5183 * lisp.h (xzalloc): New prototype. Omit needless casts.
5184 * alloc.c (xzalloc): New function. Omit needless casts.
5185 * charset.c: Omit needless casts. Convert all calls to
5186 xmalloc with following memset to xzalloc.
5187 * dispnew.c: Likewise.
5188 * fringe.c: Likewise.
5189 * image.c: Likewise.
5190 * sound.c: Likewise.
5191 * term.c: Likewise.
5192 * w32fns.c: Likewise.
5193 * w32font.c: Likewise.
5194 * w32term.c: Likewise.
5195 * xfaces.c: Likewise.
5196 * xfns.c: Likewise.
5197 * xterm.c: Likewise.
5198 * atimer.c: Omit needless casts.
5199 * buffer.c: Likewise.
5200 * callproc.c: Likewise.
5201 * ccl.c: Likewise.
5202 * coding.c: Likewise.
5203 * composite.c: Likewise.
5204 * doc.c: Likewise.
5205 * doprnt.c: Likewise.
5206 * editfns.c: Likewise.
5207 * emacs.c: Likewise.
5208 * eval.c: Likewise.
5209 * filelock.c: Likewise.
5210 * fns.c: Likewise.
5211 * gtkutil.c: Likewise.
5212 * keyboard.c: Likewise.
5213 * lisp.h: Likewise.
5214 * lread.c: Likewise.
5215 * minibuf.c: Likewise.
5216 * msdos.c: Likewise.
5217 * print.c: Likewise.
5218 * process.c: Likewise.
5219 * region-cache.c: Likewise.
5220 * search.c: Likewise.
5221 * sysdep.c: Likewise.
5222 * termcap.c: Likewise.
5223 * terminal.c: Likewise.
5224 * tparam.c: Likewise.
5225 * w16select.c: Likewise.
5226 * w32.c: Likewise.
5227 * w32reg.c: Likewise.
5228 * w32select.c: Likewise.
5229 * w32uniscribe.c: Likewise.
5230 * widget.c: Likewise.
5231 * xdisp.c: Likewise.
5232 * xmenu.c: Likewise.
5233 * xrdb.c: Likewise.
5234 * xselect.c: Likewise.
5235
0497dc44
PE
52362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
5237
5238 * fileio.c (time_error_value): Check the right error number.
5239 Problem reported by Troels Nielsen in
5240 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
5241
356e7178
PE
52422012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5243
4e71fd89
PE
5244 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
5245 This should be fixed in a better way; see Eli Zaretskii in
5246 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
5247 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
5248
f0941253
PE
5249 * fileio.c (time_error_value): Rename from special_mtime.
5250 The old name's problems were noted by Eli Zaretskii in
5251 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
5252
065c9eb4
PE
5253 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
5254 This variable's comment says Emacs needs at least one GDB-visible
5255 symbol of type enum pvec_type, to work around GDB problems.
5256 The symbol's value doesn't matter.
5257
356e7178
PE
5258 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
5259 that causes compilation to fail on pre-C99 compilers.
5260
ed9265fc 52612012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
5262
5263 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
5264 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
5265
3884d954
DA
52662012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5267
d209e2fb 5268 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
5269 headers for buffer_defaults and buffer_local_symbols.
5270 Reported by Juanma Barranquero <lekktu@gmail.com>.
5271
ee28be33
SM
52722012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5273
5274 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
5275 * lisp.h (enum pvec_type): Use fewer bits.
5276 (PSEUDOVECTOR_SIZE_BITS): New constant.
5277 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
5278 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
5279 change in pvec_type.
5280 (PSEUDOVECTOR_TYPEP): New macro.
5281 (TYPED_PSEUDOVECTORP): Use it.
5282 * fns.c (internal_equal): Adapt code to extract pvectype.
5283 * emacs.c (gdb_pvec_type): Update type.
5284 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
5285 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
5286 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
5287 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
5288 (sweep_vectors): Use it. Use local var `total_bytes' instead of
5289 abusing vector->header.next.nbytes.
5290 (live_vector_p): Use PVEC_TYPE.
5291 (mark_object): Adapt code to extract pvectype. Use switch.
5292
c7f2cd7f
PE
52932012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5294
5295 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
5296 Tighten new eassert a bit.
5297
8ce70ed2
DA
52982012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5299
5300 Fix compilation with --enable-gcc-warnings and -O1
5301 optimization level.
5302 * doprnt.c (doprnt): Change type of tem to int, initialize
5303 to avoid compiler warning. Add eassert.
5304 * search.c (simple_search): Initialize match_byte to avoid
5305 compiler warning. Add eassert.
5306
dea7f1e5
PE
53072012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5308
24a212eb
PE
5309 Avoid weird behavior with large horizontal scrolls.
5310 Without this change, for example, large hscroll values would
5311 mess up Emacs's display on Fedora 15 x86, presumably due to
5312 overflows in int calculations in the display code.
5313 Also, if buffers had long lines, Emacs would freeze.
5314 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
5315 (set_window_hscroll): New function, containing the old guts of
5316 Fset_window_hscroll. Return the clipped value.
5317 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
5318 This avoids the need to check against PTRDIFF_MAX.
5319
dea7f1e5
PE
5320 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
5321
76046526
DA
53222012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
5323
5324 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
5325
39adff0d
PE
53262012-07-04 Paul Eggert <eggert@cs.ucla.edu>
5327
63807d47
PE
5328 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
5329 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
5330 since GCC 4.4.6 issues a bogus warning for them.
5331
39adff0d
PE
5332 Fix bugs in file timestamp newness comparisons.
5333 * fileio.c (Ffile_newer_than_file_p):
5334 * lread.c (Fload): Use full timestamp resolution of files,
5335 not just the 1-second resolution, so that files that are only
5336 slightly newer still count as newer.
5337 * fileio.c (Ffile_newer_than_file_p): Don't assume file
5338 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
5339
dbeed9a6
PE
53402012-07-03 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 * fileio.c: Improve handling of file time marker. (Bug#11852)
5343 (special_mtime): New function.
5344 (Finsert_file_contents, Fverify_visited_file_modtime):
5345 Use it to set special mtime values consistently.
5346
636334d6
AS
53472012-07-03 Andreas Schwab <schwab@linux-m68k.org>
5348
5349 * fileio.c (Finsert_file_contents): Properly handle st_mtime
5350 marker for non-existing file. (Bug#11852)
5351
e2017fe2
GM
53522012-07-03 Glenn Morris <rgm@gnu.org>
5353
5354 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
5355 and did not make it into globals.h).
5356
404dbd37
TT
53572012-07-03 Tom Tromey <tromey@redhat.com>
5358
5359 * window.c (Fset_window_margins, Fset_window_fringes)
5360 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
5361 * textprop.c (Fprevious_property_change): No longer static.
5362 * syntax.c (Fsyntax_table_p): No longer static.
5363 * process.c (Fget_process, Fprocess_datagram_address): No longer
5364 static.
5365 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
5366 * keyboard.c (Fcommand_execute): No longer static.
5367 Remove EXFUN.
5368 * insdel.c (Fcombine_after_change_execute): No longer static.
5369 * image.c (Finit_image_library): No longer static.
5370 * fileio.c (Fmake_symbolic_link): No longer static.
5371 * eval.c (Ffetch_bytecode): No longer static.
5372 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
5373 * doc.c (Fdocumentation_property, Fsnarf_documentation):
5374 No longer static.
404dbd37
TT
5375 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
5376 static.
5377 * dired.c (Ffile_attributes): No longer static.
5378 * composite.c (Fcomposition_get_gstring): No longer static.
5379 * callproc.c (Fgetenv_internal): No longer static.
5380
5381 * ccl.h: Remove EXFUNs.
5382 * buffer.h: Remove EXFUNs.
5383 * dispextern.h: Remove EXFUNs.
5384 * intervals.h: Remove EXFUNs.
5385 * fontset.h: Remove EXFUN.
5386 * font.h: Remove EXFUNs.
5387 * dosfns.c (system_process_attributes): Remove EXFUN.
5388 * keymap.h: Remove EXFUNs.
5389 * lisp.h: Remove EXFUNs.
5390 * w32term.h: Remove EXFUNs.
5391 * window.h: Remove EXFUNs.
5392 * xsettings.h: Remove EXFUN.
5393 * xterm.h: Remove EXFUN.
5394
8e4fd1e1
GM
53952012-07-03 Glenn Morris <rgm@gnu.org>
5396
5397 * lisp.h (Frandom): Make it visible to C.
5398 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
5399 buffer for invisible buffers. (Bug#1229)
5400
ca95b3eb
DA
54012012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5402
5403 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
5404 values which aren't power of 2.
14ae4239
BT
5405 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
5406 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
5407 accordingly.
5408
7555c33f
SM
54092012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
5410
5411 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
5412
5413 * alloc.c (mark_object): Revert part of last patch to use `switch'.
5414
d12e8f5a
DA
54152012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5416
5417 * alloc.c (allocate_vector_block): Remove redundant
5418 calls to mallopt if DOUG_LEA_MALLOC is defined.
5419 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
5420 avoid calls to mallopt if zero_vector is returned.
5421
296094c3
DA
54222012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5423
5424 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
5425 is enabled, avoid dereferencing NULL current_sblock if
5426 running undumped.
5427
36429c89
DA
54282012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
5429
5430 Cleanup basic buffer management.
5431 * buffer.h (struct buffer): Change layout to use generic vector
5432 marking code. Fix some comments. Change type of 'clip_changed'
5433 to bitfield. Remove unused #ifndef old.
5434 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
5435 (GET_OVERLAYS_AT): Fix indentation.
5436 (for_each_per_buffer_object_at): New macro.
5437 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
5438 (Fbuffer_local_variables): Use it.
5439 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
5440 * alloc.c (allocate_buffer): Adjust to match new layout of
5441 struct buffer. Fix comment.
5442 (mark_overlay): New function.
5443 (mark_buffer): Use it. Use mark_vectorlike to mark normal
5444 Lisp area of struct buffer.
5445 (mark_object): Use it. Adjust marking of misc objects
5446 and related comments.
5447
3b3e4cac
PE
54482012-07-02 Paul Eggert <eggert@cs.ucla.edu>
5449
5450 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
5451 wrapper that is not needed because the wrapped code is a no-op (zero
5452 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
5453 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
5454
cf5c0175
DA
54552012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
5456
5457 * alloc.c (mark_buffer): Simplify. Remove prototype.
5458 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 5459 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
5460 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
5461 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 5462
ca26824c
GM
54632012-06-30 Glenn Morris <rgm@gnu.org>
5464
2e4c5312
GM
5465 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
5466
ca26824c
GM
5467 * epaths.in (PATH_SITELOADSEARCH): New.
5468 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
5469 This is rather than relying on --enable-locallisppath elements
5470 having "site-lisp" in their names. (Bug#10208#25, 11658)
5471
0d23c240
EZ
54722012-06-30 Eli Zaretskii <eliz@gnu.org>
5473
c9240d7a
EZ
5474 * w32proc.c (sys_select): Accept and ignore one more argument.
5475
5476 * w32.c (emacs_gnutls_pull): Call select with one more argument.
5477
0d23c240 5478 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 5479 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
5480
5481 * sysdep.c: Don't include dos.h and dosfns.h.
5482
5483 * process.c (sys_select):
5484 * msdos.c (sys_select): Accept one more argument and ignore it.
5485
5486 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
5487 adapt data types and code to that.
5488
5489 * dosfns.c:
5490 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
5491 which clashes with the gnulib function of the same name.
5492
af5a5a98
AS
54932012-06-30 Andreas Schwab <schwab@linux-m68k.org>
5494
c5e4379c
AS
5495 * font.c (font_style_to_value, font_style_symbolic)
5496 (font_prop_validate_style): Add type checks for values in
5497 font_style_table.
5498
af5a5a98
AS
5499 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
5500 argument.
5501 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
5502 uses.
5503
8d38f461
EZ
55042012-06-29 Eli Zaretskii <eliz@gnu.org>
5505
2e5a6631
EZ
5506 * xdisp.c (try_window_id): Undo last change.
5507
8d38f461
EZ
5508 * w32.c (getwd): Adjust commentary about startup_dir.
5509 (init_environment): Always call sys_access, even in non-MSVC
5510 builds. Don't chdir to the directory of the Emacs executable.
5511 This undoes code from 1997 which was justified by the need to
5512 "avoid conflicts when removing and renaming directories". But its
5513 downside was that every relative file name was being interpreted
5514 relative to the directory of the Emacs executable, which can never
5515 be TRT. In particular, it broke sys_access when called with
5516 relative file names.
5517 (sys_access): Map GetLastError to errno.
5518
2af3565e
DA
55192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5520
5521 * window.h (struct window): Change type of 'fringes_outside_margins'
5522 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 5523 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
5524 Adjust comment.
5525 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
5526 to ptrdiff_t.
5527
c8d3a25c 55282012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 5529
c8d3a25c
GM
5530 * gnutls.c (emacs_gnutls_handshake):
5531 Add QUIT to make the loop interruptible.
57570cd3 5532
c8d3a25c 55332012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 5534
c8d3a25c
GM
5535 * charset.c (init_charset): Make lack of etc/charsets fatal.
5536
3e984ee8
DA
55372012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5538
5539 * editfns.c (region_limit): Fix type mismatch.
5540
ef884f23
DA
55412012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
5542
5543 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
5544 undefined. Convert from xassert to eassert.
5545 * nsmenu.m: Convert from xassert to eassert.
5546 * nsterm.m: Likewise.
5547
7d7e0027
SM
55482012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
5549
5550 * editfns.c (region_limit): Clip to narrowing (bug#11770).
5551
aa754e6a
PE
55522012-06-28 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 Avoid integer overflow on scroll-left and scroll-right.
5555 * window.c (HSCROLL_MAX): New macro.
5556 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
5557 overflow when requested scroll falls outside ptrdiff_t range.
5558
80b00b08
DA
55592012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5560
5561 * window.h (struct window): Change type of 'hscroll',
5562 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
5563 'last_modified' and 'last_overlay_modified' to EMACS_INT.
5564 Adjust users accordingly.
5565 * xdisp.c (try_cursor_movement): Replace type check with eassert.
5566 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
5567 from EMACS_INT to ptrdiff_t.
5568 (make_window): Omit redundant initialization.
5569
62b2bcf6
JB
55702012-06-28 Juanma Barranquero <lekktu@gmail.com>
5571
5572 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
5573
45942c7d
DA
55742012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5575
5576 * window.h (struct window): Change type of 'use_time' and
5577 'sequence_number' from Lisp_Object to int.
5578 * frame.c (make_frame): Adjust users accordingly.
5579 * print.c (print_object): Likewise.
5580 * window.c (select_window, Fwindow_use_time, make_parent_window)
5581 (make_window): Likewise.
5582
e509cfa6
DA
55832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5584
5585 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
5586 enabled with --enable-checking=[all,glyphs] configure option.
5587 Fix GLYPH_DEBUG usage assuming that it may be undefined,
5588 adjust comments accordingly.
5589 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
5590 undefined, adjust comments accordingly.
5591 * image.c: Likewise.
5592 * scroll.c: Likewise.
5593 * w32fns.c: Likewise.
5594 * w32term.c: Likewise.
5595 * xdisp.c: Likewise.
5596 * xfaces.c: Likewise.
5597 * xfns.c: Likewise.
5598 * xterm.c: Likewise.
5599
a54e2c05
DA
56002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
5601
5602 Generalize run-time debugging checks.
5603 * dispextern.h (XASSERTS): Remove.
5604 * fontset.c (xassert): Remove.
5605 Convert from xassert to eassert.
5606 * alloc.c: Convert from xassert to eassert.
5607 * bidi.c: Likewise.
5608 * dispnew.c: Likewise.
5609 * fns.c: Likewise.
5610 * fringe.c: Likewise.
5611 * ftfont.c: Likewise.
5612 * gtkutil.c: Likewise.
5613 * image.c: Likewise.
5614 * keyboard.c: Likewise.
5615 * menu.c: Likewise.
5616 * process.c: Likewise.
5617 * scroll.c: Likewise.
5618 * sound.c: Likewise.
5619 * term.c: Likewise.
5620 * w32console.c: Likewise.
5621 * w32fns.c: Likewise.
5622 * w32term.c: Likewise.
5623 * window.c: Likewise.
5624 * xdisp.c: Likewise.
5625 * xfaces.c: Likewise.
5626 * xfns.c: Likewise.
5627 * xselect.c: Likewise.
5628 * xterm.c: Likewise.
5629
1ec4b7b2
SM
56302012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
5631
5632 * fns.c (maybe_resize_hash_table): Output message when growing the
5633 purify-hashtable.
5634
2014308a
DA
56352012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5636
5637 * alloc.c (allocate_string_data): Remove dead code.
5638 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
5639 avoid GCC warning about unused macro.
5640
246155eb
DA
56412012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5642
5643 * alloc.c (allocate_string): Omit intervals initialization.
5644 * alloc.c (make_uninit_multibyte_string): Initialize intervals
5645 as in make_pure_string and make_pure_c_string.
5646
43184b7b
DA
56472012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5648
d209e2fb 5649 * alloc.c (allocate_string): Fix last change.
43184b7b 5650
3fe6dd74
DA
56512012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
5652
d209e2fb 5653 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
5654 to memset, add explicit initialization where appropriate.
5655
1ba6038a
GM
56562012-06-27 Glenn Morris <rgm@gnu.org>
5657
5658 * lisp.mk (lisp): Remove paths.elc.
5659
c89926a5
CY
56602012-06-27 Chong Yidong <cyd@gnu.org>
5661
5662 * doc.c (Fsubstitute_command_keys): Fix punctuation.
5663
ed6b3510
JW
56642012-06-26 John Wiegley <johnw@newartisans.com>
5665
1ec4b7b2 5666 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
5667 on Mac OS X Lion: __mod_init_func and __mod_term_func.
5668
ed6b3510
JW
5669 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
5670 when building with Clang.
5671
8edd4a2b
SM
56722012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
5673
5674 * eval.c (Fapply): Allow calling it with a single argument.
5675
f6f62d1b
EZ
56762012-06-26 Eli Zaretskii <eliz@gnu.org>
5677
5678 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
5679 _stricmp and _strnicmp.
5680 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
5681
62efea5e
DA
56822012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5683
5684 * alloc.c (allocate_window): Zero out non-Lisp part of newly
5685 allocated window.
5686 (allocate_process): Likewise for new process.
8edd4a2b 5687 (allocate_terminal): Change to use offsetof.
62efea5e
DA
5688 (allocate_frame): Likewise.
5689 * frame.c (make_frame): Omit redundant initialization.
5690 * window.c (make_parent_window): Use memset.
5691 (make_window): Omit redundant initialization.
5692 * process.c (make_process): Omit redundant initialization.
5693 * terminal.c (create_terminal): Likewise.
5694
42997f4d
DA
56952012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5696
5697 * term.c (delete_tty): Remove redundant call to memset.
5698
1130ecfc
DA
56992012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
5700
5701 * alloc.c: Remove build_string.
5702 * lisp.h: Define build_string as static inline. This provides
5703 a better opportunity to optimize away calls to strlen when the
5704 function is called with compile-time constant argument.
5705 * image.c (imagemagick_error): Convert to build_string.
5706 * w32proc.c (sys_spawnve): Likewise.
5707 * xterm.c (x_term_init): Likewise.
5708
cf38a720
PE
57092012-06-26 Paul Eggert <eggert@cs.ucla.edu>
5710
99027bdd
PE
5711 Use sprintf return value instead of invoking strlen on result.
5712 In the old days this wasn't portable, since some sprintf
5713 implementations returned char *. But they died out years ago and
5714 Emacs already assumes sprintf returns int.
5715 Similarly for float_to_string.
5716 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
5717 * ccl.c (ccl_driver):
5718 * character.c (string_escape_byte8):
5719 * data.c (Fnumber_to_string):
5720 * doprnt.c (doprnt):
5721 * print.c (print_object):
5722 * xdisp.c (message_dolog):
5723 * xfns.c (syms_of_xfns):
5724 Use sprintf or float_to_string result to avoid need to call strlen.
5725 * data.c (Fnumber_to_string):
5726 Use make_unibyte_string, since the string must be ASCII.
5727 * lisp.h, print.c (float_to_string): Now returns int length.
5728 * term.c (produce_glyphless_glyph):
5729 Use sprintf result rather than recomputing it.
5730
cf38a720
PE
5731 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
5732 * Makefile.in (ALL_CFLAGS):
5733 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
5734 * gmalloc.c, regex.c: Include <config.h> unconditionally.
5735
3511c784
DA
57362012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5737
0a08eb21 5738 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
5739 strcasecmp if available.
5740 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
5741
fb7da12e
AS
57422012-06-25 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
5745 Avoid comma operator.
5746 * menu.c (push_submenu_start, push_submenu_end)
5747 (push_left_right_boundary, push_menu_pane): Likewise.
5748 * msdos.c (dos_rawgetc): Likewise.
5749
afa2ffd8
DA
57502012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5751
5752 * xfns.c (xic_create_fontsetname): Remove redundant calls
5753 to memset.
5754
b3b4476b
PE
57552012-06-25 Paul Eggert <eggert@cs.ucla.edu>
5756
4495ff38
PE
5757 * gtkutil.c (get_utf8_string): Remove redundant assignment.
5758 sprintf already null-terminates its output.
5759
b3b4476b
PE
5760 * xfns.c (x_window): Remove redundant cast.
5761
b00876c9
DA
57622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
5763
5764 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
5765 `const char *' to `char *' to avoid compiler warning.
5766
d188e26b
PE
57672012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5768
885d1d74
PE
5769 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
5770 instead of truncating it to 63 (admittedly a generous limit).
5771
d188e26b
PE
5772 * process.c: Fix spelling and caps in comments.
5773
e2f560b1
DN
57742012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
5775
e86db54b 5776 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
5777 * sysdep.c (setpgrp): Remove definition, not used in this file.
5778
7583a3a1
JB
57792012-06-24 Juanma Barranquero <lekktu@gmail.com>
5780
5781 * makefile.w32-in: Update dependencies.
5782
696056c2
EZ
57832012-06-24 Eli Zaretskii <eliz@gnu.org>
5784
5785 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
5786 (SYSTIME_H): Add nt/inc/sys/time.h.
5787
5788 * systime.h [WINDOWSNT]: Include sys/time.h.
5789
5790 * s/ms-w32.h (struct timespec): Definition moved from
5791 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
5792
845ca893
PE
57932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5794
5795 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
5796 * buffer.h (buffer_slot_type_mismatch):
5797 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5798 * eval.c (unwind_to_catch):
5799 * image.c (my_png_error, my_error_exit):
5800 * keyboard.c (quit_throw_to_read_char, user_error)
5801 (Fexit_recursive_edit, Fabort_recursive_edit):
5802 * lisp.h (die, args_out_of_range, args_out_of_range_3)
5803 (wrong_type_argument, buffer_overflow, __executable_start)
5804 (memory_full, buffer_memory_full, string_overflow, Fthrow)
5805 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
5806 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
5807 (fatal):
5808 (child_setup) [!DOS_NT]:
5809 * lread.c (end_of_file_error, invalid_syntax):
5810 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
5811 * puresize.h (pure_write_error):
5812 * search.c (matcher_overflow):
5813 * sound.c (sound_perror, alsa_sound_perror):
5814 * sysdep.c, syssignal.h (croak):
5815 * term.c (maybe_fatal, vfatal):
5816 * textprop.c (text_read_only):
5817 * undo.c (user_error):
5818 * unexmacosx.c (unexec_error):
5819 * xterm.c (x_ins_del_lines, x_delete_glyphs):
5820 Use _Noreturn rather than NO_RETURN.
5821 No need for separate decl merely because of _Noreturn.
5822 * sound.c (sound_warning, parse_sound):
5823 Remove unnecessary forward decls.
5824
f1dd8073
PE
58252012-06-24 Paul Eggert <eggert@cs.ucla.edu>
5826
5827 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
5828 * lisp.h (WAIT_READING_MAX): New macro.
5829 * dispnew.c (Fsleep_for, sit_for):
5830 * keyboard.c (kbd_buffer_get_event):
5831 * process.c (Faccept_process_output):
5832 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
5833 This improves on the previous patch, which introduced a bug
5834 when time_t is unsigned and as wide as intmax_t.
5835 See <http://bugs.gnu.org/9000#51>.
5836
b82c1755
EZ
58372012-06-23 Eli Zaretskii <eliz@gnu.org>
5838
5839 * dispnew.c (sit_for, Fsleep_for):
5840 * keyboard.c (kbd_buffer_get_event):
5841 * process.c (Faccept_process_output): Avoid compiler warnings when
5842 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
5843
ca300656
JB
58442012-06-23 Juanma Barranquero <lekktu@gmail.com>
5845
049ec95b
JB
5846 * makefile.w32-in: Update dependencies.
5847
ca300656
JB
5848 * w32.c (ltime): Add return type and declare static.
5849 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
5850
db7b8d06
PE
58512012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5852
5853 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
5854 Privately reported by Herbert J. Skuhra.
5855 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
5856 All uses changed.
5857 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
5858 not make_lisp_timeval, when the argument is of type EMACS_TIME.
5859
0bd8297f
EZ
58602012-06-23 Eli Zaretskii <eliz@gnu.org>
5861
96512555
EZ
5862 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
5863 last argument of make_unibyte_string.
5864
0bd8297f
EZ
5865 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
5866 language ID in the event parameters.
5867
5868 * w32term.c (w32_read_socket): Put the new keyboard codepage into
5869 event.code, not the obscure "character set ID".
5870
63def6b6
CY
58712012-06-23 Chong Yidong <cyd@gnu.org>
5872
5873 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
5874
e8a02204
EZ
58752012-06-23 Eli Zaretskii <eliz@gnu.org>
5876
388cdec0
EZ
5877 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
5878 * w32.c (fdutimens): New function.
5879
5880 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
5881
5882 * s/ms-w32.h (pselect): Redirect to sys_select.
5883
5884 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
5885
e8a02204
EZ
5886 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
5887 in the logic of incrementing and decrementing the value of
5888 use_relocatable_buffers.
5889
d054f3fb
PE
58902012-06-23 Paul Eggert <eggert@cs.ucla.edu>
5891
5892 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
5893 Privately reported by Herbert J. Skuhra.
5894 [__FreeBSD__]: Remove "*/" typo after "#include".
5895 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
5896 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
5897 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
5898 Don't assume EMACS_TIME and struct timeval are the same type.
5899
d35af63c
PE
59002012-06-22 Paul Eggert <eggert@cs.ucla.edu>
5901
5902 Support higher-resolution time stamps (Bug#9000).
5903 The time stamps are only nanosecond-resolution at the C level,
5904 since that's the best that any real-world system supports now.
5905 But they are picosecond-resolution at the Lisp level, as that's
5906 easy, and leaves room for future OS improvements.
5907
5908 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
5909 (LIBES): Use it.
5910
5911 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
5912 Don't get current time unless it's needed.
5913
5914 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
5915 now provides it if it's absent.
5916 (start_atimer): Port to higher-res time stamps.
5917 Check for time stamp overflow. Don't get current time more
5918 often than is needed.
5919
5920 * buffer.h (struct buffer): Buffer modtime now has high resolution.
5921 Include systime.h, not time.h.
5922 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
5923
5924 * dired.c: Include stat-time.h.
5925 (Ffile-attributes): File times now have higher resolution.
5926
5927 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
5928 (struct image): Timestamp now has higher resolution.
5929
5930 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
5931 has at least microseconds now. All uses removed.
5932 (update_frame, update_single_window, update_window, update_frame_1)
5933 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
927c7216 5934 (duration_to_sec_usec): Remove; no longer needed.
d35af63c
PE
5935
5936 * editfns.c (time_overflow): Now extern.
5937 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
5938 (float-time, Fformat_time_string, Fcurrent_time_string)
5939 (Fcurrent_time_zone): Accept and generate higher-resolution
5940 time stamps.
5941 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
5942 (decode_time_components, lisp_seconds_argument): New functions.
5943 (make_time): Now static.
5944 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
5945 Report an error if the time is invalid, rather than having the caller
5946 do that.
5947
5948 * fileio.c: Include <stat-time.h>
5949 (Fcopy_file): Copy higher-resolution time stamps.
5950 Prefer to set the time stamp via a file descriptor if that works.
5951 (Fset_file_times, Finsert_file_contents, Fwrite_region)
5952 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
5953 (Fvisited_file_modtime, Fset_visited_file_modtime):
5954 Support higher-resolution time stamps.
5955
5956 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
5957
5958 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
5959
5960 * image.c (prepare_image_for_display, clear_image_cache)
5961 (lookup_image): Port to higer-resolution time stamps.
5962
5963 * keyboard.c (start_polling, bind_polling_period):
5964 Check for time stamp overflow.
5965 (read_char, kbd_buffer_get_event, timer_start_idle)
5966 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
5967 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
5968 Port to higher-resolution time stamps. Do not assume time_t is signed.
5969 (decode_timer): New function. Timers are now vectors of length 9,
5970 not 8, to accommodate the picosecond component.
5971 (timer_check_2): Use it.
5972
5973 * nsterm.m (select_timeout, timeval_subtract): Remove.
5974 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
5975 as they're a bit more accurate and handle overflow better.
5976 (ns_select): Change prototype to be compatible with pselect.
5977 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
5978 * nsterm.h (ns_select): Adjust prototype.
5979
5980 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
5981 us-resolution time stamps.
5982 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
5983
5984 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
5985
5986 * lisp.h (time_overflow): New decl.
5987 (wait_reading_process_output): First arg is now intmax_t, not int,
5988 to accommodate larger waits.
5989
5990 * process.h (struct Lisp_Process.read_output_delay):
5991 Now counts nanoseconds, not microseconds.
5992 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
5993 EMACS_HAS_USECS.
5994 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
5995 (wait_reading_process_output):
5996 Port to ns-resolution time stamps.
5997 (Faccept_process_output, wait_reading_process_output):
5998 Check for time stamp overflow. Do not assume time_t is signed.
5999 (select_wrapper): Remove; we now use pselect.
6000 (Fprocess_attributes): Now generates ns-resolution time stamps.
6001
6002 * sysdep.c: Include utimens.h. Don't include utime.h
6003 or worry about struct utimbuf; gnulib does that for us now.
6004 (gettimeofday): Remove; gnulib provides a substitute.
6005 (make_timeval): New function.
6006 (set_file_times): Now sets ns-resolution time stamps.
6007 New arg FD; all uses changed.
6008 (time_from_jiffies, ltime_from_jiffies, get_up_time)
6009 (system_process_attributes):
6010 Now returns ns-resolution time stamp. All uses changed.
6011 Check for time stamp overflow.
6012
6013 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
6014 provides a substitute now.
6015
6016 * systime.h: Include timespec.h rather than sys/time.h and time.h,
6017 since it guarantees struct timespec.
6018 (EMACS_TIME): Now struct timespec, so that we can support
6019 ns-resolution time stamps.
6020 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
6021 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
6022 (EMACS_USECS): Remove.
6023 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
6024 so multiply the arg by 1000 before storing it.
6025 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
6026 New macros.
6027 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
6028 Port to ns-resolution time stamps.
6029 (EMACS_TIME_NEG_P): Remove; replaced by....
6030 (EMACS_TIME_SIGN): New macro.
6031 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
6032 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
6033 (set_file_times, make_time, lisp_time_argument): Adjust signature.
6034 (make_timeval, make_lisp_time, decode_time_components): New decls.
6035 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
6036 that it mishandled time_t overflow. You can't compare by subtracting!
6037 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
6038 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
6039
6040 * term.c: Include <sys/time.h>.
6041 (timeval_to_Time): New function, for proper overflow wraparound.
6042 (term_mouse_position, term_mouse_click): Use it.
6043
6044 * undo.c (record_first_change): Support higher-resolution time stamps
6045 in the undo buffer.
6046 (Fprimitive_undo): Use them when restoring time stamps.
6047
6048 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
6049 (w32_get_internal_run_time):
6050 Port to higher-resolution Emacs time stamps.
6051 (ltime): Now accepts single 64-bit integer, as that's more convenient
6052 for callers.
6053
6054 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
6055
6056 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
6057 for compatibility with pselect. Support ns-resolution time stamps.
6058
6059 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
6060
6061 * xselect.c (wait_for_property_change, x_get_foreign_selection):
6062 Check for time stamp overflow, and support ns-resolution time stamps.
6063
6064 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
6065 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
6066 (timeval_subtract): Remove; no longer needed.
6067 (XTflash, XTring_bell, x_wait_for_event):
6068 Port to ns-resolution time stamps. Don't assume time_t is signed.
6069
b6a92dfe
CY
60702012-06-22 Chong Yidong <cyd@gnu.org>
6071
6072 * xdisp.c (x_consider_frame_title): Revert last change.
6073
d251c37c
EZ
60742012-06-22 Eli Zaretskii <eliz@gnu.org>
6075
6076 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
6077 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
6078 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
6079 staticidx goes up to 1597 out of 1600 = 0x640.)
6080
f10deafb
PE
60812012-06-20 Paul Eggert <eggert@cs.ucla.edu>
6082
6083 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
6084 Otherwise, the umask might be mistakenly 0 while handling input signals.
6085
ec6de1e2
SM
60862012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
6087
6088 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
6089
28be1ada
DA
60902012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
6091
6092 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
6093 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
6094 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
6095 access to `contents' member of Lisp_Vector objects with AREF and ASET
6096 where appropriate.
6097
c6bf3022
CY
60982012-06-19 Chong Yidong <cyd@gnu.org>
6099
6100 * frame.c (delete_frame): When selecting a frame on a different
6101 text terminal, do not alter the terminal's top-frame.
6102
6103 * xdisp.c (format_mode_line_unwind_data): Record the target
6104 frame's selected window and its terminal's top-frame.
6105 (unwind_format_mode_line): Restore them.
6106 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
6107 Callers changed.
6108 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
6109 since tty frames can be explicitly named.
6110 (prepare_menu_bars): Likewise.
6111
6112 * term.c (Ftty_top_frame): New function.
6113
defd4196
PE
61142012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6115
6116 Port byte-code-meter to modern targets.
6117 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
6118 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 6119 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
6120 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
6121 (METER_1, METER_2): Simplify.
6122
1053a871
SM
61232012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
6124
6125 * data.c (Fdefalias): Return `symbol' (bug#11686).
6126
b7e8d081
MR
61272012-06-18 Martin Rudalics <rudalics@gmx.at>
6128
6129 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
6130 gets killed during executing of this function (Bug#11665).
6131 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
6132 (Vkill_buffer_query_functions): In doc-string say that functions
6133 run by this hook should not change the current buffer.
6134
7ea2b339
PE
61352012-06-18 Paul Eggert <eggert@cs.ucla.edu>
6136
6137 Fix recently-introduced process.c problems found by static checking.
6138 * process.c (write_queue_push, write_queue_pop, send_process):
6139 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
6140 (write_queue_pop): Fix pointer signedness problem.
6141 (send_process): Remove unused local.
6142
96a313a1
CY
61432012-06-17 Chong Yidong <cyd@gnu.org>
6144
6145 * xdisp.c (redisplay_internal): No need to redisplay terminal
6146 frames that are not on top.
6147
20ca2e94
TN
61482012-06-17 Troels Nielsen <bn.troels@gmail.com>
6149
6150 * process.c (make_process): Initialize write_queue.
6151 (write_queue_push, write_queue_pop): New functions.
6152 (send_process): Use them to maintain correct ordering of process
6153 writes (Bug#10815).
6154
9a900ca9
PE
61552012-06-17 Paul Eggert <eggert@cs.ucla.edu>
6156
310fbfa8
PE
6157 * lisp.h (eassert): Assume C89 or later.
6158 This removes the need for CHECK.
6159 (CHECK): Remove. Its comments about always evaluating its
6160 argument were confusing, as 'eassert' typically does not evaluate
6161 its argument.
6162
27bb1ca4
PE
6163 * coding.c (produce_chars): Use ptrdiff_t, not int.
6164
9a900ca9
PE
6165 * xterm.c (x_draw_underwave): Check for integer overflow.
6166 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
6167
41b7f8bc 61682012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
6169
6170 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
6171 referenced (Bug#11583).
6172
9b0e3eba
AA
61732012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
6174
6175 Implement wave-style variant of underlining.
6176 * dispextern.h (face_underline_type): New enum.
6177 (face): Add field for underline type.
6178 * nsterm.m (ns_draw_underwave): New function.
6179 (ns_draw_text_decoration): Use it.
6180 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
6181 New functions.
6182 (x_draw_glyph_string): Use them.
6183 * xfaces.c (Qline, Qwave): New Lisp objects.
6184 (check_lface_attrs, merge_face_ref)
1053a871
SM
6185 (Finternal_set_lisp_face_attribute, realize_x_face):
6186 Handle wave-style underline face attributes.
9b0e3eba
AA
6187 * xterm.c (x_draw_underwave): New function.
6188 (x_draw_glyph_string): Use it.
6189
0fb52f11
JB
61902012-06-16 Juanma Barranquero <lekktu@gmail.com>
6191
6192 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
6193 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
6194 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6195 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
6196 ($(BLD)/w32select.$(O)): Update dependencies.
6197
e5560ff7
AS
61982012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6199
6200 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
6201 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
6202 * character.c (_fetch_multibyte_char_p): Remove.
6203 * alloc.c: Include "character.h" before "buffer.h".
6204 * bidi.c: Likewise.
6205 * buffer.c: Likewise.
6206 * bytecode.c: Likewise.
6207 * callint.c: Likewise.
6208 * callproc.c: Likewise.
6209 * casefiddle.c: Likewise.
6210 * casetab.c: Likewise.
6211 * category.c: Likewise.
6212 * cmds.c: Likewise.
6213 * coding.c: Likewise.
6214 * composite.c: Likewise.
6215 * dired.c: Likewise.
6216 * dispnew.c: Likewise.
6217 * doc.c: Likewise.
6218 * dosfns.c: Likewise.
6219 * editfns.c: Likewise.
6220 * emacs.c: Likewise.
6221 * fileio.c: Likewise.
6222 * filelock.c: Likewise.
6223 * font.c: Likewise.
6224 * fontset.c: Likewise.
6225 * fringe.c: Likewise.
6226 * indent.c: Likewise.
6227 * insdel.c: Likewise.
6228 * intervals.c: Likewise.
6229 * keyboard.c: Likewise.
6230 * keymap.c: Likewise.
6231 * lread.c: Likewise.
6232 * macros.c: Likewise.
6233 * marker.c: Likewise.
6234 * minibuf.c: Likewise.
6235 * nsfns.m: Likewise.
6236 * nsmenu.m: Likewise.
6237 * print.c: Likewise.
6238 * process.c: Likewise.
6239 * regex.c: Likewise.
6240 * region-cache.c: Likewise.
6241 * search.c: Likewise.
6242 * syntax.c: Likewise.
6243 * term.c: Likewise.
6244 * textprop.c: Likewise.
6245 * undo.c: Likewise.
6246 * unexsol.c: Likewise.
6247 * w16select.c: Likewise.
6248 * w32fns.c: Likewise.
6249 * w32menu.c: Likewise.
6250 * window.c: Likewise.
6251 * xdisp.c: Likewise.
6252 * xfns.c: Likewise.
6253 * xmenu.c: Likewise.
6254 * xml.c: Likewise.
6255 * xselect.c: Likewise.
6256
2f07e6af
EZ
62572012-06-16 Eli Zaretskii <eliz@gnu.org>
6258
1053a871
SM
6259 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
6260 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 6261 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
6262 row.
6263 (handle_face_prop): Use chunk-relative overlay string index when
6264 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
6265 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
6266 the rightmost. (Bug#11720)
2f07e6af 6267
29b83cec
AS
62682012-06-16 Andreas Schwab <schwab@linux-m68k.org>
6269
6270 * category.h (CHAR_HAS_CATEGORY): Define as inline.
6271 (CATEGORY_MEMBER): Enforce 1/0 value.
6272 * category.c (_temp_category_set): Remove.
6273
4c5501e9
EZ
62742012-06-16 Eli Zaretskii <eliz@gnu.org>
6275
6276 * window.c (Fdelete_other_windows_internal)
6277 (Fdelete_window_internal): Don't access frame's mouse highlight
6278 info of the initial frame. (Bug#11677)
6279
2b570124
PE
62802012-06-14 Paul Eggert <eggert@cs.ucla.edu>
6281
e93864f9
PE
6282 * .gdbinit (xgetint): Fix recently-introduced paren typo.
6283 Assume USE_2_TAGS_FOR_INTS.
6284 (xreload): Adjust $tagmask width to match recent lisp.h change.
6285
2b570124
PE
6286 Simplify lisp.h in minor ways that should not affect code.
6287 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
6288 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6289 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
6290 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
6291 (INTTYPEBITS): New macro, for clarity.
6292 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
6293 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
6294 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
6295 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
6296 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
6297
81755f69
JB
62982012-06-13 Juanma Barranquero <lekktu@gmail.com>
6299
6300 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
6301
16192a57
GM
63022012-06-13 Glenn Morris <rgm@gnu.org>
6303
6304 * s/bsd-common.h (BSD4_3):
6305 * s/usg5-4-common.h (USG5_4): No longer define; unused.
6306
646b5f55
AS
63072012-06-13 Andreas Schwab <schwab@linux-m68k.org>
6308
6309 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
6310 instead of union.
6311 (XLI, XIL): Define.
1053a871
SM
6312 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
6313 Use them.
6314 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 6315 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 6316 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
6317 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
6318 * frame.c (delete_frame): Remove outdated comment.
6319 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
6320 USE_LISP_UNION_TYPE.
6321 (Fw32_unregister_hot_key): Likewise.
6322 (Fw32_toggle_lock_key): Likewise.
6323 * w32menu.c (add_menu_item): Likewise.
6324 (w32_menu_display_help): Use XIL instead of checking
6325 USE_LISP_UNION_TYPE.
6326 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
6327 (init_heap): Likewise.
6328 * w32term.c (w32_read_socket): Update comment.
6329
1d3823c9
GM
63302012-06-13 Glenn Morris <rgm@gnu.org>
6331
c62ff706
GM
6332 * s/usg5-4-common.h, src/s/unixware.h:
6333 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
6334
1d3823c9
GM
6335 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
6336
bfe3e0a2
PE
63372012-06-13 Paul Eggert <eggert@cs.ucla.edu>
6338
6339 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
6340 * alloc.c (make_number) [!defined make_number]:
6341 Remove, as lisp.h always defines this now.
6342 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
6343 (roundup_size): Verify that it is a power of 2.
6344 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
6345 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
6346 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
6347 -DUSE_LSB_TAG=0, to override the automatically-selected default.
6348 USE_LSB_TAG now is always defined to be either 0 or 1.
6349 All uses changed.
6350 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
6351 code works fine either way, and efficiency is not a concern here,
6352 as the union type is for debugging, not for production.
6353 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
6354 Use an inline function on all platforms when using the union type,
6355 since this is simpler and 'static inline' can be used portably
6356 within Emacs now.
6357 (LISP_INITIALLY_ZERO): New macro.
6358 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
6359 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
6360
45fa9c0f
GM
63612012-06-12 Glenn Morris <rgm@gnu.org>
6362
b4492cba
GM
6363 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
6364
6365 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 6366
45fa9c0f
GM
6367 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
6368 Move BROKEN_SIGIO to configure.
6369
6370 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
6371 Move NO_TERMIO to configure.
6372
0e25d334
CY
63732012-06-12 Chong Yidong <cyd@gnu.org>
6374
6375 * image.c (imagemagick_load_image): Use MagickFlattenImage if
6376 MagickMergeImageLayers is undefined. Use pixel pusher loop if
6377 MagickExportImagePixels is undefined.
6378
43682bb6
PE
63792012-06-12 Paul Eggert <eggert@cs.ucla.edu>
6380
6381 * image.c (imagemagick_load_image): Remove unused label.
6382
a9be7d2b
GM
63832012-06-11 Glenn Morris <rgm@gnu.org>
6384
6385 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
6386 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
6387 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
6388 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
6389
3017f87f
SM
63902012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
6391
6392 * alloc.c (make_byte_code): New function.
6393 (Fmake_byte_code): Use it. Don't purify here.
6394 * lread.c (read1): Use it as well to avoid extra allocation.
6395
1b9b4cf4
CY
63962012-06-11 Chong Yidong <cyd@gnu.org>
6397
6398 * image.c (imagemagick_load_image): Implement transparency.
6399
95988fcf
AS
64002012-06-10 Andreas Schwab <schwab@linux-m68k.org>
6401
6402 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
6403 account for preceding backslashes. (Bug#11663)
6404
cd4eb164
CY
64052012-06-09 Chong Yidong <cyd@gnu.org>
6406
6407 * term.c: Support italics in capable terminals (Bug#9652).
6408 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
6409 (turn_on_face): Output using TS_enter_italic_mode if available.
6410 Don't handle unused blinking and alt-charset cases.
6411 (turn_off_face): Handle italic case; discard unused tty_blinking_p
6412 and tty_alt_charset_p cases.
6413 (tty_capable_p, init_tty): Support italics.
6414
6415 * termchar.h (struct tty_display_info): Add field for italics.
6416 Remove unused blink field.
6417
6418 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
6419 Handle slant.
6420
6421 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
6422 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
6423 tty_alt_charset_p. Add tty_italic_p.
6424
ff88beb8
MA
64252012-06-09 Michael Albinus <michael.albinus@gmx.de>
6426
6427 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
6428 dbus_type_is_basic if available.
6429 (xd_extract_signed, xd_extract_unsigned): Rename from
6430 extract_signed and extract_unsigned, respectively. Adapt callers.
6431
44286096
CY
64322012-06-09 Chong Yidong <cyd@gnu.org>
6433
1682701f
CY
6434 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
6435
44286096
CY
6436 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
6437 case (Bug#9752).
6438
d86feb17
PE
64392012-06-08 Paul Eggert <eggert@cs.ucla.edu>
6440
6441 * xdisp.c (vmessage): Treat frame message as multibyte.
6442 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
6443 would generate the diagnostic "Making \302\247 buffer-local while
6444 let-bound!".
6445
d5c20fe8
EZ
64462012-06-08 Eli Zaretskii <eliz@gnu.org>
6447
6448 * dispnew.c (showing_window_margins_p): Undo last change, which
6449 was done due to an inadvertent commit.
6450 (adjust_frame_glyphs_for_frame_redisplay): Do call
6451 showing_window_margins_p.
6452
513749ee
SM
64532012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6454
6455 * eval.c (Fmake_var_non_special): New primitive.
6456 (syms_of_eval): Defsubr it.
6457 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
6458
d4a8f5c1
JB
64592012-06-08 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
6462 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
6463
8bbbc977
EZ
64642012-06-08 Eli Zaretskii <eliz@gnu.org>
6465
6466 * alloc.c (allocate_vectorlike): Fix last change.
6467
f3372c87
DA
64682012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
6469
6470 Block-based vector allocation of small vectors.
6471 * lisp.h (struct vectorlike_header): New field `nbytes',
6472 adjust comment accordingly.
6473 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
fc0c31f8 6474 to denote vector blocks. Adjust users (live_vector_p,
f3372c87
DA
6475 mark_maybe_pointer, valid_lisp_object_p) accordingly.
6476 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
6477 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
6478 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
6479 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
6480 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
6481 (roundup_size): New constant.
6482 (struct vector_block): New data type.
6483 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 6484 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
6485 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
6486 (sweep_vectors): New functions.
6487 (allocate_vectorlike): Return `zero_vector' as the only vector of
fc0c31f8 6488 0 items. Allocate new vector from block if vector size is less than
f3372c87
DA
6489 or equal to VBLOCK_BYTES_MAX.
6490 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
6491 (init_alloc_once): Add call to init_vectors.
6492
4f18a4ed
SM
64932012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
6494
6495 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
6496
86f158bc
PE
64972012-06-07 Paul Eggert <eggert@cs.ucla.edu>
6498
6499 * doprnt.c (doprnt): Truncate multibyte char correctly.
6500 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
6501 would mishandle a string argument "Xc" if X was a multibyte
6502 character of length 2: it would truncate after X's first byte
6503 rather than including all of X.
6504
c5cfcbe0
CY
65052012-06-06 Chong Yidong <cyd@gnu.org>
6506
6507 * buffer.c (word_wrap): Doc fix.
6508
c05cf390
PE
65092012-06-04 Paul Eggert <eggert@cs.ucla.edu>
6510
6511 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
6512
0c3461de
GM
65132012-06-03 Glenn Morris <rgm@gnu.org>
6514
6515 * xdisp.c (tool-bar-style): Doc fix.
6516
c71232db
UM
65172012-06-03 Ulrich Müller <ulm@gentoo.org>
6518
6519 * Makefile.in (PAXCTL): Define.
6520 (temacs$(EXEEXT)): Disable memory randomization for the temacs
6521 binary via PaX flags if the paxctl utility is available.
6522 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
6523 Restore PaX flags to their default. (Bug#11398)
6524
383f7350
CY
65252012-06-03 Chong Yidong <cyd@gnu.org>
6526
6527 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
6528 buffer (Bug#11226).
6529
5f2c76c6
CY
65302012-06-03 Chong Yidong <cyd@gnu.org>
6531
6532 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
6533 (note_mode_line_or_margin_highlight): If there is no help echo,
6534 use mode-line-default-help-echo. Handle the case where the mouse
6535 position is past the end of the mode line string.
6536
6537 * buffer.c (buffer_local_value_1): New function, split from
6538 Fbuffer_local_value; can return Qunbound.
6539 (Fbuffer_local_value): Use it.
6540 (Vmode_line_format): Docstring tweaks.
6541
773d47f6
PE
65422012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6543
6544 * sysdep.c (system_process_attributes): Improve comment.
6545
f2d6a3df
SM
65462012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
6547
6548 * keyboard.c: Export real-this-command to Elisp.
6549 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
6550 and DEFVAR it. Update all users.
6551
63810350
PE
65522012-06-02 Paul Eggert <eggert@cs.ucla.edu>
6553
7bd5c1f4
PE
6554 * minibuf.c (Fassoc_string): Remove duplicate declaration.
6555
63810350
PE
6556 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6557 Convert pctcpu and pctmem to Lisp float properly.
6558 Let the compiler fold better, as 100.0/0x8000 is exact.
6559
a2821611
AS
65602012-06-02 Andreas Schwab <schwab@linux-m68k.org>
6561
6562 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
6563 cons_block.
6564
5fceba1d
PE
65652012-06-01 Paul Eggert <eggert@cs.ucla.edu>
6566
6567 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
6568
c98ff5dd
DA
65692012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
6570
6571 For a 'struct window', replace some Lisp_Object fields to
6572 bitfields where appropriate, remove unused fields.
6573 * window.h (struct window): Remove unused 'last_mark_x' and
6574 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
6575 change it's type from Lisp_Object to bitfield.
6576 Change type of 'force_start', 'optional_new_start',
6577 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fc0c31f8 6578 fields from Lisp_Object to bitfield. Adjust users accordingly.
c98ff5dd 6579
ca34e0be
PE
65802012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 Pacify gcc -Wdouble-precision when using Xaw.
6583 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
6584 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
6585 Use 'float' consistently, rather than 'float' in most places
6586 and 'double' in a couple of places.
6587
efc00ab1 65882012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
6589
6590 * xdisp.c (handle_stop): Detect whether we have overlay strings
6591 loaded by testing it->current.overlay_string_index to be
6592 non-negative, instead of checking whether n_overlay_strings is
6593 positive. (Bug#11587)
6594
efc00ab1 65952012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
6596
6597 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
6598
6599 * doc.c (Fsubstitute_command_keys): Doc fix.
6600
efc00ab1 66012012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
6602
6603 * search.c (search_buffer): Remove calls to
6604 r_alloc_inhibit_buffer_relocation, as it is now called by
6605 maybe_unify_char, which was the cause of relocation of buffer text
6606 in bug#11519.
6607
efc00ab1 66082012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
6609
6610 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
6611 for the duration of call to load_charset, to avoid problems with
6612 callers of maybe_unify_char that access buffer text through C
6613 pointers.
6614
6615 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
6616 decrement the inhibition flag, instead of just setting or
6617 resetting it.
6618
ba93a187
PE
66192012-05-31 Paul Eggert <eggert@cs.ucla.edu>
6620
6621 Remove obsolete '#define static' cruft.
6622 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
6623 This #undef was "temporary" in 2000; it is no longer needed
6624 now that '#define static' has gone away.
6625 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
6626 (gray_bitmap_bits): Remove; no longer needed.
6627 All uses replaced with definiens.
6628 * xterm.c: Include "bitmaps/gray.xbm".
6629
9e4bf381
PE
66302012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6631
6632 Clean up __executable_start, monstartup when --enable-profiling.
6633 The following changes affect the code only when profiling.
6634 * dispnew.c (__executable_start): Rename from safe_bcopy.
6635 Define only on platforms that need it.
6636 * emacs.c: Include <sys/gmon.h> when profiling.
6637 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
6638 (__executable_start): Remove decl, since lisp.h does it now.
6639 (safe_bcopy): Remove decl; no longer has that name.
6640 (main): Coalesce #if into single bit of code, for simplicity.
6641 Cast pointers to uintptr_t, since standard libraries want integers
6642 and not pointers.
6643 * lisp.h (__executable_start): New decl.
6644
32d72c2f
GM
66452012-05-31 Glenn Morris <rgm@gnu.org>
6646
6647 * image.c (Fimagemagick_types): Doc fix.
6648
baac5bc7
JM
66492012-05-30 Jim Meyering <meyering@redhat.com>
6650
6651 * callproc.c (Fcall_process_region): Include directory component
6652 in mkstemp error message (Bug#11586).
6653
72cb32cf
PE
66542012-05-30 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 * alloc.c, lisp.h (make_pure_vector): Now static.
6657
61b108cc
SM
66582012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
6659
6660 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
6661 Move to byte-run.el.
6662 (Fautoload): Do the hash-doc more carefully.
6663 * data.c (Fdefalias): Purify definition, except for keymaps.
6664 (Qdefun): Move from eval.c.
6665 * lisp.h (Qdefun): Remove.
6666 * lread.c (read1): Tiny simplification.
6667
471fe23d
TN
66682012-05-29 Troels Nielsen <bn.troels@gmail.com>
6669
934f3f58 6670 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
6671 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
6672 Bug#9642, but explicitly check that the buffer the overlay would
6673 be moved to is live and rearrange lines to make sure that errors
6674 will not put the overlay in an inconsistent state.
6675 (Fdelete_overlay): Cosmetics.
6676
85d0efd1
EZ
66772012-05-28 Eli Zaretskii <eliz@gnu.org>
6678
6679 * w32term.c (my_bring_window_to_top): New function.
6680 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
6681 could be different from the original one.
6682 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
6683 (Bug#11513)
6684
6685 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
6686 by calling BringWindowToTop.
6687
6688 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
6689 (WM_EMACS_END): Increase by one.
6690
da92a98c
PE
66912012-05-28 Paul Eggert <eggert@cs.ucla.edu>
6692
6693 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
6694 This avoids undefined behavior that might cause the eassert
6695 to not catch an out-of-range value.
6696
74d1f848
JB
66972012-05-28 Juanma Barranquero <lekktu@gmail.com>
6698
6699 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
6700 Update dependencies.
6701
9e1a06fc
EZ
67022012-05-27 Eli Zaretskii <eliz@gnu.org>
6703
6704 * bidi.c (bidi_mirror_char): Fix last change.
6705
f3dd7312
AS
67062012-05-27 Andreas Schwab <schwab@linux-m68k.org>
6707
6708 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
6709 when referring to sectname field in printf format.
6710
81899c91
PE
67112012-05-27 Paul Eggert <eggert@cs.ucla.edu>
6712
57b81a9f
PE
6713 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
6714 Only r_alloc_inhibit_buffer_relocation needed to be added;
6715 the others were already declared.
6716
81899c91
PE
6717 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
6718 before checking whether it's out of range. Put the check inside
6719 eassert. See
6720 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
6721
33017faf 67222012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
6723
6724 * callproc.c (Fcall_process): Restore a line that was accidentally
6725 commented out in the 2011-02-13 change (bug#11547).
6726
33017faf 67272012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
6728
6729 * lisp.h [REL_ALLOC]: Add prototypes for external functions
6730 defined on ralloc.c.
6731
6732 * buffer.c [REL_ALLOC]: Remove prototypes of
6733 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
6734 they are now on lisp.h.
6735
6736 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
6737
6738 * search.c (search_buffer): Use it to inhibit relocation of buffer
6739 text while re_search_2 is doing its job, because re_search_2 is
6740 passed C pointers to buffer text. (Bug#11519)
6741
23415acf
EZ
6742 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
6743 Update value to 24.
6744
44e27368
EZ
6745 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
6746 state after an additional call to move_it_in_display_line_to, keep
6747 the values of it->max_ascent and it->max_descent found for the
6748 entire line.
6749 (pos_visible_p): Revert the comparison against bottom_y to what it
6750 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
6751 (Bug#11464)
6752
c1892f11
PE
67532012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 Fix coding-related core dumps with gcc -ftrapv.
6756 The code was computing A - B, where A and B are pointers, and B is
6757 random garbage. This can lead to core dumps on platforms that
6758 have special pointer registers, and it also leads to core dumps on
6759 x86-64 when compiled with gcc -ftrapv. The fix is to compute
6760 A - B only when B is initialized properly.
6761 * coding.c (coding_set_source, coding_set_destination): Return void.
6762 (coding_change_source, coding_change_destinations): New functions,
6763 with the old behaviors of coding_set_source and coding_set_destination.
6764 All callers that need an offset changed to use these new functions.
6765
eb7afdad
GM
67662012-05-26 Glenn Morris <rgm@gnu.org>
6767
6768 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
6769
f12fdf02
EZ
67702012-05-26 Eli Zaretskii <eliz@gnu.org>
6771
53a63be6 6772 Extend mouse support on W32 text-mode console.
61b108cc
SM
6773 * xdisp.c (draw_row_with_mouse_face):
6774 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 6775
eb3f6f01 6776 * w32console.c: Include window.h.
61b108cc
SM
6777 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
6778 New functions.
eb3f6f01
EZ
6779 (initialize_w32_display): Initialize mouse-highlight data.
6780
53a63be6
EZ
6781 * w32inevt.c: Include termchar.h and window.h.
6782 (do_mouse_event): Support mouse-autoselect-window. When the mouse
6783 moves, call note_mouse_highlight. If help_echo changed, call
6784 gen_help_event to produce help-echo message in the echo area.
6785 Call clear_mouse_face if mouse_face_hidden is set in the mouse
6786 highlight info.
6787
4cfd81f6
PE
67882012-05-26 Paul Eggert <eggert@cs.ucla.edu>
6789
6790 * lread.c (read1): Simplify slightly to avoid an overflow warning
6791 with GCC 4.7.0 on x86-64.
6792
4446092a
EZ
67932012-05-26 Eli Zaretskii <eliz@gnu.org>
6794
6795 * bidi.c (bidi_mirror_char): Revert last change: an int is
6796 definitely wide enough here.
6797
42b2a986 67982012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 6799
42b2a986 6800 Fix integer width and related bugs (Bug#9874).
eb106a49 6801 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
6802 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6803 (string_bytes, check_sblock, allocate_string_data):
6804 (compact_small_strings, Fmake_bool_vector, make_string)
6805 (make_unibyte_string, make_multibyte_string)
6806 (make_string_from_bytes, make_specified_string)
6807 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
6808 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
6809 (mark_vectorlike):
6810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6811 (allocate_pseudovector):
6812 Use int, not EMACS_INT, where int is wide enough.
6813 (inhibit_garbage_collection, Fgarbage_collect):
6814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6815 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
6816 int might not be wide enough.
6817 (bidi_cache_search, bidi_cache_find, bidi_init_it)
6818 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
6819 (bidi_at_paragraph_end, bidi_find_paragraph_start)
6820 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6821 (bidi_level_of_next_char, bidi_move_to_visually_next):
6822 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6823 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
6824 (Fkill_buffer, Fset_buffer_major_mode)
6825 (advance_to_char_boundary, Fbuffer_swap_text)
6826 (Fset_buffer_multibyte, overlays_at, overlays_in)
6827 (overlay_touches_p, struct sortvec, record_overlay_string)
6828 (overlay_strings, recenter_overlay_lists)
6829 (adjust_overlays_for_insert, adjust_overlays_for_delete)
6830 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
6831 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
6832 (Foverlay_recenter, last_overlay_modification_hooks_used)
6833 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
6834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
6835 (validate_region): Omit unnecessary test for b <= e,
6836 since that's guaranteed by the previous test.
d311d28c
PE
6837 (adjust_overlays_for_delete): Avoid pos + length overflow.
6838 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
6839 (report_overlay_modification):
6840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6841 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
6842 Omit pointer cast, which isn't needed anyway, and doesn't work
6843 after the EMACS_INT -> ptrdiff_t change.
02481186 6844 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
6845 * buffer.h: Adjust decls to match defn changes elsewhere.
6846 (struct buffer_text, struct buffer):
6847 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6848 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
6849 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
6850 not int, to avoid needless 32-bit limit on 64-bit hosts.
6851 (exec_byte_code): Use tighter memory-full test, one that checks
6852 for alloca overflow. Don't compute the address of the object just
6853 before an array, as that's not portable. Use EMACS_INT, not
6854 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
6855 * callint.c (Fcall_interactively):
6856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6857 * callproc.c (call_process_kill, Fcall_process):
6858 Don't assume pid_t fits into an Emacs fixnum.
6859 (call_process_cleanup, Fcall_process, child_setup):
6860 Don't assume pid_t fits into int.
6861 (call_process_cleanup, Fcall_process, delete_temp_file)
6862 (Fcall_process_region):
6863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6864 (Fcall_process): Simplify handling of volatile integers.
6865 Use int, not EMACS_INT, where int will do.
6866 * casefiddle.c (casify_object, casify_region, operate_on_word)
6867 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
6868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6869 (casify_object): Avoid integer overflow when overallocating buffer.
6870 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 6871 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
6872 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
6873 * category.h (CATEGORYP): Don't assume arg is nonnegative.
6874 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
6875 integers are now checked earlier. All uses replaced with XINT.
6876 (ccl_driver):
6877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6878 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
6879 (ccl_driver, Fregister_code_conversion_map):
6880 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
6881 (resolve_symbol_ccl_program): Check that vector header is in range.
6882 Always copy the vector, so that we can check its contents reliably
6883 now rather than having to recheck each instruction as it's being
6884 executed. Check that vector words fit in 'int'.
6885 (ccl_get_compiled_code, Fregister_ccl_program)
6886 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
6887 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
6888 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
6889 contents are in range.
6890 (Fccl_execute_on_string): Check that status is in range.
6891 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
6892 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
6893 Accept and return EMACS_INT, not int, because callers can pass values
6894 out of 'int' range.
6895 (c_string_width, strwidth, lisp_string_width, chars_in_text)
6896 (multibyte_chars_in_text, parse_str_as_multibyte)
6897 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
6898 (str_as_unibyte, str_to_unibyte, string_count_byte8)
6899 (string_escape_byte8, Fget_byte):
6900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 6901 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
6902 avoid mishandling large integers.
6903 * character.h: Adjust decls to match defn changes elsewhere.
6904 * charset.c (load_charset_map_from_file, find_charsets_in_text)
6905 (Ffind_charset_region):
6906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6907 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
6908 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 6909 Don't assume fixnum fits in int.
d311d28c
PE
6910 (load_charset_map_from_vector, Fmap_charset_chars):
6911 Remove now-unnecessary CHECK_NATNUMs.
6912 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
6913 Don't rely on undefined behavior with signed left shift overflow.
6914 Don't assume unsigned int fits into fixnum, or that fixnum fits
6915 into unsigned int. Don't require max_code to be a valid fixnum;
6916 that's not true for gb10830 4-byte on a 32-bit host. Allow
6917 invalid_code to be a cons, for the same reason. Require code_offset
6918 to be a character. Avoid int overflow if max_char is close
6919 to INT_MAX.
6920 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
6921 this is intended anyway and avoids some undefined behavior.
6922 (load_charset_map): Pass unsigned, not int, as 2nd arg of
6923 INDEX_TO_CODE_POINT, as that's what it expects.
6924 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
6925 * charset.h (DECODE_CHAR): Return int, not unsigned;
6926 this is what was intended anyway, and it avoids undefined behavior.
6927 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
6928 integer-overflow issues.
6929 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
6930 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
6931 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
6932 * chartab.c (Fmake_char_table, Fset_char_table_range)
6933 (uniprop_get_decoder, uniprop_get_encoder):
6934 Don't assume fixnum fits in int.
6935 * cmds.c (move_point): New function, that does the gist of
6936 Fforward_char and Fbackward_char, but does so while checking
6937 for integer overflow more accurately.
c96e5d6a 6938 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
6939 (Fforward_line, Fend_of_line, internal_self_insert)
6940 (internal_self_insert):
6941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6942 Fix a FIXME, by checking for integer overflow when calculating
6943 target_clm and actual_clm.
6944 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 6945 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
6946 (ASSURE_DESTINATION, coding_alloc_by_realloc)
6947 (coding_alloc_by_making_gap, alloc_destination)
6948 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
6949 (encode_coding_utf_16, detect_coding_emacs_mule)
6950 (decode_coding_emacs_mule, encode_coding_emacs_mule)
6951 (detect_coding_iso_2022, decode_coding_iso_2022)
6952 (encode_invocation_designation, encode_designation_at_bol)
6953 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6954 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
6955 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
6956 (encode_coding_ccl, encode_coding_raw_text)
6957 (detect_coding_charset, decode_coding_charset)
6958 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
6959 (produce_composition, produce_charset, produce_annotation)
6960 (decode_coding, handle_composition_annotation)
6961 (handle_charset_annotation, consume_chars, decode_coding_gap)
6962 (decode_coding_object, encode_coding_object, detect_coding_system)
6963 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
6964 (code_convert_region, code_convert_string)
8f50130c
PE
6965 (Fdefine_coding_system_internal)
6966 (coding_set_source, coding_set_destination):
d311d28c
PE
6967 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6968 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
6969 (Fdefine_coding_system_internal):
6970 Don't assume fixnums fit in int.
6971 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 6972 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
6973 (Funencodable_char_position, Fcheck_coding_systems_region)
6974 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 6975 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 6976 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 6977 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 6978 Don't access memory outside of the args array.
d311d28c 6979 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
6980 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
6981 result of ENCODE_CHAR.
d311d28c
PE
6982 * coding.h: Adjust decls to match defn changes elsewhere.
6983 (struct coding_system):
6984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6985 * composite.c (get_composition_id, find_composition)
6986 (run_composition_function, update_compositions)
6987 (compose_text, composition_gstring_put_cache)
6988 (composition_gstring_p, composition_gstring_width)
6989 (fill_gstring_header, fill_gstring_body, autocmp_chars)
6990 (composition_compute_stop_pos, composition_reseat_it)
6991 (composition_update_it, struct position_record)
6992 (find_automatic_composition, composition_adjust_point)
6993 (Fcomposition_get_gstring, Ffind_composition_internal):
6994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
6995 (update_compositions):
6996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
6997 * composite.h: Adjust decls to match defn changes elsewhere.
6998 (struct composition):
6999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7000 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
7001 Do not attempt to compute the address of the object just before a
7002 buffer; this is not portable.
7003 (Faref, Faset):
7004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7005 (Faset): Use int, not EMACS_INT, where int is wide enough.
7006 (Fstring_to_number): Don't assume fixnums fit in int.
7007 (Frem): Don't assume arg is nonnegative.
7008 * dbusbind.c (xd_append_arg): Check for integers out of range.
7009 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 7010 (extract_signed, extract_unsigned): New functions.
243e0530
PE
7011 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
7012 (xd_get_connection_references): Return ptrdiff_t, not int.
7013 All uses changed.
7014 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
7015 (xd_read_message_1):
7016 Use int, not unsigned, where the dbus API uses int.
7017 (Fdbus_message_internal): Don't overflow mtype.
7018 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
7019 * dired.c (directory_files_internal, file_name_completion, scmp)
7020 (file_name_completion_stat):
7021 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7022 (file_name_completion): Don't overflow matchcount.
7023 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
7024 * dispextern.h: Adjust decls to match defn changes elsewhere.
7025 (struct text_pos, struct glyph, struct bidi_saved_info)
7026 (struct bidi_string_data, struct bidi_it, struct composition_it)
7027 (struct it):
7028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7029 (struct display_pos, struct composition_it, struct it):
7030 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7031 * dispnew.c (increment_matrix_positions)
7032 (increment_row_positions, mode_line_string)
7033 (marginal_area_string):
7034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 7035 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
7036 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7037 (duration_to_sec_usec): New function, to check for overflow better.
7038 (Fsleep_for, sit_for): Use it.
7039 * doc.c (get_doc_string, store_function_docstring):
7040 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7041 (get_doc_string, Fsnarf_documentation):
7042 Use int, not EMACS_INT, where int is wide enough.
7043 (get_doc_string):
7044 Use SAFE_ALLOCA, not alloca.
7045 Check for overflow when converting EMACS_INT to off_t.
7046 * doprnt.c (doprnt):
7047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7048 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
7049 Don't assume uid_t fits into fixnum.
7050 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
7051 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
7052 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
7053 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
7054 (general_insert_function)
7055 (Finsert_char, make_buffer_string, make_buffer_string_both)
7056 (update_buffer_properties, Fbuffer_substring)
7057 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
7058 (Fsubst_char_in_region, check_translation)
7059 (Ftranslate_region_internal, save_restriction_restore, Fformat)
7060 (transpose_markers, Ftranspose_regions):
7061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7062 (clip_to_bounds): Move to lisp.h as an inline function).
7063 (Fconstrain_to_field): Don't assume integers are nonnegative.
7064 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
7065 (Fsubst_char_in_region, Fsave_restriction):
7066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7067 (Femacs_pid): Don't assume pid_t fits into fixnum.
7068 (lo_time): Use int, not EMACS_INT, when int suffices.
7069 (lisp_time_argument): Check for usec out of range.
7070 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
7071 (Fuser_login_name, Fuser_full_name): Signal an error
7072 if a uid argument is out of range, rather than relying on
7073 undefined behavior.
c8d5c857
PE
7074 (Fformat_time_string): Remove now-unnecessary check.
7075 lisp_time_argument checks for out-of-range usec now.
243e0530 7076 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
7077 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
7078 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
7079 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
7080 (init_cmdargs, Fdump_emacs):
7081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7082 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
7083 the bottom (typically) 32 bits of the fixnum.
7084 * eval.c (specpdl_size, call_debugger):
7085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7086 (when_entered_debugger, Fbacktrace_debug):
7087 Don't assume fixnum can fit in int.
7088 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
7089 the object just before a buffer; this is not portable.
7090 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
7091 (grow_specpdl, unbind_to):
7092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7093 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
7094 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 7095 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
7096 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
7097 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
7098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7099 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
7100 (a_write, e_write):
7101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7102 (Fcopy_file, non_regular_nbytes, read_non_regular)
7103 (Finsert_file_contents):
7104 Use int, not EMACS_INT, where int is wide enough.
7105 (READ_BUF_SIZE): Verify that it fits in int.
7106 (Finsert_file_contents): Check that counts are in proper range,
7107 rather than assuming fixnums fit into ptrdiff_t etc.
7108 Don't assume fixnums fit into int.
125b3835 7109 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
7110 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
7111 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
7112 (string_char_to_byte, string_byte_to_char)
7113 (string_make_multibyte, string_to_multibyte)
7114 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
7115 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
7116 (substring_both, Fdelete, internal_equal, Ffillarray)
7117 (Fclear_string, mapcar1)
7118 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
7119 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
7120 (larger_vector, make_hash_table, maybe_resize_hash_table)
7121 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
7122 (Fmaphash, secure_hash):
7123 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7124 (concat): Check for string index and length overflow.
7125 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
7126 (Frequire):
7127 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7128 (larger_vector): New API (vec, incr_min, size_max) replaces old
7129 one (vec, new_size, init). This catches size overflow.
7130 INIT was removed because it was always Qnil.
7131 All callers changed.
7132 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
7133 the upper bound on a hash table index size.
7134 (make_hash_table, maybe_resize_hash_table): Use it.
7135 (secure_hash): Computer start_byte and end_byte only after
7136 they're known to be in ptrdiff_t range.
7137 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
7138 (Ffont_get_glyphs, Ffont_at):
7139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7140 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
7141 (Flist_fonts, Fopen_font):
7142 Don't assume fixnum can fit in int.
7143 (check_gstring): Don't assume index can fit in int.
7144 (font_match_p): Check that fixnum is a character, not a nonnegative
7145 fixnum, since the later code needs to stuff it into an int.
7146 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
7147 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
7148 conversion overflow issues.
7149 (Fopen_font): Check for integer out of range.
7150 (Ffont_get_glyphs): Don't assume index can fit in int.
7151 * font.h: Adjust decls to match defn changes elsewhere.
7152 * fontset.c (reorder_font_vector): Redo score calculation to avoid
7153 integer overflow.
7154 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
7155 printmax_t, where ptrdiff_t is wide enough.
7156 (Finternal_char_font):
7157 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7158 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
7159 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
7160 (Fset_frame_position, x_set_frame_parameters)
7161 (x_set_line_spacing, x_set_border_width)
7162 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
7163 Check that fixnums are in proper range for system types.
7164 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
7165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7166 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
7167 Use SAFE_ALLOCA_LISP, not alloca.
7168 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
7169 intptr_t is wide enough.
7170 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
7171 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
7172 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
7173 Check for fixnum out of range.
7174 * ftfont.c (ftfont_list): Don't assume index fits in int.
7175 Check that fixnums are in proper range for system types.
7176 (ftfont_shape_by_flt):
7177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
7178 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7180 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
7181 Check that fixnums are in proper range for system types.
7182 * gnutls.h: Adjust decls to match defn changes elsewhere.
7183 * gtkutil.c (xg_dialog_run):
7184 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7185 (update_frame_tool_bar):
7186 Check that fixnums are in proper range for system types.
7187 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 7188 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
7189 * indent.c (last_known_column, last_known_column_point):
7190 (current_column_bol_cache):
7191 (skip_invisible, current_column, check_display_width):
7192 (check_display_width, scan_for_column, current_column_1)
7193 (Findent_to, Fcurrent_indentation, position_indentation)
7194 (indented_beyond_p, Fmove_to_column, compute_motion):
7195 (Fcompute_motion, Fvertical_motion):
7196 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7197 (last_known_column_modified): Use EMACS_INT, not int.
7198 (check_display_width):
7199 (Fcompute_motion):
7200 Check that fixnums and floats are in proper range for system types.
7201 (compute_motion): Don't assume index or fixnum fits in int.
7202 (compute_motion, Fcompute_motion):
7203 Use int, not EMACS_INT, when it is wide enough.
7204 (vmotion): Omit local var start_hpos that is always 0; that way
7205 we don't need to worry about overflow in expressions involving it.
7206 * indent.h: Adjust decls to match defn changes elsewhere.
7207 (struct position):
7208 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7209 Use int, not EMACS_INT, where int is wide enough.
7210 Remove unused members ovstring_chars_done and tab_offset;
7211 all uses removed.
7212 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
7213 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
7214 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
7215 (make_gap, copy_text, insert, insert_and_inherit)
7216 (insert_before_markers, insert_before_markers_and_inherit)
7217 (insert_1, count_combining_before, count_combining_after)
7218 (insert_1_both, insert_from_string)
7219 (insert_from_string_before_markers, insert_from_string_1)
7220 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
7221 (adjust_after_replace, adjust_after_insert, replace_range)
7222 (replace_range_2, del_range, del_range_1, del_range_byte)
7223 (del_range_both, del_range_2, modify_region)
7224 (prepare_to_modify_buffer, signal_before_change)
7225 (signal_after_change, Fcombine_after_change_execute):
7226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7227 * intervals.c (traverse_intervals, rotate_right, rotate_left)
7228 (balance_an_interval, split_interval_right, split_interval_left)
7229 (find_interval, next_interval, update_interval)
7230 (adjust_intervals_for_insertion, delete_node, delete_interval)
7231 (interval_deletion_adjustment, adjust_intervals_for_deletion)
7232 (static_offset_intervals, offset_intervals)
7233 (merge_interval_right, merge_interval_left, make_new_interval)
7234 (graft_intervals_into_buffer, temp_set_point_both)
7235 (temp_set_point, set_point, adjust_for_invis_intang)
7236 (set_point_both, move_if_not_intangible, get_property_and_range)
7237 (get_local_map, copy_intervals, copy_intervals_to_string)
7238 (compare_string_intervals, set_intervals_multibyte_1):
7239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7240 * intervals.h: Adjust decls to match defn changes elsewhere.
7241 (struct interval):
7242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7243 * keyboard.c (this_command_key_count, this_single_command_key_start)
7244 (before_command_key_count, before_command_echo_length, echo_now)
7245 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
7246 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
7247 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
7248 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
7249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7250 (last_non_minibuf_size, last_point_position, echo_truncate)
7251 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
7252 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
7253 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
7254 (stuff_buffered_input):
7255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7256 (last_auto_save, command_loop_1, read_char):
7257 Use EMACS_INT, not int, to avoid integer overflow.
7258 (record_char): Avoid overflow in total_keys computation.
7259 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
7260 * keyboard.h: Adjust decls to match defn changes elsewhere.
7261 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
7262 (Fkey_description, Fdescribe_vector, Flookup_key):
7263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7264 (click_position): New function, to check that positions are in range.
7265 (Fcurrent_active_maps):
7266 (describe_command):
7267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7268 (Faccessible_keymaps, Fkey_description):
7269 (preferred_sequence_p):
7270 Don't assume fixnum can fit into int.
7271 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
7272 Check for integer overflow in size calculations.
7273 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
7274 avoid mishandling large integers.
7275 * lisp.h: Adjust decls to match defn changes elsewhere.
7276 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
7277 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
7278 (struct Lisp_Marker):
7279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7280 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
7281 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
7282 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
7283 All callers changed.
7284 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
7285 Assume the arg has valid form, since it always does.
7286 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
7287 unsigned integer system type.
7288 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
7289 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
7290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7291 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
7292 (duration_to_sec_usec): New decl.
7293 * lread.c (read_from_string_index, read_from_string_index_byte)
7294 (read_from_string_limit, readchar, unreadchar, openp)
7295 (read_internal_start, read1, oblookup):
7296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7297 (Fload, readevalloop, Feval_buffer, Feval_region):
7298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7299 (openp): Check for out-of-range argument to 'access'.
7300 (read1): Use int, not EMACS_INT, where int is wide enough.
7301 Don't assume fixnum fits into int.
6efdadfd 7302 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
7303 (read_filtered_event): Use duration_to_sec_usec
7304 to do proper overflow checking on durations.
d311d28c
PE
7305 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
7306 in size calculation.
7307 (Fexecute_kbd_macro):
7308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7309 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
7310 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
7311 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
7312 (set_marker_both, set_marker_restricted_both, marker_position)
7313 (marker_byte_position, Fbuffer_has_markers_at):
7314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7315 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 7316 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
7317 It now merely ensures that the menu is large enough, without
7318 necessarily growing it, as this avoids some integer overflow issues.
7319 All callers changed.
7320 (keymap_panes, parse_single_submenu, Fx_popup_menu):
7321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7322 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
7323 Use SAFE_ALLOCA_LISP, not alloca.
7324 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
7325 to EMACS_INT. Check that fixnums are in proper range for system types.
7326 * minibuf.c (minibuf_prompt_width, string_to_object)
7327 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
7328 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
7329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7330 (get_minibuffer, read_minibuf_unwind):
7331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7332 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
7333 this simplifies overflow checking. All callers changed.
7334 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
7335 (Ftest_completion):
7336 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7337 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
7338 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
7339 Check that fixnums are in proper range for system types.
7340 (Fx_create_frame, Fx_show_tip):
7341 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7342 * nsfont.m (ns_findfonts, nsfont_list_family):
7343 Don't assume fixnum fits in long.
7344 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
7345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7346 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
7347 wide enough.
17fdb222 7348 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
7349 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7350 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
7351 (PRINTDECLARE, PRINTPREPARE):
7352 (strout, print_string):
7353 (print, print_preprocess, print_check_string_charset_prop)
7354 (print_object):
7355 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7356 (PRINTDECLARE):
7357 (temp_output_buffer_setup, Fprin1_to_string, print_object):
7358 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7359 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 7360 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 7361 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
7362 (print_error_message): Use SAFE_ALLOCA, not alloca.
7363 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
7364 (print_depth, new_backquote_output, print_number_index):
7365 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
7366 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
7367 (Fset_process_window_size, Fformat_network_address)
7368 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 7369 (sigchld_handler):
d311d28c 7370 Check that fixnums are in proper range for system types.
d44287d4 7371 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
7372 Check for process-ids out of pid_t range rather than relying on
7373 undefined behavior.
e4d81efc 7374 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
7375 (Fformat_network_address, read_process_output, send_process)
7376 (Fprocess_send_region, status_notify):
7377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7378 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
7379 (wait_reading_process_output, read_process_output, exec_sentinel):
7380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7381 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
7382 (Faccept_process_output): Use duration_to_sec_usec to do proper
7383 overflow checking on durations.
dde14581
PE
7384 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
7385 Don't assume pid_t fits in int.
02481186
PE
7386 * process.h (struct Lisp_Process): Members tick and update_tick
7387 are now of type EMACS_INT, not int.
b62b53e8
PE
7388 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
7389 configured --with-wide-int.
d311d28c
PE
7390 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
7391 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
7392 * search.c (looking_at_1, string_match_1):
7393 (fast_string_match, fast_c_string_match_ignore_case)
7394 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
7395 (scan_newline, find_before_next_newline, search_command)
7396 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
7397 (set_search_regs, wordify):
7398 (Freplace_match):
7399 (Fmatch_data):
7400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7401 (string_match_1, search_buffer, set_search_regs):
7402 (Fmatch_data):
7403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7404 (wordify): Check for overflow in size calculation.
7405 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
7406 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
7407 Check that fixnums are in proper range for system types.
7408 * sound.c (struct sound_device)
7409 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
7410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7411 (Fplay_sound_internal):
7412 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 7413 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
7414 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
7415 (Fparse_partial_sexp):
7416 Don't assume fixnums can fit in int.
7417 (struct lisp_parse_state, find_start_pos, find_start_value)
7418 (find_start_value_byte, find_start_begv)
7419 (update_syntax_table, char_quoted, dec_bytepos)
7420 (find_defun_start, prev_char_comend_first, back_comment):
7421 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
7422 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
7423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7424 (Finternal_describe_syntax_value): Check that match_lisp is a
7425 character, not an integer, since the code stuffs it into int.
7426 (scan_words, scan_sexps_forward):
7427 Check that fixnums are in proper range for system types.
7428 (Fforward_word):
7429 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7430 (scan_sexps_forward):
7431 Use CHARACTERP, not INTEGERP, since the value must fit into int.
7432 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
7433 * syntax.h: Adjust decls to match defn changes elsewhere.
7434 (struct gl_state_s):
7435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
7436 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
7437 MOST_POSITIVE_FIXNUM.
d311d28c
PE
7438 * sysdep.c (wait_for_termination_1, wait_for_termination)
7439 (interruptible_wait_for_termination, mkdir):
7440 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
7441 (emacs_read, emacs_write):
7442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
7443 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
7444 and double all fit in int.
d311d28c
PE
7445 * term.c (set_tty_color_mode):
7446 Check that fixnums are in proper range for system types.
7447 * termhooks.h (struct input_event):
7448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7449 * textprop.c (validate_interval_range, interval_of)
7450 (Fadd_text_properties, set_text_properties_1)
7451 (Fremove_text_properties, Fremove_list_of_text_properties)
7452 (Ftext_property_any, Ftext_property_not_all)
7453 (copy_text_properties, text_property_list, extend_property_ranges)
7454 (verify_interval_modification):
7455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7456 (Fnext_single_char_property_change)
7457 (Fprevious_single_char_property_change):
7458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
7459 (copy_text_properties):
7460 Check for integer overflow in index calculation.
d311d28c
PE
7461 * undo.c (last_boundary_position, record_point, record_insert)
7462 (record_delete, record_marker_adjustment, record_change)
7463 (record_property_change):
7464 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7465 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
7466 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7467 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7468 (Fx_hide_tip, Fx_file_dialog):
7469 * w32menu.c (set_frame_menubar):
7470 Use ptrdiff_t, not int, for consistency with rest of code.
7471 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
7472 (select_window, Fdelete_other_windows_internal)
7473 (window_scroll_pixel_based, window_scroll_line_based)
7474 (Frecenter, Fset_window_configuration):
7475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7476 (Fset_window_hscroll, run_window_configuration_change_hook)
7477 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 7478 (Fscroll_other_window, Frecenter):
d311d28c
PE
7479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7480 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
7481 Don't assume fixnum fits in int.
7482 (Fset_window_scroll_bars):
7483 Check that fixnums are in proper range for system types.
7484 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
7485 (string_pos, c_string_pos, number_of_chars, init_iterator)
7486 (in_ellipses_for_invisible_text_p, init_from_display_pos)
7487 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
7488 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
7489 (face_before_or_after_it_pos, handle_invisible_prop)
7490 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
7491 (display_prop_intangible_p, string_buffer_position_lim)
7492 (string_buffer_position, handle_composition_prop, load_overlay_strings)
7493 (get_overlay_strings_1, get_overlay_strings)
7494 (iterate_out_of_display_property, forward_to_next_line_start)
7495 (back_to_previous_visible_line_start, reseat, reseat_to_string)
7496 (get_next_display_element, set_iterator_to_next)
7497 (get_visually_first_element, compute_stop_pos_backwards)
7498 (handle_stop_backwards, next_element_from_buffer)
7499 (move_it_in_display_line_to, move_it_in_display_line)
7500 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7501 (add_to_log, message_dolog, message_log_check_duplicate)
7502 (message2, message2_nolog, message3, message3_nolog
7503 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
7504 (current_message_1, truncate_echo_area, truncate_message_1)
7505 (set_message, set_message_1, store_mode_line_noprop)
7506 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
7507 (text_outside_line_unchanged_p, check_point_in_composition)
7508 (reconsider_clip_changes)
7509 (redisplay_internal, set_cursor_from_row, try_scrolling)
7510 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
7511 (redisplay_window, find_last_unchanged_at_beg_row)
7512 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
7513 (trailing_whitespace_p, find_row_edges, display_line)
7514 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
7515 (display_mode_element, store_mode_line_string)
7516 (pint2str, pint2hrstr, decode_mode_spec)
7517 (display_count_lines, display_string, draw_glyphs)
7518 (x_produce_glyphs, x_insert_glyphs)
7519 (rows_from_pos_range, mouse_face_from_buffer_pos)
7520 (fast_find_string_pos, mouse_face_from_string_pos)
7521 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7522 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7523 (safe_call, init_from_display_pos, handle_fontified_prop)
7524 (handle_single_display_spec, load_overlay_strings)
7525 (with_echo_area_buffer, setup_echo_area_for_printing)
7526 (display_echo_area, echo_area_display)
7527 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
7528 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
7529 (redisplay_window, dump_glyph_row, display_mode_line)
7530 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 7531 (handle_display_spec, display_prop_string_p):
d311d28c
PE
7532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7533 (handle_single_display_spec, build_desired_tool_bar_string)
7534 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
7535 (get_specified_cursor_type):
7536 Check that fixnums are in proper range for system types.
7537 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
7538 (Flookup_image_map):
7539 Don't assume fixnums fit in int.
7540 (compare_overlay_entries):
7541 Avoid mishandling comparisons due to subtraction overflow.
7542 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
7543 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
7544 (handle_tool_bar_click):
7545 Use int, not unsigned, since we prefer signed and the signedness
7546 doesn't matter here.
7547 (get_next_display_element, next_element_from_display_vector):
7548 Use int, not EMACS_INT, when int is wide enough.
7549 (start_hourglass): Use duration_to_sec_usec to do proper
7550 overflow checking on durations.
7551 * xfaces.c (Fbitmap_spec_p):
7552 Check that fixnums are in proper range for system types.
7553 (compare_fonts_by_sort_order):
7554 Avoid mishandling comparisons due to subtraction overflow.
7555 (Fx_family_fonts, realize_basic_faces):
7556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7557 (Fx_family_fonts):
7558 Don't assume fixnum fits in int.
7559 Use SAFE_ALLOCA_LISP, not alloca.
7560 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
7561 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
7562 (face_at_buffer_position, face_for_overlay_string)
7563 (face_at_string_position):
7564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7565 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
7566 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
7567 (Fx_show_tip):
7568 Check that fixnums are in proper range for system types.
7569 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
7570 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
7571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7572 (Fx_change_window_property): Don't assume fixnums fit in int.
7573 * xfont.c (xfont_chars_supported):
7574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7575 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
7576 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
7577 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7578 * xml.c (parse_region):
7579 * xrdb.c (magic_file_p):
7580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
7581 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
7582 (x_get_local_selection, x_reply_selection_request)
7583 (x_handle_selection_request, wait_for_property_change):
7584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7585 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
7586 short is wide enough.
7587 (x_send_client_event): Don't assume fixnum fits in int.
7588 * xterm.c (x_x_to_emacs_modifiers):
7589 Don't assume EMACS_INT overflows nicely into int.
7590 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
7591 may come from Lisp.
7592 (handle_one_xevent): NATNUMP can eval its arg twice.
7593 (x_connection_closed):
7594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
7595 * xterm.h: Adjust decls to match defn changes elsewhere.
7596 (struct scroll_bar): Use struct vectorlike_header
7597 rather than rolling our own approximation.
7598 (SCROLL_BAR_VEC_SIZE): Remove; not used.
7599
c6574eb5
GM
76002012-05-25 Glenn Morris <rgm@gnu.org>
7601
7602 * lisp.mk (lisp): Update for more files being compiled now.
7603
e8d32c7e
SM
76042012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
7605
48def666
SM
7606 * lread.c: Remove `read_pure' which makes no difference.
7607 (read_pure): Remove var.
7608 (unreadpure): Remove function.
7609 (readevalloop): Don't call read_list with -1 flag.
7610 (read1, read_vector): Don't test read_pure any more.
7611 (read_list): Simplify.
7612
e8d32c7e
SM
7613 * fileio.c, character.h: Minor style tweaks.
7614
4b2addb7
DA
76152012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
7616
7617 * window.h (clip_changed): Remove useless declaration.
7618
584461b2
JB
76192012-05-22 Juanma Barranquero <lekktu@gmail.com>
7620
7621 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
7622 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
7623
34374650
PE
76242012-05-22 Paul Eggert <eggert@cs.ucla.edu>
7625
7626 Remove src/m/*.
7627 This directory predates autoconf and is no longer needed nowadays.
7628 Move its few remaining bits of functionality to where they're needed.
7629 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
7630 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
7631 * m/template.h: Remove.
7632 * Makefile.in (M_FILE): Remove. All uses removed.
7633 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
7634 * lisp.h (USE_LSB_TAG):
7635 * mem-limits.h (EXCEEDS_LISP_PTR):
7636 Use VAL_MAX, not VALBITS, in #if.
7637 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
7638 (EMACS_UINT): Define unconditionally now.
7639 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
7640 (BITS_PER_EMACS_INT): New constants, replacing
7641 what used to be in config.h, but not useful in #if.
7642 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
7643 define them any more.
7644 (VAL_MAX): New macro.
7645 (VALMASK): Use it.
7646 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
7647 BITS_PER_EMACS_INT, in #if.
7648 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
7649 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
7650 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
7651 * s/ms-w32.h (DATA_START):
7652 Move here from removed file m/intel386.h.
7653 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
7654 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
7655
261cb4bb
PE
76562012-05-21 Paul Eggert <eggert@cs.ucla.edu>
7657
7658 Assume C89 or later.
7659 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
7660 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
7661 (xrealloc):
7662 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
7663 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
7664 * textprop.c, tparam.c (NULL): Remove.
7665 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
7666 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
7667 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
7668 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
7669 * xterm.c (input_signal_count): Assume volatile works.
7670
ff23cd9f
KB
76712012-05-21 Ken Brown <kbrown@cornell.edu>
7672
7673 * xgselect.c (xg_select): Fix first argument in call to 'select'
7674 (bug#11508).
7675
1b170bc6
KB
76762012-05-20 Ken Brown <kbrown@cornell.edu>
7677
7678 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 7679 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 7680
b2f4d39f
KB
76812012-05-19 Ken Brown <kbrown@cornell.edu>
7682
7683 * xfns.c (x_in_use): Remove `static' qualifier.
7684 * xterm.h (x_in_use): Declare.
7685 * xgselect.c: Include xterm.h.
7686 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
7687 and `display_arg' (bug#9754).
7688
003fdae2
PE
76892012-05-19 Paul Eggert <eggert@cs.ucla.edu>
7690
9232a6d9
PE
7691 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
7692
003fdae2
PE
7693 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
7694 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
7695
784b56e2
EZ
76962012-05-18 Eli Zaretskii <eliz@gnu.org>
7697
7698 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
7699
7700 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 7701 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
7702
7703 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
7704 reference to image_cache->refcount.
7705 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
7706
a0a79cde
JL
77072012-05-17 Juri Linkov <juri@jurta.org>
7708
7709 * search.c (Fword_search_regexp, Fword_search_backward)
7710 (Fword_search_forward, Fword_search_backward_lax)
7711 (Fword_search_forward_lax): Move functions to isearch.el
7712 (bug#10145, bug#11381).
7713
b0572523
PE
77142012-05-16 Paul Eggert <eggert@cs.ucla.edu>
7715
7716 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
7717
9660f5fc
SM
77182012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
7719
7720 * lread.c (init_obarray): Declare Qt and Qnil as special.
7721
4374de83
GM
77222012-05-14 Glenn Morris <rgm@gnu.org>
7723
7724 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 7725 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 7726
dc44c39a
PE
77272012-05-14 Paul Eggert <eggert@cs.ucla.edu>
7728
078c97cb
PE
7729 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
7730
dc44c39a
PE
7731 * unexaix.c: Port to more-recent AIX compilers.
7732 (report_error, report_error_1, make_hdr, copy_sym)
7733 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
7734 Make arguments const char *, not char *, to avoid violations of C
7735 standard and to fix some AIX warnings reported by Gilles Pion.
7736
e18afed7 77372012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
7738
7739 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
7740 already have overlays loaded.
7741 (handle_single_display_spec): Before returning without displaying
7742 fringe bitmap, synchronize the bidi iterator with the main display
7743 iterator, by calling iterate_out_of_display_property.
7744 (iterate_out_of_display_property): Detect buffer iteration by
7745 testing that it->string is a Lisp string.
7746 (get_next_display_element): When the current object is exhausted,
7747 and there's something on it->stack, call set_iterator_to_next to
7748 proceed with what's on the stack, instead of returning zero.
7749 (set_iterator_to_next): If called at the end of a Lisp string,
7750 proceed to consider_string_end without incrementing string
7751 position. Don't increment display vector index past the end of
7752 the display vector. (Bug#11417)
c8fb9dc6
EZ
7753 (pos_visible_p): Don't report a position visible when move_it_to
7754 stopped at the last line of window, which happens to be scanned
7755 backwards by the bidi iteration. (Bug#11464)
ac268e67 7756
e18afed7 77572012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
7758
7759 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
7760 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
7761 are on a TTY, and thus unable to display on the fringes.
7762 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
7763 so we need to signal to the caller that this is a "replacing"
7764 display spec. This fixes display when the spec is invalid or we
7765 are on a TTY.
7766
e18afed7 77672012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
7768
7769 * unexaix.c (make_hdr): Fix typo in prototype.
7770 This bug broke the build on AIX. Problem reported by Gilles Pion.
7771
9d0a235a
MA
77722012-05-14 Michael Albinus <michael.albinus@gmx.de>
7773
7774 * keyboard.c (kbd_buffer_get_event): Read special events also in
7775 batch mode. (Bug#11415)
7776
9e6b06ed
GM
77772012-05-12 Glenn Morris <rgm@gnu.org>
7778
7779 * ns.mk: Update for ns_appbindir no longer having trailing "/".
7780
c1a1d7a3
EZ
77812012-05-12 Eli Zaretskii <eliz@gnu.org>
7782
7783 * lisp.mk (lisp): Add newcomment.elc.
7784
3fe7cdc8
GM
77852012-05-12 Glenn Morris <rgm@gnu.org>
7786
7787 * Makefile.in (MKDIR_P): New, set by configure.
7788 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
7789
53f7d2c0
PE
77902012-05-11 Paul Eggert <eggert@cs.ucla.edu>
7791
7792 Remove unused function hourglass_started.
7793 * dispextern.h (hourglass_started):
7794 * w32fns.c (hourglass_started):
7795 * xdisp.c (hourglass_started): Remove.
7796
75aafb17
JB
77972012-05-10 Juanma Barranquero <lekktu@gmail.com>
7798
7799 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
7800 Update dependencies.
7801
12959e8e
PE
78022012-05-10 Paul Eggert <eggert@cs.ucla.edu>
7803
97107e2e
PE
7804 * xgselect.c (xg_select): Put maxfds+1 into a var.
7805 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
7806
12959e8e
PE
7807 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
7808
836d29b3
DA
78092012-05-10 Dave Abrahams <dave@boostpro.com>
7810
7811 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
7812 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
7813
5cb67954
MA
78142012-05-09 Michael Albinus <michael.albinus@gmx.de>
7815
7816 * dbusbind.c (xd_registered_buses): New internal Lisp object.
7817 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
7818 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
7819 Initialize xd_registered_buses.
7820
3478ec45
PE
78212012-05-09 Paul Eggert <eggert@cs.ucla.edu>
7822
b263a6b0
PE
7823 Untag more efficiently if USE_LSB_TAG.
7824 This is based on a proposal by YAMAMOTO Mitsuharu in
7825 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
7826 For an admittedly artificial (nth 8000 longlist) benchmark on
7827 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
7828 Emacs's overall text size by 1%.
7829 * lisp.h (XUNTAG): New macro.
7830 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
7831 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
7832 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
7833 * eval.c (Fautoload):
7834 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
7835 * frame.h (XFRAME): Use XUNTAG.
7836
3478ec45
PE
7837 Port recent dbusbind.c changes to 32-bit --with-wide-int.
7838 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
7839 Remove unportable assumptions about print widths of types like
7840 dbus_uint32_t.
7841 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
7842 intptr_t when converting between pointer and integer, to avoid GCC
7843 warnings about wrong width.
7844
666b903b 78452012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
7846
7847 * w32proc.c (new_child): Force Windows to reserve only 64KB of
7848 stack for each reader_thread, instead of defaulting to 8MB
7849 determined by the linker. This avoids failures in creating
7850 subprocesses on Windows 7, see the discussion in this thread:
7851 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
7852
b120cc17
JC
78532012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
7854
7855 Fix up display of the *Minibuf-0* buffer in the mini window.
7856 * keyboard.c (read_char): Don't clear the echo area if there's no
7857 message to clear.
7858 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 7859 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 7860
9a4b36f8
MA
78612012-05-07 Michael Albinus <michael.albinus@gmx.de>
7862
7863 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
7864 batch mode.
7865
e5f9458f
CY
78662012-05-06 Chong Yidong <cyd@gnu.org>
7867
7868 * lisp.mk (lisp): Update.
7869
eceeb5fc 78702012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
7871
7872 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
7873
71873e2b
SM
78742012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
7875
7876 * data.c (PUT_ERROR): New macro.
7877 (syms_of_data): Use it. Add new error type `user-error'.
7878 * undo.c (user_error): New function.
7879 (Fprimitive_undo): Use it.
7880 * print.c (print_error_message): Adjust print style for `user-error'.
7881 * keyboard.c (user_error): New function.
7882 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
7883
ab0fa4e4
PE
78842012-05-03 Paul Eggert <eggert@cs.ucla.edu>
7885
7886 Do not limit current-time-string to years 1000..9999.
7887 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
7888 (Fcurrent_time_string): Support any year that is supported by the
7889 underlying localtime representation. Don't use asctime, as it
7890 has undefined behavior for years outside the range -999..9999.
7891
7ed806a7
PE
78922012-05-02 Paul Eggert <eggert@cs.ucla.edu>
7893
7894 Fix race conditions involving setenv, gmtime, localtime, asctime.
7895 Without this fix, interrupts could mess up code that uses these
7896 nonreentrant functions, since setting TZ invalidates existing
7897 tm_zone or tzname values, and since most of these functions return
7898 pointers to static storage.
7899 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
7900 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
7901 Grow the critical sections to include not just invoking
7902 localtime/gmtime, but also accessing these functions' results
7903 including their tm_zone values if any, and any related TZ setting.
7904 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
7905 so that the struct tm is saved in the critical section.
7906 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
7907 motivated by the fact that memory allocation needs to be outside
7908 the critical section.
7909
0c16dfed
DA
79102012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
7911
7912 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
7913 with RESET_INTERVAL.
7914
7915 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7916 Remove duplicated buffer name initialization.
7917
3f83ace8
JM
79182012-05-02 Jim Meyering <jim@meyering.net>
7919
7920 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
7921
c7b8541e
JM
7922 * xfns.c (x_window): Use xstrdup (Bug#11375).
7923
90207a15 79242012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
7925
7926 * xdisp.c (pos_visible_p): If already at a newline from the
7927 display string before the 'while' loop, don't walk back the glyphs
7928 from it3.glyph_row. Solves assertion violation when the display
7929 string begins with a newline (egg.el). (Bug#11367)
7930
b593d6a9
AH
79312012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
7932
7933 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
7934 Move to simple.el.
7935
4737362e
GM
79362012-05-01 Glenn Morris <rgm@gnu.org>
7937
99cf43f9
GM
7938 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
7939 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
7940 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
7941 All were removed before 23.1.
7942
9311dcff
GM
7943 * dispnew.c: Remove HAVE_LIBNCURSES test;
7944 it is always true on relevant platforms.
7945
4d5c6349
GM
7946 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
7947 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
7948
4737362e
GM
7949 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
7950
74dd3a6b
AS
79512012-04-30 Andreas Schwab <schwab@linux-m68k.org>
7952
7953 * .gdbinit (xpr): Remove checks for no longer existing misc types.
7954 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
7955 Remove.
7956
13c379ee
PE
79572012-04-28 Paul Eggert <eggert@cs.ucla.edu>
7958
7959 Do not avoid creating empty evaporating overlays (Bug#9642).
7960 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
7961 That is, do not delete an evaporating overlay if it becomes
7962 empty after its bounds are adjusted to fit within its buffer.
7963 This fix caused other problems, and I'm reverting it until we get
7964 to the bottom of them.
7965
a8e7d6d7 79662012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
7967
7968 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
7969
a8e7d6d7 79702012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
7971
7972 * xdisp.c (pos_visible_p): If the window start position is beyond
7973 ZV, start the display from buffer beginning. Prevents assertion
7974 violation in init_iterator when the minibuffer window is scrolled
7975 via the scroll bar.
7976
7977 * window.c (window_scroll_pixel_based): Likewise.
7978
a8e7d6d7 79792012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
7980
7981 * keymap.c (where_is_internal): Doc fix (Bug#10872).
7982
a8e7d6d7 79832012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
7984
7985 * fileio.c (Fcopy_file, Fset_file_selinux_context):
7986 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
7987
a8e7d6d7 79882012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 7989
b593d6a9
AH
7990 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
7991 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 7992
1c6900d9
EZ
79932012-04-26 Eli Zaretskii <eliz@gnu.org>
7994
4c3fa1d9
EZ
7995 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
7996 display element, check also the underlying string or buffer
7997 character. (Bug#11341)
7998
1c6900d9
EZ
7999 * w32menu.c: Include w32heap.h.
8000 (add_menu_item): If the call to AppendMenuW (via
8001 unicode_append_menu) fails, disable Unicode menus only if we are
8002 running on Windows 9X/Me.
8003
42bf8205
AS
80042012-04-24 Andreas Schwab <schwab@linux-m68k.org>
8005
8006 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
8007 (xgetint): Add missing shift for LSB tags.
8008
b1bac16e
MR
80092012-04-24 Martin Rudalics <rudalics@gmx.at>
8010
8011 * keyboard.c (read_char): Don't wipe echo area for select window
8012 events: These might get delayed via `mouse-autoselect-window'
8013 (Bug#11304).
8014
d69621cc
JB
80152012-04-24 Juanma Barranquero <lekktu@gmail.com>
8016
8017 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
8018 manipulation of :loaded-from data.
8019
02fd101b
JB
80202012-04-23 Juanma Barranquero <lekktu@gmail.com>
8021
8022 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
8023 now a cons (bug#11311).
8024
888bec30
PE
80252012-04-23 Paul Eggert <eggert@cs.ucla.edu>
8026
89a438bd
PE
8027 Do not create empty overlays with the evaporate property (Bug#9642).
8028 * buffer.c (Fmove_overlay): Delete an evaporating overlay
8029 if it becomes empty after its bounds are adjusted to fit within
8030 its buffer. Without this fix, in a nonempty buffer (let ((o
8031 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
8032 yields an empty overlay that has the evaporate property, which is
8033 not supposed to happen.
8034
1068fe4d
PE
8035 Fix minor GTK3 problems found by static checking.
8036 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8037 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8038 (struct _EmacsFixedClass, emacs_fixed_get_type):
8039 Move decls here from emacsgtkfixed.h, since they needn't be public.
8040 (emacs_fixed_get_type): Now static.
8041 (emacs_fixed_class_init): Omit unused local.
8042 (emacs_fixed_child_type): Remove; unused.
8043 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
8044 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
8045 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
8046 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
8047 (EMACS_FIXED_GET_CLASS): Remove; unused.
8048 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
8049
888bec30
PE
8050 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
8051 Problem reported by Juanma Barranquero for Windows -Wunused-function.
8052
de85e130
PE
80532012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8054
d0baac98 8055 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 8056 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
8057 (__malloc_size_t, __malloc_ptrdiff_t):
8058 Remove. All uses removed, replaced by the definiens if needed,
8059 since we can assume C89 or better now.
8060 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
8061 (protect_malloc_state, align, get_contiguous_space)
8062 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
8063 (malloc_atfork_handler_child, malloc_enable_thread)
8064 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
8065 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
8066 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
8067 (special_realloc, _realloc_internal_nolock, _realloc_internal)
8068 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
8069 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
8070 Define using prototypes, not old style.
8071 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
8072 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
8073 (align): Don't assume that signed integer overflow wraps around.
8074 Omit unused local var.
8075 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
8076 (_free_internal_nolock, memalign, mallochook, reallochook):
8077 Omit no-longer-needed casts.
8078 (valloc): Use getpagesize, not __getpagesize.
8079 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
8080 (struct hdr): The 'magic' member is now size_t, not unsigned long.
8081
de85e130
PE
8082 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
8083
dcbf5805
MA
80842012-04-22 Michael Albinus <michael.albinus@gmx.de>
8085
8086 Move functions from C to Lisp. Make non-blocking method calls
8087 the default. Implement further D-Bus standard interfaces.
8088
8089 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
8090 (QCdbus_request_name_allow_replacement)
8091 (QCdbus_request_name_replace_existing)
8092 (QCdbus_request_name_do_not_queue)
8093 (QCdbus_request_name_reply_primary_owner)
8094 (QCdbus_request_name_reply_in_queue)
8095 (QCdbus_request_name_reply_exists)
8096 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
8097 (QCdbus_registered_serial, QCdbus_registered_method)
8098 (QCdbus_registered_signal): New Lisp objects.
8099 (XD_DEBUG_MESSAGE): Use sizeof.
8100 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
8101 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
8102 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
8103 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
8104 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
8105 (xd_signature, xd_append_arg): Allow float for integer types.
8106 (xd_get_connection_references): New function.
b593d6a9
AH
8107 (xd_get_connection_address): Rename from xd_initialize.
8108 Return cached address.
dcbf5805
MA
8109 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
8110 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
8111 level.
8112 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 8113 Return number of refcounts.
dcbf5805
MA
8114 (Fdbus_get_unique_name): Make stronger parameter check.
8115 (Fdbus_message_internal): New defun.
8116 (Fdbus_call_method, Fdbus_call_method_asynchronously)
8117 (Fdbus_method_return_internal, Fdbus_method_error_internal)
8118 (Fdbus_send_signal, Fdbus_register_service)
8119 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
8120 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
8121 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
8122 (Vdbus_compiled_version, Vdbus_runtime_version)
8123 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
8124 (Vdbus_message_type_method_return, Vdbus_message_type_error)
8125 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
8126 (Vdbus_registered_buses, Vdbus_registered_objects_table):
8127 Adapt docstring.
dcbf5805 8128
52828e02
PE
81292012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8130
da05bc4c
PE
8131 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
8132 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
8133 Do not assume ptrdiff_t is the same width as 'int'.
8134
52828e02
PE
8135 * alloc.c: Handle unusual debugging option combinations.
8136 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
8137 since the two debugging options are incompatible.
8138 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
8139 is defined.
8140 (mem_init, mem_insert, mem_insert_fixup):
8141 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
8142 (NEED_MEM_INSERT): Remove; no longer needed.
8143
f01769f9
LL
81442012-04-22 Leo Liu <sdl.web@gmail.com>
8145
8146 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
8147
5790543d
PE
81482012-04-22 Paul Eggert <eggert@cs.ucla.edu>
8149
8150 * sysdep.c [__FreeBSD__]: Minor cleanups.
8151 (list_system_processes, system_process_attributes) [__FreeBSD__]:
8152 Use Emacs indenting style more consistently. Avoid some casts.
8153 Use 'double' consistently rather than mixing 'float' and 'double'.
8154
b91b7e4d
EW
81552012-04-21 Eduard Wiebe <usenet@pusto.de>
8156
b593d6a9
AH
8157 * sysdep.c (list_system_processes, system_process_attributes):
8158 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 8159
6114eb15
AS
81602012-04-21 Andreas Schwab <schwab@linux-m68k.org>
8161
8162 * lisp.mk (lisp): Update.
8163
2f38dff7
PE
81642012-04-20 Paul Eggert <eggert@cs.ucla.edu>
8165
8166 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
8167 It is never used otherwise.
8168
4ae29f89
SM
81692012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
8170
8171 * print.c (print_preprocess): Only check print_depth if print-circle
8172 is nil.
8173 (print_object): Check for cycles even when print-circle is nil and
8174 print-gensym is t, but only check print_depth if print-circle is nil.
8175
f30d612a
CY
81762012-04-20 Chong Yidong <cyd@gnu.org>
8177
8178 * process.c (wait_reading_process_output): If EIO occurs on a pty,
8179 set the status to "failed" and ensure that sentinel is run.
8180
c07a4c0b 81812012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
8182
8183 * process.c (Fset_process_inherit_coding_system_flag)
8184 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 8185 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 8186
c07a4c0b 81872012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
8188
8189 * xdisp.c (string_buffer_position_lim): Limit starting position to
8190 BEGV.
8191 (set_cursor_from_row): If called for a mode-line or header-line
8192 row, return zero immediately.
8193 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
8194 farther than the first row after the header line, if any.
8195 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
8196 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
8197
c07a4c0b 81982012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8199
4ae29f89
SM
8200 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
8201 (bug#11238).
ad3a2b41 8202
c07a4c0b 82032012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 82042012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
8205
8206 configure: new option --enable-gcc-warnings (Bug#11207)
8207 * Makefile.in (C_WARNINGS_SWITCH): Remove.
8208 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
8209 (ALL_CFLAGS): Use new macros rather than old.
8210 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
8211 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
8212 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
8213 -Wunused-result, -Wunused-variable. This should go away once
8214 the Emacs and Gnulib regex code is merged.
8215 (xmalloc, xrealloc): Now static.
8216
aba027e8
PE
82172012-04-17 Paul Eggert <eggert@cs.ucla.edu>
8218
8219 * dired.c (Fsystem_groups): Remove unused local.
8220
e5a36063
GM
82212012-04-17 Glenn Morris <rgm@gnu.org>
8222
8223 * dired.c (Fsystem_users): Doc fix.
8224
316411f0
DA
82252012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
8226
8227 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
8228 (syms_of_dired): Add them.
8229
9426aba4
PE
82302012-04-16 Paul Eggert <eggert@cs.ucla.edu>
8231
b62a57be
PE
8232 Fix minor alloc.c problems found by static checking.
8233 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
8234 New extern decls, to avoid calling undeclared functions.
8235 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
8236 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
8237 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
8238 (NEED_MEM_INSERT): New macro.
8239 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 8240 Remove one incorrect comment and fix another.
b62a57be 8241
3539f31f
PE
8242 Fix minor ralloc.c problems found by static checking.
8243 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8244 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
8245 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
8246 (r_alloc_sbrk): Now static.
8247
a041960a
PE
8248 Improve ralloc.c interface checking.
8249 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
8250 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
8251 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
8252 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
8253 [REL_ALLOC]: ... to here, to check interface.
8254 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
8255 Remove decls. This fixes an "It stinks!".
8256
9426aba4
PE
8257 * alloc.c (which_symbols): Fix alignment issue / type clash.
8258
d55c12ed
AS
82592012-04-15 Andreas Schwab <schwab@linux-m68k.org>
8260
8261 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
8262 (struct Lisp_Misc_Any): Likewise.
8263 (struct Lisp_Free): Likewise.
8264 * alloc.c (union aligned_Lisp_Symbol): Define.
8265 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
8266 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
8267 (union aligned_Lisp_Misc): Define.
8268 (MARKER_BLOCK_SIZE, struct marker_block): Use union
8269 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 8270 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 8271
b948ce8b
PE
82722012-04-14 Paul Eggert <eggert@cs.ucla.edu>
8273
8274 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
8275 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
8276 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
8277 * s/netbsd.h, s/sol2-6.h:
8278 Remove definition of GC_MARK_STACK, since the default now works.
8279 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
8280 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
8281 no longer the default.
8282 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
8283
35dc09a1 82842012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 8285
35dc09a1
GM
8286 * lread.c (lisp_file_lexically_bound_p):
8287 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 8288
35dc09a1
GM
82892012-04-14 Eli Zaretskii <eliz@gnu.org>
8290
8291 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
8292 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
8293
82942012-04-14 Jan Djärv <jan.h.d@swipnet.se>
8295
8296 * nsterm.m (constrainFrameRect): Always constrain when there is only
8297 one screen (Bug#10962).
8298
bcd86815
KB
82992012-04-13 Ken Brown <kbrown@cornell.edu>
8300
8301 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
8302
c25df26e
RT
83032012-04-13 Reuben Thomas <rrt@sc3d.org>
8304
8305 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
8306
0fc59f1e
DC
83072012-04-11 Daniel Colascione <dancol@dancol.org>
8308
8309 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8310 against is gone. It's better to use vfork now so that when Cygwin
8311 gains a new, working vfork, we use it automatically (bug#10398).
8312
de8c03dc
SM
83132012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8314
8315 * window.c (save_window_save): Obey window-point-insertion-type.
8316
2f097256
GM
83172012-04-11 Glenn Morris <rgm@gnu.org>
8318
8319 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
8320
453b951e
SM
83212012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
8322
8323 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
8324
75f1671a 83252012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
8326
8327 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
8328 (force_quit_count): New var.
8329 (handle_interrupt): Use it.
8330
2a8ce227
JB
83312012-04-10 Juanma Barranquero <lekktu@gmail.com>
8332
8333 * w32.c (w32_delayed_load): Record the full path of the library
8334 being loaded (bug#10424).
8335
935396c0
GM
83362012-04-09 Glenn Morris <rgm@gnu.org>
8337
05920a43
GM
8338 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
8339 not just in the obarray, before snarfing them. (Bug#11036)
8340
935396c0
GM
8341 * Makefile.in ($(leimdir)/leim-list.el):
8342 Pass EMACS rather than BUILT_EMACS.
8343
a18ecafa
TZ
83442012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
8345
8346 * process.c (make_process):
8347 * process.h: Add integer `gnutls_handshakes_tried' member to
8348 process struct.
8349
6bbef4e5
JC
8350 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
8351 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
8352
8353 * gnutls.c (gnutls_log_function2i): Convenience log function.
8354 (emacs_gnutls_read): Use new log functions,
8355 `gnutls_handshakes_tried' process member, and
8356 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
8357 attempts per process (connection).
8358
b4d3bc10
CY
83592012-04-09 Chong Yidong <cyd@gnu.org>
8360
8361 * eval.c (Fuser_variable_p, user_variable_p_eh)
8362 (lisp_indirect_variable): Functions deleted.
8363 (Fdefvar): Caller changed.
8364
8365 * callint.c (Finteractive, Fcall_interactively):
8366 * minibuf.c (Fread_variable): Callers changed.
8367
70f4d973
EZ
83682012-04-09 Eli Zaretskii <eliz@gnu.org>
8369
8370 * xdisp.c (set_cursor_from_row): If the display string appears in
8371 the buffer at position that is closer to point than the position
8372 after the display string, display the cursor on the first glyph of
8373 the display string. Fixes cursor display when a 'display' text
8374 property immediately follows invisible text. (Bug#11094)
8375
cb3c2e3e
PE
83762012-04-09 Paul Eggert <eggert@cs.ucla.edu>
8377
8378 composite.c: use 'double' consistently
8379 * composite.c (get_composition_id): Use 'double' consistently
8380 instead of converting 'float' to 'double' and vice versa; this is
8381 easier to understand and avoids a GCC warning.
8382
fd06db5d
GM
83832012-04-09 Glenn Morris <rgm@gnu.org>
8384
50fe702a
GM
8385 * Makefile.in: Generate leim-list with bootstrap-emacs, in
8386 preparation for dumping it with emacs. (Bug#4789)
8387 (leimdir): New variable.
8388 ($(leimdir)/leim-list.el): New rule.
8389 (emacs$(EXEEXT)): Depend on leim-list.el.
8390
fd06db5d
GM
8391 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
8392 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
8393 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
8394
55c131ee
AS
83952012-04-08 Andreas Schwab <schwab@linux-m68k.org>
8396
8397 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
8398 proper alignment.
8399
9209588f
JB
84002012-04-07 Juanma Barranquero <lekktu@gmail.com>
8401
8402 * xml.c (init_libxml2_functions) [WINDOWSNT]:
8403 Remove unused local variable.
8404
e3fb2efb
PE
84052012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8406
8407 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
8408 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
8409 (mark_memory): Mark Lisp_Objects only if pointers might hide in
8410 objects, as mark_maybe_pointer will catch them otherwise.
8411 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
8412 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
8413
b5385551
PE
84142012-04-07 Paul Eggert <eggert@cs.ucla.edu>
8415
8416 Fix typo that broke non-Windows builds.
8417 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
8418
9078ead6
EZ
84192012-04-07 Eli Zaretskii <eliz@gnu.org>
8420
8421 Support building on MS-Windows with libxml2.
8422
8423 * makefile.w32-in (OBJ2): Add xml.$(O).
8424 (GLOBAL_SOURCES): Add xml.c.
8425 ($(BLD)/xml.$(O)): New dependency list.
8426
8427 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
8428 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
8429 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
8430 [!WINDOWSNT]: New macros.
8431 (init_libxml2_functions, libxml2_loaded_p): New functions.
8432 (parse_region): Call fn_xmlCheckVersion instead of using the macro
8433 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
8434 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
8435 Calls xmlCleanupParser only if libxml2 was loaded (or statically
8436 linked in).
6bbef4e5
JC
8437 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
8438 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
8439 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
8440
8441 * emacs.c: Don't include libxml/parser.h.
8442 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
8443 xmlCleanupParser directly.
8444
8445 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
8446
3811fdf3
EZ
84472012-04-07 Eli Zaretskii <eliz@gnu.org>
8448
8449 * indent.c (Fvertical_motion): If there is a display string at
8450 point, use it.vpos to compute how many lines to backtrack after
8451 move_it_to point. (Bug#11133)
8452
2f8e16b2
EZ
84532012-04-06 Eli Zaretskii <eliz@gnu.org>
8454
8455 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
8456 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
8457 about subtle differences between FETCH_CHAR* and STRING_CHAR*
8458 macros related to unification of CJK characters. For the details,
8459 see the discussion following the message here:
8460 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
8461
3d439cd1
CY
84622012-04-04 Chong Yidong <cyd@gnu.org>
8463
8464 * keyboard.c (Vdelayed_warnings_list): Doc fix.
8465
8bc53d00
EZ
84662012-04-01 Eli Zaretskii <eliz@gnu.org>
8467
8468 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
8469 instead of alloca. (Bug#11138)
8470
3b0512a3
AS
84712012-04-01 Andreas Schwab <schwab@linux-m68k.org>
8472
8473 * w32menu.c (is_simple_dialog): Properly check lisp types.
8474 (Bug#11141)
8475
8427ddd2
EZ
84762012-03-31 Eli Zaretskii <eliz@gnu.org>
8477
979022ef
EZ
8478 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
8479 position we get to after a call to move_it_to fails the
8480 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
8481 only if we wind up in a string from display property. (Bug#11063)
8482
a6b1c7cc
EZ
8483 * window.c (Fdelete_other_windows_internal): Invalidate the row
8484 and column information about mouse highlight, so that redisplay
8485 restores it after reallocating the glyph matrices. (Bug#7464)
8486
8427ddd2
EZ
8487 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
8488 string comes from a `display' text property, use the buffer
8489 position of that property as if we actually saw that position in
8490 the row's glyphs.
697ba24b
EZ
8491 (move_it_by_lines): Remove the assertion that
8492 "it->current_x == 0 && it->hpos == 0" which can be legitimately
8493 violated when there's a before-string at the beginning of a line.
8494 (Bug#11063)
8427ddd2 8495
65a0a738
EZ
84962012-03-30 Eli Zaretskii <eliz@gnu.org>
8497
8498 * xdisp.c (append_space_for_newline): If the default face was
8499 remapped, use the remapped face for the appended newline.
8500 (extend_face_to_end_of_line): Use the remapped default face for
8501 extending the face to the end of the line.
8502 (display_line): Call extend_face_to_end_of_line when the default
8503 face was remapped. (Bug#11068)
8504
581355cc
EZ
85052012-03-29 Eli Zaretskii <eliz@gnu.org>
8506
8507 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
8508
e8fc049f
SM
85092012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8510
8511 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
8512
4fb9a543
GM
85132012-03-27 Glenn Morris <rgm@gnu.org>
8514
8515 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
8516 Doc fixes.
8517
679910f1
KH
85182012-03-26 Kenichi Handa <handa@m17n.org>
8519
8520 * dispextern.h (struct glyph): Fix previous change. Change the
8521 bit length of glyphless.ch to 25 (Bug#11082).
8522
90d49b7f
CY
85232012-03-26 Chong Yidong <cyd@gnu.org>
8524
8525 * keyboard.c (Vselection_inhibit_update_commands): New variable.
8526 (command_loop_1): Use it; inhibit selection update for
8527 handle-select-window too (Bug#8996).
8528
f514f6f0
FP
85292012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
8530
e8fc049f 8531 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 8532
bf43fa51
KH
85332012-03-25 Kenichi Handa <handa@m17n.org>
8534
8535 * dispextern.h (struct glyph): Change the bit length of
8536 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
8537
8a0c01dd
EZ
85382012-03-24 Eli Zaretskii <eliz@gnu.org>
8539
8540 * s/ms-w32.h (tzname): Include time.h before redirecting to
8541 _tzname. Fixes the MSVC build. (Bug#9960)
8542
7d1c3a76
AS
85432012-03-24 Andreas Schwab <schwab@linux-m68k.org>
8544
8ed79523
AS
8545 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
8546 characters.
8547
7d1c3a76
AS
8548 * xterm.c (XTread_socket): Only modify handling_signal if
8549 !SYNC_INPUT. (Bug#11080)
8550
e99a9b8b
EZ
85512012-03-23 Eli Zaretskii <eliz@gnu.org>
8552
8553 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
8554 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
8555 when fetching a multibyte character consumes more bytes than
8556 CHAR_BYTES returns, due to unification of CJK characters in
8557 string_char. (Bug#11073)
8558
5063c0e1
TN
85592012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
8560
8561 * process.c (wait_reading_process_output): Handle pty disconnect
8562 by refraining from sending oneself a SIGCHLD (bug#10933).
8563
9f851fbd
CY
85642012-03-22 Chong Yidong <cyd@gnu.org>
8565
8566 * dispextern.h (struct it): New member string_from_prefix_prop_p.
8567
5063c0e1 8568 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
8569 Mark string as coming from a prefix property.
8570 (handle_face_prop): Use default face for prefix strings (Bug#4281).
8571 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
8572
fb5b8aca
CY
85732012-03-21 Chong Yidong <cyd@gnu.org>
8574
8575 * xfaces.c (Vface_remapping_alist): Doc fix.
8576
62356a1b
EZ
85772012-03-20 Eli Zaretskii <eliz@gnu.org>
8578
8579 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
8580 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
8581 Doc fixes.
62356a1b 8582
025de85b
CY
85832012-03-20 Chong Yidong <cyd@gnu.org>
8584
8585 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
8586 to reflect default non-nil value of redisplay-dont-pause.
8587
4827f94e
KH
85882012-03-19 Kenichi Handa <handa@m17n.org>
8589
8590 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
8591 it fit in a valid range (Bug#11003).
8592
e50a24a2
EZ
85932012-03-18 Eli Zaretskii <eliz@gnu.org>
8594
8595 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
8596 that is not from display property, accept the row as a "cursor
8597 row" if one of the string's character has a non-nil `cursor'
8598 property. Fixes cursor positioning when there are newlines in
8599 overlay strings, e.g. in icomplete.el. (Bug#11035)
8600
9af5ed87
PE
86012012-03-12 Paul Eggert <eggert@cs.ucla.edu>
8602
8603 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
8604
d1f55f16
CY
86052012-03-12 Chong Yidong <cyd@gnu.org>
8606
8607 * eval.c (inhibit_lisp_code): Rename from
8608 inhibit_window_configuration_change_hook; move from window.c.
8609
8610 * xfns.c (unwind_create_frame_1, Fx_create_frame):
8611 * window.c (run_window_configuration_change_hook)
8612 (syms_of_window): Callers changed.
8613
66c5eebd
CY
86142012-03-11 Chong Yidong <cyd@gnu.org>
8615
413df973
CY
8616 * keymap.c (Fkey_description): Doc fix (Bug#9700).
8617
66c5eebd
CY
8618 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
8619
1de11f56
CY
86202012-03-10 Chong Yidong <cyd@gnu.org>
8621
8622 * frame.c (other_visible_frames): Don't assume the selected frame
8623 is visible (Bug#10955).
8624
cae07000
SM
86252012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
8626
8627 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
8628
89c94350
JD
86292012-03-08 Jan Djärv <jan.h.d@swipnet.se>
8630
8631 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
8632 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
8633 zero (Bug#10954).
8634
999dd333
GM
86352012-03-03 Glenn Morris <rgm@gnu.org>
8636
01a6dcc8 8637 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 8638
de0100f2
EZ
86392012-03-02 Eli Zaretskii <eliz@gnu.org>
8640
8641 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
8642 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
8643 (redisplay_window, next_element_from_string): Fix typos in
8644 comments.
3e441275
EZ
8645 (redisplay_window): Pass to move_it_vertically the margin in
8646 pixels, not in screen lines.
de0100f2 8647
96a72ee9
GM
86482012-03-02 Glenn Morris <rgm@gnu.org>
8649
8650 * buffer.c (buffer-list-update-hook): Doc fix.
8651
312508d7
EZ
86522012-02-29 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
8655 push_it before setting up the iterator for the first overlay
8656 string, even if we have an empty string loaded.
8657 (next_overlay_string): If there's an empty string on the iterator
8658 stack, pop the stack. (Bug#10903)
8659
27f3c637
PE
86602012-02-25 Paul Eggert <eggert@cs.ucla.edu>
8661
8662 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
8663 Suggested by Stefan Monnier in
8664 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
8665 * alloc.c (widen_to_Lisp_Object): New static function.
8666 (mark_memory): Also mark Lisp_Objects by fetching pointer words
8667 and widening them to Lisp_Objects. This would work even if
8668 USE_LSB_TAG is defined and wide integers are used, which might
8669 happen in a future version of Emacs.
8670
3c9dfce6
CY
86712012-02-25 Chong Yidong <cyd@gnu.org>
8672
fa74b241
CY
8673 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
8674 Doc fix.
8675
3c9dfce6
CY
8676 * xselect.c (Fx_selection_exists_p): Doc fix.
8677 (x_clipboard_manager_save_all): Print an informative message
8678 before saving to clipboard manager.
8679
9486df08
CY
86802012-02-24 Chong Yidong <cyd@gnu.org>
8681
8682 * keyboard.c (process_special_events): Handle all X selection
8683 requests in kbd_buffer, not just the next one (Bug#8869).
8684
f01d3321
CY
86852012-02-23 Chong Yidong <cyd@gnu.org>
8686
8687 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
8688 call when setting menu-bar-lines and tool-bar-lines parameters.
8689 (unwind_create_frame_1): New helper function.
8690
8691 * window.c (inhibit_window_configuration_change_hook): New var.
8692 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 8693 (syms_of_window): Initialize it.
f01d3321 8694
86b847b6
CY
86952012-02-22 Chong Yidong <cyd@gnu.org>
8696
8697 * xterm.c (x_draw_image_relief): Add missing type check for
8698 Vtool_bar_button_margin (Bug#10743).
8699
a59225b1
CY
87002012-02-21 Chong Yidong <cyd@gnu.org>
8701
8702 * fileio.c (Vfile_name_handler_alist): Doc fix.
8703
8704 * buffer.c (Fget_file_buffer): Protect against invalid file
8705 handler return value.
8706
310f5bd4
PE
87072012-02-20 Paul Eggert <eggert@cs.ucla.edu>
8708
cb3a28cc
PE
8709 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
8710 when computing $valmask.
8711
310f5bd4
PE
8712 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
8713 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
8714 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
8715 It's useless in that case, and it can cause problems on hosts
8716 that allocate halves of EMACS_INT values separately.
8717 Reported by Dan Horák. Diagnosed by Andreas Schwab in
8718 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
8719 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
8720 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
8721 it avoids undefined behavior on hosts where shifting right by more
8722 than the word width has undefined behavior.
8723
2375c96a
CY
87242012-02-19 Chong Yidong <cyd@gnu.org>
8725
8726 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
8727 (Funhandled_file_name_directory, Ffile_name_as_directory)
8728 (Fdirectory_file_name, Fexpand_file_name)
8729 (Fsubstitute_in_file_name): Protect against invalid file handler
8730 return values (Bug#10845).
8731
3eb49e71
EZ
87322012-02-18 Eli Zaretskii <eliz@gnu.org>
8733
8734 * .gdbinit (pitx): Fix incorrect references to fields of the
8735 iterator stack.
8736
7b926f3f
CY
87372012-02-17 Chong Yidong <cyd@gnu.org>
8738
8739 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
8740
11273115
PE
87412012-02-15 Paul Eggert <eggert@cs.ucla.edu>
8742
8743 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
8744 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
8745
c3a70e2b
CY
87462012-02-15 Chong Yidong <cyd@gnu.org>
8747
8748 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
8749 marked as special. Also, starting docstrings with * is obsolete.
8750
0ca43699
AS
87512012-02-13 Andreas Schwab <schwab@linux-m68k.org>
8752
8753 * gnutls.c (emacs_gnutls_write): Fix last change.
8754
2e8f3c56
LI
87552012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
8756
8757 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
8758 send_process.
8759
af70074f
SM
87602012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
8761
8762 * keymap.c (Fsingle_key_description): Handle char ranges.
8763
95986d52
CY
87642012-02-12 Chong Yidong <cyd@gnu.org>
8765
afd83bd1
CY
8766 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
8767 as that creates a dangerous corner case.
8768
95986d52
CY
8769 * window.c (Fdelete_window_internal): Invalidate the mouse
8770 highlight (Bug#9904).
8771
bd7da63e
GM
87722012-02-12 Glenn Morris <rgm@gnu.org>
8773
8774 * xselect.c (Fx_own_selection_internal)
8775 (Fx_get_selection_internal, Fx_disown_selection_internal)
8776 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
8777 * nsselect.m (Fx_own_selection_internal)
8778 (Fx_disown_selection_internal, Fx_selection_exists_p)
8779 (Fx_selection_owner_p, Fx_get_selection_internal):
8780 Sync docs and argument specs with the xselect.c versions.
8781
77abcbc2
LI
87822012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
8783
8784 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
8785
90b671e2
EZ
87862012-02-11 Eli Zaretskii <eliz@gnu.org>
8787
1c0ca0b7
EZ
8788 * w32select.c (Fx_selection_exists_p): Sync doc string and
8789 argument list with xselect.c. (Bug#10783)
8790
8791 * w16select.c (Fx_selection_exists_p): Sync doc string and
8792 argument list with xselect.c. (Bug#10783)
90b671e2 8793
49241268
GM
87942012-02-10 Glenn Morris <rgm@gnu.org>
8795
8796 * fns.c (Fsecure_hash): Doc fix.
8797
f998bbe7 87982012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
8799
8800 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
8801
0992bd9c
CY
88022012-02-07 Chong Yidong <cyd@gnu.org>
8803
8804 * buffer.c (Fbuffer_local_variables)
8805 (buffer_lisp_local_variables): Handle unbound vars correctly;
8806 don't let Qunbound leak into Lisp.
8807
af008560
GM
88082012-02-07 Glenn Morris <rgm@gnu.org>
8809
dd605cc4
GM
8810 * image.c (Fimagemagick_types): Doc fix.
8811
af008560
GM
8812 * image.c (imagemagick-render-type): Change it from a lisp object
8813 to an integer. Move the doc here from the lisp manual.
8814 Treat all values not equal to 0 the same.
8815
1449fa1d
CY
88162012-02-06 Chong Yidong <cyd@gnu.org>
8817
8818 * doc.c (store_function_docstring): Avoid applying docstring of
8819 alias to base function (Bug#2603).
8820
3723ec07
AS
88212012-02-04 Andreas Schwab <schwab@linux-m68k.org>
8822
8823 * .gdbinit (pp1, pv1): Remove redundant defines.
8824 (pr): Use pp.
8825
79c1cc1e
CY
88262012-02-04 Chong Yidong <cyd@gnu.org>
8827
8828 * nsterm.m: Declare a global (Bug#10694).
8829
d7f29f8e
EZ
88302012-02-04 Eli Zaretskii <eliz@gnu.org>
8831
cae07000
SM
8832 * w32.c (get_emacs_configuration_options):
8833 Include --enable-checking, if specified, in the return value.
d7f29f8e 8834
3b95a6f9
MR
88352012-02-04 Martin Rudalics <rudalics@gmx.at>
8836
8837 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
8838 after rounding frame sizes. (Bug#9723)
8839
d6fa96a6
EZ
88402012-02-04 Eli Zaretskii <eliz@gnu.org>
8841
8842 * keyboard.c (adjust_point_for_property): Don't position point
8843 before BEGV. (Bug#10696)
8844
df0b2940
PE
88452012-02-03 Paul Eggert <eggert@cs.ucla.edu>
8846
8847 Handle overflow when computing char display width (Bug#9496).
8848 * character.c (char_width): Return EMACS_INT, not int.
8849 (char_width, c_string_width): Check for overflow when
8850 computing the width; this is possible now that individual
8851 characters can have unbounded width. Problem introduced
8852 by merge from Emacs 23 on 2012-01-19.
8853
6bee44d6
MA
88542012-02-02 Michael Albinus <michael.albinus@gmx.de>
8855
8856 * dbusbind.c (Fdbus_register_method): Mention the return value
8857 :ignore in the docstring.
8858
44f92739
GM
88592012-02-02 Glenn Morris <rgm@gnu.org>
8860
1b9f60cc
GM
8861 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
8862
44f92739
GM
8863 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8864 Unconditionally set to t. (Bug#10673)
8865 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
8866 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
8867 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
8868
c5d3843c
KH
88692012-02-02 Kenichi Handa <handa@m17n.org>
8870
8871 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
8872 0, do not call append_composite_glyph.
8873
159462d4 88742012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
8875
8876 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
8877 NULL (Bug#6988).
8878 (x_produce_glyphs): If the component of a composition is a null
8879 string, set it->pixel_width to 1 to avoid zero-width glyph.
8880
78cef877
EZ
88812012-02-01 Eli Zaretskii <eliz@gnu.org>
8882
8883 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
8884 first 2 arguments are identical. This makes inserting large
8885 output from a subprocess an order of magnitude faster on
8886 MS-Windows, where all sbrk'ed memory is always contiguous.
8887
97897668
GM
88882012-01-31 Glenn Morris <rgm@gnu.org>
8889
8890 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 8891 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
8892 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
8893
31fd3586
GM
88942012-01-29 Glenn Morris <rgm@gnu.org>
8895
8896 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
8897
0e24a8b2
CY
88982012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
8899
8900 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
8901
cc0adcb0
CY
89022012-01-28 Chong Yidong <cyd@gnu.org>
8903
8904 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
8905
acc28cb9
CY
89062012-01-26 Chong Yidong <cyd@gnu.org>
8907
9c69cfb7
CY
8908 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
8909
acc28cb9
CY
8910 * search.c (Fsearch_forward, Fsearch_backward): Document negative
8911 repeat counts (Bug#10507).
8912
48da7392
GM
89132012-01-26 Glenn Morris <rgm@gnu.org>
8914
8915 * lread.c (syms_of_lread): Doc fix.
8916
14af5f7f
CY
89172012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
8918
8919 * coding.c (encode_designation_at_bol): Change return value to
8920 EMACS_INT.
8921
0b21c100
CY
89222012-01-25 Chong Yidong <cyd@gnu.org>
8923
8924 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
8925
3c2907f7
CY
89262012-01-21 Chong Yidong <cyd@gnu.org>
8927
8928 * floatfns.c (Fcopysign): Make the second argument non-optional,
8929 since nil is not allowed anyway.
8930
959ad23f
AS
89312012-01-21 Andreas Schwab <schwab@linux-m68k.org>
8932
8933 * process.c (read_process_output): Use p instead of XPROCESS (proc).
8934 (send_process): Likewise.
8935
34a02f46
MR
89362012-01-19 Martin Rudalics <rudalics@gmx.at>
8937
8938 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
8939 (Vwindow_persistent_parameters): Do not use Qstate.
8940 Rewrite doc-strings.
34a02f46 8941
1259009a 89422012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
8943
8944 * character.c (char_width): New function.
70d4fdf6
GM
8945 (Fchar_width, c_string_width, lisp_string_width):
8946 Use char_width (Bug#9496).
25ed9e61 8947
6a6ee00d
MR
89482012-01-16 Martin Rudalics <rudalics@gmx.at>
8949
8950 * window.c (Vwindow_persistent_parameters): New variable.
8951 (Fset_window_configuration, save_window_save): Handle persistent
8952 window parameters.
8953
c85efaf7
EZ
89542012-01-14 Eli Zaretskii <eliz@gnu.org>
8955
8956 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
8957 thrashing the stack of the thread. (Bug#9087)
8958
5944709e
PE
89592012-01-12 Paul Eggert <eggert@cs.ucla.edu>
8960
8961 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
8962
e71f5d99
EZ
89632012-01-11 Eli Zaretskii <eliz@gnu.org>
8964
8965 * xdisp.c (rows_from_pos_range): Handle the case where the
8966 highlight ends on a newline. (Bug#10464)
8967 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
8968 he end column for display of highlight that ends on a newline
8969 before a R2L line.
8970
ce316182
GM
89712012-01-11 Glenn Morris <rgm@gnu.org>
8972
8973 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
8974 from load-path also when installation-directory is nil. (Bug#10208)
8975
5b43da69
GM
89762012-01-10 Glenn Morris <rgm@gnu.org>
8977
74cc8ff9
GM
8978 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
8979
7d8d6e4e
GM
8980 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
8981 Update template values to be closer to their typical values these days.
5b43da69 8982
a0db8d43
EZ
89832012-01-09 Eli Zaretskii <eliz@gnu.org>
8984
8985 * xdisp.c (rows_from_pos_range): Accept additional argument
8986 DISP_STRING, and accept any glyph in a row whose object is that
8987 string as eligible for mouse highlight. Fixes mouse highlight of
8988 display strings from overlays. (Bug#10464)
8989
9a0115ab 89902012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 8991
b9110d6a 8992 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
8993 * fileio.c (auto_saving_dir_umask): New static var.
8994 (Fmake_directory_internal): Use it.
8995 (do_auto_save_make_dir): Set it, instead of invoking chmod after
8996 creating the directory. The old code temporarily assigns
8997 too-generous permissions to the directory.
8998 (do_auto_save_eh): Clear it.
b9110d6a 8999 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
9000 that the var is always cleared.
9001
6c1bd3f3
EZ
90022012-01-07 Eli Zaretskii <eliz@gnu.org>
9003
9004 * search.c (scan_buffer): Pass character positions to
9005 know_region_cache, not byte positions. (Bug#6540)
9006
069d2b50
L
90072012-01-07 LynX <_LynX@bk.ru> (tiny change)
9008
9009 * w32.c (sys_rename): Report EXDEV when rename of a directory
9010 fails because the target is on another logical disk. (Bug#10284)
9011
75bf0d33
DB
90122012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
9013
9014 * xterm.c (x_embed_request_focus): New function.
9015
9016 * xterm.h: Add prototype.
9017
9018 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
9019
1c6e5a32
GM
90202012-01-05 Glenn Morris <rgm@gnu.org>
9021
9022 * emacs.c (emacs_copyright): Update short copyright year to 2012.
9023
651e947e
EZ
90242012-01-01 Eli Zaretskii <eliz@gnu.org>
9025
9026 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
9027 Load gnutls_transport_set_lowat only if GnuTLS version is below
9028 2.11.1.
9029 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
9030 GnuTLS versions below 2.11.1.
9031
3778cdd8
AL
90322011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
9033
9034 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
9035 to the doc string advising against its use for altering the way
9036 windows are scrolled.
9037
0e5317f7
KH
90382011-12-28 Kenichi Handa <handa@m17n.org>
9039
9040 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
9041 coding-system ASCII compatible only when it does not produce BOM
9042 on encoding (Bug#10383).
9043
93d5ca1f
JD
90442011-12-26 Jan Djärv <jan.h.d@swipnet.se>
9045
9046 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
9047 can scroll.
9048 (create_and_show_popup_menu): Always use menu_position_func for
9049 Gtk3 (Bug#10361).
9050
ca22b785
AS
90512011-12-24 Andreas Schwab <schwab@linux-m68k.org>
9052
9053 * callint.c (Fcall_interactively): Don't truncate prompt string.
9054
d048e1e6
EZ
90552011-12-23 Eli Zaretskii <eliz@gnu.org>
9056
9057 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
9058 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 9059 resumed from there (after widening). (Bug#10360)
d048e1e6 9060
5ccaba1f
JD
90612011-12-22 Jan Djärv <jan.h.d@swipnet.se>
9062
9063 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
9064
204ee57f
JD
90652011-12-21 Jan Djärv <jan.h.d@swipnet.se>
9066
b81d40f0
JB
9067 * nsterm.m (x_free_frame_resources):
9068 Release f->output_data.ns->miniimage.
204ee57f
JD
9069 (ns_index_color): Fix indentation. Do not retain
9070 color_table->colors[i].
9071
9072 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
9073 before returning.
9074
9075 * nsfns.m (x_set_background_color): Assign return value from
9076 ns_index_color to face-background instead of NSColor*.
9077 (ns_implicitly_set_icon_type): Fix indentation.
9078 Change assignment in for loop to comparison.
9079
9080 * emacs.c (ns_pool): New variable.
9081 (main): Assign ns_pool.
9082 (Fkill_emacs): Call ns_release_autorelease_pool.
9083
9084 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
9085 autorelease fdesc, release fdAttrs and tdict.
9086 (ns_get_covering_families): Release charset.
9087 (ns_findfonts): Release NSFontDescriptor created with new.
9088 (ns_uni_to_glyphs): Fix indentation.
9089 (setString): Release attrStr before assigning new value.
9090
c803b2b7
JD
90912011-12-18 Jan Djärv <jan.h.d@swipnet.se>
9092
678f4426
JD
9093 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
9094 and NS_IMPL_COCOA.
9095 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
9096 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
9097
cd394be1 90982011-12-18 David Reitter <reitter@cmu.edu>
678f4426 9099
5fecd5fc
JD
9100 * nsterm.m (ns_term_init): Subscribe for notifications
9101 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
9102 to method trackingNotification in EmacsMenu.
9103
9104 * nsmenu.m (trackingMenu): New variable.
3771cb17 9105 (trackingNotification): New method (from Aquamacs).
5fecd5fc 9106 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 9107 from Aquamacs (Bug#7030).
678f4426
JD
9108
91092011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 9110
c803b2b7
JD
9111 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
9112 (symbol_to_nsstring): Fix indentation.
9113 (ns_symbol_to_pb): New function.
cae07000
SM
9114 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
9115 (Fns_rotate_cut_buffers_internal): Remove.
9116 (Fns_store_selection_internal): Rename from
c803b2b7
JD
9117 Fns_store_cut_buffer_internal.
9118 (ns_get_foreign_selection, Fx_own_selection_internal)
9119 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
9120 (Fns_get_selection_internal, Fns_store_selection_internal):
9121 Use ns_symbol_to_pb and check if return value is nil.
9122 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
9123 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
9124 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
9125 renamed to Sns_store_selection_internal.
9126 (ns_handle_selection_request): Move code to Fx_own_selection_internal
9127 and remove this function.
9128 (ns_handle_selection_clear): Remove, never used.
9129 (Fx_own_selection_internal): Move code from ns_handle_selection_request
9130 here.
9131
e1b01a3a
KB
91322011-12-17 Ken Brown <kbrown@cornell.edu>
9133
9134 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
9135 GID is unknown (Bug#10257).
9136
2adb6e85
PE
91372011-12-17 Paul Eggert <eggert@cs.ucla.edu>
9138
9139 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
9140 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
9141 which caused a build failure on GNU/Linux IA-64. This problem was
9142 introduced by my 2011-10-07 patch.
9143
d1d7b339
JL
91442011-12-15 Juri Linkov <juri@jurta.org>
9145
9146 * image.c (imagemagick_error): New function. (Bug#10112)
9147 (imagemagick_load_image): Comment out `MagickSetResolution' call.
9148 Use `imagemagick_error' where ImageMagick functions return
9149 `MagickFalse'.
9150 (Fimagemagick_types): Add `Fnreverse' to return the list in the
9151 proper order.
9152
100d5755
KH
91532011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9154
9155 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
9156 fill background (Bug#8992).
9157
454592a6
MR
91582011-12-13 Martin Rudalics <rudalics@gmx.at>
9159
9160 * window.c (Vwindow_combination_resize)
9161 (Vwindow_combination_limit): Use t instead of non-nil in
9162 doc-strings.
61d4b438
MR
9163 (Vrecenter_redisplay): Add first sentence of doc-string on
9164 separate line.
53524d93 9165 (Frecenter): Fix doc-string typo.
454592a6 9166
3633e3aa
KH
91672011-12-11 Kenichi Handa <handa@m17n.org>
9168
9169 * coding.c (Funencodable_char_position): Pay attention to the
9170 buffer text relocation (Bug#9389).
9171
7b9d523a 91722011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 9173
7b9d523a
JD
9174 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
9175 gtk_init (Bug#10100).
9176
b73189c6
EZ
91772011-12-10 Eli Zaretskii <eliz@gnu.org>
9178
9179 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9180 IT->string is nil. (Bug#10263)
9181
f7dfe5d6
JD
91822011-12-10 Jan Djärv <jan.h.d@swipnet.se>
9183
83faebb4
JD
9184 * nsterm.h (x_free_frame_resources): Declare.
9185
f7dfe5d6
JD
9186 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
9187 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
9188
9189 * nsterm.h (ns_get_defaults_value): Declare.
9190
9191 * nsterm.m (ns_default): Call ns_get_defaults_value.
9192
7cd4e72c
EZ
91932011-12-09 Eli Zaretskii <eliz@gnu.org>
9194
9195 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
9196 (Bug#10170)
9197
b34d7317
YM
91982011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9199
9200 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
9201 that where the value of an _OBJC_* symbol points to is in the .bss
9202 section (Bug#10240).
9203
76470ad1
KH
92042011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9205
9206 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 9207 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 9208
745fff94
KH
92092011-12-08 Kenichi Handa <handa@m17n.org>
9210
9211 * ftfont.c (get_adstyle_property): Fix previous change
9212 (Bug#10233).
9213
6e44397c
JB
92142011-12-07 Juanma Barranquero <lekktu@gmail.com>
9215
9216 * w32.c (init_environment): If no_site_lisp, remove site-lisp
9217 dirs from the default value of EMACSLOADPATH (bug#10208).
9218
7efa6272
GM
92192011-12-07 Glenn Morris <rgm@gnu.org>
9220
9221 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
9222 installation and source directories as well. (Bug#10208)
9223
f6fc4d87
CY
92242011-12-06 Chong Yidong <cyd@gnu.org>
9225
9226 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
9227
2bf26180
GM
92282011-12-06 Glenn Morris <rgm@gnu.org>
9229
9230 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
9231 as an error, not just -1. (Bug#10217)
9232
3a6ad4f0
CY
92332011-12-05 Chong Yidong <cyd@gnu.org>
9234
9235 * keyboard.c (process_special_events): New function.
9236 (swallow_events, Finput_pending_p): Use it (Bug#10195).
9237
75a3b399
PE
92382011-12-05 Paul Eggert <eggert@cs.ucla.edu>
9239
9240 * coding.c (encode_designation_at_bol): Don't use uninitialized
9241 local variable (Bug#9318).
9242
c3c9e25e
KH
92432011-12-05 Kenichi Handa <handa@m17n.org>
9244
9245 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
9246 return Qnil (Bug#8046, Bug#10193).
9247
5eb05ea3
KH
92482011-12-05 Kenichi Handa <handa@m17n.org>
9249
9250 * coding.c (encode_designation_at_bol): New args charbuf_end and
9251 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
9252 (coding_set_source): Return how many bytes coding->source was
9253 relocated.
9254 (coding_set_destination): Return how many bytes
9255 coding->destination was relocated.
9256 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 9257 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
9258
92592011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
9260
9261 * coding.c (CODING_CHAR_CHARSET_P): New macro.
9262 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
9263 macro (Bug#9318).
9264
92652011-12-05 Andreas Schwab <schwab@linux-m68k.org>
9266
9267 The following changes are to fix Bug#9318.
9268
a79703f5 9269 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
9270 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
9271 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 9272 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 9273
7dbda6df
JB
92742011-12-05 Juanma Barranquero <lekktu@gmail.com>
9275
9276 * lisp.h (process_quit_flag): Fix external declaration.
9277
6d5eb5b0
SM
92782011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
9279
9280 Don't macro-inline non-performance-critical code.
9281 * eval.c (process_quit_flag): New function.
9282 * lisp.h (QUIT): Use it.
9283
a0c3fad0
JD
92842011-12-04 Jan Djärv <jan.h.d@swipnet.se>
9285
9286 * nsfns.m (get_geometry_from_preferences): New function.
9287 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
9288
6c07aac2
AS
92892011-12-04 Andreas Schwab <schwab@linux-m68k.org>
9290
9291 * emacs.c (Qkill_emacs): Define.
9292 (syms_of_emacs): Initialize it.
9293 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
9294 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
9295 (quit_throw_to_read_char): Add parameter `from_signal'.
9296 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
9297 * lisp.h (QUIT): Call Fkill_emacs if requested.
9298
c052ead4
JD
92992011-12-03 Jan Djärv <jan.h.d@swipnet.se>
9300
9301 * widget.c (update_wm_hints): Return if wmshell is null.
9302 (widget_update_wm_size_hints): New function.
9303
9304 * widget.h (widget_update_wm_size_hints): Declare.
9305
9306 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
9307 widget_update_wm_size_hints (Bug#10104).
9308
9e49252b
EZ
93092011-12-03 Eli Zaretskii <eliz@gnu.org>
9310
9311 * xdisp.c (handle_invisible_prop): If the invisible text ends just
9312 before a newline, prepare the bidi iterator for consuming the
9313 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 9314 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 9315
02b16839
JL
93162011-12-02 Juri Linkov <juri@jurta.org>
9317
9318 * search.c (Fword_search_regexp): New Lisp function created from
9319 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
9320 (Fword_search_backward, Fword_search_forward)
9321 (Fword_search_backward_lax, Fword_search_forward_lax):
9322 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
9323 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
9324
0068070e
SM
93252011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
9326
9327 * fileio.c (Finsert_file_contents): Move after-change-function call
9328 to before the "handled:" label, since all "goto handled" appear in
9329 cases where the *-change-functions have already been properly called
9330 (bug#10117).
9331
3360a3fc
AS
93322011-12-01 Andreas Schwab <schwab@linux-m68k.org>
9333
9334 * keyboard.c (interrupt_signal): Don't call kill-emacs when
9335 waiting for input. (Bug#10169)
9336
73d6c093
EZ
93372011-11-30 Eli Zaretskii <eliz@gnu.org>
9338
9339 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9340 verifies glyph row's hash code--we have just reallocated the
9341 glyphs, so their contents can be complete garbage. (Bug#10164)
9342
febe6bea
JB
93432011-11-30 Juanma Barranquero <lekktu@gmail.com>
9344
9345 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
9346
801a4313
EZ
93472011-11-30 Eli Zaretskii <eliz@gnu.org>
9348
9349 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
9350 attributes are tested _before_ calling verify_row_hash, to protect
9351 against GCC re-ordering of the tests. (Bug#10164)
9352
2b56b87e
JD
93532011-11-29 Jan Djärv <jan.h.d@swipnet.se>
9354
9355 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
9356
9357 * xterm.c (handle_one_xevent): Only set async_visible and friends
9358 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 9359 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
9360 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
9361
dbf31225
PE
93622011-11-28 Paul Eggert <eggert@cs.ucla.edu>
9363
9364 Remove GCPRO-related macros that exist only to avoid shadowing locals.
9365 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
9366 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
9367 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9368 All uses changed to use GCPRO1 etc.
9369 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9370 Revert to old implementation (i.e., before 2011-03-11).
9371
1305621b
YM
93722011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9373
9374 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
9375 of scroll runs so as to avoid assigning disabled bogus rows and
9376 unnecessary graphics copy operations.
9377
8c9afb46
EZ
93782011-11-27 Eli Zaretskii <eliz@gnu.org>
9379
9380 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
9381 (snprintf) [_MSC_VER]: Redirect to _snprintf.
9382 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
9383 (malloc, free, realloc, calloc): Redirect to e_* only when
9384 compiling Emacs.
9385
9386 * lisp.h (GCTYPEBITS): Move before first use.
9387 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
9388 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
9389 this macro definition.
9390
9391 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
9392 _MSC_VER.
9393
54e9e3bf
JD
93942011-11-27 Jan Djärv <jan.h.d@swipnet.se>
9395
6d5eb5b0
SM
9396 * gtkutil.c (xg_create_frame_widgets):
9397 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
9398 present with Gtk+ 2.0.
9399
83aca1cb
PE
94002011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9401
9402 * fileio.c (Finsert_file_contents): Undo previous change; see
9403 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
9404
5b76caa4
PE
94052011-11-26 Paul Eggert <eggert@cs.ucla.edu>
9406
9407 Rename locals to avoid shadowing.
9408 * fileio.c (Finsert_file_contents):
9409 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
9410 * process.c (wait_reading_process_output):
9411 Rename inner 'proc' to 'p' to avoid shadowing.
9412 Indent for consistency with usual Emacs style.
9413
8c535114
EZ
94142011-11-25 Eli Zaretskii <eliz@gnu.org>
9415
9416 * xdisp.c (redisplay_window): If cursor row is not fully visible
9417 after recentering, and scroll-conservatively is set to a large
9418 number, scroll window by a few more lines to make the cursor fully
9419 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
9420 (start_display): Don't move to the next line if the display should
9421 start at a newline that is part of a display vector or an overlay
9422 string. (Bug#10119)
8c535114 9423
fa4fdb5c
JL
94242011-11-24 Juri Linkov <juri@jurta.org>
9425
9426 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
9427 after the `MagickPingImage' call. (Bug#10112)
9428
90ec88df
CY
94292011-11-23 Chong Yidong <cyd@gnu.org>
9430
9431 * window.c (Fcoordinates_in_window_p): Accept only live windows.
9432
56e2e794
MR
94332011-11-23 Martin Rudalics <rudalics@gmx.at>
9434
9435 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
9436 making another buffer current. (Bug#10114)
9437
b6e64c41
GM
94382011-11-23 Glenn Morris <rgm@gnu.org>
9439
9440 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
9441
6b21de18
CY
94422011-11-23 Chong Yidong <cyd@gnu.org>
9443
9444 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
9445 using it (Bug#5984).
9446
b12cd789
EZ
94472011-11-22 Eli Zaretskii <eliz@gnu.org>
9448
9449 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
9450 and header-lines, as they don't have one computed for them.
9451 (Bug#10098)
9452
9453 * .gdbinit (prow): Make displayed values more self-explaining.
9454 Add row's hash code.
9455
261b6fd4
LMI
94562011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
9457
9458 * process.c (wait_reading_process_output): Fix asynchrounous
9459 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 9460 (wait_reading_process_output): Add comment and URL.
261b6fd4 9461
e7cfd277
JD
94622011-11-21 Jan Djärv <jan.h.d@swipnet.se>
9463
9464 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
9465
a9b9b7f5
CY
94662011-11-21 Chong Yidong <cyd@gnu.org>
9467
9468 * window.c (Fnext_window, Fprevious_window): Doc fix.
9469
b0d15b4f
SM
94702011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9471
9472 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9473
fe7a3057
JB
94742011-11-20 Juanma Barranquero <lekktu@gmail.com>
9475
9476 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
9477
d2999b1a
MR
94782011-11-20 Martin Rudalics <rudalics@gmx.at>
9479
9480 * window.c (Fset_window_combination_limit): Rename argument
9481 STATUS to LIMIT.
9482 (Vwindow_combination_limit): Remove "status" from doc-string.
9483
d5ff9cd0
AS
94842011-11-20 Andreas Schwab <schwab@linux-m68k.org>
9485
9486 * m/ibms390.h: Remove.
9487 * m/ibms390x.h: Don't include "ibms390.h".
9488
a5bb9bd3
SM
94892011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
9490
9491 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
9492 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
9493
cd1181db
JB
94942011-11-20 Juanma Barranquero <lekktu@gmail.com>
9495
9496 * casetab.c (Fset_case_table):
9497 * charset.c (Fcharset_after): Fix typos.
9498
615a3b8d 94992011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 9500
17e845af
PE
9501 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
9502 Otherwise, valgrind does not work on some platforms.
9503 Problem reported by Andreas Schwab in
6a0bf43d
PE
9504 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
9505 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
9506 is set, removing the need for VIRT_ADDRESS_VARIES.
9507 (PURE_P): Use a more-efficient implementation that needs just one
9508 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
9509 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
9510 to 4 (xorl, subq, cmpq, setbe).
9511 * alloc.c (pure): Always extern now, since that's the
9512 VIRT_ADDR_VARIES behavior.
9513 (PURE_POINTER_P): Use a single comparison, not two, for
9514 consistency with the new puresize.h.
9515 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
9516 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
9517 Remove VIRT_ADDR_VARIES no longer needed.
9518
f8fe6f96
EZ
95192011-11-19 Eli Zaretskii <eliz@gnu.org>
9520
9521 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
9522 (erase_phys_cursor, update_window_cursor, show_mouse_face)
9523 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
9524 behave as if the cursor position were at the window margin.
9525
9526 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
9527 and the cursor position is out of bounds, behave as if the cursor
9528 position were at the window margin. (Bug#10075)
9529
df05a53c
CY
95302011-11-18 Chong Yidong <cyd@gnu.org>
9531
9532 * window.c (Fwindow_combination_limit): Make first argument
9533 non-optional, since it is meaningless for live windows like the
9534 selected window.
61ccba97 9535
2071918e
DA
95362011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
9537
9538 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
9539
b50a28de
SM
95402011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
9541
9542 * intervals.c: Fix grafting over the whole buffer (bug#10071).
9543 (graft_intervals_into_buffer): Simplify.
9544
015137db
EZ
95452011-11-18 Eli Zaretskii <eliz@gnu.org>
9546
9547 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
9548 hash values of the two rows.
9549 (copy_row_except_pointers): Preserve the used[] arrays and the
9550 hash values of the two rows. (Bug#10035)
68c95424 9551 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
9552
9553 * xdisp.c (row_hash): New function, body extracted from
9554 compute_line_metrics.
9555 (compute_line_metrics): Call row_hash, instead of computing the
9556 hash code inline.
9557
9558 * dispnew.c (verify_row_hash): Call row_hash for computing the
9559 hash code of a row, instead of duplicating code from xdisp.c.
9560
9561 * dispextern.h (row_hash): Add prototype.
9562
a2addb04
TH
95632011-11-18 Tassilo Horn <tassilo@member.fsf.org>
9564
9565 * frame.c (delete_frame): Don't delete the terminal when the last
9566 X frame is closed if emacs is built with GTK toolkit.
9567
df85d315
JB
95682011-11-17 Juanma Barranquero <lekktu@gmail.com>
9569
9570 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
9571
a0c2d0ae
MR
95722011-11-17 Martin Rudalics <rudalics@gmx.at>
9573
9574 * window.c (Vwindow_splits): Rename to
9575 Vwindow_combination_resize. Suggested by Juri Linkov.
9576 (Fsplit_window_internal): Use Vwindow_combination_resize instead
9577 of Vwindow_splits.
9578
58179cce
JB
95792011-11-16 Juanma Barranquero <lekktu@gmail.com>
9580
7877f373
JB
9581 * nsfns.m (Fns_font_name):
9582 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 9583
b6f67890
MR
95842011-11-16 Martin Rudalics <rudalics@gmx.at>
9585
9586 * window.h (window): Rename slot "nest" to "combination_limit".
9587 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
9588 (Fset_window_nest): Rename to Fset_window_combination_limit.
9589 (Vwindow_nest): Rename to Vwindow_combination_limit.
9590 (recombine_windows, make_parent_window, make_window)
9591 (Fsplit_window_internal, saved_window)
9592 (Fset_window_configuration, save_window_save): Rename all
9593 occurrences of window_nest to window_combination_limit.
9594
c7015153
JB
95952011-11-15 Juanma Barranquero <lekktu@gmail.com>
9596
9597 * image.c (imagemagick_load_image): Fix typo.
9598
322ad6ec
EZ
95992011-11-14 Eli Zaretskii <eliz@gnu.org>
9600
9601 * xdisp.c (display_line): Move the call to
9602 highlight_trailing_whitespace before the call to
9603 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
9604 faces of all the glyphs to compute ROW's hash value.
9605 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 9606
f067b8ec
JB
96072011-11-14 Juanma Barranquero <lekktu@gmail.com>
9608
9609 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
9610 just return (bug#10044).
9611
1e5b2111
EZ
96122011-11-12 Eli Zaretskii <eliz@gnu.org>
9613
7ef3cbd5
EZ
9614 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
9615 with user-defined heap size. Bump the default size of the temacs
9616 heap to 27MB, to avoid memory warning when running temacs.
9617 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
9618
1e5b2111
EZ
9619 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
9620 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
9621 (verify_row_hash) [XASSERTS]: New function.
9622 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
9623 that the hash value of glyph rows is correct.
1e5b2111 9624
89d61221
MR
96252011-11-12 Martin Rudalics <rudalics@gmx.at>
9626
9627 * window.h (window): Remove splits slot.
9628 * window.c (Fwindow_splits, Fset_window_splits): Remove.
9629 (Fdelete_other_windows_internal, make_parent_window)
9630 (make_window, Fsplit_window_internal, Fdelete_window_internal)
9631 (Fset_window_configuration, save_window_save): Don't deal with
9632 split status of windows.
9633 (saved_window): Remove splits slot.
9634 (Vwindow_splits): Rewrite doc-string.
9635
97f18cc8
JD
96362011-11-11 Jan Djärv <jan.h.d@swipnet.se>
9637
9638 * xfns.c (unwind_create_frame):
9639 * nsfns.m (unwind_create_frame):
9640 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
9641 Vframe_list (Bug#9999).
9642
22a648b4
DA
96432011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
9644
0b381c7e 9645 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 9646
659afede
KH
96472011-11-11 Kenichi Handa <handa@m17n.org>
9648
9649 * callproc.c (Fcall_process): Set the member dst_multibyte of
9650 process_coding.
9651
9ac0394b
KH
96522011-11-11 Johan Bockgård <bojohan@gnu.org>
9653
9654 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
9655 avoid a crash (bug#9496).
9656
2fbdc249
CY
96572011-11-09 Chong Yidong <cyd@gnu.org>
9658
9659 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9660 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
9661
ac6b1f81
PE
96622011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9663
9664 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
9665
09db192c
PE
96662011-11-08 Paul Eggert <eggert@cs.ucla.edu>
9667
9668 Avoid some portability problems by eschewing 'extern inline' functions.
9669 The trivial performance wins aren't worth the portability hassles; see
9670 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
9671 et seq.
9672 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9673 (window_box_width, window_box_left, window_box_left_offset)
9674 (window_box_right, window_box_right_offset): Undo previous change,
9675 by removing the "extern"s.
9676 * intervals.c (adjust_intervals_for_insertion)
9677 (adjust_intervals_for_deletion): Undo previous change,
9678 making these static again.
9679 (offset_intervals, temp_set_point_both, temp_set_point)
9680 (copy_intervals_to_string): No longer inline.
9681 * xdisp.c (window_text_bottom_y, window_box_width)
9682 (window_box_height, window_box_left_offset)
9683 (window_box_right_offset, window_box_left, window_box_right)
9684 (window_box): No longer inline.
9685
105216ed
CY
96862011-11-08 Chong Yidong <cyd@gnu.org>
9687
9688 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
9689 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
9690 Signal an error if not a live window.
105216ed
CY
9691 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
9692 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
9693
ae9e237f
JB
96942011-11-07 Juanma Barranquero <lekktu@gmail.com>
9695
9696 * lisp.h (syms_of_abbrev): Remove declaration.
9697 Reported by CHENG Gao <chenggao@royau.me>.
9698
c7aa8333
EZ
96992011-11-07 Eli Zaretskii <eliz@gnu.org>
9700
9701 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
9702 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
9703 of temacs in GUI mode.
9704
be7f5545
MR
97052011-11-07 Martin Rudalics <rudalics@gmx.at>
9706
9707 * window.h: Declare delete_all_child_windows instead of
9708 delete_all_subwindows.
9709 * window.c (Fwindow_nest, Fset_window_nest)
9710 (Fset_window_new_total, Fset_window_new_normal)
9711 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
9712 (delete_all_subwindows): Rename to delete_all_child_windows.
9713 (Fdelete_other_windows_internal, Fset_window_configuration):
9714 Call delete_all_child_windows instead of delete_all_subwindows.
9715 * frame.c (delete_frame): Call delete_all_child_windows instead
9716 of delete_all_subwindows.
9717
ca78dc43
PE
97182011-11-07 Paul Eggert <eggert@cs.ucla.edu>
9719
9720 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
9721 This is also needed for porting to any host where GC_MARK_STACK is
9722 not GC_MAKE_GCPROS_NOOPS.
9723 (which_symbols): Use it.
9724
a0241d01
KH
97252011-11-07 Kenichi Handa <handa@m17n.org>
9726
9727 * coding.c (coding_set_destination): Check coding->src_pos only
9728 when coding->src_object is a buffer (bug#9910).
9729
9730 * process.c (send_process): Set the member src_multibyte of coding
9731 to 0 (bug#9911) when sending a unibyte text.
9732
9733 * callproc.c (Fcall_process): Set the member src_multibyte of
9734 process_coding to 0 (bug#9912).
9735
a64bfdfa 97362011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
9737
9738 * xmenu.c (cleanup_widget_value_tree): New function.
9739 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
9740 calling free_menubar_widget_value_tree directly (Bug#9830).
9741
cb41b32a
PE
97422011-11-06 Paul Eggert <eggert@cs.ucla.edu>
9743
9744 Fix some portability problems with 'inline'.
9745 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
9746 (window_box_width, window_box_left, window_box_left_offset)
9747 (window_box_right, window_box_right_offset): Declare extern.
9748 Otherwise, these inline functions do not conform to C99 and
9749 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
9750 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
9751 * intervals.c (adjust_intervals_for_insertion)
9752 (adjust_intervals_for_deletion): Now extern, because otherwise the
9753 extern inline functions 'offset_intervals' couldn't refer to it.
9754 (static_offset_intervals): Remove.
9755 (offset_intervals): Rewrite using the old contents of
9756 static_offset_intervals. The old version didn't conform to C99
9757 because an extern inline function contained a reference to an
9758 identifier with static linkage.
9759
b7041366
AS
97602011-11-06 Andreas Schwab <schwab@linux-m68k.org>
9761
9762 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
9763 GC.
9764
88a37c4d
EZ
97652011-11-06 Eli Zaretskii <eliz@gnu.org>
9766
9767 * xdisp.c (init_iterator, reseat_to_string): Don't set the
9768 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
9769 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
9770 return Qleft_to_right.
9771
49745b39
CY
97722011-11-06 Chong Yidong <cyd@gnu.org>
9773
9774 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
9775 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
9776 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
9777 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
9778 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
9779 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
9780 (Fwindow_vscroll): Doc fix.
9781 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
9782 argument, since it makes no sense to pass a live window and for
9783 consistency with window-child.
9784
1f05cd82
CS
97852011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
9786
9787 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
9788 support MSVC.
9789
22610910
JR
97902011-11-05 Jason Rumney <jasonr@gnu.org>
9791
9792 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
9793 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
9794 fonts (Bug#6029).
9795 (add_font_entity_to_list): Fix logic errors in mixed boolean and
9796 bitwise arithmetic preventing use of unicode-sip and non-truetype
9797 opentype fonts.
9798
a06776b2
EZ
97992011-11-05 Eli Zaretskii <eliz@gnu.org>
9800
3ad924ba
EZ
9801 * s/ms-w32.h (fstat, stat, utime): Move redirections to
9802 "emacs"-only part.
9803
a06776b2
EZ
9804 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
9805 initialization code to keep similarity to xfns.c after changes
9806 from 2011-11-05.
9807
c9e7db78
JD
98082011-11-05 Jan Djärv <jan.h.d@swipnet.se>
9809
a97f8f3f
JD
9810 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
9811 (unwind_create_frame): New function (Bug#9943).
9812 (Fx_create_frame): Restructure code to be more similar to the one in
9813 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
9814 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
9815 Move terminal->reference_count++ just before making the frame official
9816 (Bug#9943).
9817
9818 * nsterm.m (x_free_frame_resources): New function.
9819 (x_destroy_window): Move code to x_free_frame_resources.
9820
c9e7db78 9821 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
9822 (Fx_create_frame, x_create_tip_frame):
9823 Move terminal->reference_count++ just before making the frame
75f1671a 9824 official. Move initialization of image_cache_refcount and
c9e7db78
JD
9825 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
9826
a6fc3b5c
EZ
98272011-11-05 Eli Zaretskii <eliz@gnu.org>
9828
9829 Support MSVC build with newer versions of Visual Studio.
9830 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
9831 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
9832 nt/gmake.defs.
9833
9834 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
9835 which are not supported by MSVC.
9836 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
9837 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
9838 bitfields.
9839 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
9840 types in bitfields.
9841 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
9842
9843 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
9844
58179cce 98452011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
9846
9847 Support MSVC build with newer versions of Visual Studio.
9848 * w32.c: Don't include w32api.h for MSVC.
9849 (init_environment) [_MSC_VER]: Call sys_access, not _access.
9850
9851 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
9852 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
9853 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
9854 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
9855 e_* cousins.
9856 (alloca) [_MSC_VER]: Define to _alloca.
9857
9858 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
9859
9860 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
9861
a58c13ed
EZ
98622011-11-04 Eli Zaretskii <eliz@gnu.org>
9863
9864 * xdisp.c (note_mouse_highlight): If either of
9865 previous/next-single-property-change returns nil, treat that as
9866 the beginning or the end of the buffer. (Bug#9955)
9867
fe0b6370
JD
98682011-11-04 Jan Djärv <jan.h.d@swipnet.se>
9869
a58c13ed 9870 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
9871 label is not null (Bug#9951).
9872 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
9873 may be NULL.
9874
89bd5ee1
EZ
98752011-11-04 Eli Zaretskii <eliz@gnu.org>
9876
9877 * window.c (Fwindow_body_size): Mention in the doc string that the
9878 return value is in frame's canonical units. (Bug#9949)
9879
84c3edb9
EZ
98802011-11-03 Eli Zaretskii <eliz@gnu.org>
9881
4e2fb5c7
EZ
9882 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
9883
84c3edb9 9884 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 9885 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 9886 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 9887
bc17a887
EZ
98882011-11-01 Eli Zaretskii <eliz@gnu.org>
9889
9890 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
9891 Don't stop backward scan on the continuation glyph, even though
9892 its CHARPOS is positive.
6d5eb5b0
SM
9893 (mouse_face_from_buffer_pos, note_mouse_highlight):
9894 Rename cover_string to disp_string.
bc17a887 9895
4ee88440
MR
98962011-11-01 Martin Rudalics <rudalics@gmx.at>
9897
9898 * window.c (temp_output_buffer_show): Don't use
9899 Vtemp_buffer_show_specifiers.
9900 (Vtemp_buffer_show_specifiers): Remove unused variable.
9901
c2ff3c02
EZ
99022011-10-30 Eli Zaretskii <eliz@gnu.org>
9903
9904 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
9905 past the beginning of the current glyph matrix.
9906
58179cce 99072011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
9908
9909 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
9910 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
9911 HAVE_GTK3 (Bug#9869).
b77a6a7f 9912
3b574623
JD
9913 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
9914 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
9915
b77a6a7f
JD
9916 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
9917
9918 * xterm.c: Declare x_handle_net_wm_state to return int.
9919 (handle_one_xevent): Check if we are iconified but don't have
9920 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
9921 (get_current_wm_state): Return non-zero if not hidden,
9922 check for _NET_WM_STATE_HIDDEN (Bug#9893).
9923 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
9924 (x_handle_net_wm_state): Return what get_current_wm_state returns.
9925 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
9926
196e41e4
PE
99272011-10-29 Paul Eggert <eggert@cs.ucla.edu>
9928
9929 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
9930 so that this new function doesn't get optimized away by a
9931 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
9932
021f2e1a
AS
99332011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9934
9935 * frame.h (MOUSE_HL_INFO): Remove excess parens.
9936
8b058d44
EZ
99372011-10-29 Eli Zaretskii <eliz@gnu.org>
9938
9939 Fix the `xbytecode' command.
9940 * .gdbinit (xprintbytestr): New command.
b50a28de 9941 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
9942 (xbytecode): Print the byte-code string as well.
9943
4452fb80
EZ
99442011-10-29 Kim Storm <storm@cua.dk>
9945
8b058d44
EZ
9946 * alloc.c (which_symbols): New function.
9947
21b72067
AS
99482011-10-29 Andreas Schwab <schwab@linux-m68k.org>
9949
9950 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
9951 line. (Bug#9903)
9952
83ed7b5c
GM
99532011-10-29 Glenn Morris <rgm@gnu.org>
9954
9955 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9956 Not clear what it was for, and it causes various bugs. (Bug#9839)
9957
5a7a728b
EZ
99582011-10-28 Eli Zaretskii <eliz@gnu.org>
9959
9960 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
9961 possible random value that matches one of those tested as
9962 condition to clear the mouse face.
9963
d3d0842f
CY
99642011-10-28 Chong Yidong <cyd@gnu.org>
9965
9966 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
9967
31b39d13
DN
99682011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
9969
9970 * window.c (make_window): Initialize phys_cursor_on_p.
9971
9aba6043
SM
99722011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
9973
9974 * lisp.h (struct Lisp_Symbol): Update comments.
9975
c20992f4
JB
99762011-10-28 Juanma Barranquero <lekktu@gmail.com>
9977
9978 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
9979
db4f02f2
EZ
99802011-10-28 Eli Zaretskii <eliz@gnu.org>
9981
9982 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
9983 <oslsachem@gmail.com> for helping to debug this.
9984
9985 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
9986 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
9987 (g_b_init_get_glyph_outline_w): New static variables.
9988 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
9989 (GetGlyphOutlineW_Proc): New typedefs.
9990 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
9991 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
9992 New functions.
9993 (w32font_open_internal, compute_metrics):
9994 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
9995 instead of calling the "wide" APIs directly.
9996
9997 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
9998
9999 * w32.h (syms_of_w32font): Add prototype.
10000
87e68db4
JB
100012011-10-27 Juanma Barranquero <lekktu@gmail.com>
10002
10003 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
10004 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
10005 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
10006 (Fmove_to_window_line): Doc fix.
10007
435c1d67
CY
100082011-10-27 Chong Yidong <cyd@gnu.org>
10009
10010 * process.c (make_process): Set gnutls_state to NULL.
10011
10012 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
10013 non-NULL, regardless of GNUTLS_INITSTAGE.
10014 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
10015 an error. Set process slots as soon as we allocate them.
10016
10017 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
10018
9c6c6f49
CY
100192011-10-27 Chong Yidong <cyd@gnu.org>
10020
9aba6043
SM
10021 * gnutls.c (emacs_gnutls_deinit): New function.
10022 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
10023 (Fgnutls_deinit, Fgnutls_boot): Use it.
10024
10025 * process.c (make_process): Initialize GnuTLS credentials to NULL.
10026 (deactivate_process): Call emacs_gnutls_deinit.
10027
657d08d3
JB
100282011-10-27 Juanma Barranquero <lekktu@gmail.com>
10029
10030 * image.c (x_create_x_image_and_pixmap):
10031 * w32.c (sys_rename, w32_delayed_load):
10032 * w32font.c (fill_in_logfont):
10033 * w32reg.c (x_get_string_resource): Silence compiler warnings.
10034
5430d399
JB
100352011-10-26 Juanma Barranquero <lekktu@gmail.com>
10036
10037 * w32fns.c (w32_default_color_map): New function,
10038 extracted from Fw32_default_color_map.
a7ef684b 10039 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 10040
fe0055fa
PE
100412011-10-25 Paul Eggert <eggert@cs.ucla.edu>
10042
10043 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
10044
e6346438
SM
100452011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
10046
10047 * keyboard.c (test_undefined): New function (bug#9751).
10048 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
10049
e112cc37
ET
100502011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
10051
10052 * sysdep.c (init_sys_modes): Fix the check for the controlling
10053 terminal (Bug#6649).
10054
7b5d6677
EZ
100552011-10-20 Eli Zaretskii <eliz@gnu.org>
10056
10057 * dispextern.h (struct bidi_it): New member next_en_type.
10058
10059 * bidi.c (bidi_line_init): Initialize the next_en_type member.
10060 (bidi_resolve_explicit_1): When next_en_pos is valid for the
10061 current character, check also for next_en_type being WEAK_EN.
10062 (bidi_resolve_weak): Don't enter the expensive loop if the current
10063 position is before next_en_pos. Record the bidi type of the first
10064 non-ET, non-BN character we find, in addition to its position.
10065 (bidi_level_of_next_char): Invalidate next_en_type when
10066 next_en_pos is over-stepped.
10067
7da0b018
PE
100682011-10-20 Paul Eggert <eggert@cs.ucla.edu>
10069
10070 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
10071 * editfns.c: Rewrite current-time-zone so that it invokes
10072 the equivalent of (format-time-string "%Z") to get the time zone name.
10073 This fixes a bug when the time zone name contains characters that
10074 need converting from the system time locale to Emacs internal format.
10075 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
10076 that patch fixed format-time-string to do the conversion, but
10077 I forgot to fix current-time-zone.
10078 (format_time_string): New function, containing most of
10079 what Fformat_time_string used to contain.
10080 (Fformat_time_string): Rewrite in terms of format_time_string.
10081 This doesn't change this function's behavior.
10082 (current-time-zone): Rewrite to use format_time_string.
10083 This fixes the bug reported by Michael Schierl in
10084 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
10085 Jason Rumney's 2007-06-07 change worked around this bug, but
10086 didn't fix it.
10087 * systime.h (tzname, timezone): Remove no-longer-used declarations.
10088
8547b010
EZ
100892011-10-19 Eli Zaretskii <eliz@gnu.org>
10090
10091 * xdisp.c (start_display): If the character at POS is displayed
10092 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
10093 (try_window_reusing_current_matrix): If a line ends in a display
10094 vector or the next line starts in a display vector, continue
10095 redrawing the window even though the character position of
10096 start_row was reached.
8547b010
EZ
10097 (Bug#9771, part 2)
10098
4e948d15
CY
100992011-10-18 Chong Yidong <cyd@gnu.org>
10100
10101 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
10102 with nobreak-char-display too.
10103
4787455f
EZ
101042011-10-18 Eli Zaretskii <eliz@gnu.org>
10105
10106 Fix part 3 of bug#9771.
10107 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
10108 (bidi_resolve_neutral): Don't enter the expensive loop looking for
10109 non-neutral characters if the current character is a paragraph
10110 separator (a.k.a. Newline). This avoids running the same
10111 expensive loop twice, once when we consume the preceding newline
10112 and the other time when the line actually needs to be displayed.
10113 Avoid the loop when we see neutrals on the base embedding level
10114 following a character whose directionality is the same as the
10115 paragraph's. This avoids running the expensive loop when a line
10116 ends in a long sequence of neutrals, like control characters.
10117 Add assertion against STRONG_AL type. Slightly rearrange code
10118 that determines the type of a neutral given the first non-neutral
10119 that follows it.
10120 (bidi_level_of_next_char): Set next_en_pos to zero when
10121 invalidating its info.
10122
2c91f553
EZ
101232011-10-17 Eli Zaretskii <eliz@gnu.org>
10124
10125 * xdisp.c (push_display_prop): Determine whether to record string
10126 or buffer position by IT->string, not by IT->method. Allow
10127 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
10128 (move_it_vertically_backward): Don't look for character position
10129 immediately after the newline when in a continuation line.
10130 (Bug#9771, part 1)
2c91f553 10131
c7b08b0d
MR
101322011-10-15 Martin Rudalics <rudalics@gmx.at>
10133
10134 * window.c (coordinates_in_window): Rewrite and delabelize
10135 vertical border check. (Bug#5357) (Bug#9618)
10136
6b02f655
SM
101372011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
10138
10139 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
10140 errors in XSetWindowBorder (bug#9310).
10141
81d40c92
DA
101422011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
10143
10144 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
10145 avoid crash when xmalloc overrun checking is enabled.
10146
d4172c3b
EZ
101472011-10-13 Eli Zaretskii <eliz@gnu.org>
10148
10149 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
10150 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
10151 cursor motion with <left> and <right> arrow keys.
10152
10153 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
10154 some callers set that themselves.
10155
b00eea75
EZ
101562011-10-12 Eli Zaretskii <eliz@gnu.org>
10157
10158 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
10159 display string and the previous row comes from the same string and
10160 is empty. (Bug#9739) (Bug#9738)
10161
8fe012c4
SM
101622011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
10163
10164 * doc.c (get_doc_string): Encode file name (bug#9735).
10165
0074aef2
EZ
101662011-10-12 Eli Zaretskii <eliz@gnu.org>
10167
79beb178
EZ
10168 * bidi.c (bidi_level_of_next_char):
10169 * xdisp.c (get_visually_first_element): Remove old incorrect
10170 comments regarding the Unicode Line Separator character.
10171
0074aef2
EZ
10172 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
10173
6e4b3fbe
DA
101742011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
10175
10176 * alloc.c (Fgc_status): Do not access beyond zombies array
10177 boundary if nzombies > MAX_ZOMBIES.
10178 * alloc.c (dump_zombies): Add missing format specifier.
10179
0324f3af
PE
101802011-10-12 Paul Eggert <eggert@cs.ucla.edu>
10181
b5525cac
PE
10182 * xdisp.c (set_cursor_from_row): Simplify conditionals,
10183 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
10184
0324f3af
PE
10185 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
10186 Some packages use them to denote characters with modifiers.
10187
e9b5f888
AS
101882011-10-11 Andreas Schwab <schwab@linux-m68k.org>
10189
10190 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
10191 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
10192 matching a pp-number. Rename parameter var to var1.
10193
127827c0
SM
101942011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
10195
10196 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10197
c8fd3bd0
GM
101982011-10-08 Glenn Morris <rgm@gnu.org>
10199
10200 * callint.c (Fcall_interactively): Give a more explicit error for the
10201 'c' case with a non-character input. (Bug#8479)
10202
352ec8ff
EZ
102032011-10-08 Eli Zaretskii <eliz@gnu.org>
10204
03669ccb
EZ
10205 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
10206 lines.
7061c986
EZ
10207 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
10208 lines that are hscrolled on the left.
03669ccb 10209
352ec8ff
EZ
10210 * dispnew.c (buffer_posn_from_coords): Account for a possible
10211 presence of header-line. (Bug#4426)
10212
a66cfb1c
SM
102132011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
10214
6b02f655
SM
10215 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
10216 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 10217
7c5ee88e
PE
102182011-10-07 Paul Eggert <eggert@cs.ucla.edu>
10219
10220 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
10221 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
10222 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
10223 this makes Emacs dump core during garbage collection on rare
10224 occasions. sizeof is obviously inferior to offsetof here, so
10225 stick with offsetof.
10226 (GC_POINTER_ALIGNMENT): New macro.
10227 (mark_memory): Omit 3rd (offset) arg; caller changed.
10228 Don't assume EMACS_INT alignment is the same as pointer alignment.
10229
df1bbe5b
SM
102302011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
10231
10232 * keyboard.c (read_key_sequence_remapped): New var.
10233 (read_key_sequence): Compute remapping in the right buffer.
10234 (command_loop_1): Use read_key_sequence's remapping directly.
10235
51553db6
SM
102362011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
10237
32c1fffd
SM
10238 * dired.c (file_name_completion): Don't expand file name.
10239 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
10240 before checking file name handler.
10241
51553db6
SM
10242 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
10243 they've been requested explicitly (bug#9591).
10244
b6bd1599 102452011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
10246
10247 * keymap.c (Fsingle_key_description): Use make_specified_string
10248 instead of build_string to build string from push_key_description.
10249 (Bug#5193)
10250
f701dc2a
PE
102512011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10252
4222c55d
PE
10253 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
10254 This fixes a Y2038 bug on 64-bit hosts.
10255 * buffer.c (reset_buffer):
10256 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
10257 (Fclear_buffer_auto_save_failure):
10258 Use 0, not -1, to represent an unset failure time, since time_t
10259 might not be signed.
10260
f701dc2a
PE
10261 Remove dependency on glibc malloc internals.
10262 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10263 Move back here from lisp.h, but with their new implementations.
10264 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10265 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
10266 * charset.c (charset_table_init): New static var.
10267 (syms_of_charset): Use it instead of xmalloc. This removes a
10268 dependency on glibc malloc internals. See Eli Zaretskii's comment in
10269 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
10270 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10271 Move back to alloc.c.
10272 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10273 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
10274
9ceebf39
JD
102752011-09-30 Jan Djärv <jan.h.d@swipnet.se>
10276
10277 * nsterm.m (windowDidResize): Call x_set_window_size only when
10278 ns_in_resize is true. Otherwise set pixelwidth/height and
10279 call change_frame_size (Bug#9628).
10280
cb993c58
PE
102812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
10282
3930c88b
PE
10283 Port --enable-checking=all to Fedora 14 x86-64.
10284 * charset.c (syms_of_charset): Also account for glibc malloc's
10285 internal overhead when calculating the initial malloc maximum.
10286
cb993c58
PE
10287 Port --enable-checking=all to Fedora 14 x86.
10288 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10289 Move to lisp.h.
10290 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
10291 (overrun_check_realloc, overrun_check_free):
10292 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
10293 That way, xmalloc returns a properly-aligned pointer even if
10294 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
10295 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
10296 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
10297 into account when calculating the initial malloc maximum.
10298 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
10299 Move here from alloc.c, so that charset.c can use it too.
10300 Properly align; the old code wasn't right for common 32-bit hosts
10301 when configured with --enable-checking=all.
10302 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
10303 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
10304
31bed486
EZ
103052011-09-29 Eli Zaretskii <eliz@gnu.org>
10306
04c70788 10307 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
10308 use EDOM.
10309
fbcaa2f3
EZ
103102011-09-28 Eli Zaretskii <eliz@gnu.org>
10311
10312 * xdisp.c (compute_display_string_end): If there's no display
10313 string at CHARPOS, return -1.
10314
10315 * bidi.c (bidi_fetch_char): When compute_display_string_end
10316 returns a negative value, treat the character as a normal
10317 character not covered by a display string. (Bug#9624)
10318
a239d4e9
JB
103192011-09-28 Juanma Barranquero <lekktu@gmail.com>
10320
10321 * lread.c (Fread_from_string): Fix typo in docstring.
10322
88652fd5
EZ
103232011-09-27 Eli Zaretskii <eliz@gnu.org>
10324
10325 * xdisp.c (handle_invisible_prop): If invisible text ends on a
10326 newline, reseat the iterator instead of bidi-iterating there one
10327 character at a time. (Bug#9610)
32c1fffd
SM
10328 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
10329 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 10330
ed497dd4
AS
103312011-09-27 Andreas Schwab <schwab@linux-m68k.org>
10332
10333 * lread.c (readevalloop): Use correct code for NBSP.
10334 (read1): Likewise. (Bug#9608)
10335
b2bf61aa
MA
103362011-09-25 Michael Albinus <michael.albinus@gmx.de>
10337
10338 * dbusbind.c (Fdbus_register_signal): When service is not
10339 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10340
32bbb17c
GM
103412011-09-25 Glenn Morris <rgm@gnu.org>
10342
10343 * buffer.c (truncate-lines): Doc fix.
10344
94e0933e
CY
103452011-09-24 Chong Yidong <cyd@stupidchicken.com>
10346
10347 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
10348 (Fset_window_next_buffers): Doc fix.
10349
cddde921
GM
103502011-09-24 Glenn Morris <rgm@gnu.org>
10351
10352 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
10353
1260aef1
PE
103542011-09-24 Paul Eggert <eggert@cs.ucla.edu>
10355
25b4bfa0
PE
10356 Fix minor problems found by static checking.
10357 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
10358 * indent.c (Fvertical_motion): Fix == vs = typo.
10359
e3cbd34b
EZ
103602011-09-24 Eli Zaretskii <eliz@gnu.org>
10361
a66cfb1c
SM
10362 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
10363 Default value is now t. Doc fix.
6bf7006f 10364
e3cbd34b 10365 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 10366 logic when moving up, not only when moving down. Fix the
e3cbd34b 10367 confusing name and values of the it_overshoot_expected variable;
32c1fffd 10368 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
10369
10370 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
10371 CHARPOS is covered by a display string which includes newlines.
10372 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
10373 is covered by a display string with embedded newlines.
10374
a3de0cbd
MA
103752011-09-24 Michael Albinus <michael.albinus@gmx.de>
10376
10377 * dbusbind.c (Fdbus_register_signal): Add match rule to
10378 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
10379 (Fdbus_register_method, Vdbus_registered_objects_table):
10380 Fix docstring.
a3de0cbd 10381
b260039d
JM
103822011-09-24 Jim Meyering <meyering@redhat.com>
10383
32c1fffd 10384 do not ignore write error for any output size
b260039d
JM
10385 The previous change was incomplete.
10386 While it makes emacs --batch detect the vast majority of stdout
10387 write failures, errors were still ignored whenever the output size is
10388 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
10389 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
10390 && echo FAIL: ignored write error
10391 FAIL: ignored write error
10392 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
10393 && echo FAIL: ignored write error
10394 FAIL: ignored write error
10395 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
10396
8eca8a7c
AS
103972011-09-23 Andreas Schwab <schwab@linux-m68k.org>
10398
10399 * emacs.c (Fkill_emacs): In noninteractive mode exit
10400 non-successfully if a write error occurred on stdout. (Bug#9574)
10401
3341db62
EZ
104022011-09-21 Eli Zaretskii <eliz@gnu.org>
10403
10404 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
10405 the xassert test.
10406
10407 * dispextern.h (struct it): Update the comment documenting what
10408 can it->OBJECT be.
10409
8c203dbf
EZ
104102011-09-20 Eli Zaretskii <eliz@gnu.org>
10411
10412 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
10413 a display string, extend search for cursor position to end of row.
10414 (find_row_edges): If the row ends in a newline from a display
10415 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
10416 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
10417 (Fcurrent_bidi_paragraph_direction): Fix search for previous
10418 non-empty line. Fixes confusing cursor motion with arrow keys at
10419 the beginning of a line that starts with whitespace.
8c203dbf 10420
a4824228
LMI
104212011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
10422
10423 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
10424 (bug#9493).
10425
33ed493b
CY
104262011-09-18 Chong Yidong <cyd@stupidchicken.com>
10427
10428 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
10429 boolean (Bug#9154).
10430
56cd55c8
EZ
104312011-09-18 Eli Zaretskii <eliz@gnu.org>
10432
10433 * xdisp.c (display_line): Record maximum and minimum buffer
10434 positions even if no glyphs were produced (e.g., by a zero-width
10435 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
10436 buffer positions that will be removed from the glyph row because
10437 they don't fit.
c02dcedf
EZ
10438 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
10439 column is beyond frame width: don't subtract 1 "pixel" when
10440 computing width of the stretch.
3e62b7e0
EZ
10441 (reseat_at_next_visible_line_start): Undo the change made on
10442 2011-09-17 that saved paragraph information and restored it after
10443 the call to `reseat'. (Bug#9545)
56cd55c8 10444
5ed99d36 104452011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
10446
10447 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
10448 and turn window cursor on if cleared (Bug#9415).
10449
5ed99d36 104502011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
10451
10452 * search.c (boyer_moore): Take unibyte characters from pattern
10453 literally. (Bug#9458)
10454
9bade7b2
EZ
104552011-09-18 Eli Zaretskii <eliz@gnu.org>
10456
10457 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
10458
e5e9d610
PE
104592011-09-18 Paul Eggert <eggert@cs.ucla.edu>
10460
87e4427a
PE
10461 Fix minor problem found by static checking.
10462 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
10463 initialized, to pacify gcc -Wuninitialized.
10464
e5e9d610
PE
10465 * fileio.c: Report proper errno when syscall falls.
10466 (Finsert_file_contents): Save and restore errno,
10467 so that report_file_error outputs the correct diagnostic.
10468 (Fwrite_region) [CLASH_DETECTION]: Likewise.
10469
a1674f0b
EZ
104702011-09-18 Eli Zaretskii <eliz@gnu.org>
10471
10472 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
10473
fbfb6dd4
EZ
104742011-09-17 Eli Zaretskii <eliz@gnu.org>
10475
10476 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
10477 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
10478
bb187662
EZ
104792011-09-17 Eli Zaretskii <eliz@gnu.org>
10480
1137e8b8 10481 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 10482 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
10483
10484 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
10485 (bidi_find_paragraph_start): Search back for paragraph beginning
10486 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
10487 (bidi_move_to_visually_next): Only trigger paragraph-related
10488 computations when the last character is a newline or at EOB, not
10489 just any NEUTRAL_B. (Bug#9470)
10490
bb187662
EZ
10491 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
10492 truncated lines if point is covered by a display string. (Bug#9524)
10493
2e621251
PE
104942011-09-16 Paul Eggert <eggert@cs.ucla.edu>
10495
10496 * xselect.c: Relax test for outgoing X longs (Bug#9498).
10497 (cons_to_x_long): New function.
10498 (lisp_data_to_selection_data): Use it. Correct the test for
10499 short-versus-long data; it was negated. Break out of vector
10500 loop, for efficiency, when a long datum is discovered.
10501
91a15bc6
SM
105022011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10503
10504 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
10505
b41c3a35
EZ
105062011-09-16 Eli Zaretskii <eliz@gnu.org>
10507
10508 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
10509 GCC PR/17406) by declaring this function with external scope.
10510
7812ba2d
PE
105112011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10512
10513 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
10514 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
10515
cf7edc2a
AS
105162011-09-15 Andreas Schwab <schwab@linux-m68k.org>
10517
10518 * editfns.c (Fformat): Correctly handle text properties on "%%".
10519
bd01620e
EZ
105202011-09-15 Eli Zaretskii <eliz@gnu.org>
10521
10522 * xterm.c (x_draw_composite_glyph_string_foreground):
10523 * w32term.c (x_draw_composite_glyph_string_foreground):
10524 * term.c (encode_terminal_code):
10525 * composite.c (composition_update_it, get_composition_id):
10526 * xdisp.c (get_next_display_element)
10527 (fill_composite_glyph_string): Add comments about special meaning
10528 of TAB characters in a composition.
10529
a02719a3
PE
105302011-09-15 Paul Eggert <eggert@cs.ucla.edu>
10531
10532 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
10533 This occurs when processing a multibyte format.
10534 Problem reported by Wolfgang Jenker.
a02719a3 10535
72589a3c
JB
105362011-09-15 Johan Bockgård <bojohan@gnu.org>
10537
10538 * xdisp.c (try_cursor_movement): Only check for exact match if
10539 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
10540
1c14176c
PE
105412011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10542
10543 Remove unused external symbols.
10544 * dispextern.h (calc_pixel_width_or_height): Remove decl.
10545 * xdisp.c (calc_pixel_width_or_height): Now static.
10546 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
10547 * indent.c (check_display_width):
10548 * w32term.c: Fix comment to match code.
10549 * xterm.c, xterm.h (x_catching_errors): Remove.
10550
d2eea5b5
PE
105512011-09-14 Paul Eggert <eggert@cs.ucla.edu>
10552
10553 * xselect.c: Use signed conversions more consistently (Bug#9498).
10554 (selection_data_to_lisp_data): Assume incoming selection data are
10555 signed integers, not unsigned. This is to be consistent with
10556 outgoing selection data, which was modified to use signed integers
10557 in as part of the fix to Bug#9196 in response to Jan D.'s comment
10558 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
10559 expects long, not unsigned long.
10560
46888499
EZ
105612011-09-14 Eli Zaretskii <eliz@gnu.org>
10562
10563 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
10564 computation of loop end. Reported by Johan Bockgård
10565 <bojohan@gnu.org>.
10566
ef8ef9fb
CY
105672011-09-13 Chong Yidong <cyd@stupidchicken.com>
10568
10569 * frame.c (Fother_visible_frames_p): Function deleted.
10570
fa819fed
EZ
105712011-09-12 Eli Zaretskii <eliz@gnu.org>
10572
10573 * indent.c (compute_motion): Process display vector front to back
10574 rather than the other way around. (Bug#2496)
10575
2ba8e008
SM
105762011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
10577
10578 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
10579
20f53c69
CY
105802011-09-11 Chong Yidong <cyd@stupidchicken.com>
10581
10582 * minibuf.c (Fread_from_minibuffer): Doc fix.
10583
d562d7a4
EZ
105842011-09-11 Eli Zaretskii <eliz@gnu.org>
10585
10586 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
10587 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
10588
1c4d7f3d
LMI
105892011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
10590
10591 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
10592 value for non-existent files.
10593
b885bf36
EZ
105942011-09-11 Eli Zaretskii <eliz@gnu.org>
10595
10596 * fileio.c (Finsert_file_contents): If the file cannot be opened,
10597 set its "size" to -1. This will set the modtime_size field of
10598 the corresponding buffer to -1, which is what
10599 verify-visited-file-modtime expects for files that do not exist.
10600 (Bug#9139)
10601
6612f0bf
PE
106022011-09-11 Paul Eggert <eggert@cs.ucla.edu>
10603
10604 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
10605 here ...
10606 * lisp.h: ... from here. push_key_description is no longer
10607 defined in keyboard.c, so its declaration should not be in
10608 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
10609 logically belongs with push_key_description.
10610
dfb3f755
PE
106112011-09-10 Paul Eggert <eggert@cs.ucla.edu>
10612
10613 * buffer.h: Include <sys/types.h> instead of <time.h>.
10614 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
10615 Problem reported by Herbert J. Skuhra.
10616
3134906c
LMI
106172011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
10618
10619 * xml.c (parse_region): Make the parsing work for
10620 non-comment-starting XML files again (bug#9144).
10621
8d903f4e
AS
106222011-09-10 Andreas Schwab <schwab@linux-m68k.org>
10623
10624 * image.c (gif_load): Fix calculation of bottom and right corner.
10625 (Bug#9468)
10626
80ad64f4
EZ
106272011-09-10 Eli Zaretskii <eliz@gnu.org>
10628
10629 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
10630 redisplay in small windows.
10631
208a048d
EZ
106322011-09-09 Eli Zaretskii <eliz@gnu.org>
10633
10634 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
10635
9b1c252e
MR
106362011-09-08 Martin Rudalics <rudalics@gmx.at>
10637
10638 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
10639 Operate on live windows only.
10640
2949f33b
JB
106412011-09-08 Juanma Barranquero <lekktu@gmail.com>
10642
10643 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
10644
e08dcafd
EZ
106452011-09-07 Eli Zaretskii <eliz@gnu.org>
10646
10647 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
10648 only under bidi iteration.
10649
115b96bd
JD
106502011-09-07 Jan Djärv <jan.h.d@swipnet.se>
10651
10652 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
10653
c8199d0f
PE
106542011-09-06 Paul Eggert <eggert@cs.ucla.edu>
10655
10656 isnan: Fix porting problem to Solaris 10 with bundled gcc.
10657 Without this fix, the command to link temacs failed due to an
10658 undefined symbol __builtin_isnan. This is because
10659 /usr/include/iso/math_c99.h #defines isnan(x) to
10660 __builtin_isnan(x), but the bundled gcc, which identifies itself
10661 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
10662 a __builtin_isnan.
10663 * floatfns.c (isnan): #undef, and then #define to a clone of
10664 what's in data.c.
10665 (Fisnan): Always define, since it's always available now.
10666 (syms_of_floatfns): Always define isnan at the Lisp level.
10667
e39b275c 106682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
10669
10670 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
10671
b2db44d9 106722011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 10673
f4af5137 10674 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
10675 The previous code assumed that file offsets (off_t values) fit in
10676 EMACS_INT variables, which is not true on typical 32-bit hosts.
10677 The code messed up by falsely reporting buffer overflow in cases
10678 such as (insert-file-contents "big" nil 1 2) into an empty buffer
10679 when "big" contains more than 2**29 bytes, even though this
10680 inserts just one byte and does not overflow the buffer.
10681 (Finsert_file_contents): Store file offsets as off_t
10682 values, not as EMACS_INT values. Check for overflow when
10683 converting between EMACS_INT and off_t. When checking for
10684 buffer overflow or for overlap, take the offsets into account.
10685 Don't use EMACS_INT for small values where int suffices.
10686 When checking for overlap, fix a typo: ZV was used where
10687 ZV_BYTE was intended.
10688 (Fwrite_region): Don't assume off_t fits into 'long'.
10689 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
10690
ecfc0a49
MA
106912011-09-05 Michael Albinus <michael.albinus@gmx.de>
10692
10693 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
10694
6511acf2 106952011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 10696
0999621a 10697 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
10698
10699 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 10700 (esprintf, exprintf, evxprintf): New functions.
62f19c19 10701 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 10702 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
10703 (modify_event_symbol): Do not assume that the length of
10704 name_alist_or_stem is safe to alloca and fits in int.
10705 (Fexecute_extended_command): Likewise for function name and binding.
10706 (Frecursion_depth): Wrap around reliably on integer overflow.
10707 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
10708 since some callers pass EMACS_INT values.
10709 (Fsingle_key_description): Don't crash if symbol name contains more
10710 than MAX_ALLOCA bytes.
10711 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
10712 (get_minibuffer): Arg is now EMACS_INT, not int.
10713 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 10714 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
10715 * window.h (command_loop_level, minibuf_level): Reflect API changes.
10716
2be7d702
PE
10717 * dbusbind.c (signature_cat): New function.
10718 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
10719 Do not overrun buffer; instead, report string overflow.
10720
9d1df220
PE
10721 * dispnew.c (add_window_display_history): Don't overrun buffer.
10722 Truncate instead; this is OK since it's just a log.
10723
33ef5c64
PE
10724 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
10725 even if the time zone offset is outlandishly large.
10726 Don't mishandle offset == INT_MIN.
10727
66c6fdd5
PE
10728 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
10729 when creating daemon; the previous buffer-overflow check was incorrect.
10730
d749b01b
PE
10731 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
10732 which has the guts of the old verror function.
10733
b5cd1905
PE
10734 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
10735 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
10736
6e1a67fb
PE
10737 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
10738 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 10739 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 10740 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
10741 length of string rather than counting it via multiple sprintfs;
10742 that's simpler and more reliable.
c21721cc
PE
10743 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
10744 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
10745 sprintf, in case result does not fit in int.
10746
c57b67fc
PE
10747 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
10748 (fontset_from_font): Print it.
10749
8a401434
PE
10750 * frame.c (tty_frame_count): Now printmax_t, not int.
10751 (make_terminal_frame, set_term_frame_name): Print it.
10752 (x_report_frame_params): In X, window IDs are unsigned long,
10753 not signed long, so print them as unsigned.
10754 (validate_x_resource_name): Check for implausibly long names,
10755 and don't assume name length fits in 'int'.
10756 (x_get_resource_string): Don't blindly alloca invocation name;
10757 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
10758 not fit in int.
10759
6e1a67fb
PE
10760 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
10761 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
10762 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
10763
0df02bf3
PE
10764 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
10765 Use esprintf, not sprintf, in case result does not fit in int.
10766
48e30793
PE
10767 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10768 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
10769 it as a large positive number.
10770 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
10771 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
10772
a66ff6d8
PE
10773 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
10774 in case result does not fit in int.
10775
aca216ff
PE
10776 * print.c (float_to_string): Detect width overflow more reliably.
10777 (print_object): Make sprintf buffer a bit bigger, to avoid potential
10778 buffer overrun. Don't assume list length fits in 'int'. Treat
10779 print length of 0 as 0, not as infinity; to be consistent with other
10780 uses of print length in this function. Don't overflow print length
10781 index. Don't assume hash table size fits in 'long', or that
10782 vectorlike size fits in 'unsigned long'.
10783
31c286f7
PE
10784 * process.c (make_process): Use printmax_t, not int, to format
10785 process-name gensyms.
10786
55e5faa1
PE
10787 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
10788
80f2e268
PE
10789 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
10790 to avoid potential buffer overrun.
10791
670741ab
PE
10792 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
10793 if X resource line is longer than 512 bytes.
10794
b7163a50
PE
10795 * xfns.c (x_window): Make sprintf buffer a bit bigger
10796 to avoid potential buffer overrun.
10797
ae58ff1f
PE
10798 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
10799
c43c8a6a
PE
10800 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
10801
3f8236f4
PE
108022011-09-04 Paul Eggert <eggert@cs.ucla.edu>
10803
53e9fe90 10804 Integer overflow fixes for scrolling, etc.
6511acf2
PE
10805 Without these, Emacs silently mishandles large integers sometimes.
10806 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
10807 it were "C-u 1 M-x recenter" on a typical 64-bit host.
10808
6511acf2
PE
10809 * xdisp.c (try_window_id): Check Emacs fixnum range before
10810 converting to 'int'.
806add1d 10811
6511acf2 10812 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
10813 Check that an Emacs fixnum is in range before assigning it to 'int'.
10814 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
10815 values converted from Emacs fixnums.
10816 (Frecenter): Don't wrap around a line count if it is out of 'int'
10817 range; instead, treat it as an extreme value.
10818 (Fset_window_configuration, compare_window_configurations):
10819 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
10820
6511acf2
PE
10821 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
10822 that can exceed INT_MAX. Check that EMACS_INT value is in range
10823 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
10824 (match_limit): Don't assume that a fixnum can fit in 'int'.
10825
6511acf2 10826 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
10827 exceed INT_MAX.
10828
6511acf2 10829 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
10830 (Fvertical_motion): Don't wrap around LINES values that don't fit
10831 in 'int'. Instead, treat them as extreme values. This is good
10832 enough for windows, which can't have more than INT_MAX lines anyway.
10833
fcb901a7
LMI
108342011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10835
0f2f6b6d
LMI
10836 * Require libxml/parser.h to avoid compilation warning.
10837
fcb901a7
LMI
10838 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
10839
10840 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
10841 since this reportedly can destroy thread storage.
10842
6e20a0d4
CY
108432011-08-30 Chong Yidong <cyd@stupidchicken.com>
10844
10845 * syntax.c (find_defun_start): Update all cache variables if
10846 exiting early (Bug#9401).
10847
148ae00e
EZ
108482011-08-30 Eli Zaretskii <eliz@gnu.org>
10849
f6cfbd8f
EZ
10850 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
10851
148ae00e
EZ
10852 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
10853 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
10854 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
10855
10856 * term.c (tty_append_glyph): New function.
10857 (produce_stretch_glyph): Static function and its prototype deleted.
10858
a66cfb1c
SM
10859 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
10860 Add prototypes.
148ae00e 10861
c4a07a4c
PE
108622011-08-29 Paul Eggert <eggert@cs.ucla.edu>
10863
10864 * image.c (parse_image_spec): Check for nonnegative, not for positive,
10865 when checking :margin (Bug#9390).
10866 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 10867 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
10868 so that the name doesn't mislead. All uses changed.
10869
6bc8cd65
JB
108702011-08-28 Johan Bockgård <bojohan@gnu.org>
10871
10872 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
10873 set_tty_hooks.
10874
dca4927e
EZ
108752011-08-27 Eli Zaretskii <eliz@gnu.org>
10876
10877 * xdisp.c (move_it_to): Don't bail out early when reaching
10878 position beyond to_charpos, if we are scanning backwards.
10879 (move_it_vertically_backward): When DY == 0, make sure we get to
10880 the first character in the line after the newline.
10881
f2cad773
PE
108822011-08-27 Paul Eggert <eggert@cs.ucla.edu>
10883
10884 * ccl.c: Improve and simplify overflow checking (Bug#9196).
10885 (ccl_driver): Do not generate an out-of-range pointer.
10886 (Fccl_execute_on_string): Remove unnecessary check for
10887 integer overflow, noted by Stefan Monnier in
10888 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
10889 Remove a FIXME that didn't need fixing.
10890 Simplify the newly-introduced buffer reallocation code.
10891
0cae2cdb
JB
108922011-08-27 Juanma Barranquero <lekktu@gmail.com>
10893
10894 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
10895
5fc295a4 108962011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 10897
70c60eb2 10898 Integer and memory overflow issues (Bug#9196).
726e0ab1 10899
d31850da
PE
10900 * doc.c (get_doc_string): Rework so that
10901 get_doc_string_buffer_size is the actual buffer size, rather than
10902 being 1 less than the actual buffer size; this makes xpalloc more
10903 convenient.
10904
a69fbedb
PE
10905 * image.c (x_allocate_bitmap_record, cache_image):
10906 * xselect.c (Fx_register_dnd_atom):
10907 Simplify previous changes by using xpalloc.
10908
fe5c5d37
PE
10909 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
10910 since either will do and ptrdiff_t is convenient with xpalloc.
10911
0065d054
PE
10912 * charset.c (charset_table_size)
10913 (struct charset_sort_data.priority): Now ptrdiff_t.
10914 (charset_compare): Don't overflow if priorities differ greatly.
10915 (Fsort_charsets): Don't assume list length fits in int.
10916 Check for size-calculation overflow when allocating sort data.
10917 (syms_of_charset): Allocate an initial charset table that is
10918 just under 64 KiB, to avoid problems with glibc malloc and mmap.
10919
10920 * cmds.c (internal_self_insert): Check for size-calculation overflow.
10921
10922 * composite.h (struct composition.glyph_len): Now int, not unsigned.
10923 The actual value is always <= INT_MAX, and leaving it unsigned made
10924 overflow checking harder.
10925
10926 * dispextern.h (struct glyph_matrix.rows_allocated)
10927 (struct face_cache.size): Now ptrdiff_t, for convenience in use
10928 with xpalloc. The values are still always <= INT_MAX.
10929
10930 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
10931
10932 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
10933 (SAFE_NALLOCA): New macro.
10934
10935 * region-cache.c (struct boundary.pos, find_cache_boundary)
10936 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
10937 (set_cache_region, invalidate_region_cache)
10938 (revalidate_region_cache, know_region_cache, region_cache_forward)
10939 (region_cache_backward, pp_cache):
10940 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
10941 so that ptrdiff_t * can be passed to xpalloc.
10942 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
10943 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
10944 (pp_cache): Don't assume cache_len fits in int.
10945 * region-cache.h: Adjust extern decls to match.
10946
10947 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
10948 EMACS_INT, since either will do, for xpalloc.
10949
10950 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
10951 (xnmalloc, xnrealloc, xpalloc): New functions.
10952
726e0ab1
PE
10953 * bidi.c (bidi_shelve_header_size): New constant.
10954 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
10955 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
10956
51f30bc5 10957 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
10958 * buffer.c (overlays_at, overlays_in, record_overlay_string)
10959 (overlay_strings):
10960 Don't update size of array until after memory allocation succeeds,
10961 because xmalloc/xrealloc may not return.
0065d054
PE
10962 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
10963 now that we have proper integer overflow checking.
10964 (record_overlay_string, overlay_strings): Catch overflows when
10965 calculating size of overlay_str_buf.
726e0ab1 10966
0065d054
PE
10967 * callproc.c (Fcall_process): Check for size overflow when
10968 calculating size of args2.
10969 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
10970 Normally we prefer signed values, but sticking with ptrdiff_t would
10971 require adding more-complicated checks.
726e0ab1
PE
10972
10973 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
10974 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
10975 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 10976 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
10977
10978 * character.c (Fstring): Check for size-calculation overflow.
10979
10980 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
10981 unnecessary integer overflow. Check for size overflow.
10982 (encode_coding_object): Don't update size until xmalloc succeeds.
10983
10984 * composite.c (get_composition_id): Check for overflow in glyph
10985 length calculations.
10986
10987 Integer and memory overflow fixes for display code.
10988 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
10989 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
10990 (scrolling_window): Check for overflow in size calculations.
10991 (line_draw_cost, realloc_glyph_pool, add_row_entry):
10992 Don't assume glyph table len fits in int.
10993 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
10994 (row_table_size): Now ptrdiff_t, not int.
10995 (scrolling_window): Avoid overflow in size calculations.
10996 Don't update size until allocation succeeds.
10997 * fns.c (concat): Check for overflow in size calculations.
10998 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
10999 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11000 (NEXT_ALMOST_PRIME_LIMIT): New constant.
11001
11002 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
11003 (get_doc_string): Check for size calculation overflow.
11004 Don't update size until allocation succeeds.
11005 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
11006 EMACS_INT, where ptrdiff_t will do.
11007 (Fsubstitute_command_keys): Check for string overflow.
11008
11009 * editfns.c (set_time_zone_rule): Don't assume environment length
11010 fits in int.
11011 (message_length): Now ptrdiff_t, not int.
11012 (Fmessage_box): Don't update size until allocation succeeds.
11013 Don't assume message length fits in int.
11014 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
11015
0065d054
PE
11016 * emacs.c (main): Do not reallocate argv, since there is a null at
11017 the end that can be overwritten, and this way there's no need to
11018 worry about size-calculation overflow.
11019 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
11020
11021 * eval.c (init_eval_once, grow_specpdl): Don't update size until
11022 alloc succeeds.
11023 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
11024
11025 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
11026 (x_set_scroll_bar_width, x_figure_window_size):
11027 Check for integer overflow.
11028 (x_set_alpha): Do not assume XINT fits in int.
11029
11030 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
11031 This is for the members text_lines, text_cols, total_lines, total_cols,
11032 where the system imposes an 'int' limit.
11033
11034 * fringe.c (Fdefine_fringe_bitmap):
11035 Don't update size until alloc works.
11036
11037 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
11038 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
11039
11040 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
11041 Check for size-calculation overflow.
11042 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
11043 do, as we prefer signed integers.
11044 (id_to_widget.max_size, id_to_widget.used)
11045 (xg_store_widget_in_map, xg_remove_widget_from_map)
11046 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
11047 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
11048 Use and return ptrdiff_t, not int.
11049 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
11050 * gtkutil.h: Change prototypes to match the above.
11051
11052 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
11053 are duplicate now that they've been promoted to lisp.h.
11054 (x_allocate_bitmap_record, x_alloc_image_color)
11055 (make_image_cache, cache_image, xpm_load):
11056 Don't update size until alloc is done.
11057 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
11058 (x_detect_edges):
3256efce 11059 Check for size calculation overflow.
726e0ab1
PE
11060 (ct_colors_allocated_max): New constant.
11061 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
11062 overflow.
3256efce 11063
726e0ab1
PE
11064 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
11065 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
11066 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
11067 Use ptrdiff_t, not int, to count maps.
11068 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
11069 calculations. Don't update size until allocation succeeds.
11070 Redo calculations to avoid overflow.
726e0ab1
PE
11071 * keyboard.h: Change prototypes to match the above.
11072
11073 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
11074 to count maps.
11075 (current_minor_maps): Check for size calculation overflow.
11076 * keymap.h: Change prototypes to match the above.
11077
11078 * lread.c (read1, init_obarray): Don't update size until alloc done.
11079
11080 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
11081 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
11082
726e0ab1
PE
11083 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
11084 Now ptrdiff_t, not int.
11085 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
11086 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
11087
11088 * process.c (Fnetwork_interface_list): Check for overflow
11089 in size calculation.
11090
11091 * region-cache.c (move_cache_gap): Check for size calculation overflow.
11092
11093 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
11094 overflow. Don't bother calling xmalloc when xrealloc will do.
11095
11096 * search.c (Freplace_match): Check for size calculation overflow.
11097 (Fset_match_data): Don't assume list lengths fit in 'int'.
11098
11099 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
11100 for command line length. Do not attempt to address one before the
11101 beginning of an array, as that's not portable.
11102
11103 * term.c (max_frame_lines): Remove; unused.
11104 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
11105 not int.
11106 (encode_terminal_code, calculate_costs): Check for size
11107 calculation overflow.
11108 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
11109 table lengths and related sizes. Don't update size until alloc
11110 done. Redo calculations to avoid overflow.
11111 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
11112
11113 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
11114 subtracting pointers.
11115 (gobble_line): Check for overflow more carefully. Don't update size
11116 until alloc done.
11117
11118 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
11119 Don't update size until alloc done.
11120 Redo size calculations to avoid overflow.
11121 Check for size calculation overflow.
0065d054 11122 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
11123
11124 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
11125 Use ptrdiff_t, not int, for sizes.
11126 (store_mode_line_noprop_char): Don't update size until alloc done.
11127
0065d054
PE
11128 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
11129 Use ptrdiff_t, not int, for sizes.
11130 (Finternal_make_lisp_face, cache_face):
11131 Check for size calculation overflow.
11132 (cache_face): Treat size calculation overflows as if they were
11133 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
11134
11135 * xfns.c (x_encode_text, x_set_name_internal)
11136 (Fx_change_window_property): Use ptrdiff_t, not int, to count
11137 sizes, since they can exceed INT_MAX in size. Check for size
11138 calculation overflow.
11139
0065d054
PE
11140 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
11141 (xg_select): Check for size calculation overflow.
726e0ab1
PE
11142 Don't update size until alloc done.
11143
0065d054 11144 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 11145 as sprintf is limited to int lengths.
1d526e2f 11146
252c5ee1
PE
11147 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
11148 (X_LONG_MIN): New macros.
864d7ce7
PE
11149 Use them to make the following changes clearer.
11150 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
11151 This change doesn't affect the value now, but it may help remind
11152 future maintainers not to raise the value too much later.
11153 (SELECTION_QUANTUM): Remove, replacing with ...
11154 (selection_quantum): ... new function, which avoids overflow.
11155 All uses changed.
11156 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
11157 assumption that selection length fits in 'int'.
11158 (x_reply_selection_request, x_handle_selection_request)
11159 (x_get_window_property, receive_incremental_selection)
11160 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
11161 (lisp_data_to_selection_data, clean_local_selection_data):
11162 Use ptrdiff_t, not int, to record length of selection.
11163 (x_reply_selection_request, x_get_window_property)
11164 (receive_incremental_selection, x_property_data_to_lisp):
11165 Redo calculations to avoid overflow.
11166 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 11167 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
11168 something.
11169 (x_get_window_property, receive_incremental_selection)
11170 (lisp_data_to_selection_data, x_property_data_to_lisp):
11171 Check for size-calculation overflow.
11172 (x_get_window_property, receive_incremental_selection)
11173 (lisp_data_to_selection_data, Fx_register_dnd_atom):
11174 Don't store size until memory allocation succeeds.
11175 (x_get_window_property): Plug memory leak on memory exhaustion.
11176 Don't double-block input; malloc is safe here. Don't assume 2**34
11177 - 4 fits in unsigned long. Add an xassert to check
11178 XGetWindowProperty overflow. Be more careful about overflow
11179 calculations, and distinguish size from memory overflow better.
11180 (receive_incremental_selection): When tracing, don't assume
11181 unsigned int is less than INT_MAX.
11182 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
11183 harmful) conversions of unsigned short to int.
11184 (lisp_data_to_selection_data): Don't assume that integers
11185 in the range -65535 through -1 fit in an X unsigned short.
11186 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
11187 result parameters unless successful. Rely on cons_to_unsigned
11188 to report problems with elements; the old code wasn't right anyway.
11189 (x_check_property_data): Check for int overflow; we cannot use
11190 a wider type due to X limits.
11191 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
11192
726e0ab1 11193 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 11194
0065d054
PE
11195 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
11196 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
11197 (x_color_cells): Don't store size until memory allocation succeeds.
11198 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 11199 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
11200 (x_term_init): Don't assume length fits in int (sprintf is limited
11201 to int size).
bc18e09d 11202
ebfa62c0
PE
11203 Use ptrdiff_t for composition IDs.
11204 * character.c (lisp_string_width):
11205 * composite.c (composition_table_size, n_compositions)
11206 (get_composition_id, composition_gstring_from_id):
11207 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
11208 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
11209 * window.c (Frecenter):
11210 Use ptrdiff_t, not int, for composition IDs.
11211 * composite.c (get_composition_id): Check for integer overflow.
11212 * composite.h: Adjust prototypes to match the above changes.
11213
d3411f89
PE
11214 Use ptrdiff_t for hash table indexes.
11215 * category.c (hash_get_category_set):
11216 * ccl.c (ccl_driver):
11217 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
11218 * coding.c (coding_system_charset_list, detect_coding_system):
11219 * coding.h (struct coding_system.id):
11220 * composite.c (get_composition_id, gstring_lookup_cache):
11221 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
11222 * image.c (xpm_get_color_table_h):
11223 * lisp.h (hash_lookup, hash_put):
11224 * minibuf.c (Ftest_completion):
11225 Use ptrdiff_t for hash table indexes, not int (which is too
11226 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
11227 32-bit --with-wide-int hosts).
11228
e097a6fa
PE
11229 * charset.c (Fdefine_charset_internal): Check for integer overflow.
11230 Add a FIXME comment about memory leaks.
11231 (syms_of_charset): Don't assume xmalloc returns.
11232
5637687f
PE
11233 Don't assume that stated character widths fit in int.
11234 * character.c (Fchar_width, c_string_width, lisp_string_width):
11235 * character.h (CHAR_WIDTH):
11236 * indent.c (MULTIBYTE_BYTES_WIDTH):
11237 Use sanitize_char_width to avoid undefined and/or bad behavior
11238 with outlandish widths.
a66cfb1c 11239 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
11240 now that we have two such functions. All uses changed.
11241 (sanitize_char_width): New inline function.
11242
a2271ba2
PE
11243 Don't assume that tab-width fits in int.
11244 * character.h (sanitize_width): New inline function.
11245 (SANE_TAB_WIDTH): New macro.
11246 (ASCII_CHAR_WIDTH): Use it.
11247 * indent.c (sane_tab_width): Remove. All uses replaced by
11248 SANE_TAB_WIDTH (current_buffer).
11249 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
11250
18c52557
PE
11251 * fileio.c: Integer overflow issues with file modes.
11252 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
11253
caeeedc1
PE
11254 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
11255 Remove unreachable code.
11256 (read_hex, load_charset_map_from_file): Check for integer overflow.
11257
6df6ae42 11258 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
11259 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
11260 (x_send_scroll_bar_event): Likewise. Check that the size does not
11261 exceed limits imposed by XClientMessageEvent, as well as the usual
11262 ptrdiff_t and size_t limits.
11263
b13995db
PE
11264 * keyboard.c: Overflow, signedness and related fixes.
11265 (make_lispy_movement): Use same integer type in forward decl
11266 that is used in the definition.
11267 (read_key_sequence, keyremap_step):
11268 Change bufsize argument back to int, undoing my 2011-03-30 change.
11269 We prefer signed types, and int is wide enough here.
11270 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
11271 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
11272 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
11273 length, not size_t. Use ptrdiff_t for index, not int.
11274 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
11275 possibility of integer overflow.
11276
13464394
PE
11277 Overflow, signedness and related fixes for images.
11278
11279 * dispextern.h (struct it.stack[0].u.image.image_id)
11280 (struct_it.image_id, struct image.id, struct image_cache.size)
11281 (struct image_cache.used, struct image_cache.ref_count):
11282 * gtkutil.c (update_frame_tool_bar):
11283 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
11284 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11285 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
11286 * nsmenu.m (update_frame_tool_bar):
11287 * xdisp.c (calc_pixel_width_or_height):
11288 * xfns.c (image_cache_refcount):
11289 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
11290 on typical 64-bit hosts.
11291
11292 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
11293 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
11294 Omit unnecessary casts to int.
11295 (parse_image_spec): Check that integers fall into 'int' range
11296 when the callers expect that.
11297 (image_ascent): Redo ascent calculation to avoid int overflow.
11298 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
11299 (lookup_image): Remove unnecessary tests.
11300 (xbm_image_p): Locals are now of int, not EMACS_INT,
11301 since parse_image_check makes sure they fit into int.
11302 (png_load, gif_load, svg_load_image):
11303 Prefer int to unsigned where either will do.
11304 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
11305 old tiff_error_handler and tiff_warning_handler.
11306 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
11307 stack buffer overflows. It uses only the features of vsnprintf
11308 that are common to both POSIX and native Microsoft.
11309 (tiff_error_handler, tiff_warning_handler): Use it.
11310 (tiff_load, gif_load, imagemagick_load_image):
11311 Don't assume :index value fits in 'int'.
11312 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
11313 (imagemagick_load_image): Check that crop parameters fit into
11314 the integer types that MagickCropImage accepts. Don't assume
11315 Vimagemagick_render_type has a nonnegative value. Don't assume
11316 size_t fits in 'long'.
11317 (gs_load): Use printmax_t to print the widest integers possible.
11318 Check for integer overflow when computing image height and width.
11319
c11821d4
EZ
113202011-08-26 Eli Zaretskii <eliz@gnu.org>
11321
11322 * xdisp.c (redisplay_window): Don't force window start if point
11323 will be invisible in the resulting window. (Bug#9324)
11324
0c95fcf7
EZ
113252011-08-25 Eli Zaretskii <eliz@gnu.org>
11326
11327 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
11328 the display spec is of the form `(space ...)'.
11329 (handle_display_spec): Return the value returned by
11330 handle_single_display_spec, not just 1 or zero.
11331 (handle_single_display_spec): If the display spec is of the form
11332 `(space ...)', and specifies display in the text area, return 2
11333 rather than 1.
fee65a97 11334 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
11335 accurately, and prefer exact match for point under bidi.
11336 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
11337
11338 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
11339 into disp_prop; all users changed.
11340
11341 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
11342 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
11343 for the text covered by the display property.
11344
e4ed06f1
CY
113452011-08-25 Chong Yidong <cyd@stupidchicken.com>
11346
11347 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
11348 Change return value to nil.
11349 (Frecord_buffer): Delete unused function.
11350
f67cdd7f
EZ
113512011-08-24 Eli Zaretskii <eliz@gnu.org>
11352
5980d4c6
EZ
11353 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
11354 buffers, return left-to-right.
8610fe8b
EZ
11355 (set_cursor_from_row): Consider candidate row a win if its glyph
11356 represents a newline and point is on that newline. Fixes cursor
11357 positioning on the newline at EOL of R2L text within L2R
11358 paragraph, and vice versa.
11359 (try_cursor_movement): Check continued rows, in addition to
11360 continuation rows. Fixes unwarranted scroll when point enters a
11361 continued line of R2L text within an L2R paragraph, or vice versa.
11362 (cursor_row_p): Consider the case of point being equal to
11363 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
11364 from the end of a short line to the beginning of a continued line
11365 of R2L text within L2R paragraph.
11366 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
11367 composed characters.
5980d4c6 11368
f67cdd7f
EZ
11369 * bidi.c (bidi_check_type): Use xassert.
11370 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
11371 members.
11372
bca633fb
EZ
113732011-08-23 Eli Zaretskii <eliz@gnu.org>
11374
11375 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
11376 a character.
11377
4a5885a7
CY
113782011-08-23 Chong Yidong <cyd@stupidchicken.com>
11379
11380 * nsfont.m (ns_otf_to_script): Fix typo.
11381
0902a04e
KH
113822011-08-22 Kenichi Handa <handa@m17n.org>
11383
11384 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
11385 extra slot even if the purpose is char-code-property-table.
11386
1a2e6670
EZ
113872011-08-23 Eli Zaretskii <eliz@gnu.org>
11388
8ddde651
EZ
11389 * xdisp.c (redisplay_window): When computing centering_position,
11390 account for the height of the header line. (Bug#8874)
11391
425cc014
EZ
11392 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
11393 instead of CHAR_TO_BYTE. Fixes a crash when a completion
11394 candidate is selected by the mouse, and that candidate has a
11395 composed character under the mouse.
11396
1a2e6670
EZ
11397 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
11398 coordinates reported by pos-visible-in-window-p for a composed
11399 character in column zero.
11400
8b76d6f8
SM
114012011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
11402
11403 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
11404
dac347dd
EZ
114052011-08-22 Eli Zaretskii <eliz@gnu.org>
11406
11407 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
11408 consider it a hit if to_charpos is anywhere in the range of the
11409 composed buffer positions.
11410
e013fb34
CY
114112011-08-22 Chong Yidong <cyd@stupidchicken.com>
11412
11413 * image.c (gif_load): Don't assume that each subimage has the same
11414 dimensions as the base image. Handle disposal method that is
11415 "undefined" by the gif spec (Bug#9335).
11416
bd1ba3e8
CY
114172011-08-20 Chong Yidong <cyd@stupidchicken.com>
11418
11419 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 11420 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 11421
54a1215b
EZ
114222011-08-19 Eli Zaretskii <eliz@gnu.org>
11423
823564e5
EZ
11424 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
11425 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
11426 from an Org mode buffer to a Speedbar frame.
11427
54a1215b
EZ
11428 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
11429 a composition, take its buffer position from IT->cmp_it.charpos.
11430 Fixes cursor positioning at the beginning of a line that begins
11431 with a composed character.
11432
9778ebcc
EZ
114332011-08-18 Eli Zaretskii <eliz@gnu.org>
11434
0be6ee06
EZ
11435 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
11436 character bidirectional type, use STRONG_L instead. Fixes crashes
11437 in a buffer produced by `describe-categories'.
11438
9778ebcc
EZ
11439 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
11440 members before the level stack, so they would be saved and
11441 restored when copying iterator state. Fixes incorrect reordering
11442 around TABs covered by display properties.
11443
156bffbe
AS
114442011-08-18 Andreas Schwab <schwab@linux-m68k.org>
11445
6b02f655 11446 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 11447
72ad093b
CY
114482011-08-17 Chong Yidong <cyd@stupidchicken.com>
11449
11450 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
11451 (internal_condition_case_2, internal_condition_case_n):
11452 Remove unnecessary aborts (Bug#9081).
72ad093b 11453
35774242
EZ
114542011-08-17 Eli Zaretskii <eliz@gnu.org>
11455
11456 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
11457 has no `load' handler, try opening the file locally. (Bug#9311)
11458
db76dd85
KB
114592011-08-16 Ken Brown <kbrown@cornell.edu>
11460
11461 * gmalloc.c: Expand comment.
11462
b215eee5
EZ
114632011-08-16 Eli Zaretskii <eliz@gnu.org>
11464
11465 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
11466 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
11467
a4579d33
KB
114682011-08-16 Ken Brown <kbrown@cornell.edu>
11469
11470 Fix memory allocation problems in Cygwin build (Bug#9273).
11471
11472 * unexcw.c ( __malloc_initialized): Declare external variable.
11473 (fixup_executable): Force the dumped emacs to reinitialize malloc.
11474
8b76d6f8
SM
11475 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
11476 New variables.
a4579d33
KB
11477 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
11478 dumped emacs.
11479 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
11480 in the static heap.
11481 [CYGWIN] (special_realloc): New function.
11482 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
11483 requests to realloc storage in the static heap.
11484
3ebec551
PE
114852011-08-15 Paul Eggert <eggert@cs.ucla.edu>
11486
11487 * bidi.c (bidi_initialize): Remove unused local.
11488
9fd8be00
EZ
114892011-08-15 Eli Zaretskii <eliz@gnu.org>
11490
6b02f655
SM
11491 * bidimirror.h:
11492 * biditype.h: Remove file.
11493 * makefile.w32-in ($(BLD)/bidi.$(O)):
11494 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
11495
11496 * dispextern.h: Fix a typo in the comment to bidi_type_t.
11497
11498 * chartab.c: Improve commentary for the uniprop_table API.
11499
32413314
EZ
11500 * bidi.c (bidi_paragraph_init): Support zero value of
11501 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
11502 (bidi_initialize): Use uniprop_table instead of including
11503 biditype.h and bidimirror.h.
32413314 11504
9fd8be00
EZ
11505 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
11506 coordinates of the iterator when restoring from ppos_it.
11507 (Bug#9296)
11508
5cf2b69b
KH
115092011-08-14 Kenichi Handa <handa@m17n.org>
11510
11511 * process.c (create_process): Call setup_process_coding_systems
72ad093b 11512 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 11513
daf17d00
EZ
115142011-08-14 Eli Zaretskii <eliz@gnu.org>
11515
11516 * xdisp.c (move_it_in_display_line_to): Don't invoke
11517 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
11518 ppos_it. Fixes vertical cursor motion when line beginning is
11519 covered by an image. (Bug#9296)
11520
08e3161a
JD
115212011-08-14 Jan Djärv <jan.h.d@swipnet.se>
11522
11523 * nsterm.h (ns_run_ascript): Declare.
11524 (NSAPP_DATA2_RUNASSCRIPT): Define.
11525
11526 * nsfns.m (as_script, as_result, as_status): New static variables.
11527 (ns_run_ascript): New function.
5e617bc2 11528 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
11529 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
11530 the event loop. Get status from as_status (Bug#7276).
11531
11532 * nsterm.m (sendEvent): If event is NSApplicationDefined and
11533 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
11534 the event loop (Bug#7276).
11535
a3720aa2
AS
115362011-08-14 Andreas Schwab <schwab@linux-m68k.org>
11537
11538 * gnutls.c (QCgnutls_bootprop_priority)
11539 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
11540 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
11541 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
11542 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
11543 (QCgnutls_bootprop_verify_hostname_error)
11544 (QCgnutls_bootprop_callbacks_verify): Rename from
11545 Qgnutls_bootprop_..., all uses changed.
11546
11547 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
11548 uses changed.
11549
0a0d27fb
PE
115502011-08-14 Paul Eggert <eggert@cs.ucla.edu>
11551
19d5c50c
PE
11552 * xfaces.c (Qframe_set_background_mode): Now static.
11553 * dispextern.h (Qframe_set_background_mode): Remove decl.
11554
0a0d27fb
PE
11555 * process.c (Fnetwork_interface_info): Declare local only if needed.
11556
377538cb
JD
115572011-08-13 Jan Djärv <jan.h.d@swipnet.se>
11558
11559 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
11560 (Fnetwork_interface_list): Allocate in increments of bytes instead
11561 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
11562 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
11563 sockaddr.
11564 (struct ifflag_def): notrailers is smart on OSX.
11565 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
11566 Get hardware address with getifaddrs if available.
11567
08fff70c
EZ
115682011-08-12 Eli Zaretskii <eliz@gnu.org>
11569
11570 * xdisp.c (iterate_out_of_display_property): xassert that
11571 IT->position is set to within IT->object's boundaries. Break from
11572 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
11573 when IT->position is set up wrongly due to some bug.
11574 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
11575 (push_display_prop): Allow GET_FROM_STRING as IT->method on
11576 entry. Force push_it to save on the stack the current
11577 buffer/string position, to be restored by pop_it. Fix flags in
11578 the iterator structure wrt the object coming from a display
11579 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
11580 properties. (Bug#9284)
11581
7be1c708 115822011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 11583
7be1c708
CY
11584 * fontset.c (fontset_get_font_group): Add proper type checks.
11585 (Bug#9172)
aac0c6e3 11586
7be1c708 115872011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 11588
7be1c708
CY
11589 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
11590 and LC_VERSION_MIN_MACOSX.
11591 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
11592 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 11593
97bb72a6
EZ
115942011-08-08 Eli Zaretskii <eliz@gnu.org>
11595
11596 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
11597 no-display-properties-and-no-overlays under bidi display.
11598 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 11599 properties and overlays.
97bb72a6 11600
d5617611
CY
116012011-08-08 Chong Yidong <cyd@stupidchicken.com>
11602
37e11a63
CY
11603 * editfns.c (Fset_time_zone_rule): Document relationship with the
11604 setenv function.
11605
d5617611
CY
11606 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
11607 the font entity extracted from the cache (Bug#8109).
11608
58872834
CY
116092011-08-07 Chong Yidong <cyd@stupidchicken.com>
11610
11611 * composite.c (autocmp_chars): Don't reset point. That is done by
11612 restore_point_unwind (Bug#5984).
11613
75bfc667
JL
116142011-08-07 Juri Linkov <juri@jurta.org>
11615
11616 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
11617 to show the arg `TIME' instead of `TIMEVAL'.
11618
d1410150
EZ
116192011-08-06 Eli Zaretskii <eliz@gnu.org>
11620
11621 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
11622 display property strides EOL and includes a newline, as in
11623 longlines-mode. (Bug#9254)
75b771e4
EZ
11624 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
11625 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
11626
11627 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
11628 is non-zero, even if the data buffer is NULL. Fixes a crash in
11629 vertical-motion with longlines-mode. (Bug#9254)
11630
35928349
EZ
116312011-08-05 Eli Zaretskii <eliz@gnu.org>
11632
ec7cc85b
EZ
11633 * bidi.c <bidi_cache_total_alloc>: Now static.
11634 (bidi_initialize): Initialize bidi_cache_total_alloc.
11635
8b76d6f8 11636 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
11637 cache. (Bug#9221)
11638
11639 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
11640 amount allocated this far in `bidi_cache_total_alloc'.
11641 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
11642 non-zero, only free the data buffer without restoring the cache
11643 contents. All callers changed.
11644
11645 * dispextern.h (bidi_unshelve_cache): Update prototype.
11646
11647 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
11648 (move_it_in_display_line, move_it_to)
11649 (move_it_vertically_backward, move_it_by_lines): Replace the call
11650 to xfree to an equivalent call to bidi_unshelve_cache.
11651 (move_it_in_display_line_to): Fix logic of returning
412b6358 11652 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 11653
e2e2423b
EZ
116542011-08-05 Eli Zaretskii <eliz@gnu.org>
11655
11656 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
11657 came from a string character with a `cursor' property. (Bug#9229)
11658
ae9e757a
JD
116592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11660
11661 * Makefile.in (LIB_PTHREAD): New variable.
11662 (LIBES): Add LIB_PTHREAD (Bug#9216).
11663
11664 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
11665 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
11666
213bd7f2
AS
116672011-08-04 Andreas Schwab <schwab@linux-m68k.org>
11668
6b02f655 11669 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 11670
99aaf75f
JD
116712011-08-04 Jan Djärv <jan.h.d@swipnet.se>
11672
11673 * xterm.c (x_find_topmost_parent): New function.
11674 (x_set_frame_alpha): Find topmost parent window with
11675 x_find_topmost_parent and set the property there also (bug#9181).
11676 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
11677
c74e9d86
PE
116782011-08-04 Paul Eggert <eggert@cs.ucla.edu>
11679
11680 * callproc.c (Fcall_process): Avoid vfork clobbering
11681 the local vars buffer, coding_systems, current_dir.
11682
640c8776
SM
116832011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
11684
11685 * keymap.c (Fmake_composed_keymap): Move to subr.el.
11686
f26d0e4c
PE
116872011-08-03 Paul Eggert <eggert@cs.ucla.edu>
11688
8a10d76c
PE
11689 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
11690 so that it is not optimized away.
11691
f26d0e4c
PE
11692 * xdisp.c (compute_display_string_pos): Remove unused local.
11693
55439c61
EZ
116942011-08-02 Eli Zaretskii <eliz@gnu.org>
11695
11696 Fix slow cursor motion and scrolling in large buffers with
11697 selective display, like Org Mode buffers. (Bug#9218)
11698
11699 * dispextern.h (struct bidi_it): New member disp_prop_p.
11700
11701 * xdisp.c: Remove one-slot cache of display string positions.
11702 (compute_display_string_pos): Accept an additional argument
5e617bc2 11703 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
11704 for a display string or property. If found, set DISP_PROP_P
11705 non-zero.
11706
11707 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
11708 DISP_PROP_P, and pass it to compute_display_string_pos.
11709 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
11710 non-zero. All callers of bidi_fetch_char changed.
11711
fb33fa43
SM
117122011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
11713
11714 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
11715
b099e063
DM
117162010-12-03 Don March <don@ohspite.net>
11717
11718 * keymap.c (Fdefine_key): Fix non-prefix key error message when
11719 last character M-[char] is translated to ESC [char] (bug#7541).
11720
5cc7f7af
KH
117212011-08-02 Kenichi Handa <handa@m17n.org>
11722
d0fffa3f 11723 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
11724
11725 * chartab.c (uniprop_table): Make it non-static.
11726
525d5e6e
EZ
117272011-08-01 Eli Zaretskii <eliz@gnu.org>
11728
11729 * xdisp.c (forward_to_next_line_start): Accept additional argument
11730 BIDI_IT_PREV, and store into it the state of the bidi iterator had
11731 on the newline.
11732 (reseat_at_next_visible_line_start): Use the bidi iterator state
11733 returned by forward_to_next_line_start to restore the state of
11734 it->bidi_it after backing up to previous newline. (Bug#9212)
11735
31011111
AS
117362011-07-30 Andreas Schwab <schwab@linux-m68k.org>
11737
11738 * regex.c (re_comp): Protoize.
11739 (re_exec): Fix return type.
11740 (regexec): Fix type of `ret'. (Bug#9203)
11741
476371c4
PE
117422011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11743
e5d76069
PE
11744 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
11745 This is needed if max-image-size is a floating-point number.
11746
9a79b20c
AS
117472011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11748
11749 * print.c (print_object): Print empty symbol as ##.
11750
11751 * lread.c (read1): Read ## as empty symbol.
11752
d8c2fa78
AA
117532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
11754
11755 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
11756 setting frame foreground color (Bug#9175).
11757 (x_set_background_color): Likewise.
11758
ffe57a7a
AA
11759 * nsmenu.m (-setText): Size tooltip dimensions precisely to
11760 contents (Bug#9176).
11761 (EmacsTooltip -init): Remove bezels and add shadows to
11762 tooltip windows.
11763
bf3492a5
AA
11764 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
11765 or scroll bar (Bug#8470).
11766
d55e9c53
AA
11767 * nsfont.m (nsfont_open): Remove assignment to voffset and
11768 unnecessary vars hshink, expand, hd, full_height, min_height.
11769 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
11770
11771 * nsterm.h (nsfont_info): Remove voffset field.
11772
d8c2fa78 117732011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
11774
11775 Implement strike-through and overline on NextStep (Bug#8863).
11776
11777 * nsfont.m (nsfont_open): Use underline position provided by font,
11778 instead of hard-coded value of 2.
11779 (nsfont_draw): Call ns_draw_text_decoration instead.
11780
11781 * nsterm.h: Add declaration for ns_draw_text_decoration.
11782
11783 * nsterm.m (ns_draw_text_decoration): New function for drawing
11784 underline, overline, and strike-through.
11785 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
11786 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 11787 accommodate underlining, etc.
4843aac3 11788
4cc60b9b
EZ
117892011-07-28 Eli Zaretskii <eliz@gnu.org>
11790
bc7ece87
EZ
11791 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
11792 default.
4cc60b9b 11793
476371c4
PE
117942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11795
66606eea
PE
11796 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
11797 Without this fix, if a signal arrives just after memory fills up,
11798 'malloc' might be invoked reentrantly.
11799
476371c4
PE
11800 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
11801 In other words, assume that every image size is allowed, on non-X
11802 hosts. This assumption is probably wrong, but it lets Emacs compile.
11803
f3fcc40d
AS
118042011-07-28 Andreas Schwab <schwab@linux-m68k.org>
11805
11806 * regex.c (re_iswctype): Convert return values to boolean.
11807
350c992f
EZ
118082011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
11809
11810 * xdisp.c (compute_display_string_pos): Don't use cached display
11811 string position if the buffer had its restriction changed.
11812 (Bug#9184)
11813
5266b4bb
PE
118142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
11815
11816 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11817
2573a837 118182011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 11819
41f55ccd 11820 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 11821
39e378da
PE
11822 * bidi.c: Integer size and overflow fixes.
11823 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
11824 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
11825 (bidi_cache_find_level_change, bidi_cache_ensure_space)
11826 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
11827 (bidi_find_other_level_edge):
11828 Use ptrdiff_t instead of EMACS_INT where either will do.
11829 This works better on 32-bit hosts configured --with-wide-int.
11830 (bidi_cache_ensure_space): Check for size-calculation overflow.
11831 Use % rather than repeated addition, for better worst-case speed.
11832 Don't set bidi_cache_size until after xrealloc returns, because it
11833 might not return.
11834 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
11835 (bidi_cache_ensure_space): Also check that the bidi cache size
11836 does not exceed that of the largest Lisp string or buffer. See Eli
11837 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 11838
5e927815
PE
11839 * alloc.c (__malloc_size_t): Remove.
11840 All uses replaced by size_t. See Andreas Schwab's note
11841 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
11842
ca4aa935
PE
11843 * image.c: Improve checking for integer overflow.
11844 (check_image_size): Assume that f is nonnull, since
11845 it is always nonnull in practice. This is one less thing to
11846 worry about when checking for integer overflow later.
11847 (x_check_image_size): New function, which checks for integer
11848 overflow issues inside X.
11849 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
11850 This removes the need for a memory_full check.
11851 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
11852 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
11853 (xbm_read_bitmap_data): Change locals back to 'int', since
11854 their values must fit in 'int'.
11855 (xpm_load_image, png_load, tiff_load):
11856 Invoke x_create_x_image_and_pixmap earlier,
11857 to avoid much needless work if the image is too large.
11858 (tiff_load): Treat overly large images as if
11859 x_create_x_image_and_pixmap failed, not as malloc failures.
11860 (gs_load): Use x_check_image_size.
11861
5f8f9cc2
PE
11862 * gtkutil.c: Omit integer casts.
11863 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
11864 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
11865
5adf60bc
PE
11866 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
11867
c8907a93
PE
11868 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
11869 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
11870 would wrongly return t on a 64-bit host.
11871
e3c25c68
PE
11872 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
11873 The plain *_OVERFLOW macros run afoul of GCC bug 49705
11874 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
11875 and therefore cause GCC to emit a bogus diagnostic in some cases.
11876
3f791afe
PE
11877 * image.c: Integer signedness and overflow and related fixes.
11878 This is not an exhaustive set of fixes, but it's time to
11879 record what I've got.
11880 (lookup_pixel_color, check_image_size): Remove redundant decls.
11881 (check_image_size): Don't assume that arbitrary EMACS_INT values
11882 fit in 'int', or that arbitrary 'double' values fit in 'int'.
11883 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
11884 (tiff_load, imagemagick_load_image):
11885 Check for overflow in size calculations.
11886 (x_create_x_image_and_pixmap): Remove unnecessary test for
11887 xmalloc returning NULL; that can't happen.
11888 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
11889 (xpm_color_bucket): Use better integer hashing function.
11890 (xpm_cache_color): Don't possibly over-allocate memory.
11891 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
11892 (gif_memory_source):
11893 Use ptrdiff_t, not int or size_t, to record sizes.
11894 (png_load): Don't assume values greater than 2**31 fit in 'int'.
11895 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
11896 either works, as we prefer signed integers.
11897 (tiff_read_from_memory, tiff_write_from_memory):
11898 Return tsize_t, not size_t, since that's what the TIFF API wants.
11899 (tiff_read_from_memory): Don't fail simply because the read would
11900 go past EOF; instead, return a short read.
11901 (tiff_load): Omit no-longer-needed casts.
11902 (Fimagemagick_types): Don't assume size fits into 'int'.
11903
3cc5a532
PE
11904 Improve hashing quality when configured --with-wide-int.
11905 * fns.c (hash_string): New function, taken from sxhash_string.
11906 Do not discard information about ASCII character case; this
11907 discarding is no longer needed.
11908 (sxhash-string): Use it. Change sig to match it. Caller changed.
11909 * lisp.h: Declare it.
11910 * lread.c (hash_string): Remove, since we now use fns.c's version.
11911 The fns.c version returns a wider integer if --with-wide-int is
11912 specified, so this should help the quality of the hashing a bit.
11913
b312a492
PE
11914 * emacs.c: Integer overflow minor fix.
11915 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
11916 Define only if GNU_LINUX.
11917 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
11918
dfd153ae
PE
11919 * dispnew.c: Integer signedness and overflow fixes.
11920 Remove unnecessary forward decls, that were a maintenance hassle.
11921 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
11922 All uses changed.
11923 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
11924 (scrolling_window): Use ptrdiff_t, not int, for byte count.
11925 (prepare_desired_row, line_draw_cost):
11926 Use int, not unsigned, where either works.
11927 (save_current_matrix, restore_current_matrix):
11928 Use ptrdiff_t, not size_t, where either works.
11929 (init_display): Check for overflow more accurately, and without
11930 relying on undefined behavior.
11931
a81d11a3
PE
11932 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
11933 Remove, replacing with the new symbols in lisp.h. All uses changed.
11934 * fileio.c (make_temp_name):
11935 * filelock.c (lock_file_1, lock_file):
11936 * xdisp.c (message_dolog):
11937 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
11938 Use pMd etc. instead.
11939 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
11940 replacing the pWIDE etc. symbols removed from editfns.c.
11941
3300e6fd
PE
11942 * keyboard.h (num_input_events): Now uintmax_t.
11943 This is (very slightly) less likely to mess up due to wraparound.
11944 All uses changed.
11945
fd05c7e9
PE
11946 * buffer.c: Integer signedness fixes.
11947 (alloc_buffer_text, enlarge_buffer_text):
11948 Use ptrdiff_t rather than size_t when either will do, as we prefer
11949 signed integers.
11950
903fe15d
PE
11951 * alloc.c: Integer signedness and overflow fixes.
11952 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
11953 (__malloc_size_t): Default to size_t, not to int.
11954 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
11955 (Fgarbage_collect, mark_object_loop_halt, mark_object):
11956 Prefer ptrdiff_t to size_t when either would do, as we prefer
11957 signed integers.
11958 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
11959 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
11960 Now const. Initialize with values that are in range even if char
11961 is signed.
11962 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
11963 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
11964 These functions do the right thing with sizes > 2**32.
11965 (check_depth): Now ptrdiff_t, not int.
11966 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
11967 Adjust to new way of storing sizes. Check for size overflow bugs
11968 in rest of code.
11969 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
11970 slightly wrong anyway, as it missed one instance of
11971 XMALLOC_OVERRUN_CHECK_OVERHEAD.
11972 (refill_memory_reserve): Omit needless cast to size_t.
11973 (mark_object_loop_halt): Mark as externally visible.
11974
ac82cc6a
PE
11975 * xselect.c: Integer signedness and overflow fixes.
11976 (Fx_register_dnd_atom, x_handle_dnd_message):
11977 Use ptrdiff_t, not size_t, since we prefer signed.
11978 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
11979 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
11980 x_dnd_atoms_size and x_dnd_atoms_length.
11981
c2d1e36d
PE
11982 * doprnt.c: Prefer signed to unsigned when either works.
11983 * eval.c (verror):
11984 * doprnt.c (doprnt):
11985 * lisp.h (doprnt):
11986 * xdisp.c (vmessage):
11987 Use ptrdiff_t, not size_t, when using or implementing doprnt,
11988 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
11989 prefer signed arithmetic to avoid comparison confusion.
11990 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
11991 but is a bit tricky.
11992
0e926e56
PE
11993 Assume freestanding C89 headers, string.h, stdlib.h.
11994 * data.c, doprnt.c, floatfns.c, print.c:
11995 Include float.h unconditionally.
11996 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
11997 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
11998 * regex.c: Likewise for stddef.h, string.h.
11999 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
12000 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
12001 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
12002 (STDC_HEADERS): Remove obsolete defines.
12003 * sysdep.c: Include limits.h unconditionally.
12004
9cfdb3ec
PE
12005 Assume support for memcmp, memcpy, memmove, memset.
12006 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
12007 * regex.c (memcmp, memcpy):
12008 Remove; we assume C89 now.
12009
12010 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
12011 (__malloc_safe_bcopy): Remove; no longer needed.
12012
cf950e6b 12013 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
12014 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
12015 well either way, and we prefer signed to unsigned.
12016
dbf38e02
LMI
120172011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
12018
12019 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
12020 closes the connection while we're reading (bug#9182).
12021
d6f0886c 120222011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 12023
d6f0886c
JD
12024 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
12025 are specified (Bug#9168).
24e0f6b1 12026
2eb1f9e6
PE
120272011-07-25 Paul Eggert <eggert@cs.ucla.edu>
12028
12029 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
12030 Found by GCC static checking and --with-wide-int on a 32-bit host.
12031
22381272 120322011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
12033
12034 * xdisp.c (compute_display_string_pos): Fix logic of caching
12035 previous display string position. Initialize cached_prev_pos to
12036 -1. Fixes slow-down at the beginning of a buffer.
12037
f25e39b4
EZ
120382011-07-24 Eli Zaretskii <eliz@gnu.org>
12039
12040 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
12041 for attrs[LFACE_FONTSET_INDEX].
12042
04c4b52e
PE
120432011-07-23 Paul Eggert <eggert@cs.ucla.edu>
12044
12045 * xml.c (parse_region): Remove unused local
12046 that was recently introduced.
12047
c1734fbd
EZ
120482011-07-23 Eli Zaretskii <eliz@gnu.org>
12049
be18c5a5
EZ
12050 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
12051 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
12052
c1734fbd
EZ
12053 * xdisp.c (move_it_in_display_line_to): Record the best matching
12054 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
12055 exit if none of the characters scanned was an exact match.
12056 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
12057 when exact match is impossible due to invisible text, and the
12058 lines are truncated.
12059
a258d627
JD
120602011-07-23 Jan Djärv <jan.h.d@swipnet.se>
12061
12062 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
12063 for OSX >= 10.7.
12064
b6d5a689
EZ
120652011-07-22 Eli Zaretskii <eliz@gnu.org>
12066
0f74f785
EZ
12067 Fix a significant slow-down of cursor motion with C-n, C-p,
12068 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
12069 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 12070 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
12071 (next_element_from_buffer): Call compute_stop_pos_backwards to
12072 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
12073 base_level_stop.
12074 (reseat): Don't look for prev_stop, as that could mean a very long
12075 run.
12076 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
12077 <cached_disp_overlay_modiff>: Cache for last found display string
12078 position.
551918c1 12079 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
12080 about the same buffer in the same area of character positions, and
12081 the buffer wasn't changed since the time the display string
12082 position was cached.
551918c1 12083
b2d0c91a
EZ
120842011-07-22 Eli Zaretskii <eliz@gnu.org>
12085
12086 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
12087 is an integer, which is important for empty lines. (Bug#9149)
12088
043604ee
CY
120892011-07-22 Chong Yidong <cyd@stupidchicken.com>
12090
12091 * frame.c (Fmodify_frame_parameters): In tty case, update the
12092 default face if necessary (Bug#4238).
12093
da4adb04
CY
120942011-07-21 Chong Yidong <cyd@stupidchicken.com>
12095
12096 * editfns.c (Fstring_to_char): No need to explain what a character
12097 is in the docstring (Bug#6576).
12098
9abd0532
LMI
120992011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12100
12101 * xml.c (parse_region): Make sure we always return a tree.
12102
36881d16
HK
121032011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
12104
12105 * xml.c (parse_region): If a document contains only comments,
12106 return that, too.
12107
1e98674d
LMI
121082011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
12109
12110 * xml.c (make_dom): Return comments, too.
12111
590bd467
PE
121122011-07-19 Paul Eggert <eggert@cs.ucla.edu>
12113
12114 Port to OpenBSD.
12115 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
12116 and the surrounding thread.
12117 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
12118 rather than fgets, and retry after EINTR. Otherwise, 'emacs
12119 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
12120 timer goes off.
12121 * s/openbsd.h (BROKEN_SIGIO): Define.
12122 * unexelf.c (unexec) [__OpenBSD__]:
12123 Don't update the .mdebug section of the Alpha COFF symbol table.
12124
f41628b2
LMI
121252011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
12126
12127 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
12128 (bug#8460).
12129
b59b67c5
PE
121302011-07-18 Paul Eggert <eggert@cs.ucla.edu>
12131
15e3a074
PE
12132 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
12133 This fixes some race conditions on the permissions of any newly
12134 created file.
12135
41bed37d
PE
12136 * alloc.c (valid_pointer_p): Use pipe, not open.
12137 This fixes some permissions issues when debugging.
12138
b59b67c5
PE
12139 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
12140 If fchown fails to set both uid and gid, try to set just gid,
12141 as that is sometimes allowed. Adjust the file's mode to eliminate
12142 setuid or setgid bits that are inappropriate if fchown fails.
12143
925a6be7
SM
121442011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
12145
12146 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
12147 to compare Lisp_Objects.
12148 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
12149 global_gnutls_log_level, don't mistake it for a Lisp_Object.
12150 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
12151
52968808
AS
121522011-07-17 Andreas Schwab <schwab@linux-m68k.org>
12153
0a6a104b
AS
12154 * lread.c (read_integer): Unread even EOF character.
12155 (read1): Likewise. Properly record start position of symbol.
12156
52968808
AS
12157 * lread.c (read1): Read `#:' as empty uninterned symbol if no
12158 symbol character follows.
12159
9e381cdd
PE
121602011-07-17 Paul Eggert <eggert@cs.ucla.edu>
12161
12162 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
12163 This works around a problem with the previous change to Fcopy_file.
12164 Recent glibc declares fchown with __attribute__((warn_unused_result)),
12165 and without this change, GCC might complain about discarding
12166 fchown's return value.
12167
b5641435
JB
121682011-07-16 Juanma Barranquero <lekktu@gmail.com>
12169
12170 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
12171
a8031457
PE
121722011-07-16 Paul Eggert <eggert@cs.ucla.edu>
12173
12174 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
12175
dd889327
LMI
121762011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
12177
750c33f7
LMI
12178 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
12179 it's used from the C level.
12180
dd889327
LMI
12181 * process.c: Use the same condition for POLL_FOR_INPUT in both
12182 keyboard.c and process.c (bug#1858).
12183
87e86684
LM
121842011-07-09 Lawrence Mitchell <wence@gmx.li>
12185
12186 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
12187 (Fgnutls_boot): Use it.
12188
64348f40
AS
121892011-07-15 Andreas Schwab <schwab@linux-m68k.org>
12190
12191 * doc.c (Fsubstitute_command_keys): Revert last change.
12192
1d698799
LMI
121932011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
12194
f863868c
LMI
12195 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
12196 quotes the next character, and doesn't affect other longer
12197 sequences (bug#8935).
12198
1d698799
LMI
12199 * lread.c (syms_of_lread): Clarify that is isn't only
12200 `eval-buffer' and `eval-defun' that's affected by
12201 `lexical-binding' (bug#8460).
12202
aa4b6df6
EZ
122032011-07-15 Eli Zaretskii <eliz@gnu.org>
12204
12205 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 12206 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 12207
5d856da6
PE
122082011-07-14 Paul Eggert <eggert@cs.ucla.edu>
12209
ad6042bb
PE
12210 Fix minor problems found by static checking.
12211 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
12212 (elsz): Now a signed constant, not a size_t var. We prefer signed
12213 types to unsigned, to avoid integer comparison confusion. Without
12214 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
12215 "cannot optimize loop, the loop counter may overflow", a symptom
12216 of the confusion.
f00bbb22 12217 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
12218 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
12219
6468f31c
LMI
122202011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12221
49080b10
LMI
12222 * search.c (Fre_search_backward): Mention `case-fold-search' in
12223 all the re_search_* functions (bug#8138).
12224
6468f31c
LMI
12225 * keyboard.c (Fopen_dribble_file): Document when the file is
12226 closed (bug#8056).
12227
c965adc5
EZ
122282011-07-14 Eli Zaretskii <eliz@gnu.org>
12229
df9733bf
EZ
12230 * bidi.c (bidi_dump_cached_states): Fix format of displaying
12231 bidi_cache_idx.
12232
0bb23927
EZ
12233 Support bidi reordering of display and overlay strings.
12234 * xdisp.c (compute_display_string_pos)
12235 (compute_display_string_end): Accept additional argument STRING.
12236 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
12237 (reseat_to_string): Initialize bidi_it->string.s and
12238 bidi_it->string.schars.
12239 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
12240 NULL (avoids a crash in bidi_paragraph_init).
12241 Initialize itb.string.lstring.
0bb23927
EZ
12242 (init_iterator): Call bidi_init_it only of a valid
12243 buffer position was specified. Initialize paragraph_embedding to
12244 L2R.
12245 (reseat_to_string): Initialize the bidi iterator.
12246 (display_string): If we need to ignore text properties of
12247 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
12248 original value of -1 will not work with bidi.)
12249 (compute_display_string_pos): First arg is now struct
12250 `text_pos *'; all callers changed. Support display properties on
12251 Lisp strings.
12252 (compute_display_string_end): Support display properties on Lisp
12253 strings.
12254 (init_iterator, reseat_1, reseat_to_string): Initialize the
12255 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
12256 when iterating on a string not from display properties).
640c8776
SM
12257 (compute_display_string_pos, compute_display_string_end):
12258 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
12259 arrow keys.
12260 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
12261 base_level_stop; instead, set base_level_stop to BEGV.
12262 Fixes crashes in vertical-motion.
0bb23927
EZ
12263 (next_element_from_buffer): Improve commentary for when
12264 the iterator is before prev_stop.
12265 (init_iterator): Initialize bidi_p from the default value of
12266 bidi-display-reordering, not from buffer-local value. Use the
12267 buffer-local value only if initializing for buffer iteration.
12268 (handle_invisible_prop): Support invisible properties on strings
12269 that are being bidi-reordered.
12270 (set_iterator_to_next): Support bidi reordering of C strings and
12271 Lisp strings.
12272 (next_element_from_string): Support bidi reordering of Lisp
12273 strings.
12274 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
12275 (display_string): Support display of R2L glyph rows.
12276 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
12277 (init_iterator): Don't initialize it->bidi_p for strings
12278 here.
12279 (reseat_to_string): Initialize it->bidi_p for strings here.
12280 (next_element_from_string, next_element_from_c_string)
12281 (next_element_from_buffer): Add xassert's for correspondence
12282 between IT's object being iterated and it->bidi_it.string
12283 structure.
12284 (face_before_or_after_it_pos): Support bidi iteration.
12285 (next_element_from_c_string): Handle the case of the first string
12286 character that is not the first one in the visual order.
12287 (get_visually_first_element): New function, refactored from common
12288 parts of next_element_from_buffer, next_element_from_string, and
12289 next_element_from_c_string.
12290 (tool_bar_lines_needed, redisplay_tool_bar)
12291 (display_menu_bar): Force left-to-right direction. Add a FIXME
12292 comment for making that be controlled by a user option.
12293 (push_it, pop_it): Save and restore the state of the
12294 bidi iterator. Save and restore the bidi_p flag.
12295 (pop_it): Iterate out of display property for string iteration as
12296 well.
12297 (iterate_out_of_display_property): Support iteration over strings.
12298 (handle_single_display_spec): Set up it->bidi_it for iteration
12299 over a display string, and call bidi_init_it.
12300 (handle_single_display_spec, next_overlay_string)
12301 (get_overlay_strings_1, push_display_prop): Set up the bidi
12302 iterator for displaying display or overlay strings.
12303 (forward_to_next_line_start): Don't use the shortcut if
12304 bidi-iterating.
12305 (back_to_previous_visible_line_start): If handle_display_prop
12306 pushed the iterator stack, restore the internal state of the bidi
12307 iterator by calling bidi_pop_it same number of times.
12308 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
12309 and we are bidi-iterating, don't decrement the iterator position;
12310 instead, set the first_elt flag in the bidi iterator, to produce
12311 the same effect.
12312 (reseat_1): Remove redundant setting of string_from_display_prop_p.
12313 (push_display_prop): xassert that we are iterating a buffer.
12314 (push_it, pop_it): Save and restore paragraph_embedding member.
12315 (handle_single_display_spec, next_overlay_string)
12316 (get_overlay_strings_1, reseat_1, reseat_to_string)
12317 (push_display_prop): Set up the `unibyte' member of bidi_it.string
12318 correctly. Don't assume unibyte strings are not bidi-reordered.
12319 (compute_display_string_pos)
12320 (compute_display_string_end): Fix handling the case of C string.
12321 (push_it, pop_it): Save and restore from_disp_prop_p.
12322 (handle_single_display_spec, push_display_prop): Set the
12323 from_disp_prop_p flag.
12324 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
12325 (pop_it): Call iterate_out_of_display_property only if we are
12326 popping after iteration over a string that came from a display
12327 property. Fix a typo in popping stretch info. Add an assertion
12328 for verifying that the iterator position is in sync with the bidi
12329 iterator.
12330 (handle_single_display_spec, get_overlay_strings_1)
12331 (push_display_prop): Fix initialization of paragraph direction for
12332 string when that of the parent object is not yet determined.
12333 (reseat_1): Call bidi_init_it to resync the bidi
12334 iterator with IT's position. (Bug#7616)
12335 (find_row_edges): If ROW->start.pos gives position
12336 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
12337 (handle_stop, back_to_previous_visible_line_start, reseat_1):
12338 Reset the from_disp_prop_p flag.
12339 (SAVE_IT, RESTORE_IT): New macros.
12340 (pos_visible_p, face_before_or_after_it_pos)
12341 (back_to_previous_visible_line_start)
12342 (move_it_in_display_line_to, move_it_in_display_line)
12343 (move_it_to, move_it_vertically_backward, move_it_by_lines)
12344 (try_scrolling, redisplay_window, display_line): Use them when
12345 saving a temporary copy of the iterator and restoring it back.
12346 (back_to_previous_visible_line_start, reseat_1)
12347 (init_iterator): Empty the bidi cache "stack".
12348 (move_it_in_display_line_to): If iterator ended up at
12349 EOL, but we never saw any buffer positions smaller than
12350 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
12351 motion in bidi-reordered lines.
12352 (move_it_in_display_line_to): Record prev_method and prev_pos
12353 immediately before the call to set_iterator_to_next. Fixes cursor
12354 motion in bidi-reordered lines with stretch glyphs and strings
12355 displayed in margins. (Bug#8133) (Bug#8867)
12356 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
12357 TO_CHARPOS.
640c8776
SM
12358 (pos_visible_p): Support positions in bidi-reordered lines.
12359 Save and restore bidi cache.
0bb23927
EZ
12360
12361 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
12362 (bidi_paragraph_info): Delete unused struct.
12363 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
12364 (bidi_cache_start): New variable.
12365 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
12366 to zero.
12367 (bidi_cache_fetch_state, bidi_cache_search)
12368 (bidi_cache_find_level_change, bidi_cache_iterator_state)
12369 (bidi_cache_find, bidi_peek_at_next_level)
12370 (bidi_level_of_next_char, bidi_find_other_level_edge)
12371 (bidi_move_to_visually_next): Compare cache index with
12372 bidi_cache_start rather than with zero.
12373 (bidi_fetch_char): Accept new argument STRING; all callers
12374 changed. Support iteration over a string. Support strings with
12375 display properties. Support unibyte strings. Fix the type of
12376 `len' according to what STRING_CHAR_AND_LENGTH expects.
12377 (bidi_paragraph_init, bidi_resolve_explicit_1)
12378 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
12379 (bidi_level_of_next_char, bidi_move_to_visually_next):
12380 Support iteration over a string.
0bb23927
EZ
12381 (bidi_set_sor_type, bidi_resolve_explicit_1)
12382 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
12383 can now be zero (for strings); special values 0 and -1 were
12384 changed to -1 and -2, respectively.
12385 (bidi_char_at_pos): New function.
12386 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
12387 Call it instead of FETCH_MULTIBYTE_CHAR.
12388 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
12389 initialized to valid values.
12390 (bidi_init_it): Don't initialize charpos and bytepos with invalid
12391 values.
12392 (bidi_level_of_next_char): Allow the sentinel "position" to pass
12393 the test for valid cached positions. Fix the logic for looking up
12394 the sentinel state in the cache. GCPRO the Lisp string we are
12395 iterating.
12396 (bidi_push_it, bidi_pop_it): New functions.
12397 (bidi_initialize): Initialize the bidi cache start stack pointer.
12398 (bidi_cache_ensure_space): New function, refactored from part of
12399 bidi_cache_iterator_state. Don't assume the required size is just
12400 one BIDI_CACHE_CHUNK away.
12401 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
12402 (bidi_count_bytes, bidi_char_at_pos): New functions.
12403 (bidi_cache_search): Don't assume bidi_cache_last_idx is
12404 always valid if bidi_cache_idx is valid.
12405 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
12406 is valid if it's going to be used.
12407 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
12408 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
12409 (bidi_cache_find_level_change, bidi_cache_ensure_space)
12410 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
12411 (bidi_find_other_level_edge, bidi_cache_start_stack):
12412 All variables related to cache indices are now EMACS_INT.
c965adc5 12413
0bb23927
EZ
12414 * dispextern.h (struct bidi_string_data): New structure.
12415 (struct bidi_it): New member `string'. Make flag members be 1-bit
12416 fields, and put them last in the struct.
640c8776
SM
12417 (compute_display_string_pos, compute_display_string_end):
12418 Update prototypes.
0bb23927
EZ
12419 (bidi_push_it, bidi_pop_it): Add prototypes.
12420 (struct iterator_stack_entry): New members bidi_p,
12421 paragraph_embedding, and from_disp_prop_p.
12422 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
12423 (bidi_shelve_cache, bidi_unshelve_cache):
12424 Declare prototypes.
0bb23927
EZ
12425
12426 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
12427 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
12428 and vector-like objects.
12429
12430 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
12431 cache around display iteration.
12432
12433 * window.c (Fwindow_end, window_scroll_pixel_based)
12434 (displayed_window_lines, Frecenter): Save and restore the bidi
12435 cache around display iteration.
12436
3bbd2265
LMI
124372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
12438
12439 * editfns.c (Fdelete_region): Clarify the use of the named
12440 parameters (bug#6788).
12441
adc47434
MR
124422011-07-14 Martin Rudalics <rudalics@gmx.at>
12443
12444 * indent.c (Fvertical_motion): Set and restore w->pointm when
12445 saving and restoring the window's buffer (Bug#9006).
12446
837c31f8
LMI
124472011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
12448
12449 * editfns.c (Fstring_to_char): Clarify just what is returned
12450 (bug#6576). Text by Eli Zaretskii.
12451
ac389d0c
JB
124522011-07-13 Juanma Barranquero <lekktu@gmail.com>
12453
12454 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
12455
0be0ce47
EZ
124562011-07-13 Eli Zaretskii <eliz@gnu.org>
12457
12458 * buffer.c (mmap_find): Fix a typo.
12459
cd18e7e3
JB
124602011-07-13 Johan Bockgård <bojohan@gnu.org>
12461
12462 Fix execution of x selection hooks.
12463 * xselect.c (Qx_lost_selection_functions)
12464 (Qx_sent_selection_functions): New vars.
12465 (syms_of_xselect): DEFSYM them.
12466 (x_handle_selection_request): Pass Qx_sent_selection_functions
12467 rather than Vx_sent_selection_functions to Frun_hook_with_args.
12468 (x_handle_selection_clear,x_clear_frame_selections):
12469 Pass Qx_lost_selection_functions rather than
12470 Vx_lost_selection_functions to Frun_hook_with_args.
12471
47ea7f44
PE
124722011-07-13 Paul Eggert <eggert@cs.ucla.edu>
12473
ac389d0c 12474 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
12475 The old code sometimes used this field without initializing it.
12476
47ea7f44
PE
12477 * alloc.c (gc_sweep): Don't read past end of array.
12478 In theory, the old code could also have corrupted Emacs internals,
12479 though it'd be very unlikely.
12480
bc985c87
AS
124812011-07-12 Andreas Schwab <schwab@linux-m68k.org>
12482
12483 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 12484 argument. (Bug#4026)
bc985c87 12485
0cf34688
LMI
124862011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
12487
b3dadd76
LMI
12488 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
12489 key" (bug#4257).
12490
0cf34688
LMI
12491 * window.c (Fset_window_start): Doc fix (bug#4199).
12492 (Fset_window_hscroll): Ditto.
12493
270768cd
PE
124942011-07-12 Paul Eggert <eggert@cs.ucla.edu>
12495
077e3dda 12496 Fix minor new problems caught by GCC 4.6.1.
270768cd 12497 * term.c (init_tty): Remove unused local.
490011a6 12498 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 12499 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 12500 not used otherwise.
270768cd 12501
b1f58454
CY
125022011-07-12 Chong Yidong <cyd@stupidchicken.com>
12503
12504 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
12505
22b9578d
LMI
125062011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
12507
6e70ab07
LMI
12508 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
12509 are the mini-buffer and the echo area (bug#3320).
12510
22b9578d
LMI
12511 * term.c (init_tty): Remove support for supdup, c10 and perq
12512 terminals, which are no longer supported (bug#1482).
12513
8974cc9f
JB
125142011-07-10 Johan Bockgård <bojohan@gnu.org>
12515
12516 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
12517
a560d974
JD
125182011-07-10 Jan Djärv <jan.h.d@swipnet.se>
12519
12520 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
12521 for non-popups (Bug#3642).
12522
1dae0f0a
AS
125232011-07-10 Andreas Schwab <schwab@linux-m68k.org>
12524
268c2c36 12525 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 12526 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
12527 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
12528 * cm.c (losecursor): Likewise.
1dae0f0a
AS
12529 * data.c (fmod): Likewise.
12530 * dispnew.c (swap_glyphs_in_rows): Likewise.
12531 * emacs.c (memory_warning_signal): Likewise.
12532 * floatfns.c (float_error): Likewise.
12533 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
12534 (otf_open, font_otf_capability, generate_otf_features)
12535 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
12536 Likewise.
12537 * image.c (pbm_read_file): Likewise.
12538 * indent.c (string_display_width): Likewise.
12539 * intervals.c (check_for_interval, search_for_interval)
12540 (inc_interval_count, count_intervals, root_interval)
12541 (adjust_intervals_for_insertion, make_new_interval): Likewise.
12542 * lread.c (defalias): Likewise.
268c2c36 12543 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
12544 * regex.c (set_image_of_range_1, set_image_of_range)
12545 (regex_grow_registers): Likewise.
12546 * sysdep.c (strerror): Likewise.
12547 * termcap.c (valid_filename_p, tprint, main): Likewise.
12548 * tparam.c (main): Likewise.
12549 * unexhp9k800.c (run_time_remap, save_data_space)
12550 (update_file_ptrs, read_header, write_header, calculate_checksum)
12551 (copy_file, copy_rest, display_header): Likewise.
12552 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
12553 Likewise.
12554 * xdisp.c (check_it): Likewise.
12555 * xfaces.c (register_color, unregister_color, unregister_colors):
12556 Likewise.
12557 * xfns.c (print_fontset_result): Likewise.
12558 * xrdb.c (member, fatal, main): Likewise.
12559
99033785
PE
125602011-07-10 Paul Eggert <eggert@cs.ucla.edu>
12561
12562 Fix minor problems found by static checking (Bug#9031).
12563 * chartab.c (char_table_set_range, map_sub_char_table):
12564 Remove unused locals.
12565 (uniprop_table): Now static.
12566 * composite.c (_work_char): Remove unused static var.
12567
9cb2ac56
JB
125682011-07-09 Juanma Barranquero <lekktu@gmail.com>
12569
12570 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
12571
f25661f0
JD
125722011-07-09 Jan Djärv <jan.h.d@swipnet.se>
12573
12574 * gtkutil.c (qttip_cb): Remove code without function.
12575
8278c4fe
EZ
125762011-07-09 Eli Zaretskii <eliz@gnu.org>
12577
12578 * w32.c (pthread_sigmask): New stub.
12579
1692ae2d 125802011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 12581
8a6ebd58 12582 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
12583 sigprocmask is portable only for single-threaded applications, and
12584 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
12585 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
12586 (LIBES): Use it.
12587 * callproc.c (Fcall_process):
12588 * process.c (create_process):
12589 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
12590 Use pthread_sigmask, not sigprocmask.
123403e4 12591
1b854618
JD
125922011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12593
12594 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
12595 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
12596 wrong (Bug#8591).
12597
3fe4b549
JD
125982011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12599
0ce7e563
JD
12600 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
12601 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
12602 (xg_hide_tooltip): Fix comment.
12603
3fe4b549
JD
12604 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
12605 in registerServicesMenuSendTypes.
12606 (validRequestorForSendType): Don't check ns_return_types.
12607
12608 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
12609 ns_return_type.
12610
5df75e47
JR
126112011-07-08 Jason Rumney <jasonr@gnu.org>
12612
22610910
JR
12613 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
12614 SH_SHOW for hidden windows (Bug#5482).
12615
5df75e47
JR
12616 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
12617 frame struct members of non-existent frames (Bug#6284).
12618
699c10bd
JD
126192011-07-08 Jan Djärv <jan.h.d@swipnet.se>
12620
4393663b
JD
12621 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
12622 variable firstTime not needed on OSX >= 10.6.
12623 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
12624 >= 10.5. Use setKnobProportion, setDoubleValue.
12625
12626 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
12627 (MAC_OS_X_VERSION_10_5): Define if not defined.
12628 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
12629 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
12630 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
12631
12632 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 12633 cString and lossyCString on OSX >= 10.4.
4393663b 12634
58179cce 12635 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
12636 sizeToFit on OSX >= 10.2.
12637
12638 * nsimage.m (allocInitFromFile): Don't use deprecated method
12639 bestRepresentationForDevice on OSX >= 10.6.
12640
12641 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
12642 to avoid warning.
12643
12644 * emacs.c: Declare unexec_init_emacs_zone.
12645
a63e0781
JD
12646 * nsgui.h: Fix compiler warning about gnulib redefining verify.
12647
699c10bd
JD
12648 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
12649
12650 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
12651 on svcsMenu (Bug#8842).
12652
12653 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
12654 ns_return_types.
12655 (Fns_list_services): Just return Qnil on 10.6, code not working there.
12656
12657 * nsterm.m (QUTF8_STRING): Declare.
12658 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
12659 (validRequestorForSendType): Return type is (id).
12660 Change indexOfObjectIdenticalTo to indexOfObject.
12661 Check if we have local selection before returning self (Bug#8842).
12662 (writeSelectionToPasteboard): Put local selection into paste board
12663 if we have a local selection (Bug#8842).
12664 (syms_of_nsterm): DEFSYM QUTF8_STRING.
12665
12666 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
12667 (ns_get_local_selection): Declare.
12668
54e10184
LMI
126692011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
12670
9888ff71
LMI
12671 * keymap.c (describe_map_tree): Don't insert a double newline at
12672 the end of the buffer (bug#1169) and return whether we inserted
12673 something.
12674
54e10184
LMI
12675 * callint.c (Fcall_interactively): Change "reading args" to
12676 "providing args" to try to clarify what it does (bug#1010).
12677
15fa4783
KH
126782011-07-07 Kenichi Handa <handa@m17n.org>
12679
12680 * composite.c (composition_compute_stop_pos): Ignore a static
12681 composition starting before CHARPOS (Bug#8915).
12682
12683 * xdisp.c (handle_composition_prop): Likewise.
12684
a8815b00
EZ
126852011-07-07 Eli Zaretskii <eliz@gnu.org>
12686
12687 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
12688 (Bug#9015)
12689
ef7b981d 126902011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
12691
12692 * character.h (unicode_category_t): New enum type.
12693
12694 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
12695 (Qchar_code_property_table): New variable.
12696 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
12697 (UNIPROP_COMPRESSED_FORM_P): New macros.
12698 (char_table_ascii): Uncompress the compressed values.
12699 (sub_char_table_ref): New arg is_uniprop. Callers changed.
12700 Uncompress the compressed values.
ac389d0c 12701 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
12702 (char_table_ref_and_range): Uncompress the compressed values.
12703 (sub_char_table_set): New arg is_uniprop. Callers changed.
12704 Uncompress the compressed values.
12705 (sub_char_table_set_range): Args changed. Callers changed.
12706 (char_table_set_range): Adjuted for the above change.
12707 (map_sub_char_table): Delete args default_val and parent. Add arg
12708 top. Give decoded values to a Lisp function.
640c8776 12709 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
12710 values to a Lisp function. Gcpro more variables.
12711 (uniprop_table_uncompress)
12712 (uniprop_decode_value_run_length): New functions.
12713 (uniprop_decoder, uniprop_decoder_count): New variables.
12714 (uniprop_get_decoder, uniprop_encode_value_character)
12715 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
12716 New functions.
12717 (uniprop_encoder, uniprop_encoder_count): New variables.
12718 (uniprop_get_encoder, uniprop_table)
12719 (Funicode_property_table_internal, Fget_unicode_property_internal)
12720 (Fput_unicode_property_internal): New functions.
12721 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
12722 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 12723 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
12724 char-code-property-alist.
12725
640c8776 12726 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
12727 Vunicode_category_table.
12728
640c8776 12729 * font.c (font_range): Adjust for the change of
c805dec0
KH
12730 Vunicode_category_table.
12731
76b397fb
DN
127322011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
12733
12734 * m/iris4d.h: Remove file, move contents ...
12735 * s/irix6-5.h: ... here.
12736
22b4128e
PE
127372011-07-06 Paul Eggert <eggert@cs.ucla.edu>
12738
12739 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
12740 * alloc.c (mark_buffer):
12741 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
12742 (clone_per_buffer_values): Don't assume that
22b4128e
PE
12743 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
12744 This isn't true in general, and it's particularly not true
12745 if Emacs is configured with --with-wide-int.
12746 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
12747 New macros, used in the buffer.c change.
12748
869795d6
JD
127492011-07-05 Jan Djärv <jan.h.d@swipnet.se>
12750
12751 * xsettings.c: Use both GConf and GSettings if both are available.
12752 (store_config_changed_event): Add comment.
12753 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
12754 (store_tool_bar_style_changed): New functions.
5e617bc2 12755 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
12756 (struct xsettings): Move font inside HAVE_XFT.
12757 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 12758 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 12759 Move inside HAVE_XFT.
640c8776 12760 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
12761 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
12762 also.
12763 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 12764 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 12765 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
12766 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
12767 (parse_settings): Move check for font inside HAVE_XFT.
12768 (read_settings, apply_xft_settings): Add comment.
12769 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
12770 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
12771 call store_font_name_changed.
12772 (xft_settings_event): Add comment.
12773 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
12774 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
12775 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
12776 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
12777 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
12778 (xsettings_get_system_font, xsettings_get_system_normal_font):
12779 Add comment.
869795d6 12780
d8ed26bd
PE
127812011-07-05 Paul Eggert <eggert@cs.ucla.edu>
12782
12783 Random fixes. E.g., (random) never returned negative values.
12784 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
12785 subseconds part to the entropy, as that's a bit more random.
12786 Prefer signed to unsigned, since the signedness doesn't matter and
12787 in general we prefer signed. When given a limit, use a
12788 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
12789 latter isn't right if USE_2_TAGS_FOR_INTS.
12790 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
12791 not 0..VALMASK. Don't discard "excess" bits that random () returns.
12792
cabf1cac
SM
127932011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
12794
12795 * textprop.c (text_property_stickiness):
12796 Obey Vtext_property_default_nonsticky.
12797 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
12798 * w32fns.c (syms_of_w32fns):
12799 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
12800
6e9b2be9
PE
128012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12802
12803 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
12804 This is more efficient than Ffile_directory_p and avoids a minor race.
12805
90186c68
LMI
128062011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
12807
7c301272
LMI
12808 * buffer.c (Foverlay_put): Say what the return value is
12809 (bug#7835).
12810
c4f2d8d4
LMI
12811 * fileio.c (barf_or_query_if_file_exists): Check first if the file
12812 is a directory before asking whether to use the file name
12813 (bug#7564).
ad637907
LMI
12814 (barf_or_query_if_file_exists): Make the "File is a directory"
12815 error be more correct.
c4f2d8d4 12816
90186c68
LMI
12817 * fns.c (Frequire): Remove the mention of the .gz files, since
12818 that's installation-specific, but keep the mention of
12819 `get-load-suffixes'.
12820
da64016e
PE
128212011-07-04 Paul Eggert <eggert@cs.ucla.edu>
12822
12823 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
12824 Report string overflow if the output is too long.
12825
7d47b580
JB
128262011-07-04 Juanma Barranquero <lekktu@gmail.com>
12827
a555cb87
JB
12828 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
12829 (syms_of_gnutls): Remove duplicate DEFSYM for
12830 Qgnutls_bootprop_verify_hostname_error, an error for
12831 Qgnutls_bootprop_verify_error (which is no longer used).
12832
7d47b580
JB
12833 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
12834 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
12835 Also (re)move comments that are misplaced or no longer relevant.
12836
1e49bfab
LMI
128372011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12838
12839 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
12840
1485f4c0
CY
128412011-07-03 Chong Yidong <cyd@stupidchicken.com>
12842
12843 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
12844 and background color parameters if they have been changed.
12845
a9ab721e
LMI
128462011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
12847
12848 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
12849
cf7cff57
PE
128502011-07-03 Paul Eggert <eggert@cs.ucla.edu>
12851
2e13213d
PE
12852 * xsettings.c (SYSTEM_FONT): Define only when used.
12853 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
12854
cf7cff57
PE
12855 * keymap.c (access_keymap_1): Now static.
12856
7a8e04f7
CY
128572011-07-02 Chong Yidong <cyd@stupidchicken.com>
12858
12859 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
12860 leave any prefix arg for the up event (Bug#1586).
12861
61352f62
LMI
128622011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
12863
69bb1ef7
LMI
12864 * lread.c (syms_of_lread): Mention single symbols defined by
12865 `defvar' or `defconst' (bug#7154).
12866
61352f62 12867 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 12868 (Frequire): Mention get-load-suffixes.
61352f62 12869
28545e04
MR
128702011-07-02 Martin Rudalics <rudalics@gmx.at>
12871
12872 * window.h (window): Remove clone_number slot.
12873 * window.c (Fwindow_clone_number, Fset_window_clone_number):
12874 Remove.
12875 (make_parent_window, make_window, saved_window)
12876 (Fset_window_configuration, save_window_save): Don't deal with
12877 clone numbers.
12878 * buffer.c (Qclone_number): Remove declaration.
12879 (sort_overlays, overlay_strings): Don't deal with clone numbers.
12880
3349e122
SM
128812011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
12882
12883 Add multiple inheritance to keymaps.
12884 * keymap.c (Fmake_composed_keymap): New function.
12885 (Fset_keymap_parent): Simplify.
12886 (fix_submap_inheritance): Remove.
12887 (access_keymap_1): New function extracted from access_keymap to handle
12888 embedded parents and handle lists of maps.
12889 (access_keymap): Use it.
12890 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
12891 (Fcopy_keymap): Handle embedded parents.
12892 (Fcommand_remapping, define_as_prefix): Simplify.
12893 (Fkey_binding): Simplify.
12894 (syms_of_keymap): Move minibuffer-local-completion-map,
12895 minibuffer-local-filename-completion-map,
12896 minibuffer-local-must-match-map, and
12897 minibuffer-local-filename-must-match-map to Elisp.
12898 (syms_of_keymap): Defsubr make-composed-keymap.
12899 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
12900 (parse_menu_item): Trivial simplification.
12901
3279eb87
GM
129022011-07-01 Glenn Morris <rgm@gnu.org>
12903
12904 * Makefile.in (SETTINGS_LIBS): Fix typo.
12905
39cb9e56 129062011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
12907
12908 * coding.c (Fencode_coding_string): Record the last coding system
12909 used, as the function doc string says (bug#8738).
12910
0949d2b6
JD
129112011-07-01 Jan Djärv <jan.h.d@swipnet.se>
12912
12913 * xsettings.c (store_monospaced_changed): Take new font as arg and
12914 check for change against current_mono_font.
12915 (EMACS_TYPE_SETTINGS): Remove this and related defines.
12916 (emacs_settings_constructor, emacs_settings_get_property)
12917 (emacs_settings_set_property, emacs_settings_class_init)
12918 (emacs_settings_init, gsettings_obj): Remove.
12919 (something_changedCB): New function for HAVE_GSETTINGS.
12920 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
12921 with value as argument.
12922 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
12923 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 12924 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
12925 "changed".
12926
12927 * xgselect.c: Add defined (HAVE_GSETTINGS).
12928 (xgselect_initialize): Ditto.
12929
12930 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
12931 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
12932 xg_select.
12933
bbc6b304
PE
129342011-07-01 Paul Eggert <eggert@cs.ucla.edu>
12935
12936 * eval.c (struct backtrace): Simplify and port the data structure.
12937 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
12938 signed bit field, as this assumption is not portable and it makes
12939 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
12940 "char debug_on_exit : 1" as this is not portable either; instead,
12941 use the portable "unsigned int debug_on_exit : 1". Remove unused
12942 member evalargs. Remove obsolete comments about cc bombing out.
12943
9851bfc5
JD
129442011-06-30 Jan Djärv <jan.h.d@swipnet.se>
12945
51bb811f 12946 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
12947 Let HAVE_GSETTINGS override HAVE_GCONF.
12948 (store_monospaced_changed): New function.
12949 (EMACS_SETTINGS): A new type derived from GObject to handle
12950 GSettings notifications.
12951 (emacs_settings_constructor, emacs_settings_get_property)
12952 (emacs_settings_set_property, emacs_settings_class_init):
12953 New functions.
12954 (gsettings_client, gsettings_obj): New variables.
12955 (GSETTINGS_SCHEMA): New define.
12956 (something_changedCB): Call store_monospaced_changed.
12957 (init_gsettings): New function.
12958 (xsettings_initialize): Call init_gsettings.
12959 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
12960 to NULL.
12961
640c8776 12962 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
12963 GCONF_CFLAGS/LIBS.
12964
5386012d
MR
129652011-06-29 Martin Rudalics <rudalics@gmx.at>
12966
12967 * window.c (resize_root_window, grow_mini_window)
12968 (shrink_mini_window): Rename Qresize_root_window to
12969 Qwindow_resize_root_window and Qresize_root_window_vertically to
12970 Qwindow_resize_root_window_vertically.
12971
f13e0b08
PE
129722011-06-28 Paul Eggert <eggert@cs.ucla.edu>
12973
12974 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
12975
94515237
JB
129762011-06-27 Juanma Barranquero <lekktu@gmail.com>
12977
12978 * makefile.w32-in: Redesign dependencies so they reflect more
12979 clearly which files are directly included by each source file,
12980 and not through other includes.
12981
e43b6e43
MR
129822011-06-27 Martin Rudalics <rudalics@gmx.at>
12983
12984 * buffer.c (Qclone_number): Declare static and DEFSYM it.
12985 (sort_overlays, overlay_strings): When an overlay's clone number
12986 matches the window's clone number process the overlay even if
12987 the overlay's window property doesn't match the current window.
12988
d68443dc
MR
12989 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
12990 (Fwindow_hchild): Rename to Fwindow_left_child.
12991 (Fwindow_next): Rename to Fwindow_next_sibling.
12992 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
12993 (resize_window_check): Rename to window_resize_check.
12994 (resize_window_apply): Rename to window_resize_apply.
12995 (Fresize_window_apply): Rename to Fwindow_resize_apply.
12996 (Fdelete_other_windows_internal, resize_frame_windows)
12997 (Fsplit_window_internal, Fdelete_window_internal)
12998 (grow_mini_window, shrink_mini_window)
12999 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 13000
c7e73be5
JD
130012011-06-26 Jan Djärv <jan.h.d@swipnet.se>
13002
13003 * emacsgtkfixed.h: State that this is only used with Gtk+3.
13004 (emacs_fixed_set_min_size): Remove.
13005 (emacs_fixed_new): Take frame as argument.
13006
13007 * emacsgtkfixed.c: State that this is only used with Gtk+3.
13008 (_EmacsFixedPrivate): Remove minwidth/height.
13009 Add struct frame *f.
13010 (emacs_fixed_init): Initialize priv->f.
13011 (get_parent_class, emacs_fixed_set_min_size): Remove.
13012 (emacs_fixed_new): Set priv->f to argument.
13013 (emacs_fixed_get_preferred_width)
13014 (emacs_fixed_get_preferred_height): Use min_width/height from
13015 frames size_hint to set minimum and natural (Bug#8919).
13016 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
13017 and use min_width/height from frames size_hint to set
13018 min_width/height (Bug#8919).
13019
13020 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
13021 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
13022 Fix indentation.
c7e73be5 13023
cf99dcf8
EZ
130242011-06-26 Eli Zaretskii <eliz@gnu.org>
13025
13026 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
13027 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
13028 called at ZV.
13029
029529ac
CY
130302011-06-26 Chong Yidong <cyd@stupidchicken.com>
13031
13032 * process.c (wait_reading_process_output): Bypass select if
13033 waiting for a cell while ignoring keyboard input, and input is
13034 pending. Suggested by Jan Djärv (Bug#8869).
13035
7a7ef429
PE
130362011-06-25 Paul Eggert <eggert@cs.ucla.edu>
13037
13038 Use gnulib's dup2 module instead of rolling our own.
13039 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
13040
11fdef7d 130412011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
13042
13043 * dispnew.c (scrolling_window): Before scrolling, turn off a
13044 mouse-highlight in the window being scrolled.
13045
cd3520a4
JB
130462011-06-24 Juanma Barranquero <lekktu@gmail.com>
13047
13048 Move DEFSYM to lisp.h and use everywhere.
13049
13050 * character.h (DEFSYM): Move declaration...
13051 * lisp.h (DEFSYM): ...here.
13052
13053 * gnutls.c:
13054 * minibuf.c:
13055 * w32menu.c:
13056 * w32proc.c:
13057 * w32select.c: Don't include character.h.
13058
13059 * alloc.c (syms_of_alloc):
13060 * buffer.c (syms_of_buffer):
13061 * bytecode.c (syms_of_bytecode):
13062 * callint.c (syms_of_callint):
13063 * casefiddle.c (syms_of_casefiddle):
13064 * casetab.c (init_casetab_once):
13065 * category.c (init_category_once, syms_of_category):
13066 * ccl.c (syms_of_ccl):
13067 * cmds.c (syms_of_cmds):
13068 * composite.c (syms_of_composite):
13069 * dbusbind.c (syms_of_dbusbind):
13070 * dired.c (syms_of_dired):
13071 * dispnew.c (syms_of_display):
13072 * doc.c (syms_of_doc):
13073 * editfns.c (syms_of_editfns):
13074 * emacs.c (syms_of_emacs):
13075 * eval.c (syms_of_eval):
13076 * fileio.c (syms_of_fileio):
13077 * fns.c (syms_of_fns):
13078 * frame.c (syms_of_frame):
13079 * fringe.c (syms_of_fringe):
13080 * insdel.c (syms_of_insdel):
13081 * keymap.c (syms_of_keymap):
13082 * lread.c (init_obarray, syms_of_lread):
13083 * macros.c (syms_of_macros):
13084 * msdos.c (syms_of_msdos):
13085 * print.c (syms_of_print):
13086 * process.c (syms_of_process):
13087 * search.c (syms_of_search):
13088 * sound.c (syms_of_sound):
13089 * syntax.c (init_syntax_once, syms_of_syntax):
13090 * terminal.c (syms_of_terminal):
13091 * textprop.c (syms_of_textprop):
13092 * undo.c (syms_of_undo):
13093 * w32.c (globals_of_w32):
13094 * window.c (syms_of_window):
13095 * xdisp.c (syms_of_xdisp):
13096 * xfaces.c (syms_of_xfaces):
13097 * xfns.c (syms_of_xfns):
13098 * xmenu.c (syms_of_xmenu):
13099 * xsettings.c (syms_of_xsettings):
13100 * xterm.c (syms_of_xterm): Use DEFSYM.
13101
4228cf16
TZ
131022011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
13103
cd3520a4 13104 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 13105
7fcccf1e
PE
131062011-06-23 Paul Eggert <eggert@cs.ucla.edu>
13107
7efb4e0e
PE
13108 Integer and buffer overflow fixes (Bug#8873).
13109
ff5844ad
PE
13110 * print.c (printchar, strout): Check for string overflow.
13111 (PRINTPREPARE, printchar, strout):
13112 Don't set size unless allocation succeeds.
13113
90532f02
PE
13114 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
13115 for sizes. Check for string overflow more accurately.
13116 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
13117
6d84508d
PE
13118 * macros.c: Integer and buffer overflow fixes.
13119 * keyboard.h (struct keyboard.kbd_macro_bufsize):
13120 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
13121 Use ptrdiff_t, not int, for sizes.
13122 Don't increment bufsize until after realloc succeeds.
13123 Check for size-calculation overflow.
13124 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
13125
437b2cb4
PE
13126 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
13127
8b9ac8b4
PE
13128 * lread.c: Integer overflow fixes.
13129 (read_integer): Radix is now EMACS_INT, not int,
13130 to improve quality of diagnostics for out-of-range radices.
13131 Calculate buffer size correctly for out-of-range radices.
13132 (read1): Check for integer overflow in radices, and in
13133 read-circle numbers.
82cb60d3
PE
13134 (read_escape): Avoid int overflow.
13135 (Fload, openp, read_buffer_size, read1)
13136 (substitute_object_recurse, read_vector, read_list, map_obarray):
13137 Use ptrdiff_t, not int, for sizes.
13138 (read1): Use EMACS_INT, not int, for sizes.
20270765 13139 Check for size overflow.
8b9ac8b4 13140
7fcccf1e
PE
13141 * image.c (cache_image): Check for size arithmetic overflow.
13142
bfbbd7e7
PE
13143 * lread.c: Integer overflow issues.
13144 (saved_doc_string_size, saved_doc_string_length)
13145 (prev_saved_doc_string_size, prev_saved_doc_string_length):
13146 Now ptrdiff_t, not int.
13147 (read1): Don't assume doc string length fits in int. Check for
13148 out-of-range doc string lengths.
13149 (read_list): Don't assume file position fits in int.
39019e54 13150 (read_escape): Check for hex character overflow.
bfbbd7e7 13151
4e323265
LL
131522011-06-22 Leo Liu <sdl.web@gmail.com>
13153
13154 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
13155 Move to minibuffer.el.
13156
85fece3e
PE
131572011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13158
20b84ce9 13159 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
13160 The following patches are for when GLYPH_DEBUG && !XASSERT.
13161 * dispextern.h (trace_redisplay_p, dump_glyph_string):
13162 * dispnew.c (flush_stdout):
13163 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
13164 Mark as externally visible.
13165 * dispnew.c (check_window_matrix_pointers): Now static.
13166 * dispnew.c (window_to_frame_vpos):
13167 * xfns.c (unwind_create_frame):
13168 * xterm.c (x_check_font): Remove unused local.
13169 * scroll.c (CHECK_BOUNDS):
13170 * xfaces.c (cache_fache): Rename local to avoid shadowing.
13171 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
13172 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
13173 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
13174 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
13175 Now static.
13176 (debug_method_add): Use va_list and vsprintf rather than relying
13177 on undefined behavior with wrong number of arguments.
13178 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
13179 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
13180 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
13181 since we're not interested in debugging glyphs with old libraries.
13182 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
13183 GCC 4.6.0's static checking.
13184
0766b489
PE
131852011-06-22 Paul Eggert <eggert@cs.ucla.edu>
13186
31fd4b32
PE
13187 Integer overflow and signedness fixes (Bug#8873).
13188 A few related buffer overrun fixes, too.
13189
b79e8648
PE
13190 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
13191
0766b489
PE
13192 * dispextern.h (struct face.stipple):
13193 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
13194 (x_bitmap_mask, x_allocate_bitmap_record)
13195 (x_create_bitmap_from_data, x_create_bitmap_from_file)
13196 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
13197 (x_create_bitmap_from_xpm_data):
13198 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
13199 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
13200 (.bitmaps_last):
13201 * xfaces.c (load_pixmap):
13202 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
13203 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
13204 (.bitmaps_last, struct x_output.icon_bitmap):
13205 Use ptrdiff_t, not int, for bitmap indexes.
13206 (x_allocate_bitmap_record): Check for size overflow.
13207 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
13208
b081724f
PE
13209 Use ptrdiff_t, not int, for overlay counts.
13210 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
13211 * editfns.c (overlays_around, get_pos_property):
13212 * textprop.c (get_char_property_and_overlay):
13213 * xdisp.c (next_overlay_change, note_mouse_highlight):
13214 * xfaces.c (face_at_buffer_position):
21514da7
PE
13215 * buffer.c (OVERLAY_COUNT_MAX): New macro.
13216 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
13217 (Fnext_overlay_change, Fprevious_overlay_change)
13218 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13219 Use ptrdiff_t, not int, for sizes.
21514da7 13220 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 13221
3de73e5e
PE
13222 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
13223
2606c57b
PE
13224 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
13225 (x_session_initialize): Do not assume string length fits in int.
13226
aaafe47a
PE
13227 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
13228 This is unlikely, but can occur if DPI is outlandish.
13229
2674ddc8 13230 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
13231 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
13232
28154962
PE
13233 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
13234 * xrdb.c (magic_file_p, search_magic_path):
13235 Omit last arg SUFFIX; it was always 0. All callers changed.
13236 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
13237
7de51af5
PE
13238 * xfont.c (xfont_match): Avoid need for strlen.
13239
25ed6cc3
PE
13240 * xfns.c: Don't assume strlen fits in int.
13241 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
13242
4eab31dd
PE
13243 * xdisp.c (message_log_check_duplicate): Return intmax_t,
13244 not unsigned long, as we prefer signed integers. All callers changed.
13245 Detect integer overflow in repeat count.
13246 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 13247 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 13248
171e2a58
PE
13249 * termcap.c: Don't assume sizes fit in int and never overflow.
13250 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
13251 (gobble_line): Check for size-calculation overflow.
13252
ad39faca 13253 * minibuf.c (Fread_buffer):
6e5bb2dc 13254 * lread.c (intern, intern_c_string):
74ca2eb3
PE
13255 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
13256 Don't assume string length fits in int.
13257
52c61c22 13258 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
13259 * gtkutil.c (style_changed_cb): Avoid need for strlen.
13260
b5b8c9e5
PE
13261 * font.c: Don't assume string length fits in int.
13262 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
13263 Use ptrdiff_t, not int.
ccd6111c
PE
13264 (font_intern_prop): Don't assume string length fits in int.
13265 Don't assume integer property fits in fixnum.
13266 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 13267
882f0d81 13268 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 13269 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
13270 Reformulate so as not to need the command string.
13271 Invoke gzip -cd rather than gunzip, as it's more portable.
13272 (lock_info_type, lock_file_1, lock_file):
13273 Don't assume pid_t and time_t fit in unsigned long.
13274 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
13275 (current_lock_owner): Prefer signed type for sizes.
13276 Use memcpy, not strncpy, where memcpy is what is really wanted.
13277 Don't assume (via atoi) that time_t and pid_t fit in int.
13278 Check for time_t and/or pid_t out of range, e.g., via a network share.
13279 Don't alloca where an auto var works fine.
13280
93f4cf88
PE
13281 * fileio.c: Fix some integer overflow issues.
13282 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
13283 Don't assume string length fits in int.
13284 (directory_file_name): Don't assume string length fits in long.
13285 (make_temp_name): Don't assume pid fits in int, or that its print
13286 length is less than 20.
13287
f3e92b69
PE
13288 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
13289
1bfdaf10
PE
13290 * coding.c (make_subsidiaries): Don't assume string length fits in int.
13291
35016e9a
PE
13292 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
13293
3d1e65a1
PE
13294 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
13295 We prefer signed integers, even for size calculations.
13296
0b963a93
PE
13297 * emacs.c: Don't assume string length fits in 'int'.
13298 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
13299 (main): Don't invoke strlen when not needed.
13300
573f4b54
PE
13301 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
13302 (XD_DEBUG_MESSAGE): Don't waste a byte.
13303
989f33ba
PE
13304 * callproc.c (getenv_internal_1, getenv_internal)
13305 (Fgetenv_internal):
965d34eb
PE
13306 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
13307
e4d29b33
PE
13308 * lread.c (invalid_syntax): Omit length argument.
13309 All uses changed. This doesn't fix a bug, but it simplifies the
13310 code away from its former Hollerith-constant appearance, and it's
13311 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 13312 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 13313
eb49b136
PE
13314 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
13315 This didn't break anything, but it didn't help either.
13316 It's confusing to put a bogus integer in a place where the actual
13317 value does not matter.
9f62aeb1 13318 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 13319 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 13320
15375a22
PE
13321 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
13322 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
13323 implementation.
b61cc01c
PE
13324 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
13325 We prefer signed types, and the value cannot exceed the EMACS_INT
13326 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
13327 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
13328 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
13329 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 13330
53b2623d
PE
13331 * indent.c (sane_tab_width): New function.
13332 (current_column, scan_for_column, Findent_to, position_indentation)
13333 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 13334 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 13335
51cab52b 13336 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 13337
f2ed8a70
PE
13338 * lisp.h (lint_assume): New macro.
13339 * composite.c (composition_gstring_put_cache):
13340 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
13341
abe80cc6
PE
13342 * editfns.c, insdel.c:
13343 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 13344
b02c740e
PE
13345 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
13346
ebc96716
PE
13347 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
13348
b4e50fa0 13349 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 13350 Use much-faster test for byte-length change.
311d5d7c 13351 Don't assume string byte-length fits in 'int'.
a4cf38e4 13352 Check that character arg fits in 'int'.
85461888 13353 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 13354
c0c1ee9f
PE
13355 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
13356
a498d7f4
PE
13357 * fns.c (concat): Catch string overflow earlier.
13358 Do not rely on integer wraparound.
13359
51cab52b
PE
13360 * dispextern.h (struct it.overlay_strings_charpos)
13361 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
13362 * xdisp.c (forward_to_next_line_start)
13363 (back_to_previous_visible_line_start)
13364 (reseat_at_next_visible_line_start, next_element_from_buffer):
13365 Don't arbitrarily truncate the value of 'selective' to int.
13366
76031fad
PE
13367 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
13368
5eb55db9
PE
13369 * composite.c: Don't truncate sizes to 'int'.
13370 (composition_gstring_p, composition_reseat_it)
13371 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
13372 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
13373 not EMACS_UINT, for indexes.
5eb55db9 13374
0703a717
PE
13375 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
13376
d6202519
PE
13377 * buffer.c: Include <verify.h>.
13378 (struct sortvec.priority, struct sortstr.priority):
8961a454 13379 Now EMACS_INT, not int.
c20998a7 13380 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
13381 (struct sortstr.size, record_overlay_string)
13382 (struct sortstrlist.size, struct sortlist.used):
13383 Don't truncate size to int.
13384 (record_overlay_string): Check for size-calculation overflow.
d6202519 13385 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 13386
d5a19415
JM
133872011-06-22 Jim Meyering <meyering@redhat.com>
13388
029529ac 13389 Don't leak an XBM-image-sized buffer
d5a19415
JM
13390 * image.c (xbm_load): Free the image buffer after using it.
13391
a9041e6c
PE
133922011-06-21 Paul Eggert <eggert@cs.ucla.edu>
13393
13394 Port to Sun C.
13395 * composite.c (find_automatic_composition): Omit needless 'return 0;'
13396 that Sun C diagnosed.
13397 * fns.c (secure_hash): Fix pointer signedness issue.
13398 * intervals.c (static_offset_intervals): New function.
13399 (offset_intervals): Use it.
13400
7f3f739f
LL
134012011-06-21 Leo Liu <sdl.web@gmail.com>
13402
13403 * deps.mk (fns.o):
13404 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
13405 sha512.h.
13406
13407 * fns.c (secure_hash): Rename from crypto_hash_function and change
13408 the first arg to accept symbols.
5b66d427 13409 (Fsecure_hash): New primitive.
7f3f739f
LL
13410 (syms_of_fns): New symbols.
13411
76147d94
DD
134122011-06-20 Deniz Dogan <deniz@dogan.se>
13413
13414 * process.c (Fset_process_buffer): Clarify return value in
13415 docstring.
13416
7d7d0045
CY
134172011-06-18 Chong Yidong <cyd@stupidchicken.com>
13418
13419 * dispnew.c (add_window_display_history): Use BVAR.
13420
13421 * xdisp.c (debug_method_add): Use BVAR.
13422 (check_window_end, dump_glyph_matrix, dump_glyph)
13423 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
13424
13425 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
13426 Likewise.
13427
13428 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
13429 check till after the cache is created in init_frame_faces.
13430
ff2bc410
SM
134312011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
13432
13433 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
13434
28177add
PE
134352011-06-16 Paul Eggert <eggert@cs.ucla.edu>
13436
dd3482fe
PE
13437 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
13438 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
13439 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
13440
393d71f3 13441 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13442 * fileio.c (Finsert_file_contents):
13443 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
13444 Remove the old (too-loose) buffer overflow checks.
13445 They weren't needed, since make_gap checks for buffer overflow.
13446 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
13447 The old code merely checked for Emacs fixnum overflow, and relied
13448 on undefined (wraparound) behavior. The new code avoids undefined
13449 behavior, and also checks for ptrdiff_t and/or size_t overflow.
13450
2e6813b0 13451 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
13452 Tune. Don't use wider integers than needed. Don't use alloca.
13453 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 13454
599a9e4f
PE
13455 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
13456
99561444
PE
13457 * insdel.c, lisp.h (buffer_overflow): New function.
13458 (insert_from_buffer_1, replace_range, replace_range_2):
13459 * insdel.c (make_gap_larger):
13460 * editfns.c (Finsert_char):
13461 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
13462
28177add
PE
13463 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
13464
e69dafad
PE
134652011-06-15 Paul Eggert <eggert@cs.ucla.edu>
13466
4baa020d 13467 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 13468
b1c46f02
PE
13469 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
13470 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
13471
e69dafad
PE
13472 * fileio.c: Don't assume EMACS_INT fits in off_t.
13473 (emacs_lseek): New static function.
13474 (Finsert_file_contents, Fwrite_region): Use it.
13475 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
13476
566684ea
PE
13477 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
13478
e6966cd6
PE
13479 * fns.c: Don't overflow int when computing a list length.
13480 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
13481 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
13482 truncation on 64-bit hosts. Check for QUIT every
13483 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
13484 faster and is responsive enough.
13485 (Flength): Report an error instead of overflowing an integer.
13486 (Fsafe_length): Return a float if the value is not representable
13487 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 13488 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 13489 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 13490
dd0b0efb
PE
13491 * alloc.c: Check that resized vectors' lengths fit in fixnums.
13492 (header_size, word_size): New constants.
13493 (allocate_vectorlike): Don't check size overflow here.
13494 (allocate_vector): Check it here instead, since this is the only
13495 caller of allocate_vectorlike that could cause overflow.
13496 Check that the new vector's length is representable as a fixnum.
13497
86fe5cfe
PE
13498 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
13499 The previous code was bogus. For example, next_almost_prime (32)
13500 returned 39, which is undesirable as it is a multiple of 3; and
13501 next_almost_prime (24) returned 25, which is a multiple of 5 so
13502 why was the code bothering to check for multiples of 7?
13503
80e88859
PE
13504 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
13505
4a2f0ad6
PE
13506 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
13507
f66c7cf8
PE
13508 Variadic C functions now count arguments with ptrdiff_t.
13509 This partly undoes my 2011-03-30 change, which replaced int with size_t.
13510 Back then I didn't know that the Emacs coding style prefers signed int.
13511 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
13512 were being counted with int, which may truncate counts on 64-bit
13513 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
13514 * lisp.h (struct Lisp_Subr.function.aMANY)
13515 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
13516 Arg counts are now ptrdiff_t, not size_t.
13517 All variadic functions and their callers changed accordingly.
13518 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
13519 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
13520 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
13521 * callint.c (Fcall_interactively): Check arg count for overflow,
13522 to avoid potential buffer overrun. Use signed char, not 'int',
13523 for 'varies' array, so that we needn't bother to check its size
13524 calculation for overflow.
13525 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
13526 * eval.c (apply_lambda):
13527 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
13528 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
13529 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
13530
a1759b76
PE
13531 * callint.c (Fcall_interactively): Don't use index var as event count.
13532
d96be9fc
PE
13533 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
13534 * mem-limits.h (SIZE): Remove; no longer used.
13535
a690a978 13536 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 13537
578c21e6
PE
13538 Remove unnecessary casts.
13539 * xterm.c (x_term_init):
13540 * xfns.c (x_set_border_pixel):
13541 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
13542 These aren't needed now that we assume ANSI C.
13543
96f53c6c
PE
13544 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
13545 It's more likely to cause problems (due to unsigned overflow)
13546 than to cure them.
13547
83c77d31
PE
13548 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
13549
ee2079f1
PE
13550 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
13551
6da65536
PE
13552 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
13553
7147c4a4
PE
13554 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
13555
193e32d9
PE
13556 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
13557
e5533da6
PE
13558 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
13559
9910e595
PE
13560 GLYPH_CODE_FACE returns EMACS_INT, not int.
13561 * dispextern.h (merge_faces):
13562 * xfaces.c (merge_faces):
01103c44
PE
13563 * xdisp.c (get_next_display_element, next_element_from_display_vector):
13564 Don't assume EMACS_INT fits in int.
9910e595 13565
2638320e
PE
13566 * character.h (CHAR_VALID_P): Remove unused parameter.
13567 * fontset.c, lisp.h, xdisp.c: All uses changed.
13568
045eb8d9
PE
13569 * editfns.c (Ftranslate_region_internal): Omit redundant test.
13570
c1f134b5
PE
13571 * fns.c (concat): Minor tuning based on overflow analysis.
13572 This doesn't fix any bugs. Use int to hold character, instead
13573 of constantly refetching from Emacs object. Use XFASTINT, not
13574 XINT, for value known to be a character. Don't bother comparing
13575 a single byte to 0400, as it's always less.
13576
395fcb93 13577 * floatfns.c (Fexpt):
327eeec8
PE
13578 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
13579
abbd3d23
PE
13580 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
13581 for characters.
13582
684a03ef
PE
13583 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
13584
0fed43f3
PE
13585 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
13586 Without this fix, on a 64-bit host (aset S 0 4294967386) would
13587 incorrectly succeed when S was a string, because 4294967386 was
13588 truncated before it was used.
13589
8fd02eb7
PE
13590 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
13591 Otherwise, an out-of-range integer could cause undefined behavior
13592 on a 64-bit host.
13593
f8c86b69
PE
13594 * composite.c: Use int, not EMACS_INT, for characters.
13595 (fill_gstring_body, composition_compute_stop_pos): Use int, not
13596 EMACS_INT, for values that are known to be in character range.
13597 This doesn't fix any bugs but is the usual style inside Emacs and
13598 may generate better code on 32-bit machines.
13599
34206dd2
PE
13600 Make sure a 64-bit char is never passed to ENCODE_CHAR.
13601 This is for reasons similar to the recent CHAR_STRING fix.
13602 * charset.c (Fencode_char): Check that character arg is actually
13603 a character. Pass an int to ENCODE_CHAR.
13604 * charset.h (ENCODE_CHAR): Verify that the character argument is no
13605 wider than 'int', as a compile-time check to prevent future regressions
13606 in this area.
13607
c5958d4c 13608 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
13609
13610 Make sure a 64-bit char is never passed to CHAR_STRING.
13611 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
13612 by silently ignoring the top 32 bits, allowing some values
13613 that were far too large to be valid characters.
13614 * character.h: Include <verify.h>.
13615 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
13616 arguments are no wider than unsigned, as a compile-time check
13617 to prevent future regressions in this area.
13618 * data.c (Faset):
01103c44 13619 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
13620 (Fsubst_char_in_region):
13621 * fns.c (concat):
13622 * xdisp.c (decode_mode_spec_coding):
13623 Adjust to CHAR_STRING's new requirement.
13624 * editfns.c (Finsert_char, Fsubst_char_in_region):
13625 * fns.c (concat): Check that character args are actually
13626 characters. Without this test, these functions did the wrong
13627 thing with wildly out-of-range values on 64-bit hosts.
13628
d37ca623
PE
13629 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
13630 These casts should not be needed on 32-bit hosts, either.
13631 * keyboard.c (read_char):
13632 * lread.c (Fload): Remove casts to unsigned.
13633
ea204efb
PE
13634 * lisp.h (UNSIGNED_CMP): New macro.
13635 This fixes comparison bugs on 64-bit hosts.
13636 (ASCII_CHAR_P): Use it.
13637 * casefiddle.c (casify_object):
01103c44 13638 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
13639 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
13640 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
13641 * dispextern.h (FACE_FROM_ID):
13642 * keyboard.c (read_char): Use UNSIGNED_CMP.
13643
41cb286c
PE
13644 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
13645 not to EMACS_INT, to avoid GCC warning.
13646
4a1b9832
PE
13647 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
13648
55daad71
PE
13649 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
13650 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
13651 isn't needed on 32-bit machines.
8f95c75c 13652
01103c44
PE
13653 * buffer.c (Fgenerate_new_buffer_name):
13654 Use EMACS_INT for count, not int.
0ceccced 13655 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
13656
13657 * data.c (Qcompiled_function): Now static.
13658
c6f072e7
PE
13659 * window.c (window_body_lines): Now static.
13660
20ce5912
PE
13661 * image.c (gif_load): Rename local to avoid shadowing.
13662
9c4c5f81
PE
13663 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
13664 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
13665 * alloc.c (make_save_value): Integer argument is now of type
13666 ptrdiff_t, not int.
13667 (mark_object): Use ptrdiff_t, not int.
13668 * lisp.h (pD): New macro.
13669 * print.c (print_object): Use it.
13670
c0c5c8ae
PE
13671 * alloc.c: Use EMACS_INT, not int, to count objects.
13672 (total_conses, total_markers, total_symbols, total_vector_size)
13673 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
13674 (total_free_floats, total_floats, total_free_intervals)
13675 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
13676 Now EMACS_INT, not int. All uses changed.
13677 (Fgarbage_collect): Compute overall total using a double, so that
13678 integer overflow is less likely to be a problem. Check for overflow
13679 when converting back to an integer.
5a25e253
PE
13680 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
13681 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
13682 These were 'int' variables that could overflow on 64-bit hosts;
13683 they were never used, so remove them instead of repairing them.
211a0b2a 13684 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
13685 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
13686 Previously, this ceilinged at INT_MAX, but that doesn't work on
13687 64-bit machines.
e46bb31a 13688 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 13689
c78baabf 13690 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 13691 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
13692 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
13693 when a (possibly-narrower) signed value would do just as well.
13694 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 13695
c9d624c6
PE
13696 * alloc.c: Catch some string size overflows that we were missing.
13697 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
13698 for convenience in STRING_BYTES_MAX.
13699 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
13700 The definition here is exact; the one in lisp.h was approximate.
13701 (allocate_string_data): Check for string overflow. This catches
13702 some instances we weren't catching before. Also, it catches
13703 size_t overflow on (unusual) hosts where SIZE_MAX <= min
13704 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
13705 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 13706
c9d624c6
PE
13707 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
13708 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 13709 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 13710
353032ce
PE
13711 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
13712
2bccce07
PE
13713 * alloc.c (Fmake_string): Check for out-of-range init.
13714
0ac30604
SM
137152011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
13716
13717 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
13718
c195f2de
JD
137192011-06-14 Jan Djärv <jan.h.d@swipnet.se>
13720
13721 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
13722 xg_get_default_scrollbar_width.
13723
13724 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
13725 (int_gtk_range_get_value): Move to the scroll bar part of the file.
13726 (style_changed_cb): Call update_theme_scrollbar_width and call
13727 x_set_scroll_bar_default_width and xg_frame_set_char_size for
13728 all frames (Bug#8505).
13729 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
13730 Call gtk_window_set_resizable if HAVE_GTK3.
13731 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
13732 and height if HAVE_GTK3 (Bug#8505).
13733 (scroll_bar_width_for_theme): New variable.
13734 (update_theme_scrollbar_width): New function.
13735 (xg_get_default_scrollbar_width): Move code to
13736 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
13737 (xg_initialize): Call update_theme_scrollbar_width.
13738
13739 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
13740
13741 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
13742
e10ac9f1
MR
137432011-06-12 Martin Rudalics <rudalics@gmx.at>
13744
13745 * frame.c (make_frame): Call other_buffer_safely instead of
13746 other_buffer.
13747
13748 * window.c (temp_output_buffer_show): Call display_buffer with
13749 second argument Vtemp_buffer_show_specifiers and reset latter
13750 immediately after the call.
13751 (Vtemp_buffer_show_specifiers): New variable.
13752 (auto_window_vscroll_p, next_screen_context_lines)
13753 (Vscroll_preserve_screen_position): Remove leading asterisks from
13754 doc-strings.
13755
2d3c217e 137562011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 13757
7b7f97e8 13758 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
13759 * buffer.c (Qclone_number): Remove for now, as it's unused.
13760 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
13761 (record_buffer): Remove unused local.
13762 * frame.c (other_visible_frames, frame_buffer_list): Now static.
13763 (set_frame_buffer_list): Remove; unused.
13764 * frame.h (other_visible_frames): Remove decl.
13765 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
13766 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
13767 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
13768 if HAVE_GPM.
13769 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
13770 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
13771 Define only if HAVE_GPM.
13772 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
13773 (update_hints_inhibit): Remove; never set. All uses removed.
13774 * widgetprv.h (emacsFrameClassRec): Remove decl.
13775 * window.c (delete_deletable_window): Now returns void, since it
13776 wasn't returning anything.
13777 (compare_window_configurations): Remove unused locals.
13778 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
13779 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
13780 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
13781 the same widths as pointers. This follows up on the 2011-05-06 patch.
13782 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
13783 * xterm.h: Likewise.
13784 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
13785
1384b89e
JB
137862011-06-12 Juanma Barranquero <lekktu@gmail.com>
13787
13788 * makefile.w32-in: Update dependencies.
13789 (LISP_H): Add lib/intprops.h.
13790
1100a63c
CY
137912011-06-11 Chong Yidong <cyd@stupidchicken.com>
13792
13793 * image.c (gif_load): Add animation frame delay to the metadata.
13794 (syms_of_image): Use DEFSYM. New symbol `delay'.
13795
6198ccd0
MR
137962011-06-11 Martin Rudalics <rudalics@gmx.at>
13797
13798 * window.c (delete_deletable_window): Re-add.
13799 (Fset_window_configuration): Rewrite to handle dead buffers and
13800 consequently deletable windows.
13801 (window_tree, Fwindow_tree): Remove. Supply functionality in
13802 window.el.
13803 (compare_window_configurations): Simplify code.
13804
b6e3633c
AS
138052011-06-11 Andreas Schwab <schwab@linux-m68k.org>
13806
1ab0dee5
AS
13807 * image.c (imagemagick_load_image): Fix type mismatch.
13808 (Fimagemagick_types): Likewise.
13809
b6e3633c
AS
13810 * window.h (replace_buffer_in_windows): Declare.
13811
9397e56f
MR
138122011-06-11 Martin Rudalics <rudalics@gmx.at>
13813
13814 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
13815 Qclone_number. Remove external declaration of Qdelete_window.
13816 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
13817 code.
640c8776
SM
13818 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
13819 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
13820 (Fother_buffer): Rewrite doc-string. Major rewrite for new
13821 buffer list implementation.
13822 (other_buffer_safely): New function.
13823 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
13824 calls to replace_buffer_in_windows and
13825 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
13826 if allowed.
13827 (record_buffer): Inhibit quitting and rewrite using quittable
13828 functions. Run Qbuffer_list_update_hook if allowed.
13829 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
13830 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
13831 Move switch-to-buffer to window.el.
9397e56f
MR
13832 (bury-buffer): Move to window.el.
13833 (Vbuffer_list_update_hook): New variable.
13834
13835 * lisp.h (other_buffer_safely): Add prototype in buffer.c
13836 section.
13837
13838 * window.h (resize_frame_windows): Move up in code.
13839 (Fwindow_frame): Remove EXFUN.
13840 (replace_buffer_in_all_windows): Remove prototype.
13841 (replace_buffer_in_windows_safely): Add prototype.
13842
13843 * window.c: Declare Qdelete_window static again. Move down
13844 declaration of select_count.
13845 (Fnext_window, Fprevious_window): Rewrite doc-strings.
13846 (Fother_window): Move to window.el.
13847 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
13848 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
13849 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
13850 window.el.
13851 (replace_buffer_in_windows): Implement by calling
13852 Qreplace_buffer_in_windows.
13853 (replace_buffer_in_all_windows): Remove with some functionality
13854 moved into replace_buffer_in_windows_safely.
13855 (replace_buffer_in_windows_safely): New function.
13856 (select_window_norecord, select_frame_norecord): Move in front
13857 of run_window_configuration_change_hook. Remove now obsolete
13858 declarations.
640c8776
SM
13859 (Fset_window_buffer): Rewrite doc-string.
13860 Call Qrecord_window_buffer.
9397e56f
MR
13861 (keys_of_window): Move binding for other-window to window.el.
13862
b50691aa
CY
138632011-06-11 Chong Yidong <cyd@stupidchicken.com>
13864
13865 * dispextern.h (struct image): Replace data member, whose int_val
13866 and ptr_val fields were not used by anything, with a single
13867 lisp_val object.
13868
13869 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
13870 (gif_clear_image, gif_load, imagemagick_load_image)
13871 (gs_clear_image, gs_load): Callers changed.
13872
3f754b86
PE
138732011-06-10 Paul Eggert <eggert@cs.ucla.edu>
13874
cca69397
PE
13875 * buffer.h: Include <time.h>, for time_t.
13876 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
13877
109e28d0
PE
13878 Fix minor problems found by static checking.
13879
60737f02
PE
13880 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
13881
4b66faf3
PE
13882 Make identifiers static if they are not used in other modules.
13883 * data.c (Qcompiled_function, Qframe, Qvector):
13884 * image.c (QimageMagick, Qsvg):
13885 * minibuf.c (Qmetadata):
13886 * window.c (resize_window_check, resize_root_window): Now static.
13887 * window.h (resize_window_check, resize_root_window): Remove decls.
13888
109e28d0
PE
13889 * window.c (window_deletion_count, delete_deletable_window):
13890 Remove; unused.
46a4ce9e
PE
13891 (window_body_lines): Now static.
13892 (Fdelete_other_windows_internal): Mark vars as initialized.
13893 Make sure 'resize_failed' is initialized.
13894 (run_window_configuration_change_hook): Rename local to avoid shadowing.
13895 (resize_window_apply): Remove unused local.
13896 * window.h (delete_deletable_window): Remove decl.
13897
109e28d0 13898 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
13899 (imagemagick_load_image): Fix pointer signedness problem by changing
13900 last arg from unsigned char * to char *. All uses changed.
13901 Also, fix a local for similar reasons.
13902 Remove unused locals. Remove locals to avoid shadowing.
13903 (fn_rsvg_handle_free): Remove; unused.
13904 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 13905 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 13906
3f754b86
PE
13907 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
13908
2547adb1
CY
139092011-06-10 Chong Yidong <cyd@stupidchicken.com>
13910
13911 * image.c (gif_load): Fix omitted cast error introduced by
13912 2011-06-06 change.
13913
2c8e37d4
MR
139142011-06-10 Martin Rudalics <rudalics@gmx.at>
13915
13916 * window.h (resize_proportionally, orig_total_lines)
13917 (orig_top_line): Remove from window structure.
13918 (set_window_height, set_window_width, change_window_heights)
13919 (Fdelete_window): Remove prototypes.
13920 (resize_frame_windows): Remove duplicate declaration.
13921
440a42e3
EZ
139222011-06-10 Eli Zaretskii <eliz@gnu.org>
13923
13924 * window.h (resize_frame_windows, resize_window_check)
13925 (delete_deletable_window, resize_root_window)
13926 (resize_frame_windows): Declare prototypes.
13927
13928 * window.c (resize_window_apply): Make definition be "static" to
13929 match the prototype.
13930
562dd5e9
MR
139312011-06-10 Martin Rudalics <rudalics@gmx.at>
13932
13933 * window.c: Remove declarations of Qwindow_size_fixed,
13934 window_min_size_1, window_min_size_2, window_min_size,
13935 size_window, window_fixed_size_p, enlarge_window, delete_window.
13936 Remove static from declaration of Qdelete_window, it's
13937 temporarily needed by Fbury_buffer.
13938 (replace_window): Don't assign orig_top_line and
13939 orig_total_lines.
13940 (Fdelete_window, delete_window): Remove. Window deletion is
13941 handled by window.el.
640c8776
SM
13942 (window_loop): Remove DELETE_OTHER_WINDOWS case.
13943 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
13944 (Fdelete_other_windows): Remove. Deleting other windows is
13945 handled by window.el.
13946 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
13947 handled in window.el.
13948 (window_min_size_2, window_min_size_1, window_min_size): Remove.
13949 Window minimum sizes are handled in window.el.
13950 (shrink_windows, size_window, set_window_height)
13951 (set_window_width, change_window_heights, window_height)
13952 (window_width, CURBEG, CURSIZE, enlarge_window)
13953 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
13954 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
13955 handled in window.el.
13956 (make_dummy_parent): Rename to make_parent_window and give it a
13957 second argument horflag.
13958 (make_window): Don't set resize_proportionally any more.
13959 (Fsplit_window): Remove. Windows are split in window.el.
13960 (save_restore_action, save_restore_orig_size)
13961 (shrink_window_lowest_first, save_restore_orig_size): Remove.
13962 Resize mini windows in window.el.
13963 (grow_mini_window, shrink_mini_window): Implement by calling
13964 Qresize_root_window_vertically, resize_window_check and
13965 resize_window_apply.
640c8776
SM
13966 (saved_window, Fset_window_configuration, save_window_save):
13967 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
13968 resize_proportionally.
13969 (window_min_height, window_min_width): Move to window.el.
13970 (keys_of_window): Move bindings for delete-other-windows,
13971 split-window, delete-window and enlarge-window to window.el.
13972
13973 * buffer.c: Temporarily extern Qdelete_window.
13974 (Fbury_buffer): Temporarily call Qdelete_window instead of
13975 Fdelete_window (Fbury_buffer will move to window.el soon).
13976
13977 * frame.c (set_menu_bar_lines_1): Remove code handling
13978 orig_top_line and orig_total_lines.
13979
13980 * dispnew.c (adjust_frame_glyphs_initially): Don't use
13981 set_window_height but set heights directly.
13982 (change_frame_size_1): Use resize_frame_windows.
13983
13984 * xdisp.c (init_xdisp): Don't use set_window_height but set
13985 heights directly.
13986
640c8776
SM
13987 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
13988 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
13989 run_window_configuration_change_hook.
13990
13991 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
13992 instead of change_window_heights and run
13993 run_window_configuration_change_hook.
13994
1a13852e
MR
139952011-06-09 Martin Rudalics <rudalics@gmx.at>
13996
13997 * window.c (replace_window): Rename second argument REPLACEMENT to
13998 NEW. New third argument SETFLAG. Rewrite.
13999 (delete_window, make_dummy_parent): Call replace_window with
14000 third argument 1.
14001 (window_list_1): Move down in code.
14002 (run_window_configuration_change_hook): Move set_buffer part
14003 before select_frame_norecord part in order to unwind correctly.
14004 Rename count1 to count.
14005 (recombine_windows, delete_deletable_window, resize_root_window)
14006 (Fdelete_other_windows_internal)
14007 (Frun_window_configuration_change_hook, make_parent_window)
14008 (resize_window_check, resize_window_apply, Fresize_window_apply)
14009 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
14010 (Fdelete_window_internal, Fresize_mini_window_internal):
14011 New functions.
1a13852e
MR
14012 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
14013
f3d1777e
MR
140142011-06-08 Martin Rudalics <rudalics@gmx.at>
14015
496e208e
MR
14016 * window.h (window): Add some new members to window structure -
14017 normal_lines, normal_cols, new_total, new_normal, clone_number,
14018 splits, nest, prev_buffers, next_buffers.
14019 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 14020 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 14021
f3d1777e
MR
14022 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
14023 Remove.
496e208e
MR
14024 (make_dummy_parent): Set new members of windows structure.
14025 (make_window): Move down in code. Handle new members of window
14026 structure.
14027 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
14028 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
14029 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
14030 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
14031 (Fset_window_next_buffers, Fset_window_clone_number):
14032 New functions.
496e208e
MR
14033 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
14034 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
14035 Doc-string fixes.
14036 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
14037 Argument WINDOW can be now internal window too.
14038 (Fwindow_use_time): Move up in code.
14039 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
14040 Rewrite doc-string.
14041 (Fset_window_configuration, saved_window)
14042 (Fcurrent_window_configuration, save_window_save): Handle new
14043 members of window structure.
b9e809c2
MR
14044 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
14045 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
14046 (syms_of_window): New Lisp objects Qrecord_window_buffer,
14047 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
14048 Qget_mru_window, Qresize_root_window,
14049 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
14050 Qauto_buffer_name; staticpro them.
f3d1777e 14051
abde8f8c
MR
140522011-06-07 Martin Rudalics <rudalics@gmx.at>
14053
14054 * window.c (Fwindow_total_size, Fwindow_left_column)
14055 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
14056 (Fwindow_list_1): New functions.
14057 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
14058 (Fwindow_width, Fscroll_left, Fscroll_right):
14059 Use window_body_cols instead of window_box_text_cols.
14060 (delete_window, Fset_window_configuration):
14061 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
14062 (delete_all_subwindows): Take a window as argument and not a
14063 structure. Rewrite.
190b47e6
MR
14064 (window_loop): Remove handling of GET_LRU_WINDOW and
14065 GET_LARGEST_WINDOW.
14066 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
14067
14068 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
14069 window_box_text_cols. delete_all_subwindows now takes a
14070 Lisp_Object as argument.
abde8f8c 14071
640c8776
SM
14072 * indent.c (compute_motion, Fcompute_motion):
14073 Use window_body_cols instead of window_box_text_cols.
abde8f8c 14074
fa8a67e6
MR
14075 * frame.c (delete_frame): Call delete_all_subwindows with root
14076 window as argument.
14077
a54e3482
DC
140782011-06-07 Daniel Colascione <dan.colascione@gmail.com>
14079
14080 * fns.c (Fputhash): Document return value.
14081
60002bf5
CY
140822011-06-06 Chong Yidong <cyd@stupidchicken.com>
14083
14084 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14085
0c671da6 140862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 14087
b862a52a 14088 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 14089
be44ca6c
PE
14090 Check for overflow when converting integer to cons and back.
14091 * charset.c (Fdefine_charset_internal, Fdecode_char):
14092 Use cons_to_unsigned to catch overflow.
14093 (Fencode_char): Use INTEGER_TO_CONS.
14094 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
14095 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
14096 * data.c (long_to_cons, cons_to_long): Remove.
14097 (cons_to_unsigned, cons_to_signed): New functions.
14098 These signal an error for invalid or out-of-range values.
14099 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
14100 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14101 * font.c (Ffont_variation_glyphs):
14102 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
14103 * lisp.h: Include <intprops.h>.
14104 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
14105 (cons_to_signed, cons_to_unsigned): New decls.
14106 (long_to_cons, cons_to_long): Remove decls.
14107 * undo.c (record_first_change): Use INTEGER_TO_CONS.
14108 (Fprimitive_undo): Use CONS_TO_INTEGER.
14109 * xfns.c (Fx_window_property): Likewise.
14110 * xselect.c: Include <limits.h>.
14111 (x_own_selection, selection_data_to_lisp_data):
14112 Use INTEGER_TO_CONS.
14113 (x_handle_selection_request, x_handle_selection_clear)
14114 (x_get_foreign_selection, Fx_disown_selection_internal)
14115 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
14116 (lisp_data_to_selection_data): Use cons_to_unsigned.
14117 (x_fill_property_data): Use cons_to_signed.
14118 Report values out of range.
14119
d1f3d2af
PE
14120 Check for buffer and string overflow more precisely.
14121 * buffer.h (BUF_BYTES_MAX): New macro.
14122 * lisp.h (STRING_BYTES_MAX): New macro.
14123 * alloc.c (Fmake_string):
14124 * character.c (string_escape_byte8):
14125 * coding.c (coding_alloc_by_realloc):
14126 * doprnt.c (doprnt):
14127 * editfns.c (Fformat):
14128 * eval.c (verror):
14129 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
14130 since they may not be the same number.
14131 * editfns.c (Finsert_char):
14132 * fileio.c (Finsert_file_contents):
14133 Likewise for BUF_BYTES_MAX.
14134
dd52fcea
PE
14135 * image.c: Use ptrdiff_t, not int, for sizes.
14136 (slurp_file): Switch from int to ptrdiff_t.
14137 All uses changed.
14138 (slurp_file): Check that file size fits in both size_t (for
14139 malloc) and ptrdiff_t (for sanity and safety).
14140
7f9bbdbb
PE
14141 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
14142 if b->modtime has its maximal value.
14143
dfe18f82
PE
14144 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
14145
84acfcf0
PE
14146 Don't assume time_t can fit into int.
14147 * buffer.h (struct buffer.modtime): Now time_t, not int.
14148 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
14149 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
14150
ccd9a01a
PE
14151 Minor fixes for signed vs unsigned integers.
14152 * character.h (MAYBE_UNIFY_CHAR):
14153 * charset.c (maybe_unify_char):
14154 * keyboard.c (read_char, reorder_modifiers):
14155 XINT -> XFASTINT, since the integer must be nonnegative.
14156 * ftfont.c (ftfont_spec_pattern):
14157 * keymap.c (access_keymap, silly_event_symbol_error):
14158 XUINT -> XFASTINT, since the integer must be nonnegative.
14159 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
14160 since it makes no difference and we prefer signed.
14161 * keyboard.c (record_char): Use XUINT when all the neighbors do.
14162 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
14163 nonnegative.
14164
d6d100dd
SM
141652011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
14166
14167 * window.h (Fwindow_frame): Declare.
14168
2b6148e4
PE
141692011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14170
14171 * alloc.c: Simplify handling of large-request failures (Bug#8800).
14172 (SPARE_MEMORY): Always define.
14173 (LARGE_REQUEST): Remove.
14174 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
14175
f230ecc9
MR
141762011-06-06 Martin Rudalics <rudalics@gmx.at>
14177
727e958e
MR
14178 * lisp.h: Move EXFUNS for Fframe_root_window,
14179 Fframe_first_window and Fset_frame_selected_window to window.h.
14180
14181 * window.h: Move EXFUNS for Fframe_root_window,
14182 Fframe_first_window and Fset_frame_selected_window here from
14183 lisp.h.
14184
14185 * frame.c (Fwindow_frame, Fframe_first_window)
14186 (Fframe_root_window, Fframe_selected_window)
14187 (Fset_frame_selected_window): Move to window.c.
14188 (Factive_minibuffer_window): Move to minibuf.c.
14189 (Fother_visible_frames_p): New function.
14190
14191 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
14192
f230ecc9
MR
14193 * window.c (decode_window, decode_any_window): Move up in code.
14194 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
14195 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
14196 (Fwindow_buffer): Move up and rewrite doc-string.
14197 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
14198 (Fwindow_prev): New functions.
727e958e
MR
14199 (Fwindow_frame): Move here from frame.c. Accept any window as
14200 argument.
14201 (Fframe_root_window, Fframe_first_window)
14202 (Fframe_selected_window): Move here from frame.c. Accept frame
14203 or arbitrary window as argument. Update doc-strings.
14204 (Fminibuffer_window): Move up in code.
14205 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
14206 (Fset_frame_selected_window): Move here from frame.c.
14207 Marginal rewrite.
727e958e
MR
14208 (Fselected_window, select_window, Fselect_window): Move up in
14209 code. Minor doc-string fixes.
f230ecc9 14210
4d09bcf6
PE
142112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
14212
14213 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
14214 Do not assume that spare memory exists; that assumption is valid
14215 only if SYSTEM_MALLOC.
14216 (LARGE_REQUEST): New macro, so that the issue of large requests
14217 is separated from the issue of spare memory.
14218
810928a2
AS
142192011-06-05 Andreas Schwab <schwab@linux-m68k.org>
14220
172418ad
AS
14221 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
14222 format. (Bug#8806)
14223
43f862f7
AS
14224 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
14225
810928a2
AS
14226 * xfns.c (x_set_scroll_bar_default_width): Move declarations
14227 before statements.
14228
a059fe24
JD
142292011-06-05 Jan Djärv <jan.h.d@swipnet.se>
14230
14231 * gtkutil.c (xg_get_default_scrollbar_width): New function.
14232
14233 * gtkutil.h: Declare xg_get_default_scrollbar_width.
14234
14235 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
14236 min width by calling x_set_scroll_bar_default_width (Bug#8505).
14237
989bf368
JB
142382011-06-05 Juanma Barranquero <lekktu@gmail.com>
14239
14240 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
14241
4b80f674
CY
142422011-06-04 Chong Yidong <cyd@stupidchicken.com>
14243
14244 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
14245 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
14246 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
14247 New error handlers.
4b80f674
CY
14248 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
14249 Obey Vx_select_enable_clipboard_manager. Catch errors in
14250 x_clipboard_manager_save (Bug#8779).
14251 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 14252 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 14253
99a33b77 142542011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
14255
14256 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
14257
99a33b77 142582011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
14259
14260 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
14261 in the current matrix if keep_current_p is non-zero.
14262
8264569d
EZ
142632011-06-04 Eli Zaretskii <eliz@gnu.org>
14264
14265 * bidi.c (bidi_level_of_next_char): Fix last change.
14266
57f97249
EZ
142672011-06-03 Eli Zaretskii <eliz@gnu.org>
14268
fec2107c 14269 Support bidi reordering of text covered by display properties.
57f97249 14270
fec2107c
EZ
14271 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
14272 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
14273 (bidi_cache_search, bidi_cache_iterator_state)
14274 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
14275 (bidi_level_of_next_char, bidi_move_to_visually_next):
14276 Support character positions inside a run of characters covered by a
fec2107c
EZ
14277 display string.
14278 (bidi_paragraph_init, bidi_resolve_explicit_1)
14279 (bidi_level_of_next_char): Call bidi_fetch_char and
14280 bidi_fetch_char_advance instead of FETCH_CHAR and
14281 FETCH_CHAR_ADVANCE.
14282 (bidi_init_it): Initialize new members.
14283 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
14284 definitions.
14285 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
14286 instead of using explicit *_CHAR codes.
d6d100dd
SM
14287 (bidi_resolve_explicit, bidi_resolve_weak):
14288 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
14289 bidirectional text is supported only in multibyte buffers.
14290 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
14291 it to initialize the frame_window_p member of struct bidi_it.
14292 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
14293 (bidi_resolve_explicit, bidi_resolve_weak)
14294 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
14295 bidi_it->nchars is non-positive.
14296 (bidi_level_of_next_char): Don't try to lookup the cache for the
14297 next/previous character if nothing is cached there yet, or if we
14298 were just reseat()'ed to a new position.
c40e2fb2 14299
0e14fe90
EZ
14300 * xdisp.c (set_cursor_from_row): Set start and stop points
14301 according to the row's direction when priming the loop that looks
14302 for the glyph on which to display cursor.
14303 (single_display_spec_intangible_p): Function deleted.
14304 (display_prop_intangible_p): Reimplement to call
14305 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
14306 Accept 3 additional arguments needed by handle_display_spec.
14307 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
14308 values: lists, `(when COND...)' forms, etc.
14309 (single_display_spec_string_p): Support property values that are
14310 lists with the argument STRING its top-level element.
14311 (display_prop_string_p): Fix the condition for processing a
14312 property that is a list to be consistent with handle_display_spec.
fec2107c 14313 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
14314 last portion of handle_display_prop.
14315 (compute_display_string_pos): Accept additional argument
14316 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
14317 value of a `display' property is a "replacing spec".
14318 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
14319 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
14320 the display property, but just return a value indicating whether
14321 the display property will replace the characters it covers.
14322 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
14323 frame_window_p members of struct bidi_it.
d6d100dd
SM
14324 (compute_display_string_pos, compute_display_string_end):
14325 New functions.
fec2107c
EZ
14326 (push_it): Accept second argument POSITION, where pop_it should
14327 jump to continue iteration.
14328 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 14329
fec2107c
EZ
14330 * keyboard.c (adjust_point_for_property): Adjust the call to
14331 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
14332
14333 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
14334 (bidi_init_it): Update prototypes.
14335 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
14336 (compute_display_string_pos, compute_display_string_end):
14337 Declare prototypes.
fec2107c
EZ
14338 (struct bidi_it): New members nchars and disp_pos. ch_len is now
14339 EMACS_INT.
fc6f18ce 14340
40087514 143412011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 14342
57f53182
PE
14343 Malloc failure behavior now depends on size of allocation.
14344 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
14345 * lisp.h: Change signatures accordingly.
14346 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
14347 All callers changed. (Bug#8762)
14348
14349 * gnutls.c: Use Emacs's memory allocators.
14350 Without this change, the gnutls library would invoke malloc etc.
14351 directly, which causes problems on non-SYNC_INPUT hosts, and which
14352 runs afoul of improving memory_full behavior. (Bug#8761)
14353 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
14354 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
14355 xfree instead of the default malloc, realloc, free.
14356 (Fgnutls_boot): No need to check for memory allocation failure,
14357 since xmalloc does that for us.
14358
ac32cd99 14359 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
14360 * category.c (hash_get_category_set):
14361 * ccl.c (ccl_driver):
14362 * charset.c (Fdefine_charset_internal):
14363 * charset.h (struct charset.hash_index):
14364 * composite.c (get_composition_id, gstring_lookup_cache)
14365 (composition_gstring_put_cache):
14366 * composite.h (struct composition.hash_index):
14367 * dispextern.h (struct image.hash):
14368 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
14369 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
14370 (hashfn_equal, hashfn_user_defined, make_hash_table)
14371 (maybe_resize_hash_table, hash_lookup, hash_put)
14372 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
14373 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
14374 (Fsxhash, Fgethash, Fputhash, Fmaphash):
14375 * image.c (make_image, search_image_cache, lookup_image)
14376 (xpm_put_color_table_h):
14377 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 14378 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 14379 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 14380 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
14381 * alloc.c (allocate_vectorlike):
14382 Check for overflow in vector size calculations.
14383 * ccl.c (ccl_driver):
14384 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
14385 * fns.c, image.c: Remove unnecessary static decls that would otherwise
14386 need to be updated by these changes.
40087514
PE
14387 * fns.c (make_hash_table, maybe_resize_hash_table):
14388 Check for integer overflow with large hash tables.
0de4bb68
PE
14389 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
14390 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
14391 (SXHASH_REDUCE): New macro.
14392 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
14393 Use it instead of discarding useful hash info with large hash values.
14394 (sxhash_float): New function.
14395 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
14396 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
14397 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
14398 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
14399 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
14400 Adjust signatures to match updated version of code.
14401 (consing_since_gc): Now EMACS_INT, since a single hash table can
14402 use more than INT_MAX bytes.
14403
698d32e2
DN
144042011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
14405
14406 Make it possible to build with GCC-4.6+ -O2 -flto.
14407
14408 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
14409
fd6fa53f
SM
144102011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
14411
14412 * minibuf.c (get_minibuffer, read_minibuf_unwind):
14413 Call minibuffer-inactive-mode.
14414
864db017
JB
144152011-05-31 Juanma Barranquero <lekktu@gmail.com>
14416
14417 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
14418 Update dependencies.
14419
2ad0baf4
DN
144202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14421
14422 * data.c (init_data): Remove code for UTS, this system is not
14423 supported anymore.
14424
4fcc2638
DN
144252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14426
14427 Don't force ./temacs to start in terminal mode.
14428
14429 * frame.c (make_initial_frame): Initialize faces in all cases, not
14430 only when CANNOT_DUMP is defined.
14431 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
14432
c56e0fd5
DN
144332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14434
14435 * dispnew.c (add_window_display_history): Use const for the string
14436 pointer. Remove declaration, not needed.
14437
333d54da 144382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 14439
55d4c1b2 14440 Use 'inline', not 'INLINE'.
333d54da 14441 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
14442 * alloc.c, fontset.c (INLINE): Remove.
14443 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
14444 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
14445 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
14446 * gmalloc.c (register_heapinfo): Use inline unconditionally.
14447 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
14448
738db178
DN
144492011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
14450
14451 Make it possible to run ./temacs.
14452
14453 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
14454 syms_of_callproc does the same thing. Remove test for
14455 "initialized", do it in the caller.
14456 * emacs.c (main): Avoid calling set_initial_environment when dumping.
14457
620c53a6
SM
144582011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
14459
14460 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
14461 (read_minibuf): Use get_minibuffer.
14462 (syms_of_minibuf): Use DEFSYM.
14463 (Qmetadata): New var.
14464 * data.c (Qbuffer): Don't make it static.
14465 (syms_of_data): Use DEFSYM.
14466
e003a292
PE
144672011-05-31 Paul Eggert <eggert@cs.ucla.edu>
14468
14469 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
14470 (CCL_CODE_MIN): New macro.
14471
ed008a6d
PE
144722011-05-30 Paul Eggert <eggert@cs.ucla.edu>
14473
3687c2ef
PE
14474 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
14475
ed008a6d
PE
14476 * eval.c (Qdebug): Now static.
14477 * lisp.h (Qdebug): Remove decl. This reverts a part of the
14478 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
14479 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
14480
d66c4c7c
CY
144812011-05-29 Chong Yidong <cyd@stupidchicken.com>
14482
14483 * image.c: Various fixes to ImageMagick code comments.
14484 (Fimagemagick_types): Doc fix.
14485
5fbc2025
PE
144862011-05-29 Paul Eggert <eggert@cs.ucla.edu>
14487
0196f88a
PE
14488 Minor fixes prompted by GCC 4.6.0 warnings.
14489
14490 * xselect.c (converted_selections, conversion_fail_tag): Now static.
14491
5fbc2025
PE
14492 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
14493 (x_clipboard_manager_save_all): Move extern decl to ...
14494 * xterm.h: ... here, so that it can be checked for consistency.
14495
1dd3c2d9
CY
144962011-05-29 Chong Yidong <cyd@stupidchicken.com>
14497
14498 * xselect.c (x_clipboard_manager_save_frame)
14499 (x_clipboard_manager_save_all): New functions.
14500 (Fx_clipboard_manager_save): Lisp function deleted.
14501
14502 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
14503 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
14504
14505 * xterm.h: Update prototype.
14506
5ba6571d
WX
145072011-05-28 William Xu <william.xwl@gmail.com>
14508
14509 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
14510 exiting (Bug#8239).
14511
3eaff834
JM
145122011-05-28 Jim Meyering <meyering@redhat.com>
14513
e1900994 14514 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
14515 * fns.c (to_uchar): Define.
14516 (crypto_hash_function): Use it to convert some newly-signed
14517 variables to unsigned, to avoid sign-extension bugs. For example,
14518 without this change, (md5 "truc") would evaluate to
14519 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14520 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 14521 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 14522
0f6990a7
PE
145232011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14524
14525 Integer overflow fixes.
c8a9ca5a 14526
08686060
PE
14527 * dbusbind.c: Serial number integer overflow fixes.
14528 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
14529 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
14530 to hold a serial number that is too large for a fixnum.
14531 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14532 Check for serial numbers out of range. Decode any serial number
59568bf0 14533 that was so large that it became a float. (Bug#8722)
08686060 14534
2d1fc3c7
PE
14535 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
14536 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14537 Use XFASTINT rather than XUINT when numbers are nonnegative.
14538 (xd_append_arg, Fdbus_method_return_internal):
14539 (Fdbus_method_error_internal): Likewise. Also, for unsigned
14540 arguments, check that Lisp number is nonnegative, rather than
59568bf0 14541 silently wrapping negative numbers around. (Bug#8722)
30217ff0 14542 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 14543 (Bug#8722)
2d1fc3c7 14544
c8a9ca5a
PE
14545 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
14546
519e1d69
PE
14547 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
14548
6df6ae42 14549 ccl: Add integer overflow checks.
30569699
PE
14550 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
14551 (IN_INT_RANGE): New macros.
14552 (ccl_driver): Use them to check for integer overflow when
14553 decoding a CCL program. Many of the new checks are whether XINT (x)
14554 fits in int; it doesn't always, on 64-bit hosts. The new version
14555 doesn't catch all possible integer overflows, but it's an
847044ea 14556 improvement. (Bug#8719)
30569699 14557
c11285dc
PE
14558 * alloc.c (make_event_array): Use XINT, not XUINT.
14559 There's no need for unsigned here.
14560
fdccd48e
PE
14561 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
14562 This follows up to the 2011-05-06 change that substituted uintptr_t
14563 for EMACS_INT. This case wasn't caught back then.
14564
37910ab2
PE
14565 Rework Fformat to avoid integer overflow issues.
14566 * editfns.c: Include <float.h> unconditionally, as it's everywhere
14567 now (part of C89). Include <verify.h>.
14568 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
14569 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
14570 (Fformat): Avoid the prepass trying to compute sizes; it was only
14571 approximate and thus did not catch overflow reliably. Instead, walk
14572 through the format just once, formatting and computing sizes as we go,
14573 checking for integer overflow at every step, and allocating a larger
14574 buffer as needed. Keep track separately whether the format is
14575 multibyte. Keep only the most-recently calculated precision, rather
14576 than them all. Record whether each argument has been converted to
14577 string. Use EMACS_INT, not int, for byte and char and arg counts.
14578 Support field widths and precisions larger than INT_MAX. Avoid
14579 sprintf's undefined behavior with conversion specifications such as %#d
14580 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
14581 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
14582 formatting out-of-range floating point numbers with int
9173deec 14583 formats. (Bug#8668)
37910ab2 14584
2e6578fb
PE
14585 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
14586
0ae6bdee
PE
14587 * data.c: Avoid integer truncation in expressions involving floats.
14588 * data.c: Include <intprops.h>.
14589 (arith_driver): When there's an integer overflow in an expression
14590 involving floating point, convert the integers to floating point
14591 so that the resulting value does not suffer from catastrophic
14592 integer truncation. For example, on a 64-bit host (* 4
14593 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
14594 Do not rely on undefined behavior after integer overflow.
14595
de883a70
PE
14596 merge count_size_as_multibyte, parse_str_to_multibyte
14597 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 14598 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
14599 Check for integer overflow.
14600 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
14601 since it's now a duplicate of the other. This is more of
14602 a character than a buffer op, so better that it's in character.c.
14603 * fns.c, print.c: Adjust to above changes.
14604
2ff916cb
PE
146052011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
14606
14607 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
14608
f1b54466
PE
146092011-05-27 Paul Eggert <eggert@cs.ucla.edu>
14610
fb1ac845
PE
14611 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14612 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
14613 (x_clipboard_manager_save): Now static.
14614 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
14615
f1b54466
PE
14616 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
14617 (crypto_hash_function): Now static.
14618 Fix pointer signedness problems. Avoid unnecessary initializations.
14619
a9f737ee
CY
146202011-05-27 Chong Yidong <cyd@stupidchicken.com>
14621
14622 * termhooks.h (Vselection_alist): Make it terminal-local.
14623
14624 * terminal.c (create_terminal): Initialize it.
14625
14626 * xselect.c: Support for clipboard managers.
14627 (Vselection_alist): Move to termhooks.h as terminal-local var.
14628 (LOCAL_SELECTION): New macro.
14629 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
14630 (symbol_to_x_atom): Remove gratuitous arg.
14631 (x_handle_selection_request, lisp_data_to_selection_data)
14632 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
14633 (x_own_selection, x_get_local_selection, x_convert_selection):
14634 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
14635 (some_frame_on_display): Delete unused function.
14636 (Fx_own_selection_internal, Fx_get_selection_internal)
14637 (Fx_disown_selection_internal, Fx_selection_owner_p)
14638 (Fx_selection_exists_p): New optional frame arg.
14639 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
14640 (x_handle_selection_clear): Don't treat other terminals with the
14641 same keyboard specially. Use the terminal-local Vselection_alist.
14642 (x_clear_frame_selections): Use Frun_hook_with_args.
14643
14644 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
14645
14646 * xterm.h: Add support for those atoms.
14647
e067f0c1
CY
146482011-05-26 Chong Yidong <cyd@stupidchicken.com>
14649
14650 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
14651 (converted_selections, conversion_fail_tag): New global variables.
14652 (x_selection_request_lisp_error): Free the above.
14653 (x_get_local_selection): Remove unnecessary code.
14654 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
14655 of converted selections stored in converted_selections.
14656 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
14657 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
14658 (x_convert_selection): New function.
14659 (x_handle_selection_event): Simplify.
14660 (x_get_foreign_selection): Don't ignore incoming requests while
14661 waiting for an answer; this will fail when we implement
14662 SAVE_TARGETS, and seems unnecessary anyway.
14663 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
14664 (Vx_sent_selection_functions): Doc fix.
14665
0f4aebc0
LL
146662011-05-26 Leo Liu <sdl.web@gmail.com>
14667
14668 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
14669
e61124cd
YM
146702011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14671
14672 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
14673
14674 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
14675 for fringe update if it has periodic bitmap.
ac389d0c 14676 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
14677 and fringe_bitmap_periodic_p.
14678
14679 * fringe.c (get_fringe_bitmap_data): New function.
14680 (draw_fringe_bitmap_1, update_window_fringes): Use it.
14681 (update_window_fringes): Record periodicity of fringe bitmap in glyph
14682 row. Mark glyph row for fringe update if periodicity changed.
14683
14684 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
14685 for fringe update unless it has periodic bitmap.
14686
f16d9837
KH
146872011-05-25 Kenichi Handa <handa@m17n.org>
14688
14689 * xdisp.c (get_next_display_element): Set correct it->face_id for
14690 a static composition.
14691
e1b90ef6
LL
146922011-05-24 Leo Liu <sdl.web@gmail.com>
14693
14694 * deps.mk (fns.o):
14695 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
14696
14697 * fns.c (crypto_hash_function, Fsha1): New function.
14698 (Fmd5): Use crypto_hash_function.
14699 (syms_of_fns): Add Ssha1.
14700
7400048f
PE
147012011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14702
14703 * gnutls.c: Remove unused macros.
14704 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
14705 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
14706 Remove macros that are defined and never used.
14707 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
14708
abb71cf4
CY
147092011-05-22 Chong Yidong <cyd@stupidchicken.com>
14710
14711 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
14712 (Fx_get_selection_internal): Minor cleanup.
14713 (Fx_own_selection_internal): Rename arguments for consistency with
14714 select.el.
14715
6307db39
PE
147162011-05-22 Paul Eggert <eggert@cs.ucla.edu>
14717
14718 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
14719
f3d4e0a4
CY
147202011-05-22 Chong Yidong <cyd@stupidchicken.com>
14721
14722 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
14723
4d8ade89
YM
147242011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14725
14726 * dispnew.c (scrolling_window): Don't exclude the case that the
14727 last enabled row in the desired matrix touches the bottom boundary.
14728
32078c8d
GM
147292011-05-21 Glenn Morris <rgm@gnu.org>
14730
14731 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
14732 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
14733 and add some more files.
32078c8d 14734
7285dc67
EZ
147352011-05-20 Eli Zaretskii <eliz@gnu.org>
14736
14737 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
14738 report_file_error introduced by the change from 2011-05-07.
14739
89d1bd22
PE
147402011-05-20 Paul Eggert <eggert@cs.ucla.edu>
14741
14742 * systime.h (Time): Define only if emacs is defined.
14743 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
14744 where the include path doesn't have X11/X.h by default. See
14745 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
14746
cd394be1 147472011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
14748
14749 * composite.c (find_automatic_composition): Fix previous change.
14750
b9704ad9
GM
147512011-05-20 Glenn Morris <rgm@gnu.org>
14752
14753 * lisp.mk: New file, split from Makefile.in.
14754 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
14755 (shortlisp): Remove.
14756 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
14757
4a720484
GM
147582011-05-19 Glenn Morris <rgm@gnu.org>
14759
14760 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
14761 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
14762 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
14763 (lisp): Set the order to that of loadup.el.
14764 (shortlisp): Make it a copy of $lisp.
14765 (SOME_MACHINE_LISP): Remove.
14766 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
14767 Use just $shortlisp, not $SOME_MACHINE_LISP too.
14768
a28d4396
KH
147692011-05-18 Kenichi Handa <handa@m17n.org>
14770
14771 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
14772 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
14773 (find_automatic_composition): Mostly rewrite for efficiency.
14774
a2b1fa8e
JB
147752011-05-18 Juanma Barranquero <lekktu@gmail.com>
14776
14777 * makefile.w32-in: Update dependencies.
14778
8e1f5610
CS
147792011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
14780
14781 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 14782 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 14783
7025ee00 147842011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 14785
cdfa6eab
PE
14786 Fix some integer overflow issues, such as string length overflow.
14787
06d6db33
PE
14788 * insdel.c (count_size_as_multibyte): Check for string overflow.
14789
2b4560a8
PE
14790 * character.c (lisp_string_width): Check for string overflow.
14791 Use EMACS_INT, not int, for string indexes and lengths; in
14792 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
14793 the resulting string length overflows an EMACS_INT; instead,
14794 report a string overflow if no precision given. When checking for
14795 precision exhaustion, use a check that cannot possibly have
14796 integer overflow. (Bug#8675)
14797 * character.h (lisp_string_width): Adjust to new signature.
14798
cb93f9be
PE
14799 * alloc.c (string_overflow): New function.
14800 (Fmake_string): Use it. This doesn't change behavior, but saves
14801 a few bytes and will simplify future changes.
14802 * character.c (string_escape_byte8): Likewise.
14803 * lisp.h (string_overflow): New decl.
14804
1a1f3366
PE
14805 Fixups, following up to the user-interface timestamp change.
14806 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
14807 for UI timestamps, instead of unsigned long.
9fbd6841
PE
14808 * msdos.c (mouse_get_pos): Likewise.
14809 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
14810 * w32gui.h (Time): Define by including "systime.h" rather than by
14811 declaring it ourselves. (Bug#8664)
14812
d4e3e4d3
PE
14813 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
14814 * image.c (clear_image_cache): Likewise.
14815
f6a24d19
PE
14816 * term.c (term_mouse_position): Don't assume time_t wraparound.
14817
08dc5ae6
PE
14818 Be more systematic about user-interface timestamps.
14819 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
14820 and sometimes 'EMACS_UINT', to represent these timestamps.
14821 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
14822 This makes the code easier to follow, and makes it easier to catch
14823 integer overflow bugs such as Bug#8664.
14824 * frame.c (Fmouse_position, Fmouse_pixel_position):
14825 Use Time, not unsigned long, for user-interface timestamps.
14826 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
14827 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
14828 * keyboard.h (last_event_timestamp): Likewise.
14829 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
14830 * menu.h (xmenu_show): Likewise.
14831 * term.c (term_mouse_position): Likewise.
14832 * termhooks.h (struct input_event.timestamp): Likewise.
14833 (struct terminal.mouse_position_hook): Likewise.
14834 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
14835 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
14836 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
14837 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
14838 what it was before.
14839 * menu.h, termhooks.h: Include "systime.h", for Time.
14840
8e55734a
PE
14841 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
14842 Don't assume that the difference between two unsigned long values
14843 can fit into an integer. At this point, we know button_down_time
14844 <= event->timestamp, so the difference must be nonnegative, so
14845 there's no need to cast the result if double-click-time is
14846 nonnegative, as it should be; check that it's nonnegative, just in
14847 case. This bug is triggered when events are more than 2**31 ms
86db42d2 14848 apart (about 25 days). (Bug#8664)
8e55734a 14849
841f1b75 14850 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 14851 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 14852
3e26f69c
PE
14853 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
14854 that always fit in int. Use a sentinel instead of a counter, to
14855 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
14856 * frame.h (struct frame): Use int for menu_bar_items_used
14857 instead of EMACS_INT, since it always fits in int.
3e26f69c 14858
5cc152c0
PE
14859 * menu.c (grow_menu_items): Check for int overflow.
14860
d89eb65e
PE
14861 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
14862
5235bd3e
PE
14863 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
14864 Before, the code was not consistent. These values cannot exceed
14865 2**31 - 1 so there's no need to make them unsigned.
14866 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
14867 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
14868 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
14869 as modifiers.
14870 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
14871
bc827e23
PE
14872 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
14873 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
14874 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
14875 presumably because the widths might not match.
14876
78eb494e
PE
14877 * window.c (size_window): Avoid needless test at loop start.
14878
04f2d78b
CB
148792011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
14880
14881 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
14882
d2fc7e3d 148832011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
14884
14885 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
14886
d2fc7e3d 148872011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
14888
14889 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
14890 `width' to `bar_area_x' and `bar_area_width', respectively.
14891 (x_scroll_run): Take account of fringe background extension.
14892
04f2d78b
CB
14893 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
14894 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
14895 `bar_area_width', respectively.
14896 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
14897 background extension.
14898
79b70037
GM
148992011-05-10 Jim Meyering <meyering@redhat.com>
14900
14901 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
14902
2f142cc5
JB
149032011-05-10 Juanma Barranquero <lekktu@gmail.com>
14904
14905 * image.c (Finit_image_library): Return t for built-in image types,
14906 like pbm and xbm. (Bug#8640)
14907
57679c86
AS
149082011-05-09 Andreas Schwab <schwab@linux-m68k.org>
14909
14910 * w32menu.c (set_frame_menubar): Fix submenu allocation.
14911
888c9e86
EZ
149122011-05-07 Eli Zaretskii <eliz@gnu.org>
14913
b0512a1d
EZ
14914 * w32console.c (Fset_screen_color): Doc fix.
14915 (Fget_screen_color): New function.
14916 (syms_of_ntterm): Defsubr it.
14917
7285dc67
EZ
14918 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
14919 unlink the temporary file if Fcall_process didn't create it in the
14920 first place.
14921 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
14922 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
14923 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
14924 cue to call_process_cleanup not to close that handle.
14925
4d3fcc8e
BK
149262011-05-07 Ben Key <bkey76@gmail.com>
14927
14928 * makefile.w32-in: The bootstrap-temacs rule now makes use of
14929 one of two shell specific rules, either bootstrap-temacs-CMD or
14930 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
14931 to the previous implementation of the bootstrap-temacs rule.
14932 The bootstrap-temacs-CMD rule is similar to the previous
14933 implementation of the bootstrap-temacs rule except that it
14934 makes use of the ESC_CFLAGS variable instead of the CFLAGS
14935 variable.
14936
14937 These changes, along with some changes to nt/configure.bat,
14938 nt/gmake.defs, and nt/nmake.defs, are required to extend my
14939 earlier fix to add support for --cflags and --ldflags options
14940 that include quotes so that it works whether make uses cmd or
14941 sh as the shell.
14942
b4289b64
MA
149432011-05-06 Michael Albinus <michael.albinus@gmx.de>
14944
14945 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
14946 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
14947 is a constant.
14948 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
14949 a string. Handle both cases.
14950 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
14951 (Fdbus_register_method): Use Qinvalid_function.
14952
af4c0e28
JB
149532011-05-06 Juanma Barranquero <lekktu@gmail.com>
14954
14955 * makefile.w32-in: Update dependencies.
14956 (LISP_H): Add inttypes.h and stdin.h.
14957 (PROCESS_H): Add unistd.h.
14958
c51453d9
EZ
149592011-05-06 Eli Zaretskii <eliz@gnu.org>
14960
14961 * lread.c: Include limits.h (fixes the MS-Windows build broken by
14962 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
14963
8ff0ac3c 149642011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 14965
4c4b566b
PE
14966 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
14967
aab2b9b5
PE
14968 * term.c (vfatal): Remove stray call to va_end.
14969 It's not needed and the C Standard doesn't allow it here anyway.
14970
c378da0b
PE
14971 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
14972 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
14973
288b08c7
PE
14974 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
14975 bytes.
14976
e3601888
PE
14977 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
14978
db6c0e74
PE
14979 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
14980
dd5963ea
PE
14981 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
14982
88c9450f
PE
14983 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
14984
2f9442b8
PE
14985 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
14986
c032b5f8
PE
14987 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
14988 * charset.c (Fdefine_charset_internal): Don't initialize
14989 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 14990 32-bit int (Bug#8600).
a108c10b
PE
14991
14992 * lread.c (read_integer): Be more consistent with string-to-number.
14993 Use string_to_number to do the actual conversion; this avoids
14994 rounding errors and fixes some other screwups. Without this fix,
14995 for example, #x1fffffffffffffff was misread as -2305843009213693952.
14996 (digit_to_number): Move earlier, for benefit of read_integer.
14997 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 14998 not a digit in any supported base. (Bug#8602)
a108c10b 14999
ad5f9eea
PE
15000 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
15001
aec1708a
PE
15002 * dispnew.c (scrolling_window): Return 1 if we scrolled,
15003 to match comment at start of function. This also removes a
15004 GCC warning about overflow in a 32+64-bit port.
15005
47be4ab5
PE
15006 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
15007
371cac43
PE
15008 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
15009 Reported by Stefan Monnier in
15010 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
15011 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15012 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 15013
d01a7826
PE
15014 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
15015 (EMACS_UINTPTR): Likewise, with uintptr_t.
15016
7fd47d5c
PE
15017 * lisp.h: Prefer 64-bit EMACS_INT if available.
15018 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
15019 on 32-bit hosts that have 64-bit int, so that they can access
15020 large files.
122b0c86
PE
15021 However, temporarily disable this change unless the temporary
15022 symbol WIDE_EMACS_INT is defined.
7fd47d5c 15023
8727937b
PE
15024 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
15025
8ac068ac
PE
15026 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
15027 This removes an assumption that EMACS_INT and long are the same
15028 width as pointers. The assumption is true for Emacs porting targets
15029 now, but we want to make other targets possible.
15030 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
15031 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
15032 In the rest of the code, change types of integers that hold casted
15033 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
15034 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
15035 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
15036 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
15037 No need to cast type when ORing.
15038 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
15039 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
15040 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
15041 assume EMACS_INT is the same width as char *.
15042 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
15043 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
15044 Remove no-longer-needed casts.
15045 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
15046 (xg_tool_bar_help_callback, xg_make_tool_item):
15047 Use EMACS_INTPTR to hold an integer
15048 that will be cast to void *; this can avoid a GCC warning
15049 if EMACS_INT is not the same width as void *.
15050 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
15051 * xdisp.c (display_echo_area_1, resize_mini_window_1):
15052 (current_message_1, set_message_1):
15053 Use a local to convert to proper width without a cast.
15054 * xmenu.c (dialog_selection_callback): Likewise.
15055
ede49d71
PE
15056 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
15057 Also, don't assume VALBITS / RAND_BITS is less than 5,
15058 and don't rely on undefined behavior when shifting a 1 left into
15059 the sign bit.
15060 * lisp.h (get_random): Change signature to match.
15061
2f30ecd0
PE
15062 * lread.c (hash_string): Use size_t, not int, for hash computation.
15063 Normally we prefer signed values; but hashing is special, because
15064 it's better to use unsigned division on hash table sizes so that
15065 the remainder is nonnegative. Also, size_t is the natural width
15066 for hashing into memory. The previous code used 'int', which doesn't
15067 retain enough info to hash well into very large tables.
15068 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
15069
2a866e7b
PE
15070 * dbusbind.c: Don't possibly lose pointer info when converting.
15071 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
15072 Use XPNTR rather than XHASH, so that the high-order bits of
15073 the pointer aren't lost when converting through void *.
15074
51639eac
PE
15075 * eval.c (Fautoload): Don't double-shift a pointer.
15076
92394119
PE
15077 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
15078
dbdb9a7c
JB
150792011-05-06 Juanma Barranquero <lekktu@gmail.com>
15080
15081 * gnutls.c (DEF_GNUTLS_FN):
15082 * image.c (DEF_IMGLIB_FN): Make function pointers static.
15083
db7a0b4f
AS
150842011-05-05 Andreas Schwab <schwab@linux-m68k.org>
15085
15086 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
15087 marker. (Bug#8610)
15088
cd394be1 150892011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
15090
15091 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
15092 New version that can reserve upto 2GB of heap space.
15093
f7ff1b0f 150942011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
15095
15096 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
15097
639c109b
TZ
150982011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
15099
15100 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
15101 `gnutls_certificate_set_x509_key_file'.
15102
d2127135
JB
151032011-05-05 Juanma Barranquero <lekktu@gmail.com>
15104
15105 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
15106 Update dependencies.
15107
e968f4f3
JB
151082011-05-04 Juanma Barranquero <lekktu@gmail.com>
15109
15110 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
15111 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
15112 Remove unused parameter `fildes'.
15113 * process.c (read_process_output, send_process): Don't pass it.
15114
84d358f0
JB
151152011-05-04 Juanma Barranquero <lekktu@gmail.com>
15116
15117 Fix previous change: the library cache is defined in w32.c.
15118 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
15119 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
15120
0898ca10
JB
151212011-05-04 Juanma Barranquero <lekktu@gmail.com>
15122
15123 Implement dynamic loading of GnuTLS on Windows.
15124
15125 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
15126 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
15127 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15128 Declare.
15129
15130 * gnutls.c (Qgnutls_dll): Define.
15131 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
15132 (gnutls_*): Declare function pointers.
15133 (init_gnutls_functions): New function to initialize function pointers.
15134 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
15135 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
15136 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
15137 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
15138 (emacs_gnutls_write, emacs_gnutls_read)
15139 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
15140 (Fgnutls_available_p): New function.
15141 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
15142 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
15143 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
15144
15145 * image.c: Include w32.h.
15146 (Vimage_type_cache): Delete.
15147 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
15148 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
15149 (w32_delayed_load): Move to w32.c.
15150
15151 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
15152
15153 * w32.c (QCloaded_from, Vlibrary_cache): Define.
15154 (w32_delayed_load): Move from image.c. When loading a library, record
15155 its filename in the :loaded-from property of the library id.
15156 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
15157 Initialize and staticpro them.
15158 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
15159
15160 * process.c: Include lisp.h before w32.h, not after.
15161 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
15162 instead of gnutls_record_check_pending.
15163
15164 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
15165
ff4de4aa
TZ
151662011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
15167
15168 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
15169 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
15170 as passed in.
15171
abe95abb
JD
151722011-05-03 Jan Djärv <jan.h.d@swipnet.se>
15173
15174 * xterm.c (x_set_frame_alpha): Do not set property on anything
15175 else than FRAME_X_OUTER_WINDOW (Bug#8608).
15176
e16e55d4
JB
151772011-05-02 Juanma Barranquero <lekktu@gmail.com>
15178
15179 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
15180
bafcf6a5
JB
151812011-05-02 Juanma Barranquero <lekktu@gmail.com>
15182
15183 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
15184 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
15185 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
15186 (gnutls_global_initialized, Qgnutls_bootprop_priority)
15187 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
15188 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
15189 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
15190 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
15191 (Qgnutls_bootprop_callbacks_verify): Make static.
15192
e7a6747f
AS
151932011-05-01 Andreas Schwab <schwab@linux-m68k.org>
15194
19ed11ba
AS
15195 * callproc.c: Indentation fixup.
15196
e7a6747f 15197 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
15198 (wait_for_termination, interruptible_wait_for_termination):
15199 Move after wait_for_termination_1.
e7a6747f 15200
1ef14cb4
LMI
152012011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
15202
15203 * sysdep.c (interruptible_wait_for_termination): New function
15204 which is like wait_for_termination, but allows keyboard
15205 interruptions.
15206
15207 * callproc.c (Fcall_process): Add (:file "file") as an option for
15208 the STDOUT buffer.
15209 (Fcall_process_region): Ditto.
15210
330d880c
EZ
152112011-04-30 Eli Zaretskii <eliz@gnu.org>
15212
8db90b73
EZ
15213 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
15214 rather than `XVECTOR (FOO)->size'.
15215
330d880c
EZ
15216 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
15217 inttypes.h, as a gnulib replacement is used if it not available in
15218 system headers.
15219
15cbd324
EZ
152202011-04-21 Eli Zaretskii <eliz@gnu.org>
15221
15222 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
15223 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
15224 of MOST_POSITIVE_FIXNUM. (Bug#8528)
15225
15226 * coding.c (coding_alloc_by_realloc): Error out if destination
15227 will grow beyond MOST_POSITIVE_FIXNUM.
15228 (decode_coding_emacs_mule): Abort if there isn't enough place in
15229 charbuf for the composition carryover bytes. Reserve an extra
15230 space for up to 2 characters produced in a loop.
15231 (decode_coding_iso_2022): Abort if there isn't enough place in
15232 charbuf for the composition carryover bytes.
15233
152342011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 15235
ae940cca
EZ
15236 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
15237 aborting when %lld or %lll format is passed.
15238 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
15239 %llo or %llx format is passed. (Bug#8545)
15240
03ab8921
EZ
15241 * window.c (window_scroll_line_based): Use a marker instead of
15242 simple variables to record original value of point. (Bug#7952)
15243
afda1437
EZ
15244 * doprnt.c (doprnt): Fix the case where a multibyte sequence
15245 produced by %s or %c overflows available buffer space. (Bug#8545)
15246
f76dee0c
PE
152472011-04-28 Paul Eggert <eggert@cs.ucla.edu>
15248
15249 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 15250 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 15251
fdc5744d
JB
152522011-04-28 Juanma Barranquero <lekktu@gmail.com>
15253
15254 * w32.c (init_environment): Warn about defaulting HOME to C:\.
15255
638f053a
JB
152562011-04-28 Juanma Barranquero <lekktu@gmail.com>
15257
15258 * keyboard.c (Qdelayed_warnings_hook): Define.
15259 (command_loop_1): Run `delayed-warnings-hook'
15260 if Vdelayed_warnings_list is non-nil.
15261 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
15262 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
15263
d178f871
EZ
152642011-04-28 Eli Zaretskii <eliz@gnu.org>
15265
15266 * doprnt.c (doprnt): Don't return value smaller than the buffer
15267 size if the message was truncated. (Bug#8545).
15268
b124fd93
JB
152692011-04-28 Juanma Barranquero <lekktu@gmail.com>
15270
15271 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
15272 (Fx_window_property): #if-0 the whole functions, not just the bodies.
15273
e810457d
PE
152742011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15275
15276 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
15277
ea51cceb
JB
152782011-04-27 Juanma Barranquero <lekktu@gmail.com>
15279
15280 * makefile.w32-in: Update dependencies.
15281
94dcfacf
EZ
152822011-04-27 Eli Zaretskii <eliz@gnu.org>
15283
15284 Improve `doprnt' and its usage. (Bug#8545)
15285 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
15286 `format_end'. Remove support for %l as a conversion specifier.
15287 Don't use xrealloc. Improve diagnostics when the %l size modifier
15288 is used. Update the commentary.
15289
15290 * eval.c (verror): Simplify calculation of size_t.
15291
15292 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
15293 messages.
15294
f61f41d7
PE
152952011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
15296
15297 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
15298 change.
15299
96fb4434
PE
153002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
15301
15302 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
15303 This makes this file independent of the recent pseudovector change.
15304
671875da 153052011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 15306
69e9b5a3
PE
15307 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
15308
b5f869a7 15309 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 15310 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 15311 Remove unused local.
c8926152 15312 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 15313
841a1577 15314 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
15315 GCC 4.6.0 optimizes based on type-based alias analysis.
15316 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
15317 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
15318 != &v->size, and therefore "v->size = 1; b->size = 2; return
15319 v->size;" must therefore return 1. This assumption is incorrect
15320 for Emacs, since it type-puns struct Lisp_Vector * with many other
15321 types. To fix this problem, this patch adds a new type struct
f904488f 15322 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
15323 and pseudovectors, and helps optimizing compilers not get fooled
15324 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
15325 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
15326 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
15327 the size member.
eab3844f
PE
15328 (XSETPVECTYPE): Rewrite in terms of new macro.
15329 (XSETPVECTYPESIZE): New macro, specifying both type and size.
15330 This is a bit clearer, and further avoids the possibility of
15331 undesirable aliasing.
15332 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 15333 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
15334 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
15335 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
15336 (ASIZE): Now uses header.size rather than size.
15337 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
15338 to avoid the hassle of writing XVECTOR (foo)->header.size.
15339 (struct vectorlike_header): New type.
eab3844f
PE
15340 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
15341 object, to help avoid aliasing.
15342 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
15343 (SUBRP): Likewise, since Lisp_Subr is a special case.
15344 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
15345 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
15346 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 15347 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
15348 changed to be "header.size" and "header.next".
15349 * buffer.h (struct buffer): Likewise.
15350 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
15351 * frame.h (struct frame): Likewise.
15352 * process.h (struct Lisp_Process): Likewise.
15353 * termhooks.h (struct terminal): Likewise.
15354 * window.c (struct save_window_data, struct saved_window): Likewise.
15355 * window.h (struct window): Likewise.
15356 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
15357 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
15358 * buffer.c (init_buffer_once): Likewise.
15359 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
15360 special case.
15361 * process.c (Fformat_network_address): Use local var for size,
15362 for brevity.
15363
0df1eac5
PE
15364 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
15365
847ab9d1 15366 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
15367 * data.c (atof): Remove decl; no longer used or needed.
15368 (digit_to_number): Move to lread.c.
15369 (Fstring_to_number): Use new string_to_number function, to be
15370 consistent with how the Lisp reader treats infinities and NaNs.
15371 Do not assume that floating-point numbers represent EMACS_INT
15372 without losing information; this is not true on most 64-bit hosts.
15373 Avoid double-rounding errors, by insisting on integers when
15374 parsing non-base-10 numbers, as the documentation specifies.
15375 * lisp.h (string_to_number): New decl, replacing ...
15376 (isfloat_string): Remove.
bc0a5c13 15377 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 15378 (read1): Do not accept +. and -. as integers; this
452f4150
PE
15379 appears to have been a coding error. Similarly, do not accept
15380 strings like +-1e0 as floating point numbers. Do not report
15381 overflow for integer overflows unless the base is not 10 which
15382 means we have no simple and reliable way to continue.
15383 Break out the floating-point parsing into a new
15384 function string_to_number, so that Fstring_to_number parses
15385 floating point numbers consistently with the Lisp reader.
04f2d78b 15386 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
15387 (E_CHAR, EXP_INT): Remove, replacing with ...
15388 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
15389 (string_to_number): New function, replacing isfloat_string.
15390 This function checks for valid syntax and produces the resulting
15391 Lisp float number too. Rework it so that string-to-number
bc0a5c13 15392 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
15393 so that overflow for non-base-10 numbers is reported only when
15394 there's no portable and simple way to convert to floating point.
452f4150 15395
67769ffc
PE
15396 * textprop.c (set_text_properties_1): Rewrite for clarity,
15397 and to avoid GCC warning about integer overflow.
15398
c20db43f
PE
15399 * intervals.h (struct interval): Use EMACS_INT for members
15400 where EMACS_UINT might cause problems. See
15401 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
15402 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
15403 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
15404 All uses changed.
37aa2f85
PE
15405 (offset_intervals): Tell GCC not to worry about length overflow
15406 when negating a negative length.
c20db43f 15407
2538aa2f
PE
15408 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
15409 (overrun_check_free): Likewise.
15410
f2d3008d
PE
15411 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
15412 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
15413 word size.
15414
ec8df744
PE
15415 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15416 (gnutls_make_error): Rename local to avoid shadowing.
15417 (gnutls_emacs_global_deinit): ifdef out; not used.
15418 (Fgnutls_boot): Use const for pointer to readonly storage.
15419 Comment out unused local. Fix pointer signedness problems.
15420
640ee02d
PE
15421 * lread.c (openp): Don't stuff size_t into an 'int'.
15422 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
15423 about possible signed overflow.
15424
6048fb2a
PE
15425 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
15426 (GDK_KEY_g): Don't define if already defined.
15427 (xg_prepare_tooltip): Avoid pointer signedness problem.
15428 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
15429
fa3c87e1
PE
15430 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
15431 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
15432
2172544b
PE
15433 * xfns.c (Fx_window_property): Simplify a bit,
15434 to make a bit faster and to avoid GCC 4.6.0 warning.
15435 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
15436
9b821a21
PE
15437 * fns.c (internal_equal): Don't assume size_t fits in int.
15438
3c616cfa
PE
15439 * alloc.c (compact_small_strings): Tighten assertion a little.
15440
c2982e87
PE
15441 Replace pEd with more-general pI, and fix some printf arg casts.
15442 * lisp.h (pI): New macro, generalizing old pEd macro to other
15443 conversion specifiers. For example, use "...%"pI"d..." rather
15444 than "...%"pEd"...".
15445 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 15446 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
15447 * alloc.c (check_pure_size): Don't overflow by converting size to int.
15448 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
15449 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
15450 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
15451 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
15452 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
15453 64-bit hosts.
15454 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
15455 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
15456 * print.c (safe_debug_print, print_object): Likewise.
15457 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
15458 to int.
6f04d126
PE
15459 Use pI instead of if-then-else-abort. Use %p to avoid casts,
15460 avoiding the 0 flag, which is not portable.
c2982e87
PE
15461 * process.c (Fmake_network_process): Use pI to avoid cast.
15462 * region-cache.c (pp_cache): Likewise.
15463 * xdisp.c (decode_mode_spec): Likewise.
15464 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
15465 behavior on 64-bit hosts with printf arg.
6f04d126 15466 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
15467 (x_stop_queuing_selection_requests): Likewise.
15468 (x_get_window_property): Don't truncate byte count to an 'int'
15469 when tracing.
0b432f21 15470
5e073ec7
PE
15471 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
15472 here, since it parses constructs like leading '-' and spaces,
15473 which are not wanted; and it overflows with large numbers.
15474 Instead, simply match F[0-9]+, which is what is wanted anyway.
15475
36372bf9
PE
15476 * alloc.c: Remove unportable assumptions about struct layout.
15477 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
15478 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
15479 (allocate_vectorlike, make_pure_vector): Use the new macros,
15480 plus offsetof, to remove unportable assumptions about struct layout.
15481 These assumptions hold on all porting targets that I know of, but
15482 they are not guaranteed, they're easy to remove, and removing them
15483 makes further changes easier.
15484
0b432f21
PE
15485 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
15486 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
15487 (string_overrun_cookie): Now const. Use initializers that
15488 don't formally overflow signed char, to avoid warnings.
000098c1
PE
15489 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
15490 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
15491 (allocate_buffer): Don't assume sizeof (struct buffer) is a
15492 multiple of sizeof (EMACS_INT); it need not be, if
15493 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 15494 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 15495
895009e1
JB
154962011-04-26 Juanma Barranquero <lekktu@gmail.com>
15497
15498 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
15499
6a7a1b0b
TZ
155002011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
15501
15502 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 15503 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
15504 Reported by Paul Eggert <eggert@cs.ucla.edu>.
15505
841a1577 155062011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
15507
15508 * lisp.h (Qdebug): List symbol.
895009e1 15509 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
15510 * keyboard.c (debug-on-event): New variable.
15511 (handle_user_signal): Break into debugger when debug-on-event
15512 matches the current signal symbol.
15513
f2d3ba6f
DN
155142011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
15515
15516 * alloc.c (check_sblock, check_string_bytes)
15517 (check_string_free_list): Convert to standard C.
15518
42ce4c63
TZ
155192011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
15520
15521 * w32.c (emacs_gnutls_push): Fix typo.
15522
825cd63c
EZ
155232011-04-25 Eli Zaretskii <eliz@gnu.org>
15524
fb11d64d
EZ
15525 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
15526 "cast to pointer from integer of different size".
15527
825cd63c
EZ
15528 Improve doprnt and its use in verror. (Bug#8545)
15529 * doprnt.c (doprnt): Document the set of format control sequences
15530 supported by the function. Use SAFE_ALLOCA instead of always
15531 using `alloca'.
15532
15533 * eval.c (verror): Don't limit the buffer size at size_max-1, that
15534 is one byte too soon. Don't use xrealloc; instead xfree and
15535 xmalloc anew.
15536
e061a11b
TZ
155372011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
15538
15539 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
15540 callbacks stage.
15541
15542 * gnutls.c: Renamed global_initialized to
15543 gnutls_global_initialized. Added internals for the
15544 :verify-hostname-error, :verify-error, and :verify-flags
15545 parameters of `gnutls-boot' and documented those parameters in the
15546 docstring. Start callback support.
9173deec
JB
15547 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
15548 unless a fatal error occurred. Call gnutls_alert_send_appropriate
15549 on error. Return error code.
e061a11b
TZ
15550 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
15551 (emacs_gnutls_read): Likewise.
15552 (Fgnutls_boot): Return handshake error code.
15553 (emacs_gnutls_handle_error): New function.
15554 (wsaerror_to_errno): Likewise.
15555
15556 * w32.h (emacs_gnutls_pull): Add prototype.
15557 (emacs_gnutls_push): Likewise.
15558
15559 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
15560 (emacs_gnutls_push): Likewise.
15561
155622011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
15563
15564 * process.c (wait_reading_process_output): Check if GnuTLS
15565 buffered some data internally if no FDs are set for TLS
15566 connections.
15567
15568 * makefile.w32-in (OBJ2): Add gnutls.$(O).
15569 (LIBS): Link to USER_LIBS.
15570 ($(BLD)/gnutls.$(0)): New target.
15571
fa6996bc
EZ
155722011-04-24 Eli Zaretskii <eliz@gnu.org>
15573
eb35682e
EZ
15574 * xdisp.c (handle_single_display_spec): Rename the
15575 display_replaced_before_p argument into display_replaced_p, to
15576 make it consistent with the commentary. Fix typos in the
15577 commentary.
15578
e2ad650c
EZ
15579 * textprop.c (syms_of_textprop): Remove dead code.
15580 (copy_text_properties): Delete obsolete commentary about an
15581 interface that was deleted long ago. Fix typos in the description
15582 of arguments.
15583
1b2de274
EZ
15584 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
15585 to changes in oldXMenu/XMenu.h from 2011-04-16.
15586 <menu_help_message, prev_menu_help_message>: Constify.
15587 (IT_menu_make_room): menu->help_text is now `const char **';
15588 adjust.
15589
15590 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
15591 to changes in oldXMenu/XMenu.h from 2011-04-16.
15592 (struct XMenu): Declare `help_text' `const char **'.
15593
15594 * xfaces.c <Qunspecified>: Make extern again.
15595
15596 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 15597 required by POSIX.
1b2de274 15598
762b15be
EZ
15599 * doc.c (get_doc_string): Improve the format passed to `error'.
15600
15601 * doprnt.c (doprnt): Improve commentary.
15602
15603 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
15604
15605 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
15606 them with etags.
15607
f1052e5d
EZ
15608 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
15609 changes in globals.h immediately force recompilation.
762b15be
EZ
15610 (TAGS): Depend on $(CURDIR)/m/intel386.h and
15611 $(CURDIR)/s/ms-w32.h.
15612 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 15613
fa6996bc
EZ
15614 * character.c (Fchar_direction): Function deleted.
15615 (syms_of_character): Don't defsubr it.
15616 <char-direction-table>: Deleted.
15617
e6c3da20
EZ
156182011-04-23 Eli Zaretskii <eliz@gnu.org>
15619
15620 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
15621 * doprnt.c: Include limits.h.
15622 (SIZE_MAX): New macro.
04f2d78b
CB
15623 (doprnt): Return a size_t value. 2nd arg is now size_t.
15624 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
15625 Improve overflow protection. Support `l' modifier for integer
15626 conversions. Support %l conversion. Don't assume an EMACS_INT
15627 argument for integer conversions and for %c.
15628
15629 * lisp.h (doprnt): Restore prototype.
15630
15631 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
15632 $(SRC)/character.h.
15633
15634 * Makefile.in (base_obj): Add back doprnt.o.
15635
15636 * deps.mk (doprnt.o): Add back prerequisites.
15637 (callint.o): Depend on character.h.
15638
15639 * eval.c (internal_lisp_condition_case): Include the handler
15640 representation in the error message.
15641 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
15642 when breaking from the loop.
15643
15644 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
15645
15646 * callint.c (Fcall_interactively): When displaying error message
15647 about invalid control letter, pass the character's codepoint, not
15648 a pointer to its multibyte form. Improve display of the character
15649 in octal and display also its hex code.
15650
15651 * character.c (char_string): Use %x to display the (unsigned)
15652 codepoint of an invalid character, to avoid displaying a bogus
15653 negative value.
15654
15655 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
15656 `error', not SYMBOL_NAME itself.
15657
15658 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
15659 character arguments to `error'.
15660
15661 * charset.c (check_iso_charset_parameter): Fix incorrect argument
15662 to `error' in error message about FINAL_CHAR argument. Make sure
15663 FINAL_CHAR is a character, and use %c when it is passed as
15664 argument to `error'.
15665
4ffd0d6b 156662011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
15667
15668 * s/ms-w32.h (localtime): Redirect to sys_localtime.
15669
15670 * w32.c: Include <time.h>.
15671 (sys_localtime): New function.
15672
4ffd0d6b 156732011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
15674
15675 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
15676
4ffd0d6b 15677 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 15678
4ffd0d6b 156792011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 15680
4ffd0d6b
GM
15681 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
15682 zombies (Bug#8467).
aac0c6e3 15683
04c56954
EZ
156842011-04-19 Eli Zaretskii <eliz@gnu.org>
15685
15686 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
15687 gl_state.e_property when gl_state.object is Qt.
15688
15689 * insdel.c (make_gap_larger): Remove limitation of buffer size
15690 to <= INT_MAX.
15691
16a43933
CY
156922011-04-18 Chong Yidong <cyd@stupidchicken.com>
15693
15694 * xdisp.c (lookup_glyphless_char_display)
15695 (produce_glyphless_glyph): Handle cons cell entry in
15696 glyphless-char-display.
15697 (Vglyphless_char_display): Document it.
15698
15699 * term.c (produce_glyphless_glyph): Handle cons cell entry in
15700 glyphless-char-display.
15701
4581706e
CY
157022011-04-17 Chong Yidong <cyd@stupidchicken.com>
15703
15704 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
15705
15706 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
15707
15708 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
15709 definition for no-X builds.
15710
4887c6e2 157112011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 15712
fd35b6f9
PE
15713 Static checks with GCC 4.6.0 and non-default toolkits.
15714
5c1ccb01
PE
15715 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
15716
006c5daa
PE
15717 * process.c (keyboard_bit_set): Define only if SIGIO.
15718 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
15719 (send_process): Repair possible setjmp clobbering.
15720
efc736d3
PE
15721 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
15722
4e2fe2e6
PE
15723 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
15724
f97334a2
PE
15725 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
15726
4e75f29d
PE
15727 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
15728 Define only if needed.
15729
90efadd1
PE
15730 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
15731 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 15732 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 15733
3c647824
PE
15734 * dispextern.h (struct redisplay_interface): Rename param
15735 to avoid shadowing.
e264f262 15736 * termhooks.h (struct terminal): Likewise.
761383f4 15737 * xterm.c (xembed_send_message): Likewise.
3c647824 15738
b58c5c4a
PE
15739 * insdel.c (make_gap_smaller): Define only if
15740 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
15741
cad59032
PE
15742 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
15743 it.
15744
c339dc2e
PE
15745 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
15746 so that we aren't warned about unused symbols.
15747
91a3e27b
PE
15748 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
15749
399c71d3 15750 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 15751
8ffc96f5
PE
15752 * xfns.c (x_real_positions): Mark locals as initialized.
15753
eef9bc79
PE
15754 * xmenu.c (xmenu_show): Don't use uninitialized vars.
15755
098db9dd
PE
15756 * xterm.c: Fix problems found by static analysis with other toolkits.
15757 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
15758 (x_dispatch_event): Declare static if USE_GTK, and
15759 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 15760 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 15761 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
15762 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
15763 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 15764
eb18f6cc
PE
15765 * xmenu.c (menu_help_callback): Pointer type fixes.
15766 Use const pointers when pointing at readonly data. Avoid pointer
15767 signedness clashes.
15768 (FALSE): Remove unused macro.
15769 (update_frame_menubar): Remove unused decl.
15770
1fe72bf8
PE
15771 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
15772
60d9e1db
PE
15773 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
15774 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
15775 (single_menu_item): Rename local to avoid shadowing.
15776
39261c26
PE
15777 * keyboard.c (make_lispy_event): Remove unused local var.
15778
018c5e19
PE
15779 * frame.c, frame.h (x_get_resource_string): Bring this back, but
15780 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
15781
63d2b86e
PE
15782 * bitmaps: Change bitmaps from unsigned char back to the X11
15783 compatible char. Avoid the old compiler warnings about
15784 out-of-range initializers by using, for example, '\xab' rather
15785 than 0xab.
15786
aefd87e1
PE
15787 * xgselect.c (xgselect_initialize): Check vs interface
15788 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
15789
bf501fb9
PE
15790 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
15791
e9829fdf
PE
15792 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
15793 to read-only memory.
15794
1086c095
PE
15795 * fns.c (vector): Remove; this old hack is no longer needed.
15796
2baccd04 15797 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 15798 Remove unused var.
dde42981 15799 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 15800
72391843 15801 * xrdb.c (x_load_resources): Omit unused local.
3565b346 15802
436c16df 15803 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 15804 (x_window): Rename locals to avoid shadowing.
dc5ddd85 15805 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 15806
92bb796d 15807 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 15808 (x_term_init): Remove local to avoid shadowing.
92bb796d 15809
764430a3 15810 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
15811
15812 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
15813 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
15814
d1dfb56c
EZ
158152011-04-16 Eli Zaretskii <eliz@gnu.org>
15816
c4354cb4
EZ
15817 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
15818
d1dfb56c
EZ
15819 Fix regex.c, syntax.c and friends for buffers > 2GB.
15820 * syntax.h (struct gl_state_s): Declare character position members
15821 EMACS_INT.
15822
15823 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
15824
04f2d78b
CB
15825 * textprop.c (verify_interval_modification, interval_of):
15826 Declare arguments EMACS_INT.
d1dfb56c
EZ
15827
15828 * intervals.c (adjust_intervals_for_insertion): Declare arguments
15829 EMACS_INT.
15830
15831 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
15832
15833 * indent.c (Fvertical_motion): Local variable it_start is now
15834 EMACS_INT.
15835
15836 * regex.c (re_match, re_match_2, re_match_2_internal)
15837 (bcmp_translate, regcomp, regexec, print_double_string)
15838 (group_in_compile_stack, re_search, re_search_2, regex_compile)
15839 (re_compile_pattern, re_exec): Declare arguments and local
15840 variables `size_t' and `ssize_t' and return values `regoff_t', as
15841 appropriate.
15842 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
15843 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
15844 <compile_stack_type>: `size' and `avail' are now `size_t'.
15845
15846 * regex.h <regoff_t>: Use ssize_t, not int.
15847 (re_search, re_search_2, re_match, re_match_2): Arguments that
15848 specify buffer/string position and length are now ssize_t and
15849 size_t. Return type is regoff_t.
15850
613052cd
BK
158512011-04-16 Ben Key <bkey76@gmail.com>
15852
15853 * nsfont.m: Fixed bugs in ns_get_family and
15854 ns_descriptor_to_entity that were caused by using free to
15855 deallocate memory blocks that were allocated by xmalloc (via
15856 xstrdup). This caused Emacs to crash when compiled with
15857 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
15858 --enable-checking=xmallocoverrun). xfree is now used to
15859 deallocate these memory blocks.
15860
4170f62f 158612011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 15862
71b41406
PE
15863 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
15864
9587a89d
PE
15865 emacs_write: Accept and return EMACS_INT for sizes.
15866 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
15867 et seq.
15868 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
15869 Accept and return EMACS_INT.
15870 (emacs_gnutls_write): Return the number of bytes written on
15871 partial writes.
15872 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
15873 (emacs_read, emacs_write): Remove check for negative size, as the
15874 Emacs source code has been audited now.
9587a89d
PE
15875 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
15876 (emacs_read, emacs_write): Use it.
273a5f82
PE
15877 * process.c (send_process): Adjust to the new signatures of
15878 emacs_write and emacs_gnutls_write. Do not attempt to store
15879 a byte offset into an 'int'; it might overflow.
9587a89d 15880 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 15881
3e047f51
PE
15882 * sound.c: Don't assume sizes fit in 'int'.
15883 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 15884 Return EMACS_INT, not int.
3e047f51 15885 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
15886 Accept EMACS_INT, not int.
15887 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
15888 record read return values.
15889
cc39a9db
BK
158902011-04-15 Ben Key <bkey76@gmail.com>
15891
c9d0ec6d
JB
15892 * keyboard.c (Qundefined): Don't declare static since it is used
15893 in nsfns.m.
15894 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
15895 static since they are used in nsfont.m.
cc39a9db 15896
6c60eb9f
SM
158972011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
15898
15899 * process.c (Qprocessp): Don't declare static.
15900 * lisp.h (Qprocessp): Declare again.
15901
7990b61a
JB
159022011-04-15 Juanma Barranquero <lekktu@gmail.com>
15903
15904 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
15905
5d4cb038
PE
159062011-04-14 Paul Eggert <eggert@cs.ucla.edu>
15907
8bd7b830 15908 Improve C-level modularity by making more things 'static'.
cd64ea1d 15909
e3b27b31
PE
15910 Don't publish debugger-only interfaces to other modules.
15911 * lisp.h (safe_debug_print, debug_output_compilation_hack):
15912 (verify_bytepos, count_markers): Move decls to the only modules
15913 that need them.
15914 * region-cache.h (pp_cache): Likewise.
15915 * window.h (check_all_windows): Likewise.
15916 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
15917
5d4cb038
PE
15918 * sysdep.c (croak): Now static, if
15919 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
15920 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
15921
15922 * alloc.c (refill_memory_reserve): Now static if
15923 !defined REL_ALLOC || defined SYSTEM_MALLOC.
15924 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 15925
e87b6180
PE
15926 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
15927 Define only if USE_LUCID.
15928
ac64929e
PE
15929 * xrdb.c (x_customization_string, x_rm_string): Now static.
15930
6f37259d
PE
15931 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
15932 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
15933
1683e3ab
PE
15934 * xdisp.c (draw_row_with_mouse_face): Now static.
15935 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
15936
de9c2632
PE
15937 * window.h (check_all_windows): Mark externally visible.
15938
2b96acb7
PE
15939 * window.c (window_deletion_count): Now static.
15940
15941 * undo.c: Make symbols static if they're not exported.
15942 (last_undo_buffer, last_boundary_position, pending_boundary):
15943 Now static.
15944
50436f33
PE
15945 * textprop.c (interval_insert_behind_hooks): Now static.
15946 (interval_insert_in_front_hooks): Likewise.
15947
64520e5c
PE
15948 * term.c: Make symbols static if they're not exported.
15949 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
15950 (max_frame_lines, tty_set_terminal_modes):
15951 (tty_reset_terminal_modes, tty_turn_off_highlight):
15952 (get_tty_terminal): Now static.
15953 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
15954 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 15955 HAVE_WINDOW_SYSTEM.
64520e5c
PE
15956 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
15957 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
15958
1fa53021
PE
15959 * sysdep.c: Make symbols static if they're not exported.
15960 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
15961 Now static.
15962 (sigprocmask_set, full_mask): Remove; unused.
15963 (wait_debugging): Mark as visible.
15964 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
15965 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
15966
d4b43b22
PE
15967 * syntax.c (syntax_temp): Define only if !__GNUC__.
15968
b7c513d0
PE
15969 * sound.c (current_sound_device, current_sound): Now static.
15970
989b29ad
PE
15971 * search.c (searchbufs, searchbuf_head): Now static.
15972
13a55a78
PE
15973 * scroll.c (scroll_cost): Remove; unused.
15974 * dispextern.h (scroll_cost): Remove decl.
15975
de68a1fc
PE
15976 * region-cache.h (pp_cache): Mark as externally visible.
15977
40ccffa6
PE
15978 * process.c: Make symbols static if they're not exported.
15979 (process_tick, update_tick, create_process, chan_process):
15980 (Vprocess_alist, proc_buffered_char, datagram_access):
15981 (fd_callback_data, send_process_frame, process_sent_to): Now static.
15982 (deactivate_process): Mark defn as static, as well as decl.
15983 * lisp.h (create_process): Remove decl.
15984 * process.h (chan_process, Vprocess_alist): Remove decls.
15985
ad64fc97
PE
15986 * print.c: Make symbols static if they're not exported.
15987 (print_depth, new_backquote_output, being_printed, print_buffer):
15988 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
15989 (print_interval, print_number_index, initial_stderr_stream):
15990 Now static.
15991 * lisp.h (Fprinc): Remove decl.
15992 (debug_output_compilation_hack): Mark as externally visible.
15993
adddb265
PE
15994 * sysdep.c (croak): Move decl from here to syssignal.h.
15995 * syssignal.h (croak): Put it here, so the API can be checked when
15996 'croak' is called from dissociate_if_controlling_tty.
15997
1717ede2
PE
15998 * minibuf.c: Make symbols static if they're not exported.
15999 (minibuf_save_list, choose_minibuf_frame): Now static.
16000 * lisp.h (choose_minibuf_frame): Remove decl.
16001
fa5fb2bc
PE
16002 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
16003
1e3890d1
PE
16004 * lread.c: Make symbols static if they're not exported.
16005 (read_objects, initial_obarray, oblookup_last_bucket_number):
16006 Now static.
16007 (make_symbol): Remove; unused.
16008 * lisp.h (initial_obarray, make_symbol): Remove decls.
16009
8a1414fa
PE
16010 * keyboard.c: Make symbols static if they're not exported.
16011 (single_kboard, recent_keys_index, total_keys, recent_keys):
16012 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
16013 (this_single_command_key_start, echoing, last_auto_save):
16014 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
16015 (command_loop, echo_now, keyboard_init_hook, help_char_p):
16016 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
16017 (Vlispy_mouse_stem, double_click_count):
16018 Now static.
16019 (force_auto_save_soon): Define only if SIGDANGER.
16020 (ignore_mouse_drag_p): Now static if
16021 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
16022 (print_help): Remove; unused.
16023 (stop_character, last_timer_event): Mark as externally visible.
16024 * keyboard.h (ignore_mouse_drag_p): Declare only if
16025 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
16026 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
16027 * lisp.h (echoing): Remove decl.
16028 (force_auto_save_soon): Declare only if SIGDANGER.
16029 * xdisp.c (redisplay_window): Simplify code, to make it more
16030 obvious that ignore_mouse_drag_p is not accessed if !defined
16031 USE_GTK && !defined HAVE_NS.
16032
93ea6e8f
PE
16033 * intervals.c: Make symbols static if they're not exported.
16034 (merge_properties_sticky, merge_interval_right, delete_interval):
16035 Now static.
16036 * intervals.h (merge_interval_right, delete_interval): Remove decls.
16037
77382fcc
PE
16038 * insdel.c: Make symbols static if they're not exported.
16039 However, leave prepare_to_modify_buffer alone. It's never
16040 called from outside this function, but that appears to be a bug.
16041 (combine_after_change_list, combine_after_change_buffer):
4889fc82 16042 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
16043 (adjust_after_replace_noundo): Remove; unused.
16044 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 16045 (signal_before_change): Remove decls.
77382fcc 16046
9306c32e
PE
16047 * indent.c (val_compute_motion, val_vmotion): Now static.
16048
cd44d2eb
PE
16049 * image.c: Make symbols static if they're not exported.
16050 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
16051 if USE_GTK.
16052 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
16053 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
16054
ad9a7a06
PE
16055 * fringe.c (standard_bitmaps): Now static.
16056 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
16057
81626931
PE
16058 * frame.c: Make symbols static if they're not exported.
16059 (x_report_frame_params, make_terminal_frame): Now static.
16060 (get_frame_param): Now static, unless HAVE_NS.
16061 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
16062 (x_get_resource_string): Remove; not used.
16063 * frame.h (make_terminal_frame, x_report_frame_params):
16064 (x_get_resource_string); Remove decls.
16065 (x_fullscreen_adjust): Declare only if WINDOWSNT.
16066 * lisp.h (get_frame_param): Declare only if HAVE_NS.
16067
239f9db9
PE
16068 * font.c, fontset.c: Make symbols static if they're not exported.
16069 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
16070 (FACE_SUITABLE_FOR_CHAR_P): Use it.
16071 * font.c (font_close_object): Now static.
16072 * font.h (font_close_object): Remove.
16073 * fontset.c (FONTSET_OBJLIST): Remove.
16074 (free_realized_fontset) #if-0 the body, which does nothing.
16075 (face_suitable_for_char_p): #if-0, as it's never called.
16076 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
16077 * xfaces.c (face_at_string_position):
16078 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
16079 since 0 is always ASCII.
16080
dfcf3579
PE
16081 * fns.c (weak_hash_tables): Now static.
16082
5045092b
PE
16083 * fileio.c: Make symbols static if they're not exported.
16084 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
16085 (Vwrite_region_annotation_buffers): Now static.
16086
57a96f5c
PE
16087 * eval.c: Make symbols static if they're not exported.
16088 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
16089 * lisp.h (backtrace_list): Remove decl.
16090
35f08c38
PE
16091 * emacs.c: Make symbols static if they're not exported.
16092 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
16093 (fatal_error_code, fatal_error_signal_hook, standard_args):
16094 Now static.
16095 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
16096 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
16097 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
16098 * lisp.h (fatal_error_signal_hook): Remove decl.
16099 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
16100
f44bd759
PE
16101 * editfns.c: Move a (normally-unused) function to its only use.
16102 * editfns.c, lisp.h (get_operating_system_release): Remove.
16103 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
16104 worth the hassle of breaking this out.
16105
b532497d
PE
16106 * xterm.c: Make symbols static if they're not exported.
16107 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
16108 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
16109 (x_destroy_window, x_delete_display):
16110 Now static.
16111 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
16112 (x_mouse_leave): Remove; unused.
16113 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
16114 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
16115 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
16116 Remove decls.
16117 (x_mouse_leave): Declare only if WINDOWSNT.
16118 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
16119 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
16120 USE_X_TOOLKIT.
16121
1675728f
PE
16122 * ftxfont.c: Make symbols static if they're not exported.
16123 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
16124 HAVE_FREETYPE.
16125 * font.h (ftxfont_driver): Likewise.
16126
e4cebfca
PE
16127 * xfns.c: Make symbols static if they're not exported.
16128 (x_last_font_name, x_display_info_for_name):
16129 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
16130 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
16131 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
16132 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
16133 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
16134 (last_show_tip_args): Now static.
16135 (xic_defaut_fontset, xic_create_fontsetname): Define only if
16136 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
16137 (x_screen_planes): Remove; unused.
16138 * dispextern.h (x_screen_planes): Remove decl.
16139
5bf46f05
PE
16140 * dispnew.c: Make symbols static if they're not exported.
16141 * dispextern.h (redraw_garbaged_frames, scrolling):
16142 (increment_row_positions): Remove.
16143 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
16144 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
16145 Now static.
16146 (redraw_garbaged_frames): Remove; unused.
16147
435f4c28
PE
16148 * xfaces.c: Make symbols static if they're not exported.
16149 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
16150 Remove decls.
16151 * xterm.h (defined_color): Remove decls.
16152 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
16153 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
16154 (menu_face_changed_default, defined_color, free_realized_face):
16155 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
16156 (ascii_face_of_lisp_face): Remove; unused.
16157
8524aef3
PE
16158 * xdisp.c: Make symbols static if they're not exported.
16159 * dispextern.h (scratch_glyph_row, window_box_edges):
16160 (glyph_to_pixel_coords, set_cursor_from_row):
16161 (get_next_display_element, set_iterator_to_next):
16162 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
16163 (show_mouse_face): Remove decls
16164 * frame.h (message_buf_print): Likewise.
16165 * lisp.h (pop_message, set_message, check_point_in_composition):
16166 Likewise.
16167 * xterm.h (set_vertical_scroll_bar): Likewise.
16168 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
16169 (message_buf_print, scratch_glyph_row, displayed_buffer):
16170 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
16171 (get_next_display_element, show_mouse_face, window_box_edges):
16172 (frame_to_window_pixel_xy, check_point_in_composition):
16173 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
16174 (glyph_to_pixel_coords): Remove; unused.
16175
16390cd2
PE
16176 * dired.c (file_name_completion): Now static.
16177
16178 * dbusbind.c (xd_in_read_queued_messages): Now static.
16179
a25f4dfa
PE
16180 * lisp.h (circular_list_error, FOREACH): Remove; unused.
16181 * data.c (circular_list_error): Remove.
16182
14a9c8df
PE
16183 * commands.h (last_point_position, last_point_position_buffer):
16184 (last_point_position_window): Remove decls.
16185 * keyboard.c: Make these variables static.
16186
04f2d78b
CB
16187 * coding.h (coding, code_convert_region, encode_coding_gap):
16188 Remove decls.
74ab6df5
PE
16189 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
16190 (iso_code_class, detect_coding, code_convert_region): Now static.
16191 (encode_coding_gap): Remove; unused.
16192
38dfbee1
PE
16193 * chartab.c (chartab_chars, chartab_bits): Now static.
16194
a2cb4e63
PE
16195 * charset.h (charset_iso_8859_1): Remove decl.
16196 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
16197 Now static.
16198
127198fd
PE
16199 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
16200 * ccl.c (Vccl_program_table): Now static.
16201 (check_ccl_update): Remove; unused.
16202
d85b608f
PE
16203 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
16204 * category.h: ... from here.
16205 * category.c (check_category_table, set_category_set): Now static.
16206
31cd66f3
PE
16207 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
16208 * lisp.h: Remove these decls.
16209
c358e587
PE
16210 * buffer.c (buffer_count): Remove unused var.
16211
e78aecca
PE
16212 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
16213 so that it's not optimized away.
16214 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
16215 * dispextern.h (bidi_dump_cached_states): Remove, since it's
16216 exported only to the debugger.
16217
e192d7d3 16218 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 16219 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 16220
92470028
PE
16221 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
16222 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
16223 was inaccessible from Lisp.
16224 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
16225 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
16226
244ed907
PE
16227 alloc.c: Import and export fewer symbols, and remove unused items.
16228 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
16229 is defined.
16230 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
16231 it's not optimized away by whole-program optimization.
16232 (message_enable_multibyte, free_misc): Remove.
16233 (catchlist, handlerlist, mark_backtrace):
16234 Declare only if BYTE_MARK_STACK.
16235 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
16236 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
16237 (message_enable_multibyte): Remove decl.
16238 (free_misc, interval_free_list, float_block, float_block_index):
16239 (n_float_blocks, float_free_list, cons_block, cons_block_index):
16240 (cons_free_list, last_marked_index):
16241 Now static.
16242 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
16243 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
16244 (mark_backtrace): Define only if BYTE_MARK_STACK.
16245 * xdisp.c (message_enable_multibyte): Now static.
16246
61c2b50e 16247 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
16248 This makes it easier for human readers (and static analyzers)
16249 to see whether these variables are used from other modules.
16250 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
16251 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
16252 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
16253 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
16254 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
16255 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
16256 * xmenu.c, xselect.c:
16257 Declare Q* vars static if they are not used in other modules.
16258 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
16259 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
16260 Remove decls of unexported vars.
16261 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
16262
95c82688
PE
16263 * lisp.h (DEFINE_FUNC): Make sname 'static'.
16264
16a97296
PE
16265 Make Emacs functions such as Fatom 'static' by default.
16266 This makes it easier for human readers (and static analyzers)
16267 to see whether these functions can be called from other modules.
16268 DEFUN now defines a static function. To make the function external
16269 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
16270 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
16271 (Finit_image_library):
16a97296
PE
16272 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
16273 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
16274 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
16275 Remove decls, since these functions are now static.
16276 (Funintern, Fget_internal_run_time): New decls, since these functions
16277 were already external.
95c82688 16278
16a97296
PE
16279 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
16280 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
16281 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
16282 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
16283 * keyboard.c, keymap.c, lread.c:
16284 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
16285 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
16286 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
16287 Mark functions with DEFUE instead of DEFUN,
16288 if they are used in other modules.
16289 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
16290 decls for now-static functions.
16291 * buffer.h (Fdelete_overlay): Remove decl.
16292 * callproc.c (Fgetenv_internal): Mark as internal.
16293 * composite.c (Fremove_list_of_text_properties): Remove decl.
16294 (Fcomposition_get_gstring): New forward static decl.
16295 * composite.h (Fcomposite_get_gstring): Remove decl.
16296 * dired.c (Ffile_attributes): New forward static decl.
16297 * doc.c (Fdocumntation_property): New forward static decl.
16298 * eval.c (Ffetch_bytecode): New forward static decl.
16299 (Funintern): Remove extern decl; now in .h file where it belongs.
16300 * fileio.c (Fmake_symbolic_link): New forward static decl.
16301 * image.c (Finit_image_library): New forward static decl.
16302 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
16303 * intervals.h (Fprevious_property_change):
16304 (Fremove_list_of_text_properties): Remove decls.
16305 * keyboard.c (Fthis_command_keys): Remove decl.
16306 (Fcommand_execute): New forward static decl.
16307 * keymap.c (Flookup_key): New forward static decl.
16308 (Fcopy_keymap): Now static.
16309 * keymap.h (Flookup_key): Remove decl.
16310 * process.c (Fget_process): New forward static decl.
16311 (Fprocess_datagram_address): Mark as internal.
16312 * syntax.c (Fsyntax_table_p): New forward static decl.
16313 (skip_chars): Remove duplicate decl.
16314 * textprop.c (Fprevious_property_change): New forward static decl.
16315 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
16316 Now internal.
16317 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
16318 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
16319
785bbd42
PE
16320 * editfns.c (Fformat): Remove unreachable code.
16321
8b913b57
AS
163222011-04-14 Andreas Schwab <schwab@linux-m68k.org>
16323
16324 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
16325 change. (Bug#8496)
16326
a6744a35
EZ
163272011-04-13 Eli Zaretskii <eliz@gnu.org>
16328
16329 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
16330 when at ZV. (Bug#8487)
16331
e7974947
AS
163322011-04-12 Andreas Schwab <schwab@linux-m68k.org>
16333
baad03f0
AS
16334 * charset.c (Fclear_charset_maps): Use xfree instead of free.
16335 (Bug#8437)
16336 * keyboard.c (parse_tool_bar_item): Likewise.
16337 * sound.c (sound_cleanup, alsa_close): Likewise.
16338 * termcap.c (tgetent): Likewise.
16339 * xfns.c (x_default_font_parameter): Likewise.
16340 * xsettings.c (read_and_apply_settings): Likewise.
16341
e7974947
AS
16342 * alloc.c (overrun_check_malloc, overrun_check_realloc)
16343 (overrun_check_free): Protoize.
16344
28272684
PE
163452011-04-12 Paul Eggert <eggert@cs.ucla.edu>
16346
16347 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
16348 since callers should never pass a negative size.
16349 Change the signature to match that of plain 'read' and 'write'; see
16350 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
16351 * lisp.h: Update prototypes of emacs_write and emacs_read.
16352
11997c76
EZ
163532011-04-11 Eli Zaretskii <eliz@gnu.org>
16354
16355 * xdisp.c (redisplay_window): Don't try to determine the character
16356 position of the scroll margin if the window start point w->startp
e896f03c 16357 is outside the buffer's accessible region. (Bug#8468)
11997c76 16358
8a2cbd72
EZ
163592011-04-10 Eli Zaretskii <eliz@gnu.org>
16360
16361 Fix write-region and its subroutines for buffers > 2GB.
16362 * fileio.c (a_write, e_write): Modify declaration of arguments and
16363 local variables to support buffers larger than 2GB.
16364 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
16365
16366 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
16367 argument, local variables, and return value.
16368
16369 * lisp.h: Update prototypes of emacs_write and emacs_read.
16370
16371 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
16372
4073e537 163732011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 16374
1ebfdcb6
PE
16375 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
16376
b2ded58d
PE
16377 Fix more problems found by GCC 4.6.0's static checks.
16378
7d66342c
PE
16379 * xdisp.c (vmessage): Use a better test for character truncation.
16380
bbf47d44
PE
16381 * charset.c (load_charset_map): <, not <=, for optimization,
16382 and to avoid potential problems with integer overflow.
9248994d 16383 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 16384 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 16385 * editfns.c (Fformat): Likewise.
1e69125e 16386 * syntax.c (skip_chars): Likewise.
3befa583 16387
e3019616
PE
16388 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
16389 This also lets GCC 4.6.0 generate slightly better loop code.
16390
becfa255
PE
16391 * callint.c (Fcall_interactively): <, not <=, for optimization.
16392 (Fcall_interactively): Count the number of arguments produced,
16393 not the number of arguments given. This is simpler and lets GCC
16394 4.6.0 generate slightly better code.
16395
dae0cd48
PE
16396 * ftfont.c: Distingish more carefully between FcChar8 and char.
16397 The previous code passed unsigned char * to a functions like
16398 strlen and xstrcasecmp that expect char *, which does not
16399 conform to the C standard.
16400 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
16401 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
16402 char * when the C standard requires it.
16403
76032d70
PE
16404 * keyboard.c (read_char): Remove unused var.
16405
eb3f1cc8
PE
16406 * eval.c: Port to Windows vsnprintf (Bug#8435).
16407 Include <limits.h>.
16408 (SIZE_MAX): Define if the headers do not.
16409 (verror): Do not give up if vsnprintf returns a negative count.
16410 Instead, grow the buffer. This ports to Windows vsnprintf, which
16411 does not conform to C99. Problem reported by Eli Zaretskii.
16412 Also, simplify the allocation scheme, by avoiding the need for
16413 calling realloc, and removing the ALLOCATED variable.
16414
70476b54
PE
16415 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
16416
12020a9e
PE
16417 Remove invocations of doprnt, as Emacs now uses vsnprintf.
16418 But keep the doprint source code for now, as we might revamp it
16419 and use it again (Bug#8435).
ea6c7ae6
PE
16420 * lisp.h (doprnt): Remove.
16421 * Makefile.in (base_obj): Remove doprnt.o.
16422 * deps.mk (doprnt.o): Remove.
16423
5fdb398c
PE
16424 error: Print 32- and 64-bit integers portably (Bug#8435).
16425 Without this change, on typical 64-bit hosts error ("...%d...", N)
16426 was used to print both 32- and 64-bit integers N, which relied on
16427 undefined behavior.
61bdb816 16428 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
16429 * lisp.h (error, verror): Mark as printf-like functions.
16430 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
16431 Report overflow in size calculations when allocating printf buffer.
16432 Do not truncate output string at its first null byte.
16433 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
16434 Truncate the output at a character boundary, since vsnprintf does not
16435 do that.
16436 * charset.c (check_iso_charset_parameter): Convert internal
16437 character to string before calling 'error', since %c now has the
16438 printf meaning.
16439 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
16440 overflow when computing char to be passed to 'error'. Do not
16441 pass Lisp_Object to 'error'; pass the integer instead.
16442 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
16443 formatted with plain %d.
16444
b189fa66
PE
16445 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
16446
bff87ef0
PE
16447 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
16448
7e2cac20
PE
16449 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
16450
ce4d90b5
PE
16451 * xterm.c (x_catch_errors): Remove duplicate declaration.
16452
266c9547
PE
16453 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
16454
79c49ad2
PE
16455 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16456
368f4090
JM
164572011-04-10 Jim Meyering <meyering@redhat.com>
16458
16459 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
16460 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
16461 return ssize_t not "int", and use size_t as the buffer length.
16462 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
16463 * gnutls.h: Update declarations.
16464 * process.c (read_process_output): Use ssize_t, to match.
16465 (send_process): Likewise.
16466
a32d4040
CY
164672011-04-09 Chong Yidong <cyd@stupidchicken.com>
16468
16469 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
16470
8546720e 164712011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 16472
04f2d78b
CB
16473 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
16474 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 16475
8546720e
GM
16476 * xterm.c (handle_one_xevent):
16477 * xmenu.c (create_and_show_popup_menu):
16478 * xselect.c (x_decline_selection_request)
16479 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 16480
0a2f5c1a 164812011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
16482
16483 Fix some uses of `int' instead of EMACS_INT.
16484 * search.c (string_match_1, fast_string_match)
16485 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
16486 (scan_buffer, find_next_newline_no_quit)
16487 (find_before_next_newline, search_command, Freplace_match)
16488 (Fmatch_data): Make some `int' variables be EMACS_INT.
16489
16490 * xdisp.c (display_count_lines): 3rd argument and return value now
16491 EMACS_INT. All callers changed.
16492 (pint2hrstr): Last argument is now EMACS_INT.
16493
16494 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
16495 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
16496 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
16497 (decode_coding_utf_16, decode_coding_emacs_mule)
16498 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
16499 (decode_coding_ccl, decode_coding_charset)
16500 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
16501 (decode_coding_iso_2022, decode_coding_emacs_mule)
16502 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
16503 <char_offset, last_offset>: Declare EMACS_INT.
16504 (encode_coding_utf_8, encode_coding_utf_16)
16505 (encode_coding_emacs_mule, encode_invocation_designation)
16506 (encode_designation_at_bol, encode_coding_iso_2022)
16507 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
16508 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
16509 Declare EMACS_INT.
16510 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
16511 (encode_invocation_designation): Last argument P_NCHARS is now
16512 EMACS_INT.
16513 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
16514 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
16515
16516 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
16517 All users changed.
16518
16519 * ccl.c (Fccl_execute_on_string): Declare some variables
16520 EMACS_INT.
16521
8546720e 165222011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
16523
16524 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
16525
4e19a977
CS
165262011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
16527
16528 * process.c (Fformat_network_address): Doc fix.
16529
87302331
R
165302011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
16531
ee7683eb 16532 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 16533
cbb59342
CY
165342011-04-08 Chong Yidong <cyd@stupidchicken.com>
16535
16536 * keyboard.c (read_char): Call Lisp function help-form-show,
16537 instead of using internal_with_output_to_temp_buffer.
16538 (Qhelp_form_show): New var.
e0d38eeb 16539 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
16540
16541 * print.c (internal_with_output_to_temp_buffer): Function deleted.
16542
16543 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
16544
e67a13ab
CY
165452011-04-06 Chong Yidong <cyd@stupidchicken.com>
16546
04f2d78b
CB
16547 * process.c (Flist_processes): Remove to Lisp.
16548 (list_processes_1): Delete.
e67a13ab 16549
973f782d
EZ
165502011-04-06 Eli Zaretskii <eliz@gnu.org>
16551
7c106b1e
EZ
16552 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
16553
973f782d
EZ
16554 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
16555
41cf7d1a 165562011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 16557
ca23cc88
PE
16558 Fix more problems found by GCC 4.6.0's static checks.
16559
f390e2d5
PE
16560 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
16561
42eea0d0
PE
16562 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
16563
b69769da 16564 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 16565
f9541e84
PE
16566 * xdisp.c (vmessage): Mark as a printf-like function.
16567
13841b55
PE
16568 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
16569
c136c10f
PE
16570 * sound.c (sound_warning): Don't crash if arg contains a printf format.
16571
5e2d4a30
PE
16572 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
16573 printf-like functions.
16574 (tiff_load): Add casts to remove these marks before passing them
16575 to system-supplied API.
16576
583f48b9
PE
16577 * eval.c (Fsignal): Remove excess argument to 'fatal'.
16578
b25d760e
PE
16579 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
16580 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
16581 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
16582 directly, rather than having caller test rule sign. This avoids
16583 some unnecessary tests.
16584 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
16585 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
16586 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 16587
bc7b6697 16588 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 16589 (xfont_open): Avoid unnecessary tests.
bc7b6697 16590
27ccc379
PE
16591 * composite.c (composition_gstring_put_cache): Use unsigned integer.
16592
dcd5c89a
PE
16593 * composite.h, composite.c (composition_gstring_put_cache):
16594 Use EMACS_INT, not int, for length.
16595
b13a45c6
PE
16596 * composite.h (COMPOSITION_DECODE_REFS): New macro,
16597 breaking out part of COMPOSITION_DECODE_RULE.
16598 (COMPOSITION_DECODE_RULE): Use it.
16599 * composite.c (get_composition_id): Remove unused local vars,
16600 by using the new macro.
16601
1e792e4d
PE
16602 * textprop.c (set_text_properties_1): Change while to do-while,
16603 since the condition is always true at first.
16604
dc6c6455 16605 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
16606 (interval_deletion_adjustment): Return unsigned value.
16607 All uses changed.
dc6c6455 16608
aba7731a
PE
16609 * process.c (list_processes_1, create_pty, read_process_output):
16610 (exec_sentinel): Remove vars that were set but not used.
afd4052b 16611 (create_pty): Remove unnecessary "volatile"s.
bc57d757 16612 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 16613 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 16614 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 16615
fdfc4bf3
PE
16616 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
16617
fca8fe46 16618 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 16619 (update_syntax_table): Use unsigned instead of int.
fca8fe46 16620
06a0259a 16621 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 16622 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 16623 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 16624
e7b9e80f
PE
16625 * print.c (print_error_message): Avoid int overflow.
16626
56201685
PE
16627 * font.c (font_list_entities): Redo for clarity,
16628 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
16629
78834453 16630 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 16631 (font_score): Avoid potential overflow in diff calculation.
78834453 16632
0bc0b309 16633 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 16634 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 16635
e610eaca
PE
16636 * eval.c (funcall_lambda): Rename local to avoid shadowing.
16637
b895abce
PE
16638 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
16639 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
16640 can always succeed if overflow has undefined behavior.
16641
1f1d9321 16642 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 16643 (wordify): Omit three unnecessary tests.
1f1d9321 16644
c59478bc
PE
16645 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
16646 All callers changed. This avoids the need for an unused var.
16647
79b73827
PE
16648 * casefiddle.c (casify_region): Remove var that is set but not used.
16649
a4db5dfe
PE
16650 * dired.c (file_name_completion): Remove var that is set but not used.
16651
43aae36e
PE
16652 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
16653
2a47c44d 16654 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 16655 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 16656
a37c69bf
PE
16657 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
16658 Check for integer overflow on size calculations.
16659
328ab8e7
PE
16660 * buffer.c (Fprevious_overlay_change): Remove var that is set
16661 but not used.
16662
e5a2a5cb
PE
16663 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
16664 Remove vars that are set but not used.
8d84a6eb 16665 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 16666 (timer_check_2): Mark vars as initialized.
e5a2a5cb 16667
a60e5f68
PE
16668 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
16669
f661cb61 16670 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 16671 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 16672
f0397f5a
PE
16673 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
16674 that are set but not used.
16675
8664db06 16676 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 16677 if XCreateBitmapFromData fails (Bug#8410).
8664db06 16678
6abdaa4a
PE
16679 * xselect.c (x_get_local_selection, x_handle_property_notify):
16680 Remove vars that are set but not used.
16681
0ce7538d 16682 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 16683 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 16684
9ae848fc
PE
16685 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
16686 Remove var that is set but not used.
0b918413
PE
16687 (scroll_bar_windows_size): Now size_t, not int.
16688 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
16689 Check for overflow.
9ae848fc 16690
a5a62657
PE
16691 * xfaces.c (realize_named_face): Remove vars that are set but not used.
16692 (map_tty_color) [!defined MSDOS]: Likewise.
16693
5c5cdd39
PE
16694 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
16695
66ebf983
PE
16696 * coding.c: Remove vars that are set but not used.
16697 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
16698 All callers changed.
16699 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
16700 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
16701 (decode_coding_charset): Remove vars that are set but not used.
16702
1be4d761
PE
16703 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
16704 that is set but not used.
16705
47553fa8
PE
16706 * print.c (print_object): Remove var that is set but not used.
16707
1f7196bf 16708 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
16709 The gnulib version avoids calling malloc in the usual case,
16710 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
16711 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
16712 * filelock.c (current_lock_owner): Likewise.
16713 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
16714 * sysdep.c: Include allocator.h, careadlinkat.h.
16715 (emacs_no_realloc_allocator): New static constant.
16716 (emacs_readlink): New function.
fdb61804
PE
16717 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
16718 ../lib/careadlinkat.h.
d1fdcab7 16719
f84c17c7
SM
167202011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
16721
16722 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
16723 first non-nil return value).
16724
ef3862ad
JD
167252011-04-03 Jan Djärv <jan.h.d@swipnet.se>
16726
16727 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
16728 if not defined (Bug#8403).
16729
376a7006
JB
167302011-04-02 Juanma Barranquero <lekktu@gmail.com>
16731
16732 * xdisp.c (display_count_lines): Remove parameter `start',
16733 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16734 (get_char_face_and_encoding): Remove parameter `multibyte_p',
16735 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16736 (fill_stretch_glyph_string): Remove parameters `row' and `area',
16737 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
16738 and thereabouts. All callers changed.
16739 (get_per_char_metric): Remove parameter `f', unused since
16740 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
16741
6ca3801d
JM
167422011-04-02 Jim Meyering <meyering@redhat.com>
16743
16744 do not dereference NULL upon failed strdup
16745 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
16746 (ns_get_family): Likewise.
16747
d8e2b5ba
JB
167482011-04-02 Juanma Barranquero <lekktu@gmail.com>
16749
16750 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
16751
8c74fcbd
JD
167522011-04-02 Jan Djärv <jan.h.d@swipnet.se>
16753
16754 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
16755 later (Bug#8403).
16756
7200d79c
SM
167572011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
16758
03408648 16759 Add lexical binding.
7200d79c 16760
03408648
SM
16761 * window.c (Ftemp_output_buffer_show): New fun.
16762 (Fsave_window_excursion):
16763 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
16764
16765 * lread.c (lisp_file_lexically_bound_p): New function.
16766 (Fload): Bind Qlexical_binding.
16767 (readevalloop): Remove `evalfun' arg.
16768 Bind Qinternal_interpreter_environment.
16769 (Feval_buffer): Bind Qlexical_binding.
16770 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
16771 Mark as dynamic.
16772 (syms_of_lread): Declare `lexical-binding'.
16773
16774 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
16775
16776 * keyboard.c (eval_dyn): New fun.
16777 (menu_item_eval_property): Use it.
ca105506
SM
16778
16779 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 16780
03408648
SM
16781 * fns.c (concat, mapcar1): Accept byte-code-functions.
16782
16783 * eval.c (Fsetq): Handle lexical vars.
16784 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
16785 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
16786 (FletX, Flet): Obey lexical binding.
16787 (Fcommandp): Handle closures.
16788 (Feval): New `lexical' arg.
16789 (eval_sub): New function extracted from Feval. Use it almost
16790 everywhere where Feval was used. Look up vars in lexical env.
16791 Handle closures.
16792 (Ffunctionp): Move from subr.el.
16793 (Ffuncall): Handle closures.
16794 (apply_lambda): Remove `eval_flags'.
16795 (funcall_lambda): Handle closures and new byte-code-functions.
16796 (Fspecial_variable_p): New function.
16797 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
16798 but without exporting it to Lisp.
23aba0ea 16799
23aba0ea 16800 * doc.c (Fdocumentation, store_function_docstring):
03408648 16801 * data.c (Finteractive_form): Handle closures.
23aba0ea 16802
03408648
SM
16803 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
16804 interactive spec.
ba83908c 16805
04f2d78b
CB
16806 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
16807 New byte-codes.
03408648
SM
16808 (exec_byte_code): New function extracted from Fbyte_code to handle new
16809 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 16810
03408648 16811 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 16812
03408648 16813 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 16814
e2abce01
JB
168152011-03-31 Juanma Barranquero <lekktu@gmail.com>
16816
16817 * xdisp.c (redisplay_internal): Fix prototype.
16818
63696a73 168192011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 16820
63696a73 16821 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
16822 (try_scrolling): Use it when setting scroll_limit.
16823 Limit scrolling to 100 screen lines.
63696a73
EZ
16824 (redisplay_window): Even when falling back on "recentering",
16825 position point in the window according to scroll-conservatively,
16826 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
16827
16828 (try_scrolling): When point is above the window, allow searching
16829 as far as scroll_max, or one screenful, to compute vertical
16830 distance from PT to the scroll margin position. This prevents
16831 try_scrolling from unnecessarily failing when
16832 scroll-conservatively is set to a value slightly larger than the
16833 window height. Clean up the case of PT below the margin at bottom
16834 of window: scroll_max can no longer be INT_MAX. When aggressive
16835 scrolling is in use, don't let point enter the opposite scroll
16836 margin as result of the scroll.
16837 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
16838 threshold of 100 lines for never-recentering scrolling.
16839
e4cc2dfc
JB
168402011-03-31 Juanma Barranquero <lekktu@gmail.com>
16841
16842 * dispextern.h (move_it_by_lines):
16843 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
16844 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
16845 (message_log_check_duplicate): Remove parameters `prev_bol' and
16846 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
16847 (redisplay_internal): Remove parameter `preserve_echo_area',
16848 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
16849
16850 * indent.c (Fvertical_motion):
16851 * window.c (window_scroll_pixel_based, Frecenter):
16852 Don't pass `need_y_p' to `move_it_by_lines'.
16853
1c470562
SM
168542011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
16855
44f230aa
SM
16856 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
16857 steal a few bits to be more compact.
16858 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
16859 Remove unneeded casts.
16860
1c470562
SM
16861 * bytecode.c (Fbyte_code): CAR and CDR can GC.
16862
888adce9
ZK
168632011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
16864
16865 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
16866 binding" message (bug#7967).
16867
f838ed7b
PE
168682011-03-30 Paul Eggert <eggert@cs.ucla.edu>
16869
77861b95
PE
16870 Fix more problems found by GCC 4.6.0's static checks.
16871
de6dbc14
PE
16872 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
16873 Remove unused local var.
16874
f838ed7b
PE
16875 * editfns.c (Fmessage_box): Remove unused local var.
16876
792c7b2b
PE
16877 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
16878 (note_mode_line_or_margin_highlight, note_mouse_highlight):
16879 Omit unused local vars.
c499e557 16880 * window.c (shrink_windows): Omit unused local var.
b01a1c29 16881 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
16882 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
16883 Omit unused local var.
16884
ba0165e1
PE
16885 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
16886 Don't assume string length fits in int.
32ad8845 16887 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 16888 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 16889
3c59b4c9
PE
16890 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
16891 instead of alloca (Bug#8344).
16892
a3eed478 16893 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 16894 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 16895
eb4d412d
PE
16896 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
16897
1658b401
PE
16898 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
16899 concerns.
16900
16901 * term.c (produce_glyphless_glyph): Remove unnecessary test.
16902
16903 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 16904
9a2c6e05
PE
16905 * keyboard.c (syms_of_keyboard): Use the same style as later
16906 in this function when indexing through an array. This also
16907 works around GCC bug 48267.
16908
03d0a109
PE
16909 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
16910
44f730c8
PE
16911 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
16912
fe75f926
PE
16913 * chartab.c (sub_char_table_ref_and_range): Redo for slight
16914 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
16915
ffa8c828
PE
16916 * keyboard.c, keyboard.h (num_input_events): Now size_t.
16917 This avoids undefined behavior on integer overflow, and is a bit
16918 more convenient anyway since it is compared to a size_t variable.
16919
c5101a77
PE
16920 Variadic C functions now count arguments with size_t, not int.
16921 This avoids an unnecessary limitation on 64-bit machines, which
16922 caused (substring ...) to crash on large vectors (Bug#8344).
16923 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
16924 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 16925 All variadic functions and their callers changed accordingly.
c5101a77
PE
16926 (struct gcpro.nvars): Now size_t, not int. All uses changed.
16927 * data.c (arith_driver, float_arith_driver): Likewise.
16928 * editfns.c (general_insert_function): Likewise.
16929 * eval.c (struct backtrace.nargs, interactive_p)
16930 (internal_condition_case_n, run_hook_with_args, apply_lambda)
16931 (funcall_lambda, mark_backtrace): Likewise.
16932 * fns.c (concat): Likewise.
16933 * frame.c (x_set_frame_parameters): Likewise.
16934 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
16935 0 if not found, not -1. All callers changed.
16936
dd3f25f7
PE
16937 * alloc.c (garbage_collect): Don't assume stack size fits in int.
16938 (stack_copy_size): Now size_t, not int.
16939 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
16940
461c2ab9
JB
169412011-03-28 Juanma Barranquero <lekktu@gmail.com>
16942
16943 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
16944 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16945 All callers changed.
16946
16947 * lisp.h (multibyte_char_to_unibyte):
16948 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
16949 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
16950 * character.h (CHAR_TO_BYTE8):
16951 * cmds.c (internal_self_insert):
16952 * editfns.c (general_insert_function):
16953 * keymap.c (push_key_description):
16954 * search.c (Freplace_match):
16955 * xdisp.c (message_dolog, set_message_1): All callers changed.
16956
f6d62986
SM
169572011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
16958
16959 * keyboard.c (safe_run_hook_funcall): New function.
16960 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
16961 don't set the hook to nil, but remove the offending function instead.
16962 (Qcommand_hook_internal): Remove, unused.
16963 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
16964 Vcommand_hook_internal.
16965
16966 * eval.c (enum run_hooks_condition): Remove.
16967 (funcall_nil, funcall_not): New functions.
16968 (run_hook_with_args): Call each function through a `funcall' argument.
16969 Remove `cond' argument, now redundant.
16970 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
16971 (Frun_hook_with_args_until_failure): Adjust accordingly.
16972 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
16973
1db5b1ad
JB
169742011-03-28 Juanma Barranquero <lekktu@gmail.com>
16975
16976 * dispextern.h (string_buffer_position): Remove declaration.
16977
16978 * print.c (strout): Remove parameter `multibyte', unused since
16979 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
16980
16981 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
16982 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
16983 All callers changed.
16984
16985 * w32.c (_wsa_errlist): Use braces for struct initializers.
16986
16987 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
16988 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
16989 All callers changed.
16990 (string_buffer_position): Likewise. Also, make static (it's never
16991 used outside xdisp.c).
16992 (cursor_row_p): Remove parameter `w', unused since
16993 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
16994 (decode_mode_spec): Remove parameter `precision', introduced during
16995 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
16996 All callers changed.
16997
5ffb62aa
JD
169982011-03-27 Jan Djärv <jan.h.d@swipnet.se>
16999
17000 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
17001
461c2ab9 170022011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
17003
17004 * nsterm.m (ns_menu_bar_is_hidden): New variable.
17005 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
17006 (ns_update_auto_hide_menu_bar): New functions.
17007 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
17008 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
17009 ns_constrain_all_frames.
17010 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
17011 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
17012
5c380ffb
JD
170132011-03-27 Jan Djärv <jan.h.d@swipnet.se>
17014
17015 * nsmenu.m (runDialogAt): Remove argument to timer_check.
17016
9af30bdf
GM
170172011-03-27 Glenn Morris <rgm@gnu.org>
17018
17019 * syssignal.h: Replace RETSIGTYPE with void.
17020 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
17021 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
17022 Replace SIGTYPE with void everywhere.
17023 * s/usg5-4-common.h (SIGTYPE): Remove definition.
17024 * s/template.h (SIGTYPE): Remove commented out definition.
17025
e2abce01
JB
170262011-03-26 Eli Zaretskii <eliz@gnu.org>
17027
17028 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
17029 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
17030
f868cd8a
JB
170312011-03-26 Juanma Barranquero <lekktu@gmail.com>
17032
59eb0929
JB
17033 * w32.c (read_unc_volume): Use parameter `henum', instead of
17034 global variable `wget_enum_handle'.
17035
17036 * keymap.c (describe_vector): Remove parameters `indices' and
17037 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
17038 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
17039
f868cd8a
JB
17040 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
17041
17042 * keyboard.c (timer_check): Remove parameter `do_it_now',
17043 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
17044 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
17045 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
17046
17047 * keyboard.c (read_char):
17048 * w32menu.c (w32_menu_display_help):
17049 * xmenu.c (show_help_event, menu_help_callback):
17050 Adjust calls to `show_help_echo'.
17051
17052 * gtkutil.c (xg_maybe_add_timer):
17053 * keyboard.c (readable_events):
17054 * process.c (wait_reading_process_output):
17055 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
17056
17057 * insdel.c (adjust_markers_gap_motion):
17058 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
17059 (gap_left, gap_right): Don't call it.
17060
2ecf6fdb
CY
170612011-03-25 Chong Yidong <cyd@stupidchicken.com>
17062
17063 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
17064 incurred during fontification.
17065
6b1f9ba4
JB
170662011-03-25 Juanma Barranquero <lekktu@gmail.com>
17067
17068 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
17069 (DEFVAR_PER_BUFFER): Don't pass it.
17070
17071 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
17072 (scrolling_window): Don't pass it.
17073
0f4a96b5
JB
170742011-03-25 Juanma Barranquero <lekktu@gmail.com>
17075
17076 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
17077
17078 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
17079 and `suffix'.
17080 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
17081 of variables specific to SELinux and computation of `encoded_absname'.
17082
17083 * image.c (XPutPixel): Remove unused variable `height'.
17084
17085 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
17086
17087 * unexw32.c (get_section_info): Remove unused variable `section'.
17088
17089 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
17090 (system_process_attributes): Remove unused variable `sess'.
17091 (sys_read): Remove unused variable `err'.
17092
17093 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
17094 (w32_wnd_proc): Remove unused variable `isdead'.
17095 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
17096 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
17097 (x_create_tip_frame): Remove unused variable `tem'.
17098
17099 * w32inevt.c (w32_console_read_socket):
17100 Remove unused variable `no_events'.
17101
17102 * w32term.c (x_draw_composite_glyph_string_foreground):
17103 Remove unused variable `width'.
17104
1149507c
JB
171052011-03-24 Juanma Barranquero <lekktu@gmail.com>
17106
17107 * w32term.c (x_set_glyph_string_clipping):
17108 Don't pass uninitialized region to CombineRgn.
17109
9c88f339
JB
171102011-03-23 Juanma Barranquero <lekktu@gmail.com>
17111
17112 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
17113 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
17114 (Fx_close_connection): Remove unused variable `i'.
17115
17116 * w32font.c (w32font_draw): Return number of glyphs.
17117 (w32font_open_internal): Remove unused variable `i'.
17118 (w32font_driver): Add missing initializer.
17119
17120 * w32menu.c (utf8to16): Remove unused variable `utf16'.
17121 (fill_in_menu): Remove unused variable `items_added'.
17122
17123 * w32term.c (last_mouse_press_frame): Remove static global variable.
17124 (w32_clip_to_row): Remove unused variable `f'.
17125 (x_delete_terminal): Remove unused variable `i'.
17126
17127 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
17128 (NOTHING): Remove unused static global variable.
17129 (uniscribe_check_otf): Remove unused variable `table'.
17130 (uniscribe_font_driver): Add missing initializers.
17131
dee091a3
JD
171322011-03-23 Julien Danjou <julien@danjou.info>
17133
17134 * term.c (Fsuspend_tty, Fresume_tty):
17135 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
17136 * window.c (temp_output_buffer_show):
17137 * insdel.c (signal_before_change):
17138 * frame.c (Fhandle_switch_frame):
17139 * fileio.c (Fdo_auto_save):
17140 * emacs.c (Fkill_emacs):
17141 * editfns.c (save_excursion_restore):
17142 * cmds.c (internal_self_insert):
17143 * callint.c (Fcall_interactively):
17144 * buffer.c (Fkill_all_local_variables):
17145 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
17146 Use Frun_hooks.
0f4a96b5 17147 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 17148 unconditionally since it does the check itself.
dee091a3 17149
2c520ab5 171502011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 17151
c9c49752
PE
17152 Fix more problems found by GCC 4.5.2's static checks.
17153
8abc3f12
PE
17154 * coding.c (encode_coding_raw_text): Avoid unnecessary test
17155 the first time through the loop, since we know p0 < p1 then.
17156 This also avoids a gcc -Wstrict-overflow warning.
17157
a2d26660
PE
17158 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
17159 leading to a memory leak, possible in functions like
17160 load_charset_map_from_file that can allocate an unbounded number
b12ef411 17161 of objects (Bug#8318).
a2d26660 17162
916c72e9
PE
17163 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
17164 that could (at least in theory) be that large.
17165
19ab8a18
PE
17166 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
17167 This is less likely to overflow, and avoids undefined behavior if
17168 overflow does occur. All callers changed. Use strtoul to scan
17169 for the unsigned long integer.
b7cbbd6f
PE
17170 (pint2hrstr): Simplify and tune code slightly.
17171 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 17172
f0641eff
PE
17173 * scroll.c (do_scrolling): Work around GCC bug 48228.
17174 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
17175
7f650bb9
PE
17176 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
17177 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
17178 (validate_x_resource_name): Simplify count usage.
17179 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 17180
37dd57d1
PE
17181 * fileio.c (Fcopy_file): Report error if fchown or fchmod
17182 fail (Bug#8306).
81e56e61 17183
699979fc 17184 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 17185
401bf9b4
PE
17186 * process.c (Fmake_network_process): Use socklen_t, not int,
17187 where POSIX says socklen_t is required in portable programs.
17188 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 17189 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
17190 (Fmake_network_process, server_accept_connection):
17191 (wait_reading_process_output, read_process_output):
17192 Likewise.
17193
b93aacde
PE
17194 * process.c: Rename or move locals to avoid shadowing.
17195 (list_processes_1, Fmake_network_process):
17196 (read_process_output_error_handler, exec_sentinel_error_handler):
17197 Rename or move locals.
4dc343ee 17198 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 17199 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 17200 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 17201 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 17202 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 17203
af8a867c 17204 Make tparam.h and terminfo.c consistent.
44f230aa
SM
17205 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
17206 Include tparam.h instead, since it declares them.
af8a867c
PE
17207 * cm.h (PC): Remove extern decl; tparam.h now does this.
17208 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
17209 * terminfo.c: Include tparam.h, to check interfaces.
17210 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
17211 (tparam): Adjust signature to match interface in tparam.h;
17212 this removes some undefined behavior. Check that outstring and len
17213 are zero, which they always are with Emacs.
17214 * tparam.h (PC, BC, UP): New extern decls.
17215
0248044d 17216 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 17217 (xftfont_open): Rename locals to avoid shadowing.
0248044d 17218
8ff096c1 17219 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
17220 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
17221 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 17222 (ftfont_list): Remove unused local.
49eaafba
PE
17223 (get_adstyle_property, ftfont_pattern_entity):
17224 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
17225 Rename locals to avoid shadowing.
8ff096c1 17226
e2be39f6
PE
17227 * xfont.c (xfont_list_family): Mark var as initialized.
17228
c9735e30
PE
17229 * xml.c (make_dom): Now static.
17230
8f5201ae
PE
17231 * composite.c (composition_compute_stop_pos): Rename local to
17232 avoid shadowing.
b246f932
PE
17233 (composition_reseat_it): Remove unused locals.
17234 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 17235 (composition_update_it): Mark var as initialized.
11b61122
PE
17236 (find_automatic_composition): Mark vars as initialized,
17237 with a FIXME (Bug#8290).
8f5201ae 17238
760fbc2c
PE
17239 character.h: Rename locals to avoid shadowing.
17240 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
17241 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
17242 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
17243 (BUF_DEC_POS): Be more systematic about renaming local temporaries
17244 to avoid shadowing.
17245
ff08eb85
PE
17246 * textprop.c (property_change_between_p): Remove; unused.
17247
fc7bf025
PE
17248 * intervals.c (interval_start_pos): Now static.
17249
235d7abc
PE
17250 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
17251
44f230aa
SM
17252 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
17253 Rename locals to avoid shadowing.
3e7d6594 17254
50060332
PE
17255 * sound.c (wav_play, au_play, Fplay_sound_internal):
17256 Fix pointer signedness.
d01f234b 17257 (alsa_choose_format): Remove unused local var.
c83b8872
PE
17258 (wav_play): Initialize a variable to 0, to prevent undefined
17259 behavior (Bug#8278).
50060332 17260
c4fc4e30
PE
17261 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
17262
918436ed
PE
17263 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
17264
c939f91b
PE
17265 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
17266 clobbering (Bug#8298).
b9c7f648
PE
17267 * sysdep.c (sys_subshell): Likewise.
17268 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 17269
6bd8c144
PE
17270 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
17271 This should get cleaned up, so that child_setup has the
17272 same signature on all platforms.
17273
7710357c 17274 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 17275 (relocate_fd): Rename locals to avoid shadowing.
7710357c 17276
c59da222
CY
172772011-03-22 Chong Yidong <cyd@stupidchicken.com>
17278
17279 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
17280 not to be necessary, and produces flickering.
17281
66b87493
GM
172822011-03-20 Glenn Morris <rgm@gnu.org>
17283
17284 * config.in: Remove file.
17285
45b6f6d5
JB
172862011-03-20 Juanma Barranquero <lekktu@gmail.com>
17287
17288 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
17289 are now in src/globals.h.
17290 (syms_of_minibuf): Remove spurious & from previous change.
17291
cd394be1 172922011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
17293
17294 * minibuf.c (completing-read-function): New variable.
17295 (completing-read-default): Rename from completing-read.
17296 (completing-read): Call completing-read-function.
17297
b14e3e21
CY
172982011-03-19 Juanma Barranquero <lekktu@gmail.com>
17299
17300 * xfaces.c (Fx_load_color_file):
17301 Read color file from absolute filename (bug#8250).
17302
f2b726e6
JB
173032011-03-19 Juanma Barranquero <lekktu@gmail.com>
17304
17305 * makefile.w32-in: Update dependencies.
17306
09f6ff02
EZ
173072011-03-17 Eli Zaretskii <eliz@gnu.org>
17308
17309 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
17310
29a6015a
PE
173112011-03-17 Paul Eggert <eggert@cs.ucla.edu>
17312
a3a6c54e
PE
17313 Fix more problems found by GCC 4.5.2's static checks.
17314
b766f867
PE
17315 * process.c (make_serial_process_unwind, send_process_trap):
17316 (sigchld_handler): Now static.
17317
be02381c
PE
17318 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
17319 That way, the code declares only the vars that it needs.
17320 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
17321 * s/cygwin.h (PTY_ITERATION): Likewise.
17322 * s/darwin.h (PTY_ITERATION): Likewise.
17323 * s/gnu-linux.h (PTY_ITERATION): Likewise.
17324
57048744
PE
17325 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
17326 * process.c (allocate_pty): Don't declare stb unless it's needed.
17327
7914961c 17328 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
17329 (CONSTANTLIM): Remove; unused.
17330 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
17331 Define only if needed.
7914961c 17332
b3967b18
PE
17333 * unexelf.c (unexec): Name an expression,
17334 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
17335 Use a different way to cause a compilation error if anyone uses
17336 n rather than nn, a way that does not involve shadowing.
73366a00 17337 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 17338
29a6015a
PE
17339 * deps.mk (unexalpha.o): Remove; unused.
17340
43cfc33e 17341 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 17342 * unexec.h: New file.
ce701a33
PE
17343 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
17344 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
17345 Depend on unexec.h.
17346 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
17347 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
17348 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 17349 Change as necessary to match prototype in unexec.h.
ce701a33 17350
01f44d5a
PE
17351 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
17352 shadowing.
4f63c6bb 17353 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 17354
a6670b0b
PE
17355 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
17356 Rename locals to avoid shadowing.
17357
cef2010d 17358 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 17359 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 17360
d4d7173a
PE
17361 * print.c (Fredirect_debugging_output): Fix pointer signedess.
17362
f08b802a
PE
17363 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
17364 warning when compiling print.c.
17365
3ddb0639
PE
17366 * font.c (font_unparse_fcname): Abort in an "impossible" situation
17367 instead of using an uninitialized var.
5ad03b97 17368 (font_sort_entities): Mark var as initialized.
3ddb0639 17369
170a2692
PE
17370 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
17371
e663c700
PE
17372 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
17373 pointers to constants.
89bc529a 17374 (font_parse_fcname): Remove unused vars.
7b81e2d0 17375 (font_delete_unmatched): Now static.
ea838e10 17376 (font_get_spec): Remove; unused.
13a547c6
PE
17377 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
17378 (font_update_drivers, Ffont_get_glyphs, font_add_log):
17379 Rename or move locals to avoid shadowing.
e663c700 17380
2a80c887 17381 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 17382 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 17383
1384fa33 17384 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 17385 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 17386
8b2c52e9
PE
17387 * alloc.c (mark_backtrace): Move decl from here ...
17388 * lisp.h: ... to here, so that it can be checked.
17389
475545b5 17390 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 17391 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
17392 (lisp_indirect_variable): Name an expression,
17393 to avoid gcc -Wbad-function-cast warning.
1faed8ae 17394 (Fdefvar): Rename locals to avoid shadowing.
475545b5 17395
b1349114 17396 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 17397 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 17398 Use const pointer when appropriate.
b1349114 17399
a2928364
PE
17400 * lisp.h (get_system_name, get_operating_system_release):
17401 Move decls here, to check interfaces.
17402 * process.c (get_operating_system_release): Move decl to lisp.h.
17403 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
17404 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
17405 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
17406 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
17407 (Fformat_time_string, Fencode_time, Finsert_char):
17408 (Ftranslate_region_internal, Fformat):
17409 Rename or remove local vars to avoid shadowing.
9710023e 17410 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 17411
a415e694
PE
17412 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
17413 avoid shadowing.
17414
8ef4622d
PE
17415 * lisp.h (eassert): Check that the argument compiles, even if
17416 ENABLE_CHECKING is not defined.
17417
946f9a5b
PE
17418 * data.c (Findirect_variable): Name an expression, to avoid
17419 gcc -Wbad-function-cast warning.
112396d6 17420 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 17421 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
17422 (Fmake_variable_buffer_local, Fmake_local_variable):
17423 Mark variables as initialized.
52746918 17424 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 17425
e5aab7e7 17426 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
17427 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
17428 Rename locals to avoid shadowing.
dff45157
PE
17429 (mark_stack): Move local variables into the #ifdef region where
17430 they're used.
7bc26fdb
PE
17431 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
17432 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
17433 needed otherwise.
17434 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
17435 (GC_STRING_CHARS): Remove; not used.
d40d4be1 17436 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 17437
e5aab7e7
PE
17438 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
17439 avoids undefined behavior in theory.
17440
4da60324
PE
17441 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
17442
88043301
PE
17443 Use functions, not macros, for up- and down-casing (Bug#8254).
17444 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17445 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
17446 to use the following functions instead of these macros.
17447 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
17448 EMACS_INT, since callers assume the returned value fits in int.
17449 (upcase1): Likewise, for UPCASE_TABLE.
17450 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 17451 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 17452 the race-condition problem in the old DOWNCASE.
88043301 17453
19ed5445
PE
17454 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
17455 Rename locals to avoid shadowing.
17456 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
17457 (regex_compile, re_search_2, re_match_2_internal):
17458 Remove unused local vars.
952db0d7
PE
17459 (FREE_VAR): Rewrite so as not to use empty "else",
17460 which gcc can warn about.
da053e48 17461 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
17462 (RETALLOC_IF): Define only if needed.
17463 (WORDCHAR_P): Likewise. This one is never needed, but is used
17464 only in a comment talking about a compiler bug, so put inside
17465 the #if 0 of that comment.
17466 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
17467 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
17468 Remove; unused.
19ed5445 17469
1f3561e4 17470 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
17471 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
17472 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 17473
ded6f8f7
PE
17474 * search.c (simple_search): Remove unused var.
17475
dbd37a95
PE
17476 * dired.c (compile_pattern): Move decl from here ...
17477 * lisp.h: ... to here, so that it can be checked.
17478 (struct re_registers): New forward decl.
17479
7e47afad
PE
17480 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
17481
85f24f61
PE
17482 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
17483 All uses changed.
17484 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
17485 Rename locals to avoid shadowing.
5671df8f 17486 (Fvertical_motion): Mark locals as initialized.
85f24f61 17487
181aa2be 17488 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 17489 (casify_region): Mark local as initialized.
181aa2be 17490
930d429c
PE
17491 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
17492
7082eac6
PE
17493 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
17494 New macros, so that the caller can use some names other than
17495 gcpro1, gcpro2, etc.
17496 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
17497 of the new macros.
17498 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
17499 argument, for consistency with GCPRO2_VAR, etc: it is now the
17500 prefix of the variable, not the variable itself. All uses
17501 changed.
38b2c076
PE
17502 * dired.c (directory_files_internal, file_name_completion):
17503 Rename locals to avoid shadowing.
17504
15206ed9
PE
17505 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
17506 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
17507 dired.c's scmp function, had undefined behavior.
17508 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
17509 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
17510 * buffer.h: ... to here, because these macros use current_buffer,
17511 and the new implementation with inline functions needs to have
17512 current_buffer in scope now, rather than later when the macros
17513 are used.
17514 (downcase, upcase1): New static inline functions.
17515 (DOWNCASE, UPCASE1): Reimplement using these functions.
17516 This avoids undefined behavior in expressions like
17517 DOWNCASE (x) == DOWNCASE (y), which previously suffered
17518 from race conditions in accessing the global variables
17519 case_temp1 and case_temp2.
17520 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
17521 * lisp.h (case_temp1, case_temp2): Remove their decls.
17522 * character.h (ASCII_CHAR_P): Move from here ...
17523 * lisp.h: ... to here, so that the inline functions mentioned
17524 above can use them.
17525
4a6bea26
PE
17526 * dired.c (directory_files_internal_unwind): Now static.
17527
f14b7e14
PE
17528 * fileio.c (file_name_as_directory, directory_file_name):
17529 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
17530 Now static.
2893f146
PE
17531 (file_name_as_directory): Use const pointers when appropriate.
17532 (Fexpand_file_name): Likewise. In particular, newdir might
17533 point at constant storage, so make it a const pointer.
fd4ead52 17534 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
17535 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
17536 signedness issues.
f839df0c
PE
17537 (Fset_file_times, Finsert_file_contents, auto_save_error):
17538 Rename locals to avoid shadowing.
f14b7e14 17539
5716756e 17540 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
17541 (Ftry_completion, Fall_completions): Rename or remove locals
17542 to avoid shadowing.
5716756e 17543
b4c3046a
PE
17544 * marker.c (bytepos_to_charpos): Remove; unused.
17545
b45db522
PE
17546 * lisp.h (verify_bytepos, count_markers): New decls,
17547 so that gcc does not warn that these functions aren't declared.
17548
85876d07
PE
17549 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
17550 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 17551 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 17552 (copy_text): Remove unused local var.
85876d07 17553
03d78a21 17554 * filelock.c (within_one_second): Now static.
b3dd38ab 17555 (lock_file_1): Rename local to avoid shadowing.
03d78a21 17556
5df8f01b
PE
17557 * buffer.c (fix_overlays_before): Mark locals as initialized.
17558 (fix_start_end_in_overlays): Likewise. This function should be
17559 simplified by using pointers-to-pointers, but that's a different
17560 matter.
b1d876f1 17561 (switch_to_buffer_1): Now static.
8f54f30a
PE
17562 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
17563 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 17564
a70072c9 17565 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 17566 Fix pointer signedness issue.
edced198
PE
17567 (sys_subshell): Mark local as volatile if checking for lint,
17568 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 17569 (MAXPATHLEN): Define only if needed.
a70072c9 17570
a0977c44
PE
17571 * process.c (serial_open, serial_configure): Move decls from here ...
17572 * systty.h: ... to here, so that they can be checked.
17573
a884fdcc
PE
17574 * fns.c (get_random, seed_random): Move extern decls from here ...
17575 * lisp.h: ... to here, so that they can be checked.
17576
604efe86 17577 * sysdep.c (reset_io): Now static.
b8950c94 17578 (wait_for_termination_signal): Remove; unused.
604efe86 17579
38fc62d9
PE
17580 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
17581 (copy_keymap_item, append_key, push_text_char_description):
17582 Now static.
1004a21a 17583 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 17584 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
17585 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
17586 (describe_map_tree):
17587 Rename locals to avoid shadowing.
38fc62d9 17588
2f2650da
PE
17589 * keyboard.c: Declare functions static if they are not used elsewhere.
17590 (echo_char, echo_dash, cmd_error, top_level_2):
17591 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
17592 (read_char, kbd_buffer_get_event, make_lispy_position):
17593 (make_lispy_event, make_lispy_movement, apply_modifiers):
17594 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
17595 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
17596 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 17597 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 17598 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 17599
a053e86c 17600 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
17601 (mark_kboards): Move decl here ...
17602 * alloc.c (mark_kboards): ... from here.
a053e86c 17603
4752793e
PE
17604 * lisp.h (force_auto_save_soon): New decl.
17605
74f10ca7 17606 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
17607 (DEFINE_DUMMY_FUNCTION): New macro.
17608 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
17609 Use it.
c03cd23f
PE
17610 (main): Add casts to avoid warnings
17611 if GCC considers string literals to be constants.
74f10ca7 17612
022e70d4
PE
17613 * lisp.h (fatal_error_signal): Add decl, since it's exported.
17614
59d6fe83
PE
17615 * dbusbind.c: Pointer signedness fixes.
17616 (xd_signature, xd_append_arg, xd_initialize):
17617 (Fdbus_call_method, Fdbus_call_method_asynchronously):
17618 (Fdbus_method_return_internal, Fdbus_method_error_internal):
17619 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
17620 (Fdbus_register_signal): Use SSDATA when the context wants char *.
17621
78320123
PE
17622 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
17623 if GCC considers string literals to be constants.
49cebcca 17624 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 17625
35ac2a97
SM
176262011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
17627
fb103ca9
SM
17628 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
17629 (print_preprocess, print_object): New macro to fix last change.
17630
35ac2a97
SM
17631 * print.c (print_preprocess): Don't forget font objects.
17632
62973b41
JB
176332011-03-16 Juanma Barranquero <lekktu@gmail.com>
17634
17635 * emacs.c (USAGE3): Doc fixes.
17636
0e48bb22
AS
176372011-03-15 Andreas Schwab <schwab@linux-m68k.org>
17638
17639 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
17640 structure.
17641
7684e57b
JB
176422011-03-14 Juanma Barranquero <lekktu@gmail.com>
17643
17644 * lisp.h (VWindow_system, Qfile_name_history):
17645 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
17646 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
17647 (w32_system_caret_x, w32_system_caret_y): Declare extern.
17648
17649 * w32select.c: Don't #include "keyboard.h".
c96bbc66 17650 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
17651
17652 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
17653 * w32console.c (detect_input_pending, read_input_pending)
17654 (encode_terminal_code):
17655 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
17656 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
17657 (w32_system_caret_y, Qfile_name_history):
17658 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
17659 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
17660 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
17661 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
17662 * w32proc.c (Qlocal, report_file_error):
17663 * w32term.c (Vwindow_system, updating_frame):
17664 * w32uniscribe.c (initialized, uniscribe_font_driver):
17665 Remove unneeded extern declarations.
17666
2aa46d6c
CY
176672011-03-14 Chong Yidong <cyd@stupidchicken.com>
17668
c96bbc66 17669 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 17670
cffc6f3b
CY
176712011-03-13 Chong Yidong <cyd@stupidchicken.com>
17672
17673 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
17674 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
17675 These macros can no longer be used for assignment.
17676
44f230aa
SM
17677 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
17678 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
17679 (record_buffer_markers, fetch_buffer_markers): New functions for
17680 recording and fetching special buffer markers.
17681 (set_buffer_internal_1, set_buffer_temp): Use them.
17682
17683 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
17684
17685 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
17686
17687 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
17688 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
17689
17690 * xdisp.c (hscroll_window_tree):
17691 (reconsider_clip_changes): Use PT instead of BUF_PT.
17692
d251f04b
EZ
176932011-03-13 Eli Zaretskii <eliz@gnu.org>
17694
17695 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
17696 $(EMACS_ROOT)/lib/intprops.h.
17697
f0c77cd1
PE
176982011-03-13 Paul Eggert <eggert@cs.ucla.edu>
17699
3eca4629
PE
17700 Fix more problems found by GCC 4.5.2's static checks.
17701
7c86ee98
PE
17702 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
17703 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
17704 (xg_free_frame_widgets): Make it clear that a local variable is
17705 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
17706 (gdk_window_get_screen): Make it clear that this macro is needed
17707 only if USE_GTK_TOOLTIP.
1e5524e7
PE
17708 (int_gtk_range_get_value): New function, which avoids a diagnostic
17709 from gcc -Wbad-function-cast.
17710 (xg_set_toolkit_scroll_bar_thumb): Use it.
17711 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
17712 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
17713 (get_utf8_string, xg_get_file_with_chooser):
17714 Rename locals to avoid shadowing.
17715 (create_dialog): Move locals to avoid shadowing.
7c86ee98 17716
41729b81
PE
17717 * xgselect.c (xg_select): Remove unused var.
17718
f0c77cd1
PE
17719 * image.c (four_corners_best): Mark locals as initialized.
17720 (gif_load): Initialize transparent_p to zero (Bug#8238).
17721 Mark another local as initialized.
ec6cf4c6 17722 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 17723
ce0ad53d 17724 * image.c (clear_image_cache): Now static.
d5d5a617 17725 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 17726 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
17727 (x_edge_detection): Remove unnecessary cast that
17728 gcc -Wbad-function-cast diagnoses.
2037898d 17729 (gif_load): Fix pointer signedness.
6ae141d6
PE
17730 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
17731 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 17732
33383987 177332011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 17734
d32df629
PE
17735 Improve quality of tests for time stamp overflow.
17736 For example, without this patch (encode-time 0 0 0 1 1
17737 1152921504606846976) returns the obviously-bogus value (-948597
17738 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
17739 reports time overflow. See
17740 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
17741 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
17742 * editfns.c: Include limits.h and intprops.h.
17743 (TIME_T_MIN, TIME_T_MAX): New macros.
17744 (time_overflow): Move earlier, to before first use.
17745 (hi_time, lo_time): New functions, for an accurate test for
17746 out-of-range times.
17747 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
17748 (Fget_internal_run_time): Don't assume time_t fits in int.
17749 (make_time): Use list2 instead of Fcons twice.
17750 (Fdecode_time): More accurate test for out-of-range times.
17751 (check_tm_member): New function.
17752 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
17753 (lisp_time_argument): Don't rely on undefined left-shift and
17754 right-shift behavior when checking for time stamp overflow.
8be6f318 17755
fe31d94c
PE
17756 * editfns.c (time_overflow): New function, refactoring common code.
17757 (Fformat_time_string, Fdecode_time, Fencode_time):
17758 (Fcurrent_time_string): Use it.
17759
8be6f318
PE
17760 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
17761 * dired.c (make_time): Move to ...
17762 * editfns.c (make_time): ... here.
17763 * systime.h: Note the move.
17764
09d9db2c 177652011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 17766
126bc0dc
YM
17767 * fringe.c (update_window_fringes): Remove unused variables.
17768
c47cbdfd
YM
17769 * unexmacosx.c (copy_data_segment): Also copy __got section.
17770 (Bug#8223)
17771
7ac80be9
EZ
177722011-03-12 Eli Zaretskii <eliz@gnu.org>
17773
c96bbc66 17774 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
17775 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
17776 Constify `char *' arguments and their references according to
17777 prototypes in tparam.h.
17778
ecb0f94d 17779 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 17780
7ac80be9
EZ
17781 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
17782 Adapt all references accordingly.
17783
17784 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
17785
ef1fd07e
TT
177862011-03-11 Tom Tromey <tromey@redhat.com>
17787
17788 * buffer.c (syms_of_buffer): Remove obsolete comment.
17789
7ef4b50c
EZ
177902011-03-11 Eli Zaretskii <eliz@gnu.org>
17791
17792 * termhooks.h (encode_terminal_code): Declare prototype.
17793
17794 * msdos.c (encode_terminal_code): Don't declare prototype.
17795
17796 * term.c (encode_terminal_code): Now external again, used by
17797 w32console.c and msdos.c.
17798
44f230aa
SM
17799 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
17800 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 17801
4b1ec863 178022011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 17803
1714f52b 17804 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 17805
4b1ec863
PE
17806 * fringe.c (update_window_fringes): Mark locals as initialized
17807 (Bug#8227).
17808 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 17809
524c7aa6
PE
17810 * alloc.c (mark_fringe_data): Move decl from here ...
17811 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
17812 to check its interface.
17813 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
17814
a5c0af81 17815 * fontset.c (free_realized_fontset): Now static.
7519b8cd 17816 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 17817 (fontset_font): Mark local as initialized.
a9a06e0b 17818 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 17819
b4716021
PE
17820 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
17821
811e9bac 17822 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 17823 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
17824 (x_own_selection, Fx_disown_selection_internal): Rename locals
17825 to avoid shadowing.
17826 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 17827
7e3ab302
PE
17828 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
17829 so that the caller can use some name other than gcpro1.
17830 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
17831 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17832 (Fx_backspace_delete_keys_p):
17833 Use them to avoid shadowing, and rename vars to avoid shadowing.
17834 (x_decode_color, x_set_name, x_window): Now static.
6b437900 17835 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 17836 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
17837 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
17838 Remove unused locals.
7e3ab302
PE
17839 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
17840 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
17841 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
17842 macros.
f78faa98 17843
e2b13473
PE
17844 * xterm.h (x_mouse_leave): New decl.
17845
77f23912
PE
17846 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
17847 Remove unused functions.
cdf4ba58
PE
17848 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
17849 (x_calc_absolute_position): Now static.
7411c686 17850 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 17851 Don't declare local "event" unless it's used.
ed7bf3a5
PE
17852 (x_iconify_frame, x_free_frame_resources): Don't declare locals
17853 unless they are used.
38d0b34a
PE
17854 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
17855 (x_fatal_error_signal): Remove; not used.
a6067996
PE
17856 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
17857 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
17858 (x_error_catcher, x_connection_closed, x_error_handler):
17859 (x_error_quitter, xembed_send_message, x_iconify_frame):
17860 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 17861 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 17862 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 17863
44f230aa
SM
17864 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
17865 Rename or move locals to avoid shadowing.
6b463e58 17866 (tty_defined_color, merge_face_heights): Now static.
5967d051 17867 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
17868 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
17869 does not deduce is never used uninitialized.
73719eba
PE
17870 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
17871 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 17872
426994c3 17873 * terminal.c (store_terminal_param): Now static.
5489860b 17874
032f1620 17875 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 17876 (set_frame_menubar): Remove unused local.
d4323972 17877 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
17878 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
17879 since they might point to immutable storage.
281585b0
PE
17880 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
17881 since it's unused otherwise.
032f1620 17882
367c19e5 17883 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 17884 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
17885 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
17886 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 17887 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
17888 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
17889 does not deduce are never used uninitialized.
70739cbe 17890
07b48fa9
PE
17891 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
17892
8868a238 17893 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
17894 * window.c (window_loop, size_window):
17895 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 17896
7e5cf297 17897 * window.c (display_buffer): Now static.
d6550a9f
PE
17898 (size_window): Mark variables that gcc -Wuninitialized
17899 does not deduce are never used uninitialized.
a586633d
PE
17900 * window.h (check_all_windows): New decl, to forestall
17901 gcc -Wmissing-prototypes diagnostic.
5b555da1 17902 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 17903
f6095868
PE
17904 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
17905 shadowing.
17906 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
17907 Include <limits.h>.
17908 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
17909 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
17910 (load_charset_map): Mark variables that gcc -Wuninitialized
17911 does not deduce are never used uninitialized.
53df7c11 17912 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 17913
f38b440c
PE
17914 * coding.c (coding_set_source, coding_set_destination):
17915 Use "else { /* comment */ }" rather than "else /* comment */;"
17916 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
17917 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
17918 a block, when the outer 'i' will do.
17919 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
17920 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
17921 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
17922 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
17923 (Fdecode_sjis_char, Fdefine_coding_system_internal):
17924 Rename locals to avoid shadowing.
17925 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
17926 * coding.c (emacs_mule_char, encode_invocation_designation):
17927 Now static, since they're not used elsewhere.
413bb2db 17928 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 17929 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
17930 (decode_coding_emacs_mule): Mark variables that gcc
17931 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
17932 (detect_coding_iso_2022): Initialize a local variable that might
17933 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 17934 this initialization is needed. (Bug#8211)
5f58e762
PE
17935 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
17936 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
17937 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
17938 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
17939 Remove unused macros.
f38b440c 17940
232b38b9 17941 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 17942 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 17943 * character.c (string_count_byte8): Likewise.
232b38b9 17944
fb90da1b
PE
17945 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
17946 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
17947
fb93dbc2
PE
17948 * chartab.c (copy_sub_char_table): Now static, since it's not used
17949 elsewhere.
5c156ace
PE
17950 (sub_char_table_ref_and_range, char_table_ref_and_range):
17951 Rename locals to avoid shadowing.
bbcd0949 17952 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 17953
7d3b3862 17954 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 17955 (BIDI_BOB): Remove unused macro.
7d3b3862 17956
6be7d3da
PE
17957 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
17958 deduce are never used uninitialized.
c2ed9c8b 17959 * term.c (encode_terminal_code): Likewise.
6be7d3da 17960
75f8807f 17961 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 17962
50938595
PE
17963 * tparam.h: New file.
17964 * term.c, tparam.h: Include it.
17965 * deps.mk (term.o, tparam.o): Depend on tparam.h.
17966 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
17967 Move these decls to tparam.h, and make them agree with what
17968 is actually in tparam.c. The previous trick of using incompatible
17969 decls in different modules does not conform to the C standard.
17970 All callers of tparam changed to use tparam's actual API.
17971 * tparam.c (tparam1, tparam, tgoto):
17972 Use const pointers where appropriate.
17973
fbceeba2
PE
17974 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
17975 * cm.h (struct cm): Likewise.
17976 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
17977 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
17978 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
17979 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
17980 (turn_on_face, init_tty): Likewise.
17981 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 17982
7f3f1250
PE
17983 * term.c (term_mouse_position): Rename local to avoid shadowing.
17984
e6ca6543
PE
17985 * alloc.c (mark_ttys): Move decl from here ...
17986 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
17987
c40f8d15
AS
179882011-03-11 Andreas Schwab <schwab@linux-m68k.org>
17989
17990 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
17991
cfe0661d
JB
179922011-03-09 Juanma Barranquero <lekktu@gmail.com>
17993
17994 * search.c (compile_pattern_1): Remove argument regp, unused since
17995 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
17996 (compile_pattern): Don't pass it.
17997
0afb4571
J
179982011-03-08 Jan Djärv <jan.h.d@swipnet.se>
17999
18000 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
18001 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
18002 for ! HAVE_GTK3.
18003 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
18004
18005 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
18006
18007 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
18008 gdk_window_get_screen, gdk_window_get_geometry,
18009 gdk_x11_window_lookup_for_display and GDK_KEY_g.
18010 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
18011 (xg_get_pixbuf_from_pixmap): New function.
18012 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
18013 to Pixmap, take frame as parameter, remove GdkColormap parameter.
18014 Call xg_get_pixbuf_from_pixmap instead of
18015 gdk_pixbuf_get_from_drawable.
18016 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
18017 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
18018 (xg_check_special_colors): Use GtkStyleContext and its functions
18019 for HAVE_GTK3.
18020 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
18021 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
18022 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
18023 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
18024 Call gtk_widget_get_preferred_size.
0afb4571
J
18025 (xg_frame_resized): gdk_window_get_geometry only takes 5
18026 parameters.
44f230aa
SM
18027 (xg_win_to_widget, xg_event_is_for_menubar):
18028 Call gdk_x11_window_lookup_for_display.
0afb4571
J
18029 (xg_set_widget_bg): New function.
18030 (delete_cb): New function.
895009e1 18031 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 18032 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
18033 (xg_set_background_color): Call xg_set_widget_bg.
18034 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
18035 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
18036 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
18037 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
18038 if ! HAVE_GTK3.
18039 (update_frame_tool_bar): Call gtk_widget_hide.
18040 (xg_initialize): Use GDK_KEY_g.
18041
18042 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
18043 if ! HAVE_GTK3
18044 (x_session_initialize): Call gdk_x11_set_sm_client_id.
18045
18046 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
18047 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
18048 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
18049
1c2cc4ef
JB
180502011-03-08 Juanma Barranquero <lekktu@gmail.com>
18051
18052 * w32xfns.c (select_palette): Check success of RealizePalette against
18053 GDI_ERROR, not zero.
18054
33383987 18055See ChangeLog.11 for earlier changes.
aac0c6e3
MR
18056
18057;; Local Variables:
18058;; coding: utf-8
aac0c6e3
MR
18059;; End:
18060
2f097256 18061 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
18062
18063 This file is part of GNU Emacs.
18064
18065 GNU Emacs is free software: you can redistribute it and/or modify
18066 it under the terms of the GNU General Public License as published by
18067 the Free Software Foundation, either version 3 of the License, or
18068 (at your option) any later version.
18069
18070 GNU Emacs is distributed in the hope that it will be useful,
18071 but WITHOUT ANY WARRANTY; without even the implied warranty of
18072 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
18073 GNU General Public License for more details.
18074
18075 You should have received a copy of the GNU General Public License
18076 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.