* lisp/saveplace.el (save-place-limit): Make it finite. (Bug#9352)
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5fc295a4 12011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2
70c60eb2 3 Integer and memory overflow issues (Bug#9196).
726e0ab1 4
d31850da
PE
5 * doc.c (get_doc_string): Rework so that
6 get_doc_string_buffer_size is the actual buffer size, rather than
7 being 1 less than the actual buffer size; this makes xpalloc more
8 convenient.
9
a69fbedb
PE
10 * image.c (x_allocate_bitmap_record, cache_image):
11 * xselect.c (Fx_register_dnd_atom):
12 Simplify previous changes by using xpalloc.
13
fe5c5d37
PE
14 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
15 since either will do and ptrdiff_t is convenient with xpalloc.
16
0065d054
PE
17 * charset.c (charset_table_size)
18 (struct charset_sort_data.priority): Now ptrdiff_t.
19 (charset_compare): Don't overflow if priorities differ greatly.
20 (Fsort_charsets): Don't assume list length fits in int.
21 Check for size-calculation overflow when allocating sort data.
22 (syms_of_charset): Allocate an initial charset table that is
23 just under 64 KiB, to avoid problems with glibc malloc and mmap.
24
25 * cmds.c (internal_self_insert): Check for size-calculation overflow.
26
27 * composite.h (struct composition.glyph_len): Now int, not unsigned.
28 The actual value is always <= INT_MAX, and leaving it unsigned made
29 overflow checking harder.
30
31 * dispextern.h (struct glyph_matrix.rows_allocated)
32 (struct face_cache.size): Now ptrdiff_t, for convenience in use
33 with xpalloc. The values are still always <= INT_MAX.
34
35 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
36
37 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
38 (SAFE_NALLOCA): New macro.
39
40 * region-cache.c (struct boundary.pos, find_cache_boundary)
41 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
42 (set_cache_region, invalidate_region_cache)
43 (revalidate_region_cache, know_region_cache, region_cache_forward)
44 (region_cache_backward, pp_cache):
45 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
46 so that ptrdiff_t * can be passed to xpalloc.
47 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
48 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
49 (pp_cache): Don't assume cache_len fits in int.
50 * region-cache.h: Adjust extern decls to match.
51
52 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
53 EMACS_INT, since either will do, for xpalloc.
54
55 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
56 (xnmalloc, xnrealloc, xpalloc): New functions.
57
726e0ab1
PE
58 * bidi.c (bidi_shelve_header_size): New constant.
59 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
60 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
61
51f30bc5 62 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
63 * buffer.c (overlays_at, overlays_in, record_overlay_string)
64 (overlay_strings):
65 Don't update size of array until after memory allocation succeeds,
66 because xmalloc/xrealloc may not return.
0065d054
PE
67 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
68 now that we have proper integer overflow checking.
69 (record_overlay_string, overlay_strings): Catch overflows when
70 calculating size of overlay_str_buf.
726e0ab1 71
0065d054
PE
72 * callproc.c (Fcall_process): Check for size overflow when
73 calculating size of args2.
74 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
75 Normally we prefer signed values, but sticking with ptrdiff_t would
76 require adding more-complicated checks.
726e0ab1
PE
77
78 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
79 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
80 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 81 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
82
83 * character.c (Fstring): Check for size-calculation overflow.
84
85 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
86 unnecessary integer overflow. Check for size overflow.
87 (encode_coding_object): Don't update size until xmalloc succeeds.
88
89 * composite.c (get_composition_id): Check for overflow in glyph
90 length calculations.
91
92 Integer and memory overflow fixes for display code.
93 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
94 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
95 (scrolling_window): Check for overflow in size calculations.
96 (line_draw_cost, realloc_glyph_pool, add_row_entry):
97 Don't assume glyph table len fits in int.
98 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
99 (row_table_size): Now ptrdiff_t, not int.
100 (scrolling_window): Avoid overflow in size calculations.
101 Don't update size until allocation succeeds.
102 * fns.c (concat): Check for overflow in size calculations.
103 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
104 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
105 (NEXT_ALMOST_PRIME_LIMIT): New constant.
106
107 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
108 (get_doc_string): Check for size calculation overflow.
109 Don't update size until allocation succeeds.
110 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
111 EMACS_INT, where ptrdiff_t will do.
112 (Fsubstitute_command_keys): Check for string overflow.
113
114 * editfns.c (set_time_zone_rule): Don't assume environment length
115 fits in int.
116 (message_length): Now ptrdiff_t, not int.
117 (Fmessage_box): Don't update size until allocation succeeds.
118 Don't assume message length fits in int.
119 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
120
0065d054
PE
121 * emacs.c (main): Do not reallocate argv, since there is a null at
122 the end that can be overwritten, and this way there's no need to
123 worry about size-calculation overflow.
124 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
125
126 * eval.c (init_eval_once, grow_specpdl): Don't update size until
127 alloc succeeds.
128 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
129
130 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
131 (x_set_scroll_bar_width, x_figure_window_size):
132 Check for integer overflow.
133 (x_set_alpha): Do not assume XINT fits in int.
134
135 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
136 This is for the members text_lines, text_cols, total_lines, total_cols,
137 where the system imposes an 'int' limit.
138
139 * fringe.c (Fdefine_fringe_bitmap):
140 Don't update size until alloc works.
141
142 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
143 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
144
145 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
146 Check for size-calculation overflow.
147 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
148 do, as we prefer signed integers.
149 (id_to_widget.max_size, id_to_widget.used)
150 (xg_store_widget_in_map, xg_remove_widget_from_map)
151 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
152 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
153 Use and return ptrdiff_t, not int.
154 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
155 * gtkutil.h: Change prototypes to match the above.
156
157 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
158 are duplicate now that they've been promoted to lisp.h.
159 (x_allocate_bitmap_record, x_alloc_image_color)
160 (make_image_cache, cache_image, xpm_load):
161 Don't update size until alloc is done.
162 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
163 (x_detect_edges):
3256efce 164 Check for size calculation overflow.
726e0ab1
PE
165 (ct_colors_allocated_max): New constant.
166 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
167 overflow.
3256efce 168
726e0ab1
PE
169 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
170 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
171 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
172 Use ptrdiff_t, not int, to count maps.
173 (read_char_minibuf_menu_prompt): Check for overflow in size
174 calculations. Don't update size until allocation succeeds. Redo
175 calculations to avoid overflow.
176 * keyboard.h: Change prototypes to match the above.
177
178 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
179 to count maps.
180 (current_minor_maps): Check for size calculation overflow.
181 * keymap.h: Change prototypes to match the above.
182
183 * lread.c (read1, init_obarray): Don't update size until alloc done.
184
185 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
186 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
187
726e0ab1
PE
188 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
189 Now ptrdiff_t, not int.
190 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
191 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
192
193 * process.c (Fnetwork_interface_list): Check for overflow
194 in size calculation.
195
196 * region-cache.c (move_cache_gap): Check for size calculation overflow.
197
198 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
199 overflow. Don't bother calling xmalloc when xrealloc will do.
200
201 * search.c (Freplace_match): Check for size calculation overflow.
202 (Fset_match_data): Don't assume list lengths fit in 'int'.
203
204 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
205 for command line length. Do not attempt to address one before the
206 beginning of an array, as that's not portable.
207
208 * term.c (max_frame_lines): Remove; unused.
209 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
210 not int.
211 (encode_terminal_code, calculate_costs): Check for size
212 calculation overflow.
213 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
214 table lengths and related sizes. Don't update size until alloc
215 done. Redo calculations to avoid overflow.
216 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
217
218 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
219 subtracting pointers.
220 (gobble_line): Check for overflow more carefully. Don't update size
221 until alloc done.
222
223 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
224 Don't update size until alloc done.
225 Redo size calculations to avoid overflow.
226 Check for size calculation overflow.
0065d054 227 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
228
229 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
230 Use ptrdiff_t, not int, for sizes.
231 (store_mode_line_noprop_char): Don't update size until alloc done.
232
0065d054
PE
233 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
234 Use ptrdiff_t, not int, for sizes.
235 (Finternal_make_lisp_face, cache_face):
236 Check for size calculation overflow.
237 (cache_face): Treat size calculation overflows as if they were
238 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
239
240 * xfns.c (x_encode_text, x_set_name_internal)
241 (Fx_change_window_property): Use ptrdiff_t, not int, to count
242 sizes, since they can exceed INT_MAX in size. Check for size
243 calculation overflow.
244
0065d054
PE
245 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
246 (xg_select): Check for size calculation overflow.
726e0ab1
PE
247 Don't update size until alloc done.
248
0065d054 249 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 250 as sprintf is limited to int lengths.
1d526e2f 251
252c5ee1
PE
252 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
253 (X_LONG_MIN): New macros.
864d7ce7
PE
254 Use them to make the following changes clearer.
255 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
256 This change doesn't affect the value now, but it may help remind
257 future maintainers not to raise the value too much later.
258 (SELECTION_QUANTUM): Remove, replacing with ...
259 (selection_quantum): ... new function, which avoids overflow.
260 All uses changed.
261 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
262 assumption that selection length fits in 'int'.
263 (x_reply_selection_request, x_handle_selection_request)
264 (x_get_window_property, receive_incremental_selection)
265 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
266 (lisp_data_to_selection_data, clean_local_selection_data):
267 Use ptrdiff_t, not int, to record length of selection.
268 (x_reply_selection_request, x_get_window_property)
269 (receive_incremental_selection, x_property_data_to_lisp):
270 Redo calculations to avoid overflow.
271 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 272 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
273 something.
274 (x_get_window_property, receive_incremental_selection)
275 (lisp_data_to_selection_data, x_property_data_to_lisp):
276 Check for size-calculation overflow.
277 (x_get_window_property, receive_incremental_selection)
278 (lisp_data_to_selection_data, Fx_register_dnd_atom):
279 Don't store size until memory allocation succeeds.
280 (x_get_window_property): Plug memory leak on memory exhaustion.
281 Don't double-block input; malloc is safe here. Don't assume 2**34
282 - 4 fits in unsigned long. Add an xassert to check
283 XGetWindowProperty overflow. Be more careful about overflow
284 calculations, and distinguish size from memory overflow better.
285 (receive_incremental_selection): When tracing, don't assume
286 unsigned int is less than INT_MAX.
287 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
288 harmful) conversions of unsigned short to int.
289 (lisp_data_to_selection_data): Don't assume that integers
290 in the range -65535 through -1 fit in an X unsigned short.
291 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
292 result parameters unless successful. Rely on cons_to_unsigned
293 to report problems with elements; the old code wasn't right anyway.
294 (x_check_property_data): Check for int overflow; we cannot use
295 a wider type due to X limits.
296 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
297
726e0ab1 298 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 299
0065d054
PE
300 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
301 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
302 (x_color_cells): Don't store size until memory allocation succeeds.
303 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 304 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
305 (x_term_init): Don't assume length fits in int (sprintf is limited
306 to int size).
bc18e09d 307
ebfa62c0
PE
308 Use ptrdiff_t for composition IDs.
309 * character.c (lisp_string_width):
310 * composite.c (composition_table_size, n_compositions)
311 (get_composition_id, composition_gstring_from_id):
312 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
313 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
314 * window.c (Frecenter):
315 Use ptrdiff_t, not int, for composition IDs.
316 * composite.c (get_composition_id): Check for integer overflow.
317 * composite.h: Adjust prototypes to match the above changes.
318
d3411f89
PE
319 Use ptrdiff_t for hash table indexes.
320 * category.c (hash_get_category_set):
321 * ccl.c (ccl_driver):
322 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
323 * coding.c (coding_system_charset_list, detect_coding_system):
324 * coding.h (struct coding_system.id):
325 * composite.c (get_composition_id, gstring_lookup_cache):
326 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
327 * image.c (xpm_get_color_table_h):
328 * lisp.h (hash_lookup, hash_put):
329 * minibuf.c (Ftest_completion):
330 Use ptrdiff_t for hash table indexes, not int (which is too
331 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
332 32-bit --with-wide-int hosts).
333
e097a6fa
PE
334 * charset.c (Fdefine_charset_internal): Check for integer overflow.
335 Add a FIXME comment about memory leaks.
336 (syms_of_charset): Don't assume xmalloc returns.
337
5637687f
PE
338 Don't assume that stated character widths fit in int.
339 * character.c (Fchar_width, c_string_width, lisp_string_width):
340 * character.h (CHAR_WIDTH):
341 * indent.c (MULTIBYTE_BYTES_WIDTH):
342 Use sanitize_char_width to avoid undefined and/or bad behavior
343 with outlandish widths.
344 * character.h (sanitize_tab_width): Renamed from sanitize_width,
345 now that we have two such functions. All uses changed.
346 (sanitize_char_width): New inline function.
347
a2271ba2
PE
348 Don't assume that tab-width fits in int.
349 * character.h (sanitize_width): New inline function.
350 (SANE_TAB_WIDTH): New macro.
351 (ASCII_CHAR_WIDTH): Use it.
352 * indent.c (sane_tab_width): Remove. All uses replaced by
353 SANE_TAB_WIDTH (current_buffer).
354 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
355
18c52557
PE
356 * fileio.c: Integer overflow issues with file modes.
357 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
358
caeeedc1
PE
359 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
360 Remove unreachable code.
361 (read_hex, load_charset_map_from_file): Check for integer overflow.
362
50849c52
PE
363 * xterm.c: don't go over XClientMessageEvent limit
364 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
365 (x_send_scroll_bar_event): Likewise. Check that the size does not
366 exceed limits imposed by XClientMessageEvent, as well as the usual
367 ptrdiff_t and size_t limits.
368
b13995db
PE
369 * keyboard.c: Overflow, signedness and related fixes.
370 (make_lispy_movement): Use same integer type in forward decl
371 that is used in the definition.
372 (read_key_sequence, keyremap_step):
373 Change bufsize argument back to int, undoing my 2011-03-30 change.
374 We prefer signed types, and int is wide enough here.
375 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
376 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
377 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
378 length, not size_t. Use ptrdiff_t for index, not int.
379 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
380 possibility of integer overflow.
381
13464394
PE
382 Overflow, signedness and related fixes for images.
383
384 * dispextern.h (struct it.stack[0].u.image.image_id)
385 (struct_it.image_id, struct image.id, struct image_cache.size)
386 (struct image_cache.used, struct image_cache.ref_count):
387 * gtkutil.c (update_frame_tool_bar):
388 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
389 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
390 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
391 * nsmenu.m (update_frame_tool_bar):
392 * xdisp.c (calc_pixel_width_or_height):
393 * xfns.c (image_cache_refcount):
394 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
395 on typical 64-bit hosts.
396
397 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
398 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
399 Omit unnecessary casts to int.
400 (parse_image_spec): Check that integers fall into 'int' range
401 when the callers expect that.
402 (image_ascent): Redo ascent calculation to avoid int overflow.
403 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
404 (lookup_image): Remove unnecessary tests.
405 (xbm_image_p): Locals are now of int, not EMACS_INT,
406 since parse_image_check makes sure they fit into int.
407 (png_load, gif_load, svg_load_image):
408 Prefer int to unsigned where either will do.
409 (tiff_handler): New function, combining the cores of the
410 old tiff_error_handler and tiff_warning_handler. This
411 function is rewritten to use vsnprintf and thereby avoid
412 stack buffer overflows. It uses only the features of vsnprintf
413 that are common to both POSIX and native Microsoft.
414 (tiff_error_handler, tiff_warning_handler): Use it.
415 (tiff_load, gif_load, imagemagick_load_image):
416 Don't assume :index value fits in 'int'.
417 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
418 (imagemagick_load_image): Check that crop parameters fit into
419 the integer types that MagickCropImage accepts. Don't assume
420 Vimagemagick_render_type has a nonnegative value. Don't assume
421 size_t fits in 'long'.
422 (gs_load): Use printmax_t to print the widest integers possible.
423 Check for integer overflow when computing image height and width.
424
c11821d4
EZ
4252011-08-26 Eli Zaretskii <eliz@gnu.org>
426
427 * xdisp.c (redisplay_window): Don't force window start if point
428 will be invisible in the resulting window. (Bug#9324)
429
0c95fcf7
EZ
4302011-08-25 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
433 the display spec is of the form `(space ...)'.
434 (handle_display_spec): Return the value returned by
435 handle_single_display_spec, not just 1 or zero.
436 (handle_single_display_spec): If the display spec is of the form
437 `(space ...)', and specifies display in the text area, return 2
438 rather than 1.
fee65a97 439 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
440 accurately, and prefer exact match for point under bidi. Don't
441 advance `row' beyond the last row of the window.
0c95fcf7
EZ
442
443 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
444 into disp_prop; all users changed.
445
446 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
447 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
448 for the text covered by the display property.
449
e4ed06f1
CY
4502011-08-25 Chong Yidong <cyd@stupidchicken.com>
451
452 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
453 Change return value to nil.
454 (Frecord_buffer): Delete unused function.
455
f67cdd7f
EZ
4562011-08-24 Eli Zaretskii <eliz@gnu.org>
457
5980d4c6
EZ
458 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
459 buffers, return left-to-right.
8610fe8b
EZ
460 (set_cursor_from_row): Consider candidate row a win if its glyph
461 represents a newline and point is on that newline. Fixes cursor
462 positioning on the newline at EOL of R2L text within L2R
463 paragraph, and vice versa.
464 (try_cursor_movement): Check continued rows, in addition to
465 continuation rows. Fixes unwarranted scroll when point enters a
466 continued line of R2L text within an L2R paragraph, or vice versa.
467 (cursor_row_p): Consider the case of point being equal to
468 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
469 from the end of a short line to the beginning of a continued line
470 of R2L text within L2R paragraph.
471 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
472 composed characters.
5980d4c6 473
f67cdd7f
EZ
474 * bidi.c (bidi_check_type): Use xassert.
475 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
476 members.
477
bca633fb
EZ
4782011-08-23 Eli Zaretskii <eliz@gnu.org>
479
480 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
481 a character.
482
4a5885a7
CY
4832011-08-23 Chong Yidong <cyd@stupidchicken.com>
484
485 * nsfont.m (ns_otf_to_script): Fix typo.
486
0902a04e
KH
4872011-08-22 Kenichi Handa <handa@m17n.org>
488
489 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
490 extra slot even if the purpose is char-code-property-table.
491
1a2e6670
EZ
4922011-08-23 Eli Zaretskii <eliz@gnu.org>
493
8ddde651
EZ
494 * xdisp.c (redisplay_window): When computing centering_position,
495 account for the height of the header line. (Bug#8874)
496
425cc014
EZ
497 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
498 instead of CHAR_TO_BYTE. Fixes a crash when a completion
499 candidate is selected by the mouse, and that candidate has a
500 composed character under the mouse.
501
1a2e6670
EZ
502 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
503 coordinates reported by pos-visible-in-window-p for a composed
504 character in column zero.
505
8b76d6f8
SM
5062011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
507
508 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
509
dac347dd
EZ
5102011-08-22 Eli Zaretskii <eliz@gnu.org>
511
512 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
513 consider it a hit if to_charpos is anywhere in the range of the
514 composed buffer positions.
515
e013fb34
CY
5162011-08-22 Chong Yidong <cyd@stupidchicken.com>
517
518 * image.c (gif_load): Don't assume that each subimage has the same
519 dimensions as the base image. Handle disposal method that is
520 "undefined" by the gif spec (Bug#9335).
521
bd1ba3e8
CY
5222011-08-20 Chong Yidong <cyd@stupidchicken.com>
523
524 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 525 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 526
54a1215b
EZ
5272011-08-19 Eli Zaretskii <eliz@gnu.org>
528
823564e5
EZ
529 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
530 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
531 from an Org mode buffer to a Speedbar frame.
532
54a1215b
EZ
533 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
534 a composition, take its buffer position from IT->cmp_it.charpos.
535 Fixes cursor positioning at the beginning of a line that begins
536 with a composed character.
537
9778ebcc
EZ
5382011-08-18 Eli Zaretskii <eliz@gnu.org>
539
0be6ee06
EZ
540 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
541 character bidirectional type, use STRONG_L instead. Fixes crashes
542 in a buffer produced by `describe-categories'.
543
9778ebcc
EZ
544 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
545 members before the level stack, so they would be saved and
546 restored when copying iterator state. Fixes incorrect reordering
547 around TABs covered by display properties.
548
156bffbe
AS
5492011-08-18 Andreas Schwab <schwab@linux-m68k.org>
550
551 * process.c (Fnetwork_interface_list): Correctly determine buffer
552 size.
553
72ad093b
CY
5542011-08-17 Chong Yidong <cyd@stupidchicken.com>
555
556 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
557 (internal_condition_case_2, internal_condition_case_n):
558 Remove unnecessary aborts (Bug#9081).
72ad093b 559
35774242
EZ
5602011-08-17 Eli Zaretskii <eliz@gnu.org>
561
562 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
563 has no `load' handler, try opening the file locally. (Bug#9311)
564
db76dd85
KB
5652011-08-16 Ken Brown <kbrown@cornell.edu>
566
567 * gmalloc.c: Expand comment.
568
b215eee5
EZ
5692011-08-16 Eli Zaretskii <eliz@gnu.org>
570
571 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
572 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
573
a4579d33
KB
5742011-08-16 Ken Brown <kbrown@cornell.edu>
575
576 Fix memory allocation problems in Cygwin build (Bug#9273).
577
578 * unexcw.c ( __malloc_initialized): Declare external variable.
579 (fixup_executable): Force the dumped emacs to reinitialize malloc.
580
8b76d6f8
SM
581 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
582 New variables.
a4579d33
KB
583 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
584 dumped emacs.
585 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
586 in the static heap.
587 [CYGWIN] (special_realloc): New function.
588 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
589 requests to realloc storage in the static heap.
590
3ebec551
PE
5912011-08-15 Paul Eggert <eggert@cs.ucla.edu>
592
593 * bidi.c (bidi_initialize): Remove unused local.
594
9fd8be00
EZ
5952011-08-15 Eli Zaretskii <eliz@gnu.org>
596
474a8465
EZ
597 * biditype.h: File removed.
598
599 * bidimirror.h: File removed.
600
601 * deps.mk (bidi.o): Remove biditype.h and
602 bidimirror.h.
603
604 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
605 bidimirror.h.
606
607 * dispextern.h: Fix a typo in the comment to bidi_type_t.
608
609 * chartab.c: Improve commentary for the uniprop_table API.
610
32413314
EZ
611 * bidi.c (bidi_paragraph_init): Support zero value of
612 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
613 (bidi_initialize): Use uniprop_table instead of including
614 biditype.h and bidimirror.h.
32413314 615
9fd8be00
EZ
616 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
617 coordinates of the iterator when restoring from ppos_it.
618 (Bug#9296)
619
5cf2b69b
KH
6202011-08-14 Kenichi Handa <handa@m17n.org>
621
622 * process.c (create_process): Call setup_process_coding_systems
72ad093b 623 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 624
daf17d00
EZ
6252011-08-14 Eli Zaretskii <eliz@gnu.org>
626
627 * xdisp.c (move_it_in_display_line_to): Don't invoke
628 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
629 ppos_it. Fixes vertical cursor motion when line beginning is
630 covered by an image. (Bug#9296)
631
08e3161a
JD
6322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
633
634 * nsterm.h (ns_run_ascript): Declare.
635 (NSAPP_DATA2_RUNASSCRIPT): Define.
636
637 * nsfns.m (as_script, as_result, as_status): New static variables.
638 (ns_run_ascript): New function.
639 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
640 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
641 the event loop. Get status from as_status (Bug#7276).
642
643 * nsterm.m (sendEvent): If event is NSApplicationDefined and
644 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
645 the event loop (Bug#7276).
646
a3720aa2
AS
6472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
648
649 * gnutls.c (QCgnutls_bootprop_priority)
650 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
651 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
652 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
653 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
654 (QCgnutls_bootprop_verify_hostname_error)
655 (QCgnutls_bootprop_callbacks_verify): Rename from
656 Qgnutls_bootprop_..., all uses changed.
657
658 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
659 uses changed.
660
0a0d27fb
PE
6612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
662
19d5c50c
PE
663 * xfaces.c (Qframe_set_background_mode): Now static.
664 * dispextern.h (Qframe_set_background_mode): Remove decl.
665
0a0d27fb
PE
666 * process.c (Fnetwork_interface_info): Declare local only if needed.
667
377538cb
JD
6682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
669
670 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
671 (Fnetwork_interface_list): Allocate in increments of bytes instead
672 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
673 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
674 sockaddr.
675 (struct ifflag_def): notrailers is smart on OSX.
676 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
677 Get hardware address with getifaddrs if available.
678
08fff70c
EZ
6792011-08-12 Eli Zaretskii <eliz@gnu.org>
680
681 * xdisp.c (iterate_out_of_display_property): xassert that
682 IT->position is set to within IT->object's boundaries. Break from
683 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
684 when IT->position is set up wrongly due to some bug.
685 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
686 (push_display_prop): Allow GET_FROM_STRING as IT->method on
687 entry. Force push_it to save on the stack the current
688 buffer/string position, to be restored by pop_it. Fix flags in
689 the iterator structure wrt the object coming from a display
690 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
691 properties. (Bug#9284)
692
7be1c708 6932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 694
7be1c708
CY
695 * fontset.c (fontset_get_font_group): Add proper type checks.
696 (Bug#9172)
aac0c6e3 697
7be1c708 6982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 699
7be1c708
CY
700 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
701 and LC_VERSION_MIN_MACOSX.
702 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
703 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 704
97bb72a6
EZ
7052011-08-08 Eli Zaretskii <eliz@gnu.org>
706
707 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
708 no-display-properties-and-no-overlays under bidi display.
709 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 710 properties and overlays.
97bb72a6 711
d5617611
CY
7122011-08-08 Chong Yidong <cyd@stupidchicken.com>
713
37e11a63
CY
714 * editfns.c (Fset_time_zone_rule): Document relationship with the
715 setenv function.
716
d5617611
CY
717 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
718 the font entity extracted from the cache (Bug#8109).
719
58872834
CY
7202011-08-07 Chong Yidong <cyd@stupidchicken.com>
721
722 * composite.c (autocmp_chars): Don't reset point. That is done by
723 restore_point_unwind (Bug#5984).
724
75bfc667
JL
7252011-08-07 Juri Linkov <juri@jurta.org>
726
727 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
728 to show the arg `TIME' instead of `TIMEVAL'.
729
d1410150
EZ
7302011-08-06 Eli Zaretskii <eliz@gnu.org>
731
732 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
733 display property strides EOL and includes a newline, as in
734 longlines-mode. (Bug#9254)
75b771e4
EZ
735 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
736 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
737
738 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
739 is non-zero, even if the data buffer is NULL. Fixes a crash in
740 vertical-motion with longlines-mode. (Bug#9254)
741
35928349
EZ
7422011-08-05 Eli Zaretskii <eliz@gnu.org>
743
ec7cc85b
EZ
744 * bidi.c <bidi_cache_total_alloc>: Now static.
745 (bidi_initialize): Initialize bidi_cache_total_alloc.
746
8b76d6f8 747 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
748 cache. (Bug#9221)
749
750 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
751 amount allocated this far in `bidi_cache_total_alloc'.
752 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
753 non-zero, only free the data buffer without restoring the cache
754 contents. All callers changed.
755
756 * dispextern.h (bidi_unshelve_cache): Update prototype.
757
758 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
759 (move_it_in_display_line, move_it_to)
760 (move_it_vertically_backward, move_it_by_lines): Replace the call
761 to xfree to an equivalent call to bidi_unshelve_cache.
762 (move_it_in_display_line_to): Fix logic of returning
412b6358 763 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 764
e2e2423b
EZ
7652011-08-05 Eli Zaretskii <eliz@gnu.org>
766
767 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
768 came from a string character with a `cursor' property. (Bug#9229)
769
ae9e757a
JD
7702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
771
772 * Makefile.in (LIB_PTHREAD): New variable.
773 (LIBES): Add LIB_PTHREAD (Bug#9216).
774
775 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
776 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
777
213bd7f2
AS
7782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
779
780 * regex.c (re_iswctype): Remove some redundant boolean
781 conversions.
782
99aaf75f
JD
7832011-08-04 Jan Djärv <jan.h.d@swipnet.se>
784
785 * xterm.c (x_find_topmost_parent): New function.
786 (x_set_frame_alpha): Find topmost parent window with
787 x_find_topmost_parent and set the property there also (bug#9181).
788 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
789
c74e9d86
PE
7902011-08-04 Paul Eggert <eggert@cs.ucla.edu>
791
792 * callproc.c (Fcall_process): Avoid vfork clobbering
793 the local vars buffer, coding_systems, current_dir.
794
640c8776
SM
7952011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
796
797 * keymap.c (Fmake_composed_keymap): Move to subr.el.
798
f26d0e4c
PE
7992011-08-03 Paul Eggert <eggert@cs.ucla.edu>
800
8a10d76c
PE
801 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
802 so that it is not optimized away.
803
f26d0e4c
PE
804 * xdisp.c (compute_display_string_pos): Remove unused local.
805
55439c61
EZ
8062011-08-02 Eli Zaretskii <eliz@gnu.org>
807
808 Fix slow cursor motion and scrolling in large buffers with
809 selective display, like Org Mode buffers. (Bug#9218)
810
811 * dispextern.h (struct bidi_it): New member disp_prop_p.
812
813 * xdisp.c: Remove one-slot cache of display string positions.
814 (compute_display_string_pos): Accept an additional argument
815 DISP_PROP_P; callers changed. Scan at most 5K characters forward
816 for a display string or property. If found, set DISP_PROP_P
817 non-zero.
818
819 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
820 DISP_PROP_P, and pass it to compute_display_string_pos.
821 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
822 non-zero. All callers of bidi_fetch_char changed.
823
fb33fa43
SM
8242011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
825
826 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
827
b099e063
DM
8282010-12-03 Don March <don@ohspite.net>
829
830 * keymap.c (Fdefine_key): Fix non-prefix key error message when
831 last character M-[char] is translated to ESC [char] (bug#7541).
832
5cc7f7af
KH
8332011-08-02 Kenichi Handa <handa@m17n.org>
834
d0fffa3f 835 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
836
837 * chartab.c (uniprop_table): Make it non-static.
838
525d5e6e
EZ
8392011-08-01 Eli Zaretskii <eliz@gnu.org>
840
841 * xdisp.c (forward_to_next_line_start): Accept additional argument
842 BIDI_IT_PREV, and store into it the state of the bidi iterator had
843 on the newline.
844 (reseat_at_next_visible_line_start): Use the bidi iterator state
845 returned by forward_to_next_line_start to restore the state of
846 it->bidi_it after backing up to previous newline. (Bug#9212)
847
31011111
AS
8482011-07-30 Andreas Schwab <schwab@linux-m68k.org>
849
850 * regex.c (re_comp): Protoize.
851 (re_exec): Fix return type.
852 (regexec): Fix type of `ret'. (Bug#9203)
853
e5d76069
PE
8542011-07-29 Paul Eggert <eggert@cs.ucla.edu>
855
856 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
857 This is needed if max-image-size is a floating-point number.
858
9a79b20c
AS
8592011-07-28 Andreas Schwab <schwab@linux-m68k.org>
860
861 * print.c (print_object): Print empty symbol as ##.
862
863 * lread.c (read1): Read ## as empty symbol.
864
d8c2fa78
AA
8652011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
866
867 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
868 setting frame foreground color (Bug#9175).
869 (x_set_background_color): Likewise.
870
ffe57a7a
AA
871 * nsmenu.m (-setText): Size tooltip dimensions precisely to
872 contents (Bug#9176).
873 (EmacsTooltip -init): Remove bezels and add shadows to
874 tooltip windows.
875
bf3492a5
AA
876 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
877 or scroll bar (Bug#8470).
878
d55e9c53
AA
879 * nsfont.m (nsfont_open): Remove assignment to voffset and
880 unnecessary vars hshink, expand, hd, full_height, min_height.
881 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
882
883 * nsterm.h (nsfont_info): Remove voffset field.
884
d8c2fa78 8852011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
886
887 Implement strike-through and overline on NextStep (Bug#8863).
888
889 * nsfont.m (nsfont_open): Use underline position provided by font,
890 instead of hard-coded value of 2.
891 (nsfont_draw): Call ns_draw_text_decoration instead.
892
893 * nsterm.h: Add declaration for ns_draw_text_decoration.
894
895 * nsterm.m (ns_draw_text_decoration): New function for drawing
896 underline, overline, and strike-through.
897 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
898 ns_draw_text_decoration. Change treatment of cursor drawing to
899 accomodate underlining, etc.
900
4cc60b9b
EZ
9012011-07-28 Eli Zaretskii <eliz@gnu.org>
902
bc7ece87
EZ
903 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
904 default.
4cc60b9b 905
476371c4
PE
9062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
907
66606eea
PE
908 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
909 Without this fix, if a signal arrives just after memory fills up,
910 'malloc' might be invoked reentrantly.
911
476371c4
PE
912 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
913 In other words, assume that every image size is allowed, on non-X
914 hosts. This assumption is probably wrong, but it lets Emacs compile.
915
f3fcc40d
AS
9162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
917
918 * regex.c (re_iswctype): Convert return values to boolean.
919
350c992f
EZ
9202011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
921
922 * xdisp.c (compute_display_string_pos): Don't use cached display
923 string position if the buffer had its restriction changed.
924 (Bug#9184)
925
5266b4bb
PE
9262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
927
928 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
929
2573a837 9302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 931
41f55ccd 932 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 933
39e378da
PE
934 * bidi.c: Integer size and overflow fixes.
935 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
936 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
937 (bidi_cache_find_level_change, bidi_cache_ensure_space)
938 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
939 (bidi_find_other_level_edge):
940 Use ptrdiff_t instead of EMACS_INT where either will do.
941 This works better on 32-bit hosts configured --with-wide-int.
942 (bidi_cache_ensure_space): Check for size-calculation overflow.
943 Use % rather than repeated addition, for better worst-case speed.
944 Don't set bidi_cache_size until after xrealloc returns, because it
945 might not return.
946 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
947 (bidi_cache_ensure_space): Also check that the bidi cache size
948 does not exceed that of the largest Lisp string or buffer. See Eli
949 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 950
5e927815
PE
951 * alloc.c (__malloc_size_t): Remove.
952 All uses replaced by size_t. See Andreas Schwab's note
953 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
954
ca4aa935
PE
955 * image.c: Improve checking for integer overflow.
956 (check_image_size): Assume that f is nonnull, since
957 it is always nonnull in practice. This is one less thing to
958 worry about when checking for integer overflow later.
959 (x_check_image_size): New function, which checks for integer
960 overflow issues inside X.
961 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
962 This removes the need for a memory_full check.
963 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
964 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
965 (xbm_read_bitmap_data): Change locals back to 'int', since
966 their values must fit in 'int'.
967 (xpm_load_image, png_load, tiff_load):
968 Invoke x_create_x_image_and_pixmap earlier,
969 to avoid much needless work if the image is too large.
970 (tiff_load): Treat overly large images as if
971 x_create_x_image_and_pixmap failed, not as malloc failures.
972 (gs_load): Use x_check_image_size.
973
5f8f9cc2
PE
974 * gtkutil.c: Omit integer casts.
975 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
976 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
977
5adf60bc
PE
978 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
979
c8907a93
PE
980 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
981 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
982 would wrongly return t on a 64-bit host.
983
e3c25c68
PE
984 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
985 The plain *_OVERFLOW macros run afoul of GCC bug 49705
986 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
987 and therefore cause GCC to emit a bogus diagnostic in some cases.
988
3f791afe
PE
989 * image.c: Integer signedness and overflow and related fixes.
990 This is not an exhaustive set of fixes, but it's time to
991 record what I've got.
992 (lookup_pixel_color, check_image_size): Remove redundant decls.
993 (check_image_size): Don't assume that arbitrary EMACS_INT values
994 fit in 'int', or that arbitrary 'double' values fit in 'int'.
995 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
996 (tiff_load, imagemagick_load_image):
997 Check for overflow in size calculations.
998 (x_create_x_image_and_pixmap): Remove unnecessary test for
999 xmalloc returning NULL; that can't happen.
1000 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1001 (xpm_color_bucket): Use better integer hashing function.
1002 (xpm_cache_color): Don't possibly over-allocate memory.
1003 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1004 (gif_memory_source):
1005 Use ptrdiff_t, not int or size_t, to record sizes.
1006 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1007 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1008 either works, as we prefer signed integers.
1009 (tiff_read_from_memory, tiff_write_from_memory):
1010 Return tsize_t, not size_t, since that's what the TIFF API wants.
1011 (tiff_read_from_memory): Don't fail simply because the read would
1012 go past EOF; instead, return a short read.
1013 (tiff_load): Omit no-longer-needed casts.
1014 (Fimagemagick_types): Don't assume size fits into 'int'.
1015
3cc5a532
PE
1016 Improve hashing quality when configured --with-wide-int.
1017 * fns.c (hash_string): New function, taken from sxhash_string.
1018 Do not discard information about ASCII character case; this
1019 discarding is no longer needed.
1020 (sxhash-string): Use it. Change sig to match it. Caller changed.
1021 * lisp.h: Declare it.
1022 * lread.c (hash_string): Remove, since we now use fns.c's version.
1023 The fns.c version returns a wider integer if --with-wide-int is
1024 specified, so this should help the quality of the hashing a bit.
1025
b312a492
PE
1026 * emacs.c: Integer overflow minor fix.
1027 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1028 Define only if GNU_LINUX.
1029 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1030
dfd153ae
PE
1031 * dispnew.c: Integer signedness and overflow fixes.
1032 Remove unnecessary forward decls, that were a maintenance hassle.
1033 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1034 All uses changed.
1035 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1036 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1037 (prepare_desired_row, line_draw_cost):
1038 Use int, not unsigned, where either works.
1039 (save_current_matrix, restore_current_matrix):
1040 Use ptrdiff_t, not size_t, where either works.
1041 (init_display): Check for overflow more accurately, and without
1042 relying on undefined behavior.
1043
a81d11a3
PE
1044 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1045 Remove, replacing with the new symbols in lisp.h. All uses changed.
1046 * fileio.c (make_temp_name):
1047 * filelock.c (lock_file_1, lock_file):
1048 * xdisp.c (message_dolog):
1049 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1050 Use pMd etc. instead.
1051 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1052 replacing the pWIDE etc. symbols removed from editfns.c.
1053
3300e6fd
PE
1054 * keyboard.h (num_input_events): Now uintmax_t.
1055 This is (very slightly) less likely to mess up due to wraparound.
1056 All uses changed.
1057
fd05c7e9
PE
1058 * buffer.c: Integer signedness fixes.
1059 (alloc_buffer_text, enlarge_buffer_text):
1060 Use ptrdiff_t rather than size_t when either will do, as we prefer
1061 signed integers.
1062
903fe15d
PE
1063 * alloc.c: Integer signedness and overflow fixes.
1064 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1065 (__malloc_size_t): Default to size_t, not to int.
1066 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1067 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1068 Prefer ptrdiff_t to size_t when either would do, as we prefer
1069 signed integers.
1070 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1071 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1072 Now const. Initialize with values that are in range even if char
1073 is signed.
1074 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1075 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1076 These functions do the right thing with sizes > 2**32.
1077 (check_depth): Now ptrdiff_t, not int.
1078 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1079 Adjust to new way of storing sizes. Check for size overflow bugs
1080 in rest of code.
1081 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1082 slightly wrong anyway, as it missed one instance of
1083 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1084 (refill_memory_reserve): Omit needless cast to size_t.
1085 (mark_object_loop_halt): Mark as externally visible.
1086
ac82cc6a
PE
1087 * xselect.c: Integer signedness and overflow fixes.
1088 (Fx_register_dnd_atom, x_handle_dnd_message):
1089 Use ptrdiff_t, not size_t, since we prefer signed.
1090 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1091 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1092 x_dnd_atoms_size and x_dnd_atoms_length.
1093
c2d1e36d
PE
1094 * doprnt.c: Prefer signed to unsigned when either works.
1095 * eval.c (verror):
1096 * doprnt.c (doprnt):
1097 * lisp.h (doprnt):
1098 * xdisp.c (vmessage):
1099 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1100 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1101 prefer signed arithmetic to avoid comparison confusion.
1102 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1103 but is a bit tricky.
1104
0e926e56
PE
1105 Assume freestanding C89 headers, string.h, stdlib.h.
1106 * data.c, doprnt.c, floatfns.c, print.c:
1107 Include float.h unconditionally.
1108 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1109 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1110 * regex.c: Likewise for stddef.h, string.h.
1111 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1112 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1113 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1114 (STDC_HEADERS): Remove obsolete defines.
1115 * sysdep.c: Include limits.h unconditionally.
1116
9cfdb3ec
PE
1117 Assume support for memcmp, memcpy, memmove, memset.
1118 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1119 * regex.c (memcmp, memcpy):
1120 Remove; we assume C89 now.
1121
1122 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1123 (__malloc_safe_bcopy): Remove; no longer needed.
1124
cf950e6b 1125 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1126 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1127 well either way, and we prefer signed to unsigned.
1128
dbf38e02
LMI
11292011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1130
1131 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1132 closes the connection while we're reading (bug#9182).
1133
d6f0886c
JD
11342011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1135
1136 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1137 are specified (Bug#9168).
1138
2eb1f9e6
PE
11392011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1140
1141 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1142 Found by GCC static checking and --with-wide-int on a 32-bit host.
1143
22381272 11442011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1145
1146 * xdisp.c (compute_display_string_pos): Fix logic of caching
1147 previous display string position. Initialize cached_prev_pos to
1148 -1. Fixes slow-down at the beginning of a buffer.
1149
f25e39b4
EZ
11502011-07-24 Eli Zaretskii <eliz@gnu.org>
1151
1152 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1153 for attrs[LFACE_FONTSET_INDEX].
1154
04c4b52e
PE
11552011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1156
1157 * xml.c (parse_region): Remove unused local
1158 that was recently introduced.
1159
c1734fbd
EZ
11602011-07-23 Eli Zaretskii <eliz@gnu.org>
1161
be18c5a5
EZ
1162 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1163 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1164
c1734fbd
EZ
1165 * xdisp.c (move_it_in_display_line_to): Record the best matching
1166 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1167 exit if none of the characters scanned was an exact match.
1168 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1169 when exact match is impossible due to invisible text, and the
1170 lines are truncated.
1171
a258d627
JD
11722011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1173
1174 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1175 for OSX >= 10.7.
1176
b6d5a689
EZ
11772011-07-22 Eli Zaretskii <eliz@gnu.org>
1178
0f74f785
EZ
1179 Fix a significant slow-down of cursor motion with C-n, C-p,
1180 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1181 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1182 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1183 (next_element_from_buffer): Call compute_stop_pos_backwards to
1184 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1185 base_level_stop.
1186 (reseat): Don't look for prev_stop, as that could mean a very long
1187 run.
1188 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1189 <cached_disp_overlay_modiff>: Cache for last found display string
1190 position.
551918c1 1191 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1192 about the same buffer in the same area of character positions, and
1193 the buffer wasn't changed since the time the display string
1194 position was cached.
551918c1 1195
b2d0c91a
EZ
11962011-07-22 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1199 is an integer, which is important for empty lines. (Bug#9149)
1200
043604ee
CY
12012011-07-22 Chong Yidong <cyd@stupidchicken.com>
1202
1203 * frame.c (Fmodify_frame_parameters): In tty case, update the
1204 default face if necessary (Bug#4238).
1205
da4adb04
CY
12062011-07-21 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * editfns.c (Fstring_to_char): No need to explain what a character
1209 is in the docstring (Bug#6576).
1210
9abd0532
LMI
12112011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1212
1213 * xml.c (parse_region): Make sure we always return a tree.
1214
36881d16
HK
12152011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1216
1217 * xml.c (parse_region): If a document contains only comments,
1218 return that, too.
1219
1e98674d
LMI
12202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1221
1222 * xml.c (make_dom): Return comments, too.
1223
590bd467
PE
12242011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1225
1226 Port to OpenBSD.
1227 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1228 and the surrounding thread.
1229 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1230 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1231 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1232 timer goes off.
1233 * s/openbsd.h (BROKEN_SIGIO): Define.
1234 * unexelf.c (unexec) [__OpenBSD__]:
1235 Don't update the .mdebug section of the Alpha COFF symbol table.
1236
f41628b2
LMI
12372011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1238
1239 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1240 (bug#8460).
1241
b59b67c5
PE
12422011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1243
15e3a074
PE
1244 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1245 This fixes some race conditions on the permissions of any newly
1246 created file.
1247
41bed37d
PE
1248 * alloc.c (valid_pointer_p): Use pipe, not open.
1249 This fixes some permissions issues when debugging.
1250
b59b67c5
PE
1251 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1252 If fchown fails to set both uid and gid, try to set just gid,
1253 as that is sometimes allowed. Adjust the file's mode to eliminate
1254 setuid or setgid bits that are inappropriate if fchown fails.
1255
925a6be7
SM
12562011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1257
1258 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1259 to compare Lisp_Objects.
1260 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1261 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1262 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1263
52968808
AS
12642011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1265
0a6a104b
AS
1266 * lread.c (read_integer): Unread even EOF character.
1267 (read1): Likewise. Properly record start position of symbol.
1268
52968808
AS
1269 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1270 symbol character follows.
1271
9e381cdd
PE
12722011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1275 This works around a problem with the previous change to Fcopy_file.
1276 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1277 and without this change, GCC might complain about discarding
1278 fchown's return value.
1279
b5641435
JB
12802011-07-16 Juanma Barranquero <lekktu@gmail.com>
1281
1282 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1283
a8031457
PE
12842011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1287
dd889327
LMI
12882011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1289
750c33f7
LMI
1290 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1291 it's used from the C level.
1292
dd889327
LMI
1293 * process.c: Use the same condition for POLL_FOR_INPUT in both
1294 keyboard.c and process.c (bug#1858).
1295
87e86684
LM
12962011-07-09 Lawrence Mitchell <wence@gmx.li>
1297
1298 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1299 (Fgnutls_boot): Use it.
1300
64348f40
AS
13012011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1302
1303 * doc.c (Fsubstitute_command_keys): Revert last change.
1304
1d698799
LMI
13052011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1306
f863868c
LMI
1307 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1308 quotes the next character, and doesn't affect other longer
1309 sequences (bug#8935).
1310
1d698799
LMI
1311 * lread.c (syms_of_lread): Clarify that is isn't only
1312 `eval-buffer' and `eval-defun' that's affected by
1313 `lexical-binding' (bug#8460).
1314
aa4b6df6
EZ
13152011-07-15 Eli Zaretskii <eliz@gnu.org>
1316
1317 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1318 bidi redisplay when a line includes both an image and is
1319 truncated.
1320
5d856da6
PE
13212011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1322
ad6042bb
PE
1323 Fix minor problems found by static checking.
1324 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1325 (elsz): Now a signed constant, not a size_t var. We prefer signed
1326 types to unsigned, to avoid integer comparison confusion. Without
1327 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1328 "cannot optimize loop, the loop counter may overflow", a symptom
1329 of the confusion.
f00bbb22 1330 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1331 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1332
6468f31c
LMI
13332011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1334
49080b10
LMI
1335 * search.c (Fre_search_backward): Mention `case-fold-search' in
1336 all the re_search_* functions (bug#8138).
1337
6468f31c
LMI
1338 * keyboard.c (Fopen_dribble_file): Document when the file is
1339 closed (bug#8056).
1340
c965adc5
EZ
13412011-07-14 Eli Zaretskii <eliz@gnu.org>
1342
df9733bf
EZ
1343 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1344 bidi_cache_idx.
1345
0bb23927
EZ
1346 Support bidi reordering of display and overlay strings.
1347 * xdisp.c (compute_display_string_pos)
1348 (compute_display_string_end): Accept additional argument STRING.
1349 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1350 (reseat_to_string): Initialize bidi_it->string.s and
1351 bidi_it->string.schars.
1352 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1353 NULL (avoids a crash in bidi_paragraph_init).
1354 Initialize itb.string.lstring.
0bb23927
EZ
1355 (init_iterator): Call bidi_init_it only of a valid
1356 buffer position was specified. Initialize paragraph_embedding to
1357 L2R.
1358 (reseat_to_string): Initialize the bidi iterator.
1359 (display_string): If we need to ignore text properties of
1360 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1361 original value of -1 will not work with bidi.)
1362 (compute_display_string_pos): First arg is now struct
1363 `text_pos *'; all callers changed. Support display properties on
1364 Lisp strings.
1365 (compute_display_string_end): Support display properties on Lisp
1366 strings.
1367 (init_iterator, reseat_1, reseat_to_string): Initialize the
1368 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1369 when iterating on a string not from display properties).
640c8776
SM
1370 (compute_display_string_pos, compute_display_string_end):
1371 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1372 arrow keys.
1373 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1374 base_level_stop; instead, set base_level_stop to BEGV.
1375 Fixes crashes in vertical-motion.
0bb23927
EZ
1376 (next_element_from_buffer): Improve commentary for when
1377 the iterator is before prev_stop.
1378 (init_iterator): Initialize bidi_p from the default value of
1379 bidi-display-reordering, not from buffer-local value. Use the
1380 buffer-local value only if initializing for buffer iteration.
1381 (handle_invisible_prop): Support invisible properties on strings
1382 that are being bidi-reordered.
1383 (set_iterator_to_next): Support bidi reordering of C strings and
1384 Lisp strings.
1385 (next_element_from_string): Support bidi reordering of Lisp
1386 strings.
1387 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1388 (display_string): Support display of R2L glyph rows.
1389 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1390 (init_iterator): Don't initialize it->bidi_p for strings
1391 here.
1392 (reseat_to_string): Initialize it->bidi_p for strings here.
1393 (next_element_from_string, next_element_from_c_string)
1394 (next_element_from_buffer): Add xassert's for correspondence
1395 between IT's object being iterated and it->bidi_it.string
1396 structure.
1397 (face_before_or_after_it_pos): Support bidi iteration.
1398 (next_element_from_c_string): Handle the case of the first string
1399 character that is not the first one in the visual order.
1400 (get_visually_first_element): New function, refactored from common
1401 parts of next_element_from_buffer, next_element_from_string, and
1402 next_element_from_c_string.
1403 (tool_bar_lines_needed, redisplay_tool_bar)
1404 (display_menu_bar): Force left-to-right direction. Add a FIXME
1405 comment for making that be controlled by a user option.
1406 (push_it, pop_it): Save and restore the state of the
1407 bidi iterator. Save and restore the bidi_p flag.
1408 (pop_it): Iterate out of display property for string iteration as
1409 well.
1410 (iterate_out_of_display_property): Support iteration over strings.
1411 (handle_single_display_spec): Set up it->bidi_it for iteration
1412 over a display string, and call bidi_init_it.
1413 (handle_single_display_spec, next_overlay_string)
1414 (get_overlay_strings_1, push_display_prop): Set up the bidi
1415 iterator for displaying display or overlay strings.
1416 (forward_to_next_line_start): Don't use the shortcut if
1417 bidi-iterating.
1418 (back_to_previous_visible_line_start): If handle_display_prop
1419 pushed the iterator stack, restore the internal state of the bidi
1420 iterator by calling bidi_pop_it same number of times.
1421 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1422 and we are bidi-iterating, don't decrement the iterator position;
1423 instead, set the first_elt flag in the bidi iterator, to produce
1424 the same effect.
1425 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1426 (push_display_prop): xassert that we are iterating a buffer.
1427 (push_it, pop_it): Save and restore paragraph_embedding member.
1428 (handle_single_display_spec, next_overlay_string)
1429 (get_overlay_strings_1, reseat_1, reseat_to_string)
1430 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1431 correctly. Don't assume unibyte strings are not bidi-reordered.
1432 (compute_display_string_pos)
1433 (compute_display_string_end): Fix handling the case of C string.
1434 (push_it, pop_it): Save and restore from_disp_prop_p.
1435 (handle_single_display_spec, push_display_prop): Set the
1436 from_disp_prop_p flag.
1437 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1438 (pop_it): Call iterate_out_of_display_property only if we are
1439 popping after iteration over a string that came from a display
1440 property. Fix a typo in popping stretch info. Add an assertion
1441 for verifying that the iterator position is in sync with the bidi
1442 iterator.
1443 (handle_single_display_spec, get_overlay_strings_1)
1444 (push_display_prop): Fix initialization of paragraph direction for
1445 string when that of the parent object is not yet determined.
1446 (reseat_1): Call bidi_init_it to resync the bidi
1447 iterator with IT's position. (Bug#7616)
1448 (find_row_edges): If ROW->start.pos gives position
1449 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1450 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1451 Reset the from_disp_prop_p flag.
1452 (SAVE_IT, RESTORE_IT): New macros.
1453 (pos_visible_p, face_before_or_after_it_pos)
1454 (back_to_previous_visible_line_start)
1455 (move_it_in_display_line_to, move_it_in_display_line)
1456 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1457 (try_scrolling, redisplay_window, display_line): Use them when
1458 saving a temporary copy of the iterator and restoring it back.
1459 (back_to_previous_visible_line_start, reseat_1)
1460 (init_iterator): Empty the bidi cache "stack".
1461 (move_it_in_display_line_to): If iterator ended up at
1462 EOL, but we never saw any buffer positions smaller than
1463 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1464 motion in bidi-reordered lines.
1465 (move_it_in_display_line_to): Record prev_method and prev_pos
1466 immediately before the call to set_iterator_to_next. Fixes cursor
1467 motion in bidi-reordered lines with stretch glyphs and strings
1468 displayed in margins. (Bug#8133) (Bug#8867)
1469 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1470 TO_CHARPOS.
640c8776
SM
1471 (pos_visible_p): Support positions in bidi-reordered lines.
1472 Save and restore bidi cache.
0bb23927
EZ
1473
1474 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1475 (bidi_paragraph_info): Delete unused struct.
1476 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1477 (bidi_cache_start): New variable.
1478 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1479 to zero.
1480 (bidi_cache_fetch_state, bidi_cache_search)
1481 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1482 (bidi_cache_find, bidi_peek_at_next_level)
1483 (bidi_level_of_next_char, bidi_find_other_level_edge)
1484 (bidi_move_to_visually_next): Compare cache index with
1485 bidi_cache_start rather than with zero.
1486 (bidi_fetch_char): Accept new argument STRING; all callers
1487 changed. Support iteration over a string. Support strings with
1488 display properties. Support unibyte strings. Fix the type of
1489 `len' according to what STRING_CHAR_AND_LENGTH expects.
1490 (bidi_paragraph_init, bidi_resolve_explicit_1)
1491 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1492 (bidi_level_of_next_char, bidi_move_to_visually_next):
1493 Support iteration over a string.
0bb23927
EZ
1494 (bidi_set_sor_type, bidi_resolve_explicit_1)
1495 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1496 can now be zero (for strings); special values 0 and -1 were
1497 changed to -1 and -2, respectively.
1498 (bidi_char_at_pos): New function.
1499 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1500 Call it instead of FETCH_MULTIBYTE_CHAR.
1501 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1502 initialized to valid values.
1503 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1504 values.
1505 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1506 the test for valid cached positions. Fix the logic for looking up
1507 the sentinel state in the cache. GCPRO the Lisp string we are
1508 iterating.
1509 (bidi_push_it, bidi_pop_it): New functions.
1510 (bidi_initialize): Initialize the bidi cache start stack pointer.
1511 (bidi_cache_ensure_space): New function, refactored from part of
1512 bidi_cache_iterator_state. Don't assume the required size is just
1513 one BIDI_CACHE_CHUNK away.
1514 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1515 (bidi_count_bytes, bidi_char_at_pos): New functions.
1516 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1517 always valid if bidi_cache_idx is valid.
1518 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1519 is valid if it's going to be used.
1520 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1521 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1522 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1523 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1524 (bidi_find_other_level_edge, bidi_cache_start_stack):
1525 All variables related to cache indices are now EMACS_INT.
c965adc5 1526
0bb23927
EZ
1527 * dispextern.h (struct bidi_string_data): New structure.
1528 (struct bidi_it): New member `string'. Make flag members be 1-bit
1529 fields, and put them last in the struct.
640c8776
SM
1530 (compute_display_string_pos, compute_display_string_end):
1531 Update prototypes.
0bb23927
EZ
1532 (bidi_push_it, bidi_pop_it): Add prototypes.
1533 (struct iterator_stack_entry): New members bidi_p,
1534 paragraph_embedding, and from_disp_prop_p.
1535 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1536 (bidi_shelve_cache, bidi_unshelve_cache):
1537 Declare prototypes.
0bb23927
EZ
1538
1539 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1540 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1541 and vector-like objects.
1542
1543 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1544 cache around display iteration.
1545
1546 * window.c (Fwindow_end, window_scroll_pixel_based)
1547 (displayed_window_lines, Frecenter): Save and restore the bidi
1548 cache around display iteration.
1549
3bbd2265
LMI
15502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1551
1552 * editfns.c (Fdelete_region): Clarify the use of the named
1553 parameters (bug#6788).
1554
adc47434
MR
15552011-07-14 Martin Rudalics <rudalics@gmx.at>
1556
1557 * indent.c (Fvertical_motion): Set and restore w->pointm when
1558 saving and restoring the window's buffer (Bug#9006).
1559
837c31f8
LMI
15602011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1561
1562 * editfns.c (Fstring_to_char): Clarify just what is returned
1563 (bug#6576). Text by Eli Zaretskii.
1564
ac389d0c
JB
15652011-07-13 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1568
0be0ce47
EZ
15692011-07-13 Eli Zaretskii <eliz@gnu.org>
1570
1571 * buffer.c (mmap_find): Fix a typo.
1572
cd18e7e3
JB
15732011-07-13 Johan Bockgård <bojohan@gnu.org>
1574
1575 Fix execution of x selection hooks.
1576 * xselect.c (Qx_lost_selection_functions)
1577 (Qx_sent_selection_functions): New vars.
1578 (syms_of_xselect): DEFSYM them.
1579 (x_handle_selection_request): Pass Qx_sent_selection_functions
1580 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1581 (x_handle_selection_clear,x_clear_frame_selections):
1582 Pass Qx_lost_selection_functions rather than
1583 Vx_lost_selection_functions to Frun_hook_with_args.
1584
47ea7f44
PE
15852011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1586
ac389d0c 1587 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1588 The old code sometimes used this field without initializing it.
1589
47ea7f44
PE
1590 * alloc.c (gc_sweep): Don't read past end of array.
1591 In theory, the old code could also have corrupted Emacs internals,
1592 though it'd be very unlikely.
1593
bc985c87
AS
15942011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1595
1596 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1597 argument. (Bug#4026)
bc985c87 1598
0cf34688
LMI
15992011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1600
b3dadd76
LMI
1601 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1602 key" (bug#4257).
1603
0cf34688
LMI
1604 * window.c (Fset_window_start): Doc fix (bug#4199).
1605 (Fset_window_hscroll): Ditto.
1606
270768cd
PE
16072011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1608
077e3dda 1609 Fix minor new problems caught by GCC 4.6.1.
270768cd 1610 * term.c (init_tty): Remove unused local.
490011a6 1611 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1612 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1613 not used otherwise.
270768cd 1614
b1f58454
CY
16152011-07-12 Chong Yidong <cyd@stupidchicken.com>
1616
1617 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1618
22b9578d
LMI
16192011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1620
6e70ab07
LMI
1621 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1622 are the mini-buffer and the echo area (bug#3320).
1623
22b9578d
LMI
1624 * term.c (init_tty): Remove support for supdup, c10 and perq
1625 terminals, which are no longer supported (bug#1482).
1626
8974cc9f
JB
16272011-07-10 Johan Bockgård <bojohan@gnu.org>
1628
1629 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1630
a560d974
JD
16312011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1632
1633 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1634 for non-popups (Bug#3642).
1635
1dae0f0a
AS
16362011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1637
268c2c36 1638 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1639 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1640 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1641 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1642 * data.c (fmod): Likewise.
1643 * dispnew.c (swap_glyphs_in_rows): Likewise.
1644 * emacs.c (memory_warning_signal): Likewise.
1645 * floatfns.c (float_error): Likewise.
1646 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1647 (otf_open, font_otf_capability, generate_otf_features)
1648 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1649 Likewise.
1650 * image.c (pbm_read_file): Likewise.
1651 * indent.c (string_display_width): Likewise.
1652 * intervals.c (check_for_interval, search_for_interval)
1653 (inc_interval_count, count_intervals, root_interval)
1654 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1655 * lread.c (defalias): Likewise.
268c2c36 1656 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1657 * regex.c (set_image_of_range_1, set_image_of_range)
1658 (regex_grow_registers): Likewise.
1659 * sysdep.c (strerror): Likewise.
1660 * termcap.c (valid_filename_p, tprint, main): Likewise.
1661 * tparam.c (main): Likewise.
1662 * unexhp9k800.c (run_time_remap, save_data_space)
1663 (update_file_ptrs, read_header, write_header, calculate_checksum)
1664 (copy_file, copy_rest, display_header): Likewise.
1665 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1666 Likewise.
1667 * xdisp.c (check_it): Likewise.
1668 * xfaces.c (register_color, unregister_color, unregister_colors):
1669 Likewise.
1670 * xfns.c (print_fontset_result): Likewise.
1671 * xrdb.c (member, fatal, main): Likewise.
1672
99033785
PE
16732011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1674
1675 Fix minor problems found by static checking (Bug#9031).
1676 * chartab.c (char_table_set_range, map_sub_char_table):
1677 Remove unused locals.
1678 (uniprop_table): Now static.
1679 * composite.c (_work_char): Remove unused static var.
1680
9cb2ac56
JB
16812011-07-09 Juanma Barranquero <lekktu@gmail.com>
1682
1683 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1684
f25661f0
JD
16852011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1686
1687 * gtkutil.c (qttip_cb): Remove code without function.
1688
8278c4fe
EZ
16892011-07-09 Eli Zaretskii <eliz@gnu.org>
1690
1691 * w32.c (pthread_sigmask): New stub.
1692
1692ae2d 16932011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1694
8a6ebd58 1695 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1696 sigprocmask is portable only for single-threaded applications, and
1697 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1698 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1699 (LIBES): Use it.
1700 * callproc.c (Fcall_process):
1701 * process.c (create_process):
1702 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1703 Use pthread_sigmask, not sigprocmask.
123403e4 1704
1b854618
JD
17052011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1706
1707 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1708 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1709 wrong (Bug#8591).
1710
3fe4b549
JD
17112011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1712
0ce7e563
JD
1713 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1714 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1715 (xg_hide_tooltip): Fix comment.
1716
3fe4b549
JD
1717 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1718 in registerServicesMenuSendTypes.
1719 (validRequestorForSendType): Don't check ns_return_types.
1720
1721 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1722 ns_return_type.
1723
5df75e47
JR
17242011-07-08 Jason Rumney <jasonr@gnu.org>
1725
1726 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1727 frame struct members of non-existent frames (Bug#6284).
1728
699c10bd
JD
17292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1730
4393663b
JD
1731 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1732 variable firstTime not needed on OSX >= 10.6.
1733 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1734 >= 10.5. Use setKnobProportion, setDoubleValue.
1735
1736 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1737 (MAC_OS_X_VERSION_10_5): Define if not defined.
1738 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1739 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1740 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1741
1742 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1743 cString and lossyCString on OSX >= 10.4
1744
1745 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1746 sizeToFit on OSX >= 10.2.
1747
1748 * nsimage.m (allocInitFromFile): Don't use deprecated method
1749 bestRepresentationForDevice on OSX >= 10.6.
1750
1751 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1752 to avoid warning.
1753
1754 * emacs.c: Declare unexec_init_emacs_zone.
1755
a63e0781
JD
1756 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1757
699c10bd
JD
1758 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1759
1760 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1761 on svcsMenu (Bug#8842).
1762
1763 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1764 ns_return_types.
1765 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1766
1767 * nsterm.m (QUTF8_STRING): Declare.
1768 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1769 (validRequestorForSendType): Return type is (id).
1770 Change indexOfObjectIdenticalTo to indexOfObject.
1771 Check if we have local selection before returning self (Bug#8842).
1772 (writeSelectionToPasteboard): Put local selection into paste board
1773 if we have a local selection (Bug#8842).
1774 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1775
1776 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1777 (ns_get_local_selection): Declare.
1778
54e10184
LMI
17792011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1780
9888ff71
LMI
1781 * keymap.c (describe_map_tree): Don't insert a double newline at
1782 the end of the buffer (bug#1169) and return whether we inserted
1783 something.
1784
54e10184
LMI
1785 * callint.c (Fcall_interactively): Change "reading args" to
1786 "providing args" to try to clarify what it does (bug#1010).
1787
15fa4783
KH
17882011-07-07 Kenichi Handa <handa@m17n.org>
1789
1790 * composite.c (composition_compute_stop_pos): Ignore a static
1791 composition starting before CHARPOS (Bug#8915).
1792
1793 * xdisp.c (handle_composition_prop): Likewise.
1794
a8815b00
EZ
17952011-07-07 Eli Zaretskii <eliz@gnu.org>
1796
1797 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1798 (Bug#9015)
1799
ef7b981d 18002011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1801
1802 * character.h (unicode_category_t): New enum type.
1803
1804 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1805 (Qchar_code_property_table): New variable.
1806 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1807 (UNIPROP_COMPRESSED_FORM_P): New macros.
1808 (char_table_ascii): Uncompress the compressed values.
1809 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1810 Uncompress the compressed values.
ac389d0c 1811 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1812 (char_table_ref_and_range): Uncompress the compressed values.
1813 (sub_char_table_set): New arg is_uniprop. Callers changed.
1814 Uncompress the compressed values.
1815 (sub_char_table_set_range): Args changed. Callers changed.
1816 (char_table_set_range): Adjuted for the above change.
1817 (map_sub_char_table): Delete args default_val and parent. Add arg
1818 top. Give decoded values to a Lisp function.
640c8776 1819 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1820 values to a Lisp function. Gcpro more variables.
1821 (uniprop_table_uncompress)
1822 (uniprop_decode_value_run_length): New functions.
1823 (uniprop_decoder, uniprop_decoder_count): New variables.
1824 (uniprop_get_decoder, uniprop_encode_value_character)
1825 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1826 New functions.
1827 (uniprop_encoder, uniprop_encoder_count): New variables.
1828 (uniprop_get_encoder, uniprop_table)
1829 (Funicode_property_table_internal, Fget_unicode_property_internal)
1830 (Fput_unicode_property_internal): New functions.
1831 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1832 Sunicode_property_table_internal, Sget_unicode_property_internal,
1833 and Sput_unicode_property_internal. Defvar_lisp
1834 char-code-property-alist.
1835
640c8776 1836 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1837 Vunicode_category_table.
1838
640c8776 1839 * font.c (font_range): Adjust for the change of
c805dec0
KH
1840 Vunicode_category_table.
1841
76b397fb
DN
18422011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1843
1844 * m/iris4d.h: Remove file, move contents ...
1845 * s/irix6-5.h: ... here.
1846
22b4128e
PE
18472011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1850 * alloc.c (mark_buffer):
1851 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1852 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1853 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1854 This isn't true in general, and it's particularly not true
1855 if Emacs is configured with --with-wide-int.
1856 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1857 New macros, used in the buffer.c change.
1858
869795d6
JD
18592011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1860
1861 * xsettings.c: Use both GConf and GSettings if both are available.
1862 (store_config_changed_event): Add comment.
1863 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1864 (store_tool_bar_style_changed): New functions.
1865 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1866 (struct xsettings): Move font inside HAVE_XFT.
1867 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1868 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1869 Move inside HAVE_XFT.
640c8776 1870 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1871 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1872 also.
1873 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1874 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1875 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1876 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1877 (parse_settings): Move check for font inside HAVE_XFT.
1878 (read_settings, apply_xft_settings): Add comment.
1879 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1880 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1881 call store_font_name_changed.
1882 (xft_settings_event): Add comment.
1883 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1884 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1885 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1886 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1887 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1888 (xsettings_get_system_font, xsettings_get_system_normal_font):
1889 Add comment.
869795d6 1890
d8ed26bd
PE
18912011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1892
1893 Random fixes. E.g., (random) never returned negative values.
1894 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1895 subseconds part to the entropy, as that's a bit more random.
1896 Prefer signed to unsigned, since the signedness doesn't matter and
1897 in general we prefer signed. When given a limit, use a
1898 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1899 latter isn't right if USE_2_TAGS_FOR_INTS.
1900 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1901 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1902
cabf1cac
SM
19032011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1904
1905 * textprop.c (text_property_stickiness):
1906 Obey Vtext_property_default_nonsticky.
1907 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1908 * w32fns.c (syms_of_w32fns):
1909 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1910
6e9b2be9
PE
19112011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1914 This is more efficient than Ffile_directory_p and avoids a minor race.
1915
90186c68
LMI
19162011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1917
7c301272
LMI
1918 * buffer.c (Foverlay_put): Say what the return value is
1919 (bug#7835).
1920
c4f2d8d4
LMI
1921 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1922 is a directory before asking whether to use the file name
1923 (bug#7564).
ad637907
LMI
1924 (barf_or_query_if_file_exists): Make the "File is a directory"
1925 error be more correct.
c4f2d8d4 1926
90186c68
LMI
1927 * fns.c (Frequire): Remove the mention of the .gz files, since
1928 that's installation-specific, but keep the mention of
1929 `get-load-suffixes'.
1930
da64016e
PE
19312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1934 Report string overflow if the output is too long.
1935
7d47b580
JB
19362011-07-04 Juanma Barranquero <lekktu@gmail.com>
1937
a555cb87
JB
1938 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1939 (syms_of_gnutls): Remove duplicate DEFSYM for
1940 Qgnutls_bootprop_verify_hostname_error, an error for
1941 Qgnutls_bootprop_verify_error (which is no longer used).
1942
7d47b580
JB
1943 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1944 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1945 Also (re)move comments that are misplaced or no longer relevant.
1946
1e49bfab
LMI
19472011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1948
1949 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1950
1485f4c0
CY
19512011-07-03 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1954 and background color parameters if they have been changed.
1955
a9ab721e
LMI
19562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1957
1958 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1959
cf7cff57
PE
19602011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1961
2e13213d
PE
1962 * xsettings.c (SYSTEM_FONT): Define only when used.
1963 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1964
cf7cff57
PE
1965 * keymap.c (access_keymap_1): Now static.
1966
7a8e04f7
CY
19672011-07-02 Chong Yidong <cyd@stupidchicken.com>
1968
1969 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1970 leave any prefix arg for the up event (Bug#1586).
1971
61352f62
LMI
19722011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1973
69bb1ef7
LMI
1974 * lread.c (syms_of_lread): Mention single symbols defined by
1975 `defvar' or `defconst' (bug#7154).
1976
61352f62 1977 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1978 (Frequire): Mention get-load-suffixes.
61352f62 1979
28545e04
MR
19802011-07-02 Martin Rudalics <rudalics@gmx.at>
1981
1982 * window.h (window): Remove clone_number slot.
1983 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1984 Remove.
1985 (make_parent_window, make_window, saved_window)
1986 (Fset_window_configuration, save_window_save): Don't deal with
1987 clone numbers.
1988 * buffer.c (Qclone_number): Remove declaration.
1989 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1990
3349e122
SM
19912011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1992
1993 Add multiple inheritance to keymaps.
1994 * keymap.c (Fmake_composed_keymap): New function.
1995 (Fset_keymap_parent): Simplify.
1996 (fix_submap_inheritance): Remove.
1997 (access_keymap_1): New function extracted from access_keymap to handle
1998 embedded parents and handle lists of maps.
1999 (access_keymap): Use it.
2000 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2001 (Fcopy_keymap): Handle embedded parents.
2002 (Fcommand_remapping, define_as_prefix): Simplify.
2003 (Fkey_binding): Simplify.
2004 (syms_of_keymap): Move minibuffer-local-completion-map,
2005 minibuffer-local-filename-completion-map,
2006 minibuffer-local-must-match-map, and
2007 minibuffer-local-filename-must-match-map to Elisp.
2008 (syms_of_keymap): Defsubr make-composed-keymap.
2009 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2010 (parse_menu_item): Trivial simplification.
2011
3279eb87
GM
20122011-07-01 Glenn Morris <rgm@gnu.org>
2013
2014 * Makefile.in (SETTINGS_LIBS): Fix typo.
2015
4550efdf
KI
20162011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2017
2018 * coding.c (Fencode_coding_string): Record the last coding system
2019 used, as the function doc string says (bug#8738).
2020
0949d2b6
JD
20212011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2022
2023 * xsettings.c (store_monospaced_changed): Take new font as arg and
2024 check for change against current_mono_font.
2025 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2026 (emacs_settings_constructor, emacs_settings_get_property)
2027 (emacs_settings_set_property, emacs_settings_class_init)
2028 (emacs_settings_init, gsettings_obj): Remove.
2029 (something_changedCB): New function for HAVE_GSETTINGS.
2030 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2031 with value as argument.
2032 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2033 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2034 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2035 "changed".
2036
2037 * xgselect.c: Add defined (HAVE_GSETTINGS).
2038 (xgselect_initialize): Ditto.
2039
2040 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2041 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2042 xg_select.
2043
bbc6b304
PE
20442011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 * eval.c (struct backtrace): Simplify and port the data structure.
2047 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2048 signed bit field, as this assumption is not portable and it makes
2049 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2050 "char debug_on_exit : 1" as this is not portable either; instead,
2051 use the portable "unsigned int debug_on_exit : 1". Remove unused
2052 member evalargs. Remove obsolete comments about cc bombing out.
2053
9851bfc5
JD
20542011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2055
51bb811f 2056 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2057 Let HAVE_GSETTINGS override HAVE_GCONF.
2058 (store_monospaced_changed): New function.
2059 (EMACS_SETTINGS): A new type derived from GObject to handle
2060 GSettings notifications.
2061 (emacs_settings_constructor, emacs_settings_get_property)
2062 (emacs_settings_set_property, emacs_settings_class_init):
2063 New functions.
2064 (gsettings_client, gsettings_obj): New variables.
2065 (GSETTINGS_SCHEMA): New define.
2066 (something_changedCB): Call store_monospaced_changed.
2067 (init_gsettings): New function.
2068 (xsettings_initialize): Call init_gsettings.
2069 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2070 to NULL.
2071
640c8776 2072 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2073 GCONF_CFLAGS/LIBS.
2074
5386012d
MR
20752011-06-29 Martin Rudalics <rudalics@gmx.at>
2076
2077 * window.c (resize_root_window, grow_mini_window)
2078 (shrink_mini_window): Rename Qresize_root_window to
2079 Qwindow_resize_root_window and Qresize_root_window_vertically to
2080 Qwindow_resize_root_window_vertically.
2081
f13e0b08
PE
20822011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2085
94515237
JB
20862011-06-27 Juanma Barranquero <lekktu@gmail.com>
2087
2088 * makefile.w32-in: Redesign dependencies so they reflect more
2089 clearly which files are directly included by each source file,
2090 and not through other includes.
2091
e43b6e43
MR
20922011-06-27 Martin Rudalics <rudalics@gmx.at>
2093
2094 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2095 (sort_overlays, overlay_strings): When an overlay's clone number
2096 matches the window's clone number process the overlay even if
2097 the overlay's window property doesn't match the current window.
2098
d68443dc
MR
2099 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2100 (Fwindow_hchild): Rename to Fwindow_left_child.
2101 (Fwindow_next): Rename to Fwindow_next_sibling.
2102 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2103 (resize_window_check): Rename to window_resize_check.
2104 (resize_window_apply): Rename to window_resize_apply.
2105 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2106 (Fdelete_other_windows_internal, resize_frame_windows)
2107 (Fsplit_window_internal, Fdelete_window_internal)
2108 (grow_mini_window, shrink_mini_window)
2109 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2110
c7e73be5
JD
21112011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2112
2113 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2114 (emacs_fixed_set_min_size): Remove.
2115 (emacs_fixed_new): Take frame as argument.
2116
2117 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2118 (_EmacsFixedPrivate): Remove minwidth/height.
2119 Add struct frame *f.
2120 (emacs_fixed_init): Initialize priv->f.
2121 (get_parent_class, emacs_fixed_set_min_size): Remove.
2122 (emacs_fixed_new): Set priv->f to argument.
2123 (emacs_fixed_get_preferred_width)
2124 (emacs_fixed_get_preferred_height): Use min_width/height from
2125 frames size_hint to set minimum and natural (Bug#8919).
2126 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2127 and use min_width/height from frames size_hint to set
2128 min_width/height (Bug#8919).
2129
2130 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2131 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2132 Fix indentation.
c7e73be5 2133
cf99dcf8
EZ
21342011-06-26 Eli Zaretskii <eliz@gnu.org>
2135
2136 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2137 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2138 called at ZV.
2139
029529ac
CY
21402011-06-26 Chong Yidong <cyd@stupidchicken.com>
2141
2142 * process.c (wait_reading_process_output): Bypass select if
2143 waiting for a cell while ignoring keyboard input, and input is
2144 pending. Suggested by Jan Djärv (Bug#8869).
2145
7a7ef429
PE
21462011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2147
2148 Use gnulib's dup2 module instead of rolling our own.
2149 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2150
11fdef7d 21512011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2152
2153 * dispnew.c (scrolling_window): Before scrolling, turn off a
2154 mouse-highlight in the window being scrolled.
2155
cd3520a4
JB
21562011-06-24 Juanma Barranquero <lekktu@gmail.com>
2157
2158 Move DEFSYM to lisp.h and use everywhere.
2159
2160 * character.h (DEFSYM): Move declaration...
2161 * lisp.h (DEFSYM): ...here.
2162
2163 * gnutls.c:
2164 * minibuf.c:
2165 * w32menu.c:
2166 * w32proc.c:
2167 * w32select.c: Don't include character.h.
2168
2169 * alloc.c (syms_of_alloc):
2170 * buffer.c (syms_of_buffer):
2171 * bytecode.c (syms_of_bytecode):
2172 * callint.c (syms_of_callint):
2173 * casefiddle.c (syms_of_casefiddle):
2174 * casetab.c (init_casetab_once):
2175 * category.c (init_category_once, syms_of_category):
2176 * ccl.c (syms_of_ccl):
2177 * cmds.c (syms_of_cmds):
2178 * composite.c (syms_of_composite):
2179 * dbusbind.c (syms_of_dbusbind):
2180 * dired.c (syms_of_dired):
2181 * dispnew.c (syms_of_display):
2182 * doc.c (syms_of_doc):
2183 * editfns.c (syms_of_editfns):
2184 * emacs.c (syms_of_emacs):
2185 * eval.c (syms_of_eval):
2186 * fileio.c (syms_of_fileio):
2187 * fns.c (syms_of_fns):
2188 * frame.c (syms_of_frame):
2189 * fringe.c (syms_of_fringe):
2190 * insdel.c (syms_of_insdel):
2191 * keymap.c (syms_of_keymap):
2192 * lread.c (init_obarray, syms_of_lread):
2193 * macros.c (syms_of_macros):
2194 * msdos.c (syms_of_msdos):
2195 * print.c (syms_of_print):
2196 * process.c (syms_of_process):
2197 * search.c (syms_of_search):
2198 * sound.c (syms_of_sound):
2199 * syntax.c (init_syntax_once, syms_of_syntax):
2200 * terminal.c (syms_of_terminal):
2201 * textprop.c (syms_of_textprop):
2202 * undo.c (syms_of_undo):
2203 * w32.c (globals_of_w32):
2204 * window.c (syms_of_window):
2205 * xdisp.c (syms_of_xdisp):
2206 * xfaces.c (syms_of_xfaces):
2207 * xfns.c (syms_of_xfns):
2208 * xmenu.c (syms_of_xmenu):
2209 * xsettings.c (syms_of_xsettings):
2210 * xterm.c (syms_of_xterm): Use DEFSYM.
2211
4228cf16
TZ
22122011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2213
cd3520a4 2214 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2215
7fcccf1e
PE
22162011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2217
7efb4e0e
PE
2218 Integer and buffer overflow fixes (Bug#8873).
2219
ff5844ad
PE
2220 * print.c (printchar, strout): Check for string overflow.
2221 (PRINTPREPARE, printchar, strout):
2222 Don't set size unless allocation succeeds.
2223
90532f02
PE
2224 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2225 for sizes. Check for string overflow more accurately.
2226 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2227
6d84508d
PE
2228 * macros.c: Integer and buffer overflow fixes.
2229 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2230 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2231 Use ptrdiff_t, not int, for sizes.
2232 Don't increment bufsize until after realloc succeeds.
2233 Check for size-calculation overflow.
2234 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2235
437b2cb4
PE
2236 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2237
8b9ac8b4
PE
2238 * lread.c: Integer overflow fixes.
2239 (read_integer): Radix is now EMACS_INT, not int,
2240 to improve quality of diagnostics for out-of-range radices.
2241 Calculate buffer size correctly for out-of-range radices.
2242 (read1): Check for integer overflow in radices, and in
2243 read-circle numbers.
82cb60d3
PE
2244 (read_escape): Avoid int overflow.
2245 (Fload, openp, read_buffer_size, read1)
2246 (substitute_object_recurse, read_vector, read_list, map_obarray):
2247 Use ptrdiff_t, not int, for sizes.
2248 (read1): Use EMACS_INT, not int, for sizes.
20270765 2249 Check for size overflow.
8b9ac8b4 2250
7fcccf1e
PE
2251 * image.c (cache_image): Check for size arithmetic overflow.
2252
bfbbd7e7
PE
2253 * lread.c: Integer overflow issues.
2254 (saved_doc_string_size, saved_doc_string_length)
2255 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2256 Now ptrdiff_t, not int.
2257 (read1): Don't assume doc string length fits in int. Check for
2258 out-of-range doc string lengths.
2259 (read_list): Don't assume file position fits in int.
39019e54 2260 (read_escape): Check for hex character overflow.
bfbbd7e7 2261
4e323265
LL
22622011-06-22 Leo Liu <sdl.web@gmail.com>
2263
2264 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2265 Move to minibuffer.el.
2266
85fece3e
PE
22672011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2268
20b84ce9 2269 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2270 The following patches are for when GLYPH_DEBUG && !XASSERT.
2271 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2272 * dispnew.c (flush_stdout):
2273 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2274 Mark as externally visible.
2275 * dispnew.c (check_window_matrix_pointers): Now static.
2276 * dispnew.c (window_to_frame_vpos):
2277 * xfns.c (unwind_create_frame):
2278 * xterm.c (x_check_font): Remove unused local.
2279 * scroll.c (CHECK_BOUNDS):
2280 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2281 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2282 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2283 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2284 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2285 Now static.
2286 (debug_method_add): Use va_list and vsprintf rather than relying
2287 on undefined behavior with wrong number of arguments.
2288 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2289 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2290 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2291 since we're not interested in debugging glyphs with old libraries.
2292 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2293 GCC 4.6.0's static checking.
2294
0766b489
PE
22952011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2296
31fd4b32
PE
2297 Integer overflow and signedness fixes (Bug#8873).
2298 A few related buffer overrun fixes, too.
2299
b79e8648
PE
2300 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2301
0766b489
PE
2302 * dispextern.h (struct face.stipple):
2303 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2304 (x_bitmap_mask, x_allocate_bitmap_record)
2305 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2306 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2307 (x_create_bitmap_from_xpm_data):
2308 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2309 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2310 (.bitmaps_last):
2311 * xfaces.c (load_pixmap):
2312 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2313 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2314 (.bitmaps_last, struct x_output.icon_bitmap):
2315 Use ptrdiff_t, not int, for bitmap indexes.
2316 (x_allocate_bitmap_record): Check for size overflow.
2317 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2318
b081724f
PE
2319 Use ptrdiff_t, not int, for overlay counts.
2320 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2321 * editfns.c (overlays_around, get_pos_property):
2322 * textprop.c (get_char_property_and_overlay):
2323 * xdisp.c (next_overlay_change, note_mouse_highlight):
2324 * xfaces.c (face_at_buffer_position):
21514da7
PE
2325 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2326 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2327 (Fnext_overlay_change, Fprevious_overlay_change)
2328 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2329 Use ptrdiff_t, not int, for sizes.
21514da7 2330 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2331
3de73e5e
PE
2332 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2333
2606c57b
PE
2334 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2335 (x_session_initialize): Do not assume string length fits in int.
2336
aaafe47a
PE
2337 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2338 This is unlikely, but can occur if DPI is outlandish.
2339
2674ddc8 2340 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2341 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2342
28154962
PE
2343 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2344 * xrdb.c (magic_file_p, search_magic_path):
2345 Omit last arg SUFFIX; it was always 0. All callers changed.
2346 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2347
7de51af5
PE
2348 * xfont.c (xfont_match): Avoid need for strlen.
2349
25ed6cc3
PE
2350 * xfns.c: Don't assume strlen fits in int.
2351 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2352
4eab31dd
PE
2353 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2354 not unsigned long, as we prefer signed integers. All callers changed.
2355 Detect integer overflow in repeat count.
2356 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2357 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2358
171e2a58
PE
2359 * termcap.c: Don't assume sizes fit in int and never overflow.
2360 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2361 (gobble_line): Check for size-calculation overflow.
2362
ad39faca 2363 * minibuf.c (Fread_buffer):
6e5bb2dc 2364 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2365 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2366 Don't assume string length fits in int.
2367
52c61c22 2368 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2369 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2370
b5b8c9e5
PE
2371 * font.c: Don't assume string length fits in int.
2372 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2373 Use ptrdiff_t, not int.
ccd6111c
PE
2374 (font_intern_prop): Don't assume string length fits in int.
2375 Don't assume integer property fits in fixnum.
2376 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2377
882f0d81 2378 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2379 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2380 Reformulate so as not to need the command string.
2381 Invoke gzip -cd rather than gunzip, as it's more portable.
2382 (lock_info_type, lock_file_1, lock_file):
2383 Don't assume pid_t and time_t fit in unsigned long.
2384 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2385 (current_lock_owner): Prefer signed type for sizes.
2386 Use memcpy, not strncpy, where memcpy is what is really wanted.
2387 Don't assume (via atoi) that time_t and pid_t fit in int.
2388 Check for time_t and/or pid_t out of range, e.g., via a network share.
2389 Don't alloca where an auto var works fine.
2390
93f4cf88
PE
2391 * fileio.c: Fix some integer overflow issues.
2392 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2393 Don't assume string length fits in int.
2394 (directory_file_name): Don't assume string length fits in long.
2395 (make_temp_name): Don't assume pid fits in int, or that its print
2396 length is less than 20.
2397
f3e92b69
PE
2398 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2399
1bfdaf10
PE
2400 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2401
35016e9a
PE
2402 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2403
3d1e65a1
PE
2404 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2405 We prefer signed integers, even for size calculations.
2406
0b963a93
PE
2407 * emacs.c: Don't assume string length fits in 'int'.
2408 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2409 (main): Don't invoke strlen when not needed.
2410
573f4b54
PE
2411 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2412 (XD_DEBUG_MESSAGE): Don't waste a byte.
2413
989f33ba
PE
2414 * callproc.c (getenv_internal_1, getenv_internal)
2415 (Fgetenv_internal):
965d34eb
PE
2416 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2417
e4d29b33
PE
2418 * lread.c (invalid_syntax): Omit length argument.
2419 All uses changed. This doesn't fix a bug, but it simplifies the
2420 code away from its former Hollerith-constant appearance, and it's
2421 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2422 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2423
eb49b136
PE
2424 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2425 This didn't break anything, but it didn't help either.
2426 It's confusing to put a bogus integer in a place where the actual
2427 value does not matter.
9f62aeb1 2428 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2429 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2430
15375a22
PE
2431 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2432 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2433 implementation.
b61cc01c
PE
2434 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2435 We prefer signed types, and the value cannot exceed the EMACS_INT
2436 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2437 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2438 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2439 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2440
53b2623d
PE
2441 * indent.c (sane_tab_width): New function.
2442 (current_column, scan_for_column, Findent_to, position_indentation)
2443 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2444 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2445
51cab52b 2446 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2447
f2ed8a70
PE
2448 * lisp.h (lint_assume): New macro.
2449 * composite.c (composition_gstring_put_cache):
2450 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2451
abe80cc6
PE
2452 * editfns.c, insdel.c:
2453 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2454
b02c740e
PE
2455 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2456
ebc96716
PE
2457 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2458
b4e50fa0 2459 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2460 Use much-faster test for byte-length change.
311d5d7c 2461 Don't assume string byte-length fits in 'int'.
a4cf38e4 2462 Check that character arg fits in 'int'.
85461888 2463 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2464
c0c1ee9f
PE
2465 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2466
a498d7f4
PE
2467 * fns.c (concat): Catch string overflow earlier.
2468 Do not rely on integer wraparound.
2469
51cab52b
PE
2470 * dispextern.h (struct it.overlay_strings_charpos)
2471 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2472 * xdisp.c (forward_to_next_line_start)
2473 (back_to_previous_visible_line_start)
2474 (reseat_at_next_visible_line_start, next_element_from_buffer):
2475 Don't arbitrarily truncate the value of 'selective' to int.
2476
76031fad
PE
2477 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2478
5eb55db9
PE
2479 * composite.c: Don't truncate sizes to 'int'.
2480 (composition_gstring_p, composition_reseat_it)
2481 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2482 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2483 not EMACS_UINT, for indexes.
5eb55db9 2484
0703a717
PE
2485 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2486
d6202519
PE
2487 * buffer.c: Include <verify.h>.
2488 (struct sortvec.priority, struct sortstr.priority):
8961a454 2489 Now EMACS_INT, not int.
c20998a7 2490 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2491 (struct sortstr.size, record_overlay_string)
2492 (struct sortstrlist.size, struct sortlist.used):
2493 Don't truncate size to int.
2494 (record_overlay_string): Check for size-calculation overflow.
d6202519 2495 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2496
d5a19415
JM
24972011-06-22 Jim Meyering <meyering@redhat.com>
2498
029529ac 2499 Don't leak an XBM-image-sized buffer
d5a19415
JM
2500 * image.c (xbm_load): Free the image buffer after using it.
2501
a9041e6c
PE
25022011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2503
2504 Port to Sun C.
2505 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2506 that Sun C diagnosed.
2507 * fns.c (secure_hash): Fix pointer signedness issue.
2508 * intervals.c (static_offset_intervals): New function.
2509 (offset_intervals): Use it.
2510
7f3f739f
LL
25112011-06-21 Leo Liu <sdl.web@gmail.com>
2512
2513 * deps.mk (fns.o):
2514 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2515 sha512.h.
2516
2517 * fns.c (secure_hash): Rename from crypto_hash_function and change
2518 the first arg to accept symbols.
5b66d427 2519 (Fsecure_hash): New primitive.
7f3f739f
LL
2520 (syms_of_fns): New symbols.
2521
76147d94
DD
25222011-06-20 Deniz Dogan <deniz@dogan.se>
2523
2524 * process.c (Fset_process_buffer): Clarify return value in
2525 docstring.
2526
7d7d0045
CY
25272011-06-18 Chong Yidong <cyd@stupidchicken.com>
2528
2529 * dispnew.c (add_window_display_history): Use BVAR.
2530
2531 * xdisp.c (debug_method_add): Use BVAR.
2532 (check_window_end, dump_glyph_matrix, dump_glyph)
2533 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2534
2535 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2536 Likewise.
2537
2538 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2539 check till after the cache is created in init_frame_faces.
2540
ff2bc410
SM
25412011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2542
2543 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2544
28177add
PE
25452011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2546
dd3482fe
PE
2547 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2548 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2549 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2550
393d71f3 2551 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2552 * fileio.c (Finsert_file_contents):
2553 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2554 Remove the old (too-loose) buffer overflow checks.
2555 They weren't needed, since make_gap checks for buffer overflow.
2556 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2557 The old code merely checked for Emacs fixnum overflow, and relied
2558 on undefined (wraparound) behavior. The new code avoids undefined
2559 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2560
2e6813b0 2561 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2562 Tune. Don't use wider integers than needed. Don't use alloca.
2563 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2564
599a9e4f
PE
2565 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2566
99561444
PE
2567 * insdel.c, lisp.h (buffer_overflow): New function.
2568 (insert_from_buffer_1, replace_range, replace_range_2):
2569 * insdel.c (make_gap_larger):
2570 * editfns.c (Finsert_char):
2571 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2572
28177add
PE
2573 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2574
e69dafad
PE
25752011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2576
a7af7fde 2577 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2578
b1c46f02
PE
2579 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2580 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2581
e69dafad
PE
2582 * fileio.c: Don't assume EMACS_INT fits in off_t.
2583 (emacs_lseek): New static function.
2584 (Finsert_file_contents, Fwrite_region): Use it.
2585 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2586
566684ea
PE
2587 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2588
e6966cd6
PE
2589 * fns.c: Don't overflow int when computing a list length.
2590 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2591 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2592 truncation on 64-bit hosts. Check for QUIT every
2593 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2594 faster and is responsive enough.
2595 (Flength): Report an error instead of overflowing an integer.
2596 (Fsafe_length): Return a float if the value is not representable
2597 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2598 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2599 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2600
dd0b0efb
PE
2601 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2602 (header_size, word_size): New constants.
2603 (allocate_vectorlike): Don't check size overflow here.
2604 (allocate_vector): Check it here instead, since this is the only
2605 caller of allocate_vectorlike that could cause overflow.
2606 Check that the new vector's length is representable as a fixnum.
2607
86fe5cfe
PE
2608 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2609 The previous code was bogus. For example, next_almost_prime (32)
2610 returned 39, which is undesirable as it is a multiple of 3; and
2611 next_almost_prime (24) returned 25, which is a multiple of 5 so
2612 why was the code bothering to check for multiples of 7?
2613
80e88859
PE
2614 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2615
4a2f0ad6
PE
2616 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2617
f66c7cf8
PE
2618 Variadic C functions now count arguments with ptrdiff_t.
2619 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2620 Back then I didn't know that the Emacs coding style prefers signed int.
2621 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2622 were being counted with int, which may truncate counts on 64-bit
2623 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2624 * lisp.h (struct Lisp_Subr.function.aMANY)
2625 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2626 Arg counts are now ptrdiff_t, not size_t.
2627 All variadic functions and their callers changed accordingly.
2628 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2629 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2630 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2631 * callint.c (Fcall_interactively): Check arg count for overflow,
2632 to avoid potential buffer overrun. Use signed char, not 'int',
2633 for 'varies' array, so that we needn't bother to check its size
2634 calculation for overflow.
2635 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2636 * eval.c (apply_lambda):
2637 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2638 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2639 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2640
a1759b76
PE
2641 * callint.c (Fcall_interactively): Don't use index var as event count.
2642
d96be9fc
PE
2643 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2644 * mem-limits.h (SIZE): Remove; no longer used.
2645
a690a978 2646 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2647
578c21e6
PE
2648 Remove unnecessary casts.
2649 * xterm.c (x_term_init):
2650 * xfns.c (x_set_border_pixel):
2651 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2652 These aren't needed now that we assume ANSI C.
2653
96f53c6c
PE
2654 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2655 It's more likely to cause problems (due to unsigned overflow)
2656 than to cure them.
2657
83c77d31
PE
2658 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2659
ee2079f1
PE
2660 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2661
6da65536
PE
2662 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2663
7147c4a4
PE
2664 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2665
193e32d9
PE
2666 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2667
e5533da6
PE
2668 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2669
9910e595
PE
2670 GLYPH_CODE_FACE returns EMACS_INT, not int.
2671 * dispextern.h (merge_faces):
2672 * xfaces.c (merge_faces):
01103c44
PE
2673 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2674 Don't assume EMACS_INT fits in int.
9910e595 2675
2638320e
PE
2676 * character.h (CHAR_VALID_P): Remove unused parameter.
2677 * fontset.c, lisp.h, xdisp.c: All uses changed.
2678
045eb8d9
PE
2679 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2680
c1f134b5
PE
2681 * fns.c (concat): Minor tuning based on overflow analysis.
2682 This doesn't fix any bugs. Use int to hold character, instead
2683 of constantly refetching from Emacs object. Use XFASTINT, not
2684 XINT, for value known to be a character. Don't bother comparing
2685 a single byte to 0400, as it's always less.
2686
395fcb93 2687 * floatfns.c (Fexpt):
327eeec8
PE
2688 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2689
abbd3d23
PE
2690 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2691 for characters.
2692
684a03ef
PE
2693 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2694
0fed43f3
PE
2695 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2696 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2697 incorrectly succeed when S was a string, because 4294967386 was
2698 truncated before it was used.
2699
8fd02eb7
PE
2700 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2701 Otherwise, an out-of-range integer could cause undefined behavior
2702 on a 64-bit host.
2703
f8c86b69
PE
2704 * composite.c: Use int, not EMACS_INT, for characters.
2705 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2706 EMACS_INT, for values that are known to be in character range.
2707 This doesn't fix any bugs but is the usual style inside Emacs and
2708 may generate better code on 32-bit machines.
2709
34206dd2
PE
2710 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2711 This is for reasons similar to the recent CHAR_STRING fix.
2712 * charset.c (Fencode_char): Check that character arg is actually
2713 a character. Pass an int to ENCODE_CHAR.
2714 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2715 wider than 'int', as a compile-time check to prevent future regressions
2716 in this area.
2717
c5958d4c 2718 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2719
2720 Make sure a 64-bit char is never passed to CHAR_STRING.
2721 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2722 by silently ignoring the top 32 bits, allowing some values
2723 that were far too large to be valid characters.
2724 * character.h: Include <verify.h>.
2725 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2726 arguments are no wider than unsigned, as a compile-time check
2727 to prevent future regressions in this area.
2728 * data.c (Faset):
01103c44 2729 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2730 (Fsubst_char_in_region):
2731 * fns.c (concat):
2732 * xdisp.c (decode_mode_spec_coding):
2733 Adjust to CHAR_STRING's new requirement.
2734 * editfns.c (Finsert_char, Fsubst_char_in_region):
2735 * fns.c (concat): Check that character args are actually
2736 characters. Without this test, these functions did the wrong
2737 thing with wildly out-of-range values on 64-bit hosts.
2738
d37ca623
PE
2739 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2740 These casts should not be needed on 32-bit hosts, either.
2741 * keyboard.c (read_char):
2742 * lread.c (Fload): Remove casts to unsigned.
2743
ea204efb
PE
2744 * lisp.h (UNSIGNED_CMP): New macro.
2745 This fixes comparison bugs on 64-bit hosts.
2746 (ASCII_CHAR_P): Use it.
2747 * casefiddle.c (casify_object):
01103c44 2748 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2749 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2750 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2751 * dispextern.h (FACE_FROM_ID):
2752 * keyboard.c (read_char): Use UNSIGNED_CMP.
2753
41cb286c
PE
2754 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2755 not to EMACS_INT, to avoid GCC warning.
2756
4a1b9832
PE
2757 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2758
55daad71
PE
2759 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2760 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2761 isn't needed on 32-bit machines.
8f95c75c 2762
01103c44
PE
2763 * buffer.c (Fgenerate_new_buffer_name):
2764 Use EMACS_INT for count, not int.
0ceccced 2765 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2766
2767 * data.c (Qcompiled_function): Now static.
2768
c6f072e7
PE
2769 * window.c (window_body_lines): Now static.
2770
20ce5912
PE
2771 * image.c (gif_load): Rename local to avoid shadowing.
2772
9c4c5f81
PE
2773 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2774 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2775 * alloc.c (make_save_value): Integer argument is now of type
2776 ptrdiff_t, not int.
2777 (mark_object): Use ptrdiff_t, not int.
2778 * lisp.h (pD): New macro.
2779 * print.c (print_object): Use it.
2780
c0c5c8ae
PE
2781 * alloc.c: Use EMACS_INT, not int, to count objects.
2782 (total_conses, total_markers, total_symbols, total_vector_size)
2783 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2784 (total_free_floats, total_floats, total_free_intervals)
2785 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2786 Now EMACS_INT, not int. All uses changed.
2787 (Fgarbage_collect): Compute overall total using a double, so that
2788 integer overflow is less likely to be a problem. Check for overflow
2789 when converting back to an integer.
5a25e253
PE
2790 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2791 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2792 These were 'int' variables that could overflow on 64-bit hosts;
2793 they were never used, so remove them instead of repairing them.
211a0b2a 2794 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2795 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2796 Previously, this ceilinged at INT_MAX, but that doesn't work on
2797 64-bit machines.
e46bb31a 2798 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2799
c78baabf 2800 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2801 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2802 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2803 when a (possibly-narrower) signed value would do just as well.
2804 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2805
c9d624c6
PE
2806 * alloc.c: Catch some string size overflows that we were missing.
2807 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2808 for convenience in STRING_BYTES_MAX.
2809 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2810 The definition here is exact; the one in lisp.h was approximate.
2811 (allocate_string_data): Check for string overflow. This catches
2812 some instances we weren't catching before. Also, it catches
2813 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2814 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2815 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2816
c9d624c6
PE
2817 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2818 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2819 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2820
353032ce
PE
2821 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2822
2bccce07
PE
2823 * alloc.c (Fmake_string): Check for out-of-range init.
2824
0ac30604
SM
28252011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2826
2827 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2828
c195f2de
JD
28292011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2830
2831 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2832 xg_get_default_scrollbar_width.
2833
2834 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2835 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2836 (style_changed_cb): Call update_theme_scrollbar_width and call
2837 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2838 all frames (Bug#8505).
2839 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2840 Call gtk_window_set_resizable if HAVE_GTK3.
2841 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2842 and height if HAVE_GTK3 (Bug#8505).
2843 (scroll_bar_width_for_theme): New variable.
2844 (update_theme_scrollbar_width): New function.
2845 (xg_get_default_scrollbar_width): Move code to
2846 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2847 (xg_initialize): Call update_theme_scrollbar_width.
2848
2849 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2850
2851 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2852
e10ac9f1
MR
28532011-06-12 Martin Rudalics <rudalics@gmx.at>
2854
2855 * frame.c (make_frame): Call other_buffer_safely instead of
2856 other_buffer.
2857
2858 * window.c (temp_output_buffer_show): Call display_buffer with
2859 second argument Vtemp_buffer_show_specifiers and reset latter
2860 immediately after the call.
2861 (Vtemp_buffer_show_specifiers): New variable.
2862 (auto_window_vscroll_p, next_screen_context_lines)
2863 (Vscroll_preserve_screen_position): Remove leading asterisks from
2864 doc-strings.
2865
2d3c217e 28662011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2867
7b7f97e8 2868 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2869 * buffer.c (Qclone_number): Remove for now, as it's unused.
2870 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2871 (record_buffer): Remove unused local.
2872 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2873 (set_frame_buffer_list): Remove; unused.
2874 * frame.h (other_visible_frames): Remove decl.
2875 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2876 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2877 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2878 if HAVE_GPM.
2879 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2880 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2881 Define only if HAVE_GPM.
2882 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2883 (update_hints_inhibit): Remove; never set. All uses removed.
2884 * widgetprv.h (emacsFrameClassRec): Remove decl.
2885 * window.c (delete_deletable_window): Now returns void, since it
2886 wasn't returning anything.
2887 (compare_window_configurations): Remove unused locals.
2888 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2889 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2890 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2891 the same widths as pointers. This follows up on the 2011-05-06 patch.
2892 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2893 * xterm.h: Likewise.
2894 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2895
1384b89e
JB
28962011-06-12 Juanma Barranquero <lekktu@gmail.com>
2897
2898 * makefile.w32-in: Update dependencies.
2899 (LISP_H): Add lib/intprops.h.
2900
1100a63c
CY
29012011-06-11 Chong Yidong <cyd@stupidchicken.com>
2902
2903 * image.c (gif_load): Add animation frame delay to the metadata.
2904 (syms_of_image): Use DEFSYM. New symbol `delay'.
2905
6198ccd0
MR
29062011-06-11 Martin Rudalics <rudalics@gmx.at>
2907
2908 * window.c (delete_deletable_window): Re-add.
2909 (Fset_window_configuration): Rewrite to handle dead buffers and
2910 consequently deletable windows.
2911 (window_tree, Fwindow_tree): Remove. Supply functionality in
2912 window.el.
2913 (compare_window_configurations): Simplify code.
2914
b6e3633c
AS
29152011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2916
1ab0dee5
AS
2917 * image.c (imagemagick_load_image): Fix type mismatch.
2918 (Fimagemagick_types): Likewise.
2919
b6e3633c
AS
2920 * window.h (replace_buffer_in_windows): Declare.
2921
9397e56f
MR
29222011-06-11 Martin Rudalics <rudalics@gmx.at>
2923
2924 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2925 Qclone_number. Remove external declaration of Qdelete_window.
2926 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2927 code.
640c8776
SM
2928 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2929 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2930 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2931 buffer list implementation.
2932 (other_buffer_safely): New function.
2933 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2934 calls to replace_buffer_in_windows and
2935 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2936 if allowed.
2937 (record_buffer): Inhibit quitting and rewrite using quittable
2938 functions. Run Qbuffer_list_update_hook if allowed.
2939 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2940 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2941 Move switch-to-buffer to window.el.
9397e56f
MR
2942 (bury-buffer): Move to window.el.
2943 (Vbuffer_list_update_hook): New variable.
2944
2945 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2946 section.
2947
2948 * window.h (resize_frame_windows): Move up in code.
2949 (Fwindow_frame): Remove EXFUN.
2950 (replace_buffer_in_all_windows): Remove prototype.
2951 (replace_buffer_in_windows_safely): Add prototype.
2952
2953 * window.c: Declare Qdelete_window static again. Move down
2954 declaration of select_count.
2955 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2956 (Fother_window): Move to window.el.
2957 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2958 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2959 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2960 window.el.
2961 (replace_buffer_in_windows): Implement by calling
2962 Qreplace_buffer_in_windows.
2963 (replace_buffer_in_all_windows): Remove with some functionality
2964 moved into replace_buffer_in_windows_safely.
2965 (replace_buffer_in_windows_safely): New function.
2966 (select_window_norecord, select_frame_norecord): Move in front
2967 of run_window_configuration_change_hook. Remove now obsolete
2968 declarations.
640c8776
SM
2969 (Fset_window_buffer): Rewrite doc-string.
2970 Call Qrecord_window_buffer.
9397e56f
MR
2971 (keys_of_window): Move binding for other-window to window.el.
2972
b50691aa
CY
29732011-06-11 Chong Yidong <cyd@stupidchicken.com>
2974
2975 * dispextern.h (struct image): Replace data member, whose int_val
2976 and ptr_val fields were not used by anything, with a single
2977 lisp_val object.
2978
2979 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2980 (gif_clear_image, gif_load, imagemagick_load_image)
2981 (gs_clear_image, gs_load): Callers changed.
2982
3f754b86
PE
29832011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2984
cca69397
PE
2985 * buffer.h: Include <time.h>, for time_t.
2986 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2987
109e28d0
PE
2988 Fix minor problems found by static checking.
2989
60737f02
PE
2990 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2991
4b66faf3
PE
2992 Make identifiers static if they are not used in other modules.
2993 * data.c (Qcompiled_function, Qframe, Qvector):
2994 * image.c (QimageMagick, Qsvg):
2995 * minibuf.c (Qmetadata):
2996 * window.c (resize_window_check, resize_root_window): Now static.
2997 * window.h (resize_window_check, resize_root_window): Remove decls.
2998
109e28d0
PE
2999 * window.c (window_deletion_count, delete_deletable_window):
3000 Remove; unused.
46a4ce9e
PE
3001 (window_body_lines): Now static.
3002 (Fdelete_other_windows_internal): Mark vars as initialized.
3003 Make sure 'resize_failed' is initialized.
3004 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3005 (resize_window_apply): Remove unused local.
3006 * window.h (delete_deletable_window): Remove decl.
3007
109e28d0 3008 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3009 (imagemagick_load_image): Fix pointer signedness problem by changing
3010 last arg from unsigned char * to char *. All uses changed.
3011 Also, fix a local for similar reasons.
3012 Remove unused locals. Remove locals to avoid shadowing.
3013 (fn_rsvg_handle_free): Remove; unused.
3014 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3015 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3016
3f754b86
PE
3017 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3018
2547adb1
CY
30192011-06-10 Chong Yidong <cyd@stupidchicken.com>
3020
3021 * image.c (gif_load): Fix omitted cast error introduced by
3022 2011-06-06 change.
3023
2c8e37d4
MR
30242011-06-10 Martin Rudalics <rudalics@gmx.at>
3025
3026 * window.h (resize_proportionally, orig_total_lines)
3027 (orig_top_line): Remove from window structure.
3028 (set_window_height, set_window_width, change_window_heights)
3029 (Fdelete_window): Remove prototypes.
3030 (resize_frame_windows): Remove duplicate declaration.
3031
440a42e3
EZ
30322011-06-10 Eli Zaretskii <eliz@gnu.org>
3033
3034 * window.h (resize_frame_windows, resize_window_check)
3035 (delete_deletable_window, resize_root_window)
3036 (resize_frame_windows): Declare prototypes.
3037
3038 * window.c (resize_window_apply): Make definition be "static" to
3039 match the prototype.
3040
562dd5e9
MR
30412011-06-10 Martin Rudalics <rudalics@gmx.at>
3042
3043 * window.c: Remove declarations of Qwindow_size_fixed,
3044 window_min_size_1, window_min_size_2, window_min_size,
3045 size_window, window_fixed_size_p, enlarge_window, delete_window.
3046 Remove static from declaration of Qdelete_window, it's
3047 temporarily needed by Fbury_buffer.
3048 (replace_window): Don't assign orig_top_line and
3049 orig_total_lines.
3050 (Fdelete_window, delete_window): Remove. Window deletion is
3051 handled by window.el.
640c8776
SM
3052 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3053 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3054 (Fdelete_other_windows): Remove. Deleting other windows is
3055 handled by window.el.
3056 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3057 handled in window.el.
3058 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3059 Window minimum sizes are handled in window.el.
3060 (shrink_windows, size_window, set_window_height)
3061 (set_window_width, change_window_heights, window_height)
3062 (window_width, CURBEG, CURSIZE, enlarge_window)
3063 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3064 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3065 handled in window.el.
3066 (make_dummy_parent): Rename to make_parent_window and give it a
3067 second argument horflag.
3068 (make_window): Don't set resize_proportionally any more.
3069 (Fsplit_window): Remove. Windows are split in window.el.
3070 (save_restore_action, save_restore_orig_size)
3071 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3072 Resize mini windows in window.el.
3073 (grow_mini_window, shrink_mini_window): Implement by calling
3074 Qresize_root_window_vertically, resize_window_check and
3075 resize_window_apply.
640c8776
SM
3076 (saved_window, Fset_window_configuration, save_window_save):
3077 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3078 resize_proportionally.
3079 (window_min_height, window_min_width): Move to window.el.
3080 (keys_of_window): Move bindings for delete-other-windows,
3081 split-window, delete-window and enlarge-window to window.el.
3082
3083 * buffer.c: Temporarily extern Qdelete_window.
3084 (Fbury_buffer): Temporarily call Qdelete_window instead of
3085 Fdelete_window (Fbury_buffer will move to window.el soon).
3086
3087 * frame.c (set_menu_bar_lines_1): Remove code handling
3088 orig_top_line and orig_total_lines.
3089
3090 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3091 set_window_height but set heights directly.
3092 (change_frame_size_1): Use resize_frame_windows.
3093
3094 * xdisp.c (init_xdisp): Don't use set_window_height but set
3095 heights directly.
3096
640c8776
SM
3097 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3098 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3099 run_window_configuration_change_hook.
3100
3101 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3102 instead of change_window_heights and run
3103 run_window_configuration_change_hook.
3104
1a13852e
MR
31052011-06-09 Martin Rudalics <rudalics@gmx.at>
3106
3107 * window.c (replace_window): Rename second argument REPLACEMENT to
3108 NEW. New third argument SETFLAG. Rewrite.
3109 (delete_window, make_dummy_parent): Call replace_window with
3110 third argument 1.
3111 (window_list_1): Move down in code.
3112 (run_window_configuration_change_hook): Move set_buffer part
3113 before select_frame_norecord part in order to unwind correctly.
3114 Rename count1 to count.
3115 (recombine_windows, delete_deletable_window, resize_root_window)
3116 (Fdelete_other_windows_internal)
3117 (Frun_window_configuration_change_hook, make_parent_window)
3118 (resize_window_check, resize_window_apply, Fresize_window_apply)
3119 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3120 (Fdelete_window_internal, Fresize_mini_window_internal):
3121 New functions.
1a13852e
MR
3122 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3123
f3d1777e
MR
31242011-06-08 Martin Rudalics <rudalics@gmx.at>
3125
496e208e
MR
3126 * window.h (window): Add some new members to window structure -
3127 normal_lines, normal_cols, new_total, new_normal, clone_number,
3128 splits, nest, prev_buffers, next_buffers.
3129 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3130 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3131
f3d1777e
MR
3132 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3133 Remove.
496e208e
MR
3134 (make_dummy_parent): Set new members of windows structure.
3135 (make_window): Move down in code. Handle new members of window
3136 structure.
3137 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3138 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3139 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3140 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3141 (Fset_window_next_buffers, Fset_window_clone_number):
3142 New functions.
496e208e
MR
3143 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3144 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3145 Doc-string fixes.
3146 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3147 Argument WINDOW can be now internal window too.
3148 (Fwindow_use_time): Move up in code.
3149 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3150 Rewrite doc-string.
3151 (Fset_window_configuration, saved_window)
3152 (Fcurrent_window_configuration, save_window_save): Handle new
3153 members of window structure.
b9e809c2
MR
3154 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3155 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3156 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3157 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3158 Qget_mru_window, Qresize_root_window,
3159 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3160 Qauto_buffer_name; staticpro them.
f3d1777e 3161
abde8f8c
MR
31622011-06-07 Martin Rudalics <rudalics@gmx.at>
3163
3164 * window.c (Fwindow_total_size, Fwindow_left_column)
3165 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3166 (Fwindow_list_1): New functions.
3167 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3168 (Fwindow_width, Fscroll_left, Fscroll_right):
3169 Use window_body_cols instead of window_box_text_cols.
3170 (delete_window, Fset_window_configuration):
3171 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3172 (delete_all_subwindows): Take a window as argument and not a
3173 structure. Rewrite.
190b47e6
MR
3174 (window_loop): Remove handling of GET_LRU_WINDOW and
3175 GET_LARGEST_WINDOW.
3176 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3177
3178 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3179 window_box_text_cols. delete_all_subwindows now takes a
3180 Lisp_Object as argument.
abde8f8c 3181
640c8776
SM
3182 * indent.c (compute_motion, Fcompute_motion):
3183 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3184
fa8a67e6
MR
3185 * frame.c (delete_frame): Call delete_all_subwindows with root
3186 window as argument.
3187
a54e3482
DC
31882011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3189
3190 * fns.c (Fputhash): Document return value.
3191
60002bf5
CY
31922011-06-06 Chong Yidong <cyd@stupidchicken.com>
3193
3194 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3195
0c671da6 31962011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3197
b862a52a 3198 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3199
be44ca6c
PE
3200 Check for overflow when converting integer to cons and back.
3201 * charset.c (Fdefine_charset_internal, Fdecode_char):
3202 Use cons_to_unsigned to catch overflow.
3203 (Fencode_char): Use INTEGER_TO_CONS.
3204 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3205 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3206 * data.c (long_to_cons, cons_to_long): Remove.
3207 (cons_to_unsigned, cons_to_signed): New functions.
3208 These signal an error for invalid or out-of-range values.
3209 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3210 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3211 * font.c (Ffont_variation_glyphs):
3212 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3213 * lisp.h: Include <intprops.h>.
3214 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3215 (cons_to_signed, cons_to_unsigned): New decls.
3216 (long_to_cons, cons_to_long): Remove decls.
3217 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3218 (Fprimitive_undo): Use CONS_TO_INTEGER.
3219 * xfns.c (Fx_window_property): Likewise.
3220 * xselect.c: Include <limits.h>.
3221 (x_own_selection, selection_data_to_lisp_data):
3222 Use INTEGER_TO_CONS.
3223 (x_handle_selection_request, x_handle_selection_clear)
3224 (x_get_foreign_selection, Fx_disown_selection_internal)
3225 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3226 (lisp_data_to_selection_data): Use cons_to_unsigned.
3227 (x_fill_property_data): Use cons_to_signed.
3228 Report values out of range.
3229
d1f3d2af
PE
3230 Check for buffer and string overflow more precisely.
3231 * buffer.h (BUF_BYTES_MAX): New macro.
3232 * lisp.h (STRING_BYTES_MAX): New macro.
3233 * alloc.c (Fmake_string):
3234 * character.c (string_escape_byte8):
3235 * coding.c (coding_alloc_by_realloc):
3236 * doprnt.c (doprnt):
3237 * editfns.c (Fformat):
3238 * eval.c (verror):
3239 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3240 since they may not be the same number.
3241 * editfns.c (Finsert_char):
3242 * fileio.c (Finsert_file_contents):
3243 Likewise for BUF_BYTES_MAX.
3244
dd52fcea
PE
3245 * image.c: Use ptrdiff_t, not int, for sizes.
3246 (slurp_file): Switch from int to ptrdiff_t.
3247 All uses changed.
3248 (slurp_file): Check that file size fits in both size_t (for
3249 malloc) and ptrdiff_t (for sanity and safety).
3250
7f9bbdbb
PE
3251 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3252 if b->modtime has its maximal value.
3253
dfe18f82
PE
3254 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3255
84acfcf0
PE
3256 Don't assume time_t can fit into int.
3257 * buffer.h (struct buffer.modtime): Now time_t, not int.
3258 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3259 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3260
ccd9a01a
PE
3261 Minor fixes for signed vs unsigned integers.
3262 * character.h (MAYBE_UNIFY_CHAR):
3263 * charset.c (maybe_unify_char):
3264 * keyboard.c (read_char, reorder_modifiers):
3265 XINT -> XFASTINT, since the integer must be nonnegative.
3266 * ftfont.c (ftfont_spec_pattern):
3267 * keymap.c (access_keymap, silly_event_symbol_error):
3268 XUINT -> XFASTINT, since the integer must be nonnegative.
3269 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3270 since it makes no difference and we prefer signed.
3271 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3272 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3273 nonnegative.
3274
d6d100dd
SM
32752011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3276
3277 * window.h (Fwindow_frame): Declare.
3278
2b6148e4
PE
32792011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3280
3281 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3282 (SPARE_MEMORY): Always define.
3283 (LARGE_REQUEST): Remove.
3284 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3285
f230ecc9
MR
32862011-06-06 Martin Rudalics <rudalics@gmx.at>
3287
727e958e
MR
3288 * lisp.h: Move EXFUNS for Fframe_root_window,
3289 Fframe_first_window and Fset_frame_selected_window to window.h.
3290
3291 * window.h: Move EXFUNS for Fframe_root_window,
3292 Fframe_first_window and Fset_frame_selected_window here from
3293 lisp.h.
3294
3295 * frame.c (Fwindow_frame, Fframe_first_window)
3296 (Fframe_root_window, Fframe_selected_window)
3297 (Fset_frame_selected_window): Move to window.c.
3298 (Factive_minibuffer_window): Move to minibuf.c.
3299 (Fother_visible_frames_p): New function.
3300
3301 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3302
f230ecc9
MR
3303 * window.c (decode_window, decode_any_window): Move up in code.
3304 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3305 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3306 (Fwindow_buffer): Move up and rewrite doc-string.
3307 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3308 (Fwindow_prev): New functions.
727e958e
MR
3309 (Fwindow_frame): Move here from frame.c. Accept any window as
3310 argument.
3311 (Fframe_root_window, Fframe_first_window)
3312 (Fframe_selected_window): Move here from frame.c. Accept frame
3313 or arbitrary window as argument. Update doc-strings.
3314 (Fminibuffer_window): Move up in code.
3315 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3316 (Fset_frame_selected_window): Move here from frame.c.
3317 Marginal rewrite.
727e958e
MR
3318 (Fselected_window, select_window, Fselect_window): Move up in
3319 code. Minor doc-string fixes.
f230ecc9 3320
4d09bcf6
PE
33212011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3322
3323 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3324 Do not assume that spare memory exists; that assumption is valid
3325 only if SYSTEM_MALLOC.
3326 (LARGE_REQUEST): New macro, so that the issue of large requests
3327 is separated from the issue of spare memory.
3328
810928a2
AS
33292011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3330
172418ad
AS
3331 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3332 format. (Bug#8806)
3333
43f862f7
AS
3334 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3335
810928a2
AS
3336 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3337 before statements.
3338
a059fe24
JD
33392011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3340
3341 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3342
3343 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3344
3345 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3346 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3347
989bf368
JB
33482011-06-05 Juanma Barranquero <lekktu@gmail.com>
3349
3350 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3351
4b80f674
CY
33522011-06-04 Chong Yidong <cyd@stupidchicken.com>
3353
3354 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3355 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3356 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3357 New error handlers.
4b80f674
CY
3358 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3359 Obey Vx_select_enable_clipboard_manager. Catch errors in
3360 x_clipboard_manager_save (Bug#8779).
3361 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3362 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3363
99a33b77 33642011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3365
3366 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3367
99a33b77 33682011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3369
3370 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3371 in the current matrix if keep_current_p is non-zero.
3372
8264569d
EZ
33732011-06-04 Eli Zaretskii <eliz@gnu.org>
3374
3375 * bidi.c (bidi_level_of_next_char): Fix last change.
3376
57f97249
EZ
33772011-06-03 Eli Zaretskii <eliz@gnu.org>
3378
fec2107c 3379 Support bidi reordering of text covered by display properties.
57f97249 3380
fec2107c
EZ
3381 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3382 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3383 (bidi_cache_search, bidi_cache_iterator_state)
3384 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3385 (bidi_level_of_next_char, bidi_move_to_visually_next):
3386 Support character positions inside a run of characters covered by a
fec2107c
EZ
3387 display string.
3388 (bidi_paragraph_init, bidi_resolve_explicit_1)
3389 (bidi_level_of_next_char): Call bidi_fetch_char and
3390 bidi_fetch_char_advance instead of FETCH_CHAR and
3391 FETCH_CHAR_ADVANCE.
3392 (bidi_init_it): Initialize new members.
3393 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3394 definitions.
3395 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3396 instead of using explicit *_CHAR codes.
d6d100dd
SM
3397 (bidi_resolve_explicit, bidi_resolve_weak):
3398 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3399 bidirectional text is supported only in multibyte buffers.
3400 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3401 it to initialize the frame_window_p member of struct bidi_it.
3402 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3403 (bidi_resolve_explicit, bidi_resolve_weak)
3404 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3405 bidi_it->nchars is non-positive.
3406 (bidi_level_of_next_char): Don't try to lookup the cache for the
3407 next/previous character if nothing is cached there yet, or if we
3408 were just reseat()'ed to a new position.
c40e2fb2 3409
0e14fe90
EZ
3410 * xdisp.c (set_cursor_from_row): Set start and stop points
3411 according to the row's direction when priming the loop that looks
3412 for the glyph on which to display cursor.
3413 (single_display_spec_intangible_p): Function deleted.
3414 (display_prop_intangible_p): Reimplement to call
3415 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3416 Accept 3 additional arguments needed by handle_display_spec.
3417 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3418 values: lists, `(when COND...)' forms, etc.
3419 (single_display_spec_string_p): Support property values that are
3420 lists with the argument STRING its top-level element.
3421 (display_prop_string_p): Fix the condition for processing a
3422 property that is a list to be consistent with handle_display_spec.
fec2107c 3423 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3424 last portion of handle_display_prop.
3425 (compute_display_string_pos): Accept additional argument
3426 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3427 value of a `display' property is a "replacing spec".
3428 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3429 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3430 the display property, but just return a value indicating whether
3431 the display property will replace the characters it covers.
3432 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3433 frame_window_p members of struct bidi_it.
d6d100dd
SM
3434 (compute_display_string_pos, compute_display_string_end):
3435 New functions.
fec2107c
EZ
3436 (push_it): Accept second argument POSITION, where pop_it should
3437 jump to continue iteration.
3438 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3439
fec2107c
EZ
3440 * keyboard.c (adjust_point_for_property): Adjust the call to
3441 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3442
3443 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3444 (bidi_init_it): Update prototypes.
3445 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3446 (compute_display_string_pos, compute_display_string_end):
3447 Declare prototypes.
fec2107c
EZ
3448 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3449 EMACS_INT.
fc6f18ce 3450
40087514 34512011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3452
57f53182
PE
3453 Malloc failure behavior now depends on size of allocation.
3454 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3455 * lisp.h: Change signatures accordingly.
3456 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3457 All callers changed. (Bug#8762)
3458
3459 * gnutls.c: Use Emacs's memory allocators.
3460 Without this change, the gnutls library would invoke malloc etc.
3461 directly, which causes problems on non-SYNC_INPUT hosts, and which
3462 runs afoul of improving memory_full behavior. (Bug#8761)
3463 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3464 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3465 xfree instead of the default malloc, realloc, free.
3466 (Fgnutls_boot): No need to check for memory allocation failure,
3467 since xmalloc does that for us.
3468
ac32cd99 3469 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3470 * category.c (hash_get_category_set):
3471 * ccl.c (ccl_driver):
3472 * charset.c (Fdefine_charset_internal):
3473 * charset.h (struct charset.hash_index):
3474 * composite.c (get_composition_id, gstring_lookup_cache)
3475 (composition_gstring_put_cache):
3476 * composite.h (struct composition.hash_index):
3477 * dispextern.h (struct image.hash):
3478 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3479 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3480 (hashfn_equal, hashfn_user_defined, make_hash_table)
3481 (maybe_resize_hash_table, hash_lookup, hash_put)
3482 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3483 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3484 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3485 * image.c (make_image, search_image_cache, lookup_image)
3486 (xpm_put_color_table_h):
3487 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3488 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3489 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3490 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3491 * alloc.c (allocate_vectorlike):
3492 Check for overflow in vector size calculations.
3493 * ccl.c (ccl_driver):
3494 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3495 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3496 need to be updated by these changes.
40087514
PE
3497 * fns.c (make_hash_table, maybe_resize_hash_table):
3498 Check for integer overflow with large hash tables.
0de4bb68
PE
3499 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3500 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3501 (SXHASH_REDUCE): New macro.
3502 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3503 Use it instead of discarding useful hash info with large hash values.
3504 (sxhash_float): New function.
3505 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3506 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3507 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3508 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3509 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3510 Adjust signatures to match updated version of code.
3511 (consing_since_gc): Now EMACS_INT, since a single hash table can
3512 use more than INT_MAX bytes.
3513
698d32e2
DN
35142011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3515
3516 Make it possible to build with GCC-4.6+ -O2 -flto.
3517
3518 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3519
fd6fa53f
SM
35202011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3523 Call minibuffer-inactive-mode.
3524
864db017
JB
35252011-05-31 Juanma Barranquero <lekktu@gmail.com>
3526
3527 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3528 Update dependencies.
3529
2ad0baf4
DN
35302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3531
3532 * data.c (init_data): Remove code for UTS, this system is not
3533 supported anymore.
3534
4fcc2638
DN
35352011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3536
3537 Don't force ./temacs to start in terminal mode.
3538
3539 * frame.c (make_initial_frame): Initialize faces in all cases, not
3540 only when CANNOT_DUMP is defined.
3541 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3542
c56e0fd5
DN
35432011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3544
3545 * dispnew.c (add_window_display_history): Use const for the string
3546 pointer. Remove declaration, not needed.
3547
333d54da 35482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3549
55d4c1b2 3550 Use 'inline', not 'INLINE'.
333d54da 3551 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3552 * alloc.c, fontset.c (INLINE): Remove.
3553 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3554 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3555 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3556 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3557 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3558
738db178
DN
35592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3560
3561 Make it possible to run ./temacs.
3562
3563 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3564 syms_of_callproc does the same thing. Remove test for
3565 "initialized", do it in the caller.
3566 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3567
620c53a6
SM
35682011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3569
3570 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3571 (read_minibuf): Use get_minibuffer.
3572 (syms_of_minibuf): Use DEFSYM.
3573 (Qmetadata): New var.
3574 * data.c (Qbuffer): Don't make it static.
3575 (syms_of_data): Use DEFSYM.
3576
e003a292
PE
35772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3578
3579 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3580 (CCL_CODE_MIN): New macro.
3581
ed008a6d
PE
35822011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3583
3687c2ef
PE
3584 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3585
ed008a6d
PE
3586 * eval.c (Qdebug): Now static.
3587 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3588 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3589 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3590
d66c4c7c
CY
35912011-05-29 Chong Yidong <cyd@stupidchicken.com>
3592
3593 * image.c: Various fixes to ImageMagick code comments.
3594 (Fimagemagick_types): Doc fix.
3595
5fbc2025
PE
35962011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3597
0196f88a
PE
3598 Minor fixes prompted by GCC 4.6.0 warnings.
3599
3600 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3601
5fbc2025
PE
3602 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3603 (x_clipboard_manager_save_all): Move extern decl to ...
3604 * xterm.h: ... here, so that it can be checked for consistency.
3605
1dd3c2d9
CY
36062011-05-29 Chong Yidong <cyd@stupidchicken.com>
3607
3608 * xselect.c (x_clipboard_manager_save_frame)
3609 (x_clipboard_manager_save_all): New functions.
3610 (Fx_clipboard_manager_save): Lisp function deleted.
3611
3612 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3613 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3614
3615 * xterm.h: Update prototype.
3616
5ba6571d
WX
36172011-05-28 William Xu <william.xwl@gmail.com>
3618
3619 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3620 exiting (Bug#8239).
3621
3eaff834
JM
36222011-05-28 Jim Meyering <meyering@redhat.com>
3623
e1900994 3624 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3625 * fns.c (to_uchar): Define.
3626 (crypto_hash_function): Use it to convert some newly-signed
3627 variables to unsigned, to avoid sign-extension bugs. For example,
3628 without this change, (md5 "truc") would evaluate to
3629 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3630 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3631 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3632
0f6990a7
PE
36332011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 Integer overflow fixes.
c8a9ca5a 3636
08686060
PE
3637 * dbusbind.c: Serial number integer overflow fixes.
3638 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3639 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3640 to hold a serial number that is too large for a fixnum.
3641 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3642 Check for serial numbers out of range. Decode any serial number
59568bf0 3643 that was so large that it became a float. (Bug#8722)
08686060 3644
2d1fc3c7
PE
3645 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3646 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3647 Use XFASTINT rather than XUINT when numbers are nonnegative.
3648 (xd_append_arg, Fdbus_method_return_internal):
3649 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3650 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3651 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3652 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3653 (Bug#8722)
2d1fc3c7 3654
c8a9ca5a
PE
3655 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3656
519e1d69
PE
3657 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3658
30569699
PE
3659 ccl: add integer overflow checks
3660 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3661 (IN_INT_RANGE): New macros.
3662 (ccl_driver): Use them to check for integer overflow when
3663 decoding a CCL program. Many of the new checks are whether XINT (x)
3664 fits in int; it doesn't always, on 64-bit hosts. The new version
3665 doesn't catch all possible integer overflows, but it's an
847044ea 3666 improvement. (Bug#8719)
30569699 3667
c11285dc
PE
3668 * alloc.c (make_event_array): Use XINT, not XUINT.
3669 There's no need for unsigned here.
3670
fdccd48e
PE
3671 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3672 This follows up to the 2011-05-06 change that substituted uintptr_t
3673 for EMACS_INT. This case wasn't caught back then.
3674
37910ab2
PE
3675 Rework Fformat to avoid integer overflow issues.
3676 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3677 now (part of C89). Include <verify.h>.
3678 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3679 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3680 (Fformat): Avoid the prepass trying to compute sizes; it was only
3681 approximate and thus did not catch overflow reliably. Instead, walk
3682 through the format just once, formatting and computing sizes as we go,
3683 checking for integer overflow at every step, and allocating a larger
3684 buffer as needed. Keep track separately whether the format is
3685 multibyte. Keep only the most-recently calculated precision, rather
3686 than them all. Record whether each argument has been converted to
3687 string. Use EMACS_INT, not int, for byte and char and arg counts.
3688 Support field widths and precisions larger than INT_MAX. Avoid
3689 sprintf's undefined behavior with conversion specifications such as %#d
3690 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3691 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3692 formatting out-of-range floating point numbers with int
9173deec 3693 formats. (Bug#8668)
37910ab2 3694
2e6578fb
PE
3695 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3696
0ae6bdee
PE
3697 * data.c: Avoid integer truncation in expressions involving floats.
3698 * data.c: Include <intprops.h>.
3699 (arith_driver): When there's an integer overflow in an expression
3700 involving floating point, convert the integers to floating point
3701 so that the resulting value does not suffer from catastrophic
3702 integer truncation. For example, on a 64-bit host (* 4
3703 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3704 Do not rely on undefined behavior after integer overflow.
3705
de883a70
PE
3706 merge count_size_as_multibyte, parse_str_to_multibyte
3707 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3708 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3709 Check for integer overflow.
3710 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3711 since it's now a duplicate of the other. This is more of
3712 a character than a buffer op, so better that it's in character.c.
3713 * fns.c, print.c: Adjust to above changes.
3714
2ff916cb
PE
37152011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3716
3717 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3718
f1b54466
PE
37192011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3720
fb1ac845
PE
3721 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3722 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3723 (x_clipboard_manager_save): Now static.
3724 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3725
f1b54466
PE
3726 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3727 (crypto_hash_function): Now static.
3728 Fix pointer signedness problems. Avoid unnecessary initializations.
3729
a9f737ee
CY
37302011-05-27 Chong Yidong <cyd@stupidchicken.com>
3731
3732 * termhooks.h (Vselection_alist): Make it terminal-local.
3733
3734 * terminal.c (create_terminal): Initialize it.
3735
3736 * xselect.c: Support for clipboard managers.
3737 (Vselection_alist): Move to termhooks.h as terminal-local var.
3738 (LOCAL_SELECTION): New macro.
3739 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3740 (symbol_to_x_atom): Remove gratuitous arg.
3741 (x_handle_selection_request, lisp_data_to_selection_data)
3742 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3743 (x_own_selection, x_get_local_selection, x_convert_selection):
3744 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3745 (some_frame_on_display): Delete unused function.
3746 (Fx_own_selection_internal, Fx_get_selection_internal)
3747 (Fx_disown_selection_internal, Fx_selection_owner_p)
3748 (Fx_selection_exists_p): New optional frame arg.
3749 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3750 (x_handle_selection_clear): Don't treat other terminals with the
3751 same keyboard specially. Use the terminal-local Vselection_alist.
3752 (x_clear_frame_selections): Use Frun_hook_with_args.
3753
3754 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3755
3756 * xterm.h: Add support for those atoms.
3757
e067f0c1
CY
37582011-05-26 Chong Yidong <cyd@stupidchicken.com>
3759
3760 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3761 (converted_selections, conversion_fail_tag): New global variables.
3762 (x_selection_request_lisp_error): Free the above.
3763 (x_get_local_selection): Remove unnecessary code.
3764 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3765 of converted selections stored in converted_selections.
3766 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3767 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3768 (x_convert_selection): New function.
3769 (x_handle_selection_event): Simplify.
3770 (x_get_foreign_selection): Don't ignore incoming requests while
3771 waiting for an answer; this will fail when we implement
3772 SAVE_TARGETS, and seems unnecessary anyway.
3773 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3774 (Vx_sent_selection_functions): Doc fix.
3775
0f4aebc0
LL
37762011-05-26 Leo Liu <sdl.web@gmail.com>
3777
3778 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3779
e61124cd
YM
37802011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3781
3782 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3783
3784 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3785 for fringe update if it has periodic bitmap.
ac389d0c 3786 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3787 and fringe_bitmap_periodic_p.
3788
3789 * fringe.c (get_fringe_bitmap_data): New function.
3790 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3791 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3792 row. Mark glyph row for fringe update if periodicity changed.
3793
3794 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3795 for fringe update unless it has periodic bitmap.
3796
f16d9837
KH
37972011-05-25 Kenichi Handa <handa@m17n.org>
3798
3799 * xdisp.c (get_next_display_element): Set correct it->face_id for
3800 a static composition.
3801
e1b90ef6
LL
38022011-05-24 Leo Liu <sdl.web@gmail.com>
3803
3804 * deps.mk (fns.o):
3805 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3806
3807 * fns.c (crypto_hash_function, Fsha1): New function.
3808 (Fmd5): Use crypto_hash_function.
3809 (syms_of_fns): Add Ssha1.
3810
7400048f
PE
38112011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3812
3813 * gnutls.c: Remove unused macros.
3814 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3815 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3816 Remove macros that are defined and never used.
3817 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3818
abb71cf4
CY
38192011-05-22 Chong Yidong <cyd@stupidchicken.com>
3820
3821 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3822 (Fx_get_selection_internal): Minor cleanup.
3823 (Fx_own_selection_internal): Rename arguments for consistency with
3824 select.el.
3825
6307db39
PE
38262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3829
f3d4e0a4
CY
38302011-05-22 Chong Yidong <cyd@stupidchicken.com>
3831
3832 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3833
4d8ade89
YM
38342011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3835
3836 * dispnew.c (scrolling_window): Don't exclude the case that the
3837 last enabled row in the desired matrix touches the bottom boundary.
3838
32078c8d
GM
38392011-05-21 Glenn Morris <rgm@gnu.org>
3840
3841 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3842 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3843 and add some more files.
32078c8d 3844
7285dc67
EZ
38452011-05-20 Eli Zaretskii <eliz@gnu.org>
3846
3847 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3848 report_file_error introduced by the change from 2011-05-07.
3849
89d1bd22
PE
38502011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3851
3852 * systime.h (Time): Define only if emacs is defined.
3853 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3854 where the include path doesn't have X11/X.h by default. See
3855 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3856
e23640bb 38572011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3858
3859 * composite.c (find_automatic_composition): Fix previous change.
3860
b9704ad9
GM
38612011-05-20 Glenn Morris <rgm@gnu.org>
3862
3863 * lisp.mk: New file, split from Makefile.in.
3864 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3865 (shortlisp): Remove.
3866 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3867
4a720484
GM
38682011-05-19 Glenn Morris <rgm@gnu.org>
3869
3870 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3871 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3872 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3873 (lisp): Set the order to that of loadup.el.
3874 (shortlisp): Make it a copy of $lisp.
3875 (SOME_MACHINE_LISP): Remove.
3876 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3877 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3878
a28d4396
KH
38792011-05-18 Kenichi Handa <handa@m17n.org>
3880
3881 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3882 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3883 (find_automatic_composition): Mostly rewrite for efficiency.
3884
a2b1fa8e
JB
38852011-05-18 Juanma Barranquero <lekktu@gmail.com>
3886
3887 * makefile.w32-in: Update dependencies.
3888
8e1f5610
CS
38892011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3890
3891 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3892 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3893
7025ee00 38942011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3895
cdfa6eab
PE
3896 Fix some integer overflow issues, such as string length overflow.
3897
06d6db33
PE
3898 * insdel.c (count_size_as_multibyte): Check for string overflow.
3899
2b4560a8
PE
3900 * character.c (lisp_string_width): Check for string overflow.
3901 Use EMACS_INT, not int, for string indexes and lengths; in
3902 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3903 the resulting string length overflows an EMACS_INT; instead,
3904 report a string overflow if no precision given. When checking for
3905 precision exhaustion, use a check that cannot possibly have
3906 integer overflow. (Bug#8675)
3907 * character.h (lisp_string_width): Adjust to new signature.
3908
cb93f9be
PE
3909 * alloc.c (string_overflow): New function.
3910 (Fmake_string): Use it. This doesn't change behavior, but saves
3911 a few bytes and will simplify future changes.
3912 * character.c (string_escape_byte8): Likewise.
3913 * lisp.h (string_overflow): New decl.
3914
1a1f3366
PE
3915 Fixups, following up to the user-interface timestamp change.
3916 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3917 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3918 * msdos.c (mouse_get_pos): Likewise.
3919 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3920 * w32gui.h (Time): Define by including "systime.h" rather than by
3921 declaring it ourselves. (Bug#8664)
3922
d4e3e4d3
PE
3923 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3924 * image.c (clear_image_cache): Likewise.
3925
f6a24d19
PE
3926 * term.c (term_mouse_position): Don't assume time_t wraparound.
3927
08dc5ae6
PE
3928 Be more systematic about user-interface timestamps.
3929 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3930 and sometimes 'EMACS_UINT', to represent these timestamps.
3931 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3932 This makes the code easier to follow, and makes it easier to catch
3933 integer overflow bugs such as Bug#8664.
3934 * frame.c (Fmouse_position, Fmouse_pixel_position):
3935 Use Time, not unsigned long, for user-interface timestamps.
3936 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3937 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3938 * keyboard.h (last_event_timestamp): Likewise.
3939 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3940 * menu.h (xmenu_show): Likewise.
3941 * term.c (term_mouse_position): Likewise.
3942 * termhooks.h (struct input_event.timestamp): Likewise.
3943 (struct terminal.mouse_position_hook): Likewise.
3944 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3945 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3946 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3947 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3948 what it was before.
3949 * menu.h, termhooks.h: Include "systime.h", for Time.
3950
8e55734a
PE
3951 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3952 Don't assume that the difference between two unsigned long values
3953 can fit into an integer. At this point, we know button_down_time
3954 <= event->timestamp, so the difference must be nonnegative, so
3955 there's no need to cast the result if double-click-time is
3956 nonnegative, as it should be; check that it's nonnegative, just in
3957 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3958 apart (about 25 days). (Bug#8664)
8e55734a 3959
841f1b75 3960 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3961 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3962
3e26f69c
PE
3963 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3964 that always fit in int. Use a sentinel instead of a counter, to
3965 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3966 * frame.h (struct frame): Use int for menu_bar_items_used
3967 instead of EMACS_INT, since it always fits in int.
3e26f69c 3968
5cc152c0
PE
3969 * menu.c (grow_menu_items): Check for int overflow.
3970
d89eb65e
PE
3971 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3972
5235bd3e
PE
3973 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3974 Before, the code was not consistent. These values cannot exceed
3975 2**31 - 1 so there's no need to make them unsigned.
3976 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3977 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3978 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3979 as modifiers.
3980 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3981
bc827e23
PE
3982 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3983 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3984 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3985 presumably because the widths might not match.
3986
78eb494e
PE
3987 * window.c (size_window): Avoid needless test at loop start.
3988
04f2d78b
CB
39892011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3990
3991 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3992
d2fc7e3d 39932011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3994
3995 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3996
d2fc7e3d 39972011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3998
3999 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4000 `width' to `bar_area_x' and `bar_area_width', respectively.
4001 (x_scroll_run): Take account of fringe background extension.
4002
04f2d78b
CB
4003 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4004 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4005 `bar_area_width', respectively.
4006 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4007 background extension.
4008
79b70037
GM
40092011-05-10 Jim Meyering <meyering@redhat.com>
4010
4011 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4012
2f142cc5
JB
40132011-05-10 Juanma Barranquero <lekktu@gmail.com>
4014
4015 * image.c (Finit_image_library): Return t for built-in image types,
4016 like pbm and xbm. (Bug#8640)
4017
57679c86
AS
40182011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4019
4020 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4021
888c9e86
EZ
40222011-05-07 Eli Zaretskii <eliz@gnu.org>
4023
b0512a1d
EZ
4024 * w32console.c (Fset_screen_color): Doc fix.
4025 (Fget_screen_color): New function.
4026 (syms_of_ntterm): Defsubr it.
4027
7285dc67
EZ
4028 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4029 unlink the temporary file if Fcall_process didn't create it in the
4030 first place.
4031 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4032 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4033 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4034 cue to call_process_cleanup not to close that handle.
4035
4d3fcc8e
BK
40362011-05-07 Ben Key <bkey76@gmail.com>
4037
4038 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4039 one of two shell specific rules, either bootstrap-temacs-CMD or
4040 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4041 to the previous implementation of the bootstrap-temacs rule.
4042 The bootstrap-temacs-CMD rule is similar to the previous
4043 implementation of the bootstrap-temacs rule except that it
4044 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4045 variable.
4046
4047 These changes, along with some changes to nt/configure.bat,
4048 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4049 earlier fix to add support for --cflags and --ldflags options
4050 that include quotes so that it works whether make uses cmd or
4051 sh as the shell.
4052
b4289b64
MA
40532011-05-06 Michael Albinus <michael.albinus@gmx.de>
4054
4055 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4056 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4057 is a constant.
4058 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4059 a string. Handle both cases.
4060 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4061 (Fdbus_register_method): Use Qinvalid_function.
4062
af4c0e28
JB
40632011-05-06 Juanma Barranquero <lekktu@gmail.com>
4064
4065 * makefile.w32-in: Update dependencies.
4066 (LISP_H): Add inttypes.h and stdin.h.
4067 (PROCESS_H): Add unistd.h.
4068
c51453d9
EZ
40692011-05-06 Eli Zaretskii <eliz@gnu.org>
4070
4071 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4072 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4073
8ff0ac3c 40742011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4075
4c4b566b
PE
4076 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4077
aab2b9b5
PE
4078 * term.c (vfatal): Remove stray call to va_end.
4079 It's not needed and the C Standard doesn't allow it here anyway.
4080
c378da0b
PE
4081 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4082 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4083
288b08c7
PE
4084 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4085 bytes.
4086
e3601888
PE
4087 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4088
db6c0e74
PE
4089 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4090
dd5963ea
PE
4091 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4092
88c9450f
PE
4093 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4094
2f9442b8
PE
4095 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4096
c032b5f8
PE
4097 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4098 * charset.c (Fdefine_charset_internal): Don't initialize
4099 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4100 32-bit int (Bug#8600).
a108c10b
PE
4101
4102 * lread.c (read_integer): Be more consistent with string-to-number.
4103 Use string_to_number to do the actual conversion; this avoids
4104 rounding errors and fixes some other screwups. Without this fix,
4105 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4106 (digit_to_number): Move earlier, for benefit of read_integer.
4107 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4108 not a digit in any supported base. (Bug#8602)
a108c10b 4109
ad5f9eea
PE
4110 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4111
aec1708a
PE
4112 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4113 to match comment at start of function. This also removes a
4114 GCC warning about overflow in a 32+64-bit port.
4115
47be4ab5
PE
4116 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4117
371cac43
PE
4118 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4119 Reported by Stefan Monnier in
4120 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4121 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4122 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4123
d01a7826
PE
4124 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4125 (EMACS_UINTPTR): Likewise, with uintptr_t.
4126
7fd47d5c
PE
4127 * lisp.h: Prefer 64-bit EMACS_INT if available.
4128 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4129 on 32-bit hosts that have 64-bit int, so that they can access
4130 large files.
122b0c86
PE
4131 However, temporarily disable this change unless the temporary
4132 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4133
8727937b
PE
4134 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4135
8ac068ac
PE
4136 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4137 This removes an assumption that EMACS_INT and long are the same
4138 width as pointers. The assumption is true for Emacs porting targets
4139 now, but we want to make other targets possible.
4140 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4141 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4142 In the rest of the code, change types of integers that hold casted
4143 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4144 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4145 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4146 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4147 No need to cast type when ORing.
4148 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4149 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4150 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4151 assume EMACS_INT is the same width as char *.
4152 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4153 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4154 Remove no-longer-needed casts.
4155 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4156 (xg_tool_bar_help_callback, xg_make_tool_item):
4157 Use EMACS_INTPTR to hold an integer
4158 that will be cast to void *; this can avoid a GCC warning
4159 if EMACS_INT is not the same width as void *.
4160 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4161 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4162 (current_message_1, set_message_1):
4163 Use a local to convert to proper width without a cast.
4164 * xmenu.c (dialog_selection_callback): Likewise.
4165
ede49d71
PE
4166 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4167 Also, don't assume VALBITS / RAND_BITS is less than 5,
4168 and don't rely on undefined behavior when shifting a 1 left into
4169 the sign bit.
4170 * lisp.h (get_random): Change signature to match.
4171
2f30ecd0
PE
4172 * lread.c (hash_string): Use size_t, not int, for hash computation.
4173 Normally we prefer signed values; but hashing is special, because
4174 it's better to use unsigned division on hash table sizes so that
4175 the remainder is nonnegative. Also, size_t is the natural width
4176 for hashing into memory. The previous code used 'int', which doesn't
4177 retain enough info to hash well into very large tables.
4178 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4179
2a866e7b
PE
4180 * dbusbind.c: Don't possibly lose pointer info when converting.
4181 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4182 Use XPNTR rather than XHASH, so that the high-order bits of
4183 the pointer aren't lost when converting through void *.
4184
51639eac
PE
4185 * eval.c (Fautoload): Don't double-shift a pointer.
4186
92394119
PE
4187 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4188
dbdb9a7c
JB
41892011-05-06 Juanma Barranquero <lekktu@gmail.com>
4190
4191 * gnutls.c (DEF_GNUTLS_FN):
4192 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4193
db7a0b4f
AS
41942011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4195
4196 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4197 marker. (Bug#8610)
4198
f7ff1b0f 41992011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4200
4201 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4202 New version that can reserve upto 2GB of heap space.
4203
f7ff1b0f 42042011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4205
4206 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4207
639c109b
TZ
42082011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4209
4210 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4211 `gnutls_certificate_set_x509_key_file'.
4212
d2127135
JB
42132011-05-05 Juanma Barranquero <lekktu@gmail.com>
4214
4215 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4216 Update dependencies.
4217
e968f4f3
JB
42182011-05-04 Juanma Barranquero <lekktu@gmail.com>
4219
4220 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4221 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4222 Remove unused parameter `fildes'.
4223 * process.c (read_process_output, send_process): Don't pass it.
4224
84d358f0
JB
42252011-05-04 Juanma Barranquero <lekktu@gmail.com>
4226
4227 Fix previous change: the library cache is defined in w32.c.
4228 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4229 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4230
0898ca10
JB
42312011-05-04 Juanma Barranquero <lekktu@gmail.com>
4232
4233 Implement dynamic loading of GnuTLS on Windows.
4234
4235 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4236 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4237 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4238 Declare.
4239
4240 * gnutls.c (Qgnutls_dll): Define.
4241 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4242 (gnutls_*): Declare function pointers.
4243 (init_gnutls_functions): New function to initialize function pointers.
4244 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4245 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4246 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4247 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4248 (emacs_gnutls_write, emacs_gnutls_read)
4249 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4250 (Fgnutls_available_p): New function.
4251 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4252 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4253 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4254
4255 * image.c: Include w32.h.
4256 (Vimage_type_cache): Delete.
4257 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4258 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4259 (w32_delayed_load): Move to w32.c.
4260
4261 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4262
4263 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4264 (w32_delayed_load): Move from image.c. When loading a library, record
4265 its filename in the :loaded-from property of the library id.
4266 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4267 Initialize and staticpro them.
4268 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4269
4270 * process.c: Include lisp.h before w32.h, not after.
4271 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4272 instead of gnutls_record_check_pending.
4273
4274 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4275
ff4de4aa
TZ
42762011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4277
4278 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4279 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4280 as passed in.
4281
abe95abb
JD
42822011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4283
4284 * xterm.c (x_set_frame_alpha): Do not set property on anything
4285 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4286
e16e55d4
JB
42872011-05-02 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4290
bafcf6a5
JB
42912011-05-02 Juanma Barranquero <lekktu@gmail.com>
4292
4293 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4294 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4295 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4296 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4297 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4298 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4299 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4300 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4301 (Qgnutls_bootprop_callbacks_verify): Make static.
4302
e7a6747f
AS
43032011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4304
19ed11ba
AS
4305 * callproc.c: Indentation fixup.
4306
e7a6747f 4307 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4308 (wait_for_termination, interruptible_wait_for_termination):
4309 Move after wait_for_termination_1.
e7a6747f 4310
1ef14cb4
LMI
43112011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4312
4313 * sysdep.c (interruptible_wait_for_termination): New function
4314 which is like wait_for_termination, but allows keyboard
4315 interruptions.
4316
4317 * callproc.c (Fcall_process): Add (:file "file") as an option for
4318 the STDOUT buffer.
4319 (Fcall_process_region): Ditto.
4320
330d880c
EZ
43212011-04-30 Eli Zaretskii <eliz@gnu.org>
4322
8db90b73
EZ
4323 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4324 rather than `XVECTOR (FOO)->size'.
4325
330d880c
EZ
4326 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4327 inttypes.h, as a gnulib replacement is used if it not available in
4328 system headers.
4329
15cbd324
EZ
43302011-04-21 Eli Zaretskii <eliz@gnu.org>
4331
4332 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4333 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4334 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4335
4336 * coding.c (coding_alloc_by_realloc): Error out if destination
4337 will grow beyond MOST_POSITIVE_FIXNUM.
4338 (decode_coding_emacs_mule): Abort if there isn't enough place in
4339 charbuf for the composition carryover bytes. Reserve an extra
4340 space for up to 2 characters produced in a loop.
4341 (decode_coding_iso_2022): Abort if there isn't enough place in
4342 charbuf for the composition carryover bytes.
4343
43442011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4345
ae940cca
EZ
4346 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4347 aborting when %lld or %lll format is passed.
4348 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4349 %llo or %llx format is passed. (Bug#8545)
4350
03ab8921
EZ
4351 * window.c (window_scroll_line_based): Use a marker instead of
4352 simple variables to record original value of point. (Bug#7952)
4353
afda1437
EZ
4354 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4355 produced by %s or %c overflows available buffer space. (Bug#8545)
4356
f76dee0c
PE
43572011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4358
4359 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4360 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4361
fdc5744d
JB
43622011-04-28 Juanma Barranquero <lekktu@gmail.com>
4363
4364 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4365
638f053a
JB
43662011-04-28 Juanma Barranquero <lekktu@gmail.com>
4367
4368 * keyboard.c (Qdelayed_warnings_hook): Define.
4369 (command_loop_1): Run `delayed-warnings-hook'
4370 if Vdelayed_warnings_list is non-nil.
4371 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4372 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4373
d178f871
EZ
43742011-04-28 Eli Zaretskii <eliz@gnu.org>
4375
4376 * doprnt.c (doprnt): Don't return value smaller than the buffer
4377 size if the message was truncated. (Bug#8545).
4378
b124fd93
JB
43792011-04-28 Juanma Barranquero <lekktu@gmail.com>
4380
4381 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4382 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4383
e810457d
PE
43842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4387
ea51cceb
JB
43882011-04-27 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * makefile.w32-in: Update dependencies.
4391
94dcfacf
EZ
43922011-04-27 Eli Zaretskii <eliz@gnu.org>
4393
4394 Improve `doprnt' and its usage. (Bug#8545)
4395 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4396 `format_end'. Remove support for %l as a conversion specifier.
4397 Don't use xrealloc. Improve diagnostics when the %l size modifier
4398 is used. Update the commentary.
4399
4400 * eval.c (verror): Simplify calculation of size_t.
4401
4402 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4403 messages.
4404
f61f41d7
PE
44052011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4406
4407 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4408 change.
4409
96fb4434
PE
44102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4411
4412 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4413 This makes this file independent of the recent pseudovector change.
4414
671875da 44152011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4416
69e9b5a3
PE
4417 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4418
b5f869a7 4419 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4420 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4421 Remove unused local.
c8926152 4422 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4423
841a1577 4424 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4425 GCC 4.6.0 optimizes based on type-based alias analysis.
4426 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4427 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4428 != &v->size, and therefore "v->size = 1; b->size = 2; return
4429 v->size;" must therefore return 1. This assumption is incorrect
4430 for Emacs, since it type-puns struct Lisp_Vector * with many other
4431 types. To fix this problem, this patch adds a new type struct
f904488f 4432 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4433 and pseudovectors, and helps optimizing compilers not get fooled
4434 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4435 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4436 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4437 the size member.
eab3844f
PE
4438 (XSETPVECTYPE): Rewrite in terms of new macro.
4439 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4440 This is a bit clearer, and further avoids the possibility of
4441 undesirable aliasing.
4442 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4443 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4444 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4445 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4446 (ASIZE): Now uses header.size rather than size.
4447 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4448 to avoid the hassle of writing XVECTOR (foo)->header.size.
4449 (struct vectorlike_header): New type.
eab3844f
PE
4450 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4451 object, to help avoid aliasing.
4452 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4453 (SUBRP): Likewise, since Lisp_Subr is a special case.
4454 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4455 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4456 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4457 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4458 changed to be "header.size" and "header.next".
4459 * buffer.h (struct buffer): Likewise.
4460 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4461 * frame.h (struct frame): Likewise.
4462 * process.h (struct Lisp_Process): Likewise.
4463 * termhooks.h (struct terminal): Likewise.
4464 * window.c (struct save_window_data, struct saved_window): Likewise.
4465 * window.h (struct window): Likewise.
4466 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4467 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4468 * buffer.c (init_buffer_once): Likewise.
4469 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4470 special case.
4471 * process.c (Fformat_network_address): Use local var for size,
4472 for brevity.
4473
0df1eac5
PE
4474 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4475
847ab9d1 4476 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4477 * data.c (atof): Remove decl; no longer used or needed.
4478 (digit_to_number): Move to lread.c.
4479 (Fstring_to_number): Use new string_to_number function, to be
4480 consistent with how the Lisp reader treats infinities and NaNs.
4481 Do not assume that floating-point numbers represent EMACS_INT
4482 without losing information; this is not true on most 64-bit hosts.
4483 Avoid double-rounding errors, by insisting on integers when
4484 parsing non-base-10 numbers, as the documentation specifies.
4485 * lisp.h (string_to_number): New decl, replacing ...
4486 (isfloat_string): Remove.
bc0a5c13 4487 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4488 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4489 appears to have been a coding error. Similarly, do not accept
4490 strings like +-1e0 as floating point numbers. Do not report
4491 overflow for integer overflows unless the base is not 10 which
4492 means we have no simple and reliable way to continue.
4493 Break out the floating-point parsing into a new
4494 function string_to_number, so that Fstring_to_number parses
4495 floating point numbers consistently with the Lisp reader.
04f2d78b 4496 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4497 (E_CHAR, EXP_INT): Remove, replacing with ...
4498 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4499 (string_to_number): New function, replacing isfloat_string.
4500 This function checks for valid syntax and produces the resulting
4501 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4502 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4503 so that overflow for non-base-10 numbers is reported only when
4504 there's no portable and simple way to convert to floating point.
452f4150 4505
67769ffc
PE
4506 * textprop.c (set_text_properties_1): Rewrite for clarity,
4507 and to avoid GCC warning about integer overflow.
4508
c20db43f
PE
4509 * intervals.h (struct interval): Use EMACS_INT for members
4510 where EMACS_UINT might cause problems. See
4511 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4512 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4513 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4514 All uses changed.
37aa2f85
PE
4515 (offset_intervals): Tell GCC not to worry about length overflow
4516 when negating a negative length.
c20db43f 4517
2538aa2f
PE
4518 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4519 (overrun_check_free): Likewise.
4520
f2d3008d
PE
4521 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4522 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4523 word size.
4524
ec8df744
PE
4525 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4526 (gnutls_make_error): Rename local to avoid shadowing.
4527 (gnutls_emacs_global_deinit): ifdef out; not used.
4528 (Fgnutls_boot): Use const for pointer to readonly storage.
4529 Comment out unused local. Fix pointer signedness problems.
4530
640ee02d
PE
4531 * lread.c (openp): Don't stuff size_t into an 'int'.
4532 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4533 about possible signed overflow.
4534
6048fb2a
PE
4535 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4536 (GDK_KEY_g): Don't define if already defined.
4537 (xg_prepare_tooltip): Avoid pointer signedness problem.
4538 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4539
fa3c87e1
PE
4540 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4541 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4542
2172544b
PE
4543 * xfns.c (Fx_window_property): Simplify a bit,
4544 to make a bit faster and to avoid GCC 4.6.0 warning.
4545 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4546
9b821a21
PE
4547 * fns.c (internal_equal): Don't assume size_t fits in int.
4548
3c616cfa
PE
4549 * alloc.c (compact_small_strings): Tighten assertion a little.
4550
c2982e87
PE
4551 Replace pEd with more-general pI, and fix some printf arg casts.
4552 * lisp.h (pI): New macro, generalizing old pEd macro to other
4553 conversion specifiers. For example, use "...%"pI"d..." rather
4554 than "...%"pEd"...".
4555 (pEd): Remove. All uses replaced with similar uses of pI.
4556 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4557 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4558 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4559 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4560 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4561 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4562 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4563 64-bit hosts.
4564 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4565 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4566 * print.c (safe_debug_print, print_object): Likewise.
4567 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4568 to int.
6f04d126
PE
4569 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4570 avoiding the 0 flag, which is not portable.
c2982e87
PE
4571 * process.c (Fmake_network_process): Use pI to avoid cast.
4572 * region-cache.c (pp_cache): Likewise.
4573 * xdisp.c (decode_mode_spec): Likewise.
4574 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4575 behavior on 64-bit hosts with printf arg.
6f04d126 4576 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4577 (x_stop_queuing_selection_requests): Likewise.
4578 (x_get_window_property): Don't truncate byte count to an 'int'
4579 when tracing.
0b432f21 4580
5e073ec7
PE
4581 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4582 here, since it parses constructs like leading '-' and spaces,
4583 which are not wanted; and it overflows with large numbers.
4584 Instead, simply match F[0-9]+, which is what is wanted anyway.
4585
36372bf9
PE
4586 * alloc.c: Remove unportable assumptions about struct layout.
4587 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4588 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4589 (allocate_vectorlike, make_pure_vector): Use the new macros,
4590 plus offsetof, to remove unportable assumptions about struct layout.
4591 These assumptions hold on all porting targets that I know of, but
4592 they are not guaranteed, they're easy to remove, and removing them
4593 makes further changes easier.
4594
0b432f21
PE
4595 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4596 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4597 (string_overrun_cookie): Now const. Use initializers that
4598 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4599 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4600 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4601 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4602 multiple of sizeof (EMACS_INT); it need not be, if
4603 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4604 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4605
895009e1
JB
46062011-04-26 Juanma Barranquero <lekktu@gmail.com>
4607
4608 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4609
6a7a1b0b
TZ
46102011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4611
4612 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4613 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4614 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4615
841a1577 46162011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4617
4618 * lisp.h (Qdebug): List symbol.
895009e1 4619 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4620 * keyboard.c (debug-on-event): New variable.
4621 (handle_user_signal): Break into debugger when debug-on-event
4622 matches the current signal symbol.
4623
f2d3ba6f
DN
46242011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4625
4626 * alloc.c (check_sblock, check_string_bytes)
4627 (check_string_free_list): Convert to standard C.
4628
42ce4c63
TZ
46292011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4630
4631 * w32.c (emacs_gnutls_push): Fix typo.
4632
825cd63c
EZ
46332011-04-25 Eli Zaretskii <eliz@gnu.org>
4634
fb11d64d
EZ
4635 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4636 "cast to pointer from integer of different size".
4637
825cd63c
EZ
4638 Improve doprnt and its use in verror. (Bug#8545)
4639 * doprnt.c (doprnt): Document the set of format control sequences
4640 supported by the function. Use SAFE_ALLOCA instead of always
4641 using `alloca'.
4642
4643 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4644 is one byte too soon. Don't use xrealloc; instead xfree and
4645 xmalloc anew.
4646
e061a11b
TZ
46472011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4648
4649 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4650 callbacks stage.
4651
4652 * gnutls.c: Renamed global_initialized to
4653 gnutls_global_initialized. Added internals for the
4654 :verify-hostname-error, :verify-error, and :verify-flags
4655 parameters of `gnutls-boot' and documented those parameters in the
4656 docstring. Start callback support.
9173deec
JB
4657 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4658 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4659 on error. Return error code.
e061a11b
TZ
4660 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4661 (emacs_gnutls_read): Likewise.
4662 (Fgnutls_boot): Return handshake error code.
4663 (emacs_gnutls_handle_error): New function.
4664 (wsaerror_to_errno): Likewise.
4665
4666 * w32.h (emacs_gnutls_pull): Add prototype.
4667 (emacs_gnutls_push): Likewise.
4668
4669 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4670 (emacs_gnutls_push): Likewise.
4671
46722011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4673
4674 * process.c (wait_reading_process_output): Check if GnuTLS
4675 buffered some data internally if no FDs are set for TLS
4676 connections.
4677
4678 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4679 (LIBS): Link to USER_LIBS.
4680 ($(BLD)/gnutls.$(0)): New target.
4681
fa6996bc
EZ
46822011-04-24 Eli Zaretskii <eliz@gnu.org>
4683
eb35682e
EZ
4684 * xdisp.c (handle_single_display_spec): Rename the
4685 display_replaced_before_p argument into display_replaced_p, to
4686 make it consistent with the commentary. Fix typos in the
4687 commentary.
4688
e2ad650c
EZ
4689 * textprop.c (syms_of_textprop): Remove dead code.
4690 (copy_text_properties): Delete obsolete commentary about an
4691 interface that was deleted long ago. Fix typos in the description
4692 of arguments.
4693
1b2de274
EZ
4694 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4695 to changes in oldXMenu/XMenu.h from 2011-04-16.
4696 <menu_help_message, prev_menu_help_message>: Constify.
4697 (IT_menu_make_room): menu->help_text is now `const char **';
4698 adjust.
4699
4700 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4701 to changes in oldXMenu/XMenu.h from 2011-04-16.
4702 (struct XMenu): Declare `help_text' `const char **'.
4703
4704 * xfaces.c <Qunspecified>: Make extern again.
4705
4706 * syntax.c: Include sys/types.h before including regex.h, as
4707 required by Posix.
4708
762b15be
EZ
4709 * doc.c (get_doc_string): Improve the format passed to `error'.
4710
4711 * doprnt.c (doprnt): Improve commentary.
4712
4713 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4714
4715 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4716 them with etags.
4717
f1052e5d
EZ
4718 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4719 changes in globals.h immediately force recompilation.
762b15be
EZ
4720 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4721 $(CURDIR)/s/ms-w32.h.
4722 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4723
fa6996bc
EZ
4724 * character.c (Fchar_direction): Function deleted.
4725 (syms_of_character): Don't defsubr it.
4726 <char-direction-table>: Deleted.
4727
e6c3da20
EZ
47282011-04-23 Eli Zaretskii <eliz@gnu.org>
4729
4730 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4731 * doprnt.c: Include limits.h.
4732 (SIZE_MAX): New macro.
04f2d78b
CB
4733 (doprnt): Return a size_t value. 2nd arg is now size_t.
4734 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4735 Improve overflow protection. Support `l' modifier for integer
4736 conversions. Support %l conversion. Don't assume an EMACS_INT
4737 argument for integer conversions and for %c.
4738
4739 * lisp.h (doprnt): Restore prototype.
4740
4741 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4742 $(SRC)/character.h.
4743
4744 * Makefile.in (base_obj): Add back doprnt.o.
4745
4746 * deps.mk (doprnt.o): Add back prerequisites.
4747 (callint.o): Depend on character.h.
4748
4749 * eval.c (internal_lisp_condition_case): Include the handler
4750 representation in the error message.
4751 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4752 when breaking from the loop.
4753
4754 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4755
4756 * callint.c (Fcall_interactively): When displaying error message
4757 about invalid control letter, pass the character's codepoint, not
4758 a pointer to its multibyte form. Improve display of the character
4759 in octal and display also its hex code.
4760
4761 * character.c (char_string): Use %x to display the (unsigned)
4762 codepoint of an invalid character, to avoid displaying a bogus
4763 negative value.
4764
4765 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4766 `error', not SYMBOL_NAME itself.
4767
4768 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4769 character arguments to `error'.
4770
4771 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4772 to `error' in error message about FINAL_CHAR argument. Make sure
4773 FINAL_CHAR is a character, and use %c when it is passed as
4774 argument to `error'.
4775
4ffd0d6b 47762011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4777
4778 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4779
4780 * w32.c: Include <time.h>.
4781 (sys_localtime): New function.
4782
4ffd0d6b 47832011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4784
4785 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4786
4ffd0d6b 4787 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4788
4ffd0d6b 47892011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4790
4ffd0d6b
GM
4791 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4792 zombies (Bug#8467).
aac0c6e3 4793
04c56954
EZ
47942011-04-19 Eli Zaretskii <eliz@gnu.org>
4795
4796 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4797 gl_state.e_property when gl_state.object is Qt.
4798
4799 * insdel.c (make_gap_larger): Remove limitation of buffer size
4800 to <= INT_MAX.
4801
16a43933
CY
48022011-04-18 Chong Yidong <cyd@stupidchicken.com>
4803
4804 * xdisp.c (lookup_glyphless_char_display)
4805 (produce_glyphless_glyph): Handle cons cell entry in
4806 glyphless-char-display.
4807 (Vglyphless_char_display): Document it.
4808
4809 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4810 glyphless-char-display.
4811
4581706e
CY
48122011-04-17 Chong Yidong <cyd@stupidchicken.com>
4813
4814 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4815
4816 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4817
4818 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4819 definition for no-X builds.
4820
4887c6e2 48212011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4822
fd35b6f9
PE
4823 Static checks with GCC 4.6.0 and non-default toolkits.
4824
5c1ccb01
PE
4825 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4826
006c5daa
PE
4827 * process.c (keyboard_bit_set): Define only if SIGIO.
4828 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4829 (send_process): Repair possible setjmp clobbering.
4830
efc736d3
PE
4831 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4832
4e2fe2e6
PE
4833 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4834
f97334a2
PE
4835 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4836
4e75f29d
PE
4837 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4838 Define only if needed.
4839
90efadd1
PE
4840 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4841 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4842 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4843
3c647824
PE
4844 * dispextern.h (struct redisplay_interface): Rename param
4845 to avoid shadowing.
e264f262 4846 * termhooks.h (struct terminal): Likewise.
761383f4 4847 * xterm.c (xembed_send_message): Likewise.
3c647824 4848
b58c5c4a
PE
4849 * insdel.c (make_gap_smaller): Define only if
4850 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4851
cad59032
PE
4852 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4853 it.
4854
c339dc2e
PE
4855 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4856 so that we aren't warned about unused symbols.
4857
91a3e27b
PE
4858 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4859
399c71d3 4860 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4861
8ffc96f5
PE
4862 * xfns.c (x_real_positions): Mark locals as initialized.
4863
eef9bc79
PE
4864 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4865
098db9dd
PE
4866 * xterm.c: Fix problems found by static analysis with other toolkits.
4867 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4868 (x_dispatch_event): Declare static if USE_GTK, and
4869 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4870 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4871 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4872 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4873 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4874
eb18f6cc
PE
4875 * xmenu.c (menu_help_callback): Pointer type fixes.
4876 Use const pointers when pointing at readonly data. Avoid pointer
4877 signedness clashes.
4878 (FALSE): Remove unused macro.
4879 (update_frame_menubar): Remove unused decl.
4880
1fe72bf8
PE
4881 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4882
60d9e1db
PE
4883 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4884 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4885 (single_menu_item): Rename local to avoid shadowing.
4886
39261c26
PE
4887 * keyboard.c (make_lispy_event): Remove unused local var.
4888
018c5e19
PE
4889 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4890 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4891
63d2b86e
PE
4892 * bitmaps: Change bitmaps from unsigned char back to the X11
4893 compatible char. Avoid the old compiler warnings about
4894 out-of-range initializers by using, for example, '\xab' rather
4895 than 0xab.
4896
aefd87e1
PE
4897 * xgselect.c (xgselect_initialize): Check vs interface
4898 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4899
bf501fb9
PE
4900 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4901
e9829fdf
PE
4902 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4903 to read-only memory.
4904
1086c095
PE
4905 * fns.c (vector): Remove; this old hack is no longer needed.
4906
2baccd04 4907 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4908 Remove unused var.
dde42981 4909 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4910
72391843 4911 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4912
436c16df 4913 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4914 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4915 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4916
92bb796d 4917 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4918 (x_term_init): Remove local to avoid shadowing.
92bb796d 4919
764430a3 4920 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4921
4922 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4923 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4924
d1dfb56c
EZ
49252011-04-16 Eli Zaretskii <eliz@gnu.org>
4926
c4354cb4
EZ
4927 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4928
d1dfb56c
EZ
4929 Fix regex.c, syntax.c and friends for buffers > 2GB.
4930 * syntax.h (struct gl_state_s): Declare character position members
4931 EMACS_INT.
4932
4933 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4934
04f2d78b
CB
4935 * textprop.c (verify_interval_modification, interval_of):
4936 Declare arguments EMACS_INT.
d1dfb56c
EZ
4937
4938 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4939 EMACS_INT.
4940
4941 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4942
4943 * indent.c (Fvertical_motion): Local variable it_start is now
4944 EMACS_INT.
4945
4946 * regex.c (re_match, re_match_2, re_match_2_internal)
4947 (bcmp_translate, regcomp, regexec, print_double_string)
4948 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4949 (re_compile_pattern, re_exec): Declare arguments and local
4950 variables `size_t' and `ssize_t' and return values `regoff_t', as
4951 appropriate.
4952 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4953 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4954 <compile_stack_type>: `size' and `avail' are now `size_t'.
4955
4956 * regex.h <regoff_t>: Use ssize_t, not int.
4957 (re_search, re_search_2, re_match, re_match_2): Arguments that
4958 specify buffer/string position and length are now ssize_t and
4959 size_t. Return type is regoff_t.
4960
613052cd
BK
49612011-04-16 Ben Key <bkey76@gmail.com>
4962
4963 * nsfont.m: Fixed bugs in ns_get_family and
4964 ns_descriptor_to_entity that were caused by using free to
4965 deallocate memory blocks that were allocated by xmalloc (via
4966 xstrdup). This caused Emacs to crash when compiled with
4967 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4968 --enable-checking=xmallocoverrun). xfree is now used to
4969 deallocate these memory blocks.
4970
4170f62f 49712011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4972
71b41406
PE
4973 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4974
9587a89d
PE
4975 emacs_write: Accept and return EMACS_INT for sizes.
4976 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4977 et seq.
4978 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4979 Accept and return EMACS_INT.
4980 (emacs_gnutls_write): Return the number of bytes written on
4981 partial writes.
4982 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4983 (emacs_read, emacs_write): Remove check for negative size, as the
4984 Emacs source code has been audited now.
9587a89d
PE
4985 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4986 (emacs_read, emacs_write): Use it.
273a5f82
PE
4987 * process.c (send_process): Adjust to the new signatures of
4988 emacs_write and emacs_gnutls_write. Do not attempt to store
4989 a byte offset into an 'int'; it might overflow.
9587a89d 4990 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4991
3e047f51
PE
4992 * sound.c: Don't assume sizes fit in 'int'.
4993 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4994 Return EMACS_INT, not int.
3e047f51 4995 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4996 Accept EMACS_INT, not int.
4997 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4998 record read return values.
4999
cc39a9db
BK
50002011-04-15 Ben Key <bkey76@gmail.com>
5001
c9d0ec6d
JB
5002 * keyboard.c (Qundefined): Don't declare static since it is used
5003 in nsfns.m.
5004 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5005 static since they are used in nsfont.m.
cc39a9db 5006
6c60eb9f
SM
50072011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5008
5009 * process.c (Qprocessp): Don't declare static.
5010 * lisp.h (Qprocessp): Declare again.
5011
7990b61a
JB
50122011-04-15 Juanma Barranquero <lekktu@gmail.com>
5013
5014 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5015
5d4cb038
PE
50162011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5017
8bd7b830 5018 Improve C-level modularity by making more things 'static'.
cd64ea1d 5019
e3b27b31
PE
5020 Don't publish debugger-only interfaces to other modules.
5021 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5022 (verify_bytepos, count_markers): Move decls to the only modules
5023 that need them.
5024 * region-cache.h (pp_cache): Likewise.
5025 * window.h (check_all_windows): Likewise.
5026 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5027
5d4cb038
PE
5028 * sysdep.c (croak): Now static, if
5029 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5030 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5031
5032 * alloc.c (refill_memory_reserve): Now static if
5033 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5034 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5035
e87b6180
PE
5036 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5037 Define only if USE_LUCID.
5038
ac64929e
PE
5039 * xrdb.c (x_customization_string, x_rm_string): Now static.
5040
6f37259d
PE
5041 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5042 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5043
1683e3ab
PE
5044 * xdisp.c (draw_row_with_mouse_face): Now static.
5045 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5046
de9c2632
PE
5047 * window.h (check_all_windows): Mark externally visible.
5048
2b96acb7
PE
5049 * window.c (window_deletion_count): Now static.
5050
5051 * undo.c: Make symbols static if they're not exported.
5052 (last_undo_buffer, last_boundary_position, pending_boundary):
5053 Now static.
5054
50436f33
PE
5055 * textprop.c (interval_insert_behind_hooks): Now static.
5056 (interval_insert_in_front_hooks): Likewise.
5057
64520e5c
PE
5058 * term.c: Make symbols static if they're not exported.
5059 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5060 (max_frame_lines, tty_set_terminal_modes):
5061 (tty_reset_terminal_modes, tty_turn_off_highlight):
5062 (get_tty_terminal): Now static.
5063 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5064 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5065 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5066 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5067 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5068
1fa53021
PE
5069 * sysdep.c: Make symbols static if they're not exported.
5070 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5071 Now static.
5072 (sigprocmask_set, full_mask): Remove; unused.
5073 (wait_debugging): Mark as visible.
5074 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5075 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5076
d4b43b22
PE
5077 * syntax.c (syntax_temp): Define only if !__GNUC__.
5078
b7c513d0
PE
5079 * sound.c (current_sound_device, current_sound): Now static.
5080
989b29ad
PE
5081 * search.c (searchbufs, searchbuf_head): Now static.
5082
13a55a78
PE
5083 * scroll.c (scroll_cost): Remove; unused.
5084 * dispextern.h (scroll_cost): Remove decl.
5085
de68a1fc
PE
5086 * region-cache.h (pp_cache): Mark as externally visible.
5087
40ccffa6
PE
5088 * process.c: Make symbols static if they're not exported.
5089 (process_tick, update_tick, create_process, chan_process):
5090 (Vprocess_alist, proc_buffered_char, datagram_access):
5091 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5092 (deactivate_process): Mark defn as static, as well as decl.
5093 * lisp.h (create_process): Remove decl.
5094 * process.h (chan_process, Vprocess_alist): Remove decls.
5095
ad64fc97
PE
5096 * print.c: Make symbols static if they're not exported.
5097 (print_depth, new_backquote_output, being_printed, print_buffer):
5098 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5099 (print_interval, print_number_index, initial_stderr_stream):
5100 Now static.
5101 * lisp.h (Fprinc): Remove decl.
5102 (debug_output_compilation_hack): Mark as externally visible.
5103
adddb265
PE
5104 * sysdep.c (croak): Move decl from here to syssignal.h.
5105 * syssignal.h (croak): Put it here, so the API can be checked when
5106 'croak' is called from dissociate_if_controlling_tty.
5107
1717ede2
PE
5108 * minibuf.c: Make symbols static if they're not exported.
5109 (minibuf_save_list, choose_minibuf_frame): Now static.
5110 * lisp.h (choose_minibuf_frame): Remove decl.
5111
fa5fb2bc
PE
5112 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5113
1e3890d1
PE
5114 * lread.c: Make symbols static if they're not exported.
5115 (read_objects, initial_obarray, oblookup_last_bucket_number):
5116 Now static.
5117 (make_symbol): Remove; unused.
5118 * lisp.h (initial_obarray, make_symbol): Remove decls.
5119
8a1414fa
PE
5120 * keyboard.c: Make symbols static if they're not exported.
5121 (single_kboard, recent_keys_index, total_keys, recent_keys):
5122 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5123 (this_single_command_key_start, echoing, last_auto_save):
5124 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5125 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5126 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5127 (Vlispy_mouse_stem, double_click_count):
5128 Now static.
5129 (force_auto_save_soon): Define only if SIGDANGER.
5130 (ignore_mouse_drag_p): Now static if
5131 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5132 (print_help): Remove; unused.
5133 (stop_character, last_timer_event): Mark as externally visible.
5134 * keyboard.h (ignore_mouse_drag_p): Declare only if
5135 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5136 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5137 * lisp.h (echoing): Remove decl.
5138 (force_auto_save_soon): Declare only if SIGDANGER.
5139 * xdisp.c (redisplay_window): Simplify code, to make it more
5140 obvious that ignore_mouse_drag_p is not accessed if !defined
5141 USE_GTK && !defined HAVE_NS.
5142
93ea6e8f
PE
5143 * intervals.c: Make symbols static if they're not exported.
5144 (merge_properties_sticky, merge_interval_right, delete_interval):
5145 Now static.
5146 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5147
77382fcc
PE
5148 * insdel.c: Make symbols static if they're not exported.
5149 However, leave prepare_to_modify_buffer alone. It's never
5150 called from outside this function, but that appears to be a bug.
5151 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5152 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5153 (adjust_after_replace_noundo): Remove; unused.
5154 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5155 (signal_before_change): Remove decls.
77382fcc 5156
9306c32e
PE
5157 * indent.c (val_compute_motion, val_vmotion): Now static.
5158
cd44d2eb
PE
5159 * image.c: Make symbols static if they're not exported.
5160 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5161 if USE_GTK.
5162 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5163 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5164
ad9a7a06
PE
5165 * fringe.c (standard_bitmaps): Now static.
5166 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5167
81626931
PE
5168 * frame.c: Make symbols static if they're not exported.
5169 (x_report_frame_params, make_terminal_frame): Now static.
5170 (get_frame_param): Now static, unless HAVE_NS.
5171 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5172 (x_get_resource_string): Remove; not used.
5173 * frame.h (make_terminal_frame, x_report_frame_params):
5174 (x_get_resource_string); Remove decls.
5175 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5176 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5177
239f9db9
PE
5178 * font.c, fontset.c: Make symbols static if they're not exported.
5179 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5180 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5181 * font.c (font_close_object): Now static.
5182 * font.h (font_close_object): Remove.
5183 * fontset.c (FONTSET_OBJLIST): Remove.
5184 (free_realized_fontset) #if-0 the body, which does nothing.
5185 (face_suitable_for_char_p): #if-0, as it's never called.
5186 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5187 * xfaces.c (face_at_string_position):
5188 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5189 since 0 is always ASCII.
5190
dfcf3579
PE
5191 * fns.c (weak_hash_tables): Now static.
5192
5045092b
PE
5193 * fileio.c: Make symbols static if they're not exported.
5194 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5195 (Vwrite_region_annotation_buffers): Now static.
5196
57a96f5c
PE
5197 * eval.c: Make symbols static if they're not exported.
5198 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5199 * lisp.h (backtrace_list): Remove decl.
5200
35f08c38
PE
5201 * emacs.c: Make symbols static if they're not exported.
5202 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5203 (fatal_error_code, fatal_error_signal_hook, standard_args):
5204 Now static.
5205 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5206 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5207 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5208 * lisp.h (fatal_error_signal_hook): Remove decl.
5209 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5210
f44bd759
PE
5211 * editfns.c: Move a (normally-unused) function to its only use.
5212 * editfns.c, lisp.h (get_operating_system_release): Remove.
5213 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5214 worth the hassle of breaking this out.
5215
b532497d
PE
5216 * xterm.c: Make symbols static if they're not exported.
5217 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5218 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5219 (x_destroy_window, x_delete_display):
5220 Now static.
5221 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5222 (x_mouse_leave): Remove; unused.
5223 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5224 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5225 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5226 Remove decls.
5227 (x_mouse_leave): Declare only if WINDOWSNT.
5228 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5229 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5230 USE_X_TOOLKIT.
5231
1675728f
PE
5232 * ftxfont.c: Make symbols static if they're not exported.
5233 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5234 HAVE_FREETYPE.
5235 * font.h (ftxfont_driver): Likewise.
5236
e4cebfca
PE
5237 * xfns.c: Make symbols static if they're not exported.
5238 (x_last_font_name, x_display_info_for_name):
5239 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5240 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5241 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5242 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5243 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5244 (last_show_tip_args): Now static.
5245 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5246 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5247 (x_screen_planes): Remove; unused.
5248 * dispextern.h (x_screen_planes): Remove decl.
5249
5bf46f05
PE
5250 * dispnew.c: Make symbols static if they're not exported.
5251 * dispextern.h (redraw_garbaged_frames, scrolling):
5252 (increment_row_positions): Remove.
5253 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5254 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5255 Now static.
5256 (redraw_garbaged_frames): Remove; unused.
5257
435f4c28
PE
5258 * xfaces.c: Make symbols static if they're not exported.
5259 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5260 Remove decls.
5261 * xterm.h (defined_color): Remove decls.
5262 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5263 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5264 (menu_face_changed_default, defined_color, free_realized_face):
5265 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5266 (ascii_face_of_lisp_face): Remove; unused.
5267
8524aef3
PE
5268 * xdisp.c: Make symbols static if they're not exported.
5269 * dispextern.h (scratch_glyph_row, window_box_edges):
5270 (glyph_to_pixel_coords, set_cursor_from_row):
5271 (get_next_display_element, set_iterator_to_next):
5272 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5273 (show_mouse_face): Remove decls
5274 * frame.h (message_buf_print): Likewise.
5275 * lisp.h (pop_message, set_message, check_point_in_composition):
5276 Likewise.
5277 * xterm.h (set_vertical_scroll_bar): Likewise.
5278 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5279 (message_buf_print, scratch_glyph_row, displayed_buffer):
5280 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5281 (get_next_display_element, show_mouse_face, window_box_edges):
5282 (frame_to_window_pixel_xy, check_point_in_composition):
5283 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5284 (glyph_to_pixel_coords): Remove; unused.
5285
16390cd2
PE
5286 * dired.c (file_name_completion): Now static.
5287
5288 * dbusbind.c (xd_in_read_queued_messages): Now static.
5289
a25f4dfa
PE
5290 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5291 * data.c (circular_list_error): Remove.
5292
14a9c8df
PE
5293 * commands.h (last_point_position, last_point_position_buffer):
5294 (last_point_position_window): Remove decls.
5295 * keyboard.c: Make these variables static.
5296
04f2d78b
CB
5297 * coding.h (coding, code_convert_region, encode_coding_gap):
5298 Remove decls.
74ab6df5
PE
5299 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5300 (iso_code_class, detect_coding, code_convert_region): Now static.
5301 (encode_coding_gap): Remove; unused.
5302
38dfbee1
PE
5303 * chartab.c (chartab_chars, chartab_bits): Now static.
5304
a2cb4e63
PE
5305 * charset.h (charset_iso_8859_1): Remove decl.
5306 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5307 Now static.
5308
127198fd
PE
5309 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5310 * ccl.c (Vccl_program_table): Now static.
5311 (check_ccl_update): Remove; unused.
5312
d85b608f
PE
5313 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5314 * category.h: ... from here.
5315 * category.c (check_category_table, set_category_set): Now static.
5316
31cd66f3
PE
5317 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5318 * lisp.h: Remove these decls.
5319
c358e587
PE
5320 * buffer.c (buffer_count): Remove unused var.
5321
e78aecca
PE
5322 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5323 so that it's not optimized away.
5324 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5325 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5326 exported only to the debugger.
5327
e192d7d3 5328 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5329 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5330
92470028
PE
5331 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5332 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5333 was inaccessible from Lisp.
5334 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5335 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5336
244ed907
PE
5337 alloc.c: Import and export fewer symbols, and remove unused items.
5338 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5339 is defined.
5340 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5341 it's not optimized away by whole-program optimization.
5342 (message_enable_multibyte, free_misc): Remove.
5343 (catchlist, handlerlist, mark_backtrace):
5344 Declare only if BYTE_MARK_STACK.
5345 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5346 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5347 (message_enable_multibyte): Remove decl.
5348 (free_misc, interval_free_list, float_block, float_block_index):
5349 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5350 (cons_free_list, last_marked_index):
5351 Now static.
5352 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5353 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5354 (mark_backtrace): Define only if BYTE_MARK_STACK.
5355 * xdisp.c (message_enable_multibyte): Now static.
5356
61c2b50e 5357 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5358 This makes it easier for human readers (and static analyzers)
5359 to see whether these variables are used from other modules.
5360 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5361 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5362 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5363 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5364 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5365 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5366 * xmenu.c, xselect.c:
5367 Declare Q* vars static if they are not used in other modules.
5368 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5369 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5370 Remove decls of unexported vars.
5371 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5372
95c82688
PE
5373 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5374
16a97296
PE
5375 Make Emacs functions such as Fatom 'static' by default.
5376 This makes it easier for human readers (and static analyzers)
5377 to see whether these functions can be called from other modules.
5378 DEFUN now defines a static function. To make the function external
5379 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5380 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5381 (Finit_image_library):
16a97296
PE
5382 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5383 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5384 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5385 Remove decls, since these functions are now static.
5386 (Funintern, Fget_internal_run_time): New decls, since these functions
5387 were already external.
95c82688 5388
16a97296
PE
5389 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5390 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5391 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5392 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5393 * keyboard.c, keymap.c, lread.c:
5394 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5395 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5396 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5397 Mark functions with DEFUE instead of DEFUN,
5398 if they are used in other modules.
5399 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5400 decls for now-static functions.
5401 * buffer.h (Fdelete_overlay): Remove decl.
5402 * callproc.c (Fgetenv_internal): Mark as internal.
5403 * composite.c (Fremove_list_of_text_properties): Remove decl.
5404 (Fcomposition_get_gstring): New forward static decl.
5405 * composite.h (Fcomposite_get_gstring): Remove decl.
5406 * dired.c (Ffile_attributes): New forward static decl.
5407 * doc.c (Fdocumntation_property): New forward static decl.
5408 * eval.c (Ffetch_bytecode): New forward static decl.
5409 (Funintern): Remove extern decl; now in .h file where it belongs.
5410 * fileio.c (Fmake_symbolic_link): New forward static decl.
5411 * image.c (Finit_image_library): New forward static decl.
5412 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5413 * intervals.h (Fprevious_property_change):
5414 (Fremove_list_of_text_properties): Remove decls.
5415 * keyboard.c (Fthis_command_keys): Remove decl.
5416 (Fcommand_execute): New forward static decl.
5417 * keymap.c (Flookup_key): New forward static decl.
5418 (Fcopy_keymap): Now static.
5419 * keymap.h (Flookup_key): Remove decl.
5420 * process.c (Fget_process): New forward static decl.
5421 (Fprocess_datagram_address): Mark as internal.
5422 * syntax.c (Fsyntax_table_p): New forward static decl.
5423 (skip_chars): Remove duplicate decl.
5424 * textprop.c (Fprevious_property_change): New forward static decl.
5425 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5426 Now internal.
5427 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5428 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5429
785bbd42
PE
5430 * editfns.c (Fformat): Remove unreachable code.
5431
8b913b57
AS
54322011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5433
5434 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5435 change. (Bug#8496)
5436
a6744a35
EZ
54372011-04-13 Eli Zaretskii <eliz@gnu.org>
5438
5439 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5440 when at ZV. (Bug#8487)
5441
e7974947
AS
54422011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5443
baad03f0
AS
5444 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5445 (Bug#8437)
5446 * keyboard.c (parse_tool_bar_item): Likewise.
5447 * sound.c (sound_cleanup, alsa_close): Likewise.
5448 * termcap.c (tgetent): Likewise.
5449 * xfns.c (x_default_font_parameter): Likewise.
5450 * xsettings.c (read_and_apply_settings): Likewise.
5451
e7974947
AS
5452 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5453 (overrun_check_free): Protoize.
5454
28272684
PE
54552011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5456
5457 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5458 since callers should never pass a negative size.
5459 Change the signature to match that of plain 'read' and 'write'; see
5460 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5461 * lisp.h: Update prototypes of emacs_write and emacs_read.
5462
11997c76
EZ
54632011-04-11 Eli Zaretskii <eliz@gnu.org>
5464
5465 * xdisp.c (redisplay_window): Don't try to determine the character
5466 position of the scroll margin if the window start point w->startp
e896f03c 5467 is outside the buffer's accessible region. (Bug#8468)
11997c76 5468
8a2cbd72
EZ
54692011-04-10 Eli Zaretskii <eliz@gnu.org>
5470
5471 Fix write-region and its subroutines for buffers > 2GB.
5472 * fileio.c (a_write, e_write): Modify declaration of arguments and
5473 local variables to support buffers larger than 2GB.
5474 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5475
5476 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5477 argument, local variables, and return value.
5478
5479 * lisp.h: Update prototypes of emacs_write and emacs_read.
5480
5481 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5482
4073e537 54832011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5484
1ebfdcb6
PE
5485 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5486
b2ded58d
PE
5487 Fix more problems found by GCC 4.6.0's static checks.
5488
7d66342c
PE
5489 * xdisp.c (vmessage): Use a better test for character truncation.
5490
bbf47d44
PE
5491 * charset.c (load_charset_map): <, not <=, for optimization,
5492 and to avoid potential problems with integer overflow.
9248994d 5493 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5494 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5495 * editfns.c (Fformat): Likewise.
1e69125e 5496 * syntax.c (skip_chars): Likewise.
3befa583 5497
e3019616
PE
5498 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5499 This also lets GCC 4.6.0 generate slightly better loop code.
5500
becfa255
PE
5501 * callint.c (Fcall_interactively): <, not <=, for optimization.
5502 (Fcall_interactively): Count the number of arguments produced,
5503 not the number of arguments given. This is simpler and lets GCC
5504 4.6.0 generate slightly better code.
5505
dae0cd48
PE
5506 * ftfont.c: Distingish more carefully between FcChar8 and char.
5507 The previous code passed unsigned char * to a functions like
5508 strlen and xstrcasecmp that expect char *, which does not
5509 conform to the C standard.
5510 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5511 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5512 char * when the C standard requires it.
5513
76032d70
PE
5514 * keyboard.c (read_char): Remove unused var.
5515
eb3f1cc8
PE
5516 * eval.c: Port to Windows vsnprintf (Bug#8435).
5517 Include <limits.h>.
5518 (SIZE_MAX): Define if the headers do not.
5519 (verror): Do not give up if vsnprintf returns a negative count.
5520 Instead, grow the buffer. This ports to Windows vsnprintf, which
5521 does not conform to C99. Problem reported by Eli Zaretskii.
5522 Also, simplify the allocation scheme, by avoiding the need for
5523 calling realloc, and removing the ALLOCATED variable.
5524
70476b54
PE
5525 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5526
12020a9e
PE
5527 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5528 But keep the doprint source code for now, as we might revamp it
5529 and use it again (Bug#8435).
ea6c7ae6
PE
5530 * lisp.h (doprnt): Remove.
5531 * Makefile.in (base_obj): Remove doprnt.o.
5532 * deps.mk (doprnt.o): Remove.
5533
5fdb398c
PE
5534 error: Print 32- and 64-bit integers portably (Bug#8435).
5535 Without this change, on typical 64-bit hosts error ("...%d...", N)
5536 was used to print both 32- and 64-bit integers N, which relied on
5537 undefined behavior.
5538 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5539 New macro.
5540 * lisp.h (error, verror): Mark as printf-like functions.
5541 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5542 Report overflow in size calculations when allocating printf buffer.
5543 Do not truncate output string at its first null byte.
5544 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5545 Truncate the output at a character boundary, since vsnprintf does not
5546 do that.
5547 * charset.c (check_iso_charset_parameter): Convert internal
5548 character to string before calling 'error', since %c now has the
5549 printf meaning.
5550 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5551 overflow when computing char to be passed to 'error'. Do not
5552 pass Lisp_Object to 'error'; pass the integer instead.
5553 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5554 formatted with plain %d.
5555
b189fa66
PE
5556 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5557
bff87ef0
PE
5558 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5559
7e2cac20
PE
5560 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5561
ce4d90b5
PE
5562 * xterm.c (x_catch_errors): Remove duplicate declaration.
5563
266c9547
PE
5564 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5565
79c49ad2
PE
5566 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5567
368f4090
JM
55682011-04-10 Jim Meyering <meyering@redhat.com>
5569
5570 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5571 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5572 return ssize_t not "int", and use size_t as the buffer length.
5573 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5574 * gnutls.h: Update declarations.
5575 * process.c (read_process_output): Use ssize_t, to match.
5576 (send_process): Likewise.
5577
a32d4040
CY
55782011-04-09 Chong Yidong <cyd@stupidchicken.com>
5579
5580 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5581
8546720e 55822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5583
04f2d78b
CB
5584 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5585 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5586
8546720e
GM
5587 * xterm.c (handle_one_xevent):
5588 * xmenu.c (create_and_show_popup_menu):
5589 * xselect.c (x_decline_selection_request)
5590 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5591
0a2f5c1a 55922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5593
5594 Fix some uses of `int' instead of EMACS_INT.
5595 * search.c (string_match_1, fast_string_match)
5596 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5597 (scan_buffer, find_next_newline_no_quit)
5598 (find_before_next_newline, search_command, Freplace_match)
5599 (Fmatch_data): Make some `int' variables be EMACS_INT.
5600
5601 * xdisp.c (display_count_lines): 3rd argument and return value now
5602 EMACS_INT. All callers changed.
5603 (pint2hrstr): Last argument is now EMACS_INT.
5604
5605 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5606 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5607 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5608 (decode_coding_utf_16, decode_coding_emacs_mule)
5609 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5610 (decode_coding_ccl, decode_coding_charset)
5611 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5612 (decode_coding_iso_2022, decode_coding_emacs_mule)
5613 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5614 <char_offset, last_offset>: Declare EMACS_INT.
5615 (encode_coding_utf_8, encode_coding_utf_16)
5616 (encode_coding_emacs_mule, encode_invocation_designation)
5617 (encode_designation_at_bol, encode_coding_iso_2022)
5618 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5619 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5620 Declare EMACS_INT.
5621 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5622 (encode_invocation_designation): Last argument P_NCHARS is now
5623 EMACS_INT.
5624 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5625 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5626
5627 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5628 All users changed.
5629
5630 * ccl.c (Fccl_execute_on_string): Declare some variables
5631 EMACS_INT.
5632
8546720e 56332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5634
5635 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5636
4e19a977
CS
56372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5638
5639 * process.c (Fformat_network_address): Doc fix.
5640
87302331
R
56412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5642
5643 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5644
cbb59342
CY
56452011-04-08 Chong Yidong <cyd@stupidchicken.com>
5646
5647 * keyboard.c (read_char): Call Lisp function help-form-show,
5648 instead of using internal_with_output_to_temp_buffer.
5649 (Qhelp_form_show): New var.
e0d38eeb 5650 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5651
5652 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5653
5654 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5655
e67a13ab
CY
56562011-04-06 Chong Yidong <cyd@stupidchicken.com>
5657
04f2d78b
CB
5658 * process.c (Flist_processes): Remove to Lisp.
5659 (list_processes_1): Delete.
e67a13ab 5660
973f782d
EZ
56612011-04-06 Eli Zaretskii <eliz@gnu.org>
5662
7c106b1e
EZ
5663 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5664
973f782d
EZ
5665 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5666
41cf7d1a 56672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5668
ca23cc88
PE
5669 Fix more problems found by GCC 4.6.0's static checks.
5670
f390e2d5
PE
5671 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5672
42eea0d0
PE
5673 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5674
b69769da 5675 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5676
f9541e84
PE
5677 * xdisp.c (vmessage): Mark as a printf-like function.
5678
13841b55
PE
5679 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5680
c136c10f
PE
5681 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5682
5e2d4a30
PE
5683 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5684 printf-like functions.
5685 (tiff_load): Add casts to remove these marks before passing them
5686 to system-supplied API.
5687
583f48b9
PE
5688 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5689
b25d760e
PE
5690 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5691 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5692 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5693 directly, rather than having caller test rule sign. This avoids
5694 some unnecessary tests.
5695 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5696 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5697 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5698
bc7b6697 5699 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5700 (xfont_open): Avoid unnecessary tests.
bc7b6697 5701
27ccc379
PE
5702 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5703
dcd5c89a
PE
5704 * composite.h, composite.c (composition_gstring_put_cache):
5705 Use EMACS_INT, not int, for length.
5706
b13a45c6
PE
5707 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5708 breaking out part of COMPOSITION_DECODE_RULE.
5709 (COMPOSITION_DECODE_RULE): Use it.
5710 * composite.c (get_composition_id): Remove unused local vars,
5711 by using the new macro.
5712
1e792e4d
PE
5713 * textprop.c (set_text_properties_1): Change while to do-while,
5714 since the condition is always true at first.
5715
dc6c6455 5716 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5717 (interval_deletion_adjustment): Return unsigned value.
5718 All uses changed.
dc6c6455 5719
aba7731a
PE
5720 * process.c (list_processes_1, create_pty, read_process_output):
5721 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5722 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5723 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5724 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5725 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5726
fdfc4bf3
PE
5727 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5728
fca8fe46 5729 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5730 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5731
06a0259a 5732 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5733 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5734 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5735
e7b9e80f
PE
5736 * print.c (print_error_message): Avoid int overflow.
5737
56201685
PE
5738 * font.c (font_list_entities): Redo for clarity,
5739 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5740
78834453 5741 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5742 (font_score): Avoid potential overflow in diff calculation.
78834453 5743
0bc0b309 5744 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5745 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5746
e610eaca
PE
5747 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5748
b895abce
PE
5749 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5750 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5751 can always succeed if overflow has undefined behavior.
5752
1f1d9321 5753 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5754 (wordify): Omit three unnecessary tests.
1f1d9321 5755
c59478bc
PE
5756 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5757 All callers changed. This avoids the need for an unused var.
5758
79b73827
PE
5759 * casefiddle.c (casify_region): Remove var that is set but not used.
5760
a4db5dfe
PE
5761 * dired.c (file_name_completion): Remove var that is set but not used.
5762
43aae36e
PE
5763 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5764
2a47c44d 5765 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5766 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5767
a37c69bf
PE
5768 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5769 Check for integer overflow on size calculations.
5770
328ab8e7
PE
5771 * buffer.c (Fprevious_overlay_change): Remove var that is set
5772 but not used.
5773
e5a2a5cb
PE
5774 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5775 Remove vars that are set but not used.
8d84a6eb 5776 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5777 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5778
a60e5f68
PE
5779 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5780
f661cb61 5781 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5782 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5783
f0397f5a
PE
5784 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5785 that are set but not used.
5786
8664db06 5787 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5788 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5789
6abdaa4a
PE
5790 * xselect.c (x_get_local_selection, x_handle_property_notify):
5791 Remove vars that are set but not used.
5792
0ce7538d 5793 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5794 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5795
9ae848fc
PE
5796 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5797 Remove var that is set but not used.
0b918413
PE
5798 (scroll_bar_windows_size): Now size_t, not int.
5799 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5800 Check for overflow.
9ae848fc 5801
a5a62657
PE
5802 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5803 (map_tty_color) [!defined MSDOS]: Likewise.
5804
5c5cdd39
PE
5805 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5806
66ebf983
PE
5807 * coding.c: Remove vars that are set but not used.
5808 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5809 All callers changed.
5810 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5811 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5812 (decode_coding_charset): Remove vars that are set but not used.
5813
1be4d761
PE
5814 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5815 that is set but not used.
5816
47553fa8
PE
5817 * print.c (print_object): Remove var that is set but not used.
5818
1f7196bf 5819 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5820 The gnulib version avoids calling malloc in the usual case,
5821 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5822 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5823 * filelock.c (current_lock_owner): Likewise.
5824 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5825 * sysdep.c: Include allocator.h, careadlinkat.h.
5826 (emacs_no_realloc_allocator): New static constant.
5827 (emacs_readlink): New function.
fdb61804
PE
5828 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5829 ../lib/careadlinkat.h.
d1fdcab7 5830
f84c17c7
SM
58312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5832
5833 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5834 first non-nil return value).
5835
ef3862ad
JD
58362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5837
5838 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5839 if not defined (Bug#8403).
5840
376a7006
JB
58412011-04-02 Juanma Barranquero <lekktu@gmail.com>
5842
5843 * xdisp.c (display_count_lines): Remove parameter `start',
5844 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5845 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5846 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5847 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5848 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5849 and thereabouts. All callers changed.
5850 (get_per_char_metric): Remove parameter `f', unused since
5851 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5852
6ca3801d
JM
58532011-04-02 Jim Meyering <meyering@redhat.com>
5854
5855 do not dereference NULL upon failed strdup
5856 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5857 (ns_get_family): Likewise.
5858
d8e2b5ba
JB
58592011-04-02 Juanma Barranquero <lekktu@gmail.com>
5860
5861 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5862
8c74fcbd
JD
58632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5864
5865 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5866 later (Bug#8403).
5867
7200d79c
SM
58682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5869
03408648 5870 Add lexical binding.
7200d79c 5871
03408648
SM
5872 * window.c (Ftemp_output_buffer_show): New fun.
5873 (Fsave_window_excursion):
5874 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5875
5876 * lread.c (lisp_file_lexically_bound_p): New function.
5877 (Fload): Bind Qlexical_binding.
5878 (readevalloop): Remove `evalfun' arg.
5879 Bind Qinternal_interpreter_environment.
5880 (Feval_buffer): Bind Qlexical_binding.
5881 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5882 Mark as dynamic.
5883 (syms_of_lread): Declare `lexical-binding'.
5884
5885 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5886
5887 * keyboard.c (eval_dyn): New fun.
5888 (menu_item_eval_property): Use it.
ca105506
SM
5889
5890 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5891
03408648
SM
5892 * fns.c (concat, mapcar1): Accept byte-code-functions.
5893
5894 * eval.c (Fsetq): Handle lexical vars.
5895 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5896 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5897 (FletX, Flet): Obey lexical binding.
5898 (Fcommandp): Handle closures.
5899 (Feval): New `lexical' arg.
5900 (eval_sub): New function extracted from Feval. Use it almost
5901 everywhere where Feval was used. Look up vars in lexical env.
5902 Handle closures.
5903 (Ffunctionp): Move from subr.el.
5904 (Ffuncall): Handle closures.
5905 (apply_lambda): Remove `eval_flags'.
5906 (funcall_lambda): Handle closures and new byte-code-functions.
5907 (Fspecial_variable_p): New function.
5908 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5909 but without exporting it to Lisp.
23aba0ea 5910
23aba0ea 5911 * doc.c (Fdocumentation, store_function_docstring):
03408648 5912 * data.c (Finteractive_form): Handle closures.
23aba0ea 5913
03408648
SM
5914 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5915 interactive spec.
ba83908c 5916
04f2d78b
CB
5917 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5918 New byte-codes.
03408648
SM
5919 (exec_byte_code): New function extracted from Fbyte_code to handle new
5920 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5921
03408648 5922 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5923
03408648 5924 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5925
e2abce01
JB
59262011-03-31 Juanma Barranquero <lekktu@gmail.com>
5927
5928 * xdisp.c (redisplay_internal): Fix prototype.
5929
63696a73 59302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5931
63696a73 5932 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5933 (try_scrolling): Use it when setting scroll_limit.
5934 Limit scrolling to 100 screen lines.
63696a73
EZ
5935 (redisplay_window): Even when falling back on "recentering",
5936 position point in the window according to scroll-conservatively,
5937 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5938
5939 (try_scrolling): When point is above the window, allow searching
5940 as far as scroll_max, or one screenful, to compute vertical
5941 distance from PT to the scroll margin position. This prevents
5942 try_scrolling from unnecessarily failing when
5943 scroll-conservatively is set to a value slightly larger than the
5944 window height. Clean up the case of PT below the margin at bottom
5945 of window: scroll_max can no longer be INT_MAX. When aggressive
5946 scrolling is in use, don't let point enter the opposite scroll
5947 margin as result of the scroll.
5948 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5949 threshold of 100 lines for never-recentering scrolling.
5950
e4cc2dfc
JB
59512011-03-31 Juanma Barranquero <lekktu@gmail.com>
5952
5953 * dispextern.h (move_it_by_lines):
5954 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5955 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5956 (message_log_check_duplicate): Remove parameters `prev_bol' and
5957 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5958 (redisplay_internal): Remove parameter `preserve_echo_area',
5959 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5960
5961 * indent.c (Fvertical_motion):
5962 * window.c (window_scroll_pixel_based, Frecenter):
5963 Don't pass `need_y_p' to `move_it_by_lines'.
5964
1c470562
SM
59652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5966
44f230aa
SM
5967 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5968 steal a few bits to be more compact.
5969 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5970 Remove unneeded casts.
5971
1c470562
SM
5972 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5973
888adce9
ZK
59742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5975
5976 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5977 binding" message (bug#7967).
5978
f838ed7b
PE
59792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5980
77861b95
PE
5981 Fix more problems found by GCC 4.6.0's static checks.
5982
de6dbc14
PE
5983 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5984 Remove unused local var.
5985
f838ed7b
PE
5986 * editfns.c (Fmessage_box): Remove unused local var.
5987
792c7b2b
PE
5988 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5989 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5990 Omit unused local vars.
c499e557 5991 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5992 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5993 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5994 Omit unused local var.
5995
ba0165e1
PE
5996 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5997 Don't assume string length fits in int.
32ad8845 5998 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5999 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6000
3c59b4c9
PE
6001 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6002 instead of alloca (Bug#8344).
6003
a3eed478 6004 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6005 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6006
eb4d412d
PE
6007 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6008
1658b401
PE
6009 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6010 concerns.
6011
6012 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6013
6014 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6015
9a2c6e05
PE
6016 * keyboard.c (syms_of_keyboard): Use the same style as later
6017 in this function when indexing through an array. This also
6018 works around GCC bug 48267.
6019
03d0a109
PE
6020 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6021
44f730c8
PE
6022 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6023
fe75f926
PE
6024 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6025 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6026
ffa8c828
PE
6027 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6028 This avoids undefined behavior on integer overflow, and is a bit
6029 more convenient anyway since it is compared to a size_t variable.
6030
c5101a77
PE
6031 Variadic C functions now count arguments with size_t, not int.
6032 This avoids an unnecessary limitation on 64-bit machines, which
6033 caused (substring ...) to crash on large vectors (Bug#8344).
6034 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6035 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6036 All variadic functions and their callers changed accordingly.
c5101a77
PE
6037 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6038 * data.c (arith_driver, float_arith_driver): Likewise.
6039 * editfns.c (general_insert_function): Likewise.
6040 * eval.c (struct backtrace.nargs, interactive_p)
6041 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6042 (funcall_lambda, mark_backtrace): Likewise.
6043 * fns.c (concat): Likewise.
6044 * frame.c (x_set_frame_parameters): Likewise.
6045 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6046 0 if not found, not -1. All callers changed.
6047
dd3f25f7
PE
6048 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6049 (stack_copy_size): Now size_t, not int.
6050 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6051
461c2ab9
JB
60522011-03-28 Juanma Barranquero <lekktu@gmail.com>
6053
6054 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6055 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6056 All callers changed.
6057
6058 * lisp.h (multibyte_char_to_unibyte):
6059 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6060 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6061 * character.h (CHAR_TO_BYTE8):
6062 * cmds.c (internal_self_insert):
6063 * editfns.c (general_insert_function):
6064 * keymap.c (push_key_description):
6065 * search.c (Freplace_match):
6066 * xdisp.c (message_dolog, set_message_1): All callers changed.
6067
f6d62986
SM
60682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6069
6070 * keyboard.c (safe_run_hook_funcall): New function.
6071 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6072 don't set the hook to nil, but remove the offending function instead.
6073 (Qcommand_hook_internal): Remove, unused.
6074 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6075 Vcommand_hook_internal.
6076
6077 * eval.c (enum run_hooks_condition): Remove.
6078 (funcall_nil, funcall_not): New functions.
6079 (run_hook_with_args): Call each function through a `funcall' argument.
6080 Remove `cond' argument, now redundant.
6081 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6082 (Frun_hook_with_args_until_failure): Adjust accordingly.
6083 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6084
1db5b1ad
JB
60852011-03-28 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * dispextern.h (string_buffer_position): Remove declaration.
6088
6089 * print.c (strout): Remove parameter `multibyte', unused since
6090 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6091
6092 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6093 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6094 All callers changed.
6095
6096 * w32.c (_wsa_errlist): Use braces for struct initializers.
6097
6098 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6099 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6100 All callers changed.
6101 (string_buffer_position): Likewise. Also, make static (it's never
6102 used outside xdisp.c).
6103 (cursor_row_p): Remove parameter `w', unused since
6104 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6105 (decode_mode_spec): Remove parameter `precision', introduced during
6106 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6107 All callers changed.
6108
5ffb62aa
JD
61092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6110
6111 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6112
461c2ab9 61132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6114
6115 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6116 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6117 (ns_update_auto_hide_menu_bar): New functions.
6118 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6119 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6120 ns_constrain_all_frames.
6121 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6122 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6123
5c380ffb
JD
61242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6125
6126 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6127
9af30bdf
GM
61282011-03-27 Glenn Morris <rgm@gnu.org>
6129
6130 * syssignal.h: Replace RETSIGTYPE with void.
6131 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6132 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6133 Replace SIGTYPE with void everywhere.
6134 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6135 * s/template.h (SIGTYPE): Remove commented out definition.
6136
e2abce01
JB
61372011-03-26 Eli Zaretskii <eliz@gnu.org>
6138
6139 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6140 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6141
f868cd8a
JB
61422011-03-26 Juanma Barranquero <lekktu@gmail.com>
6143
59eb0929
JB
6144 * w32.c (read_unc_volume): Use parameter `henum', instead of
6145 global variable `wget_enum_handle'.
6146
6147 * keymap.c (describe_vector): Remove parameters `indices' and
6148 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6149 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6150
f868cd8a
JB
6151 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6152
6153 * keyboard.c (timer_check): Remove parameter `do_it_now',
6154 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6155 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6156 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6157
6158 * keyboard.c (read_char):
6159 * w32menu.c (w32_menu_display_help):
6160 * xmenu.c (show_help_event, menu_help_callback):
6161 Adjust calls to `show_help_echo'.
6162
6163 * gtkutil.c (xg_maybe_add_timer):
6164 * keyboard.c (readable_events):
6165 * process.c (wait_reading_process_output):
6166 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6167
6168 * insdel.c (adjust_markers_gap_motion):
6169 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6170 (gap_left, gap_right): Don't call it.
6171
2ecf6fdb
CY
61722011-03-25 Chong Yidong <cyd@stupidchicken.com>
6173
6174 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6175 incurred during fontification.
6176
6b1f9ba4
JB
61772011-03-25 Juanma Barranquero <lekktu@gmail.com>
6178
6179 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6180 (DEFVAR_PER_BUFFER): Don't pass it.
6181
6182 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6183 (scrolling_window): Don't pass it.
6184
0f4a96b5
JB
61852011-03-25 Juanma Barranquero <lekktu@gmail.com>
6186
6187 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6188
6189 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6190 and `suffix'.
6191 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6192 of variables specific to SELinux and computation of `encoded_absname'.
6193
6194 * image.c (XPutPixel): Remove unused variable `height'.
6195
6196 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6197
6198 * unexw32.c (get_section_info): Remove unused variable `section'.
6199
6200 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6201 (system_process_attributes): Remove unused variable `sess'.
6202 (sys_read): Remove unused variable `err'.
6203
6204 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6205 (w32_wnd_proc): Remove unused variable `isdead'.
6206 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6207 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6208 (x_create_tip_frame): Remove unused variable `tem'.
6209
6210 * w32inevt.c (w32_console_read_socket):
6211 Remove unused variable `no_events'.
6212
6213 * w32term.c (x_draw_composite_glyph_string_foreground):
6214 Remove unused variable `width'.
6215
1149507c
JB
62162011-03-24 Juanma Barranquero <lekktu@gmail.com>
6217
6218 * w32term.c (x_set_glyph_string_clipping):
6219 Don't pass uninitialized region to CombineRgn.
6220
9c88f339
JB
62212011-03-23 Juanma Barranquero <lekktu@gmail.com>
6222
6223 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6224 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6225 (Fx_close_connection): Remove unused variable `i'.
6226
6227 * w32font.c (w32font_draw): Return number of glyphs.
6228 (w32font_open_internal): Remove unused variable `i'.
6229 (w32font_driver): Add missing initializer.
6230
6231 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6232 (fill_in_menu): Remove unused variable `items_added'.
6233
6234 * w32term.c (last_mouse_press_frame): Remove static global variable.
6235 (w32_clip_to_row): Remove unused variable `f'.
6236 (x_delete_terminal): Remove unused variable `i'.
6237
6238 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6239 (NOTHING): Remove unused static global variable.
6240 (uniscribe_check_otf): Remove unused variable `table'.
6241 (uniscribe_font_driver): Add missing initializers.
6242
dee091a3
JD
62432011-03-23 Julien Danjou <julien@danjou.info>
6244
6245 * term.c (Fsuspend_tty, Fresume_tty):
6246 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6247 * window.c (temp_output_buffer_show):
6248 * insdel.c (signal_before_change):
6249 * frame.c (Fhandle_switch_frame):
6250 * fileio.c (Fdo_auto_save):
6251 * emacs.c (Fkill_emacs):
6252 * editfns.c (save_excursion_restore):
6253 * cmds.c (internal_self_insert):
6254 * callint.c (Fcall_interactively):
6255 * buffer.c (Fkill_all_local_variables):
6256 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6257 Use Frun_hooks.
0f4a96b5 6258 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6259 unconditionnaly since it does the check itself.
6260
2c520ab5 62612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6262
c9c49752
PE
6263 Fix more problems found by GCC 4.5.2's static checks.
6264
8abc3f12
PE
6265 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6266 the first time through the loop, since we know p0 < p1 then.
6267 This also avoids a gcc -Wstrict-overflow warning.
6268
a2d26660
PE
6269 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6270 leading to a memory leak, possible in functions like
6271 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6272 of objects (Bug#8318).
a2d26660 6273
916c72e9
PE
6274 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6275 that could (at least in theory) be that large.
6276
19ab8a18
PE
6277 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6278 This is less likely to overflow, and avoids undefined behavior if
6279 overflow does occur. All callers changed. Use strtoul to scan
6280 for the unsigned long integer.
b7cbbd6f
PE
6281 (pint2hrstr): Simplify and tune code slightly.
6282 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6283
f0641eff
PE
6284 * scroll.c (do_scrolling): Work around GCC bug 48228.
6285 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6286
7f650bb9
PE
6287 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6288 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6289 (validate_x_resource_name): Simplify count usage.
6290 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6291
37dd57d1
PE
6292 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6293 fail (Bug#8306).
81e56e61 6294
699979fc 6295 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6296
401bf9b4
PE
6297 * process.c (Fmake_network_process): Use socklen_t, not int,
6298 where POSIX says socklen_t is required in portable programs.
6299 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6300 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6301 (Fmake_network_process, server_accept_connection):
6302 (wait_reading_process_output, read_process_output):
6303 Likewise.
6304
b93aacde
PE
6305 * process.c: Rename or move locals to avoid shadowing.
6306 (list_processes_1, Fmake_network_process):
6307 (read_process_output_error_handler, exec_sentinel_error_handler):
6308 Rename or move locals.
4dc343ee 6309 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6310 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6311 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6312 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6313 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6314
af8a867c 6315 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6316 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6317 Include tparam.h instead, since it declares them.
af8a867c
PE
6318 * cm.h (PC): Remove extern decl; tparam.h now does this.
6319 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6320 * terminfo.c: Include tparam.h, to check interfaces.
6321 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6322 (tparam): Adjust signature to match interface in tparam.h;
6323 this removes some undefined behavior. Check that outstring and len
6324 are zero, which they always are with Emacs.
6325 * tparam.h (PC, BC, UP): New extern decls.
6326
0248044d 6327 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6328 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6329
8ff096c1 6330 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6331 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6332 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6333 (ftfont_list): Remove unused local.
49eaafba
PE
6334 (get_adstyle_property, ftfont_pattern_entity):
6335 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6336 Rename locals to avoid shadowing.
8ff096c1 6337
e2be39f6
PE
6338 * xfont.c (xfont_list_family): Mark var as initialized.
6339
c9735e30
PE
6340 * xml.c (make_dom): Now static.
6341
8f5201ae
PE
6342 * composite.c (composition_compute_stop_pos): Rename local to
6343 avoid shadowing.
b246f932
PE
6344 (composition_reseat_it): Remove unused locals.
6345 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6346 (composition_update_it): Mark var as initialized.
11b61122
PE
6347 (find_automatic_composition): Mark vars as initialized,
6348 with a FIXME (Bug#8290).
8f5201ae 6349
760fbc2c
PE
6350 character.h: Rename locals to avoid shadowing.
6351 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6352 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6353 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6354 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6355 to avoid shadowing.
6356
ff08eb85
PE
6357 * textprop.c (property_change_between_p): Remove; unused.
6358
fc7bf025
PE
6359 * intervals.c (interval_start_pos): Now static.
6360
235d7abc
PE
6361 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6362
44f230aa
SM
6363 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6364 Rename locals to avoid shadowing.
3e7d6594 6365
50060332
PE
6366 * sound.c (wav_play, au_play, Fplay_sound_internal):
6367 Fix pointer signedness.
d01f234b 6368 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6369 (wav_play): Initialize a variable to 0, to prevent undefined
6370 behavior (Bug#8278).
50060332 6371
c4fc4e30
PE
6372 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6373
918436ed
PE
6374 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6375
c939f91b
PE
6376 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6377 clobbering (Bug#8298).
b9c7f648
PE
6378 * sysdep.c (sys_subshell): Likewise.
6379 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6380
6bd8c144
PE
6381 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6382 This should get cleaned up, so that child_setup has the
6383 same signature on all platforms.
6384
7710357c 6385 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6386 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6387
c59da222
CY
63882011-03-22 Chong Yidong <cyd@stupidchicken.com>
6389
6390 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6391 not to be necessary, and produces flickering.
6392
66b87493
GM
63932011-03-20 Glenn Morris <rgm@gnu.org>
6394
6395 * config.in: Remove file.
6396
45b6f6d5
JB
63972011-03-20 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6400 are now in src/globals.h.
6401 (syms_of_minibuf): Remove spurious & from previous change.
6402
3ec03f7e
LL
64032011-03-20 Leo <sdl.web@gmail.com>
6404
6405 * minibuf.c (completing-read-function): New variable.
6406 (completing-read-default): Rename from completing-read.
6407 (completing-read): Call completing-read-function.
6408
b14e3e21
CY
64092011-03-19 Juanma Barranquero <lekktu@gmail.com>
6410
6411 * xfaces.c (Fx_load_color_file):
6412 Read color file from absolute filename (bug#8250).
6413
f2b726e6
JB
64142011-03-19 Juanma Barranquero <lekktu@gmail.com>
6415
6416 * makefile.w32-in: Update dependencies.
6417
09f6ff02
EZ
64182011-03-17 Eli Zaretskii <eliz@gnu.org>
6419
6420 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6421
29a6015a
PE
64222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6423
a3a6c54e
PE
6424 Fix more problems found by GCC 4.5.2's static checks.
6425
b766f867
PE
6426 * process.c (make_serial_process_unwind, send_process_trap):
6427 (sigchld_handler): Now static.
6428
be02381c
PE
6429 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6430 That way, the code declares only the vars that it needs.
6431 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6432 * s/cygwin.h (PTY_ITERATION): Likewise.
6433 * s/darwin.h (PTY_ITERATION): Likewise.
6434 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6435
57048744
PE
6436 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6437 * process.c (allocate_pty): Don't declare stb unless it's needed.
6438
7914961c 6439 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6440 (CONSTANTLIM): Remove; unused.
6441 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6442 Define only if needed.
7914961c 6443
b3967b18
PE
6444 * unexelf.c (unexec): Name an expression,
6445 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6446 Use a different way to cause a compilation error if anyone uses
6447 n rather than nn, a way that does not involve shadowing.
73366a00 6448 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6449
29a6015a
PE
6450 * deps.mk (unexalpha.o): Remove; unused.
6451
43cfc33e 6452 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6453 * unexec.h: New file.
ce701a33
PE
6454 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6455 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6456 Depend on unexec.h.
6457 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6458 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6459 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6460 Change as necessary to match prototype in unexec.h.
ce701a33 6461
01f44d5a
PE
6462 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6463 shadowing.
4f63c6bb 6464 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6465
a6670b0b
PE
6466 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6467 Rename locals to avoid shadowing.
6468
cef2010d 6469 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6470 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6471
d4d7173a
PE
6472 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6473
f08b802a
PE
6474 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6475 warning when compiling print.c.
6476
3ddb0639
PE
6477 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6478 instead of using an uninitialized var.
5ad03b97 6479 (font_sort_entities): Mark var as initialized.
3ddb0639 6480
170a2692
PE
6481 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6482
e663c700
PE
6483 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6484 pointers to constants.
89bc529a 6485 (font_parse_fcname): Remove unused vars.
7b81e2d0 6486 (font_delete_unmatched): Now static.
ea838e10 6487 (font_get_spec): Remove; unused.
13a547c6
PE
6488 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6489 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6490 Rename or move locals to avoid shadowing.
e663c700 6491
2a80c887 6492 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6493 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6494
1384fa33 6495 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6496 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6497
8b2c52e9
PE
6498 * alloc.c (mark_backtrace): Move decl from here ...
6499 * lisp.h: ... to here, so that it can be checked.
6500
475545b5 6501 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6502 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6503 (lisp_indirect_variable): Name an expression,
6504 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6505 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6506
b1349114 6507 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6508 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6509 Use const pointer when appropriate.
b1349114 6510
a2928364
PE
6511 * lisp.h (get_system_name, get_operating_system_release):
6512 Move decls here, to check interfaces.
6513 * process.c (get_operating_system_release): Move decl to lisp.h.
6514 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6515 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6516 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6517 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6518 (Fformat_time_string, Fencode_time, Finsert_char):
6519 (Ftranslate_region_internal, Fformat):
6520 Rename or remove local vars to avoid shadowing.
9710023e 6521 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6522
a415e694
PE
6523 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6524 avoid shadowing.
6525
8ef4622d
PE
6526 * lisp.h (eassert): Check that the argument compiles, even if
6527 ENABLE_CHECKING is not defined.
6528
946f9a5b
PE
6529 * data.c (Findirect_variable): Name an expression, to avoid
6530 gcc -Wbad-function-cast warning.
112396d6 6531 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6532 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6533 (Fmake_variable_buffer_local, Fmake_local_variable):
6534 Mark variables as initialized.
52746918 6535 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6536
e5aab7e7 6537 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6538 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6539 Rename locals to avoid shadowing.
dff45157
PE
6540 (mark_stack): Move local variables into the #ifdef region where
6541 they're used.
7bc26fdb
PE
6542 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6543 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6544 needed otherwise.
6545 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6546 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6547 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6548
e5aab7e7
PE
6549 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6550 avoids undefined behavior in theory.
6551
4da60324
PE
6552 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6553
88043301
PE
6554 Use functions, not macros, for up- and down-casing (Bug#8254).
6555 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6556 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6557 to use the following functions instead of these macros.
6558 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6559 EMACS_INT, since callers assume the returned value fits in int.
6560 (upcase1): Likewise, for UPCASE_TABLE.
6561 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6562 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6563 the race-condition problem in the old DOWNCASE.
88043301 6564
19ed5445
PE
6565 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6566 Rename locals to avoid shadowing.
6567 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6568 (regex_compile, re_search_2, re_match_2_internal):
6569 Remove unused local vars.
952db0d7
PE
6570 (FREE_VAR): Rewrite so as not to use empty "else",
6571 which gcc can warn about.
da053e48 6572 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6573 (RETALLOC_IF): Define only if needed.
6574 (WORDCHAR_P): Likewise. This one is never needed, but is used
6575 only in a comment talking about a compiler bug, so put inside
6576 the #if 0 of that comment.
6577 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6578 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6579 Remove; unused.
19ed5445 6580
1f3561e4 6581 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6582 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6583 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6584
ded6f8f7
PE
6585 * search.c (simple_search): Remove unused var.
6586
dbd37a95
PE
6587 * dired.c (compile_pattern): Move decl from here ...
6588 * lisp.h: ... to here, so that it can be checked.
6589 (struct re_registers): New forward decl.
6590
7e47afad
PE
6591 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6592
85f24f61
PE
6593 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6594 All uses changed.
6595 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6596 Rename locals to avoid shadowing.
5671df8f 6597 (Fvertical_motion): Mark locals as initialized.
85f24f61 6598
181aa2be 6599 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6600 (casify_region): Mark local as initialized.
181aa2be 6601
930d429c
PE
6602 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6603
7082eac6
PE
6604 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6605 New macros, so that the caller can use some names other than
6606 gcpro1, gcpro2, etc.
6607 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6608 of the new macros.
6609 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6610 argument, for consistency with GCPRO2_VAR, etc: it is now the
6611 prefix of the variable, not the variable itself. All uses
6612 changed.
38b2c076
PE
6613 * dired.c (directory_files_internal, file_name_completion):
6614 Rename locals to avoid shadowing.
6615
15206ed9
PE
6616 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6617 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6618 dired.c's scmp function, had undefined behavior.
6619 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6620 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6621 * buffer.h: ... to here, because these macros use current_buffer,
6622 and the new implementation with inline functions needs to have
6623 current_buffer in scope now, rather than later when the macros
6624 are used.
6625 (downcase, upcase1): New static inline functions.
6626 (DOWNCASE, UPCASE1): Reimplement using these functions.
6627 This avoids undefined behavior in expressions like
6628 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6629 from race conditions in accessing the global variables
6630 case_temp1 and case_temp2.
6631 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6632 * lisp.h (case_temp1, case_temp2): Remove their decls.
6633 * character.h (ASCII_CHAR_P): Move from here ...
6634 * lisp.h: ... to here, so that the inline functions mentioned
6635 above can use them.
6636
4a6bea26
PE
6637 * dired.c (directory_files_internal_unwind): Now static.
6638
f14b7e14
PE
6639 * fileio.c (file_name_as_directory, directory_file_name):
6640 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6641 Now static.
2893f146
PE
6642 (file_name_as_directory): Use const pointers when appropriate.
6643 (Fexpand_file_name): Likewise. In particular, newdir might
6644 point at constant storage, so make it a const pointer.
fd4ead52 6645 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6646 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6647 signedness issues.
f839df0c
PE
6648 (Fset_file_times, Finsert_file_contents, auto_save_error):
6649 Rename locals to avoid shadowing.
f14b7e14 6650
5716756e 6651 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6652 (Ftry_completion, Fall_completions): Rename or remove locals
6653 to avoid shadowing.
5716756e 6654
b4c3046a
PE
6655 * marker.c (bytepos_to_charpos): Remove; unused.
6656
b45db522
PE
6657 * lisp.h (verify_bytepos, count_markers): New decls,
6658 so that gcc does not warn that these functions aren't declared.
6659
85876d07
PE
6660 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6661 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6662 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6663 (copy_text): Remove unused local var.
85876d07 6664
03d78a21 6665 * filelock.c (within_one_second): Now static.
b3dd38ab 6666 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6667
5df8f01b
PE
6668 * buffer.c (fix_overlays_before): Mark locals as initialized.
6669 (fix_start_end_in_overlays): Likewise. This function should be
6670 simplified by using pointers-to-pointers, but that's a different
6671 matter.
b1d876f1 6672 (switch_to_buffer_1): Now static.
8f54f30a
PE
6673 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6674 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6675
a70072c9 6676 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6677 Fix pointer signedness issue.
edced198
PE
6678 (sys_subshell): Mark local as volatile if checking for lint,
6679 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6680 (MAXPATHLEN): Define only if needed.
a70072c9 6681
a0977c44
PE
6682 * process.c (serial_open, serial_configure): Move decls from here ...
6683 * systty.h: ... to here, so that they can be checked.
6684
a884fdcc
PE
6685 * fns.c (get_random, seed_random): Move extern decls from here ...
6686 * lisp.h: ... to here, so that they can be checked.
6687
604efe86 6688 * sysdep.c (reset_io): Now static.
b8950c94 6689 (wait_for_termination_signal): Remove; unused.
604efe86 6690
38fc62d9
PE
6691 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6692 (copy_keymap_item, append_key, push_text_char_description):
6693 Now static.
1004a21a 6694 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6695 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6696 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6697 (describe_map_tree):
6698 Rename locals to avoid shadowing.
38fc62d9 6699
2f2650da
PE
6700 * keyboard.c: Declare functions static if they are not used elsewhere.
6701 (echo_char, echo_dash, cmd_error, top_level_2):
6702 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6703 (read_char, kbd_buffer_get_event, make_lispy_position):
6704 (make_lispy_event, make_lispy_movement, apply_modifiers):
6705 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6706 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6707 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6708 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6709 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6710
a053e86c 6711 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6712 (mark_kboards): Move decl here ...
6713 * alloc.c (mark_kboards): ... from here.
a053e86c 6714
4752793e
PE
6715 * lisp.h (force_auto_save_soon): New decl.
6716
74f10ca7 6717 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6718 (DEFINE_DUMMY_FUNCTION): New macro.
6719 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6720 Use it.
c03cd23f
PE
6721 (main): Add casts to avoid warnings
6722 if GCC considers string literals to be constants.
74f10ca7 6723
022e70d4
PE
6724 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6725
59d6fe83
PE
6726 * dbusbind.c: Pointer signedness fixes.
6727 (xd_signature, xd_append_arg, xd_initialize):
6728 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6729 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6730 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6731 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6732
78320123
PE
6733 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6734 if GCC considers string literals to be constants.
49cebcca 6735 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6736
35ac2a97
SM
67372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6738
fb103ca9
SM
6739 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6740 (print_preprocess, print_object): New macro to fix last change.
6741
35ac2a97
SM
6742 * print.c (print_preprocess): Don't forget font objects.
6743
62973b41
JB
67442011-03-16 Juanma Barranquero <lekktu@gmail.com>
6745
6746 * emacs.c (USAGE3): Doc fixes.
6747
0e48bb22
AS
67482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6749
6750 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6751 structure.
6752
7684e57b
JB
67532011-03-14 Juanma Barranquero <lekktu@gmail.com>
6754
6755 * lisp.h (VWindow_system, Qfile_name_history):
6756 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6757 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6758 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6759
6760 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6761 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6762
6763 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6764 * w32console.c (detect_input_pending, read_input_pending)
6765 (encode_terminal_code):
6766 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6767 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6768 (w32_system_caret_y, Qfile_name_history):
6769 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6770 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6771 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6772 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6773 * w32proc.c (Qlocal, report_file_error):
6774 * w32term.c (Vwindow_system, updating_frame):
6775 * w32uniscribe.c (initialized, uniscribe_font_driver):
6776 Remove unneeded extern declarations.
6777
2aa46d6c
CY
67782011-03-14 Chong Yidong <cyd@stupidchicken.com>
6779
c96bbc66 6780 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6781
cffc6f3b
CY
67822011-03-13 Chong Yidong <cyd@stupidchicken.com>
6783
6784 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6785 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6786 These macros can no longer be used for assignment.
6787
44f230aa
SM
6788 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6789 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6790 (record_buffer_markers, fetch_buffer_markers): New functions for
6791 recording and fetching special buffer markers.
6792 (set_buffer_internal_1, set_buffer_temp): Use them.
6793
6794 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6795
6796 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6797
6798 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6799 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6800
6801 * xdisp.c (hscroll_window_tree):
6802 (reconsider_clip_changes): Use PT instead of BUF_PT.
6803
d251f04b
EZ
68042011-03-13 Eli Zaretskii <eliz@gnu.org>
6805
6806 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6807 $(EMACS_ROOT)/lib/intprops.h.
6808
f0c77cd1
PE
68092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6810
3eca4629
PE
6811 Fix more problems found by GCC 4.5.2's static checks.
6812
7c86ee98
PE
6813 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6814 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6815 (xg_free_frame_widgets): Make it clear that a local variable is
6816 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6817 (gdk_window_get_screen): Make it clear that this macro is needed
6818 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6819 (int_gtk_range_get_value): New function, which avoids a diagnostic
6820 from gcc -Wbad-function-cast.
6821 (xg_set_toolkit_scroll_bar_thumb): Use it.
6822 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6823 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6824 (get_utf8_string, xg_get_file_with_chooser):
6825 Rename locals to avoid shadowing.
6826 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6827
41729b81
PE
6828 * xgselect.c (xg_select): Remove unused var.
6829
f0c77cd1
PE
6830 * image.c (four_corners_best): Mark locals as initialized.
6831 (gif_load): Initialize transparent_p to zero (Bug#8238).
6832 Mark another local as initialized.
ec6cf4c6 6833 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6834
ce0ad53d 6835 * image.c (clear_image_cache): Now static.
d5d5a617 6836 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6837 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6838 (x_edge_detection): Remove unnecessary cast that
6839 gcc -Wbad-function-cast diagnoses.
2037898d 6840 (gif_load): Fix pointer signedness.
6ae141d6
PE
6841 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6842 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6843
33383987 68442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6845
d32df629
PE
6846 Improve quality of tests for time stamp overflow.
6847 For example, without this patch (encode-time 0 0 0 1 1
6848 1152921504606846976) returns the obviously-bogus value (-948597
6849 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6850 reports time overflow. See
6851 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6852 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6853 * editfns.c: Include limits.h and intprops.h.
6854 (TIME_T_MIN, TIME_T_MAX): New macros.
6855 (time_overflow): Move earlier, to before first use.
6856 (hi_time, lo_time): New functions, for an accurate test for
6857 out-of-range times.
6858 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6859 (Fget_internal_run_time): Don't assume time_t fits in int.
6860 (make_time): Use list2 instead of Fcons twice.
6861 (Fdecode_time): More accurate test for out-of-range times.
6862 (check_tm_member): New function.
6863 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6864 (lisp_time_argument): Don't rely on undefined left-shift and
6865 right-shift behavior when checking for time stamp overflow.
8be6f318 6866
fe31d94c
PE
6867 * editfns.c (time_overflow): New function, refactoring common code.
6868 (Fformat_time_string, Fdecode_time, Fencode_time):
6869 (Fcurrent_time_string): Use it.
6870
8be6f318
PE
6871 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6872 * dired.c (make_time): Move to ...
6873 * editfns.c (make_time): ... here.
6874 * systime.h: Note the move.
6875
09d9db2c 68762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6877
126bc0dc
YM
6878 * fringe.c (update_window_fringes): Remove unused variables.
6879
c47cbdfd
YM
6880 * unexmacosx.c (copy_data_segment): Also copy __got section.
6881 (Bug#8223)
6882
7ac80be9
EZ
68832011-03-12 Eli Zaretskii <eliz@gnu.org>
6884
c96bbc66 6885 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6886 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6887 Constify `char *' arguments and their references according to
6888 prototypes in tparam.h.
6889
ecb0f94d 6890 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6891
7ac80be9
EZ
6892 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6893 Adapt all references accordingly.
6894
6895 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6896
ef1fd07e
TT
68972011-03-11 Tom Tromey <tromey@redhat.com>
6898
6899 * buffer.c (syms_of_buffer): Remove obsolete comment.
6900
7ef4b50c
EZ
69012011-03-11 Eli Zaretskii <eliz@gnu.org>
6902
6903 * termhooks.h (encode_terminal_code): Declare prototype.
6904
6905 * msdos.c (encode_terminal_code): Don't declare prototype.
6906
6907 * term.c (encode_terminal_code): Now external again, used by
6908 w32console.c and msdos.c.
6909
44f230aa
SM
6910 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6911 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6912
4b1ec863 69132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6914
1714f52b 6915 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6916
4b1ec863
PE
6917 * fringe.c (update_window_fringes): Mark locals as initialized
6918 (Bug#8227).
6919 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6920
524c7aa6
PE
6921 * alloc.c (mark_fringe_data): Move decl from here ...
6922 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6923 to check its interface.
6924 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6925
a5c0af81 6926 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6927 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6928 (fontset_font): Mark local as initialized.
a9a06e0b 6929 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6930
b4716021
PE
6931 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6932
811e9bac 6933 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6934 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6935 (x_own_selection, Fx_disown_selection_internal): Rename locals
6936 to avoid shadowing.
6937 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6938
7e3ab302
PE
6939 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6940 so that the caller can use some name other than gcpro1.
6941 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6942 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6943 (Fx_backspace_delete_keys_p):
6944 Use them to avoid shadowing, and rename vars to avoid shadowing.
6945 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6946 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6947 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6948 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6949 Remove unused locals.
7e3ab302
PE
6950 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6951 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6952 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6953 macros.
f78faa98 6954
e2b13473
PE
6955 * xterm.h (x_mouse_leave): New decl.
6956
77f23912
PE
6957 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6958 Remove unused functions.
cdf4ba58
PE
6959 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6960 (x_calc_absolute_position): Now static.
7411c686 6961 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6962 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6963 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6964 unless they are used.
38d0b34a
PE
6965 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6966 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6967 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6968 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6969 (x_error_catcher, x_connection_closed, x_error_handler):
6970 (x_error_quitter, xembed_send_message, x_iconify_frame):
6971 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6972 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6973 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6974
44f230aa
SM
6975 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6976 Rename or move locals to avoid shadowing.
6b463e58 6977 (tty_defined_color, merge_face_heights): Now static.
5967d051 6978 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6979 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6980 does not deduce is never used uninitialized.
73719eba
PE
6981 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6982 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6983
426994c3 6984 * terminal.c (store_terminal_param): Now static.
5489860b 6985
032f1620 6986 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6987 (set_frame_menubar): Remove unused local.
d4323972 6988 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6989 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6990 since they might point to immutable storage.
281585b0
PE
6991 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6992 since it's unused otherwise.
032f1620 6993
367c19e5 6994 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6995 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6996 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6997 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6998 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6999 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7000 does not deduce are never used uninitialized.
70739cbe 7001
07b48fa9
PE
7002 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7003
8868a238 7004 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7005 * window.c (window_loop, size_window):
7006 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7007
7e5cf297 7008 * window.c (display_buffer): Now static.
d6550a9f
PE
7009 (size_window): Mark variables that gcc -Wuninitialized
7010 does not deduce are never used uninitialized.
a586633d
PE
7011 * window.h (check_all_windows): New decl, to forestall
7012 gcc -Wmissing-prototypes diagnostic.
5b555da1 7013 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7014
f6095868
PE
7015 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7016 shadowing.
7017 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7018 Include <limits.h>.
7019 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7020 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7021 (load_charset_map): Mark variables that gcc -Wuninitialized
7022 does not deduce are never used uninitialized.
53df7c11 7023 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7024
f38b440c
PE
7025 * coding.c (coding_set_source, coding_set_destination):
7026 Use "else { /* comment */ }" rather than "else /* comment */;"
7027 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7028 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7029 a block, when the outer 'i' will do.
7030 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7031 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7032 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7033 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7034 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7035 Rename locals to avoid shadowing.
7036 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7037 * coding.c (emacs_mule_char, encode_invocation_designation):
7038 Now static, since they're not used elsewhere.
413bb2db 7039 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7040 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7041 (decode_coding_emacs_mule): Mark variables that gcc
7042 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7043 (detect_coding_iso_2022): Initialize a local variable that might
7044 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7045 this initialization is needed. (Bug#8211)
5f58e762
PE
7046 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7047 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7048 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7049 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7050 Remove unused macros.
f38b440c 7051
232b38b9 7052 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7053 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7054 * character.c (string_count_byte8): Likewise.
232b38b9 7055
fb90da1b
PE
7056 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7057 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7058
fb93dbc2
PE
7059 * chartab.c (copy_sub_char_table): Now static, since it's not used
7060 elsewhere.
5c156ace
PE
7061 (sub_char_table_ref_and_range, char_table_ref_and_range):
7062 Rename locals to avoid shadowing.
bbcd0949 7063 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7064
7d3b3862 7065 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7066 (BIDI_BOB): Remove unused macro.
7d3b3862 7067
6be7d3da
PE
7068 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7069 deduce are never used uninitialized.
c2ed9c8b 7070 * term.c (encode_terminal_code): Likewise.
6be7d3da 7071
75f8807f 7072 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7073
50938595
PE
7074 * tparam.h: New file.
7075 * term.c, tparam.h: Include it.
7076 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7077 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7078 Move these decls to tparam.h, and make them agree with what
7079 is actually in tparam.c. The previous trick of using incompatible
7080 decls in different modules does not conform to the C standard.
7081 All callers of tparam changed to use tparam's actual API.
7082 * tparam.c (tparam1, tparam, tgoto):
7083 Use const pointers where appropriate.
7084
fbceeba2
PE
7085 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7086 * cm.h (struct cm): Likewise.
7087 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7088 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7089 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7090 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7091 (turn_on_face, init_tty): Likewise.
7092 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7093
7f3f1250
PE
7094 * term.c (term_mouse_position): Rename local to avoid shadowing.
7095
e6ca6543
PE
7096 * alloc.c (mark_ttys): Move decl from here ...
7097 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7098
c40f8d15
AS
70992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7100
7101 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7102
cfe0661d
JB
71032011-03-09 Juanma Barranquero <lekktu@gmail.com>
7104
7105 * search.c (compile_pattern_1): Remove argument regp, unused since
7106 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7107 (compile_pattern): Don't pass it.
7108
0afb4571
J
71092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7110
7111 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7112 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7113 for ! HAVE_GTK3.
7114 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7115
7116 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7117
7118 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7119 gdk_window_get_screen, gdk_window_get_geometry,
7120 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7121 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7122 (xg_get_pixbuf_from_pixmap): New function.
7123 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7124 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7125 Call xg_get_pixbuf_from_pixmap instead of
7126 gdk_pixbuf_get_from_drawable.
7127 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7128 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7129 (xg_check_special_colors): Use GtkStyleContext and its functions
7130 for HAVE_GTK3.
7131 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7132 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7133 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7134 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7135 Call gtk_widget_get_preferred_size.
0afb4571
J
7136 (xg_frame_resized): gdk_window_get_geometry only takes 5
7137 parameters.
44f230aa
SM
7138 (xg_win_to_widget, xg_event_is_for_menubar):
7139 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7140 (xg_set_widget_bg): New function.
7141 (delete_cb): New function.
895009e1 7142 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7143 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7144 (xg_set_background_color): Call xg_set_widget_bg.
7145 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7146 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7147 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7148 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7149 if ! HAVE_GTK3.
7150 (update_frame_tool_bar): Call gtk_widget_hide.
7151 (xg_initialize): Use GDK_KEY_g.
7152
7153 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7154 if ! HAVE_GTK3
7155 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7156
7157 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7158 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7159 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7160
1c2cc4ef
JB
71612011-03-08 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * w32xfns.c (select_palette): Check success of RealizePalette against
7164 GDI_ERROR, not zero.
7165
33383987 7166See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7167
7168;; Local Variables:
7169;; coding: utf-8
aac0c6e3
MR
7170;; End:
7171
33383987 7172 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7173
7174 This file is part of GNU Emacs.
7175
7176 GNU Emacs is free software: you can redistribute it and/or modify
7177 it under the terms of the GNU General Public License as published by
7178 the Free Software Foundation, either version 3 of the License, or
7179 (at your option) any later version.
7180
7181 GNU Emacs is distributed in the hope that it will be useful,
7182 but WITHOUT ANY WARRANTY; without even the implied warranty of
7183 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7184 GNU General Public License for more details.
7185
7186 You should have received a copy of the GNU General Public License
7187 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.