Add Bug#.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2be7d702 12011-08-30 Paul Eggert <eggert@cs.ucla.edu>
62f19c19 2
0999621a 3 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
2be7d702
PE
23 * dbusbind.c (signature_cat): New function.
24 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
25 Do not overrun buffer; instead, report string overflow.
26
9d1df220
PE
27 * dispnew.c (add_window_display_history): Don't overrun buffer.
28 Truncate instead; this is OK since it's just a log.
29
33ef5c64
PE
30 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
31 even if the time zone offset is outlandishly large.
32 Don't mishandle offset == INT_MIN.
33
66c6fdd5
PE
34 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
35 when creating daemon; the previous buffer-overflow check was incorrect.
36
d749b01b
PE
37 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
38 which has the guts of the old verror function.
39
b5cd1905
PE
40 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
41 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
42
6e1a67fb
PE
43 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
44 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc
PE
45 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
46 fits in int, when using sprintf. Use single snprintf to count
47 length of string rather than counting it via multiple sprintfs;
48 that's simpler and more reliable.
49 (APPEND_SPRINTF): New macro.
50 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
51 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
52 sprintf, in case result does not fit in int.
53
c57b67fc
PE
54 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
55 (fontset_from_font): Print it.
56
8a401434
PE
57 * frame.c (tty_frame_count): Now printmax_t, not int.
58 (make_terminal_frame, set_term_frame_name): Print it.
59 (x_report_frame_params): In X, window IDs are unsigned long,
60 not signed long, so print them as unsigned.
61 (validate_x_resource_name): Check for implausibly long names,
62 and don't assume name length fits in 'int'.
63 (x_get_resource_string): Don't blindly alloca invocation name;
64 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
65 not fit in int.
66
6e1a67fb
PE
67 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
68 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
69 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
70
0df02bf3
PE
71 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
72 Use esprintf, not sprintf, in case result does not fit in int.
73
48e30793
PE
74 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
75 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
76 it as a large positive number.
77 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
78 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
79
a66ff6d8
PE
80 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
81 in case result does not fit in int.
82
aca216ff
PE
83 * print.c (float_to_string): Detect width overflow more reliably.
84 (print_object): Make sprintf buffer a bit bigger, to avoid potential
85 buffer overrun. Don't assume list length fits in 'int'. Treat
86 print length of 0 as 0, not as infinity; to be consistent with other
87 uses of print length in this function. Don't overflow print length
88 index. Don't assume hash table size fits in 'long', or that
89 vectorlike size fits in 'unsigned long'.
90
31c286f7
PE
91 * process.c (make_process): Use printmax_t, not int, to format
92 process-name gensyms.
93
80f2e268
PE
94 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
95 to avoid potential buffer overrun.
96
670741ab
PE
97 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
98 if X resource line is longer than 512 bytes.
99
b7163a50
PE
100 * xfns.c (x_window): Make sprintf buffer a bit bigger
101 to avoid potential buffer overrun.
102
ae58ff1f
PE
103 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
104
c43c8a6a
PE
105 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
106
148ae00e
EZ
1072011-08-30 Eli Zaretskii <eliz@gnu.org>
108
f6cfbd8f
EZ
109 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
110
148ae00e
EZ
111 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
112 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
113 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
114
115 * term.c (tty_append_glyph): New function.
116 (produce_stretch_glyph): Static function and its prototype deleted.
117
118 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
119 prototypes.
120
c4a07a4c
PE
1212011-08-29 Paul Eggert <eggert@cs.ucla.edu>
122
123 * image.c (parse_image_spec): Check for nonnegative, not for positive,
124 when checking :margin (Bug#9390).
125 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
126 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
127 so that the name doesn't mislead. All uses changed.
128
6bc8cd65
JB
1292011-08-28 Johan Bockgård <bojohan@gnu.org>
130
131 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
132 set_tty_hooks.
133
dca4927e
EZ
1342011-08-27 Eli Zaretskii <eliz@gnu.org>
135
136 * xdisp.c (move_it_to): Don't bail out early when reaching
137 position beyond to_charpos, if we are scanning backwards.
138 (move_it_vertically_backward): When DY == 0, make sure we get to
139 the first character in the line after the newline.
140
f2cad773
PE
1412011-08-27 Paul Eggert <eggert@cs.ucla.edu>
142
143 * ccl.c: Improve and simplify overflow checking (Bug#9196).
144 (ccl_driver): Do not generate an out-of-range pointer.
145 (Fccl_execute_on_string): Remove unnecessary check for
146 integer overflow, noted by Stefan Monnier in
147 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
148 Remove a FIXME that didn't need fixing.
149 Simplify the newly-introduced buffer reallocation code.
150
0cae2cdb
JB
1512011-08-27 Juanma Barranquero <lekktu@gmail.com>
152
153 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
154
5fc295a4 1552011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 156
70c60eb2 157 Integer and memory overflow issues (Bug#9196).
726e0ab1 158
d31850da
PE
159 * doc.c (get_doc_string): Rework so that
160 get_doc_string_buffer_size is the actual buffer size, rather than
161 being 1 less than the actual buffer size; this makes xpalloc more
162 convenient.
163
a69fbedb
PE
164 * image.c (x_allocate_bitmap_record, cache_image):
165 * xselect.c (Fx_register_dnd_atom):
166 Simplify previous changes by using xpalloc.
167
fe5c5d37
PE
168 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
169 since either will do and ptrdiff_t is convenient with xpalloc.
170
0065d054
PE
171 * charset.c (charset_table_size)
172 (struct charset_sort_data.priority): Now ptrdiff_t.
173 (charset_compare): Don't overflow if priorities differ greatly.
174 (Fsort_charsets): Don't assume list length fits in int.
175 Check for size-calculation overflow when allocating sort data.
176 (syms_of_charset): Allocate an initial charset table that is
177 just under 64 KiB, to avoid problems with glibc malloc and mmap.
178
179 * cmds.c (internal_self_insert): Check for size-calculation overflow.
180
181 * composite.h (struct composition.glyph_len): Now int, not unsigned.
182 The actual value is always <= INT_MAX, and leaving it unsigned made
183 overflow checking harder.
184
185 * dispextern.h (struct glyph_matrix.rows_allocated)
186 (struct face_cache.size): Now ptrdiff_t, for convenience in use
187 with xpalloc. The values are still always <= INT_MAX.
188
189 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
190
191 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
192 (SAFE_NALLOCA): New macro.
193
194 * region-cache.c (struct boundary.pos, find_cache_boundary)
195 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
196 (set_cache_region, invalidate_region_cache)
197 (revalidate_region_cache, know_region_cache, region_cache_forward)
198 (region_cache_backward, pp_cache):
199 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
200 so that ptrdiff_t * can be passed to xpalloc.
201 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
202 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
203 (pp_cache): Don't assume cache_len fits in int.
204 * region-cache.h: Adjust extern decls to match.
205
206 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
207 EMACS_INT, since either will do, for xpalloc.
208
209 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
210 (xnmalloc, xnrealloc, xpalloc): New functions.
211
726e0ab1
PE
212 * bidi.c (bidi_shelve_header_size): New constant.
213 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
214 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
215
51f30bc5 216 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
217 * buffer.c (overlays_at, overlays_in, record_overlay_string)
218 (overlay_strings):
219 Don't update size of array until after memory allocation succeeds,
220 because xmalloc/xrealloc may not return.
0065d054
PE
221 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
222 now that we have proper integer overflow checking.
223 (record_overlay_string, overlay_strings): Catch overflows when
224 calculating size of overlay_str_buf.
726e0ab1 225
0065d054
PE
226 * callproc.c (Fcall_process): Check for size overflow when
227 calculating size of args2.
228 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
229 Normally we prefer signed values, but sticking with ptrdiff_t would
230 require adding more-complicated checks.
726e0ab1
PE
231
232 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
233 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
234 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 235 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
236
237 * character.c (Fstring): Check for size-calculation overflow.
238
239 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
240 unnecessary integer overflow. Check for size overflow.
241 (encode_coding_object): Don't update size until xmalloc succeeds.
242
243 * composite.c (get_composition_id): Check for overflow in glyph
244 length calculations.
245
246 Integer and memory overflow fixes for display code.
247 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
248 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
249 (scrolling_window): Check for overflow in size calculations.
250 (line_draw_cost, realloc_glyph_pool, add_row_entry):
251 Don't assume glyph table len fits in int.
252 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
253 (row_table_size): Now ptrdiff_t, not int.
254 (scrolling_window): Avoid overflow in size calculations.
255 Don't update size until allocation succeeds.
256 * fns.c (concat): Check for overflow in size calculations.
257 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
258 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
259 (NEXT_ALMOST_PRIME_LIMIT): New constant.
260
261 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
262 (get_doc_string): Check for size calculation overflow.
263 Don't update size until allocation succeeds.
264 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
265 EMACS_INT, where ptrdiff_t will do.
266 (Fsubstitute_command_keys): Check for string overflow.
267
268 * editfns.c (set_time_zone_rule): Don't assume environment length
269 fits in int.
270 (message_length): Now ptrdiff_t, not int.
271 (Fmessage_box): Don't update size until allocation succeeds.
272 Don't assume message length fits in int.
273 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
274
0065d054
PE
275 * emacs.c (main): Do not reallocate argv, since there is a null at
276 the end that can be overwritten, and this way there's no need to
277 worry about size-calculation overflow.
278 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
279
280 * eval.c (init_eval_once, grow_specpdl): Don't update size until
281 alloc succeeds.
282 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
283
284 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
285 (x_set_scroll_bar_width, x_figure_window_size):
286 Check for integer overflow.
287 (x_set_alpha): Do not assume XINT fits in int.
288
289 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
290 This is for the members text_lines, text_cols, total_lines, total_cols,
291 where the system imposes an 'int' limit.
292
293 * fringe.c (Fdefine_fringe_bitmap):
294 Don't update size until alloc works.
295
296 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
297 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
298
299 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
300 Check for size-calculation overflow.
301 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
302 do, as we prefer signed integers.
303 (id_to_widget.max_size, id_to_widget.used)
304 (xg_store_widget_in_map, xg_remove_widget_from_map)
305 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
306 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
307 Use and return ptrdiff_t, not int.
308 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
309 * gtkutil.h: Change prototypes to match the above.
310
311 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
312 are duplicate now that they've been promoted to lisp.h.
313 (x_allocate_bitmap_record, x_alloc_image_color)
314 (make_image_cache, cache_image, xpm_load):
315 Don't update size until alloc is done.
316 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
317 (x_detect_edges):
3256efce 318 Check for size calculation overflow.
726e0ab1
PE
319 (ct_colors_allocated_max): New constant.
320 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
321 overflow.
3256efce 322
726e0ab1
PE
323 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
324 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
325 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
326 Use ptrdiff_t, not int, to count maps.
327 (read_char_minibuf_menu_prompt): Check for overflow in size
328 calculations. Don't update size until allocation succeeds. Redo
329 calculations to avoid overflow.
330 * keyboard.h: Change prototypes to match the above.
331
332 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
333 to count maps.
334 (current_minor_maps): Check for size calculation overflow.
335 * keymap.h: Change prototypes to match the above.
336
337 * lread.c (read1, init_obarray): Don't update size until alloc done.
338
339 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
340 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
341
726e0ab1
PE
342 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
343 Now ptrdiff_t, not int.
344 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
345 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
346
347 * process.c (Fnetwork_interface_list): Check for overflow
348 in size calculation.
349
350 * region-cache.c (move_cache_gap): Check for size calculation overflow.
351
352 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
353 overflow. Don't bother calling xmalloc when xrealloc will do.
354
355 * search.c (Freplace_match): Check for size calculation overflow.
356 (Fset_match_data): Don't assume list lengths fit in 'int'.
357
358 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
359 for command line length. Do not attempt to address one before the
360 beginning of an array, as that's not portable.
361
362 * term.c (max_frame_lines): Remove; unused.
363 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
364 not int.
365 (encode_terminal_code, calculate_costs): Check for size
366 calculation overflow.
367 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
368 table lengths and related sizes. Don't update size until alloc
369 done. Redo calculations to avoid overflow.
370 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
371
372 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
373 subtracting pointers.
374 (gobble_line): Check for overflow more carefully. Don't update size
375 until alloc done.
376
377 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
378 Don't update size until alloc done.
379 Redo size calculations to avoid overflow.
380 Check for size calculation overflow.
0065d054 381 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
382
383 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
384 Use ptrdiff_t, not int, for sizes.
385 (store_mode_line_noprop_char): Don't update size until alloc done.
386
0065d054
PE
387 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
388 Use ptrdiff_t, not int, for sizes.
389 (Finternal_make_lisp_face, cache_face):
390 Check for size calculation overflow.
391 (cache_face): Treat size calculation overflows as if they were
392 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
393
394 * xfns.c (x_encode_text, x_set_name_internal)
395 (Fx_change_window_property): Use ptrdiff_t, not int, to count
396 sizes, since they can exceed INT_MAX in size. Check for size
397 calculation overflow.
398
0065d054
PE
399 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
400 (xg_select): Check for size calculation overflow.
726e0ab1
PE
401 Don't update size until alloc done.
402
0065d054 403 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 404 as sprintf is limited to int lengths.
1d526e2f 405
252c5ee1
PE
406 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
407 (X_LONG_MIN): New macros.
864d7ce7
PE
408 Use them to make the following changes clearer.
409 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
410 This change doesn't affect the value now, but it may help remind
411 future maintainers not to raise the value too much later.
412 (SELECTION_QUANTUM): Remove, replacing with ...
413 (selection_quantum): ... new function, which avoids overflow.
414 All uses changed.
415 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
416 assumption that selection length fits in 'int'.
417 (x_reply_selection_request, x_handle_selection_request)
418 (x_get_window_property, receive_incremental_selection)
419 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
420 (lisp_data_to_selection_data, clean_local_selection_data):
421 Use ptrdiff_t, not int, to record length of selection.
422 (x_reply_selection_request, x_get_window_property)
423 (receive_incremental_selection, x_property_data_to_lisp):
424 Redo calculations to avoid overflow.
425 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 426 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
427 something.
428 (x_get_window_property, receive_incremental_selection)
429 (lisp_data_to_selection_data, x_property_data_to_lisp):
430 Check for size-calculation overflow.
431 (x_get_window_property, receive_incremental_selection)
432 (lisp_data_to_selection_data, Fx_register_dnd_atom):
433 Don't store size until memory allocation succeeds.
434 (x_get_window_property): Plug memory leak on memory exhaustion.
435 Don't double-block input; malloc is safe here. Don't assume 2**34
436 - 4 fits in unsigned long. Add an xassert to check
437 XGetWindowProperty overflow. Be more careful about overflow
438 calculations, and distinguish size from memory overflow better.
439 (receive_incremental_selection): When tracing, don't assume
440 unsigned int is less than INT_MAX.
441 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
442 harmful) conversions of unsigned short to int.
443 (lisp_data_to_selection_data): Don't assume that integers
444 in the range -65535 through -1 fit in an X unsigned short.
445 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
446 result parameters unless successful. Rely on cons_to_unsigned
447 to report problems with elements; the old code wasn't right anyway.
448 (x_check_property_data): Check for int overflow; we cannot use
449 a wider type due to X limits.
450 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
451
726e0ab1 452 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 453
0065d054
PE
454 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
455 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
456 (x_color_cells): Don't store size until memory allocation succeeds.
457 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 458 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
459 (x_term_init): Don't assume length fits in int (sprintf is limited
460 to int size).
bc18e09d 461
ebfa62c0
PE
462 Use ptrdiff_t for composition IDs.
463 * character.c (lisp_string_width):
464 * composite.c (composition_table_size, n_compositions)
465 (get_composition_id, composition_gstring_from_id):
466 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
467 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
468 * window.c (Frecenter):
469 Use ptrdiff_t, not int, for composition IDs.
470 * composite.c (get_composition_id): Check for integer overflow.
471 * composite.h: Adjust prototypes to match the above changes.
472
d3411f89
PE
473 Use ptrdiff_t for hash table indexes.
474 * category.c (hash_get_category_set):
475 * ccl.c (ccl_driver):
476 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
477 * coding.c (coding_system_charset_list, detect_coding_system):
478 * coding.h (struct coding_system.id):
479 * composite.c (get_composition_id, gstring_lookup_cache):
480 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
481 * image.c (xpm_get_color_table_h):
482 * lisp.h (hash_lookup, hash_put):
483 * minibuf.c (Ftest_completion):
484 Use ptrdiff_t for hash table indexes, not int (which is too
485 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
486 32-bit --with-wide-int hosts).
487
e097a6fa
PE
488 * charset.c (Fdefine_charset_internal): Check for integer overflow.
489 Add a FIXME comment about memory leaks.
490 (syms_of_charset): Don't assume xmalloc returns.
491
5637687f
PE
492 Don't assume that stated character widths fit in int.
493 * character.c (Fchar_width, c_string_width, lisp_string_width):
494 * character.h (CHAR_WIDTH):
495 * indent.c (MULTIBYTE_BYTES_WIDTH):
496 Use sanitize_char_width to avoid undefined and/or bad behavior
497 with outlandish widths.
498 * character.h (sanitize_tab_width): Renamed from sanitize_width,
499 now that we have two such functions. All uses changed.
500 (sanitize_char_width): New inline function.
501
a2271ba2
PE
502 Don't assume that tab-width fits in int.
503 * character.h (sanitize_width): New inline function.
504 (SANE_TAB_WIDTH): New macro.
505 (ASCII_CHAR_WIDTH): Use it.
506 * indent.c (sane_tab_width): Remove. All uses replaced by
507 SANE_TAB_WIDTH (current_buffer).
508 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
509
18c52557
PE
510 * fileio.c: Integer overflow issues with file modes.
511 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
512
caeeedc1
PE
513 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
514 Remove unreachable code.
515 (read_hex, load_charset_map_from_file): Check for integer overflow.
516
50849c52
PE
517 * xterm.c: don't go over XClientMessageEvent limit
518 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
519 (x_send_scroll_bar_event): Likewise. Check that the size does not
520 exceed limits imposed by XClientMessageEvent, as well as the usual
521 ptrdiff_t and size_t limits.
522
b13995db
PE
523 * keyboard.c: Overflow, signedness and related fixes.
524 (make_lispy_movement): Use same integer type in forward decl
525 that is used in the definition.
526 (read_key_sequence, keyremap_step):
527 Change bufsize argument back to int, undoing my 2011-03-30 change.
528 We prefer signed types, and int is wide enough here.
529 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
530 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
531 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
532 length, not size_t. Use ptrdiff_t for index, not int.
533 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
534 possibility of integer overflow.
535
13464394
PE
536 Overflow, signedness and related fixes for images.
537
538 * dispextern.h (struct it.stack[0].u.image.image_id)
539 (struct_it.image_id, struct image.id, struct image_cache.size)
540 (struct image_cache.used, struct image_cache.ref_count):
541 * gtkutil.c (update_frame_tool_bar):
542 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
543 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
544 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
545 * nsmenu.m (update_frame_tool_bar):
546 * xdisp.c (calc_pixel_width_or_height):
547 * xfns.c (image_cache_refcount):
548 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
549 on typical 64-bit hosts.
550
551 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
552 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
553 Omit unnecessary casts to int.
554 (parse_image_spec): Check that integers fall into 'int' range
555 when the callers expect that.
556 (image_ascent): Redo ascent calculation to avoid int overflow.
557 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
558 (lookup_image): Remove unnecessary tests.
559 (xbm_image_p): Locals are now of int, not EMACS_INT,
560 since parse_image_check makes sure they fit into int.
561 (png_load, gif_load, svg_load_image):
562 Prefer int to unsigned where either will do.
563 (tiff_handler): New function, combining the cores of the
564 old tiff_error_handler and tiff_warning_handler. This
565 function is rewritten to use vsnprintf and thereby avoid
566 stack buffer overflows. It uses only the features of vsnprintf
567 that are common to both POSIX and native Microsoft.
568 (tiff_error_handler, tiff_warning_handler): Use it.
569 (tiff_load, gif_load, imagemagick_load_image):
570 Don't assume :index value fits in 'int'.
571 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
572 (imagemagick_load_image): Check that crop parameters fit into
573 the integer types that MagickCropImage accepts. Don't assume
574 Vimagemagick_render_type has a nonnegative value. Don't assume
575 size_t fits in 'long'.
576 (gs_load): Use printmax_t to print the widest integers possible.
577 Check for integer overflow when computing image height and width.
578
c11821d4
EZ
5792011-08-26 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (redisplay_window): Don't force window start if point
582 will be invisible in the resulting window. (Bug#9324)
583
0c95fcf7
EZ
5842011-08-25 Eli Zaretskii <eliz@gnu.org>
585
586 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
587 the display spec is of the form `(space ...)'.
588 (handle_display_spec): Return the value returned by
589 handle_single_display_spec, not just 1 or zero.
590 (handle_single_display_spec): If the display spec is of the form
591 `(space ...)', and specifies display in the text area, return 2
592 rather than 1.
fee65a97 593 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
594 accurately, and prefer exact match for point under bidi. Don't
595 advance `row' beyond the last row of the window.
0c95fcf7
EZ
596
597 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
598 into disp_prop; all users changed.
599
600 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
601 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
602 for the text covered by the display property.
603
e4ed06f1
CY
6042011-08-25 Chong Yidong <cyd@stupidchicken.com>
605
606 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
607 Change return value to nil.
608 (Frecord_buffer): Delete unused function.
609
f67cdd7f
EZ
6102011-08-24 Eli Zaretskii <eliz@gnu.org>
611
5980d4c6
EZ
612 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
613 buffers, return left-to-right.
8610fe8b
EZ
614 (set_cursor_from_row): Consider candidate row a win if its glyph
615 represents a newline and point is on that newline. Fixes cursor
616 positioning on the newline at EOL of R2L text within L2R
617 paragraph, and vice versa.
618 (try_cursor_movement): Check continued rows, in addition to
619 continuation rows. Fixes unwarranted scroll when point enters a
620 continued line of R2L text within an L2R paragraph, or vice versa.
621 (cursor_row_p): Consider the case of point being equal to
622 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
623 from the end of a short line to the beginning of a continued line
624 of R2L text within L2R paragraph.
625 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
626 composed characters.
5980d4c6 627
f67cdd7f
EZ
628 * bidi.c (bidi_check_type): Use xassert.
629 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
630 members.
631
bca633fb
EZ
6322011-08-23 Eli Zaretskii <eliz@gnu.org>
633
634 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
635 a character.
636
4a5885a7
CY
6372011-08-23 Chong Yidong <cyd@stupidchicken.com>
638
639 * nsfont.m (ns_otf_to_script): Fix typo.
640
0902a04e
KH
6412011-08-22 Kenichi Handa <handa@m17n.org>
642
643 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
644 extra slot even if the purpose is char-code-property-table.
645
1a2e6670
EZ
6462011-08-23 Eli Zaretskii <eliz@gnu.org>
647
8ddde651
EZ
648 * xdisp.c (redisplay_window): When computing centering_position,
649 account for the height of the header line. (Bug#8874)
650
425cc014
EZ
651 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
652 instead of CHAR_TO_BYTE. Fixes a crash when a completion
653 candidate is selected by the mouse, and that candidate has a
654 composed character under the mouse.
655
1a2e6670
EZ
656 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
657 coordinates reported by pos-visible-in-window-p for a composed
658 character in column zero.
659
8b76d6f8
SM
6602011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
663
dac347dd
EZ
6642011-08-22 Eli Zaretskii <eliz@gnu.org>
665
666 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
667 consider it a hit if to_charpos is anywhere in the range of the
668 composed buffer positions.
669
e013fb34
CY
6702011-08-22 Chong Yidong <cyd@stupidchicken.com>
671
672 * image.c (gif_load): Don't assume that each subimage has the same
673 dimensions as the base image. Handle disposal method that is
674 "undefined" by the gif spec (Bug#9335).
675
bd1ba3e8
CY
6762011-08-20 Chong Yidong <cyd@stupidchicken.com>
677
678 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 679 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 680
54a1215b
EZ
6812011-08-19 Eli Zaretskii <eliz@gnu.org>
682
823564e5
EZ
683 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
684 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
685 from an Org mode buffer to a Speedbar frame.
686
54a1215b
EZ
687 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
688 a composition, take its buffer position from IT->cmp_it.charpos.
689 Fixes cursor positioning at the beginning of a line that begins
690 with a composed character.
691
9778ebcc
EZ
6922011-08-18 Eli Zaretskii <eliz@gnu.org>
693
0be6ee06
EZ
694 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
695 character bidirectional type, use STRONG_L instead. Fixes crashes
696 in a buffer produced by `describe-categories'.
697
9778ebcc
EZ
698 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
699 members before the level stack, so they would be saved and
700 restored when copying iterator state. Fixes incorrect reordering
701 around TABs covered by display properties.
702
156bffbe
AS
7032011-08-18 Andreas Schwab <schwab@linux-m68k.org>
704
705 * process.c (Fnetwork_interface_list): Correctly determine buffer
706 size.
707
72ad093b
CY
7082011-08-17 Chong Yidong <cyd@stupidchicken.com>
709
710 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
711 (internal_condition_case_2, internal_condition_case_n):
712 Remove unnecessary aborts (Bug#9081).
72ad093b 713
35774242
EZ
7142011-08-17 Eli Zaretskii <eliz@gnu.org>
715
716 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
717 has no `load' handler, try opening the file locally. (Bug#9311)
718
db76dd85
KB
7192011-08-16 Ken Brown <kbrown@cornell.edu>
720
721 * gmalloc.c: Expand comment.
722
b215eee5
EZ
7232011-08-16 Eli Zaretskii <eliz@gnu.org>
724
725 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
726 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
727
a4579d33
KB
7282011-08-16 Ken Brown <kbrown@cornell.edu>
729
730 Fix memory allocation problems in Cygwin build (Bug#9273).
731
732 * unexcw.c ( __malloc_initialized): Declare external variable.
733 (fixup_executable): Force the dumped emacs to reinitialize malloc.
734
8b76d6f8
SM
735 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
736 New variables.
a4579d33
KB
737 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
738 dumped emacs.
739 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
740 in the static heap.
741 [CYGWIN] (special_realloc): New function.
742 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
743 requests to realloc storage in the static heap.
744
3ebec551
PE
7452011-08-15 Paul Eggert <eggert@cs.ucla.edu>
746
747 * bidi.c (bidi_initialize): Remove unused local.
748
9fd8be00
EZ
7492011-08-15 Eli Zaretskii <eliz@gnu.org>
750
474a8465
EZ
751 * biditype.h: File removed.
752
753 * bidimirror.h: File removed.
754
755 * deps.mk (bidi.o): Remove biditype.h and
756 bidimirror.h.
757
758 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
759 bidimirror.h.
760
761 * dispextern.h: Fix a typo in the comment to bidi_type_t.
762
763 * chartab.c: Improve commentary for the uniprop_table API.
764
32413314
EZ
765 * bidi.c (bidi_paragraph_init): Support zero value of
766 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
767 (bidi_initialize): Use uniprop_table instead of including
768 biditype.h and bidimirror.h.
32413314 769
9fd8be00
EZ
770 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
771 coordinates of the iterator when restoring from ppos_it.
772 (Bug#9296)
773
5cf2b69b
KH
7742011-08-14 Kenichi Handa <handa@m17n.org>
775
776 * process.c (create_process): Call setup_process_coding_systems
72ad093b 777 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 778
daf17d00
EZ
7792011-08-14 Eli Zaretskii <eliz@gnu.org>
780
781 * xdisp.c (move_it_in_display_line_to): Don't invoke
782 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
783 ppos_it. Fixes vertical cursor motion when line beginning is
784 covered by an image. (Bug#9296)
785
08e3161a
JD
7862011-08-14 Jan Djärv <jan.h.d@swipnet.se>
787
788 * nsterm.h (ns_run_ascript): Declare.
789 (NSAPP_DATA2_RUNASSCRIPT): Define.
790
791 * nsfns.m (as_script, as_result, as_status): New static variables.
792 (ns_run_ascript): New function.
793 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
794 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
795 the event loop. Get status from as_status (Bug#7276).
796
797 * nsterm.m (sendEvent): If event is NSApplicationDefined and
798 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
799 the event loop (Bug#7276).
800
a3720aa2
AS
8012011-08-14 Andreas Schwab <schwab@linux-m68k.org>
802
803 * gnutls.c (QCgnutls_bootprop_priority)
804 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
805 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
806 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
807 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
808 (QCgnutls_bootprop_verify_hostname_error)
809 (QCgnutls_bootprop_callbacks_verify): Rename from
810 Qgnutls_bootprop_..., all uses changed.
811
812 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
813 uses changed.
814
0a0d27fb
PE
8152011-08-14 Paul Eggert <eggert@cs.ucla.edu>
816
19d5c50c
PE
817 * xfaces.c (Qframe_set_background_mode): Now static.
818 * dispextern.h (Qframe_set_background_mode): Remove decl.
819
0a0d27fb
PE
820 * process.c (Fnetwork_interface_info): Declare local only if needed.
821
377538cb
JD
8222011-08-13 Jan Djärv <jan.h.d@swipnet.se>
823
824 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
825 (Fnetwork_interface_list): Allocate in increments of bytes instead
826 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
827 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
828 sockaddr.
829 (struct ifflag_def): notrailers is smart on OSX.
830 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
831 Get hardware address with getifaddrs if available.
832
08fff70c
EZ
8332011-08-12 Eli Zaretskii <eliz@gnu.org>
834
835 * xdisp.c (iterate_out_of_display_property): xassert that
836 IT->position is set to within IT->object's boundaries. Break from
837 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
838 when IT->position is set up wrongly due to some bug.
839 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
840 (push_display_prop): Allow GET_FROM_STRING as IT->method on
841 entry. Force push_it to save on the stack the current
842 buffer/string position, to be restored by pop_it. Fix flags in
843 the iterator structure wrt the object coming from a display
844 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
845 properties. (Bug#9284)
846
7be1c708 8472011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 848
7be1c708
CY
849 * fontset.c (fontset_get_font_group): Add proper type checks.
850 (Bug#9172)
aac0c6e3 851
7be1c708 8522011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 853
7be1c708
CY
854 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
855 and LC_VERSION_MIN_MACOSX.
856 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
857 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 858
97bb72a6
EZ
8592011-08-08 Eli Zaretskii <eliz@gnu.org>
860
861 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
862 no-display-properties-and-no-overlays under bidi display.
863 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 864 properties and overlays.
97bb72a6 865
d5617611
CY
8662011-08-08 Chong Yidong <cyd@stupidchicken.com>
867
37e11a63
CY
868 * editfns.c (Fset_time_zone_rule): Document relationship with the
869 setenv function.
870
d5617611
CY
871 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
872 the font entity extracted from the cache (Bug#8109).
873
58872834
CY
8742011-08-07 Chong Yidong <cyd@stupidchicken.com>
875
876 * composite.c (autocmp_chars): Don't reset point. That is done by
877 restore_point_unwind (Bug#5984).
878
75bfc667
JL
8792011-08-07 Juri Linkov <juri@jurta.org>
880
881 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
882 to show the arg `TIME' instead of `TIMEVAL'.
883
d1410150
EZ
8842011-08-06 Eli Zaretskii <eliz@gnu.org>
885
886 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
887 display property strides EOL and includes a newline, as in
888 longlines-mode. (Bug#9254)
75b771e4
EZ
889 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
890 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
891
892 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
893 is non-zero, even if the data buffer is NULL. Fixes a crash in
894 vertical-motion with longlines-mode. (Bug#9254)
895
35928349
EZ
8962011-08-05 Eli Zaretskii <eliz@gnu.org>
897
ec7cc85b
EZ
898 * bidi.c <bidi_cache_total_alloc>: Now static.
899 (bidi_initialize): Initialize bidi_cache_total_alloc.
900
8b76d6f8 901 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
902 cache. (Bug#9221)
903
904 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
905 amount allocated this far in `bidi_cache_total_alloc'.
906 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
907 non-zero, only free the data buffer without restoring the cache
908 contents. All callers changed.
909
910 * dispextern.h (bidi_unshelve_cache): Update prototype.
911
912 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
913 (move_it_in_display_line, move_it_to)
914 (move_it_vertically_backward, move_it_by_lines): Replace the call
915 to xfree to an equivalent call to bidi_unshelve_cache.
916 (move_it_in_display_line_to): Fix logic of returning
412b6358 917 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 918
e2e2423b
EZ
9192011-08-05 Eli Zaretskii <eliz@gnu.org>
920
921 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
922 came from a string character with a `cursor' property. (Bug#9229)
923
ae9e757a
JD
9242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
925
926 * Makefile.in (LIB_PTHREAD): New variable.
927 (LIBES): Add LIB_PTHREAD (Bug#9216).
928
929 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
930 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
931
213bd7f2
AS
9322011-08-04 Andreas Schwab <schwab@linux-m68k.org>
933
934 * regex.c (re_iswctype): Remove some redundant boolean
935 conversions.
936
99aaf75f
JD
9372011-08-04 Jan Djärv <jan.h.d@swipnet.se>
938
939 * xterm.c (x_find_topmost_parent): New function.
940 (x_set_frame_alpha): Find topmost parent window with
941 x_find_topmost_parent and set the property there also (bug#9181).
942 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
943
c74e9d86
PE
9442011-08-04 Paul Eggert <eggert@cs.ucla.edu>
945
946 * callproc.c (Fcall_process): Avoid vfork clobbering
947 the local vars buffer, coding_systems, current_dir.
948
640c8776
SM
9492011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
950
951 * keymap.c (Fmake_composed_keymap): Move to subr.el.
952
f26d0e4c
PE
9532011-08-03 Paul Eggert <eggert@cs.ucla.edu>
954
8a10d76c
PE
955 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
956 so that it is not optimized away.
957
f26d0e4c
PE
958 * xdisp.c (compute_display_string_pos): Remove unused local.
959
55439c61
EZ
9602011-08-02 Eli Zaretskii <eliz@gnu.org>
961
962 Fix slow cursor motion and scrolling in large buffers with
963 selective display, like Org Mode buffers. (Bug#9218)
964
965 * dispextern.h (struct bidi_it): New member disp_prop_p.
966
967 * xdisp.c: Remove one-slot cache of display string positions.
968 (compute_display_string_pos): Accept an additional argument
969 DISP_PROP_P; callers changed. Scan at most 5K characters forward
970 for a display string or property. If found, set DISP_PROP_P
971 non-zero.
972
973 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
974 DISP_PROP_P, and pass it to compute_display_string_pos.
975 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
976 non-zero. All callers of bidi_fetch_char changed.
977
fb33fa43
SM
9782011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
979
980 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
981
b099e063
DM
9822010-12-03 Don March <don@ohspite.net>
983
984 * keymap.c (Fdefine_key): Fix non-prefix key error message when
985 last character M-[char] is translated to ESC [char] (bug#7541).
986
5cc7f7af
KH
9872011-08-02 Kenichi Handa <handa@m17n.org>
988
d0fffa3f 989 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
990
991 * chartab.c (uniprop_table): Make it non-static.
992
525d5e6e
EZ
9932011-08-01 Eli Zaretskii <eliz@gnu.org>
994
995 * xdisp.c (forward_to_next_line_start): Accept additional argument
996 BIDI_IT_PREV, and store into it the state of the bidi iterator had
997 on the newline.
998 (reseat_at_next_visible_line_start): Use the bidi iterator state
999 returned by forward_to_next_line_start to restore the state of
1000 it->bidi_it after backing up to previous newline. (Bug#9212)
1001
31011111
AS
10022011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1003
1004 * regex.c (re_comp): Protoize.
1005 (re_exec): Fix return type.
1006 (regexec): Fix type of `ret'. (Bug#9203)
1007
e5d76069
PE
10082011-07-29 Paul Eggert <eggert@cs.ucla.edu>
1009
1010 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1011 This is needed if max-image-size is a floating-point number.
1012
9a79b20c
AS
10132011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * print.c (print_object): Print empty symbol as ##.
1016
1017 * lread.c (read1): Read ## as empty symbol.
1018
d8c2fa78
AA
10192011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1020
1021 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1022 setting frame foreground color (Bug#9175).
1023 (x_set_background_color): Likewise.
1024
ffe57a7a
AA
1025 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1026 contents (Bug#9176).
1027 (EmacsTooltip -init): Remove bezels and add shadows to
1028 tooltip windows.
1029
bf3492a5
AA
1030 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1031 or scroll bar (Bug#8470).
1032
d55e9c53
AA
1033 * nsfont.m (nsfont_open): Remove assignment to voffset and
1034 unnecessary vars hshink, expand, hd, full_height, min_height.
1035 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1036
1037 * nsterm.h (nsfont_info): Remove voffset field.
1038
d8c2fa78 10392011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1040
1041 Implement strike-through and overline on NextStep (Bug#8863).
1042
1043 * nsfont.m (nsfont_open): Use underline position provided by font,
1044 instead of hard-coded value of 2.
1045 (nsfont_draw): Call ns_draw_text_decoration instead.
1046
1047 * nsterm.h: Add declaration for ns_draw_text_decoration.
1048
1049 * nsterm.m (ns_draw_text_decoration): New function for drawing
1050 underline, overline, and strike-through.
1051 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1052 ns_draw_text_decoration. Change treatment of cursor drawing to
1053 accomodate underlining, etc.
1054
4cc60b9b
EZ
10552011-07-28 Eli Zaretskii <eliz@gnu.org>
1056
bc7ece87
EZ
1057 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1058 default.
4cc60b9b 1059
476371c4
PE
10602011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1061
66606eea
PE
1062 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1063 Without this fix, if a signal arrives just after memory fills up,
1064 'malloc' might be invoked reentrantly.
1065
476371c4
PE
1066 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1067 In other words, assume that every image size is allowed, on non-X
1068 hosts. This assumption is probably wrong, but it lets Emacs compile.
1069
f3fcc40d
AS
10702011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1071
1072 * regex.c (re_iswctype): Convert return values to boolean.
1073
350c992f
EZ
10742011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1075
1076 * xdisp.c (compute_display_string_pos): Don't use cached display
1077 string position if the buffer had its restriction changed.
1078 (Bug#9184)
1079
5266b4bb
PE
10802011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1083
2573a837 10842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1085
41f55ccd 1086 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1087
39e378da
PE
1088 * bidi.c: Integer size and overflow fixes.
1089 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1090 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1091 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1092 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1093 (bidi_find_other_level_edge):
1094 Use ptrdiff_t instead of EMACS_INT where either will do.
1095 This works better on 32-bit hosts configured --with-wide-int.
1096 (bidi_cache_ensure_space): Check for size-calculation overflow.
1097 Use % rather than repeated addition, for better worst-case speed.
1098 Don't set bidi_cache_size until after xrealloc returns, because it
1099 might not return.
1100 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1101 (bidi_cache_ensure_space): Also check that the bidi cache size
1102 does not exceed that of the largest Lisp string or buffer. See Eli
1103 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1104
5e927815
PE
1105 * alloc.c (__malloc_size_t): Remove.
1106 All uses replaced by size_t. See Andreas Schwab's note
1107 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1108
ca4aa935
PE
1109 * image.c: Improve checking for integer overflow.
1110 (check_image_size): Assume that f is nonnull, since
1111 it is always nonnull in practice. This is one less thing to
1112 worry about when checking for integer overflow later.
1113 (x_check_image_size): New function, which checks for integer
1114 overflow issues inside X.
1115 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1116 This removes the need for a memory_full check.
1117 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1118 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1119 (xbm_read_bitmap_data): Change locals back to 'int', since
1120 their values must fit in 'int'.
1121 (xpm_load_image, png_load, tiff_load):
1122 Invoke x_create_x_image_and_pixmap earlier,
1123 to avoid much needless work if the image is too large.
1124 (tiff_load): Treat overly large images as if
1125 x_create_x_image_and_pixmap failed, not as malloc failures.
1126 (gs_load): Use x_check_image_size.
1127
5f8f9cc2
PE
1128 * gtkutil.c: Omit integer casts.
1129 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1130 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1131
5adf60bc
PE
1132 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1133
c8907a93
PE
1134 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1135 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1136 would wrongly return t on a 64-bit host.
1137
e3c25c68
PE
1138 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1139 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1140 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1141 and therefore cause GCC to emit a bogus diagnostic in some cases.
1142
3f791afe
PE
1143 * image.c: Integer signedness and overflow and related fixes.
1144 This is not an exhaustive set of fixes, but it's time to
1145 record what I've got.
1146 (lookup_pixel_color, check_image_size): Remove redundant decls.
1147 (check_image_size): Don't assume that arbitrary EMACS_INT values
1148 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1149 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1150 (tiff_load, imagemagick_load_image):
1151 Check for overflow in size calculations.
1152 (x_create_x_image_and_pixmap): Remove unnecessary test for
1153 xmalloc returning NULL; that can't happen.
1154 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1155 (xpm_color_bucket): Use better integer hashing function.
1156 (xpm_cache_color): Don't possibly over-allocate memory.
1157 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1158 (gif_memory_source):
1159 Use ptrdiff_t, not int or size_t, to record sizes.
1160 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1161 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1162 either works, as we prefer signed integers.
1163 (tiff_read_from_memory, tiff_write_from_memory):
1164 Return tsize_t, not size_t, since that's what the TIFF API wants.
1165 (tiff_read_from_memory): Don't fail simply because the read would
1166 go past EOF; instead, return a short read.
1167 (tiff_load): Omit no-longer-needed casts.
1168 (Fimagemagick_types): Don't assume size fits into 'int'.
1169
3cc5a532
PE
1170 Improve hashing quality when configured --with-wide-int.
1171 * fns.c (hash_string): New function, taken from sxhash_string.
1172 Do not discard information about ASCII character case; this
1173 discarding is no longer needed.
1174 (sxhash-string): Use it. Change sig to match it. Caller changed.
1175 * lisp.h: Declare it.
1176 * lread.c (hash_string): Remove, since we now use fns.c's version.
1177 The fns.c version returns a wider integer if --with-wide-int is
1178 specified, so this should help the quality of the hashing a bit.
1179
b312a492
PE
1180 * emacs.c: Integer overflow minor fix.
1181 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1182 Define only if GNU_LINUX.
1183 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1184
dfd153ae
PE
1185 * dispnew.c: Integer signedness and overflow fixes.
1186 Remove unnecessary forward decls, that were a maintenance hassle.
1187 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1188 All uses changed.
1189 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1190 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1191 (prepare_desired_row, line_draw_cost):
1192 Use int, not unsigned, where either works.
1193 (save_current_matrix, restore_current_matrix):
1194 Use ptrdiff_t, not size_t, where either works.
1195 (init_display): Check for overflow more accurately, and without
1196 relying on undefined behavior.
1197
a81d11a3
PE
1198 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1199 Remove, replacing with the new symbols in lisp.h. All uses changed.
1200 * fileio.c (make_temp_name):
1201 * filelock.c (lock_file_1, lock_file):
1202 * xdisp.c (message_dolog):
1203 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1204 Use pMd etc. instead.
1205 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1206 replacing the pWIDE etc. symbols removed from editfns.c.
1207
3300e6fd
PE
1208 * keyboard.h (num_input_events): Now uintmax_t.
1209 This is (very slightly) less likely to mess up due to wraparound.
1210 All uses changed.
1211
fd05c7e9
PE
1212 * buffer.c: Integer signedness fixes.
1213 (alloc_buffer_text, enlarge_buffer_text):
1214 Use ptrdiff_t rather than size_t when either will do, as we prefer
1215 signed integers.
1216
903fe15d
PE
1217 * alloc.c: Integer signedness and overflow fixes.
1218 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1219 (__malloc_size_t): Default to size_t, not to int.
1220 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1221 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1222 Prefer ptrdiff_t to size_t when either would do, as we prefer
1223 signed integers.
1224 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1225 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1226 Now const. Initialize with values that are in range even if char
1227 is signed.
1228 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1229 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1230 These functions do the right thing with sizes > 2**32.
1231 (check_depth): Now ptrdiff_t, not int.
1232 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1233 Adjust to new way of storing sizes. Check for size overflow bugs
1234 in rest of code.
1235 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1236 slightly wrong anyway, as it missed one instance of
1237 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1238 (refill_memory_reserve): Omit needless cast to size_t.
1239 (mark_object_loop_halt): Mark as externally visible.
1240
ac82cc6a
PE
1241 * xselect.c: Integer signedness and overflow fixes.
1242 (Fx_register_dnd_atom, x_handle_dnd_message):
1243 Use ptrdiff_t, not size_t, since we prefer signed.
1244 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1245 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1246 x_dnd_atoms_size and x_dnd_atoms_length.
1247
c2d1e36d
PE
1248 * doprnt.c: Prefer signed to unsigned when either works.
1249 * eval.c (verror):
1250 * doprnt.c (doprnt):
1251 * lisp.h (doprnt):
1252 * xdisp.c (vmessage):
1253 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1254 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1255 prefer signed arithmetic to avoid comparison confusion.
1256 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1257 but is a bit tricky.
1258
0e926e56
PE
1259 Assume freestanding C89 headers, string.h, stdlib.h.
1260 * data.c, doprnt.c, floatfns.c, print.c:
1261 Include float.h unconditionally.
1262 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1263 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1264 * regex.c: Likewise for stddef.h, string.h.
1265 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1266 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1267 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1268 (STDC_HEADERS): Remove obsolete defines.
1269 * sysdep.c: Include limits.h unconditionally.
1270
9cfdb3ec
PE
1271 Assume support for memcmp, memcpy, memmove, memset.
1272 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1273 * regex.c (memcmp, memcpy):
1274 Remove; we assume C89 now.
1275
1276 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1277 (__malloc_safe_bcopy): Remove; no longer needed.
1278
cf950e6b 1279 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1280 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1281 well either way, and we prefer signed to unsigned.
1282
dbf38e02
LMI
12832011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1284
1285 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1286 closes the connection while we're reading (bug#9182).
1287
d6f0886c
JD
12882011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1289
1290 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1291 are specified (Bug#9168).
1292
2eb1f9e6
PE
12932011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1296 Found by GCC static checking and --with-wide-int on a 32-bit host.
1297
22381272 12982011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1299
1300 * xdisp.c (compute_display_string_pos): Fix logic of caching
1301 previous display string position. Initialize cached_prev_pos to
1302 -1. Fixes slow-down at the beginning of a buffer.
1303
f25e39b4
EZ
13042011-07-24 Eli Zaretskii <eliz@gnu.org>
1305
1306 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1307 for attrs[LFACE_FONTSET_INDEX].
1308
04c4b52e
PE
13092011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 * xml.c (parse_region): Remove unused local
1312 that was recently introduced.
1313
c1734fbd
EZ
13142011-07-23 Eli Zaretskii <eliz@gnu.org>
1315
be18c5a5
EZ
1316 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1317 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1318
c1734fbd
EZ
1319 * xdisp.c (move_it_in_display_line_to): Record the best matching
1320 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1321 exit if none of the characters scanned was an exact match.
1322 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1323 when exact match is impossible due to invisible text, and the
1324 lines are truncated.
1325
a258d627
JD
13262011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1327
1328 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1329 for OSX >= 10.7.
1330
b6d5a689
EZ
13312011-07-22 Eli Zaretskii <eliz@gnu.org>
1332
0f74f785
EZ
1333 Fix a significant slow-down of cursor motion with C-n, C-p,
1334 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1335 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1336 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1337 (next_element_from_buffer): Call compute_stop_pos_backwards to
1338 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1339 base_level_stop.
1340 (reseat): Don't look for prev_stop, as that could mean a very long
1341 run.
1342 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1343 <cached_disp_overlay_modiff>: Cache for last found display string
1344 position.
551918c1 1345 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1346 about the same buffer in the same area of character positions, and
1347 the buffer wasn't changed since the time the display string
1348 position was cached.
551918c1 1349
b2d0c91a
EZ
13502011-07-22 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1353 is an integer, which is important for empty lines. (Bug#9149)
1354
043604ee
CY
13552011-07-22 Chong Yidong <cyd@stupidchicken.com>
1356
1357 * frame.c (Fmodify_frame_parameters): In tty case, update the
1358 default face if necessary (Bug#4238).
1359
da4adb04
CY
13602011-07-21 Chong Yidong <cyd@stupidchicken.com>
1361
1362 * editfns.c (Fstring_to_char): No need to explain what a character
1363 is in the docstring (Bug#6576).
1364
9abd0532
LMI
13652011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1366
1367 * xml.c (parse_region): Make sure we always return a tree.
1368
36881d16
HK
13692011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1370
1371 * xml.c (parse_region): If a document contains only comments,
1372 return that, too.
1373
1e98674d
LMI
13742011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1375
1376 * xml.c (make_dom): Return comments, too.
1377
590bd467
PE
13782011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 Port to OpenBSD.
1381 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1382 and the surrounding thread.
1383 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1384 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1385 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1386 timer goes off.
1387 * s/openbsd.h (BROKEN_SIGIO): Define.
1388 * unexelf.c (unexec) [__OpenBSD__]:
1389 Don't update the .mdebug section of the Alpha COFF symbol table.
1390
f41628b2
LMI
13912011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1392
1393 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1394 (bug#8460).
1395
b59b67c5
PE
13962011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1397
15e3a074
PE
1398 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1399 This fixes some race conditions on the permissions of any newly
1400 created file.
1401
41bed37d
PE
1402 * alloc.c (valid_pointer_p): Use pipe, not open.
1403 This fixes some permissions issues when debugging.
1404
b59b67c5
PE
1405 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1406 If fchown fails to set both uid and gid, try to set just gid,
1407 as that is sometimes allowed. Adjust the file's mode to eliminate
1408 setuid or setgid bits that are inappropriate if fchown fails.
1409
925a6be7
SM
14102011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1411
1412 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1413 to compare Lisp_Objects.
1414 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1415 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1416 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1417
52968808
AS
14182011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1419
0a6a104b
AS
1420 * lread.c (read_integer): Unread even EOF character.
1421 (read1): Likewise. Properly record start position of symbol.
1422
52968808
AS
1423 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1424 symbol character follows.
1425
9e381cdd
PE
14262011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1427
1428 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1429 This works around a problem with the previous change to Fcopy_file.
1430 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1431 and without this change, GCC might complain about discarding
1432 fchown's return value.
1433
b5641435
JB
14342011-07-16 Juanma Barranquero <lekktu@gmail.com>
1435
1436 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1437
a8031457
PE
14382011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1441
dd889327
LMI
14422011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1443
750c33f7
LMI
1444 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1445 it's used from the C level.
1446
dd889327
LMI
1447 * process.c: Use the same condition for POLL_FOR_INPUT in both
1448 keyboard.c and process.c (bug#1858).
1449
87e86684
LM
14502011-07-09 Lawrence Mitchell <wence@gmx.li>
1451
1452 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1453 (Fgnutls_boot): Use it.
1454
64348f40
AS
14552011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1456
1457 * doc.c (Fsubstitute_command_keys): Revert last change.
1458
1d698799
LMI
14592011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1460
f863868c
LMI
1461 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1462 quotes the next character, and doesn't affect other longer
1463 sequences (bug#8935).
1464
1d698799
LMI
1465 * lread.c (syms_of_lread): Clarify that is isn't only
1466 `eval-buffer' and `eval-defun' that's affected by
1467 `lexical-binding' (bug#8460).
1468
aa4b6df6
EZ
14692011-07-15 Eli Zaretskii <eliz@gnu.org>
1470
1471 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1472 bidi redisplay when a line includes both an image and is
1473 truncated.
1474
5d856da6
PE
14752011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1476
ad6042bb
PE
1477 Fix minor problems found by static checking.
1478 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1479 (elsz): Now a signed constant, not a size_t var. We prefer signed
1480 types to unsigned, to avoid integer comparison confusion. Without
1481 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1482 "cannot optimize loop, the loop counter may overflow", a symptom
1483 of the confusion.
f00bbb22 1484 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1485 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1486
6468f31c
LMI
14872011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1488
49080b10
LMI
1489 * search.c (Fre_search_backward): Mention `case-fold-search' in
1490 all the re_search_* functions (bug#8138).
1491
6468f31c
LMI
1492 * keyboard.c (Fopen_dribble_file): Document when the file is
1493 closed (bug#8056).
1494
c965adc5
EZ
14952011-07-14 Eli Zaretskii <eliz@gnu.org>
1496
df9733bf
EZ
1497 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1498 bidi_cache_idx.
1499
0bb23927
EZ
1500 Support bidi reordering of display and overlay strings.
1501 * xdisp.c (compute_display_string_pos)
1502 (compute_display_string_end): Accept additional argument STRING.
1503 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1504 (reseat_to_string): Initialize bidi_it->string.s and
1505 bidi_it->string.schars.
1506 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1507 NULL (avoids a crash in bidi_paragraph_init).
1508 Initialize itb.string.lstring.
0bb23927
EZ
1509 (init_iterator): Call bidi_init_it only of a valid
1510 buffer position was specified. Initialize paragraph_embedding to
1511 L2R.
1512 (reseat_to_string): Initialize the bidi iterator.
1513 (display_string): If we need to ignore text properties of
1514 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1515 original value of -1 will not work with bidi.)
1516 (compute_display_string_pos): First arg is now struct
1517 `text_pos *'; all callers changed. Support display properties on
1518 Lisp strings.
1519 (compute_display_string_end): Support display properties on Lisp
1520 strings.
1521 (init_iterator, reseat_1, reseat_to_string): Initialize the
1522 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1523 when iterating on a string not from display properties).
640c8776
SM
1524 (compute_display_string_pos, compute_display_string_end):
1525 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1526 arrow keys.
1527 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1528 base_level_stop; instead, set base_level_stop to BEGV.
1529 Fixes crashes in vertical-motion.
0bb23927
EZ
1530 (next_element_from_buffer): Improve commentary for when
1531 the iterator is before prev_stop.
1532 (init_iterator): Initialize bidi_p from the default value of
1533 bidi-display-reordering, not from buffer-local value. Use the
1534 buffer-local value only if initializing for buffer iteration.
1535 (handle_invisible_prop): Support invisible properties on strings
1536 that are being bidi-reordered.
1537 (set_iterator_to_next): Support bidi reordering of C strings and
1538 Lisp strings.
1539 (next_element_from_string): Support bidi reordering of Lisp
1540 strings.
1541 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1542 (display_string): Support display of R2L glyph rows.
1543 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1544 (init_iterator): Don't initialize it->bidi_p for strings
1545 here.
1546 (reseat_to_string): Initialize it->bidi_p for strings here.
1547 (next_element_from_string, next_element_from_c_string)
1548 (next_element_from_buffer): Add xassert's for correspondence
1549 between IT's object being iterated and it->bidi_it.string
1550 structure.
1551 (face_before_or_after_it_pos): Support bidi iteration.
1552 (next_element_from_c_string): Handle the case of the first string
1553 character that is not the first one in the visual order.
1554 (get_visually_first_element): New function, refactored from common
1555 parts of next_element_from_buffer, next_element_from_string, and
1556 next_element_from_c_string.
1557 (tool_bar_lines_needed, redisplay_tool_bar)
1558 (display_menu_bar): Force left-to-right direction. Add a FIXME
1559 comment for making that be controlled by a user option.
1560 (push_it, pop_it): Save and restore the state of the
1561 bidi iterator. Save and restore the bidi_p flag.
1562 (pop_it): Iterate out of display property for string iteration as
1563 well.
1564 (iterate_out_of_display_property): Support iteration over strings.
1565 (handle_single_display_spec): Set up it->bidi_it for iteration
1566 over a display string, and call bidi_init_it.
1567 (handle_single_display_spec, next_overlay_string)
1568 (get_overlay_strings_1, push_display_prop): Set up the bidi
1569 iterator for displaying display or overlay strings.
1570 (forward_to_next_line_start): Don't use the shortcut if
1571 bidi-iterating.
1572 (back_to_previous_visible_line_start): If handle_display_prop
1573 pushed the iterator stack, restore the internal state of the bidi
1574 iterator by calling bidi_pop_it same number of times.
1575 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1576 and we are bidi-iterating, don't decrement the iterator position;
1577 instead, set the first_elt flag in the bidi iterator, to produce
1578 the same effect.
1579 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1580 (push_display_prop): xassert that we are iterating a buffer.
1581 (push_it, pop_it): Save and restore paragraph_embedding member.
1582 (handle_single_display_spec, next_overlay_string)
1583 (get_overlay_strings_1, reseat_1, reseat_to_string)
1584 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1585 correctly. Don't assume unibyte strings are not bidi-reordered.
1586 (compute_display_string_pos)
1587 (compute_display_string_end): Fix handling the case of C string.
1588 (push_it, pop_it): Save and restore from_disp_prop_p.
1589 (handle_single_display_spec, push_display_prop): Set the
1590 from_disp_prop_p flag.
1591 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1592 (pop_it): Call iterate_out_of_display_property only if we are
1593 popping after iteration over a string that came from a display
1594 property. Fix a typo in popping stretch info. Add an assertion
1595 for verifying that the iterator position is in sync with the bidi
1596 iterator.
1597 (handle_single_display_spec, get_overlay_strings_1)
1598 (push_display_prop): Fix initialization of paragraph direction for
1599 string when that of the parent object is not yet determined.
1600 (reseat_1): Call bidi_init_it to resync the bidi
1601 iterator with IT's position. (Bug#7616)
1602 (find_row_edges): If ROW->start.pos gives position
1603 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1604 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1605 Reset the from_disp_prop_p flag.
1606 (SAVE_IT, RESTORE_IT): New macros.
1607 (pos_visible_p, face_before_or_after_it_pos)
1608 (back_to_previous_visible_line_start)
1609 (move_it_in_display_line_to, move_it_in_display_line)
1610 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1611 (try_scrolling, redisplay_window, display_line): Use them when
1612 saving a temporary copy of the iterator and restoring it back.
1613 (back_to_previous_visible_line_start, reseat_1)
1614 (init_iterator): Empty the bidi cache "stack".
1615 (move_it_in_display_line_to): If iterator ended up at
1616 EOL, but we never saw any buffer positions smaller than
1617 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1618 motion in bidi-reordered lines.
1619 (move_it_in_display_line_to): Record prev_method and prev_pos
1620 immediately before the call to set_iterator_to_next. Fixes cursor
1621 motion in bidi-reordered lines with stretch glyphs and strings
1622 displayed in margins. (Bug#8133) (Bug#8867)
1623 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1624 TO_CHARPOS.
640c8776
SM
1625 (pos_visible_p): Support positions in bidi-reordered lines.
1626 Save and restore bidi cache.
0bb23927
EZ
1627
1628 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1629 (bidi_paragraph_info): Delete unused struct.
1630 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1631 (bidi_cache_start): New variable.
1632 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1633 to zero.
1634 (bidi_cache_fetch_state, bidi_cache_search)
1635 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1636 (bidi_cache_find, bidi_peek_at_next_level)
1637 (bidi_level_of_next_char, bidi_find_other_level_edge)
1638 (bidi_move_to_visually_next): Compare cache index with
1639 bidi_cache_start rather than with zero.
1640 (bidi_fetch_char): Accept new argument STRING; all callers
1641 changed. Support iteration over a string. Support strings with
1642 display properties. Support unibyte strings. Fix the type of
1643 `len' according to what STRING_CHAR_AND_LENGTH expects.
1644 (bidi_paragraph_init, bidi_resolve_explicit_1)
1645 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1646 (bidi_level_of_next_char, bidi_move_to_visually_next):
1647 Support iteration over a string.
0bb23927
EZ
1648 (bidi_set_sor_type, bidi_resolve_explicit_1)
1649 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1650 can now be zero (for strings); special values 0 and -1 were
1651 changed to -1 and -2, respectively.
1652 (bidi_char_at_pos): New function.
1653 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1654 Call it instead of FETCH_MULTIBYTE_CHAR.
1655 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1656 initialized to valid values.
1657 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1658 values.
1659 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1660 the test for valid cached positions. Fix the logic for looking up
1661 the sentinel state in the cache. GCPRO the Lisp string we are
1662 iterating.
1663 (bidi_push_it, bidi_pop_it): New functions.
1664 (bidi_initialize): Initialize the bidi cache start stack pointer.
1665 (bidi_cache_ensure_space): New function, refactored from part of
1666 bidi_cache_iterator_state. Don't assume the required size is just
1667 one BIDI_CACHE_CHUNK away.
1668 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1669 (bidi_count_bytes, bidi_char_at_pos): New functions.
1670 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1671 always valid if bidi_cache_idx is valid.
1672 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1673 is valid if it's going to be used.
1674 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1675 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1676 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1677 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1678 (bidi_find_other_level_edge, bidi_cache_start_stack):
1679 All variables related to cache indices are now EMACS_INT.
c965adc5 1680
0bb23927
EZ
1681 * dispextern.h (struct bidi_string_data): New structure.
1682 (struct bidi_it): New member `string'. Make flag members be 1-bit
1683 fields, and put them last in the struct.
640c8776
SM
1684 (compute_display_string_pos, compute_display_string_end):
1685 Update prototypes.
0bb23927
EZ
1686 (bidi_push_it, bidi_pop_it): Add prototypes.
1687 (struct iterator_stack_entry): New members bidi_p,
1688 paragraph_embedding, and from_disp_prop_p.
1689 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1690 (bidi_shelve_cache, bidi_unshelve_cache):
1691 Declare prototypes.
0bb23927
EZ
1692
1693 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1694 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1695 and vector-like objects.
1696
1697 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1698 cache around display iteration.
1699
1700 * window.c (Fwindow_end, window_scroll_pixel_based)
1701 (displayed_window_lines, Frecenter): Save and restore the bidi
1702 cache around display iteration.
1703
3bbd2265
LMI
17042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1705
1706 * editfns.c (Fdelete_region): Clarify the use of the named
1707 parameters (bug#6788).
1708
adc47434
MR
17092011-07-14 Martin Rudalics <rudalics@gmx.at>
1710
1711 * indent.c (Fvertical_motion): Set and restore w->pointm when
1712 saving and restoring the window's buffer (Bug#9006).
1713
837c31f8
LMI
17142011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1715
1716 * editfns.c (Fstring_to_char): Clarify just what is returned
1717 (bug#6576). Text by Eli Zaretskii.
1718
ac389d0c
JB
17192011-07-13 Juanma Barranquero <lekktu@gmail.com>
1720
1721 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1722
0be0ce47
EZ
17232011-07-13 Eli Zaretskii <eliz@gnu.org>
1724
1725 * buffer.c (mmap_find): Fix a typo.
1726
cd18e7e3
JB
17272011-07-13 Johan Bockgård <bojohan@gnu.org>
1728
1729 Fix execution of x selection hooks.
1730 * xselect.c (Qx_lost_selection_functions)
1731 (Qx_sent_selection_functions): New vars.
1732 (syms_of_xselect): DEFSYM them.
1733 (x_handle_selection_request): Pass Qx_sent_selection_functions
1734 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1735 (x_handle_selection_clear,x_clear_frame_selections):
1736 Pass Qx_lost_selection_functions rather than
1737 Vx_lost_selection_functions to Frun_hook_with_args.
1738
47ea7f44
PE
17392011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1740
ac389d0c 1741 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1742 The old code sometimes used this field without initializing it.
1743
47ea7f44
PE
1744 * alloc.c (gc_sweep): Don't read past end of array.
1745 In theory, the old code could also have corrupted Emacs internals,
1746 though it'd be very unlikely.
1747
bc985c87
AS
17482011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1749
1750 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1751 argument. (Bug#4026)
bc985c87 1752
0cf34688
LMI
17532011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1754
b3dadd76
LMI
1755 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1756 key" (bug#4257).
1757
0cf34688
LMI
1758 * window.c (Fset_window_start): Doc fix (bug#4199).
1759 (Fset_window_hscroll): Ditto.
1760
270768cd
PE
17612011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1762
077e3dda 1763 Fix minor new problems caught by GCC 4.6.1.
270768cd 1764 * term.c (init_tty): Remove unused local.
490011a6 1765 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1766 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1767 not used otherwise.
270768cd 1768
b1f58454
CY
17692011-07-12 Chong Yidong <cyd@stupidchicken.com>
1770
1771 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1772
22b9578d
LMI
17732011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1774
6e70ab07
LMI
1775 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1776 are the mini-buffer and the echo area (bug#3320).
1777
22b9578d
LMI
1778 * term.c (init_tty): Remove support for supdup, c10 and perq
1779 terminals, which are no longer supported (bug#1482).
1780
8974cc9f
JB
17812011-07-10 Johan Bockgård <bojohan@gnu.org>
1782
1783 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1784
a560d974
JD
17852011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1786
1787 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1788 for non-popups (Bug#3642).
1789
1dae0f0a
AS
17902011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1791
268c2c36 1792 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1793 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1794 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1795 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1796 * data.c (fmod): Likewise.
1797 * dispnew.c (swap_glyphs_in_rows): Likewise.
1798 * emacs.c (memory_warning_signal): Likewise.
1799 * floatfns.c (float_error): Likewise.
1800 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1801 (otf_open, font_otf_capability, generate_otf_features)
1802 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1803 Likewise.
1804 * image.c (pbm_read_file): Likewise.
1805 * indent.c (string_display_width): Likewise.
1806 * intervals.c (check_for_interval, search_for_interval)
1807 (inc_interval_count, count_intervals, root_interval)
1808 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1809 * lread.c (defalias): Likewise.
268c2c36 1810 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1811 * regex.c (set_image_of_range_1, set_image_of_range)
1812 (regex_grow_registers): Likewise.
1813 * sysdep.c (strerror): Likewise.
1814 * termcap.c (valid_filename_p, tprint, main): Likewise.
1815 * tparam.c (main): Likewise.
1816 * unexhp9k800.c (run_time_remap, save_data_space)
1817 (update_file_ptrs, read_header, write_header, calculate_checksum)
1818 (copy_file, copy_rest, display_header): Likewise.
1819 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1820 Likewise.
1821 * xdisp.c (check_it): Likewise.
1822 * xfaces.c (register_color, unregister_color, unregister_colors):
1823 Likewise.
1824 * xfns.c (print_fontset_result): Likewise.
1825 * xrdb.c (member, fatal, main): Likewise.
1826
99033785
PE
18272011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 Fix minor problems found by static checking (Bug#9031).
1830 * chartab.c (char_table_set_range, map_sub_char_table):
1831 Remove unused locals.
1832 (uniprop_table): Now static.
1833 * composite.c (_work_char): Remove unused static var.
1834
9cb2ac56
JB
18352011-07-09 Juanma Barranquero <lekktu@gmail.com>
1836
1837 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1838
f25661f0
JD
18392011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1840
1841 * gtkutil.c (qttip_cb): Remove code without function.
1842
8278c4fe
EZ
18432011-07-09 Eli Zaretskii <eliz@gnu.org>
1844
1845 * w32.c (pthread_sigmask): New stub.
1846
1692ae2d 18472011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1848
8a6ebd58 1849 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1850 sigprocmask is portable only for single-threaded applications, and
1851 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1852 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1853 (LIBES): Use it.
1854 * callproc.c (Fcall_process):
1855 * process.c (create_process):
1856 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1857 Use pthread_sigmask, not sigprocmask.
123403e4 1858
1b854618
JD
18592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1860
1861 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1862 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1863 wrong (Bug#8591).
1864
3fe4b549
JD
18652011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1866
0ce7e563
JD
1867 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1868 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1869 (xg_hide_tooltip): Fix comment.
1870
3fe4b549
JD
1871 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1872 in registerServicesMenuSendTypes.
1873 (validRequestorForSendType): Don't check ns_return_types.
1874
1875 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1876 ns_return_type.
1877
5df75e47
JR
18782011-07-08 Jason Rumney <jasonr@gnu.org>
1879
1880 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1881 frame struct members of non-existent frames (Bug#6284).
1882
699c10bd
JD
18832011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1884
4393663b
JD
1885 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1886 variable firstTime not needed on OSX >= 10.6.
1887 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1888 >= 10.5. Use setKnobProportion, setDoubleValue.
1889
1890 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1891 (MAC_OS_X_VERSION_10_5): Define if not defined.
1892 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1893 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1894 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1895
1896 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1897 cString and lossyCString on OSX >= 10.4
1898
1899 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1900 sizeToFit on OSX >= 10.2.
1901
1902 * nsimage.m (allocInitFromFile): Don't use deprecated method
1903 bestRepresentationForDevice on OSX >= 10.6.
1904
1905 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1906 to avoid warning.
1907
1908 * emacs.c: Declare unexec_init_emacs_zone.
1909
a63e0781
JD
1910 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1911
699c10bd
JD
1912 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1913
1914 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1915 on svcsMenu (Bug#8842).
1916
1917 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1918 ns_return_types.
1919 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1920
1921 * nsterm.m (QUTF8_STRING): Declare.
1922 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1923 (validRequestorForSendType): Return type is (id).
1924 Change indexOfObjectIdenticalTo to indexOfObject.
1925 Check if we have local selection before returning self (Bug#8842).
1926 (writeSelectionToPasteboard): Put local selection into paste board
1927 if we have a local selection (Bug#8842).
1928 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1929
1930 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1931 (ns_get_local_selection): Declare.
1932
54e10184
LMI
19332011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1934
9888ff71
LMI
1935 * keymap.c (describe_map_tree): Don't insert a double newline at
1936 the end of the buffer (bug#1169) and return whether we inserted
1937 something.
1938
54e10184
LMI
1939 * callint.c (Fcall_interactively): Change "reading args" to
1940 "providing args" to try to clarify what it does (bug#1010).
1941
15fa4783
KH
19422011-07-07 Kenichi Handa <handa@m17n.org>
1943
1944 * composite.c (composition_compute_stop_pos): Ignore a static
1945 composition starting before CHARPOS (Bug#8915).
1946
1947 * xdisp.c (handle_composition_prop): Likewise.
1948
a8815b00
EZ
19492011-07-07 Eli Zaretskii <eliz@gnu.org>
1950
1951 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1952 (Bug#9015)
1953
ef7b981d 19542011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1955
1956 * character.h (unicode_category_t): New enum type.
1957
1958 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1959 (Qchar_code_property_table): New variable.
1960 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1961 (UNIPROP_COMPRESSED_FORM_P): New macros.
1962 (char_table_ascii): Uncompress the compressed values.
1963 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1964 Uncompress the compressed values.
ac389d0c 1965 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1966 (char_table_ref_and_range): Uncompress the compressed values.
1967 (sub_char_table_set): New arg is_uniprop. Callers changed.
1968 Uncompress the compressed values.
1969 (sub_char_table_set_range): Args changed. Callers changed.
1970 (char_table_set_range): Adjuted for the above change.
1971 (map_sub_char_table): Delete args default_val and parent. Add arg
1972 top. Give decoded values to a Lisp function.
640c8776 1973 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1974 values to a Lisp function. Gcpro more variables.
1975 (uniprop_table_uncompress)
1976 (uniprop_decode_value_run_length): New functions.
1977 (uniprop_decoder, uniprop_decoder_count): New variables.
1978 (uniprop_get_decoder, uniprop_encode_value_character)
1979 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1980 New functions.
1981 (uniprop_encoder, uniprop_encoder_count): New variables.
1982 (uniprop_get_encoder, uniprop_table)
1983 (Funicode_property_table_internal, Fget_unicode_property_internal)
1984 (Fput_unicode_property_internal): New functions.
1985 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1986 Sunicode_property_table_internal, Sget_unicode_property_internal,
1987 and Sput_unicode_property_internal. Defvar_lisp
1988 char-code-property-alist.
1989
640c8776 1990 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1991 Vunicode_category_table.
1992
640c8776 1993 * font.c (font_range): Adjust for the change of
c805dec0
KH
1994 Vunicode_category_table.
1995
76b397fb
DN
19962011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1997
1998 * m/iris4d.h: Remove file, move contents ...
1999 * s/irix6-5.h: ... here.
2000
22b4128e
PE
20012011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2004 * alloc.c (mark_buffer):
2005 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2006 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2007 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2008 This isn't true in general, and it's particularly not true
2009 if Emacs is configured with --with-wide-int.
2010 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2011 New macros, used in the buffer.c change.
2012
869795d6
JD
20132011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2014
2015 * xsettings.c: Use both GConf and GSettings if both are available.
2016 (store_config_changed_event): Add comment.
2017 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2018 (store_tool_bar_style_changed): New functions.
2019 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2020 (struct xsettings): Move font inside HAVE_XFT.
2021 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2022 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2023 Move inside HAVE_XFT.
640c8776 2024 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2025 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2026 also.
2027 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
2028 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2029 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2030 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2031 (parse_settings): Move check for font inside HAVE_XFT.
2032 (read_settings, apply_xft_settings): Add comment.
2033 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2034 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2035 call store_font_name_changed.
2036 (xft_settings_event): Add comment.
2037 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2038 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2039 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2040 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2041 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2042 (xsettings_get_system_font, xsettings_get_system_normal_font):
2043 Add comment.
869795d6 2044
d8ed26bd
PE
20452011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2046
2047 Random fixes. E.g., (random) never returned negative values.
2048 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2049 subseconds part to the entropy, as that's a bit more random.
2050 Prefer signed to unsigned, since the signedness doesn't matter and
2051 in general we prefer signed. When given a limit, use a
2052 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2053 latter isn't right if USE_2_TAGS_FOR_INTS.
2054 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2055 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2056
cabf1cac
SM
20572011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2058
2059 * textprop.c (text_property_stickiness):
2060 Obey Vtext_property_default_nonsticky.
2061 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2062 * w32fns.c (syms_of_w32fns):
2063 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2064
6e9b2be9
PE
20652011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2068 This is more efficient than Ffile_directory_p and avoids a minor race.
2069
90186c68
LMI
20702011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2071
7c301272
LMI
2072 * buffer.c (Foverlay_put): Say what the return value is
2073 (bug#7835).
2074
c4f2d8d4
LMI
2075 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2076 is a directory before asking whether to use the file name
2077 (bug#7564).
ad637907
LMI
2078 (barf_or_query_if_file_exists): Make the "File is a directory"
2079 error be more correct.
c4f2d8d4 2080
90186c68
LMI
2081 * fns.c (Frequire): Remove the mention of the .gz files, since
2082 that's installation-specific, but keep the mention of
2083 `get-load-suffixes'.
2084
da64016e
PE
20852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2086
2087 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2088 Report string overflow if the output is too long.
2089
7d47b580
JB
20902011-07-04 Juanma Barranquero <lekktu@gmail.com>
2091
a555cb87
JB
2092 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2093 (syms_of_gnutls): Remove duplicate DEFSYM for
2094 Qgnutls_bootprop_verify_hostname_error, an error for
2095 Qgnutls_bootprop_verify_error (which is no longer used).
2096
7d47b580
JB
2097 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2098 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2099 Also (re)move comments that are misplaced or no longer relevant.
2100
1e49bfab
LMI
21012011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2102
2103 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2104
1485f4c0
CY
21052011-07-03 Chong Yidong <cyd@stupidchicken.com>
2106
2107 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2108 and background color parameters if they have been changed.
2109
a9ab721e
LMI
21102011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2111
2112 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2113
cf7cff57
PE
21142011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2115
2e13213d
PE
2116 * xsettings.c (SYSTEM_FONT): Define only when used.
2117 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2118
cf7cff57
PE
2119 * keymap.c (access_keymap_1): Now static.
2120
7a8e04f7
CY
21212011-07-02 Chong Yidong <cyd@stupidchicken.com>
2122
2123 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2124 leave any prefix arg for the up event (Bug#1586).
2125
61352f62
LMI
21262011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2127
69bb1ef7
LMI
2128 * lread.c (syms_of_lread): Mention single symbols defined by
2129 `defvar' or `defconst' (bug#7154).
2130
61352f62 2131 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2132 (Frequire): Mention get-load-suffixes.
61352f62 2133
28545e04
MR
21342011-07-02 Martin Rudalics <rudalics@gmx.at>
2135
2136 * window.h (window): Remove clone_number slot.
2137 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2138 Remove.
2139 (make_parent_window, make_window, saved_window)
2140 (Fset_window_configuration, save_window_save): Don't deal with
2141 clone numbers.
2142 * buffer.c (Qclone_number): Remove declaration.
2143 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2144
3349e122
SM
21452011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2146
2147 Add multiple inheritance to keymaps.
2148 * keymap.c (Fmake_composed_keymap): New function.
2149 (Fset_keymap_parent): Simplify.
2150 (fix_submap_inheritance): Remove.
2151 (access_keymap_1): New function extracted from access_keymap to handle
2152 embedded parents and handle lists of maps.
2153 (access_keymap): Use it.
2154 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2155 (Fcopy_keymap): Handle embedded parents.
2156 (Fcommand_remapping, define_as_prefix): Simplify.
2157 (Fkey_binding): Simplify.
2158 (syms_of_keymap): Move minibuffer-local-completion-map,
2159 minibuffer-local-filename-completion-map,
2160 minibuffer-local-must-match-map, and
2161 minibuffer-local-filename-must-match-map to Elisp.
2162 (syms_of_keymap): Defsubr make-composed-keymap.
2163 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2164 (parse_menu_item): Trivial simplification.
2165
3279eb87
GM
21662011-07-01 Glenn Morris <rgm@gnu.org>
2167
2168 * Makefile.in (SETTINGS_LIBS): Fix typo.
2169
4550efdf
KI
21702011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2171
2172 * coding.c (Fencode_coding_string): Record the last coding system
2173 used, as the function doc string says (bug#8738).
2174
0949d2b6
JD
21752011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2176
2177 * xsettings.c (store_monospaced_changed): Take new font as arg and
2178 check for change against current_mono_font.
2179 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2180 (emacs_settings_constructor, emacs_settings_get_property)
2181 (emacs_settings_set_property, emacs_settings_class_init)
2182 (emacs_settings_init, gsettings_obj): Remove.
2183 (something_changedCB): New function for HAVE_GSETTINGS.
2184 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2185 with value as argument.
2186 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2187 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2188 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2189 "changed".
2190
2191 * xgselect.c: Add defined (HAVE_GSETTINGS).
2192 (xgselect_initialize): Ditto.
2193
2194 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2195 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2196 xg_select.
2197
bbc6b304
PE
21982011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2199
2200 * eval.c (struct backtrace): Simplify and port the data structure.
2201 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2202 signed bit field, as this assumption is not portable and it makes
2203 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2204 "char debug_on_exit : 1" as this is not portable either; instead,
2205 use the portable "unsigned int debug_on_exit : 1". Remove unused
2206 member evalargs. Remove obsolete comments about cc bombing out.
2207
9851bfc5
JD
22082011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2209
51bb811f 2210 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2211 Let HAVE_GSETTINGS override HAVE_GCONF.
2212 (store_monospaced_changed): New function.
2213 (EMACS_SETTINGS): A new type derived from GObject to handle
2214 GSettings notifications.
2215 (emacs_settings_constructor, emacs_settings_get_property)
2216 (emacs_settings_set_property, emacs_settings_class_init):
2217 New functions.
2218 (gsettings_client, gsettings_obj): New variables.
2219 (GSETTINGS_SCHEMA): New define.
2220 (something_changedCB): Call store_monospaced_changed.
2221 (init_gsettings): New function.
2222 (xsettings_initialize): Call init_gsettings.
2223 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2224 to NULL.
2225
640c8776 2226 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2227 GCONF_CFLAGS/LIBS.
2228
5386012d
MR
22292011-06-29 Martin Rudalics <rudalics@gmx.at>
2230
2231 * window.c (resize_root_window, grow_mini_window)
2232 (shrink_mini_window): Rename Qresize_root_window to
2233 Qwindow_resize_root_window and Qresize_root_window_vertically to
2234 Qwindow_resize_root_window_vertically.
2235
f13e0b08
PE
22362011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2239
94515237
JB
22402011-06-27 Juanma Barranquero <lekktu@gmail.com>
2241
2242 * makefile.w32-in: Redesign dependencies so they reflect more
2243 clearly which files are directly included by each source file,
2244 and not through other includes.
2245
e43b6e43
MR
22462011-06-27 Martin Rudalics <rudalics@gmx.at>
2247
2248 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2249 (sort_overlays, overlay_strings): When an overlay's clone number
2250 matches the window's clone number process the overlay even if
2251 the overlay's window property doesn't match the current window.
2252
d68443dc
MR
2253 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2254 (Fwindow_hchild): Rename to Fwindow_left_child.
2255 (Fwindow_next): Rename to Fwindow_next_sibling.
2256 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2257 (resize_window_check): Rename to window_resize_check.
2258 (resize_window_apply): Rename to window_resize_apply.
2259 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2260 (Fdelete_other_windows_internal, resize_frame_windows)
2261 (Fsplit_window_internal, Fdelete_window_internal)
2262 (grow_mini_window, shrink_mini_window)
2263 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2264
c7e73be5
JD
22652011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2266
2267 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2268 (emacs_fixed_set_min_size): Remove.
2269 (emacs_fixed_new): Take frame as argument.
2270
2271 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2272 (_EmacsFixedPrivate): Remove minwidth/height.
2273 Add struct frame *f.
2274 (emacs_fixed_init): Initialize priv->f.
2275 (get_parent_class, emacs_fixed_set_min_size): Remove.
2276 (emacs_fixed_new): Set priv->f to argument.
2277 (emacs_fixed_get_preferred_width)
2278 (emacs_fixed_get_preferred_height): Use min_width/height from
2279 frames size_hint to set minimum and natural (Bug#8919).
2280 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2281 and use min_width/height from frames size_hint to set
2282 min_width/height (Bug#8919).
2283
2284 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2285 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2286 Fix indentation.
c7e73be5 2287
cf99dcf8
EZ
22882011-06-26 Eli Zaretskii <eliz@gnu.org>
2289
2290 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2291 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2292 called at ZV.
2293
029529ac
CY
22942011-06-26 Chong Yidong <cyd@stupidchicken.com>
2295
2296 * process.c (wait_reading_process_output): Bypass select if
2297 waiting for a cell while ignoring keyboard input, and input is
2298 pending. Suggested by Jan Djärv (Bug#8869).
2299
7a7ef429
PE
23002011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 Use gnulib's dup2 module instead of rolling our own.
2303 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2304
11fdef7d 23052011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2306
2307 * dispnew.c (scrolling_window): Before scrolling, turn off a
2308 mouse-highlight in the window being scrolled.
2309
cd3520a4
JB
23102011-06-24 Juanma Barranquero <lekktu@gmail.com>
2311
2312 Move DEFSYM to lisp.h and use everywhere.
2313
2314 * character.h (DEFSYM): Move declaration...
2315 * lisp.h (DEFSYM): ...here.
2316
2317 * gnutls.c:
2318 * minibuf.c:
2319 * w32menu.c:
2320 * w32proc.c:
2321 * w32select.c: Don't include character.h.
2322
2323 * alloc.c (syms_of_alloc):
2324 * buffer.c (syms_of_buffer):
2325 * bytecode.c (syms_of_bytecode):
2326 * callint.c (syms_of_callint):
2327 * casefiddle.c (syms_of_casefiddle):
2328 * casetab.c (init_casetab_once):
2329 * category.c (init_category_once, syms_of_category):
2330 * ccl.c (syms_of_ccl):
2331 * cmds.c (syms_of_cmds):
2332 * composite.c (syms_of_composite):
2333 * dbusbind.c (syms_of_dbusbind):
2334 * dired.c (syms_of_dired):
2335 * dispnew.c (syms_of_display):
2336 * doc.c (syms_of_doc):
2337 * editfns.c (syms_of_editfns):
2338 * emacs.c (syms_of_emacs):
2339 * eval.c (syms_of_eval):
2340 * fileio.c (syms_of_fileio):
2341 * fns.c (syms_of_fns):
2342 * frame.c (syms_of_frame):
2343 * fringe.c (syms_of_fringe):
2344 * insdel.c (syms_of_insdel):
2345 * keymap.c (syms_of_keymap):
2346 * lread.c (init_obarray, syms_of_lread):
2347 * macros.c (syms_of_macros):
2348 * msdos.c (syms_of_msdos):
2349 * print.c (syms_of_print):
2350 * process.c (syms_of_process):
2351 * search.c (syms_of_search):
2352 * sound.c (syms_of_sound):
2353 * syntax.c (init_syntax_once, syms_of_syntax):
2354 * terminal.c (syms_of_terminal):
2355 * textprop.c (syms_of_textprop):
2356 * undo.c (syms_of_undo):
2357 * w32.c (globals_of_w32):
2358 * window.c (syms_of_window):
2359 * xdisp.c (syms_of_xdisp):
2360 * xfaces.c (syms_of_xfaces):
2361 * xfns.c (syms_of_xfns):
2362 * xmenu.c (syms_of_xmenu):
2363 * xsettings.c (syms_of_xsettings):
2364 * xterm.c (syms_of_xterm): Use DEFSYM.
2365
4228cf16
TZ
23662011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2367
cd3520a4 2368 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2369
7fcccf1e
PE
23702011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2371
7efb4e0e
PE
2372 Integer and buffer overflow fixes (Bug#8873).
2373
ff5844ad
PE
2374 * print.c (printchar, strout): Check for string overflow.
2375 (PRINTPREPARE, printchar, strout):
2376 Don't set size unless allocation succeeds.
2377
90532f02
PE
2378 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2379 for sizes. Check for string overflow more accurately.
2380 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2381
6d84508d
PE
2382 * macros.c: Integer and buffer overflow fixes.
2383 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2384 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2385 Use ptrdiff_t, not int, for sizes.
2386 Don't increment bufsize until after realloc succeeds.
2387 Check for size-calculation overflow.
2388 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2389
437b2cb4
PE
2390 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2391
8b9ac8b4
PE
2392 * lread.c: Integer overflow fixes.
2393 (read_integer): Radix is now EMACS_INT, not int,
2394 to improve quality of diagnostics for out-of-range radices.
2395 Calculate buffer size correctly for out-of-range radices.
2396 (read1): Check for integer overflow in radices, and in
2397 read-circle numbers.
82cb60d3
PE
2398 (read_escape): Avoid int overflow.
2399 (Fload, openp, read_buffer_size, read1)
2400 (substitute_object_recurse, read_vector, read_list, map_obarray):
2401 Use ptrdiff_t, not int, for sizes.
2402 (read1): Use EMACS_INT, not int, for sizes.
20270765 2403 Check for size overflow.
8b9ac8b4 2404
7fcccf1e
PE
2405 * image.c (cache_image): Check for size arithmetic overflow.
2406
bfbbd7e7
PE
2407 * lread.c: Integer overflow issues.
2408 (saved_doc_string_size, saved_doc_string_length)
2409 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2410 Now ptrdiff_t, not int.
2411 (read1): Don't assume doc string length fits in int. Check for
2412 out-of-range doc string lengths.
2413 (read_list): Don't assume file position fits in int.
39019e54 2414 (read_escape): Check for hex character overflow.
bfbbd7e7 2415
4e323265
LL
24162011-06-22 Leo Liu <sdl.web@gmail.com>
2417
2418 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2419 Move to minibuffer.el.
2420
85fece3e
PE
24212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2422
20b84ce9 2423 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2424 The following patches are for when GLYPH_DEBUG && !XASSERT.
2425 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2426 * dispnew.c (flush_stdout):
2427 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2428 Mark as externally visible.
2429 * dispnew.c (check_window_matrix_pointers): Now static.
2430 * dispnew.c (window_to_frame_vpos):
2431 * xfns.c (unwind_create_frame):
2432 * xterm.c (x_check_font): Remove unused local.
2433 * scroll.c (CHECK_BOUNDS):
2434 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2435 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2436 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2437 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2438 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2439 Now static.
2440 (debug_method_add): Use va_list and vsprintf rather than relying
2441 on undefined behavior with wrong number of arguments.
2442 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2443 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2444 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2445 since we're not interested in debugging glyphs with old libraries.
2446 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2447 GCC 4.6.0's static checking.
2448
0766b489
PE
24492011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2450
31fd4b32
PE
2451 Integer overflow and signedness fixes (Bug#8873).
2452 A few related buffer overrun fixes, too.
2453
b79e8648
PE
2454 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2455
0766b489
PE
2456 * dispextern.h (struct face.stipple):
2457 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2458 (x_bitmap_mask, x_allocate_bitmap_record)
2459 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2460 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2461 (x_create_bitmap_from_xpm_data):
2462 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2463 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2464 (.bitmaps_last):
2465 * xfaces.c (load_pixmap):
2466 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2467 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2468 (.bitmaps_last, struct x_output.icon_bitmap):
2469 Use ptrdiff_t, not int, for bitmap indexes.
2470 (x_allocate_bitmap_record): Check for size overflow.
2471 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2472
b081724f
PE
2473 Use ptrdiff_t, not int, for overlay counts.
2474 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2475 * editfns.c (overlays_around, get_pos_property):
2476 * textprop.c (get_char_property_and_overlay):
2477 * xdisp.c (next_overlay_change, note_mouse_highlight):
2478 * xfaces.c (face_at_buffer_position):
21514da7
PE
2479 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2480 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2481 (Fnext_overlay_change, Fprevious_overlay_change)
2482 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2483 Use ptrdiff_t, not int, for sizes.
21514da7 2484 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2485
3de73e5e
PE
2486 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2487
2606c57b
PE
2488 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2489 (x_session_initialize): Do not assume string length fits in int.
2490
aaafe47a
PE
2491 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2492 This is unlikely, but can occur if DPI is outlandish.
2493
2674ddc8 2494 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2495 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2496
28154962
PE
2497 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2498 * xrdb.c (magic_file_p, search_magic_path):
2499 Omit last arg SUFFIX; it was always 0. All callers changed.
2500 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2501
7de51af5
PE
2502 * xfont.c (xfont_match): Avoid need for strlen.
2503
25ed6cc3
PE
2504 * xfns.c: Don't assume strlen fits in int.
2505 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2506
4eab31dd
PE
2507 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2508 not unsigned long, as we prefer signed integers. All callers changed.
2509 Detect integer overflow in repeat count.
2510 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2511 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2512
171e2a58
PE
2513 * termcap.c: Don't assume sizes fit in int and never overflow.
2514 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2515 (gobble_line): Check for size-calculation overflow.
2516
ad39faca 2517 * minibuf.c (Fread_buffer):
6e5bb2dc 2518 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2519 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2520 Don't assume string length fits in int.
2521
52c61c22 2522 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2523 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2524
b5b8c9e5
PE
2525 * font.c: Don't assume string length fits in int.
2526 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2527 Use ptrdiff_t, not int.
ccd6111c
PE
2528 (font_intern_prop): Don't assume string length fits in int.
2529 Don't assume integer property fits in fixnum.
2530 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2531
882f0d81 2532 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2533 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2534 Reformulate so as not to need the command string.
2535 Invoke gzip -cd rather than gunzip, as it's more portable.
2536 (lock_info_type, lock_file_1, lock_file):
2537 Don't assume pid_t and time_t fit in unsigned long.
2538 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2539 (current_lock_owner): Prefer signed type for sizes.
2540 Use memcpy, not strncpy, where memcpy is what is really wanted.
2541 Don't assume (via atoi) that time_t and pid_t fit in int.
2542 Check for time_t and/or pid_t out of range, e.g., via a network share.
2543 Don't alloca where an auto var works fine.
2544
93f4cf88
PE
2545 * fileio.c: Fix some integer overflow issues.
2546 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2547 Don't assume string length fits in int.
2548 (directory_file_name): Don't assume string length fits in long.
2549 (make_temp_name): Don't assume pid fits in int, or that its print
2550 length is less than 20.
2551
f3e92b69
PE
2552 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2553
1bfdaf10
PE
2554 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2555
35016e9a
PE
2556 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2557
3d1e65a1
PE
2558 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2559 We prefer signed integers, even for size calculations.
2560
0b963a93
PE
2561 * emacs.c: Don't assume string length fits in 'int'.
2562 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2563 (main): Don't invoke strlen when not needed.
2564
573f4b54
PE
2565 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2566 (XD_DEBUG_MESSAGE): Don't waste a byte.
2567
989f33ba
PE
2568 * callproc.c (getenv_internal_1, getenv_internal)
2569 (Fgetenv_internal):
965d34eb
PE
2570 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2571
e4d29b33
PE
2572 * lread.c (invalid_syntax): Omit length argument.
2573 All uses changed. This doesn't fix a bug, but it simplifies the
2574 code away from its former Hollerith-constant appearance, and it's
2575 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2576 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2577
eb49b136
PE
2578 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2579 This didn't break anything, but it didn't help either.
2580 It's confusing to put a bogus integer in a place where the actual
2581 value does not matter.
9f62aeb1 2582 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2583 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2584
15375a22
PE
2585 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2586 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2587 implementation.
b61cc01c
PE
2588 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2589 We prefer signed types, and the value cannot exceed the EMACS_INT
2590 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2591 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2592 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2593 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2594
53b2623d
PE
2595 * indent.c (sane_tab_width): New function.
2596 (current_column, scan_for_column, Findent_to, position_indentation)
2597 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2598 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2599
51cab52b 2600 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2601
f2ed8a70
PE
2602 * lisp.h (lint_assume): New macro.
2603 * composite.c (composition_gstring_put_cache):
2604 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2605
abe80cc6
PE
2606 * editfns.c, insdel.c:
2607 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2608
b02c740e
PE
2609 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2610
ebc96716
PE
2611 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2612
b4e50fa0 2613 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2614 Use much-faster test for byte-length change.
311d5d7c 2615 Don't assume string byte-length fits in 'int'.
a4cf38e4 2616 Check that character arg fits in 'int'.
85461888 2617 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2618
c0c1ee9f
PE
2619 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2620
a498d7f4
PE
2621 * fns.c (concat): Catch string overflow earlier.
2622 Do not rely on integer wraparound.
2623
51cab52b
PE
2624 * dispextern.h (struct it.overlay_strings_charpos)
2625 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2626 * xdisp.c (forward_to_next_line_start)
2627 (back_to_previous_visible_line_start)
2628 (reseat_at_next_visible_line_start, next_element_from_buffer):
2629 Don't arbitrarily truncate the value of 'selective' to int.
2630
76031fad
PE
2631 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2632
5eb55db9
PE
2633 * composite.c: Don't truncate sizes to 'int'.
2634 (composition_gstring_p, composition_reseat_it)
2635 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2636 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2637 not EMACS_UINT, for indexes.
5eb55db9 2638
0703a717
PE
2639 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2640
d6202519
PE
2641 * buffer.c: Include <verify.h>.
2642 (struct sortvec.priority, struct sortstr.priority):
8961a454 2643 Now EMACS_INT, not int.
c20998a7 2644 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2645 (struct sortstr.size, record_overlay_string)
2646 (struct sortstrlist.size, struct sortlist.used):
2647 Don't truncate size to int.
2648 (record_overlay_string): Check for size-calculation overflow.
d6202519 2649 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2650
d5a19415
JM
26512011-06-22 Jim Meyering <meyering@redhat.com>
2652
029529ac 2653 Don't leak an XBM-image-sized buffer
d5a19415
JM
2654 * image.c (xbm_load): Free the image buffer after using it.
2655
a9041e6c
PE
26562011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Port to Sun C.
2659 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2660 that Sun C diagnosed.
2661 * fns.c (secure_hash): Fix pointer signedness issue.
2662 * intervals.c (static_offset_intervals): New function.
2663 (offset_intervals): Use it.
2664
7f3f739f
LL
26652011-06-21 Leo Liu <sdl.web@gmail.com>
2666
2667 * deps.mk (fns.o):
2668 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2669 sha512.h.
2670
2671 * fns.c (secure_hash): Rename from crypto_hash_function and change
2672 the first arg to accept symbols.
5b66d427 2673 (Fsecure_hash): New primitive.
7f3f739f
LL
2674 (syms_of_fns): New symbols.
2675
76147d94
DD
26762011-06-20 Deniz Dogan <deniz@dogan.se>
2677
2678 * process.c (Fset_process_buffer): Clarify return value in
2679 docstring.
2680
7d7d0045
CY
26812011-06-18 Chong Yidong <cyd@stupidchicken.com>
2682
2683 * dispnew.c (add_window_display_history): Use BVAR.
2684
2685 * xdisp.c (debug_method_add): Use BVAR.
2686 (check_window_end, dump_glyph_matrix, dump_glyph)
2687 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2688
2689 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2690 Likewise.
2691
2692 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2693 check till after the cache is created in init_frame_faces.
2694
ff2bc410
SM
26952011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2696
2697 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2698
28177add
PE
26992011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2700
dd3482fe
PE
2701 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2702 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2703 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2704
393d71f3 2705 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2706 * fileio.c (Finsert_file_contents):
2707 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2708 Remove the old (too-loose) buffer overflow checks.
2709 They weren't needed, since make_gap checks for buffer overflow.
2710 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2711 The old code merely checked for Emacs fixnum overflow, and relied
2712 on undefined (wraparound) behavior. The new code avoids undefined
2713 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2714
2e6813b0 2715 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2716 Tune. Don't use wider integers than needed. Don't use alloca.
2717 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2718
599a9e4f
PE
2719 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2720
99561444
PE
2721 * insdel.c, lisp.h (buffer_overflow): New function.
2722 (insert_from_buffer_1, replace_range, replace_range_2):
2723 * insdel.c (make_gap_larger):
2724 * editfns.c (Finsert_char):
2725 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2726
28177add
PE
2727 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2728
e69dafad
PE
27292011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2730
a7af7fde 2731 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2732
b1c46f02
PE
2733 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2734 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2735
e69dafad
PE
2736 * fileio.c: Don't assume EMACS_INT fits in off_t.
2737 (emacs_lseek): New static function.
2738 (Finsert_file_contents, Fwrite_region): Use it.
2739 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2740
566684ea
PE
2741 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2742
e6966cd6
PE
2743 * fns.c: Don't overflow int when computing a list length.
2744 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2745 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2746 truncation on 64-bit hosts. Check for QUIT every
2747 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2748 faster and is responsive enough.
2749 (Flength): Report an error instead of overflowing an integer.
2750 (Fsafe_length): Return a float if the value is not representable
2751 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2752 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2753 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2754
dd0b0efb
PE
2755 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2756 (header_size, word_size): New constants.
2757 (allocate_vectorlike): Don't check size overflow here.
2758 (allocate_vector): Check it here instead, since this is the only
2759 caller of allocate_vectorlike that could cause overflow.
2760 Check that the new vector's length is representable as a fixnum.
2761
86fe5cfe
PE
2762 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2763 The previous code was bogus. For example, next_almost_prime (32)
2764 returned 39, which is undesirable as it is a multiple of 3; and
2765 next_almost_prime (24) returned 25, which is a multiple of 5 so
2766 why was the code bothering to check for multiples of 7?
2767
80e88859
PE
2768 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2769
4a2f0ad6
PE
2770 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2771
f66c7cf8
PE
2772 Variadic C functions now count arguments with ptrdiff_t.
2773 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2774 Back then I didn't know that the Emacs coding style prefers signed int.
2775 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2776 were being counted with int, which may truncate counts on 64-bit
2777 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2778 * lisp.h (struct Lisp_Subr.function.aMANY)
2779 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2780 Arg counts are now ptrdiff_t, not size_t.
2781 All variadic functions and their callers changed accordingly.
2782 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2783 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2784 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2785 * callint.c (Fcall_interactively): Check arg count for overflow,
2786 to avoid potential buffer overrun. Use signed char, not 'int',
2787 for 'varies' array, so that we needn't bother to check its size
2788 calculation for overflow.
2789 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2790 * eval.c (apply_lambda):
2791 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2792 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2793 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2794
a1759b76
PE
2795 * callint.c (Fcall_interactively): Don't use index var as event count.
2796
d96be9fc
PE
2797 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2798 * mem-limits.h (SIZE): Remove; no longer used.
2799
a690a978 2800 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2801
578c21e6
PE
2802 Remove unnecessary casts.
2803 * xterm.c (x_term_init):
2804 * xfns.c (x_set_border_pixel):
2805 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2806 These aren't needed now that we assume ANSI C.
2807
96f53c6c
PE
2808 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2809 It's more likely to cause problems (due to unsigned overflow)
2810 than to cure them.
2811
83c77d31
PE
2812 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2813
ee2079f1
PE
2814 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2815
6da65536
PE
2816 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2817
7147c4a4
PE
2818 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2819
193e32d9
PE
2820 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2821
e5533da6
PE
2822 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2823
9910e595
PE
2824 GLYPH_CODE_FACE returns EMACS_INT, not int.
2825 * dispextern.h (merge_faces):
2826 * xfaces.c (merge_faces):
01103c44
PE
2827 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2828 Don't assume EMACS_INT fits in int.
9910e595 2829
2638320e
PE
2830 * character.h (CHAR_VALID_P): Remove unused parameter.
2831 * fontset.c, lisp.h, xdisp.c: All uses changed.
2832
045eb8d9
PE
2833 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2834
c1f134b5
PE
2835 * fns.c (concat): Minor tuning based on overflow analysis.
2836 This doesn't fix any bugs. Use int to hold character, instead
2837 of constantly refetching from Emacs object. Use XFASTINT, not
2838 XINT, for value known to be a character. Don't bother comparing
2839 a single byte to 0400, as it's always less.
2840
395fcb93 2841 * floatfns.c (Fexpt):
327eeec8
PE
2842 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2843
abbd3d23
PE
2844 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2845 for characters.
2846
684a03ef
PE
2847 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2848
0fed43f3
PE
2849 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2850 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2851 incorrectly succeed when S was a string, because 4294967386 was
2852 truncated before it was used.
2853
8fd02eb7
PE
2854 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2855 Otherwise, an out-of-range integer could cause undefined behavior
2856 on a 64-bit host.
2857
f8c86b69
PE
2858 * composite.c: Use int, not EMACS_INT, for characters.
2859 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2860 EMACS_INT, for values that are known to be in character range.
2861 This doesn't fix any bugs but is the usual style inside Emacs and
2862 may generate better code on 32-bit machines.
2863
34206dd2
PE
2864 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2865 This is for reasons similar to the recent CHAR_STRING fix.
2866 * charset.c (Fencode_char): Check that character arg is actually
2867 a character. Pass an int to ENCODE_CHAR.
2868 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2869 wider than 'int', as a compile-time check to prevent future regressions
2870 in this area.
2871
c5958d4c 2872 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2873
2874 Make sure a 64-bit char is never passed to CHAR_STRING.
2875 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2876 by silently ignoring the top 32 bits, allowing some values
2877 that were far too large to be valid characters.
2878 * character.h: Include <verify.h>.
2879 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2880 arguments are no wider than unsigned, as a compile-time check
2881 to prevent future regressions in this area.
2882 * data.c (Faset):
01103c44 2883 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2884 (Fsubst_char_in_region):
2885 * fns.c (concat):
2886 * xdisp.c (decode_mode_spec_coding):
2887 Adjust to CHAR_STRING's new requirement.
2888 * editfns.c (Finsert_char, Fsubst_char_in_region):
2889 * fns.c (concat): Check that character args are actually
2890 characters. Without this test, these functions did the wrong
2891 thing with wildly out-of-range values on 64-bit hosts.
2892
d37ca623
PE
2893 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2894 These casts should not be needed on 32-bit hosts, either.
2895 * keyboard.c (read_char):
2896 * lread.c (Fload): Remove casts to unsigned.
2897
ea204efb
PE
2898 * lisp.h (UNSIGNED_CMP): New macro.
2899 This fixes comparison bugs on 64-bit hosts.
2900 (ASCII_CHAR_P): Use it.
2901 * casefiddle.c (casify_object):
01103c44 2902 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2903 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2904 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2905 * dispextern.h (FACE_FROM_ID):
2906 * keyboard.c (read_char): Use UNSIGNED_CMP.
2907
41cb286c
PE
2908 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2909 not to EMACS_INT, to avoid GCC warning.
2910
4a1b9832
PE
2911 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2912
55daad71
PE
2913 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2914 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2915 isn't needed on 32-bit machines.
8f95c75c 2916
01103c44
PE
2917 * buffer.c (Fgenerate_new_buffer_name):
2918 Use EMACS_INT for count, not int.
0ceccced 2919 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2920
2921 * data.c (Qcompiled_function): Now static.
2922
c6f072e7
PE
2923 * window.c (window_body_lines): Now static.
2924
20ce5912
PE
2925 * image.c (gif_load): Rename local to avoid shadowing.
2926
9c4c5f81
PE
2927 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2928 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2929 * alloc.c (make_save_value): Integer argument is now of type
2930 ptrdiff_t, not int.
2931 (mark_object): Use ptrdiff_t, not int.
2932 * lisp.h (pD): New macro.
2933 * print.c (print_object): Use it.
2934
c0c5c8ae
PE
2935 * alloc.c: Use EMACS_INT, not int, to count objects.
2936 (total_conses, total_markers, total_symbols, total_vector_size)
2937 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2938 (total_free_floats, total_floats, total_free_intervals)
2939 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2940 Now EMACS_INT, not int. All uses changed.
2941 (Fgarbage_collect): Compute overall total using a double, so that
2942 integer overflow is less likely to be a problem. Check for overflow
2943 when converting back to an integer.
5a25e253
PE
2944 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2945 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2946 These were 'int' variables that could overflow on 64-bit hosts;
2947 they were never used, so remove them instead of repairing them.
211a0b2a 2948 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2949 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2950 Previously, this ceilinged at INT_MAX, but that doesn't work on
2951 64-bit machines.
e46bb31a 2952 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2953
c78baabf 2954 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2955 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2956 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2957 when a (possibly-narrower) signed value would do just as well.
2958 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2959
c9d624c6
PE
2960 * alloc.c: Catch some string size overflows that we were missing.
2961 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2962 for convenience in STRING_BYTES_MAX.
2963 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2964 The definition here is exact; the one in lisp.h was approximate.
2965 (allocate_string_data): Check for string overflow. This catches
2966 some instances we weren't catching before. Also, it catches
2967 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2968 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2969 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2970
c9d624c6
PE
2971 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2972 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2973 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2974
353032ce
PE
2975 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2976
2bccce07
PE
2977 * alloc.c (Fmake_string): Check for out-of-range init.
2978
0ac30604
SM
29792011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2980
2981 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2982
c195f2de
JD
29832011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2984
2985 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2986 xg_get_default_scrollbar_width.
2987
2988 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2989 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2990 (style_changed_cb): Call update_theme_scrollbar_width and call
2991 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2992 all frames (Bug#8505).
2993 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2994 Call gtk_window_set_resizable if HAVE_GTK3.
2995 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2996 and height if HAVE_GTK3 (Bug#8505).
2997 (scroll_bar_width_for_theme): New variable.
2998 (update_theme_scrollbar_width): New function.
2999 (xg_get_default_scrollbar_width): Move code to
3000 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3001 (xg_initialize): Call update_theme_scrollbar_width.
3002
3003 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3004
3005 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3006
e10ac9f1
MR
30072011-06-12 Martin Rudalics <rudalics@gmx.at>
3008
3009 * frame.c (make_frame): Call other_buffer_safely instead of
3010 other_buffer.
3011
3012 * window.c (temp_output_buffer_show): Call display_buffer with
3013 second argument Vtemp_buffer_show_specifiers and reset latter
3014 immediately after the call.
3015 (Vtemp_buffer_show_specifiers): New variable.
3016 (auto_window_vscroll_p, next_screen_context_lines)
3017 (Vscroll_preserve_screen_position): Remove leading asterisks from
3018 doc-strings.
3019
2d3c217e 30202011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3021
7b7f97e8 3022 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3023 * buffer.c (Qclone_number): Remove for now, as it's unused.
3024 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3025 (record_buffer): Remove unused local.
3026 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3027 (set_frame_buffer_list): Remove; unused.
3028 * frame.h (other_visible_frames): Remove decl.
3029 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3030 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3031 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3032 if HAVE_GPM.
3033 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3034 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3035 Define only if HAVE_GPM.
3036 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3037 (update_hints_inhibit): Remove; never set. All uses removed.
3038 * widgetprv.h (emacsFrameClassRec): Remove decl.
3039 * window.c (delete_deletable_window): Now returns void, since it
3040 wasn't returning anything.
3041 (compare_window_configurations): Remove unused locals.
3042 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3043 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3044 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3045 the same widths as pointers. This follows up on the 2011-05-06 patch.
3046 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3047 * xterm.h: Likewise.
3048 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3049
1384b89e
JB
30502011-06-12 Juanma Barranquero <lekktu@gmail.com>
3051
3052 * makefile.w32-in: Update dependencies.
3053 (LISP_H): Add lib/intprops.h.
3054
1100a63c
CY
30552011-06-11 Chong Yidong <cyd@stupidchicken.com>
3056
3057 * image.c (gif_load): Add animation frame delay to the metadata.
3058 (syms_of_image): Use DEFSYM. New symbol `delay'.
3059
6198ccd0
MR
30602011-06-11 Martin Rudalics <rudalics@gmx.at>
3061
3062 * window.c (delete_deletable_window): Re-add.
3063 (Fset_window_configuration): Rewrite to handle dead buffers and
3064 consequently deletable windows.
3065 (window_tree, Fwindow_tree): Remove. Supply functionality in
3066 window.el.
3067 (compare_window_configurations): Simplify code.
3068
b6e3633c
AS
30692011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3070
1ab0dee5
AS
3071 * image.c (imagemagick_load_image): Fix type mismatch.
3072 (Fimagemagick_types): Likewise.
3073
b6e3633c
AS
3074 * window.h (replace_buffer_in_windows): Declare.
3075
9397e56f
MR
30762011-06-11 Martin Rudalics <rudalics@gmx.at>
3077
3078 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3079 Qclone_number. Remove external declaration of Qdelete_window.
3080 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3081 code.
640c8776
SM
3082 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3083 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3084 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3085 buffer list implementation.
3086 (other_buffer_safely): New function.
3087 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3088 calls to replace_buffer_in_windows and
3089 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3090 if allowed.
3091 (record_buffer): Inhibit quitting and rewrite using quittable
3092 functions. Run Qbuffer_list_update_hook if allowed.
3093 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3094 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3095 Move switch-to-buffer to window.el.
9397e56f
MR
3096 (bury-buffer): Move to window.el.
3097 (Vbuffer_list_update_hook): New variable.
3098
3099 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3100 section.
3101
3102 * window.h (resize_frame_windows): Move up in code.
3103 (Fwindow_frame): Remove EXFUN.
3104 (replace_buffer_in_all_windows): Remove prototype.
3105 (replace_buffer_in_windows_safely): Add prototype.
3106
3107 * window.c: Declare Qdelete_window static again. Move down
3108 declaration of select_count.
3109 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3110 (Fother_window): Move to window.el.
3111 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3112 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3113 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3114 window.el.
3115 (replace_buffer_in_windows): Implement by calling
3116 Qreplace_buffer_in_windows.
3117 (replace_buffer_in_all_windows): Remove with some functionality
3118 moved into replace_buffer_in_windows_safely.
3119 (replace_buffer_in_windows_safely): New function.
3120 (select_window_norecord, select_frame_norecord): Move in front
3121 of run_window_configuration_change_hook. Remove now obsolete
3122 declarations.
640c8776
SM
3123 (Fset_window_buffer): Rewrite doc-string.
3124 Call Qrecord_window_buffer.
9397e56f
MR
3125 (keys_of_window): Move binding for other-window to window.el.
3126
b50691aa
CY
31272011-06-11 Chong Yidong <cyd@stupidchicken.com>
3128
3129 * dispextern.h (struct image): Replace data member, whose int_val
3130 and ptr_val fields were not used by anything, with a single
3131 lisp_val object.
3132
3133 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3134 (gif_clear_image, gif_load, imagemagick_load_image)
3135 (gs_clear_image, gs_load): Callers changed.
3136
3f754b86
PE
31372011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3138
cca69397
PE
3139 * buffer.h: Include <time.h>, for time_t.
3140 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3141
109e28d0
PE
3142 Fix minor problems found by static checking.
3143
60737f02
PE
3144 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3145
4b66faf3
PE
3146 Make identifiers static if they are not used in other modules.
3147 * data.c (Qcompiled_function, Qframe, Qvector):
3148 * image.c (QimageMagick, Qsvg):
3149 * minibuf.c (Qmetadata):
3150 * window.c (resize_window_check, resize_root_window): Now static.
3151 * window.h (resize_window_check, resize_root_window): Remove decls.
3152
109e28d0
PE
3153 * window.c (window_deletion_count, delete_deletable_window):
3154 Remove; unused.
46a4ce9e
PE
3155 (window_body_lines): Now static.
3156 (Fdelete_other_windows_internal): Mark vars as initialized.
3157 Make sure 'resize_failed' is initialized.
3158 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3159 (resize_window_apply): Remove unused local.
3160 * window.h (delete_deletable_window): Remove decl.
3161
109e28d0 3162 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3163 (imagemagick_load_image): Fix pointer signedness problem by changing
3164 last arg from unsigned char * to char *. All uses changed.
3165 Also, fix a local for similar reasons.
3166 Remove unused locals. Remove locals to avoid shadowing.
3167 (fn_rsvg_handle_free): Remove; unused.
3168 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3169 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3170
3f754b86
PE
3171 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3172
2547adb1
CY
31732011-06-10 Chong Yidong <cyd@stupidchicken.com>
3174
3175 * image.c (gif_load): Fix omitted cast error introduced by
3176 2011-06-06 change.
3177
2c8e37d4
MR
31782011-06-10 Martin Rudalics <rudalics@gmx.at>
3179
3180 * window.h (resize_proportionally, orig_total_lines)
3181 (orig_top_line): Remove from window structure.
3182 (set_window_height, set_window_width, change_window_heights)
3183 (Fdelete_window): Remove prototypes.
3184 (resize_frame_windows): Remove duplicate declaration.
3185
440a42e3
EZ
31862011-06-10 Eli Zaretskii <eliz@gnu.org>
3187
3188 * window.h (resize_frame_windows, resize_window_check)
3189 (delete_deletable_window, resize_root_window)
3190 (resize_frame_windows): Declare prototypes.
3191
3192 * window.c (resize_window_apply): Make definition be "static" to
3193 match the prototype.
3194
562dd5e9
MR
31952011-06-10 Martin Rudalics <rudalics@gmx.at>
3196
3197 * window.c: Remove declarations of Qwindow_size_fixed,
3198 window_min_size_1, window_min_size_2, window_min_size,
3199 size_window, window_fixed_size_p, enlarge_window, delete_window.
3200 Remove static from declaration of Qdelete_window, it's
3201 temporarily needed by Fbury_buffer.
3202 (replace_window): Don't assign orig_top_line and
3203 orig_total_lines.
3204 (Fdelete_window, delete_window): Remove. Window deletion is
3205 handled by window.el.
640c8776
SM
3206 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3207 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3208 (Fdelete_other_windows): Remove. Deleting other windows is
3209 handled by window.el.
3210 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3211 handled in window.el.
3212 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3213 Window minimum sizes are handled in window.el.
3214 (shrink_windows, size_window, set_window_height)
3215 (set_window_width, change_window_heights, window_height)
3216 (window_width, CURBEG, CURSIZE, enlarge_window)
3217 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3218 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3219 handled in window.el.
3220 (make_dummy_parent): Rename to make_parent_window and give it a
3221 second argument horflag.
3222 (make_window): Don't set resize_proportionally any more.
3223 (Fsplit_window): Remove. Windows are split in window.el.
3224 (save_restore_action, save_restore_orig_size)
3225 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3226 Resize mini windows in window.el.
3227 (grow_mini_window, shrink_mini_window): Implement by calling
3228 Qresize_root_window_vertically, resize_window_check and
3229 resize_window_apply.
640c8776
SM
3230 (saved_window, Fset_window_configuration, save_window_save):
3231 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3232 resize_proportionally.
3233 (window_min_height, window_min_width): Move to window.el.
3234 (keys_of_window): Move bindings for delete-other-windows,
3235 split-window, delete-window and enlarge-window to window.el.
3236
3237 * buffer.c: Temporarily extern Qdelete_window.
3238 (Fbury_buffer): Temporarily call Qdelete_window instead of
3239 Fdelete_window (Fbury_buffer will move to window.el soon).
3240
3241 * frame.c (set_menu_bar_lines_1): Remove code handling
3242 orig_top_line and orig_total_lines.
3243
3244 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3245 set_window_height but set heights directly.
3246 (change_frame_size_1): Use resize_frame_windows.
3247
3248 * xdisp.c (init_xdisp): Don't use set_window_height but set
3249 heights directly.
3250
640c8776
SM
3251 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3252 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3253 run_window_configuration_change_hook.
3254
3255 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3256 instead of change_window_heights and run
3257 run_window_configuration_change_hook.
3258
1a13852e
MR
32592011-06-09 Martin Rudalics <rudalics@gmx.at>
3260
3261 * window.c (replace_window): Rename second argument REPLACEMENT to
3262 NEW. New third argument SETFLAG. Rewrite.
3263 (delete_window, make_dummy_parent): Call replace_window with
3264 third argument 1.
3265 (window_list_1): Move down in code.
3266 (run_window_configuration_change_hook): Move set_buffer part
3267 before select_frame_norecord part in order to unwind correctly.
3268 Rename count1 to count.
3269 (recombine_windows, delete_deletable_window, resize_root_window)
3270 (Fdelete_other_windows_internal)
3271 (Frun_window_configuration_change_hook, make_parent_window)
3272 (resize_window_check, resize_window_apply, Fresize_window_apply)
3273 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3274 (Fdelete_window_internal, Fresize_mini_window_internal):
3275 New functions.
1a13852e
MR
3276 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3277
f3d1777e
MR
32782011-06-08 Martin Rudalics <rudalics@gmx.at>
3279
496e208e
MR
3280 * window.h (window): Add some new members to window structure -
3281 normal_lines, normal_cols, new_total, new_normal, clone_number,
3282 splits, nest, prev_buffers, next_buffers.
3283 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3284 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3285
f3d1777e
MR
3286 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3287 Remove.
496e208e
MR
3288 (make_dummy_parent): Set new members of windows structure.
3289 (make_window): Move down in code. Handle new members of window
3290 structure.
3291 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3292 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3293 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3294 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3295 (Fset_window_next_buffers, Fset_window_clone_number):
3296 New functions.
496e208e
MR
3297 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3298 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3299 Doc-string fixes.
3300 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3301 Argument WINDOW can be now internal window too.
3302 (Fwindow_use_time): Move up in code.
3303 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3304 Rewrite doc-string.
3305 (Fset_window_configuration, saved_window)
3306 (Fcurrent_window_configuration, save_window_save): Handle new
3307 members of window structure.
b9e809c2
MR
3308 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3309 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3310 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3311 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3312 Qget_mru_window, Qresize_root_window,
3313 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3314 Qauto_buffer_name; staticpro them.
f3d1777e 3315
abde8f8c
MR
33162011-06-07 Martin Rudalics <rudalics@gmx.at>
3317
3318 * window.c (Fwindow_total_size, Fwindow_left_column)
3319 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3320 (Fwindow_list_1): New functions.
3321 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3322 (Fwindow_width, Fscroll_left, Fscroll_right):
3323 Use window_body_cols instead of window_box_text_cols.
3324 (delete_window, Fset_window_configuration):
3325 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3326 (delete_all_subwindows): Take a window as argument and not a
3327 structure. Rewrite.
190b47e6
MR
3328 (window_loop): Remove handling of GET_LRU_WINDOW and
3329 GET_LARGEST_WINDOW.
3330 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3331
3332 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3333 window_box_text_cols. delete_all_subwindows now takes a
3334 Lisp_Object as argument.
abde8f8c 3335
640c8776
SM
3336 * indent.c (compute_motion, Fcompute_motion):
3337 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3338
fa8a67e6
MR
3339 * frame.c (delete_frame): Call delete_all_subwindows with root
3340 window as argument.
3341
a54e3482
DC
33422011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3343
3344 * fns.c (Fputhash): Document return value.
3345
60002bf5
CY
33462011-06-06 Chong Yidong <cyd@stupidchicken.com>
3347
3348 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3349
0c671da6 33502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3351
b862a52a 3352 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3353
be44ca6c
PE
3354 Check for overflow when converting integer to cons and back.
3355 * charset.c (Fdefine_charset_internal, Fdecode_char):
3356 Use cons_to_unsigned to catch overflow.
3357 (Fencode_char): Use INTEGER_TO_CONS.
3358 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3359 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3360 * data.c (long_to_cons, cons_to_long): Remove.
3361 (cons_to_unsigned, cons_to_signed): New functions.
3362 These signal an error for invalid or out-of-range values.
3363 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3364 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3365 * font.c (Ffont_variation_glyphs):
3366 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3367 * lisp.h: Include <intprops.h>.
3368 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3369 (cons_to_signed, cons_to_unsigned): New decls.
3370 (long_to_cons, cons_to_long): Remove decls.
3371 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3372 (Fprimitive_undo): Use CONS_TO_INTEGER.
3373 * xfns.c (Fx_window_property): Likewise.
3374 * xselect.c: Include <limits.h>.
3375 (x_own_selection, selection_data_to_lisp_data):
3376 Use INTEGER_TO_CONS.
3377 (x_handle_selection_request, x_handle_selection_clear)
3378 (x_get_foreign_selection, Fx_disown_selection_internal)
3379 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3380 (lisp_data_to_selection_data): Use cons_to_unsigned.
3381 (x_fill_property_data): Use cons_to_signed.
3382 Report values out of range.
3383
d1f3d2af
PE
3384 Check for buffer and string overflow more precisely.
3385 * buffer.h (BUF_BYTES_MAX): New macro.
3386 * lisp.h (STRING_BYTES_MAX): New macro.
3387 * alloc.c (Fmake_string):
3388 * character.c (string_escape_byte8):
3389 * coding.c (coding_alloc_by_realloc):
3390 * doprnt.c (doprnt):
3391 * editfns.c (Fformat):
3392 * eval.c (verror):
3393 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3394 since they may not be the same number.
3395 * editfns.c (Finsert_char):
3396 * fileio.c (Finsert_file_contents):
3397 Likewise for BUF_BYTES_MAX.
3398
dd52fcea
PE
3399 * image.c: Use ptrdiff_t, not int, for sizes.
3400 (slurp_file): Switch from int to ptrdiff_t.
3401 All uses changed.
3402 (slurp_file): Check that file size fits in both size_t (for
3403 malloc) and ptrdiff_t (for sanity and safety).
3404
7f9bbdbb
PE
3405 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3406 if b->modtime has its maximal value.
3407
dfe18f82
PE
3408 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3409
84acfcf0
PE
3410 Don't assume time_t can fit into int.
3411 * buffer.h (struct buffer.modtime): Now time_t, not int.
3412 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3413 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3414
ccd9a01a
PE
3415 Minor fixes for signed vs unsigned integers.
3416 * character.h (MAYBE_UNIFY_CHAR):
3417 * charset.c (maybe_unify_char):
3418 * keyboard.c (read_char, reorder_modifiers):
3419 XINT -> XFASTINT, since the integer must be nonnegative.
3420 * ftfont.c (ftfont_spec_pattern):
3421 * keymap.c (access_keymap, silly_event_symbol_error):
3422 XUINT -> XFASTINT, since the integer must be nonnegative.
3423 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3424 since it makes no difference and we prefer signed.
3425 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3426 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3427 nonnegative.
3428
d6d100dd
SM
34292011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3430
3431 * window.h (Fwindow_frame): Declare.
3432
2b6148e4
PE
34332011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3436 (SPARE_MEMORY): Always define.
3437 (LARGE_REQUEST): Remove.
3438 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3439
f230ecc9
MR
34402011-06-06 Martin Rudalics <rudalics@gmx.at>
3441
727e958e
MR
3442 * lisp.h: Move EXFUNS for Fframe_root_window,
3443 Fframe_first_window and Fset_frame_selected_window to window.h.
3444
3445 * window.h: Move EXFUNS for Fframe_root_window,
3446 Fframe_first_window and Fset_frame_selected_window here from
3447 lisp.h.
3448
3449 * frame.c (Fwindow_frame, Fframe_first_window)
3450 (Fframe_root_window, Fframe_selected_window)
3451 (Fset_frame_selected_window): Move to window.c.
3452 (Factive_minibuffer_window): Move to minibuf.c.
3453 (Fother_visible_frames_p): New function.
3454
3455 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3456
f230ecc9
MR
3457 * window.c (decode_window, decode_any_window): Move up in code.
3458 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3459 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3460 (Fwindow_buffer): Move up and rewrite doc-string.
3461 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3462 (Fwindow_prev): New functions.
727e958e
MR
3463 (Fwindow_frame): Move here from frame.c. Accept any window as
3464 argument.
3465 (Fframe_root_window, Fframe_first_window)
3466 (Fframe_selected_window): Move here from frame.c. Accept frame
3467 or arbitrary window as argument. Update doc-strings.
3468 (Fminibuffer_window): Move up in code.
3469 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3470 (Fset_frame_selected_window): Move here from frame.c.
3471 Marginal rewrite.
727e958e
MR
3472 (Fselected_window, select_window, Fselect_window): Move up in
3473 code. Minor doc-string fixes.
f230ecc9 3474
4d09bcf6
PE
34752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3476
3477 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3478 Do not assume that spare memory exists; that assumption is valid
3479 only if SYSTEM_MALLOC.
3480 (LARGE_REQUEST): New macro, so that the issue of large requests
3481 is separated from the issue of spare memory.
3482
810928a2
AS
34832011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3484
172418ad
AS
3485 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3486 format. (Bug#8806)
3487
43f862f7
AS
3488 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3489
810928a2
AS
3490 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3491 before statements.
3492
a059fe24
JD
34932011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3494
3495 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3496
3497 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3498
3499 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3500 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3501
989bf368
JB
35022011-06-05 Juanma Barranquero <lekktu@gmail.com>
3503
3504 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3505
4b80f674
CY
35062011-06-04 Chong Yidong <cyd@stupidchicken.com>
3507
3508 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3509 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3510 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3511 New error handlers.
4b80f674
CY
3512 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3513 Obey Vx_select_enable_clipboard_manager. Catch errors in
3514 x_clipboard_manager_save (Bug#8779).
3515 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3516 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3517
99a33b77 35182011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3519
3520 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3521
99a33b77 35222011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3523
3524 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3525 in the current matrix if keep_current_p is non-zero.
3526
8264569d
EZ
35272011-06-04 Eli Zaretskii <eliz@gnu.org>
3528
3529 * bidi.c (bidi_level_of_next_char): Fix last change.
3530
57f97249
EZ
35312011-06-03 Eli Zaretskii <eliz@gnu.org>
3532
fec2107c 3533 Support bidi reordering of text covered by display properties.
57f97249 3534
fec2107c
EZ
3535 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3536 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3537 (bidi_cache_search, bidi_cache_iterator_state)
3538 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3539 (bidi_level_of_next_char, bidi_move_to_visually_next):
3540 Support character positions inside a run of characters covered by a
fec2107c
EZ
3541 display string.
3542 (bidi_paragraph_init, bidi_resolve_explicit_1)
3543 (bidi_level_of_next_char): Call bidi_fetch_char and
3544 bidi_fetch_char_advance instead of FETCH_CHAR and
3545 FETCH_CHAR_ADVANCE.
3546 (bidi_init_it): Initialize new members.
3547 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3548 definitions.
3549 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3550 instead of using explicit *_CHAR codes.
d6d100dd
SM
3551 (bidi_resolve_explicit, bidi_resolve_weak):
3552 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3553 bidirectional text is supported only in multibyte buffers.
3554 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3555 it to initialize the frame_window_p member of struct bidi_it.
3556 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3557 (bidi_resolve_explicit, bidi_resolve_weak)
3558 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3559 bidi_it->nchars is non-positive.
3560 (bidi_level_of_next_char): Don't try to lookup the cache for the
3561 next/previous character if nothing is cached there yet, or if we
3562 were just reseat()'ed to a new position.
c40e2fb2 3563
0e14fe90
EZ
3564 * xdisp.c (set_cursor_from_row): Set start and stop points
3565 according to the row's direction when priming the loop that looks
3566 for the glyph on which to display cursor.
3567 (single_display_spec_intangible_p): Function deleted.
3568 (display_prop_intangible_p): Reimplement to call
3569 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3570 Accept 3 additional arguments needed by handle_display_spec.
3571 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3572 values: lists, `(when COND...)' forms, etc.
3573 (single_display_spec_string_p): Support property values that are
3574 lists with the argument STRING its top-level element.
3575 (display_prop_string_p): Fix the condition for processing a
3576 property that is a list to be consistent with handle_display_spec.
fec2107c 3577 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3578 last portion of handle_display_prop.
3579 (compute_display_string_pos): Accept additional argument
3580 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3581 value of a `display' property is a "replacing spec".
3582 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3583 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3584 the display property, but just return a value indicating whether
3585 the display property will replace the characters it covers.
3586 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3587 frame_window_p members of struct bidi_it.
d6d100dd
SM
3588 (compute_display_string_pos, compute_display_string_end):
3589 New functions.
fec2107c
EZ
3590 (push_it): Accept second argument POSITION, where pop_it should
3591 jump to continue iteration.
3592 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3593
fec2107c
EZ
3594 * keyboard.c (adjust_point_for_property): Adjust the call to
3595 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3596
3597 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3598 (bidi_init_it): Update prototypes.
3599 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3600 (compute_display_string_pos, compute_display_string_end):
3601 Declare prototypes.
fec2107c
EZ
3602 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3603 EMACS_INT.
fc6f18ce 3604
40087514 36052011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3606
57f53182
PE
3607 Malloc failure behavior now depends on size of allocation.
3608 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3609 * lisp.h: Change signatures accordingly.
3610 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3611 All callers changed. (Bug#8762)
3612
3613 * gnutls.c: Use Emacs's memory allocators.
3614 Without this change, the gnutls library would invoke malloc etc.
3615 directly, which causes problems on non-SYNC_INPUT hosts, and which
3616 runs afoul of improving memory_full behavior. (Bug#8761)
3617 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3618 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3619 xfree instead of the default malloc, realloc, free.
3620 (Fgnutls_boot): No need to check for memory allocation failure,
3621 since xmalloc does that for us.
3622
ac32cd99 3623 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3624 * category.c (hash_get_category_set):
3625 * ccl.c (ccl_driver):
3626 * charset.c (Fdefine_charset_internal):
3627 * charset.h (struct charset.hash_index):
3628 * composite.c (get_composition_id, gstring_lookup_cache)
3629 (composition_gstring_put_cache):
3630 * composite.h (struct composition.hash_index):
3631 * dispextern.h (struct image.hash):
3632 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3633 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3634 (hashfn_equal, hashfn_user_defined, make_hash_table)
3635 (maybe_resize_hash_table, hash_lookup, hash_put)
3636 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3637 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3638 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3639 * image.c (make_image, search_image_cache, lookup_image)
3640 (xpm_put_color_table_h):
3641 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3642 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3643 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3644 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3645 * alloc.c (allocate_vectorlike):
3646 Check for overflow in vector size calculations.
3647 * ccl.c (ccl_driver):
3648 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3649 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3650 need to be updated by these changes.
40087514
PE
3651 * fns.c (make_hash_table, maybe_resize_hash_table):
3652 Check for integer overflow with large hash tables.
0de4bb68
PE
3653 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3654 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3655 (SXHASH_REDUCE): New macro.
3656 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3657 Use it instead of discarding useful hash info with large hash values.
3658 (sxhash_float): New function.
3659 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3660 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3661 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3662 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3663 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3664 Adjust signatures to match updated version of code.
3665 (consing_since_gc): Now EMACS_INT, since a single hash table can
3666 use more than INT_MAX bytes.
3667
698d32e2
DN
36682011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3669
3670 Make it possible to build with GCC-4.6+ -O2 -flto.
3671
3672 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3673
fd6fa53f
SM
36742011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3675
3676 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3677 Call minibuffer-inactive-mode.
3678
864db017
JB
36792011-05-31 Juanma Barranquero <lekktu@gmail.com>
3680
3681 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3682 Update dependencies.
3683
2ad0baf4
DN
36842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3685
3686 * data.c (init_data): Remove code for UTS, this system is not
3687 supported anymore.
3688
4fcc2638
DN
36892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3690
3691 Don't force ./temacs to start in terminal mode.
3692
3693 * frame.c (make_initial_frame): Initialize faces in all cases, not
3694 only when CANNOT_DUMP is defined.
3695 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3696
c56e0fd5
DN
36972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3698
3699 * dispnew.c (add_window_display_history): Use const for the string
3700 pointer. Remove declaration, not needed.
3701
333d54da 37022011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3703
55d4c1b2 3704 Use 'inline', not 'INLINE'.
333d54da 3705 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3706 * alloc.c, fontset.c (INLINE): Remove.
3707 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3708 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3709 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3710 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3711 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3712
738db178
DN
37132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3714
3715 Make it possible to run ./temacs.
3716
3717 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3718 syms_of_callproc does the same thing. Remove test for
3719 "initialized", do it in the caller.
3720 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3721
620c53a6
SM
37222011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3723
3724 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3725 (read_minibuf): Use get_minibuffer.
3726 (syms_of_minibuf): Use DEFSYM.
3727 (Qmetadata): New var.
3728 * data.c (Qbuffer): Don't make it static.
3729 (syms_of_data): Use DEFSYM.
3730
e003a292
PE
37312011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3734 (CCL_CODE_MIN): New macro.
3735
ed008a6d
PE
37362011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3737
3687c2ef
PE
3738 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3739
ed008a6d
PE
3740 * eval.c (Qdebug): Now static.
3741 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3742 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3743 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3744
d66c4c7c
CY
37452011-05-29 Chong Yidong <cyd@stupidchicken.com>
3746
3747 * image.c: Various fixes to ImageMagick code comments.
3748 (Fimagemagick_types): Doc fix.
3749
5fbc2025
PE
37502011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3751
0196f88a
PE
3752 Minor fixes prompted by GCC 4.6.0 warnings.
3753
3754 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3755
5fbc2025
PE
3756 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3757 (x_clipboard_manager_save_all): Move extern decl to ...
3758 * xterm.h: ... here, so that it can be checked for consistency.
3759
1dd3c2d9
CY
37602011-05-29 Chong Yidong <cyd@stupidchicken.com>
3761
3762 * xselect.c (x_clipboard_manager_save_frame)
3763 (x_clipboard_manager_save_all): New functions.
3764 (Fx_clipboard_manager_save): Lisp function deleted.
3765
3766 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3767 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3768
3769 * xterm.h: Update prototype.
3770
5ba6571d
WX
37712011-05-28 William Xu <william.xwl@gmail.com>
3772
3773 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3774 exiting (Bug#8239).
3775
3eaff834
JM
37762011-05-28 Jim Meyering <meyering@redhat.com>
3777
e1900994 3778 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3779 * fns.c (to_uchar): Define.
3780 (crypto_hash_function): Use it to convert some newly-signed
3781 variables to unsigned, to avoid sign-extension bugs. For example,
3782 without this change, (md5 "truc") would evaluate to
3783 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3784 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3785 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3786
0f6990a7
PE
37872011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 Integer overflow fixes.
c8a9ca5a 3790
08686060
PE
3791 * dbusbind.c: Serial number integer overflow fixes.
3792 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3793 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3794 to hold a serial number that is too large for a fixnum.
3795 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3796 Check for serial numbers out of range. Decode any serial number
59568bf0 3797 that was so large that it became a float. (Bug#8722)
08686060 3798
2d1fc3c7
PE
3799 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3800 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3801 Use XFASTINT rather than XUINT when numbers are nonnegative.
3802 (xd_append_arg, Fdbus_method_return_internal):
3803 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3804 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3805 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3806 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3807 (Bug#8722)
2d1fc3c7 3808
c8a9ca5a
PE
3809 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3810
519e1d69
PE
3811 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3812
30569699
PE
3813 ccl: add integer overflow checks
3814 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3815 (IN_INT_RANGE): New macros.
3816 (ccl_driver): Use them to check for integer overflow when
3817 decoding a CCL program. Many of the new checks are whether XINT (x)
3818 fits in int; it doesn't always, on 64-bit hosts. The new version
3819 doesn't catch all possible integer overflows, but it's an
847044ea 3820 improvement. (Bug#8719)
30569699 3821
c11285dc
PE
3822 * alloc.c (make_event_array): Use XINT, not XUINT.
3823 There's no need for unsigned here.
3824
fdccd48e
PE
3825 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3826 This follows up to the 2011-05-06 change that substituted uintptr_t
3827 for EMACS_INT. This case wasn't caught back then.
3828
37910ab2
PE
3829 Rework Fformat to avoid integer overflow issues.
3830 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3831 now (part of C89). Include <verify.h>.
3832 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3833 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3834 (Fformat): Avoid the prepass trying to compute sizes; it was only
3835 approximate and thus did not catch overflow reliably. Instead, walk
3836 through the format just once, formatting and computing sizes as we go,
3837 checking for integer overflow at every step, and allocating a larger
3838 buffer as needed. Keep track separately whether the format is
3839 multibyte. Keep only the most-recently calculated precision, rather
3840 than them all. Record whether each argument has been converted to
3841 string. Use EMACS_INT, not int, for byte and char and arg counts.
3842 Support field widths and precisions larger than INT_MAX. Avoid
3843 sprintf's undefined behavior with conversion specifications such as %#d
3844 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3845 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3846 formatting out-of-range floating point numbers with int
9173deec 3847 formats. (Bug#8668)
37910ab2 3848
2e6578fb
PE
3849 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3850
0ae6bdee
PE
3851 * data.c: Avoid integer truncation in expressions involving floats.
3852 * data.c: Include <intprops.h>.
3853 (arith_driver): When there's an integer overflow in an expression
3854 involving floating point, convert the integers to floating point
3855 so that the resulting value does not suffer from catastrophic
3856 integer truncation. For example, on a 64-bit host (* 4
3857 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3858 Do not rely on undefined behavior after integer overflow.
3859
de883a70
PE
3860 merge count_size_as_multibyte, parse_str_to_multibyte
3861 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3862 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3863 Check for integer overflow.
3864 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3865 since it's now a duplicate of the other. This is more of
3866 a character than a buffer op, so better that it's in character.c.
3867 * fns.c, print.c: Adjust to above changes.
3868
2ff916cb
PE
38692011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3870
3871 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3872
f1b54466
PE
38732011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3874
fb1ac845
PE
3875 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3876 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3877 (x_clipboard_manager_save): Now static.
3878 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3879
f1b54466
PE
3880 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3881 (crypto_hash_function): Now static.
3882 Fix pointer signedness problems. Avoid unnecessary initializations.
3883
a9f737ee
CY
38842011-05-27 Chong Yidong <cyd@stupidchicken.com>
3885
3886 * termhooks.h (Vselection_alist): Make it terminal-local.
3887
3888 * terminal.c (create_terminal): Initialize it.
3889
3890 * xselect.c: Support for clipboard managers.
3891 (Vselection_alist): Move to termhooks.h as terminal-local var.
3892 (LOCAL_SELECTION): New macro.
3893 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3894 (symbol_to_x_atom): Remove gratuitous arg.
3895 (x_handle_selection_request, lisp_data_to_selection_data)
3896 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3897 (x_own_selection, x_get_local_selection, x_convert_selection):
3898 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3899 (some_frame_on_display): Delete unused function.
3900 (Fx_own_selection_internal, Fx_get_selection_internal)
3901 (Fx_disown_selection_internal, Fx_selection_owner_p)
3902 (Fx_selection_exists_p): New optional frame arg.
3903 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3904 (x_handle_selection_clear): Don't treat other terminals with the
3905 same keyboard specially. Use the terminal-local Vselection_alist.
3906 (x_clear_frame_selections): Use Frun_hook_with_args.
3907
3908 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3909
3910 * xterm.h: Add support for those atoms.
3911
e067f0c1
CY
39122011-05-26 Chong Yidong <cyd@stupidchicken.com>
3913
3914 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3915 (converted_selections, conversion_fail_tag): New global variables.
3916 (x_selection_request_lisp_error): Free the above.
3917 (x_get_local_selection): Remove unnecessary code.
3918 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3919 of converted selections stored in converted_selections.
3920 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3921 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3922 (x_convert_selection): New function.
3923 (x_handle_selection_event): Simplify.
3924 (x_get_foreign_selection): Don't ignore incoming requests while
3925 waiting for an answer; this will fail when we implement
3926 SAVE_TARGETS, and seems unnecessary anyway.
3927 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3928 (Vx_sent_selection_functions): Doc fix.
3929
0f4aebc0
LL
39302011-05-26 Leo Liu <sdl.web@gmail.com>
3931
3932 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3933
e61124cd
YM
39342011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3935
3936 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3937
3938 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3939 for fringe update if it has periodic bitmap.
ac389d0c 3940 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3941 and fringe_bitmap_periodic_p.
3942
3943 * fringe.c (get_fringe_bitmap_data): New function.
3944 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3945 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3946 row. Mark glyph row for fringe update if periodicity changed.
3947
3948 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3949 for fringe update unless it has periodic bitmap.
3950
f16d9837
KH
39512011-05-25 Kenichi Handa <handa@m17n.org>
3952
3953 * xdisp.c (get_next_display_element): Set correct it->face_id for
3954 a static composition.
3955
e1b90ef6
LL
39562011-05-24 Leo Liu <sdl.web@gmail.com>
3957
3958 * deps.mk (fns.o):
3959 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3960
3961 * fns.c (crypto_hash_function, Fsha1): New function.
3962 (Fmd5): Use crypto_hash_function.
3963 (syms_of_fns): Add Ssha1.
3964
7400048f
PE
39652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3966
3967 * gnutls.c: Remove unused macros.
3968 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3969 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3970 Remove macros that are defined and never used.
3971 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3972
abb71cf4
CY
39732011-05-22 Chong Yidong <cyd@stupidchicken.com>
3974
3975 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3976 (Fx_get_selection_internal): Minor cleanup.
3977 (Fx_own_selection_internal): Rename arguments for consistency with
3978 select.el.
3979
6307db39
PE
39802011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3981
3982 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3983
f3d4e0a4
CY
39842011-05-22 Chong Yidong <cyd@stupidchicken.com>
3985
3986 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3987
4d8ade89
YM
39882011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3989
3990 * dispnew.c (scrolling_window): Don't exclude the case that the
3991 last enabled row in the desired matrix touches the bottom boundary.
3992
32078c8d
GM
39932011-05-21 Glenn Morris <rgm@gnu.org>
3994
3995 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3996 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3997 and add some more files.
32078c8d 3998
7285dc67
EZ
39992011-05-20 Eli Zaretskii <eliz@gnu.org>
4000
4001 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4002 report_file_error introduced by the change from 2011-05-07.
4003
89d1bd22
PE
40042011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4005
4006 * systime.h (Time): Define only if emacs is defined.
4007 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4008 where the include path doesn't have X11/X.h by default. See
4009 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4010
e23640bb 40112011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4012
4013 * composite.c (find_automatic_composition): Fix previous change.
4014
b9704ad9
GM
40152011-05-20 Glenn Morris <rgm@gnu.org>
4016
4017 * lisp.mk: New file, split from Makefile.in.
4018 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4019 (shortlisp): Remove.
4020 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4021
4a720484
GM
40222011-05-19 Glenn Morris <rgm@gnu.org>
4023
4024 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4025 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4026 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4027 (lisp): Set the order to that of loadup.el.
4028 (shortlisp): Make it a copy of $lisp.
4029 (SOME_MACHINE_LISP): Remove.
4030 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4031 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4032
a28d4396
KH
40332011-05-18 Kenichi Handa <handa@m17n.org>
4034
4035 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4036 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4037 (find_automatic_composition): Mostly rewrite for efficiency.
4038
a2b1fa8e
JB
40392011-05-18 Juanma Barranquero <lekktu@gmail.com>
4040
4041 * makefile.w32-in: Update dependencies.
4042
8e1f5610
CS
40432011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4044
4045 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4046 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4047
7025ee00 40482011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4049
cdfa6eab
PE
4050 Fix some integer overflow issues, such as string length overflow.
4051
06d6db33
PE
4052 * insdel.c (count_size_as_multibyte): Check for string overflow.
4053
2b4560a8
PE
4054 * character.c (lisp_string_width): Check for string overflow.
4055 Use EMACS_INT, not int, for string indexes and lengths; in
4056 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4057 the resulting string length overflows an EMACS_INT; instead,
4058 report a string overflow if no precision given. When checking for
4059 precision exhaustion, use a check that cannot possibly have
4060 integer overflow. (Bug#8675)
4061 * character.h (lisp_string_width): Adjust to new signature.
4062
cb93f9be
PE
4063 * alloc.c (string_overflow): New function.
4064 (Fmake_string): Use it. This doesn't change behavior, but saves
4065 a few bytes and will simplify future changes.
4066 * character.c (string_escape_byte8): Likewise.
4067 * lisp.h (string_overflow): New decl.
4068
1a1f3366
PE
4069 Fixups, following up to the user-interface timestamp change.
4070 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4071 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4072 * msdos.c (mouse_get_pos): Likewise.
4073 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4074 * w32gui.h (Time): Define by including "systime.h" rather than by
4075 declaring it ourselves. (Bug#8664)
4076
d4e3e4d3
PE
4077 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4078 * image.c (clear_image_cache): Likewise.
4079
f6a24d19
PE
4080 * term.c (term_mouse_position): Don't assume time_t wraparound.
4081
08dc5ae6
PE
4082 Be more systematic about user-interface timestamps.
4083 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4084 and sometimes 'EMACS_UINT', to represent these timestamps.
4085 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4086 This makes the code easier to follow, and makes it easier to catch
4087 integer overflow bugs such as Bug#8664.
4088 * frame.c (Fmouse_position, Fmouse_pixel_position):
4089 Use Time, not unsigned long, for user-interface timestamps.
4090 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4091 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4092 * keyboard.h (last_event_timestamp): Likewise.
4093 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4094 * menu.h (xmenu_show): Likewise.
4095 * term.c (term_mouse_position): Likewise.
4096 * termhooks.h (struct input_event.timestamp): Likewise.
4097 (struct terminal.mouse_position_hook): Likewise.
4098 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4099 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4100 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4101 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4102 what it was before.
4103 * menu.h, termhooks.h: Include "systime.h", for Time.
4104
8e55734a
PE
4105 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4106 Don't assume that the difference between two unsigned long values
4107 can fit into an integer. At this point, we know button_down_time
4108 <= event->timestamp, so the difference must be nonnegative, so
4109 there's no need to cast the result if double-click-time is
4110 nonnegative, as it should be; check that it's nonnegative, just in
4111 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4112 apart (about 25 days). (Bug#8664)
8e55734a 4113
841f1b75 4114 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4115 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4116
3e26f69c
PE
4117 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4118 that always fit in int. Use a sentinel instead of a counter, to
4119 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4120 * frame.h (struct frame): Use int for menu_bar_items_used
4121 instead of EMACS_INT, since it always fits in int.
3e26f69c 4122
5cc152c0
PE
4123 * menu.c (grow_menu_items): Check for int overflow.
4124
d89eb65e
PE
4125 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4126
5235bd3e
PE
4127 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4128 Before, the code was not consistent. These values cannot exceed
4129 2**31 - 1 so there's no need to make them unsigned.
4130 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4131 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4132 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4133 as modifiers.
4134 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4135
bc827e23
PE
4136 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4137 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4138 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4139 presumably because the widths might not match.
4140
78eb494e
PE
4141 * window.c (size_window): Avoid needless test at loop start.
4142
04f2d78b
CB
41432011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4144
4145 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4146
d2fc7e3d 41472011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4148
4149 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4150
d2fc7e3d 41512011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4152
4153 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4154 `width' to `bar_area_x' and `bar_area_width', respectively.
4155 (x_scroll_run): Take account of fringe background extension.
4156
04f2d78b
CB
4157 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4158 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4159 `bar_area_width', respectively.
4160 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4161 background extension.
4162
79b70037
GM
41632011-05-10 Jim Meyering <meyering@redhat.com>
4164
4165 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4166
2f142cc5
JB
41672011-05-10 Juanma Barranquero <lekktu@gmail.com>
4168
4169 * image.c (Finit_image_library): Return t for built-in image types,
4170 like pbm and xbm. (Bug#8640)
4171
57679c86
AS
41722011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4173
4174 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4175
888c9e86
EZ
41762011-05-07 Eli Zaretskii <eliz@gnu.org>
4177
b0512a1d
EZ
4178 * w32console.c (Fset_screen_color): Doc fix.
4179 (Fget_screen_color): New function.
4180 (syms_of_ntterm): Defsubr it.
4181
7285dc67
EZ
4182 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4183 unlink the temporary file if Fcall_process didn't create it in the
4184 first place.
4185 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4186 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4187 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4188 cue to call_process_cleanup not to close that handle.
4189
4d3fcc8e
BK
41902011-05-07 Ben Key <bkey76@gmail.com>
4191
4192 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4193 one of two shell specific rules, either bootstrap-temacs-CMD or
4194 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4195 to the previous implementation of the bootstrap-temacs rule.
4196 The bootstrap-temacs-CMD rule is similar to the previous
4197 implementation of the bootstrap-temacs rule except that it
4198 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4199 variable.
4200
4201 These changes, along with some changes to nt/configure.bat,
4202 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4203 earlier fix to add support for --cflags and --ldflags options
4204 that include quotes so that it works whether make uses cmd or
4205 sh as the shell.
4206
b4289b64
MA
42072011-05-06 Michael Albinus <michael.albinus@gmx.de>
4208
4209 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4210 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4211 is a constant.
4212 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4213 a string. Handle both cases.
4214 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4215 (Fdbus_register_method): Use Qinvalid_function.
4216
af4c0e28
JB
42172011-05-06 Juanma Barranquero <lekktu@gmail.com>
4218
4219 * makefile.w32-in: Update dependencies.
4220 (LISP_H): Add inttypes.h and stdin.h.
4221 (PROCESS_H): Add unistd.h.
4222
c51453d9
EZ
42232011-05-06 Eli Zaretskii <eliz@gnu.org>
4224
4225 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4226 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4227
8ff0ac3c 42282011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4229
4c4b566b
PE
4230 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4231
aab2b9b5
PE
4232 * term.c (vfatal): Remove stray call to va_end.
4233 It's not needed and the C Standard doesn't allow it here anyway.
4234
c378da0b
PE
4235 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4236 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4237
288b08c7
PE
4238 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4239 bytes.
4240
e3601888
PE
4241 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4242
db6c0e74
PE
4243 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4244
dd5963ea
PE
4245 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4246
88c9450f
PE
4247 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4248
2f9442b8
PE
4249 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4250
c032b5f8
PE
4251 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4252 * charset.c (Fdefine_charset_internal): Don't initialize
4253 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4254 32-bit int (Bug#8600).
a108c10b
PE
4255
4256 * lread.c (read_integer): Be more consistent with string-to-number.
4257 Use string_to_number to do the actual conversion; this avoids
4258 rounding errors and fixes some other screwups. Without this fix,
4259 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4260 (digit_to_number): Move earlier, for benefit of read_integer.
4261 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4262 not a digit in any supported base. (Bug#8602)
a108c10b 4263
ad5f9eea
PE
4264 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4265
aec1708a
PE
4266 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4267 to match comment at start of function. This also removes a
4268 GCC warning about overflow in a 32+64-bit port.
4269
47be4ab5
PE
4270 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4271
371cac43
PE
4272 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4273 Reported by Stefan Monnier in
4274 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4275 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4276 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4277
d01a7826
PE
4278 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4279 (EMACS_UINTPTR): Likewise, with uintptr_t.
4280
7fd47d5c
PE
4281 * lisp.h: Prefer 64-bit EMACS_INT if available.
4282 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4283 on 32-bit hosts that have 64-bit int, so that they can access
4284 large files.
122b0c86
PE
4285 However, temporarily disable this change unless the temporary
4286 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4287
8727937b
PE
4288 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4289
8ac068ac
PE
4290 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4291 This removes an assumption that EMACS_INT and long are the same
4292 width as pointers. The assumption is true for Emacs porting targets
4293 now, but we want to make other targets possible.
4294 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4295 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4296 In the rest of the code, change types of integers that hold casted
4297 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4298 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4299 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4300 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4301 No need to cast type when ORing.
4302 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4303 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4304 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4305 assume EMACS_INT is the same width as char *.
4306 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4307 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4308 Remove no-longer-needed casts.
4309 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4310 (xg_tool_bar_help_callback, xg_make_tool_item):
4311 Use EMACS_INTPTR to hold an integer
4312 that will be cast to void *; this can avoid a GCC warning
4313 if EMACS_INT is not the same width as void *.
4314 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4315 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4316 (current_message_1, set_message_1):
4317 Use a local to convert to proper width without a cast.
4318 * xmenu.c (dialog_selection_callback): Likewise.
4319
ede49d71
PE
4320 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4321 Also, don't assume VALBITS / RAND_BITS is less than 5,
4322 and don't rely on undefined behavior when shifting a 1 left into
4323 the sign bit.
4324 * lisp.h (get_random): Change signature to match.
4325
2f30ecd0
PE
4326 * lread.c (hash_string): Use size_t, not int, for hash computation.
4327 Normally we prefer signed values; but hashing is special, because
4328 it's better to use unsigned division on hash table sizes so that
4329 the remainder is nonnegative. Also, size_t is the natural width
4330 for hashing into memory. The previous code used 'int', which doesn't
4331 retain enough info to hash well into very large tables.
4332 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4333
2a866e7b
PE
4334 * dbusbind.c: Don't possibly lose pointer info when converting.
4335 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4336 Use XPNTR rather than XHASH, so that the high-order bits of
4337 the pointer aren't lost when converting through void *.
4338
51639eac
PE
4339 * eval.c (Fautoload): Don't double-shift a pointer.
4340
92394119
PE
4341 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4342
dbdb9a7c
JB
43432011-05-06 Juanma Barranquero <lekktu@gmail.com>
4344
4345 * gnutls.c (DEF_GNUTLS_FN):
4346 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4347
db7a0b4f
AS
43482011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4349
4350 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4351 marker. (Bug#8610)
4352
f7ff1b0f 43532011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4354
4355 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4356 New version that can reserve upto 2GB of heap space.
4357
f7ff1b0f 43582011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4359
4360 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4361
639c109b
TZ
43622011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4363
4364 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4365 `gnutls_certificate_set_x509_key_file'.
4366
d2127135
JB
43672011-05-05 Juanma Barranquero <lekktu@gmail.com>
4368
4369 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4370 Update dependencies.
4371
e968f4f3
JB
43722011-05-04 Juanma Barranquero <lekktu@gmail.com>
4373
4374 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4375 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4376 Remove unused parameter `fildes'.
4377 * process.c (read_process_output, send_process): Don't pass it.
4378
84d358f0
JB
43792011-05-04 Juanma Barranquero <lekktu@gmail.com>
4380
4381 Fix previous change: the library cache is defined in w32.c.
4382 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4383 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4384
0898ca10
JB
43852011-05-04 Juanma Barranquero <lekktu@gmail.com>
4386
4387 Implement dynamic loading of GnuTLS on Windows.
4388
4389 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4390 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4391 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4392 Declare.
4393
4394 * gnutls.c (Qgnutls_dll): Define.
4395 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4396 (gnutls_*): Declare function pointers.
4397 (init_gnutls_functions): New function to initialize function pointers.
4398 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4399 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4400 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4401 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4402 (emacs_gnutls_write, emacs_gnutls_read)
4403 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4404 (Fgnutls_available_p): New function.
4405 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4406 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4407 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4408
4409 * image.c: Include w32.h.
4410 (Vimage_type_cache): Delete.
4411 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4412 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4413 (w32_delayed_load): Move to w32.c.
4414
4415 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4416
4417 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4418 (w32_delayed_load): Move from image.c. When loading a library, record
4419 its filename in the :loaded-from property of the library id.
4420 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4421 Initialize and staticpro them.
4422 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4423
4424 * process.c: Include lisp.h before w32.h, not after.
4425 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4426 instead of gnutls_record_check_pending.
4427
4428 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4429
ff4de4aa
TZ
44302011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4431
4432 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4433 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4434 as passed in.
4435
abe95abb
JD
44362011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4437
4438 * xterm.c (x_set_frame_alpha): Do not set property on anything
4439 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4440
e16e55d4
JB
44412011-05-02 Juanma Barranquero <lekktu@gmail.com>
4442
4443 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4444
bafcf6a5
JB
44452011-05-02 Juanma Barranquero <lekktu@gmail.com>
4446
4447 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4448 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4449 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4450 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4451 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4452 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4453 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4454 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4455 (Qgnutls_bootprop_callbacks_verify): Make static.
4456
e7a6747f
AS
44572011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4458
19ed11ba
AS
4459 * callproc.c: Indentation fixup.
4460
e7a6747f 4461 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4462 (wait_for_termination, interruptible_wait_for_termination):
4463 Move after wait_for_termination_1.
e7a6747f 4464
1ef14cb4
LMI
44652011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4466
4467 * sysdep.c (interruptible_wait_for_termination): New function
4468 which is like wait_for_termination, but allows keyboard
4469 interruptions.
4470
4471 * callproc.c (Fcall_process): Add (:file "file") as an option for
4472 the STDOUT buffer.
4473 (Fcall_process_region): Ditto.
4474
330d880c
EZ
44752011-04-30 Eli Zaretskii <eliz@gnu.org>
4476
8db90b73
EZ
4477 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4478 rather than `XVECTOR (FOO)->size'.
4479
330d880c
EZ
4480 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4481 inttypes.h, as a gnulib replacement is used if it not available in
4482 system headers.
4483
15cbd324
EZ
44842011-04-21 Eli Zaretskii <eliz@gnu.org>
4485
4486 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4487 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4488 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4489
4490 * coding.c (coding_alloc_by_realloc): Error out if destination
4491 will grow beyond MOST_POSITIVE_FIXNUM.
4492 (decode_coding_emacs_mule): Abort if there isn't enough place in
4493 charbuf for the composition carryover bytes. Reserve an extra
4494 space for up to 2 characters produced in a loop.
4495 (decode_coding_iso_2022): Abort if there isn't enough place in
4496 charbuf for the composition carryover bytes.
4497
44982011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4499
ae940cca
EZ
4500 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4501 aborting when %lld or %lll format is passed.
4502 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4503 %llo or %llx format is passed. (Bug#8545)
4504
03ab8921
EZ
4505 * window.c (window_scroll_line_based): Use a marker instead of
4506 simple variables to record original value of point. (Bug#7952)
4507
afda1437
EZ
4508 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4509 produced by %s or %c overflows available buffer space. (Bug#8545)
4510
f76dee0c
PE
45112011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4514 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4515
fdc5744d
JB
45162011-04-28 Juanma Barranquero <lekktu@gmail.com>
4517
4518 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4519
638f053a
JB
45202011-04-28 Juanma Barranquero <lekktu@gmail.com>
4521
4522 * keyboard.c (Qdelayed_warnings_hook): Define.
4523 (command_loop_1): Run `delayed-warnings-hook'
4524 if Vdelayed_warnings_list is non-nil.
4525 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4526 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4527
d178f871
EZ
45282011-04-28 Eli Zaretskii <eliz@gnu.org>
4529
4530 * doprnt.c (doprnt): Don't return value smaller than the buffer
4531 size if the message was truncated. (Bug#8545).
4532
b124fd93
JB
45332011-04-28 Juanma Barranquero <lekktu@gmail.com>
4534
4535 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4536 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4537
e810457d
PE
45382011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4541
ea51cceb
JB
45422011-04-27 Juanma Barranquero <lekktu@gmail.com>
4543
4544 * makefile.w32-in: Update dependencies.
4545
94dcfacf
EZ
45462011-04-27 Eli Zaretskii <eliz@gnu.org>
4547
4548 Improve `doprnt' and its usage. (Bug#8545)
4549 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4550 `format_end'. Remove support for %l as a conversion specifier.
4551 Don't use xrealloc. Improve diagnostics when the %l size modifier
4552 is used. Update the commentary.
4553
4554 * eval.c (verror): Simplify calculation of size_t.
4555
4556 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4557 messages.
4558
f61f41d7
PE
45592011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4560
4561 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4562 change.
4563
96fb4434
PE
45642011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4567 This makes this file independent of the recent pseudovector change.
4568
671875da 45692011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4570
69e9b5a3
PE
4571 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4572
b5f869a7 4573 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4574 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4575 Remove unused local.
c8926152 4576 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4577
841a1577 4578 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4579 GCC 4.6.0 optimizes based on type-based alias analysis.
4580 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4581 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4582 != &v->size, and therefore "v->size = 1; b->size = 2; return
4583 v->size;" must therefore return 1. This assumption is incorrect
4584 for Emacs, since it type-puns struct Lisp_Vector * with many other
4585 types. To fix this problem, this patch adds a new type struct
f904488f 4586 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4587 and pseudovectors, and helps optimizing compilers not get fooled
4588 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4589 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4590 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4591 the size member.
eab3844f
PE
4592 (XSETPVECTYPE): Rewrite in terms of new macro.
4593 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4594 This is a bit clearer, and further avoids the possibility of
4595 undesirable aliasing.
4596 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4597 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4598 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4599 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4600 (ASIZE): Now uses header.size rather than size.
4601 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4602 to avoid the hassle of writing XVECTOR (foo)->header.size.
4603 (struct vectorlike_header): New type.
eab3844f
PE
4604 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4605 object, to help avoid aliasing.
4606 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4607 (SUBRP): Likewise, since Lisp_Subr is a special case.
4608 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4609 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4610 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4611 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4612 changed to be "header.size" and "header.next".
4613 * buffer.h (struct buffer): Likewise.
4614 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4615 * frame.h (struct frame): Likewise.
4616 * process.h (struct Lisp_Process): Likewise.
4617 * termhooks.h (struct terminal): Likewise.
4618 * window.c (struct save_window_data, struct saved_window): Likewise.
4619 * window.h (struct window): Likewise.
4620 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4621 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4622 * buffer.c (init_buffer_once): Likewise.
4623 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4624 special case.
4625 * process.c (Fformat_network_address): Use local var for size,
4626 for brevity.
4627
0df1eac5
PE
4628 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4629
847ab9d1 4630 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4631 * data.c (atof): Remove decl; no longer used or needed.
4632 (digit_to_number): Move to lread.c.
4633 (Fstring_to_number): Use new string_to_number function, to be
4634 consistent with how the Lisp reader treats infinities and NaNs.
4635 Do not assume that floating-point numbers represent EMACS_INT
4636 without losing information; this is not true on most 64-bit hosts.
4637 Avoid double-rounding errors, by insisting on integers when
4638 parsing non-base-10 numbers, as the documentation specifies.
4639 * lisp.h (string_to_number): New decl, replacing ...
4640 (isfloat_string): Remove.
bc0a5c13 4641 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4642 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4643 appears to have been a coding error. Similarly, do not accept
4644 strings like +-1e0 as floating point numbers. Do not report
4645 overflow for integer overflows unless the base is not 10 which
4646 means we have no simple and reliable way to continue.
4647 Break out the floating-point parsing into a new
4648 function string_to_number, so that Fstring_to_number parses
4649 floating point numbers consistently with the Lisp reader.
04f2d78b 4650 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4651 (E_CHAR, EXP_INT): Remove, replacing with ...
4652 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4653 (string_to_number): New function, replacing isfloat_string.
4654 This function checks for valid syntax and produces the resulting
4655 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4656 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4657 so that overflow for non-base-10 numbers is reported only when
4658 there's no portable and simple way to convert to floating point.
452f4150 4659
67769ffc
PE
4660 * textprop.c (set_text_properties_1): Rewrite for clarity,
4661 and to avoid GCC warning about integer overflow.
4662
c20db43f
PE
4663 * intervals.h (struct interval): Use EMACS_INT for members
4664 where EMACS_UINT might cause problems. See
4665 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4666 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4667 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4668 All uses changed.
37aa2f85
PE
4669 (offset_intervals): Tell GCC not to worry about length overflow
4670 when negating a negative length.
c20db43f 4671
2538aa2f
PE
4672 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4673 (overrun_check_free): Likewise.
4674
f2d3008d
PE
4675 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4676 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4677 word size.
4678
ec8df744
PE
4679 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4680 (gnutls_make_error): Rename local to avoid shadowing.
4681 (gnutls_emacs_global_deinit): ifdef out; not used.
4682 (Fgnutls_boot): Use const for pointer to readonly storage.
4683 Comment out unused local. Fix pointer signedness problems.
4684
640ee02d
PE
4685 * lread.c (openp): Don't stuff size_t into an 'int'.
4686 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4687 about possible signed overflow.
4688
6048fb2a
PE
4689 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4690 (GDK_KEY_g): Don't define if already defined.
4691 (xg_prepare_tooltip): Avoid pointer signedness problem.
4692 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4693
fa3c87e1
PE
4694 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4695 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4696
2172544b
PE
4697 * xfns.c (Fx_window_property): Simplify a bit,
4698 to make a bit faster and to avoid GCC 4.6.0 warning.
4699 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4700
9b821a21
PE
4701 * fns.c (internal_equal): Don't assume size_t fits in int.
4702
3c616cfa
PE
4703 * alloc.c (compact_small_strings): Tighten assertion a little.
4704
c2982e87
PE
4705 Replace pEd with more-general pI, and fix some printf arg casts.
4706 * lisp.h (pI): New macro, generalizing old pEd macro to other
4707 conversion specifiers. For example, use "...%"pI"d..." rather
4708 than "...%"pEd"...".
4709 (pEd): Remove. All uses replaced with similar uses of pI.
4710 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4711 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4712 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4713 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4714 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4715 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4716 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4717 64-bit hosts.
4718 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4719 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4720 * print.c (safe_debug_print, print_object): Likewise.
4721 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4722 to int.
6f04d126
PE
4723 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4724 avoiding the 0 flag, which is not portable.
c2982e87
PE
4725 * process.c (Fmake_network_process): Use pI to avoid cast.
4726 * region-cache.c (pp_cache): Likewise.
4727 * xdisp.c (decode_mode_spec): Likewise.
4728 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4729 behavior on 64-bit hosts with printf arg.
6f04d126 4730 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4731 (x_stop_queuing_selection_requests): Likewise.
4732 (x_get_window_property): Don't truncate byte count to an 'int'
4733 when tracing.
0b432f21 4734
5e073ec7
PE
4735 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4736 here, since it parses constructs like leading '-' and spaces,
4737 which are not wanted; and it overflows with large numbers.
4738 Instead, simply match F[0-9]+, which is what is wanted anyway.
4739
36372bf9
PE
4740 * alloc.c: Remove unportable assumptions about struct layout.
4741 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4742 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4743 (allocate_vectorlike, make_pure_vector): Use the new macros,
4744 plus offsetof, to remove unportable assumptions about struct layout.
4745 These assumptions hold on all porting targets that I know of, but
4746 they are not guaranteed, they're easy to remove, and removing them
4747 makes further changes easier.
4748
0b432f21
PE
4749 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4750 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4751 (string_overrun_cookie): Now const. Use initializers that
4752 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4753 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4754 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4755 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4756 multiple of sizeof (EMACS_INT); it need not be, if
4757 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4758 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4759
895009e1
JB
47602011-04-26 Juanma Barranquero <lekktu@gmail.com>
4761
4762 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4763
6a7a1b0b
TZ
47642011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4765
4766 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4767 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4768 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4769
841a1577 47702011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4771
4772 * lisp.h (Qdebug): List symbol.
895009e1 4773 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4774 * keyboard.c (debug-on-event): New variable.
4775 (handle_user_signal): Break into debugger when debug-on-event
4776 matches the current signal symbol.
4777
f2d3ba6f
DN
47782011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4779
4780 * alloc.c (check_sblock, check_string_bytes)
4781 (check_string_free_list): Convert to standard C.
4782
42ce4c63
TZ
47832011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4784
4785 * w32.c (emacs_gnutls_push): Fix typo.
4786
825cd63c
EZ
47872011-04-25 Eli Zaretskii <eliz@gnu.org>
4788
fb11d64d
EZ
4789 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4790 "cast to pointer from integer of different size".
4791
825cd63c
EZ
4792 Improve doprnt and its use in verror. (Bug#8545)
4793 * doprnt.c (doprnt): Document the set of format control sequences
4794 supported by the function. Use SAFE_ALLOCA instead of always
4795 using `alloca'.
4796
4797 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4798 is one byte too soon. Don't use xrealloc; instead xfree and
4799 xmalloc anew.
4800
e061a11b
TZ
48012011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4802
4803 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4804 callbacks stage.
4805
4806 * gnutls.c: Renamed global_initialized to
4807 gnutls_global_initialized. Added internals for the
4808 :verify-hostname-error, :verify-error, and :verify-flags
4809 parameters of `gnutls-boot' and documented those parameters in the
4810 docstring. Start callback support.
9173deec
JB
4811 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4812 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4813 on error. Return error code.
e061a11b
TZ
4814 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4815 (emacs_gnutls_read): Likewise.
4816 (Fgnutls_boot): Return handshake error code.
4817 (emacs_gnutls_handle_error): New function.
4818 (wsaerror_to_errno): Likewise.
4819
4820 * w32.h (emacs_gnutls_pull): Add prototype.
4821 (emacs_gnutls_push): Likewise.
4822
4823 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4824 (emacs_gnutls_push): Likewise.
4825
48262011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4827
4828 * process.c (wait_reading_process_output): Check if GnuTLS
4829 buffered some data internally if no FDs are set for TLS
4830 connections.
4831
4832 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4833 (LIBS): Link to USER_LIBS.
4834 ($(BLD)/gnutls.$(0)): New target.
4835
fa6996bc
EZ
48362011-04-24 Eli Zaretskii <eliz@gnu.org>
4837
eb35682e
EZ
4838 * xdisp.c (handle_single_display_spec): Rename the
4839 display_replaced_before_p argument into display_replaced_p, to
4840 make it consistent with the commentary. Fix typos in the
4841 commentary.
4842
e2ad650c
EZ
4843 * textprop.c (syms_of_textprop): Remove dead code.
4844 (copy_text_properties): Delete obsolete commentary about an
4845 interface that was deleted long ago. Fix typos in the description
4846 of arguments.
4847
1b2de274
EZ
4848 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4849 to changes in oldXMenu/XMenu.h from 2011-04-16.
4850 <menu_help_message, prev_menu_help_message>: Constify.
4851 (IT_menu_make_room): menu->help_text is now `const char **';
4852 adjust.
4853
4854 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4855 to changes in oldXMenu/XMenu.h from 2011-04-16.
4856 (struct XMenu): Declare `help_text' `const char **'.
4857
4858 * xfaces.c <Qunspecified>: Make extern again.
4859
4860 * syntax.c: Include sys/types.h before including regex.h, as
4861 required by Posix.
4862
762b15be
EZ
4863 * doc.c (get_doc_string): Improve the format passed to `error'.
4864
4865 * doprnt.c (doprnt): Improve commentary.
4866
4867 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4868
4869 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4870 them with etags.
4871
f1052e5d
EZ
4872 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4873 changes in globals.h immediately force recompilation.
762b15be
EZ
4874 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4875 $(CURDIR)/s/ms-w32.h.
4876 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4877
fa6996bc
EZ
4878 * character.c (Fchar_direction): Function deleted.
4879 (syms_of_character): Don't defsubr it.
4880 <char-direction-table>: Deleted.
4881
e6c3da20
EZ
48822011-04-23 Eli Zaretskii <eliz@gnu.org>
4883
4884 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4885 * doprnt.c: Include limits.h.
4886 (SIZE_MAX): New macro.
04f2d78b
CB
4887 (doprnt): Return a size_t value. 2nd arg is now size_t.
4888 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4889 Improve overflow protection. Support `l' modifier for integer
4890 conversions. Support %l conversion. Don't assume an EMACS_INT
4891 argument for integer conversions and for %c.
4892
4893 * lisp.h (doprnt): Restore prototype.
4894
4895 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4896 $(SRC)/character.h.
4897
4898 * Makefile.in (base_obj): Add back doprnt.o.
4899
4900 * deps.mk (doprnt.o): Add back prerequisites.
4901 (callint.o): Depend on character.h.
4902
4903 * eval.c (internal_lisp_condition_case): Include the handler
4904 representation in the error message.
4905 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4906 when breaking from the loop.
4907
4908 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4909
4910 * callint.c (Fcall_interactively): When displaying error message
4911 about invalid control letter, pass the character's codepoint, not
4912 a pointer to its multibyte form. Improve display of the character
4913 in octal and display also its hex code.
4914
4915 * character.c (char_string): Use %x to display the (unsigned)
4916 codepoint of an invalid character, to avoid displaying a bogus
4917 negative value.
4918
4919 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4920 `error', not SYMBOL_NAME itself.
4921
4922 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4923 character arguments to `error'.
4924
4925 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4926 to `error' in error message about FINAL_CHAR argument. Make sure
4927 FINAL_CHAR is a character, and use %c when it is passed as
4928 argument to `error'.
4929
4ffd0d6b 49302011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4931
4932 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4933
4934 * w32.c: Include <time.h>.
4935 (sys_localtime): New function.
4936
4ffd0d6b 49372011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4938
4939 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4940
4ffd0d6b 4941 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4942
4ffd0d6b 49432011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4944
4ffd0d6b
GM
4945 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4946 zombies (Bug#8467).
aac0c6e3 4947
04c56954
EZ
49482011-04-19 Eli Zaretskii <eliz@gnu.org>
4949
4950 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4951 gl_state.e_property when gl_state.object is Qt.
4952
4953 * insdel.c (make_gap_larger): Remove limitation of buffer size
4954 to <= INT_MAX.
4955
16a43933
CY
49562011-04-18 Chong Yidong <cyd@stupidchicken.com>
4957
4958 * xdisp.c (lookup_glyphless_char_display)
4959 (produce_glyphless_glyph): Handle cons cell entry in
4960 glyphless-char-display.
4961 (Vglyphless_char_display): Document it.
4962
4963 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4964 glyphless-char-display.
4965
4581706e
CY
49662011-04-17 Chong Yidong <cyd@stupidchicken.com>
4967
4968 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4969
4970 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4971
4972 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4973 definition for no-X builds.
4974
4887c6e2 49752011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4976
fd35b6f9
PE
4977 Static checks with GCC 4.6.0 and non-default toolkits.
4978
5c1ccb01
PE
4979 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4980
006c5daa
PE
4981 * process.c (keyboard_bit_set): Define only if SIGIO.
4982 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4983 (send_process): Repair possible setjmp clobbering.
4984
efc736d3
PE
4985 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4986
4e2fe2e6
PE
4987 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4988
f97334a2
PE
4989 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4990
4e75f29d
PE
4991 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4992 Define only if needed.
4993
90efadd1
PE
4994 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4995 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4996 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4997
3c647824
PE
4998 * dispextern.h (struct redisplay_interface): Rename param
4999 to avoid shadowing.
e264f262 5000 * termhooks.h (struct terminal): Likewise.
761383f4 5001 * xterm.c (xembed_send_message): Likewise.
3c647824 5002
b58c5c4a
PE
5003 * insdel.c (make_gap_smaller): Define only if
5004 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5005
cad59032
PE
5006 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5007 it.
5008
c339dc2e
PE
5009 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5010 so that we aren't warned about unused symbols.
5011
91a3e27b
PE
5012 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5013
399c71d3 5014 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5015
8ffc96f5
PE
5016 * xfns.c (x_real_positions): Mark locals as initialized.
5017
eef9bc79
PE
5018 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5019
098db9dd
PE
5020 * xterm.c: Fix problems found by static analysis with other toolkits.
5021 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5022 (x_dispatch_event): Declare static if USE_GTK, and
5023 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5024 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5025 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5026 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5027 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5028
eb18f6cc
PE
5029 * xmenu.c (menu_help_callback): Pointer type fixes.
5030 Use const pointers when pointing at readonly data. Avoid pointer
5031 signedness clashes.
5032 (FALSE): Remove unused macro.
5033 (update_frame_menubar): Remove unused decl.
5034
1fe72bf8
PE
5035 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5036
60d9e1db
PE
5037 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5038 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5039 (single_menu_item): Rename local to avoid shadowing.
5040
39261c26
PE
5041 * keyboard.c (make_lispy_event): Remove unused local var.
5042
018c5e19
PE
5043 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5044 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5045
63d2b86e
PE
5046 * bitmaps: Change bitmaps from unsigned char back to the X11
5047 compatible char. Avoid the old compiler warnings about
5048 out-of-range initializers by using, for example, '\xab' rather
5049 than 0xab.
5050
aefd87e1
PE
5051 * xgselect.c (xgselect_initialize): Check vs interface
5052 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5053
bf501fb9
PE
5054 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5055
e9829fdf
PE
5056 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5057 to read-only memory.
5058
1086c095
PE
5059 * fns.c (vector): Remove; this old hack is no longer needed.
5060
2baccd04 5061 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5062 Remove unused var.
dde42981 5063 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5064
72391843 5065 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5066
436c16df 5067 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5068 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5069 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5070
92bb796d 5071 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5072 (x_term_init): Remove local to avoid shadowing.
92bb796d 5073
764430a3 5074 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5075
5076 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5077 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5078
d1dfb56c
EZ
50792011-04-16 Eli Zaretskii <eliz@gnu.org>
5080
c4354cb4
EZ
5081 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5082
d1dfb56c
EZ
5083 Fix regex.c, syntax.c and friends for buffers > 2GB.
5084 * syntax.h (struct gl_state_s): Declare character position members
5085 EMACS_INT.
5086
5087 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5088
04f2d78b
CB
5089 * textprop.c (verify_interval_modification, interval_of):
5090 Declare arguments EMACS_INT.
d1dfb56c
EZ
5091
5092 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5093 EMACS_INT.
5094
5095 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5096
5097 * indent.c (Fvertical_motion): Local variable it_start is now
5098 EMACS_INT.
5099
5100 * regex.c (re_match, re_match_2, re_match_2_internal)
5101 (bcmp_translate, regcomp, regexec, print_double_string)
5102 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5103 (re_compile_pattern, re_exec): Declare arguments and local
5104 variables `size_t' and `ssize_t' and return values `regoff_t', as
5105 appropriate.
5106 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5107 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5108 <compile_stack_type>: `size' and `avail' are now `size_t'.
5109
5110 * regex.h <regoff_t>: Use ssize_t, not int.
5111 (re_search, re_search_2, re_match, re_match_2): Arguments that
5112 specify buffer/string position and length are now ssize_t and
5113 size_t. Return type is regoff_t.
5114
613052cd
BK
51152011-04-16 Ben Key <bkey76@gmail.com>
5116
5117 * nsfont.m: Fixed bugs in ns_get_family and
5118 ns_descriptor_to_entity that were caused by using free to
5119 deallocate memory blocks that were allocated by xmalloc (via
5120 xstrdup). This caused Emacs to crash when compiled with
5121 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5122 --enable-checking=xmallocoverrun). xfree is now used to
5123 deallocate these memory blocks.
5124
4170f62f 51252011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5126
71b41406
PE
5127 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5128
9587a89d
PE
5129 emacs_write: Accept and return EMACS_INT for sizes.
5130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5131 et seq.
5132 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5133 Accept and return EMACS_INT.
5134 (emacs_gnutls_write): Return the number of bytes written on
5135 partial writes.
5136 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5137 (emacs_read, emacs_write): Remove check for negative size, as the
5138 Emacs source code has been audited now.
9587a89d
PE
5139 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5140 (emacs_read, emacs_write): Use it.
273a5f82
PE
5141 * process.c (send_process): Adjust to the new signatures of
5142 emacs_write and emacs_gnutls_write. Do not attempt to store
5143 a byte offset into an 'int'; it might overflow.
9587a89d 5144 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5145
3e047f51
PE
5146 * sound.c: Don't assume sizes fit in 'int'.
5147 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5148 Return EMACS_INT, not int.
3e047f51 5149 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5150 Accept EMACS_INT, not int.
5151 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5152 record read return values.
5153
cc39a9db
BK
51542011-04-15 Ben Key <bkey76@gmail.com>
5155
c9d0ec6d
JB
5156 * keyboard.c (Qundefined): Don't declare static since it is used
5157 in nsfns.m.
5158 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5159 static since they are used in nsfont.m.
cc39a9db 5160
6c60eb9f
SM
51612011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * process.c (Qprocessp): Don't declare static.
5164 * lisp.h (Qprocessp): Declare again.
5165
7990b61a
JB
51662011-04-15 Juanma Barranquero <lekktu@gmail.com>
5167
5168 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5169
5d4cb038
PE
51702011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5171
8bd7b830 5172 Improve C-level modularity by making more things 'static'.
cd64ea1d 5173
e3b27b31
PE
5174 Don't publish debugger-only interfaces to other modules.
5175 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5176 (verify_bytepos, count_markers): Move decls to the only modules
5177 that need them.
5178 * region-cache.h (pp_cache): Likewise.
5179 * window.h (check_all_windows): Likewise.
5180 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5181
5d4cb038
PE
5182 * sysdep.c (croak): Now static, if
5183 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5184 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5185
5186 * alloc.c (refill_memory_reserve): Now static if
5187 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5188 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5189
e87b6180
PE
5190 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5191 Define only if USE_LUCID.
5192
ac64929e
PE
5193 * xrdb.c (x_customization_string, x_rm_string): Now static.
5194
6f37259d
PE
5195 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5196 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5197
1683e3ab
PE
5198 * xdisp.c (draw_row_with_mouse_face): Now static.
5199 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5200
de9c2632
PE
5201 * window.h (check_all_windows): Mark externally visible.
5202
2b96acb7
PE
5203 * window.c (window_deletion_count): Now static.
5204
5205 * undo.c: Make symbols static if they're not exported.
5206 (last_undo_buffer, last_boundary_position, pending_boundary):
5207 Now static.
5208
50436f33
PE
5209 * textprop.c (interval_insert_behind_hooks): Now static.
5210 (interval_insert_in_front_hooks): Likewise.
5211
64520e5c
PE
5212 * term.c: Make symbols static if they're not exported.
5213 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5214 (max_frame_lines, tty_set_terminal_modes):
5215 (tty_reset_terminal_modes, tty_turn_off_highlight):
5216 (get_tty_terminal): Now static.
5217 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5218 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5219 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5220 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5221 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5222
1fa53021
PE
5223 * sysdep.c: Make symbols static if they're not exported.
5224 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5225 Now static.
5226 (sigprocmask_set, full_mask): Remove; unused.
5227 (wait_debugging): Mark as visible.
5228 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5229 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5230
d4b43b22
PE
5231 * syntax.c (syntax_temp): Define only if !__GNUC__.
5232
b7c513d0
PE
5233 * sound.c (current_sound_device, current_sound): Now static.
5234
989b29ad
PE
5235 * search.c (searchbufs, searchbuf_head): Now static.
5236
13a55a78
PE
5237 * scroll.c (scroll_cost): Remove; unused.
5238 * dispextern.h (scroll_cost): Remove decl.
5239
de68a1fc
PE
5240 * region-cache.h (pp_cache): Mark as externally visible.
5241
40ccffa6
PE
5242 * process.c: Make symbols static if they're not exported.
5243 (process_tick, update_tick, create_process, chan_process):
5244 (Vprocess_alist, proc_buffered_char, datagram_access):
5245 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5246 (deactivate_process): Mark defn as static, as well as decl.
5247 * lisp.h (create_process): Remove decl.
5248 * process.h (chan_process, Vprocess_alist): Remove decls.
5249
ad64fc97
PE
5250 * print.c: Make symbols static if they're not exported.
5251 (print_depth, new_backquote_output, being_printed, print_buffer):
5252 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5253 (print_interval, print_number_index, initial_stderr_stream):
5254 Now static.
5255 * lisp.h (Fprinc): Remove decl.
5256 (debug_output_compilation_hack): Mark as externally visible.
5257
adddb265
PE
5258 * sysdep.c (croak): Move decl from here to syssignal.h.
5259 * syssignal.h (croak): Put it here, so the API can be checked when
5260 'croak' is called from dissociate_if_controlling_tty.
5261
1717ede2
PE
5262 * minibuf.c: Make symbols static if they're not exported.
5263 (minibuf_save_list, choose_minibuf_frame): Now static.
5264 * lisp.h (choose_minibuf_frame): Remove decl.
5265
fa5fb2bc
PE
5266 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5267
1e3890d1
PE
5268 * lread.c: Make symbols static if they're not exported.
5269 (read_objects, initial_obarray, oblookup_last_bucket_number):
5270 Now static.
5271 (make_symbol): Remove; unused.
5272 * lisp.h (initial_obarray, make_symbol): Remove decls.
5273
8a1414fa
PE
5274 * keyboard.c: Make symbols static if they're not exported.
5275 (single_kboard, recent_keys_index, total_keys, recent_keys):
5276 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5277 (this_single_command_key_start, echoing, last_auto_save):
5278 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5279 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5280 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5281 (Vlispy_mouse_stem, double_click_count):
5282 Now static.
5283 (force_auto_save_soon): Define only if SIGDANGER.
5284 (ignore_mouse_drag_p): Now static if
5285 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5286 (print_help): Remove; unused.
5287 (stop_character, last_timer_event): Mark as externally visible.
5288 * keyboard.h (ignore_mouse_drag_p): Declare only if
5289 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5290 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5291 * lisp.h (echoing): Remove decl.
5292 (force_auto_save_soon): Declare only if SIGDANGER.
5293 * xdisp.c (redisplay_window): Simplify code, to make it more
5294 obvious that ignore_mouse_drag_p is not accessed if !defined
5295 USE_GTK && !defined HAVE_NS.
5296
93ea6e8f
PE
5297 * intervals.c: Make symbols static if they're not exported.
5298 (merge_properties_sticky, merge_interval_right, delete_interval):
5299 Now static.
5300 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5301
77382fcc
PE
5302 * insdel.c: Make symbols static if they're not exported.
5303 However, leave prepare_to_modify_buffer alone. It's never
5304 called from outside this function, but that appears to be a bug.
5305 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5306 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5307 (adjust_after_replace_noundo): Remove; unused.
5308 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5309 (signal_before_change): Remove decls.
77382fcc 5310
9306c32e
PE
5311 * indent.c (val_compute_motion, val_vmotion): Now static.
5312
cd44d2eb
PE
5313 * image.c: Make symbols static if they're not exported.
5314 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5315 if USE_GTK.
5316 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5317 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5318
ad9a7a06
PE
5319 * fringe.c (standard_bitmaps): Now static.
5320 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5321
81626931
PE
5322 * frame.c: Make symbols static if they're not exported.
5323 (x_report_frame_params, make_terminal_frame): Now static.
5324 (get_frame_param): Now static, unless HAVE_NS.
5325 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5326 (x_get_resource_string): Remove; not used.
5327 * frame.h (make_terminal_frame, x_report_frame_params):
5328 (x_get_resource_string); Remove decls.
5329 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5330 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5331
239f9db9
PE
5332 * font.c, fontset.c: Make symbols static if they're not exported.
5333 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5334 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5335 * font.c (font_close_object): Now static.
5336 * font.h (font_close_object): Remove.
5337 * fontset.c (FONTSET_OBJLIST): Remove.
5338 (free_realized_fontset) #if-0 the body, which does nothing.
5339 (face_suitable_for_char_p): #if-0, as it's never called.
5340 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5341 * xfaces.c (face_at_string_position):
5342 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5343 since 0 is always ASCII.
5344
dfcf3579
PE
5345 * fns.c (weak_hash_tables): Now static.
5346
5045092b
PE
5347 * fileio.c: Make symbols static if they're not exported.
5348 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5349 (Vwrite_region_annotation_buffers): Now static.
5350
57a96f5c
PE
5351 * eval.c: Make symbols static if they're not exported.
5352 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5353 * lisp.h (backtrace_list): Remove decl.
5354
35f08c38
PE
5355 * emacs.c: Make symbols static if they're not exported.
5356 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5357 (fatal_error_code, fatal_error_signal_hook, standard_args):
5358 Now static.
5359 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5360 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5361 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5362 * lisp.h (fatal_error_signal_hook): Remove decl.
5363 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5364
f44bd759
PE
5365 * editfns.c: Move a (normally-unused) function to its only use.
5366 * editfns.c, lisp.h (get_operating_system_release): Remove.
5367 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5368 worth the hassle of breaking this out.
5369
b532497d
PE
5370 * xterm.c: Make symbols static if they're not exported.
5371 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5372 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5373 (x_destroy_window, x_delete_display):
5374 Now static.
5375 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5376 (x_mouse_leave): Remove; unused.
5377 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5378 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5379 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5380 Remove decls.
5381 (x_mouse_leave): Declare only if WINDOWSNT.
5382 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5383 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5384 USE_X_TOOLKIT.
5385
1675728f
PE
5386 * ftxfont.c: Make symbols static if they're not exported.
5387 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5388 HAVE_FREETYPE.
5389 * font.h (ftxfont_driver): Likewise.
5390
e4cebfca
PE
5391 * xfns.c: Make symbols static if they're not exported.
5392 (x_last_font_name, x_display_info_for_name):
5393 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5394 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5395 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5396 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5397 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5398 (last_show_tip_args): Now static.
5399 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5400 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5401 (x_screen_planes): Remove; unused.
5402 * dispextern.h (x_screen_planes): Remove decl.
5403
5bf46f05
PE
5404 * dispnew.c: Make symbols static if they're not exported.
5405 * dispextern.h (redraw_garbaged_frames, scrolling):
5406 (increment_row_positions): Remove.
5407 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5408 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5409 Now static.
5410 (redraw_garbaged_frames): Remove; unused.
5411
435f4c28
PE
5412 * xfaces.c: Make symbols static if they're not exported.
5413 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5414 Remove decls.
5415 * xterm.h (defined_color): Remove decls.
5416 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5417 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5418 (menu_face_changed_default, defined_color, free_realized_face):
5419 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5420 (ascii_face_of_lisp_face): Remove; unused.
5421
8524aef3
PE
5422 * xdisp.c: Make symbols static if they're not exported.
5423 * dispextern.h (scratch_glyph_row, window_box_edges):
5424 (glyph_to_pixel_coords, set_cursor_from_row):
5425 (get_next_display_element, set_iterator_to_next):
5426 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5427 (show_mouse_face): Remove decls
5428 * frame.h (message_buf_print): Likewise.
5429 * lisp.h (pop_message, set_message, check_point_in_composition):
5430 Likewise.
5431 * xterm.h (set_vertical_scroll_bar): Likewise.
5432 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5433 (message_buf_print, scratch_glyph_row, displayed_buffer):
5434 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5435 (get_next_display_element, show_mouse_face, window_box_edges):
5436 (frame_to_window_pixel_xy, check_point_in_composition):
5437 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5438 (glyph_to_pixel_coords): Remove; unused.
5439
16390cd2
PE
5440 * dired.c (file_name_completion): Now static.
5441
5442 * dbusbind.c (xd_in_read_queued_messages): Now static.
5443
a25f4dfa
PE
5444 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5445 * data.c (circular_list_error): Remove.
5446
14a9c8df
PE
5447 * commands.h (last_point_position, last_point_position_buffer):
5448 (last_point_position_window): Remove decls.
5449 * keyboard.c: Make these variables static.
5450
04f2d78b
CB
5451 * coding.h (coding, code_convert_region, encode_coding_gap):
5452 Remove decls.
74ab6df5
PE
5453 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5454 (iso_code_class, detect_coding, code_convert_region): Now static.
5455 (encode_coding_gap): Remove; unused.
5456
38dfbee1
PE
5457 * chartab.c (chartab_chars, chartab_bits): Now static.
5458
a2cb4e63
PE
5459 * charset.h (charset_iso_8859_1): Remove decl.
5460 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5461 Now static.
5462
127198fd
PE
5463 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5464 * ccl.c (Vccl_program_table): Now static.
5465 (check_ccl_update): Remove; unused.
5466
d85b608f
PE
5467 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5468 * category.h: ... from here.
5469 * category.c (check_category_table, set_category_set): Now static.
5470
31cd66f3
PE
5471 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5472 * lisp.h: Remove these decls.
5473
c358e587
PE
5474 * buffer.c (buffer_count): Remove unused var.
5475
e78aecca
PE
5476 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5477 so that it's not optimized away.
5478 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5479 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5480 exported only to the debugger.
5481
e192d7d3 5482 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5483 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5484
92470028
PE
5485 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5486 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5487 was inaccessible from Lisp.
5488 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5489 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5490
244ed907
PE
5491 alloc.c: Import and export fewer symbols, and remove unused items.
5492 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5493 is defined.
5494 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5495 it's not optimized away by whole-program optimization.
5496 (message_enable_multibyte, free_misc): Remove.
5497 (catchlist, handlerlist, mark_backtrace):
5498 Declare only if BYTE_MARK_STACK.
5499 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5500 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5501 (message_enable_multibyte): Remove decl.
5502 (free_misc, interval_free_list, float_block, float_block_index):
5503 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5504 (cons_free_list, last_marked_index):
5505 Now static.
5506 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5507 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5508 (mark_backtrace): Define only if BYTE_MARK_STACK.
5509 * xdisp.c (message_enable_multibyte): Now static.
5510
61c2b50e 5511 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5512 This makes it easier for human readers (and static analyzers)
5513 to see whether these variables are used from other modules.
5514 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5515 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5516 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5517 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5518 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5519 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5520 * xmenu.c, xselect.c:
5521 Declare Q* vars static if they are not used in other modules.
5522 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5523 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5524 Remove decls of unexported vars.
5525 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5526
95c82688
PE
5527 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5528
16a97296
PE
5529 Make Emacs functions such as Fatom 'static' by default.
5530 This makes it easier for human readers (and static analyzers)
5531 to see whether these functions can be called from other modules.
5532 DEFUN now defines a static function. To make the function external
5533 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5534 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5535 (Finit_image_library):
16a97296
PE
5536 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5537 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5538 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5539 Remove decls, since these functions are now static.
5540 (Funintern, Fget_internal_run_time): New decls, since these functions
5541 were already external.
95c82688 5542
16a97296
PE
5543 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5544 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5545 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5546 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5547 * keyboard.c, keymap.c, lread.c:
5548 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5549 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5550 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5551 Mark functions with DEFUE instead of DEFUN,
5552 if they are used in other modules.
5553 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5554 decls for now-static functions.
5555 * buffer.h (Fdelete_overlay): Remove decl.
5556 * callproc.c (Fgetenv_internal): Mark as internal.
5557 * composite.c (Fremove_list_of_text_properties): Remove decl.
5558 (Fcomposition_get_gstring): New forward static decl.
5559 * composite.h (Fcomposite_get_gstring): Remove decl.
5560 * dired.c (Ffile_attributes): New forward static decl.
5561 * doc.c (Fdocumntation_property): New forward static decl.
5562 * eval.c (Ffetch_bytecode): New forward static decl.
5563 (Funintern): Remove extern decl; now in .h file where it belongs.
5564 * fileio.c (Fmake_symbolic_link): New forward static decl.
5565 * image.c (Finit_image_library): New forward static decl.
5566 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5567 * intervals.h (Fprevious_property_change):
5568 (Fremove_list_of_text_properties): Remove decls.
5569 * keyboard.c (Fthis_command_keys): Remove decl.
5570 (Fcommand_execute): New forward static decl.
5571 * keymap.c (Flookup_key): New forward static decl.
5572 (Fcopy_keymap): Now static.
5573 * keymap.h (Flookup_key): Remove decl.
5574 * process.c (Fget_process): New forward static decl.
5575 (Fprocess_datagram_address): Mark as internal.
5576 * syntax.c (Fsyntax_table_p): New forward static decl.
5577 (skip_chars): Remove duplicate decl.
5578 * textprop.c (Fprevious_property_change): New forward static decl.
5579 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5580 Now internal.
5581 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5582 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5583
785bbd42
PE
5584 * editfns.c (Fformat): Remove unreachable code.
5585
8b913b57
AS
55862011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5587
5588 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5589 change. (Bug#8496)
5590
a6744a35
EZ
55912011-04-13 Eli Zaretskii <eliz@gnu.org>
5592
5593 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5594 when at ZV. (Bug#8487)
5595
e7974947
AS
55962011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5597
baad03f0
AS
5598 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5599 (Bug#8437)
5600 * keyboard.c (parse_tool_bar_item): Likewise.
5601 * sound.c (sound_cleanup, alsa_close): Likewise.
5602 * termcap.c (tgetent): Likewise.
5603 * xfns.c (x_default_font_parameter): Likewise.
5604 * xsettings.c (read_and_apply_settings): Likewise.
5605
e7974947
AS
5606 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5607 (overrun_check_free): Protoize.
5608
28272684
PE
56092011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5610
5611 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5612 since callers should never pass a negative size.
5613 Change the signature to match that of plain 'read' and 'write'; see
5614 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5615 * lisp.h: Update prototypes of emacs_write and emacs_read.
5616
11997c76
EZ
56172011-04-11 Eli Zaretskii <eliz@gnu.org>
5618
5619 * xdisp.c (redisplay_window): Don't try to determine the character
5620 position of the scroll margin if the window start point w->startp
e896f03c 5621 is outside the buffer's accessible region. (Bug#8468)
11997c76 5622
8a2cbd72
EZ
56232011-04-10 Eli Zaretskii <eliz@gnu.org>
5624
5625 Fix write-region and its subroutines for buffers > 2GB.
5626 * fileio.c (a_write, e_write): Modify declaration of arguments and
5627 local variables to support buffers larger than 2GB.
5628 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5629
5630 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5631 argument, local variables, and return value.
5632
5633 * lisp.h: Update prototypes of emacs_write and emacs_read.
5634
5635 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5636
4073e537 56372011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5638
1ebfdcb6
PE
5639 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5640
b2ded58d
PE
5641 Fix more problems found by GCC 4.6.0's static checks.
5642
7d66342c
PE
5643 * xdisp.c (vmessage): Use a better test for character truncation.
5644
bbf47d44
PE
5645 * charset.c (load_charset_map): <, not <=, for optimization,
5646 and to avoid potential problems with integer overflow.
9248994d 5647 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5648 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5649 * editfns.c (Fformat): Likewise.
1e69125e 5650 * syntax.c (skip_chars): Likewise.
3befa583 5651
e3019616
PE
5652 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5653 This also lets GCC 4.6.0 generate slightly better loop code.
5654
becfa255
PE
5655 * callint.c (Fcall_interactively): <, not <=, for optimization.
5656 (Fcall_interactively): Count the number of arguments produced,
5657 not the number of arguments given. This is simpler and lets GCC
5658 4.6.0 generate slightly better code.
5659
dae0cd48
PE
5660 * ftfont.c: Distingish more carefully between FcChar8 and char.
5661 The previous code passed unsigned char * to a functions like
5662 strlen and xstrcasecmp that expect char *, which does not
5663 conform to the C standard.
5664 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5665 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5666 char * when the C standard requires it.
5667
76032d70
PE
5668 * keyboard.c (read_char): Remove unused var.
5669
eb3f1cc8
PE
5670 * eval.c: Port to Windows vsnprintf (Bug#8435).
5671 Include <limits.h>.
5672 (SIZE_MAX): Define if the headers do not.
5673 (verror): Do not give up if vsnprintf returns a negative count.
5674 Instead, grow the buffer. This ports to Windows vsnprintf, which
5675 does not conform to C99. Problem reported by Eli Zaretskii.
5676 Also, simplify the allocation scheme, by avoiding the need for
5677 calling realloc, and removing the ALLOCATED variable.
5678
70476b54
PE
5679 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5680
12020a9e
PE
5681 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5682 But keep the doprint source code for now, as we might revamp it
5683 and use it again (Bug#8435).
ea6c7ae6
PE
5684 * lisp.h (doprnt): Remove.
5685 * Makefile.in (base_obj): Remove doprnt.o.
5686 * deps.mk (doprnt.o): Remove.
5687
5fdb398c
PE
5688 error: Print 32- and 64-bit integers portably (Bug#8435).
5689 Without this change, on typical 64-bit hosts error ("...%d...", N)
5690 was used to print both 32- and 64-bit integers N, which relied on
5691 undefined behavior.
5692 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5693 New macro.
5694 * lisp.h (error, verror): Mark as printf-like functions.
5695 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5696 Report overflow in size calculations when allocating printf buffer.
5697 Do not truncate output string at its first null byte.
5698 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5699 Truncate the output at a character boundary, since vsnprintf does not
5700 do that.
5701 * charset.c (check_iso_charset_parameter): Convert internal
5702 character to string before calling 'error', since %c now has the
5703 printf meaning.
5704 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5705 overflow when computing char to be passed to 'error'. Do not
5706 pass Lisp_Object to 'error'; pass the integer instead.
5707 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5708 formatted with plain %d.
5709
b189fa66
PE
5710 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5711
bff87ef0
PE
5712 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5713
7e2cac20
PE
5714 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5715
ce4d90b5
PE
5716 * xterm.c (x_catch_errors): Remove duplicate declaration.
5717
266c9547
PE
5718 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5719
79c49ad2
PE
5720 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5721
368f4090
JM
57222011-04-10 Jim Meyering <meyering@redhat.com>
5723
5724 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5725 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5726 return ssize_t not "int", and use size_t as the buffer length.
5727 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5728 * gnutls.h: Update declarations.
5729 * process.c (read_process_output): Use ssize_t, to match.
5730 (send_process): Likewise.
5731
a32d4040
CY
57322011-04-09 Chong Yidong <cyd@stupidchicken.com>
5733
5734 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5735
8546720e 57362011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5737
04f2d78b
CB
5738 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5739 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5740
8546720e
GM
5741 * xterm.c (handle_one_xevent):
5742 * xmenu.c (create_and_show_popup_menu):
5743 * xselect.c (x_decline_selection_request)
5744 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5745
0a2f5c1a 57462011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5747
5748 Fix some uses of `int' instead of EMACS_INT.
5749 * search.c (string_match_1, fast_string_match)
5750 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5751 (scan_buffer, find_next_newline_no_quit)
5752 (find_before_next_newline, search_command, Freplace_match)
5753 (Fmatch_data): Make some `int' variables be EMACS_INT.
5754
5755 * xdisp.c (display_count_lines): 3rd argument and return value now
5756 EMACS_INT. All callers changed.
5757 (pint2hrstr): Last argument is now EMACS_INT.
5758
5759 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5760 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5761 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5762 (decode_coding_utf_16, decode_coding_emacs_mule)
5763 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5764 (decode_coding_ccl, decode_coding_charset)
5765 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5766 (decode_coding_iso_2022, decode_coding_emacs_mule)
5767 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5768 <char_offset, last_offset>: Declare EMACS_INT.
5769 (encode_coding_utf_8, encode_coding_utf_16)
5770 (encode_coding_emacs_mule, encode_invocation_designation)
5771 (encode_designation_at_bol, encode_coding_iso_2022)
5772 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5773 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5774 Declare EMACS_INT.
5775 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5776 (encode_invocation_designation): Last argument P_NCHARS is now
5777 EMACS_INT.
5778 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5779 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5780
5781 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5782 All users changed.
5783
5784 * ccl.c (Fccl_execute_on_string): Declare some variables
5785 EMACS_INT.
5786
8546720e 57872011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5788
5789 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5790
4e19a977
CS
57912011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5792
5793 * process.c (Fformat_network_address): Doc fix.
5794
87302331
R
57952011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5796
5797 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5798
cbb59342
CY
57992011-04-08 Chong Yidong <cyd@stupidchicken.com>
5800
5801 * keyboard.c (read_char): Call Lisp function help-form-show,
5802 instead of using internal_with_output_to_temp_buffer.
5803 (Qhelp_form_show): New var.
e0d38eeb 5804 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5805
5806 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5807
5808 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5809
e67a13ab
CY
58102011-04-06 Chong Yidong <cyd@stupidchicken.com>
5811
04f2d78b
CB
5812 * process.c (Flist_processes): Remove to Lisp.
5813 (list_processes_1): Delete.
e67a13ab 5814
973f782d
EZ
58152011-04-06 Eli Zaretskii <eliz@gnu.org>
5816
7c106b1e
EZ
5817 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5818
973f782d
EZ
5819 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5820
41cf7d1a 58212011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5822
ca23cc88
PE
5823 Fix more problems found by GCC 4.6.0's static checks.
5824
f390e2d5
PE
5825 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5826
42eea0d0
PE
5827 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5828
b69769da 5829 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5830
f9541e84
PE
5831 * xdisp.c (vmessage): Mark as a printf-like function.
5832
13841b55
PE
5833 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5834
c136c10f
PE
5835 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5836
5e2d4a30
PE
5837 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5838 printf-like functions.
5839 (tiff_load): Add casts to remove these marks before passing them
5840 to system-supplied API.
5841
583f48b9
PE
5842 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5843
b25d760e
PE
5844 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5845 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5846 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5847 directly, rather than having caller test rule sign. This avoids
5848 some unnecessary tests.
5849 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5850 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5851 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5852
bc7b6697 5853 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5854 (xfont_open): Avoid unnecessary tests.
bc7b6697 5855
27ccc379
PE
5856 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5857
dcd5c89a
PE
5858 * composite.h, composite.c (composition_gstring_put_cache):
5859 Use EMACS_INT, not int, for length.
5860
b13a45c6
PE
5861 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5862 breaking out part of COMPOSITION_DECODE_RULE.
5863 (COMPOSITION_DECODE_RULE): Use it.
5864 * composite.c (get_composition_id): Remove unused local vars,
5865 by using the new macro.
5866
1e792e4d
PE
5867 * textprop.c (set_text_properties_1): Change while to do-while,
5868 since the condition is always true at first.
5869
dc6c6455 5870 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5871 (interval_deletion_adjustment): Return unsigned value.
5872 All uses changed.
dc6c6455 5873
aba7731a
PE
5874 * process.c (list_processes_1, create_pty, read_process_output):
5875 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5876 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5877 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5878 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5879 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5880
fdfc4bf3
PE
5881 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5882
fca8fe46 5883 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5884 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5885
06a0259a 5886 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5887 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5888 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5889
e7b9e80f
PE
5890 * print.c (print_error_message): Avoid int overflow.
5891
56201685
PE
5892 * font.c (font_list_entities): Redo for clarity,
5893 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5894
78834453 5895 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5896 (font_score): Avoid potential overflow in diff calculation.
78834453 5897
0bc0b309 5898 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5899 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5900
e610eaca
PE
5901 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5902
b895abce
PE
5903 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5904 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5905 can always succeed if overflow has undefined behavior.
5906
1f1d9321 5907 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5908 (wordify): Omit three unnecessary tests.
1f1d9321 5909
c59478bc
PE
5910 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5911 All callers changed. This avoids the need for an unused var.
5912
79b73827
PE
5913 * casefiddle.c (casify_region): Remove var that is set but not used.
5914
a4db5dfe
PE
5915 * dired.c (file_name_completion): Remove var that is set but not used.
5916
43aae36e
PE
5917 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5918
2a47c44d 5919 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5920 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5921
a37c69bf
PE
5922 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5923 Check for integer overflow on size calculations.
5924
328ab8e7
PE
5925 * buffer.c (Fprevious_overlay_change): Remove var that is set
5926 but not used.
5927
e5a2a5cb
PE
5928 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5929 Remove vars that are set but not used.
8d84a6eb 5930 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5931 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5932
a60e5f68
PE
5933 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5934
f661cb61 5935 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5936 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5937
f0397f5a
PE
5938 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5939 that are set but not used.
5940
8664db06 5941 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5942 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5943
6abdaa4a
PE
5944 * xselect.c (x_get_local_selection, x_handle_property_notify):
5945 Remove vars that are set but not used.
5946
0ce7538d 5947 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5948 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5949
9ae848fc
PE
5950 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5951 Remove var that is set but not used.
0b918413
PE
5952 (scroll_bar_windows_size): Now size_t, not int.
5953 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5954 Check for overflow.
9ae848fc 5955
a5a62657
PE
5956 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5957 (map_tty_color) [!defined MSDOS]: Likewise.
5958
5c5cdd39
PE
5959 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5960
66ebf983
PE
5961 * coding.c: Remove vars that are set but not used.
5962 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5963 All callers changed.
5964 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5965 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5966 (decode_coding_charset): Remove vars that are set but not used.
5967
1be4d761
PE
5968 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5969 that is set but not used.
5970
47553fa8
PE
5971 * print.c (print_object): Remove var that is set but not used.
5972
1f7196bf 5973 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5974 The gnulib version avoids calling malloc in the usual case,
5975 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5976 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5977 * filelock.c (current_lock_owner): Likewise.
5978 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5979 * sysdep.c: Include allocator.h, careadlinkat.h.
5980 (emacs_no_realloc_allocator): New static constant.
5981 (emacs_readlink): New function.
fdb61804
PE
5982 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5983 ../lib/careadlinkat.h.
d1fdcab7 5984
f84c17c7
SM
59852011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5986
5987 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5988 first non-nil return value).
5989
ef3862ad
JD
59902011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5991
5992 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5993 if not defined (Bug#8403).
5994
376a7006
JB
59952011-04-02 Juanma Barranquero <lekktu@gmail.com>
5996
5997 * xdisp.c (display_count_lines): Remove parameter `start',
5998 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5999 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6000 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6001 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6002 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6003 and thereabouts. All callers changed.
6004 (get_per_char_metric): Remove parameter `f', unused since
6005 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6006
6ca3801d
JM
60072011-04-02 Jim Meyering <meyering@redhat.com>
6008
6009 do not dereference NULL upon failed strdup
6010 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6011 (ns_get_family): Likewise.
6012
d8e2b5ba
JB
60132011-04-02 Juanma Barranquero <lekktu@gmail.com>
6014
6015 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6016
8c74fcbd
JD
60172011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6018
6019 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6020 later (Bug#8403).
6021
7200d79c
SM
60222011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6023
03408648 6024 Add lexical binding.
7200d79c 6025
03408648
SM
6026 * window.c (Ftemp_output_buffer_show): New fun.
6027 (Fsave_window_excursion):
6028 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6029
6030 * lread.c (lisp_file_lexically_bound_p): New function.
6031 (Fload): Bind Qlexical_binding.
6032 (readevalloop): Remove `evalfun' arg.
6033 Bind Qinternal_interpreter_environment.
6034 (Feval_buffer): Bind Qlexical_binding.
6035 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6036 Mark as dynamic.
6037 (syms_of_lread): Declare `lexical-binding'.
6038
6039 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6040
6041 * keyboard.c (eval_dyn): New fun.
6042 (menu_item_eval_property): Use it.
ca105506
SM
6043
6044 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6045
03408648
SM
6046 * fns.c (concat, mapcar1): Accept byte-code-functions.
6047
6048 * eval.c (Fsetq): Handle lexical vars.
6049 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6050 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6051 (FletX, Flet): Obey lexical binding.
6052 (Fcommandp): Handle closures.
6053 (Feval): New `lexical' arg.
6054 (eval_sub): New function extracted from Feval. Use it almost
6055 everywhere where Feval was used. Look up vars in lexical env.
6056 Handle closures.
6057 (Ffunctionp): Move from subr.el.
6058 (Ffuncall): Handle closures.
6059 (apply_lambda): Remove `eval_flags'.
6060 (funcall_lambda): Handle closures and new byte-code-functions.
6061 (Fspecial_variable_p): New function.
6062 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6063 but without exporting it to Lisp.
23aba0ea 6064
23aba0ea 6065 * doc.c (Fdocumentation, store_function_docstring):
03408648 6066 * data.c (Finteractive_form): Handle closures.
23aba0ea 6067
03408648
SM
6068 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6069 interactive spec.
ba83908c 6070
04f2d78b
CB
6071 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6072 New byte-codes.
03408648
SM
6073 (exec_byte_code): New function extracted from Fbyte_code to handle new
6074 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6075
03408648 6076 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6077
03408648 6078 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6079
e2abce01
JB
60802011-03-31 Juanma Barranquero <lekktu@gmail.com>
6081
6082 * xdisp.c (redisplay_internal): Fix prototype.
6083
63696a73 60842011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6085
63696a73 6086 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6087 (try_scrolling): Use it when setting scroll_limit.
6088 Limit scrolling to 100 screen lines.
63696a73
EZ
6089 (redisplay_window): Even when falling back on "recentering",
6090 position point in the window according to scroll-conservatively,
6091 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6092
6093 (try_scrolling): When point is above the window, allow searching
6094 as far as scroll_max, or one screenful, to compute vertical
6095 distance from PT to the scroll margin position. This prevents
6096 try_scrolling from unnecessarily failing when
6097 scroll-conservatively is set to a value slightly larger than the
6098 window height. Clean up the case of PT below the margin at bottom
6099 of window: scroll_max can no longer be INT_MAX. When aggressive
6100 scrolling is in use, don't let point enter the opposite scroll
6101 margin as result of the scroll.
6102 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6103 threshold of 100 lines for never-recentering scrolling.
6104
e4cc2dfc
JB
61052011-03-31 Juanma Barranquero <lekktu@gmail.com>
6106
6107 * dispextern.h (move_it_by_lines):
6108 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6109 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6110 (message_log_check_duplicate): Remove parameters `prev_bol' and
6111 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6112 (redisplay_internal): Remove parameter `preserve_echo_area',
6113 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6114
6115 * indent.c (Fvertical_motion):
6116 * window.c (window_scroll_pixel_based, Frecenter):
6117 Don't pass `need_y_p' to `move_it_by_lines'.
6118
1c470562
SM
61192011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6120
44f230aa
SM
6121 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6122 steal a few bits to be more compact.
6123 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6124 Remove unneeded casts.
6125
1c470562
SM
6126 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6127
888adce9
ZK
61282011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6129
6130 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6131 binding" message (bug#7967).
6132
f838ed7b
PE
61332011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6134
77861b95
PE
6135 Fix more problems found by GCC 4.6.0's static checks.
6136
de6dbc14
PE
6137 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6138 Remove unused local var.
6139
f838ed7b
PE
6140 * editfns.c (Fmessage_box): Remove unused local var.
6141
792c7b2b
PE
6142 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6143 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6144 Omit unused local vars.
c499e557 6145 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6146 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6147 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6148 Omit unused local var.
6149
ba0165e1
PE
6150 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6151 Don't assume string length fits in int.
32ad8845 6152 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6153 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6154
3c59b4c9
PE
6155 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6156 instead of alloca (Bug#8344).
6157
a3eed478 6158 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6159 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6160
eb4d412d
PE
6161 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6162
1658b401
PE
6163 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6164 concerns.
6165
6166 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6167
6168 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6169
9a2c6e05
PE
6170 * keyboard.c (syms_of_keyboard): Use the same style as later
6171 in this function when indexing through an array. This also
6172 works around GCC bug 48267.
6173
03d0a109
PE
6174 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6175
44f730c8
PE
6176 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6177
fe75f926
PE
6178 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6179 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6180
ffa8c828
PE
6181 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6182 This avoids undefined behavior on integer overflow, and is a bit
6183 more convenient anyway since it is compared to a size_t variable.
6184
c5101a77
PE
6185 Variadic C functions now count arguments with size_t, not int.
6186 This avoids an unnecessary limitation on 64-bit machines, which
6187 caused (substring ...) to crash on large vectors (Bug#8344).
6188 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6189 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6190 All variadic functions and their callers changed accordingly.
c5101a77
PE
6191 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6192 * data.c (arith_driver, float_arith_driver): Likewise.
6193 * editfns.c (general_insert_function): Likewise.
6194 * eval.c (struct backtrace.nargs, interactive_p)
6195 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6196 (funcall_lambda, mark_backtrace): Likewise.
6197 * fns.c (concat): Likewise.
6198 * frame.c (x_set_frame_parameters): Likewise.
6199 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6200 0 if not found, not -1. All callers changed.
6201
dd3f25f7
PE
6202 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6203 (stack_copy_size): Now size_t, not int.
6204 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6205
461c2ab9
JB
62062011-03-28 Juanma Barranquero <lekktu@gmail.com>
6207
6208 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6209 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6210 All callers changed.
6211
6212 * lisp.h (multibyte_char_to_unibyte):
6213 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6214 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6215 * character.h (CHAR_TO_BYTE8):
6216 * cmds.c (internal_self_insert):
6217 * editfns.c (general_insert_function):
6218 * keymap.c (push_key_description):
6219 * search.c (Freplace_match):
6220 * xdisp.c (message_dolog, set_message_1): All callers changed.
6221
f6d62986
SM
62222011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6223
6224 * keyboard.c (safe_run_hook_funcall): New function.
6225 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6226 don't set the hook to nil, but remove the offending function instead.
6227 (Qcommand_hook_internal): Remove, unused.
6228 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6229 Vcommand_hook_internal.
6230
6231 * eval.c (enum run_hooks_condition): Remove.
6232 (funcall_nil, funcall_not): New functions.
6233 (run_hook_with_args): Call each function through a `funcall' argument.
6234 Remove `cond' argument, now redundant.
6235 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6236 (Frun_hook_with_args_until_failure): Adjust accordingly.
6237 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6238
1db5b1ad
JB
62392011-03-28 Juanma Barranquero <lekktu@gmail.com>
6240
6241 * dispextern.h (string_buffer_position): Remove declaration.
6242
6243 * print.c (strout): Remove parameter `multibyte', unused since
6244 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6245
6246 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6247 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6248 All callers changed.
6249
6250 * w32.c (_wsa_errlist): Use braces for struct initializers.
6251
6252 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6253 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6254 All callers changed.
6255 (string_buffer_position): Likewise. Also, make static (it's never
6256 used outside xdisp.c).
6257 (cursor_row_p): Remove parameter `w', unused since
6258 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6259 (decode_mode_spec): Remove parameter `precision', introduced during
6260 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6261 All callers changed.
6262
5ffb62aa
JD
62632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6264
6265 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6266
461c2ab9 62672011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6268
6269 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6270 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6271 (ns_update_auto_hide_menu_bar): New functions.
6272 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6273 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6274 ns_constrain_all_frames.
6275 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6276 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6277
5c380ffb
JD
62782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6279
6280 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6281
9af30bdf
GM
62822011-03-27 Glenn Morris <rgm@gnu.org>
6283
6284 * syssignal.h: Replace RETSIGTYPE with void.
6285 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6286 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6287 Replace SIGTYPE with void everywhere.
6288 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6289 * s/template.h (SIGTYPE): Remove commented out definition.
6290
e2abce01
JB
62912011-03-26 Eli Zaretskii <eliz@gnu.org>
6292
6293 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6294 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6295
f868cd8a
JB
62962011-03-26 Juanma Barranquero <lekktu@gmail.com>
6297
59eb0929
JB
6298 * w32.c (read_unc_volume): Use parameter `henum', instead of
6299 global variable `wget_enum_handle'.
6300
6301 * keymap.c (describe_vector): Remove parameters `indices' and
6302 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6303 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6304
f868cd8a
JB
6305 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6306
6307 * keyboard.c (timer_check): Remove parameter `do_it_now',
6308 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6309 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6310 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6311
6312 * keyboard.c (read_char):
6313 * w32menu.c (w32_menu_display_help):
6314 * xmenu.c (show_help_event, menu_help_callback):
6315 Adjust calls to `show_help_echo'.
6316
6317 * gtkutil.c (xg_maybe_add_timer):
6318 * keyboard.c (readable_events):
6319 * process.c (wait_reading_process_output):
6320 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6321
6322 * insdel.c (adjust_markers_gap_motion):
6323 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6324 (gap_left, gap_right): Don't call it.
6325
2ecf6fdb
CY
63262011-03-25 Chong Yidong <cyd@stupidchicken.com>
6327
6328 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6329 incurred during fontification.
6330
6b1f9ba4
JB
63312011-03-25 Juanma Barranquero <lekktu@gmail.com>
6332
6333 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6334 (DEFVAR_PER_BUFFER): Don't pass it.
6335
6336 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6337 (scrolling_window): Don't pass it.
6338
0f4a96b5
JB
63392011-03-25 Juanma Barranquero <lekktu@gmail.com>
6340
6341 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6342
6343 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6344 and `suffix'.
6345 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6346 of variables specific to SELinux and computation of `encoded_absname'.
6347
6348 * image.c (XPutPixel): Remove unused variable `height'.
6349
6350 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6351
6352 * unexw32.c (get_section_info): Remove unused variable `section'.
6353
6354 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6355 (system_process_attributes): Remove unused variable `sess'.
6356 (sys_read): Remove unused variable `err'.
6357
6358 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6359 (w32_wnd_proc): Remove unused variable `isdead'.
6360 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6361 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6362 (x_create_tip_frame): Remove unused variable `tem'.
6363
6364 * w32inevt.c (w32_console_read_socket):
6365 Remove unused variable `no_events'.
6366
6367 * w32term.c (x_draw_composite_glyph_string_foreground):
6368 Remove unused variable `width'.
6369
1149507c
JB
63702011-03-24 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * w32term.c (x_set_glyph_string_clipping):
6373 Don't pass uninitialized region to CombineRgn.
6374
9c88f339
JB
63752011-03-23 Juanma Barranquero <lekktu@gmail.com>
6376
6377 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6378 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6379 (Fx_close_connection): Remove unused variable `i'.
6380
6381 * w32font.c (w32font_draw): Return number of glyphs.
6382 (w32font_open_internal): Remove unused variable `i'.
6383 (w32font_driver): Add missing initializer.
6384
6385 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6386 (fill_in_menu): Remove unused variable `items_added'.
6387
6388 * w32term.c (last_mouse_press_frame): Remove static global variable.
6389 (w32_clip_to_row): Remove unused variable `f'.
6390 (x_delete_terminal): Remove unused variable `i'.
6391
6392 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6393 (NOTHING): Remove unused static global variable.
6394 (uniscribe_check_otf): Remove unused variable `table'.
6395 (uniscribe_font_driver): Add missing initializers.
6396
dee091a3
JD
63972011-03-23 Julien Danjou <julien@danjou.info>
6398
6399 * term.c (Fsuspend_tty, Fresume_tty):
6400 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6401 * window.c (temp_output_buffer_show):
6402 * insdel.c (signal_before_change):
6403 * frame.c (Fhandle_switch_frame):
6404 * fileio.c (Fdo_auto_save):
6405 * emacs.c (Fkill_emacs):
6406 * editfns.c (save_excursion_restore):
6407 * cmds.c (internal_self_insert):
6408 * callint.c (Fcall_interactively):
6409 * buffer.c (Fkill_all_local_variables):
6410 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6411 Use Frun_hooks.
0f4a96b5 6412 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6413 unconditionnaly since it does the check itself.
6414
2c520ab5 64152011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6416
c9c49752
PE
6417 Fix more problems found by GCC 4.5.2's static checks.
6418
8abc3f12
PE
6419 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6420 the first time through the loop, since we know p0 < p1 then.
6421 This also avoids a gcc -Wstrict-overflow warning.
6422
a2d26660
PE
6423 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6424 leading to a memory leak, possible in functions like
6425 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6426 of objects (Bug#8318).
a2d26660 6427
916c72e9
PE
6428 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6429 that could (at least in theory) be that large.
6430
19ab8a18
PE
6431 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6432 This is less likely to overflow, and avoids undefined behavior if
6433 overflow does occur. All callers changed. Use strtoul to scan
6434 for the unsigned long integer.
b7cbbd6f
PE
6435 (pint2hrstr): Simplify and tune code slightly.
6436 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6437
f0641eff
PE
6438 * scroll.c (do_scrolling): Work around GCC bug 48228.
6439 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6440
7f650bb9
PE
6441 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6442 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6443 (validate_x_resource_name): Simplify count usage.
6444 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6445
37dd57d1
PE
6446 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6447 fail (Bug#8306).
81e56e61 6448
699979fc 6449 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6450
401bf9b4
PE
6451 * process.c (Fmake_network_process): Use socklen_t, not int,
6452 where POSIX says socklen_t is required in portable programs.
6453 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6454 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6455 (Fmake_network_process, server_accept_connection):
6456 (wait_reading_process_output, read_process_output):
6457 Likewise.
6458
b93aacde
PE
6459 * process.c: Rename or move locals to avoid shadowing.
6460 (list_processes_1, Fmake_network_process):
6461 (read_process_output_error_handler, exec_sentinel_error_handler):
6462 Rename or move locals.
4dc343ee 6463 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6464 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6465 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6466 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6467 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6468
af8a867c 6469 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6470 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6471 Include tparam.h instead, since it declares them.
af8a867c
PE
6472 * cm.h (PC): Remove extern decl; tparam.h now does this.
6473 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6474 * terminfo.c: Include tparam.h, to check interfaces.
6475 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6476 (tparam): Adjust signature to match interface in tparam.h;
6477 this removes some undefined behavior. Check that outstring and len
6478 are zero, which they always are with Emacs.
6479 * tparam.h (PC, BC, UP): New extern decls.
6480
0248044d 6481 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6482 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6483
8ff096c1 6484 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6485 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6486 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6487 (ftfont_list): Remove unused local.
49eaafba
PE
6488 (get_adstyle_property, ftfont_pattern_entity):
6489 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6490 Rename locals to avoid shadowing.
8ff096c1 6491
e2be39f6
PE
6492 * xfont.c (xfont_list_family): Mark var as initialized.
6493
c9735e30
PE
6494 * xml.c (make_dom): Now static.
6495
8f5201ae
PE
6496 * composite.c (composition_compute_stop_pos): Rename local to
6497 avoid shadowing.
b246f932
PE
6498 (composition_reseat_it): Remove unused locals.
6499 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6500 (composition_update_it): Mark var as initialized.
11b61122
PE
6501 (find_automatic_composition): Mark vars as initialized,
6502 with a FIXME (Bug#8290).
8f5201ae 6503
760fbc2c
PE
6504 character.h: Rename locals to avoid shadowing.
6505 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6506 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6507 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6508 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6509 to avoid shadowing.
6510
ff08eb85
PE
6511 * textprop.c (property_change_between_p): Remove; unused.
6512
fc7bf025
PE
6513 * intervals.c (interval_start_pos): Now static.
6514
235d7abc
PE
6515 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6516
44f230aa
SM
6517 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6518 Rename locals to avoid shadowing.
3e7d6594 6519
50060332
PE
6520 * sound.c (wav_play, au_play, Fplay_sound_internal):
6521 Fix pointer signedness.
d01f234b 6522 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6523 (wav_play): Initialize a variable to 0, to prevent undefined
6524 behavior (Bug#8278).
50060332 6525
c4fc4e30
PE
6526 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6527
918436ed
PE
6528 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6529
c939f91b
PE
6530 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6531 clobbering (Bug#8298).
b9c7f648
PE
6532 * sysdep.c (sys_subshell): Likewise.
6533 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6534
6bd8c144
PE
6535 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6536 This should get cleaned up, so that child_setup has the
6537 same signature on all platforms.
6538
7710357c 6539 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6540 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6541
c59da222
CY
65422011-03-22 Chong Yidong <cyd@stupidchicken.com>
6543
6544 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6545 not to be necessary, and produces flickering.
6546
66b87493
GM
65472011-03-20 Glenn Morris <rgm@gnu.org>
6548
6549 * config.in: Remove file.
6550
45b6f6d5
JB
65512011-03-20 Juanma Barranquero <lekktu@gmail.com>
6552
6553 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6554 are now in src/globals.h.
6555 (syms_of_minibuf): Remove spurious & from previous change.
6556
3ec03f7e
LL
65572011-03-20 Leo <sdl.web@gmail.com>
6558
6559 * minibuf.c (completing-read-function): New variable.
6560 (completing-read-default): Rename from completing-read.
6561 (completing-read): Call completing-read-function.
6562
b14e3e21
CY
65632011-03-19 Juanma Barranquero <lekktu@gmail.com>
6564
6565 * xfaces.c (Fx_load_color_file):
6566 Read color file from absolute filename (bug#8250).
6567
f2b726e6
JB
65682011-03-19 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * makefile.w32-in: Update dependencies.
6571
09f6ff02
EZ
65722011-03-17 Eli Zaretskii <eliz@gnu.org>
6573
6574 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6575
29a6015a
PE
65762011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6577
a3a6c54e
PE
6578 Fix more problems found by GCC 4.5.2's static checks.
6579
b766f867
PE
6580 * process.c (make_serial_process_unwind, send_process_trap):
6581 (sigchld_handler): Now static.
6582
be02381c
PE
6583 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6584 That way, the code declares only the vars that it needs.
6585 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6586 * s/cygwin.h (PTY_ITERATION): Likewise.
6587 * s/darwin.h (PTY_ITERATION): Likewise.
6588 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6589
57048744
PE
6590 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6591 * process.c (allocate_pty): Don't declare stb unless it's needed.
6592
7914961c 6593 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6594 (CONSTANTLIM): Remove; unused.
6595 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6596 Define only if needed.
7914961c 6597
b3967b18
PE
6598 * unexelf.c (unexec): Name an expression,
6599 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6600 Use a different way to cause a compilation error if anyone uses
6601 n rather than nn, a way that does not involve shadowing.
73366a00 6602 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6603
29a6015a
PE
6604 * deps.mk (unexalpha.o): Remove; unused.
6605
43cfc33e 6606 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6607 * unexec.h: New file.
ce701a33
PE
6608 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6609 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6610 Depend on unexec.h.
6611 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6612 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6613 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6614 Change as necessary to match prototype in unexec.h.
ce701a33 6615
01f44d5a
PE
6616 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6617 shadowing.
4f63c6bb 6618 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6619
a6670b0b
PE
6620 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6621 Rename locals to avoid shadowing.
6622
cef2010d 6623 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6624 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6625
d4d7173a
PE
6626 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6627
f08b802a
PE
6628 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6629 warning when compiling print.c.
6630
3ddb0639
PE
6631 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6632 instead of using an uninitialized var.
5ad03b97 6633 (font_sort_entities): Mark var as initialized.
3ddb0639 6634
170a2692
PE
6635 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6636
e663c700
PE
6637 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6638 pointers to constants.
89bc529a 6639 (font_parse_fcname): Remove unused vars.
7b81e2d0 6640 (font_delete_unmatched): Now static.
ea838e10 6641 (font_get_spec): Remove; unused.
13a547c6
PE
6642 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6643 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6644 Rename or move locals to avoid shadowing.
e663c700 6645
2a80c887 6646 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6647 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6648
1384fa33 6649 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6650 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6651
8b2c52e9
PE
6652 * alloc.c (mark_backtrace): Move decl from here ...
6653 * lisp.h: ... to here, so that it can be checked.
6654
475545b5 6655 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6656 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6657 (lisp_indirect_variable): Name an expression,
6658 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6659 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6660
b1349114 6661 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6662 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6663 Use const pointer when appropriate.
b1349114 6664
a2928364
PE
6665 * lisp.h (get_system_name, get_operating_system_release):
6666 Move decls here, to check interfaces.
6667 * process.c (get_operating_system_release): Move decl to lisp.h.
6668 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6669 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6670 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6671 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6672 (Fformat_time_string, Fencode_time, Finsert_char):
6673 (Ftranslate_region_internal, Fformat):
6674 Rename or remove local vars to avoid shadowing.
9710023e 6675 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6676
a415e694
PE
6677 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6678 avoid shadowing.
6679
8ef4622d
PE
6680 * lisp.h (eassert): Check that the argument compiles, even if
6681 ENABLE_CHECKING is not defined.
6682
946f9a5b
PE
6683 * data.c (Findirect_variable): Name an expression, to avoid
6684 gcc -Wbad-function-cast warning.
112396d6 6685 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6686 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6687 (Fmake_variable_buffer_local, Fmake_local_variable):
6688 Mark variables as initialized.
52746918 6689 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6690
e5aab7e7 6691 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6692 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6693 Rename locals to avoid shadowing.
dff45157
PE
6694 (mark_stack): Move local variables into the #ifdef region where
6695 they're used.
7bc26fdb
PE
6696 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6697 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6698 needed otherwise.
6699 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6700 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6701 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6702
e5aab7e7
PE
6703 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6704 avoids undefined behavior in theory.
6705
4da60324
PE
6706 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6707
88043301
PE
6708 Use functions, not macros, for up- and down-casing (Bug#8254).
6709 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6710 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6711 to use the following functions instead of these macros.
6712 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6713 EMACS_INT, since callers assume the returned value fits in int.
6714 (upcase1): Likewise, for UPCASE_TABLE.
6715 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6716 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6717 the race-condition problem in the old DOWNCASE.
88043301 6718
19ed5445
PE
6719 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6720 Rename locals to avoid shadowing.
6721 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6722 (regex_compile, re_search_2, re_match_2_internal):
6723 Remove unused local vars.
952db0d7
PE
6724 (FREE_VAR): Rewrite so as not to use empty "else",
6725 which gcc can warn about.
da053e48 6726 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6727 (RETALLOC_IF): Define only if needed.
6728 (WORDCHAR_P): Likewise. This one is never needed, but is used
6729 only in a comment talking about a compiler bug, so put inside
6730 the #if 0 of that comment.
6731 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6732 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6733 Remove; unused.
19ed5445 6734
1f3561e4 6735 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6736 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6737 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6738
ded6f8f7
PE
6739 * search.c (simple_search): Remove unused var.
6740
dbd37a95
PE
6741 * dired.c (compile_pattern): Move decl from here ...
6742 * lisp.h: ... to here, so that it can be checked.
6743 (struct re_registers): New forward decl.
6744
7e47afad
PE
6745 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6746
85f24f61
PE
6747 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6748 All uses changed.
6749 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6750 Rename locals to avoid shadowing.
5671df8f 6751 (Fvertical_motion): Mark locals as initialized.
85f24f61 6752
181aa2be 6753 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6754 (casify_region): Mark local as initialized.
181aa2be 6755
930d429c
PE
6756 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6757
7082eac6
PE
6758 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6759 New macros, so that the caller can use some names other than
6760 gcpro1, gcpro2, etc.
6761 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6762 of the new macros.
6763 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6764 argument, for consistency with GCPRO2_VAR, etc: it is now the
6765 prefix of the variable, not the variable itself. All uses
6766 changed.
38b2c076
PE
6767 * dired.c (directory_files_internal, file_name_completion):
6768 Rename locals to avoid shadowing.
6769
15206ed9
PE
6770 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6771 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6772 dired.c's scmp function, had undefined behavior.
6773 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6774 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6775 * buffer.h: ... to here, because these macros use current_buffer,
6776 and the new implementation with inline functions needs to have
6777 current_buffer in scope now, rather than later when the macros
6778 are used.
6779 (downcase, upcase1): New static inline functions.
6780 (DOWNCASE, UPCASE1): Reimplement using these functions.
6781 This avoids undefined behavior in expressions like
6782 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6783 from race conditions in accessing the global variables
6784 case_temp1 and case_temp2.
6785 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6786 * lisp.h (case_temp1, case_temp2): Remove their decls.
6787 * character.h (ASCII_CHAR_P): Move from here ...
6788 * lisp.h: ... to here, so that the inline functions mentioned
6789 above can use them.
6790
4a6bea26
PE
6791 * dired.c (directory_files_internal_unwind): Now static.
6792
f14b7e14
PE
6793 * fileio.c (file_name_as_directory, directory_file_name):
6794 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6795 Now static.
2893f146
PE
6796 (file_name_as_directory): Use const pointers when appropriate.
6797 (Fexpand_file_name): Likewise. In particular, newdir might
6798 point at constant storage, so make it a const pointer.
fd4ead52 6799 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6800 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6801 signedness issues.
f839df0c
PE
6802 (Fset_file_times, Finsert_file_contents, auto_save_error):
6803 Rename locals to avoid shadowing.
f14b7e14 6804
5716756e 6805 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6806 (Ftry_completion, Fall_completions): Rename or remove locals
6807 to avoid shadowing.
5716756e 6808
b4c3046a
PE
6809 * marker.c (bytepos_to_charpos): Remove; unused.
6810
b45db522
PE
6811 * lisp.h (verify_bytepos, count_markers): New decls,
6812 so that gcc does not warn that these functions aren't declared.
6813
85876d07
PE
6814 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6815 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6816 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6817 (copy_text): Remove unused local var.
85876d07 6818
03d78a21 6819 * filelock.c (within_one_second): Now static.
b3dd38ab 6820 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6821
5df8f01b
PE
6822 * buffer.c (fix_overlays_before): Mark locals as initialized.
6823 (fix_start_end_in_overlays): Likewise. This function should be
6824 simplified by using pointers-to-pointers, but that's a different
6825 matter.
b1d876f1 6826 (switch_to_buffer_1): Now static.
8f54f30a
PE
6827 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6828 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6829
a70072c9 6830 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6831 Fix pointer signedness issue.
edced198
PE
6832 (sys_subshell): Mark local as volatile if checking for lint,
6833 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6834 (MAXPATHLEN): Define only if needed.
a70072c9 6835
a0977c44
PE
6836 * process.c (serial_open, serial_configure): Move decls from here ...
6837 * systty.h: ... to here, so that they can be checked.
6838
a884fdcc
PE
6839 * fns.c (get_random, seed_random): Move extern decls from here ...
6840 * lisp.h: ... to here, so that they can be checked.
6841
604efe86 6842 * sysdep.c (reset_io): Now static.
b8950c94 6843 (wait_for_termination_signal): Remove; unused.
604efe86 6844
38fc62d9
PE
6845 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6846 (copy_keymap_item, append_key, push_text_char_description):
6847 Now static.
1004a21a 6848 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6849 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6850 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6851 (describe_map_tree):
6852 Rename locals to avoid shadowing.
38fc62d9 6853
2f2650da
PE
6854 * keyboard.c: Declare functions static if they are not used elsewhere.
6855 (echo_char, echo_dash, cmd_error, top_level_2):
6856 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6857 (read_char, kbd_buffer_get_event, make_lispy_position):
6858 (make_lispy_event, make_lispy_movement, apply_modifiers):
6859 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6860 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6861 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6862 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6863 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6864
a053e86c 6865 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6866 (mark_kboards): Move decl here ...
6867 * alloc.c (mark_kboards): ... from here.
a053e86c 6868
4752793e
PE
6869 * lisp.h (force_auto_save_soon): New decl.
6870
74f10ca7 6871 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6872 (DEFINE_DUMMY_FUNCTION): New macro.
6873 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6874 Use it.
c03cd23f
PE
6875 (main): Add casts to avoid warnings
6876 if GCC considers string literals to be constants.
74f10ca7 6877
022e70d4
PE
6878 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6879
59d6fe83
PE
6880 * dbusbind.c: Pointer signedness fixes.
6881 (xd_signature, xd_append_arg, xd_initialize):
6882 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6883 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6884 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6885 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6886
78320123
PE
6887 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6888 if GCC considers string literals to be constants.
49cebcca 6889 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6890
35ac2a97
SM
68912011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6892
fb103ca9
SM
6893 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6894 (print_preprocess, print_object): New macro to fix last change.
6895
35ac2a97
SM
6896 * print.c (print_preprocess): Don't forget font objects.
6897
62973b41
JB
68982011-03-16 Juanma Barranquero <lekktu@gmail.com>
6899
6900 * emacs.c (USAGE3): Doc fixes.
6901
0e48bb22
AS
69022011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6903
6904 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6905 structure.
6906
7684e57b
JB
69072011-03-14 Juanma Barranquero <lekktu@gmail.com>
6908
6909 * lisp.h (VWindow_system, Qfile_name_history):
6910 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6911 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6912 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6913
6914 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6915 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6916
6917 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6918 * w32console.c (detect_input_pending, read_input_pending)
6919 (encode_terminal_code):
6920 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6921 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6922 (w32_system_caret_y, Qfile_name_history):
6923 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6924 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6925 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6926 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6927 * w32proc.c (Qlocal, report_file_error):
6928 * w32term.c (Vwindow_system, updating_frame):
6929 * w32uniscribe.c (initialized, uniscribe_font_driver):
6930 Remove unneeded extern declarations.
6931
2aa46d6c
CY
69322011-03-14 Chong Yidong <cyd@stupidchicken.com>
6933
c96bbc66 6934 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6935
cffc6f3b
CY
69362011-03-13 Chong Yidong <cyd@stupidchicken.com>
6937
6938 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6939 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6940 These macros can no longer be used for assignment.
6941
44f230aa
SM
6942 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6943 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6944 (record_buffer_markers, fetch_buffer_markers): New functions for
6945 recording and fetching special buffer markers.
6946 (set_buffer_internal_1, set_buffer_temp): Use them.
6947
6948 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6949
6950 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6951
6952 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6953 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6954
6955 * xdisp.c (hscroll_window_tree):
6956 (reconsider_clip_changes): Use PT instead of BUF_PT.
6957
d251f04b
EZ
69582011-03-13 Eli Zaretskii <eliz@gnu.org>
6959
6960 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6961 $(EMACS_ROOT)/lib/intprops.h.
6962
f0c77cd1
PE
69632011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6964
3eca4629
PE
6965 Fix more problems found by GCC 4.5.2's static checks.
6966
7c86ee98
PE
6967 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6968 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6969 (xg_free_frame_widgets): Make it clear that a local variable is
6970 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6971 (gdk_window_get_screen): Make it clear that this macro is needed
6972 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6973 (int_gtk_range_get_value): New function, which avoids a diagnostic
6974 from gcc -Wbad-function-cast.
6975 (xg_set_toolkit_scroll_bar_thumb): Use it.
6976 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6977 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6978 (get_utf8_string, xg_get_file_with_chooser):
6979 Rename locals to avoid shadowing.
6980 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6981
41729b81
PE
6982 * xgselect.c (xg_select): Remove unused var.
6983
f0c77cd1
PE
6984 * image.c (four_corners_best): Mark locals as initialized.
6985 (gif_load): Initialize transparent_p to zero (Bug#8238).
6986 Mark another local as initialized.
ec6cf4c6 6987 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6988
ce0ad53d 6989 * image.c (clear_image_cache): Now static.
d5d5a617 6990 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6991 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6992 (x_edge_detection): Remove unnecessary cast that
6993 gcc -Wbad-function-cast diagnoses.
2037898d 6994 (gif_load): Fix pointer signedness.
6ae141d6
PE
6995 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6996 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6997
33383987 69982011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6999
d32df629
PE
7000 Improve quality of tests for time stamp overflow.
7001 For example, without this patch (encode-time 0 0 0 1 1
7002 1152921504606846976) returns the obviously-bogus value (-948597
7003 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7004 reports time overflow. See
7005 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7006 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7007 * editfns.c: Include limits.h and intprops.h.
7008 (TIME_T_MIN, TIME_T_MAX): New macros.
7009 (time_overflow): Move earlier, to before first use.
7010 (hi_time, lo_time): New functions, for an accurate test for
7011 out-of-range times.
7012 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7013 (Fget_internal_run_time): Don't assume time_t fits in int.
7014 (make_time): Use list2 instead of Fcons twice.
7015 (Fdecode_time): More accurate test for out-of-range times.
7016 (check_tm_member): New function.
7017 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7018 (lisp_time_argument): Don't rely on undefined left-shift and
7019 right-shift behavior when checking for time stamp overflow.
8be6f318 7020
fe31d94c
PE
7021 * editfns.c (time_overflow): New function, refactoring common code.
7022 (Fformat_time_string, Fdecode_time, Fencode_time):
7023 (Fcurrent_time_string): Use it.
7024
8be6f318
PE
7025 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7026 * dired.c (make_time): Move to ...
7027 * editfns.c (make_time): ... here.
7028 * systime.h: Note the move.
7029
09d9db2c 70302011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7031
126bc0dc
YM
7032 * fringe.c (update_window_fringes): Remove unused variables.
7033
c47cbdfd
YM
7034 * unexmacosx.c (copy_data_segment): Also copy __got section.
7035 (Bug#8223)
7036
7ac80be9
EZ
70372011-03-12 Eli Zaretskii <eliz@gnu.org>
7038
c96bbc66 7039 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7040 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7041 Constify `char *' arguments and their references according to
7042 prototypes in tparam.h.
7043
ecb0f94d 7044 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7045
7ac80be9
EZ
7046 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7047 Adapt all references accordingly.
7048
7049 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7050
ef1fd07e
TT
70512011-03-11 Tom Tromey <tromey@redhat.com>
7052
7053 * buffer.c (syms_of_buffer): Remove obsolete comment.
7054
7ef4b50c
EZ
70552011-03-11 Eli Zaretskii <eliz@gnu.org>
7056
7057 * termhooks.h (encode_terminal_code): Declare prototype.
7058
7059 * msdos.c (encode_terminal_code): Don't declare prototype.
7060
7061 * term.c (encode_terminal_code): Now external again, used by
7062 w32console.c and msdos.c.
7063
44f230aa
SM
7064 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7065 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7066
4b1ec863 70672011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7068
1714f52b 7069 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7070
4b1ec863
PE
7071 * fringe.c (update_window_fringes): Mark locals as initialized
7072 (Bug#8227).
7073 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7074
524c7aa6
PE
7075 * alloc.c (mark_fringe_data): Move decl from here ...
7076 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7077 to check its interface.
7078 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7079
a5c0af81 7080 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7081 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7082 (fontset_font): Mark local as initialized.
a9a06e0b 7083 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7084
b4716021
PE
7085 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7086
811e9bac 7087 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7088 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7089 (x_own_selection, Fx_disown_selection_internal): Rename locals
7090 to avoid shadowing.
7091 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7092
7e3ab302
PE
7093 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7094 so that the caller can use some name other than gcpro1.
7095 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7096 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7097 (Fx_backspace_delete_keys_p):
7098 Use them to avoid shadowing, and rename vars to avoid shadowing.
7099 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7100 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7101 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7102 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7103 Remove unused locals.
7e3ab302
PE
7104 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7105 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7106 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7107 macros.
f78faa98 7108
e2b13473
PE
7109 * xterm.h (x_mouse_leave): New decl.
7110
77f23912
PE
7111 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7112 Remove unused functions.
cdf4ba58
PE
7113 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7114 (x_calc_absolute_position): Now static.
7411c686 7115 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7116 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7117 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7118 unless they are used.
38d0b34a
PE
7119 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7120 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7121 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7122 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7123 (x_error_catcher, x_connection_closed, x_error_handler):
7124 (x_error_quitter, xembed_send_message, x_iconify_frame):
7125 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7126 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7127 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7128
44f230aa
SM
7129 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7130 Rename or move locals to avoid shadowing.
6b463e58 7131 (tty_defined_color, merge_face_heights): Now static.
5967d051 7132 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7133 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7134 does not deduce is never used uninitialized.
73719eba
PE
7135 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7136 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7137
426994c3 7138 * terminal.c (store_terminal_param): Now static.
5489860b 7139
032f1620 7140 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7141 (set_frame_menubar): Remove unused local.
d4323972 7142 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7143 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7144 since they might point to immutable storage.
281585b0
PE
7145 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7146 since it's unused otherwise.
032f1620 7147
367c19e5 7148 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7149 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7150 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7151 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7152 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7153 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7154 does not deduce are never used uninitialized.
70739cbe 7155
07b48fa9
PE
7156 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7157
8868a238 7158 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7159 * window.c (window_loop, size_window):
7160 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7161
7e5cf297 7162 * window.c (display_buffer): Now static.
d6550a9f
PE
7163 (size_window): Mark variables that gcc -Wuninitialized
7164 does not deduce are never used uninitialized.
a586633d
PE
7165 * window.h (check_all_windows): New decl, to forestall
7166 gcc -Wmissing-prototypes diagnostic.
5b555da1 7167 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7168
f6095868
PE
7169 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7170 shadowing.
7171 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7172 Include <limits.h>.
7173 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7174 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7175 (load_charset_map): Mark variables that gcc -Wuninitialized
7176 does not deduce are never used uninitialized.
53df7c11 7177 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7178
f38b440c
PE
7179 * coding.c (coding_set_source, coding_set_destination):
7180 Use "else { /* comment */ }" rather than "else /* comment */;"
7181 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7182 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7183 a block, when the outer 'i' will do.
7184 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7185 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7186 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7187 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7188 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7189 Rename locals to avoid shadowing.
7190 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7191 * coding.c (emacs_mule_char, encode_invocation_designation):
7192 Now static, since they're not used elsewhere.
413bb2db 7193 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7194 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7195 (decode_coding_emacs_mule): Mark variables that gcc
7196 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7197 (detect_coding_iso_2022): Initialize a local variable that might
7198 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7199 this initialization is needed. (Bug#8211)
5f58e762
PE
7200 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7201 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7202 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7203 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7204 Remove unused macros.
f38b440c 7205
232b38b9 7206 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7207 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7208 * character.c (string_count_byte8): Likewise.
232b38b9 7209
fb90da1b
PE
7210 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7211 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7212
fb93dbc2
PE
7213 * chartab.c (copy_sub_char_table): Now static, since it's not used
7214 elsewhere.
5c156ace
PE
7215 (sub_char_table_ref_and_range, char_table_ref_and_range):
7216 Rename locals to avoid shadowing.
bbcd0949 7217 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7218
7d3b3862 7219 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7220 (BIDI_BOB): Remove unused macro.
7d3b3862 7221
6be7d3da
PE
7222 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7223 deduce are never used uninitialized.
c2ed9c8b 7224 * term.c (encode_terminal_code): Likewise.
6be7d3da 7225
75f8807f 7226 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7227
50938595
PE
7228 * tparam.h: New file.
7229 * term.c, tparam.h: Include it.
7230 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7231 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7232 Move these decls to tparam.h, and make them agree with what
7233 is actually in tparam.c. The previous trick of using incompatible
7234 decls in different modules does not conform to the C standard.
7235 All callers of tparam changed to use tparam's actual API.
7236 * tparam.c (tparam1, tparam, tgoto):
7237 Use const pointers where appropriate.
7238
fbceeba2
PE
7239 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7240 * cm.h (struct cm): Likewise.
7241 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7242 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7243 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7244 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7245 (turn_on_face, init_tty): Likewise.
7246 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7247
7f3f1250
PE
7248 * term.c (term_mouse_position): Rename local to avoid shadowing.
7249
e6ca6543
PE
7250 * alloc.c (mark_ttys): Move decl from here ...
7251 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7252
c40f8d15
AS
72532011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7254
7255 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7256
cfe0661d
JB
72572011-03-09 Juanma Barranquero <lekktu@gmail.com>
7258
7259 * search.c (compile_pattern_1): Remove argument regp, unused since
7260 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7261 (compile_pattern): Don't pass it.
7262
0afb4571
J
72632011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7264
7265 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7266 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7267 for ! HAVE_GTK3.
7268 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7269
7270 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7271
7272 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7273 gdk_window_get_screen, gdk_window_get_geometry,
7274 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7275 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7276 (xg_get_pixbuf_from_pixmap): New function.
7277 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7278 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7279 Call xg_get_pixbuf_from_pixmap instead of
7280 gdk_pixbuf_get_from_drawable.
7281 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7282 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7283 (xg_check_special_colors): Use GtkStyleContext and its functions
7284 for HAVE_GTK3.
7285 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7286 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7287 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7288 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7289 Call gtk_widget_get_preferred_size.
0afb4571
J
7290 (xg_frame_resized): gdk_window_get_geometry only takes 5
7291 parameters.
44f230aa
SM
7292 (xg_win_to_widget, xg_event_is_for_menubar):
7293 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7294 (xg_set_widget_bg): New function.
7295 (delete_cb): New function.
895009e1 7296 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7297 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7298 (xg_set_background_color): Call xg_set_widget_bg.
7299 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7300 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7301 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7302 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7303 if ! HAVE_GTK3.
7304 (update_frame_tool_bar): Call gtk_widget_hide.
7305 (xg_initialize): Use GDK_KEY_g.
7306
7307 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7308 if ! HAVE_GTK3
7309 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7310
7311 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7312 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7313 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7314
1c2cc4ef
JB
73152011-03-08 Juanma Barranquero <lekktu@gmail.com>
7316
7317 * w32xfns.c (select_palette): Check success of RealizePalette against
7318 GDI_ERROR, not zero.
7319
33383987 7320See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7321
7322;; Local Variables:
7323;; coding: utf-8
aac0c6e3
MR
7324;; End:
7325
33383987 7326 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7327
7328 This file is part of GNU Emacs.
7329
7330 GNU Emacs is free software: you can redistribute it and/or modify
7331 it under the terms of the GNU General Public License as published by
7332 the Free Software Foundation, either version 3 of the License, or
7333 (at your option) any later version.
7334
7335 GNU Emacs is distributed in the hope that it will be useful,
7336 but WITHOUT ANY WARRANTY; without even the implied warranty of
7337 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7338 GNU General Public License for more details.
7339
7340 You should have received a copy of the GNU General Public License
7341 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.