Remove some struct layout assumptions in bool vectors.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
d06714cb
PE
12012-07-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 Remove some struct layout assumptions in bool vectors.
4 * alloc.c (bool_header_size): New constant.
5 (header_size, word_size): Move earlier, as they're now used earlier.
6 Use 'word_size' in a few more places, where it's appropriate.
7 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
8 padding before the data member of a bool vector.
9 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
10 than doing the check by hand with an abort ().
11
464d5a5e
SM
122012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
13
5fbc0409
SM
14 * eval.c (Fdefvar): Don't check constants since we only set the var if
15 it's not yet defined anyway (bug#11904).
16
464d5a5e
SM
17 * lisp.h (last_undo_boundary): Declare new var.
18 * keyboard.c (command_loop_1): Set it.
19 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
20 were auto-added by the command loop (bug#11774).
21
8dc2e44a
AS
222012-07-18 Andreas Schwab <schwab@linux-m68k.org>
23
24 * w32font.c (Qsymbol): Remove local definition.
25 (syms_of_w32font): Don't DEFSYM it.
26
169925ec
DA
272012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
28
29 Fix sweep_vectors to handle large bool vectors correctly.
30 * alloc.c (sweep_vectors): Account total_vector_bytes for
31 bool vectors larger than VBLOCK_BYTES_MAX.
32
5fbfb018
CY
332012-07-18 Chong Yidong <cyd@gnu.org>
34
35 * frame.c (x_set_frame_parameters): Revert bogus change introduced
36 in 2012-05-25 commit by Paul Eggert (Bug#11738).
37
3ab6e069
DA
382012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
39
40 Return more descriptive data from Fgarbage_collect.
41 Suggested by Stefan Monnier in
42 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
43 * alloc.c (bounded_number): New function.
44 (total_buffers, total_vectors): New variable.
45 (total_string_size): Rename to total_string_bytes, adjust users.
46 (total_vector_size): Rename to total_vector_bytes, adjust users.
47 (sweep_vectors): Account total_vectors and total_vector_bytes.
48 (Fgarbage_collect): New return value. Adjust documentation.
49 (gc_sweep): Account total_buffers.
50 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
51 (VECTOR_SIZE): Remove.
52 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
53 (Qinterval, Qmisc): New symbols.
54 (syms_of_data): Initialize them.
55 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
56 (Qcons, Qbuffer): New declarations.
57
6d02fe5b
PE
582012-07-17 Paul Eggert <eggert@cs.ucla.edu>
59
60 * alloc.c (Fmemory_free): Account for memory-free's own storage.
61 Round up, not down. Improve doc.
62
b7ffe040
DA
632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
64
65 Restore old code in allocate_string_data to avoid Faset breakage.
66 Reported by Julien Danjou <julien@danjou.info> in
67 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
68 * alloc.c (allocate_string_data): Restore old code with minor
69 adjustments, fix comment to explain this subtle issue.
70
4dc7c8d5
SM
712012-07-17 Eli Zaretskii <eliz@gnu.org>
72
73 Remove FILE_SYSTEM_CASE.
74 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
75
76 * fileio.c (FILE_SYSTEM_CASE): Don't define.
77 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
78 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
79 call-process-region passes it through expand-file-name.
80
81 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
82
832012-07-17 Andreas Schwab <schwab@linux-m68k.org>
84
85 Fix crash when creating indirect buffer (Bug#11917)
86 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
87 Don't handle unbound variables specially if non-zero.
88 (Fbuffer_local_variables): Pass zero.
89 (clone_per_buffer_values): Pass non-zero.
90
912012-07-17 Andreas Schwab <schwab@linux-m68k.org>
92
93 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
94 to make the loop interruptible.
95
962012-07-17 Andreas Schwab <schwab@linux-m68k.org>
97
98 * gnutls.c (emacs_gnutls_handshake): Only retry if
99 GNUTLS_E_INTERRUPTED.
100
1012012-07-17 Eli Zaretskii <eliz@gnu.org>
cce7fefc
DA
1022012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
103
104 Cleanup and convert miscellaneous checks to eassert.
105 * alloc.c (mark_interval): Fix comment, partially rephrase
106 old comment from intervals.h (see below).
107 * intervals.c (find_interval, adjust_intervals_for_insertion)
108 (delete_interval, adjust_intervals_for_deletion)
109 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
110 Convert to eassert.
111 (adjust_intervals_for_insertion, make_new_interval):
112 Remove obsolete and unused code.
113 * intervals.h (struct interval): Remove obsolete comment.
114 * textprotp.c (erase_properties): Remove unused code.
115 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
116 (Fremove_list_of_text_properties): Convert to eassert.
117
9ea10cc3
CY
1182012-07-17 Chong Yidong <cyd@gnu.org>
119
120 * editfns.c (Finsert_char): Doc fix.
121
3900d5de
DA
1222012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
123
124 Fix previous change to make Fmemory_free always accurate.
125 * alloc.c (make_interval): Update total_free_intervals.
126 (make_float): Likewise for total_free_floats.
127 (free_cons, Fcons): Likewise for total_free_conses.
128 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
129 Likewise for total_free_vector_bytes.
130 (Fmake_symbol): Likewise for total_free_symbols.
131 (bytes_free): Remove.
132
7098646f
DA
1332012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
134
135 Simple free memory accounting feature.
136 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
137 (sweep_vectors): Accumulate size of free vectors.
138 (Fgarbage_collect): Setup bytes_free.
139 (Fmemory_free): New function.
140 (syms_of_alloc): Register it.
141
22657b40
DA
1422012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Cleanup overlays checking.
145 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
146 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
147 eassert and OVERLAYP.
148 (sort_overlays): Change to use OVERLAYP.
149
ddfc8813
RK
1502012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
151
152 * editfns.c (Finsert_char): Make it interactive, and make the
153 second arg optional. Copy interactive spec and docstring from
154 ucs-insert.
155
7c26cf3c
PE
1562012-07-17 Paul Eggert <eggert@cs.ucla.edu>
157
158 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
159 Unlike the other wrapped functions, fabs has an unspecified
160 effect on errno.
161
5d127af9
JD
1622012-07-16 Jan Djärv <jan.h.d@swipnet.se>
163
164 * nsterm.m (keyDown): Interpret flags without left/right bits
165 as the left key (Bug#11670).
166
6a0dd1d7
DA
1672012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
168
169 Remove empty and useless init functions.
170 * lisp.h (init_character_once, init_fns, init_image)
171 (init_filelock, init_sound): Remove prototype.
172 * character.c (init_character_once): Remove.
173 * filelock.c (init_filelock): Likewise.
174 * fns.c (init_fns): Likewise.
175 * image.c (init_image): Likewise.
176 * sound.c (init_sound): Likewise.
177 * emacs.c (main): Adjust accordingly.
178
7a6136fd
DA
1792012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
180
181 * gtkutil.h: Tiny cleanups.
182 (use_old_gtk_file_dialog): Remove useless declaration.
183 (xg_uses_old_file_dialog): Add suggested const attribute.
184
ce811ad9
EZ
1852012-07-15 Eli Zaretskii <eliz@gnu.org>
186
187 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
188 (bidi_paragraph_init): Use it to limit search forward for a strong
189 directional character in abnormally large paragraphs full of
190 neutral or weak characters. (Bug#11943)
191
c9adfeaa
SF
1922012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
193
194 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
195 the toolbar (Bug#9451).
196 (xg_make_tool_item): Give the widget event box a transparent
197 background.
198
fff62aa9
DA
1992012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
200
201 Cleanup basic allocation variables and functions.
202 * alloc.c (ignore_warnings, init_intervals, init_float)
203 (init_cons, init_symbol, init_marker): Remove.
204 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
205 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
206 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
207 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
208 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
209 (staticidx, init_alloc_once, init_strings, free_ablock):
210 Remove redundant initialization.
211 * fns.c (init_weak_hash_tables): Remove.
212 * lisp.h (init_weak_hash_tables): Remove prototype.
213
9730daca
DA
2142012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
215
216 Use zero_vector where appropriate.
217 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
218 accordingly.
219 * lisp.h (zero_vector): New declaration.
220 * font.c (null_vector): Remove.
221 (syms_of_font): Remove initialization and staticpro.
222 (font_list_entities, font_find_for_lface): Change to use zero_vector.
223 * keymap.c (Faccessible_keymaps): Likewise.
224
2e2d2a13
LL
2252012-07-15 Leo Liu <sdl.web@gmail.com>
226
227 * fringe.c: Fix typo in comments.
228
cd276f6e
LL
2292012-07-14 Leo Liu <sdl.web@gmail.com>
230
231 * fringe.c: Add a new bitmap exclamation-mark.
232
5a1131d9
EZ
2332012-07-14 Eli Zaretskii <eliz@gnu.org>
234
235 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
236
237 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
238 (HAVE_MENUS): Don't define, defined by editing config.in with
239 msdos/sed2v2.inp.
240 (GMALLOC_INHIBIT_VALLOC): Don't define.
241 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
242
22e983b7
JB
2432012-07-14 Juanma Barranquero <lekktu@gmail.com>
244
245 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
246
5b3f250f
GM
2472012-07-14 Glenn Morris <rgm@gnu.org>
248
249 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
250 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
251 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
252
33d63ff4
GM
2532012-07-13 Glenn Morris <rgm@gnu.org>
254
5b633342
GM
255 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
256
33d63ff4
GM
257 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
258 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
259
b55b9f85
JD
2602012-07-13 Jan Djärv <jan.h.d@swipnet.se>
261
0dc8cf50
JD
262 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
263 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
264 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
265 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
266 where appropriate.
267 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
268 as boolean expression.
269 (x_set_window_size): Remove unused variable toolbar.
270 (ns_get_color_default, ns_mod_to_lisp): Remove.
271 (ns_mouse_position): Remove unused variables xchar and ychar.
272 (ns_compute_glyph_string_overhangs): Remove unused variable face.
273 (ns_set_vertical_scroll_bar): Remove unused variable count.
274 (ns_delete_terminal): Remove unused variable i.
275 (ns_term_init): Remove unused variables r, g and b.
276 (mouseDown): Remove unused variable window.
277 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
278 (initFrameFromEmacs): Remove unused variable vbextra.
279 (mouseEntered): Remove unused variables p and dpyinfo.
280 (mouseExited): Remove unused variables p and r.
281 (ns_define_frame_cursor, ns_clear_frame_area)
282 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
283 (menuDown): Assign [sender tag] to variable and cast the variable.
284
285 * nsterm.h (menuDown): Add id as type to argument sender.
286 (ns_display_info_for_name): Add Lisp_Object argument.
287 (ns_term_init): Add Lisp_Object argument.
288 (ns_map_event_to_object): Add void argument.
289 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
290 prototype with arguments and only declare if __OBJC__.
291 (nxatoms_of_nsselect): Add void argument.
292 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
293 (ns_alloc_autorelease_pool): Add void argument.
294 (ns_release_autorelease_pool): Add void* argument.
295 (ns_get_defaults_value): Add const char* argument.
296
297 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
298 (initFromContents): Use SSDATA where appropriate.
299 (ns_update_menubar): Add braces to ambigous if-else.
300 (initWithTitle): Put () around assignment in if statement.
301 (ns_menu_show): Remove unused variables window and keymap.
302 (update_frame_tool_bar): Remove unused variable selected_p.
303 (initWithContentRect): Remove unused variable this_cmd_name.
304
305 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
306 appropriate.
307 (setXBMColor): Remove unused variable len.
308 (setPixmapData): Put () around assignment in loop statement.
309
310 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
311 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
312 where appropriate.
313 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
314 around assignment in loop statement.
315 (nsfont_open): Remove unused variable i.
316 (nsfont_open): Remove unused variable len.
317 (nsfont_draw): Remove unused variable cs.
318
319 * nsfns.m (x_set_icon_name, ns_set_name_internal)
320 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
321 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
322 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
323 (Fns_font_name, Fns_perform_service)
324 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
325 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
326 (ns_set_name): Remove unused variable view.
327 (x_set_menu_bar_lines): Remove unused variable olines.
328 (x_set_tool_bar_lines): Remove unused variable root_window.
329 (Fns_list_colors): Put () around assignment in while statement.
330 (Fns_perform_service): Remove unused variable len.
331 (Fns_display_usable_bounds): Remove unused variable top.
332 (syms_of_nsfns): Remove unused variable i.
333
b55b9f85
JD
334 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
335 memcpy (Bug#11907).
336
ed9265fc 3372012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
338
339 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
340 and free it with DestroyExceptionInfo (Bug#11558).
341
ef099b57
JB
3422012-07-13 Juanma Barranquero <lekktu@gmail.com>
343
344 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
345 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
346 Set here, not in nt/config.nt.
347
ea814a5d
EZ
3482012-07-13 Eli Zaretskii <eliz@gnu.org>
349
350 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
351 cursor overflow into the last glyph on display line when the right
352 fringe is off. (Bug#11832)
353
1a952767
PE
3542012-07-13 Paul Eggert <eggert@cs.ucla.edu>
355
356 * xdisp.c (produce_special_glyphs): Now static.
357 * dispextern.h (produce_special_glyphs): Remove decl.
358
983188fd
GM
3592012-07-13 Glenn Morris <rgm@gnu.org>
360
32fb4bb6
GM
361 * s/bsd-common, s/cygwin.h: Remove empty files.
362 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
363
983188fd
GM
364 * s/usg5-4-common.h (USG, USG5):
365 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
366 * s/sol2-6.h (SOLARIS2):
367 * s/irix6-5.h (IRIX6_5):
368 * s/hpux10-20.h (USG, USG5, HPUX):
369 * s/gnu-linux.h (USG, GNU_LINUX):
370 * s/freebsd.h (BSD_SYSTEM):
371 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
372 * s/cygwin.h (CYGWIN):
373 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
374 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
375
d1e68667 3762012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
377
378 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 379
6de0e799
GM
3802012-07-13 Glenn Morris <rgm@gnu.org>
381
739ae010
GM
382 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
383
dbee5793
GM
384 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
385
6de0e799
GM
386 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
387 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
388
b82da769
GM
3892012-07-12 Glenn Morris <rgm@gnu.org>
390
4fae5a7a 391 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
392
393 * process.c (init_process_emacs): Rename from init_process.
394 The old name is also the name of a Mach system call.
395 * lisp.h, emacs.c: Update for this name change.
396 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
397 longer needed.
398
5a979817
EZ
3992012-07-12 Eli Zaretskii <eliz@gnu.org>
400
401 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
402 memmove call that removes glyphs covered by the left truncation
403 glyph. Improve commentary.
404 (display_line): Fix display of continuation glyphs on GUI frames
405 when the right fringe is turned off and variable-size fonts are
406 used in the window. Move the code that appends a stretch glyph to
407 produce_special_glyphs, so that it could be used for truncation
408 and continuation glyphs alike.
409 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
410 glyph of a suitably computed width, to align the special glyphs at
411 the window margin. Code moved from display_line. (Bug#11832)
412
3e91a053
GM
4132012-07-12 Glenn Morris <rgm@gnu.org>
414
ba9e4b84
GM
415 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
416
417 * s/gnu-linux.h, s/hpux10-20.h:
418 Do not unconditionally define HAVE_XRMSETDATABASE.
419
3e91a053
GM
420 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
421
b300b1f4
PE
4222012-07-12 Paul Eggert <eggert@cs.ucla.edu>
423
424 Fix typos that broke OS X build.
425 Reported by Randal L. Schwartz in
426 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
427 * nsterm.m (ns_timeout): Add missing local decl.
428 (ns_get_color): snprintf -> sprintf, to fix typo.
429
6e777848
GM
4302012-07-12 Glenn Morris <rgm@gnu.org>
431
3f922c37
GM
432 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
433 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
434 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
435 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
436
0ab7b23a
GM
437 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
438 Move PTY_OPEN to configure.
439
6e777848
GM
440 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
441 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
442 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
443
4a7edc24
DA
4442012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
445
446 Use empty_unibyte_string where applicable.
447 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
448 * lread.c (read1): Likewise.
449 * xsettings.c (syms_of_xsettings): Likewise.
450
308aab79
GM
4512012-07-12 Glenn Morris <rgm@gnu.org>
452
42bd1719
GM
453 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
454 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
455 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
456 * s/hpux10-20.h (RUN_TIME_REMAP):
457 * s/bsd-common.h (TABDLY): Move to configure.
458
459 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
460
461 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
462
ea0bbd17 463 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 464 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
465
466 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 467
308aab79
GM
468 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
469 * s/template.h: Move NARROWPROTO to configure.
470
ee1cf5cf
GM
4712012-07-11 Glenn Morris <rgm@gnu.org>
472
30fe9bf4
GM
473 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
474 unused since 2011-01-17 change to systty.h.
475
ee1cf5cf
GM
476 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
477 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
478 Move HAVE_PTYS and HAVE_SOCKETS to configure.
479
63e47e07
PE
4802012-07-11 Paul Eggert <eggert@cs.ucla.edu>
481
482 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
483
c43fb4c3
GM
4842012-07-11 Glenn Morris <rgm@gnu.org>
485
486 * s/darwin.h, s/gnu-linux.h, s/template.h:
487 Move INTERRUPT_INPUT to configure.
488
e8df9267
DA
4892012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
490
491 Minor adjustments to interning code.
492 * lisp.h (intern, intern_c_string): Redefine as static inline
493 wrappers for intern_1 and intern_c_string_1, respectively.
494 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
495 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
496 Vobarray checking.
e8df9267
DA
497 * font.c (font_intern_prop): Likewise. Adjust comment.
498 * w32font.c (intern_font_name): Likewise.
499
34348bd4
AS
5002012-07-11 Andreas Schwab <schwab@linux-m68k.org>
501
d96a1e0c
AS
502 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
503
34348bd4
AS
504 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
505 of Fcar/Fcdr if possible.
506 * font.c (check_otf_features): Likewise.
507 * fontset.c (Fnew_fontset): Likewise.
508 * gnutls.c (Fgnutls_boot): Likewise.
509 * minibuf.c (read_minibuf): Likewise.
510 * msdos.c (IT_set_frame_parameters): Likewise.
511 * xmenu.c (Fx_popup_dialog): Likewise.
512 * w32menu.c (Fx_popup_dialog): Likewise.
513
c8add24e
GM
5142012-07-11 Glenn Morris <rgm@gnu.org>
515
4b575b3c
GM
516 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
517 since nothing has defined it on these platforms.
518
09f4e3b0
GM
519 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
520 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
521
172bedef
GM
522 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
523 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
524 Move CLASH_DETECTION to configure.
525
249685df
GM
526 * s/gnu.h: Remove file, which is now empty.
527
c8add24e
GM
528 * s/gnu.h, s/gnu-linux.h:
529 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
530
b41253a3
JW
5312012-07-11 John Wiegley <johnw@newartisans.com>
532
533 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
534 function attribute, so we only use it if it exists in the
535 compiler.
536
d923b542
DA
5372012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
538
539 Avoid call to strlen in fast_c_string_match_ignore_case.
540 * search.c (fast_c_string_match_ignore_case): Change to use
541 length argument. Adjust users accordingly.
542 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
543
5ebbef1d
PE
5442012-07-11 Paul Eggert <eggert@cs.ucla.edu>
545
bb352260
PE
546 Assume mkdir, rmdir.
547 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
548 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
549
57054ddd
PE
550 Assume rename.
551 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
552
b747d3f7
PE
553 Assume perror.
554 * s/hpux10-20.h (HAVE_PERROR): Remove.
555 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
556 Remove dummy definition, as this problem was obsolete long ago.
557
5ebbef1d
PE
558 Assume strerror.
559 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
560
984e7f30
DA
5612012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Avoid calls to strlen in font processing functions.
564 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 565 (font_open_by_name): Change to use length argument. Adjust
984e7f30 566 users accordingly.
d923b542
DA
567 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
568 Adjust prototypes.
569 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
570 Change to return ptrdiff_t.
984e7f30
DA
571 (xfont_list_pattern, xfont_match): Use length returned by
572 xfont_decode_coding_xlfd.
573 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
574
20e94fdd
GM
5752012-07-11 Glenn Morris <rgm@gnu.org>
576
9d596af3
GM
577 * s/darwin.h, s/freebsd.h, s/netbsd.h:
578 Move DONT_REOPEN_PTY to configure.
579
20e94fdd
GM
580 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
581 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
582
e99a530f
PE
5832012-07-10 Paul Eggert <eggert@cs.ucla.edu>
584
22ffb973
PE
585 Remove "#define unix" that is no longer needed (Bug#11905).
586 * s/aix4-2.h (unix): Remove; no longer needed.
587
e9a9ae03
PE
588 EMACS_TIME simplification (Bug#11875).
589 This replaces macros (which typically do not work in GDB)
590 with functions, typedefs and enums, making the code easier to debug.
591 The functional style also makes code easier to read and maintain.
592 * systime.h: Include <sys/time.h> on all hosts, not just if
593 WINDOWSNT, since 'struct timeval' is needed in general.
594 (EMACS_TIME): Now a typedef, not a macro.
595 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
596 not macros.
597 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
598 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
599 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
600 (EMACS_TIME_LE): Now functions, not macros.
601 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
602 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
603 which are not functions. All uses rewritten to use:
604 (make_emacs_time): New function.
605 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
606 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
607 not functions. All uses rewritten to use the following, respectively:
608 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
609 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 610 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
611 * fileio.c (Fcopy_file):
612 * xterm.c (XTflash): Get the current time closer to when it's used.
613 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
614
ffacb126
PE
615 * bytecode.c (targets): Suppress -Woverride-init warnings.
616
e99a530f
PE
617 Simplify by avoiding confusing use of strncpy etc.
618 * doc.c (Fsnarf_documentation):
619 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
620 * frame.c (Fmake_terminal_frame):
621 * gtkutil.c (get_utf8_string):
622 * lread.c (openp):
623 * nsmenu.m (ns_update_menubar):
624 * regex.c (regerror):
625 Prefer memcpy to strncpy and strncat when either will do.
626 * fileio.c (Fsubstitute_in_file_name):
627 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
628 (menu_separator_name_p):
629 * nsmenu.m (ns_update_menubar):
630 Prefer memcmp to strncmp when either will do.
631 * nsterm.m: Include <ftoastr.h>.
632 (ns_get_color):
633 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
634 Prefer snprintf to strncpy.
635 * nsterm.m (ns_term_init):
636 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
637 * nsterm.m (ns_term_init):
638 Avoid the need for strncpy, by using build_string or
639 make_unibyte_string directly. Use dtoastr, not snprintf.
640 * process.c (Fmake_network_process): Diagnose service names that
641 are too long, rather than silently truncating them or creating
642 non-null-terminated names.
643 (Fnetwork_interface_info): Likewise, for interface names.
644 * sysdep.c (system_process_attributes) [GNU_LINUX]:
645 Prefer sprintf to strncat.
646 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
647 Prefer vsnprintf to vsprintf + strncpy.
648
c59592b3
GM
6492012-07-10 Glenn Morris <rgm@gnu.org>
650
651 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
652 Clarify fallback case.
653
7d7bbefd
DA
6542012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
657 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
658 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 659 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
660 where argument type is known to be a Lisp_Cons.
661
3a4c8000
TT
6622012-07-10 Tom Tromey <tromey@redhat.com>
663
664 * bytecode.c (BYTE_CODE_THREADED): New macro.
665 (BYTE_CODES): New macro. Replaces all old byte-code defines.
666 (enum byte_code_op): New type.
667 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
668 (exec_byte_code): Use them. Use token threading when applicable.
669
2a0213a6
DA
6702012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
671
672 Optimize pure C strings initialization.
673 * lisp.h (make_pure_string): Fix prototype.
674 (build_pure_c_string): New function, defined as static inline. This
675 provides a better opportunity to optimize away calls to strlen when
676 the function is called with compile-time constant argument.
677 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
678 argument, adjust users accordingly. Use build_pure_c_string where
679 appropriate.
680 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
681 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
682 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
683
cb1caeaf
DA
6842012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
685
686 Avoid calls to strlen in miscellaneous functions.
687 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
688 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
689 * lread.c (openp): Likewise.
690
c293e30c
DA
6912012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Avoid calls to strlen in path processing functions.
694 * fileio.c (file_name_as_directory): Add comment. Change to add
695 srclen argument and return the length of result. Adjust users
696 accordingly.
697 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 698 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
699 users accordingly.
700 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
701
9e059e3f
GM
7022012-07-10 Glenn Morris <rgm@gnu.org>
703
d02eb359
GM
704 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
705 Move PENDING_OUTPUT_COUNT definition to configure.
706
882cf227
GM
707 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
708 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
709 * s/gnu.h (DATA_START): Move definitions to configure.
710
af6e839f
GM
711 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
712 We include usg5-4-common.h, which defines them both.
713
40289a12
GM
714 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
715 O_RDONLY already includes it).
716
9e059e3f
GM
717 Stop ns builds setting the EMACSLOADPATH environment variable.
718 * nsterm.m (ns_load_path): Rename from ns_init_paths.
719 Now it does not set EMACSLOADPATH, just returns the load-path string.
720 * nsterm.h: Update accordingly.
721 * lread.c [HAVE_NS]: Include nsterm.h.
722 (init_lread) [HAVE_NS]: Use ns_load_path.
723 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
724
7c4e8ec0
GM
7252012-07-09 Glenn Morris <rgm@gnu.org>
726
d4f600ff
GM
727 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
728 since the included bsd-common.h does so.
729
cbb31951
GM
730 Stop ns builds setting the EMACSPATH environment variable.
731 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
732 (ns_init_paths): Do not set EMACSPATH.
733 * nsterm.h (ns_exec_path): Add it.
734 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
735 Use ns_exec_path.
736
7c4e8ec0
GM
737 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
738
26bccfae
PE
7392012-07-09 Paul Eggert <eggert@cs.ucla.edu>
740
a0bee46f
PE
741 * process.c (wait_reading_process_output): 'waitchannels' was unset
742 when read_kbd || !NILP (wait_for_cell); fix this.
743
5994c183
PE
744 Add GCC-style 'const' attribute to functions that can use it.
745 * character.h (char_resolve_modifier_mask):
746 * keyboard.h (make_ctrl_char):
747 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
748 (init_character_once, next_almost_prime, init_fns, init_image)
749 (flush_pending_output, init_sound):
750 * mem-limits.h (start_of_data):
751 * menu.h (finish_menu_items):
752 Add ATTRIBUTE_CONST.
753 * emacs.c (DEFINE_DUMMY_FUNCTION):
754 Declare the dummy function with ATTRIBUTE_CONST.
755 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
756 Add decls with ATTRIBUTE_CONST.
757
26bccfae
PE
758 Minor improvements to make_formatted_string.
759 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
760 where int is good enough, as vsprintf returns an int.
761 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
762
a8290ec3
DA
7632012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
764
765 Use make_formatted_string to avoid double length calculation.
766 * lisp.h (make_formatted_string): New prototype.
767 * alloc.c (make_formatted_string): New function.
768 * buffer.c (Fgenerate_new_buffer_name): Use it.
769 * dbus.c (syms_of_dbusbind): Likewise.
770 * editfns.c (Fcurrent_time_zone): Likewise.
771 * filelock.c (get_boot_time): Likewise.
772 * frame.c (make_terminal_frame, set_term_frame_name)
773 (x_report_frame_params): Likewise.
774 * image.c (gs_load): Likewise.
775 * minibuf.c (get_minibuffer): Likewise.
776 * msdos.c (dos_set_window_size): Likewise.
777 * process.c (make_process): Likewise.
778 * xdisp.c (ensure_echo_area_buffers): Likewise.
779 * xsettings.c (apply_xft_settings): Likewise.
780
d01ba2f1
GM
7812012-07-09 Glenn Morris <rgm@gnu.org>
782
783 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
784 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
785 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
786 * nsterm.h (ns_etc_directory): Add it.
787 * callproc.c [HAVE_NS]: Include nsterm.h.
788 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
789
f1f924b6
DA
7902012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
791
792 Move marker debugging code under MARKER_DEBUG.
793 * marker.c (MARKER_DEBUG): Move marker debugging code under
794 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
795 for bootstrap with --enable-checking (~3x slowdown reported
796 by Juanma Barranquero <lekktu@gmail.com>).
797 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
798
ab531b66
PE
7992012-07-08 Paul Eggert <eggert@cs.ucla.edu>
800
801 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
802 See <http://bugs.gnu.org/11825#29>.
803
c4b3bc8a
EZ
8042012-07-08 Eli Zaretskii <eliz@gnu.org>
805
806 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
807 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
808 (display_line): Add commentary about displaying truncation glyphs
809 on GUI frames.
810 (produce_special_glyphs): Move here from term.c.
811
812 * term.c (produce_special_glyphs): Move to xdisp.c.
813
814 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
815 section.
c4b3bc8a 816
b676b881
AS
8172012-07-07 Andreas Schwab <schwab@linux-m68k.org>
818
f17c5273
AS
819 * xdisp.c (display_line): Avoid warning about implicit declaration
820 of FRAME_FONT.
821
298819b9
AS
822 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
823
b676b881
AS
824 * lisp.h: Remove empty conditional.
825
6045c4fd
PE
8262012-07-07 Paul Eggert <eggert@cs.ucla.edu>
827
b3350bf9
PE
828 * lread.c (load_path_check): Now static.
829
6045c4fd
PE
830 Fix some minor --with-ns problems found by static checking.
831 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
832 (x_set_font) [!HAVE_X_WINDOWS]:
833 * image.c (xpm_load_image) [HAVE_NS]:
834 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
835 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
836 Remove unused local.
837 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
838 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
839 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
840 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
841 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
842 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
843 Fix pointer signedness problem.
844 * xfaces.c (FRAME_X_FONT_TABLE):
845 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
846
929e7845
GM
8472012-07-07 Glenn Morris <rgm@gnu.org>
848
849 * lread.c (load_path_check): New function, split from init_lread.
850 (init_lread): Reorganize. Motivation:
851 If EMACSLOADPATH is set, check/warn about that rather than the
852 defaults, which we are not going to use. Hence we can remove
853 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
854 Don't warn if site-lisp directories are missing.
855 If not installed, start from a blank load-path, since
856 PATH_LOADSEARCH refers to the eventual installation directories.
857
58dd0aa4
EZ
8582012-07-07 Eli Zaretskii <eliz@gnu.org>
859
860 Support truncation and continuation glyphs on GUI frames, when
861 fringes are disabled. (Bug#11832)
862 * xdisp.c (init_iterator): Get dimensions of truncation and
863 continuation glyphs even if on GUI frames. Adjust
864 it->last_visible_x on GUI frames when the left or right fringes,
865 or both, are absent.
866 (start_display, move_it_in_display_line_to): Handle the case of a
867 GUI frame without a fringe to display continuation or truncation
868 glyphs.
869 (insert_left_trunc_glyphs): Support GUI frames: make sure
870 truncation glyphs overwrite enough glyphs from the current line to
871 have sufficient space in pixels.
872 (display_line): Support truncation and continuation glyphs on GUI
873 frames. If some spare pixels are left on the line after inserting
874 the truncation glyphs, fill that space with a stretch glyph of a
875 suitably computed width.
876
877 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
878 produce_glyphs, to support GUI sessions.
879
31571fd7
PE
8802012-07-07 Paul Eggert <eggert@cs.ucla.edu>
881
5a16b9bc
PE
882 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
883
f3047c75
PE
884 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
885
31571fd7
PE
886 Do not require float-time's arg to fit in time_t (Bug#11825).
887 This works better on hosts where time_t is unsigned, and where
888 float-time is applied to the (negative) difference between two times.
889 * editfns.c (decode_time_components): Last arg is now double *,
890 not int *, and means to store all the result as a double, without
891 worrying about whether the seconds part fits in time_t.
892 All callers changed.
893 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
894 All callers changed.
895 (Ffloat_time): Do not fail merely because the specified time falls
896 outside of time_t range.
897
4516fbef
GM
8982012-07-07 Glenn Morris <rgm@gnu.org>
899
900 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
901 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
902 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
903
07adc2c6
JB
9042012-07-07 Juanma Barranquero <lekktu@gmail.com>
905
906 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
907 Update dependencies.
908
909 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
910
fd573f31
PE
9112012-07-06 Paul Eggert <eggert@cs.ucla.edu>
912
fee5959d
PE
913 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
914 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
915 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
916 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
917 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
918 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
919
fd573f31
PE
920 * xfont.c (compare_font_names): Redo to omit the need for casts.
921
ddadbc0e
AS
9222012-07-06 Andreas Schwab <schwab@linux-m68k.org>
923
fca8d6b6
AS
924 * xfns.c (Fx_change_window_property): Doc fix.
925 * w32fns.c (Fx_change_window_property): Doc fix.
926
ddadbc0e
AS
927 * w32fns.c (Fx_window_property): Accept the same arguments as the
928 X Windows version. Doc fix.
929 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
930
ed9265fc 9312012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
932 Eli Zaretskii <eliz@gnu.org>
933
934 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
935 Windows-specific code from nt/config.nt moved here.
936 Obsolete settings removed.
937
216ee680
PE
9382012-07-06 Paul Eggert <eggert@cs.ucla.edu>
939
940 * process.c: Avoid unnecessary calls to gettime.
941 (wait_reading_process_output): Don't get the time of day
942 when gobbling data immediately and not waiting, as there's no need
943 for it in that case. This removes a FIXME.
944
bdd091e4
JD
9452012-07-06 Jan Djärv <jan.h.d@swipnet.se>
946
947 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
948 is defined (Bug#11768).
949
9d44f8ce
DA
9502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
951
952 Fix marker debugging code.
953 * marker.c (byte_char_debug_check): Do not perform the check
954 if buffer is not multibyte.
090bd7cb
JB
955 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
956 Call byte_char_debug_check with correct arguments.
9d44f8ce 957
90fc4786
DA
9582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
959
960 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
961 * marker.c (byte_char_debug_check, count_markers):
962 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
963 (byte_debug_flag): Remove.
964 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
965 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
966
7b7ae965
DA
9672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
968
4e57b342
DA
969 Avoid code repetition in marker-related functions.
970 * marker.c (attach_marker): New function.
971 (Fset_marker, set_marker_restricted, set_marker_both)
972 (set_marker_restricted_both): Use it.
973 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
974 Consistently rename charno to charpos.
975 (marker_position): Add eassert.
976 (marker_byte_position): Convert to eassert.
977
9782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
979
980 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 981 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 982 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 983
657924ff
DA
9842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Introduce fast path for the widely used marker operation.
987 * alloc.c (build_marker): New function.
988 * lisp.h (build_marker): New prototype.
989 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
990 * composite.c (autocmp_chars): Likewise.
991 * editfns.c (buildmark): Remove.
992 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
993 (save_restriction_save): Use build_marker.
994 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
995 * window.c (save_window_save): Likewise.
996
041a49a6
DA
9972012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
998
999 Do not use Fdelete_overlay in delete_all_overlays
1000 to avoid redundant calls to unchain_overlay.
1001 * buffer.c (drop_overlay): New function.
1002 (delete_all_overlays, Fdelete_overlay): Use it.
1003 * minibuf.c (get_minibuffer): Fix comment.
1004
7dca65a4
PE
10052012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 Port to OpenBSD 5.1 amd64.
1008 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1009 This is needed for OpenBSD, and should be harmless on all BSD systems.
1010 Also, include <sys/sysctl.h>, as it should be available on all
1011 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1012 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1013 use p_pid member, not kp_proc.pid.
1014
8eb876e2
GM
10152012-07-06 Glenn Morris <rgm@gnu.org>
1016
1017 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1018
38182d90
PE
10192012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 More xmalloc and related cleanup.
1022 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1023 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1024 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1025 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1026 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1027 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1028 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1029 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1030 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1031 * xterm.c:
1032 Omit needless casts involving void * pointers and allocation.
1033 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1034 as the former is more robust if P's type is changed.
1035 Prefer xzalloc to xmalloc + memset 0.
1036 Simplify malloc-or-realloc to realloc.
1037 Don't worry about xmalloc returning a null pointer.
1038 Prefer xstrdup to xmalloc + strcpy.
1039 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1040 growing it.
1041 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1042 alloca of a constant.
1043
6dd5a677
EZ
10442012-07-05 Eli Zaretskii <eliz@gnu.org>
1045
1046 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1047 hscroll is larger than the line width. Fixes long and futile
1048 looping inside extend_face_to_end_of_line (on a TTY) producing
1049 glyphs that are not needed and thrown away.
1050
6b312f0f
DA
10512012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1052
1053 * marker.c (set_marker_restricted_both): Simplify by using
1054 clip_to_bounds.
1055
f520ef9b
PE
10562012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1059
383b7c95
JD
10602012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1061
1062 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1063 not defined (Bug#11768).
1064 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1065 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1066 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1067 followed by gtk_box_set_homogeneous (Bug#11768).
1068 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1069 (update_theme_scrollbar_width, xg_create_scroll_bar):
1070 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1071 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1072 (is_box_type): New function (Bug#11768).
1073 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1074 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1075 with default display (Bug#11768).
1076
d6e7bf45
EZ
10772012-07-05 Eli Zaretskii <eliz@gnu.org>
1078
1079 * xdisp.c (window_hscroll_limited): New function.
1080 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1081 coordinates when window's hscroll is set to insanely large
1082 values. (Bug#11857)
1083
431391ec
JB
10842012-07-05 Juanma Barranquero <lekktu@gmail.com>
1085
1086 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1087 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1088
23f86fce
DA
10892012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1090
1091 Cleanup xmalloc.
1092 * lisp.h (xzalloc): New prototype. Omit needless casts.
1093 * alloc.c (xzalloc): New function. Omit needless casts.
1094 * charset.c: Omit needless casts. Convert all calls to
1095 xmalloc with following memset to xzalloc.
1096 * dispnew.c: Likewise.
1097 * fringe.c: Likewise.
1098 * image.c: Likewise.
1099 * sound.c: Likewise.
1100 * term.c: Likewise.
1101 * w32fns.c: Likewise.
1102 * w32font.c: Likewise.
1103 * w32term.c: Likewise.
1104 * xfaces.c: Likewise.
1105 * xfns.c: Likewise.
1106 * xterm.c: Likewise.
1107 * atimer.c: Omit needless casts.
1108 * buffer.c: Likewise.
1109 * callproc.c: Likewise.
1110 * ccl.c: Likewise.
1111 * coding.c: Likewise.
1112 * composite.c: Likewise.
1113 * doc.c: Likewise.
1114 * doprnt.c: Likewise.
1115 * editfns.c: Likewise.
1116 * emacs.c: Likewise.
1117 * eval.c: Likewise.
1118 * filelock.c: Likewise.
1119 * fns.c: Likewise.
1120 * gtkutil.c: Likewise.
1121 * keyboard.c: Likewise.
1122 * lisp.h: Likewise.
1123 * lread.c: Likewise.
1124 * minibuf.c: Likewise.
1125 * msdos.c: Likewise.
1126 * print.c: Likewise.
1127 * process.c: Likewise.
1128 * region-cache.c: Likewise.
1129 * search.c: Likewise.
1130 * sysdep.c: Likewise.
1131 * termcap.c: Likewise.
1132 * terminal.c: Likewise.
1133 * tparam.c: Likewise.
1134 * w16select.c: Likewise.
1135 * w32.c: Likewise.
1136 * w32reg.c: Likewise.
1137 * w32select.c: Likewise.
1138 * w32uniscribe.c: Likewise.
1139 * widget.c: Likewise.
1140 * xdisp.c: Likewise.
1141 * xmenu.c: Likewise.
1142 * xrdb.c: Likewise.
1143 * xselect.c: Likewise.
1144
0497dc44
PE
11452012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1146
1147 * fileio.c (time_error_value): Check the right error number.
1148 Problem reported by Troels Nielsen in
1149 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1150
356e7178
PE
11512012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1152
4e71fd89
PE
1153 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1154 This should be fixed in a better way; see Eli Zaretskii in
1155 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1156 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1157
f0941253
PE
1158 * fileio.c (time_error_value): Rename from special_mtime.
1159 The old name's problems were noted by Eli Zaretskii in
1160 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1161
065c9eb4
PE
1162 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1163 This variable's comment says Emacs needs at least one GDB-visible
1164 symbol of type enum pvec_type, to work around GDB problems.
1165 The symbol's value doesn't matter.
1166
356e7178
PE
1167 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1168 that causes compilation to fail on pre-C99 compilers.
1169
ed9265fc 11702012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1171
1172 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1173 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1174
3884d954
DA
11752012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1176
d209e2fb 1177 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1178 headers for buffer_defaults and buffer_local_symbols.
1179 Reported by Juanma Barranquero <lekktu@gmail.com>.
1180
ee28be33
SM
11812012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1182
1183 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1184 * lisp.h (enum pvec_type): Use fewer bits.
1185 (PSEUDOVECTOR_SIZE_BITS): New constant.
1186 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1187 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1188 change in pvec_type.
1189 (PSEUDOVECTOR_TYPEP): New macro.
1190 (TYPED_PSEUDOVECTORP): Use it.
1191 * fns.c (internal_equal): Adapt code to extract pvectype.
1192 * emacs.c (gdb_pvec_type): Update type.
1193 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1194 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1195 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1196 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1197 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1198 abusing vector->header.next.nbytes.
1199 (live_vector_p): Use PVEC_TYPE.
1200 (mark_object): Adapt code to extract pvectype. Use switch.
1201
c7f2cd7f
PE
12022012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1205 Tighten new eassert a bit.
1206
8ce70ed2
DA
12072012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 Fix compilation with --enable-gcc-warnings and -O1
1210 optimization level.
1211 * doprnt.c (doprnt): Change type of tem to int, initialize
1212 to avoid compiler warning. Add eassert.
1213 * search.c (simple_search): Initialize match_byte to avoid
1214 compiler warning. Add eassert.
1215
dea7f1e5
PE
12162012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1217
24a212eb
PE
1218 Avoid weird behavior with large horizontal scrolls.
1219 Without this change, for example, large hscroll values would
1220 mess up Emacs's display on Fedora 15 x86, presumably due to
1221 overflows in int calculations in the display code.
1222 Also, if buffers had long lines, Emacs would freeze.
1223 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1224 (set_window_hscroll): New function, containing the old guts of
1225 Fset_window_hscroll. Return the clipped value.
1226 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1227 This avoids the need to check against PTRDIFF_MAX.
1228
dea7f1e5
PE
1229 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1230
76046526
DA
12312012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1232
1233 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1234
39adff0d
PE
12352012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1236
63807d47
PE
1237 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1238 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1239 since GCC 4.4.6 issues a bogus warning for them.
1240
39adff0d
PE
1241 Fix bugs in file timestamp newness comparisons.
1242 * fileio.c (Ffile_newer_than_file_p):
1243 * lread.c (Fload): Use full timestamp resolution of files,
1244 not just the 1-second resolution, so that files that are only
1245 slightly newer still count as newer.
1246 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1247 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1248
dbeed9a6
PE
12492012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1250
1251 * fileio.c: Improve handling of file time marker. (Bug#11852)
1252 (special_mtime): New function.
1253 (Finsert_file_contents, Fverify_visited_file_modtime):
1254 Use it to set special mtime values consistently.
1255
636334d6
AS
12562012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1257
1258 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1259 marker for non-existing file. (Bug#11852)
1260
e2017fe2
GM
12612012-07-03 Glenn Morris <rgm@gnu.org>
1262
1263 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1264 and did not make it into globals.h).
1265
404dbd37
TT
12662012-07-03 Tom Tromey <tromey@redhat.com>
1267
1268 * window.c (Fset_window_margins, Fset_window_fringes)
1269 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1270 * textprop.c (Fprevious_property_change): No longer static.
1271 * syntax.c (Fsyntax_table_p): No longer static.
1272 * process.c (Fget_process, Fprocess_datagram_address): No longer
1273 static.
1274 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1275 * keyboard.c (Fcommand_execute): No longer static.
1276 Remove EXFUN.
1277 * insdel.c (Fcombine_after_change_execute): No longer static.
1278 * image.c (Finit_image_library): No longer static.
1279 * fileio.c (Fmake_symbolic_link): No longer static.
1280 * eval.c (Ffetch_bytecode): No longer static.
1281 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1282 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1283 No longer static.
404dbd37
TT
1284 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1285 static.
1286 * dired.c (Ffile_attributes): No longer static.
1287 * composite.c (Fcomposition_get_gstring): No longer static.
1288 * callproc.c (Fgetenv_internal): No longer static.
1289
1290 * ccl.h: Remove EXFUNs.
1291 * buffer.h: Remove EXFUNs.
1292 * dispextern.h: Remove EXFUNs.
1293 * intervals.h: Remove EXFUNs.
1294 * fontset.h: Remove EXFUN.
1295 * font.h: Remove EXFUNs.
1296 * dosfns.c (system_process_attributes): Remove EXFUN.
1297 * keymap.h: Remove EXFUNs.
1298 * lisp.h: Remove EXFUNs.
1299 * w32term.h: Remove EXFUNs.
1300 * window.h: Remove EXFUNs.
1301 * xsettings.h: Remove EXFUN.
1302 * xterm.h: Remove EXFUN.
1303
8e4fd1e1
GM
13042012-07-03 Glenn Morris <rgm@gnu.org>
1305
1306 * lisp.h (Frandom): Make it visible to C.
1307 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1308 buffer for invisible buffers. (Bug#1229)
1309
ca95b3eb
DA
13102012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1313 values which aren't power of 2.
1314 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1315 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1316 accordingly.
1317
7555c33f
SM
13182012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1321
1322 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1323
d12e8f5a
DA
13242012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1325
1326 * alloc.c (allocate_vector_block): Remove redundant
1327 calls to mallopt if DOUG_LEA_MALLOC is defined.
1328 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1329 avoid calls to mallopt if zero_vector is returned.
1330
296094c3
DA
13312012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1334 is enabled, avoid dereferencing NULL current_sblock if
1335 running undumped.
1336
36429c89
DA
13372012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1338
1339 Cleanup basic buffer management.
1340 * buffer.h (struct buffer): Change layout to use generic vector
1341 marking code. Fix some comments. Change type of 'clip_changed'
1342 to bitfield. Remove unused #ifndef old.
1343 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1344 (GET_OVERLAYS_AT): Fix indentation.
1345 (for_each_per_buffer_object_at): New macro.
1346 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1347 (Fbuffer_local_variables): Use it.
1348 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1349 * alloc.c (allocate_buffer): Adjust to match new layout of
1350 struct buffer. Fix comment.
1351 (mark_overlay): New function.
1352 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1353 Lisp area of struct buffer.
1354 (mark_object): Use it. Adjust marking of misc objects
1355 and related comments.
1356
3b3e4cac
PE
13572012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1358
1359 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1360 wrapper that is not needed because the wrapped code is a no-op (zero
1361 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1362 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1363
cf5c0175
DA
13642012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1365
1366 * alloc.c (mark_buffer): Simplify. Remove prototype.
1367 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1368 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1369 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1370 redundant calls to mark_vectorlike for bool vectors.
1371
ca26824c
GM
13722012-06-30 Glenn Morris <rgm@gnu.org>
1373
2e4c5312
GM
1374 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1375
ca26824c
GM
1376 * epaths.in (PATH_SITELOADSEARCH): New.
1377 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1378 This is rather than relying on --enable-locallisppath elements
1379 having "site-lisp" in their names. (Bug#10208#25, 11658)
1380
0d23c240
EZ
13812012-06-30 Eli Zaretskii <eliz@gnu.org>
1382
c9240d7a
EZ
1383 * w32proc.c (sys_select): Accept and ignore one more argument.
1384
1385 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1386
0d23c240 1387 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1388 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1389
1390 * sysdep.c: Don't include dos.h and dosfns.h.
1391
1392 * process.c (sys_select):
1393 * msdos.c (sys_select): Accept one more argument and ignore it.
1394
1395 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1396 adapt data types and code to that.
1397
1398 * dosfns.c:
1399 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1400 which clashes with the gnulib function of the same name.
1401
af5a5a98
AS
14022012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1403
c5e4379c
AS
1404 * font.c (font_style_to_value, font_style_symbolic)
1405 (font_prop_validate_style): Add type checks for values in
1406 font_style_table.
1407
af5a5a98
AS
1408 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1409 argument.
1410 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1411 uses.
1412
8d38f461
EZ
14132012-06-29 Eli Zaretskii <eliz@gnu.org>
1414
2e5a6631
EZ
1415 * xdisp.c (try_window_id): Undo last change.
1416
8d38f461
EZ
1417 * w32.c (getwd): Adjust commentary about startup_dir.
1418 (init_environment): Always call sys_access, even in non-MSVC
1419 builds. Don't chdir to the directory of the Emacs executable.
1420 This undoes code from 1997 which was justified by the need to
1421 "avoid conflicts when removing and renaming directories". But its
1422 downside was that every relative file name was being interpreted
1423 relative to the directory of the Emacs executable, which can never
1424 be TRT. In particular, it broke sys_access when called with
1425 relative file names.
1426 (sys_access): Map GetLastError to errno.
1427
2af3565e
DA
14282012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1429
1430 * window.h (struct window): Change type of 'fringes_outside_margins'
1431 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1432 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1433 Adjust comment.
1434 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1435 to ptrdiff_t.
1436
c8d3a25c 14372012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1438
c8d3a25c
GM
1439 * gnutls.c (emacs_gnutls_handshake):
1440 Add QUIT to make the loop interruptible.
57570cd3 1441
c8d3a25c 14422012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1443
c8d3a25c
GM
1444 * charset.c (init_charset): Make lack of etc/charsets fatal.
1445
3e984ee8
DA
14462012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1447
1448 * editfns.c (region_limit): Fix type mismatch.
1449
ef884f23
DA
14502012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1451
1452 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1453 undefined. Convert from xassert to eassert.
1454 * nsmenu.m: Convert from xassert to eassert.
1455 * nsterm.m: Likewise.
1456
7d7e0027
SM
14572012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1458
1459 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1460
aa754e6a
PE
14612012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1462
1463 Avoid integer overflow on scroll-left and scroll-right.
1464 * window.c (HSCROLL_MAX): New macro.
1465 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1466 overflow when requested scroll falls outside ptrdiff_t range.
1467
80b00b08
DA
14682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1469
1470 * window.h (struct window): Change type of 'hscroll',
1471 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1472 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1473 Adjust users accordingly.
1474 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1475 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1476 from EMACS_INT to ptrdiff_t.
1477 (make_window): Omit redundant initialization.
1478
62b2bcf6
JB
14792012-06-28 Juanma Barranquero <lekktu@gmail.com>
1480
1481 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1482
45942c7d
DA
14832012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 * window.h (struct window): Change type of 'use_time' and
1486 'sequence_number' from Lisp_Object to int.
1487 * frame.c (make_frame): Adjust users accordingly.
1488 * print.c (print_object): Likewise.
1489 * window.c (select_window, Fwindow_use_time, make_parent_window)
1490 (make_window): Likewise.
1491
e509cfa6
DA
14922012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1493
1494 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1495 enabled with --enable-checking=[all,glyphs] configure option.
1496 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1497 adjust comments accordingly.
1498 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1499 undefined, adjust comments accordingly.
1500 * image.c: Likewise.
1501 * scroll.c: Likewise.
1502 * w32fns.c: Likewise.
1503 * w32term.c: Likewise.
1504 * xdisp.c: Likewise.
1505 * xfaces.c: Likewise.
1506 * xfns.c: Likewise.
1507 * xterm.c: Likewise.
1508
a54e2c05
DA
15092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1510
1511 Generalize run-time debugging checks.
1512 * dispextern.h (XASSERTS): Remove.
1513 * fontset.c (xassert): Remove.
1514 Convert from xassert to eassert.
1515 * alloc.c: Convert from xassert to eassert.
1516 * bidi.c: Likewise.
1517 * dispnew.c: Likewise.
1518 * fns.c: Likewise.
1519 * fringe.c: Likewise.
1520 * ftfont.c: Likewise.
1521 * gtkutil.c: Likewise.
1522 * image.c: Likewise.
1523 * keyboard.c: Likewise.
1524 * menu.c: Likewise.
1525 * process.c: Likewise.
1526 * scroll.c: Likewise.
1527 * sound.c: Likewise.
1528 * term.c: Likewise.
1529 * w32console.c: Likewise.
1530 * w32fns.c: Likewise.
1531 * w32term.c: Likewise.
1532 * window.c: Likewise.
1533 * xdisp.c: Likewise.
1534 * xfaces.c: Likewise.
1535 * xfns.c: Likewise.
1536 * xselect.c: Likewise.
1537 * xterm.c: Likewise.
1538
1ec4b7b2
SM
15392012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * fns.c (maybe_resize_hash_table): Output message when growing the
1542 purify-hashtable.
1543
2014308a
DA
15442012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1545
1546 * alloc.c (allocate_string_data): Remove dead code.
1547 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1548 avoid GCC warning about unused macro.
1549
246155eb
DA
15502012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 * alloc.c (allocate_string): Omit intervals initialization.
1553 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1554 as in make_pure_string and make_pure_c_string.
1555
43184b7b
DA
15562012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1557
d209e2fb 1558 * alloc.c (allocate_string): Fix last change.
43184b7b 1559
3fe6dd74
DA
15602012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1561
d209e2fb 1562 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1563 to memset, add explicit initialization where appropriate.
1564
1ba6038a
GM
15652012-06-27 Glenn Morris <rgm@gnu.org>
1566
1567 * lisp.mk (lisp): Remove paths.elc.
1568
c89926a5
CY
15692012-06-27 Chong Yidong <cyd@gnu.org>
1570
1571 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1572
ed6b3510
JW
15732012-06-26 John Wiegley <johnw@newartisans.com>
1574
1ec4b7b2 1575 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1576 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1577
ed6b3510
JW
1578 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1579 when building with Clang.
1580
8edd4a2b
SM
15812012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1582
1583 * eval.c (Fapply): Allow calling it with a single argument.
1584
f6f62d1b
EZ
15852012-06-26 Eli Zaretskii <eliz@gnu.org>
1586
1587 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1588 _stricmp and _strnicmp.
1589 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1590
62efea5e
DA
15912012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1592
1593 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1594 allocated window.
1595 (allocate_process): Likewise for new process.
8edd4a2b 1596 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1597 (allocate_frame): Likewise.
1598 * frame.c (make_frame): Omit redundant initialization.
1599 * window.c (make_parent_window): Use memset.
1600 (make_window): Omit redundant initialization.
1601 * process.c (make_process): Omit redundant initialization.
1602 * terminal.c (create_terminal): Likewise.
1603
42997f4d
DA
16042012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1605
1606 * term.c (delete_tty): Remove redundant call to memset.
1607
1130ecfc
DA
16082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1609
1610 * alloc.c: Remove build_string.
1611 * lisp.h: Define build_string as static inline. This provides
1612 a better opportunity to optimize away calls to strlen when the
1613 function is called with compile-time constant argument.
1614 * image.c (imagemagick_error): Convert to build_string.
1615 * w32proc.c (sys_spawnve): Likewise.
1616 * xterm.c (x_term_init): Likewise.
1617
cf38a720
PE
16182012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1619
99027bdd
PE
1620 Use sprintf return value instead of invoking strlen on result.
1621 In the old days this wasn't portable, since some sprintf
1622 implementations returned char *. But they died out years ago and
1623 Emacs already assumes sprintf returns int.
1624 Similarly for float_to_string.
1625 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1626 * ccl.c (ccl_driver):
1627 * character.c (string_escape_byte8):
1628 * data.c (Fnumber_to_string):
1629 * doprnt.c (doprnt):
1630 * print.c (print_object):
1631 * xdisp.c (message_dolog):
1632 * xfns.c (syms_of_xfns):
1633 Use sprintf or float_to_string result to avoid need to call strlen.
1634 * data.c (Fnumber_to_string):
1635 Use make_unibyte_string, since the string must be ASCII.
1636 * lisp.h, print.c (float_to_string): Now returns int length.
1637 * term.c (produce_glyphless_glyph):
1638 Use sprintf result rather than recomputing it.
1639
cf38a720
PE
1640 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1641 * Makefile.in (ALL_CFLAGS):
1642 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1643 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1644
3511c784
DA
16452012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1646
0a08eb21 1647 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1648 strcasecmp if available.
1649 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1650
fb7da12e
AS
16512012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1652
1653 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1654 Avoid comma operator.
1655 * menu.c (push_submenu_start, push_submenu_end)
1656 (push_left_right_boundary, push_menu_pane): Likewise.
1657 * msdos.c (dos_rawgetc): Likewise.
1658
afa2ffd8
DA
16592012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1660
1661 * xfns.c (xic_create_fontsetname): Remove redundant calls
1662 to memset.
1663
b3b4476b
PE
16642012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1665
4495ff38
PE
1666 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1667 sprintf already null-terminates its output.
1668
b3b4476b
PE
1669 * xfns.c (x_window): Remove redundant cast.
1670
b00876c9
DA
16712012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1672
1673 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1674 `const char *' to `char *' to avoid compiler warning.
1675
d188e26b
PE
16762012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1677
885d1d74
PE
1678 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1679 instead of truncating it to 63 (admittedly a generous limit).
1680
d188e26b
PE
1681 * process.c: Fix spelling and caps in comments.
1682
e2f560b1
DN
16832012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1684
e86db54b 1685 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1686 * sysdep.c (setpgrp): Remove definition, not used in this file.
1687
7583a3a1
JB
16882012-06-24 Juanma Barranquero <lekktu@gmail.com>
1689
1690 * makefile.w32-in: Update dependencies.
1691
696056c2
EZ
16922012-06-24 Eli Zaretskii <eliz@gnu.org>
1693
1694 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1695 (SYSTIME_H): Add nt/inc/sys/time.h.
1696
1697 * systime.h [WINDOWSNT]: Include sys/time.h.
1698
1699 * s/ms-w32.h (struct timespec): Definition moved from
1700 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1701
845ca893
PE
17022012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1705 * buffer.h (buffer_slot_type_mismatch):
1706 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1707 * eval.c (unwind_to_catch):
1708 * image.c (my_png_error, my_error_exit):
1709 * keyboard.c (quit_throw_to_read_char, user_error)
1710 (Fexit_recursive_edit, Fabort_recursive_edit):
1711 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1712 (wrong_type_argument, buffer_overflow, __executable_start)
1713 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1714 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1715 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1716 (fatal):
1717 (child_setup) [!DOS_NT]:
1718 * lread.c (end_of_file_error, invalid_syntax):
1719 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1720 * puresize.h (pure_write_error):
1721 * search.c (matcher_overflow):
1722 * sound.c (sound_perror, alsa_sound_perror):
1723 * sysdep.c, syssignal.h (croak):
1724 * term.c (maybe_fatal, vfatal):
1725 * textprop.c (text_read_only):
1726 * undo.c (user_error):
1727 * unexmacosx.c (unexec_error):
1728 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1729 Use _Noreturn rather than NO_RETURN.
1730 No need for separate decl merely because of _Noreturn.
1731 * sound.c (sound_warning, parse_sound):
1732 Remove unnecessary forward decls.
1733
f1dd8073
PE
17342012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1735
1736 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1737 * lisp.h (WAIT_READING_MAX): New macro.
1738 * dispnew.c (Fsleep_for, sit_for):
1739 * keyboard.c (kbd_buffer_get_event):
1740 * process.c (Faccept_process_output):
1741 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1742 This improves on the previous patch, which introduced a bug
1743 when time_t is unsigned and as wide as intmax_t.
1744 See <http://bugs.gnu.org/9000#51>.
1745
b82c1755
EZ
17462012-06-23 Eli Zaretskii <eliz@gnu.org>
1747
1748 * dispnew.c (sit_for, Fsleep_for):
1749 * keyboard.c (kbd_buffer_get_event):
1750 * process.c (Faccept_process_output): Avoid compiler warnings when
1751 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1752
ca300656
JB
17532012-06-23 Juanma Barranquero <lekktu@gmail.com>
1754
049ec95b
JB
1755 * makefile.w32-in: Update dependencies.
1756
ca300656
JB
1757 * w32.c (ltime): Add return type and declare static.
1758 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1759
db7b8d06
PE
17602012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1761
1762 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1763 Privately reported by Herbert J. Skuhra.
1764 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1765 All uses changed.
1766 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1767 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1768
0bd8297f
EZ
17692012-06-23 Eli Zaretskii <eliz@gnu.org>
1770
96512555
EZ
1771 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1772 last argument of make_unibyte_string.
1773
0bd8297f
EZ
1774 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1775 language ID in the event parameters.
1776
1777 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1778 event.code, not the obscure "character set ID".
1779
63def6b6
CY
17802012-06-23 Chong Yidong <cyd@gnu.org>
1781
1782 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1783
e8a02204
EZ
17842012-06-23 Eli Zaretskii <eliz@gnu.org>
1785
388cdec0
EZ
1786 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1787 * w32.c (fdutimens): New function.
1788
1789 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1790
1791 * s/ms-w32.h (pselect): Redirect to sys_select.
1792
1793 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1794
e8a02204
EZ
1795 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1796 in the logic of incrementing and decrementing the value of
1797 use_relocatable_buffers.
1798
d054f3fb
PE
17992012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1802 Privately reported by Herbert J. Skuhra.
1803 [__FreeBSD__]: Remove "*/" typo after "#include".
1804 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1805 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1806 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1807 Don't assume EMACS_TIME and struct timeval are the same type.
1808
d35af63c
PE
18092012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1810
1811 Support higher-resolution time stamps (Bug#9000).
1812 The time stamps are only nanosecond-resolution at the C level,
1813 since that's the best that any real-world system supports now.
1814 But they are picosecond-resolution at the Lisp level, as that's
1815 easy, and leaves room for future OS improvements.
1816
1817 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1818 (LIBES): Use it.
1819
1820 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1821 Don't get current time unless it's needed.
1822
1823 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1824 now provides it if it's absent.
1825 (start_atimer): Port to higher-res time stamps.
1826 Check for time stamp overflow. Don't get current time more
1827 often than is needed.
1828
1829 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1830 Include systime.h, not time.h.
1831 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1832
1833 * dired.c: Include stat-time.h.
1834 (Ffile-attributes): File times now have higher resolution.
1835
1836 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1837 (struct image): Timestamp now has higher resolution.
1838
1839 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1840 has at least microseconds now. All uses removed.
1841 (update_frame, update_single_window, update_window, update_frame_1)
1842 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1843
1844 * editfns.c (time_overflow): Now extern.
1845 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1846 (float-time, Fformat_time_string, Fcurrent_time_string)
1847 (Fcurrent_time_zone): Accept and generate higher-resolution
1848 time stamps.
1849 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1850 (decode_time_components, lisp_seconds_argument): New functions.
1851 (make_time): Now static.
1852 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1853 Report an error if the time is invalid, rather than having the caller
1854 do that.
1855
1856 * fileio.c: Include <stat-time.h>
1857 (Fcopy_file): Copy higher-resolution time stamps.
1858 Prefer to set the time stamp via a file descriptor if that works.
1859 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1860 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1861 (Fvisited_file_modtime, Fset_visited_file_modtime):
1862 Support higher-resolution time stamps.
1863
1864 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1865
1866 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1867
1868 * image.c (prepare_image_for_display, clear_image_cache)
1869 (lookup_image): Port to higer-resolution time stamps.
1870
1871 * keyboard.c (start_polling, bind_polling_period):
1872 Check for time stamp overflow.
1873 (read_char, kbd_buffer_get_event, timer_start_idle)
1874 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1875 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1876 Port to higher-resolution time stamps. Do not assume time_t is signed.
1877 (decode_timer): New function. Timers are now vectors of length 9,
1878 not 8, to accommodate the picosecond component.
1879 (timer_check_2): Use it.
1880
1881 * nsterm.m (select_timeout, timeval_subtract): Remove.
1882 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1883 as they're a bit more accurate and handle overflow better.
1884 (ns_select): Change prototype to be compatible with pselect.
1885 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1886 * nsterm.h (ns_select): Adjust prototype.
1887
1888 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1889 us-resolution time stamps.
1890 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1891
1892 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1893
1894 * lisp.h (time_overflow): New decl.
1895 (wait_reading_process_output): First arg is now intmax_t, not int,
1896 to accommodate larger waits.
1897
1898 * process.h (struct Lisp_Process.read_output_delay):
1899 Now counts nanoseconds, not microseconds.
1900 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1901 EMACS_HAS_USECS.
1902 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1903 (wait_reading_process_output):
1904 Port to ns-resolution time stamps.
1905 (Faccept_process_output, wait_reading_process_output):
1906 Check for time stamp overflow. Do not assume time_t is signed.
1907 (select_wrapper): Remove; we now use pselect.
1908 (Fprocess_attributes): Now generates ns-resolution time stamps.
1909
1910 * sysdep.c: Include utimens.h. Don't include utime.h
1911 or worry about struct utimbuf; gnulib does that for us now.
1912 (gettimeofday): Remove; gnulib provides a substitute.
1913 (make_timeval): New function.
1914 (set_file_times): Now sets ns-resolution time stamps.
1915 New arg FD; all uses changed.
1916 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1917 (system_process_attributes):
1918 Now returns ns-resolution time stamp. All uses changed.
1919 Check for time stamp overflow.
1920
1921 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1922 provides a substitute now.
1923
1924 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1925 since it guarantees struct timespec.
1926 (EMACS_TIME): Now struct timespec, so that we can support
1927 ns-resolution time stamps.
1928 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1929 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1930 (EMACS_USECS): Remove.
1931 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1932 so multiply the arg by 1000 before storing it.
1933 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1934 New macros.
1935 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1936 Port to ns-resolution time stamps.
1937 (EMACS_TIME_NEG_P): Remove; replaced by....
1938 (EMACS_TIME_SIGN): New macro.
1939 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1940 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1941 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1942 (make_timeval, make_lisp_time, decode_time_components): New decls.
1943 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1944 that it mishandled time_t overflow. You can't compare by subtracting!
1945 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1946 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1947
1948 * term.c: Include <sys/time.h>.
1949 (timeval_to_Time): New function, for proper overflow wraparound.
1950 (term_mouse_position, term_mouse_click): Use it.
1951
1952 * undo.c (record_first_change): Support higher-resolution time stamps
1953 in the undo buffer.
1954 (Fprimitive_undo): Use them when restoring time stamps.
1955
1956 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1957 (w32_get_internal_run_time):
1958 Port to higher-resolution Emacs time stamps.
1959 (ltime): Now accepts single 64-bit integer, as that's more convenient
1960 for callers.
1961
1962 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1963
1964 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1965 for compatibility with pselect. Support ns-resolution time stamps.
1966
1967 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1968
1969 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1970 Check for time stamp overflow, and support ns-resolution time stamps.
1971
1972 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1973 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1974 (timeval_subtract): Remove; no longer needed.
1975 (XTflash, XTring_bell, x_wait_for_event):
1976 Port to ns-resolution time stamps. Don't assume time_t is signed.
1977
b6a92dfe
CY
19782012-06-22 Chong Yidong <cyd@gnu.org>
1979
1980 * xdisp.c (x_consider_frame_title): Revert last change.
1981
d251c37c
EZ
19822012-06-22 Eli Zaretskii <eliz@gnu.org>
1983
1984 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1985 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1986 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1987 staticidx goes up to 1597 out of 1600 = 0x640.)
1988
f10deafb
PE
19892012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1992 Otherwise, the umask might be mistakenly 0 while handling input signals.
1993
ec6de1e2
SM
19942012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1997
28be1ada
DA
19982012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1999
2000 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2001 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2002 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2003 access to `contents' member of Lisp_Vector objects with AREF and ASET
2004 where appropriate.
2005
c6bf3022
CY
20062012-06-19 Chong Yidong <cyd@gnu.org>
2007
2008 * frame.c (delete_frame): When selecting a frame on a different
2009 text terminal, do not alter the terminal's top-frame.
2010
2011 * xdisp.c (format_mode_line_unwind_data): Record the target
2012 frame's selected window and its terminal's top-frame.
2013 (unwind_format_mode_line): Restore them.
2014 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2015 Callers changed.
2016 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2017 since tty frames can be explicitly named.
2018 (prepare_menu_bars): Likewise.
2019
2020 * term.c (Ftty_top_frame): New function.
2021
defd4196
PE
20222012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 Port byte-code-meter to modern targets.
2025 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2026 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2027 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2028 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2029 (METER_1, METER_2): Simplify.
2030
1053a871
SM
20312012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2032
2033 * data.c (Fdefalias): Return `symbol' (bug#11686).
2034
b7e8d081
MR
20352012-06-18 Martin Rudalics <rudalics@gmx.at>
2036
2037 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2038 gets killed during executing of this function (Bug#11665).
2039 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2040 (Vkill_buffer_query_functions): In doc-string say that functions
2041 run by this hook should not change the current buffer.
2042
7ea2b339
PE
20432012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 Fix recently-introduced process.c problems found by static checking.
2046 * process.c (write_queue_push, write_queue_pop, send_process):
2047 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2048 (write_queue_pop): Fix pointer signedness problem.
2049 (send_process): Remove unused local.
2050
96a313a1
CY
20512012-06-17 Chong Yidong <cyd@gnu.org>
2052
2053 * xdisp.c (redisplay_internal): No need to redisplay terminal
2054 frames that are not on top.
2055
20ca2e94
TN
20562012-06-17 Troels Nielsen <bn.troels@gmail.com>
2057
2058 * process.c (make_process): Initialize write_queue.
2059 (write_queue_push, write_queue_pop): New functions.
2060 (send_process): Use them to maintain correct ordering of process
2061 writes (Bug#10815).
2062
9a900ca9
PE
20632012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2064
310fbfa8
PE
2065 * lisp.h (eassert): Assume C89 or later.
2066 This removes the need for CHECK.
2067 (CHECK): Remove. Its comments about always evaluating its
2068 argument were confusing, as 'eassert' typically does not evaluate
2069 its argument.
2070
27bb1ca4
PE
2071 * coding.c (produce_chars): Use ptrdiff_t, not int.
2072
9a900ca9
PE
2073 * xterm.c (x_draw_underwave): Check for integer overflow.
2074 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2075
41b7f8bc 20762012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2077
2078 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2079 referenced (Bug#11583).
2080
9b0e3eba
AA
20812012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2082
2083 Implement wave-style variant of underlining.
2084 * dispextern.h (face_underline_type): New enum.
2085 (face): Add field for underline type.
2086 * nsterm.m (ns_draw_underwave): New function.
2087 (ns_draw_text_decoration): Use it.
2088 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2089 New functions.
2090 (x_draw_glyph_string): Use them.
2091 * xfaces.c (Qline, Qwave): New Lisp objects.
2092 (check_lface_attrs, merge_face_ref)
1053a871
SM
2093 (Finternal_set_lisp_face_attribute, realize_x_face):
2094 Handle wave-style underline face attributes.
9b0e3eba
AA
2095 * xterm.c (x_draw_underwave): New function.
2096 (x_draw_glyph_string): Use it.
2097
0fb52f11
JB
20982012-06-16 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2101 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2102 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2103 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2104 ($(BLD)/w32select.$(O)): Update dependencies.
2105
e5560ff7
AS
21062012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2107
2108 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2109 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2110 * character.c (_fetch_multibyte_char_p): Remove.
2111 * alloc.c: Include "character.h" before "buffer.h".
2112 * bidi.c: Likewise.
2113 * buffer.c: Likewise.
2114 * bytecode.c: Likewise.
2115 * callint.c: Likewise.
2116 * callproc.c: Likewise.
2117 * casefiddle.c: Likewise.
2118 * casetab.c: Likewise.
2119 * category.c: Likewise.
2120 * cmds.c: Likewise.
2121 * coding.c: Likewise.
2122 * composite.c: Likewise.
2123 * dired.c: Likewise.
2124 * dispnew.c: Likewise.
2125 * doc.c: Likewise.
2126 * dosfns.c: Likewise.
2127 * editfns.c: Likewise.
2128 * emacs.c: Likewise.
2129 * fileio.c: Likewise.
2130 * filelock.c: Likewise.
2131 * font.c: Likewise.
2132 * fontset.c: Likewise.
2133 * fringe.c: Likewise.
2134 * indent.c: Likewise.
2135 * insdel.c: Likewise.
2136 * intervals.c: Likewise.
2137 * keyboard.c: Likewise.
2138 * keymap.c: Likewise.
2139 * lread.c: Likewise.
2140 * macros.c: Likewise.
2141 * marker.c: Likewise.
2142 * minibuf.c: Likewise.
2143 * nsfns.m: Likewise.
2144 * nsmenu.m: Likewise.
2145 * print.c: Likewise.
2146 * process.c: Likewise.
2147 * regex.c: Likewise.
2148 * region-cache.c: Likewise.
2149 * search.c: Likewise.
2150 * syntax.c: Likewise.
2151 * term.c: Likewise.
2152 * textprop.c: Likewise.
2153 * undo.c: Likewise.
2154 * unexsol.c: Likewise.
2155 * w16select.c: Likewise.
2156 * w32fns.c: Likewise.
2157 * w32menu.c: Likewise.
2158 * window.c: Likewise.
2159 * xdisp.c: Likewise.
2160 * xfns.c: Likewise.
2161 * xmenu.c: Likewise.
2162 * xml.c: Likewise.
2163 * xselect.c: Likewise.
2164
2f07e6af
EZ
21652012-06-16 Eli Zaretskii <eliz@gnu.org>
2166
1053a871
SM
2167 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2168 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2169 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2170 row.
2171 (handle_face_prop): Use chunk-relative overlay string index when
2172 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2173 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2174 the rightmost. (Bug#11720)
2f07e6af 2175
29b83cec
AS
21762012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2177
2178 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2179 (CATEGORY_MEMBER): Enforce 1/0 value.
2180 * category.c (_temp_category_set): Remove.
2181
4c5501e9
EZ
21822012-06-16 Eli Zaretskii <eliz@gnu.org>
2183
2184 * window.c (Fdelete_other_windows_internal)
2185 (Fdelete_window_internal): Don't access frame's mouse highlight
2186 info of the initial frame. (Bug#11677)
2187
2b570124
PE
21882012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2189
e93864f9
PE
2190 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2191 Assume USE_2_TAGS_FOR_INTS.
2192 (xreload): Adjust $tagmask width to match recent lisp.h change.
2193
2b570124
PE
2194 Simplify lisp.h in minor ways that should not affect code.
2195 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2196 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2197 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2198 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2199 (INTTYPEBITS): New macro, for clarity.
2200 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2201 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2202 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2203 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2204 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2205
81755f69
JB
22062012-06-13 Juanma Barranquero <lekktu@gmail.com>
2207
2208 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2209
16192a57
GM
22102012-06-13 Glenn Morris <rgm@gnu.org>
2211
2212 * s/bsd-common.h (BSD4_3):
2213 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2214
646b5f55
AS
22152012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2216
2217 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2218 instead of union.
2219 (XLI, XIL): Define.
1053a871
SM
2220 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2221 Use them.
2222 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2223 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2224 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2225 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2226 * frame.c (delete_frame): Remove outdated comment.
2227 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2228 USE_LISP_UNION_TYPE.
2229 (Fw32_unregister_hot_key): Likewise.
2230 (Fw32_toggle_lock_key): Likewise.
2231 * w32menu.c (add_menu_item): Likewise.
2232 (w32_menu_display_help): Use XIL instead of checking
2233 USE_LISP_UNION_TYPE.
2234 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2235 (init_heap): Likewise.
2236 * w32term.c (w32_read_socket): Update comment.
2237
1d3823c9
GM
22382012-06-13 Glenn Morris <rgm@gnu.org>
2239
c62ff706
GM
2240 * s/usg5-4-common.h, src/s/unixware.h:
2241 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2242
1d3823c9
GM
2243 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2244
bfe3e0a2
PE
22452012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2248 * alloc.c (make_number) [!defined make_number]:
2249 Remove, as lisp.h always defines this now.
2250 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2251 (roundup_size): Verify that it is a power of 2.
2252 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2253 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2254 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2255 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2256 USE_LSB_TAG now is always defined to be either 0 or 1.
2257 All uses changed.
2258 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2259 code works fine either way, and efficiency is not a concern here,
2260 as the union type is for debugging, not for production.
2261 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2262 Use an inline function on all platforms when using the union type,
2263 since this is simpler and 'static inline' can be used portably
2264 within Emacs now.
2265 (LISP_INITIALLY_ZERO): New macro.
2266 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2267 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2268
45fa9c0f
GM
22692012-06-12 Glenn Morris <rgm@gnu.org>
2270
b4492cba
GM
2271 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2272
2273 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2274
45fa9c0f
GM
2275 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2276 Move BROKEN_SIGIO to configure.
2277
2278 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2279 Move NO_TERMIO to configure.
2280
0e25d334
CY
22812012-06-12 Chong Yidong <cyd@gnu.org>
2282
2283 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2284 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2285 MagickExportImagePixels is undefined.
2286
43682bb6
PE
22872012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2288
2289 * image.c (imagemagick_load_image): Remove unused label.
2290
a9be7d2b
GM
22912012-06-11 Glenn Morris <rgm@gnu.org>
2292
2293 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2294 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2295 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2296 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2297
3017f87f
SM
22982012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2299
2300 * alloc.c (make_byte_code): New function.
2301 (Fmake_byte_code): Use it. Don't purify here.
2302 * lread.c (read1): Use it as well to avoid extra allocation.
2303
1b9b4cf4
CY
23042012-06-11 Chong Yidong <cyd@gnu.org>
2305
2306 * image.c (imagemagick_load_image): Implement transparency.
2307
95988fcf
AS
23082012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2309
2310 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2311 account for preceding backslashes. (Bug#11663)
2312
cd4eb164
CY
23132012-06-09 Chong Yidong <cyd@gnu.org>
2314
2315 * term.c: Support italics in capable terminals (Bug#9652).
2316 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2317 (turn_on_face): Output using TS_enter_italic_mode if available.
2318 Don't handle unused blinking and alt-charset cases.
2319 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2320 and tty_alt_charset_p cases.
2321 (tty_capable_p, init_tty): Support italics.
2322
2323 * termchar.h (struct tty_display_info): Add field for italics.
2324 Remove unused blink field.
2325
2326 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2327 Handle slant.
2328
2329 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2330 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2331 tty_alt_charset_p. Add tty_italic_p.
2332
ff88beb8
MA
23332012-06-09 Michael Albinus <michael.albinus@gmx.de>
2334
2335 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2336 dbus_type_is_basic if available.
2337 (xd_extract_signed, xd_extract_unsigned): Rename from
2338 extract_signed and extract_unsigned, respectively. Adapt callers.
2339
44286096
CY
23402012-06-09 Chong Yidong <cyd@gnu.org>
2341
1682701f
CY
2342 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2343
44286096
CY
2344 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2345 case (Bug#9752).
2346
d86feb17
PE
23472012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * xdisp.c (vmessage): Treat frame message as multibyte.
2350 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2351 would generate the diagnostic "Making \302\247 buffer-local while
2352 let-bound!".
2353
d5c20fe8
EZ
23542012-06-08 Eli Zaretskii <eliz@gnu.org>
2355
2356 * dispnew.c (showing_window_margins_p): Undo last change, which
2357 was done due to an inadvertent commit.
2358 (adjust_frame_glyphs_for_frame_redisplay): Do call
2359 showing_window_margins_p.
2360
513749ee
SM
23612012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2362
2363 * eval.c (Fmake_var_non_special): New primitive.
2364 (syms_of_eval): Defsubr it.
2365 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2366
d4a8f5c1
JB
23672012-06-08 Juanma Barranquero <lekktu@gmail.com>
2368
2369 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2370 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2371
8bbbc977
EZ
23722012-06-08 Eli Zaretskii <eliz@gnu.org>
2373
2374 * alloc.c (allocate_vectorlike): Fix last change.
2375
f3372c87
DA
23762012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2377
2378 Block-based vector allocation of small vectors.
2379 * lisp.h (struct vectorlike_header): New field `nbytes',
2380 adjust comment accordingly.
2381 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2382 to denote vector blocks. Adjust users (live_vector_p,
2383 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2384 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2385 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2386 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2387 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2388 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2389 (roundup_size): New constant.
2390 (struct vector_block): New data type.
2391 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2392 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2393 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2394 (sweep_vectors): New functions.
2395 (allocate_vectorlike): Return `zero_vector' as the only vector of
2396 0 items. Allocate new vector from block if vector size is less than
2397 or equal to VBLOCK_BYTES_MAX.
2398 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2399 (init_alloc_once): Add call to init_vectors.
2400
4f18a4ed
SM
24012012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2402
2403 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2404
86f158bc
PE
24052012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2406
2407 * doprnt.c (doprnt): Truncate multibyte char correctly.
2408 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2409 would mishandle a string argument "Xc" if X was a multibyte
2410 character of length 2: it would truncate after X's first byte
2411 rather than including all of X.
2412
c5cfcbe0
CY
24132012-06-06 Chong Yidong <cyd@gnu.org>
2414
2415 * buffer.c (word_wrap): Doc fix.
2416
c05cf390
PE
24172012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2420
0c3461de
GM
24212012-06-03 Glenn Morris <rgm@gnu.org>
2422
2423 * xdisp.c (tool-bar-style): Doc fix.
2424
c71232db
UM
24252012-06-03 Ulrich Müller <ulm@gentoo.org>
2426
2427 * Makefile.in (PAXCTL): Define.
2428 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2429 binary via PaX flags if the paxctl utility is available.
2430 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2431 Restore PaX flags to their default. (Bug#11398)
2432
383f7350
CY
24332012-06-03 Chong Yidong <cyd@gnu.org>
2434
2435 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2436 buffer (Bug#11226).
2437
5f2c76c6
CY
24382012-06-03 Chong Yidong <cyd@gnu.org>
2439
2440 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2441 (note_mode_line_or_margin_highlight): If there is no help echo,
2442 use mode-line-default-help-echo. Handle the case where the mouse
2443 position is past the end of the mode line string.
2444
2445 * buffer.c (buffer_local_value_1): New function, split from
2446 Fbuffer_local_value; can return Qunbound.
2447 (Fbuffer_local_value): Use it.
2448 (Vmode_line_format): Docstring tweaks.
2449
773d47f6
PE
24502012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * sysdep.c (system_process_attributes): Improve comment.
2453
f2d6a3df
SM
24542012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2455
2456 * keyboard.c: Export real-this-command to Elisp.
2457 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2458 and DEFVAR it. Update all users.
2459
63810350
PE
24602012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2461
7bd5c1f4
PE
2462 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2463
63810350
PE
2464 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2465 Convert pctcpu and pctmem to Lisp float properly.
2466 Let the compiler fold better, as 100.0/0x8000 is exact.
2467
a2821611
AS
24682012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2469
2470 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2471 cons_block.
2472
5fceba1d
PE
24732012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2476
c98ff5dd
DA
24772012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2478
2479 For a 'struct window', replace some Lisp_Object fields to
2480 bitfields where appropriate, remove unused fields.
2481 * window.h (struct window): Remove unused 'last_mark_x' and
2482 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2483 change it's type from Lisp_Object to bitfield.
2484 Change type of 'force_start', 'optional_new_start',
2485 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2486 fields from Lisp_Object to bitfield. Adjust users accordingly.
2487
ca34e0be
PE
24882012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 Pacify gcc -Wdouble-precision when using Xaw.
2491 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2492 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2493 Use 'float' consistently, rather than 'float' in most places
2494 and 'double' in a couple of places.
2495
efc00ab1 24962012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2497
2498 * xdisp.c (handle_stop): Detect whether we have overlay strings
2499 loaded by testing it->current.overlay_string_index to be
2500 non-negative, instead of checking whether n_overlay_strings is
2501 positive. (Bug#11587)
2502
efc00ab1 25032012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2504
2505 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2506
2507 * doc.c (Fsubstitute_command_keys): Doc fix.
2508
efc00ab1 25092012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2510
2511 * search.c (search_buffer): Remove calls to
2512 r_alloc_inhibit_buffer_relocation, as it is now called by
2513 maybe_unify_char, which was the cause of relocation of buffer text
2514 in bug#11519.
2515
efc00ab1 25162012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2517
2518 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2519 for the duration of call to load_charset, to avoid problems with
2520 callers of maybe_unify_char that access buffer text through C
2521 pointers.
2522
2523 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2524 decrement the inhibition flag, instead of just setting or
2525 resetting it.
2526
ba93a187
PE
25272012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2528
2529 Remove obsolete '#define static' cruft.
2530 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2531 This #undef was "temporary" in 2000; it is no longer needed
2532 now that '#define static' has gone away.
2533 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2534 (gray_bitmap_bits): Remove; no longer needed.
2535 All uses replaced with definiens.
2536 * xterm.c: Include "bitmaps/gray.xbm".
2537
9e4bf381
PE
25382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2539
2540 Clean up __executable_start, monstartup when --enable-profiling.
2541 The following changes affect the code only when profiling.
2542 * dispnew.c (__executable_start): Rename from safe_bcopy.
2543 Define only on platforms that need it.
2544 * emacs.c: Include <sys/gmon.h> when profiling.
2545 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2546 (__executable_start): Remove decl, since lisp.h does it now.
2547 (safe_bcopy): Remove decl; no longer has that name.
2548 (main): Coalesce #if into single bit of code, for simplicity.
2549 Cast pointers to uintptr_t, since standard libraries want integers
2550 and not pointers.
2551 * lisp.h (__executable_start): New decl.
2552
32d72c2f
GM
25532012-05-31 Glenn Morris <rgm@gnu.org>
2554
2555 * image.c (Fimagemagick_types): Doc fix.
2556
baac5bc7
JM
25572012-05-30 Jim Meyering <meyering@redhat.com>
2558
2559 * callproc.c (Fcall_process_region): Include directory component
2560 in mkstemp error message (Bug#11586).
2561
72cb32cf
PE
25622012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * alloc.c, lisp.h (make_pure_vector): Now static.
2565
61b108cc
SM
25662012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2567
2568 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2569 Move to byte-run.el.
2570 (Fautoload): Do the hash-doc more carefully.
2571 * data.c (Fdefalias): Purify definition, except for keymaps.
2572 (Qdefun): Move from eval.c.
2573 * lisp.h (Qdefun): Remove.
2574 * lread.c (read1): Tiny simplification.
2575
471fe23d
TN
25762012-05-29 Troels Nielsen <bn.troels@gmail.com>
2577
934f3f58 2578 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2579 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2580 Bug#9642, but explicitly check that the buffer the overlay would
2581 be moved to is live and rearrange lines to make sure that errors
2582 will not put the overlay in an inconsistent state.
2583 (Fdelete_overlay): Cosmetics.
2584
85d0efd1
EZ
25852012-05-28 Eli Zaretskii <eliz@gnu.org>
2586
2587 * w32term.c (my_bring_window_to_top): New function.
2588 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2589 could be different from the original one.
2590 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2591 (Bug#11513)
2592
2593 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2594 by calling BringWindowToTop.
2595
2596 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2597 (WM_EMACS_END): Increase by one.
2598
da92a98c
PE
25992012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2600
2601 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2602 This avoids undefined behavior that might cause the eassert
2603 to not catch an out-of-range value.
2604
74d1f848
JB
26052012-05-28 Juanma Barranquero <lekktu@gmail.com>
2606
2607 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2608 Update dependencies.
2609
9e1a06fc
EZ
26102012-05-27 Eli Zaretskii <eliz@gnu.org>
2611
2612 * bidi.c (bidi_mirror_char): Fix last change.
2613
f3dd7312
AS
26142012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2615
2616 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2617 when referring to sectname field in printf format.
2618
81899c91
PE
26192012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2620
57b81a9f
PE
2621 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2622 Only r_alloc_inhibit_buffer_relocation needed to be added;
2623 the others were already declared.
2624
81899c91
PE
2625 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2626 before checking whether it's out of range. Put the check inside
2627 eassert. See
2628 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2629
33017faf 26302012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2631
2632 * callproc.c (Fcall_process): Restore a line that was accidentally
2633 commented out in the 2011-02-13 change (bug#11547).
2634
33017faf 26352012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2636
2637 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2638 defined on ralloc.c.
2639
2640 * buffer.c [REL_ALLOC]: Remove prototypes of
2641 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2642 they are now on lisp.h.
2643
2644 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2645
2646 * search.c (search_buffer): Use it to inhibit relocation of buffer
2647 text while re_search_2 is doing its job, because re_search_2 is
2648 passed C pointers to buffer text. (Bug#11519)
2649
23415acf
EZ
2650 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2651 Update value to 24.
2652
44e27368
EZ
2653 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2654 state after an additional call to move_it_in_display_line_to, keep
2655 the values of it->max_ascent and it->max_descent found for the
2656 entire line.
2657 (pos_visible_p): Revert the comparison against bottom_y to what it
2658 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2659 (Bug#11464)
2660
c1892f11
PE
26612012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2662
2663 Fix coding-related core dumps with gcc -ftrapv.
2664 The code was computing A - B, where A and B are pointers, and B is
2665 random garbage. This can lead to core dumps on platforms that
2666 have special pointer registers, and it also leads to core dumps on
2667 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2668 A - B only when B is initialized properly.
2669 * coding.c (coding_set_source, coding_set_destination): Return void.
2670 (coding_change_source, coding_change_destinations): New functions,
2671 with the old behaviors of coding_set_source and coding_set_destination.
2672 All callers that need an offset changed to use these new functions.
2673
eb7afdad
GM
26742012-05-26 Glenn Morris <rgm@gnu.org>
2675
2676 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2677
f12fdf02
EZ
26782012-05-26 Eli Zaretskii <eliz@gnu.org>
2679
53a63be6 2680 Extend mouse support on W32 text-mode console.
61b108cc
SM
2681 * xdisp.c (draw_row_with_mouse_face):
2682 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2683
eb3f6f01 2684 * w32console.c: Include window.h.
61b108cc
SM
2685 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2686 New functions.
eb3f6f01
EZ
2687 (initialize_w32_display): Initialize mouse-highlight data.
2688
53a63be6
EZ
2689 * w32inevt.c: Include termchar.h and window.h.
2690 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2691 moves, call note_mouse_highlight. If help_echo changed, call
2692 gen_help_event to produce help-echo message in the echo area.
2693 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2694 highlight info.
2695
4cfd81f6
PE
26962012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * lread.c (read1): Simplify slightly to avoid an overflow warning
2699 with GCC 4.7.0 on x86-64.
2700
4446092a
EZ
27012012-05-26 Eli Zaretskii <eliz@gnu.org>
2702
2703 * bidi.c (bidi_mirror_char): Revert last change: an int is
2704 definitely wide enough here.
2705
42b2a986 27062012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2707
42b2a986 2708 Fix integer width and related bugs (Bug#9874).
eb106a49 2709 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2710 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2711 (string_bytes, check_sblock, allocate_string_data):
2712 (compact_small_strings, Fmake_bool_vector, make_string)
2713 (make_unibyte_string, make_multibyte_string)
2714 (make_string_from_bytes, make_specified_string)
2715 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2716 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2717 (mark_vectorlike):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 (allocate_pseudovector):
2720 Use int, not EMACS_INT, where int is wide enough.
2721 (inhibit_garbage_collection, Fgarbage_collect):
2722 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2723 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2724 int might not be wide enough.
2725 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2726 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2727 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2728 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2729 (bidi_level_of_next_char, bidi_move_to_visually_next):
2730 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2731 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2732 (Fkill_buffer, Fset_buffer_major_mode)
2733 (advance_to_char_boundary, Fbuffer_swap_text)
2734 (Fset_buffer_multibyte, overlays_at, overlays_in)
2735 (overlay_touches_p, struct sortvec, record_overlay_string)
2736 (overlay_strings, recenter_overlay_lists)
2737 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2738 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2739 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2740 (Foverlay_recenter, last_overlay_modification_hooks_used)
2741 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2742 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2743 (validate_region): Omit unnecessary test for b <= e,
2744 since that's guaranteed by the previous test.
d311d28c
PE
2745 (adjust_overlays_for_delete): Avoid pos + length overflow.
2746 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2747 (report_overlay_modification):
2748 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2749 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2750 Omit pointer cast, which isn't needed anyway, and doesn't work
2751 after the EMACS_INT -> ptrdiff_t change.
02481186 2752 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2753 * buffer.h: Adjust decls to match defn changes elsewhere.
2754 (struct buffer_text, struct buffer):
2755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2756 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2757 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2758 not int, to avoid needless 32-bit limit on 64-bit hosts.
2759 (exec_byte_code): Use tighter memory-full test, one that checks
2760 for alloca overflow. Don't compute the address of the object just
2761 before an array, as that's not portable. Use EMACS_INT, not
2762 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2763 * callint.c (Fcall_interactively):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 * callproc.c (call_process_kill, Fcall_process):
2766 Don't assume pid_t fits into an Emacs fixnum.
2767 (call_process_cleanup, Fcall_process, child_setup):
2768 Don't assume pid_t fits into int.
2769 (call_process_cleanup, Fcall_process, delete_temp_file)
2770 (Fcall_process_region):
2771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2772 (Fcall_process): Simplify handling of volatile integers.
2773 Use int, not EMACS_INT, where int will do.
2774 * casefiddle.c (casify_object, casify_region, operate_on_word)
2775 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2777 (casify_object): Avoid integer overflow when overallocating buffer.
2778 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2779 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2780 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2781 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2782 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2783 integers are now checked earlier. All uses replaced with XINT.
2784 (ccl_driver):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2787 (ccl_driver, Fregister_code_conversion_map):
2788 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2789 (resolve_symbol_ccl_program): Check that vector header is in range.
2790 Always copy the vector, so that we can check its contents reliably
2791 now rather than having to recheck each instruction as it's being
2792 executed. Check that vector words fit in 'int'.
2793 (ccl_get_compiled_code, Fregister_ccl_program)
2794 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2795 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2796 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2797 contents are in range.
2798 (Fccl_execute_on_string): Check that status is in range.
2799 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2800 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2801 Accept and return EMACS_INT, not int, because callers can pass values
2802 out of 'int' range.
2803 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2804 (multibyte_chars_in_text, parse_str_as_multibyte)
2805 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2806 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2807 (string_escape_byte8, Fget_byte):
2808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2809 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2810 avoid mishandling large integers.
2811 * character.h: Adjust decls to match defn changes elsewhere.
2812 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2813 (Ffind_charset_region):
2814 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2815 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2816 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2817 Don't assume fixnum fits in int.
d311d28c
PE
2818 (load_charset_map_from_vector, Fmap_charset_chars):
2819 Remove now-unnecessary CHECK_NATNUMs.
2820 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2821 Don't rely on undefined behavior with signed left shift overflow.
2822 Don't assume unsigned int fits into fixnum, or that fixnum fits
2823 into unsigned int. Don't require max_code to be a valid fixnum;
2824 that's not true for gb10830 4-byte on a 32-bit host. Allow
2825 invalid_code to be a cons, for the same reason. Require code_offset
2826 to be a character. Avoid int overflow if max_char is close
2827 to INT_MAX.
2828 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2829 this is intended anyway and avoids some undefined behavior.
2830 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2831 INDEX_TO_CODE_POINT, as that's what it expects.
2832 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2833 * charset.h (DECODE_CHAR): Return int, not unsigned;
2834 this is what was intended anyway, and it avoids undefined behavior.
2835 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2836 integer-overflow issues.
2837 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2838 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2839 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2840 * chartab.c (Fmake_char_table, Fset_char_table_range)
2841 (uniprop_get_decoder, uniprop_get_encoder):
2842 Don't assume fixnum fits in int.
2843 * cmds.c (move_point): New function, that does the gist of
2844 Fforward_char and Fbackward_char, but does so while checking
2845 for integer overflow more accurately.
c96e5d6a 2846 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2847 (Fforward_line, Fend_of_line, internal_self_insert)
2848 (internal_self_insert):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 Fix a FIXME, by checking for integer overflow when calculating
2851 target_clm and actual_clm.
2852 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2853 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2854 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2855 (coding_alloc_by_making_gap, alloc_destination)
2856 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2857 (encode_coding_utf_16, detect_coding_emacs_mule)
2858 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2859 (detect_coding_iso_2022, decode_coding_iso_2022)
2860 (encode_invocation_designation, encode_designation_at_bol)
2861 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2862 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2863 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2864 (encode_coding_ccl, encode_coding_raw_text)
2865 (detect_coding_charset, decode_coding_charset)
2866 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2867 (produce_composition, produce_charset, produce_annotation)
2868 (decode_coding, handle_composition_annotation)
2869 (handle_charset_annotation, consume_chars, decode_coding_gap)
2870 (decode_coding_object, encode_coding_object, detect_coding_system)
2871 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2872 (code_convert_region, code_convert_string)
8f50130c
PE
2873 (Fdefine_coding_system_internal)
2874 (coding_set_source, coding_set_destination):
d311d28c
PE
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2877 (Fdefine_coding_system_internal):
2878 Don't assume fixnums fit in int.
2879 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2880 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2881 (Funencodable_char_position, Fcheck_coding_systems_region)
2882 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2884 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2885 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2886 Don't access memory outside of the args array.
d311d28c 2887 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2888 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2889 result of ENCODE_CHAR.
d311d28c
PE
2890 * coding.h: Adjust decls to match defn changes elsewhere.
2891 (struct coding_system):
2892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2893 * composite.c (get_composition_id, find_composition)
2894 (run_composition_function, update_compositions)
2895 (compose_text, composition_gstring_put_cache)
2896 (composition_gstring_p, composition_gstring_width)
2897 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2898 (composition_compute_stop_pos, composition_reseat_it)
2899 (composition_update_it, struct position_record)
2900 (find_automatic_composition, composition_adjust_point)
2901 (Fcomposition_get_gstring, Ffind_composition_internal):
2902 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2903 (update_compositions):
2904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 * composite.h: Adjust decls to match defn changes elsewhere.
2906 (struct composition):
2907 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2908 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2909 Do not attempt to compute the address of the object just before a
2910 buffer; this is not portable.
2911 (Faref, Faset):
2912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2913 (Faset): Use int, not EMACS_INT, where int is wide enough.
2914 (Fstring_to_number): Don't assume fixnums fit in int.
2915 (Frem): Don't assume arg is nonnegative.
2916 * dbusbind.c (xd_append_arg): Check for integers out of range.
2917 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2918 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2919 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2920 (xd_get_connection_references): Return ptrdiff_t, not int.
2921 All uses changed.
2922 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2923 (xd_read_message_1):
2924 Use int, not unsigned, where the dbus API uses int.
2925 (Fdbus_message_internal): Don't overflow mtype.
2926 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2927 * dired.c (directory_files_internal, file_name_completion, scmp)
2928 (file_name_completion_stat):
2929 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2930 (file_name_completion): Don't overflow matchcount.
2931 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2932 * dispextern.h: Adjust decls to match defn changes elsewhere.
2933 (struct text_pos, struct glyph, struct bidi_saved_info)
2934 (struct bidi_string_data, struct bidi_it, struct composition_it)
2935 (struct it):
2936 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2937 (struct display_pos, struct composition_it, struct it):
2938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2939 * dispnew.c (increment_matrix_positions)
2940 (increment_row_positions, mode_line_string)
2941 (marginal_area_string):
2942 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2943 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2944 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2945 (duration_to_sec_usec): New function, to check for overflow better.
2946 (Fsleep_for, sit_for): Use it.
2947 * doc.c (get_doc_string, store_function_docstring):
2948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2949 (get_doc_string, Fsnarf_documentation):
2950 Use int, not EMACS_INT, where int is wide enough.
2951 (get_doc_string):
2952 Use SAFE_ALLOCA, not alloca.
2953 Check for overflow when converting EMACS_INT to off_t.
2954 * doprnt.c (doprnt):
2955 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2956 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2957 Don't assume uid_t fits into fixnum.
2958 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2959 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2960 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2961 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2962 (general_insert_function)
2963 (Finsert_char, make_buffer_string, make_buffer_string_both)
2964 (update_buffer_properties, Fbuffer_substring)
2965 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2966 (Fsubst_char_in_region, check_translation)
2967 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2968 (transpose_markers, Ftranspose_regions):
2969 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2970 (clip_to_bounds): Move to lisp.h as an inline function).
2971 (Fconstrain_to_field): Don't assume integers are nonnegative.
2972 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2973 (Fsubst_char_in_region, Fsave_restriction):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 (Femacs_pid): Don't assume pid_t fits into fixnum.
2976 (lo_time): Use int, not EMACS_INT, when int suffices.
2977 (lisp_time_argument): Check for usec out of range.
2978 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2979 (Fuser_login_name, Fuser_full_name): Signal an error
2980 if a uid argument is out of range, rather than relying on
2981 undefined behavior.
c8d5c857
PE
2982 (Fformat_time_string): Remove now-unnecessary check.
2983 lisp_time_argument checks for out-of-range usec now.
243e0530 2984 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2985 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2986 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2987 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2988 (init_cmdargs, Fdump_emacs):
2989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2990 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2991 the bottom (typically) 32 bits of the fixnum.
2992 * eval.c (specpdl_size, call_debugger):
2993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2994 (when_entered_debugger, Fbacktrace_debug):
2995 Don't assume fixnum can fit in int.
2996 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2997 the object just before a buffer; this is not portable.
2998 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2999 (grow_specpdl, unbind_to):
3000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3001 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3002 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3003 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3004 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3005 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3007 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3008 (a_write, e_write):
3009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3010 (Fcopy_file, non_regular_nbytes, read_non_regular)
3011 (Finsert_file_contents):
3012 Use int, not EMACS_INT, where int is wide enough.
3013 (READ_BUF_SIZE): Verify that it fits in int.
3014 (Finsert_file_contents): Check that counts are in proper range,
3015 rather than assuming fixnums fit into ptrdiff_t etc.
3016 Don't assume fixnums fit into int.
125b3835 3017 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3018 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3019 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3020 (string_char_to_byte, string_byte_to_char)
3021 (string_make_multibyte, string_to_multibyte)
3022 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3023 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3024 (substring_both, Fdelete, internal_equal, Ffillarray)
3025 (Fclear_string, mapcar1)
3026 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3027 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3028 (larger_vector, make_hash_table, maybe_resize_hash_table)
3029 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3030 (Fmaphash, secure_hash):
3031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3032 (concat): Check for string index and length overflow.
3033 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3034 (Frequire):
3035 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3036 (larger_vector): New API (vec, incr_min, size_max) replaces old
3037 one (vec, new_size, init). This catches size overflow.
3038 INIT was removed because it was always Qnil.
3039 All callers changed.
3040 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3041 the upper bound on a hash table index size.
3042 (make_hash_table, maybe_resize_hash_table): Use it.
3043 (secure_hash): Computer start_byte and end_byte only after
3044 they're known to be in ptrdiff_t range.
3045 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3046 (Ffont_get_glyphs, Ffont_at):
3047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3048 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3049 (Flist_fonts, Fopen_font):
3050 Don't assume fixnum can fit in int.
3051 (check_gstring): Don't assume index can fit in int.
3052 (font_match_p): Check that fixnum is a character, not a nonnegative
3053 fixnum, since the later code needs to stuff it into an int.
3054 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3055 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3056 conversion overflow issues.
3057 (Fopen_font): Check for integer out of range.
3058 (Ffont_get_glyphs): Don't assume index can fit in int.
3059 * font.h: Adjust decls to match defn changes elsewhere.
3060 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3061 integer overflow.
3062 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3063 printmax_t, where ptrdiff_t is wide enough.
3064 (Finternal_char_font):
3065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3066 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3067 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3068 (Fset_frame_position, x_set_frame_parameters)
3069 (x_set_line_spacing, x_set_border_width)
3070 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3071 Check that fixnums are in proper range for system types.
3072 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3074 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3075 Use SAFE_ALLOCA_LISP, not alloca.
3076 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3077 intptr_t is wide enough.
3078 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3079 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3080 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3081 Check for fixnum out of range.
3082 * ftfont.c (ftfont_list): Don't assume index fits in int.
3083 Check that fixnums are in proper range for system types.
3084 (ftfont_shape_by_flt):
3085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3086 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3088 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3089 Check that fixnums are in proper range for system types.
3090 * gnutls.h: Adjust decls to match defn changes elsewhere.
3091 * gtkutil.c (xg_dialog_run):
3092 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3093 (update_frame_tool_bar):
3094 Check that fixnums are in proper range for system types.
3095 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3096 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3097 * indent.c (last_known_column, last_known_column_point):
3098 (current_column_bol_cache):
3099 (skip_invisible, current_column, check_display_width):
3100 (check_display_width, scan_for_column, current_column_1)
3101 (Findent_to, Fcurrent_indentation, position_indentation)
3102 (indented_beyond_p, Fmove_to_column, compute_motion):
3103 (Fcompute_motion, Fvertical_motion):
3104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3105 (last_known_column_modified): Use EMACS_INT, not int.
3106 (check_display_width):
3107 (Fcompute_motion):
3108 Check that fixnums and floats are in proper range for system types.
3109 (compute_motion): Don't assume index or fixnum fits in int.
3110 (compute_motion, Fcompute_motion):
3111 Use int, not EMACS_INT, when it is wide enough.
3112 (vmotion): Omit local var start_hpos that is always 0; that way
3113 we don't need to worry about overflow in expressions involving it.
3114 * indent.h: Adjust decls to match defn changes elsewhere.
3115 (struct position):
3116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3117 Use int, not EMACS_INT, where int is wide enough.
3118 Remove unused members ovstring_chars_done and tab_offset;
3119 all uses removed.
3120 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3121 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3122 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3123 (make_gap, copy_text, insert, insert_and_inherit)
3124 (insert_before_markers, insert_before_markers_and_inherit)
3125 (insert_1, count_combining_before, count_combining_after)
3126 (insert_1_both, insert_from_string)
3127 (insert_from_string_before_markers, insert_from_string_1)
3128 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3129 (adjust_after_replace, adjust_after_insert, replace_range)
3130 (replace_range_2, del_range, del_range_1, del_range_byte)
3131 (del_range_both, del_range_2, modify_region)
3132 (prepare_to_modify_buffer, signal_before_change)
3133 (signal_after_change, Fcombine_after_change_execute):
3134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3135 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3136 (balance_an_interval, split_interval_right, split_interval_left)
3137 (find_interval, next_interval, update_interval)
3138 (adjust_intervals_for_insertion, delete_node, delete_interval)
3139 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3140 (static_offset_intervals, offset_intervals)
3141 (merge_interval_right, merge_interval_left, make_new_interval)
3142 (graft_intervals_into_buffer, temp_set_point_both)
3143 (temp_set_point, set_point, adjust_for_invis_intang)
3144 (set_point_both, move_if_not_intangible, get_property_and_range)
3145 (get_local_map, copy_intervals, copy_intervals_to_string)
3146 (compare_string_intervals, set_intervals_multibyte_1):
3147 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3148 * intervals.h: Adjust decls to match defn changes elsewhere.
3149 (struct interval):
3150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3151 * keyboard.c (this_command_key_count, this_single_command_key_start)
3152 (before_command_key_count, before_command_echo_length, echo_now)
3153 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3154 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3155 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3156 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3157 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3158 (last_non_minibuf_size, last_point_position, echo_truncate)
3159 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3160 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3161 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3162 (stuff_buffered_input):
3163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3164 (last_auto_save, command_loop_1, read_char):
3165 Use EMACS_INT, not int, to avoid integer overflow.
3166 (record_char): Avoid overflow in total_keys computation.
3167 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3168 * keyboard.h: Adjust decls to match defn changes elsewhere.
3169 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3170 (Fkey_description, Fdescribe_vector, Flookup_key):
3171 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3172 (click_position): New function, to check that positions are in range.
3173 (Fcurrent_active_maps):
3174 (describe_command):
3175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3176 (Faccessible_keymaps, Fkey_description):
3177 (preferred_sequence_p):
3178 Don't assume fixnum can fit into int.
3179 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3180 Check for integer overflow in size calculations.
3181 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3182 avoid mishandling large integers.
3183 * lisp.h: Adjust decls to match defn changes elsewhere.
3184 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3185 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3186 (struct Lisp_Marker):
3187 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3188 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3189 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3190 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3191 All callers changed.
3192 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3193 Assume the arg has valid form, since it always does.
3194 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3195 unsigned integer system type.
3196 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3197 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3198 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3199 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3200 (duration_to_sec_usec): New decl.
3201 * lread.c (read_from_string_index, read_from_string_index_byte)
3202 (read_from_string_limit, readchar, unreadchar, openp)
3203 (read_internal_start, read1, oblookup):
3204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3205 (Fload, readevalloop, Feval_buffer, Feval_region):
3206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3207 (openp): Check for out-of-range argument to 'access'.
3208 (read1): Use int, not EMACS_INT, where int is wide enough.
3209 Don't assume fixnum fits into int.
6efdadfd 3210 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3211 (read_filtered_event): Use duration_to_sec_usec
3212 to do proper overflow checking on durations.
d311d28c
PE
3213 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3214 in size calculation.
3215 (Fexecute_kbd_macro):
3216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3217 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3218 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3219 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3220 (set_marker_both, set_marker_restricted_both, marker_position)
3221 (marker_byte_position, Fbuffer_has_markers_at):
3222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3223 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3224 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3225 It now merely ensures that the menu is large enough, without
3226 necessarily growing it, as this avoids some integer overflow issues.
3227 All callers changed.
3228 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3230 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3231 Use SAFE_ALLOCA_LISP, not alloca.
3232 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3233 to EMACS_INT. Check that fixnums are in proper range for system types.
3234 * minibuf.c (minibuf_prompt_width, string_to_object)
3235 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3236 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3238 (get_minibuffer, read_minibuf_unwind):
3239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3240 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3241 this simplifies overflow checking. All callers changed.
3242 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3243 (Ftest_completion):
3244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3245 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3246 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3247 Check that fixnums are in proper range for system types.
3248 (Fx_create_frame, Fx_show_tip):
3249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3250 * nsfont.m (ns_findfonts, nsfont_list_family):
3251 Don't assume fixnum fits in long.
3252 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3253 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3254 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3255 wide enough.
17fdb222 3256 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3258 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3259 (PRINTDECLARE, PRINTPREPARE):
3260 (strout, print_string):
3261 (print, print_preprocess, print_check_string_charset_prop)
3262 (print_object):
3263 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3264 (PRINTDECLARE):
3265 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3267 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3268 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3269 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3270 (print_error_message): Use SAFE_ALLOCA, not alloca.
3271 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3272 (print_depth, new_backquote_output, print_number_index):
3273 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3274 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3275 (Fset_process_window_size, Fformat_network_address)
3276 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3277 (sigchld_handler):
d311d28c 3278 Check that fixnums are in proper range for system types.
d44287d4 3279 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3280 Check for process-ids out of pid_t range rather than relying on
3281 undefined behavior.
e4d81efc 3282 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3283 (Fformat_network_address, read_process_output, send_process)
3284 (Fprocess_send_region, status_notify):
3285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3286 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3287 (wait_reading_process_output, read_process_output, exec_sentinel):
3288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3289 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3290 (Faccept_process_output): Use duration_to_sec_usec to do proper
3291 overflow checking on durations.
dde14581
PE
3292 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3293 Don't assume pid_t fits in int.
02481186
PE
3294 * process.h (struct Lisp_Process): Members tick and update_tick
3295 are now of type EMACS_INT, not int.
b62b53e8
PE
3296 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3297 configured --with-wide-int.
d311d28c
PE
3298 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3299 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3300 * search.c (looking_at_1, string_match_1):
3301 (fast_string_match, fast_c_string_match_ignore_case)
3302 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3303 (scan_newline, find_before_next_newline, search_command)
3304 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3305 (set_search_regs, wordify):
3306 (Freplace_match):
3307 (Fmatch_data):
3308 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3309 (string_match_1, search_buffer, set_search_regs):
3310 (Fmatch_data):
3311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3312 (wordify): Check for overflow in size calculation.
3313 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3314 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3315 Check that fixnums are in proper range for system types.
3316 * sound.c (struct sound_device)
3317 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3319 (Fplay_sound_internal):
3320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3321 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3322 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3323 (Fparse_partial_sexp):
3324 Don't assume fixnums can fit in int.
3325 (struct lisp_parse_state, find_start_pos, find_start_value)
3326 (find_start_value_byte, find_start_begv)
3327 (update_syntax_table, char_quoted, dec_bytepos)
3328 (find_defun_start, prev_char_comend_first, back_comment):
3329 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3330 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 (Finternal_describe_syntax_value): Check that match_lisp is a
3333 character, not an integer, since the code stuffs it into int.
3334 (scan_words, scan_sexps_forward):
3335 Check that fixnums are in proper range for system types.
3336 (Fforward_word):
3337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3338 (scan_sexps_forward):
3339 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3340 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3341 * syntax.h: Adjust decls to match defn changes elsewhere.
3342 (struct gl_state_s):
3343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3344 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3345 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3346 * sysdep.c (wait_for_termination_1, wait_for_termination)
3347 (interruptible_wait_for_termination, mkdir):
3348 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3349 (emacs_read, emacs_write):
3350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3351 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3352 and double all fit in int.
d311d28c
PE
3353 * term.c (set_tty_color_mode):
3354 Check that fixnums are in proper range for system types.
3355 * termhooks.h (struct input_event):
3356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3357 * textprop.c (validate_interval_range, interval_of)
3358 (Fadd_text_properties, set_text_properties_1)
3359 (Fremove_text_properties, Fremove_list_of_text_properties)
3360 (Ftext_property_any, Ftext_property_not_all)
3361 (copy_text_properties, text_property_list, extend_property_ranges)
3362 (verify_interval_modification):
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 (Fnext_single_char_property_change)
3365 (Fprevious_single_char_property_change):
3366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3367 (copy_text_properties):
3368 Check for integer overflow in index calculation.
d311d28c
PE
3369 * undo.c (last_boundary_position, record_point, record_insert)
3370 (record_delete, record_marker_adjustment, record_change)
3371 (record_property_change):
3372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3373 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3374 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3375 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3376 (Fx_hide_tip, Fx_file_dialog):
3377 * w32menu.c (set_frame_menubar):
3378 Use ptrdiff_t, not int, for consistency with rest of code.
3379 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3380 (select_window, Fdelete_other_windows_internal)
3381 (window_scroll_pixel_based, window_scroll_line_based)
3382 (Frecenter, Fset_window_configuration):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 (Fset_window_hscroll, run_window_configuration_change_hook)
3385 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3386 (Fscroll_other_window, Frecenter):
d311d28c
PE
3387 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3388 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3389 Don't assume fixnum fits in int.
3390 (Fset_window_scroll_bars):
3391 Check that fixnums are in proper range for system types.
3392 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3393 (string_pos, c_string_pos, number_of_chars, init_iterator)
3394 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3395 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3396 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3397 (face_before_or_after_it_pos, handle_invisible_prop)
3398 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3399 (display_prop_intangible_p, string_buffer_position_lim)
3400 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3401 (get_overlay_strings_1, get_overlay_strings)
3402 (iterate_out_of_display_property, forward_to_next_line_start)
3403 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3404 (get_next_display_element, set_iterator_to_next)
3405 (get_visually_first_element, compute_stop_pos_backwards)
3406 (handle_stop_backwards, next_element_from_buffer)
3407 (move_it_in_display_line_to, move_it_in_display_line)
3408 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3409 (add_to_log, message_dolog, message_log_check_duplicate)
3410 (message2, message2_nolog, message3, message3_nolog
3411 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3412 (current_message_1, truncate_echo_area, truncate_message_1)
3413 (set_message, set_message_1, store_mode_line_noprop)
3414 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3415 (text_outside_line_unchanged_p, check_point_in_composition)
3416 (reconsider_clip_changes)
3417 (redisplay_internal, set_cursor_from_row, try_scrolling)
3418 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3419 (redisplay_window, find_last_unchanged_at_beg_row)
3420 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3421 (trailing_whitespace_p, find_row_edges, display_line)
3422 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3423 (display_mode_element, store_mode_line_string)
3424 (pint2str, pint2hrstr, decode_mode_spec)
3425 (display_count_lines, display_string, draw_glyphs)
3426 (x_produce_glyphs, x_insert_glyphs)
3427 (rows_from_pos_range, mouse_face_from_buffer_pos)
3428 (fast_find_string_pos, mouse_face_from_string_pos)
3429 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3431 (safe_call, init_from_display_pos, handle_fontified_prop)
3432 (handle_single_display_spec, load_overlay_strings)
3433 (with_echo_area_buffer, setup_echo_area_for_printing)
3434 (display_echo_area, echo_area_display)
3435 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3436 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3437 (redisplay_window, dump_glyph_row, display_mode_line)
3438 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3439 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3441 (handle_single_display_spec, build_desired_tool_bar_string)
3442 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3443 (get_specified_cursor_type):
3444 Check that fixnums are in proper range for system types.
3445 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3446 (Flookup_image_map):
3447 Don't assume fixnums fit in int.
3448 (compare_overlay_entries):
3449 Avoid mishandling comparisons due to subtraction overflow.
3450 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3451 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3452 (handle_tool_bar_click):
3453 Use int, not unsigned, since we prefer signed and the signedness
3454 doesn't matter here.
3455 (get_next_display_element, next_element_from_display_vector):
3456 Use int, not EMACS_INT, when int is wide enough.
3457 (start_hourglass): Use duration_to_sec_usec to do proper
3458 overflow checking on durations.
3459 * xfaces.c (Fbitmap_spec_p):
3460 Check that fixnums are in proper range for system types.
3461 (compare_fonts_by_sort_order):
3462 Avoid mishandling comparisons due to subtraction overflow.
3463 (Fx_family_fonts, realize_basic_faces):
3464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3465 (Fx_family_fonts):
3466 Don't assume fixnum fits in int.
3467 Use SAFE_ALLOCA_LISP, not alloca.
3468 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3469 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3470 (face_at_buffer_position, face_for_overlay_string)
3471 (face_at_string_position):
3472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3473 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3474 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3475 (Fx_show_tip):
3476 Check that fixnums are in proper range for system types.
3477 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3478 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3480 (Fx_change_window_property): Don't assume fixnums fit in int.
3481 * xfont.c (xfont_chars_supported):
3482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3483 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3484 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3486 * xml.c (parse_region):
3487 * xrdb.c (magic_file_p):
3488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3489 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3490 (x_get_local_selection, x_reply_selection_request)
3491 (x_handle_selection_request, wait_for_property_change):
3492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3493 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3494 short is wide enough.
3495 (x_send_client_event): Don't assume fixnum fits in int.
3496 * xterm.c (x_x_to_emacs_modifiers):
3497 Don't assume EMACS_INT overflows nicely into int.
3498 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3499 may come from Lisp.
3500 (handle_one_xevent): NATNUMP can eval its arg twice.
3501 (x_connection_closed):
3502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3503 * xterm.h: Adjust decls to match defn changes elsewhere.
3504 (struct scroll_bar): Use struct vectorlike_header
3505 rather than rolling our own approximation.
3506 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3507
c6574eb5
GM
35082012-05-25 Glenn Morris <rgm@gnu.org>
3509
3510 * lisp.mk (lisp): Update for more files being compiled now.
3511
e8d32c7e
SM
35122012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3513
48def666
SM
3514 * lread.c: Remove `read_pure' which makes no difference.
3515 (read_pure): Remove var.
3516 (unreadpure): Remove function.
3517 (readevalloop): Don't call read_list with -1 flag.
3518 (read1, read_vector): Don't test read_pure any more.
3519 (read_list): Simplify.
3520
e8d32c7e
SM
3521 * fileio.c, character.h: Minor style tweaks.
3522
4b2addb7
DA
35232012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3524
3525 * window.h (clip_changed): Remove useless declaration.
3526
584461b2
JB
35272012-05-22 Juanma Barranquero <lekktu@gmail.com>
3528
3529 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3530 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3531
34374650
PE
35322012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 Remove src/m/*.
3535 This directory predates autoconf and is no longer needed nowadays.
3536 Move its few remaining bits of functionality to where they're needed.
3537 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3538 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3539 * m/template.h: Remove.
3540 * Makefile.in (M_FILE): Remove. All uses removed.
3541 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3542 * lisp.h (USE_LSB_TAG):
3543 * mem-limits.h (EXCEEDS_LISP_PTR):
3544 Use VAL_MAX, not VALBITS, in #if.
3545 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3546 (EMACS_UINT): Define unconditionally now.
3547 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3548 (BITS_PER_EMACS_INT): New constants, replacing
3549 what used to be in config.h, but not useful in #if.
3550 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3551 define them any more.
3552 (VAL_MAX): New macro.
3553 (VALMASK): Use it.
3554 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3555 BITS_PER_EMACS_INT, in #if.
3556 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3557 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3558 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3559 * s/ms-w32.h (DATA_START):
3560 Move here from removed file m/intel386.h.
3561 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3562 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3563
261cb4bb
PE
35642012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3565
3566 Assume C89 or later.
3567 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3568 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3569 (xrealloc):
3570 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3571 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3572 * textprop.c, tparam.c (NULL): Remove.
3573 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3574 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3575 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3576 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3577 * xterm.c (input_signal_count): Assume volatile works.
3578
ff23cd9f
KB
35792012-05-21 Ken Brown <kbrown@cornell.edu>
3580
3581 * xgselect.c (xg_select): Fix first argument in call to 'select'
3582 (bug#11508).
3583
1b170bc6
KB
35842012-05-20 Ken Brown <kbrown@cornell.edu>
3585
3586 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3587 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3588
b2f4d39f
KB
35892012-05-19 Ken Brown <kbrown@cornell.edu>
3590
3591 * xfns.c (x_in_use): Remove `static' qualifier.
3592 * xterm.h (x_in_use): Declare.
3593 * xgselect.c: Include xterm.h.
3594 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3595 and `display_arg' (bug#9754).
3596
003fdae2
PE
35972012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3598
9232a6d9
PE
3599 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3600
003fdae2
PE
3601 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3602 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3603
784b56e2
EZ
36042012-05-18 Eli Zaretskii <eliz@gnu.org>
3605
3606 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3607
3608 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3609 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3610
3611 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3612 reference to image_cache->refcount.
3613 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3614
a0a79cde
JL
36152012-05-17 Juri Linkov <juri@jurta.org>
3616
3617 * search.c (Fword_search_regexp, Fword_search_backward)
3618 (Fword_search_forward, Fword_search_backward_lax)
3619 (Fword_search_forward_lax): Move functions to isearch.el
3620 (bug#10145, bug#11381).
3621
b0572523
PE
36222012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3623
3624 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3625
9660f5fc
SM
36262012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3627
3628 * lread.c (init_obarray): Declare Qt and Qnil as special.
3629
4374de83
GM
36302012-05-14 Glenn Morris <rgm@gnu.org>
3631
3632 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3633 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3634
dc44c39a
PE
36352012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3636
078c97cb
PE
3637 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3638
dc44c39a
PE
3639 * unexaix.c: Port to more-recent AIX compilers.
3640 (report_error, report_error_1, make_hdr, copy_sym)
3641 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3642 Make arguments const char *, not char *, to avoid violations of C
3643 standard and to fix some AIX warnings reported by Gilles Pion.
3644
e18afed7 36452012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3646
3647 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3648 already have overlays loaded.
3649 (handle_single_display_spec): Before returning without displaying
3650 fringe bitmap, synchronize the bidi iterator with the main display
3651 iterator, by calling iterate_out_of_display_property.
3652 (iterate_out_of_display_property): Detect buffer iteration by
3653 testing that it->string is a Lisp string.
3654 (get_next_display_element): When the current object is exhausted,
3655 and there's something on it->stack, call set_iterator_to_next to
3656 proceed with what's on the stack, instead of returning zero.
3657 (set_iterator_to_next): If called at the end of a Lisp string,
3658 proceed to consider_string_end without incrementing string
3659 position. Don't increment display vector index past the end of
3660 the display vector. (Bug#11417)
c8fb9dc6
EZ
3661 (pos_visible_p): Don't report a position visible when move_it_to
3662 stopped at the last line of window, which happens to be scanned
3663 backwards by the bidi iteration. (Bug#11464)
ac268e67 3664
e18afed7 36652012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3666
3667 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3668 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3669 are on a TTY, and thus unable to display on the fringes.
3670 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3671 so we need to signal to the caller that this is a "replacing"
3672 display spec. This fixes display when the spec is invalid or we
3673 are on a TTY.
3674
e18afed7 36752012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3676
3677 * unexaix.c (make_hdr): Fix typo in prototype.
3678 This bug broke the build on AIX. Problem reported by Gilles Pion.
3679
9d0a235a
MA
36802012-05-14 Michael Albinus <michael.albinus@gmx.de>
3681
3682 * keyboard.c (kbd_buffer_get_event): Read special events also in
3683 batch mode. (Bug#11415)
3684
9e6b06ed
GM
36852012-05-12 Glenn Morris <rgm@gnu.org>
3686
3687 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3688
c1a1d7a3
EZ
36892012-05-12 Eli Zaretskii <eliz@gnu.org>
3690
3691 * lisp.mk (lisp): Add newcomment.elc.
3692
3fe7cdc8
GM
36932012-05-12 Glenn Morris <rgm@gnu.org>
3694
3695 * Makefile.in (MKDIR_P): New, set by configure.
3696 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3697
53f7d2c0
PE
36982012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3699
3700 Remove unused function hourglass_started.
3701 * dispextern.h (hourglass_started):
3702 * w32fns.c (hourglass_started):
3703 * xdisp.c (hourglass_started): Remove.
3704
75aafb17
JB
37052012-05-10 Juanma Barranquero <lekktu@gmail.com>
3706
3707 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3708 Update dependencies.
3709
12959e8e
PE
37102012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3711
97107e2e
PE
3712 * xgselect.c (xg_select): Put maxfds+1 into a var.
3713 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3714
12959e8e
PE
3715 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3716
836d29b3
DA
37172012-05-10 Dave Abrahams <dave@boostpro.com>
3718
3719 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3720 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3721
5cb67954
MA
37222012-05-09 Michael Albinus <michael.albinus@gmx.de>
3723
3724 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3725 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3726 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3727 Initialize xd_registered_buses.
3728
3478ec45
PE
37292012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3730
b263a6b0
PE
3731 Untag more efficiently if USE_LSB_TAG.
3732 This is based on a proposal by YAMAMOTO Mitsuharu in
3733 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3734 For an admittedly artificial (nth 8000 longlist) benchmark on
3735 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3736 Emacs's overall text size by 1%.
3737 * lisp.h (XUNTAG): New macro.
3738 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3739 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3740 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3741 * eval.c (Fautoload):
3742 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3743 * frame.h (XFRAME): Use XUNTAG.
3744
3478ec45
PE
3745 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3746 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3747 Remove unportable assumptions about print widths of types like
3748 dbus_uint32_t.
3749 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3750 intptr_t when converting between pointer and integer, to avoid GCC
3751 warnings about wrong width.
3752
666b903b 37532012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3754
3755 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3756 stack for each reader_thread, instead of defaulting to 8MB
3757 determined by the linker. This avoids failures in creating
3758 subprocesses on Windows 7, see the discussion in this thread:
3759 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3760
b120cc17
JC
37612012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3762
3763 Fix up display of the *Minibuf-0* buffer in the mini window.
3764 * keyboard.c (read_char): Don't clear the echo area if there's no
3765 message to clear.
3766 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3767 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3768
9a4b36f8
MA
37692012-05-07 Michael Albinus <michael.albinus@gmx.de>
3770
3771 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3772 batch mode.
3773
e5f9458f
CY
37742012-05-06 Chong Yidong <cyd@gnu.org>
3775
3776 * lisp.mk (lisp): Update.
3777
eceeb5fc 37782012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3779
3780 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3781
71873e2b
SM
37822012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3783
3784 * data.c (PUT_ERROR): New macro.
3785 (syms_of_data): Use it. Add new error type `user-error'.
3786 * undo.c (user_error): New function.
3787 (Fprimitive_undo): Use it.
3788 * print.c (print_error_message): Adjust print style for `user-error'.
3789 * keyboard.c (user_error): New function.
3790 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3791
ab0fa4e4
PE
37922012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3793
3794 Do not limit current-time-string to years 1000..9999.
3795 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3796 (Fcurrent_time_string): Support any year that is supported by the
3797 underlying localtime representation. Don't use asctime, as it
3798 has undefined behavior for years outside the range -999..9999.
3799
7ed806a7
PE
38002012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3801
3802 Fix race conditions involving setenv, gmtime, localtime, asctime.
3803 Without this fix, interrupts could mess up code that uses these
3804 nonreentrant functions, since setting TZ invalidates existing
3805 tm_zone or tzname values, and since most of these functions return
3806 pointers to static storage.
3807 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3808 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3809 Grow the critical sections to include not just invoking
3810 localtime/gmtime, but also accessing these functions' results
3811 including their tm_zone values if any, and any related TZ setting.
3812 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3813 so that the struct tm is saved in the critical section.
3814 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3815 motivated by the fact that memory allocation needs to be outside
3816 the critical section.
3817
0c16dfed
DA
38182012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3819
3820 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3821 with RESET_INTERVAL.
3822
3823 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3824 Remove duplicated buffer name initialization.
3825
3f83ace8
JM
38262012-05-02 Jim Meyering <jim@meyering.net>
3827
3828 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3829
c7b8541e
JM
3830 * xfns.c (x_window): Use xstrdup (Bug#11375).
3831
90207a15 38322012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3833
3834 * xdisp.c (pos_visible_p): If already at a newline from the
3835 display string before the 'while' loop, don't walk back the glyphs
3836 from it3.glyph_row. Solves assertion violation when the display
3837 string begins with a newline (egg.el). (Bug#11367)
3838
b593d6a9
AH
38392012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3840
3841 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3842 Move to simple.el.
3843
4737362e
GM
38442012-05-01 Glenn Morris <rgm@gnu.org>
3845
99cf43f9
GM
3846 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3847 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3848 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3849 All were removed before 23.1.
3850
9311dcff
GM
3851 * dispnew.c: Remove HAVE_LIBNCURSES test;
3852 it is always true on relevant platforms.
3853
4d5c6349
GM
3854 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3855 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3856
4737362e
GM
3857 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3858
74dd3a6b
AS
38592012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3860
3861 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3862 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3863 Remove.
3864
13c379ee
PE
38652012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3866
3867 Do not avoid creating empty evaporating overlays (Bug#9642).
3868 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3869 That is, do not delete an evaporating overlay if it becomes
3870 empty after its bounds are adjusted to fit within its buffer.
3871 This fix caused other problems, and I'm reverting it until we get
3872 to the bottom of them.
3873
a8e7d6d7 38742012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3875
3876 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3877
a8e7d6d7 38782012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3879
3880 * xdisp.c (pos_visible_p): If the window start position is beyond
3881 ZV, start the display from buffer beginning. Prevents assertion
3882 violation in init_iterator when the minibuffer window is scrolled
3883 via the scroll bar.
3884
3885 * window.c (window_scroll_pixel_based): Likewise.
3886
a8e7d6d7 38872012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3888
3889 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3890
a8e7d6d7 38912012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3892
3893 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3894 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3895
a8e7d6d7 38962012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3897
b593d6a9
AH
3898 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3899 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3900
1c6900d9
EZ
39012012-04-26 Eli Zaretskii <eliz@gnu.org>
3902
4c3fa1d9
EZ
3903 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3904 display element, check also the underlying string or buffer
3905 character. (Bug#11341)
3906
1c6900d9
EZ
3907 * w32menu.c: Include w32heap.h.
3908 (add_menu_item): If the call to AppendMenuW (via
3909 unicode_append_menu) fails, disable Unicode menus only if we are
3910 running on Windows 9X/Me.
3911
42bf8205
AS
39122012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3913
3914 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3915 (xgetint): Add missing shift for LSB tags.
3916
b1bac16e
MR
39172012-04-24 Martin Rudalics <rudalics@gmx.at>
3918
3919 * keyboard.c (read_char): Don't wipe echo area for select window
3920 events: These might get delayed via `mouse-autoselect-window'
3921 (Bug#11304).
3922
d69621cc
JB
39232012-04-24 Juanma Barranquero <lekktu@gmail.com>
3924
3925 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3926 manipulation of :loaded-from data.
3927
02fd101b
JB
39282012-04-23 Juanma Barranquero <lekktu@gmail.com>
3929
3930 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3931 now a cons (bug#11311).
3932
888bec30
PE
39332012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3934
89a438bd
PE
3935 Do not create empty overlays with the evaporate property (Bug#9642).
3936 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3937 if it becomes empty after its bounds are adjusted to fit within
3938 its buffer. Without this fix, in a nonempty buffer (let ((o
3939 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3940 yields an empty overlay that has the evaporate property, which is
3941 not supposed to happen.
3942
1068fe4d
PE
3943 Fix minor GTK3 problems found by static checking.
3944 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3945 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3946 (struct _EmacsFixedClass, emacs_fixed_get_type):
3947 Move decls here from emacsgtkfixed.h, since they needn't be public.
3948 (emacs_fixed_get_type): Now static.
3949 (emacs_fixed_class_init): Omit unused local.
3950 (emacs_fixed_child_type): Remove; unused.
3951 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3952 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3953 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3954 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3955 (EMACS_FIXED_GET_CLASS): Remove; unused.
3956 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3957
888bec30
PE
3958 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3959 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3960
de85e130
PE
39612012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3962
d0baac98 3963 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3964 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3965 (__malloc_size_t, __malloc_ptrdiff_t):
3966 Remove. All uses removed, replaced by the definiens if needed,
3967 since we can assume C89 or better now.
3968 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3969 (protect_malloc_state, align, get_contiguous_space)
3970 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3971 (malloc_atfork_handler_child, malloc_enable_thread)
3972 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3973 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3974 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3975 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3976 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3977 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3978 Define using prototypes, not old style.
3979 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3980 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3981 (align): Don't assume that signed integer overflow wraps around.
3982 Omit unused local var.
3983 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3984 (_free_internal_nolock, memalign, mallochook, reallochook):
3985 Omit no-longer-needed casts.
3986 (valloc): Use getpagesize, not __getpagesize.
3987 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3988 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3989
de85e130
PE
3990 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3991
dcbf5805
MA
39922012-04-22 Michael Albinus <michael.albinus@gmx.de>
3993
3994 Move functions from C to Lisp. Make non-blocking method calls
3995 the default. Implement further D-Bus standard interfaces.
3996
3997 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3998 (QCdbus_request_name_allow_replacement)
3999 (QCdbus_request_name_replace_existing)
4000 (QCdbus_request_name_do_not_queue)
4001 (QCdbus_request_name_reply_primary_owner)
4002 (QCdbus_request_name_reply_in_queue)
4003 (QCdbus_request_name_reply_exists)
4004 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4005 (QCdbus_registered_serial, QCdbus_registered_method)
4006 (QCdbus_registered_signal): New Lisp objects.
4007 (XD_DEBUG_MESSAGE): Use sizeof.
4008 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4009 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4010 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4011 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4012 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4013 (xd_signature, xd_append_arg): Allow float for integer types.
4014 (xd_get_connection_references): New function.
b593d6a9
AH
4015 (xd_get_connection_address): Rename from xd_initialize.
4016 Return cached address.
dcbf5805
MA
4017 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4018 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4019 level.
4020 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4021 Return number of refcounts.
dcbf5805
MA
4022 (Fdbus_get_unique_name): Make stronger parameter check.
4023 (Fdbus_message_internal): New defun.
4024 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4025 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4026 (Fdbus_send_signal, Fdbus_register_service)
4027 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4028 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4029 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4030 (Vdbus_compiled_version, Vdbus_runtime_version)
4031 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4032 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4033 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4034 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4035 Adapt docstring.
dcbf5805 4036
52828e02
PE
40372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4038
da05bc4c
PE
4039 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4040 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4041 Do not assume ptrdiff_t is the same width as 'int'.
4042
52828e02
PE
4043 * alloc.c: Handle unusual debugging option combinations.
4044 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4045 since the two debugging options are incompatible.
4046 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4047 is defined.
4048 (mem_init, mem_insert, mem_insert_fixup):
4049 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4050 (NEED_MEM_INSERT): Remove; no longer needed.
4051
f01769f9
LL
40522012-04-22 Leo Liu <sdl.web@gmail.com>
4053
4054 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4055
5790543d
PE
40562012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4057
4058 * sysdep.c [__FreeBSD__]: Minor cleanups.
4059 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4060 Use Emacs indenting style more consistently. Avoid some casts.
4061 Use 'double' consistently rather than mixing 'float' and 'double'.
4062
b91b7e4d
EW
40632012-04-21 Eduard Wiebe <usenet@pusto.de>
4064
b593d6a9
AH
4065 * sysdep.c (list_system_processes, system_process_attributes):
4066 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4067
6114eb15
AS
40682012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4069
4070 * lisp.mk (lisp): Update.
4071
2f38dff7
PE
40722012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4073
4074 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4075 It is never used otherwise.
4076
4ae29f89
SM
40772012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4078
4079 * print.c (print_preprocess): Only check print_depth if print-circle
4080 is nil.
4081 (print_object): Check for cycles even when print-circle is nil and
4082 print-gensym is t, but only check print_depth if print-circle is nil.
4083
f30d612a
CY
40842012-04-20 Chong Yidong <cyd@gnu.org>
4085
4086 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4087 set the status to "failed" and ensure that sentinel is run.
4088
c07a4c0b 40892012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4090
4091 * process.c (Fset_process_inherit_coding_system_flag)
4092 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4093 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4094
c07a4c0b 40952012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4096
4097 * xdisp.c (string_buffer_position_lim): Limit starting position to
4098 BEGV.
4099 (set_cursor_from_row): If called for a mode-line or header-line
4100 row, return zero immediately.
4101 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4102 farther than the first row after the header line, if any.
4103 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4104 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4105
c07a4c0b 41062012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4107
4ae29f89
SM
4108 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4109 (bug#11238).
ad3a2b41 4110
c07a4c0b 41112012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 41122012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4113
4114 configure: new option --enable-gcc-warnings (Bug#11207)
4115 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4116 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4117 (ALL_CFLAGS): Use new macros rather than old.
4118 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4119 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4120 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4121 -Wunused-result, -Wunused-variable. This should go away once
4122 the Emacs and Gnulib regex code is merged.
4123 (xmalloc, xrealloc): Now static.
4124
aba027e8
PE
41252012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4126
4127 * dired.c (Fsystem_groups): Remove unused local.
4128
e5a36063
GM
41292012-04-17 Glenn Morris <rgm@gnu.org>
4130
4131 * dired.c (Fsystem_users): Doc fix.
4132
316411f0
DA
41332012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4134
4135 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4136 (syms_of_dired): Add them.
4137
9426aba4
PE
41382012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4139
b62a57be
PE
4140 Fix minor alloc.c problems found by static checking.
4141 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4142 New extern decls, to avoid calling undeclared functions.
4143 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4144 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4145 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4146 (NEED_MEM_INSERT): New macro.
4147 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4148 Remove one incorrect comment and fix another.
b62a57be 4149
3539f31f
PE
4150 Fix minor ralloc.c problems found by static checking.
4151 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4152 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4153 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4154 (r_alloc_sbrk): Now static.
4155
a041960a
PE
4156 Improve ralloc.c interface checking.
4157 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4158 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4159 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4160 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4161 [REL_ALLOC]: ... to here, to check interface.
4162 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4163 Remove decls. This fixes an "It stinks!".
4164
9426aba4
PE
4165 * alloc.c (which_symbols): Fix alignment issue / type clash.
4166
d55c12ed
AS
41672012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4168
4169 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4170 (struct Lisp_Misc_Any): Likewise.
4171 (struct Lisp_Free): Likewise.
4172 * alloc.c (union aligned_Lisp_Symbol): Define.
4173 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4174 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4175 (union aligned_Lisp_Misc): Define.
4176 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4177 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4178 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4179
b948ce8b
PE
41802012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4181
4182 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4183 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4184 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4185 * s/netbsd.h, s/sol2-6.h:
4186 Remove definition of GC_MARK_STACK, since the default now works.
4187 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4188 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4189 no longer the default.
4190 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4191
35dc09a1 41922012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4193
35dc09a1
GM
4194 * lread.c (lisp_file_lexically_bound_p):
4195 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4196
35dc09a1
GM
41972012-04-14 Eli Zaretskii <eliz@gnu.org>
4198
4199 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4200 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4201
42022012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4203
4204 * nsterm.m (constrainFrameRect): Always constrain when there is only
4205 one screen (Bug#10962).
4206
bcd86815
KB
42072012-04-13 Ken Brown <kbrown@cornell.edu>
4208
4209 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4210
c25df26e
RT
42112012-04-13 Reuben Thomas <rrt@sc3d.org>
4212
4213 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4214
0fc59f1e
DC
42152012-04-11 Daniel Colascione <dancol@dancol.org>
4216
4217 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4218 against is gone. It's better to use vfork now so that when Cygwin
4219 gains a new, working vfork, we use it automatically (bug#10398).
4220
de8c03dc
SM
42212012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4222
4223 * window.c (save_window_save): Obey window-point-insertion-type.
4224
2f097256
GM
42252012-04-11 Glenn Morris <rgm@gnu.org>
4226
4227 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4228
453b951e
SM
42292012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4230
4231 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4232
75f1671a 42332012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4234
4235 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4236 (force_quit_count): New var.
4237 (handle_interrupt): Use it.
4238
2a8ce227
JB
42392012-04-10 Juanma Barranquero <lekktu@gmail.com>
4240
4241 * w32.c (w32_delayed_load): Record the full path of the library
4242 being loaded (bug#10424).
4243
935396c0
GM
42442012-04-09 Glenn Morris <rgm@gnu.org>
4245
05920a43
GM
4246 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4247 not just in the obarray, before snarfing them. (Bug#11036)
4248
935396c0
GM
4249 * Makefile.in ($(leimdir)/leim-list.el):
4250 Pass EMACS rather than BUILT_EMACS.
4251
a18ecafa
TZ
42522012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4253
4254 * process.c (make_process):
4255 * process.h: Add integer `gnutls_handshakes_tried' member to
4256 process struct.
4257
6bbef4e5
JC
4258 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4259 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4260
4261 * gnutls.c (gnutls_log_function2i): Convenience log function.
4262 (emacs_gnutls_read): Use new log functions,
4263 `gnutls_handshakes_tried' process member, and
4264 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4265 attempts per process (connection).
4266
b4d3bc10
CY
42672012-04-09 Chong Yidong <cyd@gnu.org>
4268
4269 * eval.c (Fuser_variable_p, user_variable_p_eh)
4270 (lisp_indirect_variable): Functions deleted.
4271 (Fdefvar): Caller changed.
4272
4273 * callint.c (Finteractive, Fcall_interactively):
4274 * minibuf.c (Fread_variable): Callers changed.
4275
70f4d973
EZ
42762012-04-09 Eli Zaretskii <eliz@gnu.org>
4277
4278 * xdisp.c (set_cursor_from_row): If the display string appears in
4279 the buffer at position that is closer to point than the position
4280 after the display string, display the cursor on the first glyph of
4281 the display string. Fixes cursor display when a 'display' text
4282 property immediately follows invisible text. (Bug#11094)
4283
cb3c2e3e
PE
42842012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4285
4286 composite.c: use 'double' consistently
4287 * composite.c (get_composition_id): Use 'double' consistently
4288 instead of converting 'float' to 'double' and vice versa; this is
4289 easier to understand and avoids a GCC warning.
4290
fd06db5d
GM
42912012-04-09 Glenn Morris <rgm@gnu.org>
4292
50fe702a
GM
4293 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4294 preparation for dumping it with emacs. (Bug#4789)
4295 (leimdir): New variable.
4296 ($(leimdir)/leim-list.el): New rule.
4297 (emacs$(EXEEXT)): Depend on leim-list.el.
4298
fd06db5d
GM
4299 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4300 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4301 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4302
55c131ee
AS
43032012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4304
4305 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4306 proper alignment.
4307
9209588f
JB
43082012-04-07 Juanma Barranquero <lekktu@gmail.com>
4309
4310 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4311 Remove unused local variable.
4312
e3fb2efb
PE
43132012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4314
4315 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4316 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4317 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4318 objects, as mark_maybe_pointer will catch them otherwise.
4319 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4320 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4321
b5385551
PE
43222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 Fix typo that broke non-Windows builds.
4325 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4326
9078ead6
EZ
43272012-04-07 Eli Zaretskii <eliz@gnu.org>
4328
4329 Support building on MS-Windows with libxml2.
4330
4331 * makefile.w32-in (OBJ2): Add xml.$(O).
4332 (GLOBAL_SOURCES): Add xml.c.
4333 ($(BLD)/xml.$(O)): New dependency list.
4334
4335 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4336 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4337 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4338 [!WINDOWSNT]: New macros.
4339 (init_libxml2_functions, libxml2_loaded_p): New functions.
4340 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4341 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4342 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4343 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4344 linked in).
6bbef4e5
JC
4345 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4346 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4347 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4348
4349 * emacs.c: Don't include libxml/parser.h.
4350 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4351 xmlCleanupParser directly.
4352
4353 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4354
3811fdf3
EZ
43552012-04-07 Eli Zaretskii <eliz@gnu.org>
4356
4357 * indent.c (Fvertical_motion): If there is a display string at
4358 point, use it.vpos to compute how many lines to backtrack after
4359 move_it_to point. (Bug#11133)
4360
2f8e16b2
EZ
43612012-04-06 Eli Zaretskii <eliz@gnu.org>
4362
4363 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4364 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4365 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4366 macros related to unification of CJK characters. For the details,
4367 see the discussion following the message here:
4368 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4369
3d439cd1
CY
43702012-04-04 Chong Yidong <cyd@gnu.org>
4371
4372 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4373
8bc53d00
EZ
43742012-04-01 Eli Zaretskii <eliz@gnu.org>
4375
4376 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4377 instead of alloca. (Bug#11138)
4378
3b0512a3
AS
43792012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4380
4381 * w32menu.c (is_simple_dialog): Properly check lisp types.
4382 (Bug#11141)
4383
8427ddd2
EZ
43842012-03-31 Eli Zaretskii <eliz@gnu.org>
4385
979022ef
EZ
4386 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4387 position we get to after a call to move_it_to fails the
4388 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4389 only if we wind up in a string from display property. (Bug#11063)
4390
a6b1c7cc
EZ
4391 * window.c (Fdelete_other_windows_internal): Invalidate the row
4392 and column information about mouse highlight, so that redisplay
4393 restores it after reallocating the glyph matrices. (Bug#7464)
4394
8427ddd2
EZ
4395 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4396 string comes from a `display' text property, use the buffer
4397 position of that property as if we actually saw that position in
4398 the row's glyphs.
697ba24b
EZ
4399 (move_it_by_lines): Remove the assertion that
4400 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4401 violated when there's a before-string at the beginning of a line.
4402 (Bug#11063)
8427ddd2 4403
65a0a738
EZ
44042012-03-30 Eli Zaretskii <eliz@gnu.org>
4405
4406 * xdisp.c (append_space_for_newline): If the default face was
4407 remapped, use the remapped face for the appended newline.
4408 (extend_face_to_end_of_line): Use the remapped default face for
4409 extending the face to the end of the line.
4410 (display_line): Call extend_face_to_end_of_line when the default
4411 face was remapped. (Bug#11068)
4412
581355cc
EZ
44132012-03-29 Eli Zaretskii <eliz@gnu.org>
4414
4415 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4416
e8fc049f
SM
44172012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4418
4419 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4420
4fb9a543
GM
44212012-03-27 Glenn Morris <rgm@gnu.org>
4422
4423 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4424 Doc fixes.
4425
679910f1
KH
44262012-03-26 Kenichi Handa <handa@m17n.org>
4427
4428 * dispextern.h (struct glyph): Fix previous change. Change the
4429 bit length of glyphless.ch to 25 (Bug#11082).
4430
90d49b7f
CY
44312012-03-26 Chong Yidong <cyd@gnu.org>
4432
4433 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4434 (command_loop_1): Use it; inhibit selection update for
4435 handle-select-window too (Bug#8996).
4436
f514f6f0
FP
44372012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4438
e8fc049f 4439 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4440
bf43fa51
KH
44412012-03-25 Kenichi Handa <handa@m17n.org>
4442
4443 * dispextern.h (struct glyph): Change the bit length of
4444 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4445
8a0c01dd
EZ
44462012-03-24 Eli Zaretskii <eliz@gnu.org>
4447
4448 * s/ms-w32.h (tzname): Include time.h before redirecting to
4449 _tzname. Fixes the MSVC build. (Bug#9960)
4450
7d1c3a76
AS
44512012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4452
8ed79523
AS
4453 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4454 characters.
4455
7d1c3a76
AS
4456 * xterm.c (XTread_socket): Only modify handling_signal if
4457 !SYNC_INPUT. (Bug#11080)
4458
e99a9b8b
EZ
44592012-03-23 Eli Zaretskii <eliz@gnu.org>
4460
4461 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4462 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4463 when fetching a multibyte character consumes more bytes than
4464 CHAR_BYTES returns, due to unification of CJK characters in
4465 string_char. (Bug#11073)
4466
5063c0e1
TN
44672012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4468
4469 * process.c (wait_reading_process_output): Handle pty disconnect
4470 by refraining from sending oneself a SIGCHLD (bug#10933).
4471
9f851fbd
CY
44722012-03-22 Chong Yidong <cyd@gnu.org>
4473
4474 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4475
5063c0e1 4476 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4477 Mark string as coming from a prefix property.
4478 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4479 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4480
fb5b8aca
CY
44812012-03-21 Chong Yidong <cyd@gnu.org>
4482
4483 * xfaces.c (Vface_remapping_alist): Doc fix.
4484
62356a1b
EZ
44852012-03-20 Eli Zaretskii <eliz@gnu.org>
4486
4487 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4488 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4489 Doc fixes.
62356a1b 4490
025de85b
CY
44912012-03-20 Chong Yidong <cyd@gnu.org>
4492
4493 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4494 to reflect default non-nil value of redisplay-dont-pause.
4495
4827f94e
KH
44962012-03-19 Kenichi Handa <handa@m17n.org>
4497
4498 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4499 it fit in a valid range (Bug#11003).
4500
e50a24a2
EZ
45012012-03-18 Eli Zaretskii <eliz@gnu.org>
4502
4503 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4504 that is not from display property, accept the row as a "cursor
4505 row" if one of the string's character has a non-nil `cursor'
4506 property. Fixes cursor positioning when there are newlines in
4507 overlay strings, e.g. in icomplete.el. (Bug#11035)
4508
9af5ed87
PE
45092012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4510
4511 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4512
d1f55f16
CY
45132012-03-12 Chong Yidong <cyd@gnu.org>
4514
4515 * eval.c (inhibit_lisp_code): Rename from
4516 inhibit_window_configuration_change_hook; move from window.c.
4517
4518 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4519 * window.c (run_window_configuration_change_hook)
4520 (syms_of_window): Callers changed.
4521
66c5eebd
CY
45222012-03-11 Chong Yidong <cyd@gnu.org>
4523
413df973
CY
4524 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4525
66c5eebd
CY
4526 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4527
1de11f56
CY
45282012-03-10 Chong Yidong <cyd@gnu.org>
4529
4530 * frame.c (other_visible_frames): Don't assume the selected frame
4531 is visible (Bug#10955).
4532
cae07000
SM
45332012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4534
4535 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4536
89c94350
JD
45372012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4538
4539 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4540 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4541 zero (Bug#10954).
4542
999dd333
GM
45432012-03-03 Glenn Morris <rgm@gnu.org>
4544
01a6dcc8 4545 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4546
de0100f2
EZ
45472012-03-02 Eli Zaretskii <eliz@gnu.org>
4548
4549 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4550 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4551 (redisplay_window, next_element_from_string): Fix typos in
4552 comments.
3e441275
EZ
4553 (redisplay_window): Pass to move_it_vertically the margin in
4554 pixels, not in screen lines.
de0100f2 4555
96a72ee9
GM
45562012-03-02 Glenn Morris <rgm@gnu.org>
4557
4558 * buffer.c (buffer-list-update-hook): Doc fix.
4559
312508d7
EZ
45602012-02-29 Eli Zaretskii <eliz@gnu.org>
4561
4562 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4563 push_it before setting up the iterator for the first overlay
4564 string, even if we have an empty string loaded.
4565 (next_overlay_string): If there's an empty string on the iterator
4566 stack, pop the stack. (Bug#10903)
4567
27f3c637
PE
45682012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4569
4570 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4571 Suggested by Stefan Monnier in
4572 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4573 * alloc.c (widen_to_Lisp_Object): New static function.
4574 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4575 and widening them to Lisp_Objects. This would work even if
4576 USE_LSB_TAG is defined and wide integers are used, which might
4577 happen in a future version of Emacs.
4578
3c9dfce6
CY
45792012-02-25 Chong Yidong <cyd@gnu.org>
4580
fa74b241
CY
4581 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4582 Doc fix.
4583
3c9dfce6
CY
4584 * xselect.c (Fx_selection_exists_p): Doc fix.
4585 (x_clipboard_manager_save_all): Print an informative message
4586 before saving to clipboard manager.
4587
9486df08
CY
45882012-02-24 Chong Yidong <cyd@gnu.org>
4589
4590 * keyboard.c (process_special_events): Handle all X selection
4591 requests in kbd_buffer, not just the next one (Bug#8869).
4592
f01d3321
CY
45932012-02-23 Chong Yidong <cyd@gnu.org>
4594
4595 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4596 call when setting menu-bar-lines and tool-bar-lines parameters.
4597 (unwind_create_frame_1): New helper function.
4598
4599 * window.c (inhibit_window_configuration_change_hook): New var.
4600 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4601 (syms_of_window): Initialize it.
f01d3321 4602
86b847b6
CY
46032012-02-22 Chong Yidong <cyd@gnu.org>
4604
4605 * xterm.c (x_draw_image_relief): Add missing type check for
4606 Vtool_bar_button_margin (Bug#10743).
4607
a59225b1
CY
46082012-02-21 Chong Yidong <cyd@gnu.org>
4609
4610 * fileio.c (Vfile_name_handler_alist): Doc fix.
4611
4612 * buffer.c (Fget_file_buffer): Protect against invalid file
4613 handler return value.
4614
310f5bd4
PE
46152012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4616
cb3a28cc
PE
4617 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4618 when computing $valmask.
4619
310f5bd4
PE
4620 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4621 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4622 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4623 It's useless in that case, and it can cause problems on hosts
4624 that allocate halves of EMACS_INT values separately.
4625 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4626 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4627 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4628 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4629 it avoids undefined behavior on hosts where shifting right by more
4630 than the word width has undefined behavior.
4631
2375c96a
CY
46322012-02-19 Chong Yidong <cyd@gnu.org>
4633
4634 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4635 (Funhandled_file_name_directory, Ffile_name_as_directory)
4636 (Fdirectory_file_name, Fexpand_file_name)
4637 (Fsubstitute_in_file_name): Protect against invalid file handler
4638 return values (Bug#10845).
4639
3eb49e71
EZ
46402012-02-18 Eli Zaretskii <eliz@gnu.org>
4641
4642 * .gdbinit (pitx): Fix incorrect references to fields of the
4643 iterator stack.
4644
7b926f3f
CY
46452012-02-17 Chong Yidong <cyd@gnu.org>
4646
4647 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4648
11273115
PE
46492012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4650
4651 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4652 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4653
c3a70e2b
CY
46542012-02-15 Chong Yidong <cyd@gnu.org>
4655
4656 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4657 marked as special. Also, starting docstrings with * is obsolete.
4658
0ca43699
AS
46592012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4660
4661 * gnutls.c (emacs_gnutls_write): Fix last change.
4662
2e8f3c56
LI
46632012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4664
4665 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4666 send_process.
4667
af70074f
SM
46682012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4669
4670 * keymap.c (Fsingle_key_description): Handle char ranges.
4671
95986d52
CY
46722012-02-12 Chong Yidong <cyd@gnu.org>
4673
afd83bd1
CY
4674 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4675 as that creates a dangerous corner case.
4676
95986d52
CY
4677 * window.c (Fdelete_window_internal): Invalidate the mouse
4678 highlight (Bug#9904).
4679
bd7da63e
GM
46802012-02-12 Glenn Morris <rgm@gnu.org>
4681
4682 * xselect.c (Fx_own_selection_internal)
4683 (Fx_get_selection_internal, Fx_disown_selection_internal)
4684 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4685 * nsselect.m (Fx_own_selection_internal)
4686 (Fx_disown_selection_internal, Fx_selection_exists_p)
4687 (Fx_selection_owner_p, Fx_get_selection_internal):
4688 Sync docs and argument specs with the xselect.c versions.
4689
77abcbc2
LI
46902012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4691
4692 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4693
90b671e2
EZ
46942012-02-11 Eli Zaretskii <eliz@gnu.org>
4695
1c0ca0b7
EZ
4696 * w32select.c (Fx_selection_exists_p): Sync doc string and
4697 argument list with xselect.c. (Bug#10783)
4698
4699 * w16select.c (Fx_selection_exists_p): Sync doc string and
4700 argument list with xselect.c. (Bug#10783)
90b671e2 4701
49241268
GM
47022012-02-10 Glenn Morris <rgm@gnu.org>
4703
4704 * fns.c (Fsecure_hash): Doc fix.
4705
f998bbe7 47062012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4707
4708 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4709
0992bd9c
CY
47102012-02-07 Chong Yidong <cyd@gnu.org>
4711
4712 * buffer.c (Fbuffer_local_variables)
4713 (buffer_lisp_local_variables): Handle unbound vars correctly;
4714 don't let Qunbound leak into Lisp.
4715
af008560
GM
47162012-02-07 Glenn Morris <rgm@gnu.org>
4717
dd605cc4
GM
4718 * image.c (Fimagemagick_types): Doc fix.
4719
af008560
GM
4720 * image.c (imagemagick-render-type): Change it from a lisp object
4721 to an integer. Move the doc here from the lisp manual.
4722 Treat all values not equal to 0 the same.
4723
1449fa1d
CY
47242012-02-06 Chong Yidong <cyd@gnu.org>
4725
4726 * doc.c (store_function_docstring): Avoid applying docstring of
4727 alias to base function (Bug#2603).
4728
3723ec07
AS
47292012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4730
4731 * .gdbinit (pp1, pv1): Remove redundant defines.
4732 (pr): Use pp.
4733
79c1cc1e
CY
47342012-02-04 Chong Yidong <cyd@gnu.org>
4735
4736 * nsterm.m: Declare a global (Bug#10694).
4737
d7f29f8e
EZ
47382012-02-04 Eli Zaretskii <eliz@gnu.org>
4739
cae07000
SM
4740 * w32.c (get_emacs_configuration_options):
4741 Include --enable-checking, if specified, in the return value.
d7f29f8e 4742
3b95a6f9
MR
47432012-02-04 Martin Rudalics <rudalics@gmx.at>
4744
4745 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4746 after rounding frame sizes. (Bug#9723)
4747
d6fa96a6
EZ
47482012-02-04 Eli Zaretskii <eliz@gnu.org>
4749
4750 * keyboard.c (adjust_point_for_property): Don't position point
4751 before BEGV. (Bug#10696)
4752
df0b2940
PE
47532012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4754
4755 Handle overflow when computing char display width (Bug#9496).
4756 * character.c (char_width): Return EMACS_INT, not int.
4757 (char_width, c_string_width): Check for overflow when
4758 computing the width; this is possible now that individual
4759 characters can have unbounded width. Problem introduced
4760 by merge from Emacs 23 on 2012-01-19.
4761
6bee44d6
MA
47622012-02-02 Michael Albinus <michael.albinus@gmx.de>
4763
4764 * dbusbind.c (Fdbus_register_method): Mention the return value
4765 :ignore in the docstring.
4766
44f92739
GM
47672012-02-02 Glenn Morris <rgm@gnu.org>
4768
1b9f60cc
GM
4769 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4770
44f92739
GM
4771 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4772 Unconditionally set to t. (Bug#10673)
4773 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4774 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4775 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4776
c5d3843c
KH
47772012-02-02 Kenichi Handa <handa@m17n.org>
4778
4779 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4780 0, do not call append_composite_glyph.
4781
159462d4 47822012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4783
4784 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4785 NULL (Bug#6988).
4786 (x_produce_glyphs): If the component of a composition is a null
4787 string, set it->pixel_width to 1 to avoid zero-width glyph.
4788
78cef877
EZ
47892012-02-01 Eli Zaretskii <eliz@gnu.org>
4790
4791 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4792 first 2 arguments are identical. This makes inserting large
4793 output from a subprocess an order of magnitude faster on
4794 MS-Windows, where all sbrk'ed memory is always contiguous.
4795
97897668
GM
47962012-01-31 Glenn Morris <rgm@gnu.org>
4797
4798 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4799 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4800 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4801
31fd3586
GM
48022012-01-29 Glenn Morris <rgm@gnu.org>
4803
4804 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4805
0e24a8b2
CY
48062012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4807
4808 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4809
cc0adcb0
CY
48102012-01-28 Chong Yidong <cyd@gnu.org>
4811
4812 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4813
acc28cb9
CY
48142012-01-26 Chong Yidong <cyd@gnu.org>
4815
9c69cfb7
CY
4816 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4817
acc28cb9
CY
4818 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4819 repeat counts (Bug#10507).
4820
48da7392
GM
48212012-01-26 Glenn Morris <rgm@gnu.org>
4822
4823 * lread.c (syms_of_lread): Doc fix.
4824
14af5f7f
CY
48252012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4826
4827 * coding.c (encode_designation_at_bol): Change return value to
4828 EMACS_INT.
4829
0b21c100
CY
48302012-01-25 Chong Yidong <cyd@gnu.org>
4831
4832 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4833
3c2907f7
CY
48342012-01-21 Chong Yidong <cyd@gnu.org>
4835
4836 * floatfns.c (Fcopysign): Make the second argument non-optional,
4837 since nil is not allowed anyway.
4838
959ad23f
AS
48392012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4840
4841 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4842 (send_process): Likewise.
4843
34a02f46
MR
48442012-01-19 Martin Rudalics <rudalics@gmx.at>
4845
4846 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4847 (Vwindow_persistent_parameters): Do not use Qstate.
4848 Rewrite doc-strings.
34a02f46 4849
1259009a 48502012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4851
4852 * character.c (char_width): New function.
70d4fdf6
GM
4853 (Fchar_width, c_string_width, lisp_string_width):
4854 Use char_width (Bug#9496).
25ed9e61 4855
6a6ee00d
MR
48562012-01-16 Martin Rudalics <rudalics@gmx.at>
4857
4858 * window.c (Vwindow_persistent_parameters): New variable.
4859 (Fset_window_configuration, save_window_save): Handle persistent
4860 window parameters.
4861
c85efaf7
EZ
48622012-01-14 Eli Zaretskii <eliz@gnu.org>
4863
4864 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4865 thrashing the stack of the thread. (Bug#9087)
4866
5944709e
PE
48672012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4868
4869 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4870
e71f5d99
EZ
48712012-01-11 Eli Zaretskii <eliz@gnu.org>
4872
4873 * xdisp.c (rows_from_pos_range): Handle the case where the
4874 highlight ends on a newline. (Bug#10464)
4875 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4876 he end column for display of highlight that ends on a newline
4877 before a R2L line.
4878
ce316182
GM
48792012-01-11 Glenn Morris <rgm@gnu.org>
4880
4881 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4882 from load-path also when installation-directory is nil. (Bug#10208)
4883
5b43da69
GM
48842012-01-10 Glenn Morris <rgm@gnu.org>
4885
74cc8ff9
GM
4886 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4887
7d8d6e4e
GM
4888 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4889 Update template values to be closer to their typical values these days.
5b43da69 4890
a0db8d43
EZ
48912012-01-09 Eli Zaretskii <eliz@gnu.org>
4892
4893 * xdisp.c (rows_from_pos_range): Accept additional argument
4894 DISP_STRING, and accept any glyph in a row whose object is that
4895 string as eligible for mouse highlight. Fixes mouse highlight of
4896 display strings from overlays. (Bug#10464)
4897
9a0115ab 48982012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4899
b9110d6a 4900 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4901 * fileio.c (auto_saving_dir_umask): New static var.
4902 (Fmake_directory_internal): Use it.
4903 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4904 creating the directory. The old code temporarily assigns
4905 too-generous permissions to the directory.
4906 (do_auto_save_eh): Clear it.
b9110d6a 4907 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4908 that the var is always cleared.
4909
6c1bd3f3
EZ
49102012-01-07 Eli Zaretskii <eliz@gnu.org>
4911
4912 * search.c (scan_buffer): Pass character positions to
4913 know_region_cache, not byte positions. (Bug#6540)
4914
069d2b50
L
49152012-01-07 LynX <_LynX@bk.ru> (tiny change)
4916
4917 * w32.c (sys_rename): Report EXDEV when rename of a directory
4918 fails because the target is on another logical disk. (Bug#10284)
4919
75bf0d33
DB
49202012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4921
4922 * xterm.c (x_embed_request_focus): New function.
4923
4924 * xterm.h: Add prototype.
4925
4926 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4927
1c6e5a32
GM
49282012-01-05 Glenn Morris <rgm@gnu.org>
4929
4930 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4931
651e947e
EZ
49322012-01-01 Eli Zaretskii <eliz@gnu.org>
4933
4934 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4935 Load gnutls_transport_set_lowat only if GnuTLS version is below
4936 2.11.1.
4937 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4938 GnuTLS versions below 2.11.1.
4939
3778cdd8
AL
49402011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4941
4942 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4943 to the doc string advising against its use for altering the way
4944 windows are scrolled.
4945
0e5317f7
KH
49462011-12-28 Kenichi Handa <handa@m17n.org>
4947
4948 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4949 coding-system ASCII compatible only when it does not produce BOM
4950 on encoding (Bug#10383).
4951
93d5ca1f
JD
49522011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4953
4954 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4955 can scroll.
4956 (create_and_show_popup_menu): Always use menu_position_func for
4957 Gtk3 (Bug#10361).
4958
ca22b785
AS
49592011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4960
4961 * callint.c (Fcall_interactively): Don't truncate prompt string.
4962
d048e1e6
EZ
49632011-12-23 Eli Zaretskii <eliz@gnu.org>
4964
4965 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4966 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4967 resumed from there (after widening). (Bug#10360)
d048e1e6 4968
5ccaba1f
JD
49692011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4970
4971 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4972
204ee57f
JD
49732011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4974
b81d40f0
JB
4975 * nsterm.m (x_free_frame_resources):
4976 Release f->output_data.ns->miniimage.
204ee57f
JD
4977 (ns_index_color): Fix indentation. Do not retain
4978 color_table->colors[i].
4979
4980 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4981 before returning.
4982
4983 * nsfns.m (x_set_background_color): Assign return value from
4984 ns_index_color to face-background instead of NSColor*.
4985 (ns_implicitly_set_icon_type): Fix indentation.
4986 Change assignment in for loop to comparison.
4987
4988 * emacs.c (ns_pool): New variable.
4989 (main): Assign ns_pool.
4990 (Fkill_emacs): Call ns_release_autorelease_pool.
4991
4992 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4993 autorelease fdesc, release fdAttrs and tdict.
4994 (ns_get_covering_families): Release charset.
4995 (ns_findfonts): Release NSFontDescriptor created with new.
4996 (ns_uni_to_glyphs): Fix indentation.
4997 (setString): Release attrStr before assigning new value.
4998
c803b2b7
JD
49992011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5000
678f4426
JD
5001 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5002 and NS_IMPL_COCOA.
5003 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5004 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5005
cd394be1 50062011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5007
5fecd5fc
JD
5008 * nsterm.m (ns_term_init): Subscribe for notifications
5009 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5010 to method trackingNotification in EmacsMenu.
5011
5012 * nsmenu.m (trackingMenu): New variable.
3771cb17 5013 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5014 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5015 from Aquamacs (Bug#7030).
678f4426
JD
5016
50172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5018
c803b2b7
JD
5019 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5020 (symbol_to_nsstring): Fix indentation.
5021 (ns_symbol_to_pb): New function.
cae07000
SM
5022 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5023 (Fns_rotate_cut_buffers_internal): Remove.
5024 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5025 Fns_store_cut_buffer_internal.
5026 (ns_get_foreign_selection, Fx_own_selection_internal)
5027 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5028 (Fns_get_selection_internal, Fns_store_selection_internal):
5029 Use ns_symbol_to_pb and check if return value is nil.
5030 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5031 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5032 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5033 renamed to Sns_store_selection_internal.
5034 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5035 and remove this function.
5036 (ns_handle_selection_clear): Remove, never used.
5037 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5038 here.
5039
e1b01a3a
KB
50402011-12-17 Ken Brown <kbrown@cornell.edu>
5041
5042 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5043 GID is unknown (Bug#10257).
5044
2adb6e85
PE
50452011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5046
5047 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5048 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5049 which caused a build failure on GNU/Linux IA-64. This problem was
5050 introduced by my 2011-10-07 patch.
5051
d1d7b339
JL
50522011-12-15 Juri Linkov <juri@jurta.org>
5053
5054 * image.c (imagemagick_error): New function. (Bug#10112)
5055 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5056 Use `imagemagick_error' where ImageMagick functions return
5057 `MagickFalse'.
5058 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5059 proper order.
5060
100d5755
KH
50612011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5062
5063 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5064 fill background (Bug#8992).
5065
454592a6
MR
50662011-12-13 Martin Rudalics <rudalics@gmx.at>
5067
5068 * window.c (Vwindow_combination_resize)
5069 (Vwindow_combination_limit): Use t instead of non-nil in
5070 doc-strings.
61d4b438
MR
5071 (Vrecenter_redisplay): Add first sentence of doc-string on
5072 separate line.
53524d93 5073 (Frecenter): Fix doc-string typo.
454592a6 5074
3633e3aa
KH
50752011-12-11 Kenichi Handa <handa@m17n.org>
5076
5077 * coding.c (Funencodable_char_position): Pay attention to the
5078 buffer text relocation (Bug#9389).
5079
7b9d523a 50802011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5081
7b9d523a
JD
5082 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5083 gtk_init (Bug#10100).
5084
b73189c6
EZ
50852011-12-10 Eli Zaretskii <eliz@gnu.org>
5086
5087 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5088 IT->string is nil. (Bug#10263)
5089
f7dfe5d6
JD
50902011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5091
83faebb4
JD
5092 * nsterm.h (x_free_frame_resources): Declare.
5093
f7dfe5d6
JD
5094 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5095 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5096
5097 * nsterm.h (ns_get_defaults_value): Declare.
5098
5099 * nsterm.m (ns_default): Call ns_get_defaults_value.
5100
7cd4e72c
EZ
51012011-12-09 Eli Zaretskii <eliz@gnu.org>
5102
5103 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5104 (Bug#10170)
5105
b34d7317
YM
51062011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5107
5108 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5109 that where the value of an _OBJC_* symbol points to is in the .bss
5110 section (Bug#10240).
5111
76470ad1
KH
51122011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5113
5114 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5115 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5116
745fff94
KH
51172011-12-08 Kenichi Handa <handa@m17n.org>
5118
5119 * ftfont.c (get_adstyle_property): Fix previous change
5120 (Bug#10233).
5121
6e44397c
JB
51222011-12-07 Juanma Barranquero <lekktu@gmail.com>
5123
5124 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5125 dirs from the default value of EMACSLOADPATH (bug#10208).
5126
7efa6272
GM
51272011-12-07 Glenn Morris <rgm@gnu.org>
5128
5129 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5130 installation and source directories as well. (Bug#10208)
5131
f6fc4d87
CY
51322011-12-06 Chong Yidong <cyd@gnu.org>
5133
5134 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5135
2bf26180
GM
51362011-12-06 Glenn Morris <rgm@gnu.org>
5137
5138 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5139 as an error, not just -1. (Bug#10217)
5140
3a6ad4f0
CY
51412011-12-05 Chong Yidong <cyd@gnu.org>
5142
5143 * keyboard.c (process_special_events): New function.
5144 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5145
75a3b399
PE
51462011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5147
5148 * coding.c (encode_designation_at_bol): Don't use uninitialized
5149 local variable (Bug#9318).
5150
c3c9e25e
KH
51512011-12-05 Kenichi Handa <handa@m17n.org>
5152
5153 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5154 return Qnil (Bug#8046, Bug#10193).
5155
5eb05ea3
KH
51562011-12-05 Kenichi Handa <handa@m17n.org>
5157
5158 * coding.c (encode_designation_at_bol): New args charbuf_end and
5159 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5160 (coding_set_source): Return how many bytes coding->source was
5161 relocated.
5162 (coding_set_destination): Return how many bytes
5163 coding->destination was relocated.
5164 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5165 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5166
51672011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5168
5169 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5170 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5171 macro (Bug#9318).
5172
51732011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5174
5175 The following changes are to fix Bug#9318.
5176
a79703f5 5177 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5178 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5179 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5180 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5181
7dbda6df
JB
51822011-12-05 Juanma Barranquero <lekktu@gmail.com>
5183
5184 * lisp.h (process_quit_flag): Fix external declaration.
5185
6d5eb5b0
SM
51862011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5187
5188 Don't macro-inline non-performance-critical code.
5189 * eval.c (process_quit_flag): New function.
5190 * lisp.h (QUIT): Use it.
5191
a0c3fad0
JD
51922011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5193
5194 * nsfns.m (get_geometry_from_preferences): New function.
5195 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5196
6c07aac2
AS
51972011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5198
5199 * emacs.c (Qkill_emacs): Define.
5200 (syms_of_emacs): Initialize it.
5201 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5202 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5203 (quit_throw_to_read_char): Add parameter `from_signal'.
5204 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5205 * lisp.h (QUIT): Call Fkill_emacs if requested.
5206
c052ead4
JD
52072011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5208
5209 * widget.c (update_wm_hints): Return if wmshell is null.
5210 (widget_update_wm_size_hints): New function.
5211
5212 * widget.h (widget_update_wm_size_hints): Declare.
5213
5214 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5215 widget_update_wm_size_hints (Bug#10104).
5216
9e49252b
EZ
52172011-12-03 Eli Zaretskii <eliz@gnu.org>
5218
5219 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5220 before a newline, prepare the bidi iterator for consuming the
5221 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5222 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5223
02b16839
JL
52242011-12-02 Juri Linkov <juri@jurta.org>
5225
5226 * search.c (Fword_search_regexp): New Lisp function created from
5227 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5228 (Fword_search_backward, Fword_search_forward)
5229 (Fword_search_backward_lax, Fword_search_forward_lax):
5230 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5231 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5232
0068070e
SM
52332011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5234
5235 * fileio.c (Finsert_file_contents): Move after-change-function call
5236 to before the "handled:" label, since all "goto handled" appear in
5237 cases where the *-change-functions have already been properly called
5238 (bug#10117).
5239
3360a3fc
AS
52402011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5241
5242 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5243 waiting for input. (Bug#10169)
5244
73d6c093
EZ
52452011-11-30 Eli Zaretskii <eliz@gnu.org>
5246
5247 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5248 verifies glyph row's hash code--we have just reallocated the
5249 glyphs, so their contents can be complete garbage. (Bug#10164)
5250
febe6bea
JB
52512011-11-30 Juanma Barranquero <lekktu@gmail.com>
5252
5253 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5254
801a4313
EZ
52552011-11-30 Eli Zaretskii <eliz@gnu.org>
5256
5257 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5258 attributes are tested _before_ calling verify_row_hash, to protect
5259 against GCC re-ordering of the tests. (Bug#10164)
5260
2b56b87e
JD
52612011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5262
5263 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5264
5265 * xterm.c (handle_one_xevent): Only set async_visible and friends
5266 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5267 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5268 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5269
dbf31225
PE
52702011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5271
5272 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5273 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5274 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5275 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5276 All uses changed to use GCPRO1 etc.
5277 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5278 Revert to old implementation (i.e., before 2011-03-11).
5279
1305621b
YM
52802011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5281
5282 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5283 of scroll runs so as to avoid assigning disabled bogus rows and
5284 unnecessary graphics copy operations.
5285
8c9afb46
EZ
52862011-11-27 Eli Zaretskii <eliz@gnu.org>
5287
5288 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5289 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5290 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5291 (malloc, free, realloc, calloc): Redirect to e_* only when
5292 compiling Emacs.
5293
5294 * lisp.h (GCTYPEBITS): Move before first use.
5295 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5296 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5297 this macro definition.
5298
5299 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5300 _MSC_VER.
5301
54e9e3bf
JD
53022011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5303
6d5eb5b0
SM
5304 * gtkutil.c (xg_create_frame_widgets):
5305 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5306 present with Gtk+ 2.0.
5307
83aca1cb
PE
53082011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5309
5310 * fileio.c (Finsert_file_contents): Undo previous change; see
5311 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5312
5b76caa4
PE
53132011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5314
5315 Rename locals to avoid shadowing.
5316 * fileio.c (Finsert_file_contents):
5317 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5318 * process.c (wait_reading_process_output):
5319 Rename inner 'proc' to 'p' to avoid shadowing.
5320 Indent for consistency with usual Emacs style.
5321
8c535114
EZ
53222011-11-25 Eli Zaretskii <eliz@gnu.org>
5323
5324 * xdisp.c (redisplay_window): If cursor row is not fully visible
5325 after recentering, and scroll-conservatively is set to a large
5326 number, scroll window by a few more lines to make the cursor fully
5327 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5328 (start_display): Don't move to the next line if the display should
5329 start at a newline that is part of a display vector or an overlay
5330 string. (Bug#10119)
8c535114 5331
fa4fdb5c
JL
53322011-11-24 Juri Linkov <juri@jurta.org>
5333
5334 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5335 after the `MagickPingImage' call. (Bug#10112)
5336
90ec88df
CY
53372011-11-23 Chong Yidong <cyd@gnu.org>
5338
5339 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5340
56e2e794
MR
53412011-11-23 Martin Rudalics <rudalics@gmx.at>
5342
5343 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5344 making another buffer current. (Bug#10114)
5345
b6e64c41
GM
53462011-11-23 Glenn Morris <rgm@gnu.org>
5347
5348 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5349
6b21de18
CY
53502011-11-23 Chong Yidong <cyd@gnu.org>
5351
5352 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5353 using it (Bug#5984).
5354
b12cd789
EZ
53552011-11-22 Eli Zaretskii <eliz@gnu.org>
5356
5357 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5358 and header-lines, as they don't have one computed for them.
5359 (Bug#10098)
5360
5361 * .gdbinit (prow): Make displayed values more self-explaining.
5362 Add row's hash code.
5363
261b6fd4
LMI
53642011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5365
5366 * process.c (wait_reading_process_output): Fix asynchrounous
5367 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5368 (wait_reading_process_output): Add comment and URL.
261b6fd4 5369
e7cfd277
JD
53702011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5371
5372 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5373
a9b9b7f5
CY
53742011-11-21 Chong Yidong <cyd@gnu.org>
5375
5376 * window.c (Fnext_window, Fprevious_window): Doc fix.
5377
b0d15b4f
SM
53782011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5379
5380 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5381
fe7a3057
JB
53822011-11-20 Juanma Barranquero <lekktu@gmail.com>
5383
5384 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5385
d2999b1a
MR
53862011-11-20 Martin Rudalics <rudalics@gmx.at>
5387
5388 * window.c (Fset_window_combination_limit): Rename argument
5389 STATUS to LIMIT.
5390 (Vwindow_combination_limit): Remove "status" from doc-string.
5391
d5ff9cd0
AS
53922011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5393
5394 * m/ibms390.h: Remove.
5395 * m/ibms390x.h: Don't include "ibms390.h".
5396
a5bb9bd3
SM
53972011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5398
5399 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5400 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5401
cd1181db
JB
54022011-11-20 Juanma Barranquero <lekktu@gmail.com>
5403
5404 * casetab.c (Fset_case_table):
5405 * charset.c (Fcharset_after): Fix typos.
5406
615a3b8d 54072011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5408
17e845af
PE
5409 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5410 Otherwise, valgrind does not work on some platforms.
5411 Problem reported by Andreas Schwab in
6a0bf43d
PE
5412 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5413 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5414 is set, removing the need for VIRT_ADDRESS_VARIES.
5415 (PURE_P): Use a more-efficient implementation that needs just one
5416 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5417 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5418 to 4 (xorl, subq, cmpq, setbe).
5419 * alloc.c (pure): Always extern now, since that's the
5420 VIRT_ADDR_VARIES behavior.
5421 (PURE_POINTER_P): Use a single comparison, not two, for
5422 consistency with the new puresize.h.
5423 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5424 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5425 Remove VIRT_ADDR_VARIES no longer needed.
5426
f8fe6f96
EZ
54272011-11-19 Eli Zaretskii <eliz@gnu.org>
5428
5429 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5430 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5431 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5432 behave as if the cursor position were at the window margin.
5433
5434 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5435 and the cursor position is out of bounds, behave as if the cursor
5436 position were at the window margin. (Bug#10075)
5437
df05a53c
CY
54382011-11-18 Chong Yidong <cyd@gnu.org>
5439
5440 * window.c (Fwindow_combination_limit): Make first argument
5441 non-optional, since it is meaningless for live windows like the
5442 selected window.
61ccba97 5443
2071918e
DA
54442011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5445
5446 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5447
b50a28de
SM
54482011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5449
5450 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5451 (graft_intervals_into_buffer): Simplify.
5452
015137db
EZ
54532011-11-18 Eli Zaretskii <eliz@gnu.org>
5454
5455 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5456 hash values of the two rows.
5457 (copy_row_except_pointers): Preserve the used[] arrays and the
5458 hash values of the two rows. (Bug#10035)
68c95424 5459 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5460
5461 * xdisp.c (row_hash): New function, body extracted from
5462 compute_line_metrics.
5463 (compute_line_metrics): Call row_hash, instead of computing the
5464 hash code inline.
5465
5466 * dispnew.c (verify_row_hash): Call row_hash for computing the
5467 hash code of a row, instead of duplicating code from xdisp.c.
5468
5469 * dispextern.h (row_hash): Add prototype.
5470
a2addb04
TH
54712011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5472
5473 * frame.c (delete_frame): Don't delete the terminal when the last
5474 X frame is closed if emacs is built with GTK toolkit.
5475
df85d315
JB
54762011-11-17 Juanma Barranquero <lekktu@gmail.com>
5477
5478 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5479
a0c2d0ae
MR
54802011-11-17 Martin Rudalics <rudalics@gmx.at>
5481
5482 * window.c (Vwindow_splits): Rename to
5483 Vwindow_combination_resize. Suggested by Juri Linkov.
5484 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5485 of Vwindow_splits.
5486
58179cce
JB
54872011-11-16 Juanma Barranquero <lekktu@gmail.com>
5488
7877f373
JB
5489 * nsfns.m (Fns_font_name):
5490 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5491
b6f67890
MR
54922011-11-16 Martin Rudalics <rudalics@gmx.at>
5493
5494 * window.h (window): Rename slot "nest" to "combination_limit".
5495 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5496 (Fset_window_nest): Rename to Fset_window_combination_limit.
5497 (Vwindow_nest): Rename to Vwindow_combination_limit.
5498 (recombine_windows, make_parent_window, make_window)
5499 (Fsplit_window_internal, saved_window)
5500 (Fset_window_configuration, save_window_save): Rename all
5501 occurrences of window_nest to window_combination_limit.
5502
c7015153
JB
55032011-11-15 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * image.c (imagemagick_load_image): Fix typo.
5506
322ad6ec
EZ
55072011-11-14 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (display_line): Move the call to
5510 highlight_trailing_whitespace before the call to
5511 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5512 faces of all the glyphs to compute ROW's hash value.
5513 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5514
f067b8ec
JB
55152011-11-14 Juanma Barranquero <lekktu@gmail.com>
5516
5517 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5518 just return (bug#10044).
5519
1e5b2111
EZ
55202011-11-12 Eli Zaretskii <eliz@gnu.org>
5521
7ef3cbd5
EZ
5522 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5523 with user-defined heap size. Bump the default size of the temacs
5524 heap to 27MB, to avoid memory warning when running temacs.
5525 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5526
1e5b2111
EZ
5527 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5528 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5529 (verify_row_hash) [XASSERTS]: New function.
5530 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5531 that the hash value of glyph rows is correct.
1e5b2111 5532
89d61221
MR
55332011-11-12 Martin Rudalics <rudalics@gmx.at>
5534
5535 * window.h (window): Remove splits slot.
5536 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5537 (Fdelete_other_windows_internal, make_parent_window)
5538 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5539 (Fset_window_configuration, save_window_save): Don't deal with
5540 split status of windows.
5541 (saved_window): Remove splits slot.
5542 (Vwindow_splits): Rewrite doc-string.
5543
97f18cc8
JD
55442011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5545
5546 * xfns.c (unwind_create_frame):
5547 * nsfns.m (unwind_create_frame):
5548 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5549 Vframe_list (Bug#9999).
5550
22a648b4
DA
55512011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5552
0b381c7e 5553 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5554
659afede
KH
55552011-11-11 Kenichi Handa <handa@m17n.org>
5556
5557 * callproc.c (Fcall_process): Set the member dst_multibyte of
5558 process_coding.
5559
9ac0394b
KH
55602011-11-11 Johan Bockgård <bojohan@gnu.org>
5561
5562 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5563 avoid a crash (bug#9496).
5564
2fbdc249
CY
55652011-11-09 Chong Yidong <cyd@gnu.org>
5566
5567 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5568 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5569
ac6b1f81
PE
55702011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5573
09db192c
PE
55742011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5575
5576 Avoid some portability problems by eschewing 'extern inline' functions.
5577 The trivial performance wins aren't worth the portability hassles; see
5578 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5579 et seq.
5580 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5581 (window_box_width, window_box_left, window_box_left_offset)
5582 (window_box_right, window_box_right_offset): Undo previous change,
5583 by removing the "extern"s.
5584 * intervals.c (adjust_intervals_for_insertion)
5585 (adjust_intervals_for_deletion): Undo previous change,
5586 making these static again.
5587 (offset_intervals, temp_set_point_both, temp_set_point)
5588 (copy_intervals_to_string): No longer inline.
5589 * xdisp.c (window_text_bottom_y, window_box_width)
5590 (window_box_height, window_box_left_offset)
5591 (window_box_right_offset, window_box_left, window_box_right)
5592 (window_box): No longer inline.
5593
105216ed
CY
55942011-11-08 Chong Yidong <cyd@gnu.org>
5595
5596 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5597 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5598 Signal an error if not a live window.
105216ed
CY
5599 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5600 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5601
ae9e237f
JB
56022011-11-07 Juanma Barranquero <lekktu@gmail.com>
5603
5604 * lisp.h (syms_of_abbrev): Remove declaration.
5605 Reported by CHENG Gao <chenggao@royau.me>.
5606
c7aa8333
EZ
56072011-11-07 Eli Zaretskii <eliz@gnu.org>
5608
5609 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5610 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5611 of temacs in GUI mode.
5612
be7f5545
MR
56132011-11-07 Martin Rudalics <rudalics@gmx.at>
5614
5615 * window.h: Declare delete_all_child_windows instead of
5616 delete_all_subwindows.
5617 * window.c (Fwindow_nest, Fset_window_nest)
5618 (Fset_window_new_total, Fset_window_new_normal)
5619 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5620 (delete_all_subwindows): Rename to delete_all_child_windows.
5621 (Fdelete_other_windows_internal, Fset_window_configuration):
5622 Call delete_all_child_windows instead of delete_all_subwindows.
5623 * frame.c (delete_frame): Call delete_all_child_windows instead
5624 of delete_all_subwindows.
5625
ca78dc43
PE
56262011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5627
5628 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5629 This is also needed for porting to any host where GC_MARK_STACK is
5630 not GC_MAKE_GCPROS_NOOPS.
5631 (which_symbols): Use it.
5632
a0241d01
KH
56332011-11-07 Kenichi Handa <handa@m17n.org>
5634
5635 * coding.c (coding_set_destination): Check coding->src_pos only
5636 when coding->src_object is a buffer (bug#9910).
5637
5638 * process.c (send_process): Set the member src_multibyte of coding
5639 to 0 (bug#9911) when sending a unibyte text.
5640
5641 * callproc.c (Fcall_process): Set the member src_multibyte of
5642 process_coding to 0 (bug#9912).
5643
a64bfdfa 56442011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5645
5646 * xmenu.c (cleanup_widget_value_tree): New function.
5647 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5648 calling free_menubar_widget_value_tree directly (Bug#9830).
5649
cb41b32a
PE
56502011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5651
5652 Fix some portability problems with 'inline'.
5653 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5654 (window_box_width, window_box_left, window_box_left_offset)
5655 (window_box_right, window_box_right_offset): Declare extern.
5656 Otherwise, these inline functions do not conform to C99 and
5657 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5658 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5659 * intervals.c (adjust_intervals_for_insertion)
5660 (adjust_intervals_for_deletion): Now extern, because otherwise the
5661 extern inline functions 'offset_intervals' couldn't refer to it.
5662 (static_offset_intervals): Remove.
5663 (offset_intervals): Rewrite using the old contents of
5664 static_offset_intervals. The old version didn't conform to C99
5665 because an extern inline function contained a reference to an
5666 identifier with static linkage.
5667
b7041366
AS
56682011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5669
5670 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5671 GC.
5672
88a37c4d
EZ
56732011-11-06 Eli Zaretskii <eliz@gnu.org>
5674
5675 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5676 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5677 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5678 return Qleft_to_right.
5679
49745b39
CY
56802011-11-06 Chong Yidong <cyd@gnu.org>
5681
5682 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5683 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5684 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5685 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5686 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5687 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5688 (Fwindow_vscroll): Doc fix.
5689 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5690 argument, since it makes no sense to pass a live window and for
5691 consistency with window-child.
5692
1f05cd82
CS
56932011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5694
5695 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5696 support MSVC.
5697
22610910
JR
56982011-11-05 Jason Rumney <jasonr@gnu.org>
5699
5700 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5701 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5702 fonts (Bug#6029).
5703 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5704 bitwise arithmetic preventing use of unicode-sip and non-truetype
5705 opentype fonts.
5706
a06776b2
EZ
57072011-11-05 Eli Zaretskii <eliz@gnu.org>
5708
3ad924ba
EZ
5709 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5710 "emacs"-only part.
5711
a06776b2
EZ
5712 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5713 initialization code to keep similarity to xfns.c after changes
5714 from 2011-11-05.
5715
c9e7db78
JD
57162011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5717
a97f8f3f
JD
5718 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5719 (unwind_create_frame): New function (Bug#9943).
5720 (Fx_create_frame): Restructure code to be more similar to the one in
5721 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5722 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5723 Move terminal->reference_count++ just before making the frame official
5724 (Bug#9943).
5725
5726 * nsterm.m (x_free_frame_resources): New function.
5727 (x_destroy_window): Move code to x_free_frame_resources.
5728
c9e7db78 5729 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5730 (Fx_create_frame, x_create_tip_frame):
5731 Move terminal->reference_count++ just before making the frame
75f1671a 5732 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5733 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5734
a6fc3b5c
EZ
57352011-11-05 Eli Zaretskii <eliz@gnu.org>
5736
5737 Support MSVC build with newer versions of Visual Studio.
5738 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5739 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5740 nt/gmake.defs.
5741
5742 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5743 which are not supported by MSVC.
5744 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5745 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5746 bitfields.
5747 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5748 types in bitfields.
5749 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5750
5751 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5752
58179cce 57532011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5754
5755 Support MSVC build with newer versions of Visual Studio.
5756 * w32.c: Don't include w32api.h for MSVC.
5757 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5758
5759 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5760 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5761 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5762 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5763 e_* cousins.
5764 (alloca) [_MSC_VER]: Define to _alloca.
5765
5766 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5767
5768 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5769
a58c13ed
EZ
57702011-11-04 Eli Zaretskii <eliz@gnu.org>
5771
5772 * xdisp.c (note_mouse_highlight): If either of
5773 previous/next-single-property-change returns nil, treat that as
5774 the beginning or the end of the buffer. (Bug#9955)
5775
fe0b6370
JD
57762011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5777
a58c13ed 5778 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5779 label is not null (Bug#9951).
5780 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5781 may be NULL.
5782
89bd5ee1
EZ
57832011-11-04 Eli Zaretskii <eliz@gnu.org>
5784
5785 * window.c (Fwindow_body_size): Mention in the doc string that the
5786 return value is in frame's canonical units. (Bug#9949)
5787
84c3edb9
EZ
57882011-11-03 Eli Zaretskii <eliz@gnu.org>
5789
4e2fb5c7
EZ
5790 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5791
84c3edb9 5792 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5793 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5794 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5795
bc17a887
EZ
57962011-11-01 Eli Zaretskii <eliz@gnu.org>
5797
5798 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5799 Don't stop backward scan on the continuation glyph, even though
5800 its CHARPOS is positive.
6d5eb5b0
SM
5801 (mouse_face_from_buffer_pos, note_mouse_highlight):
5802 Rename cover_string to disp_string.
bc17a887 5803
4ee88440
MR
58042011-11-01 Martin Rudalics <rudalics@gmx.at>
5805
5806 * window.c (temp_output_buffer_show): Don't use
5807 Vtemp_buffer_show_specifiers.
5808 (Vtemp_buffer_show_specifiers): Remove unused variable.
5809
c2ff3c02
EZ
58102011-10-30 Eli Zaretskii <eliz@gnu.org>
5811
5812 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5813 past the beginning of the current glyph matrix.
5814
58179cce 58152011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5816
5817 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5818 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5819 HAVE_GTK3 (Bug#9869).
b77a6a7f 5820
3b574623
JD
5821 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5822 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5823
b77a6a7f
JD
5824 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5825
5826 * xterm.c: Declare x_handle_net_wm_state to return int.
5827 (handle_one_xevent): Check if we are iconified but don't have
5828 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5829 (get_current_wm_state): Return non-zero if not hidden,
5830 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5831 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5832 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5833 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5834
196e41e4
PE
58352011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5836
5837 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5838 so that this new function doesn't get optimized away by a
5839 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5840
021f2e1a
AS
58412011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5842
5843 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5844
8b058d44
EZ
58452011-10-29 Eli Zaretskii <eliz@gnu.org>
5846
5847 Fix the `xbytecode' command.
5848 * .gdbinit (xprintbytestr): New command.
b50a28de 5849 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5850 (xbytecode): Print the byte-code string as well.
5851
4452fb80
EZ
58522011-10-29 Kim Storm <storm@cua.dk>
5853
8b058d44
EZ
5854 * alloc.c (which_symbols): New function.
5855
21b72067
AS
58562011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5857
5858 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5859 line. (Bug#9903)
5860
83ed7b5c
GM
58612011-10-29 Glenn Morris <rgm@gnu.org>
5862
5863 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5864 Not clear what it was for, and it causes various bugs. (Bug#9839)
5865
5a7a728b
EZ
58662011-10-28 Eli Zaretskii <eliz@gnu.org>
5867
5868 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5869 possible random value that matches one of those tested as
5870 condition to clear the mouse face.
5871
d3d0842f
CY
58722011-10-28 Chong Yidong <cyd@gnu.org>
5873
5874 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5875
31b39d13
DN
58762011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5877
5878 * window.c (make_window): Initialize phys_cursor_on_p.
5879
9aba6043
SM
58802011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5881
5882 * lisp.h (struct Lisp_Symbol): Update comments.
5883
c20992f4
JB
58842011-10-28 Juanma Barranquero <lekktu@gmail.com>
5885
5886 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5887
db4f02f2
EZ
58882011-10-28 Eli Zaretskii <eliz@gnu.org>
5889
5890 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5891 <oslsachem@gmail.com> for helping to debug this.
5892
5893 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5894 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5895 (g_b_init_get_glyph_outline_w): New static variables.
5896 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5897 (GetGlyphOutlineW_Proc): New typedefs.
5898 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5899 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5900 New functions.
5901 (w32font_open_internal, compute_metrics):
5902 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5903 instead of calling the "wide" APIs directly.
5904
5905 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5906
5907 * w32.h (syms_of_w32font): Add prototype.
5908
87e68db4
JB
59092011-10-27 Juanma Barranquero <lekktu@gmail.com>
5910
5911 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5912 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5913 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5914 (Fmove_to_window_line): Doc fix.
5915
435c1d67
CY
59162011-10-27 Chong Yidong <cyd@gnu.org>
5917
5918 * process.c (make_process): Set gnutls_state to NULL.
5919
5920 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5921 non-NULL, regardless of GNUTLS_INITSTAGE.
5922 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5923 an error. Set process slots as soon as we allocate them.
5924
5925 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5926
9c6c6f49
CY
59272011-10-27 Chong Yidong <cyd@gnu.org>
5928
9aba6043
SM
5929 * gnutls.c (emacs_gnutls_deinit): New function.
5930 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5931 (Fgnutls_deinit, Fgnutls_boot): Use it.
5932
5933 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5934 (deactivate_process): Call emacs_gnutls_deinit.
5935
657d08d3
JB
59362011-10-27 Juanma Barranquero <lekktu@gmail.com>
5937
5938 * image.c (x_create_x_image_and_pixmap):
5939 * w32.c (sys_rename, w32_delayed_load):
5940 * w32font.c (fill_in_logfont):
5941 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5942
5430d399
JB
59432011-10-26 Juanma Barranquero <lekktu@gmail.com>
5944
5945 * w32fns.c (w32_default_color_map): New function,
5946 extracted from Fw32_default_color_map.
a7ef684b 5947 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5948
fe0055fa
PE
59492011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5950
5951 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5952
e6346438
SM
59532011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5954
5955 * keyboard.c (test_undefined): New function (bug#9751).
5956 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5957
e112cc37
ET
59582011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5959
5960 * sysdep.c (init_sys_modes): Fix the check for the controlling
5961 terminal (Bug#6649).
5962
7b5d6677
EZ
59632011-10-20 Eli Zaretskii <eliz@gnu.org>
5964
5965 * dispextern.h (struct bidi_it): New member next_en_type.
5966
5967 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5968 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5969 current character, check also for next_en_type being WEAK_EN.
5970 (bidi_resolve_weak): Don't enter the expensive loop if the current
5971 position is before next_en_pos. Record the bidi type of the first
5972 non-ET, non-BN character we find, in addition to its position.
5973 (bidi_level_of_next_char): Invalidate next_en_type when
5974 next_en_pos is over-stepped.
5975
7da0b018
PE
59762011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5979 * editfns.c: Rewrite current-time-zone so that it invokes
5980 the equivalent of (format-time-string "%Z") to get the time zone name.
5981 This fixes a bug when the time zone name contains characters that
5982 need converting from the system time locale to Emacs internal format.
5983 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5984 that patch fixed format-time-string to do the conversion, but
5985 I forgot to fix current-time-zone.
5986 (format_time_string): New function, containing most of
5987 what Fformat_time_string used to contain.
5988 (Fformat_time_string): Rewrite in terms of format_time_string.
5989 This doesn't change this function's behavior.
5990 (current-time-zone): Rewrite to use format_time_string.
5991 This fixes the bug reported by Michael Schierl in
5992 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5993 Jason Rumney's 2007-06-07 change worked around this bug, but
5994 didn't fix it.
5995 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5996
8547b010
EZ
59972011-10-19 Eli Zaretskii <eliz@gnu.org>
5998
5999 * xdisp.c (start_display): If the character at POS is displayed
6000 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6001 (try_window_reusing_current_matrix): If a line ends in a display
6002 vector or the next line starts in a display vector, continue
6003 redrawing the window even though the character position of
6004 start_row was reached.
8547b010
EZ
6005 (Bug#9771, part 2)
6006
4e948d15
CY
60072011-10-18 Chong Yidong <cyd@gnu.org>
6008
6009 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6010 with nobreak-char-display too.
6011
4787455f
EZ
60122011-10-18 Eli Zaretskii <eliz@gnu.org>
6013
6014 Fix part 3 of bug#9771.
6015 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6016 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6017 non-neutral characters if the current character is a paragraph
6018 separator (a.k.a. Newline). This avoids running the same
6019 expensive loop twice, once when we consume the preceding newline
6020 and the other time when the line actually needs to be displayed.
6021 Avoid the loop when we see neutrals on the base embedding level
6022 following a character whose directionality is the same as the
6023 paragraph's. This avoids running the expensive loop when a line
6024 ends in a long sequence of neutrals, like control characters.
6025 Add assertion against STRONG_AL type. Slightly rearrange code
6026 that determines the type of a neutral given the first non-neutral
6027 that follows it.
6028 (bidi_level_of_next_char): Set next_en_pos to zero when
6029 invalidating its info.
6030
2c91f553
EZ
60312011-10-17 Eli Zaretskii <eliz@gnu.org>
6032
6033 * xdisp.c (push_display_prop): Determine whether to record string
6034 or buffer position by IT->string, not by IT->method. Allow
6035 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6036 (move_it_vertically_backward): Don't look for character position
6037 immediately after the newline when in a continuation line.
6038 (Bug#9771, part 1)
2c91f553 6039
c7b08b0d
MR
60402011-10-15 Martin Rudalics <rudalics@gmx.at>
6041
6042 * window.c (coordinates_in_window): Rewrite and delabelize
6043 vertical border check. (Bug#5357) (Bug#9618)
6044
6b02f655
SM
60452011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6046
6047 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6048 errors in XSetWindowBorder (bug#9310).
6049
81d40c92
DA
60502011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6051
6052 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6053 avoid crash when xmalloc overrun checking is enabled.
6054
d4172c3b
EZ
60552011-10-13 Eli Zaretskii <eliz@gnu.org>
6056
6057 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6058 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6059 cursor motion with <left> and <right> arrow keys.
6060
6061 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6062 some callers set that themselves.
6063
b00eea75
EZ
60642011-10-12 Eli Zaretskii <eliz@gnu.org>
6065
6066 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6067 display string and the previous row comes from the same string and
6068 is empty. (Bug#9739) (Bug#9738)
6069
8fe012c4
SM
60702011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6071
6072 * doc.c (get_doc_string): Encode file name (bug#9735).
6073
0074aef2
EZ
60742011-10-12 Eli Zaretskii <eliz@gnu.org>
6075
79beb178
EZ
6076 * bidi.c (bidi_level_of_next_char):
6077 * xdisp.c (get_visually_first_element): Remove old incorrect
6078 comments regarding the Unicode Line Separator character.
6079
0074aef2
EZ
6080 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6081
6e4b3fbe
DA
60822011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6083
6084 * alloc.c (Fgc_status): Do not access beyond zombies array
6085 boundary if nzombies > MAX_ZOMBIES.
6086 * alloc.c (dump_zombies): Add missing format specifier.
6087
0324f3af
PE
60882011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6089
b5525cac
PE
6090 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6091 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6092
0324f3af
PE
6093 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6094 Some packages use them to denote characters with modifiers.
6095
e9b5f888
AS
60962011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6097
6098 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6099 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6100 matching a pp-number. Rename parameter var to var1.
6101
127827c0
SM
61022011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6103
6104 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6105
c8fd3bd0
GM
61062011-10-08 Glenn Morris <rgm@gnu.org>
6107
6108 * callint.c (Fcall_interactively): Give a more explicit error for the
6109 'c' case with a non-character input. (Bug#8479)
6110
352ec8ff
EZ
61112011-10-08 Eli Zaretskii <eliz@gnu.org>
6112
03669ccb
EZ
6113 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6114 lines.
7061c986
EZ
6115 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6116 lines that are hscrolled on the left.
03669ccb 6117
352ec8ff
EZ
6118 * dispnew.c (buffer_posn_from_coords): Account for a possible
6119 presence of header-line. (Bug#4426)
6120
a66cfb1c
SM
61212011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6122
6b02f655
SM
6123 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6124 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6125
7c5ee88e
PE
61262011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6127
6128 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6129 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6130 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6131 this makes Emacs dump core during garbage collection on rare
6132 occasions. sizeof is obviously inferior to offsetof here, so
6133 stick with offsetof.
6134 (GC_POINTER_ALIGNMENT): New macro.
6135 (mark_memory): Omit 3rd (offset) arg; caller changed.
6136 Don't assume EMACS_INT alignment is the same as pointer alignment.
6137
df1bbe5b
SM
61382011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6139
6140 * keyboard.c (read_key_sequence_remapped): New var.
6141 (read_key_sequence): Compute remapping in the right buffer.
6142 (command_loop_1): Use read_key_sequence's remapping directly.
6143
51553db6
SM
61442011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6145
32c1fffd
SM
6146 * dired.c (file_name_completion): Don't expand file name.
6147 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6148 before checking file name handler.
6149
51553db6
SM
6150 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6151 they've been requested explicitly (bug#9591).
6152
b6bd1599 61532011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6154
6155 * keymap.c (Fsingle_key_description): Use make_specified_string
6156 instead of build_string to build string from push_key_description.
6157 (Bug#5193)
6158
f701dc2a
PE
61592011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6160
4222c55d
PE
6161 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6162 This fixes a Y2038 bug on 64-bit hosts.
6163 * buffer.c (reset_buffer):
6164 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6165 (Fclear_buffer_auto_save_failure):
6166 Use 0, not -1, to represent an unset failure time, since time_t
6167 might not be signed.
6168
f701dc2a
PE
6169 Remove dependency on glibc malloc internals.
6170 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6171 Move back here from lisp.h, but with their new implementations.
6172 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6173 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6174 * charset.c (charset_table_init): New static var.
6175 (syms_of_charset): Use it instead of xmalloc. This removes a
6176 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6177 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6178 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6179 Move back to alloc.c.
6180 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6181 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6182
9ceebf39
JD
61832011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6184
6185 * nsterm.m (windowDidResize): Call x_set_window_size only when
6186 ns_in_resize is true. Otherwise set pixelwidth/height and
6187 call change_frame_size (Bug#9628).
6188
cb993c58
PE
61892011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6190
3930c88b
PE
6191 Port --enable-checking=all to Fedora 14 x86-64.
6192 * charset.c (syms_of_charset): Also account for glibc malloc's
6193 internal overhead when calculating the initial malloc maximum.
6194
cb993c58
PE
6195 Port --enable-checking=all to Fedora 14 x86.
6196 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6197 Move to lisp.h.
6198 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6199 (overrun_check_realloc, overrun_check_free):
6200 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6201 That way, xmalloc returns a properly-aligned pointer even if
6202 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6203 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6204 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6205 into account when calculating the initial malloc maximum.
6206 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6207 Move here from alloc.c, so that charset.c can use it too.
6208 Properly align; the old code wasn't right for common 32-bit hosts
6209 when configured with --enable-checking=all.
6210 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6211 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6212
31bed486
EZ
62132011-09-29 Eli Zaretskii <eliz@gnu.org>
6214
04c70788 6215 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6216 use EDOM.
6217
fbcaa2f3
EZ
62182011-09-28 Eli Zaretskii <eliz@gnu.org>
6219
6220 * xdisp.c (compute_display_string_end): If there's no display
6221 string at CHARPOS, return -1.
6222
6223 * bidi.c (bidi_fetch_char): When compute_display_string_end
6224 returns a negative value, treat the character as a normal
6225 character not covered by a display string. (Bug#9624)
6226
a239d4e9
JB
62272011-09-28 Juanma Barranquero <lekktu@gmail.com>
6228
6229 * lread.c (Fread_from_string): Fix typo in docstring.
6230
88652fd5
EZ
62312011-09-27 Eli Zaretskii <eliz@gnu.org>
6232
6233 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6234 newline, reseat the iterator instead of bidi-iterating there one
6235 character at a time. (Bug#9610)
32c1fffd
SM
6236 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6237 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6238
ed497dd4
AS
62392011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6240
6241 * lread.c (readevalloop): Use correct code for NBSP.
6242 (read1): Likewise. (Bug#9608)
6243
b2bf61aa
MA
62442011-09-25 Michael Albinus <michael.albinus@gmx.de>
6245
6246 * dbusbind.c (Fdbus_register_signal): When service is not
6247 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6248
32bbb17c
GM
62492011-09-25 Glenn Morris <rgm@gnu.org>
6250
6251 * buffer.c (truncate-lines): Doc fix.
6252
94e0933e
CY
62532011-09-24 Chong Yidong <cyd@stupidchicken.com>
6254
6255 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6256 (Fset_window_next_buffers): Doc fix.
6257
cddde921
GM
62582011-09-24 Glenn Morris <rgm@gnu.org>
6259
6260 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6261
1260aef1
PE
62622011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6263
25b4bfa0
PE
6264 Fix minor problems found by static checking.
6265 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6266 * indent.c (Fvertical_motion): Fix == vs = typo.
6267
e3cbd34b
EZ
62682011-09-24 Eli Zaretskii <eliz@gnu.org>
6269
a66cfb1c
SM
6270 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6271 Default value is now t. Doc fix.
6bf7006f 6272
e3cbd34b 6273 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6274 logic when moving up, not only when moving down. Fix the
e3cbd34b 6275 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6276 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6277
6278 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6279 CHARPOS is covered by a display string which includes newlines.
6280 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6281 is covered by a display string with embedded newlines.
6282
a3de0cbd
MA
62832011-09-24 Michael Albinus <michael.albinus@gmx.de>
6284
6285 * dbusbind.c (Fdbus_register_signal): Add match rule to
6286 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6287 (Fdbus_register_method, Vdbus_registered_objects_table):
6288 Fix docstring.
a3de0cbd 6289
b260039d
JM
62902011-09-24 Jim Meyering <meyering@redhat.com>
6291
32c1fffd 6292 do not ignore write error for any output size
b260039d
JM
6293 The previous change was incomplete.
6294 While it makes emacs --batch detect the vast majority of stdout
6295 write failures, errors were still ignored whenever the output size is
6296 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6297 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6298 && echo FAIL: ignored write error
6299 FAIL: ignored write error
6300 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6301 && echo FAIL: ignored write error
6302 FAIL: ignored write error
6303 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6304
8eca8a7c
AS
63052011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6306
6307 * emacs.c (Fkill_emacs): In noninteractive mode exit
6308 non-successfully if a write error occurred on stdout. (Bug#9574)
6309
3341db62
EZ
63102011-09-21 Eli Zaretskii <eliz@gnu.org>
6311
6312 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6313 the xassert test.
6314
6315 * dispextern.h (struct it): Update the comment documenting what
6316 can it->OBJECT be.
6317
8c203dbf
EZ
63182011-09-20 Eli Zaretskii <eliz@gnu.org>
6319
6320 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6321 a display string, extend search for cursor position to end of row.
6322 (find_row_edges): If the row ends in a newline from a display
6323 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6324 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6325 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6326 non-empty line. Fixes confusing cursor motion with arrow keys at
6327 the beginning of a line that starts with whitespace.
8c203dbf 6328
a4824228
LMI
63292011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6330
6331 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6332 (bug#9493).
6333
33ed493b
CY
63342011-09-18 Chong Yidong <cyd@stupidchicken.com>
6335
6336 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6337 boolean (Bug#9154).
6338
56cd55c8
EZ
63392011-09-18 Eli Zaretskii <eliz@gnu.org>
6340
6341 * xdisp.c (display_line): Record maximum and minimum buffer
6342 positions even if no glyphs were produced (e.g., by a zero-width
6343 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6344 buffer positions that will be removed from the glyph row because
6345 they don't fit.
c02dcedf
EZ
6346 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6347 column is beyond frame width: don't subtract 1 "pixel" when
6348 computing width of the stretch.
3e62b7e0
EZ
6349 (reseat_at_next_visible_line_start): Undo the change made on
6350 2011-09-17 that saved paragraph information and restored it after
6351 the call to `reseat'. (Bug#9545)
56cd55c8 6352
5ed99d36 63532011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6354
6355 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6356 and turn window cursor on if cleared (Bug#9415).
6357
5ed99d36 63582011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6359
6360 * search.c (boyer_moore): Take unibyte characters from pattern
6361 literally. (Bug#9458)
6362
9bade7b2
EZ
63632011-09-18 Eli Zaretskii <eliz@gnu.org>
6364
6365 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6366
e5e9d610
PE
63672011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6368
87e4427a
PE
6369 Fix minor problem found by static checking.
6370 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6371 initialized, to pacify gcc -Wuninitialized.
6372
e5e9d610
PE
6373 * fileio.c: Report proper errno when syscall falls.
6374 (Finsert_file_contents): Save and restore errno,
6375 so that report_file_error outputs the correct diagnostic.
6376 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6377
a1674f0b
EZ
63782011-09-18 Eli Zaretskii <eliz@gnu.org>
6379
6380 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6381
fbfb6dd4
EZ
63822011-09-17 Eli Zaretskii <eliz@gnu.org>
6383
6384 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6385 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6386
bb187662
EZ
63872011-09-17 Eli Zaretskii <eliz@gnu.org>
6388
1137e8b8 6389 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6390 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6391
6392 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6393 (bidi_find_paragraph_start): Search back for paragraph beginning
6394 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6395 (bidi_move_to_visually_next): Only trigger paragraph-related
6396 computations when the last character is a newline or at EOB, not
6397 just any NEUTRAL_B. (Bug#9470)
6398
bb187662
EZ
6399 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6400 truncated lines if point is covered by a display string. (Bug#9524)
6401
2e621251
PE
64022011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6403
6404 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6405 (cons_to_x_long): New function.
6406 (lisp_data_to_selection_data): Use it. Correct the test for
6407 short-versus-long data; it was negated. Break out of vector
6408 loop, for efficiency, when a long datum is discovered.
6409
91a15bc6
SM
64102011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6411
6412 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6413
b41c3a35
EZ
64142011-09-16 Eli Zaretskii <eliz@gnu.org>
6415
6416 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6417 GCC PR/17406) by declaring this function with external scope.
6418
7812ba2d
PE
64192011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6420
6421 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6422 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6423
cf7edc2a
AS
64242011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6425
6426 * editfns.c (Fformat): Correctly handle text properties on "%%".
6427
bd01620e
EZ
64282011-09-15 Eli Zaretskii <eliz@gnu.org>
6429
6430 * xterm.c (x_draw_composite_glyph_string_foreground):
6431 * w32term.c (x_draw_composite_glyph_string_foreground):
6432 * term.c (encode_terminal_code):
6433 * composite.c (composition_update_it, get_composition_id):
6434 * xdisp.c (get_next_display_element)
6435 (fill_composite_glyph_string): Add comments about special meaning
6436 of TAB characters in a composition.
6437
a02719a3
PE
64382011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6439
6440 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6441 This occurs when processing a multibyte format.
6442 Problem reported by Wolfgang Jenker.
a02719a3 6443
72589a3c
JB
64442011-09-15 Johan Bockgård <bojohan@gnu.org>
6445
6446 * xdisp.c (try_cursor_movement): Only check for exact match if
6447 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6448
1c14176c
PE
64492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6450
6451 Remove unused external symbols.
6452 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6453 * xdisp.c (calc_pixel_width_or_height): Now static.
6454 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6455 * indent.c (check_display_width):
6456 * w32term.c: Fix comment to match code.
6457 * xterm.c, xterm.h (x_catching_errors): Remove.
6458
d2eea5b5
PE
64592011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6460
6461 * xselect.c: Use signed conversions more consistently (Bug#9498).
6462 (selection_data_to_lisp_data): Assume incoming selection data are
6463 signed integers, not unsigned. This is to be consistent with
6464 outgoing selection data, which was modified to use signed integers
6465 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6466 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6467 expects long, not unsigned long.
6468
46888499
EZ
64692011-09-14 Eli Zaretskii <eliz@gnu.org>
6470
6471 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6472 computation of loop end. Reported by Johan Bockgård
6473 <bojohan@gnu.org>.
6474
ef8ef9fb
CY
64752011-09-13 Chong Yidong <cyd@stupidchicken.com>
6476
6477 * frame.c (Fother_visible_frames_p): Function deleted.
6478
fa819fed
EZ
64792011-09-12 Eli Zaretskii <eliz@gnu.org>
6480
6481 * indent.c (compute_motion): Process display vector front to back
6482 rather than the other way around. (Bug#2496)
6483
2ba8e008
SM
64842011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6485
6486 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6487
20f53c69
CY
64882011-09-11 Chong Yidong <cyd@stupidchicken.com>
6489
6490 * minibuf.c (Fread_from_minibuffer): Doc fix.
6491
d562d7a4
EZ
64922011-09-11 Eli Zaretskii <eliz@gnu.org>
6493
6494 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6495 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6496
1c4d7f3d
LMI
64972011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6498
6499 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6500 value for non-existent files.
6501
b885bf36
EZ
65022011-09-11 Eli Zaretskii <eliz@gnu.org>
6503
6504 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6505 set its "size" to -1. This will set the modtime_size field of
6506 the corresponding buffer to -1, which is what
6507 verify-visited-file-modtime expects for files that do not exist.
6508 (Bug#9139)
6509
6612f0bf
PE
65102011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6511
6512 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6513 here ...
6514 * lisp.h: ... from here. push_key_description is no longer
6515 defined in keyboard.c, so its declaration should not be in
6516 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6517 logically belongs with push_key_description.
6518
dfb3f755
PE
65192011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6520
6521 * buffer.h: Include <sys/types.h> instead of <time.h>.
6522 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6523 Problem reported by Herbert J. Skuhra.
6524
3134906c
LMI
65252011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6526
6527 * xml.c (parse_region): Make the parsing work for
6528 non-comment-starting XML files again (bug#9144).
6529
8d903f4e
AS
65302011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6531
6532 * image.c (gif_load): Fix calculation of bottom and right corner.
6533 (Bug#9468)
6534
80ad64f4
EZ
65352011-09-10 Eli Zaretskii <eliz@gnu.org>
6536
6537 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6538 redisplay in small windows.
6539
208a048d
EZ
65402011-09-09 Eli Zaretskii <eliz@gnu.org>
6541
6542 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6543
9b1c252e
MR
65442011-09-08 Martin Rudalics <rudalics@gmx.at>
6545
6546 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6547 Operate on live windows only.
6548
2949f33b
JB
65492011-09-08 Juanma Barranquero <lekktu@gmail.com>
6550
6551 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6552
e08dcafd
EZ
65532011-09-07 Eli Zaretskii <eliz@gnu.org>
6554
6555 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6556 only under bidi iteration.
6557
115b96bd
JD
65582011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6559
6560 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6561
c8199d0f
PE
65622011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6563
6564 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6565 Without this fix, the command to link temacs failed due to an
6566 undefined symbol __builtin_isnan. This is because
6567 /usr/include/iso/math_c99.h #defines isnan(x) to
6568 __builtin_isnan(x), but the bundled gcc, which identifies itself
6569 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6570 a __builtin_isnan.
6571 * floatfns.c (isnan): #undef, and then #define to a clone of
6572 what's in data.c.
6573 (Fisnan): Always define, since it's always available now.
6574 (syms_of_floatfns): Always define isnan at the Lisp level.
6575
e39b275c 65762011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6577
6578 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6579
b2db44d9 65802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6581
f4af5137 6582 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6583 The previous code assumed that file offsets (off_t values) fit in
6584 EMACS_INT variables, which is not true on typical 32-bit hosts.
6585 The code messed up by falsely reporting buffer overflow in cases
6586 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6587 when "big" contains more than 2**29 bytes, even though this
6588 inserts just one byte and does not overflow the buffer.
6589 (Finsert_file_contents): Store file offsets as off_t
6590 values, not as EMACS_INT values. Check for overflow when
6591 converting between EMACS_INT and off_t. When checking for
6592 buffer overflow or for overlap, take the offsets into account.
6593 Don't use EMACS_INT for small values where int suffices.
6594 When checking for overlap, fix a typo: ZV was used where
6595 ZV_BYTE was intended.
6596 (Fwrite_region): Don't assume off_t fits into 'long'.
6597 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6598
ecfc0a49
MA
65992011-09-05 Michael Albinus <michael.albinus@gmx.de>
6600
6601 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6602
6511acf2 66032011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6604
0999621a 6605 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6606
6607 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6608 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6609 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6610 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6611 (modify_event_symbol): Do not assume that the length of
6612 name_alist_or_stem is safe to alloca and fits in int.
6613 (Fexecute_extended_command): Likewise for function name and binding.
6614 (Frecursion_depth): Wrap around reliably on integer overflow.
6615 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6616 since some callers pass EMACS_INT values.
6617 (Fsingle_key_description): Don't crash if symbol name contains more
6618 than MAX_ALLOCA bytes.
6619 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6620 (get_minibuffer): Arg is now EMACS_INT, not int.
6621 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6622 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6623 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6624
2be7d702
PE
6625 * dbusbind.c (signature_cat): New function.
6626 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6627 Do not overrun buffer; instead, report string overflow.
6628
9d1df220
PE
6629 * dispnew.c (add_window_display_history): Don't overrun buffer.
6630 Truncate instead; this is OK since it's just a log.
6631
33ef5c64
PE
6632 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6633 even if the time zone offset is outlandishly large.
6634 Don't mishandle offset == INT_MIN.
6635
66c6fdd5
PE
6636 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6637 when creating daemon; the previous buffer-overflow check was incorrect.
6638
d749b01b
PE
6639 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6640 which has the guts of the old verror function.
6641
b5cd1905
PE
6642 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6643 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6644
6e1a67fb
PE
6645 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6646 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6647 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6648 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6649 length of string rather than counting it via multiple sprintfs;
6650 that's simpler and more reliable.
c21721cc
PE
6651 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6652 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6653 sprintf, in case result does not fit in int.
6654
c57b67fc
PE
6655 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6656 (fontset_from_font): Print it.
6657
8a401434
PE
6658 * frame.c (tty_frame_count): Now printmax_t, not int.
6659 (make_terminal_frame, set_term_frame_name): Print it.
6660 (x_report_frame_params): In X, window IDs are unsigned long,
6661 not signed long, so print them as unsigned.
6662 (validate_x_resource_name): Check for implausibly long names,
6663 and don't assume name length fits in 'int'.
6664 (x_get_resource_string): Don't blindly alloca invocation name;
6665 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6666 not fit in int.
6667
6e1a67fb
PE
6668 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6669 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6670 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6671
0df02bf3
PE
6672 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6673 Use esprintf, not sprintf, in case result does not fit in int.
6674
48e30793
PE
6675 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6676 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6677 it as a large positive number.
6678 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6679 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6680
a66ff6d8
PE
6681 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6682 in case result does not fit in int.
6683
aca216ff
PE
6684 * print.c (float_to_string): Detect width overflow more reliably.
6685 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6686 buffer overrun. Don't assume list length fits in 'int'. Treat
6687 print length of 0 as 0, not as infinity; to be consistent with other
6688 uses of print length in this function. Don't overflow print length
6689 index. Don't assume hash table size fits in 'long', or that
6690 vectorlike size fits in 'unsigned long'.
6691
31c286f7
PE
6692 * process.c (make_process): Use printmax_t, not int, to format
6693 process-name gensyms.
6694
55e5faa1
PE
6695 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6696
80f2e268
PE
6697 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6698 to avoid potential buffer overrun.
6699
670741ab
PE
6700 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6701 if X resource line is longer than 512 bytes.
6702
b7163a50
PE
6703 * xfns.c (x_window): Make sprintf buffer a bit bigger
6704 to avoid potential buffer overrun.
6705
ae58ff1f
PE
6706 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6707
c43c8a6a
PE
6708 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6709
3f8236f4
PE
67102011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6711
53e9fe90 6712 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6713 Without these, Emacs silently mishandles large integers sometimes.
6714 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6715 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6716
6511acf2
PE
6717 * xdisp.c (try_window_id): Check Emacs fixnum range before
6718 converting to 'int'.
806add1d 6719
6511acf2 6720 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6721 Check that an Emacs fixnum is in range before assigning it to 'int'.
6722 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6723 values converted from Emacs fixnums.
6724 (Frecenter): Don't wrap around a line count if it is out of 'int'
6725 range; instead, treat it as an extreme value.
6726 (Fset_window_configuration, compare_window_configurations):
6727 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6728
6511acf2
PE
6729 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6730 that can exceed INT_MAX. Check that EMACS_INT value is in range
6731 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6732 (match_limit): Don't assume that a fixnum can fit in 'int'.
6733
6511acf2 6734 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6735 exceed INT_MAX.
6736
6511acf2 6737 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6738 (Fvertical_motion): Don't wrap around LINES values that don't fit
6739 in 'int'. Instead, treat them as extreme values. This is good
6740 enough for windows, which can't have more than INT_MAX lines anyway.
6741
fcb901a7
LMI
67422011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6743
0f2f6b6d
LMI
6744 * Require libxml/parser.h to avoid compilation warning.
6745
fcb901a7
LMI
6746 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6747
6748 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6749 since this reportedly can destroy thread storage.
6750
6e20a0d4
CY
67512011-08-30 Chong Yidong <cyd@stupidchicken.com>
6752
6753 * syntax.c (find_defun_start): Update all cache variables if
6754 exiting early (Bug#9401).
6755
148ae00e
EZ
67562011-08-30 Eli Zaretskii <eliz@gnu.org>
6757
f6cfbd8f
EZ
6758 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6759
148ae00e
EZ
6760 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6761 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6762 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6763
6764 * term.c (tty_append_glyph): New function.
6765 (produce_stretch_glyph): Static function and its prototype deleted.
6766
a66cfb1c
SM
6767 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6768 Add prototypes.
148ae00e 6769
c4a07a4c
PE
67702011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6771
6772 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6773 when checking :margin (Bug#9390).
6774 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6775 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6776 so that the name doesn't mislead. All uses changed.
6777
6bc8cd65
JB
67782011-08-28 Johan Bockgård <bojohan@gnu.org>
6779
6780 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6781 set_tty_hooks.
6782
dca4927e
EZ
67832011-08-27 Eli Zaretskii <eliz@gnu.org>
6784
6785 * xdisp.c (move_it_to): Don't bail out early when reaching
6786 position beyond to_charpos, if we are scanning backwards.
6787 (move_it_vertically_backward): When DY == 0, make sure we get to
6788 the first character in the line after the newline.
6789
f2cad773
PE
67902011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6791
6792 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6793 (ccl_driver): Do not generate an out-of-range pointer.
6794 (Fccl_execute_on_string): Remove unnecessary check for
6795 integer overflow, noted by Stefan Monnier in
6796 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6797 Remove a FIXME that didn't need fixing.
6798 Simplify the newly-introduced buffer reallocation code.
6799
0cae2cdb
JB
68002011-08-27 Juanma Barranquero <lekktu@gmail.com>
6801
6802 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6803
5fc295a4 68042011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6805
70c60eb2 6806 Integer and memory overflow issues (Bug#9196).
726e0ab1 6807
d31850da
PE
6808 * doc.c (get_doc_string): Rework so that
6809 get_doc_string_buffer_size is the actual buffer size, rather than
6810 being 1 less than the actual buffer size; this makes xpalloc more
6811 convenient.
6812
a69fbedb
PE
6813 * image.c (x_allocate_bitmap_record, cache_image):
6814 * xselect.c (Fx_register_dnd_atom):
6815 Simplify previous changes by using xpalloc.
6816
fe5c5d37
PE
6817 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6818 since either will do and ptrdiff_t is convenient with xpalloc.
6819
0065d054
PE
6820 * charset.c (charset_table_size)
6821 (struct charset_sort_data.priority): Now ptrdiff_t.
6822 (charset_compare): Don't overflow if priorities differ greatly.
6823 (Fsort_charsets): Don't assume list length fits in int.
6824 Check for size-calculation overflow when allocating sort data.
6825 (syms_of_charset): Allocate an initial charset table that is
6826 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6827
6828 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6829
6830 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6831 The actual value is always <= INT_MAX, and leaving it unsigned made
6832 overflow checking harder.
6833
6834 * dispextern.h (struct glyph_matrix.rows_allocated)
6835 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6836 with xpalloc. The values are still always <= INT_MAX.
6837
6838 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6839
6840 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6841 (SAFE_NALLOCA): New macro.
6842
6843 * region-cache.c (struct boundary.pos, find_cache_boundary)
6844 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6845 (set_cache_region, invalidate_region_cache)
6846 (revalidate_region_cache, know_region_cache, region_cache_forward)
6847 (region_cache_backward, pp_cache):
6848 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6849 so that ptrdiff_t * can be passed to xpalloc.
6850 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6851 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6852 (pp_cache): Don't assume cache_len fits in int.
6853 * region-cache.h: Adjust extern decls to match.
6854
6855 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6856 EMACS_INT, since either will do, for xpalloc.
6857
6858 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6859 (xnmalloc, xnrealloc, xpalloc): New functions.
6860
726e0ab1
PE
6861 * bidi.c (bidi_shelve_header_size): New constant.
6862 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6863 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6864
51f30bc5 6865 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6866 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6867 (overlay_strings):
6868 Don't update size of array until after memory allocation succeeds,
6869 because xmalloc/xrealloc may not return.
0065d054
PE
6870 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6871 now that we have proper integer overflow checking.
6872 (record_overlay_string, overlay_strings): Catch overflows when
6873 calculating size of overlay_str_buf.
726e0ab1 6874
0065d054
PE
6875 * callproc.c (Fcall_process): Check for size overflow when
6876 calculating size of args2.
6877 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6878 Normally we prefer signed values, but sticking with ptrdiff_t would
6879 require adding more-complicated checks.
726e0ab1
PE
6880
6881 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6882 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6883 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6884 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6885
6886 * character.c (Fstring): Check for size-calculation overflow.
6887
6888 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6889 unnecessary integer overflow. Check for size overflow.
6890 (encode_coding_object): Don't update size until xmalloc succeeds.
6891
6892 * composite.c (get_composition_id): Check for overflow in glyph
6893 length calculations.
6894
6895 Integer and memory overflow fixes for display code.
6896 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6897 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6898 (scrolling_window): Check for overflow in size calculations.
6899 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6900 Don't assume glyph table len fits in int.
6901 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6902 (row_table_size): Now ptrdiff_t, not int.
6903 (scrolling_window): Avoid overflow in size calculations.
6904 Don't update size until allocation succeeds.
6905 * fns.c (concat): Check for overflow in size calculations.
6906 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6907 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6908 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6909
6910 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6911 (get_doc_string): Check for size calculation overflow.
6912 Don't update size until allocation succeeds.
6913 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6914 EMACS_INT, where ptrdiff_t will do.
6915 (Fsubstitute_command_keys): Check for string overflow.
6916
6917 * editfns.c (set_time_zone_rule): Don't assume environment length
6918 fits in int.
6919 (message_length): Now ptrdiff_t, not int.
6920 (Fmessage_box): Don't update size until allocation succeeds.
6921 Don't assume message length fits in int.
6922 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6923
0065d054
PE
6924 * emacs.c (main): Do not reallocate argv, since there is a null at
6925 the end that can be overwritten, and this way there's no need to
6926 worry about size-calculation overflow.
6927 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6928
6929 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6930 alloc succeeds.
6931 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6932
6933 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6934 (x_set_scroll_bar_width, x_figure_window_size):
6935 Check for integer overflow.
6936 (x_set_alpha): Do not assume XINT fits in int.
6937
6938 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6939 This is for the members text_lines, text_cols, total_lines, total_cols,
6940 where the system imposes an 'int' limit.
6941
6942 * fringe.c (Fdefine_fringe_bitmap):
6943 Don't update size until alloc works.
6944
6945 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6946 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6947
6948 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6949 Check for size-calculation overflow.
6950 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6951 do, as we prefer signed integers.
6952 (id_to_widget.max_size, id_to_widget.used)
6953 (xg_store_widget_in_map, xg_remove_widget_from_map)
6954 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6955 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6956 Use and return ptrdiff_t, not int.
6957 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6958 * gtkutil.h: Change prototypes to match the above.
6959
6960 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6961 are duplicate now that they've been promoted to lisp.h.
6962 (x_allocate_bitmap_record, x_alloc_image_color)
6963 (make_image_cache, cache_image, xpm_load):
6964 Don't update size until alloc is done.
6965 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6966 (x_detect_edges):
3256efce 6967 Check for size calculation overflow.
726e0ab1
PE
6968 (ct_colors_allocated_max): New constant.
6969 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6970 overflow.
3256efce 6971
726e0ab1
PE
6972 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6973 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6974 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6975 Use ptrdiff_t, not int, to count maps.
6976 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6977 calculations. Don't update size until allocation succeeds.
6978 Redo calculations to avoid overflow.
726e0ab1
PE
6979 * keyboard.h: Change prototypes to match the above.
6980
6981 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6982 to count maps.
6983 (current_minor_maps): Check for size calculation overflow.
6984 * keymap.h: Change prototypes to match the above.
6985
6986 * lread.c (read1, init_obarray): Don't update size until alloc done.
6987
6988 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6989 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6990
726e0ab1
PE
6991 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6992 Now ptrdiff_t, not int.
6993 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6994 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6995
6996 * process.c (Fnetwork_interface_list): Check for overflow
6997 in size calculation.
6998
6999 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7000
7001 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7002 overflow. Don't bother calling xmalloc when xrealloc will do.
7003
7004 * search.c (Freplace_match): Check for size calculation overflow.
7005 (Fset_match_data): Don't assume list lengths fit in 'int'.
7006
7007 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7008 for command line length. Do not attempt to address one before the
7009 beginning of an array, as that's not portable.
7010
7011 * term.c (max_frame_lines): Remove; unused.
7012 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7013 not int.
7014 (encode_terminal_code, calculate_costs): Check for size
7015 calculation overflow.
7016 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7017 table lengths and related sizes. Don't update size until alloc
7018 done. Redo calculations to avoid overflow.
7019 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7020
7021 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7022 subtracting pointers.
7023 (gobble_line): Check for overflow more carefully. Don't update size
7024 until alloc done.
7025
7026 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7027 Don't update size until alloc done.
7028 Redo size calculations to avoid overflow.
7029 Check for size calculation overflow.
0065d054 7030 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7031
7032 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7033 Use ptrdiff_t, not int, for sizes.
7034 (store_mode_line_noprop_char): Don't update size until alloc done.
7035
0065d054
PE
7036 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7037 Use ptrdiff_t, not int, for sizes.
7038 (Finternal_make_lisp_face, cache_face):
7039 Check for size calculation overflow.
7040 (cache_face): Treat size calculation overflows as if they were
7041 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7042
7043 * xfns.c (x_encode_text, x_set_name_internal)
7044 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7045 sizes, since they can exceed INT_MAX in size. Check for size
7046 calculation overflow.
7047
0065d054
PE
7048 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7049 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7050 Don't update size until alloc done.
7051
0065d054 7052 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7053 as sprintf is limited to int lengths.
1d526e2f 7054
252c5ee1
PE
7055 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7056 (X_LONG_MIN): New macros.
864d7ce7
PE
7057 Use them to make the following changes clearer.
7058 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7059 This change doesn't affect the value now, but it may help remind
7060 future maintainers not to raise the value too much later.
7061 (SELECTION_QUANTUM): Remove, replacing with ...
7062 (selection_quantum): ... new function, which avoids overflow.
7063 All uses changed.
7064 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7065 assumption that selection length fits in 'int'.
7066 (x_reply_selection_request, x_handle_selection_request)
7067 (x_get_window_property, receive_incremental_selection)
7068 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7069 (lisp_data_to_selection_data, clean_local_selection_data):
7070 Use ptrdiff_t, not int, to record length of selection.
7071 (x_reply_selection_request, x_get_window_property)
7072 (receive_incremental_selection, x_property_data_to_lisp):
7073 Redo calculations to avoid overflow.
7074 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7075 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7076 something.
7077 (x_get_window_property, receive_incremental_selection)
7078 (lisp_data_to_selection_data, x_property_data_to_lisp):
7079 Check for size-calculation overflow.
7080 (x_get_window_property, receive_incremental_selection)
7081 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7082 Don't store size until memory allocation succeeds.
7083 (x_get_window_property): Plug memory leak on memory exhaustion.
7084 Don't double-block input; malloc is safe here. Don't assume 2**34
7085 - 4 fits in unsigned long. Add an xassert to check
7086 XGetWindowProperty overflow. Be more careful about overflow
7087 calculations, and distinguish size from memory overflow better.
7088 (receive_incremental_selection): When tracing, don't assume
7089 unsigned int is less than INT_MAX.
7090 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7091 harmful) conversions of unsigned short to int.
7092 (lisp_data_to_selection_data): Don't assume that integers
7093 in the range -65535 through -1 fit in an X unsigned short.
7094 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7095 result parameters unless successful. Rely on cons_to_unsigned
7096 to report problems with elements; the old code wasn't right anyway.
7097 (x_check_property_data): Check for int overflow; we cannot use
7098 a wider type due to X limits.
7099 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7100
726e0ab1 7101 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7102
0065d054
PE
7103 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7104 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7105 (x_color_cells): Don't store size until memory allocation succeeds.
7106 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7107 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7108 (x_term_init): Don't assume length fits in int (sprintf is limited
7109 to int size).
bc18e09d 7110
ebfa62c0
PE
7111 Use ptrdiff_t for composition IDs.
7112 * character.c (lisp_string_width):
7113 * composite.c (composition_table_size, n_compositions)
7114 (get_composition_id, composition_gstring_from_id):
7115 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7116 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7117 * window.c (Frecenter):
7118 Use ptrdiff_t, not int, for composition IDs.
7119 * composite.c (get_composition_id): Check for integer overflow.
7120 * composite.h: Adjust prototypes to match the above changes.
7121
d3411f89
PE
7122 Use ptrdiff_t for hash table indexes.
7123 * category.c (hash_get_category_set):
7124 * ccl.c (ccl_driver):
7125 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7126 * coding.c (coding_system_charset_list, detect_coding_system):
7127 * coding.h (struct coding_system.id):
7128 * composite.c (get_composition_id, gstring_lookup_cache):
7129 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7130 * image.c (xpm_get_color_table_h):
7131 * lisp.h (hash_lookup, hash_put):
7132 * minibuf.c (Ftest_completion):
7133 Use ptrdiff_t for hash table indexes, not int (which is too
7134 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7135 32-bit --with-wide-int hosts).
7136
e097a6fa
PE
7137 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7138 Add a FIXME comment about memory leaks.
7139 (syms_of_charset): Don't assume xmalloc returns.
7140
5637687f
PE
7141 Don't assume that stated character widths fit in int.
7142 * character.c (Fchar_width, c_string_width, lisp_string_width):
7143 * character.h (CHAR_WIDTH):
7144 * indent.c (MULTIBYTE_BYTES_WIDTH):
7145 Use sanitize_char_width to avoid undefined and/or bad behavior
7146 with outlandish widths.
a66cfb1c 7147 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7148 now that we have two such functions. All uses changed.
7149 (sanitize_char_width): New inline function.
7150
a2271ba2
PE
7151 Don't assume that tab-width fits in int.
7152 * character.h (sanitize_width): New inline function.
7153 (SANE_TAB_WIDTH): New macro.
7154 (ASCII_CHAR_WIDTH): Use it.
7155 * indent.c (sane_tab_width): Remove. All uses replaced by
7156 SANE_TAB_WIDTH (current_buffer).
7157 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7158
18c52557
PE
7159 * fileio.c: Integer overflow issues with file modes.
7160 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7161
caeeedc1
PE
7162 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7163 Remove unreachable code.
7164 (read_hex, load_charset_map_from_file): Check for integer overflow.
7165
6df6ae42 7166 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7167 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7168 (x_send_scroll_bar_event): Likewise. Check that the size does not
7169 exceed limits imposed by XClientMessageEvent, as well as the usual
7170 ptrdiff_t and size_t limits.
7171
b13995db
PE
7172 * keyboard.c: Overflow, signedness and related fixes.
7173 (make_lispy_movement): Use same integer type in forward decl
7174 that is used in the definition.
7175 (read_key_sequence, keyremap_step):
7176 Change bufsize argument back to int, undoing my 2011-03-30 change.
7177 We prefer signed types, and int is wide enough here.
7178 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7179 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7180 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7181 length, not size_t. Use ptrdiff_t for index, not int.
7182 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7183 possibility of integer overflow.
7184
13464394
PE
7185 Overflow, signedness and related fixes for images.
7186
7187 * dispextern.h (struct it.stack[0].u.image.image_id)
7188 (struct_it.image_id, struct image.id, struct image_cache.size)
7189 (struct image_cache.used, struct image_cache.ref_count):
7190 * gtkutil.c (update_frame_tool_bar):
7191 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7192 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7193 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7194 * nsmenu.m (update_frame_tool_bar):
7195 * xdisp.c (calc_pixel_width_or_height):
7196 * xfns.c (image_cache_refcount):
7197 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7198 on typical 64-bit hosts.
7199
7200 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7201 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7202 Omit unnecessary casts to int.
7203 (parse_image_spec): Check that integers fall into 'int' range
7204 when the callers expect that.
7205 (image_ascent): Redo ascent calculation to avoid int overflow.
7206 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7207 (lookup_image): Remove unnecessary tests.
7208 (xbm_image_p): Locals are now of int, not EMACS_INT,
7209 since parse_image_check makes sure they fit into int.
7210 (png_load, gif_load, svg_load_image):
7211 Prefer int to unsigned where either will do.
7212 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7213 old tiff_error_handler and tiff_warning_handler.
7214 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7215 stack buffer overflows. It uses only the features of vsnprintf
7216 that are common to both POSIX and native Microsoft.
7217 (tiff_error_handler, tiff_warning_handler): Use it.
7218 (tiff_load, gif_load, imagemagick_load_image):
7219 Don't assume :index value fits in 'int'.
7220 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7221 (imagemagick_load_image): Check that crop parameters fit into
7222 the integer types that MagickCropImage accepts. Don't assume
7223 Vimagemagick_render_type has a nonnegative value. Don't assume
7224 size_t fits in 'long'.
7225 (gs_load): Use printmax_t to print the widest integers possible.
7226 Check for integer overflow when computing image height and width.
7227
c11821d4
EZ
72282011-08-26 Eli Zaretskii <eliz@gnu.org>
7229
7230 * xdisp.c (redisplay_window): Don't force window start if point
7231 will be invisible in the resulting window. (Bug#9324)
7232
0c95fcf7
EZ
72332011-08-25 Eli Zaretskii <eliz@gnu.org>
7234
7235 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7236 the display spec is of the form `(space ...)'.
7237 (handle_display_spec): Return the value returned by
7238 handle_single_display_spec, not just 1 or zero.
7239 (handle_single_display_spec): If the display spec is of the form
7240 `(space ...)', and specifies display in the text area, return 2
7241 rather than 1.
fee65a97 7242 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7243 accurately, and prefer exact match for point under bidi.
7244 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7245
7246 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7247 into disp_prop; all users changed.
7248
7249 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7250 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7251 for the text covered by the display property.
7252
e4ed06f1
CY
72532011-08-25 Chong Yidong <cyd@stupidchicken.com>
7254
7255 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7256 Change return value to nil.
7257 (Frecord_buffer): Delete unused function.
7258
f67cdd7f
EZ
72592011-08-24 Eli Zaretskii <eliz@gnu.org>
7260
5980d4c6
EZ
7261 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7262 buffers, return left-to-right.
8610fe8b
EZ
7263 (set_cursor_from_row): Consider candidate row a win if its glyph
7264 represents a newline and point is on that newline. Fixes cursor
7265 positioning on the newline at EOL of R2L text within L2R
7266 paragraph, and vice versa.
7267 (try_cursor_movement): Check continued rows, in addition to
7268 continuation rows. Fixes unwarranted scroll when point enters a
7269 continued line of R2L text within an L2R paragraph, or vice versa.
7270 (cursor_row_p): Consider the case of point being equal to
7271 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7272 from the end of a short line to the beginning of a continued line
7273 of R2L text within L2R paragraph.
7274 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7275 composed characters.
5980d4c6 7276
f67cdd7f
EZ
7277 * bidi.c (bidi_check_type): Use xassert.
7278 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7279 members.
7280
bca633fb
EZ
72812011-08-23 Eli Zaretskii <eliz@gnu.org>
7282
7283 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7284 a character.
7285
4a5885a7
CY
72862011-08-23 Chong Yidong <cyd@stupidchicken.com>
7287
7288 * nsfont.m (ns_otf_to_script): Fix typo.
7289
0902a04e
KH
72902011-08-22 Kenichi Handa <handa@m17n.org>
7291
7292 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7293 extra slot even if the purpose is char-code-property-table.
7294
1a2e6670
EZ
72952011-08-23 Eli Zaretskii <eliz@gnu.org>
7296
8ddde651
EZ
7297 * xdisp.c (redisplay_window): When computing centering_position,
7298 account for the height of the header line. (Bug#8874)
7299
425cc014
EZ
7300 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7301 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7302 candidate is selected by the mouse, and that candidate has a
7303 composed character under the mouse.
7304
1a2e6670
EZ
7305 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7306 coordinates reported by pos-visible-in-window-p for a composed
7307 character in column zero.
7308
8b76d6f8
SM
73092011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7310
7311 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7312
dac347dd
EZ
73132011-08-22 Eli Zaretskii <eliz@gnu.org>
7314
7315 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7316 consider it a hit if to_charpos is anywhere in the range of the
7317 composed buffer positions.
7318
e013fb34
CY
73192011-08-22 Chong Yidong <cyd@stupidchicken.com>
7320
7321 * image.c (gif_load): Don't assume that each subimage has the same
7322 dimensions as the base image. Handle disposal method that is
7323 "undefined" by the gif spec (Bug#9335).
7324
bd1ba3e8
CY
73252011-08-20 Chong Yidong <cyd@stupidchicken.com>
7326
7327 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7328 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7329
54a1215b
EZ
73302011-08-19 Eli Zaretskii <eliz@gnu.org>
7331
823564e5
EZ
7332 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7333 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7334 from an Org mode buffer to a Speedbar frame.
7335
54a1215b
EZ
7336 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7337 a composition, take its buffer position from IT->cmp_it.charpos.
7338 Fixes cursor positioning at the beginning of a line that begins
7339 with a composed character.
7340
9778ebcc
EZ
73412011-08-18 Eli Zaretskii <eliz@gnu.org>
7342
0be6ee06
EZ
7343 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7344 character bidirectional type, use STRONG_L instead. Fixes crashes
7345 in a buffer produced by `describe-categories'.
7346
9778ebcc
EZ
7347 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7348 members before the level stack, so they would be saved and
7349 restored when copying iterator state. Fixes incorrect reordering
7350 around TABs covered by display properties.
7351
156bffbe
AS
73522011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7353
6b02f655 7354 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7355
72ad093b
CY
73562011-08-17 Chong Yidong <cyd@stupidchicken.com>
7357
7358 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7359 (internal_condition_case_2, internal_condition_case_n):
7360 Remove unnecessary aborts (Bug#9081).
72ad093b 7361
35774242
EZ
73622011-08-17 Eli Zaretskii <eliz@gnu.org>
7363
7364 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7365 has no `load' handler, try opening the file locally. (Bug#9311)
7366
db76dd85
KB
73672011-08-16 Ken Brown <kbrown@cornell.edu>
7368
7369 * gmalloc.c: Expand comment.
7370
b215eee5
EZ
73712011-08-16 Eli Zaretskii <eliz@gnu.org>
7372
7373 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7374 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7375
a4579d33
KB
73762011-08-16 Ken Brown <kbrown@cornell.edu>
7377
7378 Fix memory allocation problems in Cygwin build (Bug#9273).
7379
7380 * unexcw.c ( __malloc_initialized): Declare external variable.
7381 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7382
8b76d6f8
SM
7383 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7384 New variables.
a4579d33
KB
7385 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7386 dumped emacs.
7387 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7388 in the static heap.
7389 [CYGWIN] (special_realloc): New function.
7390 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7391 requests to realloc storage in the static heap.
7392
3ebec551
PE
73932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7394
7395 * bidi.c (bidi_initialize): Remove unused local.
7396
9fd8be00
EZ
73972011-08-15 Eli Zaretskii <eliz@gnu.org>
7398
6b02f655
SM
7399 * bidimirror.h:
7400 * biditype.h: Remove file.
7401 * makefile.w32-in ($(BLD)/bidi.$(O)):
7402 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7403
7404 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7405
7406 * chartab.c: Improve commentary for the uniprop_table API.
7407
32413314
EZ
7408 * bidi.c (bidi_paragraph_init): Support zero value of
7409 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7410 (bidi_initialize): Use uniprop_table instead of including
7411 biditype.h and bidimirror.h.
32413314 7412
9fd8be00
EZ
7413 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7414 coordinates of the iterator when restoring from ppos_it.
7415 (Bug#9296)
7416
5cf2b69b
KH
74172011-08-14 Kenichi Handa <handa@m17n.org>
7418
7419 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7420 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7421
daf17d00
EZ
74222011-08-14 Eli Zaretskii <eliz@gnu.org>
7423
7424 * xdisp.c (move_it_in_display_line_to): Don't invoke
7425 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7426 ppos_it. Fixes vertical cursor motion when line beginning is
7427 covered by an image. (Bug#9296)
7428
08e3161a
JD
74292011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7430
7431 * nsterm.h (ns_run_ascript): Declare.
7432 (NSAPP_DATA2_RUNASSCRIPT): Define.
7433
7434 * nsfns.m (as_script, as_result, as_status): New static variables.
7435 (ns_run_ascript): New function.
5e617bc2 7436 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7437 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7438 the event loop. Get status from as_status (Bug#7276).
7439
7440 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7441 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7442 the event loop (Bug#7276).
7443
a3720aa2
AS
74442011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7445
7446 * gnutls.c (QCgnutls_bootprop_priority)
7447 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7448 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7449 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7450 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7451 (QCgnutls_bootprop_verify_hostname_error)
7452 (QCgnutls_bootprop_callbacks_verify): Rename from
7453 Qgnutls_bootprop_..., all uses changed.
7454
7455 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7456 uses changed.
7457
0a0d27fb
PE
74582011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7459
19d5c50c
PE
7460 * xfaces.c (Qframe_set_background_mode): Now static.
7461 * dispextern.h (Qframe_set_background_mode): Remove decl.
7462
0a0d27fb
PE
7463 * process.c (Fnetwork_interface_info): Declare local only if needed.
7464
377538cb
JD
74652011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7466
7467 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7468 (Fnetwork_interface_list): Allocate in increments of bytes instead
7469 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7470 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7471 sockaddr.
7472 (struct ifflag_def): notrailers is smart on OSX.
7473 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7474 Get hardware address with getifaddrs if available.
7475
08fff70c
EZ
74762011-08-12 Eli Zaretskii <eliz@gnu.org>
7477
7478 * xdisp.c (iterate_out_of_display_property): xassert that
7479 IT->position is set to within IT->object's boundaries. Break from
7480 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7481 when IT->position is set up wrongly due to some bug.
7482 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7483 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7484 entry. Force push_it to save on the stack the current
7485 buffer/string position, to be restored by pop_it. Fix flags in
7486 the iterator structure wrt the object coming from a display
7487 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7488 properties. (Bug#9284)
7489
7be1c708 74902011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7491
7be1c708
CY
7492 * fontset.c (fontset_get_font_group): Add proper type checks.
7493 (Bug#9172)
aac0c6e3 7494
7be1c708 74952011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7496
7be1c708
CY
7497 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7498 and LC_VERSION_MIN_MACOSX.
7499 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7500 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7501
97bb72a6
EZ
75022011-08-08 Eli Zaretskii <eliz@gnu.org>
7503
7504 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7505 no-display-properties-and-no-overlays under bidi display.
7506 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7507 properties and overlays.
97bb72a6 7508
d5617611
CY
75092011-08-08 Chong Yidong <cyd@stupidchicken.com>
7510
37e11a63
CY
7511 * editfns.c (Fset_time_zone_rule): Document relationship with the
7512 setenv function.
7513
d5617611
CY
7514 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7515 the font entity extracted from the cache (Bug#8109).
7516
58872834
CY
75172011-08-07 Chong Yidong <cyd@stupidchicken.com>
7518
7519 * composite.c (autocmp_chars): Don't reset point. That is done by
7520 restore_point_unwind (Bug#5984).
7521
75bfc667
JL
75222011-08-07 Juri Linkov <juri@jurta.org>
7523
7524 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7525 to show the arg `TIME' instead of `TIMEVAL'.
7526
d1410150
EZ
75272011-08-06 Eli Zaretskii <eliz@gnu.org>
7528
7529 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7530 display property strides EOL and includes a newline, as in
7531 longlines-mode. (Bug#9254)
75b771e4
EZ
7532 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7533 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7534
7535 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7536 is non-zero, even if the data buffer is NULL. Fixes a crash in
7537 vertical-motion with longlines-mode. (Bug#9254)
7538
35928349
EZ
75392011-08-05 Eli Zaretskii <eliz@gnu.org>
7540
ec7cc85b
EZ
7541 * bidi.c <bidi_cache_total_alloc>: Now static.
7542 (bidi_initialize): Initialize bidi_cache_total_alloc.
7543
8b76d6f8 7544 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7545 cache. (Bug#9221)
7546
7547 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7548 amount allocated this far in `bidi_cache_total_alloc'.
7549 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7550 non-zero, only free the data buffer without restoring the cache
7551 contents. All callers changed.
7552
7553 * dispextern.h (bidi_unshelve_cache): Update prototype.
7554
7555 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7556 (move_it_in_display_line, move_it_to)
7557 (move_it_vertically_backward, move_it_by_lines): Replace the call
7558 to xfree to an equivalent call to bidi_unshelve_cache.
7559 (move_it_in_display_line_to): Fix logic of returning
412b6358 7560 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7561
e2e2423b
EZ
75622011-08-05 Eli Zaretskii <eliz@gnu.org>
7563
7564 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7565 came from a string character with a `cursor' property. (Bug#9229)
7566
ae9e757a
JD
75672011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7568
7569 * Makefile.in (LIB_PTHREAD): New variable.
7570 (LIBES): Add LIB_PTHREAD (Bug#9216).
7571
7572 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7573 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7574
213bd7f2
AS
75752011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7576
6b02f655 7577 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7578
99aaf75f
JD
75792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7580
7581 * xterm.c (x_find_topmost_parent): New function.
7582 (x_set_frame_alpha): Find topmost parent window with
7583 x_find_topmost_parent and set the property there also (bug#9181).
7584 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7585
c74e9d86
PE
75862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7587
7588 * callproc.c (Fcall_process): Avoid vfork clobbering
7589 the local vars buffer, coding_systems, current_dir.
7590
640c8776
SM
75912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7592
7593 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7594
f26d0e4c
PE
75952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7596
8a10d76c
PE
7597 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7598 so that it is not optimized away.
7599
f26d0e4c
PE
7600 * xdisp.c (compute_display_string_pos): Remove unused local.
7601
55439c61
EZ
76022011-08-02 Eli Zaretskii <eliz@gnu.org>
7603
7604 Fix slow cursor motion and scrolling in large buffers with
7605 selective display, like Org Mode buffers. (Bug#9218)
7606
7607 * dispextern.h (struct bidi_it): New member disp_prop_p.
7608
7609 * xdisp.c: Remove one-slot cache of display string positions.
7610 (compute_display_string_pos): Accept an additional argument
5e617bc2 7611 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7612 for a display string or property. If found, set DISP_PROP_P
7613 non-zero.
7614
7615 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7616 DISP_PROP_P, and pass it to compute_display_string_pos.
7617 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7618 non-zero. All callers of bidi_fetch_char changed.
7619
fb33fa43
SM
76202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7621
7622 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7623
b099e063
DM
76242010-12-03 Don March <don@ohspite.net>
7625
7626 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7627 last character M-[char] is translated to ESC [char] (bug#7541).
7628
5cc7f7af
KH
76292011-08-02 Kenichi Handa <handa@m17n.org>
7630
d0fffa3f 7631 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7632
7633 * chartab.c (uniprop_table): Make it non-static.
7634
525d5e6e
EZ
76352011-08-01 Eli Zaretskii <eliz@gnu.org>
7636
7637 * xdisp.c (forward_to_next_line_start): Accept additional argument
7638 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7639 on the newline.
7640 (reseat_at_next_visible_line_start): Use the bidi iterator state
7641 returned by forward_to_next_line_start to restore the state of
7642 it->bidi_it after backing up to previous newline. (Bug#9212)
7643
31011111
AS
76442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7645
7646 * regex.c (re_comp): Protoize.
7647 (re_exec): Fix return type.
7648 (regexec): Fix type of `ret'. (Bug#9203)
7649
476371c4
PE
76502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7651
e5d76069
PE
7652 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7653 This is needed if max-image-size is a floating-point number.
7654
9a79b20c
AS
76552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7656
7657 * print.c (print_object): Print empty symbol as ##.
7658
7659 * lread.c (read1): Read ## as empty symbol.
7660
d8c2fa78
AA
76612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7662
7663 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7664 setting frame foreground color (Bug#9175).
7665 (x_set_background_color): Likewise.
7666
ffe57a7a
AA
7667 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7668 contents (Bug#9176).
7669 (EmacsTooltip -init): Remove bezels and add shadows to
7670 tooltip windows.
7671
bf3492a5
AA
7672 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7673 or scroll bar (Bug#8470).
7674
d55e9c53
AA
7675 * nsfont.m (nsfont_open): Remove assignment to voffset and
7676 unnecessary vars hshink, expand, hd, full_height, min_height.
7677 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7678
7679 * nsterm.h (nsfont_info): Remove voffset field.
7680
d8c2fa78 76812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7682
7683 Implement strike-through and overline on NextStep (Bug#8863).
7684
7685 * nsfont.m (nsfont_open): Use underline position provided by font,
7686 instead of hard-coded value of 2.
7687 (nsfont_draw): Call ns_draw_text_decoration instead.
7688
7689 * nsterm.h: Add declaration for ns_draw_text_decoration.
7690
7691 * nsterm.m (ns_draw_text_decoration): New function for drawing
7692 underline, overline, and strike-through.
7693 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7694 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7695 accommodate underlining, etc.
4843aac3 7696
4cc60b9b
EZ
76972011-07-28 Eli Zaretskii <eliz@gnu.org>
7698
bc7ece87
EZ
7699 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7700 default.
4cc60b9b 7701
476371c4
PE
77022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7703
66606eea
PE
7704 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7705 Without this fix, if a signal arrives just after memory fills up,
7706 'malloc' might be invoked reentrantly.
7707
476371c4
PE
7708 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7709 In other words, assume that every image size is allowed, on non-X
7710 hosts. This assumption is probably wrong, but it lets Emacs compile.
7711
f3fcc40d
AS
77122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7713
7714 * regex.c (re_iswctype): Convert return values to boolean.
7715
350c992f
EZ
77162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7717
7718 * xdisp.c (compute_display_string_pos): Don't use cached display
7719 string position if the buffer had its restriction changed.
7720 (Bug#9184)
7721
5266b4bb
PE
77222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7723
7724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7725
2573a837 77262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7727
41f55ccd 7728 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7729
39e378da
PE
7730 * bidi.c: Integer size and overflow fixes.
7731 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7732 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7733 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7734 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7735 (bidi_find_other_level_edge):
7736 Use ptrdiff_t instead of EMACS_INT where either will do.
7737 This works better on 32-bit hosts configured --with-wide-int.
7738 (bidi_cache_ensure_space): Check for size-calculation overflow.
7739 Use % rather than repeated addition, for better worst-case speed.
7740 Don't set bidi_cache_size until after xrealloc returns, because it
7741 might not return.
7742 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7743 (bidi_cache_ensure_space): Also check that the bidi cache size
7744 does not exceed that of the largest Lisp string or buffer. See Eli
7745 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7746
5e927815
PE
7747 * alloc.c (__malloc_size_t): Remove.
7748 All uses replaced by size_t. See Andreas Schwab's note
7749 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7750
ca4aa935
PE
7751 * image.c: Improve checking for integer overflow.
7752 (check_image_size): Assume that f is nonnull, since
7753 it is always nonnull in practice. This is one less thing to
7754 worry about when checking for integer overflow later.
7755 (x_check_image_size): New function, which checks for integer
7756 overflow issues inside X.
7757 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7758 This removes the need for a memory_full check.
7759 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7760 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7761 (xbm_read_bitmap_data): Change locals back to 'int', since
7762 their values must fit in 'int'.
7763 (xpm_load_image, png_load, tiff_load):
7764 Invoke x_create_x_image_and_pixmap earlier,
7765 to avoid much needless work if the image is too large.
7766 (tiff_load): Treat overly large images as if
7767 x_create_x_image_and_pixmap failed, not as malloc failures.
7768 (gs_load): Use x_check_image_size.
7769
5f8f9cc2
PE
7770 * gtkutil.c: Omit integer casts.
7771 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7772 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7773
5adf60bc
PE
7774 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7775
c8907a93
PE
7776 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7777 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7778 would wrongly return t on a 64-bit host.
7779
e3c25c68
PE
7780 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7781 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7782 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7783 and therefore cause GCC to emit a bogus diagnostic in some cases.
7784
3f791afe
PE
7785 * image.c: Integer signedness and overflow and related fixes.
7786 This is not an exhaustive set of fixes, but it's time to
7787 record what I've got.
7788 (lookup_pixel_color, check_image_size): Remove redundant decls.
7789 (check_image_size): Don't assume that arbitrary EMACS_INT values
7790 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7791 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7792 (tiff_load, imagemagick_load_image):
7793 Check for overflow in size calculations.
7794 (x_create_x_image_and_pixmap): Remove unnecessary test for
7795 xmalloc returning NULL; that can't happen.
7796 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7797 (xpm_color_bucket): Use better integer hashing function.
7798 (xpm_cache_color): Don't possibly over-allocate memory.
7799 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7800 (gif_memory_source):
7801 Use ptrdiff_t, not int or size_t, to record sizes.
7802 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7803 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7804 either works, as we prefer signed integers.
7805 (tiff_read_from_memory, tiff_write_from_memory):
7806 Return tsize_t, not size_t, since that's what the TIFF API wants.
7807 (tiff_read_from_memory): Don't fail simply because the read would
7808 go past EOF; instead, return a short read.
7809 (tiff_load): Omit no-longer-needed casts.
7810 (Fimagemagick_types): Don't assume size fits into 'int'.
7811
3cc5a532
PE
7812 Improve hashing quality when configured --with-wide-int.
7813 * fns.c (hash_string): New function, taken from sxhash_string.
7814 Do not discard information about ASCII character case; this
7815 discarding is no longer needed.
7816 (sxhash-string): Use it. Change sig to match it. Caller changed.
7817 * lisp.h: Declare it.
7818 * lread.c (hash_string): Remove, since we now use fns.c's version.
7819 The fns.c version returns a wider integer if --with-wide-int is
7820 specified, so this should help the quality of the hashing a bit.
7821
b312a492
PE
7822 * emacs.c: Integer overflow minor fix.
7823 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7824 Define only if GNU_LINUX.
7825 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7826
dfd153ae
PE
7827 * dispnew.c: Integer signedness and overflow fixes.
7828 Remove unnecessary forward decls, that were a maintenance hassle.
7829 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7830 All uses changed.
7831 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7832 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7833 (prepare_desired_row, line_draw_cost):
7834 Use int, not unsigned, where either works.
7835 (save_current_matrix, restore_current_matrix):
7836 Use ptrdiff_t, not size_t, where either works.
7837 (init_display): Check for overflow more accurately, and without
7838 relying on undefined behavior.
7839
a81d11a3
PE
7840 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7841 Remove, replacing with the new symbols in lisp.h. All uses changed.
7842 * fileio.c (make_temp_name):
7843 * filelock.c (lock_file_1, lock_file):
7844 * xdisp.c (message_dolog):
7845 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7846 Use pMd etc. instead.
7847 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7848 replacing the pWIDE etc. symbols removed from editfns.c.
7849
3300e6fd
PE
7850 * keyboard.h (num_input_events): Now uintmax_t.
7851 This is (very slightly) less likely to mess up due to wraparound.
7852 All uses changed.
7853
fd05c7e9
PE
7854 * buffer.c: Integer signedness fixes.
7855 (alloc_buffer_text, enlarge_buffer_text):
7856 Use ptrdiff_t rather than size_t when either will do, as we prefer
7857 signed integers.
7858
903fe15d
PE
7859 * alloc.c: Integer signedness and overflow fixes.
7860 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7861 (__malloc_size_t): Default to size_t, not to int.
7862 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7863 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7864 Prefer ptrdiff_t to size_t when either would do, as we prefer
7865 signed integers.
7866 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7867 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7868 Now const. Initialize with values that are in range even if char
7869 is signed.
7870 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7871 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7872 These functions do the right thing with sizes > 2**32.
7873 (check_depth): Now ptrdiff_t, not int.
7874 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7875 Adjust to new way of storing sizes. Check for size overflow bugs
7876 in rest of code.
7877 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7878 slightly wrong anyway, as it missed one instance of
7879 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7880 (refill_memory_reserve): Omit needless cast to size_t.
7881 (mark_object_loop_halt): Mark as externally visible.
7882
ac82cc6a
PE
7883 * xselect.c: Integer signedness and overflow fixes.
7884 (Fx_register_dnd_atom, x_handle_dnd_message):
7885 Use ptrdiff_t, not size_t, since we prefer signed.
7886 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7887 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7888 x_dnd_atoms_size and x_dnd_atoms_length.
7889
c2d1e36d
PE
7890 * doprnt.c: Prefer signed to unsigned when either works.
7891 * eval.c (verror):
7892 * doprnt.c (doprnt):
7893 * lisp.h (doprnt):
7894 * xdisp.c (vmessage):
7895 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7896 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7897 prefer signed arithmetic to avoid comparison confusion.
7898 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7899 but is a bit tricky.
7900
0e926e56
PE
7901 Assume freestanding C89 headers, string.h, stdlib.h.
7902 * data.c, doprnt.c, floatfns.c, print.c:
7903 Include float.h unconditionally.
7904 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7905 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7906 * regex.c: Likewise for stddef.h, string.h.
7907 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7908 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7909 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7910 (STDC_HEADERS): Remove obsolete defines.
7911 * sysdep.c: Include limits.h unconditionally.
7912
9cfdb3ec
PE
7913 Assume support for memcmp, memcpy, memmove, memset.
7914 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7915 * regex.c (memcmp, memcpy):
7916 Remove; we assume C89 now.
7917
7918 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7919 (__malloc_safe_bcopy): Remove; no longer needed.
7920
cf950e6b 7921 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7922 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7923 well either way, and we prefer signed to unsigned.
7924
dbf38e02
LMI
79252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7926
7927 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7928 closes the connection while we're reading (bug#9182).
7929
d6f0886c 79302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7931
d6f0886c
JD
7932 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7933 are specified (Bug#9168).
24e0f6b1 7934
2eb1f9e6
PE
79352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7936
7937 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7938 Found by GCC static checking and --with-wide-int on a 32-bit host.
7939
22381272 79402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7941
7942 * xdisp.c (compute_display_string_pos): Fix logic of caching
7943 previous display string position. Initialize cached_prev_pos to
7944 -1. Fixes slow-down at the beginning of a buffer.
7945
f25e39b4
EZ
79462011-07-24 Eli Zaretskii <eliz@gnu.org>
7947
7948 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7949 for attrs[LFACE_FONTSET_INDEX].
7950
04c4b52e
PE
79512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7952
7953 * xml.c (parse_region): Remove unused local
7954 that was recently introduced.
7955
c1734fbd
EZ
79562011-07-23 Eli Zaretskii <eliz@gnu.org>
7957
be18c5a5
EZ
7958 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7959 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7960
c1734fbd
EZ
7961 * xdisp.c (move_it_in_display_line_to): Record the best matching
7962 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7963 exit if none of the characters scanned was an exact match.
7964 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7965 when exact match is impossible due to invisible text, and the
7966 lines are truncated.
7967
a258d627
JD
79682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7969
7970 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7971 for OSX >= 10.7.
7972
b6d5a689
EZ
79732011-07-22 Eli Zaretskii <eliz@gnu.org>
7974
0f74f785
EZ
7975 Fix a significant slow-down of cursor motion with C-n, C-p,
7976 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7977 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7978 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7979 (next_element_from_buffer): Call compute_stop_pos_backwards to
7980 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7981 base_level_stop.
7982 (reseat): Don't look for prev_stop, as that could mean a very long
7983 run.
7984 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7985 <cached_disp_overlay_modiff>: Cache for last found display string
7986 position.
551918c1 7987 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7988 about the same buffer in the same area of character positions, and
7989 the buffer wasn't changed since the time the display string
7990 position was cached.
551918c1 7991
b2d0c91a
EZ
79922011-07-22 Eli Zaretskii <eliz@gnu.org>
7993
7994 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7995 is an integer, which is important for empty lines. (Bug#9149)
7996
043604ee
CY
79972011-07-22 Chong Yidong <cyd@stupidchicken.com>
7998
7999 * frame.c (Fmodify_frame_parameters): In tty case, update the
8000 default face if necessary (Bug#4238).
8001
da4adb04
CY
80022011-07-21 Chong Yidong <cyd@stupidchicken.com>
8003
8004 * editfns.c (Fstring_to_char): No need to explain what a character
8005 is in the docstring (Bug#6576).
8006
9abd0532
LMI
80072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8008
8009 * xml.c (parse_region): Make sure we always return a tree.
8010
36881d16
HK
80112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8012
8013 * xml.c (parse_region): If a document contains only comments,
8014 return that, too.
8015
1e98674d
LMI
80162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8017
8018 * xml.c (make_dom): Return comments, too.
8019
590bd467
PE
80202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8021
8022 Port to OpenBSD.
8023 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8024 and the surrounding thread.
8025 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8026 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8027 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8028 timer goes off.
8029 * s/openbsd.h (BROKEN_SIGIO): Define.
8030 * unexelf.c (unexec) [__OpenBSD__]:
8031 Don't update the .mdebug section of the Alpha COFF symbol table.
8032
f41628b2
LMI
80332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8034
8035 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8036 (bug#8460).
8037
b59b67c5
PE
80382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8039
15e3a074
PE
8040 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8041 This fixes some race conditions on the permissions of any newly
8042 created file.
8043
41bed37d
PE
8044 * alloc.c (valid_pointer_p): Use pipe, not open.
8045 This fixes some permissions issues when debugging.
8046
b59b67c5
PE
8047 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8048 If fchown fails to set both uid and gid, try to set just gid,
8049 as that is sometimes allowed. Adjust the file's mode to eliminate
8050 setuid or setgid bits that are inappropriate if fchown fails.
8051
925a6be7
SM
80522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8053
8054 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8055 to compare Lisp_Objects.
8056 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8057 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8058 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8059
52968808
AS
80602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8061
0a6a104b
AS
8062 * lread.c (read_integer): Unread even EOF character.
8063 (read1): Likewise. Properly record start position of symbol.
8064
52968808
AS
8065 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8066 symbol character follows.
8067
9e381cdd
PE
80682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8069
8070 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8071 This works around a problem with the previous change to Fcopy_file.
8072 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8073 and without this change, GCC might complain about discarding
8074 fchown's return value.
8075
b5641435
JB
80762011-07-16 Juanma Barranquero <lekktu@gmail.com>
8077
8078 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8079
a8031457
PE
80802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8081
8082 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8083
dd889327
LMI
80842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8085
750c33f7
LMI
8086 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8087 it's used from the C level.
8088
dd889327
LMI
8089 * process.c: Use the same condition for POLL_FOR_INPUT in both
8090 keyboard.c and process.c (bug#1858).
8091
87e86684
LM
80922011-07-09 Lawrence Mitchell <wence@gmx.li>
8093
8094 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8095 (Fgnutls_boot): Use it.
8096
64348f40
AS
80972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8098
8099 * doc.c (Fsubstitute_command_keys): Revert last change.
8100
1d698799
LMI
81012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8102
f863868c
LMI
8103 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8104 quotes the next character, and doesn't affect other longer
8105 sequences (bug#8935).
8106
1d698799
LMI
8107 * lread.c (syms_of_lread): Clarify that is isn't only
8108 `eval-buffer' and `eval-defun' that's affected by
8109 `lexical-binding' (bug#8460).
8110
aa4b6df6
EZ
81112011-07-15 Eli Zaretskii <eliz@gnu.org>
8112
8113 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8114 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8115
5d856da6
PE
81162011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8117
ad6042bb
PE
8118 Fix minor problems found by static checking.
8119 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8120 (elsz): Now a signed constant, not a size_t var. We prefer signed
8121 types to unsigned, to avoid integer comparison confusion. Without
8122 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8123 "cannot optimize loop, the loop counter may overflow", a symptom
8124 of the confusion.
f00bbb22 8125 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8126 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8127
6468f31c
LMI
81282011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8129
49080b10
LMI
8130 * search.c (Fre_search_backward): Mention `case-fold-search' in
8131 all the re_search_* functions (bug#8138).
8132
6468f31c
LMI
8133 * keyboard.c (Fopen_dribble_file): Document when the file is
8134 closed (bug#8056).
8135
c965adc5
EZ
81362011-07-14 Eli Zaretskii <eliz@gnu.org>
8137
df9733bf
EZ
8138 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8139 bidi_cache_idx.
8140
0bb23927
EZ
8141 Support bidi reordering of display and overlay strings.
8142 * xdisp.c (compute_display_string_pos)
8143 (compute_display_string_end): Accept additional argument STRING.
8144 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8145 (reseat_to_string): Initialize bidi_it->string.s and
8146 bidi_it->string.schars.
8147 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8148 NULL (avoids a crash in bidi_paragraph_init).
8149 Initialize itb.string.lstring.
0bb23927
EZ
8150 (init_iterator): Call bidi_init_it only of a valid
8151 buffer position was specified. Initialize paragraph_embedding to
8152 L2R.
8153 (reseat_to_string): Initialize the bidi iterator.
8154 (display_string): If we need to ignore text properties of
8155 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8156 original value of -1 will not work with bidi.)
8157 (compute_display_string_pos): First arg is now struct
8158 `text_pos *'; all callers changed. Support display properties on
8159 Lisp strings.
8160 (compute_display_string_end): Support display properties on Lisp
8161 strings.
8162 (init_iterator, reseat_1, reseat_to_string): Initialize the
8163 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8164 when iterating on a string not from display properties).
640c8776
SM
8165 (compute_display_string_pos, compute_display_string_end):
8166 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8167 arrow keys.
8168 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8169 base_level_stop; instead, set base_level_stop to BEGV.
8170 Fixes crashes in vertical-motion.
0bb23927
EZ
8171 (next_element_from_buffer): Improve commentary for when
8172 the iterator is before prev_stop.
8173 (init_iterator): Initialize bidi_p from the default value of
8174 bidi-display-reordering, not from buffer-local value. Use the
8175 buffer-local value only if initializing for buffer iteration.
8176 (handle_invisible_prop): Support invisible properties on strings
8177 that are being bidi-reordered.
8178 (set_iterator_to_next): Support bidi reordering of C strings and
8179 Lisp strings.
8180 (next_element_from_string): Support bidi reordering of Lisp
8181 strings.
8182 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8183 (display_string): Support display of R2L glyph rows.
8184 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8185 (init_iterator): Don't initialize it->bidi_p for strings
8186 here.
8187 (reseat_to_string): Initialize it->bidi_p for strings here.
8188 (next_element_from_string, next_element_from_c_string)
8189 (next_element_from_buffer): Add xassert's for correspondence
8190 between IT's object being iterated and it->bidi_it.string
8191 structure.
8192 (face_before_or_after_it_pos): Support bidi iteration.
8193 (next_element_from_c_string): Handle the case of the first string
8194 character that is not the first one in the visual order.
8195 (get_visually_first_element): New function, refactored from common
8196 parts of next_element_from_buffer, next_element_from_string, and
8197 next_element_from_c_string.
8198 (tool_bar_lines_needed, redisplay_tool_bar)
8199 (display_menu_bar): Force left-to-right direction. Add a FIXME
8200 comment for making that be controlled by a user option.
8201 (push_it, pop_it): Save and restore the state of the
8202 bidi iterator. Save and restore the bidi_p flag.
8203 (pop_it): Iterate out of display property for string iteration as
8204 well.
8205 (iterate_out_of_display_property): Support iteration over strings.
8206 (handle_single_display_spec): Set up it->bidi_it for iteration
8207 over a display string, and call bidi_init_it.
8208 (handle_single_display_spec, next_overlay_string)
8209 (get_overlay_strings_1, push_display_prop): Set up the bidi
8210 iterator for displaying display or overlay strings.
8211 (forward_to_next_line_start): Don't use the shortcut if
8212 bidi-iterating.
8213 (back_to_previous_visible_line_start): If handle_display_prop
8214 pushed the iterator stack, restore the internal state of the bidi
8215 iterator by calling bidi_pop_it same number of times.
8216 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8217 and we are bidi-iterating, don't decrement the iterator position;
8218 instead, set the first_elt flag in the bidi iterator, to produce
8219 the same effect.
8220 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8221 (push_display_prop): xassert that we are iterating a buffer.
8222 (push_it, pop_it): Save and restore paragraph_embedding member.
8223 (handle_single_display_spec, next_overlay_string)
8224 (get_overlay_strings_1, reseat_1, reseat_to_string)
8225 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8226 correctly. Don't assume unibyte strings are not bidi-reordered.
8227 (compute_display_string_pos)
8228 (compute_display_string_end): Fix handling the case of C string.
8229 (push_it, pop_it): Save and restore from_disp_prop_p.
8230 (handle_single_display_spec, push_display_prop): Set the
8231 from_disp_prop_p flag.
8232 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8233 (pop_it): Call iterate_out_of_display_property only if we are
8234 popping after iteration over a string that came from a display
8235 property. Fix a typo in popping stretch info. Add an assertion
8236 for verifying that the iterator position is in sync with the bidi
8237 iterator.
8238 (handle_single_display_spec, get_overlay_strings_1)
8239 (push_display_prop): Fix initialization of paragraph direction for
8240 string when that of the parent object is not yet determined.
8241 (reseat_1): Call bidi_init_it to resync the bidi
8242 iterator with IT's position. (Bug#7616)
8243 (find_row_edges): If ROW->start.pos gives position
8244 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8245 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8246 Reset the from_disp_prop_p flag.
8247 (SAVE_IT, RESTORE_IT): New macros.
8248 (pos_visible_p, face_before_or_after_it_pos)
8249 (back_to_previous_visible_line_start)
8250 (move_it_in_display_line_to, move_it_in_display_line)
8251 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8252 (try_scrolling, redisplay_window, display_line): Use them when
8253 saving a temporary copy of the iterator and restoring it back.
8254 (back_to_previous_visible_line_start, reseat_1)
8255 (init_iterator): Empty the bidi cache "stack".
8256 (move_it_in_display_line_to): If iterator ended up at
8257 EOL, but we never saw any buffer positions smaller than
8258 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8259 motion in bidi-reordered lines.
8260 (move_it_in_display_line_to): Record prev_method and prev_pos
8261 immediately before the call to set_iterator_to_next. Fixes cursor
8262 motion in bidi-reordered lines with stretch glyphs and strings
8263 displayed in margins. (Bug#8133) (Bug#8867)
8264 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8265 TO_CHARPOS.
640c8776
SM
8266 (pos_visible_p): Support positions in bidi-reordered lines.
8267 Save and restore bidi cache.
0bb23927
EZ
8268
8269 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8270 (bidi_paragraph_info): Delete unused struct.
8271 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8272 (bidi_cache_start): New variable.
8273 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8274 to zero.
8275 (bidi_cache_fetch_state, bidi_cache_search)
8276 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8277 (bidi_cache_find, bidi_peek_at_next_level)
8278 (bidi_level_of_next_char, bidi_find_other_level_edge)
8279 (bidi_move_to_visually_next): Compare cache index with
8280 bidi_cache_start rather than with zero.
8281 (bidi_fetch_char): Accept new argument STRING; all callers
8282 changed. Support iteration over a string. Support strings with
8283 display properties. Support unibyte strings. Fix the type of
8284 `len' according to what STRING_CHAR_AND_LENGTH expects.
8285 (bidi_paragraph_init, bidi_resolve_explicit_1)
8286 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8287 (bidi_level_of_next_char, bidi_move_to_visually_next):
8288 Support iteration over a string.
0bb23927
EZ
8289 (bidi_set_sor_type, bidi_resolve_explicit_1)
8290 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8291 can now be zero (for strings); special values 0 and -1 were
8292 changed to -1 and -2, respectively.
8293 (bidi_char_at_pos): New function.
8294 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8295 Call it instead of FETCH_MULTIBYTE_CHAR.
8296 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8297 initialized to valid values.
8298 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8299 values.
8300 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8301 the test for valid cached positions. Fix the logic for looking up
8302 the sentinel state in the cache. GCPRO the Lisp string we are
8303 iterating.
8304 (bidi_push_it, bidi_pop_it): New functions.
8305 (bidi_initialize): Initialize the bidi cache start stack pointer.
8306 (bidi_cache_ensure_space): New function, refactored from part of
8307 bidi_cache_iterator_state. Don't assume the required size is just
8308 one BIDI_CACHE_CHUNK away.
8309 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8310 (bidi_count_bytes, bidi_char_at_pos): New functions.
8311 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8312 always valid if bidi_cache_idx is valid.
8313 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8314 is valid if it's going to be used.
8315 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8316 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8317 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8318 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8319 (bidi_find_other_level_edge, bidi_cache_start_stack):
8320 All variables related to cache indices are now EMACS_INT.
c965adc5 8321
0bb23927
EZ
8322 * dispextern.h (struct bidi_string_data): New structure.
8323 (struct bidi_it): New member `string'. Make flag members be 1-bit
8324 fields, and put them last in the struct.
640c8776
SM
8325 (compute_display_string_pos, compute_display_string_end):
8326 Update prototypes.
0bb23927
EZ
8327 (bidi_push_it, bidi_pop_it): Add prototypes.
8328 (struct iterator_stack_entry): New members bidi_p,
8329 paragraph_embedding, and from_disp_prop_p.
8330 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8331 (bidi_shelve_cache, bidi_unshelve_cache):
8332 Declare prototypes.
0bb23927
EZ
8333
8334 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8335 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8336 and vector-like objects.
8337
8338 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8339 cache around display iteration.
8340
8341 * window.c (Fwindow_end, window_scroll_pixel_based)
8342 (displayed_window_lines, Frecenter): Save and restore the bidi
8343 cache around display iteration.
8344
3bbd2265
LMI
83452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8346
8347 * editfns.c (Fdelete_region): Clarify the use of the named
8348 parameters (bug#6788).
8349
adc47434
MR
83502011-07-14 Martin Rudalics <rudalics@gmx.at>
8351
8352 * indent.c (Fvertical_motion): Set and restore w->pointm when
8353 saving and restoring the window's buffer (Bug#9006).
8354
837c31f8
LMI
83552011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8356
8357 * editfns.c (Fstring_to_char): Clarify just what is returned
8358 (bug#6576). Text by Eli Zaretskii.
8359
ac389d0c
JB
83602011-07-13 Juanma Barranquero <lekktu@gmail.com>
8361
8362 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8363
0be0ce47
EZ
83642011-07-13 Eli Zaretskii <eliz@gnu.org>
8365
8366 * buffer.c (mmap_find): Fix a typo.
8367
cd18e7e3
JB
83682011-07-13 Johan Bockgård <bojohan@gnu.org>
8369
8370 Fix execution of x selection hooks.
8371 * xselect.c (Qx_lost_selection_functions)
8372 (Qx_sent_selection_functions): New vars.
8373 (syms_of_xselect): DEFSYM them.
8374 (x_handle_selection_request): Pass Qx_sent_selection_functions
8375 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8376 (x_handle_selection_clear,x_clear_frame_selections):
8377 Pass Qx_lost_selection_functions rather than
8378 Vx_lost_selection_functions to Frun_hook_with_args.
8379
47ea7f44
PE
83802011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8381
ac389d0c 8382 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8383 The old code sometimes used this field without initializing it.
8384
47ea7f44
PE
8385 * alloc.c (gc_sweep): Don't read past end of array.
8386 In theory, the old code could also have corrupted Emacs internals,
8387 though it'd be very unlikely.
8388
bc985c87
AS
83892011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8390
8391 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8392 argument. (Bug#4026)
bc985c87 8393
0cf34688
LMI
83942011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8395
b3dadd76
LMI
8396 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8397 key" (bug#4257).
8398
0cf34688
LMI
8399 * window.c (Fset_window_start): Doc fix (bug#4199).
8400 (Fset_window_hscroll): Ditto.
8401
270768cd
PE
84022011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8403
077e3dda 8404 Fix minor new problems caught by GCC 4.6.1.
270768cd 8405 * term.c (init_tty): Remove unused local.
490011a6 8406 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8407 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8408 not used otherwise.
270768cd 8409
b1f58454
CY
84102011-07-12 Chong Yidong <cyd@stupidchicken.com>
8411
8412 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8413
22b9578d
LMI
84142011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8415
6e70ab07
LMI
8416 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8417 are the mini-buffer and the echo area (bug#3320).
8418
22b9578d
LMI
8419 * term.c (init_tty): Remove support for supdup, c10 and perq
8420 terminals, which are no longer supported (bug#1482).
8421
8974cc9f
JB
84222011-07-10 Johan Bockgård <bojohan@gnu.org>
8423
8424 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8425
a560d974
JD
84262011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8427
8428 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8429 for non-popups (Bug#3642).
8430
1dae0f0a
AS
84312011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8432
268c2c36 8433 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8434 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8435 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8436 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8437 * data.c (fmod): Likewise.
8438 * dispnew.c (swap_glyphs_in_rows): Likewise.
8439 * emacs.c (memory_warning_signal): Likewise.
8440 * floatfns.c (float_error): Likewise.
8441 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8442 (otf_open, font_otf_capability, generate_otf_features)
8443 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8444 Likewise.
8445 * image.c (pbm_read_file): Likewise.
8446 * indent.c (string_display_width): Likewise.
8447 * intervals.c (check_for_interval, search_for_interval)
8448 (inc_interval_count, count_intervals, root_interval)
8449 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8450 * lread.c (defalias): Likewise.
268c2c36 8451 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8452 * regex.c (set_image_of_range_1, set_image_of_range)
8453 (regex_grow_registers): Likewise.
8454 * sysdep.c (strerror): Likewise.
8455 * termcap.c (valid_filename_p, tprint, main): Likewise.
8456 * tparam.c (main): Likewise.
8457 * unexhp9k800.c (run_time_remap, save_data_space)
8458 (update_file_ptrs, read_header, write_header, calculate_checksum)
8459 (copy_file, copy_rest, display_header): Likewise.
8460 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8461 Likewise.
8462 * xdisp.c (check_it): Likewise.
8463 * xfaces.c (register_color, unregister_color, unregister_colors):
8464 Likewise.
8465 * xfns.c (print_fontset_result): Likewise.
8466 * xrdb.c (member, fatal, main): Likewise.
8467
99033785
PE
84682011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8469
8470 Fix minor problems found by static checking (Bug#9031).
8471 * chartab.c (char_table_set_range, map_sub_char_table):
8472 Remove unused locals.
8473 (uniprop_table): Now static.
8474 * composite.c (_work_char): Remove unused static var.
8475
9cb2ac56
JB
84762011-07-09 Juanma Barranquero <lekktu@gmail.com>
8477
8478 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8479
f25661f0
JD
84802011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8481
8482 * gtkutil.c (qttip_cb): Remove code without function.
8483
8278c4fe
EZ
84842011-07-09 Eli Zaretskii <eliz@gnu.org>
8485
8486 * w32.c (pthread_sigmask): New stub.
8487
1692ae2d 84882011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8489
8a6ebd58 8490 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8491 sigprocmask is portable only for single-threaded applications, and
8492 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8493 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8494 (LIBES): Use it.
8495 * callproc.c (Fcall_process):
8496 * process.c (create_process):
8497 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8498 Use pthread_sigmask, not sigprocmask.
123403e4 8499
1b854618
JD
85002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8501
8502 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8503 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8504 wrong (Bug#8591).
8505
3fe4b549
JD
85062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8507
0ce7e563
JD
8508 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8509 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8510 (xg_hide_tooltip): Fix comment.
8511
3fe4b549
JD
8512 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8513 in registerServicesMenuSendTypes.
8514 (validRequestorForSendType): Don't check ns_return_types.
8515
8516 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8517 ns_return_type.
8518
5df75e47
JR
85192011-07-08 Jason Rumney <jasonr@gnu.org>
8520
22610910
JR
8521 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8522 SH_SHOW for hidden windows (Bug#5482).
8523
5df75e47
JR
8524 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8525 frame struct members of non-existent frames (Bug#6284).
8526
699c10bd
JD
85272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8528
4393663b
JD
8529 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8530 variable firstTime not needed on OSX >= 10.6.
8531 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8532 >= 10.5. Use setKnobProportion, setDoubleValue.
8533
8534 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8535 (MAC_OS_X_VERSION_10_5): Define if not defined.
8536 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8537 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8538 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8539
8540 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8541 cString and lossyCString on OSX >= 10.4.
4393663b 8542
58179cce 8543 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8544 sizeToFit on OSX >= 10.2.
8545
8546 * nsimage.m (allocInitFromFile): Don't use deprecated method
8547 bestRepresentationForDevice on OSX >= 10.6.
8548
8549 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8550 to avoid warning.
8551
8552 * emacs.c: Declare unexec_init_emacs_zone.
8553
a63e0781
JD
8554 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8555
699c10bd
JD
8556 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8557
8558 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8559 on svcsMenu (Bug#8842).
8560
8561 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8562 ns_return_types.
8563 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8564
8565 * nsterm.m (QUTF8_STRING): Declare.
8566 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8567 (validRequestorForSendType): Return type is (id).
8568 Change indexOfObjectIdenticalTo to indexOfObject.
8569 Check if we have local selection before returning self (Bug#8842).
8570 (writeSelectionToPasteboard): Put local selection into paste board
8571 if we have a local selection (Bug#8842).
8572 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8573
8574 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8575 (ns_get_local_selection): Declare.
8576
54e10184
LMI
85772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8578
9888ff71
LMI
8579 * keymap.c (describe_map_tree): Don't insert a double newline at
8580 the end of the buffer (bug#1169) and return whether we inserted
8581 something.
8582
54e10184
LMI
8583 * callint.c (Fcall_interactively): Change "reading args" to
8584 "providing args" to try to clarify what it does (bug#1010).
8585
15fa4783
KH
85862011-07-07 Kenichi Handa <handa@m17n.org>
8587
8588 * composite.c (composition_compute_stop_pos): Ignore a static
8589 composition starting before CHARPOS (Bug#8915).
8590
8591 * xdisp.c (handle_composition_prop): Likewise.
8592
a8815b00
EZ
85932011-07-07 Eli Zaretskii <eliz@gnu.org>
8594
8595 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8596 (Bug#9015)
8597
ef7b981d 85982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8599
8600 * character.h (unicode_category_t): New enum type.
8601
8602 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8603 (Qchar_code_property_table): New variable.
8604 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8605 (UNIPROP_COMPRESSED_FORM_P): New macros.
8606 (char_table_ascii): Uncompress the compressed values.
8607 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8608 Uncompress the compressed values.
ac389d0c 8609 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8610 (char_table_ref_and_range): Uncompress the compressed values.
8611 (sub_char_table_set): New arg is_uniprop. Callers changed.
8612 Uncompress the compressed values.
8613 (sub_char_table_set_range): Args changed. Callers changed.
8614 (char_table_set_range): Adjuted for the above change.
8615 (map_sub_char_table): Delete args default_val and parent. Add arg
8616 top. Give decoded values to a Lisp function.
640c8776 8617 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8618 values to a Lisp function. Gcpro more variables.
8619 (uniprop_table_uncompress)
8620 (uniprop_decode_value_run_length): New functions.
8621 (uniprop_decoder, uniprop_decoder_count): New variables.
8622 (uniprop_get_decoder, uniprop_encode_value_character)
8623 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8624 New functions.
8625 (uniprop_encoder, uniprop_encoder_count): New variables.
8626 (uniprop_get_encoder, uniprop_table)
8627 (Funicode_property_table_internal, Fget_unicode_property_internal)
8628 (Fput_unicode_property_internal): New functions.
8629 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8630 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8631 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8632 char-code-property-alist.
8633
640c8776 8634 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8635 Vunicode_category_table.
8636
640c8776 8637 * font.c (font_range): Adjust for the change of
c805dec0
KH
8638 Vunicode_category_table.
8639
76b397fb
DN
86402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8641
8642 * m/iris4d.h: Remove file, move contents ...
8643 * s/irix6-5.h: ... here.
8644
22b4128e
PE
86452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8646
8647 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8648 * alloc.c (mark_buffer):
8649 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8650 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8651 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8652 This isn't true in general, and it's particularly not true
8653 if Emacs is configured with --with-wide-int.
8654 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8655 New macros, used in the buffer.c change.
8656
869795d6
JD
86572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8658
8659 * xsettings.c: Use both GConf and GSettings if both are available.
8660 (store_config_changed_event): Add comment.
8661 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8662 (store_tool_bar_style_changed): New functions.
5e617bc2 8663 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8664 (struct xsettings): Move font inside HAVE_XFT.
8665 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8666 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8667 Move inside HAVE_XFT.
640c8776 8668 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8669 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8670 also.
8671 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8672 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8673 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8674 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8675 (parse_settings): Move check for font inside HAVE_XFT.
8676 (read_settings, apply_xft_settings): Add comment.
8677 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8678 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8679 call store_font_name_changed.
8680 (xft_settings_event): Add comment.
8681 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8682 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8683 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8684 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8685 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8686 (xsettings_get_system_font, xsettings_get_system_normal_font):
8687 Add comment.
869795d6 8688
d8ed26bd
PE
86892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8690
8691 Random fixes. E.g., (random) never returned negative values.
8692 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8693 subseconds part to the entropy, as that's a bit more random.
8694 Prefer signed to unsigned, since the signedness doesn't matter and
8695 in general we prefer signed. When given a limit, use a
8696 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8697 latter isn't right if USE_2_TAGS_FOR_INTS.
8698 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8699 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8700
cabf1cac
SM
87012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8702
8703 * textprop.c (text_property_stickiness):
8704 Obey Vtext_property_default_nonsticky.
8705 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8706 * w32fns.c (syms_of_w32fns):
8707 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8708
6e9b2be9
PE
87092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8710
8711 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8712 This is more efficient than Ffile_directory_p and avoids a minor race.
8713
90186c68
LMI
87142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8715
7c301272
LMI
8716 * buffer.c (Foverlay_put): Say what the return value is
8717 (bug#7835).
8718
c4f2d8d4
LMI
8719 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8720 is a directory before asking whether to use the file name
8721 (bug#7564).
ad637907
LMI
8722 (barf_or_query_if_file_exists): Make the "File is a directory"
8723 error be more correct.
c4f2d8d4 8724
90186c68
LMI
8725 * fns.c (Frequire): Remove the mention of the .gz files, since
8726 that's installation-specific, but keep the mention of
8727 `get-load-suffixes'.
8728
da64016e
PE
87292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8730
8731 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8732 Report string overflow if the output is too long.
8733
7d47b580
JB
87342011-07-04 Juanma Barranquero <lekktu@gmail.com>
8735
a555cb87
JB
8736 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8737 (syms_of_gnutls): Remove duplicate DEFSYM for
8738 Qgnutls_bootprop_verify_hostname_error, an error for
8739 Qgnutls_bootprop_verify_error (which is no longer used).
8740
7d47b580
JB
8741 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8742 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8743 Also (re)move comments that are misplaced or no longer relevant.
8744
1e49bfab
LMI
87452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8746
8747 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8748
1485f4c0
CY
87492011-07-03 Chong Yidong <cyd@stupidchicken.com>
8750
8751 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8752 and background color parameters if they have been changed.
8753
a9ab721e
LMI
87542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8755
8756 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8757
cf7cff57
PE
87582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8759
2e13213d
PE
8760 * xsettings.c (SYSTEM_FONT): Define only when used.
8761 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8762
cf7cff57
PE
8763 * keymap.c (access_keymap_1): Now static.
8764
7a8e04f7
CY
87652011-07-02 Chong Yidong <cyd@stupidchicken.com>
8766
8767 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8768 leave any prefix arg for the up event (Bug#1586).
8769
61352f62
LMI
87702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8771
69bb1ef7
LMI
8772 * lread.c (syms_of_lread): Mention single symbols defined by
8773 `defvar' or `defconst' (bug#7154).
8774
61352f62 8775 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8776 (Frequire): Mention get-load-suffixes.
61352f62 8777
28545e04
MR
87782011-07-02 Martin Rudalics <rudalics@gmx.at>
8779
8780 * window.h (window): Remove clone_number slot.
8781 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8782 Remove.
8783 (make_parent_window, make_window, saved_window)
8784 (Fset_window_configuration, save_window_save): Don't deal with
8785 clone numbers.
8786 * buffer.c (Qclone_number): Remove declaration.
8787 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8788
3349e122
SM
87892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8790
8791 Add multiple inheritance to keymaps.
8792 * keymap.c (Fmake_composed_keymap): New function.
8793 (Fset_keymap_parent): Simplify.
8794 (fix_submap_inheritance): Remove.
8795 (access_keymap_1): New function extracted from access_keymap to handle
8796 embedded parents and handle lists of maps.
8797 (access_keymap): Use it.
8798 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8799 (Fcopy_keymap): Handle embedded parents.
8800 (Fcommand_remapping, define_as_prefix): Simplify.
8801 (Fkey_binding): Simplify.
8802 (syms_of_keymap): Move minibuffer-local-completion-map,
8803 minibuffer-local-filename-completion-map,
8804 minibuffer-local-must-match-map, and
8805 minibuffer-local-filename-must-match-map to Elisp.
8806 (syms_of_keymap): Defsubr make-composed-keymap.
8807 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8808 (parse_menu_item): Trivial simplification.
8809
3279eb87
GM
88102011-07-01 Glenn Morris <rgm@gnu.org>
8811
8812 * Makefile.in (SETTINGS_LIBS): Fix typo.
8813
4550efdf
KI
88142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8815
8816 * coding.c (Fencode_coding_string): Record the last coding system
8817 used, as the function doc string says (bug#8738).
8818
0949d2b6
JD
88192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8820
8821 * xsettings.c (store_monospaced_changed): Take new font as arg and
8822 check for change against current_mono_font.
8823 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8824 (emacs_settings_constructor, emacs_settings_get_property)
8825 (emacs_settings_set_property, emacs_settings_class_init)
8826 (emacs_settings_init, gsettings_obj): Remove.
8827 (something_changedCB): New function for HAVE_GSETTINGS.
8828 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8829 with value as argument.
8830 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8831 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8832 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8833 "changed".
8834
8835 * xgselect.c: Add defined (HAVE_GSETTINGS).
8836 (xgselect_initialize): Ditto.
8837
8838 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8839 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8840 xg_select.
8841
bbc6b304
PE
88422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8843
8844 * eval.c (struct backtrace): Simplify and port the data structure.
8845 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8846 signed bit field, as this assumption is not portable and it makes
8847 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8848 "char debug_on_exit : 1" as this is not portable either; instead,
8849 use the portable "unsigned int debug_on_exit : 1". Remove unused
8850 member evalargs. Remove obsolete comments about cc bombing out.
8851
9851bfc5
JD
88522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8853
51bb811f 8854 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8855 Let HAVE_GSETTINGS override HAVE_GCONF.
8856 (store_monospaced_changed): New function.
8857 (EMACS_SETTINGS): A new type derived from GObject to handle
8858 GSettings notifications.
8859 (emacs_settings_constructor, emacs_settings_get_property)
8860 (emacs_settings_set_property, emacs_settings_class_init):
8861 New functions.
8862 (gsettings_client, gsettings_obj): New variables.
8863 (GSETTINGS_SCHEMA): New define.
8864 (something_changedCB): Call store_monospaced_changed.
8865 (init_gsettings): New function.
8866 (xsettings_initialize): Call init_gsettings.
8867 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8868 to NULL.
8869
640c8776 8870 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8871 GCONF_CFLAGS/LIBS.
8872
5386012d
MR
88732011-06-29 Martin Rudalics <rudalics@gmx.at>
8874
8875 * window.c (resize_root_window, grow_mini_window)
8876 (shrink_mini_window): Rename Qresize_root_window to
8877 Qwindow_resize_root_window and Qresize_root_window_vertically to
8878 Qwindow_resize_root_window_vertically.
8879
f13e0b08
PE
88802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8881
8882 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8883
94515237
JB
88842011-06-27 Juanma Barranquero <lekktu@gmail.com>
8885
8886 * makefile.w32-in: Redesign dependencies so they reflect more
8887 clearly which files are directly included by each source file,
8888 and not through other includes.
8889
e43b6e43
MR
88902011-06-27 Martin Rudalics <rudalics@gmx.at>
8891
8892 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8893 (sort_overlays, overlay_strings): When an overlay's clone number
8894 matches the window's clone number process the overlay even if
8895 the overlay's window property doesn't match the current window.
8896
d68443dc
MR
8897 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8898 (Fwindow_hchild): Rename to Fwindow_left_child.
8899 (Fwindow_next): Rename to Fwindow_next_sibling.
8900 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8901 (resize_window_check): Rename to window_resize_check.
8902 (resize_window_apply): Rename to window_resize_apply.
8903 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8904 (Fdelete_other_windows_internal, resize_frame_windows)
8905 (Fsplit_window_internal, Fdelete_window_internal)
8906 (grow_mini_window, shrink_mini_window)
8907 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8908
c7e73be5
JD
89092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8910
8911 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8912 (emacs_fixed_set_min_size): Remove.
8913 (emacs_fixed_new): Take frame as argument.
8914
8915 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8916 (_EmacsFixedPrivate): Remove minwidth/height.
8917 Add struct frame *f.
8918 (emacs_fixed_init): Initialize priv->f.
8919 (get_parent_class, emacs_fixed_set_min_size): Remove.
8920 (emacs_fixed_new): Set priv->f to argument.
8921 (emacs_fixed_get_preferred_width)
8922 (emacs_fixed_get_preferred_height): Use min_width/height from
8923 frames size_hint to set minimum and natural (Bug#8919).
8924 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8925 and use min_width/height from frames size_hint to set
8926 min_width/height (Bug#8919).
8927
8928 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8929 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8930 Fix indentation.
c7e73be5 8931
cf99dcf8
EZ
89322011-06-26 Eli Zaretskii <eliz@gnu.org>
8933
8934 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8935 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8936 called at ZV.
8937
029529ac
CY
89382011-06-26 Chong Yidong <cyd@stupidchicken.com>
8939
8940 * process.c (wait_reading_process_output): Bypass select if
8941 waiting for a cell while ignoring keyboard input, and input is
8942 pending. Suggested by Jan Djärv (Bug#8869).
8943
7a7ef429
PE
89442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8945
8946 Use gnulib's dup2 module instead of rolling our own.
8947 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8948
11fdef7d 89492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8950
8951 * dispnew.c (scrolling_window): Before scrolling, turn off a
8952 mouse-highlight in the window being scrolled.
8953
cd3520a4
JB
89542011-06-24 Juanma Barranquero <lekktu@gmail.com>
8955
8956 Move DEFSYM to lisp.h and use everywhere.
8957
8958 * character.h (DEFSYM): Move declaration...
8959 * lisp.h (DEFSYM): ...here.
8960
8961 * gnutls.c:
8962 * minibuf.c:
8963 * w32menu.c:
8964 * w32proc.c:
8965 * w32select.c: Don't include character.h.
8966
8967 * alloc.c (syms_of_alloc):
8968 * buffer.c (syms_of_buffer):
8969 * bytecode.c (syms_of_bytecode):
8970 * callint.c (syms_of_callint):
8971 * casefiddle.c (syms_of_casefiddle):
8972 * casetab.c (init_casetab_once):
8973 * category.c (init_category_once, syms_of_category):
8974 * ccl.c (syms_of_ccl):
8975 * cmds.c (syms_of_cmds):
8976 * composite.c (syms_of_composite):
8977 * dbusbind.c (syms_of_dbusbind):
8978 * dired.c (syms_of_dired):
8979 * dispnew.c (syms_of_display):
8980 * doc.c (syms_of_doc):
8981 * editfns.c (syms_of_editfns):
8982 * emacs.c (syms_of_emacs):
8983 * eval.c (syms_of_eval):
8984 * fileio.c (syms_of_fileio):
8985 * fns.c (syms_of_fns):
8986 * frame.c (syms_of_frame):
8987 * fringe.c (syms_of_fringe):
8988 * insdel.c (syms_of_insdel):
8989 * keymap.c (syms_of_keymap):
8990 * lread.c (init_obarray, syms_of_lread):
8991 * macros.c (syms_of_macros):
8992 * msdos.c (syms_of_msdos):
8993 * print.c (syms_of_print):
8994 * process.c (syms_of_process):
8995 * search.c (syms_of_search):
8996 * sound.c (syms_of_sound):
8997 * syntax.c (init_syntax_once, syms_of_syntax):
8998 * terminal.c (syms_of_terminal):
8999 * textprop.c (syms_of_textprop):
9000 * undo.c (syms_of_undo):
9001 * w32.c (globals_of_w32):
9002 * window.c (syms_of_window):
9003 * xdisp.c (syms_of_xdisp):
9004 * xfaces.c (syms_of_xfaces):
9005 * xfns.c (syms_of_xfns):
9006 * xmenu.c (syms_of_xmenu):
9007 * xsettings.c (syms_of_xsettings):
9008 * xterm.c (syms_of_xterm): Use DEFSYM.
9009
4228cf16
TZ
90102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9011
cd3520a4 9012 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9013
7fcccf1e
PE
90142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9015
7efb4e0e
PE
9016 Integer and buffer overflow fixes (Bug#8873).
9017
ff5844ad
PE
9018 * print.c (printchar, strout): Check for string overflow.
9019 (PRINTPREPARE, printchar, strout):
9020 Don't set size unless allocation succeeds.
9021
90532f02
PE
9022 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9023 for sizes. Check for string overflow more accurately.
9024 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9025
6d84508d
PE
9026 * macros.c: Integer and buffer overflow fixes.
9027 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9028 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9029 Use ptrdiff_t, not int, for sizes.
9030 Don't increment bufsize until after realloc succeeds.
9031 Check for size-calculation overflow.
9032 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9033
437b2cb4
PE
9034 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9035
8b9ac8b4
PE
9036 * lread.c: Integer overflow fixes.
9037 (read_integer): Radix is now EMACS_INT, not int,
9038 to improve quality of diagnostics for out-of-range radices.
9039 Calculate buffer size correctly for out-of-range radices.
9040 (read1): Check for integer overflow in radices, and in
9041 read-circle numbers.
82cb60d3
PE
9042 (read_escape): Avoid int overflow.
9043 (Fload, openp, read_buffer_size, read1)
9044 (substitute_object_recurse, read_vector, read_list, map_obarray):
9045 Use ptrdiff_t, not int, for sizes.
9046 (read1): Use EMACS_INT, not int, for sizes.
20270765 9047 Check for size overflow.
8b9ac8b4 9048
7fcccf1e
PE
9049 * image.c (cache_image): Check for size arithmetic overflow.
9050
bfbbd7e7
PE
9051 * lread.c: Integer overflow issues.
9052 (saved_doc_string_size, saved_doc_string_length)
9053 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9054 Now ptrdiff_t, not int.
9055 (read1): Don't assume doc string length fits in int. Check for
9056 out-of-range doc string lengths.
9057 (read_list): Don't assume file position fits in int.
39019e54 9058 (read_escape): Check for hex character overflow.
bfbbd7e7 9059
4e323265
LL
90602011-06-22 Leo Liu <sdl.web@gmail.com>
9061
9062 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9063 Move to minibuffer.el.
9064
85fece3e
PE
90652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9066
20b84ce9 9067 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9068 The following patches are for when GLYPH_DEBUG && !XASSERT.
9069 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9070 * dispnew.c (flush_stdout):
9071 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9072 Mark as externally visible.
9073 * dispnew.c (check_window_matrix_pointers): Now static.
9074 * dispnew.c (window_to_frame_vpos):
9075 * xfns.c (unwind_create_frame):
9076 * xterm.c (x_check_font): Remove unused local.
9077 * scroll.c (CHECK_BOUNDS):
9078 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9079 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9080 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9081 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9082 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9083 Now static.
9084 (debug_method_add): Use va_list and vsprintf rather than relying
9085 on undefined behavior with wrong number of arguments.
9086 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9087 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9088 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9089 since we're not interested in debugging glyphs with old libraries.
9090 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9091 GCC 4.6.0's static checking.
9092
0766b489
PE
90932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9094
31fd4b32
PE
9095 Integer overflow and signedness fixes (Bug#8873).
9096 A few related buffer overrun fixes, too.
9097
b79e8648
PE
9098 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9099
0766b489
PE
9100 * dispextern.h (struct face.stipple):
9101 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9102 (x_bitmap_mask, x_allocate_bitmap_record)
9103 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9104 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9105 (x_create_bitmap_from_xpm_data):
9106 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9107 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9108 (.bitmaps_last):
9109 * xfaces.c (load_pixmap):
9110 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9111 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9112 (.bitmaps_last, struct x_output.icon_bitmap):
9113 Use ptrdiff_t, not int, for bitmap indexes.
9114 (x_allocate_bitmap_record): Check for size overflow.
9115 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9116
b081724f
PE
9117 Use ptrdiff_t, not int, for overlay counts.
9118 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9119 * editfns.c (overlays_around, get_pos_property):
9120 * textprop.c (get_char_property_and_overlay):
9121 * xdisp.c (next_overlay_change, note_mouse_highlight):
9122 * xfaces.c (face_at_buffer_position):
21514da7
PE
9123 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9124 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9125 (Fnext_overlay_change, Fprevious_overlay_change)
9126 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9127 Use ptrdiff_t, not int, for sizes.
21514da7 9128 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9129
3de73e5e
PE
9130 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9131
2606c57b
PE
9132 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9133 (x_session_initialize): Do not assume string length fits in int.
9134
aaafe47a
PE
9135 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9136 This is unlikely, but can occur if DPI is outlandish.
9137
2674ddc8 9138 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9139 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9140
28154962
PE
9141 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9142 * xrdb.c (magic_file_p, search_magic_path):
9143 Omit last arg SUFFIX; it was always 0. All callers changed.
9144 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9145
7de51af5
PE
9146 * xfont.c (xfont_match): Avoid need for strlen.
9147
25ed6cc3
PE
9148 * xfns.c: Don't assume strlen fits in int.
9149 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9150
4eab31dd
PE
9151 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9152 not unsigned long, as we prefer signed integers. All callers changed.
9153 Detect integer overflow in repeat count.
9154 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9155 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9156
171e2a58
PE
9157 * termcap.c: Don't assume sizes fit in int and never overflow.
9158 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9159 (gobble_line): Check for size-calculation overflow.
9160
ad39faca 9161 * minibuf.c (Fread_buffer):
6e5bb2dc 9162 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9163 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9164 Don't assume string length fits in int.
9165
52c61c22 9166 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9167 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9168
b5b8c9e5
PE
9169 * font.c: Don't assume string length fits in int.
9170 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9171 Use ptrdiff_t, not int.
ccd6111c
PE
9172 (font_intern_prop): Don't assume string length fits in int.
9173 Don't assume integer property fits in fixnum.
9174 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9175
882f0d81 9176 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9177 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9178 Reformulate so as not to need the command string.
9179 Invoke gzip -cd rather than gunzip, as it's more portable.
9180 (lock_info_type, lock_file_1, lock_file):
9181 Don't assume pid_t and time_t fit in unsigned long.
9182 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9183 (current_lock_owner): Prefer signed type for sizes.
9184 Use memcpy, not strncpy, where memcpy is what is really wanted.
9185 Don't assume (via atoi) that time_t and pid_t fit in int.
9186 Check for time_t and/or pid_t out of range, e.g., via a network share.
9187 Don't alloca where an auto var works fine.
9188
93f4cf88
PE
9189 * fileio.c: Fix some integer overflow issues.
9190 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9191 Don't assume string length fits in int.
9192 (directory_file_name): Don't assume string length fits in long.
9193 (make_temp_name): Don't assume pid fits in int, or that its print
9194 length is less than 20.
9195
f3e92b69
PE
9196 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9197
1bfdaf10
PE
9198 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9199
35016e9a
PE
9200 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9201
3d1e65a1
PE
9202 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9203 We prefer signed integers, even for size calculations.
9204
0b963a93
PE
9205 * emacs.c: Don't assume string length fits in 'int'.
9206 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9207 (main): Don't invoke strlen when not needed.
9208
573f4b54
PE
9209 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9210 (XD_DEBUG_MESSAGE): Don't waste a byte.
9211
989f33ba
PE
9212 * callproc.c (getenv_internal_1, getenv_internal)
9213 (Fgetenv_internal):
965d34eb
PE
9214 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9215
e4d29b33
PE
9216 * lread.c (invalid_syntax): Omit length argument.
9217 All uses changed. This doesn't fix a bug, but it simplifies the
9218 code away from its former Hollerith-constant appearance, and it's
9219 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9220 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9221
eb49b136
PE
9222 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9223 This didn't break anything, but it didn't help either.
9224 It's confusing to put a bogus integer in a place where the actual
9225 value does not matter.
9f62aeb1 9226 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9227 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9228
15375a22
PE
9229 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9230 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9231 implementation.
b61cc01c
PE
9232 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9233 We prefer signed types, and the value cannot exceed the EMACS_INT
9234 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9235 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9236 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9237 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9238
53b2623d
PE
9239 * indent.c (sane_tab_width): New function.
9240 (current_column, scan_for_column, Findent_to, position_indentation)
9241 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9242 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9243
51cab52b 9244 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9245
f2ed8a70
PE
9246 * lisp.h (lint_assume): New macro.
9247 * composite.c (composition_gstring_put_cache):
9248 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9249
abe80cc6
PE
9250 * editfns.c, insdel.c:
9251 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9252
b02c740e
PE
9253 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9254
ebc96716
PE
9255 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9256
b4e50fa0 9257 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9258 Use much-faster test for byte-length change.
311d5d7c 9259 Don't assume string byte-length fits in 'int'.
a4cf38e4 9260 Check that character arg fits in 'int'.
85461888 9261 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9262
c0c1ee9f
PE
9263 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9264
a498d7f4
PE
9265 * fns.c (concat): Catch string overflow earlier.
9266 Do not rely on integer wraparound.
9267
51cab52b
PE
9268 * dispextern.h (struct it.overlay_strings_charpos)
9269 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9270 * xdisp.c (forward_to_next_line_start)
9271 (back_to_previous_visible_line_start)
9272 (reseat_at_next_visible_line_start, next_element_from_buffer):
9273 Don't arbitrarily truncate the value of 'selective' to int.
9274
76031fad
PE
9275 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9276
5eb55db9
PE
9277 * composite.c: Don't truncate sizes to 'int'.
9278 (composition_gstring_p, composition_reseat_it)
9279 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9280 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9281 not EMACS_UINT, for indexes.
5eb55db9 9282
0703a717
PE
9283 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9284
d6202519
PE
9285 * buffer.c: Include <verify.h>.
9286 (struct sortvec.priority, struct sortstr.priority):
8961a454 9287 Now EMACS_INT, not int.
c20998a7 9288 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9289 (struct sortstr.size, record_overlay_string)
9290 (struct sortstrlist.size, struct sortlist.used):
9291 Don't truncate size to int.
9292 (record_overlay_string): Check for size-calculation overflow.
d6202519 9293 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9294
d5a19415
JM
92952011-06-22 Jim Meyering <meyering@redhat.com>
9296
029529ac 9297 Don't leak an XBM-image-sized buffer
d5a19415
JM
9298 * image.c (xbm_load): Free the image buffer after using it.
9299
a9041e6c
PE
93002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9301
9302 Port to Sun C.
9303 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9304 that Sun C diagnosed.
9305 * fns.c (secure_hash): Fix pointer signedness issue.
9306 * intervals.c (static_offset_intervals): New function.
9307 (offset_intervals): Use it.
9308
7f3f739f
LL
93092011-06-21 Leo Liu <sdl.web@gmail.com>
9310
9311 * deps.mk (fns.o):
9312 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9313 sha512.h.
9314
9315 * fns.c (secure_hash): Rename from crypto_hash_function and change
9316 the first arg to accept symbols.
5b66d427 9317 (Fsecure_hash): New primitive.
7f3f739f
LL
9318 (syms_of_fns): New symbols.
9319
76147d94
DD
93202011-06-20 Deniz Dogan <deniz@dogan.se>
9321
9322 * process.c (Fset_process_buffer): Clarify return value in
9323 docstring.
9324
7d7d0045
CY
93252011-06-18 Chong Yidong <cyd@stupidchicken.com>
9326
9327 * dispnew.c (add_window_display_history): Use BVAR.
9328
9329 * xdisp.c (debug_method_add): Use BVAR.
9330 (check_window_end, dump_glyph_matrix, dump_glyph)
9331 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9332
9333 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9334 Likewise.
9335
9336 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9337 check till after the cache is created in init_frame_faces.
9338
ff2bc410
SM
93392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9340
9341 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9342
28177add
PE
93432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9344
dd3482fe
PE
9345 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9346 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9347 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9348
393d71f3 9349 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9350 * fileio.c (Finsert_file_contents):
9351 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9352 Remove the old (too-loose) buffer overflow checks.
9353 They weren't needed, since make_gap checks for buffer overflow.
9354 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9355 The old code merely checked for Emacs fixnum overflow, and relied
9356 on undefined (wraparound) behavior. The new code avoids undefined
9357 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9358
2e6813b0 9359 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9360 Tune. Don't use wider integers than needed. Don't use alloca.
9361 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9362
599a9e4f
PE
9363 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9364
99561444
PE
9365 * insdel.c, lisp.h (buffer_overflow): New function.
9366 (insert_from_buffer_1, replace_range, replace_range_2):
9367 * insdel.c (make_gap_larger):
9368 * editfns.c (Finsert_char):
9369 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9370
28177add
PE
9371 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9372
e69dafad
PE
93732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9374
4baa020d 9375 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9376
b1c46f02
PE
9377 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9378 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9379
e69dafad
PE
9380 * fileio.c: Don't assume EMACS_INT fits in off_t.
9381 (emacs_lseek): New static function.
9382 (Finsert_file_contents, Fwrite_region): Use it.
9383 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9384
566684ea
PE
9385 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9386
e6966cd6
PE
9387 * fns.c: Don't overflow int when computing a list length.
9388 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9389 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9390 truncation on 64-bit hosts. Check for QUIT every
9391 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9392 faster and is responsive enough.
9393 (Flength): Report an error instead of overflowing an integer.
9394 (Fsafe_length): Return a float if the value is not representable
9395 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9396 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9397 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9398
dd0b0efb
PE
9399 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9400 (header_size, word_size): New constants.
9401 (allocate_vectorlike): Don't check size overflow here.
9402 (allocate_vector): Check it here instead, since this is the only
9403 caller of allocate_vectorlike that could cause overflow.
9404 Check that the new vector's length is representable as a fixnum.
9405
86fe5cfe
PE
9406 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9407 The previous code was bogus. For example, next_almost_prime (32)
9408 returned 39, which is undesirable as it is a multiple of 3; and
9409 next_almost_prime (24) returned 25, which is a multiple of 5 so
9410 why was the code bothering to check for multiples of 7?
9411
80e88859
PE
9412 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9413
4a2f0ad6
PE
9414 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9415
f66c7cf8
PE
9416 Variadic C functions now count arguments with ptrdiff_t.
9417 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9418 Back then I didn't know that the Emacs coding style prefers signed int.
9419 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9420 were being counted with int, which may truncate counts on 64-bit
9421 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9422 * lisp.h (struct Lisp_Subr.function.aMANY)
9423 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9424 Arg counts are now ptrdiff_t, not size_t.
9425 All variadic functions and their callers changed accordingly.
9426 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9427 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9428 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9429 * callint.c (Fcall_interactively): Check arg count for overflow,
9430 to avoid potential buffer overrun. Use signed char, not 'int',
9431 for 'varies' array, so that we needn't bother to check its size
9432 calculation for overflow.
9433 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9434 * eval.c (apply_lambda):
9435 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9436 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9437 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9438
a1759b76
PE
9439 * callint.c (Fcall_interactively): Don't use index var as event count.
9440
d96be9fc
PE
9441 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9442 * mem-limits.h (SIZE): Remove; no longer used.
9443
a690a978 9444 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9445
578c21e6
PE
9446 Remove unnecessary casts.
9447 * xterm.c (x_term_init):
9448 * xfns.c (x_set_border_pixel):
9449 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9450 These aren't needed now that we assume ANSI C.
9451
96f53c6c
PE
9452 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9453 It's more likely to cause problems (due to unsigned overflow)
9454 than to cure them.
9455
83c77d31
PE
9456 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9457
ee2079f1
PE
9458 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9459
6da65536
PE
9460 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9461
7147c4a4
PE
9462 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9463
193e32d9
PE
9464 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9465
e5533da6
PE
9466 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9467
9910e595
PE
9468 GLYPH_CODE_FACE returns EMACS_INT, not int.
9469 * dispextern.h (merge_faces):
9470 * xfaces.c (merge_faces):
01103c44
PE
9471 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9472 Don't assume EMACS_INT fits in int.
9910e595 9473
2638320e
PE
9474 * character.h (CHAR_VALID_P): Remove unused parameter.
9475 * fontset.c, lisp.h, xdisp.c: All uses changed.
9476
045eb8d9
PE
9477 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9478
c1f134b5
PE
9479 * fns.c (concat): Minor tuning based on overflow analysis.
9480 This doesn't fix any bugs. Use int to hold character, instead
9481 of constantly refetching from Emacs object. Use XFASTINT, not
9482 XINT, for value known to be a character. Don't bother comparing
9483 a single byte to 0400, as it's always less.
9484
395fcb93 9485 * floatfns.c (Fexpt):
327eeec8
PE
9486 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9487
abbd3d23
PE
9488 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9489 for characters.
9490
684a03ef
PE
9491 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9492
0fed43f3
PE
9493 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9494 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9495 incorrectly succeed when S was a string, because 4294967386 was
9496 truncated before it was used.
9497
8fd02eb7
PE
9498 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9499 Otherwise, an out-of-range integer could cause undefined behavior
9500 on a 64-bit host.
9501
f8c86b69
PE
9502 * composite.c: Use int, not EMACS_INT, for characters.
9503 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9504 EMACS_INT, for values that are known to be in character range.
9505 This doesn't fix any bugs but is the usual style inside Emacs and
9506 may generate better code on 32-bit machines.
9507
34206dd2
PE
9508 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9509 This is for reasons similar to the recent CHAR_STRING fix.
9510 * charset.c (Fencode_char): Check that character arg is actually
9511 a character. Pass an int to ENCODE_CHAR.
9512 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9513 wider than 'int', as a compile-time check to prevent future regressions
9514 in this area.
9515
c5958d4c 9516 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9517
9518 Make sure a 64-bit char is never passed to CHAR_STRING.
9519 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9520 by silently ignoring the top 32 bits, allowing some values
9521 that were far too large to be valid characters.
9522 * character.h: Include <verify.h>.
9523 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9524 arguments are no wider than unsigned, as a compile-time check
9525 to prevent future regressions in this area.
9526 * data.c (Faset):
01103c44 9527 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9528 (Fsubst_char_in_region):
9529 * fns.c (concat):
9530 * xdisp.c (decode_mode_spec_coding):
9531 Adjust to CHAR_STRING's new requirement.
9532 * editfns.c (Finsert_char, Fsubst_char_in_region):
9533 * fns.c (concat): Check that character args are actually
9534 characters. Without this test, these functions did the wrong
9535 thing with wildly out-of-range values on 64-bit hosts.
9536
d37ca623
PE
9537 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9538 These casts should not be needed on 32-bit hosts, either.
9539 * keyboard.c (read_char):
9540 * lread.c (Fload): Remove casts to unsigned.
9541
ea204efb
PE
9542 * lisp.h (UNSIGNED_CMP): New macro.
9543 This fixes comparison bugs on 64-bit hosts.
9544 (ASCII_CHAR_P): Use it.
9545 * casefiddle.c (casify_object):
01103c44 9546 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9547 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9548 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9549 * dispextern.h (FACE_FROM_ID):
9550 * keyboard.c (read_char): Use UNSIGNED_CMP.
9551
41cb286c
PE
9552 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9553 not to EMACS_INT, to avoid GCC warning.
9554
4a1b9832
PE
9555 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9556
55daad71
PE
9557 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9558 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9559 isn't needed on 32-bit machines.
8f95c75c 9560
01103c44
PE
9561 * buffer.c (Fgenerate_new_buffer_name):
9562 Use EMACS_INT for count, not int.
0ceccced 9563 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9564
9565 * data.c (Qcompiled_function): Now static.
9566
c6f072e7
PE
9567 * window.c (window_body_lines): Now static.
9568
20ce5912
PE
9569 * image.c (gif_load): Rename local to avoid shadowing.
9570
9c4c5f81
PE
9571 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9572 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9573 * alloc.c (make_save_value): Integer argument is now of type
9574 ptrdiff_t, not int.
9575 (mark_object): Use ptrdiff_t, not int.
9576 * lisp.h (pD): New macro.
9577 * print.c (print_object): Use it.
9578
c0c5c8ae
PE
9579 * alloc.c: Use EMACS_INT, not int, to count objects.
9580 (total_conses, total_markers, total_symbols, total_vector_size)
9581 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9582 (total_free_floats, total_floats, total_free_intervals)
9583 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9584 Now EMACS_INT, not int. All uses changed.
9585 (Fgarbage_collect): Compute overall total using a double, so that
9586 integer overflow is less likely to be a problem. Check for overflow
9587 when converting back to an integer.
5a25e253
PE
9588 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9589 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9590 These were 'int' variables that could overflow on 64-bit hosts;
9591 they were never used, so remove them instead of repairing them.
211a0b2a 9592 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9593 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9594 Previously, this ceilinged at INT_MAX, but that doesn't work on
9595 64-bit machines.
e46bb31a 9596 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9597
c78baabf 9598 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9599 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9600 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9601 when a (possibly-narrower) signed value would do just as well.
9602 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9603
c9d624c6
PE
9604 * alloc.c: Catch some string size overflows that we were missing.
9605 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9606 for convenience in STRING_BYTES_MAX.
9607 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9608 The definition here is exact; the one in lisp.h was approximate.
9609 (allocate_string_data): Check for string overflow. This catches
9610 some instances we weren't catching before. Also, it catches
9611 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9612 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9613 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9614
c9d624c6
PE
9615 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9616 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9617 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9618
353032ce
PE
9619 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9620
2bccce07
PE
9621 * alloc.c (Fmake_string): Check for out-of-range init.
9622
0ac30604
SM
96232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9624
9625 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9626
c195f2de
JD
96272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9628
9629 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9630 xg_get_default_scrollbar_width.
9631
9632 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9633 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9634 (style_changed_cb): Call update_theme_scrollbar_width and call
9635 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9636 all frames (Bug#8505).
9637 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9638 Call gtk_window_set_resizable if HAVE_GTK3.
9639 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9640 and height if HAVE_GTK3 (Bug#8505).
9641 (scroll_bar_width_for_theme): New variable.
9642 (update_theme_scrollbar_width): New function.
9643 (xg_get_default_scrollbar_width): Move code to
9644 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9645 (xg_initialize): Call update_theme_scrollbar_width.
9646
9647 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9648
9649 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9650
e10ac9f1
MR
96512011-06-12 Martin Rudalics <rudalics@gmx.at>
9652
9653 * frame.c (make_frame): Call other_buffer_safely instead of
9654 other_buffer.
9655
9656 * window.c (temp_output_buffer_show): Call display_buffer with
9657 second argument Vtemp_buffer_show_specifiers and reset latter
9658 immediately after the call.
9659 (Vtemp_buffer_show_specifiers): New variable.
9660 (auto_window_vscroll_p, next_screen_context_lines)
9661 (Vscroll_preserve_screen_position): Remove leading asterisks from
9662 doc-strings.
9663
2d3c217e 96642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9665
7b7f97e8 9666 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9667 * buffer.c (Qclone_number): Remove for now, as it's unused.
9668 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9669 (record_buffer): Remove unused local.
9670 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9671 (set_frame_buffer_list): Remove; unused.
9672 * frame.h (other_visible_frames): Remove decl.
9673 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9674 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9675 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9676 if HAVE_GPM.
9677 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9678 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9679 Define only if HAVE_GPM.
9680 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9681 (update_hints_inhibit): Remove; never set. All uses removed.
9682 * widgetprv.h (emacsFrameClassRec): Remove decl.
9683 * window.c (delete_deletable_window): Now returns void, since it
9684 wasn't returning anything.
9685 (compare_window_configurations): Remove unused locals.
9686 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9687 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9688 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9689 the same widths as pointers. This follows up on the 2011-05-06 patch.
9690 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9691 * xterm.h: Likewise.
9692 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9693
1384b89e
JB
96942011-06-12 Juanma Barranquero <lekktu@gmail.com>
9695
9696 * makefile.w32-in: Update dependencies.
9697 (LISP_H): Add lib/intprops.h.
9698
1100a63c
CY
96992011-06-11 Chong Yidong <cyd@stupidchicken.com>
9700
9701 * image.c (gif_load): Add animation frame delay to the metadata.
9702 (syms_of_image): Use DEFSYM. New symbol `delay'.
9703
6198ccd0
MR
97042011-06-11 Martin Rudalics <rudalics@gmx.at>
9705
9706 * window.c (delete_deletable_window): Re-add.
9707 (Fset_window_configuration): Rewrite to handle dead buffers and
9708 consequently deletable windows.
9709 (window_tree, Fwindow_tree): Remove. Supply functionality in
9710 window.el.
9711 (compare_window_configurations): Simplify code.
9712
b6e3633c
AS
97132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9714
1ab0dee5
AS
9715 * image.c (imagemagick_load_image): Fix type mismatch.
9716 (Fimagemagick_types): Likewise.
9717
b6e3633c
AS
9718 * window.h (replace_buffer_in_windows): Declare.
9719
9397e56f
MR
97202011-06-11 Martin Rudalics <rudalics@gmx.at>
9721
9722 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9723 Qclone_number. Remove external declaration of Qdelete_window.
9724 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9725 code.
640c8776
SM
9726 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9727 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9728 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9729 buffer list implementation.
9730 (other_buffer_safely): New function.
9731 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9732 calls to replace_buffer_in_windows and
9733 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9734 if allowed.
9735 (record_buffer): Inhibit quitting and rewrite using quittable
9736 functions. Run Qbuffer_list_update_hook if allowed.
9737 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9738 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9739 Move switch-to-buffer to window.el.
9397e56f
MR
9740 (bury-buffer): Move to window.el.
9741 (Vbuffer_list_update_hook): New variable.
9742
9743 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9744 section.
9745
9746 * window.h (resize_frame_windows): Move up in code.
9747 (Fwindow_frame): Remove EXFUN.
9748 (replace_buffer_in_all_windows): Remove prototype.
9749 (replace_buffer_in_windows_safely): Add prototype.
9750
9751 * window.c: Declare Qdelete_window static again. Move down
9752 declaration of select_count.
9753 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9754 (Fother_window): Move to window.el.
9755 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9756 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9757 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9758 window.el.
9759 (replace_buffer_in_windows): Implement by calling
9760 Qreplace_buffer_in_windows.
9761 (replace_buffer_in_all_windows): Remove with some functionality
9762 moved into replace_buffer_in_windows_safely.
9763 (replace_buffer_in_windows_safely): New function.
9764 (select_window_norecord, select_frame_norecord): Move in front
9765 of run_window_configuration_change_hook. Remove now obsolete
9766 declarations.
640c8776
SM
9767 (Fset_window_buffer): Rewrite doc-string.
9768 Call Qrecord_window_buffer.
9397e56f
MR
9769 (keys_of_window): Move binding for other-window to window.el.
9770
b50691aa
CY
97712011-06-11 Chong Yidong <cyd@stupidchicken.com>
9772
9773 * dispextern.h (struct image): Replace data member, whose int_val
9774 and ptr_val fields were not used by anything, with a single
9775 lisp_val object.
9776
9777 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9778 (gif_clear_image, gif_load, imagemagick_load_image)
9779 (gs_clear_image, gs_load): Callers changed.
9780
3f754b86
PE
97812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9782
cca69397
PE
9783 * buffer.h: Include <time.h>, for time_t.
9784 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9785
109e28d0
PE
9786 Fix minor problems found by static checking.
9787
60737f02
PE
9788 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9789
4b66faf3
PE
9790 Make identifiers static if they are not used in other modules.
9791 * data.c (Qcompiled_function, Qframe, Qvector):
9792 * image.c (QimageMagick, Qsvg):
9793 * minibuf.c (Qmetadata):
9794 * window.c (resize_window_check, resize_root_window): Now static.
9795 * window.h (resize_window_check, resize_root_window): Remove decls.
9796
109e28d0
PE
9797 * window.c (window_deletion_count, delete_deletable_window):
9798 Remove; unused.
46a4ce9e
PE
9799 (window_body_lines): Now static.
9800 (Fdelete_other_windows_internal): Mark vars as initialized.
9801 Make sure 'resize_failed' is initialized.
9802 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9803 (resize_window_apply): Remove unused local.
9804 * window.h (delete_deletable_window): Remove decl.
9805
109e28d0 9806 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9807 (imagemagick_load_image): Fix pointer signedness problem by changing
9808 last arg from unsigned char * to char *. All uses changed.
9809 Also, fix a local for similar reasons.
9810 Remove unused locals. Remove locals to avoid shadowing.
9811 (fn_rsvg_handle_free): Remove; unused.
9812 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9813 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9814
3f754b86
PE
9815 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9816
2547adb1
CY
98172011-06-10 Chong Yidong <cyd@stupidchicken.com>
9818
9819 * image.c (gif_load): Fix omitted cast error introduced by
9820 2011-06-06 change.
9821
2c8e37d4
MR
98222011-06-10 Martin Rudalics <rudalics@gmx.at>
9823
9824 * window.h (resize_proportionally, orig_total_lines)
9825 (orig_top_line): Remove from window structure.
9826 (set_window_height, set_window_width, change_window_heights)
9827 (Fdelete_window): Remove prototypes.
9828 (resize_frame_windows): Remove duplicate declaration.
9829
440a42e3
EZ
98302011-06-10 Eli Zaretskii <eliz@gnu.org>
9831
9832 * window.h (resize_frame_windows, resize_window_check)
9833 (delete_deletable_window, resize_root_window)
9834 (resize_frame_windows): Declare prototypes.
9835
9836 * window.c (resize_window_apply): Make definition be "static" to
9837 match the prototype.
9838
562dd5e9
MR
98392011-06-10 Martin Rudalics <rudalics@gmx.at>
9840
9841 * window.c: Remove declarations of Qwindow_size_fixed,
9842 window_min_size_1, window_min_size_2, window_min_size,
9843 size_window, window_fixed_size_p, enlarge_window, delete_window.
9844 Remove static from declaration of Qdelete_window, it's
9845 temporarily needed by Fbury_buffer.
9846 (replace_window): Don't assign orig_top_line and
9847 orig_total_lines.
9848 (Fdelete_window, delete_window): Remove. Window deletion is
9849 handled by window.el.
640c8776
SM
9850 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9851 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9852 (Fdelete_other_windows): Remove. Deleting other windows is
9853 handled by window.el.
9854 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9855 handled in window.el.
9856 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9857 Window minimum sizes are handled in window.el.
9858 (shrink_windows, size_window, set_window_height)
9859 (set_window_width, change_window_heights, window_height)
9860 (window_width, CURBEG, CURSIZE, enlarge_window)
9861 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9862 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9863 handled in window.el.
9864 (make_dummy_parent): Rename to make_parent_window and give it a
9865 second argument horflag.
9866 (make_window): Don't set resize_proportionally any more.
9867 (Fsplit_window): Remove. Windows are split in window.el.
9868 (save_restore_action, save_restore_orig_size)
9869 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9870 Resize mini windows in window.el.
9871 (grow_mini_window, shrink_mini_window): Implement by calling
9872 Qresize_root_window_vertically, resize_window_check and
9873 resize_window_apply.
640c8776
SM
9874 (saved_window, Fset_window_configuration, save_window_save):
9875 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9876 resize_proportionally.
9877 (window_min_height, window_min_width): Move to window.el.
9878 (keys_of_window): Move bindings for delete-other-windows,
9879 split-window, delete-window and enlarge-window to window.el.
9880
9881 * buffer.c: Temporarily extern Qdelete_window.
9882 (Fbury_buffer): Temporarily call Qdelete_window instead of
9883 Fdelete_window (Fbury_buffer will move to window.el soon).
9884
9885 * frame.c (set_menu_bar_lines_1): Remove code handling
9886 orig_top_line and orig_total_lines.
9887
9888 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9889 set_window_height but set heights directly.
9890 (change_frame_size_1): Use resize_frame_windows.
9891
9892 * xdisp.c (init_xdisp): Don't use set_window_height but set
9893 heights directly.
9894
640c8776
SM
9895 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9896 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9897 run_window_configuration_change_hook.
9898
9899 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9900 instead of change_window_heights and run
9901 run_window_configuration_change_hook.
9902
1a13852e
MR
99032011-06-09 Martin Rudalics <rudalics@gmx.at>
9904
9905 * window.c (replace_window): Rename second argument REPLACEMENT to
9906 NEW. New third argument SETFLAG. Rewrite.
9907 (delete_window, make_dummy_parent): Call replace_window with
9908 third argument 1.
9909 (window_list_1): Move down in code.
9910 (run_window_configuration_change_hook): Move set_buffer part
9911 before select_frame_norecord part in order to unwind correctly.
9912 Rename count1 to count.
9913 (recombine_windows, delete_deletable_window, resize_root_window)
9914 (Fdelete_other_windows_internal)
9915 (Frun_window_configuration_change_hook, make_parent_window)
9916 (resize_window_check, resize_window_apply, Fresize_window_apply)
9917 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9918 (Fdelete_window_internal, Fresize_mini_window_internal):
9919 New functions.
1a13852e
MR
9920 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9921
f3d1777e
MR
99222011-06-08 Martin Rudalics <rudalics@gmx.at>
9923
496e208e
MR
9924 * window.h (window): Add some new members to window structure -
9925 normal_lines, normal_cols, new_total, new_normal, clone_number,
9926 splits, nest, prev_buffers, next_buffers.
9927 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9928 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9929
f3d1777e
MR
9930 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9931 Remove.
496e208e
MR
9932 (make_dummy_parent): Set new members of windows structure.
9933 (make_window): Move down in code. Handle new members of window
9934 structure.
9935 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9936 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9937 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9938 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9939 (Fset_window_next_buffers, Fset_window_clone_number):
9940 New functions.
496e208e
MR
9941 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9942 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9943 Doc-string fixes.
9944 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9945 Argument WINDOW can be now internal window too.
9946 (Fwindow_use_time): Move up in code.
9947 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9948 Rewrite doc-string.
9949 (Fset_window_configuration, saved_window)
9950 (Fcurrent_window_configuration, save_window_save): Handle new
9951 members of window structure.
b9e809c2
MR
9952 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9953 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9954 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9955 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9956 Qget_mru_window, Qresize_root_window,
9957 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9958 Qauto_buffer_name; staticpro them.
f3d1777e 9959
abde8f8c
MR
99602011-06-07 Martin Rudalics <rudalics@gmx.at>
9961
9962 * window.c (Fwindow_total_size, Fwindow_left_column)
9963 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9964 (Fwindow_list_1): New functions.
9965 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9966 (Fwindow_width, Fscroll_left, Fscroll_right):
9967 Use window_body_cols instead of window_box_text_cols.
9968 (delete_window, Fset_window_configuration):
9969 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9970 (delete_all_subwindows): Take a window as argument and not a
9971 structure. Rewrite.
190b47e6
MR
9972 (window_loop): Remove handling of GET_LRU_WINDOW and
9973 GET_LARGEST_WINDOW.
9974 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9975
9976 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9977 window_box_text_cols. delete_all_subwindows now takes a
9978 Lisp_Object as argument.
abde8f8c 9979
640c8776
SM
9980 * indent.c (compute_motion, Fcompute_motion):
9981 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9982
fa8a67e6
MR
9983 * frame.c (delete_frame): Call delete_all_subwindows with root
9984 window as argument.
9985
a54e3482
DC
99862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9987
9988 * fns.c (Fputhash): Document return value.
9989
60002bf5
CY
99902011-06-06 Chong Yidong <cyd@stupidchicken.com>
9991
9992 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9993
0c671da6 99942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9995
b862a52a 9996 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9997
be44ca6c
PE
9998 Check for overflow when converting integer to cons and back.
9999 * charset.c (Fdefine_charset_internal, Fdecode_char):
10000 Use cons_to_unsigned to catch overflow.
10001 (Fencode_char): Use INTEGER_TO_CONS.
10002 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10003 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10004 * data.c (long_to_cons, cons_to_long): Remove.
10005 (cons_to_unsigned, cons_to_signed): New functions.
10006 These signal an error for invalid or out-of-range values.
10007 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10008 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10009 * font.c (Ffont_variation_glyphs):
10010 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10011 * lisp.h: Include <intprops.h>.
10012 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10013 (cons_to_signed, cons_to_unsigned): New decls.
10014 (long_to_cons, cons_to_long): Remove decls.
10015 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10016 (Fprimitive_undo): Use CONS_TO_INTEGER.
10017 * xfns.c (Fx_window_property): Likewise.
10018 * xselect.c: Include <limits.h>.
10019 (x_own_selection, selection_data_to_lisp_data):
10020 Use INTEGER_TO_CONS.
10021 (x_handle_selection_request, x_handle_selection_clear)
10022 (x_get_foreign_selection, Fx_disown_selection_internal)
10023 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10024 (lisp_data_to_selection_data): Use cons_to_unsigned.
10025 (x_fill_property_data): Use cons_to_signed.
10026 Report values out of range.
10027
d1f3d2af
PE
10028 Check for buffer and string overflow more precisely.
10029 * buffer.h (BUF_BYTES_MAX): New macro.
10030 * lisp.h (STRING_BYTES_MAX): New macro.
10031 * alloc.c (Fmake_string):
10032 * character.c (string_escape_byte8):
10033 * coding.c (coding_alloc_by_realloc):
10034 * doprnt.c (doprnt):
10035 * editfns.c (Fformat):
10036 * eval.c (verror):
10037 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10038 since they may not be the same number.
10039 * editfns.c (Finsert_char):
10040 * fileio.c (Finsert_file_contents):
10041 Likewise for BUF_BYTES_MAX.
10042
dd52fcea
PE
10043 * image.c: Use ptrdiff_t, not int, for sizes.
10044 (slurp_file): Switch from int to ptrdiff_t.
10045 All uses changed.
10046 (slurp_file): Check that file size fits in both size_t (for
10047 malloc) and ptrdiff_t (for sanity and safety).
10048
7f9bbdbb
PE
10049 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10050 if b->modtime has its maximal value.
10051
dfe18f82
PE
10052 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10053
84acfcf0
PE
10054 Don't assume time_t can fit into int.
10055 * buffer.h (struct buffer.modtime): Now time_t, not int.
10056 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10057 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10058
ccd9a01a
PE
10059 Minor fixes for signed vs unsigned integers.
10060 * character.h (MAYBE_UNIFY_CHAR):
10061 * charset.c (maybe_unify_char):
10062 * keyboard.c (read_char, reorder_modifiers):
10063 XINT -> XFASTINT, since the integer must be nonnegative.
10064 * ftfont.c (ftfont_spec_pattern):
10065 * keymap.c (access_keymap, silly_event_symbol_error):
10066 XUINT -> XFASTINT, since the integer must be nonnegative.
10067 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10068 since it makes no difference and we prefer signed.
10069 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10070 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10071 nonnegative.
10072
d6d100dd
SM
100732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10074
10075 * window.h (Fwindow_frame): Declare.
10076
2b6148e4
PE
100772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10078
10079 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10080 (SPARE_MEMORY): Always define.
10081 (LARGE_REQUEST): Remove.
10082 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10083
f230ecc9
MR
100842011-06-06 Martin Rudalics <rudalics@gmx.at>
10085
727e958e
MR
10086 * lisp.h: Move EXFUNS for Fframe_root_window,
10087 Fframe_first_window and Fset_frame_selected_window to window.h.
10088
10089 * window.h: Move EXFUNS for Fframe_root_window,
10090 Fframe_first_window and Fset_frame_selected_window here from
10091 lisp.h.
10092
10093 * frame.c (Fwindow_frame, Fframe_first_window)
10094 (Fframe_root_window, Fframe_selected_window)
10095 (Fset_frame_selected_window): Move to window.c.
10096 (Factive_minibuffer_window): Move to minibuf.c.
10097 (Fother_visible_frames_p): New function.
10098
10099 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10100
f230ecc9
MR
10101 * window.c (decode_window, decode_any_window): Move up in code.
10102 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10103 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10104 (Fwindow_buffer): Move up and rewrite doc-string.
10105 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10106 (Fwindow_prev): New functions.
727e958e
MR
10107 (Fwindow_frame): Move here from frame.c. Accept any window as
10108 argument.
10109 (Fframe_root_window, Fframe_first_window)
10110 (Fframe_selected_window): Move here from frame.c. Accept frame
10111 or arbitrary window as argument. Update doc-strings.
10112 (Fminibuffer_window): Move up in code.
10113 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10114 (Fset_frame_selected_window): Move here from frame.c.
10115 Marginal rewrite.
727e958e
MR
10116 (Fselected_window, select_window, Fselect_window): Move up in
10117 code. Minor doc-string fixes.
f230ecc9 10118
4d09bcf6
PE
101192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10120
10121 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10122 Do not assume that spare memory exists; that assumption is valid
10123 only if SYSTEM_MALLOC.
10124 (LARGE_REQUEST): New macro, so that the issue of large requests
10125 is separated from the issue of spare memory.
10126
810928a2
AS
101272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10128
172418ad
AS
10129 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10130 format. (Bug#8806)
10131
43f862f7
AS
10132 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10133
810928a2
AS
10134 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10135 before statements.
10136
a059fe24
JD
101372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10138
10139 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10140
10141 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10142
10143 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10144 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10145
989bf368
JB
101462011-06-05 Juanma Barranquero <lekktu@gmail.com>
10147
10148 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10149
4b80f674
CY
101502011-06-04 Chong Yidong <cyd@stupidchicken.com>
10151
10152 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10153 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10154 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10155 New error handlers.
4b80f674
CY
10156 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10157 Obey Vx_select_enable_clipboard_manager. Catch errors in
10158 x_clipboard_manager_save (Bug#8779).
10159 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10160 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10161
99a33b77 101622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10163
10164 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10165
99a33b77 101662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10167
10168 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10169 in the current matrix if keep_current_p is non-zero.
10170
8264569d
EZ
101712011-06-04 Eli Zaretskii <eliz@gnu.org>
10172
10173 * bidi.c (bidi_level_of_next_char): Fix last change.
10174
57f97249
EZ
101752011-06-03 Eli Zaretskii <eliz@gnu.org>
10176
fec2107c 10177 Support bidi reordering of text covered by display properties.
57f97249 10178
fec2107c
EZ
10179 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10180 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10181 (bidi_cache_search, bidi_cache_iterator_state)
10182 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10183 (bidi_level_of_next_char, bidi_move_to_visually_next):
10184 Support character positions inside a run of characters covered by a
fec2107c
EZ
10185 display string.
10186 (bidi_paragraph_init, bidi_resolve_explicit_1)
10187 (bidi_level_of_next_char): Call bidi_fetch_char and
10188 bidi_fetch_char_advance instead of FETCH_CHAR and
10189 FETCH_CHAR_ADVANCE.
10190 (bidi_init_it): Initialize new members.
10191 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10192 definitions.
10193 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10194 instead of using explicit *_CHAR codes.
d6d100dd
SM
10195 (bidi_resolve_explicit, bidi_resolve_weak):
10196 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10197 bidirectional text is supported only in multibyte buffers.
10198 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10199 it to initialize the frame_window_p member of struct bidi_it.
10200 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10201 (bidi_resolve_explicit, bidi_resolve_weak)
10202 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10203 bidi_it->nchars is non-positive.
10204 (bidi_level_of_next_char): Don't try to lookup the cache for the
10205 next/previous character if nothing is cached there yet, or if we
10206 were just reseat()'ed to a new position.
c40e2fb2 10207
0e14fe90
EZ
10208 * xdisp.c (set_cursor_from_row): Set start and stop points
10209 according to the row's direction when priming the loop that looks
10210 for the glyph on which to display cursor.
10211 (single_display_spec_intangible_p): Function deleted.
10212 (display_prop_intangible_p): Reimplement to call
10213 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10214 Accept 3 additional arguments needed by handle_display_spec.
10215 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10216 values: lists, `(when COND...)' forms, etc.
10217 (single_display_spec_string_p): Support property values that are
10218 lists with the argument STRING its top-level element.
10219 (display_prop_string_p): Fix the condition for processing a
10220 property that is a list to be consistent with handle_display_spec.
fec2107c 10221 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10222 last portion of handle_display_prop.
10223 (compute_display_string_pos): Accept additional argument
10224 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10225 value of a `display' property is a "replacing spec".
10226 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10227 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10228 the display property, but just return a value indicating whether
10229 the display property will replace the characters it covers.
10230 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10231 frame_window_p members of struct bidi_it.
d6d100dd
SM
10232 (compute_display_string_pos, compute_display_string_end):
10233 New functions.
fec2107c
EZ
10234 (push_it): Accept second argument POSITION, where pop_it should
10235 jump to continue iteration.
10236 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10237
fec2107c
EZ
10238 * keyboard.c (adjust_point_for_property): Adjust the call to
10239 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10240
10241 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10242 (bidi_init_it): Update prototypes.
10243 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10244 (compute_display_string_pos, compute_display_string_end):
10245 Declare prototypes.
fec2107c
EZ
10246 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10247 EMACS_INT.
fc6f18ce 10248
40087514 102492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10250
57f53182
PE
10251 Malloc failure behavior now depends on size of allocation.
10252 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10253 * lisp.h: Change signatures accordingly.
10254 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10255 All callers changed. (Bug#8762)
10256
10257 * gnutls.c: Use Emacs's memory allocators.
10258 Without this change, the gnutls library would invoke malloc etc.
10259 directly, which causes problems on non-SYNC_INPUT hosts, and which
10260 runs afoul of improving memory_full behavior. (Bug#8761)
10261 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10262 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10263 xfree instead of the default malloc, realloc, free.
10264 (Fgnutls_boot): No need to check for memory allocation failure,
10265 since xmalloc does that for us.
10266
ac32cd99 10267 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10268 * category.c (hash_get_category_set):
10269 * ccl.c (ccl_driver):
10270 * charset.c (Fdefine_charset_internal):
10271 * charset.h (struct charset.hash_index):
10272 * composite.c (get_composition_id, gstring_lookup_cache)
10273 (composition_gstring_put_cache):
10274 * composite.h (struct composition.hash_index):
10275 * dispextern.h (struct image.hash):
10276 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10277 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10278 (hashfn_equal, hashfn_user_defined, make_hash_table)
10279 (maybe_resize_hash_table, hash_lookup, hash_put)
10280 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10281 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10282 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10283 * image.c (make_image, search_image_cache, lookup_image)
10284 (xpm_put_color_table_h):
10285 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10286 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10287 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10288 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10289 * alloc.c (allocate_vectorlike):
10290 Check for overflow in vector size calculations.
10291 * ccl.c (ccl_driver):
10292 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10293 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10294 need to be updated by these changes.
40087514
PE
10295 * fns.c (make_hash_table, maybe_resize_hash_table):
10296 Check for integer overflow with large hash tables.
0de4bb68
PE
10297 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10298 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10299 (SXHASH_REDUCE): New macro.
10300 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10301 Use it instead of discarding useful hash info with large hash values.
10302 (sxhash_float): New function.
10303 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10304 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10305 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10306 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10307 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10308 Adjust signatures to match updated version of code.
10309 (consing_since_gc): Now EMACS_INT, since a single hash table can
10310 use more than INT_MAX bytes.
10311
698d32e2
DN
103122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10313
10314 Make it possible to build with GCC-4.6+ -O2 -flto.
10315
10316 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10317
fd6fa53f
SM
103182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10319
10320 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10321 Call minibuffer-inactive-mode.
10322
864db017
JB
103232011-05-31 Juanma Barranquero <lekktu@gmail.com>
10324
10325 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10326 Update dependencies.
10327
2ad0baf4
DN
103282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10329
10330 * data.c (init_data): Remove code for UTS, this system is not
10331 supported anymore.
10332
4fcc2638
DN
103332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10334
10335 Don't force ./temacs to start in terminal mode.
10336
10337 * frame.c (make_initial_frame): Initialize faces in all cases, not
10338 only when CANNOT_DUMP is defined.
10339 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10340
c56e0fd5
DN
103412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10342
10343 * dispnew.c (add_window_display_history): Use const for the string
10344 pointer. Remove declaration, not needed.
10345
333d54da 103462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10347
55d4c1b2 10348 Use 'inline', not 'INLINE'.
333d54da 10349 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10350 * alloc.c, fontset.c (INLINE): Remove.
10351 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10352 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10353 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10354 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10355 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10356
738db178
DN
103572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10358
10359 Make it possible to run ./temacs.
10360
10361 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10362 syms_of_callproc does the same thing. Remove test for
10363 "initialized", do it in the caller.
10364 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10365
620c53a6
SM
103662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10367
10368 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10369 (read_minibuf): Use get_minibuffer.
10370 (syms_of_minibuf): Use DEFSYM.
10371 (Qmetadata): New var.
10372 * data.c (Qbuffer): Don't make it static.
10373 (syms_of_data): Use DEFSYM.
10374
e003a292
PE
103752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10376
10377 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10378 (CCL_CODE_MIN): New macro.
10379
ed008a6d
PE
103802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10381
3687c2ef
PE
10382 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10383
ed008a6d
PE
10384 * eval.c (Qdebug): Now static.
10385 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10386 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10387 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10388
d66c4c7c
CY
103892011-05-29 Chong Yidong <cyd@stupidchicken.com>
10390
10391 * image.c: Various fixes to ImageMagick code comments.
10392 (Fimagemagick_types): Doc fix.
10393
5fbc2025
PE
103942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10395
0196f88a
PE
10396 Minor fixes prompted by GCC 4.6.0 warnings.
10397
10398 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10399
5fbc2025
PE
10400 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10401 (x_clipboard_manager_save_all): Move extern decl to ...
10402 * xterm.h: ... here, so that it can be checked for consistency.
10403
1dd3c2d9
CY
104042011-05-29 Chong Yidong <cyd@stupidchicken.com>
10405
10406 * xselect.c (x_clipboard_manager_save_frame)
10407 (x_clipboard_manager_save_all): New functions.
10408 (Fx_clipboard_manager_save): Lisp function deleted.
10409
10410 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10411 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10412
10413 * xterm.h: Update prototype.
10414
5ba6571d
WX
104152011-05-28 William Xu <william.xwl@gmail.com>
10416
10417 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10418 exiting (Bug#8239).
10419
3eaff834
JM
104202011-05-28 Jim Meyering <meyering@redhat.com>
10421
e1900994 10422 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10423 * fns.c (to_uchar): Define.
10424 (crypto_hash_function): Use it to convert some newly-signed
10425 variables to unsigned, to avoid sign-extension bugs. For example,
10426 without this change, (md5 "truc") would evaluate to
10427 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10428 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10429 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10430
0f6990a7
PE
104312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10432
10433 Integer overflow fixes.
c8a9ca5a 10434
08686060
PE
10435 * dbusbind.c: Serial number integer overflow fixes.
10436 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10437 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10438 to hold a serial number that is too large for a fixnum.
10439 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10440 Check for serial numbers out of range. Decode any serial number
59568bf0 10441 that was so large that it became a float. (Bug#8722)
08686060 10442
2d1fc3c7
PE
10443 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10444 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10445 Use XFASTINT rather than XUINT when numbers are nonnegative.
10446 (xd_append_arg, Fdbus_method_return_internal):
10447 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10448 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10449 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10450 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10451 (Bug#8722)
2d1fc3c7 10452
c8a9ca5a
PE
10453 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10454
519e1d69
PE
10455 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10456
6df6ae42 10457 ccl: Add integer overflow checks.
30569699
PE
10458 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10459 (IN_INT_RANGE): New macros.
10460 (ccl_driver): Use them to check for integer overflow when
10461 decoding a CCL program. Many of the new checks are whether XINT (x)
10462 fits in int; it doesn't always, on 64-bit hosts. The new version
10463 doesn't catch all possible integer overflows, but it's an
847044ea 10464 improvement. (Bug#8719)
30569699 10465
c11285dc
PE
10466 * alloc.c (make_event_array): Use XINT, not XUINT.
10467 There's no need for unsigned here.
10468
fdccd48e
PE
10469 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10470 This follows up to the 2011-05-06 change that substituted uintptr_t
10471 for EMACS_INT. This case wasn't caught back then.
10472
37910ab2
PE
10473 Rework Fformat to avoid integer overflow issues.
10474 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10475 now (part of C89). Include <verify.h>.
10476 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10477 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10478 (Fformat): Avoid the prepass trying to compute sizes; it was only
10479 approximate and thus did not catch overflow reliably. Instead, walk
10480 through the format just once, formatting and computing sizes as we go,
10481 checking for integer overflow at every step, and allocating a larger
10482 buffer as needed. Keep track separately whether the format is
10483 multibyte. Keep only the most-recently calculated precision, rather
10484 than them all. Record whether each argument has been converted to
10485 string. Use EMACS_INT, not int, for byte and char and arg counts.
10486 Support field widths and precisions larger than INT_MAX. Avoid
10487 sprintf's undefined behavior with conversion specifications such as %#d
10488 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10489 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10490 formatting out-of-range floating point numbers with int
9173deec 10491 formats. (Bug#8668)
37910ab2 10492
2e6578fb
PE
10493 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10494
0ae6bdee
PE
10495 * data.c: Avoid integer truncation in expressions involving floats.
10496 * data.c: Include <intprops.h>.
10497 (arith_driver): When there's an integer overflow in an expression
10498 involving floating point, convert the integers to floating point
10499 so that the resulting value does not suffer from catastrophic
10500 integer truncation. For example, on a 64-bit host (* 4
10501 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10502 Do not rely on undefined behavior after integer overflow.
10503
de883a70
PE
10504 merge count_size_as_multibyte, parse_str_to_multibyte
10505 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10506 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10507 Check for integer overflow.
10508 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10509 since it's now a duplicate of the other. This is more of
10510 a character than a buffer op, so better that it's in character.c.
10511 * fns.c, print.c: Adjust to above changes.
10512
2ff916cb
PE
105132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10514
10515 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10516
f1b54466
PE
105172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10518
fb1ac845
PE
10519 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10520 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10521 (x_clipboard_manager_save): Now static.
10522 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10523
f1b54466
PE
10524 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10525 (crypto_hash_function): Now static.
10526 Fix pointer signedness problems. Avoid unnecessary initializations.
10527
a9f737ee
CY
105282011-05-27 Chong Yidong <cyd@stupidchicken.com>
10529
10530 * termhooks.h (Vselection_alist): Make it terminal-local.
10531
10532 * terminal.c (create_terminal): Initialize it.
10533
10534 * xselect.c: Support for clipboard managers.
10535 (Vselection_alist): Move to termhooks.h as terminal-local var.
10536 (LOCAL_SELECTION): New macro.
10537 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10538 (symbol_to_x_atom): Remove gratuitous arg.
10539 (x_handle_selection_request, lisp_data_to_selection_data)
10540 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10541 (x_own_selection, x_get_local_selection, x_convert_selection):
10542 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10543 (some_frame_on_display): Delete unused function.
10544 (Fx_own_selection_internal, Fx_get_selection_internal)
10545 (Fx_disown_selection_internal, Fx_selection_owner_p)
10546 (Fx_selection_exists_p): New optional frame arg.
10547 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10548 (x_handle_selection_clear): Don't treat other terminals with the
10549 same keyboard specially. Use the terminal-local Vselection_alist.
10550 (x_clear_frame_selections): Use Frun_hook_with_args.
10551
10552 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10553
10554 * xterm.h: Add support for those atoms.
10555
e067f0c1
CY
105562011-05-26 Chong Yidong <cyd@stupidchicken.com>
10557
10558 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10559 (converted_selections, conversion_fail_tag): New global variables.
10560 (x_selection_request_lisp_error): Free the above.
10561 (x_get_local_selection): Remove unnecessary code.
10562 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10563 of converted selections stored in converted_selections.
10564 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10565 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10566 (x_convert_selection): New function.
10567 (x_handle_selection_event): Simplify.
10568 (x_get_foreign_selection): Don't ignore incoming requests while
10569 waiting for an answer; this will fail when we implement
10570 SAVE_TARGETS, and seems unnecessary anyway.
10571 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10572 (Vx_sent_selection_functions): Doc fix.
10573
0f4aebc0
LL
105742011-05-26 Leo Liu <sdl.web@gmail.com>
10575
10576 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10577
e61124cd
YM
105782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10579
10580 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10581
10582 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10583 for fringe update if it has periodic bitmap.
ac389d0c 10584 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10585 and fringe_bitmap_periodic_p.
10586
10587 * fringe.c (get_fringe_bitmap_data): New function.
10588 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10589 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10590 row. Mark glyph row for fringe update if periodicity changed.
10591
10592 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10593 for fringe update unless it has periodic bitmap.
10594
f16d9837
KH
105952011-05-25 Kenichi Handa <handa@m17n.org>
10596
10597 * xdisp.c (get_next_display_element): Set correct it->face_id for
10598 a static composition.
10599
e1b90ef6
LL
106002011-05-24 Leo Liu <sdl.web@gmail.com>
10601
10602 * deps.mk (fns.o):
10603 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10604
10605 * fns.c (crypto_hash_function, Fsha1): New function.
10606 (Fmd5): Use crypto_hash_function.
10607 (syms_of_fns): Add Ssha1.
10608
7400048f
PE
106092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10610
10611 * gnutls.c: Remove unused macros.
10612 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10613 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10614 Remove macros that are defined and never used.
10615 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10616
abb71cf4
CY
106172011-05-22 Chong Yidong <cyd@stupidchicken.com>
10618
10619 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10620 (Fx_get_selection_internal): Minor cleanup.
10621 (Fx_own_selection_internal): Rename arguments for consistency with
10622 select.el.
10623
6307db39
PE
106242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10625
10626 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10627
f3d4e0a4
CY
106282011-05-22 Chong Yidong <cyd@stupidchicken.com>
10629
10630 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10631
4d8ade89
YM
106322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10633
10634 * dispnew.c (scrolling_window): Don't exclude the case that the
10635 last enabled row in the desired matrix touches the bottom boundary.
10636
32078c8d
GM
106372011-05-21 Glenn Morris <rgm@gnu.org>
10638
10639 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10640 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10641 and add some more files.
32078c8d 10642
7285dc67
EZ
106432011-05-20 Eli Zaretskii <eliz@gnu.org>
10644
10645 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10646 report_file_error introduced by the change from 2011-05-07.
10647
89d1bd22
PE
106482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10649
10650 * systime.h (Time): Define only if emacs is defined.
10651 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10652 where the include path doesn't have X11/X.h by default. See
10653 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10654
cd394be1 106552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10656
10657 * composite.c (find_automatic_composition): Fix previous change.
10658
b9704ad9
GM
106592011-05-20 Glenn Morris <rgm@gnu.org>
10660
10661 * lisp.mk: New file, split from Makefile.in.
10662 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10663 (shortlisp): Remove.
10664 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10665
4a720484
GM
106662011-05-19 Glenn Morris <rgm@gnu.org>
10667
10668 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10669 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10670 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10671 (lisp): Set the order to that of loadup.el.
10672 (shortlisp): Make it a copy of $lisp.
10673 (SOME_MACHINE_LISP): Remove.
10674 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10675 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10676
a28d4396
KH
106772011-05-18 Kenichi Handa <handa@m17n.org>
10678
10679 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10680 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10681 (find_automatic_composition): Mostly rewrite for efficiency.
10682
a2b1fa8e
JB
106832011-05-18 Juanma Barranquero <lekktu@gmail.com>
10684
10685 * makefile.w32-in: Update dependencies.
10686
8e1f5610
CS
106872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10688
10689 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10690 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10691
7025ee00 106922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10693
cdfa6eab
PE
10694 Fix some integer overflow issues, such as string length overflow.
10695
06d6db33
PE
10696 * insdel.c (count_size_as_multibyte): Check for string overflow.
10697
2b4560a8
PE
10698 * character.c (lisp_string_width): Check for string overflow.
10699 Use EMACS_INT, not int, for string indexes and lengths; in
10700 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10701 the resulting string length overflows an EMACS_INT; instead,
10702 report a string overflow if no precision given. When checking for
10703 precision exhaustion, use a check that cannot possibly have
10704 integer overflow. (Bug#8675)
10705 * character.h (lisp_string_width): Adjust to new signature.
10706
cb93f9be
PE
10707 * alloc.c (string_overflow): New function.
10708 (Fmake_string): Use it. This doesn't change behavior, but saves
10709 a few bytes and will simplify future changes.
10710 * character.c (string_escape_byte8): Likewise.
10711 * lisp.h (string_overflow): New decl.
10712
1a1f3366
PE
10713 Fixups, following up to the user-interface timestamp change.
10714 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10715 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10716 * msdos.c (mouse_get_pos): Likewise.
10717 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10718 * w32gui.h (Time): Define by including "systime.h" rather than by
10719 declaring it ourselves. (Bug#8664)
10720
d4e3e4d3
PE
10721 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10722 * image.c (clear_image_cache): Likewise.
10723
f6a24d19
PE
10724 * term.c (term_mouse_position): Don't assume time_t wraparound.
10725
08dc5ae6
PE
10726 Be more systematic about user-interface timestamps.
10727 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10728 and sometimes 'EMACS_UINT', to represent these timestamps.
10729 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10730 This makes the code easier to follow, and makes it easier to catch
10731 integer overflow bugs such as Bug#8664.
10732 * frame.c (Fmouse_position, Fmouse_pixel_position):
10733 Use Time, not unsigned long, for user-interface timestamps.
10734 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10735 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10736 * keyboard.h (last_event_timestamp): Likewise.
10737 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10738 * menu.h (xmenu_show): Likewise.
10739 * term.c (term_mouse_position): Likewise.
10740 * termhooks.h (struct input_event.timestamp): Likewise.
10741 (struct terminal.mouse_position_hook): Likewise.
10742 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10743 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10744 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10745 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10746 what it was before.
10747 * menu.h, termhooks.h: Include "systime.h", for Time.
10748
8e55734a
PE
10749 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10750 Don't assume that the difference between two unsigned long values
10751 can fit into an integer. At this point, we know button_down_time
10752 <= event->timestamp, so the difference must be nonnegative, so
10753 there's no need to cast the result if double-click-time is
10754 nonnegative, as it should be; check that it's nonnegative, just in
10755 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10756 apart (about 25 days). (Bug#8664)
8e55734a 10757
841f1b75 10758 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10759 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10760
3e26f69c
PE
10761 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10762 that always fit in int. Use a sentinel instead of a counter, to
10763 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10764 * frame.h (struct frame): Use int for menu_bar_items_used
10765 instead of EMACS_INT, since it always fits in int.
3e26f69c 10766
5cc152c0
PE
10767 * menu.c (grow_menu_items): Check for int overflow.
10768
d89eb65e
PE
10769 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10770
5235bd3e
PE
10771 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10772 Before, the code was not consistent. These values cannot exceed
10773 2**31 - 1 so there's no need to make them unsigned.
10774 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10775 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10776 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10777 as modifiers.
10778 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10779
bc827e23
PE
10780 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10781 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10782 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10783 presumably because the widths might not match.
10784
78eb494e
PE
10785 * window.c (size_window): Avoid needless test at loop start.
10786
04f2d78b
CB
107872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10788
10789 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10790
d2fc7e3d 107912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10792
10793 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10794
d2fc7e3d 107952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10796
10797 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10798 `width' to `bar_area_x' and `bar_area_width', respectively.
10799 (x_scroll_run): Take account of fringe background extension.
10800
04f2d78b
CB
10801 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10802 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10803 `bar_area_width', respectively.
10804 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10805 background extension.
10806
79b70037
GM
108072011-05-10 Jim Meyering <meyering@redhat.com>
10808
10809 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10810
2f142cc5
JB
108112011-05-10 Juanma Barranquero <lekktu@gmail.com>
10812
10813 * image.c (Finit_image_library): Return t for built-in image types,
10814 like pbm and xbm. (Bug#8640)
10815
57679c86
AS
108162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10817
10818 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10819
888c9e86
EZ
108202011-05-07 Eli Zaretskii <eliz@gnu.org>
10821
b0512a1d
EZ
10822 * w32console.c (Fset_screen_color): Doc fix.
10823 (Fget_screen_color): New function.
10824 (syms_of_ntterm): Defsubr it.
10825
7285dc67
EZ
10826 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10827 unlink the temporary file if Fcall_process didn't create it in the
10828 first place.
10829 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10830 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10831 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10832 cue to call_process_cleanup not to close that handle.
10833
4d3fcc8e
BK
108342011-05-07 Ben Key <bkey76@gmail.com>
10835
10836 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10837 one of two shell specific rules, either bootstrap-temacs-CMD or
10838 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10839 to the previous implementation of the bootstrap-temacs rule.
10840 The bootstrap-temacs-CMD rule is similar to the previous
10841 implementation of the bootstrap-temacs rule except that it
10842 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10843 variable.
10844
10845 These changes, along with some changes to nt/configure.bat,
10846 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10847 earlier fix to add support for --cflags and --ldflags options
10848 that include quotes so that it works whether make uses cmd or
10849 sh as the shell.
10850
b4289b64
MA
108512011-05-06 Michael Albinus <michael.albinus@gmx.de>
10852
10853 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10854 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10855 is a constant.
10856 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10857 a string. Handle both cases.
10858 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10859 (Fdbus_register_method): Use Qinvalid_function.
10860
af4c0e28
JB
108612011-05-06 Juanma Barranquero <lekktu@gmail.com>
10862
10863 * makefile.w32-in: Update dependencies.
10864 (LISP_H): Add inttypes.h and stdin.h.
10865 (PROCESS_H): Add unistd.h.
10866
c51453d9
EZ
108672011-05-06 Eli Zaretskii <eliz@gnu.org>
10868
10869 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10870 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10871
8ff0ac3c 108722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10873
4c4b566b
PE
10874 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10875
aab2b9b5
PE
10876 * term.c (vfatal): Remove stray call to va_end.
10877 It's not needed and the C Standard doesn't allow it here anyway.
10878
c378da0b
PE
10879 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10880 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10881
288b08c7
PE
10882 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10883 bytes.
10884
e3601888
PE
10885 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10886
db6c0e74
PE
10887 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10888
dd5963ea
PE
10889 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10890
88c9450f
PE
10891 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10892
2f9442b8
PE
10893 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10894
c032b5f8
PE
10895 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10896 * charset.c (Fdefine_charset_internal): Don't initialize
10897 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10898 32-bit int (Bug#8600).
a108c10b
PE
10899
10900 * lread.c (read_integer): Be more consistent with string-to-number.
10901 Use string_to_number to do the actual conversion; this avoids
10902 rounding errors and fixes some other screwups. Without this fix,
10903 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10904 (digit_to_number): Move earlier, for benefit of read_integer.
10905 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10906 not a digit in any supported base. (Bug#8602)
a108c10b 10907
ad5f9eea
PE
10908 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10909
aec1708a
PE
10910 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10911 to match comment at start of function. This also removes a
10912 GCC warning about overflow in a 32+64-bit port.
10913
47be4ab5
PE
10914 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10915
371cac43
PE
10916 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10917 Reported by Stefan Monnier in
10918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10919 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10920 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10921
d01a7826
PE
10922 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10923 (EMACS_UINTPTR): Likewise, with uintptr_t.
10924
7fd47d5c
PE
10925 * lisp.h: Prefer 64-bit EMACS_INT if available.
10926 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10927 on 32-bit hosts that have 64-bit int, so that they can access
10928 large files.
122b0c86
PE
10929 However, temporarily disable this change unless the temporary
10930 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10931
8727937b
PE
10932 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10933
8ac068ac
PE
10934 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10935 This removes an assumption that EMACS_INT and long are the same
10936 width as pointers. The assumption is true for Emacs porting targets
10937 now, but we want to make other targets possible.
10938 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10939 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10940 In the rest of the code, change types of integers that hold casted
10941 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10942 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10943 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10944 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10945 No need to cast type when ORing.
10946 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10947 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10948 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10949 assume EMACS_INT is the same width as char *.
10950 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10951 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10952 Remove no-longer-needed casts.
10953 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10954 (xg_tool_bar_help_callback, xg_make_tool_item):
10955 Use EMACS_INTPTR to hold an integer
10956 that will be cast to void *; this can avoid a GCC warning
10957 if EMACS_INT is not the same width as void *.
10958 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10959 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10960 (current_message_1, set_message_1):
10961 Use a local to convert to proper width without a cast.
10962 * xmenu.c (dialog_selection_callback): Likewise.
10963
ede49d71
PE
10964 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10965 Also, don't assume VALBITS / RAND_BITS is less than 5,
10966 and don't rely on undefined behavior when shifting a 1 left into
10967 the sign bit.
10968 * lisp.h (get_random): Change signature to match.
10969
2f30ecd0
PE
10970 * lread.c (hash_string): Use size_t, not int, for hash computation.
10971 Normally we prefer signed values; but hashing is special, because
10972 it's better to use unsigned division on hash table sizes so that
10973 the remainder is nonnegative. Also, size_t is the natural width
10974 for hashing into memory. The previous code used 'int', which doesn't
10975 retain enough info to hash well into very large tables.
10976 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10977
2a866e7b
PE
10978 * dbusbind.c: Don't possibly lose pointer info when converting.
10979 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10980 Use XPNTR rather than XHASH, so that the high-order bits of
10981 the pointer aren't lost when converting through void *.
10982
51639eac
PE
10983 * eval.c (Fautoload): Don't double-shift a pointer.
10984
92394119
PE
10985 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10986
dbdb9a7c
JB
109872011-05-06 Juanma Barranquero <lekktu@gmail.com>
10988
10989 * gnutls.c (DEF_GNUTLS_FN):
10990 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10991
db7a0b4f
AS
109922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10993
10994 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10995 marker. (Bug#8610)
10996
cd394be1 109972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10998
10999 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11000 New version that can reserve upto 2GB of heap space.
11001
f7ff1b0f 110022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11003
11004 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11005
639c109b
TZ
110062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11007
11008 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11009 `gnutls_certificate_set_x509_key_file'.
11010
d2127135
JB
110112011-05-05 Juanma Barranquero <lekktu@gmail.com>
11012
11013 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11014 Update dependencies.
11015
e968f4f3
JB
110162011-05-04 Juanma Barranquero <lekktu@gmail.com>
11017
11018 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11019 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11020 Remove unused parameter `fildes'.
11021 * process.c (read_process_output, send_process): Don't pass it.
11022
84d358f0
JB
110232011-05-04 Juanma Barranquero <lekktu@gmail.com>
11024
11025 Fix previous change: the library cache is defined in w32.c.
11026 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11027 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11028
0898ca10
JB
110292011-05-04 Juanma Barranquero <lekktu@gmail.com>
11030
11031 Implement dynamic loading of GnuTLS on Windows.
11032
11033 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11034 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11035 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11036 Declare.
11037
11038 * gnutls.c (Qgnutls_dll): Define.
11039 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11040 (gnutls_*): Declare function pointers.
11041 (init_gnutls_functions): New function to initialize function pointers.
11042 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11043 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11044 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11045 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11046 (emacs_gnutls_write, emacs_gnutls_read)
11047 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11048 (Fgnutls_available_p): New function.
11049 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11050 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11051 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11052
11053 * image.c: Include w32.h.
11054 (Vimage_type_cache): Delete.
11055 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11056 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11057 (w32_delayed_load): Move to w32.c.
11058
11059 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11060
11061 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11062 (w32_delayed_load): Move from image.c. When loading a library, record
11063 its filename in the :loaded-from property of the library id.
11064 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11065 Initialize and staticpro them.
11066 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11067
11068 * process.c: Include lisp.h before w32.h, not after.
11069 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11070 instead of gnutls_record_check_pending.
11071
11072 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11073
ff4de4aa
TZ
110742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11075
11076 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11077 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11078 as passed in.
11079
abe95abb
JD
110802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11081
11082 * xterm.c (x_set_frame_alpha): Do not set property on anything
11083 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11084
e16e55d4
JB
110852011-05-02 Juanma Barranquero <lekktu@gmail.com>
11086
11087 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11088
bafcf6a5
JB
110892011-05-02 Juanma Barranquero <lekktu@gmail.com>
11090
11091 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11092 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11093 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11094 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11095 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11096 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11097 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11098 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11099 (Qgnutls_bootprop_callbacks_verify): Make static.
11100
e7a6747f
AS
111012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11102
19ed11ba
AS
11103 * callproc.c: Indentation fixup.
11104
e7a6747f 11105 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11106 (wait_for_termination, interruptible_wait_for_termination):
11107 Move after wait_for_termination_1.
e7a6747f 11108
1ef14cb4
LMI
111092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11110
11111 * sysdep.c (interruptible_wait_for_termination): New function
11112 which is like wait_for_termination, but allows keyboard
11113 interruptions.
11114
11115 * callproc.c (Fcall_process): Add (:file "file") as an option for
11116 the STDOUT buffer.
11117 (Fcall_process_region): Ditto.
11118
330d880c
EZ
111192011-04-30 Eli Zaretskii <eliz@gnu.org>
11120
8db90b73
EZ
11121 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11122 rather than `XVECTOR (FOO)->size'.
11123
330d880c
EZ
11124 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11125 inttypes.h, as a gnulib replacement is used if it not available in
11126 system headers.
11127
15cbd324
EZ
111282011-04-21 Eli Zaretskii <eliz@gnu.org>
11129
11130 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11131 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11132 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11133
11134 * coding.c (coding_alloc_by_realloc): Error out if destination
11135 will grow beyond MOST_POSITIVE_FIXNUM.
11136 (decode_coding_emacs_mule): Abort if there isn't enough place in
11137 charbuf for the composition carryover bytes. Reserve an extra
11138 space for up to 2 characters produced in a loop.
11139 (decode_coding_iso_2022): Abort if there isn't enough place in
11140 charbuf for the composition carryover bytes.
11141
111422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11143
ae940cca
EZ
11144 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11145 aborting when %lld or %lll format is passed.
11146 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11147 %llo or %llx format is passed. (Bug#8545)
11148
03ab8921
EZ
11149 * window.c (window_scroll_line_based): Use a marker instead of
11150 simple variables to record original value of point. (Bug#7952)
11151
afda1437
EZ
11152 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11153 produced by %s or %c overflows available buffer space. (Bug#8545)
11154
f76dee0c
PE
111552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11156
11157 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11158 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11159
fdc5744d
JB
111602011-04-28 Juanma Barranquero <lekktu@gmail.com>
11161
11162 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11163
638f053a
JB
111642011-04-28 Juanma Barranquero <lekktu@gmail.com>
11165
11166 * keyboard.c (Qdelayed_warnings_hook): Define.
11167 (command_loop_1): Run `delayed-warnings-hook'
11168 if Vdelayed_warnings_list is non-nil.
11169 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11170 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11171
d178f871
EZ
111722011-04-28 Eli Zaretskii <eliz@gnu.org>
11173
11174 * doprnt.c (doprnt): Don't return value smaller than the buffer
11175 size if the message was truncated. (Bug#8545).
11176
b124fd93
JB
111772011-04-28 Juanma Barranquero <lekktu@gmail.com>
11178
11179 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11180 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11181
e810457d
PE
111822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11183
11184 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11185
ea51cceb
JB
111862011-04-27 Juanma Barranquero <lekktu@gmail.com>
11187
11188 * makefile.w32-in: Update dependencies.
11189
94dcfacf
EZ
111902011-04-27 Eli Zaretskii <eliz@gnu.org>
11191
11192 Improve `doprnt' and its usage. (Bug#8545)
11193 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11194 `format_end'. Remove support for %l as a conversion specifier.
11195 Don't use xrealloc. Improve diagnostics when the %l size modifier
11196 is used. Update the commentary.
11197
11198 * eval.c (verror): Simplify calculation of size_t.
11199
11200 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11201 messages.
11202
f61f41d7
PE
112032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11204
11205 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11206 change.
11207
96fb4434
PE
112082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11209
11210 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11211 This makes this file independent of the recent pseudovector change.
11212
671875da 112132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11214
69e9b5a3
PE
11215 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11216
b5f869a7 11217 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11218 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11219 Remove unused local.
c8926152 11220 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11221
841a1577 11222 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11223 GCC 4.6.0 optimizes based on type-based alias analysis.
11224 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11225 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11226 != &v->size, and therefore "v->size = 1; b->size = 2; return
11227 v->size;" must therefore return 1. This assumption is incorrect
11228 for Emacs, since it type-puns struct Lisp_Vector * with many other
11229 types. To fix this problem, this patch adds a new type struct
f904488f 11230 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11231 and pseudovectors, and helps optimizing compilers not get fooled
11232 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11233 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11234 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11235 the size member.
eab3844f
PE
11236 (XSETPVECTYPE): Rewrite in terms of new macro.
11237 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11238 This is a bit clearer, and further avoids the possibility of
11239 undesirable aliasing.
11240 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11241 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11242 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11243 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11244 (ASIZE): Now uses header.size rather than size.
11245 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11246 to avoid the hassle of writing XVECTOR (foo)->header.size.
11247 (struct vectorlike_header): New type.
eab3844f
PE
11248 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11249 object, to help avoid aliasing.
11250 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11251 (SUBRP): Likewise, since Lisp_Subr is a special case.
11252 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11253 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11254 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11255 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11256 changed to be "header.size" and "header.next".
11257 * buffer.h (struct buffer): Likewise.
11258 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11259 * frame.h (struct frame): Likewise.
11260 * process.h (struct Lisp_Process): Likewise.
11261 * termhooks.h (struct terminal): Likewise.
11262 * window.c (struct save_window_data, struct saved_window): Likewise.
11263 * window.h (struct window): Likewise.
11264 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11265 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11266 * buffer.c (init_buffer_once): Likewise.
11267 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11268 special case.
11269 * process.c (Fformat_network_address): Use local var for size,
11270 for brevity.
11271
0df1eac5
PE
11272 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11273
847ab9d1 11274 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11275 * data.c (atof): Remove decl; no longer used or needed.
11276 (digit_to_number): Move to lread.c.
11277 (Fstring_to_number): Use new string_to_number function, to be
11278 consistent with how the Lisp reader treats infinities and NaNs.
11279 Do not assume that floating-point numbers represent EMACS_INT
11280 without losing information; this is not true on most 64-bit hosts.
11281 Avoid double-rounding errors, by insisting on integers when
11282 parsing non-base-10 numbers, as the documentation specifies.
11283 * lisp.h (string_to_number): New decl, replacing ...
11284 (isfloat_string): Remove.
bc0a5c13 11285 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11286 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11287 appears to have been a coding error. Similarly, do not accept
11288 strings like +-1e0 as floating point numbers. Do not report
11289 overflow for integer overflows unless the base is not 10 which
11290 means we have no simple and reliable way to continue.
11291 Break out the floating-point parsing into a new
11292 function string_to_number, so that Fstring_to_number parses
11293 floating point numbers consistently with the Lisp reader.
04f2d78b 11294 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11295 (E_CHAR, EXP_INT): Remove, replacing with ...
11296 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11297 (string_to_number): New function, replacing isfloat_string.
11298 This function checks for valid syntax and produces the resulting
11299 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11300 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11301 so that overflow for non-base-10 numbers is reported only when
11302 there's no portable and simple way to convert to floating point.
452f4150 11303
67769ffc
PE
11304 * textprop.c (set_text_properties_1): Rewrite for clarity,
11305 and to avoid GCC warning about integer overflow.
11306
c20db43f
PE
11307 * intervals.h (struct interval): Use EMACS_INT for members
11308 where EMACS_UINT might cause problems. See
11309 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11310 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11311 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11312 All uses changed.
37aa2f85
PE
11313 (offset_intervals): Tell GCC not to worry about length overflow
11314 when negating a negative length.
c20db43f 11315
2538aa2f
PE
11316 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11317 (overrun_check_free): Likewise.
11318
f2d3008d
PE
11319 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11320 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11321 word size.
11322
ec8df744
PE
11323 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11324 (gnutls_make_error): Rename local to avoid shadowing.
11325 (gnutls_emacs_global_deinit): ifdef out; not used.
11326 (Fgnutls_boot): Use const for pointer to readonly storage.
11327 Comment out unused local. Fix pointer signedness problems.
11328
640ee02d
PE
11329 * lread.c (openp): Don't stuff size_t into an 'int'.
11330 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11331 about possible signed overflow.
11332
6048fb2a
PE
11333 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11334 (GDK_KEY_g): Don't define if already defined.
11335 (xg_prepare_tooltip): Avoid pointer signedness problem.
11336 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11337
fa3c87e1
PE
11338 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11339 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11340
2172544b
PE
11341 * xfns.c (Fx_window_property): Simplify a bit,
11342 to make a bit faster and to avoid GCC 4.6.0 warning.
11343 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11344
9b821a21
PE
11345 * fns.c (internal_equal): Don't assume size_t fits in int.
11346
3c616cfa
PE
11347 * alloc.c (compact_small_strings): Tighten assertion a little.
11348
c2982e87
PE
11349 Replace pEd with more-general pI, and fix some printf arg casts.
11350 * lisp.h (pI): New macro, generalizing old pEd macro to other
11351 conversion specifiers. For example, use "...%"pI"d..." rather
11352 than "...%"pEd"...".
11353 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11354 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11355 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11356 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11357 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11358 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11359 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11360 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11361 64-bit hosts.
11362 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11363 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11364 * print.c (safe_debug_print, print_object): Likewise.
11365 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11366 to int.
6f04d126
PE
11367 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11368 avoiding the 0 flag, which is not portable.
c2982e87
PE
11369 * process.c (Fmake_network_process): Use pI to avoid cast.
11370 * region-cache.c (pp_cache): Likewise.
11371 * xdisp.c (decode_mode_spec): Likewise.
11372 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11373 behavior on 64-bit hosts with printf arg.
6f04d126 11374 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11375 (x_stop_queuing_selection_requests): Likewise.
11376 (x_get_window_property): Don't truncate byte count to an 'int'
11377 when tracing.
0b432f21 11378
5e073ec7
PE
11379 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11380 here, since it parses constructs like leading '-' and spaces,
11381 which are not wanted; and it overflows with large numbers.
11382 Instead, simply match F[0-9]+, which is what is wanted anyway.
11383
36372bf9
PE
11384 * alloc.c: Remove unportable assumptions about struct layout.
11385 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11386 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11387 (allocate_vectorlike, make_pure_vector): Use the new macros,
11388 plus offsetof, to remove unportable assumptions about struct layout.
11389 These assumptions hold on all porting targets that I know of, but
11390 they are not guaranteed, they're easy to remove, and removing them
11391 makes further changes easier.
11392
0b432f21
PE
11393 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11394 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11395 (string_overrun_cookie): Now const. Use initializers that
11396 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11397 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11398 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11399 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11400 multiple of sizeof (EMACS_INT); it need not be, if
11401 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11402 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11403
895009e1
JB
114042011-04-26 Juanma Barranquero <lekktu@gmail.com>
11405
11406 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11407
6a7a1b0b
TZ
114082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11409
11410 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11411 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11412 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11413
841a1577 114142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11415
11416 * lisp.h (Qdebug): List symbol.
895009e1 11417 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11418 * keyboard.c (debug-on-event): New variable.
11419 (handle_user_signal): Break into debugger when debug-on-event
11420 matches the current signal symbol.
11421
f2d3ba6f
DN
114222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11423
11424 * alloc.c (check_sblock, check_string_bytes)
11425 (check_string_free_list): Convert to standard C.
11426
42ce4c63
TZ
114272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11428
11429 * w32.c (emacs_gnutls_push): Fix typo.
11430
825cd63c
EZ
114312011-04-25 Eli Zaretskii <eliz@gnu.org>
11432
fb11d64d
EZ
11433 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11434 "cast to pointer from integer of different size".
11435
825cd63c
EZ
11436 Improve doprnt and its use in verror. (Bug#8545)
11437 * doprnt.c (doprnt): Document the set of format control sequences
11438 supported by the function. Use SAFE_ALLOCA instead of always
11439 using `alloca'.
11440
11441 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11442 is one byte too soon. Don't use xrealloc; instead xfree and
11443 xmalloc anew.
11444
e061a11b
TZ
114452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11446
11447 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11448 callbacks stage.
11449
11450 * gnutls.c: Renamed global_initialized to
11451 gnutls_global_initialized. Added internals for the
11452 :verify-hostname-error, :verify-error, and :verify-flags
11453 parameters of `gnutls-boot' and documented those parameters in the
11454 docstring. Start callback support.
9173deec
JB
11455 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11456 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11457 on error. Return error code.
e061a11b
TZ
11458 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11459 (emacs_gnutls_read): Likewise.
11460 (Fgnutls_boot): Return handshake error code.
11461 (emacs_gnutls_handle_error): New function.
11462 (wsaerror_to_errno): Likewise.
11463
11464 * w32.h (emacs_gnutls_pull): Add prototype.
11465 (emacs_gnutls_push): Likewise.
11466
11467 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11468 (emacs_gnutls_push): Likewise.
11469
114702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11471
11472 * process.c (wait_reading_process_output): Check if GnuTLS
11473 buffered some data internally if no FDs are set for TLS
11474 connections.
11475
11476 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11477 (LIBS): Link to USER_LIBS.
11478 ($(BLD)/gnutls.$(0)): New target.
11479
fa6996bc
EZ
114802011-04-24 Eli Zaretskii <eliz@gnu.org>
11481
eb35682e
EZ
11482 * xdisp.c (handle_single_display_spec): Rename the
11483 display_replaced_before_p argument into display_replaced_p, to
11484 make it consistent with the commentary. Fix typos in the
11485 commentary.
11486
e2ad650c
EZ
11487 * textprop.c (syms_of_textprop): Remove dead code.
11488 (copy_text_properties): Delete obsolete commentary about an
11489 interface that was deleted long ago. Fix typos in the description
11490 of arguments.
11491
1b2de274
EZ
11492 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11493 to changes in oldXMenu/XMenu.h from 2011-04-16.
11494 <menu_help_message, prev_menu_help_message>: Constify.
11495 (IT_menu_make_room): menu->help_text is now `const char **';
11496 adjust.
11497
11498 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11499 to changes in oldXMenu/XMenu.h from 2011-04-16.
11500 (struct XMenu): Declare `help_text' `const char **'.
11501
11502 * xfaces.c <Qunspecified>: Make extern again.
11503
11504 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11505 required by POSIX.
1b2de274 11506
762b15be
EZ
11507 * doc.c (get_doc_string): Improve the format passed to `error'.
11508
11509 * doprnt.c (doprnt): Improve commentary.
11510
11511 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11512
11513 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11514 them with etags.
11515
f1052e5d
EZ
11516 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11517 changes in globals.h immediately force recompilation.
762b15be
EZ
11518 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11519 $(CURDIR)/s/ms-w32.h.
11520 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11521
fa6996bc
EZ
11522 * character.c (Fchar_direction): Function deleted.
11523 (syms_of_character): Don't defsubr it.
11524 <char-direction-table>: Deleted.
11525
e6c3da20
EZ
115262011-04-23 Eli Zaretskii <eliz@gnu.org>
11527
11528 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11529 * doprnt.c: Include limits.h.
11530 (SIZE_MAX): New macro.
04f2d78b
CB
11531 (doprnt): Return a size_t value. 2nd arg is now size_t.
11532 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11533 Improve overflow protection. Support `l' modifier for integer
11534 conversions. Support %l conversion. Don't assume an EMACS_INT
11535 argument for integer conversions and for %c.
11536
11537 * lisp.h (doprnt): Restore prototype.
11538
11539 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11540 $(SRC)/character.h.
11541
11542 * Makefile.in (base_obj): Add back doprnt.o.
11543
11544 * deps.mk (doprnt.o): Add back prerequisites.
11545 (callint.o): Depend on character.h.
11546
11547 * eval.c (internal_lisp_condition_case): Include the handler
11548 representation in the error message.
11549 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11550 when breaking from the loop.
11551
11552 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11553
11554 * callint.c (Fcall_interactively): When displaying error message
11555 about invalid control letter, pass the character's codepoint, not
11556 a pointer to its multibyte form. Improve display of the character
11557 in octal and display also its hex code.
11558
11559 * character.c (char_string): Use %x to display the (unsigned)
11560 codepoint of an invalid character, to avoid displaying a bogus
11561 negative value.
11562
11563 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11564 `error', not SYMBOL_NAME itself.
11565
11566 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11567 character arguments to `error'.
11568
11569 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11570 to `error' in error message about FINAL_CHAR argument. Make sure
11571 FINAL_CHAR is a character, and use %c when it is passed as
11572 argument to `error'.
11573
4ffd0d6b 115742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11575
11576 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11577
11578 * w32.c: Include <time.h>.
11579 (sys_localtime): New function.
11580
4ffd0d6b 115812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11582
11583 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11584
4ffd0d6b 11585 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11586
4ffd0d6b 115872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11588
4ffd0d6b
GM
11589 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11590 zombies (Bug#8467).
aac0c6e3 11591
04c56954
EZ
115922011-04-19 Eli Zaretskii <eliz@gnu.org>
11593
11594 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11595 gl_state.e_property when gl_state.object is Qt.
11596
11597 * insdel.c (make_gap_larger): Remove limitation of buffer size
11598 to <= INT_MAX.
11599
16a43933
CY
116002011-04-18 Chong Yidong <cyd@stupidchicken.com>
11601
11602 * xdisp.c (lookup_glyphless_char_display)
11603 (produce_glyphless_glyph): Handle cons cell entry in
11604 glyphless-char-display.
11605 (Vglyphless_char_display): Document it.
11606
11607 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11608 glyphless-char-display.
11609
4581706e
CY
116102011-04-17 Chong Yidong <cyd@stupidchicken.com>
11611
11612 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11613
11614 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11615
11616 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11617 definition for no-X builds.
11618
4887c6e2 116192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11620
fd35b6f9
PE
11621 Static checks with GCC 4.6.0 and non-default toolkits.
11622
5c1ccb01
PE
11623 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11624
006c5daa
PE
11625 * process.c (keyboard_bit_set): Define only if SIGIO.
11626 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11627 (send_process): Repair possible setjmp clobbering.
11628
efc736d3
PE
11629 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11630
4e2fe2e6
PE
11631 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11632
f97334a2
PE
11633 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11634
4e75f29d
PE
11635 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11636 Define only if needed.
11637
90efadd1
PE
11638 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11639 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11640 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11641
3c647824
PE
11642 * dispextern.h (struct redisplay_interface): Rename param
11643 to avoid shadowing.
e264f262 11644 * termhooks.h (struct terminal): Likewise.
761383f4 11645 * xterm.c (xembed_send_message): Likewise.
3c647824 11646
b58c5c4a
PE
11647 * insdel.c (make_gap_smaller): Define only if
11648 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11649
cad59032
PE
11650 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11651 it.
11652
c339dc2e
PE
11653 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11654 so that we aren't warned about unused symbols.
11655
91a3e27b
PE
11656 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11657
399c71d3 11658 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11659
8ffc96f5
PE
11660 * xfns.c (x_real_positions): Mark locals as initialized.
11661
eef9bc79
PE
11662 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11663
098db9dd
PE
11664 * xterm.c: Fix problems found by static analysis with other toolkits.
11665 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11666 (x_dispatch_event): Declare static if USE_GTK, and
11667 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11668 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11669 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11670 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11671 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11672
eb18f6cc
PE
11673 * xmenu.c (menu_help_callback): Pointer type fixes.
11674 Use const pointers when pointing at readonly data. Avoid pointer
11675 signedness clashes.
11676 (FALSE): Remove unused macro.
11677 (update_frame_menubar): Remove unused decl.
11678
1fe72bf8
PE
11679 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11680
60d9e1db
PE
11681 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11682 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11683 (single_menu_item): Rename local to avoid shadowing.
11684
39261c26
PE
11685 * keyboard.c (make_lispy_event): Remove unused local var.
11686
018c5e19
PE
11687 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11688 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11689
63d2b86e
PE
11690 * bitmaps: Change bitmaps from unsigned char back to the X11
11691 compatible char. Avoid the old compiler warnings about
11692 out-of-range initializers by using, for example, '\xab' rather
11693 than 0xab.
11694
aefd87e1
PE
11695 * xgselect.c (xgselect_initialize): Check vs interface
11696 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11697
bf501fb9
PE
11698 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11699
e9829fdf
PE
11700 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11701 to read-only memory.
11702
1086c095
PE
11703 * fns.c (vector): Remove; this old hack is no longer needed.
11704
2baccd04 11705 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11706 Remove unused var.
dde42981 11707 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11708
72391843 11709 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11710
436c16df 11711 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11712 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11713 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11714
92bb796d 11715 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11716 (x_term_init): Remove local to avoid shadowing.
92bb796d 11717
764430a3 11718 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11719
11720 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11721 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11722
d1dfb56c
EZ
117232011-04-16 Eli Zaretskii <eliz@gnu.org>
11724
c4354cb4
EZ
11725 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11726
d1dfb56c
EZ
11727 Fix regex.c, syntax.c and friends for buffers > 2GB.
11728 * syntax.h (struct gl_state_s): Declare character position members
11729 EMACS_INT.
11730
11731 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11732
04f2d78b
CB
11733 * textprop.c (verify_interval_modification, interval_of):
11734 Declare arguments EMACS_INT.
d1dfb56c
EZ
11735
11736 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11737 EMACS_INT.
11738
11739 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11740
11741 * indent.c (Fvertical_motion): Local variable it_start is now
11742 EMACS_INT.
11743
11744 * regex.c (re_match, re_match_2, re_match_2_internal)
11745 (bcmp_translate, regcomp, regexec, print_double_string)
11746 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11747 (re_compile_pattern, re_exec): Declare arguments and local
11748 variables `size_t' and `ssize_t' and return values `regoff_t', as
11749 appropriate.
11750 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11751 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11752 <compile_stack_type>: `size' and `avail' are now `size_t'.
11753
11754 * regex.h <regoff_t>: Use ssize_t, not int.
11755 (re_search, re_search_2, re_match, re_match_2): Arguments that
11756 specify buffer/string position and length are now ssize_t and
11757 size_t. Return type is regoff_t.
11758
613052cd
BK
117592011-04-16 Ben Key <bkey76@gmail.com>
11760
11761 * nsfont.m: Fixed bugs in ns_get_family and
11762 ns_descriptor_to_entity that were caused by using free to
11763 deallocate memory blocks that were allocated by xmalloc (via
11764 xstrdup). This caused Emacs to crash when compiled with
11765 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11766 --enable-checking=xmallocoverrun). xfree is now used to
11767 deallocate these memory blocks.
11768
4170f62f 117692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11770
71b41406
PE
11771 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11772
9587a89d
PE
11773 emacs_write: Accept and return EMACS_INT for sizes.
11774 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11775 et seq.
11776 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11777 Accept and return EMACS_INT.
11778 (emacs_gnutls_write): Return the number of bytes written on
11779 partial writes.
11780 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11781 (emacs_read, emacs_write): Remove check for negative size, as the
11782 Emacs source code has been audited now.
9587a89d
PE
11783 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11784 (emacs_read, emacs_write): Use it.
273a5f82
PE
11785 * process.c (send_process): Adjust to the new signatures of
11786 emacs_write and emacs_gnutls_write. Do not attempt to store
11787 a byte offset into an 'int'; it might overflow.
9587a89d 11788 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11789
3e047f51
PE
11790 * sound.c: Don't assume sizes fit in 'int'.
11791 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11792 Return EMACS_INT, not int.
3e047f51 11793 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11794 Accept EMACS_INT, not int.
11795 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11796 record read return values.
11797
cc39a9db
BK
117982011-04-15 Ben Key <bkey76@gmail.com>
11799
c9d0ec6d
JB
11800 * keyboard.c (Qundefined): Don't declare static since it is used
11801 in nsfns.m.
11802 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11803 static since they are used in nsfont.m.
cc39a9db 11804
6c60eb9f
SM
118052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11806
11807 * process.c (Qprocessp): Don't declare static.
11808 * lisp.h (Qprocessp): Declare again.
11809
7990b61a
JB
118102011-04-15 Juanma Barranquero <lekktu@gmail.com>
11811
11812 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11813
5d4cb038
PE
118142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11815
8bd7b830 11816 Improve C-level modularity by making more things 'static'.
cd64ea1d 11817
e3b27b31
PE
11818 Don't publish debugger-only interfaces to other modules.
11819 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11820 (verify_bytepos, count_markers): Move decls to the only modules
11821 that need them.
11822 * region-cache.h (pp_cache): Likewise.
11823 * window.h (check_all_windows): Likewise.
11824 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11825
5d4cb038
PE
11826 * sysdep.c (croak): Now static, if
11827 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11828 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11829
11830 * alloc.c (refill_memory_reserve): Now static if
11831 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11832 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11833
e87b6180
PE
11834 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11835 Define only if USE_LUCID.
11836
ac64929e
PE
11837 * xrdb.c (x_customization_string, x_rm_string): Now static.
11838
6f37259d
PE
11839 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11840 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11841
1683e3ab
PE
11842 * xdisp.c (draw_row_with_mouse_face): Now static.
11843 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11844
de9c2632
PE
11845 * window.h (check_all_windows): Mark externally visible.
11846
2b96acb7
PE
11847 * window.c (window_deletion_count): Now static.
11848
11849 * undo.c: Make symbols static if they're not exported.
11850 (last_undo_buffer, last_boundary_position, pending_boundary):
11851 Now static.
11852
50436f33
PE
11853 * textprop.c (interval_insert_behind_hooks): Now static.
11854 (interval_insert_in_front_hooks): Likewise.
11855
64520e5c
PE
11856 * term.c: Make symbols static if they're not exported.
11857 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11858 (max_frame_lines, tty_set_terminal_modes):
11859 (tty_reset_terminal_modes, tty_turn_off_highlight):
11860 (get_tty_terminal): Now static.
11861 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11862 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11863 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11864 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11865 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11866
1fa53021
PE
11867 * sysdep.c: Make symbols static if they're not exported.
11868 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11869 Now static.
11870 (sigprocmask_set, full_mask): Remove; unused.
11871 (wait_debugging): Mark as visible.
11872 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11873 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11874
d4b43b22
PE
11875 * syntax.c (syntax_temp): Define only if !__GNUC__.
11876
b7c513d0
PE
11877 * sound.c (current_sound_device, current_sound): Now static.
11878
989b29ad
PE
11879 * search.c (searchbufs, searchbuf_head): Now static.
11880
13a55a78
PE
11881 * scroll.c (scroll_cost): Remove; unused.
11882 * dispextern.h (scroll_cost): Remove decl.
11883
de68a1fc
PE
11884 * region-cache.h (pp_cache): Mark as externally visible.
11885
40ccffa6
PE
11886 * process.c: Make symbols static if they're not exported.
11887 (process_tick, update_tick, create_process, chan_process):
11888 (Vprocess_alist, proc_buffered_char, datagram_access):
11889 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11890 (deactivate_process): Mark defn as static, as well as decl.
11891 * lisp.h (create_process): Remove decl.
11892 * process.h (chan_process, Vprocess_alist): Remove decls.
11893
ad64fc97
PE
11894 * print.c: Make symbols static if they're not exported.
11895 (print_depth, new_backquote_output, being_printed, print_buffer):
11896 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11897 (print_interval, print_number_index, initial_stderr_stream):
11898 Now static.
11899 * lisp.h (Fprinc): Remove decl.
11900 (debug_output_compilation_hack): Mark as externally visible.
11901
adddb265
PE
11902 * sysdep.c (croak): Move decl from here to syssignal.h.
11903 * syssignal.h (croak): Put it here, so the API can be checked when
11904 'croak' is called from dissociate_if_controlling_tty.
11905
1717ede2
PE
11906 * minibuf.c: Make symbols static if they're not exported.
11907 (minibuf_save_list, choose_minibuf_frame): Now static.
11908 * lisp.h (choose_minibuf_frame): Remove decl.
11909
fa5fb2bc
PE
11910 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11911
1e3890d1
PE
11912 * lread.c: Make symbols static if they're not exported.
11913 (read_objects, initial_obarray, oblookup_last_bucket_number):
11914 Now static.
11915 (make_symbol): Remove; unused.
11916 * lisp.h (initial_obarray, make_symbol): Remove decls.
11917
8a1414fa
PE
11918 * keyboard.c: Make symbols static if they're not exported.
11919 (single_kboard, recent_keys_index, total_keys, recent_keys):
11920 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11921 (this_single_command_key_start, echoing, last_auto_save):
11922 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11923 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11924 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11925 (Vlispy_mouse_stem, double_click_count):
11926 Now static.
11927 (force_auto_save_soon): Define only if SIGDANGER.
11928 (ignore_mouse_drag_p): Now static if
11929 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11930 (print_help): Remove; unused.
11931 (stop_character, last_timer_event): Mark as externally visible.
11932 * keyboard.h (ignore_mouse_drag_p): Declare only if
11933 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11934 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11935 * lisp.h (echoing): Remove decl.
11936 (force_auto_save_soon): Declare only if SIGDANGER.
11937 * xdisp.c (redisplay_window): Simplify code, to make it more
11938 obvious that ignore_mouse_drag_p is not accessed if !defined
11939 USE_GTK && !defined HAVE_NS.
11940
93ea6e8f
PE
11941 * intervals.c: Make symbols static if they're not exported.
11942 (merge_properties_sticky, merge_interval_right, delete_interval):
11943 Now static.
11944 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11945
77382fcc
PE
11946 * insdel.c: Make symbols static if they're not exported.
11947 However, leave prepare_to_modify_buffer alone. It's never
11948 called from outside this function, but that appears to be a bug.
11949 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11950 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11951 (adjust_after_replace_noundo): Remove; unused.
11952 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11953 (signal_before_change): Remove decls.
77382fcc 11954
9306c32e
PE
11955 * indent.c (val_compute_motion, val_vmotion): Now static.
11956
cd44d2eb
PE
11957 * image.c: Make symbols static if they're not exported.
11958 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11959 if USE_GTK.
11960 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11961 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11962
ad9a7a06
PE
11963 * fringe.c (standard_bitmaps): Now static.
11964 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11965
81626931
PE
11966 * frame.c: Make symbols static if they're not exported.
11967 (x_report_frame_params, make_terminal_frame): Now static.
11968 (get_frame_param): Now static, unless HAVE_NS.
11969 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11970 (x_get_resource_string): Remove; not used.
11971 * frame.h (make_terminal_frame, x_report_frame_params):
11972 (x_get_resource_string); Remove decls.
11973 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11974 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11975
239f9db9
PE
11976 * font.c, fontset.c: Make symbols static if they're not exported.
11977 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11978 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11979 * font.c (font_close_object): Now static.
11980 * font.h (font_close_object): Remove.
11981 * fontset.c (FONTSET_OBJLIST): Remove.
11982 (free_realized_fontset) #if-0 the body, which does nothing.
11983 (face_suitable_for_char_p): #if-0, as it's never called.
11984 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11985 * xfaces.c (face_at_string_position):
11986 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11987 since 0 is always ASCII.
11988
dfcf3579
PE
11989 * fns.c (weak_hash_tables): Now static.
11990
5045092b
PE
11991 * fileio.c: Make symbols static if they're not exported.
11992 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11993 (Vwrite_region_annotation_buffers): Now static.
11994
57a96f5c
PE
11995 * eval.c: Make symbols static if they're not exported.
11996 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11997 * lisp.h (backtrace_list): Remove decl.
11998
35f08c38
PE
11999 * emacs.c: Make symbols static if they're not exported.
12000 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12001 (fatal_error_code, fatal_error_signal_hook, standard_args):
12002 Now static.
12003 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12004 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12005 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12006 * lisp.h (fatal_error_signal_hook): Remove decl.
12007 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12008
f44bd759
PE
12009 * editfns.c: Move a (normally-unused) function to its only use.
12010 * editfns.c, lisp.h (get_operating_system_release): Remove.
12011 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12012 worth the hassle of breaking this out.
12013
b532497d
PE
12014 * xterm.c: Make symbols static if they're not exported.
12015 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12016 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12017 (x_destroy_window, x_delete_display):
12018 Now static.
12019 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12020 (x_mouse_leave): Remove; unused.
12021 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12022 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12023 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12024 Remove decls.
12025 (x_mouse_leave): Declare only if WINDOWSNT.
12026 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12027 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12028 USE_X_TOOLKIT.
12029
1675728f
PE
12030 * ftxfont.c: Make symbols static if they're not exported.
12031 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12032 HAVE_FREETYPE.
12033 * font.h (ftxfont_driver): Likewise.
12034
e4cebfca
PE
12035 * xfns.c: Make symbols static if they're not exported.
12036 (x_last_font_name, x_display_info_for_name):
12037 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12038 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12039 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12040 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12041 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12042 (last_show_tip_args): Now static.
12043 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12044 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12045 (x_screen_planes): Remove; unused.
12046 * dispextern.h (x_screen_planes): Remove decl.
12047
5bf46f05
PE
12048 * dispnew.c: Make symbols static if they're not exported.
12049 * dispextern.h (redraw_garbaged_frames, scrolling):
12050 (increment_row_positions): Remove.
12051 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12052 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12053 Now static.
12054 (redraw_garbaged_frames): Remove; unused.
12055
435f4c28
PE
12056 * xfaces.c: Make symbols static if they're not exported.
12057 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12058 Remove decls.
12059 * xterm.h (defined_color): Remove decls.
12060 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12061 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12062 (menu_face_changed_default, defined_color, free_realized_face):
12063 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12064 (ascii_face_of_lisp_face): Remove; unused.
12065
8524aef3
PE
12066 * xdisp.c: Make symbols static if they're not exported.
12067 * dispextern.h (scratch_glyph_row, window_box_edges):
12068 (glyph_to_pixel_coords, set_cursor_from_row):
12069 (get_next_display_element, set_iterator_to_next):
12070 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12071 (show_mouse_face): Remove decls
12072 * frame.h (message_buf_print): Likewise.
12073 * lisp.h (pop_message, set_message, check_point_in_composition):
12074 Likewise.
12075 * xterm.h (set_vertical_scroll_bar): Likewise.
12076 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12077 (message_buf_print, scratch_glyph_row, displayed_buffer):
12078 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12079 (get_next_display_element, show_mouse_face, window_box_edges):
12080 (frame_to_window_pixel_xy, check_point_in_composition):
12081 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12082 (glyph_to_pixel_coords): Remove; unused.
12083
16390cd2
PE
12084 * dired.c (file_name_completion): Now static.
12085
12086 * dbusbind.c (xd_in_read_queued_messages): Now static.
12087
a25f4dfa
PE
12088 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12089 * data.c (circular_list_error): Remove.
12090
14a9c8df
PE
12091 * commands.h (last_point_position, last_point_position_buffer):
12092 (last_point_position_window): Remove decls.
12093 * keyboard.c: Make these variables static.
12094
04f2d78b
CB
12095 * coding.h (coding, code_convert_region, encode_coding_gap):
12096 Remove decls.
74ab6df5
PE
12097 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12098 (iso_code_class, detect_coding, code_convert_region): Now static.
12099 (encode_coding_gap): Remove; unused.
12100
38dfbee1
PE
12101 * chartab.c (chartab_chars, chartab_bits): Now static.
12102
a2cb4e63
PE
12103 * charset.h (charset_iso_8859_1): Remove decl.
12104 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12105 Now static.
12106
127198fd
PE
12107 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12108 * ccl.c (Vccl_program_table): Now static.
12109 (check_ccl_update): Remove; unused.
12110
d85b608f
PE
12111 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12112 * category.h: ... from here.
12113 * category.c (check_category_table, set_category_set): Now static.
12114
31cd66f3
PE
12115 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12116 * lisp.h: Remove these decls.
12117
c358e587
PE
12118 * buffer.c (buffer_count): Remove unused var.
12119
e78aecca
PE
12120 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12121 so that it's not optimized away.
12122 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12123 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12124 exported only to the debugger.
12125
e192d7d3 12126 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12127 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12128
92470028
PE
12129 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12130 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12131 was inaccessible from Lisp.
12132 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12133 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12134
244ed907
PE
12135 alloc.c: Import and export fewer symbols, and remove unused items.
12136 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12137 is defined.
12138 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12139 it's not optimized away by whole-program optimization.
12140 (message_enable_multibyte, free_misc): Remove.
12141 (catchlist, handlerlist, mark_backtrace):
12142 Declare only if BYTE_MARK_STACK.
12143 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12144 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12145 (message_enable_multibyte): Remove decl.
12146 (free_misc, interval_free_list, float_block, float_block_index):
12147 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12148 (cons_free_list, last_marked_index):
12149 Now static.
12150 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12151 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12152 (mark_backtrace): Define only if BYTE_MARK_STACK.
12153 * xdisp.c (message_enable_multibyte): Now static.
12154
61c2b50e 12155 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12156 This makes it easier for human readers (and static analyzers)
12157 to see whether these variables are used from other modules.
12158 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12159 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12160 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12161 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12162 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12163 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12164 * xmenu.c, xselect.c:
12165 Declare Q* vars static if they are not used in other modules.
12166 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12167 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12168 Remove decls of unexported vars.
12169 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12170
95c82688
PE
12171 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12172
16a97296
PE
12173 Make Emacs functions such as Fatom 'static' by default.
12174 This makes it easier for human readers (and static analyzers)
12175 to see whether these functions can be called from other modules.
12176 DEFUN now defines a static function. To make the function external
12177 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12178 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12179 (Finit_image_library):
16a97296
PE
12180 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12181 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12182 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12183 Remove decls, since these functions are now static.
12184 (Funintern, Fget_internal_run_time): New decls, since these functions
12185 were already external.
95c82688 12186
16a97296
PE
12187 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12188 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12189 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12190 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12191 * keyboard.c, keymap.c, lread.c:
12192 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12193 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12194 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12195 Mark functions with DEFUE instead of DEFUN,
12196 if they are used in other modules.
12197 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12198 decls for now-static functions.
12199 * buffer.h (Fdelete_overlay): Remove decl.
12200 * callproc.c (Fgetenv_internal): Mark as internal.
12201 * composite.c (Fremove_list_of_text_properties): Remove decl.
12202 (Fcomposition_get_gstring): New forward static decl.
12203 * composite.h (Fcomposite_get_gstring): Remove decl.
12204 * dired.c (Ffile_attributes): New forward static decl.
12205 * doc.c (Fdocumntation_property): New forward static decl.
12206 * eval.c (Ffetch_bytecode): New forward static decl.
12207 (Funintern): Remove extern decl; now in .h file where it belongs.
12208 * fileio.c (Fmake_symbolic_link): New forward static decl.
12209 * image.c (Finit_image_library): New forward static decl.
12210 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12211 * intervals.h (Fprevious_property_change):
12212 (Fremove_list_of_text_properties): Remove decls.
12213 * keyboard.c (Fthis_command_keys): Remove decl.
12214 (Fcommand_execute): New forward static decl.
12215 * keymap.c (Flookup_key): New forward static decl.
12216 (Fcopy_keymap): Now static.
12217 * keymap.h (Flookup_key): Remove decl.
12218 * process.c (Fget_process): New forward static decl.
12219 (Fprocess_datagram_address): Mark as internal.
12220 * syntax.c (Fsyntax_table_p): New forward static decl.
12221 (skip_chars): Remove duplicate decl.
12222 * textprop.c (Fprevious_property_change): New forward static decl.
12223 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12224 Now internal.
12225 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12226 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12227
785bbd42
PE
12228 * editfns.c (Fformat): Remove unreachable code.
12229
8b913b57
AS
122302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12231
12232 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12233 change. (Bug#8496)
12234
a6744a35
EZ
122352011-04-13 Eli Zaretskii <eliz@gnu.org>
12236
12237 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12238 when at ZV. (Bug#8487)
12239
e7974947
AS
122402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12241
baad03f0
AS
12242 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12243 (Bug#8437)
12244 * keyboard.c (parse_tool_bar_item): Likewise.
12245 * sound.c (sound_cleanup, alsa_close): Likewise.
12246 * termcap.c (tgetent): Likewise.
12247 * xfns.c (x_default_font_parameter): Likewise.
12248 * xsettings.c (read_and_apply_settings): Likewise.
12249
e7974947
AS
12250 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12251 (overrun_check_free): Protoize.
12252
28272684
PE
122532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12254
12255 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12256 since callers should never pass a negative size.
12257 Change the signature to match that of plain 'read' and 'write'; see
12258 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12259 * lisp.h: Update prototypes of emacs_write and emacs_read.
12260
11997c76
EZ
122612011-04-11 Eli Zaretskii <eliz@gnu.org>
12262
12263 * xdisp.c (redisplay_window): Don't try to determine the character
12264 position of the scroll margin if the window start point w->startp
e896f03c 12265 is outside the buffer's accessible region. (Bug#8468)
11997c76 12266
8a2cbd72
EZ
122672011-04-10 Eli Zaretskii <eliz@gnu.org>
12268
12269 Fix write-region and its subroutines for buffers > 2GB.
12270 * fileio.c (a_write, e_write): Modify declaration of arguments and
12271 local variables to support buffers larger than 2GB.
12272 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12273
12274 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12275 argument, local variables, and return value.
12276
12277 * lisp.h: Update prototypes of emacs_write and emacs_read.
12278
12279 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12280
4073e537 122812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12282
1ebfdcb6
PE
12283 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12284
b2ded58d
PE
12285 Fix more problems found by GCC 4.6.0's static checks.
12286
7d66342c
PE
12287 * xdisp.c (vmessage): Use a better test for character truncation.
12288
bbf47d44
PE
12289 * charset.c (load_charset_map): <, not <=, for optimization,
12290 and to avoid potential problems with integer overflow.
9248994d 12291 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12292 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12293 * editfns.c (Fformat): Likewise.
1e69125e 12294 * syntax.c (skip_chars): Likewise.
3befa583 12295
e3019616
PE
12296 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12297 This also lets GCC 4.6.0 generate slightly better loop code.
12298
becfa255
PE
12299 * callint.c (Fcall_interactively): <, not <=, for optimization.
12300 (Fcall_interactively): Count the number of arguments produced,
12301 not the number of arguments given. This is simpler and lets GCC
12302 4.6.0 generate slightly better code.
12303
dae0cd48
PE
12304 * ftfont.c: Distingish more carefully between FcChar8 and char.
12305 The previous code passed unsigned char * to a functions like
12306 strlen and xstrcasecmp that expect char *, which does not
12307 conform to the C standard.
12308 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12309 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12310 char * when the C standard requires it.
12311
76032d70
PE
12312 * keyboard.c (read_char): Remove unused var.
12313
eb3f1cc8
PE
12314 * eval.c: Port to Windows vsnprintf (Bug#8435).
12315 Include <limits.h>.
12316 (SIZE_MAX): Define if the headers do not.
12317 (verror): Do not give up if vsnprintf returns a negative count.
12318 Instead, grow the buffer. This ports to Windows vsnprintf, which
12319 does not conform to C99. Problem reported by Eli Zaretskii.
12320 Also, simplify the allocation scheme, by avoiding the need for
12321 calling realloc, and removing the ALLOCATED variable.
12322
70476b54
PE
12323 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12324
12020a9e
PE
12325 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12326 But keep the doprint source code for now, as we might revamp it
12327 and use it again (Bug#8435).
ea6c7ae6
PE
12328 * lisp.h (doprnt): Remove.
12329 * Makefile.in (base_obj): Remove doprnt.o.
12330 * deps.mk (doprnt.o): Remove.
12331
5fdb398c
PE
12332 error: Print 32- and 64-bit integers portably (Bug#8435).
12333 Without this change, on typical 64-bit hosts error ("...%d...", N)
12334 was used to print both 32- and 64-bit integers N, which relied on
12335 undefined behavior.
61bdb816 12336 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12337 * lisp.h (error, verror): Mark as printf-like functions.
12338 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12339 Report overflow in size calculations when allocating printf buffer.
12340 Do not truncate output string at its first null byte.
12341 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12342 Truncate the output at a character boundary, since vsnprintf does not
12343 do that.
12344 * charset.c (check_iso_charset_parameter): Convert internal
12345 character to string before calling 'error', since %c now has the
12346 printf meaning.
12347 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12348 overflow when computing char to be passed to 'error'. Do not
12349 pass Lisp_Object to 'error'; pass the integer instead.
12350 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12351 formatted with plain %d.
12352
b189fa66
PE
12353 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12354
bff87ef0
PE
12355 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12356
7e2cac20
PE
12357 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12358
ce4d90b5
PE
12359 * xterm.c (x_catch_errors): Remove duplicate declaration.
12360
266c9547
PE
12361 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12362
79c49ad2
PE
12363 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12364
368f4090
JM
123652011-04-10 Jim Meyering <meyering@redhat.com>
12366
12367 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12368 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12369 return ssize_t not "int", and use size_t as the buffer length.
12370 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12371 * gnutls.h: Update declarations.
12372 * process.c (read_process_output): Use ssize_t, to match.
12373 (send_process): Likewise.
12374
a32d4040
CY
123752011-04-09 Chong Yidong <cyd@stupidchicken.com>
12376
12377 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12378
8546720e 123792011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12380
04f2d78b
CB
12381 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12382 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12383
8546720e
GM
12384 * xterm.c (handle_one_xevent):
12385 * xmenu.c (create_and_show_popup_menu):
12386 * xselect.c (x_decline_selection_request)
12387 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12388
0a2f5c1a 123892011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12390
12391 Fix some uses of `int' instead of EMACS_INT.
12392 * search.c (string_match_1, fast_string_match)
12393 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12394 (scan_buffer, find_next_newline_no_quit)
12395 (find_before_next_newline, search_command, Freplace_match)
12396 (Fmatch_data): Make some `int' variables be EMACS_INT.
12397
12398 * xdisp.c (display_count_lines): 3rd argument and return value now
12399 EMACS_INT. All callers changed.
12400 (pint2hrstr): Last argument is now EMACS_INT.
12401
12402 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12403 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12404 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12405 (decode_coding_utf_16, decode_coding_emacs_mule)
12406 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12407 (decode_coding_ccl, decode_coding_charset)
12408 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12409 (decode_coding_iso_2022, decode_coding_emacs_mule)
12410 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12411 <char_offset, last_offset>: Declare EMACS_INT.
12412 (encode_coding_utf_8, encode_coding_utf_16)
12413 (encode_coding_emacs_mule, encode_invocation_designation)
12414 (encode_designation_at_bol, encode_coding_iso_2022)
12415 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12416 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12417 Declare EMACS_INT.
12418 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12419 (encode_invocation_designation): Last argument P_NCHARS is now
12420 EMACS_INT.
12421 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12422 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12423
12424 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12425 All users changed.
12426
12427 * ccl.c (Fccl_execute_on_string): Declare some variables
12428 EMACS_INT.
12429
8546720e 124302011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12431
12432 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12433
4e19a977
CS
124342011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12435
12436 * process.c (Fformat_network_address): Doc fix.
12437
87302331
R
124382011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12439
ee7683eb 12440 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12441
cbb59342
CY
124422011-04-08 Chong Yidong <cyd@stupidchicken.com>
12443
12444 * keyboard.c (read_char): Call Lisp function help-form-show,
12445 instead of using internal_with_output_to_temp_buffer.
12446 (Qhelp_form_show): New var.
e0d38eeb 12447 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12448
12449 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12450
12451 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12452
e67a13ab
CY
124532011-04-06 Chong Yidong <cyd@stupidchicken.com>
12454
04f2d78b
CB
12455 * process.c (Flist_processes): Remove to Lisp.
12456 (list_processes_1): Delete.
e67a13ab 12457
973f782d
EZ
124582011-04-06 Eli Zaretskii <eliz@gnu.org>
12459
7c106b1e
EZ
12460 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12461
973f782d
EZ
12462 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12463
41cf7d1a 124642011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12465
ca23cc88
PE
12466 Fix more problems found by GCC 4.6.0's static checks.
12467
f390e2d5
PE
12468 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12469
42eea0d0
PE
12470 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12471
b69769da 12472 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12473
f9541e84
PE
12474 * xdisp.c (vmessage): Mark as a printf-like function.
12475
13841b55
PE
12476 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12477
c136c10f
PE
12478 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12479
5e2d4a30
PE
12480 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12481 printf-like functions.
12482 (tiff_load): Add casts to remove these marks before passing them
12483 to system-supplied API.
12484
583f48b9
PE
12485 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12486
b25d760e
PE
12487 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12488 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12489 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12490 directly, rather than having caller test rule sign. This avoids
12491 some unnecessary tests.
12492 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12493 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12494 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12495
bc7b6697 12496 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12497 (xfont_open): Avoid unnecessary tests.
bc7b6697 12498
27ccc379
PE
12499 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12500
dcd5c89a
PE
12501 * composite.h, composite.c (composition_gstring_put_cache):
12502 Use EMACS_INT, not int, for length.
12503
b13a45c6
PE
12504 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12505 breaking out part of COMPOSITION_DECODE_RULE.
12506 (COMPOSITION_DECODE_RULE): Use it.
12507 * composite.c (get_composition_id): Remove unused local vars,
12508 by using the new macro.
12509
1e792e4d
PE
12510 * textprop.c (set_text_properties_1): Change while to do-while,
12511 since the condition is always true at first.
12512
dc6c6455 12513 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12514 (interval_deletion_adjustment): Return unsigned value.
12515 All uses changed.
dc6c6455 12516
aba7731a
PE
12517 * process.c (list_processes_1, create_pty, read_process_output):
12518 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12519 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12520 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12521 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12522 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12523
fdfc4bf3
PE
12524 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12525
fca8fe46 12526 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12527 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12528
06a0259a 12529 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12530 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12531 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12532
e7b9e80f
PE
12533 * print.c (print_error_message): Avoid int overflow.
12534
56201685
PE
12535 * font.c (font_list_entities): Redo for clarity,
12536 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12537
78834453 12538 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12539 (font_score): Avoid potential overflow in diff calculation.
78834453 12540
0bc0b309 12541 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12542 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12543
e610eaca
PE
12544 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12545
b895abce
PE
12546 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12547 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12548 can always succeed if overflow has undefined behavior.
12549
1f1d9321 12550 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12551 (wordify): Omit three unnecessary tests.
1f1d9321 12552
c59478bc
PE
12553 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12554 All callers changed. This avoids the need for an unused var.
12555
79b73827
PE
12556 * casefiddle.c (casify_region): Remove var that is set but not used.
12557
a4db5dfe
PE
12558 * dired.c (file_name_completion): Remove var that is set but not used.
12559
43aae36e
PE
12560 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12561
2a47c44d 12562 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12563 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12564
a37c69bf
PE
12565 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12566 Check for integer overflow on size calculations.
12567
328ab8e7
PE
12568 * buffer.c (Fprevious_overlay_change): Remove var that is set
12569 but not used.
12570
e5a2a5cb
PE
12571 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12572 Remove vars that are set but not used.
8d84a6eb 12573 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12574 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12575
a60e5f68
PE
12576 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12577
f661cb61 12578 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12579 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12580
f0397f5a
PE
12581 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12582 that are set but not used.
12583
8664db06 12584 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12585 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12586
6abdaa4a
PE
12587 * xselect.c (x_get_local_selection, x_handle_property_notify):
12588 Remove vars that are set but not used.
12589
0ce7538d 12590 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12591 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12592
9ae848fc
PE
12593 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12594 Remove var that is set but not used.
0b918413
PE
12595 (scroll_bar_windows_size): Now size_t, not int.
12596 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12597 Check for overflow.
9ae848fc 12598
a5a62657
PE
12599 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12600 (map_tty_color) [!defined MSDOS]: Likewise.
12601
5c5cdd39
PE
12602 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12603
66ebf983
PE
12604 * coding.c: Remove vars that are set but not used.
12605 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12606 All callers changed.
12607 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12608 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12609 (decode_coding_charset): Remove vars that are set but not used.
12610
1be4d761
PE
12611 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12612 that is set but not used.
12613
47553fa8
PE
12614 * print.c (print_object): Remove var that is set but not used.
12615
1f7196bf 12616 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12617 The gnulib version avoids calling malloc in the usual case,
12618 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12619 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12620 * filelock.c (current_lock_owner): Likewise.
12621 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12622 * sysdep.c: Include allocator.h, careadlinkat.h.
12623 (emacs_no_realloc_allocator): New static constant.
12624 (emacs_readlink): New function.
fdb61804
PE
12625 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12626 ../lib/careadlinkat.h.
d1fdcab7 12627
f84c17c7
SM
126282011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12629
12630 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12631 first non-nil return value).
12632
ef3862ad
JD
126332011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12634
12635 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12636 if not defined (Bug#8403).
12637
376a7006
JB
126382011-04-02 Juanma Barranquero <lekktu@gmail.com>
12639
12640 * xdisp.c (display_count_lines): Remove parameter `start',
12641 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12642 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12643 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12644 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12645 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12646 and thereabouts. All callers changed.
12647 (get_per_char_metric): Remove parameter `f', unused since
12648 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12649
6ca3801d
JM
126502011-04-02 Jim Meyering <meyering@redhat.com>
12651
12652 do not dereference NULL upon failed strdup
12653 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12654 (ns_get_family): Likewise.
12655
d8e2b5ba
JB
126562011-04-02 Juanma Barranquero <lekktu@gmail.com>
12657
12658 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12659
8c74fcbd
JD
126602011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12661
12662 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12663 later (Bug#8403).
12664
7200d79c
SM
126652011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12666
03408648 12667 Add lexical binding.
7200d79c 12668
03408648
SM
12669 * window.c (Ftemp_output_buffer_show): New fun.
12670 (Fsave_window_excursion):
12671 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12672
12673 * lread.c (lisp_file_lexically_bound_p): New function.
12674 (Fload): Bind Qlexical_binding.
12675 (readevalloop): Remove `evalfun' arg.
12676 Bind Qinternal_interpreter_environment.
12677 (Feval_buffer): Bind Qlexical_binding.
12678 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12679 Mark as dynamic.
12680 (syms_of_lread): Declare `lexical-binding'.
12681
12682 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12683
12684 * keyboard.c (eval_dyn): New fun.
12685 (menu_item_eval_property): Use it.
ca105506
SM
12686
12687 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12688
03408648
SM
12689 * fns.c (concat, mapcar1): Accept byte-code-functions.
12690
12691 * eval.c (Fsetq): Handle lexical vars.
12692 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12693 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12694 (FletX, Flet): Obey lexical binding.
12695 (Fcommandp): Handle closures.
12696 (Feval): New `lexical' arg.
12697 (eval_sub): New function extracted from Feval. Use it almost
12698 everywhere where Feval was used. Look up vars in lexical env.
12699 Handle closures.
12700 (Ffunctionp): Move from subr.el.
12701 (Ffuncall): Handle closures.
12702 (apply_lambda): Remove `eval_flags'.
12703 (funcall_lambda): Handle closures and new byte-code-functions.
12704 (Fspecial_variable_p): New function.
12705 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12706 but without exporting it to Lisp.
23aba0ea 12707
23aba0ea 12708 * doc.c (Fdocumentation, store_function_docstring):
03408648 12709 * data.c (Finteractive_form): Handle closures.
23aba0ea 12710
03408648
SM
12711 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12712 interactive spec.
ba83908c 12713
04f2d78b
CB
12714 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12715 New byte-codes.
03408648
SM
12716 (exec_byte_code): New function extracted from Fbyte_code to handle new
12717 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12718
03408648 12719 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12720
03408648 12721 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12722
e2abce01
JB
127232011-03-31 Juanma Barranquero <lekktu@gmail.com>
12724
12725 * xdisp.c (redisplay_internal): Fix prototype.
12726
63696a73 127272011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12728
63696a73 12729 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12730 (try_scrolling): Use it when setting scroll_limit.
12731 Limit scrolling to 100 screen lines.
63696a73
EZ
12732 (redisplay_window): Even when falling back on "recentering",
12733 position point in the window according to scroll-conservatively,
12734 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12735
12736 (try_scrolling): When point is above the window, allow searching
12737 as far as scroll_max, or one screenful, to compute vertical
12738 distance from PT to the scroll margin position. This prevents
12739 try_scrolling from unnecessarily failing when
12740 scroll-conservatively is set to a value slightly larger than the
12741 window height. Clean up the case of PT below the margin at bottom
12742 of window: scroll_max can no longer be INT_MAX. When aggressive
12743 scrolling is in use, don't let point enter the opposite scroll
12744 margin as result of the scroll.
12745 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12746 threshold of 100 lines for never-recentering scrolling.
12747
e4cc2dfc
JB
127482011-03-31 Juanma Barranquero <lekktu@gmail.com>
12749
12750 * dispextern.h (move_it_by_lines):
12751 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12752 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12753 (message_log_check_duplicate): Remove parameters `prev_bol' and
12754 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12755 (redisplay_internal): Remove parameter `preserve_echo_area',
12756 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12757
12758 * indent.c (Fvertical_motion):
12759 * window.c (window_scroll_pixel_based, Frecenter):
12760 Don't pass `need_y_p' to `move_it_by_lines'.
12761
1c470562
SM
127622011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12763
44f230aa
SM
12764 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12765 steal a few bits to be more compact.
12766 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12767 Remove unneeded casts.
12768
1c470562
SM
12769 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12770
888adce9
ZK
127712011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12772
12773 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12774 binding" message (bug#7967).
12775
f838ed7b
PE
127762011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12777
77861b95
PE
12778 Fix more problems found by GCC 4.6.0's static checks.
12779
de6dbc14
PE
12780 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12781 Remove unused local var.
12782
f838ed7b
PE
12783 * editfns.c (Fmessage_box): Remove unused local var.
12784
792c7b2b
PE
12785 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12786 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12787 Omit unused local vars.
c499e557 12788 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12789 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12790 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12791 Omit unused local var.
12792
ba0165e1
PE
12793 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12794 Don't assume string length fits in int.
32ad8845 12795 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12796 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12797
3c59b4c9
PE
12798 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12799 instead of alloca (Bug#8344).
12800
a3eed478 12801 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12802 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12803
eb4d412d
PE
12804 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12805
1658b401
PE
12806 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12807 concerns.
12808
12809 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12810
12811 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12812
9a2c6e05
PE
12813 * keyboard.c (syms_of_keyboard): Use the same style as later
12814 in this function when indexing through an array. This also
12815 works around GCC bug 48267.
12816
03d0a109
PE
12817 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12818
44f730c8
PE
12819 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12820
fe75f926
PE
12821 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12822 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12823
ffa8c828
PE
12824 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12825 This avoids undefined behavior on integer overflow, and is a bit
12826 more convenient anyway since it is compared to a size_t variable.
12827
c5101a77
PE
12828 Variadic C functions now count arguments with size_t, not int.
12829 This avoids an unnecessary limitation on 64-bit machines, which
12830 caused (substring ...) to crash on large vectors (Bug#8344).
12831 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12832 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12833 All variadic functions and their callers changed accordingly.
c5101a77
PE
12834 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12835 * data.c (arith_driver, float_arith_driver): Likewise.
12836 * editfns.c (general_insert_function): Likewise.
12837 * eval.c (struct backtrace.nargs, interactive_p)
12838 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12839 (funcall_lambda, mark_backtrace): Likewise.
12840 * fns.c (concat): Likewise.
12841 * frame.c (x_set_frame_parameters): Likewise.
12842 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12843 0 if not found, not -1. All callers changed.
12844
dd3f25f7
PE
12845 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12846 (stack_copy_size): Now size_t, not int.
12847 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12848
461c2ab9
JB
128492011-03-28 Juanma Barranquero <lekktu@gmail.com>
12850
12851 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12852 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12853 All callers changed.
12854
12855 * lisp.h (multibyte_char_to_unibyte):
12856 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12857 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12858 * character.h (CHAR_TO_BYTE8):
12859 * cmds.c (internal_self_insert):
12860 * editfns.c (general_insert_function):
12861 * keymap.c (push_key_description):
12862 * search.c (Freplace_match):
12863 * xdisp.c (message_dolog, set_message_1): All callers changed.
12864
f6d62986
SM
128652011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12866
12867 * keyboard.c (safe_run_hook_funcall): New function.
12868 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12869 don't set the hook to nil, but remove the offending function instead.
12870 (Qcommand_hook_internal): Remove, unused.
12871 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12872 Vcommand_hook_internal.
12873
12874 * eval.c (enum run_hooks_condition): Remove.
12875 (funcall_nil, funcall_not): New functions.
12876 (run_hook_with_args): Call each function through a `funcall' argument.
12877 Remove `cond' argument, now redundant.
12878 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12879 (Frun_hook_with_args_until_failure): Adjust accordingly.
12880 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12881
1db5b1ad
JB
128822011-03-28 Juanma Barranquero <lekktu@gmail.com>
12883
12884 * dispextern.h (string_buffer_position): Remove declaration.
12885
12886 * print.c (strout): Remove parameter `multibyte', unused since
12887 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12888
12889 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12890 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12891 All callers changed.
12892
12893 * w32.c (_wsa_errlist): Use braces for struct initializers.
12894
12895 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12896 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12897 All callers changed.
12898 (string_buffer_position): Likewise. Also, make static (it's never
12899 used outside xdisp.c).
12900 (cursor_row_p): Remove parameter `w', unused since
12901 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12902 (decode_mode_spec): Remove parameter `precision', introduced during
12903 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12904 All callers changed.
12905
5ffb62aa
JD
129062011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12907
12908 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12909
461c2ab9 129102011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12911
12912 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12913 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12914 (ns_update_auto_hide_menu_bar): New functions.
12915 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12916 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12917 ns_constrain_all_frames.
12918 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12919 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12920
5c380ffb
JD
129212011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12922
12923 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12924
9af30bdf
GM
129252011-03-27 Glenn Morris <rgm@gnu.org>
12926
12927 * syssignal.h: Replace RETSIGTYPE with void.
12928 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12929 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12930 Replace SIGTYPE with void everywhere.
12931 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12932 * s/template.h (SIGTYPE): Remove commented out definition.
12933
e2abce01
JB
129342011-03-26 Eli Zaretskii <eliz@gnu.org>
12935
12936 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12937 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12938
f868cd8a
JB
129392011-03-26 Juanma Barranquero <lekktu@gmail.com>
12940
59eb0929
JB
12941 * w32.c (read_unc_volume): Use parameter `henum', instead of
12942 global variable `wget_enum_handle'.
12943
12944 * keymap.c (describe_vector): Remove parameters `indices' and
12945 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12946 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12947
f868cd8a
JB
12948 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12949
12950 * keyboard.c (timer_check): Remove parameter `do_it_now',
12951 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12952 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12953 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12954
12955 * keyboard.c (read_char):
12956 * w32menu.c (w32_menu_display_help):
12957 * xmenu.c (show_help_event, menu_help_callback):
12958 Adjust calls to `show_help_echo'.
12959
12960 * gtkutil.c (xg_maybe_add_timer):
12961 * keyboard.c (readable_events):
12962 * process.c (wait_reading_process_output):
12963 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12964
12965 * insdel.c (adjust_markers_gap_motion):
12966 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12967 (gap_left, gap_right): Don't call it.
12968
2ecf6fdb
CY
129692011-03-25 Chong Yidong <cyd@stupidchicken.com>
12970
12971 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12972 incurred during fontification.
12973
6b1f9ba4
JB
129742011-03-25 Juanma Barranquero <lekktu@gmail.com>
12975
12976 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12977 (DEFVAR_PER_BUFFER): Don't pass it.
12978
12979 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12980 (scrolling_window): Don't pass it.
12981
0f4a96b5
JB
129822011-03-25 Juanma Barranquero <lekktu@gmail.com>
12983
12984 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12985
12986 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12987 and `suffix'.
12988 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12989 of variables specific to SELinux and computation of `encoded_absname'.
12990
12991 * image.c (XPutPixel): Remove unused variable `height'.
12992
12993 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12994
12995 * unexw32.c (get_section_info): Remove unused variable `section'.
12996
12997 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12998 (system_process_attributes): Remove unused variable `sess'.
12999 (sys_read): Remove unused variable `err'.
13000
13001 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13002 (w32_wnd_proc): Remove unused variable `isdead'.
13003 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13004 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13005 (x_create_tip_frame): Remove unused variable `tem'.
13006
13007 * w32inevt.c (w32_console_read_socket):
13008 Remove unused variable `no_events'.
13009
13010 * w32term.c (x_draw_composite_glyph_string_foreground):
13011 Remove unused variable `width'.
13012
1149507c
JB
130132011-03-24 Juanma Barranquero <lekktu@gmail.com>
13014
13015 * w32term.c (x_set_glyph_string_clipping):
13016 Don't pass uninitialized region to CombineRgn.
13017
9c88f339
JB
130182011-03-23 Juanma Barranquero <lekktu@gmail.com>
13019
13020 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13021 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13022 (Fx_close_connection): Remove unused variable `i'.
13023
13024 * w32font.c (w32font_draw): Return number of glyphs.
13025 (w32font_open_internal): Remove unused variable `i'.
13026 (w32font_driver): Add missing initializer.
13027
13028 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13029 (fill_in_menu): Remove unused variable `items_added'.
13030
13031 * w32term.c (last_mouse_press_frame): Remove static global variable.
13032 (w32_clip_to_row): Remove unused variable `f'.
13033 (x_delete_terminal): Remove unused variable `i'.
13034
13035 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13036 (NOTHING): Remove unused static global variable.
13037 (uniscribe_check_otf): Remove unused variable `table'.
13038 (uniscribe_font_driver): Add missing initializers.
13039
dee091a3
JD
130402011-03-23 Julien Danjou <julien@danjou.info>
13041
13042 * term.c (Fsuspend_tty, Fresume_tty):
13043 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13044 * window.c (temp_output_buffer_show):
13045 * insdel.c (signal_before_change):
13046 * frame.c (Fhandle_switch_frame):
13047 * fileio.c (Fdo_auto_save):
13048 * emacs.c (Fkill_emacs):
13049 * editfns.c (save_excursion_restore):
13050 * cmds.c (internal_self_insert):
13051 * callint.c (Fcall_interactively):
13052 * buffer.c (Fkill_all_local_variables):
13053 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13054 Use Frun_hooks.
0f4a96b5 13055 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13056 unconditionally since it does the check itself.
dee091a3 13057
2c520ab5 130582011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13059
c9c49752
PE
13060 Fix more problems found by GCC 4.5.2's static checks.
13061
8abc3f12
PE
13062 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13063 the first time through the loop, since we know p0 < p1 then.
13064 This also avoids a gcc -Wstrict-overflow warning.
13065
a2d26660
PE
13066 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13067 leading to a memory leak, possible in functions like
13068 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13069 of objects (Bug#8318).
a2d26660 13070
916c72e9
PE
13071 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13072 that could (at least in theory) be that large.
13073
19ab8a18
PE
13074 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13075 This is less likely to overflow, and avoids undefined behavior if
13076 overflow does occur. All callers changed. Use strtoul to scan
13077 for the unsigned long integer.
b7cbbd6f
PE
13078 (pint2hrstr): Simplify and tune code slightly.
13079 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13080
f0641eff
PE
13081 * scroll.c (do_scrolling): Work around GCC bug 48228.
13082 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13083
7f650bb9
PE
13084 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13085 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13086 (validate_x_resource_name): Simplify count usage.
13087 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13088
37dd57d1
PE
13089 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13090 fail (Bug#8306).
81e56e61 13091
699979fc 13092 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13093
401bf9b4
PE
13094 * process.c (Fmake_network_process): Use socklen_t, not int,
13095 where POSIX says socklen_t is required in portable programs.
13096 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13097 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13098 (Fmake_network_process, server_accept_connection):
13099 (wait_reading_process_output, read_process_output):
13100 Likewise.
13101
b93aacde
PE
13102 * process.c: Rename or move locals to avoid shadowing.
13103 (list_processes_1, Fmake_network_process):
13104 (read_process_output_error_handler, exec_sentinel_error_handler):
13105 Rename or move locals.
4dc343ee 13106 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13107 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13108 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13109 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13110 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13111
af8a867c 13112 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13113 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13114 Include tparam.h instead, since it declares them.
af8a867c
PE
13115 * cm.h (PC): Remove extern decl; tparam.h now does this.
13116 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13117 * terminfo.c: Include tparam.h, to check interfaces.
13118 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13119 (tparam): Adjust signature to match interface in tparam.h;
13120 this removes some undefined behavior. Check that outstring and len
13121 are zero, which they always are with Emacs.
13122 * tparam.h (PC, BC, UP): New extern decls.
13123
0248044d 13124 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13125 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13126
8ff096c1 13127 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13128 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13129 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13130 (ftfont_list): Remove unused local.
49eaafba
PE
13131 (get_adstyle_property, ftfont_pattern_entity):
13132 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13133 Rename locals to avoid shadowing.
8ff096c1 13134
e2be39f6
PE
13135 * xfont.c (xfont_list_family): Mark var as initialized.
13136
c9735e30
PE
13137 * xml.c (make_dom): Now static.
13138
8f5201ae
PE
13139 * composite.c (composition_compute_stop_pos): Rename local to
13140 avoid shadowing.
b246f932
PE
13141 (composition_reseat_it): Remove unused locals.
13142 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13143 (composition_update_it): Mark var as initialized.
11b61122
PE
13144 (find_automatic_composition): Mark vars as initialized,
13145 with a FIXME (Bug#8290).
8f5201ae 13146
760fbc2c
PE
13147 character.h: Rename locals to avoid shadowing.
13148 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13149 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13150 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13151 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13152 to avoid shadowing.
13153
ff08eb85
PE
13154 * textprop.c (property_change_between_p): Remove; unused.
13155
fc7bf025
PE
13156 * intervals.c (interval_start_pos): Now static.
13157
235d7abc
PE
13158 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13159
44f230aa
SM
13160 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13161 Rename locals to avoid shadowing.
3e7d6594 13162
50060332
PE
13163 * sound.c (wav_play, au_play, Fplay_sound_internal):
13164 Fix pointer signedness.
d01f234b 13165 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13166 (wav_play): Initialize a variable to 0, to prevent undefined
13167 behavior (Bug#8278).
50060332 13168
c4fc4e30
PE
13169 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13170
918436ed
PE
13171 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13172
c939f91b
PE
13173 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13174 clobbering (Bug#8298).
b9c7f648
PE
13175 * sysdep.c (sys_subshell): Likewise.
13176 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13177
6bd8c144
PE
13178 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13179 This should get cleaned up, so that child_setup has the
13180 same signature on all platforms.
13181
7710357c 13182 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13183 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13184
c59da222
CY
131852011-03-22 Chong Yidong <cyd@stupidchicken.com>
13186
13187 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13188 not to be necessary, and produces flickering.
13189
66b87493
GM
131902011-03-20 Glenn Morris <rgm@gnu.org>
13191
13192 * config.in: Remove file.
13193
45b6f6d5
JB
131942011-03-20 Juanma Barranquero <lekktu@gmail.com>
13195
13196 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13197 are now in src/globals.h.
13198 (syms_of_minibuf): Remove spurious & from previous change.
13199
cd394be1 132002011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13201
13202 * minibuf.c (completing-read-function): New variable.
13203 (completing-read-default): Rename from completing-read.
13204 (completing-read): Call completing-read-function.
13205
b14e3e21
CY
132062011-03-19 Juanma Barranquero <lekktu@gmail.com>
13207
13208 * xfaces.c (Fx_load_color_file):
13209 Read color file from absolute filename (bug#8250).
13210
f2b726e6
JB
132112011-03-19 Juanma Barranquero <lekktu@gmail.com>
13212
13213 * makefile.w32-in: Update dependencies.
13214
09f6ff02
EZ
132152011-03-17 Eli Zaretskii <eliz@gnu.org>
13216
13217 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13218
29a6015a
PE
132192011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13220
a3a6c54e
PE
13221 Fix more problems found by GCC 4.5.2's static checks.
13222
b766f867
PE
13223 * process.c (make_serial_process_unwind, send_process_trap):
13224 (sigchld_handler): Now static.
13225
be02381c
PE
13226 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13227 That way, the code declares only the vars that it needs.
13228 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13229 * s/cygwin.h (PTY_ITERATION): Likewise.
13230 * s/darwin.h (PTY_ITERATION): Likewise.
13231 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13232
57048744
PE
13233 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13234 * process.c (allocate_pty): Don't declare stb unless it's needed.
13235
7914961c 13236 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13237 (CONSTANTLIM): Remove; unused.
13238 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13239 Define only if needed.
7914961c 13240
b3967b18
PE
13241 * unexelf.c (unexec): Name an expression,
13242 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13243 Use a different way to cause a compilation error if anyone uses
13244 n rather than nn, a way that does not involve shadowing.
73366a00 13245 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13246
29a6015a
PE
13247 * deps.mk (unexalpha.o): Remove; unused.
13248
43cfc33e 13249 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13250 * unexec.h: New file.
ce701a33
PE
13251 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13252 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13253 Depend on unexec.h.
13254 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13255 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13256 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13257 Change as necessary to match prototype in unexec.h.
ce701a33 13258
01f44d5a
PE
13259 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13260 shadowing.
4f63c6bb 13261 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13262
a6670b0b
PE
13263 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13264 Rename locals to avoid shadowing.
13265
cef2010d 13266 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13267 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13268
d4d7173a
PE
13269 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13270
f08b802a
PE
13271 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13272 warning when compiling print.c.
13273
3ddb0639
PE
13274 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13275 instead of using an uninitialized var.
5ad03b97 13276 (font_sort_entities): Mark var as initialized.
3ddb0639 13277
170a2692
PE
13278 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13279
e663c700
PE
13280 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13281 pointers to constants.
89bc529a 13282 (font_parse_fcname): Remove unused vars.
7b81e2d0 13283 (font_delete_unmatched): Now static.
ea838e10 13284 (font_get_spec): Remove; unused.
13a547c6
PE
13285 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13286 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13287 Rename or move locals to avoid shadowing.
e663c700 13288
2a80c887 13289 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13290 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13291
1384fa33 13292 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13293 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13294
8b2c52e9
PE
13295 * alloc.c (mark_backtrace): Move decl from here ...
13296 * lisp.h: ... to here, so that it can be checked.
13297
475545b5 13298 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13299 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13300 (lisp_indirect_variable): Name an expression,
13301 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13302 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13303
b1349114 13304 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13305 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13306 Use const pointer when appropriate.
b1349114 13307
a2928364
PE
13308 * lisp.h (get_system_name, get_operating_system_release):
13309 Move decls here, to check interfaces.
13310 * process.c (get_operating_system_release): Move decl to lisp.h.
13311 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13312 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13313 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13314 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13315 (Fformat_time_string, Fencode_time, Finsert_char):
13316 (Ftranslate_region_internal, Fformat):
13317 Rename or remove local vars to avoid shadowing.
9710023e 13318 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13319
a415e694
PE
13320 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13321 avoid shadowing.
13322
8ef4622d
PE
13323 * lisp.h (eassert): Check that the argument compiles, even if
13324 ENABLE_CHECKING is not defined.
13325
946f9a5b
PE
13326 * data.c (Findirect_variable): Name an expression, to avoid
13327 gcc -Wbad-function-cast warning.
112396d6 13328 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13329 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13330 (Fmake_variable_buffer_local, Fmake_local_variable):
13331 Mark variables as initialized.
52746918 13332 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13333
e5aab7e7 13334 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13335 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13336 Rename locals to avoid shadowing.
dff45157
PE
13337 (mark_stack): Move local variables into the #ifdef region where
13338 they're used.
7bc26fdb
PE
13339 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13340 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13341 needed otherwise.
13342 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13343 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13344 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13345
e5aab7e7
PE
13346 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13347 avoids undefined behavior in theory.
13348
4da60324
PE
13349 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13350
88043301
PE
13351 Use functions, not macros, for up- and down-casing (Bug#8254).
13352 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13353 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13354 to use the following functions instead of these macros.
13355 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13356 EMACS_INT, since callers assume the returned value fits in int.
13357 (upcase1): Likewise, for UPCASE_TABLE.
13358 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13359 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13360 the race-condition problem in the old DOWNCASE.
88043301 13361
19ed5445
PE
13362 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13363 Rename locals to avoid shadowing.
13364 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13365 (regex_compile, re_search_2, re_match_2_internal):
13366 Remove unused local vars.
952db0d7
PE
13367 (FREE_VAR): Rewrite so as not to use empty "else",
13368 which gcc can warn about.
da053e48 13369 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13370 (RETALLOC_IF): Define only if needed.
13371 (WORDCHAR_P): Likewise. This one is never needed, but is used
13372 only in a comment talking about a compiler bug, so put inside
13373 the #if 0 of that comment.
13374 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13375 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13376 Remove; unused.
19ed5445 13377
1f3561e4 13378 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13379 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13380 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13381
ded6f8f7
PE
13382 * search.c (simple_search): Remove unused var.
13383
dbd37a95
PE
13384 * dired.c (compile_pattern): Move decl from here ...
13385 * lisp.h: ... to here, so that it can be checked.
13386 (struct re_registers): New forward decl.
13387
7e47afad
PE
13388 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13389
85f24f61
PE
13390 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13391 All uses changed.
13392 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13393 Rename locals to avoid shadowing.
5671df8f 13394 (Fvertical_motion): Mark locals as initialized.
85f24f61 13395
181aa2be 13396 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13397 (casify_region): Mark local as initialized.
181aa2be 13398
930d429c
PE
13399 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13400
7082eac6
PE
13401 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13402 New macros, so that the caller can use some names other than
13403 gcpro1, gcpro2, etc.
13404 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13405 of the new macros.
13406 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13407 argument, for consistency with GCPRO2_VAR, etc: it is now the
13408 prefix of the variable, not the variable itself. All uses
13409 changed.
38b2c076
PE
13410 * dired.c (directory_files_internal, file_name_completion):
13411 Rename locals to avoid shadowing.
13412
15206ed9
PE
13413 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13414 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13415 dired.c's scmp function, had undefined behavior.
13416 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13417 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13418 * buffer.h: ... to here, because these macros use current_buffer,
13419 and the new implementation with inline functions needs to have
13420 current_buffer in scope now, rather than later when the macros
13421 are used.
13422 (downcase, upcase1): New static inline functions.
13423 (DOWNCASE, UPCASE1): Reimplement using these functions.
13424 This avoids undefined behavior in expressions like
13425 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13426 from race conditions in accessing the global variables
13427 case_temp1 and case_temp2.
13428 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13429 * lisp.h (case_temp1, case_temp2): Remove their decls.
13430 * character.h (ASCII_CHAR_P): Move from here ...
13431 * lisp.h: ... to here, so that the inline functions mentioned
13432 above can use them.
13433
4a6bea26
PE
13434 * dired.c (directory_files_internal_unwind): Now static.
13435
f14b7e14
PE
13436 * fileio.c (file_name_as_directory, directory_file_name):
13437 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13438 Now static.
2893f146
PE
13439 (file_name_as_directory): Use const pointers when appropriate.
13440 (Fexpand_file_name): Likewise. In particular, newdir might
13441 point at constant storage, so make it a const pointer.
fd4ead52 13442 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13443 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13444 signedness issues.
f839df0c
PE
13445 (Fset_file_times, Finsert_file_contents, auto_save_error):
13446 Rename locals to avoid shadowing.
f14b7e14 13447
5716756e 13448 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13449 (Ftry_completion, Fall_completions): Rename or remove locals
13450 to avoid shadowing.
5716756e 13451
b4c3046a
PE
13452 * marker.c (bytepos_to_charpos): Remove; unused.
13453
b45db522
PE
13454 * lisp.h (verify_bytepos, count_markers): New decls,
13455 so that gcc does not warn that these functions aren't declared.
13456
85876d07
PE
13457 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13458 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13459 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13460 (copy_text): Remove unused local var.
85876d07 13461
03d78a21 13462 * filelock.c (within_one_second): Now static.
b3dd38ab 13463 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13464
5df8f01b
PE
13465 * buffer.c (fix_overlays_before): Mark locals as initialized.
13466 (fix_start_end_in_overlays): Likewise. This function should be
13467 simplified by using pointers-to-pointers, but that's a different
13468 matter.
b1d876f1 13469 (switch_to_buffer_1): Now static.
8f54f30a
PE
13470 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13471 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13472
a70072c9 13473 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13474 Fix pointer signedness issue.
edced198
PE
13475 (sys_subshell): Mark local as volatile if checking for lint,
13476 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13477 (MAXPATHLEN): Define only if needed.
a70072c9 13478
a0977c44
PE
13479 * process.c (serial_open, serial_configure): Move decls from here ...
13480 * systty.h: ... to here, so that they can be checked.
13481
a884fdcc
PE
13482 * fns.c (get_random, seed_random): Move extern decls from here ...
13483 * lisp.h: ... to here, so that they can be checked.
13484
604efe86 13485 * sysdep.c (reset_io): Now static.
b8950c94 13486 (wait_for_termination_signal): Remove; unused.
604efe86 13487
38fc62d9
PE
13488 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13489 (copy_keymap_item, append_key, push_text_char_description):
13490 Now static.
1004a21a 13491 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13492 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13493 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13494 (describe_map_tree):
13495 Rename locals to avoid shadowing.
38fc62d9 13496
2f2650da
PE
13497 * keyboard.c: Declare functions static if they are not used elsewhere.
13498 (echo_char, echo_dash, cmd_error, top_level_2):
13499 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13500 (read_char, kbd_buffer_get_event, make_lispy_position):
13501 (make_lispy_event, make_lispy_movement, apply_modifiers):
13502 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13503 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13504 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13505 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13506 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13507
a053e86c 13508 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13509 (mark_kboards): Move decl here ...
13510 * alloc.c (mark_kboards): ... from here.
a053e86c 13511
4752793e
PE
13512 * lisp.h (force_auto_save_soon): New decl.
13513
74f10ca7 13514 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13515 (DEFINE_DUMMY_FUNCTION): New macro.
13516 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13517 Use it.
c03cd23f
PE
13518 (main): Add casts to avoid warnings
13519 if GCC considers string literals to be constants.
74f10ca7 13520
022e70d4
PE
13521 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13522
59d6fe83
PE
13523 * dbusbind.c: Pointer signedness fixes.
13524 (xd_signature, xd_append_arg, xd_initialize):
13525 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13526 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13527 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13528 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13529
78320123
PE
13530 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13531 if GCC considers string literals to be constants.
49cebcca 13532 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13533
35ac2a97
SM
135342011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13535
fb103ca9
SM
13536 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13537 (print_preprocess, print_object): New macro to fix last change.
13538
35ac2a97
SM
13539 * print.c (print_preprocess): Don't forget font objects.
13540
62973b41
JB
135412011-03-16 Juanma Barranquero <lekktu@gmail.com>
13542
13543 * emacs.c (USAGE3): Doc fixes.
13544
0e48bb22
AS
135452011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13546
13547 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13548 structure.
13549
7684e57b
JB
135502011-03-14 Juanma Barranquero <lekktu@gmail.com>
13551
13552 * lisp.h (VWindow_system, Qfile_name_history):
13553 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13554 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13555 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13556
13557 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13558 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13559
13560 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13561 * w32console.c (detect_input_pending, read_input_pending)
13562 (encode_terminal_code):
13563 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13564 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13565 (w32_system_caret_y, Qfile_name_history):
13566 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13567 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13568 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13569 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13570 * w32proc.c (Qlocal, report_file_error):
13571 * w32term.c (Vwindow_system, updating_frame):
13572 * w32uniscribe.c (initialized, uniscribe_font_driver):
13573 Remove unneeded extern declarations.
13574
2aa46d6c
CY
135752011-03-14 Chong Yidong <cyd@stupidchicken.com>
13576
c96bbc66 13577 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13578
cffc6f3b
CY
135792011-03-13 Chong Yidong <cyd@stupidchicken.com>
13580
13581 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13582 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13583 These macros can no longer be used for assignment.
13584
44f230aa
SM
13585 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13586 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13587 (record_buffer_markers, fetch_buffer_markers): New functions for
13588 recording and fetching special buffer markers.
13589 (set_buffer_internal_1, set_buffer_temp): Use them.
13590
13591 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13592
13593 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13594
13595 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13596 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13597
13598 * xdisp.c (hscroll_window_tree):
13599 (reconsider_clip_changes): Use PT instead of BUF_PT.
13600
d251f04b
EZ
136012011-03-13 Eli Zaretskii <eliz@gnu.org>
13602
13603 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13604 $(EMACS_ROOT)/lib/intprops.h.
13605
f0c77cd1
PE
136062011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13607
3eca4629
PE
13608 Fix more problems found by GCC 4.5.2's static checks.
13609
7c86ee98
PE
13610 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13611 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13612 (xg_free_frame_widgets): Make it clear that a local variable is
13613 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13614 (gdk_window_get_screen): Make it clear that this macro is needed
13615 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13616 (int_gtk_range_get_value): New function, which avoids a diagnostic
13617 from gcc -Wbad-function-cast.
13618 (xg_set_toolkit_scroll_bar_thumb): Use it.
13619 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13620 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13621 (get_utf8_string, xg_get_file_with_chooser):
13622 Rename locals to avoid shadowing.
13623 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13624
41729b81
PE
13625 * xgselect.c (xg_select): Remove unused var.
13626
f0c77cd1
PE
13627 * image.c (four_corners_best): Mark locals as initialized.
13628 (gif_load): Initialize transparent_p to zero (Bug#8238).
13629 Mark another local as initialized.
ec6cf4c6 13630 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13631
ce0ad53d 13632 * image.c (clear_image_cache): Now static.
d5d5a617 13633 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13634 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13635 (x_edge_detection): Remove unnecessary cast that
13636 gcc -Wbad-function-cast diagnoses.
2037898d 13637 (gif_load): Fix pointer signedness.
6ae141d6
PE
13638 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13639 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13640
33383987 136412011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13642
d32df629
PE
13643 Improve quality of tests for time stamp overflow.
13644 For example, without this patch (encode-time 0 0 0 1 1
13645 1152921504606846976) returns the obviously-bogus value (-948597
13646 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13647 reports time overflow. See
13648 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13649 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13650 * editfns.c: Include limits.h and intprops.h.
13651 (TIME_T_MIN, TIME_T_MAX): New macros.
13652 (time_overflow): Move earlier, to before first use.
13653 (hi_time, lo_time): New functions, for an accurate test for
13654 out-of-range times.
13655 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13656 (Fget_internal_run_time): Don't assume time_t fits in int.
13657 (make_time): Use list2 instead of Fcons twice.
13658 (Fdecode_time): More accurate test for out-of-range times.
13659 (check_tm_member): New function.
13660 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13661 (lisp_time_argument): Don't rely on undefined left-shift and
13662 right-shift behavior when checking for time stamp overflow.
8be6f318 13663
fe31d94c
PE
13664 * editfns.c (time_overflow): New function, refactoring common code.
13665 (Fformat_time_string, Fdecode_time, Fencode_time):
13666 (Fcurrent_time_string): Use it.
13667
8be6f318
PE
13668 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13669 * dired.c (make_time): Move to ...
13670 * editfns.c (make_time): ... here.
13671 * systime.h: Note the move.
13672
09d9db2c 136732011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13674
126bc0dc
YM
13675 * fringe.c (update_window_fringes): Remove unused variables.
13676
c47cbdfd
YM
13677 * unexmacosx.c (copy_data_segment): Also copy __got section.
13678 (Bug#8223)
13679
7ac80be9
EZ
136802011-03-12 Eli Zaretskii <eliz@gnu.org>
13681
c96bbc66 13682 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13683 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13684 Constify `char *' arguments and their references according to
13685 prototypes in tparam.h.
13686
ecb0f94d 13687 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13688
7ac80be9
EZ
13689 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13690 Adapt all references accordingly.
13691
13692 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13693
ef1fd07e
TT
136942011-03-11 Tom Tromey <tromey@redhat.com>
13695
13696 * buffer.c (syms_of_buffer): Remove obsolete comment.
13697
7ef4b50c
EZ
136982011-03-11 Eli Zaretskii <eliz@gnu.org>
13699
13700 * termhooks.h (encode_terminal_code): Declare prototype.
13701
13702 * msdos.c (encode_terminal_code): Don't declare prototype.
13703
13704 * term.c (encode_terminal_code): Now external again, used by
13705 w32console.c and msdos.c.
13706
44f230aa
SM
13707 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13708 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13709
4b1ec863 137102011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13711
1714f52b 13712 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13713
4b1ec863
PE
13714 * fringe.c (update_window_fringes): Mark locals as initialized
13715 (Bug#8227).
13716 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13717
524c7aa6
PE
13718 * alloc.c (mark_fringe_data): Move decl from here ...
13719 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13720 to check its interface.
13721 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13722
a5c0af81 13723 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13724 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13725 (fontset_font): Mark local as initialized.
a9a06e0b 13726 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13727
b4716021
PE
13728 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13729
811e9bac 13730 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13731 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13732 (x_own_selection, Fx_disown_selection_internal): Rename locals
13733 to avoid shadowing.
13734 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13735
7e3ab302
PE
13736 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13737 so that the caller can use some name other than gcpro1.
13738 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13739 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13740 (Fx_backspace_delete_keys_p):
13741 Use them to avoid shadowing, and rename vars to avoid shadowing.
13742 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13743 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13744 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13745 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13746 Remove unused locals.
7e3ab302
PE
13747 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13748 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13749 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13750 macros.
f78faa98 13751
e2b13473
PE
13752 * xterm.h (x_mouse_leave): New decl.
13753
77f23912
PE
13754 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13755 Remove unused functions.
cdf4ba58
PE
13756 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13757 (x_calc_absolute_position): Now static.
7411c686 13758 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13759 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13760 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13761 unless they are used.
38d0b34a
PE
13762 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13763 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13764 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13765 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13766 (x_error_catcher, x_connection_closed, x_error_handler):
13767 (x_error_quitter, xembed_send_message, x_iconify_frame):
13768 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13769 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13770 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13771
44f230aa
SM
13772 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13773 Rename or move locals to avoid shadowing.
6b463e58 13774 (tty_defined_color, merge_face_heights): Now static.
5967d051 13775 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13776 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13777 does not deduce is never used uninitialized.
73719eba
PE
13778 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13779 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13780
426994c3 13781 * terminal.c (store_terminal_param): Now static.
5489860b 13782
032f1620 13783 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13784 (set_frame_menubar): Remove unused local.
d4323972 13785 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13786 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13787 since they might point to immutable storage.
281585b0
PE
13788 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13789 since it's unused otherwise.
032f1620 13790
367c19e5 13791 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13792 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13793 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13794 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13795 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13796 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13797 does not deduce are never used uninitialized.
70739cbe 13798
07b48fa9
PE
13799 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13800
8868a238 13801 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13802 * window.c (window_loop, size_window):
13803 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13804
7e5cf297 13805 * window.c (display_buffer): Now static.
d6550a9f
PE
13806 (size_window): Mark variables that gcc -Wuninitialized
13807 does not deduce are never used uninitialized.
a586633d
PE
13808 * window.h (check_all_windows): New decl, to forestall
13809 gcc -Wmissing-prototypes diagnostic.
5b555da1 13810 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13811
f6095868
PE
13812 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13813 shadowing.
13814 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13815 Include <limits.h>.
13816 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13817 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13818 (load_charset_map): Mark variables that gcc -Wuninitialized
13819 does not deduce are never used uninitialized.
53df7c11 13820 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13821
f38b440c
PE
13822 * coding.c (coding_set_source, coding_set_destination):
13823 Use "else { /* comment */ }" rather than "else /* comment */;"
13824 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13825 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13826 a block, when the outer 'i' will do.
13827 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13828 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13829 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13830 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13831 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13832 Rename locals to avoid shadowing.
13833 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13834 * coding.c (emacs_mule_char, encode_invocation_designation):
13835 Now static, since they're not used elsewhere.
413bb2db 13836 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13837 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13838 (decode_coding_emacs_mule): Mark variables that gcc
13839 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13840 (detect_coding_iso_2022): Initialize a local variable that might
13841 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13842 this initialization is needed. (Bug#8211)
5f58e762
PE
13843 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13844 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13845 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13846 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13847 Remove unused macros.
f38b440c 13848
232b38b9 13849 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13850 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13851 * character.c (string_count_byte8): Likewise.
232b38b9 13852
fb90da1b
PE
13853 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13854 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13855
fb93dbc2
PE
13856 * chartab.c (copy_sub_char_table): Now static, since it's not used
13857 elsewhere.
5c156ace
PE
13858 (sub_char_table_ref_and_range, char_table_ref_and_range):
13859 Rename locals to avoid shadowing.
bbcd0949 13860 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13861
7d3b3862 13862 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13863 (BIDI_BOB): Remove unused macro.
7d3b3862 13864
6be7d3da
PE
13865 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13866 deduce are never used uninitialized.
c2ed9c8b 13867 * term.c (encode_terminal_code): Likewise.
6be7d3da 13868
75f8807f 13869 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13870
50938595
PE
13871 * tparam.h: New file.
13872 * term.c, tparam.h: Include it.
13873 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13874 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13875 Move these decls to tparam.h, and make them agree with what
13876 is actually in tparam.c. The previous trick of using incompatible
13877 decls in different modules does not conform to the C standard.
13878 All callers of tparam changed to use tparam's actual API.
13879 * tparam.c (tparam1, tparam, tgoto):
13880 Use const pointers where appropriate.
13881
fbceeba2
PE
13882 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13883 * cm.h (struct cm): Likewise.
13884 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13885 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13886 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13887 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13888 (turn_on_face, init_tty): Likewise.
13889 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13890
7f3f1250
PE
13891 * term.c (term_mouse_position): Rename local to avoid shadowing.
13892
e6ca6543
PE
13893 * alloc.c (mark_ttys): Move decl from here ...
13894 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13895
c40f8d15
AS
138962011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13897
13898 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13899
cfe0661d
JB
139002011-03-09 Juanma Barranquero <lekktu@gmail.com>
13901
13902 * search.c (compile_pattern_1): Remove argument regp, unused since
13903 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13904 (compile_pattern): Don't pass it.
13905
0afb4571
J
139062011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13907
13908 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13909 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13910 for ! HAVE_GTK3.
13911 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13912
13913 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13914
13915 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13916 gdk_window_get_screen, gdk_window_get_geometry,
13917 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13918 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13919 (xg_get_pixbuf_from_pixmap): New function.
13920 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13921 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13922 Call xg_get_pixbuf_from_pixmap instead of
13923 gdk_pixbuf_get_from_drawable.
13924 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13925 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13926 (xg_check_special_colors): Use GtkStyleContext and its functions
13927 for HAVE_GTK3.
13928 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13929 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13930 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13931 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13932 Call gtk_widget_get_preferred_size.
0afb4571
J
13933 (xg_frame_resized): gdk_window_get_geometry only takes 5
13934 parameters.
44f230aa
SM
13935 (xg_win_to_widget, xg_event_is_for_menubar):
13936 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13937 (xg_set_widget_bg): New function.
13938 (delete_cb): New function.
895009e1 13939 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13940 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13941 (xg_set_background_color): Call xg_set_widget_bg.
13942 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13943 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13944 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13945 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13946 if ! HAVE_GTK3.
13947 (update_frame_tool_bar): Call gtk_widget_hide.
13948 (xg_initialize): Use GDK_KEY_g.
13949
13950 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13951 if ! HAVE_GTK3
13952 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13953
13954 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13955 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13956 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13957
1c2cc4ef
JB
139582011-03-08 Juanma Barranquero <lekktu@gmail.com>
13959
13960 * w32xfns.c (select_palette): Check success of RealizePalette against
13961 GDI_ERROR, not zero.
13962
33383987 13963See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13964
13965;; Local Variables:
13966;; coding: utf-8
aac0c6e3
MR
13967;; End:
13968
2f097256 13969 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13970
13971 This file is part of GNU Emacs.
13972
13973 GNU Emacs is free software: you can redistribute it and/or modify
13974 it under the terms of the GNU General Public License as published by
13975 the Free Software Foundation, either version 3 of the License, or
13976 (at your option) any later version.
13977
13978 GNU Emacs is distributed in the hope that it will be useful,
13979 but WITHOUT ANY WARRANTY; without even the implied warranty of
13980 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13981 GNU General Public License for more details.
13982
13983 You should have received a copy of the GNU General Public License
13984 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.