* eval.c (internal_lisp_condition_case): Don't pass spurious arg.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bff87ef0
PE
12011-04-07 Paul Eggert <eggert@cs.ucla.edu>
2
b189fa66
PE
3 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4
bff87ef0
PE
5 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6
79c49ad2
PE
72011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8
7e2cac20
PE
9 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10
ce4d90b5
PE
11 * xterm.c (x_catch_errors): Remove duplicate declaration.
12
266c9547
PE
13 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
14
79c49ad2
PE
15 * xdisp.c, lisp.h (message_nolog): Remove; unused.
16
973f782d
EZ
172011-04-06 Eli Zaretskii <eliz@gnu.org>
18
7c106b1e
EZ
19 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
20
973f782d
EZ
21 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
22
41cf7d1a 232011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 24
ca23cc88
PE
25 Fix more problems found by GCC 4.6.0's static checks.
26
f390e2d5
PE
27 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
28
42eea0d0
PE
29 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
30
b69769da 31 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 32
f9541e84
PE
33 * xdisp.c (vmessage): Mark as a printf-like function.
34
13841b55
PE
35 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
36
c136c10f
PE
37 * sound.c (sound_warning): Don't crash if arg contains a printf format.
38
5e2d4a30
PE
39 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
40 printf-like functions.
41 (tiff_load): Add casts to remove these marks before passing them
42 to system-supplied API.
43
583f48b9
PE
44 * eval.c (Fsignal): Remove excess argument to 'fatal'.
45
b25d760e
PE
46 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
47 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
48 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
49 directly, rather than having caller test rule sign. This avoids
50 some unnecessary tests.
51 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
52 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
53 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 54
bc7b6697 55 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 56 (xfont_open): Avoid unnecessary tests.
bc7b6697 57
27ccc379
PE
58 * composite.c (composition_gstring_put_cache): Use unsigned integer.
59
dcd5c89a
PE
60 * composite.h, composite.c (composition_gstring_put_cache):
61 Use EMACS_INT, not int, for length.
62
b13a45c6
PE
63 * composite.h (COMPOSITION_DECODE_REFS): New macro,
64 breaking out part of COMPOSITION_DECODE_RULE.
65 (COMPOSITION_DECODE_RULE): Use it.
66 * composite.c (get_composition_id): Remove unused local vars,
67 by using the new macro.
68
1e792e4d
PE
69 * textprop.c (set_text_properties_1): Change while to do-while,
70 since the condition is always true at first.
71
dc6c6455 72 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
73 (interval_deletion_adjustment): Return unsigned value.
74 All uses changed.
dc6c6455 75
aba7731a
PE
76 * process.c (list_processes_1, create_pty, read_process_output):
77 (exec_sentinel): Remove vars that were set but not used.
afd4052b 78 (create_pty): Remove unnecessary "volatile"s.
bc57d757 79 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 80 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 81 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 82
fdfc4bf3
PE
83 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
84
fca8fe46 85 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 86 (update_syntax_table): Use unsigned instead of int.
fca8fe46 87
06a0259a 88 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 89 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 90 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 91
e7b9e80f
PE
92 * print.c (print_error_message): Avoid int overflow.
93
56201685
PE
94 * font.c (font_list_entities): Redo for clarity,
95 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
96
78834453 97 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 98 (font_score): Avoid potential overflow in diff calculation.
78834453 99
0bc0b309 100 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 101 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 102
e610eaca
PE
103 * eval.c (funcall_lambda): Rename local to avoid shadowing.
104
b895abce
PE
105 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
106 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
107 can always succeed if overflow has undefined behavior.
108
1f1d9321 109 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 110 (wordify): Omit three unnecessary tests.
1f1d9321 111
c59478bc
PE
112 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
113 All callers changed. This avoids the need for an unused var.
114
79b73827
PE
115 * casefiddle.c (casify_region): Remove var that is set but not used.
116
a4db5dfe
PE
117 * dired.c (file_name_completion): Remove var that is set but not used.
118
43aae36e
PE
119 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
120
2a47c44d 121 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 122 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 123
a37c69bf
PE
124 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
125 Check for integer overflow on size calculations.
126
328ab8e7
PE
127 * buffer.c (Fprevious_overlay_change): Remove var that is set
128 but not used.
129
e5a2a5cb
PE
130 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
131 Remove vars that are set but not used.
8d84a6eb 132 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 133 (timer_check_2): Mark vars as initialized.
e5a2a5cb 134
a60e5f68
PE
135 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
136
f661cb61 137 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 138 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 139
f0397f5a
PE
140 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
141 that are set but not used.
142
8664db06 143 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 144 if XCreateBitmapFromData fails (Bug#8410).
8664db06 145
6abdaa4a
PE
146 * xselect.c (x_get_local_selection, x_handle_property_notify):
147 Remove vars that are set but not used.
148
0ce7538d 149 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 150 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 151
9ae848fc
PE
152 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
153 Remove var that is set but not used.
0b918413
PE
154 (scroll_bar_windows_size): Now size_t, not int.
155 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
156 Check for overflow.
9ae848fc 157
a5a62657
PE
158 * xfaces.c (realize_named_face): Remove vars that are set but not used.
159 (map_tty_color) [!defined MSDOS]: Likewise.
160
5c5cdd39
PE
161 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
162
66ebf983
PE
163 * coding.c: Remove vars that are set but not used.
164 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
165 All callers changed.
166 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
167 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
168 (decode_coding_charset): Remove vars that are set but not used.
169
1be4d761
PE
170 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
171 that is set but not used.
172
47553fa8
PE
173 * print.c (print_object): Remove var that is set but not used.
174
1f7196bf 175 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
176 The gnulib version avoids calling malloc in the usual case,
177 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
178 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
179 * filelock.c (current_lock_owner): Likewise.
180 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
181 * sysdep.c: Include allocator.h, careadlinkat.h.
182 (emacs_no_realloc_allocator): New static constant.
183 (emacs_readlink): New function.
fdb61804
PE
184 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
185 ../lib/careadlinkat.h.
d1fdcab7 186
f84c17c7
SM
1872011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
188
189 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
190 first non-nil return value).
191
ef3862ad
JD
1922011-04-03 Jan Djärv <jan.h.d@swipnet.se>
193
194 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
195 if not defined (Bug#8403).
196
376a7006
JB
1972011-04-02 Juanma Barranquero <lekktu@gmail.com>
198
199 * xdisp.c (display_count_lines): Remove parameter `start',
200 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
201 (get_char_face_and_encoding): Remove parameter `multibyte_p',
202 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
203 (fill_stretch_glyph_string): Remove parameters `row' and `area',
204 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
205 and thereabouts. All callers changed.
206 (get_per_char_metric): Remove parameter `f', unused since
207 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
208
6ca3801d
JM
2092011-04-02 Jim Meyering <meyering@redhat.com>
210
211 do not dereference NULL upon failed strdup
212 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
213 (ns_get_family): Likewise.
214
d8e2b5ba
JB
2152011-04-02 Juanma Barranquero <lekktu@gmail.com>
216
217 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
218
8c74fcbd
JD
2192011-04-02 Jan Djärv <jan.h.d@swipnet.se>
220
221 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
222 later (Bug#8403).
223
7200d79c
SM
2242011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
225
03408648 226 Add lexical binding.
7200d79c 227
03408648
SM
228 * window.c (Ftemp_output_buffer_show): New fun.
229 (Fsave_window_excursion):
230 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
231
232 * lread.c (lisp_file_lexically_bound_p): New function.
233 (Fload): Bind Qlexical_binding.
234 (readevalloop): Remove `evalfun' arg.
235 Bind Qinternal_interpreter_environment.
236 (Feval_buffer): Bind Qlexical_binding.
237 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
238 Mark as dynamic.
239 (syms_of_lread): Declare `lexical-binding'.
240
241 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
242
243 * keyboard.c (eval_dyn): New fun.
244 (menu_item_eval_property): Use it.
ca105506
SM
245
246 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 247
03408648
SM
248 * fns.c (concat, mapcar1): Accept byte-code-functions.
249
250 * eval.c (Fsetq): Handle lexical vars.
251 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
252 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
253 (FletX, Flet): Obey lexical binding.
254 (Fcommandp): Handle closures.
255 (Feval): New `lexical' arg.
256 (eval_sub): New function extracted from Feval. Use it almost
257 everywhere where Feval was used. Look up vars in lexical env.
258 Handle closures.
259 (Ffunctionp): Move from subr.el.
260 (Ffuncall): Handle closures.
261 (apply_lambda): Remove `eval_flags'.
262 (funcall_lambda): Handle closures and new byte-code-functions.
263 (Fspecial_variable_p): New function.
264 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
265 but without exporting it to Lisp.
23aba0ea 266
23aba0ea 267 * doc.c (Fdocumentation, store_function_docstring):
03408648 268 * data.c (Finteractive_form): Handle closures.
23aba0ea 269
03408648
SM
270 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
271 interactive spec.
ba83908c 272
03408648
SM
273 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
274 byte-codes.
275 (exec_byte_code): New function extracted from Fbyte_code to handle new
276 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 277
03408648 278 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 279
03408648 280 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 281
e2abce01
JB
2822011-03-31 Juanma Barranquero <lekktu@gmail.com>
283
284 * xdisp.c (redisplay_internal): Fix prototype.
285
63696a73 2862011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 287
63696a73
EZ
288 * xdisp.c (SCROLL_LIMIT): New macro.
289 (try_scrolling): Use it when setting scroll_limit. Limit
290 scrolling to 100 screen lines.
291 (redisplay_window): Even when falling back on "recentering",
292 position point in the window according to scroll-conservatively,
293 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
294
295 (try_scrolling): When point is above the window, allow searching
296 as far as scroll_max, or one screenful, to compute vertical
297 distance from PT to the scroll margin position. This prevents
298 try_scrolling from unnecessarily failing when
299 scroll-conservatively is set to a value slightly larger than the
300 window height. Clean up the case of PT below the margin at bottom
301 of window: scroll_max can no longer be INT_MAX. When aggressive
302 scrolling is in use, don't let point enter the opposite scroll
303 margin as result of the scroll.
304 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
305 threshold of 100 lines for never-recentering scrolling.
306
e4cc2dfc
JB
3072011-03-31 Juanma Barranquero <lekktu@gmail.com>
308
309 * dispextern.h (move_it_by_lines):
310 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
311 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
312 (message_log_check_duplicate): Remove parameters `prev_bol' and
313 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
314 (redisplay_internal): Remove parameter `preserve_echo_area',
315 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
316
317 * indent.c (Fvertical_motion):
318 * window.c (window_scroll_pixel_based, Frecenter):
319 Don't pass `need_y_p' to `move_it_by_lines'.
320
1c470562
SM
3212011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
322
44f230aa
SM
323 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
324 steal a few bits to be more compact.
325 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
326 Remove unneeded casts.
327
1c470562
SM
328 * bytecode.c (Fbyte_code): CAR and CDR can GC.
329
888adce9
ZK
3302011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
331
332 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
333 binding" message (bug#7967).
334
f838ed7b
PE
3352011-03-30 Paul Eggert <eggert@cs.ucla.edu>
336
77861b95
PE
337 Fix more problems found by GCC 4.6.0's static checks.
338
de6dbc14
PE
339 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
340 Remove unused local var.
341
f838ed7b
PE
342 * editfns.c (Fmessage_box): Remove unused local var.
343
792c7b2b
PE
344 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
345 (note_mode_line_or_margin_highlight, note_mouse_highlight):
346 Omit unused local vars.
c499e557 347 * window.c (shrink_windows): Omit unused local var.
b01a1c29 348 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
349 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
350 Omit unused local var.
351
ba0165e1
PE
352 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
353 Don't assume string length fits in int.
32ad8845 354 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 355 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 356
3c59b4c9
PE
357 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
358 instead of alloca (Bug#8344).
359
a3eed478 360 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 361 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 362
eb4d412d
PE
363 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
364
1658b401
PE
365 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
366 concerns.
367
368 * term.c (produce_glyphless_glyph): Remove unnecessary test.
369
370 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 371
9a2c6e05
PE
372 * keyboard.c (syms_of_keyboard): Use the same style as later
373 in this function when indexing through an array. This also
374 works around GCC bug 48267.
375
03d0a109
PE
376 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
377
44f730c8
PE
378 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
379
fe75f926
PE
380 * chartab.c (sub_char_table_ref_and_range): Redo for slight
381 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
382
ffa8c828
PE
383 * keyboard.c, keyboard.h (num_input_events): Now size_t.
384 This avoids undefined behavior on integer overflow, and is a bit
385 more convenient anyway since it is compared to a size_t variable.
386
c5101a77
PE
387 Variadic C functions now count arguments with size_t, not int.
388 This avoids an unnecessary limitation on 64-bit machines, which
389 caused (substring ...) to crash on large vectors (Bug#8344).
390 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
391 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 392 All variadic functions and their callers changed accordingly.
c5101a77
PE
393 (struct gcpro.nvars): Now size_t, not int. All uses changed.
394 * data.c (arith_driver, float_arith_driver): Likewise.
395 * editfns.c (general_insert_function): Likewise.
396 * eval.c (struct backtrace.nargs, interactive_p)
397 (internal_condition_case_n, run_hook_with_args, apply_lambda)
398 (funcall_lambda, mark_backtrace): Likewise.
399 * fns.c (concat): Likewise.
400 * frame.c (x_set_frame_parameters): Likewise.
401 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
402 0 if not found, not -1. All callers changed.
403
dd3f25f7
PE
404 * alloc.c (garbage_collect): Don't assume stack size fits in int.
405 (stack_copy_size): Now size_t, not int.
406 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
407
461c2ab9
JB
4082011-03-28 Juanma Barranquero <lekktu@gmail.com>
409
410 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
411 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
412 All callers changed.
413
414 * lisp.h (multibyte_char_to_unibyte):
415 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
416 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
417 * character.h (CHAR_TO_BYTE8):
418 * cmds.c (internal_self_insert):
419 * editfns.c (general_insert_function):
420 * keymap.c (push_key_description):
421 * search.c (Freplace_match):
422 * xdisp.c (message_dolog, set_message_1): All callers changed.
423
f6d62986
SM
4242011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
425
426 * keyboard.c (safe_run_hook_funcall): New function.
427 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
428 don't set the hook to nil, but remove the offending function instead.
429 (Qcommand_hook_internal): Remove, unused.
430 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
431 Vcommand_hook_internal.
432
433 * eval.c (enum run_hooks_condition): Remove.
434 (funcall_nil, funcall_not): New functions.
435 (run_hook_with_args): Call each function through a `funcall' argument.
436 Remove `cond' argument, now redundant.
437 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
438 (Frun_hook_with_args_until_failure): Adjust accordingly.
439 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
440
1db5b1ad
JB
4412011-03-28 Juanma Barranquero <lekktu@gmail.com>
442
443 * dispextern.h (string_buffer_position): Remove declaration.
444
445 * print.c (strout): Remove parameter `multibyte', unused since
446 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
447
448 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
449 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
450 All callers changed.
451
452 * w32.c (_wsa_errlist): Use braces for struct initializers.
453
454 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
455 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
456 All callers changed.
457 (string_buffer_position): Likewise. Also, make static (it's never
458 used outside xdisp.c).
459 (cursor_row_p): Remove parameter `w', unused since
460 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
461 (decode_mode_spec): Remove parameter `precision', introduced during
462 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
463 All callers changed.
464
5ffb62aa
JD
4652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
466
467 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
468
461c2ab9 4692011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
470
471 * nsterm.m (ns_menu_bar_is_hidden): New variable.
472 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
473 (ns_update_auto_hide_menu_bar): New functions.
474 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
475 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
476 ns_constrain_all_frames.
477 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
478 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
479
5c380ffb
JD
4802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
481
482 * nsmenu.m (runDialogAt): Remove argument to timer_check.
483
9af30bdf
GM
4842011-03-27 Glenn Morris <rgm@gnu.org>
485
486 * syssignal.h: Replace RETSIGTYPE with void.
487 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
488 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
489 Replace SIGTYPE with void everywhere.
490 * s/usg5-4-common.h (SIGTYPE): Remove definition.
491 * s/template.h (SIGTYPE): Remove commented out definition.
492
e2abce01
JB
4932011-03-26 Eli Zaretskii <eliz@gnu.org>
494
495 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
496 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
497
f868cd8a
JB
4982011-03-26 Juanma Barranquero <lekktu@gmail.com>
499
59eb0929
JB
500 * w32.c (read_unc_volume): Use parameter `henum', instead of
501 global variable `wget_enum_handle'.
502
503 * keymap.c (describe_vector): Remove parameters `indices' and
504 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
505 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
506
f868cd8a
JB
507 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
508
509 * keyboard.c (timer_check): Remove parameter `do_it_now',
510 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
511 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
512 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
513
514 * keyboard.c (read_char):
515 * w32menu.c (w32_menu_display_help):
516 * xmenu.c (show_help_event, menu_help_callback):
517 Adjust calls to `show_help_echo'.
518
519 * gtkutil.c (xg_maybe_add_timer):
520 * keyboard.c (readable_events):
521 * process.c (wait_reading_process_output):
522 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
523
524 * insdel.c (adjust_markers_gap_motion):
525 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
526 (gap_left, gap_right): Don't call it.
527
2ecf6fdb
CY
5282011-03-25 Chong Yidong <cyd@stupidchicken.com>
529
530 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
531 incurred during fontification.
532
6b1f9ba4
JB
5332011-03-25 Juanma Barranquero <lekktu@gmail.com>
534
535 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
536 (DEFVAR_PER_BUFFER): Don't pass it.
537
538 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
539 (scrolling_window): Don't pass it.
540
0f4a96b5
JB
5412011-03-25 Juanma Barranquero <lekktu@gmail.com>
542
543 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
544
545 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
546 and `suffix'.
547 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
548 of variables specific to SELinux and computation of `encoded_absname'.
549
550 * image.c (XPutPixel): Remove unused variable `height'.
551
552 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
553
554 * unexw32.c (get_section_info): Remove unused variable `section'.
555
556 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
557 (system_process_attributes): Remove unused variable `sess'.
558 (sys_read): Remove unused variable `err'.
559
560 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
561 (w32_wnd_proc): Remove unused variable `isdead'.
562 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
563 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
564 (x_create_tip_frame): Remove unused variable `tem'.
565
566 * w32inevt.c (w32_console_read_socket):
567 Remove unused variable `no_events'.
568
569 * w32term.c (x_draw_composite_glyph_string_foreground):
570 Remove unused variable `width'.
571
1149507c
JB
5722011-03-24 Juanma Barranquero <lekktu@gmail.com>
573
574 * w32term.c (x_set_glyph_string_clipping):
575 Don't pass uninitialized region to CombineRgn.
576
9c88f339
JB
5772011-03-23 Juanma Barranquero <lekktu@gmail.com>
578
579 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
580 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
581 (Fx_close_connection): Remove unused variable `i'.
582
583 * w32font.c (w32font_draw): Return number of glyphs.
584 (w32font_open_internal): Remove unused variable `i'.
585 (w32font_driver): Add missing initializer.
586
587 * w32menu.c (utf8to16): Remove unused variable `utf16'.
588 (fill_in_menu): Remove unused variable `items_added'.
589
590 * w32term.c (last_mouse_press_frame): Remove static global variable.
591 (w32_clip_to_row): Remove unused variable `f'.
592 (x_delete_terminal): Remove unused variable `i'.
593
594 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
595 (NOTHING): Remove unused static global variable.
596 (uniscribe_check_otf): Remove unused variable `table'.
597 (uniscribe_font_driver): Add missing initializers.
598
dee091a3
JD
5992011-03-23 Julien Danjou <julien@danjou.info>
600
601 * term.c (Fsuspend_tty, Fresume_tty):
602 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
603 * window.c (temp_output_buffer_show):
604 * insdel.c (signal_before_change):
605 * frame.c (Fhandle_switch_frame):
606 * fileio.c (Fdo_auto_save):
607 * emacs.c (Fkill_emacs):
608 * editfns.c (save_excursion_restore):
609 * cmds.c (internal_self_insert):
610 * callint.c (Fcall_interactively):
611 * buffer.c (Fkill_all_local_variables):
612 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
613 Use Frun_hooks.
0f4a96b5 614 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
615 unconditionnaly since it does the check itself.
616
2c520ab5 6172011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 618
c9c49752
PE
619 Fix more problems found by GCC 4.5.2's static checks.
620
8abc3f12
PE
621 * coding.c (encode_coding_raw_text): Avoid unnecessary test
622 the first time through the loop, since we know p0 < p1 then.
623 This also avoids a gcc -Wstrict-overflow warning.
624
a2d26660
PE
625 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
626 leading to a memory leak, possible in functions like
627 load_charset_map_from_file that can allocate an unbounded number
b12ef411 628 of objects (Bug#8318).
a2d26660 629
916c72e9
PE
630 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
631 that could (at least in theory) be that large.
632
19ab8a18
PE
633 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
634 This is less likely to overflow, and avoids undefined behavior if
635 overflow does occur. All callers changed. Use strtoul to scan
636 for the unsigned long integer.
b7cbbd6f
PE
637 (pint2hrstr): Simplify and tune code slightly.
638 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 639
f0641eff
PE
640 * scroll.c (do_scrolling): Work around GCC bug 48228.
641 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
642
7f650bb9
PE
643 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
644 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
645 (validate_x_resource_name): Simplify count usage.
646 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 647
37dd57d1
PE
648 * fileio.c (Fcopy_file): Report error if fchown or fchmod
649 fail (Bug#8306).
81e56e61 650
699979fc 651 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 652
401bf9b4
PE
653 * process.c (Fmake_network_process): Use socklen_t, not int,
654 where POSIX says socklen_t is required in portable programs.
655 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 656 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
657 (Fmake_network_process, server_accept_connection):
658 (wait_reading_process_output, read_process_output):
659 Likewise.
660
b93aacde
PE
661 * process.c: Rename or move locals to avoid shadowing.
662 (list_processes_1, Fmake_network_process):
663 (read_process_output_error_handler, exec_sentinel_error_handler):
664 Rename or move locals.
4dc343ee 665 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 666 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 667 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 668 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 669 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 670
af8a867c 671 Make tparam.h and terminfo.c consistent.
44f230aa
SM
672 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
673 Include tparam.h instead, since it declares them.
af8a867c
PE
674 * cm.h (PC): Remove extern decl; tparam.h now does this.
675 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
676 * terminfo.c: Include tparam.h, to check interfaces.
677 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
678 (tparam): Adjust signature to match interface in tparam.h;
679 this removes some undefined behavior. Check that outstring and len
680 are zero, which they always are with Emacs.
681 * tparam.h (PC, BC, UP): New extern decls.
682
0248044d 683 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 684 (xftfont_open): Rename locals to avoid shadowing.
0248044d 685
8ff096c1 686 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
687 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
688 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 689 (ftfont_list): Remove unused local.
49eaafba
PE
690 (get_adstyle_property, ftfont_pattern_entity):
691 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
692 Rename locals to avoid shadowing.
8ff096c1 693
e2be39f6
PE
694 * xfont.c (xfont_list_family): Mark var as initialized.
695
c9735e30
PE
696 * xml.c (make_dom): Now static.
697
8f5201ae
PE
698 * composite.c (composition_compute_stop_pos): Rename local to
699 avoid shadowing.
b246f932
PE
700 (composition_reseat_it): Remove unused locals.
701 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 702 (composition_update_it): Mark var as initialized.
11b61122
PE
703 (find_automatic_composition): Mark vars as initialized,
704 with a FIXME (Bug#8290).
8f5201ae 705
760fbc2c
PE
706 character.h: Rename locals to avoid shadowing.
707 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
708 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
709 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
710 (BUF_DEC_POS): Be more systematic about renaming local temporaries
711 to avoid shadowing.
712
ff08eb85
PE
713 * textprop.c (property_change_between_p): Remove; unused.
714
fc7bf025
PE
715 * intervals.c (interval_start_pos): Now static.
716
235d7abc
PE
717 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
718
44f230aa
SM
719 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
720 Rename locals to avoid shadowing.
3e7d6594 721
50060332
PE
722 * sound.c (wav_play, au_play, Fplay_sound_internal):
723 Fix pointer signedness.
d01f234b 724 (alsa_choose_format): Remove unused local var.
c83b8872
PE
725 (wav_play): Initialize a variable to 0, to prevent undefined
726 behavior (Bug#8278).
50060332 727
c4fc4e30
PE
728 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
729
918436ed
PE
730 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
731
c939f91b
PE
732 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
733 clobbering (Bug#8298).
b9c7f648
PE
734 * sysdep.c (sys_subshell): Likewise.
735 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 736
6bd8c144
PE
737 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
738 This should get cleaned up, so that child_setup has the
739 same signature on all platforms.
740
7710357c 741 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 742 (relocate_fd): Rename locals to avoid shadowing.
7710357c 743
c59da222
CY
7442011-03-22 Chong Yidong <cyd@stupidchicken.com>
745
746 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
747 not to be necessary, and produces flickering.
748
66b87493
GM
7492011-03-20 Glenn Morris <rgm@gnu.org>
750
751 * config.in: Remove file.
752
45b6f6d5
JB
7532011-03-20 Juanma Barranquero <lekktu@gmail.com>
754
755 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
756 are now in src/globals.h.
757 (syms_of_minibuf): Remove spurious & from previous change.
758
3ec03f7e
LL
7592011-03-20 Leo <sdl.web@gmail.com>
760
761 * minibuf.c (completing-read-function): New variable.
762 (completing-read-default): Rename from completing-read.
763 (completing-read): Call completing-read-function.
764
b14e3e21
CY
7652011-03-19 Juanma Barranquero <lekktu@gmail.com>
766
767 * xfaces.c (Fx_load_color_file):
768 Read color file from absolute filename (bug#8250).
769
f2b726e6
JB
7702011-03-19 Juanma Barranquero <lekktu@gmail.com>
771
772 * makefile.w32-in: Update dependencies.
773
09f6ff02
EZ
7742011-03-17 Eli Zaretskii <eliz@gnu.org>
775
776 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
777
29a6015a
PE
7782011-03-17 Paul Eggert <eggert@cs.ucla.edu>
779
a3a6c54e
PE
780 Fix more problems found by GCC 4.5.2's static checks.
781
b766f867
PE
782 * process.c (make_serial_process_unwind, send_process_trap):
783 (sigchld_handler): Now static.
784
be02381c
PE
785 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
786 That way, the code declares only the vars that it needs.
787 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
788 * s/cygwin.h (PTY_ITERATION): Likewise.
789 * s/darwin.h (PTY_ITERATION): Likewise.
790 * s/gnu-linux.h (PTY_ITERATION): Likewise.
791
57048744
PE
792 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
793 * process.c (allocate_pty): Don't declare stb unless it's needed.
794
7914961c 795 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
796 (CONSTANTLIM): Remove; unused.
797 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
798 Define only if needed.
7914961c 799
b3967b18
PE
800 * unexelf.c (unexec): Name an expression,
801 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
802 Use a different way to cause a compilation error if anyone uses
803 n rather than nn, a way that does not involve shadowing.
73366a00 804 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 805
29a6015a
PE
806 * deps.mk (unexalpha.o): Remove; unused.
807
43cfc33e 808 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 809 * unexec.h: New file.
ce701a33
PE
810 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
811 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
812 Depend on unexec.h.
813 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
814 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
815 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 816 Change as necessary to match prototype in unexec.h.
ce701a33 817
01f44d5a
PE
818 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
819 shadowing.
4f63c6bb 820 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 821
a6670b0b
PE
822 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
823 Rename locals to avoid shadowing.
824
cef2010d 825 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 826 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 827
d4d7173a
PE
828 * print.c (Fredirect_debugging_output): Fix pointer signedess.
829
f08b802a
PE
830 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
831 warning when compiling print.c.
832
3ddb0639
PE
833 * font.c (font_unparse_fcname): Abort in an "impossible" situation
834 instead of using an uninitialized var.
5ad03b97 835 (font_sort_entities): Mark var as initialized.
3ddb0639 836
170a2692
PE
837 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
838
e663c700
PE
839 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
840 pointers to constants.
89bc529a 841 (font_parse_fcname): Remove unused vars.
7b81e2d0 842 (font_delete_unmatched): Now static.
ea838e10 843 (font_get_spec): Remove; unused.
13a547c6
PE
844 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
845 (font_update_drivers, Ffont_get_glyphs, font_add_log):
846 Rename or move locals to avoid shadowing.
e663c700 847
2a80c887 848 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 849 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 850
1384fa33 851 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 852 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 853
8b2c52e9
PE
854 * alloc.c (mark_backtrace): Move decl from here ...
855 * lisp.h: ... to here, so that it can be checked.
856
475545b5 857 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 858 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
859 (lisp_indirect_variable): Name an expression,
860 to avoid gcc -Wbad-function-cast warning.
1faed8ae 861 (Fdefvar): Rename locals to avoid shadowing.
475545b5 862
b1349114 863 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 864 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 865 Use const pointer when appropriate.
b1349114 866
a2928364
PE
867 * lisp.h (get_system_name, get_operating_system_release):
868 Move decls here, to check interfaces.
869 * process.c (get_operating_system_release): Move decl to lisp.h.
870 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
871 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
872 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
873 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
874 (Fformat_time_string, Fencode_time, Finsert_char):
875 (Ftranslate_region_internal, Fformat):
876 Rename or remove local vars to avoid shadowing.
9710023e 877 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 878
a415e694
PE
879 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
880 avoid shadowing.
881
8ef4622d
PE
882 * lisp.h (eassert): Check that the argument compiles, even if
883 ENABLE_CHECKING is not defined.
884
946f9a5b
PE
885 * data.c (Findirect_variable): Name an expression, to avoid
886 gcc -Wbad-function-cast warning.
112396d6 887 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 888 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
889 (Fmake_variable_buffer_local, Fmake_local_variable):
890 Mark variables as initialized.
52746918 891 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 892
e5aab7e7 893 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
894 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
895 Rename locals to avoid shadowing.
dff45157
PE
896 (mark_stack): Move local variables into the #ifdef region where
897 they're used.
7bc26fdb
PE
898 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
899 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
900 needed otherwise.
901 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
902 (GC_STRING_CHARS): Remove; not used.
d40d4be1 903 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 904
e5aab7e7
PE
905 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
906 avoids undefined behavior in theory.
907
4da60324
PE
908 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
909
88043301
PE
910 Use functions, not macros, for up- and down-casing (Bug#8254).
911 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
912 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
913 to use the following functions instead of these macros.
914 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
915 EMACS_INT, since callers assume the returned value fits in int.
916 (upcase1): Likewise, for UPCASE_TABLE.
917 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 918 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 919 the race-condition problem in the old DOWNCASE.
88043301 920
19ed5445
PE
921 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
922 Rename locals to avoid shadowing.
923 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
924 (regex_compile, re_search_2, re_match_2_internal):
925 Remove unused local vars.
952db0d7
PE
926 (FREE_VAR): Rewrite so as not to use empty "else",
927 which gcc can warn about.
da053e48 928 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
929 (RETALLOC_IF): Define only if needed.
930 (WORDCHAR_P): Likewise. This one is never needed, but is used
931 only in a comment talking about a compiler bug, so put inside
932 the #if 0 of that comment.
933 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
934 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
935 Remove; unused.
19ed5445 936
1f3561e4 937 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
938 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
939 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 940
ded6f8f7
PE
941 * search.c (simple_search): Remove unused var.
942
dbd37a95
PE
943 * dired.c (compile_pattern): Move decl from here ...
944 * lisp.h: ... to here, so that it can be checked.
945 (struct re_registers): New forward decl.
946
7e47afad
PE
947 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
948
85f24f61
PE
949 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
950 All uses changed.
951 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
952 Rename locals to avoid shadowing.
5671df8f 953 (Fvertical_motion): Mark locals as initialized.
85f24f61 954
181aa2be 955 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 956 (casify_region): Mark local as initialized.
181aa2be 957
930d429c
PE
958 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
959
7082eac6
PE
960 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
961 New macros, so that the caller can use some names other than
962 gcpro1, gcpro2, etc.
963 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
964 of the new macros.
965 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
966 argument, for consistency with GCPRO2_VAR, etc: it is now the
967 prefix of the variable, not the variable itself. All uses
968 changed.
38b2c076
PE
969 * dired.c (directory_files_internal, file_name_completion):
970 Rename locals to avoid shadowing.
971
15206ed9
PE
972 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
973 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
974 dired.c's scmp function, had undefined behavior.
975 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
976 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
977 * buffer.h: ... to here, because these macros use current_buffer,
978 and the new implementation with inline functions needs to have
979 current_buffer in scope now, rather than later when the macros
980 are used.
981 (downcase, upcase1): New static inline functions.
982 (DOWNCASE, UPCASE1): Reimplement using these functions.
983 This avoids undefined behavior in expressions like
984 DOWNCASE (x) == DOWNCASE (y), which previously suffered
985 from race conditions in accessing the global variables
986 case_temp1 and case_temp2.
987 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
988 * lisp.h (case_temp1, case_temp2): Remove their decls.
989 * character.h (ASCII_CHAR_P): Move from here ...
990 * lisp.h: ... to here, so that the inline functions mentioned
991 above can use them.
992
4a6bea26
PE
993 * dired.c (directory_files_internal_unwind): Now static.
994
f14b7e14
PE
995 * fileio.c (file_name_as_directory, directory_file_name):
996 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
997 Now static.
2893f146
PE
998 (file_name_as_directory): Use const pointers when appropriate.
999 (Fexpand_file_name): Likewise. In particular, newdir might
1000 point at constant storage, so make it a const pointer.
fd4ead52 1001 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1002 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1003 signedness issues.
f839df0c
PE
1004 (Fset_file_times, Finsert_file_contents, auto_save_error):
1005 Rename locals to avoid shadowing.
f14b7e14 1006
5716756e 1007 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1008 (Ftry_completion, Fall_completions): Rename or remove locals
1009 to avoid shadowing.
5716756e 1010
b4c3046a
PE
1011 * marker.c (bytepos_to_charpos): Remove; unused.
1012
b45db522
PE
1013 * lisp.h (verify_bytepos, count_markers): New decls,
1014 so that gcc does not warn that these functions aren't declared.
1015
85876d07
PE
1016 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1017 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1018 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1019 (copy_text): Remove unused local var.
85876d07 1020
03d78a21 1021 * filelock.c (within_one_second): Now static.
b3dd38ab 1022 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1023
5df8f01b
PE
1024 * buffer.c (fix_overlays_before): Mark locals as initialized.
1025 (fix_start_end_in_overlays): Likewise. This function should be
1026 simplified by using pointers-to-pointers, but that's a different
1027 matter.
b1d876f1 1028 (switch_to_buffer_1): Now static.
8f54f30a
PE
1029 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1030 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1031
a70072c9 1032 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1033 Fix pointer signedness issue.
edced198
PE
1034 (sys_subshell): Mark local as volatile if checking for lint,
1035 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1036 (MAXPATHLEN): Define only if needed.
a70072c9 1037
a0977c44
PE
1038 * process.c (serial_open, serial_configure): Move decls from here ...
1039 * systty.h: ... to here, so that they can be checked.
1040
a884fdcc
PE
1041 * fns.c (get_random, seed_random): Move extern decls from here ...
1042 * lisp.h: ... to here, so that they can be checked.
1043
604efe86 1044 * sysdep.c (reset_io): Now static.
b8950c94 1045 (wait_for_termination_signal): Remove; unused.
604efe86 1046
38fc62d9
PE
1047 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1048 (copy_keymap_item, append_key, push_text_char_description):
1049 Now static.
1004a21a 1050 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1051 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1052 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1053 (describe_map_tree):
1054 Rename locals to avoid shadowing.
38fc62d9 1055
2f2650da
PE
1056 * keyboard.c: Declare functions static if they are not used elsewhere.
1057 (echo_char, echo_dash, cmd_error, top_level_2):
1058 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1059 (read_char, kbd_buffer_get_event, make_lispy_position):
1060 (make_lispy_event, make_lispy_movement, apply_modifiers):
1061 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1062 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1063 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1064 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1065 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1066
a053e86c 1067 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1068 (mark_kboards): Move decl here ...
1069 * alloc.c (mark_kboards): ... from here.
a053e86c 1070
4752793e
PE
1071 * lisp.h (force_auto_save_soon): New decl.
1072
74f10ca7 1073 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1074 (DEFINE_DUMMY_FUNCTION): New macro.
1075 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1076 Use it.
c03cd23f
PE
1077 (main): Add casts to avoid warnings
1078 if GCC considers string literals to be constants.
74f10ca7 1079
022e70d4
PE
1080 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1081
59d6fe83
PE
1082 * dbusbind.c: Pointer signedness fixes.
1083 (xd_signature, xd_append_arg, xd_initialize):
1084 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1085 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1086 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1087 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1088
78320123
PE
1089 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1090 if GCC considers string literals to be constants.
49cebcca 1091 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1092
35ac2a97
SM
10932011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1094
fb103ca9
SM
1095 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1096 (print_preprocess, print_object): New macro to fix last change.
1097
35ac2a97
SM
1098 * print.c (print_preprocess): Don't forget font objects.
1099
62973b41
JB
11002011-03-16 Juanma Barranquero <lekktu@gmail.com>
1101
1102 * emacs.c (USAGE3): Doc fixes.
1103
0e48bb22
AS
11042011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1105
1106 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1107 structure.
1108
7684e57b
JB
11092011-03-14 Juanma Barranquero <lekktu@gmail.com>
1110
1111 * lisp.h (VWindow_system, Qfile_name_history):
1112 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1113 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1114 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1115
1116 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1117 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1118
1119 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1120 * w32console.c (detect_input_pending, read_input_pending)
1121 (encode_terminal_code):
1122 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1123 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1124 (w32_system_caret_y, Qfile_name_history):
1125 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1126 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1127 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1128 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1129 * w32proc.c (Qlocal, report_file_error):
1130 * w32term.c (Vwindow_system, updating_frame):
1131 * w32uniscribe.c (initialized, uniscribe_font_driver):
1132 Remove unneeded extern declarations.
1133
2aa46d6c
CY
11342011-03-14 Chong Yidong <cyd@stupidchicken.com>
1135
c96bbc66 1136 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1137
cffc6f3b
CY
11382011-03-13 Chong Yidong <cyd@stupidchicken.com>
1139
1140 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1141 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1142 These macros can no longer be used for assignment.
1143
44f230aa
SM
1144 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1145 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1146 (record_buffer_markers, fetch_buffer_markers): New functions for
1147 recording and fetching special buffer markers.
1148 (set_buffer_internal_1, set_buffer_temp): Use them.
1149
1150 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1151
1152 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1153
1154 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1155 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1156
1157 * xdisp.c (hscroll_window_tree):
1158 (reconsider_clip_changes): Use PT instead of BUF_PT.
1159
d251f04b
EZ
11602011-03-13 Eli Zaretskii <eliz@gnu.org>
1161
1162 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1163 $(EMACS_ROOT)/lib/intprops.h.
1164
f0c77cd1
PE
11652011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1166
3eca4629
PE
1167 Fix more problems found by GCC 4.5.2's static checks.
1168
7c86ee98
PE
1169 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1170 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1171 (xg_free_frame_widgets): Make it clear that a local variable is
1172 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1173 (gdk_window_get_screen): Make it clear that this macro is needed
1174 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1175 (int_gtk_range_get_value): New function, which avoids a diagnostic
1176 from gcc -Wbad-function-cast.
1177 (xg_set_toolkit_scroll_bar_thumb): Use it.
1178 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1179 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1180 (get_utf8_string, xg_get_file_with_chooser):
1181 Rename locals to avoid shadowing.
1182 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1183
41729b81
PE
1184 * xgselect.c (xg_select): Remove unused var.
1185
f0c77cd1
PE
1186 * image.c (four_corners_best): Mark locals as initialized.
1187 (gif_load): Initialize transparent_p to zero (Bug#8238).
1188 Mark another local as initialized.
ec6cf4c6 1189 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1190
ce0ad53d 1191 * image.c (clear_image_cache): Now static.
d5d5a617 1192 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1193 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1194 (x_edge_detection): Remove unnecessary cast that
1195 gcc -Wbad-function-cast diagnoses.
2037898d 1196 (gif_load): Fix pointer signedness.
6ae141d6
PE
1197 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1198 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1199
33383987 12002011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1201
d32df629
PE
1202 Improve quality of tests for time stamp overflow.
1203 For example, without this patch (encode-time 0 0 0 1 1
1204 1152921504606846976) returns the obviously-bogus value (-948597
1205 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1206 reports time overflow. See
1207 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1208 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1209 * editfns.c: Include limits.h and intprops.h.
1210 (TIME_T_MIN, TIME_T_MAX): New macros.
1211 (time_overflow): Move earlier, to before first use.
1212 (hi_time, lo_time): New functions, for an accurate test for
1213 out-of-range times.
1214 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1215 (Fget_internal_run_time): Don't assume time_t fits in int.
1216 (make_time): Use list2 instead of Fcons twice.
1217 (Fdecode_time): More accurate test for out-of-range times.
1218 (check_tm_member): New function.
1219 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1220 (lisp_time_argument): Don't rely on undefined left-shift and
1221 right-shift behavior when checking for time stamp overflow.
8be6f318 1222
fe31d94c
PE
1223 * editfns.c (time_overflow): New function, refactoring common code.
1224 (Fformat_time_string, Fdecode_time, Fencode_time):
1225 (Fcurrent_time_string): Use it.
1226
8be6f318
PE
1227 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1228 * dired.c (make_time): Move to ...
1229 * editfns.c (make_time): ... here.
1230 * systime.h: Note the move.
1231
09d9db2c 12322011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1233
126bc0dc
YM
1234 * fringe.c (update_window_fringes): Remove unused variables.
1235
c47cbdfd
YM
1236 * unexmacosx.c (copy_data_segment): Also copy __got section.
1237 (Bug#8223)
1238
7ac80be9
EZ
12392011-03-12 Eli Zaretskii <eliz@gnu.org>
1240
c96bbc66 1241 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1242 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1243 Constify `char *' arguments and their references according to
1244 prototypes in tparam.h.
1245
ecb0f94d 1246 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1247
7ac80be9
EZ
1248 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1249 Adapt all references accordingly.
1250
1251 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1252
ef1fd07e
TT
12532011-03-11 Tom Tromey <tromey@redhat.com>
1254
1255 * buffer.c (syms_of_buffer): Remove obsolete comment.
1256
7ef4b50c
EZ
12572011-03-11 Eli Zaretskii <eliz@gnu.org>
1258
1259 * termhooks.h (encode_terminal_code): Declare prototype.
1260
1261 * msdos.c (encode_terminal_code): Don't declare prototype.
1262
1263 * term.c (encode_terminal_code): Now external again, used by
1264 w32console.c and msdos.c.
1265
44f230aa
SM
1266 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1267 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1268
4b1ec863 12692011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1270
1714f52b 1271 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1272
4b1ec863
PE
1273 * fringe.c (update_window_fringes): Mark locals as initialized
1274 (Bug#8227).
1275 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1276
524c7aa6
PE
1277 * alloc.c (mark_fringe_data): Move decl from here ...
1278 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1279 to check its interface.
1280 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1281
a5c0af81 1282 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1283 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1284 (fontset_font): Mark local as initialized.
a9a06e0b 1285 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1286
b4716021
PE
1287 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1288
811e9bac 1289 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1290 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1291 (x_own_selection, Fx_disown_selection_internal): Rename locals
1292 to avoid shadowing.
1293 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1294
7e3ab302
PE
1295 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1296 so that the caller can use some name other than gcpro1.
1297 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1298 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1299 (Fx_backspace_delete_keys_p):
1300 Use them to avoid shadowing, and rename vars to avoid shadowing.
1301 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1302 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1303 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1304 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1305 Remove unused locals.
7e3ab302
PE
1306 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1307 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1308 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1309 macros.
f78faa98 1310
e2b13473
PE
1311 * xterm.h (x_mouse_leave): New decl.
1312
77f23912
PE
1313 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1314 Remove unused functions.
cdf4ba58
PE
1315 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1316 (x_calc_absolute_position): Now static.
7411c686 1317 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1318 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1319 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1320 unless they are used.
38d0b34a
PE
1321 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1322 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1323 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1324 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1325 (x_error_catcher, x_connection_closed, x_error_handler):
1326 (x_error_quitter, xembed_send_message, x_iconify_frame):
1327 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1328 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1329 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1330
44f230aa
SM
1331 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1332 Rename or move locals to avoid shadowing.
6b463e58 1333 (tty_defined_color, merge_face_heights): Now static.
5967d051 1334 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1335 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1336 does not deduce is never used uninitialized.
73719eba
PE
1337 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1338 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1339
426994c3 1340 * terminal.c (store_terminal_param): Now static.
5489860b 1341
032f1620 1342 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1343 (set_frame_menubar): Remove unused local.
d4323972 1344 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1345 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1346 since they might point to immutable storage.
281585b0
PE
1347 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1348 since it's unused otherwise.
032f1620 1349
367c19e5 1350 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1351 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1352 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1353 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1354 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1355 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1356 does not deduce are never used uninitialized.
70739cbe 1357
07b48fa9
PE
1358 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1359
8868a238 1360 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1361 * window.c (window_loop, size_window):
1362 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1363
7e5cf297 1364 * window.c (display_buffer): Now static.
d6550a9f
PE
1365 (size_window): Mark variables that gcc -Wuninitialized
1366 does not deduce are never used uninitialized.
a586633d
PE
1367 * window.h (check_all_windows): New decl, to forestall
1368 gcc -Wmissing-prototypes diagnostic.
5b555da1 1369 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1370
f6095868
PE
1371 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1372 shadowing.
1373 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1374 Include <limits.h>.
1375 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1376 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1377 (load_charset_map): Mark variables that gcc -Wuninitialized
1378 does not deduce are never used uninitialized.
53df7c11 1379 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1380
f38b440c
PE
1381 * coding.c (coding_set_source, coding_set_destination):
1382 Use "else { /* comment */ }" rather than "else /* comment */;"
1383 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1384 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1385 a block, when the outer 'i' will do.
1386 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1387 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1388 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1389 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1390 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1391 Rename locals to avoid shadowing.
1392 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1393 * coding.c (emacs_mule_char, encode_invocation_designation):
1394 Now static, since they're not used elsewhere.
413bb2db 1395 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1396 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1397 (decode_coding_emacs_mule): Mark variables that gcc
1398 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1399 (detect_coding_iso_2022): Initialize a local variable that might
1400 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1401 this initialization is needed. (Bug#8211)
5f58e762
PE
1402 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1403 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1404 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1405 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1406 Remove unused macros.
f38b440c 1407
232b38b9 1408 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1409 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1410 * character.c (string_count_byte8): Likewise.
232b38b9 1411
fb90da1b
PE
1412 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1413 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1414
fb93dbc2
PE
1415 * chartab.c (copy_sub_char_table): Now static, since it's not used
1416 elsewhere.
5c156ace
PE
1417 (sub_char_table_ref_and_range, char_table_ref_and_range):
1418 Rename locals to avoid shadowing.
bbcd0949 1419 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1420
7d3b3862 1421 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1422 (BIDI_BOB): Remove unused macro.
7d3b3862 1423
6be7d3da
PE
1424 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1425 deduce are never used uninitialized.
c2ed9c8b 1426 * term.c (encode_terminal_code): Likewise.
6be7d3da 1427
75f8807f 1428 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1429
50938595
PE
1430 * tparam.h: New file.
1431 * term.c, tparam.h: Include it.
1432 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1433 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1434 Move these decls to tparam.h, and make them agree with what
1435 is actually in tparam.c. The previous trick of using incompatible
1436 decls in different modules does not conform to the C standard.
1437 All callers of tparam changed to use tparam's actual API.
1438 * tparam.c (tparam1, tparam, tgoto):
1439 Use const pointers where appropriate.
1440
fbceeba2
PE
1441 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1442 * cm.h (struct cm): Likewise.
1443 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1444 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1445 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1446 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1447 (turn_on_face, init_tty): Likewise.
1448 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 1449
7f3f1250
PE
1450 * term.c (term_mouse_position): Rename local to avoid shadowing.
1451
e6ca6543
PE
1452 * alloc.c (mark_ttys): Move decl from here ...
1453 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1454
c40f8d15
AS
14552011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1456
1457 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1458
cfe0661d
JB
14592011-03-09 Juanma Barranquero <lekktu@gmail.com>
1460
1461 * search.c (compile_pattern_1): Remove argument regp, unused since
1462 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1463 (compile_pattern): Don't pass it.
1464
0afb4571
J
14652011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1466
1467 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1468 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1469 for ! HAVE_GTK3.
1470 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1471
1472 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1473
1474 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1475 gdk_window_get_screen, gdk_window_get_geometry,
1476 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1477 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1478 (xg_get_pixbuf_from_pixmap): New function.
1479 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1480 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1481 Call xg_get_pixbuf_from_pixmap instead of
1482 gdk_pixbuf_get_from_drawable.
1483 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1484 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1485 (xg_check_special_colors): Use GtkStyleContext and its functions
1486 for HAVE_GTK3.
1487 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1488 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1489 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
1490 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1491 Call gtk_widget_get_preferred_size.
0afb4571
J
1492 (xg_frame_resized): gdk_window_get_geometry only takes 5
1493 parameters.
44f230aa
SM
1494 (xg_win_to_widget, xg_event_is_for_menubar):
1495 Call gdk_x11_window_lookup_for_display.
0afb4571
J
1496 (xg_set_widget_bg): New function.
1497 (delete_cb): New function.
1498 (xg_create_frame_widgets): connect delete-event to delete_cb.
1499 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1500 (xg_set_background_color): Call xg_set_widget_bg.
1501 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1502 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1503 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1504 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1505 if ! HAVE_GTK3.
1506 (update_frame_tool_bar): Call gtk_widget_hide.
1507 (xg_initialize): Use GDK_KEY_g.
1508
1509 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1510 if ! HAVE_GTK3
1511 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1512
1513 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1514 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1515 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1516
1c2cc4ef
JB
15172011-03-08 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * w32xfns.c (select_palette): Check success of RealizePalette against
1520 GDI_ERROR, not zero.
1521
33383987 1522See ChangeLog.11 for earlier changes.
aac0c6e3
MR
1523
1524;; Local Variables:
1525;; coding: utf-8
aac0c6e3
MR
1526;; End:
1527
33383987 1528 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
1529
1530 This file is part of GNU Emacs.
1531
1532 GNU Emacs is free software: you can redistribute it and/or modify
1533 it under the terms of the GNU General Public License as published by
1534 the Free Software Foundation, either version 3 of the License, or
1535 (at your option) any later version.
1536
1537 GNU Emacs is distributed in the hope that it will be useful,
1538 but WITHOUT ANY WARRANTY; without even the implied warranty of
1539 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1540 GNU General Public License for more details.
1541
1542 You should have received a copy of the GNU General Public License
1543 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.