Fix format bug in defstruct
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0c95fcf7
EZ
12011-08-25 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4 the display spec is of the form `(space ...)'.
5 (handle_display_spec): Return the value returned by
6 handle_single_display_spec, not just 1 or zero.
7 (handle_single_display_spec): If the display spec is of the form
8 `(space ...)', and specifies display in the text area, return 2
9 rather than 1.
fee65a97 10 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
11 accurately, and prefer exact match for point under bidi. Don't
12 advance `row' beyond the last row of the window.
0c95fcf7
EZ
13
14 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
15 into disp_prop; all users changed.
16
17 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
18 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
19 for the text covered by the display property.
20
e4ed06f1
CY
212011-08-25 Chong Yidong <cyd@stupidchicken.com>
22
23 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
24 Change return value to nil.
25 (Frecord_buffer): Delete unused function.
26
f67cdd7f
EZ
272011-08-24 Eli Zaretskii <eliz@gnu.org>
28
5980d4c6
EZ
29 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
30 buffers, return left-to-right.
8610fe8b
EZ
31 (set_cursor_from_row): Consider candidate row a win if its glyph
32 represents a newline and point is on that newline. Fixes cursor
33 positioning on the newline at EOL of R2L text within L2R
34 paragraph, and vice versa.
35 (try_cursor_movement): Check continued rows, in addition to
36 continuation rows. Fixes unwarranted scroll when point enters a
37 continued line of R2L text within an L2R paragraph, or vice versa.
38 (cursor_row_p): Consider the case of point being equal to
39 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
40 from the end of a short line to the beginning of a continued line
41 of R2L text within L2R paragraph.
42 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
43 composed characters.
5980d4c6 44
f67cdd7f
EZ
45 * bidi.c (bidi_check_type): Use xassert.
46 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
47 members.
48
bca633fb
EZ
492011-08-23 Eli Zaretskii <eliz@gnu.org>
50
51 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
52 a character.
53
4a5885a7
CY
542011-08-23 Chong Yidong <cyd@stupidchicken.com>
55
56 * nsfont.m (ns_otf_to_script): Fix typo.
57
0902a04e
KH
582011-08-22 Kenichi Handa <handa@m17n.org>
59
60 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
61 extra slot even if the purpose is char-code-property-table.
62
1a2e6670
EZ
632011-08-23 Eli Zaretskii <eliz@gnu.org>
64
8ddde651
EZ
65 * xdisp.c (redisplay_window): When computing centering_position,
66 account for the height of the header line. (Bug#8874)
67
425cc014
EZ
68 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
69 instead of CHAR_TO_BYTE. Fixes a crash when a completion
70 candidate is selected by the mouse, and that candidate has a
71 composed character under the mouse.
72
1a2e6670
EZ
73 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
74 coordinates reported by pos-visible-in-window-p for a composed
75 character in column zero.
76
8b76d6f8
SM
772011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
78
79 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
80
dac347dd
EZ
812011-08-22 Eli Zaretskii <eliz@gnu.org>
82
83 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
84 consider it a hit if to_charpos is anywhere in the range of the
85 composed buffer positions.
86
e013fb34
CY
872011-08-22 Chong Yidong <cyd@stupidchicken.com>
88
89 * image.c (gif_load): Don't assume that each subimage has the same
90 dimensions as the base image. Handle disposal method that is
91 "undefined" by the gif spec (Bug#9335).
92
bd1ba3e8
CY
932011-08-20 Chong Yidong <cyd@stupidchicken.com>
94
95 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 96 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 97
54a1215b
EZ
982011-08-19 Eli Zaretskii <eliz@gnu.org>
99
823564e5
EZ
100 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
101 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
102 from an Org mode buffer to a Speedbar frame.
103
54a1215b
EZ
104 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
105 a composition, take its buffer position from IT->cmp_it.charpos.
106 Fixes cursor positioning at the beginning of a line that begins
107 with a composed character.
108
9778ebcc
EZ
1092011-08-18 Eli Zaretskii <eliz@gnu.org>
110
0be6ee06
EZ
111 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
112 character bidirectional type, use STRONG_L instead. Fixes crashes
113 in a buffer produced by `describe-categories'.
114
9778ebcc
EZ
115 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
116 members before the level stack, so they would be saved and
117 restored when copying iterator state. Fixes incorrect reordering
118 around TABs covered by display properties.
119
156bffbe
AS
1202011-08-18 Andreas Schwab <schwab@linux-m68k.org>
121
122 * process.c (Fnetwork_interface_list): Correctly determine buffer
123 size.
124
72ad093b
CY
1252011-08-17 Chong Yidong <cyd@stupidchicken.com>
126
127 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
128 (internal_condition_case_2, internal_condition_case_n):
129 Remove unnecessary aborts (Bug#9081).
72ad093b 130
35774242
EZ
1312011-08-17 Eli Zaretskii <eliz@gnu.org>
132
133 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
134 has no `load' handler, try opening the file locally. (Bug#9311)
135
db76dd85
KB
1362011-08-16 Ken Brown <kbrown@cornell.edu>
137
138 * gmalloc.c: Expand comment.
139
b215eee5
EZ
1402011-08-16 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
143 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
144
a4579d33
KB
1452011-08-16 Ken Brown <kbrown@cornell.edu>
146
147 Fix memory allocation problems in Cygwin build (Bug#9273).
148
149 * unexcw.c ( __malloc_initialized): Declare external variable.
150 (fixup_executable): Force the dumped emacs to reinitialize malloc.
151
8b76d6f8
SM
152 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
153 New variables.
a4579d33
KB
154 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
155 dumped emacs.
156 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
157 in the static heap.
158 [CYGWIN] (special_realloc): New function.
159 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
160 requests to realloc storage in the static heap.
161
3ebec551
PE
1622011-08-15 Paul Eggert <eggert@cs.ucla.edu>
163
164 * bidi.c (bidi_initialize): Remove unused local.
165
9fd8be00
EZ
1662011-08-15 Eli Zaretskii <eliz@gnu.org>
167
474a8465
EZ
168 * biditype.h: File removed.
169
170 * bidimirror.h: File removed.
171
172 * deps.mk (bidi.o): Remove biditype.h and
173 bidimirror.h.
174
175 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
176 bidimirror.h.
177
178 * dispextern.h: Fix a typo in the comment to bidi_type_t.
179
180 * chartab.c: Improve commentary for the uniprop_table API.
181
32413314
EZ
182 * bidi.c (bidi_paragraph_init): Support zero value of
183 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
184 (bidi_initialize): Use uniprop_table instead of including
185 biditype.h and bidimirror.h.
32413314 186
9fd8be00
EZ
187 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
188 coordinates of the iterator when restoring from ppos_it.
189 (Bug#9296)
190
5cf2b69b
KH
1912011-08-14 Kenichi Handa <handa@m17n.org>
192
193 * process.c (create_process): Call setup_process_coding_systems
72ad093b 194 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 195
daf17d00
EZ
1962011-08-14 Eli Zaretskii <eliz@gnu.org>
197
198 * xdisp.c (move_it_in_display_line_to): Don't invoke
199 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
200 ppos_it. Fixes vertical cursor motion when line beginning is
201 covered by an image. (Bug#9296)
202
08e3161a
JD
2032011-08-14 Jan Djärv <jan.h.d@swipnet.se>
204
205 * nsterm.h (ns_run_ascript): Declare.
206 (NSAPP_DATA2_RUNASSCRIPT): Define.
207
208 * nsfns.m (as_script, as_result, as_status): New static variables.
209 (ns_run_ascript): New function.
210 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
211 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
212 the event loop. Get status from as_status (Bug#7276).
213
214 * nsterm.m (sendEvent): If event is NSApplicationDefined and
215 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
216 the event loop (Bug#7276).
217
a3720aa2
AS
2182011-08-14 Andreas Schwab <schwab@linux-m68k.org>
219
220 * gnutls.c (QCgnutls_bootprop_priority)
221 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
222 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
223 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
224 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
225 (QCgnutls_bootprop_verify_hostname_error)
226 (QCgnutls_bootprop_callbacks_verify): Rename from
227 Qgnutls_bootprop_..., all uses changed.
228
229 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
230 uses changed.
231
0a0d27fb
PE
2322011-08-14 Paul Eggert <eggert@cs.ucla.edu>
233
19d5c50c
PE
234 * xfaces.c (Qframe_set_background_mode): Now static.
235 * dispextern.h (Qframe_set_background_mode): Remove decl.
236
0a0d27fb
PE
237 * process.c (Fnetwork_interface_info): Declare local only if needed.
238
377538cb
JD
2392011-08-13 Jan Djärv <jan.h.d@swipnet.se>
240
241 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
242 (Fnetwork_interface_list): Allocate in increments of bytes instead
243 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
244 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
245 sockaddr.
246 (struct ifflag_def): notrailers is smart on OSX.
247 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
248 Get hardware address with getifaddrs if available.
249
08fff70c
EZ
2502011-08-12 Eli Zaretskii <eliz@gnu.org>
251
252 * xdisp.c (iterate_out_of_display_property): xassert that
253 IT->position is set to within IT->object's boundaries. Break from
254 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
255 when IT->position is set up wrongly due to some bug.
256 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
257 (push_display_prop): Allow GET_FROM_STRING as IT->method on
258 entry. Force push_it to save on the stack the current
259 buffer/string position, to be restored by pop_it. Fix flags in
260 the iterator structure wrt the object coming from a display
261 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
262 properties. (Bug#9284)
263
7be1c708 2642011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 265
7be1c708
CY
266 * fontset.c (fontset_get_font_group): Add proper type checks.
267 (Bug#9172)
aac0c6e3 268
7be1c708 2692011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 270
7be1c708
CY
271 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
272 and LC_VERSION_MIN_MACOSX.
273 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
274 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 275
97bb72a6
EZ
2762011-08-08 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
279 no-display-properties-and-no-overlays under bidi display.
280 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 281 properties and overlays.
97bb72a6 282
d5617611
CY
2832011-08-08 Chong Yidong <cyd@stupidchicken.com>
284
37e11a63
CY
285 * editfns.c (Fset_time_zone_rule): Document relationship with the
286 setenv function.
287
d5617611
CY
288 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
289 the font entity extracted from the cache (Bug#8109).
290
58872834
CY
2912011-08-07 Chong Yidong <cyd@stupidchicken.com>
292
293 * composite.c (autocmp_chars): Don't reset point. That is done by
294 restore_point_unwind (Bug#5984).
295
75bfc667
JL
2962011-08-07 Juri Linkov <juri@jurta.org>
297
298 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
299 to show the arg `TIME' instead of `TIMEVAL'.
300
d1410150
EZ
3012011-08-06 Eli Zaretskii <eliz@gnu.org>
302
303 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
304 display property strides EOL and includes a newline, as in
305 longlines-mode. (Bug#9254)
75b771e4
EZ
306 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
307 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
308
309 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
310 is non-zero, even if the data buffer is NULL. Fixes a crash in
311 vertical-motion with longlines-mode. (Bug#9254)
312
35928349
EZ
3132011-08-05 Eli Zaretskii <eliz@gnu.org>
314
ec7cc85b
EZ
315 * bidi.c <bidi_cache_total_alloc>: Now static.
316 (bidi_initialize): Initialize bidi_cache_total_alloc.
317
8b76d6f8 318 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
319 cache. (Bug#9221)
320
321 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
322 amount allocated this far in `bidi_cache_total_alloc'.
323 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
324 non-zero, only free the data buffer without restoring the cache
325 contents. All callers changed.
326
327 * dispextern.h (bidi_unshelve_cache): Update prototype.
328
329 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
330 (move_it_in_display_line, move_it_to)
331 (move_it_vertically_backward, move_it_by_lines): Replace the call
332 to xfree to an equivalent call to bidi_unshelve_cache.
333 (move_it_in_display_line_to): Fix logic of returning
412b6358 334 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 335
e2e2423b
EZ
3362011-08-05 Eli Zaretskii <eliz@gnu.org>
337
338 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
339 came from a string character with a `cursor' property. (Bug#9229)
340
ae9e757a
JD
3412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
342
343 * Makefile.in (LIB_PTHREAD): New variable.
344 (LIBES): Add LIB_PTHREAD (Bug#9216).
345
346 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
347 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
348
213bd7f2
AS
3492011-08-04 Andreas Schwab <schwab@linux-m68k.org>
350
351 * regex.c (re_iswctype): Remove some redundant boolean
352 conversions.
353
99aaf75f
JD
3542011-08-04 Jan Djärv <jan.h.d@swipnet.se>
355
356 * xterm.c (x_find_topmost_parent): New function.
357 (x_set_frame_alpha): Find topmost parent window with
358 x_find_topmost_parent and set the property there also (bug#9181).
359 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
360
c74e9d86
PE
3612011-08-04 Paul Eggert <eggert@cs.ucla.edu>
362
363 * callproc.c (Fcall_process): Avoid vfork clobbering
364 the local vars buffer, coding_systems, current_dir.
365
640c8776
SM
3662011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 * keymap.c (Fmake_composed_keymap): Move to subr.el.
369
f26d0e4c
PE
3702011-08-03 Paul Eggert <eggert@cs.ucla.edu>
371
8a10d76c
PE
372 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
373 so that it is not optimized away.
374
f26d0e4c
PE
375 * xdisp.c (compute_display_string_pos): Remove unused local.
376
55439c61
EZ
3772011-08-02 Eli Zaretskii <eliz@gnu.org>
378
379 Fix slow cursor motion and scrolling in large buffers with
380 selective display, like Org Mode buffers. (Bug#9218)
381
382 * dispextern.h (struct bidi_it): New member disp_prop_p.
383
384 * xdisp.c: Remove one-slot cache of display string positions.
385 (compute_display_string_pos): Accept an additional argument
386 DISP_PROP_P; callers changed. Scan at most 5K characters forward
387 for a display string or property. If found, set DISP_PROP_P
388 non-zero.
389
390 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
391 DISP_PROP_P, and pass it to compute_display_string_pos.
392 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
393 non-zero. All callers of bidi_fetch_char changed.
394
fb33fa43
SM
3952011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
396
397 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
398
b099e063
DM
3992010-12-03 Don March <don@ohspite.net>
400
401 * keymap.c (Fdefine_key): Fix non-prefix key error message when
402 last character M-[char] is translated to ESC [char] (bug#7541).
403
5cc7f7af
KH
4042011-08-02 Kenichi Handa <handa@m17n.org>
405
d0fffa3f 406 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
407
408 * chartab.c (uniprop_table): Make it non-static.
409
525d5e6e
EZ
4102011-08-01 Eli Zaretskii <eliz@gnu.org>
411
412 * xdisp.c (forward_to_next_line_start): Accept additional argument
413 BIDI_IT_PREV, and store into it the state of the bidi iterator had
414 on the newline.
415 (reseat_at_next_visible_line_start): Use the bidi iterator state
416 returned by forward_to_next_line_start to restore the state of
417 it->bidi_it after backing up to previous newline. (Bug#9212)
418
31011111
AS
4192011-07-30 Andreas Schwab <schwab@linux-m68k.org>
420
421 * regex.c (re_comp): Protoize.
422 (re_exec): Fix return type.
423 (regexec): Fix type of `ret'. (Bug#9203)
424
e5d76069
PE
4252011-07-29 Paul Eggert <eggert@cs.ucla.edu>
426
427 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
428 This is needed if max-image-size is a floating-point number.
429
9a79b20c
AS
4302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
431
432 * print.c (print_object): Print empty symbol as ##.
433
434 * lread.c (read1): Read ## as empty symbol.
435
d8c2fa78
AA
4362011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
437
438 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
439 setting frame foreground color (Bug#9175).
440 (x_set_background_color): Likewise.
441
ffe57a7a
AA
442 * nsmenu.m (-setText): Size tooltip dimensions precisely to
443 contents (Bug#9176).
444 (EmacsTooltip -init): Remove bezels and add shadows to
445 tooltip windows.
446
bf3492a5
AA
447 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
448 or scroll bar (Bug#8470).
449
d55e9c53
AA
450 * nsfont.m (nsfont_open): Remove assignment to voffset and
451 unnecessary vars hshink, expand, hd, full_height, min_height.
452 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
453
454 * nsterm.h (nsfont_info): Remove voffset field.
455
d8c2fa78 4562011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
457
458 Implement strike-through and overline on NextStep (Bug#8863).
459
460 * nsfont.m (nsfont_open): Use underline position provided by font,
461 instead of hard-coded value of 2.
462 (nsfont_draw): Call ns_draw_text_decoration instead.
463
464 * nsterm.h: Add declaration for ns_draw_text_decoration.
465
466 * nsterm.m (ns_draw_text_decoration): New function for drawing
467 underline, overline, and strike-through.
468 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
469 ns_draw_text_decoration. Change treatment of cursor drawing to
470 accomodate underlining, etc.
471
4cc60b9b
EZ
4722011-07-28 Eli Zaretskii <eliz@gnu.org>
473
bc7ece87
EZ
474 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
475 default.
4cc60b9b 476
476371c4
PE
4772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
478
66606eea
PE
479 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
480 Without this fix, if a signal arrives just after memory fills up,
481 'malloc' might be invoked reentrantly.
482
476371c4
PE
483 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
484 In other words, assume that every image size is allowed, on non-X
485 hosts. This assumption is probably wrong, but it lets Emacs compile.
486
f3fcc40d
AS
4872011-07-28 Andreas Schwab <schwab@linux-m68k.org>
488
489 * regex.c (re_iswctype): Convert return values to boolean.
490
350c992f
EZ
4912011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
492
493 * xdisp.c (compute_display_string_pos): Don't use cached display
494 string position if the buffer had its restriction changed.
495 (Bug#9184)
496
5266b4bb
PE
4972011-07-28 Paul Eggert <eggert@cs.ucla.edu>
498
499 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
500
2573a837 5012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 502
41f55ccd 503 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 504
39e378da
PE
505 * bidi.c: Integer size and overflow fixes.
506 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
507 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
508 (bidi_cache_find_level_change, bidi_cache_ensure_space)
509 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
510 (bidi_find_other_level_edge):
511 Use ptrdiff_t instead of EMACS_INT where either will do.
512 This works better on 32-bit hosts configured --with-wide-int.
513 (bidi_cache_ensure_space): Check for size-calculation overflow.
514 Use % rather than repeated addition, for better worst-case speed.
515 Don't set bidi_cache_size until after xrealloc returns, because it
516 might not return.
517 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
518 (bidi_cache_ensure_space): Also check that the bidi cache size
519 does not exceed that of the largest Lisp string or buffer. See Eli
520 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 521
5e927815
PE
522 * alloc.c (__malloc_size_t): Remove.
523 All uses replaced by size_t. See Andreas Schwab's note
524 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
525
ca4aa935
PE
526 * image.c: Improve checking for integer overflow.
527 (check_image_size): Assume that f is nonnull, since
528 it is always nonnull in practice. This is one less thing to
529 worry about when checking for integer overflow later.
530 (x_check_image_size): New function, which checks for integer
531 overflow issues inside X.
532 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
533 This removes the need for a memory_full check.
534 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
535 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
536 (xbm_read_bitmap_data): Change locals back to 'int', since
537 their values must fit in 'int'.
538 (xpm_load_image, png_load, tiff_load):
539 Invoke x_create_x_image_and_pixmap earlier,
540 to avoid much needless work if the image is too large.
541 (tiff_load): Treat overly large images as if
542 x_create_x_image_and_pixmap failed, not as malloc failures.
543 (gs_load): Use x_check_image_size.
544
5f8f9cc2
PE
545 * gtkutil.c: Omit integer casts.
546 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
547 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
548
5adf60bc
PE
549 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
550
c8907a93
PE
551 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
552 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
553 would wrongly return t on a 64-bit host.
554
e3c25c68
PE
555 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
556 The plain *_OVERFLOW macros run afoul of GCC bug 49705
557 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
558 and therefore cause GCC to emit a bogus diagnostic in some cases.
559
3f791afe
PE
560 * image.c: Integer signedness and overflow and related fixes.
561 This is not an exhaustive set of fixes, but it's time to
562 record what I've got.
563 (lookup_pixel_color, check_image_size): Remove redundant decls.
564 (check_image_size): Don't assume that arbitrary EMACS_INT values
565 fit in 'int', or that arbitrary 'double' values fit in 'int'.
566 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
567 (tiff_load, imagemagick_load_image):
568 Check for overflow in size calculations.
569 (x_create_x_image_and_pixmap): Remove unnecessary test for
570 xmalloc returning NULL; that can't happen.
571 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
572 (xpm_color_bucket): Use better integer hashing function.
573 (xpm_cache_color): Don't possibly over-allocate memory.
574 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
575 (gif_memory_source):
576 Use ptrdiff_t, not int or size_t, to record sizes.
577 (png_load): Don't assume values greater than 2**31 fit in 'int'.
578 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
579 either works, as we prefer signed integers.
580 (tiff_read_from_memory, tiff_write_from_memory):
581 Return tsize_t, not size_t, since that's what the TIFF API wants.
582 (tiff_read_from_memory): Don't fail simply because the read would
583 go past EOF; instead, return a short read.
584 (tiff_load): Omit no-longer-needed casts.
585 (Fimagemagick_types): Don't assume size fits into 'int'.
586
3cc5a532
PE
587 Improve hashing quality when configured --with-wide-int.
588 * fns.c (hash_string): New function, taken from sxhash_string.
589 Do not discard information about ASCII character case; this
590 discarding is no longer needed.
591 (sxhash-string): Use it. Change sig to match it. Caller changed.
592 * lisp.h: Declare it.
593 * lread.c (hash_string): Remove, since we now use fns.c's version.
594 The fns.c version returns a wider integer if --with-wide-int is
595 specified, so this should help the quality of the hashing a bit.
596
b312a492
PE
597 * emacs.c: Integer overflow minor fix.
598 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
599 Define only if GNU_LINUX.
600 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
601
dfd153ae
PE
602 * dispnew.c: Integer signedness and overflow fixes.
603 Remove unnecessary forward decls, that were a maintenance hassle.
604 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
605 All uses changed.
606 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
607 (scrolling_window): Use ptrdiff_t, not int, for byte count.
608 (prepare_desired_row, line_draw_cost):
609 Use int, not unsigned, where either works.
610 (save_current_matrix, restore_current_matrix):
611 Use ptrdiff_t, not size_t, where either works.
612 (init_display): Check for overflow more accurately, and without
613 relying on undefined behavior.
614
a81d11a3
PE
615 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
616 Remove, replacing with the new symbols in lisp.h. All uses changed.
617 * fileio.c (make_temp_name):
618 * filelock.c (lock_file_1, lock_file):
619 * xdisp.c (message_dolog):
620 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
621 Use pMd etc. instead.
622 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
623 replacing the pWIDE etc. symbols removed from editfns.c.
624
3300e6fd
PE
625 * keyboard.h (num_input_events): Now uintmax_t.
626 This is (very slightly) less likely to mess up due to wraparound.
627 All uses changed.
628
fd05c7e9
PE
629 * buffer.c: Integer signedness fixes.
630 (alloc_buffer_text, enlarge_buffer_text):
631 Use ptrdiff_t rather than size_t when either will do, as we prefer
632 signed integers.
633
903fe15d
PE
634 * alloc.c: Integer signedness and overflow fixes.
635 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
636 (__malloc_size_t): Default to size_t, not to int.
637 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
638 (Fgarbage_collect, mark_object_loop_halt, mark_object):
639 Prefer ptrdiff_t to size_t when either would do, as we prefer
640 signed integers.
641 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
642 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
643 Now const. Initialize with values that are in range even if char
644 is signed.
645 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
646 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
647 These functions do the right thing with sizes > 2**32.
648 (check_depth): Now ptrdiff_t, not int.
649 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
650 Adjust to new way of storing sizes. Check for size overflow bugs
651 in rest of code.
652 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
653 slightly wrong anyway, as it missed one instance of
654 XMALLOC_OVERRUN_CHECK_OVERHEAD.
655 (refill_memory_reserve): Omit needless cast to size_t.
656 (mark_object_loop_halt): Mark as externally visible.
657
ac82cc6a
PE
658 * xselect.c: Integer signedness and overflow fixes.
659 (Fx_register_dnd_atom, x_handle_dnd_message):
660 Use ptrdiff_t, not size_t, since we prefer signed.
661 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
662 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
663 x_dnd_atoms_size and x_dnd_atoms_length.
664
c2d1e36d
PE
665 * doprnt.c: Prefer signed to unsigned when either works.
666 * eval.c (verror):
667 * doprnt.c (doprnt):
668 * lisp.h (doprnt):
669 * xdisp.c (vmessage):
670 Use ptrdiff_t, not size_t, when using or implementing doprnt,
671 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
672 prefer signed arithmetic to avoid comparison confusion.
673 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
674 but is a bit tricky.
675
0e926e56
PE
676 Assume freestanding C89 headers, string.h, stdlib.h.
677 * data.c, doprnt.c, floatfns.c, print.c:
678 Include float.h unconditionally.
679 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
680 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
681 * regex.c: Likewise for stddef.h, string.h.
682 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
683 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
684 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
685 (STDC_HEADERS): Remove obsolete defines.
686 * sysdep.c: Include limits.h unconditionally.
687
9cfdb3ec
PE
688 Assume support for memcmp, memcpy, memmove, memset.
689 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
690 * regex.c (memcmp, memcpy):
691 Remove; we assume C89 now.
692
693 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
694 (__malloc_safe_bcopy): Remove; no longer needed.
695
cf950e6b 696 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
697 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
698 well either way, and we prefer signed to unsigned.
699
dbf38e02
LMI
7002011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
701
702 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
703 closes the connection while we're reading (bug#9182).
704
d6f0886c
JD
7052011-07-25 Jan Djärv <jan.h.d@swipnet.se>
706
707 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
708 are specified (Bug#9168).
709
2eb1f9e6
PE
7102011-07-25 Paul Eggert <eggert@cs.ucla.edu>
711
712 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
713 Found by GCC static checking and --with-wide-int on a 32-bit host.
714
22381272 7152011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
716
717 * xdisp.c (compute_display_string_pos): Fix logic of caching
718 previous display string position. Initialize cached_prev_pos to
719 -1. Fixes slow-down at the beginning of a buffer.
720
f25e39b4
EZ
7212011-07-24 Eli Zaretskii <eliz@gnu.org>
722
723 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
724 for attrs[LFACE_FONTSET_INDEX].
725
04c4b52e
PE
7262011-07-23 Paul Eggert <eggert@cs.ucla.edu>
727
728 * xml.c (parse_region): Remove unused local
729 that was recently introduced.
730
c1734fbd
EZ
7312011-07-23 Eli Zaretskii <eliz@gnu.org>
732
be18c5a5
EZ
733 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
734 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
735
c1734fbd
EZ
736 * xdisp.c (move_it_in_display_line_to): Record the best matching
737 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
738 exit if none of the characters scanned was an exact match.
739 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
740 when exact match is impossible due to invisible text, and the
741 lines are truncated.
742
a258d627
JD
7432011-07-23 Jan Djärv <jan.h.d@swipnet.se>
744
745 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
746 for OSX >= 10.7.
747
b6d5a689
EZ
7482011-07-22 Eli Zaretskii <eliz@gnu.org>
749
0f74f785
EZ
750 Fix a significant slow-down of cursor motion with C-n, C-p,
751 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
752 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 753 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
754 (next_element_from_buffer): Call compute_stop_pos_backwards to
755 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
756 base_level_stop.
757 (reseat): Don't look for prev_stop, as that could mean a very long
758 run.
759 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
760 <cached_disp_overlay_modiff>: Cache for last found display string
761 position.
551918c1 762 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
763 about the same buffer in the same area of character positions, and
764 the buffer wasn't changed since the time the display string
765 position was cached.
551918c1 766
b2d0c91a
EZ
7672011-07-22 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
770 is an integer, which is important for empty lines. (Bug#9149)
771
043604ee
CY
7722011-07-22 Chong Yidong <cyd@stupidchicken.com>
773
774 * frame.c (Fmodify_frame_parameters): In tty case, update the
775 default face if necessary (Bug#4238).
776
da4adb04
CY
7772011-07-21 Chong Yidong <cyd@stupidchicken.com>
778
779 * editfns.c (Fstring_to_char): No need to explain what a character
780 is in the docstring (Bug#6576).
781
9abd0532
LMI
7822011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
783
784 * xml.c (parse_region): Make sure we always return a tree.
785
36881d16
HK
7862011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
787
788 * xml.c (parse_region): If a document contains only comments,
789 return that, too.
790
1e98674d
LMI
7912011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
792
793 * xml.c (make_dom): Return comments, too.
794
590bd467
PE
7952011-07-19 Paul Eggert <eggert@cs.ucla.edu>
796
797 Port to OpenBSD.
798 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
799 and the surrounding thread.
800 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
801 rather than fgets, and retry after EINTR. Otherwise, 'emacs
802 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
803 timer goes off.
804 * s/openbsd.h (BROKEN_SIGIO): Define.
805 * unexelf.c (unexec) [__OpenBSD__]:
806 Don't update the .mdebug section of the Alpha COFF symbol table.
807
f41628b2
LMI
8082011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
809
810 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
811 (bug#8460).
812
b59b67c5
PE
8132011-07-18 Paul Eggert <eggert@cs.ucla.edu>
814
15e3a074
PE
815 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
816 This fixes some race conditions on the permissions of any newly
817 created file.
818
41bed37d
PE
819 * alloc.c (valid_pointer_p): Use pipe, not open.
820 This fixes some permissions issues when debugging.
821
b59b67c5
PE
822 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
823 If fchown fails to set both uid and gid, try to set just gid,
824 as that is sometimes allowed. Adjust the file's mode to eliminate
825 setuid or setgid bits that are inappropriate if fchown fails.
826
925a6be7
SM
8272011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
828
829 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
830 to compare Lisp_Objects.
831 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
832 global_gnutls_log_level, don't mistake it for a Lisp_Object.
833 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
834
52968808
AS
8352011-07-17 Andreas Schwab <schwab@linux-m68k.org>
836
0a6a104b
AS
837 * lread.c (read_integer): Unread even EOF character.
838 (read1): Likewise. Properly record start position of symbol.
839
52968808
AS
840 * lread.c (read1): Read `#:' as empty uninterned symbol if no
841 symbol character follows.
842
9e381cdd
PE
8432011-07-17 Paul Eggert <eggert@cs.ucla.edu>
844
845 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
846 This works around a problem with the previous change to Fcopy_file.
847 Recent glibc declares fchown with __attribute__((warn_unused_result)),
848 and without this change, GCC might complain about discarding
849 fchown's return value.
850
b5641435
JB
8512011-07-16 Juanma Barranquero <lekktu@gmail.com>
852
853 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
854
a8031457
PE
8552011-07-16 Paul Eggert <eggert@cs.ucla.edu>
856
857 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
858
dd889327
LMI
8592011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
860
750c33f7
LMI
861 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
862 it's used from the C level.
863
dd889327
LMI
864 * process.c: Use the same condition for POLL_FOR_INPUT in both
865 keyboard.c and process.c (bug#1858).
866
87e86684
LM
8672011-07-09 Lawrence Mitchell <wence@gmx.li>
868
869 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
870 (Fgnutls_boot): Use it.
871
64348f40
AS
8722011-07-15 Andreas Schwab <schwab@linux-m68k.org>
873
874 * doc.c (Fsubstitute_command_keys): Revert last change.
875
1d698799
LMI
8762011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
877
f863868c
LMI
878 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
879 quotes the next character, and doesn't affect other longer
880 sequences (bug#8935).
881
1d698799
LMI
882 * lread.c (syms_of_lread): Clarify that is isn't only
883 `eval-buffer' and `eval-defun' that's affected by
884 `lexical-binding' (bug#8460).
885
aa4b6df6
EZ
8862011-07-15 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
889 bidi redisplay when a line includes both an image and is
890 truncated.
891
5d856da6
PE
8922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
893
ad6042bb
PE
894 Fix minor problems found by static checking.
895 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
896 (elsz): Now a signed constant, not a size_t var. We prefer signed
897 types to unsigned, to avoid integer comparison confusion. Without
898 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
899 "cannot optimize loop, the loop counter may overflow", a symptom
900 of the confusion.
f00bbb22 901 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
902 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
903
6468f31c
LMI
9042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
905
49080b10
LMI
906 * search.c (Fre_search_backward): Mention `case-fold-search' in
907 all the re_search_* functions (bug#8138).
908
6468f31c
LMI
909 * keyboard.c (Fopen_dribble_file): Document when the file is
910 closed (bug#8056).
911
c965adc5
EZ
9122011-07-14 Eli Zaretskii <eliz@gnu.org>
913
df9733bf
EZ
914 * bidi.c (bidi_dump_cached_states): Fix format of displaying
915 bidi_cache_idx.
916
0bb23927
EZ
917 Support bidi reordering of display and overlay strings.
918 * xdisp.c (compute_display_string_pos)
919 (compute_display_string_end): Accept additional argument STRING.
920 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
921 (reseat_to_string): Initialize bidi_it->string.s and
922 bidi_it->string.schars.
923 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
924 NULL (avoids a crash in bidi_paragraph_init).
925 Initialize itb.string.lstring.
0bb23927
EZ
926 (init_iterator): Call bidi_init_it only of a valid
927 buffer position was specified. Initialize paragraph_embedding to
928 L2R.
929 (reseat_to_string): Initialize the bidi iterator.
930 (display_string): If we need to ignore text properties of
931 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
932 original value of -1 will not work with bidi.)
933 (compute_display_string_pos): First arg is now struct
934 `text_pos *'; all callers changed. Support display properties on
935 Lisp strings.
936 (compute_display_string_end): Support display properties on Lisp
937 strings.
938 (init_iterator, reseat_1, reseat_to_string): Initialize the
939 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
940 when iterating on a string not from display properties).
640c8776
SM
941 (compute_display_string_pos, compute_display_string_end):
942 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
943 arrow keys.
944 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
945 base_level_stop; instead, set base_level_stop to BEGV.
946 Fixes crashes in vertical-motion.
0bb23927
EZ
947 (next_element_from_buffer): Improve commentary for when
948 the iterator is before prev_stop.
949 (init_iterator): Initialize bidi_p from the default value of
950 bidi-display-reordering, not from buffer-local value. Use the
951 buffer-local value only if initializing for buffer iteration.
952 (handle_invisible_prop): Support invisible properties on strings
953 that are being bidi-reordered.
954 (set_iterator_to_next): Support bidi reordering of C strings and
955 Lisp strings.
956 (next_element_from_string): Support bidi reordering of Lisp
957 strings.
958 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
959 (display_string): Support display of R2L glyph rows.
960 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
961 (init_iterator): Don't initialize it->bidi_p for strings
962 here.
963 (reseat_to_string): Initialize it->bidi_p for strings here.
964 (next_element_from_string, next_element_from_c_string)
965 (next_element_from_buffer): Add xassert's for correspondence
966 between IT's object being iterated and it->bidi_it.string
967 structure.
968 (face_before_or_after_it_pos): Support bidi iteration.
969 (next_element_from_c_string): Handle the case of the first string
970 character that is not the first one in the visual order.
971 (get_visually_first_element): New function, refactored from common
972 parts of next_element_from_buffer, next_element_from_string, and
973 next_element_from_c_string.
974 (tool_bar_lines_needed, redisplay_tool_bar)
975 (display_menu_bar): Force left-to-right direction. Add a FIXME
976 comment for making that be controlled by a user option.
977 (push_it, pop_it): Save and restore the state of the
978 bidi iterator. Save and restore the bidi_p flag.
979 (pop_it): Iterate out of display property for string iteration as
980 well.
981 (iterate_out_of_display_property): Support iteration over strings.
982 (handle_single_display_spec): Set up it->bidi_it for iteration
983 over a display string, and call bidi_init_it.
984 (handle_single_display_spec, next_overlay_string)
985 (get_overlay_strings_1, push_display_prop): Set up the bidi
986 iterator for displaying display or overlay strings.
987 (forward_to_next_line_start): Don't use the shortcut if
988 bidi-iterating.
989 (back_to_previous_visible_line_start): If handle_display_prop
990 pushed the iterator stack, restore the internal state of the bidi
991 iterator by calling bidi_pop_it same number of times.
992 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
993 and we are bidi-iterating, don't decrement the iterator position;
994 instead, set the first_elt flag in the bidi iterator, to produce
995 the same effect.
996 (reseat_1): Remove redundant setting of string_from_display_prop_p.
997 (push_display_prop): xassert that we are iterating a buffer.
998 (push_it, pop_it): Save and restore paragraph_embedding member.
999 (handle_single_display_spec, next_overlay_string)
1000 (get_overlay_strings_1, reseat_1, reseat_to_string)
1001 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1002 correctly. Don't assume unibyte strings are not bidi-reordered.
1003 (compute_display_string_pos)
1004 (compute_display_string_end): Fix handling the case of C string.
1005 (push_it, pop_it): Save and restore from_disp_prop_p.
1006 (handle_single_display_spec, push_display_prop): Set the
1007 from_disp_prop_p flag.
1008 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1009 (pop_it): Call iterate_out_of_display_property only if we are
1010 popping after iteration over a string that came from a display
1011 property. Fix a typo in popping stretch info. Add an assertion
1012 for verifying that the iterator position is in sync with the bidi
1013 iterator.
1014 (handle_single_display_spec, get_overlay_strings_1)
1015 (push_display_prop): Fix initialization of paragraph direction for
1016 string when that of the parent object is not yet determined.
1017 (reseat_1): Call bidi_init_it to resync the bidi
1018 iterator with IT's position. (Bug#7616)
1019 (find_row_edges): If ROW->start.pos gives position
1020 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1021 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1022 Reset the from_disp_prop_p flag.
1023 (SAVE_IT, RESTORE_IT): New macros.
1024 (pos_visible_p, face_before_or_after_it_pos)
1025 (back_to_previous_visible_line_start)
1026 (move_it_in_display_line_to, move_it_in_display_line)
1027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1028 (try_scrolling, redisplay_window, display_line): Use them when
1029 saving a temporary copy of the iterator and restoring it back.
1030 (back_to_previous_visible_line_start, reseat_1)
1031 (init_iterator): Empty the bidi cache "stack".
1032 (move_it_in_display_line_to): If iterator ended up at
1033 EOL, but we never saw any buffer positions smaller than
1034 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1035 motion in bidi-reordered lines.
1036 (move_it_in_display_line_to): Record prev_method and prev_pos
1037 immediately before the call to set_iterator_to_next. Fixes cursor
1038 motion in bidi-reordered lines with stretch glyphs and strings
1039 displayed in margins. (Bug#8133) (Bug#8867)
1040 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1041 TO_CHARPOS.
640c8776
SM
1042 (pos_visible_p): Support positions in bidi-reordered lines.
1043 Save and restore bidi cache.
0bb23927
EZ
1044
1045 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1046 (bidi_paragraph_info): Delete unused struct.
1047 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1048 (bidi_cache_start): New variable.
1049 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1050 to zero.
1051 (bidi_cache_fetch_state, bidi_cache_search)
1052 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1053 (bidi_cache_find, bidi_peek_at_next_level)
1054 (bidi_level_of_next_char, bidi_find_other_level_edge)
1055 (bidi_move_to_visually_next): Compare cache index with
1056 bidi_cache_start rather than with zero.
1057 (bidi_fetch_char): Accept new argument STRING; all callers
1058 changed. Support iteration over a string. Support strings with
1059 display properties. Support unibyte strings. Fix the type of
1060 `len' according to what STRING_CHAR_AND_LENGTH expects.
1061 (bidi_paragraph_init, bidi_resolve_explicit_1)
1062 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1063 (bidi_level_of_next_char, bidi_move_to_visually_next):
1064 Support iteration over a string.
0bb23927
EZ
1065 (bidi_set_sor_type, bidi_resolve_explicit_1)
1066 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1067 can now be zero (for strings); special values 0 and -1 were
1068 changed to -1 and -2, respectively.
1069 (bidi_char_at_pos): New function.
1070 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1071 Call it instead of FETCH_MULTIBYTE_CHAR.
1072 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1073 initialized to valid values.
1074 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1075 values.
1076 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1077 the test for valid cached positions. Fix the logic for looking up
1078 the sentinel state in the cache. GCPRO the Lisp string we are
1079 iterating.
1080 (bidi_push_it, bidi_pop_it): New functions.
1081 (bidi_initialize): Initialize the bidi cache start stack pointer.
1082 (bidi_cache_ensure_space): New function, refactored from part of
1083 bidi_cache_iterator_state. Don't assume the required size is just
1084 one BIDI_CACHE_CHUNK away.
1085 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1086 (bidi_count_bytes, bidi_char_at_pos): New functions.
1087 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1088 always valid if bidi_cache_idx is valid.
1089 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1090 is valid if it's going to be used.
1091 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1092 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1093 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1094 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1095 (bidi_find_other_level_edge, bidi_cache_start_stack):
1096 All variables related to cache indices are now EMACS_INT.
c965adc5 1097
0bb23927
EZ
1098 * dispextern.h (struct bidi_string_data): New structure.
1099 (struct bidi_it): New member `string'. Make flag members be 1-bit
1100 fields, and put them last in the struct.
640c8776
SM
1101 (compute_display_string_pos, compute_display_string_end):
1102 Update prototypes.
0bb23927
EZ
1103 (bidi_push_it, bidi_pop_it): Add prototypes.
1104 (struct iterator_stack_entry): New members bidi_p,
1105 paragraph_embedding, and from_disp_prop_p.
1106 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1107 (bidi_shelve_cache, bidi_unshelve_cache):
1108 Declare prototypes.
0bb23927
EZ
1109
1110 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1111 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1112 and vector-like objects.
1113
1114 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1115 cache around display iteration.
1116
1117 * window.c (Fwindow_end, window_scroll_pixel_based)
1118 (displayed_window_lines, Frecenter): Save and restore the bidi
1119 cache around display iteration.
1120
3bbd2265
LMI
11212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1122
1123 * editfns.c (Fdelete_region): Clarify the use of the named
1124 parameters (bug#6788).
1125
adc47434
MR
11262011-07-14 Martin Rudalics <rudalics@gmx.at>
1127
1128 * indent.c (Fvertical_motion): Set and restore w->pointm when
1129 saving and restoring the window's buffer (Bug#9006).
1130
837c31f8
LMI
11312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1132
1133 * editfns.c (Fstring_to_char): Clarify just what is returned
1134 (bug#6576). Text by Eli Zaretskii.
1135
ac389d0c
JB
11362011-07-13 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1139
0be0ce47
EZ
11402011-07-13 Eli Zaretskii <eliz@gnu.org>
1141
1142 * buffer.c (mmap_find): Fix a typo.
1143
cd18e7e3
JB
11442011-07-13 Johan Bockgård <bojohan@gnu.org>
1145
1146 Fix execution of x selection hooks.
1147 * xselect.c (Qx_lost_selection_functions)
1148 (Qx_sent_selection_functions): New vars.
1149 (syms_of_xselect): DEFSYM them.
1150 (x_handle_selection_request): Pass Qx_sent_selection_functions
1151 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1152 (x_handle_selection_clear,x_clear_frame_selections):
1153 Pass Qx_lost_selection_functions rather than
1154 Vx_lost_selection_functions to Frun_hook_with_args.
1155
47ea7f44
PE
11562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1157
ac389d0c 1158 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1159 The old code sometimes used this field without initializing it.
1160
47ea7f44
PE
1161 * alloc.c (gc_sweep): Don't read past end of array.
1162 In theory, the old code could also have corrupted Emacs internals,
1163 though it'd be very unlikely.
1164
bc985c87
AS
11652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1166
1167 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1168 argument. (Bug#4026)
bc985c87 1169
0cf34688
LMI
11702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1171
b3dadd76
LMI
1172 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1173 key" (bug#4257).
1174
0cf34688
LMI
1175 * window.c (Fset_window_start): Doc fix (bug#4199).
1176 (Fset_window_hscroll): Ditto.
1177
270768cd
PE
11782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1179
077e3dda 1180 Fix minor new problems caught by GCC 4.6.1.
270768cd 1181 * term.c (init_tty): Remove unused local.
490011a6 1182 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 1183 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 1184 not used otherwise.
270768cd 1185
b1f58454
CY
11862011-07-12 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1189
22b9578d
LMI
11902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1191
6e70ab07
LMI
1192 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1193 are the mini-buffer and the echo area (bug#3320).
1194
22b9578d
LMI
1195 * term.c (init_tty): Remove support for supdup, c10 and perq
1196 terminals, which are no longer supported (bug#1482).
1197
8974cc9f
JB
11982011-07-10 Johan Bockgård <bojohan@gnu.org>
1199
1200 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1201
a560d974
JD
12022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1203
1204 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1205 for non-popups (Bug#3642).
1206
1dae0f0a
AS
12072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1208
268c2c36 1209 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 1210 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
1211 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1212 * cm.c (losecursor): Likewise.
1dae0f0a
AS
1213 * data.c (fmod): Likewise.
1214 * dispnew.c (swap_glyphs_in_rows): Likewise.
1215 * emacs.c (memory_warning_signal): Likewise.
1216 * floatfns.c (float_error): Likewise.
1217 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1218 (otf_open, font_otf_capability, generate_otf_features)
1219 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1220 Likewise.
1221 * image.c (pbm_read_file): Likewise.
1222 * indent.c (string_display_width): Likewise.
1223 * intervals.c (check_for_interval, search_for_interval)
1224 (inc_interval_count, count_intervals, root_interval)
1225 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1226 * lread.c (defalias): Likewise.
268c2c36 1227 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
1228 * regex.c (set_image_of_range_1, set_image_of_range)
1229 (regex_grow_registers): Likewise.
1230 * sysdep.c (strerror): Likewise.
1231 * termcap.c (valid_filename_p, tprint, main): Likewise.
1232 * tparam.c (main): Likewise.
1233 * unexhp9k800.c (run_time_remap, save_data_space)
1234 (update_file_ptrs, read_header, write_header, calculate_checksum)
1235 (copy_file, copy_rest, display_header): Likewise.
1236 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1237 Likewise.
1238 * xdisp.c (check_it): Likewise.
1239 * xfaces.c (register_color, unregister_color, unregister_colors):
1240 Likewise.
1241 * xfns.c (print_fontset_result): Likewise.
1242 * xrdb.c (member, fatal, main): Likewise.
1243
99033785
PE
12442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1245
1246 Fix minor problems found by static checking (Bug#9031).
1247 * chartab.c (char_table_set_range, map_sub_char_table):
1248 Remove unused locals.
1249 (uniprop_table): Now static.
1250 * composite.c (_work_char): Remove unused static var.
1251
9cb2ac56
JB
12522011-07-09 Juanma Barranquero <lekktu@gmail.com>
1253
1254 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1255
f25661f0
JD
12562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1257
1258 * gtkutil.c (qttip_cb): Remove code without function.
1259
8278c4fe
EZ
12602011-07-09 Eli Zaretskii <eliz@gnu.org>
1261
1262 * w32.c (pthread_sigmask): New stub.
1263
1692ae2d 12642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 1265
8a6ebd58 1266 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
1267 sigprocmask is portable only for single-threaded applications, and
1268 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
1269 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1270 (LIBES): Use it.
1271 * callproc.c (Fcall_process):
1272 * process.c (create_process):
1273 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1274 Use pthread_sigmask, not sigprocmask.
123403e4 1275
1b854618
JD
12762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1277
1278 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1279 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1280 wrong (Bug#8591).
1281
3fe4b549
JD
12822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1283
0ce7e563
JD
1284 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1285 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1286 (xg_hide_tooltip): Fix comment.
1287
3fe4b549
JD
1288 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1289 in registerServicesMenuSendTypes.
1290 (validRequestorForSendType): Don't check ns_return_types.
1291
1292 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1293 ns_return_type.
1294
5df75e47
JR
12952011-07-08 Jason Rumney <jasonr@gnu.org>
1296
1297 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1298 frame struct members of non-existent frames (Bug#6284).
1299
699c10bd
JD
13002011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1301
4393663b
JD
1302 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1303 variable firstTime not needed on OSX >= 10.6.
1304 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1305 >= 10.5. Use setKnobProportion, setDoubleValue.
1306
1307 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1308 (MAC_OS_X_VERSION_10_5): Define if not defined.
1309 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1310 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1311 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1312
1313 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1314 cString and lossyCString on OSX >= 10.4
1315
1316 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1317 sizeToFit on OSX >= 10.2.
1318
1319 * nsimage.m (allocInitFromFile): Don't use deprecated method
1320 bestRepresentationForDevice on OSX >= 10.6.
1321
1322 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1323 to avoid warning.
1324
1325 * emacs.c: Declare unexec_init_emacs_zone.
1326
a63e0781
JD
1327 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1328
699c10bd
JD
1329 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1330
1331 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1332 on svcsMenu (Bug#8842).
1333
1334 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1335 ns_return_types.
1336 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1337
1338 * nsterm.m (QUTF8_STRING): Declare.
1339 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1340 (validRequestorForSendType): Return type is (id).
1341 Change indexOfObjectIdenticalTo to indexOfObject.
1342 Check if we have local selection before returning self (Bug#8842).
1343 (writeSelectionToPasteboard): Put local selection into paste board
1344 if we have a local selection (Bug#8842).
1345 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1346
1347 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1348 (ns_get_local_selection): Declare.
1349
54e10184
LMI
13502011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1351
9888ff71
LMI
1352 * keymap.c (describe_map_tree): Don't insert a double newline at
1353 the end of the buffer (bug#1169) and return whether we inserted
1354 something.
1355
54e10184
LMI
1356 * callint.c (Fcall_interactively): Change "reading args" to
1357 "providing args" to try to clarify what it does (bug#1010).
1358
15fa4783
KH
13592011-07-07 Kenichi Handa <handa@m17n.org>
1360
1361 * composite.c (composition_compute_stop_pos): Ignore a static
1362 composition starting before CHARPOS (Bug#8915).
1363
1364 * xdisp.c (handle_composition_prop): Likewise.
1365
a8815b00
EZ
13662011-07-07 Eli Zaretskii <eliz@gnu.org>
1367
1368 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1369 (Bug#9015)
1370
ef7b981d 13712011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1372
1373 * character.h (unicode_category_t): New enum type.
1374
1375 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1376 (Qchar_code_property_table): New variable.
1377 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1378 (UNIPROP_COMPRESSED_FORM_P): New macros.
1379 (char_table_ascii): Uncompress the compressed values.
1380 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1381 Uncompress the compressed values.
ac389d0c 1382 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1383 (char_table_ref_and_range): Uncompress the compressed values.
1384 (sub_char_table_set): New arg is_uniprop. Callers changed.
1385 Uncompress the compressed values.
1386 (sub_char_table_set_range): Args changed. Callers changed.
1387 (char_table_set_range): Adjuted for the above change.
1388 (map_sub_char_table): Delete args default_val and parent. Add arg
1389 top. Give decoded values to a Lisp function.
640c8776 1390 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1391 values to a Lisp function. Gcpro more variables.
1392 (uniprop_table_uncompress)
1393 (uniprop_decode_value_run_length): New functions.
1394 (uniprop_decoder, uniprop_decoder_count): New variables.
1395 (uniprop_get_decoder, uniprop_encode_value_character)
1396 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1397 New functions.
1398 (uniprop_encoder, uniprop_encoder_count): New variables.
1399 (uniprop_get_encoder, uniprop_table)
1400 (Funicode_property_table_internal, Fget_unicode_property_internal)
1401 (Fput_unicode_property_internal): New functions.
1402 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1403 Sunicode_property_table_internal, Sget_unicode_property_internal,
1404 and Sput_unicode_property_internal. Defvar_lisp
1405 char-code-property-alist.
1406
640c8776 1407 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1408 Vunicode_category_table.
1409
640c8776 1410 * font.c (font_range): Adjust for the change of
c805dec0
KH
1411 Vunicode_category_table.
1412
76b397fb
DN
14132011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1414
1415 * m/iris4d.h: Remove file, move contents ...
1416 * s/irix6-5.h: ... here.
1417
22b4128e
PE
14182011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1419
1420 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1421 * alloc.c (mark_buffer):
1422 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1423 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1424 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1425 This isn't true in general, and it's particularly not true
1426 if Emacs is configured with --with-wide-int.
1427 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1428 New macros, used in the buffer.c change.
1429
869795d6
JD
14302011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1431
1432 * xsettings.c: Use both GConf and GSettings if both are available.
1433 (store_config_changed_event): Add comment.
1434 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1435 (store_tool_bar_style_changed): New functions.
1436 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1437 (struct xsettings): Move font inside HAVE_XFT.
1438 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1439 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1440 Move inside HAVE_XFT.
640c8776 1441 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1442 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1443 also.
1444 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1445 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1446 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1447 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1448 (parse_settings): Move check for font inside HAVE_XFT.
1449 (read_settings, apply_xft_settings): Add comment.
1450 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1451 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1452 call store_font_name_changed.
1453 (xft_settings_event): Add comment.
1454 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1455 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1456 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1457 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1458 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1459 (xsettings_get_system_font, xsettings_get_system_normal_font):
1460 Add comment.
869795d6 1461
d8ed26bd
PE
14622011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1463
1464 Random fixes. E.g., (random) never returned negative values.
1465 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1466 subseconds part to the entropy, as that's a bit more random.
1467 Prefer signed to unsigned, since the signedness doesn't matter and
1468 in general we prefer signed. When given a limit, use a
1469 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1470 latter isn't right if USE_2_TAGS_FOR_INTS.
1471 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1472 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1473
cabf1cac
SM
14742011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1475
1476 * textprop.c (text_property_stickiness):
1477 Obey Vtext_property_default_nonsticky.
1478 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1479 * w32fns.c (syms_of_w32fns):
1480 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1481
6e9b2be9
PE
14822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1483
1484 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1485 This is more efficient than Ffile_directory_p and avoids a minor race.
1486
90186c68
LMI
14872011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1488
7c301272
LMI
1489 * buffer.c (Foverlay_put): Say what the return value is
1490 (bug#7835).
1491
c4f2d8d4
LMI
1492 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1493 is a directory before asking whether to use the file name
1494 (bug#7564).
ad637907
LMI
1495 (barf_or_query_if_file_exists): Make the "File is a directory"
1496 error be more correct.
c4f2d8d4 1497
90186c68
LMI
1498 * fns.c (Frequire): Remove the mention of the .gz files, since
1499 that's installation-specific, but keep the mention of
1500 `get-load-suffixes'.
1501
da64016e
PE
15022011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1503
1504 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1505 Report string overflow if the output is too long.
1506
7d47b580
JB
15072011-07-04 Juanma Barranquero <lekktu@gmail.com>
1508
a555cb87
JB
1509 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1510 (syms_of_gnutls): Remove duplicate DEFSYM for
1511 Qgnutls_bootprop_verify_hostname_error, an error for
1512 Qgnutls_bootprop_verify_error (which is no longer used).
1513
7d47b580
JB
1514 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1515 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1516 Also (re)move comments that are misplaced or no longer relevant.
1517
1e49bfab
LMI
15182011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1519
1520 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1521
1485f4c0
CY
15222011-07-03 Chong Yidong <cyd@stupidchicken.com>
1523
1524 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1525 and background color parameters if they have been changed.
1526
a9ab721e
LMI
15272011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1528
1529 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1530
cf7cff57
PE
15312011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1532
2e13213d
PE
1533 * xsettings.c (SYSTEM_FONT): Define only when used.
1534 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1535
cf7cff57
PE
1536 * keymap.c (access_keymap_1): Now static.
1537
7a8e04f7
CY
15382011-07-02 Chong Yidong <cyd@stupidchicken.com>
1539
1540 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1541 leave any prefix arg for the up event (Bug#1586).
1542
61352f62
LMI
15432011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1544
69bb1ef7
LMI
1545 * lread.c (syms_of_lread): Mention single symbols defined by
1546 `defvar' or `defconst' (bug#7154).
1547
61352f62 1548 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1549 (Frequire): Mention get-load-suffixes.
61352f62 1550
28545e04
MR
15512011-07-02 Martin Rudalics <rudalics@gmx.at>
1552
1553 * window.h (window): Remove clone_number slot.
1554 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1555 Remove.
1556 (make_parent_window, make_window, saved_window)
1557 (Fset_window_configuration, save_window_save): Don't deal with
1558 clone numbers.
1559 * buffer.c (Qclone_number): Remove declaration.
1560 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1561
3349e122
SM
15622011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1563
1564 Add multiple inheritance to keymaps.
1565 * keymap.c (Fmake_composed_keymap): New function.
1566 (Fset_keymap_parent): Simplify.
1567 (fix_submap_inheritance): Remove.
1568 (access_keymap_1): New function extracted from access_keymap to handle
1569 embedded parents and handle lists of maps.
1570 (access_keymap): Use it.
1571 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1572 (Fcopy_keymap): Handle embedded parents.
1573 (Fcommand_remapping, define_as_prefix): Simplify.
1574 (Fkey_binding): Simplify.
1575 (syms_of_keymap): Move minibuffer-local-completion-map,
1576 minibuffer-local-filename-completion-map,
1577 minibuffer-local-must-match-map, and
1578 minibuffer-local-filename-must-match-map to Elisp.
1579 (syms_of_keymap): Defsubr make-composed-keymap.
1580 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1581 (parse_menu_item): Trivial simplification.
1582
3279eb87
GM
15832011-07-01 Glenn Morris <rgm@gnu.org>
1584
1585 * Makefile.in (SETTINGS_LIBS): Fix typo.
1586
4550efdf
KI
15872011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1588
1589 * coding.c (Fencode_coding_string): Record the last coding system
1590 used, as the function doc string says (bug#8738).
1591
0949d2b6
JD
15922011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1593
1594 * xsettings.c (store_monospaced_changed): Take new font as arg and
1595 check for change against current_mono_font.
1596 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1597 (emacs_settings_constructor, emacs_settings_get_property)
1598 (emacs_settings_set_property, emacs_settings_class_init)
1599 (emacs_settings_init, gsettings_obj): Remove.
1600 (something_changedCB): New function for HAVE_GSETTINGS.
1601 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1602 with value as argument.
1603 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1604 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1605 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1606 "changed".
1607
1608 * xgselect.c: Add defined (HAVE_GSETTINGS).
1609 (xgselect_initialize): Ditto.
1610
1611 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1612 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1613 xg_select.
1614
bbc6b304
PE
16152011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1616
1617 * eval.c (struct backtrace): Simplify and port the data structure.
1618 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1619 signed bit field, as this assumption is not portable and it makes
1620 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1621 "char debug_on_exit : 1" as this is not portable either; instead,
1622 use the portable "unsigned int debug_on_exit : 1". Remove unused
1623 member evalargs. Remove obsolete comments about cc bombing out.
1624
9851bfc5
JD
16252011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1626
51bb811f 1627 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1628 Let HAVE_GSETTINGS override HAVE_GCONF.
1629 (store_monospaced_changed): New function.
1630 (EMACS_SETTINGS): A new type derived from GObject to handle
1631 GSettings notifications.
1632 (emacs_settings_constructor, emacs_settings_get_property)
1633 (emacs_settings_set_property, emacs_settings_class_init):
1634 New functions.
1635 (gsettings_client, gsettings_obj): New variables.
1636 (GSETTINGS_SCHEMA): New define.
1637 (something_changedCB): Call store_monospaced_changed.
1638 (init_gsettings): New function.
1639 (xsettings_initialize): Call init_gsettings.
1640 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1641 to NULL.
1642
640c8776 1643 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1644 GCONF_CFLAGS/LIBS.
1645
5386012d
MR
16462011-06-29 Martin Rudalics <rudalics@gmx.at>
1647
1648 * window.c (resize_root_window, grow_mini_window)
1649 (shrink_mini_window): Rename Qresize_root_window to
1650 Qwindow_resize_root_window and Qresize_root_window_vertically to
1651 Qwindow_resize_root_window_vertically.
1652
f13e0b08
PE
16532011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1656
94515237
JB
16572011-06-27 Juanma Barranquero <lekktu@gmail.com>
1658
1659 * makefile.w32-in: Redesign dependencies so they reflect more
1660 clearly which files are directly included by each source file,
1661 and not through other includes.
1662
e43b6e43
MR
16632011-06-27 Martin Rudalics <rudalics@gmx.at>
1664
1665 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1666 (sort_overlays, overlay_strings): When an overlay's clone number
1667 matches the window's clone number process the overlay even if
1668 the overlay's window property doesn't match the current window.
1669
d68443dc
MR
1670 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1671 (Fwindow_hchild): Rename to Fwindow_left_child.
1672 (Fwindow_next): Rename to Fwindow_next_sibling.
1673 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1674 (resize_window_check): Rename to window_resize_check.
1675 (resize_window_apply): Rename to window_resize_apply.
1676 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1677 (Fdelete_other_windows_internal, resize_frame_windows)
1678 (Fsplit_window_internal, Fdelete_window_internal)
1679 (grow_mini_window, shrink_mini_window)
1680 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1681
c7e73be5
JD
16822011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1683
1684 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1685 (emacs_fixed_set_min_size): Remove.
1686 (emacs_fixed_new): Take frame as argument.
1687
1688 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1689 (_EmacsFixedPrivate): Remove minwidth/height.
1690 Add struct frame *f.
1691 (emacs_fixed_init): Initialize priv->f.
1692 (get_parent_class, emacs_fixed_set_min_size): Remove.
1693 (emacs_fixed_new): Set priv->f to argument.
1694 (emacs_fixed_get_preferred_width)
1695 (emacs_fixed_get_preferred_height): Use min_width/height from
1696 frames size_hint to set minimum and natural (Bug#8919).
1697 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1698 and use min_width/height from frames size_hint to set
1699 min_width/height (Bug#8919).
1700
1701 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1702 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1703 Fix indentation.
c7e73be5 1704
cf99dcf8
EZ
17052011-06-26 Eli Zaretskii <eliz@gnu.org>
1706
1707 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1708 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1709 called at ZV.
1710
029529ac
CY
17112011-06-26 Chong Yidong <cyd@stupidchicken.com>
1712
1713 * process.c (wait_reading_process_output): Bypass select if
1714 waiting for a cell while ignoring keyboard input, and input is
1715 pending. Suggested by Jan Djärv (Bug#8869).
1716
7a7ef429
PE
17172011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1718
1719 Use gnulib's dup2 module instead of rolling our own.
1720 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1721
11fdef7d 17222011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1723
1724 * dispnew.c (scrolling_window): Before scrolling, turn off a
1725 mouse-highlight in the window being scrolled.
1726
cd3520a4
JB
17272011-06-24 Juanma Barranquero <lekktu@gmail.com>
1728
1729 Move DEFSYM to lisp.h and use everywhere.
1730
1731 * character.h (DEFSYM): Move declaration...
1732 * lisp.h (DEFSYM): ...here.
1733
1734 * gnutls.c:
1735 * minibuf.c:
1736 * w32menu.c:
1737 * w32proc.c:
1738 * w32select.c: Don't include character.h.
1739
1740 * alloc.c (syms_of_alloc):
1741 * buffer.c (syms_of_buffer):
1742 * bytecode.c (syms_of_bytecode):
1743 * callint.c (syms_of_callint):
1744 * casefiddle.c (syms_of_casefiddle):
1745 * casetab.c (init_casetab_once):
1746 * category.c (init_category_once, syms_of_category):
1747 * ccl.c (syms_of_ccl):
1748 * cmds.c (syms_of_cmds):
1749 * composite.c (syms_of_composite):
1750 * dbusbind.c (syms_of_dbusbind):
1751 * dired.c (syms_of_dired):
1752 * dispnew.c (syms_of_display):
1753 * doc.c (syms_of_doc):
1754 * editfns.c (syms_of_editfns):
1755 * emacs.c (syms_of_emacs):
1756 * eval.c (syms_of_eval):
1757 * fileio.c (syms_of_fileio):
1758 * fns.c (syms_of_fns):
1759 * frame.c (syms_of_frame):
1760 * fringe.c (syms_of_fringe):
1761 * insdel.c (syms_of_insdel):
1762 * keymap.c (syms_of_keymap):
1763 * lread.c (init_obarray, syms_of_lread):
1764 * macros.c (syms_of_macros):
1765 * msdos.c (syms_of_msdos):
1766 * print.c (syms_of_print):
1767 * process.c (syms_of_process):
1768 * search.c (syms_of_search):
1769 * sound.c (syms_of_sound):
1770 * syntax.c (init_syntax_once, syms_of_syntax):
1771 * terminal.c (syms_of_terminal):
1772 * textprop.c (syms_of_textprop):
1773 * undo.c (syms_of_undo):
1774 * w32.c (globals_of_w32):
1775 * window.c (syms_of_window):
1776 * xdisp.c (syms_of_xdisp):
1777 * xfaces.c (syms_of_xfaces):
1778 * xfns.c (syms_of_xfns):
1779 * xmenu.c (syms_of_xmenu):
1780 * xsettings.c (syms_of_xsettings):
1781 * xterm.c (syms_of_xterm): Use DEFSYM.
1782
4228cf16
TZ
17832011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1784
cd3520a4 1785 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1786
7fcccf1e
PE
17872011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1788
7efb4e0e
PE
1789 Integer and buffer overflow fixes (Bug#8873).
1790
ff5844ad
PE
1791 * print.c (printchar, strout): Check for string overflow.
1792 (PRINTPREPARE, printchar, strout):
1793 Don't set size unless allocation succeeds.
1794
90532f02
PE
1795 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1796 for sizes. Check for string overflow more accurately.
1797 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1798
6d84508d
PE
1799 * macros.c: Integer and buffer overflow fixes.
1800 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1801 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1802 Use ptrdiff_t, not int, for sizes.
1803 Don't increment bufsize until after realloc succeeds.
1804 Check for size-calculation overflow.
1805 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1806
437b2cb4
PE
1807 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1808
8b9ac8b4
PE
1809 * lread.c: Integer overflow fixes.
1810 (read_integer): Radix is now EMACS_INT, not int,
1811 to improve quality of diagnostics for out-of-range radices.
1812 Calculate buffer size correctly for out-of-range radices.
1813 (read1): Check for integer overflow in radices, and in
1814 read-circle numbers.
82cb60d3
PE
1815 (read_escape): Avoid int overflow.
1816 (Fload, openp, read_buffer_size, read1)
1817 (substitute_object_recurse, read_vector, read_list, map_obarray):
1818 Use ptrdiff_t, not int, for sizes.
1819 (read1): Use EMACS_INT, not int, for sizes.
20270765 1820 Check for size overflow.
8b9ac8b4 1821
7fcccf1e
PE
1822 * image.c (cache_image): Check for size arithmetic overflow.
1823
bfbbd7e7
PE
1824 * lread.c: Integer overflow issues.
1825 (saved_doc_string_size, saved_doc_string_length)
1826 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1827 Now ptrdiff_t, not int.
1828 (read1): Don't assume doc string length fits in int. Check for
1829 out-of-range doc string lengths.
1830 (read_list): Don't assume file position fits in int.
39019e54 1831 (read_escape): Check for hex character overflow.
bfbbd7e7 1832
4e323265
LL
18332011-06-22 Leo Liu <sdl.web@gmail.com>
1834
1835 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1836 Move to minibuffer.el.
1837
85fece3e
PE
18382011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1839
20b84ce9 1840 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1841 The following patches are for when GLYPH_DEBUG && !XASSERT.
1842 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1843 * dispnew.c (flush_stdout):
1844 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1845 Mark as externally visible.
1846 * dispnew.c (check_window_matrix_pointers): Now static.
1847 * dispnew.c (window_to_frame_vpos):
1848 * xfns.c (unwind_create_frame):
1849 * xterm.c (x_check_font): Remove unused local.
1850 * scroll.c (CHECK_BOUNDS):
1851 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1852 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1853 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1854 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1855 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1856 Now static.
1857 (debug_method_add): Use va_list and vsprintf rather than relying
1858 on undefined behavior with wrong number of arguments.
1859 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1860 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1861 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1862 since we're not interested in debugging glyphs with old libraries.
1863 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1864 GCC 4.6.0's static checking.
1865
0766b489
PE
18662011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1867
31fd4b32
PE
1868 Integer overflow and signedness fixes (Bug#8873).
1869 A few related buffer overrun fixes, too.
1870
b79e8648
PE
1871 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1872
0766b489
PE
1873 * dispextern.h (struct face.stipple):
1874 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1875 (x_bitmap_mask, x_allocate_bitmap_record)
1876 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1877 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1878 (x_create_bitmap_from_xpm_data):
1879 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1880 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1881 (.bitmaps_last):
1882 * xfaces.c (load_pixmap):
1883 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1884 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1885 (.bitmaps_last, struct x_output.icon_bitmap):
1886 Use ptrdiff_t, not int, for bitmap indexes.
1887 (x_allocate_bitmap_record): Check for size overflow.
1888 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1889
b081724f
PE
1890 Use ptrdiff_t, not int, for overlay counts.
1891 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1892 * editfns.c (overlays_around, get_pos_property):
1893 * textprop.c (get_char_property_and_overlay):
1894 * xdisp.c (next_overlay_change, note_mouse_highlight):
1895 * xfaces.c (face_at_buffer_position):
21514da7
PE
1896 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1897 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1898 (Fnext_overlay_change, Fprevious_overlay_change)
1899 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1900 Use ptrdiff_t, not int, for sizes.
21514da7 1901 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1902
3de73e5e
PE
1903 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1904
2606c57b
PE
1905 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1906 (x_session_initialize): Do not assume string length fits in int.
1907
aaafe47a
PE
1908 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1909 This is unlikely, but can occur if DPI is outlandish.
1910
2674ddc8 1911 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1912 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1913
28154962
PE
1914 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1915 * xrdb.c (magic_file_p, search_magic_path):
1916 Omit last arg SUFFIX; it was always 0. All callers changed.
1917 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1918
7de51af5
PE
1919 * xfont.c (xfont_match): Avoid need for strlen.
1920
25ed6cc3
PE
1921 * xfns.c: Don't assume strlen fits in int.
1922 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1923
4eab31dd
PE
1924 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1925 not unsigned long, as we prefer signed integers. All callers changed.
1926 Detect integer overflow in repeat count.
1927 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1928 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1929
171e2a58
PE
1930 * termcap.c: Don't assume sizes fit in int and never overflow.
1931 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1932 (gobble_line): Check for size-calculation overflow.
1933
ad39faca 1934 * minibuf.c (Fread_buffer):
6e5bb2dc 1935 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1936 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1937 Don't assume string length fits in int.
1938
52c61c22 1939 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1940 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1941
b5b8c9e5
PE
1942 * font.c: Don't assume string length fits in int.
1943 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1944 Use ptrdiff_t, not int.
ccd6111c
PE
1945 (font_intern_prop): Don't assume string length fits in int.
1946 Don't assume integer property fits in fixnum.
1947 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1948
882f0d81 1949 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1950 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1951 Reformulate so as not to need the command string.
1952 Invoke gzip -cd rather than gunzip, as it's more portable.
1953 (lock_info_type, lock_file_1, lock_file):
1954 Don't assume pid_t and time_t fit in unsigned long.
1955 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1956 (current_lock_owner): Prefer signed type for sizes.
1957 Use memcpy, not strncpy, where memcpy is what is really wanted.
1958 Don't assume (via atoi) that time_t and pid_t fit in int.
1959 Check for time_t and/or pid_t out of range, e.g., via a network share.
1960 Don't alloca where an auto var works fine.
1961
93f4cf88
PE
1962 * fileio.c: Fix some integer overflow issues.
1963 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1964 Don't assume string length fits in int.
1965 (directory_file_name): Don't assume string length fits in long.
1966 (make_temp_name): Don't assume pid fits in int, or that its print
1967 length is less than 20.
1968
f3e92b69
PE
1969 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1970
1bfdaf10
PE
1971 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1972
35016e9a
PE
1973 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1974
3d1e65a1
PE
1975 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1976 We prefer signed integers, even for size calculations.
1977
0b963a93
PE
1978 * emacs.c: Don't assume string length fits in 'int'.
1979 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1980 (main): Don't invoke strlen when not needed.
1981
573f4b54
PE
1982 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1983 (XD_DEBUG_MESSAGE): Don't waste a byte.
1984
989f33ba
PE
1985 * callproc.c (getenv_internal_1, getenv_internal)
1986 (Fgetenv_internal):
965d34eb
PE
1987 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1988
e4d29b33
PE
1989 * lread.c (invalid_syntax): Omit length argument.
1990 All uses changed. This doesn't fix a bug, but it simplifies the
1991 code away from its former Hollerith-constant appearance, and it's
1992 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1993 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1994
eb49b136
PE
1995 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1996 This didn't break anything, but it didn't help either.
1997 It's confusing to put a bogus integer in a place where the actual
1998 value does not matter.
9f62aeb1 1999 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2000 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2001
15375a22
PE
2002 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2003 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2004 implementation.
b61cc01c
PE
2005 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2006 We prefer signed types, and the value cannot exceed the EMACS_INT
2007 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2008 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2009 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2010 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2011
53b2623d
PE
2012 * indent.c (sane_tab_width): New function.
2013 (current_column, scan_for_column, Findent_to, position_indentation)
2014 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2015 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2016
51cab52b 2017 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2018
f2ed8a70
PE
2019 * lisp.h (lint_assume): New macro.
2020 * composite.c (composition_gstring_put_cache):
2021 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2022
abe80cc6
PE
2023 * editfns.c, insdel.c:
2024 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2025
b02c740e
PE
2026 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2027
ebc96716
PE
2028 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2029
b4e50fa0 2030 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2031 Use much-faster test for byte-length change.
311d5d7c 2032 Don't assume string byte-length fits in 'int'.
a4cf38e4 2033 Check that character arg fits in 'int'.
85461888 2034 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2035
c0c1ee9f
PE
2036 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2037
a498d7f4
PE
2038 * fns.c (concat): Catch string overflow earlier.
2039 Do not rely on integer wraparound.
2040
51cab52b
PE
2041 * dispextern.h (struct it.overlay_strings_charpos)
2042 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2043 * xdisp.c (forward_to_next_line_start)
2044 (back_to_previous_visible_line_start)
2045 (reseat_at_next_visible_line_start, next_element_from_buffer):
2046 Don't arbitrarily truncate the value of 'selective' to int.
2047
76031fad
PE
2048 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2049
5eb55db9
PE
2050 * composite.c: Don't truncate sizes to 'int'.
2051 (composition_gstring_p, composition_reseat_it)
2052 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2053 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2054 not EMACS_UINT, for indexes.
5eb55db9 2055
0703a717
PE
2056 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2057
d6202519
PE
2058 * buffer.c: Include <verify.h>.
2059 (struct sortvec.priority, struct sortstr.priority):
8961a454 2060 Now EMACS_INT, not int.
c20998a7 2061 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2062 (struct sortstr.size, record_overlay_string)
2063 (struct sortstrlist.size, struct sortlist.used):
2064 Don't truncate size to int.
2065 (record_overlay_string): Check for size-calculation overflow.
d6202519 2066 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2067
d5a19415
JM
20682011-06-22 Jim Meyering <meyering@redhat.com>
2069
029529ac 2070 Don't leak an XBM-image-sized buffer
d5a19415
JM
2071 * image.c (xbm_load): Free the image buffer after using it.
2072
a9041e6c
PE
20732011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 Port to Sun C.
2076 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2077 that Sun C diagnosed.
2078 * fns.c (secure_hash): Fix pointer signedness issue.
2079 * intervals.c (static_offset_intervals): New function.
2080 (offset_intervals): Use it.
2081
7f3f739f
LL
20822011-06-21 Leo Liu <sdl.web@gmail.com>
2083
2084 * deps.mk (fns.o):
2085 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2086 sha512.h.
2087
2088 * fns.c (secure_hash): Rename from crypto_hash_function and change
2089 the first arg to accept symbols.
5b66d427 2090 (Fsecure_hash): New primitive.
7f3f739f
LL
2091 (syms_of_fns): New symbols.
2092
76147d94
DD
20932011-06-20 Deniz Dogan <deniz@dogan.se>
2094
2095 * process.c (Fset_process_buffer): Clarify return value in
2096 docstring.
2097
7d7d0045
CY
20982011-06-18 Chong Yidong <cyd@stupidchicken.com>
2099
2100 * dispnew.c (add_window_display_history): Use BVAR.
2101
2102 * xdisp.c (debug_method_add): Use BVAR.
2103 (check_window_end, dump_glyph_matrix, dump_glyph)
2104 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2105
2106 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2107 Likewise.
2108
2109 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2110 check till after the cache is created in init_frame_faces.
2111
ff2bc410
SM
21122011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2113
2114 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2115
28177add
PE
21162011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2117
dd3482fe
PE
2118 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2119 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2120 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2121
393d71f3 2122 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2123 * fileio.c (Finsert_file_contents):
2124 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2125 Remove the old (too-loose) buffer overflow checks.
2126 They weren't needed, since make_gap checks for buffer overflow.
2127 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2128 The old code merely checked for Emacs fixnum overflow, and relied
2129 on undefined (wraparound) behavior. The new code avoids undefined
2130 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2131
2e6813b0 2132 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2133 Tune. Don't use wider integers than needed. Don't use alloca.
2134 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2135
599a9e4f
PE
2136 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2137
99561444
PE
2138 * insdel.c, lisp.h (buffer_overflow): New function.
2139 (insert_from_buffer_1, replace_range, replace_range_2):
2140 * insdel.c (make_gap_larger):
2141 * editfns.c (Finsert_char):
2142 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2143
28177add
PE
2144 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2145
e69dafad
PE
21462011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2147
a7af7fde 2148 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2149
b1c46f02
PE
2150 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2151 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2152
e69dafad
PE
2153 * fileio.c: Don't assume EMACS_INT fits in off_t.
2154 (emacs_lseek): New static function.
2155 (Finsert_file_contents, Fwrite_region): Use it.
2156 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2157
566684ea
PE
2158 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2159
e6966cd6
PE
2160 * fns.c: Don't overflow int when computing a list length.
2161 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2162 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2163 truncation on 64-bit hosts. Check for QUIT every
2164 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2165 faster and is responsive enough.
2166 (Flength): Report an error instead of overflowing an integer.
2167 (Fsafe_length): Return a float if the value is not representable
2168 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 2169 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 2170 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 2171
dd0b0efb
PE
2172 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2173 (header_size, word_size): New constants.
2174 (allocate_vectorlike): Don't check size overflow here.
2175 (allocate_vector): Check it here instead, since this is the only
2176 caller of allocate_vectorlike that could cause overflow.
2177 Check that the new vector's length is representable as a fixnum.
2178
86fe5cfe
PE
2179 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2180 The previous code was bogus. For example, next_almost_prime (32)
2181 returned 39, which is undesirable as it is a multiple of 3; and
2182 next_almost_prime (24) returned 25, which is a multiple of 5 so
2183 why was the code bothering to check for multiples of 7?
2184
80e88859
PE
2185 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2186
4a2f0ad6
PE
2187 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2188
f66c7cf8
PE
2189 Variadic C functions now count arguments with ptrdiff_t.
2190 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2191 Back then I didn't know that the Emacs coding style prefers signed int.
2192 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
2193 were being counted with int, which may truncate counts on 64-bit
2194 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
2195 * lisp.h (struct Lisp_Subr.function.aMANY)
2196 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2197 Arg counts are now ptrdiff_t, not size_t.
2198 All variadic functions and their callers changed accordingly.
2199 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2200 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2201 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2202 * callint.c (Fcall_interactively): Check arg count for overflow,
2203 to avoid potential buffer overrun. Use signed char, not 'int',
2204 for 'varies' array, so that we needn't bother to check its size
2205 calculation for overflow.
2206 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2207 * eval.c (apply_lambda):
2208 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2209 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2210 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2211
a1759b76
PE
2212 * callint.c (Fcall_interactively): Don't use index var as event count.
2213
d96be9fc
PE
2214 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2215 * mem-limits.h (SIZE): Remove; no longer used.
2216
a690a978 2217 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 2218
578c21e6
PE
2219 Remove unnecessary casts.
2220 * xterm.c (x_term_init):
2221 * xfns.c (x_set_border_pixel):
2222 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2223 These aren't needed now that we assume ANSI C.
2224
96f53c6c
PE
2225 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2226 It's more likely to cause problems (due to unsigned overflow)
2227 than to cure them.
2228
83c77d31
PE
2229 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2230
ee2079f1
PE
2231 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2232
6da65536
PE
2233 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2234
7147c4a4
PE
2235 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2236
193e32d9
PE
2237 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2238
e5533da6
PE
2239 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2240
9910e595
PE
2241 GLYPH_CODE_FACE returns EMACS_INT, not int.
2242 * dispextern.h (merge_faces):
2243 * xfaces.c (merge_faces):
01103c44
PE
2244 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2245 Don't assume EMACS_INT fits in int.
9910e595 2246
2638320e
PE
2247 * character.h (CHAR_VALID_P): Remove unused parameter.
2248 * fontset.c, lisp.h, xdisp.c: All uses changed.
2249
045eb8d9
PE
2250 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2251
c1f134b5
PE
2252 * fns.c (concat): Minor tuning based on overflow analysis.
2253 This doesn't fix any bugs. Use int to hold character, instead
2254 of constantly refetching from Emacs object. Use XFASTINT, not
2255 XINT, for value known to be a character. Don't bother comparing
2256 a single byte to 0400, as it's always less.
2257
395fcb93 2258 * floatfns.c (Fexpt):
327eeec8
PE
2259 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2260
abbd3d23
PE
2261 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2262 for characters.
2263
684a03ef
PE
2264 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2265
0fed43f3
PE
2266 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2267 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2268 incorrectly succeed when S was a string, because 4294967386 was
2269 truncated before it was used.
2270
8fd02eb7
PE
2271 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2272 Otherwise, an out-of-range integer could cause undefined behavior
2273 on a 64-bit host.
2274
f8c86b69
PE
2275 * composite.c: Use int, not EMACS_INT, for characters.
2276 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2277 EMACS_INT, for values that are known to be in character range.
2278 This doesn't fix any bugs but is the usual style inside Emacs and
2279 may generate better code on 32-bit machines.
2280
34206dd2
PE
2281 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2282 This is for reasons similar to the recent CHAR_STRING fix.
2283 * charset.c (Fencode_char): Check that character arg is actually
2284 a character. Pass an int to ENCODE_CHAR.
2285 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2286 wider than 'int', as a compile-time check to prevent future regressions
2287 in this area.
2288
c5958d4c 2289 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2290
2291 Make sure a 64-bit char is never passed to CHAR_STRING.
2292 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2293 by silently ignoring the top 32 bits, allowing some values
2294 that were far too large to be valid characters.
2295 * character.h: Include <verify.h>.
2296 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2297 arguments are no wider than unsigned, as a compile-time check
2298 to prevent future regressions in this area.
2299 * data.c (Faset):
01103c44 2300 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2301 (Fsubst_char_in_region):
2302 * fns.c (concat):
2303 * xdisp.c (decode_mode_spec_coding):
2304 Adjust to CHAR_STRING's new requirement.
2305 * editfns.c (Finsert_char, Fsubst_char_in_region):
2306 * fns.c (concat): Check that character args are actually
2307 characters. Without this test, these functions did the wrong
2308 thing with wildly out-of-range values on 64-bit hosts.
2309
d37ca623
PE
2310 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2311 These casts should not be needed on 32-bit hosts, either.
2312 * keyboard.c (read_char):
2313 * lread.c (Fload): Remove casts to unsigned.
2314
ea204efb
PE
2315 * lisp.h (UNSIGNED_CMP): New macro.
2316 This fixes comparison bugs on 64-bit hosts.
2317 (ASCII_CHAR_P): Use it.
2318 * casefiddle.c (casify_object):
01103c44 2319 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2320 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2321 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2322 * dispextern.h (FACE_FROM_ID):
2323 * keyboard.c (read_char): Use UNSIGNED_CMP.
2324
41cb286c
PE
2325 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2326 not to EMACS_INT, to avoid GCC warning.
2327
4a1b9832
PE
2328 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2329
55daad71
PE
2330 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2331 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2332 isn't needed on 32-bit machines.
8f95c75c 2333
01103c44
PE
2334 * buffer.c (Fgenerate_new_buffer_name):
2335 Use EMACS_INT for count, not int.
0ceccced 2336 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2337
2338 * data.c (Qcompiled_function): Now static.
2339
c6f072e7
PE
2340 * window.c (window_body_lines): Now static.
2341
20ce5912
PE
2342 * image.c (gif_load): Rename local to avoid shadowing.
2343
9c4c5f81
PE
2344 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2345 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2346 * alloc.c (make_save_value): Integer argument is now of type
2347 ptrdiff_t, not int.
2348 (mark_object): Use ptrdiff_t, not int.
2349 * lisp.h (pD): New macro.
2350 * print.c (print_object): Use it.
2351
c0c5c8ae
PE
2352 * alloc.c: Use EMACS_INT, not int, to count objects.
2353 (total_conses, total_markers, total_symbols, total_vector_size)
2354 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2355 (total_free_floats, total_floats, total_free_intervals)
2356 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2357 Now EMACS_INT, not int. All uses changed.
2358 (Fgarbage_collect): Compute overall total using a double, so that
2359 integer overflow is less likely to be a problem. Check for overflow
2360 when converting back to an integer.
5a25e253
PE
2361 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2362 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2363 These were 'int' variables that could overflow on 64-bit hosts;
2364 they were never used, so remove them instead of repairing them.
211a0b2a 2365 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2366 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2367 Previously, this ceilinged at INT_MAX, but that doesn't work on
2368 64-bit machines.
e46bb31a 2369 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2370
c78baabf 2371 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2372 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2373 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2374 when a (possibly-narrower) signed value would do just as well.
2375 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2376
c9d624c6
PE
2377 * alloc.c: Catch some string size overflows that we were missing.
2378 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2379 for convenience in STRING_BYTES_MAX.
2380 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2381 The definition here is exact; the one in lisp.h was approximate.
2382 (allocate_string_data): Check for string overflow. This catches
2383 some instances we weren't catching before. Also, it catches
2384 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2385 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2386 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2387
c9d624c6
PE
2388 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2389 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2390 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2391
353032ce
PE
2392 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2393
2bccce07
PE
2394 * alloc.c (Fmake_string): Check for out-of-range init.
2395
0ac30604
SM
23962011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2399
c195f2de
JD
24002011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2401
2402 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2403 xg_get_default_scrollbar_width.
2404
2405 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2406 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2407 (style_changed_cb): Call update_theme_scrollbar_width and call
2408 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2409 all frames (Bug#8505).
2410 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2411 Call gtk_window_set_resizable if HAVE_GTK3.
2412 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2413 and height if HAVE_GTK3 (Bug#8505).
2414 (scroll_bar_width_for_theme): New variable.
2415 (update_theme_scrollbar_width): New function.
2416 (xg_get_default_scrollbar_width): Move code to
2417 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2418 (xg_initialize): Call update_theme_scrollbar_width.
2419
2420 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2421
2422 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2423
e10ac9f1
MR
24242011-06-12 Martin Rudalics <rudalics@gmx.at>
2425
2426 * frame.c (make_frame): Call other_buffer_safely instead of
2427 other_buffer.
2428
2429 * window.c (temp_output_buffer_show): Call display_buffer with
2430 second argument Vtemp_buffer_show_specifiers and reset latter
2431 immediately after the call.
2432 (Vtemp_buffer_show_specifiers): New variable.
2433 (auto_window_vscroll_p, next_screen_context_lines)
2434 (Vscroll_preserve_screen_position): Remove leading asterisks from
2435 doc-strings.
2436
2d3c217e 24372011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2438
7b7f97e8 2439 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2440 * buffer.c (Qclone_number): Remove for now, as it's unused.
2441 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2442 (record_buffer): Remove unused local.
2443 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2444 (set_frame_buffer_list): Remove; unused.
2445 * frame.h (other_visible_frames): Remove decl.
2446 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2447 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2448 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2449 if HAVE_GPM.
2450 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2451 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2452 Define only if HAVE_GPM.
2453 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2454 (update_hints_inhibit): Remove; never set. All uses removed.
2455 * widgetprv.h (emacsFrameClassRec): Remove decl.
2456 * window.c (delete_deletable_window): Now returns void, since it
2457 wasn't returning anything.
2458 (compare_window_configurations): Remove unused locals.
2459 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2460 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2461 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2462 the same widths as pointers. This follows up on the 2011-05-06 patch.
2463 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2464 * xterm.h: Likewise.
2465 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2466
1384b89e
JB
24672011-06-12 Juanma Barranquero <lekktu@gmail.com>
2468
2469 * makefile.w32-in: Update dependencies.
2470 (LISP_H): Add lib/intprops.h.
2471
1100a63c
CY
24722011-06-11 Chong Yidong <cyd@stupidchicken.com>
2473
2474 * image.c (gif_load): Add animation frame delay to the metadata.
2475 (syms_of_image): Use DEFSYM. New symbol `delay'.
2476
6198ccd0
MR
24772011-06-11 Martin Rudalics <rudalics@gmx.at>
2478
2479 * window.c (delete_deletable_window): Re-add.
2480 (Fset_window_configuration): Rewrite to handle dead buffers and
2481 consequently deletable windows.
2482 (window_tree, Fwindow_tree): Remove. Supply functionality in
2483 window.el.
2484 (compare_window_configurations): Simplify code.
2485
b6e3633c
AS
24862011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2487
1ab0dee5
AS
2488 * image.c (imagemagick_load_image): Fix type mismatch.
2489 (Fimagemagick_types): Likewise.
2490
b6e3633c
AS
2491 * window.h (replace_buffer_in_windows): Declare.
2492
9397e56f
MR
24932011-06-11 Martin Rudalics <rudalics@gmx.at>
2494
2495 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2496 Qclone_number. Remove external declaration of Qdelete_window.
2497 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2498 code.
640c8776
SM
2499 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2500 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2501 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2502 buffer list implementation.
2503 (other_buffer_safely): New function.
2504 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2505 calls to replace_buffer_in_windows and
2506 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2507 if allowed.
2508 (record_buffer): Inhibit quitting and rewrite using quittable
2509 functions. Run Qbuffer_list_update_hook if allowed.
2510 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2511 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2512 Move switch-to-buffer to window.el.
9397e56f
MR
2513 (bury-buffer): Move to window.el.
2514 (Vbuffer_list_update_hook): New variable.
2515
2516 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2517 section.
2518
2519 * window.h (resize_frame_windows): Move up in code.
2520 (Fwindow_frame): Remove EXFUN.
2521 (replace_buffer_in_all_windows): Remove prototype.
2522 (replace_buffer_in_windows_safely): Add prototype.
2523
2524 * window.c: Declare Qdelete_window static again. Move down
2525 declaration of select_count.
2526 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2527 (Fother_window): Move to window.el.
2528 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2529 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2530 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2531 window.el.
2532 (replace_buffer_in_windows): Implement by calling
2533 Qreplace_buffer_in_windows.
2534 (replace_buffer_in_all_windows): Remove with some functionality
2535 moved into replace_buffer_in_windows_safely.
2536 (replace_buffer_in_windows_safely): New function.
2537 (select_window_norecord, select_frame_norecord): Move in front
2538 of run_window_configuration_change_hook. Remove now obsolete
2539 declarations.
640c8776
SM
2540 (Fset_window_buffer): Rewrite doc-string.
2541 Call Qrecord_window_buffer.
9397e56f
MR
2542 (keys_of_window): Move binding for other-window to window.el.
2543
b50691aa
CY
25442011-06-11 Chong Yidong <cyd@stupidchicken.com>
2545
2546 * dispextern.h (struct image): Replace data member, whose int_val
2547 and ptr_val fields were not used by anything, with a single
2548 lisp_val object.
2549
2550 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2551 (gif_clear_image, gif_load, imagemagick_load_image)
2552 (gs_clear_image, gs_load): Callers changed.
2553
3f754b86
PE
25542011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2555
cca69397
PE
2556 * buffer.h: Include <time.h>, for time_t.
2557 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2558
109e28d0
PE
2559 Fix minor problems found by static checking.
2560
60737f02
PE
2561 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2562
4b66faf3
PE
2563 Make identifiers static if they are not used in other modules.
2564 * data.c (Qcompiled_function, Qframe, Qvector):
2565 * image.c (QimageMagick, Qsvg):
2566 * minibuf.c (Qmetadata):
2567 * window.c (resize_window_check, resize_root_window): Now static.
2568 * window.h (resize_window_check, resize_root_window): Remove decls.
2569
109e28d0
PE
2570 * window.c (window_deletion_count, delete_deletable_window):
2571 Remove; unused.
46a4ce9e
PE
2572 (window_body_lines): Now static.
2573 (Fdelete_other_windows_internal): Mark vars as initialized.
2574 Make sure 'resize_failed' is initialized.
2575 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2576 (resize_window_apply): Remove unused local.
2577 * window.h (delete_deletable_window): Remove decl.
2578
109e28d0 2579 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2580 (imagemagick_load_image): Fix pointer signedness problem by changing
2581 last arg from unsigned char * to char *. All uses changed.
2582 Also, fix a local for similar reasons.
2583 Remove unused locals. Remove locals to avoid shadowing.
2584 (fn_rsvg_handle_free): Remove; unused.
2585 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2586 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2587
3f754b86
PE
2588 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2589
2547adb1
CY
25902011-06-10 Chong Yidong <cyd@stupidchicken.com>
2591
2592 * image.c (gif_load): Fix omitted cast error introduced by
2593 2011-06-06 change.
2594
2c8e37d4
MR
25952011-06-10 Martin Rudalics <rudalics@gmx.at>
2596
2597 * window.h (resize_proportionally, orig_total_lines)
2598 (orig_top_line): Remove from window structure.
2599 (set_window_height, set_window_width, change_window_heights)
2600 (Fdelete_window): Remove prototypes.
2601 (resize_frame_windows): Remove duplicate declaration.
2602
440a42e3
EZ
26032011-06-10 Eli Zaretskii <eliz@gnu.org>
2604
2605 * window.h (resize_frame_windows, resize_window_check)
2606 (delete_deletable_window, resize_root_window)
2607 (resize_frame_windows): Declare prototypes.
2608
2609 * window.c (resize_window_apply): Make definition be "static" to
2610 match the prototype.
2611
562dd5e9
MR
26122011-06-10 Martin Rudalics <rudalics@gmx.at>
2613
2614 * window.c: Remove declarations of Qwindow_size_fixed,
2615 window_min_size_1, window_min_size_2, window_min_size,
2616 size_window, window_fixed_size_p, enlarge_window, delete_window.
2617 Remove static from declaration of Qdelete_window, it's
2618 temporarily needed by Fbury_buffer.
2619 (replace_window): Don't assign orig_top_line and
2620 orig_total_lines.
2621 (Fdelete_window, delete_window): Remove. Window deletion is
2622 handled by window.el.
640c8776
SM
2623 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2624 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2625 (Fdelete_other_windows): Remove. Deleting other windows is
2626 handled by window.el.
2627 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2628 handled in window.el.
2629 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2630 Window minimum sizes are handled in window.el.
2631 (shrink_windows, size_window, set_window_height)
2632 (set_window_width, change_window_heights, window_height)
2633 (window_width, CURBEG, CURSIZE, enlarge_window)
2634 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2635 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2636 handled in window.el.
2637 (make_dummy_parent): Rename to make_parent_window and give it a
2638 second argument horflag.
2639 (make_window): Don't set resize_proportionally any more.
2640 (Fsplit_window): Remove. Windows are split in window.el.
2641 (save_restore_action, save_restore_orig_size)
2642 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2643 Resize mini windows in window.el.
2644 (grow_mini_window, shrink_mini_window): Implement by calling
2645 Qresize_root_window_vertically, resize_window_check and
2646 resize_window_apply.
640c8776
SM
2647 (saved_window, Fset_window_configuration, save_window_save):
2648 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2649 resize_proportionally.
2650 (window_min_height, window_min_width): Move to window.el.
2651 (keys_of_window): Move bindings for delete-other-windows,
2652 split-window, delete-window and enlarge-window to window.el.
2653
2654 * buffer.c: Temporarily extern Qdelete_window.
2655 (Fbury_buffer): Temporarily call Qdelete_window instead of
2656 Fdelete_window (Fbury_buffer will move to window.el soon).
2657
2658 * frame.c (set_menu_bar_lines_1): Remove code handling
2659 orig_top_line and orig_total_lines.
2660
2661 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2662 set_window_height but set heights directly.
2663 (change_frame_size_1): Use resize_frame_windows.
2664
2665 * xdisp.c (init_xdisp): Don't use set_window_height but set
2666 heights directly.
2667
640c8776
SM
2668 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2669 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2670 run_window_configuration_change_hook.
2671
2672 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2673 instead of change_window_heights and run
2674 run_window_configuration_change_hook.
2675
1a13852e
MR
26762011-06-09 Martin Rudalics <rudalics@gmx.at>
2677
2678 * window.c (replace_window): Rename second argument REPLACEMENT to
2679 NEW. New third argument SETFLAG. Rewrite.
2680 (delete_window, make_dummy_parent): Call replace_window with
2681 third argument 1.
2682 (window_list_1): Move down in code.
2683 (run_window_configuration_change_hook): Move set_buffer part
2684 before select_frame_norecord part in order to unwind correctly.
2685 Rename count1 to count.
2686 (recombine_windows, delete_deletable_window, resize_root_window)
2687 (Fdelete_other_windows_internal)
2688 (Frun_window_configuration_change_hook, make_parent_window)
2689 (resize_window_check, resize_window_apply, Fresize_window_apply)
2690 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2691 (Fdelete_window_internal, Fresize_mini_window_internal):
2692 New functions.
1a13852e
MR
2693 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2694
f3d1777e
MR
26952011-06-08 Martin Rudalics <rudalics@gmx.at>
2696
496e208e
MR
2697 * window.h (window): Add some new members to window structure -
2698 normal_lines, normal_cols, new_total, new_normal, clone_number,
2699 splits, nest, prev_buffers, next_buffers.
2700 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2701 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2702
f3d1777e
MR
2703 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2704 Remove.
496e208e
MR
2705 (make_dummy_parent): Set new members of windows structure.
2706 (make_window): Move down in code. Handle new members of window
2707 structure.
2708 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2709 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2710 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2711 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2712 (Fset_window_next_buffers, Fset_window_clone_number):
2713 New functions.
496e208e
MR
2714 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2715 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2716 Doc-string fixes.
2717 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2718 Argument WINDOW can be now internal window too.
2719 (Fwindow_use_time): Move up in code.
2720 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2721 Rewrite doc-string.
2722 (Fset_window_configuration, saved_window)
2723 (Fcurrent_window_configuration, save_window_save): Handle new
2724 members of window structure.
b9e809c2
MR
2725 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2726 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2727 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2728 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2729 Qget_mru_window, Qresize_root_window,
2730 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2731 Qauto_buffer_name; staticpro them.
f3d1777e 2732
abde8f8c
MR
27332011-06-07 Martin Rudalics <rudalics@gmx.at>
2734
2735 * window.c (Fwindow_total_size, Fwindow_left_column)
2736 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2737 (Fwindow_list_1): New functions.
2738 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2739 (Fwindow_width, Fscroll_left, Fscroll_right):
2740 Use window_body_cols instead of window_box_text_cols.
2741 (delete_window, Fset_window_configuration):
2742 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2743 (delete_all_subwindows): Take a window as argument and not a
2744 structure. Rewrite.
190b47e6
MR
2745 (window_loop): Remove handling of GET_LRU_WINDOW and
2746 GET_LARGEST_WINDOW.
2747 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2748
2749 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2750 window_box_text_cols. delete_all_subwindows now takes a
2751 Lisp_Object as argument.
abde8f8c 2752
640c8776
SM
2753 * indent.c (compute_motion, Fcompute_motion):
2754 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2755
fa8a67e6
MR
2756 * frame.c (delete_frame): Call delete_all_subwindows with root
2757 window as argument.
2758
a54e3482
DC
27592011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2760
2761 * fns.c (Fputhash): Document return value.
2762
60002bf5
CY
27632011-06-06 Chong Yidong <cyd@stupidchicken.com>
2764
2765 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2766
0c671da6 27672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2768
b862a52a 2769 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2770
be44ca6c
PE
2771 Check for overflow when converting integer to cons and back.
2772 * charset.c (Fdefine_charset_internal, Fdecode_char):
2773 Use cons_to_unsigned to catch overflow.
2774 (Fencode_char): Use INTEGER_TO_CONS.
2775 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2776 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2777 * data.c (long_to_cons, cons_to_long): Remove.
2778 (cons_to_unsigned, cons_to_signed): New functions.
2779 These signal an error for invalid or out-of-range values.
2780 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2781 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2782 * font.c (Ffont_variation_glyphs):
2783 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2784 * lisp.h: Include <intprops.h>.
2785 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2786 (cons_to_signed, cons_to_unsigned): New decls.
2787 (long_to_cons, cons_to_long): Remove decls.
2788 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2789 (Fprimitive_undo): Use CONS_TO_INTEGER.
2790 * xfns.c (Fx_window_property): Likewise.
2791 * xselect.c: Include <limits.h>.
2792 (x_own_selection, selection_data_to_lisp_data):
2793 Use INTEGER_TO_CONS.
2794 (x_handle_selection_request, x_handle_selection_clear)
2795 (x_get_foreign_selection, Fx_disown_selection_internal)
2796 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2797 (lisp_data_to_selection_data): Use cons_to_unsigned.
2798 (x_fill_property_data): Use cons_to_signed.
2799 Report values out of range.
2800
d1f3d2af
PE
2801 Check for buffer and string overflow more precisely.
2802 * buffer.h (BUF_BYTES_MAX): New macro.
2803 * lisp.h (STRING_BYTES_MAX): New macro.
2804 * alloc.c (Fmake_string):
2805 * character.c (string_escape_byte8):
2806 * coding.c (coding_alloc_by_realloc):
2807 * doprnt.c (doprnt):
2808 * editfns.c (Fformat):
2809 * eval.c (verror):
2810 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2811 since they may not be the same number.
2812 * editfns.c (Finsert_char):
2813 * fileio.c (Finsert_file_contents):
2814 Likewise for BUF_BYTES_MAX.
2815
dd52fcea
PE
2816 * image.c: Use ptrdiff_t, not int, for sizes.
2817 (slurp_file): Switch from int to ptrdiff_t.
2818 All uses changed.
2819 (slurp_file): Check that file size fits in both size_t (for
2820 malloc) and ptrdiff_t (for sanity and safety).
2821
7f9bbdbb
PE
2822 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2823 if b->modtime has its maximal value.
2824
dfe18f82
PE
2825 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2826
84acfcf0
PE
2827 Don't assume time_t can fit into int.
2828 * buffer.h (struct buffer.modtime): Now time_t, not int.
2829 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2830 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2831
ccd9a01a
PE
2832 Minor fixes for signed vs unsigned integers.
2833 * character.h (MAYBE_UNIFY_CHAR):
2834 * charset.c (maybe_unify_char):
2835 * keyboard.c (read_char, reorder_modifiers):
2836 XINT -> XFASTINT, since the integer must be nonnegative.
2837 * ftfont.c (ftfont_spec_pattern):
2838 * keymap.c (access_keymap, silly_event_symbol_error):
2839 XUINT -> XFASTINT, since the integer must be nonnegative.
2840 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2841 since it makes no difference and we prefer signed.
2842 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2843 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2844 nonnegative.
2845
d6d100dd
SM
28462011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2847
2848 * window.h (Fwindow_frame): Declare.
2849
2b6148e4
PE
28502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2853 (SPARE_MEMORY): Always define.
2854 (LARGE_REQUEST): Remove.
2855 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2856
f230ecc9
MR
28572011-06-06 Martin Rudalics <rudalics@gmx.at>
2858
727e958e
MR
2859 * lisp.h: Move EXFUNS for Fframe_root_window,
2860 Fframe_first_window and Fset_frame_selected_window to window.h.
2861
2862 * window.h: Move EXFUNS for Fframe_root_window,
2863 Fframe_first_window and Fset_frame_selected_window here from
2864 lisp.h.
2865
2866 * frame.c (Fwindow_frame, Fframe_first_window)
2867 (Fframe_root_window, Fframe_selected_window)
2868 (Fset_frame_selected_window): Move to window.c.
2869 (Factive_minibuffer_window): Move to minibuf.c.
2870 (Fother_visible_frames_p): New function.
2871
2872 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2873
f230ecc9
MR
2874 * window.c (decode_window, decode_any_window): Move up in code.
2875 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2876 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2877 (Fwindow_buffer): Move up and rewrite doc-string.
2878 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2879 (Fwindow_prev): New functions.
727e958e
MR
2880 (Fwindow_frame): Move here from frame.c. Accept any window as
2881 argument.
2882 (Fframe_root_window, Fframe_first_window)
2883 (Fframe_selected_window): Move here from frame.c. Accept frame
2884 or arbitrary window as argument. Update doc-strings.
2885 (Fminibuffer_window): Move up in code.
2886 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2887 (Fset_frame_selected_window): Move here from frame.c.
2888 Marginal rewrite.
727e958e
MR
2889 (Fselected_window, select_window, Fselect_window): Move up in
2890 code. Minor doc-string fixes.
f230ecc9 2891
4d09bcf6
PE
28922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2895 Do not assume that spare memory exists; that assumption is valid
2896 only if SYSTEM_MALLOC.
2897 (LARGE_REQUEST): New macro, so that the issue of large requests
2898 is separated from the issue of spare memory.
2899
810928a2
AS
29002011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2901
172418ad
AS
2902 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2903 format. (Bug#8806)
2904
43f862f7
AS
2905 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2906
810928a2
AS
2907 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2908 before statements.
2909
a059fe24
JD
29102011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2911
2912 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2913
2914 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2915
2916 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2917 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2918
989bf368
JB
29192011-06-05 Juanma Barranquero <lekktu@gmail.com>
2920
2921 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2922
4b80f674
CY
29232011-06-04 Chong Yidong <cyd@stupidchicken.com>
2924
2925 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2926 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2927 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2928 New error handlers.
4b80f674
CY
2929 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2930 Obey Vx_select_enable_clipboard_manager. Catch errors in
2931 x_clipboard_manager_save (Bug#8779).
2932 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2933 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2934
99a33b77 29352011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2936
2937 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2938
99a33b77 29392011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2940
2941 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2942 in the current matrix if keep_current_p is non-zero.
2943
8264569d
EZ
29442011-06-04 Eli Zaretskii <eliz@gnu.org>
2945
2946 * bidi.c (bidi_level_of_next_char): Fix last change.
2947
57f97249
EZ
29482011-06-03 Eli Zaretskii <eliz@gnu.org>
2949
fec2107c 2950 Support bidi reordering of text covered by display properties.
57f97249 2951
fec2107c
EZ
2952 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2953 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2954 (bidi_cache_search, bidi_cache_iterator_state)
2955 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2956 (bidi_level_of_next_char, bidi_move_to_visually_next):
2957 Support character positions inside a run of characters covered by a
fec2107c
EZ
2958 display string.
2959 (bidi_paragraph_init, bidi_resolve_explicit_1)
2960 (bidi_level_of_next_char): Call bidi_fetch_char and
2961 bidi_fetch_char_advance instead of FETCH_CHAR and
2962 FETCH_CHAR_ADVANCE.
2963 (bidi_init_it): Initialize new members.
2964 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2965 definitions.
2966 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2967 instead of using explicit *_CHAR codes.
d6d100dd
SM
2968 (bidi_resolve_explicit, bidi_resolve_weak):
2969 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2970 bidirectional text is supported only in multibyte buffers.
2971 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2972 it to initialize the frame_window_p member of struct bidi_it.
2973 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2974 (bidi_resolve_explicit, bidi_resolve_weak)
2975 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2976 bidi_it->nchars is non-positive.
2977 (bidi_level_of_next_char): Don't try to lookup the cache for the
2978 next/previous character if nothing is cached there yet, or if we
2979 were just reseat()'ed to a new position.
c40e2fb2 2980
0e14fe90
EZ
2981 * xdisp.c (set_cursor_from_row): Set start and stop points
2982 according to the row's direction when priming the loop that looks
2983 for the glyph on which to display cursor.
2984 (single_display_spec_intangible_p): Function deleted.
2985 (display_prop_intangible_p): Reimplement to call
2986 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2987 Accept 3 additional arguments needed by handle_display_spec.
2988 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2989 values: lists, `(when COND...)' forms, etc.
2990 (single_display_spec_string_p): Support property values that are
2991 lists with the argument STRING its top-level element.
2992 (display_prop_string_p): Fix the condition for processing a
2993 property that is a list to be consistent with handle_display_spec.
fec2107c 2994 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2995 last portion of handle_display_prop.
2996 (compute_display_string_pos): Accept additional argument
2997 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2998 value of a `display' property is a "replacing spec".
2999 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3000 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3001 the display property, but just return a value indicating whether
3002 the display property will replace the characters it covers.
3003 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3004 frame_window_p members of struct bidi_it.
d6d100dd
SM
3005 (compute_display_string_pos, compute_display_string_end):
3006 New functions.
fec2107c
EZ
3007 (push_it): Accept second argument POSITION, where pop_it should
3008 jump to continue iteration.
3009 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3010
fec2107c
EZ
3011 * keyboard.c (adjust_point_for_property): Adjust the call to
3012 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3013
3014 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3015 (bidi_init_it): Update prototypes.
3016 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3017 (compute_display_string_pos, compute_display_string_end):
3018 Declare prototypes.
fec2107c
EZ
3019 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3020 EMACS_INT.
fc6f18ce 3021
40087514 30222011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3023
57f53182
PE
3024 Malloc failure behavior now depends on size of allocation.
3025 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3026 * lisp.h: Change signatures accordingly.
3027 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3028 All callers changed. (Bug#8762)
3029
3030 * gnutls.c: Use Emacs's memory allocators.
3031 Without this change, the gnutls library would invoke malloc etc.
3032 directly, which causes problems on non-SYNC_INPUT hosts, and which
3033 runs afoul of improving memory_full behavior. (Bug#8761)
3034 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3035 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3036 xfree instead of the default malloc, realloc, free.
3037 (Fgnutls_boot): No need to check for memory allocation failure,
3038 since xmalloc does that for us.
3039
ac32cd99 3040 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3041 * category.c (hash_get_category_set):
3042 * ccl.c (ccl_driver):
3043 * charset.c (Fdefine_charset_internal):
3044 * charset.h (struct charset.hash_index):
3045 * composite.c (get_composition_id, gstring_lookup_cache)
3046 (composition_gstring_put_cache):
3047 * composite.h (struct composition.hash_index):
3048 * dispextern.h (struct image.hash):
3049 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3050 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3051 (hashfn_equal, hashfn_user_defined, make_hash_table)
3052 (maybe_resize_hash_table, hash_lookup, hash_put)
3053 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3054 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3055 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3056 * image.c (make_image, search_image_cache, lookup_image)
3057 (xpm_put_color_table_h):
3058 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3059 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3060 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3061 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3062 * alloc.c (allocate_vectorlike):
3063 Check for overflow in vector size calculations.
3064 * ccl.c (ccl_driver):
3065 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3066 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3067 need to be updated by these changes.
40087514
PE
3068 * fns.c (make_hash_table, maybe_resize_hash_table):
3069 Check for integer overflow with large hash tables.
0de4bb68
PE
3070 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3071 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3072 (SXHASH_REDUCE): New macro.
3073 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3074 Use it instead of discarding useful hash info with large hash values.
3075 (sxhash_float): New function.
3076 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3077 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3078 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3079 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3080 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3081 Adjust signatures to match updated version of code.
3082 (consing_since_gc): Now EMACS_INT, since a single hash table can
3083 use more than INT_MAX bytes.
3084
698d32e2
DN
30852011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3086
3087 Make it possible to build with GCC-4.6+ -O2 -flto.
3088
3089 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3090
fd6fa53f
SM
30912011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3092
3093 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3094 Call minibuffer-inactive-mode.
3095
864db017
JB
30962011-05-31 Juanma Barranquero <lekktu@gmail.com>
3097
3098 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3099 Update dependencies.
3100
2ad0baf4
DN
31012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3102
3103 * data.c (init_data): Remove code for UTS, this system is not
3104 supported anymore.
3105
4fcc2638
DN
31062011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3107
3108 Don't force ./temacs to start in terminal mode.
3109
3110 * frame.c (make_initial_frame): Initialize faces in all cases, not
3111 only when CANNOT_DUMP is defined.
3112 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3113
c56e0fd5
DN
31142011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3115
3116 * dispnew.c (add_window_display_history): Use const for the string
3117 pointer. Remove declaration, not needed.
3118
333d54da 31192011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3120
55d4c1b2 3121 Use 'inline', not 'INLINE'.
333d54da 3122 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3123 * alloc.c, fontset.c (INLINE): Remove.
3124 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3125 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3126 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3127 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3128 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3129
738db178
DN
31302011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3131
3132 Make it possible to run ./temacs.
3133
3134 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3135 syms_of_callproc does the same thing. Remove test for
3136 "initialized", do it in the caller.
3137 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3138
620c53a6
SM
31392011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3140
3141 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3142 (read_minibuf): Use get_minibuffer.
3143 (syms_of_minibuf): Use DEFSYM.
3144 (Qmetadata): New var.
3145 * data.c (Qbuffer): Don't make it static.
3146 (syms_of_data): Use DEFSYM.
3147
e003a292
PE
31482011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3149
3150 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3151 (CCL_CODE_MIN): New macro.
3152
ed008a6d
PE
31532011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3154
3687c2ef
PE
3155 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3156
ed008a6d
PE
3157 * eval.c (Qdebug): Now static.
3158 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3159 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3160 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3161
d66c4c7c
CY
31622011-05-29 Chong Yidong <cyd@stupidchicken.com>
3163
3164 * image.c: Various fixes to ImageMagick code comments.
3165 (Fimagemagick_types): Doc fix.
3166
5fbc2025
PE
31672011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3168
0196f88a
PE
3169 Minor fixes prompted by GCC 4.6.0 warnings.
3170
3171 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3172
5fbc2025
PE
3173 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3174 (x_clipboard_manager_save_all): Move extern decl to ...
3175 * xterm.h: ... here, so that it can be checked for consistency.
3176
1dd3c2d9
CY
31772011-05-29 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * xselect.c (x_clipboard_manager_save_frame)
3180 (x_clipboard_manager_save_all): New functions.
3181 (Fx_clipboard_manager_save): Lisp function deleted.
3182
3183 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3184 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3185
3186 * xterm.h: Update prototype.
3187
5ba6571d
WX
31882011-05-28 William Xu <william.xwl@gmail.com>
3189
3190 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3191 exiting (Bug#8239).
3192
3eaff834
JM
31932011-05-28 Jim Meyering <meyering@redhat.com>
3194
e1900994 3195 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
3196 * fns.c (to_uchar): Define.
3197 (crypto_hash_function): Use it to convert some newly-signed
3198 variables to unsigned, to avoid sign-extension bugs. For example,
3199 without this change, (md5 "truc") would evaluate to
3200 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3201 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 3202 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 3203
0f6990a7
PE
32042011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 Integer overflow fixes.
c8a9ca5a 3207
08686060
PE
3208 * dbusbind.c: Serial number integer overflow fixes.
3209 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
3210 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3211 to hold a serial number that is too large for a fixnum.
3212 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3213 Check for serial numbers out of range. Decode any serial number
59568bf0 3214 that was so large that it became a float. (Bug#8722)
08686060 3215
2d1fc3c7
PE
3216 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3217 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3218 Use XFASTINT rather than XUINT when numbers are nonnegative.
3219 (xd_append_arg, Fdbus_method_return_internal):
3220 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3221 arguments, check that Lisp number is nonnegative, rather than
59568bf0 3222 silently wrapping negative numbers around. (Bug#8722)
30217ff0 3223 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 3224 (Bug#8722)
2d1fc3c7 3225
c8a9ca5a
PE
3226 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3227
519e1d69
PE
3228 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3229
30569699
PE
3230 ccl: add integer overflow checks
3231 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3232 (IN_INT_RANGE): New macros.
3233 (ccl_driver): Use them to check for integer overflow when
3234 decoding a CCL program. Many of the new checks are whether XINT (x)
3235 fits in int; it doesn't always, on 64-bit hosts. The new version
3236 doesn't catch all possible integer overflows, but it's an
847044ea 3237 improvement. (Bug#8719)
30569699 3238
c11285dc
PE
3239 * alloc.c (make_event_array): Use XINT, not XUINT.
3240 There's no need for unsigned here.
3241
fdccd48e
PE
3242 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3243 This follows up to the 2011-05-06 change that substituted uintptr_t
3244 for EMACS_INT. This case wasn't caught back then.
3245
37910ab2
PE
3246 Rework Fformat to avoid integer overflow issues.
3247 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3248 now (part of C89). Include <verify.h>.
3249 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3250 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3251 (Fformat): Avoid the prepass trying to compute sizes; it was only
3252 approximate and thus did not catch overflow reliably. Instead, walk
3253 through the format just once, formatting and computing sizes as we go,
3254 checking for integer overflow at every step, and allocating a larger
3255 buffer as needed. Keep track separately whether the format is
3256 multibyte. Keep only the most-recently calculated precision, rather
3257 than them all. Record whether each argument has been converted to
3258 string. Use EMACS_INT, not int, for byte and char and arg counts.
3259 Support field widths and precisions larger than INT_MAX. Avoid
3260 sprintf's undefined behavior with conversion specifications such as %#d
3261 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3262 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3263 formatting out-of-range floating point numbers with int
9173deec 3264 formats. (Bug#8668)
37910ab2 3265
2e6578fb
PE
3266 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3267
0ae6bdee
PE
3268 * data.c: Avoid integer truncation in expressions involving floats.
3269 * data.c: Include <intprops.h>.
3270 (arith_driver): When there's an integer overflow in an expression
3271 involving floating point, convert the integers to floating point
3272 so that the resulting value does not suffer from catastrophic
3273 integer truncation. For example, on a 64-bit host (* 4
3274 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3275 Do not rely on undefined behavior after integer overflow.
3276
de883a70
PE
3277 merge count_size_as_multibyte, parse_str_to_multibyte
3278 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3279 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3280 Check for integer overflow.
3281 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3282 since it's now a duplicate of the other. This is more of
3283 a character than a buffer op, so better that it's in character.c.
3284 * fns.c, print.c: Adjust to above changes.
3285
2ff916cb
PE
32862011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3287
3288 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3289
f1b54466
PE
32902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3291
fb1ac845
PE
3292 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3293 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3294 (x_clipboard_manager_save): Now static.
3295 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3296
f1b54466
PE
3297 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3298 (crypto_hash_function): Now static.
3299 Fix pointer signedness problems. Avoid unnecessary initializations.
3300
a9f737ee
CY
33012011-05-27 Chong Yidong <cyd@stupidchicken.com>
3302
3303 * termhooks.h (Vselection_alist): Make it terminal-local.
3304
3305 * terminal.c (create_terminal): Initialize it.
3306
3307 * xselect.c: Support for clipboard managers.
3308 (Vselection_alist): Move to termhooks.h as terminal-local var.
3309 (LOCAL_SELECTION): New macro.
3310 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3311 (symbol_to_x_atom): Remove gratuitous arg.
3312 (x_handle_selection_request, lisp_data_to_selection_data)
3313 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3314 (x_own_selection, x_get_local_selection, x_convert_selection):
3315 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3316 (some_frame_on_display): Delete unused function.
3317 (Fx_own_selection_internal, Fx_get_selection_internal)
3318 (Fx_disown_selection_internal, Fx_selection_owner_p)
3319 (Fx_selection_exists_p): New optional frame arg.
3320 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3321 (x_handle_selection_clear): Don't treat other terminals with the
3322 same keyboard specially. Use the terminal-local Vselection_alist.
3323 (x_clear_frame_selections): Use Frun_hook_with_args.
3324
3325 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3326
3327 * xterm.h: Add support for those atoms.
3328
e067f0c1
CY
33292011-05-26 Chong Yidong <cyd@stupidchicken.com>
3330
3331 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3332 (converted_selections, conversion_fail_tag): New global variables.
3333 (x_selection_request_lisp_error): Free the above.
3334 (x_get_local_selection): Remove unnecessary code.
3335 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3336 of converted selections stored in converted_selections.
3337 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3338 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3339 (x_convert_selection): New function.
3340 (x_handle_selection_event): Simplify.
3341 (x_get_foreign_selection): Don't ignore incoming requests while
3342 waiting for an answer; this will fail when we implement
3343 SAVE_TARGETS, and seems unnecessary anyway.
3344 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3345 (Vx_sent_selection_functions): Doc fix.
3346
0f4aebc0
LL
33472011-05-26 Leo Liu <sdl.web@gmail.com>
3348
3349 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3350
e61124cd
YM
33512011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3352
3353 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3354
3355 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3356 for fringe update if it has periodic bitmap.
ac389d0c 3357 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3358 and fringe_bitmap_periodic_p.
3359
3360 * fringe.c (get_fringe_bitmap_data): New function.
3361 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3362 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3363 row. Mark glyph row for fringe update if periodicity changed.
3364
3365 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3366 for fringe update unless it has periodic bitmap.
3367
f16d9837
KH
33682011-05-25 Kenichi Handa <handa@m17n.org>
3369
3370 * xdisp.c (get_next_display_element): Set correct it->face_id for
3371 a static composition.
3372
e1b90ef6
LL
33732011-05-24 Leo Liu <sdl.web@gmail.com>
3374
3375 * deps.mk (fns.o):
3376 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3377
3378 * fns.c (crypto_hash_function, Fsha1): New function.
3379 (Fmd5): Use crypto_hash_function.
3380 (syms_of_fns): Add Ssha1.
3381
7400048f
PE
33822011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 * gnutls.c: Remove unused macros.
3385 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3386 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3387 Remove macros that are defined and never used.
3388 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3389
abb71cf4
CY
33902011-05-22 Chong Yidong <cyd@stupidchicken.com>
3391
3392 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3393 (Fx_get_selection_internal): Minor cleanup.
3394 (Fx_own_selection_internal): Rename arguments for consistency with
3395 select.el.
3396
6307db39
PE
33972011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3398
3399 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3400
f3d4e0a4
CY
34012011-05-22 Chong Yidong <cyd@stupidchicken.com>
3402
3403 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3404
4d8ade89
YM
34052011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3406
3407 * dispnew.c (scrolling_window): Don't exclude the case that the
3408 last enabled row in the desired matrix touches the bottom boundary.
3409
32078c8d
GM
34102011-05-21 Glenn Morris <rgm@gnu.org>
3411
3412 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3413 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3414 and add some more files.
32078c8d 3415
7285dc67
EZ
34162011-05-20 Eli Zaretskii <eliz@gnu.org>
3417
3418 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3419 report_file_error introduced by the change from 2011-05-07.
3420
89d1bd22
PE
34212011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 * systime.h (Time): Define only if emacs is defined.
3424 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3425 where the include path doesn't have X11/X.h by default. See
3426 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3427
e23640bb 34282011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3429
3430 * composite.c (find_automatic_composition): Fix previous change.
3431
b9704ad9
GM
34322011-05-20 Glenn Morris <rgm@gnu.org>
3433
3434 * lisp.mk: New file, split from Makefile.in.
3435 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3436 (shortlisp): Remove.
3437 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3438
4a720484
GM
34392011-05-19 Glenn Morris <rgm@gnu.org>
3440
3441 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3442 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3443 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3444 (lisp): Set the order to that of loadup.el.
3445 (shortlisp): Make it a copy of $lisp.
3446 (SOME_MACHINE_LISP): Remove.
3447 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3448 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3449
a28d4396
KH
34502011-05-18 Kenichi Handa <handa@m17n.org>
3451
3452 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3453 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3454 (find_automatic_composition): Mostly rewrite for efficiency.
3455
a2b1fa8e
JB
34562011-05-18 Juanma Barranquero <lekktu@gmail.com>
3457
3458 * makefile.w32-in: Update dependencies.
3459
8e1f5610
CS
34602011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3461
3462 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3463 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3464
7025ee00 34652011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3466
cdfa6eab
PE
3467 Fix some integer overflow issues, such as string length overflow.
3468
06d6db33
PE
3469 * insdel.c (count_size_as_multibyte): Check for string overflow.
3470
2b4560a8
PE
3471 * character.c (lisp_string_width): Check for string overflow.
3472 Use EMACS_INT, not int, for string indexes and lengths; in
3473 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3474 the resulting string length overflows an EMACS_INT; instead,
3475 report a string overflow if no precision given. When checking for
3476 precision exhaustion, use a check that cannot possibly have
3477 integer overflow. (Bug#8675)
3478 * character.h (lisp_string_width): Adjust to new signature.
3479
cb93f9be
PE
3480 * alloc.c (string_overflow): New function.
3481 (Fmake_string): Use it. This doesn't change behavior, but saves
3482 a few bytes and will simplify future changes.
3483 * character.c (string_escape_byte8): Likewise.
3484 * lisp.h (string_overflow): New decl.
3485
1a1f3366
PE
3486 Fixups, following up to the user-interface timestamp change.
3487 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3488 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3489 * msdos.c (mouse_get_pos): Likewise.
3490 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3491 * w32gui.h (Time): Define by including "systime.h" rather than by
3492 declaring it ourselves. (Bug#8664)
3493
d4e3e4d3
PE
3494 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3495 * image.c (clear_image_cache): Likewise.
3496
f6a24d19
PE
3497 * term.c (term_mouse_position): Don't assume time_t wraparound.
3498
08dc5ae6
PE
3499 Be more systematic about user-interface timestamps.
3500 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3501 and sometimes 'EMACS_UINT', to represent these timestamps.
3502 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3503 This makes the code easier to follow, and makes it easier to catch
3504 integer overflow bugs such as Bug#8664.
3505 * frame.c (Fmouse_position, Fmouse_pixel_position):
3506 Use Time, not unsigned long, for user-interface timestamps.
3507 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3508 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3509 * keyboard.h (last_event_timestamp): Likewise.
3510 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3511 * menu.h (xmenu_show): Likewise.
3512 * term.c (term_mouse_position): Likewise.
3513 * termhooks.h (struct input_event.timestamp): Likewise.
3514 (struct terminal.mouse_position_hook): Likewise.
3515 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3516 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3517 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3518 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3519 what it was before.
3520 * menu.h, termhooks.h: Include "systime.h", for Time.
3521
8e55734a
PE
3522 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3523 Don't assume that the difference between two unsigned long values
3524 can fit into an integer. At this point, we know button_down_time
3525 <= event->timestamp, so the difference must be nonnegative, so
3526 there's no need to cast the result if double-click-time is
3527 nonnegative, as it should be; check that it's nonnegative, just in
3528 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3529 apart (about 25 days). (Bug#8664)
8e55734a 3530
841f1b75 3531 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3532 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3533
3e26f69c
PE
3534 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3535 that always fit in int. Use a sentinel instead of a counter, to
3536 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3537 * frame.h (struct frame): Use int for menu_bar_items_used
3538 instead of EMACS_INT, since it always fits in int.
3e26f69c 3539
5cc152c0
PE
3540 * menu.c (grow_menu_items): Check for int overflow.
3541
d89eb65e
PE
3542 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3543
5235bd3e
PE
3544 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3545 Before, the code was not consistent. These values cannot exceed
3546 2**31 - 1 so there's no need to make them unsigned.
3547 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3548 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3549 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3550 as modifiers.
3551 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3552
bc827e23
PE
3553 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3554 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3555 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3556 presumably because the widths might not match.
3557
78eb494e
PE
3558 * window.c (size_window): Avoid needless test at loop start.
3559
04f2d78b
CB
35602011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3561
3562 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3563
d2fc7e3d 35642011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3565
3566 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3567
d2fc7e3d 35682011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3569
3570 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3571 `width' to `bar_area_x' and `bar_area_width', respectively.
3572 (x_scroll_run): Take account of fringe background extension.
3573
04f2d78b
CB
3574 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3575 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3576 `bar_area_width', respectively.
3577 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3578 background extension.
3579
79b70037
GM
35802011-05-10 Jim Meyering <meyering@redhat.com>
3581
3582 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3583
2f142cc5
JB
35842011-05-10 Juanma Barranquero <lekktu@gmail.com>
3585
3586 * image.c (Finit_image_library): Return t for built-in image types,
3587 like pbm and xbm. (Bug#8640)
3588
57679c86
AS
35892011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3590
3591 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3592
888c9e86
EZ
35932011-05-07 Eli Zaretskii <eliz@gnu.org>
3594
b0512a1d
EZ
3595 * w32console.c (Fset_screen_color): Doc fix.
3596 (Fget_screen_color): New function.
3597 (syms_of_ntterm): Defsubr it.
3598
7285dc67
EZ
3599 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3600 unlink the temporary file if Fcall_process didn't create it in the
3601 first place.
3602 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3603 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3604 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3605 cue to call_process_cleanup not to close that handle.
3606
4d3fcc8e
BK
36072011-05-07 Ben Key <bkey76@gmail.com>
3608
3609 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3610 one of two shell specific rules, either bootstrap-temacs-CMD or
3611 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3612 to the previous implementation of the bootstrap-temacs rule.
3613 The bootstrap-temacs-CMD rule is similar to the previous
3614 implementation of the bootstrap-temacs rule except that it
3615 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3616 variable.
3617
3618 These changes, along with some changes to nt/configure.bat,
3619 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3620 earlier fix to add support for --cflags and --ldflags options
3621 that include quotes so that it works whether make uses cmd or
3622 sh as the shell.
3623
b4289b64
MA
36242011-05-06 Michael Albinus <michael.albinus@gmx.de>
3625
3626 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3627 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3628 is a constant.
3629 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3630 a string. Handle both cases.
3631 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3632 (Fdbus_register_method): Use Qinvalid_function.
3633
af4c0e28
JB
36342011-05-06 Juanma Barranquero <lekktu@gmail.com>
3635
3636 * makefile.w32-in: Update dependencies.
3637 (LISP_H): Add inttypes.h and stdin.h.
3638 (PROCESS_H): Add unistd.h.
3639
c51453d9
EZ
36402011-05-06 Eli Zaretskii <eliz@gnu.org>
3641
3642 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3643 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3644
8ff0ac3c 36452011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3646
4c4b566b
PE
3647 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3648
aab2b9b5
PE
3649 * term.c (vfatal): Remove stray call to va_end.
3650 It's not needed and the C Standard doesn't allow it here anyway.
3651
c378da0b
PE
3652 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3653 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3654
288b08c7
PE
3655 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3656 bytes.
3657
e3601888
PE
3658 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3659
db6c0e74
PE
3660 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3661
dd5963ea
PE
3662 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3663
88c9450f
PE
3664 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3665
2f9442b8
PE
3666 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3667
c032b5f8
PE
3668 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3669 * charset.c (Fdefine_charset_internal): Don't initialize
3670 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3671 32-bit int (Bug#8600).
a108c10b
PE
3672
3673 * lread.c (read_integer): Be more consistent with string-to-number.
3674 Use string_to_number to do the actual conversion; this avoids
3675 rounding errors and fixes some other screwups. Without this fix,
3676 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3677 (digit_to_number): Move earlier, for benefit of read_integer.
3678 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3679 not a digit in any supported base. (Bug#8602)
a108c10b 3680
ad5f9eea
PE
3681 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3682
aec1708a
PE
3683 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3684 to match comment at start of function. This also removes a
3685 GCC warning about overflow in a 32+64-bit port.
3686
47be4ab5
PE
3687 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3688
371cac43
PE
3689 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3690 Reported by Stefan Monnier in
3691 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3692 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3693 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3694
d01a7826
PE
3695 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3696 (EMACS_UINTPTR): Likewise, with uintptr_t.
3697
7fd47d5c
PE
3698 * lisp.h: Prefer 64-bit EMACS_INT if available.
3699 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3700 on 32-bit hosts that have 64-bit int, so that they can access
3701 large files.
122b0c86
PE
3702 However, temporarily disable this change unless the temporary
3703 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3704
8727937b
PE
3705 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3706
8ac068ac
PE
3707 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3708 This removes an assumption that EMACS_INT and long are the same
3709 width as pointers. The assumption is true for Emacs porting targets
3710 now, but we want to make other targets possible.
3711 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3712 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3713 In the rest of the code, change types of integers that hold casted
3714 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3715 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3716 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3717 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3718 No need to cast type when ORing.
3719 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3720 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3721 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3722 assume EMACS_INT is the same width as char *.
3723 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3724 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3725 Remove no-longer-needed casts.
3726 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3727 (xg_tool_bar_help_callback, xg_make_tool_item):
3728 Use EMACS_INTPTR to hold an integer
3729 that will be cast to void *; this can avoid a GCC warning
3730 if EMACS_INT is not the same width as void *.
3731 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3732 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3733 (current_message_1, set_message_1):
3734 Use a local to convert to proper width without a cast.
3735 * xmenu.c (dialog_selection_callback): Likewise.
3736
ede49d71
PE
3737 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3738 Also, don't assume VALBITS / RAND_BITS is less than 5,
3739 and don't rely on undefined behavior when shifting a 1 left into
3740 the sign bit.
3741 * lisp.h (get_random): Change signature to match.
3742
2f30ecd0
PE
3743 * lread.c (hash_string): Use size_t, not int, for hash computation.
3744 Normally we prefer signed values; but hashing is special, because
3745 it's better to use unsigned division on hash table sizes so that
3746 the remainder is nonnegative. Also, size_t is the natural width
3747 for hashing into memory. The previous code used 'int', which doesn't
3748 retain enough info to hash well into very large tables.
3749 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3750
2a866e7b
PE
3751 * dbusbind.c: Don't possibly lose pointer info when converting.
3752 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3753 Use XPNTR rather than XHASH, so that the high-order bits of
3754 the pointer aren't lost when converting through void *.
3755
51639eac
PE
3756 * eval.c (Fautoload): Don't double-shift a pointer.
3757
92394119
PE
3758 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3759
dbdb9a7c
JB
37602011-05-06 Juanma Barranquero <lekktu@gmail.com>
3761
3762 * gnutls.c (DEF_GNUTLS_FN):
3763 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3764
db7a0b4f
AS
37652011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3766
3767 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3768 marker. (Bug#8610)
3769
f7ff1b0f 37702011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3771
3772 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3773 New version that can reserve upto 2GB of heap space.
3774
f7ff1b0f 37752011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3776
3777 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3778
639c109b
TZ
37792011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3780
3781 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3782 `gnutls_certificate_set_x509_key_file'.
3783
d2127135
JB
37842011-05-05 Juanma Barranquero <lekktu@gmail.com>
3785
3786 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3787 Update dependencies.
3788
e968f4f3
JB
37892011-05-04 Juanma Barranquero <lekktu@gmail.com>
3790
3791 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3792 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3793 Remove unused parameter `fildes'.
3794 * process.c (read_process_output, send_process): Don't pass it.
3795
84d358f0
JB
37962011-05-04 Juanma Barranquero <lekktu@gmail.com>
3797
3798 Fix previous change: the library cache is defined in w32.c.
3799 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3800 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3801
0898ca10
JB
38022011-05-04 Juanma Barranquero <lekktu@gmail.com>
3803
3804 Implement dynamic loading of GnuTLS on Windows.
3805
3806 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3807 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3808 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3809 Declare.
3810
3811 * gnutls.c (Qgnutls_dll): Define.
3812 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3813 (gnutls_*): Declare function pointers.
3814 (init_gnutls_functions): New function to initialize function pointers.
3815 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3816 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3817 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3818 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3819 (emacs_gnutls_write, emacs_gnutls_read)
3820 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3821 (Fgnutls_available_p): New function.
3822 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3823 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3824 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3825
3826 * image.c: Include w32.h.
3827 (Vimage_type_cache): Delete.
3828 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3829 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3830 (w32_delayed_load): Move to w32.c.
3831
3832 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3833
3834 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3835 (w32_delayed_load): Move from image.c. When loading a library, record
3836 its filename in the :loaded-from property of the library id.
3837 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3838 Initialize and staticpro them.
3839 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3840
3841 * process.c: Include lisp.h before w32.h, not after.
3842 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3843 instead of gnutls_record_check_pending.
3844
3845 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3846
ff4de4aa
TZ
38472011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3848
3849 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3850 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3851 as passed in.
3852
abe95abb
JD
38532011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3854
3855 * xterm.c (x_set_frame_alpha): Do not set property on anything
3856 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3857
e16e55d4
JB
38582011-05-02 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3861
bafcf6a5
JB
38622011-05-02 Juanma Barranquero <lekktu@gmail.com>
3863
3864 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3865 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3866 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3867 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3868 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3869 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3870 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3871 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3872 (Qgnutls_bootprop_callbacks_verify): Make static.
3873
e7a6747f
AS
38742011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3875
19ed11ba
AS
3876 * callproc.c: Indentation fixup.
3877
e7a6747f 3878 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3879 (wait_for_termination, interruptible_wait_for_termination):
3880 Move after wait_for_termination_1.
e7a6747f 3881
1ef14cb4
LMI
38822011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
3884 * sysdep.c (interruptible_wait_for_termination): New function
3885 which is like wait_for_termination, but allows keyboard
3886 interruptions.
3887
3888 * callproc.c (Fcall_process): Add (:file "file") as an option for
3889 the STDOUT buffer.
3890 (Fcall_process_region): Ditto.
3891
330d880c
EZ
38922011-04-30 Eli Zaretskii <eliz@gnu.org>
3893
8db90b73
EZ
3894 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3895 rather than `XVECTOR (FOO)->size'.
3896
330d880c
EZ
3897 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3898 inttypes.h, as a gnulib replacement is used if it not available in
3899 system headers.
3900
15cbd324
EZ
39012011-04-21 Eli Zaretskii <eliz@gnu.org>
3902
3903 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3904 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3905 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3906
3907 * coding.c (coding_alloc_by_realloc): Error out if destination
3908 will grow beyond MOST_POSITIVE_FIXNUM.
3909 (decode_coding_emacs_mule): Abort if there isn't enough place in
3910 charbuf for the composition carryover bytes. Reserve an extra
3911 space for up to 2 characters produced in a loop.
3912 (decode_coding_iso_2022): Abort if there isn't enough place in
3913 charbuf for the composition carryover bytes.
3914
39152011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3916
ae940cca
EZ
3917 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3918 aborting when %lld or %lll format is passed.
3919 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3920 %llo or %llx format is passed. (Bug#8545)
3921
03ab8921
EZ
3922 * window.c (window_scroll_line_based): Use a marker instead of
3923 simple variables to record original value of point. (Bug#7952)
3924
afda1437
EZ
3925 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3926 produced by %s or %c overflows available buffer space. (Bug#8545)
3927
f76dee0c
PE
39282011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3931 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3932
fdc5744d
JB
39332011-04-28 Juanma Barranquero <lekktu@gmail.com>
3934
3935 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3936
638f053a
JB
39372011-04-28 Juanma Barranquero <lekktu@gmail.com>
3938
3939 * keyboard.c (Qdelayed_warnings_hook): Define.
3940 (command_loop_1): Run `delayed-warnings-hook'
3941 if Vdelayed_warnings_list is non-nil.
3942 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3943 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3944
d178f871
EZ
39452011-04-28 Eli Zaretskii <eliz@gnu.org>
3946
3947 * doprnt.c (doprnt): Don't return value smaller than the buffer
3948 size if the message was truncated. (Bug#8545).
3949
b124fd93
JB
39502011-04-28 Juanma Barranquero <lekktu@gmail.com>
3951
3952 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3953 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3954
e810457d
PE
39552011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3956
3957 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3958
ea51cceb
JB
39592011-04-27 Juanma Barranquero <lekktu@gmail.com>
3960
3961 * makefile.w32-in: Update dependencies.
3962
94dcfacf
EZ
39632011-04-27 Eli Zaretskii <eliz@gnu.org>
3964
3965 Improve `doprnt' and its usage. (Bug#8545)
3966 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3967 `format_end'. Remove support for %l as a conversion specifier.
3968 Don't use xrealloc. Improve diagnostics when the %l size modifier
3969 is used. Update the commentary.
3970
3971 * eval.c (verror): Simplify calculation of size_t.
3972
3973 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3974 messages.
3975
f61f41d7
PE
39762011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3977
3978 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3979 change.
3980
96fb4434
PE
39812011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3982
3983 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3984 This makes this file independent of the recent pseudovector change.
3985
671875da 39862011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3987
69e9b5a3
PE
3988 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3989
b5f869a7 3990 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3991 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3992 Remove unused local.
c8926152 3993 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3994
841a1577 3995 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3996 GCC 4.6.0 optimizes based on type-based alias analysis.
3997 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3998 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3999 != &v->size, and therefore "v->size = 1; b->size = 2; return
4000 v->size;" must therefore return 1. This assumption is incorrect
4001 for Emacs, since it type-puns struct Lisp_Vector * with many other
4002 types. To fix this problem, this patch adds a new type struct
f904488f 4003 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4004 and pseudovectors, and helps optimizing compilers not get fooled
4005 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4006 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4007 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4008 the size member.
eab3844f
PE
4009 (XSETPVECTYPE): Rewrite in terms of new macro.
4010 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4011 This is a bit clearer, and further avoids the possibility of
4012 undesirable aliasing.
4013 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4014 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4015 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4016 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4017 (ASIZE): Now uses header.size rather than size.
4018 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4019 to avoid the hassle of writing XVECTOR (foo)->header.size.
4020 (struct vectorlike_header): New type.
eab3844f
PE
4021 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4022 object, to help avoid aliasing.
4023 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4024 (SUBRP): Likewise, since Lisp_Subr is a special case.
4025 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4026 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4027 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4028 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4029 changed to be "header.size" and "header.next".
4030 * buffer.h (struct buffer): Likewise.
4031 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4032 * frame.h (struct frame): Likewise.
4033 * process.h (struct Lisp_Process): Likewise.
4034 * termhooks.h (struct terminal): Likewise.
4035 * window.c (struct save_window_data, struct saved_window): Likewise.
4036 * window.h (struct window): Likewise.
4037 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4038 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4039 * buffer.c (init_buffer_once): Likewise.
4040 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4041 special case.
4042 * process.c (Fformat_network_address): Use local var for size,
4043 for brevity.
4044
0df1eac5
PE
4045 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4046
847ab9d1 4047 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4048 * data.c (atof): Remove decl; no longer used or needed.
4049 (digit_to_number): Move to lread.c.
4050 (Fstring_to_number): Use new string_to_number function, to be
4051 consistent with how the Lisp reader treats infinities and NaNs.
4052 Do not assume that floating-point numbers represent EMACS_INT
4053 without losing information; this is not true on most 64-bit hosts.
4054 Avoid double-rounding errors, by insisting on integers when
4055 parsing non-base-10 numbers, as the documentation specifies.
4056 * lisp.h (string_to_number): New decl, replacing ...
4057 (isfloat_string): Remove.
bc0a5c13 4058 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4059 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4060 appears to have been a coding error. Similarly, do not accept
4061 strings like +-1e0 as floating point numbers. Do not report
4062 overflow for integer overflows unless the base is not 10 which
4063 means we have no simple and reliable way to continue.
4064 Break out the floating-point parsing into a new
4065 function string_to_number, so that Fstring_to_number parses
4066 floating point numbers consistently with the Lisp reader.
04f2d78b 4067 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4068 (E_CHAR, EXP_INT): Remove, replacing with ...
4069 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4070 (string_to_number): New function, replacing isfloat_string.
4071 This function checks for valid syntax and produces the resulting
4072 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4073 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4074 so that overflow for non-base-10 numbers is reported only when
4075 there's no portable and simple way to convert to floating point.
452f4150 4076
67769ffc
PE
4077 * textprop.c (set_text_properties_1): Rewrite for clarity,
4078 and to avoid GCC warning about integer overflow.
4079
c20db43f
PE
4080 * intervals.h (struct interval): Use EMACS_INT for members
4081 where EMACS_UINT might cause problems. See
4082 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4083 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4084 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4085 All uses changed.
37aa2f85
PE
4086 (offset_intervals): Tell GCC not to worry about length overflow
4087 when negating a negative length.
c20db43f 4088
2538aa2f
PE
4089 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4090 (overrun_check_free): Likewise.
4091
f2d3008d
PE
4092 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4093 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4094 word size.
4095
ec8df744
PE
4096 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4097 (gnutls_make_error): Rename local to avoid shadowing.
4098 (gnutls_emacs_global_deinit): ifdef out; not used.
4099 (Fgnutls_boot): Use const for pointer to readonly storage.
4100 Comment out unused local. Fix pointer signedness problems.
4101
640ee02d
PE
4102 * lread.c (openp): Don't stuff size_t into an 'int'.
4103 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4104 about possible signed overflow.
4105
6048fb2a
PE
4106 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4107 (GDK_KEY_g): Don't define if already defined.
4108 (xg_prepare_tooltip): Avoid pointer signedness problem.
4109 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4110
fa3c87e1
PE
4111 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4112 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4113
2172544b
PE
4114 * xfns.c (Fx_window_property): Simplify a bit,
4115 to make a bit faster and to avoid GCC 4.6.0 warning.
4116 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4117
9b821a21
PE
4118 * fns.c (internal_equal): Don't assume size_t fits in int.
4119
3c616cfa
PE
4120 * alloc.c (compact_small_strings): Tighten assertion a little.
4121
c2982e87
PE
4122 Replace pEd with more-general pI, and fix some printf arg casts.
4123 * lisp.h (pI): New macro, generalizing old pEd macro to other
4124 conversion specifiers. For example, use "...%"pI"d..." rather
4125 than "...%"pEd"...".
4126 (pEd): Remove. All uses replaced with similar uses of pI.
4127 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4128 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4129 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4130 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4131 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4132 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4133 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4134 64-bit hosts.
4135 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4136 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4137 * print.c (safe_debug_print, print_object): Likewise.
4138 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4139 to int.
6f04d126
PE
4140 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4141 avoiding the 0 flag, which is not portable.
c2982e87
PE
4142 * process.c (Fmake_network_process): Use pI to avoid cast.
4143 * region-cache.c (pp_cache): Likewise.
4144 * xdisp.c (decode_mode_spec): Likewise.
4145 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4146 behavior on 64-bit hosts with printf arg.
6f04d126 4147 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4148 (x_stop_queuing_selection_requests): Likewise.
4149 (x_get_window_property): Don't truncate byte count to an 'int'
4150 when tracing.
0b432f21 4151
5e073ec7
PE
4152 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4153 here, since it parses constructs like leading '-' and spaces,
4154 which are not wanted; and it overflows with large numbers.
4155 Instead, simply match F[0-9]+, which is what is wanted anyway.
4156
36372bf9
PE
4157 * alloc.c: Remove unportable assumptions about struct layout.
4158 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4159 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4160 (allocate_vectorlike, make_pure_vector): Use the new macros,
4161 plus offsetof, to remove unportable assumptions about struct layout.
4162 These assumptions hold on all porting targets that I know of, but
4163 they are not guaranteed, they're easy to remove, and removing them
4164 makes further changes easier.
4165
0b432f21
PE
4166 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4167 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4168 (string_overrun_cookie): Now const. Use initializers that
4169 don't formally overflow signed char, to avoid warnings.
000098c1
PE
4170 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4171 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
4172 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4173 multiple of sizeof (EMACS_INT); it need not be, if
4174 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 4175 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 4176
895009e1
JB
41772011-04-26 Juanma Barranquero <lekktu@gmail.com>
4178
4179 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4180
6a7a1b0b
TZ
41812011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4182
4183 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 4184 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
4185 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4186
841a1577 41872011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
4188
4189 * lisp.h (Qdebug): List symbol.
895009e1 4190 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
4191 * keyboard.c (debug-on-event): New variable.
4192 (handle_user_signal): Break into debugger when debug-on-event
4193 matches the current signal symbol.
4194
f2d3ba6f
DN
41952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4196
4197 * alloc.c (check_sblock, check_string_bytes)
4198 (check_string_free_list): Convert to standard C.
4199
42ce4c63
TZ
42002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4201
4202 * w32.c (emacs_gnutls_push): Fix typo.
4203
825cd63c
EZ
42042011-04-25 Eli Zaretskii <eliz@gnu.org>
4205
fb11d64d
EZ
4206 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4207 "cast to pointer from integer of different size".
4208
825cd63c
EZ
4209 Improve doprnt and its use in verror. (Bug#8545)
4210 * doprnt.c (doprnt): Document the set of format control sequences
4211 supported by the function. Use SAFE_ALLOCA instead of always
4212 using `alloca'.
4213
4214 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4215 is one byte too soon. Don't use xrealloc; instead xfree and
4216 xmalloc anew.
4217
e061a11b
TZ
42182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4219
4220 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4221 callbacks stage.
4222
4223 * gnutls.c: Renamed global_initialized to
4224 gnutls_global_initialized. Added internals for the
4225 :verify-hostname-error, :verify-error, and :verify-flags
4226 parameters of `gnutls-boot' and documented those parameters in the
4227 docstring. Start callback support.
9173deec
JB
4228 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4229 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4230 on error. Return error code.
e061a11b
TZ
4231 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4232 (emacs_gnutls_read): Likewise.
4233 (Fgnutls_boot): Return handshake error code.
4234 (emacs_gnutls_handle_error): New function.
4235 (wsaerror_to_errno): Likewise.
4236
4237 * w32.h (emacs_gnutls_pull): Add prototype.
4238 (emacs_gnutls_push): Likewise.
4239
4240 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4241 (emacs_gnutls_push): Likewise.
4242
42432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4244
4245 * process.c (wait_reading_process_output): Check if GnuTLS
4246 buffered some data internally if no FDs are set for TLS
4247 connections.
4248
4249 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4250 (LIBS): Link to USER_LIBS.
4251 ($(BLD)/gnutls.$(0)): New target.
4252
fa6996bc
EZ
42532011-04-24 Eli Zaretskii <eliz@gnu.org>
4254
eb35682e
EZ
4255 * xdisp.c (handle_single_display_spec): Rename the
4256 display_replaced_before_p argument into display_replaced_p, to
4257 make it consistent with the commentary. Fix typos in the
4258 commentary.
4259
e2ad650c
EZ
4260 * textprop.c (syms_of_textprop): Remove dead code.
4261 (copy_text_properties): Delete obsolete commentary about an
4262 interface that was deleted long ago. Fix typos in the description
4263 of arguments.
4264
1b2de274
EZ
4265 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4266 to changes in oldXMenu/XMenu.h from 2011-04-16.
4267 <menu_help_message, prev_menu_help_message>: Constify.
4268 (IT_menu_make_room): menu->help_text is now `const char **';
4269 adjust.
4270
4271 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4272 to changes in oldXMenu/XMenu.h from 2011-04-16.
4273 (struct XMenu): Declare `help_text' `const char **'.
4274
4275 * xfaces.c <Qunspecified>: Make extern again.
4276
4277 * syntax.c: Include sys/types.h before including regex.h, as
4278 required by Posix.
4279
762b15be
EZ
4280 * doc.c (get_doc_string): Improve the format passed to `error'.
4281
4282 * doprnt.c (doprnt): Improve commentary.
4283
4284 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4285
4286 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4287 them with etags.
4288
f1052e5d
EZ
4289 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4290 changes in globals.h immediately force recompilation.
762b15be
EZ
4291 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4292 $(CURDIR)/s/ms-w32.h.
4293 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4294
fa6996bc
EZ
4295 * character.c (Fchar_direction): Function deleted.
4296 (syms_of_character): Don't defsubr it.
4297 <char-direction-table>: Deleted.
4298
e6c3da20
EZ
42992011-04-23 Eli Zaretskii <eliz@gnu.org>
4300
4301 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4302 * doprnt.c: Include limits.h.
4303 (SIZE_MAX): New macro.
04f2d78b
CB
4304 (doprnt): Return a size_t value. 2nd arg is now size_t.
4305 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4306 Improve overflow protection. Support `l' modifier for integer
4307 conversions. Support %l conversion. Don't assume an EMACS_INT
4308 argument for integer conversions and for %c.
4309
4310 * lisp.h (doprnt): Restore prototype.
4311
4312 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4313 $(SRC)/character.h.
4314
4315 * Makefile.in (base_obj): Add back doprnt.o.
4316
4317 * deps.mk (doprnt.o): Add back prerequisites.
4318 (callint.o): Depend on character.h.
4319
4320 * eval.c (internal_lisp_condition_case): Include the handler
4321 representation in the error message.
4322 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4323 when breaking from the loop.
4324
4325 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4326
4327 * callint.c (Fcall_interactively): When displaying error message
4328 about invalid control letter, pass the character's codepoint, not
4329 a pointer to its multibyte form. Improve display of the character
4330 in octal and display also its hex code.
4331
4332 * character.c (char_string): Use %x to display the (unsigned)
4333 codepoint of an invalid character, to avoid displaying a bogus
4334 negative value.
4335
4336 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4337 `error', not SYMBOL_NAME itself.
4338
4339 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4340 character arguments to `error'.
4341
4342 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4343 to `error' in error message about FINAL_CHAR argument. Make sure
4344 FINAL_CHAR is a character, and use %c when it is passed as
4345 argument to `error'.
4346
4ffd0d6b 43472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4348
4349 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4350
4351 * w32.c: Include <time.h>.
4352 (sys_localtime): New function.
4353
4ffd0d6b 43542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4355
4356 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4357
4ffd0d6b 4358 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4359
4ffd0d6b 43602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4361
4ffd0d6b
GM
4362 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4363 zombies (Bug#8467).
aac0c6e3 4364
04c56954
EZ
43652011-04-19 Eli Zaretskii <eliz@gnu.org>
4366
4367 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4368 gl_state.e_property when gl_state.object is Qt.
4369
4370 * insdel.c (make_gap_larger): Remove limitation of buffer size
4371 to <= INT_MAX.
4372
16a43933
CY
43732011-04-18 Chong Yidong <cyd@stupidchicken.com>
4374
4375 * xdisp.c (lookup_glyphless_char_display)
4376 (produce_glyphless_glyph): Handle cons cell entry in
4377 glyphless-char-display.
4378 (Vglyphless_char_display): Document it.
4379
4380 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4381 glyphless-char-display.
4382
4581706e
CY
43832011-04-17 Chong Yidong <cyd@stupidchicken.com>
4384
4385 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4386
4387 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4388
4389 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4390 definition for no-X builds.
4391
4887c6e2 43922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4393
fd35b6f9
PE
4394 Static checks with GCC 4.6.0 and non-default toolkits.
4395
5c1ccb01
PE
4396 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4397
006c5daa
PE
4398 * process.c (keyboard_bit_set): Define only if SIGIO.
4399 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4400 (send_process): Repair possible setjmp clobbering.
4401
efc736d3
PE
4402 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4403
4e2fe2e6
PE
4404 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4405
f97334a2
PE
4406 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4407
4e75f29d
PE
4408 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4409 Define only if needed.
4410
90efadd1
PE
4411 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4412 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4413 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4414
3c647824
PE
4415 * dispextern.h (struct redisplay_interface): Rename param
4416 to avoid shadowing.
e264f262 4417 * termhooks.h (struct terminal): Likewise.
761383f4 4418 * xterm.c (xembed_send_message): Likewise.
3c647824 4419
b58c5c4a
PE
4420 * insdel.c (make_gap_smaller): Define only if
4421 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4422
cad59032
PE
4423 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4424 it.
4425
c339dc2e
PE
4426 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4427 so that we aren't warned about unused symbols.
4428
91a3e27b
PE
4429 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4430
399c71d3 4431 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4432
8ffc96f5
PE
4433 * xfns.c (x_real_positions): Mark locals as initialized.
4434
eef9bc79
PE
4435 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4436
098db9dd
PE
4437 * xterm.c: Fix problems found by static analysis with other toolkits.
4438 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4439 (x_dispatch_event): Declare static if USE_GTK, and
4440 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4441 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4442 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4443 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4444 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4445
eb18f6cc
PE
4446 * xmenu.c (menu_help_callback): Pointer type fixes.
4447 Use const pointers when pointing at readonly data. Avoid pointer
4448 signedness clashes.
4449 (FALSE): Remove unused macro.
4450 (update_frame_menubar): Remove unused decl.
4451
1fe72bf8
PE
4452 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4453
60d9e1db
PE
4454 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4455 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4456 (single_menu_item): Rename local to avoid shadowing.
4457
39261c26
PE
4458 * keyboard.c (make_lispy_event): Remove unused local var.
4459
018c5e19
PE
4460 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4461 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4462
63d2b86e
PE
4463 * bitmaps: Change bitmaps from unsigned char back to the X11
4464 compatible char. Avoid the old compiler warnings about
4465 out-of-range initializers by using, for example, '\xab' rather
4466 than 0xab.
4467
aefd87e1
PE
4468 * xgselect.c (xgselect_initialize): Check vs interface
4469 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4470
bf501fb9
PE
4471 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4472
e9829fdf
PE
4473 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4474 to read-only memory.
4475
1086c095
PE
4476 * fns.c (vector): Remove; this old hack is no longer needed.
4477
2baccd04 4478 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4479 Remove unused var.
dde42981 4480 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4481
72391843 4482 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4483
436c16df 4484 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4485 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4486 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4487
92bb796d 4488 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4489 (x_term_init): Remove local to avoid shadowing.
92bb796d 4490
764430a3 4491 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4492
4493 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4494 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4495
d1dfb56c
EZ
44962011-04-16 Eli Zaretskii <eliz@gnu.org>
4497
c4354cb4
EZ
4498 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4499
d1dfb56c
EZ
4500 Fix regex.c, syntax.c and friends for buffers > 2GB.
4501 * syntax.h (struct gl_state_s): Declare character position members
4502 EMACS_INT.
4503
4504 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4505
04f2d78b
CB
4506 * textprop.c (verify_interval_modification, interval_of):
4507 Declare arguments EMACS_INT.
d1dfb56c
EZ
4508
4509 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4510 EMACS_INT.
4511
4512 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4513
4514 * indent.c (Fvertical_motion): Local variable it_start is now
4515 EMACS_INT.
4516
4517 * regex.c (re_match, re_match_2, re_match_2_internal)
4518 (bcmp_translate, regcomp, regexec, print_double_string)
4519 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4520 (re_compile_pattern, re_exec): Declare arguments and local
4521 variables `size_t' and `ssize_t' and return values `regoff_t', as
4522 appropriate.
4523 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4524 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4525 <compile_stack_type>: `size' and `avail' are now `size_t'.
4526
4527 * regex.h <regoff_t>: Use ssize_t, not int.
4528 (re_search, re_search_2, re_match, re_match_2): Arguments that
4529 specify buffer/string position and length are now ssize_t and
4530 size_t. Return type is regoff_t.
4531
613052cd
BK
45322011-04-16 Ben Key <bkey76@gmail.com>
4533
4534 * nsfont.m: Fixed bugs in ns_get_family and
4535 ns_descriptor_to_entity that were caused by using free to
4536 deallocate memory blocks that were allocated by xmalloc (via
4537 xstrdup). This caused Emacs to crash when compiled with
4538 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4539 --enable-checking=xmallocoverrun). xfree is now used to
4540 deallocate these memory blocks.
4541
4170f62f 45422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4543
71b41406
PE
4544 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4545
9587a89d
PE
4546 emacs_write: Accept and return EMACS_INT for sizes.
4547 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4548 et seq.
4549 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4550 Accept and return EMACS_INT.
4551 (emacs_gnutls_write): Return the number of bytes written on
4552 partial writes.
4553 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4554 (emacs_read, emacs_write): Remove check for negative size, as the
4555 Emacs source code has been audited now.
9587a89d
PE
4556 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4557 (emacs_read, emacs_write): Use it.
273a5f82
PE
4558 * process.c (send_process): Adjust to the new signatures of
4559 emacs_write and emacs_gnutls_write. Do not attempt to store
4560 a byte offset into an 'int'; it might overflow.
9587a89d 4561 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4562
3e047f51
PE
4563 * sound.c: Don't assume sizes fit in 'int'.
4564 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4565 Return EMACS_INT, not int.
3e047f51 4566 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4567 Accept EMACS_INT, not int.
4568 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4569 record read return values.
4570
cc39a9db
BK
45712011-04-15 Ben Key <bkey76@gmail.com>
4572
c9d0ec6d
JB
4573 * keyboard.c (Qundefined): Don't declare static since it is used
4574 in nsfns.m.
4575 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4576 static since they are used in nsfont.m.
cc39a9db 4577
6c60eb9f
SM
45782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4579
4580 * process.c (Qprocessp): Don't declare static.
4581 * lisp.h (Qprocessp): Declare again.
4582
7990b61a
JB
45832011-04-15 Juanma Barranquero <lekktu@gmail.com>
4584
4585 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4586
5d4cb038
PE
45872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4588
8bd7b830 4589 Improve C-level modularity by making more things 'static'.
cd64ea1d 4590
e3b27b31
PE
4591 Don't publish debugger-only interfaces to other modules.
4592 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4593 (verify_bytepos, count_markers): Move decls to the only modules
4594 that need them.
4595 * region-cache.h (pp_cache): Likewise.
4596 * window.h (check_all_windows): Likewise.
4597 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4598
5d4cb038
PE
4599 * sysdep.c (croak): Now static, if
4600 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4601 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4602
4603 * alloc.c (refill_memory_reserve): Now static if
4604 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4605 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4606
e87b6180
PE
4607 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4608 Define only if USE_LUCID.
4609
ac64929e
PE
4610 * xrdb.c (x_customization_string, x_rm_string): Now static.
4611
6f37259d
PE
4612 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4613 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4614
1683e3ab
PE
4615 * xdisp.c (draw_row_with_mouse_face): Now static.
4616 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4617
de9c2632
PE
4618 * window.h (check_all_windows): Mark externally visible.
4619
2b96acb7
PE
4620 * window.c (window_deletion_count): Now static.
4621
4622 * undo.c: Make symbols static if they're not exported.
4623 (last_undo_buffer, last_boundary_position, pending_boundary):
4624 Now static.
4625
50436f33
PE
4626 * textprop.c (interval_insert_behind_hooks): Now static.
4627 (interval_insert_in_front_hooks): Likewise.
4628
64520e5c
PE
4629 * term.c: Make symbols static if they're not exported.
4630 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4631 (max_frame_lines, tty_set_terminal_modes):
4632 (tty_reset_terminal_modes, tty_turn_off_highlight):
4633 (get_tty_terminal): Now static.
4634 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4635 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4636 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4637 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4638 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4639
1fa53021
PE
4640 * sysdep.c: Make symbols static if they're not exported.
4641 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4642 Now static.
4643 (sigprocmask_set, full_mask): Remove; unused.
4644 (wait_debugging): Mark as visible.
4645 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4646 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4647
d4b43b22
PE
4648 * syntax.c (syntax_temp): Define only if !__GNUC__.
4649
b7c513d0
PE
4650 * sound.c (current_sound_device, current_sound): Now static.
4651
989b29ad
PE
4652 * search.c (searchbufs, searchbuf_head): Now static.
4653
13a55a78
PE
4654 * scroll.c (scroll_cost): Remove; unused.
4655 * dispextern.h (scroll_cost): Remove decl.
4656
de68a1fc
PE
4657 * region-cache.h (pp_cache): Mark as externally visible.
4658
40ccffa6
PE
4659 * process.c: Make symbols static if they're not exported.
4660 (process_tick, update_tick, create_process, chan_process):
4661 (Vprocess_alist, proc_buffered_char, datagram_access):
4662 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4663 (deactivate_process): Mark defn as static, as well as decl.
4664 * lisp.h (create_process): Remove decl.
4665 * process.h (chan_process, Vprocess_alist): Remove decls.
4666
ad64fc97
PE
4667 * print.c: Make symbols static if they're not exported.
4668 (print_depth, new_backquote_output, being_printed, print_buffer):
4669 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4670 (print_interval, print_number_index, initial_stderr_stream):
4671 Now static.
4672 * lisp.h (Fprinc): Remove decl.
4673 (debug_output_compilation_hack): Mark as externally visible.
4674
adddb265
PE
4675 * sysdep.c (croak): Move decl from here to syssignal.h.
4676 * syssignal.h (croak): Put it here, so the API can be checked when
4677 'croak' is called from dissociate_if_controlling_tty.
4678
1717ede2
PE
4679 * minibuf.c: Make symbols static if they're not exported.
4680 (minibuf_save_list, choose_minibuf_frame): Now static.
4681 * lisp.h (choose_minibuf_frame): Remove decl.
4682
fa5fb2bc
PE
4683 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4684
1e3890d1
PE
4685 * lread.c: Make symbols static if they're not exported.
4686 (read_objects, initial_obarray, oblookup_last_bucket_number):
4687 Now static.
4688 (make_symbol): Remove; unused.
4689 * lisp.h (initial_obarray, make_symbol): Remove decls.
4690
8a1414fa
PE
4691 * keyboard.c: Make symbols static if they're not exported.
4692 (single_kboard, recent_keys_index, total_keys, recent_keys):
4693 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4694 (this_single_command_key_start, echoing, last_auto_save):
4695 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4696 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4697 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4698 (Vlispy_mouse_stem, double_click_count):
4699 Now static.
4700 (force_auto_save_soon): Define only if SIGDANGER.
4701 (ignore_mouse_drag_p): Now static if
4702 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4703 (print_help): Remove; unused.
4704 (stop_character, last_timer_event): Mark as externally visible.
4705 * keyboard.h (ignore_mouse_drag_p): Declare only if
4706 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4707 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4708 * lisp.h (echoing): Remove decl.
4709 (force_auto_save_soon): Declare only if SIGDANGER.
4710 * xdisp.c (redisplay_window): Simplify code, to make it more
4711 obvious that ignore_mouse_drag_p is not accessed if !defined
4712 USE_GTK && !defined HAVE_NS.
4713
93ea6e8f
PE
4714 * intervals.c: Make symbols static if they're not exported.
4715 (merge_properties_sticky, merge_interval_right, delete_interval):
4716 Now static.
4717 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4718
77382fcc
PE
4719 * insdel.c: Make symbols static if they're not exported.
4720 However, leave prepare_to_modify_buffer alone. It's never
4721 called from outside this function, but that appears to be a bug.
4722 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4723 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4724 (adjust_after_replace_noundo): Remove; unused.
4725 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4726 (signal_before_change): Remove decls.
77382fcc 4727
9306c32e
PE
4728 * indent.c (val_compute_motion, val_vmotion): Now static.
4729
cd44d2eb
PE
4730 * image.c: Make symbols static if they're not exported.
4731 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4732 if USE_GTK.
4733 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4734 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4735
ad9a7a06
PE
4736 * fringe.c (standard_bitmaps): Now static.
4737 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4738
81626931
PE
4739 * frame.c: Make symbols static if they're not exported.
4740 (x_report_frame_params, make_terminal_frame): Now static.
4741 (get_frame_param): Now static, unless HAVE_NS.
4742 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4743 (x_get_resource_string): Remove; not used.
4744 * frame.h (make_terminal_frame, x_report_frame_params):
4745 (x_get_resource_string); Remove decls.
4746 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4747 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4748
239f9db9
PE
4749 * font.c, fontset.c: Make symbols static if they're not exported.
4750 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4751 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4752 * font.c (font_close_object): Now static.
4753 * font.h (font_close_object): Remove.
4754 * fontset.c (FONTSET_OBJLIST): Remove.
4755 (free_realized_fontset) #if-0 the body, which does nothing.
4756 (face_suitable_for_char_p): #if-0, as it's never called.
4757 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4758 * xfaces.c (face_at_string_position):
4759 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4760 since 0 is always ASCII.
4761
dfcf3579
PE
4762 * fns.c (weak_hash_tables): Now static.
4763
5045092b
PE
4764 * fileio.c: Make symbols static if they're not exported.
4765 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4766 (Vwrite_region_annotation_buffers): Now static.
4767
57a96f5c
PE
4768 * eval.c: Make symbols static if they're not exported.
4769 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4770 * lisp.h (backtrace_list): Remove decl.
4771
35f08c38
PE
4772 * emacs.c: Make symbols static if they're not exported.
4773 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4774 (fatal_error_code, fatal_error_signal_hook, standard_args):
4775 Now static.
4776 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4777 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4778 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4779 * lisp.h (fatal_error_signal_hook): Remove decl.
4780 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4781
f44bd759
PE
4782 * editfns.c: Move a (normally-unused) function to its only use.
4783 * editfns.c, lisp.h (get_operating_system_release): Remove.
4784 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4785 worth the hassle of breaking this out.
4786
b532497d
PE
4787 * xterm.c: Make symbols static if they're not exported.
4788 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4789 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4790 (x_destroy_window, x_delete_display):
4791 Now static.
4792 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4793 (x_mouse_leave): Remove; unused.
4794 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4795 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4796 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4797 Remove decls.
4798 (x_mouse_leave): Declare only if WINDOWSNT.
4799 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4800 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4801 USE_X_TOOLKIT.
4802
1675728f
PE
4803 * ftxfont.c: Make symbols static if they're not exported.
4804 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4805 HAVE_FREETYPE.
4806 * font.h (ftxfont_driver): Likewise.
4807
e4cebfca
PE
4808 * xfns.c: Make symbols static if they're not exported.
4809 (x_last_font_name, x_display_info_for_name):
4810 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4811 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4812 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4813 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4814 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4815 (last_show_tip_args): Now static.
4816 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4817 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4818 (x_screen_planes): Remove; unused.
4819 * dispextern.h (x_screen_planes): Remove decl.
4820
5bf46f05
PE
4821 * dispnew.c: Make symbols static if they're not exported.
4822 * dispextern.h (redraw_garbaged_frames, scrolling):
4823 (increment_row_positions): Remove.
4824 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4825 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4826 Now static.
4827 (redraw_garbaged_frames): Remove; unused.
4828
435f4c28
PE
4829 * xfaces.c: Make symbols static if they're not exported.
4830 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4831 Remove decls.
4832 * xterm.h (defined_color): Remove decls.
4833 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4834 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4835 (menu_face_changed_default, defined_color, free_realized_face):
4836 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4837 (ascii_face_of_lisp_face): Remove; unused.
4838
8524aef3
PE
4839 * xdisp.c: Make symbols static if they're not exported.
4840 * dispextern.h (scratch_glyph_row, window_box_edges):
4841 (glyph_to_pixel_coords, set_cursor_from_row):
4842 (get_next_display_element, set_iterator_to_next):
4843 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4844 (show_mouse_face): Remove decls
4845 * frame.h (message_buf_print): Likewise.
4846 * lisp.h (pop_message, set_message, check_point_in_composition):
4847 Likewise.
4848 * xterm.h (set_vertical_scroll_bar): Likewise.
4849 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4850 (message_buf_print, scratch_glyph_row, displayed_buffer):
4851 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4852 (get_next_display_element, show_mouse_face, window_box_edges):
4853 (frame_to_window_pixel_xy, check_point_in_composition):
4854 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4855 (glyph_to_pixel_coords): Remove; unused.
4856
16390cd2
PE
4857 * dired.c (file_name_completion): Now static.
4858
4859 * dbusbind.c (xd_in_read_queued_messages): Now static.
4860
a25f4dfa
PE
4861 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4862 * data.c (circular_list_error): Remove.
4863
14a9c8df
PE
4864 * commands.h (last_point_position, last_point_position_buffer):
4865 (last_point_position_window): Remove decls.
4866 * keyboard.c: Make these variables static.
4867
04f2d78b
CB
4868 * coding.h (coding, code_convert_region, encode_coding_gap):
4869 Remove decls.
74ab6df5
PE
4870 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4871 (iso_code_class, detect_coding, code_convert_region): Now static.
4872 (encode_coding_gap): Remove; unused.
4873
38dfbee1
PE
4874 * chartab.c (chartab_chars, chartab_bits): Now static.
4875
a2cb4e63
PE
4876 * charset.h (charset_iso_8859_1): Remove decl.
4877 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4878 Now static.
4879
127198fd
PE
4880 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4881 * ccl.c (Vccl_program_table): Now static.
4882 (check_ccl_update): Remove; unused.
4883
d85b608f
PE
4884 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4885 * category.h: ... from here.
4886 * category.c (check_category_table, set_category_set): Now static.
4887
31cd66f3
PE
4888 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4889 * lisp.h: Remove these decls.
4890
c358e587
PE
4891 * buffer.c (buffer_count): Remove unused var.
4892
e78aecca
PE
4893 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4894 so that it's not optimized away.
4895 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4896 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4897 exported only to the debugger.
4898
e192d7d3 4899 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4900 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4901
92470028
PE
4902 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4903 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4904 was inaccessible from Lisp.
4905 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4906 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4907
244ed907
PE
4908 alloc.c: Import and export fewer symbols, and remove unused items.
4909 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4910 is defined.
4911 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4912 it's not optimized away by whole-program optimization.
4913 (message_enable_multibyte, free_misc): Remove.
4914 (catchlist, handlerlist, mark_backtrace):
4915 Declare only if BYTE_MARK_STACK.
4916 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4917 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4918 (message_enable_multibyte): Remove decl.
4919 (free_misc, interval_free_list, float_block, float_block_index):
4920 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4921 (cons_free_list, last_marked_index):
4922 Now static.
4923 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4924 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4925 (mark_backtrace): Define only if BYTE_MARK_STACK.
4926 * xdisp.c (message_enable_multibyte): Now static.
4927
61c2b50e 4928 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4929 This makes it easier for human readers (and static analyzers)
4930 to see whether these variables are used from other modules.
4931 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4932 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4933 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4934 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4935 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4936 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4937 * xmenu.c, xselect.c:
4938 Declare Q* vars static if they are not used in other modules.
4939 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4940 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4941 Remove decls of unexported vars.
4942 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4943
95c82688
PE
4944 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4945
16a97296
PE
4946 Make Emacs functions such as Fatom 'static' by default.
4947 This makes it easier for human readers (and static analyzers)
4948 to see whether these functions can be called from other modules.
4949 DEFUN now defines a static function. To make the function external
4950 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4951 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4952 (Finit_image_library):
16a97296
PE
4953 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4954 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4955 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4956 Remove decls, since these functions are now static.
4957 (Funintern, Fget_internal_run_time): New decls, since these functions
4958 were already external.
95c82688 4959
16a97296
PE
4960 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4961 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4962 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4963 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4964 * keyboard.c, keymap.c, lread.c:
4965 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4966 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4967 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4968 Mark functions with DEFUE instead of DEFUN,
4969 if they are used in other modules.
4970 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4971 decls for now-static functions.
4972 * buffer.h (Fdelete_overlay): Remove decl.
4973 * callproc.c (Fgetenv_internal): Mark as internal.
4974 * composite.c (Fremove_list_of_text_properties): Remove decl.
4975 (Fcomposition_get_gstring): New forward static decl.
4976 * composite.h (Fcomposite_get_gstring): Remove decl.
4977 * dired.c (Ffile_attributes): New forward static decl.
4978 * doc.c (Fdocumntation_property): New forward static decl.
4979 * eval.c (Ffetch_bytecode): New forward static decl.
4980 (Funintern): Remove extern decl; now in .h file where it belongs.
4981 * fileio.c (Fmake_symbolic_link): New forward static decl.
4982 * image.c (Finit_image_library): New forward static decl.
4983 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4984 * intervals.h (Fprevious_property_change):
4985 (Fremove_list_of_text_properties): Remove decls.
4986 * keyboard.c (Fthis_command_keys): Remove decl.
4987 (Fcommand_execute): New forward static decl.
4988 * keymap.c (Flookup_key): New forward static decl.
4989 (Fcopy_keymap): Now static.
4990 * keymap.h (Flookup_key): Remove decl.
4991 * process.c (Fget_process): New forward static decl.
4992 (Fprocess_datagram_address): Mark as internal.
4993 * syntax.c (Fsyntax_table_p): New forward static decl.
4994 (skip_chars): Remove duplicate decl.
4995 * textprop.c (Fprevious_property_change): New forward static decl.
4996 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4997 Now internal.
4998 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4999 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5000
785bbd42
PE
5001 * editfns.c (Fformat): Remove unreachable code.
5002
8b913b57
AS
50032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5004
5005 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5006 change. (Bug#8496)
5007
a6744a35
EZ
50082011-04-13 Eli Zaretskii <eliz@gnu.org>
5009
5010 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5011 when at ZV. (Bug#8487)
5012
e7974947
AS
50132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5014
baad03f0
AS
5015 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5016 (Bug#8437)
5017 * keyboard.c (parse_tool_bar_item): Likewise.
5018 * sound.c (sound_cleanup, alsa_close): Likewise.
5019 * termcap.c (tgetent): Likewise.
5020 * xfns.c (x_default_font_parameter): Likewise.
5021 * xsettings.c (read_and_apply_settings): Likewise.
5022
e7974947
AS
5023 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5024 (overrun_check_free): Protoize.
5025
28272684
PE
50262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5027
5028 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5029 since callers should never pass a negative size.
5030 Change the signature to match that of plain 'read' and 'write'; see
5031 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5032 * lisp.h: Update prototypes of emacs_write and emacs_read.
5033
11997c76
EZ
50342011-04-11 Eli Zaretskii <eliz@gnu.org>
5035
5036 * xdisp.c (redisplay_window): Don't try to determine the character
5037 position of the scroll margin if the window start point w->startp
e896f03c 5038 is outside the buffer's accessible region. (Bug#8468)
11997c76 5039
8a2cbd72
EZ
50402011-04-10 Eli Zaretskii <eliz@gnu.org>
5041
5042 Fix write-region and its subroutines for buffers > 2GB.
5043 * fileio.c (a_write, e_write): Modify declaration of arguments and
5044 local variables to support buffers larger than 2GB.
5045 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5046
5047 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5048 argument, local variables, and return value.
5049
5050 * lisp.h: Update prototypes of emacs_write and emacs_read.
5051
5052 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5053
4073e537 50542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5055
1ebfdcb6
PE
5056 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5057
b2ded58d
PE
5058 Fix more problems found by GCC 4.6.0's static checks.
5059
7d66342c
PE
5060 * xdisp.c (vmessage): Use a better test for character truncation.
5061
bbf47d44
PE
5062 * charset.c (load_charset_map): <, not <=, for optimization,
5063 and to avoid potential problems with integer overflow.
9248994d 5064 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5065 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5066 * editfns.c (Fformat): Likewise.
1e69125e 5067 * syntax.c (skip_chars): Likewise.
3befa583 5068
e3019616
PE
5069 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5070 This also lets GCC 4.6.0 generate slightly better loop code.
5071
becfa255
PE
5072 * callint.c (Fcall_interactively): <, not <=, for optimization.
5073 (Fcall_interactively): Count the number of arguments produced,
5074 not the number of arguments given. This is simpler and lets GCC
5075 4.6.0 generate slightly better code.
5076
dae0cd48
PE
5077 * ftfont.c: Distingish more carefully between FcChar8 and char.
5078 The previous code passed unsigned char * to a functions like
5079 strlen and xstrcasecmp that expect char *, which does not
5080 conform to the C standard.
5081 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5082 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5083 char * when the C standard requires it.
5084
76032d70
PE
5085 * keyboard.c (read_char): Remove unused var.
5086
eb3f1cc8
PE
5087 * eval.c: Port to Windows vsnprintf (Bug#8435).
5088 Include <limits.h>.
5089 (SIZE_MAX): Define if the headers do not.
5090 (verror): Do not give up if vsnprintf returns a negative count.
5091 Instead, grow the buffer. This ports to Windows vsnprintf, which
5092 does not conform to C99. Problem reported by Eli Zaretskii.
5093 Also, simplify the allocation scheme, by avoiding the need for
5094 calling realloc, and removing the ALLOCATED variable.
5095
70476b54
PE
5096 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5097
12020a9e
PE
5098 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5099 But keep the doprint source code for now, as we might revamp it
5100 and use it again (Bug#8435).
ea6c7ae6
PE
5101 * lisp.h (doprnt): Remove.
5102 * Makefile.in (base_obj): Remove doprnt.o.
5103 * deps.mk (doprnt.o): Remove.
5104
5fdb398c
PE
5105 error: Print 32- and 64-bit integers portably (Bug#8435).
5106 Without this change, on typical 64-bit hosts error ("...%d...", N)
5107 was used to print both 32- and 64-bit integers N, which relied on
5108 undefined behavior.
5109 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5110 New macro.
5111 * lisp.h (error, verror): Mark as printf-like functions.
5112 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5113 Report overflow in size calculations when allocating printf buffer.
5114 Do not truncate output string at its first null byte.
5115 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5116 Truncate the output at a character boundary, since vsnprintf does not
5117 do that.
5118 * charset.c (check_iso_charset_parameter): Convert internal
5119 character to string before calling 'error', since %c now has the
5120 printf meaning.
5121 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5122 overflow when computing char to be passed to 'error'. Do not
5123 pass Lisp_Object to 'error'; pass the integer instead.
5124 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5125 formatted with plain %d.
5126
b189fa66
PE
5127 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5128
bff87ef0
PE
5129 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5130
7e2cac20
PE
5131 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5132
ce4d90b5
PE
5133 * xterm.c (x_catch_errors): Remove duplicate declaration.
5134
266c9547
PE
5135 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5136
79c49ad2
PE
5137 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5138
368f4090
JM
51392011-04-10 Jim Meyering <meyering@redhat.com>
5140
5141 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5142 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5143 return ssize_t not "int", and use size_t as the buffer length.
5144 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5145 * gnutls.h: Update declarations.
5146 * process.c (read_process_output): Use ssize_t, to match.
5147 (send_process): Likewise.
5148
a32d4040
CY
51492011-04-09 Chong Yidong <cyd@stupidchicken.com>
5150
5151 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5152
8546720e 51532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5154
04f2d78b
CB
5155 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5156 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5157
8546720e
GM
5158 * xterm.c (handle_one_xevent):
5159 * xmenu.c (create_and_show_popup_menu):
5160 * xselect.c (x_decline_selection_request)
5161 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5162
0a2f5c1a 51632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5164
5165 Fix some uses of `int' instead of EMACS_INT.
5166 * search.c (string_match_1, fast_string_match)
5167 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5168 (scan_buffer, find_next_newline_no_quit)
5169 (find_before_next_newline, search_command, Freplace_match)
5170 (Fmatch_data): Make some `int' variables be EMACS_INT.
5171
5172 * xdisp.c (display_count_lines): 3rd argument and return value now
5173 EMACS_INT. All callers changed.
5174 (pint2hrstr): Last argument is now EMACS_INT.
5175
5176 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5177 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5178 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5179 (decode_coding_utf_16, decode_coding_emacs_mule)
5180 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5181 (decode_coding_ccl, decode_coding_charset)
5182 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5183 (decode_coding_iso_2022, decode_coding_emacs_mule)
5184 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5185 <char_offset, last_offset>: Declare EMACS_INT.
5186 (encode_coding_utf_8, encode_coding_utf_16)
5187 (encode_coding_emacs_mule, encode_invocation_designation)
5188 (encode_designation_at_bol, encode_coding_iso_2022)
5189 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5190 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5191 Declare EMACS_INT.
5192 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5193 (encode_invocation_designation): Last argument P_NCHARS is now
5194 EMACS_INT.
5195 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5196 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5197
5198 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5199 All users changed.
5200
5201 * ccl.c (Fccl_execute_on_string): Declare some variables
5202 EMACS_INT.
5203
8546720e 52042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
5205
5206 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5207
4e19a977
CS
52082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5209
5210 * process.c (Fformat_network_address): Doc fix.
5211
87302331
R
52122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5213
5214 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5215
cbb59342
CY
52162011-04-08 Chong Yidong <cyd@stupidchicken.com>
5217
5218 * keyboard.c (read_char): Call Lisp function help-form-show,
5219 instead of using internal_with_output_to_temp_buffer.
5220 (Qhelp_form_show): New var.
e0d38eeb 5221 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
5222
5223 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5224
5225 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5226
e67a13ab
CY
52272011-04-06 Chong Yidong <cyd@stupidchicken.com>
5228
04f2d78b
CB
5229 * process.c (Flist_processes): Remove to Lisp.
5230 (list_processes_1): Delete.
e67a13ab 5231
973f782d
EZ
52322011-04-06 Eli Zaretskii <eliz@gnu.org>
5233
7c106b1e
EZ
5234 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5235
973f782d
EZ
5236 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5237
41cf7d1a 52382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 5239
ca23cc88
PE
5240 Fix more problems found by GCC 4.6.0's static checks.
5241
f390e2d5
PE
5242 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5243
42eea0d0
PE
5244 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5245
b69769da 5246 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 5247
f9541e84
PE
5248 * xdisp.c (vmessage): Mark as a printf-like function.
5249
13841b55
PE
5250 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5251
c136c10f
PE
5252 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5253
5e2d4a30
PE
5254 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5255 printf-like functions.
5256 (tiff_load): Add casts to remove these marks before passing them
5257 to system-supplied API.
5258
583f48b9
PE
5259 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5260
b25d760e
PE
5261 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5262 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
5263 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5264 directly, rather than having caller test rule sign. This avoids
5265 some unnecessary tests.
5266 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5267 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5268 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 5269
bc7b6697 5270 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 5271 (xfont_open): Avoid unnecessary tests.
bc7b6697 5272
27ccc379
PE
5273 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5274
dcd5c89a
PE
5275 * composite.h, composite.c (composition_gstring_put_cache):
5276 Use EMACS_INT, not int, for length.
5277
b13a45c6
PE
5278 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5279 breaking out part of COMPOSITION_DECODE_RULE.
5280 (COMPOSITION_DECODE_RULE): Use it.
5281 * composite.c (get_composition_id): Remove unused local vars,
5282 by using the new macro.
5283
1e792e4d
PE
5284 * textprop.c (set_text_properties_1): Change while to do-while,
5285 since the condition is always true at first.
5286
dc6c6455 5287 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5288 (interval_deletion_adjustment): Return unsigned value.
5289 All uses changed.
dc6c6455 5290
aba7731a
PE
5291 * process.c (list_processes_1, create_pty, read_process_output):
5292 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5293 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5294 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5295 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5296 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5297
fdfc4bf3
PE
5298 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5299
fca8fe46 5300 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5301 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5302
06a0259a 5303 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5304 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5305 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5306
e7b9e80f
PE
5307 * print.c (print_error_message): Avoid int overflow.
5308
56201685
PE
5309 * font.c (font_list_entities): Redo for clarity,
5310 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5311
78834453 5312 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5313 (font_score): Avoid potential overflow in diff calculation.
78834453 5314
0bc0b309 5315 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5316 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5317
e610eaca
PE
5318 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5319
b895abce
PE
5320 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5321 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5322 can always succeed if overflow has undefined behavior.
5323
1f1d9321 5324 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5325 (wordify): Omit three unnecessary tests.
1f1d9321 5326
c59478bc
PE
5327 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5328 All callers changed. This avoids the need for an unused var.
5329
79b73827
PE
5330 * casefiddle.c (casify_region): Remove var that is set but not used.
5331
a4db5dfe
PE
5332 * dired.c (file_name_completion): Remove var that is set but not used.
5333
43aae36e
PE
5334 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5335
2a47c44d 5336 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5337 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5338
a37c69bf
PE
5339 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5340 Check for integer overflow on size calculations.
5341
328ab8e7
PE
5342 * buffer.c (Fprevious_overlay_change): Remove var that is set
5343 but not used.
5344
e5a2a5cb
PE
5345 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5346 Remove vars that are set but not used.
8d84a6eb 5347 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5348 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5349
a60e5f68
PE
5350 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5351
f661cb61 5352 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5353 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5354
f0397f5a
PE
5355 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5356 that are set but not used.
5357
8664db06 5358 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5359 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5360
6abdaa4a
PE
5361 * xselect.c (x_get_local_selection, x_handle_property_notify):
5362 Remove vars that are set but not used.
5363
0ce7538d 5364 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5365 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5366
9ae848fc
PE
5367 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5368 Remove var that is set but not used.
0b918413
PE
5369 (scroll_bar_windows_size): Now size_t, not int.
5370 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5371 Check for overflow.
9ae848fc 5372
a5a62657
PE
5373 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5374 (map_tty_color) [!defined MSDOS]: Likewise.
5375
5c5cdd39
PE
5376 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5377
66ebf983
PE
5378 * coding.c: Remove vars that are set but not used.
5379 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5380 All callers changed.
5381 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5382 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5383 (decode_coding_charset): Remove vars that are set but not used.
5384
1be4d761
PE
5385 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5386 that is set but not used.
5387
47553fa8
PE
5388 * print.c (print_object): Remove var that is set but not used.
5389
1f7196bf 5390 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5391 The gnulib version avoids calling malloc in the usual case,
5392 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5393 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5394 * filelock.c (current_lock_owner): Likewise.
5395 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5396 * sysdep.c: Include allocator.h, careadlinkat.h.
5397 (emacs_no_realloc_allocator): New static constant.
5398 (emacs_readlink): New function.
fdb61804
PE
5399 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5400 ../lib/careadlinkat.h.
d1fdcab7 5401
f84c17c7
SM
54022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5403
5404 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5405 first non-nil return value).
5406
ef3862ad
JD
54072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5408
5409 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5410 if not defined (Bug#8403).
5411
376a7006
JB
54122011-04-02 Juanma Barranquero <lekktu@gmail.com>
5413
5414 * xdisp.c (display_count_lines): Remove parameter `start',
5415 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5416 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5417 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5418 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5419 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5420 and thereabouts. All callers changed.
5421 (get_per_char_metric): Remove parameter `f', unused since
5422 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5423
6ca3801d
JM
54242011-04-02 Jim Meyering <meyering@redhat.com>
5425
5426 do not dereference NULL upon failed strdup
5427 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5428 (ns_get_family): Likewise.
5429
d8e2b5ba
JB
54302011-04-02 Juanma Barranquero <lekktu@gmail.com>
5431
5432 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5433
8c74fcbd
JD
54342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5435
5436 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5437 later (Bug#8403).
5438
7200d79c
SM
54392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5440
03408648 5441 Add lexical binding.
7200d79c 5442
03408648
SM
5443 * window.c (Ftemp_output_buffer_show): New fun.
5444 (Fsave_window_excursion):
5445 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5446
5447 * lread.c (lisp_file_lexically_bound_p): New function.
5448 (Fload): Bind Qlexical_binding.
5449 (readevalloop): Remove `evalfun' arg.
5450 Bind Qinternal_interpreter_environment.
5451 (Feval_buffer): Bind Qlexical_binding.
5452 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5453 Mark as dynamic.
5454 (syms_of_lread): Declare `lexical-binding'.
5455
5456 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5457
5458 * keyboard.c (eval_dyn): New fun.
5459 (menu_item_eval_property): Use it.
ca105506
SM
5460
5461 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5462
03408648
SM
5463 * fns.c (concat, mapcar1): Accept byte-code-functions.
5464
5465 * eval.c (Fsetq): Handle lexical vars.
5466 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5467 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5468 (FletX, Flet): Obey lexical binding.
5469 (Fcommandp): Handle closures.
5470 (Feval): New `lexical' arg.
5471 (eval_sub): New function extracted from Feval. Use it almost
5472 everywhere where Feval was used. Look up vars in lexical env.
5473 Handle closures.
5474 (Ffunctionp): Move from subr.el.
5475 (Ffuncall): Handle closures.
5476 (apply_lambda): Remove `eval_flags'.
5477 (funcall_lambda): Handle closures and new byte-code-functions.
5478 (Fspecial_variable_p): New function.
5479 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5480 but without exporting it to Lisp.
23aba0ea 5481
23aba0ea 5482 * doc.c (Fdocumentation, store_function_docstring):
03408648 5483 * data.c (Finteractive_form): Handle closures.
23aba0ea 5484
03408648
SM
5485 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5486 interactive spec.
ba83908c 5487
04f2d78b
CB
5488 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5489 New byte-codes.
03408648
SM
5490 (exec_byte_code): New function extracted from Fbyte_code to handle new
5491 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5492
03408648 5493 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5494
03408648 5495 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5496
e2abce01
JB
54972011-03-31 Juanma Barranquero <lekktu@gmail.com>
5498
5499 * xdisp.c (redisplay_internal): Fix prototype.
5500
63696a73 55012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5502
63696a73 5503 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5504 (try_scrolling): Use it when setting scroll_limit.
5505 Limit scrolling to 100 screen lines.
63696a73
EZ
5506 (redisplay_window): Even when falling back on "recentering",
5507 position point in the window according to scroll-conservatively,
5508 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5509
5510 (try_scrolling): When point is above the window, allow searching
5511 as far as scroll_max, or one screenful, to compute vertical
5512 distance from PT to the scroll margin position. This prevents
5513 try_scrolling from unnecessarily failing when
5514 scroll-conservatively is set to a value slightly larger than the
5515 window height. Clean up the case of PT below the margin at bottom
5516 of window: scroll_max can no longer be INT_MAX. When aggressive
5517 scrolling is in use, don't let point enter the opposite scroll
5518 margin as result of the scroll.
5519 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5520 threshold of 100 lines for never-recentering scrolling.
5521
e4cc2dfc
JB
55222011-03-31 Juanma Barranquero <lekktu@gmail.com>
5523
5524 * dispextern.h (move_it_by_lines):
5525 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5526 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5527 (message_log_check_duplicate): Remove parameters `prev_bol' and
5528 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5529 (redisplay_internal): Remove parameter `preserve_echo_area',
5530 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5531
5532 * indent.c (Fvertical_motion):
5533 * window.c (window_scroll_pixel_based, Frecenter):
5534 Don't pass `need_y_p' to `move_it_by_lines'.
5535
1c470562
SM
55362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5537
44f230aa
SM
5538 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5539 steal a few bits to be more compact.
5540 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5541 Remove unneeded casts.
5542
1c470562
SM
5543 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5544
888adce9
ZK
55452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5546
5547 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5548 binding" message (bug#7967).
5549
f838ed7b
PE
55502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5551
77861b95
PE
5552 Fix more problems found by GCC 4.6.0's static checks.
5553
de6dbc14
PE
5554 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5555 Remove unused local var.
5556
f838ed7b
PE
5557 * editfns.c (Fmessage_box): Remove unused local var.
5558
792c7b2b
PE
5559 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5560 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5561 Omit unused local vars.
c499e557 5562 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5563 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5564 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5565 Omit unused local var.
5566
ba0165e1
PE
5567 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5568 Don't assume string length fits in int.
32ad8845 5569 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5570 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5571
3c59b4c9
PE
5572 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5573 instead of alloca (Bug#8344).
5574
a3eed478 5575 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5576 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5577
eb4d412d
PE
5578 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5579
1658b401
PE
5580 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5581 concerns.
5582
5583 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5584
5585 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5586
9a2c6e05
PE
5587 * keyboard.c (syms_of_keyboard): Use the same style as later
5588 in this function when indexing through an array. This also
5589 works around GCC bug 48267.
5590
03d0a109
PE
5591 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5592
44f730c8
PE
5593 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5594
fe75f926
PE
5595 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5596 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5597
ffa8c828
PE
5598 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5599 This avoids undefined behavior on integer overflow, and is a bit
5600 more convenient anyway since it is compared to a size_t variable.
5601
c5101a77
PE
5602 Variadic C functions now count arguments with size_t, not int.
5603 This avoids an unnecessary limitation on 64-bit machines, which
5604 caused (substring ...) to crash on large vectors (Bug#8344).
5605 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5606 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5607 All variadic functions and their callers changed accordingly.
c5101a77
PE
5608 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5609 * data.c (arith_driver, float_arith_driver): Likewise.
5610 * editfns.c (general_insert_function): Likewise.
5611 * eval.c (struct backtrace.nargs, interactive_p)
5612 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5613 (funcall_lambda, mark_backtrace): Likewise.
5614 * fns.c (concat): Likewise.
5615 * frame.c (x_set_frame_parameters): Likewise.
5616 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5617 0 if not found, not -1. All callers changed.
5618
dd3f25f7
PE
5619 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5620 (stack_copy_size): Now size_t, not int.
5621 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5622
461c2ab9
JB
56232011-03-28 Juanma Barranquero <lekktu@gmail.com>
5624
5625 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5626 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5627 All callers changed.
5628
5629 * lisp.h (multibyte_char_to_unibyte):
5630 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5631 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5632 * character.h (CHAR_TO_BYTE8):
5633 * cmds.c (internal_self_insert):
5634 * editfns.c (general_insert_function):
5635 * keymap.c (push_key_description):
5636 * search.c (Freplace_match):
5637 * xdisp.c (message_dolog, set_message_1): All callers changed.
5638
f6d62986
SM
56392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5640
5641 * keyboard.c (safe_run_hook_funcall): New function.
5642 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5643 don't set the hook to nil, but remove the offending function instead.
5644 (Qcommand_hook_internal): Remove, unused.
5645 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5646 Vcommand_hook_internal.
5647
5648 * eval.c (enum run_hooks_condition): Remove.
5649 (funcall_nil, funcall_not): New functions.
5650 (run_hook_with_args): Call each function through a `funcall' argument.
5651 Remove `cond' argument, now redundant.
5652 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5653 (Frun_hook_with_args_until_failure): Adjust accordingly.
5654 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5655
1db5b1ad
JB
56562011-03-28 Juanma Barranquero <lekktu@gmail.com>
5657
5658 * dispextern.h (string_buffer_position): Remove declaration.
5659
5660 * print.c (strout): Remove parameter `multibyte', unused since
5661 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5662
5663 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5664 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5665 All callers changed.
5666
5667 * w32.c (_wsa_errlist): Use braces for struct initializers.
5668
5669 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5670 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5671 All callers changed.
5672 (string_buffer_position): Likewise. Also, make static (it's never
5673 used outside xdisp.c).
5674 (cursor_row_p): Remove parameter `w', unused since
5675 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5676 (decode_mode_spec): Remove parameter `precision', introduced during
5677 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5678 All callers changed.
5679
5ffb62aa
JD
56802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5681
5682 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5683
461c2ab9 56842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5685
5686 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5687 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5688 (ns_update_auto_hide_menu_bar): New functions.
5689 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5690 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5691 ns_constrain_all_frames.
5692 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5693 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5694
5c380ffb
JD
56952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5696
5697 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5698
9af30bdf
GM
56992011-03-27 Glenn Morris <rgm@gnu.org>
5700
5701 * syssignal.h: Replace RETSIGTYPE with void.
5702 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5703 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5704 Replace SIGTYPE with void everywhere.
5705 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5706 * s/template.h (SIGTYPE): Remove commented out definition.
5707
e2abce01
JB
57082011-03-26 Eli Zaretskii <eliz@gnu.org>
5709
5710 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5711 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5712
f868cd8a
JB
57132011-03-26 Juanma Barranquero <lekktu@gmail.com>
5714
59eb0929
JB
5715 * w32.c (read_unc_volume): Use parameter `henum', instead of
5716 global variable `wget_enum_handle'.
5717
5718 * keymap.c (describe_vector): Remove parameters `indices' and
5719 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5720 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5721
f868cd8a
JB
5722 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5723
5724 * keyboard.c (timer_check): Remove parameter `do_it_now',
5725 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5726 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5727 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5728
5729 * keyboard.c (read_char):
5730 * w32menu.c (w32_menu_display_help):
5731 * xmenu.c (show_help_event, menu_help_callback):
5732 Adjust calls to `show_help_echo'.
5733
5734 * gtkutil.c (xg_maybe_add_timer):
5735 * keyboard.c (readable_events):
5736 * process.c (wait_reading_process_output):
5737 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5738
5739 * insdel.c (adjust_markers_gap_motion):
5740 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5741 (gap_left, gap_right): Don't call it.
5742
2ecf6fdb
CY
57432011-03-25 Chong Yidong <cyd@stupidchicken.com>
5744
5745 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5746 incurred during fontification.
5747
6b1f9ba4
JB
57482011-03-25 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5751 (DEFVAR_PER_BUFFER): Don't pass it.
5752
5753 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5754 (scrolling_window): Don't pass it.
5755
0f4a96b5
JB
57562011-03-25 Juanma Barranquero <lekktu@gmail.com>
5757
5758 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5759
5760 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5761 and `suffix'.
5762 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5763 of variables specific to SELinux and computation of `encoded_absname'.
5764
5765 * image.c (XPutPixel): Remove unused variable `height'.
5766
5767 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5768
5769 * unexw32.c (get_section_info): Remove unused variable `section'.
5770
5771 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5772 (system_process_attributes): Remove unused variable `sess'.
5773 (sys_read): Remove unused variable `err'.
5774
5775 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5776 (w32_wnd_proc): Remove unused variable `isdead'.
5777 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5778 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5779 (x_create_tip_frame): Remove unused variable `tem'.
5780
5781 * w32inevt.c (w32_console_read_socket):
5782 Remove unused variable `no_events'.
5783
5784 * w32term.c (x_draw_composite_glyph_string_foreground):
5785 Remove unused variable `width'.
5786
1149507c
JB
57872011-03-24 Juanma Barranquero <lekktu@gmail.com>
5788
5789 * w32term.c (x_set_glyph_string_clipping):
5790 Don't pass uninitialized region to CombineRgn.
5791
9c88f339
JB
57922011-03-23 Juanma Barranquero <lekktu@gmail.com>
5793
5794 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5795 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5796 (Fx_close_connection): Remove unused variable `i'.
5797
5798 * w32font.c (w32font_draw): Return number of glyphs.
5799 (w32font_open_internal): Remove unused variable `i'.
5800 (w32font_driver): Add missing initializer.
5801
5802 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5803 (fill_in_menu): Remove unused variable `items_added'.
5804
5805 * w32term.c (last_mouse_press_frame): Remove static global variable.
5806 (w32_clip_to_row): Remove unused variable `f'.
5807 (x_delete_terminal): Remove unused variable `i'.
5808
5809 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5810 (NOTHING): Remove unused static global variable.
5811 (uniscribe_check_otf): Remove unused variable `table'.
5812 (uniscribe_font_driver): Add missing initializers.
5813
dee091a3
JD
58142011-03-23 Julien Danjou <julien@danjou.info>
5815
5816 * term.c (Fsuspend_tty, Fresume_tty):
5817 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5818 * window.c (temp_output_buffer_show):
5819 * insdel.c (signal_before_change):
5820 * frame.c (Fhandle_switch_frame):
5821 * fileio.c (Fdo_auto_save):
5822 * emacs.c (Fkill_emacs):
5823 * editfns.c (save_excursion_restore):
5824 * cmds.c (internal_self_insert):
5825 * callint.c (Fcall_interactively):
5826 * buffer.c (Fkill_all_local_variables):
5827 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5828 Use Frun_hooks.
0f4a96b5 5829 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5830 unconditionnaly since it does the check itself.
5831
2c520ab5 58322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5833
c9c49752
PE
5834 Fix more problems found by GCC 4.5.2's static checks.
5835
8abc3f12
PE
5836 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5837 the first time through the loop, since we know p0 < p1 then.
5838 This also avoids a gcc -Wstrict-overflow warning.
5839
a2d26660
PE
5840 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5841 leading to a memory leak, possible in functions like
5842 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5843 of objects (Bug#8318).
a2d26660 5844
916c72e9
PE
5845 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5846 that could (at least in theory) be that large.
5847
19ab8a18
PE
5848 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5849 This is less likely to overflow, and avoids undefined behavior if
5850 overflow does occur. All callers changed. Use strtoul to scan
5851 for the unsigned long integer.
b7cbbd6f
PE
5852 (pint2hrstr): Simplify and tune code slightly.
5853 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5854
f0641eff
PE
5855 * scroll.c (do_scrolling): Work around GCC bug 48228.
5856 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5857
7f650bb9
PE
5858 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5859 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5860 (validate_x_resource_name): Simplify count usage.
5861 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5862
37dd57d1
PE
5863 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5864 fail (Bug#8306).
81e56e61 5865
699979fc 5866 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5867
401bf9b4
PE
5868 * process.c (Fmake_network_process): Use socklen_t, not int,
5869 where POSIX says socklen_t is required in portable programs.
5870 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5871 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5872 (Fmake_network_process, server_accept_connection):
5873 (wait_reading_process_output, read_process_output):
5874 Likewise.
5875
b93aacde
PE
5876 * process.c: Rename or move locals to avoid shadowing.
5877 (list_processes_1, Fmake_network_process):
5878 (read_process_output_error_handler, exec_sentinel_error_handler):
5879 Rename or move locals.
4dc343ee 5880 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5881 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5882 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5883 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5884 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5885
af8a867c 5886 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5887 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5888 Include tparam.h instead, since it declares them.
af8a867c
PE
5889 * cm.h (PC): Remove extern decl; tparam.h now does this.
5890 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5891 * terminfo.c: Include tparam.h, to check interfaces.
5892 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5893 (tparam): Adjust signature to match interface in tparam.h;
5894 this removes some undefined behavior. Check that outstring and len
5895 are zero, which they always are with Emacs.
5896 * tparam.h (PC, BC, UP): New extern decls.
5897
0248044d 5898 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5899 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5900
8ff096c1 5901 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5902 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5903 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5904 (ftfont_list): Remove unused local.
49eaafba
PE
5905 (get_adstyle_property, ftfont_pattern_entity):
5906 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5907 Rename locals to avoid shadowing.
8ff096c1 5908
e2be39f6
PE
5909 * xfont.c (xfont_list_family): Mark var as initialized.
5910
c9735e30
PE
5911 * xml.c (make_dom): Now static.
5912
8f5201ae
PE
5913 * composite.c (composition_compute_stop_pos): Rename local to
5914 avoid shadowing.
b246f932
PE
5915 (composition_reseat_it): Remove unused locals.
5916 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5917 (composition_update_it): Mark var as initialized.
11b61122
PE
5918 (find_automatic_composition): Mark vars as initialized,
5919 with a FIXME (Bug#8290).
8f5201ae 5920
760fbc2c
PE
5921 character.h: Rename locals to avoid shadowing.
5922 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5923 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5924 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5925 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5926 to avoid shadowing.
5927
ff08eb85
PE
5928 * textprop.c (property_change_between_p): Remove; unused.
5929
fc7bf025
PE
5930 * intervals.c (interval_start_pos): Now static.
5931
235d7abc
PE
5932 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5933
44f230aa
SM
5934 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5935 Rename locals to avoid shadowing.
3e7d6594 5936
50060332
PE
5937 * sound.c (wav_play, au_play, Fplay_sound_internal):
5938 Fix pointer signedness.
d01f234b 5939 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5940 (wav_play): Initialize a variable to 0, to prevent undefined
5941 behavior (Bug#8278).
50060332 5942
c4fc4e30
PE
5943 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5944
918436ed
PE
5945 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5946
c939f91b
PE
5947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5948 clobbering (Bug#8298).
b9c7f648
PE
5949 * sysdep.c (sys_subshell): Likewise.
5950 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5951
6bd8c144
PE
5952 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5953 This should get cleaned up, so that child_setup has the
5954 same signature on all platforms.
5955
7710357c 5956 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5957 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5958
c59da222
CY
59592011-03-22 Chong Yidong <cyd@stupidchicken.com>
5960
5961 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5962 not to be necessary, and produces flickering.
5963
66b87493
GM
59642011-03-20 Glenn Morris <rgm@gnu.org>
5965
5966 * config.in: Remove file.
5967
45b6f6d5
JB
59682011-03-20 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5971 are now in src/globals.h.
5972 (syms_of_minibuf): Remove spurious & from previous change.
5973
3ec03f7e
LL
59742011-03-20 Leo <sdl.web@gmail.com>
5975
5976 * minibuf.c (completing-read-function): New variable.
5977 (completing-read-default): Rename from completing-read.
5978 (completing-read): Call completing-read-function.
5979
b14e3e21
CY
59802011-03-19 Juanma Barranquero <lekktu@gmail.com>
5981
5982 * xfaces.c (Fx_load_color_file):
5983 Read color file from absolute filename (bug#8250).
5984
f2b726e6
JB
59852011-03-19 Juanma Barranquero <lekktu@gmail.com>
5986
5987 * makefile.w32-in: Update dependencies.
5988
09f6ff02
EZ
59892011-03-17 Eli Zaretskii <eliz@gnu.org>
5990
5991 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5992
29a6015a
PE
59932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5994
a3a6c54e
PE
5995 Fix more problems found by GCC 4.5.2's static checks.
5996
b766f867
PE
5997 * process.c (make_serial_process_unwind, send_process_trap):
5998 (sigchld_handler): Now static.
5999
be02381c
PE
6000 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6001 That way, the code declares only the vars that it needs.
6002 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6003 * s/cygwin.h (PTY_ITERATION): Likewise.
6004 * s/darwin.h (PTY_ITERATION): Likewise.
6005 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6006
57048744
PE
6007 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6008 * process.c (allocate_pty): Don't declare stb unless it's needed.
6009
7914961c 6010 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6011 (CONSTANTLIM): Remove; unused.
6012 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6013 Define only if needed.
7914961c 6014
b3967b18
PE
6015 * unexelf.c (unexec): Name an expression,
6016 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6017 Use a different way to cause a compilation error if anyone uses
6018 n rather than nn, a way that does not involve shadowing.
73366a00 6019 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6020
29a6015a
PE
6021 * deps.mk (unexalpha.o): Remove; unused.
6022
43cfc33e 6023 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6024 * unexec.h: New file.
ce701a33
PE
6025 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6026 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6027 Depend on unexec.h.
6028 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6029 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6030 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6031 Change as necessary to match prototype in unexec.h.
ce701a33 6032
01f44d5a
PE
6033 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6034 shadowing.
4f63c6bb 6035 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6036
a6670b0b
PE
6037 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6038 Rename locals to avoid shadowing.
6039
cef2010d 6040 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6041 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6042
d4d7173a
PE
6043 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6044
f08b802a
PE
6045 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6046 warning when compiling print.c.
6047
3ddb0639
PE
6048 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6049 instead of using an uninitialized var.
5ad03b97 6050 (font_sort_entities): Mark var as initialized.
3ddb0639 6051
170a2692
PE
6052 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6053
e663c700
PE
6054 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6055 pointers to constants.
89bc529a 6056 (font_parse_fcname): Remove unused vars.
7b81e2d0 6057 (font_delete_unmatched): Now static.
ea838e10 6058 (font_get_spec): Remove; unused.
13a547c6
PE
6059 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6060 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6061 Rename or move locals to avoid shadowing.
e663c700 6062
2a80c887 6063 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6064 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6065
1384fa33 6066 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6067 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6068
8b2c52e9
PE
6069 * alloc.c (mark_backtrace): Move decl from here ...
6070 * lisp.h: ... to here, so that it can be checked.
6071
475545b5 6072 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6073 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6074 (lisp_indirect_variable): Name an expression,
6075 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6076 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6077
b1349114 6078 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6079 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6080 Use const pointer when appropriate.
b1349114 6081
a2928364
PE
6082 * lisp.h (get_system_name, get_operating_system_release):
6083 Move decls here, to check interfaces.
6084 * process.c (get_operating_system_release): Move decl to lisp.h.
6085 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6086 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6087 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6088 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6089 (Fformat_time_string, Fencode_time, Finsert_char):
6090 (Ftranslate_region_internal, Fformat):
6091 Rename or remove local vars to avoid shadowing.
9710023e 6092 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6093
a415e694
PE
6094 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6095 avoid shadowing.
6096
8ef4622d
PE
6097 * lisp.h (eassert): Check that the argument compiles, even if
6098 ENABLE_CHECKING is not defined.
6099
946f9a5b
PE
6100 * data.c (Findirect_variable): Name an expression, to avoid
6101 gcc -Wbad-function-cast warning.
112396d6 6102 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6103 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6104 (Fmake_variable_buffer_local, Fmake_local_variable):
6105 Mark variables as initialized.
52746918 6106 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6107
e5aab7e7 6108 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6109 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6110 Rename locals to avoid shadowing.
dff45157
PE
6111 (mark_stack): Move local variables into the #ifdef region where
6112 they're used.
7bc26fdb
PE
6113 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6114 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6115 needed otherwise.
6116 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6117 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6118 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6119
e5aab7e7
PE
6120 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6121 avoids undefined behavior in theory.
6122
4da60324
PE
6123 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6124
88043301
PE
6125 Use functions, not macros, for up- and down-casing (Bug#8254).
6126 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6128 to use the following functions instead of these macros.
6129 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6130 EMACS_INT, since callers assume the returned value fits in int.
6131 (upcase1): Likewise, for UPCASE_TABLE.
6132 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6133 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6134 the race-condition problem in the old DOWNCASE.
88043301 6135
19ed5445
PE
6136 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6137 Rename locals to avoid shadowing.
6138 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6139 (regex_compile, re_search_2, re_match_2_internal):
6140 Remove unused local vars.
952db0d7
PE
6141 (FREE_VAR): Rewrite so as not to use empty "else",
6142 which gcc can warn about.
da053e48 6143 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6144 (RETALLOC_IF): Define only if needed.
6145 (WORDCHAR_P): Likewise. This one is never needed, but is used
6146 only in a comment talking about a compiler bug, so put inside
6147 the #if 0 of that comment.
6148 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6149 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6150 Remove; unused.
19ed5445 6151
1f3561e4 6152 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6153 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6154 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6155
ded6f8f7
PE
6156 * search.c (simple_search): Remove unused var.
6157
dbd37a95
PE
6158 * dired.c (compile_pattern): Move decl from here ...
6159 * lisp.h: ... to here, so that it can be checked.
6160 (struct re_registers): New forward decl.
6161
7e47afad
PE
6162 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6163
85f24f61
PE
6164 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6165 All uses changed.
6166 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6167 Rename locals to avoid shadowing.
5671df8f 6168 (Fvertical_motion): Mark locals as initialized.
85f24f61 6169
181aa2be 6170 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 6171 (casify_region): Mark local as initialized.
181aa2be 6172
930d429c
PE
6173 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6174
7082eac6
PE
6175 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6176 New macros, so that the caller can use some names other than
6177 gcpro1, gcpro2, etc.
6178 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6179 of the new macros.
6180 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6181 argument, for consistency with GCPRO2_VAR, etc: it is now the
6182 prefix of the variable, not the variable itself. All uses
6183 changed.
38b2c076
PE
6184 * dired.c (directory_files_internal, file_name_completion):
6185 Rename locals to avoid shadowing.
6186
15206ed9
PE
6187 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6188 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6189 dired.c's scmp function, had undefined behavior.
6190 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6192 * buffer.h: ... to here, because these macros use current_buffer,
6193 and the new implementation with inline functions needs to have
6194 current_buffer in scope now, rather than later when the macros
6195 are used.
6196 (downcase, upcase1): New static inline functions.
6197 (DOWNCASE, UPCASE1): Reimplement using these functions.
6198 This avoids undefined behavior in expressions like
6199 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6200 from race conditions in accessing the global variables
6201 case_temp1 and case_temp2.
6202 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6203 * lisp.h (case_temp1, case_temp2): Remove their decls.
6204 * character.h (ASCII_CHAR_P): Move from here ...
6205 * lisp.h: ... to here, so that the inline functions mentioned
6206 above can use them.
6207
4a6bea26
PE
6208 * dired.c (directory_files_internal_unwind): Now static.
6209
f14b7e14
PE
6210 * fileio.c (file_name_as_directory, directory_file_name):
6211 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6212 Now static.
2893f146
PE
6213 (file_name_as_directory): Use const pointers when appropriate.
6214 (Fexpand_file_name): Likewise. In particular, newdir might
6215 point at constant storage, so make it a const pointer.
fd4ead52 6216 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
6217 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6218 signedness issues.
f839df0c
PE
6219 (Fset_file_times, Finsert_file_contents, auto_save_error):
6220 Rename locals to avoid shadowing.
f14b7e14 6221
5716756e 6222 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
6223 (Ftry_completion, Fall_completions): Rename or remove locals
6224 to avoid shadowing.
5716756e 6225
b4c3046a
PE
6226 * marker.c (bytepos_to_charpos): Remove; unused.
6227
b45db522
PE
6228 * lisp.h (verify_bytepos, count_markers): New decls,
6229 so that gcc does not warn that these functions aren't declared.
6230
85876d07
PE
6231 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6232 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 6233 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 6234 (copy_text): Remove unused local var.
85876d07 6235
03d78a21 6236 * filelock.c (within_one_second): Now static.
b3dd38ab 6237 (lock_file_1): Rename local to avoid shadowing.
03d78a21 6238
5df8f01b
PE
6239 * buffer.c (fix_overlays_before): Mark locals as initialized.
6240 (fix_start_end_in_overlays): Likewise. This function should be
6241 simplified by using pointers-to-pointers, but that's a different
6242 matter.
b1d876f1 6243 (switch_to_buffer_1): Now static.
8f54f30a
PE
6244 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6245 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 6246
a70072c9 6247 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 6248 Fix pointer signedness issue.
edced198
PE
6249 (sys_subshell): Mark local as volatile if checking for lint,
6250 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 6251 (MAXPATHLEN): Define only if needed.
a70072c9 6252
a0977c44
PE
6253 * process.c (serial_open, serial_configure): Move decls from here ...
6254 * systty.h: ... to here, so that they can be checked.
6255
a884fdcc
PE
6256 * fns.c (get_random, seed_random): Move extern decls from here ...
6257 * lisp.h: ... to here, so that they can be checked.
6258
604efe86 6259 * sysdep.c (reset_io): Now static.
b8950c94 6260 (wait_for_termination_signal): Remove; unused.
604efe86 6261
38fc62d9
PE
6262 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6263 (copy_keymap_item, append_key, push_text_char_description):
6264 Now static.
1004a21a 6265 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 6266 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
6267 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6268 (describe_map_tree):
6269 Rename locals to avoid shadowing.
38fc62d9 6270
2f2650da
PE
6271 * keyboard.c: Declare functions static if they are not used elsewhere.
6272 (echo_char, echo_dash, cmd_error, top_level_2):
6273 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
6274 (read_char, kbd_buffer_get_event, make_lispy_position):
6275 (make_lispy_event, make_lispy_movement, apply_modifiers):
6276 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6277 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6278 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6279 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6280 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6281
a053e86c 6282 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6283 (mark_kboards): Move decl here ...
6284 * alloc.c (mark_kboards): ... from here.
a053e86c 6285
4752793e
PE
6286 * lisp.h (force_auto_save_soon): New decl.
6287
74f10ca7 6288 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6289 (DEFINE_DUMMY_FUNCTION): New macro.
6290 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6291 Use it.
c03cd23f
PE
6292 (main): Add casts to avoid warnings
6293 if GCC considers string literals to be constants.
74f10ca7 6294
022e70d4
PE
6295 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6296
59d6fe83
PE
6297 * dbusbind.c: Pointer signedness fixes.
6298 (xd_signature, xd_append_arg, xd_initialize):
6299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6301 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6302 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6303
78320123
PE
6304 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6305 if GCC considers string literals to be constants.
49cebcca 6306 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6307
35ac2a97
SM
63082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6309
fb103ca9
SM
6310 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6311 (print_preprocess, print_object): New macro to fix last change.
6312
35ac2a97
SM
6313 * print.c (print_preprocess): Don't forget font objects.
6314
62973b41
JB
63152011-03-16 Juanma Barranquero <lekktu@gmail.com>
6316
6317 * emacs.c (USAGE3): Doc fixes.
6318
0e48bb22
AS
63192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6320
6321 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6322 structure.
6323
7684e57b
JB
63242011-03-14 Juanma Barranquero <lekktu@gmail.com>
6325
6326 * lisp.h (VWindow_system, Qfile_name_history):
6327 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6328 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6329 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6330
6331 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6332 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6333
6334 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6335 * w32console.c (detect_input_pending, read_input_pending)
6336 (encode_terminal_code):
6337 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6338 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6339 (w32_system_caret_y, Qfile_name_history):
6340 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6341 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6342 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6343 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6344 * w32proc.c (Qlocal, report_file_error):
6345 * w32term.c (Vwindow_system, updating_frame):
6346 * w32uniscribe.c (initialized, uniscribe_font_driver):
6347 Remove unneeded extern declarations.
6348
2aa46d6c
CY
63492011-03-14 Chong Yidong <cyd@stupidchicken.com>
6350
c96bbc66 6351 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6352
cffc6f3b
CY
63532011-03-13 Chong Yidong <cyd@stupidchicken.com>
6354
6355 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6356 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6357 These macros can no longer be used for assignment.
6358
44f230aa
SM
6359 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6360 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6361 (record_buffer_markers, fetch_buffer_markers): New functions for
6362 recording and fetching special buffer markers.
6363 (set_buffer_internal_1, set_buffer_temp): Use them.
6364
6365 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6366
6367 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6368
6369 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6370 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6371
6372 * xdisp.c (hscroll_window_tree):
6373 (reconsider_clip_changes): Use PT instead of BUF_PT.
6374
d251f04b
EZ
63752011-03-13 Eli Zaretskii <eliz@gnu.org>
6376
6377 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6378 $(EMACS_ROOT)/lib/intprops.h.
6379
f0c77cd1
PE
63802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6381
3eca4629
PE
6382 Fix more problems found by GCC 4.5.2's static checks.
6383
7c86ee98
PE
6384 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6385 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6386 (xg_free_frame_widgets): Make it clear that a local variable is
6387 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6388 (gdk_window_get_screen): Make it clear that this macro is needed
6389 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6390 (int_gtk_range_get_value): New function, which avoids a diagnostic
6391 from gcc -Wbad-function-cast.
6392 (xg_set_toolkit_scroll_bar_thumb): Use it.
6393 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6394 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6395 (get_utf8_string, xg_get_file_with_chooser):
6396 Rename locals to avoid shadowing.
6397 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6398
41729b81
PE
6399 * xgselect.c (xg_select): Remove unused var.
6400
f0c77cd1
PE
6401 * image.c (four_corners_best): Mark locals as initialized.
6402 (gif_load): Initialize transparent_p to zero (Bug#8238).
6403 Mark another local as initialized.
ec6cf4c6 6404 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6405
ce0ad53d 6406 * image.c (clear_image_cache): Now static.
d5d5a617 6407 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6408 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6409 (x_edge_detection): Remove unnecessary cast that
6410 gcc -Wbad-function-cast diagnoses.
2037898d 6411 (gif_load): Fix pointer signedness.
6ae141d6
PE
6412 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6413 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6414
33383987 64152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6416
d32df629
PE
6417 Improve quality of tests for time stamp overflow.
6418 For example, without this patch (encode-time 0 0 0 1 1
6419 1152921504606846976) returns the obviously-bogus value (-948597
6420 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6421 reports time overflow. See
6422 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6423 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6424 * editfns.c: Include limits.h and intprops.h.
6425 (TIME_T_MIN, TIME_T_MAX): New macros.
6426 (time_overflow): Move earlier, to before first use.
6427 (hi_time, lo_time): New functions, for an accurate test for
6428 out-of-range times.
6429 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6430 (Fget_internal_run_time): Don't assume time_t fits in int.
6431 (make_time): Use list2 instead of Fcons twice.
6432 (Fdecode_time): More accurate test for out-of-range times.
6433 (check_tm_member): New function.
6434 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6435 (lisp_time_argument): Don't rely on undefined left-shift and
6436 right-shift behavior when checking for time stamp overflow.
8be6f318 6437
fe31d94c
PE
6438 * editfns.c (time_overflow): New function, refactoring common code.
6439 (Fformat_time_string, Fdecode_time, Fencode_time):
6440 (Fcurrent_time_string): Use it.
6441
8be6f318
PE
6442 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6443 * dired.c (make_time): Move to ...
6444 * editfns.c (make_time): ... here.
6445 * systime.h: Note the move.
6446
09d9db2c 64472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6448
126bc0dc
YM
6449 * fringe.c (update_window_fringes): Remove unused variables.
6450
c47cbdfd
YM
6451 * unexmacosx.c (copy_data_segment): Also copy __got section.
6452 (Bug#8223)
6453
7ac80be9
EZ
64542011-03-12 Eli Zaretskii <eliz@gnu.org>
6455
c96bbc66 6456 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6457 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6458 Constify `char *' arguments and their references according to
6459 prototypes in tparam.h.
6460
ecb0f94d 6461 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6462
7ac80be9
EZ
6463 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6464 Adapt all references accordingly.
6465
6466 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6467
ef1fd07e
TT
64682011-03-11 Tom Tromey <tromey@redhat.com>
6469
6470 * buffer.c (syms_of_buffer): Remove obsolete comment.
6471
7ef4b50c
EZ
64722011-03-11 Eli Zaretskii <eliz@gnu.org>
6473
6474 * termhooks.h (encode_terminal_code): Declare prototype.
6475
6476 * msdos.c (encode_terminal_code): Don't declare prototype.
6477
6478 * term.c (encode_terminal_code): Now external again, used by
6479 w32console.c and msdos.c.
6480
44f230aa
SM
6481 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6482 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6483
4b1ec863 64842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6485
1714f52b 6486 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6487
4b1ec863
PE
6488 * fringe.c (update_window_fringes): Mark locals as initialized
6489 (Bug#8227).
6490 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6491
524c7aa6
PE
6492 * alloc.c (mark_fringe_data): Move decl from here ...
6493 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6494 to check its interface.
6495 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6496
a5c0af81 6497 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6498 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6499 (fontset_font): Mark local as initialized.
a9a06e0b 6500 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6501
b4716021
PE
6502 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6503
811e9bac 6504 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6505 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6506 (x_own_selection, Fx_disown_selection_internal): Rename locals
6507 to avoid shadowing.
6508 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6509
7e3ab302
PE
6510 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6511 so that the caller can use some name other than gcpro1.
6512 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6513 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6514 (Fx_backspace_delete_keys_p):
6515 Use them to avoid shadowing, and rename vars to avoid shadowing.
6516 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6517 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6518 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6519 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6520 Remove unused locals.
7e3ab302
PE
6521 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6522 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6523 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6524 macros.
f78faa98 6525
e2b13473
PE
6526 * xterm.h (x_mouse_leave): New decl.
6527
77f23912
PE
6528 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6529 Remove unused functions.
cdf4ba58
PE
6530 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6531 (x_calc_absolute_position): Now static.
7411c686 6532 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6533 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6534 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6535 unless they are used.
38d0b34a
PE
6536 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6537 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6538 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6539 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6540 (x_error_catcher, x_connection_closed, x_error_handler):
6541 (x_error_quitter, xembed_send_message, x_iconify_frame):
6542 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6543 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6544 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6545
44f230aa
SM
6546 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6547 Rename or move locals to avoid shadowing.
6b463e58 6548 (tty_defined_color, merge_face_heights): Now static.
5967d051 6549 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6550 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6551 does not deduce is never used uninitialized.
73719eba
PE
6552 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6553 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6554
426994c3 6555 * terminal.c (store_terminal_param): Now static.
5489860b 6556
032f1620 6557 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6558 (set_frame_menubar): Remove unused local.
d4323972 6559 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6560 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6561 since they might point to immutable storage.
281585b0
PE
6562 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6563 since it's unused otherwise.
032f1620 6564
367c19e5 6565 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6566 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6567 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6568 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6569 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6570 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6571 does not deduce are never used uninitialized.
70739cbe 6572
07b48fa9
PE
6573 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6574
8868a238 6575 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6576 * window.c (window_loop, size_window):
6577 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6578
7e5cf297 6579 * window.c (display_buffer): Now static.
d6550a9f
PE
6580 (size_window): Mark variables that gcc -Wuninitialized
6581 does not deduce are never used uninitialized.
a586633d
PE
6582 * window.h (check_all_windows): New decl, to forestall
6583 gcc -Wmissing-prototypes diagnostic.
5b555da1 6584 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6585
f6095868
PE
6586 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6587 shadowing.
6588 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6589 Include <limits.h>.
6590 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6591 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6592 (load_charset_map): Mark variables that gcc -Wuninitialized
6593 does not deduce are never used uninitialized.
53df7c11 6594 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6595
f38b440c
PE
6596 * coding.c (coding_set_source, coding_set_destination):
6597 Use "else { /* comment */ }" rather than "else /* comment */;"
6598 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6599 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6600 a block, when the outer 'i' will do.
6601 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6602 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6604 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6605 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6606 Rename locals to avoid shadowing.
6607 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6608 * coding.c (emacs_mule_char, encode_invocation_designation):
6609 Now static, since they're not used elsewhere.
413bb2db 6610 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6611 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6612 (decode_coding_emacs_mule): Mark variables that gcc
6613 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6614 (detect_coding_iso_2022): Initialize a local variable that might
6615 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6616 this initialization is needed. (Bug#8211)
5f58e762
PE
6617 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6618 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6619 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6620 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6621 Remove unused macros.
f38b440c 6622
232b38b9 6623 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6624 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6625 * character.c (string_count_byte8): Likewise.
232b38b9 6626
fb90da1b
PE
6627 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6628 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6629
fb93dbc2
PE
6630 * chartab.c (copy_sub_char_table): Now static, since it's not used
6631 elsewhere.
5c156ace
PE
6632 (sub_char_table_ref_and_range, char_table_ref_and_range):
6633 Rename locals to avoid shadowing.
bbcd0949 6634 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6635
7d3b3862 6636 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6637 (BIDI_BOB): Remove unused macro.
7d3b3862 6638
6be7d3da
PE
6639 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6640 deduce are never used uninitialized.
c2ed9c8b 6641 * term.c (encode_terminal_code): Likewise.
6be7d3da 6642
75f8807f 6643 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6644
50938595
PE
6645 * tparam.h: New file.
6646 * term.c, tparam.h: Include it.
6647 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6648 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6649 Move these decls to tparam.h, and make them agree with what
6650 is actually in tparam.c. The previous trick of using incompatible
6651 decls in different modules does not conform to the C standard.
6652 All callers of tparam changed to use tparam's actual API.
6653 * tparam.c (tparam1, tparam, tgoto):
6654 Use const pointers where appropriate.
6655
fbceeba2
PE
6656 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6657 * cm.h (struct cm): Likewise.
6658 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6659 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6660 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6661 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6662 (turn_on_face, init_tty): Likewise.
6663 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6664
7f3f1250
PE
6665 * term.c (term_mouse_position): Rename local to avoid shadowing.
6666
e6ca6543
PE
6667 * alloc.c (mark_ttys): Move decl from here ...
6668 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6669
c40f8d15
AS
66702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6671
6672 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6673
cfe0661d
JB
66742011-03-09 Juanma Barranquero <lekktu@gmail.com>
6675
6676 * search.c (compile_pattern_1): Remove argument regp, unused since
6677 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6678 (compile_pattern): Don't pass it.
6679
0afb4571
J
66802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6681
6682 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6683 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6684 for ! HAVE_GTK3.
6685 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6686
6687 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6688
6689 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6690 gdk_window_get_screen, gdk_window_get_geometry,
6691 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6692 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6693 (xg_get_pixbuf_from_pixmap): New function.
6694 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6695 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6696 Call xg_get_pixbuf_from_pixmap instead of
6697 gdk_pixbuf_get_from_drawable.
6698 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6699 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6700 (xg_check_special_colors): Use GtkStyleContext and its functions
6701 for HAVE_GTK3.
6702 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6703 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6704 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6705 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6706 Call gtk_widget_get_preferred_size.
0afb4571
J
6707 (xg_frame_resized): gdk_window_get_geometry only takes 5
6708 parameters.
44f230aa
SM
6709 (xg_win_to_widget, xg_event_is_for_menubar):
6710 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6711 (xg_set_widget_bg): New function.
6712 (delete_cb): New function.
895009e1 6713 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6714 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6715 (xg_set_background_color): Call xg_set_widget_bg.
6716 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6717 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6718 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6719 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6720 if ! HAVE_GTK3.
6721 (update_frame_tool_bar): Call gtk_widget_hide.
6722 (xg_initialize): Use GDK_KEY_g.
6723
6724 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6725 if ! HAVE_GTK3
6726 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6727
6728 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6729 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6730 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6731
1c2cc4ef
JB
67322011-03-08 Juanma Barranquero <lekktu@gmail.com>
6733
6734 * w32xfns.c (select_palette): Check success of RealizePalette against
6735 GDI_ERROR, not zero.
6736
33383987 6737See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6738
6739;; Local Variables:
6740;; coding: utf-8
aac0c6e3
MR
6741;; End:
6742
33383987 6743 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6744
6745 This file is part of GNU Emacs.
6746
6747 GNU Emacs is free software: you can redistribute it and/or modify
6748 it under the terms of the GNU General Public License as published by
6749 the Free Software Foundation, either version 3 of the License, or
6750 (at your option) any later version.
6751
6752 GNU Emacs is distributed in the hope that it will be useful,
6753 but WITHOUT ANY WARRANTY; without even the implied warranty of
6754 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6755 GNU General Public License for more details.
6756
6757 You should have received a copy of the GNU General Public License
6758 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.