gnus-sync.el: Simply require json
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca26824c
GM
12012-06-30 Glenn Morris <rgm@gnu.org>
2
2e4c5312
GM
3 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
4
ca26824c
GM
5 * epaths.in (PATH_SITELOADSEARCH): New.
6 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
7 This is rather than relying on --enable-locallisppath elements
8 having "site-lisp" in their names. (Bug#10208#25, 11658)
9
0d23c240
EZ
102012-06-30 Eli Zaretskii <eliz@gnu.org>
11
c9240d7a
EZ
12 * w32proc.c (sys_select): Accept and ignore one more argument.
13
14 * w32.c (emacs_gnutls_pull): Call select with one more argument.
15
0d23c240 16 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 17 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
18
19 * sysdep.c: Don't include dos.h and dosfns.h.
20
21 * process.c (sys_select):
22 * msdos.c (sys_select): Accept one more argument and ignore it.
23
24 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
25 adapt data types and code to that.
26
27 * dosfns.c:
28 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
29 which clashes with the gnulib function of the same name.
30
af5a5a98
AS
312012-06-30 Andreas Schwab <schwab@linux-m68k.org>
32
c5e4379c
AS
33 * font.c (font_style_to_value, font_style_symbolic)
34 (font_prop_validate_style): Add type checks for values in
35 font_style_table.
36
af5a5a98
AS
37 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
38 argument.
39 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
40 uses.
41
8d38f461
EZ
422012-06-29 Eli Zaretskii <eliz@gnu.org>
43
2e5a6631
EZ
44 * xdisp.c (try_window_id): Undo last change.
45
8d38f461
EZ
46 * w32.c (getwd): Adjust commentary about startup_dir.
47 (init_environment): Always call sys_access, even in non-MSVC
48 builds. Don't chdir to the directory of the Emacs executable.
49 This undoes code from 1997 which was justified by the need to
50 "avoid conflicts when removing and renaming directories". But its
51 downside was that every relative file name was being interpreted
52 relative to the directory of the Emacs executable, which can never
53 be TRT. In particular, it broke sys_access when called with
54 relative file names.
55 (sys_access): Map GetLastError to errno.
56
2af3565e
DA
572012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
58
59 * window.h (struct window): Change type of 'fringes_outside_margins'
60 to bitfield. Fix comment. Adjust users accordingly.
61 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
62 Adjust comment.
63 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
64 to ptrdiff_t.
65
c8d3a25c 662012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 67
c8d3a25c
GM
68 * gnutls.c (emacs_gnutls_handshake):
69 Add QUIT to make the loop interruptible.
57570cd3 70
c8d3a25c 712012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 72
c8d3a25c
GM
73 * charset.c (init_charset): Make lack of etc/charsets fatal.
74
3e984ee8
DA
752012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
76
77 * editfns.c (region_limit): Fix type mismatch.
78
ef884f23
DA
792012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
80
81 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
82 undefined. Convert from xassert to eassert.
83 * nsmenu.m: Convert from xassert to eassert.
84 * nsterm.m: Likewise.
85
7d7e0027
SM
862012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 * editfns.c (region_limit): Clip to narrowing (bug#11770).
89
aa754e6a
PE
902012-06-28 Paul Eggert <eggert@cs.ucla.edu>
91
92 Avoid integer overflow on scroll-left and scroll-right.
93 * window.c (HSCROLL_MAX): New macro.
94 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
95 overflow when requested scroll falls outside ptrdiff_t range.
96
80b00b08
DA
972012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
98
99 * window.h (struct window): Change type of 'hscroll',
100 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
101 'last_modified' and 'last_overlay_modified' to EMACS_INT.
102 Adjust users accordingly.
103 * xdisp.c (try_cursor_movement): Replace type check with eassert.
104 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
105 from EMACS_INT to ptrdiff_t.
106 (make_window): Omit redundant initialization.
107
62b2bcf6
JB
1082012-06-28 Juanma Barranquero <lekktu@gmail.com>
109
110 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
111
45942c7d
DA
1122012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
113
114 * window.h (struct window): Change type of 'use_time' and
115 'sequence_number' from Lisp_Object to int.
116 * frame.c (make_frame): Adjust users accordingly.
117 * print.c (print_object): Likewise.
118 * window.c (select_window, Fwindow_use_time, make_parent_window)
119 (make_window): Likewise.
120
e509cfa6
DA
1212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
122
123 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
124 enabled with --enable-checking=[all,glyphs] configure option.
125 Fix GLYPH_DEBUG usage assuming that it may be undefined,
126 adjust comments accordingly.
127 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
128 undefined, adjust comments accordingly.
129 * image.c: Likewise.
130 * scroll.c: Likewise.
131 * w32fns.c: Likewise.
132 * w32term.c: Likewise.
133 * xdisp.c: Likewise.
134 * xfaces.c: Likewise.
135 * xfns.c: Likewise.
136 * xterm.c: Likewise.
137
a54e2c05
DA
1382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
139
140 Generalize run-time debugging checks.
141 * dispextern.h (XASSERTS): Remove.
142 * fontset.c (xassert): Remove.
143 Convert from xassert to eassert.
144 * alloc.c: Convert from xassert to eassert.
145 * bidi.c: Likewise.
146 * dispnew.c: Likewise.
147 * fns.c: Likewise.
148 * fringe.c: Likewise.
149 * ftfont.c: Likewise.
150 * gtkutil.c: Likewise.
151 * image.c: Likewise.
152 * keyboard.c: Likewise.
153 * menu.c: Likewise.
154 * process.c: Likewise.
155 * scroll.c: Likewise.
156 * sound.c: Likewise.
157 * term.c: Likewise.
158 * w32console.c: Likewise.
159 * w32fns.c: Likewise.
160 * w32term.c: Likewise.
161 * window.c: Likewise.
162 * xdisp.c: Likewise.
163 * xfaces.c: Likewise.
164 * xfns.c: Likewise.
165 * xselect.c: Likewise.
166 * xterm.c: Likewise.
167
1ec4b7b2
SM
1682012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
169
170 * fns.c (maybe_resize_hash_table): Output message when growing the
171 purify-hashtable.
172
2014308a
DA
1732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
174
175 * alloc.c (allocate_string_data): Remove dead code.
176 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
177 avoid GCC warning about unused macro.
178
246155eb
DA
1792012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
180
181 * alloc.c (allocate_string): Omit intervals initialization.
182 * alloc.c (make_uninit_multibyte_string): Initialize intervals
183 as in make_pure_string and make_pure_c_string.
184
43184b7b
DA
1852012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
186
187 * alloc.c (allocate_string): Fix last change.
188
3fe6dd74
DA
1892012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
190
191 * alloc.c (allocate_string): Remove two redundant calls
192 to memset, add explicit initialization where appropriate.
193
1ba6038a
GM
1942012-06-27 Glenn Morris <rgm@gnu.org>
195
196 * lisp.mk (lisp): Remove paths.elc.
197
c89926a5
CY
1982012-06-27 Chong Yidong <cyd@gnu.org>
199
200 * doc.c (Fsubstitute_command_keys): Fix punctuation.
201
ed6b3510
JW
2022012-06-26 John Wiegley <johnw@newartisans.com>
203
1ec4b7b2 204 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
205 on Mac OS X Lion: __mod_init_func and __mod_term_func.
206
ed6b3510
JW
207 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
208 when building with Clang.
209
8edd4a2b
SM
2102012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
211
212 * eval.c (Fapply): Allow calling it with a single argument.
213
f6f62d1b
EZ
2142012-06-26 Eli Zaretskii <eliz@gnu.org>
215
216 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
217 _stricmp and _strnicmp.
218 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
219
62efea5e
DA
2202012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
221
222 * alloc.c (allocate_window): Zero out non-Lisp part of newly
223 allocated window.
224 (allocate_process): Likewise for new process.
8edd4a2b 225 (allocate_terminal): Change to use offsetof.
62efea5e
DA
226 (allocate_frame): Likewise.
227 * frame.c (make_frame): Omit redundant initialization.
228 * window.c (make_parent_window): Use memset.
229 (make_window): Omit redundant initialization.
230 * process.c (make_process): Omit redundant initialization.
231 * terminal.c (create_terminal): Likewise.
232
42997f4d
DA
2332012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
234
235 * term.c (delete_tty): Remove redundant call to memset.
236
1130ecfc
DA
2372012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
238
239 * alloc.c: Remove build_string.
240 * lisp.h: Define build_string as static inline. This provides
241 a better opportunity to optimize away calls to strlen when the
242 function is called with compile-time constant argument.
243 * image.c (imagemagick_error): Convert to build_string.
244 * w32proc.c (sys_spawnve): Likewise.
245 * xterm.c (x_term_init): Likewise.
246
cf38a720
PE
2472012-06-26 Paul Eggert <eggert@cs.ucla.edu>
248
99027bdd
PE
249 Use sprintf return value instead of invoking strlen on result.
250 In the old days this wasn't portable, since some sprintf
251 implementations returned char *. But they died out years ago and
252 Emacs already assumes sprintf returns int.
253 Similarly for float_to_string.
254 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
255 * ccl.c (ccl_driver):
256 * character.c (string_escape_byte8):
257 * data.c (Fnumber_to_string):
258 * doprnt.c (doprnt):
259 * print.c (print_object):
260 * xdisp.c (message_dolog):
261 * xfns.c (syms_of_xfns):
262 Use sprintf or float_to_string result to avoid need to call strlen.
263 * data.c (Fnumber_to_string):
264 Use make_unibyte_string, since the string must be ASCII.
265 * lisp.h, print.c (float_to_string): Now returns int length.
266 * term.c (produce_glyphless_glyph):
267 Use sprintf result rather than recomputing it.
268
cf38a720
PE
269 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
270 * Makefile.in (ALL_CFLAGS):
271 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
272 * gmalloc.c, regex.c: Include <config.h> unconditionally.
273
3511c784
DA
2742012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
275
0a08eb21 276 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
277 strcasecmp if available.
278 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
279
fb7da12e
AS
2802012-06-25 Andreas Schwab <schwab@linux-m68k.org>
281
282 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
283 Avoid comma operator.
284 * menu.c (push_submenu_start, push_submenu_end)
285 (push_left_right_boundary, push_menu_pane): Likewise.
286 * msdos.c (dos_rawgetc): Likewise.
287
afa2ffd8
DA
2882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
289
290 * xfns.c (xic_create_fontsetname): Remove redundant calls
291 to memset.
292
b3b4476b
PE
2932012-06-25 Paul Eggert <eggert@cs.ucla.edu>
294
4495ff38
PE
295 * gtkutil.c (get_utf8_string): Remove redundant assignment.
296 sprintf already null-terminates its output.
297
b3b4476b
PE
298 * xfns.c (x_window): Remove redundant cast.
299
b00876c9
DA
3002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
301
302 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
303 `const char *' to `char *' to avoid compiler warning.
304
d188e26b
PE
3052012-06-24 Paul Eggert <eggert@cs.ucla.edu>
306
885d1d74
PE
307 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
308 instead of truncating it to 63 (admittedly a generous limit).
309
d188e26b
PE
310 * process.c: Fix spelling and caps in comments.
311
e2f560b1
DN
3122012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
313
e86db54b 314 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
315 * sysdep.c (setpgrp): Remove definition, not used in this file.
316
7583a3a1
JB
3172012-06-24 Juanma Barranquero <lekktu@gmail.com>
318
319 * makefile.w32-in: Update dependencies.
320
696056c2
EZ
3212012-06-24 Eli Zaretskii <eliz@gnu.org>
322
323 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
324 (SYSTIME_H): Add nt/inc/sys/time.h.
325
326 * systime.h [WINDOWSNT]: Include sys/time.h.
327
328 * s/ms-w32.h (struct timespec): Definition moved from
329 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
330
845ca893
PE
3312012-06-24 Paul Eggert <eggert@cs.ucla.edu>
332
333 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
334 * buffer.h (buffer_slot_type_mismatch):
335 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
336 * eval.c (unwind_to_catch):
337 * image.c (my_png_error, my_error_exit):
338 * keyboard.c (quit_throw_to_read_char, user_error)
339 (Fexit_recursive_edit, Fabort_recursive_edit):
340 * lisp.h (die, args_out_of_range, args_out_of_range_3)
341 (wrong_type_argument, buffer_overflow, __executable_start)
342 (memory_full, buffer_memory_full, string_overflow, Fthrow)
343 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
344 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
345 (fatal):
346 (child_setup) [!DOS_NT]:
347 * lread.c (end_of_file_error, invalid_syntax):
348 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
349 * puresize.h (pure_write_error):
350 * search.c (matcher_overflow):
351 * sound.c (sound_perror, alsa_sound_perror):
352 * sysdep.c, syssignal.h (croak):
353 * term.c (maybe_fatal, vfatal):
354 * textprop.c (text_read_only):
355 * undo.c (user_error):
356 * unexmacosx.c (unexec_error):
357 * xterm.c (x_ins_del_lines, x_delete_glyphs):
358 Use _Noreturn rather than NO_RETURN.
359 No need for separate decl merely because of _Noreturn.
360 * sound.c (sound_warning, parse_sound):
361 Remove unnecessary forward decls.
362
f1dd8073
PE
3632012-06-24 Paul Eggert <eggert@cs.ucla.edu>
364
365 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
366 * lisp.h (WAIT_READING_MAX): New macro.
367 * dispnew.c (Fsleep_for, sit_for):
368 * keyboard.c (kbd_buffer_get_event):
369 * process.c (Faccept_process_output):
370 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
371 This improves on the previous patch, which introduced a bug
372 when time_t is unsigned and as wide as intmax_t.
373 See <http://bugs.gnu.org/9000#51>.
374
b82c1755
EZ
3752012-06-23 Eli Zaretskii <eliz@gnu.org>
376
377 * dispnew.c (sit_for, Fsleep_for):
378 * keyboard.c (kbd_buffer_get_event):
379 * process.c (Faccept_process_output): Avoid compiler warnings when
380 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
381
ca300656
JB
3822012-06-23 Juanma Barranquero <lekktu@gmail.com>
383
049ec95b
JB
384 * makefile.w32-in: Update dependencies.
385
ca300656
JB
386 * w32.c (ltime): Add return type and declare static.
387 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
388
db7b8d06
PE
3892012-06-23 Paul Eggert <eggert@cs.ucla.edu>
390
391 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
392 Privately reported by Herbert J. Skuhra.
393 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
394 All uses changed.
395 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
396 not make_lisp_timeval, when the argument is of type EMACS_TIME.
397
0bd8297f
EZ
3982012-06-23 Eli Zaretskii <eliz@gnu.org>
399
96512555
EZ
400 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
401 last argument of make_unibyte_string.
402
0bd8297f
EZ
403 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
404 language ID in the event parameters.
405
406 * w32term.c (w32_read_socket): Put the new keyboard codepage into
407 event.code, not the obscure "character set ID".
408
63def6b6
CY
4092012-06-23 Chong Yidong <cyd@gnu.org>
410
411 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
412
e8a02204
EZ
4132012-06-23 Eli Zaretskii <eliz@gnu.org>
414
388cdec0
EZ
415 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
416 * w32.c (fdutimens): New function.
417
418 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
419
420 * s/ms-w32.h (pselect): Redirect to sys_select.
421
422 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
423
e8a02204
EZ
424 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
425 in the logic of incrementing and decrementing the value of
426 use_relocatable_buffers.
427
d054f3fb
PE
4282012-06-23 Paul Eggert <eggert@cs.ucla.edu>
429
430 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
431 Privately reported by Herbert J. Skuhra.
432 [__FreeBSD__]: Remove "*/" typo after "#include".
433 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
434 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
435 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
436 Don't assume EMACS_TIME and struct timeval are the same type.
437
d35af63c
PE
4382012-06-22 Paul Eggert <eggert@cs.ucla.edu>
439
440 Support higher-resolution time stamps (Bug#9000).
441 The time stamps are only nanosecond-resolution at the C level,
442 since that's the best that any real-world system supports now.
443 But they are picosecond-resolution at the Lisp level, as that's
444 easy, and leaves room for future OS improvements.
445
446 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
447 (LIBES): Use it.
448
449 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
450 Don't get current time unless it's needed.
451
452 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
453 now provides it if it's absent.
454 (start_atimer): Port to higher-res time stamps.
455 Check for time stamp overflow. Don't get current time more
456 often than is needed.
457
458 * buffer.h (struct buffer): Buffer modtime now has high resolution.
459 Include systime.h, not time.h.
460 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
461
462 * dired.c: Include stat-time.h.
463 (Ffile-attributes): File times now have higher resolution.
464
465 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
466 (struct image): Timestamp now has higher resolution.
467
468 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
469 has at least microseconds now. All uses removed.
470 (update_frame, update_single_window, update_window, update_frame_1)
471 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
472
473 * editfns.c (time_overflow): Now extern.
474 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
475 (float-time, Fformat_time_string, Fcurrent_time_string)
476 (Fcurrent_time_zone): Accept and generate higher-resolution
477 time stamps.
478 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
479 (decode_time_components, lisp_seconds_argument): New functions.
480 (make_time): Now static.
481 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
482 Report an error if the time is invalid, rather than having the caller
483 do that.
484
485 * fileio.c: Include <stat-time.h>
486 (Fcopy_file): Copy higher-resolution time stamps.
487 Prefer to set the time stamp via a file descriptor if that works.
488 (Fset_file_times, Finsert_file_contents, Fwrite_region)
489 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
490 (Fvisited_file_modtime, Fset_visited_file_modtime):
491 Support higher-resolution time stamps.
492
493 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
494
495 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
496
497 * image.c (prepare_image_for_display, clear_image_cache)
498 (lookup_image): Port to higer-resolution time stamps.
499
500 * keyboard.c (start_polling, bind_polling_period):
501 Check for time stamp overflow.
502 (read_char, kbd_buffer_get_event, timer_start_idle)
503 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
504 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
505 Port to higher-resolution time stamps. Do not assume time_t is signed.
506 (decode_timer): New function. Timers are now vectors of length 9,
507 not 8, to accommodate the picosecond component.
508 (timer_check_2): Use it.
509
510 * nsterm.m (select_timeout, timeval_subtract): Remove.
511 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
512 as they're a bit more accurate and handle overflow better.
513 (ns_select): Change prototype to be compatible with pselect.
514 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
515 * nsterm.h (ns_select): Adjust prototype.
516
517 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
518 us-resolution time stamps.
519 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
520
521 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
522
523 * lisp.h (time_overflow): New decl.
524 (wait_reading_process_output): First arg is now intmax_t, not int,
525 to accommodate larger waits.
526
527 * process.h (struct Lisp_Process.read_output_delay):
528 Now counts nanoseconds, not microseconds.
529 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
530 EMACS_HAS_USECS.
531 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
532 (wait_reading_process_output):
533 Port to ns-resolution time stamps.
534 (Faccept_process_output, wait_reading_process_output):
535 Check for time stamp overflow. Do not assume time_t is signed.
536 (select_wrapper): Remove; we now use pselect.
537 (Fprocess_attributes): Now generates ns-resolution time stamps.
538
539 * sysdep.c: Include utimens.h. Don't include utime.h
540 or worry about struct utimbuf; gnulib does that for us now.
541 (gettimeofday): Remove; gnulib provides a substitute.
542 (make_timeval): New function.
543 (set_file_times): Now sets ns-resolution time stamps.
544 New arg FD; all uses changed.
545 (time_from_jiffies, ltime_from_jiffies, get_up_time)
546 (system_process_attributes):
547 Now returns ns-resolution time stamp. All uses changed.
548 Check for time stamp overflow.
549
550 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
551 provides a substitute now.
552
553 * systime.h: Include timespec.h rather than sys/time.h and time.h,
554 since it guarantees struct timespec.
555 (EMACS_TIME): Now struct timespec, so that we can support
556 ns-resolution time stamps.
557 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
558 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
559 (EMACS_USECS): Remove.
560 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
561 so multiply the arg by 1000 before storing it.
562 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
563 New macros.
564 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
565 Port to ns-resolution time stamps.
566 (EMACS_TIME_NEG_P): Remove; replaced by....
567 (EMACS_TIME_SIGN): New macro.
568 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
569 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
570 (set_file_times, make_time, lisp_time_argument): Adjust signature.
571 (make_timeval, make_lisp_time, decode_time_components): New decls.
572 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
573 that it mishandled time_t overflow. You can't compare by subtracting!
574 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
575 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
576
577 * term.c: Include <sys/time.h>.
578 (timeval_to_Time): New function, for proper overflow wraparound.
579 (term_mouse_position, term_mouse_click): Use it.
580
581 * undo.c (record_first_change): Support higher-resolution time stamps
582 in the undo buffer.
583 (Fprimitive_undo): Use them when restoring time stamps.
584
585 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
586 (w32_get_internal_run_time):
587 Port to higher-resolution Emacs time stamps.
588 (ltime): Now accepts single 64-bit integer, as that's more convenient
589 for callers.
590
591 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
592
593 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
594 for compatibility with pselect. Support ns-resolution time stamps.
595
596 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
597
598 * xselect.c (wait_for_property_change, x_get_foreign_selection):
599 Check for time stamp overflow, and support ns-resolution time stamps.
600
601 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
602 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
603 (timeval_subtract): Remove; no longer needed.
604 (XTflash, XTring_bell, x_wait_for_event):
605 Port to ns-resolution time stamps. Don't assume time_t is signed.
606
b6a92dfe
CY
6072012-06-22 Chong Yidong <cyd@gnu.org>
608
609 * xdisp.c (x_consider_frame_title): Revert last change.
610
d251c37c
EZ
6112012-06-22 Eli Zaretskii <eliz@gnu.org>
612
613 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
614 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
615 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
616 staticidx goes up to 1597 out of 1600 = 0x640.)
617
f10deafb
PE
6182012-06-20 Paul Eggert <eggert@cs.ucla.edu>
619
620 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
621 Otherwise, the umask might be mistakenly 0 while handling input signals.
622
ec6de1e2
SM
6232012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
626
28be1ada
DA
6272012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
628
629 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
630 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
631 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
632 access to `contents' member of Lisp_Vector objects with AREF and ASET
633 where appropriate.
634
c6bf3022
CY
6352012-06-19 Chong Yidong <cyd@gnu.org>
636
637 * frame.c (delete_frame): When selecting a frame on a different
638 text terminal, do not alter the terminal's top-frame.
639
640 * xdisp.c (format_mode_line_unwind_data): Record the target
641 frame's selected window and its terminal's top-frame.
642 (unwind_format_mode_line): Restore them.
643 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
644 Callers changed.
645 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
646 since tty frames can be explicitly named.
647 (prepare_menu_bars): Likewise.
648
649 * term.c (Ftty_top_frame): New function.
650
defd4196
PE
6512012-06-18 Paul Eggert <eggert@cs.ucla.edu>
652
653 Port byte-code-meter to modern targets.
654 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
655 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 656 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
657 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
658 (METER_1, METER_2): Simplify.
659
1053a871
SM
6602012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
661
662 * data.c (Fdefalias): Return `symbol' (bug#11686).
663
b7e8d081
MR
6642012-06-18 Martin Rudalics <rudalics@gmx.at>
665
666 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
667 gets killed during executing of this function (Bug#11665).
668 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
669 (Vkill_buffer_query_functions): In doc-string say that functions
670 run by this hook should not change the current buffer.
671
7ea2b339
PE
6722012-06-18 Paul Eggert <eggert@cs.ucla.edu>
673
674 Fix recently-introduced process.c problems found by static checking.
675 * process.c (write_queue_push, write_queue_pop, send_process):
676 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
677 (write_queue_pop): Fix pointer signedness problem.
678 (send_process): Remove unused local.
679
96a313a1
CY
6802012-06-17 Chong Yidong <cyd@gnu.org>
681
682 * xdisp.c (redisplay_internal): No need to redisplay terminal
683 frames that are not on top.
684
20ca2e94
TN
6852012-06-17 Troels Nielsen <bn.troels@gmail.com>
686
687 * process.c (make_process): Initialize write_queue.
688 (write_queue_push, write_queue_pop): New functions.
689 (send_process): Use them to maintain correct ordering of process
690 writes (Bug#10815).
691
9a900ca9
PE
6922012-06-17 Paul Eggert <eggert@cs.ucla.edu>
693
310fbfa8
PE
694 * lisp.h (eassert): Assume C89 or later.
695 This removes the need for CHECK.
696 (CHECK): Remove. Its comments about always evaluating its
697 argument were confusing, as 'eassert' typically does not evaluate
698 its argument.
699
27bb1ca4
PE
700 * coding.c (produce_chars): Use ptrdiff_t, not int.
701
9a900ca9
PE
702 * xterm.c (x_draw_underwave): Check for integer overflow.
703 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
704
41b7f8bc 7052012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
706
707 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
708 referenced (Bug#11583).
709
9b0e3eba
AA
7102012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
711
712 Implement wave-style variant of underlining.
713 * dispextern.h (face_underline_type): New enum.
714 (face): Add field for underline type.
715 * nsterm.m (ns_draw_underwave): New function.
716 (ns_draw_text_decoration): Use it.
717 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
718 New functions.
719 (x_draw_glyph_string): Use them.
720 * xfaces.c (Qline, Qwave): New Lisp objects.
721 (check_lface_attrs, merge_face_ref)
1053a871
SM
722 (Finternal_set_lisp_face_attribute, realize_x_face):
723 Handle wave-style underline face attributes.
9b0e3eba
AA
724 * xterm.c (x_draw_underwave): New function.
725 (x_draw_glyph_string): Use it.
726
0fb52f11
JB
7272012-06-16 Juanma Barranquero <lekktu@gmail.com>
728
729 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
730 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
731 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
732 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
733 ($(BLD)/w32select.$(O)): Update dependencies.
734
e5560ff7
AS
7352012-06-16 Andreas Schwab <schwab@linux-m68k.org>
736
737 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
738 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
739 * character.c (_fetch_multibyte_char_p): Remove.
740 * alloc.c: Include "character.h" before "buffer.h".
741 * bidi.c: Likewise.
742 * buffer.c: Likewise.
743 * bytecode.c: Likewise.
744 * callint.c: Likewise.
745 * callproc.c: Likewise.
746 * casefiddle.c: Likewise.
747 * casetab.c: Likewise.
748 * category.c: Likewise.
749 * cmds.c: Likewise.
750 * coding.c: Likewise.
751 * composite.c: Likewise.
752 * dired.c: Likewise.
753 * dispnew.c: Likewise.
754 * doc.c: Likewise.
755 * dosfns.c: Likewise.
756 * editfns.c: Likewise.
757 * emacs.c: Likewise.
758 * fileio.c: Likewise.
759 * filelock.c: Likewise.
760 * font.c: Likewise.
761 * fontset.c: Likewise.
762 * fringe.c: Likewise.
763 * indent.c: Likewise.
764 * insdel.c: Likewise.
765 * intervals.c: Likewise.
766 * keyboard.c: Likewise.
767 * keymap.c: Likewise.
768 * lread.c: Likewise.
769 * macros.c: Likewise.
770 * marker.c: Likewise.
771 * minibuf.c: Likewise.
772 * nsfns.m: Likewise.
773 * nsmenu.m: Likewise.
774 * print.c: Likewise.
775 * process.c: Likewise.
776 * regex.c: Likewise.
777 * region-cache.c: Likewise.
778 * search.c: Likewise.
779 * syntax.c: Likewise.
780 * term.c: Likewise.
781 * textprop.c: Likewise.
782 * undo.c: Likewise.
783 * unexsol.c: Likewise.
784 * w16select.c: Likewise.
785 * w32fns.c: Likewise.
786 * w32menu.c: Likewise.
787 * window.c: Likewise.
788 * xdisp.c: Likewise.
789 * xfns.c: Likewise.
790 * xmenu.c: Likewise.
791 * xml.c: Likewise.
792 * xselect.c: Likewise.
793
2f07e6af
EZ
7942012-06-16 Eli Zaretskii <eliz@gnu.org>
795
1053a871
SM
796 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
797 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 798 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
799 row.
800 (handle_face_prop): Use chunk-relative overlay string index when
801 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
802 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
803 the rightmost. (Bug#11720)
2f07e6af 804
29b83cec
AS
8052012-06-16 Andreas Schwab <schwab@linux-m68k.org>
806
807 * category.h (CHAR_HAS_CATEGORY): Define as inline.
808 (CATEGORY_MEMBER): Enforce 1/0 value.
809 * category.c (_temp_category_set): Remove.
810
4c5501e9
EZ
8112012-06-16 Eli Zaretskii <eliz@gnu.org>
812
813 * window.c (Fdelete_other_windows_internal)
814 (Fdelete_window_internal): Don't access frame's mouse highlight
815 info of the initial frame. (Bug#11677)
816
2b570124
PE
8172012-06-14 Paul Eggert <eggert@cs.ucla.edu>
818
e93864f9
PE
819 * .gdbinit (xgetint): Fix recently-introduced paren typo.
820 Assume USE_2_TAGS_FOR_INTS.
821 (xreload): Adjust $tagmask width to match recent lisp.h change.
822
2b570124
PE
823 Simplify lisp.h in minor ways that should not affect code.
824 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
825 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
826 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
827 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
828 (INTTYPEBITS): New macro, for clarity.
829 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
830 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
831 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
832 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
833 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
834
81755f69
JB
8352012-06-13 Juanma Barranquero <lekktu@gmail.com>
836
837 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
838
16192a57
GM
8392012-06-13 Glenn Morris <rgm@gnu.org>
840
841 * s/bsd-common.h (BSD4_3):
842 * s/usg5-4-common.h (USG5_4): No longer define; unused.
843
646b5f55
AS
8442012-06-13 Andreas Schwab <schwab@linux-m68k.org>
845
846 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
847 instead of union.
848 (XLI, XIL): Define.
1053a871
SM
849 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
850 Use them.
851 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 852 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 853 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
854 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
855 * frame.c (delete_frame): Remove outdated comment.
856 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
857 USE_LISP_UNION_TYPE.
858 (Fw32_unregister_hot_key): Likewise.
859 (Fw32_toggle_lock_key): Likewise.
860 * w32menu.c (add_menu_item): Likewise.
861 (w32_menu_display_help): Use XIL instead of checking
862 USE_LISP_UNION_TYPE.
863 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
864 (init_heap): Likewise.
865 * w32term.c (w32_read_socket): Update comment.
866
1d3823c9
GM
8672012-06-13 Glenn Morris <rgm@gnu.org>
868
c62ff706
GM
869 * s/usg5-4-common.h, src/s/unixware.h:
870 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
871
1d3823c9
GM
872 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
873
bfe3e0a2
PE
8742012-06-13 Paul Eggert <eggert@cs.ucla.edu>
875
876 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
877 * alloc.c (make_number) [!defined make_number]:
878 Remove, as lisp.h always defines this now.
879 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
880 (roundup_size): Verify that it is a power of 2.
881 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
882 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
883 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
884 -DUSE_LSB_TAG=0, to override the automatically-selected default.
885 USE_LSB_TAG now is always defined to be either 0 or 1.
886 All uses changed.
887 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
888 code works fine either way, and efficiency is not a concern here,
889 as the union type is for debugging, not for production.
890 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
891 Use an inline function on all platforms when using the union type,
892 since this is simpler and 'static inline' can be used portably
893 within Emacs now.
894 (LISP_INITIALLY_ZERO): New macro.
895 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
896 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
897
45fa9c0f
GM
8982012-06-12 Glenn Morris <rgm@gnu.org>
899
b4492cba
GM
900 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
901
902 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 903
45fa9c0f
GM
904 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
905 Move BROKEN_SIGIO to configure.
906
907 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
908 Move NO_TERMIO to configure.
909
0e25d334
CY
9102012-06-12 Chong Yidong <cyd@gnu.org>
911
912 * image.c (imagemagick_load_image): Use MagickFlattenImage if
913 MagickMergeImageLayers is undefined. Use pixel pusher loop if
914 MagickExportImagePixels is undefined.
915
43682bb6
PE
9162012-06-12 Paul Eggert <eggert@cs.ucla.edu>
917
918 * image.c (imagemagick_load_image): Remove unused label.
919
a9be7d2b
GM
9202012-06-11 Glenn Morris <rgm@gnu.org>
921
922 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
923 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
924 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
925 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
926
3017f87f
SM
9272012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
928
929 * alloc.c (make_byte_code): New function.
930 (Fmake_byte_code): Use it. Don't purify here.
931 * lread.c (read1): Use it as well to avoid extra allocation.
932
1b9b4cf4
CY
9332012-06-11 Chong Yidong <cyd@gnu.org>
934
935 * image.c (imagemagick_load_image): Implement transparency.
936
95988fcf
AS
9372012-06-10 Andreas Schwab <schwab@linux-m68k.org>
938
939 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
940 account for preceding backslashes. (Bug#11663)
941
cd4eb164
CY
9422012-06-09 Chong Yidong <cyd@gnu.org>
943
944 * term.c: Support italics in capable terminals (Bug#9652).
945 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
946 (turn_on_face): Output using TS_enter_italic_mode if available.
947 Don't handle unused blinking and alt-charset cases.
948 (turn_off_face): Handle italic case; discard unused tty_blinking_p
949 and tty_alt_charset_p cases.
950 (tty_capable_p, init_tty): Support italics.
951
952 * termchar.h (struct tty_display_info): Add field for italics.
953 Remove unused blink field.
954
955 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
956 Handle slant.
957
958 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
959 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
960 tty_alt_charset_p. Add tty_italic_p.
961
ff88beb8
MA
9622012-06-09 Michael Albinus <michael.albinus@gmx.de>
963
964 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
965 dbus_type_is_basic if available.
966 (xd_extract_signed, xd_extract_unsigned): Rename from
967 extract_signed and extract_unsigned, respectively. Adapt callers.
968
44286096
CY
9692012-06-09 Chong Yidong <cyd@gnu.org>
970
1682701f
CY
971 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
972
44286096
CY
973 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
974 case (Bug#9752).
975
d86feb17
PE
9762012-06-08 Paul Eggert <eggert@cs.ucla.edu>
977
978 * xdisp.c (vmessage): Treat frame message as multibyte.
979 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
980 would generate the diagnostic "Making \302\247 buffer-local while
981 let-bound!".
982
d5c20fe8
EZ
9832012-06-08 Eli Zaretskii <eliz@gnu.org>
984
985 * dispnew.c (showing_window_margins_p): Undo last change, which
986 was done due to an inadvertent commit.
987 (adjust_frame_glyphs_for_frame_redisplay): Do call
988 showing_window_margins_p.
989
513749ee
SM
9902012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
991
992 * eval.c (Fmake_var_non_special): New primitive.
993 (syms_of_eval): Defsubr it.
994 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
995
d4a8f5c1
JB
9962012-06-08 Juanma Barranquero <lekktu@gmail.com>
997
998 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
999 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1000
8bbbc977
EZ
10012012-06-08 Eli Zaretskii <eliz@gnu.org>
1002
1003 * alloc.c (allocate_vectorlike): Fix last change.
1004
f3372c87
DA
10052012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1006
1007 Block-based vector allocation of small vectors.
1008 * lisp.h (struct vectorlike_header): New field `nbytes',
1009 adjust comment accordingly.
1010 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1011 to denote vector blocks. Adjust users (live_vector_p,
1012 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1013 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1014 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1015 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1016 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1017 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1018 (roundup_size): New constant.
1019 (struct vector_block): New data type.
1020 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1021 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1022 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1023 (sweep_vectors): New functions.
1024 (allocate_vectorlike): Return `zero_vector' as the only vector of
1025 0 items. Allocate new vector from block if vector size is less than
1026 or equal to VBLOCK_BYTES_MAX.
1027 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1028 (init_alloc_once): Add call to init_vectors.
1029
4f18a4ed
SM
10302012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1031
1032 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1033
86f158bc
PE
10342012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1035
1036 * doprnt.c (doprnt): Truncate multibyte char correctly.
1037 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1038 would mishandle a string argument "Xc" if X was a multibyte
1039 character of length 2: it would truncate after X's first byte
1040 rather than including all of X.
1041
c5cfcbe0
CY
10422012-06-06 Chong Yidong <cyd@gnu.org>
1043
1044 * buffer.c (word_wrap): Doc fix.
1045
c05cf390
PE
10462012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1049
0c3461de
GM
10502012-06-03 Glenn Morris <rgm@gnu.org>
1051
1052 * xdisp.c (tool-bar-style): Doc fix.
1053
c71232db
UM
10542012-06-03 Ulrich Müller <ulm@gentoo.org>
1055
1056 * Makefile.in (PAXCTL): Define.
1057 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1058 binary via PaX flags if the paxctl utility is available.
1059 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1060 Restore PaX flags to their default. (Bug#11398)
1061
383f7350
CY
10622012-06-03 Chong Yidong <cyd@gnu.org>
1063
1064 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1065 buffer (Bug#11226).
1066
5f2c76c6
CY
10672012-06-03 Chong Yidong <cyd@gnu.org>
1068
1069 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1070 (note_mode_line_or_margin_highlight): If there is no help echo,
1071 use mode-line-default-help-echo. Handle the case where the mouse
1072 position is past the end of the mode line string.
1073
1074 * buffer.c (buffer_local_value_1): New function, split from
1075 Fbuffer_local_value; can return Qunbound.
1076 (Fbuffer_local_value): Use it.
1077 (Vmode_line_format): Docstring tweaks.
1078
773d47f6
PE
10792012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1080
1081 * sysdep.c (system_process_attributes): Improve comment.
1082
f2d6a3df
SM
10832012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1084
1085 * keyboard.c: Export real-this-command to Elisp.
1086 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1087 and DEFVAR it. Update all users.
1088
63810350
PE
10892012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1090
7bd5c1f4
PE
1091 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1092
63810350
PE
1093 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1094 Convert pctcpu and pctmem to Lisp float properly.
1095 Let the compiler fold better, as 100.0/0x8000 is exact.
1096
a2821611
AS
10972012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1098
1099 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1100 cons_block.
1101
5fceba1d
PE
11022012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1105
c98ff5dd
DA
11062012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 For a 'struct window', replace some Lisp_Object fields to
1109 bitfields where appropriate, remove unused fields.
1110 * window.h (struct window): Remove unused 'last_mark_x' and
1111 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1112 change it's type from Lisp_Object to bitfield.
1113 Change type of 'force_start', 'optional_new_start',
1114 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1115 fields from Lisp_Object to bitfield. Adjust users accordingly.
1116
ca34e0be
PE
11172012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 Pacify gcc -Wdouble-precision when using Xaw.
1120 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1121 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1122 Use 'float' consistently, rather than 'float' in most places
1123 and 'double' in a couple of places.
1124
efc00ab1 11252012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1126
1127 * xdisp.c (handle_stop): Detect whether we have overlay strings
1128 loaded by testing it->current.overlay_string_index to be
1129 non-negative, instead of checking whether n_overlay_strings is
1130 positive. (Bug#11587)
1131
efc00ab1 11322012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1133
1134 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1135
1136 * doc.c (Fsubstitute_command_keys): Doc fix.
1137
efc00ab1 11382012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1139
1140 * search.c (search_buffer): Remove calls to
1141 r_alloc_inhibit_buffer_relocation, as it is now called by
1142 maybe_unify_char, which was the cause of relocation of buffer text
1143 in bug#11519.
1144
efc00ab1 11452012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1146
1147 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1148 for the duration of call to load_charset, to avoid problems with
1149 callers of maybe_unify_char that access buffer text through C
1150 pointers.
1151
1152 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1153 decrement the inhibition flag, instead of just setting or
1154 resetting it.
1155
ba93a187
PE
11562012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 Remove obsolete '#define static' cruft.
1159 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1160 This #undef was "temporary" in 2000; it is no longer needed
1161 now that '#define static' has gone away.
1162 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1163 (gray_bitmap_bits): Remove; no longer needed.
1164 All uses replaced with definiens.
1165 * xterm.c: Include "bitmaps/gray.xbm".
1166
9e4bf381
PE
11672012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1168
1169 Clean up __executable_start, monstartup when --enable-profiling.
1170 The following changes affect the code only when profiling.
1171 * dispnew.c (__executable_start): Rename from safe_bcopy.
1172 Define only on platforms that need it.
1173 * emacs.c: Include <sys/gmon.h> when profiling.
1174 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1175 (__executable_start): Remove decl, since lisp.h does it now.
1176 (safe_bcopy): Remove decl; no longer has that name.
1177 (main): Coalesce #if into single bit of code, for simplicity.
1178 Cast pointers to uintptr_t, since standard libraries want integers
1179 and not pointers.
1180 * lisp.h (__executable_start): New decl.
1181
32d72c2f
GM
11822012-05-31 Glenn Morris <rgm@gnu.org>
1183
1184 * image.c (Fimagemagick_types): Doc fix.
1185
baac5bc7
JM
11862012-05-30 Jim Meyering <meyering@redhat.com>
1187
1188 * callproc.c (Fcall_process_region): Include directory component
1189 in mkstemp error message (Bug#11586).
1190
72cb32cf
PE
11912012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1192
1193 * alloc.c, lisp.h (make_pure_vector): Now static.
1194
61b108cc
SM
11952012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1196
1197 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1198 Move to byte-run.el.
1199 (Fautoload): Do the hash-doc more carefully.
1200 * data.c (Fdefalias): Purify definition, except for keymaps.
1201 (Qdefun): Move from eval.c.
1202 * lisp.h (Qdefun): Remove.
1203 * lread.c (read1): Tiny simplification.
1204
471fe23d
TN
12052012-05-29 Troels Nielsen <bn.troels@gmail.com>
1206
934f3f58 1207 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1208 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1209 Bug#9642, but explicitly check that the buffer the overlay would
1210 be moved to is live and rearrange lines to make sure that errors
1211 will not put the overlay in an inconsistent state.
1212 (Fdelete_overlay): Cosmetics.
1213
85d0efd1
EZ
12142012-05-28 Eli Zaretskii <eliz@gnu.org>
1215
1216 * w32term.c (my_bring_window_to_top): New function.
1217 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1218 could be different from the original one.
1219 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1220 (Bug#11513)
1221
1222 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1223 by calling BringWindowToTop.
1224
1225 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1226 (WM_EMACS_END): Increase by one.
1227
da92a98c
PE
12282012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1229
1230 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1231 This avoids undefined behavior that might cause the eassert
1232 to not catch an out-of-range value.
1233
74d1f848
JB
12342012-05-28 Juanma Barranquero <lekktu@gmail.com>
1235
1236 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1237 Update dependencies.
1238
9e1a06fc
EZ
12392012-05-27 Eli Zaretskii <eliz@gnu.org>
1240
1241 * bidi.c (bidi_mirror_char): Fix last change.
1242
f3dd7312
AS
12432012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1244
1245 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1246 when referring to sectname field in printf format.
1247
81899c91
PE
12482012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1249
57b81a9f
PE
1250 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1251 Only r_alloc_inhibit_buffer_relocation needed to be added;
1252 the others were already declared.
1253
81899c91
PE
1254 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1255 before checking whether it's out of range. Put the check inside
1256 eassert. See
1257 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1258
33017faf 12592012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1260
1261 * callproc.c (Fcall_process): Restore a line that was accidentally
1262 commented out in the 2011-02-13 change (bug#11547).
1263
33017faf 12642012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1265
1266 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1267 defined on ralloc.c.
1268
1269 * buffer.c [REL_ALLOC]: Remove prototypes of
1270 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1271 they are now on lisp.h.
1272
1273 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1274
1275 * search.c (search_buffer): Use it to inhibit relocation of buffer
1276 text while re_search_2 is doing its job, because re_search_2 is
1277 passed C pointers to buffer text. (Bug#11519)
1278
23415acf
EZ
1279 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1280 Update value to 24.
1281
44e27368
EZ
1282 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1283 state after an additional call to move_it_in_display_line_to, keep
1284 the values of it->max_ascent and it->max_descent found for the
1285 entire line.
1286 (pos_visible_p): Revert the comparison against bottom_y to what it
1287 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1288 (Bug#11464)
1289
c1892f11
PE
12902012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Fix coding-related core dumps with gcc -ftrapv.
1293 The code was computing A - B, where A and B are pointers, and B is
1294 random garbage. This can lead to core dumps on platforms that
1295 have special pointer registers, and it also leads to core dumps on
1296 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1297 A - B only when B is initialized properly.
1298 * coding.c (coding_set_source, coding_set_destination): Return void.
1299 (coding_change_source, coding_change_destinations): New functions,
1300 with the old behaviors of coding_set_source and coding_set_destination.
1301 All callers that need an offset changed to use these new functions.
1302
eb7afdad
GM
13032012-05-26 Glenn Morris <rgm@gnu.org>
1304
1305 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1306
f12fdf02
EZ
13072012-05-26 Eli Zaretskii <eliz@gnu.org>
1308
53a63be6 1309 Extend mouse support on W32 text-mode console.
61b108cc
SM
1310 * xdisp.c (draw_row_with_mouse_face):
1311 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1312
eb3f6f01 1313 * w32console.c: Include window.h.
61b108cc
SM
1314 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1315 New functions.
eb3f6f01
EZ
1316 (initialize_w32_display): Initialize mouse-highlight data.
1317
53a63be6
EZ
1318 * w32inevt.c: Include termchar.h and window.h.
1319 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1320 moves, call note_mouse_highlight. If help_echo changed, call
1321 gen_help_event to produce help-echo message in the echo area.
1322 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1323 highlight info.
1324
4cfd81f6
PE
13252012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1326
1327 * lread.c (read1): Simplify slightly to avoid an overflow warning
1328 with GCC 4.7.0 on x86-64.
1329
4446092a
EZ
13302012-05-26 Eli Zaretskii <eliz@gnu.org>
1331
1332 * bidi.c (bidi_mirror_char): Revert last change: an int is
1333 definitely wide enough here.
1334
42b2a986 13352012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1336
42b2a986 1337 Fix integer width and related bugs (Bug#9874).
eb106a49 1338 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1339 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1340 (string_bytes, check_sblock, allocate_string_data):
1341 (compact_small_strings, Fmake_bool_vector, make_string)
1342 (make_unibyte_string, make_multibyte_string)
1343 (make_string_from_bytes, make_specified_string)
1344 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1345 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1346 (mark_vectorlike):
1347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1348 (allocate_pseudovector):
1349 Use int, not EMACS_INT, where int is wide enough.
1350 (inhibit_garbage_collection, Fgarbage_collect):
1351 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1352 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1353 int might not be wide enough.
1354 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1355 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1356 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1357 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1358 (bidi_level_of_next_char, bidi_move_to_visually_next):
1359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1360 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1361 (Fkill_buffer, Fset_buffer_major_mode)
1362 (advance_to_char_boundary, Fbuffer_swap_text)
1363 (Fset_buffer_multibyte, overlays_at, overlays_in)
1364 (overlay_touches_p, struct sortvec, record_overlay_string)
1365 (overlay_strings, recenter_overlay_lists)
1366 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1367 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1368 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1369 (Foverlay_recenter, last_overlay_modification_hooks_used)
1370 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1372 (validate_region): Omit unnecessary test for b <= e,
1373 since that's guaranteed by the previous test.
d311d28c
PE
1374 (adjust_overlays_for_delete): Avoid pos + length overflow.
1375 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1376 (report_overlay_modification):
1377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1378 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1379 Omit pointer cast, which isn't needed anyway, and doesn't work
1380 after the EMACS_INT -> ptrdiff_t change.
02481186 1381 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1382 * buffer.h: Adjust decls to match defn changes elsewhere.
1383 (struct buffer_text, struct buffer):
1384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1385 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1386 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1387 not int, to avoid needless 32-bit limit on 64-bit hosts.
1388 (exec_byte_code): Use tighter memory-full test, one that checks
1389 for alloca overflow. Don't compute the address of the object just
1390 before an array, as that's not portable. Use EMACS_INT, not
1391 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1392 * callint.c (Fcall_interactively):
1393 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1394 * callproc.c (call_process_kill, Fcall_process):
1395 Don't assume pid_t fits into an Emacs fixnum.
1396 (call_process_cleanup, Fcall_process, child_setup):
1397 Don't assume pid_t fits into int.
1398 (call_process_cleanup, Fcall_process, delete_temp_file)
1399 (Fcall_process_region):
1400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1401 (Fcall_process): Simplify handling of volatile integers.
1402 Use int, not EMACS_INT, where int will do.
1403 * casefiddle.c (casify_object, casify_region, operate_on_word)
1404 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1405 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1406 (casify_object): Avoid integer overflow when overallocating buffer.
1407 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1408 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1409 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1410 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1411 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1412 integers are now checked earlier. All uses replaced with XINT.
1413 (ccl_driver):
1414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1415 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1416 (ccl_driver, Fregister_code_conversion_map):
1417 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1418 (resolve_symbol_ccl_program): Check that vector header is in range.
1419 Always copy the vector, so that we can check its contents reliably
1420 now rather than having to recheck each instruction as it's being
1421 executed. Check that vector words fit in 'int'.
1422 (ccl_get_compiled_code, Fregister_ccl_program)
1423 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1424 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1425 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1426 contents are in range.
1427 (Fccl_execute_on_string): Check that status is in range.
1428 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1429 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1430 Accept and return EMACS_INT, not int, because callers can pass values
1431 out of 'int' range.
1432 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1433 (multibyte_chars_in_text, parse_str_as_multibyte)
1434 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1435 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1436 (string_escape_byte8, Fget_byte):
1437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1438 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1439 avoid mishandling large integers.
1440 * character.h: Adjust decls to match defn changes elsewhere.
1441 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1442 (Ffind_charset_region):
1443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1444 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1445 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1446 Don't assume fixnum fits in int.
d311d28c
PE
1447 (load_charset_map_from_vector, Fmap_charset_chars):
1448 Remove now-unnecessary CHECK_NATNUMs.
1449 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1450 Don't rely on undefined behavior with signed left shift overflow.
1451 Don't assume unsigned int fits into fixnum, or that fixnum fits
1452 into unsigned int. Don't require max_code to be a valid fixnum;
1453 that's not true for gb10830 4-byte on a 32-bit host. Allow
1454 invalid_code to be a cons, for the same reason. Require code_offset
1455 to be a character. Avoid int overflow if max_char is close
1456 to INT_MAX.
1457 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1458 this is intended anyway and avoids some undefined behavior.
1459 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1460 INDEX_TO_CODE_POINT, as that's what it expects.
1461 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1462 * charset.h (DECODE_CHAR): Return int, not unsigned;
1463 this is what was intended anyway, and it avoids undefined behavior.
1464 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1465 integer-overflow issues.
1466 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1467 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1468 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1469 * chartab.c (Fmake_char_table, Fset_char_table_range)
1470 (uniprop_get_decoder, uniprop_get_encoder):
1471 Don't assume fixnum fits in int.
1472 * cmds.c (move_point): New function, that does the gist of
1473 Fforward_char and Fbackward_char, but does so while checking
1474 for integer overflow more accurately.
c96e5d6a 1475 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1476 (Fforward_line, Fend_of_line, internal_self_insert)
1477 (internal_self_insert):
1478 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1479 Fix a FIXME, by checking for integer overflow when calculating
1480 target_clm and actual_clm.
1481 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1482 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1483 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1484 (coding_alloc_by_making_gap, alloc_destination)
1485 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1486 (encode_coding_utf_16, detect_coding_emacs_mule)
1487 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1488 (detect_coding_iso_2022, decode_coding_iso_2022)
1489 (encode_invocation_designation, encode_designation_at_bol)
1490 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1491 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1492 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1493 (encode_coding_ccl, encode_coding_raw_text)
1494 (detect_coding_charset, decode_coding_charset)
1495 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1496 (produce_composition, produce_charset, produce_annotation)
1497 (decode_coding, handle_composition_annotation)
1498 (handle_charset_annotation, consume_chars, decode_coding_gap)
1499 (decode_coding_object, encode_coding_object, detect_coding_system)
1500 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1501 (code_convert_region, code_convert_string)
8f50130c
PE
1502 (Fdefine_coding_system_internal)
1503 (coding_set_source, coding_set_destination):
d311d28c
PE
1504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1505 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1506 (Fdefine_coding_system_internal):
1507 Don't assume fixnums fit in int.
1508 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1509 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1510 (Funencodable_char_position, Fcheck_coding_systems_region)
1511 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1513 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1514 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1515 Don't access memory outside of the args array.
d311d28c 1516 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1517 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1518 result of ENCODE_CHAR.
d311d28c
PE
1519 * coding.h: Adjust decls to match defn changes elsewhere.
1520 (struct coding_system):
1521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1522 * composite.c (get_composition_id, find_composition)
1523 (run_composition_function, update_compositions)
1524 (compose_text, composition_gstring_put_cache)
1525 (composition_gstring_p, composition_gstring_width)
1526 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1527 (composition_compute_stop_pos, composition_reseat_it)
1528 (composition_update_it, struct position_record)
1529 (find_automatic_composition, composition_adjust_point)
1530 (Fcomposition_get_gstring, Ffind_composition_internal):
1531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1532 (update_compositions):
1533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1534 * composite.h: Adjust decls to match defn changes elsewhere.
1535 (struct composition):
1536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1537 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1538 Do not attempt to compute the address of the object just before a
1539 buffer; this is not portable.
1540 (Faref, Faset):
1541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1542 (Faset): Use int, not EMACS_INT, where int is wide enough.
1543 (Fstring_to_number): Don't assume fixnums fit in int.
1544 (Frem): Don't assume arg is nonnegative.
1545 * dbusbind.c (xd_append_arg): Check for integers out of range.
1546 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1547 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1548 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1549 (xd_get_connection_references): Return ptrdiff_t, not int.
1550 All uses changed.
1551 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1552 (xd_read_message_1):
1553 Use int, not unsigned, where the dbus API uses int.
1554 (Fdbus_message_internal): Don't overflow mtype.
1555 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1556 * dired.c (directory_files_internal, file_name_completion, scmp)
1557 (file_name_completion_stat):
1558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1559 (file_name_completion): Don't overflow matchcount.
1560 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1561 * dispextern.h: Adjust decls to match defn changes elsewhere.
1562 (struct text_pos, struct glyph, struct bidi_saved_info)
1563 (struct bidi_string_data, struct bidi_it, struct composition_it)
1564 (struct it):
1565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1566 (struct display_pos, struct composition_it, struct it):
1567 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1568 * dispnew.c (increment_matrix_positions)
1569 (increment_row_positions, mode_line_string)
1570 (marginal_area_string):
1571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1572 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1574 (duration_to_sec_usec): New function, to check for overflow better.
1575 (Fsleep_for, sit_for): Use it.
1576 * doc.c (get_doc_string, store_function_docstring):
1577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1578 (get_doc_string, Fsnarf_documentation):
1579 Use int, not EMACS_INT, where int is wide enough.
1580 (get_doc_string):
1581 Use SAFE_ALLOCA, not alloca.
1582 Check for overflow when converting EMACS_INT to off_t.
1583 * doprnt.c (doprnt):
1584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1585 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1586 Don't assume uid_t fits into fixnum.
1587 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1588 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1589 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1590 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1591 (general_insert_function)
1592 (Finsert_char, make_buffer_string, make_buffer_string_both)
1593 (update_buffer_properties, Fbuffer_substring)
1594 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1595 (Fsubst_char_in_region, check_translation)
1596 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1597 (transpose_markers, Ftranspose_regions):
1598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1599 (clip_to_bounds): Move to lisp.h as an inline function).
1600 (Fconstrain_to_field): Don't assume integers are nonnegative.
1601 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1602 (Fsubst_char_in_region, Fsave_restriction):
1603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1604 (Femacs_pid): Don't assume pid_t fits into fixnum.
1605 (lo_time): Use int, not EMACS_INT, when int suffices.
1606 (lisp_time_argument): Check for usec out of range.
1607 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1608 (Fuser_login_name, Fuser_full_name): Signal an error
1609 if a uid argument is out of range, rather than relying on
1610 undefined behavior.
c8d5c857
PE
1611 (Fformat_time_string): Remove now-unnecessary check.
1612 lisp_time_argument checks for out-of-range usec now.
243e0530 1613 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1614 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1615 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1616 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1617 (init_cmdargs, Fdump_emacs):
1618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1619 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1620 the bottom (typically) 32 bits of the fixnum.
1621 * eval.c (specpdl_size, call_debugger):
1622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1623 (when_entered_debugger, Fbacktrace_debug):
1624 Don't assume fixnum can fit in int.
1625 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1626 the object just before a buffer; this is not portable.
1627 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1628 (grow_specpdl, unbind_to):
1629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1630 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1631 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1632 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1633 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1634 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1636 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1637 (a_write, e_write):
1638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1639 (Fcopy_file, non_regular_nbytes, read_non_regular)
1640 (Finsert_file_contents):
1641 Use int, not EMACS_INT, where int is wide enough.
1642 (READ_BUF_SIZE): Verify that it fits in int.
1643 (Finsert_file_contents): Check that counts are in proper range,
1644 rather than assuming fixnums fit into ptrdiff_t etc.
1645 Don't assume fixnums fit into int.
125b3835 1646 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1647 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1648 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1649 (string_char_to_byte, string_byte_to_char)
1650 (string_make_multibyte, string_to_multibyte)
1651 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1652 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1653 (substring_both, Fdelete, internal_equal, Ffillarray)
1654 (Fclear_string, mapcar1)
1655 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1656 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1657 (larger_vector, make_hash_table, maybe_resize_hash_table)
1658 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1659 (Fmaphash, secure_hash):
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 (concat): Check for string index and length overflow.
1662 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1663 (Frequire):
1664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1665 (larger_vector): New API (vec, incr_min, size_max) replaces old
1666 one (vec, new_size, init). This catches size overflow.
1667 INIT was removed because it was always Qnil.
1668 All callers changed.
1669 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1670 the upper bound on a hash table index size.
1671 (make_hash_table, maybe_resize_hash_table): Use it.
1672 (secure_hash): Computer start_byte and end_byte only after
1673 they're known to be in ptrdiff_t range.
1674 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1675 (Ffont_get_glyphs, Ffont_at):
1676 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1677 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1678 (Flist_fonts, Fopen_font):
1679 Don't assume fixnum can fit in int.
1680 (check_gstring): Don't assume index can fit in int.
1681 (font_match_p): Check that fixnum is a character, not a nonnegative
1682 fixnum, since the later code needs to stuff it into an int.
1683 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1684 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1685 conversion overflow issues.
1686 (Fopen_font): Check for integer out of range.
1687 (Ffont_get_glyphs): Don't assume index can fit in int.
1688 * font.h: Adjust decls to match defn changes elsewhere.
1689 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1690 integer overflow.
1691 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1692 printmax_t, where ptrdiff_t is wide enough.
1693 (Finternal_char_font):
1694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1695 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1696 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1697 (Fset_frame_position, x_set_frame_parameters)
1698 (x_set_line_spacing, x_set_border_width)
1699 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1700 Check that fixnums are in proper range for system types.
1701 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1702 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1703 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1704 Use SAFE_ALLOCA_LISP, not alloca.
1705 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1706 intptr_t is wide enough.
1707 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1708 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1709 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1710 Check for fixnum out of range.
1711 * ftfont.c (ftfont_list): Don't assume index fits in int.
1712 Check that fixnums are in proper range for system types.
1713 (ftfont_shape_by_flt):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1715 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1717 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1718 Check that fixnums are in proper range for system types.
1719 * gnutls.h: Adjust decls to match defn changes elsewhere.
1720 * gtkutil.c (xg_dialog_run):
1721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1722 (update_frame_tool_bar):
1723 Check that fixnums are in proper range for system types.
1724 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1725 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1726 * indent.c (last_known_column, last_known_column_point):
1727 (current_column_bol_cache):
1728 (skip_invisible, current_column, check_display_width):
1729 (check_display_width, scan_for_column, current_column_1)
1730 (Findent_to, Fcurrent_indentation, position_indentation)
1731 (indented_beyond_p, Fmove_to_column, compute_motion):
1732 (Fcompute_motion, Fvertical_motion):
1733 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1734 (last_known_column_modified): Use EMACS_INT, not int.
1735 (check_display_width):
1736 (Fcompute_motion):
1737 Check that fixnums and floats are in proper range for system types.
1738 (compute_motion): Don't assume index or fixnum fits in int.
1739 (compute_motion, Fcompute_motion):
1740 Use int, not EMACS_INT, when it is wide enough.
1741 (vmotion): Omit local var start_hpos that is always 0; that way
1742 we don't need to worry about overflow in expressions involving it.
1743 * indent.h: Adjust decls to match defn changes elsewhere.
1744 (struct position):
1745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1746 Use int, not EMACS_INT, where int is wide enough.
1747 Remove unused members ovstring_chars_done and tab_offset;
1748 all uses removed.
1749 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1750 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1751 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1752 (make_gap, copy_text, insert, insert_and_inherit)
1753 (insert_before_markers, insert_before_markers_and_inherit)
1754 (insert_1, count_combining_before, count_combining_after)
1755 (insert_1_both, insert_from_string)
1756 (insert_from_string_before_markers, insert_from_string_1)
1757 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1758 (adjust_after_replace, adjust_after_insert, replace_range)
1759 (replace_range_2, del_range, del_range_1, del_range_byte)
1760 (del_range_both, del_range_2, modify_region)
1761 (prepare_to_modify_buffer, signal_before_change)
1762 (signal_after_change, Fcombine_after_change_execute):
1763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1764 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1765 (balance_an_interval, split_interval_right, split_interval_left)
1766 (find_interval, next_interval, update_interval)
1767 (adjust_intervals_for_insertion, delete_node, delete_interval)
1768 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1769 (static_offset_intervals, offset_intervals)
1770 (merge_interval_right, merge_interval_left, make_new_interval)
1771 (graft_intervals_into_buffer, temp_set_point_both)
1772 (temp_set_point, set_point, adjust_for_invis_intang)
1773 (set_point_both, move_if_not_intangible, get_property_and_range)
1774 (get_local_map, copy_intervals, copy_intervals_to_string)
1775 (compare_string_intervals, set_intervals_multibyte_1):
1776 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1777 * intervals.h: Adjust decls to match defn changes elsewhere.
1778 (struct interval):
1779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1780 * keyboard.c (this_command_key_count, this_single_command_key_start)
1781 (before_command_key_count, before_command_echo_length, echo_now)
1782 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1783 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1784 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1785 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1787 (last_non_minibuf_size, last_point_position, echo_truncate)
1788 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1789 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1790 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1791 (stuff_buffered_input):
1792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1793 (last_auto_save, command_loop_1, read_char):
1794 Use EMACS_INT, not int, to avoid integer overflow.
1795 (record_char): Avoid overflow in total_keys computation.
1796 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1797 * keyboard.h: Adjust decls to match defn changes elsewhere.
1798 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1799 (Fkey_description, Fdescribe_vector, Flookup_key):
1800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1801 (click_position): New function, to check that positions are in range.
1802 (Fcurrent_active_maps):
1803 (describe_command):
1804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1805 (Faccessible_keymaps, Fkey_description):
1806 (preferred_sequence_p):
1807 Don't assume fixnum can fit into int.
1808 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1809 Check for integer overflow in size calculations.
1810 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1811 avoid mishandling large integers.
1812 * lisp.h: Adjust decls to match defn changes elsewhere.
1813 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1814 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1815 (struct Lisp_Marker):
1816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1817 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1818 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1819 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1820 All callers changed.
1821 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1822 Assume the arg has valid form, since it always does.
1823 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1824 unsigned integer system type.
1825 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1826 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1829 (duration_to_sec_usec): New decl.
1830 * lread.c (read_from_string_index, read_from_string_index_byte)
1831 (read_from_string_limit, readchar, unreadchar, openp)
1832 (read_internal_start, read1, oblookup):
1833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1834 (Fload, readevalloop, Feval_buffer, Feval_region):
1835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1836 (openp): Check for out-of-range argument to 'access'.
1837 (read1): Use int, not EMACS_INT, where int is wide enough.
1838 Don't assume fixnum fits into int.
6efdadfd 1839 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1840 (read_filtered_event): Use duration_to_sec_usec
1841 to do proper overflow checking on durations.
d311d28c
PE
1842 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1843 in size calculation.
1844 (Fexecute_kbd_macro):
1845 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1846 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1847 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1848 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1849 (set_marker_both, set_marker_restricted_both, marker_position)
1850 (marker_byte_position, Fbuffer_has_markers_at):
1851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1852 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1853 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1854 It now merely ensures that the menu is large enough, without
1855 necessarily growing it, as this avoids some integer overflow issues.
1856 All callers changed.
1857 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1859 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1860 Use SAFE_ALLOCA_LISP, not alloca.
1861 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1862 to EMACS_INT. Check that fixnums are in proper range for system types.
1863 * minibuf.c (minibuf_prompt_width, string_to_object)
1864 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1865 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1867 (get_minibuffer, read_minibuf_unwind):
1868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1869 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1870 this simplifies overflow checking. All callers changed.
1871 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1872 (Ftest_completion):
1873 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1874 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1875 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1876 Check that fixnums are in proper range for system types.
1877 (Fx_create_frame, Fx_show_tip):
1878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1879 * nsfont.m (ns_findfonts, nsfont_list_family):
1880 Don't assume fixnum fits in long.
1881 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1883 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1884 wide enough.
17fdb222 1885 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1888 (PRINTDECLARE, PRINTPREPARE):
1889 (strout, print_string):
1890 (print, print_preprocess, print_check_string_charset_prop)
1891 (print_object):
1892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1893 (PRINTDECLARE):
1894 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1895 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1896 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1897 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1898 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1899 (print_error_message): Use SAFE_ALLOCA, not alloca.
1900 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1901 (print_depth, new_backquote_output, print_number_index):
1902 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1903 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1904 (Fset_process_window_size, Fformat_network_address)
1905 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1906 (sigchld_handler):
d311d28c 1907 Check that fixnums are in proper range for system types.
d44287d4 1908 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1909 Check for process-ids out of pid_t range rather than relying on
1910 undefined behavior.
e4d81efc 1911 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1912 (Fformat_network_address, read_process_output, send_process)
1913 (Fprocess_send_region, status_notify):
1914 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1915 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1916 (wait_reading_process_output, read_process_output, exec_sentinel):
1917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1918 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1919 (Faccept_process_output): Use duration_to_sec_usec to do proper
1920 overflow checking on durations.
dde14581
PE
1921 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1922 Don't assume pid_t fits in int.
02481186
PE
1923 * process.h (struct Lisp_Process): Members tick and update_tick
1924 are now of type EMACS_INT, not int.
b62b53e8
PE
1925 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1926 configured --with-wide-int.
d311d28c
PE
1927 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1928 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1929 * search.c (looking_at_1, string_match_1):
1930 (fast_string_match, fast_c_string_match_ignore_case)
1931 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1932 (scan_newline, find_before_next_newline, search_command)
1933 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1934 (set_search_regs, wordify):
1935 (Freplace_match):
1936 (Fmatch_data):
1937 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1938 (string_match_1, search_buffer, set_search_regs):
1939 (Fmatch_data):
1940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1941 (wordify): Check for overflow in size calculation.
1942 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1943 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1944 Check that fixnums are in proper range for system types.
1945 * sound.c (struct sound_device)
1946 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1948 (Fplay_sound_internal):
1949 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1950 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1951 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1952 (Fparse_partial_sexp):
1953 Don't assume fixnums can fit in int.
1954 (struct lisp_parse_state, find_start_pos, find_start_value)
1955 (find_start_value_byte, find_start_begv)
1956 (update_syntax_table, char_quoted, dec_bytepos)
1957 (find_defun_start, prev_char_comend_first, back_comment):
1958 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1959 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1960 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1961 (Finternal_describe_syntax_value): Check that match_lisp is a
1962 character, not an integer, since the code stuffs it into int.
1963 (scan_words, scan_sexps_forward):
1964 Check that fixnums are in proper range for system types.
1965 (Fforward_word):
1966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1967 (scan_sexps_forward):
1968 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1969 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1970 * syntax.h: Adjust decls to match defn changes elsewhere.
1971 (struct gl_state_s):
1972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1973 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1974 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1975 * sysdep.c (wait_for_termination_1, wait_for_termination)
1976 (interruptible_wait_for_termination, mkdir):
1977 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1978 (emacs_read, emacs_write):
1979 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1980 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1981 and double all fit in int.
d311d28c
PE
1982 * term.c (set_tty_color_mode):
1983 Check that fixnums are in proper range for system types.
1984 * termhooks.h (struct input_event):
1985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1986 * textprop.c (validate_interval_range, interval_of)
1987 (Fadd_text_properties, set_text_properties_1)
1988 (Fremove_text_properties, Fremove_list_of_text_properties)
1989 (Ftext_property_any, Ftext_property_not_all)
1990 (copy_text_properties, text_property_list, extend_property_ranges)
1991 (verify_interval_modification):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (Fnext_single_char_property_change)
1994 (Fprevious_single_char_property_change):
1995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1996 (copy_text_properties):
1997 Check for integer overflow in index calculation.
d311d28c
PE
1998 * undo.c (last_boundary_position, record_point, record_insert)
1999 (record_delete, record_marker_adjustment, record_change)
2000 (record_property_change):
2001 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2002 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2004 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2005 (Fx_hide_tip, Fx_file_dialog):
2006 * w32menu.c (set_frame_menubar):
2007 Use ptrdiff_t, not int, for consistency with rest of code.
2008 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2009 (select_window, Fdelete_other_windows_internal)
2010 (window_scroll_pixel_based, window_scroll_line_based)
2011 (Frecenter, Fset_window_configuration):
2012 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2013 (Fset_window_hscroll, run_window_configuration_change_hook)
2014 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2015 (Fscroll_other_window, Frecenter):
d311d28c
PE
2016 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2017 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2018 Don't assume fixnum fits in int.
2019 (Fset_window_scroll_bars):
2020 Check that fixnums are in proper range for system types.
2021 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2022 (string_pos, c_string_pos, number_of_chars, init_iterator)
2023 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2024 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2025 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2026 (face_before_or_after_it_pos, handle_invisible_prop)
2027 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2028 (display_prop_intangible_p, string_buffer_position_lim)
2029 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2030 (get_overlay_strings_1, get_overlay_strings)
2031 (iterate_out_of_display_property, forward_to_next_line_start)
2032 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2033 (get_next_display_element, set_iterator_to_next)
2034 (get_visually_first_element, compute_stop_pos_backwards)
2035 (handle_stop_backwards, next_element_from_buffer)
2036 (move_it_in_display_line_to, move_it_in_display_line)
2037 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2038 (add_to_log, message_dolog, message_log_check_duplicate)
2039 (message2, message2_nolog, message3, message3_nolog
2040 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2041 (current_message_1, truncate_echo_area, truncate_message_1)
2042 (set_message, set_message_1, store_mode_line_noprop)
2043 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2044 (text_outside_line_unchanged_p, check_point_in_composition)
2045 (reconsider_clip_changes)
2046 (redisplay_internal, set_cursor_from_row, try_scrolling)
2047 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2048 (redisplay_window, find_last_unchanged_at_beg_row)
2049 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2050 (trailing_whitespace_p, find_row_edges, display_line)
2051 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2052 (display_mode_element, store_mode_line_string)
2053 (pint2str, pint2hrstr, decode_mode_spec)
2054 (display_count_lines, display_string, draw_glyphs)
2055 (x_produce_glyphs, x_insert_glyphs)
2056 (rows_from_pos_range, mouse_face_from_buffer_pos)
2057 (fast_find_string_pos, mouse_face_from_string_pos)
2058 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2060 (safe_call, init_from_display_pos, handle_fontified_prop)
2061 (handle_single_display_spec, load_overlay_strings)
2062 (with_echo_area_buffer, setup_echo_area_for_printing)
2063 (display_echo_area, echo_area_display)
2064 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2065 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2066 (redisplay_window, dump_glyph_row, display_mode_line)
2067 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2068 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2070 (handle_single_display_spec, build_desired_tool_bar_string)
2071 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2072 (get_specified_cursor_type):
2073 Check that fixnums are in proper range for system types.
2074 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2075 (Flookup_image_map):
2076 Don't assume fixnums fit in int.
2077 (compare_overlay_entries):
2078 Avoid mishandling comparisons due to subtraction overflow.
2079 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2080 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2081 (handle_tool_bar_click):
2082 Use int, not unsigned, since we prefer signed and the signedness
2083 doesn't matter here.
2084 (get_next_display_element, next_element_from_display_vector):
2085 Use int, not EMACS_INT, when int is wide enough.
2086 (start_hourglass): Use duration_to_sec_usec to do proper
2087 overflow checking on durations.
2088 * xfaces.c (Fbitmap_spec_p):
2089 Check that fixnums are in proper range for system types.
2090 (compare_fonts_by_sort_order):
2091 Avoid mishandling comparisons due to subtraction overflow.
2092 (Fx_family_fonts, realize_basic_faces):
2093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2094 (Fx_family_fonts):
2095 Don't assume fixnum fits in int.
2096 Use SAFE_ALLOCA_LISP, not alloca.
2097 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2098 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2099 (face_at_buffer_position, face_for_overlay_string)
2100 (face_at_string_position):
2101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2102 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2103 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2104 (Fx_show_tip):
2105 Check that fixnums are in proper range for system types.
2106 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2107 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2108 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2109 (Fx_change_window_property): Don't assume fixnums fit in int.
2110 * xfont.c (xfont_chars_supported):
2111 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2112 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2113 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2115 * xml.c (parse_region):
2116 * xrdb.c (magic_file_p):
2117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2118 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2119 (x_get_local_selection, x_reply_selection_request)
2120 (x_handle_selection_request, wait_for_property_change):
2121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2122 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2123 short is wide enough.
2124 (x_send_client_event): Don't assume fixnum fits in int.
2125 * xterm.c (x_x_to_emacs_modifiers):
2126 Don't assume EMACS_INT overflows nicely into int.
2127 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2128 may come from Lisp.
2129 (handle_one_xevent): NATNUMP can eval its arg twice.
2130 (x_connection_closed):
2131 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2132 * xterm.h: Adjust decls to match defn changes elsewhere.
2133 (struct scroll_bar): Use struct vectorlike_header
2134 rather than rolling our own approximation.
2135 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2136
c6574eb5
GM
21372012-05-25 Glenn Morris <rgm@gnu.org>
2138
2139 * lisp.mk (lisp): Update for more files being compiled now.
2140
e8d32c7e
SM
21412012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2142
48def666
SM
2143 * lread.c: Remove `read_pure' which makes no difference.
2144 (read_pure): Remove var.
2145 (unreadpure): Remove function.
2146 (readevalloop): Don't call read_list with -1 flag.
2147 (read1, read_vector): Don't test read_pure any more.
2148 (read_list): Simplify.
2149
e8d32c7e
SM
2150 * fileio.c, character.h: Minor style tweaks.
2151
4b2addb7
DA
21522012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 * window.h (clip_changed): Remove useless declaration.
2155
584461b2
JB
21562012-05-22 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2159 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2160
34374650
PE
21612012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2162
2163 Remove src/m/*.
2164 This directory predates autoconf and is no longer needed nowadays.
2165 Move its few remaining bits of functionality to where they're needed.
2166 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2167 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2168 * m/template.h: Remove.
2169 * Makefile.in (M_FILE): Remove. All uses removed.
2170 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2171 * lisp.h (USE_LSB_TAG):
2172 * mem-limits.h (EXCEEDS_LISP_PTR):
2173 Use VAL_MAX, not VALBITS, in #if.
2174 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2175 (EMACS_UINT): Define unconditionally now.
2176 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2177 (BITS_PER_EMACS_INT): New constants, replacing
2178 what used to be in config.h, but not useful in #if.
2179 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2180 define them any more.
2181 (VAL_MAX): New macro.
2182 (VALMASK): Use it.
2183 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2184 BITS_PER_EMACS_INT, in #if.
2185 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2186 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2187 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2188 * s/ms-w32.h (DATA_START):
2189 Move here from removed file m/intel386.h.
2190 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2191 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2192
261cb4bb
PE
21932012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 Assume C89 or later.
2196 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2197 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2198 (xrealloc):
2199 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2200 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2201 * textprop.c, tparam.c (NULL): Remove.
2202 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2203 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2204 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2205 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2206 * xterm.c (input_signal_count): Assume volatile works.
2207
ff23cd9f
KB
22082012-05-21 Ken Brown <kbrown@cornell.edu>
2209
2210 * xgselect.c (xg_select): Fix first argument in call to 'select'
2211 (bug#11508).
2212
1b170bc6
KB
22132012-05-20 Ken Brown <kbrown@cornell.edu>
2214
2215 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2216 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2217
b2f4d39f
KB
22182012-05-19 Ken Brown <kbrown@cornell.edu>
2219
2220 * xfns.c (x_in_use): Remove `static' qualifier.
2221 * xterm.h (x_in_use): Declare.
2222 * xgselect.c: Include xterm.h.
2223 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2224 and `display_arg' (bug#9754).
2225
003fdae2
PE
22262012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2227
9232a6d9
PE
2228 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2229
003fdae2
PE
2230 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2231 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2232
784b56e2
EZ
22332012-05-18 Eli Zaretskii <eliz@gnu.org>
2234
2235 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2236
2237 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2238 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2239
2240 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2241 reference to image_cache->refcount.
2242 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2243
a0a79cde
JL
22442012-05-17 Juri Linkov <juri@jurta.org>
2245
2246 * search.c (Fword_search_regexp, Fword_search_backward)
2247 (Fword_search_forward, Fword_search_backward_lax)
2248 (Fword_search_forward_lax): Move functions to isearch.el
2249 (bug#10145, bug#11381).
2250
b0572523
PE
22512012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2252
2253 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2254
9660f5fc
SM
22552012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2256
2257 * lread.c (init_obarray): Declare Qt and Qnil as special.
2258
4374de83
GM
22592012-05-14 Glenn Morris <rgm@gnu.org>
2260
2261 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2262 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2263
dc44c39a
PE
22642012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2265
078c97cb
PE
2266 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2267
dc44c39a
PE
2268 * unexaix.c: Port to more-recent AIX compilers.
2269 (report_error, report_error_1, make_hdr, copy_sym)
2270 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2271 Make arguments const char *, not char *, to avoid violations of C
2272 standard and to fix some AIX warnings reported by Gilles Pion.
2273
e18afed7 22742012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2275
2276 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2277 already have overlays loaded.
2278 (handle_single_display_spec): Before returning without displaying
2279 fringe bitmap, synchronize the bidi iterator with the main display
2280 iterator, by calling iterate_out_of_display_property.
2281 (iterate_out_of_display_property): Detect buffer iteration by
2282 testing that it->string is a Lisp string.
2283 (get_next_display_element): When the current object is exhausted,
2284 and there's something on it->stack, call set_iterator_to_next to
2285 proceed with what's on the stack, instead of returning zero.
2286 (set_iterator_to_next): If called at the end of a Lisp string,
2287 proceed to consider_string_end without incrementing string
2288 position. Don't increment display vector index past the end of
2289 the display vector. (Bug#11417)
c8fb9dc6
EZ
2290 (pos_visible_p): Don't report a position visible when move_it_to
2291 stopped at the last line of window, which happens to be scanned
2292 backwards by the bidi iteration. (Bug#11464)
ac268e67 2293
e18afed7 22942012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2295
2296 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2297 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2298 are on a TTY, and thus unable to display on the fringes.
2299 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2300 so we need to signal to the caller that this is a "replacing"
2301 display spec. This fixes display when the spec is invalid or we
2302 are on a TTY.
2303
e18afed7 23042012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2305
2306 * unexaix.c (make_hdr): Fix typo in prototype.
2307 This bug broke the build on AIX. Problem reported by Gilles Pion.
2308
9d0a235a
MA
23092012-05-14 Michael Albinus <michael.albinus@gmx.de>
2310
2311 * keyboard.c (kbd_buffer_get_event): Read special events also in
2312 batch mode. (Bug#11415)
2313
9e6b06ed
GM
23142012-05-12 Glenn Morris <rgm@gnu.org>
2315
2316 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2317
c1a1d7a3
EZ
23182012-05-12 Eli Zaretskii <eliz@gnu.org>
2319
2320 * lisp.mk (lisp): Add newcomment.elc.
2321
3fe7cdc8
GM
23222012-05-12 Glenn Morris <rgm@gnu.org>
2323
2324 * Makefile.in (MKDIR_P): New, set by configure.
2325 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2326
53f7d2c0
PE
23272012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2328
2329 Remove unused function hourglass_started.
2330 * dispextern.h (hourglass_started):
2331 * w32fns.c (hourglass_started):
2332 * xdisp.c (hourglass_started): Remove.
2333
75aafb17
JB
23342012-05-10 Juanma Barranquero <lekktu@gmail.com>
2335
2336 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2337 Update dependencies.
2338
12959e8e
PE
23392012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2340
97107e2e
PE
2341 * xgselect.c (xg_select): Put maxfds+1 into a var.
2342 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2343
12959e8e
PE
2344 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2345
836d29b3
DA
23462012-05-10 Dave Abrahams <dave@boostpro.com>
2347
2348 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2349 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2350
5cb67954
MA
23512012-05-09 Michael Albinus <michael.albinus@gmx.de>
2352
2353 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2354 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2355 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2356 Initialize xd_registered_buses.
2357
3478ec45
PE
23582012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2359
b263a6b0
PE
2360 Untag more efficiently if USE_LSB_TAG.
2361 This is based on a proposal by YAMAMOTO Mitsuharu in
2362 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2363 For an admittedly artificial (nth 8000 longlist) benchmark on
2364 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2365 Emacs's overall text size by 1%.
2366 * lisp.h (XUNTAG): New macro.
2367 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2368 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2369 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2370 * eval.c (Fautoload):
2371 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2372 * frame.h (XFRAME): Use XUNTAG.
2373
3478ec45
PE
2374 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2375 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2376 Remove unportable assumptions about print widths of types like
2377 dbus_uint32_t.
2378 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2379 intptr_t when converting between pointer and integer, to avoid GCC
2380 warnings about wrong width.
2381
666b903b 23822012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2383
2384 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2385 stack for each reader_thread, instead of defaulting to 8MB
2386 determined by the linker. This avoids failures in creating
2387 subprocesses on Windows 7, see the discussion in this thread:
2388 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2389
b120cc17
JC
23902012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2391
2392 Fix up display of the *Minibuf-0* buffer in the mini window.
2393 * keyboard.c (read_char): Don't clear the echo area if there's no
2394 message to clear.
2395 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2396 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2397
9a4b36f8
MA
23982012-05-07 Michael Albinus <michael.albinus@gmx.de>
2399
2400 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2401 batch mode.
2402
e5f9458f
CY
24032012-05-06 Chong Yidong <cyd@gnu.org>
2404
2405 * lisp.mk (lisp): Update.
2406
eceeb5fc 24072012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2408
2409 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2410
71873e2b
SM
24112012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2412
2413 * data.c (PUT_ERROR): New macro.
2414 (syms_of_data): Use it. Add new error type `user-error'.
2415 * undo.c (user_error): New function.
2416 (Fprimitive_undo): Use it.
2417 * print.c (print_error_message): Adjust print style for `user-error'.
2418 * keyboard.c (user_error): New function.
2419 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2420
ab0fa4e4
PE
24212012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Do not limit current-time-string to years 1000..9999.
2424 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2425 (Fcurrent_time_string): Support any year that is supported by the
2426 underlying localtime representation. Don't use asctime, as it
2427 has undefined behavior for years outside the range -999..9999.
2428
7ed806a7
PE
24292012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2430
2431 Fix race conditions involving setenv, gmtime, localtime, asctime.
2432 Without this fix, interrupts could mess up code that uses these
2433 nonreentrant functions, since setting TZ invalidates existing
2434 tm_zone or tzname values, and since most of these functions return
2435 pointers to static storage.
2436 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2437 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2438 Grow the critical sections to include not just invoking
2439 localtime/gmtime, but also accessing these functions' results
2440 including their tm_zone values if any, and any related TZ setting.
2441 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2442 so that the struct tm is saved in the critical section.
2443 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2444 motivated by the fact that memory allocation needs to be outside
2445 the critical section.
2446
0c16dfed
DA
24472012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2448
2449 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2450 with RESET_INTERVAL.
2451
2452 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2453 Remove duplicated buffer name initialization.
2454
3f83ace8
JM
24552012-05-02 Jim Meyering <jim@meyering.net>
2456
2457 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2458
c7b8541e
JM
2459 * xfns.c (x_window): Use xstrdup (Bug#11375).
2460
90207a15 24612012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2462
2463 * xdisp.c (pos_visible_p): If already at a newline from the
2464 display string before the 'while' loop, don't walk back the glyphs
2465 from it3.glyph_row. Solves assertion violation when the display
2466 string begins with a newline (egg.el). (Bug#11367)
2467
b593d6a9
AH
24682012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2469
2470 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2471 Move to simple.el.
2472
4737362e
GM
24732012-05-01 Glenn Morris <rgm@gnu.org>
2474
99cf43f9
GM
2475 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2476 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2477 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2478 All were removed before 23.1.
2479
9311dcff
GM
2480 * dispnew.c: Remove HAVE_LIBNCURSES test;
2481 it is always true on relevant platforms.
2482
4d5c6349
GM
2483 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2484 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2485
4737362e
GM
2486 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2487
74dd3a6b
AS
24882012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2489
2490 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2491 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2492 Remove.
2493
13c379ee
PE
24942012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 Do not avoid creating empty evaporating overlays (Bug#9642).
2497 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2498 That is, do not delete an evaporating overlay if it becomes
2499 empty after its bounds are adjusted to fit within its buffer.
2500 This fix caused other problems, and I'm reverting it until we get
2501 to the bottom of them.
2502
a8e7d6d7 25032012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2504
2505 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2506
a8e7d6d7 25072012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2508
2509 * xdisp.c (pos_visible_p): If the window start position is beyond
2510 ZV, start the display from buffer beginning. Prevents assertion
2511 violation in init_iterator when the minibuffer window is scrolled
2512 via the scroll bar.
2513
2514 * window.c (window_scroll_pixel_based): Likewise.
2515
a8e7d6d7 25162012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2517
2518 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2519
a8e7d6d7 25202012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2521
2522 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2523 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2524
a8e7d6d7 25252012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2526
b593d6a9
AH
2527 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2528 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2529
1c6900d9
EZ
25302012-04-26 Eli Zaretskii <eliz@gnu.org>
2531
4c3fa1d9
EZ
2532 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2533 display element, check also the underlying string or buffer
2534 character. (Bug#11341)
2535
1c6900d9
EZ
2536 * w32menu.c: Include w32heap.h.
2537 (add_menu_item): If the call to AppendMenuW (via
2538 unicode_append_menu) fails, disable Unicode menus only if we are
2539 running on Windows 9X/Me.
2540
42bf8205
AS
25412012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2542
2543 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2544 (xgetint): Add missing shift for LSB tags.
2545
b1bac16e
MR
25462012-04-24 Martin Rudalics <rudalics@gmx.at>
2547
2548 * keyboard.c (read_char): Don't wipe echo area for select window
2549 events: These might get delayed via `mouse-autoselect-window'
2550 (Bug#11304).
2551
d69621cc
JB
25522012-04-24 Juanma Barranquero <lekktu@gmail.com>
2553
2554 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2555 manipulation of :loaded-from data.
2556
02fd101b
JB
25572012-04-23 Juanma Barranquero <lekktu@gmail.com>
2558
2559 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2560 now a cons (bug#11311).
2561
888bec30
PE
25622012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2563
89a438bd
PE
2564 Do not create empty overlays with the evaporate property (Bug#9642).
2565 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2566 if it becomes empty after its bounds are adjusted to fit within
2567 its buffer. Without this fix, in a nonempty buffer (let ((o
2568 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2569 yields an empty overlay that has the evaporate property, which is
2570 not supposed to happen.
2571
1068fe4d
PE
2572 Fix minor GTK3 problems found by static checking.
2573 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2574 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2575 (struct _EmacsFixedClass, emacs_fixed_get_type):
2576 Move decls here from emacsgtkfixed.h, since they needn't be public.
2577 (emacs_fixed_get_type): Now static.
2578 (emacs_fixed_class_init): Omit unused local.
2579 (emacs_fixed_child_type): Remove; unused.
2580 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2581 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2582 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2583 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2584 (EMACS_FIXED_GET_CLASS): Remove; unused.
2585 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2586
888bec30
PE
2587 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2588 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2589
de85e130
PE
25902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2591
d0baac98 2592 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2593 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2594 (__malloc_size_t, __malloc_ptrdiff_t):
2595 Remove. All uses removed, replaced by the definiens if needed,
2596 since we can assume C89 or better now.
2597 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2598 (protect_malloc_state, align, get_contiguous_space)
2599 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2600 (malloc_atfork_handler_child, malloc_enable_thread)
2601 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2602 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2603 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2604 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2605 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2606 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2607 Define using prototypes, not old style.
2608 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2609 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2610 (align): Don't assume that signed integer overflow wraps around.
2611 Omit unused local var.
2612 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2613 (_free_internal_nolock, memalign, mallochook, reallochook):
2614 Omit no-longer-needed casts.
2615 (valloc): Use getpagesize, not __getpagesize.
2616 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2617 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2618
de85e130
PE
2619 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2620
dcbf5805
MA
26212012-04-22 Michael Albinus <michael.albinus@gmx.de>
2622
2623 Move functions from C to Lisp. Make non-blocking method calls
2624 the default. Implement further D-Bus standard interfaces.
2625
2626 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2627 (QCdbus_request_name_allow_replacement)
2628 (QCdbus_request_name_replace_existing)
2629 (QCdbus_request_name_do_not_queue)
2630 (QCdbus_request_name_reply_primary_owner)
2631 (QCdbus_request_name_reply_in_queue)
2632 (QCdbus_request_name_reply_exists)
2633 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2634 (QCdbus_registered_serial, QCdbus_registered_method)
2635 (QCdbus_registered_signal): New Lisp objects.
2636 (XD_DEBUG_MESSAGE): Use sizeof.
2637 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2638 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2639 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2640 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2641 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2642 (xd_signature, xd_append_arg): Allow float for integer types.
2643 (xd_get_connection_references): New function.
b593d6a9
AH
2644 (xd_get_connection_address): Rename from xd_initialize.
2645 Return cached address.
dcbf5805
MA
2646 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2647 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2648 level.
2649 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2650 Return number of refcounts.
dcbf5805
MA
2651 (Fdbus_get_unique_name): Make stronger parameter check.
2652 (Fdbus_message_internal): New defun.
2653 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2654 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2655 (Fdbus_send_signal, Fdbus_register_service)
2656 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2657 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2658 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2659 (Vdbus_compiled_version, Vdbus_runtime_version)
2660 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2661 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2662 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2663 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2664 Adapt docstring.
dcbf5805 2665
52828e02
PE
26662012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2667
da05bc4c
PE
2668 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2669 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2670 Do not assume ptrdiff_t is the same width as 'int'.
2671
52828e02
PE
2672 * alloc.c: Handle unusual debugging option combinations.
2673 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2674 since the two debugging options are incompatible.
2675 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2676 is defined.
2677 (mem_init, mem_insert, mem_insert_fixup):
2678 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2679 (NEED_MEM_INSERT): Remove; no longer needed.
2680
f01769f9
LL
26812012-04-22 Leo Liu <sdl.web@gmail.com>
2682
2683 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2684
5790543d
PE
26852012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2686
2687 * sysdep.c [__FreeBSD__]: Minor cleanups.
2688 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2689 Use Emacs indenting style more consistently. Avoid some casts.
2690 Use 'double' consistently rather than mixing 'float' and 'double'.
2691
b91b7e4d
EW
26922012-04-21 Eduard Wiebe <usenet@pusto.de>
2693
b593d6a9
AH
2694 * sysdep.c (list_system_processes, system_process_attributes):
2695 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2696
6114eb15
AS
26972012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2698
2699 * lisp.mk (lisp): Update.
2700
2f38dff7
PE
27012012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2702
2703 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2704 It is never used otherwise.
2705
4ae29f89
SM
27062012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2707
2708 * print.c (print_preprocess): Only check print_depth if print-circle
2709 is nil.
2710 (print_object): Check for cycles even when print-circle is nil and
2711 print-gensym is t, but only check print_depth if print-circle is nil.
2712
f30d612a
CY
27132012-04-20 Chong Yidong <cyd@gnu.org>
2714
2715 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2716 set the status to "failed" and ensure that sentinel is run.
2717
c07a4c0b 27182012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2719
2720 * process.c (Fset_process_inherit_coding_system_flag)
2721 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2722 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2723
c07a4c0b 27242012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2725
2726 * xdisp.c (string_buffer_position_lim): Limit starting position to
2727 BEGV.
2728 (set_cursor_from_row): If called for a mode-line or header-line
2729 row, return zero immediately.
2730 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2731 farther than the first row after the header line, if any.
2732 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2733 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2734
c07a4c0b 27352012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2736
4ae29f89
SM
2737 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2738 (bug#11238).
ad3a2b41 2739
c07a4c0b 27402012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 27412012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2742
2743 configure: new option --enable-gcc-warnings (Bug#11207)
2744 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2745 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2746 (ALL_CFLAGS): Use new macros rather than old.
2747 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2748 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2749 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2750 -Wunused-result, -Wunused-variable. This should go away once
2751 the Emacs and Gnulib regex code is merged.
2752 (xmalloc, xrealloc): Now static.
2753
aba027e8
PE
27542012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2755
2756 * dired.c (Fsystem_groups): Remove unused local.
2757
e5a36063
GM
27582012-04-17 Glenn Morris <rgm@gnu.org>
2759
2760 * dired.c (Fsystem_users): Doc fix.
2761
316411f0
DA
27622012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2763
2764 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2765 (syms_of_dired): Add them.
2766
9426aba4
PE
27672012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2768
b62a57be
PE
2769 Fix minor alloc.c problems found by static checking.
2770 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2771 New extern decls, to avoid calling undeclared functions.
2772 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2773 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2774 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2775 (NEED_MEM_INSERT): New macro.
2776 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2777 Remove one incorrect comment and fix another.
b62a57be 2778
3539f31f
PE
2779 Fix minor ralloc.c problems found by static checking.
2780 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2781 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2782 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2783 (r_alloc_sbrk): Now static.
2784
a041960a
PE
2785 Improve ralloc.c interface checking.
2786 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2787 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2788 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2789 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2790 [REL_ALLOC]: ... to here, to check interface.
2791 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2792 Remove decls. This fixes an "It stinks!".
2793
9426aba4
PE
2794 * alloc.c (which_symbols): Fix alignment issue / type clash.
2795
d55c12ed
AS
27962012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2797
2798 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2799 (struct Lisp_Misc_Any): Likewise.
2800 (struct Lisp_Free): Likewise.
2801 * alloc.c (union aligned_Lisp_Symbol): Define.
2802 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2803 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2804 (union aligned_Lisp_Misc): Define.
2805 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2806 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2807 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2808
b948ce8b
PE
28092012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2812 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2813 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2814 * s/netbsd.h, s/sol2-6.h:
2815 Remove definition of GC_MARK_STACK, since the default now works.
2816 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2817 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2818 no longer the default.
2819 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2820
35dc09a1 28212012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2822
35dc09a1
GM
2823 * lread.c (lisp_file_lexically_bound_p):
2824 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2825
35dc09a1
GM
28262012-04-14 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2829 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2830
28312012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2832
2833 * nsterm.m (constrainFrameRect): Always constrain when there is only
2834 one screen (Bug#10962).
2835
bcd86815
KB
28362012-04-13 Ken Brown <kbrown@cornell.edu>
2837
2838 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2839
c25df26e
RT
28402012-04-13 Reuben Thomas <rrt@sc3d.org>
2841
2842 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2843
0fc59f1e
DC
28442012-04-11 Daniel Colascione <dancol@dancol.org>
2845
2846 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2847 against is gone. It's better to use vfork now so that when Cygwin
2848 gains a new, working vfork, we use it automatically (bug#10398).
2849
de8c03dc
SM
28502012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2851
2852 * window.c (save_window_save): Obey window-point-insertion-type.
2853
2f097256
GM
28542012-04-11 Glenn Morris <rgm@gnu.org>
2855
2856 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2857
453b951e
SM
28582012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2861
75f1671a 28622012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2863
2864 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2865 (force_quit_count): New var.
2866 (handle_interrupt): Use it.
2867
2a8ce227
JB
28682012-04-10 Juanma Barranquero <lekktu@gmail.com>
2869
2870 * w32.c (w32_delayed_load): Record the full path of the library
2871 being loaded (bug#10424).
2872
935396c0
GM
28732012-04-09 Glenn Morris <rgm@gnu.org>
2874
05920a43
GM
2875 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2876 not just in the obarray, before snarfing them. (Bug#11036)
2877
935396c0
GM
2878 * Makefile.in ($(leimdir)/leim-list.el):
2879 Pass EMACS rather than BUILT_EMACS.
2880
a18ecafa
TZ
28812012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2882
2883 * process.c (make_process):
2884 * process.h: Add integer `gnutls_handshakes_tried' member to
2885 process struct.
2886
6bbef4e5
JC
2887 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2888 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2889
2890 * gnutls.c (gnutls_log_function2i): Convenience log function.
2891 (emacs_gnutls_read): Use new log functions,
2892 `gnutls_handshakes_tried' process member, and
2893 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2894 attempts per process (connection).
2895
b4d3bc10
CY
28962012-04-09 Chong Yidong <cyd@gnu.org>
2897
2898 * eval.c (Fuser_variable_p, user_variable_p_eh)
2899 (lisp_indirect_variable): Functions deleted.
2900 (Fdefvar): Caller changed.
2901
2902 * callint.c (Finteractive, Fcall_interactively):
2903 * minibuf.c (Fread_variable): Callers changed.
2904
70f4d973
EZ
29052012-04-09 Eli Zaretskii <eliz@gnu.org>
2906
2907 * xdisp.c (set_cursor_from_row): If the display string appears in
2908 the buffer at position that is closer to point than the position
2909 after the display string, display the cursor on the first glyph of
2910 the display string. Fixes cursor display when a 'display' text
2911 property immediately follows invisible text. (Bug#11094)
2912
cb3c2e3e
PE
29132012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2914
2915 composite.c: use 'double' consistently
2916 * composite.c (get_composition_id): Use 'double' consistently
2917 instead of converting 'float' to 'double' and vice versa; this is
2918 easier to understand and avoids a GCC warning.
2919
fd06db5d
GM
29202012-04-09 Glenn Morris <rgm@gnu.org>
2921
50fe702a
GM
2922 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2923 preparation for dumping it with emacs. (Bug#4789)
2924 (leimdir): New variable.
2925 ($(leimdir)/leim-list.el): New rule.
2926 (emacs$(EXEEXT)): Depend on leim-list.el.
2927
fd06db5d
GM
2928 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2929 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2930 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2931
55c131ee
AS
29322012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2933
2934 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2935 proper alignment.
2936
9209588f
JB
29372012-04-07 Juanma Barranquero <lekktu@gmail.com>
2938
2939 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2940 Remove unused local variable.
2941
e3fb2efb
PE
29422012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2943
2944 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2945 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2946 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2947 objects, as mark_maybe_pointer will catch them otherwise.
2948 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2949 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2950
b5385551
PE
29512012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2952
2953 Fix typo that broke non-Windows builds.
2954 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2955
9078ead6
EZ
29562012-04-07 Eli Zaretskii <eliz@gnu.org>
2957
2958 Support building on MS-Windows with libxml2.
2959
2960 * makefile.w32-in (OBJ2): Add xml.$(O).
2961 (GLOBAL_SOURCES): Add xml.c.
2962 ($(BLD)/xml.$(O)): New dependency list.
2963
2964 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2965 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2966 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2967 [!WINDOWSNT]: New macros.
2968 (init_libxml2_functions, libxml2_loaded_p): New functions.
2969 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2970 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2971 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2972 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2973 linked in).
6bbef4e5
JC
2974 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2975 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2976 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2977
2978 * emacs.c: Don't include libxml/parser.h.
2979 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2980 xmlCleanupParser directly.
2981
2982 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2983
3811fdf3
EZ
29842012-04-07 Eli Zaretskii <eliz@gnu.org>
2985
2986 * indent.c (Fvertical_motion): If there is a display string at
2987 point, use it.vpos to compute how many lines to backtrack after
2988 move_it_to point. (Bug#11133)
2989
2f8e16b2
EZ
29902012-04-06 Eli Zaretskii <eliz@gnu.org>
2991
2992 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2993 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2994 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2995 macros related to unification of CJK characters. For the details,
2996 see the discussion following the message here:
2997 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2998
3d439cd1
CY
29992012-04-04 Chong Yidong <cyd@gnu.org>
3000
3001 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3002
8bc53d00
EZ
30032012-04-01 Eli Zaretskii <eliz@gnu.org>
3004
3005 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3006 instead of alloca. (Bug#11138)
3007
3b0512a3
AS
30082012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3009
3010 * w32menu.c (is_simple_dialog): Properly check lisp types.
3011 (Bug#11141)
3012
8427ddd2
EZ
30132012-03-31 Eli Zaretskii <eliz@gnu.org>
3014
979022ef
EZ
3015 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3016 position we get to after a call to move_it_to fails the
3017 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3018 only if we wind up in a string from display property. (Bug#11063)
3019
a6b1c7cc
EZ
3020 * window.c (Fdelete_other_windows_internal): Invalidate the row
3021 and column information about mouse highlight, so that redisplay
3022 restores it after reallocating the glyph matrices. (Bug#7464)
3023
8427ddd2
EZ
3024 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3025 string comes from a `display' text property, use the buffer
3026 position of that property as if we actually saw that position in
3027 the row's glyphs.
697ba24b
EZ
3028 (move_it_by_lines): Remove the assertion that
3029 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3030 violated when there's a before-string at the beginning of a line.
3031 (Bug#11063)
8427ddd2 3032
65a0a738
EZ
30332012-03-30 Eli Zaretskii <eliz@gnu.org>
3034
3035 * xdisp.c (append_space_for_newline): If the default face was
3036 remapped, use the remapped face for the appended newline.
3037 (extend_face_to_end_of_line): Use the remapped default face for
3038 extending the face to the end of the line.
3039 (display_line): Call extend_face_to_end_of_line when the default
3040 face was remapped. (Bug#11068)
3041
581355cc
EZ
30422012-03-29 Eli Zaretskii <eliz@gnu.org>
3043
3044 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3045
e8fc049f
SM
30462012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3047
3048 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3049
4fb9a543
GM
30502012-03-27 Glenn Morris <rgm@gnu.org>
3051
3052 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3053 Doc fixes.
3054
679910f1
KH
30552012-03-26 Kenichi Handa <handa@m17n.org>
3056
3057 * dispextern.h (struct glyph): Fix previous change. Change the
3058 bit length of glyphless.ch to 25 (Bug#11082).
3059
90d49b7f
CY
30602012-03-26 Chong Yidong <cyd@gnu.org>
3061
3062 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3063 (command_loop_1): Use it; inhibit selection update for
3064 handle-select-window too (Bug#8996).
3065
f514f6f0
FP
30662012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3067
e8fc049f 3068 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3069
bf43fa51
KH
30702012-03-25 Kenichi Handa <handa@m17n.org>
3071
3072 * dispextern.h (struct glyph): Change the bit length of
3073 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3074
8a0c01dd
EZ
30752012-03-24 Eli Zaretskii <eliz@gnu.org>
3076
3077 * s/ms-w32.h (tzname): Include time.h before redirecting to
3078 _tzname. Fixes the MSVC build. (Bug#9960)
3079
7d1c3a76
AS
30802012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3081
8ed79523
AS
3082 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3083 characters.
3084
7d1c3a76
AS
3085 * xterm.c (XTread_socket): Only modify handling_signal if
3086 !SYNC_INPUT. (Bug#11080)
3087
e99a9b8b
EZ
30882012-03-23 Eli Zaretskii <eliz@gnu.org>
3089
3090 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3091 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3092 when fetching a multibyte character consumes more bytes than
3093 CHAR_BYTES returns, due to unification of CJK characters in
3094 string_char. (Bug#11073)
3095
5063c0e1
TN
30962012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3097
3098 * process.c (wait_reading_process_output): Handle pty disconnect
3099 by refraining from sending oneself a SIGCHLD (bug#10933).
3100
9f851fbd
CY
31012012-03-22 Chong Yidong <cyd@gnu.org>
3102
3103 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3104
5063c0e1 3105 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3106 Mark string as coming from a prefix property.
3107 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3108 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3109
fb5b8aca
CY
31102012-03-21 Chong Yidong <cyd@gnu.org>
3111
3112 * xfaces.c (Vface_remapping_alist): Doc fix.
3113
62356a1b
EZ
31142012-03-20 Eli Zaretskii <eliz@gnu.org>
3115
3116 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3117 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3118 Doc fixes.
62356a1b 3119
025de85b
CY
31202012-03-20 Chong Yidong <cyd@gnu.org>
3121
3122 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3123 to reflect default non-nil value of redisplay-dont-pause.
3124
4827f94e
KH
31252012-03-19 Kenichi Handa <handa@m17n.org>
3126
3127 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3128 it fit in a valid range (Bug#11003).
3129
e50a24a2
EZ
31302012-03-18 Eli Zaretskii <eliz@gnu.org>
3131
3132 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3133 that is not from display property, accept the row as a "cursor
3134 row" if one of the string's character has a non-nil `cursor'
3135 property. Fixes cursor positioning when there are newlines in
3136 overlay strings, e.g. in icomplete.el. (Bug#11035)
3137
9af5ed87
PE
31382012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3139
3140 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3141
d1f55f16
CY
31422012-03-12 Chong Yidong <cyd@gnu.org>
3143
3144 * eval.c (inhibit_lisp_code): Rename from
3145 inhibit_window_configuration_change_hook; move from window.c.
3146
3147 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3148 * window.c (run_window_configuration_change_hook)
3149 (syms_of_window): Callers changed.
3150
66c5eebd
CY
31512012-03-11 Chong Yidong <cyd@gnu.org>
3152
413df973
CY
3153 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3154
66c5eebd
CY
3155 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3156
1de11f56
CY
31572012-03-10 Chong Yidong <cyd@gnu.org>
3158
3159 * frame.c (other_visible_frames): Don't assume the selected frame
3160 is visible (Bug#10955).
3161
cae07000
SM
31622012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3163
3164 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3165
89c94350
JD
31662012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3167
3168 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3169 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3170 zero (Bug#10954).
3171
999dd333
GM
31722012-03-03 Glenn Morris <rgm@gnu.org>
3173
01a6dcc8 3174 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3175
de0100f2
EZ
31762012-03-02 Eli Zaretskii <eliz@gnu.org>
3177
3178 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3179 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3180 (redisplay_window, next_element_from_string): Fix typos in
3181 comments.
3e441275
EZ
3182 (redisplay_window): Pass to move_it_vertically the margin in
3183 pixels, not in screen lines.
de0100f2 3184
96a72ee9
GM
31852012-03-02 Glenn Morris <rgm@gnu.org>
3186
3187 * buffer.c (buffer-list-update-hook): Doc fix.
3188
312508d7
EZ
31892012-02-29 Eli Zaretskii <eliz@gnu.org>
3190
3191 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3192 push_it before setting up the iterator for the first overlay
3193 string, even if we have an empty string loaded.
3194 (next_overlay_string): If there's an empty string on the iterator
3195 stack, pop the stack. (Bug#10903)
3196
27f3c637
PE
31972012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3198
3199 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3200 Suggested by Stefan Monnier in
3201 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3202 * alloc.c (widen_to_Lisp_Object): New static function.
3203 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3204 and widening them to Lisp_Objects. This would work even if
3205 USE_LSB_TAG is defined and wide integers are used, which might
3206 happen in a future version of Emacs.
3207
3c9dfce6
CY
32082012-02-25 Chong Yidong <cyd@gnu.org>
3209
fa74b241
CY
3210 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3211 Doc fix.
3212
3c9dfce6
CY
3213 * xselect.c (Fx_selection_exists_p): Doc fix.
3214 (x_clipboard_manager_save_all): Print an informative message
3215 before saving to clipboard manager.
3216
9486df08
CY
32172012-02-24 Chong Yidong <cyd@gnu.org>
3218
3219 * keyboard.c (process_special_events): Handle all X selection
3220 requests in kbd_buffer, not just the next one (Bug#8869).
3221
f01d3321
CY
32222012-02-23 Chong Yidong <cyd@gnu.org>
3223
3224 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3225 call when setting menu-bar-lines and tool-bar-lines parameters.
3226 (unwind_create_frame_1): New helper function.
3227
3228 * window.c (inhibit_window_configuration_change_hook): New var.
3229 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3230 (syms_of_window): Initialize it.
f01d3321 3231
86b847b6
CY
32322012-02-22 Chong Yidong <cyd@gnu.org>
3233
3234 * xterm.c (x_draw_image_relief): Add missing type check for
3235 Vtool_bar_button_margin (Bug#10743).
3236
a59225b1
CY
32372012-02-21 Chong Yidong <cyd@gnu.org>
3238
3239 * fileio.c (Vfile_name_handler_alist): Doc fix.
3240
3241 * buffer.c (Fget_file_buffer): Protect against invalid file
3242 handler return value.
3243
310f5bd4
PE
32442012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3245
cb3a28cc
PE
3246 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3247 when computing $valmask.
3248
310f5bd4
PE
3249 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3250 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3251 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3252 It's useless in that case, and it can cause problems on hosts
3253 that allocate halves of EMACS_INT values separately.
3254 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3255 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3256 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3257 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3258 it avoids undefined behavior on hosts where shifting right by more
3259 than the word width has undefined behavior.
3260
2375c96a
CY
32612012-02-19 Chong Yidong <cyd@gnu.org>
3262
3263 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3264 (Funhandled_file_name_directory, Ffile_name_as_directory)
3265 (Fdirectory_file_name, Fexpand_file_name)
3266 (Fsubstitute_in_file_name): Protect against invalid file handler
3267 return values (Bug#10845).
3268
3eb49e71
EZ
32692012-02-18 Eli Zaretskii <eliz@gnu.org>
3270
3271 * .gdbinit (pitx): Fix incorrect references to fields of the
3272 iterator stack.
3273
7b926f3f
CY
32742012-02-17 Chong Yidong <cyd@gnu.org>
3275
3276 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3277
11273115
PE
32782012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3279
3280 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3281 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3282
c3a70e2b
CY
32832012-02-15 Chong Yidong <cyd@gnu.org>
3284
3285 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3286 marked as special. Also, starting docstrings with * is obsolete.
3287
0ca43699
AS
32882012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3289
3290 * gnutls.c (emacs_gnutls_write): Fix last change.
3291
2e8f3c56
LI
32922012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3293
3294 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3295 send_process.
3296
af70074f
SM
32972012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3298
3299 * keymap.c (Fsingle_key_description): Handle char ranges.
3300
95986d52
CY
33012012-02-12 Chong Yidong <cyd@gnu.org>
3302
afd83bd1
CY
3303 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3304 as that creates a dangerous corner case.
3305
95986d52
CY
3306 * window.c (Fdelete_window_internal): Invalidate the mouse
3307 highlight (Bug#9904).
3308
bd7da63e
GM
33092012-02-12 Glenn Morris <rgm@gnu.org>
3310
3311 * xselect.c (Fx_own_selection_internal)
3312 (Fx_get_selection_internal, Fx_disown_selection_internal)
3313 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3314 * nsselect.m (Fx_own_selection_internal)
3315 (Fx_disown_selection_internal, Fx_selection_exists_p)
3316 (Fx_selection_owner_p, Fx_get_selection_internal):
3317 Sync docs and argument specs with the xselect.c versions.
3318
77abcbc2
LI
33192012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3320
3321 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3322
90b671e2
EZ
33232012-02-11 Eli Zaretskii <eliz@gnu.org>
3324
1c0ca0b7
EZ
3325 * w32select.c (Fx_selection_exists_p): Sync doc string and
3326 argument list with xselect.c. (Bug#10783)
3327
3328 * w16select.c (Fx_selection_exists_p): Sync doc string and
3329 argument list with xselect.c. (Bug#10783)
90b671e2 3330
49241268
GM
33312012-02-10 Glenn Morris <rgm@gnu.org>
3332
3333 * fns.c (Fsecure_hash): Doc fix.
3334
f998bbe7 33352012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3336
3337 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3338
0992bd9c
CY
33392012-02-07 Chong Yidong <cyd@gnu.org>
3340
3341 * buffer.c (Fbuffer_local_variables)
3342 (buffer_lisp_local_variables): Handle unbound vars correctly;
3343 don't let Qunbound leak into Lisp.
3344
af008560
GM
33452012-02-07 Glenn Morris <rgm@gnu.org>
3346
dd605cc4
GM
3347 * image.c (Fimagemagick_types): Doc fix.
3348
af008560
GM
3349 * image.c (imagemagick-render-type): Change it from a lisp object
3350 to an integer. Move the doc here from the lisp manual.
3351 Treat all values not equal to 0 the same.
3352
1449fa1d
CY
33532012-02-06 Chong Yidong <cyd@gnu.org>
3354
3355 * doc.c (store_function_docstring): Avoid applying docstring of
3356 alias to base function (Bug#2603).
3357
3723ec07
AS
33582012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3359
3360 * .gdbinit (pp1, pv1): Remove redundant defines.
3361 (pr): Use pp.
3362
79c1cc1e
CY
33632012-02-04 Chong Yidong <cyd@gnu.org>
3364
3365 * nsterm.m: Declare a global (Bug#10694).
3366
d7f29f8e
EZ
33672012-02-04 Eli Zaretskii <eliz@gnu.org>
3368
cae07000
SM
3369 * w32.c (get_emacs_configuration_options):
3370 Include --enable-checking, if specified, in the return value.
d7f29f8e 3371
3b95a6f9
MR
33722012-02-04 Martin Rudalics <rudalics@gmx.at>
3373
3374 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3375 after rounding frame sizes. (Bug#9723)
3376
d6fa96a6
EZ
33772012-02-04 Eli Zaretskii <eliz@gnu.org>
3378
3379 * keyboard.c (adjust_point_for_property): Don't position point
3380 before BEGV. (Bug#10696)
3381
df0b2940
PE
33822012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Handle overflow when computing char display width (Bug#9496).
3385 * character.c (char_width): Return EMACS_INT, not int.
3386 (char_width, c_string_width): Check for overflow when
3387 computing the width; this is possible now that individual
3388 characters can have unbounded width. Problem introduced
3389 by merge from Emacs 23 on 2012-01-19.
3390
6bee44d6
MA
33912012-02-02 Michael Albinus <michael.albinus@gmx.de>
3392
3393 * dbusbind.c (Fdbus_register_method): Mention the return value
3394 :ignore in the docstring.
3395
44f92739
GM
33962012-02-02 Glenn Morris <rgm@gnu.org>
3397
1b9f60cc
GM
3398 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3399
44f92739
GM
3400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3401 Unconditionally set to t. (Bug#10673)
3402 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3403 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3404 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3405
c5d3843c
KH
34062012-02-02 Kenichi Handa <handa@m17n.org>
3407
3408 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3409 0, do not call append_composite_glyph.
3410
159462d4 34112012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3412
3413 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3414 NULL (Bug#6988).
3415 (x_produce_glyphs): If the component of a composition is a null
3416 string, set it->pixel_width to 1 to avoid zero-width glyph.
3417
78cef877
EZ
34182012-02-01 Eli Zaretskii <eliz@gnu.org>
3419
3420 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3421 first 2 arguments are identical. This makes inserting large
3422 output from a subprocess an order of magnitude faster on
3423 MS-Windows, where all sbrk'ed memory is always contiguous.
3424
97897668
GM
34252012-01-31 Glenn Morris <rgm@gnu.org>
3426
3427 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3428 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3429 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3430
31fd3586
GM
34312012-01-29 Glenn Morris <rgm@gnu.org>
3432
3433 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3434
0e24a8b2
CY
34352012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3436
3437 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3438
cc0adcb0
CY
34392012-01-28 Chong Yidong <cyd@gnu.org>
3440
3441 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3442
acc28cb9
CY
34432012-01-26 Chong Yidong <cyd@gnu.org>
3444
9c69cfb7
CY
3445 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3446
acc28cb9
CY
3447 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3448 repeat counts (Bug#10507).
3449
48da7392
GM
34502012-01-26 Glenn Morris <rgm@gnu.org>
3451
3452 * lread.c (syms_of_lread): Doc fix.
3453
14af5f7f
CY
34542012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3455
3456 * coding.c (encode_designation_at_bol): Change return value to
3457 EMACS_INT.
3458
0b21c100
CY
34592012-01-25 Chong Yidong <cyd@gnu.org>
3460
3461 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3462
3c2907f7
CY
34632012-01-21 Chong Yidong <cyd@gnu.org>
3464
3465 * floatfns.c (Fcopysign): Make the second argument non-optional,
3466 since nil is not allowed anyway.
3467
959ad23f
AS
34682012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3469
3470 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3471 (send_process): Likewise.
3472
34a02f46
MR
34732012-01-19 Martin Rudalics <rudalics@gmx.at>
3474
3475 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3476 (Vwindow_persistent_parameters): Do not use Qstate.
3477 Rewrite doc-strings.
34a02f46 3478
1259009a 34792012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3480
3481 * character.c (char_width): New function.
70d4fdf6
GM
3482 (Fchar_width, c_string_width, lisp_string_width):
3483 Use char_width (Bug#9496).
25ed9e61 3484
6a6ee00d
MR
34852012-01-16 Martin Rudalics <rudalics@gmx.at>
3486
3487 * window.c (Vwindow_persistent_parameters): New variable.
3488 (Fset_window_configuration, save_window_save): Handle persistent
3489 window parameters.
3490
c85efaf7
EZ
34912012-01-14 Eli Zaretskii <eliz@gnu.org>
3492
3493 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3494 thrashing the stack of the thread. (Bug#9087)
3495
5944709e
PE
34962012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3497
3498 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3499
e71f5d99
EZ
35002012-01-11 Eli Zaretskii <eliz@gnu.org>
3501
3502 * xdisp.c (rows_from_pos_range): Handle the case where the
3503 highlight ends on a newline. (Bug#10464)
3504 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3505 he end column for display of highlight that ends on a newline
3506 before a R2L line.
3507
ce316182
GM
35082012-01-11 Glenn Morris <rgm@gnu.org>
3509
3510 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3511 from load-path also when installation-directory is nil. (Bug#10208)
3512
5b43da69
GM
35132012-01-10 Glenn Morris <rgm@gnu.org>
3514
74cc8ff9
GM
3515 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3516
7d8d6e4e
GM
3517 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3518 Update template values to be closer to their typical values these days.
5b43da69 3519
a0db8d43
EZ
35202012-01-09 Eli Zaretskii <eliz@gnu.org>
3521
3522 * xdisp.c (rows_from_pos_range): Accept additional argument
3523 DISP_STRING, and accept any glyph in a row whose object is that
3524 string as eligible for mouse highlight. Fixes mouse highlight of
3525 display strings from overlays. (Bug#10464)
3526
9a0115ab 35272012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3528
b9110d6a 3529 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3530 * fileio.c (auto_saving_dir_umask): New static var.
3531 (Fmake_directory_internal): Use it.
3532 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3533 creating the directory. The old code temporarily assigns
3534 too-generous permissions to the directory.
3535 (do_auto_save_eh): Clear it.
b9110d6a 3536 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3537 that the var is always cleared.
3538
6c1bd3f3
EZ
35392012-01-07 Eli Zaretskii <eliz@gnu.org>
3540
3541 * search.c (scan_buffer): Pass character positions to
3542 know_region_cache, not byte positions. (Bug#6540)
3543
069d2b50
L
35442012-01-07 LynX <_LynX@bk.ru> (tiny change)
3545
3546 * w32.c (sys_rename): Report EXDEV when rename of a directory
3547 fails because the target is on another logical disk. (Bug#10284)
3548
75bf0d33
DB
35492012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3550
3551 * xterm.c (x_embed_request_focus): New function.
3552
3553 * xterm.h: Add prototype.
3554
3555 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3556
1c6e5a32
GM
35572012-01-05 Glenn Morris <rgm@gnu.org>
3558
3559 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3560
651e947e
EZ
35612012-01-01 Eli Zaretskii <eliz@gnu.org>
3562
3563 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3564 Load gnutls_transport_set_lowat only if GnuTLS version is below
3565 2.11.1.
3566 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3567 GnuTLS versions below 2.11.1.
3568
3778cdd8
AL
35692011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3570
3571 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3572 to the doc string advising against its use for altering the way
3573 windows are scrolled.
3574
0e5317f7
KH
35752011-12-28 Kenichi Handa <handa@m17n.org>
3576
3577 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3578 coding-system ASCII compatible only when it does not produce BOM
3579 on encoding (Bug#10383).
3580
93d5ca1f
JD
35812011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3582
3583 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3584 can scroll.
3585 (create_and_show_popup_menu): Always use menu_position_func for
3586 Gtk3 (Bug#10361).
3587
ca22b785
AS
35882011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3589
3590 * callint.c (Fcall_interactively): Don't truncate prompt string.
3591
d048e1e6
EZ
35922011-12-23 Eli Zaretskii <eliz@gnu.org>
3593
3594 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3595 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3596 resumed from there (after widening). (Bug#10360)
d048e1e6 3597
5ccaba1f
JD
35982011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3599
3600 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3601
204ee57f
JD
36022011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3603
b81d40f0
JB
3604 * nsterm.m (x_free_frame_resources):
3605 Release f->output_data.ns->miniimage.
204ee57f
JD
3606 (ns_index_color): Fix indentation. Do not retain
3607 color_table->colors[i].
3608
3609 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3610 before returning.
3611
3612 * nsfns.m (x_set_background_color): Assign return value from
3613 ns_index_color to face-background instead of NSColor*.
3614 (ns_implicitly_set_icon_type): Fix indentation.
3615 Change assignment in for loop to comparison.
3616
3617 * emacs.c (ns_pool): New variable.
3618 (main): Assign ns_pool.
3619 (Fkill_emacs): Call ns_release_autorelease_pool.
3620
3621 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3622 autorelease fdesc, release fdAttrs and tdict.
3623 (ns_get_covering_families): Release charset.
3624 (ns_findfonts): Release NSFontDescriptor created with new.
3625 (ns_uni_to_glyphs): Fix indentation.
3626 (setString): Release attrStr before assigning new value.
3627
c803b2b7
JD
36282011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3629
678f4426
JD
3630 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3631 and NS_IMPL_COCOA.
3632 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3633 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3634
cd394be1 36352011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3636
5fecd5fc
JD
3637 * nsterm.m (ns_term_init): Subscribe for notifications
3638 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3639 to method trackingNotification in EmacsMenu.
3640
3641 * nsmenu.m (trackingMenu): New variable.
3771cb17 3642 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3643 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3644 from Aquamacs (Bug#7030).
678f4426
JD
3645
36462011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3647
c803b2b7
JD
3648 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3649 (symbol_to_nsstring): Fix indentation.
3650 (ns_symbol_to_pb): New function.
cae07000
SM
3651 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3652 (Fns_rotate_cut_buffers_internal): Remove.
3653 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3654 Fns_store_cut_buffer_internal.
3655 (ns_get_foreign_selection, Fx_own_selection_internal)
3656 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3657 (Fns_get_selection_internal, Fns_store_selection_internal):
3658 Use ns_symbol_to_pb and check if return value is nil.
3659 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3660 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3661 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3662 renamed to Sns_store_selection_internal.
3663 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3664 and remove this function.
3665 (ns_handle_selection_clear): Remove, never used.
3666 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3667 here.
3668
e1b01a3a
KB
36692011-12-17 Ken Brown <kbrown@cornell.edu>
3670
3671 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3672 GID is unknown (Bug#10257).
3673
2adb6e85
PE
36742011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3675
3676 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3677 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3678 which caused a build failure on GNU/Linux IA-64. This problem was
3679 introduced by my 2011-10-07 patch.
3680
d1d7b339
JL
36812011-12-15 Juri Linkov <juri@jurta.org>
3682
3683 * image.c (imagemagick_error): New function. (Bug#10112)
3684 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3685 Use `imagemagick_error' where ImageMagick functions return
3686 `MagickFalse'.
3687 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3688 proper order.
3689
100d5755
KH
36902011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3691
3692 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3693 fill background (Bug#8992).
3694
454592a6
MR
36952011-12-13 Martin Rudalics <rudalics@gmx.at>
3696
3697 * window.c (Vwindow_combination_resize)
3698 (Vwindow_combination_limit): Use t instead of non-nil in
3699 doc-strings.
61d4b438
MR
3700 (Vrecenter_redisplay): Add first sentence of doc-string on
3701 separate line.
53524d93 3702 (Frecenter): Fix doc-string typo.
454592a6 3703
3633e3aa
KH
37042011-12-11 Kenichi Handa <handa@m17n.org>
3705
3706 * coding.c (Funencodable_char_position): Pay attention to the
3707 buffer text relocation (Bug#9389).
3708
7b9d523a 37092011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3710
7b9d523a
JD
3711 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3712 gtk_init (Bug#10100).
3713
b73189c6
EZ
37142011-12-10 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3717 IT->string is nil. (Bug#10263)
3718
f7dfe5d6
JD
37192011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3720
83faebb4
JD
3721 * nsterm.h (x_free_frame_resources): Declare.
3722
f7dfe5d6
JD
3723 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3724 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3725
3726 * nsterm.h (ns_get_defaults_value): Declare.
3727
3728 * nsterm.m (ns_default): Call ns_get_defaults_value.
3729
7cd4e72c
EZ
37302011-12-09 Eli Zaretskii <eliz@gnu.org>
3731
3732 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3733 (Bug#10170)
3734
b34d7317
YM
37352011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3736
3737 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3738 that where the value of an _OBJC_* symbol points to is in the .bss
3739 section (Bug#10240).
3740
76470ad1
KH
37412011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3742
3743 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3744 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3745
745fff94
KH
37462011-12-08 Kenichi Handa <handa@m17n.org>
3747
3748 * ftfont.c (get_adstyle_property): Fix previous change
3749 (Bug#10233).
3750
6e44397c
JB
37512011-12-07 Juanma Barranquero <lekktu@gmail.com>
3752
3753 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3754 dirs from the default value of EMACSLOADPATH (bug#10208).
3755
7efa6272
GM
37562011-12-07 Glenn Morris <rgm@gnu.org>
3757
3758 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3759 installation and source directories as well. (Bug#10208)
3760
f6fc4d87
CY
37612011-12-06 Chong Yidong <cyd@gnu.org>
3762
3763 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3764
2bf26180
GM
37652011-12-06 Glenn Morris <rgm@gnu.org>
3766
3767 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3768 as an error, not just -1. (Bug#10217)
3769
3a6ad4f0
CY
37702011-12-05 Chong Yidong <cyd@gnu.org>
3771
3772 * keyboard.c (process_special_events): New function.
3773 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3774
75a3b399
PE
37752011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3776
3777 * coding.c (encode_designation_at_bol): Don't use uninitialized
3778 local variable (Bug#9318).
3779
c3c9e25e
KH
37802011-12-05 Kenichi Handa <handa@m17n.org>
3781
3782 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3783 return Qnil (Bug#8046, Bug#10193).
3784
5eb05ea3
KH
37852011-12-05 Kenichi Handa <handa@m17n.org>
3786
3787 * coding.c (encode_designation_at_bol): New args charbuf_end and
3788 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3789 (coding_set_source): Return how many bytes coding->source was
3790 relocated.
3791 (coding_set_destination): Return how many bytes
3792 coding->destination was relocated.
3793 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3794 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3795
37962011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3797
3798 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3799 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3800 macro (Bug#9318).
3801
38022011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3803
3804 The following changes are to fix Bug#9318.
3805
a79703f5 3806 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3807 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3808 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3809 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3810
7dbda6df
JB
38112011-12-05 Juanma Barranquero <lekktu@gmail.com>
3812
3813 * lisp.h (process_quit_flag): Fix external declaration.
3814
6d5eb5b0
SM
38152011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3816
3817 Don't macro-inline non-performance-critical code.
3818 * eval.c (process_quit_flag): New function.
3819 * lisp.h (QUIT): Use it.
3820
a0c3fad0
JD
38212011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * nsfns.m (get_geometry_from_preferences): New function.
3824 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3825
6c07aac2
AS
38262011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3827
3828 * emacs.c (Qkill_emacs): Define.
3829 (syms_of_emacs): Initialize it.
3830 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3831 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3832 (quit_throw_to_read_char): Add parameter `from_signal'.
3833 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3834 * lisp.h (QUIT): Call Fkill_emacs if requested.
3835
c052ead4
JD
38362011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3837
3838 * widget.c (update_wm_hints): Return if wmshell is null.
3839 (widget_update_wm_size_hints): New function.
3840
3841 * widget.h (widget_update_wm_size_hints): Declare.
3842
3843 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3844 widget_update_wm_size_hints (Bug#10104).
3845
9e49252b
EZ
38462011-12-03 Eli Zaretskii <eliz@gnu.org>
3847
3848 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3849 before a newline, prepare the bidi iterator for consuming the
3850 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3851 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3852
02b16839
JL
38532011-12-02 Juri Linkov <juri@jurta.org>
3854
3855 * search.c (Fword_search_regexp): New Lisp function created from
3856 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3857 (Fword_search_backward, Fword_search_forward)
3858 (Fword_search_backward_lax, Fword_search_forward_lax):
3859 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3860 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3861
0068070e
SM
38622011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3863
3864 * fileio.c (Finsert_file_contents): Move after-change-function call
3865 to before the "handled:" label, since all "goto handled" appear in
3866 cases where the *-change-functions have already been properly called
3867 (bug#10117).
3868
3360a3fc
AS
38692011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3870
3871 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3872 waiting for input. (Bug#10169)
3873
73d6c093
EZ
38742011-11-30 Eli Zaretskii <eliz@gnu.org>
3875
3876 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3877 verifies glyph row's hash code--we have just reallocated the
3878 glyphs, so their contents can be complete garbage. (Bug#10164)
3879
febe6bea
JB
38802011-11-30 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3883
801a4313
EZ
38842011-11-30 Eli Zaretskii <eliz@gnu.org>
3885
3886 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3887 attributes are tested _before_ calling verify_row_hash, to protect
3888 against GCC re-ordering of the tests. (Bug#10164)
3889
2b56b87e
JD
38902011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3891
3892 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3893
3894 * xterm.c (handle_one_xevent): Only set async_visible and friends
3895 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3896 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3897 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3898
dbf31225
PE
38992011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3902 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3903 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3904 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3905 All uses changed to use GCPRO1 etc.
3906 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3907 Revert to old implementation (i.e., before 2011-03-11).
3908
1305621b
YM
39092011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3910
3911 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3912 of scroll runs so as to avoid assigning disabled bogus rows and
3913 unnecessary graphics copy operations.
3914
8c9afb46
EZ
39152011-11-27 Eli Zaretskii <eliz@gnu.org>
3916
3917 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3918 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3919 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3920 (malloc, free, realloc, calloc): Redirect to e_* only when
3921 compiling Emacs.
3922
3923 * lisp.h (GCTYPEBITS): Move before first use.
3924 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3925 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3926 this macro definition.
3927
3928 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3929 _MSC_VER.
3930
54e9e3bf
JD
39312011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3932
6d5eb5b0
SM
3933 * gtkutil.c (xg_create_frame_widgets):
3934 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3935 present with Gtk+ 2.0.
3936
83aca1cb
PE
39372011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3938
3939 * fileio.c (Finsert_file_contents): Undo previous change; see
3940 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3941
5b76caa4
PE
39422011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3943
3944 Rename locals to avoid shadowing.
3945 * fileio.c (Finsert_file_contents):
3946 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3947 * process.c (wait_reading_process_output):
3948 Rename inner 'proc' to 'p' to avoid shadowing.
3949 Indent for consistency with usual Emacs style.
3950
8c535114
EZ
39512011-11-25 Eli Zaretskii <eliz@gnu.org>
3952
3953 * xdisp.c (redisplay_window): If cursor row is not fully visible
3954 after recentering, and scroll-conservatively is set to a large
3955 number, scroll window by a few more lines to make the cursor fully
3956 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3957 (start_display): Don't move to the next line if the display should
3958 start at a newline that is part of a display vector or an overlay
3959 string. (Bug#10119)
8c535114 3960
fa4fdb5c
JL
39612011-11-24 Juri Linkov <juri@jurta.org>
3962
3963 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3964 after the `MagickPingImage' call. (Bug#10112)
3965
90ec88df
CY
39662011-11-23 Chong Yidong <cyd@gnu.org>
3967
3968 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3969
56e2e794
MR
39702011-11-23 Martin Rudalics <rudalics@gmx.at>
3971
3972 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3973 making another buffer current. (Bug#10114)
3974
b6e64c41
GM
39752011-11-23 Glenn Morris <rgm@gnu.org>
3976
3977 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3978
6b21de18
CY
39792011-11-23 Chong Yidong <cyd@gnu.org>
3980
3981 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3982 using it (Bug#5984).
3983
b12cd789
EZ
39842011-11-22 Eli Zaretskii <eliz@gnu.org>
3985
3986 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3987 and header-lines, as they don't have one computed for them.
3988 (Bug#10098)
3989
3990 * .gdbinit (prow): Make displayed values more self-explaining.
3991 Add row's hash code.
3992
261b6fd4
LMI
39932011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3994
3995 * process.c (wait_reading_process_output): Fix asynchrounous
3996 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3997 (wait_reading_process_output): Add comment and URL.
261b6fd4 3998
e7cfd277
JD
39992011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4000
4001 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4002
a9b9b7f5
CY
40032011-11-21 Chong Yidong <cyd@gnu.org>
4004
4005 * window.c (Fnext_window, Fprevious_window): Doc fix.
4006
b0d15b4f
SM
40072011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4008
4009 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4010
fe7a3057
JB
40112011-11-20 Juanma Barranquero <lekktu@gmail.com>
4012
4013 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4014
d2999b1a
MR
40152011-11-20 Martin Rudalics <rudalics@gmx.at>
4016
4017 * window.c (Fset_window_combination_limit): Rename argument
4018 STATUS to LIMIT.
4019 (Vwindow_combination_limit): Remove "status" from doc-string.
4020
d5ff9cd0
AS
40212011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4022
4023 * m/ibms390.h: Remove.
4024 * m/ibms390x.h: Don't include "ibms390.h".
4025
a5bb9bd3
SM
40262011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4027
4028 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4029 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4030
cd1181db
JB
40312011-11-20 Juanma Barranquero <lekktu@gmail.com>
4032
4033 * casetab.c (Fset_case_table):
4034 * charset.c (Fcharset_after): Fix typos.
4035
615a3b8d 40362011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4037
17e845af
PE
4038 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4039 Otherwise, valgrind does not work on some platforms.
4040 Problem reported by Andreas Schwab in
6a0bf43d
PE
4041 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4042 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4043 is set, removing the need for VIRT_ADDRESS_VARIES.
4044 (PURE_P): Use a more-efficient implementation that needs just one
4045 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4046 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4047 to 4 (xorl, subq, cmpq, setbe).
4048 * alloc.c (pure): Always extern now, since that's the
4049 VIRT_ADDR_VARIES behavior.
4050 (PURE_POINTER_P): Use a single comparison, not two, for
4051 consistency with the new puresize.h.
4052 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4053 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4054 Remove VIRT_ADDR_VARIES no longer needed.
4055
f8fe6f96
EZ
40562011-11-19 Eli Zaretskii <eliz@gnu.org>
4057
4058 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4059 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4060 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4061 behave as if the cursor position were at the window margin.
4062
4063 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4064 and the cursor position is out of bounds, behave as if the cursor
4065 position were at the window margin. (Bug#10075)
4066
df05a53c
CY
40672011-11-18 Chong Yidong <cyd@gnu.org>
4068
4069 * window.c (Fwindow_combination_limit): Make first argument
4070 non-optional, since it is meaningless for live windows like the
4071 selected window.
61ccba97 4072
2071918e
DA
40732011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4074
4075 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4076
b50a28de
SM
40772011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4078
4079 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4080 (graft_intervals_into_buffer): Simplify.
4081
015137db
EZ
40822011-11-18 Eli Zaretskii <eliz@gnu.org>
4083
4084 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4085 hash values of the two rows.
4086 (copy_row_except_pointers): Preserve the used[] arrays and the
4087 hash values of the two rows. (Bug#10035)
68c95424 4088 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4089
4090 * xdisp.c (row_hash): New function, body extracted from
4091 compute_line_metrics.
4092 (compute_line_metrics): Call row_hash, instead of computing the
4093 hash code inline.
4094
4095 * dispnew.c (verify_row_hash): Call row_hash for computing the
4096 hash code of a row, instead of duplicating code from xdisp.c.
4097
4098 * dispextern.h (row_hash): Add prototype.
4099
a2addb04
TH
41002011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4101
4102 * frame.c (delete_frame): Don't delete the terminal when the last
4103 X frame is closed if emacs is built with GTK toolkit.
4104
df85d315
JB
41052011-11-17 Juanma Barranquero <lekktu@gmail.com>
4106
4107 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4108
a0c2d0ae
MR
41092011-11-17 Martin Rudalics <rudalics@gmx.at>
4110
4111 * window.c (Vwindow_splits): Rename to
4112 Vwindow_combination_resize. Suggested by Juri Linkov.
4113 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4114 of Vwindow_splits.
4115
58179cce
JB
41162011-11-16 Juanma Barranquero <lekktu@gmail.com>
4117
7877f373
JB
4118 * nsfns.m (Fns_font_name):
4119 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4120
b6f67890
MR
41212011-11-16 Martin Rudalics <rudalics@gmx.at>
4122
4123 * window.h (window): Rename slot "nest" to "combination_limit".
4124 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4125 (Fset_window_nest): Rename to Fset_window_combination_limit.
4126 (Vwindow_nest): Rename to Vwindow_combination_limit.
4127 (recombine_windows, make_parent_window, make_window)
4128 (Fsplit_window_internal, saved_window)
4129 (Fset_window_configuration, save_window_save): Rename all
4130 occurrences of window_nest to window_combination_limit.
4131
c7015153
JB
41322011-11-15 Juanma Barranquero <lekktu@gmail.com>
4133
4134 * image.c (imagemagick_load_image): Fix typo.
4135
322ad6ec
EZ
41362011-11-14 Eli Zaretskii <eliz@gnu.org>
4137
4138 * xdisp.c (display_line): Move the call to
4139 highlight_trailing_whitespace before the call to
4140 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4141 faces of all the glyphs to compute ROW's hash value.
4142 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4143
f067b8ec
JB
41442011-11-14 Juanma Barranquero <lekktu@gmail.com>
4145
4146 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4147 just return (bug#10044).
4148
1e5b2111
EZ
41492011-11-12 Eli Zaretskii <eliz@gnu.org>
4150
7ef3cbd5
EZ
4151 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4152 with user-defined heap size. Bump the default size of the temacs
4153 heap to 27MB, to avoid memory warning when running temacs.
4154 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4155
1e5b2111
EZ
4156 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4157 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4158 (verify_row_hash) [XASSERTS]: New function.
4159 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4160 that the hash value of glyph rows is correct.
1e5b2111 4161
89d61221
MR
41622011-11-12 Martin Rudalics <rudalics@gmx.at>
4163
4164 * window.h (window): Remove splits slot.
4165 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4166 (Fdelete_other_windows_internal, make_parent_window)
4167 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4168 (Fset_window_configuration, save_window_save): Don't deal with
4169 split status of windows.
4170 (saved_window): Remove splits slot.
4171 (Vwindow_splits): Rewrite doc-string.
4172
97f18cc8
JD
41732011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4174
4175 * xfns.c (unwind_create_frame):
4176 * nsfns.m (unwind_create_frame):
4177 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4178 Vframe_list (Bug#9999).
4179
22a648b4
DA
41802011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4181
0b381c7e 4182 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4183
659afede
KH
41842011-11-11 Kenichi Handa <handa@m17n.org>
4185
4186 * callproc.c (Fcall_process): Set the member dst_multibyte of
4187 process_coding.
4188
9ac0394b
KH
41892011-11-11 Johan Bockgård <bojohan@gnu.org>
4190
4191 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4192 avoid a crash (bug#9496).
4193
2fbdc249
CY
41942011-11-09 Chong Yidong <cyd@gnu.org>
4195
4196 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4197 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4198
ac6b1f81
PE
41992011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4200
4201 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4202
09db192c
PE
42032011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4204
4205 Avoid some portability problems by eschewing 'extern inline' functions.
4206 The trivial performance wins aren't worth the portability hassles; see
4207 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4208 et seq.
4209 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4210 (window_box_width, window_box_left, window_box_left_offset)
4211 (window_box_right, window_box_right_offset): Undo previous change,
4212 by removing the "extern"s.
4213 * intervals.c (adjust_intervals_for_insertion)
4214 (adjust_intervals_for_deletion): Undo previous change,
4215 making these static again.
4216 (offset_intervals, temp_set_point_both, temp_set_point)
4217 (copy_intervals_to_string): No longer inline.
4218 * xdisp.c (window_text_bottom_y, window_box_width)
4219 (window_box_height, window_box_left_offset)
4220 (window_box_right_offset, window_box_left, window_box_right)
4221 (window_box): No longer inline.
4222
105216ed
CY
42232011-11-08 Chong Yidong <cyd@gnu.org>
4224
4225 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4226 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4227 Signal an error if not a live window.
105216ed
CY
4228 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4229 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4230
ae9e237f
JB
42312011-11-07 Juanma Barranquero <lekktu@gmail.com>
4232
4233 * lisp.h (syms_of_abbrev): Remove declaration.
4234 Reported by CHENG Gao <chenggao@royau.me>.
4235
c7aa8333
EZ
42362011-11-07 Eli Zaretskii <eliz@gnu.org>
4237
4238 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4239 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4240 of temacs in GUI mode.
4241
be7f5545
MR
42422011-11-07 Martin Rudalics <rudalics@gmx.at>
4243
4244 * window.h: Declare delete_all_child_windows instead of
4245 delete_all_subwindows.
4246 * window.c (Fwindow_nest, Fset_window_nest)
4247 (Fset_window_new_total, Fset_window_new_normal)
4248 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4249 (delete_all_subwindows): Rename to delete_all_child_windows.
4250 (Fdelete_other_windows_internal, Fset_window_configuration):
4251 Call delete_all_child_windows instead of delete_all_subwindows.
4252 * frame.c (delete_frame): Call delete_all_child_windows instead
4253 of delete_all_subwindows.
4254
ca78dc43
PE
42552011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4256
4257 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4258 This is also needed for porting to any host where GC_MARK_STACK is
4259 not GC_MAKE_GCPROS_NOOPS.
4260 (which_symbols): Use it.
4261
a0241d01
KH
42622011-11-07 Kenichi Handa <handa@m17n.org>
4263
4264 * coding.c (coding_set_destination): Check coding->src_pos only
4265 when coding->src_object is a buffer (bug#9910).
4266
4267 * process.c (send_process): Set the member src_multibyte of coding
4268 to 0 (bug#9911) when sending a unibyte text.
4269
4270 * callproc.c (Fcall_process): Set the member src_multibyte of
4271 process_coding to 0 (bug#9912).
4272
a64bfdfa 42732011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4274
4275 * xmenu.c (cleanup_widget_value_tree): New function.
4276 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4277 calling free_menubar_widget_value_tree directly (Bug#9830).
4278
cb41b32a
PE
42792011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4280
4281 Fix some portability problems with 'inline'.
4282 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4283 (window_box_width, window_box_left, window_box_left_offset)
4284 (window_box_right, window_box_right_offset): Declare extern.
4285 Otherwise, these inline functions do not conform to C99 and
4286 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4287 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4288 * intervals.c (adjust_intervals_for_insertion)
4289 (adjust_intervals_for_deletion): Now extern, because otherwise the
4290 extern inline functions 'offset_intervals' couldn't refer to it.
4291 (static_offset_intervals): Remove.
4292 (offset_intervals): Rewrite using the old contents of
4293 static_offset_intervals. The old version didn't conform to C99
4294 because an extern inline function contained a reference to an
4295 identifier with static linkage.
4296
b7041366
AS
42972011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4298
4299 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4300 GC.
4301
88a37c4d
EZ
43022011-11-06 Eli Zaretskii <eliz@gnu.org>
4303
4304 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4305 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4306 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4307 return Qleft_to_right.
4308
49745b39
CY
43092011-11-06 Chong Yidong <cyd@gnu.org>
4310
4311 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4312 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4313 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4314 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4315 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4316 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4317 (Fwindow_vscroll): Doc fix.
4318 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4319 argument, since it makes no sense to pass a live window and for
4320 consistency with window-child.
4321
1f05cd82
CS
43222011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4323
4324 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4325 support MSVC.
4326
22610910
JR
43272011-11-05 Jason Rumney <jasonr@gnu.org>
4328
4329 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4330 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4331 fonts (Bug#6029).
4332 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4333 bitwise arithmetic preventing use of unicode-sip and non-truetype
4334 opentype fonts.
4335
a06776b2
EZ
43362011-11-05 Eli Zaretskii <eliz@gnu.org>
4337
3ad924ba
EZ
4338 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4339 "emacs"-only part.
4340
a06776b2
EZ
4341 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4342 initialization code to keep similarity to xfns.c after changes
4343 from 2011-11-05.
4344
c9e7db78
JD
43452011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4346
a97f8f3f
JD
4347 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4348 (unwind_create_frame): New function (Bug#9943).
4349 (Fx_create_frame): Restructure code to be more similar to the one in
4350 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4351 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4352 Move terminal->reference_count++ just before making the frame official
4353 (Bug#9943).
4354
4355 * nsterm.m (x_free_frame_resources): New function.
4356 (x_destroy_window): Move code to x_free_frame_resources.
4357
c9e7db78 4358 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4359 (Fx_create_frame, x_create_tip_frame):
4360 Move terminal->reference_count++ just before making the frame
75f1671a 4361 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4362 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4363
a6fc3b5c
EZ
43642011-11-05 Eli Zaretskii <eliz@gnu.org>
4365
4366 Support MSVC build with newer versions of Visual Studio.
4367 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4368 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4369 nt/gmake.defs.
4370
4371 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4372 which are not supported by MSVC.
4373 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4374 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4375 bitfields.
4376 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4377 types in bitfields.
4378 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4379
4380 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4381
58179cce 43822011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4383
4384 Support MSVC build with newer versions of Visual Studio.
4385 * w32.c: Don't include w32api.h for MSVC.
4386 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4387
4388 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4389 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4390 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4391 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4392 e_* cousins.
4393 (alloca) [_MSC_VER]: Define to _alloca.
4394
4395 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4396
4397 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4398
a58c13ed
EZ
43992011-11-04 Eli Zaretskii <eliz@gnu.org>
4400
4401 * xdisp.c (note_mouse_highlight): If either of
4402 previous/next-single-property-change returns nil, treat that as
4403 the beginning or the end of the buffer. (Bug#9955)
4404
fe0b6370
JD
44052011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4406
a58c13ed 4407 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4408 label is not null (Bug#9951).
4409 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4410 may be NULL.
4411
89bd5ee1
EZ
44122011-11-04 Eli Zaretskii <eliz@gnu.org>
4413
4414 * window.c (Fwindow_body_size): Mention in the doc string that the
4415 return value is in frame's canonical units. (Bug#9949)
4416
84c3edb9
EZ
44172011-11-03 Eli Zaretskii <eliz@gnu.org>
4418
4e2fb5c7
EZ
4419 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4420
84c3edb9 4421 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4422 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4423 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4424
bc17a887
EZ
44252011-11-01 Eli Zaretskii <eliz@gnu.org>
4426
4427 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4428 Don't stop backward scan on the continuation glyph, even though
4429 its CHARPOS is positive.
6d5eb5b0
SM
4430 (mouse_face_from_buffer_pos, note_mouse_highlight):
4431 Rename cover_string to disp_string.
bc17a887 4432
4ee88440
MR
44332011-11-01 Martin Rudalics <rudalics@gmx.at>
4434
4435 * window.c (temp_output_buffer_show): Don't use
4436 Vtemp_buffer_show_specifiers.
4437 (Vtemp_buffer_show_specifiers): Remove unused variable.
4438
c2ff3c02
EZ
44392011-10-30 Eli Zaretskii <eliz@gnu.org>
4440
4441 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4442 past the beginning of the current glyph matrix.
4443
58179cce 44442011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4445
4446 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4447 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4448 HAVE_GTK3 (Bug#9869).
b77a6a7f 4449
3b574623
JD
4450 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4451 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4452
b77a6a7f
JD
4453 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4454
4455 * xterm.c: Declare x_handle_net_wm_state to return int.
4456 (handle_one_xevent): Check if we are iconified but don't have
4457 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4458 (get_current_wm_state): Return non-zero if not hidden,
4459 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4460 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4461 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4462 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4463
196e41e4
PE
44642011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4465
4466 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4467 so that this new function doesn't get optimized away by a
4468 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4469
021f2e1a
AS
44702011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4471
4472 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4473
8b058d44
EZ
44742011-10-29 Eli Zaretskii <eliz@gnu.org>
4475
4476 Fix the `xbytecode' command.
4477 * .gdbinit (xprintbytestr): New command.
b50a28de 4478 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4479 (xbytecode): Print the byte-code string as well.
4480
4452fb80
EZ
44812011-10-29 Kim Storm <storm@cua.dk>
4482
8b058d44
EZ
4483 * alloc.c (which_symbols): New function.
4484
21b72067
AS
44852011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4486
4487 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4488 line. (Bug#9903)
4489
83ed7b5c
GM
44902011-10-29 Glenn Morris <rgm@gnu.org>
4491
4492 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4493 Not clear what it was for, and it causes various bugs. (Bug#9839)
4494
5a7a728b
EZ
44952011-10-28 Eli Zaretskii <eliz@gnu.org>
4496
4497 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4498 possible random value that matches one of those tested as
4499 condition to clear the mouse face.
4500
d3d0842f
CY
45012011-10-28 Chong Yidong <cyd@gnu.org>
4502
4503 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4504
31b39d13
DN
45052011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4506
4507 * window.c (make_window): Initialize phys_cursor_on_p.
4508
9aba6043
SM
45092011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4510
4511 * lisp.h (struct Lisp_Symbol): Update comments.
4512
c20992f4
JB
45132011-10-28 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4516
db4f02f2
EZ
45172011-10-28 Eli Zaretskii <eliz@gnu.org>
4518
4519 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4520 <oslsachem@gmail.com> for helping to debug this.
4521
4522 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4523 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4524 (g_b_init_get_glyph_outline_w): New static variables.
4525 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4526 (GetGlyphOutlineW_Proc): New typedefs.
4527 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4528 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4529 New functions.
4530 (w32font_open_internal, compute_metrics):
4531 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4532 instead of calling the "wide" APIs directly.
4533
4534 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4535
4536 * w32.h (syms_of_w32font): Add prototype.
4537
87e68db4
JB
45382011-10-27 Juanma Barranquero <lekktu@gmail.com>
4539
4540 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4541 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4542 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4543 (Fmove_to_window_line): Doc fix.
4544
435c1d67
CY
45452011-10-27 Chong Yidong <cyd@gnu.org>
4546
4547 * process.c (make_process): Set gnutls_state to NULL.
4548
4549 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4550 non-NULL, regardless of GNUTLS_INITSTAGE.
4551 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4552 an error. Set process slots as soon as we allocate them.
4553
4554 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4555
9c6c6f49
CY
45562011-10-27 Chong Yidong <cyd@gnu.org>
4557
9aba6043
SM
4558 * gnutls.c (emacs_gnutls_deinit): New function.
4559 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4560 (Fgnutls_deinit, Fgnutls_boot): Use it.
4561
4562 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4563 (deactivate_process): Call emacs_gnutls_deinit.
4564
657d08d3
JB
45652011-10-27 Juanma Barranquero <lekktu@gmail.com>
4566
4567 * image.c (x_create_x_image_and_pixmap):
4568 * w32.c (sys_rename, w32_delayed_load):
4569 * w32font.c (fill_in_logfont):
4570 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4571
5430d399
JB
45722011-10-26 Juanma Barranquero <lekktu@gmail.com>
4573
4574 * w32fns.c (w32_default_color_map): New function,
4575 extracted from Fw32_default_color_map.
a7ef684b 4576 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4577
fe0055fa
PE
45782011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4579
4580 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4581
e6346438
SM
45822011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4583
4584 * keyboard.c (test_undefined): New function (bug#9751).
4585 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4586
e112cc37
ET
45872011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4588
4589 * sysdep.c (init_sys_modes): Fix the check for the controlling
4590 terminal (Bug#6649).
4591
7b5d6677
EZ
45922011-10-20 Eli Zaretskii <eliz@gnu.org>
4593
4594 * dispextern.h (struct bidi_it): New member next_en_type.
4595
4596 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4597 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4598 current character, check also for next_en_type being WEAK_EN.
4599 (bidi_resolve_weak): Don't enter the expensive loop if the current
4600 position is before next_en_pos. Record the bidi type of the first
4601 non-ET, non-BN character we find, in addition to its position.
4602 (bidi_level_of_next_char): Invalidate next_en_type when
4603 next_en_pos is over-stepped.
4604
7da0b018
PE
46052011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4606
4607 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4608 * editfns.c: Rewrite current-time-zone so that it invokes
4609 the equivalent of (format-time-string "%Z") to get the time zone name.
4610 This fixes a bug when the time zone name contains characters that
4611 need converting from the system time locale to Emacs internal format.
4612 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4613 that patch fixed format-time-string to do the conversion, but
4614 I forgot to fix current-time-zone.
4615 (format_time_string): New function, containing most of
4616 what Fformat_time_string used to contain.
4617 (Fformat_time_string): Rewrite in terms of format_time_string.
4618 This doesn't change this function's behavior.
4619 (current-time-zone): Rewrite to use format_time_string.
4620 This fixes the bug reported by Michael Schierl in
4621 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4622 Jason Rumney's 2007-06-07 change worked around this bug, but
4623 didn't fix it.
4624 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4625
8547b010
EZ
46262011-10-19 Eli Zaretskii <eliz@gnu.org>
4627
4628 * xdisp.c (start_display): If the character at POS is displayed
4629 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4630 (try_window_reusing_current_matrix): If a line ends in a display
4631 vector or the next line starts in a display vector, continue
4632 redrawing the window even though the character position of
4633 start_row was reached.
8547b010
EZ
4634 (Bug#9771, part 2)
4635
4e948d15
CY
46362011-10-18 Chong Yidong <cyd@gnu.org>
4637
4638 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4639 with nobreak-char-display too.
4640
4787455f
EZ
46412011-10-18 Eli Zaretskii <eliz@gnu.org>
4642
4643 Fix part 3 of bug#9771.
4644 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4645 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4646 non-neutral characters if the current character is a paragraph
4647 separator (a.k.a. Newline). This avoids running the same
4648 expensive loop twice, once when we consume the preceding newline
4649 and the other time when the line actually needs to be displayed.
4650 Avoid the loop when we see neutrals on the base embedding level
4651 following a character whose directionality is the same as the
4652 paragraph's. This avoids running the expensive loop when a line
4653 ends in a long sequence of neutrals, like control characters.
4654 Add assertion against STRONG_AL type. Slightly rearrange code
4655 that determines the type of a neutral given the first non-neutral
4656 that follows it.
4657 (bidi_level_of_next_char): Set next_en_pos to zero when
4658 invalidating its info.
4659
2c91f553
EZ
46602011-10-17 Eli Zaretskii <eliz@gnu.org>
4661
4662 * xdisp.c (push_display_prop): Determine whether to record string
4663 or buffer position by IT->string, not by IT->method. Allow
4664 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4665 (move_it_vertically_backward): Don't look for character position
4666 immediately after the newline when in a continuation line.
4667 (Bug#9771, part 1)
2c91f553 4668
c7b08b0d
MR
46692011-10-15 Martin Rudalics <rudalics@gmx.at>
4670
4671 * window.c (coordinates_in_window): Rewrite and delabelize
4672 vertical border check. (Bug#5357) (Bug#9618)
4673
6b02f655
SM
46742011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4675
4676 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4677 errors in XSetWindowBorder (bug#9310).
4678
81d40c92
DA
46792011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4680
4681 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4682 avoid crash when xmalloc overrun checking is enabled.
4683
d4172c3b
EZ
46842011-10-13 Eli Zaretskii <eliz@gnu.org>
4685
4686 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4687 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4688 cursor motion with <left> and <right> arrow keys.
4689
4690 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4691 some callers set that themselves.
4692
b00eea75
EZ
46932011-10-12 Eli Zaretskii <eliz@gnu.org>
4694
4695 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4696 display string and the previous row comes from the same string and
4697 is empty. (Bug#9739) (Bug#9738)
4698
8fe012c4
SM
46992011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4700
4701 * doc.c (get_doc_string): Encode file name (bug#9735).
4702
0074aef2
EZ
47032011-10-12 Eli Zaretskii <eliz@gnu.org>
4704
79beb178
EZ
4705 * bidi.c (bidi_level_of_next_char):
4706 * xdisp.c (get_visually_first_element): Remove old incorrect
4707 comments regarding the Unicode Line Separator character.
4708
0074aef2
EZ
4709 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4710
6e4b3fbe
DA
47112011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4712
4713 * alloc.c (Fgc_status): Do not access beyond zombies array
4714 boundary if nzombies > MAX_ZOMBIES.
4715 * alloc.c (dump_zombies): Add missing format specifier.
4716
0324f3af
PE
47172011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4718
b5525cac
PE
4719 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4720 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4721
0324f3af
PE
4722 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4723 Some packages use them to denote characters with modifiers.
4724
e9b5f888
AS
47252011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4726
4727 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4728 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4729 matching a pp-number. Rename parameter var to var1.
4730
127827c0
SM
47312011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4732
4733 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4734
c8fd3bd0
GM
47352011-10-08 Glenn Morris <rgm@gnu.org>
4736
4737 * callint.c (Fcall_interactively): Give a more explicit error for the
4738 'c' case with a non-character input. (Bug#8479)
4739
352ec8ff
EZ
47402011-10-08 Eli Zaretskii <eliz@gnu.org>
4741
03669ccb
EZ
4742 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4743 lines.
7061c986
EZ
4744 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4745 lines that are hscrolled on the left.
03669ccb 4746
352ec8ff
EZ
4747 * dispnew.c (buffer_posn_from_coords): Account for a possible
4748 presence of header-line. (Bug#4426)
4749
a66cfb1c
SM
47502011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4751
6b02f655
SM
4752 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4753 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4754
7c5ee88e
PE
47552011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4756
4757 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4758 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4759 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4760 this makes Emacs dump core during garbage collection on rare
4761 occasions. sizeof is obviously inferior to offsetof here, so
4762 stick with offsetof.
4763 (GC_POINTER_ALIGNMENT): New macro.
4764 (mark_memory): Omit 3rd (offset) arg; caller changed.
4765 Don't assume EMACS_INT alignment is the same as pointer alignment.
4766
df1bbe5b
SM
47672011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4768
4769 * keyboard.c (read_key_sequence_remapped): New var.
4770 (read_key_sequence): Compute remapping in the right buffer.
4771 (command_loop_1): Use read_key_sequence's remapping directly.
4772
51553db6
SM
47732011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4774
32c1fffd
SM
4775 * dired.c (file_name_completion): Don't expand file name.
4776 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4777 before checking file name handler.
4778
51553db6
SM
4779 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4780 they've been requested explicitly (bug#9591).
4781
b6bd1599 47822011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4783
4784 * keymap.c (Fsingle_key_description): Use make_specified_string
4785 instead of build_string to build string from push_key_description.
4786 (Bug#5193)
4787
f701dc2a
PE
47882011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4789
4222c55d
PE
4790 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4791 This fixes a Y2038 bug on 64-bit hosts.
4792 * buffer.c (reset_buffer):
4793 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4794 (Fclear_buffer_auto_save_failure):
4795 Use 0, not -1, to represent an unset failure time, since time_t
4796 might not be signed.
4797
f701dc2a
PE
4798 Remove dependency on glibc malloc internals.
4799 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4800 Move back here from lisp.h, but with their new implementations.
4801 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4802 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4803 * charset.c (charset_table_init): New static var.
4804 (syms_of_charset): Use it instead of xmalloc. This removes a
4805 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4806 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4807 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4808 Move back to alloc.c.
4809 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4810 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4811
9ceebf39
JD
48122011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4813
4814 * nsterm.m (windowDidResize): Call x_set_window_size only when
4815 ns_in_resize is true. Otherwise set pixelwidth/height and
4816 call change_frame_size (Bug#9628).
4817
cb993c58
PE
48182011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4819
3930c88b
PE
4820 Port --enable-checking=all to Fedora 14 x86-64.
4821 * charset.c (syms_of_charset): Also account for glibc malloc's
4822 internal overhead when calculating the initial malloc maximum.
4823
cb993c58
PE
4824 Port --enable-checking=all to Fedora 14 x86.
4825 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4826 Move to lisp.h.
4827 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4828 (overrun_check_realloc, overrun_check_free):
4829 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4830 That way, xmalloc returns a properly-aligned pointer even if
4831 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4832 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4833 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4834 into account when calculating the initial malloc maximum.
4835 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4836 Move here from alloc.c, so that charset.c can use it too.
4837 Properly align; the old code wasn't right for common 32-bit hosts
4838 when configured with --enable-checking=all.
4839 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4840 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4841
31bed486
EZ
48422011-09-29 Eli Zaretskii <eliz@gnu.org>
4843
04c70788 4844 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4845 use EDOM.
4846
fbcaa2f3
EZ
48472011-09-28 Eli Zaretskii <eliz@gnu.org>
4848
4849 * xdisp.c (compute_display_string_end): If there's no display
4850 string at CHARPOS, return -1.
4851
4852 * bidi.c (bidi_fetch_char): When compute_display_string_end
4853 returns a negative value, treat the character as a normal
4854 character not covered by a display string. (Bug#9624)
4855
a239d4e9
JB
48562011-09-28 Juanma Barranquero <lekktu@gmail.com>
4857
4858 * lread.c (Fread_from_string): Fix typo in docstring.
4859
88652fd5
EZ
48602011-09-27 Eli Zaretskii <eliz@gnu.org>
4861
4862 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4863 newline, reseat the iterator instead of bidi-iterating there one
4864 character at a time. (Bug#9610)
32c1fffd
SM
4865 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4866 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4867
ed497dd4
AS
48682011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4869
4870 * lread.c (readevalloop): Use correct code for NBSP.
4871 (read1): Likewise. (Bug#9608)
4872
b2bf61aa
MA
48732011-09-25 Michael Albinus <michael.albinus@gmx.de>
4874
4875 * dbusbind.c (Fdbus_register_signal): When service is not
4876 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4877
32bbb17c
GM
48782011-09-25 Glenn Morris <rgm@gnu.org>
4879
4880 * buffer.c (truncate-lines): Doc fix.
4881
94e0933e
CY
48822011-09-24 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4885 (Fset_window_next_buffers): Doc fix.
4886
cddde921
GM
48872011-09-24 Glenn Morris <rgm@gnu.org>
4888
4889 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4890
1260aef1
PE
48912011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4892
25b4bfa0
PE
4893 Fix minor problems found by static checking.
4894 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4895 * indent.c (Fvertical_motion): Fix == vs = typo.
4896
e3cbd34b
EZ
48972011-09-24 Eli Zaretskii <eliz@gnu.org>
4898
a66cfb1c
SM
4899 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4900 Default value is now t. Doc fix.
6bf7006f 4901
e3cbd34b 4902 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4903 logic when moving up, not only when moving down. Fix the
e3cbd34b 4904 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4905 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4906
4907 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4908 CHARPOS is covered by a display string which includes newlines.
4909 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4910 is covered by a display string with embedded newlines.
4911
a3de0cbd
MA
49122011-09-24 Michael Albinus <michael.albinus@gmx.de>
4913
4914 * dbusbind.c (Fdbus_register_signal): Add match rule to
4915 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4916 (Fdbus_register_method, Vdbus_registered_objects_table):
4917 Fix docstring.
a3de0cbd 4918
b260039d
JM
49192011-09-24 Jim Meyering <meyering@redhat.com>
4920
32c1fffd 4921 do not ignore write error for any output size
b260039d
JM
4922 The previous change was incomplete.
4923 While it makes emacs --batch detect the vast majority of stdout
4924 write failures, errors were still ignored whenever the output size is
4925 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4926 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4927 && echo FAIL: ignored write error
4928 FAIL: ignored write error
4929 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4930 && echo FAIL: ignored write error
4931 FAIL: ignored write error
4932 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4933
8eca8a7c
AS
49342011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4935
4936 * emacs.c (Fkill_emacs): In noninteractive mode exit
4937 non-successfully if a write error occurred on stdout. (Bug#9574)
4938
3341db62
EZ
49392011-09-21 Eli Zaretskii <eliz@gnu.org>
4940
4941 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4942 the xassert test.
4943
4944 * dispextern.h (struct it): Update the comment documenting what
4945 can it->OBJECT be.
4946
8c203dbf
EZ
49472011-09-20 Eli Zaretskii <eliz@gnu.org>
4948
4949 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4950 a display string, extend search for cursor position to end of row.
4951 (find_row_edges): If the row ends in a newline from a display
4952 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4953 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4954 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4955 non-empty line. Fixes confusing cursor motion with arrow keys at
4956 the beginning of a line that starts with whitespace.
8c203dbf 4957
a4824228
LMI
49582011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4959
4960 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4961 (bug#9493).
4962
33ed493b
CY
49632011-09-18 Chong Yidong <cyd@stupidchicken.com>
4964
4965 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4966 boolean (Bug#9154).
4967
56cd55c8
EZ
49682011-09-18 Eli Zaretskii <eliz@gnu.org>
4969
4970 * xdisp.c (display_line): Record maximum and minimum buffer
4971 positions even if no glyphs were produced (e.g., by a zero-width
4972 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4973 buffer positions that will be removed from the glyph row because
4974 they don't fit.
c02dcedf
EZ
4975 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4976 column is beyond frame width: don't subtract 1 "pixel" when
4977 computing width of the stretch.
3e62b7e0
EZ
4978 (reseat_at_next_visible_line_start): Undo the change made on
4979 2011-09-17 that saved paragraph information and restored it after
4980 the call to `reseat'. (Bug#9545)
56cd55c8 4981
5ed99d36 49822011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4983
4984 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4985 and turn window cursor on if cleared (Bug#9415).
4986
5ed99d36 49872011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4988
4989 * search.c (boyer_moore): Take unibyte characters from pattern
4990 literally. (Bug#9458)
4991
9bade7b2
EZ
49922011-09-18 Eli Zaretskii <eliz@gnu.org>
4993
4994 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4995
e5e9d610
PE
49962011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4997
87e4427a
PE
4998 Fix minor problem found by static checking.
4999 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5000 initialized, to pacify gcc -Wuninitialized.
5001
e5e9d610
PE
5002 * fileio.c: Report proper errno when syscall falls.
5003 (Finsert_file_contents): Save and restore errno,
5004 so that report_file_error outputs the correct diagnostic.
5005 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5006
a1674f0b
EZ
50072011-09-18 Eli Zaretskii <eliz@gnu.org>
5008
5009 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5010
fbfb6dd4
EZ
50112011-09-17 Eli Zaretskii <eliz@gnu.org>
5012
5013 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5014 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5015
bb187662
EZ
50162011-09-17 Eli Zaretskii <eliz@gnu.org>
5017
1137e8b8 5018 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5019 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5020
5021 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5022 (bidi_find_paragraph_start): Search back for paragraph beginning
5023 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5024 (bidi_move_to_visually_next): Only trigger paragraph-related
5025 computations when the last character is a newline or at EOB, not
5026 just any NEUTRAL_B. (Bug#9470)
5027
bb187662
EZ
5028 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5029 truncated lines if point is covered by a display string. (Bug#9524)
5030
2e621251
PE
50312011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5032
5033 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5034 (cons_to_x_long): New function.
5035 (lisp_data_to_selection_data): Use it. Correct the test for
5036 short-versus-long data; it was negated. Break out of vector
5037 loop, for efficiency, when a long datum is discovered.
5038
91a15bc6
SM
50392011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5040
5041 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5042
b41c3a35
EZ
50432011-09-16 Eli Zaretskii <eliz@gnu.org>
5044
5045 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5046 GCC PR/17406) by declaring this function with external scope.
5047
7812ba2d
PE
50482011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5049
5050 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5051 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5052
cf7edc2a
AS
50532011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5054
5055 * editfns.c (Fformat): Correctly handle text properties on "%%".
5056
bd01620e
EZ
50572011-09-15 Eli Zaretskii <eliz@gnu.org>
5058
5059 * xterm.c (x_draw_composite_glyph_string_foreground):
5060 * w32term.c (x_draw_composite_glyph_string_foreground):
5061 * term.c (encode_terminal_code):
5062 * composite.c (composition_update_it, get_composition_id):
5063 * xdisp.c (get_next_display_element)
5064 (fill_composite_glyph_string): Add comments about special meaning
5065 of TAB characters in a composition.
5066
a02719a3
PE
50672011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5068
5069 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5070 This occurs when processing a multibyte format.
5071 Problem reported by Wolfgang Jenker.
a02719a3 5072
72589a3c
JB
50732011-09-15 Johan Bockgård <bojohan@gnu.org>
5074
5075 * xdisp.c (try_cursor_movement): Only check for exact match if
5076 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5077
1c14176c
PE
50782011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 Remove unused external symbols.
5081 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5082 * xdisp.c (calc_pixel_width_or_height): Now static.
5083 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5084 * indent.c (check_display_width):
5085 * w32term.c: Fix comment to match code.
5086 * xterm.c, xterm.h (x_catching_errors): Remove.
5087
d2eea5b5
PE
50882011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5089
5090 * xselect.c: Use signed conversions more consistently (Bug#9498).
5091 (selection_data_to_lisp_data): Assume incoming selection data are
5092 signed integers, not unsigned. This is to be consistent with
5093 outgoing selection data, which was modified to use signed integers
5094 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5095 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5096 expects long, not unsigned long.
5097
46888499
EZ
50982011-09-14 Eli Zaretskii <eliz@gnu.org>
5099
5100 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5101 computation of loop end. Reported by Johan Bockgård
5102 <bojohan@gnu.org>.
5103
ef8ef9fb
CY
51042011-09-13 Chong Yidong <cyd@stupidchicken.com>
5105
5106 * frame.c (Fother_visible_frames_p): Function deleted.
5107
fa819fed
EZ
51082011-09-12 Eli Zaretskii <eliz@gnu.org>
5109
5110 * indent.c (compute_motion): Process display vector front to back
5111 rather than the other way around. (Bug#2496)
5112
2ba8e008
SM
51132011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5114
5115 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5116
20f53c69
CY
51172011-09-11 Chong Yidong <cyd@stupidchicken.com>
5118
5119 * minibuf.c (Fread_from_minibuffer): Doc fix.
5120
d562d7a4
EZ
51212011-09-11 Eli Zaretskii <eliz@gnu.org>
5122
5123 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5124 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5125
1c4d7f3d
LMI
51262011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5127
5128 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5129 value for non-existent files.
5130
b885bf36
EZ
51312011-09-11 Eli Zaretskii <eliz@gnu.org>
5132
5133 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5134 set its "size" to -1. This will set the modtime_size field of
5135 the corresponding buffer to -1, which is what
5136 verify-visited-file-modtime expects for files that do not exist.
5137 (Bug#9139)
5138
6612f0bf
PE
51392011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5140
5141 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5142 here ...
5143 * lisp.h: ... from here. push_key_description is no longer
5144 defined in keyboard.c, so its declaration should not be in
5145 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5146 logically belongs with push_key_description.
5147
dfb3f755
PE
51482011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5149
5150 * buffer.h: Include <sys/types.h> instead of <time.h>.
5151 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5152 Problem reported by Herbert J. Skuhra.
5153
3134906c
LMI
51542011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5155
5156 * xml.c (parse_region): Make the parsing work for
5157 non-comment-starting XML files again (bug#9144).
5158
8d903f4e
AS
51592011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5160
5161 * image.c (gif_load): Fix calculation of bottom and right corner.
5162 (Bug#9468)
5163
80ad64f4
EZ
51642011-09-10 Eli Zaretskii <eliz@gnu.org>
5165
5166 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5167 redisplay in small windows.
5168
208a048d
EZ
51692011-09-09 Eli Zaretskii <eliz@gnu.org>
5170
5171 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5172
9b1c252e
MR
51732011-09-08 Martin Rudalics <rudalics@gmx.at>
5174
5175 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5176 Operate on live windows only.
5177
2949f33b
JB
51782011-09-08 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5181
e08dcafd
EZ
51822011-09-07 Eli Zaretskii <eliz@gnu.org>
5183
5184 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5185 only under bidi iteration.
5186
115b96bd
JD
51872011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5188
5189 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5190
c8199d0f
PE
51912011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5192
5193 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5194 Without this fix, the command to link temacs failed due to an
5195 undefined symbol __builtin_isnan. This is because
5196 /usr/include/iso/math_c99.h #defines isnan(x) to
5197 __builtin_isnan(x), but the bundled gcc, which identifies itself
5198 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5199 a __builtin_isnan.
5200 * floatfns.c (isnan): #undef, and then #define to a clone of
5201 what's in data.c.
5202 (Fisnan): Always define, since it's always available now.
5203 (syms_of_floatfns): Always define isnan at the Lisp level.
5204
e39b275c 52052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5206
5207 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5208
b2db44d9 52092011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5210
f4af5137 5211 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5212 The previous code assumed that file offsets (off_t values) fit in
5213 EMACS_INT variables, which is not true on typical 32-bit hosts.
5214 The code messed up by falsely reporting buffer overflow in cases
5215 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5216 when "big" contains more than 2**29 bytes, even though this
5217 inserts just one byte and does not overflow the buffer.
5218 (Finsert_file_contents): Store file offsets as off_t
5219 values, not as EMACS_INT values. Check for overflow when
5220 converting between EMACS_INT and off_t. When checking for
5221 buffer overflow or for overlap, take the offsets into account.
5222 Don't use EMACS_INT for small values where int suffices.
5223 When checking for overlap, fix a typo: ZV was used where
5224 ZV_BYTE was intended.
5225 (Fwrite_region): Don't assume off_t fits into 'long'.
5226 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5227
ecfc0a49
MA
52282011-09-05 Michael Albinus <michael.albinus@gmx.de>
5229
5230 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5231
6511acf2 52322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5233
0999621a 5234 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5235
5236 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5237 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5238 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5239 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5240 (modify_event_symbol): Do not assume that the length of
5241 name_alist_or_stem is safe to alloca and fits in int.
5242 (Fexecute_extended_command): Likewise for function name and binding.
5243 (Frecursion_depth): Wrap around reliably on integer overflow.
5244 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5245 since some callers pass EMACS_INT values.
5246 (Fsingle_key_description): Don't crash if symbol name contains more
5247 than MAX_ALLOCA bytes.
5248 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5249 (get_minibuffer): Arg is now EMACS_INT, not int.
5250 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5251 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5252 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5253
2be7d702
PE
5254 * dbusbind.c (signature_cat): New function.
5255 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5256 Do not overrun buffer; instead, report string overflow.
5257
9d1df220
PE
5258 * dispnew.c (add_window_display_history): Don't overrun buffer.
5259 Truncate instead; this is OK since it's just a log.
5260
33ef5c64
PE
5261 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5262 even if the time zone offset is outlandishly large.
5263 Don't mishandle offset == INT_MIN.
5264
66c6fdd5
PE
5265 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5266 when creating daemon; the previous buffer-overflow check was incorrect.
5267
d749b01b
PE
5268 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5269 which has the guts of the old verror function.
5270
b5cd1905
PE
5271 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5272 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5273
6e1a67fb
PE
5274 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5275 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5276 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5277 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5278 length of string rather than counting it via multiple sprintfs;
5279 that's simpler and more reliable.
c21721cc
PE
5280 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5281 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5282 sprintf, in case result does not fit in int.
5283
c57b67fc
PE
5284 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5285 (fontset_from_font): Print it.
5286
8a401434
PE
5287 * frame.c (tty_frame_count): Now printmax_t, not int.
5288 (make_terminal_frame, set_term_frame_name): Print it.
5289 (x_report_frame_params): In X, window IDs are unsigned long,
5290 not signed long, so print them as unsigned.
5291 (validate_x_resource_name): Check for implausibly long names,
5292 and don't assume name length fits in 'int'.
5293 (x_get_resource_string): Don't blindly alloca invocation name;
5294 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5295 not fit in int.
5296
6e1a67fb
PE
5297 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5298 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5299 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5300
0df02bf3
PE
5301 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5302 Use esprintf, not sprintf, in case result does not fit in int.
5303
48e30793
PE
5304 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5305 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5306 it as a large positive number.
5307 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5308 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5309
a66ff6d8
PE
5310 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5311 in case result does not fit in int.
5312
aca216ff
PE
5313 * print.c (float_to_string): Detect width overflow more reliably.
5314 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5315 buffer overrun. Don't assume list length fits in 'int'. Treat
5316 print length of 0 as 0, not as infinity; to be consistent with other
5317 uses of print length in this function. Don't overflow print length
5318 index. Don't assume hash table size fits in 'long', or that
5319 vectorlike size fits in 'unsigned long'.
5320
31c286f7
PE
5321 * process.c (make_process): Use printmax_t, not int, to format
5322 process-name gensyms.
5323
55e5faa1
PE
5324 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5325
80f2e268
PE
5326 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5327 to avoid potential buffer overrun.
5328
670741ab
PE
5329 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5330 if X resource line is longer than 512 bytes.
5331
b7163a50
PE
5332 * xfns.c (x_window): Make sprintf buffer a bit bigger
5333 to avoid potential buffer overrun.
5334
ae58ff1f
PE
5335 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5336
c43c8a6a
PE
5337 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5338
3f8236f4
PE
53392011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5340
53e9fe90 5341 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5342 Without these, Emacs silently mishandles large integers sometimes.
5343 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5344 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5345
6511acf2
PE
5346 * xdisp.c (try_window_id): Check Emacs fixnum range before
5347 converting to 'int'.
806add1d 5348
6511acf2 5349 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5350 Check that an Emacs fixnum is in range before assigning it to 'int'.
5351 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5352 values converted from Emacs fixnums.
5353 (Frecenter): Don't wrap around a line count if it is out of 'int'
5354 range; instead, treat it as an extreme value.
5355 (Fset_window_configuration, compare_window_configurations):
5356 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5357
6511acf2
PE
5358 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5359 that can exceed INT_MAX. Check that EMACS_INT value is in range
5360 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5361 (match_limit): Don't assume that a fixnum can fit in 'int'.
5362
6511acf2 5363 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5364 exceed INT_MAX.
5365
6511acf2 5366 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5367 (Fvertical_motion): Don't wrap around LINES values that don't fit
5368 in 'int'. Instead, treat them as extreme values. This is good
5369 enough for windows, which can't have more than INT_MAX lines anyway.
5370
fcb901a7
LMI
53712011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5372
0f2f6b6d
LMI
5373 * Require libxml/parser.h to avoid compilation warning.
5374
fcb901a7
LMI
5375 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5376
5377 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5378 since this reportedly can destroy thread storage.
5379
6e20a0d4
CY
53802011-08-30 Chong Yidong <cyd@stupidchicken.com>
5381
5382 * syntax.c (find_defun_start): Update all cache variables if
5383 exiting early (Bug#9401).
5384
148ae00e
EZ
53852011-08-30 Eli Zaretskii <eliz@gnu.org>
5386
f6cfbd8f
EZ
5387 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5388
148ae00e
EZ
5389 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5390 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5391 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5392
5393 * term.c (tty_append_glyph): New function.
5394 (produce_stretch_glyph): Static function and its prototype deleted.
5395
a66cfb1c
SM
5396 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5397 Add prototypes.
148ae00e 5398
c4a07a4c
PE
53992011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5400
5401 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5402 when checking :margin (Bug#9390).
5403 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5404 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5405 so that the name doesn't mislead. All uses changed.
5406
6bc8cd65
JB
54072011-08-28 Johan Bockgård <bojohan@gnu.org>
5408
5409 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5410 set_tty_hooks.
5411
dca4927e
EZ
54122011-08-27 Eli Zaretskii <eliz@gnu.org>
5413
5414 * xdisp.c (move_it_to): Don't bail out early when reaching
5415 position beyond to_charpos, if we are scanning backwards.
5416 (move_it_vertically_backward): When DY == 0, make sure we get to
5417 the first character in the line after the newline.
5418
f2cad773
PE
54192011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5420
5421 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5422 (ccl_driver): Do not generate an out-of-range pointer.
5423 (Fccl_execute_on_string): Remove unnecessary check for
5424 integer overflow, noted by Stefan Monnier in
5425 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5426 Remove a FIXME that didn't need fixing.
5427 Simplify the newly-introduced buffer reallocation code.
5428
0cae2cdb
JB
54292011-08-27 Juanma Barranquero <lekktu@gmail.com>
5430
5431 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5432
5fc295a4 54332011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5434
70c60eb2 5435 Integer and memory overflow issues (Bug#9196).
726e0ab1 5436
d31850da
PE
5437 * doc.c (get_doc_string): Rework so that
5438 get_doc_string_buffer_size is the actual buffer size, rather than
5439 being 1 less than the actual buffer size; this makes xpalloc more
5440 convenient.
5441
a69fbedb
PE
5442 * image.c (x_allocate_bitmap_record, cache_image):
5443 * xselect.c (Fx_register_dnd_atom):
5444 Simplify previous changes by using xpalloc.
5445
fe5c5d37
PE
5446 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5447 since either will do and ptrdiff_t is convenient with xpalloc.
5448
0065d054
PE
5449 * charset.c (charset_table_size)
5450 (struct charset_sort_data.priority): Now ptrdiff_t.
5451 (charset_compare): Don't overflow if priorities differ greatly.
5452 (Fsort_charsets): Don't assume list length fits in int.
5453 Check for size-calculation overflow when allocating sort data.
5454 (syms_of_charset): Allocate an initial charset table that is
5455 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5456
5457 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5458
5459 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5460 The actual value is always <= INT_MAX, and leaving it unsigned made
5461 overflow checking harder.
5462
5463 * dispextern.h (struct glyph_matrix.rows_allocated)
5464 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5465 with xpalloc. The values are still always <= INT_MAX.
5466
5467 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5468
5469 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5470 (SAFE_NALLOCA): New macro.
5471
5472 * region-cache.c (struct boundary.pos, find_cache_boundary)
5473 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5474 (set_cache_region, invalidate_region_cache)
5475 (revalidate_region_cache, know_region_cache, region_cache_forward)
5476 (region_cache_backward, pp_cache):
5477 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5478 so that ptrdiff_t * can be passed to xpalloc.
5479 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5480 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5481 (pp_cache): Don't assume cache_len fits in int.
5482 * region-cache.h: Adjust extern decls to match.
5483
5484 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5485 EMACS_INT, since either will do, for xpalloc.
5486
5487 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5488 (xnmalloc, xnrealloc, xpalloc): New functions.
5489
726e0ab1
PE
5490 * bidi.c (bidi_shelve_header_size): New constant.
5491 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5492 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5493
51f30bc5 5494 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5495 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5496 (overlay_strings):
5497 Don't update size of array until after memory allocation succeeds,
5498 because xmalloc/xrealloc may not return.
0065d054
PE
5499 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5500 now that we have proper integer overflow checking.
5501 (record_overlay_string, overlay_strings): Catch overflows when
5502 calculating size of overlay_str_buf.
726e0ab1 5503
0065d054
PE
5504 * callproc.c (Fcall_process): Check for size overflow when
5505 calculating size of args2.
5506 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5507 Normally we prefer signed values, but sticking with ptrdiff_t would
5508 require adding more-complicated checks.
726e0ab1
PE
5509
5510 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5511 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5512 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5513 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5514
5515 * character.c (Fstring): Check for size-calculation overflow.
5516
5517 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5518 unnecessary integer overflow. Check for size overflow.
5519 (encode_coding_object): Don't update size until xmalloc succeeds.
5520
5521 * composite.c (get_composition_id): Check for overflow in glyph
5522 length calculations.
5523
5524 Integer and memory overflow fixes for display code.
5525 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5526 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5527 (scrolling_window): Check for overflow in size calculations.
5528 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5529 Don't assume glyph table len fits in int.
5530 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5531 (row_table_size): Now ptrdiff_t, not int.
5532 (scrolling_window): Avoid overflow in size calculations.
5533 Don't update size until allocation succeeds.
5534 * fns.c (concat): Check for overflow in size calculations.
5535 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5536 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5537 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5538
5539 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5540 (get_doc_string): Check for size calculation overflow.
5541 Don't update size until allocation succeeds.
5542 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5543 EMACS_INT, where ptrdiff_t will do.
5544 (Fsubstitute_command_keys): Check for string overflow.
5545
5546 * editfns.c (set_time_zone_rule): Don't assume environment length
5547 fits in int.
5548 (message_length): Now ptrdiff_t, not int.
5549 (Fmessage_box): Don't update size until allocation succeeds.
5550 Don't assume message length fits in int.
5551 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5552
0065d054
PE
5553 * emacs.c (main): Do not reallocate argv, since there is a null at
5554 the end that can be overwritten, and this way there's no need to
5555 worry about size-calculation overflow.
5556 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5557
5558 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5559 alloc succeeds.
5560 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5561
5562 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5563 (x_set_scroll_bar_width, x_figure_window_size):
5564 Check for integer overflow.
5565 (x_set_alpha): Do not assume XINT fits in int.
5566
5567 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5568 This is for the members text_lines, text_cols, total_lines, total_cols,
5569 where the system imposes an 'int' limit.
5570
5571 * fringe.c (Fdefine_fringe_bitmap):
5572 Don't update size until alloc works.
5573
5574 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5575 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5576
5577 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5578 Check for size-calculation overflow.
5579 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5580 do, as we prefer signed integers.
5581 (id_to_widget.max_size, id_to_widget.used)
5582 (xg_store_widget_in_map, xg_remove_widget_from_map)
5583 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5584 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5585 Use and return ptrdiff_t, not int.
5586 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5587 * gtkutil.h: Change prototypes to match the above.
5588
5589 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5590 are duplicate now that they've been promoted to lisp.h.
5591 (x_allocate_bitmap_record, x_alloc_image_color)
5592 (make_image_cache, cache_image, xpm_load):
5593 Don't update size until alloc is done.
5594 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5595 (x_detect_edges):
3256efce 5596 Check for size calculation overflow.
726e0ab1
PE
5597 (ct_colors_allocated_max): New constant.
5598 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5599 overflow.
3256efce 5600
726e0ab1
PE
5601 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5602 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5603 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5604 Use ptrdiff_t, not int, to count maps.
5605 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5606 calculations. Don't update size until allocation succeeds.
5607 Redo calculations to avoid overflow.
726e0ab1
PE
5608 * keyboard.h: Change prototypes to match the above.
5609
5610 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5611 to count maps.
5612 (current_minor_maps): Check for size calculation overflow.
5613 * keymap.h: Change prototypes to match the above.
5614
5615 * lread.c (read1, init_obarray): Don't update size until alloc done.
5616
5617 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5618 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5619
726e0ab1
PE
5620 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5621 Now ptrdiff_t, not int.
5622 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5623 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5624
5625 * process.c (Fnetwork_interface_list): Check for overflow
5626 in size calculation.
5627
5628 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5629
5630 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5631 overflow. Don't bother calling xmalloc when xrealloc will do.
5632
5633 * search.c (Freplace_match): Check for size calculation overflow.
5634 (Fset_match_data): Don't assume list lengths fit in 'int'.
5635
5636 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5637 for command line length. Do not attempt to address one before the
5638 beginning of an array, as that's not portable.
5639
5640 * term.c (max_frame_lines): Remove; unused.
5641 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5642 not int.
5643 (encode_terminal_code, calculate_costs): Check for size
5644 calculation overflow.
5645 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5646 table lengths and related sizes. Don't update size until alloc
5647 done. Redo calculations to avoid overflow.
5648 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5649
5650 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5651 subtracting pointers.
5652 (gobble_line): Check for overflow more carefully. Don't update size
5653 until alloc done.
5654
5655 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5656 Don't update size until alloc done.
5657 Redo size calculations to avoid overflow.
5658 Check for size calculation overflow.
0065d054 5659 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5660
5661 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5662 Use ptrdiff_t, not int, for sizes.
5663 (store_mode_line_noprop_char): Don't update size until alloc done.
5664
0065d054
PE
5665 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5666 Use ptrdiff_t, not int, for sizes.
5667 (Finternal_make_lisp_face, cache_face):
5668 Check for size calculation overflow.
5669 (cache_face): Treat size calculation overflows as if they were
5670 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5671
5672 * xfns.c (x_encode_text, x_set_name_internal)
5673 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5674 sizes, since they can exceed INT_MAX in size. Check for size
5675 calculation overflow.
5676
0065d054
PE
5677 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5678 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5679 Don't update size until alloc done.
5680
0065d054 5681 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5682 as sprintf is limited to int lengths.
1d526e2f 5683
252c5ee1
PE
5684 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5685 (X_LONG_MIN): New macros.
864d7ce7
PE
5686 Use them to make the following changes clearer.
5687 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5688 This change doesn't affect the value now, but it may help remind
5689 future maintainers not to raise the value too much later.
5690 (SELECTION_QUANTUM): Remove, replacing with ...
5691 (selection_quantum): ... new function, which avoids overflow.
5692 All uses changed.
5693 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5694 assumption that selection length fits in 'int'.
5695 (x_reply_selection_request, x_handle_selection_request)
5696 (x_get_window_property, receive_incremental_selection)
5697 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5698 (lisp_data_to_selection_data, clean_local_selection_data):
5699 Use ptrdiff_t, not int, to record length of selection.
5700 (x_reply_selection_request, x_get_window_property)
5701 (receive_incremental_selection, x_property_data_to_lisp):
5702 Redo calculations to avoid overflow.
5703 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5704 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5705 something.
5706 (x_get_window_property, receive_incremental_selection)
5707 (lisp_data_to_selection_data, x_property_data_to_lisp):
5708 Check for size-calculation overflow.
5709 (x_get_window_property, receive_incremental_selection)
5710 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5711 Don't store size until memory allocation succeeds.
5712 (x_get_window_property): Plug memory leak on memory exhaustion.
5713 Don't double-block input; malloc is safe here. Don't assume 2**34
5714 - 4 fits in unsigned long. Add an xassert to check
5715 XGetWindowProperty overflow. Be more careful about overflow
5716 calculations, and distinguish size from memory overflow better.
5717 (receive_incremental_selection): When tracing, don't assume
5718 unsigned int is less than INT_MAX.
5719 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5720 harmful) conversions of unsigned short to int.
5721 (lisp_data_to_selection_data): Don't assume that integers
5722 in the range -65535 through -1 fit in an X unsigned short.
5723 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5724 result parameters unless successful. Rely on cons_to_unsigned
5725 to report problems with elements; the old code wasn't right anyway.
5726 (x_check_property_data): Check for int overflow; we cannot use
5727 a wider type due to X limits.
5728 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5729
726e0ab1 5730 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5731
0065d054
PE
5732 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5733 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5734 (x_color_cells): Don't store size until memory allocation succeeds.
5735 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5736 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5737 (x_term_init): Don't assume length fits in int (sprintf is limited
5738 to int size).
bc18e09d 5739
ebfa62c0
PE
5740 Use ptrdiff_t for composition IDs.
5741 * character.c (lisp_string_width):
5742 * composite.c (composition_table_size, n_compositions)
5743 (get_composition_id, composition_gstring_from_id):
5744 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5745 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5746 * window.c (Frecenter):
5747 Use ptrdiff_t, not int, for composition IDs.
5748 * composite.c (get_composition_id): Check for integer overflow.
5749 * composite.h: Adjust prototypes to match the above changes.
5750
d3411f89
PE
5751 Use ptrdiff_t for hash table indexes.
5752 * category.c (hash_get_category_set):
5753 * ccl.c (ccl_driver):
5754 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5755 * coding.c (coding_system_charset_list, detect_coding_system):
5756 * coding.h (struct coding_system.id):
5757 * composite.c (get_composition_id, gstring_lookup_cache):
5758 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5759 * image.c (xpm_get_color_table_h):
5760 * lisp.h (hash_lookup, hash_put):
5761 * minibuf.c (Ftest_completion):
5762 Use ptrdiff_t for hash table indexes, not int (which is too
5763 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5764 32-bit --with-wide-int hosts).
5765
e097a6fa
PE
5766 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5767 Add a FIXME comment about memory leaks.
5768 (syms_of_charset): Don't assume xmalloc returns.
5769
5637687f
PE
5770 Don't assume that stated character widths fit in int.
5771 * character.c (Fchar_width, c_string_width, lisp_string_width):
5772 * character.h (CHAR_WIDTH):
5773 * indent.c (MULTIBYTE_BYTES_WIDTH):
5774 Use sanitize_char_width to avoid undefined and/or bad behavior
5775 with outlandish widths.
a66cfb1c 5776 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5777 now that we have two such functions. All uses changed.
5778 (sanitize_char_width): New inline function.
5779
a2271ba2
PE
5780 Don't assume that tab-width fits in int.
5781 * character.h (sanitize_width): New inline function.
5782 (SANE_TAB_WIDTH): New macro.
5783 (ASCII_CHAR_WIDTH): Use it.
5784 * indent.c (sane_tab_width): Remove. All uses replaced by
5785 SANE_TAB_WIDTH (current_buffer).
5786 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5787
18c52557
PE
5788 * fileio.c: Integer overflow issues with file modes.
5789 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5790
caeeedc1
PE
5791 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5792 Remove unreachable code.
5793 (read_hex, load_charset_map_from_file): Check for integer overflow.
5794
6df6ae42 5795 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5796 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5797 (x_send_scroll_bar_event): Likewise. Check that the size does not
5798 exceed limits imposed by XClientMessageEvent, as well as the usual
5799 ptrdiff_t and size_t limits.
5800
b13995db
PE
5801 * keyboard.c: Overflow, signedness and related fixes.
5802 (make_lispy_movement): Use same integer type in forward decl
5803 that is used in the definition.
5804 (read_key_sequence, keyremap_step):
5805 Change bufsize argument back to int, undoing my 2011-03-30 change.
5806 We prefer signed types, and int is wide enough here.
5807 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5808 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5809 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5810 length, not size_t. Use ptrdiff_t for index, not int.
5811 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5812 possibility of integer overflow.
5813
13464394
PE
5814 Overflow, signedness and related fixes for images.
5815
5816 * dispextern.h (struct it.stack[0].u.image.image_id)
5817 (struct_it.image_id, struct image.id, struct image_cache.size)
5818 (struct image_cache.used, struct image_cache.ref_count):
5819 * gtkutil.c (update_frame_tool_bar):
5820 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5821 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5822 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5823 * nsmenu.m (update_frame_tool_bar):
5824 * xdisp.c (calc_pixel_width_or_height):
5825 * xfns.c (image_cache_refcount):
5826 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5827 on typical 64-bit hosts.
5828
5829 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5830 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5831 Omit unnecessary casts to int.
5832 (parse_image_spec): Check that integers fall into 'int' range
5833 when the callers expect that.
5834 (image_ascent): Redo ascent calculation to avoid int overflow.
5835 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5836 (lookup_image): Remove unnecessary tests.
5837 (xbm_image_p): Locals are now of int, not EMACS_INT,
5838 since parse_image_check makes sure they fit into int.
5839 (png_load, gif_load, svg_load_image):
5840 Prefer int to unsigned where either will do.
5841 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5842 old tiff_error_handler and tiff_warning_handler.
5843 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5844 stack buffer overflows. It uses only the features of vsnprintf
5845 that are common to both POSIX and native Microsoft.
5846 (tiff_error_handler, tiff_warning_handler): Use it.
5847 (tiff_load, gif_load, imagemagick_load_image):
5848 Don't assume :index value fits in 'int'.
5849 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5850 (imagemagick_load_image): Check that crop parameters fit into
5851 the integer types that MagickCropImage accepts. Don't assume
5852 Vimagemagick_render_type has a nonnegative value. Don't assume
5853 size_t fits in 'long'.
5854 (gs_load): Use printmax_t to print the widest integers possible.
5855 Check for integer overflow when computing image height and width.
5856
c11821d4
EZ
58572011-08-26 Eli Zaretskii <eliz@gnu.org>
5858
5859 * xdisp.c (redisplay_window): Don't force window start if point
5860 will be invisible in the resulting window. (Bug#9324)
5861
0c95fcf7
EZ
58622011-08-25 Eli Zaretskii <eliz@gnu.org>
5863
5864 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5865 the display spec is of the form `(space ...)'.
5866 (handle_display_spec): Return the value returned by
5867 handle_single_display_spec, not just 1 or zero.
5868 (handle_single_display_spec): If the display spec is of the form
5869 `(space ...)', and specifies display in the text area, return 2
5870 rather than 1.
fee65a97 5871 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5872 accurately, and prefer exact match for point under bidi.
5873 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5874
5875 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5876 into disp_prop; all users changed.
5877
5878 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5879 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5880 for the text covered by the display property.
5881
e4ed06f1
CY
58822011-08-25 Chong Yidong <cyd@stupidchicken.com>
5883
5884 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5885 Change return value to nil.
5886 (Frecord_buffer): Delete unused function.
5887
f67cdd7f
EZ
58882011-08-24 Eli Zaretskii <eliz@gnu.org>
5889
5980d4c6
EZ
5890 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5891 buffers, return left-to-right.
8610fe8b
EZ
5892 (set_cursor_from_row): Consider candidate row a win if its glyph
5893 represents a newline and point is on that newline. Fixes cursor
5894 positioning on the newline at EOL of R2L text within L2R
5895 paragraph, and vice versa.
5896 (try_cursor_movement): Check continued rows, in addition to
5897 continuation rows. Fixes unwarranted scroll when point enters a
5898 continued line of R2L text within an L2R paragraph, or vice versa.
5899 (cursor_row_p): Consider the case of point being equal to
5900 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5901 from the end of a short line to the beginning of a continued line
5902 of R2L text within L2R paragraph.
5903 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5904 composed characters.
5980d4c6 5905
f67cdd7f
EZ
5906 * bidi.c (bidi_check_type): Use xassert.
5907 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5908 members.
5909
bca633fb
EZ
59102011-08-23 Eli Zaretskii <eliz@gnu.org>
5911
5912 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5913 a character.
5914
4a5885a7
CY
59152011-08-23 Chong Yidong <cyd@stupidchicken.com>
5916
5917 * nsfont.m (ns_otf_to_script): Fix typo.
5918
0902a04e
KH
59192011-08-22 Kenichi Handa <handa@m17n.org>
5920
5921 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5922 extra slot even if the purpose is char-code-property-table.
5923
1a2e6670
EZ
59242011-08-23 Eli Zaretskii <eliz@gnu.org>
5925
8ddde651
EZ
5926 * xdisp.c (redisplay_window): When computing centering_position,
5927 account for the height of the header line. (Bug#8874)
5928
425cc014
EZ
5929 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5930 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5931 candidate is selected by the mouse, and that candidate has a
5932 composed character under the mouse.
5933
1a2e6670
EZ
5934 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5935 coordinates reported by pos-visible-in-window-p for a composed
5936 character in column zero.
5937
8b76d6f8
SM
59382011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5939
5940 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5941
dac347dd
EZ
59422011-08-22 Eli Zaretskii <eliz@gnu.org>
5943
5944 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5945 consider it a hit if to_charpos is anywhere in the range of the
5946 composed buffer positions.
5947
e013fb34
CY
59482011-08-22 Chong Yidong <cyd@stupidchicken.com>
5949
5950 * image.c (gif_load): Don't assume that each subimage has the same
5951 dimensions as the base image. Handle disposal method that is
5952 "undefined" by the gif spec (Bug#9335).
5953
bd1ba3e8
CY
59542011-08-20 Chong Yidong <cyd@stupidchicken.com>
5955
5956 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5957 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5958
54a1215b
EZ
59592011-08-19 Eli Zaretskii <eliz@gnu.org>
5960
823564e5
EZ
5961 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5962 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5963 from an Org mode buffer to a Speedbar frame.
5964
54a1215b
EZ
5965 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5966 a composition, take its buffer position from IT->cmp_it.charpos.
5967 Fixes cursor positioning at the beginning of a line that begins
5968 with a composed character.
5969
9778ebcc
EZ
59702011-08-18 Eli Zaretskii <eliz@gnu.org>
5971
0be6ee06
EZ
5972 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5973 character bidirectional type, use STRONG_L instead. Fixes crashes
5974 in a buffer produced by `describe-categories'.
5975
9778ebcc
EZ
5976 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5977 members before the level stack, so they would be saved and
5978 restored when copying iterator state. Fixes incorrect reordering
5979 around TABs covered by display properties.
5980
156bffbe
AS
59812011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5982
6b02f655 5983 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5984
72ad093b
CY
59852011-08-17 Chong Yidong <cyd@stupidchicken.com>
5986
5987 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5988 (internal_condition_case_2, internal_condition_case_n):
5989 Remove unnecessary aborts (Bug#9081).
72ad093b 5990
35774242
EZ
59912011-08-17 Eli Zaretskii <eliz@gnu.org>
5992
5993 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5994 has no `load' handler, try opening the file locally. (Bug#9311)
5995
db76dd85
KB
59962011-08-16 Ken Brown <kbrown@cornell.edu>
5997
5998 * gmalloc.c: Expand comment.
5999
b215eee5
EZ
60002011-08-16 Eli Zaretskii <eliz@gnu.org>
6001
6002 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6003 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6004
a4579d33
KB
60052011-08-16 Ken Brown <kbrown@cornell.edu>
6006
6007 Fix memory allocation problems in Cygwin build (Bug#9273).
6008
6009 * unexcw.c ( __malloc_initialized): Declare external variable.
6010 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6011
8b76d6f8
SM
6012 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6013 New variables.
a4579d33
KB
6014 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6015 dumped emacs.
6016 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6017 in the static heap.
6018 [CYGWIN] (special_realloc): New function.
6019 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6020 requests to realloc storage in the static heap.
6021
3ebec551
PE
60222011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6023
6024 * bidi.c (bidi_initialize): Remove unused local.
6025
9fd8be00
EZ
60262011-08-15 Eli Zaretskii <eliz@gnu.org>
6027
6b02f655
SM
6028 * bidimirror.h:
6029 * biditype.h: Remove file.
6030 * makefile.w32-in ($(BLD)/bidi.$(O)):
6031 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6032
6033 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6034
6035 * chartab.c: Improve commentary for the uniprop_table API.
6036
32413314
EZ
6037 * bidi.c (bidi_paragraph_init): Support zero value of
6038 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6039 (bidi_initialize): Use uniprop_table instead of including
6040 biditype.h and bidimirror.h.
32413314 6041
9fd8be00
EZ
6042 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6043 coordinates of the iterator when restoring from ppos_it.
6044 (Bug#9296)
6045
5cf2b69b
KH
60462011-08-14 Kenichi Handa <handa@m17n.org>
6047
6048 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6049 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6050
daf17d00
EZ
60512011-08-14 Eli Zaretskii <eliz@gnu.org>
6052
6053 * xdisp.c (move_it_in_display_line_to): Don't invoke
6054 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6055 ppos_it. Fixes vertical cursor motion when line beginning is
6056 covered by an image. (Bug#9296)
6057
08e3161a
JD
60582011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6059
6060 * nsterm.h (ns_run_ascript): Declare.
6061 (NSAPP_DATA2_RUNASSCRIPT): Define.
6062
6063 * nsfns.m (as_script, as_result, as_status): New static variables.
6064 (ns_run_ascript): New function.
5e617bc2 6065 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6066 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6067 the event loop. Get status from as_status (Bug#7276).
6068
6069 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6070 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6071 the event loop (Bug#7276).
6072
a3720aa2
AS
60732011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6074
6075 * gnutls.c (QCgnutls_bootprop_priority)
6076 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6077 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6078 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6079 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6080 (QCgnutls_bootprop_verify_hostname_error)
6081 (QCgnutls_bootprop_callbacks_verify): Rename from
6082 Qgnutls_bootprop_..., all uses changed.
6083
6084 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6085 uses changed.
6086
0a0d27fb
PE
60872011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6088
19d5c50c
PE
6089 * xfaces.c (Qframe_set_background_mode): Now static.
6090 * dispextern.h (Qframe_set_background_mode): Remove decl.
6091
0a0d27fb
PE
6092 * process.c (Fnetwork_interface_info): Declare local only if needed.
6093
377538cb
JD
60942011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6095
6096 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6097 (Fnetwork_interface_list): Allocate in increments of bytes instead
6098 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6099 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6100 sockaddr.
6101 (struct ifflag_def): notrailers is smart on OSX.
6102 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6103 Get hardware address with getifaddrs if available.
6104
08fff70c
EZ
61052011-08-12 Eli Zaretskii <eliz@gnu.org>
6106
6107 * xdisp.c (iterate_out_of_display_property): xassert that
6108 IT->position is set to within IT->object's boundaries. Break from
6109 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6110 when IT->position is set up wrongly due to some bug.
6111 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6112 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6113 entry. Force push_it to save on the stack the current
6114 buffer/string position, to be restored by pop_it. Fix flags in
6115 the iterator structure wrt the object coming from a display
6116 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6117 properties. (Bug#9284)
6118
7be1c708 61192011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6120
7be1c708
CY
6121 * fontset.c (fontset_get_font_group): Add proper type checks.
6122 (Bug#9172)
aac0c6e3 6123
7be1c708 61242011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6125
7be1c708
CY
6126 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6127 and LC_VERSION_MIN_MACOSX.
6128 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6129 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6130
97bb72a6
EZ
61312011-08-08 Eli Zaretskii <eliz@gnu.org>
6132
6133 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6134 no-display-properties-and-no-overlays under bidi display.
6135 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6136 properties and overlays.
97bb72a6 6137
d5617611
CY
61382011-08-08 Chong Yidong <cyd@stupidchicken.com>
6139
37e11a63
CY
6140 * editfns.c (Fset_time_zone_rule): Document relationship with the
6141 setenv function.
6142
d5617611
CY
6143 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6144 the font entity extracted from the cache (Bug#8109).
6145
58872834
CY
61462011-08-07 Chong Yidong <cyd@stupidchicken.com>
6147
6148 * composite.c (autocmp_chars): Don't reset point. That is done by
6149 restore_point_unwind (Bug#5984).
6150
75bfc667
JL
61512011-08-07 Juri Linkov <juri@jurta.org>
6152
6153 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6154 to show the arg `TIME' instead of `TIMEVAL'.
6155
d1410150
EZ
61562011-08-06 Eli Zaretskii <eliz@gnu.org>
6157
6158 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6159 display property strides EOL and includes a newline, as in
6160 longlines-mode. (Bug#9254)
75b771e4
EZ
6161 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6162 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6163
6164 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6165 is non-zero, even if the data buffer is NULL. Fixes a crash in
6166 vertical-motion with longlines-mode. (Bug#9254)
6167
35928349
EZ
61682011-08-05 Eli Zaretskii <eliz@gnu.org>
6169
ec7cc85b
EZ
6170 * bidi.c <bidi_cache_total_alloc>: Now static.
6171 (bidi_initialize): Initialize bidi_cache_total_alloc.
6172
8b76d6f8 6173 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6174 cache. (Bug#9221)
6175
6176 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6177 amount allocated this far in `bidi_cache_total_alloc'.
6178 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6179 non-zero, only free the data buffer without restoring the cache
6180 contents. All callers changed.
6181
6182 * dispextern.h (bidi_unshelve_cache): Update prototype.
6183
6184 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6185 (move_it_in_display_line, move_it_to)
6186 (move_it_vertically_backward, move_it_by_lines): Replace the call
6187 to xfree to an equivalent call to bidi_unshelve_cache.
6188 (move_it_in_display_line_to): Fix logic of returning
412b6358 6189 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6190
e2e2423b
EZ
61912011-08-05 Eli Zaretskii <eliz@gnu.org>
6192
6193 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6194 came from a string character with a `cursor' property. (Bug#9229)
6195
ae9e757a
JD
61962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6197
6198 * Makefile.in (LIB_PTHREAD): New variable.
6199 (LIBES): Add LIB_PTHREAD (Bug#9216).
6200
6201 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6202 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6203
213bd7f2
AS
62042011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6205
6b02f655 6206 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6207
99aaf75f
JD
62082011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6209
6210 * xterm.c (x_find_topmost_parent): New function.
6211 (x_set_frame_alpha): Find topmost parent window with
6212 x_find_topmost_parent and set the property there also (bug#9181).
6213 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6214
c74e9d86
PE
62152011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6216
6217 * callproc.c (Fcall_process): Avoid vfork clobbering
6218 the local vars buffer, coding_systems, current_dir.
6219
640c8776
SM
62202011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6221
6222 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6223
f26d0e4c
PE
62242011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6225
8a10d76c
PE
6226 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6227 so that it is not optimized away.
6228
f26d0e4c
PE
6229 * xdisp.c (compute_display_string_pos): Remove unused local.
6230
55439c61
EZ
62312011-08-02 Eli Zaretskii <eliz@gnu.org>
6232
6233 Fix slow cursor motion and scrolling in large buffers with
6234 selective display, like Org Mode buffers. (Bug#9218)
6235
6236 * dispextern.h (struct bidi_it): New member disp_prop_p.
6237
6238 * xdisp.c: Remove one-slot cache of display string positions.
6239 (compute_display_string_pos): Accept an additional argument
5e617bc2 6240 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6241 for a display string or property. If found, set DISP_PROP_P
6242 non-zero.
6243
6244 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6245 DISP_PROP_P, and pass it to compute_display_string_pos.
6246 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6247 non-zero. All callers of bidi_fetch_char changed.
6248
fb33fa43
SM
62492011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6250
6251 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6252
b099e063
DM
62532010-12-03 Don March <don@ohspite.net>
6254
6255 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6256 last character M-[char] is translated to ESC [char] (bug#7541).
6257
5cc7f7af
KH
62582011-08-02 Kenichi Handa <handa@m17n.org>
6259
d0fffa3f 6260 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6261
6262 * chartab.c (uniprop_table): Make it non-static.
6263
525d5e6e
EZ
62642011-08-01 Eli Zaretskii <eliz@gnu.org>
6265
6266 * xdisp.c (forward_to_next_line_start): Accept additional argument
6267 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6268 on the newline.
6269 (reseat_at_next_visible_line_start): Use the bidi iterator state
6270 returned by forward_to_next_line_start to restore the state of
6271 it->bidi_it after backing up to previous newline. (Bug#9212)
6272
31011111
AS
62732011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6274
6275 * regex.c (re_comp): Protoize.
6276 (re_exec): Fix return type.
6277 (regexec): Fix type of `ret'. (Bug#9203)
6278
476371c4
PE
62792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6280
e5d76069
PE
6281 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6282 This is needed if max-image-size is a floating-point number.
6283
9a79b20c
AS
62842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6285
6286 * print.c (print_object): Print empty symbol as ##.
6287
6288 * lread.c (read1): Read ## as empty symbol.
6289
d8c2fa78
AA
62902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6291
6292 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6293 setting frame foreground color (Bug#9175).
6294 (x_set_background_color): Likewise.
6295
ffe57a7a
AA
6296 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6297 contents (Bug#9176).
6298 (EmacsTooltip -init): Remove bezels and add shadows to
6299 tooltip windows.
6300
bf3492a5
AA
6301 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6302 or scroll bar (Bug#8470).
6303
d55e9c53
AA
6304 * nsfont.m (nsfont_open): Remove assignment to voffset and
6305 unnecessary vars hshink, expand, hd, full_height, min_height.
6306 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6307
6308 * nsterm.h (nsfont_info): Remove voffset field.
6309
d8c2fa78 63102011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6311
6312 Implement strike-through and overline on NextStep (Bug#8863).
6313
6314 * nsfont.m (nsfont_open): Use underline position provided by font,
6315 instead of hard-coded value of 2.
6316 (nsfont_draw): Call ns_draw_text_decoration instead.
6317
6318 * nsterm.h: Add declaration for ns_draw_text_decoration.
6319
6320 * nsterm.m (ns_draw_text_decoration): New function for drawing
6321 underline, overline, and strike-through.
6322 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6323 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6324 accommodate underlining, etc.
4843aac3 6325
4cc60b9b
EZ
63262011-07-28 Eli Zaretskii <eliz@gnu.org>
6327
bc7ece87
EZ
6328 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6329 default.
4cc60b9b 6330
476371c4
PE
63312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6332
66606eea
PE
6333 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6334 Without this fix, if a signal arrives just after memory fills up,
6335 'malloc' might be invoked reentrantly.
6336
476371c4
PE
6337 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6338 In other words, assume that every image size is allowed, on non-X
6339 hosts. This assumption is probably wrong, but it lets Emacs compile.
6340
f3fcc40d
AS
63412011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6342
6343 * regex.c (re_iswctype): Convert return values to boolean.
6344
350c992f
EZ
63452011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6346
6347 * xdisp.c (compute_display_string_pos): Don't use cached display
6348 string position if the buffer had its restriction changed.
6349 (Bug#9184)
6350
5266b4bb
PE
63512011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6352
6353 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6354
2573a837 63552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6356
41f55ccd 6357 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6358
39e378da
PE
6359 * bidi.c: Integer size and overflow fixes.
6360 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6361 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6362 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6363 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6364 (bidi_find_other_level_edge):
6365 Use ptrdiff_t instead of EMACS_INT where either will do.
6366 This works better on 32-bit hosts configured --with-wide-int.
6367 (bidi_cache_ensure_space): Check for size-calculation overflow.
6368 Use % rather than repeated addition, for better worst-case speed.
6369 Don't set bidi_cache_size until after xrealloc returns, because it
6370 might not return.
6371 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6372 (bidi_cache_ensure_space): Also check that the bidi cache size
6373 does not exceed that of the largest Lisp string or buffer. See Eli
6374 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6375
5e927815
PE
6376 * alloc.c (__malloc_size_t): Remove.
6377 All uses replaced by size_t. See Andreas Schwab's note
6378 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6379
ca4aa935
PE
6380 * image.c: Improve checking for integer overflow.
6381 (check_image_size): Assume that f is nonnull, since
6382 it is always nonnull in practice. This is one less thing to
6383 worry about when checking for integer overflow later.
6384 (x_check_image_size): New function, which checks for integer
6385 overflow issues inside X.
6386 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6387 This removes the need for a memory_full check.
6388 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6389 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6390 (xbm_read_bitmap_data): Change locals back to 'int', since
6391 their values must fit in 'int'.
6392 (xpm_load_image, png_load, tiff_load):
6393 Invoke x_create_x_image_and_pixmap earlier,
6394 to avoid much needless work if the image is too large.
6395 (tiff_load): Treat overly large images as if
6396 x_create_x_image_and_pixmap failed, not as malloc failures.
6397 (gs_load): Use x_check_image_size.
6398
5f8f9cc2
PE
6399 * gtkutil.c: Omit integer casts.
6400 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6401 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6402
5adf60bc
PE
6403 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6404
c8907a93
PE
6405 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6406 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6407 would wrongly return t on a 64-bit host.
6408
e3c25c68
PE
6409 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6410 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6411 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6412 and therefore cause GCC to emit a bogus diagnostic in some cases.
6413
3f791afe
PE
6414 * image.c: Integer signedness and overflow and related fixes.
6415 This is not an exhaustive set of fixes, but it's time to
6416 record what I've got.
6417 (lookup_pixel_color, check_image_size): Remove redundant decls.
6418 (check_image_size): Don't assume that arbitrary EMACS_INT values
6419 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6420 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6421 (tiff_load, imagemagick_load_image):
6422 Check for overflow in size calculations.
6423 (x_create_x_image_and_pixmap): Remove unnecessary test for
6424 xmalloc returning NULL; that can't happen.
6425 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6426 (xpm_color_bucket): Use better integer hashing function.
6427 (xpm_cache_color): Don't possibly over-allocate memory.
6428 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6429 (gif_memory_source):
6430 Use ptrdiff_t, not int or size_t, to record sizes.
6431 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6432 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6433 either works, as we prefer signed integers.
6434 (tiff_read_from_memory, tiff_write_from_memory):
6435 Return tsize_t, not size_t, since that's what the TIFF API wants.
6436 (tiff_read_from_memory): Don't fail simply because the read would
6437 go past EOF; instead, return a short read.
6438 (tiff_load): Omit no-longer-needed casts.
6439 (Fimagemagick_types): Don't assume size fits into 'int'.
6440
3cc5a532
PE
6441 Improve hashing quality when configured --with-wide-int.
6442 * fns.c (hash_string): New function, taken from sxhash_string.
6443 Do not discard information about ASCII character case; this
6444 discarding is no longer needed.
6445 (sxhash-string): Use it. Change sig to match it. Caller changed.
6446 * lisp.h: Declare it.
6447 * lread.c (hash_string): Remove, since we now use fns.c's version.
6448 The fns.c version returns a wider integer if --with-wide-int is
6449 specified, so this should help the quality of the hashing a bit.
6450
b312a492
PE
6451 * emacs.c: Integer overflow minor fix.
6452 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6453 Define only if GNU_LINUX.
6454 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6455
dfd153ae
PE
6456 * dispnew.c: Integer signedness and overflow fixes.
6457 Remove unnecessary forward decls, that were a maintenance hassle.
6458 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6459 All uses changed.
6460 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6461 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6462 (prepare_desired_row, line_draw_cost):
6463 Use int, not unsigned, where either works.
6464 (save_current_matrix, restore_current_matrix):
6465 Use ptrdiff_t, not size_t, where either works.
6466 (init_display): Check for overflow more accurately, and without
6467 relying on undefined behavior.
6468
a81d11a3
PE
6469 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6470 Remove, replacing with the new symbols in lisp.h. All uses changed.
6471 * fileio.c (make_temp_name):
6472 * filelock.c (lock_file_1, lock_file):
6473 * xdisp.c (message_dolog):
6474 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6475 Use pMd etc. instead.
6476 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6477 replacing the pWIDE etc. symbols removed from editfns.c.
6478
3300e6fd
PE
6479 * keyboard.h (num_input_events): Now uintmax_t.
6480 This is (very slightly) less likely to mess up due to wraparound.
6481 All uses changed.
6482
fd05c7e9
PE
6483 * buffer.c: Integer signedness fixes.
6484 (alloc_buffer_text, enlarge_buffer_text):
6485 Use ptrdiff_t rather than size_t when either will do, as we prefer
6486 signed integers.
6487
903fe15d
PE
6488 * alloc.c: Integer signedness and overflow fixes.
6489 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6490 (__malloc_size_t): Default to size_t, not to int.
6491 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6492 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6493 Prefer ptrdiff_t to size_t when either would do, as we prefer
6494 signed integers.
6495 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6496 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6497 Now const. Initialize with values that are in range even if char
6498 is signed.
6499 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6500 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6501 These functions do the right thing with sizes > 2**32.
6502 (check_depth): Now ptrdiff_t, not int.
6503 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6504 Adjust to new way of storing sizes. Check for size overflow bugs
6505 in rest of code.
6506 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6507 slightly wrong anyway, as it missed one instance of
6508 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6509 (refill_memory_reserve): Omit needless cast to size_t.
6510 (mark_object_loop_halt): Mark as externally visible.
6511
ac82cc6a
PE
6512 * xselect.c: Integer signedness and overflow fixes.
6513 (Fx_register_dnd_atom, x_handle_dnd_message):
6514 Use ptrdiff_t, not size_t, since we prefer signed.
6515 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6516 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6517 x_dnd_atoms_size and x_dnd_atoms_length.
6518
c2d1e36d
PE
6519 * doprnt.c: Prefer signed to unsigned when either works.
6520 * eval.c (verror):
6521 * doprnt.c (doprnt):
6522 * lisp.h (doprnt):
6523 * xdisp.c (vmessage):
6524 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6525 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6526 prefer signed arithmetic to avoid comparison confusion.
6527 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6528 but is a bit tricky.
6529
0e926e56
PE
6530 Assume freestanding C89 headers, string.h, stdlib.h.
6531 * data.c, doprnt.c, floatfns.c, print.c:
6532 Include float.h unconditionally.
6533 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6534 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6535 * regex.c: Likewise for stddef.h, string.h.
6536 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6537 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6538 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6539 (STDC_HEADERS): Remove obsolete defines.
6540 * sysdep.c: Include limits.h unconditionally.
6541
9cfdb3ec
PE
6542 Assume support for memcmp, memcpy, memmove, memset.
6543 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6544 * regex.c (memcmp, memcpy):
6545 Remove; we assume C89 now.
6546
6547 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6548 (__malloc_safe_bcopy): Remove; no longer needed.
6549
cf950e6b 6550 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6551 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6552 well either way, and we prefer signed to unsigned.
6553
dbf38e02
LMI
65542011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6555
6556 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6557 closes the connection while we're reading (bug#9182).
6558
d6f0886c 65592011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6560
d6f0886c
JD
6561 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6562 are specified (Bug#9168).
24e0f6b1 6563
2eb1f9e6
PE
65642011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6565
6566 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6567 Found by GCC static checking and --with-wide-int on a 32-bit host.
6568
22381272 65692011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6570
6571 * xdisp.c (compute_display_string_pos): Fix logic of caching
6572 previous display string position. Initialize cached_prev_pos to
6573 -1. Fixes slow-down at the beginning of a buffer.
6574
f25e39b4
EZ
65752011-07-24 Eli Zaretskii <eliz@gnu.org>
6576
6577 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6578 for attrs[LFACE_FONTSET_INDEX].
6579
04c4b52e
PE
65802011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6581
6582 * xml.c (parse_region): Remove unused local
6583 that was recently introduced.
6584
c1734fbd
EZ
65852011-07-23 Eli Zaretskii <eliz@gnu.org>
6586
be18c5a5
EZ
6587 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6588 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6589
c1734fbd
EZ
6590 * xdisp.c (move_it_in_display_line_to): Record the best matching
6591 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6592 exit if none of the characters scanned was an exact match.
6593 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6594 when exact match is impossible due to invisible text, and the
6595 lines are truncated.
6596
a258d627
JD
65972011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6598
6599 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6600 for OSX >= 10.7.
6601
b6d5a689
EZ
66022011-07-22 Eli Zaretskii <eliz@gnu.org>
6603
0f74f785
EZ
6604 Fix a significant slow-down of cursor motion with C-n, C-p,
6605 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6606 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6607 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6608 (next_element_from_buffer): Call compute_stop_pos_backwards to
6609 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6610 base_level_stop.
6611 (reseat): Don't look for prev_stop, as that could mean a very long
6612 run.
6613 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6614 <cached_disp_overlay_modiff>: Cache for last found display string
6615 position.
551918c1 6616 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6617 about the same buffer in the same area of character positions, and
6618 the buffer wasn't changed since the time the display string
6619 position was cached.
551918c1 6620
b2d0c91a
EZ
66212011-07-22 Eli Zaretskii <eliz@gnu.org>
6622
6623 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6624 is an integer, which is important for empty lines. (Bug#9149)
6625
043604ee
CY
66262011-07-22 Chong Yidong <cyd@stupidchicken.com>
6627
6628 * frame.c (Fmodify_frame_parameters): In tty case, update the
6629 default face if necessary (Bug#4238).
6630
da4adb04
CY
66312011-07-21 Chong Yidong <cyd@stupidchicken.com>
6632
6633 * editfns.c (Fstring_to_char): No need to explain what a character
6634 is in the docstring (Bug#6576).
6635
9abd0532
LMI
66362011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6637
6638 * xml.c (parse_region): Make sure we always return a tree.
6639
36881d16
HK
66402011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6641
6642 * xml.c (parse_region): If a document contains only comments,
6643 return that, too.
6644
1e98674d
LMI
66452011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6646
6647 * xml.c (make_dom): Return comments, too.
6648
590bd467
PE
66492011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6650
6651 Port to OpenBSD.
6652 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6653 and the surrounding thread.
6654 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6655 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6656 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6657 timer goes off.
6658 * s/openbsd.h (BROKEN_SIGIO): Define.
6659 * unexelf.c (unexec) [__OpenBSD__]:
6660 Don't update the .mdebug section of the Alpha COFF symbol table.
6661
f41628b2
LMI
66622011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6663
6664 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6665 (bug#8460).
6666
b59b67c5
PE
66672011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6668
15e3a074
PE
6669 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6670 This fixes some race conditions on the permissions of any newly
6671 created file.
6672
41bed37d
PE
6673 * alloc.c (valid_pointer_p): Use pipe, not open.
6674 This fixes some permissions issues when debugging.
6675
b59b67c5
PE
6676 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6677 If fchown fails to set both uid and gid, try to set just gid,
6678 as that is sometimes allowed. Adjust the file's mode to eliminate
6679 setuid or setgid bits that are inappropriate if fchown fails.
6680
925a6be7
SM
66812011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6682
6683 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6684 to compare Lisp_Objects.
6685 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6686 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6687 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6688
52968808
AS
66892011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6690
0a6a104b
AS
6691 * lread.c (read_integer): Unread even EOF character.
6692 (read1): Likewise. Properly record start position of symbol.
6693
52968808
AS
6694 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6695 symbol character follows.
6696
9e381cdd
PE
66972011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6698
6699 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6700 This works around a problem with the previous change to Fcopy_file.
6701 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6702 and without this change, GCC might complain about discarding
6703 fchown's return value.
6704
b5641435
JB
67052011-07-16 Juanma Barranquero <lekktu@gmail.com>
6706
6707 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6708
a8031457
PE
67092011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6710
6711 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6712
dd889327
LMI
67132011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6714
750c33f7
LMI
6715 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6716 it's used from the C level.
6717
dd889327
LMI
6718 * process.c: Use the same condition for POLL_FOR_INPUT in both
6719 keyboard.c and process.c (bug#1858).
6720
87e86684
LM
67212011-07-09 Lawrence Mitchell <wence@gmx.li>
6722
6723 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6724 (Fgnutls_boot): Use it.
6725
64348f40
AS
67262011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6727
6728 * doc.c (Fsubstitute_command_keys): Revert last change.
6729
1d698799
LMI
67302011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6731
f863868c
LMI
6732 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6733 quotes the next character, and doesn't affect other longer
6734 sequences (bug#8935).
6735
1d698799
LMI
6736 * lread.c (syms_of_lread): Clarify that is isn't only
6737 `eval-buffer' and `eval-defun' that's affected by
6738 `lexical-binding' (bug#8460).
6739
aa4b6df6
EZ
67402011-07-15 Eli Zaretskii <eliz@gnu.org>
6741
6742 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6743 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6744
5d856da6
PE
67452011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6746
ad6042bb
PE
6747 Fix minor problems found by static checking.
6748 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6749 (elsz): Now a signed constant, not a size_t var. We prefer signed
6750 types to unsigned, to avoid integer comparison confusion. Without
6751 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6752 "cannot optimize loop, the loop counter may overflow", a symptom
6753 of the confusion.
f00bbb22 6754 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6755 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6756
6468f31c
LMI
67572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6758
49080b10
LMI
6759 * search.c (Fre_search_backward): Mention `case-fold-search' in
6760 all the re_search_* functions (bug#8138).
6761
6468f31c
LMI
6762 * keyboard.c (Fopen_dribble_file): Document when the file is
6763 closed (bug#8056).
6764
c965adc5
EZ
67652011-07-14 Eli Zaretskii <eliz@gnu.org>
6766
df9733bf
EZ
6767 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6768 bidi_cache_idx.
6769
0bb23927
EZ
6770 Support bidi reordering of display and overlay strings.
6771 * xdisp.c (compute_display_string_pos)
6772 (compute_display_string_end): Accept additional argument STRING.
6773 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6774 (reseat_to_string): Initialize bidi_it->string.s and
6775 bidi_it->string.schars.
6776 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6777 NULL (avoids a crash in bidi_paragraph_init).
6778 Initialize itb.string.lstring.
0bb23927
EZ
6779 (init_iterator): Call bidi_init_it only of a valid
6780 buffer position was specified. Initialize paragraph_embedding to
6781 L2R.
6782 (reseat_to_string): Initialize the bidi iterator.
6783 (display_string): If we need to ignore text properties of
6784 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6785 original value of -1 will not work with bidi.)
6786 (compute_display_string_pos): First arg is now struct
6787 `text_pos *'; all callers changed. Support display properties on
6788 Lisp strings.
6789 (compute_display_string_end): Support display properties on Lisp
6790 strings.
6791 (init_iterator, reseat_1, reseat_to_string): Initialize the
6792 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6793 when iterating on a string not from display properties).
640c8776
SM
6794 (compute_display_string_pos, compute_display_string_end):
6795 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6796 arrow keys.
6797 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6798 base_level_stop; instead, set base_level_stop to BEGV.
6799 Fixes crashes in vertical-motion.
0bb23927
EZ
6800 (next_element_from_buffer): Improve commentary for when
6801 the iterator is before prev_stop.
6802 (init_iterator): Initialize bidi_p from the default value of
6803 bidi-display-reordering, not from buffer-local value. Use the
6804 buffer-local value only if initializing for buffer iteration.
6805 (handle_invisible_prop): Support invisible properties on strings
6806 that are being bidi-reordered.
6807 (set_iterator_to_next): Support bidi reordering of C strings and
6808 Lisp strings.
6809 (next_element_from_string): Support bidi reordering of Lisp
6810 strings.
6811 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6812 (display_string): Support display of R2L glyph rows.
6813 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6814 (init_iterator): Don't initialize it->bidi_p for strings
6815 here.
6816 (reseat_to_string): Initialize it->bidi_p for strings here.
6817 (next_element_from_string, next_element_from_c_string)
6818 (next_element_from_buffer): Add xassert's for correspondence
6819 between IT's object being iterated and it->bidi_it.string
6820 structure.
6821 (face_before_or_after_it_pos): Support bidi iteration.
6822 (next_element_from_c_string): Handle the case of the first string
6823 character that is not the first one in the visual order.
6824 (get_visually_first_element): New function, refactored from common
6825 parts of next_element_from_buffer, next_element_from_string, and
6826 next_element_from_c_string.
6827 (tool_bar_lines_needed, redisplay_tool_bar)
6828 (display_menu_bar): Force left-to-right direction. Add a FIXME
6829 comment for making that be controlled by a user option.
6830 (push_it, pop_it): Save and restore the state of the
6831 bidi iterator. Save and restore the bidi_p flag.
6832 (pop_it): Iterate out of display property for string iteration as
6833 well.
6834 (iterate_out_of_display_property): Support iteration over strings.
6835 (handle_single_display_spec): Set up it->bidi_it for iteration
6836 over a display string, and call bidi_init_it.
6837 (handle_single_display_spec, next_overlay_string)
6838 (get_overlay_strings_1, push_display_prop): Set up the bidi
6839 iterator for displaying display or overlay strings.
6840 (forward_to_next_line_start): Don't use the shortcut if
6841 bidi-iterating.
6842 (back_to_previous_visible_line_start): If handle_display_prop
6843 pushed the iterator stack, restore the internal state of the bidi
6844 iterator by calling bidi_pop_it same number of times.
6845 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6846 and we are bidi-iterating, don't decrement the iterator position;
6847 instead, set the first_elt flag in the bidi iterator, to produce
6848 the same effect.
6849 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6850 (push_display_prop): xassert that we are iterating a buffer.
6851 (push_it, pop_it): Save and restore paragraph_embedding member.
6852 (handle_single_display_spec, next_overlay_string)
6853 (get_overlay_strings_1, reseat_1, reseat_to_string)
6854 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6855 correctly. Don't assume unibyte strings are not bidi-reordered.
6856 (compute_display_string_pos)
6857 (compute_display_string_end): Fix handling the case of C string.
6858 (push_it, pop_it): Save and restore from_disp_prop_p.
6859 (handle_single_display_spec, push_display_prop): Set the
6860 from_disp_prop_p flag.
6861 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6862 (pop_it): Call iterate_out_of_display_property only if we are
6863 popping after iteration over a string that came from a display
6864 property. Fix a typo in popping stretch info. Add an assertion
6865 for verifying that the iterator position is in sync with the bidi
6866 iterator.
6867 (handle_single_display_spec, get_overlay_strings_1)
6868 (push_display_prop): Fix initialization of paragraph direction for
6869 string when that of the parent object is not yet determined.
6870 (reseat_1): Call bidi_init_it to resync the bidi
6871 iterator with IT's position. (Bug#7616)
6872 (find_row_edges): If ROW->start.pos gives position
6873 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6874 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6875 Reset the from_disp_prop_p flag.
6876 (SAVE_IT, RESTORE_IT): New macros.
6877 (pos_visible_p, face_before_or_after_it_pos)
6878 (back_to_previous_visible_line_start)
6879 (move_it_in_display_line_to, move_it_in_display_line)
6880 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6881 (try_scrolling, redisplay_window, display_line): Use them when
6882 saving a temporary copy of the iterator and restoring it back.
6883 (back_to_previous_visible_line_start, reseat_1)
6884 (init_iterator): Empty the bidi cache "stack".
6885 (move_it_in_display_line_to): If iterator ended up at
6886 EOL, but we never saw any buffer positions smaller than
6887 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6888 motion in bidi-reordered lines.
6889 (move_it_in_display_line_to): Record prev_method and prev_pos
6890 immediately before the call to set_iterator_to_next. Fixes cursor
6891 motion in bidi-reordered lines with stretch glyphs and strings
6892 displayed in margins. (Bug#8133) (Bug#8867)
6893 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6894 TO_CHARPOS.
640c8776
SM
6895 (pos_visible_p): Support positions in bidi-reordered lines.
6896 Save and restore bidi cache.
0bb23927
EZ
6897
6898 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6899 (bidi_paragraph_info): Delete unused struct.
6900 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6901 (bidi_cache_start): New variable.
6902 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6903 to zero.
6904 (bidi_cache_fetch_state, bidi_cache_search)
6905 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6906 (bidi_cache_find, bidi_peek_at_next_level)
6907 (bidi_level_of_next_char, bidi_find_other_level_edge)
6908 (bidi_move_to_visually_next): Compare cache index with
6909 bidi_cache_start rather than with zero.
6910 (bidi_fetch_char): Accept new argument STRING; all callers
6911 changed. Support iteration over a string. Support strings with
6912 display properties. Support unibyte strings. Fix the type of
6913 `len' according to what STRING_CHAR_AND_LENGTH expects.
6914 (bidi_paragraph_init, bidi_resolve_explicit_1)
6915 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6916 (bidi_level_of_next_char, bidi_move_to_visually_next):
6917 Support iteration over a string.
0bb23927
EZ
6918 (bidi_set_sor_type, bidi_resolve_explicit_1)
6919 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6920 can now be zero (for strings); special values 0 and -1 were
6921 changed to -1 and -2, respectively.
6922 (bidi_char_at_pos): New function.
6923 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6924 Call it instead of FETCH_MULTIBYTE_CHAR.
6925 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6926 initialized to valid values.
6927 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6928 values.
6929 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6930 the test for valid cached positions. Fix the logic for looking up
6931 the sentinel state in the cache. GCPRO the Lisp string we are
6932 iterating.
6933 (bidi_push_it, bidi_pop_it): New functions.
6934 (bidi_initialize): Initialize the bidi cache start stack pointer.
6935 (bidi_cache_ensure_space): New function, refactored from part of
6936 bidi_cache_iterator_state. Don't assume the required size is just
6937 one BIDI_CACHE_CHUNK away.
6938 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6939 (bidi_count_bytes, bidi_char_at_pos): New functions.
6940 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6941 always valid if bidi_cache_idx is valid.
6942 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6943 is valid if it's going to be used.
6944 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6945 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6946 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6947 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6948 (bidi_find_other_level_edge, bidi_cache_start_stack):
6949 All variables related to cache indices are now EMACS_INT.
c965adc5 6950
0bb23927
EZ
6951 * dispextern.h (struct bidi_string_data): New structure.
6952 (struct bidi_it): New member `string'. Make flag members be 1-bit
6953 fields, and put them last in the struct.
640c8776
SM
6954 (compute_display_string_pos, compute_display_string_end):
6955 Update prototypes.
0bb23927
EZ
6956 (bidi_push_it, bidi_pop_it): Add prototypes.
6957 (struct iterator_stack_entry): New members bidi_p,
6958 paragraph_embedding, and from_disp_prop_p.
6959 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6960 (bidi_shelve_cache, bidi_unshelve_cache):
6961 Declare prototypes.
0bb23927
EZ
6962
6963 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6964 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6965 and vector-like objects.
6966
6967 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6968 cache around display iteration.
6969
6970 * window.c (Fwindow_end, window_scroll_pixel_based)
6971 (displayed_window_lines, Frecenter): Save and restore the bidi
6972 cache around display iteration.
6973
3bbd2265
LMI
69742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6975
6976 * editfns.c (Fdelete_region): Clarify the use of the named
6977 parameters (bug#6788).
6978
adc47434
MR
69792011-07-14 Martin Rudalics <rudalics@gmx.at>
6980
6981 * indent.c (Fvertical_motion): Set and restore w->pointm when
6982 saving and restoring the window's buffer (Bug#9006).
6983
837c31f8
LMI
69842011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6985
6986 * editfns.c (Fstring_to_char): Clarify just what is returned
6987 (bug#6576). Text by Eli Zaretskii.
6988
ac389d0c
JB
69892011-07-13 Juanma Barranquero <lekktu@gmail.com>
6990
6991 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6992
0be0ce47
EZ
69932011-07-13 Eli Zaretskii <eliz@gnu.org>
6994
6995 * buffer.c (mmap_find): Fix a typo.
6996
cd18e7e3
JB
69972011-07-13 Johan Bockgård <bojohan@gnu.org>
6998
6999 Fix execution of x selection hooks.
7000 * xselect.c (Qx_lost_selection_functions)
7001 (Qx_sent_selection_functions): New vars.
7002 (syms_of_xselect): DEFSYM them.
7003 (x_handle_selection_request): Pass Qx_sent_selection_functions
7004 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7005 (x_handle_selection_clear,x_clear_frame_selections):
7006 Pass Qx_lost_selection_functions rather than
7007 Vx_lost_selection_functions to Frun_hook_with_args.
7008
47ea7f44
PE
70092011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7010
ac389d0c 7011 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7012 The old code sometimes used this field without initializing it.
7013
47ea7f44
PE
7014 * alloc.c (gc_sweep): Don't read past end of array.
7015 In theory, the old code could also have corrupted Emacs internals,
7016 though it'd be very unlikely.
7017
bc985c87
AS
70182011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7019
7020 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7021 argument. (Bug#4026)
bc985c87 7022
0cf34688
LMI
70232011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7024
b3dadd76
LMI
7025 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7026 key" (bug#4257).
7027
0cf34688
LMI
7028 * window.c (Fset_window_start): Doc fix (bug#4199).
7029 (Fset_window_hscroll): Ditto.
7030
270768cd
PE
70312011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7032
077e3dda 7033 Fix minor new problems caught by GCC 4.6.1.
270768cd 7034 * term.c (init_tty): Remove unused local.
490011a6 7035 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7036 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7037 not used otherwise.
270768cd 7038
b1f58454
CY
70392011-07-12 Chong Yidong <cyd@stupidchicken.com>
7040
7041 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7042
22b9578d
LMI
70432011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7044
6e70ab07
LMI
7045 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7046 are the mini-buffer and the echo area (bug#3320).
7047
22b9578d
LMI
7048 * term.c (init_tty): Remove support for supdup, c10 and perq
7049 terminals, which are no longer supported (bug#1482).
7050
8974cc9f
JB
70512011-07-10 Johan Bockgård <bojohan@gnu.org>
7052
7053 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7054
a560d974
JD
70552011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7056
7057 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7058 for non-popups (Bug#3642).
7059
1dae0f0a
AS
70602011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7061
268c2c36 7062 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7063 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7064 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7065 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7066 * data.c (fmod): Likewise.
7067 * dispnew.c (swap_glyphs_in_rows): Likewise.
7068 * emacs.c (memory_warning_signal): Likewise.
7069 * floatfns.c (float_error): Likewise.
7070 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7071 (otf_open, font_otf_capability, generate_otf_features)
7072 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7073 Likewise.
7074 * image.c (pbm_read_file): Likewise.
7075 * indent.c (string_display_width): Likewise.
7076 * intervals.c (check_for_interval, search_for_interval)
7077 (inc_interval_count, count_intervals, root_interval)
7078 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7079 * lread.c (defalias): Likewise.
268c2c36 7080 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7081 * regex.c (set_image_of_range_1, set_image_of_range)
7082 (regex_grow_registers): Likewise.
7083 * sysdep.c (strerror): Likewise.
7084 * termcap.c (valid_filename_p, tprint, main): Likewise.
7085 * tparam.c (main): Likewise.
7086 * unexhp9k800.c (run_time_remap, save_data_space)
7087 (update_file_ptrs, read_header, write_header, calculate_checksum)
7088 (copy_file, copy_rest, display_header): Likewise.
7089 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7090 Likewise.
7091 * xdisp.c (check_it): Likewise.
7092 * xfaces.c (register_color, unregister_color, unregister_colors):
7093 Likewise.
7094 * xfns.c (print_fontset_result): Likewise.
7095 * xrdb.c (member, fatal, main): Likewise.
7096
99033785
PE
70972011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7098
7099 Fix minor problems found by static checking (Bug#9031).
7100 * chartab.c (char_table_set_range, map_sub_char_table):
7101 Remove unused locals.
7102 (uniprop_table): Now static.
7103 * composite.c (_work_char): Remove unused static var.
7104
9cb2ac56
JB
71052011-07-09 Juanma Barranquero <lekktu@gmail.com>
7106
7107 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7108
f25661f0
JD
71092011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7110
7111 * gtkutil.c (qttip_cb): Remove code without function.
7112
8278c4fe
EZ
71132011-07-09 Eli Zaretskii <eliz@gnu.org>
7114
7115 * w32.c (pthread_sigmask): New stub.
7116
1692ae2d 71172011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7118
8a6ebd58 7119 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7120 sigprocmask is portable only for single-threaded applications, and
7121 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7122 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7123 (LIBES): Use it.
7124 * callproc.c (Fcall_process):
7125 * process.c (create_process):
7126 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7127 Use pthread_sigmask, not sigprocmask.
123403e4 7128
1b854618
JD
71292011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7130
7131 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7132 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7133 wrong (Bug#8591).
7134
3fe4b549
JD
71352011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7136
0ce7e563
JD
7137 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7138 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7139 (xg_hide_tooltip): Fix comment.
7140
3fe4b549
JD
7141 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7142 in registerServicesMenuSendTypes.
7143 (validRequestorForSendType): Don't check ns_return_types.
7144
7145 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7146 ns_return_type.
7147
5df75e47
JR
71482011-07-08 Jason Rumney <jasonr@gnu.org>
7149
22610910
JR
7150 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7151 SH_SHOW for hidden windows (Bug#5482).
7152
5df75e47
JR
7153 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7154 frame struct members of non-existent frames (Bug#6284).
7155
699c10bd
JD
71562011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7157
4393663b
JD
7158 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7159 variable firstTime not needed on OSX >= 10.6.
7160 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7161 >= 10.5. Use setKnobProportion, setDoubleValue.
7162
7163 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7164 (MAC_OS_X_VERSION_10_5): Define if not defined.
7165 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7166 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7167 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7168
7169 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7170 cString and lossyCString on OSX >= 10.4
7171
58179cce 7172 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7173 sizeToFit on OSX >= 10.2.
7174
7175 * nsimage.m (allocInitFromFile): Don't use deprecated method
7176 bestRepresentationForDevice on OSX >= 10.6.
7177
7178 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7179 to avoid warning.
7180
7181 * emacs.c: Declare unexec_init_emacs_zone.
7182
a63e0781
JD
7183 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7184
699c10bd
JD
7185 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7186
7187 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7188 on svcsMenu (Bug#8842).
7189
7190 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7191 ns_return_types.
7192 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7193
7194 * nsterm.m (QUTF8_STRING): Declare.
7195 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7196 (validRequestorForSendType): Return type is (id).
7197 Change indexOfObjectIdenticalTo to indexOfObject.
7198 Check if we have local selection before returning self (Bug#8842).
7199 (writeSelectionToPasteboard): Put local selection into paste board
7200 if we have a local selection (Bug#8842).
7201 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7202
7203 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7204 (ns_get_local_selection): Declare.
7205
54e10184
LMI
72062011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7207
9888ff71
LMI
7208 * keymap.c (describe_map_tree): Don't insert a double newline at
7209 the end of the buffer (bug#1169) and return whether we inserted
7210 something.
7211
54e10184
LMI
7212 * callint.c (Fcall_interactively): Change "reading args" to
7213 "providing args" to try to clarify what it does (bug#1010).
7214
15fa4783
KH
72152011-07-07 Kenichi Handa <handa@m17n.org>
7216
7217 * composite.c (composition_compute_stop_pos): Ignore a static
7218 composition starting before CHARPOS (Bug#8915).
7219
7220 * xdisp.c (handle_composition_prop): Likewise.
7221
a8815b00
EZ
72222011-07-07 Eli Zaretskii <eliz@gnu.org>
7223
7224 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7225 (Bug#9015)
7226
ef7b981d 72272011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7228
7229 * character.h (unicode_category_t): New enum type.
7230
7231 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7232 (Qchar_code_property_table): New variable.
7233 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7234 (UNIPROP_COMPRESSED_FORM_P): New macros.
7235 (char_table_ascii): Uncompress the compressed values.
7236 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7237 Uncompress the compressed values.
ac389d0c 7238 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7239 (char_table_ref_and_range): Uncompress the compressed values.
7240 (sub_char_table_set): New arg is_uniprop. Callers changed.
7241 Uncompress the compressed values.
7242 (sub_char_table_set_range): Args changed. Callers changed.
7243 (char_table_set_range): Adjuted for the above change.
7244 (map_sub_char_table): Delete args default_val and parent. Add arg
7245 top. Give decoded values to a Lisp function.
640c8776 7246 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7247 values to a Lisp function. Gcpro more variables.
7248 (uniprop_table_uncompress)
7249 (uniprop_decode_value_run_length): New functions.
7250 (uniprop_decoder, uniprop_decoder_count): New variables.
7251 (uniprop_get_decoder, uniprop_encode_value_character)
7252 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7253 New functions.
7254 (uniprop_encoder, uniprop_encoder_count): New variables.
7255 (uniprop_get_encoder, uniprop_table)
7256 (Funicode_property_table_internal, Fget_unicode_property_internal)
7257 (Fput_unicode_property_internal): New functions.
7258 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7259 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7260 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7261 char-code-property-alist.
7262
640c8776 7263 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7264 Vunicode_category_table.
7265
640c8776 7266 * font.c (font_range): Adjust for the change of
c805dec0
KH
7267 Vunicode_category_table.
7268
76b397fb
DN
72692011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7270
7271 * m/iris4d.h: Remove file, move contents ...
7272 * s/irix6-5.h: ... here.
7273
22b4128e
PE
72742011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7275
7276 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7277 * alloc.c (mark_buffer):
7278 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7279 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7280 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7281 This isn't true in general, and it's particularly not true
7282 if Emacs is configured with --with-wide-int.
7283 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7284 New macros, used in the buffer.c change.
7285
869795d6
JD
72862011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7287
7288 * xsettings.c: Use both GConf and GSettings if both are available.
7289 (store_config_changed_event): Add comment.
7290 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7291 (store_tool_bar_style_changed): New functions.
5e617bc2 7292 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7293 (struct xsettings): Move font inside HAVE_XFT.
7294 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7295 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7296 Move inside HAVE_XFT.
640c8776 7297 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7298 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7299 also.
7300 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7301 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7302 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7303 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7304 (parse_settings): Move check for font inside HAVE_XFT.
7305 (read_settings, apply_xft_settings): Add comment.
7306 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7307 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7308 call store_font_name_changed.
7309 (xft_settings_event): Add comment.
7310 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7311 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7312 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7313 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7314 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7315 (xsettings_get_system_font, xsettings_get_system_normal_font):
7316 Add comment.
869795d6 7317
d8ed26bd
PE
73182011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7319
7320 Random fixes. E.g., (random) never returned negative values.
7321 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7322 subseconds part to the entropy, as that's a bit more random.
7323 Prefer signed to unsigned, since the signedness doesn't matter and
7324 in general we prefer signed. When given a limit, use a
7325 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7326 latter isn't right if USE_2_TAGS_FOR_INTS.
7327 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7328 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7329
cabf1cac
SM
73302011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7331
7332 * textprop.c (text_property_stickiness):
7333 Obey Vtext_property_default_nonsticky.
7334 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7335 * w32fns.c (syms_of_w32fns):
7336 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7337
6e9b2be9
PE
73382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7339
7340 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7341 This is more efficient than Ffile_directory_p and avoids a minor race.
7342
90186c68
LMI
73432011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7344
7c301272
LMI
7345 * buffer.c (Foverlay_put): Say what the return value is
7346 (bug#7835).
7347
c4f2d8d4
LMI
7348 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7349 is a directory before asking whether to use the file name
7350 (bug#7564).
ad637907
LMI
7351 (barf_or_query_if_file_exists): Make the "File is a directory"
7352 error be more correct.
c4f2d8d4 7353
90186c68
LMI
7354 * fns.c (Frequire): Remove the mention of the .gz files, since
7355 that's installation-specific, but keep the mention of
7356 `get-load-suffixes'.
7357
da64016e
PE
73582011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7359
7360 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7361 Report string overflow if the output is too long.
7362
7d47b580
JB
73632011-07-04 Juanma Barranquero <lekktu@gmail.com>
7364
a555cb87
JB
7365 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7366 (syms_of_gnutls): Remove duplicate DEFSYM for
7367 Qgnutls_bootprop_verify_hostname_error, an error for
7368 Qgnutls_bootprop_verify_error (which is no longer used).
7369
7d47b580
JB
7370 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7371 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7372 Also (re)move comments that are misplaced or no longer relevant.
7373
1e49bfab
LMI
73742011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7375
7376 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7377
1485f4c0
CY
73782011-07-03 Chong Yidong <cyd@stupidchicken.com>
7379
7380 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7381 and background color parameters if they have been changed.
7382
a9ab721e
LMI
73832011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7384
7385 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7386
cf7cff57
PE
73872011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7388
2e13213d
PE
7389 * xsettings.c (SYSTEM_FONT): Define only when used.
7390 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7391
cf7cff57
PE
7392 * keymap.c (access_keymap_1): Now static.
7393
7a8e04f7
CY
73942011-07-02 Chong Yidong <cyd@stupidchicken.com>
7395
7396 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7397 leave any prefix arg for the up event (Bug#1586).
7398
61352f62
LMI
73992011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7400
69bb1ef7
LMI
7401 * lread.c (syms_of_lread): Mention single symbols defined by
7402 `defvar' or `defconst' (bug#7154).
7403
61352f62 7404 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7405 (Frequire): Mention get-load-suffixes.
61352f62 7406
28545e04
MR
74072011-07-02 Martin Rudalics <rudalics@gmx.at>
7408
7409 * window.h (window): Remove clone_number slot.
7410 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7411 Remove.
7412 (make_parent_window, make_window, saved_window)
7413 (Fset_window_configuration, save_window_save): Don't deal with
7414 clone numbers.
7415 * buffer.c (Qclone_number): Remove declaration.
7416 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7417
3349e122
SM
74182011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7419
7420 Add multiple inheritance to keymaps.
7421 * keymap.c (Fmake_composed_keymap): New function.
7422 (Fset_keymap_parent): Simplify.
7423 (fix_submap_inheritance): Remove.
7424 (access_keymap_1): New function extracted from access_keymap to handle
7425 embedded parents and handle lists of maps.
7426 (access_keymap): Use it.
7427 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7428 (Fcopy_keymap): Handle embedded parents.
7429 (Fcommand_remapping, define_as_prefix): Simplify.
7430 (Fkey_binding): Simplify.
7431 (syms_of_keymap): Move minibuffer-local-completion-map,
7432 minibuffer-local-filename-completion-map,
7433 minibuffer-local-must-match-map, and
7434 minibuffer-local-filename-must-match-map to Elisp.
7435 (syms_of_keymap): Defsubr make-composed-keymap.
7436 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7437 (parse_menu_item): Trivial simplification.
7438
3279eb87
GM
74392011-07-01 Glenn Morris <rgm@gnu.org>
7440
7441 * Makefile.in (SETTINGS_LIBS): Fix typo.
7442
4550efdf
KI
74432011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7444
7445 * coding.c (Fencode_coding_string): Record the last coding system
7446 used, as the function doc string says (bug#8738).
7447
0949d2b6
JD
74482011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7449
7450 * xsettings.c (store_monospaced_changed): Take new font as arg and
7451 check for change against current_mono_font.
7452 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7453 (emacs_settings_constructor, emacs_settings_get_property)
7454 (emacs_settings_set_property, emacs_settings_class_init)
7455 (emacs_settings_init, gsettings_obj): Remove.
7456 (something_changedCB): New function for HAVE_GSETTINGS.
7457 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7458 with value as argument.
7459 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7460 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7461 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7462 "changed".
7463
7464 * xgselect.c: Add defined (HAVE_GSETTINGS).
7465 (xgselect_initialize): Ditto.
7466
7467 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7468 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7469 xg_select.
7470
bbc6b304
PE
74712011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7472
7473 * eval.c (struct backtrace): Simplify and port the data structure.
7474 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7475 signed bit field, as this assumption is not portable and it makes
7476 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7477 "char debug_on_exit : 1" as this is not portable either; instead,
7478 use the portable "unsigned int debug_on_exit : 1". Remove unused
7479 member evalargs. Remove obsolete comments about cc bombing out.
7480
9851bfc5
JD
74812011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7482
51bb811f 7483 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7484 Let HAVE_GSETTINGS override HAVE_GCONF.
7485 (store_monospaced_changed): New function.
7486 (EMACS_SETTINGS): A new type derived from GObject to handle
7487 GSettings notifications.
7488 (emacs_settings_constructor, emacs_settings_get_property)
7489 (emacs_settings_set_property, emacs_settings_class_init):
7490 New functions.
7491 (gsettings_client, gsettings_obj): New variables.
7492 (GSETTINGS_SCHEMA): New define.
7493 (something_changedCB): Call store_monospaced_changed.
7494 (init_gsettings): New function.
7495 (xsettings_initialize): Call init_gsettings.
7496 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7497 to NULL.
7498
640c8776 7499 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7500 GCONF_CFLAGS/LIBS.
7501
5386012d
MR
75022011-06-29 Martin Rudalics <rudalics@gmx.at>
7503
7504 * window.c (resize_root_window, grow_mini_window)
7505 (shrink_mini_window): Rename Qresize_root_window to
7506 Qwindow_resize_root_window and Qresize_root_window_vertically to
7507 Qwindow_resize_root_window_vertically.
7508
f13e0b08
PE
75092011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7510
7511 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7512
94515237
JB
75132011-06-27 Juanma Barranquero <lekktu@gmail.com>
7514
7515 * makefile.w32-in: Redesign dependencies so they reflect more
7516 clearly which files are directly included by each source file,
7517 and not through other includes.
7518
e43b6e43
MR
75192011-06-27 Martin Rudalics <rudalics@gmx.at>
7520
7521 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7522 (sort_overlays, overlay_strings): When an overlay's clone number
7523 matches the window's clone number process the overlay even if
7524 the overlay's window property doesn't match the current window.
7525
d68443dc
MR
7526 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7527 (Fwindow_hchild): Rename to Fwindow_left_child.
7528 (Fwindow_next): Rename to Fwindow_next_sibling.
7529 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7530 (resize_window_check): Rename to window_resize_check.
7531 (resize_window_apply): Rename to window_resize_apply.
7532 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7533 (Fdelete_other_windows_internal, resize_frame_windows)
7534 (Fsplit_window_internal, Fdelete_window_internal)
7535 (grow_mini_window, shrink_mini_window)
7536 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7537
c7e73be5
JD
75382011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7539
7540 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7541 (emacs_fixed_set_min_size): Remove.
7542 (emacs_fixed_new): Take frame as argument.
7543
7544 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7545 (_EmacsFixedPrivate): Remove minwidth/height.
7546 Add struct frame *f.
7547 (emacs_fixed_init): Initialize priv->f.
7548 (get_parent_class, emacs_fixed_set_min_size): Remove.
7549 (emacs_fixed_new): Set priv->f to argument.
7550 (emacs_fixed_get_preferred_width)
7551 (emacs_fixed_get_preferred_height): Use min_width/height from
7552 frames size_hint to set minimum and natural (Bug#8919).
7553 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7554 and use min_width/height from frames size_hint to set
7555 min_width/height (Bug#8919).
7556
7557 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7558 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7559 Fix indentation.
c7e73be5 7560
cf99dcf8
EZ
75612011-06-26 Eli Zaretskii <eliz@gnu.org>
7562
7563 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7564 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7565 called at ZV.
7566
029529ac
CY
75672011-06-26 Chong Yidong <cyd@stupidchicken.com>
7568
7569 * process.c (wait_reading_process_output): Bypass select if
7570 waiting for a cell while ignoring keyboard input, and input is
7571 pending. Suggested by Jan Djärv (Bug#8869).
7572
7a7ef429
PE
75732011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7574
7575 Use gnulib's dup2 module instead of rolling our own.
7576 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7577
11fdef7d 75782011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7579
7580 * dispnew.c (scrolling_window): Before scrolling, turn off a
7581 mouse-highlight in the window being scrolled.
7582
cd3520a4
JB
75832011-06-24 Juanma Barranquero <lekktu@gmail.com>
7584
7585 Move DEFSYM to lisp.h and use everywhere.
7586
7587 * character.h (DEFSYM): Move declaration...
7588 * lisp.h (DEFSYM): ...here.
7589
7590 * gnutls.c:
7591 * minibuf.c:
7592 * w32menu.c:
7593 * w32proc.c:
7594 * w32select.c: Don't include character.h.
7595
7596 * alloc.c (syms_of_alloc):
7597 * buffer.c (syms_of_buffer):
7598 * bytecode.c (syms_of_bytecode):
7599 * callint.c (syms_of_callint):
7600 * casefiddle.c (syms_of_casefiddle):
7601 * casetab.c (init_casetab_once):
7602 * category.c (init_category_once, syms_of_category):
7603 * ccl.c (syms_of_ccl):
7604 * cmds.c (syms_of_cmds):
7605 * composite.c (syms_of_composite):
7606 * dbusbind.c (syms_of_dbusbind):
7607 * dired.c (syms_of_dired):
7608 * dispnew.c (syms_of_display):
7609 * doc.c (syms_of_doc):
7610 * editfns.c (syms_of_editfns):
7611 * emacs.c (syms_of_emacs):
7612 * eval.c (syms_of_eval):
7613 * fileio.c (syms_of_fileio):
7614 * fns.c (syms_of_fns):
7615 * frame.c (syms_of_frame):
7616 * fringe.c (syms_of_fringe):
7617 * insdel.c (syms_of_insdel):
7618 * keymap.c (syms_of_keymap):
7619 * lread.c (init_obarray, syms_of_lread):
7620 * macros.c (syms_of_macros):
7621 * msdos.c (syms_of_msdos):
7622 * print.c (syms_of_print):
7623 * process.c (syms_of_process):
7624 * search.c (syms_of_search):
7625 * sound.c (syms_of_sound):
7626 * syntax.c (init_syntax_once, syms_of_syntax):
7627 * terminal.c (syms_of_terminal):
7628 * textprop.c (syms_of_textprop):
7629 * undo.c (syms_of_undo):
7630 * w32.c (globals_of_w32):
7631 * window.c (syms_of_window):
7632 * xdisp.c (syms_of_xdisp):
7633 * xfaces.c (syms_of_xfaces):
7634 * xfns.c (syms_of_xfns):
7635 * xmenu.c (syms_of_xmenu):
7636 * xsettings.c (syms_of_xsettings):
7637 * xterm.c (syms_of_xterm): Use DEFSYM.
7638
4228cf16
TZ
76392011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7640
cd3520a4 7641 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7642
7fcccf1e
PE
76432011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7644
7efb4e0e
PE
7645 Integer and buffer overflow fixes (Bug#8873).
7646
ff5844ad
PE
7647 * print.c (printchar, strout): Check for string overflow.
7648 (PRINTPREPARE, printchar, strout):
7649 Don't set size unless allocation succeeds.
7650
90532f02
PE
7651 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7652 for sizes. Check for string overflow more accurately.
7653 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7654
6d84508d
PE
7655 * macros.c: Integer and buffer overflow fixes.
7656 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7657 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7658 Use ptrdiff_t, not int, for sizes.
7659 Don't increment bufsize until after realloc succeeds.
7660 Check for size-calculation overflow.
7661 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7662
437b2cb4
PE
7663 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7664
8b9ac8b4
PE
7665 * lread.c: Integer overflow fixes.
7666 (read_integer): Radix is now EMACS_INT, not int,
7667 to improve quality of diagnostics for out-of-range radices.
7668 Calculate buffer size correctly for out-of-range radices.
7669 (read1): Check for integer overflow in radices, and in
7670 read-circle numbers.
82cb60d3
PE
7671 (read_escape): Avoid int overflow.
7672 (Fload, openp, read_buffer_size, read1)
7673 (substitute_object_recurse, read_vector, read_list, map_obarray):
7674 Use ptrdiff_t, not int, for sizes.
7675 (read1): Use EMACS_INT, not int, for sizes.
20270765 7676 Check for size overflow.
8b9ac8b4 7677
7fcccf1e
PE
7678 * image.c (cache_image): Check for size arithmetic overflow.
7679
bfbbd7e7
PE
7680 * lread.c: Integer overflow issues.
7681 (saved_doc_string_size, saved_doc_string_length)
7682 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7683 Now ptrdiff_t, not int.
7684 (read1): Don't assume doc string length fits in int. Check for
7685 out-of-range doc string lengths.
7686 (read_list): Don't assume file position fits in int.
39019e54 7687 (read_escape): Check for hex character overflow.
bfbbd7e7 7688
4e323265
LL
76892011-06-22 Leo Liu <sdl.web@gmail.com>
7690
7691 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7692 Move to minibuffer.el.
7693
85fece3e
PE
76942011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7695
20b84ce9 7696 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7697 The following patches are for when GLYPH_DEBUG && !XASSERT.
7698 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7699 * dispnew.c (flush_stdout):
7700 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7701 Mark as externally visible.
7702 * dispnew.c (check_window_matrix_pointers): Now static.
7703 * dispnew.c (window_to_frame_vpos):
7704 * xfns.c (unwind_create_frame):
7705 * xterm.c (x_check_font): Remove unused local.
7706 * scroll.c (CHECK_BOUNDS):
7707 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7708 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7709 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7710 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7711 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7712 Now static.
7713 (debug_method_add): Use va_list and vsprintf rather than relying
7714 on undefined behavior with wrong number of arguments.
7715 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7716 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7717 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7718 since we're not interested in debugging glyphs with old libraries.
7719 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7720 GCC 4.6.0's static checking.
7721
0766b489
PE
77222011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7723
31fd4b32
PE
7724 Integer overflow and signedness fixes (Bug#8873).
7725 A few related buffer overrun fixes, too.
7726
b79e8648
PE
7727 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7728
0766b489
PE
7729 * dispextern.h (struct face.stipple):
7730 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7731 (x_bitmap_mask, x_allocate_bitmap_record)
7732 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7733 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7734 (x_create_bitmap_from_xpm_data):
7735 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7736 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7737 (.bitmaps_last):
7738 * xfaces.c (load_pixmap):
7739 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7740 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7741 (.bitmaps_last, struct x_output.icon_bitmap):
7742 Use ptrdiff_t, not int, for bitmap indexes.
7743 (x_allocate_bitmap_record): Check for size overflow.
7744 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7745
b081724f
PE
7746 Use ptrdiff_t, not int, for overlay counts.
7747 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7748 * editfns.c (overlays_around, get_pos_property):
7749 * textprop.c (get_char_property_and_overlay):
7750 * xdisp.c (next_overlay_change, note_mouse_highlight):
7751 * xfaces.c (face_at_buffer_position):
21514da7
PE
7752 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7753 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7754 (Fnext_overlay_change, Fprevious_overlay_change)
7755 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7756 Use ptrdiff_t, not int, for sizes.
21514da7 7757 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7758
3de73e5e
PE
7759 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7760
2606c57b
PE
7761 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7762 (x_session_initialize): Do not assume string length fits in int.
7763
aaafe47a
PE
7764 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7765 This is unlikely, but can occur if DPI is outlandish.
7766
2674ddc8 7767 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7768 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7769
28154962
PE
7770 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7771 * xrdb.c (magic_file_p, search_magic_path):
7772 Omit last arg SUFFIX; it was always 0. All callers changed.
7773 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7774
7de51af5
PE
7775 * xfont.c (xfont_match): Avoid need for strlen.
7776
25ed6cc3
PE
7777 * xfns.c: Don't assume strlen fits in int.
7778 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7779
4eab31dd
PE
7780 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7781 not unsigned long, as we prefer signed integers. All callers changed.
7782 Detect integer overflow in repeat count.
7783 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7784 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7785
171e2a58
PE
7786 * termcap.c: Don't assume sizes fit in int and never overflow.
7787 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7788 (gobble_line): Check for size-calculation overflow.
7789
ad39faca 7790 * minibuf.c (Fread_buffer):
6e5bb2dc 7791 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7792 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7793 Don't assume string length fits in int.
7794
52c61c22 7795 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7796 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7797
b5b8c9e5
PE
7798 * font.c: Don't assume string length fits in int.
7799 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7800 Use ptrdiff_t, not int.
ccd6111c
PE
7801 (font_intern_prop): Don't assume string length fits in int.
7802 Don't assume integer property fits in fixnum.
7803 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7804
882f0d81 7805 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7806 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7807 Reformulate so as not to need the command string.
7808 Invoke gzip -cd rather than gunzip, as it's more portable.
7809 (lock_info_type, lock_file_1, lock_file):
7810 Don't assume pid_t and time_t fit in unsigned long.
7811 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7812 (current_lock_owner): Prefer signed type for sizes.
7813 Use memcpy, not strncpy, where memcpy is what is really wanted.
7814 Don't assume (via atoi) that time_t and pid_t fit in int.
7815 Check for time_t and/or pid_t out of range, e.g., via a network share.
7816 Don't alloca where an auto var works fine.
7817
93f4cf88
PE
7818 * fileio.c: Fix some integer overflow issues.
7819 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7820 Don't assume string length fits in int.
7821 (directory_file_name): Don't assume string length fits in long.
7822 (make_temp_name): Don't assume pid fits in int, or that its print
7823 length is less than 20.
7824
f3e92b69
PE
7825 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7826
1bfdaf10
PE
7827 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7828
35016e9a
PE
7829 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7830
3d1e65a1
PE
7831 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7832 We prefer signed integers, even for size calculations.
7833
0b963a93
PE
7834 * emacs.c: Don't assume string length fits in 'int'.
7835 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7836 (main): Don't invoke strlen when not needed.
7837
573f4b54
PE
7838 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7839 (XD_DEBUG_MESSAGE): Don't waste a byte.
7840
989f33ba
PE
7841 * callproc.c (getenv_internal_1, getenv_internal)
7842 (Fgetenv_internal):
965d34eb
PE
7843 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7844
e4d29b33
PE
7845 * lread.c (invalid_syntax): Omit length argument.
7846 All uses changed. This doesn't fix a bug, but it simplifies the
7847 code away from its former Hollerith-constant appearance, and it's
7848 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7849 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7850
eb49b136
PE
7851 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7852 This didn't break anything, but it didn't help either.
7853 It's confusing to put a bogus integer in a place where the actual
7854 value does not matter.
9f62aeb1 7855 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7856 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7857
15375a22
PE
7858 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7859 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7860 implementation.
b61cc01c
PE
7861 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7862 We prefer signed types, and the value cannot exceed the EMACS_INT
7863 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7864 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7865 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7866 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7867
53b2623d
PE
7868 * indent.c (sane_tab_width): New function.
7869 (current_column, scan_for_column, Findent_to, position_indentation)
7870 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7871 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7872
51cab52b 7873 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7874
f2ed8a70
PE
7875 * lisp.h (lint_assume): New macro.
7876 * composite.c (composition_gstring_put_cache):
7877 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7878
abe80cc6
PE
7879 * editfns.c, insdel.c:
7880 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7881
b02c740e
PE
7882 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7883
ebc96716
PE
7884 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7885
b4e50fa0 7886 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7887 Use much-faster test for byte-length change.
311d5d7c 7888 Don't assume string byte-length fits in 'int'.
a4cf38e4 7889 Check that character arg fits in 'int'.
85461888 7890 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7891
c0c1ee9f
PE
7892 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7893
a498d7f4
PE
7894 * fns.c (concat): Catch string overflow earlier.
7895 Do not rely on integer wraparound.
7896
51cab52b
PE
7897 * dispextern.h (struct it.overlay_strings_charpos)
7898 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7899 * xdisp.c (forward_to_next_line_start)
7900 (back_to_previous_visible_line_start)
7901 (reseat_at_next_visible_line_start, next_element_from_buffer):
7902 Don't arbitrarily truncate the value of 'selective' to int.
7903
76031fad
PE
7904 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7905
5eb55db9
PE
7906 * composite.c: Don't truncate sizes to 'int'.
7907 (composition_gstring_p, composition_reseat_it)
7908 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7909 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7910 not EMACS_UINT, for indexes.
5eb55db9 7911
0703a717
PE
7912 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7913
d6202519
PE
7914 * buffer.c: Include <verify.h>.
7915 (struct sortvec.priority, struct sortstr.priority):
8961a454 7916 Now EMACS_INT, not int.
c20998a7 7917 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7918 (struct sortstr.size, record_overlay_string)
7919 (struct sortstrlist.size, struct sortlist.used):
7920 Don't truncate size to int.
7921 (record_overlay_string): Check for size-calculation overflow.
d6202519 7922 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7923
d5a19415
JM
79242011-06-22 Jim Meyering <meyering@redhat.com>
7925
029529ac 7926 Don't leak an XBM-image-sized buffer
d5a19415
JM
7927 * image.c (xbm_load): Free the image buffer after using it.
7928
a9041e6c
PE
79292011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7930
7931 Port to Sun C.
7932 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7933 that Sun C diagnosed.
7934 * fns.c (secure_hash): Fix pointer signedness issue.
7935 * intervals.c (static_offset_intervals): New function.
7936 (offset_intervals): Use it.
7937
7f3f739f
LL
79382011-06-21 Leo Liu <sdl.web@gmail.com>
7939
7940 * deps.mk (fns.o):
7941 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7942 sha512.h.
7943
7944 * fns.c (secure_hash): Rename from crypto_hash_function and change
7945 the first arg to accept symbols.
5b66d427 7946 (Fsecure_hash): New primitive.
7f3f739f
LL
7947 (syms_of_fns): New symbols.
7948
76147d94
DD
79492011-06-20 Deniz Dogan <deniz@dogan.se>
7950
7951 * process.c (Fset_process_buffer): Clarify return value in
7952 docstring.
7953
7d7d0045
CY
79542011-06-18 Chong Yidong <cyd@stupidchicken.com>
7955
7956 * dispnew.c (add_window_display_history): Use BVAR.
7957
7958 * xdisp.c (debug_method_add): Use BVAR.
7959 (check_window_end, dump_glyph_matrix, dump_glyph)
7960 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7961
7962 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7963 Likewise.
7964
7965 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7966 check till after the cache is created in init_frame_faces.
7967
ff2bc410
SM
79682011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7969
7970 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7971
28177add
PE
79722011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7973
dd3482fe
PE
7974 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7975 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7976 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7977
393d71f3 7978 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7979 * fileio.c (Finsert_file_contents):
7980 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7981 Remove the old (too-loose) buffer overflow checks.
7982 They weren't needed, since make_gap checks for buffer overflow.
7983 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7984 The old code merely checked for Emacs fixnum overflow, and relied
7985 on undefined (wraparound) behavior. The new code avoids undefined
7986 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7987
2e6813b0 7988 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7989 Tune. Don't use wider integers than needed. Don't use alloca.
7990 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7991
599a9e4f
PE
7992 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7993
99561444
PE
7994 * insdel.c, lisp.h (buffer_overflow): New function.
7995 (insert_from_buffer_1, replace_range, replace_range_2):
7996 * insdel.c (make_gap_larger):
7997 * editfns.c (Finsert_char):
7998 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7999
28177add
PE
8000 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8001
e69dafad
PE
80022011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8003
4baa020d 8004 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8005
b1c46f02
PE
8006 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8007 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8008
e69dafad
PE
8009 * fileio.c: Don't assume EMACS_INT fits in off_t.
8010 (emacs_lseek): New static function.
8011 (Finsert_file_contents, Fwrite_region): Use it.
8012 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8013
566684ea
PE
8014 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8015
e6966cd6
PE
8016 * fns.c: Don't overflow int when computing a list length.
8017 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8018 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8019 truncation on 64-bit hosts. Check for QUIT every
8020 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8021 faster and is responsive enough.
8022 (Flength): Report an error instead of overflowing an integer.
8023 (Fsafe_length): Return a float if the value is not representable
8024 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8025 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8026 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8027
dd0b0efb
PE
8028 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8029 (header_size, word_size): New constants.
8030 (allocate_vectorlike): Don't check size overflow here.
8031 (allocate_vector): Check it here instead, since this is the only
8032 caller of allocate_vectorlike that could cause overflow.
8033 Check that the new vector's length is representable as a fixnum.
8034
86fe5cfe
PE
8035 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8036 The previous code was bogus. For example, next_almost_prime (32)
8037 returned 39, which is undesirable as it is a multiple of 3; and
8038 next_almost_prime (24) returned 25, which is a multiple of 5 so
8039 why was the code bothering to check for multiples of 7?
8040
80e88859
PE
8041 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8042
4a2f0ad6
PE
8043 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8044
f66c7cf8
PE
8045 Variadic C functions now count arguments with ptrdiff_t.
8046 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8047 Back then I didn't know that the Emacs coding style prefers signed int.
8048 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8049 were being counted with int, which may truncate counts on 64-bit
8050 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8051 * lisp.h (struct Lisp_Subr.function.aMANY)
8052 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8053 Arg counts are now ptrdiff_t, not size_t.
8054 All variadic functions and their callers changed accordingly.
8055 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8056 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8057 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8058 * callint.c (Fcall_interactively): Check arg count for overflow,
8059 to avoid potential buffer overrun. Use signed char, not 'int',
8060 for 'varies' array, so that we needn't bother to check its size
8061 calculation for overflow.
8062 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8063 * eval.c (apply_lambda):
8064 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8065 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8066 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8067
a1759b76
PE
8068 * callint.c (Fcall_interactively): Don't use index var as event count.
8069
d96be9fc
PE
8070 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8071 * mem-limits.h (SIZE): Remove; no longer used.
8072
a690a978 8073 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8074
578c21e6
PE
8075 Remove unnecessary casts.
8076 * xterm.c (x_term_init):
8077 * xfns.c (x_set_border_pixel):
8078 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8079 These aren't needed now that we assume ANSI C.
8080
96f53c6c
PE
8081 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8082 It's more likely to cause problems (due to unsigned overflow)
8083 than to cure them.
8084
83c77d31
PE
8085 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8086
ee2079f1
PE
8087 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8088
6da65536
PE
8089 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8090
7147c4a4
PE
8091 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8092
193e32d9
PE
8093 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8094
e5533da6
PE
8095 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8096
9910e595
PE
8097 GLYPH_CODE_FACE returns EMACS_INT, not int.
8098 * dispextern.h (merge_faces):
8099 * xfaces.c (merge_faces):
01103c44
PE
8100 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8101 Don't assume EMACS_INT fits in int.
9910e595 8102
2638320e
PE
8103 * character.h (CHAR_VALID_P): Remove unused parameter.
8104 * fontset.c, lisp.h, xdisp.c: All uses changed.
8105
045eb8d9
PE
8106 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8107
c1f134b5
PE
8108 * fns.c (concat): Minor tuning based on overflow analysis.
8109 This doesn't fix any bugs. Use int to hold character, instead
8110 of constantly refetching from Emacs object. Use XFASTINT, not
8111 XINT, for value known to be a character. Don't bother comparing
8112 a single byte to 0400, as it's always less.
8113
395fcb93 8114 * floatfns.c (Fexpt):
327eeec8
PE
8115 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8116
abbd3d23
PE
8117 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8118 for characters.
8119
684a03ef
PE
8120 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8121
0fed43f3
PE
8122 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8123 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8124 incorrectly succeed when S was a string, because 4294967386 was
8125 truncated before it was used.
8126
8fd02eb7
PE
8127 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8128 Otherwise, an out-of-range integer could cause undefined behavior
8129 on a 64-bit host.
8130
f8c86b69
PE
8131 * composite.c: Use int, not EMACS_INT, for characters.
8132 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8133 EMACS_INT, for values that are known to be in character range.
8134 This doesn't fix any bugs but is the usual style inside Emacs and
8135 may generate better code on 32-bit machines.
8136
34206dd2
PE
8137 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8138 This is for reasons similar to the recent CHAR_STRING fix.
8139 * charset.c (Fencode_char): Check that character arg is actually
8140 a character. Pass an int to ENCODE_CHAR.
8141 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8142 wider than 'int', as a compile-time check to prevent future regressions
8143 in this area.
8144
c5958d4c 8145 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8146
8147 Make sure a 64-bit char is never passed to CHAR_STRING.
8148 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8149 by silently ignoring the top 32 bits, allowing some values
8150 that were far too large to be valid characters.
8151 * character.h: Include <verify.h>.
8152 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8153 arguments are no wider than unsigned, as a compile-time check
8154 to prevent future regressions in this area.
8155 * data.c (Faset):
01103c44 8156 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8157 (Fsubst_char_in_region):
8158 * fns.c (concat):
8159 * xdisp.c (decode_mode_spec_coding):
8160 Adjust to CHAR_STRING's new requirement.
8161 * editfns.c (Finsert_char, Fsubst_char_in_region):
8162 * fns.c (concat): Check that character args are actually
8163 characters. Without this test, these functions did the wrong
8164 thing with wildly out-of-range values on 64-bit hosts.
8165
d37ca623
PE
8166 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8167 These casts should not be needed on 32-bit hosts, either.
8168 * keyboard.c (read_char):
8169 * lread.c (Fload): Remove casts to unsigned.
8170
ea204efb
PE
8171 * lisp.h (UNSIGNED_CMP): New macro.
8172 This fixes comparison bugs on 64-bit hosts.
8173 (ASCII_CHAR_P): Use it.
8174 * casefiddle.c (casify_object):
01103c44 8175 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8176 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8177 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8178 * dispextern.h (FACE_FROM_ID):
8179 * keyboard.c (read_char): Use UNSIGNED_CMP.
8180
41cb286c
PE
8181 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8182 not to EMACS_INT, to avoid GCC warning.
8183
4a1b9832
PE
8184 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8185
55daad71
PE
8186 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8187 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8188 isn't needed on 32-bit machines.
8f95c75c 8189
01103c44
PE
8190 * buffer.c (Fgenerate_new_buffer_name):
8191 Use EMACS_INT for count, not int.
0ceccced 8192 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8193
8194 * data.c (Qcompiled_function): Now static.
8195
c6f072e7
PE
8196 * window.c (window_body_lines): Now static.
8197
20ce5912
PE
8198 * image.c (gif_load): Rename local to avoid shadowing.
8199
9c4c5f81
PE
8200 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8201 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8202 * alloc.c (make_save_value): Integer argument is now of type
8203 ptrdiff_t, not int.
8204 (mark_object): Use ptrdiff_t, not int.
8205 * lisp.h (pD): New macro.
8206 * print.c (print_object): Use it.
8207
c0c5c8ae
PE
8208 * alloc.c: Use EMACS_INT, not int, to count objects.
8209 (total_conses, total_markers, total_symbols, total_vector_size)
8210 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8211 (total_free_floats, total_floats, total_free_intervals)
8212 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8213 Now EMACS_INT, not int. All uses changed.
8214 (Fgarbage_collect): Compute overall total using a double, so that
8215 integer overflow is less likely to be a problem. Check for overflow
8216 when converting back to an integer.
5a25e253
PE
8217 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8218 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8219 These were 'int' variables that could overflow on 64-bit hosts;
8220 they were never used, so remove them instead of repairing them.
211a0b2a 8221 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8222 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8223 Previously, this ceilinged at INT_MAX, but that doesn't work on
8224 64-bit machines.
e46bb31a 8225 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8226
c78baabf 8227 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8228 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8229 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8230 when a (possibly-narrower) signed value would do just as well.
8231 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8232
c9d624c6
PE
8233 * alloc.c: Catch some string size overflows that we were missing.
8234 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8235 for convenience in STRING_BYTES_MAX.
8236 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8237 The definition here is exact; the one in lisp.h was approximate.
8238 (allocate_string_data): Check for string overflow. This catches
8239 some instances we weren't catching before. Also, it catches
8240 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8241 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8242 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8243
c9d624c6
PE
8244 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8245 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8246 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8247
353032ce
PE
8248 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8249
2bccce07
PE
8250 * alloc.c (Fmake_string): Check for out-of-range init.
8251
0ac30604
SM
82522011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8253
8254 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8255
c195f2de
JD
82562011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8257
8258 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8259 xg_get_default_scrollbar_width.
8260
8261 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8262 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8263 (style_changed_cb): Call update_theme_scrollbar_width and call
8264 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8265 all frames (Bug#8505).
8266 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8267 Call gtk_window_set_resizable if HAVE_GTK3.
8268 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8269 and height if HAVE_GTK3 (Bug#8505).
8270 (scroll_bar_width_for_theme): New variable.
8271 (update_theme_scrollbar_width): New function.
8272 (xg_get_default_scrollbar_width): Move code to
8273 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8274 (xg_initialize): Call update_theme_scrollbar_width.
8275
8276 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8277
8278 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8279
e10ac9f1
MR
82802011-06-12 Martin Rudalics <rudalics@gmx.at>
8281
8282 * frame.c (make_frame): Call other_buffer_safely instead of
8283 other_buffer.
8284
8285 * window.c (temp_output_buffer_show): Call display_buffer with
8286 second argument Vtemp_buffer_show_specifiers and reset latter
8287 immediately after the call.
8288 (Vtemp_buffer_show_specifiers): New variable.
8289 (auto_window_vscroll_p, next_screen_context_lines)
8290 (Vscroll_preserve_screen_position): Remove leading asterisks from
8291 doc-strings.
8292
2d3c217e 82932011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8294
7b7f97e8 8295 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8296 * buffer.c (Qclone_number): Remove for now, as it's unused.
8297 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8298 (record_buffer): Remove unused local.
8299 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8300 (set_frame_buffer_list): Remove; unused.
8301 * frame.h (other_visible_frames): Remove decl.
8302 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8303 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8304 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8305 if HAVE_GPM.
8306 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8307 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8308 Define only if HAVE_GPM.
8309 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8310 (update_hints_inhibit): Remove; never set. All uses removed.
8311 * widgetprv.h (emacsFrameClassRec): Remove decl.
8312 * window.c (delete_deletable_window): Now returns void, since it
8313 wasn't returning anything.
8314 (compare_window_configurations): Remove unused locals.
8315 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8316 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8317 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8318 the same widths as pointers. This follows up on the 2011-05-06 patch.
8319 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8320 * xterm.h: Likewise.
8321 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8322
1384b89e
JB
83232011-06-12 Juanma Barranquero <lekktu@gmail.com>
8324
8325 * makefile.w32-in: Update dependencies.
8326 (LISP_H): Add lib/intprops.h.
8327
1100a63c
CY
83282011-06-11 Chong Yidong <cyd@stupidchicken.com>
8329
8330 * image.c (gif_load): Add animation frame delay to the metadata.
8331 (syms_of_image): Use DEFSYM. New symbol `delay'.
8332
6198ccd0
MR
83332011-06-11 Martin Rudalics <rudalics@gmx.at>
8334
8335 * window.c (delete_deletable_window): Re-add.
8336 (Fset_window_configuration): Rewrite to handle dead buffers and
8337 consequently deletable windows.
8338 (window_tree, Fwindow_tree): Remove. Supply functionality in
8339 window.el.
8340 (compare_window_configurations): Simplify code.
8341
b6e3633c
AS
83422011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8343
1ab0dee5
AS
8344 * image.c (imagemagick_load_image): Fix type mismatch.
8345 (Fimagemagick_types): Likewise.
8346
b6e3633c
AS
8347 * window.h (replace_buffer_in_windows): Declare.
8348
9397e56f
MR
83492011-06-11 Martin Rudalics <rudalics@gmx.at>
8350
8351 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8352 Qclone_number. Remove external declaration of Qdelete_window.
8353 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8354 code.
640c8776
SM
8355 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8356 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8357 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8358 buffer list implementation.
8359 (other_buffer_safely): New function.
8360 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8361 calls to replace_buffer_in_windows and
8362 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8363 if allowed.
8364 (record_buffer): Inhibit quitting and rewrite using quittable
8365 functions. Run Qbuffer_list_update_hook if allowed.
8366 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8367 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8368 Move switch-to-buffer to window.el.
9397e56f
MR
8369 (bury-buffer): Move to window.el.
8370 (Vbuffer_list_update_hook): New variable.
8371
8372 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8373 section.
8374
8375 * window.h (resize_frame_windows): Move up in code.
8376 (Fwindow_frame): Remove EXFUN.
8377 (replace_buffer_in_all_windows): Remove prototype.
8378 (replace_buffer_in_windows_safely): Add prototype.
8379
8380 * window.c: Declare Qdelete_window static again. Move down
8381 declaration of select_count.
8382 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8383 (Fother_window): Move to window.el.
8384 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8385 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8386 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8387 window.el.
8388 (replace_buffer_in_windows): Implement by calling
8389 Qreplace_buffer_in_windows.
8390 (replace_buffer_in_all_windows): Remove with some functionality
8391 moved into replace_buffer_in_windows_safely.
8392 (replace_buffer_in_windows_safely): New function.
8393 (select_window_norecord, select_frame_norecord): Move in front
8394 of run_window_configuration_change_hook. Remove now obsolete
8395 declarations.
640c8776
SM
8396 (Fset_window_buffer): Rewrite doc-string.
8397 Call Qrecord_window_buffer.
9397e56f
MR
8398 (keys_of_window): Move binding for other-window to window.el.
8399
b50691aa
CY
84002011-06-11 Chong Yidong <cyd@stupidchicken.com>
8401
8402 * dispextern.h (struct image): Replace data member, whose int_val
8403 and ptr_val fields were not used by anything, with a single
8404 lisp_val object.
8405
8406 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8407 (gif_clear_image, gif_load, imagemagick_load_image)
8408 (gs_clear_image, gs_load): Callers changed.
8409
3f754b86
PE
84102011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8411
cca69397
PE
8412 * buffer.h: Include <time.h>, for time_t.
8413 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8414
109e28d0
PE
8415 Fix minor problems found by static checking.
8416
60737f02
PE
8417 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8418
4b66faf3
PE
8419 Make identifiers static if they are not used in other modules.
8420 * data.c (Qcompiled_function, Qframe, Qvector):
8421 * image.c (QimageMagick, Qsvg):
8422 * minibuf.c (Qmetadata):
8423 * window.c (resize_window_check, resize_root_window): Now static.
8424 * window.h (resize_window_check, resize_root_window): Remove decls.
8425
109e28d0
PE
8426 * window.c (window_deletion_count, delete_deletable_window):
8427 Remove; unused.
46a4ce9e
PE
8428 (window_body_lines): Now static.
8429 (Fdelete_other_windows_internal): Mark vars as initialized.
8430 Make sure 'resize_failed' is initialized.
8431 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8432 (resize_window_apply): Remove unused local.
8433 * window.h (delete_deletable_window): Remove decl.
8434
109e28d0 8435 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8436 (imagemagick_load_image): Fix pointer signedness problem by changing
8437 last arg from unsigned char * to char *. All uses changed.
8438 Also, fix a local for similar reasons.
8439 Remove unused locals. Remove locals to avoid shadowing.
8440 (fn_rsvg_handle_free): Remove; unused.
8441 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8442 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8443
3f754b86
PE
8444 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8445
2547adb1
CY
84462011-06-10 Chong Yidong <cyd@stupidchicken.com>
8447
8448 * image.c (gif_load): Fix omitted cast error introduced by
8449 2011-06-06 change.
8450
2c8e37d4
MR
84512011-06-10 Martin Rudalics <rudalics@gmx.at>
8452
8453 * window.h (resize_proportionally, orig_total_lines)
8454 (orig_top_line): Remove from window structure.
8455 (set_window_height, set_window_width, change_window_heights)
8456 (Fdelete_window): Remove prototypes.
8457 (resize_frame_windows): Remove duplicate declaration.
8458
440a42e3
EZ
84592011-06-10 Eli Zaretskii <eliz@gnu.org>
8460
8461 * window.h (resize_frame_windows, resize_window_check)
8462 (delete_deletable_window, resize_root_window)
8463 (resize_frame_windows): Declare prototypes.
8464
8465 * window.c (resize_window_apply): Make definition be "static" to
8466 match the prototype.
8467
562dd5e9
MR
84682011-06-10 Martin Rudalics <rudalics@gmx.at>
8469
8470 * window.c: Remove declarations of Qwindow_size_fixed,
8471 window_min_size_1, window_min_size_2, window_min_size,
8472 size_window, window_fixed_size_p, enlarge_window, delete_window.
8473 Remove static from declaration of Qdelete_window, it's
8474 temporarily needed by Fbury_buffer.
8475 (replace_window): Don't assign orig_top_line and
8476 orig_total_lines.
8477 (Fdelete_window, delete_window): Remove. Window deletion is
8478 handled by window.el.
640c8776
SM
8479 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8480 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8481 (Fdelete_other_windows): Remove. Deleting other windows is
8482 handled by window.el.
8483 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8484 handled in window.el.
8485 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8486 Window minimum sizes are handled in window.el.
8487 (shrink_windows, size_window, set_window_height)
8488 (set_window_width, change_window_heights, window_height)
8489 (window_width, CURBEG, CURSIZE, enlarge_window)
8490 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8491 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8492 handled in window.el.
8493 (make_dummy_parent): Rename to make_parent_window and give it a
8494 second argument horflag.
8495 (make_window): Don't set resize_proportionally any more.
8496 (Fsplit_window): Remove. Windows are split in window.el.
8497 (save_restore_action, save_restore_orig_size)
8498 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8499 Resize mini windows in window.el.
8500 (grow_mini_window, shrink_mini_window): Implement by calling
8501 Qresize_root_window_vertically, resize_window_check and
8502 resize_window_apply.
640c8776
SM
8503 (saved_window, Fset_window_configuration, save_window_save):
8504 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8505 resize_proportionally.
8506 (window_min_height, window_min_width): Move to window.el.
8507 (keys_of_window): Move bindings for delete-other-windows,
8508 split-window, delete-window and enlarge-window to window.el.
8509
8510 * buffer.c: Temporarily extern Qdelete_window.
8511 (Fbury_buffer): Temporarily call Qdelete_window instead of
8512 Fdelete_window (Fbury_buffer will move to window.el soon).
8513
8514 * frame.c (set_menu_bar_lines_1): Remove code handling
8515 orig_top_line and orig_total_lines.
8516
8517 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8518 set_window_height but set heights directly.
8519 (change_frame_size_1): Use resize_frame_windows.
8520
8521 * xdisp.c (init_xdisp): Don't use set_window_height but set
8522 heights directly.
8523
640c8776
SM
8524 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8525 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8526 run_window_configuration_change_hook.
8527
8528 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8529 instead of change_window_heights and run
8530 run_window_configuration_change_hook.
8531
1a13852e
MR
85322011-06-09 Martin Rudalics <rudalics@gmx.at>
8533
8534 * window.c (replace_window): Rename second argument REPLACEMENT to
8535 NEW. New third argument SETFLAG. Rewrite.
8536 (delete_window, make_dummy_parent): Call replace_window with
8537 third argument 1.
8538 (window_list_1): Move down in code.
8539 (run_window_configuration_change_hook): Move set_buffer part
8540 before select_frame_norecord part in order to unwind correctly.
8541 Rename count1 to count.
8542 (recombine_windows, delete_deletable_window, resize_root_window)
8543 (Fdelete_other_windows_internal)
8544 (Frun_window_configuration_change_hook, make_parent_window)
8545 (resize_window_check, resize_window_apply, Fresize_window_apply)
8546 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8547 (Fdelete_window_internal, Fresize_mini_window_internal):
8548 New functions.
1a13852e
MR
8549 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8550
f3d1777e
MR
85512011-06-08 Martin Rudalics <rudalics@gmx.at>
8552
496e208e
MR
8553 * window.h (window): Add some new members to window structure -
8554 normal_lines, normal_cols, new_total, new_normal, clone_number,
8555 splits, nest, prev_buffers, next_buffers.
8556 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8557 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8558
f3d1777e
MR
8559 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8560 Remove.
496e208e
MR
8561 (make_dummy_parent): Set new members of windows structure.
8562 (make_window): Move down in code. Handle new members of window
8563 structure.
8564 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8565 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8566 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8567 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8568 (Fset_window_next_buffers, Fset_window_clone_number):
8569 New functions.
496e208e
MR
8570 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8571 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8572 Doc-string fixes.
8573 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8574 Argument WINDOW can be now internal window too.
8575 (Fwindow_use_time): Move up in code.
8576 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8577 Rewrite doc-string.
8578 (Fset_window_configuration, saved_window)
8579 (Fcurrent_window_configuration, save_window_save): Handle new
8580 members of window structure.
b9e809c2
MR
8581 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8582 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8583 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8584 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8585 Qget_mru_window, Qresize_root_window,
8586 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8587 Qauto_buffer_name; staticpro them.
f3d1777e 8588
abde8f8c
MR
85892011-06-07 Martin Rudalics <rudalics@gmx.at>
8590
8591 * window.c (Fwindow_total_size, Fwindow_left_column)
8592 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8593 (Fwindow_list_1): New functions.
8594 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8595 (Fwindow_width, Fscroll_left, Fscroll_right):
8596 Use window_body_cols instead of window_box_text_cols.
8597 (delete_window, Fset_window_configuration):
8598 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8599 (delete_all_subwindows): Take a window as argument and not a
8600 structure. Rewrite.
190b47e6
MR
8601 (window_loop): Remove handling of GET_LRU_WINDOW and
8602 GET_LARGEST_WINDOW.
8603 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8604
8605 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8606 window_box_text_cols. delete_all_subwindows now takes a
8607 Lisp_Object as argument.
abde8f8c 8608
640c8776
SM
8609 * indent.c (compute_motion, Fcompute_motion):
8610 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8611
fa8a67e6
MR
8612 * frame.c (delete_frame): Call delete_all_subwindows with root
8613 window as argument.
8614
a54e3482
DC
86152011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8616
8617 * fns.c (Fputhash): Document return value.
8618
60002bf5
CY
86192011-06-06 Chong Yidong <cyd@stupidchicken.com>
8620
8621 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8622
0c671da6 86232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8624
b862a52a 8625 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8626
be44ca6c
PE
8627 Check for overflow when converting integer to cons and back.
8628 * charset.c (Fdefine_charset_internal, Fdecode_char):
8629 Use cons_to_unsigned to catch overflow.
8630 (Fencode_char): Use INTEGER_TO_CONS.
8631 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8632 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8633 * data.c (long_to_cons, cons_to_long): Remove.
8634 (cons_to_unsigned, cons_to_signed): New functions.
8635 These signal an error for invalid or out-of-range values.
8636 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8637 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8638 * font.c (Ffont_variation_glyphs):
8639 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8640 * lisp.h: Include <intprops.h>.
8641 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8642 (cons_to_signed, cons_to_unsigned): New decls.
8643 (long_to_cons, cons_to_long): Remove decls.
8644 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8645 (Fprimitive_undo): Use CONS_TO_INTEGER.
8646 * xfns.c (Fx_window_property): Likewise.
8647 * xselect.c: Include <limits.h>.
8648 (x_own_selection, selection_data_to_lisp_data):
8649 Use INTEGER_TO_CONS.
8650 (x_handle_selection_request, x_handle_selection_clear)
8651 (x_get_foreign_selection, Fx_disown_selection_internal)
8652 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8653 (lisp_data_to_selection_data): Use cons_to_unsigned.
8654 (x_fill_property_data): Use cons_to_signed.
8655 Report values out of range.
8656
d1f3d2af
PE
8657 Check for buffer and string overflow more precisely.
8658 * buffer.h (BUF_BYTES_MAX): New macro.
8659 * lisp.h (STRING_BYTES_MAX): New macro.
8660 * alloc.c (Fmake_string):
8661 * character.c (string_escape_byte8):
8662 * coding.c (coding_alloc_by_realloc):
8663 * doprnt.c (doprnt):
8664 * editfns.c (Fformat):
8665 * eval.c (verror):
8666 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8667 since they may not be the same number.
8668 * editfns.c (Finsert_char):
8669 * fileio.c (Finsert_file_contents):
8670 Likewise for BUF_BYTES_MAX.
8671
dd52fcea
PE
8672 * image.c: Use ptrdiff_t, not int, for sizes.
8673 (slurp_file): Switch from int to ptrdiff_t.
8674 All uses changed.
8675 (slurp_file): Check that file size fits in both size_t (for
8676 malloc) and ptrdiff_t (for sanity and safety).
8677
7f9bbdbb
PE
8678 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8679 if b->modtime has its maximal value.
8680
dfe18f82
PE
8681 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8682
84acfcf0
PE
8683 Don't assume time_t can fit into int.
8684 * buffer.h (struct buffer.modtime): Now time_t, not int.
8685 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8686 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8687
ccd9a01a
PE
8688 Minor fixes for signed vs unsigned integers.
8689 * character.h (MAYBE_UNIFY_CHAR):
8690 * charset.c (maybe_unify_char):
8691 * keyboard.c (read_char, reorder_modifiers):
8692 XINT -> XFASTINT, since the integer must be nonnegative.
8693 * ftfont.c (ftfont_spec_pattern):
8694 * keymap.c (access_keymap, silly_event_symbol_error):
8695 XUINT -> XFASTINT, since the integer must be nonnegative.
8696 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8697 since it makes no difference and we prefer signed.
8698 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8699 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8700 nonnegative.
8701
d6d100dd
SM
87022011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8703
8704 * window.h (Fwindow_frame): Declare.
8705
2b6148e4
PE
87062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8707
8708 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8709 (SPARE_MEMORY): Always define.
8710 (LARGE_REQUEST): Remove.
8711 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8712
f230ecc9
MR
87132011-06-06 Martin Rudalics <rudalics@gmx.at>
8714
727e958e
MR
8715 * lisp.h: Move EXFUNS for Fframe_root_window,
8716 Fframe_first_window and Fset_frame_selected_window to window.h.
8717
8718 * window.h: Move EXFUNS for Fframe_root_window,
8719 Fframe_first_window and Fset_frame_selected_window here from
8720 lisp.h.
8721
8722 * frame.c (Fwindow_frame, Fframe_first_window)
8723 (Fframe_root_window, Fframe_selected_window)
8724 (Fset_frame_selected_window): Move to window.c.
8725 (Factive_minibuffer_window): Move to minibuf.c.
8726 (Fother_visible_frames_p): New function.
8727
8728 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8729
f230ecc9
MR
8730 * window.c (decode_window, decode_any_window): Move up in code.
8731 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8732 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8733 (Fwindow_buffer): Move up and rewrite doc-string.
8734 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8735 (Fwindow_prev): New functions.
727e958e
MR
8736 (Fwindow_frame): Move here from frame.c. Accept any window as
8737 argument.
8738 (Fframe_root_window, Fframe_first_window)
8739 (Fframe_selected_window): Move here from frame.c. Accept frame
8740 or arbitrary window as argument. Update doc-strings.
8741 (Fminibuffer_window): Move up in code.
8742 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8743 (Fset_frame_selected_window): Move here from frame.c.
8744 Marginal rewrite.
727e958e
MR
8745 (Fselected_window, select_window, Fselect_window): Move up in
8746 code. Minor doc-string fixes.
f230ecc9 8747
4d09bcf6
PE
87482011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8749
8750 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8751 Do not assume that spare memory exists; that assumption is valid
8752 only if SYSTEM_MALLOC.
8753 (LARGE_REQUEST): New macro, so that the issue of large requests
8754 is separated from the issue of spare memory.
8755
810928a2
AS
87562011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8757
172418ad
AS
8758 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8759 format. (Bug#8806)
8760
43f862f7
AS
8761 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8762
810928a2
AS
8763 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8764 before statements.
8765
a059fe24
JD
87662011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8767
8768 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8769
8770 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8771
8772 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8773 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8774
989bf368
JB
87752011-06-05 Juanma Barranquero <lekktu@gmail.com>
8776
8777 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8778
4b80f674
CY
87792011-06-04 Chong Yidong <cyd@stupidchicken.com>
8780
8781 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8782 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8783 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8784 New error handlers.
4b80f674
CY
8785 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8786 Obey Vx_select_enable_clipboard_manager. Catch errors in
8787 x_clipboard_manager_save (Bug#8779).
8788 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8789 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8790
99a33b77 87912011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8792
8793 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8794
99a33b77 87952011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8796
8797 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8798 in the current matrix if keep_current_p is non-zero.
8799
8264569d
EZ
88002011-06-04 Eli Zaretskii <eliz@gnu.org>
8801
8802 * bidi.c (bidi_level_of_next_char): Fix last change.
8803
57f97249
EZ
88042011-06-03 Eli Zaretskii <eliz@gnu.org>
8805
fec2107c 8806 Support bidi reordering of text covered by display properties.
57f97249 8807
fec2107c
EZ
8808 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8809 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8810 (bidi_cache_search, bidi_cache_iterator_state)
8811 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8812 (bidi_level_of_next_char, bidi_move_to_visually_next):
8813 Support character positions inside a run of characters covered by a
fec2107c
EZ
8814 display string.
8815 (bidi_paragraph_init, bidi_resolve_explicit_1)
8816 (bidi_level_of_next_char): Call bidi_fetch_char and
8817 bidi_fetch_char_advance instead of FETCH_CHAR and
8818 FETCH_CHAR_ADVANCE.
8819 (bidi_init_it): Initialize new members.
8820 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8821 definitions.
8822 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8823 instead of using explicit *_CHAR codes.
d6d100dd
SM
8824 (bidi_resolve_explicit, bidi_resolve_weak):
8825 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8826 bidirectional text is supported only in multibyte buffers.
8827 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8828 it to initialize the frame_window_p member of struct bidi_it.
8829 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8830 (bidi_resolve_explicit, bidi_resolve_weak)
8831 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8832 bidi_it->nchars is non-positive.
8833 (bidi_level_of_next_char): Don't try to lookup the cache for the
8834 next/previous character if nothing is cached there yet, or if we
8835 were just reseat()'ed to a new position.
c40e2fb2 8836
0e14fe90
EZ
8837 * xdisp.c (set_cursor_from_row): Set start and stop points
8838 according to the row's direction when priming the loop that looks
8839 for the glyph on which to display cursor.
8840 (single_display_spec_intangible_p): Function deleted.
8841 (display_prop_intangible_p): Reimplement to call
8842 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8843 Accept 3 additional arguments needed by handle_display_spec.
8844 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8845 values: lists, `(when COND...)' forms, etc.
8846 (single_display_spec_string_p): Support property values that are
8847 lists with the argument STRING its top-level element.
8848 (display_prop_string_p): Fix the condition for processing a
8849 property that is a list to be consistent with handle_display_spec.
fec2107c 8850 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8851 last portion of handle_display_prop.
8852 (compute_display_string_pos): Accept additional argument
8853 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8854 value of a `display' property is a "replacing spec".
8855 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8856 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8857 the display property, but just return a value indicating whether
8858 the display property will replace the characters it covers.
8859 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8860 frame_window_p members of struct bidi_it.
d6d100dd
SM
8861 (compute_display_string_pos, compute_display_string_end):
8862 New functions.
fec2107c
EZ
8863 (push_it): Accept second argument POSITION, where pop_it should
8864 jump to continue iteration.
8865 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8866
fec2107c
EZ
8867 * keyboard.c (adjust_point_for_property): Adjust the call to
8868 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8869
8870 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8871 (bidi_init_it): Update prototypes.
8872 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8873 (compute_display_string_pos, compute_display_string_end):
8874 Declare prototypes.
fec2107c
EZ
8875 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8876 EMACS_INT.
fc6f18ce 8877
40087514 88782011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8879
57f53182
PE
8880 Malloc failure behavior now depends on size of allocation.
8881 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8882 * lisp.h: Change signatures accordingly.
8883 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8884 All callers changed. (Bug#8762)
8885
8886 * gnutls.c: Use Emacs's memory allocators.
8887 Without this change, the gnutls library would invoke malloc etc.
8888 directly, which causes problems on non-SYNC_INPUT hosts, and which
8889 runs afoul of improving memory_full behavior. (Bug#8761)
8890 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8891 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8892 xfree instead of the default malloc, realloc, free.
8893 (Fgnutls_boot): No need to check for memory allocation failure,
8894 since xmalloc does that for us.
8895
ac32cd99 8896 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8897 * category.c (hash_get_category_set):
8898 * ccl.c (ccl_driver):
8899 * charset.c (Fdefine_charset_internal):
8900 * charset.h (struct charset.hash_index):
8901 * composite.c (get_composition_id, gstring_lookup_cache)
8902 (composition_gstring_put_cache):
8903 * composite.h (struct composition.hash_index):
8904 * dispextern.h (struct image.hash):
8905 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8906 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8907 (hashfn_equal, hashfn_user_defined, make_hash_table)
8908 (maybe_resize_hash_table, hash_lookup, hash_put)
8909 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8910 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8911 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8912 * image.c (make_image, search_image_cache, lookup_image)
8913 (xpm_put_color_table_h):
8914 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8915 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8916 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8917 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8918 * alloc.c (allocate_vectorlike):
8919 Check for overflow in vector size calculations.
8920 * ccl.c (ccl_driver):
8921 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8922 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8923 need to be updated by these changes.
40087514
PE
8924 * fns.c (make_hash_table, maybe_resize_hash_table):
8925 Check for integer overflow with large hash tables.
0de4bb68
PE
8926 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8927 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8928 (SXHASH_REDUCE): New macro.
8929 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8930 Use it instead of discarding useful hash info with large hash values.
8931 (sxhash_float): New function.
8932 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8933 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8934 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8935 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8936 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8937 Adjust signatures to match updated version of code.
8938 (consing_since_gc): Now EMACS_INT, since a single hash table can
8939 use more than INT_MAX bytes.
8940
698d32e2
DN
89412011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8942
8943 Make it possible to build with GCC-4.6+ -O2 -flto.
8944
8945 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8946
fd6fa53f
SM
89472011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8948
8949 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8950 Call minibuffer-inactive-mode.
8951
864db017
JB
89522011-05-31 Juanma Barranquero <lekktu@gmail.com>
8953
8954 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8955 Update dependencies.
8956
2ad0baf4
DN
89572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8958
8959 * data.c (init_data): Remove code for UTS, this system is not
8960 supported anymore.
8961
4fcc2638
DN
89622011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8963
8964 Don't force ./temacs to start in terminal mode.
8965
8966 * frame.c (make_initial_frame): Initialize faces in all cases, not
8967 only when CANNOT_DUMP is defined.
8968 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8969
c56e0fd5
DN
89702011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8971
8972 * dispnew.c (add_window_display_history): Use const for the string
8973 pointer. Remove declaration, not needed.
8974
333d54da 89752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8976
55d4c1b2 8977 Use 'inline', not 'INLINE'.
333d54da 8978 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8979 * alloc.c, fontset.c (INLINE): Remove.
8980 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8981 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8982 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8983 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8984 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8985
738db178
DN
89862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8987
8988 Make it possible to run ./temacs.
8989
8990 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8991 syms_of_callproc does the same thing. Remove test for
8992 "initialized", do it in the caller.
8993 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8994
620c53a6
SM
89952011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8996
8997 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8998 (read_minibuf): Use get_minibuffer.
8999 (syms_of_minibuf): Use DEFSYM.
9000 (Qmetadata): New var.
9001 * data.c (Qbuffer): Don't make it static.
9002 (syms_of_data): Use DEFSYM.
9003
e003a292
PE
90042011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9005
9006 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9007 (CCL_CODE_MIN): New macro.
9008
ed008a6d
PE
90092011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9010
3687c2ef
PE
9011 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9012
ed008a6d
PE
9013 * eval.c (Qdebug): Now static.
9014 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9015 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9016 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9017
d66c4c7c
CY
90182011-05-29 Chong Yidong <cyd@stupidchicken.com>
9019
9020 * image.c: Various fixes to ImageMagick code comments.
9021 (Fimagemagick_types): Doc fix.
9022
5fbc2025
PE
90232011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9024
0196f88a
PE
9025 Minor fixes prompted by GCC 4.6.0 warnings.
9026
9027 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9028
5fbc2025
PE
9029 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9030 (x_clipboard_manager_save_all): Move extern decl to ...
9031 * xterm.h: ... here, so that it can be checked for consistency.
9032
1dd3c2d9
CY
90332011-05-29 Chong Yidong <cyd@stupidchicken.com>
9034
9035 * xselect.c (x_clipboard_manager_save_frame)
9036 (x_clipboard_manager_save_all): New functions.
9037 (Fx_clipboard_manager_save): Lisp function deleted.
9038
9039 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9040 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9041
9042 * xterm.h: Update prototype.
9043
5ba6571d
WX
90442011-05-28 William Xu <william.xwl@gmail.com>
9045
9046 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9047 exiting (Bug#8239).
9048
3eaff834
JM
90492011-05-28 Jim Meyering <meyering@redhat.com>
9050
e1900994 9051 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9052 * fns.c (to_uchar): Define.
9053 (crypto_hash_function): Use it to convert some newly-signed
9054 variables to unsigned, to avoid sign-extension bugs. For example,
9055 without this change, (md5 "truc") would evaluate to
9056 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9057 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9058 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9059
0f6990a7
PE
90602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9061
9062 Integer overflow fixes.
c8a9ca5a 9063
08686060
PE
9064 * dbusbind.c: Serial number integer overflow fixes.
9065 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9066 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9067 to hold a serial number that is too large for a fixnum.
9068 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9069 Check for serial numbers out of range. Decode any serial number
59568bf0 9070 that was so large that it became a float. (Bug#8722)
08686060 9071
2d1fc3c7
PE
9072 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9073 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9074 Use XFASTINT rather than XUINT when numbers are nonnegative.
9075 (xd_append_arg, Fdbus_method_return_internal):
9076 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9077 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9078 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9079 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9080 (Bug#8722)
2d1fc3c7 9081
c8a9ca5a
PE
9082 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9083
519e1d69
PE
9084 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9085
6df6ae42 9086 ccl: Add integer overflow checks.
30569699
PE
9087 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9088 (IN_INT_RANGE): New macros.
9089 (ccl_driver): Use them to check for integer overflow when
9090 decoding a CCL program. Many of the new checks are whether XINT (x)
9091 fits in int; it doesn't always, on 64-bit hosts. The new version
9092 doesn't catch all possible integer overflows, but it's an
847044ea 9093 improvement. (Bug#8719)
30569699 9094
c11285dc
PE
9095 * alloc.c (make_event_array): Use XINT, not XUINT.
9096 There's no need for unsigned here.
9097
fdccd48e
PE
9098 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9099 This follows up to the 2011-05-06 change that substituted uintptr_t
9100 for EMACS_INT. This case wasn't caught back then.
9101
37910ab2
PE
9102 Rework Fformat to avoid integer overflow issues.
9103 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9104 now (part of C89). Include <verify.h>.
9105 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9106 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9107 (Fformat): Avoid the prepass trying to compute sizes; it was only
9108 approximate and thus did not catch overflow reliably. Instead, walk
9109 through the format just once, formatting and computing sizes as we go,
9110 checking for integer overflow at every step, and allocating a larger
9111 buffer as needed. Keep track separately whether the format is
9112 multibyte. Keep only the most-recently calculated precision, rather
9113 than them all. Record whether each argument has been converted to
9114 string. Use EMACS_INT, not int, for byte and char and arg counts.
9115 Support field widths and precisions larger than INT_MAX. Avoid
9116 sprintf's undefined behavior with conversion specifications such as %#d
9117 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9118 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9119 formatting out-of-range floating point numbers with int
9173deec 9120 formats. (Bug#8668)
37910ab2 9121
2e6578fb
PE
9122 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9123
0ae6bdee
PE
9124 * data.c: Avoid integer truncation in expressions involving floats.
9125 * data.c: Include <intprops.h>.
9126 (arith_driver): When there's an integer overflow in an expression
9127 involving floating point, convert the integers to floating point
9128 so that the resulting value does not suffer from catastrophic
9129 integer truncation. For example, on a 64-bit host (* 4
9130 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9131 Do not rely on undefined behavior after integer overflow.
9132
de883a70
PE
9133 merge count_size_as_multibyte, parse_str_to_multibyte
9134 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9135 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9136 Check for integer overflow.
9137 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9138 since it's now a duplicate of the other. This is more of
9139 a character than a buffer op, so better that it's in character.c.
9140 * fns.c, print.c: Adjust to above changes.
9141
2ff916cb
PE
91422011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9143
9144 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9145
f1b54466
PE
91462011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9147
fb1ac845
PE
9148 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9149 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9150 (x_clipboard_manager_save): Now static.
9151 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9152
f1b54466
PE
9153 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9154 (crypto_hash_function): Now static.
9155 Fix pointer signedness problems. Avoid unnecessary initializations.
9156
a9f737ee
CY
91572011-05-27 Chong Yidong <cyd@stupidchicken.com>
9158
9159 * termhooks.h (Vselection_alist): Make it terminal-local.
9160
9161 * terminal.c (create_terminal): Initialize it.
9162
9163 * xselect.c: Support for clipboard managers.
9164 (Vselection_alist): Move to termhooks.h as terminal-local var.
9165 (LOCAL_SELECTION): New macro.
9166 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9167 (symbol_to_x_atom): Remove gratuitous arg.
9168 (x_handle_selection_request, lisp_data_to_selection_data)
9169 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9170 (x_own_selection, x_get_local_selection, x_convert_selection):
9171 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9172 (some_frame_on_display): Delete unused function.
9173 (Fx_own_selection_internal, Fx_get_selection_internal)
9174 (Fx_disown_selection_internal, Fx_selection_owner_p)
9175 (Fx_selection_exists_p): New optional frame arg.
9176 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9177 (x_handle_selection_clear): Don't treat other terminals with the
9178 same keyboard specially. Use the terminal-local Vselection_alist.
9179 (x_clear_frame_selections): Use Frun_hook_with_args.
9180
9181 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9182
9183 * xterm.h: Add support for those atoms.
9184
e067f0c1
CY
91852011-05-26 Chong Yidong <cyd@stupidchicken.com>
9186
9187 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9188 (converted_selections, conversion_fail_tag): New global variables.
9189 (x_selection_request_lisp_error): Free the above.
9190 (x_get_local_selection): Remove unnecessary code.
9191 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9192 of converted selections stored in converted_selections.
9193 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9194 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9195 (x_convert_selection): New function.
9196 (x_handle_selection_event): Simplify.
9197 (x_get_foreign_selection): Don't ignore incoming requests while
9198 waiting for an answer; this will fail when we implement
9199 SAVE_TARGETS, and seems unnecessary anyway.
9200 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9201 (Vx_sent_selection_functions): Doc fix.
9202
0f4aebc0
LL
92032011-05-26 Leo Liu <sdl.web@gmail.com>
9204
9205 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9206
e61124cd
YM
92072011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9208
9209 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9210
9211 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9212 for fringe update if it has periodic bitmap.
ac389d0c 9213 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9214 and fringe_bitmap_periodic_p.
9215
9216 * fringe.c (get_fringe_bitmap_data): New function.
9217 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9218 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9219 row. Mark glyph row for fringe update if periodicity changed.
9220
9221 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9222 for fringe update unless it has periodic bitmap.
9223
f16d9837
KH
92242011-05-25 Kenichi Handa <handa@m17n.org>
9225
9226 * xdisp.c (get_next_display_element): Set correct it->face_id for
9227 a static composition.
9228
e1b90ef6
LL
92292011-05-24 Leo Liu <sdl.web@gmail.com>
9230
9231 * deps.mk (fns.o):
9232 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9233
9234 * fns.c (crypto_hash_function, Fsha1): New function.
9235 (Fmd5): Use crypto_hash_function.
9236 (syms_of_fns): Add Ssha1.
9237
7400048f
PE
92382011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9239
9240 * gnutls.c: Remove unused macros.
9241 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9242 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9243 Remove macros that are defined and never used.
9244 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9245
abb71cf4
CY
92462011-05-22 Chong Yidong <cyd@stupidchicken.com>
9247
9248 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9249 (Fx_get_selection_internal): Minor cleanup.
9250 (Fx_own_selection_internal): Rename arguments for consistency with
9251 select.el.
9252
6307db39
PE
92532011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9254
9255 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9256
f3d4e0a4
CY
92572011-05-22 Chong Yidong <cyd@stupidchicken.com>
9258
9259 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9260
4d8ade89
YM
92612011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9262
9263 * dispnew.c (scrolling_window): Don't exclude the case that the
9264 last enabled row in the desired matrix touches the bottom boundary.
9265
32078c8d
GM
92662011-05-21 Glenn Morris <rgm@gnu.org>
9267
9268 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9269 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9270 and add some more files.
32078c8d 9271
7285dc67
EZ
92722011-05-20 Eli Zaretskii <eliz@gnu.org>
9273
9274 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9275 report_file_error introduced by the change from 2011-05-07.
9276
89d1bd22
PE
92772011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9278
9279 * systime.h (Time): Define only if emacs is defined.
9280 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9281 where the include path doesn't have X11/X.h by default. See
9282 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9283
cd394be1 92842011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9285
9286 * composite.c (find_automatic_composition): Fix previous change.
9287
b9704ad9
GM
92882011-05-20 Glenn Morris <rgm@gnu.org>
9289
9290 * lisp.mk: New file, split from Makefile.in.
9291 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9292 (shortlisp): Remove.
9293 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9294
4a720484
GM
92952011-05-19 Glenn Morris <rgm@gnu.org>
9296
9297 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9298 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9299 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9300 (lisp): Set the order to that of loadup.el.
9301 (shortlisp): Make it a copy of $lisp.
9302 (SOME_MACHINE_LISP): Remove.
9303 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9304 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9305
a28d4396
KH
93062011-05-18 Kenichi Handa <handa@m17n.org>
9307
9308 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9309 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9310 (find_automatic_composition): Mostly rewrite for efficiency.
9311
a2b1fa8e
JB
93122011-05-18 Juanma Barranquero <lekktu@gmail.com>
9313
9314 * makefile.w32-in: Update dependencies.
9315
8e1f5610
CS
93162011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9317
9318 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9319 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9320
7025ee00 93212011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9322
cdfa6eab
PE
9323 Fix some integer overflow issues, such as string length overflow.
9324
06d6db33
PE
9325 * insdel.c (count_size_as_multibyte): Check for string overflow.
9326
2b4560a8
PE
9327 * character.c (lisp_string_width): Check for string overflow.
9328 Use EMACS_INT, not int, for string indexes and lengths; in
9329 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9330 the resulting string length overflows an EMACS_INT; instead,
9331 report a string overflow if no precision given. When checking for
9332 precision exhaustion, use a check that cannot possibly have
9333 integer overflow. (Bug#8675)
9334 * character.h (lisp_string_width): Adjust to new signature.
9335
cb93f9be
PE
9336 * alloc.c (string_overflow): New function.
9337 (Fmake_string): Use it. This doesn't change behavior, but saves
9338 a few bytes and will simplify future changes.
9339 * character.c (string_escape_byte8): Likewise.
9340 * lisp.h (string_overflow): New decl.
9341
1a1f3366
PE
9342 Fixups, following up to the user-interface timestamp change.
9343 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9344 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9345 * msdos.c (mouse_get_pos): Likewise.
9346 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9347 * w32gui.h (Time): Define by including "systime.h" rather than by
9348 declaring it ourselves. (Bug#8664)
9349
d4e3e4d3
PE
9350 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9351 * image.c (clear_image_cache): Likewise.
9352
f6a24d19
PE
9353 * term.c (term_mouse_position): Don't assume time_t wraparound.
9354
08dc5ae6
PE
9355 Be more systematic about user-interface timestamps.
9356 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9357 and sometimes 'EMACS_UINT', to represent these timestamps.
9358 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9359 This makes the code easier to follow, and makes it easier to catch
9360 integer overflow bugs such as Bug#8664.
9361 * frame.c (Fmouse_position, Fmouse_pixel_position):
9362 Use Time, not unsigned long, for user-interface timestamps.
9363 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9364 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9365 * keyboard.h (last_event_timestamp): Likewise.
9366 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9367 * menu.h (xmenu_show): Likewise.
9368 * term.c (term_mouse_position): Likewise.
9369 * termhooks.h (struct input_event.timestamp): Likewise.
9370 (struct terminal.mouse_position_hook): Likewise.
9371 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9372 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9373 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9374 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9375 what it was before.
9376 * menu.h, termhooks.h: Include "systime.h", for Time.
9377
8e55734a
PE
9378 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9379 Don't assume that the difference between two unsigned long values
9380 can fit into an integer. At this point, we know button_down_time
9381 <= event->timestamp, so the difference must be nonnegative, so
9382 there's no need to cast the result if double-click-time is
9383 nonnegative, as it should be; check that it's nonnegative, just in
9384 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9385 apart (about 25 days). (Bug#8664)
8e55734a 9386
841f1b75 9387 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9388 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9389
3e26f69c
PE
9390 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9391 that always fit in int. Use a sentinel instead of a counter, to
9392 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9393 * frame.h (struct frame): Use int for menu_bar_items_used
9394 instead of EMACS_INT, since it always fits in int.
3e26f69c 9395
5cc152c0
PE
9396 * menu.c (grow_menu_items): Check for int overflow.
9397
d89eb65e
PE
9398 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9399
5235bd3e
PE
9400 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9401 Before, the code was not consistent. These values cannot exceed
9402 2**31 - 1 so there's no need to make them unsigned.
9403 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9404 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9405 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9406 as modifiers.
9407 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9408
bc827e23
PE
9409 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9410 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9411 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9412 presumably because the widths might not match.
9413
78eb494e
PE
9414 * window.c (size_window): Avoid needless test at loop start.
9415
04f2d78b
CB
94162011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9417
9418 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9419
d2fc7e3d 94202011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9421
9422 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9423
d2fc7e3d 94242011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9425
9426 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9427 `width' to `bar_area_x' and `bar_area_width', respectively.
9428 (x_scroll_run): Take account of fringe background extension.
9429
04f2d78b
CB
9430 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9431 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9432 `bar_area_width', respectively.
9433 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9434 background extension.
9435
79b70037
GM
94362011-05-10 Jim Meyering <meyering@redhat.com>
9437
9438 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9439
2f142cc5
JB
94402011-05-10 Juanma Barranquero <lekktu@gmail.com>
9441
9442 * image.c (Finit_image_library): Return t for built-in image types,
9443 like pbm and xbm. (Bug#8640)
9444
57679c86
AS
94452011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9446
9447 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9448
888c9e86
EZ
94492011-05-07 Eli Zaretskii <eliz@gnu.org>
9450
b0512a1d
EZ
9451 * w32console.c (Fset_screen_color): Doc fix.
9452 (Fget_screen_color): New function.
9453 (syms_of_ntterm): Defsubr it.
9454
7285dc67
EZ
9455 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9456 unlink the temporary file if Fcall_process didn't create it in the
9457 first place.
9458 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9459 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9460 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9461 cue to call_process_cleanup not to close that handle.
9462
4d3fcc8e
BK
94632011-05-07 Ben Key <bkey76@gmail.com>
9464
9465 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9466 one of two shell specific rules, either bootstrap-temacs-CMD or
9467 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9468 to the previous implementation of the bootstrap-temacs rule.
9469 The bootstrap-temacs-CMD rule is similar to the previous
9470 implementation of the bootstrap-temacs rule except that it
9471 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9472 variable.
9473
9474 These changes, along with some changes to nt/configure.bat,
9475 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9476 earlier fix to add support for --cflags and --ldflags options
9477 that include quotes so that it works whether make uses cmd or
9478 sh as the shell.
9479
b4289b64
MA
94802011-05-06 Michael Albinus <michael.albinus@gmx.de>
9481
9482 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9483 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9484 is a constant.
9485 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9486 a string. Handle both cases.
9487 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9488 (Fdbus_register_method): Use Qinvalid_function.
9489
af4c0e28
JB
94902011-05-06 Juanma Barranquero <lekktu@gmail.com>
9491
9492 * makefile.w32-in: Update dependencies.
9493 (LISP_H): Add inttypes.h and stdin.h.
9494 (PROCESS_H): Add unistd.h.
9495
c51453d9
EZ
94962011-05-06 Eli Zaretskii <eliz@gnu.org>
9497
9498 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9499 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9500
8ff0ac3c 95012011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9502
4c4b566b
PE
9503 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9504
aab2b9b5
PE
9505 * term.c (vfatal): Remove stray call to va_end.
9506 It's not needed and the C Standard doesn't allow it here anyway.
9507
c378da0b
PE
9508 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9509 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9510
288b08c7
PE
9511 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9512 bytes.
9513
e3601888
PE
9514 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9515
db6c0e74
PE
9516 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9517
dd5963ea
PE
9518 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9519
88c9450f
PE
9520 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9521
2f9442b8
PE
9522 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9523
c032b5f8
PE
9524 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9525 * charset.c (Fdefine_charset_internal): Don't initialize
9526 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9527 32-bit int (Bug#8600).
a108c10b
PE
9528
9529 * lread.c (read_integer): Be more consistent with string-to-number.
9530 Use string_to_number to do the actual conversion; this avoids
9531 rounding errors and fixes some other screwups. Without this fix,
9532 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9533 (digit_to_number): Move earlier, for benefit of read_integer.
9534 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9535 not a digit in any supported base. (Bug#8602)
a108c10b 9536
ad5f9eea
PE
9537 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9538
aec1708a
PE
9539 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9540 to match comment at start of function. This also removes a
9541 GCC warning about overflow in a 32+64-bit port.
9542
47be4ab5
PE
9543 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9544
371cac43
PE
9545 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9546 Reported by Stefan Monnier in
9547 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9548 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9549 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9550
d01a7826
PE
9551 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9552 (EMACS_UINTPTR): Likewise, with uintptr_t.
9553
7fd47d5c
PE
9554 * lisp.h: Prefer 64-bit EMACS_INT if available.
9555 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9556 on 32-bit hosts that have 64-bit int, so that they can access
9557 large files.
122b0c86
PE
9558 However, temporarily disable this change unless the temporary
9559 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9560
8727937b
PE
9561 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9562
8ac068ac
PE
9563 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9564 This removes an assumption that EMACS_INT and long are the same
9565 width as pointers. The assumption is true for Emacs porting targets
9566 now, but we want to make other targets possible.
9567 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9568 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9569 In the rest of the code, change types of integers that hold casted
9570 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9571 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9572 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9573 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9574 No need to cast type when ORing.
9575 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9576 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9577 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9578 assume EMACS_INT is the same width as char *.
9579 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9580 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9581 Remove no-longer-needed casts.
9582 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9583 (xg_tool_bar_help_callback, xg_make_tool_item):
9584 Use EMACS_INTPTR to hold an integer
9585 that will be cast to void *; this can avoid a GCC warning
9586 if EMACS_INT is not the same width as void *.
9587 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9588 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9589 (current_message_1, set_message_1):
9590 Use a local to convert to proper width without a cast.
9591 * xmenu.c (dialog_selection_callback): Likewise.
9592
ede49d71
PE
9593 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9594 Also, don't assume VALBITS / RAND_BITS is less than 5,
9595 and don't rely on undefined behavior when shifting a 1 left into
9596 the sign bit.
9597 * lisp.h (get_random): Change signature to match.
9598
2f30ecd0
PE
9599 * lread.c (hash_string): Use size_t, not int, for hash computation.
9600 Normally we prefer signed values; but hashing is special, because
9601 it's better to use unsigned division on hash table sizes so that
9602 the remainder is nonnegative. Also, size_t is the natural width
9603 for hashing into memory. The previous code used 'int', which doesn't
9604 retain enough info to hash well into very large tables.
9605 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9606
2a866e7b
PE
9607 * dbusbind.c: Don't possibly lose pointer info when converting.
9608 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9609 Use XPNTR rather than XHASH, so that the high-order bits of
9610 the pointer aren't lost when converting through void *.
9611
51639eac
PE
9612 * eval.c (Fautoload): Don't double-shift a pointer.
9613
92394119
PE
9614 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9615
dbdb9a7c
JB
96162011-05-06 Juanma Barranquero <lekktu@gmail.com>
9617
9618 * gnutls.c (DEF_GNUTLS_FN):
9619 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9620
db7a0b4f
AS
96212011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9622
9623 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9624 marker. (Bug#8610)
9625
cd394be1 96262011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9627
9628 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9629 New version that can reserve upto 2GB of heap space.
9630
f7ff1b0f 96312011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9632
9633 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9634
639c109b
TZ
96352011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9636
9637 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9638 `gnutls_certificate_set_x509_key_file'.
9639
d2127135
JB
96402011-05-05 Juanma Barranquero <lekktu@gmail.com>
9641
9642 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9643 Update dependencies.
9644
e968f4f3
JB
96452011-05-04 Juanma Barranquero <lekktu@gmail.com>
9646
9647 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9648 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9649 Remove unused parameter `fildes'.
9650 * process.c (read_process_output, send_process): Don't pass it.
9651
84d358f0
JB
96522011-05-04 Juanma Barranquero <lekktu@gmail.com>
9653
9654 Fix previous change: the library cache is defined in w32.c.
9655 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9656 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9657
0898ca10
JB
96582011-05-04 Juanma Barranquero <lekktu@gmail.com>
9659
9660 Implement dynamic loading of GnuTLS on Windows.
9661
9662 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9663 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9664 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9665 Declare.
9666
9667 * gnutls.c (Qgnutls_dll): Define.
9668 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9669 (gnutls_*): Declare function pointers.
9670 (init_gnutls_functions): New function to initialize function pointers.
9671 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9672 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9673 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9674 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9675 (emacs_gnutls_write, emacs_gnutls_read)
9676 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9677 (Fgnutls_available_p): New function.
9678 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9679 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9680 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9681
9682 * image.c: Include w32.h.
9683 (Vimage_type_cache): Delete.
9684 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9685 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9686 (w32_delayed_load): Move to w32.c.
9687
9688 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9689
9690 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9691 (w32_delayed_load): Move from image.c. When loading a library, record
9692 its filename in the :loaded-from property of the library id.
9693 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9694 Initialize and staticpro them.
9695 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9696
9697 * process.c: Include lisp.h before w32.h, not after.
9698 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9699 instead of gnutls_record_check_pending.
9700
9701 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9702
ff4de4aa
TZ
97032011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9704
9705 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9706 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9707 as passed in.
9708
abe95abb
JD
97092011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9710
9711 * xterm.c (x_set_frame_alpha): Do not set property on anything
9712 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9713
e16e55d4
JB
97142011-05-02 Juanma Barranquero <lekktu@gmail.com>
9715
9716 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9717
bafcf6a5
JB
97182011-05-02 Juanma Barranquero <lekktu@gmail.com>
9719
9720 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9721 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9722 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9723 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9724 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9725 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9726 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9727 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9728 (Qgnutls_bootprop_callbacks_verify): Make static.
9729
e7a6747f
AS
97302011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9731
19ed11ba
AS
9732 * callproc.c: Indentation fixup.
9733
e7a6747f 9734 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9735 (wait_for_termination, interruptible_wait_for_termination):
9736 Move after wait_for_termination_1.
e7a6747f 9737
1ef14cb4
LMI
97382011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9739
9740 * sysdep.c (interruptible_wait_for_termination): New function
9741 which is like wait_for_termination, but allows keyboard
9742 interruptions.
9743
9744 * callproc.c (Fcall_process): Add (:file "file") as an option for
9745 the STDOUT buffer.
9746 (Fcall_process_region): Ditto.
9747
330d880c
EZ
97482011-04-30 Eli Zaretskii <eliz@gnu.org>
9749
8db90b73
EZ
9750 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9751 rather than `XVECTOR (FOO)->size'.
9752
330d880c
EZ
9753 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9754 inttypes.h, as a gnulib replacement is used if it not available in
9755 system headers.
9756
15cbd324
EZ
97572011-04-21 Eli Zaretskii <eliz@gnu.org>
9758
9759 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9760 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9761 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9762
9763 * coding.c (coding_alloc_by_realloc): Error out if destination
9764 will grow beyond MOST_POSITIVE_FIXNUM.
9765 (decode_coding_emacs_mule): Abort if there isn't enough place in
9766 charbuf for the composition carryover bytes. Reserve an extra
9767 space for up to 2 characters produced in a loop.
9768 (decode_coding_iso_2022): Abort if there isn't enough place in
9769 charbuf for the composition carryover bytes.
9770
97712011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9772
ae940cca
EZ
9773 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9774 aborting when %lld or %lll format is passed.
9775 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9776 %llo or %llx format is passed. (Bug#8545)
9777
03ab8921
EZ
9778 * window.c (window_scroll_line_based): Use a marker instead of
9779 simple variables to record original value of point. (Bug#7952)
9780
afda1437
EZ
9781 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9782 produced by %s or %c overflows available buffer space. (Bug#8545)
9783
f76dee0c
PE
97842011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9785
9786 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9787 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9788
fdc5744d
JB
97892011-04-28 Juanma Barranquero <lekktu@gmail.com>
9790
9791 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9792
638f053a
JB
97932011-04-28 Juanma Barranquero <lekktu@gmail.com>
9794
9795 * keyboard.c (Qdelayed_warnings_hook): Define.
9796 (command_loop_1): Run `delayed-warnings-hook'
9797 if Vdelayed_warnings_list is non-nil.
9798 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9799 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9800
d178f871
EZ
98012011-04-28 Eli Zaretskii <eliz@gnu.org>
9802
9803 * doprnt.c (doprnt): Don't return value smaller than the buffer
9804 size if the message was truncated. (Bug#8545).
9805
b124fd93
JB
98062011-04-28 Juanma Barranquero <lekktu@gmail.com>
9807
9808 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9809 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9810
e810457d
PE
98112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9812
9813 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9814
ea51cceb
JB
98152011-04-27 Juanma Barranquero <lekktu@gmail.com>
9816
9817 * makefile.w32-in: Update dependencies.
9818
94dcfacf
EZ
98192011-04-27 Eli Zaretskii <eliz@gnu.org>
9820
9821 Improve `doprnt' and its usage. (Bug#8545)
9822 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9823 `format_end'. Remove support for %l as a conversion specifier.
9824 Don't use xrealloc. Improve diagnostics when the %l size modifier
9825 is used. Update the commentary.
9826
9827 * eval.c (verror): Simplify calculation of size_t.
9828
9829 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9830 messages.
9831
f61f41d7
PE
98322011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9833
9834 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9835 change.
9836
96fb4434
PE
98372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9838
9839 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9840 This makes this file independent of the recent pseudovector change.
9841
671875da 98422011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9843
69e9b5a3
PE
9844 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9845
b5f869a7 9846 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9847 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9848 Remove unused local.
c8926152 9849 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9850
841a1577 9851 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9852 GCC 4.6.0 optimizes based on type-based alias analysis.
9853 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9854 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9855 != &v->size, and therefore "v->size = 1; b->size = 2; return
9856 v->size;" must therefore return 1. This assumption is incorrect
9857 for Emacs, since it type-puns struct Lisp_Vector * with many other
9858 types. To fix this problem, this patch adds a new type struct
f904488f 9859 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9860 and pseudovectors, and helps optimizing compilers not get fooled
9861 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9862 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9863 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9864 the size member.
eab3844f
PE
9865 (XSETPVECTYPE): Rewrite in terms of new macro.
9866 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9867 This is a bit clearer, and further avoids the possibility of
9868 undesirable aliasing.
9869 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9870 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9871 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9872 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9873 (ASIZE): Now uses header.size rather than size.
9874 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9875 to avoid the hassle of writing XVECTOR (foo)->header.size.
9876 (struct vectorlike_header): New type.
eab3844f
PE
9877 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9878 object, to help avoid aliasing.
9879 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9880 (SUBRP): Likewise, since Lisp_Subr is a special case.
9881 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9882 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9883 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9884 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9885 changed to be "header.size" and "header.next".
9886 * buffer.h (struct buffer): Likewise.
9887 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9888 * frame.h (struct frame): Likewise.
9889 * process.h (struct Lisp_Process): Likewise.
9890 * termhooks.h (struct terminal): Likewise.
9891 * window.c (struct save_window_data, struct saved_window): Likewise.
9892 * window.h (struct window): Likewise.
9893 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9894 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9895 * buffer.c (init_buffer_once): Likewise.
9896 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9897 special case.
9898 * process.c (Fformat_network_address): Use local var for size,
9899 for brevity.
9900
0df1eac5
PE
9901 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9902
847ab9d1 9903 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9904 * data.c (atof): Remove decl; no longer used or needed.
9905 (digit_to_number): Move to lread.c.
9906 (Fstring_to_number): Use new string_to_number function, to be
9907 consistent with how the Lisp reader treats infinities and NaNs.
9908 Do not assume that floating-point numbers represent EMACS_INT
9909 without losing information; this is not true on most 64-bit hosts.
9910 Avoid double-rounding errors, by insisting on integers when
9911 parsing non-base-10 numbers, as the documentation specifies.
9912 * lisp.h (string_to_number): New decl, replacing ...
9913 (isfloat_string): Remove.
bc0a5c13 9914 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9915 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9916 appears to have been a coding error. Similarly, do not accept
9917 strings like +-1e0 as floating point numbers. Do not report
9918 overflow for integer overflows unless the base is not 10 which
9919 means we have no simple and reliable way to continue.
9920 Break out the floating-point parsing into a new
9921 function string_to_number, so that Fstring_to_number parses
9922 floating point numbers consistently with the Lisp reader.
04f2d78b 9923 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9924 (E_CHAR, EXP_INT): Remove, replacing with ...
9925 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9926 (string_to_number): New function, replacing isfloat_string.
9927 This function checks for valid syntax and produces the resulting
9928 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9929 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9930 so that overflow for non-base-10 numbers is reported only when
9931 there's no portable and simple way to convert to floating point.
452f4150 9932
67769ffc
PE
9933 * textprop.c (set_text_properties_1): Rewrite for clarity,
9934 and to avoid GCC warning about integer overflow.
9935
c20db43f
PE
9936 * intervals.h (struct interval): Use EMACS_INT for members
9937 where EMACS_UINT might cause problems. See
9938 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9939 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9940 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9941 All uses changed.
37aa2f85
PE
9942 (offset_intervals): Tell GCC not to worry about length overflow
9943 when negating a negative length.
c20db43f 9944
2538aa2f
PE
9945 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9946 (overrun_check_free): Likewise.
9947
f2d3008d
PE
9948 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9949 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9950 word size.
9951
ec8df744
PE
9952 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9953 (gnutls_make_error): Rename local to avoid shadowing.
9954 (gnutls_emacs_global_deinit): ifdef out; not used.
9955 (Fgnutls_boot): Use const for pointer to readonly storage.
9956 Comment out unused local. Fix pointer signedness problems.
9957
640ee02d
PE
9958 * lread.c (openp): Don't stuff size_t into an 'int'.
9959 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9960 about possible signed overflow.
9961
6048fb2a
PE
9962 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9963 (GDK_KEY_g): Don't define if already defined.
9964 (xg_prepare_tooltip): Avoid pointer signedness problem.
9965 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9966
fa3c87e1
PE
9967 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9968 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9969
2172544b
PE
9970 * xfns.c (Fx_window_property): Simplify a bit,
9971 to make a bit faster and to avoid GCC 4.6.0 warning.
9972 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9973
9b821a21
PE
9974 * fns.c (internal_equal): Don't assume size_t fits in int.
9975
3c616cfa
PE
9976 * alloc.c (compact_small_strings): Tighten assertion a little.
9977
c2982e87
PE
9978 Replace pEd with more-general pI, and fix some printf arg casts.
9979 * lisp.h (pI): New macro, generalizing old pEd macro to other
9980 conversion specifiers. For example, use "...%"pI"d..." rather
9981 than "...%"pEd"...".
9982 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9983 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9984 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9985 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9986 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9987 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9988 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9989 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9990 64-bit hosts.
9991 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9992 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9993 * print.c (safe_debug_print, print_object): Likewise.
9994 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9995 to int.
6f04d126
PE
9996 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9997 avoiding the 0 flag, which is not portable.
c2982e87
PE
9998 * process.c (Fmake_network_process): Use pI to avoid cast.
9999 * region-cache.c (pp_cache): Likewise.
10000 * xdisp.c (decode_mode_spec): Likewise.
10001 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10002 behavior on 64-bit hosts with printf arg.
6f04d126 10003 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10004 (x_stop_queuing_selection_requests): Likewise.
10005 (x_get_window_property): Don't truncate byte count to an 'int'
10006 when tracing.
0b432f21 10007
5e073ec7
PE
10008 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10009 here, since it parses constructs like leading '-' and spaces,
10010 which are not wanted; and it overflows with large numbers.
10011 Instead, simply match F[0-9]+, which is what is wanted anyway.
10012
36372bf9
PE
10013 * alloc.c: Remove unportable assumptions about struct layout.
10014 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10015 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10016 (allocate_vectorlike, make_pure_vector): Use the new macros,
10017 plus offsetof, to remove unportable assumptions about struct layout.
10018 These assumptions hold on all porting targets that I know of, but
10019 they are not guaranteed, they're easy to remove, and removing them
10020 makes further changes easier.
10021
0b432f21
PE
10022 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10023 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10024 (string_overrun_cookie): Now const. Use initializers that
10025 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10026 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10027 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10028 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10029 multiple of sizeof (EMACS_INT); it need not be, if
10030 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10031 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10032
895009e1
JB
100332011-04-26 Juanma Barranquero <lekktu@gmail.com>
10034
10035 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10036
6a7a1b0b
TZ
100372011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10038
10039 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10040 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10041 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10042
841a1577 100432011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10044
10045 * lisp.h (Qdebug): List symbol.
895009e1 10046 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10047 * keyboard.c (debug-on-event): New variable.
10048 (handle_user_signal): Break into debugger when debug-on-event
10049 matches the current signal symbol.
10050
f2d3ba6f
DN
100512011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10052
10053 * alloc.c (check_sblock, check_string_bytes)
10054 (check_string_free_list): Convert to standard C.
10055
42ce4c63
TZ
100562011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10057
10058 * w32.c (emacs_gnutls_push): Fix typo.
10059
825cd63c
EZ
100602011-04-25 Eli Zaretskii <eliz@gnu.org>
10061
fb11d64d
EZ
10062 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10063 "cast to pointer from integer of different size".
10064
825cd63c
EZ
10065 Improve doprnt and its use in verror. (Bug#8545)
10066 * doprnt.c (doprnt): Document the set of format control sequences
10067 supported by the function. Use SAFE_ALLOCA instead of always
10068 using `alloca'.
10069
10070 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10071 is one byte too soon. Don't use xrealloc; instead xfree and
10072 xmalloc anew.
10073
e061a11b
TZ
100742011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10075
10076 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10077 callbacks stage.
10078
10079 * gnutls.c: Renamed global_initialized to
10080 gnutls_global_initialized. Added internals for the
10081 :verify-hostname-error, :verify-error, and :verify-flags
10082 parameters of `gnutls-boot' and documented those parameters in the
10083 docstring. Start callback support.
9173deec
JB
10084 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10085 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10086 on error. Return error code.
e061a11b
TZ
10087 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10088 (emacs_gnutls_read): Likewise.
10089 (Fgnutls_boot): Return handshake error code.
10090 (emacs_gnutls_handle_error): New function.
10091 (wsaerror_to_errno): Likewise.
10092
10093 * w32.h (emacs_gnutls_pull): Add prototype.
10094 (emacs_gnutls_push): Likewise.
10095
10096 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10097 (emacs_gnutls_push): Likewise.
10098
100992011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10100
10101 * process.c (wait_reading_process_output): Check if GnuTLS
10102 buffered some data internally if no FDs are set for TLS
10103 connections.
10104
10105 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10106 (LIBS): Link to USER_LIBS.
10107 ($(BLD)/gnutls.$(0)): New target.
10108
fa6996bc
EZ
101092011-04-24 Eli Zaretskii <eliz@gnu.org>
10110
eb35682e
EZ
10111 * xdisp.c (handle_single_display_spec): Rename the
10112 display_replaced_before_p argument into display_replaced_p, to
10113 make it consistent with the commentary. Fix typos in the
10114 commentary.
10115
e2ad650c
EZ
10116 * textprop.c (syms_of_textprop): Remove dead code.
10117 (copy_text_properties): Delete obsolete commentary about an
10118 interface that was deleted long ago. Fix typos in the description
10119 of arguments.
10120
1b2de274
EZ
10121 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10122 to changes in oldXMenu/XMenu.h from 2011-04-16.
10123 <menu_help_message, prev_menu_help_message>: Constify.
10124 (IT_menu_make_room): menu->help_text is now `const char **';
10125 adjust.
10126
10127 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10128 to changes in oldXMenu/XMenu.h from 2011-04-16.
10129 (struct XMenu): Declare `help_text' `const char **'.
10130
10131 * xfaces.c <Qunspecified>: Make extern again.
10132
10133 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10134 required by POSIX.
1b2de274 10135
762b15be
EZ
10136 * doc.c (get_doc_string): Improve the format passed to `error'.
10137
10138 * doprnt.c (doprnt): Improve commentary.
10139
10140 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10141
10142 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10143 them with etags.
10144
f1052e5d
EZ
10145 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10146 changes in globals.h immediately force recompilation.
762b15be
EZ
10147 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10148 $(CURDIR)/s/ms-w32.h.
10149 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10150
fa6996bc
EZ
10151 * character.c (Fchar_direction): Function deleted.
10152 (syms_of_character): Don't defsubr it.
10153 <char-direction-table>: Deleted.
10154
e6c3da20
EZ
101552011-04-23 Eli Zaretskii <eliz@gnu.org>
10156
10157 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10158 * doprnt.c: Include limits.h.
10159 (SIZE_MAX): New macro.
04f2d78b
CB
10160 (doprnt): Return a size_t value. 2nd arg is now size_t.
10161 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10162 Improve overflow protection. Support `l' modifier for integer
10163 conversions. Support %l conversion. Don't assume an EMACS_INT
10164 argument for integer conversions and for %c.
10165
10166 * lisp.h (doprnt): Restore prototype.
10167
10168 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10169 $(SRC)/character.h.
10170
10171 * Makefile.in (base_obj): Add back doprnt.o.
10172
10173 * deps.mk (doprnt.o): Add back prerequisites.
10174 (callint.o): Depend on character.h.
10175
10176 * eval.c (internal_lisp_condition_case): Include the handler
10177 representation in the error message.
10178 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10179 when breaking from the loop.
10180
10181 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10182
10183 * callint.c (Fcall_interactively): When displaying error message
10184 about invalid control letter, pass the character's codepoint, not
10185 a pointer to its multibyte form. Improve display of the character
10186 in octal and display also its hex code.
10187
10188 * character.c (char_string): Use %x to display the (unsigned)
10189 codepoint of an invalid character, to avoid displaying a bogus
10190 negative value.
10191
10192 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10193 `error', not SYMBOL_NAME itself.
10194
10195 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10196 character arguments to `error'.
10197
10198 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10199 to `error' in error message about FINAL_CHAR argument. Make sure
10200 FINAL_CHAR is a character, and use %c when it is passed as
10201 argument to `error'.
10202
4ffd0d6b 102032011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10204
10205 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10206
10207 * w32.c: Include <time.h>.
10208 (sys_localtime): New function.
10209
4ffd0d6b 102102011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10211
10212 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10213
4ffd0d6b 10214 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10215
4ffd0d6b 102162011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10217
4ffd0d6b
GM
10218 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10219 zombies (Bug#8467).
aac0c6e3 10220
04c56954
EZ
102212011-04-19 Eli Zaretskii <eliz@gnu.org>
10222
10223 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10224 gl_state.e_property when gl_state.object is Qt.
10225
10226 * insdel.c (make_gap_larger): Remove limitation of buffer size
10227 to <= INT_MAX.
10228
16a43933
CY
102292011-04-18 Chong Yidong <cyd@stupidchicken.com>
10230
10231 * xdisp.c (lookup_glyphless_char_display)
10232 (produce_glyphless_glyph): Handle cons cell entry in
10233 glyphless-char-display.
10234 (Vglyphless_char_display): Document it.
10235
10236 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10237 glyphless-char-display.
10238
4581706e
CY
102392011-04-17 Chong Yidong <cyd@stupidchicken.com>
10240
10241 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10242
10243 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10244
10245 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10246 definition for no-X builds.
10247
4887c6e2 102482011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10249
fd35b6f9
PE
10250 Static checks with GCC 4.6.0 and non-default toolkits.
10251
5c1ccb01
PE
10252 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10253
006c5daa
PE
10254 * process.c (keyboard_bit_set): Define only if SIGIO.
10255 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10256 (send_process): Repair possible setjmp clobbering.
10257
efc736d3
PE
10258 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10259
4e2fe2e6
PE
10260 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10261
f97334a2
PE
10262 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10263
4e75f29d
PE
10264 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10265 Define only if needed.
10266
90efadd1
PE
10267 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10268 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10269 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10270
3c647824
PE
10271 * dispextern.h (struct redisplay_interface): Rename param
10272 to avoid shadowing.
e264f262 10273 * termhooks.h (struct terminal): Likewise.
761383f4 10274 * xterm.c (xembed_send_message): Likewise.
3c647824 10275
b58c5c4a
PE
10276 * insdel.c (make_gap_smaller): Define only if
10277 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10278
cad59032
PE
10279 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10280 it.
10281
c339dc2e
PE
10282 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10283 so that we aren't warned about unused symbols.
10284
91a3e27b
PE
10285 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10286
399c71d3 10287 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10288
8ffc96f5
PE
10289 * xfns.c (x_real_positions): Mark locals as initialized.
10290
eef9bc79
PE
10291 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10292
098db9dd
PE
10293 * xterm.c: Fix problems found by static analysis with other toolkits.
10294 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10295 (x_dispatch_event): Declare static if USE_GTK, and
10296 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10297 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10298 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10299 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10300 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10301
eb18f6cc
PE
10302 * xmenu.c (menu_help_callback): Pointer type fixes.
10303 Use const pointers when pointing at readonly data. Avoid pointer
10304 signedness clashes.
10305 (FALSE): Remove unused macro.
10306 (update_frame_menubar): Remove unused decl.
10307
1fe72bf8
PE
10308 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10309
60d9e1db
PE
10310 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10311 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10312 (single_menu_item): Rename local to avoid shadowing.
10313
39261c26
PE
10314 * keyboard.c (make_lispy_event): Remove unused local var.
10315
018c5e19
PE
10316 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10317 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10318
63d2b86e
PE
10319 * bitmaps: Change bitmaps from unsigned char back to the X11
10320 compatible char. Avoid the old compiler warnings about
10321 out-of-range initializers by using, for example, '\xab' rather
10322 than 0xab.
10323
aefd87e1
PE
10324 * xgselect.c (xgselect_initialize): Check vs interface
10325 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10326
bf501fb9
PE
10327 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10328
e9829fdf
PE
10329 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10330 to read-only memory.
10331
1086c095
PE
10332 * fns.c (vector): Remove; this old hack is no longer needed.
10333
2baccd04 10334 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10335 Remove unused var.
dde42981 10336 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10337
72391843 10338 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10339
436c16df 10340 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10341 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10342 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10343
92bb796d 10344 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10345 (x_term_init): Remove local to avoid shadowing.
92bb796d 10346
764430a3 10347 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10348
10349 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10350 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10351
d1dfb56c
EZ
103522011-04-16 Eli Zaretskii <eliz@gnu.org>
10353
c4354cb4
EZ
10354 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10355
d1dfb56c
EZ
10356 Fix regex.c, syntax.c and friends for buffers > 2GB.
10357 * syntax.h (struct gl_state_s): Declare character position members
10358 EMACS_INT.
10359
10360 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10361
04f2d78b
CB
10362 * textprop.c (verify_interval_modification, interval_of):
10363 Declare arguments EMACS_INT.
d1dfb56c
EZ
10364
10365 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10366 EMACS_INT.
10367
10368 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10369
10370 * indent.c (Fvertical_motion): Local variable it_start is now
10371 EMACS_INT.
10372
10373 * regex.c (re_match, re_match_2, re_match_2_internal)
10374 (bcmp_translate, regcomp, regexec, print_double_string)
10375 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10376 (re_compile_pattern, re_exec): Declare arguments and local
10377 variables `size_t' and `ssize_t' and return values `regoff_t', as
10378 appropriate.
10379 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10380 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10381 <compile_stack_type>: `size' and `avail' are now `size_t'.
10382
10383 * regex.h <regoff_t>: Use ssize_t, not int.
10384 (re_search, re_search_2, re_match, re_match_2): Arguments that
10385 specify buffer/string position and length are now ssize_t and
10386 size_t. Return type is regoff_t.
10387
613052cd
BK
103882011-04-16 Ben Key <bkey76@gmail.com>
10389
10390 * nsfont.m: Fixed bugs in ns_get_family and
10391 ns_descriptor_to_entity that were caused by using free to
10392 deallocate memory blocks that were allocated by xmalloc (via
10393 xstrdup). This caused Emacs to crash when compiled with
10394 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10395 --enable-checking=xmallocoverrun). xfree is now used to
10396 deallocate these memory blocks.
10397
4170f62f 103982011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10399
71b41406
PE
10400 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10401
9587a89d
PE
10402 emacs_write: Accept and return EMACS_INT for sizes.
10403 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10404 et seq.
10405 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10406 Accept and return EMACS_INT.
10407 (emacs_gnutls_write): Return the number of bytes written on
10408 partial writes.
10409 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10410 (emacs_read, emacs_write): Remove check for negative size, as the
10411 Emacs source code has been audited now.
9587a89d
PE
10412 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10413 (emacs_read, emacs_write): Use it.
273a5f82
PE
10414 * process.c (send_process): Adjust to the new signatures of
10415 emacs_write and emacs_gnutls_write. Do not attempt to store
10416 a byte offset into an 'int'; it might overflow.
9587a89d 10417 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10418
3e047f51
PE
10419 * sound.c: Don't assume sizes fit in 'int'.
10420 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10421 Return EMACS_INT, not int.
3e047f51 10422 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10423 Accept EMACS_INT, not int.
10424 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10425 record read return values.
10426
cc39a9db
BK
104272011-04-15 Ben Key <bkey76@gmail.com>
10428
c9d0ec6d
JB
10429 * keyboard.c (Qundefined): Don't declare static since it is used
10430 in nsfns.m.
10431 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10432 static since they are used in nsfont.m.
cc39a9db 10433
6c60eb9f
SM
104342011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10435
10436 * process.c (Qprocessp): Don't declare static.
10437 * lisp.h (Qprocessp): Declare again.
10438
7990b61a
JB
104392011-04-15 Juanma Barranquero <lekktu@gmail.com>
10440
10441 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10442
5d4cb038
PE
104432011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10444
8bd7b830 10445 Improve C-level modularity by making more things 'static'.
cd64ea1d 10446
e3b27b31
PE
10447 Don't publish debugger-only interfaces to other modules.
10448 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10449 (verify_bytepos, count_markers): Move decls to the only modules
10450 that need them.
10451 * region-cache.h (pp_cache): Likewise.
10452 * window.h (check_all_windows): Likewise.
10453 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10454
5d4cb038
PE
10455 * sysdep.c (croak): Now static, if
10456 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10457 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10458
10459 * alloc.c (refill_memory_reserve): Now static if
10460 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10461 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10462
e87b6180
PE
10463 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10464 Define only if USE_LUCID.
10465
ac64929e
PE
10466 * xrdb.c (x_customization_string, x_rm_string): Now static.
10467
6f37259d
PE
10468 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10469 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10470
1683e3ab
PE
10471 * xdisp.c (draw_row_with_mouse_face): Now static.
10472 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10473
de9c2632
PE
10474 * window.h (check_all_windows): Mark externally visible.
10475
2b96acb7
PE
10476 * window.c (window_deletion_count): Now static.
10477
10478 * undo.c: Make symbols static if they're not exported.
10479 (last_undo_buffer, last_boundary_position, pending_boundary):
10480 Now static.
10481
50436f33
PE
10482 * textprop.c (interval_insert_behind_hooks): Now static.
10483 (interval_insert_in_front_hooks): Likewise.
10484
64520e5c
PE
10485 * term.c: Make symbols static if they're not exported.
10486 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10487 (max_frame_lines, tty_set_terminal_modes):
10488 (tty_reset_terminal_modes, tty_turn_off_highlight):
10489 (get_tty_terminal): Now static.
10490 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10491 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10492 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10493 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10494 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10495
1fa53021
PE
10496 * sysdep.c: Make symbols static if they're not exported.
10497 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10498 Now static.
10499 (sigprocmask_set, full_mask): Remove; unused.
10500 (wait_debugging): Mark as visible.
10501 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10502 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10503
d4b43b22
PE
10504 * syntax.c (syntax_temp): Define only if !__GNUC__.
10505
b7c513d0
PE
10506 * sound.c (current_sound_device, current_sound): Now static.
10507
989b29ad
PE
10508 * search.c (searchbufs, searchbuf_head): Now static.
10509
13a55a78
PE
10510 * scroll.c (scroll_cost): Remove; unused.
10511 * dispextern.h (scroll_cost): Remove decl.
10512
de68a1fc
PE
10513 * region-cache.h (pp_cache): Mark as externally visible.
10514
40ccffa6
PE
10515 * process.c: Make symbols static if they're not exported.
10516 (process_tick, update_tick, create_process, chan_process):
10517 (Vprocess_alist, proc_buffered_char, datagram_access):
10518 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10519 (deactivate_process): Mark defn as static, as well as decl.
10520 * lisp.h (create_process): Remove decl.
10521 * process.h (chan_process, Vprocess_alist): Remove decls.
10522
ad64fc97
PE
10523 * print.c: Make symbols static if they're not exported.
10524 (print_depth, new_backquote_output, being_printed, print_buffer):
10525 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10526 (print_interval, print_number_index, initial_stderr_stream):
10527 Now static.
10528 * lisp.h (Fprinc): Remove decl.
10529 (debug_output_compilation_hack): Mark as externally visible.
10530
adddb265
PE
10531 * sysdep.c (croak): Move decl from here to syssignal.h.
10532 * syssignal.h (croak): Put it here, so the API can be checked when
10533 'croak' is called from dissociate_if_controlling_tty.
10534
1717ede2
PE
10535 * minibuf.c: Make symbols static if they're not exported.
10536 (minibuf_save_list, choose_minibuf_frame): Now static.
10537 * lisp.h (choose_minibuf_frame): Remove decl.
10538
fa5fb2bc
PE
10539 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10540
1e3890d1
PE
10541 * lread.c: Make symbols static if they're not exported.
10542 (read_objects, initial_obarray, oblookup_last_bucket_number):
10543 Now static.
10544 (make_symbol): Remove; unused.
10545 * lisp.h (initial_obarray, make_symbol): Remove decls.
10546
8a1414fa
PE
10547 * keyboard.c: Make symbols static if they're not exported.
10548 (single_kboard, recent_keys_index, total_keys, recent_keys):
10549 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10550 (this_single_command_key_start, echoing, last_auto_save):
10551 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10552 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10553 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10554 (Vlispy_mouse_stem, double_click_count):
10555 Now static.
10556 (force_auto_save_soon): Define only if SIGDANGER.
10557 (ignore_mouse_drag_p): Now static if
10558 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10559 (print_help): Remove; unused.
10560 (stop_character, last_timer_event): Mark as externally visible.
10561 * keyboard.h (ignore_mouse_drag_p): Declare only if
10562 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10563 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10564 * lisp.h (echoing): Remove decl.
10565 (force_auto_save_soon): Declare only if SIGDANGER.
10566 * xdisp.c (redisplay_window): Simplify code, to make it more
10567 obvious that ignore_mouse_drag_p is not accessed if !defined
10568 USE_GTK && !defined HAVE_NS.
10569
93ea6e8f
PE
10570 * intervals.c: Make symbols static if they're not exported.
10571 (merge_properties_sticky, merge_interval_right, delete_interval):
10572 Now static.
10573 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10574
77382fcc
PE
10575 * insdel.c: Make symbols static if they're not exported.
10576 However, leave prepare_to_modify_buffer alone. It's never
10577 called from outside this function, but that appears to be a bug.
10578 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10579 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10580 (adjust_after_replace_noundo): Remove; unused.
10581 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10582 (signal_before_change): Remove decls.
77382fcc 10583
9306c32e
PE
10584 * indent.c (val_compute_motion, val_vmotion): Now static.
10585
cd44d2eb
PE
10586 * image.c: Make symbols static if they're not exported.
10587 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10588 if USE_GTK.
10589 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10590 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10591
ad9a7a06
PE
10592 * fringe.c (standard_bitmaps): Now static.
10593 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10594
81626931
PE
10595 * frame.c: Make symbols static if they're not exported.
10596 (x_report_frame_params, make_terminal_frame): Now static.
10597 (get_frame_param): Now static, unless HAVE_NS.
10598 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10599 (x_get_resource_string): Remove; not used.
10600 * frame.h (make_terminal_frame, x_report_frame_params):
10601 (x_get_resource_string); Remove decls.
10602 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10603 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10604
239f9db9
PE
10605 * font.c, fontset.c: Make symbols static if they're not exported.
10606 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10607 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10608 * font.c (font_close_object): Now static.
10609 * font.h (font_close_object): Remove.
10610 * fontset.c (FONTSET_OBJLIST): Remove.
10611 (free_realized_fontset) #if-0 the body, which does nothing.
10612 (face_suitable_for_char_p): #if-0, as it's never called.
10613 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10614 * xfaces.c (face_at_string_position):
10615 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10616 since 0 is always ASCII.
10617
dfcf3579
PE
10618 * fns.c (weak_hash_tables): Now static.
10619
5045092b
PE
10620 * fileio.c: Make symbols static if they're not exported.
10621 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10622 (Vwrite_region_annotation_buffers): Now static.
10623
57a96f5c
PE
10624 * eval.c: Make symbols static if they're not exported.
10625 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10626 * lisp.h (backtrace_list): Remove decl.
10627
35f08c38
PE
10628 * emacs.c: Make symbols static if they're not exported.
10629 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10630 (fatal_error_code, fatal_error_signal_hook, standard_args):
10631 Now static.
10632 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10633 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10634 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10635 * lisp.h (fatal_error_signal_hook): Remove decl.
10636 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10637
f44bd759
PE
10638 * editfns.c: Move a (normally-unused) function to its only use.
10639 * editfns.c, lisp.h (get_operating_system_release): Remove.
10640 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10641 worth the hassle of breaking this out.
10642
b532497d
PE
10643 * xterm.c: Make symbols static if they're not exported.
10644 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10645 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10646 (x_destroy_window, x_delete_display):
10647 Now static.
10648 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10649 (x_mouse_leave): Remove; unused.
10650 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10651 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10652 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10653 Remove decls.
10654 (x_mouse_leave): Declare only if WINDOWSNT.
10655 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10656 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10657 USE_X_TOOLKIT.
10658
1675728f
PE
10659 * ftxfont.c: Make symbols static if they're not exported.
10660 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10661 HAVE_FREETYPE.
10662 * font.h (ftxfont_driver): Likewise.
10663
e4cebfca
PE
10664 * xfns.c: Make symbols static if they're not exported.
10665 (x_last_font_name, x_display_info_for_name):
10666 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10667 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10668 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10669 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10670 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10671 (last_show_tip_args): Now static.
10672 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10673 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10674 (x_screen_planes): Remove; unused.
10675 * dispextern.h (x_screen_planes): Remove decl.
10676
5bf46f05
PE
10677 * dispnew.c: Make symbols static if they're not exported.
10678 * dispextern.h (redraw_garbaged_frames, scrolling):
10679 (increment_row_positions): Remove.
10680 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10681 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10682 Now static.
10683 (redraw_garbaged_frames): Remove; unused.
10684
435f4c28
PE
10685 * xfaces.c: Make symbols static if they're not exported.
10686 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10687 Remove decls.
10688 * xterm.h (defined_color): Remove decls.
10689 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10690 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10691 (menu_face_changed_default, defined_color, free_realized_face):
10692 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10693 (ascii_face_of_lisp_face): Remove; unused.
10694
8524aef3
PE
10695 * xdisp.c: Make symbols static if they're not exported.
10696 * dispextern.h (scratch_glyph_row, window_box_edges):
10697 (glyph_to_pixel_coords, set_cursor_from_row):
10698 (get_next_display_element, set_iterator_to_next):
10699 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10700 (show_mouse_face): Remove decls
10701 * frame.h (message_buf_print): Likewise.
10702 * lisp.h (pop_message, set_message, check_point_in_composition):
10703 Likewise.
10704 * xterm.h (set_vertical_scroll_bar): Likewise.
10705 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10706 (message_buf_print, scratch_glyph_row, displayed_buffer):
10707 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10708 (get_next_display_element, show_mouse_face, window_box_edges):
10709 (frame_to_window_pixel_xy, check_point_in_composition):
10710 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10711 (glyph_to_pixel_coords): Remove; unused.
10712
16390cd2
PE
10713 * dired.c (file_name_completion): Now static.
10714
10715 * dbusbind.c (xd_in_read_queued_messages): Now static.
10716
a25f4dfa
PE
10717 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10718 * data.c (circular_list_error): Remove.
10719
14a9c8df
PE
10720 * commands.h (last_point_position, last_point_position_buffer):
10721 (last_point_position_window): Remove decls.
10722 * keyboard.c: Make these variables static.
10723
04f2d78b
CB
10724 * coding.h (coding, code_convert_region, encode_coding_gap):
10725 Remove decls.
74ab6df5
PE
10726 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10727 (iso_code_class, detect_coding, code_convert_region): Now static.
10728 (encode_coding_gap): Remove; unused.
10729
38dfbee1
PE
10730 * chartab.c (chartab_chars, chartab_bits): Now static.
10731
a2cb4e63
PE
10732 * charset.h (charset_iso_8859_1): Remove decl.
10733 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10734 Now static.
10735
127198fd
PE
10736 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10737 * ccl.c (Vccl_program_table): Now static.
10738 (check_ccl_update): Remove; unused.
10739
d85b608f
PE
10740 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10741 * category.h: ... from here.
10742 * category.c (check_category_table, set_category_set): Now static.
10743
31cd66f3
PE
10744 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10745 * lisp.h: Remove these decls.
10746
c358e587
PE
10747 * buffer.c (buffer_count): Remove unused var.
10748
e78aecca
PE
10749 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10750 so that it's not optimized away.
10751 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10752 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10753 exported only to the debugger.
10754
e192d7d3 10755 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10756 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10757
92470028
PE
10758 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10759 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10760 was inaccessible from Lisp.
10761 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10762 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10763
244ed907
PE
10764 alloc.c: Import and export fewer symbols, and remove unused items.
10765 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10766 is defined.
10767 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10768 it's not optimized away by whole-program optimization.
10769 (message_enable_multibyte, free_misc): Remove.
10770 (catchlist, handlerlist, mark_backtrace):
10771 Declare only if BYTE_MARK_STACK.
10772 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10773 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10774 (message_enable_multibyte): Remove decl.
10775 (free_misc, interval_free_list, float_block, float_block_index):
10776 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10777 (cons_free_list, last_marked_index):
10778 Now static.
10779 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10780 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10781 (mark_backtrace): Define only if BYTE_MARK_STACK.
10782 * xdisp.c (message_enable_multibyte): Now static.
10783
61c2b50e 10784 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10785 This makes it easier for human readers (and static analyzers)
10786 to see whether these variables are used from other modules.
10787 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10788 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10789 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10790 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10791 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10792 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10793 * xmenu.c, xselect.c:
10794 Declare Q* vars static if they are not used in other modules.
10795 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10796 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10797 Remove decls of unexported vars.
10798 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10799
95c82688
PE
10800 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10801
16a97296
PE
10802 Make Emacs functions such as Fatom 'static' by default.
10803 This makes it easier for human readers (and static analyzers)
10804 to see whether these functions can be called from other modules.
10805 DEFUN now defines a static function. To make the function external
10806 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10807 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10808 (Finit_image_library):
16a97296
PE
10809 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10810 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10811 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10812 Remove decls, since these functions are now static.
10813 (Funintern, Fget_internal_run_time): New decls, since these functions
10814 were already external.
95c82688 10815
16a97296
PE
10816 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10817 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10818 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10819 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10820 * keyboard.c, keymap.c, lread.c:
10821 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10822 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10823 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10824 Mark functions with DEFUE instead of DEFUN,
10825 if they are used in other modules.
10826 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10827 decls for now-static functions.
10828 * buffer.h (Fdelete_overlay): Remove decl.
10829 * callproc.c (Fgetenv_internal): Mark as internal.
10830 * composite.c (Fremove_list_of_text_properties): Remove decl.
10831 (Fcomposition_get_gstring): New forward static decl.
10832 * composite.h (Fcomposite_get_gstring): Remove decl.
10833 * dired.c (Ffile_attributes): New forward static decl.
10834 * doc.c (Fdocumntation_property): New forward static decl.
10835 * eval.c (Ffetch_bytecode): New forward static decl.
10836 (Funintern): Remove extern decl; now in .h file where it belongs.
10837 * fileio.c (Fmake_symbolic_link): New forward static decl.
10838 * image.c (Finit_image_library): New forward static decl.
10839 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10840 * intervals.h (Fprevious_property_change):
10841 (Fremove_list_of_text_properties): Remove decls.
10842 * keyboard.c (Fthis_command_keys): Remove decl.
10843 (Fcommand_execute): New forward static decl.
10844 * keymap.c (Flookup_key): New forward static decl.
10845 (Fcopy_keymap): Now static.
10846 * keymap.h (Flookup_key): Remove decl.
10847 * process.c (Fget_process): New forward static decl.
10848 (Fprocess_datagram_address): Mark as internal.
10849 * syntax.c (Fsyntax_table_p): New forward static decl.
10850 (skip_chars): Remove duplicate decl.
10851 * textprop.c (Fprevious_property_change): New forward static decl.
10852 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10853 Now internal.
10854 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10855 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10856
785bbd42
PE
10857 * editfns.c (Fformat): Remove unreachable code.
10858
8b913b57
AS
108592011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10860
10861 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10862 change. (Bug#8496)
10863
a6744a35
EZ
108642011-04-13 Eli Zaretskii <eliz@gnu.org>
10865
10866 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10867 when at ZV. (Bug#8487)
10868
e7974947
AS
108692011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10870
baad03f0
AS
10871 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10872 (Bug#8437)
10873 * keyboard.c (parse_tool_bar_item): Likewise.
10874 * sound.c (sound_cleanup, alsa_close): Likewise.
10875 * termcap.c (tgetent): Likewise.
10876 * xfns.c (x_default_font_parameter): Likewise.
10877 * xsettings.c (read_and_apply_settings): Likewise.
10878
e7974947
AS
10879 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10880 (overrun_check_free): Protoize.
10881
28272684
PE
108822011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10883
10884 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10885 since callers should never pass a negative size.
10886 Change the signature to match that of plain 'read' and 'write'; see
10887 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10888 * lisp.h: Update prototypes of emacs_write and emacs_read.
10889
11997c76
EZ
108902011-04-11 Eli Zaretskii <eliz@gnu.org>
10891
10892 * xdisp.c (redisplay_window): Don't try to determine the character
10893 position of the scroll margin if the window start point w->startp
e896f03c 10894 is outside the buffer's accessible region. (Bug#8468)
11997c76 10895
8a2cbd72
EZ
108962011-04-10 Eli Zaretskii <eliz@gnu.org>
10897
10898 Fix write-region and its subroutines for buffers > 2GB.
10899 * fileio.c (a_write, e_write): Modify declaration of arguments and
10900 local variables to support buffers larger than 2GB.
10901 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10902
10903 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10904 argument, local variables, and return value.
10905
10906 * lisp.h: Update prototypes of emacs_write and emacs_read.
10907
10908 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10909
4073e537 109102011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10911
1ebfdcb6
PE
10912 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10913
b2ded58d
PE
10914 Fix more problems found by GCC 4.6.0's static checks.
10915
7d66342c
PE
10916 * xdisp.c (vmessage): Use a better test for character truncation.
10917
bbf47d44
PE
10918 * charset.c (load_charset_map): <, not <=, for optimization,
10919 and to avoid potential problems with integer overflow.
9248994d 10920 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10921 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10922 * editfns.c (Fformat): Likewise.
1e69125e 10923 * syntax.c (skip_chars): Likewise.
3befa583 10924
e3019616
PE
10925 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10926 This also lets GCC 4.6.0 generate slightly better loop code.
10927
becfa255
PE
10928 * callint.c (Fcall_interactively): <, not <=, for optimization.
10929 (Fcall_interactively): Count the number of arguments produced,
10930 not the number of arguments given. This is simpler and lets GCC
10931 4.6.0 generate slightly better code.
10932
dae0cd48
PE
10933 * ftfont.c: Distingish more carefully between FcChar8 and char.
10934 The previous code passed unsigned char * to a functions like
10935 strlen and xstrcasecmp that expect char *, which does not
10936 conform to the C standard.
10937 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10938 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10939 char * when the C standard requires it.
10940
76032d70
PE
10941 * keyboard.c (read_char): Remove unused var.
10942
eb3f1cc8
PE
10943 * eval.c: Port to Windows vsnprintf (Bug#8435).
10944 Include <limits.h>.
10945 (SIZE_MAX): Define if the headers do not.
10946 (verror): Do not give up if vsnprintf returns a negative count.
10947 Instead, grow the buffer. This ports to Windows vsnprintf, which
10948 does not conform to C99. Problem reported by Eli Zaretskii.
10949 Also, simplify the allocation scheme, by avoiding the need for
10950 calling realloc, and removing the ALLOCATED variable.
10951
70476b54
PE
10952 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10953
12020a9e
PE
10954 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10955 But keep the doprint source code for now, as we might revamp it
10956 and use it again (Bug#8435).
ea6c7ae6
PE
10957 * lisp.h (doprnt): Remove.
10958 * Makefile.in (base_obj): Remove doprnt.o.
10959 * deps.mk (doprnt.o): Remove.
10960
5fdb398c
PE
10961 error: Print 32- and 64-bit integers portably (Bug#8435).
10962 Without this change, on typical 64-bit hosts error ("...%d...", N)
10963 was used to print both 32- and 64-bit integers N, which relied on
10964 undefined behavior.
61bdb816 10965 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10966 * lisp.h (error, verror): Mark as printf-like functions.
10967 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10968 Report overflow in size calculations when allocating printf buffer.
10969 Do not truncate output string at its first null byte.
10970 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10971 Truncate the output at a character boundary, since vsnprintf does not
10972 do that.
10973 * charset.c (check_iso_charset_parameter): Convert internal
10974 character to string before calling 'error', since %c now has the
10975 printf meaning.
10976 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10977 overflow when computing char to be passed to 'error'. Do not
10978 pass Lisp_Object to 'error'; pass the integer instead.
10979 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10980 formatted with plain %d.
10981
b189fa66
PE
10982 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10983
bff87ef0
PE
10984 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10985
7e2cac20
PE
10986 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10987
ce4d90b5
PE
10988 * xterm.c (x_catch_errors): Remove duplicate declaration.
10989
266c9547
PE
10990 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10991
79c49ad2
PE
10992 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10993
368f4090
JM
109942011-04-10 Jim Meyering <meyering@redhat.com>
10995
10996 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10997 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10998 return ssize_t not "int", and use size_t as the buffer length.
10999 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11000 * gnutls.h: Update declarations.
11001 * process.c (read_process_output): Use ssize_t, to match.
11002 (send_process): Likewise.
11003
a32d4040
CY
110042011-04-09 Chong Yidong <cyd@stupidchicken.com>
11005
11006 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11007
8546720e 110082011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11009
04f2d78b
CB
11010 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11011 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11012
8546720e
GM
11013 * xterm.c (handle_one_xevent):
11014 * xmenu.c (create_and_show_popup_menu):
11015 * xselect.c (x_decline_selection_request)
11016 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11017
0a2f5c1a 110182011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11019
11020 Fix some uses of `int' instead of EMACS_INT.
11021 * search.c (string_match_1, fast_string_match)
11022 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11023 (scan_buffer, find_next_newline_no_quit)
11024 (find_before_next_newline, search_command, Freplace_match)
11025 (Fmatch_data): Make some `int' variables be EMACS_INT.
11026
11027 * xdisp.c (display_count_lines): 3rd argument and return value now
11028 EMACS_INT. All callers changed.
11029 (pint2hrstr): Last argument is now EMACS_INT.
11030
11031 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11032 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11033 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11034 (decode_coding_utf_16, decode_coding_emacs_mule)
11035 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11036 (decode_coding_ccl, decode_coding_charset)
11037 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11038 (decode_coding_iso_2022, decode_coding_emacs_mule)
11039 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11040 <char_offset, last_offset>: Declare EMACS_INT.
11041 (encode_coding_utf_8, encode_coding_utf_16)
11042 (encode_coding_emacs_mule, encode_invocation_designation)
11043 (encode_designation_at_bol, encode_coding_iso_2022)
11044 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11045 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11046 Declare EMACS_INT.
11047 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11048 (encode_invocation_designation): Last argument P_NCHARS is now
11049 EMACS_INT.
11050 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11051 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11052
11053 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11054 All users changed.
11055
11056 * ccl.c (Fccl_execute_on_string): Declare some variables
11057 EMACS_INT.
11058
8546720e 110592011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11060
11061 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11062
4e19a977
CS
110632011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11064
11065 * process.c (Fformat_network_address): Doc fix.
11066
87302331
R
110672011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11068
ee7683eb 11069 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11070
cbb59342
CY
110712011-04-08 Chong Yidong <cyd@stupidchicken.com>
11072
11073 * keyboard.c (read_char): Call Lisp function help-form-show,
11074 instead of using internal_with_output_to_temp_buffer.
11075 (Qhelp_form_show): New var.
e0d38eeb 11076 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11077
11078 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11079
11080 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11081
e67a13ab
CY
110822011-04-06 Chong Yidong <cyd@stupidchicken.com>
11083
04f2d78b
CB
11084 * process.c (Flist_processes): Remove to Lisp.
11085 (list_processes_1): Delete.
e67a13ab 11086
973f782d
EZ
110872011-04-06 Eli Zaretskii <eliz@gnu.org>
11088
7c106b1e
EZ
11089 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11090
973f782d
EZ
11091 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11092
41cf7d1a 110932011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11094
ca23cc88
PE
11095 Fix more problems found by GCC 4.6.0's static checks.
11096
f390e2d5
PE
11097 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11098
42eea0d0
PE
11099 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11100
b69769da 11101 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11102
f9541e84
PE
11103 * xdisp.c (vmessage): Mark as a printf-like function.
11104
13841b55
PE
11105 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11106
c136c10f
PE
11107 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11108
5e2d4a30
PE
11109 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11110 printf-like functions.
11111 (tiff_load): Add casts to remove these marks before passing them
11112 to system-supplied API.
11113
583f48b9
PE
11114 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11115
b25d760e
PE
11116 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11117 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11118 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11119 directly, rather than having caller test rule sign. This avoids
11120 some unnecessary tests.
11121 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11122 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11123 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11124
bc7b6697 11125 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11126 (xfont_open): Avoid unnecessary tests.
bc7b6697 11127
27ccc379
PE
11128 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11129
dcd5c89a
PE
11130 * composite.h, composite.c (composition_gstring_put_cache):
11131 Use EMACS_INT, not int, for length.
11132
b13a45c6
PE
11133 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11134 breaking out part of COMPOSITION_DECODE_RULE.
11135 (COMPOSITION_DECODE_RULE): Use it.
11136 * composite.c (get_composition_id): Remove unused local vars,
11137 by using the new macro.
11138
1e792e4d
PE
11139 * textprop.c (set_text_properties_1): Change while to do-while,
11140 since the condition is always true at first.
11141
dc6c6455 11142 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11143 (interval_deletion_adjustment): Return unsigned value.
11144 All uses changed.
dc6c6455 11145
aba7731a
PE
11146 * process.c (list_processes_1, create_pty, read_process_output):
11147 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11148 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11149 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11150 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11151 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11152
fdfc4bf3
PE
11153 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11154
fca8fe46 11155 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11156 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11157
06a0259a 11158 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11159 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11160 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11161
e7b9e80f
PE
11162 * print.c (print_error_message): Avoid int overflow.
11163
56201685
PE
11164 * font.c (font_list_entities): Redo for clarity,
11165 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11166
78834453 11167 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11168 (font_score): Avoid potential overflow in diff calculation.
78834453 11169
0bc0b309 11170 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11171 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11172
e610eaca
PE
11173 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11174
b895abce
PE
11175 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11176 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11177 can always succeed if overflow has undefined behavior.
11178
1f1d9321 11179 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11180 (wordify): Omit three unnecessary tests.
1f1d9321 11181
c59478bc
PE
11182 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11183 All callers changed. This avoids the need for an unused var.
11184
79b73827
PE
11185 * casefiddle.c (casify_region): Remove var that is set but not used.
11186
a4db5dfe
PE
11187 * dired.c (file_name_completion): Remove var that is set but not used.
11188
43aae36e
PE
11189 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11190
2a47c44d 11191 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11192 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11193
a37c69bf
PE
11194 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11195 Check for integer overflow on size calculations.
11196
328ab8e7
PE
11197 * buffer.c (Fprevious_overlay_change): Remove var that is set
11198 but not used.
11199
e5a2a5cb
PE
11200 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11201 Remove vars that are set but not used.
8d84a6eb 11202 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11203 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11204
a60e5f68
PE
11205 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11206
f661cb61 11207 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11208 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11209
f0397f5a
PE
11210 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11211 that are set but not used.
11212
8664db06 11213 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11214 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11215
6abdaa4a
PE
11216 * xselect.c (x_get_local_selection, x_handle_property_notify):
11217 Remove vars that are set but not used.
11218
0ce7538d 11219 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11220 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11221
9ae848fc
PE
11222 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11223 Remove var that is set but not used.
0b918413
PE
11224 (scroll_bar_windows_size): Now size_t, not int.
11225 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11226 Check for overflow.
9ae848fc 11227
a5a62657
PE
11228 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11229 (map_tty_color) [!defined MSDOS]: Likewise.
11230
5c5cdd39
PE
11231 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11232
66ebf983
PE
11233 * coding.c: Remove vars that are set but not used.
11234 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11235 All callers changed.
11236 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11237 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11238 (decode_coding_charset): Remove vars that are set but not used.
11239
1be4d761
PE
11240 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11241 that is set but not used.
11242
47553fa8
PE
11243 * print.c (print_object): Remove var that is set but not used.
11244
1f7196bf 11245 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11246 The gnulib version avoids calling malloc in the usual case,
11247 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11248 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11249 * filelock.c (current_lock_owner): Likewise.
11250 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11251 * sysdep.c: Include allocator.h, careadlinkat.h.
11252 (emacs_no_realloc_allocator): New static constant.
11253 (emacs_readlink): New function.
fdb61804
PE
11254 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11255 ../lib/careadlinkat.h.
d1fdcab7 11256
f84c17c7
SM
112572011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11258
11259 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11260 first non-nil return value).
11261
ef3862ad
JD
112622011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11263
11264 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11265 if not defined (Bug#8403).
11266
376a7006
JB
112672011-04-02 Juanma Barranquero <lekktu@gmail.com>
11268
11269 * xdisp.c (display_count_lines): Remove parameter `start',
11270 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11271 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11272 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11273 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11274 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11275 and thereabouts. All callers changed.
11276 (get_per_char_metric): Remove parameter `f', unused since
11277 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11278
6ca3801d
JM
112792011-04-02 Jim Meyering <meyering@redhat.com>
11280
11281 do not dereference NULL upon failed strdup
11282 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11283 (ns_get_family): Likewise.
11284
d8e2b5ba
JB
112852011-04-02 Juanma Barranquero <lekktu@gmail.com>
11286
11287 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11288
8c74fcbd
JD
112892011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11290
11291 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11292 later (Bug#8403).
11293
7200d79c
SM
112942011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11295
03408648 11296 Add lexical binding.
7200d79c 11297
03408648
SM
11298 * window.c (Ftemp_output_buffer_show): New fun.
11299 (Fsave_window_excursion):
11300 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11301
11302 * lread.c (lisp_file_lexically_bound_p): New function.
11303 (Fload): Bind Qlexical_binding.
11304 (readevalloop): Remove `evalfun' arg.
11305 Bind Qinternal_interpreter_environment.
11306 (Feval_buffer): Bind Qlexical_binding.
11307 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11308 Mark as dynamic.
11309 (syms_of_lread): Declare `lexical-binding'.
11310
11311 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11312
11313 * keyboard.c (eval_dyn): New fun.
11314 (menu_item_eval_property): Use it.
ca105506
SM
11315
11316 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11317
03408648
SM
11318 * fns.c (concat, mapcar1): Accept byte-code-functions.
11319
11320 * eval.c (Fsetq): Handle lexical vars.
11321 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11322 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11323 (FletX, Flet): Obey lexical binding.
11324 (Fcommandp): Handle closures.
11325 (Feval): New `lexical' arg.
11326 (eval_sub): New function extracted from Feval. Use it almost
11327 everywhere where Feval was used. Look up vars in lexical env.
11328 Handle closures.
11329 (Ffunctionp): Move from subr.el.
11330 (Ffuncall): Handle closures.
11331 (apply_lambda): Remove `eval_flags'.
11332 (funcall_lambda): Handle closures and new byte-code-functions.
11333 (Fspecial_variable_p): New function.
11334 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11335 but without exporting it to Lisp.
23aba0ea 11336
23aba0ea 11337 * doc.c (Fdocumentation, store_function_docstring):
03408648 11338 * data.c (Finteractive_form): Handle closures.
23aba0ea 11339
03408648
SM
11340 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11341 interactive spec.
ba83908c 11342
04f2d78b
CB
11343 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11344 New byte-codes.
03408648
SM
11345 (exec_byte_code): New function extracted from Fbyte_code to handle new
11346 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11347
03408648 11348 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11349
03408648 11350 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11351
e2abce01
JB
113522011-03-31 Juanma Barranquero <lekktu@gmail.com>
11353
11354 * xdisp.c (redisplay_internal): Fix prototype.
11355
63696a73 113562011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11357
63696a73 11358 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11359 (try_scrolling): Use it when setting scroll_limit.
11360 Limit scrolling to 100 screen lines.
63696a73
EZ
11361 (redisplay_window): Even when falling back on "recentering",
11362 position point in the window according to scroll-conservatively,
11363 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11364
11365 (try_scrolling): When point is above the window, allow searching
11366 as far as scroll_max, or one screenful, to compute vertical
11367 distance from PT to the scroll margin position. This prevents
11368 try_scrolling from unnecessarily failing when
11369 scroll-conservatively is set to a value slightly larger than the
11370 window height. Clean up the case of PT below the margin at bottom
11371 of window: scroll_max can no longer be INT_MAX. When aggressive
11372 scrolling is in use, don't let point enter the opposite scroll
11373 margin as result of the scroll.
11374 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11375 threshold of 100 lines for never-recentering scrolling.
11376
e4cc2dfc
JB
113772011-03-31 Juanma Barranquero <lekktu@gmail.com>
11378
11379 * dispextern.h (move_it_by_lines):
11380 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11381 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11382 (message_log_check_duplicate): Remove parameters `prev_bol' and
11383 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11384 (redisplay_internal): Remove parameter `preserve_echo_area',
11385 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11386
11387 * indent.c (Fvertical_motion):
11388 * window.c (window_scroll_pixel_based, Frecenter):
11389 Don't pass `need_y_p' to `move_it_by_lines'.
11390
1c470562
SM
113912011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11392
44f230aa
SM
11393 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11394 steal a few bits to be more compact.
11395 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11396 Remove unneeded casts.
11397
1c470562
SM
11398 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11399
888adce9
ZK
114002011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11401
11402 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11403 binding" message (bug#7967).
11404
f838ed7b
PE
114052011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11406
77861b95
PE
11407 Fix more problems found by GCC 4.6.0's static checks.
11408
de6dbc14
PE
11409 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11410 Remove unused local var.
11411
f838ed7b
PE
11412 * editfns.c (Fmessage_box): Remove unused local var.
11413
792c7b2b
PE
11414 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11415 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11416 Omit unused local vars.
c499e557 11417 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11418 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11419 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11420 Omit unused local var.
11421
ba0165e1
PE
11422 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11423 Don't assume string length fits in int.
32ad8845 11424 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11425 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11426
3c59b4c9
PE
11427 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11428 instead of alloca (Bug#8344).
11429
a3eed478 11430 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11431 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11432
eb4d412d
PE
11433 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11434
1658b401
PE
11435 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11436 concerns.
11437
11438 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11439
11440 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11441
9a2c6e05
PE
11442 * keyboard.c (syms_of_keyboard): Use the same style as later
11443 in this function when indexing through an array. This also
11444 works around GCC bug 48267.
11445
03d0a109
PE
11446 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11447
44f730c8
PE
11448 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11449
fe75f926
PE
11450 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11451 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11452
ffa8c828
PE
11453 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11454 This avoids undefined behavior on integer overflow, and is a bit
11455 more convenient anyway since it is compared to a size_t variable.
11456
c5101a77
PE
11457 Variadic C functions now count arguments with size_t, not int.
11458 This avoids an unnecessary limitation on 64-bit machines, which
11459 caused (substring ...) to crash on large vectors (Bug#8344).
11460 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11461 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11462 All variadic functions and their callers changed accordingly.
c5101a77
PE
11463 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11464 * data.c (arith_driver, float_arith_driver): Likewise.
11465 * editfns.c (general_insert_function): Likewise.
11466 * eval.c (struct backtrace.nargs, interactive_p)
11467 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11468 (funcall_lambda, mark_backtrace): Likewise.
11469 * fns.c (concat): Likewise.
11470 * frame.c (x_set_frame_parameters): Likewise.
11471 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11472 0 if not found, not -1. All callers changed.
11473
dd3f25f7
PE
11474 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11475 (stack_copy_size): Now size_t, not int.
11476 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11477
461c2ab9
JB
114782011-03-28 Juanma Barranquero <lekktu@gmail.com>
11479
11480 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11481 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11482 All callers changed.
11483
11484 * lisp.h (multibyte_char_to_unibyte):
11485 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11486 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11487 * character.h (CHAR_TO_BYTE8):
11488 * cmds.c (internal_self_insert):
11489 * editfns.c (general_insert_function):
11490 * keymap.c (push_key_description):
11491 * search.c (Freplace_match):
11492 * xdisp.c (message_dolog, set_message_1): All callers changed.
11493
f6d62986
SM
114942011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11495
11496 * keyboard.c (safe_run_hook_funcall): New function.
11497 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11498 don't set the hook to nil, but remove the offending function instead.
11499 (Qcommand_hook_internal): Remove, unused.
11500 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11501 Vcommand_hook_internal.
11502
11503 * eval.c (enum run_hooks_condition): Remove.
11504 (funcall_nil, funcall_not): New functions.
11505 (run_hook_with_args): Call each function through a `funcall' argument.
11506 Remove `cond' argument, now redundant.
11507 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11508 (Frun_hook_with_args_until_failure): Adjust accordingly.
11509 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11510
1db5b1ad
JB
115112011-03-28 Juanma Barranquero <lekktu@gmail.com>
11512
11513 * dispextern.h (string_buffer_position): Remove declaration.
11514
11515 * print.c (strout): Remove parameter `multibyte', unused since
11516 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11517
11518 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11519 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11520 All callers changed.
11521
11522 * w32.c (_wsa_errlist): Use braces for struct initializers.
11523
11524 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11525 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11526 All callers changed.
11527 (string_buffer_position): Likewise. Also, make static (it's never
11528 used outside xdisp.c).
11529 (cursor_row_p): Remove parameter `w', unused since
11530 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11531 (decode_mode_spec): Remove parameter `precision', introduced during
11532 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11533 All callers changed.
11534
5ffb62aa
JD
115352011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11536
11537 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11538
461c2ab9 115392011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11540
11541 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11542 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11543 (ns_update_auto_hide_menu_bar): New functions.
11544 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11545 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11546 ns_constrain_all_frames.
11547 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11548 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11549
5c380ffb
JD
115502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11551
11552 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11553
9af30bdf
GM
115542011-03-27 Glenn Morris <rgm@gnu.org>
11555
11556 * syssignal.h: Replace RETSIGTYPE with void.
11557 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11558 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11559 Replace SIGTYPE with void everywhere.
11560 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11561 * s/template.h (SIGTYPE): Remove commented out definition.
11562
e2abce01
JB
115632011-03-26 Eli Zaretskii <eliz@gnu.org>
11564
11565 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11566 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11567
f868cd8a
JB
115682011-03-26 Juanma Barranquero <lekktu@gmail.com>
11569
59eb0929
JB
11570 * w32.c (read_unc_volume): Use parameter `henum', instead of
11571 global variable `wget_enum_handle'.
11572
11573 * keymap.c (describe_vector): Remove parameters `indices' and
11574 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11575 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11576
f868cd8a
JB
11577 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11578
11579 * keyboard.c (timer_check): Remove parameter `do_it_now',
11580 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11581 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11582 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11583
11584 * keyboard.c (read_char):
11585 * w32menu.c (w32_menu_display_help):
11586 * xmenu.c (show_help_event, menu_help_callback):
11587 Adjust calls to `show_help_echo'.
11588
11589 * gtkutil.c (xg_maybe_add_timer):
11590 * keyboard.c (readable_events):
11591 * process.c (wait_reading_process_output):
11592 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11593
11594 * insdel.c (adjust_markers_gap_motion):
11595 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11596 (gap_left, gap_right): Don't call it.
11597
2ecf6fdb
CY
115982011-03-25 Chong Yidong <cyd@stupidchicken.com>
11599
11600 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11601 incurred during fontification.
11602
6b1f9ba4
JB
116032011-03-25 Juanma Barranquero <lekktu@gmail.com>
11604
11605 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11606 (DEFVAR_PER_BUFFER): Don't pass it.
11607
11608 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11609 (scrolling_window): Don't pass it.
11610
0f4a96b5
JB
116112011-03-25 Juanma Barranquero <lekktu@gmail.com>
11612
11613 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11614
11615 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11616 and `suffix'.
11617 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11618 of variables specific to SELinux and computation of `encoded_absname'.
11619
11620 * image.c (XPutPixel): Remove unused variable `height'.
11621
11622 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11623
11624 * unexw32.c (get_section_info): Remove unused variable `section'.
11625
11626 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11627 (system_process_attributes): Remove unused variable `sess'.
11628 (sys_read): Remove unused variable `err'.
11629
11630 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11631 (w32_wnd_proc): Remove unused variable `isdead'.
11632 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11633 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11634 (x_create_tip_frame): Remove unused variable `tem'.
11635
11636 * w32inevt.c (w32_console_read_socket):
11637 Remove unused variable `no_events'.
11638
11639 * w32term.c (x_draw_composite_glyph_string_foreground):
11640 Remove unused variable `width'.
11641
1149507c
JB
116422011-03-24 Juanma Barranquero <lekktu@gmail.com>
11643
11644 * w32term.c (x_set_glyph_string_clipping):
11645 Don't pass uninitialized region to CombineRgn.
11646
9c88f339
JB
116472011-03-23 Juanma Barranquero <lekktu@gmail.com>
11648
11649 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11650 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11651 (Fx_close_connection): Remove unused variable `i'.
11652
11653 * w32font.c (w32font_draw): Return number of glyphs.
11654 (w32font_open_internal): Remove unused variable `i'.
11655 (w32font_driver): Add missing initializer.
11656
11657 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11658 (fill_in_menu): Remove unused variable `items_added'.
11659
11660 * w32term.c (last_mouse_press_frame): Remove static global variable.
11661 (w32_clip_to_row): Remove unused variable `f'.
11662 (x_delete_terminal): Remove unused variable `i'.
11663
11664 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11665 (NOTHING): Remove unused static global variable.
11666 (uniscribe_check_otf): Remove unused variable `table'.
11667 (uniscribe_font_driver): Add missing initializers.
11668
dee091a3
JD
116692011-03-23 Julien Danjou <julien@danjou.info>
11670
11671 * term.c (Fsuspend_tty, Fresume_tty):
11672 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11673 * window.c (temp_output_buffer_show):
11674 * insdel.c (signal_before_change):
11675 * frame.c (Fhandle_switch_frame):
11676 * fileio.c (Fdo_auto_save):
11677 * emacs.c (Fkill_emacs):
11678 * editfns.c (save_excursion_restore):
11679 * cmds.c (internal_self_insert):
11680 * callint.c (Fcall_interactively):
11681 * buffer.c (Fkill_all_local_variables):
11682 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11683 Use Frun_hooks.
0f4a96b5 11684 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11685 unconditionally since it does the check itself.
dee091a3 11686
2c520ab5 116872011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11688
c9c49752
PE
11689 Fix more problems found by GCC 4.5.2's static checks.
11690
8abc3f12
PE
11691 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11692 the first time through the loop, since we know p0 < p1 then.
11693 This also avoids a gcc -Wstrict-overflow warning.
11694
a2d26660
PE
11695 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11696 leading to a memory leak, possible in functions like
11697 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11698 of objects (Bug#8318).
a2d26660 11699
916c72e9
PE
11700 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11701 that could (at least in theory) be that large.
11702
19ab8a18
PE
11703 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11704 This is less likely to overflow, and avoids undefined behavior if
11705 overflow does occur. All callers changed. Use strtoul to scan
11706 for the unsigned long integer.
b7cbbd6f
PE
11707 (pint2hrstr): Simplify and tune code slightly.
11708 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11709
f0641eff
PE
11710 * scroll.c (do_scrolling): Work around GCC bug 48228.
11711 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11712
7f650bb9
PE
11713 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11714 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11715 (validate_x_resource_name): Simplify count usage.
11716 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11717
37dd57d1
PE
11718 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11719 fail (Bug#8306).
81e56e61 11720
699979fc 11721 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11722
401bf9b4
PE
11723 * process.c (Fmake_network_process): Use socklen_t, not int,
11724 where POSIX says socklen_t is required in portable programs.
11725 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11726 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11727 (Fmake_network_process, server_accept_connection):
11728 (wait_reading_process_output, read_process_output):
11729 Likewise.
11730
b93aacde
PE
11731 * process.c: Rename or move locals to avoid shadowing.
11732 (list_processes_1, Fmake_network_process):
11733 (read_process_output_error_handler, exec_sentinel_error_handler):
11734 Rename or move locals.
4dc343ee 11735 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11736 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11737 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11738 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11739 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11740
af8a867c 11741 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11742 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11743 Include tparam.h instead, since it declares them.
af8a867c
PE
11744 * cm.h (PC): Remove extern decl; tparam.h now does this.
11745 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11746 * terminfo.c: Include tparam.h, to check interfaces.
11747 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11748 (tparam): Adjust signature to match interface in tparam.h;
11749 this removes some undefined behavior. Check that outstring and len
11750 are zero, which they always are with Emacs.
11751 * tparam.h (PC, BC, UP): New extern decls.
11752
0248044d 11753 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11754 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11755
8ff096c1 11756 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11757 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11758 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11759 (ftfont_list): Remove unused local.
49eaafba
PE
11760 (get_adstyle_property, ftfont_pattern_entity):
11761 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11762 Rename locals to avoid shadowing.
8ff096c1 11763
e2be39f6
PE
11764 * xfont.c (xfont_list_family): Mark var as initialized.
11765
c9735e30
PE
11766 * xml.c (make_dom): Now static.
11767
8f5201ae
PE
11768 * composite.c (composition_compute_stop_pos): Rename local to
11769 avoid shadowing.
b246f932
PE
11770 (composition_reseat_it): Remove unused locals.
11771 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11772 (composition_update_it): Mark var as initialized.
11b61122
PE
11773 (find_automatic_composition): Mark vars as initialized,
11774 with a FIXME (Bug#8290).
8f5201ae 11775
760fbc2c
PE
11776 character.h: Rename locals to avoid shadowing.
11777 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11778 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11779 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11780 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11781 to avoid shadowing.
11782
ff08eb85
PE
11783 * textprop.c (property_change_between_p): Remove; unused.
11784
fc7bf025
PE
11785 * intervals.c (interval_start_pos): Now static.
11786
235d7abc
PE
11787 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11788
44f230aa
SM
11789 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11790 Rename locals to avoid shadowing.
3e7d6594 11791
50060332
PE
11792 * sound.c (wav_play, au_play, Fplay_sound_internal):
11793 Fix pointer signedness.
d01f234b 11794 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11795 (wav_play): Initialize a variable to 0, to prevent undefined
11796 behavior (Bug#8278).
50060332 11797
c4fc4e30
PE
11798 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11799
918436ed
PE
11800 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11801
c939f91b
PE
11802 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11803 clobbering (Bug#8298).
b9c7f648
PE
11804 * sysdep.c (sys_subshell): Likewise.
11805 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11806
6bd8c144
PE
11807 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11808 This should get cleaned up, so that child_setup has the
11809 same signature on all platforms.
11810
7710357c 11811 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11812 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11813
c59da222
CY
118142011-03-22 Chong Yidong <cyd@stupidchicken.com>
11815
11816 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11817 not to be necessary, and produces flickering.
11818
66b87493
GM
118192011-03-20 Glenn Morris <rgm@gnu.org>
11820
11821 * config.in: Remove file.
11822
45b6f6d5
JB
118232011-03-20 Juanma Barranquero <lekktu@gmail.com>
11824
11825 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11826 are now in src/globals.h.
11827 (syms_of_minibuf): Remove spurious & from previous change.
11828
cd394be1 118292011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11830
11831 * minibuf.c (completing-read-function): New variable.
11832 (completing-read-default): Rename from completing-read.
11833 (completing-read): Call completing-read-function.
11834
b14e3e21
CY
118352011-03-19 Juanma Barranquero <lekktu@gmail.com>
11836
11837 * xfaces.c (Fx_load_color_file):
11838 Read color file from absolute filename (bug#8250).
11839
f2b726e6
JB
118402011-03-19 Juanma Barranquero <lekktu@gmail.com>
11841
11842 * makefile.w32-in: Update dependencies.
11843
09f6ff02
EZ
118442011-03-17 Eli Zaretskii <eliz@gnu.org>
11845
11846 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11847
29a6015a
PE
118482011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11849
a3a6c54e
PE
11850 Fix more problems found by GCC 4.5.2's static checks.
11851
b766f867
PE
11852 * process.c (make_serial_process_unwind, send_process_trap):
11853 (sigchld_handler): Now static.
11854
be02381c
PE
11855 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11856 That way, the code declares only the vars that it needs.
11857 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11858 * s/cygwin.h (PTY_ITERATION): Likewise.
11859 * s/darwin.h (PTY_ITERATION): Likewise.
11860 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11861
57048744
PE
11862 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11863 * process.c (allocate_pty): Don't declare stb unless it's needed.
11864
7914961c 11865 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11866 (CONSTANTLIM): Remove; unused.
11867 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11868 Define only if needed.
7914961c 11869
b3967b18
PE
11870 * unexelf.c (unexec): Name an expression,
11871 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11872 Use a different way to cause a compilation error if anyone uses
11873 n rather than nn, a way that does not involve shadowing.
73366a00 11874 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11875
29a6015a
PE
11876 * deps.mk (unexalpha.o): Remove; unused.
11877
43cfc33e 11878 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11879 * unexec.h: New file.
ce701a33
PE
11880 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11881 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11882 Depend on unexec.h.
11883 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11884 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11885 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11886 Change as necessary to match prototype in unexec.h.
ce701a33 11887
01f44d5a
PE
11888 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11889 shadowing.
4f63c6bb 11890 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11891
a6670b0b
PE
11892 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11893 Rename locals to avoid shadowing.
11894
cef2010d 11895 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11896 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11897
d4d7173a
PE
11898 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11899
f08b802a
PE
11900 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11901 warning when compiling print.c.
11902
3ddb0639
PE
11903 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11904 instead of using an uninitialized var.
5ad03b97 11905 (font_sort_entities): Mark var as initialized.
3ddb0639 11906
170a2692
PE
11907 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11908
e663c700
PE
11909 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11910 pointers to constants.
89bc529a 11911 (font_parse_fcname): Remove unused vars.
7b81e2d0 11912 (font_delete_unmatched): Now static.
ea838e10 11913 (font_get_spec): Remove; unused.
13a547c6
PE
11914 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11915 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11916 Rename or move locals to avoid shadowing.
e663c700 11917
2a80c887 11918 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11919 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11920
1384fa33 11921 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11922 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11923
8b2c52e9
PE
11924 * alloc.c (mark_backtrace): Move decl from here ...
11925 * lisp.h: ... to here, so that it can be checked.
11926
475545b5 11927 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11928 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11929 (lisp_indirect_variable): Name an expression,
11930 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11931 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11932
b1349114 11933 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11934 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11935 Use const pointer when appropriate.
b1349114 11936
a2928364
PE
11937 * lisp.h (get_system_name, get_operating_system_release):
11938 Move decls here, to check interfaces.
11939 * process.c (get_operating_system_release): Move decl to lisp.h.
11940 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11941 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11942 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11943 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11944 (Fformat_time_string, Fencode_time, Finsert_char):
11945 (Ftranslate_region_internal, Fformat):
11946 Rename or remove local vars to avoid shadowing.
9710023e 11947 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11948
a415e694
PE
11949 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11950 avoid shadowing.
11951
8ef4622d
PE
11952 * lisp.h (eassert): Check that the argument compiles, even if
11953 ENABLE_CHECKING is not defined.
11954
946f9a5b
PE
11955 * data.c (Findirect_variable): Name an expression, to avoid
11956 gcc -Wbad-function-cast warning.
112396d6 11957 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11958 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11959 (Fmake_variable_buffer_local, Fmake_local_variable):
11960 Mark variables as initialized.
52746918 11961 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11962
e5aab7e7 11963 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11964 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11965 Rename locals to avoid shadowing.
dff45157
PE
11966 (mark_stack): Move local variables into the #ifdef region where
11967 they're used.
7bc26fdb
PE
11968 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11969 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11970 needed otherwise.
11971 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11972 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11973 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11974
e5aab7e7
PE
11975 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11976 avoids undefined behavior in theory.
11977
4da60324
PE
11978 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11979
88043301
PE
11980 Use functions, not macros, for up- and down-casing (Bug#8254).
11981 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11982 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11983 to use the following functions instead of these macros.
11984 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11985 EMACS_INT, since callers assume the returned value fits in int.
11986 (upcase1): Likewise, for UPCASE_TABLE.
11987 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11988 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11989 the race-condition problem in the old DOWNCASE.
88043301 11990
19ed5445
PE
11991 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11992 Rename locals to avoid shadowing.
11993 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11994 (regex_compile, re_search_2, re_match_2_internal):
11995 Remove unused local vars.
952db0d7
PE
11996 (FREE_VAR): Rewrite so as not to use empty "else",
11997 which gcc can warn about.
da053e48 11998 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11999 (RETALLOC_IF): Define only if needed.
12000 (WORDCHAR_P): Likewise. This one is never needed, but is used
12001 only in a comment talking about a compiler bug, so put inside
12002 the #if 0 of that comment.
12003 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12004 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12005 Remove; unused.
19ed5445 12006
1f3561e4 12007 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12008 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12009 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12010
ded6f8f7
PE
12011 * search.c (simple_search): Remove unused var.
12012
dbd37a95
PE
12013 * dired.c (compile_pattern): Move decl from here ...
12014 * lisp.h: ... to here, so that it can be checked.
12015 (struct re_registers): New forward decl.
12016
7e47afad
PE
12017 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12018
85f24f61
PE
12019 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12020 All uses changed.
12021 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12022 Rename locals to avoid shadowing.
5671df8f 12023 (Fvertical_motion): Mark locals as initialized.
85f24f61 12024
181aa2be 12025 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12026 (casify_region): Mark local as initialized.
181aa2be 12027
930d429c
PE
12028 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12029
7082eac6
PE
12030 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12031 New macros, so that the caller can use some names other than
12032 gcpro1, gcpro2, etc.
12033 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12034 of the new macros.
12035 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12036 argument, for consistency with GCPRO2_VAR, etc: it is now the
12037 prefix of the variable, not the variable itself. All uses
12038 changed.
38b2c076
PE
12039 * dired.c (directory_files_internal, file_name_completion):
12040 Rename locals to avoid shadowing.
12041
15206ed9
PE
12042 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12043 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12044 dired.c's scmp function, had undefined behavior.
12045 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12046 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12047 * buffer.h: ... to here, because these macros use current_buffer,
12048 and the new implementation with inline functions needs to have
12049 current_buffer in scope now, rather than later when the macros
12050 are used.
12051 (downcase, upcase1): New static inline functions.
12052 (DOWNCASE, UPCASE1): Reimplement using these functions.
12053 This avoids undefined behavior in expressions like
12054 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12055 from race conditions in accessing the global variables
12056 case_temp1 and case_temp2.
12057 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12058 * lisp.h (case_temp1, case_temp2): Remove their decls.
12059 * character.h (ASCII_CHAR_P): Move from here ...
12060 * lisp.h: ... to here, so that the inline functions mentioned
12061 above can use them.
12062
4a6bea26
PE
12063 * dired.c (directory_files_internal_unwind): Now static.
12064
f14b7e14
PE
12065 * fileio.c (file_name_as_directory, directory_file_name):
12066 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12067 Now static.
2893f146
PE
12068 (file_name_as_directory): Use const pointers when appropriate.
12069 (Fexpand_file_name): Likewise. In particular, newdir might
12070 point at constant storage, so make it a const pointer.
fd4ead52 12071 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12072 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12073 signedness issues.
f839df0c
PE
12074 (Fset_file_times, Finsert_file_contents, auto_save_error):
12075 Rename locals to avoid shadowing.
f14b7e14 12076
5716756e 12077 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12078 (Ftry_completion, Fall_completions): Rename or remove locals
12079 to avoid shadowing.
5716756e 12080
b4c3046a
PE
12081 * marker.c (bytepos_to_charpos): Remove; unused.
12082
b45db522
PE
12083 * lisp.h (verify_bytepos, count_markers): New decls,
12084 so that gcc does not warn that these functions aren't declared.
12085
85876d07
PE
12086 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12087 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12088 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12089 (copy_text): Remove unused local var.
85876d07 12090
03d78a21 12091 * filelock.c (within_one_second): Now static.
b3dd38ab 12092 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12093
5df8f01b
PE
12094 * buffer.c (fix_overlays_before): Mark locals as initialized.
12095 (fix_start_end_in_overlays): Likewise. This function should be
12096 simplified by using pointers-to-pointers, but that's a different
12097 matter.
b1d876f1 12098 (switch_to_buffer_1): Now static.
8f54f30a
PE
12099 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12100 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12101
a70072c9 12102 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12103 Fix pointer signedness issue.
edced198
PE
12104 (sys_subshell): Mark local as volatile if checking for lint,
12105 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12106 (MAXPATHLEN): Define only if needed.
a70072c9 12107
a0977c44
PE
12108 * process.c (serial_open, serial_configure): Move decls from here ...
12109 * systty.h: ... to here, so that they can be checked.
12110
a884fdcc
PE
12111 * fns.c (get_random, seed_random): Move extern decls from here ...
12112 * lisp.h: ... to here, so that they can be checked.
12113
604efe86 12114 * sysdep.c (reset_io): Now static.
b8950c94 12115 (wait_for_termination_signal): Remove; unused.
604efe86 12116
38fc62d9
PE
12117 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12118 (copy_keymap_item, append_key, push_text_char_description):
12119 Now static.
1004a21a 12120 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12121 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12122 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12123 (describe_map_tree):
12124 Rename locals to avoid shadowing.
38fc62d9 12125
2f2650da
PE
12126 * keyboard.c: Declare functions static if they are not used elsewhere.
12127 (echo_char, echo_dash, cmd_error, top_level_2):
12128 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12129 (read_char, kbd_buffer_get_event, make_lispy_position):
12130 (make_lispy_event, make_lispy_movement, apply_modifiers):
12131 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12132 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12133 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12134 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12135 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12136
a053e86c 12137 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12138 (mark_kboards): Move decl here ...
12139 * alloc.c (mark_kboards): ... from here.
a053e86c 12140
4752793e
PE
12141 * lisp.h (force_auto_save_soon): New decl.
12142
74f10ca7 12143 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12144 (DEFINE_DUMMY_FUNCTION): New macro.
12145 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12146 Use it.
c03cd23f
PE
12147 (main): Add casts to avoid warnings
12148 if GCC considers string literals to be constants.
74f10ca7 12149
022e70d4
PE
12150 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12151
59d6fe83
PE
12152 * dbusbind.c: Pointer signedness fixes.
12153 (xd_signature, xd_append_arg, xd_initialize):
12154 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12155 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12156 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12157 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12158
78320123
PE
12159 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12160 if GCC considers string literals to be constants.
49cebcca 12161 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12162
35ac2a97
SM
121632011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12164
fb103ca9
SM
12165 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12166 (print_preprocess, print_object): New macro to fix last change.
12167
35ac2a97
SM
12168 * print.c (print_preprocess): Don't forget font objects.
12169
62973b41
JB
121702011-03-16 Juanma Barranquero <lekktu@gmail.com>
12171
12172 * emacs.c (USAGE3): Doc fixes.
12173
0e48bb22
AS
121742011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12175
12176 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12177 structure.
12178
7684e57b
JB
121792011-03-14 Juanma Barranquero <lekktu@gmail.com>
12180
12181 * lisp.h (VWindow_system, Qfile_name_history):
12182 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12183 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12184 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12185
12186 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12187 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12188
12189 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12190 * w32console.c (detect_input_pending, read_input_pending)
12191 (encode_terminal_code):
12192 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12193 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12194 (w32_system_caret_y, Qfile_name_history):
12195 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12196 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12197 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12198 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12199 * w32proc.c (Qlocal, report_file_error):
12200 * w32term.c (Vwindow_system, updating_frame):
12201 * w32uniscribe.c (initialized, uniscribe_font_driver):
12202 Remove unneeded extern declarations.
12203
2aa46d6c
CY
122042011-03-14 Chong Yidong <cyd@stupidchicken.com>
12205
c96bbc66 12206 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12207
cffc6f3b
CY
122082011-03-13 Chong Yidong <cyd@stupidchicken.com>
12209
12210 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12211 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12212 These macros can no longer be used for assignment.
12213
44f230aa
SM
12214 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12215 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12216 (record_buffer_markers, fetch_buffer_markers): New functions for
12217 recording and fetching special buffer markers.
12218 (set_buffer_internal_1, set_buffer_temp): Use them.
12219
12220 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12221
12222 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12223
12224 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12225 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12226
12227 * xdisp.c (hscroll_window_tree):
12228 (reconsider_clip_changes): Use PT instead of BUF_PT.
12229
d251f04b
EZ
122302011-03-13 Eli Zaretskii <eliz@gnu.org>
12231
12232 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12233 $(EMACS_ROOT)/lib/intprops.h.
12234
f0c77cd1
PE
122352011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12236
3eca4629
PE
12237 Fix more problems found by GCC 4.5.2's static checks.
12238
7c86ee98
PE
12239 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12240 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12241 (xg_free_frame_widgets): Make it clear that a local variable is
12242 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12243 (gdk_window_get_screen): Make it clear that this macro is needed
12244 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12245 (int_gtk_range_get_value): New function, which avoids a diagnostic
12246 from gcc -Wbad-function-cast.
12247 (xg_set_toolkit_scroll_bar_thumb): Use it.
12248 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12249 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12250 (get_utf8_string, xg_get_file_with_chooser):
12251 Rename locals to avoid shadowing.
12252 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12253
41729b81
PE
12254 * xgselect.c (xg_select): Remove unused var.
12255
f0c77cd1
PE
12256 * image.c (four_corners_best): Mark locals as initialized.
12257 (gif_load): Initialize transparent_p to zero (Bug#8238).
12258 Mark another local as initialized.
ec6cf4c6 12259 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12260
ce0ad53d 12261 * image.c (clear_image_cache): Now static.
d5d5a617 12262 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12263 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12264 (x_edge_detection): Remove unnecessary cast that
12265 gcc -Wbad-function-cast diagnoses.
2037898d 12266 (gif_load): Fix pointer signedness.
6ae141d6
PE
12267 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12268 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12269
33383987 122702011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12271
d32df629
PE
12272 Improve quality of tests for time stamp overflow.
12273 For example, without this patch (encode-time 0 0 0 1 1
12274 1152921504606846976) returns the obviously-bogus value (-948597
12275 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12276 reports time overflow. See
12277 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12278 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12279 * editfns.c: Include limits.h and intprops.h.
12280 (TIME_T_MIN, TIME_T_MAX): New macros.
12281 (time_overflow): Move earlier, to before first use.
12282 (hi_time, lo_time): New functions, for an accurate test for
12283 out-of-range times.
12284 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12285 (Fget_internal_run_time): Don't assume time_t fits in int.
12286 (make_time): Use list2 instead of Fcons twice.
12287 (Fdecode_time): More accurate test for out-of-range times.
12288 (check_tm_member): New function.
12289 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12290 (lisp_time_argument): Don't rely on undefined left-shift and
12291 right-shift behavior when checking for time stamp overflow.
8be6f318 12292
fe31d94c
PE
12293 * editfns.c (time_overflow): New function, refactoring common code.
12294 (Fformat_time_string, Fdecode_time, Fencode_time):
12295 (Fcurrent_time_string): Use it.
12296
8be6f318
PE
12297 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12298 * dired.c (make_time): Move to ...
12299 * editfns.c (make_time): ... here.
12300 * systime.h: Note the move.
12301
09d9db2c 123022011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12303
126bc0dc
YM
12304 * fringe.c (update_window_fringes): Remove unused variables.
12305
c47cbdfd
YM
12306 * unexmacosx.c (copy_data_segment): Also copy __got section.
12307 (Bug#8223)
12308
7ac80be9
EZ
123092011-03-12 Eli Zaretskii <eliz@gnu.org>
12310
c96bbc66 12311 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12312 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12313 Constify `char *' arguments and their references according to
12314 prototypes in tparam.h.
12315
ecb0f94d 12316 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12317
7ac80be9
EZ
12318 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12319 Adapt all references accordingly.
12320
12321 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12322
ef1fd07e
TT
123232011-03-11 Tom Tromey <tromey@redhat.com>
12324
12325 * buffer.c (syms_of_buffer): Remove obsolete comment.
12326
7ef4b50c
EZ
123272011-03-11 Eli Zaretskii <eliz@gnu.org>
12328
12329 * termhooks.h (encode_terminal_code): Declare prototype.
12330
12331 * msdos.c (encode_terminal_code): Don't declare prototype.
12332
12333 * term.c (encode_terminal_code): Now external again, used by
12334 w32console.c and msdos.c.
12335
44f230aa
SM
12336 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12337 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12338
4b1ec863 123392011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12340
1714f52b 12341 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12342
4b1ec863
PE
12343 * fringe.c (update_window_fringes): Mark locals as initialized
12344 (Bug#8227).
12345 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12346
524c7aa6
PE
12347 * alloc.c (mark_fringe_data): Move decl from here ...
12348 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12349 to check its interface.
12350 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12351
a5c0af81 12352 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12353 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12354 (fontset_font): Mark local as initialized.
a9a06e0b 12355 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12356
b4716021
PE
12357 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12358
811e9bac 12359 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12360 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12361 (x_own_selection, Fx_disown_selection_internal): Rename locals
12362 to avoid shadowing.
12363 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12364
7e3ab302
PE
12365 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12366 so that the caller can use some name other than gcpro1.
12367 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12368 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12369 (Fx_backspace_delete_keys_p):
12370 Use them to avoid shadowing, and rename vars to avoid shadowing.
12371 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12372 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12373 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12374 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12375 Remove unused locals.
7e3ab302
PE
12376 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12377 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12378 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12379 macros.
f78faa98 12380
e2b13473
PE
12381 * xterm.h (x_mouse_leave): New decl.
12382
77f23912
PE
12383 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12384 Remove unused functions.
cdf4ba58
PE
12385 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12386 (x_calc_absolute_position): Now static.
7411c686 12387 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12388 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12389 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12390 unless they are used.
38d0b34a
PE
12391 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12392 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12393 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12394 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12395 (x_error_catcher, x_connection_closed, x_error_handler):
12396 (x_error_quitter, xembed_send_message, x_iconify_frame):
12397 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12398 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12399 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12400
44f230aa
SM
12401 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12402 Rename or move locals to avoid shadowing.
6b463e58 12403 (tty_defined_color, merge_face_heights): Now static.
5967d051 12404 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12405 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12406 does not deduce is never used uninitialized.
73719eba
PE
12407 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12408 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12409
426994c3 12410 * terminal.c (store_terminal_param): Now static.
5489860b 12411
032f1620 12412 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12413 (set_frame_menubar): Remove unused local.
d4323972 12414 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12415 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12416 since they might point to immutable storage.
281585b0
PE
12417 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12418 since it's unused otherwise.
032f1620 12419
367c19e5 12420 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12421 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12422 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12423 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12424 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12425 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12426 does not deduce are never used uninitialized.
70739cbe 12427
07b48fa9
PE
12428 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12429
8868a238 12430 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12431 * window.c (window_loop, size_window):
12432 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12433
7e5cf297 12434 * window.c (display_buffer): Now static.
d6550a9f
PE
12435 (size_window): Mark variables that gcc -Wuninitialized
12436 does not deduce are never used uninitialized.
a586633d
PE
12437 * window.h (check_all_windows): New decl, to forestall
12438 gcc -Wmissing-prototypes diagnostic.
5b555da1 12439 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12440
f6095868
PE
12441 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12442 shadowing.
12443 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12444 Include <limits.h>.
12445 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12446 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12447 (load_charset_map): Mark variables that gcc -Wuninitialized
12448 does not deduce are never used uninitialized.
53df7c11 12449 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12450
f38b440c
PE
12451 * coding.c (coding_set_source, coding_set_destination):
12452 Use "else { /* comment */ }" rather than "else /* comment */;"
12453 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12454 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12455 a block, when the outer 'i' will do.
12456 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12457 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12458 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12459 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12460 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12461 Rename locals to avoid shadowing.
12462 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12463 * coding.c (emacs_mule_char, encode_invocation_designation):
12464 Now static, since they're not used elsewhere.
413bb2db 12465 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12466 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12467 (decode_coding_emacs_mule): Mark variables that gcc
12468 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12469 (detect_coding_iso_2022): Initialize a local variable that might
12470 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12471 this initialization is needed. (Bug#8211)
5f58e762
PE
12472 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12473 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12474 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12475 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12476 Remove unused macros.
f38b440c 12477
232b38b9 12478 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12479 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12480 * character.c (string_count_byte8): Likewise.
232b38b9 12481
fb90da1b
PE
12482 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12483 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12484
fb93dbc2
PE
12485 * chartab.c (copy_sub_char_table): Now static, since it's not used
12486 elsewhere.
5c156ace
PE
12487 (sub_char_table_ref_and_range, char_table_ref_and_range):
12488 Rename locals to avoid shadowing.
bbcd0949 12489 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12490
7d3b3862 12491 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12492 (BIDI_BOB): Remove unused macro.
7d3b3862 12493
6be7d3da
PE
12494 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12495 deduce are never used uninitialized.
c2ed9c8b 12496 * term.c (encode_terminal_code): Likewise.
6be7d3da 12497
75f8807f 12498 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12499
50938595
PE
12500 * tparam.h: New file.
12501 * term.c, tparam.h: Include it.
12502 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12503 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12504 Move these decls to tparam.h, and make them agree with what
12505 is actually in tparam.c. The previous trick of using incompatible
12506 decls in different modules does not conform to the C standard.
12507 All callers of tparam changed to use tparam's actual API.
12508 * tparam.c (tparam1, tparam, tgoto):
12509 Use const pointers where appropriate.
12510
fbceeba2
PE
12511 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12512 * cm.h (struct cm): Likewise.
12513 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12514 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12515 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12516 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12517 (turn_on_face, init_tty): Likewise.
12518 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12519
7f3f1250
PE
12520 * term.c (term_mouse_position): Rename local to avoid shadowing.
12521
e6ca6543
PE
12522 * alloc.c (mark_ttys): Move decl from here ...
12523 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12524
c40f8d15
AS
125252011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12526
12527 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12528
cfe0661d
JB
125292011-03-09 Juanma Barranquero <lekktu@gmail.com>
12530
12531 * search.c (compile_pattern_1): Remove argument regp, unused since
12532 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12533 (compile_pattern): Don't pass it.
12534
0afb4571
J
125352011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12536
12537 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12538 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12539 for ! HAVE_GTK3.
12540 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12541
12542 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12543
12544 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12545 gdk_window_get_screen, gdk_window_get_geometry,
12546 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12547 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12548 (xg_get_pixbuf_from_pixmap): New function.
12549 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12550 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12551 Call xg_get_pixbuf_from_pixmap instead of
12552 gdk_pixbuf_get_from_drawable.
12553 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12554 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12555 (xg_check_special_colors): Use GtkStyleContext and its functions
12556 for HAVE_GTK3.
12557 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12558 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12559 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12560 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12561 Call gtk_widget_get_preferred_size.
0afb4571
J
12562 (xg_frame_resized): gdk_window_get_geometry only takes 5
12563 parameters.
44f230aa
SM
12564 (xg_win_to_widget, xg_event_is_for_menubar):
12565 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12566 (xg_set_widget_bg): New function.
12567 (delete_cb): New function.
895009e1 12568 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12569 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12570 (xg_set_background_color): Call xg_set_widget_bg.
12571 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12572 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12573 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12574 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12575 if ! HAVE_GTK3.
12576 (update_frame_tool_bar): Call gtk_widget_hide.
12577 (xg_initialize): Use GDK_KEY_g.
12578
12579 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12580 if ! HAVE_GTK3
12581 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12582
12583 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12584 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12585 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12586
1c2cc4ef
JB
125872011-03-08 Juanma Barranquero <lekktu@gmail.com>
12588
12589 * w32xfns.c (select_palette): Check success of RealizePalette against
12590 GDI_ERROR, not zero.
12591
33383987 12592See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12593
12594;; Local Variables:
12595;; coding: utf-8
aac0c6e3
MR
12596;; End:
12597
2f097256 12598 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12599
12600 This file is part of GNU Emacs.
12601
12602 GNU Emacs is free software: you can redistribute it and/or modify
12603 it under the terms of the GNU General Public License as published by
12604 the Free Software Foundation, either version 3 of the License, or
12605 (at your option) any later version.
12606
12607 GNU Emacs is distributed in the hope that it will be useful,
12608 but WITHOUT ANY WARRANTY; without even the implied warranty of
12609 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12610 GNU General Public License for more details.
12611
12612 You should have received a copy of the GNU General Public License
12613 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.