* doc/misc/ert.texi: Whitespace trivia to make main menu items line up better.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e9b5f888
AS
12011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2
3 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5 matching a pp-number. Rename parameter var to var1.
6
127827c0
SM
72011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
8
9 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
10
c8fd3bd0
GM
112011-10-08 Glenn Morris <rgm@gnu.org>
12
13 * callint.c (Fcall_interactively): Give a more explicit error for the
14 'c' case with a non-character input. (Bug#8479)
15
352ec8ff
EZ
162011-10-08 Eli Zaretskii <eliz@gnu.org>
17
03669ccb
EZ
18 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
19 lines.
7061c986
EZ
20 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
21 lines that are hscrolled on the left.
03669ccb 22
352ec8ff
EZ
23 * dispnew.c (buffer_posn_from_coords): Account for a possible
24 presence of header-line. (Bug#4426)
25
a66cfb1c
SM
262011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
27
28 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
29 advertise functionality which we discourage or doesn't work.
30
7c5ee88e
PE
312011-10-07 Paul Eggert <eggert@cs.ucla.edu>
32
33 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
34 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
35 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
36 this makes Emacs dump core during garbage collection on rare
37 occasions. sizeof is obviously inferior to offsetof here, so
38 stick with offsetof.
39 (GC_POINTER_ALIGNMENT): New macro.
40 (mark_memory): Omit 3rd (offset) arg; caller changed.
41 Don't assume EMACS_INT alignment is the same as pointer alignment.
42
df1bbe5b
SM
432011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
44
45 * keyboard.c (read_key_sequence_remapped): New var.
46 (read_key_sequence): Compute remapping in the right buffer.
47 (command_loop_1): Use read_key_sequence's remapping directly.
48
51553db6
SM
492011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
50
32c1fffd
SM
51 * dired.c (file_name_completion): Don't expand file name.
52 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
53 before checking file name handler.
54
51553db6
SM
55 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
56 they've been requested explicitly (bug#9591).
57
b6bd1599 582011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
59
60 * keymap.c (Fsingle_key_description): Use make_specified_string
61 instead of build_string to build string from push_key_description.
62 (Bug#5193)
63
f701dc2a
PE
642011-09-30 Paul Eggert <eggert@cs.ucla.edu>
65
4222c55d
PE
66 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
67 This fixes a Y2038 bug on 64-bit hosts.
68 * buffer.c (reset_buffer):
69 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
70 (Fclear_buffer_auto_save_failure):
71 Use 0, not -1, to represent an unset failure time, since time_t
72 might not be signed.
73
f701dc2a
PE
74 Remove dependency on glibc malloc internals.
75 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
76 Move back here from lisp.h, but with their new implementations.
77 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
78 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
79 * charset.c (charset_table_init): New static var.
80 (syms_of_charset): Use it instead of xmalloc. This removes a
81 dependency on glibc malloc internals. See Eli Zaretskii's comment in
82 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
83 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
84 Move back to alloc.c.
85 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
86 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
87
9ceebf39
JD
882011-09-30 Jan Djärv <jan.h.d@swipnet.se>
89
90 * nsterm.m (windowDidResize): Call x_set_window_size only when
91 ns_in_resize is true. Otherwise set pixelwidth/height and
92 call change_frame_size (Bug#9628).
93
cb993c58
PE
942011-09-30 Paul Eggert <eggert@cs.ucla.edu>
95
3930c88b
PE
96 Port --enable-checking=all to Fedora 14 x86-64.
97 * charset.c (syms_of_charset): Also account for glibc malloc's
98 internal overhead when calculating the initial malloc maximum.
99
cb993c58
PE
100 Port --enable-checking=all to Fedora 14 x86.
101 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
102 Move to lisp.h.
103 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
104 (overrun_check_realloc, overrun_check_free):
105 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
106 That way, xmalloc returns a properly-aligned pointer even if
107 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
108 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
109 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
110 into account when calculating the initial malloc maximum.
111 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
112 Move here from alloc.c, so that charset.c can use it too.
113 Properly align; the old code wasn't right for common 32-bit hosts
114 when configured with --enable-checking=all.
115 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
116 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
117
31bed486
EZ
1182011-09-29 Eli Zaretskii <eliz@gnu.org>
119
04c70788 120 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
121 use EDOM.
122
fbcaa2f3
EZ
1232011-09-28 Eli Zaretskii <eliz@gnu.org>
124
125 * xdisp.c (compute_display_string_end): If there's no display
126 string at CHARPOS, return -1.
127
128 * bidi.c (bidi_fetch_char): When compute_display_string_end
129 returns a negative value, treat the character as a normal
130 character not covered by a display string. (Bug#9624)
131
a239d4e9
JB
1322011-09-28 Juanma Barranquero <lekktu@gmail.com>
133
134 * lread.c (Fread_from_string): Fix typo in docstring.
135
88652fd5
EZ
1362011-09-27 Eli Zaretskii <eliz@gnu.org>
137
138 * xdisp.c (handle_invisible_prop): If invisible text ends on a
139 newline, reseat the iterator instead of bidi-iterating there one
140 character at a time. (Bug#9610)
32c1fffd
SM
141 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
142 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 143
ed497dd4
AS
1442011-09-27 Andreas Schwab <schwab@linux-m68k.org>
145
146 * lread.c (readevalloop): Use correct code for NBSP.
147 (read1): Likewise. (Bug#9608)
148
b2bf61aa
MA
1492011-09-25 Michael Albinus <michael.albinus@gmx.de>
150
151 * dbusbind.c (Fdbus_register_signal): When service is not
152 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
153
32bbb17c
GM
1542011-09-25 Glenn Morris <rgm@gnu.org>
155
156 * buffer.c (truncate-lines): Doc fix.
157
94e0933e
CY
1582011-09-24 Chong Yidong <cyd@stupidchicken.com>
159
160 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
161 (Fset_window_next_buffers): Doc fix.
162
cddde921
GM
1632011-09-24 Glenn Morris <rgm@gnu.org>
164
165 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
166
1260aef1
PE
1672011-09-24 Paul Eggert <eggert@cs.ucla.edu>
168
25b4bfa0
PE
169 Fix minor problems found by static checking.
170 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
171 * indent.c (Fvertical_motion): Fix == vs = typo.
172
e3cbd34b
EZ
1732011-09-24 Eli Zaretskii <eliz@gnu.org>
174
a66cfb1c
SM
175 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
176 Default value is now t. Doc fix.
6bf7006f 177
e3cbd34b 178 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 179 logic when moving up, not only when moving down. Fix the
e3cbd34b 180 confusing name and values of the it_overshoot_expected variable;
32c1fffd 181 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
182
183 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
184 CHARPOS is covered by a display string which includes newlines.
185 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
186 is covered by a display string with embedded newlines.
187
a3de0cbd
MA
1882011-09-24 Michael Albinus <michael.albinus@gmx.de>
189
190 * dbusbind.c (Fdbus_register_signal): Add match rule to
191 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
192 (Fdbus_register_method, Vdbus_registered_objects_table):
193 Fix docstring.
a3de0cbd 194
b260039d
JM
1952011-09-24 Jim Meyering <meyering@redhat.com>
196
32c1fffd 197 do not ignore write error for any output size
b260039d
JM
198 The previous change was incomplete.
199 While it makes emacs --batch detect the vast majority of stdout
200 write failures, errors were still ignored whenever the output size is
201 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
202 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
203 && echo FAIL: ignored write error
204 FAIL: ignored write error
205 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
206 && echo FAIL: ignored write error
207 FAIL: ignored write error
208 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
209
8eca8a7c
AS
2102011-09-23 Andreas Schwab <schwab@linux-m68k.org>
211
212 * emacs.c (Fkill_emacs): In noninteractive mode exit
213 non-successfully if a write error occurred on stdout. (Bug#9574)
214
3341db62
EZ
2152011-09-21 Eli Zaretskii <eliz@gnu.org>
216
217 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
218 the xassert test.
219
220 * dispextern.h (struct it): Update the comment documenting what
221 can it->OBJECT be.
222
8c203dbf
EZ
2232011-09-20 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
226 a display string, extend search for cursor position to end of row.
227 (find_row_edges): If the row ends in a newline from a display
228 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
229 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
230 (Fcurrent_bidi_paragraph_direction): Fix search for previous
231 non-empty line. Fixes confusing cursor motion with arrow keys at
232 the beginning of a line that starts with whitespace.
8c203dbf 233
a4824228
LMI
2342011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
235
236 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
237 (bug#9493).
238
33ed493b
CY
2392011-09-18 Chong Yidong <cyd@stupidchicken.com>
240
241 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
242 boolean (Bug#9154).
243
56cd55c8
EZ
2442011-09-18 Eli Zaretskii <eliz@gnu.org>
245
246 * xdisp.c (display_line): Record maximum and minimum buffer
247 positions even if no glyphs were produced (e.g., by a zero-width
248 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
249 buffer positions that will be removed from the glyph row because
250 they don't fit.
c02dcedf
EZ
251 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
252 column is beyond frame width: don't subtract 1 "pixel" when
253 computing width of the stretch.
3e62b7e0
EZ
254 (reseat_at_next_visible_line_start): Undo the change made on
255 2011-09-17 that saved paragraph information and restored it after
256 the call to `reseat'. (Bug#9545)
56cd55c8 257
5ed99d36 2582011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
259
260 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
261 and turn window cursor on if cleared (Bug#9415).
262
5ed99d36 2632011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
264
265 * search.c (boyer_moore): Take unibyte characters from pattern
266 literally. (Bug#9458)
267
9bade7b2
EZ
2682011-09-18 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
271
e5e9d610
PE
2722011-09-18 Paul Eggert <eggert@cs.ucla.edu>
273
87e4427a
PE
274 Fix minor problem found by static checking.
275 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
276 initialized, to pacify gcc -Wuninitialized.
277
e5e9d610
PE
278 * fileio.c: Report proper errno when syscall falls.
279 (Finsert_file_contents): Save and restore errno,
280 so that report_file_error outputs the correct diagnostic.
281 (Fwrite_region) [CLASH_DETECTION]: Likewise.
282
a1674f0b
EZ
2832011-09-18 Eli Zaretskii <eliz@gnu.org>
284
285 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
286
fbfb6dd4
EZ
2872011-09-17 Eli Zaretskii <eliz@gnu.org>
288
289 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
290 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
291
bb187662
EZ
2922011-09-17 Eli Zaretskii <eliz@gnu.org>
293
1137e8b8
EZ
294 * xdisp.c (reseat_at_next_visible_line_start): Keep information
295 about the current paragraph and restore it after the call to
296 reseat.
297
298 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
299 (bidi_find_paragraph_start): Search back for paragraph beginning
300 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
301 (bidi_move_to_visually_next): Only trigger paragraph-related
302 computations when the last character is a newline or at EOB, not
303 just any NEUTRAL_B. (Bug#9470)
304
bb187662
EZ
305 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
306 truncated lines if point is covered by a display string. (Bug#9524)
307
2e621251
PE
3082011-09-16 Paul Eggert <eggert@cs.ucla.edu>
309
310 * xselect.c: Relax test for outgoing X longs (Bug#9498).
311 (cons_to_x_long): New function.
312 (lisp_data_to_selection_data): Use it. Correct the test for
313 short-versus-long data; it was negated. Break out of vector
314 loop, for efficiency, when a long datum is discovered.
315
91a15bc6
SM
3162011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
317
318 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
319
b41c3a35
EZ
3202011-09-16 Eli Zaretskii <eliz@gnu.org>
321
322 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
323 GCC PR/17406) by declaring this function with external scope.
324
7812ba2d
PE
3252011-09-15 Paul Eggert <eggert@cs.ucla.edu>
326
327 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
328 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
329
cf7edc2a
AS
3302011-09-15 Andreas Schwab <schwab@linux-m68k.org>
331
332 * editfns.c (Fformat): Correctly handle text properties on "%%".
333
bd01620e
EZ
3342011-09-15 Eli Zaretskii <eliz@gnu.org>
335
336 * xterm.c (x_draw_composite_glyph_string_foreground):
337 * w32term.c (x_draw_composite_glyph_string_foreground):
338 * term.c (encode_terminal_code):
339 * composite.c (composition_update_it, get_composition_id):
340 * xdisp.c (get_next_display_element)
341 (fill_composite_glyph_string): Add comments about special meaning
342 of TAB characters in a composition.
343
a02719a3
PE
3442011-09-15 Paul Eggert <eggert@cs.ucla.edu>
345
346 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
347 This occurs when processing a multibyte format.
348 Problem reported by Wolfgang Jenker.
a02719a3 349
72589a3c
JB
3502011-09-15 Johan Bockgård <bojohan@gnu.org>
351
352 * xdisp.c (try_cursor_movement): Only check for exact match if
353 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
354
1c14176c
PE
3552011-09-14 Paul Eggert <eggert@cs.ucla.edu>
356
357 Remove unused external symbols.
358 * dispextern.h (calc_pixel_width_or_height): Remove decl.
359 * xdisp.c (calc_pixel_width_or_height): Now static.
360 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
361 * indent.c (check_display_width):
362 * w32term.c: Fix comment to match code.
363 * xterm.c, xterm.h (x_catching_errors): Remove.
364
d2eea5b5
PE
3652011-09-14 Paul Eggert <eggert@cs.ucla.edu>
366
367 * xselect.c: Use signed conversions more consistently (Bug#9498).
368 (selection_data_to_lisp_data): Assume incoming selection data are
369 signed integers, not unsigned. This is to be consistent with
370 outgoing selection data, which was modified to use signed integers
371 in as part of the fix to Bug#9196 in response to Jan D.'s comment
372 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
373 expects long, not unsigned long.
374
46888499
EZ
3752011-09-14 Eli Zaretskii <eliz@gnu.org>
376
377 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
378 computation of loop end. Reported by Johan Bockgård
379 <bojohan@gnu.org>.
380
ef8ef9fb
CY
3812011-09-13 Chong Yidong <cyd@stupidchicken.com>
382
383 * frame.c (Fother_visible_frames_p): Function deleted.
384
fa819fed
EZ
3852011-09-12 Eli Zaretskii <eliz@gnu.org>
386
387 * indent.c (compute_motion): Process display vector front to back
388 rather than the other way around. (Bug#2496)
389
2ba8e008
SM
3902011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
391
392 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
393
20f53c69
CY
3942011-09-11 Chong Yidong <cyd@stupidchicken.com>
395
396 * minibuf.c (Fread_from_minibuffer): Doc fix.
397
d562d7a4
EZ
3982011-09-11 Eli Zaretskii <eliz@gnu.org>
399
400 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
401 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
402
1c4d7f3d
LMI
4032011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
404
405 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
406 value for non-existent files.
407
b885bf36
EZ
4082011-09-11 Eli Zaretskii <eliz@gnu.org>
409
410 * fileio.c (Finsert_file_contents): If the file cannot be opened,
411 set its "size" to -1. This will set the modtime_size field of
412 the corresponding buffer to -1, which is what
413 verify-visited-file-modtime expects for files that do not exist.
414 (Bug#9139)
415
6612f0bf
PE
4162011-09-11 Paul Eggert <eggert@cs.ucla.edu>
417
418 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
419 here ...
420 * lisp.h: ... from here. push_key_description is no longer
421 defined in keyboard.c, so its declaration should not be in
422 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
423 logically belongs with push_key_description.
424
dfb3f755
PE
4252011-09-10 Paul Eggert <eggert@cs.ucla.edu>
426
427 * buffer.h: Include <sys/types.h> instead of <time.h>.
428 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
429 Problem reported by Herbert J. Skuhra.
430
3134906c
LMI
4312011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
432
433 * xml.c (parse_region): Make the parsing work for
434 non-comment-starting XML files again (bug#9144).
435
8d903f4e
AS
4362011-09-10 Andreas Schwab <schwab@linux-m68k.org>
437
438 * image.c (gif_load): Fix calculation of bottom and right corner.
439 (Bug#9468)
440
80ad64f4
EZ
4412011-09-10 Eli Zaretskii <eliz@gnu.org>
442
443 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
444 redisplay in small windows.
445
208a048d
EZ
4462011-09-09 Eli Zaretskii <eliz@gnu.org>
447
448 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
449
9b1c252e
MR
4502011-09-08 Martin Rudalics <rudalics@gmx.at>
451
452 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
453 Operate on live windows only.
454
2949f33b
JB
4552011-09-08 Juanma Barranquero <lekktu@gmail.com>
456
457 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
458
e08dcafd
EZ
4592011-09-07 Eli Zaretskii <eliz@gnu.org>
460
461 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
462 only under bidi iteration.
463
115b96bd
JD
4642011-09-07 Jan Djärv <jan.h.d@swipnet.se>
465
466 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
467
c8199d0f
PE
4682011-09-06 Paul Eggert <eggert@cs.ucla.edu>
469
470 isnan: Fix porting problem to Solaris 10 with bundled gcc.
471 Without this fix, the command to link temacs failed due to an
472 undefined symbol __builtin_isnan. This is because
473 /usr/include/iso/math_c99.h #defines isnan(x) to
474 __builtin_isnan(x), but the bundled gcc, which identifies itself
475 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
476 a __builtin_isnan.
477 * floatfns.c (isnan): #undef, and then #define to a clone of
478 what's in data.c.
479 (Fisnan): Always define, since it's always available now.
480 (syms_of_floatfns): Always define isnan at the Lisp level.
481
e39b275c 4822011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
483
484 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
485
b2db44d9 4862011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 487
f4af5137 488 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
489 The previous code assumed that file offsets (off_t values) fit in
490 EMACS_INT variables, which is not true on typical 32-bit hosts.
491 The code messed up by falsely reporting buffer overflow in cases
492 such as (insert-file-contents "big" nil 1 2) into an empty buffer
493 when "big" contains more than 2**29 bytes, even though this
494 inserts just one byte and does not overflow the buffer.
495 (Finsert_file_contents): Store file offsets as off_t
496 values, not as EMACS_INT values. Check for overflow when
497 converting between EMACS_INT and off_t. When checking for
498 buffer overflow or for overlap, take the offsets into account.
499 Don't use EMACS_INT for small values where int suffices.
500 When checking for overlap, fix a typo: ZV was used where
501 ZV_BYTE was intended.
502 (Fwrite_region): Don't assume off_t fits into 'long'.
503 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
504
ecfc0a49
MA
5052011-09-05 Michael Albinus <michael.albinus@gmx.de>
506
507 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
508
6511acf2 5092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 510
0999621a 511 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
512
513 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 514 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
515 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
516 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
517 (modify_event_symbol): Do not assume that the length of
518 name_alist_or_stem is safe to alloca and fits in int.
519 (Fexecute_extended_command): Likewise for function name and binding.
520 (Frecursion_depth): Wrap around reliably on integer overflow.
521 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
522 since some callers pass EMACS_INT values.
523 (Fsingle_key_description): Don't crash if symbol name contains more
524 than MAX_ALLOCA bytes.
525 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
526 (get_minibuffer): Arg is now EMACS_INT, not int.
527 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 528 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
529 * window.h (command_loop_level, minibuf_level): Reflect API changes.
530
2be7d702
PE
531 * dbusbind.c (signature_cat): New function.
532 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
533 Do not overrun buffer; instead, report string overflow.
534
9d1df220
PE
535 * dispnew.c (add_window_display_history): Don't overrun buffer.
536 Truncate instead; this is OK since it's just a log.
537
33ef5c64
PE
538 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
539 even if the time zone offset is outlandishly large.
540 Don't mishandle offset == INT_MIN.
541
66c6fdd5
PE
542 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
543 when creating daemon; the previous buffer-overflow check was incorrect.
544
d749b01b
PE
545 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
546 which has the guts of the old verror function.
547
b5cd1905
PE
548 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
549 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
550
6e1a67fb
PE
551 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
552 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 553 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 554 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
555 length of string rather than counting it via multiple sprintfs;
556 that's simpler and more reliable.
c21721cc
PE
557 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
558 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
559 sprintf, in case result does not fit in int.
560
c57b67fc
PE
561 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
562 (fontset_from_font): Print it.
563
8a401434
PE
564 * frame.c (tty_frame_count): Now printmax_t, not int.
565 (make_terminal_frame, set_term_frame_name): Print it.
566 (x_report_frame_params): In X, window IDs are unsigned long,
567 not signed long, so print them as unsigned.
568 (validate_x_resource_name): Check for implausibly long names,
569 and don't assume name length fits in 'int'.
570 (x_get_resource_string): Don't blindly alloca invocation name;
571 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
572 not fit in int.
573
6e1a67fb
PE
574 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
575 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
576 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
577
0df02bf3
PE
578 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
579 Use esprintf, not sprintf, in case result does not fit in int.
580
48e30793
PE
581 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
582 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
583 it as a large positive number.
584 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
585 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
586
a66ff6d8
PE
587 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
588 in case result does not fit in int.
589
aca216ff
PE
590 * print.c (float_to_string): Detect width overflow more reliably.
591 (print_object): Make sprintf buffer a bit bigger, to avoid potential
592 buffer overrun. Don't assume list length fits in 'int'. Treat
593 print length of 0 as 0, not as infinity; to be consistent with other
594 uses of print length in this function. Don't overflow print length
595 index. Don't assume hash table size fits in 'long', or that
596 vectorlike size fits in 'unsigned long'.
597
31c286f7
PE
598 * process.c (make_process): Use printmax_t, not int, to format
599 process-name gensyms.
600
55e5faa1
PE
601 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
602
80f2e268
PE
603 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
604 to avoid potential buffer overrun.
605
670741ab
PE
606 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
607 if X resource line is longer than 512 bytes.
608
b7163a50
PE
609 * xfns.c (x_window): Make sprintf buffer a bit bigger
610 to avoid potential buffer overrun.
611
ae58ff1f
PE
612 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
613
c43c8a6a
PE
614 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
615
3f8236f4
PE
6162011-09-04 Paul Eggert <eggert@cs.ucla.edu>
617
53e9fe90 618 Integer overflow fixes for scrolling, etc.
6511acf2
PE
619 Without these, Emacs silently mishandles large integers sometimes.
620 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
621 it were "C-u 1 M-x recenter" on a typical 64-bit host.
622
6511acf2
PE
623 * xdisp.c (try_window_id): Check Emacs fixnum range before
624 converting to 'int'.
806add1d 625
6511acf2 626 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
627 Check that an Emacs fixnum is in range before assigning it to 'int'.
628 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
629 values converted from Emacs fixnums.
630 (Frecenter): Don't wrap around a line count if it is out of 'int'
631 range; instead, treat it as an extreme value.
632 (Fset_window_configuration, compare_window_configurations):
633 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
634
6511acf2
PE
635 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
636 that can exceed INT_MAX. Check that EMACS_INT value is in range
637 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
638 (match_limit): Don't assume that a fixnum can fit in 'int'.
639
6511acf2 640 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
641 exceed INT_MAX.
642
6511acf2 643 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
644 (Fvertical_motion): Don't wrap around LINES values that don't fit
645 in 'int'. Instead, treat them as extreme values. This is good
646 enough for windows, which can't have more than INT_MAX lines anyway.
647
fcb901a7
LMI
6482011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
649
0f2f6b6d
LMI
650 * Require libxml/parser.h to avoid compilation warning.
651
fcb901a7
LMI
652 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
653
654 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
655 since this reportedly can destroy thread storage.
656
6e20a0d4
CY
6572011-08-30 Chong Yidong <cyd@stupidchicken.com>
658
659 * syntax.c (find_defun_start): Update all cache variables if
660 exiting early (Bug#9401).
661
148ae00e
EZ
6622011-08-30 Eli Zaretskii <eliz@gnu.org>
663
f6cfbd8f
EZ
664 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
665
148ae00e
EZ
666 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
667 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
668 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
669
670 * term.c (tty_append_glyph): New function.
671 (produce_stretch_glyph): Static function and its prototype deleted.
672
a66cfb1c
SM
673 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
674 Add prototypes.
148ae00e 675
c4a07a4c
PE
6762011-08-29 Paul Eggert <eggert@cs.ucla.edu>
677
678 * image.c (parse_image_spec): Check for nonnegative, not for positive,
679 when checking :margin (Bug#9390).
680 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 681 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
682 so that the name doesn't mislead. All uses changed.
683
6bc8cd65
JB
6842011-08-28 Johan Bockgård <bojohan@gnu.org>
685
686 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
687 set_tty_hooks.
688
dca4927e
EZ
6892011-08-27 Eli Zaretskii <eliz@gnu.org>
690
691 * xdisp.c (move_it_to): Don't bail out early when reaching
692 position beyond to_charpos, if we are scanning backwards.
693 (move_it_vertically_backward): When DY == 0, make sure we get to
694 the first character in the line after the newline.
695
f2cad773
PE
6962011-08-27 Paul Eggert <eggert@cs.ucla.edu>
697
698 * ccl.c: Improve and simplify overflow checking (Bug#9196).
699 (ccl_driver): Do not generate an out-of-range pointer.
700 (Fccl_execute_on_string): Remove unnecessary check for
701 integer overflow, noted by Stefan Monnier in
702 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
703 Remove a FIXME that didn't need fixing.
704 Simplify the newly-introduced buffer reallocation code.
705
0cae2cdb
JB
7062011-08-27 Juanma Barranquero <lekktu@gmail.com>
707
708 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
709
5fc295a4 7102011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 711
70c60eb2 712 Integer and memory overflow issues (Bug#9196).
726e0ab1 713
d31850da
PE
714 * doc.c (get_doc_string): Rework so that
715 get_doc_string_buffer_size is the actual buffer size, rather than
716 being 1 less than the actual buffer size; this makes xpalloc more
717 convenient.
718
a69fbedb
PE
719 * image.c (x_allocate_bitmap_record, cache_image):
720 * xselect.c (Fx_register_dnd_atom):
721 Simplify previous changes by using xpalloc.
722
fe5c5d37
PE
723 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
724 since either will do and ptrdiff_t is convenient with xpalloc.
725
0065d054
PE
726 * charset.c (charset_table_size)
727 (struct charset_sort_data.priority): Now ptrdiff_t.
728 (charset_compare): Don't overflow if priorities differ greatly.
729 (Fsort_charsets): Don't assume list length fits in int.
730 Check for size-calculation overflow when allocating sort data.
731 (syms_of_charset): Allocate an initial charset table that is
732 just under 64 KiB, to avoid problems with glibc malloc and mmap.
733
734 * cmds.c (internal_self_insert): Check for size-calculation overflow.
735
736 * composite.h (struct composition.glyph_len): Now int, not unsigned.
737 The actual value is always <= INT_MAX, and leaving it unsigned made
738 overflow checking harder.
739
740 * dispextern.h (struct glyph_matrix.rows_allocated)
741 (struct face_cache.size): Now ptrdiff_t, for convenience in use
742 with xpalloc. The values are still always <= INT_MAX.
743
744 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
745
746 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
747 (SAFE_NALLOCA): New macro.
748
749 * region-cache.c (struct boundary.pos, find_cache_boundary)
750 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
751 (set_cache_region, invalidate_region_cache)
752 (revalidate_region_cache, know_region_cache, region_cache_forward)
753 (region_cache_backward, pp_cache):
754 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
755 so that ptrdiff_t * can be passed to xpalloc.
756 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
757 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
758 (pp_cache): Don't assume cache_len fits in int.
759 * region-cache.h: Adjust extern decls to match.
760
761 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
762 EMACS_INT, since either will do, for xpalloc.
763
764 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
765 (xnmalloc, xnrealloc, xpalloc): New functions.
766
726e0ab1
PE
767 * bidi.c (bidi_shelve_header_size): New constant.
768 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
769 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
770
51f30bc5 771 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
772 * buffer.c (overlays_at, overlays_in, record_overlay_string)
773 (overlay_strings):
774 Don't update size of array until after memory allocation succeeds,
775 because xmalloc/xrealloc may not return.
0065d054
PE
776 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
777 now that we have proper integer overflow checking.
778 (record_overlay_string, overlay_strings): Catch overflows when
779 calculating size of overlay_str_buf.
726e0ab1 780
0065d054
PE
781 * callproc.c (Fcall_process): Check for size overflow when
782 calculating size of args2.
783 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
784 Normally we prefer signed values, but sticking with ptrdiff_t would
785 require adding more-complicated checks.
726e0ab1
PE
786
787 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
788 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
789 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 790 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
791
792 * character.c (Fstring): Check for size-calculation overflow.
793
794 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
795 unnecessary integer overflow. Check for size overflow.
796 (encode_coding_object): Don't update size until xmalloc succeeds.
797
798 * composite.c (get_composition_id): Check for overflow in glyph
799 length calculations.
800
801 Integer and memory overflow fixes for display code.
802 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
803 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
804 (scrolling_window): Check for overflow in size calculations.
805 (line_draw_cost, realloc_glyph_pool, add_row_entry):
806 Don't assume glyph table len fits in int.
807 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
808 (row_table_size): Now ptrdiff_t, not int.
809 (scrolling_window): Avoid overflow in size calculations.
810 Don't update size until allocation succeeds.
811 * fns.c (concat): Check for overflow in size calculations.
812 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
813 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
814 (NEXT_ALMOST_PRIME_LIMIT): New constant.
815
816 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
817 (get_doc_string): Check for size calculation overflow.
818 Don't update size until allocation succeeds.
819 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
820 EMACS_INT, where ptrdiff_t will do.
821 (Fsubstitute_command_keys): Check for string overflow.
822
823 * editfns.c (set_time_zone_rule): Don't assume environment length
824 fits in int.
825 (message_length): Now ptrdiff_t, not int.
826 (Fmessage_box): Don't update size until allocation succeeds.
827 Don't assume message length fits in int.
828 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
829
0065d054
PE
830 * emacs.c (main): Do not reallocate argv, since there is a null at
831 the end that can be overwritten, and this way there's no need to
832 worry about size-calculation overflow.
833 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
834
835 * eval.c (init_eval_once, grow_specpdl): Don't update size until
836 alloc succeeds.
837 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
838
839 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
840 (x_set_scroll_bar_width, x_figure_window_size):
841 Check for integer overflow.
842 (x_set_alpha): Do not assume XINT fits in int.
843
844 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
845 This is for the members text_lines, text_cols, total_lines, total_cols,
846 where the system imposes an 'int' limit.
847
848 * fringe.c (Fdefine_fringe_bitmap):
849 Don't update size until alloc works.
850
851 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
852 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
853
854 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
855 Check for size-calculation overflow.
856 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
857 do, as we prefer signed integers.
858 (id_to_widget.max_size, id_to_widget.used)
859 (xg_store_widget_in_map, xg_remove_widget_from_map)
860 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
861 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
862 Use and return ptrdiff_t, not int.
863 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
864 * gtkutil.h: Change prototypes to match the above.
865
866 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
867 are duplicate now that they've been promoted to lisp.h.
868 (x_allocate_bitmap_record, x_alloc_image_color)
869 (make_image_cache, cache_image, xpm_load):
870 Don't update size until alloc is done.
871 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
872 (x_detect_edges):
3256efce 873 Check for size calculation overflow.
726e0ab1
PE
874 (ct_colors_allocated_max): New constant.
875 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
876 overflow.
3256efce 877
726e0ab1
PE
878 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
879 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
880 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
881 Use ptrdiff_t, not int, to count maps.
882 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
883 calculations. Don't update size until allocation succeeds.
884 Redo calculations to avoid overflow.
726e0ab1
PE
885 * keyboard.h: Change prototypes to match the above.
886
887 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
888 to count maps.
889 (current_minor_maps): Check for size calculation overflow.
890 * keymap.h: Change prototypes to match the above.
891
892 * lread.c (read1, init_obarray): Don't update size until alloc done.
893
894 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
895 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
896
726e0ab1
PE
897 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
898 Now ptrdiff_t, not int.
899 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
900 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
901
902 * process.c (Fnetwork_interface_list): Check for overflow
903 in size calculation.
904
905 * region-cache.c (move_cache_gap): Check for size calculation overflow.
906
907 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
908 overflow. Don't bother calling xmalloc when xrealloc will do.
909
910 * search.c (Freplace_match): Check for size calculation overflow.
911 (Fset_match_data): Don't assume list lengths fit in 'int'.
912
913 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
914 for command line length. Do not attempt to address one before the
915 beginning of an array, as that's not portable.
916
917 * term.c (max_frame_lines): Remove; unused.
918 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
919 not int.
920 (encode_terminal_code, calculate_costs): Check for size
921 calculation overflow.
922 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
923 table lengths and related sizes. Don't update size until alloc
924 done. Redo calculations to avoid overflow.
925 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
926
927 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
928 subtracting pointers.
929 (gobble_line): Check for overflow more carefully. Don't update size
930 until alloc done.
931
932 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
933 Don't update size until alloc done.
934 Redo size calculations to avoid overflow.
935 Check for size calculation overflow.
0065d054 936 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
937
938 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
939 Use ptrdiff_t, not int, for sizes.
940 (store_mode_line_noprop_char): Don't update size until alloc done.
941
0065d054
PE
942 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
943 Use ptrdiff_t, not int, for sizes.
944 (Finternal_make_lisp_face, cache_face):
945 Check for size calculation overflow.
946 (cache_face): Treat size calculation overflows as if they were
947 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
948
949 * xfns.c (x_encode_text, x_set_name_internal)
950 (Fx_change_window_property): Use ptrdiff_t, not int, to count
951 sizes, since they can exceed INT_MAX in size. Check for size
952 calculation overflow.
953
0065d054
PE
954 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
955 (xg_select): Check for size calculation overflow.
726e0ab1
PE
956 Don't update size until alloc done.
957
0065d054 958 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 959 as sprintf is limited to int lengths.
1d526e2f 960
252c5ee1
PE
961 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
962 (X_LONG_MIN): New macros.
864d7ce7
PE
963 Use them to make the following changes clearer.
964 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
965 This change doesn't affect the value now, but it may help remind
966 future maintainers not to raise the value too much later.
967 (SELECTION_QUANTUM): Remove, replacing with ...
968 (selection_quantum): ... new function, which avoids overflow.
969 All uses changed.
970 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
971 assumption that selection length fits in 'int'.
972 (x_reply_selection_request, x_handle_selection_request)
973 (x_get_window_property, receive_incremental_selection)
974 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
975 (lisp_data_to_selection_data, clean_local_selection_data):
976 Use ptrdiff_t, not int, to record length of selection.
977 (x_reply_selection_request, x_get_window_property)
978 (receive_incremental_selection, x_property_data_to_lisp):
979 Redo calculations to avoid overflow.
980 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 981 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
982 something.
983 (x_get_window_property, receive_incremental_selection)
984 (lisp_data_to_selection_data, x_property_data_to_lisp):
985 Check for size-calculation overflow.
986 (x_get_window_property, receive_incremental_selection)
987 (lisp_data_to_selection_data, Fx_register_dnd_atom):
988 Don't store size until memory allocation succeeds.
989 (x_get_window_property): Plug memory leak on memory exhaustion.
990 Don't double-block input; malloc is safe here. Don't assume 2**34
991 - 4 fits in unsigned long. Add an xassert to check
992 XGetWindowProperty overflow. Be more careful about overflow
993 calculations, and distinguish size from memory overflow better.
994 (receive_incremental_selection): When tracing, don't assume
995 unsigned int is less than INT_MAX.
996 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
997 harmful) conversions of unsigned short to int.
998 (lisp_data_to_selection_data): Don't assume that integers
999 in the range -65535 through -1 fit in an X unsigned short.
1000 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1001 result parameters unless successful. Rely on cons_to_unsigned
1002 to report problems with elements; the old code wasn't right anyway.
1003 (x_check_property_data): Check for int overflow; we cannot use
1004 a wider type due to X limits.
1005 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1006
726e0ab1 1007 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1008
0065d054
PE
1009 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1010 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1011 (x_color_cells): Don't store size until memory allocation succeeds.
1012 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1013 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1014 (x_term_init): Don't assume length fits in int (sprintf is limited
1015 to int size).
bc18e09d 1016
ebfa62c0
PE
1017 Use ptrdiff_t for composition IDs.
1018 * character.c (lisp_string_width):
1019 * composite.c (composition_table_size, n_compositions)
1020 (get_composition_id, composition_gstring_from_id):
1021 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1022 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1023 * window.c (Frecenter):
1024 Use ptrdiff_t, not int, for composition IDs.
1025 * composite.c (get_composition_id): Check for integer overflow.
1026 * composite.h: Adjust prototypes to match the above changes.
1027
d3411f89
PE
1028 Use ptrdiff_t for hash table indexes.
1029 * category.c (hash_get_category_set):
1030 * ccl.c (ccl_driver):
1031 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1032 * coding.c (coding_system_charset_list, detect_coding_system):
1033 * coding.h (struct coding_system.id):
1034 * composite.c (get_composition_id, gstring_lookup_cache):
1035 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1036 * image.c (xpm_get_color_table_h):
1037 * lisp.h (hash_lookup, hash_put):
1038 * minibuf.c (Ftest_completion):
1039 Use ptrdiff_t for hash table indexes, not int (which is too
1040 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1041 32-bit --with-wide-int hosts).
1042
e097a6fa
PE
1043 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1044 Add a FIXME comment about memory leaks.
1045 (syms_of_charset): Don't assume xmalloc returns.
1046
5637687f
PE
1047 Don't assume that stated character widths fit in int.
1048 * character.c (Fchar_width, c_string_width, lisp_string_width):
1049 * character.h (CHAR_WIDTH):
1050 * indent.c (MULTIBYTE_BYTES_WIDTH):
1051 Use sanitize_char_width to avoid undefined and/or bad behavior
1052 with outlandish widths.
a66cfb1c 1053 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1054 now that we have two such functions. All uses changed.
1055 (sanitize_char_width): New inline function.
1056
a2271ba2
PE
1057 Don't assume that tab-width fits in int.
1058 * character.h (sanitize_width): New inline function.
1059 (SANE_TAB_WIDTH): New macro.
1060 (ASCII_CHAR_WIDTH): Use it.
1061 * indent.c (sane_tab_width): Remove. All uses replaced by
1062 SANE_TAB_WIDTH (current_buffer).
1063 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1064
18c52557
PE
1065 * fileio.c: Integer overflow issues with file modes.
1066 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1067
caeeedc1
PE
1068 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1069 Remove unreachable code.
1070 (read_hex, load_charset_map_from_file): Check for integer overflow.
1071
50849c52
PE
1072 * xterm.c: don't go over XClientMessageEvent limit
1073 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1074 (x_send_scroll_bar_event): Likewise. Check that the size does not
1075 exceed limits imposed by XClientMessageEvent, as well as the usual
1076 ptrdiff_t and size_t limits.
1077
b13995db
PE
1078 * keyboard.c: Overflow, signedness and related fixes.
1079 (make_lispy_movement): Use same integer type in forward decl
1080 that is used in the definition.
1081 (read_key_sequence, keyremap_step):
1082 Change bufsize argument back to int, undoing my 2011-03-30 change.
1083 We prefer signed types, and int is wide enough here.
1084 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1085 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1086 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1087 length, not size_t. Use ptrdiff_t for index, not int.
1088 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1089 possibility of integer overflow.
1090
13464394
PE
1091 Overflow, signedness and related fixes for images.
1092
1093 * dispextern.h (struct it.stack[0].u.image.image_id)
1094 (struct_it.image_id, struct image.id, struct image_cache.size)
1095 (struct image_cache.used, struct image_cache.ref_count):
1096 * gtkutil.c (update_frame_tool_bar):
1097 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1098 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1099 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1100 * nsmenu.m (update_frame_tool_bar):
1101 * xdisp.c (calc_pixel_width_or_height):
1102 * xfns.c (image_cache_refcount):
1103 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1104 on typical 64-bit hosts.
1105
1106 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1107 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1108 Omit unnecessary casts to int.
1109 (parse_image_spec): Check that integers fall into 'int' range
1110 when the callers expect that.
1111 (image_ascent): Redo ascent calculation to avoid int overflow.
1112 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1113 (lookup_image): Remove unnecessary tests.
1114 (xbm_image_p): Locals are now of int, not EMACS_INT,
1115 since parse_image_check makes sure they fit into int.
1116 (png_load, gif_load, svg_load_image):
1117 Prefer int to unsigned where either will do.
1118 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1119 old tiff_error_handler and tiff_warning_handler.
1120 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1121 stack buffer overflows. It uses only the features of vsnprintf
1122 that are common to both POSIX and native Microsoft.
1123 (tiff_error_handler, tiff_warning_handler): Use it.
1124 (tiff_load, gif_load, imagemagick_load_image):
1125 Don't assume :index value fits in 'int'.
1126 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1127 (imagemagick_load_image): Check that crop parameters fit into
1128 the integer types that MagickCropImage accepts. Don't assume
1129 Vimagemagick_render_type has a nonnegative value. Don't assume
1130 size_t fits in 'long'.
1131 (gs_load): Use printmax_t to print the widest integers possible.
1132 Check for integer overflow when computing image height and width.
1133
c11821d4
EZ
11342011-08-26 Eli Zaretskii <eliz@gnu.org>
1135
1136 * xdisp.c (redisplay_window): Don't force window start if point
1137 will be invisible in the resulting window. (Bug#9324)
1138
0c95fcf7
EZ
11392011-08-25 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1142 the display spec is of the form `(space ...)'.
1143 (handle_display_spec): Return the value returned by
1144 handle_single_display_spec, not just 1 or zero.
1145 (handle_single_display_spec): If the display spec is of the form
1146 `(space ...)', and specifies display in the text area, return 2
1147 rather than 1.
fee65a97 1148 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1149 accurately, and prefer exact match for point under bidi.
1150 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1151
1152 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1153 into disp_prop; all users changed.
1154
1155 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1156 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1157 for the text covered by the display property.
1158
e4ed06f1
CY
11592011-08-25 Chong Yidong <cyd@stupidchicken.com>
1160
1161 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1162 Change return value to nil.
1163 (Frecord_buffer): Delete unused function.
1164
f67cdd7f
EZ
11652011-08-24 Eli Zaretskii <eliz@gnu.org>
1166
5980d4c6
EZ
1167 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1168 buffers, return left-to-right.
8610fe8b
EZ
1169 (set_cursor_from_row): Consider candidate row a win if its glyph
1170 represents a newline and point is on that newline. Fixes cursor
1171 positioning on the newline at EOL of R2L text within L2R
1172 paragraph, and vice versa.
1173 (try_cursor_movement): Check continued rows, in addition to
1174 continuation rows. Fixes unwarranted scroll when point enters a
1175 continued line of R2L text within an L2R paragraph, or vice versa.
1176 (cursor_row_p): Consider the case of point being equal to
1177 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1178 from the end of a short line to the beginning of a continued line
1179 of R2L text within L2R paragraph.
1180 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1181 composed characters.
5980d4c6 1182
f67cdd7f
EZ
1183 * bidi.c (bidi_check_type): Use xassert.
1184 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1185 members.
1186
bca633fb
EZ
11872011-08-23 Eli Zaretskii <eliz@gnu.org>
1188
1189 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1190 a character.
1191
4a5885a7
CY
11922011-08-23 Chong Yidong <cyd@stupidchicken.com>
1193
1194 * nsfont.m (ns_otf_to_script): Fix typo.
1195
0902a04e
KH
11962011-08-22 Kenichi Handa <handa@m17n.org>
1197
1198 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1199 extra slot even if the purpose is char-code-property-table.
1200
1a2e6670
EZ
12012011-08-23 Eli Zaretskii <eliz@gnu.org>
1202
8ddde651
EZ
1203 * xdisp.c (redisplay_window): When computing centering_position,
1204 account for the height of the header line. (Bug#8874)
1205
425cc014
EZ
1206 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1207 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1208 candidate is selected by the mouse, and that candidate has a
1209 composed character under the mouse.
1210
1a2e6670
EZ
1211 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1212 coordinates reported by pos-visible-in-window-p for a composed
1213 character in column zero.
1214
8b76d6f8
SM
12152011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1216
1217 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1218
dac347dd
EZ
12192011-08-22 Eli Zaretskii <eliz@gnu.org>
1220
1221 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1222 consider it a hit if to_charpos is anywhere in the range of the
1223 composed buffer positions.
1224
e013fb34
CY
12252011-08-22 Chong Yidong <cyd@stupidchicken.com>
1226
1227 * image.c (gif_load): Don't assume that each subimage has the same
1228 dimensions as the base image. Handle disposal method that is
1229 "undefined" by the gif spec (Bug#9335).
1230
bd1ba3e8
CY
12312011-08-20 Chong Yidong <cyd@stupidchicken.com>
1232
1233 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1234 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1235
54a1215b
EZ
12362011-08-19 Eli Zaretskii <eliz@gnu.org>
1237
823564e5
EZ
1238 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1239 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1240 from an Org mode buffer to a Speedbar frame.
1241
54a1215b
EZ
1242 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1243 a composition, take its buffer position from IT->cmp_it.charpos.
1244 Fixes cursor positioning at the beginning of a line that begins
1245 with a composed character.
1246
9778ebcc
EZ
12472011-08-18 Eli Zaretskii <eliz@gnu.org>
1248
0be6ee06
EZ
1249 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1250 character bidirectional type, use STRONG_L instead. Fixes crashes
1251 in a buffer produced by `describe-categories'.
1252
9778ebcc
EZ
1253 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1254 members before the level stack, so they would be saved and
1255 restored when copying iterator state. Fixes incorrect reordering
1256 around TABs covered by display properties.
1257
156bffbe
AS
12582011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1259
1260 * process.c (Fnetwork_interface_list): Correctly determine buffer
1261 size.
1262
72ad093b
CY
12632011-08-17 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1266 (internal_condition_case_2, internal_condition_case_n):
1267 Remove unnecessary aborts (Bug#9081).
72ad093b 1268
35774242
EZ
12692011-08-17 Eli Zaretskii <eliz@gnu.org>
1270
1271 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1272 has no `load' handler, try opening the file locally. (Bug#9311)
1273
db76dd85
KB
12742011-08-16 Ken Brown <kbrown@cornell.edu>
1275
1276 * gmalloc.c: Expand comment.
1277
b215eee5
EZ
12782011-08-16 Eli Zaretskii <eliz@gnu.org>
1279
1280 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1281 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1282
a4579d33
KB
12832011-08-16 Ken Brown <kbrown@cornell.edu>
1284
1285 Fix memory allocation problems in Cygwin build (Bug#9273).
1286
1287 * unexcw.c ( __malloc_initialized): Declare external variable.
1288 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1289
8b76d6f8
SM
1290 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1291 New variables.
a4579d33
KB
1292 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1293 dumped emacs.
1294 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1295 in the static heap.
1296 [CYGWIN] (special_realloc): New function.
1297 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1298 requests to realloc storage in the static heap.
1299
3ebec551
PE
13002011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * bidi.c (bidi_initialize): Remove unused local.
1303
9fd8be00
EZ
13042011-08-15 Eli Zaretskii <eliz@gnu.org>
1305
474a8465
EZ
1306 * biditype.h: File removed.
1307
1308 * bidimirror.h: File removed.
1309
1310 * deps.mk (bidi.o): Remove biditype.h and
1311 bidimirror.h.
1312
1313 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1314 bidimirror.h.
1315
1316 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1317
1318 * chartab.c: Improve commentary for the uniprop_table API.
1319
32413314
EZ
1320 * bidi.c (bidi_paragraph_init): Support zero value of
1321 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1322 (bidi_initialize): Use uniprop_table instead of including
1323 biditype.h and bidimirror.h.
32413314 1324
9fd8be00
EZ
1325 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1326 coordinates of the iterator when restoring from ppos_it.
1327 (Bug#9296)
1328
5cf2b69b
KH
13292011-08-14 Kenichi Handa <handa@m17n.org>
1330
1331 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1332 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1333
daf17d00
EZ
13342011-08-14 Eli Zaretskii <eliz@gnu.org>
1335
1336 * xdisp.c (move_it_in_display_line_to): Don't invoke
1337 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1338 ppos_it. Fixes vertical cursor motion when line beginning is
1339 covered by an image. (Bug#9296)
1340
08e3161a
JD
13412011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1342
1343 * nsterm.h (ns_run_ascript): Declare.
1344 (NSAPP_DATA2_RUNASSCRIPT): Define.
1345
1346 * nsfns.m (as_script, as_result, as_status): New static variables.
1347 (ns_run_ascript): New function.
5e617bc2 1348 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1349 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1350 the event loop. Get status from as_status (Bug#7276).
1351
1352 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1353 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1354 the event loop (Bug#7276).
1355
a3720aa2
AS
13562011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1357
1358 * gnutls.c (QCgnutls_bootprop_priority)
1359 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1360 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1361 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1362 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1363 (QCgnutls_bootprop_verify_hostname_error)
1364 (QCgnutls_bootprop_callbacks_verify): Rename from
1365 Qgnutls_bootprop_..., all uses changed.
1366
1367 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1368 uses changed.
1369
0a0d27fb
PE
13702011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1371
19d5c50c
PE
1372 * xfaces.c (Qframe_set_background_mode): Now static.
1373 * dispextern.h (Qframe_set_background_mode): Remove decl.
1374
0a0d27fb
PE
1375 * process.c (Fnetwork_interface_info): Declare local only if needed.
1376
377538cb
JD
13772011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1378
1379 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1380 (Fnetwork_interface_list): Allocate in increments of bytes instead
1381 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1382 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1383 sockaddr.
1384 (struct ifflag_def): notrailers is smart on OSX.
1385 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1386 Get hardware address with getifaddrs if available.
1387
08fff70c
EZ
13882011-08-12 Eli Zaretskii <eliz@gnu.org>
1389
1390 * xdisp.c (iterate_out_of_display_property): xassert that
1391 IT->position is set to within IT->object's boundaries. Break from
1392 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1393 when IT->position is set up wrongly due to some bug.
1394 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1395 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1396 entry. Force push_it to save on the stack the current
1397 buffer/string position, to be restored by pop_it. Fix flags in
1398 the iterator structure wrt the object coming from a display
1399 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1400 properties. (Bug#9284)
1401
7be1c708 14022011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1403
7be1c708
CY
1404 * fontset.c (fontset_get_font_group): Add proper type checks.
1405 (Bug#9172)
aac0c6e3 1406
7be1c708 14072011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1408
7be1c708
CY
1409 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1410 and LC_VERSION_MIN_MACOSX.
1411 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1412 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1413
97bb72a6
EZ
14142011-08-08 Eli Zaretskii <eliz@gnu.org>
1415
1416 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1417 no-display-properties-and-no-overlays under bidi display.
1418 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1419 properties and overlays.
97bb72a6 1420
d5617611
CY
14212011-08-08 Chong Yidong <cyd@stupidchicken.com>
1422
37e11a63
CY
1423 * editfns.c (Fset_time_zone_rule): Document relationship with the
1424 setenv function.
1425
d5617611
CY
1426 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1427 the font entity extracted from the cache (Bug#8109).
1428
58872834
CY
14292011-08-07 Chong Yidong <cyd@stupidchicken.com>
1430
1431 * composite.c (autocmp_chars): Don't reset point. That is done by
1432 restore_point_unwind (Bug#5984).
1433
75bfc667
JL
14342011-08-07 Juri Linkov <juri@jurta.org>
1435
1436 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1437 to show the arg `TIME' instead of `TIMEVAL'.
1438
d1410150
EZ
14392011-08-06 Eli Zaretskii <eliz@gnu.org>
1440
1441 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1442 display property strides EOL and includes a newline, as in
1443 longlines-mode. (Bug#9254)
75b771e4
EZ
1444 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1445 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1446
1447 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1448 is non-zero, even if the data buffer is NULL. Fixes a crash in
1449 vertical-motion with longlines-mode. (Bug#9254)
1450
35928349
EZ
14512011-08-05 Eli Zaretskii <eliz@gnu.org>
1452
ec7cc85b
EZ
1453 * bidi.c <bidi_cache_total_alloc>: Now static.
1454 (bidi_initialize): Initialize bidi_cache_total_alloc.
1455
8b76d6f8 1456 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1457 cache. (Bug#9221)
1458
1459 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1460 amount allocated this far in `bidi_cache_total_alloc'.
1461 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1462 non-zero, only free the data buffer without restoring the cache
1463 contents. All callers changed.
1464
1465 * dispextern.h (bidi_unshelve_cache): Update prototype.
1466
1467 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1468 (move_it_in_display_line, move_it_to)
1469 (move_it_vertically_backward, move_it_by_lines): Replace the call
1470 to xfree to an equivalent call to bidi_unshelve_cache.
1471 (move_it_in_display_line_to): Fix logic of returning
412b6358 1472 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1473
e2e2423b
EZ
14742011-08-05 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1477 came from a string character with a `cursor' property. (Bug#9229)
1478
ae9e757a
JD
14792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1480
1481 * Makefile.in (LIB_PTHREAD): New variable.
1482 (LIBES): Add LIB_PTHREAD (Bug#9216).
1483
1484 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1485 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1486
213bd7f2
AS
14872011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1488
1489 * regex.c (re_iswctype): Remove some redundant boolean
1490 conversions.
1491
99aaf75f
JD
14922011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1493
1494 * xterm.c (x_find_topmost_parent): New function.
1495 (x_set_frame_alpha): Find topmost parent window with
1496 x_find_topmost_parent and set the property there also (bug#9181).
1497 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1498
c74e9d86
PE
14992011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1500
1501 * callproc.c (Fcall_process): Avoid vfork clobbering
1502 the local vars buffer, coding_systems, current_dir.
1503
640c8776
SM
15042011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1505
1506 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1507
f26d0e4c
PE
15082011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1509
8a10d76c
PE
1510 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1511 so that it is not optimized away.
1512
f26d0e4c
PE
1513 * xdisp.c (compute_display_string_pos): Remove unused local.
1514
55439c61
EZ
15152011-08-02 Eli Zaretskii <eliz@gnu.org>
1516
1517 Fix slow cursor motion and scrolling in large buffers with
1518 selective display, like Org Mode buffers. (Bug#9218)
1519
1520 * dispextern.h (struct bidi_it): New member disp_prop_p.
1521
1522 * xdisp.c: Remove one-slot cache of display string positions.
1523 (compute_display_string_pos): Accept an additional argument
5e617bc2 1524 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1525 for a display string or property. If found, set DISP_PROP_P
1526 non-zero.
1527
1528 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1529 DISP_PROP_P, and pass it to compute_display_string_pos.
1530 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1531 non-zero. All callers of bidi_fetch_char changed.
1532
fb33fa43
SM
15332011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1534
1535 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1536
b099e063
DM
15372010-12-03 Don March <don@ohspite.net>
1538
1539 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1540 last character M-[char] is translated to ESC [char] (bug#7541).
1541
5cc7f7af
KH
15422011-08-02 Kenichi Handa <handa@m17n.org>
1543
d0fffa3f 1544 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1545
1546 * chartab.c (uniprop_table): Make it non-static.
1547
525d5e6e
EZ
15482011-08-01 Eli Zaretskii <eliz@gnu.org>
1549
1550 * xdisp.c (forward_to_next_line_start): Accept additional argument
1551 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1552 on the newline.
1553 (reseat_at_next_visible_line_start): Use the bidi iterator state
1554 returned by forward_to_next_line_start to restore the state of
1555 it->bidi_it after backing up to previous newline. (Bug#9212)
1556
31011111
AS
15572011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1558
1559 * regex.c (re_comp): Protoize.
1560 (re_exec): Fix return type.
1561 (regexec): Fix type of `ret'. (Bug#9203)
1562
476371c4
PE
15632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1564
e5d76069
PE
1565 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1566 This is needed if max-image-size is a floating-point number.
1567
9a79b20c
AS
15682011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1569
1570 * print.c (print_object): Print empty symbol as ##.
1571
1572 * lread.c (read1): Read ## as empty symbol.
1573
d8c2fa78
AA
15742011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1575
1576 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1577 setting frame foreground color (Bug#9175).
1578 (x_set_background_color): Likewise.
1579
ffe57a7a
AA
1580 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1581 contents (Bug#9176).
1582 (EmacsTooltip -init): Remove bezels and add shadows to
1583 tooltip windows.
1584
bf3492a5
AA
1585 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1586 or scroll bar (Bug#8470).
1587
d55e9c53
AA
1588 * nsfont.m (nsfont_open): Remove assignment to voffset and
1589 unnecessary vars hshink, expand, hd, full_height, min_height.
1590 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1591
1592 * nsterm.h (nsfont_info): Remove voffset field.
1593
d8c2fa78 15942011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1595
1596 Implement strike-through and overline on NextStep (Bug#8863).
1597
1598 * nsfont.m (nsfont_open): Use underline position provided by font,
1599 instead of hard-coded value of 2.
1600 (nsfont_draw): Call ns_draw_text_decoration instead.
1601
1602 * nsterm.h: Add declaration for ns_draw_text_decoration.
1603
1604 * nsterm.m (ns_draw_text_decoration): New function for drawing
1605 underline, overline, and strike-through.
1606 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1607 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1608 accommodate underlining, etc.
4843aac3 1609
4cc60b9b
EZ
16102011-07-28 Eli Zaretskii <eliz@gnu.org>
1611
bc7ece87
EZ
1612 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1613 default.
4cc60b9b 1614
476371c4
PE
16152011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1616
66606eea
PE
1617 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1618 Without this fix, if a signal arrives just after memory fills up,
1619 'malloc' might be invoked reentrantly.
1620
476371c4
PE
1621 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1622 In other words, assume that every image size is allowed, on non-X
1623 hosts. This assumption is probably wrong, but it lets Emacs compile.
1624
f3fcc40d
AS
16252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1626
1627 * regex.c (re_iswctype): Convert return values to boolean.
1628
350c992f
EZ
16292011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1630
1631 * xdisp.c (compute_display_string_pos): Don't use cached display
1632 string position if the buffer had its restriction changed.
1633 (Bug#9184)
1634
5266b4bb
PE
16352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1636
1637 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1638
2573a837 16392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1640
41f55ccd 1641 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1642
39e378da
PE
1643 * bidi.c: Integer size and overflow fixes.
1644 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1645 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1646 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1647 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1648 (bidi_find_other_level_edge):
1649 Use ptrdiff_t instead of EMACS_INT where either will do.
1650 This works better on 32-bit hosts configured --with-wide-int.
1651 (bidi_cache_ensure_space): Check for size-calculation overflow.
1652 Use % rather than repeated addition, for better worst-case speed.
1653 Don't set bidi_cache_size until after xrealloc returns, because it
1654 might not return.
1655 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1656 (bidi_cache_ensure_space): Also check that the bidi cache size
1657 does not exceed that of the largest Lisp string or buffer. See Eli
1658 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1659
5e927815
PE
1660 * alloc.c (__malloc_size_t): Remove.
1661 All uses replaced by size_t. See Andreas Schwab's note
1662 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1663
ca4aa935
PE
1664 * image.c: Improve checking for integer overflow.
1665 (check_image_size): Assume that f is nonnull, since
1666 it is always nonnull in practice. This is one less thing to
1667 worry about when checking for integer overflow later.
1668 (x_check_image_size): New function, which checks for integer
1669 overflow issues inside X.
1670 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1671 This removes the need for a memory_full check.
1672 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1673 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1674 (xbm_read_bitmap_data): Change locals back to 'int', since
1675 their values must fit in 'int'.
1676 (xpm_load_image, png_load, tiff_load):
1677 Invoke x_create_x_image_and_pixmap earlier,
1678 to avoid much needless work if the image is too large.
1679 (tiff_load): Treat overly large images as if
1680 x_create_x_image_and_pixmap failed, not as malloc failures.
1681 (gs_load): Use x_check_image_size.
1682
5f8f9cc2
PE
1683 * gtkutil.c: Omit integer casts.
1684 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1685 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1686
5adf60bc
PE
1687 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1688
c8907a93
PE
1689 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1690 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1691 would wrongly return t on a 64-bit host.
1692
e3c25c68
PE
1693 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1694 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1695 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1696 and therefore cause GCC to emit a bogus diagnostic in some cases.
1697
3f791afe
PE
1698 * image.c: Integer signedness and overflow and related fixes.
1699 This is not an exhaustive set of fixes, but it's time to
1700 record what I've got.
1701 (lookup_pixel_color, check_image_size): Remove redundant decls.
1702 (check_image_size): Don't assume that arbitrary EMACS_INT values
1703 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1704 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1705 (tiff_load, imagemagick_load_image):
1706 Check for overflow in size calculations.
1707 (x_create_x_image_and_pixmap): Remove unnecessary test for
1708 xmalloc returning NULL; that can't happen.
1709 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1710 (xpm_color_bucket): Use better integer hashing function.
1711 (xpm_cache_color): Don't possibly over-allocate memory.
1712 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1713 (gif_memory_source):
1714 Use ptrdiff_t, not int or size_t, to record sizes.
1715 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1716 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1717 either works, as we prefer signed integers.
1718 (tiff_read_from_memory, tiff_write_from_memory):
1719 Return tsize_t, not size_t, since that's what the TIFF API wants.
1720 (tiff_read_from_memory): Don't fail simply because the read would
1721 go past EOF; instead, return a short read.
1722 (tiff_load): Omit no-longer-needed casts.
1723 (Fimagemagick_types): Don't assume size fits into 'int'.
1724
3cc5a532
PE
1725 Improve hashing quality when configured --with-wide-int.
1726 * fns.c (hash_string): New function, taken from sxhash_string.
1727 Do not discard information about ASCII character case; this
1728 discarding is no longer needed.
1729 (sxhash-string): Use it. Change sig to match it. Caller changed.
1730 * lisp.h: Declare it.
1731 * lread.c (hash_string): Remove, since we now use fns.c's version.
1732 The fns.c version returns a wider integer if --with-wide-int is
1733 specified, so this should help the quality of the hashing a bit.
1734
b312a492
PE
1735 * emacs.c: Integer overflow minor fix.
1736 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1737 Define only if GNU_LINUX.
1738 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1739
dfd153ae
PE
1740 * dispnew.c: Integer signedness and overflow fixes.
1741 Remove unnecessary forward decls, that were a maintenance hassle.
1742 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1743 All uses changed.
1744 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1745 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1746 (prepare_desired_row, line_draw_cost):
1747 Use int, not unsigned, where either works.
1748 (save_current_matrix, restore_current_matrix):
1749 Use ptrdiff_t, not size_t, where either works.
1750 (init_display): Check for overflow more accurately, and without
1751 relying on undefined behavior.
1752
a81d11a3
PE
1753 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1754 Remove, replacing with the new symbols in lisp.h. All uses changed.
1755 * fileio.c (make_temp_name):
1756 * filelock.c (lock_file_1, lock_file):
1757 * xdisp.c (message_dolog):
1758 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1759 Use pMd etc. instead.
1760 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1761 replacing the pWIDE etc. symbols removed from editfns.c.
1762
3300e6fd
PE
1763 * keyboard.h (num_input_events): Now uintmax_t.
1764 This is (very slightly) less likely to mess up due to wraparound.
1765 All uses changed.
1766
fd05c7e9
PE
1767 * buffer.c: Integer signedness fixes.
1768 (alloc_buffer_text, enlarge_buffer_text):
1769 Use ptrdiff_t rather than size_t when either will do, as we prefer
1770 signed integers.
1771
903fe15d
PE
1772 * alloc.c: Integer signedness and overflow fixes.
1773 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1774 (__malloc_size_t): Default to size_t, not to int.
1775 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1776 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1777 Prefer ptrdiff_t to size_t when either would do, as we prefer
1778 signed integers.
1779 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1780 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1781 Now const. Initialize with values that are in range even if char
1782 is signed.
1783 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1784 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1785 These functions do the right thing with sizes > 2**32.
1786 (check_depth): Now ptrdiff_t, not int.
1787 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1788 Adjust to new way of storing sizes. Check for size overflow bugs
1789 in rest of code.
1790 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1791 slightly wrong anyway, as it missed one instance of
1792 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1793 (refill_memory_reserve): Omit needless cast to size_t.
1794 (mark_object_loop_halt): Mark as externally visible.
1795
ac82cc6a
PE
1796 * xselect.c: Integer signedness and overflow fixes.
1797 (Fx_register_dnd_atom, x_handle_dnd_message):
1798 Use ptrdiff_t, not size_t, since we prefer signed.
1799 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1800 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1801 x_dnd_atoms_size and x_dnd_atoms_length.
1802
c2d1e36d
PE
1803 * doprnt.c: Prefer signed to unsigned when either works.
1804 * eval.c (verror):
1805 * doprnt.c (doprnt):
1806 * lisp.h (doprnt):
1807 * xdisp.c (vmessage):
1808 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1809 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1810 prefer signed arithmetic to avoid comparison confusion.
1811 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1812 but is a bit tricky.
1813
0e926e56
PE
1814 Assume freestanding C89 headers, string.h, stdlib.h.
1815 * data.c, doprnt.c, floatfns.c, print.c:
1816 Include float.h unconditionally.
1817 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1818 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1819 * regex.c: Likewise for stddef.h, string.h.
1820 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1821 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1822 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1823 (STDC_HEADERS): Remove obsolete defines.
1824 * sysdep.c: Include limits.h unconditionally.
1825
9cfdb3ec
PE
1826 Assume support for memcmp, memcpy, memmove, memset.
1827 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1828 * regex.c (memcmp, memcpy):
1829 Remove; we assume C89 now.
1830
1831 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1832 (__malloc_safe_bcopy): Remove; no longer needed.
1833
cf950e6b 1834 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1835 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1836 well either way, and we prefer signed to unsigned.
1837
dbf38e02
LMI
18382011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1839
1840 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1841 closes the connection while we're reading (bug#9182).
1842
d6f0886c 18432011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1844
d6f0886c
JD
1845 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1846 are specified (Bug#9168).
24e0f6b1 1847
2eb1f9e6
PE
18482011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1849
1850 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1851 Found by GCC static checking and --with-wide-int on a 32-bit host.
1852
22381272 18532011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1854
1855 * xdisp.c (compute_display_string_pos): Fix logic of caching
1856 previous display string position. Initialize cached_prev_pos to
1857 -1. Fixes slow-down at the beginning of a buffer.
1858
f25e39b4
EZ
18592011-07-24 Eli Zaretskii <eliz@gnu.org>
1860
1861 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1862 for attrs[LFACE_FONTSET_INDEX].
1863
04c4b52e
PE
18642011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * xml.c (parse_region): Remove unused local
1867 that was recently introduced.
1868
c1734fbd
EZ
18692011-07-23 Eli Zaretskii <eliz@gnu.org>
1870
be18c5a5
EZ
1871 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1872 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1873
c1734fbd
EZ
1874 * xdisp.c (move_it_in_display_line_to): Record the best matching
1875 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1876 exit if none of the characters scanned was an exact match.
1877 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1878 when exact match is impossible due to invisible text, and the
1879 lines are truncated.
1880
a258d627
JD
18812011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1882
1883 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1884 for OSX >= 10.7.
1885
b6d5a689
EZ
18862011-07-22 Eli Zaretskii <eliz@gnu.org>
1887
0f74f785
EZ
1888 Fix a significant slow-down of cursor motion with C-n, C-p,
1889 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1890 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1891 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1892 (next_element_from_buffer): Call compute_stop_pos_backwards to
1893 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1894 base_level_stop.
1895 (reseat): Don't look for prev_stop, as that could mean a very long
1896 run.
1897 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1898 <cached_disp_overlay_modiff>: Cache for last found display string
1899 position.
551918c1 1900 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1901 about the same buffer in the same area of character positions, and
1902 the buffer wasn't changed since the time the display string
1903 position was cached.
551918c1 1904
b2d0c91a
EZ
19052011-07-22 Eli Zaretskii <eliz@gnu.org>
1906
1907 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1908 is an integer, which is important for empty lines. (Bug#9149)
1909
043604ee
CY
19102011-07-22 Chong Yidong <cyd@stupidchicken.com>
1911
1912 * frame.c (Fmodify_frame_parameters): In tty case, update the
1913 default face if necessary (Bug#4238).
1914
da4adb04
CY
19152011-07-21 Chong Yidong <cyd@stupidchicken.com>
1916
1917 * editfns.c (Fstring_to_char): No need to explain what a character
1918 is in the docstring (Bug#6576).
1919
9abd0532
LMI
19202011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1921
1922 * xml.c (parse_region): Make sure we always return a tree.
1923
36881d16
HK
19242011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1925
1926 * xml.c (parse_region): If a document contains only comments,
1927 return that, too.
1928
1e98674d
LMI
19292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1930
1931 * xml.c (make_dom): Return comments, too.
1932
590bd467
PE
19332011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1934
1935 Port to OpenBSD.
1936 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1937 and the surrounding thread.
1938 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1939 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1940 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1941 timer goes off.
1942 * s/openbsd.h (BROKEN_SIGIO): Define.
1943 * unexelf.c (unexec) [__OpenBSD__]:
1944 Don't update the .mdebug section of the Alpha COFF symbol table.
1945
f41628b2
LMI
19462011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1947
1948 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1949 (bug#8460).
1950
b59b67c5
PE
19512011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1952
15e3a074
PE
1953 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1954 This fixes some race conditions on the permissions of any newly
1955 created file.
1956
41bed37d
PE
1957 * alloc.c (valid_pointer_p): Use pipe, not open.
1958 This fixes some permissions issues when debugging.
1959
b59b67c5
PE
1960 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1961 If fchown fails to set both uid and gid, try to set just gid,
1962 as that is sometimes allowed. Adjust the file's mode to eliminate
1963 setuid or setgid bits that are inappropriate if fchown fails.
1964
925a6be7
SM
19652011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1966
1967 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1968 to compare Lisp_Objects.
1969 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1970 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1971 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1972
52968808
AS
19732011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1974
0a6a104b
AS
1975 * lread.c (read_integer): Unread even EOF character.
1976 (read1): Likewise. Properly record start position of symbol.
1977
52968808
AS
1978 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1979 symbol character follows.
1980
9e381cdd
PE
19812011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1984 This works around a problem with the previous change to Fcopy_file.
1985 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1986 and without this change, GCC might complain about discarding
1987 fchown's return value.
1988
b5641435
JB
19892011-07-16 Juanma Barranquero <lekktu@gmail.com>
1990
1991 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1992
a8031457
PE
19932011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1994
1995 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1996
dd889327
LMI
19972011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1998
750c33f7
LMI
1999 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2000 it's used from the C level.
2001
dd889327
LMI
2002 * process.c: Use the same condition for POLL_FOR_INPUT in both
2003 keyboard.c and process.c (bug#1858).
2004
87e86684
LM
20052011-07-09 Lawrence Mitchell <wence@gmx.li>
2006
2007 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2008 (Fgnutls_boot): Use it.
2009
64348f40
AS
20102011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2011
2012 * doc.c (Fsubstitute_command_keys): Revert last change.
2013
1d698799
LMI
20142011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2015
f863868c
LMI
2016 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2017 quotes the next character, and doesn't affect other longer
2018 sequences (bug#8935).
2019
1d698799
LMI
2020 * lread.c (syms_of_lread): Clarify that is isn't only
2021 `eval-buffer' and `eval-defun' that's affected by
2022 `lexical-binding' (bug#8460).
2023
aa4b6df6
EZ
20242011-07-15 Eli Zaretskii <eliz@gnu.org>
2025
2026 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2027 bidi redisplay when a line includes both an image and is
2028 truncated.
2029
5d856da6
PE
20302011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2031
ad6042bb
PE
2032 Fix minor problems found by static checking.
2033 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2034 (elsz): Now a signed constant, not a size_t var. We prefer signed
2035 types to unsigned, to avoid integer comparison confusion. Without
2036 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2037 "cannot optimize loop, the loop counter may overflow", a symptom
2038 of the confusion.
f00bbb22 2039 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2040 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2041
6468f31c
LMI
20422011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2043
49080b10
LMI
2044 * search.c (Fre_search_backward): Mention `case-fold-search' in
2045 all the re_search_* functions (bug#8138).
2046
6468f31c
LMI
2047 * keyboard.c (Fopen_dribble_file): Document when the file is
2048 closed (bug#8056).
2049
c965adc5
EZ
20502011-07-14 Eli Zaretskii <eliz@gnu.org>
2051
df9733bf
EZ
2052 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2053 bidi_cache_idx.
2054
0bb23927
EZ
2055 Support bidi reordering of display and overlay strings.
2056 * xdisp.c (compute_display_string_pos)
2057 (compute_display_string_end): Accept additional argument STRING.
2058 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2059 (reseat_to_string): Initialize bidi_it->string.s and
2060 bidi_it->string.schars.
2061 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2062 NULL (avoids a crash in bidi_paragraph_init).
2063 Initialize itb.string.lstring.
0bb23927
EZ
2064 (init_iterator): Call bidi_init_it only of a valid
2065 buffer position was specified. Initialize paragraph_embedding to
2066 L2R.
2067 (reseat_to_string): Initialize the bidi iterator.
2068 (display_string): If we need to ignore text properties of
2069 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2070 original value of -1 will not work with bidi.)
2071 (compute_display_string_pos): First arg is now struct
2072 `text_pos *'; all callers changed. Support display properties on
2073 Lisp strings.
2074 (compute_display_string_end): Support display properties on Lisp
2075 strings.
2076 (init_iterator, reseat_1, reseat_to_string): Initialize the
2077 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2078 when iterating on a string not from display properties).
640c8776
SM
2079 (compute_display_string_pos, compute_display_string_end):
2080 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2081 arrow keys.
2082 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2083 base_level_stop; instead, set base_level_stop to BEGV.
2084 Fixes crashes in vertical-motion.
0bb23927
EZ
2085 (next_element_from_buffer): Improve commentary for when
2086 the iterator is before prev_stop.
2087 (init_iterator): Initialize bidi_p from the default value of
2088 bidi-display-reordering, not from buffer-local value. Use the
2089 buffer-local value only if initializing for buffer iteration.
2090 (handle_invisible_prop): Support invisible properties on strings
2091 that are being bidi-reordered.
2092 (set_iterator_to_next): Support bidi reordering of C strings and
2093 Lisp strings.
2094 (next_element_from_string): Support bidi reordering of Lisp
2095 strings.
2096 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2097 (display_string): Support display of R2L glyph rows.
2098 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2099 (init_iterator): Don't initialize it->bidi_p for strings
2100 here.
2101 (reseat_to_string): Initialize it->bidi_p for strings here.
2102 (next_element_from_string, next_element_from_c_string)
2103 (next_element_from_buffer): Add xassert's for correspondence
2104 between IT's object being iterated and it->bidi_it.string
2105 structure.
2106 (face_before_or_after_it_pos): Support bidi iteration.
2107 (next_element_from_c_string): Handle the case of the first string
2108 character that is not the first one in the visual order.
2109 (get_visually_first_element): New function, refactored from common
2110 parts of next_element_from_buffer, next_element_from_string, and
2111 next_element_from_c_string.
2112 (tool_bar_lines_needed, redisplay_tool_bar)
2113 (display_menu_bar): Force left-to-right direction. Add a FIXME
2114 comment for making that be controlled by a user option.
2115 (push_it, pop_it): Save and restore the state of the
2116 bidi iterator. Save and restore the bidi_p flag.
2117 (pop_it): Iterate out of display property for string iteration as
2118 well.
2119 (iterate_out_of_display_property): Support iteration over strings.
2120 (handle_single_display_spec): Set up it->bidi_it for iteration
2121 over a display string, and call bidi_init_it.
2122 (handle_single_display_spec, next_overlay_string)
2123 (get_overlay_strings_1, push_display_prop): Set up the bidi
2124 iterator for displaying display or overlay strings.
2125 (forward_to_next_line_start): Don't use the shortcut if
2126 bidi-iterating.
2127 (back_to_previous_visible_line_start): If handle_display_prop
2128 pushed the iterator stack, restore the internal state of the bidi
2129 iterator by calling bidi_pop_it same number of times.
2130 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2131 and we are bidi-iterating, don't decrement the iterator position;
2132 instead, set the first_elt flag in the bidi iterator, to produce
2133 the same effect.
2134 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2135 (push_display_prop): xassert that we are iterating a buffer.
2136 (push_it, pop_it): Save and restore paragraph_embedding member.
2137 (handle_single_display_spec, next_overlay_string)
2138 (get_overlay_strings_1, reseat_1, reseat_to_string)
2139 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2140 correctly. Don't assume unibyte strings are not bidi-reordered.
2141 (compute_display_string_pos)
2142 (compute_display_string_end): Fix handling the case of C string.
2143 (push_it, pop_it): Save and restore from_disp_prop_p.
2144 (handle_single_display_spec, push_display_prop): Set the
2145 from_disp_prop_p flag.
2146 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2147 (pop_it): Call iterate_out_of_display_property only if we are
2148 popping after iteration over a string that came from a display
2149 property. Fix a typo in popping stretch info. Add an assertion
2150 for verifying that the iterator position is in sync with the bidi
2151 iterator.
2152 (handle_single_display_spec, get_overlay_strings_1)
2153 (push_display_prop): Fix initialization of paragraph direction for
2154 string when that of the parent object is not yet determined.
2155 (reseat_1): Call bidi_init_it to resync the bidi
2156 iterator with IT's position. (Bug#7616)
2157 (find_row_edges): If ROW->start.pos gives position
2158 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2159 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2160 Reset the from_disp_prop_p flag.
2161 (SAVE_IT, RESTORE_IT): New macros.
2162 (pos_visible_p, face_before_or_after_it_pos)
2163 (back_to_previous_visible_line_start)
2164 (move_it_in_display_line_to, move_it_in_display_line)
2165 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2166 (try_scrolling, redisplay_window, display_line): Use them when
2167 saving a temporary copy of the iterator and restoring it back.
2168 (back_to_previous_visible_line_start, reseat_1)
2169 (init_iterator): Empty the bidi cache "stack".
2170 (move_it_in_display_line_to): If iterator ended up at
2171 EOL, but we never saw any buffer positions smaller than
2172 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2173 motion in bidi-reordered lines.
2174 (move_it_in_display_line_to): Record prev_method and prev_pos
2175 immediately before the call to set_iterator_to_next. Fixes cursor
2176 motion in bidi-reordered lines with stretch glyphs and strings
2177 displayed in margins. (Bug#8133) (Bug#8867)
2178 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2179 TO_CHARPOS.
640c8776
SM
2180 (pos_visible_p): Support positions in bidi-reordered lines.
2181 Save and restore bidi cache.
0bb23927
EZ
2182
2183 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2184 (bidi_paragraph_info): Delete unused struct.
2185 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2186 (bidi_cache_start): New variable.
2187 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2188 to zero.
2189 (bidi_cache_fetch_state, bidi_cache_search)
2190 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2191 (bidi_cache_find, bidi_peek_at_next_level)
2192 (bidi_level_of_next_char, bidi_find_other_level_edge)
2193 (bidi_move_to_visually_next): Compare cache index with
2194 bidi_cache_start rather than with zero.
2195 (bidi_fetch_char): Accept new argument STRING; all callers
2196 changed. Support iteration over a string. Support strings with
2197 display properties. Support unibyte strings. Fix the type of
2198 `len' according to what STRING_CHAR_AND_LENGTH expects.
2199 (bidi_paragraph_init, bidi_resolve_explicit_1)
2200 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2201 (bidi_level_of_next_char, bidi_move_to_visually_next):
2202 Support iteration over a string.
0bb23927
EZ
2203 (bidi_set_sor_type, bidi_resolve_explicit_1)
2204 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2205 can now be zero (for strings); special values 0 and -1 were
2206 changed to -1 and -2, respectively.
2207 (bidi_char_at_pos): New function.
2208 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2209 Call it instead of FETCH_MULTIBYTE_CHAR.
2210 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2211 initialized to valid values.
2212 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2213 values.
2214 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2215 the test for valid cached positions. Fix the logic for looking up
2216 the sentinel state in the cache. GCPRO the Lisp string we are
2217 iterating.
2218 (bidi_push_it, bidi_pop_it): New functions.
2219 (bidi_initialize): Initialize the bidi cache start stack pointer.
2220 (bidi_cache_ensure_space): New function, refactored from part of
2221 bidi_cache_iterator_state. Don't assume the required size is just
2222 one BIDI_CACHE_CHUNK away.
2223 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2224 (bidi_count_bytes, bidi_char_at_pos): New functions.
2225 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2226 always valid if bidi_cache_idx is valid.
2227 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2228 is valid if it's going to be used.
2229 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2230 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2231 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2232 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2233 (bidi_find_other_level_edge, bidi_cache_start_stack):
2234 All variables related to cache indices are now EMACS_INT.
c965adc5 2235
0bb23927
EZ
2236 * dispextern.h (struct bidi_string_data): New structure.
2237 (struct bidi_it): New member `string'. Make flag members be 1-bit
2238 fields, and put them last in the struct.
640c8776
SM
2239 (compute_display_string_pos, compute_display_string_end):
2240 Update prototypes.
0bb23927
EZ
2241 (bidi_push_it, bidi_pop_it): Add prototypes.
2242 (struct iterator_stack_entry): New members bidi_p,
2243 paragraph_embedding, and from_disp_prop_p.
2244 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2245 (bidi_shelve_cache, bidi_unshelve_cache):
2246 Declare prototypes.
0bb23927
EZ
2247
2248 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2249 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2250 and vector-like objects.
2251
2252 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2253 cache around display iteration.
2254
2255 * window.c (Fwindow_end, window_scroll_pixel_based)
2256 (displayed_window_lines, Frecenter): Save and restore the bidi
2257 cache around display iteration.
2258
3bbd2265
LMI
22592011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2260
2261 * editfns.c (Fdelete_region): Clarify the use of the named
2262 parameters (bug#6788).
2263
adc47434
MR
22642011-07-14 Martin Rudalics <rudalics@gmx.at>
2265
2266 * indent.c (Fvertical_motion): Set and restore w->pointm when
2267 saving and restoring the window's buffer (Bug#9006).
2268
837c31f8
LMI
22692011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2270
2271 * editfns.c (Fstring_to_char): Clarify just what is returned
2272 (bug#6576). Text by Eli Zaretskii.
2273
ac389d0c
JB
22742011-07-13 Juanma Barranquero <lekktu@gmail.com>
2275
2276 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2277
0be0ce47
EZ
22782011-07-13 Eli Zaretskii <eliz@gnu.org>
2279
2280 * buffer.c (mmap_find): Fix a typo.
2281
cd18e7e3
JB
22822011-07-13 Johan Bockgård <bojohan@gnu.org>
2283
2284 Fix execution of x selection hooks.
2285 * xselect.c (Qx_lost_selection_functions)
2286 (Qx_sent_selection_functions): New vars.
2287 (syms_of_xselect): DEFSYM them.
2288 (x_handle_selection_request): Pass Qx_sent_selection_functions
2289 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2290 (x_handle_selection_clear,x_clear_frame_selections):
2291 Pass Qx_lost_selection_functions rather than
2292 Vx_lost_selection_functions to Frun_hook_with_args.
2293
47ea7f44
PE
22942011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2295
ac389d0c 2296 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2297 The old code sometimes used this field without initializing it.
2298
47ea7f44
PE
2299 * alloc.c (gc_sweep): Don't read past end of array.
2300 In theory, the old code could also have corrupted Emacs internals,
2301 though it'd be very unlikely.
2302
bc985c87
AS
23032011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2304
2305 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2306 argument. (Bug#4026)
bc985c87 2307
0cf34688
LMI
23082011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2309
b3dadd76
LMI
2310 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2311 key" (bug#4257).
2312
0cf34688
LMI
2313 * window.c (Fset_window_start): Doc fix (bug#4199).
2314 (Fset_window_hscroll): Ditto.
2315
270768cd
PE
23162011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2317
077e3dda 2318 Fix minor new problems caught by GCC 4.6.1.
270768cd 2319 * term.c (init_tty): Remove unused local.
490011a6 2320 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2321 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2322 not used otherwise.
270768cd 2323
b1f58454
CY
23242011-07-12 Chong Yidong <cyd@stupidchicken.com>
2325
2326 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2327
22b9578d
LMI
23282011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2329
6e70ab07
LMI
2330 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2331 are the mini-buffer and the echo area (bug#3320).
2332
22b9578d
LMI
2333 * term.c (init_tty): Remove support for supdup, c10 and perq
2334 terminals, which are no longer supported (bug#1482).
2335
8974cc9f
JB
23362011-07-10 Johan Bockgård <bojohan@gnu.org>
2337
2338 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2339
a560d974
JD
23402011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2341
2342 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2343 for non-popups (Bug#3642).
2344
1dae0f0a
AS
23452011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2346
268c2c36 2347 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2348 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2349 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2350 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2351 * data.c (fmod): Likewise.
2352 * dispnew.c (swap_glyphs_in_rows): Likewise.
2353 * emacs.c (memory_warning_signal): Likewise.
2354 * floatfns.c (float_error): Likewise.
2355 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2356 (otf_open, font_otf_capability, generate_otf_features)
2357 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2358 Likewise.
2359 * image.c (pbm_read_file): Likewise.
2360 * indent.c (string_display_width): Likewise.
2361 * intervals.c (check_for_interval, search_for_interval)
2362 (inc_interval_count, count_intervals, root_interval)
2363 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2364 * lread.c (defalias): Likewise.
268c2c36 2365 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2366 * regex.c (set_image_of_range_1, set_image_of_range)
2367 (regex_grow_registers): Likewise.
2368 * sysdep.c (strerror): Likewise.
2369 * termcap.c (valid_filename_p, tprint, main): Likewise.
2370 * tparam.c (main): Likewise.
2371 * unexhp9k800.c (run_time_remap, save_data_space)
2372 (update_file_ptrs, read_header, write_header, calculate_checksum)
2373 (copy_file, copy_rest, display_header): Likewise.
2374 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2375 Likewise.
2376 * xdisp.c (check_it): Likewise.
2377 * xfaces.c (register_color, unregister_color, unregister_colors):
2378 Likewise.
2379 * xfns.c (print_fontset_result): Likewise.
2380 * xrdb.c (member, fatal, main): Likewise.
2381
99033785
PE
23822011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2383
2384 Fix minor problems found by static checking (Bug#9031).
2385 * chartab.c (char_table_set_range, map_sub_char_table):
2386 Remove unused locals.
2387 (uniprop_table): Now static.
2388 * composite.c (_work_char): Remove unused static var.
2389
9cb2ac56
JB
23902011-07-09 Juanma Barranquero <lekktu@gmail.com>
2391
2392 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2393
f25661f0
JD
23942011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2395
2396 * gtkutil.c (qttip_cb): Remove code without function.
2397
8278c4fe
EZ
23982011-07-09 Eli Zaretskii <eliz@gnu.org>
2399
2400 * w32.c (pthread_sigmask): New stub.
2401
1692ae2d 24022011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2403
8a6ebd58 2404 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2405 sigprocmask is portable only for single-threaded applications, and
2406 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2407 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2408 (LIBES): Use it.
2409 * callproc.c (Fcall_process):
2410 * process.c (create_process):
2411 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2412 Use pthread_sigmask, not sigprocmask.
123403e4 2413
1b854618
JD
24142011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2415
2416 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2417 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2418 wrong (Bug#8591).
2419
3fe4b549
JD
24202011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2421
0ce7e563
JD
2422 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2423 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2424 (xg_hide_tooltip): Fix comment.
2425
3fe4b549
JD
2426 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2427 in registerServicesMenuSendTypes.
2428 (validRequestorForSendType): Don't check ns_return_types.
2429
2430 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2431 ns_return_type.
2432
5df75e47
JR
24332011-07-08 Jason Rumney <jasonr@gnu.org>
2434
2435 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2436 frame struct members of non-existent frames (Bug#6284).
2437
699c10bd
JD
24382011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2439
4393663b
JD
2440 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2441 variable firstTime not needed on OSX >= 10.6.
2442 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2443 >= 10.5. Use setKnobProportion, setDoubleValue.
2444
2445 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2446 (MAC_OS_X_VERSION_10_5): Define if not defined.
2447 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2448 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2449 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2450
2451 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2452 cString and lossyCString on OSX >= 10.4
2453
2454 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2455 sizeToFit on OSX >= 10.2.
2456
2457 * nsimage.m (allocInitFromFile): Don't use deprecated method
2458 bestRepresentationForDevice on OSX >= 10.6.
2459
2460 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2461 to avoid warning.
2462
2463 * emacs.c: Declare unexec_init_emacs_zone.
2464
a63e0781
JD
2465 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2466
699c10bd
JD
2467 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2468
2469 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2470 on svcsMenu (Bug#8842).
2471
2472 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2473 ns_return_types.
2474 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2475
2476 * nsterm.m (QUTF8_STRING): Declare.
2477 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2478 (validRequestorForSendType): Return type is (id).
2479 Change indexOfObjectIdenticalTo to indexOfObject.
2480 Check if we have local selection before returning self (Bug#8842).
2481 (writeSelectionToPasteboard): Put local selection into paste board
2482 if we have a local selection (Bug#8842).
2483 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2484
2485 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2486 (ns_get_local_selection): Declare.
2487
54e10184
LMI
24882011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2489
9888ff71
LMI
2490 * keymap.c (describe_map_tree): Don't insert a double newline at
2491 the end of the buffer (bug#1169) and return whether we inserted
2492 something.
2493
54e10184
LMI
2494 * callint.c (Fcall_interactively): Change "reading args" to
2495 "providing args" to try to clarify what it does (bug#1010).
2496
15fa4783
KH
24972011-07-07 Kenichi Handa <handa@m17n.org>
2498
2499 * composite.c (composition_compute_stop_pos): Ignore a static
2500 composition starting before CHARPOS (Bug#8915).
2501
2502 * xdisp.c (handle_composition_prop): Likewise.
2503
a8815b00
EZ
25042011-07-07 Eli Zaretskii <eliz@gnu.org>
2505
2506 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2507 (Bug#9015)
2508
ef7b981d 25092011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2510
2511 * character.h (unicode_category_t): New enum type.
2512
2513 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2514 (Qchar_code_property_table): New variable.
2515 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2516 (UNIPROP_COMPRESSED_FORM_P): New macros.
2517 (char_table_ascii): Uncompress the compressed values.
2518 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2519 Uncompress the compressed values.
ac389d0c 2520 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2521 (char_table_ref_and_range): Uncompress the compressed values.
2522 (sub_char_table_set): New arg is_uniprop. Callers changed.
2523 Uncompress the compressed values.
2524 (sub_char_table_set_range): Args changed. Callers changed.
2525 (char_table_set_range): Adjuted for the above change.
2526 (map_sub_char_table): Delete args default_val and parent. Add arg
2527 top. Give decoded values to a Lisp function.
640c8776 2528 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2529 values to a Lisp function. Gcpro more variables.
2530 (uniprop_table_uncompress)
2531 (uniprop_decode_value_run_length): New functions.
2532 (uniprop_decoder, uniprop_decoder_count): New variables.
2533 (uniprop_get_decoder, uniprop_encode_value_character)
2534 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2535 New functions.
2536 (uniprop_encoder, uniprop_encoder_count): New variables.
2537 (uniprop_get_encoder, uniprop_table)
2538 (Funicode_property_table_internal, Fget_unicode_property_internal)
2539 (Fput_unicode_property_internal): New functions.
2540 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2541 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2542 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2543 char-code-property-alist.
2544
640c8776 2545 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2546 Vunicode_category_table.
2547
640c8776 2548 * font.c (font_range): Adjust for the change of
c805dec0
KH
2549 Vunicode_category_table.
2550
76b397fb
DN
25512011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2552
2553 * m/iris4d.h: Remove file, move contents ...
2554 * s/irix6-5.h: ... here.
2555
22b4128e
PE
25562011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2557
2558 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2559 * alloc.c (mark_buffer):
2560 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2561 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2562 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2563 This isn't true in general, and it's particularly not true
2564 if Emacs is configured with --with-wide-int.
2565 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2566 New macros, used in the buffer.c change.
2567
869795d6
JD
25682011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2569
2570 * xsettings.c: Use both GConf and GSettings if both are available.
2571 (store_config_changed_event): Add comment.
2572 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2573 (store_tool_bar_style_changed): New functions.
5e617bc2 2574 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2575 (struct xsettings): Move font inside HAVE_XFT.
2576 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2577 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2578 Move inside HAVE_XFT.
640c8776 2579 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2580 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2581 also.
2582 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2583 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2584 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2585 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2586 (parse_settings): Move check for font inside HAVE_XFT.
2587 (read_settings, apply_xft_settings): Add comment.
2588 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2589 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2590 call store_font_name_changed.
2591 (xft_settings_event): Add comment.
2592 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2593 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2594 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2595 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2596 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2597 (xsettings_get_system_font, xsettings_get_system_normal_font):
2598 Add comment.
869795d6 2599
d8ed26bd
PE
26002011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 Random fixes. E.g., (random) never returned negative values.
2603 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2604 subseconds part to the entropy, as that's a bit more random.
2605 Prefer signed to unsigned, since the signedness doesn't matter and
2606 in general we prefer signed. When given a limit, use a
2607 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2608 latter isn't right if USE_2_TAGS_FOR_INTS.
2609 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2610 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2611
cabf1cac
SM
26122011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2613
2614 * textprop.c (text_property_stickiness):
2615 Obey Vtext_property_default_nonsticky.
2616 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2617 * w32fns.c (syms_of_w32fns):
2618 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2619
6e9b2be9
PE
26202011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2621
2622 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2623 This is more efficient than Ffile_directory_p and avoids a minor race.
2624
90186c68
LMI
26252011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2626
7c301272
LMI
2627 * buffer.c (Foverlay_put): Say what the return value is
2628 (bug#7835).
2629
c4f2d8d4
LMI
2630 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2631 is a directory before asking whether to use the file name
2632 (bug#7564).
ad637907
LMI
2633 (barf_or_query_if_file_exists): Make the "File is a directory"
2634 error be more correct.
c4f2d8d4 2635
90186c68
LMI
2636 * fns.c (Frequire): Remove the mention of the .gz files, since
2637 that's installation-specific, but keep the mention of
2638 `get-load-suffixes'.
2639
da64016e
PE
26402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2641
2642 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2643 Report string overflow if the output is too long.
2644
7d47b580
JB
26452011-07-04 Juanma Barranquero <lekktu@gmail.com>
2646
a555cb87
JB
2647 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2648 (syms_of_gnutls): Remove duplicate DEFSYM for
2649 Qgnutls_bootprop_verify_hostname_error, an error for
2650 Qgnutls_bootprop_verify_error (which is no longer used).
2651
7d47b580
JB
2652 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2653 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2654 Also (re)move comments that are misplaced or no longer relevant.
2655
1e49bfab
LMI
26562011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2657
2658 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2659
1485f4c0
CY
26602011-07-03 Chong Yidong <cyd@stupidchicken.com>
2661
2662 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2663 and background color parameters if they have been changed.
2664
a9ab721e
LMI
26652011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2666
2667 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2668
cf7cff57
PE
26692011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2670
2e13213d
PE
2671 * xsettings.c (SYSTEM_FONT): Define only when used.
2672 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2673
cf7cff57
PE
2674 * keymap.c (access_keymap_1): Now static.
2675
7a8e04f7
CY
26762011-07-02 Chong Yidong <cyd@stupidchicken.com>
2677
2678 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2679 leave any prefix arg for the up event (Bug#1586).
2680
61352f62
LMI
26812011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2682
69bb1ef7
LMI
2683 * lread.c (syms_of_lread): Mention single symbols defined by
2684 `defvar' or `defconst' (bug#7154).
2685
61352f62 2686 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2687 (Frequire): Mention get-load-suffixes.
61352f62 2688
28545e04
MR
26892011-07-02 Martin Rudalics <rudalics@gmx.at>
2690
2691 * window.h (window): Remove clone_number slot.
2692 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2693 Remove.
2694 (make_parent_window, make_window, saved_window)
2695 (Fset_window_configuration, save_window_save): Don't deal with
2696 clone numbers.
2697 * buffer.c (Qclone_number): Remove declaration.
2698 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2699
3349e122
SM
27002011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2701
2702 Add multiple inheritance to keymaps.
2703 * keymap.c (Fmake_composed_keymap): New function.
2704 (Fset_keymap_parent): Simplify.
2705 (fix_submap_inheritance): Remove.
2706 (access_keymap_1): New function extracted from access_keymap to handle
2707 embedded parents and handle lists of maps.
2708 (access_keymap): Use it.
2709 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2710 (Fcopy_keymap): Handle embedded parents.
2711 (Fcommand_remapping, define_as_prefix): Simplify.
2712 (Fkey_binding): Simplify.
2713 (syms_of_keymap): Move minibuffer-local-completion-map,
2714 minibuffer-local-filename-completion-map,
2715 minibuffer-local-must-match-map, and
2716 minibuffer-local-filename-must-match-map to Elisp.
2717 (syms_of_keymap): Defsubr make-composed-keymap.
2718 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2719 (parse_menu_item): Trivial simplification.
2720
3279eb87
GM
27212011-07-01 Glenn Morris <rgm@gnu.org>
2722
2723 * Makefile.in (SETTINGS_LIBS): Fix typo.
2724
4550efdf
KI
27252011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2726
2727 * coding.c (Fencode_coding_string): Record the last coding system
2728 used, as the function doc string says (bug#8738).
2729
0949d2b6
JD
27302011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2731
2732 * xsettings.c (store_monospaced_changed): Take new font as arg and
2733 check for change against current_mono_font.
2734 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2735 (emacs_settings_constructor, emacs_settings_get_property)
2736 (emacs_settings_set_property, emacs_settings_class_init)
2737 (emacs_settings_init, gsettings_obj): Remove.
2738 (something_changedCB): New function for HAVE_GSETTINGS.
2739 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2740 with value as argument.
2741 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2742 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2743 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2744 "changed".
2745
2746 * xgselect.c: Add defined (HAVE_GSETTINGS).
2747 (xgselect_initialize): Ditto.
2748
2749 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2750 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2751 xg_select.
2752
bbc6b304
PE
27532011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2754
2755 * eval.c (struct backtrace): Simplify and port the data structure.
2756 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2757 signed bit field, as this assumption is not portable and it makes
2758 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2759 "char debug_on_exit : 1" as this is not portable either; instead,
2760 use the portable "unsigned int debug_on_exit : 1". Remove unused
2761 member evalargs. Remove obsolete comments about cc bombing out.
2762
9851bfc5
JD
27632011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2764
51bb811f 2765 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2766 Let HAVE_GSETTINGS override HAVE_GCONF.
2767 (store_monospaced_changed): New function.
2768 (EMACS_SETTINGS): A new type derived from GObject to handle
2769 GSettings notifications.
2770 (emacs_settings_constructor, emacs_settings_get_property)
2771 (emacs_settings_set_property, emacs_settings_class_init):
2772 New functions.
2773 (gsettings_client, gsettings_obj): New variables.
2774 (GSETTINGS_SCHEMA): New define.
2775 (something_changedCB): Call store_monospaced_changed.
2776 (init_gsettings): New function.
2777 (xsettings_initialize): Call init_gsettings.
2778 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2779 to NULL.
2780
640c8776 2781 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2782 GCONF_CFLAGS/LIBS.
2783
5386012d
MR
27842011-06-29 Martin Rudalics <rudalics@gmx.at>
2785
2786 * window.c (resize_root_window, grow_mini_window)
2787 (shrink_mini_window): Rename Qresize_root_window to
2788 Qwindow_resize_root_window and Qresize_root_window_vertically to
2789 Qwindow_resize_root_window_vertically.
2790
f13e0b08
PE
27912011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2792
2793 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2794
94515237
JB
27952011-06-27 Juanma Barranquero <lekktu@gmail.com>
2796
2797 * makefile.w32-in: Redesign dependencies so they reflect more
2798 clearly which files are directly included by each source file,
2799 and not through other includes.
2800
e43b6e43
MR
28012011-06-27 Martin Rudalics <rudalics@gmx.at>
2802
2803 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2804 (sort_overlays, overlay_strings): When an overlay's clone number
2805 matches the window's clone number process the overlay even if
2806 the overlay's window property doesn't match the current window.
2807
d68443dc
MR
2808 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2809 (Fwindow_hchild): Rename to Fwindow_left_child.
2810 (Fwindow_next): Rename to Fwindow_next_sibling.
2811 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2812 (resize_window_check): Rename to window_resize_check.
2813 (resize_window_apply): Rename to window_resize_apply.
2814 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2815 (Fdelete_other_windows_internal, resize_frame_windows)
2816 (Fsplit_window_internal, Fdelete_window_internal)
2817 (grow_mini_window, shrink_mini_window)
2818 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2819
c7e73be5
JD
28202011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2821
2822 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2823 (emacs_fixed_set_min_size): Remove.
2824 (emacs_fixed_new): Take frame as argument.
2825
2826 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2827 (_EmacsFixedPrivate): Remove minwidth/height.
2828 Add struct frame *f.
2829 (emacs_fixed_init): Initialize priv->f.
2830 (get_parent_class, emacs_fixed_set_min_size): Remove.
2831 (emacs_fixed_new): Set priv->f to argument.
2832 (emacs_fixed_get_preferred_width)
2833 (emacs_fixed_get_preferred_height): Use min_width/height from
2834 frames size_hint to set minimum and natural (Bug#8919).
2835 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2836 and use min_width/height from frames size_hint to set
2837 min_width/height (Bug#8919).
2838
2839 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2840 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2841 Fix indentation.
c7e73be5 2842
cf99dcf8
EZ
28432011-06-26 Eli Zaretskii <eliz@gnu.org>
2844
2845 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2846 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2847 called at ZV.
2848
029529ac
CY
28492011-06-26 Chong Yidong <cyd@stupidchicken.com>
2850
2851 * process.c (wait_reading_process_output): Bypass select if
2852 waiting for a cell while ignoring keyboard input, and input is
2853 pending. Suggested by Jan Djärv (Bug#8869).
2854
7a7ef429
PE
28552011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2856
2857 Use gnulib's dup2 module instead of rolling our own.
2858 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2859
11fdef7d 28602011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2861
2862 * dispnew.c (scrolling_window): Before scrolling, turn off a
2863 mouse-highlight in the window being scrolled.
2864
cd3520a4
JB
28652011-06-24 Juanma Barranquero <lekktu@gmail.com>
2866
2867 Move DEFSYM to lisp.h and use everywhere.
2868
2869 * character.h (DEFSYM): Move declaration...
2870 * lisp.h (DEFSYM): ...here.
2871
2872 * gnutls.c:
2873 * minibuf.c:
2874 * w32menu.c:
2875 * w32proc.c:
2876 * w32select.c: Don't include character.h.
2877
2878 * alloc.c (syms_of_alloc):
2879 * buffer.c (syms_of_buffer):
2880 * bytecode.c (syms_of_bytecode):
2881 * callint.c (syms_of_callint):
2882 * casefiddle.c (syms_of_casefiddle):
2883 * casetab.c (init_casetab_once):
2884 * category.c (init_category_once, syms_of_category):
2885 * ccl.c (syms_of_ccl):
2886 * cmds.c (syms_of_cmds):
2887 * composite.c (syms_of_composite):
2888 * dbusbind.c (syms_of_dbusbind):
2889 * dired.c (syms_of_dired):
2890 * dispnew.c (syms_of_display):
2891 * doc.c (syms_of_doc):
2892 * editfns.c (syms_of_editfns):
2893 * emacs.c (syms_of_emacs):
2894 * eval.c (syms_of_eval):
2895 * fileio.c (syms_of_fileio):
2896 * fns.c (syms_of_fns):
2897 * frame.c (syms_of_frame):
2898 * fringe.c (syms_of_fringe):
2899 * insdel.c (syms_of_insdel):
2900 * keymap.c (syms_of_keymap):
2901 * lread.c (init_obarray, syms_of_lread):
2902 * macros.c (syms_of_macros):
2903 * msdos.c (syms_of_msdos):
2904 * print.c (syms_of_print):
2905 * process.c (syms_of_process):
2906 * search.c (syms_of_search):
2907 * sound.c (syms_of_sound):
2908 * syntax.c (init_syntax_once, syms_of_syntax):
2909 * terminal.c (syms_of_terminal):
2910 * textprop.c (syms_of_textprop):
2911 * undo.c (syms_of_undo):
2912 * w32.c (globals_of_w32):
2913 * window.c (syms_of_window):
2914 * xdisp.c (syms_of_xdisp):
2915 * xfaces.c (syms_of_xfaces):
2916 * xfns.c (syms_of_xfns):
2917 * xmenu.c (syms_of_xmenu):
2918 * xsettings.c (syms_of_xsettings):
2919 * xterm.c (syms_of_xterm): Use DEFSYM.
2920
4228cf16
TZ
29212011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2922
cd3520a4 2923 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2924
7fcccf1e
PE
29252011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2926
7efb4e0e
PE
2927 Integer and buffer overflow fixes (Bug#8873).
2928
ff5844ad
PE
2929 * print.c (printchar, strout): Check for string overflow.
2930 (PRINTPREPARE, printchar, strout):
2931 Don't set size unless allocation succeeds.
2932
90532f02
PE
2933 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2934 for sizes. Check for string overflow more accurately.
2935 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2936
6d84508d
PE
2937 * macros.c: Integer and buffer overflow fixes.
2938 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2939 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2940 Use ptrdiff_t, not int, for sizes.
2941 Don't increment bufsize until after realloc succeeds.
2942 Check for size-calculation overflow.
2943 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2944
437b2cb4
PE
2945 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2946
8b9ac8b4
PE
2947 * lread.c: Integer overflow fixes.
2948 (read_integer): Radix is now EMACS_INT, not int,
2949 to improve quality of diagnostics for out-of-range radices.
2950 Calculate buffer size correctly for out-of-range radices.
2951 (read1): Check for integer overflow in radices, and in
2952 read-circle numbers.
82cb60d3
PE
2953 (read_escape): Avoid int overflow.
2954 (Fload, openp, read_buffer_size, read1)
2955 (substitute_object_recurse, read_vector, read_list, map_obarray):
2956 Use ptrdiff_t, not int, for sizes.
2957 (read1): Use EMACS_INT, not int, for sizes.
20270765 2958 Check for size overflow.
8b9ac8b4 2959
7fcccf1e
PE
2960 * image.c (cache_image): Check for size arithmetic overflow.
2961
bfbbd7e7
PE
2962 * lread.c: Integer overflow issues.
2963 (saved_doc_string_size, saved_doc_string_length)
2964 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2965 Now ptrdiff_t, not int.
2966 (read1): Don't assume doc string length fits in int. Check for
2967 out-of-range doc string lengths.
2968 (read_list): Don't assume file position fits in int.
39019e54 2969 (read_escape): Check for hex character overflow.
bfbbd7e7 2970
4e323265
LL
29712011-06-22 Leo Liu <sdl.web@gmail.com>
2972
2973 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2974 Move to minibuffer.el.
2975
85fece3e
PE
29762011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2977
20b84ce9 2978 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2979 The following patches are for when GLYPH_DEBUG && !XASSERT.
2980 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2981 * dispnew.c (flush_stdout):
2982 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2983 Mark as externally visible.
2984 * dispnew.c (check_window_matrix_pointers): Now static.
2985 * dispnew.c (window_to_frame_vpos):
2986 * xfns.c (unwind_create_frame):
2987 * xterm.c (x_check_font): Remove unused local.
2988 * scroll.c (CHECK_BOUNDS):
2989 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2990 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2991 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2992 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2993 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2994 Now static.
2995 (debug_method_add): Use va_list and vsprintf rather than relying
2996 on undefined behavior with wrong number of arguments.
2997 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2998 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2999 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3000 since we're not interested in debugging glyphs with old libraries.
3001 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3002 GCC 4.6.0's static checking.
3003
0766b489
PE
30042011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3005
31fd4b32
PE
3006 Integer overflow and signedness fixes (Bug#8873).
3007 A few related buffer overrun fixes, too.
3008
b79e8648
PE
3009 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3010
0766b489
PE
3011 * dispextern.h (struct face.stipple):
3012 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3013 (x_bitmap_mask, x_allocate_bitmap_record)
3014 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3015 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3016 (x_create_bitmap_from_xpm_data):
3017 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3018 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3019 (.bitmaps_last):
3020 * xfaces.c (load_pixmap):
3021 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3022 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3023 (.bitmaps_last, struct x_output.icon_bitmap):
3024 Use ptrdiff_t, not int, for bitmap indexes.
3025 (x_allocate_bitmap_record): Check for size overflow.
3026 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3027
b081724f
PE
3028 Use ptrdiff_t, not int, for overlay counts.
3029 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3030 * editfns.c (overlays_around, get_pos_property):
3031 * textprop.c (get_char_property_and_overlay):
3032 * xdisp.c (next_overlay_change, note_mouse_highlight):
3033 * xfaces.c (face_at_buffer_position):
21514da7
PE
3034 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3035 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3036 (Fnext_overlay_change, Fprevious_overlay_change)
3037 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3038 Use ptrdiff_t, not int, for sizes.
21514da7 3039 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3040
3de73e5e
PE
3041 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3042
2606c57b
PE
3043 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3044 (x_session_initialize): Do not assume string length fits in int.
3045
aaafe47a
PE
3046 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3047 This is unlikely, but can occur if DPI is outlandish.
3048
2674ddc8 3049 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3050 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3051
28154962
PE
3052 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3053 * xrdb.c (magic_file_p, search_magic_path):
3054 Omit last arg SUFFIX; it was always 0. All callers changed.
3055 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3056
7de51af5
PE
3057 * xfont.c (xfont_match): Avoid need for strlen.
3058
25ed6cc3
PE
3059 * xfns.c: Don't assume strlen fits in int.
3060 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3061
4eab31dd
PE
3062 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3063 not unsigned long, as we prefer signed integers. All callers changed.
3064 Detect integer overflow in repeat count.
3065 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3066 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3067
171e2a58
PE
3068 * termcap.c: Don't assume sizes fit in int and never overflow.
3069 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3070 (gobble_line): Check for size-calculation overflow.
3071
ad39faca 3072 * minibuf.c (Fread_buffer):
6e5bb2dc 3073 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3074 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3075 Don't assume string length fits in int.
3076
52c61c22 3077 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3078 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3079
b5b8c9e5
PE
3080 * font.c: Don't assume string length fits in int.
3081 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3082 Use ptrdiff_t, not int.
ccd6111c
PE
3083 (font_intern_prop): Don't assume string length fits in int.
3084 Don't assume integer property fits in fixnum.
3085 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3086
882f0d81 3087 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3088 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3089 Reformulate so as not to need the command string.
3090 Invoke gzip -cd rather than gunzip, as it's more portable.
3091 (lock_info_type, lock_file_1, lock_file):
3092 Don't assume pid_t and time_t fit in unsigned long.
3093 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3094 (current_lock_owner): Prefer signed type for sizes.
3095 Use memcpy, not strncpy, where memcpy is what is really wanted.
3096 Don't assume (via atoi) that time_t and pid_t fit in int.
3097 Check for time_t and/or pid_t out of range, e.g., via a network share.
3098 Don't alloca where an auto var works fine.
3099
93f4cf88
PE
3100 * fileio.c: Fix some integer overflow issues.
3101 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3102 Don't assume string length fits in int.
3103 (directory_file_name): Don't assume string length fits in long.
3104 (make_temp_name): Don't assume pid fits in int, or that its print
3105 length is less than 20.
3106
f3e92b69
PE
3107 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3108
1bfdaf10
PE
3109 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3110
35016e9a
PE
3111 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3112
3d1e65a1
PE
3113 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3114 We prefer signed integers, even for size calculations.
3115
0b963a93
PE
3116 * emacs.c: Don't assume string length fits in 'int'.
3117 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3118 (main): Don't invoke strlen when not needed.
3119
573f4b54
PE
3120 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3121 (XD_DEBUG_MESSAGE): Don't waste a byte.
3122
989f33ba
PE
3123 * callproc.c (getenv_internal_1, getenv_internal)
3124 (Fgetenv_internal):
965d34eb
PE
3125 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3126
e4d29b33
PE
3127 * lread.c (invalid_syntax): Omit length argument.
3128 All uses changed. This doesn't fix a bug, but it simplifies the
3129 code away from its former Hollerith-constant appearance, and it's
3130 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3131 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3132
eb49b136
PE
3133 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3134 This didn't break anything, but it didn't help either.
3135 It's confusing to put a bogus integer in a place where the actual
3136 value does not matter.
9f62aeb1 3137 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3138 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3139
15375a22
PE
3140 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3141 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3142 implementation.
b61cc01c
PE
3143 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3144 We prefer signed types, and the value cannot exceed the EMACS_INT
3145 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3146 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3147 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3148 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3149
53b2623d
PE
3150 * indent.c (sane_tab_width): New function.
3151 (current_column, scan_for_column, Findent_to, position_indentation)
3152 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3153 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3154
51cab52b 3155 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3156
f2ed8a70
PE
3157 * lisp.h (lint_assume): New macro.
3158 * composite.c (composition_gstring_put_cache):
3159 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3160
abe80cc6
PE
3161 * editfns.c, insdel.c:
3162 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3163
b02c740e
PE
3164 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3165
ebc96716
PE
3166 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3167
b4e50fa0 3168 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3169 Use much-faster test for byte-length change.
311d5d7c 3170 Don't assume string byte-length fits in 'int'.
a4cf38e4 3171 Check that character arg fits in 'int'.
85461888 3172 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3173
c0c1ee9f
PE
3174 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3175
a498d7f4
PE
3176 * fns.c (concat): Catch string overflow earlier.
3177 Do not rely on integer wraparound.
3178
51cab52b
PE
3179 * dispextern.h (struct it.overlay_strings_charpos)
3180 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3181 * xdisp.c (forward_to_next_line_start)
3182 (back_to_previous_visible_line_start)
3183 (reseat_at_next_visible_line_start, next_element_from_buffer):
3184 Don't arbitrarily truncate the value of 'selective' to int.
3185
76031fad
PE
3186 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3187
5eb55db9
PE
3188 * composite.c: Don't truncate sizes to 'int'.
3189 (composition_gstring_p, composition_reseat_it)
3190 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3191 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3192 not EMACS_UINT, for indexes.
5eb55db9 3193
0703a717
PE
3194 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3195
d6202519
PE
3196 * buffer.c: Include <verify.h>.
3197 (struct sortvec.priority, struct sortstr.priority):
8961a454 3198 Now EMACS_INT, not int.
c20998a7 3199 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3200 (struct sortstr.size, record_overlay_string)
3201 (struct sortstrlist.size, struct sortlist.used):
3202 Don't truncate size to int.
3203 (record_overlay_string): Check for size-calculation overflow.
d6202519 3204 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3205
d5a19415
JM
32062011-06-22 Jim Meyering <meyering@redhat.com>
3207
029529ac 3208 Don't leak an XBM-image-sized buffer
d5a19415
JM
3209 * image.c (xbm_load): Free the image buffer after using it.
3210
a9041e6c
PE
32112011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3212
3213 Port to Sun C.
3214 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3215 that Sun C diagnosed.
3216 * fns.c (secure_hash): Fix pointer signedness issue.
3217 * intervals.c (static_offset_intervals): New function.
3218 (offset_intervals): Use it.
3219
7f3f739f
LL
32202011-06-21 Leo Liu <sdl.web@gmail.com>
3221
3222 * deps.mk (fns.o):
3223 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3224 sha512.h.
3225
3226 * fns.c (secure_hash): Rename from crypto_hash_function and change
3227 the first arg to accept symbols.
5b66d427 3228 (Fsecure_hash): New primitive.
7f3f739f
LL
3229 (syms_of_fns): New symbols.
3230
76147d94
DD
32312011-06-20 Deniz Dogan <deniz@dogan.se>
3232
3233 * process.c (Fset_process_buffer): Clarify return value in
3234 docstring.
3235
7d7d0045
CY
32362011-06-18 Chong Yidong <cyd@stupidchicken.com>
3237
3238 * dispnew.c (add_window_display_history): Use BVAR.
3239
3240 * xdisp.c (debug_method_add): Use BVAR.
3241 (check_window_end, dump_glyph_matrix, dump_glyph)
3242 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3243
3244 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3245 Likewise.
3246
3247 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3248 check till after the cache is created in init_frame_faces.
3249
ff2bc410
SM
32502011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3251
3252 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3253
28177add
PE
32542011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3255
dd3482fe
PE
3256 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3257 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3258 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3259
393d71f3 3260 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3261 * fileio.c (Finsert_file_contents):
3262 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3263 Remove the old (too-loose) buffer overflow checks.
3264 They weren't needed, since make_gap checks for buffer overflow.
3265 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3266 The old code merely checked for Emacs fixnum overflow, and relied
3267 on undefined (wraparound) behavior. The new code avoids undefined
3268 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3269
2e6813b0 3270 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3271 Tune. Don't use wider integers than needed. Don't use alloca.
3272 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3273
599a9e4f
PE
3274 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3275
99561444
PE
3276 * insdel.c, lisp.h (buffer_overflow): New function.
3277 (insert_from_buffer_1, replace_range, replace_range_2):
3278 * insdel.c (make_gap_larger):
3279 * editfns.c (Finsert_char):
3280 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3281
28177add
PE
3282 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3283
e69dafad
PE
32842011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3285
a7af7fde 3286 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3287
b1c46f02
PE
3288 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3289 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3290
e69dafad
PE
3291 * fileio.c: Don't assume EMACS_INT fits in off_t.
3292 (emacs_lseek): New static function.
3293 (Finsert_file_contents, Fwrite_region): Use it.
3294 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3295
566684ea
PE
3296 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3297
e6966cd6
PE
3298 * fns.c: Don't overflow int when computing a list length.
3299 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3300 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3301 truncation on 64-bit hosts. Check for QUIT every
3302 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3303 faster and is responsive enough.
3304 (Flength): Report an error instead of overflowing an integer.
3305 (Fsafe_length): Return a float if the value is not representable
3306 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3307 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3308 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3309
dd0b0efb
PE
3310 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3311 (header_size, word_size): New constants.
3312 (allocate_vectorlike): Don't check size overflow here.
3313 (allocate_vector): Check it here instead, since this is the only
3314 caller of allocate_vectorlike that could cause overflow.
3315 Check that the new vector's length is representable as a fixnum.
3316
86fe5cfe
PE
3317 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3318 The previous code was bogus. For example, next_almost_prime (32)
3319 returned 39, which is undesirable as it is a multiple of 3; and
3320 next_almost_prime (24) returned 25, which is a multiple of 5 so
3321 why was the code bothering to check for multiples of 7?
3322
80e88859
PE
3323 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3324
4a2f0ad6
PE
3325 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3326
f66c7cf8
PE
3327 Variadic C functions now count arguments with ptrdiff_t.
3328 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3329 Back then I didn't know that the Emacs coding style prefers signed int.
3330 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3331 were being counted with int, which may truncate counts on 64-bit
3332 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3333 * lisp.h (struct Lisp_Subr.function.aMANY)
3334 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3335 Arg counts are now ptrdiff_t, not size_t.
3336 All variadic functions and their callers changed accordingly.
3337 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3338 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3339 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3340 * callint.c (Fcall_interactively): Check arg count for overflow,
3341 to avoid potential buffer overrun. Use signed char, not 'int',
3342 for 'varies' array, so that we needn't bother to check its size
3343 calculation for overflow.
3344 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3345 * eval.c (apply_lambda):
3346 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3347 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3348 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3349
a1759b76
PE
3350 * callint.c (Fcall_interactively): Don't use index var as event count.
3351
d96be9fc
PE
3352 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3353 * mem-limits.h (SIZE): Remove; no longer used.
3354
a690a978 3355 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3356
578c21e6
PE
3357 Remove unnecessary casts.
3358 * xterm.c (x_term_init):
3359 * xfns.c (x_set_border_pixel):
3360 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3361 These aren't needed now that we assume ANSI C.
3362
96f53c6c
PE
3363 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3364 It's more likely to cause problems (due to unsigned overflow)
3365 than to cure them.
3366
83c77d31
PE
3367 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3368
ee2079f1
PE
3369 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3370
6da65536
PE
3371 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3372
7147c4a4
PE
3373 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3374
193e32d9
PE
3375 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3376
e5533da6
PE
3377 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3378
9910e595
PE
3379 GLYPH_CODE_FACE returns EMACS_INT, not int.
3380 * dispextern.h (merge_faces):
3381 * xfaces.c (merge_faces):
01103c44
PE
3382 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3383 Don't assume EMACS_INT fits in int.
9910e595 3384
2638320e
PE
3385 * character.h (CHAR_VALID_P): Remove unused parameter.
3386 * fontset.c, lisp.h, xdisp.c: All uses changed.
3387
045eb8d9
PE
3388 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3389
c1f134b5
PE
3390 * fns.c (concat): Minor tuning based on overflow analysis.
3391 This doesn't fix any bugs. Use int to hold character, instead
3392 of constantly refetching from Emacs object. Use XFASTINT, not
3393 XINT, for value known to be a character. Don't bother comparing
3394 a single byte to 0400, as it's always less.
3395
395fcb93 3396 * floatfns.c (Fexpt):
327eeec8
PE
3397 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3398
abbd3d23
PE
3399 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3400 for characters.
3401
684a03ef
PE
3402 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3403
0fed43f3
PE
3404 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3405 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3406 incorrectly succeed when S was a string, because 4294967386 was
3407 truncated before it was used.
3408
8fd02eb7
PE
3409 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3410 Otherwise, an out-of-range integer could cause undefined behavior
3411 on a 64-bit host.
3412
f8c86b69
PE
3413 * composite.c: Use int, not EMACS_INT, for characters.
3414 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3415 EMACS_INT, for values that are known to be in character range.
3416 This doesn't fix any bugs but is the usual style inside Emacs and
3417 may generate better code on 32-bit machines.
3418
34206dd2
PE
3419 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3420 This is for reasons similar to the recent CHAR_STRING fix.
3421 * charset.c (Fencode_char): Check that character arg is actually
3422 a character. Pass an int to ENCODE_CHAR.
3423 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3424 wider than 'int', as a compile-time check to prevent future regressions
3425 in this area.
3426
c5958d4c 3427 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3428
3429 Make sure a 64-bit char is never passed to CHAR_STRING.
3430 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3431 by silently ignoring the top 32 bits, allowing some values
3432 that were far too large to be valid characters.
3433 * character.h: Include <verify.h>.
3434 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3435 arguments are no wider than unsigned, as a compile-time check
3436 to prevent future regressions in this area.
3437 * data.c (Faset):
01103c44 3438 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3439 (Fsubst_char_in_region):
3440 * fns.c (concat):
3441 * xdisp.c (decode_mode_spec_coding):
3442 Adjust to CHAR_STRING's new requirement.
3443 * editfns.c (Finsert_char, Fsubst_char_in_region):
3444 * fns.c (concat): Check that character args are actually
3445 characters. Without this test, these functions did the wrong
3446 thing with wildly out-of-range values on 64-bit hosts.
3447
d37ca623
PE
3448 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3449 These casts should not be needed on 32-bit hosts, either.
3450 * keyboard.c (read_char):
3451 * lread.c (Fload): Remove casts to unsigned.
3452
ea204efb
PE
3453 * lisp.h (UNSIGNED_CMP): New macro.
3454 This fixes comparison bugs on 64-bit hosts.
3455 (ASCII_CHAR_P): Use it.
3456 * casefiddle.c (casify_object):
01103c44 3457 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3458 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3459 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3460 * dispextern.h (FACE_FROM_ID):
3461 * keyboard.c (read_char): Use UNSIGNED_CMP.
3462
41cb286c
PE
3463 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3464 not to EMACS_INT, to avoid GCC warning.
3465
4a1b9832
PE
3466 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3467
55daad71
PE
3468 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3469 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3470 isn't needed on 32-bit machines.
8f95c75c 3471
01103c44
PE
3472 * buffer.c (Fgenerate_new_buffer_name):
3473 Use EMACS_INT for count, not int.
0ceccced 3474 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3475
3476 * data.c (Qcompiled_function): Now static.
3477
c6f072e7
PE
3478 * window.c (window_body_lines): Now static.
3479
20ce5912
PE
3480 * image.c (gif_load): Rename local to avoid shadowing.
3481
9c4c5f81
PE
3482 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3483 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3484 * alloc.c (make_save_value): Integer argument is now of type
3485 ptrdiff_t, not int.
3486 (mark_object): Use ptrdiff_t, not int.
3487 * lisp.h (pD): New macro.
3488 * print.c (print_object): Use it.
3489
c0c5c8ae
PE
3490 * alloc.c: Use EMACS_INT, not int, to count objects.
3491 (total_conses, total_markers, total_symbols, total_vector_size)
3492 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3493 (total_free_floats, total_floats, total_free_intervals)
3494 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3495 Now EMACS_INT, not int. All uses changed.
3496 (Fgarbage_collect): Compute overall total using a double, so that
3497 integer overflow is less likely to be a problem. Check for overflow
3498 when converting back to an integer.
5a25e253
PE
3499 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3500 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3501 These were 'int' variables that could overflow on 64-bit hosts;
3502 they were never used, so remove them instead of repairing them.
211a0b2a 3503 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3504 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3505 Previously, this ceilinged at INT_MAX, but that doesn't work on
3506 64-bit machines.
e46bb31a 3507 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3508
c78baabf 3509 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3510 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3511 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3512 when a (possibly-narrower) signed value would do just as well.
3513 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3514
c9d624c6
PE
3515 * alloc.c: Catch some string size overflows that we were missing.
3516 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3517 for convenience in STRING_BYTES_MAX.
3518 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3519 The definition here is exact; the one in lisp.h was approximate.
3520 (allocate_string_data): Check for string overflow. This catches
3521 some instances we weren't catching before. Also, it catches
3522 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3523 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3524 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3525
c9d624c6
PE
3526 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3527 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3528 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3529
353032ce
PE
3530 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3531
2bccce07
PE
3532 * alloc.c (Fmake_string): Check for out-of-range init.
3533
0ac30604
SM
35342011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3535
3536 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3537
c195f2de
JD
35382011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3539
3540 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3541 xg_get_default_scrollbar_width.
3542
3543 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3544 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3545 (style_changed_cb): Call update_theme_scrollbar_width and call
3546 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3547 all frames (Bug#8505).
3548 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3549 Call gtk_window_set_resizable if HAVE_GTK3.
3550 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3551 and height if HAVE_GTK3 (Bug#8505).
3552 (scroll_bar_width_for_theme): New variable.
3553 (update_theme_scrollbar_width): New function.
3554 (xg_get_default_scrollbar_width): Move code to
3555 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3556 (xg_initialize): Call update_theme_scrollbar_width.
3557
3558 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3559
3560 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3561
e10ac9f1
MR
35622011-06-12 Martin Rudalics <rudalics@gmx.at>
3563
3564 * frame.c (make_frame): Call other_buffer_safely instead of
3565 other_buffer.
3566
3567 * window.c (temp_output_buffer_show): Call display_buffer with
3568 second argument Vtemp_buffer_show_specifiers and reset latter
3569 immediately after the call.
3570 (Vtemp_buffer_show_specifiers): New variable.
3571 (auto_window_vscroll_p, next_screen_context_lines)
3572 (Vscroll_preserve_screen_position): Remove leading asterisks from
3573 doc-strings.
3574
2d3c217e 35752011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3576
7b7f97e8 3577 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3578 * buffer.c (Qclone_number): Remove for now, as it's unused.
3579 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3580 (record_buffer): Remove unused local.
3581 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3582 (set_frame_buffer_list): Remove; unused.
3583 * frame.h (other_visible_frames): Remove decl.
3584 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3585 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3586 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3587 if HAVE_GPM.
3588 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3589 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3590 Define only if HAVE_GPM.
3591 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3592 (update_hints_inhibit): Remove; never set. All uses removed.
3593 * widgetprv.h (emacsFrameClassRec): Remove decl.
3594 * window.c (delete_deletable_window): Now returns void, since it
3595 wasn't returning anything.
3596 (compare_window_configurations): Remove unused locals.
3597 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3598 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3599 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3600 the same widths as pointers. This follows up on the 2011-05-06 patch.
3601 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3602 * xterm.h: Likewise.
3603 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3604
1384b89e
JB
36052011-06-12 Juanma Barranquero <lekktu@gmail.com>
3606
3607 * makefile.w32-in: Update dependencies.
3608 (LISP_H): Add lib/intprops.h.
3609
1100a63c
CY
36102011-06-11 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * image.c (gif_load): Add animation frame delay to the metadata.
3613 (syms_of_image): Use DEFSYM. New symbol `delay'.
3614
6198ccd0
MR
36152011-06-11 Martin Rudalics <rudalics@gmx.at>
3616
3617 * window.c (delete_deletable_window): Re-add.
3618 (Fset_window_configuration): Rewrite to handle dead buffers and
3619 consequently deletable windows.
3620 (window_tree, Fwindow_tree): Remove. Supply functionality in
3621 window.el.
3622 (compare_window_configurations): Simplify code.
3623
b6e3633c
AS
36242011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3625
1ab0dee5
AS
3626 * image.c (imagemagick_load_image): Fix type mismatch.
3627 (Fimagemagick_types): Likewise.
3628
b6e3633c
AS
3629 * window.h (replace_buffer_in_windows): Declare.
3630
9397e56f
MR
36312011-06-11 Martin Rudalics <rudalics@gmx.at>
3632
3633 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3634 Qclone_number. Remove external declaration of Qdelete_window.
3635 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3636 code.
640c8776
SM
3637 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3638 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3639 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3640 buffer list implementation.
3641 (other_buffer_safely): New function.
3642 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3643 calls to replace_buffer_in_windows and
3644 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3645 if allowed.
3646 (record_buffer): Inhibit quitting and rewrite using quittable
3647 functions. Run Qbuffer_list_update_hook if allowed.
3648 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3649 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3650 Move switch-to-buffer to window.el.
9397e56f
MR
3651 (bury-buffer): Move to window.el.
3652 (Vbuffer_list_update_hook): New variable.
3653
3654 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3655 section.
3656
3657 * window.h (resize_frame_windows): Move up in code.
3658 (Fwindow_frame): Remove EXFUN.
3659 (replace_buffer_in_all_windows): Remove prototype.
3660 (replace_buffer_in_windows_safely): Add prototype.
3661
3662 * window.c: Declare Qdelete_window static again. Move down
3663 declaration of select_count.
3664 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3665 (Fother_window): Move to window.el.
3666 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3667 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3668 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3669 window.el.
3670 (replace_buffer_in_windows): Implement by calling
3671 Qreplace_buffer_in_windows.
3672 (replace_buffer_in_all_windows): Remove with some functionality
3673 moved into replace_buffer_in_windows_safely.
3674 (replace_buffer_in_windows_safely): New function.
3675 (select_window_norecord, select_frame_norecord): Move in front
3676 of run_window_configuration_change_hook. Remove now obsolete
3677 declarations.
640c8776
SM
3678 (Fset_window_buffer): Rewrite doc-string.
3679 Call Qrecord_window_buffer.
9397e56f
MR
3680 (keys_of_window): Move binding for other-window to window.el.
3681
b50691aa
CY
36822011-06-11 Chong Yidong <cyd@stupidchicken.com>
3683
3684 * dispextern.h (struct image): Replace data member, whose int_val
3685 and ptr_val fields were not used by anything, with a single
3686 lisp_val object.
3687
3688 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3689 (gif_clear_image, gif_load, imagemagick_load_image)
3690 (gs_clear_image, gs_load): Callers changed.
3691
3f754b86
PE
36922011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3693
cca69397
PE
3694 * buffer.h: Include <time.h>, for time_t.
3695 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3696
109e28d0
PE
3697 Fix minor problems found by static checking.
3698
60737f02
PE
3699 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3700
4b66faf3
PE
3701 Make identifiers static if they are not used in other modules.
3702 * data.c (Qcompiled_function, Qframe, Qvector):
3703 * image.c (QimageMagick, Qsvg):
3704 * minibuf.c (Qmetadata):
3705 * window.c (resize_window_check, resize_root_window): Now static.
3706 * window.h (resize_window_check, resize_root_window): Remove decls.
3707
109e28d0
PE
3708 * window.c (window_deletion_count, delete_deletable_window):
3709 Remove; unused.
46a4ce9e
PE
3710 (window_body_lines): Now static.
3711 (Fdelete_other_windows_internal): Mark vars as initialized.
3712 Make sure 'resize_failed' is initialized.
3713 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3714 (resize_window_apply): Remove unused local.
3715 * window.h (delete_deletable_window): Remove decl.
3716
109e28d0 3717 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3718 (imagemagick_load_image): Fix pointer signedness problem by changing
3719 last arg from unsigned char * to char *. All uses changed.
3720 Also, fix a local for similar reasons.
3721 Remove unused locals. Remove locals to avoid shadowing.
3722 (fn_rsvg_handle_free): Remove; unused.
3723 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3724 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3725
3f754b86
PE
3726 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3727
2547adb1
CY
37282011-06-10 Chong Yidong <cyd@stupidchicken.com>
3729
3730 * image.c (gif_load): Fix omitted cast error introduced by
3731 2011-06-06 change.
3732
2c8e37d4
MR
37332011-06-10 Martin Rudalics <rudalics@gmx.at>
3734
3735 * window.h (resize_proportionally, orig_total_lines)
3736 (orig_top_line): Remove from window structure.
3737 (set_window_height, set_window_width, change_window_heights)
3738 (Fdelete_window): Remove prototypes.
3739 (resize_frame_windows): Remove duplicate declaration.
3740
440a42e3
EZ
37412011-06-10 Eli Zaretskii <eliz@gnu.org>
3742
3743 * window.h (resize_frame_windows, resize_window_check)
3744 (delete_deletable_window, resize_root_window)
3745 (resize_frame_windows): Declare prototypes.
3746
3747 * window.c (resize_window_apply): Make definition be "static" to
3748 match the prototype.
3749
562dd5e9
MR
37502011-06-10 Martin Rudalics <rudalics@gmx.at>
3751
3752 * window.c: Remove declarations of Qwindow_size_fixed,
3753 window_min_size_1, window_min_size_2, window_min_size,
3754 size_window, window_fixed_size_p, enlarge_window, delete_window.
3755 Remove static from declaration of Qdelete_window, it's
3756 temporarily needed by Fbury_buffer.
3757 (replace_window): Don't assign orig_top_line and
3758 orig_total_lines.
3759 (Fdelete_window, delete_window): Remove. Window deletion is
3760 handled by window.el.
640c8776
SM
3761 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3762 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3763 (Fdelete_other_windows): Remove. Deleting other windows is
3764 handled by window.el.
3765 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3766 handled in window.el.
3767 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3768 Window minimum sizes are handled in window.el.
3769 (shrink_windows, size_window, set_window_height)
3770 (set_window_width, change_window_heights, window_height)
3771 (window_width, CURBEG, CURSIZE, enlarge_window)
3772 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3773 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3774 handled in window.el.
3775 (make_dummy_parent): Rename to make_parent_window and give it a
3776 second argument horflag.
3777 (make_window): Don't set resize_proportionally any more.
3778 (Fsplit_window): Remove. Windows are split in window.el.
3779 (save_restore_action, save_restore_orig_size)
3780 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3781 Resize mini windows in window.el.
3782 (grow_mini_window, shrink_mini_window): Implement by calling
3783 Qresize_root_window_vertically, resize_window_check and
3784 resize_window_apply.
640c8776
SM
3785 (saved_window, Fset_window_configuration, save_window_save):
3786 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3787 resize_proportionally.
3788 (window_min_height, window_min_width): Move to window.el.
3789 (keys_of_window): Move bindings for delete-other-windows,
3790 split-window, delete-window and enlarge-window to window.el.
3791
3792 * buffer.c: Temporarily extern Qdelete_window.
3793 (Fbury_buffer): Temporarily call Qdelete_window instead of
3794 Fdelete_window (Fbury_buffer will move to window.el soon).
3795
3796 * frame.c (set_menu_bar_lines_1): Remove code handling
3797 orig_top_line and orig_total_lines.
3798
3799 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3800 set_window_height but set heights directly.
3801 (change_frame_size_1): Use resize_frame_windows.
3802
3803 * xdisp.c (init_xdisp): Don't use set_window_height but set
3804 heights directly.
3805
640c8776
SM
3806 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3807 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3808 run_window_configuration_change_hook.
3809
3810 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3811 instead of change_window_heights and run
3812 run_window_configuration_change_hook.
3813
1a13852e
MR
38142011-06-09 Martin Rudalics <rudalics@gmx.at>
3815
3816 * window.c (replace_window): Rename second argument REPLACEMENT to
3817 NEW. New third argument SETFLAG. Rewrite.
3818 (delete_window, make_dummy_parent): Call replace_window with
3819 third argument 1.
3820 (window_list_1): Move down in code.
3821 (run_window_configuration_change_hook): Move set_buffer part
3822 before select_frame_norecord part in order to unwind correctly.
3823 Rename count1 to count.
3824 (recombine_windows, delete_deletable_window, resize_root_window)
3825 (Fdelete_other_windows_internal)
3826 (Frun_window_configuration_change_hook, make_parent_window)
3827 (resize_window_check, resize_window_apply, Fresize_window_apply)
3828 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3829 (Fdelete_window_internal, Fresize_mini_window_internal):
3830 New functions.
1a13852e
MR
3831 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3832
f3d1777e
MR
38332011-06-08 Martin Rudalics <rudalics@gmx.at>
3834
496e208e
MR
3835 * window.h (window): Add some new members to window structure -
3836 normal_lines, normal_cols, new_total, new_normal, clone_number,
3837 splits, nest, prev_buffers, next_buffers.
3838 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3839 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3840
f3d1777e
MR
3841 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3842 Remove.
496e208e
MR
3843 (make_dummy_parent): Set new members of windows structure.
3844 (make_window): Move down in code. Handle new members of window
3845 structure.
3846 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3847 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3848 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3849 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3850 (Fset_window_next_buffers, Fset_window_clone_number):
3851 New functions.
496e208e
MR
3852 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3853 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3854 Doc-string fixes.
3855 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3856 Argument WINDOW can be now internal window too.
3857 (Fwindow_use_time): Move up in code.
3858 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3859 Rewrite doc-string.
3860 (Fset_window_configuration, saved_window)
3861 (Fcurrent_window_configuration, save_window_save): Handle new
3862 members of window structure.
b9e809c2
MR
3863 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3864 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3865 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3866 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3867 Qget_mru_window, Qresize_root_window,
3868 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3869 Qauto_buffer_name; staticpro them.
f3d1777e 3870
abde8f8c
MR
38712011-06-07 Martin Rudalics <rudalics@gmx.at>
3872
3873 * window.c (Fwindow_total_size, Fwindow_left_column)
3874 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3875 (Fwindow_list_1): New functions.
3876 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3877 (Fwindow_width, Fscroll_left, Fscroll_right):
3878 Use window_body_cols instead of window_box_text_cols.
3879 (delete_window, Fset_window_configuration):
3880 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3881 (delete_all_subwindows): Take a window as argument and not a
3882 structure. Rewrite.
190b47e6
MR
3883 (window_loop): Remove handling of GET_LRU_WINDOW and
3884 GET_LARGEST_WINDOW.
3885 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3886
3887 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3888 window_box_text_cols. delete_all_subwindows now takes a
3889 Lisp_Object as argument.
abde8f8c 3890
640c8776
SM
3891 * indent.c (compute_motion, Fcompute_motion):
3892 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3893
fa8a67e6
MR
3894 * frame.c (delete_frame): Call delete_all_subwindows with root
3895 window as argument.
3896
a54e3482
DC
38972011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3898
3899 * fns.c (Fputhash): Document return value.
3900
60002bf5
CY
39012011-06-06 Chong Yidong <cyd@stupidchicken.com>
3902
3903 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3904
0c671da6 39052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3906
b862a52a 3907 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3908
be44ca6c
PE
3909 Check for overflow when converting integer to cons and back.
3910 * charset.c (Fdefine_charset_internal, Fdecode_char):
3911 Use cons_to_unsigned to catch overflow.
3912 (Fencode_char): Use INTEGER_TO_CONS.
3913 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3914 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3915 * data.c (long_to_cons, cons_to_long): Remove.
3916 (cons_to_unsigned, cons_to_signed): New functions.
3917 These signal an error for invalid or out-of-range values.
3918 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3919 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3920 * font.c (Ffont_variation_glyphs):
3921 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3922 * lisp.h: Include <intprops.h>.
3923 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3924 (cons_to_signed, cons_to_unsigned): New decls.
3925 (long_to_cons, cons_to_long): Remove decls.
3926 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3927 (Fprimitive_undo): Use CONS_TO_INTEGER.
3928 * xfns.c (Fx_window_property): Likewise.
3929 * xselect.c: Include <limits.h>.
3930 (x_own_selection, selection_data_to_lisp_data):
3931 Use INTEGER_TO_CONS.
3932 (x_handle_selection_request, x_handle_selection_clear)
3933 (x_get_foreign_selection, Fx_disown_selection_internal)
3934 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3935 (lisp_data_to_selection_data): Use cons_to_unsigned.
3936 (x_fill_property_data): Use cons_to_signed.
3937 Report values out of range.
3938
d1f3d2af
PE
3939 Check for buffer and string overflow more precisely.
3940 * buffer.h (BUF_BYTES_MAX): New macro.
3941 * lisp.h (STRING_BYTES_MAX): New macro.
3942 * alloc.c (Fmake_string):
3943 * character.c (string_escape_byte8):
3944 * coding.c (coding_alloc_by_realloc):
3945 * doprnt.c (doprnt):
3946 * editfns.c (Fformat):
3947 * eval.c (verror):
3948 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3949 since they may not be the same number.
3950 * editfns.c (Finsert_char):
3951 * fileio.c (Finsert_file_contents):
3952 Likewise for BUF_BYTES_MAX.
3953
dd52fcea
PE
3954 * image.c: Use ptrdiff_t, not int, for sizes.
3955 (slurp_file): Switch from int to ptrdiff_t.
3956 All uses changed.
3957 (slurp_file): Check that file size fits in both size_t (for
3958 malloc) and ptrdiff_t (for sanity and safety).
3959
7f9bbdbb
PE
3960 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3961 if b->modtime has its maximal value.
3962
dfe18f82
PE
3963 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3964
84acfcf0
PE
3965 Don't assume time_t can fit into int.
3966 * buffer.h (struct buffer.modtime): Now time_t, not int.
3967 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3968 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3969
ccd9a01a
PE
3970 Minor fixes for signed vs unsigned integers.
3971 * character.h (MAYBE_UNIFY_CHAR):
3972 * charset.c (maybe_unify_char):
3973 * keyboard.c (read_char, reorder_modifiers):
3974 XINT -> XFASTINT, since the integer must be nonnegative.
3975 * ftfont.c (ftfont_spec_pattern):
3976 * keymap.c (access_keymap, silly_event_symbol_error):
3977 XUINT -> XFASTINT, since the integer must be nonnegative.
3978 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3979 since it makes no difference and we prefer signed.
3980 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3981 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3982 nonnegative.
3983
d6d100dd
SM
39842011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3985
3986 * window.h (Fwindow_frame): Declare.
3987
2b6148e4
PE
39882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3989
3990 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3991 (SPARE_MEMORY): Always define.
3992 (LARGE_REQUEST): Remove.
3993 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3994
f230ecc9
MR
39952011-06-06 Martin Rudalics <rudalics@gmx.at>
3996
727e958e
MR
3997 * lisp.h: Move EXFUNS for Fframe_root_window,
3998 Fframe_first_window and Fset_frame_selected_window to window.h.
3999
4000 * window.h: Move EXFUNS for Fframe_root_window,
4001 Fframe_first_window and Fset_frame_selected_window here from
4002 lisp.h.
4003
4004 * frame.c (Fwindow_frame, Fframe_first_window)
4005 (Fframe_root_window, Fframe_selected_window)
4006 (Fset_frame_selected_window): Move to window.c.
4007 (Factive_minibuffer_window): Move to minibuf.c.
4008 (Fother_visible_frames_p): New function.
4009
4010 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4011
f230ecc9
MR
4012 * window.c (decode_window, decode_any_window): Move up in code.
4013 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4014 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4015 (Fwindow_buffer): Move up and rewrite doc-string.
4016 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4017 (Fwindow_prev): New functions.
727e958e
MR
4018 (Fwindow_frame): Move here from frame.c. Accept any window as
4019 argument.
4020 (Fframe_root_window, Fframe_first_window)
4021 (Fframe_selected_window): Move here from frame.c. Accept frame
4022 or arbitrary window as argument. Update doc-strings.
4023 (Fminibuffer_window): Move up in code.
4024 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4025 (Fset_frame_selected_window): Move here from frame.c.
4026 Marginal rewrite.
727e958e
MR
4027 (Fselected_window, select_window, Fselect_window): Move up in
4028 code. Minor doc-string fixes.
f230ecc9 4029
4d09bcf6
PE
40302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4031
4032 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4033 Do not assume that spare memory exists; that assumption is valid
4034 only if SYSTEM_MALLOC.
4035 (LARGE_REQUEST): New macro, so that the issue of large requests
4036 is separated from the issue of spare memory.
4037
810928a2
AS
40382011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4039
172418ad
AS
4040 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4041 format. (Bug#8806)
4042
43f862f7
AS
4043 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4044
810928a2
AS
4045 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4046 before statements.
4047
a059fe24
JD
40482011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4049
4050 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4051
4052 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4053
4054 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4055 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4056
989bf368
JB
40572011-06-05 Juanma Barranquero <lekktu@gmail.com>
4058
4059 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4060
4b80f674
CY
40612011-06-04 Chong Yidong <cyd@stupidchicken.com>
4062
4063 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4064 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4065 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4066 New error handlers.
4b80f674
CY
4067 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4068 Obey Vx_select_enable_clipboard_manager. Catch errors in
4069 x_clipboard_manager_save (Bug#8779).
4070 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4071 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4072
99a33b77 40732011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4074
4075 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4076
99a33b77 40772011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4078
4079 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4080 in the current matrix if keep_current_p is non-zero.
4081
8264569d
EZ
40822011-06-04 Eli Zaretskii <eliz@gnu.org>
4083
4084 * bidi.c (bidi_level_of_next_char): Fix last change.
4085
57f97249
EZ
40862011-06-03 Eli Zaretskii <eliz@gnu.org>
4087
fec2107c 4088 Support bidi reordering of text covered by display properties.
57f97249 4089
fec2107c
EZ
4090 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4091 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4092 (bidi_cache_search, bidi_cache_iterator_state)
4093 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4094 (bidi_level_of_next_char, bidi_move_to_visually_next):
4095 Support character positions inside a run of characters covered by a
fec2107c
EZ
4096 display string.
4097 (bidi_paragraph_init, bidi_resolve_explicit_1)
4098 (bidi_level_of_next_char): Call bidi_fetch_char and
4099 bidi_fetch_char_advance instead of FETCH_CHAR and
4100 FETCH_CHAR_ADVANCE.
4101 (bidi_init_it): Initialize new members.
4102 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4103 definitions.
4104 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4105 instead of using explicit *_CHAR codes.
d6d100dd
SM
4106 (bidi_resolve_explicit, bidi_resolve_weak):
4107 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4108 bidirectional text is supported only in multibyte buffers.
4109 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4110 it to initialize the frame_window_p member of struct bidi_it.
4111 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4112 (bidi_resolve_explicit, bidi_resolve_weak)
4113 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4114 bidi_it->nchars is non-positive.
4115 (bidi_level_of_next_char): Don't try to lookup the cache for the
4116 next/previous character if nothing is cached there yet, or if we
4117 were just reseat()'ed to a new position.
c40e2fb2 4118
0e14fe90
EZ
4119 * xdisp.c (set_cursor_from_row): Set start and stop points
4120 according to the row's direction when priming the loop that looks
4121 for the glyph on which to display cursor.
4122 (single_display_spec_intangible_p): Function deleted.
4123 (display_prop_intangible_p): Reimplement to call
4124 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4125 Accept 3 additional arguments needed by handle_display_spec.
4126 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4127 values: lists, `(when COND...)' forms, etc.
4128 (single_display_spec_string_p): Support property values that are
4129 lists with the argument STRING its top-level element.
4130 (display_prop_string_p): Fix the condition for processing a
4131 property that is a list to be consistent with handle_display_spec.
fec2107c 4132 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4133 last portion of handle_display_prop.
4134 (compute_display_string_pos): Accept additional argument
4135 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4136 value of a `display' property is a "replacing spec".
4137 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4138 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4139 the display property, but just return a value indicating whether
4140 the display property will replace the characters it covers.
4141 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4142 frame_window_p members of struct bidi_it.
d6d100dd
SM
4143 (compute_display_string_pos, compute_display_string_end):
4144 New functions.
fec2107c
EZ
4145 (push_it): Accept second argument POSITION, where pop_it should
4146 jump to continue iteration.
4147 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4148
fec2107c
EZ
4149 * keyboard.c (adjust_point_for_property): Adjust the call to
4150 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4151
4152 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4153 (bidi_init_it): Update prototypes.
4154 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4155 (compute_display_string_pos, compute_display_string_end):
4156 Declare prototypes.
fec2107c
EZ
4157 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4158 EMACS_INT.
fc6f18ce 4159
40087514 41602011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4161
57f53182
PE
4162 Malloc failure behavior now depends on size of allocation.
4163 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4164 * lisp.h: Change signatures accordingly.
4165 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4166 All callers changed. (Bug#8762)
4167
4168 * gnutls.c: Use Emacs's memory allocators.
4169 Without this change, the gnutls library would invoke malloc etc.
4170 directly, which causes problems on non-SYNC_INPUT hosts, and which
4171 runs afoul of improving memory_full behavior. (Bug#8761)
4172 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4173 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4174 xfree instead of the default malloc, realloc, free.
4175 (Fgnutls_boot): No need to check for memory allocation failure,
4176 since xmalloc does that for us.
4177
ac32cd99 4178 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4179 * category.c (hash_get_category_set):
4180 * ccl.c (ccl_driver):
4181 * charset.c (Fdefine_charset_internal):
4182 * charset.h (struct charset.hash_index):
4183 * composite.c (get_composition_id, gstring_lookup_cache)
4184 (composition_gstring_put_cache):
4185 * composite.h (struct composition.hash_index):
4186 * dispextern.h (struct image.hash):
4187 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4188 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4189 (hashfn_equal, hashfn_user_defined, make_hash_table)
4190 (maybe_resize_hash_table, hash_lookup, hash_put)
4191 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4192 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4193 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4194 * image.c (make_image, search_image_cache, lookup_image)
4195 (xpm_put_color_table_h):
4196 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4197 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4198 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4199 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4200 * alloc.c (allocate_vectorlike):
4201 Check for overflow in vector size calculations.
4202 * ccl.c (ccl_driver):
4203 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4204 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4205 need to be updated by these changes.
40087514
PE
4206 * fns.c (make_hash_table, maybe_resize_hash_table):
4207 Check for integer overflow with large hash tables.
0de4bb68
PE
4208 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4209 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4210 (SXHASH_REDUCE): New macro.
4211 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4212 Use it instead of discarding useful hash info with large hash values.
4213 (sxhash_float): New function.
4214 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4215 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4216 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4217 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4218 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4219 Adjust signatures to match updated version of code.
4220 (consing_since_gc): Now EMACS_INT, since a single hash table can
4221 use more than INT_MAX bytes.
4222
698d32e2
DN
42232011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4224
4225 Make it possible to build with GCC-4.6+ -O2 -flto.
4226
4227 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4228
fd6fa53f
SM
42292011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4230
4231 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4232 Call minibuffer-inactive-mode.
4233
864db017
JB
42342011-05-31 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4237 Update dependencies.
4238
2ad0baf4
DN
42392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4240
4241 * data.c (init_data): Remove code for UTS, this system is not
4242 supported anymore.
4243
4fcc2638
DN
42442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4245
4246 Don't force ./temacs to start in terminal mode.
4247
4248 * frame.c (make_initial_frame): Initialize faces in all cases, not
4249 only when CANNOT_DUMP is defined.
4250 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4251
c56e0fd5
DN
42522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4253
4254 * dispnew.c (add_window_display_history): Use const for the string
4255 pointer. Remove declaration, not needed.
4256
333d54da 42572011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4258
55d4c1b2 4259 Use 'inline', not 'INLINE'.
333d54da 4260 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4261 * alloc.c, fontset.c (INLINE): Remove.
4262 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4263 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4264 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4265 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4266 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4267
738db178
DN
42682011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4269
4270 Make it possible to run ./temacs.
4271
4272 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4273 syms_of_callproc does the same thing. Remove test for
4274 "initialized", do it in the caller.
4275 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4276
620c53a6
SM
42772011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4278
4279 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4280 (read_minibuf): Use get_minibuffer.
4281 (syms_of_minibuf): Use DEFSYM.
4282 (Qmetadata): New var.
4283 * data.c (Qbuffer): Don't make it static.
4284 (syms_of_data): Use DEFSYM.
4285
e003a292
PE
42862011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4287
4288 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4289 (CCL_CODE_MIN): New macro.
4290
ed008a6d
PE
42912011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4292
3687c2ef
PE
4293 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4294
ed008a6d
PE
4295 * eval.c (Qdebug): Now static.
4296 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4297 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4298 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4299
d66c4c7c
CY
43002011-05-29 Chong Yidong <cyd@stupidchicken.com>
4301
4302 * image.c: Various fixes to ImageMagick code comments.
4303 (Fimagemagick_types): Doc fix.
4304
5fbc2025
PE
43052011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4306
0196f88a
PE
4307 Minor fixes prompted by GCC 4.6.0 warnings.
4308
4309 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4310
5fbc2025
PE
4311 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4312 (x_clipboard_manager_save_all): Move extern decl to ...
4313 * xterm.h: ... here, so that it can be checked for consistency.
4314
1dd3c2d9
CY
43152011-05-29 Chong Yidong <cyd@stupidchicken.com>
4316
4317 * xselect.c (x_clipboard_manager_save_frame)
4318 (x_clipboard_manager_save_all): New functions.
4319 (Fx_clipboard_manager_save): Lisp function deleted.
4320
4321 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4322 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4323
4324 * xterm.h: Update prototype.
4325
5ba6571d
WX
43262011-05-28 William Xu <william.xwl@gmail.com>
4327
4328 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4329 exiting (Bug#8239).
4330
3eaff834
JM
43312011-05-28 Jim Meyering <meyering@redhat.com>
4332
e1900994 4333 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4334 * fns.c (to_uchar): Define.
4335 (crypto_hash_function): Use it to convert some newly-signed
4336 variables to unsigned, to avoid sign-extension bugs. For example,
4337 without this change, (md5 "truc") would evaluate to
4338 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4339 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4340 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4341
0f6990a7
PE
43422011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4343
4344 Integer overflow fixes.
c8a9ca5a 4345
08686060
PE
4346 * dbusbind.c: Serial number integer overflow fixes.
4347 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4348 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4349 to hold a serial number that is too large for a fixnum.
4350 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4351 Check for serial numbers out of range. Decode any serial number
59568bf0 4352 that was so large that it became a float. (Bug#8722)
08686060 4353
2d1fc3c7
PE
4354 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4355 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4356 Use XFASTINT rather than XUINT when numbers are nonnegative.
4357 (xd_append_arg, Fdbus_method_return_internal):
4358 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4359 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4360 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4361 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4362 (Bug#8722)
2d1fc3c7 4363
c8a9ca5a
PE
4364 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4365
519e1d69
PE
4366 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4367
30569699
PE
4368 ccl: add integer overflow checks
4369 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4370 (IN_INT_RANGE): New macros.
4371 (ccl_driver): Use them to check for integer overflow when
4372 decoding a CCL program. Many of the new checks are whether XINT (x)
4373 fits in int; it doesn't always, on 64-bit hosts. The new version
4374 doesn't catch all possible integer overflows, but it's an
847044ea 4375 improvement. (Bug#8719)
30569699 4376
c11285dc
PE
4377 * alloc.c (make_event_array): Use XINT, not XUINT.
4378 There's no need for unsigned here.
4379
fdccd48e
PE
4380 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4381 This follows up to the 2011-05-06 change that substituted uintptr_t
4382 for EMACS_INT. This case wasn't caught back then.
4383
37910ab2
PE
4384 Rework Fformat to avoid integer overflow issues.
4385 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4386 now (part of C89). Include <verify.h>.
4387 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4388 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4389 (Fformat): Avoid the prepass trying to compute sizes; it was only
4390 approximate and thus did not catch overflow reliably. Instead, walk
4391 through the format just once, formatting and computing sizes as we go,
4392 checking for integer overflow at every step, and allocating a larger
4393 buffer as needed. Keep track separately whether the format is
4394 multibyte. Keep only the most-recently calculated precision, rather
4395 than them all. Record whether each argument has been converted to
4396 string. Use EMACS_INT, not int, for byte and char and arg counts.
4397 Support field widths and precisions larger than INT_MAX. Avoid
4398 sprintf's undefined behavior with conversion specifications such as %#d
4399 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4400 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4401 formatting out-of-range floating point numbers with int
9173deec 4402 formats. (Bug#8668)
37910ab2 4403
2e6578fb
PE
4404 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4405
0ae6bdee
PE
4406 * data.c: Avoid integer truncation in expressions involving floats.
4407 * data.c: Include <intprops.h>.
4408 (arith_driver): When there's an integer overflow in an expression
4409 involving floating point, convert the integers to floating point
4410 so that the resulting value does not suffer from catastrophic
4411 integer truncation. For example, on a 64-bit host (* 4
4412 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4413 Do not rely on undefined behavior after integer overflow.
4414
de883a70
PE
4415 merge count_size_as_multibyte, parse_str_to_multibyte
4416 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4417 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4418 Check for integer overflow.
4419 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4420 since it's now a duplicate of the other. This is more of
4421 a character than a buffer op, so better that it's in character.c.
4422 * fns.c, print.c: Adjust to above changes.
4423
2ff916cb
PE
44242011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4425
4426 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4427
f1b54466
PE
44282011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4429
fb1ac845
PE
4430 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4431 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4432 (x_clipboard_manager_save): Now static.
4433 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4434
f1b54466
PE
4435 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4436 (crypto_hash_function): Now static.
4437 Fix pointer signedness problems. Avoid unnecessary initializations.
4438
a9f737ee
CY
44392011-05-27 Chong Yidong <cyd@stupidchicken.com>
4440
4441 * termhooks.h (Vselection_alist): Make it terminal-local.
4442
4443 * terminal.c (create_terminal): Initialize it.
4444
4445 * xselect.c: Support for clipboard managers.
4446 (Vselection_alist): Move to termhooks.h as terminal-local var.
4447 (LOCAL_SELECTION): New macro.
4448 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4449 (symbol_to_x_atom): Remove gratuitous arg.
4450 (x_handle_selection_request, lisp_data_to_selection_data)
4451 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4452 (x_own_selection, x_get_local_selection, x_convert_selection):
4453 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4454 (some_frame_on_display): Delete unused function.
4455 (Fx_own_selection_internal, Fx_get_selection_internal)
4456 (Fx_disown_selection_internal, Fx_selection_owner_p)
4457 (Fx_selection_exists_p): New optional frame arg.
4458 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4459 (x_handle_selection_clear): Don't treat other terminals with the
4460 same keyboard specially. Use the terminal-local Vselection_alist.
4461 (x_clear_frame_selections): Use Frun_hook_with_args.
4462
4463 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4464
4465 * xterm.h: Add support for those atoms.
4466
e067f0c1
CY
44672011-05-26 Chong Yidong <cyd@stupidchicken.com>
4468
4469 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4470 (converted_selections, conversion_fail_tag): New global variables.
4471 (x_selection_request_lisp_error): Free the above.
4472 (x_get_local_selection): Remove unnecessary code.
4473 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4474 of converted selections stored in converted_selections.
4475 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4476 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4477 (x_convert_selection): New function.
4478 (x_handle_selection_event): Simplify.
4479 (x_get_foreign_selection): Don't ignore incoming requests while
4480 waiting for an answer; this will fail when we implement
4481 SAVE_TARGETS, and seems unnecessary anyway.
4482 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4483 (Vx_sent_selection_functions): Doc fix.
4484
0f4aebc0
LL
44852011-05-26 Leo Liu <sdl.web@gmail.com>
4486
4487 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4488
e61124cd
YM
44892011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4490
4491 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4492
4493 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4494 for fringe update if it has periodic bitmap.
ac389d0c 4495 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4496 and fringe_bitmap_periodic_p.
4497
4498 * fringe.c (get_fringe_bitmap_data): New function.
4499 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4500 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4501 row. Mark glyph row for fringe update if periodicity changed.
4502
4503 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4504 for fringe update unless it has periodic bitmap.
4505
f16d9837
KH
45062011-05-25 Kenichi Handa <handa@m17n.org>
4507
4508 * xdisp.c (get_next_display_element): Set correct it->face_id for
4509 a static composition.
4510
e1b90ef6
LL
45112011-05-24 Leo Liu <sdl.web@gmail.com>
4512
4513 * deps.mk (fns.o):
4514 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4515
4516 * fns.c (crypto_hash_function, Fsha1): New function.
4517 (Fmd5): Use crypto_hash_function.
4518 (syms_of_fns): Add Ssha1.
4519
7400048f
PE
45202011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4521
4522 * gnutls.c: Remove unused macros.
4523 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4524 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4525 Remove macros that are defined and never used.
4526 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4527
abb71cf4
CY
45282011-05-22 Chong Yidong <cyd@stupidchicken.com>
4529
4530 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4531 (Fx_get_selection_internal): Minor cleanup.
4532 (Fx_own_selection_internal): Rename arguments for consistency with
4533 select.el.
4534
6307db39
PE
45352011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4536
4537 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4538
f3d4e0a4
CY
45392011-05-22 Chong Yidong <cyd@stupidchicken.com>
4540
4541 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4542
4d8ade89
YM
45432011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4544
4545 * dispnew.c (scrolling_window): Don't exclude the case that the
4546 last enabled row in the desired matrix touches the bottom boundary.
4547
32078c8d
GM
45482011-05-21 Glenn Morris <rgm@gnu.org>
4549
4550 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4551 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4552 and add some more files.
32078c8d 4553
7285dc67
EZ
45542011-05-20 Eli Zaretskii <eliz@gnu.org>
4555
4556 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4557 report_file_error introduced by the change from 2011-05-07.
4558
89d1bd22
PE
45592011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4560
4561 * systime.h (Time): Define only if emacs is defined.
4562 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4563 where the include path doesn't have X11/X.h by default. See
4564 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4565
e23640bb 45662011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4567
4568 * composite.c (find_automatic_composition): Fix previous change.
4569
b9704ad9
GM
45702011-05-20 Glenn Morris <rgm@gnu.org>
4571
4572 * lisp.mk: New file, split from Makefile.in.
4573 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4574 (shortlisp): Remove.
4575 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4576
4a720484
GM
45772011-05-19 Glenn Morris <rgm@gnu.org>
4578
4579 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4580 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4581 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4582 (lisp): Set the order to that of loadup.el.
4583 (shortlisp): Make it a copy of $lisp.
4584 (SOME_MACHINE_LISP): Remove.
4585 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4586 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4587
a28d4396
KH
45882011-05-18 Kenichi Handa <handa@m17n.org>
4589
4590 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4591 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4592 (find_automatic_composition): Mostly rewrite for efficiency.
4593
a2b1fa8e
JB
45942011-05-18 Juanma Barranquero <lekktu@gmail.com>
4595
4596 * makefile.w32-in: Update dependencies.
4597
8e1f5610
CS
45982011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4599
4600 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4601 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4602
7025ee00 46032011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4604
cdfa6eab
PE
4605 Fix some integer overflow issues, such as string length overflow.
4606
06d6db33
PE
4607 * insdel.c (count_size_as_multibyte): Check for string overflow.
4608
2b4560a8
PE
4609 * character.c (lisp_string_width): Check for string overflow.
4610 Use EMACS_INT, not int, for string indexes and lengths; in
4611 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4612 the resulting string length overflows an EMACS_INT; instead,
4613 report a string overflow if no precision given. When checking for
4614 precision exhaustion, use a check that cannot possibly have
4615 integer overflow. (Bug#8675)
4616 * character.h (lisp_string_width): Adjust to new signature.
4617
cb93f9be
PE
4618 * alloc.c (string_overflow): New function.
4619 (Fmake_string): Use it. This doesn't change behavior, but saves
4620 a few bytes and will simplify future changes.
4621 * character.c (string_escape_byte8): Likewise.
4622 * lisp.h (string_overflow): New decl.
4623
1a1f3366
PE
4624 Fixups, following up to the user-interface timestamp change.
4625 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4626 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4627 * msdos.c (mouse_get_pos): Likewise.
4628 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4629 * w32gui.h (Time): Define by including "systime.h" rather than by
4630 declaring it ourselves. (Bug#8664)
4631
d4e3e4d3
PE
4632 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4633 * image.c (clear_image_cache): Likewise.
4634
f6a24d19
PE
4635 * term.c (term_mouse_position): Don't assume time_t wraparound.
4636
08dc5ae6
PE
4637 Be more systematic about user-interface timestamps.
4638 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4639 and sometimes 'EMACS_UINT', to represent these timestamps.
4640 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4641 This makes the code easier to follow, and makes it easier to catch
4642 integer overflow bugs such as Bug#8664.
4643 * frame.c (Fmouse_position, Fmouse_pixel_position):
4644 Use Time, not unsigned long, for user-interface timestamps.
4645 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4646 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4647 * keyboard.h (last_event_timestamp): Likewise.
4648 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4649 * menu.h (xmenu_show): Likewise.
4650 * term.c (term_mouse_position): Likewise.
4651 * termhooks.h (struct input_event.timestamp): Likewise.
4652 (struct terminal.mouse_position_hook): Likewise.
4653 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4654 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4655 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4656 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4657 what it was before.
4658 * menu.h, termhooks.h: Include "systime.h", for Time.
4659
8e55734a
PE
4660 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4661 Don't assume that the difference between two unsigned long values
4662 can fit into an integer. At this point, we know button_down_time
4663 <= event->timestamp, so the difference must be nonnegative, so
4664 there's no need to cast the result if double-click-time is
4665 nonnegative, as it should be; check that it's nonnegative, just in
4666 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4667 apart (about 25 days). (Bug#8664)
8e55734a 4668
841f1b75 4669 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4670 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4671
3e26f69c
PE
4672 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4673 that always fit in int. Use a sentinel instead of a counter, to
4674 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4675 * frame.h (struct frame): Use int for menu_bar_items_used
4676 instead of EMACS_INT, since it always fits in int.
3e26f69c 4677
5cc152c0
PE
4678 * menu.c (grow_menu_items): Check for int overflow.
4679
d89eb65e
PE
4680 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4681
5235bd3e
PE
4682 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4683 Before, the code was not consistent. These values cannot exceed
4684 2**31 - 1 so there's no need to make them unsigned.
4685 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4686 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4687 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4688 as modifiers.
4689 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4690
bc827e23
PE
4691 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4692 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4693 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4694 presumably because the widths might not match.
4695
78eb494e
PE
4696 * window.c (size_window): Avoid needless test at loop start.
4697
04f2d78b
CB
46982011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4699
4700 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4701
d2fc7e3d 47022011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4703
4704 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4705
d2fc7e3d 47062011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4707
4708 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4709 `width' to `bar_area_x' and `bar_area_width', respectively.
4710 (x_scroll_run): Take account of fringe background extension.
4711
04f2d78b
CB
4712 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4713 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4714 `bar_area_width', respectively.
4715 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4716 background extension.
4717
79b70037
GM
47182011-05-10 Jim Meyering <meyering@redhat.com>
4719
4720 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4721
2f142cc5
JB
47222011-05-10 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * image.c (Finit_image_library): Return t for built-in image types,
4725 like pbm and xbm. (Bug#8640)
4726
57679c86
AS
47272011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4728
4729 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4730
888c9e86
EZ
47312011-05-07 Eli Zaretskii <eliz@gnu.org>
4732
b0512a1d
EZ
4733 * w32console.c (Fset_screen_color): Doc fix.
4734 (Fget_screen_color): New function.
4735 (syms_of_ntterm): Defsubr it.
4736
7285dc67
EZ
4737 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4738 unlink the temporary file if Fcall_process didn't create it in the
4739 first place.
4740 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4741 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4742 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4743 cue to call_process_cleanup not to close that handle.
4744
4d3fcc8e
BK
47452011-05-07 Ben Key <bkey76@gmail.com>
4746
4747 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4748 one of two shell specific rules, either bootstrap-temacs-CMD or
4749 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4750 to the previous implementation of the bootstrap-temacs rule.
4751 The bootstrap-temacs-CMD rule is similar to the previous
4752 implementation of the bootstrap-temacs rule except that it
4753 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4754 variable.
4755
4756 These changes, along with some changes to nt/configure.bat,
4757 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4758 earlier fix to add support for --cflags and --ldflags options
4759 that include quotes so that it works whether make uses cmd or
4760 sh as the shell.
4761
b4289b64
MA
47622011-05-06 Michael Albinus <michael.albinus@gmx.de>
4763
4764 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4765 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4766 is a constant.
4767 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4768 a string. Handle both cases.
4769 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4770 (Fdbus_register_method): Use Qinvalid_function.
4771
af4c0e28
JB
47722011-05-06 Juanma Barranquero <lekktu@gmail.com>
4773
4774 * makefile.w32-in: Update dependencies.
4775 (LISP_H): Add inttypes.h and stdin.h.
4776 (PROCESS_H): Add unistd.h.
4777
c51453d9
EZ
47782011-05-06 Eli Zaretskii <eliz@gnu.org>
4779
4780 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4781 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4782
8ff0ac3c 47832011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4784
4c4b566b
PE
4785 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4786
aab2b9b5
PE
4787 * term.c (vfatal): Remove stray call to va_end.
4788 It's not needed and the C Standard doesn't allow it here anyway.
4789
c378da0b
PE
4790 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4791 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4792
288b08c7
PE
4793 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4794 bytes.
4795
e3601888
PE
4796 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4797
db6c0e74
PE
4798 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4799
dd5963ea
PE
4800 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4801
88c9450f
PE
4802 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4803
2f9442b8
PE
4804 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4805
c032b5f8
PE
4806 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4807 * charset.c (Fdefine_charset_internal): Don't initialize
4808 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4809 32-bit int (Bug#8600).
a108c10b
PE
4810
4811 * lread.c (read_integer): Be more consistent with string-to-number.
4812 Use string_to_number to do the actual conversion; this avoids
4813 rounding errors and fixes some other screwups. Without this fix,
4814 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4815 (digit_to_number): Move earlier, for benefit of read_integer.
4816 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4817 not a digit in any supported base. (Bug#8602)
a108c10b 4818
ad5f9eea
PE
4819 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4820
aec1708a
PE
4821 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4822 to match comment at start of function. This also removes a
4823 GCC warning about overflow in a 32+64-bit port.
4824
47be4ab5
PE
4825 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4826
371cac43
PE
4827 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4828 Reported by Stefan Monnier in
4829 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4830 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4831 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4832
d01a7826
PE
4833 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4834 (EMACS_UINTPTR): Likewise, with uintptr_t.
4835
7fd47d5c
PE
4836 * lisp.h: Prefer 64-bit EMACS_INT if available.
4837 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4838 on 32-bit hosts that have 64-bit int, so that they can access
4839 large files.
122b0c86
PE
4840 However, temporarily disable this change unless the temporary
4841 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4842
8727937b
PE
4843 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4844
8ac068ac
PE
4845 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4846 This removes an assumption that EMACS_INT and long are the same
4847 width as pointers. The assumption is true for Emacs porting targets
4848 now, but we want to make other targets possible.
4849 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4850 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4851 In the rest of the code, change types of integers that hold casted
4852 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4853 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4854 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4855 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4856 No need to cast type when ORing.
4857 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4858 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4859 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4860 assume EMACS_INT is the same width as char *.
4861 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4862 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4863 Remove no-longer-needed casts.
4864 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4865 (xg_tool_bar_help_callback, xg_make_tool_item):
4866 Use EMACS_INTPTR to hold an integer
4867 that will be cast to void *; this can avoid a GCC warning
4868 if EMACS_INT is not the same width as void *.
4869 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4870 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4871 (current_message_1, set_message_1):
4872 Use a local to convert to proper width without a cast.
4873 * xmenu.c (dialog_selection_callback): Likewise.
4874
ede49d71
PE
4875 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4876 Also, don't assume VALBITS / RAND_BITS is less than 5,
4877 and don't rely on undefined behavior when shifting a 1 left into
4878 the sign bit.
4879 * lisp.h (get_random): Change signature to match.
4880
2f30ecd0
PE
4881 * lread.c (hash_string): Use size_t, not int, for hash computation.
4882 Normally we prefer signed values; but hashing is special, because
4883 it's better to use unsigned division on hash table sizes so that
4884 the remainder is nonnegative. Also, size_t is the natural width
4885 for hashing into memory. The previous code used 'int', which doesn't
4886 retain enough info to hash well into very large tables.
4887 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4888
2a866e7b
PE
4889 * dbusbind.c: Don't possibly lose pointer info when converting.
4890 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4891 Use XPNTR rather than XHASH, so that the high-order bits of
4892 the pointer aren't lost when converting through void *.
4893
51639eac
PE
4894 * eval.c (Fautoload): Don't double-shift a pointer.
4895
92394119
PE
4896 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4897
dbdb9a7c
JB
48982011-05-06 Juanma Barranquero <lekktu@gmail.com>
4899
4900 * gnutls.c (DEF_GNUTLS_FN):
4901 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4902
db7a0b4f
AS
49032011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4904
4905 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4906 marker. (Bug#8610)
4907
f7ff1b0f 49082011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4909
4910 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4911 New version that can reserve upto 2GB of heap space.
4912
f7ff1b0f 49132011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4914
4915 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4916
639c109b
TZ
49172011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4918
4919 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4920 `gnutls_certificate_set_x509_key_file'.
4921
d2127135
JB
49222011-05-05 Juanma Barranquero <lekktu@gmail.com>
4923
4924 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4925 Update dependencies.
4926
e968f4f3
JB
49272011-05-04 Juanma Barranquero <lekktu@gmail.com>
4928
4929 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4930 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4931 Remove unused parameter `fildes'.
4932 * process.c (read_process_output, send_process): Don't pass it.
4933
84d358f0
JB
49342011-05-04 Juanma Barranquero <lekktu@gmail.com>
4935
4936 Fix previous change: the library cache is defined in w32.c.
4937 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4938 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4939
0898ca10
JB
49402011-05-04 Juanma Barranquero <lekktu@gmail.com>
4941
4942 Implement dynamic loading of GnuTLS on Windows.
4943
4944 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4945 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4946 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4947 Declare.
4948
4949 * gnutls.c (Qgnutls_dll): Define.
4950 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4951 (gnutls_*): Declare function pointers.
4952 (init_gnutls_functions): New function to initialize function pointers.
4953 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4954 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4955 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4956 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4957 (emacs_gnutls_write, emacs_gnutls_read)
4958 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4959 (Fgnutls_available_p): New function.
4960 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4961 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4962 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4963
4964 * image.c: Include w32.h.
4965 (Vimage_type_cache): Delete.
4966 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4967 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4968 (w32_delayed_load): Move to w32.c.
4969
4970 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4971
4972 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4973 (w32_delayed_load): Move from image.c. When loading a library, record
4974 its filename in the :loaded-from property of the library id.
4975 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4976 Initialize and staticpro them.
4977 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4978
4979 * process.c: Include lisp.h before w32.h, not after.
4980 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4981 instead of gnutls_record_check_pending.
4982
4983 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4984
ff4de4aa
TZ
49852011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4986
4987 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4988 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4989 as passed in.
4990
abe95abb
JD
49912011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4992
4993 * xterm.c (x_set_frame_alpha): Do not set property on anything
4994 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4995
e16e55d4
JB
49962011-05-02 Juanma Barranquero <lekktu@gmail.com>
4997
4998 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4999
bafcf6a5
JB
50002011-05-02 Juanma Barranquero <lekktu@gmail.com>
5001
5002 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5003 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5004 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5005 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5006 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5007 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5008 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5009 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5010 (Qgnutls_bootprop_callbacks_verify): Make static.
5011
e7a6747f
AS
50122011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5013
19ed11ba
AS
5014 * callproc.c: Indentation fixup.
5015
e7a6747f 5016 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5017 (wait_for_termination, interruptible_wait_for_termination):
5018 Move after wait_for_termination_1.
e7a6747f 5019
1ef14cb4
LMI
50202011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5021
5022 * sysdep.c (interruptible_wait_for_termination): New function
5023 which is like wait_for_termination, but allows keyboard
5024 interruptions.
5025
5026 * callproc.c (Fcall_process): Add (:file "file") as an option for
5027 the STDOUT buffer.
5028 (Fcall_process_region): Ditto.
5029
330d880c
EZ
50302011-04-30 Eli Zaretskii <eliz@gnu.org>
5031
8db90b73
EZ
5032 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5033 rather than `XVECTOR (FOO)->size'.
5034
330d880c
EZ
5035 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5036 inttypes.h, as a gnulib replacement is used if it not available in
5037 system headers.
5038
15cbd324
EZ
50392011-04-21 Eli Zaretskii <eliz@gnu.org>
5040
5041 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5042 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5043 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5044
5045 * coding.c (coding_alloc_by_realloc): Error out if destination
5046 will grow beyond MOST_POSITIVE_FIXNUM.
5047 (decode_coding_emacs_mule): Abort if there isn't enough place in
5048 charbuf for the composition carryover bytes. Reserve an extra
5049 space for up to 2 characters produced in a loop.
5050 (decode_coding_iso_2022): Abort if there isn't enough place in
5051 charbuf for the composition carryover bytes.
5052
50532011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5054
ae940cca
EZ
5055 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5056 aborting when %lld or %lll format is passed.
5057 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5058 %llo or %llx format is passed. (Bug#8545)
5059
03ab8921
EZ
5060 * window.c (window_scroll_line_based): Use a marker instead of
5061 simple variables to record original value of point. (Bug#7952)
5062
afda1437
EZ
5063 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5064 produced by %s or %c overflows available buffer space. (Bug#8545)
5065
f76dee0c
PE
50662011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5067
5068 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5069 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5070
fdc5744d
JB
50712011-04-28 Juanma Barranquero <lekktu@gmail.com>
5072
5073 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5074
638f053a
JB
50752011-04-28 Juanma Barranquero <lekktu@gmail.com>
5076
5077 * keyboard.c (Qdelayed_warnings_hook): Define.
5078 (command_loop_1): Run `delayed-warnings-hook'
5079 if Vdelayed_warnings_list is non-nil.
5080 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5081 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5082
d178f871
EZ
50832011-04-28 Eli Zaretskii <eliz@gnu.org>
5084
5085 * doprnt.c (doprnt): Don't return value smaller than the buffer
5086 size if the message was truncated. (Bug#8545).
5087
b124fd93
JB
50882011-04-28 Juanma Barranquero <lekktu@gmail.com>
5089
5090 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5091 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5092
e810457d
PE
50932011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5094
5095 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5096
ea51cceb
JB
50972011-04-27 Juanma Barranquero <lekktu@gmail.com>
5098
5099 * makefile.w32-in: Update dependencies.
5100
94dcfacf
EZ
51012011-04-27 Eli Zaretskii <eliz@gnu.org>
5102
5103 Improve `doprnt' and its usage. (Bug#8545)
5104 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5105 `format_end'. Remove support for %l as a conversion specifier.
5106 Don't use xrealloc. Improve diagnostics when the %l size modifier
5107 is used. Update the commentary.
5108
5109 * eval.c (verror): Simplify calculation of size_t.
5110
5111 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5112 messages.
5113
f61f41d7
PE
51142011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5115
5116 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5117 change.
5118
96fb4434
PE
51192011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5120
5121 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5122 This makes this file independent of the recent pseudovector change.
5123
671875da 51242011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5125
69e9b5a3
PE
5126 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5127
b5f869a7 5128 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5129 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5130 Remove unused local.
c8926152 5131 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5132
841a1577 5133 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5134 GCC 4.6.0 optimizes based on type-based alias analysis.
5135 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5136 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5137 != &v->size, and therefore "v->size = 1; b->size = 2; return
5138 v->size;" must therefore return 1. This assumption is incorrect
5139 for Emacs, since it type-puns struct Lisp_Vector * with many other
5140 types. To fix this problem, this patch adds a new type struct
f904488f 5141 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5142 and pseudovectors, and helps optimizing compilers not get fooled
5143 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5144 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5145 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5146 the size member.
eab3844f
PE
5147 (XSETPVECTYPE): Rewrite in terms of new macro.
5148 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5149 This is a bit clearer, and further avoids the possibility of
5150 undesirable aliasing.
5151 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5152 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5153 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5154 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5155 (ASIZE): Now uses header.size rather than size.
5156 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5157 to avoid the hassle of writing XVECTOR (foo)->header.size.
5158 (struct vectorlike_header): New type.
eab3844f
PE
5159 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5160 object, to help avoid aliasing.
5161 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5162 (SUBRP): Likewise, since Lisp_Subr is a special case.
5163 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5164 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5165 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5166 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5167 changed to be "header.size" and "header.next".
5168 * buffer.h (struct buffer): Likewise.
5169 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5170 * frame.h (struct frame): Likewise.
5171 * process.h (struct Lisp_Process): Likewise.
5172 * termhooks.h (struct terminal): Likewise.
5173 * window.c (struct save_window_data, struct saved_window): Likewise.
5174 * window.h (struct window): Likewise.
5175 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5176 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5177 * buffer.c (init_buffer_once): Likewise.
5178 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5179 special case.
5180 * process.c (Fformat_network_address): Use local var for size,
5181 for brevity.
5182
0df1eac5
PE
5183 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5184
847ab9d1 5185 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5186 * data.c (atof): Remove decl; no longer used or needed.
5187 (digit_to_number): Move to lread.c.
5188 (Fstring_to_number): Use new string_to_number function, to be
5189 consistent with how the Lisp reader treats infinities and NaNs.
5190 Do not assume that floating-point numbers represent EMACS_INT
5191 without losing information; this is not true on most 64-bit hosts.
5192 Avoid double-rounding errors, by insisting on integers when
5193 parsing non-base-10 numbers, as the documentation specifies.
5194 * lisp.h (string_to_number): New decl, replacing ...
5195 (isfloat_string): Remove.
bc0a5c13 5196 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5197 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5198 appears to have been a coding error. Similarly, do not accept
5199 strings like +-1e0 as floating point numbers. Do not report
5200 overflow for integer overflows unless the base is not 10 which
5201 means we have no simple and reliable way to continue.
5202 Break out the floating-point parsing into a new
5203 function string_to_number, so that Fstring_to_number parses
5204 floating point numbers consistently with the Lisp reader.
04f2d78b 5205 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5206 (E_CHAR, EXP_INT): Remove, replacing with ...
5207 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5208 (string_to_number): New function, replacing isfloat_string.
5209 This function checks for valid syntax and produces the resulting
5210 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5211 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5212 so that overflow for non-base-10 numbers is reported only when
5213 there's no portable and simple way to convert to floating point.
452f4150 5214
67769ffc
PE
5215 * textprop.c (set_text_properties_1): Rewrite for clarity,
5216 and to avoid GCC warning about integer overflow.
5217
c20db43f
PE
5218 * intervals.h (struct interval): Use EMACS_INT for members
5219 where EMACS_UINT might cause problems. See
5220 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5221 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5222 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5223 All uses changed.
37aa2f85
PE
5224 (offset_intervals): Tell GCC not to worry about length overflow
5225 when negating a negative length.
c20db43f 5226
2538aa2f
PE
5227 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5228 (overrun_check_free): Likewise.
5229
f2d3008d
PE
5230 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5231 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5232 word size.
5233
ec8df744
PE
5234 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5235 (gnutls_make_error): Rename local to avoid shadowing.
5236 (gnutls_emacs_global_deinit): ifdef out; not used.
5237 (Fgnutls_boot): Use const for pointer to readonly storage.
5238 Comment out unused local. Fix pointer signedness problems.
5239
640ee02d
PE
5240 * lread.c (openp): Don't stuff size_t into an 'int'.
5241 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5242 about possible signed overflow.
5243
6048fb2a
PE
5244 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5245 (GDK_KEY_g): Don't define if already defined.
5246 (xg_prepare_tooltip): Avoid pointer signedness problem.
5247 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5248
fa3c87e1
PE
5249 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5250 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5251
2172544b
PE
5252 * xfns.c (Fx_window_property): Simplify a bit,
5253 to make a bit faster and to avoid GCC 4.6.0 warning.
5254 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5255
9b821a21
PE
5256 * fns.c (internal_equal): Don't assume size_t fits in int.
5257
3c616cfa
PE
5258 * alloc.c (compact_small_strings): Tighten assertion a little.
5259
c2982e87
PE
5260 Replace pEd with more-general pI, and fix some printf arg casts.
5261 * lisp.h (pI): New macro, generalizing old pEd macro to other
5262 conversion specifiers. For example, use "...%"pI"d..." rather
5263 than "...%"pEd"...".
5264 (pEd): Remove. All uses replaced with similar uses of pI.
5265 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5266 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5267 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5268 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5269 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5270 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5271 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5272 64-bit hosts.
5273 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5274 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5275 * print.c (safe_debug_print, print_object): Likewise.
5276 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5277 to int.
6f04d126
PE
5278 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5279 avoiding the 0 flag, which is not portable.
c2982e87
PE
5280 * process.c (Fmake_network_process): Use pI to avoid cast.
5281 * region-cache.c (pp_cache): Likewise.
5282 * xdisp.c (decode_mode_spec): Likewise.
5283 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5284 behavior on 64-bit hosts with printf arg.
6f04d126 5285 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5286 (x_stop_queuing_selection_requests): Likewise.
5287 (x_get_window_property): Don't truncate byte count to an 'int'
5288 when tracing.
0b432f21 5289
5e073ec7
PE
5290 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5291 here, since it parses constructs like leading '-' and spaces,
5292 which are not wanted; and it overflows with large numbers.
5293 Instead, simply match F[0-9]+, which is what is wanted anyway.
5294
36372bf9
PE
5295 * alloc.c: Remove unportable assumptions about struct layout.
5296 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5297 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5298 (allocate_vectorlike, make_pure_vector): Use the new macros,
5299 plus offsetof, to remove unportable assumptions about struct layout.
5300 These assumptions hold on all porting targets that I know of, but
5301 they are not guaranteed, they're easy to remove, and removing them
5302 makes further changes easier.
5303
0b432f21
PE
5304 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5305 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5306 (string_overrun_cookie): Now const. Use initializers that
5307 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5308 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5309 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5310 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5311 multiple of sizeof (EMACS_INT); it need not be, if
5312 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5313 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5314
895009e1
JB
53152011-04-26 Juanma Barranquero <lekktu@gmail.com>
5316
5317 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5318
6a7a1b0b
TZ
53192011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5320
5321 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5322 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5323 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5324
841a1577 53252011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5326
5327 * lisp.h (Qdebug): List symbol.
895009e1 5328 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5329 * keyboard.c (debug-on-event): New variable.
5330 (handle_user_signal): Break into debugger when debug-on-event
5331 matches the current signal symbol.
5332
f2d3ba6f
DN
53332011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5334
5335 * alloc.c (check_sblock, check_string_bytes)
5336 (check_string_free_list): Convert to standard C.
5337
42ce4c63
TZ
53382011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5339
5340 * w32.c (emacs_gnutls_push): Fix typo.
5341
825cd63c
EZ
53422011-04-25 Eli Zaretskii <eliz@gnu.org>
5343
fb11d64d
EZ
5344 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5345 "cast to pointer from integer of different size".
5346
825cd63c
EZ
5347 Improve doprnt and its use in verror. (Bug#8545)
5348 * doprnt.c (doprnt): Document the set of format control sequences
5349 supported by the function. Use SAFE_ALLOCA instead of always
5350 using `alloca'.
5351
5352 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5353 is one byte too soon. Don't use xrealloc; instead xfree and
5354 xmalloc anew.
5355
e061a11b
TZ
53562011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5357
5358 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5359 callbacks stage.
5360
5361 * gnutls.c: Renamed global_initialized to
5362 gnutls_global_initialized. Added internals for the
5363 :verify-hostname-error, :verify-error, and :verify-flags
5364 parameters of `gnutls-boot' and documented those parameters in the
5365 docstring. Start callback support.
9173deec
JB
5366 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5367 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5368 on error. Return error code.
e061a11b
TZ
5369 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5370 (emacs_gnutls_read): Likewise.
5371 (Fgnutls_boot): Return handshake error code.
5372 (emacs_gnutls_handle_error): New function.
5373 (wsaerror_to_errno): Likewise.
5374
5375 * w32.h (emacs_gnutls_pull): Add prototype.
5376 (emacs_gnutls_push): Likewise.
5377
5378 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5379 (emacs_gnutls_push): Likewise.
5380
53812011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5382
5383 * process.c (wait_reading_process_output): Check if GnuTLS
5384 buffered some data internally if no FDs are set for TLS
5385 connections.
5386
5387 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5388 (LIBS): Link to USER_LIBS.
5389 ($(BLD)/gnutls.$(0)): New target.
5390
fa6996bc
EZ
53912011-04-24 Eli Zaretskii <eliz@gnu.org>
5392
eb35682e
EZ
5393 * xdisp.c (handle_single_display_spec): Rename the
5394 display_replaced_before_p argument into display_replaced_p, to
5395 make it consistent with the commentary. Fix typos in the
5396 commentary.
5397
e2ad650c
EZ
5398 * textprop.c (syms_of_textprop): Remove dead code.
5399 (copy_text_properties): Delete obsolete commentary about an
5400 interface that was deleted long ago. Fix typos in the description
5401 of arguments.
5402
1b2de274
EZ
5403 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5404 to changes in oldXMenu/XMenu.h from 2011-04-16.
5405 <menu_help_message, prev_menu_help_message>: Constify.
5406 (IT_menu_make_room): menu->help_text is now `const char **';
5407 adjust.
5408
5409 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5410 to changes in oldXMenu/XMenu.h from 2011-04-16.
5411 (struct XMenu): Declare `help_text' `const char **'.
5412
5413 * xfaces.c <Qunspecified>: Make extern again.
5414
5415 * syntax.c: Include sys/types.h before including regex.h, as
5416 required by Posix.
5417
762b15be
EZ
5418 * doc.c (get_doc_string): Improve the format passed to `error'.
5419
5420 * doprnt.c (doprnt): Improve commentary.
5421
5422 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5423
5424 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5425 them with etags.
5426
f1052e5d
EZ
5427 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5428 changes in globals.h immediately force recompilation.
762b15be
EZ
5429 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5430 $(CURDIR)/s/ms-w32.h.
5431 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5432
fa6996bc
EZ
5433 * character.c (Fchar_direction): Function deleted.
5434 (syms_of_character): Don't defsubr it.
5435 <char-direction-table>: Deleted.
5436
e6c3da20
EZ
54372011-04-23 Eli Zaretskii <eliz@gnu.org>
5438
5439 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5440 * doprnt.c: Include limits.h.
5441 (SIZE_MAX): New macro.
04f2d78b
CB
5442 (doprnt): Return a size_t value. 2nd arg is now size_t.
5443 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5444 Improve overflow protection. Support `l' modifier for integer
5445 conversions. Support %l conversion. Don't assume an EMACS_INT
5446 argument for integer conversions and for %c.
5447
5448 * lisp.h (doprnt): Restore prototype.
5449
5450 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5451 $(SRC)/character.h.
5452
5453 * Makefile.in (base_obj): Add back doprnt.o.
5454
5455 * deps.mk (doprnt.o): Add back prerequisites.
5456 (callint.o): Depend on character.h.
5457
5458 * eval.c (internal_lisp_condition_case): Include the handler
5459 representation in the error message.
5460 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5461 when breaking from the loop.
5462
5463 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5464
5465 * callint.c (Fcall_interactively): When displaying error message
5466 about invalid control letter, pass the character's codepoint, not
5467 a pointer to its multibyte form. Improve display of the character
5468 in octal and display also its hex code.
5469
5470 * character.c (char_string): Use %x to display the (unsigned)
5471 codepoint of an invalid character, to avoid displaying a bogus
5472 negative value.
5473
5474 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5475 `error', not SYMBOL_NAME itself.
5476
5477 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5478 character arguments to `error'.
5479
5480 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5481 to `error' in error message about FINAL_CHAR argument. Make sure
5482 FINAL_CHAR is a character, and use %c when it is passed as
5483 argument to `error'.
5484
4ffd0d6b 54852011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5486
5487 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5488
5489 * w32.c: Include <time.h>.
5490 (sys_localtime): New function.
5491
4ffd0d6b 54922011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5493
5494 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5495
4ffd0d6b 5496 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5497
4ffd0d6b 54982011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5499
4ffd0d6b
GM
5500 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5501 zombies (Bug#8467).
aac0c6e3 5502
04c56954
EZ
55032011-04-19 Eli Zaretskii <eliz@gnu.org>
5504
5505 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5506 gl_state.e_property when gl_state.object is Qt.
5507
5508 * insdel.c (make_gap_larger): Remove limitation of buffer size
5509 to <= INT_MAX.
5510
16a43933
CY
55112011-04-18 Chong Yidong <cyd@stupidchicken.com>
5512
5513 * xdisp.c (lookup_glyphless_char_display)
5514 (produce_glyphless_glyph): Handle cons cell entry in
5515 glyphless-char-display.
5516 (Vglyphless_char_display): Document it.
5517
5518 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5519 glyphless-char-display.
5520
4581706e
CY
55212011-04-17 Chong Yidong <cyd@stupidchicken.com>
5522
5523 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5524
5525 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5526
5527 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5528 definition for no-X builds.
5529
4887c6e2 55302011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5531
fd35b6f9
PE
5532 Static checks with GCC 4.6.0 and non-default toolkits.
5533
5c1ccb01
PE
5534 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5535
006c5daa
PE
5536 * process.c (keyboard_bit_set): Define only if SIGIO.
5537 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5538 (send_process): Repair possible setjmp clobbering.
5539
efc736d3
PE
5540 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5541
4e2fe2e6
PE
5542 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5543
f97334a2
PE
5544 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5545
4e75f29d
PE
5546 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5547 Define only if needed.
5548
90efadd1
PE
5549 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5550 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5551 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5552
3c647824
PE
5553 * dispextern.h (struct redisplay_interface): Rename param
5554 to avoid shadowing.
e264f262 5555 * termhooks.h (struct terminal): Likewise.
761383f4 5556 * xterm.c (xembed_send_message): Likewise.
3c647824 5557
b58c5c4a
PE
5558 * insdel.c (make_gap_smaller): Define only if
5559 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5560
cad59032
PE
5561 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5562 it.
5563
c339dc2e
PE
5564 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5565 so that we aren't warned about unused symbols.
5566
91a3e27b
PE
5567 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5568
399c71d3 5569 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5570
8ffc96f5
PE
5571 * xfns.c (x_real_positions): Mark locals as initialized.
5572
eef9bc79
PE
5573 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5574
098db9dd
PE
5575 * xterm.c: Fix problems found by static analysis with other toolkits.
5576 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5577 (x_dispatch_event): Declare static if USE_GTK, and
5578 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5579 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5580 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5581 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5582 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5583
eb18f6cc
PE
5584 * xmenu.c (menu_help_callback): Pointer type fixes.
5585 Use const pointers when pointing at readonly data. Avoid pointer
5586 signedness clashes.
5587 (FALSE): Remove unused macro.
5588 (update_frame_menubar): Remove unused decl.
5589
1fe72bf8
PE
5590 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5591
60d9e1db
PE
5592 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5593 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5594 (single_menu_item): Rename local to avoid shadowing.
5595
39261c26
PE
5596 * keyboard.c (make_lispy_event): Remove unused local var.
5597
018c5e19
PE
5598 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5599 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5600
63d2b86e
PE
5601 * bitmaps: Change bitmaps from unsigned char back to the X11
5602 compatible char. Avoid the old compiler warnings about
5603 out-of-range initializers by using, for example, '\xab' rather
5604 than 0xab.
5605
aefd87e1
PE
5606 * xgselect.c (xgselect_initialize): Check vs interface
5607 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5608
bf501fb9
PE
5609 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5610
e9829fdf
PE
5611 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5612 to read-only memory.
5613
1086c095
PE
5614 * fns.c (vector): Remove; this old hack is no longer needed.
5615
2baccd04 5616 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5617 Remove unused var.
dde42981 5618 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5619
72391843 5620 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5621
436c16df 5622 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5623 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5624 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5625
92bb796d 5626 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5627 (x_term_init): Remove local to avoid shadowing.
92bb796d 5628
764430a3 5629 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5630
5631 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5632 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5633
d1dfb56c
EZ
56342011-04-16 Eli Zaretskii <eliz@gnu.org>
5635
c4354cb4
EZ
5636 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5637
d1dfb56c
EZ
5638 Fix regex.c, syntax.c and friends for buffers > 2GB.
5639 * syntax.h (struct gl_state_s): Declare character position members
5640 EMACS_INT.
5641
5642 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5643
04f2d78b
CB
5644 * textprop.c (verify_interval_modification, interval_of):
5645 Declare arguments EMACS_INT.
d1dfb56c
EZ
5646
5647 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5648 EMACS_INT.
5649
5650 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5651
5652 * indent.c (Fvertical_motion): Local variable it_start is now
5653 EMACS_INT.
5654
5655 * regex.c (re_match, re_match_2, re_match_2_internal)
5656 (bcmp_translate, regcomp, regexec, print_double_string)
5657 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5658 (re_compile_pattern, re_exec): Declare arguments and local
5659 variables `size_t' and `ssize_t' and return values `regoff_t', as
5660 appropriate.
5661 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5662 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5663 <compile_stack_type>: `size' and `avail' are now `size_t'.
5664
5665 * regex.h <regoff_t>: Use ssize_t, not int.
5666 (re_search, re_search_2, re_match, re_match_2): Arguments that
5667 specify buffer/string position and length are now ssize_t and
5668 size_t. Return type is regoff_t.
5669
613052cd
BK
56702011-04-16 Ben Key <bkey76@gmail.com>
5671
5672 * nsfont.m: Fixed bugs in ns_get_family and
5673 ns_descriptor_to_entity that were caused by using free to
5674 deallocate memory blocks that were allocated by xmalloc (via
5675 xstrdup). This caused Emacs to crash when compiled with
5676 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5677 --enable-checking=xmallocoverrun). xfree is now used to
5678 deallocate these memory blocks.
5679
4170f62f 56802011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5681
71b41406
PE
5682 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5683
9587a89d
PE
5684 emacs_write: Accept and return EMACS_INT for sizes.
5685 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5686 et seq.
5687 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5688 Accept and return EMACS_INT.
5689 (emacs_gnutls_write): Return the number of bytes written on
5690 partial writes.
5691 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5692 (emacs_read, emacs_write): Remove check for negative size, as the
5693 Emacs source code has been audited now.
9587a89d
PE
5694 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5695 (emacs_read, emacs_write): Use it.
273a5f82
PE
5696 * process.c (send_process): Adjust to the new signatures of
5697 emacs_write and emacs_gnutls_write. Do not attempt to store
5698 a byte offset into an 'int'; it might overflow.
9587a89d 5699 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5700
3e047f51
PE
5701 * sound.c: Don't assume sizes fit in 'int'.
5702 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5703 Return EMACS_INT, not int.
3e047f51 5704 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5705 Accept EMACS_INT, not int.
5706 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5707 record read return values.
5708
cc39a9db
BK
57092011-04-15 Ben Key <bkey76@gmail.com>
5710
c9d0ec6d
JB
5711 * keyboard.c (Qundefined): Don't declare static since it is used
5712 in nsfns.m.
5713 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5714 static since they are used in nsfont.m.
cc39a9db 5715
6c60eb9f
SM
57162011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5717
5718 * process.c (Qprocessp): Don't declare static.
5719 * lisp.h (Qprocessp): Declare again.
5720
7990b61a
JB
57212011-04-15 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5724
5d4cb038
PE
57252011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5726
8bd7b830 5727 Improve C-level modularity by making more things 'static'.
cd64ea1d 5728
e3b27b31
PE
5729 Don't publish debugger-only interfaces to other modules.
5730 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5731 (verify_bytepos, count_markers): Move decls to the only modules
5732 that need them.
5733 * region-cache.h (pp_cache): Likewise.
5734 * window.h (check_all_windows): Likewise.
5735 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5736
5d4cb038
PE
5737 * sysdep.c (croak): Now static, if
5738 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5739 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5740
5741 * alloc.c (refill_memory_reserve): Now static if
5742 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5743 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5744
e87b6180
PE
5745 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5746 Define only if USE_LUCID.
5747
ac64929e
PE
5748 * xrdb.c (x_customization_string, x_rm_string): Now static.
5749
6f37259d
PE
5750 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5751 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5752
1683e3ab
PE
5753 * xdisp.c (draw_row_with_mouse_face): Now static.
5754 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5755
de9c2632
PE
5756 * window.h (check_all_windows): Mark externally visible.
5757
2b96acb7
PE
5758 * window.c (window_deletion_count): Now static.
5759
5760 * undo.c: Make symbols static if they're not exported.
5761 (last_undo_buffer, last_boundary_position, pending_boundary):
5762 Now static.
5763
50436f33
PE
5764 * textprop.c (interval_insert_behind_hooks): Now static.
5765 (interval_insert_in_front_hooks): Likewise.
5766
64520e5c
PE
5767 * term.c: Make symbols static if they're not exported.
5768 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5769 (max_frame_lines, tty_set_terminal_modes):
5770 (tty_reset_terminal_modes, tty_turn_off_highlight):
5771 (get_tty_terminal): Now static.
5772 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5773 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5774 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5775 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5776 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5777
1fa53021
PE
5778 * sysdep.c: Make symbols static if they're not exported.
5779 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5780 Now static.
5781 (sigprocmask_set, full_mask): Remove; unused.
5782 (wait_debugging): Mark as visible.
5783 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5784 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5785
d4b43b22
PE
5786 * syntax.c (syntax_temp): Define only if !__GNUC__.
5787
b7c513d0
PE
5788 * sound.c (current_sound_device, current_sound): Now static.
5789
989b29ad
PE
5790 * search.c (searchbufs, searchbuf_head): Now static.
5791
13a55a78
PE
5792 * scroll.c (scroll_cost): Remove; unused.
5793 * dispextern.h (scroll_cost): Remove decl.
5794
de68a1fc
PE
5795 * region-cache.h (pp_cache): Mark as externally visible.
5796
40ccffa6
PE
5797 * process.c: Make symbols static if they're not exported.
5798 (process_tick, update_tick, create_process, chan_process):
5799 (Vprocess_alist, proc_buffered_char, datagram_access):
5800 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5801 (deactivate_process): Mark defn as static, as well as decl.
5802 * lisp.h (create_process): Remove decl.
5803 * process.h (chan_process, Vprocess_alist): Remove decls.
5804
ad64fc97
PE
5805 * print.c: Make symbols static if they're not exported.
5806 (print_depth, new_backquote_output, being_printed, print_buffer):
5807 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5808 (print_interval, print_number_index, initial_stderr_stream):
5809 Now static.
5810 * lisp.h (Fprinc): Remove decl.
5811 (debug_output_compilation_hack): Mark as externally visible.
5812
adddb265
PE
5813 * sysdep.c (croak): Move decl from here to syssignal.h.
5814 * syssignal.h (croak): Put it here, so the API can be checked when
5815 'croak' is called from dissociate_if_controlling_tty.
5816
1717ede2
PE
5817 * minibuf.c: Make symbols static if they're not exported.
5818 (minibuf_save_list, choose_minibuf_frame): Now static.
5819 * lisp.h (choose_minibuf_frame): Remove decl.
5820
fa5fb2bc
PE
5821 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5822
1e3890d1
PE
5823 * lread.c: Make symbols static if they're not exported.
5824 (read_objects, initial_obarray, oblookup_last_bucket_number):
5825 Now static.
5826 (make_symbol): Remove; unused.
5827 * lisp.h (initial_obarray, make_symbol): Remove decls.
5828
8a1414fa
PE
5829 * keyboard.c: Make symbols static if they're not exported.
5830 (single_kboard, recent_keys_index, total_keys, recent_keys):
5831 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5832 (this_single_command_key_start, echoing, last_auto_save):
5833 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5834 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5835 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5836 (Vlispy_mouse_stem, double_click_count):
5837 Now static.
5838 (force_auto_save_soon): Define only if SIGDANGER.
5839 (ignore_mouse_drag_p): Now static if
5840 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5841 (print_help): Remove; unused.
5842 (stop_character, last_timer_event): Mark as externally visible.
5843 * keyboard.h (ignore_mouse_drag_p): Declare only if
5844 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5845 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5846 * lisp.h (echoing): Remove decl.
5847 (force_auto_save_soon): Declare only if SIGDANGER.
5848 * xdisp.c (redisplay_window): Simplify code, to make it more
5849 obvious that ignore_mouse_drag_p is not accessed if !defined
5850 USE_GTK && !defined HAVE_NS.
5851
93ea6e8f
PE
5852 * intervals.c: Make symbols static if they're not exported.
5853 (merge_properties_sticky, merge_interval_right, delete_interval):
5854 Now static.
5855 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5856
77382fcc
PE
5857 * insdel.c: Make symbols static if they're not exported.
5858 However, leave prepare_to_modify_buffer alone. It's never
5859 called from outside this function, but that appears to be a bug.
5860 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5861 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5862 (adjust_after_replace_noundo): Remove; unused.
5863 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5864 (signal_before_change): Remove decls.
77382fcc 5865
9306c32e
PE
5866 * indent.c (val_compute_motion, val_vmotion): Now static.
5867
cd44d2eb
PE
5868 * image.c: Make symbols static if they're not exported.
5869 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5870 if USE_GTK.
5871 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5872 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5873
ad9a7a06
PE
5874 * fringe.c (standard_bitmaps): Now static.
5875 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5876
81626931
PE
5877 * frame.c: Make symbols static if they're not exported.
5878 (x_report_frame_params, make_terminal_frame): Now static.
5879 (get_frame_param): Now static, unless HAVE_NS.
5880 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5881 (x_get_resource_string): Remove; not used.
5882 * frame.h (make_terminal_frame, x_report_frame_params):
5883 (x_get_resource_string); Remove decls.
5884 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5885 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5886
239f9db9
PE
5887 * font.c, fontset.c: Make symbols static if they're not exported.
5888 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5889 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5890 * font.c (font_close_object): Now static.
5891 * font.h (font_close_object): Remove.
5892 * fontset.c (FONTSET_OBJLIST): Remove.
5893 (free_realized_fontset) #if-0 the body, which does nothing.
5894 (face_suitable_for_char_p): #if-0, as it's never called.
5895 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5896 * xfaces.c (face_at_string_position):
5897 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5898 since 0 is always ASCII.
5899
dfcf3579
PE
5900 * fns.c (weak_hash_tables): Now static.
5901
5045092b
PE
5902 * fileio.c: Make symbols static if they're not exported.
5903 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5904 (Vwrite_region_annotation_buffers): Now static.
5905
57a96f5c
PE
5906 * eval.c: Make symbols static if they're not exported.
5907 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5908 * lisp.h (backtrace_list): Remove decl.
5909
35f08c38
PE
5910 * emacs.c: Make symbols static if they're not exported.
5911 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5912 (fatal_error_code, fatal_error_signal_hook, standard_args):
5913 Now static.
5914 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5915 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5916 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5917 * lisp.h (fatal_error_signal_hook): Remove decl.
5918 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5919
f44bd759
PE
5920 * editfns.c: Move a (normally-unused) function to its only use.
5921 * editfns.c, lisp.h (get_operating_system_release): Remove.
5922 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5923 worth the hassle of breaking this out.
5924
b532497d
PE
5925 * xterm.c: Make symbols static if they're not exported.
5926 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5927 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5928 (x_destroy_window, x_delete_display):
5929 Now static.
5930 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5931 (x_mouse_leave): Remove; unused.
5932 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5933 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5934 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5935 Remove decls.
5936 (x_mouse_leave): Declare only if WINDOWSNT.
5937 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5938 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5939 USE_X_TOOLKIT.
5940
1675728f
PE
5941 * ftxfont.c: Make symbols static if they're not exported.
5942 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5943 HAVE_FREETYPE.
5944 * font.h (ftxfont_driver): Likewise.
5945
e4cebfca
PE
5946 * xfns.c: Make symbols static if they're not exported.
5947 (x_last_font_name, x_display_info_for_name):
5948 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5949 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5950 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5951 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5952 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5953 (last_show_tip_args): Now static.
5954 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5955 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5956 (x_screen_planes): Remove; unused.
5957 * dispextern.h (x_screen_planes): Remove decl.
5958
5bf46f05
PE
5959 * dispnew.c: Make symbols static if they're not exported.
5960 * dispextern.h (redraw_garbaged_frames, scrolling):
5961 (increment_row_positions): Remove.
5962 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5963 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5964 Now static.
5965 (redraw_garbaged_frames): Remove; unused.
5966
435f4c28
PE
5967 * xfaces.c: Make symbols static if they're not exported.
5968 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5969 Remove decls.
5970 * xterm.h (defined_color): Remove decls.
5971 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5972 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5973 (menu_face_changed_default, defined_color, free_realized_face):
5974 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5975 (ascii_face_of_lisp_face): Remove; unused.
5976
8524aef3
PE
5977 * xdisp.c: Make symbols static if they're not exported.
5978 * dispextern.h (scratch_glyph_row, window_box_edges):
5979 (glyph_to_pixel_coords, set_cursor_from_row):
5980 (get_next_display_element, set_iterator_to_next):
5981 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5982 (show_mouse_face): Remove decls
5983 * frame.h (message_buf_print): Likewise.
5984 * lisp.h (pop_message, set_message, check_point_in_composition):
5985 Likewise.
5986 * xterm.h (set_vertical_scroll_bar): Likewise.
5987 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5988 (message_buf_print, scratch_glyph_row, displayed_buffer):
5989 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5990 (get_next_display_element, show_mouse_face, window_box_edges):
5991 (frame_to_window_pixel_xy, check_point_in_composition):
5992 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5993 (glyph_to_pixel_coords): Remove; unused.
5994
16390cd2
PE
5995 * dired.c (file_name_completion): Now static.
5996
5997 * dbusbind.c (xd_in_read_queued_messages): Now static.
5998
a25f4dfa
PE
5999 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6000 * data.c (circular_list_error): Remove.
6001
14a9c8df
PE
6002 * commands.h (last_point_position, last_point_position_buffer):
6003 (last_point_position_window): Remove decls.
6004 * keyboard.c: Make these variables static.
6005
04f2d78b
CB
6006 * coding.h (coding, code_convert_region, encode_coding_gap):
6007 Remove decls.
74ab6df5
PE
6008 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6009 (iso_code_class, detect_coding, code_convert_region): Now static.
6010 (encode_coding_gap): Remove; unused.
6011
38dfbee1
PE
6012 * chartab.c (chartab_chars, chartab_bits): Now static.
6013
a2cb4e63
PE
6014 * charset.h (charset_iso_8859_1): Remove decl.
6015 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6016 Now static.
6017
127198fd
PE
6018 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6019 * ccl.c (Vccl_program_table): Now static.
6020 (check_ccl_update): Remove; unused.
6021
d85b608f
PE
6022 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6023 * category.h: ... from here.
6024 * category.c (check_category_table, set_category_set): Now static.
6025
31cd66f3
PE
6026 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6027 * lisp.h: Remove these decls.
6028
c358e587
PE
6029 * buffer.c (buffer_count): Remove unused var.
6030
e78aecca
PE
6031 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6032 so that it's not optimized away.
6033 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6034 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6035 exported only to the debugger.
6036
e192d7d3 6037 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6038 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6039
92470028
PE
6040 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6041 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6042 was inaccessible from Lisp.
6043 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6044 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6045
244ed907
PE
6046 alloc.c: Import and export fewer symbols, and remove unused items.
6047 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6048 is defined.
6049 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6050 it's not optimized away by whole-program optimization.
6051 (message_enable_multibyte, free_misc): Remove.
6052 (catchlist, handlerlist, mark_backtrace):
6053 Declare only if BYTE_MARK_STACK.
6054 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6055 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6056 (message_enable_multibyte): Remove decl.
6057 (free_misc, interval_free_list, float_block, float_block_index):
6058 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6059 (cons_free_list, last_marked_index):
6060 Now static.
6061 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6062 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6063 (mark_backtrace): Define only if BYTE_MARK_STACK.
6064 * xdisp.c (message_enable_multibyte): Now static.
6065
61c2b50e 6066 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6067 This makes it easier for human readers (and static analyzers)
6068 to see whether these variables are used from other modules.
6069 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6070 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6071 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6072 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6073 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6074 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6075 * xmenu.c, xselect.c:
6076 Declare Q* vars static if they are not used in other modules.
6077 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6078 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6079 Remove decls of unexported vars.
6080 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6081
95c82688
PE
6082 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6083
16a97296
PE
6084 Make Emacs functions such as Fatom 'static' by default.
6085 This makes it easier for human readers (and static analyzers)
6086 to see whether these functions can be called from other modules.
6087 DEFUN now defines a static function. To make the function external
6088 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6089 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6090 (Finit_image_library):
16a97296
PE
6091 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6092 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6093 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6094 Remove decls, since these functions are now static.
6095 (Funintern, Fget_internal_run_time): New decls, since these functions
6096 were already external.
95c82688 6097
16a97296
PE
6098 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6099 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6100 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6101 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6102 * keyboard.c, keymap.c, lread.c:
6103 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6104 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6105 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6106 Mark functions with DEFUE instead of DEFUN,
6107 if they are used in other modules.
6108 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6109 decls for now-static functions.
6110 * buffer.h (Fdelete_overlay): Remove decl.
6111 * callproc.c (Fgetenv_internal): Mark as internal.
6112 * composite.c (Fremove_list_of_text_properties): Remove decl.
6113 (Fcomposition_get_gstring): New forward static decl.
6114 * composite.h (Fcomposite_get_gstring): Remove decl.
6115 * dired.c (Ffile_attributes): New forward static decl.
6116 * doc.c (Fdocumntation_property): New forward static decl.
6117 * eval.c (Ffetch_bytecode): New forward static decl.
6118 (Funintern): Remove extern decl; now in .h file where it belongs.
6119 * fileio.c (Fmake_symbolic_link): New forward static decl.
6120 * image.c (Finit_image_library): New forward static decl.
6121 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6122 * intervals.h (Fprevious_property_change):
6123 (Fremove_list_of_text_properties): Remove decls.
6124 * keyboard.c (Fthis_command_keys): Remove decl.
6125 (Fcommand_execute): New forward static decl.
6126 * keymap.c (Flookup_key): New forward static decl.
6127 (Fcopy_keymap): Now static.
6128 * keymap.h (Flookup_key): Remove decl.
6129 * process.c (Fget_process): New forward static decl.
6130 (Fprocess_datagram_address): Mark as internal.
6131 * syntax.c (Fsyntax_table_p): New forward static decl.
6132 (skip_chars): Remove duplicate decl.
6133 * textprop.c (Fprevious_property_change): New forward static decl.
6134 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6135 Now internal.
6136 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6137 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6138
785bbd42
PE
6139 * editfns.c (Fformat): Remove unreachable code.
6140
8b913b57
AS
61412011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6142
6143 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6144 change. (Bug#8496)
6145
a6744a35
EZ
61462011-04-13 Eli Zaretskii <eliz@gnu.org>
6147
6148 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6149 when at ZV. (Bug#8487)
6150
e7974947
AS
61512011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6152
baad03f0
AS
6153 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6154 (Bug#8437)
6155 * keyboard.c (parse_tool_bar_item): Likewise.
6156 * sound.c (sound_cleanup, alsa_close): Likewise.
6157 * termcap.c (tgetent): Likewise.
6158 * xfns.c (x_default_font_parameter): Likewise.
6159 * xsettings.c (read_and_apply_settings): Likewise.
6160
e7974947
AS
6161 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6162 (overrun_check_free): Protoize.
6163
28272684
PE
61642011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6165
6166 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6167 since callers should never pass a negative size.
6168 Change the signature to match that of plain 'read' and 'write'; see
6169 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6170 * lisp.h: Update prototypes of emacs_write and emacs_read.
6171
11997c76
EZ
61722011-04-11 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (redisplay_window): Don't try to determine the character
6175 position of the scroll margin if the window start point w->startp
e896f03c 6176 is outside the buffer's accessible region. (Bug#8468)
11997c76 6177
8a2cbd72
EZ
61782011-04-10 Eli Zaretskii <eliz@gnu.org>
6179
6180 Fix write-region and its subroutines for buffers > 2GB.
6181 * fileio.c (a_write, e_write): Modify declaration of arguments and
6182 local variables to support buffers larger than 2GB.
6183 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6184
6185 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6186 argument, local variables, and return value.
6187
6188 * lisp.h: Update prototypes of emacs_write and emacs_read.
6189
6190 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6191
4073e537 61922011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6193
1ebfdcb6
PE
6194 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6195
b2ded58d
PE
6196 Fix more problems found by GCC 4.6.0's static checks.
6197
7d66342c
PE
6198 * xdisp.c (vmessage): Use a better test for character truncation.
6199
bbf47d44
PE
6200 * charset.c (load_charset_map): <, not <=, for optimization,
6201 and to avoid potential problems with integer overflow.
9248994d 6202 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6203 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6204 * editfns.c (Fformat): Likewise.
1e69125e 6205 * syntax.c (skip_chars): Likewise.
3befa583 6206
e3019616
PE
6207 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6208 This also lets GCC 4.6.0 generate slightly better loop code.
6209
becfa255
PE
6210 * callint.c (Fcall_interactively): <, not <=, for optimization.
6211 (Fcall_interactively): Count the number of arguments produced,
6212 not the number of arguments given. This is simpler and lets GCC
6213 4.6.0 generate slightly better code.
6214
dae0cd48
PE
6215 * ftfont.c: Distingish more carefully between FcChar8 and char.
6216 The previous code passed unsigned char * to a functions like
6217 strlen and xstrcasecmp that expect char *, which does not
6218 conform to the C standard.
6219 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6220 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6221 char * when the C standard requires it.
6222
76032d70
PE
6223 * keyboard.c (read_char): Remove unused var.
6224
eb3f1cc8
PE
6225 * eval.c: Port to Windows vsnprintf (Bug#8435).
6226 Include <limits.h>.
6227 (SIZE_MAX): Define if the headers do not.
6228 (verror): Do not give up if vsnprintf returns a negative count.
6229 Instead, grow the buffer. This ports to Windows vsnprintf, which
6230 does not conform to C99. Problem reported by Eli Zaretskii.
6231 Also, simplify the allocation scheme, by avoiding the need for
6232 calling realloc, and removing the ALLOCATED variable.
6233
70476b54
PE
6234 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6235
12020a9e
PE
6236 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6237 But keep the doprint source code for now, as we might revamp it
6238 and use it again (Bug#8435).
ea6c7ae6
PE
6239 * lisp.h (doprnt): Remove.
6240 * Makefile.in (base_obj): Remove doprnt.o.
6241 * deps.mk (doprnt.o): Remove.
6242
5fdb398c
PE
6243 error: Print 32- and 64-bit integers portably (Bug#8435).
6244 Without this change, on typical 64-bit hosts error ("...%d...", N)
6245 was used to print both 32- and 64-bit integers N, which relied on
6246 undefined behavior.
6247 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6248 New macro.
6249 * lisp.h (error, verror): Mark as printf-like functions.
6250 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6251 Report overflow in size calculations when allocating printf buffer.
6252 Do not truncate output string at its first null byte.
6253 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6254 Truncate the output at a character boundary, since vsnprintf does not
6255 do that.
6256 * charset.c (check_iso_charset_parameter): Convert internal
6257 character to string before calling 'error', since %c now has the
6258 printf meaning.
6259 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6260 overflow when computing char to be passed to 'error'. Do not
6261 pass Lisp_Object to 'error'; pass the integer instead.
6262 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6263 formatted with plain %d.
6264
b189fa66
PE
6265 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6266
bff87ef0
PE
6267 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6268
7e2cac20
PE
6269 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6270
ce4d90b5
PE
6271 * xterm.c (x_catch_errors): Remove duplicate declaration.
6272
266c9547
PE
6273 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6274
79c49ad2
PE
6275 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6276
368f4090
JM
62772011-04-10 Jim Meyering <meyering@redhat.com>
6278
6279 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6280 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6281 return ssize_t not "int", and use size_t as the buffer length.
6282 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6283 * gnutls.h: Update declarations.
6284 * process.c (read_process_output): Use ssize_t, to match.
6285 (send_process): Likewise.
6286
a32d4040
CY
62872011-04-09 Chong Yidong <cyd@stupidchicken.com>
6288
6289 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6290
8546720e 62912011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6292
04f2d78b
CB
6293 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6294 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6295
8546720e
GM
6296 * xterm.c (handle_one_xevent):
6297 * xmenu.c (create_and_show_popup_menu):
6298 * xselect.c (x_decline_selection_request)
6299 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6300
0a2f5c1a 63012011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6302
6303 Fix some uses of `int' instead of EMACS_INT.
6304 * search.c (string_match_1, fast_string_match)
6305 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6306 (scan_buffer, find_next_newline_no_quit)
6307 (find_before_next_newline, search_command, Freplace_match)
6308 (Fmatch_data): Make some `int' variables be EMACS_INT.
6309
6310 * xdisp.c (display_count_lines): 3rd argument and return value now
6311 EMACS_INT. All callers changed.
6312 (pint2hrstr): Last argument is now EMACS_INT.
6313
6314 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6315 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6316 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6317 (decode_coding_utf_16, decode_coding_emacs_mule)
6318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6319 (decode_coding_ccl, decode_coding_charset)
6320 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6321 (decode_coding_iso_2022, decode_coding_emacs_mule)
6322 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6323 <char_offset, last_offset>: Declare EMACS_INT.
6324 (encode_coding_utf_8, encode_coding_utf_16)
6325 (encode_coding_emacs_mule, encode_invocation_designation)
6326 (encode_designation_at_bol, encode_coding_iso_2022)
6327 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6328 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6329 Declare EMACS_INT.
6330 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6331 (encode_invocation_designation): Last argument P_NCHARS is now
6332 EMACS_INT.
6333 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6334 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6335
6336 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6337 All users changed.
6338
6339 * ccl.c (Fccl_execute_on_string): Declare some variables
6340 EMACS_INT.
6341
8546720e 63422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6343
6344 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6345
4e19a977
CS
63462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6347
6348 * process.c (Fformat_network_address): Doc fix.
6349
87302331
R
63502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6351
6352 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6353
cbb59342
CY
63542011-04-08 Chong Yidong <cyd@stupidchicken.com>
6355
6356 * keyboard.c (read_char): Call Lisp function help-form-show,
6357 instead of using internal_with_output_to_temp_buffer.
6358 (Qhelp_form_show): New var.
e0d38eeb 6359 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6360
6361 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6362
6363 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6364
e67a13ab
CY
63652011-04-06 Chong Yidong <cyd@stupidchicken.com>
6366
04f2d78b
CB
6367 * process.c (Flist_processes): Remove to Lisp.
6368 (list_processes_1): Delete.
e67a13ab 6369
973f782d
EZ
63702011-04-06 Eli Zaretskii <eliz@gnu.org>
6371
7c106b1e
EZ
6372 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6373
973f782d
EZ
6374 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6375
41cf7d1a 63762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6377
ca23cc88
PE
6378 Fix more problems found by GCC 4.6.0's static checks.
6379
f390e2d5
PE
6380 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6381
42eea0d0
PE
6382 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6383
b69769da 6384 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6385
f9541e84
PE
6386 * xdisp.c (vmessage): Mark as a printf-like function.
6387
13841b55
PE
6388 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6389
c136c10f
PE
6390 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6391
5e2d4a30
PE
6392 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6393 printf-like functions.
6394 (tiff_load): Add casts to remove these marks before passing them
6395 to system-supplied API.
6396
583f48b9
PE
6397 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6398
b25d760e
PE
6399 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6400 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6401 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6402 directly, rather than having caller test rule sign. This avoids
6403 some unnecessary tests.
6404 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6405 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6406 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6407
bc7b6697 6408 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6409 (xfont_open): Avoid unnecessary tests.
bc7b6697 6410
27ccc379
PE
6411 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6412
dcd5c89a
PE
6413 * composite.h, composite.c (composition_gstring_put_cache):
6414 Use EMACS_INT, not int, for length.
6415
b13a45c6
PE
6416 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6417 breaking out part of COMPOSITION_DECODE_RULE.
6418 (COMPOSITION_DECODE_RULE): Use it.
6419 * composite.c (get_composition_id): Remove unused local vars,
6420 by using the new macro.
6421
1e792e4d
PE
6422 * textprop.c (set_text_properties_1): Change while to do-while,
6423 since the condition is always true at first.
6424
dc6c6455 6425 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6426 (interval_deletion_adjustment): Return unsigned value.
6427 All uses changed.
dc6c6455 6428
aba7731a
PE
6429 * process.c (list_processes_1, create_pty, read_process_output):
6430 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6431 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6432 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6433 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6434 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6435
fdfc4bf3
PE
6436 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6437
fca8fe46 6438 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6439 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6440
06a0259a 6441 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6442 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6443 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6444
e7b9e80f
PE
6445 * print.c (print_error_message): Avoid int overflow.
6446
56201685
PE
6447 * font.c (font_list_entities): Redo for clarity,
6448 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6449
78834453 6450 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6451 (font_score): Avoid potential overflow in diff calculation.
78834453 6452
0bc0b309 6453 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6454 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6455
e610eaca
PE
6456 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6457
b895abce
PE
6458 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6459 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6460 can always succeed if overflow has undefined behavior.
6461
1f1d9321 6462 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6463 (wordify): Omit three unnecessary tests.
1f1d9321 6464
c59478bc
PE
6465 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6466 All callers changed. This avoids the need for an unused var.
6467
79b73827
PE
6468 * casefiddle.c (casify_region): Remove var that is set but not used.
6469
a4db5dfe
PE
6470 * dired.c (file_name_completion): Remove var that is set but not used.
6471
43aae36e
PE
6472 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6473
2a47c44d 6474 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6475 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6476
a37c69bf
PE
6477 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6478 Check for integer overflow on size calculations.
6479
328ab8e7
PE
6480 * buffer.c (Fprevious_overlay_change): Remove var that is set
6481 but not used.
6482
e5a2a5cb
PE
6483 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6484 Remove vars that are set but not used.
8d84a6eb 6485 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6486 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6487
a60e5f68
PE
6488 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6489
f661cb61 6490 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6491 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6492
f0397f5a
PE
6493 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6494 that are set but not used.
6495
8664db06 6496 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6497 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6498
6abdaa4a
PE
6499 * xselect.c (x_get_local_selection, x_handle_property_notify):
6500 Remove vars that are set but not used.
6501
0ce7538d 6502 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6503 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6504
9ae848fc
PE
6505 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6506 Remove var that is set but not used.
0b918413
PE
6507 (scroll_bar_windows_size): Now size_t, not int.
6508 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6509 Check for overflow.
9ae848fc 6510
a5a62657
PE
6511 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6512 (map_tty_color) [!defined MSDOS]: Likewise.
6513
5c5cdd39
PE
6514 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6515
66ebf983
PE
6516 * coding.c: Remove vars that are set but not used.
6517 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6518 All callers changed.
6519 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6520 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6521 (decode_coding_charset): Remove vars that are set but not used.
6522
1be4d761
PE
6523 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6524 that is set but not used.
6525
47553fa8
PE
6526 * print.c (print_object): Remove var that is set but not used.
6527
1f7196bf 6528 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6529 The gnulib version avoids calling malloc in the usual case,
6530 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6531 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6532 * filelock.c (current_lock_owner): Likewise.
6533 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6534 * sysdep.c: Include allocator.h, careadlinkat.h.
6535 (emacs_no_realloc_allocator): New static constant.
6536 (emacs_readlink): New function.
fdb61804
PE
6537 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6538 ../lib/careadlinkat.h.
d1fdcab7 6539
f84c17c7
SM
65402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6541
6542 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6543 first non-nil return value).
6544
ef3862ad
JD
65452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6546
6547 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6548 if not defined (Bug#8403).
6549
376a7006
JB
65502011-04-02 Juanma Barranquero <lekktu@gmail.com>
6551
6552 * xdisp.c (display_count_lines): Remove parameter `start',
6553 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6554 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6555 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6556 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6557 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6558 and thereabouts. All callers changed.
6559 (get_per_char_metric): Remove parameter `f', unused since
6560 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6561
6ca3801d
JM
65622011-04-02 Jim Meyering <meyering@redhat.com>
6563
6564 do not dereference NULL upon failed strdup
6565 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6566 (ns_get_family): Likewise.
6567
d8e2b5ba
JB
65682011-04-02 Juanma Barranquero <lekktu@gmail.com>
6569
6570 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6571
8c74fcbd
JD
65722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6573
6574 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6575 later (Bug#8403).
6576
7200d79c
SM
65772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6578
03408648 6579 Add lexical binding.
7200d79c 6580
03408648
SM
6581 * window.c (Ftemp_output_buffer_show): New fun.
6582 (Fsave_window_excursion):
6583 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6584
6585 * lread.c (lisp_file_lexically_bound_p): New function.
6586 (Fload): Bind Qlexical_binding.
6587 (readevalloop): Remove `evalfun' arg.
6588 Bind Qinternal_interpreter_environment.
6589 (Feval_buffer): Bind Qlexical_binding.
6590 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6591 Mark as dynamic.
6592 (syms_of_lread): Declare `lexical-binding'.
6593
6594 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6595
6596 * keyboard.c (eval_dyn): New fun.
6597 (menu_item_eval_property): Use it.
ca105506
SM
6598
6599 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6600
03408648
SM
6601 * fns.c (concat, mapcar1): Accept byte-code-functions.
6602
6603 * eval.c (Fsetq): Handle lexical vars.
6604 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6605 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6606 (FletX, Flet): Obey lexical binding.
6607 (Fcommandp): Handle closures.
6608 (Feval): New `lexical' arg.
6609 (eval_sub): New function extracted from Feval. Use it almost
6610 everywhere where Feval was used. Look up vars in lexical env.
6611 Handle closures.
6612 (Ffunctionp): Move from subr.el.
6613 (Ffuncall): Handle closures.
6614 (apply_lambda): Remove `eval_flags'.
6615 (funcall_lambda): Handle closures and new byte-code-functions.
6616 (Fspecial_variable_p): New function.
6617 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6618 but without exporting it to Lisp.
23aba0ea 6619
23aba0ea 6620 * doc.c (Fdocumentation, store_function_docstring):
03408648 6621 * data.c (Finteractive_form): Handle closures.
23aba0ea 6622
03408648
SM
6623 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6624 interactive spec.
ba83908c 6625
04f2d78b
CB
6626 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6627 New byte-codes.
03408648
SM
6628 (exec_byte_code): New function extracted from Fbyte_code to handle new
6629 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6630
03408648 6631 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6632
03408648 6633 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6634
e2abce01
JB
66352011-03-31 Juanma Barranquero <lekktu@gmail.com>
6636
6637 * xdisp.c (redisplay_internal): Fix prototype.
6638
63696a73 66392011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6640
63696a73 6641 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6642 (try_scrolling): Use it when setting scroll_limit.
6643 Limit scrolling to 100 screen lines.
63696a73
EZ
6644 (redisplay_window): Even when falling back on "recentering",
6645 position point in the window according to scroll-conservatively,
6646 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6647
6648 (try_scrolling): When point is above the window, allow searching
6649 as far as scroll_max, or one screenful, to compute vertical
6650 distance from PT to the scroll margin position. This prevents
6651 try_scrolling from unnecessarily failing when
6652 scroll-conservatively is set to a value slightly larger than the
6653 window height. Clean up the case of PT below the margin at bottom
6654 of window: scroll_max can no longer be INT_MAX. When aggressive
6655 scrolling is in use, don't let point enter the opposite scroll
6656 margin as result of the scroll.
6657 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6658 threshold of 100 lines for never-recentering scrolling.
6659
e4cc2dfc
JB
66602011-03-31 Juanma Barranquero <lekktu@gmail.com>
6661
6662 * dispextern.h (move_it_by_lines):
6663 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6664 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6665 (message_log_check_duplicate): Remove parameters `prev_bol' and
6666 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6667 (redisplay_internal): Remove parameter `preserve_echo_area',
6668 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6669
6670 * indent.c (Fvertical_motion):
6671 * window.c (window_scroll_pixel_based, Frecenter):
6672 Don't pass `need_y_p' to `move_it_by_lines'.
6673
1c470562
SM
66742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6675
44f230aa
SM
6676 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6677 steal a few bits to be more compact.
6678 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6679 Remove unneeded casts.
6680
1c470562
SM
6681 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6682
888adce9
ZK
66832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6684
6685 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6686 binding" message (bug#7967).
6687
f838ed7b
PE
66882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6689
77861b95
PE
6690 Fix more problems found by GCC 4.6.0's static checks.
6691
de6dbc14
PE
6692 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6693 Remove unused local var.
6694
f838ed7b
PE
6695 * editfns.c (Fmessage_box): Remove unused local var.
6696
792c7b2b
PE
6697 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6698 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6699 Omit unused local vars.
c499e557 6700 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6701 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6702 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6703 Omit unused local var.
6704
ba0165e1
PE
6705 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6706 Don't assume string length fits in int.
32ad8845 6707 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6708 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6709
3c59b4c9
PE
6710 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6711 instead of alloca (Bug#8344).
6712
a3eed478 6713 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6714 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6715
eb4d412d
PE
6716 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6717
1658b401
PE
6718 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6719 concerns.
6720
6721 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6722
6723 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6724
9a2c6e05
PE
6725 * keyboard.c (syms_of_keyboard): Use the same style as later
6726 in this function when indexing through an array. This also
6727 works around GCC bug 48267.
6728
03d0a109
PE
6729 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6730
44f730c8
PE
6731 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6732
fe75f926
PE
6733 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6734 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6735
ffa8c828
PE
6736 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6737 This avoids undefined behavior on integer overflow, and is a bit
6738 more convenient anyway since it is compared to a size_t variable.
6739
c5101a77
PE
6740 Variadic C functions now count arguments with size_t, not int.
6741 This avoids an unnecessary limitation on 64-bit machines, which
6742 caused (substring ...) to crash on large vectors (Bug#8344).
6743 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6745 All variadic functions and their callers changed accordingly.
c5101a77
PE
6746 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6747 * data.c (arith_driver, float_arith_driver): Likewise.
6748 * editfns.c (general_insert_function): Likewise.
6749 * eval.c (struct backtrace.nargs, interactive_p)
6750 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6751 (funcall_lambda, mark_backtrace): Likewise.
6752 * fns.c (concat): Likewise.
6753 * frame.c (x_set_frame_parameters): Likewise.
6754 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6755 0 if not found, not -1. All callers changed.
6756
dd3f25f7
PE
6757 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6758 (stack_copy_size): Now size_t, not int.
6759 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6760
461c2ab9
JB
67612011-03-28 Juanma Barranquero <lekktu@gmail.com>
6762
6763 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6764 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6765 All callers changed.
6766
6767 * lisp.h (multibyte_char_to_unibyte):
6768 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6769 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6770 * character.h (CHAR_TO_BYTE8):
6771 * cmds.c (internal_self_insert):
6772 * editfns.c (general_insert_function):
6773 * keymap.c (push_key_description):
6774 * search.c (Freplace_match):
6775 * xdisp.c (message_dolog, set_message_1): All callers changed.
6776
f6d62986
SM
67772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6778
6779 * keyboard.c (safe_run_hook_funcall): New function.
6780 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6781 don't set the hook to nil, but remove the offending function instead.
6782 (Qcommand_hook_internal): Remove, unused.
6783 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6784 Vcommand_hook_internal.
6785
6786 * eval.c (enum run_hooks_condition): Remove.
6787 (funcall_nil, funcall_not): New functions.
6788 (run_hook_with_args): Call each function through a `funcall' argument.
6789 Remove `cond' argument, now redundant.
6790 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6791 (Frun_hook_with_args_until_failure): Adjust accordingly.
6792 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6793
1db5b1ad
JB
67942011-03-28 Juanma Barranquero <lekktu@gmail.com>
6795
6796 * dispextern.h (string_buffer_position): Remove declaration.
6797
6798 * print.c (strout): Remove parameter `multibyte', unused since
6799 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6800
6801 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6802 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6803 All callers changed.
6804
6805 * w32.c (_wsa_errlist): Use braces for struct initializers.
6806
6807 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6808 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6809 All callers changed.
6810 (string_buffer_position): Likewise. Also, make static (it's never
6811 used outside xdisp.c).
6812 (cursor_row_p): Remove parameter `w', unused since
6813 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6814 (decode_mode_spec): Remove parameter `precision', introduced during
6815 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6816 All callers changed.
6817
5ffb62aa
JD
68182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6819
6820 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6821
461c2ab9 68222011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6823
6824 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6825 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6826 (ns_update_auto_hide_menu_bar): New functions.
6827 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6828 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6829 ns_constrain_all_frames.
6830 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6831 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6832
5c380ffb
JD
68332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6834
6835 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6836
9af30bdf
GM
68372011-03-27 Glenn Morris <rgm@gnu.org>
6838
6839 * syssignal.h: Replace RETSIGTYPE with void.
6840 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6841 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6842 Replace SIGTYPE with void everywhere.
6843 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6844 * s/template.h (SIGTYPE): Remove commented out definition.
6845
e2abce01
JB
68462011-03-26 Eli Zaretskii <eliz@gnu.org>
6847
6848 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6849 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6850
f868cd8a
JB
68512011-03-26 Juanma Barranquero <lekktu@gmail.com>
6852
59eb0929
JB
6853 * w32.c (read_unc_volume): Use parameter `henum', instead of
6854 global variable `wget_enum_handle'.
6855
6856 * keymap.c (describe_vector): Remove parameters `indices' and
6857 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6858 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6859
f868cd8a
JB
6860 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6861
6862 * keyboard.c (timer_check): Remove parameter `do_it_now',
6863 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6864 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6865 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6866
6867 * keyboard.c (read_char):
6868 * w32menu.c (w32_menu_display_help):
6869 * xmenu.c (show_help_event, menu_help_callback):
6870 Adjust calls to `show_help_echo'.
6871
6872 * gtkutil.c (xg_maybe_add_timer):
6873 * keyboard.c (readable_events):
6874 * process.c (wait_reading_process_output):
6875 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6876
6877 * insdel.c (adjust_markers_gap_motion):
6878 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6879 (gap_left, gap_right): Don't call it.
6880
2ecf6fdb
CY
68812011-03-25 Chong Yidong <cyd@stupidchicken.com>
6882
6883 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6884 incurred during fontification.
6885
6b1f9ba4
JB
68862011-03-25 Juanma Barranquero <lekktu@gmail.com>
6887
6888 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6889 (DEFVAR_PER_BUFFER): Don't pass it.
6890
6891 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6892 (scrolling_window): Don't pass it.
6893
0f4a96b5
JB
68942011-03-25 Juanma Barranquero <lekktu@gmail.com>
6895
6896 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6897
6898 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6899 and `suffix'.
6900 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6901 of variables specific to SELinux and computation of `encoded_absname'.
6902
6903 * image.c (XPutPixel): Remove unused variable `height'.
6904
6905 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6906
6907 * unexw32.c (get_section_info): Remove unused variable `section'.
6908
6909 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6910 (system_process_attributes): Remove unused variable `sess'.
6911 (sys_read): Remove unused variable `err'.
6912
6913 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6914 (w32_wnd_proc): Remove unused variable `isdead'.
6915 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6916 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6917 (x_create_tip_frame): Remove unused variable `tem'.
6918
6919 * w32inevt.c (w32_console_read_socket):
6920 Remove unused variable `no_events'.
6921
6922 * w32term.c (x_draw_composite_glyph_string_foreground):
6923 Remove unused variable `width'.
6924
1149507c
JB
69252011-03-24 Juanma Barranquero <lekktu@gmail.com>
6926
6927 * w32term.c (x_set_glyph_string_clipping):
6928 Don't pass uninitialized region to CombineRgn.
6929
9c88f339
JB
69302011-03-23 Juanma Barranquero <lekktu@gmail.com>
6931
6932 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6933 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6934 (Fx_close_connection): Remove unused variable `i'.
6935
6936 * w32font.c (w32font_draw): Return number of glyphs.
6937 (w32font_open_internal): Remove unused variable `i'.
6938 (w32font_driver): Add missing initializer.
6939
6940 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6941 (fill_in_menu): Remove unused variable `items_added'.
6942
6943 * w32term.c (last_mouse_press_frame): Remove static global variable.
6944 (w32_clip_to_row): Remove unused variable `f'.
6945 (x_delete_terminal): Remove unused variable `i'.
6946
6947 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6948 (NOTHING): Remove unused static global variable.
6949 (uniscribe_check_otf): Remove unused variable `table'.
6950 (uniscribe_font_driver): Add missing initializers.
6951
dee091a3
JD
69522011-03-23 Julien Danjou <julien@danjou.info>
6953
6954 * term.c (Fsuspend_tty, Fresume_tty):
6955 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6956 * window.c (temp_output_buffer_show):
6957 * insdel.c (signal_before_change):
6958 * frame.c (Fhandle_switch_frame):
6959 * fileio.c (Fdo_auto_save):
6960 * emacs.c (Fkill_emacs):
6961 * editfns.c (save_excursion_restore):
6962 * cmds.c (internal_self_insert):
6963 * callint.c (Fcall_interactively):
6964 * buffer.c (Fkill_all_local_variables):
6965 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6966 Use Frun_hooks.
0f4a96b5 6967 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6968 unconditionnaly since it does the check itself.
6969
2c520ab5 69702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6971
c9c49752
PE
6972 Fix more problems found by GCC 4.5.2's static checks.
6973
8abc3f12
PE
6974 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6975 the first time through the loop, since we know p0 < p1 then.
6976 This also avoids a gcc -Wstrict-overflow warning.
6977
a2d26660
PE
6978 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6979 leading to a memory leak, possible in functions like
6980 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6981 of objects (Bug#8318).
a2d26660 6982
916c72e9
PE
6983 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6984 that could (at least in theory) be that large.
6985
19ab8a18
PE
6986 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6987 This is less likely to overflow, and avoids undefined behavior if
6988 overflow does occur. All callers changed. Use strtoul to scan
6989 for the unsigned long integer.
b7cbbd6f
PE
6990 (pint2hrstr): Simplify and tune code slightly.
6991 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6992
f0641eff
PE
6993 * scroll.c (do_scrolling): Work around GCC bug 48228.
6994 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6995
7f650bb9
PE
6996 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6997 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6998 (validate_x_resource_name): Simplify count usage.
6999 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7000
37dd57d1
PE
7001 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7002 fail (Bug#8306).
81e56e61 7003
699979fc 7004 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7005
401bf9b4
PE
7006 * process.c (Fmake_network_process): Use socklen_t, not int,
7007 where POSIX says socklen_t is required in portable programs.
7008 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7009 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7010 (Fmake_network_process, server_accept_connection):
7011 (wait_reading_process_output, read_process_output):
7012 Likewise.
7013
b93aacde
PE
7014 * process.c: Rename or move locals to avoid shadowing.
7015 (list_processes_1, Fmake_network_process):
7016 (read_process_output_error_handler, exec_sentinel_error_handler):
7017 Rename or move locals.
4dc343ee 7018 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7019 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7020 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7021 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7022 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7023
af8a867c 7024 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7025 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7026 Include tparam.h instead, since it declares them.
af8a867c
PE
7027 * cm.h (PC): Remove extern decl; tparam.h now does this.
7028 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7029 * terminfo.c: Include tparam.h, to check interfaces.
7030 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7031 (tparam): Adjust signature to match interface in tparam.h;
7032 this removes some undefined behavior. Check that outstring and len
7033 are zero, which they always are with Emacs.
7034 * tparam.h (PC, BC, UP): New extern decls.
7035
0248044d 7036 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7037 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7038
8ff096c1 7039 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7040 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7041 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7042 (ftfont_list): Remove unused local.
49eaafba
PE
7043 (get_adstyle_property, ftfont_pattern_entity):
7044 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7045 Rename locals to avoid shadowing.
8ff096c1 7046
e2be39f6
PE
7047 * xfont.c (xfont_list_family): Mark var as initialized.
7048
c9735e30
PE
7049 * xml.c (make_dom): Now static.
7050
8f5201ae
PE
7051 * composite.c (composition_compute_stop_pos): Rename local to
7052 avoid shadowing.
b246f932
PE
7053 (composition_reseat_it): Remove unused locals.
7054 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7055 (composition_update_it): Mark var as initialized.
11b61122
PE
7056 (find_automatic_composition): Mark vars as initialized,
7057 with a FIXME (Bug#8290).
8f5201ae 7058
760fbc2c
PE
7059 character.h: Rename locals to avoid shadowing.
7060 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7061 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7062 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7063 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7064 to avoid shadowing.
7065
ff08eb85
PE
7066 * textprop.c (property_change_between_p): Remove; unused.
7067
fc7bf025
PE
7068 * intervals.c (interval_start_pos): Now static.
7069
235d7abc
PE
7070 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7071
44f230aa
SM
7072 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7073 Rename locals to avoid shadowing.
3e7d6594 7074
50060332
PE
7075 * sound.c (wav_play, au_play, Fplay_sound_internal):
7076 Fix pointer signedness.
d01f234b 7077 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7078 (wav_play): Initialize a variable to 0, to prevent undefined
7079 behavior (Bug#8278).
50060332 7080
c4fc4e30
PE
7081 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7082
918436ed
PE
7083 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7084
c939f91b
PE
7085 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7086 clobbering (Bug#8298).
b9c7f648
PE
7087 * sysdep.c (sys_subshell): Likewise.
7088 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7089
6bd8c144
PE
7090 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7091 This should get cleaned up, so that child_setup has the
7092 same signature on all platforms.
7093
7710357c 7094 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7095 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7096
c59da222
CY
70972011-03-22 Chong Yidong <cyd@stupidchicken.com>
7098
7099 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7100 not to be necessary, and produces flickering.
7101
66b87493
GM
71022011-03-20 Glenn Morris <rgm@gnu.org>
7103
7104 * config.in: Remove file.
7105
45b6f6d5
JB
71062011-03-20 Juanma Barranquero <lekktu@gmail.com>
7107
7108 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7109 are now in src/globals.h.
7110 (syms_of_minibuf): Remove spurious & from previous change.
7111
3ec03f7e
LL
71122011-03-20 Leo <sdl.web@gmail.com>
7113
7114 * minibuf.c (completing-read-function): New variable.
7115 (completing-read-default): Rename from completing-read.
7116 (completing-read): Call completing-read-function.
7117
b14e3e21
CY
71182011-03-19 Juanma Barranquero <lekktu@gmail.com>
7119
7120 * xfaces.c (Fx_load_color_file):
7121 Read color file from absolute filename (bug#8250).
7122
f2b726e6
JB
71232011-03-19 Juanma Barranquero <lekktu@gmail.com>
7124
7125 * makefile.w32-in: Update dependencies.
7126
09f6ff02
EZ
71272011-03-17 Eli Zaretskii <eliz@gnu.org>
7128
7129 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7130
29a6015a
PE
71312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7132
a3a6c54e
PE
7133 Fix more problems found by GCC 4.5.2's static checks.
7134
b766f867
PE
7135 * process.c (make_serial_process_unwind, send_process_trap):
7136 (sigchld_handler): Now static.
7137
be02381c
PE
7138 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7139 That way, the code declares only the vars that it needs.
7140 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7141 * s/cygwin.h (PTY_ITERATION): Likewise.
7142 * s/darwin.h (PTY_ITERATION): Likewise.
7143 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7144
57048744
PE
7145 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7146 * process.c (allocate_pty): Don't declare stb unless it's needed.
7147
7914961c 7148 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7149 (CONSTANTLIM): Remove; unused.
7150 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7151 Define only if needed.
7914961c 7152
b3967b18
PE
7153 * unexelf.c (unexec): Name an expression,
7154 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7155 Use a different way to cause a compilation error if anyone uses
7156 n rather than nn, a way that does not involve shadowing.
73366a00 7157 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7158
29a6015a
PE
7159 * deps.mk (unexalpha.o): Remove; unused.
7160
43cfc33e 7161 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7162 * unexec.h: New file.
ce701a33
PE
7163 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7164 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7165 Depend on unexec.h.
7166 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7167 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7168 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7169 Change as necessary to match prototype in unexec.h.
ce701a33 7170
01f44d5a
PE
7171 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7172 shadowing.
4f63c6bb 7173 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7174
a6670b0b
PE
7175 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7176 Rename locals to avoid shadowing.
7177
cef2010d 7178 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7179 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7180
d4d7173a
PE
7181 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7182
f08b802a
PE
7183 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7184 warning when compiling print.c.
7185
3ddb0639
PE
7186 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7187 instead of using an uninitialized var.
5ad03b97 7188 (font_sort_entities): Mark var as initialized.
3ddb0639 7189
170a2692
PE
7190 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7191
e663c700
PE
7192 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7193 pointers to constants.
89bc529a 7194 (font_parse_fcname): Remove unused vars.
7b81e2d0 7195 (font_delete_unmatched): Now static.
ea838e10 7196 (font_get_spec): Remove; unused.
13a547c6
PE
7197 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7198 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7199 Rename or move locals to avoid shadowing.
e663c700 7200
2a80c887 7201 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7202 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7203
1384fa33 7204 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7205 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7206
8b2c52e9
PE
7207 * alloc.c (mark_backtrace): Move decl from here ...
7208 * lisp.h: ... to here, so that it can be checked.
7209
475545b5 7210 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7211 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7212 (lisp_indirect_variable): Name an expression,
7213 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7214 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7215
b1349114 7216 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7217 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7218 Use const pointer when appropriate.
b1349114 7219
a2928364
PE
7220 * lisp.h (get_system_name, get_operating_system_release):
7221 Move decls here, to check interfaces.
7222 * process.c (get_operating_system_release): Move decl to lisp.h.
7223 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7224 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7225 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7226 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7227 (Fformat_time_string, Fencode_time, Finsert_char):
7228 (Ftranslate_region_internal, Fformat):
7229 Rename or remove local vars to avoid shadowing.
9710023e 7230 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7231
a415e694
PE
7232 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7233 avoid shadowing.
7234
8ef4622d
PE
7235 * lisp.h (eassert): Check that the argument compiles, even if
7236 ENABLE_CHECKING is not defined.
7237
946f9a5b
PE
7238 * data.c (Findirect_variable): Name an expression, to avoid
7239 gcc -Wbad-function-cast warning.
112396d6 7240 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7241 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7242 (Fmake_variable_buffer_local, Fmake_local_variable):
7243 Mark variables as initialized.
52746918 7244 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7245
e5aab7e7 7246 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7247 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7248 Rename locals to avoid shadowing.
dff45157
PE
7249 (mark_stack): Move local variables into the #ifdef region where
7250 they're used.
7bc26fdb
PE
7251 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7252 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7253 needed otherwise.
7254 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7255 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7256 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7257
e5aab7e7
PE
7258 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7259 avoids undefined behavior in theory.
7260
4da60324
PE
7261 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7262
88043301
PE
7263 Use functions, not macros, for up- and down-casing (Bug#8254).
7264 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7265 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7266 to use the following functions instead of these macros.
7267 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7268 EMACS_INT, since callers assume the returned value fits in int.
7269 (upcase1): Likewise, for UPCASE_TABLE.
7270 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7271 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7272 the race-condition problem in the old DOWNCASE.
88043301 7273
19ed5445
PE
7274 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7275 Rename locals to avoid shadowing.
7276 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7277 (regex_compile, re_search_2, re_match_2_internal):
7278 Remove unused local vars.
952db0d7
PE
7279 (FREE_VAR): Rewrite so as not to use empty "else",
7280 which gcc can warn about.
da053e48 7281 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7282 (RETALLOC_IF): Define only if needed.
7283 (WORDCHAR_P): Likewise. This one is never needed, but is used
7284 only in a comment talking about a compiler bug, so put inside
7285 the #if 0 of that comment.
7286 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7287 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7288 Remove; unused.
19ed5445 7289
1f3561e4 7290 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7291 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7292 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7293
ded6f8f7
PE
7294 * search.c (simple_search): Remove unused var.
7295
dbd37a95
PE
7296 * dired.c (compile_pattern): Move decl from here ...
7297 * lisp.h: ... to here, so that it can be checked.
7298 (struct re_registers): New forward decl.
7299
7e47afad
PE
7300 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7301
85f24f61
PE
7302 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7303 All uses changed.
7304 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7305 Rename locals to avoid shadowing.
5671df8f 7306 (Fvertical_motion): Mark locals as initialized.
85f24f61 7307
181aa2be 7308 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7309 (casify_region): Mark local as initialized.
181aa2be 7310
930d429c
PE
7311 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7312
7082eac6
PE
7313 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7314 New macros, so that the caller can use some names other than
7315 gcpro1, gcpro2, etc.
7316 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7317 of the new macros.
7318 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7319 argument, for consistency with GCPRO2_VAR, etc: it is now the
7320 prefix of the variable, not the variable itself. All uses
7321 changed.
38b2c076
PE
7322 * dired.c (directory_files_internal, file_name_completion):
7323 Rename locals to avoid shadowing.
7324
15206ed9
PE
7325 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7326 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7327 dired.c's scmp function, had undefined behavior.
7328 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7329 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7330 * buffer.h: ... to here, because these macros use current_buffer,
7331 and the new implementation with inline functions needs to have
7332 current_buffer in scope now, rather than later when the macros
7333 are used.
7334 (downcase, upcase1): New static inline functions.
7335 (DOWNCASE, UPCASE1): Reimplement using these functions.
7336 This avoids undefined behavior in expressions like
7337 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7338 from race conditions in accessing the global variables
7339 case_temp1 and case_temp2.
7340 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7341 * lisp.h (case_temp1, case_temp2): Remove their decls.
7342 * character.h (ASCII_CHAR_P): Move from here ...
7343 * lisp.h: ... to here, so that the inline functions mentioned
7344 above can use them.
7345
4a6bea26
PE
7346 * dired.c (directory_files_internal_unwind): Now static.
7347
f14b7e14
PE
7348 * fileio.c (file_name_as_directory, directory_file_name):
7349 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7350 Now static.
2893f146
PE
7351 (file_name_as_directory): Use const pointers when appropriate.
7352 (Fexpand_file_name): Likewise. In particular, newdir might
7353 point at constant storage, so make it a const pointer.
fd4ead52 7354 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7355 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7356 signedness issues.
f839df0c
PE
7357 (Fset_file_times, Finsert_file_contents, auto_save_error):
7358 Rename locals to avoid shadowing.
f14b7e14 7359
5716756e 7360 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7361 (Ftry_completion, Fall_completions): Rename or remove locals
7362 to avoid shadowing.
5716756e 7363
b4c3046a
PE
7364 * marker.c (bytepos_to_charpos): Remove; unused.
7365
b45db522
PE
7366 * lisp.h (verify_bytepos, count_markers): New decls,
7367 so that gcc does not warn that these functions aren't declared.
7368
85876d07
PE
7369 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7370 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7371 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7372 (copy_text): Remove unused local var.
85876d07 7373
03d78a21 7374 * filelock.c (within_one_second): Now static.
b3dd38ab 7375 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7376
5df8f01b
PE
7377 * buffer.c (fix_overlays_before): Mark locals as initialized.
7378 (fix_start_end_in_overlays): Likewise. This function should be
7379 simplified by using pointers-to-pointers, but that's a different
7380 matter.
b1d876f1 7381 (switch_to_buffer_1): Now static.
8f54f30a
PE
7382 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7383 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7384
a70072c9 7385 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7386 Fix pointer signedness issue.
edced198
PE
7387 (sys_subshell): Mark local as volatile if checking for lint,
7388 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7389 (MAXPATHLEN): Define only if needed.
a70072c9 7390
a0977c44
PE
7391 * process.c (serial_open, serial_configure): Move decls from here ...
7392 * systty.h: ... to here, so that they can be checked.
7393
a884fdcc
PE
7394 * fns.c (get_random, seed_random): Move extern decls from here ...
7395 * lisp.h: ... to here, so that they can be checked.
7396
604efe86 7397 * sysdep.c (reset_io): Now static.
b8950c94 7398 (wait_for_termination_signal): Remove; unused.
604efe86 7399
38fc62d9
PE
7400 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7401 (copy_keymap_item, append_key, push_text_char_description):
7402 Now static.
1004a21a 7403 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7404 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7405 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7406 (describe_map_tree):
7407 Rename locals to avoid shadowing.
38fc62d9 7408
2f2650da
PE
7409 * keyboard.c: Declare functions static if they are not used elsewhere.
7410 (echo_char, echo_dash, cmd_error, top_level_2):
7411 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7412 (read_char, kbd_buffer_get_event, make_lispy_position):
7413 (make_lispy_event, make_lispy_movement, apply_modifiers):
7414 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7415 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7416 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7417 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7418 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7419
a053e86c 7420 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7421 (mark_kboards): Move decl here ...
7422 * alloc.c (mark_kboards): ... from here.
a053e86c 7423
4752793e
PE
7424 * lisp.h (force_auto_save_soon): New decl.
7425
74f10ca7 7426 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7427 (DEFINE_DUMMY_FUNCTION): New macro.
7428 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7429 Use it.
c03cd23f
PE
7430 (main): Add casts to avoid warnings
7431 if GCC considers string literals to be constants.
74f10ca7 7432
022e70d4
PE
7433 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7434
59d6fe83
PE
7435 * dbusbind.c: Pointer signedness fixes.
7436 (xd_signature, xd_append_arg, xd_initialize):
7437 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7438 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7439 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7440 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7441
78320123
PE
7442 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7443 if GCC considers string literals to be constants.
49cebcca 7444 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7445
35ac2a97
SM
74462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7447
fb103ca9
SM
7448 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7449 (print_preprocess, print_object): New macro to fix last change.
7450
35ac2a97
SM
7451 * print.c (print_preprocess): Don't forget font objects.
7452
62973b41
JB
74532011-03-16 Juanma Barranquero <lekktu@gmail.com>
7454
7455 * emacs.c (USAGE3): Doc fixes.
7456
0e48bb22
AS
74572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7458
7459 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7460 structure.
7461
7684e57b
JB
74622011-03-14 Juanma Barranquero <lekktu@gmail.com>
7463
7464 * lisp.h (VWindow_system, Qfile_name_history):
7465 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7466 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7467 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7468
7469 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7470 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7471
7472 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7473 * w32console.c (detect_input_pending, read_input_pending)
7474 (encode_terminal_code):
7475 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7476 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7477 (w32_system_caret_y, Qfile_name_history):
7478 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7479 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7480 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7481 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7482 * w32proc.c (Qlocal, report_file_error):
7483 * w32term.c (Vwindow_system, updating_frame):
7484 * w32uniscribe.c (initialized, uniscribe_font_driver):
7485 Remove unneeded extern declarations.
7486
2aa46d6c
CY
74872011-03-14 Chong Yidong <cyd@stupidchicken.com>
7488
c96bbc66 7489 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7490
cffc6f3b
CY
74912011-03-13 Chong Yidong <cyd@stupidchicken.com>
7492
7493 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7494 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7495 These macros can no longer be used for assignment.
7496
44f230aa
SM
7497 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7498 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7499 (record_buffer_markers, fetch_buffer_markers): New functions for
7500 recording and fetching special buffer markers.
7501 (set_buffer_internal_1, set_buffer_temp): Use them.
7502
7503 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7504
7505 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7506
7507 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7508 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7509
7510 * xdisp.c (hscroll_window_tree):
7511 (reconsider_clip_changes): Use PT instead of BUF_PT.
7512
d251f04b
EZ
75132011-03-13 Eli Zaretskii <eliz@gnu.org>
7514
7515 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7516 $(EMACS_ROOT)/lib/intprops.h.
7517
f0c77cd1
PE
75182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7519
3eca4629
PE
7520 Fix more problems found by GCC 4.5.2's static checks.
7521
7c86ee98
PE
7522 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7523 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7524 (xg_free_frame_widgets): Make it clear that a local variable is
7525 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7526 (gdk_window_get_screen): Make it clear that this macro is needed
7527 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7528 (int_gtk_range_get_value): New function, which avoids a diagnostic
7529 from gcc -Wbad-function-cast.
7530 (xg_set_toolkit_scroll_bar_thumb): Use it.
7531 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7532 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7533 (get_utf8_string, xg_get_file_with_chooser):
7534 Rename locals to avoid shadowing.
7535 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7536
41729b81
PE
7537 * xgselect.c (xg_select): Remove unused var.
7538
f0c77cd1
PE
7539 * image.c (four_corners_best): Mark locals as initialized.
7540 (gif_load): Initialize transparent_p to zero (Bug#8238).
7541 Mark another local as initialized.
ec6cf4c6 7542 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7543
ce0ad53d 7544 * image.c (clear_image_cache): Now static.
d5d5a617 7545 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7546 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7547 (x_edge_detection): Remove unnecessary cast that
7548 gcc -Wbad-function-cast diagnoses.
2037898d 7549 (gif_load): Fix pointer signedness.
6ae141d6
PE
7550 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7551 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7552
33383987 75532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7554
d32df629
PE
7555 Improve quality of tests for time stamp overflow.
7556 For example, without this patch (encode-time 0 0 0 1 1
7557 1152921504606846976) returns the obviously-bogus value (-948597
7558 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7559 reports time overflow. See
7560 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7561 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7562 * editfns.c: Include limits.h and intprops.h.
7563 (TIME_T_MIN, TIME_T_MAX): New macros.
7564 (time_overflow): Move earlier, to before first use.
7565 (hi_time, lo_time): New functions, for an accurate test for
7566 out-of-range times.
7567 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7568 (Fget_internal_run_time): Don't assume time_t fits in int.
7569 (make_time): Use list2 instead of Fcons twice.
7570 (Fdecode_time): More accurate test for out-of-range times.
7571 (check_tm_member): New function.
7572 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7573 (lisp_time_argument): Don't rely on undefined left-shift and
7574 right-shift behavior when checking for time stamp overflow.
8be6f318 7575
fe31d94c
PE
7576 * editfns.c (time_overflow): New function, refactoring common code.
7577 (Fformat_time_string, Fdecode_time, Fencode_time):
7578 (Fcurrent_time_string): Use it.
7579
8be6f318
PE
7580 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7581 * dired.c (make_time): Move to ...
7582 * editfns.c (make_time): ... here.
7583 * systime.h: Note the move.
7584
09d9db2c 75852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7586
126bc0dc
YM
7587 * fringe.c (update_window_fringes): Remove unused variables.
7588
c47cbdfd
YM
7589 * unexmacosx.c (copy_data_segment): Also copy __got section.
7590 (Bug#8223)
7591
7ac80be9
EZ
75922011-03-12 Eli Zaretskii <eliz@gnu.org>
7593
c96bbc66 7594 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7595 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7596 Constify `char *' arguments and their references according to
7597 prototypes in tparam.h.
7598
ecb0f94d 7599 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7600
7ac80be9
EZ
7601 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7602 Adapt all references accordingly.
7603
7604 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7605
ef1fd07e
TT
76062011-03-11 Tom Tromey <tromey@redhat.com>
7607
7608 * buffer.c (syms_of_buffer): Remove obsolete comment.
7609
7ef4b50c
EZ
76102011-03-11 Eli Zaretskii <eliz@gnu.org>
7611
7612 * termhooks.h (encode_terminal_code): Declare prototype.
7613
7614 * msdos.c (encode_terminal_code): Don't declare prototype.
7615
7616 * term.c (encode_terminal_code): Now external again, used by
7617 w32console.c and msdos.c.
7618
44f230aa
SM
7619 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7620 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7621
4b1ec863 76222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7623
1714f52b 7624 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7625
4b1ec863
PE
7626 * fringe.c (update_window_fringes): Mark locals as initialized
7627 (Bug#8227).
7628 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7629
524c7aa6
PE
7630 * alloc.c (mark_fringe_data): Move decl from here ...
7631 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7632 to check its interface.
7633 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7634
a5c0af81 7635 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7636 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7637 (fontset_font): Mark local as initialized.
a9a06e0b 7638 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7639
b4716021
PE
7640 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7641
811e9bac 7642 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7643 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7644 (x_own_selection, Fx_disown_selection_internal): Rename locals
7645 to avoid shadowing.
7646 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7647
7e3ab302
PE
7648 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7649 so that the caller can use some name other than gcpro1.
7650 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7651 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7652 (Fx_backspace_delete_keys_p):
7653 Use them to avoid shadowing, and rename vars to avoid shadowing.
7654 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7655 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7656 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7657 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7658 Remove unused locals.
7e3ab302
PE
7659 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7660 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7661 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7662 macros.
f78faa98 7663
e2b13473
PE
7664 * xterm.h (x_mouse_leave): New decl.
7665
77f23912
PE
7666 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7667 Remove unused functions.
cdf4ba58
PE
7668 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7669 (x_calc_absolute_position): Now static.
7411c686 7670 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7671 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7672 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7673 unless they are used.
38d0b34a
PE
7674 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7675 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7676 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7677 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7678 (x_error_catcher, x_connection_closed, x_error_handler):
7679 (x_error_quitter, xembed_send_message, x_iconify_frame):
7680 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7681 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7682 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7683
44f230aa
SM
7684 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7685 Rename or move locals to avoid shadowing.
6b463e58 7686 (tty_defined_color, merge_face_heights): Now static.
5967d051 7687 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7688 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7689 does not deduce is never used uninitialized.
73719eba
PE
7690 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7691 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7692
426994c3 7693 * terminal.c (store_terminal_param): Now static.
5489860b 7694
032f1620 7695 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7696 (set_frame_menubar): Remove unused local.
d4323972 7697 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7698 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7699 since they might point to immutable storage.
281585b0
PE
7700 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7701 since it's unused otherwise.
032f1620 7702
367c19e5 7703 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7704 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7705 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7706 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7707 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7708 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7709 does not deduce are never used uninitialized.
70739cbe 7710
07b48fa9
PE
7711 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7712
8868a238 7713 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7714 * window.c (window_loop, size_window):
7715 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7716
7e5cf297 7717 * window.c (display_buffer): Now static.
d6550a9f
PE
7718 (size_window): Mark variables that gcc -Wuninitialized
7719 does not deduce are never used uninitialized.
a586633d
PE
7720 * window.h (check_all_windows): New decl, to forestall
7721 gcc -Wmissing-prototypes diagnostic.
5b555da1 7722 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7723
f6095868
PE
7724 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7725 shadowing.
7726 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7727 Include <limits.h>.
7728 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7729 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7730 (load_charset_map): Mark variables that gcc -Wuninitialized
7731 does not deduce are never used uninitialized.
53df7c11 7732 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7733
f38b440c
PE
7734 * coding.c (coding_set_source, coding_set_destination):
7735 Use "else { /* comment */ }" rather than "else /* comment */;"
7736 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7737 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7738 a block, when the outer 'i' will do.
7739 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7740 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7741 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7742 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7743 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7744 Rename locals to avoid shadowing.
7745 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7746 * coding.c (emacs_mule_char, encode_invocation_designation):
7747 Now static, since they're not used elsewhere.
413bb2db 7748 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7749 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7750 (decode_coding_emacs_mule): Mark variables that gcc
7751 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7752 (detect_coding_iso_2022): Initialize a local variable that might
7753 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7754 this initialization is needed. (Bug#8211)
5f58e762
PE
7755 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7756 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7757 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7758 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7759 Remove unused macros.
f38b440c 7760
232b38b9 7761 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7762 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7763 * character.c (string_count_byte8): Likewise.
232b38b9 7764
fb90da1b
PE
7765 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7766 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7767
fb93dbc2
PE
7768 * chartab.c (copy_sub_char_table): Now static, since it's not used
7769 elsewhere.
5c156ace
PE
7770 (sub_char_table_ref_and_range, char_table_ref_and_range):
7771 Rename locals to avoid shadowing.
bbcd0949 7772 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7773
7d3b3862 7774 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7775 (BIDI_BOB): Remove unused macro.
7d3b3862 7776
6be7d3da
PE
7777 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7778 deduce are never used uninitialized.
c2ed9c8b 7779 * term.c (encode_terminal_code): Likewise.
6be7d3da 7780
75f8807f 7781 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7782
50938595
PE
7783 * tparam.h: New file.
7784 * term.c, tparam.h: Include it.
7785 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7786 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7787 Move these decls to tparam.h, and make them agree with what
7788 is actually in tparam.c. The previous trick of using incompatible
7789 decls in different modules does not conform to the C standard.
7790 All callers of tparam changed to use tparam's actual API.
7791 * tparam.c (tparam1, tparam, tgoto):
7792 Use const pointers where appropriate.
7793
fbceeba2
PE
7794 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7795 * cm.h (struct cm): Likewise.
7796 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7797 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7798 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7799 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7800 (turn_on_face, init_tty): Likewise.
7801 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7802
7f3f1250
PE
7803 * term.c (term_mouse_position): Rename local to avoid shadowing.
7804
e6ca6543
PE
7805 * alloc.c (mark_ttys): Move decl from here ...
7806 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7807
c40f8d15
AS
78082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7809
7810 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7811
cfe0661d
JB
78122011-03-09 Juanma Barranquero <lekktu@gmail.com>
7813
7814 * search.c (compile_pattern_1): Remove argument regp, unused since
7815 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7816 (compile_pattern): Don't pass it.
7817
0afb4571
J
78182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7819
7820 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7821 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7822 for ! HAVE_GTK3.
7823 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7824
7825 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7826
7827 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7828 gdk_window_get_screen, gdk_window_get_geometry,
7829 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7830 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7831 (xg_get_pixbuf_from_pixmap): New function.
7832 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7833 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7834 Call xg_get_pixbuf_from_pixmap instead of
7835 gdk_pixbuf_get_from_drawable.
7836 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7837 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7838 (xg_check_special_colors): Use GtkStyleContext and its functions
7839 for HAVE_GTK3.
7840 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7841 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7842 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7843 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7844 Call gtk_widget_get_preferred_size.
0afb4571
J
7845 (xg_frame_resized): gdk_window_get_geometry only takes 5
7846 parameters.
44f230aa
SM
7847 (xg_win_to_widget, xg_event_is_for_menubar):
7848 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7849 (xg_set_widget_bg): New function.
7850 (delete_cb): New function.
895009e1 7851 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7852 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7853 (xg_set_background_color): Call xg_set_widget_bg.
7854 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7855 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7856 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7857 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7858 if ! HAVE_GTK3.
7859 (update_frame_tool_bar): Call gtk_widget_hide.
7860 (xg_initialize): Use GDK_KEY_g.
7861
7862 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7863 if ! HAVE_GTK3
7864 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7865
7866 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7867 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7868 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7869
1c2cc4ef
JB
78702011-03-08 Juanma Barranquero <lekktu@gmail.com>
7871
7872 * w32xfns.c (select_palette): Check success of RealizePalette against
7873 GDI_ERROR, not zero.
7874
33383987 7875See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7876
7877;; Local Variables:
7878;; coding: utf-8
aac0c6e3
MR
7879;; End:
7880
33383987 7881 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7882
7883 This file is part of GNU Emacs.
7884
7885 GNU Emacs is free software: you can redistribute it and/or modify
7886 it under the terms of the GNU General Public License as published by
7887 the Free Software Foundation, either version 3 of the License, or
7888 (at your option) any later version.
7889
7890 GNU Emacs is distributed in the hope that it will be useful,
7891 but WITHOUT ANY WARRANTY; without even the implied warranty of
7892 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7893 GNU General Public License for more details.
7894
7895 You should have received a copy of the GNU General Public License
7896 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.